bfd/ChangeLog

   1 2021-02-15  Alan Modra  <amodra@gmail.com>
   2
   3         * coff-alpha.c (alpha_ecoff_get_relocated_section_contents): Use
   4         bfd_get_full_section_contents.
   5
   6 2021-02-14  Alan Modra  <amodra@gmail.com>
   7
   8         * elfxx-mips.c (_bfd_elf_mips_get_relocated_section_contents): Apply
   9         all fixes to bfd_generic_get_relocated_section_contents since this
  10         function was split out.
  11
  12 2021-02-11  Alan Modra  <amodra@gmail.com>
  13
  14         * config.bfd: Remove ia64 from obsolete list.
  15
  16 2021-02-11  Alan Modra  <amodra@gmail.com>
  17
  18         PR ld/22269
  19         * elfnn-ia64.c: Revert 2017-10-14 git commit db41f6eb5234.
  20
  21 2021-02-11  Alan Modra  <amodra@gmail.com>
  22
  23         PR 27294
  24         * elf32-avr.c (avr_elf32_load_records_from_section): Use
  25         bfd_malloc_and_get_section.  Use bfd_byte* vars and remove then
  26         unnecessary casts.
  27
  28 2021-02-11  Alan Modra  <amodra@gmail.com>
  29
  30         PR 27291
  31         * section.c (bfd_get_section_contents): Avoid possible overflow
  32         when range checking offset and count.
  33         (bfd_set_section_contents): Likewise.
  34
  35 2021-02-03  Nick Alcock  <nick.alcock@oracle.com>
  36
  37         * configure.ac (SHARED_LIBADD): Remove explicit -lintl population in
  38         favour of LIBINTL.
  39         * configure: Regenerated.
  40
  41 2021-02-09  Alan Modra  <amodra@gmail.com>
  42
  43         * config.bfd (arm*-*-symbianelf*): Move from obsolete to removed.
  44         * configure.ac: Delete symbian entries.
  45         * elf-bfd.h (enum elf_target_os): Delete is_symbian.
  46         * elf32-arm.c: Remove symbian support.  Formatting.
  47         * targets.c: Delete symbian entries.
  48         * configure: Regenerate.
  49
  50 2021-02-04  H.J. Lu  <hongjiu.lu@intel.com>
  51
  52         PR ld/19609
  53         * elf64-x86-64.c (elf_x86_64_relocate_section): Provide more
  54         info when failed to convert GOTPCREL relocation.
  55
  56 2021-02-04  Nelson Chu  <nelson.chu@sifive.com>
  57
  58         * elfxx-riscv.c (riscv_parse_prefixed_ext): Removed zb*.
  59
  60 2021-02-04  Alan Modra  <amodra@gmail.com>
  61
  62         PR 27311
  63         * elflink.c (elf_link_add_object_symbols): Don't pull in as-needed
  64         libraries for IR references on pass over libraries after LTO
  65         recompilation.
  66
  67 2021-02-03  Alan Modra  <amodra@gmail.com>
  68
  69         PR 27311
  70         * elflink.c (_bfd_elf_add_default_symbol): Revert last two changes.
  71         (elf_link_add_object_symbols): Here too.  Don't pull in as-needed
  72         libraries when H is an indirect symbol after calling
  73         _bfd_elf_add_default_symbol.
  74
  75 2021-02-03  Alan Modra  <amodra@gmail.com>
  76
  77         PR 27311
  78         * elflink.c (_bfd_elf_add_default_symbol): Clear override when
  79         undecorated symbol will have a different version.
  80
  81 2021-02-02  Alan Modra  <amodra@gmail.com>
  82
  83         PR 27311
  84         * elflink.c (_bfd_elf_add_default_symbol): Add override parameter.
  85         Use when handling default versioned symbol.  Rename existing
  86         override variable to nondef_override and use for non-default
  87         versioned symbol.
  88         (elf_link_add_object_symbols): Adjust call to suit.  Don't
  89         pull in as-needed libraries when override is set.
  90
  91 2021-02-01  Emery Hemingway  <ehmry@posteo.net>
  92
  93         * config.bfd: Add *-*-genode* as a target for AArch64 and x86.
  94
  95 2021-02-01  Egor Vishnyakov  <lenvampir@yandex.ru>
  96
  97         PR 27254
  98         * elf32-rl78.c (rl78_elf_relocate_section): Fix calculation of
  99         offset for the R_RL78_RH_SADDR relocation.
 100
 101 2021-01-29  Alan Modra  <amodra@gmail.com>
 102
 103         PR 27271
 104         * elflink.c (bfd_elf_link_record_dynamic_symbol): Don't segfault
 105         on symbols defined in absolute or other special sections.
 106
 107 2021-01-28  Alan Modra  <amodra@gmail.com>
 108
 109         PR 27259
 110         * elflink.c (_bfd_elf_gc_mark_extra_sections): Use linker_mark to
 111         prevent endless looping of linked-to sections.
 112
 113 2020-12-17  Mihails Strasuns  <mihails.strasuns@intel.com>
 114
 115         * bfd-elf.h (elfcore_write_file_note): New function.
 116         * elf.c (elfcore_write_file_note): New function.
 117
 118 2021-01-26  Alan Modra  <amodra@gmail.com>
 119
 120         * elf32-ft32.c (ft32_reloc_type_lookup): Don't miss ft32_reloc_map[0].
 121
 122 2021-01-24  H.J. Lu  <hongjiu.lu@intel.com>
 123
 124         PR binutils/27231
 125         * dwarf2.c (read_rnglists): Ignore empty range when parsing line
 126         number tables.
 127
 128 2021-01-23  H.J. Lu  <hongjiu.lu@intel.com>
 129
 130         PR binutils/27231
 131         * dwarf2.c (read_rnglists): Advance rngs_ptr after
 132         _bfd_safe_read_leb128 when parsing DW_RLE_offset_pair.
 133
 134 2021-01-20  Alan Modra  <amodra@gmail.com>
 135
 136         * elf32-ppc.c: Delete outdated comment.
 137         (TARGET_KEEP_UNUSED_SECTION_SYMBOLS): Define.
 138         * elf64-ppc.c (TARGET_KEEP_UNUSED_SECTION_SYMBOLS): Define.
 139
 140 2021-01-20  Alan Modra  <amodra@gmail.com>
 141
 142         * elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Don't assume
 143         section symbols are present.
 144
 145 2021-01-19  Alan Modra  <amodra@gmail.com>
 146
 147         * elf64-ppc.c (elf_hash_entry): New inline function.  Use
 148         throughout to replace casts.
 149         (branch_reloc_hash_match): Remove const from params.
 150         (use_local_plt): New function.
 151         (allocate_dynrelocs, ppc_build_one_stub, ppc_size_one_stub),
 152         (build_global_entry_stubs_and_plt, ppc64_elf_relocate_section):
 153         Use use_local_plt.
 154         * elf32-ppc.c (use_local_plt): New function.
 155         (allocate_dynrelocs, ppc_elf_relocate_section),
 156         (write_global_sym_plt): Use use_local_plt.
 157
 158 2021-01-17  H.J. Lu  <hongjiu.lu@intel.com>
 159
 160         PR ld/27193
 161         * elflink.c (elf_create_symbuf): Also ignore section symbols.
 162
 163 2021-01-16  H.J. Lu  <hongjiu.lu@intel.com>
 164
 165         PR ld/23169
 166         * elfxx-x86.c (_bfd_x86_elf_link_fixup_ifunc_symbol): Don't
 167         check pointer_equality_needed.
 168
 169 2021-01-15  H.J. Lu  <hongjiu.lu@intel.com>
 170
 171         * elf-linker-x86.h (elf_linker_x86_params): Add
 172         report_relative_reloc.
 173         * elf32-i386.c (elf_i386_relocate_section): Call
 174         _bfd_x86_elf_link_report_relative_reloc to report relative
 175         relocations for -z report-relative-reloc.
 176         (elf_i386_finish_dynamic_symbol): Likewse.
 177         * elf64-x86-64.c (elf_x86_64_relocate_section): Likewse.
 178         (elf_x86_64_finish_dynamic_symbol): Likewse.
 179         * elfxx-x86.c (_bfd_x86_elf_link_report_relative_reloc): New
 180         function.
 181         * elfxx-x86.h (_bfd_x86_elf_link_report_relative_reloc): New
 182         prototype.
 183
 184 2021-01-16  Alan Modra  <amodra@gmail.com>
 185
 186         * compress.c (decompress_contents): Tidy inflateEnd result test.
 187
 188 2021-01-16  Alan Modra  <amodra@gmail.com>
 189
 190         PR 26002
 191         * elflink.c (elf_link_output_extsym): Use version 1 in
 192         .gnu.version for undefined unversioned symbols.
 193
 194 2021-01-15  Nelson Chu  <nelson.chu@sifive.com>
 195
 196         * elfnn-riscv.c (riscv_relax_delete_bytes): Fixed the indent that
 197         caused the by previous commit accidentally.
 198
 199 2021-01-15  Nelson Chu  <nelson.chu@sifive.com>
 200
 201         * elfnn-riscv.c: Indent, labels and GNU coding standards tidy,
 202         also aligned the code.
 203
 204 2021-01-15  Nelson Chu  <nelson.chu@sifive.com>
 205
 206         * elfnn-riscv.c (riscv_merge_attributes): Fix typos of messages.
 207
 208 2021-01-15  Nelson Chu  <nelson.chu@sifive.com>
 209
 210         * elfnn-riscv.c: Comments tidy and improvement.
 211         * elfxx-riscv.c: Likewise.
 212         * elfxx-riscv.h: Likewise.
 213
 214 2021-01-14  H.J. Lu  <hongjiu.lu@intel.com>
 215
 216         PR ld/26688
 217         * elf32-bfin.c (bfinfdpic_relocate_section): Skip non SEC_ALLOC
 218         section for R_BFIN_FUNCDESC.
 219
 220 2021-01-14  Nick Clifton  <nickc@redhat.com>
 221
 222         * elf.c (elfcore_grok_win32pstatus): Check for a note type of 0.
 223
 224 2021-01-13  Alan Modra  <amodra@gmail.com>
 225
 226         * Makefile.in: Regenerate.
 227         * doc/Makefile.in: Regenerate.
 228
 229 2021-01-13  Alan Modra  <amodra@gmail.com>
 230
 231         PR 27160
 232         * section.c (struct bfd_section): Remove pattern field.
 233         (BFD_FAKE_SECTION): Adjust to suit.
 234         * bfd-in2.h: Regenerate.
 235         * elflink.c (compare_link_order, elf_fixup_link_order): Delete.
 236         (bfd_elf_final_link): Don't call elf_fixup_link_order.
 237
 238 2021-01-12  H.J. Lu  <hongjiu.lu@intel.com>
 239
 240         PR binutils/26792
 241         * configure.ac: Use GNU_MAKE_JOBSERVER.
 242         * aclocal.m4: Regenerated.
 243         * configure: Likewise.
 244
 245 2021-01-12  H.J. Lu  <hongjiu.lu@intel.com>
 246
 247         PR ld/27171
 248         * reloc.c (bfd_perform_relocation): Adjust R_AMD64_DIR64 and
 249         R_AMD64_DIR32 relocations for PE/x86-64 inputs.
 250
 251 2021-01-11  H.J. Lu  <hongjiu.lu@intel.com>
 252
 253         PR ld/27173
 254         * configure: Regenerated.
 255
 256 2021-01-11  Nick Clifton  <nickc@redhat.com>
 257
 258         * po/fr.po: Updated French translation.
 259         * po/pt.po: Updated Portuguese translation.
 260         * po/sr.po: Updated Serbian translation.
 261         * po/uk.po: Updated Ukranian translation.
 262
 263 2021-01-09  H.J. Lu  <hongjiu.lu@intel.com>
 264
 265         * configure: Regenerated.
 266
 267 2021-01-09  H.J. Lu  <hongjiu.lu@intel.com>
 268
 269         PR ld/27166
 270         * elfxx-x86.c (_bfd_x86_elf_merge_gnu_properties): Handle
 271         -z lam-u48 and -z lam-u57.
 272
 273 2021-01-09  Nick Clifton  <nickc@redhat.com>
 274
 275         * version.m4: Change to 2.36.50.
 276         * configure: Regenerate.
 277         * po/bfd.pot: Regenerate.
 278
 279 2021-01-09  Nick Clifton  <nickc@redhat.com>
 280
 281         * 2.36 release branch crated.
 282
 283 2021-01-08  H.J. Lu  <hongjiu.lu@intel.com>
 284
 285         * elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Also set
 286         LAM_U57 when setting LAM_U48.
 287
 288 2021-01-08  H.J. Lu  <hongjiu.lu@intel.com>
 289
 290         PR ld/26256
 291         PR ld/27160
 292         * elflink.c (elf_fixup_link_order): Verify that fixing up
 293         SHF_LINK_ORDER doesn't increase the output section size.
 294
 295 2021-01-09  Alan Modra  <amodra@gmail.com>
 296
 297         * configure: Regenerate.
 298
 299 2021-01-07  Samuel Thibault  <samuel.thibault@gnu.org>
 300
 301         * configure: Regenerate.
 302
 303 2021-01-07  H.J. Lu  <hongjiu.lu@intel.com>
 304
 305         PR 27109
 306         * aix386-core.c (core_aix386_vec): Initialize
 307         keep_unused_section_symbol to TARGET_KEEP_UNUSED_SECTION_SYMBOLS.
 308         * aout-target.h (MY (vec)): Likewise.
 309         * binary.c (binary_vec): Likewise.
 310         * cisco-core.c (core_cisco_be_vec): Likewise.
 311         (core_cisco_le_vec): Likewise.
 312         * coff-alpha.c (alpha_ecoff_le_vec): Likewise.
 313         * coff-i386.c (TARGET_SYM): Likewise.
 314         (TARGET_SYM_BIG): Likewise.
 315         * coff-ia64.c (TARGET_SYM): Likewise.
 316         * coff-mips.c (mips_ecoff_le_vec): Likewise.
 317         (mips_ecoff_be_vec): Likewise.
 318         (mips_ecoff_bele_vec): Likewise.
 319         * coff-rs6000.c (rs6000_xcoff_vec): Likewise.
 320         (powerpc_xcoff_vec): Likewise.
 321         * coff-sh.c (sh_coff_small_vec): Likewise.
 322         (sh_coff_small_le_vec): Likewise.
 323         * coff-tic30.c (tic30_coff_vec): Likewise.
 324         * coff-tic54x.c (tic54x_coff0_vec): Likewise.
 325         (tic54x_coff0_beh_vec): Likewise.
 326         (tic54x_coff1_vec): Likewise.
 327         (tic54x_coff1_beh_vec): Likewise.
 328         (tic54x_coff2_vec): Likewise.
 329         (tic54x_coff2_beh_vec): Likewise.
 330         * coff-x86_64.c (TARGET_SYM): Likewise.
 331         (TARGET_SYM_BIG): Likewise.
 332         * coff64-rs6000.c (rs6000_xcoff64_vec): Likewise.
 333         (rs6000_xcoff64_aix_vec): Likewise.
 334         * coffcode.h (CREATE_BIG_COFF_TARGET_VEC): Likewise.
 335         (CREATE_BIGHDR_COFF_TARGET_VEC): Likewise.
 336         (CREATE_LITTLE_COFF_TARGET_VEC): Likewise.
 337         * elfxx-target.h (TARGET_BIG_SYM): Likewise.
 338         (TARGET_LITTLE_SYM): Likewise.
 339         * hppabsd-core.c (core_hppabsd_vec): Likewise.
 340         * hpux-core.c (core_hpux_vec): Likewise.
 341         * i386msdos.c (i386_msdos_vec): Likewise.
 342         * ihex.c (ihex_vec): Likewise.
 343         * irix-core.c (core_irix_vec): Likewise.
 344         * mach-o-target.c (TARGET_NAME): Likewise.
 345         * mmo.c (mmix_mmo_vec): Likewise.
 346         * netbsd-core.c (core_netbsd_vec): Likewise.
 347         * osf-core.c (core_osf_vec): Likewise.
 348         * pdp11.c (MY (vec)): Likewise.
 349         * pef.c (pef_vec): Likewise.
 350         (pef_xlib_vec): Likewise.
 351         * plugin.c (plugin_vec): Likewise.
 352         * ppcboot.c (powerpc_boot_vec): Likewise.
 353         * ptrace-core.c (core_ptrace_vec): Likewise.
 354         * sco5-core.c (core_sco5_vec): Likewise.
 355         * som.c (hppa_som_vec): Likewise.
 356         * srec.c (srec_vec): Likewise.
 357         (symbolsrec_vec): Likewise.
 358         * tekhex.c (tekhex_vec): Likewise.
 359         * trad-core.c (core_trad_vec): Likewise.
 360         * verilog.c (verilog_vec): Likewise.
 361         * vms-alpha.c (alpha_vms_vec): Likewise.
 362         * vms-lib.c (alpha_vms_lib_txt_vec): Likewise.
 363         * wasm-module.c (wasm_vec): Likewise.
 364         * xsym.c (sym_vec): Likewise.
 365         * elf.c (ignore_section_sym): Return TRUE if BSF_SECTION_SYM_USED
 366         isn't set.
 367         (elf_map_symbols): Don't include ignored section symbols.
 368         * elfcode.h (elf_slurp_symbol_table): Also set
 369         BSF_SECTION_SYM_USED on STT_SECTION symbols.
 370         * elflink.c (bfd_elf_final_link): Generated section symbols only
 371         when emitting relocations or reqired.
 372         * elfxx-x86.h (TARGET_KEEP_UNUSED_SECTION_SYMBOLS): New.
 373         * syms.c (BSF_SECTION_SYM_USED): New.
 374         * targets.c (TARGET_KEEP_UNUSED_SECTION_SYMBOLS): New.
 375         (bfd_target): Add keep_unused_section_symbols.
 376         (bfd_keep_unused_section_symbols): New.
 377         * bfd-in2.h: Regenerated.
 378
 379 2021-01-07  Nick Clifton  <nickc@redhat.com>
 380
 381         PR 25713
 382         * bfdio.c (_bfd_real_fopen): For Win32 convert relative paths to
 383         absolute paths and check to see if they are longer than MAX_PATH.
 384
 385 2021-01-07  Philipp Tomsich  <prt@gnu.org>
 386
 387         * elfxx-riscv.c (riscv_std_z_ext_strtab): Added zihintpause.
 388
 389 2021-01-07  Claire Xenia Wolf  <claire@symbioticeda.com>
 390             Jim Wilson  <jimw@sifive.com>
 391             Andrew Waterman  <andrew@sifive.com>
 392             Maxim Blinov  <maxim.blinov@embecosm.com>
 393             Kito Cheng  <kito.cheng@sifive.com>
 394             Nelson Chu  <nelson.chu@sifive.com>
 395
 396         * elfxx-riscv.c (riscv_std_z_ext_strtab): Added zba, zbb and zbc.
 397
 398 2021-01-06  H.J. Lu  <hongjiu.lu@intel.com>
 399
 400         * elf32-bfin.c (bfin_check_relocs): Check bfd_link_hash_indirect.
 401         (bfinfdpic_check_relocs): Likewise.
 402
 403 2021-01-06  Alan Modra  <amodra@gmail.com>
 404
 405         * elf32-score.c (s3_bfd_score_info_to_howto): Report an error
 406         on unknown r_type.
 407         * elf32-score7.c (s7_bfd_score_info_to_howto): Likewise.
 408
 409 2021-01-06  Alan Modra  <amodra@gmail.com>
 410
 411         * config.bfd (sparc-*-solaris2*): Add sparc_elf32_vec.
 412         (sparc64-*-solaris2*): Add sparc_elf64_vec and
 413         sparc_elf32_vec.
 414
 415 2021-01-06  Marcus Comstedt  <marcus@mc.pp.se>
 416
 417         * config.bfd: Added targets riscv64be*-*-*, riscv32be*-*-* and
 418         riscvbe*-*-*.  Also added riscv_elf[32|64]_be_vec.
 419         * configure.ac: Handle riscv_elf[32|64]_be_vec.
 420         * configure: Regenerate.
 421         * elfnn-riscv.c: Include <limits.h> and define CHAR_BIT for
 422         riscv_is_insn_reloc.
 423         (riscv_get_insn): RISC-V instructions are always little endian, but
 424         bfd_get may be used for big-endian, so add new riscv_get_insn to handle
 425         the insturctions.
 426         (riscv_put_insn): Likewsie.
 427         (riscv_is_insn_reloc): Check if we are relocaing an instruction.
 428         (perform_relocation): Call riscv_is_insn_reloc to decide if we should
 429         use riscv_[get|put]_insn or bfd_[get|put].
 430         (riscv_zero_pcrel_hi_reloc): Use riscv_[get|put]_insn, bfd_[get|put]l32
 431         or bfd_[get|put]l16 for code.
 432         (riscv_elf_relocate_section): Likewise.
 433         (riscv_elf_finish_dynamic_symbol): Likewise.
 434         (riscv_elf_finish_dynamic_sections): Likewise.
 435         (_bfd_riscv_relax_call): Likewise.
 436         (_bfd_riscv_relax_lui): Likewise.
 437         (_bfd_riscv_relax_align): Likewise.
 438         (_bfd_riscv_relax_pc): Likewise.
 439         (riscv_elf_object_p): Handled for big endian.
 440         (TARGET_BIG_SYM, TARGET_BIG_NAME): Defined.
 441         * targets.c: Add riscv_elf[32|64]_be_vec.
 442         (_bfd_target_vector): Likewise.
 443
 444 2021-01-05  Alan Modra  <amodra@gmail.com>
 445
 446         * elflink.c (bfd_elf_link_record_dynamic_symbol): Handle no_export
 447         for relocatable executable.
 448
 449 2021-01-05  Alan Modra  <amodra@gmail.com>
 450
 451         * vms-alpha.c (_bfd_vms_slurp_egsd): Read flags after size check.
 452
 453 2021-01-05  Nelson Chu  <nelson.chu@sifive.com>
 454
 455         * elfnn-riscv.c (allocate_dynrelocs): When we are generating pde,
 456         make sure gp symbol is output as a dynamic symbol.
 457
 458 2021-01-04  H.J. Lu  <hongjiu.lu@intel.com>
 459
 460         PR ld/26256
 461         * elflink.c (compare_link_order): Place unordered sections before
 462         ordered sections.
 463         (elf_fixup_link_order): Add a link info argument.  Allow mixed
 464         ordered and unordered input sections for non-relocatable link.
 465         Sort the consecutive bfd_indirect_link_order sections with the
 466         same pattern.  Change the offsets of the bfd_indirect_link_order
 467         sections only.
 468         (bfd_elf_final_link): Pass info to elf_fixup_link_order.
 469         * section.c (bfd_section): Add pattern.
 470         (BFD_FAKE_SECTION): Initialize pattern to NULL.
 471         * bfd-in2.h: Regenerated.
 472
 473 2021-01-04  Alexander Fedotov  <alfedotov@gmail.com>
 474
 475         * elf32-arm.c (elf32_arm_print_private_bfd_data): Prefix hex value
 476         of private flags with 0x.
 477         * elfnn-aarch64.c (elfNN_aarch64_print_private_bfd_data): Likewise.
 478
 479 2021-01-04  Alan Modra  <amodra@gmail.com>
 480
 481         PR 26822
 482         * elflink.c (elf_link_input_bfd): Use the file base name in
 483         linker generated STT_FILE symbols.
 484
 485 2021-01-04  Nelson Chu  <nelson.chu@sifive.com>
 486
 487         * elfxx-riscv.c (riscv_compare_subsets): Removed static.
 488         * elfxx-riscv.h: Add declaration.
 489         * elfnn-riscv.c (riscv_merge_multi_letter_ext): Use
 490         riscv_compare_subsets to check the orders.
 491         (riscv_skip_prefix): Removed.
 492         (riscv_prefix_cmp): Removed.
 493
 494 2021-01-04  Alan Modra  <amodra@gmail.com>
 495
 496         PR 26741
 497         * elfxx-riscv.c (riscv_parse_prefixed_ext): Free subset after
 498         calculating subset version length.
 499
 500 2021-01-01  Nicolas Boulenguez  <nicolas@debian.org>
 501
 502         * xcofflink.c: Correct spelling in comments.
 503
 504 2021-01-01  Alan Modra  <amodra@gmail.com>
 505
 506         Update year range in copyright notice of all files.
 507
 508 For older changes see ChangeLog-2020
 509 \f
 510 Copyright (C) 2021 Free Software Foundation, Inc.
 511
 512 Copying and distribution of this file, with or without modification,
 513 are permitted in any medium without royalty provided the copyright
 514 notice and this notice are preserved.
 515
 516 Local Variables:
 517 mode: change-log
 518 left-margin: 8
 519 fill-column: 74
 520 version-control: never
 521 End: