binutils/ChangeLog

   1 2009-06-03  Tristan Gingold  <gingold@adacore.com>
   2
   3         * MAINTAINERS: Add myself as Mach-O maintainer.
   4
   5 2009-06-01  Alan Modra  <amodra@bigpond.net.au>
   6
   7         PR 10199
   8         * doc/binutils.texi (nm): Correct -S description.
   9
  10 2009-05-28  Nick Clifton  <nickc@redhat.com>
  11
  12         * po/da.po: Updated Danish translation.
  13
  14 2009-05-28  Nick Clifton  <nickc@redhat.com>
  15
  16         * readelf.c (display_debug_section): Do not display debug sections
  17         with the NOBITS section type.
  18
  19 2009-05-27  Rafael Avila de Espindola  <espindola@google.com>
  20
  21         * aclocal.m4: Include ../config/plugins.m4.
  22         * configure.in: Use AC_PLUGINS.
  23         * configure: Regenerate.
  24         * Makefile.in: Regenerate.
  25         * doc/Makefile.in: Regenerate.
  26
  27 2009-05-27  Rafael Avila de Espindola  <espindola@google.com>
  28
  29         * ar.c (main): Call bfd_plugin_set_program_name.
  30         * nm.c (main): Call bfd_plugin_set_program_name.
  31
  32 2009-05-27  Nathan Sidwell  <nathan@codesourcery.com>
  33
  34         * sysdump.c (tab): Use puts rather than two printfs.
  35
  36 2009-05-26  Nick Clifton  <nickc@redhat.com>
  37
  38         * po/id.po: Updated Indonesian translation.
  39         * po/binutils.pot: Updated template file.
  40
  41 2009-05-26  Rafael Avila de Espindola  <espindola@google.com>
  42
  43         * ar.c: Include plugin.h.
  44         (main): Handle the --plugin option.
  45         * nm.c: Include plugin.h.
  46         (OPTION_PLUGIN): New.
  47         (long_options): Add plugin.
  48         (main): Handle OPTION_PLUGIN.
  49         * NEWS: Mention  the new feature.
  50         * doc/binutils: Documement the new command line options.
  51         * configure.in: Check for --enable-plugins.
  52         * configure: Regenerate.
  53
  54 2009-05-26  Alan Modra  <amodra@bigpond.net.au>
  55
  56         * dep-in.sed: Output one filename per line with all lines having
  57         continuation backslash.  Prefix first line with "A", following
  58         lines with "B".
  59         * Makefile.am (DEP): Don't use dep.sed here.
  60         (DEP1): Run $MKDEP on single files, use dep.sed here on dependencies,
  61         sort and uniq.
  62         * Makefile.in: Regenerate.
  63
  64 2009-05-25  Tristan Gingold  <gingold@adacore.com>
  65
  66         * makefile.vms-in: Fix CFLAGS, add addr2line.exe target.
  67
  68         * configure.com: Fix it: handle alloca and define TARGET in config.h.
  69
  70 2009-05-22  Alan Modra  <amodra@bigpond.net.au>
  71
  72         * Makefile.am: Run "make dep-am".
  73         * Makefile.in: Regenerate.
  74
  75 2009-05-12  Alan Modra  <amodra@bigpond.net.au>
  76
  77         * objcopy.c (set_long_section_mode): Check input_bfd is coff
  78         before accessing coff specific fields of bfd.
  79
  80 2009-05-09  Dave Korn  <dave.korn.cygwin@gmail.com>
  81
  82         * MAINTAINERS:  Add myself as PE/COFF co-maintainer.
  83
  84 2009-05-08  Kai Tietz  <kai.tietz@onevision.com>
  85
  86         * winduni.c (iconv_onechar): Only define when HAVE_ICONV
  87         is defined, but not when __CYGWIN__ or _WIN32 are defined.
  88         See wind_iconv_cp for call logic of this local funtion.
  89
  90 2009-05-05  Guillaume Duhamel  <guillaume.duhamel@gmail.com>
  91
  92         PR 10109
  93         * winduni.c: Replace test of HAVE_ICONV_H with a test of
  94         HAVE_ICONV.
  95         (iconv_onechar): Use ICONV_CONST instead of "const".
  96         (wind_MultiByteToWideChar): Initialise local strings.
  97
  98 2009-04-30  Nick Clifton  <nickc@redhat.com>
  99
 100         * readelf.c (dump_relocations): Display a relocation against an
 101         ifunc symbol as if it were a function invocation.
 102         (get_symbol_type): Handle STT_GNU_IFUNC.
 103
 104 2009-04-29  Anthony Green  <green@moxielogic.com>
 105
 106         * NEWS: Tweak verilog support description.
 107
 108 2009-04-29  Alan Modra  <amodra@bigpond.net.au>
 109             Denis Scherbakov <denis_scherbakov@yahoo.com>
 110
 111         * readelf.c (slurp_ia64_unwind_table): Correct 64-bit unwind table
 112         read, and merge with 32-bit case.
 113
 114 2009-04-27  Anthony Green  <green@moxielogic.com>
 115
 116         * NEWS: Mention verilog support added to bfd.
 117
 118 2009-04-27  H.J. Lu  <hongjiu.lu@intel.com>
 119
 120         * objcopy.c (copy_object): Copy pe_opthdr before changing PE
 121         parameters.
 122
 123 2009-04-24  Cary Coutant  <ccoutant@google.com>
 124
 125         * dwarf.c (process_extended_line_op): Add DW_LNE_set_discriminator.
 126         Add missing newlines to HP extensions.
 127
 128 2009-04-17  H.J. Lu  <hongjiu.lu@intel.com>
 129
 130         * objcopy.c (set_pe_subsystem): Replace efi-rom with sal-rtd.
 131         * doc/binutils.texi: Likewise.
 132
 133 2009-04-17  H.J. Lu  <hongjiu.lu@intel.com>
 134
 135         PR binutils/10074
 136         * objcopy.c: Include coff/i386.h and coff/pe.h.
 137         (pe_file_alignment): New.
 138         (pe_heap_commit): Likewise.
 139         (pe_heap_reserve): Likewise.
 140         (pe_image_base): Likewise.
 141         (pe_section_alignment): Likewise.
 142         (pe_stack_commit): Likewise.
 143         (pe_stack_reserve): Likewise.
 144         (pe_subsystem): Likewise.
 145         (pe_major_subsystem_version): Likewise.
 146         (pe_minor_subsystem_version): Likewise.
 147         (set_pe_subsystem): Likewise.
 148         (convert_efi_target): Likewise.
 149         (command_line_switch): Add OPTION_FILE_ALIGNMENT,
 150         OPTION_HEAP, OPTION_IMAGE_BASE, OPTION_SECTION_ALIGNMENT,
 151         OPTION_STACK and OPTION_SUBSYSTEM.
 152         (copy_options): Likewise.
 153         (copy_usage): Add --file-alignment, --heap, --image-base,
 154         --section-alignment, --stack and --subsystem.
 155         (copy_object): Set up PE parameters.
 156         (copy_main): Process Add OPTION_FILE_ALIGNMENT,
 157         OPTION_HEAP, OPTION_IMAGE_BASE, OPTION_SECTION_ALIGNMENT,
 158         OPTION_STACK and OPTION_SUBSYSTEM.   Convert EFI target to
 159         PEI target.
 160
 161         * NEWS: Mention --file-alignment, --heap, --image-base,
 162         --section-alignment, --stack and --subsystem command line
 163         options for objcopy.
 164
 165         * doc/binutils.texi: Document --file-alignment, --heap,
 166         --image-base, --section-alignment, --stack and --subsystem
 167         command line options for objcopy.
 168
 169 2009-04-15  Anthony Green  <green@moxielogic.com>
 170
 171         * MAINTAINERS: Add myself as Moxie port maintainer.
 172
 173 2009-04-14  Dave Korn  <dave.korn.cygwin@gmail.com>
 174
 175         * objcopy.c (enum long_section_name_handling):  New enum type.
 176         (enum command_line_switch):  Add OPTION_LONG_SECTION_NAMES.
 177         (copy_options[]):  Add entry for --long-section-names option.
 178         (copy_usage):  Document it.
 179         (set_long_section_mode):  New subroutine.
 180         (copy_file):  Call it.
 181         (copy_main):  Accept OPTION_LONG_SECTION_NAMES and parse arg.
 182         * doc/binutils.texi:  Update objcopy documentation with details
 183         of new option.
 184
 185 2009-04-01  Dave Korn  <dave.korn.cygwin@gmail.com>
 186
 187         * dlltool.c (set_dll_name_from_def):  Accept new second arg that
 188         indicates if we are building DLL or EXE, and use it to add a
 189         default suffix to the output filename when none is already present.
 190         (def_name):  Indicate we are building an EXE when calling it.
 191         (def_library):  Indicate we are building a DLL when calling it.
 192
 193 2009-04-01  Jari Aalto  <jari.aalto@cante.net>
 194
 195         PR 9972
 196         * doc/binutils.texi (strings): Document the -V alias for the
 197         --version option.
 198         * strings.c (usage): Likewise.
 199
 200 2009-03-31  Nick Clifton  <nickc@redhat.com>
 201
 202         PR 9992
 203         * configure.in: Import Solaris specific largefile test from
 204         bfd/configure.in.
 205         * configure: Regenerate.
 206
 207 2009-03-30  Richard Sandiford  <rdsandiford@googlemail.com>
 208
 209         * MAINTAINERS: Add self.
 210
 211 2009-03-27  Nick Clifton  <nickc@redhat.com>
 212
 213         * dwarf.c (display_debug_ranges): Add the base address to the
 214         displayed values for 'Begin' and 'End'.
 215
 216 2009-03-25  Ryan Mansfield  <rmansfield@qnx.com>
 217
 218         * readelf.c (process_file_header): Don't report a corrupt string
 219         table index if it is zero.
 220
 221 2009-03-19  H.J. Lu  <hongjiu.lu@intel.com>
 222
 223         * dwarf.c (dwarf_regnames): Moved before frame_need_space.
 224         (dwarf_regnames_count): Likewise.
 225         (frame_need_space): Return int.
 226         (display_debug_frames): Check invalid registers.
 227
 228 2009-03-19  H.J. Lu  <hongjiu.lu@intel.com>
 229
 230         * readelf.c (debug_apply_relocations): Check relocations
 231         against STT_SECTION symbol.
 232
 233 2009-03-18  H.J. Lu  <hongjiu.lu@intel.com>
 234
 235         * readelf.c (debug_apply_relocations): Allow relocations
 236         against function symbols.
 237
 238 2009-03-18  Alan Modra  <amodra@bigpond.net.au>
 239
 240         * sysdep.h: Include alloca-conf.h instead of config.h and remove
 241         existing #if's handling alloca.
 242         * Makefile.am: Run "make dep-am".
 243         * Makefile.in: Regenerate.
 244
 245 2009-03-14  Richard Sandiford  <r.sandiford@uk.ibm.com>
 246
 247         * configure.tgt: Extend AIX 5 behavior to AIX 6 and above.
 248         * configure.in: Likewise.
 249         * configure: Regenerate.
 250
 251 2009-03-13  H.J. Lu  <hongjiu.lu@intel.com>
 252
 253         PR binutils/9945
 254         * objcopy.c (copy_object): Clear HAS_RELOC when stripping all.
 255
 256 2009-03-11  Chris Demetriou  <cgd@google.com>
 257
 258         * ar.c (deterministic): New global variable.
 259         (main): Recognize new 'D' option, which enables 'deterministic mode'.
 260         (usage): Document new 'D' option.
 261         (write_archive): Set BFD_DETERMINISTIC_OUTPUT in output archive's
 262         flags if deterministic mode was requested.
 263         * doc/binutils.texi (ar): Document deterministic mode ('D' option).
 264
 265 2009-03-09  H.J. Lu  <hongjiu.lu@intel.com>
 266
 267         PR binutils/9933
 268         * objcopy.c (filter_symbols): Properly handle common symbols
 269         in relocatable file.
 270
 271 2009-03-06  Nick Clifton  <nickc@redhat.com>
 272
 273         * po/es.po: Updated Spanish translation.
 274
 275 2009-03-05  Nick Clifton  <nickc@redhat.com>
 276
 277         * objdump.c (disassemble_section): If the computed next offset is
 278         not beyond the current offset then just continue to the end.
 279
 280 2009-03-04  Tristan Gingold  <gingold@adacore.com>
 281
 282         * MAINTAINERS: Add myself as VMS maintainer.
 283
 284 2009-03-03  Nick Clifton  <nickc@redhat.com>
 285
 286         * readelf.c: Update formatting.
 287
 288 2009-03-03  Alan Modra  <amodra@bigpond.net.au>
 289
 290         * Makefile.am: Run "make dep-am".
 291         * Makefile.in: Regenerate.
 292
 293 2009-03-03  Alan Modra  <amodra@bigpond.net.au>
 294
 295         * objdump.c (disassemble_section): Mask address before sign extending.
 296
 297 2009-03-02  Sebastian Biallas  <sb@biallas.net>
 298
 299         * ieee.c (parse_ieee_ty): Add support for undocumented 'v' type.
 300         (parse_ieee_bb): Set the filename if it has not already been
 301         discovered.
 302
 303 2009-03-02  Cary Coutant  <ccoutant@google.com>
 304
 305         * readelf.c (adjust_relative_path): New function.
 306         (struct archive_info): New type.
 307         (setup_archive): New function.
 308         (release_archive): New function.
 309         (setup_nested_archive): New function.
 310         (get_archive_member_name): New function.
 311         (get_archive_member_name_at): New function.
 312         (make_qualified_name): New function.
 313         (process_archive): Factor out code for reading archive index and
 314         long filename table to setup_archive.  Add support for thin archives.
 315
 316 2009-03-02  Nick Clifton  <nickc@redhat.com>
 317
 318         * po/sk.po: Updated Slovak translation.
 319
 320 2009-03-01  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
 321
 322         * configure: Regenerate.
 323
 324 2009-02-23  Cary Coutant <ccoutant@google.com>
 325
 326         * objdump.c (load_specific_debug_section): New function, from
 327         load_debug_section.
 328         (load_debug_section): Use load_specific_debug_section.
 329         (dump_dwarf_section): Likewise.
 330
 331 2009-02-23  Cary Coutant <ccoutant@google.com>
 332
 333         * readelf.c (parse_args): Select all sections explicitly for -w.
 334
 335 2009-02-09  Kai Tietz  <kai.tietz@onevision.com>
 336
 337         * windres.c (set_endianess): Copy name without leading '-'.
 338
 339 2009-02-09  Tristan Gingold  <gingold@adacore.com>
 340
 341         * NEWS: Mention feature match between objdump and readelf for dumping
 342         dwarf info.
 343
 344         * doc/binutils.texi (objdump): Document -W/--dwarf improvments to
 345         objdump.
 346
 347         * objdump.c (usage): Update documentation for -W/--dwarf.
 348         (enum option_values): Add OPTION_DWARF.
 349         (long_options): --dwarf can accept arguments.
 350         (dump_dwarf_section): Also check enabled field.
 351         (main): Option -W can accept arguments, code moved to
 352         dwarf.c and call dwarf_select_sections_all instead.
 353         * readelf.c (process_section_headers): Remove do_debug_lines_decoded.
 354         (parse_args): Move code to...
 355         * dwarf.c (dwarf_select_sections_by_letters,
 356         dwarf_select_sections_by_names): : ...here (new functions).
 357         (do_debug_lines_decoded): Remove and replaced by ...
 358         (FLAG_DEBUG_LINES_RAW, FLAG_DEBUG_LINES_DECODED): ... new macros.
 359         (display_debug_lines): Adjust for previous change.
 360         (dwarf_select_sections_all): New function.
 361         (debug_displays): Add initializer for enabled field.
 362         * dwarf.h (do_debug_lines_decoded): Remove.
 363         Add prototypes for the new functions.
 364         (struct dwarf_section_display): Add enabled field.
 365
 366 2009-02-06  Nick Clifton  <nickc@redhat.com>
 367
 368         * po/vi.po: Updated Vietnamese translation.
 369
 370 2009-02-03  Sandip Matte  <sandip@rmicorp.com>
 371
 372         * readelf.c (get_machine_flags): Handle E_MIPS_MACH_XLR.
 373
 374 2009-02-03  H.J. Lu  <hongjiu.lu@intel.com>
 375
 376         * NEWS: Move --as-needed change to ...
 377         * ../ld/NEWS: Here.
 378
 379 2009-02-03  Carlos O'Donell  <carlos@codesourcery.com>
 380
 381         * configure.in: AC_SUBST pdfdir.
 382         * Makefile.am: Add install-pdf, install-pdf-am,
 383         and install-pdf-recursive targets.
 384         * doc/Makefile.am: Define pdf__strip_dir. Add
 385         install-pdf and install-pdf-am targets.
 386         * po/Make-in: Add install-pdf target.
 387         * configure: Regenerate.
 388         * Makefile.in: Regenerate.
 389         * doc/Makefile.in: Regenerate.
 390
 391 2009-02-03  H.J. Lu  <hongjiu.lu@intel.com>
 392
 393         PR binutils/9784
 394         * NEWS: Mention --prefix=PREFIX and --prefix-strip=LEVEL.
 395
 396         * doc/binutils.texi: Document --prefix=PREFIX and
 397         --prefix-strip=LEVEL.
 398
 399         * objdump.c: Include "filenames.h".
 400         (prefix): New.
 401         (prefix_strip): Likewise.
 402         (prefix_length): Likewise.
 403         (usage): Add --prefix=PREFIX and --prefix-strip=LEVEL.
 404         (option_values): Add OPTION_PREFIX and OPTION_PREFIX_STRIP.
 405         (long_options): Likewise.
 406         (show_line): Handle prefix and prefix_strip.
 407         (main): Handle OPTION_PREFIX and OPTION_PREFIX_STRIP.
 408
 409         * readelf.c (PATH_MAX): Moved to ...
 410         * sysdep.h: Here.
 411
 412 2009-01-31  Alan Modra  <amodra@bigpond.net.au>
 413
 414         * NEWS: Mention --as-needed change.
 415
 416 2009-01-29  Alan Modra  <amodra@bigpond.net.au>
 417
 418         PR 9798
 419         * bucomm.c (bfd_nonfatal_message): Use bfd_get_archive_filename.
 420         (bfd_get_archive_filename): Constify param.
 421         * bucomm.h (bfd_get_archive_filename): Update prototype.
 422         * objcopy.c (RETURN_NONFATAL): Delete.
 423         (copy_unknown_object): Don't call bfd_get_archive_filename for
 424         bfd_nonfatal_message filename, instead just pass bfd.
 425         (copy_object): Likewise.
 426         (copy_archive, copy_file): Likewise.  Expand RETURN_NONFATAL.  On
 427         bfd_close errors, do not pass the bfd to bfd_nonfatal_message.
 428         (setup_bfd_headers): Fix error message.
 429
 430 2009-01-27  Nick Clifton  <nickc@redhat.com>
 431
 432         PR 9774
 433         * objdump.c (disassemble_section): When the target uses signed
 434         addresses make sure that we compute signed values.
 435
 436 2009-01-27  Nick Clifton  <nickc@redhat.com>
 437
 438         * MAINTAINERS: Remove Thiemo Seufer's name from the list of MIPS
 439         maintainers.
 440
 441 2009-01-26  Nick Clifton  <nickc@redhat.com>
 442
 443         PR 9766
 444         * dlltool.c (xlate): When strip text after the @ sign, look for
 445         the last one not the first one.
 446
 447 2009-01-16  Alan Modra  <amodra@bigpond.net.au>
 448
 449         * configure.in (commonbfdlib): Delete.
 450         * configure: Regenerate.
 451
 452 2008-01-14  Charles Wilson  <cygwin@cwilson.fastmail.fm>
 453
 454         Cleanup code related to --identify option.
 455
 456         * binutils/dlltool.c (file scope): Removed globals identify_ms,
 457         identify_member_contains_symname_result,
 458         identify_dll_name_list_head, and identify_dll_name_list_tail.
 459         Renamed existing typedef dll_name_list_type to
 460         dll_name_list_node_type.
 461         Added new typedefs dll_name_list_type, symname_search_data_type,
 462         and identify_data_type.
 463         (identify_append_dll_name_to_list): Renamed to...
 464         (dll_name_list_append): ...here.  Changed signature to accept list
 465         argument rather than use global.
 466         (identify_count_dll_name_list): Renamed to...
 467         (dll_name_list_count): ...here.  Changed signature to accept list
 468         argument rather than use global.
 469         (identify_print_dll_name_list): Renamed to...
 470         (dll_name_list_print): ...here.  Changed signature to accept list
 471         argument rather than use global.
 472         (identify_free_dll_name_list): Renamed to...
 473         (dll_name_list_free_contents): ...here.
 474         (dll_name_list_free): New function.
 475         (dll_name_list_create): New function.
 476         (identify_process_section_p): Changed signature to accept
 477         ms_style_implib argument rather than use global.
 478         (identify_member_contains_symname): Expect incoming void * data to
 479         be symname_search_data_type.
 480         (identify_dll_for_implib): Use new functions dll_name_list_create
 481         and dll_name_list_free.  Use new types symname_search_data_type
 482         and identify_data_type to communicate with search routines.
 483         (identify_search_section): Expect incoming void * data to be
 484         identify_data_type. Use its contents rather than global
 485         variables.
 486
 487 2009-01-13  Charles Wilson  <cygwin@cwilson.fastmail.fm>
 488
 489         Add --identify-strict option.  Handle ms-style implibs:
 490
 491         * dlltool.c (file scope): Added new globals identify_ms and
 492         identify_strict. New typedef dll_name_list_type, and globals
 493         identify_dll_name_list_head and identify_dll_name_list_tail. Added
 494         new global identify_member_contains_symname_result.
 495         (identify_append_dll_name_to_list): New function.
 496         (identify_count_dll_name_list): New function.
 497         (identify_print_dll_name_list): New function.
 498         (identify_free_dll_name_list): New function.
 499         (identify_search_archive): Changed signature to take function
 500         pointer to operation to apply to each member, and data to pass on
 501         to that function.
 502         (identify_search_member): Changed signature to accept user data
 503         from caller.
 504         (identify_member_contains_symname): New function.
 505         (identify_dll_for_implib): Rewrite. Now determines whether implib
 506         is ms- or binutils- style, before searching sections for
 507         dllname. Allows multiple dllnames.
 508         (identify_process_section_p): Search alternate section for dllname
 509         when implib is ms-style.
 510         (identify_search_section): Add additional conditions to excludes
 511         candidate sections from consideration.
 512         (usage): Added --identify-strict.
 513         (long_options): Added --identify-strict.
 514         (main): Handle --identify-strict option.
 515         * doc/binutils.texi: Document --identify-strict option.
 516         * NEWS: Document --identify and --identify-strict options.
 517
 518 2009-01-13  Alan Modra  <amodra@bigpond.net.au>
 519
 520         PR 7034
 521         * doc/binutils.texi (objdump -R): Note effect of -d or -D.
 522
 523 2009-01-13  Alan Modra  <amodra@bigpond.net.au>
 524
 525         * objdump.c (disassemble_section): Don't assume non-instruction
 526         data if object symbol at given address is in different section.
 527
 528 2009-01-12  Kai Tietz  <kai.tietz@onevision.com>
 529
 530         * dlltool.c (create_for_pep): New.
 531         (flush_page): Use create_for_pep instead of using
 532         macro DLLTOOL_MX86_64 clause.
 533         (generate_idata_ofile): Likewise.
 534         (make_one_lib_file): Likewise.
 535         (make_head): Likewise.
 536         (make_tail): Likewise.
 537         (main): Initialize create_for_pep.
 538
 539 2009-01-08  Kai Tietz  <kai.tietz@onevision.com>
 540
 541         * dlltool.c (use_nul_prefixed_import_tables): New.
 542         (make_head): Make prefix leading zero prefix element for
 543         idata$4 and idata$5 dependent to new flag.
 544         (usage): Add new option  --use-nul-prefixed-import-tables.
 545         (OPTION_USE_NUL_PREFIXED_IMPORT_TABLES): New.
 546         (long_options): Add --use-nul-prefixed-import-tables.
 547         (main): Likewise.
 548         * doc/binutils.texi: Add new option documentation for
 549         --use-nul-prefixed-import-tables.
 550         * NEWS: Add new option.
 551
 552 2009-01-06  Kai Tietz  <kai.tietz@onevision.com>
 553
 554         * windres.c (set_endianess): Get architecture name
 555         for internal target names like "pe-arm-wince-little".
 556         (find_arch_match): New helper.
 557         * ChangeLog: Reset it.
 558         * ChangeLog-2008: Moved old ChangeLog.
 559
 560 For older changes see ChangeLog-2008
 561 \f
 562 Local Variables:
 563 mode: change-log
 564 left-margin: 8
 565 fill-column: 74
 566 version-control: never
 567 End: