1 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
3 * repinfo.ads (TCode): Adjust range.
4 (Truth_Andif_Expr): Remove.
5 (Truth_Orif_Expr): Likewise.
6 (Truth_And_Expr .. Dynamic_Val): Adjust value.
7 * repinfo.adb (Print_Expr): Remove handling of Truth_{And,Or}if_Expr.
9 * repinfo.h (Truth_Andif_Expr): Remove.
10 (Truth_Orif_Expr): Likewise.
11 (Truth_And_Expr .. Dynamic_Val): Adjust value.
12 * gcc-interface/decl.c (annotate_value) <TRUTH_ANDIF_EXPR>: Fall
13 through to TRUTH_AND_EXPR case.
14 <TRUTH_ORIF_EXPR>: Fall through to TRUTH_OR_EXPR case.
16 2018-05-28 Ed Schonberg <schonberg@adacore.com>
18 * exp_unst.adb (Visit_Node): For indexed components and attribute
19 references, examine index expressions or associated expressions as well
20 to record uplevel references.
21 (Vist_Node): For function and procedure calls, if a formal is an
22 unconstrained array and the actual is constrained, check whether bounds
23 of actual have uplevel references.
25 2018-05-28 Ed Schonberg <schonberg@adacore.com>
27 * einfo.ads, einfo.adb: Exceptions can be uplevel references, and thus
28 they can appear as components of activation records.
29 * exp_unst.adb (Visit_Node): A reference to an exception may be an
32 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
34 * exp_ch4.adb (Expand_Composite_Equality): Compute whether the size
35 depends on a discriminant manually instead of using the predicate
36 Size_Depends_On_Discriminant in the array type case.
38 2018-05-28 Ed Schonberg <schonberg@adacore.com>
40 * exp_unst.adb (Check_Static_Type): For a record subtype, check
41 discriminant constraints as well.
42 (Visit_Node): For a selected component, check type of prefix, as is
43 done for indexed components and slices.
45 2018-05-28 Javier Miranda <miranda@adacore.com>
47 * exp_ch4.adb (Real_Range_Check): Add a temporary to store the integer
48 value when converting a float value to a fixed-point value. This is
49 required for CCG because it handles fixed-point types by means of
50 unsigned integer type variables. The range check is now performed using
51 the integer value stored in this temporary.
53 2018-05-28 Yannick Moy <moy@adacore.com>
55 * sem_util.adb (Is_OK_Volatile_Context): Add attributes First, Last and
56 Length as valid non-interfering contexts for SPARK.
58 2018-05-28 Claire Dross <dross@adacore.com>
60 * sem_disp.ads, sem_disp.adb (Inheritance_Utilities): Package for
61 generic inheritance utilities.
62 (Generic_Inherited_Subprograms): Generic version of
63 Inherited_Subprograms, generic in Find_Dispatching_Type function.
64 (Generic_Is_Overriding_Subprogram): Generic version of
65 Is_Overriding_Subprogram, generic in Find_Dispatching_Type function.
66 (Inherited_Subprograms): Instance of Generic_Inherited_Subprograms with
67 Sem_Disp.Find_Dispatching_Type.
68 (Is_Overriding_Subprogram): Instance of
69 Generic_Is_Overriding_Subprogram with Sem_Disp.Find_Dispatching_Type.
70 (Inheritance_Utilities_Inst): Instance of Inheritance_Utilities
71 with Sem_Disp.Find_Dispatching_Type.
73 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
75 * exp_ch4.adb (Expand_Composite_Equality): For a composite (or FP)
76 component type, do not expand array equality using the unconstrained
77 base type, except for the case where the bounds of the type depend on a
80 2018-05-28 Ed Schonberg <schonberg@adacore.com>
82 * einfo.ads, einfo.adb (Needs_Activation_Record): New flag on
83 access-to-subprogram types, to indicate that an indirect call through
84 such a type requires an activation record when compiling for LLVM.
85 * sem_ch3.adb (Access_Subprogram_Declaration): Set new flag as needed.
87 2018-05-28 Ed Schonberg <schonberg@adacore.com>
89 * exp_ch4.adb (Real_Range_Check): Specialize float-to-fixed conversions
90 when bounds of fixed type are static, to remove some spuerfluous
91 implicit conversions and provide an accurate result when converting
92 back and forth between the fixed point type and a floating point type.
94 2018-05-28 Ed Schonberg <schonberg@adacore.com>
96 * exp_unst.adb (Unnest_Subprogram): Prevent creation of empty
99 2018-05-28 Richard Kenner <kenner@vlsi1.ultra.nyu.edu>
101 * exp_unst.adb (Check_Static_Type): Add argument to indicate node to be
102 replaced, if any; all callers changed.
103 (Note_Uplevel_Ref): Likewise. Also replace reference to deferred
104 constant with private view so we take the address of that entity.
105 (Note_Uplevel_Bound): Add argument to indicate node to be replaced, if
106 any; all callers changed. Handle N_Indexed_Component like
107 N_Attribute_Reference. Add N_Type_Conversion case.
108 (Visit_Node): Indexed references can be uplevel if the type isn't
110 (Unnest_Subprograms): Don't rewrite if no reference given. If call has
111 been relocated, set first_named pointer in original node as well.
113 2018-05-28 Ed Schonberg <schonberg@adacore.com>
115 * exp_aggr.adb (Flatten): Copy tree of expression in a component
116 association with a range or a set of discrete choices, rather than
117 relocating the node. This avoids inconsistencies in the tree when
118 handling nested subprograms with uplevel references for LLVM.
120 2018-05-28 Arnaud Charlet <charlet@adacore.com>
122 * exp_util.adb (Possible_Bit_Aligned_Component): Always return False in
125 2018-05-28 Arnaud Charlet <charlet@adacore.com>
127 * exp_unst.adb: Fix typo.
129 2018-05-28 Bob Duff <duff@adacore.com>
131 * libgnat/a-convec.adb (Query_Element): Minor cleanup: remove an
132 unnecessary use of 'Unrestricted_Access.
134 2018-05-28 Hristian Kirtchev <kirtchev@adacore.com>
136 * repinfo.adb (Expr_Value_S): New routine.
137 (List_Linker_Section): Properly extract the value of the section
140 2018-05-28 Patrick Bernardi <bernardi@adacore.com>
142 * doc/gnat_ugn/building_executable_programs_with_gnat.rst: Update the
143 description of the -D binder switch to reflect current usage.
144 * gnat_ugn.texi: Regenerate.
146 2018-05-28 Gary Dismukes <dismukes@adacore.com>
148 * exp_ch3.adb: Minor reformatting
150 2018-05-28 Justin Squirek <squirek@adacore.com>
153 (Build_Initialization_Call): Add logic to pass the appropriate actual to match
155 (Init_Formals): Add new formal *_skip_null_excluding_check
156 * exp_util.adb, exp_util.ads
157 (Enclosing_Init_Proc): Added to fetch the enclosing Init_Proc from the current
159 (Inside_Init_Proc): Refactored to use Enclosing_Init_Proc
160 (Needs_Conditional_Null_Excluding_Check): Added to factorize the predicate
161 used to determine how to generate an Init_Proc for a given type.
162 (Needs_Constant_Address): Minor reformatting
164 (Resolve_Null): Add logic to generate a conditional check in certain cases
166 2018-05-28 Hristian Kirtchev <kirtchev@adacore.com>
168 * exp_aggr.adb, gnatlink.adb, sem_ch6.adb, sem_res.adb, sem_util.adb:
171 2018-05-28 Hristian Kirtchev <kirtchev@adacore.com>
173 * sem_prag.adb (Process_Atomic_Independent_Shared_Volatile): Include
174 the declarations of single concurrent types because they fall in the
175 category of full type and object declarations.
177 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
179 * repinfo.adb (Compute_Max_Length): Skip _Parent component.
180 (List_Record_Layout): Likewise.
182 2018-05-28 Ed Schonberg <schonberg@adacore.com>
184 * sem_util.adb (Is_Function_Result): Add a warning if a postcondition
185 includes a call to function to which it applies. This may mean an
186 omission of an attribute reference 'Result, in particular if the
187 function is pqrameterless.
189 2018-05-28 Justin Squirek <squirek@adacore.com>
191 * sem_ch8.adb (Find_Expanded_Name): Add extra guard to make sure the
192 misresolved package name is not a case of mistaken identity.
194 2018-05-28 Yannick Moy <moy@adacore.com>
196 * sem_res.adb (Resolve_Range): Re-resolve the low bound of a range in
197 GNATprove mode, as the order of resolution (low then high) means that
198 all the information is not available when resolving the low bound the
201 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
203 * repinfo.adb (List_Array_Info): Start with an explicit blank line and
204 end with the linker section, if any.
205 (List_Entities): Do not output the linker section for record types,
206 array types and variables.
207 (Print_Expr): Factor out common processing for unary operators and
208 special values. Adjust and reorder the various cases.
209 (List_Object_Info): End with the linker section, if any.
210 (List_Record_Info): Likewise.
211 (List_Type_Info): Do not start with a blank line.
213 2018-05-25 Nicolas Roche <roche@adacore.com>
215 * libgnat/s-valrea.adb (Scan_Real): Abort computation once it is sure
216 that the result will be either -infinite or +infinite.
218 2018-05-25 Patrick Bernardi <bernardi@adacore.com>
220 * libgnat/s-parame.ads, libgnat/s-parame__vxworks.ads,
221 libgnat/s-parame__ae653.ads, libgnat/s-parame__hpux.ads (Size_Type):
222 Expand range of type to match the address space of the target.
223 (Task_Storage_Size): Remove unused type.
225 2018-05-25 Ed Schonberg <schonberg@adacore.com>
227 * sem_res.adb (Set_Mixed_Mode_Operand): If the operand is an expression
228 of a fixed point type and the parent is a multiplying operation,
229 resolve the operand with its own type because the context will impose a
230 resulting type on the result of the multiplication by means of
231 approriate conversion.
233 2018-05-25 Hristian Kirtchev <kirtchev@adacore.com>
235 * exp_ch3.adb (Default_Initialize_Object): Ensure that the analysis of
236 the in-place initialization aggregate created for pragmas
237 Initialize_Scalars or Normalize_Scalars is performed with checks
240 2018-05-25 Arnaud Charlet <charlet@adacore.com>
242 * exp_aggr.adb (Convert_To_Positional): Bump default for
243 Max_Others_Replicate to 32. Update comments.
244 * osint.ads (Unknown_Attributes): No longer pretend this is a constant.
245 (No_File_Info_Cache): Initialize separately.
246 * osint.adb (No_File_Info_Cache): Update initializer.
248 2018-05-25 Javier Miranda <miranda@adacore.com>
250 * sem_res.adb (Resolve_Membership_Op): Allow the use of the membership
251 test when the left operand is a class-wide interface and the right
252 operand is not a class-wide type.
253 * exp_ch4.adb (Tagged_Membership): Adding support for interface as the
256 2018-05-25 Ed Schonberg <schonberg@adacore.com>
258 * exp_aggr.adb (Flatten): A quantified expression cannot be duplicated
259 in an others clause to prevent visibility issues with the generated
261 (Component_OK_For_Backend): Return false for a quantified expression.
262 (Check_Static_Component): Ditto.
264 2018-05-25 Hristian Kirtchev <kirtchev@adacore.com>
266 * libgnat/s-secsta.adb (SS_Allocate): Reimplemented.
267 (SS_Allocate_Dynamic): New routine. The allocation logic is now split
268 into three distring cases rather than in one loop which attempts to
269 handle all three cases. This rewrite eliminates an issue where the last
270 frame of the stack cannot be freed, thus causing the memory range of a
271 new frame to approach the overflow point of the memory index type.
272 Since the overflow is logically treated as a
273 too-much-memory-on-the-stack scenario, it causes a bogus Storage_Error.
274 (SS_Allocate_Static): New routine. The routine factorizes the static
275 secondary stack-related code from the former SS_Allocate.
277 2018-05-25 Sergey Rybin <rybin@adacore.com>
279 * doc/gnat_ugn/gnat_and_program_execution.rst: Add description of '-U'
282 2018-05-25 Ed Schonberg <schonberg@adacore.com>
284 * sem_ch6.adb (Analyze_Subprogram_Body_Helper): Do not create
285 Class_Wide_Clone_Body when analyzing a subprogram_body_stub: the clone
286 is created when the proper body of the stub is analyzed.
287 * sem_util.adb (ZBuild_Class_Wide_Clone_Body): If the subprogram body
288 is the proper body of a subunit, the cloned body must be inserted in
289 the declarative list that contains the stub.
291 2018-05-25 Justin Squirek <squirek@adacore.com>
293 * exp_ch6.adb (Expand_Simple_Function_Return): Add guard in check to
294 generate code for 6.5(8-10) so that we don't get an assertion error
295 when dealing with an incomplete return type.
297 2018-05-25 Arnaud Charlet <charlet@adacore.com>
299 * pprint.adb (Expression_Name): Strip too long expressions to avoid
300 carrying very large strings.
302 2018-05-25 Patrick Bernardi <bernardi@adacore.com>
304 * switch-b.adb (Scan_Binder_Switches): binder switch -Q accepts Natural
307 2018-05-25 Doug Rupp <rupp@adacore.com>
309 * tracebak.c (aarch64-linux): Implement.
311 2018-05-25 Justin Squirek <squirek@adacore.com>
313 * sem_ch8.adb: Minor reformatting.
315 2018-05-25 Piotr Trojanek <trojanek@adacore.com>
317 * sem_util.adb (Iterate_Call_Parameters): Fix code convention and
320 2018-05-25 Hristian Kirtchev <kirtchev@adacore.com>
322 * einfo.adb, einfo.ads, exp_ch3.adb, exp_ch8.adb, exp_unst.adb,
323 pprint.adb, sem_ch12.adb, sem_ch3.adb, sem_prag.adb, sem_util.adb:
326 2018-05-25 Ed Schonberg <schonberg@adacore.com>
328 * sem_ch12.adb (Instance_Exists): New function, subsidiary of
329 Validate_Derived_Type_Instance, to verify that all interfaces
330 implemented by the formal type are also implemented by the actual. The
331 verification is complicated when an interface of the formal is declared
332 in a generic unit and the actual is declared in an instance of it.
333 There is currently no mechanism to relate an interface declared within
334 a generic to the corresponding interface in an instance, so we must
335 traverse the list of interfaces of the actual, looking for a name
336 match, and verifying that that interface is declared in an instance.
338 2018-05-25 Piotr Trojanek <trojanek@adacore.com>
340 * sem_util.adb (Iterate_Call_Parameters): Rewrite with extra
341 assertions; replace function versions of Next_Formal/Next_Actual with
342 their procedural versions (which are more concise).
344 2018-05-25 Doug Rupp <rupp@adacore.com>
346 * libgnarl/s-osinte__aix.ads, libgnarl/s-osinte__android.ads,
347 libgnarl/s-osinte__darwin.ads, libgnarl/s-osinte__freebsd.ads,
348 libgnarl/s-osinte__hpux.ads, libgnarl/s-osinte__kfreebsd-gnu.ads,
349 libgnarl/s-osinte__linux.ads, libgnarl/s-osinte__lynxos178e.ads,
350 libgnarl/s-osinte__qnx.ads, libgnarl/s-osinte__rtems.ads
351 (Relative_Timed_Wait): Remove.
352 * libgnarl/s-tpopmo.adb (Timed_Sleep, Timed_Delay): Rewrite to allow
353 for incremental looping. Remove references to Rel_Time and
355 * libgnat/s-osprim__posix.adb, libgnat/s-osprim__posix2008.adb
356 (Timed_Delay): Make separate.
357 * libgnat/s-optide.adb: New separate procedure.
358 * libgnat/s-osprim.ads (Max_System_Delay): New constant.
359 * libgnat/s-osprim__lynxos.ads (Max_Sensible_Delay): Set to 6 months.
360 (Max_System_Delay): New constant.
362 2018-05-25 Ed Schonberg <schonberg@adacore.com>
364 * sem_ch12.adb (Validate_Derived_Type_Instance): Verify that the actual
365 for a formal derived type implements all the interfaces declared for
368 2018-05-25 Yannick Moy <moy@adacore.com>
370 * sem_prag.adb (Check_Applicable_Policy): Deal specially with CodePeer
371 and GNATprove modes when applicable policy is Ignore.
373 2018-05-25 Eric Botcazou <ebotcazou@adacore.com>
375 * freeze.adb (Freeze_Enumeration_Type): Do not give integer size to a
376 boolean type with convention C.
377 * libgnat/i-cexten.ads (bool): Change to boolean with convention C.
378 * gcc-interface/decl.c (gnat_to_gnu_entity): Add new local variable
379 FOREIGN and use it throughout the function.
380 <E_Enumeration_Type>: Set precision 1 on boolean types with foreign
382 <E_Enumeration_Subtype>: Likewise for subtypes.
383 <E_Record_Type>: Force the size of a storage unit on empty classes.
384 * gcc-interface/utils.c (make_type_from_size) <BOOLEAN_TYPE>: Skip
385 boolean types with precision 1 if the size is the expected one.
387 2018-05-25 Arnaud Charlet <charlet@adacore.com>
389 * pprint.adb (Expression_Name): Do not print non ASCII characters.
391 2018-05-25 Bob Duff <duff@adacore.com>
393 * libgnat/a-strunb__shared.ads, libgnat/a-stwiun__shared.ads,
394 libgnat/a-stzunb__shared.ads: (Initialize, Adjust): Add pragma Inline.
396 2018-05-25 Bob Duff <duff@adacore.com>
398 * sem_util.ads: Minor comment fix.
400 2018-05-25 Ed Schonberg <schonberg@adacore.com>
402 * exp_unst.adb (Visit_Node): Restrict check for uplevel references in
403 prefixes of array attributes, to prefixes that are entity names whose
405 (Note_Uplevel_Bound): Verify that the bound is declared in an enclosing
406 subprogram, as itype created for loops in pre/postcondition may appear
407 in loops at the library level.
409 2018-05-25 Ed Schonberg <schonberg@adacore.com>
411 * sem_ch13.adb (Build_Predicate_Functions): The predicate function
412 declaration is inserted into the tree and analyzed at that point, so
413 should not be reinserted when the body is constructed. Inside a
414 generic, ensure that the body is not inserted twice in the tree.
416 2018-05-25 Yannick Moy <moy@adacore.com>
418 * sem_prag.adb (Check_Grouping): Modify test to ignore statements and
419 declarations not coming from source.
421 2018-05-25 Fedor Rybin <frybin@adacore.com>
423 * doc/gnat_ugn/gnat_utility_programs.rst: Document new switch
424 --copy-environment for gnattest.
426 2018-05-24 Piotr Trojanek <trojanek@adacore.com>
428 * sem_elab.adb (Non_Private_View): Simplify by removing a local Result
430 * sem_prag.adb (Get_Base_Subprogram): Same as above.
432 2018-05-24 Eric Botcazou <ebotcazou@adacore.com>
434 * fe.h (Set_Normalized_First_Bit): Declare.
435 (Set_Normalized_Position): Likewise.
436 * repinfo.adb (List_Record_Layout): Do not use irregular output for a
437 variable position. Fix minor spacing issue.
438 * gcc-interface/decl.c (annotate_rep): If a field has a variable
439 offset, compute the normalized position and annotate it in addition to
442 2018-05-24 Eric Botcazou <ebotcazou@adacore.com>
444 * gcc-interface/trans.c (Handled_Sequence_Of_Statements_to_gnu):
445 Constify and rename variables. Fix formatting.
446 (gnat_to_gnu) <N_Exception_Handler>: Minor tweak.
447 <N_Raise_Statement>: Likewise.
449 2018-05-24 Javier Miranda <miranda@adacore.com>
451 * exp_ch8.adb (Build_Body_For_Renaming): Adding support to build the
452 body of a variant record equality renaming.
453 (Expand_N_Subprogram_Renaming_Declaration): Adapt the code to the new
454 implementation of Build_Body_For_Renaming.
455 * exp_ch3.ads (Build_Variant_Record_Equality): New library level
456 function that factorizes the functionality needed by
457 Build_Body_For_Renaming and Expand_Freeze_Record_Type to build the body
458 of a variant record equality subprogram.
459 * exp_ch3.adb (Build_Variant_Record_Equality): New subprogram.
460 (Build_Variant_Record_Equality): New local procedure of
461 Expand_Freeze_Record_Type containing all the code specific for freezing
462 the record type that cannot be place in the new library level function.
464 2018-05-24 Ed Schonberg <schonberg@adacore.com>
466 * einfo.ads, einfo.adb (Is_Activation_Record): New flag on
467 in_parameters, used when unesting subprograms for LLVM, to indicate
468 that a generated parameter carries the activation record from the
469 enclosing subprogram.
470 * exp_unst.adb (Check_Static_Type): Handle array attributes of types
471 whose bounds may contain up-level references that need to be added to
472 an activation recoord.
473 (Add_Extra_Formal): Set Is_Activation_Record on new formal.
475 2018-05-24 Yannick Moy <moy@adacore.com>
477 * pprint.adb (Expression_Image): Improve the printing of expressions,
478 by taking more cases into account, in particular qualified expressions
479 and aggregates. Also count more the number of parentheses to close
480 after the expression.
482 2018-05-24 Javier Miranda <miranda@adacore.com>
484 * sem_ch3.adb (Is_Visible_Component): For untagged types add missing
485 check for renamed discriminants.
486 * sem_ch4.adb (Analyze_Overloaded_Selected_Component,
487 Analyze_Selected_Component, Check_Misspelled_Selector): For calls to
488 Is_Visible_Component pass the associated selector node to allow
489 checking renamed discriminants on untagged types.
491 2018-05-24 Ed Schonberg <schonberg@adacore.com>
493 * sem_ch8.adb (Analyze_Use_Type): Do not assign the Prev_Use_Clause
494 link to a use_type clause if this would cause an infinite loop in the
495 machinery that detects redundant use clauses. This may happen when the
496 redundant clauses appear in the context of a child unit and the context
499 2018-05-24 Piotr Trojanek <trojanek@adacore.com>
501 * sinfo.ads: Fix grammar in comment.
503 2018-05-24 Justin Squirek <squirek@adacore.com>
505 * einfo.ads, einfo.adb (Append_Entity): Modified to use Link_Entities
506 and manage doubly-linked entity chain.
507 (Nested_Scenarios): Removed entity field used for optimization during
508 elaboration to make room for the new field Prev_Entity.
509 (Link_Entities): Added to replace redundant calls to Set_Next_Entity
510 and Set_Prev_Entity as well as centralize changes to the entity chain.
511 (Predicated_Parent): Modified to use Node38.
512 (Prev_Entity): Added to fetch new node field Prev_Entity in all entity
514 (Remove_Entity): Moved from sem_util.
515 (Set_Nested_Scenarios): Deleted.
516 (Set_Predicated_Parent): Modified to use Node38.
517 (Set_Prev_Entity): Added to set Prev_Entity field.
518 (Set_Validated_Object): Modified to use Node38.
519 (Unlink_Next_Entity): Added to process Prev_Entity when an unlinking
521 (Validated_Object): Modified to use Node38.
522 (Write_Field36_Name): Remove Nested_Scenarios, Validated_Object, and
523 predicated parent cases.
524 (Write_Field38_Name): Add predicated parent and Validated_Object cases.
525 * sem_ch3.adb (Process_Subtype): Add guard to protect against
526 inappropriate marking of Predicated_Parent to non-itype subtypes.
527 (Make_Class_Wide_Type): Preserve Prev_Entity field and set in new type.
528 (Copy_And_Swap): Add setting of Prev_Entity.
529 (Build_derived_Record_Type): Replace Set_Next_Entity w/ Link_Entities.
530 * sem_ch6.adb (Analyze_Subprogram_Body_Helper): Replace Set_Next_Entity
532 (New_Overloaded_Entity): Remove block created to search for previous
533 entities in the entity chain with relevant calls to Prev_Entity as well
534 as replace duplicated code from Remove_Entity_And_Homonym with a call
536 * sem_ch7.adb (Exchange_Declarations): Replace Set_Next_Entity w/
538 * sem_elab.adb (Find_And_Process_Nested_Scenarios): Remove global and
539 initial subprogram declarations related to Nested_Scenarios.
540 (Process_Nested_Scenarios): Deleted.
541 (Save_Scenario): Deleted.
542 (Traverse_Body): Remove optimization for Nested_Scenarios so as to free
543 node space in the entity tree.
544 * sem_util.adb, sem_util.ads (Remove_Entity): Moved to einfo.
545 (Remove_Entity_And_Homonym): Added to separate functionality of
546 Remove_Entity from the homonym chain directly.
547 * exp_attr.adb (Expand_N_Attribute_Reference): Replace Set_Next_Entity
548 w/ Link_Entities and Unlink_Next_Entity.
549 * exp_ch3.adb (Expand_N_Object_Declaration): Replace Set_Next_Entity w/
551 * exp_ch6.adb (Replace_Renaming_Declaration_Id): Replace
552 Set_Next_Entity w/ Link_Entities.
553 * exp_disp.adb (Expand_Dispatching_Call): Replace Set_Next_Entity w/
554 Link_Entities and Unlink_Next_Entity.
555 * exp_spark.adb (Expand_SPARK_N_Object_Renaming_Declaration): Replace
556 call to Remove_Entity with its new incarnation.
557 * exp_util.adb (New_Class_Wide_Subtype): Add setting of Prev_Entity.
558 * freeze.adb (Freeze_Record_Type): Replace Set_Next_Entity w/
561 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
563 * sem_ch10.adb (Expand_Limited_With_Clause): Update the call to
564 Install_Limited_Withed_Unit.
565 (Expand_With_Clause): Update the call to Install_Withed_Unit.
566 (Implicit_With_On_Parent): Update the call to Install_Withed_Unit.
567 (Install_Context_Clauses): Update the call to Install_Withed_Unit.
568 (Install_Limited_Context_Clauses): Update the calls to
569 Install_Limited_Withed_Unit.
570 (Install_Limited_Withed_Unit): Renamed to better illustrate its
572 (Install_Private_With_Clauses): Update the calls to Install_Withed_Unit
573 and Install_Limited_Withed_Unit.
574 (Install_With_Clause): Uninstall a limited with clause if a [private]
575 with clause is given for the same package.
576 (Install_Withed_Unit): Renamed to better illustrate its purpose.
577 (Remove_Limited_With_Unit): New routine.
579 2018-05-24 Eric Botcazou <ebotcazou@adacore.com>
581 * raise-gcc.c (__gnat_SEH_error_handler): Remove prototype.
582 (__gnat_personality_seh0): Adjust and beef up comments, and
583 fix formatting throughout.
584 (__gnat_adjust_context): Deal minimally with version 2.
585 * seh_init.c (__gnat_map_SEH): Fix formatting.
586 (_gnat_SEH_error_handler): Adjust comments.
587 (__gnat_install_SEH_handler): Fix formatting.
589 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
591 * exp_ch7.adb, sem_ch3.adb, sem_res.adb: Minor reformatting.
593 2018-05-24 Ed Schonberg <schonberg@adacore.com>
595 * exp_aggr.adb (Flatten): Add a warning on an others clause in an array
596 aggregate with static bounds when named associations cover all index
597 positions and the others clause is redundant.
599 2018-05-24 Raphael Amiard <amiard@adacore.com>
601 * libgnat/a-cohama.ads: Add documentation.
603 2018-05-24 Raphael Amiard <amiard@adacore.com>
605 * libgnat/a-convec.ads: Add documentation.
607 2018-05-24 Justin Squirek <squirek@adacore.com>
609 * exp_ch3.adb (Expand_N_Object_Declaration): Ignore raising an error in
610 expansion for limited tagged types when the node to be expanded is a
611 raise expression due to it not representing a valid object.
612 * exp_ch5.adb (Expand_N_Assignment_Statement): Add exception to error
613 message regarding assignments to limited types to ignore genereated
616 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
618 * exp_util.adb (New_Class_Wide_Subtype): Capture and restore relevant
619 Ghost-related attributes of the class-wide subtype because the copy
622 2018-05-24 Justin Squirek <squirek@adacore.com>
624 * sem_res.adb (Resolve_Entity_Name): Add guard to protect against
625 marking use clauses as effective when the reference appears within
628 2018-05-24 Cyrille Comar <comar@adacore.com>
630 * doc/gnat_rm/the_gnat_library.rst: Fix typos.
631 * gnat_rm.texi: Regenerate.
633 2018-05-24 Bob Duff <duff@adacore.com>
635 * exp_ch7.adb (Expand_Cleanup_Actions): Create a mark unconditionally
636 for build-in-place functions with a caller-unknown-size result.
637 (Create_Finalizer): For build-in-place functions with a
638 caller-unknown-size result, check at run time whether we need to
639 release the secondary stack.
641 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
643 * sem_prag.adb (Analyze_Pragma): Use the full view of an internally
644 generated incomplete type.
646 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
648 * expander.adb (Expand): Update the save and restore of the Ghost
650 * exp_ch3.adb (Freeze_Type): Likewise.
651 * exp_disp.adb (Make_DT): Likewise.
652 * exp_util.adb (Build_DIC_Procedure_Body): Likewise.
653 (Build_DIC_Procedure_Declaration): Likewise.
654 (Build_Invariant_Procedure_Body): Likewise.
655 (Build_Invariant_Procedure_Declaration): Likewise.
656 (Make_Predicate_Call): Likewise.
657 * freeze.adb (Add_To_Result): Insert the freeze action of a living
658 entity prior to the start of the enclosing ignored Ghost region.
659 (Freeze_Entity): Update the save and restore of the Ghost region.
660 * ghost.adb (Install_Ghost_Mode): Reimplemented.
661 (Install_Ghost_Region): New routine.
662 (Mark_And_Set_Ghost_Assignment): Install a region rather than a mode.
663 (Mark_And_Set_Ghost_Body): Likewise.
664 (Mark_And_Set_Ghost_Completion): Likewise.
665 (Mark_And_Set_Ghost_Declaration): Likewise.
666 (Mark_And_Set_Ghost_Instantiation): Likewise.
667 (Mark_And_Set_Ghost_Procedure_Call): Likewise.
668 (Name_To_Ghost_Mode): New routine.
669 (Restore_Ghost_Region): New routine.
670 * ghost.ads (Install_Ghost_Region): New routine.
671 (Restore_Ghost_Region): New routine.
672 * opt.ads: Add new global variable Ignored_Ghost_Region.
673 * rtsfind.adb (Load_RTU): Update the save and restore of the Ghost
674 region. Install a clean region.
675 * sem.adb (Analyze): Likewise.
676 (Do_Analyze): Likewise.
677 * sem_ch3.adb (Analyze_Object_Declaration): Likewise
678 (Derive_Progenitor_Subprograms): Use local variable Iface_Alias to
679 capture the ultimate alias of the current primitive.
680 (Process_Full_View): Update the save and restore of the Ghost region.
681 Do not inherit DIC and invariant procedures.
682 * sem_ch5.adb (Analyze_Assignment): Update the save and restore of the
684 * sem_ch6.adb (Analyze_Procedure_Call): Likewise.
685 (Analyze_Subprogram_Body_Helper): Likewise.
686 * sem_ch7.adb (Analyze_Package_Body_Helper): Likewise.
687 * sem_ch12.adb (Analyze_Package_Instantiation): Likewise.
688 (Analyze_Subprogram_Instantiation): Likewise.
689 (Instantiate_Package_Body): Likewise.
690 (Instantiate_Subprogram_Body): Likewise.
691 * sem_ch13.adb (Build_Predicate_Functions): Likewise.
692 (Build_Predicate_Function_Declaration): Likewise.
694 (Add_Dispatching_Operation): Do not consider DIC and invariant
696 (Check_Dispatching_Operation): Use Add_Dispatching_Operation to collect
697 a dispatching subprogram.
698 (Check_Operation_From_Private_View): Likewise.
699 (Override_Dispatching_Operation): Likewise.
700 * sem_prag.adb (Analyze_Contract_Cases_In_Decl_Part): Update the save
701 and restore of the Ghost region.
702 (Analyze_Initial_Condition_In_Decl_Part): Likewise.
703 (Analyze_Pragma): Update the save and restore of the Ghost region.
704 (Analyze_Pre_Post_Condition_In_Decl_Part): Likewise.
705 * sem_util.adb (Is_Suitable_Primitive): New routine.
706 * sem_util.ads (Is_Suitable_Primitive): New routine.
707 * sinfo.ads: Update the section of Ghost regions.
709 2018-05-24 Piotr Trojanek <trojanek@adacore.com>
711 * doc/gnat_rm/implementation_defined_pragmas.rst (Contract_Cases):
712 Change "condition" to "case guard" after renaming in the contract
714 * gnat_rm.texi: Regenerate.
716 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
718 * exp_util.adb (Expand_Static_Predicates_In_Choices): Indicate that the
719 construct with discrete choices no longer contains a subtype with
720 predicates since the expansion already handled this case.
722 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
724 * freeze.adb (Wrap_Imported_Subprogram): Generate an unchecked
725 conversion to the return type to avoid a side effect where an imported
726 relocated function generates a new anonymous access type, whose
727 accessibility level does not agree with with that of the wrapper.
729 2018-05-24 Javier Miranda <miranda@adacore.com>
731 * sem_util.adb (Abstract_Interface_List): Add missing support for
732 private types whose full view is a synchronized type.
733 * sem_ch3.adb (Build_Derived_Private_Type): Skip building the full
734 derivation of a private type parent type is a task type with
735 discriminants as gigi does not use such type directly.
737 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
739 * sem_elab.adb (Build_Variable_Reference_Marker): Do not create a
740 variable marker when the reference appears in the formal part of a
741 compilation unit instance because there is no place to insert it.
742 (In_Compilation_Instance_Formal_Part): New routine.
744 2018-05-24 Piotr Trojanek <trojanek@adacore.com>
746 * layout.ads, repinfo.ads: Fix references to renamed Backend_Layout
747 configuration parameter.
749 2018-05-24 Doug Rupp <rupp@adacore.com>
751 * argv-lynxos178-raven-cert.c: New file.
752 * libgnat/system-lynxos178-x86.ads: New file.
754 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
756 * exp_disp.adb, freeze.adb, gnat1drv.adb, sem_ch5.adb, sem_spark.adb:
759 2018-05-23 Pascal Obry <obry@adacore.com>
761 * adaint.c (win32_wait): Properly free the handle/pid lists when
762 WaitForMultipleObjects fails (return WAIT_FAILED).
764 2018-05-23 Pascal Obry <obry@adacore.com>
766 * adaint.c (win32_wait): Add missing parentheses.
768 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
770 * exp_ch3.adb (Check_Large_Modular_Array): Moved to Freeze.
771 (Expand_N_Object_Declaration): Do not check for a large modular array
773 * freeze.adb (Check_Large_Modular_Array): Moved from Exp_Ch3.
774 (Freeze_Object_Declaration): Code cleanup. Check for a large modular
776 * sem_ch3.adb: Minor reformatting.
778 2018-05-23 Ed Schonberg <schonberg@adacore.com>
780 * einfo.ads: New attribute on types: Predicated_Parent, to simplify the
781 retrieval of the applicable predicate function to an itype created for
782 a constrained array component.
783 * einfo.adb: Subprograms for Predicated_Parent.
784 (Predicate_Function): Use new attribute.
785 * exp_util.adb (Make_Predicate_Call): If the predicate function is not
786 available for a subtype, retrieve it from the base type, which may have
787 been frozen after the subtype declaration and not captured by the
789 * sem_aggr.adb (Resolve_Array_Aggregate): An Others association is
790 legal within a generated initiqlization procedure, as may happen with a
791 predicate check on a component, when the predicate function applies to
792 the base type of the component.
793 * sem_ch3.adb (Analyze_Subtype_Declaration): Clean up inheritance of
794 predicates for subtype declarations and for subtype indications in
796 (Process_Subtype): Likewise. Handle properly the case of a private type
797 with unknown discriminants whose full view is an unconstrained array.
798 Use Predicated_Parent to indicate source of predicate function on an
799 itype whose parent is itself an itype.
800 (Complete_Private_Subtype): If the private view has unknown
801 discriminants and the full view is an unconstrained array, set base
802 type of completion to the full view of parent.
803 (Inherit_Predicate_Flags): Prevent double assignment of predicate
805 (Build_Subtype): For a constrained array component, propagate predicate
806 information from original component type declaration.
808 2018-05-23 Boris Yakobowski <yakobowski@adacore.com>
810 * libgnat/a-ngelfu.ads (Arctanh, Arccoth): Fix faulty preconditions.
812 2018-05-23 Arnaud Charlet <charlet@adacore.com>
814 * checks.adb (Minimize_Eliminate_Overflows): Default initialize Lo and
816 * sem_elab.adb: Make "out" parameters instead of "in out" when
819 2018-05-23 Bob Duff <duff@adacore.com>
821 * gnatbind.adb (List_Applicable_Restrictions): Add
822 No_Implementation_Restrictions to the list of restrictions not to list.
823 Remove double negative "not No_Restriction_List". Comment the
824 commentary that is output, so it won't cause errors if used directly in
827 2018-05-23 Ed Schonberg <schonberg@adacore.com>
829 * sem_prag.adb (Inherit_Class_Wide_Pre): Refine legality check on
830 class-wide precondition on a type extension when ancestor does not have
831 a class-wide precondition. Previously the compiler accepted such a
832 precondition when the ancestor had a class-wide postcondition.
834 2018-05-23 Javier Miranda <miranda@adacore.com>
836 * sem_attr.adb (Valid_Scalars): Do not invoke Error_Attr_P to report
837 the warning on occurrences of this attribute whose evaluation is always
838 true (since that subprogram aborts processing the attribute). In
839 addition, replace the node by its boolean result 'True' (required
840 because the backend has no knowledge of this attribute).
842 2018-05-23 Bob Duff <duff@adacore.com>
844 * libgnat/a-convec.adb: (Insert, Insert_Space): Suppress warnings. The
845 code in question is not reachable in the case where Count_Type'Last is
848 2018-05-23 Yannick Moy <moy@adacore.com>
850 * doc/gnat_rm/implementation_defined_pragmas.rst: Clarify meaning of
851 local pragma Warnings Off without On.
852 * gnat_rm.texi: Regenerate.
854 2018-05-23 Olivier Hainque <hainque@adacore.com>
856 * libgnat/g-excact.ads (Is_Foreign_Exception): New predicate.
857 * libgnat/g-excact.adb: Implement.
859 2018-05-23 Ed Schonberg <schonberg@adacore.com>
861 * sem_ch5.adb (Analyze_Iterator_Specification): If a subtype indication
862 is present, verify its legality when the domain of iteration is a
863 GNAT-specific formal container, as is already done for arrays and
864 predefined containers.
866 2018-05-23 Yannick Moy <moy@adacore.com>
868 * sem_util.adb (Enclosing_Declaration): Fix the case of a named number
869 declaration, which was not taken into account.
871 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
873 * debug.adb: Switch -gnatd_s is now used to stop elaboration checks on
874 synchronized suspension.
875 * rtsfind.ads: Add entries for units Ada.Synchronous_Barriers and
876 Ada.Synchronous_Task_Control and routines Suspend_Until_True and
878 * sem_elab.adb: Document switch -gnatd_s.
879 (In_Task_Body): New routine.
880 (Is_Potential_Scenario): Code cleanup. Stop the traversal of a task
881 body when the current construct denotes a synchronous suspension call,
882 and restriction No_Entry_Calls_In_Elaboration_Code or switch -gnatd_s
884 (Is_Synchronous_Suspension_Call): New routine.
885 * switch-c.adb (Scan_Front_End_Switches): Switch -gnatJ now sets switch
888 2018-05-23 Javier Miranda <miranda@adacore.com>
890 * exp_disp.adb (Make_DT): Restrict the initialization of
891 External_Tag and Expanded_Name to an empty string to the case where
892 both pragmas apply (i.e. No_Tagged_Streams and Discard_Names), since
893 restricted runtimes are compiled with pragma Discard_Names.
894 * doc/gnat_rm/implementation_defined_pragmas.rst,
895 doc/gnat_rm/implementation_defined_characteristics.rst: Add
897 * gnat_rm.texi: Regenerate.
899 2018-05-23 Maroua Maalej <maalej@adacore.com>
901 * sem_spark.adb: Fix of some permission rules of pointers in SPARK.
903 2018-05-23 Ed Schonberg <schonberg@adacore.com>
905 * sem_ch5.adb (Preanalyze_Range): The pre-analysis of the domain of
906 iteration of an Ada2012 loop is performed to determine the type of the
907 domain, but full analysis is performed once the loop is rewritten as a
908 while-loop during expansion. The pre-analysis suppresses expansion; it
909 must also suppress the generation of freeze nodes, which may otherwise
910 appear in the wrong scope before rewritting.
912 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
914 * sem_elab.adb: Update the section on suppressing elaboration warnings.
916 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
918 * einfo.adb (Is_Elaboration_Checks_OK_Id): Use predicate
919 Is_Elaboration_Target.
920 (Is_Elaboration_Target): New routine.
921 (Is_Elaboration_Warnings_OK_Id): Use predicate Is_Elaboration_Target.
922 (Set_Is_Elaboration_Checks_OK_Id): Use predicate Is_Elaboration_Target.
923 (Set_Is_Elaboration_Warnings_OK_Id): Use predicate
924 Is_Elaboration_Target.
925 * einfo.ads: Add new synthesized attribute Is_Elaboration_Target along
926 with occurrences in nodes.
927 (Is_Elaboration_Target): New routine.
928 * sem_prag.adb (Analyze_Pragma): Suppress elaboration warnings when an
929 elaboration target is subject to pragma Warnings (Off, ...).
931 2018-05-23 Eric Botcazou <ebotcazou@adacore.com>
933 * repinfo.adb (List_Type_Info): Remove obsolete stuff.
935 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
937 * einfo.adb: Flag304 is now Is_Elaboration_Warnings_OK_Id.
938 (Is_Elaboration_Warnings_OK_Id): New routine.
939 (Set_Is_Elaboration_Warnings_OK_Id): New routine.
940 (Write_Entity_Flags): Output Flag304.
941 * einfo.ads: Add new attribute Is_Elaboration_Warnings_OK_Id along with
942 occurrences in entities.
943 (Is_Elaboration_Warnings_OK_Id): New routine along with pragma Inline.
944 (Set_Is_Elaboration_Warnings_OK_Id): New routine along with pragma
946 * sem_attr.adb (Analyze_Access_Attribute): Capture the state of
947 elaboration warnings.
948 * sem_ch3.adb (Analyze_Object_Declaration): Capture the state of
949 elaboration warnings.
950 * sem_ch6.adb (Analyze_Abstract_Subprogram_Declaration): Capture the
951 state of elaboration warnings.
952 (Analyze_Subprogram_Body_Helper): Capture the state of elaboration
954 (Analyze_Subprogram_Declaration): Capture the state of elaboration
956 * sem_ch9.adb (Analyze_Entry_Declaration): Capture the state of
957 elaboration warnings.
958 (Analyze_Single_Task_Declaration): Capture the state of elaboration
960 (Analyze_Task_Type_Declaration): Capture the state of elaboration
962 * sem_ch12.adb (Analyze_Generic_Package_Declaration): Capture the state
963 of elaboration warnings.
964 (Analyze_Generic_Subprogram_Declaration): Capture the state of
965 elaboration warnings.
966 * sem_elab.adb: Add a section on suppressing elaboration warnings.
967 Type Processing_Attributes includes component Suppress_Warnings
968 intended to suppress any elaboration warnings along a path in the
969 graph. Update Initial_State to include a value for this component.
970 Types Target_Attributes and Task_Attriutes include component
971 Elab_Warnings_OK to indicate whether the target or task has elaboration
972 warnings enabled. component Elab_Warnings_OK.
973 (Build_Access_Marker): Propagate attribute
974 Is_Elaboration_Warnings_OK_Node from the attribute to the generated
976 (Extract_Instantiation_Attributes): Set the value for Elab_Warnings_OK.
977 (Extract_Target_Attributes): Set the value for Elab_Warnings_OK.
978 (Extract_Task_Attributes): Set the value for Elab_Warnings_OK.
979 (Process_Conditional_ABE_Access): Suppress futher elaboration warnings
980 when already in this mode or when the attribute or target have warnings
982 (Process_Conditional_ABE_Activation_Impl): Do not emit any diagnostics
983 if warnings are suppressed.
984 (Process_Conditional_ABE_Call): Suppress further elaboration warnings
985 when already in this mode, or the target or call have warnings
987 (Process_Conditional_ABE_Call_Ada): Do not emit any diagnostics if
988 warnings are suppressed.
989 (Process_Conditional_ABE_Call_SPARK): Do not emit any diagnostics if
990 warnings are suppressed.
991 (Process_Conditional_ABE_Instantiation): Suppress further elaboration
992 warnings when already in this mode or when the instantiation has
994 (Process_Conditional_ABE_Instantiation_Ada): Do not emit any
995 diagnostics if warnings are suppressed.
996 (Process_Conditional_ABE_Variable_Assignment_Ada): Use the more
997 specific Is_Elaboration_Warnings_OK_Id rather than Warnings_Off.
998 (Process_Conditional_ABE_Variable_Assignment_SPARK): Use the more
999 specific Is_Elaboration_Warnings_OK_Id rather than Warnings_Off.
1000 (Process_Task_Object): Suppress further elaboration warnings when
1001 already in this mode, or when the object, activation call, or task type
1002 have warnings suppressed. Update the processing state to indicate that
1003 the path goes through a task body.
1004 * sinfo.adb (Is_Elaboration_Warnings_OK_Node): Accept attribute
1006 (Set_Is_Elaboration_Warnings_OK_Node): Accept attribute references.
1007 * sinfo.ads: Attribute Is_Elaboration_Warnings_OK_Node now applies to
1008 attribute references.
1010 2018-05-23 Piotr Trojanek <trojanek@adacore.com>
1012 * einfo.ads: Minor reformatting.
1014 2018-05-23 Ed Schonberg <schonberg@adacore.com>
1016 * sem_ch3.adb (Analyze_Object_Declaration): If expression is an
1017 anonymous_access_to_ subprogram formal, apply a conversion to force an
1018 accsssibility check that will fail statically, enforcing 3.10.2 (13).
1020 2018-05-23 Daniel Mercier <mercier@adacore.com>
1022 * gnat1drv.adb: Turn off length expansion in CodePeer mode.
1024 2018-05-23 Bob Duff <duff@adacore.com>
1026 * freeze.adb: (Check_Address_Clause): Deal with build-in-place
1027 aggregates in addition to build-in-place calls.
1029 2018-05-23 Bob Duff <duff@adacore.com>
1031 * einfo.ads: Minor reformatting.
1032 * sem_ch3.adb: Likewise.
1033 * sinfo.ads: Likewise.
1035 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
1037 * exp_ch3.adb (Default_Initialize_Object): Do not optimize scalar array
1038 initialization when the component type has predicates.
1039 * exp_ch4.adb (Expand_N_Allocator): Do not optimize scalar array
1040 allocation when the component type has predicates.
1042 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
1044 * einfo.adb, exp_disp.adb, sem_ch3.adb, sem_ch6.adb, sem_prag.adb:
1047 2018-05-22 Justin Squirek <squirek@adacore.com>
1049 * sem_ch6.adb (Analyze_Expression_Function): Propagate flags from the
1050 original function spec into the generated function spec due to
1051 expansion of expression functions during analysis.
1052 (Analyze_Subprogram_Body_Helper): Modify check on formal parameter
1053 references from the body to the subprogram spec in the case of
1054 expression functions because of inconsistances related to having a
1056 * libgnarl/s-osinte__android.ads: Flag parameters as unused.
1057 * libgnarl/s-osinte__lynxos178e.ads: Likewise.
1058 * libgnarl/s-osinte__qnx.adb: Likewise.
1059 * libgnarl/s-osinte__qnx.ads: Likewise.
1061 2018-05-22 Doug Rupp <rupp@adacore.com>
1063 * init.c (HAVE_ADJUST_CONTEXT_FOR_RAISE): Don't define on VxWorks7 for
1066 2018-05-22 Olivier Hainque <hainque@adacore.com>
1068 * libgnat/a-except.adb (Exception_Propagation.Propagate_Exception):
1069 Expect an Exception_Occurence object, not an Access.
1070 (Complete_And_Propagate_Occurrence): Adjust accordingly.
1071 (Raise_From_Signal_Handler): Likewise.
1072 (Reraise_Occurrence_No_Defer): If we have a Machine_Occurrence
1073 available in the provided occurrence object, just re-propagate the
1074 latter as a bare "raise;" would do.
1075 * libgnat/a-exexpr.adb (Propagate_Exception): Adjust to spec change.
1076 * libgnat/a-exstat.adb (String_To_EO): Initialize X.Machine_Occurrence
1077 to null, to mark that the occurrence we're crafting from the stream
1078 contents is not being propagated (yet).
1080 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
1082 * exp_aggr.adb (Initialize_Ctrl_Record_Component): Insert the generated
1083 code for a transient component in line with the rest of the
1084 initialization code, rather than before the aggregate. This ensures
1085 that the component has proper visibility of the discriminants.
1087 2018-05-22 Jerome Lambourg <lambourg@adacore.com>
1089 * adaint.c: Reorganize QNX-specific macros, use syspage to retreive the
1092 2018-05-22 Jerome Lambourg <lambourg@adacore.com>
1094 * sigtramp-qnx.c: Properly restore link register in signal trampoline.
1096 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
1098 * exp_aggr.adb (Aggr_Assignment_OK_For_Backend): Strip away any
1099 conversions before extracting the value of the expression.
1100 * exp_ch3.adb (Default_Initialize_Object): Optimize the default
1101 initialization of an array of scalars.
1102 (Get_Simple_Init_Val): Add processing for array types. Remove the
1103 processing of strings because this case is already handled by the array
1105 (Needs_Simple_Initialization): Moved to Sem_Util.
1106 (Simple_Init_Array_Type): New routine.
1107 (Simple_Init_Initialize_Scalars_Type): Reimplemented to use the new
1108 facilities from Sem_Util.
1109 (Simple_Initialization_OK): New routine.
1110 * exp_ch3.ads (Needs_Simple_Initialization): Moved to Sem_Util.
1111 * exp_ch4.adb (Expand_N_Allocator): Optimize the default allocation of
1112 an array of scalars.
1113 * sem_prag.adb (Analyze_Float_Value): New routine.
1114 (Analyze_Integer_Value): New routine.
1115 (Analyze_Pragma): Reimplement the analysis of pragma Initialize_Scalars
1116 to handled the extended form of the pragma.
1117 (Analyze_Type_Value_Pair): New routine.
1118 * sem_util.adb: Add invalid value-related data structures.
1119 (Examine_Array_Bounds): New routine.
1120 (Has_Static_Array_Bounds): Reimplemented.
1121 (Has_Static_Non_Empty_Array_Bounds): New routine.
1122 (Invalid_Scalar_Value): New routine.
1123 (Needs_Simple_Initialization): Moved from Exp_Ch3.
1124 (Set_Invalid_Scalar_Value): New routines.
1125 * sem_util.ads (Has_Static_Non_Empty_Array_Bounds): New routine.
1126 (Invalid_Scalar_Value): New routine.
1127 (Needs_Simple_Initialization): Moved from Exp_Ch3.
1128 (Set_Invalid_Scalar_Value): New routines.
1129 * snames.ads-tmpl: Add names for the salar type families used by pragma
1132 2018-05-22 Javier Miranda <miranda@adacore.com>
1134 * exp_disp.adb (Make_DT): Initialize the External_Tag with an empty
1135 string when pragma No_Tagged_Streams is applicable to the tagged type,
1136 and initialize the Expanded_Name with an empty string when pragma
1137 Discard_Names is applicable to the tagged type.
1139 2018-05-22 Ed Schonberg <schonberg@adacore.com>
1141 * sem_ch6.adb (Check_Conformance): Add RM reference for rule that a
1142 formal subprogram is never subtype conformqnt, and thus cannot be the
1143 prefix of 'Access. Reject as well the attribute when applied to a
1144 renaming of a formal subprogram.
1146 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
1148 * exp_ch3.adb (Build_Array_Init_Proc): Update the call to
1149 Needs_Simple_Initialization.
1150 (Build_Init_Statements): Update the call to Get_Simple_Init_Val.
1151 (Check_Subtype_Bounds): Renamed to Extract_Subtype_Bounds. Update the
1152 profile and comment on usage.
1153 (Default_Initialize_Object): Do not use New_Copy_Tree to set the proper
1154 Sloc of a value obtained from aspect Default_Value because this could
1155 potentially replicate large trees. The proper Sloc is now set in
1156 Get_Simple_Init_Val.
1157 (Get_Simple_Init_Val): Reorganized by breaking the various cases into
1158 separate routines. Eliminate the use of global variables.
1159 (Init_Component): Update the call to Get_Simple_Init_Val.
1160 (Needs_Simple_Initialization): Update the parameter profile and all
1162 (Simple_Init_Defaulted_Type): Copy the value of aspect Default_Value
1163 and set the proper Sloc.
1164 * exp_ch3.ads (Get_Simple_Init_Val): Update the parameter profile and
1166 (Needs_Simple_Initialization): Update the parameter profile.
1168 2018-05-22 Patrick Bernardi <bernardi@adacore.com>
1170 * sem_ch3.adb (Build_Discriminant_Constraints): Raise an error if the
1171 user tries to use a subtype indication as a discriminant constraint.
1173 2018-05-22 Ed Schonberg <schonberg@adacore.com>
1175 * exp_ch4.ads, exp_ch4.adb, exp_util.adb, expander.adb: Remove mention
1176 of N_Reduction_Expression and N_Reduction_Expression_Parameter.
1177 * par-ch4.adb: Remove parsing routines for reduction expressions.
1178 * sem.adb, sinfo.ads, sinfo.adb, sem_ch4.ads, sem_ch4.adb, sem_res.adb,
1179 sem_spark.adb, sprint.adb: Remove analysis routines for reduction
1182 2018-05-22 Arnaud Charlet <charlet@adacore.com>
1184 * sem_ch8.adb (Check_Frozen_Renaming): Do not emit error in
1185 Relaxed_RM_Semantics mode.
1187 2018-05-22 Arnaud Charlet <charlet@adacore.com>
1189 * comperr.adb (Delete_SCIL_Files): Take into account
1190 N_Generic_Package_Renaming_Declaration.
1192 2018-05-22 Ed Schonberg <schonberg@adacore.com>
1194 * sem_ch3.adb (Search_Derivation_Levels): Whenever a parent type is
1195 private, use the full view if available, because it may include renamed
1196 discriminants whose values are stored in the corresponding
1199 2018-05-22 Ed Schonberg <schonberg@adacore.com>
1201 * einfo.ads, einfo.adb: New attribute Hidden_In_Formal_Instance,
1202 defined on packages that are actuals for formal packages, in order to
1203 set/reset the visibility of the formals of a formal package with given
1204 actuals, when there are subsequent uses of those formals in the
1205 enclosing generic, as required by RN 12.7 (10).
1206 * atree.ads, atree.adb: Add operations for Elist30.
1207 * atree.h: Add Elist30.
1208 * sem_ch12.adb (Analyze_Formal_Package_Instantiation): Collect formals
1209 that are not defaulted and are thus not visible within the current
1211 (Check_Formal_Packages): Reset visibility of formals of a formal
1212 package that are not defaulted, on exit from current instance.
1214 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
1216 * sem_prag.adb (Analyze_Input_Output): Emit an error when a non-null,
1217 non-'Result output appears in the output list of a function.
1219 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
1221 * exp_attr.adb (Build_Array_VS_Func): Reimplemented.
1222 (Build_Record_VS_Func): Reimplemented.
1223 (Expand_N_Attribute): Reimplement the handling of attribute
1225 * sem_attr.adb (Analyze_Attribute): Reimplement the handling of
1226 attribute 'Valid_Scalars.
1227 * sem_util.adb (Scalar_Part_Present): Reimplemented.
1228 (Validated_View): New routine.
1229 * sem_util.ads (Scalar_Part_Present): Update the parameter profile and
1231 (Validated_View): New routine.
1232 * doc/gnat_rm/implementation_defined_attributes.rst: Update the
1233 documentation of attribute 'Valid_Scalars.
1234 * gnat_rm.texi: Regenerate.
1236 2018-05-22 Bob Duff <duff@adacore.com>
1238 * binde.adb: (Choose): Ignore a pragma Elaborate_Body that appears in
1239 the spec of a SAL_Interface package.
1241 2018-05-22 Ed Schonberg <schonberg@adacore.com>
1243 * freeze.adb (Freeze_Entity): When analyzing delayed aspects of an
1244 entity E within a generic unit, indicate that there are no remaining
1245 delayed aspects after invoking Analyze_Aspects_At_Freeze_Point. The
1246 entity E is not frozen yet but the aspects should not be reanalyzed at
1247 the freeze point, which may be outside of the generic and may not have
1248 the proper visibility.
1250 2018-05-22 Bob Duff <duff@adacore.com>
1252 * doc/gnat_ugn/gnat_utility_programs.rst: Add documentation for
1253 the new --split-line-before-record, --indent-named-statements and
1254 --no-align-modes gnatpp switches.
1256 2018-05-22 Ed Schonberg <schonberg@adacore.com>
1258 * sem_prag.adb (Process_Compile_Time_Warning_Or_Error): Handle properly
1259 a second argument that is a constant of a given string value.
1261 2018-05-22 Doug Rupp <rupp@adacore.com>
1263 * sigtramp-vxworks-target.inc: Align stack to 128bits on AArch64.
1265 2018-05-22 Jerome Lambourg <lambourg@adacore.com>
1267 * sigtramp-qnx.c: Fix stack alignment issue in the signal trampoline.
1269 2018-05-22 Ed Schonberg <schonberg@adacore.com>
1271 * freeze.adb (Freeze_Fixed_Point_Type): If the first subtype has
1272 delayed aspects, analyze them now, os that the representation of the
1273 type (size, bounds) can be computed and validated.
1275 2018-05-22 Olivier Hainque <hainque@adacore.com>
1277 * libgnat/s-dwalin.adb (Enable_Cache): Skip symbols outside of the
1278 executable code section boundaries.
1280 2018-05-22 Javier Miranda <miranda@adacore.com>
1282 * locales.c: New implementation for the Ada.Locales package.
1283 * libgnat/a-locale.ads: Remove comment indicating that this is not
1285 * doc/gnat_rm/standard_library_routines.rst: Remove comment indicating
1286 that this is not implemented.
1287 * gnat_rm.texi: Regenerate.
1289 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
1291 * exp_ch5.adb, freeze.adb, pprint.adb, sem_ch4.adb, sem_res.adb: Minor
1294 2018-05-22 Justin Squirek <squirek@adacore.com>
1296 * sem_ch12.adb (In_Same_Declarative_Part): Moved to sem_util.
1297 (Freeze_Subprogram_Body, Install_Body): Modify calls to
1298 In_Same_Declarative_Part.
1299 * sem_prag.adb (Analyze_Pragma-Pragma_Pure_Function): Add check to
1300 verify pragma declaration is within the same declarative list with
1301 corresponding error message.
1302 * sem_util.adb, sem_util.ads (In_Same_Declarative_Part): Moved from
1303 sem_ch12.adb and generalized to be useful outside the scope of
1306 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
1308 * sem_ch6.adb (Analyze_Subprogram_Declaration): Set the proper
1309 categorization of the unit after processing the aspects in case one of
1310 its aspects is converted into a categorization pragma.
1312 2018-05-21 Ed Schonberg <schonberg@adacore.com>
1314 * freeze.adb (Warn_Overlay): Do not emit a wawrning on an object
1315 declaration with an explicit address clause and a type with default
1316 initialization, if the declaration carries an aspect
1317 Suppress_Initialization.
1319 2018-05-21 Daniel Mercier <mercier@adacore.com>
1321 * pprint.adb: Use mixed case for attribute names.
1323 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
1325 * sem_ch6.adb (Analyze_Generic_Subprogram_Body): Rename the call to
1326 Analyze_Aspect_Specifications_On_Body_Or_Stub.
1327 (Analyze_Subprogram_Body_Helper): Rename the calls to
1328 Analyze_Aspect_Specifications_On_Body_Or_Stub.
1329 * sem_ch9.adb (Analyze_Entry_Body): Rename the call to
1330 Analyze_Aspect_Specifications_On_Body_Or_Stub.
1331 * sem_ch10.adb: Add with and use clause for Sem_Ch13.
1332 (Analyze_Package_Body_Stub): Add constant Id. Decorate the package stub
1333 prior to analyzing its aspects.
1334 (Analyze_Protected_Body_Stub): Add constant Id. Decorate the package
1335 stub prior to analyzing its aspects. Save and restore the configuration
1337 (Analyze_Task_Body_Stub): Add constant Id. Decorate the package stub
1338 prior to analyzing its aspects.
1339 * sem_ch13.adb (Analyze_Aspect_Specifications_On_Body_Or_Stub): Renamed
1340 to Analyze_Aspects_On_Subprogram_Body_Or_Stub.
1341 * sem_ch13.ads (Analyze_Aspect_Specifications_On_Body_Or_Stub): Renamed
1342 to Analyze_Aspects_On_Subprogram_Body_Or_Stub.
1343 * sem_prag.adb: Code reformatting.
1344 (Analyze_Refined_Depends_Global_Post): Consider task body stubs.
1346 2018-05-21 Jerome Lambourg <lambourg@adacore.com>
1348 * gcc-interface/Makefile.in: Add g-soliop__qnx.ads to the runtime build
1351 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
1353 * exp_cg.adb: Remove with and use clause for Exp_Disp.
1354 * exp_ch9.adb: Remove with and use clause for Exp_Disp.
1355 * exp_disp.adb (Is_Predefined_Dispatching_Operation): Moved to Sem_Util.
1356 (Is_Predefined_Interface_Primitive): Moved to Sem_Util.
1357 (Is_Predefined_Internal_Operation): Moved to Sem_Util.
1358 * exp_disp.ads (Is_Predefined_Dispatching_Operation): Moved to Sem_Util.
1359 (Is_Predefined_Interface_Primitive): Moved to Sem_Util.
1360 (Is_Predefined_Internal_Operation): Moved to Sem_Util.
1361 * exp_dist.adb: Remove with and use clause for Exp_Disp.
1362 * freeze.adb: Remove with and use clause for Exp_Disp.
1363 * sem_cat.adb: Remove with and use clause for Exp_Disp.
1364 * sem_ch6.adb: Remove with and use clause for Exp_Disp.
1365 * sem_ch12.adb: Remove with and use clause for Exp_Disp.
1366 * sem_elab.adb (Check_Overriding_Primitive): Do not process predefined
1368 * sem_util.adb: Remove with and use clause for Exp_Disp.
1369 (Is_Predefined_Dispatching_Operation): Moved from Exp_Disp.
1370 (Is_Predefined_Interface_Primitive): Moved from Exp_Disp.
1371 (Is_Predefined_Internal_Operation): Moved from Exp_Disp.
1372 * sem_util.ads (Is_Predefined_Dispatching_Operation): Moved from
1374 (Is_Predefined_Interface_Primitive): Moved from Exp_Disp.
1375 (Is_Predefined_Internal_Operation): Moved from Exp_Disp.
1377 2018-05-21 Ed Schonberg <schonberg@adacore.com>
1379 * sem_res.adb (Valid_Conversion): Improve error message on an illegal
1380 type conversion whose expression has a limited view of a type.
1382 2018-05-21 Ed Schonberg <schonberg@adacore.com>
1384 * exp_ch5.adb (Build_Formal_Container_Iteration): If source has
1385 explicit name for iterator loop, preserve that name in expanded
1386 construct, for possible use in exit statements.
1388 2018-05-21 Javier Miranda <miranda@adacore.com>
1390 * sem_ch4.adb (Analyze_Membership_Op): Avoid compiler crash when the
1391 spec of a unit has Ada 2012 membership tests with multiple choices and
1392 the unit body is not compiled under Ada 2012 mode.
1394 2018-05-21 Doug Rupp <rupp@adacore.com>
1396 * sigtramp-vxworks-target.inc: Set cfa_reg properly from sigcontext
1398 (CFI_COMMON_REGS): Restore LR jic probed from prologue.
1399 (REGNO_PC_OFFSET): Change to correct value for Aarch64.
1401 2018-05-21 Jose Ruiz <ruiz@adacore.com>
1403 * doc/gnat_ugn/gnat_utility_programs.rst, exp_attr.adb,
1404 libgnarl/s-tassta.adb: Minor typo fixes
1406 2018-05-21 Ed Schonberg <schonberg@adacore.com>
1408 * sem_ch4.adb (Analyze_One_Call): Recognize complex cases where an
1409 indexed call originally in prefix forn is itself the prefix of a
1412 2018-05-21 Piotr Trojanek <trojanek@adacore.com>
1414 * sem_eval.adb (Is_Null_Range): Clarify access to the full view of a
1416 (Not_Null_Range): Same as above.
1418 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
1420 * exp_ch3.adb: Minor reformatting.
1421 * exp_ch6.adb: Likewise.
1422 * freeze.adb: Likewise.
1423 * inline.adb: Likewise.
1424 * sem_util.adb: Likewise.
1426 2018-05-21 Yannick Moy <moy@adacore.com>
1428 * inline.adb (Expand_Inlined_Call.Process_Formals): Use a type
1429 conversion instead of an unchecked type conversion when inlining a
1430 return statement, unless type qualification is required (for character
1431 and string literal) or no check can result from the conversion (for
1433 * opt.ads: Update comment.
1435 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
1437 * sem_ch6.adb (Analyze_Subprogram_Body_Helper): Install the elaboration
1438 model of the compilation unit spec, if any.
1439 * sem_ch7.adb (Analyze_Package_Body_Helper): Install the elaboration
1440 model of the compilation unit spec, if any.
1441 * sem_ch10.adb (Analyze_Subunit): Install the elaboration model of the
1442 parent compilation unit spec, if any.
1443 * sem_elab.adb (Check_Elaboration_Scenarios): Restore the elaboration
1444 model of the main unit.
1445 (Is_Same_Unit): The routine now uses Unit_Entity.
1446 (Is_Subunit): Removed.
1447 (Normalize_Unit): Removed.
1448 (Unit_Entity): New routine.
1449 * sem_prag.adb (Analyze_Pragma): Reimplement the handling of pragma
1450 Elaboration_Checks. The analysis now ensures that the pragma appears at
1451 the configuration level, and on the initial declaration of a unit.
1452 Other placements are either flagged as illegal, or ignored.
1453 (Check_Duplicate_Elaboration_Checks_Pragma): New routine.
1454 (Ignore_Elaboration_Checks_Pragma): New routine.
1455 * sem_util.adb (Install_Elaboration_Model): New routine.
1456 * sem_util.ads (Install_Elaboration_Model): New routine.
1457 * doc/gnat_rm/implementation_defined_pragmas.rst: Update the
1458 documentation of pragma Elaboration_Checks.
1459 * gnat_rm.texi: Regenerate.
1461 2018-05-21 Olivier Hainque <hainque@adacore.com>
1463 * libgnat/s-trasym__dwarf.adb (Executable_Name): Return argv[0] instead
1464 of empty string when argv[0] couldn't be found on PATH.
1465 (Enable_Cache): Raise Program_Error instead of attempting a null
1466 pointer dereference when the Exec_Module initialization failed.
1468 2018-05-21 Piotr Trojanek <trojanek@adacore.com>
1470 * libgnarl/a-reatim.ads (Clock_Time): Remove External aspect.
1471 * libgnarl/a-taside.ads (Tasking_State): Likewise.
1472 * libgnat/a-calend.ads (Clock_Time): Likewise.
1474 2018-05-21 Yannick Moy <moy@adacore.com>
1476 * sem_ch6.adb (Analyze_Procedure_Call): Refine test to recognize prefix
1477 call notation in inlined call in GNATprove mode.
1479 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
1481 * einfo.adb (Is_External_State): An abstract state is also external
1482 when it is declared with option "synchronous".
1483 * einfo.ads: Update the documentation of synthesized attribute
1485 * sem_util.adb (Find_Simple_Properties): New routine.
1486 (Is_Enabled_External_Property): New routine.
1487 (State_Has_Enabled_Property): Reimplemented. The two flavors of option
1488 External have precedence over option Synchronous when determining
1489 whether a property is in effect.
1491 2018-05-21 Yannick Moy <moy@adacore.com>
1493 * sem_eval.adb (Static_Length): Take into account case of variable of
1494 subtype string literal.
1496 2018-05-21 Olivier Hainque <hainque@adacore.com>
1498 * libgnat/s-objrea.ads (Get_Memory_Bounds): Rename as Get_Xcode_Bounds.
1499 (Object_Section): Rename Flag_Alloc component as Flag_Xcode.
1500 * libgnat/s-objrea.adb (Get_Xcode_Bounds): Adjust to new subprogram and
1502 (Get_Section, ELF case): Set Flag_Xcode from SHF_EXECINSTR.
1503 * libgnat/s-dwalin.adb (Open): Adjust to the Get_Memory_Bounds name
1506 2018-05-21 Olivier Hainque <hainque@adacore.com>
1508 * libgnat/s-dwalin.ads (Dwarf_Context): Change type of Load_Address to
1509 Address, and type of Low, High to Storage_Offset.
1510 (Low): Rename as Low_Address and convey that the return value is a
1511 runtime reference accounting for a load address.
1512 * libgnat/s-dwalin.adb (Read_Aranges_Entry): Adjust to the
1513 address/offset type changes.
1514 (Aranges_Lookup): Likewise.
1515 (Symbolic_Address): Likewise.
1516 (Symbolic_Traceback): Likewise.
1517 (Dump_Cache): Likewise.
1518 (Is_Inside): Likewise.
1520 (Set_Load_Address): Likewise.
1521 (Low_Address): Likewise, and account for C.Load_Address.
1522 * libgnat/s-trasym__dwarf.adb (Lt): Use Low_Address instead of Low.
1523 (Multi_Module_Symbolic_Traceback): Compare address in traceback
1524 with module Low_Address instead of Low.
1526 2018-05-21 Olivier Hainque <hainque@adacore.com>
1528 * libgnat/s-dwalin.ads (Dwarf_Context): Rename Load_Slide as
1530 * libgnat/s-dwalin.adb (Is_Inside): Adjust accordingly.
1531 (Set_Load_Address): Likewise.
1532 (Symbolic_Traceback): Likewise.
1534 2018-05-21 Olivier Hainque <hainque@adacore.com>
1536 * libgnat/s-trasym__dwarf.adb (Add_Module_To_Cache): Expect a
1537 Load_Address argument and pass it down to Init_Module.
1538 * libgnat/s-tsmona__linux.adb (Build_Cache_For_All_Modules): Pass
1539 lm.l_addr as the Load_Address to Add_Module_To_Cache.
1541 2018-05-21 Piotr Trojanek <trojanek@adacore.com>
1543 * einfo.adb (Has_Discriminants): Stronger assertion.
1544 (Set_Has_Discriminants): Stronger assertion.
1545 * sem_ch13.adb (Push_Scope_And_Install_Discriminants): Adapt to respect
1546 the stronger assertion on Has_Discriminant.
1547 (Uninstall_Discriminants_And_Pop_Scope): Same as above.
1548 * sem_util.adb (New_Copy_Tree): Same as above.
1549 * sem_ch7.adb (Generate_Parent_References): Prevent calls to
1550 Has_Discriminant on non-type entities that might happen when the
1551 compiled code has errors.
1552 * sem_ch3.adb (Derived_Type_Declaration): Only call
1553 Set_Has_Discriminant on type entities.
1555 2018-05-21 Arnaud Charlet <charlet@adacore.com>
1557 * exp_unst.adb (Unnest_Subprogram): Unnest all subprograms relevant for
1560 2018-05-21 Piotr Trojanek <trojanek@adacore.com>
1562 * lib.ads: Fix typo in enumeration in comment.
1564 2018-05-21 Ed Schonberg <schonberg@adacore.com>
1566 * sem_attr.adb (Analyze_Attribute, case Scalar_Storage_Order): The
1567 attribute reference is legal within a generic unit when the prefix is a
1568 formal private type.
1570 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
1572 * exp_ch7.adb (Establish_Transient_Scope): Code cleanup. Do not
1573 delegate the secondary stack management when there is no suitable
1574 transient context, and the transient scope was intended to manage the
1575 secondary stack because this causes premature reclamation. Change the
1576 transient scope creation logic by special casing assignment statements
1577 of controlled components for type initialization procedures.
1578 (Find_Node_To_Be_Wrapped): Renamed to Find_Transient_Context. Update
1579 the comment on usage.
1580 (Find_Transient_Context): Change the initinte loop into a while loop.
1581 Iterations schemes and iterator specifications are not valid transient
1582 contexts because they rely on special processing. Assignment statements
1583 are now treated as a normal transient context, special cases are
1584 handled by the caller. Add special processing for pragma Check.
1585 (Is_OK_Construct): Removed. Its functionality has been merged in
1586 routine Find_Transient_Context.
1587 * sem_ch5.adb (Check_Call): Reimplemented. Add code to properly
1588 retrieve the subprogram being invoked. Use a more accurate predicate
1589 (Requires_Transient_Scope) to determine that the function will emply
1590 the secondary stack.
1592 2018-05-21 Piotr Trojanek <trojanek@adacore.com>
1594 * ada_get_targ.adb: Fix subprogram body headers.
1595 * adabkend.adb: Likewise.
1596 * checks.adb: Likewise.
1597 * exp_ch3.adb: Likewise.
1598 * exp_ch5.adb: Likewise.
1599 * exp_ch9.adb: Likewise.
1600 * exp_dist.adb: Likewise.
1601 * exp_tss.adb: Likewise.
1602 * inline.adb: Likewise.
1603 * lib-writ.adb: Likewise.
1604 * lib-xref-spark_specific.adb: Likewise.
1605 * libgnarl/s-osinte__darwin.adb: Likewise.
1606 * libgnarl/s-stusta.adb: Likewise.
1607 * libgnarl/s-taprop__solaris.adb: Likewise.
1608 * libgnarl/s-tposen.adb: Likewise.
1609 * libgnarl/s-vxwext__kernel-smp.adb: Likewise.
1610 * libgnarl/s-vxwext__kernel.adb: Likewise.
1611 * libgnat/a-btgbso.adb: Likewise.
1612 * libgnat/a-cfdlli.adb: Likewise.
1613 * libgnat/a-cfhama.adb: Likewise.
1614 * libgnat/a-cfinve.adb: Likewise.
1615 * libgnat/a-cimutr.adb: Likewise.
1616 * libgnat/a-coboho.adb: Likewise.
1617 * libgnat/a-cofove.adb: Likewise.
1618 * libgnat/a-cofuve.adb: Likewise.
1619 * libgnat/a-comutr.adb: Likewise.
1620 * libgnat/a-exexda.adb: Likewise.
1621 * libgnat/a-tags.adb: Likewise.
1622 * libgnat/a-tideau.adb: Likewise.
1623 * libgnat/a-wtdeau.adb: Likewise.
1624 * libgnat/a-ztdeau.adb: Likewise.
1625 * libgnat/g-alleve.adb: Likewise.
1626 * libgnat/s-excdeb.adb: Likewise.
1627 * libgnat/s-parint.adb: Likewise.
1628 * libgnat/s-shasto.adb: Likewise.
1629 * libgnat/s-traceb__hpux.adb: Likewise.
1630 * prepcomp.adb: Likewise.
1631 * sem_ch4.adb: Likewise.
1632 * sem_ch6.adb: Likewise.
1633 * sem_dist.adb: Likewise.
1634 * sem_prag.adb: Likewise.
1635 * sem_util.adb: Likewise.
1636 * sinfo.adb: Likewise.
1637 * switch.adb: Likewise.
1639 2018-05-04 John Marino <gnugcc@marino.st>
1642 * link.c (BSD platforms): Add missing backslash.
1644 2018-04-27 Eric Botcazou <ebotcazou@adacore.com>
1647 * init.c (__gnat_handle_vms_condition): Add missing parentheses.
1649 2018-04-25 Eric Botcazou <ebotcazou@adacore.com>
1652 * gnat_ugn.texi: Regenerate.
1654 2018-03-23 Eric Botcazou <ebotcazou@adacore.com>
1657 * gnatlink.adb (Gnatlink): Remove handling of -b switch.
1658 * doc/gnat_ugn/building_executable_programs_with_gnat.rst (gnatlink):
1659 Remove documentation of -b switch.
1661 2018-03-23 Eric Botcazou <ebotcazou@adacore.com>
1664 * gnatlink.adb (Process_Args): Drop existing link switches if multiple
1665 switches are passed for --LINK.
1667 2018-03-12 Eric Botcazou <ebotcazou@adacore.com>
1670 * gcc-interface/misc.c (gnat_post_options): Disable string overflow
1673 2018-03-10 Eric Botcazou <ebotcazou@adacore.com>
1675 * gcc-interface/trans.c (node_has_volatile_full_access) <N_Identifier>:
1676 Consider only entities for objects.
1678 2018-03-07 Sebastian Huber <sebastian.huber@embedded-brains.de>
1680 * gcc-interface/Makefile.in (OSCONS_CPP): Remove redundant
1682 (OSCONS_EXTRACT): Add $(GNATLIBCFLAGS_FOR_C).
1684 2018-03-06 Eric Botcazou <ebotcazou@adacore.com>
1686 * gcc-interface/trans.c (convert_with_check): Fix typo in the condition
1687 guarding the overflow check emitted for the upper bound of a floating-
1690 2018-03-06 Eric Botcazou <ebotcazou@adacore.com>
1692 * gcc-interface/utils.c (def_builtin_1): Bail out on error_mark_node.
1694 2018-02-28 Eric Botcazou <ebotcazou@adacore.com>
1696 * libgnat/i-cexten.ads (Float_128): New type.
1698 2018-02-02 Eric Botcazou <ebotcazou@adacore.com>
1700 * gcc-interface/decl.c (array_type_has_nonaliased_component): Return
1701 false if the component type is a pointer.
1703 2018-01-11 Gary Dismukes <dismukes@adacore.com>
1705 * exp_ch3.adb (Default_Initialize_Object): Call New_Copy_Tree on the
1706 result of Get_Simple_Init_Value and pass the source location of the
1707 object declaration's object_definition.
1709 2018-01-11 Ed Schonberg <schonberg@adacore.com>
1711 * exp_ch6.adb (Make_Build_In_Place_Call_In_Object_Declaration): Handle
1712 properly object declarations with initializations that are
1713 build-in-place function calls, when there is an address specification,
1714 either as an aspect specification or an explicit attribute
1715 specification clause, for the initialized object.
1716 * freeze.adb (Check_Address_Clause): Do not remove side-effects from
1717 initial expressions in the case of a build-in-place call.
1719 2018-01-11 Piotr Trojanek <trojanek@adacore.com>
1721 * sem_eval.adb (Is_Null_Range): Retrieve the full view when called on a
1722 private (sub)type; refactor to avoid early return statement.
1723 (Not_Null_Range): Same as above.
1725 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1727 * freeze.adb (Freeze_Entity): Ensure that a Ghost type is not
1728 concurrent, nor effectively volatile.
1729 * ghost.adb (Check_Ghost_Type): New routine.
1730 * ghost.ads (Check_Ghost_Type): New routine.
1731 * sem_util.adb (Is_Declaration): Reimplemented. The routine can now
1732 consider specific subsets of declarations.
1733 (Is_Declaration_Other_Than_Renaming): Removed. Its functionality is
1734 replicated by Is_Declaration.
1735 * sem_util.ads (Is_Declaration): New parameter profile. Update the
1737 (Is_Declaration_Other_Than_Renaming): Removed.
1739 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1741 * sem_ch5.adb (Analyze_Assignment): Assignments to variables that act
1742 as Part_Of consituents of single protected types are illegal when they
1743 take place inside a protected function.
1744 (Diagnose_Non_Variable_Lhs): Use Within_Function to check for an
1746 (Is_Protected_Part_Of_Constituent): New routine.
1747 (Within_Function): New routine.
1749 2018-01-11 Arnaud Charlet <charlet@adacore.com>
1751 Bump copyright notices to 2018.
1753 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1755 * binde.adb, par-ch6.adb, par-ch9.adb, sem_ch12.adb, sem_ch13.adb:
1758 2018-01-11 Justin Squirek <squirek@adacore.com>
1760 * par-ch6.adb (Scan_Body_Or_Expression_Function): Add additional check
1761 to make sure a given expression function is properly parenthesized.
1763 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1765 * sem_ch6.adb (Analyze_Subprogram_Body_Helper): Check the
1766 categorization of a subprogram body which does not complete a previous
1769 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1771 * sem_ch10.adb (Check_Private_Child_Unit): Ensure that the enclosing
1772 scope of package Ada is Standard.
1774 2018-01-11 Ed Schonberg <schonberg@adacore.com>
1776 * sem_ch13.adb (Replace_Type_Ref): Handle properly reference to a
1777 subcomponent of the current entity when building the body for a dynamic
1778 predicate function for a record with composite subcomponents.
1780 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1782 * exp_aggr.adb (Convert_Aggr_In_Object_Decl): Update the call to
1783 Establish_Transient_Scope.
1784 (Convert_To_Assignments): Update the call to Establish_Transient_Scope.
1785 (Expand_Array_Aggregate): Update the call to Establish_Transient_Scope.
1786 * exp_ch6.adb (Expand_Call_Helper): Update the call to
1787 Establish_Transient_Scope.
1788 (Make_Build_In_Place_Call_In_Object_Declaration): Update the call to
1789 Establish_Transient_Scope.
1790 * exp_ch7.adb (Establish_Transient_Scope): Restructured. Delegate the
1791 management of the secondary stack to an enclosing scope if there is no
1792 suitable construct to wrap, and the transient scope was intended to
1793 manage the secondary stack.
1794 (Find_Node_To_Be_Wrapped): Restructured. A case_statement_alternative
1795 is a valid boundary for a transient expression which comes from the
1796 statements of the alternative, otherwise alternatives cannot be
1797 wrapped. Assignments of controlled objects which have controlled
1798 actions suppressed now stop the traversal as there is no point in
1799 looking for an enclosing construct. Add several N_xxx_Body choices to
1800 the termination conditions for completeness.
1801 * exp_ch7.ads (Establish_Transient_Scope): Update the parameter profile
1802 and the associated comment on usage.
1803 * exp_smem.adb (Add_Shared_Var_Lock_Procs): Update the call to
1804 Establish_Transient_Scope.
1805 (Add_Write_After): Update the call to Establish_Transient_Scope.
1806 * sem_res.adb (Check_Initialization_Call): Removed.
1807 (Resolve_Actuals): Account for additional cases where finalization
1808 actions are required by utilizing predicate Needs_Finalization rather
1810 (Resolve_Call): Type initialization procedures can now utilize
1811 transient scopes to manage the secondary stack, thus preventing leaks
1812 during initialization. Remove the previous kludgy algorithm which
1813 attempts to manage the secondary stack at the object creation site.
1815 2018-01-11 Jerome Lambourg <lambourg@adacore.com>
1817 * libgnat/g-soliop__qnx.ads: New.
1818 * adaint.c, adaint.h, cstreams.c, s-oscons-tmplt.c, sysdep.c: Update
1821 2018-01-11 Bob Duff <duff@adacore.com>
1823 * par-ch9.adb (P_Protected_Operation_Declaration_Opt): Give an error if
1824 a null procedure occurs in a protected definition.
1826 2018-01-11 Bob Duff <duff@adacore.com>
1828 * binderr.ads, namet.ads: Minor reformatting.
1830 2018-01-11 Bob Duff <duff@adacore.com>
1832 * doc/gnat_ugn/gnat_utility_programs.rst: Improve documentation of
1835 2018-01-11 Bob Duff <duff@adacore.com>
1837 * binde.adb (Force_Elab_Order): Give an error if there are duplicate
1840 2018-01-11 Ed Schonberg <schonberg@adacore.com>
1842 * sem_ch6.adb (Freeze_Expr_Types): If an access value is the
1843 controlling argument of a dispatching call. freeze the corresponding
1846 2018-01-11 Ben Brosgol <brosgol@adacore.com>
1848 * doc/Makefile: Add Sphinx option -W to treat warnings as errors.
1850 2018-01-11 Ben Brosgol <brosgol@adacore.com>
1852 * doc/gnat_rm/implementation_defined_aspects.rst: Minor type/wording
1854 * gnat_rm.texi: Regenerate.
1856 2018-01-11 Ed Schonberg <schonberg@adacore.com>
1858 * sem_ch12.adb (Check_Fixed_Point_Type): Do not apply check if the
1859 formsl type corresponding to the actual fixed point type is private,
1860 because in this case there can be no suspicious arithmetic operations
1861 in the generic unless they reference a formal subprogram. Clarify
1864 2018-01-11 Javier Miranda <miranda@adacore.com>
1866 * exp_util.adb (Remove_Side_Effects): No action done for functions
1867 returning class-wide types since it requires generating code using
1868 'reference and the CCG target has no secondary stack.
1869 * gnat1drv.adb: Disable building static dispatch tables when generating
1872 2018-01-11 Piotr Trojanek <trojanek@adacore.com>
1874 * libgnat/a-direio.ads, libgnat/a-sequio.ads, libgnat/a-ststio.ads,
1875 libgnat/a-textio.ads, libgnat/a-witeio.ads, libgnat/a-ztexio.ads
1876 (File_Type): Add Default_Initial_Condition aspect.
1878 2018-01-11 Pascal Obry <obry@adacore.com>
1880 * libgnat/s-os_lib.adb (Normalize_Pathname): New implementation.
1882 2018-01-11 Bob Duff <duff@adacore.com>
1884 * doc/gnat_ugn/gnat_utility_programs.rst: Rewrite gnatpp documentation
1885 to match what the Libadalang-based version does.
1886 * doc/gnat_ugn/about_this_guide.rst: Update reference.
1888 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1890 * sem_res.adb (Uses_SS): A controlled type requires the secondary stack
1891 if it contains at least one component declaration employing a function
1892 call returning on the secondary stack.
1894 2018-01-11 Yannick Moy <moy@adacore.com>
1896 * doc/gnat_rm/standard_and_implementation_defined_restrictions.rst:
1897 Update description of restriction SPARK_05 with SPARK 2014.
1898 * gnat_rm.texi: Regenerate.
1900 2018-01-11 Vasiliy Fofanov <fofanov@adacore.com>
1902 * doc/gnat_ugn/gnat_utility_programs.rst: Fix layout.
1904 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1906 * exp_aggr.adb, exp_ch9.adb, exp_util.adb, sem_aggr.adb, sem_ch3.adb,
1907 sem_res.adb, sem_util.adb: Minor reformatting.
1909 2018-01-11 Ed Schonberg <schonberg@adacore.com>
1911 * sem_prag.adb (Analyze_Pragma, case Predicate): Indicate that the type
1912 has a delayed aspect which must be processed at the point the type is
1913 frozen. This mimics what is done when the predicate is provided by a
1916 2018-01-11 Doug Rupp <rupp@adacore.com>
1918 * init.c (vxworks): Add macro checks for __aarch64__.
1920 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1922 * exp_util.adb (Add_Failure_Expression): New routine.
1923 (Make_Predicate_Check): Reimplement the handling of Predicate_Failure.
1924 * sem_util.adb (Is_Current_Instance): Code cleanup.
1926 2018-01-11 Patrick Bernardi <bernardi@adacore.com>
1928 * libgnat/s-parame*.adb, libgnat/s-parame*.ads: Remove unneeded
1929 Default_Sec_Stack_Size.
1930 * libgnat/s-secsta.adb (SS_Allocate): Handle the fixed secondary stack
1931 limit check so that the integer index does not overflow. Check the
1932 dynamic stack allocation does not cause the secondary stack pointer to
1934 (SS_Info): Align colons.
1935 (SS_Init): Cover the case when bootstraping with an old compiler that
1936 does not set Default_SS_Size.
1938 2018-01-11 Ed Schonberg <schonberg@adacore.com>
1940 * sem_ch3.adb (Add_Internal_Interface_Entities): When checking the
1941 legality of an inherited operation that may require overriding, ignore
1942 primitive_wrappers that correspond to explicit operations that override
1943 an interface primitive.
1944 * exp_util.adb (Build_Class_Wide_Expression, Replace_Entity): If the
1945 operation to which the class-wide expression applies is a protected op.
1946 with a primitive_wrapper, verify that the updated inherited expression
1947 does not contain an internal call to a protected function. This
1948 completes the implementation of AI12-0166.
1950 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1952 * ali.adb: Document the remaining letters available for ALI lines.
1953 (Scan_ALI): A with clause is internal when it is encoded on a 'Z' line.
1954 * ali.ads: Update type With_Record. Field
1955 Implicit_With_From_Instantiation is no longer in use. Add field
1957 * csinfo.adb (CSinfo): Remove the setup for attribute
1958 Implicit_With_From_Instantiation.
1959 * lib-writ.adb (Collect_Withs): Correct the logic which marks a unit as
1960 either implicitly or explicitly withed.
1961 (Is_Implicit_With_Clause): New routine.
1962 (Write_ALI): Rename array Implicit_With to Has_Implicit_With to avoid
1963 confusion with the with clause attribute by the same name.
1964 (Write_With_Lines): Update the emission of 'W', 'Y', and 'Z' headers.
1965 * rtsfind.adb (Maybe_Add_With): Code cleanup.
1966 * sem_ch8.adb (Present_System_Aux): Code cleanup.
1967 * sem_ch10.adb (Expand_With_Clause): Mark the with clause as generated
1969 (Implicit_With_On_Parent): Mark the with clause as generated for a
1971 * sem_ch12.adb (Inherit_Context): With clauses inherited by an
1972 instantiation are no longer marked as Implicit_With_From_Instantiation
1973 because they are already marked as implicit.
1974 * sem_elab.adb (Ensure_Prior_Elaboration_Static): Remove the kludge
1975 which marks implicit with clauses as related to an instantiation.
1976 * sinfo.adb (Implicit_With_From_Instantiation): Removed.
1977 (Parent_With): New routine.
1978 (Set_Implicit_With_From_Instantiation): Removed.
1979 (Set_Parent_With): New routine.
1980 * sinfo.ads: Update the documentation of attribute Implicit_With.
1981 Remove attribute Implicit_With_From_Instantiation along with
1982 occurrences in nodes. Add attribute Parent_With along with occurrences
1984 (Implicit_With_From_Instantiation): Removed along with pragma Inline.
1985 (Parent_With): New routine along with pragma Inline.
1986 (Set_Implicit_With_From_Instantiation): Removed along with pragma Inline.
1987 (Set_Parent_With): New routine along with pragma Inline.
1989 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
1991 * sem_util.adb (Find_Enclosing_Scope): Return the unique defining
1992 entity when the enclosing construct is a body.
1994 2018-01-11 Patrick Bernardi <bernardi@adacore.com>
1996 * exp_ch9.adb (Expand_N_Task_Type_Declaration): Simplified
1997 Secondary_Stack_Size handling as a pragma is now generated for the
1998 corresponding aspect instead of an attribute. Pragma expression is
1999 relocated instead of evaluated. Discriminant of the corresponding
2000 record type is referenced rather than the type discriminant.
2001 (Create_Secondary_Stack_For_Task, Make_Task_Create_Call): Update
2002 Secondary_Stack_Size rep item checks to only look for the pragma rep.
2003 * sem_ch13.adb (Analyze_One_Aspect): Transform
2004 Aspect_Secondary_Stack_Size into a pragma instead of an attribute
2005 because the attribute does not have visibility on a task type's
2006 discriminants when the type's definition is expanded.
2007 (Analyze_Attribute_Definition_Clause): Remove handling of
2008 Attribute_Secondary_Stack_Size.
2009 * snames.adb-tmpl, snames.ads-tmpl: Remove
2010 Attribute_Secondary_Stack_Size, no longer used.
2012 2018-01-11 Justin Squirek <squirek@adacore.com>
2014 * sem_ch8.adb: Minor comment fix.
2016 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2018 * exp_ch4.adb (Process_Action): Do not abandon the inspection of an
2019 individual action because the action may denote a complex expression,
2020 such as a case statement, which in turn may contain additional
2023 2018-01-11 Ed Schonberg <schonberg@adacore.com>
2025 * sem_aggr.adb (Resolve_Iterated_Component_Association): Perform
2026 analysis on a copy of the expression with a copy of the index variable,
2027 because full expansion will rewrite construct into a loop with the
2028 original loop variable.
2029 * exp_aggr.adb (Gen_Assign): Defer analysis and resolution if the
2030 expression is an iterated component association. Full analysis takes
2031 place when construct is rewritten as a loop.
2032 (In_Place_Assign_OK, Safe_Component): An iterated_component_association
2033 is not safe for in-place assignment.
2034 * sem_util.adb (Remove_Entity): Handle properly the case of an isolated
2035 entity with no homonym and no other entity in the scope.
2037 2018-01-11 Justin Squirek <squirek@adacore.com>
2039 * sem_prag.adb (Analyze_Pragma:Pragma_Loop_Variant): Modify error
2040 message to be printed on the pragma argument identifier.
2042 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2044 * exp_util.adb (Build_Invariant_Procedure_Declaration): Set the last
2045 entity of the generated invariant procedure in order to construct a
2046 proper entity chain.
2048 2018-01-11 Piotr Trojanek <trojanek@adacore.com>
2050 * sem_ch13.adb (Build_Predicate_Functions): Fix minor issues in
2053 2018-01-11 Arnaud Charlet <charlet@adacore.com>
2055 * einfo.ads, einfo.adb (Activation_Record_Component,
2056 Set_Activation_Record_Component, Set_Is_Uplevel_Referenced_Entity):
2057 Allow E_Discriminant.
2059 2018-01-10 Eric Botcazou <ebotcazou@adacore.com>
2061 * gcc-interface/decl.c (gnat_to_gnu_component_type): Apply the check
2062 for atomic access once the component size is taken into account and
2063 also do it if the component type is Atomic or Volatile_Full_Access.
2065 2018-01-04 Eric Botcazou <ebotcazou@adacore.com>
2067 * gnatvsn.ads: Bump copyright year.
2069 2018-01-03 Richard Sandiford <richard.sandiford@linaro.org>
2070 Alan Hayward <alan.hayward@arm.com>
2071 David Sherwood <david.sherwood@arm.com>
2073 * gcc-interface/misc.c (enumerate_modes): Treat GET_MODE_BITSIZE
2076 2018-01-03 Richard Sandiford <richard.sandiford@linaro.org>
2077 Alan Hayward <alan.hayward@arm.com>
2078 David Sherwood <david.sherwood@arm.com>
2080 * gcc-interface/misc.c (enumerate_modes): Treat GET_MODE_PRECISION
2083 2018-01-03 Richard Sandiford <richard.sandiford@linaro.org>
2084 Alan Hayward <alan.hayward@arm.com>
2085 David Sherwood <david.sherwood@arm.com>
2087 * gcc-interface/utils.c (gnat_types_compatible_p): Handle
2088 polynomial TYPE_VECTOR_SUBPARTS.
2090 2018-01-03 Richard Sandiford <richard.sandiford@linaro.org>
2091 Alan Hayward <alan.hayward@arm.com>
2092 David Sherwood <david.sherwood@arm.com>
2094 * gcc-interface/misc.c (enumerate_modes): Handle polynomial
2097 2018-01-03 Jakub Jelinek <jakub@redhat.com>
2099 Update copyright years.
2101 * gnat_ugn.texi: Bump @copying's copyright year.
2102 * gnat_rm.texi: Likewise.
2104 Copyright (C) 2018 Free Software Foundation, Inc.
2106 Copying and distribution of this file, with or without modification,
2107 are permitted in any medium without royalty provided the copyright
2108 notice and this notice are preserved.