1 2018-07-16 Yannick Moy <moy@adacore.com>
3 * sem_res.adb (Resolve_Call): Do not inline calls inside
4 compiler-generated functions translated as predicates in GNATprove.
6 2018-07-16 Gary Dismukes <dismukes@adacore.com>
8 * exp_ch4.adb (Expand_N_Allocator): Test for Storage_Pool being RTE in
9 addition to the existing test for no Storage_Pool as a condition
10 enabling generation of the call to Check_Standard_Allocator when the
11 restriction No_Standard_Allocators_After_Elaboration is active.
12 * libgnat/s-elaall.ads (Check_Standard_Allocator): Correct comment to
13 say that Storage_Error will be raised (rather than Program_Error).
14 * libgnat/s-elaall.adb (Check_Standard_Allocator): Raise Storage_Error
15 rather than Program_Error when Elaboration_In_Progress is False.
17 2018-07-16 Gary Dismukes <dismukes@adacore.com>
19 * sem_eval.adb: Fix spelling for compile-time-known.
21 2018-07-16 Hristian Kirtchev <kirtchev@adacore.com>
23 * sem_eval.adb (Compile_Time_Known_Value): Add a guard which prevents
24 the compiler from entering infinite recursion when trying to determine
25 whether a deferred constant has a compile time known value, and the
26 initialization expression of the constant is a reference to the
29 2018-07-16 Nicolas Roche <roche@adacore.com>
31 * libgnat/a-strunb.adb, libgnat/a-strunb__shared.adb: Adjust growth
32 factor from 1/32 to 1/2 for Unbounded_String.
34 2018-07-13 Eric Botcazou <ebotcazou@adacore.com>
36 * gcc-interface/lang.opt (funsigned-char): New option.
37 * gcc-interface/misc.c (gnat_handle_option): Accept it.
38 * gcc-interface/utils.c (finish_character_type): Tweak comment.
40 2018-07-07 Eric Botcazou <ebotcazou@adacore.com>
42 * gcc-interface/decl.c (gnat_to_gnu_entity): Add GNAT_DECL local
43 variable and use it throughout.
44 <E_Variable>: If the nominal subtype of the object is unconstrained,
45 compute the Ada size separately and put in on the padding type if the
47 <E_Record_Type>: Minor tweak.
48 * gcc-interface/misc.c (gnat_type_max_size): Rename max_size_unit
49 into max_size_unit throughout.
51 2018-07-07 Eric Botcazou <ebotcazou@adacore.com>
53 * gcc-interface/gigi.h (add_decl_expr): Adjust prototype.
54 * gcc-interface/decl.c (gnat_to_gnu_entity): Remove useless test.
55 * gcc-interface/trans.c (add_stmt_with_node): Remove exceptions.
56 (add_decl_expr): Change type of second parameter and rename it.
57 (renaming_from_instantiation_p): New function moved from...
58 (set_expr_location_from_node): Test for exceptions here and add one
59 for actual subtypes built for unconstrained composite actuals.
60 * gcc-interface/utils.c (renaming_from_instantiation_p): ...here.
62 2018-07-07 Eric Botcazou <ebotcazou@adacore.com>
64 * gcc-interface/trans.c (lvalue_required_p): Remove ALIASED parameter
65 and adjust recursive calls.
66 (Identifier_to_gnu): Adjust calls to lvalue_required_p.
67 (gnat_to_gnu): Likewise.
69 2018-07-07 Eric Botcazou <ebotcazou@adacore.com>
71 * gcc-interface/decl.c (gnat_to_gnu_param): Minor tweak.
72 (gnat_to_gnu_subprog_type): New pure_flag local variable. Set it for
73 a pure Ada function with a by-ref In parameter. Propagate it onto the
74 function type by means of the TYPE_QUAL_RESTRICT flag.
75 * gcc-interface/utils.c (finish_subprog_decl): Set DECL_PURE_P if the
76 function type has the TYPE_QUAL_RESTRICT flag set.
78 2018-07-06 Jim Wilson <jimw@sifive.com>
80 * Makefile.rtl: Add riscv*-linux* support.
81 * libgnarl/s-linux__riscv.ads: New.
82 * libgnat/system-linux-riscv.ads: New.
84 * Make-generated.in (treeprs.ads): Use $(GNATMAKE) instead of gnatmake.
85 (einfo.h, sinfo.h, stamp-snames, stamp-nmake): Likewise.
86 * gcc-interface/Makefile.in (xoscons): Likewise.
88 2018-07-06 Sebastian Huber <sebastian.huber@embedded-brains.de>
90 * libgnat/system-rtems.ads (Frontend_Exceptions): Set to False.
91 (ZCX_By_Default): Set to True.
93 2018-07-02 Martin Liska <mliska@suse.cz>
95 * gnatvsn.ads: Bump Library_Version to 9.
97 2018-06-12 Eric Botcazou <ebotcazou@adacore.com>
99 * gcc-interface/ada-tree.h (TYPE_RETURN_BY_DIRECT_REF_P): Change from
100 using TYPE_LANG_FLAG_4 to using TYPE_LANG_FLAG_0.
101 (TYPE_ALIGN_OK): Move around.
102 (TYPE_PADDING_FOR_COMPONENT): Remove superfluous parentheses.
103 * gcc-interface/decl.c (change_qualified_type): Move to...
104 (gnat_to_gnu_entity): Adjust comment.
105 * gcc-interface/gigi.h (change_qualified_type): ...here; make inline.
106 (ceil_pow2): Use ceil_log2.
107 * gcc-interface/utils.c (finish_subprog_decl): Add couple of comments
108 and do not set TREE_SIDE_EFFECTS.
109 (handle_noreturn_attribute): Use change_qualified_type.
111 2018-06-12 Eric Botcazou <ebotcazou@adacore.com>
113 * gcc-interface/decl.c (gnat_to_gnu_entity) <E_Constant>: Do not get
114 the expression of a dispatch table that is not being defined.
115 <E_Record_Subtype>: Remove obsolete kludge.
117 2018-06-12 Eric Botcazou <ebotcazou@adacore.com>
119 * gcc-interface/decl.c (warn_on_field_placement): Use specific wording
121 (warn_on_list_placement): New static function.
122 (components_to_record): Use it to warn on multiple fields in list.
124 2018-06-12 Eric Botcazou <ebotcazou@adacore.com>
126 * gcc-interface/decl.c (variant_desc): Add AUX field.
127 (gnat_to_gnu_entity) <discrete_type>: Do not call compute_record_mode
129 (reverse_sort_field_list): New static function.
130 (components_to_record): Place the variant part at the beginning of the
131 field list when there is an obvious order of increasing position.
132 (build_variant_list): Initialize it.
133 (create_variant_part_from): Do not call compute_record_mode directly.
134 (copy_and_substitute_in_layout): Likewise. Always sort the fields with
135 fixed position in order of increasing position, in the record and all
136 the variants, in any. Call reverse_sort_field_list.
137 * gcc-interface/utils.c (make_packable_type): Compute the sizes before
138 calling finish_record_type. Do not call compute_record_mode directly.
139 (finish_record_type): Overhaul final processing depending on REP_LEVEL
140 and call finish_bitfield_layout if it is equal to one or two.
142 2018-06-11 Eric Botcazou <ebotcazou@adacore.com>
144 * gcc-interface/decl.c (gnat_to_gnu_entity) <E_Array_Type>: Reuse the
145 existing fields of a dummy fat pointer type, if any. Clear the
146 TYPE_DECL_SUPPRESS_DEBUG on the fat pointer type after completing it.
148 2018-06-11 Hristian Kirtchev <kirtchev@adacore.com>
150 * contracts.adb (Process_Body_Postconditions): Expand only checked
152 (Process_Contract_Cases_For): Expand only checked contract cases.
153 (Process_Inherited_Preconditions): Ignored class-wide preconditions are
154 partially expanded because some of their semantic checks are tied to
156 (Process_Preconditions_For): Expand only checked preconditions.
157 (Process_Spec_Postconditions): Expand only checked preconditions.
158 Ignored class-wide preconditions are partially expanded because some of
159 their semantic checks are tied to the expansion.
160 * exp_prag.adb (Expand_N_Pragma): Suppress the expansion of ignored
162 * exp_util.adb (Add_Inherited_Invariants): Code clean up.
163 * sem_util.adb (Propagate_Invariant_Attributes): Code clean up.
165 2018-06-11 Hristian Kirtchev <kirtchev@adacore.com>
167 * exp_ch9.adb, exp_unst.adb, inline.adb, libgnat/a-ciorma.adb,
168 libgnat/a-ciormu.adb, libgnat/a-ciorse.adb, libgnat/a-coorma.adb,
169 libgnat/a-coormu.adb, libgnat/a-coorse.adb, sem_prag.adb: Minor
172 2018-06-11 Gary Dismukes <dismukes@adacore.com>
174 * exp_unst.ads, exp_unst.adb: Typo fixes and minor reformatting.
176 2018-06-11 Hristian Kirtchev <kirtchev@adacore.com>
178 * exp_ch6.adb (Add_Unconstrained_Actuals_To_Build_In_Place_Call): Do
179 not add any actuals when the size of the object is known, and the
180 caller will allocate it.
181 (Build_Heap_Allocator): Rename to Build_Heap_Or_Pool_Allocator to
182 better illustrate its functionality. Update the comment on the
183 generated code. Generate a branch for the heap and pool cases where
184 the object is not necessarity controlled.
185 (Expand_N_Extended_Return_Statement): Expand the extended return
186 statement into four branches depending the requested mode if the caller
187 will not allocate the object on its side.
188 (Make_Build_In_Place_Call_In_Allocator): Do not allocate a controlled
189 object on the caller side because this will violate the semantics of
190 finalizable types. Instead notify the function to allocate the object
191 on the heap or a user-defined storage pool.
192 (Needs_BIP_Alloc_Form): A build-in-place function needs to be notified
193 which of the four modes to employ when returning a limited controlled
195 * exp_util.adb (Build_Allocate_Deallocate_Proc): Remove a redundant
196 guard which is already covered in Needs_Finalization.
198 2018-06-11 Olivier Hainque <hainque@adacore.com>
200 * libgnat/s-excmac*.ads: Factorize Unwind_Action definitions ...
201 * libgnat/a-exexpr.adb: ... Here, then add comments describing the
202 major datastructures associated with the current exception raised.
203 (Setup_Current_Excep): Accept a "Phase" argument conveying the
204 unwinding phase during which this subprogram is called. For an Ada
205 exception, don't update the current exception buffer from the raised
206 exception object during SEARCH_PHASE, as this is redundant with the
207 call now issued just before propagation starts.
208 (Propagate_GCC_Exception): Move call to Setup_Current_Excep ahead of
209 the unwinding start, conveying Phase 0.
210 (Unhandled_Except_Handler): Pass UA_CLEANUP_PHASE as the Phase value on
211 the call to Setup_Current_Excep.
212 * raise-gcc.c (personality_body): Pass uw_phases as the Phase argument
213 on calls to Setup_Current_Excep.
215 2018-06-11 Ed Schonberg <schonberg@adacore.com>
217 * exp_unst.ads, exp_unst.adb (Needs_Fat_Pointer,
218 Build_Access_Type_Decl): New subprograms to handle uplevel references
219 to formals of an unconstrained array type. The activation record
220 component for these is an access type, and the reference is rewritten
221 as an explicit derefenrence of that component.
223 2018-06-11 Bob Duff <duff@adacore.com>
225 * libgnat/a-ciorma.adb, libgnat/a-ciormu.adb, libgnat/a-ciorse.adb,
226 libgnat/a-coorma.adb, libgnat/a-coormu.adb, libgnat/a-coorse.adb:
227 (Element): Add code to detect dangling cursors in some cases.
229 2018-06-11 Yannick Moy <moy@adacore.com>
231 * sem_ch6.adb (Build_Subprogram_Declaration): Mark parameters as coming
234 2018-06-11 Ed Schonberg <schonberg@adacore.com>
236 * sem_ch13.adb (Build_Predicate_Functions): For a derived type, ensure
237 that its parent is already frozen so that its predicate function, if
238 any, has already been constructed.
240 2018-06-11 Yannick Moy <moy@adacore.com>
242 * sem_prag.adb (Check_Mode_Restriction_In_Enclosing_Context): Adapt for
243 possible task unit as the enclosing context.
245 2018-06-11 Eric Botcazou <ebotcazou@adacore.com>
247 * gnat1drv.adb: Remove use clause for Repinfo.
248 (Gnat1drv): Beef up comment about the interplay between -gnatc and
249 back-end annotations. Use full qualified name for List_Rep_Info.
251 2018-06-11 Hristian Kirtchev <kirtchev@adacore.com>
253 * libgnat/g-arrspl.ads: Add pragma Preelaborate.
255 2018-06-11 Arnaud Charlet <charlet@adacore.com>
257 * exp_ch4.adb (Expand_Record_Equality): Remove extraneous "True and
258 then" and general logical "ada" in codepeer mode.
260 2018-06-11 Javier Miranda <miranda@adacore.com>
262 * exp_ch9.adb (Expand_N_Protected_Body): Add missing handling of
265 2018-06-11 Arnaud Charlet <charlet@adacore.com>
267 * exp_ch3.adb, exp_unst.adb, inline.adb, sem_prag.adb: Minor
270 2018-06-11 Yannick Moy <moy@adacore.com>
272 * doc/gnat_rm/implementation_defined_pragmas.rst: Add Suppressible
273 argument to Assertion_Policy
274 * gnat_rm.texi: Regenerate.
276 2018-06-11 Yannick Moy <moy@adacore.com>
278 * gnat1drv.adb: Do not check representation information in CodePeer and
279 GNATprove modes, as these modes call a special backend instead of gigi,
280 so do not have the information.
282 2018-06-11 Yannick Moy <moy@adacore.com>
284 * inline.adb (Build_Body_To_Inline): Consider case of extended return
285 of unconstrained type as one case where inlining is not supported.
286 (Expand_Inlined_Call): Remove special case for body as extended return
287 of unconstrained type.
289 2018-06-11 Yannick Moy <moy@adacore.com>
291 * sem_prag.adb (Analyze_Part_Of): Only allow Part_Of on non-generic
293 (Check_Missing_Part_Of): Do not force Part_Of on generic unit.
295 2018-06-11 Piotr Trojanek <trojanek@adacore.com>
297 * sem_ch13.adb (Analyze_Aspect_Specifications): Don't split AND THEN
298 expressions in Pre/Post contracts while in GNATprove_Mode.
300 2018-06-11 Piotr Trojanek <trojanek@adacore.com>
302 * sem_util.adb (Is_Potentially_Unevaluated): Fix detection of contracts
303 with AND THEN expressions broken down into individual conjuncts.
305 2018-06-11 Ed Schonberg <schonberg@adacore.com>
307 * exp_ch7.adb (Check_Unnesting_Elaboration_Code): Add guard.
309 2018-06-11 Ed Schonberg <schonberg@adacore.com>
311 * exp_unst.adb (Visit_Node): Skip generic associations.
313 2018-06-11 Arnaud Charlet <charlet@adacore.com>
315 * libgnat/memtrack.adb (fwrite): Remove second definition.
317 2018-06-11 Javier Miranda <miranda@adacore.com>
319 * sinfo.ads (Is_Dynamic_Coextension): Adding documentation.
320 (Is_Static_Coextension): Adding documentation.
321 * sinfo.adb (Is_Dynamic_Coextension): Extending the assertion.
322 (Is_Static_Coextension): Extending the assertion.
323 * sem_util.adb (Mark_Allocator): Clear Is_Static_Coextension when
324 setting flag Is_Dynamic_Coextension (and vice versa).
326 2018-06-11 Ed Schonberg <schonberg@adacore.com>
328 * exp_unst.adb (Search_Subprograms): Handle explicitly stubs at the top
329 level of a compilation unit, becuase they may contain nested
330 subprograms that need an activation record.
332 2018-06-11 Arnaud Charlet <charlet@adacore.com>
334 * Makefile.rtl: Compile Ada files with $(ADAC) instead of $(CC).
336 2018-06-11 Hristian Kirtchev <kirtchev@adacore.com>
338 * exp_ch11.adb, exp_unst.adb, inline.adb, sem_ch12.adb, sem_util.adb:
340 * sinfo.ads: Fix a typo.
342 2018-06-11 Ed Schonberg <schonberg@adacore.com>
344 * inline.adb (Expand_Inlined_Call): If no optimization level is
345 specified, the expansion of a call to an Inline_Always function is
346 fully performed in the front-end even on a target that support back-end
349 2018-06-11 Arnaud Charlet <charlet@adacore.com>
351 * bindgen.adb (Gen_Adainit): Protect reference to System.Parameters
354 2018-06-11 Hristian Kirtchev <kirtchev@adacore.com>
356 * sem_ch8.adb (Find_Direct_Name): Mode the declaration of
357 Is_Assignment_LHS further in. Use predicate
358 Needs_Variable_Reference_Marker to determine whether to create a
360 (Find_Expanded_Name): Mode the declaration of Is_Assignment_LHS further
361 in. Use predicate Needs_Variable_Reference_Marker to determine whether
362 to create a variable marker.
363 * sem_elab.adb (Build_Variable_Reference_Marker): Remove the various
364 checks that determine whether the identifier or expanded name is a
365 suitable variable reference. The checks are now performed by
366 Needs_Variable_Reference_Marker.
367 * sem_res.adb (Resolve_Actuals): Use predicate
368 Needs_Variable_Reference_Marker to determine whether to create a
370 * sem_util.adb (Needs_Variable_Reference_Marker): New routine.
371 * sem_util.ads (Needs_Variable_Reference_Marker): New routine.
373 2018-06-11 Valentine Reboul <reboul@adacore.com>
375 * doc/gnat_rm.rst, doc/gnat_ugn.rst: Rename "GPL Edition" into
378 2018-06-11 Ed Schonberg <schonberg@adacore.com>
380 * sem_ch12.adb (Install_Body): In order to determine the placement of
381 the freeze node for an instance of a generic nested within another
382 instance, take into account that the outer instance may be declared in
383 the visible part of a package and the inner intance may be in the
384 private part of the same package.
386 2018-06-11 Eric Botcazou <ebotcazou@adacore.com>
388 * errout.adb (Special_Msg_Delete): Remove handling of Atomic and VFA.
390 2018-06-11 Nicolas Roche <roche@adacore.com>
392 * libgnat/s-valuti.adb (Bad_Value): Ensure that we do not generate a
393 stack overflow while raising a constraint error.
395 2018-06-11 Eric Botcazou <ebotcazou@adacore.com>
397 * repinfo.ads (Rep_Value): Use a single line.
398 * repinfo.adb (Rep_Value): Likewise.
399 (List_Attr): Do not use string concatenation.
401 2018-06-11 Ed Schonberg <schonberg@adacore.com>
403 * exp_unst.adb (Visit_Node): Check reference to formal parameter of
404 current procedure, because the bounds of its type may be uplevel
407 2018-06-02 Eric Botcazou <ebotcazou@adacore.com>
409 * gcc-interface/decl.c (gnat_to_gnu_entity) <E_Constant>: If this is
410 not a definition, retrieve the expression only if it's a compile-time
411 known value if we are just annotating types.
413 * gcc-interface/utils.c (convert): Do not try to upcast properly for a
414 conversion between tagged types in type_annotate_only mode.
416 2018-06-02 Eric Botcazou <ebotcazou@adacore.com>
418 * gcc-interface/ada-tree.h (TYPE_PADDING_FOR_COMPONENT): New macro.
419 * gcc-interface/decl.c (gnat_to_gnu_component_type): Cache the padding
420 type built for an aliased component with variable size.
422 2018-05-31 Pierre-Marie de Rodat <derodat@adacore.com>
424 * doc/gnat_ugn/project-manager-figure.png: Delete.
426 2018-05-31 Pierre-Marie de Rodat <derodat@adacore.com>
428 * vxworks-arm-link.spec, vxworks-e500-link.spec,
429 vxworks-gnat-crtbe-link.spec, vxworks-smp-arm-link.spec,
430 vxworks-smp-e500-link.spec, vxworks-smp-ppc-link.spec,
431 vxworks-smp-x86-link.spec: New files.
433 2018-05-31 Pierre-Marie de Rodat <derodat@adacore.com>
435 * gnatvsn.adb: Re-center the copyright header.
436 * indepsw-darwin.adb: Adjust the starting copyright year to 2011.
438 2018-05-31 Fedor Rybin <frybin@adacore.com>
440 * doc/gnat_ugn/gnat_utility_programs.rst: Document Stubs_Subdir in
441 gnattest section on user guide.
443 2018-05-31 Ed Schonberg <schonberg@adacore.com>
445 * sem_res.adb (Resolve_String_Literal): If the type is a string type
446 whose component subtype has a static predicate, ensure that the
447 predicate is applied to each character by expanding the string into the
448 equivalent aggregate. This is also done if the component subtype is
451 2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
453 * gcc-interface/trans.c (Call_to_gnu): Remove obsolete code.
455 2018-05-31 Piotr Trojanek <trojanek@adacore.com>
457 * sem_ch6.adb (Check_Missing_Return): Handle procedures with no
460 2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
462 * gcc-interface/trans.c (Call_to_gnu): In the by-reference case, if
463 the type of the parameter is an unconstrained array type, convert
464 to the type of the actual before the type of the formal only if the
465 conversion was suppressed earlier. Use in_param and gnu_actual_type
466 local variables throughout, and uniform spelling for In Out or Out.
467 Also remove dead code in the component-by-reference case.
469 2018-05-31 Frederic Konrad <konrad@adacore.com>
471 * tracebak.c (STOP_FRAME): Harden condition.
472 (is_return_from, EXTRA_STOP_CONDITION): New helpers for VxWorks in RTP
475 2018-05-31 Ed Schonberg <schonberg@adacore.com>
477 * checks.adb (Apply_Discriminant_Check): Do not apply discriminant
478 check to a call to a build-in-place function, given that the return
479 object is limited and cannot be copied.
481 2018-05-31 Olivier Hainque <hainque@adacore.com>
483 * libgnat/s-atopri.ads: Update comment on __atomic_compare_exchange
486 2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
488 * gcc-interface/trans.c (Call_to_gnu): If this is a function call and
489 there is no target, also create a temporary for the return value for
490 an allocator if the type is an unconstrained record type with default
493 2018-05-31 Hristian Kirtchev <kirtchev@adacore.com>
495 * exp_ch7.adb (Find_Transient_Context): An iteration scheme is a valid
496 boudary for a transient scope.
498 2018-05-31 Valentine Reboul <reboul@adacore.com>
500 * gnatvsn.ads: Rename "GPL" version to "Community".
502 2018-05-31 Ed Schonberg <schonberg@adacore.com>
504 * einfo.ads: Improve documentation for the Is_Unsigned_Type entity
507 2018-05-31 Piotr Trojanek <trojanek@adacore.com>
509 * sem_prag.adb (Analyze_Pragma): Replace call to Unique_Defining_Entity
510 with a semantically equivalent call to Defining_Entity.
512 2018-05-31 Piotr Trojanek <trojanek@adacore.com>
514 * sem_prag.adb (Analyze_Pragma): Set Etype on the rewritten
515 Max_Queue_Length expression.
517 2018-05-31 Sergey Rybin <rybin@adacore.com>
519 * doc/gnat_ugn/gnat_and_program_execution.rst: gnatelim does not need
520 that the main unit to be built before the call, now it computes the
521 closure of the main unit itself.
522 * gnat_ugn.texi: Regenerate.
524 2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
526 * repinfo.adb (List_Structural_Record_Layout): Set First to false
527 after having listed the fields of the parent type, if any.
529 2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
531 * gcc-interface/decl.c (gnat_to_gnu_entity) <discrete_type>: Do not
532 deal with the ___XP suffix for packed array types here...
533 <E_Array_Subtype>: ...or here when processing the implementation type
534 but when processing the original type instead. Do not reuse the DECL
535 of the implementation type for the original type. Tidy up.
537 2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
539 * einfo.ads (Object_Size_Clause): Declare.
540 * einfo.adb (Object_Size_Clause): New function.
541 * gcc-interface/utils.c (maybe_pad_type): Test Has_Size_Clause before
542 retrieving Size_Clause and post the warning on the object size clause
543 if Has_Object_Size_Clause is true.
545 2018-05-31 Javier Miranda <miranda@adacore.com>
547 * sem_util.ads, sem_util.adb (Find_Primitive_Eq): New subprogram.
548 * exp_ch4.adb (Expand_Composite_Equality): Use the new subprogram
549 Find_Primitive_Eq to search for the primitive of types whose underlying
550 type is a tagged type.
552 2018-05-31 Yannick Moy <moy@adacore.com>
554 * sem_prag.adb (Analyze_Pragma.Check_Loop_Pragma_Placement): Inverse
555 order of treatment between nodes recognized as loop pragmas (or
556 generated from one) and block statements.
558 2018-05-31 Doug Rupp <rupp@adacore.com>
560 * libgnat/s-osprim__posix2008.adb (Clock): Implement using
563 2018-05-31 Ed Schonberg <schonberg@adacore.com>
565 * exp_unst.ads, exp_unst.adb (In_Synchronized_Unit): New predicate to
566 mark subprograms that cannot be eliminated because they must be treated
567 as reachable from outside the current unit. This includes entry bodies
568 and protected operations.
570 2018-05-31 Ed Schonberg <schonberg@adacore.com>
572 * exp_ch4.adb (Expand_Modular_Addition, Expand_Modular_Subtraction):
573 Convert all operands of the generated code to Standard.Unsigned, to
574 prevent spurious visibility errors. This is needed when the generated
575 expansion involves a modular index type of an array type, and the index
576 type is not immediately visible.
578 2018-05-30 Piotr Trojanek <trojanek@adacore.com>
580 * einfo.ads (Package_Instantiation): Update comment after a routine
581 that uses this field has been renamed.
583 2018-05-30 Ed Schonberg <schonberg@adacore.com>
585 * exp_ch11.adb (Replace_Raise_By_Goto): The transfomation is legal even
586 if the local raise statement includes a string expression. This
587 expression might be picked up by an outer handler or discarded, but
588 plays no role in this transformation.
590 2018-05-30 Hristian Kirtchev <kirtchev@adacore.com>
592 * exp_aggr.adb, exp_unst.adb, freeze.adb, libgnat/a-direct.adb: Minor
595 2018-05-30 Ed Schonberg <schonberg@adacore.com>
597 * exp_unst.adb (Visit_Node): Handle the semantic Procedure_To_Call
598 field in relevant nodes: Allocate, Free, and return statements.
600 2018-05-30 Ed Schonberg <schonberg@adacore.com>
602 * exp_unst.adb (Visit_Node): Do not traverse a Component_Association
603 that has not been analyzed, as will be the case for a nested aggregate
604 that is expanded into individual assignments.
606 2018-05-30 Justin Squirek <squirek@adacore.com>
608 * aspects.adb, aspects.ads: Register new aspect.
609 * par-prag.adb (Prag): Register new pragma.
610 * sem_ch13.adb (Analyze_Aspect_Specifications): Add processing for new
611 aspect similar to Aspect_Max_Queue_Length.
612 * sem_prag.adb, sem_prag.ads (Analyze_Pragma): Register new pragma and
613 set it to use the same processing as Pragma_Max_Queue_Length.
614 * snames.ads-tmpl: Move definition of Name_Max_Entry_Queue_Depth so
615 that it can be processed as a pragma in addition to a restriction and
616 add an entry for the pragma itself.
618 2018-05-30 Ed Schonberg <schonberg@adacore.com>
620 * freeze.adb (Freeze_Object_Declaration): A pragma Thread_Local_Storage
621 is now legal on a variable of composite type initialized with an
622 aggregate that is fully static and requires no elaboration code.
623 * exp_aggr.adb (Convert_To_Positional): Recognize additional cases of
624 nested aggregates that are compile-time static, so they can be used to
625 initialize variables declared with Threqd_Local_Storage.
626 * doc/gnat_rm/implementation_defined_pragmas.rst: Add documentation on
627 Thread_Local_Storage.
628 * gnat_rm.texi: Regenerate.
630 2018-05-30 Yannick Moy <moy@adacore.com>
632 * sem_util.adb (Policy_In_Effect): Take into account CodePeer and
635 2018-05-30 Justin Squirek <squirek@adacore.com>
637 * libgnat/a-direct.adb, libgnat/a-direct.ads (Name_Case_Equivalence):
639 (Start_Search): Modify to use Start_Search_Internal
640 (Start_Search_Internal): Add to break out an extra flag for searching
641 case insensative due to the potential for directories within the same
642 OS to allow different casing schemes.
643 * sysdep.c (__gnat_name_case_equivalence): Add as a default fallback
644 for when the more precise solution fails.
646 2018-05-30 Hristian Kirtchev <kirtchev@adacore.com>
648 * checks.adb, exp_ch5.adb, exp_ch7.adb, exp_unst.adb, sem_eval.adb:
651 2018-05-30 Pascal Obry <obry@adacore.com>
653 * libgnat/g-comlin.ads (Value_Callback, Define_Switch): New.
654 * libgnat/g-comlin.adb: Add corresponding implementation.
656 2018-05-30 Gary Dismukes <dismukes@adacore.com>
658 * sem_res.adb, sem_util.adb: Fix several typos.
660 2018-05-30 Olivier Hainque <hainque@adacore.com>
662 * vx_crtbegin_attr.c (CTOR_ATTRIBUTE, DTOR_ATTRIBUTE): Empty.
663 (eh_registration_ctors, eh_registration_tors): New static variables,
664 forced in a .ctors/.dtors section, respectively, with priority.
666 2018-05-30 Bob Duff <duff@adacore.com>
668 * aspects.ads, contracts.adb, exp_util.adb, expander.adb, expander.ads,
669 freeze.adb, inline.adb, lib-xref.adb, sem.ads, sem_aggr.adb,
670 sem_attr.adb, sem_ch13.adb, sem_ch3.adb, sem_ch5.adb, sem_ch6.adb,
671 sem_ch8.adb, sem_dim.adb, sem_elab.adb, sem_res.adb, sem_res.ads,
672 sinfo.ads: Spell preanalysis, preanalyze correctly.
674 2018-05-30 Bob Duff <duff@adacore.com>
676 * libgnat/g-sestin.ads: Rework documentation comments.
678 2018-05-30 Piotr Trojanek <trojanek@adacore.com>
680 * errout.adb, exp_aggr.adb, exp_ch7.adb, exp_util.adb, lib.adb,
681 sem_ch13.adb, sem_ch4.adb, sem_res.adb, sem_util.adb
682 (Has_Original_Node): Refactor to use Is_Rewrite_Substitution.
684 2018-05-30 Piotr Trojanek <trojanek@adacore.com>
686 * sem_prag.adb (Analyze_Pragma): Remove conjuncts that are always true.
688 2018-05-30 Hristian Kirtchev <kirtchev@adacore.com>
690 * sem_util.adb (Is_Atomic_Object): Cleaned up. Split the entity logic
691 in a separate routine.
692 (Is_Atomic_Object_Entity): New routine.
693 (Is_Atomic_Prefix): Cleaned up.
694 (Is_Synchronized_Object): Check that the object is atomic, or its type
696 (Object_Has_Atomic_Components): Removed.
697 * sem_util.ads (Is_Atomic_Object): Reword the comment on usage.
698 (Is_Atomic_Object_Entity): New routine.
700 2018-05-30 Ed Schonberg <schonberg@adacore.com>
702 * sem_ch3.adb (Access_Subprogram_Declaration): The flag
703 Needs_Activation_Record is only needed on a subprogram type, not on a
705 * sem_res.adb (Resolve_Selected_Component): If the context type and the
706 component type are anonymous access to subprograms, use the component
707 type to obtain the proper value of Needs_Activation_Record flag for the
710 2018-05-30 Eric Botcazou <ebotcazou@adacore.com>
712 * gcc-interface/trans.c (gnat_to_gnu) <N_Assignment_Statement>: Add
713 comment about the memset case.
715 2018-05-30 Bob Duff <duff@adacore.com>
717 * exp_ch5.adb (Expand_Formal_Container_Element_Loop): Remove the code
718 to analyze the Elmt_Decl, because it gets analyzed in the wrong scope.
719 We need to analyze it as part of analyzing the block, so that if the
720 call to Element that initializes Elmt_Decl returns on the secondary
721 stack, the block will ss_mark/ss_release. This block is inside the
722 loop; we don't want to leak memory until the loop exits. The purpose
723 of analyzing Elmt_Decl first was to catch the error of modifying it,
724 which is illegal because it's a loop parameter. The above causes us to
725 miss that error. Therefore, we add a flag Is_Loop_Parameter, and set
726 it on the Element entity, so we end up with an E_Variable node with the
728 * einfo.ads, einfo.adb (Is_Loop_Parameter): New flag.
729 * sem_ch5.adb (Diagnose_Non_Variable_Lhs): Give the "assignment to loop
730 parameter not allowed" error if Is_Loop_Parameter.
731 * sem_util.adb (Is_Variable): Return False if Is_Loop_Parameter, to
732 trigger the call to Diagnose_Non_Variable_Lhs.
734 2018-05-30 Arnaud Charlet <charlet@adacore.com>
736 * checks.adb (Apply_Scalar_Range_Check):
737 * sem_eval.adb (Check_Non_Static_Context, Out_Of_Range): Ignore out of
738 range values for System.Priority in CodePeer mode since the actual
739 target compiler may provide a wider range.
741 2018-05-30 Ed Schonberg <schonberg@adacore.com>
743 * exp_unst.adb: Search specification of main unit as well, for
746 2018-05-30 Ed Schonberg <schonberg@adacore.com>
748 * exp_ch7.adb (Check_Unnesting_Elaboration_Code): The statement part of
749 a package body that is a compilation unit may contain blocks that
750 declare local subprograms. In Subprogram_Unnesting Mode such
751 subprograms must be handled as nested inside the (implicit) elaboration
752 procedure that executes that statement part. To handle properly uplevel
753 references we construct that subprogram explicitly, to contain blocks
754 and inner subprograms, The statement part of the compilation unit
755 becomes a call to this subprogram. This is only done if blocks are
756 present in the statement list of the body.
758 2018-05-30 Bob Duff <duff@adacore.com>
760 * exp_ch7.adb: Minor comment fix.
762 2018-05-30 Ed Schonberg <schonberg@adacore.com>
764 * exp_unst.adb (Visit_Node): Handle properly subprogram instantiations
765 that have no corresponding body and appear as attributes of the
766 corresponding wrapper package declaration.
767 (Register_Subprogram): New subprogram, used for subprogram bodies and
768 for subprogram instantiations to enter callable entity into Subp table.
770 2018-05-30 Hristian Kirtchev <kirtchev@adacore.com>
772 * libgnat/s-secsta.adb: Reimplement the secondary stack support.
773 * libgnat/s-secsta.ads: Update the documentation of all routines in the
774 public part of the package. Reimplement the private part of the
775 package to account for the new secondary stack structure. Add types
776 and subprograms for testing purposes. Add several documentation
779 2018-05-30 Hristian Kirtchev <kirtchev@adacore.com>
781 * exp_aggr.adb, exp_ch3.adb, exp_ch4.adb, exp_ch7.adb, exp_unst.adb,
782 exp_util.adb, exp_util.ads, libgnat/a-calcon.adb, libgnat/a-calcon.ads,
783 libgnat/s-os_lib.adb, repinfo.adb, sem_ch3.adb, sem_disp.adb,
784 sem_disp.ads, sem_util.adb: Minor reformatting.
786 2018-05-30 Arnaud Charlet <charlet@adacore.com>
788 * gcc-interface/Makefile.in: Move special flags for Ada runtime files
790 * Makefile.rtl: ... to here. Update comments. Protect call to
791 "GCC_FOR_TARGET" in case target_os isn't defined.
793 2018-05-30 Arnaud Charlet <charlet@adacore.com>
795 * gcc-interface/Makefile.in: Move target pair settings from here...
796 * Makefile.rtl: ... to here.
797 (setup-rts): New target.
799 2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
801 * doc/gnat_ugn/building_executable_programs_with_gnat.rst (Alphabetical
802 List of All Switches): Replace "modules" with "units".
803 (Subprogram Inlining Control): Likewise.
804 * gnat_ugn.texi: Regenerate.
805 * usage.adb (Usage): Fix description of -gnatn switch.
807 2018-05-29 Arnaud Charlet <charlet@adacore.com>
809 * gcc-interface/Makefile.in: Fix typos.
811 2018-05-29 Ed Schonberg <schonberg@adacore.com>
813 * exp_ch7.adb (Build_Finalizer_Call): Attach to tree the reference to
814 the finalizer procedure in the At_End handler, for use in LLVM
817 2018-05-29 Javier Miranda <miranda@adacore.com>
819 * exp_ch4.adb (Expand_N_Op_Eq, Expand_Composite_Equality): Use the new
820 subprogram Inherits_From_Tagged_Full_View to identify more reliably
821 untagged private types completed with a derivation of an untagged
822 private whose full view is a tagged type.
823 * sem_util.ads, sem_util.adb (Inherits_From_Tagged_Full_View): New
825 (Collect_Primitive_Operations): Handle untagged private types completed
826 with a derivation of an untagged private type whose full view is a
827 tagged type. In such case, collecting the list of primitives we may
828 find two equality primitives: one associated with the untagged private
829 and another associated with the ultimate tagged type (and we must
830 remove from the returned list this latter one).
832 2018-05-29 Ed Schonberg <schonberg@adacore.com>
834 * exp_unst.adb (Visit_Node): Handle statement sequences that include an
837 2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
839 * repinfo.adb (List_Entities): Also recurse into blocks without label.
841 2018-05-29 Ed Schonberg <schonberg@adacore.com>
843 * exp_ch6.adb (Expand_N_Subprogram_Body): Do not generate push/pop for
844 exceptions if subprogram unnesting is in effect, because these branch
845 nodes are relevant only in the presence of nested subprograms.
847 2018-05-29 Ed Schonberg <schonberg@adacore.com>
849 * libgnat/s-fatgen.adb (Succ, Pred): Raise Constraint_Error
850 unconditionally when applied to the largest positive (resp. largest
851 negative) value of a floating-point type.
853 2018-05-29 Ed Schonberg <schonberg@adacore.com>
855 * einfo.ads, einfo.adb: Clarify use of Activation_Record_Component:
856 discriminants and exceptions are never components of such. The flag
857 Needs_Activation_Record is set on subprogram types, not on access to
860 2018-05-29 Ed Schonberg <schonberg@adacore.com>
862 * sem_ch3.adb: Set scope of component of subtype.
864 2018-05-29 Ed Schonberg <schonberg@adacore.com>
866 * exp_unst.adb (Visit_Node): Exclude selected components whose prefix
867 carry no type. Such selected components appear in unit names that are
868 child units, both in the specification and possibly in an end label for
869 the unit, and they do not contain any relevant uplevel references.
871 2018-05-29 Arnaud Charlet <charlet@adacore.com>
873 * libgnat/a-calend.ads, libgnat/a-calend.adb (Epoch_Offset): Make it a
876 2018-05-29 Olivier Hainque <hainque@adacore.com>
878 * libgnat/system-vxworks7-ppc-rtp.ads: New file.
879 * libgnat/system-vxworks7-ppc-kernel.ads: New file.
880 * libgnat/system-vxworks7-e500-rtp.ads: New file.
881 * libgnat/system-vxworks7-e500-kernel.ads: New file.
882 * libgnat/system-vxworks7-x86-rtp.ads: New file.
883 * libgnat/system-vxworks-ppc64-kernel.ads: Rename as ...
884 * libgnat/system-vxworks7-ppc64-kernel.ads: and adjust name of
885 gnat-crtbe link spec to use the vx7 variant.
887 2018-05-29 Olivier Hainque <hainque@adacore.com>
889 * vx_crtbegin.inc: Use a consistent naming convention for the
890 registration/deregistration functions across RTP or kernel. Remove the
891 ctor/dtor attribute setting based on RTP/kernel, expect the optional
892 attribute extension to be provided by includers instead.
893 * vx_crtbegin.c: Mere inclusion of vx_crtbegin.inc with empty attribute
894 extension for the registration/deregistration functions.
895 * vx_crtbegin_attr.c: New file. Include vx_crtbegin.inc with explicit
896 constructor/destructor attribute extensions.
897 * vx_crtbegin_array.c: New file. Include vx_crtbegin.inc with empty
898 attribute extensions and declare _ctors/_dtors arrays.
899 * vx_crtbegin_auto.c: Remove.
900 * libgnat/system-vxworks7-aarch64-rtp-smp.ads: Use
901 vxworks7-gnat-crtbe-link.spec.
902 * libgnat/system-vxworks7-aarch64.ads: Likewise.
903 * libgnat/system-vxworks7-e500-rtp-smp.ads: Likewise.
904 * libgnat/system-vxworks7-ppc-rtp-smp.ads: Likewise.
905 * libgnat/system-vxworks7-ppc64-rtp-smp.ads: Likewise.
906 * libgnat/system-vxworks7-x86-kernel.ads: Likewise.
907 * libgnat/system-vxworks7-x86-rtp-smp.ads: Likewise.
908 * libgnat/system-vxworks7-x86_64-kernel.ads: Likewise.
909 * libgnat/system-vxworks7-x86_64-rtp-smp.ads: Likewise.
911 2018-05-29 Piotr Trojanek <trojanek@adacore.com>
913 * ali.adb: Minor reformatting.
915 2018-05-29 Joel Brobecker <brobecker@adacore.com>
917 * doc/gnat_ugn/platform_specific_information.rst: Update package
918 requirements for 32bit GNAT on x86_64-linux.
919 * gnat_ugn.texi: Regenerate.
921 2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
923 * doc/gnat_ugn/building_executable_programs_with_gnat.rst (Debugging
924 Control): Adjust description of -gnatRj.
925 * gnat_ugn.texi: Regenerate.
926 * opt.ads (List_Representation_Info_To_JSON): Likewise.
927 * repinfo.adb (List_Rep_Info): Do not automatically create a file
928 if List_Representation_Info_To_JSON is true.
929 * switch-c.adb (Scan_Front_End_Switches) <R>: Remove incompatibility
930 check between -gnatRj and -gnatRs.
931 * usage.adb (Usage): Adjust description of -gnatRj.
933 2018-05-29 Pascal Obry <obry@adacore.com>
935 * libgnat/s-os_lib.adb (Normalize_Pathname): Fix handling of ".." in
938 2018-05-29 Pascal Obry <obry@adacore.com>
940 * libgnat/s-os_lib.adb: Minor reformatting.
942 2018-05-29 Doug Rupp <rupp@adacore.com>
944 * libgnat/a-calend.adb (Epoch_Offset): Move from body to ...
945 * libgnat/a-calend.ads (Epoch_Offset): to private part of spec
946 * libgnat/a-calcon.ads (To_Unix_Nano_Time): New function spec.
947 * libgnat/a-calcon.adb (To_Unix_Nano_Time): New function body.
949 2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
951 * repinfo.ads (JSON format): Document new pair for components.
952 * repinfo.adb (Derived_Discriminant): New function.
953 (List_Structural_Record_Layout): Add Outer_Ent parameter and pass it
954 in recursive calls. If the record type is the parent of an extension,
955 find and list the derived discriminant from the extension, if any.
956 (List_Component_Layout): List the Discriminant_Number in JSON mode.
957 (List_Record_Info): Adjust call to List_Structural_Record_Layout.
959 2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
961 * doc/gnat_ugn/building_executable_programs_with_gnat.rst (Alphabetical
962 List of All Switches): Document -gnatRj.
963 (Debugging Control): Likewise.
964 * gnat_ugn.texi: Regenerate.
965 * opt.ads (List_Representation_Info_To_JSON): New boolean variable.
966 * osint-c.adb (Create_Repinfo_File): Use the .json instead of .rep
967 extension if List_Representation_Info_To_JSON is true.
968 * repinfo.ads: Document the JSON output format.
969 * repinfo.adb (List_Location): New procedure.
970 (List_Array_Info): Add support for JSON output.
971 (List_Entities): Likewise.
974 (Print_Expr): Likewise.
975 (List_Linker_Section): Likewise.
976 (List_Mechanisms): Likewise.
977 (List_Name): Likewise.
978 (List_Object_Info): Likewise.
979 (List_Record_Info): Likewise.
980 (List_Component_Layout): Likewise. Add Indent parameter.
981 (List_Structural_Record_Layout): New procedure.
982 (List_Attr): Add support for JSON output.
983 (List_Type_Info): Likewise.
984 (Write_Unknown_Val): Likewise.
985 * switch-c.adb (Scan_Front_End_Switches) <R>: Deal with 'j'.
986 * usage.adb (Usage): List -gnatRj.
988 2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
990 * repinfo.adb (List_Component_Layout): New procedure extracted from...
991 (List_Record_Layout): ...here. Invoke it.
993 2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
995 * repinfo.adb (Write_Unknown_Val): New procedure.
996 (List_GCC_Expression): Call it.
997 (List_Record_Layout): Likewise.
998 (Write_Val): Likewise.
1000 2018-05-29 Richard Kenner <kenner@vlsi1.ultra.nyu.edu>
1002 * exp_ch4.adb (Expand_N_Op_Abs): Clear Do_Overflow_Check when inserting
1005 2018-05-29 Arnaud Charlet <charlet@adacore.com>
1007 * lib-writ.adb (Write_ALI): Do not use new function from s-casuti yet.
1008 This breaks build of cross compilers with older versions of GNAT, so
1011 2018-05-29 Doug Rupp <rupp@adacore.com>
1013 * libgnarl/s-taprop.ads (Monotonic_Clock): Refine documentation to
1016 2018-05-29 Richard Kenner <kenner@vlsi1.ultra.nyu.edu>
1018 * exp_ch4.adb (Expand_N_Op_Abs): Always do range check against 'First.
1020 2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
1022 * repinfo.adb (List_Entities): Do not list the Linker_Section for
1024 (List_Mechanisms): ...but here instead. Use consistent name output
1025 and formatting conventions.
1027 2018-05-29 Bob Duff <duff@adacore.com>
1029 * lib-writ.adb (Write_ALI): Cleanup: avoid use of global var; call new
1031 * libgnat/s-casuti.ads, libgnat/s-casuti.adb (To_Upper, To_Lower,
1032 To_Mixed): New functions.
1033 * osint.adb: Cleanup: use Is_Directory_Separator, which correctly
1034 allows both '\' and '/' on Windows.
1036 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
1038 * repinfo.ads: Minor fixes and tweaks in comments.
1040 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
1042 * repinfo.adb (List_GCC_Expression): Remove Valop and replace calls to
1043 it with calls to Unop.
1045 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
1047 * repinfo.ads (TCode): Adjust range.
1048 (Truth_Andif_Expr): Remove.
1049 (Truth_Orif_Expr): Likewise.
1050 (Truth_And_Expr .. Dynamic_Val): Adjust value.
1051 * repinfo.adb (Print_Expr): Remove handling of Truth_{And,Or}if_Expr.
1052 (Rep_Value): Likewise.
1053 * repinfo.h (Truth_Andif_Expr): Remove.
1054 (Truth_Orif_Expr): Likewise.
1055 (Truth_And_Expr .. Dynamic_Val): Adjust value.
1056 * gcc-interface/decl.c (annotate_value) <TRUTH_ANDIF_EXPR>: Fall
1057 through to TRUTH_AND_EXPR case.
1058 <TRUTH_ORIF_EXPR>: Fall through to TRUTH_OR_EXPR case.
1060 2018-05-28 Ed Schonberg <schonberg@adacore.com>
1062 * exp_unst.adb (Visit_Node): For indexed components and attribute
1063 references, examine index expressions or associated expressions as well
1064 to record uplevel references.
1065 (Vist_Node): For function and procedure calls, if a formal is an
1066 unconstrained array and the actual is constrained, check whether bounds
1067 of actual have uplevel references.
1069 2018-05-28 Ed Schonberg <schonberg@adacore.com>
1071 * einfo.ads, einfo.adb: Exceptions can be uplevel references, and thus
1072 they can appear as components of activation records.
1073 * exp_unst.adb (Visit_Node): A reference to an exception may be an
1076 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
1078 * exp_ch4.adb (Expand_Composite_Equality): Compute whether the size
1079 depends on a discriminant manually instead of using the predicate
1080 Size_Depends_On_Discriminant in the array type case.
1082 2018-05-28 Ed Schonberg <schonberg@adacore.com>
1084 * exp_unst.adb (Check_Static_Type): For a record subtype, check
1085 discriminant constraints as well.
1086 (Visit_Node): For a selected component, check type of prefix, as is
1087 done for indexed components and slices.
1089 2018-05-28 Javier Miranda <miranda@adacore.com>
1091 * exp_ch4.adb (Real_Range_Check): Add a temporary to store the integer
1092 value when converting a float value to a fixed-point value. This is
1093 required for CCG because it handles fixed-point types by means of
1094 unsigned integer type variables. The range check is now performed using
1095 the integer value stored in this temporary.
1097 2018-05-28 Yannick Moy <moy@adacore.com>
1099 * sem_util.adb (Is_OK_Volatile_Context): Add attributes First, Last and
1100 Length as valid non-interfering contexts for SPARK.
1102 2018-05-28 Claire Dross <dross@adacore.com>
1104 * sem_disp.ads, sem_disp.adb (Inheritance_Utilities): Package for
1105 generic inheritance utilities.
1106 (Generic_Inherited_Subprograms): Generic version of
1107 Inherited_Subprograms, generic in Find_Dispatching_Type function.
1108 (Generic_Is_Overriding_Subprogram): Generic version of
1109 Is_Overriding_Subprogram, generic in Find_Dispatching_Type function.
1110 (Inherited_Subprograms): Instance of Generic_Inherited_Subprograms with
1111 Sem_Disp.Find_Dispatching_Type.
1112 (Is_Overriding_Subprogram): Instance of
1113 Generic_Is_Overriding_Subprogram with Sem_Disp.Find_Dispatching_Type.
1114 (Inheritance_Utilities_Inst): Instance of Inheritance_Utilities
1115 with Sem_Disp.Find_Dispatching_Type.
1117 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
1119 * exp_ch4.adb (Expand_Composite_Equality): For a composite (or FP)
1120 component type, do not expand array equality using the unconstrained
1121 base type, except for the case where the bounds of the type depend on a
1124 2018-05-28 Ed Schonberg <schonberg@adacore.com>
1126 * einfo.ads, einfo.adb (Needs_Activation_Record): New flag on
1127 access-to-subprogram types, to indicate that an indirect call through
1128 such a type requires an activation record when compiling for LLVM.
1129 * sem_ch3.adb (Access_Subprogram_Declaration): Set new flag as needed.
1131 2018-05-28 Ed Schonberg <schonberg@adacore.com>
1133 * exp_ch4.adb (Real_Range_Check): Specialize float-to-fixed conversions
1134 when bounds of fixed type are static, to remove some spuerfluous
1135 implicit conversions and provide an accurate result when converting
1136 back and forth between the fixed point type and a floating point type.
1138 2018-05-28 Ed Schonberg <schonberg@adacore.com>
1140 * exp_unst.adb (Unnest_Subprogram): Prevent creation of empty
1143 2018-05-28 Richard Kenner <kenner@vlsi1.ultra.nyu.edu>
1145 * exp_unst.adb (Check_Static_Type): Add argument to indicate node to be
1146 replaced, if any; all callers changed.
1147 (Note_Uplevel_Ref): Likewise. Also replace reference to deferred
1148 constant with private view so we take the address of that entity.
1149 (Note_Uplevel_Bound): Add argument to indicate node to be replaced, if
1150 any; all callers changed. Handle N_Indexed_Component like
1151 N_Attribute_Reference. Add N_Type_Conversion case.
1152 (Visit_Node): Indexed references can be uplevel if the type isn't
1154 (Unnest_Subprograms): Don't rewrite if no reference given. If call has
1155 been relocated, set first_named pointer in original node as well.
1157 2018-05-28 Ed Schonberg <schonberg@adacore.com>
1159 * exp_aggr.adb (Flatten): Copy tree of expression in a component
1160 association with a range or a set of discrete choices, rather than
1161 relocating the node. This avoids inconsistencies in the tree when
1162 handling nested subprograms with uplevel references for LLVM.
1164 2018-05-28 Arnaud Charlet <charlet@adacore.com>
1166 * exp_util.adb (Possible_Bit_Aligned_Component): Always return False in
1169 2018-05-28 Arnaud Charlet <charlet@adacore.com>
1171 * exp_unst.adb: Fix typo.
1173 2018-05-28 Bob Duff <duff@adacore.com>
1175 * libgnat/a-convec.adb (Query_Element): Minor cleanup: remove an
1176 unnecessary use of 'Unrestricted_Access.
1178 2018-05-28 Hristian Kirtchev <kirtchev@adacore.com>
1180 * repinfo.adb (Expr_Value_S): New routine.
1181 (List_Linker_Section): Properly extract the value of the section
1184 2018-05-28 Patrick Bernardi <bernardi@adacore.com>
1186 * doc/gnat_ugn/building_executable_programs_with_gnat.rst: Update the
1187 description of the -D binder switch to reflect current usage.
1188 * gnat_ugn.texi: Regenerate.
1190 2018-05-28 Gary Dismukes <dismukes@adacore.com>
1192 * exp_ch3.adb: Minor reformatting
1194 2018-05-28 Justin Squirek <squirek@adacore.com>
1197 (Build_Initialization_Call): Add logic to pass the appropriate actual to match
1199 (Init_Formals): Add new formal *_skip_null_excluding_check
1200 * exp_util.adb, exp_util.ads
1201 (Enclosing_Init_Proc): Added to fetch the enclosing Init_Proc from the current
1203 (Inside_Init_Proc): Refactored to use Enclosing_Init_Proc
1204 (Needs_Conditional_Null_Excluding_Check): Added to factorize the predicate
1205 used to determine how to generate an Init_Proc for a given type.
1206 (Needs_Constant_Address): Minor reformatting
1208 (Resolve_Null): Add logic to generate a conditional check in certain cases
1210 2018-05-28 Hristian Kirtchev <kirtchev@adacore.com>
1212 * exp_aggr.adb, gnatlink.adb, sem_ch6.adb, sem_res.adb, sem_util.adb:
1215 2018-05-28 Hristian Kirtchev <kirtchev@adacore.com>
1217 * sem_prag.adb (Process_Atomic_Independent_Shared_Volatile): Include
1218 the declarations of single concurrent types because they fall in the
1219 category of full type and object declarations.
1221 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
1223 * repinfo.adb (Compute_Max_Length): Skip _Parent component.
1224 (List_Record_Layout): Likewise.
1226 2018-05-28 Ed Schonberg <schonberg@adacore.com>
1228 * sem_util.adb (Is_Function_Result): Add a warning if a postcondition
1229 includes a call to function to which it applies. This may mean an
1230 omission of an attribute reference 'Result, in particular if the
1231 function is pqrameterless.
1233 2018-05-28 Justin Squirek <squirek@adacore.com>
1235 * sem_ch8.adb (Find_Expanded_Name): Add extra guard to make sure the
1236 misresolved package name is not a case of mistaken identity.
1238 2018-05-28 Yannick Moy <moy@adacore.com>
1240 * sem_res.adb (Resolve_Range): Re-resolve the low bound of a range in
1241 GNATprove mode, as the order of resolution (low then high) means that
1242 all the information is not available when resolving the low bound the
1245 2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
1247 * repinfo.adb (List_Array_Info): Start with an explicit blank line and
1248 end with the linker section, if any.
1249 (List_Entities): Do not output the linker section for record types,
1250 array types and variables.
1251 (Print_Expr): Factor out common processing for unary operators and
1252 special values. Adjust and reorder the various cases.
1253 (List_Object_Info): End with the linker section, if any.
1254 (List_Record_Info): Likewise.
1255 (List_Type_Info): Do not start with a blank line.
1257 2018-05-25 Nicolas Roche <roche@adacore.com>
1259 * libgnat/s-valrea.adb (Scan_Real): Abort computation once it is sure
1260 that the result will be either -infinite or +infinite.
1262 2018-05-25 Patrick Bernardi <bernardi@adacore.com>
1264 * libgnat/s-parame.ads, libgnat/s-parame__vxworks.ads,
1265 libgnat/s-parame__ae653.ads, libgnat/s-parame__hpux.ads (Size_Type):
1266 Expand range of type to match the address space of the target.
1267 (Task_Storage_Size): Remove unused type.
1269 2018-05-25 Ed Schonberg <schonberg@adacore.com>
1271 * sem_res.adb (Set_Mixed_Mode_Operand): If the operand is an expression
1272 of a fixed point type and the parent is a multiplying operation,
1273 resolve the operand with its own type because the context will impose a
1274 resulting type on the result of the multiplication by means of
1275 approriate conversion.
1277 2018-05-25 Hristian Kirtchev <kirtchev@adacore.com>
1279 * exp_ch3.adb (Default_Initialize_Object): Ensure that the analysis of
1280 the in-place initialization aggregate created for pragmas
1281 Initialize_Scalars or Normalize_Scalars is performed with checks
1284 2018-05-25 Arnaud Charlet <charlet@adacore.com>
1286 * exp_aggr.adb (Convert_To_Positional): Bump default for
1287 Max_Others_Replicate to 32. Update comments.
1288 * osint.ads (Unknown_Attributes): No longer pretend this is a constant.
1289 (No_File_Info_Cache): Initialize separately.
1290 * osint.adb (No_File_Info_Cache): Update initializer.
1292 2018-05-25 Javier Miranda <miranda@adacore.com>
1294 * sem_res.adb (Resolve_Membership_Op): Allow the use of the membership
1295 test when the left operand is a class-wide interface and the right
1296 operand is not a class-wide type.
1297 * exp_ch4.adb (Tagged_Membership): Adding support for interface as the
1300 2018-05-25 Ed Schonberg <schonberg@adacore.com>
1302 * exp_aggr.adb (Flatten): A quantified expression cannot be duplicated
1303 in an others clause to prevent visibility issues with the generated
1305 (Component_OK_For_Backend): Return false for a quantified expression.
1306 (Check_Static_Component): Ditto.
1308 2018-05-25 Hristian Kirtchev <kirtchev@adacore.com>
1310 * libgnat/s-secsta.adb (SS_Allocate): Reimplemented.
1311 (SS_Allocate_Dynamic): New routine. The allocation logic is now split
1312 into three distring cases rather than in one loop which attempts to
1313 handle all three cases. This rewrite eliminates an issue where the last
1314 frame of the stack cannot be freed, thus causing the memory range of a
1315 new frame to approach the overflow point of the memory index type.
1316 Since the overflow is logically treated as a
1317 too-much-memory-on-the-stack scenario, it causes a bogus Storage_Error.
1318 (SS_Allocate_Static): New routine. The routine factorizes the static
1319 secondary stack-related code from the former SS_Allocate.
1321 2018-05-25 Sergey Rybin <rybin@adacore.com>
1323 * doc/gnat_ugn/gnat_and_program_execution.rst: Add description of '-U'
1324 option for gnatelim.
1326 2018-05-25 Ed Schonberg <schonberg@adacore.com>
1328 * sem_ch6.adb (Analyze_Subprogram_Body_Helper): Do not create
1329 Class_Wide_Clone_Body when analyzing a subprogram_body_stub: the clone
1330 is created when the proper body of the stub is analyzed.
1331 * sem_util.adb (ZBuild_Class_Wide_Clone_Body): If the subprogram body
1332 is the proper body of a subunit, the cloned body must be inserted in
1333 the declarative list that contains the stub.
1335 2018-05-25 Justin Squirek <squirek@adacore.com>
1337 * exp_ch6.adb (Expand_Simple_Function_Return): Add guard in check to
1338 generate code for 6.5(8-10) so that we don't get an assertion error
1339 when dealing with an incomplete return type.
1341 2018-05-25 Arnaud Charlet <charlet@adacore.com>
1343 * pprint.adb (Expression_Name): Strip too long expressions to avoid
1344 carrying very large strings.
1346 2018-05-25 Patrick Bernardi <bernardi@adacore.com>
1348 * switch-b.adb (Scan_Binder_Switches): binder switch -Q accepts Natural
1351 2018-05-25 Doug Rupp <rupp@adacore.com>
1353 * tracebak.c (aarch64-linux): Implement.
1355 2018-05-25 Justin Squirek <squirek@adacore.com>
1357 * sem_ch8.adb: Minor reformatting.
1359 2018-05-25 Piotr Trojanek <trojanek@adacore.com>
1361 * sem_util.adb (Iterate_Call_Parameters): Fix code convention and
1364 2018-05-25 Hristian Kirtchev <kirtchev@adacore.com>
1366 * einfo.adb, einfo.ads, exp_ch3.adb, exp_ch8.adb, exp_unst.adb,
1367 pprint.adb, sem_ch12.adb, sem_ch3.adb, sem_prag.adb, sem_util.adb:
1370 2018-05-25 Ed Schonberg <schonberg@adacore.com>
1372 * sem_ch12.adb (Instance_Exists): New function, subsidiary of
1373 Validate_Derived_Type_Instance, to verify that all interfaces
1374 implemented by the formal type are also implemented by the actual. The
1375 verification is complicated when an interface of the formal is declared
1376 in a generic unit and the actual is declared in an instance of it.
1377 There is currently no mechanism to relate an interface declared within
1378 a generic to the corresponding interface in an instance, so we must
1379 traverse the list of interfaces of the actual, looking for a name
1380 match, and verifying that that interface is declared in an instance.
1382 2018-05-25 Piotr Trojanek <trojanek@adacore.com>
1384 * sem_util.adb (Iterate_Call_Parameters): Rewrite with extra
1385 assertions; replace function versions of Next_Formal/Next_Actual with
1386 their procedural versions (which are more concise).
1388 2018-05-25 Doug Rupp <rupp@adacore.com>
1390 * libgnarl/s-osinte__aix.ads, libgnarl/s-osinte__android.ads,
1391 libgnarl/s-osinte__darwin.ads, libgnarl/s-osinte__freebsd.ads,
1392 libgnarl/s-osinte__hpux.ads, libgnarl/s-osinte__kfreebsd-gnu.ads,
1393 libgnarl/s-osinte__linux.ads, libgnarl/s-osinte__lynxos178e.ads,
1394 libgnarl/s-osinte__qnx.ads, libgnarl/s-osinte__rtems.ads
1395 (Relative_Timed_Wait): Remove.
1396 * libgnarl/s-tpopmo.adb (Timed_Sleep, Timed_Delay): Rewrite to allow
1397 for incremental looping. Remove references to Rel_Time and
1398 Relative_Timed_Wait.
1399 * libgnat/s-osprim__posix.adb, libgnat/s-osprim__posix2008.adb
1400 (Timed_Delay): Make separate.
1401 * libgnat/s-optide.adb: New separate procedure.
1402 * libgnat/s-osprim.ads (Max_System_Delay): New constant.
1403 * libgnat/s-osprim__lynxos.ads (Max_Sensible_Delay): Set to 6 months.
1404 (Max_System_Delay): New constant.
1406 2018-05-25 Ed Schonberg <schonberg@adacore.com>
1408 * sem_ch12.adb (Validate_Derived_Type_Instance): Verify that the actual
1409 for a formal derived type implements all the interfaces declared for
1412 2018-05-25 Yannick Moy <moy@adacore.com>
1414 * sem_prag.adb (Check_Applicable_Policy): Deal specially with CodePeer
1415 and GNATprove modes when applicable policy is Ignore.
1417 2018-05-25 Eric Botcazou <ebotcazou@adacore.com>
1419 * freeze.adb (Freeze_Enumeration_Type): Do not give integer size to a
1420 boolean type with convention C.
1421 * libgnat/i-cexten.ads (bool): Change to boolean with convention C.
1422 * gcc-interface/decl.c (gnat_to_gnu_entity): Add new local variable
1423 FOREIGN and use it throughout the function.
1424 <E_Enumeration_Type>: Set precision 1 on boolean types with foreign
1426 <E_Enumeration_Subtype>: Likewise for subtypes.
1427 <E_Record_Type>: Force the size of a storage unit on empty classes.
1428 * gcc-interface/utils.c (make_type_from_size) <BOOLEAN_TYPE>: Skip
1429 boolean types with precision 1 if the size is the expected one.
1431 2018-05-25 Arnaud Charlet <charlet@adacore.com>
1433 * pprint.adb (Expression_Name): Do not print non ASCII characters.
1435 2018-05-25 Bob Duff <duff@adacore.com>
1437 * libgnat/a-strunb__shared.ads, libgnat/a-stwiun__shared.ads,
1438 libgnat/a-stzunb__shared.ads: (Initialize, Adjust): Add pragma Inline.
1440 2018-05-25 Bob Duff <duff@adacore.com>
1442 * sem_util.ads: Minor comment fix.
1444 2018-05-25 Ed Schonberg <schonberg@adacore.com>
1446 * exp_unst.adb (Visit_Node): Restrict check for uplevel references in
1447 prefixes of array attributes, to prefixes that are entity names whose
1448 type is constrained.
1449 (Note_Uplevel_Bound): Verify that the bound is declared in an enclosing
1450 subprogram, as itype created for loops in pre/postcondition may appear
1451 in loops at the library level.
1453 2018-05-25 Ed Schonberg <schonberg@adacore.com>
1455 * sem_ch13.adb (Build_Predicate_Functions): The predicate function
1456 declaration is inserted into the tree and analyzed at that point, so
1457 should not be reinserted when the body is constructed. Inside a
1458 generic, ensure that the body is not inserted twice in the tree.
1460 2018-05-25 Yannick Moy <moy@adacore.com>
1462 * sem_prag.adb (Check_Grouping): Modify test to ignore statements and
1463 declarations not coming from source.
1465 2018-05-25 Fedor Rybin <frybin@adacore.com>
1467 * doc/gnat_ugn/gnat_utility_programs.rst: Document new switch
1468 --copy-environment for gnattest.
1470 2018-05-24 Piotr Trojanek <trojanek@adacore.com>
1472 * sem_elab.adb (Non_Private_View): Simplify by removing a local Result
1474 * sem_prag.adb (Get_Base_Subprogram): Same as above.
1476 2018-05-24 Eric Botcazou <ebotcazou@adacore.com>
1478 * fe.h (Set_Normalized_First_Bit): Declare.
1479 (Set_Normalized_Position): Likewise.
1480 * repinfo.adb (List_Record_Layout): Do not use irregular output for a
1481 variable position. Fix minor spacing issue.
1482 * gcc-interface/decl.c (annotate_rep): If a field has a variable
1483 offset, compute the normalized position and annotate it in addition to
1486 2018-05-24 Eric Botcazou <ebotcazou@adacore.com>
1488 * gcc-interface/trans.c (Handled_Sequence_Of_Statements_to_gnu):
1489 Constify and rename variables. Fix formatting.
1490 (gnat_to_gnu) <N_Exception_Handler>: Minor tweak.
1491 <N_Raise_Statement>: Likewise.
1493 2018-05-24 Javier Miranda <miranda@adacore.com>
1495 * exp_ch8.adb (Build_Body_For_Renaming): Adding support to build the
1496 body of a variant record equality renaming.
1497 (Expand_N_Subprogram_Renaming_Declaration): Adapt the code to the new
1498 implementation of Build_Body_For_Renaming.
1499 * exp_ch3.ads (Build_Variant_Record_Equality): New library level
1500 function that factorizes the functionality needed by
1501 Build_Body_For_Renaming and Expand_Freeze_Record_Type to build the body
1502 of a variant record equality subprogram.
1503 * exp_ch3.adb (Build_Variant_Record_Equality): New subprogram.
1504 (Build_Variant_Record_Equality): New local procedure of
1505 Expand_Freeze_Record_Type containing all the code specific for freezing
1506 the record type that cannot be place in the new library level function.
1508 2018-05-24 Ed Schonberg <schonberg@adacore.com>
1510 * einfo.ads, einfo.adb (Is_Activation_Record): New flag on
1511 in_parameters, used when unesting subprograms for LLVM, to indicate
1512 that a generated parameter carries the activation record from the
1513 enclosing subprogram.
1514 * exp_unst.adb (Check_Static_Type): Handle array attributes of types
1515 whose bounds may contain up-level references that need to be added to
1516 an activation recoord.
1517 (Add_Extra_Formal): Set Is_Activation_Record on new formal.
1519 2018-05-24 Yannick Moy <moy@adacore.com>
1521 * pprint.adb (Expression_Image): Improve the printing of expressions,
1522 by taking more cases into account, in particular qualified expressions
1523 and aggregates. Also count more the number of parentheses to close
1524 after the expression.
1526 2018-05-24 Javier Miranda <miranda@adacore.com>
1528 * sem_ch3.adb (Is_Visible_Component): For untagged types add missing
1529 check for renamed discriminants.
1530 * sem_ch4.adb (Analyze_Overloaded_Selected_Component,
1531 Analyze_Selected_Component, Check_Misspelled_Selector): For calls to
1532 Is_Visible_Component pass the associated selector node to allow
1533 checking renamed discriminants on untagged types.
1535 2018-05-24 Ed Schonberg <schonberg@adacore.com>
1537 * sem_ch8.adb (Analyze_Use_Type): Do not assign the Prev_Use_Clause
1538 link to a use_type clause if this would cause an infinite loop in the
1539 machinery that detects redundant use clauses. This may happen when the
1540 redundant clauses appear in the context of a child unit and the context
1543 2018-05-24 Piotr Trojanek <trojanek@adacore.com>
1545 * sinfo.ads: Fix grammar in comment.
1547 2018-05-24 Justin Squirek <squirek@adacore.com>
1549 * einfo.ads, einfo.adb (Append_Entity): Modified to use Link_Entities
1550 and manage doubly-linked entity chain.
1551 (Nested_Scenarios): Removed entity field used for optimization during
1552 elaboration to make room for the new field Prev_Entity.
1553 (Link_Entities): Added to replace redundant calls to Set_Next_Entity
1554 and Set_Prev_Entity as well as centralize changes to the entity chain.
1555 (Predicated_Parent): Modified to use Node38.
1556 (Prev_Entity): Added to fetch new node field Prev_Entity in all entity
1558 (Remove_Entity): Moved from sem_util.
1559 (Set_Nested_Scenarios): Deleted.
1560 (Set_Predicated_Parent): Modified to use Node38.
1561 (Set_Prev_Entity): Added to set Prev_Entity field.
1562 (Set_Validated_Object): Modified to use Node38.
1563 (Unlink_Next_Entity): Added to process Prev_Entity when an unlinking
1565 (Validated_Object): Modified to use Node38.
1566 (Write_Field36_Name): Remove Nested_Scenarios, Validated_Object, and
1567 predicated parent cases.
1568 (Write_Field38_Name): Add predicated parent and Validated_Object cases.
1569 * sem_ch3.adb (Process_Subtype): Add guard to protect against
1570 inappropriate marking of Predicated_Parent to non-itype subtypes.
1571 (Make_Class_Wide_Type): Preserve Prev_Entity field and set in new type.
1572 (Copy_And_Swap): Add setting of Prev_Entity.
1573 (Build_derived_Record_Type): Replace Set_Next_Entity w/ Link_Entities.
1574 * sem_ch6.adb (Analyze_Subprogram_Body_Helper): Replace Set_Next_Entity
1576 (New_Overloaded_Entity): Remove block created to search for previous
1577 entities in the entity chain with relevant calls to Prev_Entity as well
1578 as replace duplicated code from Remove_Entity_And_Homonym with a call
1580 * sem_ch7.adb (Exchange_Declarations): Replace Set_Next_Entity w/
1582 * sem_elab.adb (Find_And_Process_Nested_Scenarios): Remove global and
1583 initial subprogram declarations related to Nested_Scenarios.
1584 (Process_Nested_Scenarios): Deleted.
1585 (Save_Scenario): Deleted.
1586 (Traverse_Body): Remove optimization for Nested_Scenarios so as to free
1587 node space in the entity tree.
1588 * sem_util.adb, sem_util.ads (Remove_Entity): Moved to einfo.
1589 (Remove_Entity_And_Homonym): Added to separate functionality of
1590 Remove_Entity from the homonym chain directly.
1591 * exp_attr.adb (Expand_N_Attribute_Reference): Replace Set_Next_Entity
1592 w/ Link_Entities and Unlink_Next_Entity.
1593 * exp_ch3.adb (Expand_N_Object_Declaration): Replace Set_Next_Entity w/
1595 * exp_ch6.adb (Replace_Renaming_Declaration_Id): Replace
1596 Set_Next_Entity w/ Link_Entities.
1597 * exp_disp.adb (Expand_Dispatching_Call): Replace Set_Next_Entity w/
1598 Link_Entities and Unlink_Next_Entity.
1599 * exp_spark.adb (Expand_SPARK_N_Object_Renaming_Declaration): Replace
1600 call to Remove_Entity with its new incarnation.
1601 * exp_util.adb (New_Class_Wide_Subtype): Add setting of Prev_Entity.
1602 * freeze.adb (Freeze_Record_Type): Replace Set_Next_Entity w/
1605 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
1607 * sem_ch10.adb (Expand_Limited_With_Clause): Update the call to
1608 Install_Limited_Withed_Unit.
1609 (Expand_With_Clause): Update the call to Install_Withed_Unit.
1610 (Implicit_With_On_Parent): Update the call to Install_Withed_Unit.
1611 (Install_Context_Clauses): Update the call to Install_Withed_Unit.
1612 (Install_Limited_Context_Clauses): Update the calls to
1613 Install_Limited_Withed_Unit.
1614 (Install_Limited_Withed_Unit): Renamed to better illustrate its
1616 (Install_Private_With_Clauses): Update the calls to Install_Withed_Unit
1617 and Install_Limited_Withed_Unit.
1618 (Install_With_Clause): Uninstall a limited with clause if a [private]
1619 with clause is given for the same package.
1620 (Install_Withed_Unit): Renamed to better illustrate its purpose.
1621 (Remove_Limited_With_Unit): New routine.
1623 2018-05-24 Eric Botcazou <ebotcazou@adacore.com>
1625 * raise-gcc.c (__gnat_SEH_error_handler): Remove prototype.
1626 (__gnat_personality_seh0): Adjust and beef up comments, and
1627 fix formatting throughout.
1628 (__gnat_adjust_context): Deal minimally with version 2.
1629 * seh_init.c (__gnat_map_SEH): Fix formatting.
1630 (_gnat_SEH_error_handler): Adjust comments.
1631 (__gnat_install_SEH_handler): Fix formatting.
1633 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
1635 * exp_ch7.adb, sem_ch3.adb, sem_res.adb: Minor reformatting.
1637 2018-05-24 Ed Schonberg <schonberg@adacore.com>
1639 * exp_aggr.adb (Flatten): Add a warning on an others clause in an array
1640 aggregate with static bounds when named associations cover all index
1641 positions and the others clause is redundant.
1643 2018-05-24 Raphael Amiard <amiard@adacore.com>
1645 * libgnat/a-cohama.ads: Add documentation.
1647 2018-05-24 Raphael Amiard <amiard@adacore.com>
1649 * libgnat/a-convec.ads: Add documentation.
1651 2018-05-24 Justin Squirek <squirek@adacore.com>
1653 * exp_ch3.adb (Expand_N_Object_Declaration): Ignore raising an error in
1654 expansion for limited tagged types when the node to be expanded is a
1655 raise expression due to it not representing a valid object.
1656 * exp_ch5.adb (Expand_N_Assignment_Statement): Add exception to error
1657 message regarding assignments to limited types to ignore genereated
1660 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
1662 * exp_util.adb (New_Class_Wide_Subtype): Capture and restore relevant
1663 Ghost-related attributes of the class-wide subtype because the copy
1666 2018-05-24 Justin Squirek <squirek@adacore.com>
1668 * sem_res.adb (Resolve_Entity_Name): Add guard to protect against
1669 marking use clauses as effective when the reference appears within
1672 2018-05-24 Cyrille Comar <comar@adacore.com>
1674 * doc/gnat_rm/the_gnat_library.rst: Fix typos.
1675 * gnat_rm.texi: Regenerate.
1677 2018-05-24 Bob Duff <duff@adacore.com>
1679 * exp_ch7.adb (Expand_Cleanup_Actions): Create a mark unconditionally
1680 for build-in-place functions with a caller-unknown-size result.
1681 (Create_Finalizer): For build-in-place functions with a
1682 caller-unknown-size result, check at run time whether we need to
1683 release the secondary stack.
1685 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
1687 * sem_prag.adb (Analyze_Pragma): Use the full view of an internally
1688 generated incomplete type.
1690 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
1692 * expander.adb (Expand): Update the save and restore of the Ghost
1694 * exp_ch3.adb (Freeze_Type): Likewise.
1695 * exp_disp.adb (Make_DT): Likewise.
1696 * exp_util.adb (Build_DIC_Procedure_Body): Likewise.
1697 (Build_DIC_Procedure_Declaration): Likewise.
1698 (Build_Invariant_Procedure_Body): Likewise.
1699 (Build_Invariant_Procedure_Declaration): Likewise.
1700 (Make_Predicate_Call): Likewise.
1701 * freeze.adb (Add_To_Result): Insert the freeze action of a living
1702 entity prior to the start of the enclosing ignored Ghost region.
1703 (Freeze_Entity): Update the save and restore of the Ghost region.
1704 * ghost.adb (Install_Ghost_Mode): Reimplemented.
1705 (Install_Ghost_Region): New routine.
1706 (Mark_And_Set_Ghost_Assignment): Install a region rather than a mode.
1707 (Mark_And_Set_Ghost_Body): Likewise.
1708 (Mark_And_Set_Ghost_Completion): Likewise.
1709 (Mark_And_Set_Ghost_Declaration): Likewise.
1710 (Mark_And_Set_Ghost_Instantiation): Likewise.
1711 (Mark_And_Set_Ghost_Procedure_Call): Likewise.
1712 (Name_To_Ghost_Mode): New routine.
1713 (Restore_Ghost_Region): New routine.
1714 * ghost.ads (Install_Ghost_Region): New routine.
1715 (Restore_Ghost_Region): New routine.
1716 * opt.ads: Add new global variable Ignored_Ghost_Region.
1717 * rtsfind.adb (Load_RTU): Update the save and restore of the Ghost
1718 region. Install a clean region.
1719 * sem.adb (Analyze): Likewise.
1720 (Do_Analyze): Likewise.
1721 * sem_ch3.adb (Analyze_Object_Declaration): Likewise
1722 (Derive_Progenitor_Subprograms): Use local variable Iface_Alias to
1723 capture the ultimate alias of the current primitive.
1724 (Process_Full_View): Update the save and restore of the Ghost region.
1725 Do not inherit DIC and invariant procedures.
1726 * sem_ch5.adb (Analyze_Assignment): Update the save and restore of the
1728 * sem_ch6.adb (Analyze_Procedure_Call): Likewise.
1729 (Analyze_Subprogram_Body_Helper): Likewise.
1730 * sem_ch7.adb (Analyze_Package_Body_Helper): Likewise.
1731 * sem_ch12.adb (Analyze_Package_Instantiation): Likewise.
1732 (Analyze_Subprogram_Instantiation): Likewise.
1733 (Instantiate_Package_Body): Likewise.
1734 (Instantiate_Subprogram_Body): Likewise.
1735 * sem_ch13.adb (Build_Predicate_Functions): Likewise.
1736 (Build_Predicate_Function_Declaration): Likewise.
1738 (Add_Dispatching_Operation): Do not consider DIC and invariant
1740 (Check_Dispatching_Operation): Use Add_Dispatching_Operation to collect
1741 a dispatching subprogram.
1742 (Check_Operation_From_Private_View): Likewise.
1743 (Override_Dispatching_Operation): Likewise.
1744 * sem_prag.adb (Analyze_Contract_Cases_In_Decl_Part): Update the save
1745 and restore of the Ghost region.
1746 (Analyze_Initial_Condition_In_Decl_Part): Likewise.
1747 (Analyze_Pragma): Update the save and restore of the Ghost region.
1748 (Analyze_Pre_Post_Condition_In_Decl_Part): Likewise.
1749 * sem_util.adb (Is_Suitable_Primitive): New routine.
1750 * sem_util.ads (Is_Suitable_Primitive): New routine.
1751 * sinfo.ads: Update the section of Ghost regions.
1753 2018-05-24 Piotr Trojanek <trojanek@adacore.com>
1755 * doc/gnat_rm/implementation_defined_pragmas.rst (Contract_Cases):
1756 Change "condition" to "case guard" after renaming in the contract
1758 * gnat_rm.texi: Regenerate.
1760 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
1762 * exp_util.adb (Expand_Static_Predicates_In_Choices): Indicate that the
1763 construct with discrete choices no longer contains a subtype with
1764 predicates since the expansion already handled this case.
1766 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
1768 * freeze.adb (Wrap_Imported_Subprogram): Generate an unchecked
1769 conversion to the return type to avoid a side effect where an imported
1770 relocated function generates a new anonymous access type, whose
1771 accessibility level does not agree with with that of the wrapper.
1773 2018-05-24 Javier Miranda <miranda@adacore.com>
1775 * sem_util.adb (Abstract_Interface_List): Add missing support for
1776 private types whose full view is a synchronized type.
1777 * sem_ch3.adb (Build_Derived_Private_Type): Skip building the full
1778 derivation of a private type parent type is a task type with
1779 discriminants as gigi does not use such type directly.
1781 2018-05-24 Hristian Kirtchev <kirtchev@adacore.com>
1783 * sem_elab.adb (Build_Variable_Reference_Marker): Do not create a
1784 variable marker when the reference appears in the formal part of a
1785 compilation unit instance because there is no place to insert it.
1786 (In_Compilation_Instance_Formal_Part): New routine.
1788 2018-05-24 Piotr Trojanek <trojanek@adacore.com>
1790 * layout.ads, repinfo.ads: Fix references to renamed Backend_Layout
1791 configuration parameter.
1793 2018-05-24 Doug Rupp <rupp@adacore.com>
1795 * argv-lynxos178-raven-cert.c: New file.
1796 * libgnat/system-lynxos178-x86.ads: New file.
1798 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
1800 * exp_disp.adb, freeze.adb, gnat1drv.adb, sem_ch5.adb, sem_spark.adb:
1801 Minor reformattings.
1803 2018-05-23 Pascal Obry <obry@adacore.com>
1805 * adaint.c (win32_wait): Properly free the handle/pid lists when
1806 WaitForMultipleObjects fails (return WAIT_FAILED).
1808 2018-05-23 Pascal Obry <obry@adacore.com>
1810 * adaint.c (win32_wait): Add missing parentheses.
1812 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
1814 * exp_ch3.adb (Check_Large_Modular_Array): Moved to Freeze.
1815 (Expand_N_Object_Declaration): Do not check for a large modular array
1817 * freeze.adb (Check_Large_Modular_Array): Moved from Exp_Ch3.
1818 (Freeze_Object_Declaration): Code cleanup. Check for a large modular
1820 * sem_ch3.adb: Minor reformatting.
1822 2018-05-23 Ed Schonberg <schonberg@adacore.com>
1824 * einfo.ads: New attribute on types: Predicated_Parent, to simplify the
1825 retrieval of the applicable predicate function to an itype created for
1826 a constrained array component.
1827 * einfo.adb: Subprograms for Predicated_Parent.
1828 (Predicate_Function): Use new attribute.
1829 * exp_util.adb (Make_Predicate_Call): If the predicate function is not
1830 available for a subtype, retrieve it from the base type, which may have
1831 been frozen after the subtype declaration and not captured by the
1832 subtype declaration.
1833 * sem_aggr.adb (Resolve_Array_Aggregate): An Others association is
1834 legal within a generated initiqlization procedure, as may happen with a
1835 predicate check on a component, when the predicate function applies to
1836 the base type of the component.
1837 * sem_ch3.adb (Analyze_Subtype_Declaration): Clean up inheritance of
1838 predicates for subtype declarations and for subtype indications in
1840 (Process_Subtype): Likewise. Handle properly the case of a private type
1841 with unknown discriminants whose full view is an unconstrained array.
1842 Use Predicated_Parent to indicate source of predicate function on an
1843 itype whose parent is itself an itype.
1844 (Complete_Private_Subtype): If the private view has unknown
1845 discriminants and the full view is an unconstrained array, set base
1846 type of completion to the full view of parent.
1847 (Inherit_Predicate_Flags): Prevent double assignment of predicate
1849 (Build_Subtype): For a constrained array component, propagate predicate
1850 information from original component type declaration.
1852 2018-05-23 Boris Yakobowski <yakobowski@adacore.com>
1854 * libgnat/a-ngelfu.ads (Arctanh, Arccoth): Fix faulty preconditions.
1856 2018-05-23 Arnaud Charlet <charlet@adacore.com>
1858 * checks.adb (Minimize_Eliminate_Overflows): Default initialize Lo and
1860 * sem_elab.adb: Make "out" parameters instead of "in out" when
1863 2018-05-23 Bob Duff <duff@adacore.com>
1865 * gnatbind.adb (List_Applicable_Restrictions): Add
1866 No_Implementation_Restrictions to the list of restrictions not to list.
1867 Remove double negative "not No_Restriction_List". Comment the
1868 commentary that is output, so it won't cause errors if used directly in
1871 2018-05-23 Ed Schonberg <schonberg@adacore.com>
1873 * sem_prag.adb (Inherit_Class_Wide_Pre): Refine legality check on
1874 class-wide precondition on a type extension when ancestor does not have
1875 a class-wide precondition. Previously the compiler accepted such a
1876 precondition when the ancestor had a class-wide postcondition.
1878 2018-05-23 Javier Miranda <miranda@adacore.com>
1880 * sem_attr.adb (Valid_Scalars): Do not invoke Error_Attr_P to report
1881 the warning on occurrences of this attribute whose evaluation is always
1882 true (since that subprogram aborts processing the attribute). In
1883 addition, replace the node by its boolean result 'True' (required
1884 because the backend has no knowledge of this attribute).
1886 2018-05-23 Bob Duff <duff@adacore.com>
1888 * libgnat/a-convec.adb: (Insert, Insert_Space): Suppress warnings. The
1889 code in question is not reachable in the case where Count_Type'Last is
1892 2018-05-23 Yannick Moy <moy@adacore.com>
1894 * doc/gnat_rm/implementation_defined_pragmas.rst: Clarify meaning of
1895 local pragma Warnings Off without On.
1896 * gnat_rm.texi: Regenerate.
1898 2018-05-23 Olivier Hainque <hainque@adacore.com>
1900 * libgnat/g-excact.ads (Is_Foreign_Exception): New predicate.
1901 * libgnat/g-excact.adb: Implement.
1903 2018-05-23 Ed Schonberg <schonberg@adacore.com>
1905 * sem_ch5.adb (Analyze_Iterator_Specification): If a subtype indication
1906 is present, verify its legality when the domain of iteration is a
1907 GNAT-specific formal container, as is already done for arrays and
1908 predefined containers.
1910 2018-05-23 Yannick Moy <moy@adacore.com>
1912 * sem_util.adb (Enclosing_Declaration): Fix the case of a named number
1913 declaration, which was not taken into account.
1915 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
1917 * debug.adb: Switch -gnatd_s is now used to stop elaboration checks on
1918 synchronized suspension.
1919 * rtsfind.ads: Add entries for units Ada.Synchronous_Barriers and
1920 Ada.Synchronous_Task_Control and routines Suspend_Until_True and
1922 * sem_elab.adb: Document switch -gnatd_s.
1923 (In_Task_Body): New routine.
1924 (Is_Potential_Scenario): Code cleanup. Stop the traversal of a task
1925 body when the current construct denotes a synchronous suspension call,
1926 and restriction No_Entry_Calls_In_Elaboration_Code or switch -gnatd_s
1928 (Is_Synchronous_Suspension_Call): New routine.
1929 * switch-c.adb (Scan_Front_End_Switches): Switch -gnatJ now sets switch
1932 2018-05-23 Javier Miranda <miranda@adacore.com>
1934 * exp_disp.adb (Make_DT): Restrict the initialization of
1935 External_Tag and Expanded_Name to an empty string to the case where
1936 both pragmas apply (i.e. No_Tagged_Streams and Discard_Names), since
1937 restricted runtimes are compiled with pragma Discard_Names.
1938 * doc/gnat_rm/implementation_defined_pragmas.rst,
1939 doc/gnat_rm/implementation_defined_characteristics.rst: Add
1941 * gnat_rm.texi: Regenerate.
1943 2018-05-23 Maroua Maalej <maalej@adacore.com>
1945 * sem_spark.adb: Fix of some permission rules of pointers in SPARK.
1947 2018-05-23 Ed Schonberg <schonberg@adacore.com>
1949 * sem_ch5.adb (Preanalyze_Range): The pre-analysis of the domain of
1950 iteration of an Ada2012 loop is performed to determine the type of the
1951 domain, but full analysis is performed once the loop is rewritten as a
1952 while-loop during expansion. The pre-analysis suppresses expansion; it
1953 must also suppress the generation of freeze nodes, which may otherwise
1954 appear in the wrong scope before rewritting.
1956 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
1958 * sem_elab.adb: Update the section on suppressing elaboration warnings.
1960 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
1962 * einfo.adb (Is_Elaboration_Checks_OK_Id): Use predicate
1963 Is_Elaboration_Target.
1964 (Is_Elaboration_Target): New routine.
1965 (Is_Elaboration_Warnings_OK_Id): Use predicate Is_Elaboration_Target.
1966 (Set_Is_Elaboration_Checks_OK_Id): Use predicate Is_Elaboration_Target.
1967 (Set_Is_Elaboration_Warnings_OK_Id): Use predicate
1968 Is_Elaboration_Target.
1969 * einfo.ads: Add new synthesized attribute Is_Elaboration_Target along
1970 with occurrences in nodes.
1971 (Is_Elaboration_Target): New routine.
1972 * sem_prag.adb (Analyze_Pragma): Suppress elaboration warnings when an
1973 elaboration target is subject to pragma Warnings (Off, ...).
1975 2018-05-23 Eric Botcazou <ebotcazou@adacore.com>
1977 * repinfo.adb (List_Type_Info): Remove obsolete stuff.
1979 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
1981 * einfo.adb: Flag304 is now Is_Elaboration_Warnings_OK_Id.
1982 (Is_Elaboration_Warnings_OK_Id): New routine.
1983 (Set_Is_Elaboration_Warnings_OK_Id): New routine.
1984 (Write_Entity_Flags): Output Flag304.
1985 * einfo.ads: Add new attribute Is_Elaboration_Warnings_OK_Id along with
1986 occurrences in entities.
1987 (Is_Elaboration_Warnings_OK_Id): New routine along with pragma Inline.
1988 (Set_Is_Elaboration_Warnings_OK_Id): New routine along with pragma
1990 * sem_attr.adb (Analyze_Access_Attribute): Capture the state of
1991 elaboration warnings.
1992 * sem_ch3.adb (Analyze_Object_Declaration): Capture the state of
1993 elaboration warnings.
1994 * sem_ch6.adb (Analyze_Abstract_Subprogram_Declaration): Capture the
1995 state of elaboration warnings.
1996 (Analyze_Subprogram_Body_Helper): Capture the state of elaboration
1998 (Analyze_Subprogram_Declaration): Capture the state of elaboration
2000 * sem_ch9.adb (Analyze_Entry_Declaration): Capture the state of
2001 elaboration warnings.
2002 (Analyze_Single_Task_Declaration): Capture the state of elaboration
2004 (Analyze_Task_Type_Declaration): Capture the state of elaboration
2006 * sem_ch12.adb (Analyze_Generic_Package_Declaration): Capture the state
2007 of elaboration warnings.
2008 (Analyze_Generic_Subprogram_Declaration): Capture the state of
2009 elaboration warnings.
2010 * sem_elab.adb: Add a section on suppressing elaboration warnings.
2011 Type Processing_Attributes includes component Suppress_Warnings
2012 intended to suppress any elaboration warnings along a path in the
2013 graph. Update Initial_State to include a value for this component.
2014 Types Target_Attributes and Task_Attriutes include component
2015 Elab_Warnings_OK to indicate whether the target or task has elaboration
2016 warnings enabled. component Elab_Warnings_OK.
2017 (Build_Access_Marker): Propagate attribute
2018 Is_Elaboration_Warnings_OK_Node from the attribute to the generated
2020 (Extract_Instantiation_Attributes): Set the value for Elab_Warnings_OK.
2021 (Extract_Target_Attributes): Set the value for Elab_Warnings_OK.
2022 (Extract_Task_Attributes): Set the value for Elab_Warnings_OK.
2023 (Process_Conditional_ABE_Access): Suppress futher elaboration warnings
2024 when already in this mode or when the attribute or target have warnings
2026 (Process_Conditional_ABE_Activation_Impl): Do not emit any diagnostics
2027 if warnings are suppressed.
2028 (Process_Conditional_ABE_Call): Suppress further elaboration warnings
2029 when already in this mode, or the target or call have warnings
2031 (Process_Conditional_ABE_Call_Ada): Do not emit any diagnostics if
2032 warnings are suppressed.
2033 (Process_Conditional_ABE_Call_SPARK): Do not emit any diagnostics if
2034 warnings are suppressed.
2035 (Process_Conditional_ABE_Instantiation): Suppress further elaboration
2036 warnings when already in this mode or when the instantiation has
2037 warnings suppressed.
2038 (Process_Conditional_ABE_Instantiation_Ada): Do not emit any
2039 diagnostics if warnings are suppressed.
2040 (Process_Conditional_ABE_Variable_Assignment_Ada): Use the more
2041 specific Is_Elaboration_Warnings_OK_Id rather than Warnings_Off.
2042 (Process_Conditional_ABE_Variable_Assignment_SPARK): Use the more
2043 specific Is_Elaboration_Warnings_OK_Id rather than Warnings_Off.
2044 (Process_Task_Object): Suppress further elaboration warnings when
2045 already in this mode, or when the object, activation call, or task type
2046 have warnings suppressed. Update the processing state to indicate that
2047 the path goes through a task body.
2048 * sinfo.adb (Is_Elaboration_Warnings_OK_Node): Accept attribute
2050 (Set_Is_Elaboration_Warnings_OK_Node): Accept attribute references.
2051 * sinfo.ads: Attribute Is_Elaboration_Warnings_OK_Node now applies to
2052 attribute references.
2054 2018-05-23 Piotr Trojanek <trojanek@adacore.com>
2056 * einfo.ads: Minor reformatting.
2058 2018-05-23 Ed Schonberg <schonberg@adacore.com>
2060 * sem_ch3.adb (Analyze_Object_Declaration): If expression is an
2061 anonymous_access_to_ subprogram formal, apply a conversion to force an
2062 accsssibility check that will fail statically, enforcing 3.10.2 (13).
2064 2018-05-23 Daniel Mercier <mercier@adacore.com>
2066 * gnat1drv.adb: Turn off length expansion in CodePeer mode.
2068 2018-05-23 Bob Duff <duff@adacore.com>
2070 * freeze.adb: (Check_Address_Clause): Deal with build-in-place
2071 aggregates in addition to build-in-place calls.
2073 2018-05-23 Bob Duff <duff@adacore.com>
2075 * einfo.ads: Minor reformatting.
2076 * sem_ch3.adb: Likewise.
2077 * sinfo.ads: Likewise.
2079 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
2081 * exp_ch3.adb (Default_Initialize_Object): Do not optimize scalar array
2082 initialization when the component type has predicates.
2083 * exp_ch4.adb (Expand_N_Allocator): Do not optimize scalar array
2084 allocation when the component type has predicates.
2086 2018-05-23 Hristian Kirtchev <kirtchev@adacore.com>
2088 * einfo.adb, exp_disp.adb, sem_ch3.adb, sem_ch6.adb, sem_prag.adb:
2091 2018-05-22 Justin Squirek <squirek@adacore.com>
2093 * sem_ch6.adb (Analyze_Expression_Function): Propagate flags from the
2094 original function spec into the generated function spec due to
2095 expansion of expression functions during analysis.
2096 (Analyze_Subprogram_Body_Helper): Modify check on formal parameter
2097 references from the body to the subprogram spec in the case of
2098 expression functions because of inconsistances related to having a
2100 * libgnarl/s-osinte__android.ads: Flag parameters as unused.
2101 * libgnarl/s-osinte__lynxos178e.ads: Likewise.
2102 * libgnarl/s-osinte__qnx.adb: Likewise.
2103 * libgnarl/s-osinte__qnx.ads: Likewise.
2105 2018-05-22 Doug Rupp <rupp@adacore.com>
2107 * init.c (HAVE_ADJUST_CONTEXT_FOR_RAISE): Don't define on VxWorks7 for
2110 2018-05-22 Olivier Hainque <hainque@adacore.com>
2112 * libgnat/a-except.adb (Exception_Propagation.Propagate_Exception):
2113 Expect an Exception_Occurence object, not an Access.
2114 (Complete_And_Propagate_Occurrence): Adjust accordingly.
2115 (Raise_From_Signal_Handler): Likewise.
2116 (Reraise_Occurrence_No_Defer): If we have a Machine_Occurrence
2117 available in the provided occurrence object, just re-propagate the
2118 latter as a bare "raise;" would do.
2119 * libgnat/a-exexpr.adb (Propagate_Exception): Adjust to spec change.
2120 * libgnat/a-exstat.adb (String_To_EO): Initialize X.Machine_Occurrence
2121 to null, to mark that the occurrence we're crafting from the stream
2122 contents is not being propagated (yet).
2124 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
2126 * exp_aggr.adb (Initialize_Ctrl_Record_Component): Insert the generated
2127 code for a transient component in line with the rest of the
2128 initialization code, rather than before the aggregate. This ensures
2129 that the component has proper visibility of the discriminants.
2131 2018-05-22 Jerome Lambourg <lambourg@adacore.com>
2133 * adaint.c: Reorganize QNX-specific macros, use syspage to retreive the
2136 2018-05-22 Jerome Lambourg <lambourg@adacore.com>
2138 * sigtramp-qnx.c: Properly restore link register in signal trampoline.
2140 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
2142 * exp_aggr.adb (Aggr_Assignment_OK_For_Backend): Strip away any
2143 conversions before extracting the value of the expression.
2144 * exp_ch3.adb (Default_Initialize_Object): Optimize the default
2145 initialization of an array of scalars.
2146 (Get_Simple_Init_Val): Add processing for array types. Remove the
2147 processing of strings because this case is already handled by the array
2149 (Needs_Simple_Initialization): Moved to Sem_Util.
2150 (Simple_Init_Array_Type): New routine.
2151 (Simple_Init_Initialize_Scalars_Type): Reimplemented to use the new
2152 facilities from Sem_Util.
2153 (Simple_Initialization_OK): New routine.
2154 * exp_ch3.ads (Needs_Simple_Initialization): Moved to Sem_Util.
2155 * exp_ch4.adb (Expand_N_Allocator): Optimize the default allocation of
2156 an array of scalars.
2157 * sem_prag.adb (Analyze_Float_Value): New routine.
2158 (Analyze_Integer_Value): New routine.
2159 (Analyze_Pragma): Reimplement the analysis of pragma Initialize_Scalars
2160 to handled the extended form of the pragma.
2161 (Analyze_Type_Value_Pair): New routine.
2162 * sem_util.adb: Add invalid value-related data structures.
2163 (Examine_Array_Bounds): New routine.
2164 (Has_Static_Array_Bounds): Reimplemented.
2165 (Has_Static_Non_Empty_Array_Bounds): New routine.
2166 (Invalid_Scalar_Value): New routine.
2167 (Needs_Simple_Initialization): Moved from Exp_Ch3.
2168 (Set_Invalid_Scalar_Value): New routines.
2169 * sem_util.ads (Has_Static_Non_Empty_Array_Bounds): New routine.
2170 (Invalid_Scalar_Value): New routine.
2171 (Needs_Simple_Initialization): Moved from Exp_Ch3.
2172 (Set_Invalid_Scalar_Value): New routines.
2173 * snames.ads-tmpl: Add names for the salar type families used by pragma
2176 2018-05-22 Javier Miranda <miranda@adacore.com>
2178 * exp_disp.adb (Make_DT): Initialize the External_Tag with an empty
2179 string when pragma No_Tagged_Streams is applicable to the tagged type,
2180 and initialize the Expanded_Name with an empty string when pragma
2181 Discard_Names is applicable to the tagged type.
2183 2018-05-22 Ed Schonberg <schonberg@adacore.com>
2185 * sem_ch6.adb (Check_Conformance): Add RM reference for rule that a
2186 formal subprogram is never subtype conformqnt, and thus cannot be the
2187 prefix of 'Access. Reject as well the attribute when applied to a
2188 renaming of a formal subprogram.
2190 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
2192 * exp_ch3.adb (Build_Array_Init_Proc): Update the call to
2193 Needs_Simple_Initialization.
2194 (Build_Init_Statements): Update the call to Get_Simple_Init_Val.
2195 (Check_Subtype_Bounds): Renamed to Extract_Subtype_Bounds. Update the
2196 profile and comment on usage.
2197 (Default_Initialize_Object): Do not use New_Copy_Tree to set the proper
2198 Sloc of a value obtained from aspect Default_Value because this could
2199 potentially replicate large trees. The proper Sloc is now set in
2200 Get_Simple_Init_Val.
2201 (Get_Simple_Init_Val): Reorganized by breaking the various cases into
2202 separate routines. Eliminate the use of global variables.
2203 (Init_Component): Update the call to Get_Simple_Init_Val.
2204 (Needs_Simple_Initialization): Update the parameter profile and all
2206 (Simple_Init_Defaulted_Type): Copy the value of aspect Default_Value
2207 and set the proper Sloc.
2208 * exp_ch3.ads (Get_Simple_Init_Val): Update the parameter profile and
2210 (Needs_Simple_Initialization): Update the parameter profile.
2212 2018-05-22 Patrick Bernardi <bernardi@adacore.com>
2214 * sem_ch3.adb (Build_Discriminant_Constraints): Raise an error if the
2215 user tries to use a subtype indication as a discriminant constraint.
2217 2018-05-22 Ed Schonberg <schonberg@adacore.com>
2219 * exp_ch4.ads, exp_ch4.adb, exp_util.adb, expander.adb: Remove mention
2220 of N_Reduction_Expression and N_Reduction_Expression_Parameter.
2221 * par-ch4.adb: Remove parsing routines for reduction expressions.
2222 * sem.adb, sinfo.ads, sinfo.adb, sem_ch4.ads, sem_ch4.adb, sem_res.adb,
2223 sem_spark.adb, sprint.adb: Remove analysis routines for reduction
2226 2018-05-22 Arnaud Charlet <charlet@adacore.com>
2228 * sem_ch8.adb (Check_Frozen_Renaming): Do not emit error in
2229 Relaxed_RM_Semantics mode.
2231 2018-05-22 Arnaud Charlet <charlet@adacore.com>
2233 * comperr.adb (Delete_SCIL_Files): Take into account
2234 N_Generic_Package_Renaming_Declaration.
2236 2018-05-22 Ed Schonberg <schonberg@adacore.com>
2238 * sem_ch3.adb (Search_Derivation_Levels): Whenever a parent type is
2239 private, use the full view if available, because it may include renamed
2240 discriminants whose values are stored in the corresponding
2243 2018-05-22 Ed Schonberg <schonberg@adacore.com>
2245 * einfo.ads, einfo.adb: New attribute Hidden_In_Formal_Instance,
2246 defined on packages that are actuals for formal packages, in order to
2247 set/reset the visibility of the formals of a formal package with given
2248 actuals, when there are subsequent uses of those formals in the
2249 enclosing generic, as required by RN 12.7 (10).
2250 * atree.ads, atree.adb: Add operations for Elist30.
2251 * atree.h: Add Elist30.
2252 * sem_ch12.adb (Analyze_Formal_Package_Instantiation): Collect formals
2253 that are not defaulted and are thus not visible within the current
2255 (Check_Formal_Packages): Reset visibility of formals of a formal
2256 package that are not defaulted, on exit from current instance.
2258 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
2260 * sem_prag.adb (Analyze_Input_Output): Emit an error when a non-null,
2261 non-'Result output appears in the output list of a function.
2263 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
2265 * exp_attr.adb (Build_Array_VS_Func): Reimplemented.
2266 (Build_Record_VS_Func): Reimplemented.
2267 (Expand_N_Attribute): Reimplement the handling of attribute
2269 * sem_attr.adb (Analyze_Attribute): Reimplement the handling of
2270 attribute 'Valid_Scalars.
2271 * sem_util.adb (Scalar_Part_Present): Reimplemented.
2272 (Validated_View): New routine.
2273 * sem_util.ads (Scalar_Part_Present): Update the parameter profile and
2275 (Validated_View): New routine.
2276 * doc/gnat_rm/implementation_defined_attributes.rst: Update the
2277 documentation of attribute 'Valid_Scalars.
2278 * gnat_rm.texi: Regenerate.
2280 2018-05-22 Bob Duff <duff@adacore.com>
2282 * binde.adb: (Choose): Ignore a pragma Elaborate_Body that appears in
2283 the spec of a SAL_Interface package.
2285 2018-05-22 Ed Schonberg <schonberg@adacore.com>
2287 * freeze.adb (Freeze_Entity): When analyzing delayed aspects of an
2288 entity E within a generic unit, indicate that there are no remaining
2289 delayed aspects after invoking Analyze_Aspects_At_Freeze_Point. The
2290 entity E is not frozen yet but the aspects should not be reanalyzed at
2291 the freeze point, which may be outside of the generic and may not have
2292 the proper visibility.
2294 2018-05-22 Bob Duff <duff@adacore.com>
2296 * doc/gnat_ugn/gnat_utility_programs.rst: Add documentation for
2297 the new --split-line-before-record, --indent-named-statements and
2298 --no-align-modes gnatpp switches.
2300 2018-05-22 Ed Schonberg <schonberg@adacore.com>
2302 * sem_prag.adb (Process_Compile_Time_Warning_Or_Error): Handle properly
2303 a second argument that is a constant of a given string value.
2305 2018-05-22 Doug Rupp <rupp@adacore.com>
2307 * sigtramp-vxworks-target.inc: Align stack to 128bits on AArch64.
2309 2018-05-22 Jerome Lambourg <lambourg@adacore.com>
2311 * sigtramp-qnx.c: Fix stack alignment issue in the signal trampoline.
2313 2018-05-22 Ed Schonberg <schonberg@adacore.com>
2315 * freeze.adb (Freeze_Fixed_Point_Type): If the first subtype has
2316 delayed aspects, analyze them now, os that the representation of the
2317 type (size, bounds) can be computed and validated.
2319 2018-05-22 Olivier Hainque <hainque@adacore.com>
2321 * libgnat/s-dwalin.adb (Enable_Cache): Skip symbols outside of the
2322 executable code section boundaries.
2324 2018-05-22 Javier Miranda <miranda@adacore.com>
2326 * locales.c: New implementation for the Ada.Locales package.
2327 * libgnat/a-locale.ads: Remove comment indicating that this is not
2329 * doc/gnat_rm/standard_library_routines.rst: Remove comment indicating
2330 that this is not implemented.
2331 * gnat_rm.texi: Regenerate.
2333 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
2335 * exp_ch5.adb, freeze.adb, pprint.adb, sem_ch4.adb, sem_res.adb: Minor
2338 2018-05-22 Justin Squirek <squirek@adacore.com>
2340 * sem_ch12.adb (In_Same_Declarative_Part): Moved to sem_util.
2341 (Freeze_Subprogram_Body, Install_Body): Modify calls to
2342 In_Same_Declarative_Part.
2343 * sem_prag.adb (Analyze_Pragma-Pragma_Pure_Function): Add check to
2344 verify pragma declaration is within the same declarative list with
2345 corresponding error message.
2346 * sem_util.adb, sem_util.ads (In_Same_Declarative_Part): Moved from
2347 sem_ch12.adb and generalized to be useful outside the scope of
2350 2018-05-22 Hristian Kirtchev <kirtchev@adacore.com>
2352 * sem_ch6.adb (Analyze_Subprogram_Declaration): Set the proper
2353 categorization of the unit after processing the aspects in case one of
2354 its aspects is converted into a categorization pragma.
2356 2018-05-21 Ed Schonberg <schonberg@adacore.com>
2358 * freeze.adb (Warn_Overlay): Do not emit a wawrning on an object
2359 declaration with an explicit address clause and a type with default
2360 initialization, if the declaration carries an aspect
2361 Suppress_Initialization.
2363 2018-05-21 Daniel Mercier <mercier@adacore.com>
2365 * pprint.adb: Use mixed case for attribute names.
2367 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
2369 * sem_ch6.adb (Analyze_Generic_Subprogram_Body): Rename the call to
2370 Analyze_Aspect_Specifications_On_Body_Or_Stub.
2371 (Analyze_Subprogram_Body_Helper): Rename the calls to
2372 Analyze_Aspect_Specifications_On_Body_Or_Stub.
2373 * sem_ch9.adb (Analyze_Entry_Body): Rename the call to
2374 Analyze_Aspect_Specifications_On_Body_Or_Stub.
2375 * sem_ch10.adb: Add with and use clause for Sem_Ch13.
2376 (Analyze_Package_Body_Stub): Add constant Id. Decorate the package stub
2377 prior to analyzing its aspects.
2378 (Analyze_Protected_Body_Stub): Add constant Id. Decorate the package
2379 stub prior to analyzing its aspects. Save and restore the configuration
2381 (Analyze_Task_Body_Stub): Add constant Id. Decorate the package stub
2382 prior to analyzing its aspects.
2383 * sem_ch13.adb (Analyze_Aspect_Specifications_On_Body_Or_Stub): Renamed
2384 to Analyze_Aspects_On_Subprogram_Body_Or_Stub.
2385 * sem_ch13.ads (Analyze_Aspect_Specifications_On_Body_Or_Stub): Renamed
2386 to Analyze_Aspects_On_Subprogram_Body_Or_Stub.
2387 * sem_prag.adb: Code reformatting.
2388 (Analyze_Refined_Depends_Global_Post): Consider task body stubs.
2390 2018-05-21 Jerome Lambourg <lambourg@adacore.com>
2392 * gcc-interface/Makefile.in: Add g-soliop__qnx.ads to the runtime build
2395 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
2397 * exp_cg.adb: Remove with and use clause for Exp_Disp.
2398 * exp_ch9.adb: Remove with and use clause for Exp_Disp.
2399 * exp_disp.adb (Is_Predefined_Dispatching_Operation): Moved to Sem_Util.
2400 (Is_Predefined_Interface_Primitive): Moved to Sem_Util.
2401 (Is_Predefined_Internal_Operation): Moved to Sem_Util.
2402 * exp_disp.ads (Is_Predefined_Dispatching_Operation): Moved to Sem_Util.
2403 (Is_Predefined_Interface_Primitive): Moved to Sem_Util.
2404 (Is_Predefined_Internal_Operation): Moved to Sem_Util.
2405 * exp_dist.adb: Remove with and use clause for Exp_Disp.
2406 * freeze.adb: Remove with and use clause for Exp_Disp.
2407 * sem_cat.adb: Remove with and use clause for Exp_Disp.
2408 * sem_ch6.adb: Remove with and use clause for Exp_Disp.
2409 * sem_ch12.adb: Remove with and use clause for Exp_Disp.
2410 * sem_elab.adb (Check_Overriding_Primitive): Do not process predefined
2412 * sem_util.adb: Remove with and use clause for Exp_Disp.
2413 (Is_Predefined_Dispatching_Operation): Moved from Exp_Disp.
2414 (Is_Predefined_Interface_Primitive): Moved from Exp_Disp.
2415 (Is_Predefined_Internal_Operation): Moved from Exp_Disp.
2416 * sem_util.ads (Is_Predefined_Dispatching_Operation): Moved from
2418 (Is_Predefined_Interface_Primitive): Moved from Exp_Disp.
2419 (Is_Predefined_Internal_Operation): Moved from Exp_Disp.
2421 2018-05-21 Ed Schonberg <schonberg@adacore.com>
2423 * sem_res.adb (Valid_Conversion): Improve error message on an illegal
2424 type conversion whose expression has a limited view of a type.
2426 2018-05-21 Ed Schonberg <schonberg@adacore.com>
2428 * exp_ch5.adb (Build_Formal_Container_Iteration): If source has
2429 explicit name for iterator loop, preserve that name in expanded
2430 construct, for possible use in exit statements.
2432 2018-05-21 Javier Miranda <miranda@adacore.com>
2434 * sem_ch4.adb (Analyze_Membership_Op): Avoid compiler crash when the
2435 spec of a unit has Ada 2012 membership tests with multiple choices and
2436 the unit body is not compiled under Ada 2012 mode.
2438 2018-05-21 Doug Rupp <rupp@adacore.com>
2440 * sigtramp-vxworks-target.inc: Set cfa_reg properly from sigcontext
2442 (CFI_COMMON_REGS): Restore LR jic probed from prologue.
2443 (REGNO_PC_OFFSET): Change to correct value for Aarch64.
2445 2018-05-21 Jose Ruiz <ruiz@adacore.com>
2447 * doc/gnat_ugn/gnat_utility_programs.rst, exp_attr.adb,
2448 libgnarl/s-tassta.adb: Minor typo fixes
2450 2018-05-21 Ed Schonberg <schonberg@adacore.com>
2452 * sem_ch4.adb (Analyze_One_Call): Recognize complex cases where an
2453 indexed call originally in prefix forn is itself the prefix of a
2456 2018-05-21 Piotr Trojanek <trojanek@adacore.com>
2458 * sem_eval.adb (Is_Null_Range): Clarify access to the full view of a
2460 (Not_Null_Range): Same as above.
2462 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
2464 * exp_ch3.adb: Minor reformatting.
2465 * exp_ch6.adb: Likewise.
2466 * freeze.adb: Likewise.
2467 * inline.adb: Likewise.
2468 * sem_util.adb: Likewise.
2470 2018-05-21 Yannick Moy <moy@adacore.com>
2472 * inline.adb (Expand_Inlined_Call.Process_Formals): Use a type
2473 conversion instead of an unchecked type conversion when inlining a
2474 return statement, unless type qualification is required (for character
2475 and string literal) or no check can result from the conversion (for
2477 * opt.ads: Update comment.
2479 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
2481 * sem_ch6.adb (Analyze_Subprogram_Body_Helper): Install the elaboration
2482 model of the compilation unit spec, if any.
2483 * sem_ch7.adb (Analyze_Package_Body_Helper): Install the elaboration
2484 model of the compilation unit spec, if any.
2485 * sem_ch10.adb (Analyze_Subunit): Install the elaboration model of the
2486 parent compilation unit spec, if any.
2487 * sem_elab.adb (Check_Elaboration_Scenarios): Restore the elaboration
2488 model of the main unit.
2489 (Is_Same_Unit): The routine now uses Unit_Entity.
2490 (Is_Subunit): Removed.
2491 (Normalize_Unit): Removed.
2492 (Unit_Entity): New routine.
2493 * sem_prag.adb (Analyze_Pragma): Reimplement the handling of pragma
2494 Elaboration_Checks. The analysis now ensures that the pragma appears at
2495 the configuration level, and on the initial declaration of a unit.
2496 Other placements are either flagged as illegal, or ignored.
2497 (Check_Duplicate_Elaboration_Checks_Pragma): New routine.
2498 (Ignore_Elaboration_Checks_Pragma): New routine.
2499 * sem_util.adb (Install_Elaboration_Model): New routine.
2500 * sem_util.ads (Install_Elaboration_Model): New routine.
2501 * doc/gnat_rm/implementation_defined_pragmas.rst: Update the
2502 documentation of pragma Elaboration_Checks.
2503 * gnat_rm.texi: Regenerate.
2505 2018-05-21 Olivier Hainque <hainque@adacore.com>
2507 * libgnat/s-trasym__dwarf.adb (Executable_Name): Return argv[0] instead
2508 of empty string when argv[0] couldn't be found on PATH.
2509 (Enable_Cache): Raise Program_Error instead of attempting a null
2510 pointer dereference when the Exec_Module initialization failed.
2512 2018-05-21 Piotr Trojanek <trojanek@adacore.com>
2514 * libgnarl/a-reatim.ads (Clock_Time): Remove External aspect.
2515 * libgnarl/a-taside.ads (Tasking_State): Likewise.
2516 * libgnat/a-calend.ads (Clock_Time): Likewise.
2518 2018-05-21 Yannick Moy <moy@adacore.com>
2520 * sem_ch6.adb (Analyze_Procedure_Call): Refine test to recognize prefix
2521 call notation in inlined call in GNATprove mode.
2523 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
2525 * einfo.adb (Is_External_State): An abstract state is also external
2526 when it is declared with option "synchronous".
2527 * einfo.ads: Update the documentation of synthesized attribute
2529 * sem_util.adb (Find_Simple_Properties): New routine.
2530 (Is_Enabled_External_Property): New routine.
2531 (State_Has_Enabled_Property): Reimplemented. The two flavors of option
2532 External have precedence over option Synchronous when determining
2533 whether a property is in effect.
2535 2018-05-21 Yannick Moy <moy@adacore.com>
2537 * sem_eval.adb (Static_Length): Take into account case of variable of
2538 subtype string literal.
2540 2018-05-21 Olivier Hainque <hainque@adacore.com>
2542 * libgnat/s-objrea.ads (Get_Memory_Bounds): Rename as Get_Xcode_Bounds.
2543 (Object_Section): Rename Flag_Alloc component as Flag_Xcode.
2544 * libgnat/s-objrea.adb (Get_Xcode_Bounds): Adjust to new subprogram and
2546 (Get_Section, ELF case): Set Flag_Xcode from SHF_EXECINSTR.
2547 * libgnat/s-dwalin.adb (Open): Adjust to the Get_Memory_Bounds name
2550 2018-05-21 Olivier Hainque <hainque@adacore.com>
2552 * libgnat/s-dwalin.ads (Dwarf_Context): Change type of Load_Address to
2553 Address, and type of Low, High to Storage_Offset.
2554 (Low): Rename as Low_Address and convey that the return value is a
2555 runtime reference accounting for a load address.
2556 * libgnat/s-dwalin.adb (Read_Aranges_Entry): Adjust to the
2557 address/offset type changes.
2558 (Aranges_Lookup): Likewise.
2559 (Symbolic_Address): Likewise.
2560 (Symbolic_Traceback): Likewise.
2561 (Dump_Cache): Likewise.
2562 (Is_Inside): Likewise.
2564 (Set_Load_Address): Likewise.
2565 (Low_Address): Likewise, and account for C.Load_Address.
2566 * libgnat/s-trasym__dwarf.adb (Lt): Use Low_Address instead of Low.
2567 (Multi_Module_Symbolic_Traceback): Compare address in traceback
2568 with module Low_Address instead of Low.
2570 2018-05-21 Olivier Hainque <hainque@adacore.com>
2572 * libgnat/s-dwalin.ads (Dwarf_Context): Rename Load_Slide as
2574 * libgnat/s-dwalin.adb (Is_Inside): Adjust accordingly.
2575 (Set_Load_Address): Likewise.
2576 (Symbolic_Traceback): Likewise.
2578 2018-05-21 Olivier Hainque <hainque@adacore.com>
2580 * libgnat/s-trasym__dwarf.adb (Add_Module_To_Cache): Expect a
2581 Load_Address argument and pass it down to Init_Module.
2582 * libgnat/s-tsmona__linux.adb (Build_Cache_For_All_Modules): Pass
2583 lm.l_addr as the Load_Address to Add_Module_To_Cache.
2585 2018-05-21 Piotr Trojanek <trojanek@adacore.com>
2587 * einfo.adb (Has_Discriminants): Stronger assertion.
2588 (Set_Has_Discriminants): Stronger assertion.
2589 * sem_ch13.adb (Push_Scope_And_Install_Discriminants): Adapt to respect
2590 the stronger assertion on Has_Discriminant.
2591 (Uninstall_Discriminants_And_Pop_Scope): Same as above.
2592 * sem_util.adb (New_Copy_Tree): Same as above.
2593 * sem_ch7.adb (Generate_Parent_References): Prevent calls to
2594 Has_Discriminant on non-type entities that might happen when the
2595 compiled code has errors.
2596 * sem_ch3.adb (Derived_Type_Declaration): Only call
2597 Set_Has_Discriminant on type entities.
2599 2018-05-21 Arnaud Charlet <charlet@adacore.com>
2601 * exp_unst.adb (Unnest_Subprogram): Unnest all subprograms relevant for
2604 2018-05-21 Piotr Trojanek <trojanek@adacore.com>
2606 * lib.ads: Fix typo in enumeration in comment.
2608 2018-05-21 Ed Schonberg <schonberg@adacore.com>
2610 * sem_attr.adb (Analyze_Attribute, case Scalar_Storage_Order): The
2611 attribute reference is legal within a generic unit when the prefix is a
2612 formal private type.
2614 2018-05-21 Hristian Kirtchev <kirtchev@adacore.com>
2616 * exp_ch7.adb (Establish_Transient_Scope): Code cleanup. Do not
2617 delegate the secondary stack management when there is no suitable
2618 transient context, and the transient scope was intended to manage the
2619 secondary stack because this causes premature reclamation. Change the
2620 transient scope creation logic by special casing assignment statements
2621 of controlled components for type initialization procedures.
2622 (Find_Node_To_Be_Wrapped): Renamed to Find_Transient_Context. Update
2623 the comment on usage.
2624 (Find_Transient_Context): Change the initinte loop into a while loop.
2625 Iterations schemes and iterator specifications are not valid transient
2626 contexts because they rely on special processing. Assignment statements
2627 are now treated as a normal transient context, special cases are
2628 handled by the caller. Add special processing for pragma Check.
2629 (Is_OK_Construct): Removed. Its functionality has been merged in
2630 routine Find_Transient_Context.
2631 * sem_ch5.adb (Check_Call): Reimplemented. Add code to properly
2632 retrieve the subprogram being invoked. Use a more accurate predicate
2633 (Requires_Transient_Scope) to determine that the function will emply
2634 the secondary stack.
2636 2018-05-21 Piotr Trojanek <trojanek@adacore.com>
2638 * ada_get_targ.adb: Fix subprogram body headers.
2639 * adabkend.adb: Likewise.
2640 * checks.adb: Likewise.
2641 * exp_ch3.adb: Likewise.
2642 * exp_ch5.adb: Likewise.
2643 * exp_ch9.adb: Likewise.
2644 * exp_dist.adb: Likewise.
2645 * exp_tss.adb: Likewise.
2646 * inline.adb: Likewise.
2647 * lib-writ.adb: Likewise.
2648 * lib-xref-spark_specific.adb: Likewise.
2649 * libgnarl/s-osinte__darwin.adb: Likewise.
2650 * libgnarl/s-stusta.adb: Likewise.
2651 * libgnarl/s-taprop__solaris.adb: Likewise.
2652 * libgnarl/s-tposen.adb: Likewise.
2653 * libgnarl/s-vxwext__kernel-smp.adb: Likewise.
2654 * libgnarl/s-vxwext__kernel.adb: Likewise.
2655 * libgnat/a-btgbso.adb: Likewise.
2656 * libgnat/a-cfdlli.adb: Likewise.
2657 * libgnat/a-cfhama.adb: Likewise.
2658 * libgnat/a-cfinve.adb: Likewise.
2659 * libgnat/a-cimutr.adb: Likewise.
2660 * libgnat/a-coboho.adb: Likewise.
2661 * libgnat/a-cofove.adb: Likewise.
2662 * libgnat/a-cofuve.adb: Likewise.
2663 * libgnat/a-comutr.adb: Likewise.
2664 * libgnat/a-exexda.adb: Likewise.
2665 * libgnat/a-tags.adb: Likewise.
2666 * libgnat/a-tideau.adb: Likewise.
2667 * libgnat/a-wtdeau.adb: Likewise.
2668 * libgnat/a-ztdeau.adb: Likewise.
2669 * libgnat/g-alleve.adb: Likewise.
2670 * libgnat/s-excdeb.adb: Likewise.
2671 * libgnat/s-parint.adb: Likewise.
2672 * libgnat/s-shasto.adb: Likewise.
2673 * libgnat/s-traceb__hpux.adb: Likewise.
2674 * prepcomp.adb: Likewise.
2675 * sem_ch4.adb: Likewise.
2676 * sem_ch6.adb: Likewise.
2677 * sem_dist.adb: Likewise.
2678 * sem_prag.adb: Likewise.
2679 * sem_util.adb: Likewise.
2680 * sinfo.adb: Likewise.
2681 * switch.adb: Likewise.
2683 2018-05-04 John Marino <gnugcc@marino.st>
2686 * link.c (BSD platforms): Add missing backslash.
2688 2018-04-27 Eric Botcazou <ebotcazou@adacore.com>
2691 * init.c (__gnat_handle_vms_condition): Add missing parentheses.
2693 2018-04-25 Eric Botcazou <ebotcazou@adacore.com>
2696 * gnat_ugn.texi: Regenerate.
2698 2018-03-23 Eric Botcazou <ebotcazou@adacore.com>
2701 * gnatlink.adb (Gnatlink): Remove handling of -b switch.
2702 * doc/gnat_ugn/building_executable_programs_with_gnat.rst (gnatlink):
2703 Remove documentation of -b switch.
2705 2018-03-23 Eric Botcazou <ebotcazou@adacore.com>
2708 * gnatlink.adb (Process_Args): Drop existing link switches if multiple
2709 switches are passed for --LINK.
2711 2018-03-12 Eric Botcazou <ebotcazou@adacore.com>
2714 * gcc-interface/misc.c (gnat_post_options): Disable string overflow
2717 2018-03-10 Eric Botcazou <ebotcazou@adacore.com>
2719 * gcc-interface/trans.c (node_has_volatile_full_access) <N_Identifier>:
2720 Consider only entities for objects.
2722 2018-03-07 Sebastian Huber <sebastian.huber@embedded-brains.de>
2724 * gcc-interface/Makefile.in (OSCONS_CPP): Remove redundant
2726 (OSCONS_EXTRACT): Add $(GNATLIBCFLAGS_FOR_C).
2728 2018-03-06 Eric Botcazou <ebotcazou@adacore.com>
2730 * gcc-interface/trans.c (convert_with_check): Fix typo in the condition
2731 guarding the overflow check emitted for the upper bound of a floating-
2734 2018-03-06 Eric Botcazou <ebotcazou@adacore.com>
2736 * gcc-interface/utils.c (def_builtin_1): Bail out on error_mark_node.
2738 2018-02-28 Eric Botcazou <ebotcazou@adacore.com>
2740 * libgnat/i-cexten.ads (Float_128): New type.
2742 2018-02-02 Eric Botcazou <ebotcazou@adacore.com>
2744 * gcc-interface/decl.c (array_type_has_nonaliased_component): Return
2745 false if the component type is a pointer.
2747 2018-01-11 Gary Dismukes <dismukes@adacore.com>
2749 * exp_ch3.adb (Default_Initialize_Object): Call New_Copy_Tree on the
2750 result of Get_Simple_Init_Value and pass the source location of the
2751 object declaration's object_definition.
2753 2018-01-11 Ed Schonberg <schonberg@adacore.com>
2755 * exp_ch6.adb (Make_Build_In_Place_Call_In_Object_Declaration): Handle
2756 properly object declarations with initializations that are
2757 build-in-place function calls, when there is an address specification,
2758 either as an aspect specification or an explicit attribute
2759 specification clause, for the initialized object.
2760 * freeze.adb (Check_Address_Clause): Do not remove side-effects from
2761 initial expressions in the case of a build-in-place call.
2763 2018-01-11 Piotr Trojanek <trojanek@adacore.com>
2765 * sem_eval.adb (Is_Null_Range): Retrieve the full view when called on a
2766 private (sub)type; refactor to avoid early return statement.
2767 (Not_Null_Range): Same as above.
2769 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2771 * freeze.adb (Freeze_Entity): Ensure that a Ghost type is not
2772 concurrent, nor effectively volatile.
2773 * ghost.adb (Check_Ghost_Type): New routine.
2774 * ghost.ads (Check_Ghost_Type): New routine.
2775 * sem_util.adb (Is_Declaration): Reimplemented. The routine can now
2776 consider specific subsets of declarations.
2777 (Is_Declaration_Other_Than_Renaming): Removed. Its functionality is
2778 replicated by Is_Declaration.
2779 * sem_util.ads (Is_Declaration): New parameter profile. Update the
2781 (Is_Declaration_Other_Than_Renaming): Removed.
2783 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2785 * sem_ch5.adb (Analyze_Assignment): Assignments to variables that act
2786 as Part_Of consituents of single protected types are illegal when they
2787 take place inside a protected function.
2788 (Diagnose_Non_Variable_Lhs): Use Within_Function to check for an
2790 (Is_Protected_Part_Of_Constituent): New routine.
2791 (Within_Function): New routine.
2793 2018-01-11 Arnaud Charlet <charlet@adacore.com>
2795 Bump copyright notices to 2018.
2797 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2799 * binde.adb, par-ch6.adb, par-ch9.adb, sem_ch12.adb, sem_ch13.adb:
2802 2018-01-11 Justin Squirek <squirek@adacore.com>
2804 * par-ch6.adb (Scan_Body_Or_Expression_Function): Add additional check
2805 to make sure a given expression function is properly parenthesized.
2807 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2809 * sem_ch6.adb (Analyze_Subprogram_Body_Helper): Check the
2810 categorization of a subprogram body which does not complete a previous
2813 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2815 * sem_ch10.adb (Check_Private_Child_Unit): Ensure that the enclosing
2816 scope of package Ada is Standard.
2818 2018-01-11 Ed Schonberg <schonberg@adacore.com>
2820 * sem_ch13.adb (Replace_Type_Ref): Handle properly reference to a
2821 subcomponent of the current entity when building the body for a dynamic
2822 predicate function for a record with composite subcomponents.
2824 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2826 * exp_aggr.adb (Convert_Aggr_In_Object_Decl): Update the call to
2827 Establish_Transient_Scope.
2828 (Convert_To_Assignments): Update the call to Establish_Transient_Scope.
2829 (Expand_Array_Aggregate): Update the call to Establish_Transient_Scope.
2830 * exp_ch6.adb (Expand_Call_Helper): Update the call to
2831 Establish_Transient_Scope.
2832 (Make_Build_In_Place_Call_In_Object_Declaration): Update the call to
2833 Establish_Transient_Scope.
2834 * exp_ch7.adb (Establish_Transient_Scope): Restructured. Delegate the
2835 management of the secondary stack to an enclosing scope if there is no
2836 suitable construct to wrap, and the transient scope was intended to
2837 manage the secondary stack.
2838 (Find_Node_To_Be_Wrapped): Restructured. A case_statement_alternative
2839 is a valid boundary for a transient expression which comes from the
2840 statements of the alternative, otherwise alternatives cannot be
2841 wrapped. Assignments of controlled objects which have controlled
2842 actions suppressed now stop the traversal as there is no point in
2843 looking for an enclosing construct. Add several N_xxx_Body choices to
2844 the termination conditions for completeness.
2845 * exp_ch7.ads (Establish_Transient_Scope): Update the parameter profile
2846 and the associated comment on usage.
2847 * exp_smem.adb (Add_Shared_Var_Lock_Procs): Update the call to
2848 Establish_Transient_Scope.
2849 (Add_Write_After): Update the call to Establish_Transient_Scope.
2850 * sem_res.adb (Check_Initialization_Call): Removed.
2851 (Resolve_Actuals): Account for additional cases where finalization
2852 actions are required by utilizing predicate Needs_Finalization rather
2854 (Resolve_Call): Type initialization procedures can now utilize
2855 transient scopes to manage the secondary stack, thus preventing leaks
2856 during initialization. Remove the previous kludgy algorithm which
2857 attempts to manage the secondary stack at the object creation site.
2859 2018-01-11 Jerome Lambourg <lambourg@adacore.com>
2861 * libgnat/g-soliop__qnx.ads: New.
2862 * adaint.c, adaint.h, cstreams.c, s-oscons-tmplt.c, sysdep.c: Update
2865 2018-01-11 Bob Duff <duff@adacore.com>
2867 * par-ch9.adb (P_Protected_Operation_Declaration_Opt): Give an error if
2868 a null procedure occurs in a protected definition.
2870 2018-01-11 Bob Duff <duff@adacore.com>
2872 * binderr.ads, namet.ads: Minor reformatting.
2874 2018-01-11 Bob Duff <duff@adacore.com>
2876 * doc/gnat_ugn/gnat_utility_programs.rst: Improve documentation of
2879 2018-01-11 Bob Duff <duff@adacore.com>
2881 * binde.adb (Force_Elab_Order): Give an error if there are duplicate
2884 2018-01-11 Ed Schonberg <schonberg@adacore.com>
2886 * sem_ch6.adb (Freeze_Expr_Types): If an access value is the
2887 controlling argument of a dispatching call. freeze the corresponding
2890 2018-01-11 Ben Brosgol <brosgol@adacore.com>
2892 * doc/Makefile: Add Sphinx option -W to treat warnings as errors.
2894 2018-01-11 Ben Brosgol <brosgol@adacore.com>
2896 * doc/gnat_rm/implementation_defined_aspects.rst: Minor type/wording
2898 * gnat_rm.texi: Regenerate.
2900 2018-01-11 Ed Schonberg <schonberg@adacore.com>
2902 * sem_ch12.adb (Check_Fixed_Point_Type): Do not apply check if the
2903 formsl type corresponding to the actual fixed point type is private,
2904 because in this case there can be no suspicious arithmetic operations
2905 in the generic unless they reference a formal subprogram. Clarify
2908 2018-01-11 Javier Miranda <miranda@adacore.com>
2910 * exp_util.adb (Remove_Side_Effects): No action done for functions
2911 returning class-wide types since it requires generating code using
2912 'reference and the CCG target has no secondary stack.
2913 * gnat1drv.adb: Disable building static dispatch tables when generating
2916 2018-01-11 Piotr Trojanek <trojanek@adacore.com>
2918 * libgnat/a-direio.ads, libgnat/a-sequio.ads, libgnat/a-ststio.ads,
2919 libgnat/a-textio.ads, libgnat/a-witeio.ads, libgnat/a-ztexio.ads
2920 (File_Type): Add Default_Initial_Condition aspect.
2922 2018-01-11 Pascal Obry <obry@adacore.com>
2924 * libgnat/s-os_lib.adb (Normalize_Pathname): New implementation.
2926 2018-01-11 Bob Duff <duff@adacore.com>
2928 * doc/gnat_ugn/gnat_utility_programs.rst: Rewrite gnatpp documentation
2929 to match what the Libadalang-based version does.
2930 * doc/gnat_ugn/about_this_guide.rst: Update reference.
2932 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2934 * sem_res.adb (Uses_SS): A controlled type requires the secondary stack
2935 if it contains at least one component declaration employing a function
2936 call returning on the secondary stack.
2938 2018-01-11 Yannick Moy <moy@adacore.com>
2940 * doc/gnat_rm/standard_and_implementation_defined_restrictions.rst:
2941 Update description of restriction SPARK_05 with SPARK 2014.
2942 * gnat_rm.texi: Regenerate.
2944 2018-01-11 Vasiliy Fofanov <fofanov@adacore.com>
2946 * doc/gnat_ugn/gnat_utility_programs.rst: Fix layout.
2948 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2950 * exp_aggr.adb, exp_ch9.adb, exp_util.adb, sem_aggr.adb, sem_ch3.adb,
2951 sem_res.adb, sem_util.adb: Minor reformatting.
2953 2018-01-11 Ed Schonberg <schonberg@adacore.com>
2955 * sem_prag.adb (Analyze_Pragma, case Predicate): Indicate that the type
2956 has a delayed aspect which must be processed at the point the type is
2957 frozen. This mimics what is done when the predicate is provided by a
2960 2018-01-11 Doug Rupp <rupp@adacore.com>
2962 * init.c (vxworks): Add macro checks for __aarch64__.
2964 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2966 * exp_util.adb (Add_Failure_Expression): New routine.
2967 (Make_Predicate_Check): Reimplement the handling of Predicate_Failure.
2968 * sem_util.adb (Is_Current_Instance): Code cleanup.
2970 2018-01-11 Patrick Bernardi <bernardi@adacore.com>
2972 * libgnat/s-parame*.adb, libgnat/s-parame*.ads: Remove unneeded
2973 Default_Sec_Stack_Size.
2974 * libgnat/s-secsta.adb (SS_Allocate): Handle the fixed secondary stack
2975 limit check so that the integer index does not overflow. Check the
2976 dynamic stack allocation does not cause the secondary stack pointer to
2978 (SS_Info): Align colons.
2979 (SS_Init): Cover the case when bootstraping with an old compiler that
2980 does not set Default_SS_Size.
2982 2018-01-11 Ed Schonberg <schonberg@adacore.com>
2984 * sem_ch3.adb (Add_Internal_Interface_Entities): When checking the
2985 legality of an inherited operation that may require overriding, ignore
2986 primitive_wrappers that correspond to explicit operations that override
2987 an interface primitive.
2988 * exp_util.adb (Build_Class_Wide_Expression, Replace_Entity): If the
2989 operation to which the class-wide expression applies is a protected op.
2990 with a primitive_wrapper, verify that the updated inherited expression
2991 does not contain an internal call to a protected function. This
2992 completes the implementation of AI12-0166.
2994 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
2996 * ali.adb: Document the remaining letters available for ALI lines.
2997 (Scan_ALI): A with clause is internal when it is encoded on a 'Z' line.
2998 * ali.ads: Update type With_Record. Field
2999 Implicit_With_From_Instantiation is no longer in use. Add field
3001 * csinfo.adb (CSinfo): Remove the setup for attribute
3002 Implicit_With_From_Instantiation.
3003 * lib-writ.adb (Collect_Withs): Correct the logic which marks a unit as
3004 either implicitly or explicitly withed.
3005 (Is_Implicit_With_Clause): New routine.
3006 (Write_ALI): Rename array Implicit_With to Has_Implicit_With to avoid
3007 confusion with the with clause attribute by the same name.
3008 (Write_With_Lines): Update the emission of 'W', 'Y', and 'Z' headers.
3009 * rtsfind.adb (Maybe_Add_With): Code cleanup.
3010 * sem_ch8.adb (Present_System_Aux): Code cleanup.
3011 * sem_ch10.adb (Expand_With_Clause): Mark the with clause as generated
3013 (Implicit_With_On_Parent): Mark the with clause as generated for a
3015 * sem_ch12.adb (Inherit_Context): With clauses inherited by an
3016 instantiation are no longer marked as Implicit_With_From_Instantiation
3017 because they are already marked as implicit.
3018 * sem_elab.adb (Ensure_Prior_Elaboration_Static): Remove the kludge
3019 which marks implicit with clauses as related to an instantiation.
3020 * sinfo.adb (Implicit_With_From_Instantiation): Removed.
3021 (Parent_With): New routine.
3022 (Set_Implicit_With_From_Instantiation): Removed.
3023 (Set_Parent_With): New routine.
3024 * sinfo.ads: Update the documentation of attribute Implicit_With.
3025 Remove attribute Implicit_With_From_Instantiation along with
3026 occurrences in nodes. Add attribute Parent_With along with occurrences
3028 (Implicit_With_From_Instantiation): Removed along with pragma Inline.
3029 (Parent_With): New routine along with pragma Inline.
3030 (Set_Implicit_With_From_Instantiation): Removed along with pragma Inline.
3031 (Set_Parent_With): New routine along with pragma Inline.
3033 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
3035 * sem_util.adb (Find_Enclosing_Scope): Return the unique defining
3036 entity when the enclosing construct is a body.
3038 2018-01-11 Patrick Bernardi <bernardi@adacore.com>
3040 * exp_ch9.adb (Expand_N_Task_Type_Declaration): Simplified
3041 Secondary_Stack_Size handling as a pragma is now generated for the
3042 corresponding aspect instead of an attribute. Pragma expression is
3043 relocated instead of evaluated. Discriminant of the corresponding
3044 record type is referenced rather than the type discriminant.
3045 (Create_Secondary_Stack_For_Task, Make_Task_Create_Call): Update
3046 Secondary_Stack_Size rep item checks to only look for the pragma rep.
3047 * sem_ch13.adb (Analyze_One_Aspect): Transform
3048 Aspect_Secondary_Stack_Size into a pragma instead of an attribute
3049 because the attribute does not have visibility on a task type's
3050 discriminants when the type's definition is expanded.
3051 (Analyze_Attribute_Definition_Clause): Remove handling of
3052 Attribute_Secondary_Stack_Size.
3053 * snames.adb-tmpl, snames.ads-tmpl: Remove
3054 Attribute_Secondary_Stack_Size, no longer used.
3056 2018-01-11 Justin Squirek <squirek@adacore.com>
3058 * sem_ch8.adb: Minor comment fix.
3060 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
3062 * exp_ch4.adb (Process_Action): Do not abandon the inspection of an
3063 individual action because the action may denote a complex expression,
3064 such as a case statement, which in turn may contain additional
3067 2018-01-11 Ed Schonberg <schonberg@adacore.com>
3069 * sem_aggr.adb (Resolve_Iterated_Component_Association): Perform
3070 analysis on a copy of the expression with a copy of the index variable,
3071 because full expansion will rewrite construct into a loop with the
3072 original loop variable.
3073 * exp_aggr.adb (Gen_Assign): Defer analysis and resolution if the
3074 expression is an iterated component association. Full analysis takes
3075 place when construct is rewritten as a loop.
3076 (In_Place_Assign_OK, Safe_Component): An iterated_component_association
3077 is not safe for in-place assignment.
3078 * sem_util.adb (Remove_Entity): Handle properly the case of an isolated
3079 entity with no homonym and no other entity in the scope.
3081 2018-01-11 Justin Squirek <squirek@adacore.com>
3083 * sem_prag.adb (Analyze_Pragma:Pragma_Loop_Variant): Modify error
3084 message to be printed on the pragma argument identifier.
3086 2018-01-11 Hristian Kirtchev <kirtchev@adacore.com>
3088 * exp_util.adb (Build_Invariant_Procedure_Declaration): Set the last
3089 entity of the generated invariant procedure in order to construct a
3090 proper entity chain.
3092 2018-01-11 Piotr Trojanek <trojanek@adacore.com>
3094 * sem_ch13.adb (Build_Predicate_Functions): Fix minor issues in
3097 2018-01-11 Arnaud Charlet <charlet@adacore.com>
3099 * einfo.ads, einfo.adb (Activation_Record_Component,
3100 Set_Activation_Record_Component, Set_Is_Uplevel_Referenced_Entity):
3101 Allow E_Discriminant.
3103 2018-01-10 Eric Botcazou <ebotcazou@adacore.com>
3105 * gcc-interface/decl.c (gnat_to_gnu_component_type): Apply the check
3106 for atomic access once the component size is taken into account and
3107 also do it if the component type is Atomic or Volatile_Full_Access.
3109 2018-01-04 Eric Botcazou <ebotcazou@adacore.com>
3111 * gnatvsn.ads: Bump copyright year.
3113 2018-01-03 Richard Sandiford <richard.sandiford@linaro.org>
3114 Alan Hayward <alan.hayward@arm.com>
3115 David Sherwood <david.sherwood@arm.com>
3117 * gcc-interface/misc.c (enumerate_modes): Treat GET_MODE_BITSIZE
3120 2018-01-03 Richard Sandiford <richard.sandiford@linaro.org>
3121 Alan Hayward <alan.hayward@arm.com>
3122 David Sherwood <david.sherwood@arm.com>
3124 * gcc-interface/misc.c (enumerate_modes): Treat GET_MODE_PRECISION
3127 2018-01-03 Richard Sandiford <richard.sandiford@linaro.org>
3128 Alan Hayward <alan.hayward@arm.com>
3129 David Sherwood <david.sherwood@arm.com>
3131 * gcc-interface/utils.c (gnat_types_compatible_p): Handle
3132 polynomial TYPE_VECTOR_SUBPARTS.
3134 2018-01-03 Richard Sandiford <richard.sandiford@linaro.org>
3135 Alan Hayward <alan.hayward@arm.com>
3136 David Sherwood <david.sherwood@arm.com>
3138 * gcc-interface/misc.c (enumerate_modes): Handle polynomial
3141 2018-01-03 Jakub Jelinek <jakub@redhat.com>
3143 Update copyright years.
3145 * gnat_ugn.texi: Bump @copying's copyright year.
3146 * gnat_rm.texi: Likewise.
3148 Copyright (C) 2018 Free Software Foundation, Inc.
3150 Copying and distribution of this file, with or without modification,
3151 are permitted in any medium without royalty provided the copyright
3152 notice and this notice are preserved.