gdb/ChangeLog

   1 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
   4
   5 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
   6
   7         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
   8         target types of size 96-bits, add some additional comments, and
   9         check that the builtin type we found was the correct size.
  10
  11 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
  12
  13         * utils.c (prompt_for_continue): Don't restore the styling at the
  14         end, as applied_style has the wrong value.  This fixes styling in
  15         long lists of file names that are interrupted by the "Continue?"
  16         prompt.
  17
  18 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  19
  20         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
  21         * c-lang.c (c_language_defn): Likewise.
  22         (cplus_language_defn): Likewise.
  23         (asm_language_defn): Likewise.
  24         (minimal_language_defn): Likewise.
  25         * d-lang.c (d_language_defn): Likewise.
  26         * f-lang.c (f_language_defn): Likewise.
  27         * go-lang.c (go_language_defn): Likewise.
  28         * language.c (unknown_language_defn): Likewise.
  29         (auto_language_defn): Likewise.
  30         * language.h (struct language_defn): Remove la_magic field.
  31         (LANG_MAGIC): Delete.
  32         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
  33         * objc-lang.c (objc_language_defn): Likewise.
  34         * opencl-lang.c (opencl_language_defn): Likewise.
  35         * p-lang.c (pascal_language_defn): Likewise.
  36         * rust-lang.c (rust_language_defn): Likewise.
  37
  38 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  39
  40         * riscv-tdep.c (riscv_type_align): New function.
  41         (riscv_type_alignment): Delete.
  42         (riscv_arg_location): Use 'type_align'.
  43         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
  44
  45 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  46
  47         * gdbtypes.c (type_align): A struct with no non-static fields also
  48         has alignment of 1.
  49
  50 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  51
  52         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
  53         component to 0.
  54         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
  55         member.
  56         (riscv_struct_info::analyse): New implementation using new
  57         analyse_inner member function.
  58         (riscv_struct_info::field_offset): New member function.
  59         (riscv_struct_info::m_offsets): New member variable.
  60         (riscv_struct_info::analyse_inner): New private member function,
  61         takes the old implementation of riscv_struct_info::analyse but
  62         extended to track field offsets.
  63         (riscv_call_arg_struct): Update the struct folding special cases
  64         to handle cases where empty C++ structs, which are non-zero
  65         length, are found.
  66         (riscv_arg_location): Initialise the length of each location, a
  67         non-zero length now indicates the location is in use.
  68         (riscv_push_dummy_call): Allow for the first location having a
  69         non-zero offset when setting up arguments.
  70         (riscv_return_value): Likewise, but for return values.
  71
  72 2019-04-11  Tom Tromey  <tromey@adacore.com>
  73
  74         * utils.c (internal_vproblem): Make "msg" const.
  75
  76 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
  77
  78         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
  79         * trad-frame.c (trad_frame_reset_saved_regs): New function.
  80         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
  81         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
  82
  83 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
  84
  85         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
  86         function.
  87         (fill_gregset): Call amd64_linux_collect_native_gregset instead
  88         of amd64_collect_native_gregset.
  89         (amd64_linux_nat_target::store_registers): Likewise.
  90
  91 2019-04-10  Tom Tromey  <tom@tromey.com>
  92
  93         * symtab.c (lookup_global_symbol_from_objfile)
  94         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
  95         * objfiles.h (class separate_debug_iterator): New.
  96         (class separate_debug_range): New.
  97         (struct objfile) <separate_debug_objfiles>: New method.
  98         (objfile_separate_debug_iterate): Don't declare.
  99         * objfiles.c (separate_debug_iterator::operator++): Rename from
 100         objfile_separate_debug_iterate.
 101         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 102         iterator.
 103         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 104         iterator.
 105
 106 2019-04-10  Tom Tromey  <tom@tromey.com>
 107
 108         * symfile.c (reread_symbols): Remove old comment.
 109         * objfiles.c (free_all_objfiles): Fix a typo.
 110
 111 2019-04-10  Tom Tromey  <tom@tromey.com>
 112
 113         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 114         * minsyms.c (lookup_minimal_symbol): Use foreach.
 115         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 116         (lookup_minimal_symbol_solib_trampoline): Likewise.
 117         * symfile.c (reread_symbols): Use foreach.
 118
 119 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 120             Tom Tromey  <tromey@adacore.com>
 121
 122         PR rust/24414:
 123         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 124         (rust_lex_int_test): Change "value" to be LONGEST.
 125         (rust_lex_tests): Add test for long integer literal.
 126
 127 2019-04-09  Tom Tromey  <tromey@adacore.com>
 128
 129         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 130         to bool.
 131         (extended_remote_target::attach): Update.
 132         (remote_target::remote_notice_new_inferior): Update.
 133         (remote_target::add_current_inferior_and_thread): Update.
 134         * inferior.c (exit_inferior_1): Use "false".
 135         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 136
 137 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 138
 139         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 140         the "start" command.
 141
 142 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 143
 144         * python/py-inferior.c (infpy_thread_from_thread_handle):
 145         Adjust comments to reflect renaming of thread_from_thread_handle
 146         to thread_from_handle.  Adjust keywords.  Fix type error message.
 147         (inferior_object_methods): Add thread_from_handle.  Retain
 148         thread_from_thread_handle, but mark it as deprecated.
 149
 150 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 151
 152         * gdbthread.h (find_thread_by_handle): Revise declaration.
 153         * thread.c (find_thread_by_handle): Likewise.  Adjust
 154         implementation too.
 155         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 156         support for buffer objects as handles.
 157
 158 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 159
 160         * python/py-infthread.c (thpy_thread_handle): New function.
 161         (thread_object_methods): Register thpy_thread_handle.
 162
 163 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 164
 165         * gdbthread.h (thread_to_thread_handle): Declare.
 166         * thread.c (gdbtypes.h): Include.
 167         (thread_to_thread_handle): New function.
 168
 169         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 170         (target_thread_info_to_thread_handle): Declare.
 171         * target.c (target_thread_info_to_thread_handle): New function.
 172         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 173         * target-delegates.c: Regenerate.
 174
 175         * linux-thread-db.c (class thread_db_target): Add method
 176         thread_info_to_thread_handle.
 177         (thread_db_target::thread_info_to_thread_handle): Define.
 178         * remote.c (class remote_target): Add new method
 179         thread_info_to_thread_handle.
 180         (remote_target::thread_info_to_thread_handle): Define.
 181
 182 2019-04-08  Pedro Alves  <palves@redhat.com>
 183
 184         * common/common-exceptions.c (throw_exception): Don't create
 185         named object to throw; throw directly.
 186         (throw_it): Likewise.  Don't initialize gdb_exception::message
 187         here, with new; pass FMT and AP to the ctor instead.
 188         * common/common-exceptions.h: Include <string>.
 189         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 190         const char *, va_list)): New ctor.  Use std::make_shared.
 191         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 192         errors)): Delete.
 193         (gdb_exception_error::gdb_exception_error(enum errors, const char
 194         *, va_list)): New.
 195         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 196         Add assertion.
 197         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 198         errors)): Delete.
 199         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 200         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 201         Add assertion.
 202
 203 2019-04-08  Tom Tromey  <tom@tromey.com>
 204
 205         * valops.c (value_rtti_indirect_type): Replace throw_exception
 206         with throw.
 207         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 208         with throw.
 209         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 210         throw.
 211         * target.c (target_translate_tls_address): Replace throw_exception
 212         with throw.
 213         * stack.c (frame_apply_command_count): Replace throw_exception
 214         with throw.
 215         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 216         throw.
 217         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 218         with throw.
 219         * rs6000-tdep.c (rs6000_frame_cache)
 220         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 221         * remote.c: Replace throw_exception with throw.
 222         * record-full.c (record_full_message, record_full_wait_1)
 223         (record_full_restore): Replace throw_exception with throw.
 224         * record-btrace.c:
 225         (get_thread_current_frame_id, record_btrace_start_replaying)
 226         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 227         (cmd_record_btrace_start): Replace throw_exception with throw.
 228         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 229         throw.
 230         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 231         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 232         * linespec.c:
 233         (find_linespec_symbols): Replace throw_exception with throw.
 234         * infrun.c (displaced_step_prepare, resume): Replace
 235         throw_exception with throw.
 236         * infcmd.c (post_create_inferior): Replace throw_exception with
 237         throw.
 238         * inf-loop.c (inferior_event_handler): Replace throw_exception
 239         with throw.
 240         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 241         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 242         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 243         (get_prev_frame_always, get_frame_pc_if_available)
 244         (get_frame_address_in_block_if_available, get_frame_language):
 245         Replace throw_exception with throw.
 246         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 247         throw_exception with throw.
 248         * eval.c (fetch_subexp_value, evaluate_var_value)
 249         (evaluate_funcall, evaluate_subexp_standard): Replace
 250         throw_exception with throw.
 251         * dwarf2loc.c (call_site_find_chain)
 252         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 253         Replace throw_exception with throw.
 254         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 255         with throw.
 256         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 257         throw.
 258         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 259         * completer.c (complete_line_internal): Replace throw_exception
 260         with throw.
 261         * compile/compile-object-run.c (compile_object_run): Replace
 262         throw_exception with throw.
 263         * cli/cli-script.c (process_next_line): Replace throw_exception
 264         with throw.
 265         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 266         (btrace_enable, btrace_maint_update_pt_packets): Replace
 267         throw_exception with throw.
 268         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 269         throw_exception with throw.
 270         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 271         throw_exception with throw.
 272         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 273         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 274         * aarch64-tdep.c (aarch64_make_prologue_cache)
 275         (aarch64_make_stub_cache): Replace throw_exception with throw.
 276
 277 2019-04-08  Tom Tromey  <tom@tromey.com>
 278
 279         * common/common-exceptions.c (throw_exception): Rename from
 280         throw_exception_cxx.  Remove old copy.  Make argument const.
 281         (throw_it): Create and throw exception objects directly.
 282         * common/common-exceptions.h (throw_exception): Make argument
 283         const.
 284         (struct gdb_exception_error): Add constructor.
 285         (struct gdb_exception_quit): Add constructor.
 286
 287 2019-04-08  Tom Tromey  <tom@tromey.com>
 288
 289         * common/common-exceptions.h (exception_rethrow): Don't declare.
 290         (TRY_SJLJ): Update comment.
 291         (TRY, CATCH, END_CATCH): Remove.
 292         * common/common-exceptions.c (exception_rethrow): Remove.
 293
 294 2019-04-08  Tom Tromey  <tom@tromey.com>
 295
 296         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 297         Remove.
 298         (gdb_exception_error): Rename from
 299         gdb_exception_RETURN_MASK_ERROR.
 300         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 301         (gdb_quit_bad_alloc): Update.
 302         * aarch64-tdep.c: Update.
 303         * ada-lang.c: Update.
 304         * ada-typeprint.c: Update.
 305         * ada-valprint.c: Update.
 306         * amd64-tdep.c: Update.
 307         * arch-utils.c: Update.
 308         * break-catch-throw.c: Update.
 309         * breakpoint.c: Update.
 310         * btrace.c: Update.
 311         * c-varobj.c: Update.
 312         * cli/cli-cmds.c: Update.
 313         * cli/cli-interp.c: Update.
 314         * cli/cli-script.c: Update.
 315         * common/common-exceptions.c: Update.
 316         * common/new-op.c: Update.
 317         * common/selftest.c: Update.
 318         * compile/compile-c-symbols.c: Update.
 319         * compile/compile-cplus-symbols.c: Update.
 320         * compile/compile-object-load.c: Update.
 321         * compile/compile-object-run.c: Update.
 322         * completer.c: Update.
 323         * corelow.c: Update.
 324         * cp-abi.c: Update.
 325         * cp-support.c: Update.
 326         * cp-valprint.c: Update.
 327         * darwin-nat.c: Update.
 328         * disasm-selftests.c: Update.
 329         * dtrace-probe.c: Update.
 330         * dwarf-index-cache.c: Update.
 331         * dwarf-index-write.c: Update.
 332         * dwarf2-frame-tailcall.c: Update.
 333         * dwarf2-frame.c: Update.
 334         * dwarf2loc.c: Update.
 335         * dwarf2read.c: Update.
 336         * eval.c: Update.
 337         * event-loop.c: Update.
 338         * event-top.c: Update.
 339         * exec.c: Update.
 340         * f-valprint.c: Update.
 341         * fbsd-tdep.c: Update.
 342         * frame-unwind.c: Update.
 343         * frame.c: Update.
 344         * gdbtypes.c: Update.
 345         * gnu-v3-abi.c: Update.
 346         * guile/guile-internal.h: Update.
 347         * guile/scm-block.c: Update.
 348         * guile/scm-breakpoint.c: Update.
 349         * guile/scm-cmd.c: Update.
 350         * guile/scm-disasm.c: Update.
 351         * guile/scm-frame.c: Update.
 352         * guile/scm-lazy-string.c: Update.
 353         * guile/scm-math.c: Update.
 354         * guile/scm-param.c: Update.
 355         * guile/scm-ports.c: Update.
 356         * guile/scm-pretty-print.c: Update.
 357         * guile/scm-symbol.c: Update.
 358         * guile/scm-symtab.c: Update.
 359         * guile/scm-type.c: Update.
 360         * guile/scm-value.c: Update.
 361         * i386-linux-tdep.c: Update.
 362         * i386-tdep.c: Update.
 363         * inf-loop.c: Update.
 364         * infcall.c: Update.
 365         * infcmd.c: Update.
 366         * infrun.c: Update.
 367         * jit.c: Update.
 368         * language.c: Update.
 369         * linespec.c: Update.
 370         * linux-fork.c: Update.
 371         * linux-nat.c: Update.
 372         * linux-tdep.c: Update.
 373         * linux-thread-db.c: Update.
 374         * main.c: Update.
 375         * mi/mi-cmd-break.c: Update.
 376         * mi/mi-cmd-stack.c: Update.
 377         * mi/mi-interp.c: Update.
 378         * mi/mi-main.c: Update.
 379         * objc-lang.c: Update.
 380         * p-valprint.c: Update.
 381         * parse.c: Update.
 382         * ppc-linux-tdep.c: Update.
 383         * printcmd.c: Update.
 384         * python/py-arch.c: Update.
 385         * python/py-breakpoint.c: Update.
 386         * python/py-cmd.c: Update.
 387         * python/py-finishbreakpoint.c: Update.
 388         * python/py-frame.c: Update.
 389         * python/py-framefilter.c: Update.
 390         * python/py-gdb-readline.c: Update.
 391         * python/py-inferior.c: Update.
 392         * python/py-infthread.c: Update.
 393         * python/py-lazy-string.c: Update.
 394         * python/py-linetable.c: Update.
 395         * python/py-objfile.c: Update.
 396         * python/py-param.c: Update.
 397         * python/py-prettyprint.c: Update.
 398         * python/py-progspace.c: Update.
 399         * python/py-record-btrace.c: Update.
 400         * python/py-record.c: Update.
 401         * python/py-symbol.c: Update.
 402         * python/py-type.c: Update.
 403         * python/py-unwind.c: Update.
 404         * python/py-utils.c: Update.
 405         * python/py-value.c: Update.
 406         * python/python.c: Update.
 407         * record-btrace.c: Update.
 408         * record-full.c: Update.
 409         * remote-fileio.c: Update.
 410         * remote.c: Update.
 411         * riscv-tdep.c: Update.
 412         * rs6000-aix-tdep.c: Update.
 413         * rs6000-tdep.c: Update.
 414         * rust-exp.y: Update.
 415         * rust-lang.c: Update.
 416         * s390-tdep.c: Update.
 417         * selftest-arch.c: Update.
 418         * solib-dsbt.c: Update.
 419         * solib-frv.c: Update.
 420         * solib-spu.c: Update.
 421         * solib-svr4.c: Update.
 422         * solib.c: Update.
 423         * sparc64-linux-tdep.c: Update.
 424         * stack.c: Update.
 425         * symfile-mem.c: Update.
 426         * symmisc.c: Update.
 427         * target.c: Update.
 428         * thread.c: Update.
 429         * top.c: Update.
 430         * tracefile-tfile.c: Update.
 431         * tui/tui.c: Update.
 432         * typeprint.c: Update.
 433         * unittests/cli-utils-selftests.c: Update.
 434         * unittests/parse-connection-spec-selftests.c: Update.
 435         * valops.c: Update.
 436         * valprint.c: Update.
 437         * value.c: Update.
 438         * varobj.c: Update.
 439         * windows-nat.c: Update.
 440         * x86-linux-nat.c: Update.
 441         * xml-support.c: Update.
 442
 443 2019-04-08  Tom Tromey  <tom@tromey.com>
 444
 445         * xml-support.c: Use C++ exception handling.
 446         * x86-linux-nat.c: Use C++ exception handling.
 447         * windows-nat.c: Use C++ exception handling.
 448         * varobj.c: Use C++ exception handling.
 449         * value.c: Use C++ exception handling.
 450         * valprint.c: Use C++ exception handling.
 451         * valops.c: Use C++ exception handling.
 452         * unittests/parse-connection-spec-selftests.c: Use C++ exception
 453         handling.
 454         * unittests/cli-utils-selftests.c: Use C++ exception handling.
 455         * typeprint.c: Use C++ exception handling.
 456         * tui/tui.c: Use C++ exception handling.
 457         * tracefile-tfile.c: Use C++ exception handling.
 458         * top.c: Use C++ exception handling.
 459         * thread.c: Use C++ exception handling.
 460         * target.c: Use C++ exception handling.
 461         * symmisc.c: Use C++ exception handling.
 462         * symfile-mem.c: Use C++ exception handling.
 463         * stack.c: Use C++ exception handling.
 464         * sparc64-linux-tdep.c: Use C++ exception handling.
 465         * solib.c: Use C++ exception handling.
 466         * solib-svr4.c: Use C++ exception handling.
 467         * solib-spu.c: Use C++ exception handling.
 468         * solib-frv.c: Use C++ exception handling.
 469         * solib-dsbt.c: Use C++ exception handling.
 470         * selftest-arch.c: Use C++ exception handling.
 471         * s390-tdep.c: Use C++ exception handling.
 472         * rust-lang.c: Use C++ exception handling.
 473         * rust-exp.y: Use C++ exception handling.
 474         * rs6000-tdep.c: Use C++ exception handling.
 475         * rs6000-aix-tdep.c: Use C++ exception handling.
 476         * riscv-tdep.c: Use C++ exception handling.
 477         * remote.c: Use C++ exception handling.
 478         * remote-fileio.c: Use C++ exception handling.
 479         * record-full.c: Use C++ exception handling.
 480         * record-btrace.c: Use C++ exception handling.
 481         * python/python.c: Use C++ exception handling.
 482         * python/py-value.c: Use C++ exception handling.
 483         * python/py-utils.c: Use C++ exception handling.
 484         * python/py-unwind.c: Use C++ exception handling.
 485         * python/py-type.c: Use C++ exception handling.
 486         * python/py-symbol.c: Use C++ exception handling.
 487         * python/py-record.c: Use C++ exception handling.
 488         * python/py-record-btrace.c: Use C++ exception handling.
 489         * python/py-progspace.c: Use C++ exception handling.
 490         * python/py-prettyprint.c: Use C++ exception handling.
 491         * python/py-param.c: Use C++ exception handling.
 492         * python/py-objfile.c: Use C++ exception handling.
 493         * python/py-linetable.c: Use C++ exception handling.
 494         * python/py-lazy-string.c: Use C++ exception handling.
 495         * python/py-infthread.c: Use C++ exception handling.
 496         * python/py-inferior.c: Use C++ exception handling.
 497         * python/py-gdb-readline.c: Use C++ exception handling.
 498         * python/py-framefilter.c: Use C++ exception handling.
 499         * python/py-frame.c: Use C++ exception handling.
 500         * python/py-finishbreakpoint.c: Use C++ exception handling.
 501         * python/py-cmd.c: Use C++ exception handling.
 502         * python/py-breakpoint.c: Use C++ exception handling.
 503         * python/py-arch.c: Use C++ exception handling.
 504         * printcmd.c: Use C++ exception handling.
 505         * ppc-linux-tdep.c: Use C++ exception handling.
 506         * parse.c: Use C++ exception handling.
 507         * p-valprint.c: Use C++ exception handling.
 508         * objc-lang.c: Use C++ exception handling.
 509         * mi/mi-main.c: Use C++ exception handling.
 510         * mi/mi-interp.c: Use C++ exception handling.
 511         * mi/mi-cmd-stack.c: Use C++ exception handling.
 512         * mi/mi-cmd-break.c: Use C++ exception handling.
 513         * main.c: Use C++ exception handling.
 514         * linux-thread-db.c: Use C++ exception handling.
 515         * linux-tdep.c: Use C++ exception handling.
 516         * linux-nat.c: Use C++ exception handling.
 517         * linux-fork.c: Use C++ exception handling.
 518         * linespec.c: Use C++ exception handling.
 519         * language.c: Use C++ exception handling.
 520         * jit.c: Use C++ exception handling.
 521         * infrun.c: Use C++ exception handling.
 522         * infcmd.c: Use C++ exception handling.
 523         * infcall.c: Use C++ exception handling.
 524         * inf-loop.c: Use C++ exception handling.
 525         * i386-tdep.c: Use C++ exception handling.
 526         * i386-linux-tdep.c: Use C++ exception handling.
 527         * guile/scm-value.c: Use C++ exception handling.
 528         * guile/scm-type.c: Use C++ exception handling.
 529         * guile/scm-symtab.c: Use C++ exception handling.
 530         * guile/scm-symbol.c: Use C++ exception handling.
 531         * guile/scm-pretty-print.c: Use C++ exception handling.
 532         * guile/scm-ports.c: Use C++ exception handling.
 533         * guile/scm-param.c: Use C++ exception handling.
 534         * guile/scm-math.c: Use C++ exception handling.
 535         * guile/scm-lazy-string.c: Use C++ exception handling.
 536         * guile/scm-frame.c: Use C++ exception handling.
 537         * guile/scm-disasm.c: Use C++ exception handling.
 538         * guile/scm-cmd.c: Use C++ exception handling.
 539         * guile/scm-breakpoint.c: Use C++ exception handling.
 540         * guile/scm-block.c: Use C++ exception handling.
 541         * guile/guile-internal.h: Use C++ exception handling.
 542         * gnu-v3-abi.c: Use C++ exception handling.
 543         * gdbtypes.c: Use C++ exception handling.
 544         * frame.c: Use C++ exception handling.
 545         * frame-unwind.c: Use C++ exception handling.
 546         * fbsd-tdep.c: Use C++ exception handling.
 547         * f-valprint.c: Use C++ exception handling.
 548         * exec.c: Use C++ exception handling.
 549         * event-top.c: Use C++ exception handling.
 550         * event-loop.c: Use C++ exception handling.
 551         * eval.c: Use C++ exception handling.
 552         * dwarf2read.c: Use C++ exception handling.
 553         * dwarf2loc.c: Use C++ exception handling.
 554         * dwarf2-frame.c: Use C++ exception handling.
 555         * dwarf2-frame-tailcall.c: Use C++ exception handling.
 556         * dwarf-index-write.c: Use C++ exception handling.
 557         * dwarf-index-cache.c: Use C++ exception handling.
 558         * dtrace-probe.c: Use C++ exception handling.
 559         * disasm-selftests.c: Use C++ exception handling.
 560         * darwin-nat.c: Use C++ exception handling.
 561         * cp-valprint.c: Use C++ exception handling.
 562         * cp-support.c: Use C++ exception handling.
 563         * cp-abi.c: Use C++ exception handling.
 564         * corelow.c: Use C++ exception handling.
 565         * completer.c: Use C++ exception handling.
 566         * compile/compile-object-run.c: Use C++ exception handling.
 567         * compile/compile-object-load.c: Use C++ exception handling.
 568         * compile/compile-cplus-symbols.c: Use C++ exception handling.
 569         * compile/compile-c-symbols.c: Use C++ exception handling.
 570         * common/selftest.c: Use C++ exception handling.
 571         * common/new-op.c: Use C++ exception handling.
 572         * cli/cli-script.c: Use C++ exception handling.
 573         * cli/cli-interp.c: Use C++ exception handling.
 574         * cli/cli-cmds.c: Use C++ exception handling.
 575         * c-varobj.c: Use C++ exception handling.
 576         * btrace.c: Use C++ exception handling.
 577         * breakpoint.c: Use C++ exception handling.
 578         * break-catch-throw.c: Use C++ exception handling.
 579         * arch-utils.c: Use C++ exception handling.
 580         * amd64-tdep.c: Use C++ exception handling.
 581         * ada-valprint.c: Use C++ exception handling.
 582         * ada-typeprint.c: Use C++ exception handling.
 583         * ada-lang.c: Use C++ exception handling.
 584         * aarch64-tdep.c: Use C++ exception handling.
 585
 586 2019-04-08  Tom Tromey  <tom@tromey.com>
 587
 588         * xml-support.c (gdb_xml_parser::parse): Update.
 589         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 590         * value.c (show_convenience): Update.
 591         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
 592         (test_parse_flags_qcs): Update.
 593         * thread.c (thr_try_catch_cmd): Update.
 594         * target.c (target_translate_tls_address): Update.
 595         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 596         (info_frame_command_core, frame_apply_command_count): Update.
 597         * rust-exp.y (rust_lex_exception_test): Update.
 598         * riscv-tdep.c (riscv_print_one_register_info): Update.
 599         * remote.c (remote_target::enable_btrace): Update.
 600         * record-btrace.c (record_btrace_enable_warn): Update.
 601         * python/py-utils.c (gdbpy_convert_exception): Update.
 602         * printcmd.c (do_one_display, print_variable_and_value): Update.
 603         * mi/mi-main.c (mi_print_exception): Update.
 604         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
 605         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 606         * linux-nat.c (linux_nat_target::attach): Update.
 607         * linux-fork.c (class scoped_switch_fork_info): Update.
 608         * infrun.c (displaced_step_prepare): Update.
 609         * infcall.c (call_function_by_hand_dummy): Update.
 610         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
 611         * gnu-v3-abi.c (print_one_vtable): Update.
 612         * frame.c (get_prev_frame_always): Update.
 613         * f-valprint.c (info_common_command_for_block): Update.
 614         * exec.c (try_open_exec_file): Update.
 615         * exceptions.c (print_exception, exception_print)
 616         (exception_fprintf, exception_print_same): Update.
 617         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
 618         * dwarf-index-cache.c (index_cache::store)
 619         (index_cache::lookup_gdb_index): Update.
 620         * darwin-nat.c (maybe_cache_shell): Update.
 621         * cp-valprint.c (cp_print_value_fields): Update.
 622         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
 623         (gcc_cplus_symbol_address): Update.
 624         * compile/compile-c-symbols.c (gcc_convert_symbol)
 625         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
 626         * common/selftest.c: Update.
 627         * common/common-exceptions.h (struct gdb_exception) <message>: Now
 628         a std::string.
 629         (exception_try_scope_entry, exception_try_scope_exit): Don't
 630         declare.
 631         (struct exception_try_scope): Remove.
 632         (TRY): Don't use exception_try_scope.
 633         (struct gdb_exception): Add constructor, operator=.
 634         <what>: New method.
 635         (struct gdb_exception_RETURN_MASK_ALL)
 636         (struct gdb_exception_RETURN_MASK_ERROR)
 637         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
 638         (struct gdb_quit_bad_alloc): Update.
 639         * common/common-exceptions.c (exception_none): Change
 640         initializer.
 641         (struct catcher) <state, exception>: Initialize inline.
 642         <prev>: Remove member.
 643         (current_catcher): Remove.
 644         (catchers): New global.
 645         (exceptions_state_mc_init): Simplify.
 646         (catcher_pop): Remove.
 647         (exceptions_state_mc, exceptions_state_mc_catch): Update.
 648         (try_scope_depth, exception_try_scope_entry)
 649         (exception_try_scope_exit): Remove.
 650         (throw_exception_sjlj): Update.
 651         (exception_messages, exception_messages_size): Remove.
 652         (throw_it): Simplify.
 653         (gdb_exception_sliced_copy): Remove.
 654         (throw_exception_cxx): Update.
 655         * cli/cli-script.c (script_from_file): Update.
 656         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
 657         Update.
 658         * ada-valprint.c (ada_val_print): Update.
 659         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
 660         (create_excep_cond_exprs): Update.
 661
 662 2019-04-08  Tom Tromey  <tom@tromey.com>
 663
 664         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
 665         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
 666         (TRY, CATCH, END_CATCH): Remove some definitions.
 667         * common/common-exceptions.c: Don't use GDB_XCPT.
 668         (catcher_list_size): Remove.
 669         (throw_exception, throw_it): Simplify.
 670
 671 2019-04-05  Tom Tromey  <tom@tromey.com>
 672
 673         Revert the header-sorting patch.
 674         * ft32-tdep.c: Revert.
 675         * frv-tdep.c: Revert.
 676         * frv-linux-tdep.c: Revert.
 677         * frame.c: Revert.
 678         * frame-unwind.c: Revert.
 679         * frame-base.c: Revert.
 680         * fork-child.c: Revert.
 681         * findvar.c: Revert.
 682         * findcmd.c: Revert.
 683         * filesystem.c: Revert.
 684         * filename-seen-cache.h: Revert.
 685         * filename-seen-cache.c: Revert.
 686         * fbsd-tdep.c: Revert.
 687         * fbsd-nat.h: Revert.
 688         * fbsd-nat.c: Revert.
 689         * f-valprint.c: Revert.
 690         * f-typeprint.c: Revert.
 691         * f-lang.c: Revert.
 692         * extension.h: Revert.
 693         * extension.c: Revert.
 694         * extension-priv.h: Revert.
 695         * expprint.c: Revert.
 696         * exec.h: Revert.
 697         * exec.c: Revert.
 698         * exceptions.c: Revert.
 699         * event-top.c: Revert.
 700         * event-loop.c: Revert.
 701         * eval.c: Revert.
 702         * elfread.c: Revert.
 703         * dwarf2read.h: Revert.
 704         * dwarf2read.c: Revert.
 705         * dwarf2loc.c: Revert.
 706         * dwarf2expr.h: Revert.
 707         * dwarf2expr.c: Revert.
 708         * dwarf2-frame.c: Revert.
 709         * dwarf2-frame-tailcall.c: Revert.
 710         * dwarf-index-write.h: Revert.
 711         * dwarf-index-write.c: Revert.
 712         * dwarf-index-common.c: Revert.
 713         * dwarf-index-cache.h: Revert.
 714         * dwarf-index-cache.c: Revert.
 715         * dummy-frame.c: Revert.
 716         * dtrace-probe.c: Revert.
 717         * disasm.h: Revert.
 718         * disasm.c: Revert.
 719         * disasm-selftests.c: Revert.
 720         * dictionary.c: Revert.
 721         * dicos-tdep.c: Revert.
 722         * demangle.c: Revert.
 723         * dcache.h: Revert.
 724         * dcache.c: Revert.
 725         * darwin-nat.h: Revert.
 726         * darwin-nat.c: Revert.
 727         * darwin-nat-info.c: Revert.
 728         * d-valprint.c: Revert.
 729         * d-namespace.c: Revert.
 730         * d-lang.c: Revert.
 731         * ctf.c: Revert.
 732         * csky-tdep.c: Revert.
 733         * csky-linux-tdep.c: Revert.
 734         * cris-tdep.c: Revert.
 735         * cris-linux-tdep.c: Revert.
 736         * cp-valprint.c: Revert.
 737         * cp-support.c: Revert.
 738         * cp-namespace.c: Revert.
 739         * cp-abi.c: Revert.
 740         * corelow.c: Revert.
 741         * corefile.c: Revert.
 742         * continuations.c: Revert.
 743         * completer.h: Revert.
 744         * completer.c: Revert.
 745         * complaints.c: Revert.
 746         * coffread.c: Revert.
 747         * coff-pe-read.c: Revert.
 748         * cli-out.h: Revert.
 749         * cli-out.c: Revert.
 750         * charset.c: Revert.
 751         * c-varobj.c: Revert.
 752         * c-valprint.c: Revert.
 753         * c-typeprint.c: Revert.
 754         * c-lang.c: Revert.
 755         * buildsym.c: Revert.
 756         * buildsym-legacy.c: Revert.
 757         * build-id.h: Revert.
 758         * build-id.c: Revert.
 759         * btrace.c: Revert.
 760         * bsd-uthread.c: Revert.
 761         * breakpoint.h: Revert.
 762         * breakpoint.c: Revert.
 763         * break-catch-throw.c: Revert.
 764         * break-catch-syscall.c: Revert.
 765         * break-catch-sig.c: Revert.
 766         * blockframe.c: Revert.
 767         * block.c: Revert.
 768         * bfin-tdep.c: Revert.
 769         * bfin-linux-tdep.c: Revert.
 770         * bfd-target.c: Revert.
 771         * bcache.c: Revert.
 772         * ax-general.c: Revert.
 773         * ax-gdb.h: Revert.
 774         * ax-gdb.c: Revert.
 775         * avr-tdep.c: Revert.
 776         * auxv.c: Revert.
 777         * auto-load.c: Revert.
 778         * arm-wince-tdep.c: Revert.
 779         * arm-tdep.c: Revert.
 780         * arm-symbian-tdep.c: Revert.
 781         * arm-pikeos-tdep.c: Revert.
 782         * arm-obsd-tdep.c: Revert.
 783         * arm-nbsd-tdep.c: Revert.
 784         * arm-nbsd-nat.c: Revert.
 785         * arm-linux-tdep.c: Revert.
 786         * arm-linux-nat.c: Revert.
 787         * arm-fbsd-tdep.c: Revert.
 788         * arm-fbsd-nat.c: Revert.
 789         * arm-bsd-tdep.c: Revert.
 790         * arch-utils.c: Revert.
 791         * arc-tdep.c: Revert.
 792         * arc-newlib-tdep.c: Revert.
 793         * annotate.h: Revert.
 794         * annotate.c: Revert.
 795         * amd64-windows-tdep.c: Revert.
 796         * amd64-windows-nat.c: Revert.
 797         * amd64-tdep.c: Revert.
 798         * amd64-sol2-tdep.c: Revert.
 799         * amd64-obsd-tdep.c: Revert.
 800         * amd64-obsd-nat.c: Revert.
 801         * amd64-nbsd-tdep.c: Revert.
 802         * amd64-nbsd-nat.c: Revert.
 803         * amd64-nat.c: Revert.
 804         * amd64-linux-tdep.c: Revert.
 805         * amd64-linux-nat.c: Revert.
 806         * amd64-fbsd-tdep.c: Revert.
 807         * amd64-fbsd-nat.c: Revert.
 808         * amd64-dicos-tdep.c: Revert.
 809         * amd64-darwin-tdep.c: Revert.
 810         * amd64-bsd-nat.c: Revert.
 811         * alpha-tdep.c: Revert.
 812         * alpha-obsd-tdep.c: Revert.
 813         * alpha-nbsd-tdep.c: Revert.
 814         * alpha-mdebug-tdep.c: Revert.
 815         * alpha-linux-tdep.c: Revert.
 816         * alpha-linux-nat.c: Revert.
 817         * alpha-bsd-tdep.c: Revert.
 818         * alpha-bsd-nat.c: Revert.
 819         * aix-thread.c: Revert.
 820         * agent.c: Revert.
 821         * addrmap.c: Revert.
 822         * ada-varobj.c: Revert.
 823         * ada-valprint.c: Revert.
 824         * ada-typeprint.c: Revert.
 825         * ada-tasks.c: Revert.
 826         * ada-lang.c: Revert.
 827         * aarch64-tdep.c: Revert.
 828         * aarch64-ravenscar-thread.c: Revert.
 829         * aarch64-newlib-tdep.c: Revert.
 830         * aarch64-linux-tdep.c: Revert.
 831         * aarch64-linux-nat.c: Revert.
 832         * aarch64-fbsd-tdep.c: Revert.
 833         * aarch64-fbsd-nat.c: Revert.
 834         * aarch32-linux-nat.c: Revert.
 835
 836 2019-04-05  Tom Tromey  <tom@tromey.com>
 837
 838         * ft32-tdep.c: Sort headers.
 839         * frv-tdep.c: Sort headers.
 840         * frv-linux-tdep.c: Sort headers.
 841         * frame.c: Sort headers.
 842         * frame-unwind.c: Sort headers.
 843         * frame-base.c: Sort headers.
 844         * fork-child.c: Sort headers.
 845         * findvar.c: Sort headers.
 846         * findcmd.c: Sort headers.
 847         * filesystem.c: Sort headers.
 848         * filename-seen-cache.h: Sort headers.
 849         * filename-seen-cache.c: Sort headers.
 850         * fbsd-tdep.c: Sort headers.
 851         * fbsd-nat.h: Sort headers.
 852         * fbsd-nat.c: Sort headers.
 853         * f-valprint.c: Sort headers.
 854         * f-typeprint.c: Sort headers.
 855         * f-lang.c: Sort headers.
 856         * extension.h: Sort headers.
 857         * extension.c: Sort headers.
 858         * extension-priv.h: Sort headers.
 859         * expprint.c: Sort headers.
 860         * exec.h: Sort headers.
 861         * exec.c: Sort headers.
 862         * exceptions.c: Sort headers.
 863         * event-top.c: Sort headers.
 864         * event-loop.c: Sort headers.
 865         * eval.c: Sort headers.
 866         * elfread.c: Sort headers.
 867         * dwarf2read.h: Sort headers.
 868         * dwarf2read.c: Sort headers.
 869         * dwarf2loc.c: Sort headers.
 870         * dwarf2expr.h: Sort headers.
 871         * dwarf2expr.c: Sort headers.
 872         * dwarf2-frame.c: Sort headers.
 873         * dwarf2-frame-tailcall.c: Sort headers.
 874         * dwarf-index-write.h: Sort headers.
 875         * dwarf-index-write.c: Sort headers.
 876         * dwarf-index-common.c: Sort headers.
 877         * dwarf-index-cache.h: Sort headers.
 878         * dwarf-index-cache.c: Sort headers.
 879         * dummy-frame.c: Sort headers.
 880         * dtrace-probe.c: Sort headers.
 881         * disasm.h: Sort headers.
 882         * disasm.c: Sort headers.
 883         * disasm-selftests.c: Sort headers.
 884         * dictionary.c: Sort headers.
 885         * dicos-tdep.c: Sort headers.
 886         * demangle.c: Sort headers.
 887         * dcache.h: Sort headers.
 888         * dcache.c: Sort headers.
 889         * darwin-nat.h: Sort headers.
 890         * darwin-nat.c: Sort headers.
 891         * darwin-nat-info.c: Sort headers.
 892         * d-valprint.c: Sort headers.
 893         * d-namespace.c: Sort headers.
 894         * d-lang.c: Sort headers.
 895         * ctf.c: Sort headers.
 896         * csky-tdep.c: Sort headers.
 897         * csky-linux-tdep.c: Sort headers.
 898         * cris-tdep.c: Sort headers.
 899         * cris-linux-tdep.c: Sort headers.
 900         * cp-valprint.c: Sort headers.
 901         * cp-support.c: Sort headers.
 902         * cp-namespace.c: Sort headers.
 903         * cp-abi.c: Sort headers.
 904         * corelow.c: Sort headers.
 905         * corefile.c: Sort headers.
 906         * continuations.c: Sort headers.
 907         * completer.h: Sort headers.
 908         * completer.c: Sort headers.
 909         * complaints.c: Sort headers.
 910         * coffread.c: Sort headers.
 911         * coff-pe-read.c: Sort headers.
 912         * cli-out.h: Sort headers.
 913         * cli-out.c: Sort headers.
 914         * charset.c: Sort headers.
 915         * c-varobj.c: Sort headers.
 916         * c-valprint.c: Sort headers.
 917         * c-typeprint.c: Sort headers.
 918         * c-lang.c: Sort headers.
 919         * buildsym.c: Sort headers.
 920         * buildsym-legacy.c: Sort headers.
 921         * build-id.h: Sort headers.
 922         * build-id.c: Sort headers.
 923         * btrace.c: Sort headers.
 924         * bsd-uthread.c: Sort headers.
 925         * breakpoint.h: Sort headers.
 926         * breakpoint.c: Sort headers.
 927         * break-catch-throw.c: Sort headers.
 928         * break-catch-syscall.c: Sort headers.
 929         * break-catch-sig.c: Sort headers.
 930         * blockframe.c: Sort headers.
 931         * block.c: Sort headers.
 932         * bfin-tdep.c: Sort headers.
 933         * bfin-linux-tdep.c: Sort headers.
 934         * bfd-target.c: Sort headers.
 935         * bcache.c: Sort headers.
 936         * ax-general.c: Sort headers.
 937         * ax-gdb.h: Sort headers.
 938         * ax-gdb.c: Sort headers.
 939         * avr-tdep.c: Sort headers.
 940         * auxv.c: Sort headers.
 941         * auto-load.c: Sort headers.
 942         * arm-wince-tdep.c: Sort headers.
 943         * arm-tdep.c: Sort headers.
 944         * arm-symbian-tdep.c: Sort headers.
 945         * arm-pikeos-tdep.c: Sort headers.
 946         * arm-obsd-tdep.c: Sort headers.
 947         * arm-nbsd-tdep.c: Sort headers.
 948         * arm-nbsd-nat.c: Sort headers.
 949         * arm-linux-tdep.c: Sort headers.
 950         * arm-linux-nat.c: Sort headers.
 951         * arm-fbsd-tdep.c: Sort headers.
 952         * arm-fbsd-nat.c: Sort headers.
 953         * arm-bsd-tdep.c: Sort headers.
 954         * arch-utils.c: Sort headers.
 955         * arc-tdep.c: Sort headers.
 956         * arc-newlib-tdep.c: Sort headers.
 957         * annotate.h: Sort headers.
 958         * annotate.c: Sort headers.
 959         * amd64-windows-tdep.c: Sort headers.
 960         * amd64-windows-nat.c: Sort headers.
 961         * amd64-tdep.c: Sort headers.
 962         * amd64-sol2-tdep.c: Sort headers.
 963         * amd64-obsd-tdep.c: Sort headers.
 964         * amd64-obsd-nat.c: Sort headers.
 965         * amd64-nbsd-tdep.c: Sort headers.
 966         * amd64-nbsd-nat.c: Sort headers.
 967         * amd64-nat.c: Sort headers.
 968         * amd64-linux-tdep.c: Sort headers.
 969         * amd64-linux-nat.c: Sort headers.
 970         * amd64-fbsd-tdep.c: Sort headers.
 971         * amd64-fbsd-nat.c: Sort headers.
 972         * amd64-dicos-tdep.c: Sort headers.
 973         * amd64-darwin-tdep.c: Sort headers.
 974         * amd64-bsd-nat.c: Sort headers.
 975         * alpha-tdep.c: Sort headers.
 976         * alpha-obsd-tdep.c: Sort headers.
 977         * alpha-nbsd-tdep.c: Sort headers.
 978         * alpha-mdebug-tdep.c: Sort headers.
 979         * alpha-linux-tdep.c: Sort headers.
 980         * alpha-linux-nat.c: Sort headers.
 981         * alpha-bsd-tdep.c: Sort headers.
 982         * alpha-bsd-nat.c: Sort headers.
 983         * aix-thread.c: Sort headers.
 984         * agent.c: Sort headers.
 985         * addrmap.c: Sort headers.
 986         * ada-varobj.c: Sort headers.
 987         * ada-valprint.c: Sort headers.
 988         * ada-typeprint.c: Sort headers.
 989         * ada-tasks.c: Sort headers.
 990         * ada-lang.c: Sort headers.
 991         * aarch64-tdep.c: Sort headers.
 992         * aarch64-ravenscar-thread.c: Sort headers.
 993         * aarch64-newlib-tdep.c: Sort headers.
 994         * aarch64-linux-tdep.c: Sort headers.
 995         * aarch64-linux-nat.c: Sort headers.
 996         * aarch64-fbsd-tdep.c: Sort headers.
 997         * aarch64-fbsd-nat.c: Sort headers.
 998         * aarch32-linux-nat.c: Sort headers.
 999
1000 2019-04-04  Tom Tromey  <tom@tromey.com>
1001
1002         * varobj.c (varobj_create): Update.
1003         * rust-exp.y (struct rust_parser) <update_innermost_block,
1004         lookup_symbol>: New methods.
1005         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1006         Rename.
1007         (rust_parser::rust_lookup_type)
1008         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1009         * printcmd.c (display_command, do_one_display): Update.
1010         * parser-defs.h (struct parser_state) <parser_state>: Add
1011         "tracker" parameter.
1012         (block_tracker): New member.
1013         (class innermost_block_tracker) <innermost_block_tracker>: Add
1014         "types" parameter.
1015         <reset>: Remove method.
1016         (innermost_block): Don't declare.
1017         (null_post_parser): Update.
1018         * parse.c (innermost_block): Remove global.
1019         (write_dollar_variable): Update.
1020         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1021         Remove "tracker_types" parameter.
1022         (parse_expression): Add "tracker" parameter.
1023         (parse_expression_for_completion): Update.
1024         (null_post_parser): Add "tracker" parameter.
1025         * p-exp.y: Update rules.
1026         * m2-exp.y: Update rules.
1027         * language.h (struct language_defn) <la_post_parser>: Add
1028         "tracker" parameter.
1029         * go-exp.y: Update rules.
1030         * f-exp.y: Update rules.
1031         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1032         parameter.
1033         * d-exp.y: Update rules.
1034         * c-exp.y: Update rules.
1035         * breakpoint.c (set_breakpoint_condition): Create an
1036         innermost_block_tracker.
1037         (watch_command_1): Likewise.
1038         * ada-lang.c (resolve): Add "tracker" parameter.
1039         (resolve_subexp): Likewise.
1040         * ada-exp.y (write_var_from_sym): Update.
1041
1042 2019-04-04  Tom Tromey  <tom@tromey.com>
1043
1044         * type-stack.h: New file.
1045         * type-stack.c: New file.
1046         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1047         type-stack.h.
1048         (insert_into_type_stack, insert_type, push_type, push_type_int)
1049         (insert_type_address_space, pop_type, pop_type_int)
1050         (pop_typelist, pop_type_stack, append_type_stack)
1051         (push_type_stack, get_type_stack, push_typelist)
1052         (follow_type_instance_flags, follow_types): Don't declare.
1053         * parse.c (type_stack): Remove global.
1054         (parse_exp_in_context): Update.
1055         (insert_into_type_stack, insert_type, push_type, push_type_int)
1056         (insert_type_address_space, pop_type, pop_type_int)
1057         (pop_typelist, pop_type_stack, append_type_stack)
1058         (push_type_stack, get_type_stack, push_typelist)
1059         (follow_type_instance_flags, follow_types): Remove (moved to
1060         type-stack.c).
1061         * f-exp.y (type_stack): New global.
1062         Update rules.
1063         (push_kind_type, f_parse): Update.
1064         * d-exp.y (type_stack): New global.
1065         Update rules.
1066         (d_parse): Update.
1067         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1068         Update rules.
1069         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1070         (HFILES_NO_SRCDIR): Add type-stack.h.
1071
1072 2019-04-04  Tom Tromey  <tom@tromey.com>
1073
1074         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1075         (rust_parser::convert_ast_to_expression, rust_parse)
1076         (rust_lex_test_completion, rust_lex_tests): Update.
1077         * parser-defs.h (struct expr_completion_state): New.
1078         (struct parser_state) <parser_state>: Add completion parameter.
1079         <mark_struct_expression, mark_completion_tag>: New methods.
1080         <parse_completion, m_completion_state>: New members.
1081         (prefixify_expression, null_post_parser): Update.
1082         (mark_struct_expression, mark_completion_tag): Don't declare.
1083         * parse.c (parse_completion, expout_last_struct)
1084         (expout_tag_completion_type, expout_completion_name): Remove
1085         globals.
1086         (parser_state::mark_struct_expression)
1087         (parser_state::mark_completion_tag): Now methods.
1088         (prefixify_expression): Add last_struct parameter.
1089         (prefixify_subexp): Likewise.
1090         (parse_exp_1): Update.
1091         (parse_exp_in_context): Add cstate parameter.  Update.
1092         (parse_expression_for_completion): Create an
1093         expr_completion_state.
1094         (null_post_parser): Add "completion" parameter.
1095         * p-exp.y: Update rules.
1096         (yylex): Update.
1097         * language.h (struct language_defn) <la_post_parser>: Add
1098         "completing" parameter.
1099         * go-exp.y: Update rules.
1100         (lex_one_token): Update.
1101         * expression.h (parse_completion): Don't declare.
1102         * d-exp.y: Update rules.
1103         (lex_one_token): Update rules.
1104         * c-exp.y: Update rules.
1105         (lex_one_token): Update.
1106         * ada-lang.c (resolve): Add "parse_completion" parameter.
1107         (resolve_subexp): Likewise.
1108         (ada_resolve_function): Likewise.
1109
1110 2019-04-04  Tom Tromey  <tom@tromey.com>
1111
1112         * parser-defs.h (struct parser_state) <start_arglist,
1113         end_arglist>: New methods.
1114         <arglist_len, m_funcall_chain>: New members.
1115         (arglist_len, start_arglist, end_arglist): Don't declare.
1116         * parse.c (arglist_len, funcall_chain): Remove global.
1117         (start_arglist, end_arglist): Remove functions.
1118         (parse_exp_in_context): Update.
1119         * p-exp.y: Update rules.
1120         * m2-exp.y: Update rules.
1121         * go-exp.y: Update rules.
1122         * f-exp.y: Update rules.
1123         * d-exp.y: Update rules.
1124         * c-exp.y: Update rules.
1125
1126 2019-04-04  Tom Tromey  <tom@tromey.com>
1127
1128         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1129         lex_operator, push_back>: New methods.
1130         Update all rules.
1131         (rust_parser::lex_hex, lex_escape): Rename and update.
1132         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1133         (rust_parser::lex_operator): Rename and update.
1134         (rust_parser::lex_number, rustyylex, rustyyerror)
1135         (rust_lex_test_init, rust_lex_test_sequence)
1136         (rust_lex_test_push_back, rust_lex_tests): Update.
1137         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1138         parameter.
1139         <lexptr, prev_lexptr>: New members.
1140         (lexptr, prev_lexptr): Don't declare.
1141         * parse.c (lexptr, prev_lexptr): Remove globals.
1142         (parse_exp_in_context): Update.
1143         * p-exp.y (yylex, yyerror): Update.
1144         * m2-exp.y (parse_number, yylex, yyerror): Update.
1145         * go-exp.y (lex_one_token, yyerror): Update.
1146         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1147         * d-exp.y (lex_one_token, yyerror): Update.
1148         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1149         (lex_one_token, yyerror): Update.
1150         * ada-lex.l (YY_INPUT): Update.
1151         (rewind_to_char): Update.
1152         * ada-exp.y (yyerror): Update.
1153
1154 2019-04-04  Tom Tromey  <tom@tromey.com>
1155
1156         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1157         * parser-defs.h (struct parser_state) <parser_state>: Add new
1158         parameter.
1159         <comma_terminates>: New member.
1160         (comma_terminates): Don't declare global.
1161         * parse.c (comma_terminates): Remove global.
1162         (parse_exp_in_context): Update.
1163         * p-exp.y (yylex): Update.
1164         * m2-exp.y (yylex): Update.
1165         * go-exp.y (lex_one_token): Update.
1166         * f-exp.y (yylex): Update.
1167         * d-exp.y (lex_one_token): Update.
1168         * c-exp.y (lex_one_token): Update.
1169         * ada-lex.l: Update.
1170
1171 2019-04-04  Tom Tromey  <tom@tromey.com>
1172
1173         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1174         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1175         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1176         * parser-defs.h (paren_depth): Don't declare.
1177         * parse.c (paren_depth): Remove global.
1178         (parse_exp_in_context): Update.
1179         * p-exp.y (paren_depth): New global.
1180         (pascal_parse): Initialize it.
1181         * m2-exp.y (paren_depth): New global.
1182         (m2_parse): Initialize it.
1183         * go-exp.y (paren_depth): New global.
1184         (go_parse): Initialize it.
1185         * f-exp.y (paren_depth): New global.
1186         (f_parse): Initialize it.
1187         * d-exp.y (paren_depth): New global.
1188         (d_parse): Initialize it.
1189         * c-exp.y (paren_depth): New global.
1190         (c_parse): Initialize it.
1191         * ada-lex.l (paren_depth): New global.
1192         (lexer_init): Initialize it.
1193
1194 2019-04-04  Tom Tromey  <tom@tromey.com>
1195
1196         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1197         (rust_parser::convert_ast_to_type)
1198         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1199         * parser-defs.h (struct parser_state) <parser_state>: Add
1200         parameters.  Initialize new members.
1201         <expression_context_block, expression_context_pc>: New members.
1202         * parse.c (expression_context_block, expression_context_pc):
1203         Remove globals.
1204         (parse_exp_in_context): Update.
1205         * p-exp.y: Update all rules.
1206         (yylex): Update.
1207         * m2-exp.y: Update all rules.
1208         (yylex): Update.
1209         * go-exp.y (yylex): Update.
1210         * f-exp.y (yylex): Update.
1211         * d-exp.y: Update all rules.
1212         (yylex): Update.
1213         * c-exp.y: Update all rules.
1214         (lex_one_token, classify_name, yylex, c_parse): Update.
1215         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1216
1217 2019-04-04  Tom Tromey  <tom@tromey.com>
1218
1219         * gdbarch.h, gdbarch.c: Rebuild.
1220         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1221         * stap-probe.h:
1222         (struct stap_parse_info): Replace "parser_state" with
1223         "expr_builder".
1224         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1225         (parser_state): New class.
1226         * parse.c (expr_builder): Rename.
1227         (expr_builder::release): Rename.
1228         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1229         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1230         (write_exp_elt_longcst, write_exp_elt_floatcst)
1231         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1232         (write_exp_string_vector, write_exp_bitstring)
1233         (write_exp_msymbol, mark_struct_expression)
1234         (write_dollar_variable)
1235         (insert_type_address_space, increase_expout_size): Replace
1236         "parser_state" with "expr_builder".
1237         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1238         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1239         "parser_state" with "expr_builder".
1240
1241 2019-04-04  Tom Tromey  <tom@tromey.com>
1242
1243         * rust-exp.y: Replace "parse_language" with method call.
1244         * p-exp.y:
1245         (yylex): Replace "parse_language" with method call.
1246         * m2-exp.y:
1247         (yylex): Replace "parse_language" with method call.
1248         * go-exp.y (classify_name): Replace "parse_language" with method
1249         call.
1250         * f-exp.y (yylex): Replace "parse_language" with method call.
1251         * d-exp.y (lex_one_token): Replace "parse_language" with method
1252         call.
1253         * c-exp.y:
1254         (lex_one_token, classify_name, yylex): Replace "parse_language"
1255         with method call.
1256         * ada-exp.y (find_primitive_type, type_char)
1257         (type_system_address): Replace "parse_language" with method call.
1258
1259 2019-04-04  Tom Tromey  <tom@tromey.com>
1260
1261         * rust-exp.y: Replace "parse_gdbarch" with method call.
1262         * parse.c (write_dollar_variable, insert_type_address_space):
1263         Replace "parse_gdbarch" with method call.
1264         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1265         call.
1266         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1267         call.
1268         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1269         "parse_gdbarch" with method call.
1270         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1271         with method call.
1272         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1273         "parse_gdbarch" with method call.
1274         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1275         "parse_gdbarch" with method call.
1276         * c-exp.y (parse_type, parse_number, classify_name): Replace
1277         "parse_gdbarch" with method call.
1278         * ada-lex.l: Replace "parse_gdbarch" with method call.
1279         * ada-exp.y (parse_type, find_primitive_type, type_char)
1280         (type_system_address): Replace "parse_gdbarch" with method call.
1281
1282 2019-04-04  Tom Tromey  <tom@tromey.com>
1283
1284         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1285         * stap-probe.c (stap_parse_argument): Update.
1286         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1287         initial_size parameter.
1288         * rust-exp.y (rust_lex_tests): Update.
1289         * parse.c (parser_state): Update.
1290         (parse_exp_in_context): Update.
1291         * parser-defs.h (struct parser_state) <parser_state>: Remove
1292         "initial_size" parameter.
1293
1294 2019-04-04  Tom Tromey  <tom@tromey.com>
1295
1296         * parser-defs.h (increase_expout_size): Don't declare.
1297         * parse.c (increase_expout_size): Now static.
1298
1299 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1300
1301         * gnu-nat.c (gnu_nat_target::wait): Fix
1302         target_waitstatus_to_string call.
1303
1304 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1305
1306         * eval.c (evaluate_subexp_standard): Handle internal functions
1307         during Fortran function call handling.
1308
1309 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1310
1311         * NEWS: Mention new internal functions.
1312         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1313         (read_base_type): Use dwarf2_init_complex_target_type.
1314         * value.c (creal_internal_fn): New function.
1315         (cimag_internal_fn): New function.
1316         (_initialize_values): Register new internal functions.
1317
1318 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1319
1320         * infrun.c (stop_all_threads): If debug_infrun, always
1321         trace the wait status after wait_one, using
1322         target_waitstatus_to_string and target_pid_to_str.
1323         (handle_inferior_event): Replace various trace of
1324         wait status kind by a single trace.
1325         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1326         wait status kind image by target_waitstatus_to_string.
1327         * target/waitstatus.c (target_waitstatus_to_string): Fix
1328         obsolete comment.
1329
1330 2019-04-01  Tom Tromey  <tromey@adacore.com>
1331
1332         PR symtab/23331:
1333         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1334
1335 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1336             Pedro Alves  <palves@redhat.com>
1337
1338         * top.c (quit_force): Call 'finalize_values'.
1339         * value.c (finalize_values): New function.
1340         * value.h (finalize_values): Declare.
1341
1342 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1343
1344         * NEWS: Announce $_gdb_major and $_gdb_minor.
1345
1346         * top.c (init_gdb_version_vars): New function.
1347         (gdb_init): Call init_gdb_version_vars.
1348
1349 2019-03-29  Tom Tromey  <tromey@adacore.com>
1350
1351         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1352         help text.  Remove dead code.
1353
1354 2019-03-29  Keith Seitz  <keiths@redhat.com>
1355
1356         From Siddhesh Poyarekar:
1357         * f-lang.h (f77_get_upperbound): Return LONGEST.
1358         (f77_get_lowerbound): Likewise.
1359         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1360         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1361         print them.
1362         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1363         plongest to format print it.
1364         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1365         (f77_get_upperbound): Likewise.
1366         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1367         LOWER_BOUND to LONGEST.
1368         (f77_create_arrayprint_offset_tbl): Likewise.
1369
1370 2019-03-29  Keith Seitz  <keiths@redhat.com>
1371
1372         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1373         %s/pulongest for TYPE_LENGTH instead of %d in format
1374         strings.
1375         * ada-typerint.c (ada_print_type): Likewise.
1376         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1377         * compile/compile-c-support.c (generate_register_struct): Likewise.
1378         * gdbtypes.c (recursive_dump_type): Likewise.
1379         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1380         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1381         instead of %d in format strings.
1382         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1383         to std::min to ULONGEST.
1384         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1385         instead of %d in format strings.
1386         * tracepoint.c (info_scope_command): Likewise.
1387         * typeprint.c (print_offset_data::update)
1388         (print_offset_data::finish): Likewise.
1389         * xtensa-tdep.c (xtensa_store_return_value)
1390         (xtensa_push_dummy_call): Likewise.
1391
1392 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1393
1394         * windows-nat.c (display_selector): Fixed format specifications
1395         for 64-bit Cygwin.
1396
1397 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1398
1399         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1400
1401 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1402
1403         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1404         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1405         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1406         (nios2_linux_init_abi): Install it.
1407
1408 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1409
1410         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1411
1412 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1413
1414         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1415
1416 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1417             Tom Tromey  <tromey@adacore.com>
1418
1419         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1420
1421 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1422
1423         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1424         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1425         method to compute the bounds of range types. Also print "[evaluated]"
1426         if the bounds' values come from a dynamic evaluation.
1427
1428 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1429
1430         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1431         whitespace when pretty printing is on.
1432
1433 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1434
1435         * ppc-linux-nat.c: Add include.
1436
1437 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1438
1439         * NEWS: Mention AArch64 Pointer Authentication.
1440
1441 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1442
1443         * arm-linux-nat.c: Add include.
1444
1445 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1446
1447         * source-cache.c (source_cache::get_source_lines): Re-read
1448         fullname after calling open_source_file.
1449
1450 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1451
1452         * NEWS: Mention TLS support for FreeBSD.
1453
1454 2019-03-25  Tom Tromey  <tromey@adacore.com>
1455
1456         * minsyms.c (BUNCH_SIZE): Update comment.
1457         (~minimal_symbol_reader): Remove old comment.
1458         (compact_minimal_symbols): Update comment.
1459         (minimal_symbol_reader::install): Remove old comment.  Update
1460         other comments.
1461
1462 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1463
1464         * s390-linux-nat.c: Add include.
1465
1466 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1467
1468         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1469         Call linux_get_hwcap.
1470         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1471         Likewise.
1472         (aarch64_linux_get_hwcap): Remove function.
1473         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1474         declaration.
1475         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1476         linux_get_hwcap.
1477         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1478         * linux-tdep.c (linux_get_hwcap): Add function.
1479         (linux_get_hwcap2): Likewise.
1480         * linux-tdep.h (linux_get_hwcap): Add declaration.
1481         (linux_get_hwcap2): Likewise.
1482         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1483         (ppc_linux_get_hwcap2): Likewise.
1484         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1485         linux_get_hwcap.
1486         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1487         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1488         (ppc_linux_nat_target::read_description): Likewise.
1489         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1490         * s390-linux-nat.c: Likewise.
1491         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1492
1493 2019-03-24  Tom Tromey  <tom@tromey.com>
1494
1495         * ada-lang.c (standard_lookup): Simplify initialization.
1496         (ada_lookup_symbol_nonlocal): Simplify return.
1497         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1498         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1499         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1500         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1501         initialization.
1502         * solib.c (solib_global_lookup): Simplify.
1503         * symtab.c (null_block_symbol): Remove.
1504         (symbol_cache_lookup): Simplify returns.
1505         (lookup_language_this): Simplify returns.
1506         (lookup_symbol_aux): Simplify return.
1507         (lookup_local_symbol): Simplify returns.
1508         (lookup_global_symbol_from_objfile): Simplify return.
1509         (lookup_symbol_in_objfile_symtabs)
1510         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1511         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1512         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1513         * cp-namespace.c (cp_lookup_bare_symbol)
1514         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1515         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1516         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1517         (cp_lookup_symbol_via_imports): Simplify initialization.
1518         (find_symbol_in_baseclass): Likewise.
1519         * symtab.h (null_block_symbol): Remove.
1520         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1521         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1522         (d_lookup_symbol_module): Likewise.
1523         (find_symbol_in_baseclass): Simplify initialization.
1524
1525 2019-03-24  Tom Tromey  <tom@tromey.com>
1526
1527         * expression.h: Don't include symtab.h.
1528         (struct block): Forward declare.
1529
1530 2019-03-24  Tom Tromey  <tom@tromey.com>
1531
1532         * c-exp.y (typebase): Remove casts.
1533         * gdbtypes.c (lookup_unsigned_typename, )
1534         (lookup_signed_typename): Remove cast.
1535         * eval.c (parse_to_comma_and_eval): Remove cast.
1536         * parse.c (write_dollar_variable): Remove cast.
1537         * block.h (struct block) <superblock>: Now const.
1538         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1539         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1540         (map_block): Make "block" const.
1541         * symfile.h (struct quick_symbol_functions)
1542         <map_matching_symbols>: Constify block argument to "callback".
1543         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1544         const.
1545         (find_pc_sect_compunit_symtab): Make "b" const.
1546         (find_symbol_at_address): Likewise.
1547         (search_symbols): Likewise.
1548         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1549         (dw2_debug_names_lookup_symbol): Likewise.
1550         (dw2_map_matching_symbols): Update.
1551         * p-valprint.c (pascal_val_print): Remove "block".
1552         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1553         (aux_add_nonlocal_symbols): Make "block" const.
1554         (resolve_subexp): Remove cast.
1555         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1556         const.
1557         (iterate_over_file_blocks): Likewise.
1558         * f-exp.y (%union) <bval>: Remove.
1559         * coffread.c (patch_opaque_types): Make "b" const.
1560         * spu-tdep.c (spu_catch_start): Make "block" const.
1561         * c-valprint.c (print_unpacked_pointer): Remove "block".
1562         * symmisc.c (dump_symtab_1): Make "b" const.
1563         (block_depth): Make "block" const.
1564         * d-exp.y (%union) <bval>: Remove.
1565         * cp-support.h (cp_lookup_rtti_type): Update.
1566         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1567         * psymtab.c (psym_lookup_symbol): Make "block" const.
1568         (maintenance_check_psymtabs): Make "b" const.
1569         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1570         (enumerate_locals, enumerate_args): Update.
1571         * python/py-symtab.c (stpy_global_block): Make "block" const.
1572         (stpy_static_block): Likewise.
1573         * inline-frame.c (block_starting_point_at): Make "new_block"
1574         const.
1575         * block.c (find_block_in_blockvector): Make return type const.
1576         (blockvector_for_pc_sect): Make "b" const.
1577         (find_block_in_blockvector): Make "b" const.
1578
1579 2019-03-23  Tom Tromey  <tom@tromey.com>
1580
1581         * varobj.c (varobj_create): Update.
1582         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1583         * printcmd.c (display_command, do_one_display): Don't reset
1584         innermost_block.
1585         * parser-defs.h (enum innermost_block_tracker_type): Move to
1586         expression.h.
1587         (innermost_block): Update comment.
1588         * parse.c (parse_exp_1): Add tracker_types parameter.
1589         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1590         tracker_types parameter.  Reset innermost_block.
1591         (parse_exp_in_context): Remove.
1592         (parse_expression_for_completion): Update.
1593         * objfiles.c (~objfile): Don't reset expression_context_block or
1594         innermost_block.
1595         * expression.h (enum innermost_block_tracker_type): Move from
1596         parser-defs.h.
1597         (parse_exp_1): Add tracker_types parameter.
1598         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1599         reset innermost_block.
1600
1601 2019-03-23  Tom Tromey  <tom@tromey.com>
1602
1603         * objfiles.h: Include bcache.h.
1604
1605 2019-03-23  Tom Tromey  <tom@tromey.com>
1606
1607         * linespec.c (get_current_search_block): Use
1608         scoped_restore_current_language.
1609         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1610
1611 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1612             Jiong Wang  <jiong.wang@arm.com>
1613
1614         * aarch64-linux-tdep.c
1615         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1616         section.
1617         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1618
1619 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1620             Jiong Wang  <jiong.wang@arm.com>
1621
1622         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1623         instructions.
1624         (aarch64_analyze_prologue_test): Add PACIASP test.
1625         (aarch64_prologue_prev_register): Unmask PC value.
1626
1627 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1628             Jiong Wang  <jiong.wang@arm.com>
1629
1630         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1631         (aarch64_dwarf2_prev_register): Unmask PC value.
1632         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1633         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1634         DW_CFA_AARCH64_negate_ra_state.
1635         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1636
1637 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1638             Jiong Wang  <jiong.wang@arm.com>
1639
1640         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1641         registers.
1642         (aarch64_pseudo_register_name): Likewise.
1643         (aarch64_pseudo_register_type): Likewise.
1644         (aarch64_pseudo_register_reggroup_p): Likewise.
1645         (aarch64_gdbarch_init): Add pauth registers.
1646         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1647         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1648         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1649         (struct gdbarch_tdep): Add regnum for ra_state.
1650
1651 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1652             Jiong Wang  <jiong.wang@arm.com>
1653
1654         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1655
1656 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1657             Jiong Wang  <jiong.wang@arm.com>
1658
1659         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1660         function.
1661         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1662         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1663         (aarch64_gdbarch_init): Add puth registers.
1664         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1665         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1666         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1667
1668 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1669             Jiong Wang  <jiong.wang@arm.com>
1670
1671         * aarch64-linux-nat.c
1672         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1673         * aarch64-linux-tdep.c
1674         (aarch64_linux_core_read_description): Likewise.
1675         (aarch64_linux_get_hwcap): New function.
1676         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1677         (aarch64_linux_get_hwcap): New declaration.
1678
1679 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1680             Jiong Wang  <jiong.wang@arm.com>
1681
1682         * aarch64-linux-nat.c
1683         (aarch64_linux_nat_target::read_description): Add pauth param.
1684         * aarch64-linux-tdep.c
1685         (aarch64_linux_core_read_description): Likewise.
1686         * aarch64-tdep.c (struct target_desc): Add in pauth.
1687         (aarch64_read_description): Add pauth param.
1688         (aarch64_gdbarch_init): Likewise.
1689         * aarch64-tdep.h (aarch64_read_description): Likewise.
1690         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1691         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1692         * features/Makefile: Add new files.
1693         * features/aarch64-pauth.c: New file.
1694         * features/aarch64-pauth.xml: New file.
1695
1696 2019-03-20  Tom Tromey  <tromey@adacore.com>
1697
1698         * infrun.c (handle_inferior_event): Rename from
1699         handle_inferior_event_1.  Create a scoped_value_mark.
1700         (handle_inferior_event): Remove.
1701
1702 2019-03-19  Tom Tromey  <tromey@adacore.com>
1703
1704         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1705         * infrun.h (print_stop_event): Add "displays" parameter.
1706         * infrun.c (print_stop_event): Add "displays" parameter.
1707
1708 2019-03-19  Pedro Alves  <palves@redhat.com>
1709
1710         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1711         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1712         to -1.  Fix TABs vs spaces.
1713         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1714         * tui/tui-out.h (tui_ui_out) Add intro comments.
1715         <m_line, m_start_of_line>: In-class initialize, and add describing
1716         comment.
1717
1718 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1719
1720         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1721         variable names.
1722         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1723
1724 2019-03-18  Pedro Alves  <palves@redhat.com>
1725             Eli Zaretskii <eliz@gnu.org>
1726
1727         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1728         m_line and m_start_of_line.
1729
1730 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1731
1732         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1733         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1734         it returns a newline.  This fixes a regression in TU mode, whereby
1735         the next line is output on the same screen line as the user input.
1736
1737 2019-03-18  Tom Tromey  <tromey@adacore.com>
1738
1739         * minsyms.c (minimal_symbol_reader::install): Remove call to
1740         obstack_blank.
1741
1742 2019-03-18  Pedro Alves  <palves@redhat.com>
1743
1744         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1745         New globals.
1746         (apply_style): New, factored out from ...
1747         (apply_ansi_escape): ... this.  Handle reverse video mode.
1748         (tui_set_reverse_mode): New function.
1749         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1750         * tui/tui-winsource.c (tui_show_source_line): Use
1751         tui_set_reverse_mode instead of setting A_STANDOUT.
1752         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1753         New setter methods.
1754
1755 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1756
1757         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1758         Handle tabs.
1759
1760 2019-03-18  Tom Tromey  <tromey@adacore.com>
1761
1762         * ada-lang.c (empty_array): Add "high" parameter.
1763         (ada_evaluate_subexp): Update.
1764
1765 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1766
1767         * unittests/string_view-selftests.c: Define
1768         _initialize_string_view_selftests unconditionally.
1769
1770 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1771
1772         PR gdb/24350
1773         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1774
1775 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1776
1777         PR gdb/24351
1778         * windows-nat.c (display_selector): Fix format specifiers.
1779
1780 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1781
1782         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1783         tui_refill_source_window instead of tui_refresh_win, to update the
1784         current execution line.  This fixes redisplay of the current line
1785         when stepping through the code with "next" or "step".
1786
1787 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1788
1789         * source-cache.c (source_cache::get_source_lines): Call
1790         find_source_lines to initialize s->nlines.  This fixes vertical
1791         scrolling of TUI source window when the DOWN arrow is pressed.
1792
1793 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1794
1795         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1796         linux-thread-db.c (_initialize_thread_db): Likewise.
1797
1798 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1799
1800         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1801         wclrtoeol in tui_show_source_line".  This reverts changes made in
1802         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1803
1804 2019-03-15  Tom Tromey  <tom@tromey.com>
1805
1806         * symtab.h (struct minimal_symbol): Derive from
1807         general_symbol_info.
1808         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1809         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1810         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1811         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1812         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1813         (MSYMBOL_SEARCH_NAME): Update.
1814         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1815         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1816         * minsyms.c (minimal_symbol_reader::record_full): Update.
1817
1818 2019-03-15  Tom Tromey  <tom@tromey.com>
1819
1820         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1821
1822 2019-03-15  Tom Tromey  <tom@tromey.com>
1823
1824         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1825         unique_xmalloc_ptr.
1826         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1827         Update.
1828         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1829         (build_minimal_symbol_hash_tables)
1830         (minimal_symbol_reader::install): Update.
1831
1832 2019-03-15  Tom Tromey  <tom@tromey.com>
1833
1834         * symtab.c (create_demangled_names_hash): Update.
1835         (symbol_set_names): Update.
1836         * objfiles.h (struct objfile_per_bfd_storage)
1837         <demangled_names_hash>: Now an htab_up.
1838         * objfiles.c (objfile_per_bfd_storage): Simplify.
1839
1840 2019-03-15  Tom Tromey  <tom@tromey.com>
1841
1842         * objfiles.h (struct objfile_per_bfd_storage): Declare
1843         destructor.
1844         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1845         New.
1846         (get_objfile_bfd_data): Use new.  Don't initialize
1847         language_of_main.
1848         (free_objfile_per_bfd_storage): Remove.
1849         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1850
1851 2019-03-15  Tom Tromey  <tom@tromey.com>
1852
1853         * symfile.c (reread_symbols): Update.
1854         * objfiles.c (objfile::objfile): Update.
1855         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1856         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1857         comment.
1858         (minimal_symbol_reader::install): Update.
1859         (terminate_minimal_symbol_table): Remove.
1860         * jit.c (jit_object_close_impl): Update.
1861
1862 2019-03-15  Tom Tromey  <tom@tromey.com>
1863
1864         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1865         initializations.
1866
1867 2019-03-15  Tom Tromey  <tom@tromey.com>
1868
1869         * objfiles.h (struct objfile_per_bfd_storage)
1870         <demangled_hash_languages>: Now a bitset.
1871         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1872         (lookup_minimal_symbol): Update.
1873
1874 2019-03-15  Tom Tromey  <tom@tromey.com>
1875
1876         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1877         Don't return the symbol.
1878         * coffread.c (record_minimal_symbol): Use record_full.
1879
1880 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1881
1882         The MS-Windows port of ncurses fails to switch to a color pair if
1883         one or both of the colors are the implicit default colors.  This
1884         change records the default colors when TUI is initialized, and
1885         then specifies them explicitly when a color pair uses the default
1886         colors.  This allows color styling in TUI mode on MS-Windows.
1887
1888         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1889         ncurses_norm_attr.
1890         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1891         colors in ncurses_norm_attr.
1892         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1893         "none", replace it with the default color recorded in
1894         ncurses_norm_attr.
1895
1896 2019-03-14  Tom Tromey  <tromey@adacore.com>
1897
1898         * source-cache.h (class source_cache) <get_source_lines>: Return
1899         std::string.
1900         * source-cache.c (source_cache::extract_lines): Handle case where
1901         first_pos==npos.  Return std::string.
1902         (source_cache::get_source_lines): Update.
1903
1904 2019-03-14  Tom Tromey  <tromey@adacore.com>
1905
1906         * NEWS: Add item for "style sources" commands.
1907         * source-cache.c (source_cache::get_source_lines): Check
1908         source_styling.
1909         * cli/cli-style.c (source_styling): New global.
1910         (_initialize_cli_style): Add "style sources" commands.
1911         (show_style_sources): New function.
1912         * cli/cli-style.h (source_styling): Declare.
1913
1914 2019-03-14  Pedro Alves  <palves@redhat.com>
1915             Tom Tromey  <tromey@adacore.com>
1916
1917         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1918         * tui/tui-winsource.c (tui_refill_source_window): New function,
1919         from...
1920         (tui_horizontal_source_scroll): ... here.  Move some logic.
1921         * cli/cli-style.c (set_style_enabled): Notify new observable.
1922         * tui/tui-hooks.c (tui_redisplay_source): New function.
1923         (tui_attach_detach_observers): Attach or detach
1924         tui_redisplay_source.
1925         * observable.h (source_styling_changed): New observable.
1926         * observable.c: Define source_styling_changed observable.
1927
1928 2019-03-13  Tom Tromey  <tromey@adacore.com>
1929
1930         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1931         (i386_gnu_nat_target::store_registers): Update.
1932         * target-debug.h (target_debug_print_std_string): New macro.
1933         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1934         * windows-tdep.c (display_one_tib): Update.
1935         * tui/tui-stack.c (tui_make_status_line): Update.
1936         * top.c (print_inferior_quit_action): Update.
1937         * thread.c (thr_try_catch_cmd): Update.
1938         (add_thread_with_info): Update.
1939         (thread_target_id_str): Update.
1940         (thr_try_catch_cmd): Update.
1941         (thread_command): Update.
1942         (thread_find_command): Update.
1943         * record-btrace.c (record_btrace_target::info_record)
1944         (record_btrace_resume_thread, record_btrace_target::resume)
1945         (record_btrace_cancel_resume, record_btrace_step_thread)
1946         (record_btrace_target::wait, record_btrace_target::wait)
1947         (record_btrace_target::wait, record_btrace_target::stop): Update.
1948         * progspace.c (print_program_space): Update.
1949         * process-stratum-target.c
1950         (process_stratum_target::thread_address_space): Update.
1951         * linux-fork.c (linux_fork_mourn_inferior)
1952         (detach_checkpoint_command, info_checkpoints_command)
1953         (linux_fork_context): Update.
1954         (linux_fork_detach): Update.
1955         (class scoped_switch_fork_info): Update.
1956         (delete_checkpoint_command): Update.
1957         * infrun.c (follow_fork_inferior): Update.
1958         (follow_fork_inferior): Update.
1959         (proceed_after_vfork_done): Update.
1960         (handle_vfork_child_exec_or_exit): Update.
1961         (follow_exec): Update.
1962         (displaced_step_prepare_throw): Update.
1963         (displaced_step_restore): Update.
1964         (start_step_over): Update.
1965         (resume_1): Update.
1966         (clear_proceed_status_thread): Update.
1967         (proceed): Update.
1968         (print_target_wait_results): Update.
1969         (do_target_wait): Update.
1970         (context_switch): Update.
1971         (stop_all_threads): Update.
1972         (restart_threads): Update.
1973         (finish_step_over): Update.
1974         (handle_signal_stop): Update.
1975         (switch_back_to_stepped_thread): Update.
1976         (keep_going_pass_signal): Update.
1977         (print_exited_reason): Update.
1978         (normal_stop): Update.
1979         * inferior.c (inferior_pid_to_str): Change return type.
1980         (print_selected_inferior): Update.
1981         (add_inferior): Update.
1982         (detach_inferior): Update.
1983         * dummy-frame.c (fprint_dummy_frames): Update.
1984         * dcache.c (dcache_info_1): Update.
1985         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1986         (btrace_fetch, btrace_clear): Update.
1987         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1988         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1989         type.
1990         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1991         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1992         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1993         * gdbarch.c, gdbarch.h: Rebuild.
1994         * gdbarch.sh (core_pid_to_str): Change return type.
1995         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1996         return type.
1997         (windows_nat_target::pid_to_str): Change return type.
1998         (windows_delete_thread): Update.
1999         (windows_nat_target::attach): Update.
2000         (windows_nat_target::files_info): Update.
2001         * target-delegates.c: Rebuild.
2002         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2003         return type.
2004         (sol_thread_target::pid_to_str): Change return type.
2005         * remote.c (class remote_target) <pid_to_str>: Change return
2006         type.
2007         (remote_target::pid_to_str): Change return type.
2008         (extended_remote_target::attach, remote_target::remote_stop_ns)
2009         (remote_target::remote_notif_remove_queued_reply)
2010         (remote_target::push_stop_reply, remote_target::disable_btrace):
2011         Update.
2012         (extended_remote_target::attach): Update.
2013         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2014         type.
2015         (gdbsim_target::pid_to_str): Change return type.
2016         * ravenscar-thread.c (struct ravenscar_thread_target)
2017         <pid_to_str>: Change return type.
2018         (ravenscar_thread_target::pid_to_str): Change return type.
2019         * procfs.c (class procfs_target) <pid_to_str>: Change return
2020         type.
2021         (procfs_target::pid_to_str): Change return type.
2022         (procfs_target::attach): Update.
2023         (procfs_target::detach): Update.
2024         (procfs_target::fetch_registers): Update.
2025         (procfs_target::store_registers): Update.
2026         (procfs_target::wait): Update.
2027         (procfs_target::files_info): Update.
2028         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2029         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2030         return type.
2031         (nto_procfs_target::pid_to_str): Change return type.
2032         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2033         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2034         return type.
2035         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2036         (exit_lwp): Update.
2037         (attach_proc_task_lwp_callback, get_detach_signal)
2038         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2039         (linux_nat_target::resume, wait_lwp, stop_callback)
2040         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2041         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2042         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2043         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2044         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2045         type.
2046         (inf_ptrace_target::attach): Update.
2047         (inf_ptrace_target::files_info): Update.
2048         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2049         type.
2050         (go32_nat_target::pid_to_str): Change return type.
2051         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2052         (gnu_nat_target::wait): Update.
2053         (gnu_nat_target::wait): Update.
2054         (gnu_nat_target::resume): Update.
2055         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2056         (fbsd_nat_target::wait): Update.
2057         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2058         type.
2059         (darwin_nat_target::attach): Update.
2060         * corelow.c (class core_target) <pid_to_str>: Change return type.
2061         (core_target::pid_to_str): Change return type.
2062         * target.c (normal_pid_to_str): Change return type.
2063         (default_pid_to_str): Likewise.
2064         (target_pid_to_str): Change return type.
2065         (target_translate_tls_address): Update.
2066         (target_announce_detach): Update.
2067         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2068         return type.
2069         (bsd_uthread_target::pid_to_str): Change return type.
2070         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2071         type.
2072         (bsd_kvm_target::pid_to_str): Change return type.
2073         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2074         return type.
2075         (aix_thread_target::pid_to_str): Change return type.
2076         * target.h (struct target_ops) <pid_to_str>: Change return type.
2077         (target_pid_to_str, normal_pid_to_str): Likewise.
2078         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2079         type.
2080         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2081         type.
2082         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2083         return type.
2084         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2085         type.
2086         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2087         type.
2088         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2089         return type.
2090
2091 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2092
2093         * NEWS: Mention that the new default MI version is 3.  Mention
2094         changes to the output of commands and events that deal with
2095         multi-location breakpoints.
2096         * breakpoint.c: Include "mi/mi-out.h".
2097         (print_one_breakpoint): Change output syntax if using MI version
2098         >= 3.
2099         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2100         New.
2101         (mi_multi_location_breakpoint_output_fixed): New.
2102         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2103         (mi_cmd_fix_multi_location_breakpoint_output): New.
2104         (mi_multi_location_breakpoint_output_fixed): New.
2105         * mi/mi-cmds.c (mi_cmds): Register command
2106         -fix-multi-location-breakpoint-output.
2107         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2108         interpreter "mi".
2109
2110 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2111
2112         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2113         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2114         instantiate mi_ui_out based on interpreter name.
2115         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2116         * mi/mi-main.c (mi_load_progress): Likewise.
2117
2118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2119
2120         * NEWS: Combine separate "New targets" sections for 8.3.
2121
2122 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2123
2124         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2125         (ppcfbsd_init_abi): Install gdbarch
2126         "fetch_tls_load_module_address" and "get_thread_local_address"
2127         methods.
2128
2129 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2130
2131         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2132         (riscv_fbsd_init_abi): Install gdbarch
2133         "fetch_tls_load_module_address" and "get_thread_local_address"
2134         methods.
2135
2136 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2137
2138         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2139         (i386fbsd_init_abi): Install gdbarch
2140         "fetch_tls_load_module_address" and "get_thread_local_address"
2141         methods.
2142
2143 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2144
2145         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2146         (amd64fbsd_init_abi): Install gdbarch
2147         "fetch_tls_load_module_address" and "get_thread_local_address"
2148         methods.
2149
2150 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2151
2152         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2153         (struct fbsd_pspace_data): New type.
2154         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2155         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2156         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2157         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2158         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2159
2160 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2161
2162         * gdbtypes.c (lookup_struct_elt): New function.
2163         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2164         * gdbtypes.h (struct struct_elt): New type.
2165         (lookup_struct_elt): New prototype.
2166
2167 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2168
2169         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2170         remove disabled code block.
2171
2172 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2173
2174         * gdbarch.sh (get_thread_local_address): New method.
2175         * gdbarch.h, gdbarch.c: Regenerate.
2176         * target.c (target_translate_tls_address): Use
2177         gdbarch_get_thread_local_address if present instead of
2178         target::get_thread_local_address.
2179
2180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2181
2182         * target.h (target::get_thread_local_address): Update comment.
2183
2184 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2185
2186         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2187         objfile->separate_debug_objfile_backlink if not NULL.
2188
2189 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2190
2191         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2192         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2193         (amd64bsd_store_inferior_registers): Likewise.
2194         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2195         Enable segment base registers.
2196         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2197         PT_GETFSBASE and PT_GETGSBASE.
2198         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2199         PT_SETGSBASE.
2200         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2201         segment base registers.
2202         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2203
2204 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2205
2206         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2207         Update calls to i386_target_description to add 'segments'
2208         parameter.
2209         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2210         add segment base registers.
2211         * arch/i386.c (i386_create_target_description): Add 'segments'
2212         parameter to enable segment base registers.
2213         * arch/i386.h (i386_create_target_description): Likewise.
2214         * features/i386/32bit-segments.xml: New file.
2215         * features/i386/32bit-segments.c: Generate.
2216         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2217         call to i386_target_description to add 'segments' parameter.
2218         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2219         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2220         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2221         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2222         if feature is present.
2223         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2224         Add 'segments' parameter to call to i386_target_description.
2225         (i386_target_description): Add 'segments' parameter to enable
2226         segment base registers.
2227         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2228         to call to i386_target_description.
2229         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2230         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2231         Define I386_NUM_REGS.
2232         (i386_target_description): Add 'segments' parameter to enable
2233         segment base registers.
2234
2235 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2236
2237         PR/24325
2238         * source-cache.c: #undef open and close, to avoid unresolved
2239         externals during linking.
2240
2241 2019-03-12  Tom Tromey  <tromey@adacore.com>
2242
2243         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2244         const.  Add initializers.
2245         (_initialize_remote): Don't initialize ptid globals.
2246
2247 2019-03-12  Pedro Alves  <palves@redhat.com>
2248
2249         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2250
2251 2019-03-12  Pedro Alves  <palves@redhat.com>
2252
2253         * cp-name-parser.y (main): Remove unused 'len' variable.
2254
2255 2019-03-12  Tom Tromey  <tromey@adacore.com>
2256
2257         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2258         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2259
2260 2019-03-12  Tom Tromey  <tromey@adacore.com>
2261
2262         * linux-nat.c (iterate_over_lwps): Update.
2263         (stop_callback): Remove parameter.
2264         (stop_wait_callback, detach_callback, resume_set_callback)
2265         (select_singlestep_lwp_callback, set_ignore_sigint)
2266         (status_callback, resumed_callback, resume_clear_callback)
2267         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2268         data parameter.
2269         (linux_nat_target::detach, linux_nat_target::resume)
2270         (linux_stop_and_wait_all_lwps, select_event_lwp)
2271         (linux_nat_filter_event, linux_nat_wait_1)
2272         (linux_nat_target::kill, linux_nat_target::stop)
2273         (linux_nat_target::stop): Update.
2274         (linux_nat_resume_callback): Change type.
2275         (resume_stopped_resumed_lwps, count_events_callback)
2276         (select_event_lwp_callback): Likewise.
2277         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2278         * arm-linux-nat.c (struct update_registers_data): Remove.
2279         (update_registers_callback): Change type.
2280         (arm_linux_insert_hw_breakpoint1): Update.
2281         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2282         parameter.
2283         (x86_linux_dr_set_addr): Update.
2284         (x86_linux_dr_set_control): Update.
2285         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2286         (iterate_over_lwps): Use gdb::function_view.
2287         * nat/aarch64-linux-hw-point.c (struct
2288         aarch64_dr_update_callback_param): Remove.
2289         (debug_reg_change_callback): Change type.
2290         (aarch64_notify_debug_reg_change): Update.
2291         * s390-linux-nat.c (s390_refresh_per_info): Update.
2292
2293 2019-03-11  Tom Tromey  <tromey@adacore.com>
2294
2295         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2296         redundant assignment to "this_cu".
2297
2298 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2299
2300         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2301
2302 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2303
2304         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2305         from...
2306         (rank_one_type): ... this.
2307
2308 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2309
2310         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2311         from...
2312         (rank_one_type): ... this.
2313
2314 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2315
2316         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2317         from...
2318         (rank_one_type): ... this.
2319
2320 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2321
2322         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2323         from...
2324         (rank_one_type): ... this.
2325
2326 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2327
2328         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2329         from...
2330         (rank_one_type): ... this.
2331
2332 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2333
2334         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2335         from...
2336         (rank_one_type): ... this.
2337
2338 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2339
2340         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2341         from...
2342         (rank_one_type): ... this.
2343
2344 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2345
2346         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2347         from...
2348         (rank_one_type): ... this.
2349
2350 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2351
2352         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2353         from...
2354         (rank_one_type): ... this.
2355
2356 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2357
2358         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2359         from...
2360         (rank_one_type): ... this.
2361
2362 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2363
2364         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2365         from...
2366         (rank_one_type): ... this.
2367
2368 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2369
2370         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2371         from...
2372         (rank_one_type): ... this.
2373
2374 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2375
2376         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2377         inferior-events' shows the example events.
2378
2379 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2380
2381         Support styling on native MS-Windows console
2382
2383         PR/24315
2384         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2385         on MS-Windows if $TERM is not defined.
2386
2387         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2388
2389         * posix-hdep.c (gdb_console_fputs):
2390         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2391         functions.
2392         * ui-file.h (gdb_console_fputs): Add prototype.
2393
2394         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2395         back to fputs only if the former returns zero.
2396
2397 2019-03-07  Tom Tromey  <tom@tromey.com>
2398
2399         * symmisc.c (print_symbol_bcache_statistics): Update.
2400         (print_objfile_statistics): Update.
2401         * symfile.c (allocate_symtab): Update.
2402         * stabsread.c: Don't include bcache.h.
2403         * psymtab.h (struct psymbol_bcache): Don't declare.
2404         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2405         (psymbol_bcache_init, psymbol_bcache_free)
2406         (psymbol_bcache_get_bcache): Don't declare.
2407         * psymtab.c (struct psymbol_bcache): Remove.
2408         (psymtab_storage::psymtab_storage): Update.
2409         (psymtab_storage::~psymtab_storage): Update.
2410         (psymbol_bcache_init, psymbol_bcache_free)
2411         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2412         (add_psymbol_to_bcache): Update.
2413         (allocate_psymtab): Update.
2414         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2415         macro_cache>: No longer pointers.
2416         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2417         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2418         * macrotab.c (macro_bcache): Update.
2419         * macroexp.c: Don't include bcache.h.
2420         * gdbtypes.c (check_types_worklist): Update.
2421         (types_deeply_equal): Remove TRY/CATCH.  Update.
2422         * elfread.c (elf_symtab_read): Update.
2423         * dwarf2read.c: Don't include bcache.h.
2424         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2425         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2426         (print_bcache_statistics, bcache_memory_used): Don't declare.
2427         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2428         methods.  Rename all data members.
2429         * bcache.c (struct bcache): Move to bcache.h.
2430         (bcache::expand_hash_table): Rename from expand_hash_table.
2431         (bcache): Remove.
2432         (bcache::insert): Rename from bcache_full.
2433         (bcache::compare): Rename from bcache_compare.
2434         (bcache_xmalloc): Remove.
2435         (bcache::~bcache): Rename from bcache_xfree.
2436         (bcache::print_statistics): Rename from print_bcache_statistics.
2437         (bcache::memory_used): Rename from bcache_memory_used.
2438
2439 2019-03-07  Pedro Alves  <palves@redhat.com>
2440
2441         * infrun.c (normal_stop): Also check for
2442         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2443
2444 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2445
2446         * f-lang.c (value_from_host_double): Moved to...
2447         * value.c (value_from_host_double): ...here.
2448         * value.h (value_from_host_double): Declare.
2449         * guile/scm-math.c (vlscm_convert_typed_number): Use
2450         value_from_host_double.
2451         (vlscm_convert_number): Likewise.
2452         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2453         * python/py-value.c (convert_value_from_python): Likewise.
2454
2455 2019-03-06  Tom Tromey  <tom@tromey.com>
2456
2457         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2458
2459 2019-03-06  Tom Tromey  <tom@tromey.com>
2460
2461         * utils.h (free_current_contents): Don't declare.
2462         * utils.c (free_current_contents): Remove.
2463
2464 2019-03-06  Tom Tromey  <tom@tromey.com>
2465
2466         * top.c (quit_force): Update.
2467         * main.c (captured_command_loop): Update.
2468         * common/new-op.c (operator new): Update.
2469         * common/common-exceptions.c (struct catcher)
2470         <save_cleanup_chain>: Remove member.
2471         (exceptions_state_mc_init): Update.
2472         (exception_try_scope_entry): Return nullptr.
2473         (exception_try_scope_exit, exception_rethrow)
2474         (throw_exception_sjlj, throw_exception_cxx): Update.
2475         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2476         (all_cleanups, do_cleanups, discard_cleanups)
2477         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2478         (restore_cleanups, restore_final_cleanups): Don't declare.
2479         (do_final_cleanups): Remove parameter.
2480         * common/cleanups.c (cleanup_chain, make_cleanup)
2481         (make_cleanup_dtor, all_cleanups, do_cleanups)
2482         (discard_my_cleanups, discard_cleanups)
2483         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2484         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2485         (null_cleanup): Remove.
2486         (do_final_cleanups): Remove parameter.
2487
2488 2019-03-06  Tom Tromey  <tom@tromey.com>
2489
2490         * remote.c (remote_target::remote_parse_stop_reply): Use
2491         unique_xmalloc_ptr.
2492
2493 2019-03-06  Tom Tromey  <tom@tromey.com>
2494
2495         * stabsread.c (struct stabs_field_info): Rename from field_info.
2496         <list, fnlist>: Add initializers.
2497         <obstack>: New member.
2498         (read_member_functions, read_struct_fields, read_baseclasses):
2499         Allocate on obstack.  Don't use cleanups.
2500         (read_one_struct_field, read_member_functions, read_struct_fields)
2501         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2502         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2503         (read_struct_type): Update.
2504
2505 2019-03-06  Tom Tromey  <tom@tromey.com>
2506
2507         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2508         * common/filestuff.h (make_cleanup_close): Don't declare.
2509         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2510         Remove.
2511
2512 2019-03-06  Tom Tromey  <tom@tromey.com>
2513
2514         * solib-aix.c: Use make_scope_exit.
2515
2516 2019-03-06  Tom Tromey  <tom@tromey.com>
2517
2518         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2519         Use make_scope_exit.
2520
2521 2019-03-06  Tom Tromey  <tom@tromey.com>
2522
2523         * solib-svr4.c (disable_probes_interface): Remove parameter.
2524         (svr4_handle_solib_event): Use make_scope_exit.
2525
2526 2019-03-06  Tom Tromey  <tom@tromey.com>
2527
2528         * remote.c (struct stop_reply_deleter): Remove.
2529         (stop_reply_up): Update.
2530         (struct stop_reply): Derive from notif_event.  Don't typedef.
2531         <regcache>: Now a std::vector.
2532         (stop_reply_xfree): Remove.
2533         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2534         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2535         (remote_target::discard_pending_stop_replies): Use delete.
2536         (remote_target::remote_parse_stop_reply): Update.
2537         (remote_target::process_stop_reply): Update.
2538         * remote-notif.h (struct notif_event): Add virtual destructor.
2539         Remove "dtr" member.
2540         (struct notif_client) <alloc_event>: Return a unique_ptr.
2541         (notif_event_xfree): Don't declare.
2542         (notif_event_up): New typedef.
2543         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2544         (notif_event_xfree, do_notif_event_xfree): Remove.
2545         (remote_notif_state_xfree): Update.
2546
2547 2019-03-06  Tom Tromey  <tom@tromey.com>
2548
2549         * infrun.c (displaced_step_clear_cleanup): Now a
2550         forward_scope_exit type.
2551         (displaced_step_prepare_throw): Update.
2552         (displaced_step_fixup): Update.
2553
2554 2019-03-06  Tom Tromey  <tom@tromey.com>
2555
2556         * inferior.h (class inferior): Update comment.
2557         * gdbthread.h (class thread_info): Update comment.
2558
2559 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2560             Tom Tromey  <tom@tromey.com>
2561
2562         * stabsread.h (struct stab_section_list): Remove.
2563         (coffstab_build_psymtabs): Update.
2564         * dbxread.c (symbuf_sections): Now a std::vector.
2565         (sect_idx): New global.
2566         (fill_symbuf): Update.
2567         (coffstab_build_psymtabs): Change type of stabsects parameter.
2568         Update.
2569         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2570         std::vector.
2571         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2572         (coff_locate_sections): Update.
2573         (coff_symfile_read): Remove cleanups.  Update.
2574         (init_stringtab): Add storage parameter.
2575         (free_stringtab, free_stringtab_cleanup): Remove.
2576         (init_lineno): Add storage parameter.
2577         (free_linetab, free_linetab_cleanup): Remove.
2578
2579 2019-03-06  Pedro Alves  <palves@redhat.com>
2580
2581         * linux-fork.c (fork_info::clobber_regs): Delete.
2582         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2583         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2584         comment.  Adjust.
2585         (scoped_switch_fork_info::scoped_switch_fork_info)
2586         (checkpoint_command, linux_fork_context): Adjust
2587         fork_save_infrun_state calls.
2588
2589 2019-03-06  Pedro Alves  <palves@redhat.com>
2590
2591         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2592         (inf_has_multiple_threads): Return 'bool' and rewrite using
2593         inferior_info::threads().
2594
2595 2019-03-06  Pedro Alves  <palves@redhat.com>
2596
2597         * linux-fork.c: Include <list>.
2598         (fork_list): Now a std::list instance.
2599         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2600         (forks_exist_p, find_last_fork): Adjust.
2601         (new_fork): Delete.
2602         (one_fork_p): New.
2603         (add_fork): Adjust.
2604         (free_fork): Delete, folded into fork_info::~fork_info().
2605         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2606         Adjust.
2607         (init_fork_list): Delete.
2608         (linux_fork_killall, linux_fork_mourn_inferior)
2609         (linux_fork_detach, info_checkpoints_command): Adjust.
2610         (_initialize_linux_fork): No longer call init_fork_list.
2611
2612 2019-03-06  Pedro Alves  <palves@redhat.com>
2613
2614         * linux-fork.c (new_fork): New, split out of ...
2615         (add_fork): ... this.  Return void.  Move "first fork" special
2616         case from here, to ...
2617         (checkpoint_command): ... here.
2618         * linux-linux.h (add_fork): Return void.
2619
2620 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2621
2622         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2623
2624 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2625             Chris January  <chris.january@arm.com>
2626             David Lecomber  <david.lecomber@arm.com>
2627
2628         * f-exp.y: New token, UNOP_INTRINSIC.
2629         (exp): New pattern using UNOP_INTRINSIC token.
2630         (f77_keywords): Add 'abs' keyword.
2631         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2632         (value_from_host_double): New function.
2633         (evaluate_subexp_f): Support UNOP_ABS.
2634
2635 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2636
2637         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2638         types.
2639
2640 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2641
2642         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2643         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2644         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2645
2646 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2647
2648         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2649
2650 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2651             Chris January  <chris.january@arm.com>
2652
2653         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2654         * f-exp.y: Define 'KIND' token.
2655         (exp): New pattern for KIND expressions.
2656         (ptype): Handle types with a kind extension.
2657         (direct_abs_decl): Extend to spot kind extensions.
2658         (f77_keywords): Add 'kind' to the list.
2659         (push_kind_type): New function.
2660         (convert_to_kind_type): New function.
2661         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2662         * parse.c (operator_length_standard): Likewise.
2663         * parser-defs.h (enum type_pieces): Add tp_kind.
2664         * std-operator.def: Add UNOP_KIND.
2665
2666 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2667
2668         * f-exp.y (f_parse): Set yydebug.
2669
2670 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2671
2672         * f-lang.c (evaluate_subexp_f): New function.
2673         (exp_descriptor_f): New global.
2674         (f_language_defn): Use exp_descriptor_f instead of
2675         exp_descriptor_standard.
2676
2677 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * f-exp.y (struct token): Add comments.
2680         (dot_ops): Remove uppercase versions and the end marker.
2681         (f77_keywords): Likewise.
2682         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2683         entries in the dot_ops array are case insensitive, and use
2684         strncasecmp to compare strings.  Also some whitespace cleanup in
2685         this area.  Similar for the f77_keywords array, except entries in
2686         this list might be case sensitive.
2687
2688 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2689
2690         * f-exp.y (struct f77_boolean_val): Add comments.
2691         (boolean_values): Remove uppercase versions, and end marker.
2692         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2693         and use strncasecmp to achieve case insensitivity.  Additionally,
2694         perform whitespace cleanup around this code.
2695
2696 2019-03-06  Tom Tromey  <tromey@adacore.com>
2697
2698         * remote-sim.c (gdbsim_target_open): Use result of
2699         gdb_argv::release.
2700
2701 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2702         Dirk Schubert  <dirk.schubert@arm.com>
2703         Chris January  <chris.january@arm.com>
2704
2705         * eval.c (evaluate_subexp_standard): Call Fortran argument
2706         wrapping logic.
2707         * f-lang.c (struct value): A value which can be passed into a
2708         Fortran function call.
2709         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2710         where appropriate.
2711         (struct type): Value ready for a Fortran function call.
2712         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2713         is needed.
2714         * f-lang.h (fortran_argument_convert): Declaration.
2715         (fortran_preserve_arg_pointer): Declaration.
2716         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2717
2718 2019-03-05  Tom Tromey  <tromey@adacore.com>
2719
2720         * python/py-prettyprint.c (print_string_repr): Remove #if.
2721         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2722
2723 2019-03-05  Tom Tromey  <tromey@adacore.com>
2724
2725         * target.c (the_dummy_target): Move later.  Change type to
2726         "dummy_target".
2727         (initialize_targets): Don't initialize the_dummy_target.
2728
2729 2019-03-05  Tom Tromey  <tromey@adacore.com>
2730
2731         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2732         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2733
2734 2019-03-05  Tom Tromey  <tromey@adacore.com>
2735
2736         * windows-nat.c (windows_nat_target::attach)
2737         (windows_nat_target::detach): Don't call gdb_flush.
2738         * valprint.c (generic_val_print, val_print, val_print_string):
2739         Don't call gdb_flush.
2740         * utils.c (defaulted_query): Don't call gdb_flush.
2741         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2742         * target.c (target_announce_detach): Don't call gdb_flush.
2743         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2744         * remote.c (extended_remote_target::attach): Don't call
2745         gdb_flush.
2746         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2747         * printcmd.c (do_examine): Don't call gdb_flush.
2748         (info_display_command): Don't call gdb_flush.
2749         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2750         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2751         * memattr.c (info_mem_command): Don't call gdb_flush.
2752         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2753         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2754         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2755         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2756         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2757         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2758         (gnu_nat_target::detach): Don't call gdb_flush.
2759         * f-valprint.c (f_val_print): Don't call gdb_flush.
2760         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2761         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2762         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2763         gdb_flush.
2764         * c-valprint.c (c_val_print): Don't call gdb_flush.
2765         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2766
2767 2019-03-05  Tom Tromey  <tromey@adacore.com>
2768
2769         * varobj.c (update_dynamic_varobj_children): Update.
2770         (install_default_visualizer): Use reset, not release.
2771         * value.c (set_internalvar): Update.
2772         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2773         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2774         ATTRIBUTE_UNUSED_RESULT.
2775
2776 2019-03-05  Tom Tromey  <tromey@adacore.com>
2777
2778         * remote.c (class scoped_remote_fd) <release>: Add
2779         ATTRIBUTE_UNUSED_RESULT.
2780
2781 2019-03-05  Tom Tromey  <tromey@adacore.com>
2782
2783         * macroexp.c (struct macro_buffer) <release>: Add
2784         ATTRIBUTE_UNUSED_RESULT.
2785
2786 2019-03-05  Tom Tromey  <tromey@adacore.com>
2787
2788         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2789         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2790         ATTRIBUTE_UNUSED_RESULT.
2791
2792 2019-03-05  Tom Tromey  <tromey@adacore.com>
2793
2794         * common/scoped_fd.h (class scoped_fd) <release>: Add
2795         ATTRIBUTE_UNUSED_RESULT.
2796
2797 2019-03-05  Tom Tromey  <tromey@adacore.com>
2798
2799         * parser-defs.h (struct parser_state) <release>: Add
2800         ATTRIBUTE_UNUSED_RESULT.
2801
2802 2019-03-05  Tom Tromey  <tromey@adacore.com>
2803
2804         * utils.h (class gdb_argv) <release>: Add
2805         ATTRIBUTE_UNUSED_RESULT.
2806         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2807
2808 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2809
2810         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2811         for-loop range, to avoid compiler warnings.
2812
2813         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2814         avoid compiler warnings about unused variables.
2815
2816         * NEWS: Mention end of support for native debugging on MS-Windows
2817         before XP.
2818
2819         PR gdb/24292
2820         * common/netstuff.c:
2821         * gdbserver/gdbreplay.c
2822         * gdbserver/remote-utils.c:
2823         * ser-tcp.c:
2824         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2825         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2826         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2827         'getaddrinfo' and 'freeaddrinfo' were not available before
2828         Windows XP, and mingw.org's MinGW headers by default define
2829         _WIN32_WINNT to 0x500.
2830
2831 2019-03-01  Gary Benson <gbenson@redhat.com>
2832
2833         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2834
2835 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2836             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2837
2838         PR gdb/8527
2839         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2840         set_sigint_trap, clear_sigint_trap.
2841
2842 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2843
2844         * target.c (target_detach): Clear the regcache and the
2845         frame cache.
2846
2847 2019-02-27  Pedro Alves  <palves@redhat.com>
2848
2849         * utils.c (set_screen_size): When we cap the height/width sizes,
2850         tweak the corresponding command variable to show "unlimited":
2851
2852 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2853             Pedro Alves  <palves@redhat.com>
2854
2855         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2856         before calling rl_set_screen_size.
2857
2858 2019-02-27  Tom Tromey  <tromey@adacore.com>
2859
2860         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2861         define.
2862         * python/py-value.c: Remove Python 2.4 workaround.
2863         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2864         workaround.
2865         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2866         Python 2.4 workaround.
2867         * python/python-internal.h: Remove Python 2.4 comment.
2868         (Py_ssize_t): Don't define.
2869         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2870         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2871         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2872         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2873         * python/python.c (do_start_initialization): Remove Python 2.4
2874         workaround.
2875         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2876         (print_children): Remove Python 2.4 workaround.
2877         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2878         workaround.
2879         (CHARBUFFERPROC_NAME): Remove.
2880         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2881         Python 2.4 workaround.
2882
2883 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2884
2885         * NEWS: Note minimum Python version.
2886
2887 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2888
2889         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2890         code from these functions.  Remove corresponding ifdefs.  Use
2891         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2892         Remove gotos and target of gotos.
2893         (infpy_search_memory): Likewise.
2894
2895 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2896
2897         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2898         (hppa_gdbarch_init): Don't register deleted functions with
2899         gdbarch.
2900
2901 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2902
2903         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2904         (h8300_unwind_sp): Delete.
2905         (h8300_dummy_id): Delete.
2906         (h8300_gdbarch_init): Don't register deleted functions with
2907         gdbarch.
2908
2909 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2910
2911         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2912         (ft32_unwind_pc): Delete.
2913         (ft32_unwind_sp): Delete.
2914         (ft32_gdbarch_init): Don't register deleted functions with
2915         gdbarch.
2916
2917 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2918
2919         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2920         (frv_unwind_pc): Delete.
2921         (frv_unwind_sp): Delete.
2922         (frv_gdbarch_init): Don't register deleted functions with
2923         gdbarch.
2924
2925 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2926
2927         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2928         (riscv_unwind_pc): Delete.
2929         (riscv_unwind_sp): Delete.
2930         (riscv_gdbarch_init): Don't register deleted functions with
2931         gdbarch.
2932
2933 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2934
2935         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2936         (csky_unwind_pc): Delete.
2937         (csky_unwind_sp): Delete.
2938         (csky_gdbarch_init): Don't register deleted functions with
2939         gdbarch.
2940
2941 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2942
2943         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2944         (cris_unwind_pc): Delete.
2945         (cris_unwind_sp): Delete.
2946         (cris_gdbarch_init): Don't register deleted functions with
2947         gdbarch.
2948
2949 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2952         (bfin_unwind_pc): Delete.
2953         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2954
2955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2956
2957         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2958         (arm_unwind_pc): Delete.
2959         (arm_unwind_sp): Delete.
2960         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2961
2962 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2963
2964         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2965         (arc_unwind_pc): Delete.
2966         (arc_unwind_sp): Delete.
2967         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2968
2969 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2970
2971         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2972         (alpha_unwind_pc): Delete.
2973         (alpha_gdbarch_init): Don't register deleted functions with
2974         gdbarch.
2975
2976 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2977
2978         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2979         (aarch64_unwind_pc): Delete.
2980         (aarch64_unwind_sp): Delete.
2981         (aarch64_gdbarch_init): Don't register deleted functions with
2982         gdbarch.
2983
2984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2985
2986         * gdbtypes.c (type_align): Don't consider static members when
2987         computing structure alignment.
2988
2989 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2990
2991         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2992         return 0 for other types.
2993         * arch-utils.c (default_type_align): Always return 0.
2994         * gdbarch.h: Regenerate.
2995         * gdbarch.sh (type_align): Extend comment.
2996         * gdbtypes.c (type_align): Add additional comments, always call
2997         gdbarch_type_align before applying the default rules.
2998         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2999         generic code will then apply a suitable default.
3000         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3001         types, return 0 for other types.
3002
3003 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3004
3005         * NEWS: Create a new section for the next release branch.
3006         Rename the section of the current branch, now that it has
3007         been cut.
3008
3009 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3010
3011         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3012         * version.in: Bump version to 8.3.50.DATE-git.
3013
3014 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3015
3016         * aix-thread.c (ptid_cmp): Remove unused variable.
3017         (get_signaled_thread): Likewise.
3018         (store_regs_user_thread): Likewise.
3019         (store_regs_kernel_thread): Likewise.
3020         (fetch_regs_kernel_thread): Remove shadowed variable.
3021
3022 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3023
3024         * features/riscv/32bit-cpu.xml: Add register numbers.
3025         * features/riscv/32bit-fpu.c: Regenerate.
3026         * features/riscv/32bit-fpu.xml: Add register numbers.
3027         * features/riscv/64bit-cpu.xml: Add register numbers.
3028         * features/riscv/64bit-fpu.c: Regenerate.
3029         * features/riscv/64bit-fpu.xml: Add register numbers.
3030
3031 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3032
3033         * NEWS: Mention two argument form of gdb.Value constructor.
3034         * python/py-value.c (convert_buffer_and_type_to_value): New
3035         function.
3036         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3037         Add support for handling an optional second argument.  Call
3038         convert_buffer_and_type_to_value as appropriate.
3039         * python/python-internal.h (Py_buffer_deleter): New struct.
3040         (Py_buffer_up): New typedef.
3041
3042 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3043
3044         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3045         instead of releasing ownership.
3046
3047 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3048
3049         * dwarf2read.c (open_and_init_dwp_file): Call
3050         elf_numsections instead of bfd_count_sections to initialize
3051         dwp_file->num_sections.
3052
3053 2019-02-25  Tom Tromey  <tromey@adacore.com>
3054
3055         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3056
3057 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3058
3059         * gcore.in: Add '--readnever' option when invoking GDB.
3060
3061 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3062
3063         * MAINTAINERS: Update my email address.
3064
3065 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3066
3067         * build-id.c (build_id_to_debug_bfd_1): New function.
3068         (build_id_to_debug_bfd): Look for separate debug file in
3069         sysroot.
3070
3071 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3072
3073         * gdbarch.sh: Update the copyright year range that is placed into
3074         generated files.
3075
3076 2019-02-22  Keith Seitz  <keiths@redhat.com>
3077
3078         PR symtab/23853
3079         * linespec.c (create_sals_line_offset): Search for the default
3080         symtab's filename instead of its fullname.
3081
3082 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3083
3084         * NEWS: Update style defaults.
3085
3086 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3087
3088         * main.c (captured_main_1): Disable styling in batch mode.
3089
3090 2019-02-20  Tom Tromey  <tom@tromey.com>
3091
3092         * symtab.c (symtab_symbol_info): Fix typos.
3093
3094 2019-02-20  Tom Tromey  <tromey@adacore.com>
3095
3096         * findcmd.c (_initialize_mem_search): Use upper case for
3097         metasyntactic variables.
3098
3099 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3100
3101         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3102         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3103
3104 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3105
3106         * top.h (source_file_name): Change to std::string.
3107         * top.c (source_file_name): Likewise.
3108         (command_line_input): Adjust.
3109         * cli/cli-script.c (script_from_file): Adjust.
3110
3111 2019-02-19  Tom Tromey  <tromey@adacore.com>
3112
3113         * ravenscar-thread.c
3114         (ravenscar_thread_target::update_thread_list): Don't call
3115         ada_build_task_list.
3116         * ada-lang.h (ada_build_task_list): Don't declare.
3117         * ada-tasks.c (struct ada_tasks_inferior_data)
3118         <task_list_valid_p>: Now bool.
3119         (read_known_tasks, ada_task_list_changed)
3120         (ada_tasks_invalidate_inferior_data): Update.
3121         (read_known_tasks_array): Return bool.
3122         (read_known_tasks_list): Likewise.
3123         (read_known_tasks): Return void.
3124         (ada_build_task_list): Now static.
3125
3126 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3127
3128         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3129         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3130
3131 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3132
3133         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3134         variant for ada_tasks_pspace_data_handle and
3135         ada_tasks_inferior_data_handle.
3136         (ada_tasks_pspace_data_cleanup): New function.
3137         (ada_tasks_inferior_data_cleanup): New function.
3138
3139 2019-02-17  Tom Tromey  <tom@tromey.com>
3140
3141         * macrotab.h (macro_source_fullname): Return a std::string.
3142         * macrotab.c (macro_include, check_for_redefinition)
3143         (macro_undef, macro_lookup_definition, foreach_macro)
3144         (foreach_macro_in_scope): Update.
3145         (macro_source_fullname): Return a std::string.
3146         * macrocmd.c (show_pp_source_pos): Update.
3147
3148 2019-02-17  Tom Tromey  <tom@tromey.com>
3149
3150         * macrocmd.c (show_pp_source_pos): Style the file names.
3151
3152 2019-02-17  Tom Tromey  <tom@tromey.com>
3153
3154         PR tui/24197:
3155         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3156
3157 2019-02-17  Tom Tromey  <tom@tromey.com>
3158
3159         * ada-lang.c (user_select_syms): Use filtered printing.
3160         * utils.c (wrap_style): New global.
3161         (desired_style): Remove.
3162         (emit_style_escape): Add stream parameter.
3163         (set_output_style, reset_terminal_style, prompt_for_continue):
3164         Update.
3165         (flush_wrap_buffer): Only flush gdb_stdout.
3166         (wrap_here): Set wrap_style.
3167         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3168         treat escape sequences as a character.  Change when wrap buffer is
3169         flushed.
3170         (fputs_styled): Do not set the output style when the default is
3171         requested.
3172         * ui-style.h (struct ui_file_style) <is_default>: New method.
3173         * source.c (print_source_lines_base): Emit escape sequences in one
3174         piece.
3175
3176 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3177
3178         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3179         integers and enumeration types.
3180
3181 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3182
3183         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3184         instead of lookup_symbol_in_language
3185         (do_exact_match): New function.
3186         (ada_get_symbol_name_matcher): Return do_exact_match when
3187         doing a verbatim match.
3188
3189 2019-02-15  Tom Tromey  <tromey@adacore.com>
3190
3191         * ravenscar-thread.c (ravenscar_thread_target::resume)
3192         (ravenscar_thread_target::wait): Special case wildcard requests.
3193
3194 2019-02-15  Tom Tromey  <tromey@adacore.com>
3195
3196         * ravenscar-thread.c (base_ptid): Remove.
3197         (struct ravenscar_thread_target) <close>: New method.
3198         <m_base_ptid>: New member.
3199         <update_inferior_ptid, active_task, task_is_currently_active,
3200         runtime_initialized>: Declare methods.
3201         <ravenscar_thread_target>: Add constructor.
3202         (ravenscar_thread_target::task_is_currently_active)
3203         (ravenscar_thread_target::update_inferior_ptid)
3204         (ravenscar_runtime_initialized): Rename.  Now methods.
3205         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3206         (ravenscar_thread_target::update_thread_list): Update.
3207         (ravenscar_thread_target::active_task): Now method.
3208         (ravenscar_thread_target::store_registers)
3209         (ravenscar_thread_target::prepare_to_store)
3210         (ravenscar_thread_target::prepare_to_store)
3211         (ravenscar_thread_target::mourn_inferior): Update.
3212         (ravenscar_inferior_created): Use "new" to create target.
3213         (ravenscar_thread_target::get_ada_task_ptid): Update.
3214         (_initialize_ravenscar): Don't initialize base_ptid.
3215         (ravenscar_ops): Remove global.
3216
3217 2019-02-15  Tom Tromey  <tromey@adacore.com>
3218
3219         * target.h (push_target): Declare new overload.
3220         * target.c (push_target): New overload, taking an rvalue reference.
3221         * remote.c (remote_target::open_1): Use push_target overload.
3222         * corelow.c (core_target_open): Use push_target overload.
3223
3224 2019-02-15  Tom Tromey  <tromey@adacore.com>
3225
3226         * ravenscar-thread.c (is_ravenscar_task)
3227         (ravenscar_task_is_currently_active): Return bool.
3228         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3229         (_initialize_ravenscar): Remove "(void)".
3230         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3231         Return bool.
3232
3233 2019-02-15  Tom Tromey  <tromey@adacore.com>
3234
3235         * ravenscar-thread.c (ravenscar_runtime_initializer)
3236         (has_ravenscar_runtime, get_running_thread_id)
3237         (ravenscar_thread_target::resume): Fix indentation.
3238
3239 2019-02-15  Tom Tromey  <tromey@adacore.com>
3240
3241         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3242         from ravenscar_arch_ops.
3243         (sparc_ravenscar_ops::fetch_registers)
3244         (sparc_ravenscar_ops::store_registers): Now methods.
3245         (sparc_ravenscar_prepare_to_store): Remove.
3246         (sparc_ravenscar_ops): Redefine.
3247         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3248         methods and destructor.  Remove members.
3249         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3250         (ravenscar_thread_target::store_registers)
3251         (ravenscar_thread_target::prepare_to_store): Update.
3252         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3253         Remove.
3254         (struct ppc_ravenscar_powerpc_ops): Derive from
3255         ravenscar_arch_ops.
3256         (ppc_ravenscar_powerpc_ops::fetch_registers)
3257         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3258         (ppc_ravenscar_powerpc_ops): Redefine.
3259         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3260         (ppc_ravenscar_e500_ops::fetch_registers)
3261         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3262         (ppc_ravenscar_e500_ops): Redefine.
3263         * aarch64-ravenscar-thread.c
3264         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3265         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3266         (aarch64_ravenscar_fetch_registers)
3267         (aarch64_ravenscar_store_registers): Now methods.
3268         (aarch64_ravenscar_ops): Redefine.
3269
3270 2019-02-15  Tom Tromey  <tromey@adacore.com>
3271
3272         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3273         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3274         (ravenscar_thread_target::stopped_by_watchpoint)
3275         (ravenscar_thread_target::stopped_data_address)
3276         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3277
3278 2019-02-15  Tom Tromey  <tromey@adacore.com>
3279
3280         * ravenscar-thread.c: Fix some typos.
3281
3282 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3283             Tom Tromey  <tromey@adacore.com>
3284
3285         * ada-lang.c (ada_exception_sal): Change addr_string to a
3286         std::string.
3287         (create_ada_exception_catchpoint): Update.
3288
3289 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3290             Tom Tromey  <tromey@adacore.com>
3291
3292         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3293         (bp_location_ops): Remove.
3294         (base_breakpoint_allocate_location): Update.
3295         (free_bp_location): Update.
3296         * ada-lang.c (class ada_catchpoint_location)
3297         <ada_catchpoint_location>: Remove ops parameter.
3298         (ada_catchpoint_location_dtor): Remove.
3299         (ada_catchpoint_location_ops): Remove.
3300         (allocate_location_exception): Update.
3301         * breakpoint.h (struct bp_location_ops): Remove.
3302         (class bp_location) <bp_location>: Remove bp_location_ops
3303         parameter.
3304         <~bp_location>: Add destructor.
3305         <ops>: Remove.
3306
3307 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3308             Pedro Alves  <palves@redhat.com>
3309
3310         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3311         'PATH_MAX'.
3312
3313 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3314             Samuel Thibault  <samuel.thibault@gnu.org>
3315             Thomas Schwinge  <thomas@codesourcery.com>
3316
3317         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3318         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3319
3320 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3321
3322         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3323         (check_empty): Use "const char *".
3324
3325         * gnu-nat.c (gnu_nat_target::detach): Instead of
3326         'detach_inferior (pid)' call
3327         'detach_inferior (find_inferior_pid (pid))'.
3328
3329         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3330         'nat/fork-inferior.o'.
3331         * gnu-nat.c: #include "nat/fork-inferior.h".
3332
3333         * gnu-nat.c (gnu_nat_target::detach): Instead of
3334         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3335         * gnu-nat.h: #include "inf-child.h".
3336         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3337         'i386_gnu_nat_target::fetch_registers'.
3338         (gnu_store_registers): Rename/move to
3339         'i386_gnu_nat_target::store_registers'.
3340
3341         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3342         * gnu-nat.h (mach_thread_info): New function.
3343         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3344
3345         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3346
3347 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3348
3349         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3350
3351 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3352
3353         * windows-nat.c (windows_add_thread): Add new parameter
3354         "main_thread_p" with default value set to false.  Update
3355         function documentation as well as all callers.
3356         (windows_delete_thread): Likewise.
3357         (fake_create_process): Update call to windows_add_thread.
3358         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3359         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3360         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3361         call to windows_delete_thread.
3362
3363 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3364
3365         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3366
3367 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3368
3369         * symfile.c (find_separate_debug_file): Use canonical path of
3370         sysroot with child_path instead of gdb_sysroot if it is valid.
3371
3372 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3373
3374         * symfile.c (find_separate_debug_file): Use child_path to
3375         determine if an object file is under a sysroot.
3376
3377 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3378
3379         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3380         unittests/child-path-selftests.c.
3381         * common/pathstuff.c (child_path): New function.
3382         * common/pathstuff.h (child_path): New prototype.
3383         * unittests/child-path-selftests.c: New file.
3384
3385 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3386
3387         * symfile.c (find_separate_debug_file): Look for separate debug
3388         files in debug directories under the sysroot.
3389
3390 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3391
3392         * symtab.h (struct minimal_symbol data_p): New const method.
3393         (struct minimal_symbol text_p): Likewise.
3394         * symtab.c (output_source_filename): Use file name style
3395         to print file name.
3396         (print_symbol_info): Likewise.
3397         (print_msymbol_info): Use address style to print addresses.
3398         Use function name style to print executable text symbols.
3399         (expand_symtab_containing_pc): Use data_p.
3400         (find_pc_sect_compunit_symtab): Likewise.
3401
3402 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3403
3404         * breakpoint.c (describe_other_breakpoints): Use address style
3405         to print addresses.
3406         (say_where): Likewise.
3407
3408 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3409
3410         * ada-typeprint.c (print_func_type): Print function name
3411         style to print function name.
3412         * c-typeprint.c (c_print_type_1): Likewise.
3413
3414 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3415
3416         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3417         for execve.
3418
3419 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3420
3421         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3422         type_stack.
3423
3424 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3425
3426         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3427         TYPE_CODE_REF types.
3428
3429 2019-02-08  Jim Wilson  <jimw@sifive.com>
3430
3431         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3432         (riscv_linux_fregset): New.
3433         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3434
3435 2019-02-07  Tom Tromey  <tom@tromey.com>
3436
3437         * thread.c (thread_cancel_execution_command): Update.
3438         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3439         methods.
3440         (struct thread_fsm_ops): Remove.
3441         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3442         (thread_fsm_should_stop, thread_fsm_return_value)
3443         (thread_fsm_set_finished, thread_fsm_finished_p)
3444         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3445         Don't declare.
3446         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3447         * infrun.c (clear_proceed_status_thread)
3448         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3449         (print_stop_event): Update.
3450         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3451         Add constructor.
3452         (step_command_fsm_ops): Remove.
3453         (new_step_command_fsm): Remove.
3454         (step_1): Update.
3455         (step_command_fsm::should_stop): Rename from
3456         step_command_fsm_should_stop.
3457         (step_command_fsm::clean_up): Rename from
3458         step_command_fsm_clean_up.
3459         (step_command_fsm::do_async_reply_reason): Rename from
3460         step_command_fsm_async_reply_reason.
3461         (struct until_next_fsm): Inherit from thread_fsm.  Add
3462         constructor.
3463         (until_next_fsm_ops): Remove.
3464         (new_until_next_fsm): Remove.
3465         (until_next_fsm::should_stop): Rename from
3466         until_next_fsm_should_stop.
3467         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3468         (until_next_fsm::do_async_reply_reason): Rename from
3469         until_next_fsm_async_reply_reason.
3470         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3471         constructor.  Change type of breakpoint.
3472         (finish_command_fsm_ops): Remove.
3473         (new_finish_command_fsm): Remove.
3474         (finish_command_fsm::should_stop): Rename from
3475         finish_command_fsm_should_stop.
3476         (finish_command_fsm::clean_up): Rename from
3477         finish_command_fsm_clean_up.
3478         (finish_command_fsm::return_value): Rename from
3479         finish_command_fsm_return_value.
3480         (finish_command_fsm::do_async_reply_reason): Rename from
3481         finish_command_fsm_async_reply_reason.
3482         (finish_command): Update.
3483         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3484         Add constructor.
3485         (call_thread_fsm_ops): Remove.
3486         (call_thread_fsm::call_thread_fsm): Rename from
3487         new_call_thread_fsm.
3488         (call_thread_fsm::should_stop): Rename from
3489         call_thread_fsm_should_stop.
3490         (call_thread_fsm::should_notify_stop): Rename from
3491         call_thread_fsm_should_notify_stop.
3492         (run_inferior_call, call_function_by_hand_dummy): Update.
3493         * cli/cli-interp.c (should_print_stop_to_console): Update.
3494         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3495         Add constructor.  Change type of location_breakpoint,
3496         caller_breakpoint.
3497         (until_break_fsm_ops): Remove.
3498         (new_until_break_fsm): Remove.
3499         (until_break_fsm::should_stop): Rename from
3500         until_break_fsm_should_stop.
3501         (until_break_fsm::clean_up): Rename from
3502         until_break_fsm_clean_up.
3503         (until_break_fsm::do_async_reply_reason): Rename from
3504         until_break_fsm_async_reply_reason.
3505         (until_break_command): Update.
3506         * thread-fsm.c: Remove.
3507         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3508
3509 2019-02-07  Tom Tromey  <tom@tromey.com>
3510
3511         * yy-remap.h: Add include guard.
3512         * xtensa-tdep.h: Add include guard.
3513         * xcoffread.h: Rename include guard.
3514         * varobj-iter.h: Add include guard.
3515         * tui/tui.h: Rename include guard.
3516         * tui/tui-winsource.h: Rename include guard.
3517         * tui/tui-wingeneral.h: Rename include guard.
3518         * tui/tui-windata.h: Rename include guard.
3519         * tui/tui-win.h: Rename include guard.
3520         * tui/tui-stack.h: Rename include guard.
3521         * tui/tui-source.h: Rename include guard.
3522         * tui/tui-regs.h: Rename include guard.
3523         * tui/tui-out.h: Rename include guard.
3524         * tui/tui-layout.h: Rename include guard.
3525         * tui/tui-io.h: Rename include guard.
3526         * tui/tui-hooks.h: Rename include guard.
3527         * tui/tui-file.h: Rename include guard.
3528         * tui/tui-disasm.h: Rename include guard.
3529         * tui/tui-data.h: Rename include guard.
3530         * tui/tui-command.h: Rename include guard.
3531         * tic6x-tdep.h: Add include guard.
3532         * target/waitstatus.h: Rename include guard.
3533         * target/wait.h: Rename include guard.
3534         * target/target.h: Rename include guard.
3535         * target/resume.h: Rename include guard.
3536         * target-float.h: Rename include guard.
3537         * stabsread.h: Add include guard.
3538         * rs6000-tdep.h: Add include guard.
3539         * riscv-fbsd-tdep.h: Add include guard.
3540         * regformats/regdef.h: Rename include guard.
3541         * record.h: Rename include guard.
3542         * python/python.h: Rename include guard.
3543         * python/python-internal.h: Rename include guard.
3544         * python/py-stopevent.h: Rename include guard.
3545         * python/py-ref.h: Rename include guard.
3546         * python/py-record.h: Rename include guard.
3547         * python/py-record-full.h: Rename include guard.
3548         * python/py-record-btrace.h: Rename include guard.
3549         * python/py-instruction.h: Rename include guard.
3550         * python/py-events.h: Rename include guard.
3551         * python/py-event.h: Rename include guard.
3552         * procfs.h: Add include guard.
3553         * proc-utils.h: Add include guard.
3554         * p-lang.h: Add include guard.
3555         * or1k-tdep.h: Rename include guard.
3556         * observable.h: Rename include guard.
3557         * nto-tdep.h: Rename include guard.
3558         * nat/x86-linux.h: Rename include guard.
3559         * nat/x86-linux-dregs.h: Rename include guard.
3560         * nat/x86-gcc-cpuid.h: Add include guard.
3561         * nat/x86-dregs.h: Rename include guard.
3562         * nat/x86-cpuid.h: Rename include guard.
3563         * nat/ppc-linux.h: Rename include guard.
3564         * nat/mips-linux-watch.h: Rename include guard.
3565         * nat/linux-waitpid.h: Rename include guard.
3566         * nat/linux-ptrace.h: Rename include guard.
3567         * nat/linux-procfs.h: Rename include guard.
3568         * nat/linux-osdata.h: Rename include guard.
3569         * nat/linux-nat.h: Rename include guard.
3570         * nat/linux-namespaces.h: Rename include guard.
3571         * nat/linux-btrace.h: Rename include guard.
3572         * nat/glibc_thread_db.h: Rename include guard.
3573         * nat/gdb_thread_db.h: Rename include guard.
3574         * nat/gdb_ptrace.h: Rename include guard.
3575         * nat/fork-inferior.h: Rename include guard.
3576         * nat/amd64-linux-siginfo.h: Rename include guard.
3577         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3578         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3579         * nat/aarch64-linux.h: Rename include guard.
3580         * nat/aarch64-linux-hw-point.h: Rename include guard.
3581         * mn10300-tdep.h: Add include guard.
3582         * mips-linux-tdep.h: Add include guard.
3583         * mi/mi-parse.h: Rename include guard.
3584         * mi/mi-out.h: Rename include guard.
3585         * mi/mi-main.h: Rename include guard.
3586         * mi/mi-interp.h: Rename include guard.
3587         * mi/mi-getopt.h: Rename include guard.
3588         * mi/mi-console.h: Rename include guard.
3589         * mi/mi-common.h: Rename include guard.
3590         * mi/mi-cmds.h: Rename include guard.
3591         * mi/mi-cmd-break.h: Rename include guard.
3592         * m2-lang.h: Add include guard.
3593         * location.h: Rename include guard.
3594         * linux-record.h: Rename include guard.
3595         * linux-nat.h: Add include guard.
3596         * linux-fork.h: Add include guard.
3597         * i386-darwin-tdep.h: Rename include guard.
3598         * hppa-linux-offsets.h: Add include guard.
3599         * guile/guile.h: Rename include guard.
3600         * guile/guile-internal.h: Rename include guard.
3601         * gnu-nat.h: Rename include guard.
3602         * gdb-stabs.h: Rename include guard.
3603         * frv-tdep.h: Add include guard.
3604         * f-lang.h: Add include guard.
3605         * event-loop.h: Add include guard.
3606         * darwin-nat.h: Rename include guard.
3607         * cp-abi.h: Rename include guard.
3608         * config/sparc/nm-sol2.h: Rename include guard.
3609         * config/nm-nto.h: Rename include guard.
3610         * config/nm-linux.h: Add include guard.
3611         * config/i386/nm-i386gnu.h: Rename include guard.
3612         * config/djgpp/nl_types.h: Rename include guard.
3613         * config/djgpp/langinfo.h: Rename include guard.
3614         * compile/gcc-cp-plugin.h: Add include guard.
3615         * compile/gcc-c-plugin.h: Add include guard.
3616         * compile/compile.h: Rename include guard.
3617         * compile/compile-object-run.h: Rename include guard.
3618         * compile/compile-object-load.h: Rename include guard.
3619         * compile/compile-internal.h: Rename include guard.
3620         * compile/compile-cplus.h: Rename include guard.
3621         * compile/compile-c.h: Rename include guard.
3622         * common/xml-utils.h: Rename include guard.
3623         * common/x86-xstate.h: Rename include guard.
3624         * common/version.h: Rename include guard.
3625         * common/vec.h: Rename include guard.
3626         * common/tdesc.h: Rename include guard.
3627         * common/selftest.h: Rename include guard.
3628         * common/scoped_restore.h: Rename include guard.
3629         * common/scoped_mmap.h: Rename include guard.
3630         * common/scoped_fd.h: Rename include guard.
3631         * common/safe-iterator.h: Rename include guard.
3632         * common/run-time-clock.h: Rename include guard.
3633         * common/refcounted-object.h: Rename include guard.
3634         * common/queue.h: Rename include guard.
3635         * common/ptid.h: Rename include guard.
3636         * common/print-utils.h: Rename include guard.
3637         * common/preprocessor.h: Rename include guard.
3638         * common/pathstuff.h: Rename include guard.
3639         * common/observable.h: Rename include guard.
3640         * common/netstuff.h: Rename include guard.
3641         * common/job-control.h: Rename include guard.
3642         * common/host-defs.h: Rename include guard.
3643         * common/gdb_wait.h: Rename include guard.
3644         * common/gdb_vecs.h: Rename include guard.
3645         * common/gdb_unlinker.h: Rename include guard.
3646         * common/gdb_unique_ptr.h: Rename include guard.
3647         * common/gdb_tilde_expand.h: Rename include guard.
3648         * common/gdb_sys_time.h: Rename include guard.
3649         * common/gdb_string_view.h: Rename include guard.
3650         * common/gdb_splay_tree.h: Rename include guard.
3651         * common/gdb_setjmp.h: Rename include guard.
3652         * common/gdb_ref_ptr.h: Rename include guard.
3653         * common/gdb_optional.h: Rename include guard.
3654         * common/gdb_locale.h: Rename include guard.
3655         * common/gdb_assert.h: Rename include guard.
3656         * common/filtered-iterator.h: Rename include guard.
3657         * common/filestuff.h: Rename include guard.
3658         * common/fileio.h: Rename include guard.
3659         * common/environ.h: Rename include guard.
3660         * common/common-utils.h: Rename include guard.
3661         * common/common-types.h: Rename include guard.
3662         * common/common-regcache.h: Rename include guard.
3663         * common/common-inferior.h: Rename include guard.
3664         * common/common-gdbthread.h: Rename include guard.
3665         * common/common-exceptions.h: Rename include guard.
3666         * common/common-defs.h: Rename include guard.
3667         * common/common-debug.h: Rename include guard.
3668         * common/cleanups.h: Rename include guard.
3669         * common/buffer.h: Rename include guard.
3670         * common/btrace-common.h: Rename include guard.
3671         * common/break-common.h: Rename include guard.
3672         * cli/cli-utils.h: Rename include guard.
3673         * cli/cli-style.h: Rename include guard.
3674         * cli/cli-setshow.h: Rename include guard.
3675         * cli/cli-script.h: Rename include guard.
3676         * cli/cli-interp.h: Rename include guard.
3677         * cli/cli-decode.h: Rename include guard.
3678         * cli/cli-cmds.h: Rename include guard.
3679         * charset-list.h: Add include guard.
3680         * buildsym-legacy.h: Rename include guard.
3681         * bfin-tdep.h: Add include guard.
3682         * ax.h: Rename include guard.
3683         * arm-linux-tdep.h: Add include guard.
3684         * arm-fbsd-tdep.h: Add include guard.
3685         * arch/xtensa.h: Rename include guard.
3686         * arch/tic6x.h: Add include guard.
3687         * arch/i386.h: Add include guard.
3688         * arch/arm.h: Rename include guard.
3689         * arch/arm-linux.h: Rename include guard.
3690         * arch/arm-get-next-pcs.h: Rename include guard.
3691         * arch/amd64.h: Add include guard.
3692         * arch/aarch64-insn.h: Rename include guard.
3693         * arch-utils.h: Rename include guard.
3694         * annotate.h: Add include guard.
3695         * amd64-darwin-tdep.h: Rename include guard.
3696         * aarch64-linux-tdep.h: Add include guard.
3697         * aarch64-fbsd-tdep.h: Add include guard.
3698         * aarch32-linux-nat.h: Add include guard.
3699
3700 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3701
3702         * macrotab.c (macro_define_internal): New function that
3703         factorizes macro_define_object_internal and macro_define_function
3704         code.
3705         (macro_define_object_internal): Use macro_define_internal.
3706         (macro_define_function): Likewise.
3707
3708 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3709
3710         * macrocmd.c (extract_identifier): Return
3711         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3712         callers.
3713
3714 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3715
3716         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3717
3718 2019-02-05  Tom Tromey  <tom@tromey.com>
3719
3720         * target.c (target_stack::unpush): Move assertion earlier.
3721
3722 2019-01-30  Tom Tromey  <tom@tromey.com>
3723
3724         PR python/23615:
3725         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3726         (gdbpy_parse_and_eval): Likewise.
3727         * python/python-internal.h (gdbpy_allow_threads): New class.
3728
3729 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3730
3731         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3732         (aarch64_fbsd_fpregmap): Move earlier.
3733         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3734         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3735         instead of individual calls to trad_frame_set_reg_addr.
3736         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3737         earlier.
3738         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3739         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3740         instead of individual calls to trad_frame_set_reg_addr.
3741
3742 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3743
3744         * CONTRIBUTE: Replace contribution list with wiki link.
3745
3746 2019-01-25  Tom Tromey  <tom@tromey.com>
3747
3748         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3749
3750 2019-01-25  Tom Tromey  <tom@tromey.com>
3751
3752         * xtensa-linux-nat.c: Fix common/ includes.
3753         * xml-support.h: Fix common/ includes.
3754         * xml-support.c: Fix common/ includes.
3755         * x86-linux-nat.c: Fix common/ includes.
3756         * windows-nat.c: Fix common/ includes.
3757         * varobj.h: Fix common/ includes.
3758         * varobj.c: Fix common/ includes.
3759         * value.c: Fix common/ includes.
3760         * valops.c: Fix common/ includes.
3761         * utils.c: Fix common/ includes.
3762         * unittests/xml-utils-selftests.c: Fix common/ includes.
3763         * unittests/utils-selftests.c: Fix common/ includes.
3764         * unittests/unpack-selftests.c: Fix common/ includes.
3765         * unittests/tracepoint-selftests.c: Fix common/ includes.
3766         * unittests/style-selftests.c: Fix common/ includes.
3767         * unittests/string_view-selftests.c: Fix common/ includes.
3768         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3769         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3770         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3771         * unittests/rsp-low-selftests.c: Fix common/ includes.
3772         * unittests/parse-connection-spec-selftests.c: Fix common/
3773         includes.
3774         * unittests/optional-selftests.c: Fix common/ includes.
3775         * unittests/offset-type-selftests.c: Fix common/ includes.
3776         * unittests/observable-selftests.c: Fix common/ includes.
3777         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3778         * unittests/memrange-selftests.c: Fix common/ includes.
3779         * unittests/memory-map-selftests.c: Fix common/ includes.
3780         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3781         * unittests/function-view-selftests.c: Fix common/ includes.
3782         * unittests/environ-selftests.c: Fix common/ includes.
3783         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3784         * unittests/common-utils-selftests.c: Fix common/ includes.
3785         * unittests/cli-utils-selftests.c: Fix common/ includes.
3786         * unittests/array-view-selftests.c: Fix common/ includes.
3787         * ui-file.c: Fix common/ includes.
3788         * tui/tui-io.c: Fix common/ includes.
3789         * tracepoint.h: Fix common/ includes.
3790         * tracepoint.c: Fix common/ includes.
3791         * tracefile-tfile.c: Fix common/ includes.
3792         * top.h: Fix common/ includes.
3793         * top.c: Fix common/ includes.
3794         * thread.c: Fix common/ includes.
3795         * target/waitstatus.h: Fix common/ includes.
3796         * target/waitstatus.c: Fix common/ includes.
3797         * target.h: Fix common/ includes.
3798         * target.c: Fix common/ includes.
3799         * target-memory.c: Fix common/ includes.
3800         * target-descriptions.c: Fix common/ includes.
3801         * symtab.h: Fix common/ includes.
3802         * symfile.c: Fix common/ includes.
3803         * stap-probe.c: Fix common/ includes.
3804         * spu-linux-nat.c: Fix common/ includes.
3805         * sparc-nat.c: Fix common/ includes.
3806         * source.c: Fix common/ includes.
3807         * solib.c: Fix common/ includes.
3808         * solib-target.c: Fix common/ includes.
3809         * ser-unix.c: Fix common/ includes.
3810         * ser-tcp.c: Fix common/ includes.
3811         * ser-pipe.c: Fix common/ includes.
3812         * ser-base.c: Fix common/ includes.
3813         * selftest-arch.c: Fix common/ includes.
3814         * s12z-tdep.c: Fix common/ includes.
3815         * rust-exp.y: Fix common/ includes.
3816         * rs6000-aix-tdep.c: Fix common/ includes.
3817         * riscv-tdep.c: Fix common/ includes.
3818         * remote.c: Fix common/ includes.
3819         * remote-notif.h: Fix common/ includes.
3820         * remote-fileio.h: Fix common/ includes.
3821         * remote-fileio.c: Fix common/ includes.
3822         * regcache.h: Fix common/ includes.
3823         * regcache.c: Fix common/ includes.
3824         * record-btrace.c: Fix common/ includes.
3825         * python/python.c: Fix common/ includes.
3826         * python/py-type.c: Fix common/ includes.
3827         * python/py-inferior.c: Fix common/ includes.
3828         * progspace.h: Fix common/ includes.
3829         * producer.c: Fix common/ includes.
3830         * procfs.c: Fix common/ includes.
3831         * proc-api.c: Fix common/ includes.
3832         * printcmd.c: Fix common/ includes.
3833         * ppc-linux-nat.c: Fix common/ includes.
3834         * parser-defs.h: Fix common/ includes.
3835         * osdata.c: Fix common/ includes.
3836         * obsd-nat.c: Fix common/ includes.
3837         * nat/x86-linux.c: Fix common/ includes.
3838         * nat/x86-linux-dregs.c: Fix common/ includes.
3839         * nat/x86-dregs.h: Fix common/ includes.
3840         * nat/x86-dregs.c: Fix common/ includes.
3841         * nat/ppc-linux.c: Fix common/ includes.
3842         * nat/mips-linux-watch.h: Fix common/ includes.
3843         * nat/mips-linux-watch.c: Fix common/ includes.
3844         * nat/linux-waitpid.c: Fix common/ includes.
3845         * nat/linux-ptrace.h: Fix common/ includes.
3846         * nat/linux-ptrace.c: Fix common/ includes.
3847         * nat/linux-procfs.c: Fix common/ includes.
3848         * nat/linux-personality.c: Fix common/ includes.
3849         * nat/linux-osdata.c: Fix common/ includes.
3850         * nat/linux-namespaces.c: Fix common/ includes.
3851         * nat/linux-btrace.h: Fix common/ includes.
3852         * nat/linux-btrace.c: Fix common/ includes.
3853         * nat/fork-inferior.c: Fix common/ includes.
3854         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3855         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3856         * nat/aarch64-linux.c: Fix common/ includes.
3857         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3858         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3859         * namespace.h: Fix common/ includes.
3860         * mips-linux-tdep.c: Fix common/ includes.
3861         * minsyms.c: Fix common/ includes.
3862         * mi/mi-parse.h: Fix common/ includes.
3863         * mi/mi-main.c: Fix common/ includes.
3864         * mi/mi-cmd-env.c: Fix common/ includes.
3865         * memrange.h: Fix common/ includes.
3866         * memattr.c: Fix common/ includes.
3867         * maint.h: Fix common/ includes.
3868         * maint.c: Fix common/ includes.
3869         * main.c: Fix common/ includes.
3870         * machoread.c: Fix common/ includes.
3871         * location.c: Fix common/ includes.
3872         * linux-thread-db.c: Fix common/ includes.
3873         * linux-nat.c: Fix common/ includes.
3874         * linux-fork.c: Fix common/ includes.
3875         * inline-frame.c: Fix common/ includes.
3876         * infrun.c: Fix common/ includes.
3877         * inflow.c: Fix common/ includes.
3878         * inferior.h: Fix common/ includes.
3879         * inferior.c: Fix common/ includes.
3880         * infcmd.c: Fix common/ includes.
3881         * inf-ptrace.c: Fix common/ includes.
3882         * inf-child.c: Fix common/ includes.
3883         * ia64-linux-nat.c: Fix common/ includes.
3884         * i387-tdep.c: Fix common/ includes.
3885         * i386-tdep.c: Fix common/ includes.
3886         * i386-linux-tdep.c: Fix common/ includes.
3887         * i386-linux-nat.c: Fix common/ includes.
3888         * i386-go32-tdep.c: Fix common/ includes.
3889         * i386-fbsd-tdep.c: Fix common/ includes.
3890         * i386-fbsd-nat.c: Fix common/ includes.
3891         * guile/scm-type.c: Fix common/ includes.
3892         * guile/guile.c: Fix common/ includes.
3893         * go32-nat.c: Fix common/ includes.
3894         * gnu-nat.c: Fix common/ includes.
3895         * gdbthread.h: Fix common/ includes.
3896         * gdbarch-selftests.c: Fix common/ includes.
3897         * gdb_usleep.c: Fix common/ includes.
3898         * gdb_select.h: Fix common/ includes.
3899         * gdb_bfd.c: Fix common/ includes.
3900         * gcore.c: Fix common/ includes.
3901         * fork-child.c: Fix common/ includes.
3902         * findvar.c: Fix common/ includes.
3903         * fbsd-nat.c: Fix common/ includes.
3904         * event-top.c: Fix common/ includes.
3905         * event-loop.c: Fix common/ includes.
3906         * dwarf2read.c: Fix common/ includes.
3907         * dwarf2loc.c: Fix common/ includes.
3908         * dwarf2-frame.c: Fix common/ includes.
3909         * dwarf-index-cache.c: Fix common/ includes.
3910         * dtrace-probe.c: Fix common/ includes.
3911         * disasm-selftests.c: Fix common/ includes.
3912         * defs.h: Fix common/ includes.
3913         * csky-tdep.c: Fix common/ includes.
3914         * cp-valprint.c: Fix common/ includes.
3915         * cp-support.h: Fix common/ includes.
3916         * cp-support.c: Fix common/ includes.
3917         * corelow.c: Fix common/ includes.
3918         * completer.h: Fix common/ includes.
3919         * completer.c: Fix common/ includes.
3920         * compile/compile.c: Fix common/ includes.
3921         * compile/compile-loc2c.c: Fix common/ includes.
3922         * compile/compile-cplus-types.c: Fix common/ includes.
3923         * compile/compile-cplus-symbols.c: Fix common/ includes.
3924         * command.h: Fix common/ includes.
3925         * cli/cli-dump.c: Fix common/ includes.
3926         * cli/cli-cmds.c: Fix common/ includes.
3927         * charset.c: Fix common/ includes.
3928         * build-id.c: Fix common/ includes.
3929         * btrace.h: Fix common/ includes.
3930         * btrace.c: Fix common/ includes.
3931         * breakpoint.h: Fix common/ includes.
3932         * breakpoint.c: Fix common/ includes.
3933         * ax.h:
3934         (enum agent_op): Fix common/ includes.
3935         * ax-general.c (struct aop_map): Fix common/ includes.
3936         * ax-gdb.c: Fix common/ includes.
3937         * auxv.c: Fix common/ includes.
3938         * auto-load.c: Fix common/ includes.
3939         * arm-tdep.c: Fix common/ includes.
3940         * arch/riscv.c: Fix common/ includes.
3941         * arch/ppc-linux-common.c: Fix common/ includes.
3942         * arch/i386.c: Fix common/ includes.
3943         * arch/arm.c: Fix common/ includes.
3944         * arch/arm-linux.c: Fix common/ includes.
3945         * arch/arm-get-next-pcs.c: Fix common/ includes.
3946         * arch/amd64.c: Fix common/ includes.
3947         * arch/aarch64.c: Fix common/ includes.
3948         * arch/aarch64-insn.c: Fix common/ includes.
3949         * arch-utils.c: Fix common/ includes.
3950         * amd64-windows-tdep.c: Fix common/ includes.
3951         * amd64-tdep.c: Fix common/ includes.
3952         * amd64-sol2-tdep.c: Fix common/ includes.
3953         * amd64-obsd-tdep.c: Fix common/ includes.
3954         * amd64-nbsd-tdep.c: Fix common/ includes.
3955         * amd64-linux-tdep.c: Fix common/ includes.
3956         * amd64-linux-nat.c: Fix common/ includes.
3957         * amd64-fbsd-tdep.c: Fix common/ includes.
3958         * amd64-fbsd-nat.c: Fix common/ includes.
3959         * amd64-dicos-tdep.c: Fix common/ includes.
3960         * amd64-darwin-tdep.c: Fix common/ includes.
3961         * agent.c: Fix common/ includes.
3962         * ada-lang.h: Fix common/ includes.
3963         * ada-lang.c: Fix common/ includes.
3964         * aarch64-tdep.c: Fix common/ includes.
3965
3966 2019-01-25  Tom Tromey  <tom@tromey.com>
3967
3968         * common/create-version.sh: Use common/version.h.
3969
3970 2019-01-24  Pedro Alves  <palves@redhat.com>
3971
3972         * infrun.c (signal_stop, signal_print, signal_program)
3973         (signal_catch, signal_pass): Now arrays instead of pointers.
3974         (update_signals_program_target, do_target_resume)
3975         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3976         * linux-nat.c (linux_nat_target::pass_signals)
3977         (linux_nat_target::create_inferior, linux_nat_target::attach):
3978         Adjust.
3979         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3980         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3981         * procfs.c (procfs_target::pass_signals): Adjust.
3982         * record-full.c (record_full_target::resume): Adjust.
3983         * remote.c (remote_target::pass_signals)
3984         (remote_target::program_signals): Adjust.
3985         * target-debug.h (target_debug_print_signals): Now takes a
3986         gdb::array_view as parameter.  Adjust.
3987         * target.h (target_ops) <pass_signals, program_signals>: Replace
3988         pointer and length parameters with gdb::array_view.
3989         (target_pass_signals, target_program_signals): Likewise.
3990         * target-delegates.c: Regenerate.
3991
3992 2019-01-24  Pedro Alves  <palves@redhat.com>
3993
3994         * common/forward-scope-exit.h
3995         (forward_scope_exit::forward_scope_exit): Pass arguments to
3996         m_bind_function directly, instead of creating a std::bind and
3997         copying that.
3998
3999 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4000
4001         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4002         for static members.
4003         (pass_in_v_vfp_candidate): Likewise.
4004
4005 2019-01-23  Tom Tromey  <tom@tromey.com>
4006             Pedro Alves  <palves@redhat.com>
4007
4008         * regcache.c (class regcache_invalidator): Remove.
4009         (regcache::raw_write): Use make_scope_exit.
4010
4011 2019-01-23  Tom Tromey  <tom@tromey.com>
4012
4013         * ui-out.h (class ui_out_emit_type): Update comment.
4014
4015 2019-01-23  Tom Tromey  <tom@tromey.com>
4016
4017         * infrun.c (fetch_inferior_event): Update comment.
4018
4019 2019-01-23  Tom Tromey  <tom@tromey.com>
4020             Pedro Alves  <palves@redhat.com>
4021
4022         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4023         parameter.
4024         (fetch_inferior_event): Use SCOPE_EXIT.
4025
4026
4027 2019-01-23  Tom Tromey  <tom@tromey.com>
4028             Pedro Alves  <palves@redhat.com>
4029
4030         * infrun.c (disable_thread_events): Delete.
4031         (stop_all_threads): Use SCOPE_EXIT.
4032
4033 2019-01-23  Tom Tromey  <tom@tromey.com>
4034             Pedro Alves  <palves@redhat.com>
4035
4036         * symfile.c: Include forward-scope-exit.h.
4037         (clear_symtab_users_cleanup): Replace forward declaration with
4038         a FORWARD_SCOPE_EXIT.
4039         (syms_from_objfile_1): Use the forward_scope_exit and
4040         gdb::optional instead of cleanup_function.
4041         (reread_symbols): Use the forward_scope_exit instead of
4042         cleanup_function.
4043         (clear_symtab_users_cleanup): Remove function.
4044
4045 2019-01-23  Tom Tromey  <tom@tromey.com>
4046             Pedro Alves  <palves@redhat.com>
4047
4048         * linux-nat.c: Include scope-exit.h.
4049         (cleanup_target_stop): Remove.
4050         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4051         SCOPE_EXIT.
4052
4053 2019-01-23  Tom Tromey  <tom@tromey.com>
4054             Pedro Alves  <palves@redhat.com>
4055
4056         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4057         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4058
4059 2019-01-23  Tom Tromey  <tom@tromey.com>
4060             Andrew Burgess  <andrew.burgess@embecosm.com>
4061             Pedro Alves  <palves@redhat.com>
4062
4063         * infrun.c (fetch_inferior_event): Use scope_exit.
4064         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4065         * top.c (execute_command): Use scope_exit.
4066         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4067         * utils.c (do_bpstat_clear_actions_cleanup)
4068         (make_bpstat_clear_actions_cleanup): Remove.
4069
4070 2019-01-23  Tom Tromey  <tom@tromey.com>
4071             Pedro Alves  <palves@redhat.com>
4072
4073         * infrun.c: Include "common/scope-exit.h"
4074         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4075         (wait_for_inferior): Use SCOPE_EXIT.
4076         (fetch_inferior_event): Use scope_exit.
4077
4078 2019-01-23  Tom Tromey  <tom@tromey.com>
4079             Pedro Alves  <palves@redhat.com>
4080
4081         * breakpoint.c (create_breakpoint): Remove cleanup.
4082
4083 2019-01-23  Tom Tromey  <tom@tromey.com>
4084             Andrew Burgess  <andrew.burgess@embecosm.com>
4085             Pedro Alves  <palves@redhat.com>
4086
4087 2019-01-23  Pedro Alves  <palves@redhat.com>
4088
4089         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4090
4091 2019-01-23  Pedro Alves  <palves@redhat.com>
4092             Andrew Burgess  <andrew.burgess@embecosm.com>
4093
4094         * gdbthread.h: Include "common/forward-scope-exit.h".
4095         (scoped_finish_thread_state): Redefine custom class in terms of
4096         forward_scope_exit.
4097
4098 2019-01-23  Pedro Alves  <palves@redhat.com>
4099             Andrew Burgess  <andrew.burgess@embecosm.com>
4100
4101         * common/forward-scope-exit.h: New file.
4102
4103 2019-01-23  Pedro Alves  <palves@redhat.com>
4104             Andrew Burgess  <andrew.burgess@embecosm.com>
4105             Tom Tromey  <tom@tromey.com>
4106
4107         * common/scope-exit.h: New file.
4108
4109 2019-01-23  Pedro Alves  <palves@redhat.com>
4110
4111         * common/preprocessor.h (ESC): Rename to ...
4112         (ESC_PARENS): ... this.
4113         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4114         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4115
4116 2019-01-23  Tom Tromey  <tom@tromey.com>
4117
4118         * language.h (class scoped_switch_to_sym_language_if_auto):
4119         Initialize m_lang in both cases.
4120
4121 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4122
4123         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4124         with XCNEW.
4125
4126 2019-01-22  Tom Tromey  <tom@tromey.com>
4127
4128         * corelow.c: Do not include sys/file.h.
4129
4130 2019-01-22  Tom Tromey  <tom@tromey.com>
4131
4132         * tui/tui-wingeneral.h: Include gdb_curses.h.
4133
4134 2019-01-22  Tom Tromey  <tom@tromey.com>
4135
4136         * source-cache.h (class source_cache) <get_source_lines,
4137         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4138
4139 2019-01-22  Tom Tromey  <tom@tromey.com>
4140
4141         * remote-fileio.h (struct remote_target): Declare.
4142
4143 2019-01-22  Tom Tromey  <tom@tromey.com>
4144
4145         * python/py-arch.c: Do not include py-ref.h.
4146         * python/py-bpevent.c: Do not include py-ref.h.
4147         * python/py-cmd.c: Do not include py-ref.h.
4148         * python/py-continueevent.c: Do not include py-ref.h.
4149         * python/py-event.h: Do not include py-ref.h.
4150         * python/py-evtregistry.c: Do not include py-ref.h.
4151         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4152         * python/py-frame.c: Do not include py-ref.h.
4153         * python/py-framefilter.c: Do not include py-ref.h.
4154         * python/py-function.c: Do not include py-ref.h.
4155         * python/py-infevents.c: Do not include py-ref.h.
4156         * python/py-linetable.c: Do not include py-ref.h.
4157         * python/py-objfile.c: Do not include py-ref.h.
4158         * python/py-param.c: Do not include py-ref.h.
4159         * python/py-prettyprint.c: Do not include py-ref.h.
4160         * python/py-progspace.c: Do not include py-ref.h.
4161         * python/py-symbol.c: Do not include py-ref.h.
4162         * python/py-symtab.c: Do not include py-ref.h.
4163         * python/py-type.c: Do not include py-ref.h.
4164         * python/py-unwind.c: Do not include py-ref.h.
4165         * python/py-utils.c: Do not include py-ref.h.
4166         * python/py-value.c: Do not include py-ref.h.
4167         * python/py-varobj.c: Do not include py-ref.h.
4168         * python/py-xmethods.c: Do not include py-ref.h.
4169         * python/python.c: Do not include py-ref.h.
4170         * varobj.c: Do not include py-ref.h.
4171
4172 2019-01-22  Tom Tromey  <tom@tromey.com>
4173
4174         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4175         keyword for bcache.
4176
4177 2019-01-22  Tom Tromey  <tom@tromey.com>
4178
4179         * compile/compile-cplus-types.c: Remove a comment by #include.
4180
4181 2019-01-22  Tom Tromey  <tom@tromey.com>
4182
4183         * compile/gcc-c-plugin.h: Include compile-internal.h.
4184
4185 2019-01-22  Tom Tromey  <tom@tromey.com>
4186
4187         * stabsread.c (EXTERN): Do not define.
4188         (symnum, next_symbol_text_func, processing_gcc_compilation)
4189         (within_function, global_sym_chain, global_stabs)
4190         (previous_stab_code, this_object_header_files)
4191         (n_this_object_header_files)
4192         (n_allocated_this_object_header_files): Define.
4193         * stabsread.h (EXTERN): Never define.  Use "extern".
4194
4195 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4196
4197         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4198         history_value.
4199
4200 2019-01-21  Tom Tromey  <tom@tromey.com>
4201
4202         * ui-out.c: Fix includes.
4203         * tui/tui-source.c: Fix includes.
4204         * target.c: Fix includes.
4205         * remote.c: Fix includes.
4206         * regcache.c: Fix includes.
4207         * python/py-block.c: Fix includes.
4208         * printcmd.c: Fix includes.
4209         * or1k-tdep.c: Fix includes.
4210         * mi/mi-main.c: Fix includes.
4211         * m32r-tdep.c: Fix includes.
4212         * csky-tdep.c: Fix includes.
4213         * compile/compile-cplus-types.c: Fix includes.
4214         * cli/cli-interp.c: Fix includes.
4215
4216 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4217
4218         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4219         for padding.
4220
4221 2019-01-16  Tom Tromey  <tom@tromey.com>
4222
4223         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4224         earlier.
4225         (struct objfile) <msymbols_range>: Move from top level.
4226         <msymbols>: New method.
4227         (class objfile_msymbols): Remove.
4228         * symtab.c (default_collect_symbol_completion_matches_break_on):
4229         Update.
4230         * symmisc.c (dump_msymbols): Update.
4231         * stabsread.c (scan_file_globals): Update.
4232         * objc-lang.c (info_selectors_command, info_classes_command)
4233         (find_methods): Update.
4234         * minsyms.c (find_solib_trampoline_target): Update.
4235         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4236         * coffread.c (coff_symfile_read): Update.
4237         * ada-lang.c (ada_lookup_simple_minsym)
4238         (ada_collect_symbol_completion_matches): Update.
4239
4240 2019-01-16  Tom Tromey  <tom@tromey.com>
4241
4242         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4243         type.  Remove no-argument constructor.
4244         <iterator::operator++>: Simplify.
4245         <begin>: Update.
4246         <end>: Use minimal_symbol_count.
4247
4248 2019-01-16  Tom Tromey  <tom@tromey.com>
4249
4250         * objfiles.h (struct objfile) <psymtabs>: New method.
4251         (class objfile_psymtabs): Remove.
4252         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4253         typedef.
4254         <range>: New method.
4255         (require_partial_symbols): Change return type.
4256         * psymtab.c (require_partial_symbols)
4257         (psym_expand_symtabs_matching): Update.
4258         * mdebugread.c (parse_partial_symbols): Update.
4259         * dbxread.c (dbx_end_psymtab): Update.
4260
4261 2019-01-15  Tom Tromey  <tom@tromey.com>
4262
4263         * symtab.c (lookup_objfile_from_block)
4264         (lookup_symbol_in_objfile_symtabs)
4265         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4266         (find_line_symtab, info_sources_command)
4267         (default_collect_symbol_completion_matches_break_on)
4268         (make_source_files_completion_list): Update.
4269         * symmisc.c (print_objfile_statistics, dump_objfile)
4270         (maintenance_print_symbols, maintenance_info_symtabs)
4271         (maintenance_check_symtabs, maintenance_info_line_tables):
4272         Update.
4273         * source.c (select_source_symtab)
4274         (forget_cached_source_info_for_objfile): Update.
4275         * objfiles.h (class objfile_compunits): Remove.
4276         (struct objfile) <compunits_range>: New typedef.
4277         (compunits): New method.
4278         * objfiles.c (objfile_relocate1): Update.
4279         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4280         * maint.c (count_symtabs_and_blocks): Update.
4281         * linespec.c (iterate_over_all_matching_symtabs): Update.
4282         * cp-support.c (add_symbol_overload_list_qualified): Update.
4283         * coffread.c (coff_symtab_read): Update.
4284         * ada-lang.c (add_nonlocal_symbols)
4285         (ada_collect_symbol_completion_matches)
4286         (ada_add_global_exceptions): Update.
4287
4288 2019-01-15  Tom Tromey  <tom@tromey.com>
4289
4290         * progspace.h (program_space) <objfiles_safe_range>: New
4291         typedef.
4292         <objfiles_safe>: New method.
4293         * objfiles.h (class all_objfiles_safe): Remove.
4294         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4295         * jit.c (jit_inferior_exit_hook): Update.
4296
4297 2019-01-17  Tom Tromey  <tom@tromey.com>
4298
4299         * progspace.h (program_space) <objfiles_range>: New typedef.
4300         <objfiles>: New method.
4301         <objfiles_head>: Rename from objfiles.
4302         (object_files): Update.
4303         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4304         * guile/scm-pretty-print.c
4305         (ppscm_find_pretty_printer_from_objfiles): Update.
4306         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4307         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4308         Update.
4309         * python/py-progspace.c (pspy_get_objfiles): Update.
4310         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4311         Update.
4312         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4313         (objfpy_lookup_objfile_by_build_id): Update.
4314         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4315         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4316         Update.
4317         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4318         (expand_symtab_containing_pc, lookup_objfile_from_block)
4319         (lookup_static_symbol, basic_lookup_transparent_type)
4320         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4321         (find_line_symtab, info_sources_command)
4322         (default_collect_symbol_completion_matches_break_on)
4323         (make_source_files_completion_list, find_main_name): Update.
4324         * symmisc.c (print_symbol_bcache_statistics)
4325         (print_objfile_statistics, maintenance_print_symbols)
4326         (maintenance_print_msymbols, maintenance_print_objfiles)
4327         (maintenance_info_symtabs, maintenance_check_symtabs)
4328         (maintenance_expand_symtabs, maintenance_info_line_tables):
4329         Update.
4330         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4331         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4332         (map_overlay_command, unmap_overlay_command)
4333         (simple_overlay_update, expand_symtabs_matching)
4334         (map_symbol_filenames): Update.
4335         * symfile-debug.c (set_debug_symfile): Update.
4336         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4337         Update.
4338         * source.c (select_source_symtab, forget_cached_source_info):
4339         Update.
4340         * solib.c (solib_read_symbols): Update.
4341         * solib-spu.c (append_ocl_sos): Update.
4342         * psymtab.c (maintenance_print_psymbols)
4343         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4344         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4345         * printcmd.c (info_symbol_command): Update.
4346         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4347         Update.
4348         * objfiles.h (class all_objfiles): Remove.
4349         * objfiles.c (have_partial_symbols, have_full_symbols)
4350         (have_minimal_symbols, qsort_cmp, update_section_map)
4351         (shared_objfile_contains_address_p)
4352         (default_iterate_over_objfiles_in_search_order): Update.
4353         * objc-lang.c (info_selectors_command, info_classes_command)
4354         (find_methods): Update.
4355         * minsyms.c (find_solib_trampoline_target): Update.
4356         * maint.c (maintenance_info_sections)
4357         (maintenance_translate_address, count_symtabs_and_blocks):
4358         Update.
4359         * main.c (captured_main_1): Update.
4360         * linux-thread-db.c (try_thread_db_load_from_pdir)
4361         (has_libpthread): Update.
4362         * linespec.c (iterate_over_all_matching_symtabs)
4363         (search_minsyms_for_name): Update.
4364         * jit.c (jit_find_objf_with_entry_addr): Update.
4365         * hppa-tdep.c (find_unwind_entry)
4366         (hppa_lookup_stub_minimal_symbol): Update.
4367         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4368         Update.
4369         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4370         (elf_gnu_ifunc_resolve_by_got): Update.
4371         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4372         * dwarf-index-write.c (save_gdb_index_command): Update.
4373         * cp-support.c (add_symbol_overload_list_qualified): Update.
4374         * breakpoint.c (create_overlay_event_breakpoint)
4375         (create_longjmp_master_breakpoint)
4376         (create_std_terminate_master_breakpoint)
4377         (create_exception_master_breakpoint): Update.
4378         * blockframe.c (find_pc_partial_function): Update.
4379         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4380         (ada_collect_symbol_completion_matches)
4381         (ada_add_global_exceptions): Update.
4382
4383 2019-01-17  Tom Tromey  <tom@tromey.com>
4384
4385         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4386         declare VEC.
4387         (solib_target_parse_libraries): Change return type.
4388         (library_list_start_segment, library_list_start_section)
4389         (library_list_end_library, library_list_start_library); Update.
4390         (solib_target_free_library_list): Remove.
4391         (solib_target_parse_libraries): Remove cleanup.  Change return
4392         type.
4393         (solib_target_current_sos): Update.
4394
4395 2019-01-17  Tom Tromey  <tromey@bapiya>
4396
4397         * valprint.c: Replace "the the" with "the".
4398         * symtab.c: Replace "the the" with "the".
4399         * solib.c: Replace "the the" with "the".
4400         * solib-dsbt.c: Replace "the the" with "the".
4401         * linespec.c: Replace "the the" with "the".
4402         * dwarf2loc.h: Replace "the the" with "the".
4403         * amd64-windows-tdep.c: Replace "the the" with "the".
4404         * aarch64-tdep.c: Replace "the the" with "the".
4405
4406 2019-01-16  Keith Seitz  <keiths@redhat.com>
4407
4408         PR gdb/23773
4409         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4410         <builder>: Rename to ..
4411         <m_builder>: ... this and make private.
4412         (dwarf2_cu::get_builder): New method.  Change all users of
4413         `builder' to use this method.
4414         (dwarf2_start_symtab): Move to ...
4415         (dwarf2_cu::start_symtab): ... here.  Update all callers
4416         (setup_type_unit_groups): Move to ...
4417         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4418         callers.
4419         (dwarf2_cu::reset_builder): New method.
4420         (process_full_compunit, process_full_type_unit): Use
4421         dwarf2_cu::reset_builder.
4422         (follow_die_offset): Record the ancestor CU if it is different
4423         from the followed DIE's CU.
4424         (follow_die_sig_1): Likewise.
4425
4426 2019-01-15  Tom Tromey  <tom@tromey.com>
4427
4428         * remote.c (class remote_state) <buf>: Now a char_vector.
4429         <buf_size>: Remove.
4430         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4431         parameter.
4432         (remote_target::getpkt_or_notif_sane_1)
4433         (remote_target::getpkt_sane)
4434         (remote_target::getpkt_or_notif_sane): Likewise.
4435         (class remote_target) <putpkt>: New overload.
4436         (remote_target::read_frame): Change type of "buf_p".  Remove
4437         sizeof_p parameter.
4438         (packet_ok): New overload.
4439         (packet_check_result): New overload.
4440         Update all uses.
4441
4442 2019-01-14  Tom Tromey  <tom@tromey.com>
4443
4444         * remote-notif.c (handle_notification, remote_notif_ack)
4445         (remote_notif_parse): Make "buf" const.
4446         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4447         const.
4448         (remote_notif_parse, remote_notif_ack, handle_notification):
4449         Likewise.
4450         * remote.c (remote_notif_stop_parse): Make "buf" const.
4451         (remote_target::remote_parse_stop_reply): Make "buf" const.
4452         (remote_notif_stop_ack): Make "buf" const.
4453
4454 2019-01-14  Tom Tromey  <tom@tromey.com>
4455
4456         * remote.c (remote_console_output): Make parameter const.
4457
4458 2019-01-14  Tom Tromey  <tom@tromey.com>
4459
4460         * target-debug.h (target_debug_print_signals): Constify.
4461         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4462         * procfs.c (procfs_target::pass_signals): Update.
4463         * linux-nat.c (linux_nat_target::pass_signals): Update.
4464         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4465         * target-delegates.c: Rebuild.
4466         * remote.c (remote_target::program_signals): Update.
4467         (remote_target::pass_signals): Update.
4468         * target.c (target_pass_signals): Constify argument.
4469         (target_program_signals): Likewise.
4470         * target.h (struct target_ops) <pass_signals, program_signals>:
4471         Constify argument.
4472         (target_pass_signals, target_program_signals): Constify argument.
4473
4474 2019-01-14  Tom Tromey  <tom@tromey.com>
4475
4476         PR tui/28819:
4477         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4478
4479 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4480
4481         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4482         field.
4483         * rs6000-tdep.c: Include reggroups.h.
4484         (IS_V_ALIAS_PSEUDOREG): Define.
4485         (rs6000_register_name): Return names for the "vX" aliases.
4486         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4487         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4488         aliases.  Call default_register_reggroup_p for all other
4489         pseudo-registers.
4490         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4491         New functions.
4492         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4493         Handle "vX" aliases.
4494         (v_alias_pseudo_register_collect): New function.
4495         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4496         (rs6000_gdbarch_init): Initialize "vX" aliases as
4497         pseudo-registers.  Restore registration of
4498         rs6000_pseudo_register_reggroup_p with
4499         set_tdesc_pseudo_register_reggroup_p.
4500
4501 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4502
4503         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4504         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4505         set_gdbarch_num_pseudo_regs.
4506
4507 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4508
4509         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4510         Remove arg prefixname, add do_set and do_show.
4511         Add member functions set_list and show_list.
4512         * cli/cli-style.c (class cli_style_option): Update accordingly.
4513         (style_set_list): Move to file scope.
4514         (style_show_list): Likewise.
4515         (set_style): Call help_list.
4516         (show_style): Call cmd_show_list.
4517         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4518         Update to use the new macro.
4519
4520 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4521
4522         * ada-lang.c (_initialize_ada_language): Expand the help text
4523         for the "catch exception" command.
4524
4525 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4526
4527         * symtab.c (matching_obj_sections): Initialize obj,
4528         declare it closer to its usage.
4529
4530 2019-01-10  Tom Tromey  <tom@tromey.com>
4531
4532         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4533         (basic_inf_threads_range): Remove.
4534         (inf_threads_range, inf_non_exited_threads_range)
4535         (safe_inf_threads_range): Use next_adapter.
4536
4537 2019-01-10  Keith Seitz  <keiths@redhat.com>
4538
4539         PR gdb/23712
4540         PR symtab/23010
4541         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4542         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4543
4544 2019-01-10  Keith Seitz  <keiths@redhat.com>
4545
4546         PR gdb/23712
4547         PR symtab/23010
4548         * dictionary.c (pending_to_vector): Remove.
4549         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4550         Remove _1 suffix, replacing functions of the same name.  Update
4551         all callers.
4552         (dict_create_hashed, dict_create_hashed_expandable)
4553         (dict_create_linear, dict_create_linear_expandable, dict_free)
4554         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4555         Make functions static.
4556
4557 2019-01-10  Keith Seitz  <keiths@redhat.com>
4558
4559         PR gdb/23712
4560         PR symtab/23010
4561         * dictionary.h (struct dictionary): Replace declaration with
4562         multidictionary.
4563         (dict_create_hashed, dict_create_hashed_expandable)
4564         (dict_create_linear, dict_create_linear_expandable)
4565         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4566         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4567         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4568         taking multidictionary argument.
4569         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4570         * block.h (struct block) <dict>: Change to multidictionary
4571         and rename `multidict'.
4572         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4573         symmisc.c: Update all dictionary references to multidictionary.
4574
4575 2019-01-10  Keith Seitz  <keiths@redhat.com>
4576
4577         PR gdb/23712
4578         PR symtab/23010
4579         * dictionary.c: Include unordered_map.
4580         (pending_to_vector): New function.
4581         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4582         Rewrite the non-"_1" functions to take vector instead
4583         of linked list.
4584         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4585         "new" _1 versions of the same name.
4586         (multidictionary): Define.
4587         (std::hash<enum language): New definition.
4588         (collate_pending_symbols_by_language, mdict_create_hashed)
4589         (mdict_create_hashed_expandable, mdict_create_linear)
4590         (mdict_create_linear_expandable, mdict_free)
4591         (find_language_dictionary, create_new_language_dictionary)
4592         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4593         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4594         (mdict_size, mdict_empty): New functions.
4595         * dictionary.h (mdict_iterator): Define.
4596
4597 2019-01-10  Pedro Alves  <palves@redhat.com>
4598
4599         * breakpoint.c (read_uploaded_action)
4600         (create_tracepoint_from_upload): Adjust to use
4601         gdb::unique_xmalloc_ptr.
4602         * ctf.c (ctf_write_uploaded_tp):
4603         (SET_ARRAY_FIELD): Use emplace_back.
4604         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4605         * tracefile-tfile.c (tfile_write_uploaded_tp):
4606         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4607         gdb::unique_xmalloc_ptr.
4608         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4609         at_string, cond_string, cmd_strings>: Replace char pointers
4610         with gdb::unique_xmalloc_ptr.
4611
4612 2019-01-10  Pedro Alves  <palves@redhat.com>
4613
4614         * solib-target.c (library_list_start_library): Don't xstrdup name.
4615
4616 2019-01-10  Pedro Alves  <palves@redhat.com>
4617
4618         * mdebugread.c (parse_partial_symbols): Use
4619         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4620
4621 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         * linux-fork.c (scoped_switch_fork_info)
4624         <~scoped_switch_fork_info>: Fix incorrect variable name.
4625
4626 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4627
4628         * linux-fork.c (scoped_switch_fork_info)
4629         <scoped_switch_fork_info>: Make explicit.
4630         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4631
4632 2019-01-10  Tom Tromey  <tom@tromey.com>
4633
4634         * objfiles.h (objfile::reset_psymtabs): Update.
4635         * objfiles.c (objfile::objfile): Update.
4636         * psymtab.h (psymtab_storage::obstack): Update.
4637         (psymtab_storage::m_obstack): Use gdb::optional.
4638         (class psymtab_storage): Update comment.  Remove objfile
4639         parameter.
4640         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4641
4642 2019-01-10  Tom Tromey  <tom@tromey.com>
4643
4644         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4645         <free_psymtabs>: Now private.
4646         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4647         (allocate_psymtab): Use new method.
4648
4649 2019-01-10  Tom Tromey  <tom@tromey.com>
4650
4651         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4652         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4653         * mdebugread.c (parse_partial_symbols): Use
4654         allocate_dependencies.
4655         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4656         allocate_dependencies.
4657         (process_psymtab_comp_unit_reader)
4658         (build_type_psymtab_dependencies): Likewise.
4659         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4660
4661 2019-01-10  Tom Tromey  <tom@tromey.com>
4662
4663         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4664         PSYMBOL_SET_LANGUAGE.
4665         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4666
4667 2019-01-10  Tom Tromey  <tom@tromey.com>
4668
4669         * psymtab.h (psymtab_storage::obstack): New method.
4670         <m_obstack>: Rename from obstack; now private.
4671         * psymtab.c (psymtab_storage): Update.
4672         * dwarf2read.c (create_addrmap_from_index)
4673         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4674         Update.
4675
4676 2019-01-10  Tom Tromey  <tom@tromey.com>
4677
4678         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4679         * objfiles.h (objfile::reset_psymtabs): New method.
4680
4681 2019-01-10  Tom Tromey  <tom@tromey.com>
4682
4683         * symmisc.c (print_symbol_bcache_statistics): Update.
4684         (print_objfile_statistics): Update.
4685         * symfile.c (reread_symbols): Update.
4686         * psymtab.h (class psymtab_storage): New.
4687         * psymtab.c (psymtab_storage): New constructor.
4688         (~psymtab_storage): New destructor.
4689         (require_partial_symbols): Update.
4690         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4691         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4692         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4693         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4694         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4695         (start_psymtab_common, end_psymtab_common)
4696         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4697         (allocate_psymtab): Update.
4698         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4699         Update.
4700         (dump_psymtab_addrmap, maintenance_print_psymbols)
4701         (maintenance_check_psymtabs): Update.
4702         (class objfile_psymtabs): Move to objfiles.h.
4703         * psympriv.h (discard_psymtab): Now inline.
4704         (psymtab_discarder::psymtab_discarder): Update.
4705         (psymtab_discarder::~psymtab_discarder): Update.
4706         (ALL_OBJFILE_PSYMTABS): Rewrite.
4707         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4708         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4709         Remove fields.
4710         <partial_symtabs>: New field.
4711         (class objfile_psymtabs): Move from psymtab.h.  Update.
4712         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4713         psymbol_cache.
4714         (objfile::~objfile): Don't destroy psymbol_cache.
4715         * mdebugread.c (parse_partial_symbols): Update.
4716         * dwarf2read.c (create_addrmap_from_index)
4717         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4718         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4719         (add_partial_subprogram, dwarf2_ranges_read): Update.
4720         * dwarf-index-write.c (write_address_map)
4721         (write_one_signatured_type, recursively_write_psymbols)
4722         (class debug_names, class debug_names, write_psymtabs_to_index):
4723         Update.
4724
4725 2019-01-10  Tom Tromey  <tom@tromey.com>
4726
4727         * symtab.h (SYMBOL_SET_NAMES): Update.
4728         (symbol_set_names): Update.
4729         (MSYMBOL_SET_NAMES): Update.
4730         * symtab.c (symbol_set_names): Change argument to be an
4731         objfile_per_bfd_storage.
4732         * psymtab.c (add_psymbol_to_bcache): Update.
4733         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4734
4735 2019-01-10  Tom Tromey  <tom@tromey.com>
4736
4737         * symtab.c (create_demangled_names_hash): Change argument to be an
4738         objfile_per_bfd_storage.
4739         (symbol_set_names): Update.
4740
4741 2019-01-10  Tom Tromey  <tom@tromey.com>
4742
4743         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4744         init_psymbol_list.
4745         * psymtab.c (init_psymbol_list): Do nothing if already called.
4746         * psympriv.h (init_psymbol_list): Add comment.
4747         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4748         init_psymbol_list.
4749         * dbxread.c (dbx_symfile_read): Unconditionally call
4750         init_psymbol_list.
4751
4752 2019-01-10  Tom Tromey  <tom@tromey.com>
4753
4754         * xcoffread.c (scan_xcoff_symtab): Update.
4755         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4756         "where".
4757         * mdebugread.c (parse_partial_symbols)
4758         (handle_psymbol_enumerators): Update.
4759         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4760         * dbxread.c (read_dbx_symtab): Update.
4761         * psympriv.h (psymbol_placement): New enum.
4762         (add_psymbol_to_list): Update.
4763
4764 2019-01-10  Tom Tromey  <tom@tromey.com>
4765
4766         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4767         static_psymbols parameters.
4768         (scan_xcoff_symtab): Update.
4769         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4770         static_psymbols parameters.
4771         * psympriv.h (start_psymtab_common): Update.
4772         * mdebugread.c (parse_partial_symbols): Update.
4773         * dwarf2read.c (create_partial_symtab): Update.
4774         * dbxread.c (read_dbx_symtab): Update.
4775         (start_psymtab): Remove global_psymbols and static_psymbols
4776         parameters.
4777
4778 2019-01-10  Tom Tromey  <tom@tromey.com>
4779
4780         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4781         * psymtab.c (allocate_psymtab): Add comment.
4782         * psympriv.h (allocate_psymtab): Add comment.
4783         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4784         initializations.
4785         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4786
4787 2019-01-10  Tom Tromey  <tom@tromey.com>
4788
4789         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4790         Don't declare.
4791         * mipsread.c: Include mdebugread.h.
4792         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4793         Declare.
4794         * elfread.c: Include mdebugread.h.
4795
4796 2019-01-09  Tom Tromey  <tom@tromey.com>
4797
4798         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4799         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4800         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4801         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4802         (psym_lookup_symbol, psym_find_last_source_symtab)
4803         (psym_forget_cached_source_info, psym_print_stats)
4804         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4805         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4806         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4807         (psym_find_compunit_symtab_by_address)
4808         (maintenance_print_psymbols, maintenance_info_psymtabs)
4809         (maintenance_check_psymtabs): Use ranged for.
4810         * psymtab.h (class objfile_psymtabs): New.
4811         (require_partial_symbols): Return objfile_psymtabs.
4812         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4813
4814 2019-01-09  Tom Tromey  <tom@tromey.com>
4815
4816         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4817         (find_pc_mapped_section, list_overlays_command)
4818         (map_overlay_command, unmap_overlay_command)
4819         (simple_overlay_update): Use all_objfiles.
4820         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4821         * printcmd.c (info_symbol_command): Use all_objfiles.
4822         * objfiles.h (ALL_OBJSECTIONS): Remove.
4823         * maint.c (maintenance_translate_address): Use all_objfiles.
4824         * gcore.c (gcore_create_callback): Use all_objfiles.
4825         (objfile_find_memory_regions): Likewise.
4826
4827 2019-01-09  Tom Tromey  <tom@tromey.com>
4828
4829         * symtab.c (find_line_symtab, info_sources_command)
4830         (make_source_files_completion_list): Use objfile_compunits.
4831         * source.c (select_source_symtab): Use objfile_compunits.
4832         * objfiles.h (struct objfile): Update comment.
4833         (ALL_OBJFILES): Remove.
4834         (ALL_FILETABS): Remove.
4835         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4836         objfile_compunits.
4837
4838 2019-01-09  Tom Tromey  <tom@tromey.com>
4839
4840         * symmisc.c (print_objfile_statistics, dump_objfile)
4841         (maintenance_print_symbols): Use compunit_filetabs.
4842         * source.c (forget_cached_source_info_for_objfile): Use
4843         compunit_filetabs.
4844         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4845         (ALL_FILETABS): Use compunit_filetabs.
4846         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4847         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4848
4849 2019-01-09  Tom Tromey  <tom@tromey.com>
4850
4851         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4852         (compunit_filetabs): New.
4853         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4854         compunit_filetabs.
4855         (info_sources_command, make_source_files_completion_list): Remove
4856         declaration.
4857         * symmisc.c (print_objfile_statistics, dump_objfile)
4858         (maintenance_print_symbols): Remove declaration.
4859         (maintenance_info_symtabs): Use compunit_filetabs.
4860         (maintenance_info_line_tables): Likewise.
4861         * source.c (select_source_symtab): Change local variable name.
4862         (forget_cached_source_info_for_objfile): Remove declaration.
4863         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4864         * objfiles.c (objfile_relocate1): Remove declaration.
4865         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4866         declaration.
4867         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4868         * coffread.c (coff_symtab_read): Remove declaration.
4869         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4870         compunit_filetabs.
4871
4872 2019-01-09  Tom Tromey  <tom@tromey.com>
4873
4874         * symtab.c (lookup_objfile_from_block)
4875         (find_pc_sect_compunit_symtab, search_symbols)
4876         (default_collect_symbol_completion_matches_break_on): Use
4877         objfile_compunits.
4878         * objfiles.h (ALL_COMPUNITS): Remove.
4879         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4880         * cp-support.c (add_symbol_overload_list_qualified): Use
4881         objfile_compunits.
4882         * ada-lang.c (ada_collect_symbol_completion_matches)
4883         (ada_add_global_exceptions): Use objfile_compunits.
4884
4885 2019-01-09  Tom Tromey  <tom@tromey.com>
4886
4887         * source.c (select_source_symtab)
4888         (forget_cached_source_info_for_objfile): Remove declaration.
4889         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4890         declaration.
4891         * maint.c (count_symtabs_and_blocks): Remove declaration.
4892         * cp-support.c (add_symbol_overload_list_qualified): Remove
4893         declaration.
4894         * coffread.c (coff_symtab_read): Remove declaration.
4895         * symtab.c (lookup_symbol_in_objfile_symtabs)
4896         (basic_lookup_transparent_type_1): Use objfile_compunits.
4897         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4898         (info_sources_command, search_symbols)
4899         (default_collect_symbol_completion_matches_break_on)
4900         (make_source_files_completion_list): Remove declaration.
4901         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4902         (ada_collect_symbol_completion_matches)
4903         (ada_add_global_exceptions): Remove declaration.
4904         * linespec.c (iterate_over_all_matching_symtabs): Use
4905         objfile_compunits.
4906         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4907         (class objfile_compunits): New.
4908         (ALL_COMPUNITS): Use objfile_compunits.
4909         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4910         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4911         objfile_compunits.
4912         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4913
4914 2019-01-09  Tom Tromey  <tom@tromey.com>
4915
4916         * symtab.c (search_symbols)
4917         (default_collect_symbol_completion_matches_break_on): Use
4918         objfile_msymbols.
4919         * ada-lang.c (ada_lookup_simple_minsym)
4920         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4921         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4922         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4923         objfile_msymbols.
4924         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4925         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4926         * objc-lang.c (find_methods): Use objfile_msymbols.
4927         (info_selectors_command, info_classes_command): Likewise.
4928         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4929         * objfiles.h (class objfile_msymbols): New.
4930         (ALL_OBJFILE_MSYMBOLS): Remove.
4931         (ALL_MSYMBOLS): Remove.
4932
4933 2019-01-09  Tom Tromey  <tom@tromey.com>
4934
4935         * common/next-iterator.h (next_adapter): Add Iterator template
4936         parameter.
4937         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4938         (class all_objfiles_safe): New.
4939         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4940         * objfiles.c (put_objfile_before): Update comment.
4941         (add_separate_debug_objfile): Likewise.
4942         (free_all_objfiles): Use all_objfiles_safe.
4943         (objfile_purge_solibs): Likewise.
4944
4945 2019-01-09  Tom Tromey  <tom@tromey.com>
4946
4947         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4948         (expand_symtab_containing_pc, lookup_static_symbol)
4949         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4950         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4951         all_objfiles.
4952         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4953         * breakpoint.c (create_overlay_event_breakpoint)
4954         (create_longjmp_master_breakpoint)
4955         (create_std_terminate_master_breakpoint)
4956         (create_exception_master_breakpoint): Use all_objfiles.
4957         * linux-thread-db.c (try_thread_db_load_from_pdir)
4958         (has_libpthread): Use all_objfiles.
4959         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4960         * linespec.c (iterate_over_all_matching_symtabs)
4961         (search_minsyms_for_name): Use all_objfiles.
4962         * maint.c (maintenance_info_sections): Use all_objfiles.
4963         * main.c (captured_main_1): Use all_objfiles.
4964         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4965         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4966         * guile/scm-pretty-print.c
4967         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4968         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4969         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4970         (maintenance_print_msymbols): Use all_objfiles.
4971         * source.c (select_source_symtab): Use all_objfiles.
4972         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4973         * symfile.c (remove_symbol_file_command)
4974         (expand_symtabs_matching, map_symbol_filenames): Use
4975         all_objfiles.
4976         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4977         all_objfiles.
4978         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4979         * objc-lang.c (find_methods): Use all_objfiles.
4980         * objfiles.c (have_partial_symbols, have_full_symbols)
4981         (have_minimal_symbols, qsort_cmp)
4982         (default_iterate_over_objfiles_in_search_order): Use
4983         all_objfiles.
4984         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4985         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4986         (maintenance_check_psymtabs): Use all_objfiles.
4987         (ALL_PSYMTABS): Remove.
4988         * compile/compile-object-run.c (do_module_cleanup): Use
4989         all_objfiles.
4990         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4991         * cp-support.c (add_symbol_overload_list_qualified): Use
4992         all_objfiles.
4993         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4994         Use all_objfiles.
4995         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4996         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4997         all_objfiles.
4998         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4999         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5000         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5001         Uses all_objfiles.
5002         * solib.c (solib_read_symbols): Use all_objfiles
5003
5004 2019-01-09  Tom Tromey  <tom@tromey.com>
5005
5006         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5007         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5008         all_objfiles.
5009         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5010         * symmisc.c (print_symbol_bcache_statistics)
5011         (print_objfile_statistics, maintenance_print_objfiles)
5012         (maintenance_info_symtabs, maintenance_check_symtabs)
5013         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5014         all_objfiles.
5015         * source.c (forget_cached_source_info): Use all_objfiles.
5016         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5017         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5018         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5019         * objfiles.c (update_section_map): Use all_objfiles.
5020         (shared_objfile_contains_address_p): Likewise.
5021         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5022         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5023
5024 2019-01-09  Tom Tromey  <tom@tromey.com>
5025
5026         * common/next-iterator.h: New file.
5027         * objfiles.h (class all_objfiles): New.
5028         (struct objfile_iterator): New.
5029
5030 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5031
5032         * NEWS: Move the description of the changed "frame", "select-frame",
5033          and "info frame" commands to the Changed commands section.
5034
5035 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5036
5037         * gdbtypes.c (check_stub_method_group): Remove handling of old
5038         mangling schemes.
5039         * linespec.c (find_methods): Likewise.
5040         * stabsread.c (read_member_functions): Likewise.
5041         * valops.c (search_struct_method): Likewise.
5042         (value_struct_elt_for_reference): Likewise.
5043         * NEWS: Mention this change.
5044
5045 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5046
5047         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5048         print_source_lines.
5049         * source.c (print_source_lines_base): Update line number check.
5050         (print_source_lines): New function.
5051         (source_lines_range::source_lines_range): New function.
5052         * source.h (class source_lines_range): New class.
5053         (print_source_lines): New declaration.
5054
5055 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5056
5057         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5058
5059 2019-01-08  Tom Tromey  <tom@tromey.com>
5060             Simon Marchi  <simon.marchi@ericsson.com>
5061
5062         PR gdb/24060
5063         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5064         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5065         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5066         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5067         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5068         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5069
5070 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5071
5072         * source.c (select_source_symtab): Move header comment to
5073         declaration in source.h.
5074         (forget_cached_source_info_for_objfile): Likewise.
5075         (forget_cached_source_info): Likewise.
5076         (identify_source_line): Likewise.
5077         * source.h (identify_source_line): Move declaration from symtab.h
5078         and add comment from source.c
5079         (print_source_lines): Likewise.
5080         (forget_cached_source_info_for_objfile): Likewise.
5081         (forget_cached_source_info): Likewise.
5082         (select_source_symtab): Likewise.
5083         (enum print_source_lines_flag): Move definition from symtab.h.
5084         * symtab.h (identify_source_line): Move declaration to source.h.
5085         (print_source_lines): Likewise.
5086         (forget_cached_source_info_for_objfile): Likewise.
5087         (forget_cached_source_info): Likewise.
5088         (select_source_symtab): Likewise.
5089         (enum print_source_lines_flag): Move definition to source.h.
5090         * tui/tui-hooks.c: Add 'source.h' include.
5091
5092 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5093
5094         * source.c (print_source_lines_base): Handle requests to print
5095         reverse line number sequences, and guard against empty lines
5096         string.
5097
5098 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5099
5100         * source.c (print_source_lines_base): Fix skip of '\r' if next
5101         character is '\n'.
5102
5103 2019-01-06  Tom Tromey  <tom@tromey.com>
5104
5105         * c-exp.y (struct c_parse_state) <macro_original_text,
5106         expansion_obstack>: New member.
5107         (macro_original_text, expansion_obstack): Remove globals.
5108         (scan_macro_expansion, scanning_macro_expansion)
5109         (finished_macro_expansion): Update.
5110         (scan_macro_cleanup): Remove.
5111         (yylex, c_parse): Update.
5112
5113 2019-01-06  Tom Tromey  <tom@tromey.com>
5114
5115         * c-exp.y (struct c_parse_state) <strings>: New member.
5116         (operator_stoken): Update.
5117
5118 2019-01-06  Tom Tromey  <tom@tromey.com>
5119
5120         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5121         (union type_stack_elt) <typelist_val>: Now a pointer to
5122         std::vector.
5123         (type_stack_cleanup): Don't declare.
5124         (push_typelist): Update.
5125         * parse.c (pop_typelist): Return a std::vector.
5126         (push_typelist): Take a std::vector.
5127         (follow_types): Update.  Do not free args.
5128         (type_stack_cleanup): Remove.
5129         * c-exp.y (struct c_parse_state): New.
5130         (cpstate): New global.
5131         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5132         (nonempty_typelist): Update.
5133         (func_mod): Create a new vector.
5134         (c_parse): Create a c_parse_state.
5135         (check_parameter_typelist): Do not delete params.
5136         (function_method): Update.  Do not delete type_list.
5137
5138 2019-01-06  Tom Tromey  <tom@tromey.com>
5139
5140         PR gdb/28155:
5141         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5142         check_typedef.
5143         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5144         (print_return_value): Likewise.
5145
5146 2019-01-05  Tom Tromey  <tom@tromey.com>
5147
5148         * contrib/cleanup_check.py: Remove.
5149         * contrib/gcc-with-excheck: Remove.
5150         * contrib/exsummary.py: Remove.
5151         * contrib/excheck.py: Remove.
5152
5153 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5154
5155         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5156         NULL. Initialize tpprev to NULL instead of assigning it
5157         to NULL on the next statement.
5158         * windows-nat.c (windows_delete_thread): Remove check for
5159         main_thread_id before printing thread exit notifications.
5160         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5161         Remove thread ID check against main_thread_id.
5162         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5163         windows_delete_thread.
5164         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5165
5166 2019-01-04  Tom Tromey  <tom@tromey.com>
5167
5168         * compile/compile.c (_initialize_compile): Use upper case for
5169         metasyntactic variables.
5170         * symmisc.c (_initialize_symmisc): Use upper case for
5171         metasyntactic variables.
5172         * psymtab.c (_initialize_psymtab): Use upper case for
5173         metasyntactic variables.
5174         * demangle.c (demangle_command): Use upper case for metasyntactic
5175         variables.
5176         (_initialize_demangler): Likewise.
5177         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5178         variables.
5179
5180 2019-01-03  Tom Tromey  <tom@tromey.com>
5181
5182         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5183
5184 2019-01-03  Tom Tromey  <tom@tromey.com>
5185
5186         * python/py-symtab.c (salpy_str): Update.
5187         (struct salpy_sal_object) <symtab>: Now a PyObject.
5188         (salpy_dealloc): Update.
5189         (del_objfile_sal): Use gdbpy_ref.
5190
5191 2019-01-03  Tom Tromey  <tom@tromey.com>
5192
5193         * python/py-type.c (convert_field): Use new_reference.  Return
5194         gdbpy_ref.
5195         (make_fielditem): Return gdbpy_ref.
5196         (typy_fields): Update.
5197         (typy_getitem): Update.
5198         (field_name): Return gdbpy_ref.  Use new_reference.
5199         (typy_iterator_iternext): Update.
5200
5201 2019-01-03  Tom Tromey  <tom@tromey.com>
5202
5203         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5204
5205 2019-01-03  Tom Tromey  <tom@tromey.com>
5206
5207         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5208         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5209         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5210         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5211         (pspy_set_type_printers): Likewise.
5212         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5213         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5214         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5215         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5216         (objfpy_set_type_printers): Likewise.
5217
5218 2019-01-03  Tom Tromey  <tom@tromey.com>
5219
5220         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5221         (gdbpy_print_stack): Use gdbpy_err_fetch.
5222         * python/python-internal.h (class gdbpy_err_fetch): New class.
5223         (class gdbpy_enter) <m_error_type, m_error_value,
5224         m_error_traceback>: Remove.
5225         <m_error>: New member.
5226         (gdbpy_exception_to_string): Don't declare.
5227         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5228         * python/py-value.c (convert_value_from_python): Use
5229         gdbpy_err_fetch.
5230         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5231         gdbpy_exception_to_string.
5232         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5233         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5234         gdbpy_err_fetch.
5235
5236 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5237
5238         * linux-nat.c (delete_lwp_cleanup): Delete.
5239         (struct lwp_deleter): New struct.
5240         (lwp_info_up): New typedef.
5241         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5242         lwp_info_up.
5243
5244 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5245
5246         * linux-fork.c (class scoped_switch_fork_info): New class.
5247         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5248
5249 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5250
5251         * valops.c (find_overload_match): Remove use of null_cleanup, and
5252         calls to do_cleanups.
5253
5254 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5255
5256         * compile/compile-cplus-types.c
5257         (compile_cplus_instance::decl_name): Handle changes to
5258         cp_func_name.
5259         * cp-support.c (cp_func_name): Update header comment, update
5260         return type.
5261         * cp-support.h (cp_func_name): Update return type in declaration.
5262         * valops.c (find_overload_match): Move temp_func local to top
5263         level of function and change its type.  Use temp_func to hold and
5264         delete temporary string obtained from cp_func_name.
5265
5266 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5267
5268         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5269         gdb::char_vector, remove cleanup, and update uses of `msg`.
5270
5271 2019-01-03  Jim Wilson  <jimw@sifive.com>
5272
5273         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5274
5275 2019-01-02  Tom Tromey  <tom@tromey.com>
5276
5277         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5278         (tdesc_parse_xml): Remove cleanups.
5279         * target-descriptions.h (make_cleanup_free_target_description):
5280         Don't declare.
5281         (target_desc_deleter): New struct.
5282         (target_desc_up): New typedef.
5283         * target-descriptions.c (target_desc_deleter::operator()): Rename
5284         from free_target_description.
5285         (make_cleanup_free_target_description): Remove.
5286
5287 2019-01-02  Tom Tromey  <tom@tromey.com>
5288
5289         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5290         constructor, destructor.
5291         (linespec_parser): Remove typedef.
5292         (~linespec_parser): Rename from linespec_parser_delete.
5293         (linespec_lex_to_end, linespec_complete_label)
5294         (linespec_complete): Update.
5295         (decode_line_full): Remove cleanups.
5296         (decode_line_1): Update.
5297
5298 2019-01-02  Tom Tromey  <tom@tromey.com>
5299
5300         * python/python-internal.h (inferior_to_inferior_object): Change
5301         return type.
5302         * python/py-exitedevent.c (create_exited_event_object): Update.
5303         * python/py-inferior.c (inferior_to_inferior_object): Return
5304         gdbpy_ref.
5305         (python_new_inferior, python_inferior_deleted)
5306         (thread_to_thread_object, delete_thread_object)
5307         (build_inferior_list, gdbpy_selected_inferior): Update.
5308         * python/py-infthread.c (create_thread_object): Update.  Also fail
5309         if inferior_to_inferior_object fails.
5310
5311 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5312
5313         * inferior.h (class inferior) <displaced_step_state>: New field.
5314         * infrun.h (struct displaced_step_state): Move here from
5315         infrun.c.  Initialize fields, add constructor.
5316         <inf>: Remove field.
5317         <reset>: New method.
5318         * infrun.c (struct displaced_step_inferior_state): Move to
5319         infrun.h.
5320         (displaced_step_inferior_states): Remove.
5321         (get_displaced_stepping_state): Adust.
5322         (displaced_step_in_progress_any_inferior): Adjust.
5323         (displaced_step_in_progress_thread): Adjust.
5324         (displaced_step_in_progress): Adjust.
5325         (add_displaced_stepping_state): Remove.
5326         (get_displaced_step_closure_by_addr): Adjust.
5327         (remove_displaced_stepping_state): Remove.
5328         (infrun_inferior_exit): Call displaced_step_state.reset.
5329         (use_displaced_stepping): Don't check for NULL.
5330         (displaced_step_prepare_throw): Call
5331         get_displaced_stepping_state.
5332         (displaced_step_fixup): Don't check for NULL.
5333         (prepare_for_detach): Don't check for NULL.
5334
5335 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5336
5337         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5338          in case of call that did not complete.
5339
5340 2019-01-02  Andrey Utkin  <autkin@undo.io>
5341
5342         * symfile.c (find_separate_debug_file): Fix search of debug files for
5343         remote debuggee.
5344
5345 2019-01-02  Tom Tromey  <tom@tromey.com>
5346
5347         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5348         indentation.
5349         * python/py-frame.c (frapy_older): Remove cast.
5350         (frapy_newer): Likewise.
5351         * python/py-breakpoint.c (local_setattro): Remove cast.
5352         * python/py-arch.c (archpy_name): Remove local variable.
5353         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5354
5355 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5356
5357         * unittests/basic_string_view/element_access/char/empty.cc:
5358         Fix year range in copyright header.
5359
5360 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5361
5362         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5363         Delete.
5364         <operator==>: Update with for removed field.
5365         <hash>: Likewise.
5366         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5367         <isa_features>: ...this.
5368         <abi_features>: New field.
5369         (riscv_isa_flen): Update comment.
5370         (riscv_abi_xlen): New declaration.
5371         (riscv_abi_flen): New declaration.
5372         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5373         isa_features.
5374         (riscv_abi_xlen): New function.
5375         (riscv_isa_flen): Update to get answer from isa_features.
5376         (riscv_abi_flen): New function.
5377         (riscv_has_fp_abi): Update to get answer from abi_features.
5378         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5379         xlen and flen.
5380         (riscv_call_info) <xlen, flen>: Update comment.
5381         (riscv_call_arg_struct): Remove invalid assertions
5382         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5383         is removed.
5384         (riscv_gdbarch_init): Gather isa features and abi features
5385         separately, ensure both match on the gdbarch when reusing an old
5386         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5387         a target with 64-bit float hardware.
5388
5389 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5390
5391         * source.c (search_command_helper): Stop reverse search
5392         when line 1 has been searched.
5393
5394 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5395
5396         * record-full.c (record_full_base_target::close): Rewrite
5397         record_full_core_buf_list free logic.
5398
5399 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5400
5401         * break-catch-syscall.c (print_one_catch_syscall): xfree
5402         the last text.
5403
5404 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5405
5406         * top.c (print_gdb_version): Update Copyright year in version
5407         message.
5408
5409 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5410
5411         Update copyright year range in all GDB files.
5412
5413 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5414
5415         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5416
5417 For older changes see ChangeLog-2018.
5418 \f
5419 Local Variables:
5420 mode: change-log
5421 left-margin: 8
5422 fill-column: 74
5423 version-control: never
5424 coding: utf-8
5425 End:
5426