gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * objc-lang.c (objc_objfile_data): Change type.
   4         (find_methods): Update.
   5         (_initialize_objc_lang): Remove.
   6
   7 2019-05-08  Tom Tromey  <tom@tromey.com>
   8
   9         * stabsread.c (rs6000_builtin_type_data): Change type.
  10         (rs6000_builtin_type, _initialize_stabsread): Update.
  11
  12 2019-05-08  Tom Tromey  <tom@tromey.com>
  13
  14         * mips-tdep.c (mips_pdr_data): Remove.
  15         (_initialize_mips_tdep): Update.
  16
  17 2019-05-08  Tom Tromey  <tom@tromey.com>
  18
  19         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
  20         (hppa_init_objfile_priv_data, read_unwind_info)
  21         (find_unwind_entry, _initialize_hppa_tdep): Update.
  22
  23 2019-05-08  Tom Tromey  <tom@tromey.com>
  24
  25         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
  26         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
  27         on obstack.
  28         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
  29
  30 2019-05-08  Tom Tromey  <tom@tromey.com>
  31
  32         * mdebugread.c (basic_type_data): Change type.
  33         (basic_type, _initialize_mdebugread): Update.
  34
  35 2019-05-08  Tom Tromey  <tom@tromey.com>
  36
  37         * common/gdb_unique_ptr.h (struct noop_deleter): New.
  38
  39 2019-05-08  Tom Tromey  <tom@tromey.com>
  40
  41         * nto-tdep.c (nto_inferior_data_reg): Change type.
  42         (nto_inferior_data): Update.
  43         (nto_inferior_data_cleanup, nto_new_inferior_data)
  44         (_initialize_nto_tdep): Remove.
  45         * nto-tdep.h (struct nto_inferior_data): Add initializers.
  46
  47 2019-05-08  Tom Tromey  <tom@tromey.com>
  48
  49         * ada-lang.c (struct ada_inferior_data): Add initializers.
  50         (ada_inferior_data): Change type.
  51         (ada_inferior_data_cleanup): Remove.
  52         (get_ada_inferior_data, ada_inferior_exit)
  53         (struct ada_pspace_data): Add initializers, destructor.
  54         (ada_pspace_data_handle): Change type.
  55         (get_ada_pspace_data): Update.
  56         (ada_pspace_data_cleanup): Remove.
  57
  58 2019-05-08  Tom Tromey  <tom@tromey.com>
  59
  60         * coffread.c (struct coff_symfile_info): Add initializers.
  61         (coff_objfile_data_key): Move lower.  Change type.
  62         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
  63         Update.
  64         (coff_free_info): Remove.
  65
  66 2019-05-08  Tom Tromey  <tom@tromey.com>
  67
  68         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  69         (fbsd_pspace_data_handle): Move lower.  Change type.
  70         (get_fbsd_pspace_data): Update.
  71         (fbsd_pspace_data_cleanup): Remove.
  72         (_initialize_fbsd_tdep): Update.
  73
  74 2019-05-08  Tom Tromey  <tom@tromey.com>
  75
  76         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  77         (get_ada_tasks_pspace_data): Update.
  78         (ada_tasks_pspace_data_cleanup): Remove.
  79         (_initialize_tasks): Update.
  80         (ada_tasks_inferior_data_handle): Change type.
  81         (get_ada_tasks_inferior_data): Update.
  82         (ada_tasks_inferior_data_cleanup): Remove.
  83         (struct ada_tasks_pspace_data): Add initializers.
  84
  85 2019-05-08  Tom Tromey  <tom@tromey.com>
  86
  87         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  88         * symfile-debug.c (debug_sym_get_probes): Change type.
  89         * stap-probe.c (handle_stap_probe):
  90         (stap_static_probe_ops::get_probes): Change type.
  91         * probe.h (class static_probe_ops) <get_probes>: Change type.
  92         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
  93         (parse_probes_in_pspace): Update.
  94         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
  95         Update.
  96         (any_static_probe_ops::get_probes): Change type.
  97         * elfread.c (elfread_data): New typedef.
  98         (probe_key): Change type.
  99         (elf_get_probes): Likewise.  Update.
 100         (probe_key_free): Remove.
 101         (_initialize_elfread): Update.
 102         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 103         Change type.
 104         (dtrace_process_dof_probe, dtrace_process_dof)
 105         (dtrace_static_probe_ops::get_probe): Change type.
 106
 107 2019-05-08  Tom Tromey  <tom@tromey.com>
 108
 109         * xcoffread.c (struct xcoff_symfile_info): Rename from
 110         coff_symfile_info.  Add initializers.
 111         (xcoff_objfile_data_key): Move lower.  Change type.
 112         (XCOFF_DATA): Rewrite.
 113         (xcoff_free_info): Remove.
 114         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 115         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 116         (xcoff_initial_scan): Update.
 117
 118 2019-05-08  Tom Tromey  <tom@tromey.com>
 119
 120         * solib-svr4.c (struct svr4_info): Add initializers and
 121         destructor.
 122         <probes_table>: Now an htab_up.
 123         (solib_svr4_pspace_data): Change type.
 124         (free_probes_table): Simplify.
 125         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 126         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 127         (probes_table_remove_objfile_probes, register_solib_event_probe)
 128         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 129         (_initialize_svr4_solib): Update.
 130
 131 2019-05-08  Tom Tromey  <tom@tromey.com>
 132
 133         * remote.c (remote_pspace_data): Change type.
 134         (remote_pspace_data_cleanup): Remove.
 135         (get_remote_exec_file, set_pspace_remote_exec_file)
 136         (_initialize_remote): Update.
 137
 138 2019-05-08  Tom Tromey  <tom@tromey.com>
 139
 140         * breakpoint.c (breakpoint_objfile_key): Change type.
 141         (get_breakpoint_objfile_data): Update.
 142         (free_breakpoint_objfile_data): Remove.
 143         (_initialize_breakpoint): Update.
 144
 145 2019-05-08  Tom Tromey  <tom@tromey.com>
 146
 147         * linux-tdep.c (struct linux_info): Add initializers.
 148         (linux_inferior_data): Move.  Change type.
 149         (invalidate_linux_cache_inf): Update.
 150         (linux_inferior_data_cleanup): Remove.
 151         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 152
 153 2019-05-08  Tom Tromey  <tom@tromey.com>
 154
 155         * auxv.c (auxv_inferior_data): Move.  Change type.
 156         (auxv_inferior_data_cleanup): Remove.
 157         (invalidate_auxv_cache_inf): Rewrite.
 158         (get_auxv_inferior_data, _initialize_auxv): Update.
 159
 160 2019-05-08  Tom Tromey  <tom@tromey.com>
 161
 162         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 163         (symfile_debug_objfile_data_key): Change type.
 164         (symfile_debug_installed, debug_qf_has_symbols)
 165         (debug_qf_find_last_source_symtab)
 166         (debug_qf_forget_cached_source_info)
 167         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 168         (debug_qf_print_stats, debug_qf_dump)
 169         (debug_qf_expand_symtabs_for_function)
 170         (debug_qf_expand_all_symtabs)
 171         (debug_qf_expand_symtabs_with_fullname)
 172         (debug_qf_map_matching_symbols)
 173         (debug_qf_expand_symtabs_matching)
 174         (debug_qf_find_pc_sect_compunit_symtab)
 175         (debug_qf_map_symbol_filenames)
 176         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 177         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 178         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 179         (debug_sym_read_linetable, debug_sym_relocate): Update.
 180         (symfile_debug_free_objfile): Remove.
 181         (install_symfile_debug_logging, _initialize_symfile_debug):
 182         Update.
 183
 184 2019-05-08  Tom Tromey  <tom@tromey.com>
 185
 186         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 187         allocate_on_obstack.
 188         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 189         (get_dwarf2_per_objfile): Update.
 190         (set_dwarf2_per_objfile): Remove.
 191         (dwarf2_has_info, dwarf2_get_section_info): Update.
 192         (dwarf2_free_objfile): Remove.
 193         (_initialize_dwarf2_read): Update.
 194
 195 2019-05-08  Tom Tromey  <tom@tromey.com>
 196
 197         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 198         initializers.
 199         <unsupported_script_warning_printed,
 200         script_not_found_warning_printed>: Now bool.
 201         (auto_load_pspace_data): Change type.
 202         (~auto_load_pspace_info): Rename from
 203         auto_load_pspace_data_cleanup.
 204         (get_auto_load_pspace_data, init_loaded_scripts_info)
 205         (clear_section_scripts, maybe_print_unsupported_script_warning)
 206         (maybe_print_script_not_found_warning, _initialize_auto_load):
 207         Update.
 208
 209 2019-05-08  Tom Tromey  <tom@tromey.com>
 210
 211         * objfiles.c (objfile_pspace_info): Add destructor and
 212         initializers.
 213         (objfiles_pspace_data): Change type.
 214         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 215         (get_objfile_pspace_data): Update.
 216         (objfiles_bfd_data): Change type.
 217         (get_objfile_bfd_data): Update.
 218         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 219
 220 2019-05-08  Tom Tromey  <tom@tromey.com>
 221
 222         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 223         Change type.
 224         (get_catch_syscall_inferior_data): Update.
 225         (catch_syscall_inferior_data_cleanup): Remove.
 226         (_initialize_break_catch_syscall): Update.
 227
 228 2019-05-08  Tom Tromey  <tom@tromey.com>
 229
 230         * inflow.c (struct terminal_info): Add destructor and
 231         initializers.
 232         (inflow_inferior_data): Change type.
 233         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 234         (get_inflow_inferior_data, inflow_inferior_exit)
 235         (swap_terminal_info, _initialize_inflow): Update.
 236
 237 2019-05-08  Tom Tromey  <tom@tromey.com>
 238
 239         * target-dcache.c (target_dcache_cleanup): Remove.
 240         (target_dcache_aspace_key): Change type.
 241         (target_dcache_init_p, target_dcache_invalidate)
 242         (target_dcache_get, target_dcache_get_or_init)
 243         (_initialize_target_dcache): Update.
 244         * dcache.h (struct dcache_deleter): New.
 245
 246 2019-05-08  Tom Tromey  <tom@tromey.com>
 247
 248         * symtab.c (struct symbol_cache): Add destructor and
 249         initializers.
 250         (symbol_cache_key): Move.  Change type.
 251         (make_symbol_cache, free_symbol_cache): Remove.
 252         (get_symbol_cache): Update.
 253         (symbol_cache_cleanup): Remove.
 254         (ALL_PSPACES, symbol_cache_flush)
 255         (maintenance_print_symbol_cache)
 256         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 257         Update.
 258
 259 2019-05-08  Tom Tromey  <tom@tromey.com>
 260
 261         * symtab.c (struct main_info): Add destructor and initializers.
 262         (main_progspace_key): Move.  Change type.
 263         (get_main_info): Update.
 264         (main_info_cleanup): Remove.
 265         (_initialize_symtab): Update.
 266
 267 2019-05-08  Tom Tromey  <tom@tromey.com>
 268
 269         * registry.h (DECLARE_REGISTRY): Define the _key class.
 270
 271 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 272
 273         * NEWS: Merge two 'New commands' sections.
 274
 275 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 276
 277         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 278         parameter and use Ada language definition instead.
 279         (ada_val_print_ptr): Remove unused language parameter.
 280         (ada_val_print_num): Remove language parameter and use Ada language
 281         definition instead.
 282         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 283         parameter.
 284         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 285         parameter and use Ada language definition instead.
 286         (ada_val_print_1): Update all ada_val_print_xxx calls.
 287         Remove language parameter.
 288         (ada_val_print): Update ada_val_print_1 call.
 289
 290 2019-05-08  Tom Tromey  <tromey@adacore.com>
 291
 292         * remote.c (remote_hw_watchpoint_limit)
 293         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 294         Now static.
 295
 296 2019-05-08  Tom Tromey  <tromey@adacore.com>
 297
 298         * maint.c (_initialize_maint_cmds): Move initialization code to
 299         remote.c.
 300         (watchdog, show_watchdog): Move to remote.c.
 301         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 302         "watchdog" static.
 303         (_initialize_remote): Move initialization code from maint.c.
 304         * defs.h (watchdog): Don't declare.
 305
 306 2019-05-08  Tom Tromey  <tromey@adacore.com>
 307
 308         * tui/tui-interp.c: Include main.h.
 309         * interps.c: Include main.h.
 310         * main.h (interpreter_p): Declare.
 311         * defs.h (interpreter_p): Don't declare.
 312
 313 2019-05-08  Tom Tromey  <tromey@adacore.com>
 314
 315         * dwarf2loc.c: Include dwarf2read.h.
 316         * defs.h (read_unsigned_leb128): Don't declare.
 317         * dwarf2read.h (read_unsigned_leb128): Declare.
 318
 319 2019-05-08  Tom Tromey  <tromey@adacore.com>
 320
 321         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 322         method.
 323
 324 2019-05-08  Tom Tromey  <tromey@adacore.com>
 325
 326         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 327         when no wrap column is set.
 328
 329 2019-05-08  Tom Tromey  <tromey@adacore.com>
 330
 331         * c-lang.c (c_get_string): Handle non-C-style arrays.
 332
 333 2019-05-08  Tom Tromey  <tromey@adacore.com>
 334
 335         * typeprint.c (print_offset_data::update): Print the bit offset,
 336         not the number of bits remaining.
 337
 338 2019-05-08  Tom Tromey  <tromey@adacore.com>
 339
 340         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 341         padding at end of comment.
 342
 343 2019-05-08  Tom Tromey  <tromey@adacore.com>
 344
 345         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 346         Compare main types.
 347
 348 2019-05-06  Tom Tromey  <tom@tromey.com>
 349
 350         * common/scoped_mmap.c: Include common-defs.h.
 351         * common/scoped_mmap.h: Don't include config.h.
 352
 353 2019-05-04  Tom Tromey  <tom@tromey.com>
 354
 355         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 356         (struct aarch64_call_info): Add initializers.
 357         <si>: Now a std::vector.
 358         (pass_on_stack, aarch64_push_dummy_call): Update.
 359
 360 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 361             Tom Tromey  <tom@tromey.com>
 362
 363         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 364         (ppc_threads): Now a std::vector.  Now static.
 365         (hwdebug_find_thread_points_by_tid)
 366         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 367         Update.
 368
 369 2019-05-04  Tom Tromey  <tom@tromey.com>
 370
 371         * arc-tdep.c (arc_tdesc_init): Return bool.
 372
 373 2019-05-04  Tom Tromey  <tom@tromey.com>
 374
 375         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 376         Use gdb_assert_not_reached.
 377
 378 2019-05-04  Tom Tromey  <tom@tromey.com>
 379
 380         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 381         "false".
 382
 383 2019-05-04  Tom Tromey  <tom@tromey.com>
 384
 385         * arc-tdep.c (arc_tdesc_init): Use bool.
 386
 387 2019-05-04  Tom Tromey  <tom@tromey.com>
 388
 389         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 390
 391 2019-05-04  Tom Tromey  <tom@tromey.com>
 392
 393         * cli/cli-cmds.c (valid_command_p): Return bool.
 394
 395 2019-05-04  Tom Tromey  <tom@tromey.com>
 396
 397         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 398         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 399
 400 2019-05-04  Raul Tambre  <raul@tambre.ee>
 401
 402         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 403         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 404         operator for comparison.
 405
 406 2019-05-04  Tom Tromey  <tom@tromey.com>
 407
 408         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 409         (lookup_partial_symbol, print_partial_symbols)
 410         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 411         (psymbol_compare): Update.
 412         (add_psymbol_to_bcache): Clear the entire psymbol.
 413         (maintenance_check_psymtabs): Update.
 414         * psympriv.h (struct partial_symbol): Don't derive from
 415         general_symbol_info.
 416         <obj_section, unrelocated_address, address,
 417         set_unrelocated_address>: Update.
 418         <ginfo>: New member.
 419         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 420         (debug_names::write_psymbols): Update.
 421
 422 2019-05-04  Tom de Vries  <tdevries@suse.de>
 423
 424         * contrib/cc-with-tweaks.sh: Support -n arg.
 425
 426 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 427
 428         * corelow.c (core_target::detach): Ensure frame cache and
 429         register caches are cleared.
 430         inferior.c (exit_inferior_1): Likewise.
 431
 432 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 433             Tom Tromey  <tom@tromey.com>
 434
 435         * dictionary.c (collate_pending_symbols_by_language): Remove
 436         "struct" from foreach.
 437         * symtab.c (lookup_global_symbol_from_objfile)
 438         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 439         foreach.
 440         * ser-tcp.c (net_open): Remove "struct" from foreach.
 441         * objfiles.c (objfile_relocate, objfile_rebase)
 442         (objfile_has_symbols): Remove "struct" from foreach.
 443         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 444         from foreach.
 445         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 446         foreach.
 447         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 448         "struct" from foreach.
 449         * ada-lang.c (create_excep_cond_exprs)
 450         (ada_exception_catchpoint_cond_string): Remove "struct" from
 451         foreach.
 452
 453 2019-05-03  Tom Tromey  <tromey@adacore.com>
 454
 455         * ada-exp.y (convert_char_literal): Check suffix of each
 456         enumerator.
 457
 458 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 459
 460         PR ada/21406:
 461         * ada-exp.y (yywrap): Don't define.
 462         * ada-lex.l (%option): Add noyywrap
 463         (yywrap): Remove.
 464
 465 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 466
 467         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 468         _WIN32_WINNT to the XP level, unless already defined to a higher
 469         level.
 470
 471         * unittests/parse-connection-spec-selftests.c:
 472         * ser-tcp.c:
 473         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 474         override.
 475
 476         * symfile.c (find_separate_debug_file): Remove colon from the
 477         drive spec of DOS/Windows file names of the target, so that the
 478         file name produced from DEBUGDIR and the target's directory will
 479         be valid on DOS/Windows systems.
 480
 481 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         * rust-lang.c (val_print_struct): Handle printing structures
 484         containing strings.
 485
 486 2019-05-02  Tom Tromey  <tromey@adacore.com>
 487
 488         * valarith.c (_initialize_valarith): Remove.
 489
 490 2019-05-01  Tom Tromey  <tromey@adacore.com>
 491
 492         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 493         bitfields.
 494
 495 2019-05-01  Tom Tromey  <tromey@adacore.com>
 496
 497         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 498         for big-endian copies.
 499
 500 2019-04-30  Ali Tamur  <tamur@google.com>
 501         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 502         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 503         (read_3_bytes): New function.
 504
 505 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 506
 507         * windows-nat.c (main_thread_id): Delete.
 508         (handle_output_debug_string): Replace main_thread_id by
 509         current_event.dwThreadId.
 510         (fake_create_process): Likewise.
 511         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 512         Do not set main_thread_id.
 513         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 514         current_event.dwThreadId.
 515         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 516
 517 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 518
 519         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 520         Use current_event.dwThreadId instead of main_thread_id.
 521
 522 2019-04-30  Tom Tromey  <tromey@adacore.com>
 523
 524         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 525         (create_excep_cond_exprs): Iterate over program spaces.
 526         (ada_exception_catchpoint_cond_string): Examine all minimal
 527         symbols for exception types.
 528
 529 2019-04-30  Tom Tromey  <tromey@adacore.com>
 530
 531         PR c++/24470:
 532         * dwarf2read.c (process_structure_scope): Handle case where type
 533         has template parameters but no symbol was created.
 534
 535 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 536             Chris January  <chris.january@arm.com>
 537
 538         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 539         qualifier.
 540         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 541
 542 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 543
 544         * f-typeprint.c (f_print_type): Update rules for printing
 545         whitespace.
 546         (f_type_print_varspec_suffix): Likewise.
 547
 548 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 549             Chris January  <chris.january@arm.com>
 550
 551         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 552         function arguments.
 553
 554 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * f-lang.c (build_fortran_types): Change name of void type to
 557         lower case.
 558         * f-typeprint.c (f_type_print_base): Print the name of the void
 559         type, rather than a fixed string.
 560         * f-valprint.c (f_decorations): Use lower case void string.
 561
 562 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 563             Chris January  <chris.january@arm.com>
 564
 565         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 566         types for Fortran.
 567
 568 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 569             Chris January  <chris.january@arm.com>
 570             David Lecomber  <david.lecomber@arm.com>
 571
 572         * f-exp.y (BINOP_INTRINSIC): New token.
 573         (exp): New parser rule handling BINOP_INTRINSIC.
 574         (f77_keywords): Add new builtin procedures.
 575         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 576         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 577         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 578         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 579         (print_unop_subexp_f): New function.
 580         (print_binop_subexp_f): New function.
 581         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 582         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 583         (dump_subexp_body_f): Likewise.
 584         (operator_check_f): Likewise.
 585         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 586         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 587
 588 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 589
 590         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 591         UNOP_KIND.
 592         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 593         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 594         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 595         (operator_length_f): New fuction.
 596         (print_subexp_f): New function.
 597         (op_name_f): New function.
 598         (dump_subexp_body_f): New function.
 599         (operator_check_f): New function.
 600         (exp_descriptor_f): Replace standard expression handling functions
 601         with new functions.
 602         * gdb/fortran-operator.def: New file.
 603         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 604         * gdb/std-operator.def: Remove UNOP_KIND.
 605
 606 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 607
 608         * std-operator.def: Remove unbalanced, stray double quote
 609         character.
 610
 611 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 612             Chris January  <chris.january@arm.com>
 613             Daniel Everett  <daniel.everett@arm.com>
 614             Nick Forrington  <nick.forrington@arm.com>
 615             Richard Bunt  <richard.bunt@arm.com>
 616
 617         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 618         of depth when printing anonymous structs or unions.
 619         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 620         Don't print either the top-level value, or the children if the
 621         max-depth is exceeded.
 622         (ppscm_print_children): When printing the key of a map, allow one
 623         extra level of depth.
 624         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 625         print either the top-level value, or the children if the max-depth
 626         is exceeded.
 627         (print_children): When printing the key of a map, allow one extra
 628         level of depth.
 629         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 630         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 631         (user_print_options): Initialise max_depth field.
 632         (val_print_scalar_or_string_type_p): New function.
 633         (val_print): Check to see if the max depth has been reached.
 634         (val_print_check_max_depth): Define new function.
 635         (show_print_max_depth): New function.
 636         (_initialize_valprint): Add 'print max-depth' option.
 637         * valprint.h (struct value_print_options) <max_depth>: New field.
 638         (val_print_check_max_depth): Declare new function.
 639         * NEWS: Document new feature.
 640
 641 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 642
 643         * ada-lang.c (ada_language_defn): Initialise new field.
 644         * c-lang.c (c_is_string_type_p): New function.
 645         (c_language_defn): Initialise new field.
 646         (cplus_language_defn): Initialise new field.
 647         (asm_language_defn): Initialise new field.
 648         (minimal_language_defn): Initialise new field.
 649         * c-lang.h (c_is_string_type_p): Declare new function.
 650         * d-lang.c (d_language_defn): Initialise new field.
 651         * f-lang.c (f_is_string_type_p): New function.
 652         (f_language_defn): Initialise new field.
 653         * go-lang.c (go_is_string_type_p): New function.
 654         (go_language_defn): Initialise new field.
 655         * language.c (default_is_string_type_p): New function.
 656         (unknown_language_defn): Initialise new field.
 657         (auto_language_defn): Initialise new field.
 658         * language.h (struct language_defn) <la_is_string_type_p>: New
 659         member variable.
 660         (default_is_string_type_p): Declare new function.
 661         * m2-lang.c (m2_language_defn): Initialise new field.
 662         * objc-lang.c (objc_language_defn): Initialise new field.
 663         * opencl-lang.c (opencl_language_defn): Initialise new field.
 664         * p-lang.c (pascal_is_string_type_p): New function.
 665         (pascal_language_defn): Initialise new field.
 666         * rust-lang.c (rust_is_string_type_p): New function.
 667         (rust_language_defn): Initialise new field.
 668
 669 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 670
 671         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 672         New field.
 673         * ada-lang.c (ada_language_defn): Initialise new field.
 674         * c-lang.c (c_language_defn): Likewise.
 675         (cplus_language_defn): Likewise.
 676         (asm_language_defn): Likewise.
 677         (minimal_language_defn): Likewise.
 678         * d-lang.c (d_language_defn): Likewise.
 679         * f-lang.c (f_language_defn): Likewise.
 680         * go-lang.c (go_language_defn): Likewise.
 681         * language.c (unknown_language_defn): Likewise.
 682         (auto_language_defn): Likewise.
 683         * m2-lang.c (m2_language_defn): Likewise.
 684         * objc-lang.c (objc_language_defn): Likewise.
 685         * opencl-lang.c (opencl_language_defn): Likewise.
 686         * p-lang.c (pascal_language_defn): Likewise.
 687         * rust-lang.c (rust_language_defn): Likewise.
 688
 689 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * ada-lang.c (ada_is_character_type): Change return type to bool.
 692         (ada_is_string_type): Likewise.
 693         * ada-lang.h (ada_is_character_type): Update declaration
 694         (ada_is_string_type): Likewise.
 695
 696 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 697
 698         Support style in 'frame|thread apply'
 699
 700         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 701         * record.c (record_start, record_stop): Update callers of
 702         execute_command_to_string with false.
 703         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 704         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 705         methods.
 706         (class string_file): New constructor with term_out parameter.
 707         Override methods term_out and can_emit_style_escape.  New member
 708         term_out.
 709         (class stdio_file): Override can_emit_style_escape.
 710         (class tee_file): Override term_out and can_emit_style_escape.
 711         * utils.h (can_emit_style_escape): Remove.
 712         * utils.c (can_emit_style_escape): Likewise.
 713         Update all callers of can_emit_style_escape (SOMESTREAM) to
 714         SOMESTREAM->can_emit_style_escape.
 715         * source-cache.c (source_cache::get_source_lines): Likewise.
 716         * stack.c (frame_apply_command_count): Call execute_command_to_string
 717         passing the term_out characteristic of the current gdb_stdout.
 718         * thread.c (thr_try_catch_cmd): Likewise.
 719         * top.c (execute_command_to_string): pass term_out parameter
 720         to construct the string_file for the command output.
 721         * ui-file.c (term_cli_styling): New function (most code moved
 722         from utils.c can_emit_style_escape).
 723         (string_file::string_file, string_file::can_emit_style_escape,
 724         stdio_file::can_emit_style_escape, tee_file::term_out,
 725         tee_file::can_emit_style_escape): New functions.
 726
 727 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 728
 729         * NEWS: Mention the new set|show may-call-functions.
 730         * infcall.c (may_call_functions_p): New variable.
 731         (show_may_call_functions_p): New function.
 732         (call_function_by_hand_dummy): Throws an error if not
 733         may-call-functions.
 734         (_initialize_infcall): Call add_setshow_boolean_cmd for
 735         may-call-functions.
 736
 737 2019-04-25  Keith Seitz  <keiths@redhat.com>
 738
 739         PR c++/24367
 740         * cp-support.c (inspect_type): Don't attempt substitutions
 741         of symbol with the same name.
 742
 743 2019-04-25  Tom Tromey  <tromey@adacore.com>
 744
 745         PR gdb/24475:
 746         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 747         static.
 748
 749 2019-04-25  Tom Tromey  <tromey@adacore.com>
 750
 751         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 752         rvalue reference.
 753         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 754         (gdb_xml_parser::parse): Use std::move.
 755         * python/python-internal.h (gdbpy_convert_exception): Take a const
 756         reference.
 757         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 758         std::move.
 759         * python/py-utils.c (gdbpy_convert_exception): Take a const
 760         reference.
 761         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 762         Use std::move.
 763         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 764         Use std::move.
 765         * mi/mi-main.c (mi_print_exception): Take a const reference.
 766         * main.c (handle_command_errors): Take a const reference.
 767         * linespec.c (parse_linespec): Use std::move.
 768         * infcall.c (run_inferior_call): Use std::move.
 769         (call_function_by_hand_dummy): Use std::move.
 770         * exec.c (try_open_exec_file): Use std::move.
 771         * exceptions.h (exception_print, exception_fprintf)
 772         (exception_print_same): Update.
 773         * exceptions.c (print_exception, exception_print)
 774         (exception_fprintf, exception_print_same): Change parameters to
 775         const reference.
 776         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 777         * common/new-op.c: Use std::move.
 778         * common/common-exceptions.h (struct gdb_exception): Add move
 779         constructor.
 780         (struct gdb_exception_error, struct gdb_exception_quit, struct
 781         gdb_quit_bad_alloc): Change constructor to move constructor.
 782         (throw_exception): Change parameter to rvalue reference.
 783         * common/common-exceptions.c (throw_exception): Take rvalue
 784         reference.
 785         * cli/cli-interp.c (safe_execute_command): Use std::move.
 786         * breakpoint.c (insert_bp_location, location_to_sals): Use
 787         std::move.
 788
 789 2019-04-25  Tom Tromey  <tromey@adacore.com>
 790
 791         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 792         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 793         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 794         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 795         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 796         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 797         guile/scm-value.c: Use unpack.
 798         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 799         gdbscm_gdb_exception.
 800         (gdbscm_throw_gdb_exception): Likewise.
 801         (struct gdbscm_gdb_exception): New.
 802         (unpack): New function.
 803         (gdbscm_wrap): Use unpack.
 804
 805 2019-04-25  Tom Tromey  <tromey@adacore.com>
 806
 807         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 808         (gdb_rl_callback_handler): Use std::move.
 809         * common/common-exceptions.h (struct gdb_exception): Add move
 810         assignment operator.
 811         (throw_exception_sjlj): Change "exception" to const reference.
 812         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 813         (throw_exception_sjlj): Change "exception" to const reference.
 814
 815 2019-04-25  Tom Tromey  <tromey@adacore.com>
 816
 817         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 818         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 819         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 820         Update.
 821         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 822         Update.
 823         * mi/mi-interp.c (mi_interp::exec): Update.
 824         * linespec.c (parse_linespec): Update.
 825         * infcall.c (run_inferior_call): Update.
 826         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 827         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 828         (gdbscm_lookup_global_symbol): Update.
 829         * guile/scm-param.c (gdbscm_parameter_value): Update.
 830         * guile/scm-frame.c (gdbscm_frame_read_register)
 831         (gdbscm_frame_read_var): Update.
 832         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 833         * exec.c (try_open_exec_file): Update.
 834         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 835         (gdb_rl_callback_handler): Update.
 836         * common/common-exceptions.h (exception_none): Don't declare.
 837         * common/common-exceptions.c (exception_none): Don't define.
 838         (struct catcher) <exception>: Update.
 839         * cli/cli-interp.c (safe_execute_command): Update.
 840         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 841
 842 2019-04-25  Ali Tamur  <tamur@google.com>
 843
 844         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 845         (read_attribute_value): Likewise.
 846         (dwarf2_read_addr_index): Update comment.
 847         (read_str_index): Add DW_FORM_strx.
 848         (dwarf2_string_attr): Likewise.
 849         (dwarf2_const_value_attr): Likewise.
 850         (dump_die_shallow): Likewise.
 851         (dwarf2_fetch_constant_bytes): Likewise.
 852         (skip_form_bytes): Likewise.
 853         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 854
 855 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 856
 857         PR corefiles/11608
 858         PR corefiles/18187
 859         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 860         OFFSET.  Verify if current mapping contains an ELF header.
 861         (linux_find_memory_regions_full): Adjust call to
 862         dump_mapping_p.
 863
 864 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 865             Kang Li <kanglictf@gmail.com>
 866
 867         PR gdb/21600
 868
 869         * dwarf2-frame.c (read_initial_length): Be consistent about using
 870         unsigned representation of length.
 871         (decode_frame_entry_1): Likewise.  Check for wraparound of
 872         end pointer as well as buffer overflow.
 873
 874 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 875
 876         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 877         "vq".
 878
 879 2019-04-24  Tom Tromey  <tromey@adacore.com>
 880
 881         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 882
 883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 884
 885         * s12z-tdep.c (s12z_unwind_pc): Delete.
 886         (s12z_unwind_sp): Delete.
 887         (s12z_gdbarch_init): Don't register deleted functions with
 888         gdbarch.
 889
 890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 891
 892         * rl78-tdep.c (rl78_unwind_sp): Delete.
 893         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 894
 895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 896
 897         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 898         (xstormy16_unwind_pc): Delete.
 899         (xstormy16_dummy_id): Delete.
 900         (xstormy16_gdbarch_init): Don't register deleted functions with
 901         gdbarch.
 902
 903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 904
 905         * vax-tdep.c (vax_unwind_pc): Delete.
 906         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 907
 908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * v850-tdep.c (v850_unwind_sp): Delete.
 911         (v850_unwind_pc): Delete.
 912         (v850_dummy_id): Delete.
 913         (v850_gdbarch_init): Don't register deleted functions with
 914         gdbarch.
 915
 916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 919         (tilegx_unwind_pc): Delete.
 920         (tilegx_unwind_dummy_id): Delete.
 921         (tilegx_gdbarch_init): Don't register deleted functions with
 922         gdbarch.
 923
 924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 927         (tic6x_dummy_id): Delete.
 928         (tic6x_gdbarch_init): Don't register deleted functions with
 929         gdbarch.
 930
 931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * sparc-tdep.c (sparc_unwind_pc): Delete.
 934         (sparc32_gdbarch_init): Don't register deleted function with
 935         gdbarch.
 936
 937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 938
 939         * sh-tdep.c (sh_unwind_sp): Delete.
 940         (sh_unwind_pc): Delete.
 941         (sh_dummy_id): Delete.
 942         (sh_gdbarch_init): Don't register deleted functions with
 943         gdbarch.
 944
 945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 946
 947         * score-tdep.c (score_unwind_sp): Delete.
 948         (score_unwind_pc): Delete.
 949         (score_dummy_id): Delete.
 950         (score_gdbarch_init): Don't register deleted functions with
 951         gdbarch.
 952
 953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * rx-tdep.c (rx_unwind_pc): Delete.
 956         (rx_unwind_sp): Delete.
 957         (rx_dummy_id): Delete.
 958         (rx_gdbarch_init): Don't register deleted functions with
 959         gdbarch.  Update comment.
 960
 961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 962
 963         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 964         (rs6000_dummy_id): Delete.
 965         (rs6000_gdbarch_init): Don't register deleted functions with
 966         gdbarch.
 967
 968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 969
 970         * or1k-tdep.c (or1k_dummy_id): Delete.
 971         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 972
 973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 974
 975         * nios2-tdep.c (nios2_dummy_id): Delete.
 976         (nios2_unwind_sp): Delete.
 977         (nios2_gdbarch_init): Don't register deleted functions with
 978         gdbarch.
 979
 980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * nds32-tdep.c (nds32_dummy_id): Delete.
 983         (nds32_unwind_pc): Delete.
 984         (nds32_unwind_sp): Delete.
 985         (nds32_gdbarch_init): Don't register deleted functions with
 986         gdbarch.
 987
 988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * msp430-tdep.c (msp430_unwind_pc): Delete.
 991         (msp430_unwind_sp): Delete.
 992         (msp430_dummy_id): Delete.
 993         (msp430_gdbarch_init): Don't register deleted functions with
 994         gdbarch.
 995
 996 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 997
 998         * moxie-tdep.c (moxie_unwind_sp): Delete.
 999         (moxie_unwind_pc): Delete.
1000         (moxie_dummy_id): Delete.
1001         (moxie_gdbarch_init): Don't register deleted functions with
1002         gdbarch.
1003
1004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1005
1006         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1007         (mn10300_unwind_pc): Delete.
1008         (mn10300_unwind_sp): Delete.
1009         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1010         mn10300_unwind_sp.
1011         (mn10300_frame_unwind_init): Don't register deleted functions with
1012         gdbarch.
1013
1014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * mep-tdep.c (mep_unwind_pc): Delete.
1017         (mep_unwind_sp): Delete.
1018         (mep_dummy_id): Delete.
1019         (mep_gdbarch_init): Don't register deleted functions with
1020         gdbarch.
1021
1022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1025         (m68hc11_unwind_sp): Delete.
1026         (m68hc11_gdbarch_init): Don't register deleted functions with
1027         gdbarch.
1028
1029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * m32r-tdep.c (m32r_unwind_sp): Delete.
1032         (m32r_unwind_pc): Delete.
1033         (m32r_dummy_id): Delete.
1034         (m32r_gdbarch_init): Don't register deleted functions with
1035         gdbarch.
1036
1037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * m32c-tdep.c (m32c_unwind_pc): Delete.
1040         (m32c_unwind_sp): Delete.
1041         (m32c_dummy_id): Delete.
1042         (m32c_gdbarch_init): Don't register deleted functions with
1043         gdbarch.
1044
1045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1046
1047         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1048         (lm32_unwind_pc): Delete.
1049         (lm32_dummy_id): Delete.
1050         (lm32_gdbarch_init): Don't register deleted functions with
1051         gdbarch.
1052
1053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1054
1055         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1056         (iq2000_unwind_pc): Delete.
1057         (iq2000_dummy_id): Delete.
1058         (iq2000_gdbarch_init): Don't register deleted functions with
1059         gdbarch.
1060
1061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * nds32-tdep.c (nds32_type_align): Delete.
1064         (nds32_push_dummy_call): Use type_align instead.
1065
1066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1067
1068         * arm-tdep.c (arm_type_align): Only handle vector override case.
1069         (arm_push_dummy_call): Use type_align.
1070         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1071
1072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1075         case.
1076         (pass_on_stack): Use type_align.
1077         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1078         function.
1079
1080 2019-04-23  Tom Tromey  <tromey@adacore.com>
1081
1082         * dwarf2read.c (line_header::file_name_at): Remove unused
1083         overload.
1084
1085 2019-04-23  Tom de Vries  <tdevries@suse.de>
1086
1087         PR gdb/24438
1088         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1089         invocation.
1090
1091
1092 2019-03-27  Ali Tamur  <tamur@google.com>
1093
1094         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1095         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1096         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1097         (dwarf_expr_context::get_addr_index): Likewise
1098         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1099         (symbol_needs_eval_context::get_addr_index): Likewise
1100         (disassemble_dwarf_expression): Add DW_OP_addrx
1101         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1102         (read_cutu_die_from_dwo): Update comment
1103         (skip_one_die): Add DW_FORM_addrx
1104         (read_attribute_value): Likewise
1105         (var_decode_location): Add DW_OP_addrx
1106         (dwarf2_const_value_attr): Add DW_FORM_addrx
1107         (dump_die_shallow): Likewise
1108         (dwarf2_fetch_constant_bytes): Likewise
1109         (decode_locdesc): Add DW_OP_addrx
1110         (skip_form_bytes): Add DW_FORM_addrx
1111
1112 2019-04-22  Ali Tamur  <tamur@google.com>
1113
1114         * MAINTAINERS (Write After Approval): Add self.
1115
1116 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1117
1118         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1119         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1120         (open_symbol_file_object): Likewise.
1121         (svr4_default_sos): Add info parameter.
1122         (svr4_read_so_list): Likewise.
1123         (svr4_current_sos_direct): Adjust functions calls to pass down
1124         info.
1125         (svr4_current_sos_1): Add info parameter.
1126         (svr4_current_sos): Call get_svr4_info, pass info down to
1127         svr4_current_sos_1.
1128         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1129         get_svr4_info.
1130         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1131         get_svr4_info.
1132         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1133         to get_svr4_info.
1134         (probes_table_remove_objfile_probes): Likewise.
1135         (register_solib_event_probe): Add info parameter.
1136         (solist_update_incremental): Pass info parameter down to
1137         svr4_read_so_list.
1138         (disable_probes_interface): Add info parameter.
1139         (svr4_handle_solib_event): Pass current_program_space to
1140         get_svr4_info.  Adjust disable_probes_interface cleanup.
1141         (svr4_create_probe_breakpoints): Add info parameter, pass it
1142         down to register_solib_event_probe.
1143         (svr4_create_solib_event_breakpoints): Add info parameter,
1144         pass it down to svr4_create_probe_breakpoints.
1145         (enable_break): Pass info down to
1146         svr4_create_solib_event_breakpoints.
1147         (svr4_solib_create_inferior_hook): Pass current_program_space to
1148         get_svr4_info.
1149         (svr4_clear_solib): Likewise.
1150
1151 2019-04-22  Pedro Alves  <palves@redhat.com>
1152
1153         * solib-svr4.c (svr4_free_objfile_observer): New.
1154         (probe_and_action::objfile): New field.
1155         (probes_table_htab_remove_objfile_probes)
1156         (probes_table_remove_objfile_probes): New functions.
1157         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1158         in the new probe_and_action.  Don't store the probe in 'lookup'.
1159         (svr4_create_probe_breakpoints): Pass objfile to
1160         register_solib_event_probe.
1161         (_initialize_svr4_solib): Register a free_objfile observer.
1162
1163 2019-04-19  Tom Tromey  <tom@tromey.com>
1164
1165         * common/queue.h: Remove.
1166
1167 2019-04-19  Tom Tromey  <tom@tromey.com>
1168
1169         * event-loop.c: Don't include "common/queue.h".
1170
1171 2019-04-19  Tom Tromey  <tom@tromey.com>
1172
1173         * remote.c (remote_target): Use delete.
1174         * remote-notif.h: Include <list>, not "common/queue.h".
1175         (notif_client_p): Remove typedef.
1176         (remote_notif_state): Add constructor, destructor, initializer.
1177         <notif_queue>: Now a std::list.
1178         (remote_notif_state_xfree): Don't declare.
1179         * remote-notif.c (remote_notif_process, handle_notification)
1180         (remote_notif_state_allocate): Update.
1181         (~remote_notif_state): Rename from remote_notif_state_xfree.
1182
1183 2019-04-19  Tom Tromey  <tom@tromey.com>
1184
1185         * symfile.c (reread_symbols): Update.
1186         * objfiles.c (objfile_register_static_link)
1187         (objfile_lookup_static_link): Update
1188         (~objfile) Don't delete static_links.
1189         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1190
1191 2019-04-19  Tom Tromey  <tom@tromey.com>
1192
1193         * type-stack.h (struct type_stack) <insert>: Constify string.
1194         * type-stack.c (type_stack::insert): Constify string.
1195         * gdbtypes.h (lookup_template_type): Update.
1196         (address_space_name_to_int): Update.
1197         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1198         const.
1199         (lookup_template_type): Make name const.
1200         * c-exp.y: Update rules.
1201         (lex_one_token, classify_name, classify_inner_name)
1202         (c_print_token): Update.
1203         * p-exp.y: Update rules.
1204         (yylex): Update.
1205         * f-exp.y: Update rules.
1206         (yylex): Update.
1207         * d-exp.y: Update rules.
1208         (lex_one_token, classify_name, classify_inner_name): Update.
1209         * parse.c (write_dollar_variable, copy_name): Return std::string.
1210         * parser-defs.h (copy_name): Change return type.
1211         * m2-exp.y: Update rules.
1212         (yylex): Update.
1213         * go-exp.y (lex_one_token): Update.
1214         Update rules.
1215         (classify_unsafe_function, classify_packaged_name)
1216         (classify_name, yylex): Update.
1217
1218 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1219
1220         * configure.ac: add --enable-source-highlight switch.
1221         * configure: Regenerate.
1222         * top.c (print_gdb_version): plumb --enable-source-highlight
1223         status to "show configuration".
1224
1225 2019-04-19  Tom Tromey  <tromey@adacore.com>
1226
1227         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1228         Check ADA_TYPE_P.
1229         (empty_record, ada_template_to_fixed_record_type_1)
1230         (template_to_static_fixed_type)
1231         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1232         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1233         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1234         macros.
1235
1236 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1237
1238         PR symtab/24423:
1239         * source.c (print_source_lines_base): Advance "iter" when a
1240         control character is seen.
1241
1242 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1243
1244         * inferior.h (struct infcall_suspend_state_deleter):
1245         Catch exception in destructor to avoid crash.
1246
1247 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1248
1249         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1250         close to the add_com "shell".
1251
1252 2019-04-18  Tom Tromey  <tromey@adacore.com>
1253
1254         * process-stratum-target.h (class process_stratum_target)
1255         <stratum>: Add "final".
1256
1257 2019-04-17  Tom Tromey  <tromey@adacore.com>
1258
1259         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1260         against nullptr before use.
1261
1262 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1263
1264         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1265
1266 2019-04-17  Jim Wilson  <jimw@sifive.com>
1267             Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1270         code read might fail, assume 4-byte breakpoint in that case.
1271
1272 2019-04-15  Leszek Swirski  <leszeks@google.com>
1273
1274         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1275         rather than a hand-rolled POD check when checking for forced MEMORY
1276         classification.
1277
1278 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1279
1280         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1281         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1282         function.
1283         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1284         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1285         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1286         declaration.
1287
1288 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1289
1290         * aarch64-linux-nat.c
1291         (aarch64_linux_nat_target::thread_architecture): Add override.
1292         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1293         each VQ.
1294
1295 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1296
1297         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1298
1299 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1302         target types of size 96-bits, add some additional comments, and
1303         check that the builtin type we found was the correct size.
1304
1305 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1306
1307         * utils.c (prompt_for_continue): Don't restore the styling at the
1308         end, as applied_style has the wrong value.  This fixes styling in
1309         long lists of file names that are interrupted by the "Continue?"
1310         prompt.
1311
1312 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1313
1314         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1315         * c-lang.c (c_language_defn): Likewise.
1316         (cplus_language_defn): Likewise.
1317         (asm_language_defn): Likewise.
1318         (minimal_language_defn): Likewise.
1319         * d-lang.c (d_language_defn): Likewise.
1320         * f-lang.c (f_language_defn): Likewise.
1321         * go-lang.c (go_language_defn): Likewise.
1322         * language.c (unknown_language_defn): Likewise.
1323         (auto_language_defn): Likewise.
1324         * language.h (struct language_defn): Remove la_magic field.
1325         (LANG_MAGIC): Delete.
1326         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1327         * objc-lang.c (objc_language_defn): Likewise.
1328         * opencl-lang.c (opencl_language_defn): Likewise.
1329         * p-lang.c (pascal_language_defn): Likewise.
1330         * rust-lang.c (rust_language_defn): Likewise.
1331
1332 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1333
1334         * riscv-tdep.c (riscv_type_align): New function.
1335         (riscv_type_alignment): Delete.
1336         (riscv_arg_location): Use 'type_align'.
1337         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1338
1339 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1340
1341         * gdbtypes.c (type_align): A struct with no non-static fields also
1342         has alignment of 1.
1343
1344 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1345
1346         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1347         component to 0.
1348         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1349         member.
1350         (riscv_struct_info::analyse): New implementation using new
1351         analyse_inner member function.
1352         (riscv_struct_info::field_offset): New member function.
1353         (riscv_struct_info::m_offsets): New member variable.
1354         (riscv_struct_info::analyse_inner): New private member function,
1355         takes the old implementation of riscv_struct_info::analyse but
1356         extended to track field offsets.
1357         (riscv_call_arg_struct): Update the struct folding special cases
1358         to handle cases where empty C++ structs, which are non-zero
1359         length, are found.
1360         (riscv_arg_location): Initialise the length of each location, a
1361         non-zero length now indicates the location is in use.
1362         (riscv_push_dummy_call): Allow for the first location having a
1363         non-zero offset when setting up arguments.
1364         (riscv_return_value): Likewise, but for return values.
1365
1366 2019-04-11  Tom Tromey  <tromey@adacore.com>
1367
1368         * utils.c (internal_vproblem): Make "msg" const.
1369
1370 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1371
1372         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1373         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1374         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1375         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1376
1377 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1378
1379         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1380         function.
1381         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1382         of amd64_collect_native_gregset.
1383         (amd64_linux_nat_target::store_registers): Likewise.
1384
1385 2019-04-10  Tom Tromey  <tom@tromey.com>
1386
1387         * symtab.c (lookup_global_symbol_from_objfile)
1388         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1389         * objfiles.h (class separate_debug_iterator): New.
1390         (class separate_debug_range): New.
1391         (struct objfile) <separate_debug_objfiles>: New method.
1392         (objfile_separate_debug_iterate): Don't declare.
1393         * objfiles.c (separate_debug_iterator::operator++): Rename from
1394         objfile_separate_debug_iterate.
1395         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1396         iterator.
1397         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1398         iterator.
1399
1400 2019-04-10  Tom Tromey  <tom@tromey.com>
1401
1402         * symfile.c (reread_symbols): Remove old comment.
1403         * objfiles.c (free_all_objfiles): Fix a typo.
1404
1405 2019-04-10  Tom Tromey  <tom@tromey.com>
1406
1407         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1408         * minsyms.c (lookup_minimal_symbol): Use foreach.
1409         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1410         (lookup_minimal_symbol_solib_trampoline): Likewise.
1411         * symfile.c (reread_symbols): Use foreach.
1412
1413 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1414             Tom Tromey  <tromey@adacore.com>
1415
1416         PR rust/24414:
1417         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1418         (rust_lex_int_test): Change "value" to be LONGEST.
1419         (rust_lex_tests): Add test for long integer literal.
1420
1421 2019-04-09  Tom Tromey  <tromey@adacore.com>
1422
1423         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1424         to bool.
1425         (extended_remote_target::attach): Update.
1426         (remote_target::remote_notice_new_inferior): Update.
1427         (remote_target::add_current_inferior_and_thread): Update.
1428         * inferior.c (exit_inferior_1): Use "false".
1429         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1430
1431 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1432
1433         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1434         the "start" command.
1435
1436 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1437
1438         * python/py-inferior.c (infpy_thread_from_thread_handle):
1439         Adjust comments to reflect renaming of thread_from_thread_handle
1440         to thread_from_handle.  Adjust keywords.  Fix type error message.
1441         (inferior_object_methods): Add thread_from_handle.  Retain
1442         thread_from_thread_handle, but mark it as deprecated.
1443
1444 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1445
1446         * gdbthread.h (find_thread_by_handle): Revise declaration.
1447         * thread.c (find_thread_by_handle): Likewise.  Adjust
1448         implementation too.
1449         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1450         support for buffer objects as handles.
1451
1452 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1453
1454         * python/py-infthread.c (thpy_thread_handle): New function.
1455         (thread_object_methods): Register thpy_thread_handle.
1456
1457 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1458
1459         * gdbthread.h (thread_to_thread_handle): Declare.
1460         * thread.c (gdbtypes.h): Include.
1461         (thread_to_thread_handle): New function.
1462
1463         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1464         (target_thread_info_to_thread_handle): Declare.
1465         * target.c (target_thread_info_to_thread_handle): New function.
1466         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1467         * target-delegates.c: Regenerate.
1468
1469         * linux-thread-db.c (class thread_db_target): Add method
1470         thread_info_to_thread_handle.
1471         (thread_db_target::thread_info_to_thread_handle): Define.
1472         * remote.c (class remote_target): Add new method
1473         thread_info_to_thread_handle.
1474         (remote_target::thread_info_to_thread_handle): Define.
1475
1476 2019-04-08  Pedro Alves  <palves@redhat.com>
1477
1478         * common/common-exceptions.c (throw_exception): Don't create
1479         named object to throw; throw directly.
1480         (throw_it): Likewise.  Don't initialize gdb_exception::message
1481         here, with new; pass FMT and AP to the ctor instead.
1482         * common/common-exceptions.h: Include <string>.
1483         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1484         const char *, va_list)): New ctor.  Use std::make_shared.
1485         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1486         errors)): Delete.
1487         (gdb_exception_error::gdb_exception_error(enum errors, const char
1488         *, va_list)): New.
1489         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1490         Add assertion.
1491         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1492         errors)): Delete.
1493         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1494         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1495         Add assertion.
1496
1497 2019-04-08  Tom Tromey  <tom@tromey.com>
1498
1499         * valops.c (value_rtti_indirect_type): Replace throw_exception
1500         with throw.
1501         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1502         with throw.
1503         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1504         throw.
1505         * target.c (target_translate_tls_address): Replace throw_exception
1506         with throw.
1507         * stack.c (frame_apply_command_count): Replace throw_exception
1508         with throw.
1509         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1510         throw.
1511         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1512         with throw.
1513         * rs6000-tdep.c (rs6000_frame_cache)
1514         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1515         * remote.c: Replace throw_exception with throw.
1516         * record-full.c (record_full_message, record_full_wait_1)
1517         (record_full_restore): Replace throw_exception with throw.
1518         * record-btrace.c:
1519         (get_thread_current_frame_id, record_btrace_start_replaying)
1520         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1521         (cmd_record_btrace_start): Replace throw_exception with throw.
1522         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1523         throw.
1524         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1525         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1526         * linespec.c:
1527         (find_linespec_symbols): Replace throw_exception with throw.
1528         * infrun.c (displaced_step_prepare, resume): Replace
1529         throw_exception with throw.
1530         * infcmd.c (post_create_inferior): Replace throw_exception with
1531         throw.
1532         * inf-loop.c (inferior_event_handler): Replace throw_exception
1533         with throw.
1534         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1535         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1536         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1537         (get_prev_frame_always, get_frame_pc_if_available)
1538         (get_frame_address_in_block_if_available, get_frame_language):
1539         Replace throw_exception with throw.
1540         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1541         throw_exception with throw.
1542         * eval.c (fetch_subexp_value, evaluate_var_value)
1543         (evaluate_funcall, evaluate_subexp_standard): Replace
1544         throw_exception with throw.
1545         * dwarf2loc.c (call_site_find_chain)
1546         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1547         Replace throw_exception with throw.
1548         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1549         with throw.
1550         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1551         throw.
1552         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1553         * completer.c (complete_line_internal): Replace throw_exception
1554         with throw.
1555         * compile/compile-object-run.c (compile_object_run): Replace
1556         throw_exception with throw.
1557         * cli/cli-script.c (process_next_line): Replace throw_exception
1558         with throw.
1559         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1560         (btrace_enable, btrace_maint_update_pt_packets): Replace
1561         throw_exception with throw.
1562         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1563         throw_exception with throw.
1564         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1565         throw_exception with throw.
1566         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1567         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1568         * aarch64-tdep.c (aarch64_make_prologue_cache)
1569         (aarch64_make_stub_cache): Replace throw_exception with throw.
1570
1571 2019-04-08  Tom Tromey  <tom@tromey.com>
1572
1573         * common/common-exceptions.c (throw_exception): Rename from
1574         throw_exception_cxx.  Remove old copy.  Make argument const.
1575         (throw_it): Create and throw exception objects directly.
1576         * common/common-exceptions.h (throw_exception): Make argument
1577         const.
1578         (struct gdb_exception_error): Add constructor.
1579         (struct gdb_exception_quit): Add constructor.
1580
1581 2019-04-08  Tom Tromey  <tom@tromey.com>
1582
1583         * common/common-exceptions.h (exception_rethrow): Don't declare.
1584         (TRY_SJLJ): Update comment.
1585         (TRY, CATCH, END_CATCH): Remove.
1586         * common/common-exceptions.c (exception_rethrow): Remove.
1587
1588 2019-04-08  Tom Tromey  <tom@tromey.com>
1589
1590         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1591         Remove.
1592         (gdb_exception_error): Rename from
1593         gdb_exception_RETURN_MASK_ERROR.
1594         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1595         (gdb_quit_bad_alloc): Update.
1596         * aarch64-tdep.c: Update.
1597         * ada-lang.c: Update.
1598         * ada-typeprint.c: Update.
1599         * ada-valprint.c: Update.
1600         * amd64-tdep.c: Update.
1601         * arch-utils.c: Update.
1602         * break-catch-throw.c: Update.
1603         * breakpoint.c: Update.
1604         * btrace.c: Update.
1605         * c-varobj.c: Update.
1606         * cli/cli-cmds.c: Update.
1607         * cli/cli-interp.c: Update.
1608         * cli/cli-script.c: Update.
1609         * common/common-exceptions.c: Update.
1610         * common/new-op.c: Update.
1611         * common/selftest.c: Update.
1612         * compile/compile-c-symbols.c: Update.
1613         * compile/compile-cplus-symbols.c: Update.
1614         * compile/compile-object-load.c: Update.
1615         * compile/compile-object-run.c: Update.
1616         * completer.c: Update.
1617         * corelow.c: Update.
1618         * cp-abi.c: Update.
1619         * cp-support.c: Update.
1620         * cp-valprint.c: Update.
1621         * darwin-nat.c: Update.
1622         * disasm-selftests.c: Update.
1623         * dtrace-probe.c: Update.
1624         * dwarf-index-cache.c: Update.
1625         * dwarf-index-write.c: Update.
1626         * dwarf2-frame-tailcall.c: Update.
1627         * dwarf2-frame.c: Update.
1628         * dwarf2loc.c: Update.
1629         * dwarf2read.c: Update.
1630         * eval.c: Update.
1631         * event-loop.c: Update.
1632         * event-top.c: Update.
1633         * exec.c: Update.
1634         * f-valprint.c: Update.
1635         * fbsd-tdep.c: Update.
1636         * frame-unwind.c: Update.
1637         * frame.c: Update.
1638         * gdbtypes.c: Update.
1639         * gnu-v3-abi.c: Update.
1640         * guile/guile-internal.h: Update.
1641         * guile/scm-block.c: Update.
1642         * guile/scm-breakpoint.c: Update.
1643         * guile/scm-cmd.c: Update.
1644         * guile/scm-disasm.c: Update.
1645         * guile/scm-frame.c: Update.
1646         * guile/scm-lazy-string.c: Update.
1647         * guile/scm-math.c: Update.
1648         * guile/scm-param.c: Update.
1649         * guile/scm-ports.c: Update.
1650         * guile/scm-pretty-print.c: Update.
1651         * guile/scm-symbol.c: Update.
1652         * guile/scm-symtab.c: Update.
1653         * guile/scm-type.c: Update.
1654         * guile/scm-value.c: Update.
1655         * i386-linux-tdep.c: Update.
1656         * i386-tdep.c: Update.
1657         * inf-loop.c: Update.
1658         * infcall.c: Update.
1659         * infcmd.c: Update.
1660         * infrun.c: Update.
1661         * jit.c: Update.
1662         * language.c: Update.
1663         * linespec.c: Update.
1664         * linux-fork.c: Update.
1665         * linux-nat.c: Update.
1666         * linux-tdep.c: Update.
1667         * linux-thread-db.c: Update.
1668         * main.c: Update.
1669         * mi/mi-cmd-break.c: Update.
1670         * mi/mi-cmd-stack.c: Update.
1671         * mi/mi-interp.c: Update.
1672         * mi/mi-main.c: Update.
1673         * objc-lang.c: Update.
1674         * p-valprint.c: Update.
1675         * parse.c: Update.
1676         * ppc-linux-tdep.c: Update.
1677         * printcmd.c: Update.
1678         * python/py-arch.c: Update.
1679         * python/py-breakpoint.c: Update.
1680         * python/py-cmd.c: Update.
1681         * python/py-finishbreakpoint.c: Update.
1682         * python/py-frame.c: Update.
1683         * python/py-framefilter.c: Update.
1684         * python/py-gdb-readline.c: Update.
1685         * python/py-inferior.c: Update.
1686         * python/py-infthread.c: Update.
1687         * python/py-lazy-string.c: Update.
1688         * python/py-linetable.c: Update.
1689         * python/py-objfile.c: Update.
1690         * python/py-param.c: Update.
1691         * python/py-prettyprint.c: Update.
1692         * python/py-progspace.c: Update.
1693         * python/py-record-btrace.c: Update.
1694         * python/py-record.c: Update.
1695         * python/py-symbol.c: Update.
1696         * python/py-type.c: Update.
1697         * python/py-unwind.c: Update.
1698         * python/py-utils.c: Update.
1699         * python/py-value.c: Update.
1700         * python/python.c: Update.
1701         * record-btrace.c: Update.
1702         * record-full.c: Update.
1703         * remote-fileio.c: Update.
1704         * remote.c: Update.
1705         * riscv-tdep.c: Update.
1706         * rs6000-aix-tdep.c: Update.
1707         * rs6000-tdep.c: Update.
1708         * rust-exp.y: Update.
1709         * rust-lang.c: Update.
1710         * s390-tdep.c: Update.
1711         * selftest-arch.c: Update.
1712         * solib-dsbt.c: Update.
1713         * solib-frv.c: Update.
1714         * solib-spu.c: Update.
1715         * solib-svr4.c: Update.
1716         * solib.c: Update.
1717         * sparc64-linux-tdep.c: Update.
1718         * stack.c: Update.
1719         * symfile-mem.c: Update.
1720         * symmisc.c: Update.
1721         * target.c: Update.
1722         * thread.c: Update.
1723         * top.c: Update.
1724         * tracefile-tfile.c: Update.
1725         * tui/tui.c: Update.
1726         * typeprint.c: Update.
1727         * unittests/cli-utils-selftests.c: Update.
1728         * unittests/parse-connection-spec-selftests.c: Update.
1729         * valops.c: Update.
1730         * valprint.c: Update.
1731         * value.c: Update.
1732         * varobj.c: Update.
1733         * windows-nat.c: Update.
1734         * x86-linux-nat.c: Update.
1735         * xml-support.c: Update.
1736
1737 2019-04-08  Tom Tromey  <tom@tromey.com>
1738
1739         * xml-support.c: Use C++ exception handling.
1740         * x86-linux-nat.c: Use C++ exception handling.
1741         * windows-nat.c: Use C++ exception handling.
1742         * varobj.c: Use C++ exception handling.
1743         * value.c: Use C++ exception handling.
1744         * valprint.c: Use C++ exception handling.
1745         * valops.c: Use C++ exception handling.
1746         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1747         handling.
1748         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1749         * typeprint.c: Use C++ exception handling.
1750         * tui/tui.c: Use C++ exception handling.
1751         * tracefile-tfile.c: Use C++ exception handling.
1752         * top.c: Use C++ exception handling.
1753         * thread.c: Use C++ exception handling.
1754         * target.c: Use C++ exception handling.
1755         * symmisc.c: Use C++ exception handling.
1756         * symfile-mem.c: Use C++ exception handling.
1757         * stack.c: Use C++ exception handling.
1758         * sparc64-linux-tdep.c: Use C++ exception handling.
1759         * solib.c: Use C++ exception handling.
1760         * solib-svr4.c: Use C++ exception handling.
1761         * solib-spu.c: Use C++ exception handling.
1762         * solib-frv.c: Use C++ exception handling.
1763         * solib-dsbt.c: Use C++ exception handling.
1764         * selftest-arch.c: Use C++ exception handling.
1765         * s390-tdep.c: Use C++ exception handling.
1766         * rust-lang.c: Use C++ exception handling.
1767         * rust-exp.y: Use C++ exception handling.
1768         * rs6000-tdep.c: Use C++ exception handling.
1769         * rs6000-aix-tdep.c: Use C++ exception handling.
1770         * riscv-tdep.c: Use C++ exception handling.
1771         * remote.c: Use C++ exception handling.
1772         * remote-fileio.c: Use C++ exception handling.
1773         * record-full.c: Use C++ exception handling.
1774         * record-btrace.c: Use C++ exception handling.
1775         * python/python.c: Use C++ exception handling.
1776         * python/py-value.c: Use C++ exception handling.
1777         * python/py-utils.c: Use C++ exception handling.
1778         * python/py-unwind.c: Use C++ exception handling.
1779         * python/py-type.c: Use C++ exception handling.
1780         * python/py-symbol.c: Use C++ exception handling.
1781         * python/py-record.c: Use C++ exception handling.
1782         * python/py-record-btrace.c: Use C++ exception handling.
1783         * python/py-progspace.c: Use C++ exception handling.
1784         * python/py-prettyprint.c: Use C++ exception handling.
1785         * python/py-param.c: Use C++ exception handling.
1786         * python/py-objfile.c: Use C++ exception handling.
1787         * python/py-linetable.c: Use C++ exception handling.
1788         * python/py-lazy-string.c: Use C++ exception handling.
1789         * python/py-infthread.c: Use C++ exception handling.
1790         * python/py-inferior.c: Use C++ exception handling.
1791         * python/py-gdb-readline.c: Use C++ exception handling.
1792         * python/py-framefilter.c: Use C++ exception handling.
1793         * python/py-frame.c: Use C++ exception handling.
1794         * python/py-finishbreakpoint.c: Use C++ exception handling.
1795         * python/py-cmd.c: Use C++ exception handling.
1796         * python/py-breakpoint.c: Use C++ exception handling.
1797         * python/py-arch.c: Use C++ exception handling.
1798         * printcmd.c: Use C++ exception handling.
1799         * ppc-linux-tdep.c: Use C++ exception handling.
1800         * parse.c: Use C++ exception handling.
1801         * p-valprint.c: Use C++ exception handling.
1802         * objc-lang.c: Use C++ exception handling.
1803         * mi/mi-main.c: Use C++ exception handling.
1804         * mi/mi-interp.c: Use C++ exception handling.
1805         * mi/mi-cmd-stack.c: Use C++ exception handling.
1806         * mi/mi-cmd-break.c: Use C++ exception handling.
1807         * main.c: Use C++ exception handling.
1808         * linux-thread-db.c: Use C++ exception handling.
1809         * linux-tdep.c: Use C++ exception handling.
1810         * linux-nat.c: Use C++ exception handling.
1811         * linux-fork.c: Use C++ exception handling.
1812         * linespec.c: Use C++ exception handling.
1813         * language.c: Use C++ exception handling.
1814         * jit.c: Use C++ exception handling.
1815         * infrun.c: Use C++ exception handling.
1816         * infcmd.c: Use C++ exception handling.
1817         * infcall.c: Use C++ exception handling.
1818         * inf-loop.c: Use C++ exception handling.
1819         * i386-tdep.c: Use C++ exception handling.
1820         * i386-linux-tdep.c: Use C++ exception handling.
1821         * guile/scm-value.c: Use C++ exception handling.
1822         * guile/scm-type.c: Use C++ exception handling.
1823         * guile/scm-symtab.c: Use C++ exception handling.
1824         * guile/scm-symbol.c: Use C++ exception handling.
1825         * guile/scm-pretty-print.c: Use C++ exception handling.
1826         * guile/scm-ports.c: Use C++ exception handling.
1827         * guile/scm-param.c: Use C++ exception handling.
1828         * guile/scm-math.c: Use C++ exception handling.
1829         * guile/scm-lazy-string.c: Use C++ exception handling.
1830         * guile/scm-frame.c: Use C++ exception handling.
1831         * guile/scm-disasm.c: Use C++ exception handling.
1832         * guile/scm-cmd.c: Use C++ exception handling.
1833         * guile/scm-breakpoint.c: Use C++ exception handling.
1834         * guile/scm-block.c: Use C++ exception handling.
1835         * guile/guile-internal.h: Use C++ exception handling.
1836         * gnu-v3-abi.c: Use C++ exception handling.
1837         * gdbtypes.c: Use C++ exception handling.
1838         * frame.c: Use C++ exception handling.
1839         * frame-unwind.c: Use C++ exception handling.
1840         * fbsd-tdep.c: Use C++ exception handling.
1841         * f-valprint.c: Use C++ exception handling.
1842         * exec.c: Use C++ exception handling.
1843         * event-top.c: Use C++ exception handling.
1844         * event-loop.c: Use C++ exception handling.
1845         * eval.c: Use C++ exception handling.
1846         * dwarf2read.c: Use C++ exception handling.
1847         * dwarf2loc.c: Use C++ exception handling.
1848         * dwarf2-frame.c: Use C++ exception handling.
1849         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1850         * dwarf-index-write.c: Use C++ exception handling.
1851         * dwarf-index-cache.c: Use C++ exception handling.
1852         * dtrace-probe.c: Use C++ exception handling.
1853         * disasm-selftests.c: Use C++ exception handling.
1854         * darwin-nat.c: Use C++ exception handling.
1855         * cp-valprint.c: Use C++ exception handling.
1856         * cp-support.c: Use C++ exception handling.
1857         * cp-abi.c: Use C++ exception handling.
1858         * corelow.c: Use C++ exception handling.
1859         * completer.c: Use C++ exception handling.
1860         * compile/compile-object-run.c: Use C++ exception handling.
1861         * compile/compile-object-load.c: Use C++ exception handling.
1862         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1863         * compile/compile-c-symbols.c: Use C++ exception handling.
1864         * common/selftest.c: Use C++ exception handling.
1865         * common/new-op.c: Use C++ exception handling.
1866         * cli/cli-script.c: Use C++ exception handling.
1867         * cli/cli-interp.c: Use C++ exception handling.
1868         * cli/cli-cmds.c: Use C++ exception handling.
1869         * c-varobj.c: Use C++ exception handling.
1870         * btrace.c: Use C++ exception handling.
1871         * breakpoint.c: Use C++ exception handling.
1872         * break-catch-throw.c: Use C++ exception handling.
1873         * arch-utils.c: Use C++ exception handling.
1874         * amd64-tdep.c: Use C++ exception handling.
1875         * ada-valprint.c: Use C++ exception handling.
1876         * ada-typeprint.c: Use C++ exception handling.
1877         * ada-lang.c: Use C++ exception handling.
1878         * aarch64-tdep.c: Use C++ exception handling.
1879
1880 2019-04-08  Tom Tromey  <tom@tromey.com>
1881
1882         * xml-support.c (gdb_xml_parser::parse): Update.
1883         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1884         * value.c (show_convenience): Update.
1885         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1886         (test_parse_flags_qcs): Update.
1887         * thread.c (thr_try_catch_cmd): Update.
1888         * target.c (target_translate_tls_address): Update.
1889         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1890         (info_frame_command_core, frame_apply_command_count): Update.
1891         * rust-exp.y (rust_lex_exception_test): Update.
1892         * riscv-tdep.c (riscv_print_one_register_info): Update.
1893         * remote.c (remote_target::enable_btrace): Update.
1894         * record-btrace.c (record_btrace_enable_warn): Update.
1895         * python/py-utils.c (gdbpy_convert_exception): Update.
1896         * printcmd.c (do_one_display, print_variable_and_value): Update.
1897         * mi/mi-main.c (mi_print_exception): Update.
1898         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1899         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1900         * linux-nat.c (linux_nat_target::attach): Update.
1901         * linux-fork.c (class scoped_switch_fork_info): Update.
1902         * infrun.c (displaced_step_prepare): Update.
1903         * infcall.c (call_function_by_hand_dummy): Update.
1904         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1905         * gnu-v3-abi.c (print_one_vtable): Update.
1906         * frame.c (get_prev_frame_always): Update.
1907         * f-valprint.c (info_common_command_for_block): Update.
1908         * exec.c (try_open_exec_file): Update.
1909         * exceptions.c (print_exception, exception_print)
1910         (exception_fprintf, exception_print_same): Update.
1911         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1912         * dwarf-index-cache.c (index_cache::store)
1913         (index_cache::lookup_gdb_index): Update.
1914         * darwin-nat.c (maybe_cache_shell): Update.
1915         * cp-valprint.c (cp_print_value_fields): Update.
1916         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1917         (gcc_cplus_symbol_address): Update.
1918         * compile/compile-c-symbols.c (gcc_convert_symbol)
1919         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1920         * common/selftest.c: Update.
1921         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1922         a std::string.
1923         (exception_try_scope_entry, exception_try_scope_exit): Don't
1924         declare.
1925         (struct exception_try_scope): Remove.
1926         (TRY): Don't use exception_try_scope.
1927         (struct gdb_exception): Add constructor, operator=.
1928         <what>: New method.
1929         (struct gdb_exception_RETURN_MASK_ALL)
1930         (struct gdb_exception_RETURN_MASK_ERROR)
1931         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1932         (struct gdb_quit_bad_alloc): Update.
1933         * common/common-exceptions.c (exception_none): Change
1934         initializer.
1935         (struct catcher) <state, exception>: Initialize inline.
1936         <prev>: Remove member.
1937         (current_catcher): Remove.
1938         (catchers): New global.
1939         (exceptions_state_mc_init): Simplify.
1940         (catcher_pop): Remove.
1941         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1942         (try_scope_depth, exception_try_scope_entry)
1943         (exception_try_scope_exit): Remove.
1944         (throw_exception_sjlj): Update.
1945         (exception_messages, exception_messages_size): Remove.
1946         (throw_it): Simplify.
1947         (gdb_exception_sliced_copy): Remove.
1948         (throw_exception_cxx): Update.
1949         * cli/cli-script.c (script_from_file): Update.
1950         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1951         Update.
1952         * ada-valprint.c (ada_val_print): Update.
1953         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1954         (create_excep_cond_exprs): Update.
1955
1956 2019-04-08  Tom Tromey  <tom@tromey.com>
1957
1958         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1959         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1960         (TRY, CATCH, END_CATCH): Remove some definitions.
1961         * common/common-exceptions.c: Don't use GDB_XCPT.
1962         (catcher_list_size): Remove.
1963         (throw_exception, throw_it): Simplify.
1964
1965 2019-04-05  Tom Tromey  <tom@tromey.com>
1966
1967         Revert the header-sorting patch.
1968         * ft32-tdep.c: Revert.
1969         * frv-tdep.c: Revert.
1970         * frv-linux-tdep.c: Revert.
1971         * frame.c: Revert.
1972         * frame-unwind.c: Revert.
1973         * frame-base.c: Revert.
1974         * fork-child.c: Revert.
1975         * findvar.c: Revert.
1976         * findcmd.c: Revert.
1977         * filesystem.c: Revert.
1978         * filename-seen-cache.h: Revert.
1979         * filename-seen-cache.c: Revert.
1980         * fbsd-tdep.c: Revert.
1981         * fbsd-nat.h: Revert.
1982         * fbsd-nat.c: Revert.
1983         * f-valprint.c: Revert.
1984         * f-typeprint.c: Revert.
1985         * f-lang.c: Revert.
1986         * extension.h: Revert.
1987         * extension.c: Revert.
1988         * extension-priv.h: Revert.
1989         * expprint.c: Revert.
1990         * exec.h: Revert.
1991         * exec.c: Revert.
1992         * exceptions.c: Revert.
1993         * event-top.c: Revert.
1994         * event-loop.c: Revert.
1995         * eval.c: Revert.
1996         * elfread.c: Revert.
1997         * dwarf2read.h: Revert.
1998         * dwarf2read.c: Revert.
1999         * dwarf2loc.c: Revert.
2000         * dwarf2expr.h: Revert.
2001         * dwarf2expr.c: Revert.
2002         * dwarf2-frame.c: Revert.
2003         * dwarf2-frame-tailcall.c: Revert.
2004         * dwarf-index-write.h: Revert.
2005         * dwarf-index-write.c: Revert.
2006         * dwarf-index-common.c: Revert.
2007         * dwarf-index-cache.h: Revert.
2008         * dwarf-index-cache.c: Revert.
2009         * dummy-frame.c: Revert.
2010         * dtrace-probe.c: Revert.
2011         * disasm.h: Revert.
2012         * disasm.c: Revert.
2013         * disasm-selftests.c: Revert.
2014         * dictionary.c: Revert.
2015         * dicos-tdep.c: Revert.
2016         * demangle.c: Revert.
2017         * dcache.h: Revert.
2018         * dcache.c: Revert.
2019         * darwin-nat.h: Revert.
2020         * darwin-nat.c: Revert.
2021         * darwin-nat-info.c: Revert.
2022         * d-valprint.c: Revert.
2023         * d-namespace.c: Revert.
2024         * d-lang.c: Revert.
2025         * ctf.c: Revert.
2026         * csky-tdep.c: Revert.
2027         * csky-linux-tdep.c: Revert.
2028         * cris-tdep.c: Revert.
2029         * cris-linux-tdep.c: Revert.
2030         * cp-valprint.c: Revert.
2031         * cp-support.c: Revert.
2032         * cp-namespace.c: Revert.
2033         * cp-abi.c: Revert.
2034         * corelow.c: Revert.
2035         * corefile.c: Revert.
2036         * continuations.c: Revert.
2037         * completer.h: Revert.
2038         * completer.c: Revert.
2039         * complaints.c: Revert.
2040         * coffread.c: Revert.
2041         * coff-pe-read.c: Revert.
2042         * cli-out.h: Revert.
2043         * cli-out.c: Revert.
2044         * charset.c: Revert.
2045         * c-varobj.c: Revert.
2046         * c-valprint.c: Revert.
2047         * c-typeprint.c: Revert.
2048         * c-lang.c: Revert.
2049         * buildsym.c: Revert.
2050         * buildsym-legacy.c: Revert.
2051         * build-id.h: Revert.
2052         * build-id.c: Revert.
2053         * btrace.c: Revert.
2054         * bsd-uthread.c: Revert.
2055         * breakpoint.h: Revert.
2056         * breakpoint.c: Revert.
2057         * break-catch-throw.c: Revert.
2058         * break-catch-syscall.c: Revert.
2059         * break-catch-sig.c: Revert.
2060         * blockframe.c: Revert.
2061         * block.c: Revert.
2062         * bfin-tdep.c: Revert.
2063         * bfin-linux-tdep.c: Revert.
2064         * bfd-target.c: Revert.
2065         * bcache.c: Revert.
2066         * ax-general.c: Revert.
2067         * ax-gdb.h: Revert.
2068         * ax-gdb.c: Revert.
2069         * avr-tdep.c: Revert.
2070         * auxv.c: Revert.
2071         * auto-load.c: Revert.
2072         * arm-wince-tdep.c: Revert.
2073         * arm-tdep.c: Revert.
2074         * arm-symbian-tdep.c: Revert.
2075         * arm-pikeos-tdep.c: Revert.
2076         * arm-obsd-tdep.c: Revert.
2077         * arm-nbsd-tdep.c: Revert.
2078         * arm-nbsd-nat.c: Revert.
2079         * arm-linux-tdep.c: Revert.
2080         * arm-linux-nat.c: Revert.
2081         * arm-fbsd-tdep.c: Revert.
2082         * arm-fbsd-nat.c: Revert.
2083         * arm-bsd-tdep.c: Revert.
2084         * arch-utils.c: Revert.
2085         * arc-tdep.c: Revert.
2086         * arc-newlib-tdep.c: Revert.
2087         * annotate.h: Revert.
2088         * annotate.c: Revert.
2089         * amd64-windows-tdep.c: Revert.
2090         * amd64-windows-nat.c: Revert.
2091         * amd64-tdep.c: Revert.
2092         * amd64-sol2-tdep.c: Revert.
2093         * amd64-obsd-tdep.c: Revert.
2094         * amd64-obsd-nat.c: Revert.
2095         * amd64-nbsd-tdep.c: Revert.
2096         * amd64-nbsd-nat.c: Revert.
2097         * amd64-nat.c: Revert.
2098         * amd64-linux-tdep.c: Revert.
2099         * amd64-linux-nat.c: Revert.
2100         * amd64-fbsd-tdep.c: Revert.
2101         * amd64-fbsd-nat.c: Revert.
2102         * amd64-dicos-tdep.c: Revert.
2103         * amd64-darwin-tdep.c: Revert.
2104         * amd64-bsd-nat.c: Revert.
2105         * alpha-tdep.c: Revert.
2106         * alpha-obsd-tdep.c: Revert.
2107         * alpha-nbsd-tdep.c: Revert.
2108         * alpha-mdebug-tdep.c: Revert.
2109         * alpha-linux-tdep.c: Revert.
2110         * alpha-linux-nat.c: Revert.
2111         * alpha-bsd-tdep.c: Revert.
2112         * alpha-bsd-nat.c: Revert.
2113         * aix-thread.c: Revert.
2114         * agent.c: Revert.
2115         * addrmap.c: Revert.
2116         * ada-varobj.c: Revert.
2117         * ada-valprint.c: Revert.
2118         * ada-typeprint.c: Revert.
2119         * ada-tasks.c: Revert.
2120         * ada-lang.c: Revert.
2121         * aarch64-tdep.c: Revert.
2122         * aarch64-ravenscar-thread.c: Revert.
2123         * aarch64-newlib-tdep.c: Revert.
2124         * aarch64-linux-tdep.c: Revert.
2125         * aarch64-linux-nat.c: Revert.
2126         * aarch64-fbsd-tdep.c: Revert.
2127         * aarch64-fbsd-nat.c: Revert.
2128         * aarch32-linux-nat.c: Revert.
2129
2130 2019-04-05  Tom Tromey  <tom@tromey.com>
2131
2132         * ft32-tdep.c: Sort headers.
2133         * frv-tdep.c: Sort headers.
2134         * frv-linux-tdep.c: Sort headers.
2135         * frame.c: Sort headers.
2136         * frame-unwind.c: Sort headers.
2137         * frame-base.c: Sort headers.
2138         * fork-child.c: Sort headers.
2139         * findvar.c: Sort headers.
2140         * findcmd.c: Sort headers.
2141         * filesystem.c: Sort headers.
2142         * filename-seen-cache.h: Sort headers.
2143         * filename-seen-cache.c: Sort headers.
2144         * fbsd-tdep.c: Sort headers.
2145         * fbsd-nat.h: Sort headers.
2146         * fbsd-nat.c: Sort headers.
2147         * f-valprint.c: Sort headers.
2148         * f-typeprint.c: Sort headers.
2149         * f-lang.c: Sort headers.
2150         * extension.h: Sort headers.
2151         * extension.c: Sort headers.
2152         * extension-priv.h: Sort headers.
2153         * expprint.c: Sort headers.
2154         * exec.h: Sort headers.
2155         * exec.c: Sort headers.
2156         * exceptions.c: Sort headers.
2157         * event-top.c: Sort headers.
2158         * event-loop.c: Sort headers.
2159         * eval.c: Sort headers.
2160         * elfread.c: Sort headers.
2161         * dwarf2read.h: Sort headers.
2162         * dwarf2read.c: Sort headers.
2163         * dwarf2loc.c: Sort headers.
2164         * dwarf2expr.h: Sort headers.
2165         * dwarf2expr.c: Sort headers.
2166         * dwarf2-frame.c: Sort headers.
2167         * dwarf2-frame-tailcall.c: Sort headers.
2168         * dwarf-index-write.h: Sort headers.
2169         * dwarf-index-write.c: Sort headers.
2170         * dwarf-index-common.c: Sort headers.
2171         * dwarf-index-cache.h: Sort headers.
2172         * dwarf-index-cache.c: Sort headers.
2173         * dummy-frame.c: Sort headers.
2174         * dtrace-probe.c: Sort headers.
2175         * disasm.h: Sort headers.
2176         * disasm.c: Sort headers.
2177         * disasm-selftests.c: Sort headers.
2178         * dictionary.c: Sort headers.
2179         * dicos-tdep.c: Sort headers.
2180         * demangle.c: Sort headers.
2181         * dcache.h: Sort headers.
2182         * dcache.c: Sort headers.
2183         * darwin-nat.h: Sort headers.
2184         * darwin-nat.c: Sort headers.
2185         * darwin-nat-info.c: Sort headers.
2186         * d-valprint.c: Sort headers.
2187         * d-namespace.c: Sort headers.
2188         * d-lang.c: Sort headers.
2189         * ctf.c: Sort headers.
2190         * csky-tdep.c: Sort headers.
2191         * csky-linux-tdep.c: Sort headers.
2192         * cris-tdep.c: Sort headers.
2193         * cris-linux-tdep.c: Sort headers.
2194         * cp-valprint.c: Sort headers.
2195         * cp-support.c: Sort headers.
2196         * cp-namespace.c: Sort headers.
2197         * cp-abi.c: Sort headers.
2198         * corelow.c: Sort headers.
2199         * corefile.c: Sort headers.
2200         * continuations.c: Sort headers.
2201         * completer.h: Sort headers.
2202         * completer.c: Sort headers.
2203         * complaints.c: Sort headers.
2204         * coffread.c: Sort headers.
2205         * coff-pe-read.c: Sort headers.
2206         * cli-out.h: Sort headers.
2207         * cli-out.c: Sort headers.
2208         * charset.c: Sort headers.
2209         * c-varobj.c: Sort headers.
2210         * c-valprint.c: Sort headers.
2211         * c-typeprint.c: Sort headers.
2212         * c-lang.c: Sort headers.
2213         * buildsym.c: Sort headers.
2214         * buildsym-legacy.c: Sort headers.
2215         * build-id.h: Sort headers.
2216         * build-id.c: Sort headers.
2217         * btrace.c: Sort headers.
2218         * bsd-uthread.c: Sort headers.
2219         * breakpoint.h: Sort headers.
2220         * breakpoint.c: Sort headers.
2221         * break-catch-throw.c: Sort headers.
2222         * break-catch-syscall.c: Sort headers.
2223         * break-catch-sig.c: Sort headers.
2224         * blockframe.c: Sort headers.
2225         * block.c: Sort headers.
2226         * bfin-tdep.c: Sort headers.
2227         * bfin-linux-tdep.c: Sort headers.
2228         * bfd-target.c: Sort headers.
2229         * bcache.c: Sort headers.
2230         * ax-general.c: Sort headers.
2231         * ax-gdb.h: Sort headers.
2232         * ax-gdb.c: Sort headers.
2233         * avr-tdep.c: Sort headers.
2234         * auxv.c: Sort headers.
2235         * auto-load.c: Sort headers.
2236         * arm-wince-tdep.c: Sort headers.
2237         * arm-tdep.c: Sort headers.
2238         * arm-symbian-tdep.c: Sort headers.
2239         * arm-pikeos-tdep.c: Sort headers.
2240         * arm-obsd-tdep.c: Sort headers.
2241         * arm-nbsd-tdep.c: Sort headers.
2242         * arm-nbsd-nat.c: Sort headers.
2243         * arm-linux-tdep.c: Sort headers.
2244         * arm-linux-nat.c: Sort headers.
2245         * arm-fbsd-tdep.c: Sort headers.
2246         * arm-fbsd-nat.c: Sort headers.
2247         * arm-bsd-tdep.c: Sort headers.
2248         * arch-utils.c: Sort headers.
2249         * arc-tdep.c: Sort headers.
2250         * arc-newlib-tdep.c: Sort headers.
2251         * annotate.h: Sort headers.
2252         * annotate.c: Sort headers.
2253         * amd64-windows-tdep.c: Sort headers.
2254         * amd64-windows-nat.c: Sort headers.
2255         * amd64-tdep.c: Sort headers.
2256         * amd64-sol2-tdep.c: Sort headers.
2257         * amd64-obsd-tdep.c: Sort headers.
2258         * amd64-obsd-nat.c: Sort headers.
2259         * amd64-nbsd-tdep.c: Sort headers.
2260         * amd64-nbsd-nat.c: Sort headers.
2261         * amd64-nat.c: Sort headers.
2262         * amd64-linux-tdep.c: Sort headers.
2263         * amd64-linux-nat.c: Sort headers.
2264         * amd64-fbsd-tdep.c: Sort headers.
2265         * amd64-fbsd-nat.c: Sort headers.
2266         * amd64-dicos-tdep.c: Sort headers.
2267         * amd64-darwin-tdep.c: Sort headers.
2268         * amd64-bsd-nat.c: Sort headers.
2269         * alpha-tdep.c: Sort headers.
2270         * alpha-obsd-tdep.c: Sort headers.
2271         * alpha-nbsd-tdep.c: Sort headers.
2272         * alpha-mdebug-tdep.c: Sort headers.
2273         * alpha-linux-tdep.c: Sort headers.
2274         * alpha-linux-nat.c: Sort headers.
2275         * alpha-bsd-tdep.c: Sort headers.
2276         * alpha-bsd-nat.c: Sort headers.
2277         * aix-thread.c: Sort headers.
2278         * agent.c: Sort headers.
2279         * addrmap.c: Sort headers.
2280         * ada-varobj.c: Sort headers.
2281         * ada-valprint.c: Sort headers.
2282         * ada-typeprint.c: Sort headers.
2283         * ada-tasks.c: Sort headers.
2284         * ada-lang.c: Sort headers.
2285         * aarch64-tdep.c: Sort headers.
2286         * aarch64-ravenscar-thread.c: Sort headers.
2287         * aarch64-newlib-tdep.c: Sort headers.
2288         * aarch64-linux-tdep.c: Sort headers.
2289         * aarch64-linux-nat.c: Sort headers.
2290         * aarch64-fbsd-tdep.c: Sort headers.
2291         * aarch64-fbsd-nat.c: Sort headers.
2292         * aarch32-linux-nat.c: Sort headers.
2293
2294 2019-04-04  Tom Tromey  <tom@tromey.com>
2295
2296         * varobj.c (varobj_create): Update.
2297         * rust-exp.y (struct rust_parser) <update_innermost_block,
2298         lookup_symbol>: New methods.
2299         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2300         Rename.
2301         (rust_parser::rust_lookup_type)
2302         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2303         * printcmd.c (display_command, do_one_display): Update.
2304         * parser-defs.h (struct parser_state) <parser_state>: Add
2305         "tracker" parameter.
2306         (block_tracker): New member.
2307         (class innermost_block_tracker) <innermost_block_tracker>: Add
2308         "types" parameter.
2309         <reset>: Remove method.
2310         (innermost_block): Don't declare.
2311         (null_post_parser): Update.
2312         * parse.c (innermost_block): Remove global.
2313         (write_dollar_variable): Update.
2314         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2315         Remove "tracker_types" parameter.
2316         (parse_expression): Add "tracker" parameter.
2317         (parse_expression_for_completion): Update.
2318         (null_post_parser): Add "tracker" parameter.
2319         * p-exp.y: Update rules.
2320         * m2-exp.y: Update rules.
2321         * language.h (struct language_defn) <la_post_parser>: Add
2322         "tracker" parameter.
2323         * go-exp.y: Update rules.
2324         * f-exp.y: Update rules.
2325         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2326         parameter.
2327         * d-exp.y: Update rules.
2328         * c-exp.y: Update rules.
2329         * breakpoint.c (set_breakpoint_condition): Create an
2330         innermost_block_tracker.
2331         (watch_command_1): Likewise.
2332         * ada-lang.c (resolve): Add "tracker" parameter.
2333         (resolve_subexp): Likewise.
2334         * ada-exp.y (write_var_from_sym): Update.
2335
2336 2019-04-04  Tom Tromey  <tom@tromey.com>
2337
2338         * type-stack.h: New file.
2339         * type-stack.c: New file.
2340         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2341         type-stack.h.
2342         (insert_into_type_stack, insert_type, push_type, push_type_int)
2343         (insert_type_address_space, pop_type, pop_type_int)
2344         (pop_typelist, pop_type_stack, append_type_stack)
2345         (push_type_stack, get_type_stack, push_typelist)
2346         (follow_type_instance_flags, follow_types): Don't declare.
2347         * parse.c (type_stack): Remove global.
2348         (parse_exp_in_context): Update.
2349         (insert_into_type_stack, insert_type, push_type, push_type_int)
2350         (insert_type_address_space, pop_type, pop_type_int)
2351         (pop_typelist, pop_type_stack, append_type_stack)
2352         (push_type_stack, get_type_stack, push_typelist)
2353         (follow_type_instance_flags, follow_types): Remove (moved to
2354         type-stack.c).
2355         * f-exp.y (type_stack): New global.
2356         Update rules.
2357         (push_kind_type, f_parse): Update.
2358         * d-exp.y (type_stack): New global.
2359         Update rules.
2360         (d_parse): Update.
2361         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2362         Update rules.
2363         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2364         (HFILES_NO_SRCDIR): Add type-stack.h.
2365
2366 2019-04-04  Tom Tromey  <tom@tromey.com>
2367
2368         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2369         (rust_parser::convert_ast_to_expression, rust_parse)
2370         (rust_lex_test_completion, rust_lex_tests): Update.
2371         * parser-defs.h (struct expr_completion_state): New.
2372         (struct parser_state) <parser_state>: Add completion parameter.
2373         <mark_struct_expression, mark_completion_tag>: New methods.
2374         <parse_completion, m_completion_state>: New members.
2375         (prefixify_expression, null_post_parser): Update.
2376         (mark_struct_expression, mark_completion_tag): Don't declare.
2377         * parse.c (parse_completion, expout_last_struct)
2378         (expout_tag_completion_type, expout_completion_name): Remove
2379         globals.
2380         (parser_state::mark_struct_expression)
2381         (parser_state::mark_completion_tag): Now methods.
2382         (prefixify_expression): Add last_struct parameter.
2383         (prefixify_subexp): Likewise.
2384         (parse_exp_1): Update.
2385         (parse_exp_in_context): Add cstate parameter.  Update.
2386         (parse_expression_for_completion): Create an
2387         expr_completion_state.
2388         (null_post_parser): Add "completion" parameter.
2389         * p-exp.y: Update rules.
2390         (yylex): Update.
2391         * language.h (struct language_defn) <la_post_parser>: Add
2392         "completing" parameter.
2393         * go-exp.y: Update rules.
2394         (lex_one_token): Update.
2395         * expression.h (parse_completion): Don't declare.
2396         * d-exp.y: Update rules.
2397         (lex_one_token): Update rules.
2398         * c-exp.y: Update rules.
2399         (lex_one_token): Update.
2400         * ada-lang.c (resolve): Add "parse_completion" parameter.
2401         (resolve_subexp): Likewise.
2402         (ada_resolve_function): Likewise.
2403
2404 2019-04-04  Tom Tromey  <tom@tromey.com>
2405
2406         * parser-defs.h (struct parser_state) <start_arglist,
2407         end_arglist>: New methods.
2408         <arglist_len, m_funcall_chain>: New members.
2409         (arglist_len, start_arglist, end_arglist): Don't declare.
2410         * parse.c (arglist_len, funcall_chain): Remove global.
2411         (start_arglist, end_arglist): Remove functions.
2412         (parse_exp_in_context): Update.
2413         * p-exp.y: Update rules.
2414         * m2-exp.y: Update rules.
2415         * go-exp.y: Update rules.
2416         * f-exp.y: Update rules.
2417         * d-exp.y: Update rules.
2418         * c-exp.y: Update rules.
2419
2420 2019-04-04  Tom Tromey  <tom@tromey.com>
2421
2422         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2423         lex_operator, push_back>: New methods.
2424         Update all rules.
2425         (rust_parser::lex_hex, lex_escape): Rename and update.
2426         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2427         (rust_parser::lex_operator): Rename and update.
2428         (rust_parser::lex_number, rustyylex, rustyyerror)
2429         (rust_lex_test_init, rust_lex_test_sequence)
2430         (rust_lex_test_push_back, rust_lex_tests): Update.
2431         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2432         parameter.
2433         <lexptr, prev_lexptr>: New members.
2434         (lexptr, prev_lexptr): Don't declare.
2435         * parse.c (lexptr, prev_lexptr): Remove globals.
2436         (parse_exp_in_context): Update.
2437         * p-exp.y (yylex, yyerror): Update.
2438         * m2-exp.y (parse_number, yylex, yyerror): Update.
2439         * go-exp.y (lex_one_token, yyerror): Update.
2440         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2441         * d-exp.y (lex_one_token, yyerror): Update.
2442         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2443         (lex_one_token, yyerror): Update.
2444         * ada-lex.l (YY_INPUT): Update.
2445         (rewind_to_char): Update.
2446         * ada-exp.y (yyerror): Update.
2447
2448 2019-04-04  Tom Tromey  <tom@tromey.com>
2449
2450         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2451         * parser-defs.h (struct parser_state) <parser_state>: Add new
2452         parameter.
2453         <comma_terminates>: New member.
2454         (comma_terminates): Don't declare global.
2455         * parse.c (comma_terminates): Remove global.
2456         (parse_exp_in_context): Update.
2457         * p-exp.y (yylex): Update.
2458         * m2-exp.y (yylex): Update.
2459         * go-exp.y (lex_one_token): Update.
2460         * f-exp.y (yylex): Update.
2461         * d-exp.y (lex_one_token): Update.
2462         * c-exp.y (lex_one_token): Update.
2463         * ada-lex.l: Update.
2464
2465 2019-04-04  Tom Tromey  <tom@tromey.com>
2466
2467         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2468         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2469         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2470         * parser-defs.h (paren_depth): Don't declare.
2471         * parse.c (paren_depth): Remove global.
2472         (parse_exp_in_context): Update.
2473         * p-exp.y (paren_depth): New global.
2474         (pascal_parse): Initialize it.
2475         * m2-exp.y (paren_depth): New global.
2476         (m2_parse): Initialize it.
2477         * go-exp.y (paren_depth): New global.
2478         (go_parse): Initialize it.
2479         * f-exp.y (paren_depth): New global.
2480         (f_parse): Initialize it.
2481         * d-exp.y (paren_depth): New global.
2482         (d_parse): Initialize it.
2483         * c-exp.y (paren_depth): New global.
2484         (c_parse): Initialize it.
2485         * ada-lex.l (paren_depth): New global.
2486         (lexer_init): Initialize it.
2487
2488 2019-04-04  Tom Tromey  <tom@tromey.com>
2489
2490         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2491         (rust_parser::convert_ast_to_type)
2492         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2493         * parser-defs.h (struct parser_state) <parser_state>: Add
2494         parameters.  Initialize new members.
2495         <expression_context_block, expression_context_pc>: New members.
2496         * parse.c (expression_context_block, expression_context_pc):
2497         Remove globals.
2498         (parse_exp_in_context): Update.
2499         * p-exp.y: Update all rules.
2500         (yylex): Update.
2501         * m2-exp.y: Update all rules.
2502         (yylex): Update.
2503         * go-exp.y (yylex): Update.
2504         * f-exp.y (yylex): Update.
2505         * d-exp.y: Update all rules.
2506         (yylex): Update.
2507         * c-exp.y: Update all rules.
2508         (lex_one_token, classify_name, yylex, c_parse): Update.
2509         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2510
2511 2019-04-04  Tom Tromey  <tom@tromey.com>
2512
2513         * gdbarch.h, gdbarch.c: Rebuild.
2514         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2515         * stap-probe.h:
2516         (struct stap_parse_info): Replace "parser_state" with
2517         "expr_builder".
2518         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2519         (parser_state): New class.
2520         * parse.c (expr_builder): Rename.
2521         (expr_builder::release): Rename.
2522         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2523         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2524         (write_exp_elt_longcst, write_exp_elt_floatcst)
2525         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2526         (write_exp_string_vector, write_exp_bitstring)
2527         (write_exp_msymbol, mark_struct_expression)
2528         (write_dollar_variable)
2529         (insert_type_address_space, increase_expout_size): Replace
2530         "parser_state" with "expr_builder".
2531         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2532         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2533         "parser_state" with "expr_builder".
2534
2535 2019-04-04  Tom Tromey  <tom@tromey.com>
2536
2537         * rust-exp.y: Replace "parse_language" with method call.
2538         * p-exp.y:
2539         (yylex): Replace "parse_language" with method call.
2540         * m2-exp.y:
2541         (yylex): Replace "parse_language" with method call.
2542         * go-exp.y (classify_name): Replace "parse_language" with method
2543         call.
2544         * f-exp.y (yylex): Replace "parse_language" with method call.
2545         * d-exp.y (lex_one_token): Replace "parse_language" with method
2546         call.
2547         * c-exp.y:
2548         (lex_one_token, classify_name, yylex): Replace "parse_language"
2549         with method call.
2550         * ada-exp.y (find_primitive_type, type_char)
2551         (type_system_address): Replace "parse_language" with method call.
2552
2553 2019-04-04  Tom Tromey  <tom@tromey.com>
2554
2555         * rust-exp.y: Replace "parse_gdbarch" with method call.
2556         * parse.c (write_dollar_variable, insert_type_address_space):
2557         Replace "parse_gdbarch" with method call.
2558         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2559         call.
2560         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2561         call.
2562         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2563         "parse_gdbarch" with method call.
2564         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2565         with method call.
2566         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2567         "parse_gdbarch" with method call.
2568         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2569         "parse_gdbarch" with method call.
2570         * c-exp.y (parse_type, parse_number, classify_name): Replace
2571         "parse_gdbarch" with method call.
2572         * ada-lex.l: Replace "parse_gdbarch" with method call.
2573         * ada-exp.y (parse_type, find_primitive_type, type_char)
2574         (type_system_address): Replace "parse_gdbarch" with method call.
2575
2576 2019-04-04  Tom Tromey  <tom@tromey.com>
2577
2578         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2579         * stap-probe.c (stap_parse_argument): Update.
2580         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2581         initial_size parameter.
2582         * rust-exp.y (rust_lex_tests): Update.
2583         * parse.c (parser_state): Update.
2584         (parse_exp_in_context): Update.
2585         * parser-defs.h (struct parser_state) <parser_state>: Remove
2586         "initial_size" parameter.
2587
2588 2019-04-04  Tom Tromey  <tom@tromey.com>
2589
2590         * parser-defs.h (increase_expout_size): Don't declare.
2591         * parse.c (increase_expout_size): Now static.
2592
2593 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2594
2595         * gnu-nat.c (gnu_nat_target::wait): Fix
2596         target_waitstatus_to_string call.
2597
2598 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2599
2600         * eval.c (evaluate_subexp_standard): Handle internal functions
2601         during Fortran function call handling.
2602
2603 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2604
2605         * NEWS: Mention new internal functions.
2606         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2607         (read_base_type): Use dwarf2_init_complex_target_type.
2608         * value.c (creal_internal_fn): New function.
2609         (cimag_internal_fn): New function.
2610         (_initialize_values): Register new internal functions.
2611
2612 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2613
2614         * infrun.c (stop_all_threads): If debug_infrun, always
2615         trace the wait status after wait_one, using
2616         target_waitstatus_to_string and target_pid_to_str.
2617         (handle_inferior_event): Replace various trace of
2618         wait status kind by a single trace.
2619         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2620         wait status kind image by target_waitstatus_to_string.
2621         * target/waitstatus.c (target_waitstatus_to_string): Fix
2622         obsolete comment.
2623
2624 2019-04-01  Tom Tromey  <tromey@adacore.com>
2625
2626         PR symtab/23331:
2627         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2628
2629 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2630             Pedro Alves  <palves@redhat.com>
2631
2632         * top.c (quit_force): Call 'finalize_values'.
2633         * value.c (finalize_values): New function.
2634         * value.h (finalize_values): Declare.
2635
2636 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2637
2638         * NEWS: Announce $_gdb_major and $_gdb_minor.
2639
2640         * top.c (init_gdb_version_vars): New function.
2641         (gdb_init): Call init_gdb_version_vars.
2642
2643 2019-03-29  Tom Tromey  <tromey@adacore.com>
2644
2645         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2646         help text.  Remove dead code.
2647
2648 2019-03-29  Keith Seitz  <keiths@redhat.com>
2649
2650         From Siddhesh Poyarekar:
2651         * f-lang.h (f77_get_upperbound): Return LONGEST.
2652         (f77_get_lowerbound): Likewise.
2653         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2654         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2655         print them.
2656         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2657         plongest to format print it.
2658         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2659         (f77_get_upperbound): Likewise.
2660         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2661         LOWER_BOUND to LONGEST.
2662         (f77_create_arrayprint_offset_tbl): Likewise.
2663
2664 2019-03-29  Keith Seitz  <keiths@redhat.com>
2665
2666         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2667         %s/pulongest for TYPE_LENGTH instead of %d in format
2668         strings.
2669         * ada-typerint.c (ada_print_type): Likewise.
2670         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2671         * compile/compile-c-support.c (generate_register_struct): Likewise.
2672         * gdbtypes.c (recursive_dump_type): Likewise.
2673         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2674         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2675         instead of %d in format strings.
2676         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2677         to std::min to ULONGEST.
2678         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2679         instead of %d in format strings.
2680         * tracepoint.c (info_scope_command): Likewise.
2681         * typeprint.c (print_offset_data::update)
2682         (print_offset_data::finish): Likewise.
2683         * xtensa-tdep.c (xtensa_store_return_value)
2684         (xtensa_push_dummy_call): Likewise.
2685
2686 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2687
2688         * windows-nat.c (display_selector): Fixed format specifications
2689         for 64-bit Cygwin.
2690
2691 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2692
2693         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2694
2695 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2696
2697         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2698         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2699         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2700         (nios2_linux_init_abi): Install it.
2701
2702 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2703
2704         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2705
2706 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2707
2708         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2709
2710 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2711             Tom Tromey  <tromey@adacore.com>
2712
2713         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2714
2715 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2716
2717         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2718         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2719         method to compute the bounds of range types. Also print "[evaluated]"
2720         if the bounds' values come from a dynamic evaluation.
2721
2722 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2723
2724         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2725         whitespace when pretty printing is on.
2726
2727 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2728
2729         * ppc-linux-nat.c: Add include.
2730
2731 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2732
2733         * NEWS: Mention AArch64 Pointer Authentication.
2734
2735 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2736
2737         * arm-linux-nat.c: Add include.
2738
2739 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2740
2741         * source-cache.c (source_cache::get_source_lines): Re-read
2742         fullname after calling open_source_file.
2743
2744 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2745
2746         * NEWS: Mention TLS support for FreeBSD.
2747
2748 2019-03-25  Tom Tromey  <tromey@adacore.com>
2749
2750         * minsyms.c (BUNCH_SIZE): Update comment.
2751         (~minimal_symbol_reader): Remove old comment.
2752         (compact_minimal_symbols): Update comment.
2753         (minimal_symbol_reader::install): Remove old comment.  Update
2754         other comments.
2755
2756 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2757
2758         * s390-linux-nat.c: Add include.
2759
2760 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2761
2762         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2763         Call linux_get_hwcap.
2764         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2765         Likewise.
2766         (aarch64_linux_get_hwcap): Remove function.
2767         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2768         declaration.
2769         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2770         linux_get_hwcap.
2771         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2772         * linux-tdep.c (linux_get_hwcap): Add function.
2773         (linux_get_hwcap2): Likewise.
2774         * linux-tdep.h (linux_get_hwcap): Add declaration.
2775         (linux_get_hwcap2): Likewise.
2776         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2777         (ppc_linux_get_hwcap2): Likewise.
2778         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2779         linux_get_hwcap.
2780         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2781         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2782         (ppc_linux_nat_target::read_description): Likewise.
2783         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2784         * s390-linux-nat.c: Likewise.
2785         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2786
2787 2019-03-24  Tom Tromey  <tom@tromey.com>
2788
2789         * ada-lang.c (standard_lookup): Simplify initialization.
2790         (ada_lookup_symbol_nonlocal): Simplify return.
2791         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2792         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2793         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2794         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2795         initialization.
2796         * solib.c (solib_global_lookup): Simplify.
2797         * symtab.c (null_block_symbol): Remove.
2798         (symbol_cache_lookup): Simplify returns.
2799         (lookup_language_this): Simplify returns.
2800         (lookup_symbol_aux): Simplify return.
2801         (lookup_local_symbol): Simplify returns.
2802         (lookup_global_symbol_from_objfile): Simplify return.
2803         (lookup_symbol_in_objfile_symtabs)
2804         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2805         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2806         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2807         * cp-namespace.c (cp_lookup_bare_symbol)
2808         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2809         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2810         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2811         (cp_lookup_symbol_via_imports): Simplify initialization.
2812         (find_symbol_in_baseclass): Likewise.
2813         * symtab.h (null_block_symbol): Remove.
2814         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2815         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2816         (d_lookup_symbol_module): Likewise.
2817         (find_symbol_in_baseclass): Simplify initialization.
2818
2819 2019-03-24  Tom Tromey  <tom@tromey.com>
2820
2821         * expression.h: Don't include symtab.h.
2822         (struct block): Forward declare.
2823
2824 2019-03-24  Tom Tromey  <tom@tromey.com>
2825
2826         * c-exp.y (typebase): Remove casts.
2827         * gdbtypes.c (lookup_unsigned_typename, )
2828         (lookup_signed_typename): Remove cast.
2829         * eval.c (parse_to_comma_and_eval): Remove cast.
2830         * parse.c (write_dollar_variable): Remove cast.
2831         * block.h (struct block) <superblock>: Now const.
2832         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2833         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2834         (map_block): Make "block" const.
2835         * symfile.h (struct quick_symbol_functions)
2836         <map_matching_symbols>: Constify block argument to "callback".
2837         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2838         const.
2839         (find_pc_sect_compunit_symtab): Make "b" const.
2840         (find_symbol_at_address): Likewise.
2841         (search_symbols): Likewise.
2842         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2843         (dw2_debug_names_lookup_symbol): Likewise.
2844         (dw2_map_matching_symbols): Update.
2845         * p-valprint.c (pascal_val_print): Remove "block".
2846         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2847         (aux_add_nonlocal_symbols): Make "block" const.
2848         (resolve_subexp): Remove cast.
2849         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2850         const.
2851         (iterate_over_file_blocks): Likewise.
2852         * f-exp.y (%union) <bval>: Remove.
2853         * coffread.c (patch_opaque_types): Make "b" const.
2854         * spu-tdep.c (spu_catch_start): Make "block" const.
2855         * c-valprint.c (print_unpacked_pointer): Remove "block".
2856         * symmisc.c (dump_symtab_1): Make "b" const.
2857         (block_depth): Make "block" const.
2858         * d-exp.y (%union) <bval>: Remove.
2859         * cp-support.h (cp_lookup_rtti_type): Update.
2860         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2861         * psymtab.c (psym_lookup_symbol): Make "block" const.
2862         (maintenance_check_psymtabs): Make "b" const.
2863         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2864         (enumerate_locals, enumerate_args): Update.
2865         * python/py-symtab.c (stpy_global_block): Make "block" const.
2866         (stpy_static_block): Likewise.
2867         * inline-frame.c (block_starting_point_at): Make "new_block"
2868         const.
2869         * block.c (find_block_in_blockvector): Make return type const.
2870         (blockvector_for_pc_sect): Make "b" const.
2871         (find_block_in_blockvector): Make "b" const.
2872
2873 2019-03-23  Tom Tromey  <tom@tromey.com>
2874
2875         * varobj.c (varobj_create): Update.
2876         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2877         * printcmd.c (display_command, do_one_display): Don't reset
2878         innermost_block.
2879         * parser-defs.h (enum innermost_block_tracker_type): Move to
2880         expression.h.
2881         (innermost_block): Update comment.
2882         * parse.c (parse_exp_1): Add tracker_types parameter.
2883         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2884         tracker_types parameter.  Reset innermost_block.
2885         (parse_exp_in_context): Remove.
2886         (parse_expression_for_completion): Update.
2887         * objfiles.c (~objfile): Don't reset expression_context_block or
2888         innermost_block.
2889         * expression.h (enum innermost_block_tracker_type): Move from
2890         parser-defs.h.
2891         (parse_exp_1): Add tracker_types parameter.
2892         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2893         reset innermost_block.
2894
2895 2019-03-23  Tom Tromey  <tom@tromey.com>
2896
2897         * objfiles.h: Include bcache.h.
2898
2899 2019-03-23  Tom Tromey  <tom@tromey.com>
2900
2901         * linespec.c (get_current_search_block): Use
2902         scoped_restore_current_language.
2903         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2904
2905 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2906             Jiong Wang  <jiong.wang@arm.com>
2907
2908         * aarch64-linux-tdep.c
2909         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2910         section.
2911         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2912
2913 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2914             Jiong Wang  <jiong.wang@arm.com>
2915
2916         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2917         instructions.
2918         (aarch64_analyze_prologue_test): Add PACIASP test.
2919         (aarch64_prologue_prev_register): Unmask PC value.
2920
2921 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2922             Jiong Wang  <jiong.wang@arm.com>
2923
2924         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2925         (aarch64_dwarf2_prev_register): Unmask PC value.
2926         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2927         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2928         DW_CFA_AARCH64_negate_ra_state.
2929         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2930
2931 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2932             Jiong Wang  <jiong.wang@arm.com>
2933
2934         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2935         registers.
2936         (aarch64_pseudo_register_name): Likewise.
2937         (aarch64_pseudo_register_type): Likewise.
2938         (aarch64_pseudo_register_reggroup_p): Likewise.
2939         (aarch64_gdbarch_init): Add pauth registers.
2940         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2941         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2942         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2943         (struct gdbarch_tdep): Add regnum for ra_state.
2944
2945 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2946             Jiong Wang  <jiong.wang@arm.com>
2947
2948         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2949
2950 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2951             Jiong Wang  <jiong.wang@arm.com>
2952
2953         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2954         function.
2955         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2956         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2957         (aarch64_gdbarch_init): Add puth registers.
2958         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2959         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2960         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2961
2962 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2963             Jiong Wang  <jiong.wang@arm.com>
2964
2965         * aarch64-linux-nat.c
2966         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2967         * aarch64-linux-tdep.c
2968         (aarch64_linux_core_read_description): Likewise.
2969         (aarch64_linux_get_hwcap): New function.
2970         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2971         (aarch64_linux_get_hwcap): New declaration.
2972
2973 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2974             Jiong Wang  <jiong.wang@arm.com>
2975
2976         * aarch64-linux-nat.c
2977         (aarch64_linux_nat_target::read_description): Add pauth param.
2978         * aarch64-linux-tdep.c
2979         (aarch64_linux_core_read_description): Likewise.
2980         * aarch64-tdep.c (struct target_desc): Add in pauth.
2981         (aarch64_read_description): Add pauth param.
2982         (aarch64_gdbarch_init): Likewise.
2983         * aarch64-tdep.h (aarch64_read_description): Likewise.
2984         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2985         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2986         * features/Makefile: Add new files.
2987         * features/aarch64-pauth.c: New file.
2988         * features/aarch64-pauth.xml: New file.
2989
2990 2019-03-20  Tom Tromey  <tromey@adacore.com>
2991
2992         * infrun.c (handle_inferior_event): Rename from
2993         handle_inferior_event_1.  Create a scoped_value_mark.
2994         (handle_inferior_event): Remove.
2995
2996 2019-03-19  Tom Tromey  <tromey@adacore.com>
2997
2998         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2999         * infrun.h (print_stop_event): Add "displays" parameter.
3000         * infrun.c (print_stop_event): Add "displays" parameter.
3001
3002 2019-03-19  Pedro Alves  <palves@redhat.com>
3003
3004         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3005         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3006         to -1.  Fix TABs vs spaces.
3007         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3008         * tui/tui-out.h (tui_ui_out) Add intro comments.
3009         <m_line, m_start_of_line>: In-class initialize, and add describing
3010         comment.
3011
3012 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3013
3014         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3015         variable names.
3016         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3017
3018 2019-03-18  Pedro Alves  <palves@redhat.com>
3019             Eli Zaretskii <eliz@gnu.org>
3020
3021         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3022         m_line and m_start_of_line.
3023
3024 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3025
3026         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3027         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3028         it returns a newline.  This fixes a regression in TU mode, whereby
3029         the next line is output on the same screen line as the user input.
3030
3031 2019-03-18  Tom Tromey  <tromey@adacore.com>
3032
3033         * minsyms.c (minimal_symbol_reader::install): Remove call to
3034         obstack_blank.
3035
3036 2019-03-18  Pedro Alves  <palves@redhat.com>
3037
3038         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3039         New globals.
3040         (apply_style): New, factored out from ...
3041         (apply_ansi_escape): ... this.  Handle reverse video mode.
3042         (tui_set_reverse_mode): New function.
3043         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3044         * tui/tui-winsource.c (tui_show_source_line): Use
3045         tui_set_reverse_mode instead of setting A_STANDOUT.
3046         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3047         New setter methods.
3048
3049 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3050
3051         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3052         Handle tabs.
3053
3054 2019-03-18  Tom Tromey  <tromey@adacore.com>
3055
3056         * ada-lang.c (empty_array): Add "high" parameter.
3057         (ada_evaluate_subexp): Update.
3058
3059 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3060
3061         * unittests/string_view-selftests.c: Define
3062         _initialize_string_view_selftests unconditionally.
3063
3064 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3065
3066         PR gdb/24350
3067         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3068
3069 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3070
3071         PR gdb/24351
3072         * windows-nat.c (display_selector): Fix format specifiers.
3073
3074 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3075
3076         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3077         tui_refill_source_window instead of tui_refresh_win, to update the
3078         current execution line.  This fixes redisplay of the current line
3079         when stepping through the code with "next" or "step".
3080
3081 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3082
3083         * source-cache.c (source_cache::get_source_lines): Call
3084         find_source_lines to initialize s->nlines.  This fixes vertical
3085         scrolling of TUI source window when the DOWN arrow is pressed.
3086
3087 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3088
3089         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3090         linux-thread-db.c (_initialize_thread_db): Likewise.
3091
3092 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3093
3094         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3095         wclrtoeol in tui_show_source_line".  This reverts changes made in
3096         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3097
3098 2019-03-15  Tom Tromey  <tom@tromey.com>
3099
3100         * symtab.h (struct minimal_symbol): Derive from
3101         general_symbol_info.
3102         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3103         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3104         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3105         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3106         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3107         (MSYMBOL_SEARCH_NAME): Update.
3108         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3109         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3110         * minsyms.c (minimal_symbol_reader::record_full): Update.
3111
3112 2019-03-15  Tom Tromey  <tom@tromey.com>
3113
3114         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3115
3116 2019-03-15  Tom Tromey  <tom@tromey.com>
3117
3118         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3119         unique_xmalloc_ptr.
3120         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3121         Update.
3122         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3123         (build_minimal_symbol_hash_tables)
3124         (minimal_symbol_reader::install): Update.
3125
3126 2019-03-15  Tom Tromey  <tom@tromey.com>
3127
3128         * symtab.c (create_demangled_names_hash): Update.
3129         (symbol_set_names): Update.
3130         * objfiles.h (struct objfile_per_bfd_storage)
3131         <demangled_names_hash>: Now an htab_up.
3132         * objfiles.c (objfile_per_bfd_storage): Simplify.
3133
3134 2019-03-15  Tom Tromey  <tom@tromey.com>
3135
3136         * objfiles.h (struct objfile_per_bfd_storage): Declare
3137         destructor.
3138         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3139         New.
3140         (get_objfile_bfd_data): Use new.  Don't initialize
3141         language_of_main.
3142         (free_objfile_per_bfd_storage): Remove.
3143         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3144
3145 2019-03-15  Tom Tromey  <tom@tromey.com>
3146
3147         * symfile.c (reread_symbols): Update.
3148         * objfiles.c (objfile::objfile): Update.
3149         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3150         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3151         comment.
3152         (minimal_symbol_reader::install): Update.
3153         (terminate_minimal_symbol_table): Remove.
3154         * jit.c (jit_object_close_impl): Update.
3155
3156 2019-03-15  Tom Tromey  <tom@tromey.com>
3157
3158         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3159         initializations.
3160
3161 2019-03-15  Tom Tromey  <tom@tromey.com>
3162
3163         * objfiles.h (struct objfile_per_bfd_storage)
3164         <demangled_hash_languages>: Now a bitset.
3165         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3166         (lookup_minimal_symbol): Update.
3167
3168 2019-03-15  Tom Tromey  <tom@tromey.com>
3169
3170         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3171         Don't return the symbol.
3172         * coffread.c (record_minimal_symbol): Use record_full.
3173
3174 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3175
3176         The MS-Windows port of ncurses fails to switch to a color pair if
3177         one or both of the colors are the implicit default colors.  This
3178         change records the default colors when TUI is initialized, and
3179         then specifies them explicitly when a color pair uses the default
3180         colors.  This allows color styling in TUI mode on MS-Windows.
3181
3182         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3183         ncurses_norm_attr.
3184         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3185         colors in ncurses_norm_attr.
3186         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3187         "none", replace it with the default color recorded in
3188         ncurses_norm_attr.
3189
3190 2019-03-14  Tom Tromey  <tromey@adacore.com>
3191
3192         * source-cache.h (class source_cache) <get_source_lines>: Return
3193         std::string.
3194         * source-cache.c (source_cache::extract_lines): Handle case where
3195         first_pos==npos.  Return std::string.
3196         (source_cache::get_source_lines): Update.
3197
3198 2019-03-14  Tom Tromey  <tromey@adacore.com>
3199
3200         * NEWS: Add item for "style sources" commands.
3201         * source-cache.c (source_cache::get_source_lines): Check
3202         source_styling.
3203         * cli/cli-style.c (source_styling): New global.
3204         (_initialize_cli_style): Add "style sources" commands.
3205         (show_style_sources): New function.
3206         * cli/cli-style.h (source_styling): Declare.
3207
3208 2019-03-14  Pedro Alves  <palves@redhat.com>
3209             Tom Tromey  <tromey@adacore.com>
3210
3211         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3212         * tui/tui-winsource.c (tui_refill_source_window): New function,
3213         from...
3214         (tui_horizontal_source_scroll): ... here.  Move some logic.
3215         * cli/cli-style.c (set_style_enabled): Notify new observable.
3216         * tui/tui-hooks.c (tui_redisplay_source): New function.
3217         (tui_attach_detach_observers): Attach or detach
3218         tui_redisplay_source.
3219         * observable.h (source_styling_changed): New observable.
3220         * observable.c: Define source_styling_changed observable.
3221
3222 2019-03-13  Tom Tromey  <tromey@adacore.com>
3223
3224         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3225         (i386_gnu_nat_target::store_registers): Update.
3226         * target-debug.h (target_debug_print_std_string): New macro.
3227         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3228         * windows-tdep.c (display_one_tib): Update.
3229         * tui/tui-stack.c (tui_make_status_line): Update.
3230         * top.c (print_inferior_quit_action): Update.
3231         * thread.c (thr_try_catch_cmd): Update.
3232         (add_thread_with_info): Update.
3233         (thread_target_id_str): Update.
3234         (thr_try_catch_cmd): Update.
3235         (thread_command): Update.
3236         (thread_find_command): Update.
3237         * record-btrace.c (record_btrace_target::info_record)
3238         (record_btrace_resume_thread, record_btrace_target::resume)
3239         (record_btrace_cancel_resume, record_btrace_step_thread)
3240         (record_btrace_target::wait, record_btrace_target::wait)
3241         (record_btrace_target::wait, record_btrace_target::stop): Update.
3242         * progspace.c (print_program_space): Update.
3243         * process-stratum-target.c
3244         (process_stratum_target::thread_address_space): Update.
3245         * linux-fork.c (linux_fork_mourn_inferior)
3246         (detach_checkpoint_command, info_checkpoints_command)
3247         (linux_fork_context): Update.
3248         (linux_fork_detach): Update.
3249         (class scoped_switch_fork_info): Update.
3250         (delete_checkpoint_command): Update.
3251         * infrun.c (follow_fork_inferior): Update.
3252         (follow_fork_inferior): Update.
3253         (proceed_after_vfork_done): Update.
3254         (handle_vfork_child_exec_or_exit): Update.
3255         (follow_exec): Update.
3256         (displaced_step_prepare_throw): Update.
3257         (displaced_step_restore): Update.
3258         (start_step_over): Update.
3259         (resume_1): Update.
3260         (clear_proceed_status_thread): Update.
3261         (proceed): Update.
3262         (print_target_wait_results): Update.
3263         (do_target_wait): Update.
3264         (context_switch): Update.
3265         (stop_all_threads): Update.
3266         (restart_threads): Update.
3267         (finish_step_over): Update.
3268         (handle_signal_stop): Update.
3269         (switch_back_to_stepped_thread): Update.
3270         (keep_going_pass_signal): Update.
3271         (print_exited_reason): Update.
3272         (normal_stop): Update.
3273         * inferior.c (inferior_pid_to_str): Change return type.
3274         (print_selected_inferior): Update.
3275         (add_inferior): Update.
3276         (detach_inferior): Update.
3277         * dummy-frame.c (fprint_dummy_frames): Update.
3278         * dcache.c (dcache_info_1): Update.
3279         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3280         (btrace_fetch, btrace_clear): Update.
3281         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3282         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3283         type.
3284         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3285         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3286         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3287         * gdbarch.c, gdbarch.h: Rebuild.
3288         * gdbarch.sh (core_pid_to_str): Change return type.
3289         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3290         return type.
3291         (windows_nat_target::pid_to_str): Change return type.
3292         (windows_delete_thread): Update.
3293         (windows_nat_target::attach): Update.
3294         (windows_nat_target::files_info): Update.
3295         * target-delegates.c: Rebuild.
3296         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3297         return type.
3298         (sol_thread_target::pid_to_str): Change return type.
3299         * remote.c (class remote_target) <pid_to_str>: Change return
3300         type.
3301         (remote_target::pid_to_str): Change return type.
3302         (extended_remote_target::attach, remote_target::remote_stop_ns)
3303         (remote_target::remote_notif_remove_queued_reply)
3304         (remote_target::push_stop_reply, remote_target::disable_btrace):
3305         Update.
3306         (extended_remote_target::attach): Update.
3307         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3308         type.
3309         (gdbsim_target::pid_to_str): Change return type.
3310         * ravenscar-thread.c (struct ravenscar_thread_target)
3311         <pid_to_str>: Change return type.
3312         (ravenscar_thread_target::pid_to_str): Change return type.
3313         * procfs.c (class procfs_target) <pid_to_str>: Change return
3314         type.
3315         (procfs_target::pid_to_str): Change return type.
3316         (procfs_target::attach): Update.
3317         (procfs_target::detach): Update.
3318         (procfs_target::fetch_registers): Update.
3319         (procfs_target::store_registers): Update.
3320         (procfs_target::wait): Update.
3321         (procfs_target::files_info): Update.
3322         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3323         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3324         return type.
3325         (nto_procfs_target::pid_to_str): Change return type.
3326         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3327         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3328         return type.
3329         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3330         (exit_lwp): Update.
3331         (attach_proc_task_lwp_callback, get_detach_signal)
3332         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3333         (linux_nat_target::resume, wait_lwp, stop_callback)
3334         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3335         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3336         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3337         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3338         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3339         type.
3340         (inf_ptrace_target::attach): Update.
3341         (inf_ptrace_target::files_info): Update.
3342         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3343         type.
3344         (go32_nat_target::pid_to_str): Change return type.
3345         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3346         (gnu_nat_target::wait): Update.
3347         (gnu_nat_target::wait): Update.
3348         (gnu_nat_target::resume): Update.
3349         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3350         (fbsd_nat_target::wait): Update.
3351         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3352         type.
3353         (darwin_nat_target::attach): Update.
3354         * corelow.c (class core_target) <pid_to_str>: Change return type.
3355         (core_target::pid_to_str): Change return type.
3356         * target.c (normal_pid_to_str): Change return type.
3357         (default_pid_to_str): Likewise.
3358         (target_pid_to_str): Change return type.
3359         (target_translate_tls_address): Update.
3360         (target_announce_detach): Update.
3361         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3362         return type.
3363         (bsd_uthread_target::pid_to_str): Change return type.
3364         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3365         type.
3366         (bsd_kvm_target::pid_to_str): Change return type.
3367         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3368         return type.
3369         (aix_thread_target::pid_to_str): Change return type.
3370         * target.h (struct target_ops) <pid_to_str>: Change return type.
3371         (target_pid_to_str, normal_pid_to_str): Likewise.
3372         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3373         type.
3374         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3375         type.
3376         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3377         return type.
3378         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3379         type.
3380         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3381         type.
3382         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3383         return type.
3384
3385 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3386
3387         * NEWS: Mention that the new default MI version is 3.  Mention
3388         changes to the output of commands and events that deal with
3389         multi-location breakpoints.
3390         * breakpoint.c: Include "mi/mi-out.h".
3391         (print_one_breakpoint): Change output syntax if using MI version
3392         >= 3.
3393         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3394         New.
3395         (mi_multi_location_breakpoint_output_fixed): New.
3396         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3397         (mi_cmd_fix_multi_location_breakpoint_output): New.
3398         (mi_multi_location_breakpoint_output_fixed): New.
3399         * mi/mi-cmds.c (mi_cmds): Register command
3400         -fix-multi-location-breakpoint-output.
3401         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3402         interpreter "mi".
3403
3404 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3405
3406         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3407         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3408         instantiate mi_ui_out based on interpreter name.
3409         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3410         * mi/mi-main.c (mi_load_progress): Likewise.
3411
3412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3413
3414         * NEWS: Combine separate "New targets" sections for 8.3.
3415
3416 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3417
3418         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3419         (ppcfbsd_init_abi): Install gdbarch
3420         "fetch_tls_load_module_address" and "get_thread_local_address"
3421         methods.
3422
3423 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3424
3425         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3426         (riscv_fbsd_init_abi): Install gdbarch
3427         "fetch_tls_load_module_address" and "get_thread_local_address"
3428         methods.
3429
3430 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3431
3432         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3433         (i386fbsd_init_abi): Install gdbarch
3434         "fetch_tls_load_module_address" and "get_thread_local_address"
3435         methods.
3436
3437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3438
3439         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3440         (amd64fbsd_init_abi): Install gdbarch
3441         "fetch_tls_load_module_address" and "get_thread_local_address"
3442         methods.
3443
3444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3445
3446         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3447         (struct fbsd_pspace_data): New type.
3448         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3449         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3450         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3451         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3452         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3453
3454 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3455
3456         * gdbtypes.c (lookup_struct_elt): New function.
3457         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3458         * gdbtypes.h (struct struct_elt): New type.
3459         (lookup_struct_elt): New prototype.
3460
3461 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3462
3463         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3464         remove disabled code block.
3465
3466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3467
3468         * gdbarch.sh (get_thread_local_address): New method.
3469         * gdbarch.h, gdbarch.c: Regenerate.
3470         * target.c (target_translate_tls_address): Use
3471         gdbarch_get_thread_local_address if present instead of
3472         target::get_thread_local_address.
3473
3474 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3475
3476         * target.h (target::get_thread_local_address): Update comment.
3477
3478 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3479
3480         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3481         objfile->separate_debug_objfile_backlink if not NULL.
3482
3483 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3484
3485         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3486         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3487         (amd64bsd_store_inferior_registers): Likewise.
3488         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3489         Enable segment base registers.
3490         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3491         PT_GETFSBASE and PT_GETGSBASE.
3492         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3493         PT_SETGSBASE.
3494         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3495         segment base registers.
3496         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3497
3498 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3499
3500         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3501         Update calls to i386_target_description to add 'segments'
3502         parameter.
3503         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3504         add segment base registers.
3505         * arch/i386.c (i386_create_target_description): Add 'segments'
3506         parameter to enable segment base registers.
3507         * arch/i386.h (i386_create_target_description): Likewise.
3508         * features/i386/32bit-segments.xml: New file.
3509         * features/i386/32bit-segments.c: Generate.
3510         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3511         call to i386_target_description to add 'segments' parameter.
3512         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3513         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3514         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3515         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3516         if feature is present.
3517         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3518         Add 'segments' parameter to call to i386_target_description.
3519         (i386_target_description): Add 'segments' parameter to enable
3520         segment base registers.
3521         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3522         to call to i386_target_description.
3523         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3524         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3525         Define I386_NUM_REGS.
3526         (i386_target_description): Add 'segments' parameter to enable
3527         segment base registers.
3528
3529 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3530
3531         PR/24325
3532         * source-cache.c: #undef open and close, to avoid unresolved
3533         externals during linking.
3534
3535 2019-03-12  Tom Tromey  <tromey@adacore.com>
3536
3537         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3538         const.  Add initializers.
3539         (_initialize_remote): Don't initialize ptid globals.
3540
3541 2019-03-12  Pedro Alves  <palves@redhat.com>
3542
3543         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3544
3545 2019-03-12  Pedro Alves  <palves@redhat.com>
3546
3547         * cp-name-parser.y (main): Remove unused 'len' variable.
3548
3549 2019-03-12  Tom Tromey  <tromey@adacore.com>
3550
3551         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3552         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3553
3554 2019-03-12  Tom Tromey  <tromey@adacore.com>
3555
3556         * linux-nat.c (iterate_over_lwps): Update.
3557         (stop_callback): Remove parameter.
3558         (stop_wait_callback, detach_callback, resume_set_callback)
3559         (select_singlestep_lwp_callback, set_ignore_sigint)
3560         (status_callback, resumed_callback, resume_clear_callback)
3561         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3562         data parameter.
3563         (linux_nat_target::detach, linux_nat_target::resume)
3564         (linux_stop_and_wait_all_lwps, select_event_lwp)
3565         (linux_nat_filter_event, linux_nat_wait_1)
3566         (linux_nat_target::kill, linux_nat_target::stop)
3567         (linux_nat_target::stop): Update.
3568         (linux_nat_resume_callback): Change type.
3569         (resume_stopped_resumed_lwps, count_events_callback)
3570         (select_event_lwp_callback): Likewise.
3571         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3572         * arm-linux-nat.c (struct update_registers_data): Remove.
3573         (update_registers_callback): Change type.
3574         (arm_linux_insert_hw_breakpoint1): Update.
3575         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3576         parameter.
3577         (x86_linux_dr_set_addr): Update.
3578         (x86_linux_dr_set_control): Update.
3579         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3580         (iterate_over_lwps): Use gdb::function_view.
3581         * nat/aarch64-linux-hw-point.c (struct
3582         aarch64_dr_update_callback_param): Remove.
3583         (debug_reg_change_callback): Change type.
3584         (aarch64_notify_debug_reg_change): Update.
3585         * s390-linux-nat.c (s390_refresh_per_info): Update.
3586
3587 2019-03-11  Tom Tromey  <tromey@adacore.com>
3588
3589         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3590         redundant assignment to "this_cu".
3591
3592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3593
3594         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3595
3596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3597
3598         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3599         from...
3600         (rank_one_type): ... this.
3601
3602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3603
3604         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3605         from...
3606         (rank_one_type): ... this.
3607
3608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3609
3610         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3611         from...
3612         (rank_one_type): ... this.
3613
3614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3615
3616         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3617         from...
3618         (rank_one_type): ... this.
3619
3620 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3621
3622         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3623         from...
3624         (rank_one_type): ... this.
3625
3626 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3627
3628         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3629         from...
3630         (rank_one_type): ... this.
3631
3632 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3633
3634         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3635         from...
3636         (rank_one_type): ... this.
3637
3638 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3639
3640         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3641         from...
3642         (rank_one_type): ... this.
3643
3644 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3645
3646         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3647         from...
3648         (rank_one_type): ... this.
3649
3650 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3651
3652         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3653         from...
3654         (rank_one_type): ... this.
3655
3656 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3657
3658         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3659         from...
3660         (rank_one_type): ... this.
3661
3662 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3663
3664         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3665         from...
3666         (rank_one_type): ... this.
3667
3668 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3669
3670         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3671         inferior-events' shows the example events.
3672
3673 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3674
3675         Support styling on native MS-Windows console
3676
3677         PR/24315
3678         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3679         on MS-Windows if $TERM is not defined.
3680
3681         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3682
3683         * posix-hdep.c (gdb_console_fputs):
3684         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3685         functions.
3686         * ui-file.h (gdb_console_fputs): Add prototype.
3687
3688         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3689         back to fputs only if the former returns zero.
3690
3691 2019-03-07  Tom Tromey  <tom@tromey.com>
3692
3693         * symmisc.c (print_symbol_bcache_statistics): Update.
3694         (print_objfile_statistics): Update.
3695         * symfile.c (allocate_symtab): Update.
3696         * stabsread.c: Don't include bcache.h.
3697         * psymtab.h (struct psymbol_bcache): Don't declare.
3698         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3699         (psymbol_bcache_init, psymbol_bcache_free)
3700         (psymbol_bcache_get_bcache): Don't declare.
3701         * psymtab.c (struct psymbol_bcache): Remove.
3702         (psymtab_storage::psymtab_storage): Update.
3703         (psymtab_storage::~psymtab_storage): Update.
3704         (psymbol_bcache_init, psymbol_bcache_free)
3705         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3706         (add_psymbol_to_bcache): Update.
3707         (allocate_psymtab): Update.
3708         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3709         macro_cache>: No longer pointers.
3710         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3711         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3712         * macrotab.c (macro_bcache): Update.
3713         * macroexp.c: Don't include bcache.h.
3714         * gdbtypes.c (check_types_worklist): Update.
3715         (types_deeply_equal): Remove TRY/CATCH.  Update.
3716         * elfread.c (elf_symtab_read): Update.
3717         * dwarf2read.c: Don't include bcache.h.
3718         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3719         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3720         (print_bcache_statistics, bcache_memory_used): Don't declare.
3721         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3722         methods.  Rename all data members.
3723         * bcache.c (struct bcache): Move to bcache.h.
3724         (bcache::expand_hash_table): Rename from expand_hash_table.
3725         (bcache): Remove.
3726         (bcache::insert): Rename from bcache_full.
3727         (bcache::compare): Rename from bcache_compare.
3728         (bcache_xmalloc): Remove.
3729         (bcache::~bcache): Rename from bcache_xfree.
3730         (bcache::print_statistics): Rename from print_bcache_statistics.
3731         (bcache::memory_used): Rename from bcache_memory_used.
3732
3733 2019-03-07  Pedro Alves  <palves@redhat.com>
3734
3735         * infrun.c (normal_stop): Also check for
3736         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3737
3738 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * f-lang.c (value_from_host_double): Moved to...
3741         * value.c (value_from_host_double): ...here.
3742         * value.h (value_from_host_double): Declare.
3743         * guile/scm-math.c (vlscm_convert_typed_number): Use
3744         value_from_host_double.
3745         (vlscm_convert_number): Likewise.
3746         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3747         * python/py-value.c (convert_value_from_python): Likewise.
3748
3749 2019-03-06  Tom Tromey  <tom@tromey.com>
3750
3751         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3752
3753 2019-03-06  Tom Tromey  <tom@tromey.com>
3754
3755         * utils.h (free_current_contents): Don't declare.
3756         * utils.c (free_current_contents): Remove.
3757
3758 2019-03-06  Tom Tromey  <tom@tromey.com>
3759
3760         * top.c (quit_force): Update.
3761         * main.c (captured_command_loop): Update.
3762         * common/new-op.c (operator new): Update.
3763         * common/common-exceptions.c (struct catcher)
3764         <save_cleanup_chain>: Remove member.
3765         (exceptions_state_mc_init): Update.
3766         (exception_try_scope_entry): Return nullptr.
3767         (exception_try_scope_exit, exception_rethrow)
3768         (throw_exception_sjlj, throw_exception_cxx): Update.
3769         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3770         (all_cleanups, do_cleanups, discard_cleanups)
3771         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3772         (restore_cleanups, restore_final_cleanups): Don't declare.
3773         (do_final_cleanups): Remove parameter.
3774         * common/cleanups.c (cleanup_chain, make_cleanup)
3775         (make_cleanup_dtor, all_cleanups, do_cleanups)
3776         (discard_my_cleanups, discard_cleanups)
3777         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3778         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3779         (null_cleanup): Remove.
3780         (do_final_cleanups): Remove parameter.
3781
3782 2019-03-06  Tom Tromey  <tom@tromey.com>
3783
3784         * remote.c (remote_target::remote_parse_stop_reply): Use
3785         unique_xmalloc_ptr.
3786
3787 2019-03-06  Tom Tromey  <tom@tromey.com>
3788
3789         * stabsread.c (struct stabs_field_info): Rename from field_info.
3790         <list, fnlist>: Add initializers.
3791         <obstack>: New member.
3792         (read_member_functions, read_struct_fields, read_baseclasses):
3793         Allocate on obstack.  Don't use cleanups.
3794         (read_one_struct_field, read_member_functions, read_struct_fields)
3795         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3796         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3797         (read_struct_type): Update.
3798
3799 2019-03-06  Tom Tromey  <tom@tromey.com>
3800
3801         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3802         * common/filestuff.h (make_cleanup_close): Don't declare.
3803         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3804         Remove.
3805
3806 2019-03-06  Tom Tromey  <tom@tromey.com>
3807
3808         * solib-aix.c: Use make_scope_exit.
3809
3810 2019-03-06  Tom Tromey  <tom@tromey.com>
3811
3812         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3813         Use make_scope_exit.
3814
3815 2019-03-06  Tom Tromey  <tom@tromey.com>
3816
3817         * solib-svr4.c (disable_probes_interface): Remove parameter.
3818         (svr4_handle_solib_event): Use make_scope_exit.
3819
3820 2019-03-06  Tom Tromey  <tom@tromey.com>
3821
3822         * remote.c (struct stop_reply_deleter): Remove.
3823         (stop_reply_up): Update.
3824         (struct stop_reply): Derive from notif_event.  Don't typedef.
3825         <regcache>: Now a std::vector.
3826         (stop_reply_xfree): Remove.
3827         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3828         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3829         (remote_target::discard_pending_stop_replies): Use delete.
3830         (remote_target::remote_parse_stop_reply): Update.
3831         (remote_target::process_stop_reply): Update.
3832         * remote-notif.h (struct notif_event): Add virtual destructor.
3833         Remove "dtr" member.
3834         (struct notif_client) <alloc_event>: Return a unique_ptr.
3835         (notif_event_xfree): Don't declare.
3836         (notif_event_up): New typedef.
3837         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3838         (notif_event_xfree, do_notif_event_xfree): Remove.
3839         (remote_notif_state_xfree): Update.
3840
3841 2019-03-06  Tom Tromey  <tom@tromey.com>
3842
3843         * infrun.c (displaced_step_clear_cleanup): Now a
3844         forward_scope_exit type.
3845         (displaced_step_prepare_throw): Update.
3846         (displaced_step_fixup): Update.
3847
3848 2019-03-06  Tom Tromey  <tom@tromey.com>
3849
3850         * inferior.h (class inferior): Update comment.
3851         * gdbthread.h (class thread_info): Update comment.
3852
3853 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3854             Tom Tromey  <tom@tromey.com>
3855
3856         * stabsread.h (struct stab_section_list): Remove.
3857         (coffstab_build_psymtabs): Update.
3858         * dbxread.c (symbuf_sections): Now a std::vector.
3859         (sect_idx): New global.
3860         (fill_symbuf): Update.
3861         (coffstab_build_psymtabs): Change type of stabsects parameter.
3862         Update.
3863         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3864         std::vector.
3865         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3866         (coff_locate_sections): Update.
3867         (coff_symfile_read): Remove cleanups.  Update.
3868         (init_stringtab): Add storage parameter.
3869         (free_stringtab, free_stringtab_cleanup): Remove.
3870         (init_lineno): Add storage parameter.
3871         (free_linetab, free_linetab_cleanup): Remove.
3872
3873 2019-03-06  Pedro Alves  <palves@redhat.com>
3874
3875         * linux-fork.c (fork_info::clobber_regs): Delete.
3876         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3877         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3878         comment.  Adjust.
3879         (scoped_switch_fork_info::scoped_switch_fork_info)
3880         (checkpoint_command, linux_fork_context): Adjust
3881         fork_save_infrun_state calls.
3882
3883 2019-03-06  Pedro Alves  <palves@redhat.com>
3884
3885         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3886         (inf_has_multiple_threads): Return 'bool' and rewrite using
3887         inferior_info::threads().
3888
3889 2019-03-06  Pedro Alves  <palves@redhat.com>
3890
3891         * linux-fork.c: Include <list>.
3892         (fork_list): Now a std::list instance.
3893         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3894         (forks_exist_p, find_last_fork): Adjust.
3895         (new_fork): Delete.
3896         (one_fork_p): New.
3897         (add_fork): Adjust.
3898         (free_fork): Delete, folded into fork_info::~fork_info().
3899         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3900         Adjust.
3901         (init_fork_list): Delete.
3902         (linux_fork_killall, linux_fork_mourn_inferior)
3903         (linux_fork_detach, info_checkpoints_command): Adjust.
3904         (_initialize_linux_fork): No longer call init_fork_list.
3905
3906 2019-03-06  Pedro Alves  <palves@redhat.com>
3907
3908         * linux-fork.c (new_fork): New, split out of ...
3909         (add_fork): ... this.  Return void.  Move "first fork" special
3910         case from here, to ...
3911         (checkpoint_command): ... here.
3912         * linux-linux.h (add_fork): Return void.
3913
3914 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3915
3916         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3917
3918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3919             Chris January  <chris.january@arm.com>
3920             David Lecomber  <david.lecomber@arm.com>
3921
3922         * f-exp.y: New token, UNOP_INTRINSIC.
3923         (exp): New pattern using UNOP_INTRINSIC token.
3924         (f77_keywords): Add 'abs' keyword.
3925         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3926         (value_from_host_double): New function.
3927         (evaluate_subexp_f): Support UNOP_ABS.
3928
3929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3930
3931         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3932         types.
3933
3934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3935
3936         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3937         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3938         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3939
3940 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3943
3944 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3945             Chris January  <chris.january@arm.com>
3946
3947         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3948         * f-exp.y: Define 'KIND' token.
3949         (exp): New pattern for KIND expressions.
3950         (ptype): Handle types with a kind extension.
3951         (direct_abs_decl): Extend to spot kind extensions.
3952         (f77_keywords): Add 'kind' to the list.
3953         (push_kind_type): New function.
3954         (convert_to_kind_type): New function.
3955         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3956         * parse.c (operator_length_standard): Likewise.
3957         * parser-defs.h (enum type_pieces): Add tp_kind.
3958         * std-operator.def: Add UNOP_KIND.
3959
3960 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * f-exp.y (f_parse): Set yydebug.
3963
3964 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3965
3966         * f-lang.c (evaluate_subexp_f): New function.
3967         (exp_descriptor_f): New global.
3968         (f_language_defn): Use exp_descriptor_f instead of
3969         exp_descriptor_standard.
3970
3971 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3972
3973         * f-exp.y (struct token): Add comments.
3974         (dot_ops): Remove uppercase versions and the end marker.
3975         (f77_keywords): Likewise.
3976         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3977         entries in the dot_ops array are case insensitive, and use
3978         strncasecmp to compare strings.  Also some whitespace cleanup in
3979         this area.  Similar for the f77_keywords array, except entries in
3980         this list might be case sensitive.
3981
3982 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3983
3984         * f-exp.y (struct f77_boolean_val): Add comments.
3985         (boolean_values): Remove uppercase versions, and end marker.
3986         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3987         and use strncasecmp to achieve case insensitivity.  Additionally,
3988         perform whitespace cleanup around this code.
3989
3990 2019-03-06  Tom Tromey  <tromey@adacore.com>
3991
3992         * remote-sim.c (gdbsim_target_open): Use result of
3993         gdb_argv::release.
3994
3995 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3996         Dirk Schubert  <dirk.schubert@arm.com>
3997         Chris January  <chris.january@arm.com>
3998
3999         * eval.c (evaluate_subexp_standard): Call Fortran argument
4000         wrapping logic.
4001         * f-lang.c (struct value): A value which can be passed into a
4002         Fortran function call.
4003         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4004         where appropriate.
4005         (struct type): Value ready for a Fortran function call.
4006         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4007         is needed.
4008         * f-lang.h (fortran_argument_convert): Declaration.
4009         (fortran_preserve_arg_pointer): Declaration.
4010         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4011
4012 2019-03-05  Tom Tromey  <tromey@adacore.com>
4013
4014         * python/py-prettyprint.c (print_string_repr): Remove #if.
4015         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4016
4017 2019-03-05  Tom Tromey  <tromey@adacore.com>
4018
4019         * target.c (the_dummy_target): Move later.  Change type to
4020         "dummy_target".
4021         (initialize_targets): Don't initialize the_dummy_target.
4022
4023 2019-03-05  Tom Tromey  <tromey@adacore.com>
4024
4025         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4026         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4027
4028 2019-03-05  Tom Tromey  <tromey@adacore.com>
4029
4030         * windows-nat.c (windows_nat_target::attach)
4031         (windows_nat_target::detach): Don't call gdb_flush.
4032         * valprint.c (generic_val_print, val_print, val_print_string):
4033         Don't call gdb_flush.
4034         * utils.c (defaulted_query): Don't call gdb_flush.
4035         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4036         * target.c (target_announce_detach): Don't call gdb_flush.
4037         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4038         * remote.c (extended_remote_target::attach): Don't call
4039         gdb_flush.
4040         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4041         * printcmd.c (do_examine): Don't call gdb_flush.
4042         (info_display_command): Don't call gdb_flush.
4043         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4044         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4045         * memattr.c (info_mem_command): Don't call gdb_flush.
4046         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4047         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4048         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4049         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4050         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4051         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4052         (gnu_nat_target::detach): Don't call gdb_flush.
4053         * f-valprint.c (f_val_print): Don't call gdb_flush.
4054         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4055         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4056         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4057         gdb_flush.
4058         * c-valprint.c (c_val_print): Don't call gdb_flush.
4059         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4060
4061 2019-03-05  Tom Tromey  <tromey@adacore.com>
4062
4063         * varobj.c (update_dynamic_varobj_children): Update.
4064         (install_default_visualizer): Use reset, not release.
4065         * value.c (set_internalvar): Update.
4066         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4067         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4068         ATTRIBUTE_UNUSED_RESULT.
4069
4070 2019-03-05  Tom Tromey  <tromey@adacore.com>
4071
4072         * remote.c (class scoped_remote_fd) <release>: Add
4073         ATTRIBUTE_UNUSED_RESULT.
4074
4075 2019-03-05  Tom Tromey  <tromey@adacore.com>
4076
4077         * macroexp.c (struct macro_buffer) <release>: Add
4078         ATTRIBUTE_UNUSED_RESULT.
4079
4080 2019-03-05  Tom Tromey  <tromey@adacore.com>
4081
4082         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4083         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4084         ATTRIBUTE_UNUSED_RESULT.
4085
4086 2019-03-05  Tom Tromey  <tromey@adacore.com>
4087
4088         * common/scoped_fd.h (class scoped_fd) <release>: Add
4089         ATTRIBUTE_UNUSED_RESULT.
4090
4091 2019-03-05  Tom Tromey  <tromey@adacore.com>
4092
4093         * parser-defs.h (struct parser_state) <release>: Add
4094         ATTRIBUTE_UNUSED_RESULT.
4095
4096 2019-03-05  Tom Tromey  <tromey@adacore.com>
4097
4098         * utils.h (class gdb_argv) <release>: Add
4099         ATTRIBUTE_UNUSED_RESULT.
4100         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4101
4102 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4103
4104         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4105         for-loop range, to avoid compiler warnings.
4106
4107         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4108         avoid compiler warnings about unused variables.
4109
4110         * NEWS: Mention end of support for native debugging on MS-Windows
4111         before XP.
4112
4113         PR gdb/24292
4114         * common/netstuff.c:
4115         * gdbserver/gdbreplay.c
4116         * gdbserver/remote-utils.c:
4117         * ser-tcp.c:
4118         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4119         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4120         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4121         'getaddrinfo' and 'freeaddrinfo' were not available before
4122         Windows XP, and mingw.org's MinGW headers by default define
4123         _WIN32_WINNT to 0x500.
4124
4125 2019-03-01  Gary Benson <gbenson@redhat.com>
4126
4127         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4128
4129 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4130             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4131
4132         PR gdb/8527
4133         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4134         set_sigint_trap, clear_sigint_trap.
4135
4136 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4137
4138         * target.c (target_detach): Clear the regcache and the
4139         frame cache.
4140
4141 2019-02-27  Pedro Alves  <palves@redhat.com>
4142
4143         * utils.c (set_screen_size): When we cap the height/width sizes,
4144         tweak the corresponding command variable to show "unlimited":
4145
4146 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4147             Pedro Alves  <palves@redhat.com>
4148
4149         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4150         before calling rl_set_screen_size.
4151
4152 2019-02-27  Tom Tromey  <tromey@adacore.com>
4153
4154         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4155         define.
4156         * python/py-value.c: Remove Python 2.4 workaround.
4157         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4158         workaround.
4159         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4160         Python 2.4 workaround.
4161         * python/python-internal.h: Remove Python 2.4 comment.
4162         (Py_ssize_t): Don't define.
4163         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4164         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4165         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4166         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4167         * python/python.c (do_start_initialization): Remove Python 2.4
4168         workaround.
4169         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4170         (print_children): Remove Python 2.4 workaround.
4171         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4172         workaround.
4173         (CHARBUFFERPROC_NAME): Remove.
4174         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4175         Python 2.4 workaround.
4176
4177 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4178
4179         * NEWS: Note minimum Python version.
4180
4181 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4182
4183         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4184         code from these functions.  Remove corresponding ifdefs.  Use
4185         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4186         Remove gotos and target of gotos.
4187         (infpy_search_memory): Likewise.
4188
4189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4190
4191         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4192         (hppa_gdbarch_init): Don't register deleted functions with
4193         gdbarch.
4194
4195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4196
4197         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4198         (h8300_unwind_sp): Delete.
4199         (h8300_dummy_id): Delete.
4200         (h8300_gdbarch_init): Don't register deleted functions with
4201         gdbarch.
4202
4203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4204
4205         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4206         (ft32_unwind_pc): Delete.
4207         (ft32_unwind_sp): Delete.
4208         (ft32_gdbarch_init): Don't register deleted functions with
4209         gdbarch.
4210
4211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4212
4213         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4214         (frv_unwind_pc): Delete.
4215         (frv_unwind_sp): Delete.
4216         (frv_gdbarch_init): Don't register deleted functions with
4217         gdbarch.
4218
4219 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4220
4221         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4222         (riscv_unwind_pc): Delete.
4223         (riscv_unwind_sp): Delete.
4224         (riscv_gdbarch_init): Don't register deleted functions with
4225         gdbarch.
4226
4227 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4228
4229         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4230         (csky_unwind_pc): Delete.
4231         (csky_unwind_sp): Delete.
4232         (csky_gdbarch_init): Don't register deleted functions with
4233         gdbarch.
4234
4235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4236
4237         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4238         (cris_unwind_pc): Delete.
4239         (cris_unwind_sp): Delete.
4240         (cris_gdbarch_init): Don't register deleted functions with
4241         gdbarch.
4242
4243 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4244
4245         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4246         (bfin_unwind_pc): Delete.
4247         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4248
4249 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4252         (arm_unwind_pc): Delete.
4253         (arm_unwind_sp): Delete.
4254         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4255
4256 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4257
4258         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4259         (arc_unwind_pc): Delete.
4260         (arc_unwind_sp): Delete.
4261         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4262
4263 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4264
4265         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4266         (alpha_unwind_pc): Delete.
4267         (alpha_gdbarch_init): Don't register deleted functions with
4268         gdbarch.
4269
4270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4273         (aarch64_unwind_pc): Delete.
4274         (aarch64_unwind_sp): Delete.
4275         (aarch64_gdbarch_init): Don't register deleted functions with
4276         gdbarch.
4277
4278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4279
4280         * gdbtypes.c (type_align): Don't consider static members when
4281         computing structure alignment.
4282
4283 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4284
4285         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4286         return 0 for other types.
4287         * arch-utils.c (default_type_align): Always return 0.
4288         * gdbarch.h: Regenerate.
4289         * gdbarch.sh (type_align): Extend comment.
4290         * gdbtypes.c (type_align): Add additional comments, always call
4291         gdbarch_type_align before applying the default rules.
4292         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4293         generic code will then apply a suitable default.
4294         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4295         types, return 0 for other types.
4296
4297 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4298
4299         * NEWS: Create a new section for the next release branch.
4300         Rename the section of the current branch, now that it has
4301         been cut.
4302
4303 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4304
4305         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4306         * version.in: Bump version to 8.3.50.DATE-git.
4307
4308 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4309
4310         * aix-thread.c (ptid_cmp): Remove unused variable.
4311         (get_signaled_thread): Likewise.
4312         (store_regs_user_thread): Likewise.
4313         (store_regs_kernel_thread): Likewise.
4314         (fetch_regs_kernel_thread): Remove shadowed variable.
4315
4316 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4317
4318         * features/riscv/32bit-cpu.xml: Add register numbers.
4319         * features/riscv/32bit-fpu.c: Regenerate.
4320         * features/riscv/32bit-fpu.xml: Add register numbers.
4321         * features/riscv/64bit-cpu.xml: Add register numbers.
4322         * features/riscv/64bit-fpu.c: Regenerate.
4323         * features/riscv/64bit-fpu.xml: Add register numbers.
4324
4325 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4326
4327         * NEWS: Mention two argument form of gdb.Value constructor.
4328         * python/py-value.c (convert_buffer_and_type_to_value): New
4329         function.
4330         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4331         Add support for handling an optional second argument.  Call
4332         convert_buffer_and_type_to_value as appropriate.
4333         * python/python-internal.h (Py_buffer_deleter): New struct.
4334         (Py_buffer_up): New typedef.
4335
4336 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4337
4338         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4339         instead of releasing ownership.
4340
4341 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4342
4343         * dwarf2read.c (open_and_init_dwp_file): Call
4344         elf_numsections instead of bfd_count_sections to initialize
4345         dwp_file->num_sections.
4346
4347 2019-02-25  Tom Tromey  <tromey@adacore.com>
4348
4349         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4350
4351 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4352
4353         * gcore.in: Add '--readnever' option when invoking GDB.
4354
4355 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4356
4357         * MAINTAINERS: Update my email address.
4358
4359 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4360
4361         * build-id.c (build_id_to_debug_bfd_1): New function.
4362         (build_id_to_debug_bfd): Look for separate debug file in
4363         sysroot.
4364
4365 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4366
4367         * gdbarch.sh: Update the copyright year range that is placed into
4368         generated files.
4369
4370 2019-02-22  Keith Seitz  <keiths@redhat.com>
4371
4372         PR symtab/23853
4373         * linespec.c (create_sals_line_offset): Search for the default
4374         symtab's filename instead of its fullname.
4375
4376 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4377
4378         * NEWS: Update style defaults.
4379
4380 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4381
4382         * main.c (captured_main_1): Disable styling in batch mode.
4383
4384 2019-02-20  Tom Tromey  <tom@tromey.com>
4385
4386         * symtab.c (symtab_symbol_info): Fix typos.
4387
4388 2019-02-20  Tom Tromey  <tromey@adacore.com>
4389
4390         * findcmd.c (_initialize_mem_search): Use upper case for
4391         metasyntactic variables.
4392
4393 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4394
4395         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4396         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4397
4398 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4399
4400         * top.h (source_file_name): Change to std::string.
4401         * top.c (source_file_name): Likewise.
4402         (command_line_input): Adjust.
4403         * cli/cli-script.c (script_from_file): Adjust.
4404
4405 2019-02-19  Tom Tromey  <tromey@adacore.com>
4406
4407         * ravenscar-thread.c
4408         (ravenscar_thread_target::update_thread_list): Don't call
4409         ada_build_task_list.
4410         * ada-lang.h (ada_build_task_list): Don't declare.
4411         * ada-tasks.c (struct ada_tasks_inferior_data)
4412         <task_list_valid_p>: Now bool.
4413         (read_known_tasks, ada_task_list_changed)
4414         (ada_tasks_invalidate_inferior_data): Update.
4415         (read_known_tasks_array): Return bool.
4416         (read_known_tasks_list): Likewise.
4417         (read_known_tasks): Return void.
4418         (ada_build_task_list): Now static.
4419
4420 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4423         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4424
4425 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4426
4427         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4428         variant for ada_tasks_pspace_data_handle and
4429         ada_tasks_inferior_data_handle.
4430         (ada_tasks_pspace_data_cleanup): New function.
4431         (ada_tasks_inferior_data_cleanup): New function.
4432
4433 2019-02-17  Tom Tromey  <tom@tromey.com>
4434
4435         * macrotab.h (macro_source_fullname): Return a std::string.
4436         * macrotab.c (macro_include, check_for_redefinition)
4437         (macro_undef, macro_lookup_definition, foreach_macro)
4438         (foreach_macro_in_scope): Update.
4439         (macro_source_fullname): Return a std::string.
4440         * macrocmd.c (show_pp_source_pos): Update.
4441
4442 2019-02-17  Tom Tromey  <tom@tromey.com>
4443
4444         * macrocmd.c (show_pp_source_pos): Style the file names.
4445
4446 2019-02-17  Tom Tromey  <tom@tromey.com>
4447
4448         PR tui/24197:
4449         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4450
4451 2019-02-17  Tom Tromey  <tom@tromey.com>
4452
4453         * ada-lang.c (user_select_syms): Use filtered printing.
4454         * utils.c (wrap_style): New global.
4455         (desired_style): Remove.
4456         (emit_style_escape): Add stream parameter.
4457         (set_output_style, reset_terminal_style, prompt_for_continue):
4458         Update.
4459         (flush_wrap_buffer): Only flush gdb_stdout.
4460         (wrap_here): Set wrap_style.
4461         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4462         treat escape sequences as a character.  Change when wrap buffer is
4463         flushed.
4464         (fputs_styled): Do not set the output style when the default is
4465         requested.
4466         * ui-style.h (struct ui_file_style) <is_default>: New method.
4467         * source.c (print_source_lines_base): Emit escape sequences in one
4468         piece.
4469
4470 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4471
4472         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4473         integers and enumeration types.
4474
4475 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4476
4477         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4478         instead of lookup_symbol_in_language
4479         (do_exact_match): New function.
4480         (ada_get_symbol_name_matcher): Return do_exact_match when
4481         doing a verbatim match.
4482
4483 2019-02-15  Tom Tromey  <tromey@adacore.com>
4484
4485         * ravenscar-thread.c (ravenscar_thread_target::resume)
4486         (ravenscar_thread_target::wait): Special case wildcard requests.
4487
4488 2019-02-15  Tom Tromey  <tromey@adacore.com>
4489
4490         * ravenscar-thread.c (base_ptid): Remove.
4491         (struct ravenscar_thread_target) <close>: New method.
4492         <m_base_ptid>: New member.
4493         <update_inferior_ptid, active_task, task_is_currently_active,
4494         runtime_initialized>: Declare methods.
4495         <ravenscar_thread_target>: Add constructor.
4496         (ravenscar_thread_target::task_is_currently_active)
4497         (ravenscar_thread_target::update_inferior_ptid)
4498         (ravenscar_runtime_initialized): Rename.  Now methods.
4499         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4500         (ravenscar_thread_target::update_thread_list): Update.
4501         (ravenscar_thread_target::active_task): Now method.
4502         (ravenscar_thread_target::store_registers)
4503         (ravenscar_thread_target::prepare_to_store)
4504         (ravenscar_thread_target::prepare_to_store)
4505         (ravenscar_thread_target::mourn_inferior): Update.
4506         (ravenscar_inferior_created): Use "new" to create target.
4507         (ravenscar_thread_target::get_ada_task_ptid): Update.
4508         (_initialize_ravenscar): Don't initialize base_ptid.
4509         (ravenscar_ops): Remove global.
4510
4511 2019-02-15  Tom Tromey  <tromey@adacore.com>
4512
4513         * target.h (push_target): Declare new overload.
4514         * target.c (push_target): New overload, taking an rvalue reference.
4515         * remote.c (remote_target::open_1): Use push_target overload.
4516         * corelow.c (core_target_open): Use push_target overload.
4517
4518 2019-02-15  Tom Tromey  <tromey@adacore.com>
4519
4520         * ravenscar-thread.c (is_ravenscar_task)
4521         (ravenscar_task_is_currently_active): Return bool.
4522         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4523         (_initialize_ravenscar): Remove "(void)".
4524         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4525         Return bool.
4526
4527 2019-02-15  Tom Tromey  <tromey@adacore.com>
4528
4529         * ravenscar-thread.c (ravenscar_runtime_initializer)
4530         (has_ravenscar_runtime, get_running_thread_id)
4531         (ravenscar_thread_target::resume): Fix indentation.
4532
4533 2019-02-15  Tom Tromey  <tromey@adacore.com>
4534
4535         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4536         from ravenscar_arch_ops.
4537         (sparc_ravenscar_ops::fetch_registers)
4538         (sparc_ravenscar_ops::store_registers): Now methods.
4539         (sparc_ravenscar_prepare_to_store): Remove.
4540         (sparc_ravenscar_ops): Redefine.
4541         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4542         methods and destructor.  Remove members.
4543         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4544         (ravenscar_thread_target::store_registers)
4545         (ravenscar_thread_target::prepare_to_store): Update.
4546         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4547         Remove.
4548         (struct ppc_ravenscar_powerpc_ops): Derive from
4549         ravenscar_arch_ops.
4550         (ppc_ravenscar_powerpc_ops::fetch_registers)
4551         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4552         (ppc_ravenscar_powerpc_ops): Redefine.
4553         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4554         (ppc_ravenscar_e500_ops::fetch_registers)
4555         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4556         (ppc_ravenscar_e500_ops): Redefine.
4557         * aarch64-ravenscar-thread.c
4558         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4559         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4560         (aarch64_ravenscar_fetch_registers)
4561         (aarch64_ravenscar_store_registers): Now methods.
4562         (aarch64_ravenscar_ops): Redefine.
4563
4564 2019-02-15  Tom Tromey  <tromey@adacore.com>
4565
4566         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4567         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4568         (ravenscar_thread_target::stopped_by_watchpoint)
4569         (ravenscar_thread_target::stopped_data_address)
4570         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4571
4572 2019-02-15  Tom Tromey  <tromey@adacore.com>
4573
4574         * ravenscar-thread.c: Fix some typos.
4575
4576 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4577             Tom Tromey  <tromey@adacore.com>
4578
4579         * ada-lang.c (ada_exception_sal): Change addr_string to a
4580         std::string.
4581         (create_ada_exception_catchpoint): Update.
4582
4583 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4584             Tom Tromey  <tromey@adacore.com>
4585
4586         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4587         (bp_location_ops): Remove.
4588         (base_breakpoint_allocate_location): Update.
4589         (free_bp_location): Update.
4590         * ada-lang.c (class ada_catchpoint_location)
4591         <ada_catchpoint_location>: Remove ops parameter.
4592         (ada_catchpoint_location_dtor): Remove.
4593         (ada_catchpoint_location_ops): Remove.
4594         (allocate_location_exception): Update.
4595         * breakpoint.h (struct bp_location_ops): Remove.
4596         (class bp_location) <bp_location>: Remove bp_location_ops
4597         parameter.
4598         <~bp_location>: Add destructor.
4599         <ops>: Remove.
4600
4601 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4602             Pedro Alves  <palves@redhat.com>
4603
4604         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4605         'PATH_MAX'.
4606
4607 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4608             Samuel Thibault  <samuel.thibault@gnu.org>
4609             Thomas Schwinge  <thomas@codesourcery.com>
4610
4611         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4612         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4613
4614 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4615
4616         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4617         (check_empty): Use "const char *".
4618
4619         * gnu-nat.c (gnu_nat_target::detach): Instead of
4620         'detach_inferior (pid)' call
4621         'detach_inferior (find_inferior_pid (pid))'.
4622
4623         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4624         'nat/fork-inferior.o'.
4625         * gnu-nat.c: #include "nat/fork-inferior.h".
4626
4627         * gnu-nat.c (gnu_nat_target::detach): Instead of
4628         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4629         * gnu-nat.h: #include "inf-child.h".
4630         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4631         'i386_gnu_nat_target::fetch_registers'.
4632         (gnu_store_registers): Rename/move to
4633         'i386_gnu_nat_target::store_registers'.
4634
4635         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4636         * gnu-nat.h (mach_thread_info): New function.
4637         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4638
4639         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4640
4641 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4642
4643         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4644
4645 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4646
4647         * windows-nat.c (windows_add_thread): Add new parameter
4648         "main_thread_p" with default value set to false.  Update
4649         function documentation as well as all callers.
4650         (windows_delete_thread): Likewise.
4651         (fake_create_process): Update call to windows_add_thread.
4652         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4653         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4654         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4655         call to windows_delete_thread.
4656
4657 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4658
4659         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4660
4661 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4662
4663         * symfile.c (find_separate_debug_file): Use canonical path of
4664         sysroot with child_path instead of gdb_sysroot if it is valid.
4665
4666 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4667
4668         * symfile.c (find_separate_debug_file): Use child_path to
4669         determine if an object file is under a sysroot.
4670
4671 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4672
4673         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4674         unittests/child-path-selftests.c.
4675         * common/pathstuff.c (child_path): New function.
4676         * common/pathstuff.h (child_path): New prototype.
4677         * unittests/child-path-selftests.c: New file.
4678
4679 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4680
4681         * symfile.c (find_separate_debug_file): Look for separate debug
4682         files in debug directories under the sysroot.
4683
4684 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4685
4686         * symtab.h (struct minimal_symbol data_p): New const method.
4687         (struct minimal_symbol text_p): Likewise.
4688         * symtab.c (output_source_filename): Use file name style
4689         to print file name.
4690         (print_symbol_info): Likewise.
4691         (print_msymbol_info): Use address style to print addresses.
4692         Use function name style to print executable text symbols.
4693         (expand_symtab_containing_pc): Use data_p.
4694         (find_pc_sect_compunit_symtab): Likewise.
4695
4696 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4697
4698         * breakpoint.c (describe_other_breakpoints): Use address style
4699         to print addresses.
4700         (say_where): Likewise.
4701
4702 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4703
4704         * ada-typeprint.c (print_func_type): Print function name
4705         style to print function name.
4706         * c-typeprint.c (c_print_type_1): Likewise.
4707
4708 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4709
4710         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4711         for execve.
4712
4713 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4714
4715         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4716         type_stack.
4717
4718 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4719
4720         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4721         TYPE_CODE_REF types.
4722
4723 2019-02-08  Jim Wilson  <jimw@sifive.com>
4724
4725         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4726         (riscv_linux_fregset): New.
4727         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4728
4729 2019-02-07  Tom Tromey  <tom@tromey.com>
4730
4731         * thread.c (thread_cancel_execution_command): Update.
4732         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4733         methods.
4734         (struct thread_fsm_ops): Remove.
4735         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4736         (thread_fsm_should_stop, thread_fsm_return_value)
4737         (thread_fsm_set_finished, thread_fsm_finished_p)
4738         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4739         Don't declare.
4740         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4741         * infrun.c (clear_proceed_status_thread)
4742         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4743         (print_stop_event): Update.
4744         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4745         Add constructor.
4746         (step_command_fsm_ops): Remove.
4747         (new_step_command_fsm): Remove.
4748         (step_1): Update.
4749         (step_command_fsm::should_stop): Rename from
4750         step_command_fsm_should_stop.
4751         (step_command_fsm::clean_up): Rename from
4752         step_command_fsm_clean_up.
4753         (step_command_fsm::do_async_reply_reason): Rename from
4754         step_command_fsm_async_reply_reason.
4755         (struct until_next_fsm): Inherit from thread_fsm.  Add
4756         constructor.
4757         (until_next_fsm_ops): Remove.
4758         (new_until_next_fsm): Remove.
4759         (until_next_fsm::should_stop): Rename from
4760         until_next_fsm_should_stop.
4761         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4762         (until_next_fsm::do_async_reply_reason): Rename from
4763         until_next_fsm_async_reply_reason.
4764         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4765         constructor.  Change type of breakpoint.
4766         (finish_command_fsm_ops): Remove.
4767         (new_finish_command_fsm): Remove.
4768         (finish_command_fsm::should_stop): Rename from
4769         finish_command_fsm_should_stop.
4770         (finish_command_fsm::clean_up): Rename from
4771         finish_command_fsm_clean_up.
4772         (finish_command_fsm::return_value): Rename from
4773         finish_command_fsm_return_value.
4774         (finish_command_fsm::do_async_reply_reason): Rename from
4775         finish_command_fsm_async_reply_reason.
4776         (finish_command): Update.
4777         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4778         Add constructor.
4779         (call_thread_fsm_ops): Remove.
4780         (call_thread_fsm::call_thread_fsm): Rename from
4781         new_call_thread_fsm.
4782         (call_thread_fsm::should_stop): Rename from
4783         call_thread_fsm_should_stop.
4784         (call_thread_fsm::should_notify_stop): Rename from
4785         call_thread_fsm_should_notify_stop.
4786         (run_inferior_call, call_function_by_hand_dummy): Update.
4787         * cli/cli-interp.c (should_print_stop_to_console): Update.
4788         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4789         Add constructor.  Change type of location_breakpoint,
4790         caller_breakpoint.
4791         (until_break_fsm_ops): Remove.
4792         (new_until_break_fsm): Remove.
4793         (until_break_fsm::should_stop): Rename from
4794         until_break_fsm_should_stop.
4795         (until_break_fsm::clean_up): Rename from
4796         until_break_fsm_clean_up.
4797         (until_break_fsm::do_async_reply_reason): Rename from
4798         until_break_fsm_async_reply_reason.
4799         (until_break_command): Update.
4800         * thread-fsm.c: Remove.
4801         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4802
4803 2019-02-07  Tom Tromey  <tom@tromey.com>
4804
4805         * yy-remap.h: Add include guard.
4806         * xtensa-tdep.h: Add include guard.
4807         * xcoffread.h: Rename include guard.
4808         * varobj-iter.h: Add include guard.
4809         * tui/tui.h: Rename include guard.
4810         * tui/tui-winsource.h: Rename include guard.
4811         * tui/tui-wingeneral.h: Rename include guard.
4812         * tui/tui-windata.h: Rename include guard.
4813         * tui/tui-win.h: Rename include guard.
4814         * tui/tui-stack.h: Rename include guard.
4815         * tui/tui-source.h: Rename include guard.
4816         * tui/tui-regs.h: Rename include guard.
4817         * tui/tui-out.h: Rename include guard.
4818         * tui/tui-layout.h: Rename include guard.
4819         * tui/tui-io.h: Rename include guard.
4820         * tui/tui-hooks.h: Rename include guard.
4821         * tui/tui-file.h: Rename include guard.
4822         * tui/tui-disasm.h: Rename include guard.
4823         * tui/tui-data.h: Rename include guard.
4824         * tui/tui-command.h: Rename include guard.
4825         * tic6x-tdep.h: Add include guard.
4826         * target/waitstatus.h: Rename include guard.
4827         * target/wait.h: Rename include guard.
4828         * target/target.h: Rename include guard.
4829         * target/resume.h: Rename include guard.
4830         * target-float.h: Rename include guard.
4831         * stabsread.h: Add include guard.
4832         * rs6000-tdep.h: Add include guard.
4833         * riscv-fbsd-tdep.h: Add include guard.
4834         * regformats/regdef.h: Rename include guard.
4835         * record.h: Rename include guard.
4836         * python/python.h: Rename include guard.
4837         * python/python-internal.h: Rename include guard.
4838         * python/py-stopevent.h: Rename include guard.
4839         * python/py-ref.h: Rename include guard.
4840         * python/py-record.h: Rename include guard.
4841         * python/py-record-full.h: Rename include guard.
4842         * python/py-record-btrace.h: Rename include guard.
4843         * python/py-instruction.h: Rename include guard.
4844         * python/py-events.h: Rename include guard.
4845         * python/py-event.h: Rename include guard.
4846         * procfs.h: Add include guard.
4847         * proc-utils.h: Add include guard.
4848         * p-lang.h: Add include guard.
4849         * or1k-tdep.h: Rename include guard.
4850         * observable.h: Rename include guard.
4851         * nto-tdep.h: Rename include guard.
4852         * nat/x86-linux.h: Rename include guard.
4853         * nat/x86-linux-dregs.h: Rename include guard.
4854         * nat/x86-gcc-cpuid.h: Add include guard.
4855         * nat/x86-dregs.h: Rename include guard.
4856         * nat/x86-cpuid.h: Rename include guard.
4857         * nat/ppc-linux.h: Rename include guard.
4858         * nat/mips-linux-watch.h: Rename include guard.
4859         * nat/linux-waitpid.h: Rename include guard.
4860         * nat/linux-ptrace.h: Rename include guard.
4861         * nat/linux-procfs.h: Rename include guard.
4862         * nat/linux-osdata.h: Rename include guard.
4863         * nat/linux-nat.h: Rename include guard.
4864         * nat/linux-namespaces.h: Rename include guard.
4865         * nat/linux-btrace.h: Rename include guard.
4866         * nat/glibc_thread_db.h: Rename include guard.
4867         * nat/gdb_thread_db.h: Rename include guard.
4868         * nat/gdb_ptrace.h: Rename include guard.
4869         * nat/fork-inferior.h: Rename include guard.
4870         * nat/amd64-linux-siginfo.h: Rename include guard.
4871         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4872         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4873         * nat/aarch64-linux.h: Rename include guard.
4874         * nat/aarch64-linux-hw-point.h: Rename include guard.
4875         * mn10300-tdep.h: Add include guard.
4876         * mips-linux-tdep.h: Add include guard.
4877         * mi/mi-parse.h: Rename include guard.
4878         * mi/mi-out.h: Rename include guard.
4879         * mi/mi-main.h: Rename include guard.
4880         * mi/mi-interp.h: Rename include guard.
4881         * mi/mi-getopt.h: Rename include guard.
4882         * mi/mi-console.h: Rename include guard.
4883         * mi/mi-common.h: Rename include guard.
4884         * mi/mi-cmds.h: Rename include guard.
4885         * mi/mi-cmd-break.h: Rename include guard.
4886         * m2-lang.h: Add include guard.
4887         * location.h: Rename include guard.
4888         * linux-record.h: Rename include guard.
4889         * linux-nat.h: Add include guard.
4890         * linux-fork.h: Add include guard.
4891         * i386-darwin-tdep.h: Rename include guard.
4892         * hppa-linux-offsets.h: Add include guard.
4893         * guile/guile.h: Rename include guard.
4894         * guile/guile-internal.h: Rename include guard.
4895         * gnu-nat.h: Rename include guard.
4896         * gdb-stabs.h: Rename include guard.
4897         * frv-tdep.h: Add include guard.
4898         * f-lang.h: Add include guard.
4899         * event-loop.h: Add include guard.
4900         * darwin-nat.h: Rename include guard.
4901         * cp-abi.h: Rename include guard.
4902         * config/sparc/nm-sol2.h: Rename include guard.
4903         * config/nm-nto.h: Rename include guard.
4904         * config/nm-linux.h: Add include guard.
4905         * config/i386/nm-i386gnu.h: Rename include guard.
4906         * config/djgpp/nl_types.h: Rename include guard.
4907         * config/djgpp/langinfo.h: Rename include guard.
4908         * compile/gcc-cp-plugin.h: Add include guard.
4909         * compile/gcc-c-plugin.h: Add include guard.
4910         * compile/compile.h: Rename include guard.
4911         * compile/compile-object-run.h: Rename include guard.
4912         * compile/compile-object-load.h: Rename include guard.
4913         * compile/compile-internal.h: Rename include guard.
4914         * compile/compile-cplus.h: Rename include guard.
4915         * compile/compile-c.h: Rename include guard.
4916         * common/xml-utils.h: Rename include guard.
4917         * common/x86-xstate.h: Rename include guard.
4918         * common/version.h: Rename include guard.
4919         * common/vec.h: Rename include guard.
4920         * common/tdesc.h: Rename include guard.
4921         * common/selftest.h: Rename include guard.
4922         * common/scoped_restore.h: Rename include guard.
4923         * common/scoped_mmap.h: Rename include guard.
4924         * common/scoped_fd.h: Rename include guard.
4925         * common/safe-iterator.h: Rename include guard.
4926         * common/run-time-clock.h: Rename include guard.
4927         * common/refcounted-object.h: Rename include guard.
4928         * common/queue.h: Rename include guard.
4929         * common/ptid.h: Rename include guard.
4930         * common/print-utils.h: Rename include guard.
4931         * common/preprocessor.h: Rename include guard.
4932         * common/pathstuff.h: Rename include guard.
4933         * common/observable.h: Rename include guard.
4934         * common/netstuff.h: Rename include guard.
4935         * common/job-control.h: Rename include guard.
4936         * common/host-defs.h: Rename include guard.
4937         * common/gdb_wait.h: Rename include guard.
4938         * common/gdb_vecs.h: Rename include guard.
4939         * common/gdb_unlinker.h: Rename include guard.
4940         * common/gdb_unique_ptr.h: Rename include guard.
4941         * common/gdb_tilde_expand.h: Rename include guard.
4942         * common/gdb_sys_time.h: Rename include guard.
4943         * common/gdb_string_view.h: Rename include guard.
4944         * common/gdb_splay_tree.h: Rename include guard.
4945         * common/gdb_setjmp.h: Rename include guard.
4946         * common/gdb_ref_ptr.h: Rename include guard.
4947         * common/gdb_optional.h: Rename include guard.
4948         * common/gdb_locale.h: Rename include guard.
4949         * common/gdb_assert.h: Rename include guard.
4950         * common/filtered-iterator.h: Rename include guard.
4951         * common/filestuff.h: Rename include guard.
4952         * common/fileio.h: Rename include guard.
4953         * common/environ.h: Rename include guard.
4954         * common/common-utils.h: Rename include guard.
4955         * common/common-types.h: Rename include guard.
4956         * common/common-regcache.h: Rename include guard.
4957         * common/common-inferior.h: Rename include guard.
4958         * common/common-gdbthread.h: Rename include guard.
4959         * common/common-exceptions.h: Rename include guard.
4960         * common/common-defs.h: Rename include guard.
4961         * common/common-debug.h: Rename include guard.
4962         * common/cleanups.h: Rename include guard.
4963         * common/buffer.h: Rename include guard.
4964         * common/btrace-common.h: Rename include guard.
4965         * common/break-common.h: Rename include guard.
4966         * cli/cli-utils.h: Rename include guard.
4967         * cli/cli-style.h: Rename include guard.
4968         * cli/cli-setshow.h: Rename include guard.
4969         * cli/cli-script.h: Rename include guard.
4970         * cli/cli-interp.h: Rename include guard.
4971         * cli/cli-decode.h: Rename include guard.
4972         * cli/cli-cmds.h: Rename include guard.
4973         * charset-list.h: Add include guard.
4974         * buildsym-legacy.h: Rename include guard.
4975         * bfin-tdep.h: Add include guard.
4976         * ax.h: Rename include guard.
4977         * arm-linux-tdep.h: Add include guard.
4978         * arm-fbsd-tdep.h: Add include guard.
4979         * arch/xtensa.h: Rename include guard.
4980         * arch/tic6x.h: Add include guard.
4981         * arch/i386.h: Add include guard.
4982         * arch/arm.h: Rename include guard.
4983         * arch/arm-linux.h: Rename include guard.
4984         * arch/arm-get-next-pcs.h: Rename include guard.
4985         * arch/amd64.h: Add include guard.
4986         * arch/aarch64-insn.h: Rename include guard.
4987         * arch-utils.h: Rename include guard.
4988         * annotate.h: Add include guard.
4989         * amd64-darwin-tdep.h: Rename include guard.
4990         * aarch64-linux-tdep.h: Add include guard.
4991         * aarch64-fbsd-tdep.h: Add include guard.
4992         * aarch32-linux-nat.h: Add include guard.
4993
4994 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4995
4996         * macrotab.c (macro_define_internal): New function that
4997         factorizes macro_define_object_internal and macro_define_function
4998         code.
4999         (macro_define_object_internal): Use macro_define_internal.
5000         (macro_define_function): Likewise.
5001
5002 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5003
5004         * macrocmd.c (extract_identifier): Return
5005         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5006         callers.
5007
5008 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5009
5010         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5011
5012 2019-02-05  Tom Tromey  <tom@tromey.com>
5013
5014         * target.c (target_stack::unpush): Move assertion earlier.
5015
5016 2019-01-30  Tom Tromey  <tom@tromey.com>
5017
5018         PR python/23615:
5019         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5020         (gdbpy_parse_and_eval): Likewise.
5021         * python/python-internal.h (gdbpy_allow_threads): New class.
5022
5023 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5024
5025         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5026         (aarch64_fbsd_fpregmap): Move earlier.
5027         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5028         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5029         instead of individual calls to trad_frame_set_reg_addr.
5030         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5031         earlier.
5032         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5033         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5034         instead of individual calls to trad_frame_set_reg_addr.
5035
5036 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5037
5038         * CONTRIBUTE: Replace contribution list with wiki link.
5039
5040 2019-01-25  Tom Tromey  <tom@tromey.com>
5041
5042         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5043
5044 2019-01-25  Tom Tromey  <tom@tromey.com>
5045
5046         * xtensa-linux-nat.c: Fix common/ includes.
5047         * xml-support.h: Fix common/ includes.
5048         * xml-support.c: Fix common/ includes.
5049         * x86-linux-nat.c: Fix common/ includes.
5050         * windows-nat.c: Fix common/ includes.
5051         * varobj.h: Fix common/ includes.
5052         * varobj.c: Fix common/ includes.
5053         * value.c: Fix common/ includes.
5054         * valops.c: Fix common/ includes.
5055         * utils.c: Fix common/ includes.
5056         * unittests/xml-utils-selftests.c: Fix common/ includes.
5057         * unittests/utils-selftests.c: Fix common/ includes.
5058         * unittests/unpack-selftests.c: Fix common/ includes.
5059         * unittests/tracepoint-selftests.c: Fix common/ includes.
5060         * unittests/style-selftests.c: Fix common/ includes.
5061         * unittests/string_view-selftests.c: Fix common/ includes.
5062         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5063         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5064         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5065         * unittests/rsp-low-selftests.c: Fix common/ includes.
5066         * unittests/parse-connection-spec-selftests.c: Fix common/
5067         includes.
5068         * unittests/optional-selftests.c: Fix common/ includes.
5069         * unittests/offset-type-selftests.c: Fix common/ includes.
5070         * unittests/observable-selftests.c: Fix common/ includes.
5071         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5072         * unittests/memrange-selftests.c: Fix common/ includes.
5073         * unittests/memory-map-selftests.c: Fix common/ includes.
5074         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5075         * unittests/function-view-selftests.c: Fix common/ includes.
5076         * unittests/environ-selftests.c: Fix common/ includes.
5077         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5078         * unittests/common-utils-selftests.c: Fix common/ includes.
5079         * unittests/cli-utils-selftests.c: Fix common/ includes.
5080         * unittests/array-view-selftests.c: Fix common/ includes.
5081         * ui-file.c: Fix common/ includes.
5082         * tui/tui-io.c: Fix common/ includes.
5083         * tracepoint.h: Fix common/ includes.
5084         * tracepoint.c: Fix common/ includes.
5085         * tracefile-tfile.c: Fix common/ includes.
5086         * top.h: Fix common/ includes.
5087         * top.c: Fix common/ includes.
5088         * thread.c: Fix common/ includes.
5089         * target/waitstatus.h: Fix common/ includes.
5090         * target/waitstatus.c: Fix common/ includes.
5091         * target.h: Fix common/ includes.
5092         * target.c: Fix common/ includes.
5093         * target-memory.c: Fix common/ includes.
5094         * target-descriptions.c: Fix common/ includes.
5095         * symtab.h: Fix common/ includes.
5096         * symfile.c: Fix common/ includes.
5097         * stap-probe.c: Fix common/ includes.
5098         * spu-linux-nat.c: Fix common/ includes.
5099         * sparc-nat.c: Fix common/ includes.
5100         * source.c: Fix common/ includes.
5101         * solib.c: Fix common/ includes.
5102         * solib-target.c: Fix common/ includes.
5103         * ser-unix.c: Fix common/ includes.
5104         * ser-tcp.c: Fix common/ includes.
5105         * ser-pipe.c: Fix common/ includes.
5106         * ser-base.c: Fix common/ includes.
5107         * selftest-arch.c: Fix common/ includes.
5108         * s12z-tdep.c: Fix common/ includes.
5109         * rust-exp.y: Fix common/ includes.
5110         * rs6000-aix-tdep.c: Fix common/ includes.
5111         * riscv-tdep.c: Fix common/ includes.
5112         * remote.c: Fix common/ includes.
5113         * remote-notif.h: Fix common/ includes.
5114         * remote-fileio.h: Fix common/ includes.
5115         * remote-fileio.c: Fix common/ includes.
5116         * regcache.h: Fix common/ includes.
5117         * regcache.c: Fix common/ includes.
5118         * record-btrace.c: Fix common/ includes.
5119         * python/python.c: Fix common/ includes.
5120         * python/py-type.c: Fix common/ includes.
5121         * python/py-inferior.c: Fix common/ includes.
5122         * progspace.h: Fix common/ includes.
5123         * producer.c: Fix common/ includes.
5124         * procfs.c: Fix common/ includes.
5125         * proc-api.c: Fix common/ includes.
5126         * printcmd.c: Fix common/ includes.
5127         * ppc-linux-nat.c: Fix common/ includes.
5128         * parser-defs.h: Fix common/ includes.
5129         * osdata.c: Fix common/ includes.
5130         * obsd-nat.c: Fix common/ includes.
5131         * nat/x86-linux.c: Fix common/ includes.
5132         * nat/x86-linux-dregs.c: Fix common/ includes.
5133         * nat/x86-dregs.h: Fix common/ includes.
5134         * nat/x86-dregs.c: Fix common/ includes.
5135         * nat/ppc-linux.c: Fix common/ includes.
5136         * nat/mips-linux-watch.h: Fix common/ includes.
5137         * nat/mips-linux-watch.c: Fix common/ includes.
5138         * nat/linux-waitpid.c: Fix common/ includes.
5139         * nat/linux-ptrace.h: Fix common/ includes.
5140         * nat/linux-ptrace.c: Fix common/ includes.
5141         * nat/linux-procfs.c: Fix common/ includes.
5142         * nat/linux-personality.c: Fix common/ includes.
5143         * nat/linux-osdata.c: Fix common/ includes.
5144         * nat/linux-namespaces.c: Fix common/ includes.
5145         * nat/linux-btrace.h: Fix common/ includes.
5146         * nat/linux-btrace.c: Fix common/ includes.
5147         * nat/fork-inferior.c: Fix common/ includes.
5148         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5149         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5150         * nat/aarch64-linux.c: Fix common/ includes.
5151         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5152         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5153         * namespace.h: Fix common/ includes.
5154         * mips-linux-tdep.c: Fix common/ includes.
5155         * minsyms.c: Fix common/ includes.
5156         * mi/mi-parse.h: Fix common/ includes.
5157         * mi/mi-main.c: Fix common/ includes.
5158         * mi/mi-cmd-env.c: Fix common/ includes.
5159         * memrange.h: Fix common/ includes.
5160         * memattr.c: Fix common/ includes.
5161         * maint.h: Fix common/ includes.
5162         * maint.c: Fix common/ includes.
5163         * main.c: Fix common/ includes.
5164         * machoread.c: Fix common/ includes.
5165         * location.c: Fix common/ includes.
5166         * linux-thread-db.c: Fix common/ includes.
5167         * linux-nat.c: Fix common/ includes.
5168         * linux-fork.c: Fix common/ includes.
5169         * inline-frame.c: Fix common/ includes.
5170         * infrun.c: Fix common/ includes.
5171         * inflow.c: Fix common/ includes.
5172         * inferior.h: Fix common/ includes.
5173         * inferior.c: Fix common/ includes.
5174         * infcmd.c: Fix common/ includes.
5175         * inf-ptrace.c: Fix common/ includes.
5176         * inf-child.c: Fix common/ includes.
5177         * ia64-linux-nat.c: Fix common/ includes.
5178         * i387-tdep.c: Fix common/ includes.
5179         * i386-tdep.c: Fix common/ includes.
5180         * i386-linux-tdep.c: Fix common/ includes.
5181         * i386-linux-nat.c: Fix common/ includes.
5182         * i386-go32-tdep.c: Fix common/ includes.
5183         * i386-fbsd-tdep.c: Fix common/ includes.
5184         * i386-fbsd-nat.c: Fix common/ includes.
5185         * guile/scm-type.c: Fix common/ includes.
5186         * guile/guile.c: Fix common/ includes.
5187         * go32-nat.c: Fix common/ includes.
5188         * gnu-nat.c: Fix common/ includes.
5189         * gdbthread.h: Fix common/ includes.
5190         * gdbarch-selftests.c: Fix common/ includes.
5191         * gdb_usleep.c: Fix common/ includes.
5192         * gdb_select.h: Fix common/ includes.
5193         * gdb_bfd.c: Fix common/ includes.
5194         * gcore.c: Fix common/ includes.
5195         * fork-child.c: Fix common/ includes.
5196         * findvar.c: Fix common/ includes.
5197         * fbsd-nat.c: Fix common/ includes.
5198         * event-top.c: Fix common/ includes.
5199         * event-loop.c: Fix common/ includes.
5200         * dwarf2read.c: Fix common/ includes.
5201         * dwarf2loc.c: Fix common/ includes.
5202         * dwarf2-frame.c: Fix common/ includes.
5203         * dwarf-index-cache.c: Fix common/ includes.
5204         * dtrace-probe.c: Fix common/ includes.
5205         * disasm-selftests.c: Fix common/ includes.
5206         * defs.h: Fix common/ includes.
5207         * csky-tdep.c: Fix common/ includes.
5208         * cp-valprint.c: Fix common/ includes.
5209         * cp-support.h: Fix common/ includes.
5210         * cp-support.c: Fix common/ includes.
5211         * corelow.c: Fix common/ includes.
5212         * completer.h: Fix common/ includes.
5213         * completer.c: Fix common/ includes.
5214         * compile/compile.c: Fix common/ includes.
5215         * compile/compile-loc2c.c: Fix common/ includes.
5216         * compile/compile-cplus-types.c: Fix common/ includes.
5217         * compile/compile-cplus-symbols.c: Fix common/ includes.
5218         * command.h: Fix common/ includes.
5219         * cli/cli-dump.c: Fix common/ includes.
5220         * cli/cli-cmds.c: Fix common/ includes.
5221         * charset.c: Fix common/ includes.
5222         * build-id.c: Fix common/ includes.
5223         * btrace.h: Fix common/ includes.
5224         * btrace.c: Fix common/ includes.
5225         * breakpoint.h: Fix common/ includes.
5226         * breakpoint.c: Fix common/ includes.
5227         * ax.h:
5228         (enum agent_op): Fix common/ includes.
5229         * ax-general.c (struct aop_map): Fix common/ includes.
5230         * ax-gdb.c: Fix common/ includes.
5231         * auxv.c: Fix common/ includes.
5232         * auto-load.c: Fix common/ includes.
5233         * arm-tdep.c: Fix common/ includes.
5234         * arch/riscv.c: Fix common/ includes.
5235         * arch/ppc-linux-common.c: Fix common/ includes.
5236         * arch/i386.c: Fix common/ includes.
5237         * arch/arm.c: Fix common/ includes.
5238         * arch/arm-linux.c: Fix common/ includes.
5239         * arch/arm-get-next-pcs.c: Fix common/ includes.
5240         * arch/amd64.c: Fix common/ includes.
5241         * arch/aarch64.c: Fix common/ includes.
5242         * arch/aarch64-insn.c: Fix common/ includes.
5243         * arch-utils.c: Fix common/ includes.
5244         * amd64-windows-tdep.c: Fix common/ includes.
5245         * amd64-tdep.c: Fix common/ includes.
5246         * amd64-sol2-tdep.c: Fix common/ includes.
5247         * amd64-obsd-tdep.c: Fix common/ includes.
5248         * amd64-nbsd-tdep.c: Fix common/ includes.
5249         * amd64-linux-tdep.c: Fix common/ includes.
5250         * amd64-linux-nat.c: Fix common/ includes.
5251         * amd64-fbsd-tdep.c: Fix common/ includes.
5252         * amd64-fbsd-nat.c: Fix common/ includes.
5253         * amd64-dicos-tdep.c: Fix common/ includes.
5254         * amd64-darwin-tdep.c: Fix common/ includes.
5255         * agent.c: Fix common/ includes.
5256         * ada-lang.h: Fix common/ includes.
5257         * ada-lang.c: Fix common/ includes.
5258         * aarch64-tdep.c: Fix common/ includes.
5259
5260 2019-01-25  Tom Tromey  <tom@tromey.com>
5261
5262         * common/create-version.sh: Use common/version.h.
5263
5264 2019-01-24  Pedro Alves  <palves@redhat.com>
5265
5266         * infrun.c (signal_stop, signal_print, signal_program)
5267         (signal_catch, signal_pass): Now arrays instead of pointers.
5268         (update_signals_program_target, do_target_resume)
5269         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5270         * linux-nat.c (linux_nat_target::pass_signals)
5271         (linux_nat_target::create_inferior, linux_nat_target::attach):
5272         Adjust.
5273         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5274         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5275         * procfs.c (procfs_target::pass_signals): Adjust.
5276         * record-full.c (record_full_target::resume): Adjust.
5277         * remote.c (remote_target::pass_signals)
5278         (remote_target::program_signals): Adjust.
5279         * target-debug.h (target_debug_print_signals): Now takes a
5280         gdb::array_view as parameter.  Adjust.
5281         * target.h (target_ops) <pass_signals, program_signals>: Replace
5282         pointer and length parameters with gdb::array_view.
5283         (target_pass_signals, target_program_signals): Likewise.
5284         * target-delegates.c: Regenerate.
5285
5286 2019-01-24  Pedro Alves  <palves@redhat.com>
5287
5288         * common/forward-scope-exit.h
5289         (forward_scope_exit::forward_scope_exit): Pass arguments to
5290         m_bind_function directly, instead of creating a std::bind and
5291         copying that.
5292
5293 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5294
5295         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5296         for static members.
5297         (pass_in_v_vfp_candidate): Likewise.
5298
5299 2019-01-23  Tom Tromey  <tom@tromey.com>
5300             Pedro Alves  <palves@redhat.com>
5301
5302         * regcache.c (class regcache_invalidator): Remove.
5303         (regcache::raw_write): Use make_scope_exit.
5304
5305 2019-01-23  Tom Tromey  <tom@tromey.com>
5306
5307         * ui-out.h (class ui_out_emit_type): Update comment.
5308
5309 2019-01-23  Tom Tromey  <tom@tromey.com>
5310
5311         * infrun.c (fetch_inferior_event): Update comment.
5312
5313 2019-01-23  Tom Tromey  <tom@tromey.com>
5314             Pedro Alves  <palves@redhat.com>
5315
5316         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5317         parameter.
5318         (fetch_inferior_event): Use SCOPE_EXIT.
5319
5320
5321 2019-01-23  Tom Tromey  <tom@tromey.com>
5322             Pedro Alves  <palves@redhat.com>
5323
5324         * infrun.c (disable_thread_events): Delete.
5325         (stop_all_threads): Use SCOPE_EXIT.
5326
5327 2019-01-23  Tom Tromey  <tom@tromey.com>
5328             Pedro Alves  <palves@redhat.com>
5329
5330         * symfile.c: Include forward-scope-exit.h.
5331         (clear_symtab_users_cleanup): Replace forward declaration with
5332         a FORWARD_SCOPE_EXIT.
5333         (syms_from_objfile_1): Use the forward_scope_exit and
5334         gdb::optional instead of cleanup_function.
5335         (reread_symbols): Use the forward_scope_exit instead of
5336         cleanup_function.
5337         (clear_symtab_users_cleanup): Remove function.
5338
5339 2019-01-23  Tom Tromey  <tom@tromey.com>
5340             Pedro Alves  <palves@redhat.com>
5341
5342         * linux-nat.c: Include scope-exit.h.
5343         (cleanup_target_stop): Remove.
5344         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5345         SCOPE_EXIT.
5346
5347 2019-01-23  Tom Tromey  <tom@tromey.com>
5348             Pedro Alves  <palves@redhat.com>
5349
5350         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5351         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5352
5353 2019-01-23  Tom Tromey  <tom@tromey.com>
5354             Andrew Burgess  <andrew.burgess@embecosm.com>
5355             Pedro Alves  <palves@redhat.com>
5356
5357         * infrun.c (fetch_inferior_event): Use scope_exit.
5358         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5359         * top.c (execute_command): Use scope_exit.
5360         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5361         * utils.c (do_bpstat_clear_actions_cleanup)
5362         (make_bpstat_clear_actions_cleanup): Remove.
5363
5364 2019-01-23  Tom Tromey  <tom@tromey.com>
5365             Pedro Alves  <palves@redhat.com>
5366
5367         * infrun.c: Include "common/scope-exit.h"
5368         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5369         (wait_for_inferior): Use SCOPE_EXIT.
5370         (fetch_inferior_event): Use scope_exit.
5371
5372 2019-01-23  Tom Tromey  <tom@tromey.com>
5373             Pedro Alves  <palves@redhat.com>
5374
5375         * breakpoint.c (create_breakpoint): Remove cleanup.
5376
5377 2019-01-23  Tom Tromey  <tom@tromey.com>
5378             Andrew Burgess  <andrew.burgess@embecosm.com>
5379             Pedro Alves  <palves@redhat.com>
5380
5381 2019-01-23  Pedro Alves  <palves@redhat.com>
5382
5383         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5384
5385 2019-01-23  Pedro Alves  <palves@redhat.com>
5386             Andrew Burgess  <andrew.burgess@embecosm.com>
5387
5388         * gdbthread.h: Include "common/forward-scope-exit.h".
5389         (scoped_finish_thread_state): Redefine custom class in terms of
5390         forward_scope_exit.
5391
5392 2019-01-23  Pedro Alves  <palves@redhat.com>
5393             Andrew Burgess  <andrew.burgess@embecosm.com>
5394
5395         * common/forward-scope-exit.h: New file.
5396
5397 2019-01-23  Pedro Alves  <palves@redhat.com>
5398             Andrew Burgess  <andrew.burgess@embecosm.com>
5399             Tom Tromey  <tom@tromey.com>
5400
5401         * common/scope-exit.h: New file.
5402
5403 2019-01-23  Pedro Alves  <palves@redhat.com>
5404
5405         * common/preprocessor.h (ESC): Rename to ...
5406         (ESC_PARENS): ... this.
5407         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5408         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5409
5410 2019-01-23  Tom Tromey  <tom@tromey.com>
5411
5412         * language.h (class scoped_switch_to_sym_language_if_auto):
5413         Initialize m_lang in both cases.
5414
5415 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5416
5417         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5418         with XCNEW.
5419
5420 2019-01-22  Tom Tromey  <tom@tromey.com>
5421
5422         * corelow.c: Do not include sys/file.h.
5423
5424 2019-01-22  Tom Tromey  <tom@tromey.com>
5425
5426         * tui/tui-wingeneral.h: Include gdb_curses.h.
5427
5428 2019-01-22  Tom Tromey  <tom@tromey.com>
5429
5430         * source-cache.h (class source_cache) <get_source_lines,
5431         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5432
5433 2019-01-22  Tom Tromey  <tom@tromey.com>
5434
5435         * remote-fileio.h (struct remote_target): Declare.
5436
5437 2019-01-22  Tom Tromey  <tom@tromey.com>
5438
5439         * python/py-arch.c: Do not include py-ref.h.
5440         * python/py-bpevent.c: Do not include py-ref.h.
5441         * python/py-cmd.c: Do not include py-ref.h.
5442         * python/py-continueevent.c: Do not include py-ref.h.
5443         * python/py-event.h: Do not include py-ref.h.
5444         * python/py-evtregistry.c: Do not include py-ref.h.
5445         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5446         * python/py-frame.c: Do not include py-ref.h.
5447         * python/py-framefilter.c: Do not include py-ref.h.
5448         * python/py-function.c: Do not include py-ref.h.
5449         * python/py-infevents.c: Do not include py-ref.h.
5450         * python/py-linetable.c: Do not include py-ref.h.
5451         * python/py-objfile.c: Do not include py-ref.h.
5452         * python/py-param.c: Do not include py-ref.h.
5453         * python/py-prettyprint.c: Do not include py-ref.h.
5454         * python/py-progspace.c: Do not include py-ref.h.
5455         * python/py-symbol.c: Do not include py-ref.h.
5456         * python/py-symtab.c: Do not include py-ref.h.
5457         * python/py-type.c: Do not include py-ref.h.
5458         * python/py-unwind.c: Do not include py-ref.h.
5459         * python/py-utils.c: Do not include py-ref.h.
5460         * python/py-value.c: Do not include py-ref.h.
5461         * python/py-varobj.c: Do not include py-ref.h.
5462         * python/py-xmethods.c: Do not include py-ref.h.
5463         * python/python.c: Do not include py-ref.h.
5464         * varobj.c: Do not include py-ref.h.
5465
5466 2019-01-22  Tom Tromey  <tom@tromey.com>
5467
5468         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5469         keyword for bcache.
5470
5471 2019-01-22  Tom Tromey  <tom@tromey.com>
5472
5473         * compile/compile-cplus-types.c: Remove a comment by #include.
5474
5475 2019-01-22  Tom Tromey  <tom@tromey.com>
5476
5477         * compile/gcc-c-plugin.h: Include compile-internal.h.
5478
5479 2019-01-22  Tom Tromey  <tom@tromey.com>
5480
5481         * stabsread.c (EXTERN): Do not define.
5482         (symnum, next_symbol_text_func, processing_gcc_compilation)
5483         (within_function, global_sym_chain, global_stabs)
5484         (previous_stab_code, this_object_header_files)
5485         (n_this_object_header_files)
5486         (n_allocated_this_object_header_files): Define.
5487         * stabsread.h (EXTERN): Never define.  Use "extern".
5488
5489 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5490
5491         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5492         history_value.
5493
5494 2019-01-21  Tom Tromey  <tom@tromey.com>
5495
5496         * ui-out.c: Fix includes.
5497         * tui/tui-source.c: Fix includes.
5498         * target.c: Fix includes.
5499         * remote.c: Fix includes.
5500         * regcache.c: Fix includes.
5501         * python/py-block.c: Fix includes.
5502         * printcmd.c: Fix includes.
5503         * or1k-tdep.c: Fix includes.
5504         * mi/mi-main.c: Fix includes.
5505         * m32r-tdep.c: Fix includes.
5506         * csky-tdep.c: Fix includes.
5507         * compile/compile-cplus-types.c: Fix includes.
5508         * cli/cli-interp.c: Fix includes.
5509
5510 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5511
5512         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5513         for padding.
5514
5515 2019-01-16  Tom Tromey  <tom@tromey.com>
5516
5517         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5518         earlier.
5519         (struct objfile) <msymbols_range>: Move from top level.
5520         <msymbols>: New method.
5521         (class objfile_msymbols): Remove.
5522         * symtab.c (default_collect_symbol_completion_matches_break_on):
5523         Update.
5524         * symmisc.c (dump_msymbols): Update.
5525         * stabsread.c (scan_file_globals): Update.
5526         * objc-lang.c (info_selectors_command, info_classes_command)
5527         (find_methods): Update.
5528         * minsyms.c (find_solib_trampoline_target): Update.
5529         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5530         * coffread.c (coff_symfile_read): Update.
5531         * ada-lang.c (ada_lookup_simple_minsym)
5532         (ada_collect_symbol_completion_matches): Update.
5533
5534 2019-01-16  Tom Tromey  <tom@tromey.com>
5535
5536         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5537         type.  Remove no-argument constructor.
5538         <iterator::operator++>: Simplify.
5539         <begin>: Update.
5540         <end>: Use minimal_symbol_count.
5541
5542 2019-01-16  Tom Tromey  <tom@tromey.com>
5543
5544         * objfiles.h (struct objfile) <psymtabs>: New method.
5545         (class objfile_psymtabs): Remove.
5546         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5547         typedef.
5548         <range>: New method.
5549         (require_partial_symbols): Change return type.
5550         * psymtab.c (require_partial_symbols)
5551         (psym_expand_symtabs_matching): Update.
5552         * mdebugread.c (parse_partial_symbols): Update.
5553         * dbxread.c (dbx_end_psymtab): Update.
5554
5555 2019-01-15  Tom Tromey  <tom@tromey.com>
5556
5557         * symtab.c (lookup_objfile_from_block)
5558         (lookup_symbol_in_objfile_symtabs)
5559         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5560         (find_line_symtab, info_sources_command)
5561         (default_collect_symbol_completion_matches_break_on)
5562         (make_source_files_completion_list): Update.
5563         * symmisc.c (print_objfile_statistics, dump_objfile)
5564         (maintenance_print_symbols, maintenance_info_symtabs)
5565         (maintenance_check_symtabs, maintenance_info_line_tables):
5566         Update.
5567         * source.c (select_source_symtab)
5568         (forget_cached_source_info_for_objfile): Update.
5569         * objfiles.h (class objfile_compunits): Remove.
5570         (struct objfile) <compunits_range>: New typedef.
5571         (compunits): New method.
5572         * objfiles.c (objfile_relocate1): Update.
5573         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5574         * maint.c (count_symtabs_and_blocks): Update.
5575         * linespec.c (iterate_over_all_matching_symtabs): Update.
5576         * cp-support.c (add_symbol_overload_list_qualified): Update.
5577         * coffread.c (coff_symtab_read): Update.
5578         * ada-lang.c (add_nonlocal_symbols)
5579         (ada_collect_symbol_completion_matches)
5580         (ada_add_global_exceptions): Update.
5581
5582 2019-01-15  Tom Tromey  <tom@tromey.com>
5583
5584         * progspace.h (program_space) <objfiles_safe_range>: New
5585         typedef.
5586         <objfiles_safe>: New method.
5587         * objfiles.h (class all_objfiles_safe): Remove.
5588         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5589         * jit.c (jit_inferior_exit_hook): Update.
5590
5591 2019-01-17  Tom Tromey  <tom@tromey.com>
5592
5593         * progspace.h (program_space) <objfiles_range>: New typedef.
5594         <objfiles>: New method.
5595         <objfiles_head>: Rename from objfiles.
5596         (object_files): Update.
5597         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5598         * guile/scm-pretty-print.c
5599         (ppscm_find_pretty_printer_from_objfiles): Update.
5600         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5601         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5602         Update.
5603         * python/py-progspace.c (pspy_get_objfiles): Update.
5604         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5605         Update.
5606         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5607         (objfpy_lookup_objfile_by_build_id): Update.
5608         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5609         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5610         Update.
5611         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5612         (expand_symtab_containing_pc, lookup_objfile_from_block)
5613         (lookup_static_symbol, basic_lookup_transparent_type)
5614         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5615         (find_line_symtab, info_sources_command)
5616         (default_collect_symbol_completion_matches_break_on)
5617         (make_source_files_completion_list, find_main_name): Update.
5618         * symmisc.c (print_symbol_bcache_statistics)
5619         (print_objfile_statistics, maintenance_print_symbols)
5620         (maintenance_print_msymbols, maintenance_print_objfiles)
5621         (maintenance_info_symtabs, maintenance_check_symtabs)
5622         (maintenance_expand_symtabs, maintenance_info_line_tables):
5623         Update.
5624         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5625         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5626         (map_overlay_command, unmap_overlay_command)
5627         (simple_overlay_update, expand_symtabs_matching)
5628         (map_symbol_filenames): Update.
5629         * symfile-debug.c (set_debug_symfile): Update.
5630         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5631         Update.
5632         * source.c (select_source_symtab, forget_cached_source_info):
5633         Update.
5634         * solib.c (solib_read_symbols): Update.
5635         * solib-spu.c (append_ocl_sos): Update.
5636         * psymtab.c (maintenance_print_psymbols)
5637         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5638         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5639         * printcmd.c (info_symbol_command): Update.
5640         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5641         Update.
5642         * objfiles.h (class all_objfiles): Remove.
5643         * objfiles.c (have_partial_symbols, have_full_symbols)
5644         (have_minimal_symbols, qsort_cmp, update_section_map)
5645         (shared_objfile_contains_address_p)
5646         (default_iterate_over_objfiles_in_search_order): Update.
5647         * objc-lang.c (info_selectors_command, info_classes_command)
5648         (find_methods): Update.
5649         * minsyms.c (find_solib_trampoline_target): Update.
5650         * maint.c (maintenance_info_sections)
5651         (maintenance_translate_address, count_symtabs_and_blocks):
5652         Update.
5653         * main.c (captured_main_1): Update.
5654         * linux-thread-db.c (try_thread_db_load_from_pdir)
5655         (has_libpthread): Update.
5656         * linespec.c (iterate_over_all_matching_symtabs)
5657         (search_minsyms_for_name): Update.
5658         * jit.c (jit_find_objf_with_entry_addr): Update.
5659         * hppa-tdep.c (find_unwind_entry)
5660         (hppa_lookup_stub_minimal_symbol): Update.
5661         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5662         Update.
5663         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5664         (elf_gnu_ifunc_resolve_by_got): Update.
5665         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5666         * dwarf-index-write.c (save_gdb_index_command): Update.
5667         * cp-support.c (add_symbol_overload_list_qualified): Update.
5668         * breakpoint.c (create_overlay_event_breakpoint)
5669         (create_longjmp_master_breakpoint)
5670         (create_std_terminate_master_breakpoint)
5671         (create_exception_master_breakpoint): Update.
5672         * blockframe.c (find_pc_partial_function): Update.
5673         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5674         (ada_collect_symbol_completion_matches)
5675         (ada_add_global_exceptions): Update.
5676
5677 2019-01-17  Tom Tromey  <tom@tromey.com>
5678
5679         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5680         declare VEC.
5681         (solib_target_parse_libraries): Change return type.
5682         (library_list_start_segment, library_list_start_section)
5683         (library_list_end_library, library_list_start_library); Update.
5684         (solib_target_free_library_list): Remove.
5685         (solib_target_parse_libraries): Remove cleanup.  Change return
5686         type.
5687         (solib_target_current_sos): Update.
5688
5689 2019-01-17  Tom Tromey  <tromey@bapiya>
5690
5691         * valprint.c: Replace "the the" with "the".
5692         * symtab.c: Replace "the the" with "the".
5693         * solib.c: Replace "the the" with "the".
5694         * solib-dsbt.c: Replace "the the" with "the".
5695         * linespec.c: Replace "the the" with "the".
5696         * dwarf2loc.h: Replace "the the" with "the".
5697         * amd64-windows-tdep.c: Replace "the the" with "the".
5698         * aarch64-tdep.c: Replace "the the" with "the".
5699
5700 2019-01-16  Keith Seitz  <keiths@redhat.com>
5701
5702         PR gdb/23773
5703         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5704         <builder>: Rename to ..
5705         <m_builder>: ... this and make private.
5706         (dwarf2_cu::get_builder): New method.  Change all users of
5707         `builder' to use this method.
5708         (dwarf2_start_symtab): Move to ...
5709         (dwarf2_cu::start_symtab): ... here.  Update all callers
5710         (setup_type_unit_groups): Move to ...
5711         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5712         callers.
5713         (dwarf2_cu::reset_builder): New method.
5714         (process_full_compunit, process_full_type_unit): Use
5715         dwarf2_cu::reset_builder.
5716         (follow_die_offset): Record the ancestor CU if it is different
5717         from the followed DIE's CU.
5718         (follow_die_sig_1): Likewise.
5719
5720 2019-01-15  Tom Tromey  <tom@tromey.com>
5721
5722         * remote.c (class remote_state) <buf>: Now a char_vector.
5723         <buf_size>: Remove.
5724         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5725         parameter.
5726         (remote_target::getpkt_or_notif_sane_1)
5727         (remote_target::getpkt_sane)
5728         (remote_target::getpkt_or_notif_sane): Likewise.
5729         (class remote_target) <putpkt>: New overload.
5730         (remote_target::read_frame): Change type of "buf_p".  Remove
5731         sizeof_p parameter.
5732         (packet_ok): New overload.
5733         (packet_check_result): New overload.
5734         Update all uses.
5735
5736 2019-01-14  Tom Tromey  <tom@tromey.com>
5737
5738         * remote-notif.c (handle_notification, remote_notif_ack)
5739         (remote_notif_parse): Make "buf" const.
5740         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5741         const.
5742         (remote_notif_parse, remote_notif_ack, handle_notification):
5743         Likewise.
5744         * remote.c (remote_notif_stop_parse): Make "buf" const.
5745         (remote_target::remote_parse_stop_reply): Make "buf" const.
5746         (remote_notif_stop_ack): Make "buf" const.
5747
5748 2019-01-14  Tom Tromey  <tom@tromey.com>
5749
5750         * remote.c (remote_console_output): Make parameter const.
5751
5752 2019-01-14  Tom Tromey  <tom@tromey.com>
5753
5754         * target-debug.h (target_debug_print_signals): Constify.
5755         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5756         * procfs.c (procfs_target::pass_signals): Update.
5757         * linux-nat.c (linux_nat_target::pass_signals): Update.
5758         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5759         * target-delegates.c: Rebuild.
5760         * remote.c (remote_target::program_signals): Update.
5761         (remote_target::pass_signals): Update.
5762         * target.c (target_pass_signals): Constify argument.
5763         (target_program_signals): Likewise.
5764         * target.h (struct target_ops) <pass_signals, program_signals>:
5765         Constify argument.
5766         (target_pass_signals, target_program_signals): Constify argument.
5767
5768 2019-01-14  Tom Tromey  <tom@tromey.com>
5769
5770         PR tui/28819:
5771         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5772
5773 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5774
5775         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5776         field.
5777         * rs6000-tdep.c: Include reggroups.h.
5778         (IS_V_ALIAS_PSEUDOREG): Define.
5779         (rs6000_register_name): Return names for the "vX" aliases.
5780         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5781         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5782         aliases.  Call default_register_reggroup_p for all other
5783         pseudo-registers.
5784         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5785         New functions.
5786         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5787         Handle "vX" aliases.
5788         (v_alias_pseudo_register_collect): New function.
5789         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5790         (rs6000_gdbarch_init): Initialize "vX" aliases as
5791         pseudo-registers.  Restore registration of
5792         rs6000_pseudo_register_reggroup_p with
5793         set_tdesc_pseudo_register_reggroup_p.
5794
5795 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5796
5797         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5798         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5799         set_gdbarch_num_pseudo_regs.
5800
5801 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5802
5803         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5804         Remove arg prefixname, add do_set and do_show.
5805         Add member functions set_list and show_list.
5806         * cli/cli-style.c (class cli_style_option): Update accordingly.
5807         (style_set_list): Move to file scope.
5808         (style_show_list): Likewise.
5809         (set_style): Call help_list.
5810         (show_style): Call cmd_show_list.
5811         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5812         Update to use the new macro.
5813
5814 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5815
5816         * ada-lang.c (_initialize_ada_language): Expand the help text
5817         for the "catch exception" command.
5818
5819 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5820
5821         * symtab.c (matching_obj_sections): Initialize obj,
5822         declare it closer to its usage.
5823
5824 2019-01-10  Tom Tromey  <tom@tromey.com>
5825
5826         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5827         (basic_inf_threads_range): Remove.
5828         (inf_threads_range, inf_non_exited_threads_range)
5829         (safe_inf_threads_range): Use next_adapter.
5830
5831 2019-01-10  Keith Seitz  <keiths@redhat.com>
5832
5833         PR gdb/23712
5834         PR symtab/23010
5835         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5836         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5837
5838 2019-01-10  Keith Seitz  <keiths@redhat.com>
5839
5840         PR gdb/23712
5841         PR symtab/23010
5842         * dictionary.c (pending_to_vector): Remove.
5843         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5844         Remove _1 suffix, replacing functions of the same name.  Update
5845         all callers.
5846         (dict_create_hashed, dict_create_hashed_expandable)
5847         (dict_create_linear, dict_create_linear_expandable, dict_free)
5848         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5849         Make functions static.
5850
5851 2019-01-10  Keith Seitz  <keiths@redhat.com>
5852
5853         PR gdb/23712
5854         PR symtab/23010
5855         * dictionary.h (struct dictionary): Replace declaration with
5856         multidictionary.
5857         (dict_create_hashed, dict_create_hashed_expandable)
5858         (dict_create_linear, dict_create_linear_expandable)
5859         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5860         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5861         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5862         taking multidictionary argument.
5863         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5864         * block.h (struct block) <dict>: Change to multidictionary
5865         and rename `multidict'.
5866         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5867         symmisc.c: Update all dictionary references to multidictionary.
5868
5869 2019-01-10  Keith Seitz  <keiths@redhat.com>
5870
5871         PR gdb/23712
5872         PR symtab/23010
5873         * dictionary.c: Include unordered_map.
5874         (pending_to_vector): New function.
5875         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5876         Rewrite the non-"_1" functions to take vector instead
5877         of linked list.
5878         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5879         "new" _1 versions of the same name.
5880         (multidictionary): Define.
5881         (std::hash<enum language): New definition.
5882         (collate_pending_symbols_by_language, mdict_create_hashed)
5883         (mdict_create_hashed_expandable, mdict_create_linear)
5884         (mdict_create_linear_expandable, mdict_free)
5885         (find_language_dictionary, create_new_language_dictionary)
5886         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5887         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5888         (mdict_size, mdict_empty): New functions.
5889         * dictionary.h (mdict_iterator): Define.
5890
5891 2019-01-10  Pedro Alves  <palves@redhat.com>
5892
5893         * breakpoint.c (read_uploaded_action)
5894         (create_tracepoint_from_upload): Adjust to use
5895         gdb::unique_xmalloc_ptr.
5896         * ctf.c (ctf_write_uploaded_tp):
5897         (SET_ARRAY_FIELD): Use emplace_back.
5898         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5899         * tracefile-tfile.c (tfile_write_uploaded_tp):
5900         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5901         gdb::unique_xmalloc_ptr.
5902         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5903         at_string, cond_string, cmd_strings>: Replace char pointers
5904         with gdb::unique_xmalloc_ptr.
5905
5906 2019-01-10  Pedro Alves  <palves@redhat.com>
5907
5908         * solib-target.c (library_list_start_library): Don't xstrdup name.
5909
5910 2019-01-10  Pedro Alves  <palves@redhat.com>
5911
5912         * mdebugread.c (parse_partial_symbols): Use
5913         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5914
5915 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5916
5917         * linux-fork.c (scoped_switch_fork_info)
5918         <~scoped_switch_fork_info>: Fix incorrect variable name.
5919
5920 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * linux-fork.c (scoped_switch_fork_info)
5923         <scoped_switch_fork_info>: Make explicit.
5924         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5925
5926 2019-01-10  Tom Tromey  <tom@tromey.com>
5927
5928         * objfiles.h (objfile::reset_psymtabs): Update.
5929         * objfiles.c (objfile::objfile): Update.
5930         * psymtab.h (psymtab_storage::obstack): Update.
5931         (psymtab_storage::m_obstack): Use gdb::optional.
5932         (class psymtab_storage): Update comment.  Remove objfile
5933         parameter.
5934         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5935
5936 2019-01-10  Tom Tromey  <tom@tromey.com>
5937
5938         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5939         <free_psymtabs>: Now private.
5940         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5941         (allocate_psymtab): Use new method.
5942
5943 2019-01-10  Tom Tromey  <tom@tromey.com>
5944
5945         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5946         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5947         * mdebugread.c (parse_partial_symbols): Use
5948         allocate_dependencies.
5949         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5950         allocate_dependencies.
5951         (process_psymtab_comp_unit_reader)
5952         (build_type_psymtab_dependencies): Likewise.
5953         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5954
5955 2019-01-10  Tom Tromey  <tom@tromey.com>
5956
5957         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5958         PSYMBOL_SET_LANGUAGE.
5959         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5960
5961 2019-01-10  Tom Tromey  <tom@tromey.com>
5962
5963         * psymtab.h (psymtab_storage::obstack): New method.
5964         <m_obstack>: Rename from obstack; now private.
5965         * psymtab.c (psymtab_storage): Update.
5966         * dwarf2read.c (create_addrmap_from_index)
5967         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5968         Update.
5969
5970 2019-01-10  Tom Tromey  <tom@tromey.com>
5971
5972         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5973         * objfiles.h (objfile::reset_psymtabs): New method.
5974
5975 2019-01-10  Tom Tromey  <tom@tromey.com>
5976
5977         * symmisc.c (print_symbol_bcache_statistics): Update.
5978         (print_objfile_statistics): Update.
5979         * symfile.c (reread_symbols): Update.
5980         * psymtab.h (class psymtab_storage): New.
5981         * psymtab.c (psymtab_storage): New constructor.
5982         (~psymtab_storage): New destructor.
5983         (require_partial_symbols): Update.
5984         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5985         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5986         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5987         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5988         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5989         (start_psymtab_common, end_psymtab_common)
5990         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5991         (allocate_psymtab): Update.
5992         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5993         Update.
5994         (dump_psymtab_addrmap, maintenance_print_psymbols)
5995         (maintenance_check_psymtabs): Update.
5996         (class objfile_psymtabs): Move to objfiles.h.
5997         * psympriv.h (discard_psymtab): Now inline.
5998         (psymtab_discarder::psymtab_discarder): Update.
5999         (psymtab_discarder::~psymtab_discarder): Update.
6000         (ALL_OBJFILE_PSYMTABS): Rewrite.
6001         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6002         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6003         Remove fields.
6004         <partial_symtabs>: New field.
6005         (class objfile_psymtabs): Move from psymtab.h.  Update.
6006         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6007         psymbol_cache.
6008         (objfile::~objfile): Don't destroy psymbol_cache.
6009         * mdebugread.c (parse_partial_symbols): Update.
6010         * dwarf2read.c (create_addrmap_from_index)
6011         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6012         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6013         (add_partial_subprogram, dwarf2_ranges_read): Update.
6014         * dwarf-index-write.c (write_address_map)
6015         (write_one_signatured_type, recursively_write_psymbols)
6016         (class debug_names, class debug_names, write_psymtabs_to_index):
6017         Update.
6018
6019 2019-01-10  Tom Tromey  <tom@tromey.com>
6020
6021         * symtab.h (SYMBOL_SET_NAMES): Update.
6022         (symbol_set_names): Update.
6023         (MSYMBOL_SET_NAMES): Update.
6024         * symtab.c (symbol_set_names): Change argument to be an
6025         objfile_per_bfd_storage.
6026         * psymtab.c (add_psymbol_to_bcache): Update.
6027         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6028
6029 2019-01-10  Tom Tromey  <tom@tromey.com>
6030
6031         * symtab.c (create_demangled_names_hash): Change argument to be an
6032         objfile_per_bfd_storage.
6033         (symbol_set_names): Update.
6034
6035 2019-01-10  Tom Tromey  <tom@tromey.com>
6036
6037         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6038         init_psymbol_list.
6039         * psymtab.c (init_psymbol_list): Do nothing if already called.
6040         * psympriv.h (init_psymbol_list): Add comment.
6041         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6042         init_psymbol_list.
6043         * dbxread.c (dbx_symfile_read): Unconditionally call
6044         init_psymbol_list.
6045
6046 2019-01-10  Tom Tromey  <tom@tromey.com>
6047
6048         * xcoffread.c (scan_xcoff_symtab): Update.
6049         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6050         "where".
6051         * mdebugread.c (parse_partial_symbols)
6052         (handle_psymbol_enumerators): Update.
6053         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6054         * dbxread.c (read_dbx_symtab): Update.
6055         * psympriv.h (psymbol_placement): New enum.
6056         (add_psymbol_to_list): Update.
6057
6058 2019-01-10  Tom Tromey  <tom@tromey.com>
6059
6060         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6061         static_psymbols parameters.
6062         (scan_xcoff_symtab): Update.
6063         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6064         static_psymbols parameters.
6065         * psympriv.h (start_psymtab_common): Update.
6066         * mdebugread.c (parse_partial_symbols): Update.
6067         * dwarf2read.c (create_partial_symtab): Update.
6068         * dbxread.c (read_dbx_symtab): Update.
6069         (start_psymtab): Remove global_psymbols and static_psymbols
6070         parameters.
6071
6072 2019-01-10  Tom Tromey  <tom@tromey.com>
6073
6074         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6075         * psymtab.c (allocate_psymtab): Add comment.
6076         * psympriv.h (allocate_psymtab): Add comment.
6077         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6078         initializations.
6079         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6080
6081 2019-01-10  Tom Tromey  <tom@tromey.com>
6082
6083         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6084         Don't declare.
6085         * mipsread.c: Include mdebugread.h.
6086         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6087         Declare.
6088         * elfread.c: Include mdebugread.h.
6089
6090 2019-01-09  Tom Tromey  <tom@tromey.com>
6091
6092         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6093         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6094         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6095         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6096         (psym_lookup_symbol, psym_find_last_source_symtab)
6097         (psym_forget_cached_source_info, psym_print_stats)
6098         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6099         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6100         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6101         (psym_find_compunit_symtab_by_address)
6102         (maintenance_print_psymbols, maintenance_info_psymtabs)
6103         (maintenance_check_psymtabs): Use ranged for.
6104         * psymtab.h (class objfile_psymtabs): New.
6105         (require_partial_symbols): Return objfile_psymtabs.
6106         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6107
6108 2019-01-09  Tom Tromey  <tom@tromey.com>
6109
6110         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6111         (find_pc_mapped_section, list_overlays_command)
6112         (map_overlay_command, unmap_overlay_command)
6113         (simple_overlay_update): Use all_objfiles.
6114         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6115         * printcmd.c (info_symbol_command): Use all_objfiles.
6116         * objfiles.h (ALL_OBJSECTIONS): Remove.
6117         * maint.c (maintenance_translate_address): Use all_objfiles.
6118         * gcore.c (gcore_create_callback): Use all_objfiles.
6119         (objfile_find_memory_regions): Likewise.
6120
6121 2019-01-09  Tom Tromey  <tom@tromey.com>
6122
6123         * symtab.c (find_line_symtab, info_sources_command)
6124         (make_source_files_completion_list): Use objfile_compunits.
6125         * source.c (select_source_symtab): Use objfile_compunits.
6126         * objfiles.h (struct objfile): Update comment.
6127         (ALL_OBJFILES): Remove.
6128         (ALL_FILETABS): Remove.
6129         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6130         objfile_compunits.
6131
6132 2019-01-09  Tom Tromey  <tom@tromey.com>
6133
6134         * symmisc.c (print_objfile_statistics, dump_objfile)
6135         (maintenance_print_symbols): Use compunit_filetabs.
6136         * source.c (forget_cached_source_info_for_objfile): Use
6137         compunit_filetabs.
6138         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6139         (ALL_FILETABS): Use compunit_filetabs.
6140         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6141         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6142
6143 2019-01-09  Tom Tromey  <tom@tromey.com>
6144
6145         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6146         (compunit_filetabs): New.
6147         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6148         compunit_filetabs.
6149         (info_sources_command, make_source_files_completion_list): Remove
6150         declaration.
6151         * symmisc.c (print_objfile_statistics, dump_objfile)
6152         (maintenance_print_symbols): Remove declaration.
6153         (maintenance_info_symtabs): Use compunit_filetabs.
6154         (maintenance_info_line_tables): Likewise.
6155         * source.c (select_source_symtab): Change local variable name.
6156         (forget_cached_source_info_for_objfile): Remove declaration.
6157         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6158         * objfiles.c (objfile_relocate1): Remove declaration.
6159         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6160         declaration.
6161         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6162         * coffread.c (coff_symtab_read): Remove declaration.
6163         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6164         compunit_filetabs.
6165
6166 2019-01-09  Tom Tromey  <tom@tromey.com>
6167
6168         * symtab.c (lookup_objfile_from_block)
6169         (find_pc_sect_compunit_symtab, search_symbols)
6170         (default_collect_symbol_completion_matches_break_on): Use
6171         objfile_compunits.
6172         * objfiles.h (ALL_COMPUNITS): Remove.
6173         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6174         * cp-support.c (add_symbol_overload_list_qualified): Use
6175         objfile_compunits.
6176         * ada-lang.c (ada_collect_symbol_completion_matches)
6177         (ada_add_global_exceptions): Use objfile_compunits.
6178
6179 2019-01-09  Tom Tromey  <tom@tromey.com>
6180
6181         * source.c (select_source_symtab)
6182         (forget_cached_source_info_for_objfile): Remove declaration.
6183         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6184         declaration.
6185         * maint.c (count_symtabs_and_blocks): Remove declaration.
6186         * cp-support.c (add_symbol_overload_list_qualified): Remove
6187         declaration.
6188         * coffread.c (coff_symtab_read): Remove declaration.
6189         * symtab.c (lookup_symbol_in_objfile_symtabs)
6190         (basic_lookup_transparent_type_1): Use objfile_compunits.
6191         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6192         (info_sources_command, search_symbols)
6193         (default_collect_symbol_completion_matches_break_on)
6194         (make_source_files_completion_list): Remove declaration.
6195         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6196         (ada_collect_symbol_completion_matches)
6197         (ada_add_global_exceptions): Remove declaration.
6198         * linespec.c (iterate_over_all_matching_symtabs): Use
6199         objfile_compunits.
6200         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6201         (class objfile_compunits): New.
6202         (ALL_COMPUNITS): Use objfile_compunits.
6203         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6204         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6205         objfile_compunits.
6206         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6207
6208 2019-01-09  Tom Tromey  <tom@tromey.com>
6209
6210         * symtab.c (search_symbols)
6211         (default_collect_symbol_completion_matches_break_on): Use
6212         objfile_msymbols.
6213         * ada-lang.c (ada_lookup_simple_minsym)
6214         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6215         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6216         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6217         objfile_msymbols.
6218         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6219         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6220         * objc-lang.c (find_methods): Use objfile_msymbols.
6221         (info_selectors_command, info_classes_command): Likewise.
6222         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6223         * objfiles.h (class objfile_msymbols): New.
6224         (ALL_OBJFILE_MSYMBOLS): Remove.
6225         (ALL_MSYMBOLS): Remove.
6226
6227 2019-01-09  Tom Tromey  <tom@tromey.com>
6228
6229         * common/next-iterator.h (next_adapter): Add Iterator template
6230         parameter.
6231         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6232         (class all_objfiles_safe): New.
6233         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6234         * objfiles.c (put_objfile_before): Update comment.
6235         (add_separate_debug_objfile): Likewise.
6236         (free_all_objfiles): Use all_objfiles_safe.
6237         (objfile_purge_solibs): Likewise.
6238
6239 2019-01-09  Tom Tromey  <tom@tromey.com>
6240
6241         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6242         (expand_symtab_containing_pc, lookup_static_symbol)
6243         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6244         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6245         all_objfiles.
6246         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6247         * breakpoint.c (create_overlay_event_breakpoint)
6248         (create_longjmp_master_breakpoint)
6249         (create_std_terminate_master_breakpoint)
6250         (create_exception_master_breakpoint): Use all_objfiles.
6251         * linux-thread-db.c (try_thread_db_load_from_pdir)
6252         (has_libpthread): Use all_objfiles.
6253         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6254         * linespec.c (iterate_over_all_matching_symtabs)
6255         (search_minsyms_for_name): Use all_objfiles.
6256         * maint.c (maintenance_info_sections): Use all_objfiles.
6257         * main.c (captured_main_1): Use all_objfiles.
6258         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6259         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6260         * guile/scm-pretty-print.c
6261         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6262         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6263         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6264         (maintenance_print_msymbols): Use all_objfiles.
6265         * source.c (select_source_symtab): Use all_objfiles.
6266         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6267         * symfile.c (remove_symbol_file_command)
6268         (expand_symtabs_matching, map_symbol_filenames): Use
6269         all_objfiles.
6270         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6271         all_objfiles.
6272         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6273         * objc-lang.c (find_methods): Use all_objfiles.
6274         * objfiles.c (have_partial_symbols, have_full_symbols)
6275         (have_minimal_symbols, qsort_cmp)
6276         (default_iterate_over_objfiles_in_search_order): Use
6277         all_objfiles.
6278         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6279         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6280         (maintenance_check_psymtabs): Use all_objfiles.
6281         (ALL_PSYMTABS): Remove.
6282         * compile/compile-object-run.c (do_module_cleanup): Use
6283         all_objfiles.
6284         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6285         * cp-support.c (add_symbol_overload_list_qualified): Use
6286         all_objfiles.
6287         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6288         Use all_objfiles.
6289         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6290         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6291         all_objfiles.
6292         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6293         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6294         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6295         Uses all_objfiles.
6296         * solib.c (solib_read_symbols): Use all_objfiles
6297
6298 2019-01-09  Tom Tromey  <tom@tromey.com>
6299
6300         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6301         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6302         all_objfiles.
6303         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6304         * symmisc.c (print_symbol_bcache_statistics)
6305         (print_objfile_statistics, maintenance_print_objfiles)
6306         (maintenance_info_symtabs, maintenance_check_symtabs)
6307         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6308         all_objfiles.
6309         * source.c (forget_cached_source_info): Use all_objfiles.
6310         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6311         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6312         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6313         * objfiles.c (update_section_map): Use all_objfiles.
6314         (shared_objfile_contains_address_p): Likewise.
6315         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6316         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6317
6318 2019-01-09  Tom Tromey  <tom@tromey.com>
6319
6320         * common/next-iterator.h: New file.
6321         * objfiles.h (class all_objfiles): New.
6322         (struct objfile_iterator): New.
6323
6324 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6325
6326         * NEWS: Move the description of the changed "frame", "select-frame",
6327          and "info frame" commands to the Changed commands section.
6328
6329 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6330
6331         * gdbtypes.c (check_stub_method_group): Remove handling of old
6332         mangling schemes.
6333         * linespec.c (find_methods): Likewise.
6334         * stabsread.c (read_member_functions): Likewise.
6335         * valops.c (search_struct_method): Likewise.
6336         (value_struct_elt_for_reference): Likewise.
6337         * NEWS: Mention this change.
6338
6339 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6340
6341         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6342         print_source_lines.
6343         * source.c (print_source_lines_base): Update line number check.
6344         (print_source_lines): New function.
6345         (source_lines_range::source_lines_range): New function.
6346         * source.h (class source_lines_range): New class.
6347         (print_source_lines): New declaration.
6348
6349 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6350
6351         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6352
6353 2019-01-08  Tom Tromey  <tom@tromey.com>
6354             Simon Marchi  <simon.marchi@ericsson.com>
6355
6356         PR gdb/24060
6357         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6358         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6359         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6360         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6361         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6362         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6363
6364 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6365
6366         * source.c (select_source_symtab): Move header comment to
6367         declaration in source.h.
6368         (forget_cached_source_info_for_objfile): Likewise.
6369         (forget_cached_source_info): Likewise.
6370         (identify_source_line): Likewise.
6371         * source.h (identify_source_line): Move declaration from symtab.h
6372         and add comment from source.c
6373         (print_source_lines): Likewise.
6374         (forget_cached_source_info_for_objfile): Likewise.
6375         (forget_cached_source_info): Likewise.
6376         (select_source_symtab): Likewise.
6377         (enum print_source_lines_flag): Move definition from symtab.h.
6378         * symtab.h (identify_source_line): Move declaration to source.h.
6379         (print_source_lines): Likewise.
6380         (forget_cached_source_info_for_objfile): Likewise.
6381         (forget_cached_source_info): Likewise.
6382         (select_source_symtab): Likewise.
6383         (enum print_source_lines_flag): Move definition to source.h.
6384         * tui/tui-hooks.c: Add 'source.h' include.
6385
6386 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6387
6388         * source.c (print_source_lines_base): Handle requests to print
6389         reverse line number sequences, and guard against empty lines
6390         string.
6391
6392 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6393
6394         * source.c (print_source_lines_base): Fix skip of '\r' if next
6395         character is '\n'.
6396
6397 2019-01-06  Tom Tromey  <tom@tromey.com>
6398
6399         * c-exp.y (struct c_parse_state) <macro_original_text,
6400         expansion_obstack>: New member.
6401         (macro_original_text, expansion_obstack): Remove globals.
6402         (scan_macro_expansion, scanning_macro_expansion)
6403         (finished_macro_expansion): Update.
6404         (scan_macro_cleanup): Remove.
6405         (yylex, c_parse): Update.
6406
6407 2019-01-06  Tom Tromey  <tom@tromey.com>
6408
6409         * c-exp.y (struct c_parse_state) <strings>: New member.
6410         (operator_stoken): Update.
6411
6412 2019-01-06  Tom Tromey  <tom@tromey.com>
6413
6414         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6415         (union type_stack_elt) <typelist_val>: Now a pointer to
6416         std::vector.
6417         (type_stack_cleanup): Don't declare.
6418         (push_typelist): Update.
6419         * parse.c (pop_typelist): Return a std::vector.
6420         (push_typelist): Take a std::vector.
6421         (follow_types): Update.  Do not free args.
6422         (type_stack_cleanup): Remove.
6423         * c-exp.y (struct c_parse_state): New.
6424         (cpstate): New global.
6425         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6426         (nonempty_typelist): Update.
6427         (func_mod): Create a new vector.
6428         (c_parse): Create a c_parse_state.
6429         (check_parameter_typelist): Do not delete params.
6430         (function_method): Update.  Do not delete type_list.
6431
6432 2019-01-06  Tom Tromey  <tom@tromey.com>
6433
6434         PR gdb/28155:
6435         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6436         check_typedef.
6437         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6438         (print_return_value): Likewise.
6439
6440 2019-01-05  Tom Tromey  <tom@tromey.com>
6441
6442         * contrib/cleanup_check.py: Remove.
6443         * contrib/gcc-with-excheck: Remove.
6444         * contrib/exsummary.py: Remove.
6445         * contrib/excheck.py: Remove.
6446
6447 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6448
6449         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6450         NULL. Initialize tpprev to NULL instead of assigning it
6451         to NULL on the next statement.
6452         * windows-nat.c (windows_delete_thread): Remove check for
6453         main_thread_id before printing thread exit notifications.
6454         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6455         Remove thread ID check against main_thread_id.
6456         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6457         windows_delete_thread.
6458         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6459
6460 2019-01-04  Tom Tromey  <tom@tromey.com>
6461
6462         * compile/compile.c (_initialize_compile): Use upper case for
6463         metasyntactic variables.
6464         * symmisc.c (_initialize_symmisc): Use upper case for
6465         metasyntactic variables.
6466         * psymtab.c (_initialize_psymtab): Use upper case for
6467         metasyntactic variables.
6468         * demangle.c (demangle_command): Use upper case for metasyntactic
6469         variables.
6470         (_initialize_demangler): Likewise.
6471         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6472         variables.
6473
6474 2019-01-03  Tom Tromey  <tom@tromey.com>
6475
6476         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6477
6478 2019-01-03  Tom Tromey  <tom@tromey.com>
6479
6480         * python/py-symtab.c (salpy_str): Update.
6481         (struct salpy_sal_object) <symtab>: Now a PyObject.
6482         (salpy_dealloc): Update.
6483         (del_objfile_sal): Use gdbpy_ref.
6484
6485 2019-01-03  Tom Tromey  <tom@tromey.com>
6486
6487         * python/py-type.c (convert_field): Use new_reference.  Return
6488         gdbpy_ref.
6489         (make_fielditem): Return gdbpy_ref.
6490         (typy_fields): Update.
6491         (typy_getitem): Update.
6492         (field_name): Return gdbpy_ref.  Use new_reference.
6493         (typy_iterator_iternext): Update.
6494
6495 2019-01-03  Tom Tromey  <tom@tromey.com>
6496
6497         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6498
6499 2019-01-03  Tom Tromey  <tom@tromey.com>
6500
6501         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6502         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6503         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6504         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6505         (pspy_set_type_printers): Likewise.
6506         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6507         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6508         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6509         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6510         (objfpy_set_type_printers): Likewise.
6511
6512 2019-01-03  Tom Tromey  <tom@tromey.com>
6513
6514         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6515         (gdbpy_print_stack): Use gdbpy_err_fetch.
6516         * python/python-internal.h (class gdbpy_err_fetch): New class.
6517         (class gdbpy_enter) <m_error_type, m_error_value,
6518         m_error_traceback>: Remove.
6519         <m_error>: New member.
6520         (gdbpy_exception_to_string): Don't declare.
6521         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6522         * python/py-value.c (convert_value_from_python): Use
6523         gdbpy_err_fetch.
6524         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6525         gdbpy_exception_to_string.
6526         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6527         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6528         gdbpy_err_fetch.
6529
6530 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6531
6532         * linux-nat.c (delete_lwp_cleanup): Delete.
6533         (struct lwp_deleter): New struct.
6534         (lwp_info_up): New typedef.
6535         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6536         lwp_info_up.
6537
6538 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6539
6540         * linux-fork.c (class scoped_switch_fork_info): New class.
6541         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6542
6543 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6544
6545         * valops.c (find_overload_match): Remove use of null_cleanup, and
6546         calls to do_cleanups.
6547
6548 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6549
6550         * compile/compile-cplus-types.c
6551         (compile_cplus_instance::decl_name): Handle changes to
6552         cp_func_name.
6553         * cp-support.c (cp_func_name): Update header comment, update
6554         return type.
6555         * cp-support.h (cp_func_name): Update return type in declaration.
6556         * valops.c (find_overload_match): Move temp_func local to top
6557         level of function and change its type.  Use temp_func to hold and
6558         delete temporary string obtained from cp_func_name.
6559
6560 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6561
6562         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6563         gdb::char_vector, remove cleanup, and update uses of `msg`.
6564
6565 2019-01-03  Jim Wilson  <jimw@sifive.com>
6566
6567         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6568
6569 2019-01-02  Tom Tromey  <tom@tromey.com>
6570
6571         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6572         (tdesc_parse_xml): Remove cleanups.
6573         * target-descriptions.h (make_cleanup_free_target_description):
6574         Don't declare.
6575         (target_desc_deleter): New struct.
6576         (target_desc_up): New typedef.
6577         * target-descriptions.c (target_desc_deleter::operator()): Rename
6578         from free_target_description.
6579         (make_cleanup_free_target_description): Remove.
6580
6581 2019-01-02  Tom Tromey  <tom@tromey.com>
6582
6583         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6584         constructor, destructor.
6585         (linespec_parser): Remove typedef.
6586         (~linespec_parser): Rename from linespec_parser_delete.
6587         (linespec_lex_to_end, linespec_complete_label)
6588         (linespec_complete): Update.
6589         (decode_line_full): Remove cleanups.
6590         (decode_line_1): Update.
6591
6592 2019-01-02  Tom Tromey  <tom@tromey.com>
6593
6594         * python/python-internal.h (inferior_to_inferior_object): Change
6595         return type.
6596         * python/py-exitedevent.c (create_exited_event_object): Update.
6597         * python/py-inferior.c (inferior_to_inferior_object): Return
6598         gdbpy_ref.
6599         (python_new_inferior, python_inferior_deleted)
6600         (thread_to_thread_object, delete_thread_object)
6601         (build_inferior_list, gdbpy_selected_inferior): Update.
6602         * python/py-infthread.c (create_thread_object): Update.  Also fail
6603         if inferior_to_inferior_object fails.
6604
6605 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6606
6607         * inferior.h (class inferior) <displaced_step_state>: New field.
6608         * infrun.h (struct displaced_step_state): Move here from
6609         infrun.c.  Initialize fields, add constructor.
6610         <inf>: Remove field.
6611         <reset>: New method.
6612         * infrun.c (struct displaced_step_inferior_state): Move to
6613         infrun.h.
6614         (displaced_step_inferior_states): Remove.
6615         (get_displaced_stepping_state): Adust.
6616         (displaced_step_in_progress_any_inferior): Adjust.
6617         (displaced_step_in_progress_thread): Adjust.
6618         (displaced_step_in_progress): Adjust.
6619         (add_displaced_stepping_state): Remove.
6620         (get_displaced_step_closure_by_addr): Adjust.
6621         (remove_displaced_stepping_state): Remove.
6622         (infrun_inferior_exit): Call displaced_step_state.reset.
6623         (use_displaced_stepping): Don't check for NULL.
6624         (displaced_step_prepare_throw): Call
6625         get_displaced_stepping_state.
6626         (displaced_step_fixup): Don't check for NULL.
6627         (prepare_for_detach): Don't check for NULL.
6628
6629 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6630
6631         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6632          in case of call that did not complete.
6633
6634 2019-01-02  Andrey Utkin  <autkin@undo.io>
6635
6636         * symfile.c (find_separate_debug_file): Fix search of debug files for
6637         remote debuggee.
6638
6639 2019-01-02  Tom Tromey  <tom@tromey.com>
6640
6641         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6642         indentation.
6643         * python/py-frame.c (frapy_older): Remove cast.
6644         (frapy_newer): Likewise.
6645         * python/py-breakpoint.c (local_setattro): Remove cast.
6646         * python/py-arch.c (archpy_name): Remove local variable.
6647         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6648
6649 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6650
6651         * unittests/basic_string_view/element_access/char/empty.cc:
6652         Fix year range in copyright header.
6653
6654 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6655
6656         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6657         Delete.
6658         <operator==>: Update with for removed field.
6659         <hash>: Likewise.
6660         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6661         <isa_features>: ...this.
6662         <abi_features>: New field.
6663         (riscv_isa_flen): Update comment.
6664         (riscv_abi_xlen): New declaration.
6665         (riscv_abi_flen): New declaration.
6666         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6667         isa_features.
6668         (riscv_abi_xlen): New function.
6669         (riscv_isa_flen): Update to get answer from isa_features.
6670         (riscv_abi_flen): New function.
6671         (riscv_has_fp_abi): Update to get answer from abi_features.
6672         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6673         xlen and flen.
6674         (riscv_call_info) <xlen, flen>: Update comment.
6675         (riscv_call_arg_struct): Remove invalid assertions
6676         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6677         is removed.
6678         (riscv_gdbarch_init): Gather isa features and abi features
6679         separately, ensure both match on the gdbarch when reusing an old
6680         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6681         a target with 64-bit float hardware.
6682
6683 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6684
6685         * source.c (search_command_helper): Stop reverse search
6686         when line 1 has been searched.
6687
6688 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6689
6690         * record-full.c (record_full_base_target::close): Rewrite
6691         record_full_core_buf_list free logic.
6692
6693 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6694
6695         * break-catch-syscall.c (print_one_catch_syscall): xfree
6696         the last text.
6697
6698 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6699
6700         * top.c (print_gdb_version): Update Copyright year in version
6701         message.
6702
6703 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6704
6705         Update copyright year range in all GDB files.
6706
6707 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6708
6709         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6710
6711 For older changes see ChangeLog-2018.
6712 \f
6713 Local Variables:
6714 mode: change-log
6715 left-margin: 8
6716 fill-column: 74
6717 version-control: never
6718 coding: utf-8
6719 End:
6720