gdb/ChangeLog

   1 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * ada-exp.y (write_object_remaining): Update.
   4         * ada-lang.c (ada_decode): Return a std::string instead of a char*
   5         and eliminate the static buffer.
   6         (ada_decode_symbol): Update.
   7         (ada_la_decode): Update.
   8         (ada_sniff_from_mangled_name): Update.
   9         (is_valid_name_for_wild_match): Update.
  10         (ada_lookup_name_info::matches): Update and simplify.
  11         (name_matches_regex): Update.
  12         (ada_add_global_exceptions): Update.
  13         * ada-lang.h (ada_decode): Update signature.
  14         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
  15         * dwarf-index-write.c (debug_names::insert): Update.
  16
  17 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
  18
  19         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
  20         formatting.
  21
  22 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
  23
  24         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
  25         Change "nonzero" to "true" in documentation.
  26
  27 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
  28
  29         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
  30         (_initialize_darwin_solib): Don't set
  31         darwin_so_ops.lookup_lib_global_symbol.
  32         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
  33         set_gdbarch_iterate_over_objfiles_in_search_order.
  34         (elf_lookup_lib_symbol): Rename to...
  35         (svr4_iterate_over_objfiles_in_search_order): this, and update
  36         to iterate semantics.
  37         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
  38         * solib.c (solib_global_lookup): Remove.
  39         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
  40         (solib_global_lookup): Remove.
  41         * symtab.c (lookup_global_or_static_symbol): Remove call to
  42         solib_global_lookup.
  43
  44 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
  45
  46         * NEWS: Move entries about default MI version now being
  47         version 3, and about the GDB/MI fix for multi-location
  48         breakpoints to the "since GDB 8.3" section.
  49
  50 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
  51
  52         GDB 8.3.1 released.
  53
  54 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
  55
  56         * NEWS: Mention that Cell/B.E. debugging support was removed.
  57         * MAINTAINERS: Remove spu target.
  58
  59         * config/djgpp/fnchange.lst: Remove entries for removed files.
  60
  61         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
  62         spu-multiarch.o, and spu-tdep.o.
  63         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
  64         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
  65         spu-multiarch.c, and spu-tdep.c.
  66         * spu-linux-nat.c: Remove file.
  67         * spu-multiarch.c: Remove file.
  68         * spu-tdep.c: Remove file.
  69         * spu-tdep.h: Remove file.
  70         * solib-spu.c: Remove file.
  71         * solib-spu.h: Remove file.
  72
  73         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
  74         * configure.nat (spu-linux): Remove.
  75         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
  76         solib-multiarch.o from gdb_target_obs.
  77         (spu*-*-*): Remove.
  78
  79         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
  80         feature flag.
  81         (ppc_linux_no_features): Update.
  82         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
  83         Cell/B.E. support.
  84         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
  85         (tdesc_powerpc_cell64l): Likewise.
  86         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
  87         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
  88         Cell/B.E. support.
  89         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
  90         Do not include "features/rs6000/powerpc-cell32l.c" or
  91         "features/rs6000/powerpc-cell64l.c".
  92         (ppc_linux_spu_section): Remove.
  93         (ppc_linux_core_read_description): Remove Cell/B.E. support.
  94         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
  95         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
  96         (ppc_linux_spe_context_lookup): Remove.
  97         (ppc_linux_spe_context_inferior_created): Remove.
  98         (ppc_linux_spe_context_solib_loaded): Remove.
  99         (ppc_linux_spe_context_solib_unloaded): Remove.
 100         (ppc_linux_spe_context): Remove.
 101         (struct ppu2spu_cache): Remove.
 102         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 103         (struct ppu2spu_data): Remove.
 104         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 105         ppu2spu_unwind): Remove.
 106         (ppc_linux_init_abi): Remove Cell/B.E. support.
 107         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 108
 109         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 110         (rs6000/powerpc-cell64l-expedite): Likewise
 111         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 112         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 113         rs6000/powerpc-cell64l.xml.
 114         * features/rs6000/powerpc-cell32l.xml: Remove.
 115         * features/rs6000/powerpc-cell64l.xml: Likewise.
 116         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 117         * features/rs6000/powerpc-cell64l.c: Likewise.
 118         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 119         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 120         * regformats/reg-spu.dat: Remove.
 121
 122         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 123         * corelow.c (struct spuid_list): Remove.
 124         (add_to_spuid_list): Remove.
 125         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 126         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 127         (remote_protocol_features): Remove associated entries.
 128         (_initialize_remote): No longer initialize them.
 129         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 130         * linux-nat.c (SPUFS_MAGIC): Remove.
 131         (linux_proc_xfer_spu): Remove.
 132         (spu_enumerate_spu_ids): Remove.
 133         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 134         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 135         (linux_make_corefile_notes): No longer call it.
 136
 137         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 138         (cooked_write_test): Likewise.
 139
 140 2019-09-20  Tom Tromey  <tom@tromey.com>
 141
 142         * NEWS: Mention case-sensitivity of TUI commands.
 143         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 144         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 145         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 146
 147 2019-09-20  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-source.c (tui_source_window::set_contents): Use
 150         make_unique_xstrdup.
 151         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 152         make_unique_xstrdup.
 153
 154 2019-09-20  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-data.c: Remove separator comments.
 157         * tui/tui-layout.c: Remove separator comments.
 158         * tui/tui-win.c: Remove separator comments.
 159         * tui/tui-wingeneral.c: Remove separator comments.
 160
 161 2019-09-20  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui.h (strcat_to_buf): Don't declare.
 164         * tui/tui.c (strcat_to_buf): Remove.
 165
 166 2019-09-20  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 169         from "fullname".
 170         * tui/tui-source.c (tui_source_window::set_contents)
 171         (tui_source_window::location_matches_p)
 172         (tui_source_window::maybe_update): Update.
 173
 174 2019-09-20  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 177         Update.
 178         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 179         prefix.
 180         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 181         (tui_data_window::line_from_reg_element_no)
 182         (tui_data_window::first_reg_element_no_inline)
 183         (tui_data_window::show_registers)
 184         (tui_data_window::show_register_group)
 185         (tui_data_window::display_registers_from)
 186         (tui_data_window::display_registers_from_line)
 187         (tui_data_window::first_data_item_displayed)
 188         (tui_data_window::delete_data_content_windows)
 189         (tui_data_window::erase_data_content)
 190         (tui_data_window::do_scroll_vertical)
 191         (tui_data_window::refresh_window)
 192         (tui_data_window::check_register_values): Update.
 193
 194 2019-09-20  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 197         (struct tui_locator_window) <full_name, proc_name>: Now
 198         std::string.
 199         * tui/tui-stack.c (tui_locator_window::make_status_line)
 200         (tui_locator_window::set_locator_fullname)
 201         (tui_locator_window::set_locator_info): Update.
 202         * tui/tui-source.c (tui_source_window::set_contents)
 203         (tui_source_window::showing_source_p): Update.
 204
 205 2019-09-20  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 208         Don't call tui_locator_win_info_ptr.
 209
 210 2019-09-20  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 213
 214 2019-09-20  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 217         height for locator.
 218         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 219         * tui/tui-layout.c (show_source_disasm_command, show_data)
 220         (show_source_or_disasm_and_command): Use 1 as height for locator.
 221
 222 2019-09-20  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui.c (tui_enable): Update.
 225         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 226         Update.
 227         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 228         Update.
 229         * tui/tui-data.c (win_resized): Now bool.
 230         (tui_win_resized): Return bool.
 231         (tui_set_win_resized_to): Accept a bool.
 232
 233 2019-09-20  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 236         Change type of "refresh_values_only".
 237         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 238         type of "refresh_values_only".
 239
 240 2019-09-20  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 243         std::string.
 244         (tui_disassemble): Add "pos" parameter.
 245         (tui_disasm_window::set_contents): Simplify.
 246
 247 2019-09-20  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-winsource.h (struct tui_source_window_base)
 250         <show_source_content>: Now private.
 251         * tui/tui-winsource.c
 252         (tui_source_window_base::show_source_content): Don't handle empty
 253         content case.
 254
 255 2019-09-20  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-layout.c (show_source_disasm_command)
 258         (show_source_or_disasm_and_command): Don't call
 259         show_source_content.
 260
 261 2019-09-20  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 264         Declare.
 265         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 266         from tui_make_status_line.
 267         (tui_locator_window::rerender): Update.
 268
 269 2019-09-20  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 272         (tui_locator_window::rerender): Update.
 273
 274 2019-09-20  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-winsource.h (struct tui_source_window_base)
 277         <~tui_source_window_base>: Don't declare.
 278         <fullname>: Remove.
 279         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 280         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 281         member.
 282         * tui/tui-source.c (tui_source_window::set_contents): Update.
 283         (tui_source_window::location_matches_p)
 284         (tui_source_window::maybe_update): Update.
 285
 286 2019-09-20  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-winsource.h (~tui_source_element): Remove.
 289         (tui_source_element): Update.
 290         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 291         * tui/tui-winsource.c (tui_show_source_line): Update.
 292         * tui/tui-source.c (tui_source_window::set_contents): Update.
 293         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 294
 295 2019-09-20  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 298         declare.
 299         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 300         tui_clear_source_windows_detail.
 301         * tui/tui-winsource.h (struct tui_source_window_base)
 302         <clear_detail>: Don't declare.
 303         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 304         Remove.
 305         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 306
 307 2019-09-20  Tom Tromey  <tromey@adacore.com>
 308
 309         PR ada/24919:
 310         * block.c (contained_in): Fix final return value.
 311
 312 2019-09-20  Alan Modra  <amodra@gmail.com>
 313
 314         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 315         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 316         (read_indirect_string_from_dwz): Use bfd accessor.
 317         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 318         * machoread.c (macho_symfile_read_all_oso): Likewise.
 319         * solib.c (solib_bfd_open): Likewise.
 320
 321 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 322
 323         * eval.c: Move declaration of overload_resolution to...
 324         * value.h: ...here.
 325
 326 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 327
 328         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 329         * arm-linux-tdep.c: Likewise.
 330         * arm-nbsd-nat.c: Likewise.
 331         * arm-tdep.h: Declare arm_apcs_32.
 332         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 333
 334 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 335
 336         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 337         * dwarf2read.h: Declare dwarf_always_disassemble.
 338
 339 2019-09-19  Tom de Vries  <tdevries@suse.de>
 340
 341         PR gdb/25009
 342         * source-cache.c (source_cache::ensure): Catch exception thrown during
 343         construction of the highlighter.
 344
 345 2019-09-18  Alan Modra  <amodra@gmail.com>
 346
 347         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 348         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 349         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 350         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 351         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 352         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 353         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 354         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 355         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 356         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 357         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 358         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 359         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 360         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 361         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 362         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 363         * mi/mi-interp.c: Update throughout for bfd section macro and
 364         function changes.
 365         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 366         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 367
 368 2019-09-18  Tom Tromey  <tom@tromey.com>
 369
 370         * NEWS: Add entry.
 371         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 372         call rl_initialize.
 373         (tui_enable): Do not call rl_initialize.
 374
 375 2019-09-18  Christian Groessler  <chris@groessler.org>
 376
 377         * alpha-linux-nat.c: Include gdbarch.h.
 378
 379 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 380
 381         * ui-file.c: Include cli/cli-style.h.
 382         (term_cli_styling): Remove cli_styling declaration.
 383
 384 2019-09-18  Alan Modra  <amodra@gmail.com>
 385
 386         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 387         to bfd_asymbol_section.
 388
 389 2019-09-18  Alan Modra  <amodra@gmail.com>
 390
 391         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 392         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 393         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 394
 395 2019-09-18  Alan Modra  <amodra@gmail.com>
 396
 397         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 398         * spu-linux-nat.c (spu_bfd_open): Likewise.
 399
 400 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 401
 402         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 403         to bool to match definition in dwarf2read.c.
 404
 405 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 406
 407         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 408         (print_signatures): Likewise.
 409         (trust_pad_over_xvs): Likewise.
 410         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 411         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 412         * arm-linux-nat.c (arm_apcs_32): Likewise.
 413         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 414         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 415         * arm-tdep.c (arm_debug): Likewise.
 416         (arm_apcs_32): Likewise.
 417         * auto-load.c (debug_auto_load): Likewise.
 418         (auto_load_gdb_scripts): Likewise.
 419         (global_auto_load): Likewise.
 420         (auto_load_local_gdbinit): Likewise.
 421         (auto_load_local_gdbinit_loaded): Likewise.
 422         * auto-load.h (global_auto_load): Likewise.
 423         (auto_load_local_gdbinit): Likewise.
 424         (auto_load_local_gdbinit_loaded): Likewise.
 425         * breakpoint.c (disconnected_dprintf): Likewise.
 426         (breakpoint_proceeded): Likewise.
 427         (automatic_hardware_breakpoints): Likewise.
 428         (always_inserted_mode): Likewise.
 429         (target_exact_watchpoints): Likewise.
 430         (_initialize_breakpoint): Update.
 431         * breakpoint.h (target_exact_watchpoints): Change to bool.
 432         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 433         * cli/cli-cmds.c (trace_commands): Likewise.
 434         * cli/cli-cmds.h (trace_commands): Likewise.
 435         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 436         to bool*.
 437         * cli/cli-logging.c (logging_overwrite): Change to bool.
 438         (logging_redirect): Likewise.
 439         (debug_redirect): Likewise.
 440         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 441         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 442         to bool.
 443         <boolean_option_def>: Update.
 444         (struct flag_option_def): Change default type of Context to bool
 445         from int.
 446         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 447         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 448         (get_setshow_command_value_string): Likewise.
 449         * cli/cli-style.c (cli_styling): Change to bool.
 450         (source_styling): Likewise.
 451         * cli/cli-style.h (source_styling): Likewise.
 452         (cli_styling): Likewise.
 453         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 454         to bool.
 455         * command.h (var_types): Update comment.
 456         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 457         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 458         bool.
 459         (debug_compile_cplus_scopes): Likewise.
 460         * compile/compile-internal.h (compile_debug): Likewise.
 461         * compile/compile.c (compile_debug): Likewise.
 462         (struct compile_options) <raw>: Likewise.
 463         * cp-support.c (catch_demangler_crashes): Likewise.
 464         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 465         (usr_cmd_cris_dwarf2_cfi): Likewise.
 466         * csky-tdep.c (csky_debug): Likewise.
 467         * darwin-nat.c (enable_mach_exceptions): Likewise.
 468         * dcache.c (dcache_enabled_p): Likewise.
 469         * defs.h (info_verbose): Likewise.
 470         * demangle.c (demangle): Likewise.
 471         (asm_demangle): Likewise.
 472         * dwarf-index-cache.c (debug_index_cache): Likewise.
 473         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 474         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 475         * dwarf2read.c (check_physname): Likewise.
 476         (use_deprecated_index_sections): Likewise.
 477         (dwarf_always_disassemble): Likewise.
 478         * eval.c (overload_resolution): Likewise.
 479         * event-top.c (set_editing_cmd_var): Likewise.
 480         (exec_done_display_p): Likewise.
 481         * event-top.h (set_editing_cmd_var): Likewise.
 482         (exec_done_display_p): Likewise.
 483         * exec.c (write_files): Likewise.
 484         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 485         (debug_fbsd_nat): Likewise.
 486         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 487         Likewise.
 488         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 489         <backtrace_past_entry> Likewise.
 490         * gdb-demangle.h (demangle): Likewise.
 491         (asm_demangle): Likewise.
 492         * gdb_bfd.c (bfd_sharing): Likewise.
 493         * gdbcore.h (write_files): Likewise.
 494         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 495         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 496         * gdbthread.h (print_thread_events): Likewise.
 497         * gdbtypes.c (opaque_type_resolution): Likewise.
 498         (strict_type_checking): Likewise.
 499         * gnu-nat.c (gnu_debug_flag): Likewise.
 500         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 501         * guile/scm-param.c (pascm_variable): Add boolval.
 502         (add_setshow_generic): Update.
 503         (pascm_param_value): Update.
 504         (pascm_set_param_value_x): Update.
 505         * hppa-tdep.c (hppa_debug): Change to bool..
 506         * infcall.c (may_call_functions_p): Likewise.
 507         (coerce_float_to_double_p): Likewise.
 508         (unwind_on_signal_p): Likewise.
 509         (unwind_on_terminating_exception_p): Likewise.
 510         * infcmd.c (startup_with_shell): Likewise.
 511         * inferior.c (print_inferior_events): Likewise.
 512         * inferior.h (startup_with_shell): Likewise.
 513         (print_inferior_events): Likewise.
 514         * infrun.c (step_stop_if_no_debug): Likewise.
 515         (detach_fork): Likewise.
 516         (debug_displaced): Likewise.
 517         (disable_randomization): Likewise.
 518         (non_stop): Likewise.
 519         (non_stop_1): Likewise.
 520         (observer_mode): Likewise.
 521         (observer_mode_1): Likewise.
 522         (set_observer_mode): Update.
 523         (sched_multi): Change to bool.
 524         * infrun.h (debug_displaced): Likewise.
 525         (sched_multi): Likewise.
 526         (step_stop_if_no_debug): Likewise.
 527         (non_stop): Likewise.
 528         (disable_randomization): Likewise.
 529         * linux-tdep.c (use_coredump_filter): Likewise.
 530         (dump_excluded_mappings): Likewise.
 531         * linux-thread-db.c (auto_load_thread_db): Likewise.
 532         (check_thread_db_on_load): Likewise.
 533         * main.c (captured_main_1): Update.
 534         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 535         xx2_opt, boolean_opt>: Change to bool.
 536         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 537         * maint.c (maintenance_profile_p): Likewise.
 538         (per_command_time): Likewise.
 539         (per_command_space): Likewise.
 540         (per_command_symtab): Likewise.
 541         * memattr.c (inaccessible_by_default): Likewise.
 542         * mi/mi-main.c (mi_async): Likewise.
 543         (mi_async_1): Likewise.
 544         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 545         * nat/fork-inferior.h (startup_with_shell): Likewise.
 546         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 547         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 548         * nios2-tdep.c (nios2_debug): Likewise.
 549         * or1k-tdep.c (or1k_debug): Likewise.
 550         * parse.c (parser_debug): Likewise.
 551         * parser-defs.h (parser_debug): Likewise.
 552         * printcmd.c (print_symbol_filename): Likewise.
 553         * proc-api.c (procfs_trace): Likewise.
 554         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 555         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 556         (set_parameter_value): Update.
 557         (add_setshow_generic): Update.
 558         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 559         to bool*.
 560         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 561         int*.
 562         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 563         * record-btrace.c (record_btrace_target::store_registers): Update.
 564         * record-full.c (record_full_memory_query): Change to bool.
 565         (record_full_stop_at_limit): Likewise.
 566         * record-full.h (record_full_memory_query): Likewise.
 567         * remote-notif.c (notif_debug): Likewise.
 568         * remote-notif.h (notif_debug): Likewise.
 569         * remote.c (use_range_stepping): Likewise.
 570         (interrupt_on_connect): Likewise.
 571         (remote_break): Likewise.
 572         * ser-tcp.c (tcp_auto_retry): Likewise.
 573         * ser-unix.c (serial_hwflow): Likewise.
 574         * skip.c (debug_skip): Likewise.
 575         * solib-aix.c (solib_aix_debug): Likewise.
 576         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 577         (spu_auto_flush_cache_p): Likewise.
 578         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 579         Likewise.
 580         (struct info_print_options) <quiet>: Likewise.
 581         * symfile-debug.c (debug_symfile): Likewise.
 582         * symfile.c (auto_solib_add): Likewise.
 583         (separate_debug_file_debug): Likewise.
 584         * symfile.h (auto_solib_add): Likewise.
 585         (separate_debug_file_debug): Likewise.
 586         * symtab.c (basenames_may_differ): Likewise.
 587         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 588         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 589         (struct info_types_options) <quiet>: Likewise.
 590         * symtab.h (demangle): Likewise.
 591         (basenames_may_differ): Likewise.
 592         * target-dcache.c (stack_cache_enabled_1): Likewise.
 593         (code_cache_enabled_1): Likewise.
 594         * target.c (trust_readonly): Likewise.
 595         (may_write_registers): Likewise.
 596         (may_write_memory): Likewise.
 597         (may_insert_breakpoints): Likewise.
 598         (may_insert_tracepoints): Likewise.
 599         (may_insert_fast_tracepoints): Likewise.
 600         (may_stop): Likewise.
 601         (auto_connect_native_target): Likewise.
 602         (target_stop_and_wait): Update.
 603         (target_async_permitted): Change to bool.
 604         (target_async_permitted_1): Likewise.
 605         (may_write_registers_1): Likewise.
 606         (may_write_memory_1): Likewise.
 607         (may_insert_breakpoints_1): Likewise.
 608         (may_insert_tracepoints_1): Likewise.
 609         (may_insert_fast_tracepoints_1): Likewise.
 610         (may_stop_1): Likewise.
 611         * target.h (target_async_permitted): Likewise.
 612         (may_write_registers): Likewise.
 613         (may_write_memory): Likewise.
 614         (may_insert_breakpoints): Likewise.
 615         (may_insert_tracepoints): Likewise.
 616         (may_insert_fast_tracepoints): Likewise.
 617         (may_stop): Likewise.
 618         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 619         (make_thread_apply_all_options_def_group): Change argument from int*
 620         to bool*.
 621         (thread_apply_all_command): Update.
 622         (print_thread_events): Change to bool.
 623         * top.c (confirm): Likewise.
 624         (command_editing_p): Likewise.
 625         (history_expansion_p): Likewise.
 626         (write_history_p): Likewise.
 627         (info_verbose): Likewise.
 628         * top.h (confirm): Likewise.
 629         (history_expansion_p): Likewise.
 630         * tracepoint.c (disconnected_tracing): Likewise.
 631         (circular_trace_buffer): Likewise.
 632         * typeprint.c (print_methods): Likewise.
 633         (print_typedefs): Likewise.
 634         * utils.c (debug_timestamp): Likewise.
 635         (sevenbit_strings): Likewise.
 636         (pagination_enabled): Likewise.
 637         * utils.h (sevenbit_strings): Likewise.
 638         (pagination_enabled): Likewise.
 639         * valops.c (overload_resolution): Likewise.
 640         * valprint.h (struct value_print_options) <prettyformat_arrays,
 641         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 642         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 643         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 644         Likewise.
 645         * windows-nat.c (new_console): Likewise.
 646         (cygwin_exceptions): Likewise.
 647         (new_group): Likewise.
 648         (debug_exec): Likewise.
 649         (debug_events): Likewise.
 650         (debug_memory): Likewise.
 651         (debug_exceptions): Likewise.
 652         (useshell): Likewise.
 653         * windows-tdep.c (maint_display_all_tib): Likewise.
 654         * xml-support.c (debug_xml): Likewise.
 655
 656 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 657
 658         * source.c (prepare_path_for_appending): New function.
 659         (openp): Make use of new function.
 660         (find_and_open_source): Search for the compilation directory and
 661         source file as a relative path beneath the directory search path.
 662
 663 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 664
 665         * source-cache.c (source_cache::get_line_charpos): Catch
 666         exceptions and return false, this matches the behaviour documented
 667         in the header file.
 668
 669 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 670
 671         * ada-tasks.c (info_task): Remove quoting of the task's name.
 672
 673 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 674
 675         * symfile.c (auto_solib_add): Replace comment with a reference
 676         to the header file.
 677
 678 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 679
 680         * NEWS: Mention that gdb can now be compiled with Python 3
 681         on Windows.
 682
 683 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 684
 685         * maint.c (maint_print_section_data::maint_print_section_data):
 686         Force use of 'float log10 (float)' by casting the argument to
 687         float.
 688
 689 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * maint.c: Add 'cmath' include.
 692         (struct maint_print_section_data): New structure.
 693         (print_section_index): New function.
 694         (print_bfd_section_info): Add header comment, small whitespace
 695         cleanup, and update to call new print_section_index function.
 696         (print_objfile_section_info): Likewise.
 697         (maint_obj_section_from_bfd_section): New function.
 698         (print_bfd_section_info_maybe_relocated): New function.
 699         (maintenance_info_sections): Add header comment, always use
 700         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 701
 702 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 703
 704         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 705         inner scope, add check that the objfile has psymtabs before
 706         checking psymtabs_addrmap.
 707         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 708
 709 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 710
 711         * NEWS: Announce that Ada task names are now shown at more places,
 712         and between quotes (except in info task output).
 713         * gdb/ada-tasks.c (task_to_str): New function.
 714         (display_current_task_id): Call task_to_str.
 715         (task_command_1): Likewise.
 716         (print_ada_task_info): In non-mi mode, Properly align headers and data
 717         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 718
 719 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 720
 721         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 722         prstatus.pr_lwp.pr_info instead of making it up.
 723
 724 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 725
 726         * auto-load.c (auto_load_expand_dir_vars): Update.
 727         * defs.h (gdb_datadir): Change to std::string.
 728         (python_libdir): Likewise.
 729         (relocate_gdb_directory): Change return type to std::string.
 730         * guile/guile.c (gdbscm_data_directory): Update.
 731         (initialize_scheme_side): Update.
 732         * jit.c (jit_reader_dir): Change to std::string.
 733         (jit_reader_load_command): Update.
 734         * main.c (gdb_datadir): Change to std::string.
 735         (python_libdir): Likewise.
 736         (set_gdb_data_directory): Update.
 737         (relocate_path): Change to return std::string.
 738         (relocate_gdb_directory): Change to return std::string.
 739         (relocate_gdbinit_path_maybe_in_datadir): Update.
 740         (captured_main_1): Update.
 741         * python/python.c (do_start_initialization): Update.
 742         * top.c (show_gdb_datadir): Update.
 743         * xml-syscall.c (xml_init_syscalls_info): Update.
 744         (init_syscalls_info): Update.
 745
 746 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 747
 748         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 749         out of get_init_files.
 750         (get_init_files): Update.
 751
 752 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 753
 754         * main.c (get_init_files): Change to use std::string.
 755         (captured_main_1): Update.
 756         (print_gdb_help): Update.
 757
 758 2019-09-11  Ali Tamur  <tamur@google.com>
 759
 760         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 761         implementation.
 762
 763 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 764
 765         * dbxread.c (read_dbx_symtab): Update.
 766         * dwarf2read.c (load_partial_dies): Update.
 767         * mdebugread.c (parse_partial_symbols): Update.
 768         (handle_psymbol_enumerators): Update.
 769         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 770         * psymtab.c (add_psymbol_to_bcache): Likewise.
 771         (add_psymbol_to_list): Likewise.
 772         * symtab.c (symbol_set_names): Likewise.
 773         * symtab.h (symbol_set_names): Likewise.
 774         * xcoffread.c (scan_xcoff_symtab): Update.
 775
 776 2019-09-11  Tom Tromey  <tom@tromey.com>
 777
 778         * symfile-mem.c (symbol_file_add_from_memory): Use
 779         bfd_set_filename.
 780         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 781         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 782
 783 2019-09-10  Tom Tromey  <tromey@adacore.com>
 784
 785         * dwarf-index-write.c (write_psymbols): Extend error message.
 786         (debug_names::insert): Add Ada code.
 787         (debug_names::write_psymbols): Remove Ada check.
 788         (debug_names) <m_string_obstack>: New member.
 789         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 790         (gdb_index_symbol_name_matcher::matches): Remove.
 791         (mapped_index_base::find_name_components_bounds): Add "lang"
 792         parameter.
 793         (mapped_index_base::build_name_components): Also split names
 794         according to Ada syntax.
 795         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 796         type of "match_callback".
 797         (check_match, check_find_bounds_finds)
 798         (dw2_expand_symtabs_matching): Update.
 799         (dw2_debug_names_iterator): Add new constructor.
 800         (dw2_debug_names_map_matching_symbols): New function.
 801         (dw2_debug_names_expand_symtabs_matching): Update.
 802         (dwarf2_debug_names_functions): Use
 803         dw2_debug_names_map_matching_symbols.
 804
 805 2019-09-10  Tom Tromey  <tromey@adacore.com>
 806
 807         * dwarf2read.c (dw2_get_file_names_reader): Add the
 808         CU's file name to the results.
 809
 810 2019-09-10  Tom Tromey  <tromey@adacore.com>
 811
 812         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 813         map_matching_symbols.  Update.
 814         * dwarf2read.c (dw2_map_matching_symbols): Update.
 815         * psymtab.c (match_partial_symbol): Change type; update.
 816         (psym_map_matching_symbols): Likewise.
 817         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 818         type; update.
 819         * symfile.h (struct quick_symbol_functions)
 820         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 821         Remove "match".
 822
 823 2019-09-10  Tom Tromey  <tromey@adacore.com>
 824
 825         * psymtab.c (map_block): Remove.
 826         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 827         * symtab.c (iterate_over_symbols_terminated): New function.
 828         * symtab.c (iterate_over_symbols_terminated): Declare.
 829
 830 2019-09-10  Tom Tromey  <tromey@adacore.com>
 831
 832         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 833         * language.h (struct language_defn) <la_iterate_over_symbols>:
 834         Return bool.
 835         * symtab.c (iterate_over_symbols): Return bool.
 836         * symtab.h (iterate_over_symbols): Return bool.
 837
 838 2019-09-10  Tom Tromey  <tromey@adacore.com>
 839
 840         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 841         (add_nonlocal_symbols): Update.
 842         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 843         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 844         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 845         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 846         Change type of "callback".  Remove "data".
 847
 848
 849 2019-09-09  Ali Tamur  <tamur@google.com>
 850
 851         * dwarf2read.c (comp_unit_head): Update comment.
 852         (dwarf2_dwo_name): New function declaration.
 853         (dwarf_unit_type_name): New function declaration.
 854         (read_comp_unit_head): Add support for new compilation units,
 855         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 856         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 857         (currently named as "signature") in their header. Also clarify error
 858         messages.
 859         (lookup_dwo_id): New function. Returns the dwo id of the given
 860         compile unit.
 861         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 862         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 863         functions.
 864         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 865         (dwarf2_dwo_name): Get the dwo name if present.
 866         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 867         purposes.
 868
 869 2019-09-09  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 872
 873 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 874
 875         * python/python.c (do_start_initialization): Make progname_copy static,
 876         to avoid a leak report.
 877
 878 2019-09-08  Tom Tromey  <tom@tromey.com>
 879
 880         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 881
 882 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 883
 884         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 885         Change type to gdb::optional<block_enum>.
 886         (dw2_symtab_iter_init): Change block_index parameter type
 887         to gdb::optional<block_enum>.
 888         (dw2_lookup_symbol): Change block_index parameter
 889         type to block_enum.c
 890         (dw2_debug_names_lookup_symbol): Likewise.
 891         * psymtab.c (psym_lookup_symbol): Likewise.
 892         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 893         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 894         Likewise.
 895
 896 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 897
 898         * defs.h (relocate_gdb_directory): Change int to bool in
 899         signature and rename flag to relocatable.
 900         * main.c (relocate_path): Likewise.
 901         (relocate_gdb_directory): Likewise.
 902
 903 2019-09-06  Alan Modra  <amodra@gmail.com>
 904
 905         * coffread.c (coff_symfile_read): Constify filename variable.
 906         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 907         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 908         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 909         * solib.c (reload_shared_libraries_1): Likewise.
 910         * symfile.c (reread_symbols): Likewise.
 911         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 912         * solib-darwin.c (darwin_bfd_open): Likewise.
 913         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 914
 915 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 918         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 919
 920 2019-09-03  Tom Tromey  <tromey@adacore.com>
 921
 922         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 923         types.
 924         (has_negatives): Unbias a range type bound.
 925         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 926         * gdbtypes.c (operator==): Handle new field.
 927         (create_range_type): Add "bias" parameter.
 928         (create_static_range_type, resolve_dynamic_range): Update.
 929         * gdbtypes.h (struct range_bounds) <bias>: New member.
 930         (create_range_type): Add bias parameter.
 931         * printcmd.c (print_scalar_formatted): Unbias range types.
 932         * value.c (unpack_long): Unbias range types.
 933         (pack_long): Bias range types.
 934
 935 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 936
 937         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 938         probe arguments.
 939
 940 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 941
 942         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 943         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 944         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 945         (compile_probe_arg): Likewise.
 946         * probe.h (get_argument_count): Likewise.
 947         * solib-svr4.c (solib_event_probe_action): Likewise.
 948         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 949
 950 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 951
 952         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 953         code to here...
 954         (svr4_create_solib_event_breakpoints): ...from here.
 955
 956 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 957
 958         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 959         suffix from warning message.
 960
 961 2019-08-30  Tom Tromey  <tom@tromey.com>
 962
 963         * tui/tui-winsource.h (struct tui_source_window_base)
 964         <refresh_all>: Don't declare.
 965         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 966         Remove.
 967         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 968         tui_show_locator_content.
 969         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 970         declare.
 971         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 972         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 973         declare.
 974
 975 2019-08-30  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 978
 979 2019-08-30  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 982         Remove unnecessary forward declarations.
 983
 984 2019-08-30  Tom Tromey  <tom@tromey.com>
 985
 986         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 987         rerender.
 988         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 989         tui_show_locator_content.
 990
 991 2019-08-30  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 994         (tui_locator_window::rerender): Rewrite using body of previous
 995         tui_show_locator_content.
 996
 997 2019-08-30  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1000         set_locator_fullname>: New methods.
1001         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1002         Rename from tui_set_locator_fullname.
1003         (tui_locator_window::set_locator_info): Rename from
1004         tui_set_locator_info.  Return bool.
1005         (tui_update_locator_fullname, tui_show_frame_info): Update.
1006
1007 2019-08-30  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1010
1011 2019-08-30  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1014         call touchwin.
1015
1016 2019-08-30  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-wingeneral.c (box_win): Assume win_info and
1019         win_info->handle cannot be NULL.
1020
1021 2019-08-30  Tom Tromey  <tom@tromey.com>
1022
1023         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1024         refresh_window>: Declare.
1025         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1026         resize.
1027         (tui_data_item_window::rerender): Rename from
1028         tui_display_register.
1029         (tui_data_item_window::refresh_window): New method.
1030         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1031         no-op.
1032
1033 2019-08-30  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1036         regs_column_count, current_group>: Move later.  Now private.
1037         <get_current_group>: New method.
1038         * tui/tui-regs.c (tui_reg_command): Update.
1039         * tui/tui-layout.c (tui_set_layout): Update.
1040
1041 2019-08-30  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1044         (tui_data_window::rerender): Don't call
1045         check_and_display_highlight_if_needed.
1046         (tui_data_window::refresh_all): Remove call to
1047         erase_data_content.
1048
1049 2019-08-30  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1052         (tui_data_window::display_registers_from)
1053         (tui_data_window::display_reg_element_at_line)
1054         (tui_data_window::display_registers_from_line): Remove checks of
1055         "empty".
1056
1057 2019-08-30  Tom Tromey  <tom@tromey.com>
1058
1059         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1060         Don't declare.
1061         * tui/tui-regs.c (tui_data_window::show_registers): Call
1062         rerender.
1063         (tui_data_window::rerender): Rename from display_all_data.
1064         (tui_data_window::rerender): Remove old implementation.
1065
1066 2019-08-30  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1069         text.
1070         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1071
1072 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1073             Sergio Durigan Junior  <sergiodj@redhat.com>
1074
1075         PR win32/24284
1076         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1077
1078 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1081         when searching for types.
1082
1083 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * f-lang.c (f_language_defn): Use f_print_typedef.
1086         * f-lang.h (f_print_typedef): Declare.
1087         * f-typeprint.c (f_print_typedef): Define.
1088
1089 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1090
1091         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1092
1093 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1094
1095         * cli/cli-utils.c (info_print_options_defs): Delete.
1096         (make_info_print_options_def_group): Delete.
1097         (extract_info_print_options): Delete.
1098         (info_print_command_completer): Delete.
1099         (info_print_args_help): Add extra parameter, and optionally
1100         include text about -n flag.
1101         * cli/cli-utils.h (struct info_print_options): Delete.
1102         (extract_info_print_options): Delete declaration.
1103         (info_print_command_completer): Delete declaration.
1104         (info_print_args_help): Add extra parameter, extend header
1105         comment.
1106         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1107         search_symbols.
1108         * stack.c (struct info_print_options): New type.
1109         (info_print_options_defs): New file scoped variable.
1110         (make_info_print_options_def_group): New static function.
1111         (info_print_command_completer): New static function.
1112         (info_locals_command): Update to use new local functions.
1113         (info_args_command): Likewise.
1114         (_initialize_stack): Add extra parameter to calls to
1115         info_print_args_help.
1116         * symtab.c (search_symbols): Add extra parameter, use this to
1117         possibly excluse non-debug symbols.
1118         (symtab_symbol_info): Add extra parameter, which is passed on to
1119         search_symbols.
1120         (struct info_print_options): New type.
1121         (info_print_options_defs): New file scoped variable.
1122         (make_info_print_options_def_group): New static function.
1123         (info_print_command_completer): New static function.
1124         (info_variables_command): Update to use local functions, and pass
1125         extra parameter through to symtab_symbol_info.
1126         (info_functions_command): Likewise.
1127         (info_types_command): Pass additional argument through to
1128         symtab_symbol_info.
1129         (rbreak_command): Pass extra argument to search_symbols.
1130         (_initialize_symtab): Add extra arguments for calls to
1131         info_print_args_help, and update help text for 'info variables',
1132         'whereis', and 'info functions' commands.
1133         * symtab.h (search_symbols): Add extra argument to declaration.
1134         * NEWS: Mention new flags.
1135
1136 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1137
1138         * symtab.c (lookup_static_symbol): Call the new function (and move
1139         it down to be next to lookup_global_symbol).
1140         (struct global_sym_lookup_data): Add block_enum member and rename to...
1141         (struct global_or_static_sym_lookup_data): ...this.
1142         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1143         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1144         (lookup_symbol_global_or_static_iterator_cb): ...this.
1145         (lookup_global_or_static_symbol): New function.
1146         (lookup_global_symbol): Call new function.
1147
1148 2019-08-26  Tom de Vries  <tdevries@suse.de>
1149
1150         PR c++/24852
1151         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1152         when pc_probe.prob == NULL.
1153
1154 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1155
1156         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1157         variable symbol_linkage to symbol_linkage_.
1158
1159 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1160
1161         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1162         represent whether the symbol is static, dynamic, or we don't
1163         know.
1164
1165 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1166
1167         * gdb/rx-tdep.c (rx_register_names): New.
1168         (rx_register_name): Delete.
1169         (rx_psw_type): Delete.
1170         (rx_fpsw_type): Delete.
1171         (rx_register_type): Delete.
1172         (rx_gdbarch_init): Convert target-descriptions.
1173         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1174         * gdb/features/Makefile: Add rx.xml.
1175         * gdb/features/rx.xml: New.
1176         * gdb/features/rx.c: Generated.
1177         * gdb/NEWS: Mention target description support.
1178
1179 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1180
1181         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1182         *slot_ptr.
1183
1184 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1185
1186         * configure.ac: Don't check for 'dlfcn.h' (moved to
1187         gdbsupport/common.m4).
1188         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1189         'gdbsupport/'.
1190         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1191         * compile/compile-c-support.c: Include
1192         'gdbsupport/gdb-dlfcn.h'.
1193         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1194         * gdb-dlfcn.c: Move to...
1195         * gdbsupport/gdb-dlfcn.c: ... here.
1196         * gdb-dlfcn.h: Move to...
1197         * gdbsupport/gdb-dlfcn.h: ... here.
1198
1199 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1200
1201         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1202         the offset field signed.
1203
1204 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1205
1206         * python/lib/gdb/__init__.py (_execute_file): New function.
1207         * python/python.c (python_run_simple_file): Call gdb._execute_file
1208         on Windows.
1209
1210 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1213         all uses as this was never set to anything but a zero value.
1214
1215 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1216
1217         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1218
1219 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1220
1221         * tui/tui-data.h (tui_gen_win_info): Add an =default
1222         move constructor, required by some GCC versions.
1223
1224 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1225
1226         * go32-nat.c (go32_sysinfo): Add hygon_p.
1227
1228 2019-08-20  Tom Tromey  <tom@tromey.com>
1229
1230         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1231         line_from_reg_element_no, first_reg_element_no_inline,
1232         display_all_data, delete_data_content_windows,
1233         erase_data_content>: Now private.
1234
1235 2019-08-20  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1238         (tui_unhighlight_win, tui_highlight_win)
1239         (tui_win_info::make_window): Update.
1240         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1241
1242 2019-08-20  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1245         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1246         (MAX_PID_WIDTH): Move to tui-stack.c.
1247         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1248         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1249         (MAX_PID_WIDTH): Move from tui-data.h.
1250
1251 2019-08-20  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1254         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1255         (box_win): Update.
1256         (tui_gen_win_info::make_window): Rename from tui_make_window.
1257         (tui_win_info::make_window): New method.
1258         (tui_gen_win_info::make_visible): Update.
1259         * tui/tui-source.c (tui_source_window::set_contents): Update.
1260         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1261         (tui_data_window::display_registers_from): Update.
1262         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1263         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1264         Declare.
1265         <can_box>: Remove.
1266         <title>: Remove.
1267         (struct tui_win_info) <make_window>: Declare.
1268         <can_box>: Now virtual.
1269         <title>: New member.
1270         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1271         * tui/tui-command.c (tui_cmd_window::resize): Update.
1272
1273 2019-08-20  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1276         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1277         (tui_data_window::check_register_values): Update.
1278
1279 2019-08-20  Tom Tromey  <tom@tromey.com>
1280
1281         * tui/tui-regs.h (struct tui_data_window): Use
1282         DISABLE_COPY_AND_ASSIGN.
1283         <regs_content>: Change type, removing unique_ptr.
1284         <tui_data_window>: Add move constructor.
1285         * tui/tui-regs.c (tui_data_window::show_registers)
1286         (tui_data_window::show_register_group)
1287         (tui_data_window::display_registers_from)
1288         (tui_data_window::display_registers_from)
1289         (tui_data_window::first_data_item_displayed)
1290         (tui_data_window::delete_data_content_windows)
1291         (tui_data_window::rerender, tui_data_window::refresh_window)
1292         (tui_data_window::check_register_values): Update.
1293
1294 2019-08-20  Tom Tromey  <tom@tromey.com>
1295
1296         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1297         show_register_group>: Declare.
1298         (tui_show_register_group): Don't declare.
1299         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1300         tui_show_registers.
1301         (tui_data_window::show_register_group): Rename from
1302         tui_show_register_group.
1303         (tui_data_window::check_register_values, tui_reg_command):
1304         Update.
1305         * tui/tui-layout.c (tui_set_layout): Update.
1306
1307 2019-08-20  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1310         Declare.
1311         (tui_check_register_values): Don't declare.
1312         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1313         from tui_check_register_values.
1314         * tui/tui-hooks.c (tui_register_changed): Update.
1315
1316 2019-08-20  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-regs.c (tui_reg_layout): Move later.
1319         (tui_show_registers): Don't enable TUI mode or change layout.
1320
1321 2019-08-20  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-regs.h (struct tui_data_item_window)
1324         <~tui_data_item_window>: Remove.
1325         <content>: Now a unique_xmalloc_ptr.
1326         * tui/tui-regs.c (tui_register_format): Return a
1327         unique_xmalloc_ptr.
1328         (tui_get_register): Update.
1329         (~tui_data_item_window): Remove.
1330         (tui_data_window::display_registers_from, tui_display_register):
1331         Update.
1332         * tui/tui-io.h (tui_expand_tabs): Update.
1333         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1334         Remove "col" parameter.
1335
1336 2019-08-20  Tom Tromey  <tom@tromey.com>
1337
1338         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1339         field.
1340         * tui/tui-regs.c (~tui_data_item_window): Update.
1341
1342 2019-08-20  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1345         earlier.
1346
1347 2019-08-20  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1350
1351 2019-08-20  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-source.h (struct tui_source_window): Update.
1354         * tui/tui-regs.c (tui_show_registers): Update.
1355         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1356         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1357         (NO_REGS_STRING): Remove defines.
1358
1359 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1360
1361         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1362         unnecessary thread walk if remote doesn't support the packet.
1363
1364 2019-08-19  Tom Tromey  <tromey@adacore.com>
1365
1366         * python/py-value.c (value_has_field): Fix indentation.
1367
1368 2019-08-19  Tom Tromey  <tromey@adacore.com>
1369
1370         * printcmd.c (do_one_display, info_display_command): Update.
1371         * block.h (contained_in): Return bool.  Add allow_nested
1372         parameter.
1373         * block.c (contained_in): Return bool.  Add allow_nested
1374         parameter.
1375
1376 2019-08-19  Tom Tromey  <tom@tromey.com>
1377
1378         * configure: Rebuild.
1379         * configure.ac: Disallow the combination of -static-libstdc++ and
1380         source highlight.
1381         * source-cache.c (get_language_name): Handle rust.
1382         (source_cache::get_source_lines): Ignore highlighting exceptions.
1383
1384 2019-08-16  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1387         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1388         (struct tui_source_window_base) <make_visible, refresh_window,
1389         resize>: Remove methods.
1390         <execution_info>: Remove field.
1391         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1392         (tui_show_source_line, tui_source_window_base)
1393         (~tui_source_window_base): Update.
1394         (tui_source_window_base::resize)
1395         (tui_source_window_base::make_visible)
1396         (tui_source_window_base::refresh_window): Remove.
1397         (tui_source_window_base::update_exec_info): Update.
1398         * tui/tui-source.c (tui_source_window::set_contents): Update.
1399         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1400
1401 2019-08-16  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1404         deprecated_query_hook.
1405
1406 2019-08-16  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1409         (tui_update_source_windows_with_line): Update.
1410         * tui/tui-source.h (struct tui_source_window)
1411         <show_symtab_source>: Declare.
1412         (tui_show_symtab_source): Don't declare.
1413         * tui/tui-source.c (tui_show_symtab_source): Rename from
1414         tui_show_symtab_source.
1415
1416 2019-08-16  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-winsource.h (struct tui_source_window_base)
1419         <set_contents>: Declare.
1420         * tui/tui-winsource.c
1421         (tui_source_window_base::update_source_window_as_is): Update.
1422         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1423         Declare.
1424         (tui_set_source_content): Don't declare.
1425         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1426         tui_set_source_content.
1427         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1428         Declare.
1429         (tui_set_disassem_content): Don't declare.
1430         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1431         tui_set_disassem_content.
1432
1433 2019-08-16  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-winsource.h (struct tui_source_window_base)
1436         <update_breakpoint_info>: Declare.
1437         (tui_update_breakpoint_info): Don't declare.
1438         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1439         (tui_update_all_breakpoint_info): Update.
1440         (tui_source_window_base::update_breakpoint_info): Rename from
1441         tui_update_breakpoint_info.
1442         (tui_source_window_base::update_exec_info): Update.
1443
1444 2019-08-16  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-winsource.h (struct tui_source_window_base)
1447         <update_source_window>: Declare.
1448         (tui_update_source_window): Don't declare.
1449         * tui/tui-winsource.c
1450         (tui_source_window_base::update_source_window): Rename from
1451         tui_update_source_window.
1452         (tui_source_window_base::rerender): Update.
1453         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1454         * tui/tui-disasm.c (tui_show_disassem)
1455         (tui_show_disassem_and_update_source)
1456         (tui_disasm_window::maybe_update): Update.
1457
1458 2019-08-16  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-winsource.h (struct tui_source_window_base)
1461         <update_source_window_as_is>: Declare.
1462         (tui_update_source_window_as_is): Don't declare.
1463         * tui/tui-winsource.c (tui_update_source_window): Update
1464         (tui_source_window_base::update_source_window_as_is): Rename from
1465         tui_update_source_window_as_is.
1466         (tui_source_window_base::refill): Update.
1467         * tui/tui-source.c (tui_show_symtab_source): Update.
1468         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1469         Update.
1470
1471 2019-08-16  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-winsource.h (tui_update_source_window)
1474         (tui_update_source_window_as_is): Remove "noerror" parameter.
1475         * tui/tui-winsource.c (tui_update_source_window)
1476         (tui_update_source_window_as_is): Remove "noerror" parameter.
1477         (tui_update_source_windows_with_addr)
1478         (tui_update_source_windows_with_line)
1479         (tui_source_window_base::rerender)
1480         (tui_source_window_base::refill): Update.
1481         * tui/tui-source.h (tui_set_source_content)
1482         (tui_show_symtab_source): Remove "noerror" parameter.
1483         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1484         parameter.
1485         (tui_show_symtab_source): Likewise.
1486         (tui_source_window::maybe_update): Update.
1487         * tui/tui-disasm.c (tui_show_disassem)
1488         (tui_show_disassem_and_update_source)
1489         (tui_disasm_window::do_scroll_vertical)
1490         (tui_disasm_window::maybe_update): Update.
1491
1492 2019-08-16  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui.c (tui_is_window_visible): Update.
1495         * tui/tui-wingeneral.c (tui_make_window)
1496         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1497         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1498         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1499         (tui_set_win_height_command, parse_scrolling_args): Update.
1500         * tui/tui-source.c (tui_source_window::style_changed): Update.
1501         * tui/tui-regs.c (tui_show_registers)
1502         (tui_data_window::first_data_item_displayed)
1503         (tui_data_window::delete_data_content_windows)
1504         (tui_check_register_values, tui_reg_command): Update.
1505         * tui/tui-disasm.c (tui_show_disassem): Update.
1506         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1507         method.
1508         <is_visible>: Remove field.
1509         * tui/tui-data.c (tui_next_win, tui_prev_win)
1510         (tui_delete_invisible_windows): Update.
1511
1512 2019-08-16  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-winsource.h (struct tui_source_window_base)
1515         <m_has_locator>: Remove.
1516         * tui/tui-layout.c (show_source_disasm_command, show_data)
1517         (show_source_or_disasm_and_command): Update.
1518
1519 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1520
1521         * NEWS (Other MI changes): New subsection.
1522         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1523         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1524         * arch-utils.c (default_get_pc_address_flags): New function.
1525         * arch-utils.h (default_get_pc_address_flags): New declaration.
1526         * gdbarch.sh: Add get_pc_address_flags.
1527         * gdbarch.c: Regenerate.
1528         * gdbarch.h: Likewise.
1529         * stack.c (print_pc): New function.
1530         (print_frame_info) (print_frame): Call print_pc.
1531
1532 2019-08-16  Tom de Vries  <tdevries@suse.de>
1533
1534         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1535         print_objfile_section_info.
1536
1537 2019-08-15  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1540         calling update_cmdwin_start_line.
1541         * tui/tui-winsource.h (struct tui_source_window_base)
1542         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1543         <rerender>: Declare.
1544         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1545         Call rerender.
1546         (tui_source_window_base::set_new_height): Remove.
1547         (tui_source_window_base::rerender): Rename from
1548         do_make_visible_with_new_height.
1549         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1550         resize method.
1551         (tui_win_info::make_invisible_and_set_new_height)
1552         (tui_win_info::make_visible_with_new_height): Remove.
1553         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1554         Declare.
1555         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1556         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1557         do_make_visible_with_new_height>: Don't declare.
1558         <rerender>: Declare.
1559         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1560         set_new_height.
1561         (tui_data_window::do_make_visible_with_new_height): Remove.
1562         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1563         call tui_show_locator_content.
1564         (tui_gen_win_info::resize): Call rerender.
1565         (show_source_or_disasm_and_command): Don't call
1566         tui_show_locator_content.
1567         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1568         method.
1569         (struct tui_win_info) <rerender>: Declare.
1570         <set_new_height, make_invisible_and_set_new_height,
1571         make_visible_with_new_height>: Don't declare.
1572         * tui/tui-data.c (tui_win_list::rerender): New method.
1573         * tui/tui-command.h (struct tui_cmd_window)
1574         <do_make_visible_with_new_height>: Don't declare.
1575         * tui/tui-command.c
1576         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1577
1578 2019-08-15  Tom Tromey  <tromey@adacore.com>
1579
1580         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1581         * ada-lang.c (ada_enum_name): Likewise.
1582
1583 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1584
1585         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1586         leading underscore.
1587         (GdbOutputErrorFile): Likewise.
1588         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1589         accordingly.
1590         (execute_unwinders): Rename to have a leading underscore.
1591         (auto_load_packages): Likewise.
1592         (global scope): Adjust call to auto_load_packages accordingly.
1593         (GdbSetPythonDirectory): Likewise.
1594         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1595         instead of execute_unwinders.
1596
1597 2019-08-15  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1600         (show_data): Don't change window visibility.
1601         (tui_gen_win_info::resize): Remove special case for command
1602         window.  Use wresize, when available.
1603         (show_source_or_disasm_and_command): Don't change window
1604         visibility.
1605         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1606         <make_visible>: New method.
1607         * tui/tui-command.c (tui_cmd_window::resize): New method.
1608
1609 2019-08-15  Tom Tromey  <tom@tromey.com>
1610
1611         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1612         (struct tui_source_windows): New.
1613         * tui/tui-winsource.c (tui_display_main): Update.
1614         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1615         (new_height_ok, parse_scrolling_args): Update.
1616         * tui/tui-layout.c (show_layout, show_data): Update.
1617         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1618         (tui_add_to_source_windows): Don't declare.
1619         * tui/tui-data.c (source_windows, tui_source_windows)
1620         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1621
1622 2019-08-15  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1625         Rename from reset.
1626         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1627         * tui/tui-layout.c (show_source_disasm_command, show_data):
1628         Update.
1629         (tui_gen_win_info::resize): Rename.
1630         (show_source_or_disasm_and_command): Update.
1631         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1632         reset.
1633
1634 2019-08-15  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1637         * tui/tui-interp.c (tui_interp::init): Don't call
1638         tui_initialize_static_data.
1639         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1640
1641 2019-08-15  Tom Tromey  <tom@tromey.com>
1642
1643         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1644         examine tui_win_list.
1645
1646 2019-08-15  Tom Tromey  <tom@tromey.com>
1647
1648         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1649         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1650         tui_clear_source_content.
1651         (tui_clear_source_content): Remove.
1652         (tui_source_window_base::do_erase_source_content): Hoist call to
1653         content.clear().
1654         * tui/tui-stack.c (tui_show_frame_info): Don't call
1655         tui_clear_source_content.
1656
1657 2019-08-15  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-winsource.h (struct tui_source_window_base)
1660         <do_erase_source_content>: New method.
1661         <erase_source_content>: New method.
1662         (tui_erase_source_content): Don't declare.
1663         * tui/tui-winsource.c (tui_clear_source_content): Update.
1664         (tui_source_window_base::do_erase_source_content): Rename from
1665         tui_erase_source_content.
1666         (tui_source_window_base::show_source_content): Update.
1667         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1668         * tui/tui-source.h (struct tui_source_window)
1669         <erase_source_content>: New method.
1670         * tui/tui-disasm.h (struct tui_disasm_window)
1671         <erase_source_content>: New method.
1672
1673 2019-08-15  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1676         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1677         constructor.
1678         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1679         * tui/tui-source.c (tui_set_source_content): Update.
1680         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1681
1682 2019-08-15  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1685         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1686         tui-source.c.
1687         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1688         Declare.
1689         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1690         method.
1691         (tui_source_window::maybe_update): Update.
1692
1693 2019-08-15  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1696         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1697         tui-disasm.c.
1698         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1699         Declare.
1700         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1701         method.
1702         (tui_disasm_window::maybe_update): Update.
1703
1704 2019-08-15  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-winsource.h (struct tui_source_window_base)
1707         <maybe_update>: Declare.
1708         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1709         method.
1710         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1711         Declare.
1712         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1713         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1714         Declare.
1715         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1716
1717 2019-08-15  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1720
1721 2019-08-15  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-wingeneral.c: Include tui-stack.h.
1724         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1725         (struct tui_locator_window): Move from tui-data.h.
1726         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1727         (tui_initialize_static_data): Move from tui-data.c.
1728         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1729         (struct tui_locator_window): Move to tui-stack.c.
1730         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1731         (tui_initialize_static_data): Move to tui-stack.c.
1732
1733 2019-08-15  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-layout.c (show_source_disasm_command)
1736         (show_source_or_disasm_and_command): Use make_visible method, not
1737         tui_make_window.
1738         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1739         Remove.
1740
1741 2019-08-15  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-wingeneral.h (tui_make_window): Update.
1744         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1745         parameter.
1746         (tui_gen_win_info::make_visible): Update.
1747         * tui/tui-regs.c (tui_data_window::display_registers_from):
1748         Update.
1749         * tui/tui-layout.c (show_source_disasm_command)
1750         (show_source_or_disasm_and_command): Update.
1751         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1752         (enum tui_box): Remove.
1753         (struct tui_win_info) <can_box>: New method.
1754         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1755         method.
1756
1757 2019-08-15  Tom de Vries  <tdevries@suse.de>
1758
1759         * linux-nat-trad.c: Include gdbarch.h.
1760
1761 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1762
1763         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1764         register sizes.
1765
1766 2019-08-14  Tom Tromey  <tromey@adacore.com>
1767
1768         * darwin-nat.c: Include gdbarch.h.
1769         * darwin-nat-info.c: Include gdbarch.h.
1770
1771 2019-08-13  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1774         Remove.
1775         * tui/tui-data.c (tui_initialize_static_data): Update.
1776
1777 2019-08-13  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.h (struct tui_exec_info_window)
1780         <~tui_exec_info_window, maybe_allocate_content, get_content,
1781         m_content>: Remove.
1782         (struct tui_source_window_base) <set_exec_info_content,
1783         show_exec_info_content>: Don't declare.
1784         * tui/tui-winsource.c
1785         (tui_exec_info_window::maybe_allocate_content): Remove.
1786         (tui_source_window_base::update_exec_info): Rename from
1787         set_exec_info_content.
1788         (tui_source_window_base::show_exec_info_content)
1789         (tui_source_window_base::update_exec_info): Remove.
1790
1791 2019-08-13  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1794         declare.
1795         * tui/tui-winsource.c (tui_update_source_window_as_is)
1796         (tui_update_source_windows_with_addr, tui_erase_source_content):
1797         Update.
1798         (tui_clear_exec_info_content): Remove.
1799
1800 2019-08-13  Tom Tromey  <tom@tromey.com>
1801
1802         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1803         declare.
1804         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1805         call tui_erase_exec_info_content.
1806         (tui_clear_exec_info_content): Rename from
1807         tui_erase_exec_info_content.
1808         (tui_clear_exec_info_content): Delete.
1809
1810 2019-08-13  Tom Tromey  <tom@tromey.com>
1811
1812         * tui/tui-winsource.h (struct tui_source_window_base)
1813         <show_exec_info_content>: Declare.
1814         (tui_show_exec_info_content): Don't declare.
1815         * tui/tui-winsource.c
1816         (tui_source_window_base::show_exec_info_content): Rename from
1817         tui_show_exec_info_content.
1818         (tui_source_window_base::update_exec_info): Update.
1819
1820 2019-08-13  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1823         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1824         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1825         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1826         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1827         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1828         ... here.
1829
1830 2019-08-13  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-winsource.h (struct tui_source_window_base)
1833         <update_exec_info>: Declare.
1834         (tui_update_exec_info): Don't declare.
1835         * tui/tui-winsource.c (tui_update_source_window_as_is)
1836         (tui_source_window_base::refresh_all)
1837         (tui_update_all_breakpoint_info): Update.
1838         (tui_source_window_base::update_exec_info): Rename from
1839         tui_update_exec_info.
1840         * tui/tui-stack.c (tui_show_frame_info): Update.
1841
1842 2019-08-13  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-winsource.h (struct tui_source_window_base)
1845         <set_exec_info_content>: Declare.
1846         (tui_set_exec_info_content): Don't declare.
1847         * tui/tui-winsource.c
1848         (tui_source_window_base::set_exec_info_content): Rename from
1849         tui_set_exec_info_content.
1850         (tui_update_exec_info): Update.
1851
1852 2019-08-13  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-winsource.h (struct tui_source_window_base)
1855         <show_source_content>: Declare.
1856         (tui_show_source_content): Don't declare.
1857         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1858         (tui_source_window_base::show_source_content): Rename from
1859         tui_show_source_content.
1860         (tui_source_window_base::refresh_all): Update.
1861         * tui/tui-layout.c (show_source_disasm_command)
1862         (show_source_or_disasm_and_command): Update.
1863
1864 2019-08-13  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-winsource.c (tui_erase_source_content)
1867         (tui_show_source_content, tui_source_window_base::refresh_all):
1868         Update.
1869         * tui/tui-wingeneral.h
1870         (tui_check_and_display_highlight_if_needed): Don't declare.
1871         * tui/tui-wingeneral.c
1872         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1873         check_and_display_highlight_if_needed.
1874         * tui/tui-win.c (tui_rehighlight_all)
1875         (tui_win_info::make_visible_with_new_height): Update.
1876         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1877         (tui_data_window::erase_data_content)
1878         (tui_data_window::display_all_data): Update.
1879         * tui/tui-data.h (struct tui_win_info)
1880         <check_and_display_highlight_if_needed>: Declare.
1881
1882 2019-08-13  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-win.c (tui_resize_all): Call
1885         tui_delete_invisible_windows.
1886         * tui/tui-layout.c (show_layout): Call
1887         tui_delete_invisible_windows.
1888         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1889         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1890
1891 2019-08-13  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1894         tui_add_win_to_layout.
1895
1896 2019-08-13  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1899         * tui/tui-layout.c (tui_default_win_height): Now static.
1900
1901 2019-08-13  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1904         single switch.
1905         (show_source_disasm_command, show_source_or_disasm_and_command):
1906         Don't check current layout.
1907
1908 2019-08-13  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-wingeneral.c (make_all_visible): Remove.
1911         (tui_make_all_invisible): Simplify.
1912         * tui/tui-layout.c (tui_make_all_invisible): Move from
1913         tui-wingeneral.c; simplify.
1914         (show_layout): Hoist call to tui_make_all_invisible.
1915         (show_data): Don't call tui_make_all_invisible.
1916
1917 2019-08-13  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1920         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1921
1922 2019-08-13  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1925         tui-data.c.
1926         (show_source_disasm_command, show_data)
1927         (show_source_or_disasm_and_command): Don't use
1928         tui_set_current_layout_to.
1929         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1930         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1931         tui-layout.c.
1932         (tui_set_current_layout_to): Remove.
1933
1934 2019-08-13  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-layout.c (tui_set_layout): Update.
1937         * tui/tui-data.h (struct tui_layout_def): Remove.
1938         (tui_layout_def): Don't declare.
1939         * tui/tui-data.c (layout_def): Remove.
1940         (tui_layout_def): Remove.
1941
1942 2019-08-13  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui-winsource.h (struct tui_source_window_base)
1945         <clear_detail>: No longer "override".
1946         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1947         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1948         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1949         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1950         Remove.
1951         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1952
1953 2019-08-13  Tom Tromey  <tromey@adacore.com>
1954
1955         * tracepoint.c: Don't include readline.h or history.h.
1956
1957 2019-08-12  Tom Tromey  <tom@tromey.com>
1958
1959         * configure: Rebuild.
1960         * configure.ac: Check for readline 7.
1961         * NEWS: Mention readline 7 requirement.
1962         * README: Update.
1963
1964 2019-08-12  Tom Tromey  <tom@tromey.com>
1965
1966         * mingw-hdep.c (gdb_select): Remove readline hack.
1967
1968 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1969
1970         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1971         when the function fails.
1972
1973 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1974
1975         * s390-tdep.c (s390_type_align): New function.
1976         (s390_gdbarch_init): Set it as type_align gdbarch method.
1977
1978 2019-08-09  Tom de Vries  <tdevries@suse.de>
1979
1980         PR gdb/24591
1981         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1982         pc_low with relocation offset.
1983
1984 2019-08-07  Tom Tromey  <tromey@adacore.com>
1985
1986         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1987         (print_frame_args): Update.
1988         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1989         Update.
1990         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1991         * frame.h (struct frame_arg): Add initializers.
1992         <error>: Now a unique_xmalloc_ptr.
1993
1994 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1995
1996         * NEWS: Expand the Pointer Authentication entry.
1997         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1998         (aarch64_frame_unmask_lr): ... to this.
1999         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2000         Call aarch64_frame_unmask_lr.
2001         * frame.c (struct frame_info): Add "masked" variable.
2002         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2003         (fprint_frame): Check for masked pc.
2004         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2005         declarations.
2006         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2007         * stack.c (print_frame): Check for masked pc.
2008
2009 2019-08-06  Tom Tromey  <tom@tromey.com>
2010
2011         * stabsread.c (patch_block_stabs, read_one_struct_field)
2012         (read_enum_type): Use obstack_strndup.
2013         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2014         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2015         * dwarf2read.c (guess_full_die_structure_name)
2016         (anonymous_struct_prefix): Use obstack_strndup.
2017         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2018         * c-exp.y (yylex): Use obstack_strndup.
2019         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2020         (write_var_or_type): Use obstack_strndup.
2021
2022 2019-08-06  Tom Tromey  <tom@tromey.com>
2023
2024         * symfile.c (reread_symbols): Use obstack_strdup.
2025         * stabsread.c (read_type): Use obstack_strdup.
2026         * gdb_obstack.h (obstack_strdup): New overload.
2027         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2028         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2029         (dwarf2_canonicalize_name): Use obstack_strdup.
2030         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2031         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2032         Use obstack_strdup.
2033
2034 2019-08-06  Tom Tromey  <tom@tromey.com>
2035
2036         * gdb_obstack.h (obstack_strdup): Define.
2037         * gdb_obstack.c (obstack_strdup): Don't define.
2038
2039 2019-08-06  Tom Tromey  <tom@tromey.com>
2040
2041         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2042         obstack_strdup.
2043         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2044         obstack_strdup.
2045         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2046         * stabsread.c (common_block_start): Use obstack_strdup.
2047         * objfiles.c (set_objfile_main_name, objfile): Use
2048         obstack_strdup.
2049         * namespace.c (add_using_directive): Use obstack_strdup.
2050         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2051         * jit.c (finalize_symtab): Use obstack_strdup.
2052         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2053         (guess_partial_die_structure_name, partial_die_info::fixup)
2054         (dwarf2_name): Use obstack_strdup.
2055         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2056         obstack_strdup.
2057         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2058         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2059         obstack_strdup.
2060         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2061
2062 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2063
2064         * unittests/help-doc-selftests.c: New file.
2065         * Makefile.in: Add the new file.
2066
2067 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2068
2069         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2070         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2071         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2072         the trailing '.' is not output, and the first character is uppercased.
2073         (print_help_for_command): Update call to print_doc_line.
2074         (print_doc_of_command): Likewise.
2075         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2076         * cli/cli-option.c (append_indented_doc): Do not append newline.
2077         (build_help_option): Append newline after first appended_indented_doc
2078         only if a second call is done.
2079         (build_help): Append 2 new lines before each option, except the first
2080         one.
2081         * compile/compile.c (_initialize_compile): Add new lines after
2082         %OPTIONS%, when not at the end of the help.
2083         Change help doc or code
2084         producing the help doc to respect the invariants.
2085         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2086         Also removed the new line after 'Options:', as all other commands
2087         do not put an empty line between 'Options:' and the first option.
2088         * printcmd.c (_initialize_printcmd): Likewise.
2089         * stack.c (_initialize_stack): Likewise.
2090         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2091         incorrectly telling COMMAND is optional.
2092         * ada-lang.c (_initialize_ada_language): Change help doc or code
2093         producing the help doc to respect the invariants.
2094         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2095         * breakpoint.c (_initialize_breakpoint): Likewise.
2096         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2097         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2098         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2099         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2100         _initialize_cli_style): Likewise.
2101         * corelow.c (core_target_info): Likewise.
2102         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2103         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2104         * filesystem.c (_initialize_filesystem): Likewise.
2105         * frame.c (_initialize_frame): Likewise.
2106         * gnu-nat.c (add_task_commands): Likewise.
2107         * infcall.c (_initialize_infcall): Likewise.
2108         * infcmd.c (_initialize_infcmd): Likewise.
2109         * interps.c (_initialize_interpreter): Likewise.
2110         * language.c (_initialize_language): Likewise.
2111         * linux-fork.c (_initialize_linux_fork): Likewise.
2112         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2113         * maint.c (_initialize_maint_cmds): Likewise.
2114         * memattr.c (_initialize_mem): Likewise.
2115         * printcmd.c (_initialize_printcmd): Likewise.
2116         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2117         _RegEx): Likewise.
2118         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2119         * record-btrace.c (_initialize_record_btrace): Likewise.
2120         * record-full.c (_initialize_record_full): Likewise.
2121         * record.c (_initialize_record): Likewise.
2122         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2123         * regcache.c (_initialize_regcache): Likewise.
2124         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2125         _initialize_remote): Likewise.
2126         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2127         * serial.c (_initialize_serial): Likewise.
2128         * skip.c (_initialize_step_skip): Likewise.
2129         * source.c (_initialize_source): Likewise.
2130         * stack.c (_initialize_stack): Likewise.
2131         * symfile.c (_initialize_symfile): Likewise.
2132         * symtab.c (_initialize_symtab): Likewise.
2133         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2134         * top.c (init_main): Likewise.
2135         * tracefile-tfile.c (tfile_target_info): Likewise.
2136         * tracepoint.c (_initialize_tracepoint): Likewise.
2137         * tui/tui-win.c (_initialize_tui_win): Likewise.
2138         * utils.c (add_internal_problem_command): Likewise.
2139         * valprint.c (value_print_option_defs): Likewise.
2140
2141 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2142
2143         PR build/24886
2144         * configure.ac: Drop enable-libmcheck support.
2145         * configure, config.in: Rebuild.
2146         * libmcheck.m4: Remove.
2147         * acinclude.m4: Don't include it.
2148         * Makefile.in: Don't distribute it.
2149         * top.c (print_gdb_configuration): Don't mention it.
2150
2151 2019-08-06  Tom Tromey  <tom@tromey.com>
2152
2153         * utils.c (set_output_style): Sometimes pass stream to
2154         emit_style_escape.
2155         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2156         * record-btrace.c (btrace_insn_history): Update.
2157         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2158         method.
2159         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2160         Update initializers.
2161         <m_uiout>: New field.
2162         <m_di>: Move lower.
2163         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2164         Remove "uiout" parameter.
2165         (dump_insns): Update.
2166         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2167         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2168
2169 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2170
2171         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2172         (error_in_psymtab_expansion): Likewise.
2173         (lookup_symbol_via_quick_fns): Likewise.
2174         (basic_lookup_transparent_type_quick): Likewise.
2175         (basic_lookup_transparent_type_1): Likewise.
2176
2177 2019-08-06  Tom Tromey  <tromey@adacore.com>
2178
2179         * source.c (last_source_error): Now bool.
2180         (print_source_lines_base): Make "noprint" bool.  Only open
2181         source file when last_source_visited changes.
2182
2183 2019-08-06  Tom Tromey  <tromey@adacore.com>
2184
2185         * annotate.c (annotate_source_line): Use g_source_cache.
2186         * source-cache.c (source_cache::get_plain_source_lines): Change
2187         parameters.  Populate m_offset_cache.
2188         (source_cache::ensure): New method.
2189         (source_cache::get_line_charpos): New method.
2190         (extract_lines): Move lower.  Change parameters.
2191         (source_cache::get_source_lines): Move lower.
2192         * source-cache.h (class source_cache): Update comment.
2193         <get_line_charpos>: New method.
2194         <get_source_lines>: Update comment.
2195         <clear>: Clear m_offset_cache.
2196         <get_plain_source_lines>: Change parameters.
2197         <ensure>: New method
2198         <m_offset_cache>: New member.
2199         * source.c (forget_cached_source_info_for_objfile): Update.
2200         (info_source_command): Use g_source_cache.
2201         (find_source_lines, open_source_file_with_line_charpos): Remove.
2202         (print_source_lines_base, search_command_helper): Use g_source_cache.
2203         * source.h (open_source_file_with_line_charpos): Don't declare.
2204         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2205         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2206         Use g_source_cache.
2207
2208 2019-08-06  Tom Tromey  <tromey@adacore.com>
2209
2210         * source-cache.c (source_cache::get_plain_source_lines):
2211         Remove "first_line" and "last_line" parameters.
2212         (source_cache::get_source_lines): Cache plain text.
2213         * source-cache.h (class source_cache)
2214         <get_plain_source_lines>: Update.
2215
2216 2019-08-06  Tom Tromey  <tromey@adacore.com>
2217
2218         * source-cache.c (extract_lines): No longer a method.
2219         Changed type of parameter.  Include final newline.
2220         (selftests::extract_lines_test): New function.
2221         (_initialize_source_cache): Likewise.
2222         * source-cache.h (class source_cache)
2223         <extract_lines>: Don't declare.
2224
2225 2019-08-06  Tom Tromey  <tromey@adacore.com>
2226
2227         * breakpoint.c (init_breakpoint_sal): Update.
2228         (breakpoint): Update.
2229         * breakpoint.h (struct breakpoint) <filter>: Now a
2230         unique_xmalloc_ptr.
2231
2232 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2233
2234         * NEWS: Mention dictionary access on blocks.
2235         * python/py-block.c (blpy_getitem): New function.
2236         (block_object_as_mapping): New struct.
2237         (block_object_type): Use new struct for tp_as_mapping field.
2238
2239 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2240
2241         * objfiles.h (objfile): Add a comment describing partial symbols.
2242
2243 2019-08-05  Tom Tromey  <tromey@adacore.com>
2244
2245         * compile/compile.c (_initialize_compile): Use _(), not N_().
2246         * thread.c (_initialize_thread): Use _(), not N_().
2247         * stack.c (_initialize_stack): Use _(), not N_().
2248         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2249
2250 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2251
2252         * dwarf2read.c (struct dw2_symtab_iterator):
2253         <want_specific_block>: Remove.
2254         <block_index>: Change type to gdb::optional.
2255         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2256         change type of BLOCK_INDEX parameter to gdb::optional.
2257         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2258         (dw2_lookup_symbol): Don't pass argument for
2259         WANT_SPECIFIC_BLOCK.
2260         (dw2_expand_symtabs_for_function): Don't pass argument for
2261         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2262         (class dw2_debug_names_iterator)
2263         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2264         parameter, change BLOCK_INDEX type to gdb::optional.
2265         <m_want_specific_block>: Remove.
2266         <m_block_index>: Change type to gdb::optional.
2267         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2268         gdb::optional.  Re-write in function of gdb::optional.
2269         (dw2_debug_names_lookup_symbol): Don't pass argument for
2270         WANT_SPECIFIC_BLOCK.
2271         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2272         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2273         BLOCK_INDEX.
2274
2275 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2276
2277         * NEWS: Mention changes to "info sources" command.
2278
2279 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2280
2281         * symtab.c (filename_partial_match_opts): New struct type.
2282         (struct output_source_filename_data): New members
2283         regexp, c_regexp, partial_match.
2284         (output_source_filename): Use new members to decide to print file.
2285         (info_sources_option_defs): New variable.
2286         (make_info_sources_options_def_group, print_info_sources_header,
2287         info_sources_command_completer):
2288         New functions.
2289         (info_sources_command): Read new optional arguments.
2290         (_initialize_symtab): Update info sources help.
2291
2292 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2293
2294         * ada-lang.c (exception_support_info_v0): Renamed from...
2295         (default_exception_support_info): ... this.  Create new
2296         definition for v1.
2297         (ada_has_this_exception_support): Look up catch_handlers_sym.
2298         (ada_exception_support_info_sniffer): Try v0 after default.
2299
2300 2019-08-01  Tom Tromey  <tromey@adacore.com>
2301
2302         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2303         gdbarch.h.
2304
2305 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2306
2307         * s12z-tdep.c: Fix include path for s12z-opc.h.
2308
2309 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2310
2311         * NEWS: Require GNU make 3.82.
2312
2313 2019-07-16  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2316         declare.
2317
2318 2019-07-30  Tom Tromey  <tromey@adacore.com>
2319
2320         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2321
2322 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2323
2324         * printcmd.c (print_address_symbolic): Print negative offsets.
2325         (build_address_symbolic): Force signed arithmetic when computing
2326         offset.
2327
2328 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2329
2330         PR/24474: Add a function to lookup static variables.
2331         * NEWS: Mention this new function.
2332         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2333         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2334         * python/python.c (python_GdbMethods): Add new function.
2335
2336 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2337
2338         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2339         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2340         (objfpy_lookup_static_symbol): New function.
2341         (objfile_object_methods): Add new functions.
2342
2343 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2344
2345         * NEWS: Mention 'set|show print frame-info'.  Mention new
2346         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2347         backtrace argument.  Mention that python frame filtering code
2348         is now consistent with what 'backtrace' command prints.
2349
2350 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2351
2352         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2353         comments.
2354         (print_frame_info_auto, print_frame_info_source_line,
2355         print_frame_info_location, print_frame_info_source_and_location,
2356         print_frame_info_location_and_address, print_frame_info_short_location):
2357         New declarations.
2358         (struct frame_print_options): New member print_frame_info.
2359         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2360         * stack.h (get_user_print_what_frame_info): New declaration.
2361         (frame_show_address): New declaration.
2362         * stack.c (print_frame_arguments_choices): New value 'presence'.
2363         (print_frame_info_auto, print_frame_info_source_line,
2364         print_frame_info_location, print_frame_info_source_and_location,
2365         print_frame_info_location_and_address, print_frame_info_short_location,
2366         print_frame_info_choices, print_frame_info_print_what): New definitions.
2367         (print_frame_args): Only print dots for args if print frame-arguments
2368         is 'presence'.
2369         (frame_print_option_defs): New element for "frame-info".
2370         (get_user_print_what_frame_info): New function.
2371         (frame_show_address): Make non static.  Move comment to stack.h.
2372         (print_frame_info_to_print_what): New function.
2373         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2374         to decide what to print.
2375         (backtrace_command_1): Handle the new print_frame_arguments_presence
2376         value.
2377         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2378         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2379         (py_print_frame): In non-mi mode, use LOCATION as default for
2380         print_what, similarly to frame information printed directly by
2381         backtrace command. Handle frame-info user option in non MI mode.
2382
2383 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2384
2385         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2386         Add case for debugging 32-bit target on 64-bit host.  Revise
2387         comment.
2388
2389 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2390
2391         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2392         instead of find_function_entry_range_from_pc.
2393
2394 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2395
2396         * stack.c (find_frame_funname): Remove code which preferred
2397         minsym over symtab sym in "certain pathological cases".
2398
2399         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2400         parameter.  Change type of "do_demangle" to bool.
2401         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2402         Pass suitable "prefer_sym_over_minsym" flag to
2403         build_address_symbolic().  Don't output "+" for negative offsets.
2404         * printcmd.c (print_address_symbolic): Update invocation of
2405         build_address_symbolic to include a "prefer_sym_over_minsym"
2406         flag.
2407         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2408         Restrict cases in which use of minimal symbol is preferred to that
2409         of a found symbol.  Update comments.
2410
2411         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2412         for entry pc when entry pc is out of range for that FDE.
2413
2414 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2415
2416         PR gdb/24839:
2417         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2418         type.
2419
2420 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2421
2422         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2423         this function's Python signature.
2424
2425
2426 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2427
2428         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2429         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2430         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2431         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2432         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2433
2434
2435 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2436
2437         * h8300-tdep.c (h8300_register_name_common): New.
2438         h8300_register_name): Use h8300_register_name_common.
2439         (h8300s_register_name): Likewise.
2440         (h8300sx_register_name): Likewise.
2441         (h8300h_register_nam): New.
2442         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2443
2444
2445 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2446
2447         * arm-tdep.c (arm_skip_cmse_entry): New function.
2448         (arm_is_sgstubs_section): New function.
2449         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2450
2451 2019-07-22  Tom Tromey  <tom@tromey.com>
2452
2453         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2454         Don't self-assign.
2455
2456 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2457
2458         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2459         type_print.
2460
2461 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2462
2463         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2464         so that GDB doesn't match any msymbols when searching in the
2465         TYPES_DOMAIN.
2466         (print_symbol_info): Print using typedef_print or type_print based
2467         on the type of the symbol.  Add updated FIXME comment moved from...
2468         (_initialize_symtab): ... move and update FIXME comment to above.
2469
2470 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2471
2472         * NEWS: Mention adding -q option to "info types".
2473         * symtab.c (struct info_types_options): New struct.
2474         (info_types_options_defs): New variable.
2475         (make_info_types_options_def_group): New function.
2476         (info_types_command): Use gdb::option framework to parse options.
2477         (info_types_command_completer): New function.
2478         (_initialize_symtab): Extend the help text on "info types" and
2479         register command completer.
2480
2481 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2482
2483         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2484         (lookup_symbol_in_objfile): Change int to block_enum and add a
2485         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2486
2487 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2488
2489         * MAINTAINERS (Write After Approval): Add self.
2490
2491 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2492
2493         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2494         instruction to the dummy code region.
2495
2496 2019-07-19  Tom Tromey  <tromey@adacore.com>
2497
2498         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2499         (ARGSUSED, PARAMS, __func__): Remove rules.
2500
2501 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2502
2503         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2504         * features/arm/arm-with-iwmmxt.c: Remove.
2505         * features/arm/arm-with-iwmmxt.xml: Remove.
2506         * features/arm/arm-with-m-fpa-layout.c: Remove.
2507         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2508         * features/arm/arm-with-m-vfp-d16.c: Remove.
2509         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2510         * features/arm/arm-with-m.c: Remove.
2511         * features/arm/arm-with-m.xml: Remove.
2512         * features/arm/arm-with-neon.c: Remove.
2513         * features/arm/arm-with-neon.xml: Remove.
2514         * features/arm/arm-with-vfpv2.c: Remove.
2515         * features/arm/arm-with-vfpv2.xml: Remove.
2516         * features/arm/arm-with-vfpv3.c: Remove.
2517         * features/arm/arm-with-vfpv3.xml: Remove.
2518
2519 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2520
2521         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2522
2523 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2524
2525         * arch/aarch32.c (aarch32_create_target_description): Create
2526         target descriptions using features.
2527         * arch/arm.c (arm_create_target_description)
2528         (arm_create_mprofile_target_description): Likewise.
2529         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2530
2531 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2532
2533         * Makefile.in: Add new files.
2534         * aarch32-tdep.c: New file.
2535         * aarch32-tdep.h: New file.
2536         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2537         Call aarch32_read_description.
2538         * arch/aarch32.c: New file.
2539         * arch/aarch32.h: New file.
2540         * arch/arm.c (arm_create_target_description)
2541         (arm_create_mprofile_target_description): New function.
2542         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2543         (arm_create_target_description)
2544         (arm_create_mprofile_target_description): New declaration.
2545         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2546         read_description functions.
2547         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2548         Likewise.
2549         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2550         * arm-tdep.c (tdesc_arm_list): New variable.
2551         (arm_register_g_packet_guesses): Call create description functions.
2552         (arm_read_description) (arm_read_mprofile_description): New
2553         function.
2554         * arm-tdep.h (arm_read_description)
2555         (arm_read_mprofile_description): Add declaration.
2556         * configure.tgt: Add new files.
2557
2558 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2559
2560         * top.c (new_ui_command): Open specified terminal just once.
2561
2562 2019-07-18  Tom Tromey  <tromey@adacore.com>
2563
2564         * symtab.c (main_name): Constify return type.
2565         * symfile.c (set_initial_language): Update.
2566         * symtab.h (main_name): Constify return type.
2567
2568 2019-07-17  Tom Tromey  <tom@tromey.com>
2569
2570         * tui/tui-winsource.c (tui_update_source_window)
2571         (tui_update_source_window_as_is)
2572         (tui_update_source_windows_with_line): Remove return.
2573         * tui/tui-disasm.c (tui_show_disassem)
2574         (tui_show_disassem_and_update_source): Remove return.
2575         * tui/tui.c (tui_reset): Remove return.
2576         * tui/tui-wingeneral.c
2577         (tui_check_and_display_highlight_if_needed): Remove return.
2578
2579 2019-07-17  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2582
2583 2019-07-17  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-winsource.h (struct tui_exec_info_window)
2586         (struct tui_source_window_base): Move from tui-data.h.
2587         * tui/tui-winsource.c: Move many method definitions from
2588         elsewhere.  Remove "structuring" comments.
2589         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2590         (tui_source_window_base::refresh_window): Move to
2591         tui-winsource.c.
2592         * tui/tui-win.c (tui_source_window_base::refresh_all)
2593         (tui_source_window_base::update_tab_width)
2594         (tui_source_window_base::set_new_height)
2595         (tui_source_window_base::do_make_visible_with_new_height): Move to
2596         tui-winsource.c.
2597         * tui/tui-source.h: Update.
2598         * tui/tui-source.c (tui_source_window_base::reset): Move to
2599         tui-winsource.c.
2600         * tui/tui-disasm.h: Update.
2601         * tui/tui-data.h (struct tui_exec_info_window): Move to
2602         tui-winsource.h.
2603         (struct tui_source_window_base): Likewise.
2604         * tui/tui-data.c (tui_source_window_base::clear_detail)
2605         (tui_source_window_base, ~tui_source_window_base): Move to
2606         tui-winsource.c.
2607
2608 2019-07-17  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-win.c (tui_resize_all)
2611         (tui_source_window_base::update_tab_width)
2612         (tui_adjust_win_heights): Update.
2613         (tui_win_info::make_invisible_and_set_new_height): Rename from
2614         make_invisible_and_set_new_height.
2615         * tui/tui-data.h (struct tui_win_info)
2616         <make_invisible_and_set_new_height>: New method.
2617
2618 2019-07-17  Tom Tromey  <tom@tromey.com>
2619
2620         * tui/tui.c: Update.
2621         * tui/tui-source.h (struct tui_source_window): Move from
2622         tui-data.h.
2623         * tui/tui-layout.c: Update.
2624         * tui/tui-disasm.c: Update.
2625         * tui/tui-data.h (struct tui_source_window): Move to
2626         tui-source.h.
2627
2628 2019-07-17  Tom Tromey  <tom@tromey.com>
2629
2630         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2631         tui-data.h.
2632         * tui/tui-data.h (struct tui_disasm_window): Move to
2633         tui-disasm.h.
2634
2635 2019-07-17  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui-regs.h (struct tui_data_item_window): Move from
2638         tui-data.h.
2639         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2640         * tui/tui-data.h (struct tui_data_item_window): Move to
2641         tui-regs.h.
2642         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2643
2644 2019-07-17  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui.c: Update.
2647         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2648         (tui_cmd_window::max_height): Move to tui-command.c.
2649         * tui/tui-layout.c: Update.
2650         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2651         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2652         tui-command.c.
2653         * tui/tui-command.h (struct tui_cmd_window): Move from
2654         tui-data.h.
2655         * tui/tui-command.c: Remove "structuring" comments.
2656         (tui_cmd_window::clear_detail)
2657         (tui_cmd_window::do_make_visible_with_new_height)
2658         (tui_cmd_window::max_height): Move from elsewhere.
2659
2660 2019-07-17  Tom Tromey  <tom@tromey.com>
2661
2662         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2663         Now static.
2664         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2665         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2666
2667 2019-07-17  Tom Tromey  <tom@tromey.com>
2668
2669         * tui/tui.c: Update.
2670         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2671         tui-regs.c.
2672         * tui/tui-windata.h: Remove file.
2673         * tui/tui-windata.c: Remove file.
2674         * tui/tui-win.c (tui_data_window::set_new_height)
2675         (tui_data_window::do_make_visible_with_new_height): Move to
2676         tui-regs.c.
2677         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2678         * tui/tui-regs.c: Remove "structuring" comments.
2679         (tui_data_window::first_data_item_displayed)
2680         (tui_data_window::delete_data_content_windows)
2681         (tui_data_window::erase_data_content)
2682         (tui_data_window::display_all_data)
2683         (tui_data_window::refresh_all)
2684         (tui_data_window::do_scroll_vertical)
2685         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2686         (tui_data_window::do_make_visible_with_new_height)
2687         (tui_data_window::refresh_window): Move from elsewhere.
2688         (_initialize_tui_regs): Move to end of file.
2689         * tui/tui-layout.c: Update.
2690         * tui/tui-hooks.c: Update.
2691         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2692         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2693         tui-regs.c.
2694         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2695
2696 2019-07-17  Tom Tromey  <tom@tromey.com>
2697
2698         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2699         seen.
2700
2701 2019-07-17  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-win.c (tui_source_window_base::set_new_height)
2704         (tui_source_window_base::do_make_visible_with_new_height): Use
2705         m_has_locator field directly.
2706         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2707         method.
2708         (struct tui_source_window_base) <has_locator>: Likewise.
2709
2710 2019-07-17  Tom Tromey  <tom@tromey.com>
2711
2712         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2713         Don't declare.
2714         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2715         Remove.
2716         * tui/tui-win.c (tui_source_window_base::set_new_height)
2717         (tui_source_window_base::set_new_height)
2718         (make_invisible_and_set_new_height)
2719         (tui_source_window_base::do_make_visible_with_new_height)
2720         (tui_source_window_base::do_make_visible_with_new_height):
2721         Update.
2722         * tui/tui-layout.c (show_source_disasm_command, show_data)
2723         (show_source_or_disasm_and_command): Update.
2724         * tui/tui-layout.c (show_layout): Update.
2725
2726 2019-07-17  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-layout.c (make_data_window): Remove.
2729         (show_data): Unify creation and re-initialization cases.
2730
2731 2019-07-17  Tom Tromey  <tom@tromey.com>
2732
2733         * tui/tui-layout.c (make_source_window, make_disasm_window):
2734         Remove.
2735         (show_data): Unify creation and re-initialization cases.
2736
2737 2019-07-17  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-layout.c (make_command_window): Remove.
2740         (show_source_disasm_command, show_source_or_disasm_and_command):
2741         Unify creation and re-initialization cases.
2742
2743 2019-07-17  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2746         creation and re-initialization cases.
2747
2748 2019-07-17  Tom Tromey  <tom@tromey.com>
2749
2750         * tui/tui-regs.c (tui_get_register): Return void.
2751
2752 2019-07-17  Tom Tromey  <tom@tromey.com>
2753
2754         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2755         Simplify.
2756
2757 2019-07-17  Tom Tromey  <tom@tromey.com>
2758
2759         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2760         resetting.
2761
2762 2019-07-17  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2765         * tui/tui-regs.c (tui_reg_layout): New function.
2766         (tui_show_registers, tui_reg_command): Use it.
2767         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2768         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2769         parameters.
2770         (tui_layout_command): Remove.
2771
2772 2019-07-17  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-layout.h (tui/tui-layout): Return void.
2775         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2776
2777 2019-07-17  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-layout.c (show_source_disasm_command, show_data):
2780         Update.
2781         (reset_locator): Remove.
2782         (show_source_or_disasm_and_command): Update.
2783
2784 2019-07-17  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-source.c (tui_source_window_base::reset): Remove
2787         win_type parameter.
2788         * tui/tui-layout.c (make_command_window, make_source_window)
2789         (make_disasm_window, make_data_window)
2790         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2791         (reset_locator, show_source_or_disasm_and_command): Update.
2792         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2793         win_type parameter.
2794         (struct tui_source_window_base) <reset>: Likewise.
2795
2796 2019-07-17  Tom Tromey  <tom@tromey.com>
2797
2798         * tui/tui-layout.c (show_source_disasm_command): Use
2799         reset_locator.
2800         (reset_locator): New function.
2801         (init_and_make_win): Remove.
2802         (show_source_or_disasm_and_command): Use reset_locator.
2803
2804 2019-07-17  Tom Tromey  <tom@tromey.com>
2805
2806         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2807         condition.
2808         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2809         Remove condition.
2810         * tui/tui-source.c (tui_source_window_base::reset): New method.
2811         * tui/tui-layout.c (make_command_window): Don't call
2812         init_and_make_win.
2813         (make_source_window, make_disasm_window): Don't call
2814         make_source_or_disasm_window.
2815         (make_data_window): Don't call init_and_make_win.  Change calling
2816         convention.
2817         (show_source_disasm_command, show_data): Simplify.
2818         (make_source_or_disasm_window): Remove.
2819         (show_source_or_disasm_and_command): Simplify.
2820         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2821         (struct tui_source_window_base) <reset>: Likewise.
2822         <execution_info>: Remove initializer.
2823         * tui/tui-data.c (tui_source_window_base): Initialize
2824         execution_info.
2825
2826 2019-07-17  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2829         variable.
2830
2831 2019-07-17  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui.c (tui_rl_other_window): Update.
2834         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2835         superclass method first.  Always iterate over regs_content.
2836         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2837         method.
2838         * tui/tui-win.c (tui_set_focus_command): Update.
2839
2840 2019-07-17  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui-win.c (tui_set_focus_command): Rename from
2843         tui_set_focus.  Call tui_enable.
2844         (tui_set_focus_command): Remove.
2845
2846 2019-07-17  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2849         refresh_window.
2850         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2851         touchwin.
2852         (tui_data_window::refresh_window): Call refresh_window on data
2853         items.  Always call superclass refresh_window.
2854         (tui_win_info::refresh): Remove.
2855         (tui_source_window_base::refresh_window): Update.
2856         (tui_refresh_all): Update.
2857         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2858         refresh_window.
2859         (show_source_or_disasm_and_command): Likewise.
2860         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2861         (struct tui_source_window_base) <refresh>: Likewise.
2862
2863 2019-07-17  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-winsource.c (tui_clear_source_content)
2866         (tui_show_source_content): Update.
2867         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2868         whether content is empty.
2869         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2870         Remove.
2871
2872 2019-07-17  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2875         window's contents.
2876         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2877         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2878
2879 2019-07-17  Tom Tromey  <tom@tromey.com>
2880
2881         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2882         (struct tui_data_item_window): Update.
2883
2884 2019-07-17  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2887         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2888         defines.
2889
2890 2019-07-17  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-winsource.h (tui_erase_source_content)
2893         (tui_clear_source_content): Remove "display_prompt" parameter.
2894         * tui/tui-winsource.c (tui_update_source_window_as_is)
2895         (tui_update_source_windows_with_addr): Update.
2896         (tui_clear_source_content): Remove "display_prompt" parameter.
2897         (tui_erase_source_content): Likewise.  Simplify.
2898         (tui_show_source_content): Update.
2899         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2900         * tui/tui-stack.c (tui_show_frame_info): Update.
2901         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2902         Remove defines.
2903
2904 2019-07-17  Tom Tromey  <tom@tromey.com>
2905
2906         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2907         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2908         parameter.
2909         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2910         parameter.
2911
2912 2019-07-17  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-winsource.c (tui_clear_source_content)
2915         (tui_show_source_content, tui_show_exec_info_content)
2916         (tui_clear_exec_info_content): Update.
2917         * tui/tui-stack.c (tui_show_locator_content): Update.
2918         (tui_show_frame_info): Update.
2919         * tui/tui-source.h (tui_source_window): Don't declare.
2920         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2921         from tui_source_is_displayed.
2922         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2923         Remove field.
2924         (struct tui_source_window_base) <content_in_use>: New field.  Now
2925         bool.
2926         (struct tui_source_window) <showing_source_p>: New method.
2927         (TUI_SRC_WIN): Change cast.
2928         * tui/tui-data.c (tui_initialize_static_data): Update.
2929
2930 2019-07-17  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2933         location_matches_p.
2934         * tui/tui-source.c (tui_source_window::location_matches_p): New
2935         method.
2936         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2937         method.
2938         * tui/tui-data.h (struct tui_source_window_base)
2939         <location_matches_p>: New method.
2940         (struct tui_source_window, struct tui_disasm_window)
2941         <location_matches_p>: Likewise.
2942
2943 2019-07-17  Tom Tromey  <tom@tromey.com>
2944
2945         * tui/tui-win.c (tui_set_win_height_command): Rename from
2946         tui_set_win_height.
2947         (tui_set_win_height_command): Remove.
2948
2949 2019-07-17  Tom Tromey  <tom@tromey.com>
2950
2951         * tui/tui-source.c (tui_source_window): New constructor.  Add
2952         observer.
2953         (~tui_source_window): New destructor.
2954         (tui_source_window::style_changed): New method.
2955         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2956         (tui_attach_detach_observers): Update.
2957         * tui/tui-data.h (struct tui_source_window): Make constructor not
2958         inline.  Add destructor.
2959         (struct tui_source_window) <style_changed>: New method.
2960         <m_observable>: New member.
2961
2962 2019-07-17  Tom Tromey  <tom@tromey.com>
2963
2964         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2965         * tui/tui-win.c (tui_resize_all): Fix typo.
2966
2967 2019-07-17  Tom Tromey  <tom@tromey.com>
2968
2969         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2970         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2971         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2972         * tui/tui-win.c (window_name_completer): Use foreach.
2973         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2974         (update_tab_width): Likewise.
2975         * tui/tui-layout.c (show_layout): Update.
2976         * tui/tui-data.h (class tui_window_iterator): New.
2977         (struct all_tui_windows): New.
2978         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2979
2980 2019-07-17  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2983         parameter.  Don't reference globals.
2984         (tui_reg_command): Update.
2985
2986 2019-07-17  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-regs.c (tui_show_registers): Simplify.
2989
2990 2019-07-17  Tom Tromey  <tom@tromey.com>
2991
2992         * tui/tui-regs.c (tui_show_registers): Update.
2993         (tui_show_register_group): Add win_info parameter.
2994
2995 2019-07-17  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2998         Rename from tui_display_reg_element_at_line.
2999         (tui_data_window::display_registers_from_line): Update.
3000         * tui/tui-data.h (struct tui_data_window)
3001         <display_reg_element_at_line>: New method.
3002
3003 2019-07-17  Tom Tromey  <tom@tromey.com>
3004
3005         * tui/tui-regs.h (tui_display_registers_from)
3006         (tui_display_registers_from_line): Don't declare.
3007         * tui/tui-windata.c (tui_data_window::display_all_data)
3008         (tui_data_window::refresh_all)
3009         (tui_data_window::do_scroll_vertical): Update.
3010         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3011         from tui_display_registers_from.
3012         (tui_display_reg_element_at_line): Update.
3013         (tui_data_window::display_registers_from_line): Rename from
3014         tui_display_registers_from_line.
3015         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3016         display_registers_from_line>: New methods.
3017
3018 2019-07-17  Tom Tromey  <tom@tromey.com>
3019
3020         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3021         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3022         from tui_erase_data_content.
3023         (tui_data_window::display_all_data)
3024         (tui_data_window::refresh_all)
3025         (tui_data_window::do_scroll_vertical): Update.
3026         * tui/tui-regs.c (tui_show_registers): Update.
3027         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3028         New method.
3029
3030 2019-07-17  Tom Tromey  <tom@tromey.com>
3031
3032         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3033         declare.
3034         * tui/tui-windata.c
3035         (tui_data_window::delete_data_content_windows): Rename from
3036         tui_delete_data_content_windows.
3037         (tui_data_window::display_all_data)
3038         (tui_data_window::do_scroll_vertical): Update.
3039         * tui/tui-data.h (struct tui_data_window)
3040         <delete_data_content_windows>: New method.
3041
3042 2019-07-17  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3045         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3046
3047 2019-07-17  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3050         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3051         from tui_display_all_data.
3052         * tui/tui-win.c
3053         (tui_data_window::do_make_visible_with_new_height): Update.
3054         * tui/tui-regs.c (tui_show_registers): Update.
3055         * tui/tui-layout.c (tui_set_layout): Update.
3056         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3057         method.
3058
3059 2019-07-17  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3062         * tui/tui-windata.c (tui_display_data_from): Remove.
3063         (tui_data_window::refresh_all): Update.
3064
3065 2019-07-17  Tom Tromey  <tom@tromey.com>
3066
3067         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3068         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3069         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3070         tui_display_registers_from_line.
3071         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3072         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3073         "force_display" parameter.
3074
3075 2019-07-17  Tom Tromey  <tom@tromey.com>
3076
3077         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3078         declare.
3079         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3080         Rename from tui_first_reg_element_no_inline.
3081         (tui_display_reg_element_at_line)
3082         (tui_display_registers_from_line): Update.
3083         * tui/tui-data.h (struct tui_data_window)
3084         <first_reg_element_no_inline>: New method.
3085
3086 2019-07-17  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-windata.c (tui_display_data_from)
3089         (tui_data_window::do_scroll_vertical): Update.
3090         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3091         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3092         Rename from tui_line_from_reg_element_no.
3093         (tui_display_registers_from_line): Update.
3094         * tui/tui-data.h (struct tui_data_window)
3095         <line_from_reg_element_no>: New method.
3096
3097 2019-07-17  Tom Tromey  <tom@tromey.com>
3098
3099         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3100         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3101         tui_last_regs_line_no.
3102         (tui_display_reg_element_at_line)
3103         (tui_display_registers_from_line): Update.
3104         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3105         method.
3106
3107 2019-07-17  Tom Tromey  <tom@tromey.com>
3108
3109         PR tui/24722:
3110         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3111         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3112         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3113         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3114         (tui_update_breakpoint_info): Likewise.
3115         * tui/tui-hooks.c (tui_event_create_breakpoint)
3116         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3117         Update.
3118
3119 2019-07-17  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3122
3123 2019-07-17  Tom Tromey  <tom@tromey.com>
3124
3125         * tui/tui-winsource.c (tui_update_source_window_as_is)
3126         (tui_update_source_windows_with_addr): Update.
3127         * tui/tui-source.h (tui_set_source_content)
3128         (tui_show_symtab_source): Add "win_info" parameter.
3129         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3130         parameter.
3131         (tui_show_symtab_source): Likewise.
3132
3133 2019-07-17  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-wingeneral.c
3136         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3137
3138 2019-07-17  Tom Tromey  <tom@tromey.com>
3139
3140         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3141         (struct tui_cmd_window) <can_scroll>: New method.
3142         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3143         method.
3144
3145 2019-07-17  Tom Tromey  <tromey@adacore.com>
3146
3147         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3148         do_field_signed>: Rename.  Change type of "value".
3149         * ui-out.c (ui_out::field_signed): Rename from field_int.
3150         Change type of "value".
3151         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3152         type of "value".
3153         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3154         do_field_int.  Change type of "value".
3155         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3156         do_field_int.  Change type of "value".
3157         * tracepoint.c (trace_status_mi, tfind_1)
3158         (print_one_static_tracepoint_marker): Update.
3159         * thread.c (print_thread_info_1, print_selected_thread_frame):
3160         Update.
3161         * stack.c (print_frame, print_frame_info): Update.
3162         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3163         Update.
3164         * source.c (print_source_lines_base): Update.
3165         * skip.c (info_skip_command): Update.
3166         * record-btrace.c (btrace_ui_out_decode_error)
3167         (btrace_call_history_src_line): Update.
3168         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3169         Update.
3170         * progspace.c (print_program_space): Update.
3171         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3172         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3173         do_field_int.  Change type of "value".
3174         * mi/mi-out.c (mi_ui_out::do_table_begin)
3175         (mi_ui_out::do_table_header): Update.
3176         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3177         type of "value".
3178         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3179         (mi_cmd_data_list_changed_registers, output_register)
3180         (mi_cmd_data_read_memory, mi_load_progress)
3181         (mi_cmd_trace_frame_collected): Update.
3182         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3183         Update.
3184         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3185         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3186         (mi_cmd_var_list_children, varobj_update_one): Update.
3187         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3188         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3189         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3190         * inferior.c (print_inferior): Update.
3191         * gdb_bfd.c (print_one_bfd): Update.
3192         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3193         Update.
3194         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3195         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3196         do_field_int.  Change type of "value".
3197         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3198         do_field_int.  Change type of "value".
3199         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3200         (print_one_breakpoint_location, print_it_catch_fork)
3201         (print_one_catch_fork, print_it_catch_vfork)
3202         (print_one_catch_vfork, print_it_catch_solib)
3203         (print_it_catch_exec, print_it_ranged_breakpoint)
3204         (print_mention_watchpoint, print_mention_masked_watchpoint)
3205         (bkpt_print_it, update_static_tracepoint): Update.
3206         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3207         * break-catch-syscall.c (print_it_catch_syscall): Update.
3208         * ada-tasks.c (print_ada_task_info): Update.
3209         * ada-lang.c (print_it_exception, print_mention_exception):
3210         Update.
3211
3212 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         PR breakpoints/24541
3215         * gdbarch.c: Regenerate.
3216         * gdbarch.h: Regenerate.
3217         * gdbarch.sh: Adjust return type and parameter types for
3218         'stap_adjust_register'.
3219         (i386_stap_adjust_register): Adjust signature and return new
3220         register name.
3221         * stap-probe.c (stap_parse_register_operand): Adjust use of
3222         'gdbarch_stap_adjust_register'.
3223
3224 2019-07-17  Tom Tromey  <tromey@adacore.com>
3225
3226         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3227         declare VEC.
3228         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3229         std::vector.
3230         (struct s390_process_info): Add initializers.
3231         (s390_add_process): Use new.
3232         (s390_linux_nat_target::low_forget_process): Use delete.
3233         (s390_linux_nat_target::low_new_fork)
3234         (s390_linux_nat_target::stopped_by_watchpoint)
3235         (s390_linux_nat_target::low_prepare_to_resume)
3236         (s390_linux_nat_target::insert_watchpoint)
3237         (s390_linux_nat_target::insert_hw_breakpoint)
3238         (s390_linux_nat_target::remove_watchpoint)
3239         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3240
3241 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3242
3243         * aarch64-fbsd-nat.c: Include regcache.h.
3244         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3245         argument.
3246         (aarch64_fbsd_nat_target::fetch_registers)
3247         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3248         variable.
3249         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3250
3251 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3252
3253         * fbsd-nat.c: Include gdbarch.h.
3254
3255 2019-07-15  Tom Tromey  <tromey@adacore.com>
3256
3257         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3258
3259 2019-07-15  Tom Tromey  <tromey@adacore.com>
3260
3261         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3262         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3263         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3264         * cli-out.c (cli_ui_out::do_field_int): New method.
3265         * ui-out.c (ui_out::field_unsigned): New method.
3266         * symfile.c (generic_load): Use field_unsigned.
3267         (print_transfer_performance): Likewise.
3268         * record-btrace.c (ui_out_field_uint): Remove.
3269         (btrace_call_history_insn_range, btrace_call_history): Use
3270         field_unsigned.
3271         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3272         field_unsigned.
3273         * ui-out.h (class ui_out) <field_unsigned>: New method.
3274         <do_field_unsigned>: Likewise.
3275
3276 2019-07-15  Tom Tromey  <tromey@adacore.com>
3277
3278         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3279         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3280         * target.c (flash_erase_command): Use field_string.
3281         * infrun.c (print_signal_received_reason): Use field_string.
3282         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3283         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3284         field_string.
3285         * ada-tasks.c (print_ada_task_info): Use field_string.
3286
3287 2019-07-15  Tom Tromey  <tromey@adacore.com>
3288
3289         * target.c (flash_erase_command): Use field_core_addr.
3290         * symfile.c (generic_load): Use field_core_addr.
3291         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3292         Use field_core_addr.
3293         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3294         field_core_addr.
3295
3296 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3297
3298         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3299         value if its desired type is smaller than a CORE_ADDR and signed.
3300
3301 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3302
3303         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3304         of changes to field names, and use new is_reference field to
3305         decide if a property is a reference or not.
3306         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3307         field.
3308         (struct dwarf2_property_baton): Update header comment, rename
3309         'referenced_type' to 'property_type' and update comments.
3310         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3311         default property type, store in property baton, update to take
3312         accound of renamed field.
3313         (read_func_scope): Update call to attr_to_dynamic_prop.
3314         (read_array_type): Likewise.
3315         (dwarf2_per_cu_addr_sized_int_type): New function.
3316         (read_subrange_index_type): Move type finding code to
3317         dwarf2_per_cu_addr_sized_int_type.
3318         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3319         (dwarf2_per_cu_addr_type): New function.
3320         (set_die_type): Update calls to attr_to_dynamic_prop.
3321
3322 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3323
3324         * dwarf2read.c (read_subrange_index_type): New function.
3325         (read_subrange_type): Move code into new function and call it.
3326         * gdbtypes.c (create_range_type): Add some asserts.
3327
3328 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3329
3330         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3331         update return statements.
3332         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3333         declaration, and update comment to match.
3334         * gdbtypes.c (resolve_dynamic_array): Update call to
3335         dwarf2_evaluate_property to match new return type.
3336
3337 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3338
3339         * valarith.c (value_subscripted_rvalue): Change lowerbound
3340         parameter type from int to LONGEST.
3341         * value.h (value_subscripted_rvalue): Likewise in declaration.
3342
3343 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3344
3345         * cli/cli-utils.c (info_print_command_completer): New function.
3346         * cli/cli-utils.h: Add 'completer.h' include, and forward
3347         declaration for 'struct cmd_list_element'.
3348         (info_print_command_completer): Declare.
3349         * stack.c (_initialize_stack): Add completer for 'info locals' and
3350         'info args'.
3351         * symtab.c (_initialize_symtab): Add completer for 'info
3352         variables' and 'info functions'.
3353         * NEWS: Mention completion for additional info commands.
3354
3355 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3356
3357         * cli/cli-utils.c (extract_info_print_args): Delete.
3358         (extract_arg_maybe_quoted): Delete.
3359         (info_print_options_defs): New variable.
3360         (make_info_print_options_def_group): New function.
3361         (extract_info_print_options): Define new function.
3362         * cli/cli-utils.h (extract_info_print_args): Delete.
3363         (struct info_print_options): New structure.
3364         (extract_info_print_options): Declare new function.
3365         * stack.c (info_locals_command): Update to use new
3366         extract_info_print_options, also add a header comment.
3367         (info_args_command): Likewise.
3368         * symtab.c (info_variables_command): Likewise.
3369         (info_functions_command): Likewise.
3370
3371 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3374         to extract string arguments.
3375         * common/common-utils.c (extract_string_maybe_quoted): New function.
3376         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3377
3378 2019-07-11  Tom Tromey  <tromey@adacore.com>
3379
3380         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3381         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3382         * top.h (gdbinit): Don't declare.
3383         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3384         into...
3385         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3386         * top.c (gdb_init): Don't call init_cli_cmds.
3387         (gdbinit): Remove.
3388         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3389
3390 2019-07-11  Tom Tromey  <tromey@adacore.com>
3391
3392         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3393         after it has been moved.
3394
3395 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3396
3397         * valops.c (value_must_coerce_to_target): Change return type to
3398         bool.
3399         * value.h (value_must_coerce_to_target): Likewise.
3400
3401 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3402
3403         * breakpoint.c (is_hardware_watchpoint): Remove
3404         forward-declaration.
3405         (is_masked_watchpoint): Change return type to bool.
3406         (is_tracepoint): Likewise.
3407         (is_breakpoint): Likewise.
3408         (is_hardware_watchpoint): Likewise.
3409         (is_watchpoint): Likewise.
3410         (is_no_memory_software_watchpoint): Likewise.
3411         (is_catchpoint): Likewise.
3412         (breakpoint_1): Make FILTER parameter's return type bool.
3413         is_masked_watchpoint): Change return type to bool.
3414         (save_breakpoints): Make FILTER parameter's return type bool.
3415         * breakpoint.h (is_breakpoint): Change return type to bool.
3416         (is_watchpoint): Likewise.
3417         (is_catchpoint): Likewise.
3418         (is_tracepoint): Likewise.
3419
3420 2019-07-10  Tom Tromey  <tom@tromey.com>
3421
3422         * defs.h: Don't include gdbarch.h.
3423         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3424         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3425         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3426         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3427         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3428         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3429         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3430         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3431         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3432         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3433         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3434         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3435         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3436         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3437         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3438         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3439         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3440         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3441         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3442         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3443         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3444         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3445         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3446         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3447         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3448         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3449         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3450
3451 2019-07-10  Tom Tromey  <tromey@adacore.com>
3452
3453         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3454         * breakpoint.c (init_ada_exception_breakpoint): Register as
3455         bp_catchpoint.
3456         (print_one_breakpoint_location, print_one_breakpoint): Use
3457         is_ada_exception_catchpoint.
3458         * ada-lang.c (class ada_catchpoint_location): Pass
3459         bp_loc_software_breakpoint to bp_location constructor.
3460         (is_ada_exception_catchpoint): New function.
3461
3462 2019-07-10  Tom Tromey  <tromey@adacore.com>
3463
3464         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3465         VEC.
3466         (struct arm_exidx_entry): New method operator<.
3467         (struct arm_exidx_data) <section_maps>: Change type.
3468         (arm_exidx_data_free): Remove.
3469         (arm_exidx_data_key): Change type.  Move lower.
3470         (arm_exidx_new_objfile): Update.
3471         (arm_compare_exidx_entries): Remove.
3472         (arm_find_exidx_entry, _initialize_arm_tdep)
3473
3474 2019-07-10  Tom Tromey  <tromey@adacore.com>
3475
3476         * solib-spu.c (ocl_program_data_key): Change type.
3477         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3478         Update.
3479
3480 2019-07-10  Tom Tromey  <tromey@adacore.com>
3481
3482         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3483         (struct solib_aix_inferior_data) <library_list>: Change type.
3484         (solib_aix_inferior_data_handle): Change type.
3485         (get_solib_aix_inferior_data): Update.
3486         (solib_aix_free_library_list): Remove.
3487         (library_list_start_library): Update.
3488         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3489         return type.
3490         (solib_aix_get_library_list)
3491         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3492         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3493
3494 2019-07-10  Tom Tromey  <tromey@adacore.com>
3495
3496         * solib-dsbt.c (struct dsbt_info): Add initializers.
3497         (solib_dsbt_pspace_data): Change type.
3498         (dsbt_pspace_data_cleanup): Remove.
3499         (get_dsbt_info, _initialize_dsbt_solib): Update.
3500
3501 2019-07-10  Tom Tromey  <tromey@adacore.com>
3502
3503         * spu-tdep.c (spu_overlay_data): Change type.
3504         (spu_get_overlay_table, spu_overlay_new_objfile)
3505         (_initialize_spu_tdep): Update.
3506
3507 2019-07-10  Tom Tromey  <tromey@adacore.com>
3508
3509         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3510         destructor.
3511         (dbx_objfile_data_key): Change type and declare later.
3512         (DBX_SYMFILE_INFO): Rewrite.
3513         * dbxread.c (dbx_objfile_data_key): Change type.
3514         (dbx_symfile_init): Update.
3515         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3516         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3517         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3518
3519 2019-07-10  Tom Tromey  <tromey@adacore.com>
3520
3521         * jit.c (jit_program_space_key): Change type.  Move lower.
3522         (get_jit_program_space_data): Update.
3523         (jit_program_space_data_cleanup): Remove.
3524         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3525         Update.
3526         (struct jit_program_space_data): Add initializers.
3527
3528 2019-07-10  Tom Tromey  <tromey@adacore.com>
3529
3530         * solib-darwin.c (struct darwin_info): Add initializers.
3531         (solib_darwin_pspace_data): Change type.
3532         (darwin_pspace_data_cleanup): Remove.
3533         (get_darwin_info, _initialize_darwin_solib): Update.
3534
3535 2019-07-10  Tom Tromey  <tromey@adacore.com>
3536
3537         * remote-sim.c (struct sim_inferior_data): Add initializers,
3538         constructor, and destructor.
3539         (sim_inferior_data_key): Change type.  Move lower.
3540         (check_for_duplicate_sim_descriptor): Update.
3541         (get_sim_inferior_data): Use new.  Update.
3542         (~sim_inferior_data_cleanup): Rename from
3543         sim_inferior_data_cleanup.  Simplify.
3544         (gdbsim_close_inferior, simulator_command)
3545         (sim_command_completer, _initialize_remote_sim): Update.
3546         (next_pid, INITIAL_PID): Move earlier.
3547
3548 2019-07-10  Tom Tromey  <tromey@adacore.com>
3549
3550         * python/python-internal.h (create_thread_object): Return
3551         gdbpy_ref.
3552         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3553         * python/py-inferior.c (struct threadlist_entry): Add
3554         constructor.
3555         <thread_obj>: Now a gdbpy_ref.
3556         (thread_to_thread_object): Update.
3557         (add_thread_object): Use new.
3558         (delete_thread_object): Use delete.
3559         (infpy_threads): Update.
3560         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3561         GIL.
3562
3563 2019-07-10  Tom Tromey  <tromey@adacore.com>
3564
3565         * valops.c (value_cast): Specialize error message for Ada.
3566
3567 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3568
3569         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3570
3571 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3572
3573         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3574         bpstat_should_step): Return bool, adjust comments.
3575         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3576         bpstat_should_step): Likewise.
3577
3578 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3579
3580         * features/Makefile: Use feature target descriptions for Arm.
3581         * features/arm/arm-core.c: Generate new file.
3582         * features/arm/arm-fpa.c: Likewise.
3583         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3584         * features/arm/arm-m-profile.c: Likewise.
3585         * features/arm/arm-vfpv2.c: Likewise.
3586         * features/arm/arm-vfpv3.c: Likewise.
3587         * features/arm/xscale-iwmmxt.c: Likewise.
3588         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3589
3590 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3591
3592         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3593         ptrace earlier.
3594
3595 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3596
3597         * features/aarch64-pauth.c: Regenerate.
3598
3599 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3600
3601         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3602         bool.
3603         (bpstat_what): Use false instead of 0.
3604
3605 2019-07-09  Pedro Alves  <palves@redhat.com>
3606
3607         * break-catch-throw.c (is_exception_catchpoint): New.
3608         * breakpoint.c (print_one_breakpoint_location): New parameter
3609         'raw_loc'.  Handle it.  Use
3610         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3611         looking at the breakpoint's type.
3612         (print_one_breakpoint): If handling "maint info breakpoints", also
3613         print locations of exception catchpoints.
3614         * breakpoint.h (is_exception_catchpoint): Declare.
3615
3616 2019-07-09  Pedro Alves  <palves@redhat.com>
3617
3618         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3619         "addr" field.
3620         (allocate_location_exception_catchpoint): New.
3621         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3622         (initialize_throw_catchpoint_ops): Install
3623         allocate_location_exception_catchpoint as allocate_location
3624         method.
3625         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3626         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3627         bp_loc_other.
3628         (breakpoint_address_is_meaningful): Delete.
3629         (bl_address_is_meaningful): New.
3630         (breakpoint_locations_match): Adjust comment.
3631         (bp_location_from_bp_type): New, factored out of...
3632         (bp_location::bp_location(breakpoint *)): ... this.
3633         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3634         factored out of...
3635         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3636         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3637         breakpoint_address_is_meaningful.
3638         (bp_locations_compare): Adjust comment.
3639         (update_global_location_list): Use bl_address_is_meaningful
3640         instead of breakpoint_address_is_meaningful.
3641         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3642         explicit.
3643         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3644         * python/py-breakpoint.c (bppy_get_location): No longer check
3645         whether location is null.
3646
3647 2019-07-09  Pedro Alves  <palves@redhat.com>
3648
3649         PR c++/15468
3650         * breakpoint.c (print_one_breakpoint_location): Remove
3651         single-location assert.
3652
3653 2019-07-09  Tom Tromey  <tom@tromey.com>
3654
3655         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3656         * configure: Rebuild.
3657         * configure.ac: Change common to gdbsupport.
3658         * gdbsupport: Rename from common.
3659         * acinclude.m4: Change common to gdbsupport.
3660         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3661         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3662         gdbsupport.
3663         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3664         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3665         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3666         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3667         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3668         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3669         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3670         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3671         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3672         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3673         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3674         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3675         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3676         coff-pe-read.c, command.h, compile/compile-c-support.c,
3677         compile/compile-c.h, compile/compile-cplus-symbols.c,
3678         compile/compile-cplus-types.c, compile/compile-cplus.h,
3679         compile/compile-loc2c.c, compile/compile.c, completer.c,
3680         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3681         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3682         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3683         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3684         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3685         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3686         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3687         features/aarch64-core.c, features/aarch64-fpu.c,
3688         features/aarch64-pauth.c, features/aarch64-sve.c,
3689         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3690         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3691         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3692         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3693         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3694         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3695         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3696         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3697         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3698         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3699         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3700         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3701         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3702         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3703         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3704         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3705         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3706         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3707         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3708         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3709         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3710         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3711         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3712         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3713         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3714         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3715         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3716         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3717         minsyms.c, mips-linux-tdep.c, namespace.h,
3718         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3719         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3720         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3721         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3722         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3723         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3724         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3725         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3726         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3727         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3728         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3729         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3730         procfs.c, producer.c, progspace.h, psymtab.h,
3731         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3732         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3733         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3734         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3735         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3736         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3737         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3738         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3739         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3740         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3741         target-memory.c, target.c, target.h, target/waitstatus.c,
3742         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3743         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3744         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3745         unittests/array-view-selftests.c,
3746         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3747         unittests/common-utils-selftests.c,
3748         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3749         unittests/format_pieces-selftests.c,
3750         unittests/function-view-selftests.c,
3751         unittests/lookup_name_info-selftests.c,
3752         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3753         unittests/mkdir-recursive-selftests.c,
3754         unittests/observable-selftests.c,
3755         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3756         unittests/parse-connection-spec-selftests.c,
3757         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3758         unittests/scoped_fd-selftests.c,
3759         unittests/scoped_mmap-selftests.c,
3760         unittests/scoped_restore-selftests.c,
3761         unittests/string_view-selftests.c, unittests/style-selftests.c,
3762         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3763         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3764         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3765         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3766         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3767         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3768
3769 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3772         bool value.
3773         (decode_digits_ordinary): Set explicit_line field in sal.
3774         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3775         symtab_and_line that was set on an explicit line number in
3776         assembler code.  Do always update the recorded symtab and line if
3777         we do skip the prologue.
3778
3779 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * breakpoint.c (set_breakpoint_location_function): Remove
3782         explicit_loc parameter.
3783         (momentary_breakpoint_from_master): Update call to
3784         set_breakpoint_location_function.
3785         (add_location_to_breakpoint): Likewise.
3786
3787 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3790         required features based on default bfd type when no specific bfd
3791         is present.
3792
3793 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3794
3795         * NEWS: Mention that GDB printf and eval commands can now print
3796         C-style and Ada-style convenience var strings without
3797         calling the inferior.
3798         * printcmd.c (printf_c_string): Locally print GDB internal var
3799         instead of transiting via the inferior.
3800         (printf_wide_c_string): Likewise.
3801
3802 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3803
3804         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3805
3806 2019-07-04  Tom Tromey  <tom@tromey.com>
3807
3808         PR tui/24724:
3809         * tui/tui-winsource.c (tui_clear_source_content): Update.
3810         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3811         (tui_update_breakpoint_info): Update.
3812         (tui_set_exec_info_content): Update.
3813         * tui/tui-source.c (tui_set_source_content_nil): Update.
3814         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3815         has_break.
3816         * tui/tui-data.h (enum tui_bp_flag): New.
3817         (tui_bp_flags): New enum flags type.
3818         (struct tui_source_element) <break_mode>: Change type.  Rename
3819         from has_break.
3820         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3821         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3822         constants.
3823         * tui/tui-winsource.h: Fix comment.
3824
3825 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3826
3827         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3828         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3829         (store_fpregs_to_thread)
3830         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3831         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3832         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3833         (IWMMXT_REGS_SIZE): Add define.
3834         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3835         (fetch_vfp_regs, store_vfp_regs)
3836         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3837         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3838
3839 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3840
3841         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3842         defines.
3843         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3844         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3845         (ARM_INT_REGISTER_SIZE): ...to this.
3846         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3847         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3848         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3849         (arm_linux_collect_gregset, supply_nwfpe_register)
3850         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3851         defines.
3852         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3853         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3854         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3855         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3856         (arm_return_in_memory, arm_store_return_value)
3857         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3858         (arm_record_ld_st_multiple): Likewise.
3859         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3860         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3861
3862 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3863
3864         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3865         AARCH64_DISPLACED_MODIFIED_INSNS.
3866         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3867         (aarch64_displaced_step_copy_insn): Likewise.
3868         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3869         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3870         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3871         ARM_DISPLACED_MODIFIED_INSNS.
3872         * arm-tdep.c (arm_gdbarch_init): Likewise.
3873         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3874         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3875         (struct arm_displaced_step_closure): Use
3876         ARM_DISPLACED_MODIFIED_INSNS.
3877
3878 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3879
3880         * features/Makefile: Remove unused xml files.
3881         * features/aarch64.xml: Remove.
3882         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3883         * features/i386/amd64-avx-avx512.xml: Remove.
3884         * features/i386/amd64-avx-linux.xml: Remove.
3885         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3886         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3887         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3888         * features/i386/amd64-avx-mpx.xml: Remove.
3889         * features/i386/amd64-avx.xml: Remove.
3890         * features/i386/amd64-linux.xml: Remove.
3891         * features/i386/amd64-mpx-linux.xml: Remove.
3892         * features/i386/amd64-mpx.xml: Remove.
3893         * features/i386/amd64.xml: Remove.
3894         * features/i386/i386-avx-avx512-linux.xml: Remove.
3895         * features/i386/i386-avx-avx512.xml: Remove.
3896         * features/i386/i386-avx-linux.xml: Remove.
3897         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3898         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3899         * features/i386/i386-avx-mpx-linux.xml: Remove.
3900         * features/i386/i386-avx-mpx.xml: Remove.
3901         * features/i386/i386-avx.xml: Remove.
3902         * features/i386/i386-linux.xml: Remove.
3903         * features/i386/i386-mmx-linux.xml: Remove.
3904         * features/i386/i386-mmx.xml: Remove.
3905         * features/i386/i386-mpx-linux.xml: Remove.
3906         * features/i386/i386-mpx.xml: Remove.
3907         * features/i386/i386.xml: Remove.
3908         * features/i386/x32-avx-avx512-linux.xml: Remove.
3909         * features/i386/x32-avx-linux.xml: Remove.
3910         * features/i386/x32-linux.xml: Remove.
3911
3912 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3913
3914         * regformats/aarch64.dat: Remove.
3915         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3916         * regformats/i386/amd64-avx-linux.dat: Remove.
3917         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3918         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3919         * regformats/i386/amd64-linux.dat: Remove.
3920         * regformats/i386/amd64-mpx-linux.dat: Remove.
3921         * regformats/i386/amd64.dat: Remove.
3922         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3923         * regformats/i386/i386-avx-linux.dat: Remove.
3924         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3925         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3926         * regformats/i386/i386-linux.dat: Remove.
3927         * regformats/i386/i386-mmx-linux.dat: Remove.
3928         * regformats/i386/i386-mpx-linux.dat: Remove.
3929         * regformats/i386/i386.dat: Remove.
3930         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3931         * regformats/i386/x32-avx-linux.dat: Remove.
3932         * regformats/i386/x32-linux.dat: Remove.
3933
3934 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3935
3936         * aarch64-tdep.c: Remove xml self tests.
3937         * amd64-linux-tdep.c: Likewise.
3938         * amd64-tdep.c: Likewise.
3939         * i386-linux-tdep.c: Likewise.
3940         * i386-tdep.c: Likewise.
3941
3942 2019-07-03  Pedro Alves  <palves@redhat.com>
3943
3944         PR cli/24732
3945         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3946         (pipe_cmd_option_defs): New.
3947         (make_pipe_cmd_options_def_group): New.
3948         (pipe_command): Use gdb::option::process_options.
3949         (pipe_command_completer): New function.
3950         (_initialize_cli_cmds): Install completer for "pipe" command.
3951
3952 2019-07-03  Pedro Alves  <palves@redhat.com>
3953
3954         * cli/cli-option.c (union option_value) <string>: New field.
3955         (struct option_def_and_value): Add ctor, move ctor, dtor and
3956         use DISABLE_COPY_AND_ASSIGN.
3957         (option_def_and_value::clear_value): New.
3958         (parse_option, save_option_value_in_ctx, get_val_type_str)
3959         (add_setshow_cmds_for_options): Handle var_string.
3960         * cli-option.h (union option_def::var_address) <string>: New
3961         field.
3962         (struct string_option_def): New.
3963         * maint-test-options.c (struct test_options_opts): Add default
3964         ctor and use DISABLE_COPY_AND_ASSIGN.
3965         <string_opt>: New field.
3966         (test_options_opts::~test_options_opts): New.
3967         (test_options_opts::dump): Also dump "-string".
3968         (test_options_option_defs): Install "string.
3969
3970 2019-07-03  Pedro Alves  <palves@redhat.com>
3971
3972         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3973         option_value with a null enumeration.
3974         (complete_options): Save the option values in the context.
3975         (save_option_value_in_ctx): New, factored out from ...
3976         (process_options): ... here.
3977         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3978         of the function.
3979         * maint-test-options.c (test_options_opts::dump): New, factored
3980         out from ...
3981         (maintenance_test_options_command_mode): ... here.
3982         (maintenance_test_options_command_completion_result): Delete.
3983         (maintenance_test_options_command_completion_text): Update
3984         comment.
3985         (maintenance_show_test_options_completion_result): Change
3986         prototype.  Just print
3987         maintenance_test_options_command_completion_text.
3988         (save_completion_result): New.
3989         (maintenance_test_options_completer_mode): Pass options context to
3990         complete_options, and then save a dump.
3991         (_initialize_maint_test_options): Use add_cmd to install "maint
3992         show test-options-completion-result".
3993
3994 2019-07-03  Pedro Alves  <palves@redhat.com>
3995
3996         * NEWS (New commands): Mention "with" and "maint with".
3997         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3998         (with_command, with_command_completer): New.
3999         (pipe_command): Adjust to new repeat_previous
4000         interface.
4001         (_initialize_cli_cmds): Install the "with" command and its "w"
4002         alias.
4003         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4004         declarations.
4005         * cli/cli-setshow.c (parse_cli_var_uinteger)
4006         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4007         argument strings for all var_types.
4008         (get_setshow_command_value_string): New, factored out from ...
4009         (do_show_command): ... this.
4010         * cli/cli-setshow.h: Include <string>.
4011         (get_setshow_command_value_string): Declare.
4012         * command.h (repeat_previous): Now returns const char *.  Adjust
4013         comment.
4014         * maint.c: Include "cli/cli-cmds.h".
4015         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4016         (_initialize_maint_cmds): Register the "maintenance with" command.
4017         * top.c (repeat_previous): Move bits from pipe_command here:
4018         Return the saved command line, if any; error out if there's no
4019         command to relaunch.
4020
4021 2019-07-03  Pedro Alves  <palves@redhat.com>
4022
4023         * NEWS (New commands): Mention "maint set/show test-settings"
4024         instead of "maint test-settings".
4025         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4026         (maintenance_test_settings_set_list): Rename to ...
4027         (maintenance_set_test_settings_list): ... this.
4028         (maintenance_test_settings_show_list): Rename to  ...
4029         (maintenance_show_test_settings_list): ... this.
4030         (maintenance_test_settings_cmd): Delete.
4031         (maintenance_test_settings_set_cmd): ...
4032         (maintenance_set_test_settings_cmd): ... this.
4033         (maintenance_test_settings_show_cmd): ...
4034         (maintenance_show_test_settings_cmd): ... this.
4035         (maintenance_test_settings_show_value_cmd):
4036         (maintenance_show_test_settings_value_cmd): ... this.
4037         (_initialize_maint_test_settings): No longer install the "maint
4038         test-settings" prefix command.  Rename "maint test-settings set"
4039         to "maint set test-settings", and "maint test-settings show" to
4040         "maint show test-settings".  Adjust all subcommands.
4041
4042 2019-07-03  Pedro Alves  <palves@redhat.com>
4043
4044         * maint-test-settings.c: Fix file's intro comment.  Replace all
4045         references to "test-options" with references to "test-settings",
4046         in comments.
4047
4048 2019-07-03  Pedro Alves  <palves@redhat.com>
4049
4050         * maint-test-settings.c (maintenance_test_settings_xxx)
4051         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4052         New.
4053         (maintenance_test_settings_enums): Use them.
4054         (maintenance_test_settings_enum): Default to
4055         maintenance_test_settings_xxx.
4056         (_initialize_maint_test_settings): Initialize
4057         MAINTENANCE_TEST_SETTINGS_FILENAME.
4058
4059 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4060
4061         * breakpoint.h (remove_breakpoints_inf): Change return type to
4062         void, move function documentation here.
4063         * breakpoint.c (remove_breakpoints_inf): Change return type to
4064         void, move function documentation to header.
4065
4066 2019-07-02  Pedro Alves  <palves@redhat.com>
4067
4068         * NEWS (Completion improvements): Mention "info threads".
4069         * thread.c (struct info_threads_opts, info_threads_option_defs)
4070         (make_info_threads_options_def_group): New.
4071         (info_threads_command): Use gdb::option::process_options.
4072         (info_threads_command_completer): New.
4073         (_initialize_thread): Use gdb::option::build_help to build the
4074         help text for "info threads".
4075
4076 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4077
4078         * defs.h (generic_load): Move from here...
4079         * symfile.h (generic_load): ... to here.  Rename name parameter
4080         to args.
4081         * symfile.c (generic_load): Add comment.
4082
4083 2019-07-01  Tom Tromey  <tromey@adacore.com>
4084
4085         * dwarf2read.c
4086         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4087         declaration of without_params.  Fix formatting.
4088
4089 2019-07-01  Tom Tromey  <tromey@adacore.com>
4090
4091         * ada-exp.y (find_primitive_type): Update.
4092         * ada-lang.h (ada_lookup_symbol): Update.
4093         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4094         parameter.
4095         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4096
4097 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4098
4099         PR breakpoints/24541
4100         * gdbarch.c: Regenerate.
4101         * gdbarch.h: Regenerate.
4102         * gdbarch.sh: Add 'stap_adjust_register'.
4103         * i386-tdep.c: Include '<unordered_set>'.
4104         (i386_stap_adjust_register): New function.
4105         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4106         * stap-probe.c (stap_parse_register_operand): Call
4107         'gdbarch_stap_adjust_register'.
4108
4109 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4110
4111         PR python/24742
4112         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4113         * python/python.c (do_start_initialization): Use 'xmalloc'
4114         instead of 'PyMem_Malloc'.
4115
4116 2019-06-28  Tom Tromey  <tromey@adacore.com>
4117
4118         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4119         for Ada.
4120
4121 2019-06-27  Tom Tromey  <tromey@adacore.com>
4122
4123         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4124         objfile_key.
4125         (arm_find_mapping_symbol, arm_record_special_symbol)
4126         (_initialize_arm_tdep): Update.
4127         (arm_objfile_data_free): Remove.
4128
4129 2019-06-27  Tom Tromey  <tromey@adacore.com>
4130
4131         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4132         to cp_print_static_field.
4133
4134 2019-06-26  Tom Tromey  <tromey@adacore.com>
4135
4136         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4137         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4138         declare.
4139
4140 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4141
4142         * features/aarch64-core.c (create_feature_aarch64_core):
4143         Regenerate.
4144         * features/aarch64-core.xml: Add cpsr flags.
4145
4146 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4147
4148         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4149         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4150
4151 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4152
4153         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4154         field.
4155         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4156         use.
4157         (arm_record_special_symbol): Don't insert new symbol in sorted
4158         position, push it at the end.
4159
4160 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4161
4162         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4163         (arm_mapping_symbol_s): Remove.
4164         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4165         (arm_mapping_symbol_vec): New typedef.
4166         (struct arm_per_objfile): Add constructor.
4167         <section_maps>: Change type to
4168         std::unique_ptr<arm_mapping_symbol_vec[]>.
4169         (arm_compare_mapping_symbols): Remove.
4170         (arm_find_mapping_symbol): Adjust to section_maps type change.
4171         (arm_objfile_data_free): Call delete on arm_per_objfile.
4172         (arm_record_special_symbol): Adjust to section_maps type change.
4173         Allocate arm_per_objfile with new.
4174
4175 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4176
4177         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4178         with the command prefix.
4179
4180 2019-06-25  Tom Tromey  <tom@tromey.com>
4181
4182         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4183         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4184
4185 2019-06-25  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4188         type.
4189         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4190         protected.
4191
4192 2019-06-25  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-winsource.c
4195         (tui_source_window_base::set_is_exec_point_at): Add check against
4196         LOA_ADDRESS.
4197
4198 2019-06-25  Tom Tromey  <tom@tromey.com>
4199
4200         * tui/tui-source.c (tui_set_source_content): Don't check before
4201         xfree.
4202         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4203
4204 2019-06-25  Tom Tromey  <tom@tromey.com>
4205
4206         * tui/tui-winsource.h (tui_update_source_window_as_is)
4207         (tui_alloc_source_buffer, tui_line_is_displayed)
4208         (tui_addr_is_displayed): Change type of win_info.
4209         * tui/tui-winsource.c (tui_update_source_window_as_is)
4210         (tui_clear_source_content, tui_show_source_line)
4211         (tui_show_source_content, tui_source_window_base::refill)
4212         (tui_source_window_base::set_is_exec_point_at)
4213         (tui_source_window_base::set_is_exec_point_at)
4214         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4215         (tui_alloc_source_buffer, tui_line_is_displayed)
4216         (tui_addr_is_displayed): Change type of win_info.  Update.
4217         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4218         (tui_source_window_base::do_make_visible_with_new_height):
4219         Update.
4220         * tui/tui-source.c (tui_set_source_content)
4221         (tui_set_source_content_nil)
4222         (tui_source_window::do_scroll_vertical): Update.
4223         * tui/tui-layout.c (show_layout): Update.
4224         * tui/tui-disasm.c (tui_set_disassem_content)
4225         (tui_disasm_window::do_scroll_vertical): Update.
4226         * tui/tui-data.h (tui_win_content): Remove.
4227         (struct tui_gen_win_info) <content, content_size>: Remove.
4228         (struct tui_source_element): Add initializers and destructor.
4229         (union tui_which_element, struct tui_win_element): Remove.
4230         (struct tui_source_window_base) <content>: New field.
4231         (struct tui_data_window): Remove destructor.
4232         (tui_alloc_content, tui_free_win_content)
4233         (tui_free_all_source_wins_content): Don't declare.
4234         * tui/tui-data.c (tui_initialize_static_data): Update.
4235         (init_content_element, tui_alloc_content): Remove.
4236         (~tui_gen_win_info): Update.
4237         (~tui_data_window, tui_free_all_source_wins_content)
4238         (tui_free_win_content, free_content, free_content_elements):
4239         Remove.
4240
4241 2019-06-25  Tom Tromey  <tom@tromey.com>
4242
4243         * tui/tui-winsource.h (tui_clear_source_content)
4244         (tui_erase_source_content, tui_show_source_content): Change type
4245         of win_info.
4246         * tui/tui-winsource.c (tui_clear_source_content)
4247         (tui_erase_source_content, tui_show_source_content): Change type
4248         of win_info.
4249         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4250         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4251         win_info.
4252         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4253         win_info.
4254         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4255
4256 2019-06-25  Tom Tromey  <tom@tromey.com>
4257
4258         * tui/tui-winsource.c (tui_clear_source_content)
4259         (tui_source_window_base::set_is_exec_point_at): Update.
4260         * tui/tui-source.c (tui_set_source_content_nil): Update.
4261         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4262         a bool.
4263         * tui/tui-data.c (init_content_element): Update.
4264
4265 2019-06-25  Tom Tromey  <tom@tromey.com>
4266
4267         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4268         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4269         * tui/tui-layout.c (init_and_make_win): Update.
4270         * tui/tui.h (enum tui_win_type): Update.
4271         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4272         tui_win_is_auxillary.
4273         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4274         tui_win_is_auxillary.
4275
4276 2019-06-25  Tom Tromey  <tom@tromey.com>
4277
4278         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4279         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4280         (tui_delete_data_content_windows, tui_display_all_data)
4281         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4282         Update.
4283         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4284         * tui/tui-regs.c (tui_last_regs_line_no)
4285         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4286         (tui_show_registers): Update.
4287         (tui_show_register_group): Return void.  Update.
4288         (tui_display_registers_from, tui_display_reg_element_at_line)
4289         (tui_display_registers_from_line, tui_check_register_values):
4290         Update.
4291         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4292         member.
4293         (struct tui_data_window) <regs_content>: Now a std::vector.
4294         <regs_content_count>: Remove.
4295         (tui_add_content_elements, tui_free_data_content): Don't declare.
4296         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4297         (init_content_element): Remove DATA_WIN case.  Add assert.
4298         (tui_add_content_elements): Remove.
4299         (tui_data_window): Update.
4300         (tui_free_data_content): Remove.
4301         (free_content_elements): Remove DATA_WIN case.
4302
4303 2019-06-25  Tom Tromey  <tom@tromey.com>
4304
4305         * tui/tui-data.c (tui_data_item_window): Update.
4306         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4307         * tui/tui-windata.c (tui_display_all_data)
4308         (tui_display_data_from_line): Update.
4309         (tui_check_data_values): Remove.
4310         * tui/tui-regs.c (tui_show_register_group)
4311         (tui_display_reg_element_at_line): Update.
4312         * tui/tui-hooks.c (tui_register_changed)
4313         (tui_refresh_frame_and_register_information): Call
4314         tui_check_register_values.
4315         * tui/tui-data.h (struct tui_data_window) <data_content,
4316         data_content_count, data_type>: Remove.
4317         (enum tui_data_type): Remove.
4318
4319         * tui/tui-data.c (tui_data_window::clear_detail)
4320         (~tui_data_window): Update.
4321
4322 2019-06-25  Tom Tromey  <tom@tromey.com>
4323
4324         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4325         declare.
4326         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4327         Rename from tui_first_data_item_displayed.  Update.
4328         (tui_data_window::refresh_all)
4329         (tui_data_window::do_scroll_vertical): Update.
4330         * tui/tui-data.h (struct tui_data_window)
4331         <first_data_item_displayed>: Declare new method.
4332
4333 2019-06-25  Tom Tromey  <tom@tromey.com>
4334
4335         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4336         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4337         contents...
4338         (tui_initialize_static_data): ...here.
4339
4340 2019-06-25  Tom Tromey  <tom@tromey.com>
4341
4342         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4343         (tui_display_registers_from, tui_check_register_values): Update.
4344         (tui_display_register): Remove win_info parameter; update.
4345         (tui_get_register): Change type of parameters.
4346         * tui/tui-data.h (struct tui_data_element): Remove.
4347         (union tui_which_element) <data>: Remove.
4348         <data_window>: Change type.
4349         (struct tui_data_item_window): New.
4350         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4351         case.  Add assert.
4352         (~tui_data_item_window): New destructor.
4353         (free_content_elements): Remove DATA_ITEM_WIN case.
4354
4355 2019-06-25  Tom Tromey  <tom@tromey.com>
4356
4357         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4358         Remove.
4359
4360 2019-06-25  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui-data.h (struct tui_command_element): Remove.
4363         (union tui_which_element) <command>: Remove.
4364         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4365         assert.
4366         (free_content_elements): Remove CMD_WIN case.
4367
4368 2019-06-25  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-layout.c (tui_set_layout): Update.
4371         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4372         * tui/tui-data.c (layout_def): Update.
4373
4374 2019-06-25  Tom Tromey  <tom@tromey.com>
4375
4376         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4377         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4378         (tui_source_window_base::set_new_height): Update.
4379         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4380         Update.
4381         (tui_set_locator_fullname, tui_set_locator_info)
4382         (tui_show_frame_info): Update.
4383         * tui/tui-source.c (tui_set_source_content)
4384         (tui_source_is_displayed): Update.
4385         * tui/tui-layout.c (show_source_disasm_command, show_data)
4386         (show_source_or_disasm_and_command): Update.
4387         * tui/tui-disasm.c (tui_set_disassem_content)
4388         (tui_get_begin_asm_address): Update.
4389         * tui/tui-data.h (struct tui_locator_element): Remove.
4390         (union tui_which_element) <locator>: Remove.
4391         (struct tui_locator_window): New.
4392         (tui_locator_win_info_ptr): Change return type.
4393         * tui/tui-data.c (_locator): Change type.
4394         (tui_locator_win_info_ptr): Change return type.
4395         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4396         (tui_alloc_content): Add assert.
4397
4398 2019-06-25  Tom Tromey  <tom@tromey.com>
4399
4400         * tui/tui-winsource.c
4401         (tui_exec_info_window::maybe_allocate_content): New method.
4402         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4403         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4404         (make_source_or_disasm_window): Add cast.
4405         * tui/tui-data.h (union tui_which_element) <simple_string>:
4406         Remove.
4407         (struct tui_source_info): New.
4408         (struct tui_source_window_base) <execution_info>: Change type.
4409         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4410         case, and add assert.
4411         (tui_alloc_content): Add assert.
4412
4413 2019-06-25  Tom Tromey  <tom@tromey.com>
4414
4415         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4416         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4417         * tui/tui-data.c (tui_alloc_win_info): Remove.
4418
4419 2019-06-25  Tom Tromey  <tom@tromey.com>
4420
4421         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4422         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4423         can_highlight.
4424
4425 2019-06-25  Tom Tromey  <tom@tromey.com>
4426
4427         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4428         make_visible_with_new_height method.
4429         (tui_win_info::make_visible_with_new_height): New method.
4430         (tui_source_window_base::do_make_visible_with_new_height)
4431         (tui_data_window::do_make_visible_with_new_height)
4432         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4433         (make_visible_with_new_height): Remove.
4434         (tui_resize_all, tui_adjust_win_heights): Use
4435         make_visible_with_new_height method.
4436         * tui/tui-data.h (struct tui_win_info)
4437         <do_make_visible_with_new_height, make_visible_with_new_height>:
4438         New methods.
4439         (struct tui_source_window_base, struct tui_data_window)
4440         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4441         methods.
4442
4443 2019-06-25  Tom Tromey  <tom@tromey.com>
4444
4445         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4446         method.
4447         (update_tab_width): Call update_tab_width method.
4448         * tui/tui-data.h (struct tui_win_info)
4449         (struct tui_source_window_base) <update_tab_width>: New methods.
4450
4451 2019-06-25  Tom Tromey  <tom@tromey.com>
4452
4453         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4454         parameter.
4455         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4456         parameter.
4457         (tui_gen_win_info::make_visible): Update.
4458         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4459         parameter.
4460         * tui/tui-data.h (enum tui_box): New enum.
4461         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4462
4463 2019-06-25  Tom Tromey  <tom@tromey.com>
4464
4465         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4466         init_and_make_win for EXEC_INFO_WIN.
4467         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4468         longer inline.
4469         (struct tui_win_info) <~tui_win_info>: Inline.
4470         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4471         Don't declare.
4472         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4473         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4474         Remove.
4475         (tui_initialize_static_data): Update.
4476         (~tui_gen_win_info): Handle more cleanup here.
4477         (~tui_source_window_base): Delete "execution_info".
4478         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4479
4480 2019-06-25  Tom Tromey  <tom@tromey.com>
4481
4482         * tui/tui-layout.c (make_command_window): Don't set
4483         can_highlight.
4484         (show_source_disasm_command): Call the reset method.
4485         (show_data): Don't set can_highlight.  Call the reset method.
4486         (tui_gen_win_info::reset): Rename from init_gen_win_info
4487         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4488         (show_source_or_disasm_and_command): Call the reset method.
4489         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4490         (struct tui_cmd_window): Set can_highlight.
4491
4492 2019-06-25  Tom Tromey  <tom@tromey.com>
4493
4494         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4495         from make_visible.
4496         (tui_make_visible, tui_make_invisible): Rewrite.
4497         (tui_win_info::make_visible): Remove.
4498         (tui_source_window_base::make_visible): Update.
4499         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4500         method.  Moved from...
4501         (struct tui_win_info) <make_visible>: ...here.
4502
4503 2019-06-25  Tom Tromey  <tom@tromey.com>
4504
4505         * tui/tui-winsource.c
4506         (tui_source_window_base::do_scroll_horizontal): Remove direction
4507         parameter.
4508         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4509         direction parameter.
4510         * tui/tui-win.c (tui_win_info::forward_scroll)
4511         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4512         (tui_win_info::right_scroll): Update.
4513         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4514         direction parameter.
4515         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4516         direction parameter.
4517         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4518         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4519         Remove direction parameter.
4520         (struct tui_source_window_base, struct tui_source_window)
4521         (struct tui_disasm_window, struct tui_data_window)
4522         (struct tui_cmd_window): Update.
4523
4524 2019-06-25  Tom Tromey  <tom@tromey.com>
4525
4526         * tui/tui-winsource.h (tui_set_exec_info_content)
4527         (tui_show_exec_info_content, tui_erase_exec_info_content)
4528         (tui_clear_exec_info_content, tui_update_exec_info): Change
4529         argument to tui_source_window_base.
4530         * tui/tui-winsource.c (tui_set_exec_info_content)
4531         (tui_show_exec_info_content, tui_erase_exec_info_content)
4532         (tui_clear_exec_info_content, tui_update_exec_info): Change
4533         argument to tui_source_window_base.
4534
4535 2019-06-25  Tom Tromey  <tom@tromey.com>
4536
4537         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4538         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4539
4540 2019-06-25  Tom Tromey  <tom@tromey.com>
4541
4542         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4543         check.
4544
4545 2019-06-25  Tom Tromey  <tom@tromey.com>
4546
4547         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4548         type to void.
4549         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4550         type to void.
4551         * tui/tui-source.c (tui_set_source_content): Update.
4552         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4553
4554 2019-06-25  Tom Tromey  <tom@tromey.com>
4555
4556         * tui/tui-win.c (window_name_completer, tui_set_focus)
4557         (tui_all_windows_info): Use name method.
4558         * tui/tui-data.h (struct tui_gen_win_info)
4559         (struct tui_source_window, struct tui_disasm_window)
4560         (struct tui_data_window, struct tui_cmd_window) <name>: New
4561         method.
4562         (tui_win_name): Don't declare.
4563         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4564         (tui_win_name): Remove.
4565
4566 2019-06-25  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui-winsource.h (tui_update_source_window)
4569         (tui_update_source_window_as_is): Change parameter type.
4570         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4571         to be a tui_source_window_base.
4572         (tui_update_source_window_as_is): Likewise.
4573         * tui/tui-win.c (make_visible_with_new_height): Update.
4574
4575 2019-06-25  Tom Tromey  <tom@tromey.com>
4576
4577         * tui/tui-winsource.c (tui_erase_source_content)
4578         (tui_show_source_content, tui_show_exec_info_content)
4579         (tui_erase_exec_info_content): Use refresh_window method.
4580         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4581         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4582         from tui_refresh_win.
4583         (tui_data_window::refresh_window): New method.
4584         (tui_win_info::refresh, tui_source_window_base::refresh)
4585         (tui_refresh_all): Use refresh_window method.
4586         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4587         method.
4588         * tui/tui-regs.c (tui_display_register): Call refresh_window
4589         method.
4590         * tui/tui-layout.c (show_source_disasm_command)
4591         (show_source_or_disasm_and_command): Call refresh_window method.
4592         * tui/tui-data.h (struct tui_gen_win_info)
4593         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4594         New method.
4595
4596 2019-06-25  Tom Tromey  <tom@tromey.com>
4597
4598         * tui/tui.c (tui_rl_other_window, tui_enable)
4599         (tui_is_window_visible, tui_get_command_dimension): Update.
4600         * tui/tui-winsource.c (tui_update_source_window_as_is)
4601         (tui_clear_source_content, tui_erase_source_content)
4602         (tui_show_source_line, tui_source_window_base::refill)
4603         (tui_source_window_base::do_scroll_horizontal)
4604         (tui_source_window_base::set_is_exec_point_at)
4605         (tui_update_breakpoint_info, tui_set_exec_info_content)
4606         (tui_alloc_source_buffer, tui_line_is_displayed)
4607         (tui_addr_is_displayed): Update.
4608         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4609         (tui_check_and_display_highlight_if_needed)
4610         (tui_win_info::make_visible, tui_win_info::refresh)
4611         (tui_refresh_all): Update.
4612         * tui/tui-windata.c (tui_first_data_item_displayed)
4613         (tui_delete_data_content_windows, tui_erase_data_content)
4614         (tui_display_all_data, tui_data_window::refresh_all)
4615         (tui_check_data_values): Update.
4616         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4617         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4618         (tui_win_info::backward_scroll, tui_refresh_all_win)
4619         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4620         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4621         (tui_source_window_base::set_new_height)
4622         (tui_data_window::set_new_height)
4623         (make_invisible_and_set_new_height)
4624         (make_visible_with_new_height, new_height_ok)
4625         (parse_scrolling_args): Update.
4626         * tui/tui-stack.c (tui_show_frame_info): Update.
4627         * tui/tui-source.c (tui_set_source_content)
4628         (tui_set_source_content_nil, tui_source_is_displayed)
4629         (tui_source_window::do_scroll_vertical): Update.
4630         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4631         (tui_display_registers_from, tui_display_reg_element_at_line)
4632         (tui_check_register_values, tui_reg_command): Update.
4633         * tui/tui-layout.c (tui_default_win_height)
4634         (show_source_disasm_command, show_data, init_and_make_win)
4635         (show_source_or_disasm_and_command): Update.
4636         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4637         (tui_redisplay_readline, tui_mld_flush)
4638         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4639         (tui_getc): Update.
4640         * tui/tui-disasm.c (tui_set_disassem_content)
4641         (tui_disasm_window::do_scroll_vertical): Update.
4642         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4643         Now virtual.
4644         (struct tui_win_info): Derive from tui_gen_win_info.
4645         <~tui_win_info>: Mark as override.
4646         <generic>: Remove member.
4647         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4648         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4649         (~tui_data_window, ~tui_win_info)
4650         (tui_free_all_source_wins_content): Update.
4651         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4652
4653 2019-06-25  Tom Tromey  <tom@tromey.com>
4654
4655         * tui/tui-layout.c (init_and_make_win): Use new.
4656         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4657         destructor, initializers.
4658         (tui_alloc_generic_win_info): Don't declare.
4659         * tui/tui-data.c (_locator): Add argument to constructor.
4660         (source_win, disasm_win): New globals.
4661         (exec_info): Remove.
4662         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4663         Update.
4664         (tui_alloc_generic_win_info): Remove.
4665         (init_content_element): Use new.
4666         (tui_win_info::tui_win_info): Update.
4667         (free_content_elements) <case DATA_WIN>: Use delete.
4668
4669 2019-06-25  Tom Tromey  <tom@tromey.com>
4670
4671         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4672         * tui/tui-windata.c (tui_first_data_item_displayed)
4673         (tui_delete_data_content_windows): Update.
4674         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4675         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4676         (tui_display_registers_from, tui_check_register_values): Update.
4677         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4678         pointer.
4679         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4680         window.
4681         (tui_free_data_content): Update.
4682         (free_content_elements) <case DATA_WIN>: Free the window.
4683
4684 2019-06-25  Tom Tromey  <tom@tromey.com>
4685
4686         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4687         Update.
4688         * tui/tui-layout.c (make_command_window)
4689         (show_source_disasm_command, show_data, init_and_make_win)
4690         (show_source_or_disasm_and_command): Update.
4691         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4692         method.
4693         <can_highight, is_highlighted>: Now bool.
4694         (tui_set_win_highlight): Don't declare.
4695         * tui/tui-data.c (tui_set_win_highlight): Remove.
4696
4697 2019-06-25  Tom Tromey  <tom@tromey.com>
4698
4699         * tui/tui-wingeneral.c (make_visible): Remove check of window
4700         type.
4701
4702 2019-06-25  Tom Tromey  <tom@tromey.com>
4703
4704         * tui/tui-win.c (tui_win_info::max_height)
4705         (tui_cmd_window::max_height): New methods.
4706         (new_height_ok): Call max_height.
4707         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4708         <max_height>: New method.
4709
4710 2019-06-25  Tom Tromey  <tom@tromey.com>
4711
4712         * tui/tui-win.c (tui_source_window_base::set_new_height)
4713         (tui_data_window::set_new_height): New methods.
4714         (make_invisible_and_set_new_height): Call set_new_height method.
4715         * tui/tui-data.h (struct tui_win_info)
4716         (struct tui_source_window_base, struct tui_data_window)
4717         <set_new_height>: New method.
4718
4719 2019-06-25  Tom Tromey  <tom@tromey.com>
4720
4721         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4722         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4723         tui_refresh_data_win.
4724         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4725         method.
4726         (tui_refresh_all_win): Call the refresh_all method.
4727         (tui_set_focus): Likewise.
4728         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4729         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4730         Likewise.
4731
4732 2019-06-25  Tom Tromey  <tom@tromey.com>
4733
4734         * tui/tui-winsource.h (tui_refill_source_window)
4735         (tui_set_is_exec_point_at): Don't declare.
4736         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4737         (tui_source_window_base::refill): Rename from
4738         tui_refill_source_window.
4739         (tui_source_window_base::do_scroll_horizontal): Update.
4740         (tui_source_window_base::set_is_exec_point_at): Rename from
4741         tui_set_is_exec_point_at.
4742         (tui_update_all_breakpoint_info): Update.
4743         * tui/tui-stack.c (tui_show_frame_info): Update.
4744         * tui/tui-layout.c (show_data): Add cast.
4745         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4746         * tui/tui-data.h (struct tui_source_window_base) <refill,
4747         set_is_exec_point_at>: New methods.
4748         (tui_source_windows, tui_add_to_source_windows): Update types.
4749         (tui_add_to_source_windows): Remove redundant declaration.
4750         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4751         (tui_source_windows): Change return type.
4752         (tui_clear_source_windows_detail): Update.
4753         (tui_add_to_source_windows): Change type of parameter.
4754         (tui_free_all_source_wins_content): Update.
4755
4756 2019-06-25  Tom Tromey  <tom@tromey.com>
4757
4758         * tui/tui-wingeneral.c (tui_win_info::refresh)
4759         (tui_source_window_base::refresh): New methods.
4760         (tui_refresh_all): Call the refresh method.
4761         * tui/tui-data.h (struct tui_win_info)
4762         (struct tui_source_window_base) <refresh>: New method.
4763
4764 2019-06-25  Tom Tromey  <tom@tromey.com>
4765
4766         * tui/tui.h (tui_is_window_visible): Return bool.
4767         * tui/tui.c (tui_is_window_visible): Return bool.
4768         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4769         (tui_make_visible, tui_make_invisible)
4770         (tui_win_info::make_visible)
4771         (tui_source_window_base::make_visible, make_all_visible)
4772         (tui_make_all_visible, tui_make_all_invisible): Update.
4773         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4774         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4775         bool.
4776         (struct tui_win_info, struct tui_source_window_base)
4777         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4778         * tui/tui-data.c (tui_init_generic_part): Update.
4779
4780 2019-06-25  Tom Tromey  <tom@tromey.com>
4781
4782         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4783         (tui_source_window_base::make_visible): New methods.
4784         (make_all_visible): Make method call.
4785         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4786         (struct tui_source_window_base, struct tui_cmd_window): Override
4787         make_visible.
4788         (tui_win_is_source_type): Don't declare.
4789         * tui/tui-data.c (tui_win_is_source_type): Remove.
4790
4791 2019-06-25  Tom Tromey  <tom@tromey.com>
4792
4793         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4794         NULL check.
4795
4796 2019-06-25  Tom Tromey  <tom@tromey.com>
4797
4798         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4799         Inline constructor.  Add initializers for members.
4800         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4801         constructors; now inline in class.
4802
4803 2019-06-25  Tom Tromey  <tom@tromey.com>
4804
4805         * tui/tui-regs.c (tui_show_registers): Update.
4806         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4807         bool.
4808         * tui/tui-data.c (tui_data_window::clear_detail)
4809         (tui_data_window): Update.
4810
4811 2019-06-25  Tom Tromey  <tom@tromey.com>
4812
4813         * tui/tui-windata.c (tui_display_all_data)
4814         (tui_display_data_from_line, tui_display_data_from)
4815         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4816         Update.
4817         * tui/tui-regs.c (tui_last_regs_line_no)
4818         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4819         (tui_show_registers, tui_show_register_group)
4820         (tui_display_registers_from, tui_display_reg_element_at_line)
4821         (tui_display_registers_from_line, tui_check_register_values)
4822         (tui_reg_next, tui_reg_prev): Update.
4823         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4824         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4825         tui_data_window.
4826         (struct tui_win_info) <detail>: Remove.  Add new fields from
4827         tui_data_info.
4828         (TUI_DATA_WIN): Add cast.
4829         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4830         (~tui_data_window): Simplify.
4831
4832 2019-06-25  Tom Tromey  <tom@tromey.com>
4833
4834         * tui/tui-layout.c (show_source_disasm_command)
4835         (show_source_or_disasm_and_command): Update.
4836         * tui/tui-io.c (update_cmdwin_start_line)
4837         (tui_redisplay_readline): Update.
4838         * tui/tui-data.h (struct tui_command_info): Remove.
4839         (struct tui_win_info) <detail>: Remove command_info member.
4840         (struct tui_data_window) <start_line>: New member, from
4841         tui_command_info.
4842         (TUI_CMD_WIN): Add casts.
4843
4844 2019-06-25  Tom Tromey  <tom@tromey.com>
4845
4846         * tui/tui-winsource.c (tui_update_source_window)
4847         (tui_refill_source_window)
4848         (tui_source_window_base::do_scroll_horizontal)
4849         (tui_update_breakpoint_info, tui_set_exec_info_content)
4850         (tui_show_exec_info_content, tui_erase_exec_info_content)
4851         (tui_clear_exec_info_content): Update.
4852         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4853         Update.
4854         * tui/tui-win.c (make_invisible_and_set_new_height)
4855         (make_visible_with_new_height): Update.
4856         * tui/tui-source.c (tui_set_source_content)
4857         (tui_show_symtab_source): Update.
4858         * tui/tui-layout.c (extract_display_start_addr)
4859         (show_source_disasm_command, show_data)
4860         (make_source_or_disasm_window)
4861         (show_source_or_disasm_and_command): Update.
4862         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4863         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4864         "gdbarch".
4865         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4866         to tui_source_window_base.
4867         (struct tui_win_info) <detail>: Remove source_info member.
4868         (struct tui_source_window_base) <has_locator>: Inline.
4869         Move contents from tui_source_info; rename has_locator member to
4870         m_has_locator.
4871         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4872         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4873         header file.
4874         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4875         Simplify.
4876         (tui_free_all_source_wins_content): Cast to
4877         tui_source_window_base.
4878
4879 2019-06-25  Tom Tromey  <tom@tromey.com>
4880
4881         * tui/tui-win.c (make_invisible_and_set_new_height)
4882         (make_visible_with_new_height): Call has_locator method.
4883         * tui/tui-layout.c (show_source_disasm_command, show_data)
4884         (show_source_or_disasm_and_command): Update for bool change.
4885         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4886         (tui_win_info) <has_locator>: New method.
4887         (struct tui_source_window_base) <has_locator>: New method.
4888         (tui_win_has_locator): Don't declare.
4889         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4890         from tui_win_has_locator.
4891         (tui_source_window_base): Use false, not FALSE.
4892
4893 2019-06-25  Tom Tromey  <tom@tromey.com>
4894
4895         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4896         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4897         clear_detail method directly.
4898         (tui_clear_win_detail): Remove.
4899
4900 2019-06-25  Tom Tromey  <tom@tromey.com>
4901
4902         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4903         "this", not TUI_DISASM_WIN.
4904
4905 2019-06-25  Tom Tromey  <tom@tromey.com>
4906
4907         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4908         declare.
4909         * tui/tui-winsource.c
4910         (tui_source_window_base::do_scroll_horizontal): Rename from
4911         tui_horizontal_source_scroll.
4912         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4913         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4914         from tui_vertical_data_scroll.
4915         * tui/tui-win.h (tui_scroll): Don't declare.
4916         * tui/tui-win.c (tui_win_info::forward_scroll)
4917         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4918         (tui_win_info::right_scroll): Rename and update.
4919         (tui_scroll_forward_command, tui_scroll_backward_command)
4920         (tui_scroll_left_command, tui_scroll_right_command): Update.
4921         (tui_scroll): Remove.
4922         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4923         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4924         from tui_vertical_source_scroll.
4925         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4926         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4927         from tui_vertical_disassem_scroll.
4928         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4929         do_scroll_horizontal>: New methods.
4930         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4931         Likewise.
4932         (struct tui_source_window_base): Add do_scroll_horizontal.
4933         (struct tui_source_window, struct tui_disasm_window): Add
4934         do_scroll_vertical.
4935         (struct tui_data_window, struct tui_cmd_window): Add
4936         do_scroll_horizontal and do_scroll_vertical.
4937         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4938
4939 2019-06-25  Tom Tromey  <tom@tromey.com>
4940
4941         * tui/tui-data.h (struct tui_source_window_base): New struct.
4942         (struct tui_source_window): Derive from tui_source_window_base.
4943         (struct tui_disasm_window): New struct.
4944         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4945         from tui_source_window::clear_detail.
4946         (tui_source_window_base): Rename from tui_source_window.
4947         (~tui_source_window_base): Rename from ~tui_source_window.
4948         (tui_alloc_win_info): Create a tui_disasm_window.
4949
4950 2019-06-25  Tom Tromey  <tom@tromey.com>
4951
4952         * tui/tui-data.h (struct tui_source_window)
4953         (struct tui_data_window): Declare destructors.
4954         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4955         destructors.
4956         (tui_win_info): Simplify.
4957
4958 2019-06-25  Tom Tromey  <tom@tromey.com>
4959
4960         * tui/tui-winsource.c (tui_display_main)
4961         (tui_update_source_windows_with_addr)
4962         (tui_update_all_breakpoint_info): Update.
4963         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4964         (new_height_ok, parse_scrolling_args): Update.
4965         * tui/tui-stack.c (tui_show_frame_info): Update.
4966         * tui/tui-data.h (struct tui_list): Remove.
4967         (tui_source_windows): Return a reference to a std::vector.
4968         * tui/tui-data.c (source_windows): Now a std::vector.
4969         (tui_source_windows): Change return type.
4970         (tui_clear_source_windows): Rewrite.
4971         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4972         (tui_free_all_source_wins_content): Rewrite.
4973
4974 2019-06-25  Tom Tromey  <tom@tromey.com>
4975
4976         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4977         (struct tui_data_window, struct tui_cmd_window): Declare
4978         clear_detail method.
4979         * tui/tui-data.c (tui_source_window::clear_detail)
4980         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4981         methods.
4982         (tui_clear_win_detail): Simplify.
4983
4984 2019-06-25  Tom Tromey  <tom@tromey.com>
4985
4986         * tui/tui-layout.c (make_source_window, make_disasm_window)
4987         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4988         Return the new window.
4989         (show_source_disasm_command, show_data)
4990         (show_source_or_disasm_and_command): Update.
4991
4992 2019-06-25  Tom Tromey  <tom@tromey.com>
4993
4994         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4995         parameter.  Return the new window.
4996         (show_source_disasm_command): Update and remove NULL check.
4997         (show_source_or_disasm_and_command): Update.
4998
4999 2019-06-25  Tom Tromey  <tom@tromey.com>
5000
5001         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5002
5003 2019-06-25  Tom Tromey  <tom@tromey.com>
5004
5005         * tui/tui-data.h (struct tui_win_info): Make constructor
5006         protected.  Make destructor virtual.  Add initializers.
5007         (tui_source_window, tui_data_window, tui_cmd_window): New
5008         classes.
5009         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5010         constructor.  Add "type" parameter.
5011         (tui_source_window, tui_data_window, tui_cmd_window): New
5012         constructors.
5013         (tui_alloc_win_info): Instantiate the appropriate subclass.
5014
5015 2019-06-25  Tom Tromey  <tom@tromey.com>
5016
5017         * tui/tui-win.c (tui_resize_all): Use delete.
5018         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5019         destructor.
5020         (tui_free_window): Don't declare.
5021         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5022         Update.
5023
5024 2019-06-25  Tom Tromey  <tom@tromey.com>
5025
5026         * tui/tui-data.h (struct tui_win_info): Add constructor.
5027         * tui/tui-data.c (tui_alloc_win_info): Use new.
5028         (tui_free_window): Use delete.
5029
5030 2019-06-22  Tom Tromey  <tom@tromey.com>
5031
5032         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5033         declare.
5034         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5035
5036 2019-06-22  Tom Tromey  <tom@tromey.com>
5037
5038         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5039         declare.
5040         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5041
5042 2019-06-22  Tom de Vries  <tdevries@suse.de>
5043
5044         * dwarf2read.c (create_addrmap_from_aranges)
5045         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5046         instead of '%zu'.
5047
5048 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5049
5050         * dwarf2read.h (dwarf2_section_info_def): Remove.
5051         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5052         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5053         std::vector<dwarf2_section_info>.
5054         (struct dwo_file) <~dwo_file>: Remove.
5055         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5056         types field.
5057         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5058         (dwarf2_read_debug_names): Likewise.
5059         (create_debug_types_hash_table): Change parameter type to
5060         array_view, adjust code accordingly.
5061         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5062         (partial_die_info::fixup): Likewise.
5063         (determine_prefix): Likewise.
5064         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5065
5066 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5067
5068         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5069         gdb_bfd_ref_ptr.
5070         <~dwo_file>: Remove call to gdb_bfd_unref.
5071         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5072         gdb_bfd_ref_ptr::get.
5073
5074 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5075
5076         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5077         type to htab_up.
5078         * dwarf2read.c (struct dwo_file): Initialize fields.
5079         <~dwo_file>: New.
5080         (free_dwo_file): Remove, move content to ~dwo_file.
5081         (struct dwo_file_deleter): Remove.
5082         (dwo_file_up>: Remove custom deleter.
5083         (free_dwo_files): Remove.
5084         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5085         dwo_files.
5086         (process_skeletonless_type_units): Call unique_ptr::get.
5087         (allocate_dwo_file_hash_table): Add deleter to created hash
5088         table.  Change return type to htab_up.
5089         (lookup_dwo_file_slot): Don't memset dwo_file, call
5090         unique_ptr::get.
5091         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5092         (create_dwo_unit_in_dwp_v2): Likewise.
5093         (open_and_init_dwo_file): Likewise.
5094         (free_dwo_file_from_slot): Remove.
5095
5096 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5097
5098         * dwarf2read.h (struct dwarf2_section_info) <readin,
5099         is_virtual>: Change type to bool.
5100         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5101         true instead of 1.
5102
5103 2019-06-19  Tom Tromey  <tom@tromey.com>
5104
5105         * tui/tui-data.h (tui_init_content_element): Don't declare.
5106
5107 2019-06-19  Tom Tromey  <tom@tromey.com>
5108
5109         * tui/tui-data.h (tui_init_win_info): Don't declare.
5110
5111 2019-06-19  Tom de Vries  <tdevries@suse.de>
5112
5113         * dwarf2read.h (abstract_to_concrete): Change type to
5114         std::unordered_map<sect_offset, std::vector<sect_offset>,
5115         gdb::hash_enum<sect_offset>>.
5116
5117 2019-06-19  Tom Tromey  <tromey@adacore.com>
5118
5119         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5120         EVAL_AVOID_SIDE_EFFECTS specially.
5121
5122 2019-06-19  Tom Tromey  <tromey@adacore.com>
5123
5124         * source-cache.c (highlighter): New global.
5125         (source_cache::get_source_lines): Create a highlighter on demand.
5126
5127 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5128
5129         * defs.h (deprecated_interactive_hook): Delete declaration.
5130         * interps.c (clear_interpreter_hooks): Remove use of
5131         deprecated_interactive_hook.
5132         * top.c (deprecated_interactive_hook): Delete definition.
5133         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5134
5135 2019-06-18  Tom de Vries  <tdevries@suse.de>
5136
5137         PR gdb/24515
5138         * dwarf2read.h (abstract_to_concrete): Change type from
5139         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5140         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5141         * dwarf2read.c (read_variable): Update.
5142         (dwarf2_fetch_die_loc_sect_off): Update.
5143
5144 2019-06-17  Tom de Vries  <tdevries@suse.de>
5145
5146         PR gdb/24617
5147         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5148         accessing parent[parent_len - 1].
5149
5150 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5151
5152         PR gdb/24364
5153         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5154         call dtrace_process_dof with NULL dof.
5155
5156 2019-06-16  Tom de Vries  <tdevries@suse.de>
5157
5158         PR gdb/24445
5159         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5160
5161 2019-06-16  Tom Tromey  <tom@tromey.com>
5162
5163         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5164         (make_all_visible): Use address of member.
5165
5166 2019-06-16  Tom Tromey  <tom@tromey.com>
5167
5168         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5169         (tui_free_window, free_content, free_content_elements): Remove
5170         unnecessary cast.
5171         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5172         cast.
5173         * tui/tui-regs.c (tui_show_register_group)
5174         (tui_display_registers_from, tui_display_reg_element_at_line):
5175         Remove unnecessary cast.
5176
5177 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * linux-nat.c (normal_mask): Delete.
5180         (_initialize_linux_nat): Don't initialise normal_mask.
5181
5182 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5183
5184         PR gdb/24445
5185         * dwarf-index-write.h (write_psymtabs_to_index): Add
5186         dwz_basename parameter.
5187         * dwarf-index-write.c (write_gdbindex): Move file writing to
5188         write_gdbindex_1.  Change return type void.
5189         (assert_file_size): Move up, remove filename parameter.
5190         (write_gdbindex_1): New function.
5191         (write_debug_names): Change return type to void, call
5192         assert_file_size.
5193         (struct index_wip_file): New struct.
5194         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5195         file logic to index_wip_file.  Write index for dwz file if
5196         needed.
5197         (save_gdb_index_command): Pass basename of dwz file, if present.
5198         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5199         build-id of dwz file, if present.
5200         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5201         (dwarf2_get_dwz_file): Likewise.
5202         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5203         (dwarf2_get_dwz_file): Likewise.
5204
5205 2019-06-16  Tom Tromey  <tom@tromey.com>
5206
5207         * coffread.c (process_coff_symbol): Use xstrdup.
5208         * value.c (create_internalvar): Use xstrdup.
5209
5210 2019-06-16  Tom Tromey  <tom@tromey.com>
5211
5212         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5213         * breakpoint.c (stopin_command, stopat_command)
5214         (until_break_command, decode_location_default): Remove unnecessary
5215         cast.
5216         * utils.c (subset_compare): Remove unnecessary cast.
5217         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5218         cast.
5219         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5220         cast.
5221         * infcmd.c (path_command): Remove unnecessary cast.
5222         * coffread.c (decode_type): Remove unnecessary cast.
5223         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5224         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5225         * tui/tui-stack.c (tui_show_locator_content)
5226         (tui_show_frame_info): Remove unnecessary cast.
5227         * tui/tui-win.c (tui_scroll_forward_command)
5228         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5229         (parse_scrolling_args): Remove unnecessary cast.
5230         * tui/tui-data.c (init_win_info, tui_del_window)
5231         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5232         (free_content_elements): Remove unnecessary cast.
5233         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5234         unnecessary cast.
5235         * tui/tui-source.c (tui_set_source_content)
5236         (tui_vertical_source_scroll): Remove unnecessary cast.
5237         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5238         cast.
5239         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5240         * tui/tui-regs.c (tui_display_registers_from)
5241         (tui_display_register): Remove unnecessary cast.
5242         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5243         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5244         (make_visible): Remove unnecessary cast.
5245         * tui/tui-winsource.c (tui_erase_source_content)
5246         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5247         unnecessary cast.
5248         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5249         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5250         * stabsread.c (read_type, read_array_type, read_range_type):
5251         Remove unnecessary cast.
5252         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5253         (parse_symbol, parse_type, upgrade_type, parse_external)
5254         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5255         unnecessary cast.
5256         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5257
5258 2019-06-16  Tom Tromey  <tom@tromey.com>
5259
5260         * tui/tui-data.c (tui_alloc_generic_win_info)
5261         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5262         checks.
5263
5264 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5265             Andrew Burgess  <andrew.burgess@embecosm.com>
5266
5267         * f-typeprint.c (f_print_type): Don't return early for not
5268         associated or not allocated types.
5269         (f_type_print_varspec_suffix): Add print_rank parameter and print
5270         ranks of array types in case they dangling.
5271         (f_type_print_base): Add print_rank parameter.
5272
5273 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5274
5275         * NEWS: Mention new MI commands.
5276         * break-catch-throw.c (enum exception_event_kind): Move to
5277         breakpoint.h.
5278         (print_mention_exception_catchpoint): Output text as a single
5279         message.
5280         (catch_exception_command_1): Rename to...
5281         (catch_exception_event): ...this, make non-static, update header
5282         command, and change some parameter types.
5283         (catch_catch_command): Update for changes to
5284         catch_exception_command_1.
5285         (catch_throw_command): Likewise.
5286         (catch_rethrow_command): Likewise.
5287         * breakpoint.c (enum exception_event_kind): Delete.
5288         * breakpoint.h (enum exception_event_kind): Moved here from
5289         break-catch-throw.c.
5290         (catch_exception_event): Declare.
5291         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5292         (mi_cmd_catch_throw): New function.
5293         (mi_cmd_catch_rethrow): New function.
5294         (mi_cmd_catch_catch): New function.
5295         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5296         'catch-catch' entries.
5297         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5298         (mi_cmd_catch_rethrow): Declare.
5299         (mi_cmd_catch_catch): Declare.
5300
5301 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5302
5303         * annotate.c (annotate_source_line): Change return type to void,
5304         update implementation to match.
5305         * annotate.h (annotate_source_line): Change return type to void,
5306         update header comment.
5307         * stack.c (print_frame_info): Don't change what frame information
5308         is printed based on whether annotations are on or not.
5309
5310 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5311
5312         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5313         (annotate_source): Make static.
5314         (annotate_source_line): Moved from source.c and renamed from
5315         identify_source_line.  Update the return type.
5316         * annotate.h (annotate_source): Delete declaration.
5317         (annotate_source_line): Declaration moved from source.h, and
5318         renamed from identify_source_line.  Return type updated.
5319         * source.c (identify_source_line): Moved to annotate.c and renamed
5320         to annotate_source_line.
5321         (info_line_command): Remove check of annotation_level.
5322         * source.h (identify_source_line): Move declaration to annotate.h
5323         and rename to annotate_source_line.
5324         * stack.c: Add 'annotate.h' include.
5325         (print_frame_info): Remove check of annotation_level before
5326         calling annotate_source_line.
5327
5328 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5329
5330         * source-cache.c (source_cache::get_plain_source_lines): Use
5331         open_source_file_with_line_charpos instead of just
5332         open_source_file, remove call to find_source_lines.
5333         (source_cache::get_source_lines): Likewise.
5334         * source.c (find_source_lines): Make static.
5335         (get_filename_and_charpos): Renamed into...
5336         (open_source_file_with_line_charpos): ..this along with changes to
5337         return a scoped_fd, and some other minor clean ups.
5338         (identify_source_line): Use open_source_file_with_line_charpos.
5339         (search_command_helper): Use open_source_file_with_line_charpos
5340         instead of just open_source_file, remove call to
5341         find_source_lines.
5342         * source.h (open_source_file_with_line_charpos): Declare new
5343         function.
5344         (find_source_lines): Delete declaration.
5345
5346 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5347
5348         * source.c (get_filename_and_charpos): Remove fullname
5349         parameter.
5350         (identify_source_line): Update call to get_filename_and_charpos.
5351
5352 2019-06-14  Tom Tromey  <tromey@adacore.com>
5353
5354         PR gdb/24502:
5355         * ui-style.h (skip_ansi_escape): Update comment.
5356         * ui-file.h (class no_terminal_escape_file): New class.
5357         * ui-file.c (no_terminal_escape_file::write)
5358         (no_terminal_escape_file::puts): New methods.
5359         * cli/cli-logging.c (handle_redirections): Use
5360         no_terminal_escape_file.
5361
5362 2019-06-14  Tom Tromey  <tromey@adacore.com>
5363
5364         * NEWS: Move convenience variable news above Python news.
5365
5366 2019-06-14  Tom Tromey  <tom@tromey.com>
5367
5368         * gnulib: Move directory to top-level.
5369         * configure.ac: Don't configure gnulib.
5370         * configure: Rebuild.
5371         * common/common-defs.h: Use new path to gnulib.
5372         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5373         (GNULIB_H): Remove.
5374         (INCGNU): Look in new gnulib location.
5375         (HFILES_NO_SRCDIR): Remove gnulib files.
5376         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5377         (generated_files): Remove GNULIB_H.
5378         ($(LIBGNU), all-lib): Remove targets.
5379         (distclean): Don't mention GNULIB_BUILDDIR.
5380         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5381
5382 2019-06-14  Tom Tromey  <tromey@adacore.com>
5383
5384         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5385         Warn if symbol file does not provide any symbols.
5386
5387 2019-06-14  Tom Tromey  <tromey@adacore.com>
5388
5389         * source.c (find_and_open_source): Respect basenames_may_differ.
5390
5391 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5392
5393         * annotate.c (annotate_breakpoints_invalid): Make use of
5394         scoped_restore_terminal_state.
5395         (annotate_frames_invalid): Likewise.
5396
5397 2019-06-14  Tom Tromey  <tromey@adacore.com>
5398
5399         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5400         allow assignment to an internalvar.
5401
5402 2019-06-14  Tom Tromey  <tromey@adacore.com>
5403
5404         * ada-lex.l: Allow "_" in attribute names.
5405
5406 2019-06-14  Tom Tromey  <tromey@adacore.com>
5407
5408         PR gdb/24653:
5409         * regcache.c (registers_changed): Don't call alloca.
5410         * top.c (execute_command): Don't call alloca.
5411
5412 2019-06-13  Pedro Alves  <palves@redhat.com>
5413
5414         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5415         'expression'.  When parsing an expression, error out if there's
5416         junk after "unlimited".
5417         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5418         (do_set_command): Adjust calls to is_unlimited_literal.
5419
5420 2019-06-13  Pedro Alves  <palves@redhat.com>
5421
5422         * compile/compile.c (make_compile_options_def_group): Add braces
5423         around array_view initializer.
5424         * thread.c (make_thread_apply_all_options_def_group)
5425         (make_thread_apply_all_options_def_group): Likewise.
5426
5427 2019-06-13  Pedro Alves  <palves@redhat.com>
5428
5429         * NEWS (New commands): Mention "maint test-options
5430         require-delimiter", "maint test-options unknown-is-error", "maint
5431         test-options unknown-is-operand" and "maint show
5432         test-options-completion-result".
5433         (New command options, command completion): New section.
5434         (Completion improvements): New section.
5435         Mention that you can abbreviate "unlimited".
5436
5437 2019-06-13  Pedro Alves  <palves@redhat.com>
5438
5439         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5440         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5441         * unittests/cli-utils-selftests.c (test_parse_flags)
5442         (test_parse_flags_qcs): Delete.
5443         (test_cli_utils): Don't call deleted functions.
5444
5445 2019-06-13  Pedro Alves  <palves@redhat.com>
5446
5447         * thread.c: Include "cli/cli-option.h".
5448         (tp_array_compar_ascending): Global.
5449         (tp_array_compar): Delete function.
5450         (tp_array_compar_ascending, tp_array_compar_descending): New
5451         functions.
5452         (ascending_option_def, qcs_flag_option_def)
5453         (thr_qcs_flags_option_defs)
5454         (make_thread_apply_all_options_def_group)
5455         (make_thread_apply_options_def_group): New.
5456         (thread_apply_all_command): Use gdb::option::process_options.
5457         (thread_apply_command_completer)
5458         (thread_apply_all_command_completer): New.
5459         (thread_apply_command): Use gdb::option::process_options.
5460         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5461         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5462         to generate help text of "thread apply".  Adjust "taas"'s help.
5463         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5464         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5465
5466 2019-06-13  Pedro Alves  <palves@redhat.com>
5467
5468         * thread.c (thread_apply_command): Check for invalid TID with
5469         isdigit instead of !isalpha.
5470
5471 2019-06-13  Pedro Alves  <palves@redhat.com>
5472
5473         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5474         (validate_flags_qcs): New.
5475         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5476         (validate_flags_qcs): Declare.
5477         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5478         (make_frame_apply_options_def_group): New.
5479         (frame_apply_command_count): Process options with
5480         gdb::option::process_options.
5481         (frame_apply_completer): New.
5482         (frame_apply_level_completer, frame_apply_all_completer)
5483         (frame_apply_completer): New.
5484         (_initialize_stack): Update help of "frame apply", "frame apply
5485         level", "frame apply all" and "faas" to mention supported options
5486         and install command completers.
5487         * stack.h (frame_apply_all_completer): Declare.
5488         * thread.c: Include "stack.h".
5489         (tfaas_command): Add "--".
5490         (_initialize_thread): Update help "tfaas" to mention supported
5491         options and install command completer.
5492
5493 2019-06-13  Pedro Alves  <palves@redhat.com>
5494
5495         * completer.c (complete_nested_command_line): New.
5496         (gdb_completion_word_break_characters_throw): Add assertion.
5497         * completer.h (complete_nested_command_line): Declare.
5498
5499 2019-06-13  Pedro Alves  <palves@redhat.com>
5500
5501         * stack.c (parse_backtrace_qualifiers): New.
5502         (backtrace_command): Use it.
5503         (backtrace_command_completer): Complete on qualifiers.
5504
5505 2019-06-13  Pedro Alves  <palves@redhat.com>
5506
5507         * frame.c: Include "cli/cli-option.h.
5508         (user_set_backtrace_options): New.
5509         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5510         Delete.
5511         (get_prev_frame): Adjust.
5512         (boolean_option_def, uinteger_option_def)
5513         (set_backtrace_option_defs): New.
5514         (_initialize_frame): Adjust and use
5515         gdb::option::add_setshow_cmds_for_options to install "set
5516         backtrace past-main" and "set backtrace past-entry".
5517         * frame.h: Include "cli/cli-option.h".
5518         (struct frame_print_options): Forward declare.
5519         (print_frame_arguments_all, print_frame_arguments_scalars)
5520         (print_frame_arguments_none): Declare.
5521         (print_entry_values): Delete declaration.
5522         (struct frame_print_options, user_frame_print_options): New.
5523         (struct set_backtrace_options): New.
5524         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5525         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5526         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5527         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5528         (list_args_or_locals): Add frame_print_options parameter.
5529         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5530         * python/py-framefilter.c (enumerate_args): Pass down
5531         USER_FRAME_PRINT_OPTIONS.
5532         * stack.c: Include "cli/cli-option.h".
5533         (print_frame_arguments_all, print_frame_arguments_scalars)
5534         (print_frame_arguments_none): Declare.
5535         (print_raw_frame_arguments, print_entry_values): Delete.
5536         (user_frame_print_options): New.
5537         (boolean_option_def, enum_option_def, frame_print_option_defs):
5538         New.
5539         (struct backtrace_cmd_options): New.
5540         (bt_flag_option_def): New.
5541         (backtrace_command_option_defs): New.
5542         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5543         (print_frame_arg, read_frame_arg, print_frame_args)
5544         (print_frame_info, print_frame): Add frame_print_options parameter
5545         and use it.
5546         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5547         (backtrace_command_1): Add frame_print_options and
5548         backtrace_cmd_options parameters and use them.
5549         (make_backtrace_options_def_group): New.
5550         (backtrace_command): Process command options with
5551         gdb::option::process_options.
5552         (backtrace_command_completer): New.
5553         (_initialize_stack): Extend "backtrace"'s help to mention
5554         supported options.  Install completer for "backtrace".
5555         Install some settings commands with add_setshow_cmds_for_options.
5556
5557 2019-06-13  Pedro Alves  <palves@redhat.com>
5558
5559         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5560         and that "set/show print raw frame-arguments" are now deprecated.
5561
5562         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5563         command.
5564         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5565         * stack.c (_initialize_stack): Install "set/show print
5566         raw-frame-arguments", and deprecate "set/show print raw
5567         frame-arguments".
5568         * valprint.c (_initialize_valprint): Deprecate "set/show print
5569         raw".
5570
5571 2019-06-13  Pedro Alves  <palves@redhat.com>
5572
5573         * compile/compile.c (struct compile_options): New.
5574         (compile_flag_option_def, compile_command_option_defs)
5575         (make_compile_options_def_group): New.
5576         (compile_file_command): Handle options with
5577         gdb::option::process_options.
5578         (compile_file_command_completer): New function.
5579         (compile_code_command): Handle options with
5580         gdb::option::process_options.
5581         (compile_code_command_completer): New function.
5582         (_initialize_compiler): Install completers for "compile code" and
5583         "compile file".  Mention available options in "compile code" and
5584         "compile code"'s help.
5585         * completer.c (advance_to_completion_word): New, factored out from
5586         ...
5587         (advance_to_expression_complete_word_point): ... this.
5588         (advance_to_filename_complete_word_point): New.
5589         * completer.h (advance_to_filename_complete_word_point): New
5590         declaration.
5591
5592 2019-06-13  Pedro Alves  <palves@redhat.com>
5593
5594         * compile/compile.c: Include "cli/cli-option.h".
5595         (compile_print_value): Scope data pointer is now a
5596         value_print_options pointer; adjust.
5597         (compile_print_command): Process options.  Scope data pointer is
5598         now a value_print_options pointer; adjust.
5599         (_initialize_compile): Update "compile print"'s help to include
5600         supported options.  Install a completer for "compile print".
5601         * cp-valprint.c (show_vtblprint, show_objectprint)
5602         (show_static_field_print): Delete.
5603         (_initialize_cp_valprint): Don't install "set print
5604         static-members", "set print vtbl", "set print object" here.
5605         * printcmd.c: Include "cli/cli-option.h" and
5606         "common/gdb_optional.h".
5607         (print_command_parse_format): Rework to fill in a
5608         value_print_options instead of a format_data.
5609         (print_value): Change parameter type from format_data pointer to
5610         value_print_options reference.  Adjust.
5611         (print_command_1): Process options.  Adjust to pass down a
5612         value_print_options.
5613         (print_command_completer): New.
5614         (_initialize_printcmd): Install print_command_completer as
5615         handle_brkchars completer for the "print" command.  Update
5616         "print"'s help to include supported options.
5617         * valprint.c: Include "cli/cli-option.h".
5618         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5619         here from cp-valprint.c.
5620         (boolean_option_def, uinteger_option_def)
5621         (value_print_option_defs, make_value_print_options_def_group):
5622         New.  Use gdb::option::add_setshow_cmds_for_options to install
5623         "set print elements", "set print null-stop", "set print repeats",
5624         "set print pretty", "set print union", "set print array", "set
5625         print address", "set print symbol", "set print array-indexes".
5626         * valprint.h: Include <string> and "cli/cli-option.h".
5627         (make_value_print_options_def_group): Declare.
5628         (print_value): Change parameter type from format_data pointer to
5629         value_print_options reference.
5630         (print_command_completer): Declare.
5631
5632 2019-06-13  Pedro Alves  <palves@redhat.com>
5633
5634         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5635         (COMMON_SFILES): Add maint-test-settings.c.
5636         * cli/cli-decode.c (boolean_enums): New global, factored out from
5637         ...
5638         (add_setshow_boolean_cmd): ... here.
5639         * cli/cli-decode.h (boolean_enums): Declare.
5640         * cli/cli-option.c: New file.
5641         * cli/cli-option.h: New file.
5642         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5643         factored out from ...
5644         (parse_cli_boolean_value(const char *)): ... this.
5645         (is_unlimited_literal): Change parameter type to pointer to
5646         pointer.  Adjust and advance ARG pointer.
5647         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5648         (parse_cli_var_enum): New, factored out from ...
5649         (do_set_command): ... this.  Adjust.
5650         * cli/cli-setshow.h (parse_cli_boolean_value)
5651         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5652         (parse_cli_var_enum): Declare.
5653         * cli/cli-utils.c: Include "cli/cli-option.h".
5654         (get_ulongest): New.
5655         * cli/cli-utils.h (get_ulongest): Declare.
5656         (check_for_argument): New overloads.
5657         * maint-test-options.c: New file.
5658
5659 2019-06-13  Pedro Alves  <palves@redhat.com>
5660
5661         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5662         parse a range if "-" is at the end of the string.
5663
5664 2019-06-13  Pedro Alves  <palves@redhat.com>
5665
5666         * cli/cli-setshow.c (parse_auto_binary_operation)
5667         (parse_cli_boolean_value): Don't allow "o".
5668
5669 2019-06-13  Pedro Alves  <palves@redhat.com>
5670
5671         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5672         * NEWS: Mention maint test-settings KIND.
5673         * maint-test-settings.c: New file.
5674
5675 2019-06-13  Pedro Alves  <palves@redhat.com>
5676
5677         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5678         completer.
5679         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5680         "set" completers.
5681
5682 2019-06-13  Pedro Alves  <palves@redhat.com>
5683
5684         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5685         after item.
5686
5687 2019-06-13  Pedro Alves  <palves@redhat.com>
5688
5689         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5690
5691 2019-06-13  Pedro Alves <palves@redhat.com>
5692
5693         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5694         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5695         call.
5696         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5697         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5698         calls.
5699         (check_for_argument): Skip spaces after argument.
5700
5701 2019-06-13  Pedro Alves  <palves@redhat.com>
5702
5703         * thread.c (thread_apply_command): Adjust TID parsing.
5704         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5705         detected before end of string.
5706         (tid_is_in_list): Error out if LIST is invalid.
5707
5708 2019-06-13  Pedro Alves  <palves@redhat.com>
5709
5710         * completer.c (complete_line_internal_1): Rewind completion word
5711         point.
5712         (completion_tracker::advance_custom_word_point_by): Change
5713         parameter type to int.
5714         * completer.h (completion_tracker::advance_custom_word_point_by):
5715         Likewise.
5716
5717 2019-06-13  Pedro Alves  <palves@redhat.com>
5718
5719         * completer.c (advance_to_completion_word): Handle delimiters.
5720
5721 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5722
5723         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5724
5725 2019-06-11  Tom Tromey  <tom@tromey.com>
5726
5727         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5728         (xmalloc_failed): Move to alloc.c.
5729         * alloc.c: New file.
5730         * Makefile.in (COMMON_SFILES): Add alloc.c.
5731
5732 2019-06-11  Tom Tromey  <tom@tromey.com>
5733
5734         * nat/linux-waitpid.c: Don't include server.h.
5735         (linux_debug): Remove.
5736         (my_waitpid): Update.
5737
5738 2019-06-11  Tom Tromey  <tromey@adacore.com>
5739
5740         * infcall.c (_initialize_infcall): Remove trailing newline from
5741         help.
5742         * user-regs.c (_initialize_user_regs): Remove trailing newline
5743         from help.
5744         * typeprint.c (_initialize_typeprint): Remove trailing newline
5745         from help.
5746         * reverse.c (_initialize_reverse): Remove trailing newlines from
5747         help.
5748         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5749         from help.
5750         * language.c (add_set_language_command): Remove trailing newline
5751         from help.
5752         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5753         help.
5754         * disasm.c (_initialize_disasm): Remove trailing newline from
5755         help.
5756         * top.c (init_main): Remove trailing newline from help.
5757         * interps.c (_initialize_interpreter): Remove trailing newline
5758         from help.
5759         * btrace.c (_initialize_btrace): Remove trailing newlines from
5760         help.
5761         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5762         from help.
5763         * python/python.c (_initialize_python): Remove trailing newline
5764         from help.
5765         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5766         help.
5767         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5768         from help.  Reformat some text.
5769         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5770         from help.
5771         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5772         newline from help.
5773
5774 2019-06-11  Tom Tromey  <tromey@adacore.com>
5775
5776         * darwin-nat.c (darwin_decode_exception_message)
5777         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5778
5779 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5780
5781         * valops.c (value_slice): Check for not allocated or not
5782         associated values.
5783
5784 2019-06-10  Tom de Vries  <tdevries@suse.de>
5785
5786         PR gdb/24618
5787         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5788         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5789         invalid.
5790
5791 2019-06-10  Tom de Vries  <tdevries@suse.de>
5792
5793         PR gdb/24611
5794         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5795         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5796
5797 2019-06-10  Tom de Vries  <tdevries@suse.de>
5798
5799         PR symtab/24545
5800         * symtab.c (struct demangled_name_entry): Add language field.
5801         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5802         static minimal symbol".  Set and use language field.
5803
5804 2019-06-10  Tom Tromey  <tromey@adacore.com>
5805
5806         * ada-lang.c (_initialize_ada_language): Update help text.
5807
5808 2019-06-10  Tom Tromey  <tromey@adacore.com>
5809
5810         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5811         with a newline.
5812         * guile/guile.c (handle_boot_error): Don't end warning with a
5813         newline.
5814         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5815         warning with a newline.
5816         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5817         newline.
5818         (s12z_frame_cache): Likewise.
5819         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5820         a newline.
5821         * solib-svr4.c (disable_probes_interface): Don't end warning with
5822         a newline.
5823         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5824         newline.
5825         * python/python.c (do_finish_initialization): Don't end warning
5826         with a newline.
5827
5828 2019-06-10  Tom Tromey  <tom@tromey.com>
5829
5830         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5831         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5832         gdbpy_enter.
5833
5834 2019-06-10  Tom Tromey  <tromey@adacore.com>
5835
5836         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5837         data.
5838         (elf_new_init): Don't call stabsread_new_init.
5839         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5840         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5841         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5842
5843 2019-06-10  Tom de Vries  <tdevries@suse.de>
5844
5845         PR symtab/16264
5846         PR symtab/24517
5847         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5848
5849 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5850
5851         * source.c (find_and_open_source): Also rewrite relative file
5852         names.
5853
5854 2019-04-26  Amos Bird  <amosbird@gmail.com>
5855
5856         * annotate.c (annotate_thread_exited): Add "thread-exited"
5857         annotation.
5858
5859 2019-06-06  Tom Tromey  <tromey@adacore.com>
5860
5861         * maint.h (class scoped_command_stats): Use
5862         DISABLE_COPY_AND_ASSIGN.
5863         <print_time>: New method.
5864         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5865         print_time.
5866         (scoped_command_stats::print_time): New method.
5867
5868 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5869
5870         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5871         instructions of lengths 6 or 8 bytes.
5872
5873 2019-06-04  Pedro Alves  <palves@redhat.com>
5874
5875         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5876
5877         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5878         * breakpoint.c (condition_completer): Likewise.
5879         * cli/cli-dump.c (scan_expression): Likewise.
5880         * common/filestuff.c (mkdir_recursive): Likewise.
5881         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5882         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5883         (gdb_abspath): Likewise.
5884         * compile/compile-cplus-types.c
5885         (compile_cplus_instance::decl_name): Likewise.
5886         * completer.c (complete_explicit_location):
5887         (signal_completer, reg_or_group_completer_1): Likewise.
5888         * cp-support.c (cp_remove_params_if_any): Likewise.
5889         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5890         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5891         * infcmd.c (strip_bg_char): Likewise.
5892         * linespec.c (copy_token_string): Likewise.
5893         * mi/mi-main.c (output_cores): Likewise.
5894         * psymtab.c (psymtab_search_name):
5895         * symfile.c (test_set_ext_lang_command): Likewise.
5896         * target.c (target_fileio_read_stralloc): Likewise.
5897         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5898         * value.c (complete_internalvar): Likewise.
5899
5900 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5901
5902         Add objfile property to gdb.Type.
5903         * NEWS: Mention Python API addition.
5904         * python/py-type.c (typy_get_objfile): New method.
5905
5906 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5907
5908         * NEWS: Mention the new set|show style [title|highlight].
5909         Mention changes to "show style", "help" and "apropos".
5910
5911 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5912
5913         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5914         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5915         instead of print_help_for_command.
5916         (print_doc_of_command): New function.
5917         (help_list): Add 'apropos -v word' suggestion.
5918         (print_help_for_command): Style the command name using title style.
5919         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5920         (_initialize_cli_cmds): Describe -v in apropos_command help.
5921
5922 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5923
5924         * cli/cli-style.h (cli_style_option): Add name in constructor,
5925         add m_name class member, add constructor with intensity,
5926         add name class function.
5927         (cli_style_option::add_setshow_commands): Remove name argument.
5928         (highlight_style, title_style): New styles.
5929         * cli/cli-style.c (do_show): New function that shows a style
5930         characteristic styling the style name with itself.
5931         (set_style_name): New function.
5932         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5933         Update all callers according to the changes in cli/cli-style.h.
5934         * utils.h (fputs_highlighted): New function.
5935         * utils.c (fputs_highlighted): Likewise.
5936
5937 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5938
5939         * NEWS: Mention new pipe command and new convenience variables.
5940
5941 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5942
5943         * cli/cli-cmds.c (pipe_command): New function.
5944         (_initialize_cli_cmds): Call add_com for pipe_command.
5945         Define | as an alias for pipe.
5946         (exit_status_set_internal_vars): New function.
5947         (shell_escape): Call exit_status_set_internal_vars.
5948         cli/cli-decode.c (find_command_name_length): Recognize | as
5949         a single character command.
5950
5951 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5952
5953         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5954         top.c (execute_command_to_ui_file): New function, mostly a copy
5955         of execute_command_to_string.
5956         (execute_command_to_string): Implement by calling
5957         execute_command_to_ui_file.
5958
5959 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5960
5961         * top.h (saved_command_line): Remove declaration.
5962         * top.c (previous_saved_command_line, previous_repeat_arguments):
5963         New variables.
5964         (saved_command_line): Make static, define together with other
5965         'repeat variables'.
5966         (dont_repeat): Clear repeat_arguments.
5967         (repeat_previous, get_saved_command_line, save_command_line):
5968         New functions.
5969         (gdb_init): Initialize saved_command_line
5970         and previous_saved_command_line.
5971         * main.c (captured_main_1): Remove saved_command_line initialization.
5972         * event-top.c (handle_line_of_input): Update to use
5973         the new 'repeat' related functions instead of direct access to
5974         saved_command_line.
5975         * command.h (repeat_previous, get_saved_command_line,
5976         save_command_line): New declarations.
5977         (dont_repeat): Add comment.
5978
5979 2019-05-30  Tom Tromey  <tromey@adacore.com>
5980
5981         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5982         Fix comment.
5983         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5984
5985 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5986
5987         PR cli/24587
5988         * completer.c (complete): Initialize variable word.
5989
5990 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5991
5992         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5993         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5994         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5995         'body' is NULL to the outter 'if', protecting the '!is_define'
5996         situation as well.
5997
5998 2019-05-29  Tom Tromey  <tromey@adacore.com>
5999
6000         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6001         (dwarf_unknown): New function.
6002         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6003         (dwarf_type_encoding_name): Use dwarf_unknown.
6004
6005 2019-05-29  Tom Tromey  <tromey@adacore.com>
6006
6007         PR c++/20020:
6008         * cp-valprint.c (cp_print_value_fields): Call
6009         cp_print_static_field inside "try".
6010
6011 2019-05-29  Tom Tromey  <tromey@adacore.com>
6012
6013         * inflow.c (struct terminal_info): Add default operator=.
6014         * configure: Rebuild.
6015         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6016         -Wdeprecated-copy-dtor, -Wredundant-move.
6017
6018 2019-05-29  Tom Tromey  <tromey@adacore.com>
6019
6020         * NEWS: Add entry.
6021         * infcmd.c (print_return_value_1): Handle finish_print
6022         option.
6023         (show_print_finish): New function.
6024         (_initialize_infcmd): Add "set/show print finish" commands.
6025         * valprint.c (user_print_options): Initialize new member.
6026         * valprint.h (struct value_print_options) <finish_print>: New
6027         member.
6028
6029 2019-05-28  Tom Tromey  <tromey@adacore.com>
6030
6031         * ada-lang.c (ada_remove_Xbn_suffix)
6032         (find_old_style_renaming_symbol)
6033         (parse_old_style_renaming): Remove.
6034         (ada_find_renaming_symbol): Don't call
6035         find_old_style_renaming_symbol.
6036         (ada_is_renaming_symbol): Rename from
6037         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6038         bool.  Now static.
6039         (ada_read_var_value): Update and simplify.
6040         * ada-exp.y (write_var_or_type): Remove old code.
6041
6042 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6043
6044         * event-top.c: Remove include comment.
6045         * inflow.c (class scoped_ignore_sigttou): Move from here...
6046         * inflow.h (class scoped_ignore_sigttou): ...to here.
6047         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6048         * top.c:  Remove include comment.
6049
6050 2019-05-27  Tom Tromey  <tom@tromey.com>
6051
6052         * NEWS: Fix typo.
6053
6054 2019-05-22  Tom Tromey  <tromey@adacore.com>
6055
6056         * target.c (target_follow_exec): Constify parameter.
6057         * target-delegates.c: Rebuild.
6058         * remote.c (remote_target::follow_exec): Constify parameter.
6059         * infrun.c (follow_exec): Constify parameter.
6060         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6061         (target_follow_exec): Likewise.
6062
6063 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6064
6065         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6066         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6067
6068 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6069
6070         * NEWS: Add debugredirect and testsuite sections.
6071
6072 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6073
6074         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6075         target descriptions using exclusively floating point register name
6076         aliases.
6077
6078 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6079
6080         PR gdb/18644:
6081         * f-lang.c (build_fortran_types): Handle the case where
6082         gdbarch_floatformat_for_type returns a nullptr.
6083
6084 2019-05-21  Tom de Vries  <tdevries@suse.de>
6085
6086         PR cli/24587
6087         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6088
6089 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6090
6091         PR gdb/18644:
6092         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6093         16-byte floats.
6094         * i386-tdep.c (i386_floatformat_for_type): Use
6095         floatformats_ia64_quad for the 16-byte floating point component
6096         within a fortran 32-byte complex number.
6097
6098 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6099
6100         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6101         delete default constructor.
6102         (find_partial_die): Update to return const struct.
6103         (partial_die_parent_scope): Move variable declaration into scope
6104         of its use and change its type to auto.
6105         (guess_partial_die_structure_name): Likewise.
6106         (partial_die_info::fixup): Likewise.
6107
6108 2019-05-17  Tom Tromey  <tromey@adacore.com>
6109
6110         * source.c (find_and_open_source): Remove cast.
6111
6112 2019-05-17  Tom Tromey  <tromey@adacore.com>
6113
6114         * annotate.c (annotate_source): Make "filename" const.
6115         * annotate.h (annotate_source): Use const.
6116
6117 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6118
6119         * disasm.c (set_disassembler_options): Send errors to stderr.
6120
6121 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6122
6123         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6124         (cli_interp_base::set_logging): Check debug_redirect.
6125         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6126         * cli/cli-logging.c (debug_redirect): Add static variable.
6127         (pop_output_files): Add default param.
6128         (handle_redirections): Print debug setting.
6129         (show_logging_command): Likewise.
6130         (_initialize_cli_logging): Add debugredirect command.
6131         * interps.c (current_interp_set_logging): Add debug_redirect
6132         parameter.
6133         * interps.h (set_logging): Add debug_redirect parameter.
6134         (current_interp_set_logging): Likewise.
6135         * mi/mi-common.h: Likewise.
6136         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6137
6138 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6139             Tom Tromey  <tromey@adacore.com>
6140
6141         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6142         directly.
6143         * cli/cli-interp.h (make_logging_output): Remove declaration.
6144         * cli/cli-logging.c (make_logging_output): Remove function.
6145         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6146         directly.
6147         * ui-file.c (tee_file::tee_file): Remove bools.
6148         (tee_file::~tee_file): Remove deletes.
6149         * ui-file.h (tee_file): Remove bools.
6150
6151 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6152
6153         * mi/mi-cmds.h (mi_cmd_complete): New function.
6154         * mi/mi-main.c (mi_cmd_complete): Likewise.
6155         * mi/mi-cmds.c: Define new MI command -complete.
6156         * NEWS: Mention new -complete command.
6157
6158 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6159
6160         * completer.h (complete): New function.
6161         * completer.c (complete): Likewise.
6162         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6163         function defined in completer.h.
6164
6165 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6166
6167         * MAINTAINERS (Write After Approval): Add myself.
6168
6169 2019-05-17  Tom de Vries  <tdevries@suse.de>
6170
6171         PR gdb/24094
6172         * dwarf2read.c (struct cu_partial_die_info): New struct.
6173         (find_partial_die): Return cu_partial_die_info.
6174         (partial_die_parent_scope, guess_partial_die_structure_name)
6175         (partial_die_info::fixup): Handle new return type of find_partial_die.
6176
6177 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6178
6179         PR breakpoints/24541
6180         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6181         "std::string", simplifying the algorithm.
6182
6183 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6184
6185         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6186         (stap_static_probe_ops::get_probes): Likewise.
6187
6188 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6189
6190         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6191         '-')" and "else if".
6192         (stap_parse_single_operand): Join checks for
6193         "gdbarch_stap_parse_special_token_p" and
6194         "gdbarch_stap_parse_special_token" in the same "if" statement.
6195         Invert check when verifying for operation on register
6196         displacement.
6197
6198 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6199
6200         * stap-probe.c (stap_get_opcode): Update comment.
6201         (stap_get_expected_argument_type): Likewise.
6202         (handle_stap_probe): Likewise.
6203
6204 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6205
6206         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6207         return type to 'bool'.  Adjust comment.  Use 'bool' when
6208         appropriate.
6209         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6210         * stap-probe.c (stap_parse_argument_1): Likewise.
6211         (stap_is_operator): Likewise.
6212         (stap_is_generic_prefix): Likewise.
6213         (stap_is_register_prefix): Likewise.
6214         (stap_is_register_indirection_prefix): Likewise.
6215         (stap_is_integer_prefix): Likewise.
6216         (stap_generic_check_suffix): Likewise.
6217         (stap_check_integer_suffix): Likewise.
6218         (stap_check_register_suffix): Likewise.
6219         (stap_check_register_indirection_suffix): Likewise.
6220         (stap_parse_register_operand): Likewise.
6221         (stap_parse_single_operand): Likewise.
6222         (stap_parse_argument_1): Likewise.
6223         (stap_probe::get_argument_count): Likewise.
6224         (stap_is_operator): Likewise.
6225
6226 2019-05-16  Tom Tromey  <tromey@adacore.com>
6227
6228         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6229         keyword to foreach.
6230
6231 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6232
6233         * linux-thread-db.c (try_thread_db_load_1): Change return type
6234         to bool.
6235         (try_thread_db_load): Likewise.
6236         (try_thread_db_load_from_pdir_1): Likewise.
6237         (try_thread_db_load_from_pdir): Likewise.
6238         (try_thread_db_load_from_sdir): Likewise.
6239         (try_thread_db_load_from_dir): Likewise.
6240         (thread_db_load_search): Likewise.
6241         (has_libpthread): Likewise.
6242         (thread_db_load): Likewise.
6243
6244 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6245
6246         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6247         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6248         NULL, and complain/return if that's the case.
6249
6250 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6251
6252         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6253         (advance, posn, abstract_read_memory): New functions.
6254         [struct mem_read_abstraction]: New struct.
6255         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6256
6257 2019-05-14  Tom Tromey  <tromey@adacore.com>
6258
6259         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6260         value is not lval_memory.
6261
6262 2019-05-14  Tom Tromey  <tromey@adacore.com>
6263
6264         * solib.c (info_sharedlibrary_command): Style the file name.
6265
6266 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6267
6268         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6269         (aarch64_vnv_type): Likewise.
6270         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6271         * common/tdesc.c: Likewise.
6272         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6273         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6274         * features/aarch64-fpu.xml: Add ieee half view.
6275         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6276         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6277         * gdbtypes.h (struct builtin_type): Likewise.
6278         (struct objfile_type): Likewise.
6279
6280 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6281
6282         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6283         typo.
6284         * location.h (string_to_event_location): Likewise.
6285
6286 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6287
6288         GDB 8.3 released.
6289
6290 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6291
6292         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6293         New variable declaration.
6294         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6295         New variable.
6296         (print_one_breakpoint): Use ui_out::test_flags and new global
6297         variable to compute use_fixed_output.
6298         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6299         Remove.
6300         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6301         (mi_multi_location_breakpoint_output_fixed): Remove.
6302         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6303         new variable.
6304         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6305         fix_multi_location_breakpoint_output flag if version >= 3.
6306         * ui-out.h (enum ui_out_flag)
6307         <fix_multi_location_breakpoint_output>: New enumerator.
6308
6309 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6310
6311         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6312
6313 2019-05-10  Tom Tromey  <tromey@adacore.com>
6314
6315         * ada-lang.c (catch_ada_completer): New function.
6316         (_initialize_ada_language): Use it.
6317
6318 2019-05-10  Tom Tromey  <tromey@adacore.com>
6319
6320         * thread.c (print_thread_info): Make "requested_threads" const.
6321         * gdbthread.h (print_thread_info): Make "requested_threads"
6322         const.
6323         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6324         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6325
6326 2019-05-08  Tom Tromey  <tom@tromey.com>
6327
6328         * gdbtypes.c (objfile_type_data): Change type.
6329         (objfile_type, _initialize_gdbtypes): Update.
6330
6331 2019-05-08  Tom Tromey  <tom@tromey.com>
6332
6333         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6334         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6335         (_initialize_dwarf2_frame): Update.
6336
6337 2019-05-08  Tom Tromey  <tom@tromey.com>
6338
6339         * objc-lang.c (objc_objfile_data): Change type.
6340         (find_methods): Update.
6341         (_initialize_objc_lang): Remove.
6342
6343 2019-05-08  Tom Tromey  <tom@tromey.com>
6344
6345         * stabsread.c (rs6000_builtin_type_data): Change type.
6346         (rs6000_builtin_type, _initialize_stabsread): Update.
6347
6348 2019-05-08  Tom Tromey  <tom@tromey.com>
6349
6350         * mips-tdep.c (mips_pdr_data): Remove.
6351         (_initialize_mips_tdep): Update.
6352
6353 2019-05-08  Tom Tromey  <tom@tromey.com>
6354
6355         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6356         (hppa_init_objfile_priv_data, read_unwind_info)
6357         (find_unwind_entry, _initialize_hppa_tdep): Update.
6358
6359 2019-05-08  Tom Tromey  <tom@tromey.com>
6360
6361         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6362         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6363         on obstack.
6364         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6365
6366 2019-05-08  Tom Tromey  <tom@tromey.com>
6367
6368         * mdebugread.c (basic_type_data): Change type.
6369         (basic_type, _initialize_mdebugread): Update.
6370
6371 2019-05-08  Tom Tromey  <tom@tromey.com>
6372
6373         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6374
6375 2019-05-08  Tom Tromey  <tom@tromey.com>
6376
6377         * nto-tdep.c (nto_inferior_data_reg): Change type.
6378         (nto_inferior_data): Update.
6379         (nto_inferior_data_cleanup, nto_new_inferior_data)
6380         (_initialize_nto_tdep): Remove.
6381         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6382
6383 2019-05-08  Tom Tromey  <tom@tromey.com>
6384
6385         * ada-lang.c (struct ada_inferior_data): Add initializers.
6386         (ada_inferior_data): Change type.
6387         (ada_inferior_data_cleanup): Remove.
6388         (get_ada_inferior_data, ada_inferior_exit)
6389         (struct ada_pspace_data): Add initializers, destructor.
6390         (ada_pspace_data_handle): Change type.
6391         (get_ada_pspace_data): Update.
6392         (ada_pspace_data_cleanup): Remove.
6393
6394 2019-05-08  Tom Tromey  <tom@tromey.com>
6395
6396         * coffread.c (struct coff_symfile_info): Add initializers.
6397         (coff_objfile_data_key): Move lower.  Change type.
6398         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6399         Update.
6400         (coff_free_info): Remove.
6401
6402 2019-05-08  Tom Tromey  <tom@tromey.com>
6403
6404         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6405         (fbsd_pspace_data_handle): Move lower.  Change type.
6406         (get_fbsd_pspace_data): Update.
6407         (fbsd_pspace_data_cleanup): Remove.
6408         (_initialize_fbsd_tdep): Update.
6409
6410 2019-05-08  Tom Tromey  <tom@tromey.com>
6411
6412         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6413         (get_ada_tasks_pspace_data): Update.
6414         (ada_tasks_pspace_data_cleanup): Remove.
6415         (_initialize_tasks): Update.
6416         (ada_tasks_inferior_data_handle): Change type.
6417         (get_ada_tasks_inferior_data): Update.
6418         (ada_tasks_inferior_data_cleanup): Remove.
6419         (struct ada_tasks_pspace_data): Add initializers.
6420
6421 2019-05-08  Tom Tromey  <tom@tromey.com>
6422
6423         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6424         * symfile-debug.c (debug_sym_get_probes): Change type.
6425         * stap-probe.c (handle_stap_probe):
6426         (stap_static_probe_ops::get_probes): Change type.
6427         * probe.h (class static_probe_ops) <get_probes>: Change type.
6428         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6429         (parse_probes_in_pspace): Update.
6430         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6431         Update.
6432         (any_static_probe_ops::get_probes): Change type.
6433         * elfread.c (elfread_data): New typedef.
6434         (probe_key): Change type.
6435         (elf_get_probes): Likewise.  Update.
6436         (probe_key_free): Remove.
6437         (_initialize_elfread): Update.
6438         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6439         Change type.
6440         (dtrace_process_dof_probe, dtrace_process_dof)
6441         (dtrace_static_probe_ops::get_probe): Change type.
6442
6443 2019-05-08  Tom Tromey  <tom@tromey.com>
6444
6445         * xcoffread.c (struct xcoff_symfile_info): Rename from
6446         coff_symfile_info.  Add initializers.
6447         (xcoff_objfile_data_key): Move lower.  Change type.
6448         (XCOFF_DATA): Rewrite.
6449         (xcoff_free_info): Remove.
6450         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6451         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6452         (xcoff_initial_scan): Update.
6453
6454 2019-05-08  Tom Tromey  <tom@tromey.com>
6455
6456         * solib-svr4.c (struct svr4_info): Add initializers and
6457         destructor.
6458         <probes_table>: Now an htab_up.
6459         (solib_svr4_pspace_data): Change type.
6460         (free_probes_table): Simplify.
6461         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6462         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6463         (probes_table_remove_objfile_probes, register_solib_event_probe)
6464         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6465         (_initialize_svr4_solib): Update.
6466
6467 2019-05-08  Tom Tromey  <tom@tromey.com>
6468
6469         * remote.c (remote_pspace_data): Change type.
6470         (remote_pspace_data_cleanup): Remove.
6471         (get_remote_exec_file, set_pspace_remote_exec_file)
6472         (_initialize_remote): Update.
6473
6474 2019-05-08  Tom Tromey  <tom@tromey.com>
6475
6476         * breakpoint.c (breakpoint_objfile_key): Change type.
6477         (get_breakpoint_objfile_data): Update.
6478         (free_breakpoint_objfile_data): Remove.
6479         (_initialize_breakpoint): Update.
6480
6481 2019-05-08  Tom Tromey  <tom@tromey.com>
6482
6483         * linux-tdep.c (struct linux_info): Add initializers.
6484         (linux_inferior_data): Move.  Change type.
6485         (invalidate_linux_cache_inf): Update.
6486         (linux_inferior_data_cleanup): Remove.
6487         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6488
6489 2019-05-08  Tom Tromey  <tom@tromey.com>
6490
6491         * auxv.c (auxv_inferior_data): Move.  Change type.
6492         (auxv_inferior_data_cleanup): Remove.
6493         (invalidate_auxv_cache_inf): Rewrite.
6494         (get_auxv_inferior_data, _initialize_auxv): Update.
6495
6496 2019-05-08  Tom Tromey  <tom@tromey.com>
6497
6498         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6499         (symfile_debug_objfile_data_key): Change type.
6500         (symfile_debug_installed, debug_qf_has_symbols)
6501         (debug_qf_find_last_source_symtab)
6502         (debug_qf_forget_cached_source_info)
6503         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6504         (debug_qf_print_stats, debug_qf_dump)
6505         (debug_qf_expand_symtabs_for_function)
6506         (debug_qf_expand_all_symtabs)
6507         (debug_qf_expand_symtabs_with_fullname)
6508         (debug_qf_map_matching_symbols)
6509         (debug_qf_expand_symtabs_matching)
6510         (debug_qf_find_pc_sect_compunit_symtab)
6511         (debug_qf_map_symbol_filenames)
6512         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6513         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6514         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6515         (debug_sym_read_linetable, debug_sym_relocate): Update.
6516         (symfile_debug_free_objfile): Remove.
6517         (install_symfile_debug_logging, _initialize_symfile_debug):
6518         Update.
6519
6520 2019-05-08  Tom Tromey  <tom@tromey.com>
6521
6522         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6523         allocate_on_obstack.
6524         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6525         (get_dwarf2_per_objfile): Update.
6526         (set_dwarf2_per_objfile): Remove.
6527         (dwarf2_has_info, dwarf2_get_section_info): Update.
6528         (dwarf2_free_objfile): Remove.
6529         (_initialize_dwarf2_read): Update.
6530
6531 2019-05-08  Tom Tromey  <tom@tromey.com>
6532
6533         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6534         initializers.
6535         <unsupported_script_warning_printed,
6536         script_not_found_warning_printed>: Now bool.
6537         (auto_load_pspace_data): Change type.
6538         (~auto_load_pspace_info): Rename from
6539         auto_load_pspace_data_cleanup.
6540         (get_auto_load_pspace_data, init_loaded_scripts_info)
6541         (clear_section_scripts, maybe_print_unsupported_script_warning)
6542         (maybe_print_script_not_found_warning, _initialize_auto_load):
6543         Update.
6544
6545 2019-05-08  Tom Tromey  <tom@tromey.com>
6546
6547         * objfiles.c (objfile_pspace_info): Add destructor and
6548         initializers.
6549         (objfiles_pspace_data): Change type.
6550         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6551         (get_objfile_pspace_data): Update.
6552         (objfiles_bfd_data): Change type.
6553         (get_objfile_bfd_data): Update.
6554         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6555
6556 2019-05-08  Tom Tromey  <tom@tromey.com>
6557
6558         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6559         Change type.
6560         (get_catch_syscall_inferior_data): Update.
6561         (catch_syscall_inferior_data_cleanup): Remove.
6562         (_initialize_break_catch_syscall): Update.
6563
6564 2019-05-08  Tom Tromey  <tom@tromey.com>
6565
6566         * inflow.c (struct terminal_info): Add destructor and
6567         initializers.
6568         (inflow_inferior_data): Change type.
6569         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6570         (get_inflow_inferior_data, inflow_inferior_exit)
6571         (swap_terminal_info, _initialize_inflow): Update.
6572
6573 2019-05-08  Tom Tromey  <tom@tromey.com>
6574
6575         * target-dcache.c (target_dcache_cleanup): Remove.
6576         (target_dcache_aspace_key): Change type.
6577         (target_dcache_init_p, target_dcache_invalidate)
6578         (target_dcache_get, target_dcache_get_or_init)
6579         (_initialize_target_dcache): Update.
6580         * dcache.h (struct dcache_deleter): New.
6581
6582 2019-05-08  Tom Tromey  <tom@tromey.com>
6583
6584         * symtab.c (struct symbol_cache): Add destructor and
6585         initializers.
6586         (symbol_cache_key): Move.  Change type.
6587         (make_symbol_cache, free_symbol_cache): Remove.
6588         (get_symbol_cache): Update.
6589         (symbol_cache_cleanup): Remove.
6590         (ALL_PSPACES, symbol_cache_flush)
6591         (maintenance_print_symbol_cache)
6592         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6593         Update.
6594
6595 2019-05-08  Tom Tromey  <tom@tromey.com>
6596
6597         * symtab.c (struct main_info): Add destructor and initializers.
6598         (main_progspace_key): Move.  Change type.
6599         (get_main_info): Update.
6600         (main_info_cleanup): Remove.
6601         (_initialize_symtab): Update.
6602
6603 2019-05-08  Tom Tromey  <tom@tromey.com>
6604
6605         * registry.h (DECLARE_REGISTRY): Define the _key class.
6606
6607 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6608
6609         * NEWS: Merge two 'New commands' sections.
6610
6611 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6612
6613         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6614         parameter and use Ada language definition instead.
6615         (ada_val_print_ptr): Remove unused language parameter.
6616         (ada_val_print_num): Remove language parameter and use Ada language
6617         definition instead.
6618         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6619         parameter.
6620         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6621         parameter and use Ada language definition instead.
6622         (ada_val_print_1): Update all ada_val_print_xxx calls.
6623         Remove language parameter.
6624         (ada_val_print): Update ada_val_print_1 call.
6625
6626 2019-05-08  Tom Tromey  <tromey@adacore.com>
6627
6628         * remote.c (remote_hw_watchpoint_limit)
6629         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6630         Now static.
6631
6632 2019-05-08  Tom Tromey  <tromey@adacore.com>
6633
6634         * maint.c (_initialize_maint_cmds): Move initialization code to
6635         remote.c.
6636         (watchdog, show_watchdog): Move to remote.c.
6637         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6638         "watchdog" static.
6639         (_initialize_remote): Move initialization code from maint.c.
6640         * defs.h (watchdog): Don't declare.
6641
6642 2019-05-08  Tom Tromey  <tromey@adacore.com>
6643
6644         * tui/tui-interp.c: Include main.h.
6645         * interps.c: Include main.h.
6646         * main.h (interpreter_p): Declare.
6647         * defs.h (interpreter_p): Don't declare.
6648
6649 2019-05-08  Tom Tromey  <tromey@adacore.com>
6650
6651         * dwarf2loc.c: Include dwarf2read.h.
6652         * defs.h (read_unsigned_leb128): Don't declare.
6653         * dwarf2read.h (read_unsigned_leb128): Declare.
6654
6655 2019-05-08  Tom Tromey  <tromey@adacore.com>
6656
6657         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6658         method.
6659
6660 2019-05-08  Tom Tromey  <tromey@adacore.com>
6661
6662         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6663         when no wrap column is set.
6664
6665 2019-05-08  Tom Tromey  <tromey@adacore.com>
6666
6667         * c-lang.c (c_get_string): Handle non-C-style arrays.
6668
6669 2019-05-08  Tom Tromey  <tromey@adacore.com>
6670
6671         * typeprint.c (print_offset_data::update): Print the bit offset,
6672         not the number of bits remaining.
6673
6674 2019-05-08  Tom Tromey  <tromey@adacore.com>
6675
6676         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6677         padding at end of comment.
6678
6679 2019-05-08  Tom Tromey  <tromey@adacore.com>
6680
6681         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6682         Compare main types.
6683
6684 2019-05-06  Tom Tromey  <tom@tromey.com>
6685
6686         * common/scoped_mmap.c: Include common-defs.h.
6687         * common/scoped_mmap.h: Don't include config.h.
6688
6689 2019-05-04  Tom Tromey  <tom@tromey.com>
6690
6691         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6692         (struct aarch64_call_info): Add initializers.
6693         <si>: Now a std::vector.
6694         (pass_on_stack, aarch64_push_dummy_call): Update.
6695
6696 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6697             Tom Tromey  <tom@tromey.com>
6698
6699         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6700         (ppc_threads): Now a std::vector.  Now static.
6701         (hwdebug_find_thread_points_by_tid)
6702         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6703         Update.
6704
6705 2019-05-04  Tom Tromey  <tom@tromey.com>
6706
6707         * arc-tdep.c (arc_tdesc_init): Return bool.
6708
6709 2019-05-04  Tom Tromey  <tom@tromey.com>
6710
6711         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6712         Use gdb_assert_not_reached.
6713
6714 2019-05-04  Tom Tromey  <tom@tromey.com>
6715
6716         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6717         "false".
6718
6719 2019-05-04  Tom Tromey  <tom@tromey.com>
6720
6721         * arc-tdep.c (arc_tdesc_init): Use bool.
6722
6723 2019-05-04  Tom Tromey  <tom@tromey.com>
6724
6725         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6726
6727 2019-05-04  Tom Tromey  <tom@tromey.com>
6728
6729         * cli/cli-cmds.c (valid_command_p): Return bool.
6730
6731 2019-05-04  Tom Tromey  <tom@tromey.com>
6732
6733         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6734         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6735
6736 2019-05-04  Raul Tambre  <raul@tambre.ee>
6737
6738         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6739         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6740         operator for comparison.
6741
6742 2019-05-04  Tom Tromey  <tom@tromey.com>
6743
6744         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6745         (lookup_partial_symbol, print_partial_symbols)
6746         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6747         (psymbol_compare): Update.
6748         (add_psymbol_to_bcache): Clear the entire psymbol.
6749         (maintenance_check_psymtabs): Update.
6750         * psympriv.h (struct partial_symbol): Don't derive from
6751         general_symbol_info.
6752         <obj_section, unrelocated_address, address,
6753         set_unrelocated_address>: Update.
6754         <ginfo>: New member.
6755         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6756         (debug_names::write_psymbols): Update.
6757
6758 2019-05-04  Tom de Vries  <tdevries@suse.de>
6759
6760         * contrib/cc-with-tweaks.sh: Support -n arg.
6761
6762 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6763
6764         * corelow.c (core_target::detach): Ensure frame cache and
6765         register caches are cleared.
6766         inferior.c (exit_inferior_1): Likewise.
6767
6768 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6769             Tom Tromey  <tom@tromey.com>
6770
6771         * dictionary.c (collate_pending_symbols_by_language): Remove
6772         "struct" from foreach.
6773         * symtab.c (lookup_global_symbol_from_objfile)
6774         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6775         foreach.
6776         * ser-tcp.c (net_open): Remove "struct" from foreach.
6777         * objfiles.c (objfile_relocate, objfile_rebase)
6778         (objfile_has_symbols): Remove "struct" from foreach.
6779         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6780         from foreach.
6781         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6782         foreach.
6783         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6784         "struct" from foreach.
6785         * ada-lang.c (create_excep_cond_exprs)
6786         (ada_exception_catchpoint_cond_string): Remove "struct" from
6787         foreach.
6788
6789 2019-05-03  Tom Tromey  <tromey@adacore.com>
6790
6791         * ada-exp.y (convert_char_literal): Check suffix of each
6792         enumerator.
6793
6794 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6795
6796         PR ada/21406:
6797         * ada-exp.y (yywrap): Don't define.
6798         * ada-lex.l (%option): Add noyywrap
6799         (yywrap): Remove.
6800
6801 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6802
6803         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6804         _WIN32_WINNT to the XP level, unless already defined to a higher
6805         level.
6806
6807         * unittests/parse-connection-spec-selftests.c:
6808         * ser-tcp.c:
6809         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6810         override.
6811
6812         * symfile.c (find_separate_debug_file): Remove colon from the
6813         drive spec of DOS/Windows file names of the target, so that the
6814         file name produced from DEBUGDIR and the target's directory will
6815         be valid on DOS/Windows systems.
6816
6817 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6818
6819         * rust-lang.c (val_print_struct): Handle printing structures
6820         containing strings.
6821
6822 2019-05-02  Tom Tromey  <tromey@adacore.com>
6823
6824         * valarith.c (_initialize_valarith): Remove.
6825
6826 2019-05-01  Tom Tromey  <tromey@adacore.com>
6827
6828         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6829         bitfields.
6830
6831 2019-05-01  Tom Tromey  <tromey@adacore.com>
6832
6833         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6834         for big-endian copies.
6835
6836 2019-04-30  Ali Tamur  <tamur@google.com>
6837         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6838         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6839         (read_3_bytes): New function.
6840
6841 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6842
6843         * windows-nat.c (main_thread_id): Delete.
6844         (handle_output_debug_string): Replace main_thread_id by
6845         current_event.dwThreadId.
6846         (fake_create_process): Likewise.
6847         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6848         Do not set main_thread_id.
6849         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6850         current_event.dwThreadId.
6851         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6852
6853 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6854
6855         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6856         Use current_event.dwThreadId instead of main_thread_id.
6857
6858 2019-04-30  Tom Tromey  <tromey@adacore.com>
6859
6860         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6861         (create_excep_cond_exprs): Iterate over program spaces.
6862         (ada_exception_catchpoint_cond_string): Examine all minimal
6863         symbols for exception types.
6864
6865 2019-04-30  Tom Tromey  <tromey@adacore.com>
6866
6867         PR c++/24470:
6868         * dwarf2read.c (process_structure_scope): Handle case where type
6869         has template parameters but no symbol was created.
6870
6871 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6872             Chris January  <chris.january@arm.com>
6873
6874         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6875         qualifier.
6876         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6877
6878 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6879
6880         * f-typeprint.c (f_print_type): Update rules for printing
6881         whitespace.
6882         (f_type_print_varspec_suffix): Likewise.
6883
6884 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6885             Chris January  <chris.january@arm.com>
6886
6887         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6888         function arguments.
6889
6890 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6891
6892         * f-lang.c (build_fortran_types): Change name of void type to
6893         lower case.
6894         * f-typeprint.c (f_type_print_base): Print the name of the void
6895         type, rather than a fixed string.
6896         * f-valprint.c (f_decorations): Use lower case void string.
6897
6898 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6899             Chris January  <chris.january@arm.com>
6900
6901         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6902         types for Fortran.
6903
6904 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6905             Chris January  <chris.january@arm.com>
6906             David Lecomber  <david.lecomber@arm.com>
6907
6908         * f-exp.y (BINOP_INTRINSIC): New token.
6909         (exp): New parser rule handling BINOP_INTRINSIC.
6910         (f77_keywords): Add new builtin procedures.
6911         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6912         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6913         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6914         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6915         (print_unop_subexp_f): New function.
6916         (print_binop_subexp_f): New function.
6917         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6918         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6919         (dump_subexp_body_f): Likewise.
6920         (operator_check_f): Likewise.
6921         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6922         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6923
6924 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6925
6926         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6927         UNOP_KIND.
6928         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6929         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6930         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6931         (operator_length_f): New fuction.
6932         (print_subexp_f): New function.
6933         (op_name_f): New function.
6934         (dump_subexp_body_f): New function.
6935         (operator_check_f): New function.
6936         (exp_descriptor_f): Replace standard expression handling functions
6937         with new functions.
6938         * gdb/fortran-operator.def: New file.
6939         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6940         * gdb/std-operator.def: Remove UNOP_KIND.
6941
6942 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6943
6944         * std-operator.def: Remove unbalanced, stray double quote
6945         character.
6946
6947 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6948             Chris January  <chris.january@arm.com>
6949             Daniel Everett  <daniel.everett@arm.com>
6950             Nick Forrington  <nick.forrington@arm.com>
6951             Richard Bunt  <richard.bunt@arm.com>
6952
6953         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6954         of depth when printing anonymous structs or unions.
6955         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6956         Don't print either the top-level value, or the children if the
6957         max-depth is exceeded.
6958         (ppscm_print_children): When printing the key of a map, allow one
6959         extra level of depth.
6960         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6961         print either the top-level value, or the children if the max-depth
6962         is exceeded.
6963         (print_children): When printing the key of a map, allow one extra
6964         level of depth.
6965         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6966         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6967         (user_print_options): Initialise max_depth field.
6968         (val_print_scalar_or_string_type_p): New function.
6969         (val_print): Check to see if the max depth has been reached.
6970         (val_print_check_max_depth): Define new function.
6971         (show_print_max_depth): New function.
6972         (_initialize_valprint): Add 'print max-depth' option.
6973         * valprint.h (struct value_print_options) <max_depth>: New field.
6974         (val_print_check_max_depth): Declare new function.
6975         * NEWS: Document new feature.
6976
6977 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6978
6979         * ada-lang.c (ada_language_defn): Initialise new field.
6980         * c-lang.c (c_is_string_type_p): New function.
6981         (c_language_defn): Initialise new field.
6982         (cplus_language_defn): Initialise new field.
6983         (asm_language_defn): Initialise new field.
6984         (minimal_language_defn): Initialise new field.
6985         * c-lang.h (c_is_string_type_p): Declare new function.
6986         * d-lang.c (d_language_defn): Initialise new field.
6987         * f-lang.c (f_is_string_type_p): New function.
6988         (f_language_defn): Initialise new field.
6989         * go-lang.c (go_is_string_type_p): New function.
6990         (go_language_defn): Initialise new field.
6991         * language.c (default_is_string_type_p): New function.
6992         (unknown_language_defn): Initialise new field.
6993         (auto_language_defn): Initialise new field.
6994         * language.h (struct language_defn) <la_is_string_type_p>: New
6995         member variable.
6996         (default_is_string_type_p): Declare new function.
6997         * m2-lang.c (m2_language_defn): Initialise new field.
6998         * objc-lang.c (objc_language_defn): Initialise new field.
6999         * opencl-lang.c (opencl_language_defn): Initialise new field.
7000         * p-lang.c (pascal_is_string_type_p): New function.
7001         (pascal_language_defn): Initialise new field.
7002         * rust-lang.c (rust_is_string_type_p): New function.
7003         (rust_language_defn): Initialise new field.
7004
7005 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7006
7007         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7008         New field.
7009         * ada-lang.c (ada_language_defn): Initialise new field.
7010         * c-lang.c (c_language_defn): Likewise.
7011         (cplus_language_defn): Likewise.
7012         (asm_language_defn): Likewise.
7013         (minimal_language_defn): Likewise.
7014         * d-lang.c (d_language_defn): Likewise.
7015         * f-lang.c (f_language_defn): Likewise.
7016         * go-lang.c (go_language_defn): Likewise.
7017         * language.c (unknown_language_defn): Likewise.
7018         (auto_language_defn): Likewise.
7019         * m2-lang.c (m2_language_defn): Likewise.
7020         * objc-lang.c (objc_language_defn): Likewise.
7021         * opencl-lang.c (opencl_language_defn): Likewise.
7022         * p-lang.c (pascal_language_defn): Likewise.
7023         * rust-lang.c (rust_language_defn): Likewise.
7024
7025 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7026
7027         * ada-lang.c (ada_is_character_type): Change return type to bool.
7028         (ada_is_string_type): Likewise.
7029         * ada-lang.h (ada_is_character_type): Update declaration
7030         (ada_is_string_type): Likewise.
7031
7032 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7033
7034         Support style in 'frame|thread apply'
7035
7036         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7037         * record.c (record_start, record_stop): Update callers of
7038         execute_command_to_string with false.
7039         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7040         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7041         methods.
7042         (class string_file): New constructor with term_out parameter.
7043         Override methods term_out and can_emit_style_escape.  New member
7044         term_out.
7045         (class stdio_file): Override can_emit_style_escape.
7046         (class tee_file): Override term_out and can_emit_style_escape.
7047         * utils.h (can_emit_style_escape): Remove.
7048         * utils.c (can_emit_style_escape): Likewise.
7049         Update all callers of can_emit_style_escape (SOMESTREAM) to
7050         SOMESTREAM->can_emit_style_escape.
7051         * source-cache.c (source_cache::get_source_lines): Likewise.
7052         * stack.c (frame_apply_command_count): Call execute_command_to_string
7053         passing the term_out characteristic of the current gdb_stdout.
7054         * thread.c (thr_try_catch_cmd): Likewise.
7055         * top.c (execute_command_to_string): pass term_out parameter
7056         to construct the string_file for the command output.
7057         * ui-file.c (term_cli_styling): New function (most code moved
7058         from utils.c can_emit_style_escape).
7059         (string_file::string_file, string_file::can_emit_style_escape,
7060         stdio_file::can_emit_style_escape, tee_file::term_out,
7061         tee_file::can_emit_style_escape): New functions.
7062
7063 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7064
7065         * NEWS: Mention the new set|show may-call-functions.
7066         * infcall.c (may_call_functions_p): New variable.
7067         (show_may_call_functions_p): New function.
7068         (call_function_by_hand_dummy): Throws an error if not
7069         may-call-functions.
7070         (_initialize_infcall): Call add_setshow_boolean_cmd for
7071         may-call-functions.
7072
7073 2019-04-25  Keith Seitz  <keiths@redhat.com>
7074
7075         PR c++/24367
7076         * cp-support.c (inspect_type): Don't attempt substitutions
7077         of symbol with the same name.
7078
7079 2019-04-25  Tom Tromey  <tromey@adacore.com>
7080
7081         PR gdb/24475:
7082         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7083         static.
7084
7085 2019-04-25  Tom Tromey  <tromey@adacore.com>
7086
7087         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7088         rvalue reference.
7089         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7090         (gdb_xml_parser::parse): Use std::move.
7091         * python/python-internal.h (gdbpy_convert_exception): Take a const
7092         reference.
7093         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7094         std::move.
7095         * python/py-utils.c (gdbpy_convert_exception): Take a const
7096         reference.
7097         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7098         Use std::move.
7099         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7100         Use std::move.
7101         * mi/mi-main.c (mi_print_exception): Take a const reference.
7102         * main.c (handle_command_errors): Take a const reference.
7103         * linespec.c (parse_linespec): Use std::move.
7104         * infcall.c (run_inferior_call): Use std::move.
7105         (call_function_by_hand_dummy): Use std::move.
7106         * exec.c (try_open_exec_file): Use std::move.
7107         * exceptions.h (exception_print, exception_fprintf)
7108         (exception_print_same): Update.
7109         * exceptions.c (print_exception, exception_print)
7110         (exception_fprintf, exception_print_same): Change parameters to
7111         const reference.
7112         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7113         * common/new-op.c: Use std::move.
7114         * common/common-exceptions.h (struct gdb_exception): Add move
7115         constructor.
7116         (struct gdb_exception_error, struct gdb_exception_quit, struct
7117         gdb_quit_bad_alloc): Change constructor to move constructor.
7118         (throw_exception): Change parameter to rvalue reference.
7119         * common/common-exceptions.c (throw_exception): Take rvalue
7120         reference.
7121         * cli/cli-interp.c (safe_execute_command): Use std::move.
7122         * breakpoint.c (insert_bp_location, location_to_sals): Use
7123         std::move.
7124
7125 2019-04-25  Tom Tromey  <tromey@adacore.com>
7126
7127         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7128         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7129         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7130         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7131         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7132         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7133         guile/scm-value.c: Use unpack.
7134         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7135         gdbscm_gdb_exception.
7136         (gdbscm_throw_gdb_exception): Likewise.
7137         (struct gdbscm_gdb_exception): New.
7138         (unpack): New function.
7139         (gdbscm_wrap): Use unpack.
7140
7141 2019-04-25  Tom Tromey  <tromey@adacore.com>
7142
7143         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7144         (gdb_rl_callback_handler): Use std::move.
7145         * common/common-exceptions.h (struct gdb_exception): Add move
7146         assignment operator.
7147         (throw_exception_sjlj): Change "exception" to const reference.
7148         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7149         (throw_exception_sjlj): Change "exception" to const reference.
7150
7151 2019-04-25  Tom Tromey  <tromey@adacore.com>
7152
7153         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7154         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7155         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7156         Update.
7157         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7158         Update.
7159         * mi/mi-interp.c (mi_interp::exec): Update.
7160         * linespec.c (parse_linespec): Update.
7161         * infcall.c (run_inferior_call): Update.
7162         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7163         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7164         (gdbscm_lookup_global_symbol): Update.
7165         * guile/scm-param.c (gdbscm_parameter_value): Update.
7166         * guile/scm-frame.c (gdbscm_frame_read_register)
7167         (gdbscm_frame_read_var): Update.
7168         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7169         * exec.c (try_open_exec_file): Update.
7170         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7171         (gdb_rl_callback_handler): Update.
7172         * common/common-exceptions.h (exception_none): Don't declare.
7173         * common/common-exceptions.c (exception_none): Don't define.
7174         (struct catcher) <exception>: Update.
7175         * cli/cli-interp.c (safe_execute_command): Update.
7176         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7177
7178 2019-04-25  Ali Tamur  <tamur@google.com>
7179
7180         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7181         (read_attribute_value): Likewise.
7182         (dwarf2_read_addr_index): Update comment.
7183         (read_str_index): Add DW_FORM_strx.
7184         (dwarf2_string_attr): Likewise.
7185         (dwarf2_const_value_attr): Likewise.
7186         (dump_die_shallow): Likewise.
7187         (dwarf2_fetch_constant_bytes): Likewise.
7188         (skip_form_bytes): Likewise.
7189         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7190
7191 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7192
7193         PR corefiles/11608
7194         PR corefiles/18187
7195         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7196         OFFSET.  Verify if current mapping contains an ELF header.
7197         (linux_find_memory_regions_full): Adjust call to
7198         dump_mapping_p.
7199
7200 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7201             Kang Li <kanglictf@gmail.com>
7202
7203         PR gdb/21600
7204
7205         * dwarf2-frame.c (read_initial_length): Be consistent about using
7206         unsigned representation of length.
7207         (decode_frame_entry_1): Likewise.  Check for wraparound of
7208         end pointer as well as buffer overflow.
7209
7210 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7211
7212         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7213         "vq".
7214
7215 2019-04-24  Tom Tromey  <tromey@adacore.com>
7216
7217         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7218
7219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7220
7221         * s12z-tdep.c (s12z_unwind_pc): Delete.
7222         (s12z_unwind_sp): Delete.
7223         (s12z_gdbarch_init): Don't register deleted functions with
7224         gdbarch.
7225
7226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7227
7228         * rl78-tdep.c (rl78_unwind_sp): Delete.
7229         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7230
7231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7232
7233         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7234         (xstormy16_unwind_pc): Delete.
7235         (xstormy16_dummy_id): Delete.
7236         (xstormy16_gdbarch_init): Don't register deleted functions with
7237         gdbarch.
7238
7239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7240
7241         * vax-tdep.c (vax_unwind_pc): Delete.
7242         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7243
7244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7245
7246         * v850-tdep.c (v850_unwind_sp): Delete.
7247         (v850_unwind_pc): Delete.
7248         (v850_dummy_id): Delete.
7249         (v850_gdbarch_init): Don't register deleted functions with
7250         gdbarch.
7251
7252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7253
7254         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7255         (tilegx_unwind_pc): Delete.
7256         (tilegx_unwind_dummy_id): Delete.
7257         (tilegx_gdbarch_init): Don't register deleted functions with
7258         gdbarch.
7259
7260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7261
7262         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7263         (tic6x_dummy_id): Delete.
7264         (tic6x_gdbarch_init): Don't register deleted functions with
7265         gdbarch.
7266
7267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7268
7269         * sparc-tdep.c (sparc_unwind_pc): Delete.
7270         (sparc32_gdbarch_init): Don't register deleted function with
7271         gdbarch.
7272
7273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7274
7275         * sh-tdep.c (sh_unwind_sp): Delete.
7276         (sh_unwind_pc): Delete.
7277         (sh_dummy_id): Delete.
7278         (sh_gdbarch_init): Don't register deleted functions with
7279         gdbarch.
7280
7281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7282
7283         * score-tdep.c (score_unwind_sp): Delete.
7284         (score_unwind_pc): Delete.
7285         (score_dummy_id): Delete.
7286         (score_gdbarch_init): Don't register deleted functions with
7287         gdbarch.
7288
7289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7290
7291         * rx-tdep.c (rx_unwind_pc): Delete.
7292         (rx_unwind_sp): Delete.
7293         (rx_dummy_id): Delete.
7294         (rx_gdbarch_init): Don't register deleted functions with
7295         gdbarch.  Update comment.
7296
7297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7300         (rs6000_dummy_id): Delete.
7301         (rs6000_gdbarch_init): Don't register deleted functions with
7302         gdbarch.
7303
7304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7305
7306         * or1k-tdep.c (or1k_dummy_id): Delete.
7307         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7308
7309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7310
7311         * nios2-tdep.c (nios2_dummy_id): Delete.
7312         (nios2_unwind_sp): Delete.
7313         (nios2_gdbarch_init): Don't register deleted functions with
7314         gdbarch.
7315
7316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7317
7318         * nds32-tdep.c (nds32_dummy_id): Delete.
7319         (nds32_unwind_pc): Delete.
7320         (nds32_unwind_sp): Delete.
7321         (nds32_gdbarch_init): Don't register deleted functions with
7322         gdbarch.
7323
7324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7325
7326         * msp430-tdep.c (msp430_unwind_pc): Delete.
7327         (msp430_unwind_sp): Delete.
7328         (msp430_dummy_id): Delete.
7329         (msp430_gdbarch_init): Don't register deleted functions with
7330         gdbarch.
7331
7332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7333
7334         * moxie-tdep.c (moxie_unwind_sp): Delete.
7335         (moxie_unwind_pc): Delete.
7336         (moxie_dummy_id): Delete.
7337         (moxie_gdbarch_init): Don't register deleted functions with
7338         gdbarch.
7339
7340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7341
7342         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7343         (mn10300_unwind_pc): Delete.
7344         (mn10300_unwind_sp): Delete.
7345         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7346         mn10300_unwind_sp.
7347         (mn10300_frame_unwind_init): Don't register deleted functions with
7348         gdbarch.
7349
7350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7351
7352         * mep-tdep.c (mep_unwind_pc): Delete.
7353         (mep_unwind_sp): Delete.
7354         (mep_dummy_id): Delete.
7355         (mep_gdbarch_init): Don't register deleted functions with
7356         gdbarch.
7357
7358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7359
7360         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7361         (m68hc11_unwind_sp): Delete.
7362         (m68hc11_gdbarch_init): Don't register deleted functions with
7363         gdbarch.
7364
7365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7366
7367         * m32r-tdep.c (m32r_unwind_sp): Delete.
7368         (m32r_unwind_pc): Delete.
7369         (m32r_dummy_id): Delete.
7370         (m32r_gdbarch_init): Don't register deleted functions with
7371         gdbarch.
7372
7373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7374
7375         * m32c-tdep.c (m32c_unwind_pc): Delete.
7376         (m32c_unwind_sp): Delete.
7377         (m32c_dummy_id): Delete.
7378         (m32c_gdbarch_init): Don't register deleted functions with
7379         gdbarch.
7380
7381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7382
7383         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7384         (lm32_unwind_pc): Delete.
7385         (lm32_dummy_id): Delete.
7386         (lm32_gdbarch_init): Don't register deleted functions with
7387         gdbarch.
7388
7389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7390
7391         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7392         (iq2000_unwind_pc): Delete.
7393         (iq2000_dummy_id): Delete.
7394         (iq2000_gdbarch_init): Don't register deleted functions with
7395         gdbarch.
7396
7397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7398
7399         * nds32-tdep.c (nds32_type_align): Delete.
7400         (nds32_push_dummy_call): Use type_align instead.
7401
7402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7403
7404         * arm-tdep.c (arm_type_align): Only handle vector override case.
7405         (arm_push_dummy_call): Use type_align.
7406         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7407
7408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7409
7410         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7411         case.
7412         (pass_on_stack): Use type_align.
7413         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7414         function.
7415
7416 2019-04-23  Tom Tromey  <tromey@adacore.com>
7417
7418         * dwarf2read.c (line_header::file_name_at): Remove unused
7419         overload.
7420
7421 2019-04-23  Tom de Vries  <tdevries@suse.de>
7422
7423         PR gdb/24438
7424         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7425         invocation.
7426
7427
7428 2019-03-27  Ali Tamur  <tamur@google.com>
7429
7430         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7431         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7432         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7433         (dwarf_expr_context::get_addr_index): Likewise
7434         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7435         (symbol_needs_eval_context::get_addr_index): Likewise
7436         (disassemble_dwarf_expression): Add DW_OP_addrx
7437         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7438         (read_cutu_die_from_dwo): Update comment
7439         (skip_one_die): Add DW_FORM_addrx
7440         (read_attribute_value): Likewise
7441         (var_decode_location): Add DW_OP_addrx
7442         (dwarf2_const_value_attr): Add DW_FORM_addrx
7443         (dump_die_shallow): Likewise
7444         (dwarf2_fetch_constant_bytes): Likewise
7445         (decode_locdesc): Add DW_OP_addrx
7446         (skip_form_bytes): Add DW_FORM_addrx
7447
7448 2019-04-22  Ali Tamur  <tamur@google.com>
7449
7450         * MAINTAINERS (Write After Approval): Add self.
7451
7452 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7453
7454         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7455         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7456         (open_symbol_file_object): Likewise.
7457         (svr4_default_sos): Add info parameter.
7458         (svr4_read_so_list): Likewise.
7459         (svr4_current_sos_direct): Adjust functions calls to pass down
7460         info.
7461         (svr4_current_sos_1): Add info parameter.
7462         (svr4_current_sos): Call get_svr4_info, pass info down to
7463         svr4_current_sos_1.
7464         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7465         get_svr4_info.
7466         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7467         get_svr4_info.
7468         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7469         to get_svr4_info.
7470         (probes_table_remove_objfile_probes): Likewise.
7471         (register_solib_event_probe): Add info parameter.
7472         (solist_update_incremental): Pass info parameter down to
7473         svr4_read_so_list.
7474         (disable_probes_interface): Add info parameter.
7475         (svr4_handle_solib_event): Pass current_program_space to
7476         get_svr4_info.  Adjust disable_probes_interface cleanup.
7477         (svr4_create_probe_breakpoints): Add info parameter, pass it
7478         down to register_solib_event_probe.
7479         (svr4_create_solib_event_breakpoints): Add info parameter,
7480         pass it down to svr4_create_probe_breakpoints.
7481         (enable_break): Pass info down to
7482         svr4_create_solib_event_breakpoints.
7483         (svr4_solib_create_inferior_hook): Pass current_program_space to
7484         get_svr4_info.
7485         (svr4_clear_solib): Likewise.
7486
7487 2019-04-22  Pedro Alves  <palves@redhat.com>
7488
7489         * solib-svr4.c (svr4_free_objfile_observer): New.
7490         (probe_and_action::objfile): New field.
7491         (probes_table_htab_remove_objfile_probes)
7492         (probes_table_remove_objfile_probes): New functions.
7493         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7494         in the new probe_and_action.  Don't store the probe in 'lookup'.
7495         (svr4_create_probe_breakpoints): Pass objfile to
7496         register_solib_event_probe.
7497         (_initialize_svr4_solib): Register a free_objfile observer.
7498
7499 2019-04-19  Tom Tromey  <tom@tromey.com>
7500
7501         * common/queue.h: Remove.
7502
7503 2019-04-19  Tom Tromey  <tom@tromey.com>
7504
7505         * event-loop.c: Don't include "common/queue.h".
7506
7507 2019-04-19  Tom Tromey  <tom@tromey.com>
7508
7509         * remote.c (remote_target): Use delete.
7510         * remote-notif.h: Include <list>, not "common/queue.h".
7511         (notif_client_p): Remove typedef.
7512         (remote_notif_state): Add constructor, destructor, initializer.
7513         <notif_queue>: Now a std::list.
7514         (remote_notif_state_xfree): Don't declare.
7515         * remote-notif.c (remote_notif_process, handle_notification)
7516         (remote_notif_state_allocate): Update.
7517         (~remote_notif_state): Rename from remote_notif_state_xfree.
7518
7519 2019-04-19  Tom Tromey  <tom@tromey.com>
7520
7521         * symfile.c (reread_symbols): Update.
7522         * objfiles.c (objfile_register_static_link)
7523         (objfile_lookup_static_link): Update
7524         (~objfile) Don't delete static_links.
7525         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7526
7527 2019-04-19  Tom Tromey  <tom@tromey.com>
7528
7529         * type-stack.h (struct type_stack) <insert>: Constify string.
7530         * type-stack.c (type_stack::insert): Constify string.
7531         * gdbtypes.h (lookup_template_type): Update.
7532         (address_space_name_to_int): Update.
7533         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7534         const.
7535         (lookup_template_type): Make name const.
7536         * c-exp.y: Update rules.
7537         (lex_one_token, classify_name, classify_inner_name)
7538         (c_print_token): Update.
7539         * p-exp.y: Update rules.
7540         (yylex): Update.
7541         * f-exp.y: Update rules.
7542         (yylex): Update.
7543         * d-exp.y: Update rules.
7544         (lex_one_token, classify_name, classify_inner_name): Update.
7545         * parse.c (write_dollar_variable, copy_name): Return std::string.
7546         * parser-defs.h (copy_name): Change return type.
7547         * m2-exp.y: Update rules.
7548         (yylex): Update.
7549         * go-exp.y (lex_one_token): Update.
7550         Update rules.
7551         (classify_unsafe_function, classify_packaged_name)
7552         (classify_name, yylex): Update.
7553
7554 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7555
7556         * configure.ac: add --enable-source-highlight switch.
7557         * configure: Regenerate.
7558         * top.c (print_gdb_version): plumb --enable-source-highlight
7559         status to "show configuration".
7560
7561 2019-04-19  Tom Tromey  <tromey@adacore.com>
7562
7563         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7564         Check ADA_TYPE_P.
7565         (empty_record, ada_template_to_fixed_record_type_1)
7566         (template_to_static_fixed_type)
7567         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7568         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7569         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7570         macros.
7571
7572 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7573
7574         PR symtab/24423:
7575         * source.c (print_source_lines_base): Advance "iter" when a
7576         control character is seen.
7577
7578 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7579
7580         * inferior.h (struct infcall_suspend_state_deleter):
7581         Catch exception in destructor to avoid crash.
7582
7583 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7584
7585         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7586         close to the add_com "shell".
7587
7588 2019-04-18  Tom Tromey  <tromey@adacore.com>
7589
7590         * process-stratum-target.h (class process_stratum_target)
7591         <stratum>: Add "final".
7592
7593 2019-04-17  Tom Tromey  <tromey@adacore.com>
7594
7595         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7596         against nullptr before use.
7597
7598 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7599
7600         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7601
7602 2019-04-17  Jim Wilson  <jimw@sifive.com>
7603             Andrew Burgess  <andrew.burgess@embecosm.com>
7604
7605         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7606         code read might fail, assume 4-byte breakpoint in that case.
7607
7608 2019-04-15  Leszek Swirski  <leszeks@google.com>
7609
7610         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7611         rather than a hand-rolled POD check when checking for forced MEMORY
7612         classification.
7613
7614 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7615
7616         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7617         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7618         function.
7619         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7620         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7621         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7622         declaration.
7623
7624 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7625
7626         * aarch64-linux-nat.c
7627         (aarch64_linux_nat_target::thread_architecture): Add override.
7628         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7629         each VQ.
7630
7631 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7632
7633         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7634
7635 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7636
7637         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7638         target types of size 96-bits, add some additional comments, and
7639         check that the builtin type we found was the correct size.
7640
7641 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7642
7643         * utils.c (prompt_for_continue): Don't restore the styling at the
7644         end, as applied_style has the wrong value.  This fixes styling in
7645         long lists of file names that are interrupted by the "Continue?"
7646         prompt.
7647
7648 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7649
7650         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7651         * c-lang.c (c_language_defn): Likewise.
7652         (cplus_language_defn): Likewise.
7653         (asm_language_defn): Likewise.
7654         (minimal_language_defn): Likewise.
7655         * d-lang.c (d_language_defn): Likewise.
7656         * f-lang.c (f_language_defn): Likewise.
7657         * go-lang.c (go_language_defn): Likewise.
7658         * language.c (unknown_language_defn): Likewise.
7659         (auto_language_defn): Likewise.
7660         * language.h (struct language_defn): Remove la_magic field.
7661         (LANG_MAGIC): Delete.
7662         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7663         * objc-lang.c (objc_language_defn): Likewise.
7664         * opencl-lang.c (opencl_language_defn): Likewise.
7665         * p-lang.c (pascal_language_defn): Likewise.
7666         * rust-lang.c (rust_language_defn): Likewise.
7667
7668 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7669
7670         * riscv-tdep.c (riscv_type_align): New function.
7671         (riscv_type_alignment): Delete.
7672         (riscv_arg_location): Use 'type_align'.
7673         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7674
7675 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7676
7677         * gdbtypes.c (type_align): A struct with no non-static fields also
7678         has alignment of 1.
7679
7680 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7681
7682         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7683         component to 0.
7684         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7685         member.
7686         (riscv_struct_info::analyse): New implementation using new
7687         analyse_inner member function.
7688         (riscv_struct_info::field_offset): New member function.
7689         (riscv_struct_info::m_offsets): New member variable.
7690         (riscv_struct_info::analyse_inner): New private member function,
7691         takes the old implementation of riscv_struct_info::analyse but
7692         extended to track field offsets.
7693         (riscv_call_arg_struct): Update the struct folding special cases
7694         to handle cases where empty C++ structs, which are non-zero
7695         length, are found.
7696         (riscv_arg_location): Initialise the length of each location, a
7697         non-zero length now indicates the location is in use.
7698         (riscv_push_dummy_call): Allow for the first location having a
7699         non-zero offset when setting up arguments.
7700         (riscv_return_value): Likewise, but for return values.
7701
7702 2019-04-11  Tom Tromey  <tromey@adacore.com>
7703
7704         * utils.c (internal_vproblem): Make "msg" const.
7705
7706 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7707
7708         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7709         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7710         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7711         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7712
7713 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7714
7715         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7716         function.
7717         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7718         of amd64_collect_native_gregset.
7719         (amd64_linux_nat_target::store_registers): Likewise.
7720
7721 2019-04-10  Tom Tromey  <tom@tromey.com>
7722
7723         * symtab.c (lookup_global_symbol_from_objfile)
7724         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7725         * objfiles.h (class separate_debug_iterator): New.
7726         (class separate_debug_range): New.
7727         (struct objfile) <separate_debug_objfiles>: New method.
7728         (objfile_separate_debug_iterate): Don't declare.
7729         * objfiles.c (separate_debug_iterator::operator++): Rename from
7730         objfile_separate_debug_iterate.
7731         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7732         iterator.
7733         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7734         iterator.
7735
7736 2019-04-10  Tom Tromey  <tom@tromey.com>
7737
7738         * symfile.c (reread_symbols): Remove old comment.
7739         * objfiles.c (free_all_objfiles): Fix a typo.
7740
7741 2019-04-10  Tom Tromey  <tom@tromey.com>
7742
7743         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7744         * minsyms.c (lookup_minimal_symbol): Use foreach.
7745         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7746         (lookup_minimal_symbol_solib_trampoline): Likewise.
7747         * symfile.c (reread_symbols): Use foreach.
7748
7749 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7750             Tom Tromey  <tromey@adacore.com>
7751
7752         PR rust/24414:
7753         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7754         (rust_lex_int_test): Change "value" to be LONGEST.
7755         (rust_lex_tests): Add test for long integer literal.
7756
7757 2019-04-09  Tom Tromey  <tromey@adacore.com>
7758
7759         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7760         to bool.
7761         (extended_remote_target::attach): Update.
7762         (remote_target::remote_notice_new_inferior): Update.
7763         (remote_target::add_current_inferior_and_thread): Update.
7764         * inferior.c (exit_inferior_1): Use "false".
7765         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7766
7767 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7768
7769         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7770         the "start" command.
7771
7772 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7773
7774         * python/py-inferior.c (infpy_thread_from_thread_handle):
7775         Adjust comments to reflect renaming of thread_from_thread_handle
7776         to thread_from_handle.  Adjust keywords.  Fix type error message.
7777         (inferior_object_methods): Add thread_from_handle.  Retain
7778         thread_from_thread_handle, but mark it as deprecated.
7779
7780 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7781
7782         * gdbthread.h (find_thread_by_handle): Revise declaration.
7783         * thread.c (find_thread_by_handle): Likewise.  Adjust
7784         implementation too.
7785         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7786         support for buffer objects as handles.
7787
7788 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7789
7790         * python/py-infthread.c (thpy_thread_handle): New function.
7791         (thread_object_methods): Register thpy_thread_handle.
7792
7793 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7794
7795         * gdbthread.h (thread_to_thread_handle): Declare.
7796         * thread.c (gdbtypes.h): Include.
7797         (thread_to_thread_handle): New function.
7798
7799         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7800         (target_thread_info_to_thread_handle): Declare.
7801         * target.c (target_thread_info_to_thread_handle): New function.
7802         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7803         * target-delegates.c: Regenerate.
7804
7805         * linux-thread-db.c (class thread_db_target): Add method
7806         thread_info_to_thread_handle.
7807         (thread_db_target::thread_info_to_thread_handle): Define.
7808         * remote.c (class remote_target): Add new method
7809         thread_info_to_thread_handle.
7810         (remote_target::thread_info_to_thread_handle): Define.
7811
7812 2019-04-08  Pedro Alves  <palves@redhat.com>
7813
7814         * common/common-exceptions.c (throw_exception): Don't create
7815         named object to throw; throw directly.
7816         (throw_it): Likewise.  Don't initialize gdb_exception::message
7817         here, with new; pass FMT and AP to the ctor instead.
7818         * common/common-exceptions.h: Include <string>.
7819         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7820         const char *, va_list)): New ctor.  Use std::make_shared.
7821         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7822         errors)): Delete.
7823         (gdb_exception_error::gdb_exception_error(enum errors, const char
7824         *, va_list)): New.
7825         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7826         Add assertion.
7827         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7828         errors)): Delete.
7829         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7830         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7831         Add assertion.
7832
7833 2019-04-08  Tom Tromey  <tom@tromey.com>
7834
7835         * valops.c (value_rtti_indirect_type): Replace throw_exception
7836         with throw.
7837         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7838         with throw.
7839         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7840         throw.
7841         * target.c (target_translate_tls_address): Replace throw_exception
7842         with throw.
7843         * stack.c (frame_apply_command_count): Replace throw_exception
7844         with throw.
7845         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7846         throw.
7847         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7848         with throw.
7849         * rs6000-tdep.c (rs6000_frame_cache)
7850         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7851         * remote.c: Replace throw_exception with throw.
7852         * record-full.c (record_full_message, record_full_wait_1)
7853         (record_full_restore): Replace throw_exception with throw.
7854         * record-btrace.c:
7855         (get_thread_current_frame_id, record_btrace_start_replaying)
7856         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7857         (cmd_record_btrace_start): Replace throw_exception with throw.
7858         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7859         throw.
7860         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7861         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7862         * linespec.c:
7863         (find_linespec_symbols): Replace throw_exception with throw.
7864         * infrun.c (displaced_step_prepare, resume): Replace
7865         throw_exception with throw.
7866         * infcmd.c (post_create_inferior): Replace throw_exception with
7867         throw.
7868         * inf-loop.c (inferior_event_handler): Replace throw_exception
7869         with throw.
7870         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7871         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7872         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7873         (get_prev_frame_always, get_frame_pc_if_available)
7874         (get_frame_address_in_block_if_available, get_frame_language):
7875         Replace throw_exception with throw.
7876         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7877         throw_exception with throw.
7878         * eval.c (fetch_subexp_value, evaluate_var_value)
7879         (evaluate_funcall, evaluate_subexp_standard): Replace
7880         throw_exception with throw.
7881         * dwarf2loc.c (call_site_find_chain)
7882         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7883         Replace throw_exception with throw.
7884         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7885         with throw.
7886         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7887         throw.
7888         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7889         * completer.c (complete_line_internal): Replace throw_exception
7890         with throw.
7891         * compile/compile-object-run.c (compile_object_run): Replace
7892         throw_exception with throw.
7893         * cli/cli-script.c (process_next_line): Replace throw_exception
7894         with throw.
7895         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7896         (btrace_enable, btrace_maint_update_pt_packets): Replace
7897         throw_exception with throw.
7898         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7899         throw_exception with throw.
7900         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7901         throw_exception with throw.
7902         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7903         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7904         * aarch64-tdep.c (aarch64_make_prologue_cache)
7905         (aarch64_make_stub_cache): Replace throw_exception with throw.
7906
7907 2019-04-08  Tom Tromey  <tom@tromey.com>
7908
7909         * common/common-exceptions.c (throw_exception): Rename from
7910         throw_exception_cxx.  Remove old copy.  Make argument const.
7911         (throw_it): Create and throw exception objects directly.
7912         * common/common-exceptions.h (throw_exception): Make argument
7913         const.
7914         (struct gdb_exception_error): Add constructor.
7915         (struct gdb_exception_quit): Add constructor.
7916
7917 2019-04-08  Tom Tromey  <tom@tromey.com>
7918
7919         * common/common-exceptions.h (exception_rethrow): Don't declare.
7920         (TRY_SJLJ): Update comment.
7921         (TRY, CATCH, END_CATCH): Remove.
7922         * common/common-exceptions.c (exception_rethrow): Remove.
7923
7924 2019-04-08  Tom Tromey  <tom@tromey.com>
7925
7926         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7927         Remove.
7928         (gdb_exception_error): Rename from
7929         gdb_exception_RETURN_MASK_ERROR.
7930         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7931         (gdb_quit_bad_alloc): Update.
7932         * aarch64-tdep.c: Update.
7933         * ada-lang.c: Update.
7934         * ada-typeprint.c: Update.
7935         * ada-valprint.c: Update.
7936         * amd64-tdep.c: Update.
7937         * arch-utils.c: Update.
7938         * break-catch-throw.c: Update.
7939         * breakpoint.c: Update.
7940         * btrace.c: Update.
7941         * c-varobj.c: Update.
7942         * cli/cli-cmds.c: Update.
7943         * cli/cli-interp.c: Update.
7944         * cli/cli-script.c: Update.
7945         * common/common-exceptions.c: Update.
7946         * common/new-op.c: Update.
7947         * common/selftest.c: Update.
7948         * compile/compile-c-symbols.c: Update.
7949         * compile/compile-cplus-symbols.c: Update.
7950         * compile/compile-object-load.c: Update.
7951         * compile/compile-object-run.c: Update.
7952         * completer.c: Update.
7953         * corelow.c: Update.
7954         * cp-abi.c: Update.
7955         * cp-support.c: Update.
7956         * cp-valprint.c: Update.
7957         * darwin-nat.c: Update.
7958         * disasm-selftests.c: Update.
7959         * dtrace-probe.c: Update.
7960         * dwarf-index-cache.c: Update.
7961         * dwarf-index-write.c: Update.
7962         * dwarf2-frame-tailcall.c: Update.
7963         * dwarf2-frame.c: Update.
7964         * dwarf2loc.c: Update.
7965         * dwarf2read.c: Update.
7966         * eval.c: Update.
7967         * event-loop.c: Update.
7968         * event-top.c: Update.
7969         * exec.c: Update.
7970         * f-valprint.c: Update.
7971         * fbsd-tdep.c: Update.
7972         * frame-unwind.c: Update.
7973         * frame.c: Update.
7974         * gdbtypes.c: Update.
7975         * gnu-v3-abi.c: Update.
7976         * guile/guile-internal.h: Update.
7977         * guile/scm-block.c: Update.
7978         * guile/scm-breakpoint.c: Update.
7979         * guile/scm-cmd.c: Update.
7980         * guile/scm-disasm.c: Update.
7981         * guile/scm-frame.c: Update.
7982         * guile/scm-lazy-string.c: Update.
7983         * guile/scm-math.c: Update.
7984         * guile/scm-param.c: Update.
7985         * guile/scm-ports.c: Update.
7986         * guile/scm-pretty-print.c: Update.
7987         * guile/scm-symbol.c: Update.
7988         * guile/scm-symtab.c: Update.
7989         * guile/scm-type.c: Update.
7990         * guile/scm-value.c: Update.
7991         * i386-linux-tdep.c: Update.
7992         * i386-tdep.c: Update.
7993         * inf-loop.c: Update.
7994         * infcall.c: Update.
7995         * infcmd.c: Update.
7996         * infrun.c: Update.
7997         * jit.c: Update.
7998         * language.c: Update.
7999         * linespec.c: Update.
8000         * linux-fork.c: Update.
8001         * linux-nat.c: Update.
8002         * linux-tdep.c: Update.
8003         * linux-thread-db.c: Update.
8004         * main.c: Update.
8005         * mi/mi-cmd-break.c: Update.
8006         * mi/mi-cmd-stack.c: Update.
8007         * mi/mi-interp.c: Update.
8008         * mi/mi-main.c: Update.
8009         * objc-lang.c: Update.
8010         * p-valprint.c: Update.
8011         * parse.c: Update.
8012         * ppc-linux-tdep.c: Update.
8013         * printcmd.c: Update.
8014         * python/py-arch.c: Update.
8015         * python/py-breakpoint.c: Update.
8016         * python/py-cmd.c: Update.
8017         * python/py-finishbreakpoint.c: Update.
8018         * python/py-frame.c: Update.
8019         * python/py-framefilter.c: Update.
8020         * python/py-gdb-readline.c: Update.
8021         * python/py-inferior.c: Update.
8022         * python/py-infthread.c: Update.
8023         * python/py-lazy-string.c: Update.
8024         * python/py-linetable.c: Update.
8025         * python/py-objfile.c: Update.
8026         * python/py-param.c: Update.
8027         * python/py-prettyprint.c: Update.
8028         * python/py-progspace.c: Update.
8029         * python/py-record-btrace.c: Update.
8030         * python/py-record.c: Update.
8031         * python/py-symbol.c: Update.
8032         * python/py-type.c: Update.
8033         * python/py-unwind.c: Update.
8034         * python/py-utils.c: Update.
8035         * python/py-value.c: Update.
8036         * python/python.c: Update.
8037         * record-btrace.c: Update.
8038         * record-full.c: Update.
8039         * remote-fileio.c: Update.
8040         * remote.c: Update.
8041         * riscv-tdep.c: Update.
8042         * rs6000-aix-tdep.c: Update.
8043         * rs6000-tdep.c: Update.
8044         * rust-exp.y: Update.
8045         * rust-lang.c: Update.
8046         * s390-tdep.c: Update.
8047         * selftest-arch.c: Update.
8048         * solib-dsbt.c: Update.
8049         * solib-frv.c: Update.
8050         * solib-spu.c: Update.
8051         * solib-svr4.c: Update.
8052         * solib.c: Update.
8053         * sparc64-linux-tdep.c: Update.
8054         * stack.c: Update.
8055         * symfile-mem.c: Update.
8056         * symmisc.c: Update.
8057         * target.c: Update.
8058         * thread.c: Update.
8059         * top.c: Update.
8060         * tracefile-tfile.c: Update.
8061         * tui/tui.c: Update.
8062         * typeprint.c: Update.
8063         * unittests/cli-utils-selftests.c: Update.
8064         * unittests/parse-connection-spec-selftests.c: Update.
8065         * valops.c: Update.
8066         * valprint.c: Update.
8067         * value.c: Update.
8068         * varobj.c: Update.
8069         * windows-nat.c: Update.
8070         * x86-linux-nat.c: Update.
8071         * xml-support.c: Update.
8072
8073 2019-04-08  Tom Tromey  <tom@tromey.com>
8074
8075         * xml-support.c: Use C++ exception handling.
8076         * x86-linux-nat.c: Use C++ exception handling.
8077         * windows-nat.c: Use C++ exception handling.
8078         * varobj.c: Use C++ exception handling.
8079         * value.c: Use C++ exception handling.
8080         * valprint.c: Use C++ exception handling.
8081         * valops.c: Use C++ exception handling.
8082         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8083         handling.
8084         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8085         * typeprint.c: Use C++ exception handling.
8086         * tui/tui.c: Use C++ exception handling.
8087         * tracefile-tfile.c: Use C++ exception handling.
8088         * top.c: Use C++ exception handling.
8089         * thread.c: Use C++ exception handling.
8090         * target.c: Use C++ exception handling.
8091         * symmisc.c: Use C++ exception handling.
8092         * symfile-mem.c: Use C++ exception handling.
8093         * stack.c: Use C++ exception handling.
8094         * sparc64-linux-tdep.c: Use C++ exception handling.
8095         * solib.c: Use C++ exception handling.
8096         * solib-svr4.c: Use C++ exception handling.
8097         * solib-spu.c: Use C++ exception handling.
8098         * solib-frv.c: Use C++ exception handling.
8099         * solib-dsbt.c: Use C++ exception handling.
8100         * selftest-arch.c: Use C++ exception handling.
8101         * s390-tdep.c: Use C++ exception handling.
8102         * rust-lang.c: Use C++ exception handling.
8103         * rust-exp.y: Use C++ exception handling.
8104         * rs6000-tdep.c: Use C++ exception handling.
8105         * rs6000-aix-tdep.c: Use C++ exception handling.
8106         * riscv-tdep.c: Use C++ exception handling.
8107         * remote.c: Use C++ exception handling.
8108         * remote-fileio.c: Use C++ exception handling.
8109         * record-full.c: Use C++ exception handling.
8110         * record-btrace.c: Use C++ exception handling.
8111         * python/python.c: Use C++ exception handling.
8112         * python/py-value.c: Use C++ exception handling.
8113         * python/py-utils.c: Use C++ exception handling.
8114         * python/py-unwind.c: Use C++ exception handling.
8115         * python/py-type.c: Use C++ exception handling.
8116         * python/py-symbol.c: Use C++ exception handling.
8117         * python/py-record.c: Use C++ exception handling.
8118         * python/py-record-btrace.c: Use C++ exception handling.
8119         * python/py-progspace.c: Use C++ exception handling.
8120         * python/py-prettyprint.c: Use C++ exception handling.
8121         * python/py-param.c: Use C++ exception handling.
8122         * python/py-objfile.c: Use C++ exception handling.
8123         * python/py-linetable.c: Use C++ exception handling.
8124         * python/py-lazy-string.c: Use C++ exception handling.
8125         * python/py-infthread.c: Use C++ exception handling.
8126         * python/py-inferior.c: Use C++ exception handling.
8127         * python/py-gdb-readline.c: Use C++ exception handling.
8128         * python/py-framefilter.c: Use C++ exception handling.
8129         * python/py-frame.c: Use C++ exception handling.
8130         * python/py-finishbreakpoint.c: Use C++ exception handling.
8131         * python/py-cmd.c: Use C++ exception handling.
8132         * python/py-breakpoint.c: Use C++ exception handling.
8133         * python/py-arch.c: Use C++ exception handling.
8134         * printcmd.c: Use C++ exception handling.
8135         * ppc-linux-tdep.c: Use C++ exception handling.
8136         * parse.c: Use C++ exception handling.
8137         * p-valprint.c: Use C++ exception handling.
8138         * objc-lang.c: Use C++ exception handling.
8139         * mi/mi-main.c: Use C++ exception handling.
8140         * mi/mi-interp.c: Use C++ exception handling.
8141         * mi/mi-cmd-stack.c: Use C++ exception handling.
8142         * mi/mi-cmd-break.c: Use C++ exception handling.
8143         * main.c: Use C++ exception handling.
8144         * linux-thread-db.c: Use C++ exception handling.
8145         * linux-tdep.c: Use C++ exception handling.
8146         * linux-nat.c: Use C++ exception handling.
8147         * linux-fork.c: Use C++ exception handling.
8148         * linespec.c: Use C++ exception handling.
8149         * language.c: Use C++ exception handling.
8150         * jit.c: Use C++ exception handling.
8151         * infrun.c: Use C++ exception handling.
8152         * infcmd.c: Use C++ exception handling.
8153         * infcall.c: Use C++ exception handling.
8154         * inf-loop.c: Use C++ exception handling.
8155         * i386-tdep.c: Use C++ exception handling.
8156         * i386-linux-tdep.c: Use C++ exception handling.
8157         * guile/scm-value.c: Use C++ exception handling.
8158         * guile/scm-type.c: Use C++ exception handling.
8159         * guile/scm-symtab.c: Use C++ exception handling.
8160         * guile/scm-symbol.c: Use C++ exception handling.
8161         * guile/scm-pretty-print.c: Use C++ exception handling.
8162         * guile/scm-ports.c: Use C++ exception handling.
8163         * guile/scm-param.c: Use C++ exception handling.
8164         * guile/scm-math.c: Use C++ exception handling.
8165         * guile/scm-lazy-string.c: Use C++ exception handling.
8166         * guile/scm-frame.c: Use C++ exception handling.
8167         * guile/scm-disasm.c: Use C++ exception handling.
8168         * guile/scm-cmd.c: Use C++ exception handling.
8169         * guile/scm-breakpoint.c: Use C++ exception handling.
8170         * guile/scm-block.c: Use C++ exception handling.
8171         * guile/guile-internal.h: Use C++ exception handling.
8172         * gnu-v3-abi.c: Use C++ exception handling.
8173         * gdbtypes.c: Use C++ exception handling.
8174         * frame.c: Use C++ exception handling.
8175         * frame-unwind.c: Use C++ exception handling.
8176         * fbsd-tdep.c: Use C++ exception handling.
8177         * f-valprint.c: Use C++ exception handling.
8178         * exec.c: Use C++ exception handling.
8179         * event-top.c: Use C++ exception handling.
8180         * event-loop.c: Use C++ exception handling.
8181         * eval.c: Use C++ exception handling.
8182         * dwarf2read.c: Use C++ exception handling.
8183         * dwarf2loc.c: Use C++ exception handling.
8184         * dwarf2-frame.c: Use C++ exception handling.
8185         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8186         * dwarf-index-write.c: Use C++ exception handling.
8187         * dwarf-index-cache.c: Use C++ exception handling.
8188         * dtrace-probe.c: Use C++ exception handling.
8189         * disasm-selftests.c: Use C++ exception handling.
8190         * darwin-nat.c: Use C++ exception handling.
8191         * cp-valprint.c: Use C++ exception handling.
8192         * cp-support.c: Use C++ exception handling.
8193         * cp-abi.c: Use C++ exception handling.
8194         * corelow.c: Use C++ exception handling.
8195         * completer.c: Use C++ exception handling.
8196         * compile/compile-object-run.c: Use C++ exception handling.
8197         * compile/compile-object-load.c: Use C++ exception handling.
8198         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8199         * compile/compile-c-symbols.c: Use C++ exception handling.
8200         * common/selftest.c: Use C++ exception handling.
8201         * common/new-op.c: Use C++ exception handling.
8202         * cli/cli-script.c: Use C++ exception handling.
8203         * cli/cli-interp.c: Use C++ exception handling.
8204         * cli/cli-cmds.c: Use C++ exception handling.
8205         * c-varobj.c: Use C++ exception handling.
8206         * btrace.c: Use C++ exception handling.
8207         * breakpoint.c: Use C++ exception handling.
8208         * break-catch-throw.c: Use C++ exception handling.
8209         * arch-utils.c: Use C++ exception handling.
8210         * amd64-tdep.c: Use C++ exception handling.
8211         * ada-valprint.c: Use C++ exception handling.
8212         * ada-typeprint.c: Use C++ exception handling.
8213         * ada-lang.c: Use C++ exception handling.
8214         * aarch64-tdep.c: Use C++ exception handling.
8215
8216 2019-04-08  Tom Tromey  <tom@tromey.com>
8217
8218         * xml-support.c (gdb_xml_parser::parse): Update.
8219         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8220         * value.c (show_convenience): Update.
8221         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8222         (test_parse_flags_qcs): Update.
8223         * thread.c (thr_try_catch_cmd): Update.
8224         * target.c (target_translate_tls_address): Update.
8225         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8226         (info_frame_command_core, frame_apply_command_count): Update.
8227         * rust-exp.y (rust_lex_exception_test): Update.
8228         * riscv-tdep.c (riscv_print_one_register_info): Update.
8229         * remote.c (remote_target::enable_btrace): Update.
8230         * record-btrace.c (record_btrace_enable_warn): Update.
8231         * python/py-utils.c (gdbpy_convert_exception): Update.
8232         * printcmd.c (do_one_display, print_variable_and_value): Update.
8233         * mi/mi-main.c (mi_print_exception): Update.
8234         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8235         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8236         * linux-nat.c (linux_nat_target::attach): Update.
8237         * linux-fork.c (class scoped_switch_fork_info): Update.
8238         * infrun.c (displaced_step_prepare): Update.
8239         * infcall.c (call_function_by_hand_dummy): Update.
8240         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8241         * gnu-v3-abi.c (print_one_vtable): Update.
8242         * frame.c (get_prev_frame_always): Update.
8243         * f-valprint.c (info_common_command_for_block): Update.
8244         * exec.c (try_open_exec_file): Update.
8245         * exceptions.c (print_exception, exception_print)
8246         (exception_fprintf, exception_print_same): Update.
8247         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8248         * dwarf-index-cache.c (index_cache::store)
8249         (index_cache::lookup_gdb_index): Update.
8250         * darwin-nat.c (maybe_cache_shell): Update.
8251         * cp-valprint.c (cp_print_value_fields): Update.
8252         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8253         (gcc_cplus_symbol_address): Update.
8254         * compile/compile-c-symbols.c (gcc_convert_symbol)
8255         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8256         * common/selftest.c: Update.
8257         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8258         a std::string.
8259         (exception_try_scope_entry, exception_try_scope_exit): Don't
8260         declare.
8261         (struct exception_try_scope): Remove.
8262         (TRY): Don't use exception_try_scope.
8263         (struct gdb_exception): Add constructor, operator=.
8264         <what>: New method.
8265         (struct gdb_exception_RETURN_MASK_ALL)
8266         (struct gdb_exception_RETURN_MASK_ERROR)
8267         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8268         (struct gdb_quit_bad_alloc): Update.
8269         * common/common-exceptions.c (exception_none): Change
8270         initializer.
8271         (struct catcher) <state, exception>: Initialize inline.
8272         <prev>: Remove member.
8273         (current_catcher): Remove.
8274         (catchers): New global.
8275         (exceptions_state_mc_init): Simplify.
8276         (catcher_pop): Remove.
8277         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8278         (try_scope_depth, exception_try_scope_entry)
8279         (exception_try_scope_exit): Remove.
8280         (throw_exception_sjlj): Update.
8281         (exception_messages, exception_messages_size): Remove.
8282         (throw_it): Simplify.
8283         (gdb_exception_sliced_copy): Remove.
8284         (throw_exception_cxx): Update.
8285         * cli/cli-script.c (script_from_file): Update.
8286         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8287         Update.
8288         * ada-valprint.c (ada_val_print): Update.
8289         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8290         (create_excep_cond_exprs): Update.
8291
8292 2019-04-08  Tom Tromey  <tom@tromey.com>
8293
8294         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8295         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8296         (TRY, CATCH, END_CATCH): Remove some definitions.
8297         * common/common-exceptions.c: Don't use GDB_XCPT.
8298         (catcher_list_size): Remove.
8299         (throw_exception, throw_it): Simplify.
8300
8301 2019-04-05  Tom Tromey  <tom@tromey.com>
8302
8303         Revert the header-sorting patch.
8304         * ft32-tdep.c: Revert.
8305         * frv-tdep.c: Revert.
8306         * frv-linux-tdep.c: Revert.
8307         * frame.c: Revert.
8308         * frame-unwind.c: Revert.
8309         * frame-base.c: Revert.
8310         * fork-child.c: Revert.
8311         * findvar.c: Revert.
8312         * findcmd.c: Revert.
8313         * filesystem.c: Revert.
8314         * filename-seen-cache.h: Revert.
8315         * filename-seen-cache.c: Revert.
8316         * fbsd-tdep.c: Revert.
8317         * fbsd-nat.h: Revert.
8318         * fbsd-nat.c: Revert.
8319         * f-valprint.c: Revert.
8320         * f-typeprint.c: Revert.
8321         * f-lang.c: Revert.
8322         * extension.h: Revert.
8323         * extension.c: Revert.
8324         * extension-priv.h: Revert.
8325         * expprint.c: Revert.
8326         * exec.h: Revert.
8327         * exec.c: Revert.
8328         * exceptions.c: Revert.
8329         * event-top.c: Revert.
8330         * event-loop.c: Revert.
8331         * eval.c: Revert.
8332         * elfread.c: Revert.
8333         * dwarf2read.h: Revert.
8334         * dwarf2read.c: Revert.
8335         * dwarf2loc.c: Revert.
8336         * dwarf2expr.h: Revert.
8337         * dwarf2expr.c: Revert.
8338         * dwarf2-frame.c: Revert.
8339         * dwarf2-frame-tailcall.c: Revert.
8340         * dwarf-index-write.h: Revert.
8341         * dwarf-index-write.c: Revert.
8342         * dwarf-index-common.c: Revert.
8343         * dwarf-index-cache.h: Revert.
8344         * dwarf-index-cache.c: Revert.
8345         * dummy-frame.c: Revert.
8346         * dtrace-probe.c: Revert.
8347         * disasm.h: Revert.
8348         * disasm.c: Revert.
8349         * disasm-selftests.c: Revert.
8350         * dictionary.c: Revert.
8351         * dicos-tdep.c: Revert.
8352         * demangle.c: Revert.
8353         * dcache.h: Revert.
8354         * dcache.c: Revert.
8355         * darwin-nat.h: Revert.
8356         * darwin-nat.c: Revert.
8357         * darwin-nat-info.c: Revert.
8358         * d-valprint.c: Revert.
8359         * d-namespace.c: Revert.
8360         * d-lang.c: Revert.
8361         * ctf.c: Revert.
8362         * csky-tdep.c: Revert.
8363         * csky-linux-tdep.c: Revert.
8364         * cris-tdep.c: Revert.
8365         * cris-linux-tdep.c: Revert.
8366         * cp-valprint.c: Revert.
8367         * cp-support.c: Revert.
8368         * cp-namespace.c: Revert.
8369         * cp-abi.c: Revert.
8370         * corelow.c: Revert.
8371         * corefile.c: Revert.
8372         * continuations.c: Revert.
8373         * completer.h: Revert.
8374         * completer.c: Revert.
8375         * complaints.c: Revert.
8376         * coffread.c: Revert.
8377         * coff-pe-read.c: Revert.
8378         * cli-out.h: Revert.
8379         * cli-out.c: Revert.
8380         * charset.c: Revert.
8381         * c-varobj.c: Revert.
8382         * c-valprint.c: Revert.
8383         * c-typeprint.c: Revert.
8384         * c-lang.c: Revert.
8385         * buildsym.c: Revert.
8386         * buildsym-legacy.c: Revert.
8387         * build-id.h: Revert.
8388         * build-id.c: Revert.
8389         * btrace.c: Revert.
8390         * bsd-uthread.c: Revert.
8391         * breakpoint.h: Revert.
8392         * breakpoint.c: Revert.
8393         * break-catch-throw.c: Revert.
8394         * break-catch-syscall.c: Revert.
8395         * break-catch-sig.c: Revert.
8396         * blockframe.c: Revert.
8397         * block.c: Revert.
8398         * bfin-tdep.c: Revert.
8399         * bfin-linux-tdep.c: Revert.
8400         * bfd-target.c: Revert.
8401         * bcache.c: Revert.
8402         * ax-general.c: Revert.
8403         * ax-gdb.h: Revert.
8404         * ax-gdb.c: Revert.
8405         * avr-tdep.c: Revert.
8406         * auxv.c: Revert.
8407         * auto-load.c: Revert.
8408         * arm-wince-tdep.c: Revert.
8409         * arm-tdep.c: Revert.
8410         * arm-symbian-tdep.c: Revert.
8411         * arm-pikeos-tdep.c: Revert.
8412         * arm-obsd-tdep.c: Revert.
8413         * arm-nbsd-tdep.c: Revert.
8414         * arm-nbsd-nat.c: Revert.
8415         * arm-linux-tdep.c: Revert.
8416         * arm-linux-nat.c: Revert.
8417         * arm-fbsd-tdep.c: Revert.
8418         * arm-fbsd-nat.c: Revert.
8419         * arm-bsd-tdep.c: Revert.
8420         * arch-utils.c: Revert.
8421         * arc-tdep.c: Revert.
8422         * arc-newlib-tdep.c: Revert.
8423         * annotate.h: Revert.
8424         * annotate.c: Revert.
8425         * amd64-windows-tdep.c: Revert.
8426         * amd64-windows-nat.c: Revert.
8427         * amd64-tdep.c: Revert.
8428         * amd64-sol2-tdep.c: Revert.
8429         * amd64-obsd-tdep.c: Revert.
8430         * amd64-obsd-nat.c: Revert.
8431         * amd64-nbsd-tdep.c: Revert.
8432         * amd64-nbsd-nat.c: Revert.
8433         * amd64-nat.c: Revert.
8434         * amd64-linux-tdep.c: Revert.
8435         * amd64-linux-nat.c: Revert.
8436         * amd64-fbsd-tdep.c: Revert.
8437         * amd64-fbsd-nat.c: Revert.
8438         * amd64-dicos-tdep.c: Revert.
8439         * amd64-darwin-tdep.c: Revert.
8440         * amd64-bsd-nat.c: Revert.
8441         * alpha-tdep.c: Revert.
8442         * alpha-obsd-tdep.c: Revert.
8443         * alpha-nbsd-tdep.c: Revert.
8444         * alpha-mdebug-tdep.c: Revert.
8445         * alpha-linux-tdep.c: Revert.
8446         * alpha-linux-nat.c: Revert.
8447         * alpha-bsd-tdep.c: Revert.
8448         * alpha-bsd-nat.c: Revert.
8449         * aix-thread.c: Revert.
8450         * agent.c: Revert.
8451         * addrmap.c: Revert.
8452         * ada-varobj.c: Revert.
8453         * ada-valprint.c: Revert.
8454         * ada-typeprint.c: Revert.
8455         * ada-tasks.c: Revert.
8456         * ada-lang.c: Revert.
8457         * aarch64-tdep.c: Revert.
8458         * aarch64-ravenscar-thread.c: Revert.
8459         * aarch64-newlib-tdep.c: Revert.
8460         * aarch64-linux-tdep.c: Revert.
8461         * aarch64-linux-nat.c: Revert.
8462         * aarch64-fbsd-tdep.c: Revert.
8463         * aarch64-fbsd-nat.c: Revert.
8464         * aarch32-linux-nat.c: Revert.
8465
8466 2019-04-05  Tom Tromey  <tom@tromey.com>
8467
8468         * ft32-tdep.c: Sort headers.
8469         * frv-tdep.c: Sort headers.
8470         * frv-linux-tdep.c: Sort headers.
8471         * frame.c: Sort headers.
8472         * frame-unwind.c: Sort headers.
8473         * frame-base.c: Sort headers.
8474         * fork-child.c: Sort headers.
8475         * findvar.c: Sort headers.
8476         * findcmd.c: Sort headers.
8477         * filesystem.c: Sort headers.
8478         * filename-seen-cache.h: Sort headers.
8479         * filename-seen-cache.c: Sort headers.
8480         * fbsd-tdep.c: Sort headers.
8481         * fbsd-nat.h: Sort headers.
8482         * fbsd-nat.c: Sort headers.
8483         * f-valprint.c: Sort headers.
8484         * f-typeprint.c: Sort headers.
8485         * f-lang.c: Sort headers.
8486         * extension.h: Sort headers.
8487         * extension.c: Sort headers.
8488         * extension-priv.h: Sort headers.
8489         * expprint.c: Sort headers.
8490         * exec.h: Sort headers.
8491         * exec.c: Sort headers.
8492         * exceptions.c: Sort headers.
8493         * event-top.c: Sort headers.
8494         * event-loop.c: Sort headers.
8495         * eval.c: Sort headers.
8496         * elfread.c: Sort headers.
8497         * dwarf2read.h: Sort headers.
8498         * dwarf2read.c: Sort headers.
8499         * dwarf2loc.c: Sort headers.
8500         * dwarf2expr.h: Sort headers.
8501         * dwarf2expr.c: Sort headers.
8502         * dwarf2-frame.c: Sort headers.
8503         * dwarf2-frame-tailcall.c: Sort headers.
8504         * dwarf-index-write.h: Sort headers.
8505         * dwarf-index-write.c: Sort headers.
8506         * dwarf-index-common.c: Sort headers.
8507         * dwarf-index-cache.h: Sort headers.
8508         * dwarf-index-cache.c: Sort headers.
8509         * dummy-frame.c: Sort headers.
8510         * dtrace-probe.c: Sort headers.
8511         * disasm.h: Sort headers.
8512         * disasm.c: Sort headers.
8513         * disasm-selftests.c: Sort headers.
8514         * dictionary.c: Sort headers.
8515         * dicos-tdep.c: Sort headers.
8516         * demangle.c: Sort headers.
8517         * dcache.h: Sort headers.
8518         * dcache.c: Sort headers.
8519         * darwin-nat.h: Sort headers.
8520         * darwin-nat.c: Sort headers.
8521         * darwin-nat-info.c: Sort headers.
8522         * d-valprint.c: Sort headers.
8523         * d-namespace.c: Sort headers.
8524         * d-lang.c: Sort headers.
8525         * ctf.c: Sort headers.
8526         * csky-tdep.c: Sort headers.
8527         * csky-linux-tdep.c: Sort headers.
8528         * cris-tdep.c: Sort headers.
8529         * cris-linux-tdep.c: Sort headers.
8530         * cp-valprint.c: Sort headers.
8531         * cp-support.c: Sort headers.
8532         * cp-namespace.c: Sort headers.
8533         * cp-abi.c: Sort headers.
8534         * corelow.c: Sort headers.
8535         * corefile.c: Sort headers.
8536         * continuations.c: Sort headers.
8537         * completer.h: Sort headers.
8538         * completer.c: Sort headers.
8539         * complaints.c: Sort headers.
8540         * coffread.c: Sort headers.
8541         * coff-pe-read.c: Sort headers.
8542         * cli-out.h: Sort headers.
8543         * cli-out.c: Sort headers.
8544         * charset.c: Sort headers.
8545         * c-varobj.c: Sort headers.
8546         * c-valprint.c: Sort headers.
8547         * c-typeprint.c: Sort headers.
8548         * c-lang.c: Sort headers.
8549         * buildsym.c: Sort headers.
8550         * buildsym-legacy.c: Sort headers.
8551         * build-id.h: Sort headers.
8552         * build-id.c: Sort headers.
8553         * btrace.c: Sort headers.
8554         * bsd-uthread.c: Sort headers.
8555         * breakpoint.h: Sort headers.
8556         * breakpoint.c: Sort headers.
8557         * break-catch-throw.c: Sort headers.
8558         * break-catch-syscall.c: Sort headers.
8559         * break-catch-sig.c: Sort headers.
8560         * blockframe.c: Sort headers.
8561         * block.c: Sort headers.
8562         * bfin-tdep.c: Sort headers.
8563         * bfin-linux-tdep.c: Sort headers.
8564         * bfd-target.c: Sort headers.
8565         * bcache.c: Sort headers.
8566         * ax-general.c: Sort headers.
8567         * ax-gdb.h: Sort headers.
8568         * ax-gdb.c: Sort headers.
8569         * avr-tdep.c: Sort headers.
8570         * auxv.c: Sort headers.
8571         * auto-load.c: Sort headers.
8572         * arm-wince-tdep.c: Sort headers.
8573         * arm-tdep.c: Sort headers.
8574         * arm-symbian-tdep.c: Sort headers.
8575         * arm-pikeos-tdep.c: Sort headers.
8576         * arm-obsd-tdep.c: Sort headers.
8577         * arm-nbsd-tdep.c: Sort headers.
8578         * arm-nbsd-nat.c: Sort headers.
8579         * arm-linux-tdep.c: Sort headers.
8580         * arm-linux-nat.c: Sort headers.
8581         * arm-fbsd-tdep.c: Sort headers.
8582         * arm-fbsd-nat.c: Sort headers.
8583         * arm-bsd-tdep.c: Sort headers.
8584         * arch-utils.c: Sort headers.
8585         * arc-tdep.c: Sort headers.
8586         * arc-newlib-tdep.c: Sort headers.
8587         * annotate.h: Sort headers.
8588         * annotate.c: Sort headers.
8589         * amd64-windows-tdep.c: Sort headers.
8590         * amd64-windows-nat.c: Sort headers.
8591         * amd64-tdep.c: Sort headers.
8592         * amd64-sol2-tdep.c: Sort headers.
8593         * amd64-obsd-tdep.c: Sort headers.
8594         * amd64-obsd-nat.c: Sort headers.
8595         * amd64-nbsd-tdep.c: Sort headers.
8596         * amd64-nbsd-nat.c: Sort headers.
8597         * amd64-nat.c: Sort headers.
8598         * amd64-linux-tdep.c: Sort headers.
8599         * amd64-linux-nat.c: Sort headers.
8600         * amd64-fbsd-tdep.c: Sort headers.
8601         * amd64-fbsd-nat.c: Sort headers.
8602         * amd64-dicos-tdep.c: Sort headers.
8603         * amd64-darwin-tdep.c: Sort headers.
8604         * amd64-bsd-nat.c: Sort headers.
8605         * alpha-tdep.c: Sort headers.
8606         * alpha-obsd-tdep.c: Sort headers.
8607         * alpha-nbsd-tdep.c: Sort headers.
8608         * alpha-mdebug-tdep.c: Sort headers.
8609         * alpha-linux-tdep.c: Sort headers.
8610         * alpha-linux-nat.c: Sort headers.
8611         * alpha-bsd-tdep.c: Sort headers.
8612         * alpha-bsd-nat.c: Sort headers.
8613         * aix-thread.c: Sort headers.
8614         * agent.c: Sort headers.
8615         * addrmap.c: Sort headers.
8616         * ada-varobj.c: Sort headers.
8617         * ada-valprint.c: Sort headers.
8618         * ada-typeprint.c: Sort headers.
8619         * ada-tasks.c: Sort headers.
8620         * ada-lang.c: Sort headers.
8621         * aarch64-tdep.c: Sort headers.
8622         * aarch64-ravenscar-thread.c: Sort headers.
8623         * aarch64-newlib-tdep.c: Sort headers.
8624         * aarch64-linux-tdep.c: Sort headers.
8625         * aarch64-linux-nat.c: Sort headers.
8626         * aarch64-fbsd-tdep.c: Sort headers.
8627         * aarch64-fbsd-nat.c: Sort headers.
8628         * aarch32-linux-nat.c: Sort headers.
8629
8630 2019-04-04  Tom Tromey  <tom@tromey.com>
8631
8632         * varobj.c (varobj_create): Update.
8633         * rust-exp.y (struct rust_parser) <update_innermost_block,
8634         lookup_symbol>: New methods.
8635         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8636         Rename.
8637         (rust_parser::rust_lookup_type)
8638         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8639         * printcmd.c (display_command, do_one_display): Update.
8640         * parser-defs.h (struct parser_state) <parser_state>: Add
8641         "tracker" parameter.
8642         (block_tracker): New member.
8643         (class innermost_block_tracker) <innermost_block_tracker>: Add
8644         "types" parameter.
8645         <reset>: Remove method.
8646         (innermost_block): Don't declare.
8647         (null_post_parser): Update.
8648         * parse.c (innermost_block): Remove global.
8649         (write_dollar_variable): Update.
8650         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8651         Remove "tracker_types" parameter.
8652         (parse_expression): Add "tracker" parameter.
8653         (parse_expression_for_completion): Update.
8654         (null_post_parser): Add "tracker" parameter.
8655         * p-exp.y: Update rules.
8656         * m2-exp.y: Update rules.
8657         * language.h (struct language_defn) <la_post_parser>: Add
8658         "tracker" parameter.
8659         * go-exp.y: Update rules.
8660         * f-exp.y: Update rules.
8661         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8662         parameter.
8663         * d-exp.y: Update rules.
8664         * c-exp.y: Update rules.
8665         * breakpoint.c (set_breakpoint_condition): Create an
8666         innermost_block_tracker.
8667         (watch_command_1): Likewise.
8668         * ada-lang.c (resolve): Add "tracker" parameter.
8669         (resolve_subexp): Likewise.
8670         * ada-exp.y (write_var_from_sym): Update.
8671
8672 2019-04-04  Tom Tromey  <tom@tromey.com>
8673
8674         * type-stack.h: New file.
8675         * type-stack.c: New file.
8676         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8677         type-stack.h.
8678         (insert_into_type_stack, insert_type, push_type, push_type_int)
8679         (insert_type_address_space, pop_type, pop_type_int)
8680         (pop_typelist, pop_type_stack, append_type_stack)
8681         (push_type_stack, get_type_stack, push_typelist)
8682         (follow_type_instance_flags, follow_types): Don't declare.
8683         * parse.c (type_stack): Remove global.
8684         (parse_exp_in_context): Update.
8685         (insert_into_type_stack, insert_type, push_type, push_type_int)
8686         (insert_type_address_space, pop_type, pop_type_int)
8687         (pop_typelist, pop_type_stack, append_type_stack)
8688         (push_type_stack, get_type_stack, push_typelist)
8689         (follow_type_instance_flags, follow_types): Remove (moved to
8690         type-stack.c).
8691         * f-exp.y (type_stack): New global.
8692         Update rules.
8693         (push_kind_type, f_parse): Update.
8694         * d-exp.y (type_stack): New global.
8695         Update rules.
8696         (d_parse): Update.
8697         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8698         Update rules.
8699         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8700         (HFILES_NO_SRCDIR): Add type-stack.h.
8701
8702 2019-04-04  Tom Tromey  <tom@tromey.com>
8703
8704         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8705         (rust_parser::convert_ast_to_expression, rust_parse)
8706         (rust_lex_test_completion, rust_lex_tests): Update.
8707         * parser-defs.h (struct expr_completion_state): New.
8708         (struct parser_state) <parser_state>: Add completion parameter.
8709         <mark_struct_expression, mark_completion_tag>: New methods.
8710         <parse_completion, m_completion_state>: New members.
8711         (prefixify_expression, null_post_parser): Update.
8712         (mark_struct_expression, mark_completion_tag): Don't declare.
8713         * parse.c (parse_completion, expout_last_struct)
8714         (expout_tag_completion_type, expout_completion_name): Remove
8715         globals.
8716         (parser_state::mark_struct_expression)
8717         (parser_state::mark_completion_tag): Now methods.
8718         (prefixify_expression): Add last_struct parameter.
8719         (prefixify_subexp): Likewise.
8720         (parse_exp_1): Update.
8721         (parse_exp_in_context): Add cstate parameter.  Update.
8722         (parse_expression_for_completion): Create an
8723         expr_completion_state.
8724         (null_post_parser): Add "completion" parameter.
8725         * p-exp.y: Update rules.
8726         (yylex): Update.
8727         * language.h (struct language_defn) <la_post_parser>: Add
8728         "completing" parameter.
8729         * go-exp.y: Update rules.
8730         (lex_one_token): Update.
8731         * expression.h (parse_completion): Don't declare.
8732         * d-exp.y: Update rules.
8733         (lex_one_token): Update rules.
8734         * c-exp.y: Update rules.
8735         (lex_one_token): Update.
8736         * ada-lang.c (resolve): Add "parse_completion" parameter.
8737         (resolve_subexp): Likewise.
8738         (ada_resolve_function): Likewise.
8739
8740 2019-04-04  Tom Tromey  <tom@tromey.com>
8741
8742         * parser-defs.h (struct parser_state) <start_arglist,
8743         end_arglist>: New methods.
8744         <arglist_len, m_funcall_chain>: New members.
8745         (arglist_len, start_arglist, end_arglist): Don't declare.
8746         * parse.c (arglist_len, funcall_chain): Remove global.
8747         (start_arglist, end_arglist): Remove functions.
8748         (parse_exp_in_context): Update.
8749         * p-exp.y: Update rules.
8750         * m2-exp.y: Update rules.
8751         * go-exp.y: Update rules.
8752         * f-exp.y: Update rules.
8753         * d-exp.y: Update rules.
8754         * c-exp.y: Update rules.
8755
8756 2019-04-04  Tom Tromey  <tom@tromey.com>
8757
8758         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8759         lex_operator, push_back>: New methods.
8760         Update all rules.
8761         (rust_parser::lex_hex, lex_escape): Rename and update.
8762         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8763         (rust_parser::lex_operator): Rename and update.
8764         (rust_parser::lex_number, rustyylex, rustyyerror)
8765         (rust_lex_test_init, rust_lex_test_sequence)
8766         (rust_lex_test_push_back, rust_lex_tests): Update.
8767         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8768         parameter.
8769         <lexptr, prev_lexptr>: New members.
8770         (lexptr, prev_lexptr): Don't declare.
8771         * parse.c (lexptr, prev_lexptr): Remove globals.
8772         (parse_exp_in_context): Update.
8773         * p-exp.y (yylex, yyerror): Update.
8774         * m2-exp.y (parse_number, yylex, yyerror): Update.
8775         * go-exp.y (lex_one_token, yyerror): Update.
8776         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8777         * d-exp.y (lex_one_token, yyerror): Update.
8778         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8779         (lex_one_token, yyerror): Update.
8780         * ada-lex.l (YY_INPUT): Update.
8781         (rewind_to_char): Update.
8782         * ada-exp.y (yyerror): Update.
8783
8784 2019-04-04  Tom Tromey  <tom@tromey.com>
8785
8786         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8787         * parser-defs.h (struct parser_state) <parser_state>: Add new
8788         parameter.
8789         <comma_terminates>: New member.
8790         (comma_terminates): Don't declare global.
8791         * parse.c (comma_terminates): Remove global.
8792         (parse_exp_in_context): Update.
8793         * p-exp.y (yylex): Update.
8794         * m2-exp.y (yylex): Update.
8795         * go-exp.y (lex_one_token): Update.
8796         * f-exp.y (yylex): Update.
8797         * d-exp.y (lex_one_token): Update.
8798         * c-exp.y (lex_one_token): Update.
8799         * ada-lex.l: Update.
8800
8801 2019-04-04  Tom Tromey  <tom@tromey.com>
8802
8803         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8804         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8805         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8806         * parser-defs.h (paren_depth): Don't declare.
8807         * parse.c (paren_depth): Remove global.
8808         (parse_exp_in_context): Update.
8809         * p-exp.y (paren_depth): New global.
8810         (pascal_parse): Initialize it.
8811         * m2-exp.y (paren_depth): New global.
8812         (m2_parse): Initialize it.
8813         * go-exp.y (paren_depth): New global.
8814         (go_parse): Initialize it.
8815         * f-exp.y (paren_depth): New global.
8816         (f_parse): Initialize it.
8817         * d-exp.y (paren_depth): New global.
8818         (d_parse): Initialize it.
8819         * c-exp.y (paren_depth): New global.
8820         (c_parse): Initialize it.
8821         * ada-lex.l (paren_depth): New global.
8822         (lexer_init): Initialize it.
8823
8824 2019-04-04  Tom Tromey  <tom@tromey.com>
8825
8826         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8827         (rust_parser::convert_ast_to_type)
8828         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8829         * parser-defs.h (struct parser_state) <parser_state>: Add
8830         parameters.  Initialize new members.
8831         <expression_context_block, expression_context_pc>: New members.
8832         * parse.c (expression_context_block, expression_context_pc):
8833         Remove globals.
8834         (parse_exp_in_context): Update.
8835         * p-exp.y: Update all rules.
8836         (yylex): Update.
8837         * m2-exp.y: Update all rules.
8838         (yylex): Update.
8839         * go-exp.y (yylex): Update.
8840         * f-exp.y (yylex): Update.
8841         * d-exp.y: Update all rules.
8842         (yylex): Update.
8843         * c-exp.y: Update all rules.
8844         (lex_one_token, classify_name, yylex, c_parse): Update.
8845         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8846
8847 2019-04-04  Tom Tromey  <tom@tromey.com>
8848
8849         * gdbarch.h, gdbarch.c: Rebuild.
8850         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8851         * stap-probe.h:
8852         (struct stap_parse_info): Replace "parser_state" with
8853         "expr_builder".
8854         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8855         (parser_state): New class.
8856         * parse.c (expr_builder): Rename.
8857         (expr_builder::release): Rename.
8858         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8859         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8860         (write_exp_elt_longcst, write_exp_elt_floatcst)
8861         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8862         (write_exp_string_vector, write_exp_bitstring)
8863         (write_exp_msymbol, mark_struct_expression)
8864         (write_dollar_variable)
8865         (insert_type_address_space, increase_expout_size): Replace
8866         "parser_state" with "expr_builder".
8867         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8868         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8869         "parser_state" with "expr_builder".
8870
8871 2019-04-04  Tom Tromey  <tom@tromey.com>
8872
8873         * rust-exp.y: Replace "parse_language" with method call.
8874         * p-exp.y:
8875         (yylex): Replace "parse_language" with method call.
8876         * m2-exp.y:
8877         (yylex): Replace "parse_language" with method call.
8878         * go-exp.y (classify_name): Replace "parse_language" with method
8879         call.
8880         * f-exp.y (yylex): Replace "parse_language" with method call.
8881         * d-exp.y (lex_one_token): Replace "parse_language" with method
8882         call.
8883         * c-exp.y:
8884         (lex_one_token, classify_name, yylex): Replace "parse_language"
8885         with method call.
8886         * ada-exp.y (find_primitive_type, type_char)
8887         (type_system_address): Replace "parse_language" with method call.
8888
8889 2019-04-04  Tom Tromey  <tom@tromey.com>
8890
8891         * rust-exp.y: Replace "parse_gdbarch" with method call.
8892         * parse.c (write_dollar_variable, insert_type_address_space):
8893         Replace "parse_gdbarch" with method call.
8894         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8895         call.
8896         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8897         call.
8898         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8899         "parse_gdbarch" with method call.
8900         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8901         with method call.
8902         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8903         "parse_gdbarch" with method call.
8904         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8905         "parse_gdbarch" with method call.
8906         * c-exp.y (parse_type, parse_number, classify_name): Replace
8907         "parse_gdbarch" with method call.
8908         * ada-lex.l: Replace "parse_gdbarch" with method call.
8909         * ada-exp.y (parse_type, find_primitive_type, type_char)
8910         (type_system_address): Replace "parse_gdbarch" with method call.
8911
8912 2019-04-04  Tom Tromey  <tom@tromey.com>
8913
8914         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8915         * stap-probe.c (stap_parse_argument): Update.
8916         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8917         initial_size parameter.
8918         * rust-exp.y (rust_lex_tests): Update.
8919         * parse.c (parser_state): Update.
8920         (parse_exp_in_context): Update.
8921         * parser-defs.h (struct parser_state) <parser_state>: Remove
8922         "initial_size" parameter.
8923
8924 2019-04-04  Tom Tromey  <tom@tromey.com>
8925
8926         * parser-defs.h (increase_expout_size): Don't declare.
8927         * parse.c (increase_expout_size): Now static.
8928
8929 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8930
8931         * gnu-nat.c (gnu_nat_target::wait): Fix
8932         target_waitstatus_to_string call.
8933
8934 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8935
8936         * eval.c (evaluate_subexp_standard): Handle internal functions
8937         during Fortran function call handling.
8938
8939 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8940
8941         * NEWS: Mention new internal functions.
8942         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8943         (read_base_type): Use dwarf2_init_complex_target_type.
8944         * value.c (creal_internal_fn): New function.
8945         (cimag_internal_fn): New function.
8946         (_initialize_values): Register new internal functions.
8947
8948 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8949
8950         * infrun.c (stop_all_threads): If debug_infrun, always
8951         trace the wait status after wait_one, using
8952         target_waitstatus_to_string and target_pid_to_str.
8953         (handle_inferior_event): Replace various trace of
8954         wait status kind by a single trace.
8955         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8956         wait status kind image by target_waitstatus_to_string.
8957         * target/waitstatus.c (target_waitstatus_to_string): Fix
8958         obsolete comment.
8959
8960 2019-04-01  Tom Tromey  <tromey@adacore.com>
8961
8962         PR symtab/23331:
8963         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8964
8965 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8966             Pedro Alves  <palves@redhat.com>
8967
8968         * top.c (quit_force): Call 'finalize_values'.
8969         * value.c (finalize_values): New function.
8970         * value.h (finalize_values): Declare.
8971
8972 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8973
8974         * NEWS: Announce $_gdb_major and $_gdb_minor.
8975
8976         * top.c (init_gdb_version_vars): New function.
8977         (gdb_init): Call init_gdb_version_vars.
8978
8979 2019-03-29  Tom Tromey  <tromey@adacore.com>
8980
8981         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8982         help text.  Remove dead code.
8983
8984 2019-03-29  Keith Seitz  <keiths@redhat.com>
8985
8986         From Siddhesh Poyarekar:
8987         * f-lang.h (f77_get_upperbound): Return LONGEST.
8988         (f77_get_lowerbound): Likewise.
8989         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8990         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8991         print them.
8992         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8993         plongest to format print it.
8994         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8995         (f77_get_upperbound): Likewise.
8996         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8997         LOWER_BOUND to LONGEST.
8998         (f77_create_arrayprint_offset_tbl): Likewise.
8999
9000 2019-03-29  Keith Seitz  <keiths@redhat.com>
9001
9002         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9003         %s/pulongest for TYPE_LENGTH instead of %d in format
9004         strings.
9005         * ada-typerint.c (ada_print_type): Likewise.
9006         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9007         * compile/compile-c-support.c (generate_register_struct): Likewise.
9008         * gdbtypes.c (recursive_dump_type): Likewise.
9009         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9010         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9011         instead of %d in format strings.
9012         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9013         to std::min to ULONGEST.
9014         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9015         instead of %d in format strings.
9016         * tracepoint.c (info_scope_command): Likewise.
9017         * typeprint.c (print_offset_data::update)
9018         (print_offset_data::finish): Likewise.
9019         * xtensa-tdep.c (xtensa_store_return_value)
9020         (xtensa_push_dummy_call): Likewise.
9021
9022 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9023
9024         * windows-nat.c (display_selector): Fixed format specifications
9025         for 64-bit Cygwin.
9026
9027 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9028
9029         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9030
9031 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9032
9033         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9034         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9035         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9036         (nios2_linux_init_abi): Install it.
9037
9038 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9039
9040         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9041
9042 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9043
9044         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9045
9046 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9047             Tom Tromey  <tromey@adacore.com>
9048
9049         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9050
9051 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9052
9053         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9054         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9055         method to compute the bounds of range types. Also print "[evaluated]"
9056         if the bounds' values come from a dynamic evaluation.
9057
9058 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9059
9060         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9061         whitespace when pretty printing is on.
9062
9063 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9064
9065         * ppc-linux-nat.c: Add include.
9066
9067 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9068
9069         * NEWS: Mention AArch64 Pointer Authentication.
9070
9071 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9072
9073         * arm-linux-nat.c: Add include.
9074
9075 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9076
9077         * source-cache.c (source_cache::get_source_lines): Re-read
9078         fullname after calling open_source_file.
9079
9080 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9081
9082         * NEWS: Mention TLS support for FreeBSD.
9083
9084 2019-03-25  Tom Tromey  <tromey@adacore.com>
9085
9086         * minsyms.c (BUNCH_SIZE): Update comment.
9087         (~minimal_symbol_reader): Remove old comment.
9088         (compact_minimal_symbols): Update comment.
9089         (minimal_symbol_reader::install): Remove old comment.  Update
9090         other comments.
9091
9092 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9093
9094         * s390-linux-nat.c: Add include.
9095
9096 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9097
9098         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9099         Call linux_get_hwcap.
9100         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9101         Likewise.
9102         (aarch64_linux_get_hwcap): Remove function.
9103         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9104         declaration.
9105         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9106         linux_get_hwcap.
9107         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9108         * linux-tdep.c (linux_get_hwcap): Add function.
9109         (linux_get_hwcap2): Likewise.
9110         * linux-tdep.h (linux_get_hwcap): Add declaration.
9111         (linux_get_hwcap2): Likewise.
9112         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9113         (ppc_linux_get_hwcap2): Likewise.
9114         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9115         linux_get_hwcap.
9116         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9117         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9118         (ppc_linux_nat_target::read_description): Likewise.
9119         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9120         * s390-linux-nat.c: Likewise.
9121         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9122
9123 2019-03-24  Tom Tromey  <tom@tromey.com>
9124
9125         * ada-lang.c (standard_lookup): Simplify initialization.
9126         (ada_lookup_symbol_nonlocal): Simplify return.
9127         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9128         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9129         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9130         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9131         initialization.
9132         * solib.c (solib_global_lookup): Simplify.
9133         * symtab.c (null_block_symbol): Remove.
9134         (symbol_cache_lookup): Simplify returns.
9135         (lookup_language_this): Simplify returns.
9136         (lookup_symbol_aux): Simplify return.
9137         (lookup_local_symbol): Simplify returns.
9138         (lookup_global_symbol_from_objfile): Simplify return.
9139         (lookup_symbol_in_objfile_symtabs)
9140         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9141         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9142         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9143         * cp-namespace.c (cp_lookup_bare_symbol)
9144         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9145         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9146         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9147         (cp_lookup_symbol_via_imports): Simplify initialization.
9148         (find_symbol_in_baseclass): Likewise.
9149         * symtab.h (null_block_symbol): Remove.
9150         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9151         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9152         (d_lookup_symbol_module): Likewise.
9153         (find_symbol_in_baseclass): Simplify initialization.
9154
9155 2019-03-24  Tom Tromey  <tom@tromey.com>
9156
9157         * expression.h: Don't include symtab.h.
9158         (struct block): Forward declare.
9159
9160 2019-03-24  Tom Tromey  <tom@tromey.com>
9161
9162         * c-exp.y (typebase): Remove casts.
9163         * gdbtypes.c (lookup_unsigned_typename, )
9164         (lookup_signed_typename): Remove cast.
9165         * eval.c (parse_to_comma_and_eval): Remove cast.
9166         * parse.c (write_dollar_variable): Remove cast.
9167         * block.h (struct block) <superblock>: Now const.
9168         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9169         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9170         (map_block): Make "block" const.
9171         * symfile.h (struct quick_symbol_functions)
9172         <map_matching_symbols>: Constify block argument to "callback".
9173         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9174         const.
9175         (find_pc_sect_compunit_symtab): Make "b" const.
9176         (find_symbol_at_address): Likewise.
9177         (search_symbols): Likewise.
9178         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9179         (dw2_debug_names_lookup_symbol): Likewise.
9180         (dw2_map_matching_symbols): Update.
9181         * p-valprint.c (pascal_val_print): Remove "block".
9182         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9183         (aux_add_nonlocal_symbols): Make "block" const.
9184         (resolve_subexp): Remove cast.
9185         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9186         const.
9187         (iterate_over_file_blocks): Likewise.
9188         * f-exp.y (%union) <bval>: Remove.
9189         * coffread.c (patch_opaque_types): Make "b" const.
9190         * spu-tdep.c (spu_catch_start): Make "block" const.
9191         * c-valprint.c (print_unpacked_pointer): Remove "block".
9192         * symmisc.c (dump_symtab_1): Make "b" const.
9193         (block_depth): Make "block" const.
9194         * d-exp.y (%union) <bval>: Remove.
9195         * cp-support.h (cp_lookup_rtti_type): Update.
9196         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9197         * psymtab.c (psym_lookup_symbol): Make "block" const.
9198         (maintenance_check_psymtabs): Make "b" const.
9199         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9200         (enumerate_locals, enumerate_args): Update.
9201         * python/py-symtab.c (stpy_global_block): Make "block" const.
9202         (stpy_static_block): Likewise.
9203         * inline-frame.c (block_starting_point_at): Make "new_block"
9204         const.
9205         * block.c (find_block_in_blockvector): Make return type const.
9206         (blockvector_for_pc_sect): Make "b" const.
9207         (find_block_in_blockvector): Make "b" const.
9208
9209 2019-03-23  Tom Tromey  <tom@tromey.com>
9210
9211         * varobj.c (varobj_create): Update.
9212         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9213         * printcmd.c (display_command, do_one_display): Don't reset
9214         innermost_block.
9215         * parser-defs.h (enum innermost_block_tracker_type): Move to
9216         expression.h.
9217         (innermost_block): Update comment.
9218         * parse.c (parse_exp_1): Add tracker_types parameter.
9219         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9220         tracker_types parameter.  Reset innermost_block.
9221         (parse_exp_in_context): Remove.
9222         (parse_expression_for_completion): Update.
9223         * objfiles.c (~objfile): Don't reset expression_context_block or
9224         innermost_block.
9225         * expression.h (enum innermost_block_tracker_type): Move from
9226         parser-defs.h.
9227         (parse_exp_1): Add tracker_types parameter.
9228         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9229         reset innermost_block.
9230
9231 2019-03-23  Tom Tromey  <tom@tromey.com>
9232
9233         * objfiles.h: Include bcache.h.
9234
9235 2019-03-23  Tom Tromey  <tom@tromey.com>
9236
9237         * linespec.c (get_current_search_block): Use
9238         scoped_restore_current_language.
9239         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9240
9241 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9242             Jiong Wang  <jiong.wang@arm.com>
9243
9244         * aarch64-linux-tdep.c
9245         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9246         section.
9247         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9248
9249 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9250             Jiong Wang  <jiong.wang@arm.com>
9251
9252         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9253         instructions.
9254         (aarch64_analyze_prologue_test): Add PACIASP test.
9255         (aarch64_prologue_prev_register): Unmask PC value.
9256
9257 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9258             Jiong Wang  <jiong.wang@arm.com>
9259
9260         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9261         (aarch64_dwarf2_prev_register): Unmask PC value.
9262         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9263         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9264         DW_CFA_AARCH64_negate_ra_state.
9265         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9266
9267 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9268             Jiong Wang  <jiong.wang@arm.com>
9269
9270         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9271         registers.
9272         (aarch64_pseudo_register_name): Likewise.
9273         (aarch64_pseudo_register_type): Likewise.
9274         (aarch64_pseudo_register_reggroup_p): Likewise.
9275         (aarch64_gdbarch_init): Add pauth registers.
9276         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9277         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9278         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9279         (struct gdbarch_tdep): Add regnum for ra_state.
9280
9281 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9282             Jiong Wang  <jiong.wang@arm.com>
9283
9284         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9285
9286 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9287             Jiong Wang  <jiong.wang@arm.com>
9288
9289         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9290         function.
9291         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9292         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9293         (aarch64_gdbarch_init): Add puth registers.
9294         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9295         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9296         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9297
9298 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9299             Jiong Wang  <jiong.wang@arm.com>
9300
9301         * aarch64-linux-nat.c
9302         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9303         * aarch64-linux-tdep.c
9304         (aarch64_linux_core_read_description): Likewise.
9305         (aarch64_linux_get_hwcap): New function.
9306         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9307         (aarch64_linux_get_hwcap): New declaration.
9308
9309 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9310             Jiong Wang  <jiong.wang@arm.com>
9311
9312         * aarch64-linux-nat.c
9313         (aarch64_linux_nat_target::read_description): Add pauth param.
9314         * aarch64-linux-tdep.c
9315         (aarch64_linux_core_read_description): Likewise.
9316         * aarch64-tdep.c (struct target_desc): Add in pauth.
9317         (aarch64_read_description): Add pauth param.
9318         (aarch64_gdbarch_init): Likewise.
9319         * aarch64-tdep.h (aarch64_read_description): Likewise.
9320         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9321         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9322         * features/Makefile: Add new files.
9323         * features/aarch64-pauth.c: New file.
9324         * features/aarch64-pauth.xml: New file.
9325
9326 2019-03-20  Tom Tromey  <tromey@adacore.com>
9327
9328         * infrun.c (handle_inferior_event): Rename from
9329         handle_inferior_event_1.  Create a scoped_value_mark.
9330         (handle_inferior_event): Remove.
9331
9332 2019-03-19  Tom Tromey  <tromey@adacore.com>
9333
9334         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9335         * infrun.h (print_stop_event): Add "displays" parameter.
9336         * infrun.c (print_stop_event): Add "displays" parameter.
9337
9338 2019-03-19  Pedro Alves  <palves@redhat.com>
9339
9340         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9341         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9342         to -1.  Fix TABs vs spaces.
9343         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9344         * tui/tui-out.h (tui_ui_out) Add intro comments.
9345         <m_line, m_start_of_line>: In-class initialize, and add describing
9346         comment.
9347
9348 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9349
9350         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9351         variable names.
9352         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9353
9354 2019-03-18  Pedro Alves  <palves@redhat.com>
9355             Eli Zaretskii <eliz@gnu.org>
9356
9357         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9358         m_line and m_start_of_line.
9359
9360 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9361
9362         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9363         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9364         it returns a newline.  This fixes a regression in TU mode, whereby
9365         the next line is output on the same screen line as the user input.
9366
9367 2019-03-18  Tom Tromey  <tromey@adacore.com>
9368
9369         * minsyms.c (minimal_symbol_reader::install): Remove call to
9370         obstack_blank.
9371
9372 2019-03-18  Pedro Alves  <palves@redhat.com>
9373
9374         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9375         New globals.
9376         (apply_style): New, factored out from ...
9377         (apply_ansi_escape): ... this.  Handle reverse video mode.
9378         (tui_set_reverse_mode): New function.
9379         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9380         * tui/tui-winsource.c (tui_show_source_line): Use
9381         tui_set_reverse_mode instead of setting A_STANDOUT.
9382         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9383         New setter methods.
9384
9385 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9386
9387         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9388         Handle tabs.
9389
9390 2019-03-18  Tom Tromey  <tromey@adacore.com>
9391
9392         * ada-lang.c (empty_array): Add "high" parameter.
9393         (ada_evaluate_subexp): Update.
9394
9395 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9396
9397         * unittests/string_view-selftests.c: Define
9398         _initialize_string_view_selftests unconditionally.
9399
9400 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9401
9402         PR gdb/24350
9403         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9404
9405 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9406
9407         PR gdb/24351
9408         * windows-nat.c (display_selector): Fix format specifiers.
9409
9410 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9411
9412         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9413         tui_refill_source_window instead of tui_refresh_win, to update the
9414         current execution line.  This fixes redisplay of the current line
9415         when stepping through the code with "next" or "step".
9416
9417 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9418
9419         * source-cache.c (source_cache::get_source_lines): Call
9420         find_source_lines to initialize s->nlines.  This fixes vertical
9421         scrolling of TUI source window when the DOWN arrow is pressed.
9422
9423 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9424
9425         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9426         linux-thread-db.c (_initialize_thread_db): Likewise.
9427
9428 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9429
9430         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9431         wclrtoeol in tui_show_source_line".  This reverts changes made in
9432         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9433
9434 2019-03-15  Tom Tromey  <tom@tromey.com>
9435
9436         * symtab.h (struct minimal_symbol): Derive from
9437         general_symbol_info.
9438         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9439         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9440         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9441         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9442         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9443         (MSYMBOL_SEARCH_NAME): Update.
9444         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9445         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9446         * minsyms.c (minimal_symbol_reader::record_full): Update.
9447
9448 2019-03-15  Tom Tromey  <tom@tromey.com>
9449
9450         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9451
9452 2019-03-15  Tom Tromey  <tom@tromey.com>
9453
9454         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9455         unique_xmalloc_ptr.
9456         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9457         Update.
9458         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9459         (build_minimal_symbol_hash_tables)
9460         (minimal_symbol_reader::install): Update.
9461
9462 2019-03-15  Tom Tromey  <tom@tromey.com>
9463
9464         * symtab.c (create_demangled_names_hash): Update.
9465         (symbol_set_names): Update.
9466         * objfiles.h (struct objfile_per_bfd_storage)
9467         <demangled_names_hash>: Now an htab_up.
9468         * objfiles.c (objfile_per_bfd_storage): Simplify.
9469
9470 2019-03-15  Tom Tromey  <tom@tromey.com>
9471
9472         * objfiles.h (struct objfile_per_bfd_storage): Declare
9473         destructor.
9474         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9475         New.
9476         (get_objfile_bfd_data): Use new.  Don't initialize
9477         language_of_main.
9478         (free_objfile_per_bfd_storage): Remove.
9479         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9480
9481 2019-03-15  Tom Tromey  <tom@tromey.com>
9482
9483         * symfile.c (reread_symbols): Update.
9484         * objfiles.c (objfile::objfile): Update.
9485         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9486         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9487         comment.
9488         (minimal_symbol_reader::install): Update.
9489         (terminate_minimal_symbol_table): Remove.
9490         * jit.c (jit_object_close_impl): Update.
9491
9492 2019-03-15  Tom Tromey  <tom@tromey.com>
9493
9494         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9495         initializations.
9496
9497 2019-03-15  Tom Tromey  <tom@tromey.com>
9498
9499         * objfiles.h (struct objfile_per_bfd_storage)
9500         <demangled_hash_languages>: Now a bitset.
9501         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9502         (lookup_minimal_symbol): Update.
9503
9504 2019-03-15  Tom Tromey  <tom@tromey.com>
9505
9506         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9507         Don't return the symbol.
9508         * coffread.c (record_minimal_symbol): Use record_full.
9509
9510 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9511
9512         The MS-Windows port of ncurses fails to switch to a color pair if
9513         one or both of the colors are the implicit default colors.  This
9514         change records the default colors when TUI is initialized, and
9515         then specifies them explicitly when a color pair uses the default
9516         colors.  This allows color styling in TUI mode on MS-Windows.
9517
9518         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9519         ncurses_norm_attr.
9520         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9521         colors in ncurses_norm_attr.
9522         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9523         "none", replace it with the default color recorded in
9524         ncurses_norm_attr.
9525
9526 2019-03-14  Tom Tromey  <tromey@adacore.com>
9527
9528         * source-cache.h (class source_cache) <get_source_lines>: Return
9529         std::string.
9530         * source-cache.c (source_cache::extract_lines): Handle case where
9531         first_pos==npos.  Return std::string.
9532         (source_cache::get_source_lines): Update.
9533
9534 2019-03-14  Tom Tromey  <tromey@adacore.com>
9535
9536         * NEWS: Add item for "style sources" commands.
9537         * source-cache.c (source_cache::get_source_lines): Check
9538         source_styling.
9539         * cli/cli-style.c (source_styling): New global.
9540         (_initialize_cli_style): Add "style sources" commands.
9541         (show_style_sources): New function.
9542         * cli/cli-style.h (source_styling): Declare.
9543
9544 2019-03-14  Pedro Alves  <palves@redhat.com>
9545             Tom Tromey  <tromey@adacore.com>
9546
9547         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9548         * tui/tui-winsource.c (tui_refill_source_window): New function,
9549         from...
9550         (tui_horizontal_source_scroll): ... here.  Move some logic.
9551         * cli/cli-style.c (set_style_enabled): Notify new observable.
9552         * tui/tui-hooks.c (tui_redisplay_source): New function.
9553         (tui_attach_detach_observers): Attach or detach
9554         tui_redisplay_source.
9555         * observable.h (source_styling_changed): New observable.
9556         * observable.c: Define source_styling_changed observable.
9557
9558 2019-03-13  Tom Tromey  <tromey@adacore.com>
9559
9560         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9561         (i386_gnu_nat_target::store_registers): Update.
9562         * target-debug.h (target_debug_print_std_string): New macro.
9563         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9564         * windows-tdep.c (display_one_tib): Update.
9565         * tui/tui-stack.c (tui_make_status_line): Update.
9566         * top.c (print_inferior_quit_action): Update.
9567         * thread.c (thr_try_catch_cmd): Update.
9568         (add_thread_with_info): Update.
9569         (thread_target_id_str): Update.
9570         (thr_try_catch_cmd): Update.
9571         (thread_command): Update.
9572         (thread_find_command): Update.
9573         * record-btrace.c (record_btrace_target::info_record)
9574         (record_btrace_resume_thread, record_btrace_target::resume)
9575         (record_btrace_cancel_resume, record_btrace_step_thread)
9576         (record_btrace_target::wait, record_btrace_target::wait)
9577         (record_btrace_target::wait, record_btrace_target::stop): Update.
9578         * progspace.c (print_program_space): Update.
9579         * process-stratum-target.c
9580         (process_stratum_target::thread_address_space): Update.
9581         * linux-fork.c (linux_fork_mourn_inferior)
9582         (detach_checkpoint_command, info_checkpoints_command)
9583         (linux_fork_context): Update.
9584         (linux_fork_detach): Update.
9585         (class scoped_switch_fork_info): Update.
9586         (delete_checkpoint_command): Update.
9587         * infrun.c (follow_fork_inferior): Update.
9588         (follow_fork_inferior): Update.
9589         (proceed_after_vfork_done): Update.
9590         (handle_vfork_child_exec_or_exit): Update.
9591         (follow_exec): Update.
9592         (displaced_step_prepare_throw): Update.
9593         (displaced_step_restore): Update.
9594         (start_step_over): Update.
9595         (resume_1): Update.
9596         (clear_proceed_status_thread): Update.
9597         (proceed): Update.
9598         (print_target_wait_results): Update.
9599         (do_target_wait): Update.
9600         (context_switch): Update.
9601         (stop_all_threads): Update.
9602         (restart_threads): Update.
9603         (finish_step_over): Update.
9604         (handle_signal_stop): Update.
9605         (switch_back_to_stepped_thread): Update.
9606         (keep_going_pass_signal): Update.
9607         (print_exited_reason): Update.
9608         (normal_stop): Update.
9609         * inferior.c (inferior_pid_to_str): Change return type.
9610         (print_selected_inferior): Update.
9611         (add_inferior): Update.
9612         (detach_inferior): Update.
9613         * dummy-frame.c (fprint_dummy_frames): Update.
9614         * dcache.c (dcache_info_1): Update.
9615         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9616         (btrace_fetch, btrace_clear): Update.
9617         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9618         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9619         type.
9620         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9621         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9622         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9623         * gdbarch.c, gdbarch.h: Rebuild.
9624         * gdbarch.sh (core_pid_to_str): Change return type.
9625         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9626         return type.
9627         (windows_nat_target::pid_to_str): Change return type.
9628         (windows_delete_thread): Update.
9629         (windows_nat_target::attach): Update.
9630         (windows_nat_target::files_info): Update.
9631         * target-delegates.c: Rebuild.
9632         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9633         return type.
9634         (sol_thread_target::pid_to_str): Change return type.
9635         * remote.c (class remote_target) <pid_to_str>: Change return
9636         type.
9637         (remote_target::pid_to_str): Change return type.
9638         (extended_remote_target::attach, remote_target::remote_stop_ns)
9639         (remote_target::remote_notif_remove_queued_reply)
9640         (remote_target::push_stop_reply, remote_target::disable_btrace):
9641         Update.
9642         (extended_remote_target::attach): Update.
9643         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9644         type.
9645         (gdbsim_target::pid_to_str): Change return type.
9646         * ravenscar-thread.c (struct ravenscar_thread_target)
9647         <pid_to_str>: Change return type.
9648         (ravenscar_thread_target::pid_to_str): Change return type.
9649         * procfs.c (class procfs_target) <pid_to_str>: Change return
9650         type.
9651         (procfs_target::pid_to_str): Change return type.
9652         (procfs_target::attach): Update.
9653         (procfs_target::detach): Update.
9654         (procfs_target::fetch_registers): Update.
9655         (procfs_target::store_registers): Update.
9656         (procfs_target::wait): Update.
9657         (procfs_target::files_info): Update.
9658         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9659         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9660         return type.
9661         (nto_procfs_target::pid_to_str): Change return type.
9662         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9663         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9664         return type.
9665         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9666         (exit_lwp): Update.
9667         (attach_proc_task_lwp_callback, get_detach_signal)
9668         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9669         (linux_nat_target::resume, wait_lwp, stop_callback)
9670         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9671         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9672         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9673         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9674         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9675         type.
9676         (inf_ptrace_target::attach): Update.
9677         (inf_ptrace_target::files_info): Update.
9678         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9679         type.
9680         (go32_nat_target::pid_to_str): Change return type.
9681         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9682         (gnu_nat_target::wait): Update.
9683         (gnu_nat_target::wait): Update.
9684         (gnu_nat_target::resume): Update.
9685         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9686         (fbsd_nat_target::wait): Update.
9687         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9688         type.
9689         (darwin_nat_target::attach): Update.
9690         * corelow.c (class core_target) <pid_to_str>: Change return type.
9691         (core_target::pid_to_str): Change return type.
9692         * target.c (normal_pid_to_str): Change return type.
9693         (default_pid_to_str): Likewise.
9694         (target_pid_to_str): Change return type.
9695         (target_translate_tls_address): Update.
9696         (target_announce_detach): Update.
9697         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9698         return type.
9699         (bsd_uthread_target::pid_to_str): Change return type.
9700         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9701         type.
9702         (bsd_kvm_target::pid_to_str): Change return type.
9703         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9704         return type.
9705         (aix_thread_target::pid_to_str): Change return type.
9706         * target.h (struct target_ops) <pid_to_str>: Change return type.
9707         (target_pid_to_str, normal_pid_to_str): Likewise.
9708         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9709         type.
9710         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9711         type.
9712         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9713         return type.
9714         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9715         type.
9716         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9717         type.
9718         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9719         return type.
9720
9721 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9722
9723         * NEWS: Mention that the new default MI version is 3.  Mention
9724         changes to the output of commands and events that deal with
9725         multi-location breakpoints.
9726         * breakpoint.c: Include "mi/mi-out.h".
9727         (print_one_breakpoint): Change output syntax if using MI version
9728         >= 3.
9729         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9730         New.
9731         (mi_multi_location_breakpoint_output_fixed): New.
9732         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9733         (mi_cmd_fix_multi_location_breakpoint_output): New.
9734         (mi_multi_location_breakpoint_output_fixed): New.
9735         * mi/mi-cmds.c (mi_cmds): Register command
9736         -fix-multi-location-breakpoint-output.
9737         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9738         interpreter "mi".
9739
9740 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9741
9742         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9743         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9744         instantiate mi_ui_out based on interpreter name.
9745         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9746         * mi/mi-main.c (mi_load_progress): Likewise.
9747
9748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9749
9750         * NEWS: Combine separate "New targets" sections for 8.3.
9751
9752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9753
9754         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9755         (ppcfbsd_init_abi): Install gdbarch
9756         "fetch_tls_load_module_address" and "get_thread_local_address"
9757         methods.
9758
9759 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9760
9761         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9762         (riscv_fbsd_init_abi): Install gdbarch
9763         "fetch_tls_load_module_address" and "get_thread_local_address"
9764         methods.
9765
9766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9767
9768         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9769         (i386fbsd_init_abi): Install gdbarch
9770         "fetch_tls_load_module_address" and "get_thread_local_address"
9771         methods.
9772
9773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9774
9775         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9776         (amd64fbsd_init_abi): Install gdbarch
9777         "fetch_tls_load_module_address" and "get_thread_local_address"
9778         methods.
9779
9780 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9781
9782         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9783         (struct fbsd_pspace_data): New type.
9784         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9785         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9786         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9787         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9788         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9789
9790 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9791
9792         * gdbtypes.c (lookup_struct_elt): New function.
9793         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9794         * gdbtypes.h (struct struct_elt): New type.
9795         (lookup_struct_elt): New prototype.
9796
9797 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9798
9799         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9800         remove disabled code block.
9801
9802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9803
9804         * gdbarch.sh (get_thread_local_address): New method.
9805         * gdbarch.h, gdbarch.c: Regenerate.
9806         * target.c (target_translate_tls_address): Use
9807         gdbarch_get_thread_local_address if present instead of
9808         target::get_thread_local_address.
9809
9810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9811
9812         * target.h (target::get_thread_local_address): Update comment.
9813
9814 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9815
9816         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9817         objfile->separate_debug_objfile_backlink if not NULL.
9818
9819 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9820
9821         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9822         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9823         (amd64bsd_store_inferior_registers): Likewise.
9824         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9825         Enable segment base registers.
9826         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9827         PT_GETFSBASE and PT_GETGSBASE.
9828         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9829         PT_SETGSBASE.
9830         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9831         segment base registers.
9832         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9833
9834 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9835
9836         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9837         Update calls to i386_target_description to add 'segments'
9838         parameter.
9839         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9840         add segment base registers.
9841         * arch/i386.c (i386_create_target_description): Add 'segments'
9842         parameter to enable segment base registers.
9843         * arch/i386.h (i386_create_target_description): Likewise.
9844         * features/i386/32bit-segments.xml: New file.
9845         * features/i386/32bit-segments.c: Generate.
9846         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9847         call to i386_target_description to add 'segments' parameter.
9848         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9849         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9850         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9851         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9852         if feature is present.
9853         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9854         Add 'segments' parameter to call to i386_target_description.
9855         (i386_target_description): Add 'segments' parameter to enable
9856         segment base registers.
9857         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9858         to call to i386_target_description.
9859         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9860         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9861         Define I386_NUM_REGS.
9862         (i386_target_description): Add 'segments' parameter to enable
9863         segment base registers.
9864
9865 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9866
9867         PR/24325
9868         * source-cache.c: #undef open and close, to avoid unresolved
9869         externals during linking.
9870
9871 2019-03-12  Tom Tromey  <tromey@adacore.com>
9872
9873         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9874         const.  Add initializers.
9875         (_initialize_remote): Don't initialize ptid globals.
9876
9877 2019-03-12  Pedro Alves  <palves@redhat.com>
9878
9879         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9880
9881 2019-03-12  Pedro Alves  <palves@redhat.com>
9882
9883         * cp-name-parser.y (main): Remove unused 'len' variable.
9884
9885 2019-03-12  Tom Tromey  <tromey@adacore.com>
9886
9887         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9888         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9889
9890 2019-03-12  Tom Tromey  <tromey@adacore.com>
9891
9892         * linux-nat.c (iterate_over_lwps): Update.
9893         (stop_callback): Remove parameter.
9894         (stop_wait_callback, detach_callback, resume_set_callback)
9895         (select_singlestep_lwp_callback, set_ignore_sigint)
9896         (status_callback, resumed_callback, resume_clear_callback)
9897         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9898         data parameter.
9899         (linux_nat_target::detach, linux_nat_target::resume)
9900         (linux_stop_and_wait_all_lwps, select_event_lwp)
9901         (linux_nat_filter_event, linux_nat_wait_1)
9902         (linux_nat_target::kill, linux_nat_target::stop)
9903         (linux_nat_target::stop): Update.
9904         (linux_nat_resume_callback): Change type.
9905         (resume_stopped_resumed_lwps, count_events_callback)
9906         (select_event_lwp_callback): Likewise.
9907         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9908         * arm-linux-nat.c (struct update_registers_data): Remove.
9909         (update_registers_callback): Change type.
9910         (arm_linux_insert_hw_breakpoint1): Update.
9911         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9912         parameter.
9913         (x86_linux_dr_set_addr): Update.
9914         (x86_linux_dr_set_control): Update.
9915         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9916         (iterate_over_lwps): Use gdb::function_view.
9917         * nat/aarch64-linux-hw-point.c (struct
9918         aarch64_dr_update_callback_param): Remove.
9919         (debug_reg_change_callback): Change type.
9920         (aarch64_notify_debug_reg_change): Update.
9921         * s390-linux-nat.c (s390_refresh_per_info): Update.
9922
9923 2019-03-11  Tom Tromey  <tromey@adacore.com>
9924
9925         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9926         redundant assignment to "this_cu".
9927
9928 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9929
9930         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9931
9932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9933
9934         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9935         from...
9936         (rank_one_type): ... this.
9937
9938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9939
9940         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9941         from...
9942         (rank_one_type): ... this.
9943
9944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9945
9946         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9947         from...
9948         (rank_one_type): ... this.
9949
9950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9951
9952         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9953         from...
9954         (rank_one_type): ... this.
9955
9956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9957
9958         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9959         from...
9960         (rank_one_type): ... this.
9961
9962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9963
9964         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9965         from...
9966         (rank_one_type): ... this.
9967
9968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9969
9970         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9971         from...
9972         (rank_one_type): ... this.
9973
9974 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9975
9976         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9977         from...
9978         (rank_one_type): ... this.
9979
9980 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9981
9982         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9983         from...
9984         (rank_one_type): ... this.
9985
9986 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9987
9988         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9989         from...
9990         (rank_one_type): ... this.
9991
9992 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9993
9994         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9995         from...
9996         (rank_one_type): ... this.
9997
9998 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9999
10000         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10001         from...
10002         (rank_one_type): ... this.
10003
10004 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10005
10006         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10007         inferior-events' shows the example events.
10008
10009 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10010
10011         Support styling on native MS-Windows console
10012
10013         PR/24315
10014         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10015         on MS-Windows if $TERM is not defined.
10016
10017         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10018
10019         * posix-hdep.c (gdb_console_fputs):
10020         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10021         functions.
10022         * ui-file.h (gdb_console_fputs): Add prototype.
10023
10024         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10025         back to fputs only if the former returns zero.
10026
10027 2019-03-07  Tom Tromey  <tom@tromey.com>
10028
10029         * symmisc.c (print_symbol_bcache_statistics): Update.
10030         (print_objfile_statistics): Update.
10031         * symfile.c (allocate_symtab): Update.
10032         * stabsread.c: Don't include bcache.h.
10033         * psymtab.h (struct psymbol_bcache): Don't declare.
10034         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10035         (psymbol_bcache_init, psymbol_bcache_free)
10036         (psymbol_bcache_get_bcache): Don't declare.
10037         * psymtab.c (struct psymbol_bcache): Remove.
10038         (psymtab_storage::psymtab_storage): Update.
10039         (psymtab_storage::~psymtab_storage): Update.
10040         (psymbol_bcache_init, psymbol_bcache_free)
10041         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10042         (add_psymbol_to_bcache): Update.
10043         (allocate_psymtab): Update.
10044         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10045         macro_cache>: No longer pointers.
10046         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10047         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10048         * macrotab.c (macro_bcache): Update.
10049         * macroexp.c: Don't include bcache.h.
10050         * gdbtypes.c (check_types_worklist): Update.
10051         (types_deeply_equal): Remove TRY/CATCH.  Update.
10052         * elfread.c (elf_symtab_read): Update.
10053         * dwarf2read.c: Don't include bcache.h.
10054         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10055         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10056         (print_bcache_statistics, bcache_memory_used): Don't declare.
10057         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10058         methods.  Rename all data members.
10059         * bcache.c (struct bcache): Move to bcache.h.
10060         (bcache::expand_hash_table): Rename from expand_hash_table.
10061         (bcache): Remove.
10062         (bcache::insert): Rename from bcache_full.
10063         (bcache::compare): Rename from bcache_compare.
10064         (bcache_xmalloc): Remove.
10065         (bcache::~bcache): Rename from bcache_xfree.
10066         (bcache::print_statistics): Rename from print_bcache_statistics.
10067         (bcache::memory_used): Rename from bcache_memory_used.
10068
10069 2019-03-07  Pedro Alves  <palves@redhat.com>
10070
10071         * infrun.c (normal_stop): Also check for
10072         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10073
10074 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10075
10076         * f-lang.c (value_from_host_double): Moved to...
10077         * value.c (value_from_host_double): ...here.
10078         * value.h (value_from_host_double): Declare.
10079         * guile/scm-math.c (vlscm_convert_typed_number): Use
10080         value_from_host_double.
10081         (vlscm_convert_number): Likewise.
10082         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10083         * python/py-value.c (convert_value_from_python): Likewise.
10084
10085 2019-03-06  Tom Tromey  <tom@tromey.com>
10086
10087         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10088
10089 2019-03-06  Tom Tromey  <tom@tromey.com>
10090
10091         * utils.h (free_current_contents): Don't declare.
10092         * utils.c (free_current_contents): Remove.
10093
10094 2019-03-06  Tom Tromey  <tom@tromey.com>
10095
10096         * top.c (quit_force): Update.
10097         * main.c (captured_command_loop): Update.
10098         * common/new-op.c (operator new): Update.
10099         * common/common-exceptions.c (struct catcher)
10100         <save_cleanup_chain>: Remove member.
10101         (exceptions_state_mc_init): Update.
10102         (exception_try_scope_entry): Return nullptr.
10103         (exception_try_scope_exit, exception_rethrow)
10104         (throw_exception_sjlj, throw_exception_cxx): Update.
10105         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10106         (all_cleanups, do_cleanups, discard_cleanups)
10107         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10108         (restore_cleanups, restore_final_cleanups): Don't declare.
10109         (do_final_cleanups): Remove parameter.
10110         * common/cleanups.c (cleanup_chain, make_cleanup)
10111         (make_cleanup_dtor, all_cleanups, do_cleanups)
10112         (discard_my_cleanups, discard_cleanups)
10113         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10114         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10115         (null_cleanup): Remove.
10116         (do_final_cleanups): Remove parameter.
10117
10118 2019-03-06  Tom Tromey  <tom@tromey.com>
10119
10120         * remote.c (remote_target::remote_parse_stop_reply): Use
10121         unique_xmalloc_ptr.
10122
10123 2019-03-06  Tom Tromey  <tom@tromey.com>
10124
10125         * stabsread.c (struct stabs_field_info): Rename from field_info.
10126         <list, fnlist>: Add initializers.
10127         <obstack>: New member.
10128         (read_member_functions, read_struct_fields, read_baseclasses):
10129         Allocate on obstack.  Don't use cleanups.
10130         (read_one_struct_field, read_member_functions, read_struct_fields)
10131         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10132         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10133         (read_struct_type): Update.
10134
10135 2019-03-06  Tom Tromey  <tom@tromey.com>
10136
10137         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10138         * common/filestuff.h (make_cleanup_close): Don't declare.
10139         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10140         Remove.
10141
10142 2019-03-06  Tom Tromey  <tom@tromey.com>
10143
10144         * solib-aix.c: Use make_scope_exit.
10145
10146 2019-03-06  Tom Tromey  <tom@tromey.com>
10147
10148         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10149         Use make_scope_exit.
10150
10151 2019-03-06  Tom Tromey  <tom@tromey.com>
10152
10153         * solib-svr4.c (disable_probes_interface): Remove parameter.
10154         (svr4_handle_solib_event): Use make_scope_exit.
10155
10156 2019-03-06  Tom Tromey  <tom@tromey.com>
10157
10158         * remote.c (struct stop_reply_deleter): Remove.
10159         (stop_reply_up): Update.
10160         (struct stop_reply): Derive from notif_event.  Don't typedef.
10161         <regcache>: Now a std::vector.
10162         (stop_reply_xfree): Remove.
10163         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10164         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10165         (remote_target::discard_pending_stop_replies): Use delete.
10166         (remote_target::remote_parse_stop_reply): Update.
10167         (remote_target::process_stop_reply): Update.
10168         * remote-notif.h (struct notif_event): Add virtual destructor.
10169         Remove "dtr" member.
10170         (struct notif_client) <alloc_event>: Return a unique_ptr.
10171         (notif_event_xfree): Don't declare.
10172         (notif_event_up): New typedef.
10173         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10174         (notif_event_xfree, do_notif_event_xfree): Remove.
10175         (remote_notif_state_xfree): Update.
10176
10177 2019-03-06  Tom Tromey  <tom@tromey.com>
10178
10179         * infrun.c (displaced_step_clear_cleanup): Now a
10180         forward_scope_exit type.
10181         (displaced_step_prepare_throw): Update.
10182         (displaced_step_fixup): Update.
10183
10184 2019-03-06  Tom Tromey  <tom@tromey.com>
10185
10186         * inferior.h (class inferior): Update comment.
10187         * gdbthread.h (class thread_info): Update comment.
10188
10189 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10190             Tom Tromey  <tom@tromey.com>
10191
10192         * stabsread.h (struct stab_section_list): Remove.
10193         (coffstab_build_psymtabs): Update.
10194         * dbxread.c (symbuf_sections): Now a std::vector.
10195         (sect_idx): New global.
10196         (fill_symbuf): Update.
10197         (coffstab_build_psymtabs): Change type of stabsects parameter.
10198         Update.
10199         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10200         std::vector.
10201         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10202         (coff_locate_sections): Update.
10203         (coff_symfile_read): Remove cleanups.  Update.
10204         (init_stringtab): Add storage parameter.
10205         (free_stringtab, free_stringtab_cleanup): Remove.
10206         (init_lineno): Add storage parameter.
10207         (free_linetab, free_linetab_cleanup): Remove.
10208
10209 2019-03-06  Pedro Alves  <palves@redhat.com>
10210
10211         * linux-fork.c (fork_info::clobber_regs): Delete.
10212         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10213         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10214         comment.  Adjust.
10215         (scoped_switch_fork_info::scoped_switch_fork_info)
10216         (checkpoint_command, linux_fork_context): Adjust
10217         fork_save_infrun_state calls.
10218
10219 2019-03-06  Pedro Alves  <palves@redhat.com>
10220
10221         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10222         (inf_has_multiple_threads): Return 'bool' and rewrite using
10223         inferior_info::threads().
10224
10225 2019-03-06  Pedro Alves  <palves@redhat.com>
10226
10227         * linux-fork.c: Include <list>.
10228         (fork_list): Now a std::list instance.
10229         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10230         (forks_exist_p, find_last_fork): Adjust.
10231         (new_fork): Delete.
10232         (one_fork_p): New.
10233         (add_fork): Adjust.
10234         (free_fork): Delete, folded into fork_info::~fork_info().
10235         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10236         Adjust.
10237         (init_fork_list): Delete.
10238         (linux_fork_killall, linux_fork_mourn_inferior)
10239         (linux_fork_detach, info_checkpoints_command): Adjust.
10240         (_initialize_linux_fork): No longer call init_fork_list.
10241
10242 2019-03-06  Pedro Alves  <palves@redhat.com>
10243
10244         * linux-fork.c (new_fork): New, split out of ...
10245         (add_fork): ... this.  Return void.  Move "first fork" special
10246         case from here, to ...
10247         (checkpoint_command): ... here.
10248         * linux-linux.h (add_fork): Return void.
10249
10250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10251
10252         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10253
10254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10255             Chris January  <chris.january@arm.com>
10256             David Lecomber  <david.lecomber@arm.com>
10257
10258         * f-exp.y: New token, UNOP_INTRINSIC.
10259         (exp): New pattern using UNOP_INTRINSIC token.
10260         (f77_keywords): Add 'abs' keyword.
10261         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10262         (value_from_host_double): New function.
10263         (evaluate_subexp_f): Support UNOP_ABS.
10264
10265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10266
10267         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10268         types.
10269
10270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10271
10272         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10273         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10274         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10275
10276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10277
10278         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10279
10280 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10281             Chris January  <chris.january@arm.com>
10282
10283         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10284         * f-exp.y: Define 'KIND' token.
10285         (exp): New pattern for KIND expressions.
10286         (ptype): Handle types with a kind extension.
10287         (direct_abs_decl): Extend to spot kind extensions.
10288         (f77_keywords): Add 'kind' to the list.
10289         (push_kind_type): New function.
10290         (convert_to_kind_type): New function.
10291         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10292         * parse.c (operator_length_standard): Likewise.
10293         * parser-defs.h (enum type_pieces): Add tp_kind.
10294         * std-operator.def: Add UNOP_KIND.
10295
10296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10297
10298         * f-exp.y (f_parse): Set yydebug.
10299
10300 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10301
10302         * f-lang.c (evaluate_subexp_f): New function.
10303         (exp_descriptor_f): New global.
10304         (f_language_defn): Use exp_descriptor_f instead of
10305         exp_descriptor_standard.
10306
10307 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10308
10309         * f-exp.y (struct token): Add comments.
10310         (dot_ops): Remove uppercase versions and the end marker.
10311         (f77_keywords): Likewise.
10312         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10313         entries in the dot_ops array are case insensitive, and use
10314         strncasecmp to compare strings.  Also some whitespace cleanup in
10315         this area.  Similar for the f77_keywords array, except entries in
10316         this list might be case sensitive.
10317
10318 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10319
10320         * f-exp.y (struct f77_boolean_val): Add comments.
10321         (boolean_values): Remove uppercase versions, and end marker.
10322         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10323         and use strncasecmp to achieve case insensitivity.  Additionally,
10324         perform whitespace cleanup around this code.
10325
10326 2019-03-06  Tom Tromey  <tromey@adacore.com>
10327
10328         * remote-sim.c (gdbsim_target_open): Use result of
10329         gdb_argv::release.
10330
10331 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10332         Dirk Schubert  <dirk.schubert@arm.com>
10333         Chris January  <chris.january@arm.com>
10334
10335         * eval.c (evaluate_subexp_standard): Call Fortran argument
10336         wrapping logic.
10337         * f-lang.c (struct value): A value which can be passed into a
10338         Fortran function call.
10339         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10340         where appropriate.
10341         (struct type): Value ready for a Fortran function call.
10342         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10343         is needed.
10344         * f-lang.h (fortran_argument_convert): Declaration.
10345         (fortran_preserve_arg_pointer): Declaration.
10346         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10347
10348 2019-03-05  Tom Tromey  <tromey@adacore.com>
10349
10350         * python/py-prettyprint.c (print_string_repr): Remove #if.
10351         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10352
10353 2019-03-05  Tom Tromey  <tromey@adacore.com>
10354
10355         * target.c (the_dummy_target): Move later.  Change type to
10356         "dummy_target".
10357         (initialize_targets): Don't initialize the_dummy_target.
10358
10359 2019-03-05  Tom Tromey  <tromey@adacore.com>
10360
10361         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10362         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10363
10364 2019-03-05  Tom Tromey  <tromey@adacore.com>
10365
10366         * windows-nat.c (windows_nat_target::attach)
10367         (windows_nat_target::detach): Don't call gdb_flush.
10368         * valprint.c (generic_val_print, val_print, val_print_string):
10369         Don't call gdb_flush.
10370         * utils.c (defaulted_query): Don't call gdb_flush.
10371         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10372         * target.c (target_announce_detach): Don't call gdb_flush.
10373         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10374         * remote.c (extended_remote_target::attach): Don't call
10375         gdb_flush.
10376         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10377         * printcmd.c (do_examine): Don't call gdb_flush.
10378         (info_display_command): Don't call gdb_flush.
10379         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10380         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10381         * memattr.c (info_mem_command): Don't call gdb_flush.
10382         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10383         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10384         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10385         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10386         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10387         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10388         (gnu_nat_target::detach): Don't call gdb_flush.
10389         * f-valprint.c (f_val_print): Don't call gdb_flush.
10390         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10391         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10392         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10393         gdb_flush.
10394         * c-valprint.c (c_val_print): Don't call gdb_flush.
10395         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10396
10397 2019-03-05  Tom Tromey  <tromey@adacore.com>
10398
10399         * varobj.c (update_dynamic_varobj_children): Update.
10400         (install_default_visualizer): Use reset, not release.
10401         * value.c (set_internalvar): Update.
10402         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10403         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10404         ATTRIBUTE_UNUSED_RESULT.
10405
10406 2019-03-05  Tom Tromey  <tromey@adacore.com>
10407
10408         * remote.c (class scoped_remote_fd) <release>: Add
10409         ATTRIBUTE_UNUSED_RESULT.
10410
10411 2019-03-05  Tom Tromey  <tromey@adacore.com>
10412
10413         * macroexp.c (struct macro_buffer) <release>: Add
10414         ATTRIBUTE_UNUSED_RESULT.
10415
10416 2019-03-05  Tom Tromey  <tromey@adacore.com>
10417
10418         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10419         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10420         ATTRIBUTE_UNUSED_RESULT.
10421
10422 2019-03-05  Tom Tromey  <tromey@adacore.com>
10423
10424         * common/scoped_fd.h (class scoped_fd) <release>: Add
10425         ATTRIBUTE_UNUSED_RESULT.
10426
10427 2019-03-05  Tom Tromey  <tromey@adacore.com>
10428
10429         * parser-defs.h (struct parser_state) <release>: Add
10430         ATTRIBUTE_UNUSED_RESULT.
10431
10432 2019-03-05  Tom Tromey  <tromey@adacore.com>
10433
10434         * utils.h (class gdb_argv) <release>: Add
10435         ATTRIBUTE_UNUSED_RESULT.
10436         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10437
10438 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10439
10440         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10441         for-loop range, to avoid compiler warnings.
10442
10443         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10444         avoid compiler warnings about unused variables.
10445
10446         * NEWS: Mention end of support for native debugging on MS-Windows
10447         before XP.
10448
10449         PR gdb/24292
10450         * common/netstuff.c:
10451         * gdbserver/gdbreplay.c
10452         * gdbserver/remote-utils.c:
10453         * ser-tcp.c:
10454         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10455         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10456         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10457         'getaddrinfo' and 'freeaddrinfo' were not available before
10458         Windows XP, and mingw.org's MinGW headers by default define
10459         _WIN32_WINNT to 0x500.
10460
10461 2019-03-01  Gary Benson <gbenson@redhat.com>
10462
10463         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10464
10465 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10466             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10467
10468         PR gdb/8527
10469         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10470         set_sigint_trap, clear_sigint_trap.
10471
10472 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10473
10474         * target.c (target_detach): Clear the regcache and the
10475         frame cache.
10476
10477 2019-02-27  Pedro Alves  <palves@redhat.com>
10478
10479         * utils.c (set_screen_size): When we cap the height/width sizes,
10480         tweak the corresponding command variable to show "unlimited":
10481
10482 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10483             Pedro Alves  <palves@redhat.com>
10484
10485         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10486         before calling rl_set_screen_size.
10487
10488 2019-02-27  Tom Tromey  <tromey@adacore.com>
10489
10490         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10491         define.
10492         * python/py-value.c: Remove Python 2.4 workaround.
10493         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10494         workaround.
10495         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10496         Python 2.4 workaround.
10497         * python/python-internal.h: Remove Python 2.4 comment.
10498         (Py_ssize_t): Don't define.
10499         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10500         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10501         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10502         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10503         * python/python.c (do_start_initialization): Remove Python 2.4
10504         workaround.
10505         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10506         (print_children): Remove Python 2.4 workaround.
10507         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10508         workaround.
10509         (CHARBUFFERPROC_NAME): Remove.
10510         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10511         Python 2.4 workaround.
10512
10513 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10514
10515         * NEWS: Note minimum Python version.
10516
10517 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10518
10519         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10520         code from these functions.  Remove corresponding ifdefs.  Use
10521         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10522         Remove gotos and target of gotos.
10523         (infpy_search_memory): Likewise.
10524
10525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10526
10527         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10528         (hppa_gdbarch_init): Don't register deleted functions with
10529         gdbarch.
10530
10531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10532
10533         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10534         (h8300_unwind_sp): Delete.
10535         (h8300_dummy_id): Delete.
10536         (h8300_gdbarch_init): Don't register deleted functions with
10537         gdbarch.
10538
10539 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10540
10541         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10542         (ft32_unwind_pc): Delete.
10543         (ft32_unwind_sp): Delete.
10544         (ft32_gdbarch_init): Don't register deleted functions with
10545         gdbarch.
10546
10547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10548
10549         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10550         (frv_unwind_pc): Delete.
10551         (frv_unwind_sp): Delete.
10552         (frv_gdbarch_init): Don't register deleted functions with
10553         gdbarch.
10554
10555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10556
10557         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10558         (riscv_unwind_pc): Delete.
10559         (riscv_unwind_sp): Delete.
10560         (riscv_gdbarch_init): Don't register deleted functions with
10561         gdbarch.
10562
10563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10564
10565         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10566         (csky_unwind_pc): Delete.
10567         (csky_unwind_sp): Delete.
10568         (csky_gdbarch_init): Don't register deleted functions with
10569         gdbarch.
10570
10571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10572
10573         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10574         (cris_unwind_pc): Delete.
10575         (cris_unwind_sp): Delete.
10576         (cris_gdbarch_init): Don't register deleted functions with
10577         gdbarch.
10578
10579 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10580
10581         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10582         (bfin_unwind_pc): Delete.
10583         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10584
10585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10586
10587         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10588         (arm_unwind_pc): Delete.
10589         (arm_unwind_sp): Delete.
10590         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10591
10592 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10593
10594         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10595         (arc_unwind_pc): Delete.
10596         (arc_unwind_sp): Delete.
10597         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10598
10599 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10600
10601         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10602         (alpha_unwind_pc): Delete.
10603         (alpha_gdbarch_init): Don't register deleted functions with
10604         gdbarch.
10605
10606 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10607
10608         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10609         (aarch64_unwind_pc): Delete.
10610         (aarch64_unwind_sp): Delete.
10611         (aarch64_gdbarch_init): Don't register deleted functions with
10612         gdbarch.
10613
10614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10615
10616         * gdbtypes.c (type_align): Don't consider static members when
10617         computing structure alignment.
10618
10619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10620
10621         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10622         return 0 for other types.
10623         * arch-utils.c (default_type_align): Always return 0.
10624         * gdbarch.h: Regenerate.
10625         * gdbarch.sh (type_align): Extend comment.
10626         * gdbtypes.c (type_align): Add additional comments, always call
10627         gdbarch_type_align before applying the default rules.
10628         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10629         generic code will then apply a suitable default.
10630         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10631         types, return 0 for other types.
10632
10633 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10634
10635         * NEWS: Create a new section for the next release branch.
10636         Rename the section of the current branch, now that it has
10637         been cut.
10638
10639 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10640
10641         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10642         * version.in: Bump version to 8.3.50.DATE-git.
10643
10644 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10645
10646         * aix-thread.c (ptid_cmp): Remove unused variable.
10647         (get_signaled_thread): Likewise.
10648         (store_regs_user_thread): Likewise.
10649         (store_regs_kernel_thread): Likewise.
10650         (fetch_regs_kernel_thread): Remove shadowed variable.
10651
10652 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10653
10654         * features/riscv/32bit-cpu.xml: Add register numbers.
10655         * features/riscv/32bit-fpu.c: Regenerate.
10656         * features/riscv/32bit-fpu.xml: Add register numbers.
10657         * features/riscv/64bit-cpu.xml: Add register numbers.
10658         * features/riscv/64bit-fpu.c: Regenerate.
10659         * features/riscv/64bit-fpu.xml: Add register numbers.
10660
10661 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10662
10663         * NEWS: Mention two argument form of gdb.Value constructor.
10664         * python/py-value.c (convert_buffer_and_type_to_value): New
10665         function.
10666         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10667         Add support for handling an optional second argument.  Call
10668         convert_buffer_and_type_to_value as appropriate.
10669         * python/python-internal.h (Py_buffer_deleter): New struct.
10670         (Py_buffer_up): New typedef.
10671
10672 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10673
10674         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10675         instead of releasing ownership.
10676
10677 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10678
10679         * dwarf2read.c (open_and_init_dwp_file): Call
10680         elf_numsections instead of bfd_count_sections to initialize
10681         dwp_file->num_sections.
10682
10683 2019-02-25  Tom Tromey  <tromey@adacore.com>
10684
10685         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10686
10687 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10688
10689         * gcore.in: Add '--readnever' option when invoking GDB.
10690
10691 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10692
10693         * MAINTAINERS: Update my email address.
10694
10695 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10696
10697         * build-id.c (build_id_to_debug_bfd_1): New function.
10698         (build_id_to_debug_bfd): Look for separate debug file in
10699         sysroot.
10700
10701 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10702
10703         * gdbarch.sh: Update the copyright year range that is placed into
10704         generated files.
10705
10706 2019-02-22  Keith Seitz  <keiths@redhat.com>
10707
10708         PR symtab/23853
10709         * linespec.c (create_sals_line_offset): Search for the default
10710         symtab's filename instead of its fullname.
10711
10712 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10713
10714         * NEWS: Update style defaults.
10715
10716 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10717
10718         * main.c (captured_main_1): Disable styling in batch mode.
10719
10720 2019-02-20  Tom Tromey  <tom@tromey.com>
10721
10722         * symtab.c (symtab_symbol_info): Fix typos.
10723
10724 2019-02-20  Tom Tromey  <tromey@adacore.com>
10725
10726         * findcmd.c (_initialize_mem_search): Use upper case for
10727         metasyntactic variables.
10728
10729 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10730
10731         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10732         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10733
10734 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10735
10736         * top.h (source_file_name): Change to std::string.
10737         * top.c (source_file_name): Likewise.
10738         (command_line_input): Adjust.
10739         * cli/cli-script.c (script_from_file): Adjust.
10740
10741 2019-02-19  Tom Tromey  <tromey@adacore.com>
10742
10743         * ravenscar-thread.c
10744         (ravenscar_thread_target::update_thread_list): Don't call
10745         ada_build_task_list.
10746         * ada-lang.h (ada_build_task_list): Don't declare.
10747         * ada-tasks.c (struct ada_tasks_inferior_data)
10748         <task_list_valid_p>: Now bool.
10749         (read_known_tasks, ada_task_list_changed)
10750         (ada_tasks_invalidate_inferior_data): Update.
10751         (read_known_tasks_array): Return bool.
10752         (read_known_tasks_list): Likewise.
10753         (read_known_tasks): Return void.
10754         (ada_build_task_list): Now static.
10755
10756 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10757
10758         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10759         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10760
10761 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10762
10763         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10764         variant for ada_tasks_pspace_data_handle and
10765         ada_tasks_inferior_data_handle.
10766         (ada_tasks_pspace_data_cleanup): New function.
10767         (ada_tasks_inferior_data_cleanup): New function.
10768
10769 2019-02-17  Tom Tromey  <tom@tromey.com>
10770
10771         * macrotab.h (macro_source_fullname): Return a std::string.
10772         * macrotab.c (macro_include, check_for_redefinition)
10773         (macro_undef, macro_lookup_definition, foreach_macro)
10774         (foreach_macro_in_scope): Update.
10775         (macro_source_fullname): Return a std::string.
10776         * macrocmd.c (show_pp_source_pos): Update.
10777
10778 2019-02-17  Tom Tromey  <tom@tromey.com>
10779
10780         * macrocmd.c (show_pp_source_pos): Style the file names.
10781
10782 2019-02-17  Tom Tromey  <tom@tromey.com>
10783
10784         PR tui/24197:
10785         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10786
10787 2019-02-17  Tom Tromey  <tom@tromey.com>
10788
10789         * ada-lang.c (user_select_syms): Use filtered printing.
10790         * utils.c (wrap_style): New global.
10791         (desired_style): Remove.
10792         (emit_style_escape): Add stream parameter.
10793         (set_output_style, reset_terminal_style, prompt_for_continue):
10794         Update.
10795         (flush_wrap_buffer): Only flush gdb_stdout.
10796         (wrap_here): Set wrap_style.
10797         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10798         treat escape sequences as a character.  Change when wrap buffer is
10799         flushed.
10800         (fputs_styled): Do not set the output style when the default is
10801         requested.
10802         * ui-style.h (struct ui_file_style) <is_default>: New method.
10803         * source.c (print_source_lines_base): Emit escape sequences in one
10804         piece.
10805
10806 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10807
10808         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10809         integers and enumeration types.
10810
10811 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10812
10813         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10814         instead of lookup_symbol_in_language
10815         (do_exact_match): New function.
10816         (ada_get_symbol_name_matcher): Return do_exact_match when
10817         doing a verbatim match.
10818
10819 2019-02-15  Tom Tromey  <tromey@adacore.com>
10820
10821         * ravenscar-thread.c (ravenscar_thread_target::resume)
10822         (ravenscar_thread_target::wait): Special case wildcard requests.
10823
10824 2019-02-15  Tom Tromey  <tromey@adacore.com>
10825
10826         * ravenscar-thread.c (base_ptid): Remove.
10827         (struct ravenscar_thread_target) <close>: New method.
10828         <m_base_ptid>: New member.
10829         <update_inferior_ptid, active_task, task_is_currently_active,
10830         runtime_initialized>: Declare methods.
10831         <ravenscar_thread_target>: Add constructor.
10832         (ravenscar_thread_target::task_is_currently_active)
10833         (ravenscar_thread_target::update_inferior_ptid)
10834         (ravenscar_runtime_initialized): Rename.  Now methods.
10835         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10836         (ravenscar_thread_target::update_thread_list): Update.
10837         (ravenscar_thread_target::active_task): Now method.
10838         (ravenscar_thread_target::store_registers)
10839         (ravenscar_thread_target::prepare_to_store)
10840         (ravenscar_thread_target::prepare_to_store)
10841         (ravenscar_thread_target::mourn_inferior): Update.
10842         (ravenscar_inferior_created): Use "new" to create target.
10843         (ravenscar_thread_target::get_ada_task_ptid): Update.
10844         (_initialize_ravenscar): Don't initialize base_ptid.
10845         (ravenscar_ops): Remove global.
10846
10847 2019-02-15  Tom Tromey  <tromey@adacore.com>
10848
10849         * target.h (push_target): Declare new overload.
10850         * target.c (push_target): New overload, taking an rvalue reference.
10851         * remote.c (remote_target::open_1): Use push_target overload.
10852         * corelow.c (core_target_open): Use push_target overload.
10853
10854 2019-02-15  Tom Tromey  <tromey@adacore.com>
10855
10856         * ravenscar-thread.c (is_ravenscar_task)
10857         (ravenscar_task_is_currently_active): Return bool.
10858         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10859         (_initialize_ravenscar): Remove "(void)".
10860         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10861         Return bool.
10862
10863 2019-02-15  Tom Tromey  <tromey@adacore.com>
10864
10865         * ravenscar-thread.c (ravenscar_runtime_initializer)
10866         (has_ravenscar_runtime, get_running_thread_id)
10867         (ravenscar_thread_target::resume): Fix indentation.
10868
10869 2019-02-15  Tom Tromey  <tromey@adacore.com>
10870
10871         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10872         from ravenscar_arch_ops.
10873         (sparc_ravenscar_ops::fetch_registers)
10874         (sparc_ravenscar_ops::store_registers): Now methods.
10875         (sparc_ravenscar_prepare_to_store): Remove.
10876         (sparc_ravenscar_ops): Redefine.
10877         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10878         methods and destructor.  Remove members.
10879         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10880         (ravenscar_thread_target::store_registers)
10881         (ravenscar_thread_target::prepare_to_store): Update.
10882         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10883         Remove.
10884         (struct ppc_ravenscar_powerpc_ops): Derive from
10885         ravenscar_arch_ops.
10886         (ppc_ravenscar_powerpc_ops::fetch_registers)
10887         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10888         (ppc_ravenscar_powerpc_ops): Redefine.
10889         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10890         (ppc_ravenscar_e500_ops::fetch_registers)
10891         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10892         (ppc_ravenscar_e500_ops): Redefine.
10893         * aarch64-ravenscar-thread.c
10894         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10895         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10896         (aarch64_ravenscar_fetch_registers)
10897         (aarch64_ravenscar_store_registers): Now methods.
10898         (aarch64_ravenscar_ops): Redefine.
10899
10900 2019-02-15  Tom Tromey  <tromey@adacore.com>
10901
10902         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10903         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10904         (ravenscar_thread_target::stopped_by_watchpoint)
10905         (ravenscar_thread_target::stopped_data_address)
10906         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10907
10908 2019-02-15  Tom Tromey  <tromey@adacore.com>
10909
10910         * ravenscar-thread.c: Fix some typos.
10911
10912 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10913             Tom Tromey  <tromey@adacore.com>
10914
10915         * ada-lang.c (ada_exception_sal): Change addr_string to a
10916         std::string.
10917         (create_ada_exception_catchpoint): Update.
10918
10919 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10920             Tom Tromey  <tromey@adacore.com>
10921
10922         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10923         (bp_location_ops): Remove.
10924         (base_breakpoint_allocate_location): Update.
10925         (free_bp_location): Update.
10926         * ada-lang.c (class ada_catchpoint_location)
10927         <ada_catchpoint_location>: Remove ops parameter.
10928         (ada_catchpoint_location_dtor): Remove.
10929         (ada_catchpoint_location_ops): Remove.
10930         (allocate_location_exception): Update.
10931         * breakpoint.h (struct bp_location_ops): Remove.
10932         (class bp_location) <bp_location>: Remove bp_location_ops
10933         parameter.
10934         <~bp_location>: Add destructor.
10935         <ops>: Remove.
10936
10937 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10938             Pedro Alves  <palves@redhat.com>
10939
10940         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10941         'PATH_MAX'.
10942
10943 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10944             Samuel Thibault  <samuel.thibault@gnu.org>
10945             Thomas Schwinge  <thomas@codesourcery.com>
10946
10947         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10948         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10949
10950 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10951
10952         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10953         (check_empty): Use "const char *".
10954
10955         * gnu-nat.c (gnu_nat_target::detach): Instead of
10956         'detach_inferior (pid)' call
10957         'detach_inferior (find_inferior_pid (pid))'.
10958
10959         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10960         'nat/fork-inferior.o'.
10961         * gnu-nat.c: #include "nat/fork-inferior.h".
10962
10963         * gnu-nat.c (gnu_nat_target::detach): Instead of
10964         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10965         * gnu-nat.h: #include "inf-child.h".
10966         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10967         'i386_gnu_nat_target::fetch_registers'.
10968         (gnu_store_registers): Rename/move to
10969         'i386_gnu_nat_target::store_registers'.
10970
10971         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10972         * gnu-nat.h (mach_thread_info): New function.
10973         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10974
10975         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10976
10977 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10978
10979         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10980
10981 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10982
10983         * windows-nat.c (windows_add_thread): Add new parameter
10984         "main_thread_p" with default value set to false.  Update
10985         function documentation as well as all callers.
10986         (windows_delete_thread): Likewise.
10987         (fake_create_process): Update call to windows_add_thread.
10988         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10989         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10990         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10991         call to windows_delete_thread.
10992
10993 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10994
10995         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10996
10997 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10998
10999         * symfile.c (find_separate_debug_file): Use canonical path of
11000         sysroot with child_path instead of gdb_sysroot if it is valid.
11001
11002 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11003
11004         * symfile.c (find_separate_debug_file): Use child_path to
11005         determine if an object file is under a sysroot.
11006
11007 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11008
11009         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11010         unittests/child-path-selftests.c.
11011         * common/pathstuff.c (child_path): New function.
11012         * common/pathstuff.h (child_path): New prototype.
11013         * unittests/child-path-selftests.c: New file.
11014
11015 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11016
11017         * symfile.c (find_separate_debug_file): Look for separate debug
11018         files in debug directories under the sysroot.
11019
11020 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11021
11022         * symtab.h (struct minimal_symbol data_p): New const method.
11023         (struct minimal_symbol text_p): Likewise.
11024         * symtab.c (output_source_filename): Use file name style
11025         to print file name.
11026         (print_symbol_info): Likewise.
11027         (print_msymbol_info): Use address style to print addresses.
11028         Use function name style to print executable text symbols.
11029         (expand_symtab_containing_pc): Use data_p.
11030         (find_pc_sect_compunit_symtab): Likewise.
11031
11032 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11033
11034         * breakpoint.c (describe_other_breakpoints): Use address style
11035         to print addresses.
11036         (say_where): Likewise.
11037
11038 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11039
11040         * ada-typeprint.c (print_func_type): Print function name
11041         style to print function name.
11042         * c-typeprint.c (c_print_type_1): Likewise.
11043
11044 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11045
11046         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11047         for execve.
11048
11049 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11050
11051         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11052         type_stack.
11053
11054 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11055
11056         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11057         TYPE_CODE_REF types.
11058
11059 2019-02-08  Jim Wilson  <jimw@sifive.com>
11060
11061         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11062         (riscv_linux_fregset): New.
11063         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11064
11065 2019-02-07  Tom Tromey  <tom@tromey.com>
11066
11067         * thread.c (thread_cancel_execution_command): Update.
11068         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11069         methods.
11070         (struct thread_fsm_ops): Remove.
11071         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11072         (thread_fsm_should_stop, thread_fsm_return_value)
11073         (thread_fsm_set_finished, thread_fsm_finished_p)
11074         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11075         Don't declare.
11076         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11077         * infrun.c (clear_proceed_status_thread)
11078         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11079         (print_stop_event): Update.
11080         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11081         Add constructor.
11082         (step_command_fsm_ops): Remove.
11083         (new_step_command_fsm): Remove.
11084         (step_1): Update.
11085         (step_command_fsm::should_stop): Rename from
11086         step_command_fsm_should_stop.
11087         (step_command_fsm::clean_up): Rename from
11088         step_command_fsm_clean_up.
11089         (step_command_fsm::do_async_reply_reason): Rename from
11090         step_command_fsm_async_reply_reason.
11091         (struct until_next_fsm): Inherit from thread_fsm.  Add
11092         constructor.
11093         (until_next_fsm_ops): Remove.
11094         (new_until_next_fsm): Remove.
11095         (until_next_fsm::should_stop): Rename from
11096         until_next_fsm_should_stop.
11097         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11098         (until_next_fsm::do_async_reply_reason): Rename from
11099         until_next_fsm_async_reply_reason.
11100         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11101         constructor.  Change type of breakpoint.
11102         (finish_command_fsm_ops): Remove.
11103         (new_finish_command_fsm): Remove.
11104         (finish_command_fsm::should_stop): Rename from
11105         finish_command_fsm_should_stop.
11106         (finish_command_fsm::clean_up): Rename from
11107         finish_command_fsm_clean_up.
11108         (finish_command_fsm::return_value): Rename from
11109         finish_command_fsm_return_value.
11110         (finish_command_fsm::do_async_reply_reason): Rename from
11111         finish_command_fsm_async_reply_reason.
11112         (finish_command): Update.
11113         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11114         Add constructor.
11115         (call_thread_fsm_ops): Remove.
11116         (call_thread_fsm::call_thread_fsm): Rename from
11117         new_call_thread_fsm.
11118         (call_thread_fsm::should_stop): Rename from
11119         call_thread_fsm_should_stop.
11120         (call_thread_fsm::should_notify_stop): Rename from
11121         call_thread_fsm_should_notify_stop.
11122         (run_inferior_call, call_function_by_hand_dummy): Update.
11123         * cli/cli-interp.c (should_print_stop_to_console): Update.
11124         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11125         Add constructor.  Change type of location_breakpoint,
11126         caller_breakpoint.
11127         (until_break_fsm_ops): Remove.
11128         (new_until_break_fsm): Remove.
11129         (until_break_fsm::should_stop): Rename from
11130         until_break_fsm_should_stop.
11131         (until_break_fsm::clean_up): Rename from
11132         until_break_fsm_clean_up.
11133         (until_break_fsm::do_async_reply_reason): Rename from
11134         until_break_fsm_async_reply_reason.
11135         (until_break_command): Update.
11136         * thread-fsm.c: Remove.
11137         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11138
11139 2019-02-07  Tom Tromey  <tom@tromey.com>
11140
11141         * yy-remap.h: Add include guard.
11142         * xtensa-tdep.h: Add include guard.
11143         * xcoffread.h: Rename include guard.
11144         * varobj-iter.h: Add include guard.
11145         * tui/tui.h: Rename include guard.
11146         * tui/tui-winsource.h: Rename include guard.
11147         * tui/tui-wingeneral.h: Rename include guard.
11148         * tui/tui-windata.h: Rename include guard.
11149         * tui/tui-win.h: Rename include guard.
11150         * tui/tui-stack.h: Rename include guard.
11151         * tui/tui-source.h: Rename include guard.
11152         * tui/tui-regs.h: Rename include guard.
11153         * tui/tui-out.h: Rename include guard.
11154         * tui/tui-layout.h: Rename include guard.
11155         * tui/tui-io.h: Rename include guard.
11156         * tui/tui-hooks.h: Rename include guard.
11157         * tui/tui-file.h: Rename include guard.
11158         * tui/tui-disasm.h: Rename include guard.
11159         * tui/tui-data.h: Rename include guard.
11160         * tui/tui-command.h: Rename include guard.
11161         * tic6x-tdep.h: Add include guard.
11162         * target/waitstatus.h: Rename include guard.
11163         * target/wait.h: Rename include guard.
11164         * target/target.h: Rename include guard.
11165         * target/resume.h: Rename include guard.
11166         * target-float.h: Rename include guard.
11167         * stabsread.h: Add include guard.
11168         * rs6000-tdep.h: Add include guard.
11169         * riscv-fbsd-tdep.h: Add include guard.
11170         * regformats/regdef.h: Rename include guard.
11171         * record.h: Rename include guard.
11172         * python/python.h: Rename include guard.
11173         * python/python-internal.h: Rename include guard.
11174         * python/py-stopevent.h: Rename include guard.
11175         * python/py-ref.h: Rename include guard.
11176         * python/py-record.h: Rename include guard.
11177         * python/py-record-full.h: Rename include guard.
11178         * python/py-record-btrace.h: Rename include guard.
11179         * python/py-instruction.h: Rename include guard.
11180         * python/py-events.h: Rename include guard.
11181         * python/py-event.h: Rename include guard.
11182         * procfs.h: Add include guard.
11183         * proc-utils.h: Add include guard.
11184         * p-lang.h: Add include guard.
11185         * or1k-tdep.h: Rename include guard.
11186         * observable.h: Rename include guard.
11187         * nto-tdep.h: Rename include guard.
11188         * nat/x86-linux.h: Rename include guard.
11189         * nat/x86-linux-dregs.h: Rename include guard.
11190         * nat/x86-gcc-cpuid.h: Add include guard.
11191         * nat/x86-dregs.h: Rename include guard.
11192         * nat/x86-cpuid.h: Rename include guard.
11193         * nat/ppc-linux.h: Rename include guard.
11194         * nat/mips-linux-watch.h: Rename include guard.
11195         * nat/linux-waitpid.h: Rename include guard.
11196         * nat/linux-ptrace.h: Rename include guard.
11197         * nat/linux-procfs.h: Rename include guard.
11198         * nat/linux-osdata.h: Rename include guard.
11199         * nat/linux-nat.h: Rename include guard.
11200         * nat/linux-namespaces.h: Rename include guard.
11201         * nat/linux-btrace.h: Rename include guard.
11202         * nat/glibc_thread_db.h: Rename include guard.
11203         * nat/gdb_thread_db.h: Rename include guard.
11204         * nat/gdb_ptrace.h: Rename include guard.
11205         * nat/fork-inferior.h: Rename include guard.
11206         * nat/amd64-linux-siginfo.h: Rename include guard.
11207         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11208         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11209         * nat/aarch64-linux.h: Rename include guard.
11210         * nat/aarch64-linux-hw-point.h: Rename include guard.
11211         * mn10300-tdep.h: Add include guard.
11212         * mips-linux-tdep.h: Add include guard.
11213         * mi/mi-parse.h: Rename include guard.
11214         * mi/mi-out.h: Rename include guard.
11215         * mi/mi-main.h: Rename include guard.
11216         * mi/mi-interp.h: Rename include guard.
11217         * mi/mi-getopt.h: Rename include guard.
11218         * mi/mi-console.h: Rename include guard.
11219         * mi/mi-common.h: Rename include guard.
11220         * mi/mi-cmds.h: Rename include guard.
11221         * mi/mi-cmd-break.h: Rename include guard.
11222         * m2-lang.h: Add include guard.
11223         * location.h: Rename include guard.
11224         * linux-record.h: Rename include guard.
11225         * linux-nat.h: Add include guard.
11226         * linux-fork.h: Add include guard.
11227         * i386-darwin-tdep.h: Rename include guard.
11228         * hppa-linux-offsets.h: Add include guard.
11229         * guile/guile.h: Rename include guard.
11230         * guile/guile-internal.h: Rename include guard.
11231         * gnu-nat.h: Rename include guard.
11232         * gdb-stabs.h: Rename include guard.
11233         * frv-tdep.h: Add include guard.
11234         * f-lang.h: Add include guard.
11235         * event-loop.h: Add include guard.
11236         * darwin-nat.h: Rename include guard.
11237         * cp-abi.h: Rename include guard.
11238         * config/sparc/nm-sol2.h: Rename include guard.
11239         * config/nm-nto.h: Rename include guard.
11240         * config/nm-linux.h: Add include guard.
11241         * config/i386/nm-i386gnu.h: Rename include guard.
11242         * config/djgpp/nl_types.h: Rename include guard.
11243         * config/djgpp/langinfo.h: Rename include guard.
11244         * compile/gcc-cp-plugin.h: Add include guard.
11245         * compile/gcc-c-plugin.h: Add include guard.
11246         * compile/compile.h: Rename include guard.
11247         * compile/compile-object-run.h: Rename include guard.
11248         * compile/compile-object-load.h: Rename include guard.
11249         * compile/compile-internal.h: Rename include guard.
11250         * compile/compile-cplus.h: Rename include guard.
11251         * compile/compile-c.h: Rename include guard.
11252         * common/xml-utils.h: Rename include guard.
11253         * common/x86-xstate.h: Rename include guard.
11254         * common/version.h: Rename include guard.
11255         * common/vec.h: Rename include guard.
11256         * common/tdesc.h: Rename include guard.
11257         * common/selftest.h: Rename include guard.
11258         * common/scoped_restore.h: Rename include guard.
11259         * common/scoped_mmap.h: Rename include guard.
11260         * common/scoped_fd.h: Rename include guard.
11261         * common/safe-iterator.h: Rename include guard.
11262         * common/run-time-clock.h: Rename include guard.
11263         * common/refcounted-object.h: Rename include guard.
11264         * common/queue.h: Rename include guard.
11265         * common/ptid.h: Rename include guard.
11266         * common/print-utils.h: Rename include guard.
11267         * common/preprocessor.h: Rename include guard.
11268         * common/pathstuff.h: Rename include guard.
11269         * common/observable.h: Rename include guard.
11270         * common/netstuff.h: Rename include guard.
11271         * common/job-control.h: Rename include guard.
11272         * common/host-defs.h: Rename include guard.
11273         * common/gdb_wait.h: Rename include guard.
11274         * common/gdb_vecs.h: Rename include guard.
11275         * common/gdb_unlinker.h: Rename include guard.
11276         * common/gdb_unique_ptr.h: Rename include guard.
11277         * common/gdb_tilde_expand.h: Rename include guard.
11278         * common/gdb_sys_time.h: Rename include guard.
11279         * common/gdb_string_view.h: Rename include guard.
11280         * common/gdb_splay_tree.h: Rename include guard.
11281         * common/gdb_setjmp.h: Rename include guard.
11282         * common/gdb_ref_ptr.h: Rename include guard.
11283         * common/gdb_optional.h: Rename include guard.
11284         * common/gdb_locale.h: Rename include guard.
11285         * common/gdb_assert.h: Rename include guard.
11286         * common/filtered-iterator.h: Rename include guard.
11287         * common/filestuff.h: Rename include guard.
11288         * common/fileio.h: Rename include guard.
11289         * common/environ.h: Rename include guard.
11290         * common/common-utils.h: Rename include guard.
11291         * common/common-types.h: Rename include guard.
11292         * common/common-regcache.h: Rename include guard.
11293         * common/common-inferior.h: Rename include guard.
11294         * common/common-gdbthread.h: Rename include guard.
11295         * common/common-exceptions.h: Rename include guard.
11296         * common/common-defs.h: Rename include guard.
11297         * common/common-debug.h: Rename include guard.
11298         * common/cleanups.h: Rename include guard.
11299         * common/buffer.h: Rename include guard.
11300         * common/btrace-common.h: Rename include guard.
11301         * common/break-common.h: Rename include guard.
11302         * cli/cli-utils.h: Rename include guard.
11303         * cli/cli-style.h: Rename include guard.
11304         * cli/cli-setshow.h: Rename include guard.
11305         * cli/cli-script.h: Rename include guard.
11306         * cli/cli-interp.h: Rename include guard.
11307         * cli/cli-decode.h: Rename include guard.
11308         * cli/cli-cmds.h: Rename include guard.
11309         * charset-list.h: Add include guard.
11310         * buildsym-legacy.h: Rename include guard.
11311         * bfin-tdep.h: Add include guard.
11312         * ax.h: Rename include guard.
11313         * arm-linux-tdep.h: Add include guard.
11314         * arm-fbsd-tdep.h: Add include guard.
11315         * arch/xtensa.h: Rename include guard.
11316         * arch/tic6x.h: Add include guard.
11317         * arch/i386.h: Add include guard.
11318         * arch/arm.h: Rename include guard.
11319         * arch/arm-linux.h: Rename include guard.
11320         * arch/arm-get-next-pcs.h: Rename include guard.
11321         * arch/amd64.h: Add include guard.
11322         * arch/aarch64-insn.h: Rename include guard.
11323         * arch-utils.h: Rename include guard.
11324         * annotate.h: Add include guard.
11325         * amd64-darwin-tdep.h: Rename include guard.
11326         * aarch64-linux-tdep.h: Add include guard.
11327         * aarch64-fbsd-tdep.h: Add include guard.
11328         * aarch32-linux-nat.h: Add include guard.
11329
11330 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11331
11332         * macrotab.c (macro_define_internal): New function that
11333         factorizes macro_define_object_internal and macro_define_function
11334         code.
11335         (macro_define_object_internal): Use macro_define_internal.
11336         (macro_define_function): Likewise.
11337
11338 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11339
11340         * macrocmd.c (extract_identifier): Return
11341         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11342         callers.
11343
11344 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11345
11346         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11347
11348 2019-02-05  Tom Tromey  <tom@tromey.com>
11349
11350         * target.c (target_stack::unpush): Move assertion earlier.
11351
11352 2019-01-30  Tom Tromey  <tom@tromey.com>
11353
11354         PR python/23615:
11355         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11356         (gdbpy_parse_and_eval): Likewise.
11357         * python/python-internal.h (gdbpy_allow_threads): New class.
11358
11359 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11360
11361         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11362         (aarch64_fbsd_fpregmap): Move earlier.
11363         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11364         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11365         instead of individual calls to trad_frame_set_reg_addr.
11366         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11367         earlier.
11368         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11369         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11370         instead of individual calls to trad_frame_set_reg_addr.
11371
11372 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11373
11374         * CONTRIBUTE: Replace contribution list with wiki link.
11375
11376 2019-01-25  Tom Tromey  <tom@tromey.com>
11377
11378         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11379
11380 2019-01-25  Tom Tromey  <tom@tromey.com>
11381
11382         * xtensa-linux-nat.c: Fix common/ includes.
11383         * xml-support.h: Fix common/ includes.
11384         * xml-support.c: Fix common/ includes.
11385         * x86-linux-nat.c: Fix common/ includes.
11386         * windows-nat.c: Fix common/ includes.
11387         * varobj.h: Fix common/ includes.
11388         * varobj.c: Fix common/ includes.
11389         * value.c: Fix common/ includes.
11390         * valops.c: Fix common/ includes.
11391         * utils.c: Fix common/ includes.
11392         * unittests/xml-utils-selftests.c: Fix common/ includes.
11393         * unittests/utils-selftests.c: Fix common/ includes.
11394         * unittests/unpack-selftests.c: Fix common/ includes.
11395         * unittests/tracepoint-selftests.c: Fix common/ includes.
11396         * unittests/style-selftests.c: Fix common/ includes.
11397         * unittests/string_view-selftests.c: Fix common/ includes.
11398         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11399         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11400         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11401         * unittests/rsp-low-selftests.c: Fix common/ includes.
11402         * unittests/parse-connection-spec-selftests.c: Fix common/
11403         includes.
11404         * unittests/optional-selftests.c: Fix common/ includes.
11405         * unittests/offset-type-selftests.c: Fix common/ includes.
11406         * unittests/observable-selftests.c: Fix common/ includes.
11407         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11408         * unittests/memrange-selftests.c: Fix common/ includes.
11409         * unittests/memory-map-selftests.c: Fix common/ includes.
11410         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11411         * unittests/function-view-selftests.c: Fix common/ includes.
11412         * unittests/environ-selftests.c: Fix common/ includes.
11413         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11414         * unittests/common-utils-selftests.c: Fix common/ includes.
11415         * unittests/cli-utils-selftests.c: Fix common/ includes.
11416         * unittests/array-view-selftests.c: Fix common/ includes.
11417         * ui-file.c: Fix common/ includes.
11418         * tui/tui-io.c: Fix common/ includes.
11419         * tracepoint.h: Fix common/ includes.
11420         * tracepoint.c: Fix common/ includes.
11421         * tracefile-tfile.c: Fix common/ includes.
11422         * top.h: Fix common/ includes.
11423         * top.c: Fix common/ includes.
11424         * thread.c: Fix common/ includes.
11425         * target/waitstatus.h: Fix common/ includes.
11426         * target/waitstatus.c: Fix common/ includes.
11427         * target.h: Fix common/ includes.
11428         * target.c: Fix common/ includes.
11429         * target-memory.c: Fix common/ includes.
11430         * target-descriptions.c: Fix common/ includes.
11431         * symtab.h: Fix common/ includes.
11432         * symfile.c: Fix common/ includes.
11433         * stap-probe.c: Fix common/ includes.
11434         * spu-linux-nat.c: Fix common/ includes.
11435         * sparc-nat.c: Fix common/ includes.
11436         * source.c: Fix common/ includes.
11437         * solib.c: Fix common/ includes.
11438         * solib-target.c: Fix common/ includes.
11439         * ser-unix.c: Fix common/ includes.
11440         * ser-tcp.c: Fix common/ includes.
11441         * ser-pipe.c: Fix common/ includes.
11442         * ser-base.c: Fix common/ includes.
11443         * selftest-arch.c: Fix common/ includes.
11444         * s12z-tdep.c: Fix common/ includes.
11445         * rust-exp.y: Fix common/ includes.
11446         * rs6000-aix-tdep.c: Fix common/ includes.
11447         * riscv-tdep.c: Fix common/ includes.
11448         * remote.c: Fix common/ includes.
11449         * remote-notif.h: Fix common/ includes.
11450         * remote-fileio.h: Fix common/ includes.
11451         * remote-fileio.c: Fix common/ includes.
11452         * regcache.h: Fix common/ includes.
11453         * regcache.c: Fix common/ includes.
11454         * record-btrace.c: Fix common/ includes.
11455         * python/python.c: Fix common/ includes.
11456         * python/py-type.c: Fix common/ includes.
11457         * python/py-inferior.c: Fix common/ includes.
11458         * progspace.h: Fix common/ includes.
11459         * producer.c: Fix common/ includes.
11460         * procfs.c: Fix common/ includes.
11461         * proc-api.c: Fix common/ includes.
11462         * printcmd.c: Fix common/ includes.
11463         * ppc-linux-nat.c: Fix common/ includes.
11464         * parser-defs.h: Fix common/ includes.
11465         * osdata.c: Fix common/ includes.
11466         * obsd-nat.c: Fix common/ includes.
11467         * nat/x86-linux.c: Fix common/ includes.
11468         * nat/x86-linux-dregs.c: Fix common/ includes.
11469         * nat/x86-dregs.h: Fix common/ includes.
11470         * nat/x86-dregs.c: Fix common/ includes.
11471         * nat/ppc-linux.c: Fix common/ includes.
11472         * nat/mips-linux-watch.h: Fix common/ includes.
11473         * nat/mips-linux-watch.c: Fix common/ includes.
11474         * nat/linux-waitpid.c: Fix common/ includes.
11475         * nat/linux-ptrace.h: Fix common/ includes.
11476         * nat/linux-ptrace.c: Fix common/ includes.
11477         * nat/linux-procfs.c: Fix common/ includes.
11478         * nat/linux-personality.c: Fix common/ includes.
11479         * nat/linux-osdata.c: Fix common/ includes.
11480         * nat/linux-namespaces.c: Fix common/ includes.
11481         * nat/linux-btrace.h: Fix common/ includes.
11482         * nat/linux-btrace.c: Fix common/ includes.
11483         * nat/fork-inferior.c: Fix common/ includes.
11484         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11485         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11486         * nat/aarch64-linux.c: Fix common/ includes.
11487         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11488         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11489         * namespace.h: Fix common/ includes.
11490         * mips-linux-tdep.c: Fix common/ includes.
11491         * minsyms.c: Fix common/ includes.
11492         * mi/mi-parse.h: Fix common/ includes.
11493         * mi/mi-main.c: Fix common/ includes.
11494         * mi/mi-cmd-env.c: Fix common/ includes.
11495         * memrange.h: Fix common/ includes.
11496         * memattr.c: Fix common/ includes.
11497         * maint.h: Fix common/ includes.
11498         * maint.c: Fix common/ includes.
11499         * main.c: Fix common/ includes.
11500         * machoread.c: Fix common/ includes.
11501         * location.c: Fix common/ includes.
11502         * linux-thread-db.c: Fix common/ includes.
11503         * linux-nat.c: Fix common/ includes.
11504         * linux-fork.c: Fix common/ includes.
11505         * inline-frame.c: Fix common/ includes.
11506         * infrun.c: Fix common/ includes.
11507         * inflow.c: Fix common/ includes.
11508         * inferior.h: Fix common/ includes.
11509         * inferior.c: Fix common/ includes.
11510         * infcmd.c: Fix common/ includes.
11511         * inf-ptrace.c: Fix common/ includes.
11512         * inf-child.c: Fix common/ includes.
11513         * ia64-linux-nat.c: Fix common/ includes.
11514         * i387-tdep.c: Fix common/ includes.
11515         * i386-tdep.c: Fix common/ includes.
11516         * i386-linux-tdep.c: Fix common/ includes.
11517         * i386-linux-nat.c: Fix common/ includes.
11518         * i386-go32-tdep.c: Fix common/ includes.
11519         * i386-fbsd-tdep.c: Fix common/ includes.
11520         * i386-fbsd-nat.c: Fix common/ includes.
11521         * guile/scm-type.c: Fix common/ includes.
11522         * guile/guile.c: Fix common/ includes.
11523         * go32-nat.c: Fix common/ includes.
11524         * gnu-nat.c: Fix common/ includes.
11525         * gdbthread.h: Fix common/ includes.
11526         * gdbarch-selftests.c: Fix common/ includes.
11527         * gdb_usleep.c: Fix common/ includes.
11528         * gdb_select.h: Fix common/ includes.
11529         * gdb_bfd.c: Fix common/ includes.
11530         * gcore.c: Fix common/ includes.
11531         * fork-child.c: Fix common/ includes.
11532         * findvar.c: Fix common/ includes.
11533         * fbsd-nat.c: Fix common/ includes.
11534         * event-top.c: Fix common/ includes.
11535         * event-loop.c: Fix common/ includes.
11536         * dwarf2read.c: Fix common/ includes.
11537         * dwarf2loc.c: Fix common/ includes.
11538         * dwarf2-frame.c: Fix common/ includes.
11539         * dwarf-index-cache.c: Fix common/ includes.
11540         * dtrace-probe.c: Fix common/ includes.
11541         * disasm-selftests.c: Fix common/ includes.
11542         * defs.h: Fix common/ includes.
11543         * csky-tdep.c: Fix common/ includes.
11544         * cp-valprint.c: Fix common/ includes.
11545         * cp-support.h: Fix common/ includes.
11546         * cp-support.c: Fix common/ includes.
11547         * corelow.c: Fix common/ includes.
11548         * completer.h: Fix common/ includes.
11549         * completer.c: Fix common/ includes.
11550         * compile/compile.c: Fix common/ includes.
11551         * compile/compile-loc2c.c: Fix common/ includes.
11552         * compile/compile-cplus-types.c: Fix common/ includes.
11553         * compile/compile-cplus-symbols.c: Fix common/ includes.
11554         * command.h: Fix common/ includes.
11555         * cli/cli-dump.c: Fix common/ includes.
11556         * cli/cli-cmds.c: Fix common/ includes.
11557         * charset.c: Fix common/ includes.
11558         * build-id.c: Fix common/ includes.
11559         * btrace.h: Fix common/ includes.
11560         * btrace.c: Fix common/ includes.
11561         * breakpoint.h: Fix common/ includes.
11562         * breakpoint.c: Fix common/ includes.
11563         * ax.h:
11564         (enum agent_op): Fix common/ includes.
11565         * ax-general.c (struct aop_map): Fix common/ includes.
11566         * ax-gdb.c: Fix common/ includes.
11567         * auxv.c: Fix common/ includes.
11568         * auto-load.c: Fix common/ includes.
11569         * arm-tdep.c: Fix common/ includes.
11570         * arch/riscv.c: Fix common/ includes.
11571         * arch/ppc-linux-common.c: Fix common/ includes.
11572         * arch/i386.c: Fix common/ includes.
11573         * arch/arm.c: Fix common/ includes.
11574         * arch/arm-linux.c: Fix common/ includes.
11575         * arch/arm-get-next-pcs.c: Fix common/ includes.
11576         * arch/amd64.c: Fix common/ includes.
11577         * arch/aarch64.c: Fix common/ includes.
11578         * arch/aarch64-insn.c: Fix common/ includes.
11579         * arch-utils.c: Fix common/ includes.
11580         * amd64-windows-tdep.c: Fix common/ includes.
11581         * amd64-tdep.c: Fix common/ includes.
11582         * amd64-sol2-tdep.c: Fix common/ includes.
11583         * amd64-obsd-tdep.c: Fix common/ includes.
11584         * amd64-nbsd-tdep.c: Fix common/ includes.
11585         * amd64-linux-tdep.c: Fix common/ includes.
11586         * amd64-linux-nat.c: Fix common/ includes.
11587         * amd64-fbsd-tdep.c: Fix common/ includes.
11588         * amd64-fbsd-nat.c: Fix common/ includes.
11589         * amd64-dicos-tdep.c: Fix common/ includes.
11590         * amd64-darwin-tdep.c: Fix common/ includes.
11591         * agent.c: Fix common/ includes.
11592         * ada-lang.h: Fix common/ includes.
11593         * ada-lang.c: Fix common/ includes.
11594         * aarch64-tdep.c: Fix common/ includes.
11595
11596 2019-01-25  Tom Tromey  <tom@tromey.com>
11597
11598         * common/create-version.sh: Use common/version.h.
11599
11600 2019-01-24  Pedro Alves  <palves@redhat.com>
11601
11602         * infrun.c (signal_stop, signal_print, signal_program)
11603         (signal_catch, signal_pass): Now arrays instead of pointers.
11604         (update_signals_program_target, do_target_resume)
11605         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11606         * linux-nat.c (linux_nat_target::pass_signals)
11607         (linux_nat_target::create_inferior, linux_nat_target::attach):
11608         Adjust.
11609         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11610         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11611         * procfs.c (procfs_target::pass_signals): Adjust.
11612         * record-full.c (record_full_target::resume): Adjust.
11613         * remote.c (remote_target::pass_signals)
11614         (remote_target::program_signals): Adjust.
11615         * target-debug.h (target_debug_print_signals): Now takes a
11616         gdb::array_view as parameter.  Adjust.
11617         * target.h (target_ops) <pass_signals, program_signals>: Replace
11618         pointer and length parameters with gdb::array_view.
11619         (target_pass_signals, target_program_signals): Likewise.
11620         * target-delegates.c: Regenerate.
11621
11622 2019-01-24  Pedro Alves  <palves@redhat.com>
11623
11624         * common/forward-scope-exit.h
11625         (forward_scope_exit::forward_scope_exit): Pass arguments to
11626         m_bind_function directly, instead of creating a std::bind and
11627         copying that.
11628
11629 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11630
11631         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11632         for static members.
11633         (pass_in_v_vfp_candidate): Likewise.
11634
11635 2019-01-23  Tom Tromey  <tom@tromey.com>
11636             Pedro Alves  <palves@redhat.com>
11637
11638         * regcache.c (class regcache_invalidator): Remove.
11639         (regcache::raw_write): Use make_scope_exit.
11640
11641 2019-01-23  Tom Tromey  <tom@tromey.com>
11642
11643         * ui-out.h (class ui_out_emit_type): Update comment.
11644
11645 2019-01-23  Tom Tromey  <tom@tromey.com>
11646
11647         * infrun.c (fetch_inferior_event): Update comment.
11648
11649 2019-01-23  Tom Tromey  <tom@tromey.com>
11650             Pedro Alves  <palves@redhat.com>
11651
11652         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11653         parameter.
11654         (fetch_inferior_event): Use SCOPE_EXIT.
11655
11656
11657 2019-01-23  Tom Tromey  <tom@tromey.com>
11658             Pedro Alves  <palves@redhat.com>
11659
11660         * infrun.c (disable_thread_events): Delete.
11661         (stop_all_threads): Use SCOPE_EXIT.
11662
11663 2019-01-23  Tom Tromey  <tom@tromey.com>
11664             Pedro Alves  <palves@redhat.com>
11665
11666         * symfile.c: Include forward-scope-exit.h.
11667         (clear_symtab_users_cleanup): Replace forward declaration with
11668         a FORWARD_SCOPE_EXIT.
11669         (syms_from_objfile_1): Use the forward_scope_exit and
11670         gdb::optional instead of cleanup_function.
11671         (reread_symbols): Use the forward_scope_exit instead of
11672         cleanup_function.
11673         (clear_symtab_users_cleanup): Remove function.
11674
11675 2019-01-23  Tom Tromey  <tom@tromey.com>
11676             Pedro Alves  <palves@redhat.com>
11677
11678         * linux-nat.c: Include scope-exit.h.
11679         (cleanup_target_stop): Remove.
11680         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11681         SCOPE_EXIT.
11682
11683 2019-01-23  Tom Tromey  <tom@tromey.com>
11684             Pedro Alves  <palves@redhat.com>
11685
11686         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11687         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11688
11689 2019-01-23  Tom Tromey  <tom@tromey.com>
11690             Andrew Burgess  <andrew.burgess@embecosm.com>
11691             Pedro Alves  <palves@redhat.com>
11692
11693         * infrun.c (fetch_inferior_event): Use scope_exit.
11694         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11695         * top.c (execute_command): Use scope_exit.
11696         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11697         * utils.c (do_bpstat_clear_actions_cleanup)
11698         (make_bpstat_clear_actions_cleanup): Remove.
11699
11700 2019-01-23  Tom Tromey  <tom@tromey.com>
11701             Pedro Alves  <palves@redhat.com>
11702
11703         * infrun.c: Include "common/scope-exit.h"
11704         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11705         (wait_for_inferior): Use SCOPE_EXIT.
11706         (fetch_inferior_event): Use scope_exit.
11707
11708 2019-01-23  Tom Tromey  <tom@tromey.com>
11709             Pedro Alves  <palves@redhat.com>
11710
11711         * breakpoint.c (create_breakpoint): Remove cleanup.
11712
11713 2019-01-23  Tom Tromey  <tom@tromey.com>
11714             Andrew Burgess  <andrew.burgess@embecosm.com>
11715             Pedro Alves  <palves@redhat.com>
11716
11717 2019-01-23  Pedro Alves  <palves@redhat.com>
11718
11719         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11720
11721 2019-01-23  Pedro Alves  <palves@redhat.com>
11722             Andrew Burgess  <andrew.burgess@embecosm.com>
11723
11724         * gdbthread.h: Include "common/forward-scope-exit.h".
11725         (scoped_finish_thread_state): Redefine custom class in terms of
11726         forward_scope_exit.
11727
11728 2019-01-23  Pedro Alves  <palves@redhat.com>
11729             Andrew Burgess  <andrew.burgess@embecosm.com>
11730
11731         * common/forward-scope-exit.h: New file.
11732
11733 2019-01-23  Pedro Alves  <palves@redhat.com>
11734             Andrew Burgess  <andrew.burgess@embecosm.com>
11735             Tom Tromey  <tom@tromey.com>
11736
11737         * common/scope-exit.h: New file.
11738
11739 2019-01-23  Pedro Alves  <palves@redhat.com>
11740
11741         * common/preprocessor.h (ESC): Rename to ...
11742         (ESC_PARENS): ... this.
11743         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11744         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11745
11746 2019-01-23  Tom Tromey  <tom@tromey.com>
11747
11748         * language.h (class scoped_switch_to_sym_language_if_auto):
11749         Initialize m_lang in both cases.
11750
11751 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11752
11753         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11754         with XCNEW.
11755
11756 2019-01-22  Tom Tromey  <tom@tromey.com>
11757
11758         * corelow.c: Do not include sys/file.h.
11759
11760 2019-01-22  Tom Tromey  <tom@tromey.com>
11761
11762         * tui/tui-wingeneral.h: Include gdb_curses.h.
11763
11764 2019-01-22  Tom Tromey  <tom@tromey.com>
11765
11766         * source-cache.h (class source_cache) <get_source_lines,
11767         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11768
11769 2019-01-22  Tom Tromey  <tom@tromey.com>
11770
11771         * remote-fileio.h (struct remote_target): Declare.
11772
11773 2019-01-22  Tom Tromey  <tom@tromey.com>
11774
11775         * python/py-arch.c: Do not include py-ref.h.
11776         * python/py-bpevent.c: Do not include py-ref.h.
11777         * python/py-cmd.c: Do not include py-ref.h.
11778         * python/py-continueevent.c: Do not include py-ref.h.
11779         * python/py-event.h: Do not include py-ref.h.
11780         * python/py-evtregistry.c: Do not include py-ref.h.
11781         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11782         * python/py-frame.c: Do not include py-ref.h.
11783         * python/py-framefilter.c: Do not include py-ref.h.
11784         * python/py-function.c: Do not include py-ref.h.
11785         * python/py-infevents.c: Do not include py-ref.h.
11786         * python/py-linetable.c: Do not include py-ref.h.
11787         * python/py-objfile.c: Do not include py-ref.h.
11788         * python/py-param.c: Do not include py-ref.h.
11789         * python/py-prettyprint.c: Do not include py-ref.h.
11790         * python/py-progspace.c: Do not include py-ref.h.
11791         * python/py-symbol.c: Do not include py-ref.h.
11792         * python/py-symtab.c: Do not include py-ref.h.
11793         * python/py-type.c: Do not include py-ref.h.
11794         * python/py-unwind.c: Do not include py-ref.h.
11795         * python/py-utils.c: Do not include py-ref.h.
11796         * python/py-value.c: Do not include py-ref.h.
11797         * python/py-varobj.c: Do not include py-ref.h.
11798         * python/py-xmethods.c: Do not include py-ref.h.
11799         * python/python.c: Do not include py-ref.h.
11800         * varobj.c: Do not include py-ref.h.
11801
11802 2019-01-22  Tom Tromey  <tom@tromey.com>
11803
11804         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11805         keyword for bcache.
11806
11807 2019-01-22  Tom Tromey  <tom@tromey.com>
11808
11809         * compile/compile-cplus-types.c: Remove a comment by #include.
11810
11811 2019-01-22  Tom Tromey  <tom@tromey.com>
11812
11813         * compile/gcc-c-plugin.h: Include compile-internal.h.
11814
11815 2019-01-22  Tom Tromey  <tom@tromey.com>
11816
11817         * stabsread.c (EXTERN): Do not define.
11818         (symnum, next_symbol_text_func, processing_gcc_compilation)
11819         (within_function, global_sym_chain, global_stabs)
11820         (previous_stab_code, this_object_header_files)
11821         (n_this_object_header_files)
11822         (n_allocated_this_object_header_files): Define.
11823         * stabsread.h (EXTERN): Never define.  Use "extern".
11824
11825 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11826
11827         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11828         history_value.
11829
11830 2019-01-21  Tom Tromey  <tom@tromey.com>
11831
11832         * ui-out.c: Fix includes.
11833         * tui/tui-source.c: Fix includes.
11834         * target.c: Fix includes.
11835         * remote.c: Fix includes.
11836         * regcache.c: Fix includes.
11837         * python/py-block.c: Fix includes.
11838         * printcmd.c: Fix includes.
11839         * or1k-tdep.c: Fix includes.
11840         * mi/mi-main.c: Fix includes.
11841         * m32r-tdep.c: Fix includes.
11842         * csky-tdep.c: Fix includes.
11843         * compile/compile-cplus-types.c: Fix includes.
11844         * cli/cli-interp.c: Fix includes.
11845
11846 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11847
11848         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11849         for padding.
11850
11851 2019-01-16  Tom Tromey  <tom@tromey.com>
11852
11853         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11854         earlier.
11855         (struct objfile) <msymbols_range>: Move from top level.
11856         <msymbols>: New method.
11857         (class objfile_msymbols): Remove.
11858         * symtab.c (default_collect_symbol_completion_matches_break_on):
11859         Update.
11860         * symmisc.c (dump_msymbols): Update.
11861         * stabsread.c (scan_file_globals): Update.
11862         * objc-lang.c (info_selectors_command, info_classes_command)
11863         (find_methods): Update.
11864         * minsyms.c (find_solib_trampoline_target): Update.
11865         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11866         * coffread.c (coff_symfile_read): Update.
11867         * ada-lang.c (ada_lookup_simple_minsym)
11868         (ada_collect_symbol_completion_matches): Update.
11869
11870 2019-01-16  Tom Tromey  <tom@tromey.com>
11871
11872         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11873         type.  Remove no-argument constructor.
11874         <iterator::operator++>: Simplify.
11875         <begin>: Update.
11876         <end>: Use minimal_symbol_count.
11877
11878 2019-01-16  Tom Tromey  <tom@tromey.com>
11879
11880         * objfiles.h (struct objfile) <psymtabs>: New method.
11881         (class objfile_psymtabs): Remove.
11882         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11883         typedef.
11884         <range>: New method.
11885         (require_partial_symbols): Change return type.
11886         * psymtab.c (require_partial_symbols)
11887         (psym_expand_symtabs_matching): Update.
11888         * mdebugread.c (parse_partial_symbols): Update.
11889         * dbxread.c (dbx_end_psymtab): Update.
11890
11891 2019-01-15  Tom Tromey  <tom@tromey.com>
11892
11893         * symtab.c (lookup_objfile_from_block)
11894         (lookup_symbol_in_objfile_symtabs)
11895         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11896         (find_line_symtab, info_sources_command)
11897         (default_collect_symbol_completion_matches_break_on)
11898         (make_source_files_completion_list): Update.
11899         * symmisc.c (print_objfile_statistics, dump_objfile)
11900         (maintenance_print_symbols, maintenance_info_symtabs)
11901         (maintenance_check_symtabs, maintenance_info_line_tables):
11902         Update.
11903         * source.c (select_source_symtab)
11904         (forget_cached_source_info_for_objfile): Update.
11905         * objfiles.h (class objfile_compunits): Remove.
11906         (struct objfile) <compunits_range>: New typedef.
11907         (compunits): New method.
11908         * objfiles.c (objfile_relocate1): Update.
11909         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11910         * maint.c (count_symtabs_and_blocks): Update.
11911         * linespec.c (iterate_over_all_matching_symtabs): Update.
11912         * cp-support.c (add_symbol_overload_list_qualified): Update.
11913         * coffread.c (coff_symtab_read): Update.
11914         * ada-lang.c (add_nonlocal_symbols)
11915         (ada_collect_symbol_completion_matches)
11916         (ada_add_global_exceptions): Update.
11917
11918 2019-01-15  Tom Tromey  <tom@tromey.com>
11919
11920         * progspace.h (program_space) <objfiles_safe_range>: New
11921         typedef.
11922         <objfiles_safe>: New method.
11923         * objfiles.h (class all_objfiles_safe): Remove.
11924         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11925         * jit.c (jit_inferior_exit_hook): Update.
11926
11927 2019-01-17  Tom Tromey  <tom@tromey.com>
11928
11929         * progspace.h (program_space) <objfiles_range>: New typedef.
11930         <objfiles>: New method.
11931         <objfiles_head>: Rename from objfiles.
11932         (object_files): Update.
11933         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11934         * guile/scm-pretty-print.c
11935         (ppscm_find_pretty_printer_from_objfiles): Update.
11936         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11937         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11938         Update.
11939         * python/py-progspace.c (pspy_get_objfiles): Update.
11940         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11941         Update.
11942         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11943         (objfpy_lookup_objfile_by_build_id): Update.
11944         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11945         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11946         Update.
11947         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11948         (expand_symtab_containing_pc, lookup_objfile_from_block)
11949         (lookup_static_symbol, basic_lookup_transparent_type)
11950         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11951         (find_line_symtab, info_sources_command)
11952         (default_collect_symbol_completion_matches_break_on)
11953         (make_source_files_completion_list, find_main_name): Update.
11954         * symmisc.c (print_symbol_bcache_statistics)
11955         (print_objfile_statistics, maintenance_print_symbols)
11956         (maintenance_print_msymbols, maintenance_print_objfiles)
11957         (maintenance_info_symtabs, maintenance_check_symtabs)
11958         (maintenance_expand_symtabs, maintenance_info_line_tables):
11959         Update.
11960         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11961         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11962         (map_overlay_command, unmap_overlay_command)
11963         (simple_overlay_update, expand_symtabs_matching)
11964         (map_symbol_filenames): Update.
11965         * symfile-debug.c (set_debug_symfile): Update.
11966         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11967         Update.
11968         * source.c (select_source_symtab, forget_cached_source_info):
11969         Update.
11970         * solib.c (solib_read_symbols): Update.
11971         * solib-spu.c (append_ocl_sos): Update.
11972         * psymtab.c (maintenance_print_psymbols)
11973         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11974         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11975         * printcmd.c (info_symbol_command): Update.
11976         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11977         Update.
11978         * objfiles.h (class all_objfiles): Remove.
11979         * objfiles.c (have_partial_symbols, have_full_symbols)
11980         (have_minimal_symbols, qsort_cmp, update_section_map)
11981         (shared_objfile_contains_address_p)
11982         (default_iterate_over_objfiles_in_search_order): Update.
11983         * objc-lang.c (info_selectors_command, info_classes_command)
11984         (find_methods): Update.
11985         * minsyms.c (find_solib_trampoline_target): Update.
11986         * maint.c (maintenance_info_sections)
11987         (maintenance_translate_address, count_symtabs_and_blocks):
11988         Update.
11989         * main.c (captured_main_1): Update.
11990         * linux-thread-db.c (try_thread_db_load_from_pdir)
11991         (has_libpthread): Update.
11992         * linespec.c (iterate_over_all_matching_symtabs)
11993         (search_minsyms_for_name): Update.
11994         * jit.c (jit_find_objf_with_entry_addr): Update.
11995         * hppa-tdep.c (find_unwind_entry)
11996         (hppa_lookup_stub_minimal_symbol): Update.
11997         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11998         Update.
11999         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12000         (elf_gnu_ifunc_resolve_by_got): Update.
12001         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12002         * dwarf-index-write.c (save_gdb_index_command): Update.
12003         * cp-support.c (add_symbol_overload_list_qualified): Update.
12004         * breakpoint.c (create_overlay_event_breakpoint)
12005         (create_longjmp_master_breakpoint)
12006         (create_std_terminate_master_breakpoint)
12007         (create_exception_master_breakpoint): Update.
12008         * blockframe.c (find_pc_partial_function): Update.
12009         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12010         (ada_collect_symbol_completion_matches)
12011         (ada_add_global_exceptions): Update.
12012
12013 2019-01-17  Tom Tromey  <tom@tromey.com>
12014
12015         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12016         declare VEC.
12017         (solib_target_parse_libraries): Change return type.
12018         (library_list_start_segment, library_list_start_section)
12019         (library_list_end_library, library_list_start_library); Update.
12020         (solib_target_free_library_list): Remove.
12021         (solib_target_parse_libraries): Remove cleanup.  Change return
12022         type.
12023         (solib_target_current_sos): Update.
12024
12025 2019-01-17  Tom Tromey  <tromey@bapiya>
12026
12027         * valprint.c: Replace "the the" with "the".
12028         * symtab.c: Replace "the the" with "the".
12029         * solib.c: Replace "the the" with "the".
12030         * solib-dsbt.c: Replace "the the" with "the".
12031         * linespec.c: Replace "the the" with "the".
12032         * dwarf2loc.h: Replace "the the" with "the".
12033         * amd64-windows-tdep.c: Replace "the the" with "the".
12034         * aarch64-tdep.c: Replace "the the" with "the".
12035
12036 2019-01-16  Keith Seitz  <keiths@redhat.com>
12037
12038         PR gdb/23773
12039         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12040         <builder>: Rename to ..
12041         <m_builder>: ... this and make private.
12042         (dwarf2_cu::get_builder): New method.  Change all users of
12043         `builder' to use this method.
12044         (dwarf2_start_symtab): Move to ...
12045         (dwarf2_cu::start_symtab): ... here.  Update all callers
12046         (setup_type_unit_groups): Move to ...
12047         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12048         callers.
12049         (dwarf2_cu::reset_builder): New method.
12050         (process_full_compunit, process_full_type_unit): Use
12051         dwarf2_cu::reset_builder.
12052         (follow_die_offset): Record the ancestor CU if it is different
12053         from the followed DIE's CU.
12054         (follow_die_sig_1): Likewise.
12055
12056 2019-01-15  Tom Tromey  <tom@tromey.com>
12057
12058         * remote.c (class remote_state) <buf>: Now a char_vector.
12059         <buf_size>: Remove.
12060         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12061         parameter.
12062         (remote_target::getpkt_or_notif_sane_1)
12063         (remote_target::getpkt_sane)
12064         (remote_target::getpkt_or_notif_sane): Likewise.
12065         (class remote_target) <putpkt>: New overload.
12066         (remote_target::read_frame): Change type of "buf_p".  Remove
12067         sizeof_p parameter.
12068         (packet_ok): New overload.
12069         (packet_check_result): New overload.
12070         Update all uses.
12071
12072 2019-01-14  Tom Tromey  <tom@tromey.com>
12073
12074         * remote-notif.c (handle_notification, remote_notif_ack)
12075         (remote_notif_parse): Make "buf" const.
12076         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12077         const.
12078         (remote_notif_parse, remote_notif_ack, handle_notification):
12079         Likewise.
12080         * remote.c (remote_notif_stop_parse): Make "buf" const.
12081         (remote_target::remote_parse_stop_reply): Make "buf" const.
12082         (remote_notif_stop_ack): Make "buf" const.
12083
12084 2019-01-14  Tom Tromey  <tom@tromey.com>
12085
12086         * remote.c (remote_console_output): Make parameter const.
12087
12088 2019-01-14  Tom Tromey  <tom@tromey.com>
12089
12090         * target-debug.h (target_debug_print_signals): Constify.
12091         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12092         * procfs.c (procfs_target::pass_signals): Update.
12093         * linux-nat.c (linux_nat_target::pass_signals): Update.
12094         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12095         * target-delegates.c: Rebuild.
12096         * remote.c (remote_target::program_signals): Update.
12097         (remote_target::pass_signals): Update.
12098         * target.c (target_pass_signals): Constify argument.
12099         (target_program_signals): Likewise.
12100         * target.h (struct target_ops) <pass_signals, program_signals>:
12101         Constify argument.
12102         (target_pass_signals, target_program_signals): Constify argument.
12103
12104 2019-01-14  Tom Tromey  <tom@tromey.com>
12105
12106         PR tui/28819:
12107         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12108
12109 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12110
12111         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12112         field.
12113         * rs6000-tdep.c: Include reggroups.h.
12114         (IS_V_ALIAS_PSEUDOREG): Define.
12115         (rs6000_register_name): Return names for the "vX" aliases.
12116         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12117         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12118         aliases.  Call default_register_reggroup_p for all other
12119         pseudo-registers.
12120         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12121         New functions.
12122         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12123         Handle "vX" aliases.
12124         (v_alias_pseudo_register_collect): New function.
12125         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12126         (rs6000_gdbarch_init): Initialize "vX" aliases as
12127         pseudo-registers.  Restore registration of
12128         rs6000_pseudo_register_reggroup_p with
12129         set_tdesc_pseudo_register_reggroup_p.
12130
12131 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12132
12133         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12134         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12135         set_gdbarch_num_pseudo_regs.
12136
12137 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12138
12139         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12140         Remove arg prefixname, add do_set and do_show.
12141         Add member functions set_list and show_list.
12142         * cli/cli-style.c (class cli_style_option): Update accordingly.
12143         (style_set_list): Move to file scope.
12144         (style_show_list): Likewise.
12145         (set_style): Call help_list.
12146         (show_style): Call cmd_show_list.
12147         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12148         Update to use the new macro.
12149
12150 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12151
12152         * ada-lang.c (_initialize_ada_language): Expand the help text
12153         for the "catch exception" command.
12154
12155 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12156
12157         * symtab.c (matching_obj_sections): Initialize obj,
12158         declare it closer to its usage.
12159
12160 2019-01-10  Tom Tromey  <tom@tromey.com>
12161
12162         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12163         (basic_inf_threads_range): Remove.
12164         (inf_threads_range, inf_non_exited_threads_range)
12165         (safe_inf_threads_range): Use next_adapter.
12166
12167 2019-01-10  Keith Seitz  <keiths@redhat.com>
12168
12169         PR gdb/23712
12170         PR symtab/23010
12171         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12172         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12173
12174 2019-01-10  Keith Seitz  <keiths@redhat.com>
12175
12176         PR gdb/23712
12177         PR symtab/23010
12178         * dictionary.c (pending_to_vector): Remove.
12179         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12180         Remove _1 suffix, replacing functions of the same name.  Update
12181         all callers.
12182         (dict_create_hashed, dict_create_hashed_expandable)
12183         (dict_create_linear, dict_create_linear_expandable, dict_free)
12184         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12185         Make functions static.
12186
12187 2019-01-10  Keith Seitz  <keiths@redhat.com>
12188
12189         PR gdb/23712
12190         PR symtab/23010
12191         * dictionary.h (struct dictionary): Replace declaration with
12192         multidictionary.
12193         (dict_create_hashed, dict_create_hashed_expandable)
12194         (dict_create_linear, dict_create_linear_expandable)
12195         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12196         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12197         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12198         taking multidictionary argument.
12199         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12200         * block.h (struct block) <dict>: Change to multidictionary
12201         and rename `multidict'.
12202         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12203         symmisc.c: Update all dictionary references to multidictionary.
12204
12205 2019-01-10  Keith Seitz  <keiths@redhat.com>
12206
12207         PR gdb/23712
12208         PR symtab/23010
12209         * dictionary.c: Include unordered_map.
12210         (pending_to_vector): New function.
12211         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12212         Rewrite the non-"_1" functions to take vector instead
12213         of linked list.
12214         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12215         "new" _1 versions of the same name.
12216         (multidictionary): Define.
12217         (std::hash<enum language): New definition.
12218         (collate_pending_symbols_by_language, mdict_create_hashed)
12219         (mdict_create_hashed_expandable, mdict_create_linear)
12220         (mdict_create_linear_expandable, mdict_free)
12221         (find_language_dictionary, create_new_language_dictionary)
12222         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12223         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12224         (mdict_size, mdict_empty): New functions.
12225         * dictionary.h (mdict_iterator): Define.
12226
12227 2019-01-10  Pedro Alves  <palves@redhat.com>
12228
12229         * breakpoint.c (read_uploaded_action)
12230         (create_tracepoint_from_upload): Adjust to use
12231         gdb::unique_xmalloc_ptr.
12232         * ctf.c (ctf_write_uploaded_tp):
12233         (SET_ARRAY_FIELD): Use emplace_back.
12234         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12235         * tracefile-tfile.c (tfile_write_uploaded_tp):
12236         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12237         gdb::unique_xmalloc_ptr.
12238         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12239         at_string, cond_string, cmd_strings>: Replace char pointers
12240         with gdb::unique_xmalloc_ptr.
12241
12242 2019-01-10  Pedro Alves  <palves@redhat.com>
12243
12244         * solib-target.c (library_list_start_library): Don't xstrdup name.
12245
12246 2019-01-10  Pedro Alves  <palves@redhat.com>
12247
12248         * mdebugread.c (parse_partial_symbols): Use
12249         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12250
12251 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12252
12253         * linux-fork.c (scoped_switch_fork_info)
12254         <~scoped_switch_fork_info>: Fix incorrect variable name.
12255
12256 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12257
12258         * linux-fork.c (scoped_switch_fork_info)
12259         <scoped_switch_fork_info>: Make explicit.
12260         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12261
12262 2019-01-10  Tom Tromey  <tom@tromey.com>
12263
12264         * objfiles.h (objfile::reset_psymtabs): Update.
12265         * objfiles.c (objfile::objfile): Update.
12266         * psymtab.h (psymtab_storage::obstack): Update.
12267         (psymtab_storage::m_obstack): Use gdb::optional.
12268         (class psymtab_storage): Update comment.  Remove objfile
12269         parameter.
12270         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12271
12272 2019-01-10  Tom Tromey  <tom@tromey.com>
12273
12274         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12275         <free_psymtabs>: Now private.
12276         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12277         (allocate_psymtab): Use new method.
12278
12279 2019-01-10  Tom Tromey  <tom@tromey.com>
12280
12281         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12282         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12283         * mdebugread.c (parse_partial_symbols): Use
12284         allocate_dependencies.
12285         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12286         allocate_dependencies.
12287         (process_psymtab_comp_unit_reader)
12288         (build_type_psymtab_dependencies): Likewise.
12289         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12290
12291 2019-01-10  Tom Tromey  <tom@tromey.com>
12292
12293         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12294         PSYMBOL_SET_LANGUAGE.
12295         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12296
12297 2019-01-10  Tom Tromey  <tom@tromey.com>
12298
12299         * psymtab.h (psymtab_storage::obstack): New method.
12300         <m_obstack>: Rename from obstack; now private.
12301         * psymtab.c (psymtab_storage): Update.
12302         * dwarf2read.c (create_addrmap_from_index)
12303         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12304         Update.
12305
12306 2019-01-10  Tom Tromey  <tom@tromey.com>
12307
12308         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12309         * objfiles.h (objfile::reset_psymtabs): New method.
12310
12311 2019-01-10  Tom Tromey  <tom@tromey.com>
12312
12313         * symmisc.c (print_symbol_bcache_statistics): Update.
12314         (print_objfile_statistics): Update.
12315         * symfile.c (reread_symbols): Update.
12316         * psymtab.h (class psymtab_storage): New.
12317         * psymtab.c (psymtab_storage): New constructor.
12318         (~psymtab_storage): New destructor.
12319         (require_partial_symbols): Update.
12320         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12321         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12322         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12323         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12324         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12325         (start_psymtab_common, end_psymtab_common)
12326         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12327         (allocate_psymtab): Update.
12328         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12329         Update.
12330         (dump_psymtab_addrmap, maintenance_print_psymbols)
12331         (maintenance_check_psymtabs): Update.
12332         (class objfile_psymtabs): Move to objfiles.h.
12333         * psympriv.h (discard_psymtab): Now inline.
12334         (psymtab_discarder::psymtab_discarder): Update.
12335         (psymtab_discarder::~psymtab_discarder): Update.
12336         (ALL_OBJFILE_PSYMTABS): Rewrite.
12337         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12338         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12339         Remove fields.
12340         <partial_symtabs>: New field.
12341         (class objfile_psymtabs): Move from psymtab.h.  Update.
12342         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12343         psymbol_cache.
12344         (objfile::~objfile): Don't destroy psymbol_cache.
12345         * mdebugread.c (parse_partial_symbols): Update.
12346         * dwarf2read.c (create_addrmap_from_index)
12347         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12348         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12349         (add_partial_subprogram, dwarf2_ranges_read): Update.
12350         * dwarf-index-write.c (write_address_map)
12351         (write_one_signatured_type, recursively_write_psymbols)
12352         (class debug_names, class debug_names, write_psymtabs_to_index):
12353         Update.
12354
12355 2019-01-10  Tom Tromey  <tom@tromey.com>
12356
12357         * symtab.h (SYMBOL_SET_NAMES): Update.
12358         (symbol_set_names): Update.
12359         (MSYMBOL_SET_NAMES): Update.
12360         * symtab.c (symbol_set_names): Change argument to be an
12361         objfile_per_bfd_storage.
12362         * psymtab.c (add_psymbol_to_bcache): Update.
12363         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12364
12365 2019-01-10  Tom Tromey  <tom@tromey.com>
12366
12367         * symtab.c (create_demangled_names_hash): Change argument to be an
12368         objfile_per_bfd_storage.
12369         (symbol_set_names): Update.
12370
12371 2019-01-10  Tom Tromey  <tom@tromey.com>
12372
12373         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12374         init_psymbol_list.
12375         * psymtab.c (init_psymbol_list): Do nothing if already called.
12376         * psympriv.h (init_psymbol_list): Add comment.
12377         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12378         init_psymbol_list.
12379         * dbxread.c (dbx_symfile_read): Unconditionally call
12380         init_psymbol_list.
12381
12382 2019-01-10  Tom Tromey  <tom@tromey.com>
12383
12384         * xcoffread.c (scan_xcoff_symtab): Update.
12385         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12386         "where".
12387         * mdebugread.c (parse_partial_symbols)
12388         (handle_psymbol_enumerators): Update.
12389         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12390         * dbxread.c (read_dbx_symtab): Update.
12391         * psympriv.h (psymbol_placement): New enum.
12392         (add_psymbol_to_list): Update.
12393
12394 2019-01-10  Tom Tromey  <tom@tromey.com>
12395
12396         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12397         static_psymbols parameters.
12398         (scan_xcoff_symtab): Update.
12399         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12400         static_psymbols parameters.
12401         * psympriv.h (start_psymtab_common): Update.
12402         * mdebugread.c (parse_partial_symbols): Update.
12403         * dwarf2read.c (create_partial_symtab): Update.
12404         * dbxread.c (read_dbx_symtab): Update.
12405         (start_psymtab): Remove global_psymbols and static_psymbols
12406         parameters.
12407
12408 2019-01-10  Tom Tromey  <tom@tromey.com>
12409
12410         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12411         * psymtab.c (allocate_psymtab): Add comment.
12412         * psympriv.h (allocate_psymtab): Add comment.
12413         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12414         initializations.
12415         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12416
12417 2019-01-10  Tom Tromey  <tom@tromey.com>
12418
12419         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12420         Don't declare.
12421         * mipsread.c: Include mdebugread.h.
12422         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12423         Declare.
12424         * elfread.c: Include mdebugread.h.
12425
12426 2019-01-09  Tom Tromey  <tom@tromey.com>
12427
12428         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12429         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12430         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12431         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12432         (psym_lookup_symbol, psym_find_last_source_symtab)
12433         (psym_forget_cached_source_info, psym_print_stats)
12434         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12435         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12436         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12437         (psym_find_compunit_symtab_by_address)
12438         (maintenance_print_psymbols, maintenance_info_psymtabs)
12439         (maintenance_check_psymtabs): Use ranged for.
12440         * psymtab.h (class objfile_psymtabs): New.
12441         (require_partial_symbols): Return objfile_psymtabs.
12442         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12443
12444 2019-01-09  Tom Tromey  <tom@tromey.com>
12445
12446         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12447         (find_pc_mapped_section, list_overlays_command)
12448         (map_overlay_command, unmap_overlay_command)
12449         (simple_overlay_update): Use all_objfiles.
12450         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12451         * printcmd.c (info_symbol_command): Use all_objfiles.
12452         * objfiles.h (ALL_OBJSECTIONS): Remove.
12453         * maint.c (maintenance_translate_address): Use all_objfiles.
12454         * gcore.c (gcore_create_callback): Use all_objfiles.
12455         (objfile_find_memory_regions): Likewise.
12456
12457 2019-01-09  Tom Tromey  <tom@tromey.com>
12458
12459         * symtab.c (find_line_symtab, info_sources_command)
12460         (make_source_files_completion_list): Use objfile_compunits.
12461         * source.c (select_source_symtab): Use objfile_compunits.
12462         * objfiles.h (struct objfile): Update comment.
12463         (ALL_OBJFILES): Remove.
12464         (ALL_FILETABS): Remove.
12465         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12466         objfile_compunits.
12467
12468 2019-01-09  Tom Tromey  <tom@tromey.com>
12469
12470         * symmisc.c (print_objfile_statistics, dump_objfile)
12471         (maintenance_print_symbols): Use compunit_filetabs.
12472         * source.c (forget_cached_source_info_for_objfile): Use
12473         compunit_filetabs.
12474         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12475         (ALL_FILETABS): Use compunit_filetabs.
12476         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12477         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12478
12479 2019-01-09  Tom Tromey  <tom@tromey.com>
12480
12481         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12482         (compunit_filetabs): New.
12483         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12484         compunit_filetabs.
12485         (info_sources_command, make_source_files_completion_list): Remove
12486         declaration.
12487         * symmisc.c (print_objfile_statistics, dump_objfile)
12488         (maintenance_print_symbols): Remove declaration.
12489         (maintenance_info_symtabs): Use compunit_filetabs.
12490         (maintenance_info_line_tables): Likewise.
12491         * source.c (select_source_symtab): Change local variable name.
12492         (forget_cached_source_info_for_objfile): Remove declaration.
12493         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12494         * objfiles.c (objfile_relocate1): Remove declaration.
12495         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12496         declaration.
12497         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12498         * coffread.c (coff_symtab_read): Remove declaration.
12499         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12500         compunit_filetabs.
12501
12502 2019-01-09  Tom Tromey  <tom@tromey.com>
12503
12504         * symtab.c (lookup_objfile_from_block)
12505         (find_pc_sect_compunit_symtab, search_symbols)
12506         (default_collect_symbol_completion_matches_break_on): Use
12507         objfile_compunits.
12508         * objfiles.h (ALL_COMPUNITS): Remove.
12509         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12510         * cp-support.c (add_symbol_overload_list_qualified): Use
12511         objfile_compunits.
12512         * ada-lang.c (ada_collect_symbol_completion_matches)
12513         (ada_add_global_exceptions): Use objfile_compunits.
12514
12515 2019-01-09  Tom Tromey  <tom@tromey.com>
12516
12517         * source.c (select_source_symtab)
12518         (forget_cached_source_info_for_objfile): Remove declaration.
12519         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12520         declaration.
12521         * maint.c (count_symtabs_and_blocks): Remove declaration.
12522         * cp-support.c (add_symbol_overload_list_qualified): Remove
12523         declaration.
12524         * coffread.c (coff_symtab_read): Remove declaration.
12525         * symtab.c (lookup_symbol_in_objfile_symtabs)
12526         (basic_lookup_transparent_type_1): Use objfile_compunits.
12527         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12528         (info_sources_command, search_symbols)
12529         (default_collect_symbol_completion_matches_break_on)
12530         (make_source_files_completion_list): Remove declaration.
12531         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12532         (ada_collect_symbol_completion_matches)
12533         (ada_add_global_exceptions): Remove declaration.
12534         * linespec.c (iterate_over_all_matching_symtabs): Use
12535         objfile_compunits.
12536         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12537         (class objfile_compunits): New.
12538         (ALL_COMPUNITS): Use objfile_compunits.
12539         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12540         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12541         objfile_compunits.
12542         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12543
12544 2019-01-09  Tom Tromey  <tom@tromey.com>
12545
12546         * symtab.c (search_symbols)
12547         (default_collect_symbol_completion_matches_break_on): Use
12548         objfile_msymbols.
12549         * ada-lang.c (ada_lookup_simple_minsym)
12550         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12551         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12552         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12553         objfile_msymbols.
12554         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12555         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12556         * objc-lang.c (find_methods): Use objfile_msymbols.
12557         (info_selectors_command, info_classes_command): Likewise.
12558         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12559         * objfiles.h (class objfile_msymbols): New.
12560         (ALL_OBJFILE_MSYMBOLS): Remove.
12561         (ALL_MSYMBOLS): Remove.
12562
12563 2019-01-09  Tom Tromey  <tom@tromey.com>
12564
12565         * common/next-iterator.h (next_adapter): Add Iterator template
12566         parameter.
12567         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12568         (class all_objfiles_safe): New.
12569         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12570         * objfiles.c (put_objfile_before): Update comment.
12571         (add_separate_debug_objfile): Likewise.
12572         (free_all_objfiles): Use all_objfiles_safe.
12573         (objfile_purge_solibs): Likewise.
12574
12575 2019-01-09  Tom Tromey  <tom@tromey.com>
12576
12577         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12578         (expand_symtab_containing_pc, lookup_static_symbol)
12579         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12580         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12581         all_objfiles.
12582         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12583         * breakpoint.c (create_overlay_event_breakpoint)
12584         (create_longjmp_master_breakpoint)
12585         (create_std_terminate_master_breakpoint)
12586         (create_exception_master_breakpoint): Use all_objfiles.
12587         * linux-thread-db.c (try_thread_db_load_from_pdir)
12588         (has_libpthread): Use all_objfiles.
12589         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12590         * linespec.c (iterate_over_all_matching_symtabs)
12591         (search_minsyms_for_name): Use all_objfiles.
12592         * maint.c (maintenance_info_sections): Use all_objfiles.
12593         * main.c (captured_main_1): Use all_objfiles.
12594         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12595         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12596         * guile/scm-pretty-print.c
12597         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12598         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12599         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12600         (maintenance_print_msymbols): Use all_objfiles.
12601         * source.c (select_source_symtab): Use all_objfiles.
12602         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12603         * symfile.c (remove_symbol_file_command)
12604         (expand_symtabs_matching, map_symbol_filenames): Use
12605         all_objfiles.
12606         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12607         all_objfiles.
12608         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12609         * objc-lang.c (find_methods): Use all_objfiles.
12610         * objfiles.c (have_partial_symbols, have_full_symbols)
12611         (have_minimal_symbols, qsort_cmp)
12612         (default_iterate_over_objfiles_in_search_order): Use
12613         all_objfiles.
12614         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12615         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12616         (maintenance_check_psymtabs): Use all_objfiles.
12617         (ALL_PSYMTABS): Remove.
12618         * compile/compile-object-run.c (do_module_cleanup): Use
12619         all_objfiles.
12620         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12621         * cp-support.c (add_symbol_overload_list_qualified): Use
12622         all_objfiles.
12623         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12624         Use all_objfiles.
12625         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12626         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12627         all_objfiles.
12628         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12629         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12630         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12631         Uses all_objfiles.
12632         * solib.c (solib_read_symbols): Use all_objfiles
12633
12634 2019-01-09  Tom Tromey  <tom@tromey.com>
12635
12636         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12637         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12638         all_objfiles.
12639         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12640         * symmisc.c (print_symbol_bcache_statistics)
12641         (print_objfile_statistics, maintenance_print_objfiles)
12642         (maintenance_info_symtabs, maintenance_check_symtabs)
12643         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12644         all_objfiles.
12645         * source.c (forget_cached_source_info): Use all_objfiles.
12646         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12647         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12648         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12649         * objfiles.c (update_section_map): Use all_objfiles.
12650         (shared_objfile_contains_address_p): Likewise.
12651         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12652         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12653
12654 2019-01-09  Tom Tromey  <tom@tromey.com>
12655
12656         * common/next-iterator.h: New file.
12657         * objfiles.h (class all_objfiles): New.
12658         (struct objfile_iterator): New.
12659
12660 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12661
12662         * NEWS: Move the description of the changed "frame", "select-frame",
12663          and "info frame" commands to the Changed commands section.
12664
12665 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12666
12667         * gdbtypes.c (check_stub_method_group): Remove handling of old
12668         mangling schemes.
12669         * linespec.c (find_methods): Likewise.
12670         * stabsread.c (read_member_functions): Likewise.
12671         * valops.c (search_struct_method): Likewise.
12672         (value_struct_elt_for_reference): Likewise.
12673         * NEWS: Mention this change.
12674
12675 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12676
12677         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12678         print_source_lines.
12679         * source.c (print_source_lines_base): Update line number check.
12680         (print_source_lines): New function.
12681         (source_lines_range::source_lines_range): New function.
12682         * source.h (class source_lines_range): New class.
12683         (print_source_lines): New declaration.
12684
12685 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12686
12687         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12688
12689 2019-01-08  Tom Tromey  <tom@tromey.com>
12690             Simon Marchi  <simon.marchi@ericsson.com>
12691
12692         PR gdb/24060
12693         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12694         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12695         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12696         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12697         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12698         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12699
12700 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12701
12702         * source.c (select_source_symtab): Move header comment to
12703         declaration in source.h.
12704         (forget_cached_source_info_for_objfile): Likewise.
12705         (forget_cached_source_info): Likewise.
12706         (identify_source_line): Likewise.
12707         * source.h (identify_source_line): Move declaration from symtab.h
12708         and add comment from source.c
12709         (print_source_lines): Likewise.
12710         (forget_cached_source_info_for_objfile): Likewise.
12711         (forget_cached_source_info): Likewise.
12712         (select_source_symtab): Likewise.
12713         (enum print_source_lines_flag): Move definition from symtab.h.
12714         * symtab.h (identify_source_line): Move declaration to source.h.
12715         (print_source_lines): Likewise.
12716         (forget_cached_source_info_for_objfile): Likewise.
12717         (forget_cached_source_info): Likewise.
12718         (select_source_symtab): Likewise.
12719         (enum print_source_lines_flag): Move definition to source.h.
12720         * tui/tui-hooks.c: Add 'source.h' include.
12721
12722 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12723
12724         * source.c (print_source_lines_base): Handle requests to print
12725         reverse line number sequences, and guard against empty lines
12726         string.
12727
12728 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12729
12730         * source.c (print_source_lines_base): Fix skip of '\r' if next
12731         character is '\n'.
12732
12733 2019-01-06  Tom Tromey  <tom@tromey.com>
12734
12735         * c-exp.y (struct c_parse_state) <macro_original_text,
12736         expansion_obstack>: New member.
12737         (macro_original_text, expansion_obstack): Remove globals.
12738         (scan_macro_expansion, scanning_macro_expansion)
12739         (finished_macro_expansion): Update.
12740         (scan_macro_cleanup): Remove.
12741         (yylex, c_parse): Update.
12742
12743 2019-01-06  Tom Tromey  <tom@tromey.com>
12744
12745         * c-exp.y (struct c_parse_state) <strings>: New member.
12746         (operator_stoken): Update.
12747
12748 2019-01-06  Tom Tromey  <tom@tromey.com>
12749
12750         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12751         (union type_stack_elt) <typelist_val>: Now a pointer to
12752         std::vector.
12753         (type_stack_cleanup): Don't declare.
12754         (push_typelist): Update.
12755         * parse.c (pop_typelist): Return a std::vector.
12756         (push_typelist): Take a std::vector.
12757         (follow_types): Update.  Do not free args.
12758         (type_stack_cleanup): Remove.
12759         * c-exp.y (struct c_parse_state): New.
12760         (cpstate): New global.
12761         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12762         (nonempty_typelist): Update.
12763         (func_mod): Create a new vector.
12764         (c_parse): Create a c_parse_state.
12765         (check_parameter_typelist): Do not delete params.
12766         (function_method): Update.  Do not delete type_list.
12767
12768 2019-01-06  Tom Tromey  <tom@tromey.com>
12769
12770         PR gdb/28155:
12771         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12772         check_typedef.
12773         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12774         (print_return_value): Likewise.
12775
12776 2019-01-05  Tom Tromey  <tom@tromey.com>
12777
12778         * contrib/cleanup_check.py: Remove.
12779         * contrib/gcc-with-excheck: Remove.
12780         * contrib/exsummary.py: Remove.
12781         * contrib/excheck.py: Remove.
12782
12783 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12784
12785         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12786         NULL. Initialize tpprev to NULL instead of assigning it
12787         to NULL on the next statement.
12788         * windows-nat.c (windows_delete_thread): Remove check for
12789         main_thread_id before printing thread exit notifications.
12790         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12791         Remove thread ID check against main_thread_id.
12792         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12793         windows_delete_thread.
12794         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12795
12796 2019-01-04  Tom Tromey  <tom@tromey.com>
12797
12798         * compile/compile.c (_initialize_compile): Use upper case for
12799         metasyntactic variables.
12800         * symmisc.c (_initialize_symmisc): Use upper case for
12801         metasyntactic variables.
12802         * psymtab.c (_initialize_psymtab): Use upper case for
12803         metasyntactic variables.
12804         * demangle.c (demangle_command): Use upper case for metasyntactic
12805         variables.
12806         (_initialize_demangler): Likewise.
12807         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12808         variables.
12809
12810 2019-01-03  Tom Tromey  <tom@tromey.com>
12811
12812         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12813
12814 2019-01-03  Tom Tromey  <tom@tromey.com>
12815
12816         * python/py-symtab.c (salpy_str): Update.
12817         (struct salpy_sal_object) <symtab>: Now a PyObject.
12818         (salpy_dealloc): Update.
12819         (del_objfile_sal): Use gdbpy_ref.
12820
12821 2019-01-03  Tom Tromey  <tom@tromey.com>
12822
12823         * python/py-type.c (convert_field): Use new_reference.  Return
12824         gdbpy_ref.
12825         (make_fielditem): Return gdbpy_ref.
12826         (typy_fields): Update.
12827         (typy_getitem): Update.
12828         (field_name): Return gdbpy_ref.  Use new_reference.
12829         (typy_iterator_iternext): Update.
12830
12831 2019-01-03  Tom Tromey  <tom@tromey.com>
12832
12833         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12834
12835 2019-01-03  Tom Tromey  <tom@tromey.com>
12836
12837         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12838         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12839         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12840         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12841         (pspy_set_type_printers): Likewise.
12842         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12843         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12844         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12845         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12846         (objfpy_set_type_printers): Likewise.
12847
12848 2019-01-03  Tom Tromey  <tom@tromey.com>
12849
12850         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12851         (gdbpy_print_stack): Use gdbpy_err_fetch.
12852         * python/python-internal.h (class gdbpy_err_fetch): New class.
12853         (class gdbpy_enter) <m_error_type, m_error_value,
12854         m_error_traceback>: Remove.
12855         <m_error>: New member.
12856         (gdbpy_exception_to_string): Don't declare.
12857         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12858         * python/py-value.c (convert_value_from_python): Use
12859         gdbpy_err_fetch.
12860         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12861         gdbpy_exception_to_string.
12862         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12863         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12864         gdbpy_err_fetch.
12865
12866 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12867
12868         * linux-nat.c (delete_lwp_cleanup): Delete.
12869         (struct lwp_deleter): New struct.
12870         (lwp_info_up): New typedef.
12871         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12872         lwp_info_up.
12873
12874 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12875
12876         * linux-fork.c (class scoped_switch_fork_info): New class.
12877         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12878
12879 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12880
12881         * valops.c (find_overload_match): Remove use of null_cleanup, and
12882         calls to do_cleanups.
12883
12884 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12885
12886         * compile/compile-cplus-types.c
12887         (compile_cplus_instance::decl_name): Handle changes to
12888         cp_func_name.
12889         * cp-support.c (cp_func_name): Update header comment, update
12890         return type.
12891         * cp-support.h (cp_func_name): Update return type in declaration.
12892         * valops.c (find_overload_match): Move temp_func local to top
12893         level of function and change its type.  Use temp_func to hold and
12894         delete temporary string obtained from cp_func_name.
12895
12896 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12897
12898         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12899         gdb::char_vector, remove cleanup, and update uses of `msg`.
12900
12901 2019-01-03  Jim Wilson  <jimw@sifive.com>
12902
12903         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12904
12905 2019-01-02  Tom Tromey  <tom@tromey.com>
12906
12907         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12908         (tdesc_parse_xml): Remove cleanups.
12909         * target-descriptions.h (make_cleanup_free_target_description):
12910         Don't declare.
12911         (target_desc_deleter): New struct.
12912         (target_desc_up): New typedef.
12913         * target-descriptions.c (target_desc_deleter::operator()): Rename
12914         from free_target_description.
12915         (make_cleanup_free_target_description): Remove.
12916
12917 2019-01-02  Tom Tromey  <tom@tromey.com>
12918
12919         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12920         constructor, destructor.
12921         (linespec_parser): Remove typedef.
12922         (~linespec_parser): Rename from linespec_parser_delete.
12923         (linespec_lex_to_end, linespec_complete_label)
12924         (linespec_complete): Update.
12925         (decode_line_full): Remove cleanups.
12926         (decode_line_1): Update.
12927
12928 2019-01-02  Tom Tromey  <tom@tromey.com>
12929
12930         * python/python-internal.h (inferior_to_inferior_object): Change
12931         return type.
12932         * python/py-exitedevent.c (create_exited_event_object): Update.
12933         * python/py-inferior.c (inferior_to_inferior_object): Return
12934         gdbpy_ref.
12935         (python_new_inferior, python_inferior_deleted)
12936         (thread_to_thread_object, delete_thread_object)
12937         (build_inferior_list, gdbpy_selected_inferior): Update.
12938         * python/py-infthread.c (create_thread_object): Update.  Also fail
12939         if inferior_to_inferior_object fails.
12940
12941 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12942
12943         * inferior.h (class inferior) <displaced_step_state>: New field.
12944         * infrun.h (struct displaced_step_state): Move here from
12945         infrun.c.  Initialize fields, add constructor.
12946         <inf>: Remove field.
12947         <reset>: New method.
12948         * infrun.c (struct displaced_step_inferior_state): Move to
12949         infrun.h.
12950         (displaced_step_inferior_states): Remove.
12951         (get_displaced_stepping_state): Adust.
12952         (displaced_step_in_progress_any_inferior): Adjust.
12953         (displaced_step_in_progress_thread): Adjust.
12954         (displaced_step_in_progress): Adjust.
12955         (add_displaced_stepping_state): Remove.
12956         (get_displaced_step_closure_by_addr): Adjust.
12957         (remove_displaced_stepping_state): Remove.
12958         (infrun_inferior_exit): Call displaced_step_state.reset.
12959         (use_displaced_stepping): Don't check for NULL.
12960         (displaced_step_prepare_throw): Call
12961         get_displaced_stepping_state.
12962         (displaced_step_fixup): Don't check for NULL.
12963         (prepare_for_detach): Don't check for NULL.
12964
12965 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12966
12967         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12968          in case of call that did not complete.
12969
12970 2019-01-02  Andrey Utkin  <autkin@undo.io>
12971
12972         * symfile.c (find_separate_debug_file): Fix search of debug files for
12973         remote debuggee.
12974
12975 2019-01-02  Tom Tromey  <tom@tromey.com>
12976
12977         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12978         indentation.
12979         * python/py-frame.c (frapy_older): Remove cast.
12980         (frapy_newer): Likewise.
12981         * python/py-breakpoint.c (local_setattro): Remove cast.
12982         * python/py-arch.c (archpy_name): Remove local variable.
12983         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12984
12985 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12986
12987         * unittests/basic_string_view/element_access/char/empty.cc:
12988         Fix year range in copyright header.
12989
12990 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12991
12992         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12993         Delete.
12994         <operator==>: Update with for removed field.
12995         <hash>: Likewise.
12996         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12997         <isa_features>: ...this.
12998         <abi_features>: New field.
12999         (riscv_isa_flen): Update comment.
13000         (riscv_abi_xlen): New declaration.
13001         (riscv_abi_flen): New declaration.
13002         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13003         isa_features.
13004         (riscv_abi_xlen): New function.
13005         (riscv_isa_flen): Update to get answer from isa_features.
13006         (riscv_abi_flen): New function.
13007         (riscv_has_fp_abi): Update to get answer from abi_features.
13008         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13009         xlen and flen.
13010         (riscv_call_info) <xlen, flen>: Update comment.
13011         (riscv_call_arg_struct): Remove invalid assertions
13012         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13013         is removed.
13014         (riscv_gdbarch_init): Gather isa features and abi features
13015         separately, ensure both match on the gdbarch when reusing an old
13016         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13017         a target with 64-bit float hardware.
13018
13019 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13020
13021         * source.c (search_command_helper): Stop reverse search
13022         when line 1 has been searched.
13023
13024 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13025
13026         * record-full.c (record_full_base_target::close): Rewrite
13027         record_full_core_buf_list free logic.
13028
13029 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13030
13031         * break-catch-syscall.c (print_one_catch_syscall): xfree
13032         the last text.
13033
13034 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13035
13036         * top.c (print_gdb_version): Update Copyright year in version
13037         message.
13038
13039 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13040
13041         Update copyright year range in all GDB files.
13042
13043 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13044
13045         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13046
13047 For older changes see ChangeLog-2018.
13048 \f
13049 Local Variables:
13050 mode: change-log
13051 left-margin: 8
13052 fill-column: 74
13053 version-control: never
13054 coding: utf-8
13055 End:
13056