gdb/ChangeLog

   1 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
   4         field.
   5         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
   6         use.
   7         (arm_record_special_symbol): Don't insert new symbol in sorted
   8         position, push it at the end.
   9
  10 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  11
  12         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
  13         (arm_mapping_symbol_s): Remove.
  14         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
  15         (arm_mapping_symbol_vec): New typedef.
  16         (struct arm_per_objfile): Add constructor.
  17         <section_maps>: Change type to
  18         std::unique_ptr<arm_mapping_symbol_vec[]>.
  19         (arm_compare_mapping_symbols): Remove.
  20         (arm_find_mapping_symbol): Adjust to section_maps type change.
  21         (arm_objfile_data_free): Call delete on arm_per_objfile.
  22         (arm_record_special_symbol): Adjust to section_maps type change.
  23         Allocate arm_per_objfile with new.
  24
  25 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  26
  27         * cli/cli-cmds.c (alias_command): Compare the alias prefix
  28         with the command prefix.
  29
  30 2019-06-25  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
  33         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
  34
  35 2019-06-25  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
  38         type.
  39         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
  40         protected.
  41
  42 2019-06-25  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-winsource.c
  45         (tui_source_window_base::set_is_exec_point_at): Add check against
  46         LOA_ADDRESS.
  47
  48 2019-06-25  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-source.c (tui_set_source_content): Don't check before
  51         xfree.
  52         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
  53
  54 2019-06-25  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-winsource.h (tui_update_source_window_as_is)
  57         (tui_alloc_source_buffer, tui_line_is_displayed)
  58         (tui_addr_is_displayed): Change type of win_info.
  59         * tui/tui-winsource.c (tui_update_source_window_as_is)
  60         (tui_clear_source_content, tui_show_source_line)
  61         (tui_show_source_content, tui_source_window_base::refill)
  62         (tui_source_window_base::set_is_exec_point_at)
  63         (tui_source_window_base::set_is_exec_point_at)
  64         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
  65         (tui_alloc_source_buffer, tui_line_is_displayed)
  66         (tui_addr_is_displayed): Change type of win_info.  Update.
  67         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  68         (tui_source_window_base::do_make_visible_with_new_height):
  69         Update.
  70         * tui/tui-source.c (tui_set_source_content)
  71         (tui_set_source_content_nil)
  72         (tui_source_window::do_scroll_vertical): Update.
  73         * tui/tui-layout.c (show_layout): Update.
  74         * tui/tui-disasm.c (tui_set_disassem_content)
  75         (tui_disasm_window::do_scroll_vertical): Update.
  76         * tui/tui-data.h (tui_win_content): Remove.
  77         (struct tui_gen_win_info) <content, content_size>: Remove.
  78         (struct tui_source_element): Add initializers and destructor.
  79         (union tui_which_element, struct tui_win_element): Remove.
  80         (struct tui_source_window_base) <content>: New field.
  81         (struct tui_data_window): Remove destructor.
  82         (tui_alloc_content, tui_free_win_content)
  83         (tui_free_all_source_wins_content): Don't declare.
  84         * tui/tui-data.c (tui_initialize_static_data): Update.
  85         (init_content_element, tui_alloc_content): Remove.
  86         (~tui_gen_win_info): Update.
  87         (~tui_data_window, tui_free_all_source_wins_content)
  88         (tui_free_win_content, free_content, free_content_elements):
  89         Remove.
  90
  91 2019-06-25  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-winsource.h (tui_clear_source_content)
  94         (tui_erase_source_content, tui_show_source_content): Change type
  95         of win_info.
  96         * tui/tui-winsource.c (tui_clear_source_content)
  97         (tui_erase_source_content, tui_show_source_content): Change type
  98         of win_info.
  99         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 100         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 101         win_info.
 102         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 103         win_info.
 104         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 105
 106 2019-06-25  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-winsource.c (tui_clear_source_content)
 109         (tui_source_window_base::set_is_exec_point_at): Update.
 110         * tui/tui-source.c (tui_set_source_content_nil): Update.
 111         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 112         a bool.
 113         * tui/tui-data.c (init_content_element): Update.
 114
 115 2019-06-25  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 118         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 119         * tui/tui-layout.c (init_and_make_win): Update.
 120         * tui/tui.h (enum tui_win_type): Update.
 121         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 122         tui_win_is_auxillary.
 123         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 124         tui_win_is_auxillary.
 125
 126 2019-06-25  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 129         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 130         (tui_delete_data_content_windows, tui_display_all_data)
 131         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 132         Update.
 133         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 134         * tui/tui-regs.c (tui_last_regs_line_no)
 135         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 136         (tui_show_registers): Update.
 137         (tui_show_register_group): Return void.  Update.
 138         (tui_display_registers_from, tui_display_reg_element_at_line)
 139         (tui_display_registers_from_line, tui_check_register_values):
 140         Update.
 141         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 142         member.
 143         (struct tui_data_window) <regs_content>: Now a std::vector.
 144         <regs_content_count>: Remove.
 145         (tui_add_content_elements, tui_free_data_content): Don't declare.
 146         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 147         (init_content_element): Remove DATA_WIN case.  Add assert.
 148         (tui_add_content_elements): Remove.
 149         (tui_data_window): Update.
 150         (tui_free_data_content): Remove.
 151         (free_content_elements): Remove DATA_WIN case.
 152
 153 2019-06-25  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-data.c (tui_data_item_window): Update.
 156         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 157         * tui/tui-windata.c (tui_display_all_data)
 158         (tui_display_data_from_line): Update.
 159         (tui_check_data_values): Remove.
 160         * tui/tui-regs.c (tui_show_register_group)
 161         (tui_display_reg_element_at_line): Update.
 162         * tui/tui-hooks.c (tui_register_changed)
 163         (tui_refresh_frame_and_register_information): Call
 164         tui_check_register_values.
 165         * tui/tui-data.h (struct tui_data_window) <data_content,
 166         data_content_count, data_type>: Remove.
 167         (enum tui_data_type): Remove.
 168
 169         * tui/tui-data.c (tui_data_window::clear_detail)
 170         (~tui_data_window): Update.
 171
 172 2019-06-25  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 175         declare.
 176         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 177         Rename from tui_first_data_item_displayed.  Update.
 178         (tui_data_window::refresh_all)
 179         (tui_data_window::do_scroll_vertical): Update.
 180         * tui/tui-data.h (struct tui_data_window)
 181         <first_data_item_displayed>: Declare new method.
 182
 183 2019-06-25  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 186         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 187         contents...
 188         (tui_initialize_static_data): ...here.
 189
 190 2019-06-25  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 193         (tui_display_registers_from, tui_check_register_values): Update.
 194         (tui_display_register): Remove win_info parameter; update.
 195         (tui_get_register): Change type of parameters.
 196         * tui/tui-data.h (struct tui_data_element): Remove.
 197         (union tui_which_element) <data>: Remove.
 198         <data_window>: Change type.
 199         (struct tui_data_item_window): New.
 200         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 201         case.  Add assert.
 202         (~tui_data_item_window): New destructor.
 203         (free_content_elements): Remove DATA_ITEM_WIN case.
 204
 205 2019-06-25  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 208         Remove.
 209
 210 2019-06-25  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-data.h (struct tui_command_element): Remove.
 213         (union tui_which_element) <command>: Remove.
 214         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 215         assert.
 216         (free_content_elements): Remove CMD_WIN case.
 217
 218 2019-06-25  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-layout.c (tui_set_layout): Update.
 221         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 222         * tui/tui-data.c (layout_def): Update.
 223
 224 2019-06-25  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 227         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 228         (tui_source_window_base::set_new_height): Update.
 229         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 230         Update.
 231         (tui_set_locator_fullname, tui_set_locator_info)
 232         (tui_show_frame_info): Update.
 233         * tui/tui-source.c (tui_set_source_content)
 234         (tui_source_is_displayed): Update.
 235         * tui/tui-layout.c (show_source_disasm_command, show_data)
 236         (show_source_or_disasm_and_command): Update.
 237         * tui/tui-disasm.c (tui_set_disassem_content)
 238         (tui_get_begin_asm_address): Update.
 239         * tui/tui-data.h (struct tui_locator_element): Remove.
 240         (union tui_which_element) <locator>: Remove.
 241         (struct tui_locator_window): New.
 242         (tui_locator_win_info_ptr): Change return type.
 243         * tui/tui-data.c (_locator): Change type.
 244         (tui_locator_win_info_ptr): Change return type.
 245         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 246         (tui_alloc_content): Add assert.
 247
 248 2019-06-25  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-winsource.c
 251         (tui_exec_info_window::maybe_allocate_content): New method.
 252         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 253         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 254         (make_source_or_disasm_window): Add cast.
 255         * tui/tui-data.h (union tui_which_element) <simple_string>:
 256         Remove.
 257         (struct tui_source_info): New.
 258         (struct tui_source_window_base) <execution_info>: Change type.
 259         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 260         case, and add assert.
 261         (tui_alloc_content): Add assert.
 262
 263 2019-06-25  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 266         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 267         * tui/tui-data.c (tui_alloc_win_info): Remove.
 268
 269 2019-06-25  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 272         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 273         can_highlight.
 274
 275 2019-06-25  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 278         make_visible_with_new_height method.
 279         (tui_win_info::make_visible_with_new_height): New method.
 280         (tui_source_window_base::do_make_visible_with_new_height)
 281         (tui_data_window::do_make_visible_with_new_height)
 282         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 283         (make_visible_with_new_height): Remove.
 284         (tui_resize_all, tui_adjust_win_heights): Use
 285         make_visible_with_new_height method.
 286         * tui/tui-data.h (struct tui_win_info)
 287         <do_make_visible_with_new_height, make_visible_with_new_height>:
 288         New methods.
 289         (struct tui_source_window_base, struct tui_data_window)
 290         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 291         methods.
 292
 293 2019-06-25  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 296         method.
 297         (update_tab_width): Call update_tab_width method.
 298         * tui/tui-data.h (struct tui_win_info)
 299         (struct tui_source_window_base) <update_tab_width>: New methods.
 300
 301 2019-06-25  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 304         parameter.
 305         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 306         parameter.
 307         (tui_gen_win_info::make_visible): Update.
 308         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 309         parameter.
 310         * tui/tui-data.h (enum tui_box): New enum.
 311         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 312
 313 2019-06-25  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 316         init_and_make_win for EXEC_INFO_WIN.
 317         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 318         longer inline.
 319         (struct tui_win_info) <~tui_win_info>: Inline.
 320         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 321         Don't declare.
 322         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 323         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 324         Remove.
 325         (tui_initialize_static_data): Update.
 326         (~tui_gen_win_info): Handle more cleanup here.
 327         (~tui_source_window_base): Delete "execution_info".
 328         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 329
 330 2019-06-25  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-layout.c (make_command_window): Don't set
 333         can_highlight.
 334         (show_source_disasm_command): Call the reset method.
 335         (show_data): Don't set can_highlight.  Call the reset method.
 336         (tui_gen_win_info::reset): Rename from init_gen_win_info
 337         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 338         (show_source_or_disasm_and_command): Call the reset method.
 339         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 340         (struct tui_cmd_window): Set can_highlight.
 341
 342 2019-06-25  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 345         from make_visible.
 346         (tui_make_visible, tui_make_invisible): Rewrite.
 347         (tui_win_info::make_visible): Remove.
 348         (tui_source_window_base::make_visible): Update.
 349         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 350         method.  Moved from...
 351         (struct tui_win_info) <make_visible>: ...here.
 352
 353 2019-06-25  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-winsource.c
 356         (tui_source_window_base::do_scroll_horizontal): Remove direction
 357         parameter.
 358         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 359         direction parameter.
 360         * tui/tui-win.c (tui_win_info::forward_scroll)
 361         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 362         (tui_win_info::right_scroll): Update.
 363         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 364         direction parameter.
 365         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 366         direction parameter.
 367         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 368         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 369         Remove direction parameter.
 370         (struct tui_source_window_base, struct tui_source_window)
 371         (struct tui_disasm_window, struct tui_data_window)
 372         (struct tui_cmd_window): Update.
 373
 374 2019-06-25  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-winsource.h (tui_set_exec_info_content)
 377         (tui_show_exec_info_content, tui_erase_exec_info_content)
 378         (tui_clear_exec_info_content, tui_update_exec_info): Change
 379         argument to tui_source_window_base.
 380         * tui/tui-winsource.c (tui_set_exec_info_content)
 381         (tui_show_exec_info_content, tui_erase_exec_info_content)
 382         (tui_clear_exec_info_content, tui_update_exec_info): Change
 383         argument to tui_source_window_base.
 384
 385 2019-06-25  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 388         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 389
 390 2019-06-25  Tom Tromey  <tom@tromey.com>
 391
 392         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 393         check.
 394
 395 2019-06-25  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 398         type to void.
 399         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 400         type to void.
 401         * tui/tui-source.c (tui_set_source_content): Update.
 402         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 403
 404 2019-06-25  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-win.c (window_name_completer, tui_set_focus)
 407         (tui_all_windows_info): Use name method.
 408         * tui/tui-data.h (struct tui_gen_win_info)
 409         (struct tui_source_window, struct tui_disasm_window)
 410         (struct tui_data_window, struct tui_cmd_window) <name>: New
 411         method.
 412         (tui_win_name): Don't declare.
 413         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 414         (tui_win_name): Remove.
 415
 416 2019-06-25  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-winsource.h (tui_update_source_window)
 419         (tui_update_source_window_as_is): Change parameter type.
 420         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 421         to be a tui_source_window_base.
 422         (tui_update_source_window_as_is): Likewise.
 423         * tui/tui-win.c (make_visible_with_new_height): Update.
 424
 425 2019-06-25  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-winsource.c (tui_erase_source_content)
 428         (tui_show_source_content, tui_show_exec_info_content)
 429         (tui_erase_exec_info_content): Use refresh_window method.
 430         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 431         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 432         from tui_refresh_win.
 433         (tui_data_window::refresh_window): New method.
 434         (tui_win_info::refresh, tui_source_window_base::refresh)
 435         (tui_refresh_all): Use refresh_window method.
 436         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 437         method.
 438         * tui/tui-regs.c (tui_display_register): Call refresh_window
 439         method.
 440         * tui/tui-layout.c (show_source_disasm_command)
 441         (show_source_or_disasm_and_command): Call refresh_window method.
 442         * tui/tui-data.h (struct tui_gen_win_info)
 443         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 444         New method.
 445
 446 2019-06-25  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui.c (tui_rl_other_window, tui_enable)
 449         (tui_is_window_visible, tui_get_command_dimension): Update.
 450         * tui/tui-winsource.c (tui_update_source_window_as_is)
 451         (tui_clear_source_content, tui_erase_source_content)
 452         (tui_show_source_line, tui_source_window_base::refill)
 453         (tui_source_window_base::do_scroll_horizontal)
 454         (tui_source_window_base::set_is_exec_point_at)
 455         (tui_update_breakpoint_info, tui_set_exec_info_content)
 456         (tui_alloc_source_buffer, tui_line_is_displayed)
 457         (tui_addr_is_displayed): Update.
 458         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 459         (tui_check_and_display_highlight_if_needed)
 460         (tui_win_info::make_visible, tui_win_info::refresh)
 461         (tui_refresh_all): Update.
 462         * tui/tui-windata.c (tui_first_data_item_displayed)
 463         (tui_delete_data_content_windows, tui_erase_data_content)
 464         (tui_display_all_data, tui_data_window::refresh_all)
 465         (tui_check_data_values): Update.
 466         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 467         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 468         (tui_win_info::backward_scroll, tui_refresh_all_win)
 469         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 470         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 471         (tui_source_window_base::set_new_height)
 472         (tui_data_window::set_new_height)
 473         (make_invisible_and_set_new_height)
 474         (make_visible_with_new_height, new_height_ok)
 475         (parse_scrolling_args): Update.
 476         * tui/tui-stack.c (tui_show_frame_info): Update.
 477         * tui/tui-source.c (tui_set_source_content)
 478         (tui_set_source_content_nil, tui_source_is_displayed)
 479         (tui_source_window::do_scroll_vertical): Update.
 480         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 481         (tui_display_registers_from, tui_display_reg_element_at_line)
 482         (tui_check_register_values, tui_reg_command): Update.
 483         * tui/tui-layout.c (tui_default_win_height)
 484         (show_source_disasm_command, show_data, init_and_make_win)
 485         (show_source_or_disasm_and_command): Update.
 486         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 487         (tui_redisplay_readline, tui_mld_flush)
 488         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 489         (tui_getc): Update.
 490         * tui/tui-disasm.c (tui_set_disassem_content)
 491         (tui_disasm_window::do_scroll_vertical): Update.
 492         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 493         Now virtual.
 494         (struct tui_win_info): Derive from tui_gen_win_info.
 495         <~tui_win_info>: Mark as override.
 496         <generic>: Remove member.
 497         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 498         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 499         (~tui_data_window, ~tui_win_info)
 500         (tui_free_all_source_wins_content): Update.
 501         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 502
 503 2019-06-25  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-layout.c (init_and_make_win): Use new.
 506         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 507         destructor, initializers.
 508         (tui_alloc_generic_win_info): Don't declare.
 509         * tui/tui-data.c (_locator): Add argument to constructor.
 510         (source_win, disasm_win): New globals.
 511         (exec_info): Remove.
 512         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 513         Update.
 514         (tui_alloc_generic_win_info): Remove.
 515         (init_content_element): Use new.
 516         (tui_win_info::tui_win_info): Update.
 517         (free_content_elements) <case DATA_WIN>: Use delete.
 518
 519 2019-06-25  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 522         * tui/tui-windata.c (tui_first_data_item_displayed)
 523         (tui_delete_data_content_windows): Update.
 524         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 525         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 526         (tui_display_registers_from, tui_check_register_values): Update.
 527         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 528         pointer.
 529         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 530         window.
 531         (tui_free_data_content): Update.
 532         (free_content_elements) <case DATA_WIN>: Free the window.
 533
 534 2019-06-25  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 537         Update.
 538         * tui/tui-layout.c (make_command_window)
 539         (show_source_disasm_command, show_data, init_and_make_win)
 540         (show_source_or_disasm_and_command): Update.
 541         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 542         method.
 543         <can_highight, is_highlighted>: Now bool.
 544         (tui_set_win_highlight): Don't declare.
 545         * tui/tui-data.c (tui_set_win_highlight): Remove.
 546
 547 2019-06-25  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-wingeneral.c (make_visible): Remove check of window
 550         type.
 551
 552 2019-06-25  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-win.c (tui_win_info::max_height)
 555         (tui_cmd_window::max_height): New methods.
 556         (new_height_ok): Call max_height.
 557         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 558         <max_height>: New method.
 559
 560 2019-06-25  Tom Tromey  <tom@tromey.com>
 561
 562         * tui/tui-win.c (tui_source_window_base::set_new_height)
 563         (tui_data_window::set_new_height): New methods.
 564         (make_invisible_and_set_new_height): Call set_new_height method.
 565         * tui/tui-data.h (struct tui_win_info)
 566         (struct tui_source_window_base, struct tui_data_window)
 567         <set_new_height>: New method.
 568
 569 2019-06-25  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 572         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 573         tui_refresh_data_win.
 574         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 575         method.
 576         (tui_refresh_all_win): Call the refresh_all method.
 577         (tui_set_focus): Likewise.
 578         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 579         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 580         Likewise.
 581
 582 2019-06-25  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-winsource.h (tui_refill_source_window)
 585         (tui_set_is_exec_point_at): Don't declare.
 586         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 587         (tui_source_window_base::refill): Rename from
 588         tui_refill_source_window.
 589         (tui_source_window_base::do_scroll_horizontal): Update.
 590         (tui_source_window_base::set_is_exec_point_at): Rename from
 591         tui_set_is_exec_point_at.
 592         (tui_update_all_breakpoint_info): Update.
 593         * tui/tui-stack.c (tui_show_frame_info): Update.
 594         * tui/tui-layout.c (show_data): Add cast.
 595         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 596         * tui/tui-data.h (struct tui_source_window_base) <refill,
 597         set_is_exec_point_at>: New methods.
 598         (tui_source_windows, tui_add_to_source_windows): Update types.
 599         (tui_add_to_source_windows): Remove redundant declaration.
 600         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 601         (tui_source_windows): Change return type.
 602         (tui_clear_source_windows_detail): Update.
 603         (tui_add_to_source_windows): Change type of parameter.
 604         (tui_free_all_source_wins_content): Update.
 605
 606 2019-06-25  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-wingeneral.c (tui_win_info::refresh)
 609         (tui_source_window_base::refresh): New methods.
 610         (tui_refresh_all): Call the refresh method.
 611         * tui/tui-data.h (struct tui_win_info)
 612         (struct tui_source_window_base) <refresh>: New method.
 613
 614 2019-06-25  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui.h (tui_is_window_visible): Return bool.
 617         * tui/tui.c (tui_is_window_visible): Return bool.
 618         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 619         (tui_make_visible, tui_make_invisible)
 620         (tui_win_info::make_visible)
 621         (tui_source_window_base::make_visible, make_all_visible)
 622         (tui_make_all_visible, tui_make_all_invisible): Update.
 623         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 624         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 625         bool.
 626         (struct tui_win_info, struct tui_source_window_base)
 627         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 628         * tui/tui-data.c (tui_init_generic_part): Update.
 629
 630 2019-06-25  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 633         (tui_source_window_base::make_visible): New methods.
 634         (make_all_visible): Make method call.
 635         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 636         (struct tui_source_window_base, struct tui_cmd_window): Override
 637         make_visible.
 638         (tui_win_is_source_type): Don't declare.
 639         * tui/tui-data.c (tui_win_is_source_type): Remove.
 640
 641 2019-06-25  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 644         NULL check.
 645
 646 2019-06-25  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 649         Inline constructor.  Add initializers for members.
 650         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 651         constructors; now inline in class.
 652
 653 2019-06-25  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-regs.c (tui_show_registers): Update.
 656         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 657         bool.
 658         * tui/tui-data.c (tui_data_window::clear_detail)
 659         (tui_data_window): Update.
 660
 661 2019-06-25  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-windata.c (tui_display_all_data)
 664         (tui_display_data_from_line, tui_display_data_from)
 665         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 666         Update.
 667         * tui/tui-regs.c (tui_last_regs_line_no)
 668         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 669         (tui_show_registers, tui_show_register_group)
 670         (tui_display_registers_from, tui_display_reg_element_at_line)
 671         (tui_display_registers_from_line, tui_check_register_values)
 672         (tui_reg_next, tui_reg_prev): Update.
 673         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 674         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 675         tui_data_window.
 676         (struct tui_win_info) <detail>: Remove.  Add new fields from
 677         tui_data_info.
 678         (TUI_DATA_WIN): Add cast.
 679         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 680         (~tui_data_window): Simplify.
 681
 682 2019-06-25  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-layout.c (show_source_disasm_command)
 685         (show_source_or_disasm_and_command): Update.
 686         * tui/tui-io.c (update_cmdwin_start_line)
 687         (tui_redisplay_readline): Update.
 688         * tui/tui-data.h (struct tui_command_info): Remove.
 689         (struct tui_win_info) <detail>: Remove command_info member.
 690         (struct tui_data_window) <start_line>: New member, from
 691         tui_command_info.
 692         (TUI_CMD_WIN): Add casts.
 693
 694 2019-06-25  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-winsource.c (tui_update_source_window)
 697         (tui_refill_source_window)
 698         (tui_source_window_base::do_scroll_horizontal)
 699         (tui_update_breakpoint_info, tui_set_exec_info_content)
 700         (tui_show_exec_info_content, tui_erase_exec_info_content)
 701         (tui_clear_exec_info_content): Update.
 702         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 703         Update.
 704         * tui/tui-win.c (make_invisible_and_set_new_height)
 705         (make_visible_with_new_height): Update.
 706         * tui/tui-source.c (tui_set_source_content)
 707         (tui_show_symtab_source): Update.
 708         * tui/tui-layout.c (extract_display_start_addr)
 709         (show_source_disasm_command, show_data)
 710         (make_source_or_disasm_window)
 711         (show_source_or_disasm_and_command): Update.
 712         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 713         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 714         "gdbarch".
 715         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 716         to tui_source_window_base.
 717         (struct tui_win_info) <detail>: Remove source_info member.
 718         (struct tui_source_window_base) <has_locator>: Inline.
 719         Move contents from tui_source_info; rename has_locator member to
 720         m_has_locator.
 721         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 722         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 723         header file.
 724         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 725         Simplify.
 726         (tui_free_all_source_wins_content): Cast to
 727         tui_source_window_base.
 728
 729 2019-06-25  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-win.c (make_invisible_and_set_new_height)
 732         (make_visible_with_new_height): Call has_locator method.
 733         * tui/tui-layout.c (show_source_disasm_command, show_data)
 734         (show_source_or_disasm_and_command): Update for bool change.
 735         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 736         (tui_win_info) <has_locator>: New method.
 737         (struct tui_source_window_base) <has_locator>: New method.
 738         (tui_win_has_locator): Don't declare.
 739         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 740         from tui_win_has_locator.
 741         (tui_source_window_base): Use false, not FALSE.
 742
 743 2019-06-25  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 746         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 747         clear_detail method directly.
 748         (tui_clear_win_detail): Remove.
 749
 750 2019-06-25  Tom Tromey  <tom@tromey.com>
 751
 752         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 753         "this", not TUI_DISASM_WIN.
 754
 755 2019-06-25  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 758         declare.
 759         * tui/tui-winsource.c
 760         (tui_source_window_base::do_scroll_horizontal): Rename from
 761         tui_horizontal_source_scroll.
 762         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 763         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 764         from tui_vertical_data_scroll.
 765         * tui/tui-win.h (tui_scroll): Don't declare.
 766         * tui/tui-win.c (tui_win_info::forward_scroll)
 767         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 768         (tui_win_info::right_scroll): Rename and update.
 769         (tui_scroll_forward_command, tui_scroll_backward_command)
 770         (tui_scroll_left_command, tui_scroll_right_command): Update.
 771         (tui_scroll): Remove.
 772         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 773         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 774         from tui_vertical_source_scroll.
 775         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 776         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 777         from tui_vertical_disassem_scroll.
 778         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 779         do_scroll_horizontal>: New methods.
 780         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 781         Likewise.
 782         (struct tui_source_window_base): Add do_scroll_horizontal.
 783         (struct tui_source_window, struct tui_disasm_window): Add
 784         do_scroll_vertical.
 785         (struct tui_data_window, struct tui_cmd_window): Add
 786         do_scroll_horizontal and do_scroll_vertical.
 787         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 788
 789 2019-06-25  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-data.h (struct tui_source_window_base): New struct.
 792         (struct tui_source_window): Derive from tui_source_window_base.
 793         (struct tui_disasm_window): New struct.
 794         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 795         from tui_source_window::clear_detail.
 796         (tui_source_window_base): Rename from tui_source_window.
 797         (~tui_source_window_base): Rename from ~tui_source_window.
 798         (tui_alloc_win_info): Create a tui_disasm_window.
 799
 800 2019-06-25  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-data.h (struct tui_source_window)
 803         (struct tui_data_window): Declare destructors.
 804         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 805         destructors.
 806         (tui_win_info): Simplify.
 807
 808 2019-06-25  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui-winsource.c (tui_display_main)
 811         (tui_update_source_windows_with_addr)
 812         (tui_update_all_breakpoint_info): Update.
 813         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 814         (new_height_ok, parse_scrolling_args): Update.
 815         * tui/tui-stack.c (tui_show_frame_info): Update.
 816         * tui/tui-data.h (struct tui_list): Remove.
 817         (tui_source_windows): Return a reference to a std::vector.
 818         * tui/tui-data.c (source_windows): Now a std::vector.
 819         (tui_source_windows): Change return type.
 820         (tui_clear_source_windows): Rewrite.
 821         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 822         (tui_free_all_source_wins_content): Rewrite.
 823
 824 2019-06-25  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 827         (struct tui_data_window, struct tui_cmd_window): Declare
 828         clear_detail method.
 829         * tui/tui-data.c (tui_source_window::clear_detail)
 830         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 831         methods.
 832         (tui_clear_win_detail): Simplify.
 833
 834 2019-06-25  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-layout.c (make_source_window, make_disasm_window)
 837         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 838         Return the new window.
 839         (show_source_disasm_command, show_data)
 840         (show_source_or_disasm_and_command): Update.
 841
 842 2019-06-25  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 845         parameter.  Return the new window.
 846         (show_source_disasm_command): Update and remove NULL check.
 847         (show_source_or_disasm_and_command): Update.
 848
 849 2019-06-25  Tom Tromey  <tom@tromey.com>
 850
 851         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 852
 853 2019-06-25  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-data.h (struct tui_win_info): Make constructor
 856         protected.  Make destructor virtual.  Add initializers.
 857         (tui_source_window, tui_data_window, tui_cmd_window): New
 858         classes.
 859         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 860         constructor.  Add "type" parameter.
 861         (tui_source_window, tui_data_window, tui_cmd_window): New
 862         constructors.
 863         (tui_alloc_win_info): Instantiate the appropriate subclass.
 864
 865 2019-06-25  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-win.c (tui_resize_all): Use delete.
 868         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 869         destructor.
 870         (tui_free_window): Don't declare.
 871         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 872         Update.
 873
 874 2019-06-25  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-data.h (struct tui_win_info): Add constructor.
 877         * tui/tui-data.c (tui_alloc_win_info): Use new.
 878         (tui_free_window): Use delete.
 879
 880 2019-06-22  Tom Tromey  <tom@tromey.com>
 881
 882         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 883         declare.
 884         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 885
 886 2019-06-22  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 889         declare.
 890         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 891
 892 2019-06-22  Tom de Vries  <tdevries@suse.de>
 893
 894         * dwarf2read.c (create_addrmap_from_aranges)
 895         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 896         instead of '%zu'.
 897
 898 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 899
 900         * dwarf2read.h (dwarf2_section_info_def): Remove.
 901         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 902         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 903         std::vector<dwarf2_section_info>.
 904         (struct dwo_file) <~dwo_file>: Remove.
 905         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 906         types field.
 907         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 908         (dwarf2_read_debug_names): Likewise.
 909         (create_debug_types_hash_table): Change parameter type to
 910         array_view, adjust code accordingly.
 911         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 912         (partial_die_info::fixup): Likewise.
 913         (determine_prefix): Likewise.
 914         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 915
 916 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 917
 918         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 919         gdb_bfd_ref_ptr.
 920         <~dwo_file>: Remove call to gdb_bfd_unref.
 921         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 922         gdb_bfd_ref_ptr::get.
 923
 924 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 925
 926         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 927         type to htab_up.
 928         * dwarf2read.c (struct dwo_file): Initialize fields.
 929         <~dwo_file>: New.
 930         (free_dwo_file): Remove, move content to ~dwo_file.
 931         (struct dwo_file_deleter): Remove.
 932         (dwo_file_up>: Remove custom deleter.
 933         (free_dwo_files): Remove.
 934         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 935         dwo_files.
 936         (process_skeletonless_type_units): Call unique_ptr::get.
 937         (allocate_dwo_file_hash_table): Add deleter to created hash
 938         table.  Change return type to htab_up.
 939         (lookup_dwo_file_slot): Don't memset dwo_file, call
 940         unique_ptr::get.
 941         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 942         (create_dwo_unit_in_dwp_v2): Likewise.
 943         (open_and_init_dwo_file): Likewise.
 944         (free_dwo_file_from_slot): Remove.
 945
 946 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 947
 948         * dwarf2read.h (struct dwarf2_section_info) <readin,
 949         is_virtual>: Change type to bool.
 950         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 951         true instead of 1.
 952
 953 2019-06-19  Tom Tromey  <tom@tromey.com>
 954
 955         * tui/tui-data.h (tui_init_content_element): Don't declare.
 956
 957 2019-06-19  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-data.h (tui_init_win_info): Don't declare.
 960
 961 2019-06-19  Tom de Vries  <tdevries@suse.de>
 962
 963         * dwarf2read.h (abstract_to_concrete): Change type to
 964         std::unordered_map<sect_offset, std::vector<sect_offset>,
 965         gdb::hash_enum<sect_offset>>.
 966
 967 2019-06-19  Tom Tromey  <tromey@adacore.com>
 968
 969         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 970         EVAL_AVOID_SIDE_EFFECTS specially.
 971
 972 2019-06-19  Tom Tromey  <tromey@adacore.com>
 973
 974         * source-cache.c (highlighter): New global.
 975         (source_cache::get_source_lines): Create a highlighter on demand.
 976
 977 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 978
 979         * defs.h (deprecated_interactive_hook): Delete declaration.
 980         * interps.c (clear_interpreter_hooks): Remove use of
 981         deprecated_interactive_hook.
 982         * top.c (deprecated_interactive_hook): Delete definition.
 983         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 984
 985 2019-06-18  Tom de Vries  <tdevries@suse.de>
 986
 987         PR gdb/24515
 988         * dwarf2read.h (abstract_to_concrete): Change type from
 989         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 990         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 991         * dwarf2read.c (read_variable): Update.
 992         (dwarf2_fetch_die_loc_sect_off): Update.
 993
 994 2019-06-17  Tom de Vries  <tdevries@suse.de>
 995
 996         PR gdb/24617
 997         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 998         accessing parent[parent_len - 1].
 999
1000 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1001
1002         PR gdb/24364
1003         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1004         call dtrace_process_dof with NULL dof.
1005
1006 2019-06-16  Tom de Vries  <tdevries@suse.de>
1007
1008         PR gdb/24445
1009         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1010
1011 2019-06-16  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1014         (make_all_visible): Use address of member.
1015
1016 2019-06-16  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1019         (tui_free_window, free_content, free_content_elements): Remove
1020         unnecessary cast.
1021         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1022         cast.
1023         * tui/tui-regs.c (tui_show_register_group)
1024         (tui_display_registers_from, tui_display_reg_element_at_line):
1025         Remove unnecessary cast.
1026
1027 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1028
1029         * linux-nat.c (normal_mask): Delete.
1030         (_initialize_linux_nat): Don't initialise normal_mask.
1031
1032 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1033
1034         PR gdb/24445
1035         * dwarf-index-write.h (write_psymtabs_to_index): Add
1036         dwz_basename parameter.
1037         * dwarf-index-write.c (write_gdbindex): Move file writing to
1038         write_gdbindex_1.  Change return type void.
1039         (assert_file_size): Move up, remove filename parameter.
1040         (write_gdbindex_1): New function.
1041         (write_debug_names): Change return type to void, call
1042         assert_file_size.
1043         (struct index_wip_file): New struct.
1044         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1045         file logic to index_wip_file.  Write index for dwz file if
1046         needed.
1047         (save_gdb_index_command): Pass basename of dwz file, if present.
1048         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1049         build-id of dwz file, if present.
1050         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1051         (dwarf2_get_dwz_file): Likewise.
1052         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1053         (dwarf2_get_dwz_file): Likewise.
1054
1055 2019-06-16  Tom Tromey  <tom@tromey.com>
1056
1057         * coffread.c (process_coff_symbol): Use xstrdup.
1058         * value.c (create_internalvar): Use xstrdup.
1059
1060 2019-06-16  Tom Tromey  <tom@tromey.com>
1061
1062         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1063         * breakpoint.c (stopin_command, stopat_command)
1064         (until_break_command, decode_location_default): Remove unnecessary
1065         cast.
1066         * utils.c (subset_compare): Remove unnecessary cast.
1067         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1068         cast.
1069         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1070         cast.
1071         * infcmd.c (path_command): Remove unnecessary cast.
1072         * coffread.c (decode_type): Remove unnecessary cast.
1073         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1074         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1075         * tui/tui-stack.c (tui_show_locator_content)
1076         (tui_show_frame_info): Remove unnecessary cast.
1077         * tui/tui-win.c (tui_scroll_forward_command)
1078         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1079         (parse_scrolling_args): Remove unnecessary cast.
1080         * tui/tui-data.c (init_win_info, tui_del_window)
1081         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1082         (free_content_elements): Remove unnecessary cast.
1083         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1084         unnecessary cast.
1085         * tui/tui-source.c (tui_set_source_content)
1086         (tui_vertical_source_scroll): Remove unnecessary cast.
1087         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1088         cast.
1089         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1090         * tui/tui-regs.c (tui_display_registers_from)
1091         (tui_display_register): Remove unnecessary cast.
1092         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1093         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1094         (make_visible): Remove unnecessary cast.
1095         * tui/tui-winsource.c (tui_erase_source_content)
1096         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1097         unnecessary cast.
1098         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1099         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1100         * stabsread.c (read_type, read_array_type, read_range_type):
1101         Remove unnecessary cast.
1102         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1103         (parse_symbol, parse_type, upgrade_type, parse_external)
1104         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1105         unnecessary cast.
1106         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1107
1108 2019-06-16  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-data.c (tui_alloc_generic_win_info)
1111         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1112         checks.
1113
1114 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1115             Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * f-typeprint.c (f_print_type): Don't return early for not
1118         associated or not allocated types.
1119         (f_type_print_varspec_suffix): Add print_rank parameter and print
1120         ranks of array types in case they dangling.
1121         (f_type_print_base): Add print_rank parameter.
1122
1123 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * NEWS: Mention new MI commands.
1126         * break-catch-throw.c (enum exception_event_kind): Move to
1127         breakpoint.h.
1128         (print_mention_exception_catchpoint): Output text as a single
1129         message.
1130         (catch_exception_command_1): Rename to...
1131         (catch_exception_event): ...this, make non-static, update header
1132         command, and change some parameter types.
1133         (catch_catch_command): Update for changes to
1134         catch_exception_command_1.
1135         (catch_throw_command): Likewise.
1136         (catch_rethrow_command): Likewise.
1137         * breakpoint.c (enum exception_event_kind): Delete.
1138         * breakpoint.h (enum exception_event_kind): Moved here from
1139         break-catch-throw.c.
1140         (catch_exception_event): Declare.
1141         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1142         (mi_cmd_catch_throw): New function.
1143         (mi_cmd_catch_rethrow): New function.
1144         (mi_cmd_catch_catch): New function.
1145         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1146         'catch-catch' entries.
1147         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1148         (mi_cmd_catch_rethrow): Declare.
1149         (mi_cmd_catch_catch): Declare.
1150
1151 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         * annotate.c (annotate_source_line): Change return type to void,
1154         update implementation to match.
1155         * annotate.h (annotate_source_line): Change return type to void,
1156         update header comment.
1157         * stack.c (print_frame_info): Don't change what frame information
1158         is printed based on whether annotations are on or not.
1159
1160 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1161
1162         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1163         (annotate_source): Make static.
1164         (annotate_source_line): Moved from source.c and renamed from
1165         identify_source_line.  Update the return type.
1166         * annotate.h (annotate_source): Delete declaration.
1167         (annotate_source_line): Declaration moved from source.h, and
1168         renamed from identify_source_line.  Return type updated.
1169         * source.c (identify_source_line): Moved to annotate.c and renamed
1170         to annotate_source_line.
1171         (info_line_command): Remove check of annotation_level.
1172         * source.h (identify_source_line): Move declaration to annotate.h
1173         and rename to annotate_source_line.
1174         * stack.c: Add 'annotate.h' include.
1175         (print_frame_info): Remove check of annotation_level before
1176         calling annotate_source_line.
1177
1178 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1179
1180         * source-cache.c (source_cache::get_plain_source_lines): Use
1181         open_source_file_with_line_charpos instead of just
1182         open_source_file, remove call to find_source_lines.
1183         (source_cache::get_source_lines): Likewise.
1184         * source.c (find_source_lines): Make static.
1185         (get_filename_and_charpos): Renamed into...
1186         (open_source_file_with_line_charpos): ..this along with changes to
1187         return a scoped_fd, and some other minor clean ups.
1188         (identify_source_line): Use open_source_file_with_line_charpos.
1189         (search_command_helper): Use open_source_file_with_line_charpos
1190         instead of just open_source_file, remove call to
1191         find_source_lines.
1192         * source.h (open_source_file_with_line_charpos): Declare new
1193         function.
1194         (find_source_lines): Delete declaration.
1195
1196 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1197
1198         * source.c (get_filename_and_charpos): Remove fullname
1199         parameter.
1200         (identify_source_line): Update call to get_filename_and_charpos.
1201
1202 2019-06-14  Tom Tromey  <tromey@adacore.com>
1203
1204         PR gdb/24502:
1205         * ui-style.h (skip_ansi_escape): Update comment.
1206         * ui-file.h (class no_terminal_escape_file): New class.
1207         * ui-file.c (no_terminal_escape_file::write)
1208         (no_terminal_escape_file::puts): New methods.
1209         * cli/cli-logging.c (handle_redirections): Use
1210         no_terminal_escape_file.
1211
1212 2019-06-14  Tom Tromey  <tromey@adacore.com>
1213
1214         * NEWS: Move convenience variable news above Python news.
1215
1216 2019-06-14  Tom Tromey  <tom@tromey.com>
1217
1218         * gnulib: Move directory to top-level.
1219         * configure.ac: Don't configure gnulib.
1220         * configure: Rebuild.
1221         * common/common-defs.h: Use new path to gnulib.
1222         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1223         (GNULIB_H): Remove.
1224         (INCGNU): Look in new gnulib location.
1225         (HFILES_NO_SRCDIR): Remove gnulib files.
1226         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1227         (generated_files): Remove GNULIB_H.
1228         ($(LIBGNU), all-lib): Remove targets.
1229         (distclean): Don't mention GNULIB_BUILDDIR.
1230         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1231
1232 2019-06-14  Tom Tromey  <tromey@adacore.com>
1233
1234         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1235         Warn if symbol file does not provide any symbols.
1236
1237 2019-06-14  Tom Tromey  <tromey@adacore.com>
1238
1239         * source.c (find_and_open_source): Respect basenames_may_differ.
1240
1241 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * annotate.c (annotate_breakpoints_invalid): Make use of
1244         scoped_restore_terminal_state.
1245         (annotate_frames_invalid): Likewise.
1246
1247 2019-06-14  Tom Tromey  <tromey@adacore.com>
1248
1249         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1250         allow assignment to an internalvar.
1251
1252 2019-06-14  Tom Tromey  <tromey@adacore.com>
1253
1254         * ada-lex.l: Allow "_" in attribute names.
1255
1256 2019-06-14  Tom Tromey  <tromey@adacore.com>
1257
1258         PR gdb/24653:
1259         * regcache.c (registers_changed): Don't call alloca.
1260         * top.c (execute_command): Don't call alloca.
1261
1262 2019-06-13  Pedro Alves  <palves@redhat.com>
1263
1264         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1265         'expression'.  When parsing an expression, error out if there's
1266         junk after "unlimited".
1267         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1268         (do_set_command): Adjust calls to is_unlimited_literal.
1269
1270 2019-06-13  Pedro Alves  <palves@redhat.com>
1271
1272         * compile/compile.c (make_compile_options_def_group): Add braces
1273         around array_view initializer.
1274         * thread.c (make_thread_apply_all_options_def_group)
1275         (make_thread_apply_all_options_def_group): Likewise.
1276
1277 2019-06-13  Pedro Alves  <palves@redhat.com>
1278
1279         * NEWS (New commands): Mention "maint test-options
1280         require-delimiter", "maint test-options unknown-is-error", "maint
1281         test-options unknown-is-operand" and "maint show
1282         test-options-completion-result".
1283         (New command options, command completion): New section.
1284         (Completion improvements): New section.
1285         Mention that you can abbreviate "unlimited".
1286
1287 2019-06-13  Pedro Alves  <palves@redhat.com>
1288
1289         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1290         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1291         * unittests/cli-utils-selftests.c (test_parse_flags)
1292         (test_parse_flags_qcs): Delete.
1293         (test_cli_utils): Don't call deleted functions.
1294
1295 2019-06-13  Pedro Alves  <palves@redhat.com>
1296
1297         * thread.c: Include "cli/cli-option.h".
1298         (tp_array_compar_ascending): Global.
1299         (tp_array_compar): Delete function.
1300         (tp_array_compar_ascending, tp_array_compar_descending): New
1301         functions.
1302         (ascending_option_def, qcs_flag_option_def)
1303         (thr_qcs_flags_option_defs)
1304         (make_thread_apply_all_options_def_group)
1305         (make_thread_apply_options_def_group): New.
1306         (thread_apply_all_command): Use gdb::option::process_options.
1307         (thread_apply_command_completer)
1308         (thread_apply_all_command_completer): New.
1309         (thread_apply_command): Use gdb::option::process_options.
1310         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1311         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1312         to generate help text of "thread apply".  Adjust "taas"'s help.
1313         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1314         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1315
1316 2019-06-13  Pedro Alves  <palves@redhat.com>
1317
1318         * thread.c (thread_apply_command): Check for invalid TID with
1319         isdigit instead of !isalpha.
1320
1321 2019-06-13  Pedro Alves  <palves@redhat.com>
1322
1323         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1324         (validate_flags_qcs): New.
1325         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1326         (validate_flags_qcs): Declare.
1327         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1328         (make_frame_apply_options_def_group): New.
1329         (frame_apply_command_count): Process options with
1330         gdb::option::process_options.
1331         (frame_apply_completer): New.
1332         (frame_apply_level_completer, frame_apply_all_completer)
1333         (frame_apply_completer): New.
1334         (_initialize_stack): Update help of "frame apply", "frame apply
1335         level", "frame apply all" and "faas" to mention supported options
1336         and install command completers.
1337         * stack.h (frame_apply_all_completer): Declare.
1338         * thread.c: Include "stack.h".
1339         (tfaas_command): Add "--".
1340         (_initialize_thread): Update help "tfaas" to mention supported
1341         options and install command completer.
1342
1343 2019-06-13  Pedro Alves  <palves@redhat.com>
1344
1345         * completer.c (complete_nested_command_line): New.
1346         (gdb_completion_word_break_characters_throw): Add assertion.
1347         * completer.h (complete_nested_command_line): Declare.
1348
1349 2019-06-13  Pedro Alves  <palves@redhat.com>
1350
1351         * stack.c (parse_backtrace_qualifiers): New.
1352         (backtrace_command): Use it.
1353         (backtrace_command_completer): Complete on qualifiers.
1354
1355 2019-06-13  Pedro Alves  <palves@redhat.com>
1356
1357         * frame.c: Include "cli/cli-option.h.
1358         (user_set_backtrace_options): New.
1359         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1360         Delete.
1361         (get_prev_frame): Adjust.
1362         (boolean_option_def, uinteger_option_def)
1363         (set_backtrace_option_defs): New.
1364         (_initialize_frame): Adjust and use
1365         gdb::option::add_setshow_cmds_for_options to install "set
1366         backtrace past-main" and "set backtrace past-entry".
1367         * frame.h: Include "cli/cli-option.h".
1368         (struct frame_print_options): Forward declare.
1369         (print_frame_arguments_all, print_frame_arguments_scalars)
1370         (print_frame_arguments_none): Declare.
1371         (print_entry_values): Delete declaration.
1372         (struct frame_print_options, user_frame_print_options): New.
1373         (struct set_backtrace_options): New.
1374         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1375         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1376         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1377         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1378         (list_args_or_locals): Add frame_print_options parameter.
1379         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1380         * python/py-framefilter.c (enumerate_args): Pass down
1381         USER_FRAME_PRINT_OPTIONS.
1382         * stack.c: Include "cli/cli-option.h".
1383         (print_frame_arguments_all, print_frame_arguments_scalars)
1384         (print_frame_arguments_none): Declare.
1385         (print_raw_frame_arguments, print_entry_values): Delete.
1386         (user_frame_print_options): New.
1387         (boolean_option_def, enum_option_def, frame_print_option_defs):
1388         New.
1389         (struct backtrace_cmd_options): New.
1390         (bt_flag_option_def): New.
1391         (backtrace_command_option_defs): New.
1392         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1393         (print_frame_arg, read_frame_arg, print_frame_args)
1394         (print_frame_info, print_frame): Add frame_print_options parameter
1395         and use it.
1396         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1397         (backtrace_command_1): Add frame_print_options and
1398         backtrace_cmd_options parameters and use them.
1399         (make_backtrace_options_def_group): New.
1400         (backtrace_command): Process command options with
1401         gdb::option::process_options.
1402         (backtrace_command_completer): New.
1403         (_initialize_stack): Extend "backtrace"'s help to mention
1404         supported options.  Install completer for "backtrace".
1405         Install some settings commands with add_setshow_cmds_for_options.
1406
1407 2019-06-13  Pedro Alves  <palves@redhat.com>
1408
1409         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1410         and that "set/show print raw frame-arguments" are now deprecated.
1411
1412         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1413         command.
1414         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1415         * stack.c (_initialize_stack): Install "set/show print
1416         raw-frame-arguments", and deprecate "set/show print raw
1417         frame-arguments".
1418         * valprint.c (_initialize_valprint): Deprecate "set/show print
1419         raw".
1420
1421 2019-06-13  Pedro Alves  <palves@redhat.com>
1422
1423         * compile/compile.c (struct compile_options): New.
1424         (compile_flag_option_def, compile_command_option_defs)
1425         (make_compile_options_def_group): New.
1426         (compile_file_command): Handle options with
1427         gdb::option::process_options.
1428         (compile_file_command_completer): New function.
1429         (compile_code_command): Handle options with
1430         gdb::option::process_options.
1431         (compile_code_command_completer): New function.
1432         (_initialize_compiler): Install completers for "compile code" and
1433         "compile file".  Mention available options in "compile code" and
1434         "compile code"'s help.
1435         * completer.c (advance_to_completion_word): New, factored out from
1436         ...
1437         (advance_to_expression_complete_word_point): ... this.
1438         (advance_to_filename_complete_word_point): New.
1439         * completer.h (advance_to_filename_complete_word_point): New
1440         declaration.
1441
1442 2019-06-13  Pedro Alves  <palves@redhat.com>
1443
1444         * compile/compile.c: Include "cli/cli-option.h".
1445         (compile_print_value): Scope data pointer is now a
1446         value_print_options pointer; adjust.
1447         (compile_print_command): Process options.  Scope data pointer is
1448         now a value_print_options pointer; adjust.
1449         (_initialize_compile): Update "compile print"'s help to include
1450         supported options.  Install a completer for "compile print".
1451         * cp-valprint.c (show_vtblprint, show_objectprint)
1452         (show_static_field_print): Delete.
1453         (_initialize_cp_valprint): Don't install "set print
1454         static-members", "set print vtbl", "set print object" here.
1455         * printcmd.c: Include "cli/cli-option.h" and
1456         "common/gdb_optional.h".
1457         (print_command_parse_format): Rework to fill in a
1458         value_print_options instead of a format_data.
1459         (print_value): Change parameter type from format_data pointer to
1460         value_print_options reference.  Adjust.
1461         (print_command_1): Process options.  Adjust to pass down a
1462         value_print_options.
1463         (print_command_completer): New.
1464         (_initialize_printcmd): Install print_command_completer as
1465         handle_brkchars completer for the "print" command.  Update
1466         "print"'s help to include supported options.
1467         * valprint.c: Include "cli/cli-option.h".
1468         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1469         here from cp-valprint.c.
1470         (boolean_option_def, uinteger_option_def)
1471         (value_print_option_defs, make_value_print_options_def_group):
1472         New.  Use gdb::option::add_setshow_cmds_for_options to install
1473         "set print elements", "set print null-stop", "set print repeats",
1474         "set print pretty", "set print union", "set print array", "set
1475         print address", "set print symbol", "set print array-indexes".
1476         * valprint.h: Include <string> and "cli/cli-option.h".
1477         (make_value_print_options_def_group): Declare.
1478         (print_value): Change parameter type from format_data pointer to
1479         value_print_options reference.
1480         (print_command_completer): Declare.
1481
1482 2019-06-13  Pedro Alves  <palves@redhat.com>
1483
1484         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1485         (COMMON_SFILES): Add maint-test-settings.c.
1486         * cli/cli-decode.c (boolean_enums): New global, factored out from
1487         ...
1488         (add_setshow_boolean_cmd): ... here.
1489         * cli/cli-decode.h (boolean_enums): Declare.
1490         * cli/cli-option.c: New file.
1491         * cli/cli-option.h: New file.
1492         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1493         factored out from ...
1494         (parse_cli_boolean_value(const char *)): ... this.
1495         (is_unlimited_literal): Change parameter type to pointer to
1496         pointer.  Adjust and advance ARG pointer.
1497         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1498         (parse_cli_var_enum): New, factored out from ...
1499         (do_set_command): ... this.  Adjust.
1500         * cli/cli-setshow.h (parse_cli_boolean_value)
1501         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1502         (parse_cli_var_enum): Declare.
1503         * cli/cli-utils.c: Include "cli/cli-option.h".
1504         (get_ulongest): New.
1505         * cli/cli-utils.h (get_ulongest): Declare.
1506         (check_for_argument): New overloads.
1507         * maint-test-options.c: New file.
1508
1509 2019-06-13  Pedro Alves  <palves@redhat.com>
1510
1511         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1512         parse a range if "-" is at the end of the string.
1513
1514 2019-06-13  Pedro Alves  <palves@redhat.com>
1515
1516         * cli/cli-setshow.c (parse_auto_binary_operation)
1517         (parse_cli_boolean_value): Don't allow "o".
1518
1519 2019-06-13  Pedro Alves  <palves@redhat.com>
1520
1521         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1522         * NEWS: Mention maint test-settings KIND.
1523         * maint-test-settings.c: New file.
1524
1525 2019-06-13  Pedro Alves  <palves@redhat.com>
1526
1527         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1528         completer.
1529         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1530         "set" completers.
1531
1532 2019-06-13  Pedro Alves  <palves@redhat.com>
1533
1534         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1535         after item.
1536
1537 2019-06-13  Pedro Alves  <palves@redhat.com>
1538
1539         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1540
1541 2019-06-13  Pedro Alves <palves@redhat.com>
1542
1543         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1544         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1545         call.
1546         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1547         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1548         calls.
1549         (check_for_argument): Skip spaces after argument.
1550
1551 2019-06-13  Pedro Alves  <palves@redhat.com>
1552
1553         * thread.c (thread_apply_command): Adjust TID parsing.
1554         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1555         detected before end of string.
1556         (tid_is_in_list): Error out if LIST is invalid.
1557
1558 2019-06-13  Pedro Alves  <palves@redhat.com>
1559
1560         * completer.c (complete_line_internal_1): Rewind completion word
1561         point.
1562         (completion_tracker::advance_custom_word_point_by): Change
1563         parameter type to int.
1564         * completer.h (completion_tracker::advance_custom_word_point_by):
1565         Likewise.
1566
1567 2019-06-13  Pedro Alves  <palves@redhat.com>
1568
1569         * completer.c (advance_to_completion_word): Handle delimiters.
1570
1571 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1572
1573         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1574
1575 2019-06-11  Tom Tromey  <tom@tromey.com>
1576
1577         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1578         (xmalloc_failed): Move to alloc.c.
1579         * alloc.c: New file.
1580         * Makefile.in (COMMON_SFILES): Add alloc.c.
1581
1582 2019-06-11  Tom Tromey  <tom@tromey.com>
1583
1584         * nat/linux-waitpid.c: Don't include server.h.
1585         (linux_debug): Remove.
1586         (my_waitpid): Update.
1587
1588 2019-06-11  Tom Tromey  <tromey@adacore.com>
1589
1590         * infcall.c (_initialize_infcall): Remove trailing newline from
1591         help.
1592         * user-regs.c (_initialize_user_regs): Remove trailing newline
1593         from help.
1594         * typeprint.c (_initialize_typeprint): Remove trailing newline
1595         from help.
1596         * reverse.c (_initialize_reverse): Remove trailing newlines from
1597         help.
1598         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1599         from help.
1600         * language.c (add_set_language_command): Remove trailing newline
1601         from help.
1602         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1603         help.
1604         * disasm.c (_initialize_disasm): Remove trailing newline from
1605         help.
1606         * top.c (init_main): Remove trailing newline from help.
1607         * interps.c (_initialize_interpreter): Remove trailing newline
1608         from help.
1609         * btrace.c (_initialize_btrace): Remove trailing newlines from
1610         help.
1611         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1612         from help.
1613         * python/python.c (_initialize_python): Remove trailing newline
1614         from help.
1615         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1616         help.
1617         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1618         from help.  Reformat some text.
1619         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1620         from help.
1621         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1622         newline from help.
1623
1624 2019-06-11  Tom Tromey  <tromey@adacore.com>
1625
1626         * darwin-nat.c (darwin_decode_exception_message)
1627         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1628
1629 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1630
1631         * valops.c (value_slice): Check for not allocated or not
1632         associated values.
1633
1634 2019-06-10  Tom de Vries  <tdevries@suse.de>
1635
1636         PR gdb/24618
1637         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1638         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1639         invalid.
1640
1641 2019-06-10  Tom de Vries  <tdevries@suse.de>
1642
1643         PR gdb/24611
1644         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1645         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1646
1647 2019-06-10  Tom de Vries  <tdevries@suse.de>
1648
1649         PR symtab/24545
1650         * symtab.c (struct demangled_name_entry): Add language field.
1651         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1652         static minimal symbol".  Set and use language field.
1653
1654 2019-06-10  Tom Tromey  <tromey@adacore.com>
1655
1656         * ada-lang.c (_initialize_ada_language): Update help text.
1657
1658 2019-06-10  Tom Tromey  <tromey@adacore.com>
1659
1660         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1661         with a newline.
1662         * guile/guile.c (handle_boot_error): Don't end warning with a
1663         newline.
1664         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1665         warning with a newline.
1666         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1667         newline.
1668         (s12z_frame_cache): Likewise.
1669         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1670         a newline.
1671         * solib-svr4.c (disable_probes_interface): Don't end warning with
1672         a newline.
1673         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1674         newline.
1675         * python/python.c (do_finish_initialization): Don't end warning
1676         with a newline.
1677
1678 2019-06-10  Tom Tromey  <tom@tromey.com>
1679
1680         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1681         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1682         gdbpy_enter.
1683
1684 2019-06-10  Tom Tromey  <tromey@adacore.com>
1685
1686         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1687         data.
1688         (elf_new_init): Don't call stabsread_new_init.
1689         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1690         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1691         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1692
1693 2019-06-10  Tom de Vries  <tdevries@suse.de>
1694
1695         PR symtab/16264
1696         PR symtab/24517
1697         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1698
1699 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1700
1701         * source.c (find_and_open_source): Also rewrite relative file
1702         names.
1703
1704 2019-04-26  Amos Bird  <amosbird@gmail.com>
1705
1706         * annotate.c (annotate_thread_exited): Add "thread-exited"
1707         annotation.
1708
1709 2019-06-06  Tom Tromey  <tromey@adacore.com>
1710
1711         * maint.h (class scoped_command_stats): Use
1712         DISABLE_COPY_AND_ASSIGN.
1713         <print_time>: New method.
1714         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1715         print_time.
1716         (scoped_command_stats::print_time): New method.
1717
1718 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1719
1720         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1721         instructions of lengths 6 or 8 bytes.
1722
1723 2019-06-04  Pedro Alves  <palves@redhat.com>
1724
1725         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1726
1727         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1728         * breakpoint.c (condition_completer): Likewise.
1729         * cli/cli-dump.c (scan_expression): Likewise.
1730         * common/filestuff.c (mkdir_recursive): Likewise.
1731         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1732         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1733         (gdb_abspath): Likewise.
1734         * compile/compile-cplus-types.c
1735         (compile_cplus_instance::decl_name): Likewise.
1736         * completer.c (complete_explicit_location):
1737         (signal_completer, reg_or_group_completer_1): Likewise.
1738         * cp-support.c (cp_remove_params_if_any): Likewise.
1739         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1740         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1741         * infcmd.c (strip_bg_char): Likewise.
1742         * linespec.c (copy_token_string): Likewise.
1743         * mi/mi-main.c (output_cores): Likewise.
1744         * psymtab.c (psymtab_search_name):
1745         * symfile.c (test_set_ext_lang_command): Likewise.
1746         * target.c (target_fileio_read_stralloc): Likewise.
1747         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1748         * value.c (complete_internalvar): Likewise.
1749
1750 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1751
1752         Add objfile property to gdb.Type.
1753         * NEWS: Mention Python API addition.
1754         * python/py-type.c (typy_get_objfile): New method.
1755
1756 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1757
1758         * NEWS: Mention the new set|show style [title|highlight].
1759         Mention changes to "show style", "help" and "apropos".
1760
1761 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1762
1763         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1764         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1765         instead of print_help_for_command.
1766         (print_doc_of_command): New function.
1767         (help_list): Add 'apropos -v word' suggestion.
1768         (print_help_for_command): Style the command name using title style.
1769         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1770         (_initialize_cli_cmds): Describe -v in apropos_command help.
1771
1772 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1773
1774         * cli/cli-style.h (cli_style_option): Add name in constructor,
1775         add m_name class member, add constructor with intensity,
1776         add name class function.
1777         (cli_style_option::add_setshow_commands): Remove name argument.
1778         (highlight_style, title_style): New styles.
1779         * cli/cli-style.c (do_show): New function that shows a style
1780         characteristic styling the style name with itself.
1781         (set_style_name): New function.
1782         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1783         Update all callers according to the changes in cli/cli-style.h.
1784         * utils.h (fputs_highlighted): New function.
1785         * utils.c (fputs_highlighted): Likewise.
1786
1787 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1788
1789         * NEWS: Mention new pipe command and new convenience variables.
1790
1791 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1792
1793         * cli/cli-cmds.c (pipe_command): New function.
1794         (_initialize_cli_cmds): Call add_com for pipe_command.
1795         Define | as an alias for pipe.
1796         (exit_status_set_internal_vars): New function.
1797         (shell_escape): Call exit_status_set_internal_vars.
1798         cli/cli-decode.c (find_command_name_length): Recognize | as
1799         a single character command.
1800
1801 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1802
1803         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1804         top.c (execute_command_to_ui_file): New function, mostly a copy
1805         of execute_command_to_string.
1806         (execute_command_to_string): Implement by calling
1807         execute_command_to_ui_file.
1808
1809 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1810
1811         * top.h (saved_command_line): Remove declaration.
1812         * top.c (previous_saved_command_line, previous_repeat_arguments):
1813         New variables.
1814         (saved_command_line): Make static, define together with other
1815         'repeat variables'.
1816         (dont_repeat): Clear repeat_arguments.
1817         (repeat_previous, get_saved_command_line, save_command_line):
1818         New functions.
1819         (gdb_init): Initialize saved_command_line
1820         and previous_saved_command_line.
1821         * main.c (captured_main_1): Remove saved_command_line initialization.
1822         * event-top.c (handle_line_of_input): Update to use
1823         the new 'repeat' related functions instead of direct access to
1824         saved_command_line.
1825         * command.h (repeat_previous, get_saved_command_line,
1826         save_command_line): New declarations.
1827         (dont_repeat): Add comment.
1828
1829 2019-05-30  Tom Tromey  <tromey@adacore.com>
1830
1831         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1832         Fix comment.
1833         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1834
1835 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1836
1837         PR cli/24587
1838         * completer.c (complete): Initialize variable word.
1839
1840 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1841
1842         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1843         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1844         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1845         'body' is NULL to the outter 'if', protecting the '!is_define'
1846         situation as well.
1847
1848 2019-05-29  Tom Tromey  <tromey@adacore.com>
1849
1850         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1851         (dwarf_unknown): New function.
1852         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1853         (dwarf_type_encoding_name): Use dwarf_unknown.
1854
1855 2019-05-29  Tom Tromey  <tromey@adacore.com>
1856
1857         PR c++/20020:
1858         * cp-valprint.c (cp_print_value_fields): Call
1859         cp_print_static_field inside "try".
1860
1861 2019-05-29  Tom Tromey  <tromey@adacore.com>
1862
1863         * inflow.c (struct terminal_info): Add default operator=.
1864         * configure: Rebuild.
1865         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1866         -Wdeprecated-copy-dtor, -Wredundant-move.
1867
1868 2019-05-29  Tom Tromey  <tromey@adacore.com>
1869
1870         * NEWS: Add entry.
1871         * infcmd.c (print_return_value_1): Handle finish_print
1872         option.
1873         (show_print_finish): New function.
1874         (_initialize_infcmd): Add "set/show print finish" commands.
1875         * valprint.c (user_print_options): Initialize new member.
1876         * valprint.h (struct value_print_options) <finish_print>: New
1877         member.
1878
1879 2019-05-28  Tom Tromey  <tromey@adacore.com>
1880
1881         * ada-lang.c (ada_remove_Xbn_suffix)
1882         (find_old_style_renaming_symbol)
1883         (parse_old_style_renaming): Remove.
1884         (ada_find_renaming_symbol): Don't call
1885         find_old_style_renaming_symbol.
1886         (ada_is_renaming_symbol): Rename from
1887         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1888         bool.  Now static.
1889         (ada_read_var_value): Update and simplify.
1890         * ada-exp.y (write_var_or_type): Remove old code.
1891
1892 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1893
1894         * event-top.c: Remove include comment.
1895         * inflow.c (class scoped_ignore_sigttou): Move from here...
1896         * inflow.h (class scoped_ignore_sigttou): ...to here.
1897         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1898         * top.c:  Remove include comment.
1899
1900 2019-05-27  Tom Tromey  <tom@tromey.com>
1901
1902         * NEWS: Fix typo.
1903
1904 2019-05-22  Tom Tromey  <tromey@adacore.com>
1905
1906         * target.c (target_follow_exec): Constify parameter.
1907         * target-delegates.c: Rebuild.
1908         * remote.c (remote_target::follow_exec): Constify parameter.
1909         * infrun.c (follow_exec): Constify parameter.
1910         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1911         (target_follow_exec): Likewise.
1912
1913 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1914
1915         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1916         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1917
1918 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1919
1920         * NEWS: Add debugredirect and testsuite sections.
1921
1922 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1923
1924         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1925         target descriptions using exclusively floating point register name
1926         aliases.
1927
1928 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         PR gdb/18644:
1931         * f-lang.c (build_fortran_types): Handle the case where
1932         gdbarch_floatformat_for_type returns a nullptr.
1933
1934 2019-05-21  Tom de Vries  <tdevries@suse.de>
1935
1936         PR cli/24587
1937         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1938
1939 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         PR gdb/18644:
1942         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1943         16-byte floats.
1944         * i386-tdep.c (i386_floatformat_for_type): Use
1945         floatformats_ia64_quad for the 16-byte floating point component
1946         within a fortran 32-byte complex number.
1947
1948 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1949
1950         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1951         delete default constructor.
1952         (find_partial_die): Update to return const struct.
1953         (partial_die_parent_scope): Move variable declaration into scope
1954         of its use and change its type to auto.
1955         (guess_partial_die_structure_name): Likewise.
1956         (partial_die_info::fixup): Likewise.
1957
1958 2019-05-17  Tom Tromey  <tromey@adacore.com>
1959
1960         * source.c (find_and_open_source): Remove cast.
1961
1962 2019-05-17  Tom Tromey  <tromey@adacore.com>
1963
1964         * annotate.c (annotate_source): Make "filename" const.
1965         * annotate.h (annotate_source): Use const.
1966
1967 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1968
1969         * disasm.c (set_disassembler_options): Send errors to stderr.
1970
1971 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1972
1973         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1974         (cli_interp_base::set_logging): Check debug_redirect.
1975         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1976         * cli/cli-logging.c (debug_redirect): Add static variable.
1977         (pop_output_files): Add default param.
1978         (handle_redirections): Print debug setting.
1979         (show_logging_command): Likewise.
1980         (_initialize_cli_logging): Add debugredirect command.
1981         * interps.c (current_interp_set_logging): Add debug_redirect
1982         parameter.
1983         * interps.h (set_logging): Add debug_redirect parameter.
1984         (current_interp_set_logging): Likewise.
1985         * mi/mi-common.h: Likewise.
1986         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1987
1988 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1989             Tom Tromey  <tromey@adacore.com>
1990
1991         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1992         directly.
1993         * cli/cli-interp.h (make_logging_output): Remove declaration.
1994         * cli/cli-logging.c (make_logging_output): Remove function.
1995         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1996         directly.
1997         * ui-file.c (tee_file::tee_file): Remove bools.
1998         (tee_file::~tee_file): Remove deletes.
1999         * ui-file.h (tee_file): Remove bools.
2000
2001 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2002
2003         * mi/mi-cmds.h (mi_cmd_complete): New function.
2004         * mi/mi-main.c (mi_cmd_complete): Likewise.
2005         * mi/mi-cmds.c: Define new MI command -complete.
2006         * NEWS: Mention new -complete command.
2007
2008 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2009
2010         * completer.h (complete): New function.
2011         * completer.c (complete): Likewise.
2012         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2013         function defined in completer.h.
2014
2015 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2016
2017         * MAINTAINERS (Write After Approval): Add myself.
2018
2019 2019-05-17  Tom de Vries  <tdevries@suse.de>
2020
2021         PR gdb/24094
2022         * dwarf2read.c (struct cu_partial_die_info): New struct.
2023         (find_partial_die): Return cu_partial_die_info.
2024         (partial_die_parent_scope, guess_partial_die_structure_name)
2025         (partial_die_info::fixup): Handle new return type of find_partial_die.
2026
2027 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2028
2029         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2030         "std::string", simplifying the algorithm.
2031
2032 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2033
2034         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2035         (stap_static_probe_ops::get_probes): Likewise.
2036
2037 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2038
2039         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2040         '-')" and "else if".
2041         (stap_parse_single_operand): Join checks for
2042         "gdbarch_stap_parse_special_token_p" and
2043         "gdbarch_stap_parse_special_token" in the same "if" statement.
2044         Invert check when verifying for operation on register
2045         displacement.
2046
2047 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2048
2049         * stap-probe.c (stap_get_opcode): Update comment.
2050         (stap_get_expected_argument_type): Likewise.
2051         (handle_stap_probe): Likewise.
2052
2053 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2054
2055         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2056         return type to 'bool'.  Adjust comment.  Use 'bool' when
2057         appropriate.
2058         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2059         * stap-probe.c (stap_parse_argument_1): Likewise.
2060         (stap_is_operator): Likewise.
2061         (stap_is_generic_prefix): Likewise.
2062         (stap_is_register_prefix): Likewise.
2063         (stap_is_register_indirection_prefix): Likewise.
2064         (stap_is_integer_prefix): Likewise.
2065         (stap_generic_check_suffix): Likewise.
2066         (stap_check_integer_suffix): Likewise.
2067         (stap_check_register_suffix): Likewise.
2068         (stap_check_register_indirection_suffix): Likewise.
2069         (stap_parse_register_operand): Likewise.
2070         (stap_parse_single_operand): Likewise.
2071         (stap_parse_argument_1): Likewise.
2072         (stap_probe::get_argument_count): Likewise.
2073         (stap_is_operator): Likewise.
2074
2075 2019-05-16  Tom Tromey  <tromey@adacore.com>
2076
2077         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2078         keyword to foreach.
2079
2080 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2081
2082         * linux-thread-db.c (try_thread_db_load_1): Change return type
2083         to bool.
2084         (try_thread_db_load): Likewise.
2085         (try_thread_db_load_from_pdir_1): Likewise.
2086         (try_thread_db_load_from_pdir): Likewise.
2087         (try_thread_db_load_from_sdir): Likewise.
2088         (try_thread_db_load_from_dir): Likewise.
2089         (thread_db_load_search): Likewise.
2090         (has_libpthread): Likewise.
2091         (thread_db_load): Likewise.
2092
2093 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2094
2095         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2096         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2097         NULL, and complain/return if that's the case.
2098
2099 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2100
2101         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2102         (advance, posn, abstract_read_memory): New functions.
2103         [struct mem_read_abstraction]: New struct.
2104         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2105
2106 2019-05-14  Tom Tromey  <tromey@adacore.com>
2107
2108         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2109         value is not lval_memory.
2110
2111 2019-05-14  Tom Tromey  <tromey@adacore.com>
2112
2113         * solib.c (info_sharedlibrary_command): Style the file name.
2114
2115 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2116
2117         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2118         (aarch64_vnv_type): Likewise.
2119         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2120         * common/tdesc.c: Likewise.
2121         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2122         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2123         * features/aarch64-fpu.xml: Add ieee half view.
2124         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2125         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2126         * gdbtypes.h (struct builtin_type): Likewise.
2127         (struct objfile_type): Likewise.
2128
2129 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2130
2131         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2132         typo.
2133         * location.h (string_to_event_location): Likewise.
2134
2135 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2136
2137         GDB 8.3 released.
2138
2139 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2140
2141         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2142         New variable declaration.
2143         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2144         New variable.
2145         (print_one_breakpoint): Use ui_out::test_flags and new global
2146         variable to compute use_fixed_output.
2147         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2148         Remove.
2149         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2150         (mi_multi_location_breakpoint_output_fixed): Remove.
2151         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2152         new variable.
2153         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2154         fix_multi_location_breakpoint_output flag if version >= 3.
2155         * ui-out.h (enum ui_out_flag)
2156         <fix_multi_location_breakpoint_output>: New enumerator.
2157
2158 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2159
2160         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2161
2162 2019-05-10  Tom Tromey  <tromey@adacore.com>
2163
2164         * ada-lang.c (catch_ada_completer): New function.
2165         (_initialize_ada_language): Use it.
2166
2167 2019-05-10  Tom Tromey  <tromey@adacore.com>
2168
2169         * thread.c (print_thread_info): Make "requested_threads" const.
2170         * gdbthread.h (print_thread_info): Make "requested_threads"
2171         const.
2172         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2173         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2174
2175 2019-05-08  Tom Tromey  <tom@tromey.com>
2176
2177         * gdbtypes.c (objfile_type_data): Change type.
2178         (objfile_type, _initialize_gdbtypes): Update.
2179
2180 2019-05-08  Tom Tromey  <tom@tromey.com>
2181
2182         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2183         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2184         (_initialize_dwarf2_frame): Update.
2185
2186 2019-05-08  Tom Tromey  <tom@tromey.com>
2187
2188         * objc-lang.c (objc_objfile_data): Change type.
2189         (find_methods): Update.
2190         (_initialize_objc_lang): Remove.
2191
2192 2019-05-08  Tom Tromey  <tom@tromey.com>
2193
2194         * stabsread.c (rs6000_builtin_type_data): Change type.
2195         (rs6000_builtin_type, _initialize_stabsread): Update.
2196
2197 2019-05-08  Tom Tromey  <tom@tromey.com>
2198
2199         * mips-tdep.c (mips_pdr_data): Remove.
2200         (_initialize_mips_tdep): Update.
2201
2202 2019-05-08  Tom Tromey  <tom@tromey.com>
2203
2204         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2205         (hppa_init_objfile_priv_data, read_unwind_info)
2206         (find_unwind_entry, _initialize_hppa_tdep): Update.
2207
2208 2019-05-08  Tom Tromey  <tom@tromey.com>
2209
2210         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2211         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2212         on obstack.
2213         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2214
2215 2019-05-08  Tom Tromey  <tom@tromey.com>
2216
2217         * mdebugread.c (basic_type_data): Change type.
2218         (basic_type, _initialize_mdebugread): Update.
2219
2220 2019-05-08  Tom Tromey  <tom@tromey.com>
2221
2222         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2223
2224 2019-05-08  Tom Tromey  <tom@tromey.com>
2225
2226         * nto-tdep.c (nto_inferior_data_reg): Change type.
2227         (nto_inferior_data): Update.
2228         (nto_inferior_data_cleanup, nto_new_inferior_data)
2229         (_initialize_nto_tdep): Remove.
2230         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2231
2232 2019-05-08  Tom Tromey  <tom@tromey.com>
2233
2234         * ada-lang.c (struct ada_inferior_data): Add initializers.
2235         (ada_inferior_data): Change type.
2236         (ada_inferior_data_cleanup): Remove.
2237         (get_ada_inferior_data, ada_inferior_exit)
2238         (struct ada_pspace_data): Add initializers, destructor.
2239         (ada_pspace_data_handle): Change type.
2240         (get_ada_pspace_data): Update.
2241         (ada_pspace_data_cleanup): Remove.
2242
2243 2019-05-08  Tom Tromey  <tom@tromey.com>
2244
2245         * coffread.c (struct coff_symfile_info): Add initializers.
2246         (coff_objfile_data_key): Move lower.  Change type.
2247         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2248         Update.
2249         (coff_free_info): Remove.
2250
2251 2019-05-08  Tom Tromey  <tom@tromey.com>
2252
2253         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2254         (fbsd_pspace_data_handle): Move lower.  Change type.
2255         (get_fbsd_pspace_data): Update.
2256         (fbsd_pspace_data_cleanup): Remove.
2257         (_initialize_fbsd_tdep): Update.
2258
2259 2019-05-08  Tom Tromey  <tom@tromey.com>
2260
2261         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2262         (get_ada_tasks_pspace_data): Update.
2263         (ada_tasks_pspace_data_cleanup): Remove.
2264         (_initialize_tasks): Update.
2265         (ada_tasks_inferior_data_handle): Change type.
2266         (get_ada_tasks_inferior_data): Update.
2267         (ada_tasks_inferior_data_cleanup): Remove.
2268         (struct ada_tasks_pspace_data): Add initializers.
2269
2270 2019-05-08  Tom Tromey  <tom@tromey.com>
2271
2272         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2273         * symfile-debug.c (debug_sym_get_probes): Change type.
2274         * stap-probe.c (handle_stap_probe):
2275         (stap_static_probe_ops::get_probes): Change type.
2276         * probe.h (class static_probe_ops) <get_probes>: Change type.
2277         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2278         (parse_probes_in_pspace): Update.
2279         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2280         Update.
2281         (any_static_probe_ops::get_probes): Change type.
2282         * elfread.c (elfread_data): New typedef.
2283         (probe_key): Change type.
2284         (elf_get_probes): Likewise.  Update.
2285         (probe_key_free): Remove.
2286         (_initialize_elfread): Update.
2287         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2288         Change type.
2289         (dtrace_process_dof_probe, dtrace_process_dof)
2290         (dtrace_static_probe_ops::get_probe): Change type.
2291
2292 2019-05-08  Tom Tromey  <tom@tromey.com>
2293
2294         * xcoffread.c (struct xcoff_symfile_info): Rename from
2295         coff_symfile_info.  Add initializers.
2296         (xcoff_objfile_data_key): Move lower.  Change type.
2297         (XCOFF_DATA): Rewrite.
2298         (xcoff_free_info): Remove.
2299         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2300         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2301         (xcoff_initial_scan): Update.
2302
2303 2019-05-08  Tom Tromey  <tom@tromey.com>
2304
2305         * solib-svr4.c (struct svr4_info): Add initializers and
2306         destructor.
2307         <probes_table>: Now an htab_up.
2308         (solib_svr4_pspace_data): Change type.
2309         (free_probes_table): Simplify.
2310         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2311         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2312         (probes_table_remove_objfile_probes, register_solib_event_probe)
2313         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2314         (_initialize_svr4_solib): Update.
2315
2316 2019-05-08  Tom Tromey  <tom@tromey.com>
2317
2318         * remote.c (remote_pspace_data): Change type.
2319         (remote_pspace_data_cleanup): Remove.
2320         (get_remote_exec_file, set_pspace_remote_exec_file)
2321         (_initialize_remote): Update.
2322
2323 2019-05-08  Tom Tromey  <tom@tromey.com>
2324
2325         * breakpoint.c (breakpoint_objfile_key): Change type.
2326         (get_breakpoint_objfile_data): Update.
2327         (free_breakpoint_objfile_data): Remove.
2328         (_initialize_breakpoint): Update.
2329
2330 2019-05-08  Tom Tromey  <tom@tromey.com>
2331
2332         * linux-tdep.c (struct linux_info): Add initializers.
2333         (linux_inferior_data): Move.  Change type.
2334         (invalidate_linux_cache_inf): Update.
2335         (linux_inferior_data_cleanup): Remove.
2336         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2337
2338 2019-05-08  Tom Tromey  <tom@tromey.com>
2339
2340         * auxv.c (auxv_inferior_data): Move.  Change type.
2341         (auxv_inferior_data_cleanup): Remove.
2342         (invalidate_auxv_cache_inf): Rewrite.
2343         (get_auxv_inferior_data, _initialize_auxv): Update.
2344
2345 2019-05-08  Tom Tromey  <tom@tromey.com>
2346
2347         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2348         (symfile_debug_objfile_data_key): Change type.
2349         (symfile_debug_installed, debug_qf_has_symbols)
2350         (debug_qf_find_last_source_symtab)
2351         (debug_qf_forget_cached_source_info)
2352         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2353         (debug_qf_print_stats, debug_qf_dump)
2354         (debug_qf_expand_symtabs_for_function)
2355         (debug_qf_expand_all_symtabs)
2356         (debug_qf_expand_symtabs_with_fullname)
2357         (debug_qf_map_matching_symbols)
2358         (debug_qf_expand_symtabs_matching)
2359         (debug_qf_find_pc_sect_compunit_symtab)
2360         (debug_qf_map_symbol_filenames)
2361         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2362         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2363         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2364         (debug_sym_read_linetable, debug_sym_relocate): Update.
2365         (symfile_debug_free_objfile): Remove.
2366         (install_symfile_debug_logging, _initialize_symfile_debug):
2367         Update.
2368
2369 2019-05-08  Tom Tromey  <tom@tromey.com>
2370
2371         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2372         allocate_on_obstack.
2373         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2374         (get_dwarf2_per_objfile): Update.
2375         (set_dwarf2_per_objfile): Remove.
2376         (dwarf2_has_info, dwarf2_get_section_info): Update.
2377         (dwarf2_free_objfile): Remove.
2378         (_initialize_dwarf2_read): Update.
2379
2380 2019-05-08  Tom Tromey  <tom@tromey.com>
2381
2382         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2383         initializers.
2384         <unsupported_script_warning_printed,
2385         script_not_found_warning_printed>: Now bool.
2386         (auto_load_pspace_data): Change type.
2387         (~auto_load_pspace_info): Rename from
2388         auto_load_pspace_data_cleanup.
2389         (get_auto_load_pspace_data, init_loaded_scripts_info)
2390         (clear_section_scripts, maybe_print_unsupported_script_warning)
2391         (maybe_print_script_not_found_warning, _initialize_auto_load):
2392         Update.
2393
2394 2019-05-08  Tom Tromey  <tom@tromey.com>
2395
2396         * objfiles.c (objfile_pspace_info): Add destructor and
2397         initializers.
2398         (objfiles_pspace_data): Change type.
2399         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2400         (get_objfile_pspace_data): Update.
2401         (objfiles_bfd_data): Change type.
2402         (get_objfile_bfd_data): Update.
2403         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2404
2405 2019-05-08  Tom Tromey  <tom@tromey.com>
2406
2407         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2408         Change type.
2409         (get_catch_syscall_inferior_data): Update.
2410         (catch_syscall_inferior_data_cleanup): Remove.
2411         (_initialize_break_catch_syscall): Update.
2412
2413 2019-05-08  Tom Tromey  <tom@tromey.com>
2414
2415         * inflow.c (struct terminal_info): Add destructor and
2416         initializers.
2417         (inflow_inferior_data): Change type.
2418         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2419         (get_inflow_inferior_data, inflow_inferior_exit)
2420         (swap_terminal_info, _initialize_inflow): Update.
2421
2422 2019-05-08  Tom Tromey  <tom@tromey.com>
2423
2424         * target-dcache.c (target_dcache_cleanup): Remove.
2425         (target_dcache_aspace_key): Change type.
2426         (target_dcache_init_p, target_dcache_invalidate)
2427         (target_dcache_get, target_dcache_get_or_init)
2428         (_initialize_target_dcache): Update.
2429         * dcache.h (struct dcache_deleter): New.
2430
2431 2019-05-08  Tom Tromey  <tom@tromey.com>
2432
2433         * symtab.c (struct symbol_cache): Add destructor and
2434         initializers.
2435         (symbol_cache_key): Move.  Change type.
2436         (make_symbol_cache, free_symbol_cache): Remove.
2437         (get_symbol_cache): Update.
2438         (symbol_cache_cleanup): Remove.
2439         (ALL_PSPACES, symbol_cache_flush)
2440         (maintenance_print_symbol_cache)
2441         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2442         Update.
2443
2444 2019-05-08  Tom Tromey  <tom@tromey.com>
2445
2446         * symtab.c (struct main_info): Add destructor and initializers.
2447         (main_progspace_key): Move.  Change type.
2448         (get_main_info): Update.
2449         (main_info_cleanup): Remove.
2450         (_initialize_symtab): Update.
2451
2452 2019-05-08  Tom Tromey  <tom@tromey.com>
2453
2454         * registry.h (DECLARE_REGISTRY): Define the _key class.
2455
2456 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2457
2458         * NEWS: Merge two 'New commands' sections.
2459
2460 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2461
2462         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2463         parameter and use Ada language definition instead.
2464         (ada_val_print_ptr): Remove unused language parameter.
2465         (ada_val_print_num): Remove language parameter and use Ada language
2466         definition instead.
2467         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2468         parameter.
2469         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2470         parameter and use Ada language definition instead.
2471         (ada_val_print_1): Update all ada_val_print_xxx calls.
2472         Remove language parameter.
2473         (ada_val_print): Update ada_val_print_1 call.
2474
2475 2019-05-08  Tom Tromey  <tromey@adacore.com>
2476
2477         * remote.c (remote_hw_watchpoint_limit)
2478         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2479         Now static.
2480
2481 2019-05-08  Tom Tromey  <tromey@adacore.com>
2482
2483         * maint.c (_initialize_maint_cmds): Move initialization code to
2484         remote.c.
2485         (watchdog, show_watchdog): Move to remote.c.
2486         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2487         "watchdog" static.
2488         (_initialize_remote): Move initialization code from maint.c.
2489         * defs.h (watchdog): Don't declare.
2490
2491 2019-05-08  Tom Tromey  <tromey@adacore.com>
2492
2493         * tui/tui-interp.c: Include main.h.
2494         * interps.c: Include main.h.
2495         * main.h (interpreter_p): Declare.
2496         * defs.h (interpreter_p): Don't declare.
2497
2498 2019-05-08  Tom Tromey  <tromey@adacore.com>
2499
2500         * dwarf2loc.c: Include dwarf2read.h.
2501         * defs.h (read_unsigned_leb128): Don't declare.
2502         * dwarf2read.h (read_unsigned_leb128): Declare.
2503
2504 2019-05-08  Tom Tromey  <tromey@adacore.com>
2505
2506         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2507         method.
2508
2509 2019-05-08  Tom Tromey  <tromey@adacore.com>
2510
2511         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2512         when no wrap column is set.
2513
2514 2019-05-08  Tom Tromey  <tromey@adacore.com>
2515
2516         * c-lang.c (c_get_string): Handle non-C-style arrays.
2517
2518 2019-05-08  Tom Tromey  <tromey@adacore.com>
2519
2520         * typeprint.c (print_offset_data::update): Print the bit offset,
2521         not the number of bits remaining.
2522
2523 2019-05-08  Tom Tromey  <tromey@adacore.com>
2524
2525         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2526         padding at end of comment.
2527
2528 2019-05-08  Tom Tromey  <tromey@adacore.com>
2529
2530         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2531         Compare main types.
2532
2533 2019-05-06  Tom Tromey  <tom@tromey.com>
2534
2535         * common/scoped_mmap.c: Include common-defs.h.
2536         * common/scoped_mmap.h: Don't include config.h.
2537
2538 2019-05-04  Tom Tromey  <tom@tromey.com>
2539
2540         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2541         (struct aarch64_call_info): Add initializers.
2542         <si>: Now a std::vector.
2543         (pass_on_stack, aarch64_push_dummy_call): Update.
2544
2545 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2546             Tom Tromey  <tom@tromey.com>
2547
2548         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2549         (ppc_threads): Now a std::vector.  Now static.
2550         (hwdebug_find_thread_points_by_tid)
2551         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2552         Update.
2553
2554 2019-05-04  Tom Tromey  <tom@tromey.com>
2555
2556         * arc-tdep.c (arc_tdesc_init): Return bool.
2557
2558 2019-05-04  Tom Tromey  <tom@tromey.com>
2559
2560         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2561         Use gdb_assert_not_reached.
2562
2563 2019-05-04  Tom Tromey  <tom@tromey.com>
2564
2565         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2566         "false".
2567
2568 2019-05-04  Tom Tromey  <tom@tromey.com>
2569
2570         * arc-tdep.c (arc_tdesc_init): Use bool.
2571
2572 2019-05-04  Tom Tromey  <tom@tromey.com>
2573
2574         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2575
2576 2019-05-04  Tom Tromey  <tom@tromey.com>
2577
2578         * cli/cli-cmds.c (valid_command_p): Return bool.
2579
2580 2019-05-04  Tom Tromey  <tom@tromey.com>
2581
2582         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2583         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2584
2585 2019-05-04  Raul Tambre  <raul@tambre.ee>
2586
2587         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2588         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2589         operator for comparison.
2590
2591 2019-05-04  Tom Tromey  <tom@tromey.com>
2592
2593         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2594         (lookup_partial_symbol, print_partial_symbols)
2595         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2596         (psymbol_compare): Update.
2597         (add_psymbol_to_bcache): Clear the entire psymbol.
2598         (maintenance_check_psymtabs): Update.
2599         * psympriv.h (struct partial_symbol): Don't derive from
2600         general_symbol_info.
2601         <obj_section, unrelocated_address, address,
2602         set_unrelocated_address>: Update.
2603         <ginfo>: New member.
2604         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2605         (debug_names::write_psymbols): Update.
2606
2607 2019-05-04  Tom de Vries  <tdevries@suse.de>
2608
2609         * contrib/cc-with-tweaks.sh: Support -n arg.
2610
2611 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2612
2613         * corelow.c (core_target::detach): Ensure frame cache and
2614         register caches are cleared.
2615         inferior.c (exit_inferior_1): Likewise.
2616
2617 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2618             Tom Tromey  <tom@tromey.com>
2619
2620         * dictionary.c (collate_pending_symbols_by_language): Remove
2621         "struct" from foreach.
2622         * symtab.c (lookup_global_symbol_from_objfile)
2623         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2624         foreach.
2625         * ser-tcp.c (net_open): Remove "struct" from foreach.
2626         * objfiles.c (objfile_relocate, objfile_rebase)
2627         (objfile_has_symbols): Remove "struct" from foreach.
2628         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2629         from foreach.
2630         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2631         foreach.
2632         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2633         "struct" from foreach.
2634         * ada-lang.c (create_excep_cond_exprs)
2635         (ada_exception_catchpoint_cond_string): Remove "struct" from
2636         foreach.
2637
2638 2019-05-03  Tom Tromey  <tromey@adacore.com>
2639
2640         * ada-exp.y (convert_char_literal): Check suffix of each
2641         enumerator.
2642
2643 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2644
2645         PR ada/21406:
2646         * ada-exp.y (yywrap): Don't define.
2647         * ada-lex.l (%option): Add noyywrap
2648         (yywrap): Remove.
2649
2650 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2651
2652         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2653         _WIN32_WINNT to the XP level, unless already defined to a higher
2654         level.
2655
2656         * unittests/parse-connection-spec-selftests.c:
2657         * ser-tcp.c:
2658         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2659         override.
2660
2661         * symfile.c (find_separate_debug_file): Remove colon from the
2662         drive spec of DOS/Windows file names of the target, so that the
2663         file name produced from DEBUGDIR and the target's directory will
2664         be valid on DOS/Windows systems.
2665
2666 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2667
2668         * rust-lang.c (val_print_struct): Handle printing structures
2669         containing strings.
2670
2671 2019-05-02  Tom Tromey  <tromey@adacore.com>
2672
2673         * valarith.c (_initialize_valarith): Remove.
2674
2675 2019-05-01  Tom Tromey  <tromey@adacore.com>
2676
2677         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2678         bitfields.
2679
2680 2019-05-01  Tom Tromey  <tromey@adacore.com>
2681
2682         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2683         for big-endian copies.
2684
2685 2019-04-30  Ali Tamur  <tamur@google.com>
2686         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2687         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2688         (read_3_bytes): New function.
2689
2690 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2691
2692         * windows-nat.c (main_thread_id): Delete.
2693         (handle_output_debug_string): Replace main_thread_id by
2694         current_event.dwThreadId.
2695         (fake_create_process): Likewise.
2696         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2697         Do not set main_thread_id.
2698         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2699         current_event.dwThreadId.
2700         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2701
2702 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2703
2704         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2705         Use current_event.dwThreadId instead of main_thread_id.
2706
2707 2019-04-30  Tom Tromey  <tromey@adacore.com>
2708
2709         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2710         (create_excep_cond_exprs): Iterate over program spaces.
2711         (ada_exception_catchpoint_cond_string): Examine all minimal
2712         symbols for exception types.
2713
2714 2019-04-30  Tom Tromey  <tromey@adacore.com>
2715
2716         PR c++/24470:
2717         * dwarf2read.c (process_structure_scope): Handle case where type
2718         has template parameters but no symbol was created.
2719
2720 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2721             Chris January  <chris.january@arm.com>
2722
2723         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2724         qualifier.
2725         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2726
2727 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2728
2729         * f-typeprint.c (f_print_type): Update rules for printing
2730         whitespace.
2731         (f_type_print_varspec_suffix): Likewise.
2732
2733 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2734             Chris January  <chris.january@arm.com>
2735
2736         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2737         function arguments.
2738
2739 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * f-lang.c (build_fortran_types): Change name of void type to
2742         lower case.
2743         * f-typeprint.c (f_type_print_base): Print the name of the void
2744         type, rather than a fixed string.
2745         * f-valprint.c (f_decorations): Use lower case void string.
2746
2747 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2748             Chris January  <chris.january@arm.com>
2749
2750         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2751         types for Fortran.
2752
2753 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2754             Chris January  <chris.january@arm.com>
2755             David Lecomber  <david.lecomber@arm.com>
2756
2757         * f-exp.y (BINOP_INTRINSIC): New token.
2758         (exp): New parser rule handling BINOP_INTRINSIC.
2759         (f77_keywords): Add new builtin procedures.
2760         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2761         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2762         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2763         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2764         (print_unop_subexp_f): New function.
2765         (print_binop_subexp_f): New function.
2766         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2767         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2768         (dump_subexp_body_f): Likewise.
2769         (operator_check_f): Likewise.
2770         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2771         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2772
2773 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2774
2775         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2776         UNOP_KIND.
2777         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2778         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2779         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2780         (operator_length_f): New fuction.
2781         (print_subexp_f): New function.
2782         (op_name_f): New function.
2783         (dump_subexp_body_f): New function.
2784         (operator_check_f): New function.
2785         (exp_descriptor_f): Replace standard expression handling functions
2786         with new functions.
2787         * gdb/fortran-operator.def: New file.
2788         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2789         * gdb/std-operator.def: Remove UNOP_KIND.
2790
2791 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * std-operator.def: Remove unbalanced, stray double quote
2794         character.
2795
2796 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2797             Chris January  <chris.january@arm.com>
2798             Daniel Everett  <daniel.everett@arm.com>
2799             Nick Forrington  <nick.forrington@arm.com>
2800             Richard Bunt  <richard.bunt@arm.com>
2801
2802         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2803         of depth when printing anonymous structs or unions.
2804         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2805         Don't print either the top-level value, or the children if the
2806         max-depth is exceeded.
2807         (ppscm_print_children): When printing the key of a map, allow one
2808         extra level of depth.
2809         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2810         print either the top-level value, or the children if the max-depth
2811         is exceeded.
2812         (print_children): When printing the key of a map, allow one extra
2813         level of depth.
2814         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2815         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2816         (user_print_options): Initialise max_depth field.
2817         (val_print_scalar_or_string_type_p): New function.
2818         (val_print): Check to see if the max depth has been reached.
2819         (val_print_check_max_depth): Define new function.
2820         (show_print_max_depth): New function.
2821         (_initialize_valprint): Add 'print max-depth' option.
2822         * valprint.h (struct value_print_options) <max_depth>: New field.
2823         (val_print_check_max_depth): Declare new function.
2824         * NEWS: Document new feature.
2825
2826 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2827
2828         * ada-lang.c (ada_language_defn): Initialise new field.
2829         * c-lang.c (c_is_string_type_p): New function.
2830         (c_language_defn): Initialise new field.
2831         (cplus_language_defn): Initialise new field.
2832         (asm_language_defn): Initialise new field.
2833         (minimal_language_defn): Initialise new field.
2834         * c-lang.h (c_is_string_type_p): Declare new function.
2835         * d-lang.c (d_language_defn): Initialise new field.
2836         * f-lang.c (f_is_string_type_p): New function.
2837         (f_language_defn): Initialise new field.
2838         * go-lang.c (go_is_string_type_p): New function.
2839         (go_language_defn): Initialise new field.
2840         * language.c (default_is_string_type_p): New function.
2841         (unknown_language_defn): Initialise new field.
2842         (auto_language_defn): Initialise new field.
2843         * language.h (struct language_defn) <la_is_string_type_p>: New
2844         member variable.
2845         (default_is_string_type_p): Declare new function.
2846         * m2-lang.c (m2_language_defn): Initialise new field.
2847         * objc-lang.c (objc_language_defn): Initialise new field.
2848         * opencl-lang.c (opencl_language_defn): Initialise new field.
2849         * p-lang.c (pascal_is_string_type_p): New function.
2850         (pascal_language_defn): Initialise new field.
2851         * rust-lang.c (rust_is_string_type_p): New function.
2852         (rust_language_defn): Initialise new field.
2853
2854 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2855
2856         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2857         New field.
2858         * ada-lang.c (ada_language_defn): Initialise new field.
2859         * c-lang.c (c_language_defn): Likewise.
2860         (cplus_language_defn): Likewise.
2861         (asm_language_defn): Likewise.
2862         (minimal_language_defn): Likewise.
2863         * d-lang.c (d_language_defn): Likewise.
2864         * f-lang.c (f_language_defn): Likewise.
2865         * go-lang.c (go_language_defn): Likewise.
2866         * language.c (unknown_language_defn): Likewise.
2867         (auto_language_defn): Likewise.
2868         * m2-lang.c (m2_language_defn): Likewise.
2869         * objc-lang.c (objc_language_defn): Likewise.
2870         * opencl-lang.c (opencl_language_defn): Likewise.
2871         * p-lang.c (pascal_language_defn): Likewise.
2872         * rust-lang.c (rust_language_defn): Likewise.
2873
2874 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2875
2876         * ada-lang.c (ada_is_character_type): Change return type to bool.
2877         (ada_is_string_type): Likewise.
2878         * ada-lang.h (ada_is_character_type): Update declaration
2879         (ada_is_string_type): Likewise.
2880
2881 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2882
2883         Support style in 'frame|thread apply'
2884
2885         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2886         * record.c (record_start, record_stop): Update callers of
2887         execute_command_to_string with false.
2888         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2889         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2890         methods.
2891         (class string_file): New constructor with term_out parameter.
2892         Override methods term_out and can_emit_style_escape.  New member
2893         term_out.
2894         (class stdio_file): Override can_emit_style_escape.
2895         (class tee_file): Override term_out and can_emit_style_escape.
2896         * utils.h (can_emit_style_escape): Remove.
2897         * utils.c (can_emit_style_escape): Likewise.
2898         Update all callers of can_emit_style_escape (SOMESTREAM) to
2899         SOMESTREAM->can_emit_style_escape.
2900         * source-cache.c (source_cache::get_source_lines): Likewise.
2901         * stack.c (frame_apply_command_count): Call execute_command_to_string
2902         passing the term_out characteristic of the current gdb_stdout.
2903         * thread.c (thr_try_catch_cmd): Likewise.
2904         * top.c (execute_command_to_string): pass term_out parameter
2905         to construct the string_file for the command output.
2906         * ui-file.c (term_cli_styling): New function (most code moved
2907         from utils.c can_emit_style_escape).
2908         (string_file::string_file, string_file::can_emit_style_escape,
2909         stdio_file::can_emit_style_escape, tee_file::term_out,
2910         tee_file::can_emit_style_escape): New functions.
2911
2912 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2913
2914         * NEWS: Mention the new set|show may-call-functions.
2915         * infcall.c (may_call_functions_p): New variable.
2916         (show_may_call_functions_p): New function.
2917         (call_function_by_hand_dummy): Throws an error if not
2918         may-call-functions.
2919         (_initialize_infcall): Call add_setshow_boolean_cmd for
2920         may-call-functions.
2921
2922 2019-04-25  Keith Seitz  <keiths@redhat.com>
2923
2924         PR c++/24367
2925         * cp-support.c (inspect_type): Don't attempt substitutions
2926         of symbol with the same name.
2927
2928 2019-04-25  Tom Tromey  <tromey@adacore.com>
2929
2930         PR gdb/24475:
2931         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2932         static.
2933
2934 2019-04-25  Tom Tromey  <tromey@adacore.com>
2935
2936         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2937         rvalue reference.
2938         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2939         (gdb_xml_parser::parse): Use std::move.
2940         * python/python-internal.h (gdbpy_convert_exception): Take a const
2941         reference.
2942         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2943         std::move.
2944         * python/py-utils.c (gdbpy_convert_exception): Take a const
2945         reference.
2946         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2947         Use std::move.
2948         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2949         Use std::move.
2950         * mi/mi-main.c (mi_print_exception): Take a const reference.
2951         * main.c (handle_command_errors): Take a const reference.
2952         * linespec.c (parse_linespec): Use std::move.
2953         * infcall.c (run_inferior_call): Use std::move.
2954         (call_function_by_hand_dummy): Use std::move.
2955         * exec.c (try_open_exec_file): Use std::move.
2956         * exceptions.h (exception_print, exception_fprintf)
2957         (exception_print_same): Update.
2958         * exceptions.c (print_exception, exception_print)
2959         (exception_fprintf, exception_print_same): Change parameters to
2960         const reference.
2961         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2962         * common/new-op.c: Use std::move.
2963         * common/common-exceptions.h (struct gdb_exception): Add move
2964         constructor.
2965         (struct gdb_exception_error, struct gdb_exception_quit, struct
2966         gdb_quit_bad_alloc): Change constructor to move constructor.
2967         (throw_exception): Change parameter to rvalue reference.
2968         * common/common-exceptions.c (throw_exception): Take rvalue
2969         reference.
2970         * cli/cli-interp.c (safe_execute_command): Use std::move.
2971         * breakpoint.c (insert_bp_location, location_to_sals): Use
2972         std::move.
2973
2974 2019-04-25  Tom Tromey  <tromey@adacore.com>
2975
2976         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2977         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2978         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2979         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2980         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2981         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2982         guile/scm-value.c: Use unpack.
2983         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2984         gdbscm_gdb_exception.
2985         (gdbscm_throw_gdb_exception): Likewise.
2986         (struct gdbscm_gdb_exception): New.
2987         (unpack): New function.
2988         (gdbscm_wrap): Use unpack.
2989
2990 2019-04-25  Tom Tromey  <tromey@adacore.com>
2991
2992         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2993         (gdb_rl_callback_handler): Use std::move.
2994         * common/common-exceptions.h (struct gdb_exception): Add move
2995         assignment operator.
2996         (throw_exception_sjlj): Change "exception" to const reference.
2997         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2998         (throw_exception_sjlj): Change "exception" to const reference.
2999
3000 2019-04-25  Tom Tromey  <tromey@adacore.com>
3001
3002         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3003         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3004         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3005         Update.
3006         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3007         Update.
3008         * mi/mi-interp.c (mi_interp::exec): Update.
3009         * linespec.c (parse_linespec): Update.
3010         * infcall.c (run_inferior_call): Update.
3011         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3012         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3013         (gdbscm_lookup_global_symbol): Update.
3014         * guile/scm-param.c (gdbscm_parameter_value): Update.
3015         * guile/scm-frame.c (gdbscm_frame_read_register)
3016         (gdbscm_frame_read_var): Update.
3017         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3018         * exec.c (try_open_exec_file): Update.
3019         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3020         (gdb_rl_callback_handler): Update.
3021         * common/common-exceptions.h (exception_none): Don't declare.
3022         * common/common-exceptions.c (exception_none): Don't define.
3023         (struct catcher) <exception>: Update.
3024         * cli/cli-interp.c (safe_execute_command): Update.
3025         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3026
3027 2019-04-25  Ali Tamur  <tamur@google.com>
3028
3029         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3030         (read_attribute_value): Likewise.
3031         (dwarf2_read_addr_index): Update comment.
3032         (read_str_index): Add DW_FORM_strx.
3033         (dwarf2_string_attr): Likewise.
3034         (dwarf2_const_value_attr): Likewise.
3035         (dump_die_shallow): Likewise.
3036         (dwarf2_fetch_constant_bytes): Likewise.
3037         (skip_form_bytes): Likewise.
3038         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3039
3040 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3041
3042         PR corefiles/11608
3043         PR corefiles/18187
3044         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3045         OFFSET.  Verify if current mapping contains an ELF header.
3046         (linux_find_memory_regions_full): Adjust call to
3047         dump_mapping_p.
3048
3049 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3050             Kang Li <kanglictf@gmail.com>
3051
3052         PR gdb/21600
3053
3054         * dwarf2-frame.c (read_initial_length): Be consistent about using
3055         unsigned representation of length.
3056         (decode_frame_entry_1): Likewise.  Check for wraparound of
3057         end pointer as well as buffer overflow.
3058
3059 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3060
3061         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3062         "vq".
3063
3064 2019-04-24  Tom Tromey  <tromey@adacore.com>
3065
3066         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3067
3068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * s12z-tdep.c (s12z_unwind_pc): Delete.
3071         (s12z_unwind_sp): Delete.
3072         (s12z_gdbarch_init): Don't register deleted functions with
3073         gdbarch.
3074
3075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3076
3077         * rl78-tdep.c (rl78_unwind_sp): Delete.
3078         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3079
3080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3081
3082         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3083         (xstormy16_unwind_pc): Delete.
3084         (xstormy16_dummy_id): Delete.
3085         (xstormy16_gdbarch_init): Don't register deleted functions with
3086         gdbarch.
3087
3088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3089
3090         * vax-tdep.c (vax_unwind_pc): Delete.
3091         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3092
3093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * v850-tdep.c (v850_unwind_sp): Delete.
3096         (v850_unwind_pc): Delete.
3097         (v850_dummy_id): Delete.
3098         (v850_gdbarch_init): Don't register deleted functions with
3099         gdbarch.
3100
3101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3102
3103         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3104         (tilegx_unwind_pc): Delete.
3105         (tilegx_unwind_dummy_id): Delete.
3106         (tilegx_gdbarch_init): Don't register deleted functions with
3107         gdbarch.
3108
3109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3110
3111         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3112         (tic6x_dummy_id): Delete.
3113         (tic6x_gdbarch_init): Don't register deleted functions with
3114         gdbarch.
3115
3116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3117
3118         * sparc-tdep.c (sparc_unwind_pc): Delete.
3119         (sparc32_gdbarch_init): Don't register deleted function with
3120         gdbarch.
3121
3122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3123
3124         * sh-tdep.c (sh_unwind_sp): Delete.
3125         (sh_unwind_pc): Delete.
3126         (sh_dummy_id): Delete.
3127         (sh_gdbarch_init): Don't register deleted functions with
3128         gdbarch.
3129
3130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3131
3132         * score-tdep.c (score_unwind_sp): Delete.
3133         (score_unwind_pc): Delete.
3134         (score_dummy_id): Delete.
3135         (score_gdbarch_init): Don't register deleted functions with
3136         gdbarch.
3137
3138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3139
3140         * rx-tdep.c (rx_unwind_pc): Delete.
3141         (rx_unwind_sp): Delete.
3142         (rx_dummy_id): Delete.
3143         (rx_gdbarch_init): Don't register deleted functions with
3144         gdbarch.  Update comment.
3145
3146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3147
3148         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3149         (rs6000_dummy_id): Delete.
3150         (rs6000_gdbarch_init): Don't register deleted functions with
3151         gdbarch.
3152
3153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3154
3155         * or1k-tdep.c (or1k_dummy_id): Delete.
3156         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3157
3158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3159
3160         * nios2-tdep.c (nios2_dummy_id): Delete.
3161         (nios2_unwind_sp): Delete.
3162         (nios2_gdbarch_init): Don't register deleted functions with
3163         gdbarch.
3164
3165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3166
3167         * nds32-tdep.c (nds32_dummy_id): Delete.
3168         (nds32_unwind_pc): Delete.
3169         (nds32_unwind_sp): Delete.
3170         (nds32_gdbarch_init): Don't register deleted functions with
3171         gdbarch.
3172
3173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * msp430-tdep.c (msp430_unwind_pc): Delete.
3176         (msp430_unwind_sp): Delete.
3177         (msp430_dummy_id): Delete.
3178         (msp430_gdbarch_init): Don't register deleted functions with
3179         gdbarch.
3180
3181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3182
3183         * moxie-tdep.c (moxie_unwind_sp): Delete.
3184         (moxie_unwind_pc): Delete.
3185         (moxie_dummy_id): Delete.
3186         (moxie_gdbarch_init): Don't register deleted functions with
3187         gdbarch.
3188
3189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3190
3191         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3192         (mn10300_unwind_pc): Delete.
3193         (mn10300_unwind_sp): Delete.
3194         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3195         mn10300_unwind_sp.
3196         (mn10300_frame_unwind_init): Don't register deleted functions with
3197         gdbarch.
3198
3199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3200
3201         * mep-tdep.c (mep_unwind_pc): Delete.
3202         (mep_unwind_sp): Delete.
3203         (mep_dummy_id): Delete.
3204         (mep_gdbarch_init): Don't register deleted functions with
3205         gdbarch.
3206
3207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3208
3209         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3210         (m68hc11_unwind_sp): Delete.
3211         (m68hc11_gdbarch_init): Don't register deleted functions with
3212         gdbarch.
3213
3214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3215
3216         * m32r-tdep.c (m32r_unwind_sp): Delete.
3217         (m32r_unwind_pc): Delete.
3218         (m32r_dummy_id): Delete.
3219         (m32r_gdbarch_init): Don't register deleted functions with
3220         gdbarch.
3221
3222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3223
3224         * m32c-tdep.c (m32c_unwind_pc): Delete.
3225         (m32c_unwind_sp): Delete.
3226         (m32c_dummy_id): Delete.
3227         (m32c_gdbarch_init): Don't register deleted functions with
3228         gdbarch.
3229
3230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3231
3232         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3233         (lm32_unwind_pc): Delete.
3234         (lm32_dummy_id): Delete.
3235         (lm32_gdbarch_init): Don't register deleted functions with
3236         gdbarch.
3237
3238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3239
3240         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3241         (iq2000_unwind_pc): Delete.
3242         (iq2000_dummy_id): Delete.
3243         (iq2000_gdbarch_init): Don't register deleted functions with
3244         gdbarch.
3245
3246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3247
3248         * nds32-tdep.c (nds32_type_align): Delete.
3249         (nds32_push_dummy_call): Use type_align instead.
3250
3251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3252
3253         * arm-tdep.c (arm_type_align): Only handle vector override case.
3254         (arm_push_dummy_call): Use type_align.
3255         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3256
3257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3258
3259         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3260         case.
3261         (pass_on_stack): Use type_align.
3262         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3263         function.
3264
3265 2019-04-23  Tom Tromey  <tromey@adacore.com>
3266
3267         * dwarf2read.c (line_header::file_name_at): Remove unused
3268         overload.
3269
3270 2019-04-23  Tom de Vries  <tdevries@suse.de>
3271
3272         PR gdb/24438
3273         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3274         invocation.
3275
3276
3277 2019-03-27  Ali Tamur  <tamur@google.com>
3278
3279         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3280         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3281         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3282         (dwarf_expr_context::get_addr_index): Likewise
3283         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3284         (symbol_needs_eval_context::get_addr_index): Likewise
3285         (disassemble_dwarf_expression): Add DW_OP_addrx
3286         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3287         (read_cutu_die_from_dwo): Update comment
3288         (skip_one_die): Add DW_FORM_addrx
3289         (read_attribute_value): Likewise
3290         (var_decode_location): Add DW_OP_addrx
3291         (dwarf2_const_value_attr): Add DW_FORM_addrx
3292         (dump_die_shallow): Likewise
3293         (dwarf2_fetch_constant_bytes): Likewise
3294         (decode_locdesc): Add DW_OP_addrx
3295         (skip_form_bytes): Add DW_FORM_addrx
3296
3297 2019-04-22  Ali Tamur  <tamur@google.com>
3298
3299         * MAINTAINERS (Write After Approval): Add self.
3300
3301 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3302
3303         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3304         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3305         (open_symbol_file_object): Likewise.
3306         (svr4_default_sos): Add info parameter.
3307         (svr4_read_so_list): Likewise.
3308         (svr4_current_sos_direct): Adjust functions calls to pass down
3309         info.
3310         (svr4_current_sos_1): Add info parameter.
3311         (svr4_current_sos): Call get_svr4_info, pass info down to
3312         svr4_current_sos_1.
3313         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3314         get_svr4_info.
3315         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3316         get_svr4_info.
3317         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3318         to get_svr4_info.
3319         (probes_table_remove_objfile_probes): Likewise.
3320         (register_solib_event_probe): Add info parameter.
3321         (solist_update_incremental): Pass info parameter down to
3322         svr4_read_so_list.
3323         (disable_probes_interface): Add info parameter.
3324         (svr4_handle_solib_event): Pass current_program_space to
3325         get_svr4_info.  Adjust disable_probes_interface cleanup.
3326         (svr4_create_probe_breakpoints): Add info parameter, pass it
3327         down to register_solib_event_probe.
3328         (svr4_create_solib_event_breakpoints): Add info parameter,
3329         pass it down to svr4_create_probe_breakpoints.
3330         (enable_break): Pass info down to
3331         svr4_create_solib_event_breakpoints.
3332         (svr4_solib_create_inferior_hook): Pass current_program_space to
3333         get_svr4_info.
3334         (svr4_clear_solib): Likewise.
3335
3336 2019-04-22  Pedro Alves  <palves@redhat.com>
3337
3338         * solib-svr4.c (svr4_free_objfile_observer): New.
3339         (probe_and_action::objfile): New field.
3340         (probes_table_htab_remove_objfile_probes)
3341         (probes_table_remove_objfile_probes): New functions.
3342         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3343         in the new probe_and_action.  Don't store the probe in 'lookup'.
3344         (svr4_create_probe_breakpoints): Pass objfile to
3345         register_solib_event_probe.
3346         (_initialize_svr4_solib): Register a free_objfile observer.
3347
3348 2019-04-19  Tom Tromey  <tom@tromey.com>
3349
3350         * common/queue.h: Remove.
3351
3352 2019-04-19  Tom Tromey  <tom@tromey.com>
3353
3354         * event-loop.c: Don't include "common/queue.h".
3355
3356 2019-04-19  Tom Tromey  <tom@tromey.com>
3357
3358         * remote.c (remote_target): Use delete.
3359         * remote-notif.h: Include <list>, not "common/queue.h".
3360         (notif_client_p): Remove typedef.
3361         (remote_notif_state): Add constructor, destructor, initializer.
3362         <notif_queue>: Now a std::list.
3363         (remote_notif_state_xfree): Don't declare.
3364         * remote-notif.c (remote_notif_process, handle_notification)
3365         (remote_notif_state_allocate): Update.
3366         (~remote_notif_state): Rename from remote_notif_state_xfree.
3367
3368 2019-04-19  Tom Tromey  <tom@tromey.com>
3369
3370         * symfile.c (reread_symbols): Update.
3371         * objfiles.c (objfile_register_static_link)
3372         (objfile_lookup_static_link): Update
3373         (~objfile) Don't delete static_links.
3374         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3375
3376 2019-04-19  Tom Tromey  <tom@tromey.com>
3377
3378         * type-stack.h (struct type_stack) <insert>: Constify string.
3379         * type-stack.c (type_stack::insert): Constify string.
3380         * gdbtypes.h (lookup_template_type): Update.
3381         (address_space_name_to_int): Update.
3382         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3383         const.
3384         (lookup_template_type): Make name const.
3385         * c-exp.y: Update rules.
3386         (lex_one_token, classify_name, classify_inner_name)
3387         (c_print_token): Update.
3388         * p-exp.y: Update rules.
3389         (yylex): Update.
3390         * f-exp.y: Update rules.
3391         (yylex): Update.
3392         * d-exp.y: Update rules.
3393         (lex_one_token, classify_name, classify_inner_name): Update.
3394         * parse.c (write_dollar_variable, copy_name): Return std::string.
3395         * parser-defs.h (copy_name): Change return type.
3396         * m2-exp.y: Update rules.
3397         (yylex): Update.
3398         * go-exp.y (lex_one_token): Update.
3399         Update rules.
3400         (classify_unsafe_function, classify_packaged_name)
3401         (classify_name, yylex): Update.
3402
3403 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3404
3405         * configure.ac: add --enable-source-highlight switch.
3406         * configure: Regenerate.
3407         * top.c (print_gdb_version): plumb --enable-source-highlight
3408         status to "show configuration".
3409
3410 2019-04-19  Tom Tromey  <tromey@adacore.com>
3411
3412         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3413         Check ADA_TYPE_P.
3414         (empty_record, ada_template_to_fixed_record_type_1)
3415         (template_to_static_fixed_type)
3416         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3417         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3418         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3419         macros.
3420
3421 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3422
3423         PR symtab/24423:
3424         * source.c (print_source_lines_base): Advance "iter" when a
3425         control character is seen.
3426
3427 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3428
3429         * inferior.h (struct infcall_suspend_state_deleter):
3430         Catch exception in destructor to avoid crash.
3431
3432 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3433
3434         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3435         close to the add_com "shell".
3436
3437 2019-04-18  Tom Tromey  <tromey@adacore.com>
3438
3439         * process-stratum-target.h (class process_stratum_target)
3440         <stratum>: Add "final".
3441
3442 2019-04-17  Tom Tromey  <tromey@adacore.com>
3443
3444         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3445         against nullptr before use.
3446
3447 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3448
3449         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3450
3451 2019-04-17  Jim Wilson  <jimw@sifive.com>
3452             Andrew Burgess  <andrew.burgess@embecosm.com>
3453
3454         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3455         code read might fail, assume 4-byte breakpoint in that case.
3456
3457 2019-04-15  Leszek Swirski  <leszeks@google.com>
3458
3459         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3460         rather than a hand-rolled POD check when checking for forced MEMORY
3461         classification.
3462
3463 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3464
3465         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3466         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3467         function.
3468         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3469         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3470         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3471         declaration.
3472
3473 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3474
3475         * aarch64-linux-nat.c
3476         (aarch64_linux_nat_target::thread_architecture): Add override.
3477         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3478         each VQ.
3479
3480 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3481
3482         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3483
3484 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3485
3486         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3487         target types of size 96-bits, add some additional comments, and
3488         check that the builtin type we found was the correct size.
3489
3490 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3491
3492         * utils.c (prompt_for_continue): Don't restore the styling at the
3493         end, as applied_style has the wrong value.  This fixes styling in
3494         long lists of file names that are interrupted by the "Continue?"
3495         prompt.
3496
3497 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3498
3499         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3500         * c-lang.c (c_language_defn): Likewise.
3501         (cplus_language_defn): Likewise.
3502         (asm_language_defn): Likewise.
3503         (minimal_language_defn): Likewise.
3504         * d-lang.c (d_language_defn): Likewise.
3505         * f-lang.c (f_language_defn): Likewise.
3506         * go-lang.c (go_language_defn): Likewise.
3507         * language.c (unknown_language_defn): Likewise.
3508         (auto_language_defn): Likewise.
3509         * language.h (struct language_defn): Remove la_magic field.
3510         (LANG_MAGIC): Delete.
3511         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3512         * objc-lang.c (objc_language_defn): Likewise.
3513         * opencl-lang.c (opencl_language_defn): Likewise.
3514         * p-lang.c (pascal_language_defn): Likewise.
3515         * rust-lang.c (rust_language_defn): Likewise.
3516
3517 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3518
3519         * riscv-tdep.c (riscv_type_align): New function.
3520         (riscv_type_alignment): Delete.
3521         (riscv_arg_location): Use 'type_align'.
3522         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3523
3524 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3525
3526         * gdbtypes.c (type_align): A struct with no non-static fields also
3527         has alignment of 1.
3528
3529 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3530
3531         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3532         component to 0.
3533         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3534         member.
3535         (riscv_struct_info::analyse): New implementation using new
3536         analyse_inner member function.
3537         (riscv_struct_info::field_offset): New member function.
3538         (riscv_struct_info::m_offsets): New member variable.
3539         (riscv_struct_info::analyse_inner): New private member function,
3540         takes the old implementation of riscv_struct_info::analyse but
3541         extended to track field offsets.
3542         (riscv_call_arg_struct): Update the struct folding special cases
3543         to handle cases where empty C++ structs, which are non-zero
3544         length, are found.
3545         (riscv_arg_location): Initialise the length of each location, a
3546         non-zero length now indicates the location is in use.
3547         (riscv_push_dummy_call): Allow for the first location having a
3548         non-zero offset when setting up arguments.
3549         (riscv_return_value): Likewise, but for return values.
3550
3551 2019-04-11  Tom Tromey  <tromey@adacore.com>
3552
3553         * utils.c (internal_vproblem): Make "msg" const.
3554
3555 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3556
3557         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3558         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3559         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3560         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3561
3562 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3563
3564         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3565         function.
3566         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3567         of amd64_collect_native_gregset.
3568         (amd64_linux_nat_target::store_registers): Likewise.
3569
3570 2019-04-10  Tom Tromey  <tom@tromey.com>
3571
3572         * symtab.c (lookup_global_symbol_from_objfile)
3573         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3574         * objfiles.h (class separate_debug_iterator): New.
3575         (class separate_debug_range): New.
3576         (struct objfile) <separate_debug_objfiles>: New method.
3577         (objfile_separate_debug_iterate): Don't declare.
3578         * objfiles.c (separate_debug_iterator::operator++): Rename from
3579         objfile_separate_debug_iterate.
3580         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3581         iterator.
3582         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3583         iterator.
3584
3585 2019-04-10  Tom Tromey  <tom@tromey.com>
3586
3587         * symfile.c (reread_symbols): Remove old comment.
3588         * objfiles.c (free_all_objfiles): Fix a typo.
3589
3590 2019-04-10  Tom Tromey  <tom@tromey.com>
3591
3592         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3593         * minsyms.c (lookup_minimal_symbol): Use foreach.
3594         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3595         (lookup_minimal_symbol_solib_trampoline): Likewise.
3596         * symfile.c (reread_symbols): Use foreach.
3597
3598 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3599             Tom Tromey  <tromey@adacore.com>
3600
3601         PR rust/24414:
3602         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3603         (rust_lex_int_test): Change "value" to be LONGEST.
3604         (rust_lex_tests): Add test for long integer literal.
3605
3606 2019-04-09  Tom Tromey  <tromey@adacore.com>
3607
3608         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3609         to bool.
3610         (extended_remote_target::attach): Update.
3611         (remote_target::remote_notice_new_inferior): Update.
3612         (remote_target::add_current_inferior_and_thread): Update.
3613         * inferior.c (exit_inferior_1): Use "false".
3614         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3615
3616 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3617
3618         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3619         the "start" command.
3620
3621 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3622
3623         * python/py-inferior.c (infpy_thread_from_thread_handle):
3624         Adjust comments to reflect renaming of thread_from_thread_handle
3625         to thread_from_handle.  Adjust keywords.  Fix type error message.
3626         (inferior_object_methods): Add thread_from_handle.  Retain
3627         thread_from_thread_handle, but mark it as deprecated.
3628
3629 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3630
3631         * gdbthread.h (find_thread_by_handle): Revise declaration.
3632         * thread.c (find_thread_by_handle): Likewise.  Adjust
3633         implementation too.
3634         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3635         support for buffer objects as handles.
3636
3637 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3638
3639         * python/py-infthread.c (thpy_thread_handle): New function.
3640         (thread_object_methods): Register thpy_thread_handle.
3641
3642 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3643
3644         * gdbthread.h (thread_to_thread_handle): Declare.
3645         * thread.c (gdbtypes.h): Include.
3646         (thread_to_thread_handle): New function.
3647
3648         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3649         (target_thread_info_to_thread_handle): Declare.
3650         * target.c (target_thread_info_to_thread_handle): New function.
3651         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3652         * target-delegates.c: Regenerate.
3653
3654         * linux-thread-db.c (class thread_db_target): Add method
3655         thread_info_to_thread_handle.
3656         (thread_db_target::thread_info_to_thread_handle): Define.
3657         * remote.c (class remote_target): Add new method
3658         thread_info_to_thread_handle.
3659         (remote_target::thread_info_to_thread_handle): Define.
3660
3661 2019-04-08  Pedro Alves  <palves@redhat.com>
3662
3663         * common/common-exceptions.c (throw_exception): Don't create
3664         named object to throw; throw directly.
3665         (throw_it): Likewise.  Don't initialize gdb_exception::message
3666         here, with new; pass FMT and AP to the ctor instead.
3667         * common/common-exceptions.h: Include <string>.
3668         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3669         const char *, va_list)): New ctor.  Use std::make_shared.
3670         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3671         errors)): Delete.
3672         (gdb_exception_error::gdb_exception_error(enum errors, const char
3673         *, va_list)): New.
3674         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3675         Add assertion.
3676         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3677         errors)): Delete.
3678         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3679         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3680         Add assertion.
3681
3682 2019-04-08  Tom Tromey  <tom@tromey.com>
3683
3684         * valops.c (value_rtti_indirect_type): Replace throw_exception
3685         with throw.
3686         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3687         with throw.
3688         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3689         throw.
3690         * target.c (target_translate_tls_address): Replace throw_exception
3691         with throw.
3692         * stack.c (frame_apply_command_count): Replace throw_exception
3693         with throw.
3694         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3695         throw.
3696         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3697         with throw.
3698         * rs6000-tdep.c (rs6000_frame_cache)
3699         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3700         * remote.c: Replace throw_exception with throw.
3701         * record-full.c (record_full_message, record_full_wait_1)
3702         (record_full_restore): Replace throw_exception with throw.
3703         * record-btrace.c:
3704         (get_thread_current_frame_id, record_btrace_start_replaying)
3705         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3706         (cmd_record_btrace_start): Replace throw_exception with throw.
3707         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3708         throw.
3709         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3710         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3711         * linespec.c:
3712         (find_linespec_symbols): Replace throw_exception with throw.
3713         * infrun.c (displaced_step_prepare, resume): Replace
3714         throw_exception with throw.
3715         * infcmd.c (post_create_inferior): Replace throw_exception with
3716         throw.
3717         * inf-loop.c (inferior_event_handler): Replace throw_exception
3718         with throw.
3719         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3720         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3721         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3722         (get_prev_frame_always, get_frame_pc_if_available)
3723         (get_frame_address_in_block_if_available, get_frame_language):
3724         Replace throw_exception with throw.
3725         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3726         throw_exception with throw.
3727         * eval.c (fetch_subexp_value, evaluate_var_value)
3728         (evaluate_funcall, evaluate_subexp_standard): Replace
3729         throw_exception with throw.
3730         * dwarf2loc.c (call_site_find_chain)
3731         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3732         Replace throw_exception with throw.
3733         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3734         with throw.
3735         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3736         throw.
3737         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3738         * completer.c (complete_line_internal): Replace throw_exception
3739         with throw.
3740         * compile/compile-object-run.c (compile_object_run): Replace
3741         throw_exception with throw.
3742         * cli/cli-script.c (process_next_line): Replace throw_exception
3743         with throw.
3744         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3745         (btrace_enable, btrace_maint_update_pt_packets): Replace
3746         throw_exception with throw.
3747         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3748         throw_exception with throw.
3749         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3750         throw_exception with throw.
3751         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3752         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3753         * aarch64-tdep.c (aarch64_make_prologue_cache)
3754         (aarch64_make_stub_cache): Replace throw_exception with throw.
3755
3756 2019-04-08  Tom Tromey  <tom@tromey.com>
3757
3758         * common/common-exceptions.c (throw_exception): Rename from
3759         throw_exception_cxx.  Remove old copy.  Make argument const.
3760         (throw_it): Create and throw exception objects directly.
3761         * common/common-exceptions.h (throw_exception): Make argument
3762         const.
3763         (struct gdb_exception_error): Add constructor.
3764         (struct gdb_exception_quit): Add constructor.
3765
3766 2019-04-08  Tom Tromey  <tom@tromey.com>
3767
3768         * common/common-exceptions.h (exception_rethrow): Don't declare.
3769         (TRY_SJLJ): Update comment.
3770         (TRY, CATCH, END_CATCH): Remove.
3771         * common/common-exceptions.c (exception_rethrow): Remove.
3772
3773 2019-04-08  Tom Tromey  <tom@tromey.com>
3774
3775         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3776         Remove.
3777         (gdb_exception_error): Rename from
3778         gdb_exception_RETURN_MASK_ERROR.
3779         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3780         (gdb_quit_bad_alloc): Update.
3781         * aarch64-tdep.c: Update.
3782         * ada-lang.c: Update.
3783         * ada-typeprint.c: Update.
3784         * ada-valprint.c: Update.
3785         * amd64-tdep.c: Update.
3786         * arch-utils.c: Update.
3787         * break-catch-throw.c: Update.
3788         * breakpoint.c: Update.
3789         * btrace.c: Update.
3790         * c-varobj.c: Update.
3791         * cli/cli-cmds.c: Update.
3792         * cli/cli-interp.c: Update.
3793         * cli/cli-script.c: Update.
3794         * common/common-exceptions.c: Update.
3795         * common/new-op.c: Update.
3796         * common/selftest.c: Update.
3797         * compile/compile-c-symbols.c: Update.
3798         * compile/compile-cplus-symbols.c: Update.
3799         * compile/compile-object-load.c: Update.
3800         * compile/compile-object-run.c: Update.
3801         * completer.c: Update.
3802         * corelow.c: Update.
3803         * cp-abi.c: Update.
3804         * cp-support.c: Update.
3805         * cp-valprint.c: Update.
3806         * darwin-nat.c: Update.
3807         * disasm-selftests.c: Update.
3808         * dtrace-probe.c: Update.
3809         * dwarf-index-cache.c: Update.
3810         * dwarf-index-write.c: Update.
3811         * dwarf2-frame-tailcall.c: Update.
3812         * dwarf2-frame.c: Update.
3813         * dwarf2loc.c: Update.
3814         * dwarf2read.c: Update.
3815         * eval.c: Update.
3816         * event-loop.c: Update.
3817         * event-top.c: Update.
3818         * exec.c: Update.
3819         * f-valprint.c: Update.
3820         * fbsd-tdep.c: Update.
3821         * frame-unwind.c: Update.
3822         * frame.c: Update.
3823         * gdbtypes.c: Update.
3824         * gnu-v3-abi.c: Update.
3825         * guile/guile-internal.h: Update.
3826         * guile/scm-block.c: Update.
3827         * guile/scm-breakpoint.c: Update.
3828         * guile/scm-cmd.c: Update.
3829         * guile/scm-disasm.c: Update.
3830         * guile/scm-frame.c: Update.
3831         * guile/scm-lazy-string.c: Update.
3832         * guile/scm-math.c: Update.
3833         * guile/scm-param.c: Update.
3834         * guile/scm-ports.c: Update.
3835         * guile/scm-pretty-print.c: Update.
3836         * guile/scm-symbol.c: Update.
3837         * guile/scm-symtab.c: Update.
3838         * guile/scm-type.c: Update.
3839         * guile/scm-value.c: Update.
3840         * i386-linux-tdep.c: Update.
3841         * i386-tdep.c: Update.
3842         * inf-loop.c: Update.
3843         * infcall.c: Update.
3844         * infcmd.c: Update.
3845         * infrun.c: Update.
3846         * jit.c: Update.
3847         * language.c: Update.
3848         * linespec.c: Update.
3849         * linux-fork.c: Update.
3850         * linux-nat.c: Update.
3851         * linux-tdep.c: Update.
3852         * linux-thread-db.c: Update.
3853         * main.c: Update.
3854         * mi/mi-cmd-break.c: Update.
3855         * mi/mi-cmd-stack.c: Update.
3856         * mi/mi-interp.c: Update.
3857         * mi/mi-main.c: Update.
3858         * objc-lang.c: Update.
3859         * p-valprint.c: Update.
3860         * parse.c: Update.
3861         * ppc-linux-tdep.c: Update.
3862         * printcmd.c: Update.
3863         * python/py-arch.c: Update.
3864         * python/py-breakpoint.c: Update.
3865         * python/py-cmd.c: Update.
3866         * python/py-finishbreakpoint.c: Update.
3867         * python/py-frame.c: Update.
3868         * python/py-framefilter.c: Update.
3869         * python/py-gdb-readline.c: Update.
3870         * python/py-inferior.c: Update.
3871         * python/py-infthread.c: Update.
3872         * python/py-lazy-string.c: Update.
3873         * python/py-linetable.c: Update.
3874         * python/py-objfile.c: Update.
3875         * python/py-param.c: Update.
3876         * python/py-prettyprint.c: Update.
3877         * python/py-progspace.c: Update.
3878         * python/py-record-btrace.c: Update.
3879         * python/py-record.c: Update.
3880         * python/py-symbol.c: Update.
3881         * python/py-type.c: Update.
3882         * python/py-unwind.c: Update.
3883         * python/py-utils.c: Update.
3884         * python/py-value.c: Update.
3885         * python/python.c: Update.
3886         * record-btrace.c: Update.
3887         * record-full.c: Update.
3888         * remote-fileio.c: Update.
3889         * remote.c: Update.
3890         * riscv-tdep.c: Update.
3891         * rs6000-aix-tdep.c: Update.
3892         * rs6000-tdep.c: Update.
3893         * rust-exp.y: Update.
3894         * rust-lang.c: Update.
3895         * s390-tdep.c: Update.
3896         * selftest-arch.c: Update.
3897         * solib-dsbt.c: Update.
3898         * solib-frv.c: Update.
3899         * solib-spu.c: Update.
3900         * solib-svr4.c: Update.
3901         * solib.c: Update.
3902         * sparc64-linux-tdep.c: Update.
3903         * stack.c: Update.
3904         * symfile-mem.c: Update.
3905         * symmisc.c: Update.
3906         * target.c: Update.
3907         * thread.c: Update.
3908         * top.c: Update.
3909         * tracefile-tfile.c: Update.
3910         * tui/tui.c: Update.
3911         * typeprint.c: Update.
3912         * unittests/cli-utils-selftests.c: Update.
3913         * unittests/parse-connection-spec-selftests.c: Update.
3914         * valops.c: Update.
3915         * valprint.c: Update.
3916         * value.c: Update.
3917         * varobj.c: Update.
3918         * windows-nat.c: Update.
3919         * x86-linux-nat.c: Update.
3920         * xml-support.c: Update.
3921
3922 2019-04-08  Tom Tromey  <tom@tromey.com>
3923
3924         * xml-support.c: Use C++ exception handling.
3925         * x86-linux-nat.c: Use C++ exception handling.
3926         * windows-nat.c: Use C++ exception handling.
3927         * varobj.c: Use C++ exception handling.
3928         * value.c: Use C++ exception handling.
3929         * valprint.c: Use C++ exception handling.
3930         * valops.c: Use C++ exception handling.
3931         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3932         handling.
3933         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3934         * typeprint.c: Use C++ exception handling.
3935         * tui/tui.c: Use C++ exception handling.
3936         * tracefile-tfile.c: Use C++ exception handling.
3937         * top.c: Use C++ exception handling.
3938         * thread.c: Use C++ exception handling.
3939         * target.c: Use C++ exception handling.
3940         * symmisc.c: Use C++ exception handling.
3941         * symfile-mem.c: Use C++ exception handling.
3942         * stack.c: Use C++ exception handling.
3943         * sparc64-linux-tdep.c: Use C++ exception handling.
3944         * solib.c: Use C++ exception handling.
3945         * solib-svr4.c: Use C++ exception handling.
3946         * solib-spu.c: Use C++ exception handling.
3947         * solib-frv.c: Use C++ exception handling.
3948         * solib-dsbt.c: Use C++ exception handling.
3949         * selftest-arch.c: Use C++ exception handling.
3950         * s390-tdep.c: Use C++ exception handling.
3951         * rust-lang.c: Use C++ exception handling.
3952         * rust-exp.y: Use C++ exception handling.
3953         * rs6000-tdep.c: Use C++ exception handling.
3954         * rs6000-aix-tdep.c: Use C++ exception handling.
3955         * riscv-tdep.c: Use C++ exception handling.
3956         * remote.c: Use C++ exception handling.
3957         * remote-fileio.c: Use C++ exception handling.
3958         * record-full.c: Use C++ exception handling.
3959         * record-btrace.c: Use C++ exception handling.
3960         * python/python.c: Use C++ exception handling.
3961         * python/py-value.c: Use C++ exception handling.
3962         * python/py-utils.c: Use C++ exception handling.
3963         * python/py-unwind.c: Use C++ exception handling.
3964         * python/py-type.c: Use C++ exception handling.
3965         * python/py-symbol.c: Use C++ exception handling.
3966         * python/py-record.c: Use C++ exception handling.
3967         * python/py-record-btrace.c: Use C++ exception handling.
3968         * python/py-progspace.c: Use C++ exception handling.
3969         * python/py-prettyprint.c: Use C++ exception handling.
3970         * python/py-param.c: Use C++ exception handling.
3971         * python/py-objfile.c: Use C++ exception handling.
3972         * python/py-linetable.c: Use C++ exception handling.
3973         * python/py-lazy-string.c: Use C++ exception handling.
3974         * python/py-infthread.c: Use C++ exception handling.
3975         * python/py-inferior.c: Use C++ exception handling.
3976         * python/py-gdb-readline.c: Use C++ exception handling.
3977         * python/py-framefilter.c: Use C++ exception handling.
3978         * python/py-frame.c: Use C++ exception handling.
3979         * python/py-finishbreakpoint.c: Use C++ exception handling.
3980         * python/py-cmd.c: Use C++ exception handling.
3981         * python/py-breakpoint.c: Use C++ exception handling.
3982         * python/py-arch.c: Use C++ exception handling.
3983         * printcmd.c: Use C++ exception handling.
3984         * ppc-linux-tdep.c: Use C++ exception handling.
3985         * parse.c: Use C++ exception handling.
3986         * p-valprint.c: Use C++ exception handling.
3987         * objc-lang.c: Use C++ exception handling.
3988         * mi/mi-main.c: Use C++ exception handling.
3989         * mi/mi-interp.c: Use C++ exception handling.
3990         * mi/mi-cmd-stack.c: Use C++ exception handling.
3991         * mi/mi-cmd-break.c: Use C++ exception handling.
3992         * main.c: Use C++ exception handling.
3993         * linux-thread-db.c: Use C++ exception handling.
3994         * linux-tdep.c: Use C++ exception handling.
3995         * linux-nat.c: Use C++ exception handling.
3996         * linux-fork.c: Use C++ exception handling.
3997         * linespec.c: Use C++ exception handling.
3998         * language.c: Use C++ exception handling.
3999         * jit.c: Use C++ exception handling.
4000         * infrun.c: Use C++ exception handling.
4001         * infcmd.c: Use C++ exception handling.
4002         * infcall.c: Use C++ exception handling.
4003         * inf-loop.c: Use C++ exception handling.
4004         * i386-tdep.c: Use C++ exception handling.
4005         * i386-linux-tdep.c: Use C++ exception handling.
4006         * guile/scm-value.c: Use C++ exception handling.
4007         * guile/scm-type.c: Use C++ exception handling.
4008         * guile/scm-symtab.c: Use C++ exception handling.
4009         * guile/scm-symbol.c: Use C++ exception handling.
4010         * guile/scm-pretty-print.c: Use C++ exception handling.
4011         * guile/scm-ports.c: Use C++ exception handling.
4012         * guile/scm-param.c: Use C++ exception handling.
4013         * guile/scm-math.c: Use C++ exception handling.
4014         * guile/scm-lazy-string.c: Use C++ exception handling.
4015         * guile/scm-frame.c: Use C++ exception handling.
4016         * guile/scm-disasm.c: Use C++ exception handling.
4017         * guile/scm-cmd.c: Use C++ exception handling.
4018         * guile/scm-breakpoint.c: Use C++ exception handling.
4019         * guile/scm-block.c: Use C++ exception handling.
4020         * guile/guile-internal.h: Use C++ exception handling.
4021         * gnu-v3-abi.c: Use C++ exception handling.
4022         * gdbtypes.c: Use C++ exception handling.
4023         * frame.c: Use C++ exception handling.
4024         * frame-unwind.c: Use C++ exception handling.
4025         * fbsd-tdep.c: Use C++ exception handling.
4026         * f-valprint.c: Use C++ exception handling.
4027         * exec.c: Use C++ exception handling.
4028         * event-top.c: Use C++ exception handling.
4029         * event-loop.c: Use C++ exception handling.
4030         * eval.c: Use C++ exception handling.
4031         * dwarf2read.c: Use C++ exception handling.
4032         * dwarf2loc.c: Use C++ exception handling.
4033         * dwarf2-frame.c: Use C++ exception handling.
4034         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4035         * dwarf-index-write.c: Use C++ exception handling.
4036         * dwarf-index-cache.c: Use C++ exception handling.
4037         * dtrace-probe.c: Use C++ exception handling.
4038         * disasm-selftests.c: Use C++ exception handling.
4039         * darwin-nat.c: Use C++ exception handling.
4040         * cp-valprint.c: Use C++ exception handling.
4041         * cp-support.c: Use C++ exception handling.
4042         * cp-abi.c: Use C++ exception handling.
4043         * corelow.c: Use C++ exception handling.
4044         * completer.c: Use C++ exception handling.
4045         * compile/compile-object-run.c: Use C++ exception handling.
4046         * compile/compile-object-load.c: Use C++ exception handling.
4047         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4048         * compile/compile-c-symbols.c: Use C++ exception handling.
4049         * common/selftest.c: Use C++ exception handling.
4050         * common/new-op.c: Use C++ exception handling.
4051         * cli/cli-script.c: Use C++ exception handling.
4052         * cli/cli-interp.c: Use C++ exception handling.
4053         * cli/cli-cmds.c: Use C++ exception handling.
4054         * c-varobj.c: Use C++ exception handling.
4055         * btrace.c: Use C++ exception handling.
4056         * breakpoint.c: Use C++ exception handling.
4057         * break-catch-throw.c: Use C++ exception handling.
4058         * arch-utils.c: Use C++ exception handling.
4059         * amd64-tdep.c: Use C++ exception handling.
4060         * ada-valprint.c: Use C++ exception handling.
4061         * ada-typeprint.c: Use C++ exception handling.
4062         * ada-lang.c: Use C++ exception handling.
4063         * aarch64-tdep.c: Use C++ exception handling.
4064
4065 2019-04-08  Tom Tromey  <tom@tromey.com>
4066
4067         * xml-support.c (gdb_xml_parser::parse): Update.
4068         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4069         * value.c (show_convenience): Update.
4070         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4071         (test_parse_flags_qcs): Update.
4072         * thread.c (thr_try_catch_cmd): Update.
4073         * target.c (target_translate_tls_address): Update.
4074         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4075         (info_frame_command_core, frame_apply_command_count): Update.
4076         * rust-exp.y (rust_lex_exception_test): Update.
4077         * riscv-tdep.c (riscv_print_one_register_info): Update.
4078         * remote.c (remote_target::enable_btrace): Update.
4079         * record-btrace.c (record_btrace_enable_warn): Update.
4080         * python/py-utils.c (gdbpy_convert_exception): Update.
4081         * printcmd.c (do_one_display, print_variable_and_value): Update.
4082         * mi/mi-main.c (mi_print_exception): Update.
4083         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4084         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4085         * linux-nat.c (linux_nat_target::attach): Update.
4086         * linux-fork.c (class scoped_switch_fork_info): Update.
4087         * infrun.c (displaced_step_prepare): Update.
4088         * infcall.c (call_function_by_hand_dummy): Update.
4089         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4090         * gnu-v3-abi.c (print_one_vtable): Update.
4091         * frame.c (get_prev_frame_always): Update.
4092         * f-valprint.c (info_common_command_for_block): Update.
4093         * exec.c (try_open_exec_file): Update.
4094         * exceptions.c (print_exception, exception_print)
4095         (exception_fprintf, exception_print_same): Update.
4096         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4097         * dwarf-index-cache.c (index_cache::store)
4098         (index_cache::lookup_gdb_index): Update.
4099         * darwin-nat.c (maybe_cache_shell): Update.
4100         * cp-valprint.c (cp_print_value_fields): Update.
4101         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4102         (gcc_cplus_symbol_address): Update.
4103         * compile/compile-c-symbols.c (gcc_convert_symbol)
4104         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4105         * common/selftest.c: Update.
4106         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4107         a std::string.
4108         (exception_try_scope_entry, exception_try_scope_exit): Don't
4109         declare.
4110         (struct exception_try_scope): Remove.
4111         (TRY): Don't use exception_try_scope.
4112         (struct gdb_exception): Add constructor, operator=.
4113         <what>: New method.
4114         (struct gdb_exception_RETURN_MASK_ALL)
4115         (struct gdb_exception_RETURN_MASK_ERROR)
4116         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4117         (struct gdb_quit_bad_alloc): Update.
4118         * common/common-exceptions.c (exception_none): Change
4119         initializer.
4120         (struct catcher) <state, exception>: Initialize inline.
4121         <prev>: Remove member.
4122         (current_catcher): Remove.
4123         (catchers): New global.
4124         (exceptions_state_mc_init): Simplify.
4125         (catcher_pop): Remove.
4126         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4127         (try_scope_depth, exception_try_scope_entry)
4128         (exception_try_scope_exit): Remove.
4129         (throw_exception_sjlj): Update.
4130         (exception_messages, exception_messages_size): Remove.
4131         (throw_it): Simplify.
4132         (gdb_exception_sliced_copy): Remove.
4133         (throw_exception_cxx): Update.
4134         * cli/cli-script.c (script_from_file): Update.
4135         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4136         Update.
4137         * ada-valprint.c (ada_val_print): Update.
4138         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4139         (create_excep_cond_exprs): Update.
4140
4141 2019-04-08  Tom Tromey  <tom@tromey.com>
4142
4143         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4144         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4145         (TRY, CATCH, END_CATCH): Remove some definitions.
4146         * common/common-exceptions.c: Don't use GDB_XCPT.
4147         (catcher_list_size): Remove.
4148         (throw_exception, throw_it): Simplify.
4149
4150 2019-04-05  Tom Tromey  <tom@tromey.com>
4151
4152         Revert the header-sorting patch.
4153         * ft32-tdep.c: Revert.
4154         * frv-tdep.c: Revert.
4155         * frv-linux-tdep.c: Revert.
4156         * frame.c: Revert.
4157         * frame-unwind.c: Revert.
4158         * frame-base.c: Revert.
4159         * fork-child.c: Revert.
4160         * findvar.c: Revert.
4161         * findcmd.c: Revert.
4162         * filesystem.c: Revert.
4163         * filename-seen-cache.h: Revert.
4164         * filename-seen-cache.c: Revert.
4165         * fbsd-tdep.c: Revert.
4166         * fbsd-nat.h: Revert.
4167         * fbsd-nat.c: Revert.
4168         * f-valprint.c: Revert.
4169         * f-typeprint.c: Revert.
4170         * f-lang.c: Revert.
4171         * extension.h: Revert.
4172         * extension.c: Revert.
4173         * extension-priv.h: Revert.
4174         * expprint.c: Revert.
4175         * exec.h: Revert.
4176         * exec.c: Revert.
4177         * exceptions.c: Revert.
4178         * event-top.c: Revert.
4179         * event-loop.c: Revert.
4180         * eval.c: Revert.
4181         * elfread.c: Revert.
4182         * dwarf2read.h: Revert.
4183         * dwarf2read.c: Revert.
4184         * dwarf2loc.c: Revert.
4185         * dwarf2expr.h: Revert.
4186         * dwarf2expr.c: Revert.
4187         * dwarf2-frame.c: Revert.
4188         * dwarf2-frame-tailcall.c: Revert.
4189         * dwarf-index-write.h: Revert.
4190         * dwarf-index-write.c: Revert.
4191         * dwarf-index-common.c: Revert.
4192         * dwarf-index-cache.h: Revert.
4193         * dwarf-index-cache.c: Revert.
4194         * dummy-frame.c: Revert.
4195         * dtrace-probe.c: Revert.
4196         * disasm.h: Revert.
4197         * disasm.c: Revert.
4198         * disasm-selftests.c: Revert.
4199         * dictionary.c: Revert.
4200         * dicos-tdep.c: Revert.
4201         * demangle.c: Revert.
4202         * dcache.h: Revert.
4203         * dcache.c: Revert.
4204         * darwin-nat.h: Revert.
4205         * darwin-nat.c: Revert.
4206         * darwin-nat-info.c: Revert.
4207         * d-valprint.c: Revert.
4208         * d-namespace.c: Revert.
4209         * d-lang.c: Revert.
4210         * ctf.c: Revert.
4211         * csky-tdep.c: Revert.
4212         * csky-linux-tdep.c: Revert.
4213         * cris-tdep.c: Revert.
4214         * cris-linux-tdep.c: Revert.
4215         * cp-valprint.c: Revert.
4216         * cp-support.c: Revert.
4217         * cp-namespace.c: Revert.
4218         * cp-abi.c: Revert.
4219         * corelow.c: Revert.
4220         * corefile.c: Revert.
4221         * continuations.c: Revert.
4222         * completer.h: Revert.
4223         * completer.c: Revert.
4224         * complaints.c: Revert.
4225         * coffread.c: Revert.
4226         * coff-pe-read.c: Revert.
4227         * cli-out.h: Revert.
4228         * cli-out.c: Revert.
4229         * charset.c: Revert.
4230         * c-varobj.c: Revert.
4231         * c-valprint.c: Revert.
4232         * c-typeprint.c: Revert.
4233         * c-lang.c: Revert.
4234         * buildsym.c: Revert.
4235         * buildsym-legacy.c: Revert.
4236         * build-id.h: Revert.
4237         * build-id.c: Revert.
4238         * btrace.c: Revert.
4239         * bsd-uthread.c: Revert.
4240         * breakpoint.h: Revert.
4241         * breakpoint.c: Revert.
4242         * break-catch-throw.c: Revert.
4243         * break-catch-syscall.c: Revert.
4244         * break-catch-sig.c: Revert.
4245         * blockframe.c: Revert.
4246         * block.c: Revert.
4247         * bfin-tdep.c: Revert.
4248         * bfin-linux-tdep.c: Revert.
4249         * bfd-target.c: Revert.
4250         * bcache.c: Revert.
4251         * ax-general.c: Revert.
4252         * ax-gdb.h: Revert.
4253         * ax-gdb.c: Revert.
4254         * avr-tdep.c: Revert.
4255         * auxv.c: Revert.
4256         * auto-load.c: Revert.
4257         * arm-wince-tdep.c: Revert.
4258         * arm-tdep.c: Revert.
4259         * arm-symbian-tdep.c: Revert.
4260         * arm-pikeos-tdep.c: Revert.
4261         * arm-obsd-tdep.c: Revert.
4262         * arm-nbsd-tdep.c: Revert.
4263         * arm-nbsd-nat.c: Revert.
4264         * arm-linux-tdep.c: Revert.
4265         * arm-linux-nat.c: Revert.
4266         * arm-fbsd-tdep.c: Revert.
4267         * arm-fbsd-nat.c: Revert.
4268         * arm-bsd-tdep.c: Revert.
4269         * arch-utils.c: Revert.
4270         * arc-tdep.c: Revert.
4271         * arc-newlib-tdep.c: Revert.
4272         * annotate.h: Revert.
4273         * annotate.c: Revert.
4274         * amd64-windows-tdep.c: Revert.
4275         * amd64-windows-nat.c: Revert.
4276         * amd64-tdep.c: Revert.
4277         * amd64-sol2-tdep.c: Revert.
4278         * amd64-obsd-tdep.c: Revert.
4279         * amd64-obsd-nat.c: Revert.
4280         * amd64-nbsd-tdep.c: Revert.
4281         * amd64-nbsd-nat.c: Revert.
4282         * amd64-nat.c: Revert.
4283         * amd64-linux-tdep.c: Revert.
4284         * amd64-linux-nat.c: Revert.
4285         * amd64-fbsd-tdep.c: Revert.
4286         * amd64-fbsd-nat.c: Revert.
4287         * amd64-dicos-tdep.c: Revert.
4288         * amd64-darwin-tdep.c: Revert.
4289         * amd64-bsd-nat.c: Revert.
4290         * alpha-tdep.c: Revert.
4291         * alpha-obsd-tdep.c: Revert.
4292         * alpha-nbsd-tdep.c: Revert.
4293         * alpha-mdebug-tdep.c: Revert.
4294         * alpha-linux-tdep.c: Revert.
4295         * alpha-linux-nat.c: Revert.
4296         * alpha-bsd-tdep.c: Revert.
4297         * alpha-bsd-nat.c: Revert.
4298         * aix-thread.c: Revert.
4299         * agent.c: Revert.
4300         * addrmap.c: Revert.
4301         * ada-varobj.c: Revert.
4302         * ada-valprint.c: Revert.
4303         * ada-typeprint.c: Revert.
4304         * ada-tasks.c: Revert.
4305         * ada-lang.c: Revert.
4306         * aarch64-tdep.c: Revert.
4307         * aarch64-ravenscar-thread.c: Revert.
4308         * aarch64-newlib-tdep.c: Revert.
4309         * aarch64-linux-tdep.c: Revert.
4310         * aarch64-linux-nat.c: Revert.
4311         * aarch64-fbsd-tdep.c: Revert.
4312         * aarch64-fbsd-nat.c: Revert.
4313         * aarch32-linux-nat.c: Revert.
4314
4315 2019-04-05  Tom Tromey  <tom@tromey.com>
4316
4317         * ft32-tdep.c: Sort headers.
4318         * frv-tdep.c: Sort headers.
4319         * frv-linux-tdep.c: Sort headers.
4320         * frame.c: Sort headers.
4321         * frame-unwind.c: Sort headers.
4322         * frame-base.c: Sort headers.
4323         * fork-child.c: Sort headers.
4324         * findvar.c: Sort headers.
4325         * findcmd.c: Sort headers.
4326         * filesystem.c: Sort headers.
4327         * filename-seen-cache.h: Sort headers.
4328         * filename-seen-cache.c: Sort headers.
4329         * fbsd-tdep.c: Sort headers.
4330         * fbsd-nat.h: Sort headers.
4331         * fbsd-nat.c: Sort headers.
4332         * f-valprint.c: Sort headers.
4333         * f-typeprint.c: Sort headers.
4334         * f-lang.c: Sort headers.
4335         * extension.h: Sort headers.
4336         * extension.c: Sort headers.
4337         * extension-priv.h: Sort headers.
4338         * expprint.c: Sort headers.
4339         * exec.h: Sort headers.
4340         * exec.c: Sort headers.
4341         * exceptions.c: Sort headers.
4342         * event-top.c: Sort headers.
4343         * event-loop.c: Sort headers.
4344         * eval.c: Sort headers.
4345         * elfread.c: Sort headers.
4346         * dwarf2read.h: Sort headers.
4347         * dwarf2read.c: Sort headers.
4348         * dwarf2loc.c: Sort headers.
4349         * dwarf2expr.h: Sort headers.
4350         * dwarf2expr.c: Sort headers.
4351         * dwarf2-frame.c: Sort headers.
4352         * dwarf2-frame-tailcall.c: Sort headers.
4353         * dwarf-index-write.h: Sort headers.
4354         * dwarf-index-write.c: Sort headers.
4355         * dwarf-index-common.c: Sort headers.
4356         * dwarf-index-cache.h: Sort headers.
4357         * dwarf-index-cache.c: Sort headers.
4358         * dummy-frame.c: Sort headers.
4359         * dtrace-probe.c: Sort headers.
4360         * disasm.h: Sort headers.
4361         * disasm.c: Sort headers.
4362         * disasm-selftests.c: Sort headers.
4363         * dictionary.c: Sort headers.
4364         * dicos-tdep.c: Sort headers.
4365         * demangle.c: Sort headers.
4366         * dcache.h: Sort headers.
4367         * dcache.c: Sort headers.
4368         * darwin-nat.h: Sort headers.
4369         * darwin-nat.c: Sort headers.
4370         * darwin-nat-info.c: Sort headers.
4371         * d-valprint.c: Sort headers.
4372         * d-namespace.c: Sort headers.
4373         * d-lang.c: Sort headers.
4374         * ctf.c: Sort headers.
4375         * csky-tdep.c: Sort headers.
4376         * csky-linux-tdep.c: Sort headers.
4377         * cris-tdep.c: Sort headers.
4378         * cris-linux-tdep.c: Sort headers.
4379         * cp-valprint.c: Sort headers.
4380         * cp-support.c: Sort headers.
4381         * cp-namespace.c: Sort headers.
4382         * cp-abi.c: Sort headers.
4383         * corelow.c: Sort headers.
4384         * corefile.c: Sort headers.
4385         * continuations.c: Sort headers.
4386         * completer.h: Sort headers.
4387         * completer.c: Sort headers.
4388         * complaints.c: Sort headers.
4389         * coffread.c: Sort headers.
4390         * coff-pe-read.c: Sort headers.
4391         * cli-out.h: Sort headers.
4392         * cli-out.c: Sort headers.
4393         * charset.c: Sort headers.
4394         * c-varobj.c: Sort headers.
4395         * c-valprint.c: Sort headers.
4396         * c-typeprint.c: Sort headers.
4397         * c-lang.c: Sort headers.
4398         * buildsym.c: Sort headers.
4399         * buildsym-legacy.c: Sort headers.
4400         * build-id.h: Sort headers.
4401         * build-id.c: Sort headers.
4402         * btrace.c: Sort headers.
4403         * bsd-uthread.c: Sort headers.
4404         * breakpoint.h: Sort headers.
4405         * breakpoint.c: Sort headers.
4406         * break-catch-throw.c: Sort headers.
4407         * break-catch-syscall.c: Sort headers.
4408         * break-catch-sig.c: Sort headers.
4409         * blockframe.c: Sort headers.
4410         * block.c: Sort headers.
4411         * bfin-tdep.c: Sort headers.
4412         * bfin-linux-tdep.c: Sort headers.
4413         * bfd-target.c: Sort headers.
4414         * bcache.c: Sort headers.
4415         * ax-general.c: Sort headers.
4416         * ax-gdb.h: Sort headers.
4417         * ax-gdb.c: Sort headers.
4418         * avr-tdep.c: Sort headers.
4419         * auxv.c: Sort headers.
4420         * auto-load.c: Sort headers.
4421         * arm-wince-tdep.c: Sort headers.
4422         * arm-tdep.c: Sort headers.
4423         * arm-symbian-tdep.c: Sort headers.
4424         * arm-pikeos-tdep.c: Sort headers.
4425         * arm-obsd-tdep.c: Sort headers.
4426         * arm-nbsd-tdep.c: Sort headers.
4427         * arm-nbsd-nat.c: Sort headers.
4428         * arm-linux-tdep.c: Sort headers.
4429         * arm-linux-nat.c: Sort headers.
4430         * arm-fbsd-tdep.c: Sort headers.
4431         * arm-fbsd-nat.c: Sort headers.
4432         * arm-bsd-tdep.c: Sort headers.
4433         * arch-utils.c: Sort headers.
4434         * arc-tdep.c: Sort headers.
4435         * arc-newlib-tdep.c: Sort headers.
4436         * annotate.h: Sort headers.
4437         * annotate.c: Sort headers.
4438         * amd64-windows-tdep.c: Sort headers.
4439         * amd64-windows-nat.c: Sort headers.
4440         * amd64-tdep.c: Sort headers.
4441         * amd64-sol2-tdep.c: Sort headers.
4442         * amd64-obsd-tdep.c: Sort headers.
4443         * amd64-obsd-nat.c: Sort headers.
4444         * amd64-nbsd-tdep.c: Sort headers.
4445         * amd64-nbsd-nat.c: Sort headers.
4446         * amd64-nat.c: Sort headers.
4447         * amd64-linux-tdep.c: Sort headers.
4448         * amd64-linux-nat.c: Sort headers.
4449         * amd64-fbsd-tdep.c: Sort headers.
4450         * amd64-fbsd-nat.c: Sort headers.
4451         * amd64-dicos-tdep.c: Sort headers.
4452         * amd64-darwin-tdep.c: Sort headers.
4453         * amd64-bsd-nat.c: Sort headers.
4454         * alpha-tdep.c: Sort headers.
4455         * alpha-obsd-tdep.c: Sort headers.
4456         * alpha-nbsd-tdep.c: Sort headers.
4457         * alpha-mdebug-tdep.c: Sort headers.
4458         * alpha-linux-tdep.c: Sort headers.
4459         * alpha-linux-nat.c: Sort headers.
4460         * alpha-bsd-tdep.c: Sort headers.
4461         * alpha-bsd-nat.c: Sort headers.
4462         * aix-thread.c: Sort headers.
4463         * agent.c: Sort headers.
4464         * addrmap.c: Sort headers.
4465         * ada-varobj.c: Sort headers.
4466         * ada-valprint.c: Sort headers.
4467         * ada-typeprint.c: Sort headers.
4468         * ada-tasks.c: Sort headers.
4469         * ada-lang.c: Sort headers.
4470         * aarch64-tdep.c: Sort headers.
4471         * aarch64-ravenscar-thread.c: Sort headers.
4472         * aarch64-newlib-tdep.c: Sort headers.
4473         * aarch64-linux-tdep.c: Sort headers.
4474         * aarch64-linux-nat.c: Sort headers.
4475         * aarch64-fbsd-tdep.c: Sort headers.
4476         * aarch64-fbsd-nat.c: Sort headers.
4477         * aarch32-linux-nat.c: Sort headers.
4478
4479 2019-04-04  Tom Tromey  <tom@tromey.com>
4480
4481         * varobj.c (varobj_create): Update.
4482         * rust-exp.y (struct rust_parser) <update_innermost_block,
4483         lookup_symbol>: New methods.
4484         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4485         Rename.
4486         (rust_parser::rust_lookup_type)
4487         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4488         * printcmd.c (display_command, do_one_display): Update.
4489         * parser-defs.h (struct parser_state) <parser_state>: Add
4490         "tracker" parameter.
4491         (block_tracker): New member.
4492         (class innermost_block_tracker) <innermost_block_tracker>: Add
4493         "types" parameter.
4494         <reset>: Remove method.
4495         (innermost_block): Don't declare.
4496         (null_post_parser): Update.
4497         * parse.c (innermost_block): Remove global.
4498         (write_dollar_variable): Update.
4499         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4500         Remove "tracker_types" parameter.
4501         (parse_expression): Add "tracker" parameter.
4502         (parse_expression_for_completion): Update.
4503         (null_post_parser): Add "tracker" parameter.
4504         * p-exp.y: Update rules.
4505         * m2-exp.y: Update rules.
4506         * language.h (struct language_defn) <la_post_parser>: Add
4507         "tracker" parameter.
4508         * go-exp.y: Update rules.
4509         * f-exp.y: Update rules.
4510         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4511         parameter.
4512         * d-exp.y: Update rules.
4513         * c-exp.y: Update rules.
4514         * breakpoint.c (set_breakpoint_condition): Create an
4515         innermost_block_tracker.
4516         (watch_command_1): Likewise.
4517         * ada-lang.c (resolve): Add "tracker" parameter.
4518         (resolve_subexp): Likewise.
4519         * ada-exp.y (write_var_from_sym): Update.
4520
4521 2019-04-04  Tom Tromey  <tom@tromey.com>
4522
4523         * type-stack.h: New file.
4524         * type-stack.c: New file.
4525         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4526         type-stack.h.
4527         (insert_into_type_stack, insert_type, push_type, push_type_int)
4528         (insert_type_address_space, pop_type, pop_type_int)
4529         (pop_typelist, pop_type_stack, append_type_stack)
4530         (push_type_stack, get_type_stack, push_typelist)
4531         (follow_type_instance_flags, follow_types): Don't declare.
4532         * parse.c (type_stack): Remove global.
4533         (parse_exp_in_context): Update.
4534         (insert_into_type_stack, insert_type, push_type, push_type_int)
4535         (insert_type_address_space, pop_type, pop_type_int)
4536         (pop_typelist, pop_type_stack, append_type_stack)
4537         (push_type_stack, get_type_stack, push_typelist)
4538         (follow_type_instance_flags, follow_types): Remove (moved to
4539         type-stack.c).
4540         * f-exp.y (type_stack): New global.
4541         Update rules.
4542         (push_kind_type, f_parse): Update.
4543         * d-exp.y (type_stack): New global.
4544         Update rules.
4545         (d_parse): Update.
4546         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4547         Update rules.
4548         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4549         (HFILES_NO_SRCDIR): Add type-stack.h.
4550
4551 2019-04-04  Tom Tromey  <tom@tromey.com>
4552
4553         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4554         (rust_parser::convert_ast_to_expression, rust_parse)
4555         (rust_lex_test_completion, rust_lex_tests): Update.
4556         * parser-defs.h (struct expr_completion_state): New.
4557         (struct parser_state) <parser_state>: Add completion parameter.
4558         <mark_struct_expression, mark_completion_tag>: New methods.
4559         <parse_completion, m_completion_state>: New members.
4560         (prefixify_expression, null_post_parser): Update.
4561         (mark_struct_expression, mark_completion_tag): Don't declare.
4562         * parse.c (parse_completion, expout_last_struct)
4563         (expout_tag_completion_type, expout_completion_name): Remove
4564         globals.
4565         (parser_state::mark_struct_expression)
4566         (parser_state::mark_completion_tag): Now methods.
4567         (prefixify_expression): Add last_struct parameter.
4568         (prefixify_subexp): Likewise.
4569         (parse_exp_1): Update.
4570         (parse_exp_in_context): Add cstate parameter.  Update.
4571         (parse_expression_for_completion): Create an
4572         expr_completion_state.
4573         (null_post_parser): Add "completion" parameter.
4574         * p-exp.y: Update rules.
4575         (yylex): Update.
4576         * language.h (struct language_defn) <la_post_parser>: Add
4577         "completing" parameter.
4578         * go-exp.y: Update rules.
4579         (lex_one_token): Update.
4580         * expression.h (parse_completion): Don't declare.
4581         * d-exp.y: Update rules.
4582         (lex_one_token): Update rules.
4583         * c-exp.y: Update rules.
4584         (lex_one_token): Update.
4585         * ada-lang.c (resolve): Add "parse_completion" parameter.
4586         (resolve_subexp): Likewise.
4587         (ada_resolve_function): Likewise.
4588
4589 2019-04-04  Tom Tromey  <tom@tromey.com>
4590
4591         * parser-defs.h (struct parser_state) <start_arglist,
4592         end_arglist>: New methods.
4593         <arglist_len, m_funcall_chain>: New members.
4594         (arglist_len, start_arglist, end_arglist): Don't declare.
4595         * parse.c (arglist_len, funcall_chain): Remove global.
4596         (start_arglist, end_arglist): Remove functions.
4597         (parse_exp_in_context): Update.
4598         * p-exp.y: Update rules.
4599         * m2-exp.y: Update rules.
4600         * go-exp.y: Update rules.
4601         * f-exp.y: Update rules.
4602         * d-exp.y: Update rules.
4603         * c-exp.y: Update rules.
4604
4605 2019-04-04  Tom Tromey  <tom@tromey.com>
4606
4607         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4608         lex_operator, push_back>: New methods.
4609         Update all rules.
4610         (rust_parser::lex_hex, lex_escape): Rename and update.
4611         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4612         (rust_parser::lex_operator): Rename and update.
4613         (rust_parser::lex_number, rustyylex, rustyyerror)
4614         (rust_lex_test_init, rust_lex_test_sequence)
4615         (rust_lex_test_push_back, rust_lex_tests): Update.
4616         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4617         parameter.
4618         <lexptr, prev_lexptr>: New members.
4619         (lexptr, prev_lexptr): Don't declare.
4620         * parse.c (lexptr, prev_lexptr): Remove globals.
4621         (parse_exp_in_context): Update.
4622         * p-exp.y (yylex, yyerror): Update.
4623         * m2-exp.y (parse_number, yylex, yyerror): Update.
4624         * go-exp.y (lex_one_token, yyerror): Update.
4625         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4626         * d-exp.y (lex_one_token, yyerror): Update.
4627         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4628         (lex_one_token, yyerror): Update.
4629         * ada-lex.l (YY_INPUT): Update.
4630         (rewind_to_char): Update.
4631         * ada-exp.y (yyerror): Update.
4632
4633 2019-04-04  Tom Tromey  <tom@tromey.com>
4634
4635         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4636         * parser-defs.h (struct parser_state) <parser_state>: Add new
4637         parameter.
4638         <comma_terminates>: New member.
4639         (comma_terminates): Don't declare global.
4640         * parse.c (comma_terminates): Remove global.
4641         (parse_exp_in_context): Update.
4642         * p-exp.y (yylex): Update.
4643         * m2-exp.y (yylex): Update.
4644         * go-exp.y (lex_one_token): Update.
4645         * f-exp.y (yylex): Update.
4646         * d-exp.y (lex_one_token): Update.
4647         * c-exp.y (lex_one_token): Update.
4648         * ada-lex.l: Update.
4649
4650 2019-04-04  Tom Tromey  <tom@tromey.com>
4651
4652         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4653         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4654         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4655         * parser-defs.h (paren_depth): Don't declare.
4656         * parse.c (paren_depth): Remove global.
4657         (parse_exp_in_context): Update.
4658         * p-exp.y (paren_depth): New global.
4659         (pascal_parse): Initialize it.
4660         * m2-exp.y (paren_depth): New global.
4661         (m2_parse): Initialize it.
4662         * go-exp.y (paren_depth): New global.
4663         (go_parse): Initialize it.
4664         * f-exp.y (paren_depth): New global.
4665         (f_parse): Initialize it.
4666         * d-exp.y (paren_depth): New global.
4667         (d_parse): Initialize it.
4668         * c-exp.y (paren_depth): New global.
4669         (c_parse): Initialize it.
4670         * ada-lex.l (paren_depth): New global.
4671         (lexer_init): Initialize it.
4672
4673 2019-04-04  Tom Tromey  <tom@tromey.com>
4674
4675         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4676         (rust_parser::convert_ast_to_type)
4677         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4678         * parser-defs.h (struct parser_state) <parser_state>: Add
4679         parameters.  Initialize new members.
4680         <expression_context_block, expression_context_pc>: New members.
4681         * parse.c (expression_context_block, expression_context_pc):
4682         Remove globals.
4683         (parse_exp_in_context): Update.
4684         * p-exp.y: Update all rules.
4685         (yylex): Update.
4686         * m2-exp.y: Update all rules.
4687         (yylex): Update.
4688         * go-exp.y (yylex): Update.
4689         * f-exp.y (yylex): Update.
4690         * d-exp.y: Update all rules.
4691         (yylex): Update.
4692         * c-exp.y: Update all rules.
4693         (lex_one_token, classify_name, yylex, c_parse): Update.
4694         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4695
4696 2019-04-04  Tom Tromey  <tom@tromey.com>
4697
4698         * gdbarch.h, gdbarch.c: Rebuild.
4699         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4700         * stap-probe.h:
4701         (struct stap_parse_info): Replace "parser_state" with
4702         "expr_builder".
4703         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4704         (parser_state): New class.
4705         * parse.c (expr_builder): Rename.
4706         (expr_builder::release): Rename.
4707         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4708         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4709         (write_exp_elt_longcst, write_exp_elt_floatcst)
4710         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4711         (write_exp_string_vector, write_exp_bitstring)
4712         (write_exp_msymbol, mark_struct_expression)
4713         (write_dollar_variable)
4714         (insert_type_address_space, increase_expout_size): Replace
4715         "parser_state" with "expr_builder".
4716         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4717         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4718         "parser_state" with "expr_builder".
4719
4720 2019-04-04  Tom Tromey  <tom@tromey.com>
4721
4722         * rust-exp.y: Replace "parse_language" with method call.
4723         * p-exp.y:
4724         (yylex): Replace "parse_language" with method call.
4725         * m2-exp.y:
4726         (yylex): Replace "parse_language" with method call.
4727         * go-exp.y (classify_name): Replace "parse_language" with method
4728         call.
4729         * f-exp.y (yylex): Replace "parse_language" with method call.
4730         * d-exp.y (lex_one_token): Replace "parse_language" with method
4731         call.
4732         * c-exp.y:
4733         (lex_one_token, classify_name, yylex): Replace "parse_language"
4734         with method call.
4735         * ada-exp.y (find_primitive_type, type_char)
4736         (type_system_address): Replace "parse_language" with method call.
4737
4738 2019-04-04  Tom Tromey  <tom@tromey.com>
4739
4740         * rust-exp.y: Replace "parse_gdbarch" with method call.
4741         * parse.c (write_dollar_variable, insert_type_address_space):
4742         Replace "parse_gdbarch" with method call.
4743         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4744         call.
4745         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4746         call.
4747         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4748         "parse_gdbarch" with method call.
4749         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4750         with method call.
4751         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4752         "parse_gdbarch" with method call.
4753         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4754         "parse_gdbarch" with method call.
4755         * c-exp.y (parse_type, parse_number, classify_name): Replace
4756         "parse_gdbarch" with method call.
4757         * ada-lex.l: Replace "parse_gdbarch" with method call.
4758         * ada-exp.y (parse_type, find_primitive_type, type_char)
4759         (type_system_address): Replace "parse_gdbarch" with method call.
4760
4761 2019-04-04  Tom Tromey  <tom@tromey.com>
4762
4763         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4764         * stap-probe.c (stap_parse_argument): Update.
4765         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4766         initial_size parameter.
4767         * rust-exp.y (rust_lex_tests): Update.
4768         * parse.c (parser_state): Update.
4769         (parse_exp_in_context): Update.
4770         * parser-defs.h (struct parser_state) <parser_state>: Remove
4771         "initial_size" parameter.
4772
4773 2019-04-04  Tom Tromey  <tom@tromey.com>
4774
4775         * parser-defs.h (increase_expout_size): Don't declare.
4776         * parse.c (increase_expout_size): Now static.
4777
4778 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4779
4780         * gnu-nat.c (gnu_nat_target::wait): Fix
4781         target_waitstatus_to_string call.
4782
4783 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4784
4785         * eval.c (evaluate_subexp_standard): Handle internal functions
4786         during Fortran function call handling.
4787
4788 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4789
4790         * NEWS: Mention new internal functions.
4791         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4792         (read_base_type): Use dwarf2_init_complex_target_type.
4793         * value.c (creal_internal_fn): New function.
4794         (cimag_internal_fn): New function.
4795         (_initialize_values): Register new internal functions.
4796
4797 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4798
4799         * infrun.c (stop_all_threads): If debug_infrun, always
4800         trace the wait status after wait_one, using
4801         target_waitstatus_to_string and target_pid_to_str.
4802         (handle_inferior_event): Replace various trace of
4803         wait status kind by a single trace.
4804         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4805         wait status kind image by target_waitstatus_to_string.
4806         * target/waitstatus.c (target_waitstatus_to_string): Fix
4807         obsolete comment.
4808
4809 2019-04-01  Tom Tromey  <tromey@adacore.com>
4810
4811         PR symtab/23331:
4812         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4813
4814 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4815             Pedro Alves  <palves@redhat.com>
4816
4817         * top.c (quit_force): Call 'finalize_values'.
4818         * value.c (finalize_values): New function.
4819         * value.h (finalize_values): Declare.
4820
4821 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4822
4823         * NEWS: Announce $_gdb_major and $_gdb_minor.
4824
4825         * top.c (init_gdb_version_vars): New function.
4826         (gdb_init): Call init_gdb_version_vars.
4827
4828 2019-03-29  Tom Tromey  <tromey@adacore.com>
4829
4830         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4831         help text.  Remove dead code.
4832
4833 2019-03-29  Keith Seitz  <keiths@redhat.com>
4834
4835         From Siddhesh Poyarekar:
4836         * f-lang.h (f77_get_upperbound): Return LONGEST.
4837         (f77_get_lowerbound): Likewise.
4838         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4839         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4840         print them.
4841         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4842         plongest to format print it.
4843         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4844         (f77_get_upperbound): Likewise.
4845         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4846         LOWER_BOUND to LONGEST.
4847         (f77_create_arrayprint_offset_tbl): Likewise.
4848
4849 2019-03-29  Keith Seitz  <keiths@redhat.com>
4850
4851         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4852         %s/pulongest for TYPE_LENGTH instead of %d in format
4853         strings.
4854         * ada-typerint.c (ada_print_type): Likewise.
4855         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4856         * compile/compile-c-support.c (generate_register_struct): Likewise.
4857         * gdbtypes.c (recursive_dump_type): Likewise.
4858         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4859         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4860         instead of %d in format strings.
4861         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4862         to std::min to ULONGEST.
4863         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4864         instead of %d in format strings.
4865         * tracepoint.c (info_scope_command): Likewise.
4866         * typeprint.c (print_offset_data::update)
4867         (print_offset_data::finish): Likewise.
4868         * xtensa-tdep.c (xtensa_store_return_value)
4869         (xtensa_push_dummy_call): Likewise.
4870
4871 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4872
4873         * windows-nat.c (display_selector): Fixed format specifications
4874         for 64-bit Cygwin.
4875
4876 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4877
4878         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4879
4880 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4881
4882         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4883         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4884         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4885         (nios2_linux_init_abi): Install it.
4886
4887 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4888
4889         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4890
4891 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4892
4893         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4894
4895 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4896             Tom Tromey  <tromey@adacore.com>
4897
4898         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4899
4900 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4901
4902         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4903         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4904         method to compute the bounds of range types. Also print "[evaluated]"
4905         if the bounds' values come from a dynamic evaluation.
4906
4907 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4910         whitespace when pretty printing is on.
4911
4912 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4913
4914         * ppc-linux-nat.c: Add include.
4915
4916 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4917
4918         * NEWS: Mention AArch64 Pointer Authentication.
4919
4920 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4921
4922         * arm-linux-nat.c: Add include.
4923
4924 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4925
4926         * source-cache.c (source_cache::get_source_lines): Re-read
4927         fullname after calling open_source_file.
4928
4929 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4930
4931         * NEWS: Mention TLS support for FreeBSD.
4932
4933 2019-03-25  Tom Tromey  <tromey@adacore.com>
4934
4935         * minsyms.c (BUNCH_SIZE): Update comment.
4936         (~minimal_symbol_reader): Remove old comment.
4937         (compact_minimal_symbols): Update comment.
4938         (minimal_symbol_reader::install): Remove old comment.  Update
4939         other comments.
4940
4941 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4942
4943         * s390-linux-nat.c: Add include.
4944
4945 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4946
4947         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4948         Call linux_get_hwcap.
4949         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4950         Likewise.
4951         (aarch64_linux_get_hwcap): Remove function.
4952         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4953         declaration.
4954         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4955         linux_get_hwcap.
4956         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4957         * linux-tdep.c (linux_get_hwcap): Add function.
4958         (linux_get_hwcap2): Likewise.
4959         * linux-tdep.h (linux_get_hwcap): Add declaration.
4960         (linux_get_hwcap2): Likewise.
4961         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4962         (ppc_linux_get_hwcap2): Likewise.
4963         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4964         linux_get_hwcap.
4965         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4966         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4967         (ppc_linux_nat_target::read_description): Likewise.
4968         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4969         * s390-linux-nat.c: Likewise.
4970         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4971
4972 2019-03-24  Tom Tromey  <tom@tromey.com>
4973
4974         * ada-lang.c (standard_lookup): Simplify initialization.
4975         (ada_lookup_symbol_nonlocal): Simplify return.
4976         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4977         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4978         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4979         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4980         initialization.
4981         * solib.c (solib_global_lookup): Simplify.
4982         * symtab.c (null_block_symbol): Remove.
4983         (symbol_cache_lookup): Simplify returns.
4984         (lookup_language_this): Simplify returns.
4985         (lookup_symbol_aux): Simplify return.
4986         (lookup_local_symbol): Simplify returns.
4987         (lookup_global_symbol_from_objfile): Simplify return.
4988         (lookup_symbol_in_objfile_symtabs)
4989         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4990         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4991         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4992         * cp-namespace.c (cp_lookup_bare_symbol)
4993         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4994         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4995         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4996         (cp_lookup_symbol_via_imports): Simplify initialization.
4997         (find_symbol_in_baseclass): Likewise.
4998         * symtab.h (null_block_symbol): Remove.
4999         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5000         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5001         (d_lookup_symbol_module): Likewise.
5002         (find_symbol_in_baseclass): Simplify initialization.
5003
5004 2019-03-24  Tom Tromey  <tom@tromey.com>
5005
5006         * expression.h: Don't include symtab.h.
5007         (struct block): Forward declare.
5008
5009 2019-03-24  Tom Tromey  <tom@tromey.com>
5010
5011         * c-exp.y (typebase): Remove casts.
5012         * gdbtypes.c (lookup_unsigned_typename, )
5013         (lookup_signed_typename): Remove cast.
5014         * eval.c (parse_to_comma_and_eval): Remove cast.
5015         * parse.c (write_dollar_variable): Remove cast.
5016         * block.h (struct block) <superblock>: Now const.
5017         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5018         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5019         (map_block): Make "block" const.
5020         * symfile.h (struct quick_symbol_functions)
5021         <map_matching_symbols>: Constify block argument to "callback".
5022         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5023         const.
5024         (find_pc_sect_compunit_symtab): Make "b" const.
5025         (find_symbol_at_address): Likewise.
5026         (search_symbols): Likewise.
5027         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5028         (dw2_debug_names_lookup_symbol): Likewise.
5029         (dw2_map_matching_symbols): Update.
5030         * p-valprint.c (pascal_val_print): Remove "block".
5031         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5032         (aux_add_nonlocal_symbols): Make "block" const.
5033         (resolve_subexp): Remove cast.
5034         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5035         const.
5036         (iterate_over_file_blocks): Likewise.
5037         * f-exp.y (%union) <bval>: Remove.
5038         * coffread.c (patch_opaque_types): Make "b" const.
5039         * spu-tdep.c (spu_catch_start): Make "block" const.
5040         * c-valprint.c (print_unpacked_pointer): Remove "block".
5041         * symmisc.c (dump_symtab_1): Make "b" const.
5042         (block_depth): Make "block" const.
5043         * d-exp.y (%union) <bval>: Remove.
5044         * cp-support.h (cp_lookup_rtti_type): Update.
5045         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5046         * psymtab.c (psym_lookup_symbol): Make "block" const.
5047         (maintenance_check_psymtabs): Make "b" const.
5048         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5049         (enumerate_locals, enumerate_args): Update.
5050         * python/py-symtab.c (stpy_global_block): Make "block" const.
5051         (stpy_static_block): Likewise.
5052         * inline-frame.c (block_starting_point_at): Make "new_block"
5053         const.
5054         * block.c (find_block_in_blockvector): Make return type const.
5055         (blockvector_for_pc_sect): Make "b" const.
5056         (find_block_in_blockvector): Make "b" const.
5057
5058 2019-03-23  Tom Tromey  <tom@tromey.com>
5059
5060         * varobj.c (varobj_create): Update.
5061         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5062         * printcmd.c (display_command, do_one_display): Don't reset
5063         innermost_block.
5064         * parser-defs.h (enum innermost_block_tracker_type): Move to
5065         expression.h.
5066         (innermost_block): Update comment.
5067         * parse.c (parse_exp_1): Add tracker_types parameter.
5068         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5069         tracker_types parameter.  Reset innermost_block.
5070         (parse_exp_in_context): Remove.
5071         (parse_expression_for_completion): Update.
5072         * objfiles.c (~objfile): Don't reset expression_context_block or
5073         innermost_block.
5074         * expression.h (enum innermost_block_tracker_type): Move from
5075         parser-defs.h.
5076         (parse_exp_1): Add tracker_types parameter.
5077         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5078         reset innermost_block.
5079
5080 2019-03-23  Tom Tromey  <tom@tromey.com>
5081
5082         * objfiles.h: Include bcache.h.
5083
5084 2019-03-23  Tom Tromey  <tom@tromey.com>
5085
5086         * linespec.c (get_current_search_block): Use
5087         scoped_restore_current_language.
5088         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5089
5090 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5091             Jiong Wang  <jiong.wang@arm.com>
5092
5093         * aarch64-linux-tdep.c
5094         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5095         section.
5096         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5097
5098 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5099             Jiong Wang  <jiong.wang@arm.com>
5100
5101         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5102         instructions.
5103         (aarch64_analyze_prologue_test): Add PACIASP test.
5104         (aarch64_prologue_prev_register): Unmask PC value.
5105
5106 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5107             Jiong Wang  <jiong.wang@arm.com>
5108
5109         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5110         (aarch64_dwarf2_prev_register): Unmask PC value.
5111         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5112         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5113         DW_CFA_AARCH64_negate_ra_state.
5114         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5115
5116 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5117             Jiong Wang  <jiong.wang@arm.com>
5118
5119         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5120         registers.
5121         (aarch64_pseudo_register_name): Likewise.
5122         (aarch64_pseudo_register_type): Likewise.
5123         (aarch64_pseudo_register_reggroup_p): Likewise.
5124         (aarch64_gdbarch_init): Add pauth registers.
5125         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5126         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5127         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5128         (struct gdbarch_tdep): Add regnum for ra_state.
5129
5130 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5131             Jiong Wang  <jiong.wang@arm.com>
5132
5133         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5134
5135 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5136             Jiong Wang  <jiong.wang@arm.com>
5137
5138         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5139         function.
5140         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5141         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5142         (aarch64_gdbarch_init): Add puth registers.
5143         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5144         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5145         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5146
5147 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5148             Jiong Wang  <jiong.wang@arm.com>
5149
5150         * aarch64-linux-nat.c
5151         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5152         * aarch64-linux-tdep.c
5153         (aarch64_linux_core_read_description): Likewise.
5154         (aarch64_linux_get_hwcap): New function.
5155         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5156         (aarch64_linux_get_hwcap): New declaration.
5157
5158 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5159             Jiong Wang  <jiong.wang@arm.com>
5160
5161         * aarch64-linux-nat.c
5162         (aarch64_linux_nat_target::read_description): Add pauth param.
5163         * aarch64-linux-tdep.c
5164         (aarch64_linux_core_read_description): Likewise.
5165         * aarch64-tdep.c (struct target_desc): Add in pauth.
5166         (aarch64_read_description): Add pauth param.
5167         (aarch64_gdbarch_init): Likewise.
5168         * aarch64-tdep.h (aarch64_read_description): Likewise.
5169         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5170         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5171         * features/Makefile: Add new files.
5172         * features/aarch64-pauth.c: New file.
5173         * features/aarch64-pauth.xml: New file.
5174
5175 2019-03-20  Tom Tromey  <tromey@adacore.com>
5176
5177         * infrun.c (handle_inferior_event): Rename from
5178         handle_inferior_event_1.  Create a scoped_value_mark.
5179         (handle_inferior_event): Remove.
5180
5181 2019-03-19  Tom Tromey  <tromey@adacore.com>
5182
5183         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5184         * infrun.h (print_stop_event): Add "displays" parameter.
5185         * infrun.c (print_stop_event): Add "displays" parameter.
5186
5187 2019-03-19  Pedro Alves  <palves@redhat.com>
5188
5189         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5190         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5191         to -1.  Fix TABs vs spaces.
5192         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5193         * tui/tui-out.h (tui_ui_out) Add intro comments.
5194         <m_line, m_start_of_line>: In-class initialize, and add describing
5195         comment.
5196
5197 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5198
5199         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5200         variable names.
5201         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5202
5203 2019-03-18  Pedro Alves  <palves@redhat.com>
5204             Eli Zaretskii <eliz@gnu.org>
5205
5206         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5207         m_line and m_start_of_line.
5208
5209 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5210
5211         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5212         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5213         it returns a newline.  This fixes a regression in TU mode, whereby
5214         the next line is output on the same screen line as the user input.
5215
5216 2019-03-18  Tom Tromey  <tromey@adacore.com>
5217
5218         * minsyms.c (minimal_symbol_reader::install): Remove call to
5219         obstack_blank.
5220
5221 2019-03-18  Pedro Alves  <palves@redhat.com>
5222
5223         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5224         New globals.
5225         (apply_style): New, factored out from ...
5226         (apply_ansi_escape): ... this.  Handle reverse video mode.
5227         (tui_set_reverse_mode): New function.
5228         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5229         * tui/tui-winsource.c (tui_show_source_line): Use
5230         tui_set_reverse_mode instead of setting A_STANDOUT.
5231         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5232         New setter methods.
5233
5234 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5235
5236         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5237         Handle tabs.
5238
5239 2019-03-18  Tom Tromey  <tromey@adacore.com>
5240
5241         * ada-lang.c (empty_array): Add "high" parameter.
5242         (ada_evaluate_subexp): Update.
5243
5244 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5245
5246         * unittests/string_view-selftests.c: Define
5247         _initialize_string_view_selftests unconditionally.
5248
5249 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5250
5251         PR gdb/24350
5252         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5253
5254 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5255
5256         PR gdb/24351
5257         * windows-nat.c (display_selector): Fix format specifiers.
5258
5259 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5260
5261         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5262         tui_refill_source_window instead of tui_refresh_win, to update the
5263         current execution line.  This fixes redisplay of the current line
5264         when stepping through the code with "next" or "step".
5265
5266 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5267
5268         * source-cache.c (source_cache::get_source_lines): Call
5269         find_source_lines to initialize s->nlines.  This fixes vertical
5270         scrolling of TUI source window when the DOWN arrow is pressed.
5271
5272 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5273
5274         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5275         linux-thread-db.c (_initialize_thread_db): Likewise.
5276
5277 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5278
5279         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5280         wclrtoeol in tui_show_source_line".  This reverts changes made in
5281         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5282
5283 2019-03-15  Tom Tromey  <tom@tromey.com>
5284
5285         * symtab.h (struct minimal_symbol): Derive from
5286         general_symbol_info.
5287         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5288         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5289         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5290         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5291         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5292         (MSYMBOL_SEARCH_NAME): Update.
5293         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5294         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5295         * minsyms.c (minimal_symbol_reader::record_full): Update.
5296
5297 2019-03-15  Tom Tromey  <tom@tromey.com>
5298
5299         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5300
5301 2019-03-15  Tom Tromey  <tom@tromey.com>
5302
5303         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5304         unique_xmalloc_ptr.
5305         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5306         Update.
5307         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5308         (build_minimal_symbol_hash_tables)
5309         (minimal_symbol_reader::install): Update.
5310
5311 2019-03-15  Tom Tromey  <tom@tromey.com>
5312
5313         * symtab.c (create_demangled_names_hash): Update.
5314         (symbol_set_names): Update.
5315         * objfiles.h (struct objfile_per_bfd_storage)
5316         <demangled_names_hash>: Now an htab_up.
5317         * objfiles.c (objfile_per_bfd_storage): Simplify.
5318
5319 2019-03-15  Tom Tromey  <tom@tromey.com>
5320
5321         * objfiles.h (struct objfile_per_bfd_storage): Declare
5322         destructor.
5323         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5324         New.
5325         (get_objfile_bfd_data): Use new.  Don't initialize
5326         language_of_main.
5327         (free_objfile_per_bfd_storage): Remove.
5328         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5329
5330 2019-03-15  Tom Tromey  <tom@tromey.com>
5331
5332         * symfile.c (reread_symbols): Update.
5333         * objfiles.c (objfile::objfile): Update.
5334         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5335         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5336         comment.
5337         (minimal_symbol_reader::install): Update.
5338         (terminate_minimal_symbol_table): Remove.
5339         * jit.c (jit_object_close_impl): Update.
5340
5341 2019-03-15  Tom Tromey  <tom@tromey.com>
5342
5343         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5344         initializations.
5345
5346 2019-03-15  Tom Tromey  <tom@tromey.com>
5347
5348         * objfiles.h (struct objfile_per_bfd_storage)
5349         <demangled_hash_languages>: Now a bitset.
5350         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5351         (lookup_minimal_symbol): Update.
5352
5353 2019-03-15  Tom Tromey  <tom@tromey.com>
5354
5355         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5356         Don't return the symbol.
5357         * coffread.c (record_minimal_symbol): Use record_full.
5358
5359 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5360
5361         The MS-Windows port of ncurses fails to switch to a color pair if
5362         one or both of the colors are the implicit default colors.  This
5363         change records the default colors when TUI is initialized, and
5364         then specifies them explicitly when a color pair uses the default
5365         colors.  This allows color styling in TUI mode on MS-Windows.
5366
5367         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5368         ncurses_norm_attr.
5369         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5370         colors in ncurses_norm_attr.
5371         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5372         "none", replace it with the default color recorded in
5373         ncurses_norm_attr.
5374
5375 2019-03-14  Tom Tromey  <tromey@adacore.com>
5376
5377         * source-cache.h (class source_cache) <get_source_lines>: Return
5378         std::string.
5379         * source-cache.c (source_cache::extract_lines): Handle case where
5380         first_pos==npos.  Return std::string.
5381         (source_cache::get_source_lines): Update.
5382
5383 2019-03-14  Tom Tromey  <tromey@adacore.com>
5384
5385         * NEWS: Add item for "style sources" commands.
5386         * source-cache.c (source_cache::get_source_lines): Check
5387         source_styling.
5388         * cli/cli-style.c (source_styling): New global.
5389         (_initialize_cli_style): Add "style sources" commands.
5390         (show_style_sources): New function.
5391         * cli/cli-style.h (source_styling): Declare.
5392
5393 2019-03-14  Pedro Alves  <palves@redhat.com>
5394             Tom Tromey  <tromey@adacore.com>
5395
5396         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5397         * tui/tui-winsource.c (tui_refill_source_window): New function,
5398         from...
5399         (tui_horizontal_source_scroll): ... here.  Move some logic.
5400         * cli/cli-style.c (set_style_enabled): Notify new observable.
5401         * tui/tui-hooks.c (tui_redisplay_source): New function.
5402         (tui_attach_detach_observers): Attach or detach
5403         tui_redisplay_source.
5404         * observable.h (source_styling_changed): New observable.
5405         * observable.c: Define source_styling_changed observable.
5406
5407 2019-03-13  Tom Tromey  <tromey@adacore.com>
5408
5409         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5410         (i386_gnu_nat_target::store_registers): Update.
5411         * target-debug.h (target_debug_print_std_string): New macro.
5412         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5413         * windows-tdep.c (display_one_tib): Update.
5414         * tui/tui-stack.c (tui_make_status_line): Update.
5415         * top.c (print_inferior_quit_action): Update.
5416         * thread.c (thr_try_catch_cmd): Update.
5417         (add_thread_with_info): Update.
5418         (thread_target_id_str): Update.
5419         (thr_try_catch_cmd): Update.
5420         (thread_command): Update.
5421         (thread_find_command): Update.
5422         * record-btrace.c (record_btrace_target::info_record)
5423         (record_btrace_resume_thread, record_btrace_target::resume)
5424         (record_btrace_cancel_resume, record_btrace_step_thread)
5425         (record_btrace_target::wait, record_btrace_target::wait)
5426         (record_btrace_target::wait, record_btrace_target::stop): Update.
5427         * progspace.c (print_program_space): Update.
5428         * process-stratum-target.c
5429         (process_stratum_target::thread_address_space): Update.
5430         * linux-fork.c (linux_fork_mourn_inferior)
5431         (detach_checkpoint_command, info_checkpoints_command)
5432         (linux_fork_context): Update.
5433         (linux_fork_detach): Update.
5434         (class scoped_switch_fork_info): Update.
5435         (delete_checkpoint_command): Update.
5436         * infrun.c (follow_fork_inferior): Update.
5437         (follow_fork_inferior): Update.
5438         (proceed_after_vfork_done): Update.
5439         (handle_vfork_child_exec_or_exit): Update.
5440         (follow_exec): Update.
5441         (displaced_step_prepare_throw): Update.
5442         (displaced_step_restore): Update.
5443         (start_step_over): Update.
5444         (resume_1): Update.
5445         (clear_proceed_status_thread): Update.
5446         (proceed): Update.
5447         (print_target_wait_results): Update.
5448         (do_target_wait): Update.
5449         (context_switch): Update.
5450         (stop_all_threads): Update.
5451         (restart_threads): Update.
5452         (finish_step_over): Update.
5453         (handle_signal_stop): Update.
5454         (switch_back_to_stepped_thread): Update.
5455         (keep_going_pass_signal): Update.
5456         (print_exited_reason): Update.
5457         (normal_stop): Update.
5458         * inferior.c (inferior_pid_to_str): Change return type.
5459         (print_selected_inferior): Update.
5460         (add_inferior): Update.
5461         (detach_inferior): Update.
5462         * dummy-frame.c (fprint_dummy_frames): Update.
5463         * dcache.c (dcache_info_1): Update.
5464         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5465         (btrace_fetch, btrace_clear): Update.
5466         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5467         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5468         type.
5469         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5470         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5471         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5472         * gdbarch.c, gdbarch.h: Rebuild.
5473         * gdbarch.sh (core_pid_to_str): Change return type.
5474         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5475         return type.
5476         (windows_nat_target::pid_to_str): Change return type.
5477         (windows_delete_thread): Update.
5478         (windows_nat_target::attach): Update.
5479         (windows_nat_target::files_info): Update.
5480         * target-delegates.c: Rebuild.
5481         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5482         return type.
5483         (sol_thread_target::pid_to_str): Change return type.
5484         * remote.c (class remote_target) <pid_to_str>: Change return
5485         type.
5486         (remote_target::pid_to_str): Change return type.
5487         (extended_remote_target::attach, remote_target::remote_stop_ns)
5488         (remote_target::remote_notif_remove_queued_reply)
5489         (remote_target::push_stop_reply, remote_target::disable_btrace):
5490         Update.
5491         (extended_remote_target::attach): Update.
5492         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5493         type.
5494         (gdbsim_target::pid_to_str): Change return type.
5495         * ravenscar-thread.c (struct ravenscar_thread_target)
5496         <pid_to_str>: Change return type.
5497         (ravenscar_thread_target::pid_to_str): Change return type.
5498         * procfs.c (class procfs_target) <pid_to_str>: Change return
5499         type.
5500         (procfs_target::pid_to_str): Change return type.
5501         (procfs_target::attach): Update.
5502         (procfs_target::detach): Update.
5503         (procfs_target::fetch_registers): Update.
5504         (procfs_target::store_registers): Update.
5505         (procfs_target::wait): Update.
5506         (procfs_target::files_info): Update.
5507         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5508         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5509         return type.
5510         (nto_procfs_target::pid_to_str): Change return type.
5511         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5512         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5513         return type.
5514         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5515         (exit_lwp): Update.
5516         (attach_proc_task_lwp_callback, get_detach_signal)
5517         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5518         (linux_nat_target::resume, wait_lwp, stop_callback)
5519         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5520         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5521         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5522         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5523         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5524         type.
5525         (inf_ptrace_target::attach): Update.
5526         (inf_ptrace_target::files_info): Update.
5527         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5528         type.
5529         (go32_nat_target::pid_to_str): Change return type.
5530         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5531         (gnu_nat_target::wait): Update.
5532         (gnu_nat_target::wait): Update.
5533         (gnu_nat_target::resume): Update.
5534         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5535         (fbsd_nat_target::wait): Update.
5536         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5537         type.
5538         (darwin_nat_target::attach): Update.
5539         * corelow.c (class core_target) <pid_to_str>: Change return type.
5540         (core_target::pid_to_str): Change return type.
5541         * target.c (normal_pid_to_str): Change return type.
5542         (default_pid_to_str): Likewise.
5543         (target_pid_to_str): Change return type.
5544         (target_translate_tls_address): Update.
5545         (target_announce_detach): Update.
5546         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5547         return type.
5548         (bsd_uthread_target::pid_to_str): Change return type.
5549         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5550         type.
5551         (bsd_kvm_target::pid_to_str): Change return type.
5552         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5553         return type.
5554         (aix_thread_target::pid_to_str): Change return type.
5555         * target.h (struct target_ops) <pid_to_str>: Change return type.
5556         (target_pid_to_str, normal_pid_to_str): Likewise.
5557         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5558         type.
5559         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5560         type.
5561         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5562         return type.
5563         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5564         type.
5565         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5566         type.
5567         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5568         return type.
5569
5570 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5571
5572         * NEWS: Mention that the new default MI version is 3.  Mention
5573         changes to the output of commands and events that deal with
5574         multi-location breakpoints.
5575         * breakpoint.c: Include "mi/mi-out.h".
5576         (print_one_breakpoint): Change output syntax if using MI version
5577         >= 3.
5578         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5579         New.
5580         (mi_multi_location_breakpoint_output_fixed): New.
5581         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5582         (mi_cmd_fix_multi_location_breakpoint_output): New.
5583         (mi_multi_location_breakpoint_output_fixed): New.
5584         * mi/mi-cmds.c (mi_cmds): Register command
5585         -fix-multi-location-breakpoint-output.
5586         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5587         interpreter "mi".
5588
5589 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5590
5591         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5592         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5593         instantiate mi_ui_out based on interpreter name.
5594         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5595         * mi/mi-main.c (mi_load_progress): Likewise.
5596
5597 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5598
5599         * NEWS: Combine separate "New targets" sections for 8.3.
5600
5601 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5602
5603         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5604         (ppcfbsd_init_abi): Install gdbarch
5605         "fetch_tls_load_module_address" and "get_thread_local_address"
5606         methods.
5607
5608 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5609
5610         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5611         (riscv_fbsd_init_abi): Install gdbarch
5612         "fetch_tls_load_module_address" and "get_thread_local_address"
5613         methods.
5614
5615 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5616
5617         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5618         (i386fbsd_init_abi): Install gdbarch
5619         "fetch_tls_load_module_address" and "get_thread_local_address"
5620         methods.
5621
5622 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5623
5624         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5625         (amd64fbsd_init_abi): Install gdbarch
5626         "fetch_tls_load_module_address" and "get_thread_local_address"
5627         methods.
5628
5629 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5630
5631         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5632         (struct fbsd_pspace_data): New type.
5633         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5634         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5635         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5636         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5637         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5638
5639 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5640
5641         * gdbtypes.c (lookup_struct_elt): New function.
5642         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5643         * gdbtypes.h (struct struct_elt): New type.
5644         (lookup_struct_elt): New prototype.
5645
5646 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5647
5648         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5649         remove disabled code block.
5650
5651 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5652
5653         * gdbarch.sh (get_thread_local_address): New method.
5654         * gdbarch.h, gdbarch.c: Regenerate.
5655         * target.c (target_translate_tls_address): Use
5656         gdbarch_get_thread_local_address if present instead of
5657         target::get_thread_local_address.
5658
5659 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5660
5661         * target.h (target::get_thread_local_address): Update comment.
5662
5663 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5664
5665         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5666         objfile->separate_debug_objfile_backlink if not NULL.
5667
5668 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5669
5670         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5671         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5672         (amd64bsd_store_inferior_registers): Likewise.
5673         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5674         Enable segment base registers.
5675         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5676         PT_GETFSBASE and PT_GETGSBASE.
5677         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5678         PT_SETGSBASE.
5679         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5680         segment base registers.
5681         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5682
5683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5684
5685         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5686         Update calls to i386_target_description to add 'segments'
5687         parameter.
5688         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5689         add segment base registers.
5690         * arch/i386.c (i386_create_target_description): Add 'segments'
5691         parameter to enable segment base registers.
5692         * arch/i386.h (i386_create_target_description): Likewise.
5693         * features/i386/32bit-segments.xml: New file.
5694         * features/i386/32bit-segments.c: Generate.
5695         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5696         call to i386_target_description to add 'segments' parameter.
5697         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5698         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5699         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5700         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5701         if feature is present.
5702         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5703         Add 'segments' parameter to call to i386_target_description.
5704         (i386_target_description): Add 'segments' parameter to enable
5705         segment base registers.
5706         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5707         to call to i386_target_description.
5708         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5709         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5710         Define I386_NUM_REGS.
5711         (i386_target_description): Add 'segments' parameter to enable
5712         segment base registers.
5713
5714 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5715
5716         PR/24325
5717         * source-cache.c: #undef open and close, to avoid unresolved
5718         externals during linking.
5719
5720 2019-03-12  Tom Tromey  <tromey@adacore.com>
5721
5722         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5723         const.  Add initializers.
5724         (_initialize_remote): Don't initialize ptid globals.
5725
5726 2019-03-12  Pedro Alves  <palves@redhat.com>
5727
5728         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5729
5730 2019-03-12  Pedro Alves  <palves@redhat.com>
5731
5732         * cp-name-parser.y (main): Remove unused 'len' variable.
5733
5734 2019-03-12  Tom Tromey  <tromey@adacore.com>
5735
5736         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5737         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5738
5739 2019-03-12  Tom Tromey  <tromey@adacore.com>
5740
5741         * linux-nat.c (iterate_over_lwps): Update.
5742         (stop_callback): Remove parameter.
5743         (stop_wait_callback, detach_callback, resume_set_callback)
5744         (select_singlestep_lwp_callback, set_ignore_sigint)
5745         (status_callback, resumed_callback, resume_clear_callback)
5746         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5747         data parameter.
5748         (linux_nat_target::detach, linux_nat_target::resume)
5749         (linux_stop_and_wait_all_lwps, select_event_lwp)
5750         (linux_nat_filter_event, linux_nat_wait_1)
5751         (linux_nat_target::kill, linux_nat_target::stop)
5752         (linux_nat_target::stop): Update.
5753         (linux_nat_resume_callback): Change type.
5754         (resume_stopped_resumed_lwps, count_events_callback)
5755         (select_event_lwp_callback): Likewise.
5756         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5757         * arm-linux-nat.c (struct update_registers_data): Remove.
5758         (update_registers_callback): Change type.
5759         (arm_linux_insert_hw_breakpoint1): Update.
5760         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5761         parameter.
5762         (x86_linux_dr_set_addr): Update.
5763         (x86_linux_dr_set_control): Update.
5764         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5765         (iterate_over_lwps): Use gdb::function_view.
5766         * nat/aarch64-linux-hw-point.c (struct
5767         aarch64_dr_update_callback_param): Remove.
5768         (debug_reg_change_callback): Change type.
5769         (aarch64_notify_debug_reg_change): Update.
5770         * s390-linux-nat.c (s390_refresh_per_info): Update.
5771
5772 2019-03-11  Tom Tromey  <tromey@adacore.com>
5773
5774         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5775         redundant assignment to "this_cu".
5776
5777 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5778
5779         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5780
5781 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5782
5783         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5784         from...
5785         (rank_one_type): ... this.
5786
5787 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5788
5789         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5790         from...
5791         (rank_one_type): ... this.
5792
5793 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5794
5795         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5796         from...
5797         (rank_one_type): ... this.
5798
5799 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5800
5801         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5802         from...
5803         (rank_one_type): ... this.
5804
5805 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5806
5807         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5808         from...
5809         (rank_one_type): ... this.
5810
5811 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5812
5813         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5814         from...
5815         (rank_one_type): ... this.
5816
5817 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5818
5819         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5820         from...
5821         (rank_one_type): ... this.
5822
5823 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5824
5825         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5826         from...
5827         (rank_one_type): ... this.
5828
5829 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5830
5831         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5832         from...
5833         (rank_one_type): ... this.
5834
5835 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5836
5837         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5838         from...
5839         (rank_one_type): ... this.
5840
5841 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5842
5843         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5844         from...
5845         (rank_one_type): ... this.
5846
5847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5848
5849         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5850         from...
5851         (rank_one_type): ... this.
5852
5853 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5854
5855         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5856         inferior-events' shows the example events.
5857
5858 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5859
5860         Support styling on native MS-Windows console
5861
5862         PR/24315
5863         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5864         on MS-Windows if $TERM is not defined.
5865
5866         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5867
5868         * posix-hdep.c (gdb_console_fputs):
5869         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5870         functions.
5871         * ui-file.h (gdb_console_fputs): Add prototype.
5872
5873         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5874         back to fputs only if the former returns zero.
5875
5876 2019-03-07  Tom Tromey  <tom@tromey.com>
5877
5878         * symmisc.c (print_symbol_bcache_statistics): Update.
5879         (print_objfile_statistics): Update.
5880         * symfile.c (allocate_symtab): Update.
5881         * stabsread.c: Don't include bcache.h.
5882         * psymtab.h (struct psymbol_bcache): Don't declare.
5883         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5884         (psymbol_bcache_init, psymbol_bcache_free)
5885         (psymbol_bcache_get_bcache): Don't declare.
5886         * psymtab.c (struct psymbol_bcache): Remove.
5887         (psymtab_storage::psymtab_storage): Update.
5888         (psymtab_storage::~psymtab_storage): Update.
5889         (psymbol_bcache_init, psymbol_bcache_free)
5890         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5891         (add_psymbol_to_bcache): Update.
5892         (allocate_psymtab): Update.
5893         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5894         macro_cache>: No longer pointers.
5895         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5896         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5897         * macrotab.c (macro_bcache): Update.
5898         * macroexp.c: Don't include bcache.h.
5899         * gdbtypes.c (check_types_worklist): Update.
5900         (types_deeply_equal): Remove TRY/CATCH.  Update.
5901         * elfread.c (elf_symtab_read): Update.
5902         * dwarf2read.c: Don't include bcache.h.
5903         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5904         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5905         (print_bcache_statistics, bcache_memory_used): Don't declare.
5906         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5907         methods.  Rename all data members.
5908         * bcache.c (struct bcache): Move to bcache.h.
5909         (bcache::expand_hash_table): Rename from expand_hash_table.
5910         (bcache): Remove.
5911         (bcache::insert): Rename from bcache_full.
5912         (bcache::compare): Rename from bcache_compare.
5913         (bcache_xmalloc): Remove.
5914         (bcache::~bcache): Rename from bcache_xfree.
5915         (bcache::print_statistics): Rename from print_bcache_statistics.
5916         (bcache::memory_used): Rename from bcache_memory_used.
5917
5918 2019-03-07  Pedro Alves  <palves@redhat.com>
5919
5920         * infrun.c (normal_stop): Also check for
5921         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5922
5923 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5924
5925         * f-lang.c (value_from_host_double): Moved to...
5926         * value.c (value_from_host_double): ...here.
5927         * value.h (value_from_host_double): Declare.
5928         * guile/scm-math.c (vlscm_convert_typed_number): Use
5929         value_from_host_double.
5930         (vlscm_convert_number): Likewise.
5931         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5932         * python/py-value.c (convert_value_from_python): Likewise.
5933
5934 2019-03-06  Tom Tromey  <tom@tromey.com>
5935
5936         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5937
5938 2019-03-06  Tom Tromey  <tom@tromey.com>
5939
5940         * utils.h (free_current_contents): Don't declare.
5941         * utils.c (free_current_contents): Remove.
5942
5943 2019-03-06  Tom Tromey  <tom@tromey.com>
5944
5945         * top.c (quit_force): Update.
5946         * main.c (captured_command_loop): Update.
5947         * common/new-op.c (operator new): Update.
5948         * common/common-exceptions.c (struct catcher)
5949         <save_cleanup_chain>: Remove member.
5950         (exceptions_state_mc_init): Update.
5951         (exception_try_scope_entry): Return nullptr.
5952         (exception_try_scope_exit, exception_rethrow)
5953         (throw_exception_sjlj, throw_exception_cxx): Update.
5954         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5955         (all_cleanups, do_cleanups, discard_cleanups)
5956         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5957         (restore_cleanups, restore_final_cleanups): Don't declare.
5958         (do_final_cleanups): Remove parameter.
5959         * common/cleanups.c (cleanup_chain, make_cleanup)
5960         (make_cleanup_dtor, all_cleanups, do_cleanups)
5961         (discard_my_cleanups, discard_cleanups)
5962         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5963         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5964         (null_cleanup): Remove.
5965         (do_final_cleanups): Remove parameter.
5966
5967 2019-03-06  Tom Tromey  <tom@tromey.com>
5968
5969         * remote.c (remote_target::remote_parse_stop_reply): Use
5970         unique_xmalloc_ptr.
5971
5972 2019-03-06  Tom Tromey  <tom@tromey.com>
5973
5974         * stabsread.c (struct stabs_field_info): Rename from field_info.
5975         <list, fnlist>: Add initializers.
5976         <obstack>: New member.
5977         (read_member_functions, read_struct_fields, read_baseclasses):
5978         Allocate on obstack.  Don't use cleanups.
5979         (read_one_struct_field, read_member_functions, read_struct_fields)
5980         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5981         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5982         (read_struct_type): Update.
5983
5984 2019-03-06  Tom Tromey  <tom@tromey.com>
5985
5986         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5987         * common/filestuff.h (make_cleanup_close): Don't declare.
5988         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5989         Remove.
5990
5991 2019-03-06  Tom Tromey  <tom@tromey.com>
5992
5993         * solib-aix.c: Use make_scope_exit.
5994
5995 2019-03-06  Tom Tromey  <tom@tromey.com>
5996
5997         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5998         Use make_scope_exit.
5999
6000 2019-03-06  Tom Tromey  <tom@tromey.com>
6001
6002         * solib-svr4.c (disable_probes_interface): Remove parameter.
6003         (svr4_handle_solib_event): Use make_scope_exit.
6004
6005 2019-03-06  Tom Tromey  <tom@tromey.com>
6006
6007         * remote.c (struct stop_reply_deleter): Remove.
6008         (stop_reply_up): Update.
6009         (struct stop_reply): Derive from notif_event.  Don't typedef.
6010         <regcache>: Now a std::vector.
6011         (stop_reply_xfree): Remove.
6012         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6013         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6014         (remote_target::discard_pending_stop_replies): Use delete.
6015         (remote_target::remote_parse_stop_reply): Update.
6016         (remote_target::process_stop_reply): Update.
6017         * remote-notif.h (struct notif_event): Add virtual destructor.
6018         Remove "dtr" member.
6019         (struct notif_client) <alloc_event>: Return a unique_ptr.
6020         (notif_event_xfree): Don't declare.
6021         (notif_event_up): New typedef.
6022         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6023         (notif_event_xfree, do_notif_event_xfree): Remove.
6024         (remote_notif_state_xfree): Update.
6025
6026 2019-03-06  Tom Tromey  <tom@tromey.com>
6027
6028         * infrun.c (displaced_step_clear_cleanup): Now a
6029         forward_scope_exit type.
6030         (displaced_step_prepare_throw): Update.
6031         (displaced_step_fixup): Update.
6032
6033 2019-03-06  Tom Tromey  <tom@tromey.com>
6034
6035         * inferior.h (class inferior): Update comment.
6036         * gdbthread.h (class thread_info): Update comment.
6037
6038 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6039             Tom Tromey  <tom@tromey.com>
6040
6041         * stabsread.h (struct stab_section_list): Remove.
6042         (coffstab_build_psymtabs): Update.
6043         * dbxread.c (symbuf_sections): Now a std::vector.
6044         (sect_idx): New global.
6045         (fill_symbuf): Update.
6046         (coffstab_build_psymtabs): Change type of stabsects parameter.
6047         Update.
6048         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6049         std::vector.
6050         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6051         (coff_locate_sections): Update.
6052         (coff_symfile_read): Remove cleanups.  Update.
6053         (init_stringtab): Add storage parameter.
6054         (free_stringtab, free_stringtab_cleanup): Remove.
6055         (init_lineno): Add storage parameter.
6056         (free_linetab, free_linetab_cleanup): Remove.
6057
6058 2019-03-06  Pedro Alves  <palves@redhat.com>
6059
6060         * linux-fork.c (fork_info::clobber_regs): Delete.
6061         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6062         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6063         comment.  Adjust.
6064         (scoped_switch_fork_info::scoped_switch_fork_info)
6065         (checkpoint_command, linux_fork_context): Adjust
6066         fork_save_infrun_state calls.
6067
6068 2019-03-06  Pedro Alves  <palves@redhat.com>
6069
6070         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6071         (inf_has_multiple_threads): Return 'bool' and rewrite using
6072         inferior_info::threads().
6073
6074 2019-03-06  Pedro Alves  <palves@redhat.com>
6075
6076         * linux-fork.c: Include <list>.
6077         (fork_list): Now a std::list instance.
6078         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6079         (forks_exist_p, find_last_fork): Adjust.
6080         (new_fork): Delete.
6081         (one_fork_p): New.
6082         (add_fork): Adjust.
6083         (free_fork): Delete, folded into fork_info::~fork_info().
6084         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6085         Adjust.
6086         (init_fork_list): Delete.
6087         (linux_fork_killall, linux_fork_mourn_inferior)
6088         (linux_fork_detach, info_checkpoints_command): Adjust.
6089         (_initialize_linux_fork): No longer call init_fork_list.
6090
6091 2019-03-06  Pedro Alves  <palves@redhat.com>
6092
6093         * linux-fork.c (new_fork): New, split out of ...
6094         (add_fork): ... this.  Return void.  Move "first fork" special
6095         case from here, to ...
6096         (checkpoint_command): ... here.
6097         * linux-linux.h (add_fork): Return void.
6098
6099 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6100
6101         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6102
6103 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6104             Chris January  <chris.january@arm.com>
6105             David Lecomber  <david.lecomber@arm.com>
6106
6107         * f-exp.y: New token, UNOP_INTRINSIC.
6108         (exp): New pattern using UNOP_INTRINSIC token.
6109         (f77_keywords): Add 'abs' keyword.
6110         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6111         (value_from_host_double): New function.
6112         (evaluate_subexp_f): Support UNOP_ABS.
6113
6114 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6115
6116         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6117         types.
6118
6119 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6120
6121         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6122         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6123         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6124
6125 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6126
6127         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6128
6129 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6130             Chris January  <chris.january@arm.com>
6131
6132         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6133         * f-exp.y: Define 'KIND' token.
6134         (exp): New pattern for KIND expressions.
6135         (ptype): Handle types with a kind extension.
6136         (direct_abs_decl): Extend to spot kind extensions.
6137         (f77_keywords): Add 'kind' to the list.
6138         (push_kind_type): New function.
6139         (convert_to_kind_type): New function.
6140         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6141         * parse.c (operator_length_standard): Likewise.
6142         * parser-defs.h (enum type_pieces): Add tp_kind.
6143         * std-operator.def: Add UNOP_KIND.
6144
6145 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6146
6147         * f-exp.y (f_parse): Set yydebug.
6148
6149 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6150
6151         * f-lang.c (evaluate_subexp_f): New function.
6152         (exp_descriptor_f): New global.
6153         (f_language_defn): Use exp_descriptor_f instead of
6154         exp_descriptor_standard.
6155
6156 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * f-exp.y (struct token): Add comments.
6159         (dot_ops): Remove uppercase versions and the end marker.
6160         (f77_keywords): Likewise.
6161         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6162         entries in the dot_ops array are case insensitive, and use
6163         strncasecmp to compare strings.  Also some whitespace cleanup in
6164         this area.  Similar for the f77_keywords array, except entries in
6165         this list might be case sensitive.
6166
6167 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6168
6169         * f-exp.y (struct f77_boolean_val): Add comments.
6170         (boolean_values): Remove uppercase versions, and end marker.
6171         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6172         and use strncasecmp to achieve case insensitivity.  Additionally,
6173         perform whitespace cleanup around this code.
6174
6175 2019-03-06  Tom Tromey  <tromey@adacore.com>
6176
6177         * remote-sim.c (gdbsim_target_open): Use result of
6178         gdb_argv::release.
6179
6180 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6181         Dirk Schubert  <dirk.schubert@arm.com>
6182         Chris January  <chris.january@arm.com>
6183
6184         * eval.c (evaluate_subexp_standard): Call Fortran argument
6185         wrapping logic.
6186         * f-lang.c (struct value): A value which can be passed into a
6187         Fortran function call.
6188         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6189         where appropriate.
6190         (struct type): Value ready for a Fortran function call.
6191         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6192         is needed.
6193         * f-lang.h (fortran_argument_convert): Declaration.
6194         (fortran_preserve_arg_pointer): Declaration.
6195         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6196
6197 2019-03-05  Tom Tromey  <tromey@adacore.com>
6198
6199         * python/py-prettyprint.c (print_string_repr): Remove #if.
6200         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6201
6202 2019-03-05  Tom Tromey  <tromey@adacore.com>
6203
6204         * target.c (the_dummy_target): Move later.  Change type to
6205         "dummy_target".
6206         (initialize_targets): Don't initialize the_dummy_target.
6207
6208 2019-03-05  Tom Tromey  <tromey@adacore.com>
6209
6210         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6211         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6212
6213 2019-03-05  Tom Tromey  <tromey@adacore.com>
6214
6215         * windows-nat.c (windows_nat_target::attach)
6216         (windows_nat_target::detach): Don't call gdb_flush.
6217         * valprint.c (generic_val_print, val_print, val_print_string):
6218         Don't call gdb_flush.
6219         * utils.c (defaulted_query): Don't call gdb_flush.
6220         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6221         * target.c (target_announce_detach): Don't call gdb_flush.
6222         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6223         * remote.c (extended_remote_target::attach): Don't call
6224         gdb_flush.
6225         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6226         * printcmd.c (do_examine): Don't call gdb_flush.
6227         (info_display_command): Don't call gdb_flush.
6228         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6229         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6230         * memattr.c (info_mem_command): Don't call gdb_flush.
6231         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6232         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6233         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6234         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6235         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6236         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6237         (gnu_nat_target::detach): Don't call gdb_flush.
6238         * f-valprint.c (f_val_print): Don't call gdb_flush.
6239         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6240         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6241         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6242         gdb_flush.
6243         * c-valprint.c (c_val_print): Don't call gdb_flush.
6244         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6245
6246 2019-03-05  Tom Tromey  <tromey@adacore.com>
6247
6248         * varobj.c (update_dynamic_varobj_children): Update.
6249         (install_default_visualizer): Use reset, not release.
6250         * value.c (set_internalvar): Update.
6251         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6252         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6253         ATTRIBUTE_UNUSED_RESULT.
6254
6255 2019-03-05  Tom Tromey  <tromey@adacore.com>
6256
6257         * remote.c (class scoped_remote_fd) <release>: Add
6258         ATTRIBUTE_UNUSED_RESULT.
6259
6260 2019-03-05  Tom Tromey  <tromey@adacore.com>
6261
6262         * macroexp.c (struct macro_buffer) <release>: Add
6263         ATTRIBUTE_UNUSED_RESULT.
6264
6265 2019-03-05  Tom Tromey  <tromey@adacore.com>
6266
6267         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6268         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6269         ATTRIBUTE_UNUSED_RESULT.
6270
6271 2019-03-05  Tom Tromey  <tromey@adacore.com>
6272
6273         * common/scoped_fd.h (class scoped_fd) <release>: Add
6274         ATTRIBUTE_UNUSED_RESULT.
6275
6276 2019-03-05  Tom Tromey  <tromey@adacore.com>
6277
6278         * parser-defs.h (struct parser_state) <release>: Add
6279         ATTRIBUTE_UNUSED_RESULT.
6280
6281 2019-03-05  Tom Tromey  <tromey@adacore.com>
6282
6283         * utils.h (class gdb_argv) <release>: Add
6284         ATTRIBUTE_UNUSED_RESULT.
6285         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6286
6287 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6288
6289         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6290         for-loop range, to avoid compiler warnings.
6291
6292         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6293         avoid compiler warnings about unused variables.
6294
6295         * NEWS: Mention end of support for native debugging on MS-Windows
6296         before XP.
6297
6298         PR gdb/24292
6299         * common/netstuff.c:
6300         * gdbserver/gdbreplay.c
6301         * gdbserver/remote-utils.c:
6302         * ser-tcp.c:
6303         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6304         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6305         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6306         'getaddrinfo' and 'freeaddrinfo' were not available before
6307         Windows XP, and mingw.org's MinGW headers by default define
6308         _WIN32_WINNT to 0x500.
6309
6310 2019-03-01  Gary Benson <gbenson@redhat.com>
6311
6312         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6313
6314 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6315             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6316
6317         PR gdb/8527
6318         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6319         set_sigint_trap, clear_sigint_trap.
6320
6321 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6322
6323         * target.c (target_detach): Clear the regcache and the
6324         frame cache.
6325
6326 2019-02-27  Pedro Alves  <palves@redhat.com>
6327
6328         * utils.c (set_screen_size): When we cap the height/width sizes,
6329         tweak the corresponding command variable to show "unlimited":
6330
6331 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6332             Pedro Alves  <palves@redhat.com>
6333
6334         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6335         before calling rl_set_screen_size.
6336
6337 2019-02-27  Tom Tromey  <tromey@adacore.com>
6338
6339         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6340         define.
6341         * python/py-value.c: Remove Python 2.4 workaround.
6342         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6343         workaround.
6344         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6345         Python 2.4 workaround.
6346         * python/python-internal.h: Remove Python 2.4 comment.
6347         (Py_ssize_t): Don't define.
6348         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6349         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6350         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6351         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6352         * python/python.c (do_start_initialization): Remove Python 2.4
6353         workaround.
6354         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6355         (print_children): Remove Python 2.4 workaround.
6356         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6357         workaround.
6358         (CHARBUFFERPROC_NAME): Remove.
6359         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6360         Python 2.4 workaround.
6361
6362 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6363
6364         * NEWS: Note minimum Python version.
6365
6366 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6367
6368         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6369         code from these functions.  Remove corresponding ifdefs.  Use
6370         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6371         Remove gotos and target of gotos.
6372         (infpy_search_memory): Likewise.
6373
6374 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6375
6376         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6377         (hppa_gdbarch_init): Don't register deleted functions with
6378         gdbarch.
6379
6380 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6381
6382         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6383         (h8300_unwind_sp): Delete.
6384         (h8300_dummy_id): Delete.
6385         (h8300_gdbarch_init): Don't register deleted functions with
6386         gdbarch.
6387
6388 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6389
6390         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6391         (ft32_unwind_pc): Delete.
6392         (ft32_unwind_sp): Delete.
6393         (ft32_gdbarch_init): Don't register deleted functions with
6394         gdbarch.
6395
6396 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6397
6398         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6399         (frv_unwind_pc): Delete.
6400         (frv_unwind_sp): Delete.
6401         (frv_gdbarch_init): Don't register deleted functions with
6402         gdbarch.
6403
6404 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6405
6406         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6407         (riscv_unwind_pc): Delete.
6408         (riscv_unwind_sp): Delete.
6409         (riscv_gdbarch_init): Don't register deleted functions with
6410         gdbarch.
6411
6412 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6413
6414         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6415         (csky_unwind_pc): Delete.
6416         (csky_unwind_sp): Delete.
6417         (csky_gdbarch_init): Don't register deleted functions with
6418         gdbarch.
6419
6420 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6421
6422         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6423         (cris_unwind_pc): Delete.
6424         (cris_unwind_sp): Delete.
6425         (cris_gdbarch_init): Don't register deleted functions with
6426         gdbarch.
6427
6428 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6429
6430         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6431         (bfin_unwind_pc): Delete.
6432         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6433
6434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6437         (arm_unwind_pc): Delete.
6438         (arm_unwind_sp): Delete.
6439         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6440
6441 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6442
6443         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6444         (arc_unwind_pc): Delete.
6445         (arc_unwind_sp): Delete.
6446         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6447
6448 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6449
6450         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6451         (alpha_unwind_pc): Delete.
6452         (alpha_gdbarch_init): Don't register deleted functions with
6453         gdbarch.
6454
6455 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6456
6457         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6458         (aarch64_unwind_pc): Delete.
6459         (aarch64_unwind_sp): Delete.
6460         (aarch64_gdbarch_init): Don't register deleted functions with
6461         gdbarch.
6462
6463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6464
6465         * gdbtypes.c (type_align): Don't consider static members when
6466         computing structure alignment.
6467
6468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6469
6470         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6471         return 0 for other types.
6472         * arch-utils.c (default_type_align): Always return 0.
6473         * gdbarch.h: Regenerate.
6474         * gdbarch.sh (type_align): Extend comment.
6475         * gdbtypes.c (type_align): Add additional comments, always call
6476         gdbarch_type_align before applying the default rules.
6477         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6478         generic code will then apply a suitable default.
6479         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6480         types, return 0 for other types.
6481
6482 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6483
6484         * NEWS: Create a new section for the next release branch.
6485         Rename the section of the current branch, now that it has
6486         been cut.
6487
6488 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6489
6490         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6491         * version.in: Bump version to 8.3.50.DATE-git.
6492
6493 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6494
6495         * aix-thread.c (ptid_cmp): Remove unused variable.
6496         (get_signaled_thread): Likewise.
6497         (store_regs_user_thread): Likewise.
6498         (store_regs_kernel_thread): Likewise.
6499         (fetch_regs_kernel_thread): Remove shadowed variable.
6500
6501 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6502
6503         * features/riscv/32bit-cpu.xml: Add register numbers.
6504         * features/riscv/32bit-fpu.c: Regenerate.
6505         * features/riscv/32bit-fpu.xml: Add register numbers.
6506         * features/riscv/64bit-cpu.xml: Add register numbers.
6507         * features/riscv/64bit-fpu.c: Regenerate.
6508         * features/riscv/64bit-fpu.xml: Add register numbers.
6509
6510 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6511
6512         * NEWS: Mention two argument form of gdb.Value constructor.
6513         * python/py-value.c (convert_buffer_and_type_to_value): New
6514         function.
6515         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6516         Add support for handling an optional second argument.  Call
6517         convert_buffer_and_type_to_value as appropriate.
6518         * python/python-internal.h (Py_buffer_deleter): New struct.
6519         (Py_buffer_up): New typedef.
6520
6521 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6522
6523         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6524         instead of releasing ownership.
6525
6526 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6527
6528         * dwarf2read.c (open_and_init_dwp_file): Call
6529         elf_numsections instead of bfd_count_sections to initialize
6530         dwp_file->num_sections.
6531
6532 2019-02-25  Tom Tromey  <tromey@adacore.com>
6533
6534         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6535
6536 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6537
6538         * gcore.in: Add '--readnever' option when invoking GDB.
6539
6540 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6541
6542         * MAINTAINERS: Update my email address.
6543
6544 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6545
6546         * build-id.c (build_id_to_debug_bfd_1): New function.
6547         (build_id_to_debug_bfd): Look for separate debug file in
6548         sysroot.
6549
6550 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6551
6552         * gdbarch.sh: Update the copyright year range that is placed into
6553         generated files.
6554
6555 2019-02-22  Keith Seitz  <keiths@redhat.com>
6556
6557         PR symtab/23853
6558         * linespec.c (create_sals_line_offset): Search for the default
6559         symtab's filename instead of its fullname.
6560
6561 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6562
6563         * NEWS: Update style defaults.
6564
6565 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6566
6567         * main.c (captured_main_1): Disable styling in batch mode.
6568
6569 2019-02-20  Tom Tromey  <tom@tromey.com>
6570
6571         * symtab.c (symtab_symbol_info): Fix typos.
6572
6573 2019-02-20  Tom Tromey  <tromey@adacore.com>
6574
6575         * findcmd.c (_initialize_mem_search): Use upper case for
6576         metasyntactic variables.
6577
6578 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6579
6580         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6581         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6582
6583 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6584
6585         * top.h (source_file_name): Change to std::string.
6586         * top.c (source_file_name): Likewise.
6587         (command_line_input): Adjust.
6588         * cli/cli-script.c (script_from_file): Adjust.
6589
6590 2019-02-19  Tom Tromey  <tromey@adacore.com>
6591
6592         * ravenscar-thread.c
6593         (ravenscar_thread_target::update_thread_list): Don't call
6594         ada_build_task_list.
6595         * ada-lang.h (ada_build_task_list): Don't declare.
6596         * ada-tasks.c (struct ada_tasks_inferior_data)
6597         <task_list_valid_p>: Now bool.
6598         (read_known_tasks, ada_task_list_changed)
6599         (ada_tasks_invalidate_inferior_data): Update.
6600         (read_known_tasks_array): Return bool.
6601         (read_known_tasks_list): Likewise.
6602         (read_known_tasks): Return void.
6603         (ada_build_task_list): Now static.
6604
6605 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6606
6607         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6608         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6609
6610 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6611
6612         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6613         variant for ada_tasks_pspace_data_handle and
6614         ada_tasks_inferior_data_handle.
6615         (ada_tasks_pspace_data_cleanup): New function.
6616         (ada_tasks_inferior_data_cleanup): New function.
6617
6618 2019-02-17  Tom Tromey  <tom@tromey.com>
6619
6620         * macrotab.h (macro_source_fullname): Return a std::string.
6621         * macrotab.c (macro_include, check_for_redefinition)
6622         (macro_undef, macro_lookup_definition, foreach_macro)
6623         (foreach_macro_in_scope): Update.
6624         (macro_source_fullname): Return a std::string.
6625         * macrocmd.c (show_pp_source_pos): Update.
6626
6627 2019-02-17  Tom Tromey  <tom@tromey.com>
6628
6629         * macrocmd.c (show_pp_source_pos): Style the file names.
6630
6631 2019-02-17  Tom Tromey  <tom@tromey.com>
6632
6633         PR tui/24197:
6634         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6635
6636 2019-02-17  Tom Tromey  <tom@tromey.com>
6637
6638         * ada-lang.c (user_select_syms): Use filtered printing.
6639         * utils.c (wrap_style): New global.
6640         (desired_style): Remove.
6641         (emit_style_escape): Add stream parameter.
6642         (set_output_style, reset_terminal_style, prompt_for_continue):
6643         Update.
6644         (flush_wrap_buffer): Only flush gdb_stdout.
6645         (wrap_here): Set wrap_style.
6646         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6647         treat escape sequences as a character.  Change when wrap buffer is
6648         flushed.
6649         (fputs_styled): Do not set the output style when the default is
6650         requested.
6651         * ui-style.h (struct ui_file_style) <is_default>: New method.
6652         * source.c (print_source_lines_base): Emit escape sequences in one
6653         piece.
6654
6655 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6656
6657         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6658         integers and enumeration types.
6659
6660 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6661
6662         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6663         instead of lookup_symbol_in_language
6664         (do_exact_match): New function.
6665         (ada_get_symbol_name_matcher): Return do_exact_match when
6666         doing a verbatim match.
6667
6668 2019-02-15  Tom Tromey  <tromey@adacore.com>
6669
6670         * ravenscar-thread.c (ravenscar_thread_target::resume)
6671         (ravenscar_thread_target::wait): Special case wildcard requests.
6672
6673 2019-02-15  Tom Tromey  <tromey@adacore.com>
6674
6675         * ravenscar-thread.c (base_ptid): Remove.
6676         (struct ravenscar_thread_target) <close>: New method.
6677         <m_base_ptid>: New member.
6678         <update_inferior_ptid, active_task, task_is_currently_active,
6679         runtime_initialized>: Declare methods.
6680         <ravenscar_thread_target>: Add constructor.
6681         (ravenscar_thread_target::task_is_currently_active)
6682         (ravenscar_thread_target::update_inferior_ptid)
6683         (ravenscar_runtime_initialized): Rename.  Now methods.
6684         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6685         (ravenscar_thread_target::update_thread_list): Update.
6686         (ravenscar_thread_target::active_task): Now method.
6687         (ravenscar_thread_target::store_registers)
6688         (ravenscar_thread_target::prepare_to_store)
6689         (ravenscar_thread_target::prepare_to_store)
6690         (ravenscar_thread_target::mourn_inferior): Update.
6691         (ravenscar_inferior_created): Use "new" to create target.
6692         (ravenscar_thread_target::get_ada_task_ptid): Update.
6693         (_initialize_ravenscar): Don't initialize base_ptid.
6694         (ravenscar_ops): Remove global.
6695
6696 2019-02-15  Tom Tromey  <tromey@adacore.com>
6697
6698         * target.h (push_target): Declare new overload.
6699         * target.c (push_target): New overload, taking an rvalue reference.
6700         * remote.c (remote_target::open_1): Use push_target overload.
6701         * corelow.c (core_target_open): Use push_target overload.
6702
6703 2019-02-15  Tom Tromey  <tromey@adacore.com>
6704
6705         * ravenscar-thread.c (is_ravenscar_task)
6706         (ravenscar_task_is_currently_active): Return bool.
6707         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6708         (_initialize_ravenscar): Remove "(void)".
6709         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6710         Return bool.
6711
6712 2019-02-15  Tom Tromey  <tromey@adacore.com>
6713
6714         * ravenscar-thread.c (ravenscar_runtime_initializer)
6715         (has_ravenscar_runtime, get_running_thread_id)
6716         (ravenscar_thread_target::resume): Fix indentation.
6717
6718 2019-02-15  Tom Tromey  <tromey@adacore.com>
6719
6720         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6721         from ravenscar_arch_ops.
6722         (sparc_ravenscar_ops::fetch_registers)
6723         (sparc_ravenscar_ops::store_registers): Now methods.
6724         (sparc_ravenscar_prepare_to_store): Remove.
6725         (sparc_ravenscar_ops): Redefine.
6726         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6727         methods and destructor.  Remove members.
6728         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6729         (ravenscar_thread_target::store_registers)
6730         (ravenscar_thread_target::prepare_to_store): Update.
6731         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6732         Remove.
6733         (struct ppc_ravenscar_powerpc_ops): Derive from
6734         ravenscar_arch_ops.
6735         (ppc_ravenscar_powerpc_ops::fetch_registers)
6736         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6737         (ppc_ravenscar_powerpc_ops): Redefine.
6738         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6739         (ppc_ravenscar_e500_ops::fetch_registers)
6740         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6741         (ppc_ravenscar_e500_ops): Redefine.
6742         * aarch64-ravenscar-thread.c
6743         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6744         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6745         (aarch64_ravenscar_fetch_registers)
6746         (aarch64_ravenscar_store_registers): Now methods.
6747         (aarch64_ravenscar_ops): Redefine.
6748
6749 2019-02-15  Tom Tromey  <tromey@adacore.com>
6750
6751         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6752         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6753         (ravenscar_thread_target::stopped_by_watchpoint)
6754         (ravenscar_thread_target::stopped_data_address)
6755         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6756
6757 2019-02-15  Tom Tromey  <tromey@adacore.com>
6758
6759         * ravenscar-thread.c: Fix some typos.
6760
6761 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6762             Tom Tromey  <tromey@adacore.com>
6763
6764         * ada-lang.c (ada_exception_sal): Change addr_string to a
6765         std::string.
6766         (create_ada_exception_catchpoint): Update.
6767
6768 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6769             Tom Tromey  <tromey@adacore.com>
6770
6771         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6772         (bp_location_ops): Remove.
6773         (base_breakpoint_allocate_location): Update.
6774         (free_bp_location): Update.
6775         * ada-lang.c (class ada_catchpoint_location)
6776         <ada_catchpoint_location>: Remove ops parameter.
6777         (ada_catchpoint_location_dtor): Remove.
6778         (ada_catchpoint_location_ops): Remove.
6779         (allocate_location_exception): Update.
6780         * breakpoint.h (struct bp_location_ops): Remove.
6781         (class bp_location) <bp_location>: Remove bp_location_ops
6782         parameter.
6783         <~bp_location>: Add destructor.
6784         <ops>: Remove.
6785
6786 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6787             Pedro Alves  <palves@redhat.com>
6788
6789         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6790         'PATH_MAX'.
6791
6792 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6793             Samuel Thibault  <samuel.thibault@gnu.org>
6794             Thomas Schwinge  <thomas@codesourcery.com>
6795
6796         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6797         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6798
6799 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6800
6801         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6802         (check_empty): Use "const char *".
6803
6804         * gnu-nat.c (gnu_nat_target::detach): Instead of
6805         'detach_inferior (pid)' call
6806         'detach_inferior (find_inferior_pid (pid))'.
6807
6808         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6809         'nat/fork-inferior.o'.
6810         * gnu-nat.c: #include "nat/fork-inferior.h".
6811
6812         * gnu-nat.c (gnu_nat_target::detach): Instead of
6813         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6814         * gnu-nat.h: #include "inf-child.h".
6815         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6816         'i386_gnu_nat_target::fetch_registers'.
6817         (gnu_store_registers): Rename/move to
6818         'i386_gnu_nat_target::store_registers'.
6819
6820         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6821         * gnu-nat.h (mach_thread_info): New function.
6822         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6823
6824         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6825
6826 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6827
6828         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6829
6830 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6831
6832         * windows-nat.c (windows_add_thread): Add new parameter
6833         "main_thread_p" with default value set to false.  Update
6834         function documentation as well as all callers.
6835         (windows_delete_thread): Likewise.
6836         (fake_create_process): Update call to windows_add_thread.
6837         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6838         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6839         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6840         call to windows_delete_thread.
6841
6842 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6843
6844         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6845
6846 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6847
6848         * symfile.c (find_separate_debug_file): Use canonical path of
6849         sysroot with child_path instead of gdb_sysroot if it is valid.
6850
6851 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6852
6853         * symfile.c (find_separate_debug_file): Use child_path to
6854         determine if an object file is under a sysroot.
6855
6856 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6857
6858         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6859         unittests/child-path-selftests.c.
6860         * common/pathstuff.c (child_path): New function.
6861         * common/pathstuff.h (child_path): New prototype.
6862         * unittests/child-path-selftests.c: New file.
6863
6864 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6865
6866         * symfile.c (find_separate_debug_file): Look for separate debug
6867         files in debug directories under the sysroot.
6868
6869 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6870
6871         * symtab.h (struct minimal_symbol data_p): New const method.
6872         (struct minimal_symbol text_p): Likewise.
6873         * symtab.c (output_source_filename): Use file name style
6874         to print file name.
6875         (print_symbol_info): Likewise.
6876         (print_msymbol_info): Use address style to print addresses.
6877         Use function name style to print executable text symbols.
6878         (expand_symtab_containing_pc): Use data_p.
6879         (find_pc_sect_compunit_symtab): Likewise.
6880
6881 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6882
6883         * breakpoint.c (describe_other_breakpoints): Use address style
6884         to print addresses.
6885         (say_where): Likewise.
6886
6887 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6888
6889         * ada-typeprint.c (print_func_type): Print function name
6890         style to print function name.
6891         * c-typeprint.c (c_print_type_1): Likewise.
6892
6893 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6894
6895         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6896         for execve.
6897
6898 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6899
6900         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6901         type_stack.
6902
6903 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6904
6905         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6906         TYPE_CODE_REF types.
6907
6908 2019-02-08  Jim Wilson  <jimw@sifive.com>
6909
6910         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6911         (riscv_linux_fregset): New.
6912         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6913
6914 2019-02-07  Tom Tromey  <tom@tromey.com>
6915
6916         * thread.c (thread_cancel_execution_command): Update.
6917         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6918         methods.
6919         (struct thread_fsm_ops): Remove.
6920         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6921         (thread_fsm_should_stop, thread_fsm_return_value)
6922         (thread_fsm_set_finished, thread_fsm_finished_p)
6923         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6924         Don't declare.
6925         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6926         * infrun.c (clear_proceed_status_thread)
6927         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6928         (print_stop_event): Update.
6929         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6930         Add constructor.
6931         (step_command_fsm_ops): Remove.
6932         (new_step_command_fsm): Remove.
6933         (step_1): Update.
6934         (step_command_fsm::should_stop): Rename from
6935         step_command_fsm_should_stop.
6936         (step_command_fsm::clean_up): Rename from
6937         step_command_fsm_clean_up.
6938         (step_command_fsm::do_async_reply_reason): Rename from
6939         step_command_fsm_async_reply_reason.
6940         (struct until_next_fsm): Inherit from thread_fsm.  Add
6941         constructor.
6942         (until_next_fsm_ops): Remove.
6943         (new_until_next_fsm): Remove.
6944         (until_next_fsm::should_stop): Rename from
6945         until_next_fsm_should_stop.
6946         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6947         (until_next_fsm::do_async_reply_reason): Rename from
6948         until_next_fsm_async_reply_reason.
6949         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6950         constructor.  Change type of breakpoint.
6951         (finish_command_fsm_ops): Remove.
6952         (new_finish_command_fsm): Remove.
6953         (finish_command_fsm::should_stop): Rename from
6954         finish_command_fsm_should_stop.
6955         (finish_command_fsm::clean_up): Rename from
6956         finish_command_fsm_clean_up.
6957         (finish_command_fsm::return_value): Rename from
6958         finish_command_fsm_return_value.
6959         (finish_command_fsm::do_async_reply_reason): Rename from
6960         finish_command_fsm_async_reply_reason.
6961         (finish_command): Update.
6962         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6963         Add constructor.
6964         (call_thread_fsm_ops): Remove.
6965         (call_thread_fsm::call_thread_fsm): Rename from
6966         new_call_thread_fsm.
6967         (call_thread_fsm::should_stop): Rename from
6968         call_thread_fsm_should_stop.
6969         (call_thread_fsm::should_notify_stop): Rename from
6970         call_thread_fsm_should_notify_stop.
6971         (run_inferior_call, call_function_by_hand_dummy): Update.
6972         * cli/cli-interp.c (should_print_stop_to_console): Update.
6973         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6974         Add constructor.  Change type of location_breakpoint,
6975         caller_breakpoint.
6976         (until_break_fsm_ops): Remove.
6977         (new_until_break_fsm): Remove.
6978         (until_break_fsm::should_stop): Rename from
6979         until_break_fsm_should_stop.
6980         (until_break_fsm::clean_up): Rename from
6981         until_break_fsm_clean_up.
6982         (until_break_fsm::do_async_reply_reason): Rename from
6983         until_break_fsm_async_reply_reason.
6984         (until_break_command): Update.
6985         * thread-fsm.c: Remove.
6986         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6987
6988 2019-02-07  Tom Tromey  <tom@tromey.com>
6989
6990         * yy-remap.h: Add include guard.
6991         * xtensa-tdep.h: Add include guard.
6992         * xcoffread.h: Rename include guard.
6993         * varobj-iter.h: Add include guard.
6994         * tui/tui.h: Rename include guard.
6995         * tui/tui-winsource.h: Rename include guard.
6996         * tui/tui-wingeneral.h: Rename include guard.
6997         * tui/tui-windata.h: Rename include guard.
6998         * tui/tui-win.h: Rename include guard.
6999         * tui/tui-stack.h: Rename include guard.
7000         * tui/tui-source.h: Rename include guard.
7001         * tui/tui-regs.h: Rename include guard.
7002         * tui/tui-out.h: Rename include guard.
7003         * tui/tui-layout.h: Rename include guard.
7004         * tui/tui-io.h: Rename include guard.
7005         * tui/tui-hooks.h: Rename include guard.
7006         * tui/tui-file.h: Rename include guard.
7007         * tui/tui-disasm.h: Rename include guard.
7008         * tui/tui-data.h: Rename include guard.
7009         * tui/tui-command.h: Rename include guard.
7010         * tic6x-tdep.h: Add include guard.
7011         * target/waitstatus.h: Rename include guard.
7012         * target/wait.h: Rename include guard.
7013         * target/target.h: Rename include guard.
7014         * target/resume.h: Rename include guard.
7015         * target-float.h: Rename include guard.
7016         * stabsread.h: Add include guard.
7017         * rs6000-tdep.h: Add include guard.
7018         * riscv-fbsd-tdep.h: Add include guard.
7019         * regformats/regdef.h: Rename include guard.
7020         * record.h: Rename include guard.
7021         * python/python.h: Rename include guard.
7022         * python/python-internal.h: Rename include guard.
7023         * python/py-stopevent.h: Rename include guard.
7024         * python/py-ref.h: Rename include guard.
7025         * python/py-record.h: Rename include guard.
7026         * python/py-record-full.h: Rename include guard.
7027         * python/py-record-btrace.h: Rename include guard.
7028         * python/py-instruction.h: Rename include guard.
7029         * python/py-events.h: Rename include guard.
7030         * python/py-event.h: Rename include guard.
7031         * procfs.h: Add include guard.
7032         * proc-utils.h: Add include guard.
7033         * p-lang.h: Add include guard.
7034         * or1k-tdep.h: Rename include guard.
7035         * observable.h: Rename include guard.
7036         * nto-tdep.h: Rename include guard.
7037         * nat/x86-linux.h: Rename include guard.
7038         * nat/x86-linux-dregs.h: Rename include guard.
7039         * nat/x86-gcc-cpuid.h: Add include guard.
7040         * nat/x86-dregs.h: Rename include guard.
7041         * nat/x86-cpuid.h: Rename include guard.
7042         * nat/ppc-linux.h: Rename include guard.
7043         * nat/mips-linux-watch.h: Rename include guard.
7044         * nat/linux-waitpid.h: Rename include guard.
7045         * nat/linux-ptrace.h: Rename include guard.
7046         * nat/linux-procfs.h: Rename include guard.
7047         * nat/linux-osdata.h: Rename include guard.
7048         * nat/linux-nat.h: Rename include guard.
7049         * nat/linux-namespaces.h: Rename include guard.
7050         * nat/linux-btrace.h: Rename include guard.
7051         * nat/glibc_thread_db.h: Rename include guard.
7052         * nat/gdb_thread_db.h: Rename include guard.
7053         * nat/gdb_ptrace.h: Rename include guard.
7054         * nat/fork-inferior.h: Rename include guard.
7055         * nat/amd64-linux-siginfo.h: Rename include guard.
7056         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7057         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7058         * nat/aarch64-linux.h: Rename include guard.
7059         * nat/aarch64-linux-hw-point.h: Rename include guard.
7060         * mn10300-tdep.h: Add include guard.
7061         * mips-linux-tdep.h: Add include guard.
7062         * mi/mi-parse.h: Rename include guard.
7063         * mi/mi-out.h: Rename include guard.
7064         * mi/mi-main.h: Rename include guard.
7065         * mi/mi-interp.h: Rename include guard.
7066         * mi/mi-getopt.h: Rename include guard.
7067         * mi/mi-console.h: Rename include guard.
7068         * mi/mi-common.h: Rename include guard.
7069         * mi/mi-cmds.h: Rename include guard.
7070         * mi/mi-cmd-break.h: Rename include guard.
7071         * m2-lang.h: Add include guard.
7072         * location.h: Rename include guard.
7073         * linux-record.h: Rename include guard.
7074         * linux-nat.h: Add include guard.
7075         * linux-fork.h: Add include guard.
7076         * i386-darwin-tdep.h: Rename include guard.
7077         * hppa-linux-offsets.h: Add include guard.
7078         * guile/guile.h: Rename include guard.
7079         * guile/guile-internal.h: Rename include guard.
7080         * gnu-nat.h: Rename include guard.
7081         * gdb-stabs.h: Rename include guard.
7082         * frv-tdep.h: Add include guard.
7083         * f-lang.h: Add include guard.
7084         * event-loop.h: Add include guard.
7085         * darwin-nat.h: Rename include guard.
7086         * cp-abi.h: Rename include guard.
7087         * config/sparc/nm-sol2.h: Rename include guard.
7088         * config/nm-nto.h: Rename include guard.
7089         * config/nm-linux.h: Add include guard.
7090         * config/i386/nm-i386gnu.h: Rename include guard.
7091         * config/djgpp/nl_types.h: Rename include guard.
7092         * config/djgpp/langinfo.h: Rename include guard.
7093         * compile/gcc-cp-plugin.h: Add include guard.
7094         * compile/gcc-c-plugin.h: Add include guard.
7095         * compile/compile.h: Rename include guard.
7096         * compile/compile-object-run.h: Rename include guard.
7097         * compile/compile-object-load.h: Rename include guard.
7098         * compile/compile-internal.h: Rename include guard.
7099         * compile/compile-cplus.h: Rename include guard.
7100         * compile/compile-c.h: Rename include guard.
7101         * common/xml-utils.h: Rename include guard.
7102         * common/x86-xstate.h: Rename include guard.
7103         * common/version.h: Rename include guard.
7104         * common/vec.h: Rename include guard.
7105         * common/tdesc.h: Rename include guard.
7106         * common/selftest.h: Rename include guard.
7107         * common/scoped_restore.h: Rename include guard.
7108         * common/scoped_mmap.h: Rename include guard.
7109         * common/scoped_fd.h: Rename include guard.
7110         * common/safe-iterator.h: Rename include guard.
7111         * common/run-time-clock.h: Rename include guard.
7112         * common/refcounted-object.h: Rename include guard.
7113         * common/queue.h: Rename include guard.
7114         * common/ptid.h: Rename include guard.
7115         * common/print-utils.h: Rename include guard.
7116         * common/preprocessor.h: Rename include guard.
7117         * common/pathstuff.h: Rename include guard.
7118         * common/observable.h: Rename include guard.
7119         * common/netstuff.h: Rename include guard.
7120         * common/job-control.h: Rename include guard.
7121         * common/host-defs.h: Rename include guard.
7122         * common/gdb_wait.h: Rename include guard.
7123         * common/gdb_vecs.h: Rename include guard.
7124         * common/gdb_unlinker.h: Rename include guard.
7125         * common/gdb_unique_ptr.h: Rename include guard.
7126         * common/gdb_tilde_expand.h: Rename include guard.
7127         * common/gdb_sys_time.h: Rename include guard.
7128         * common/gdb_string_view.h: Rename include guard.
7129         * common/gdb_splay_tree.h: Rename include guard.
7130         * common/gdb_setjmp.h: Rename include guard.
7131         * common/gdb_ref_ptr.h: Rename include guard.
7132         * common/gdb_optional.h: Rename include guard.
7133         * common/gdb_locale.h: Rename include guard.
7134         * common/gdb_assert.h: Rename include guard.
7135         * common/filtered-iterator.h: Rename include guard.
7136         * common/filestuff.h: Rename include guard.
7137         * common/fileio.h: Rename include guard.
7138         * common/environ.h: Rename include guard.
7139         * common/common-utils.h: Rename include guard.
7140         * common/common-types.h: Rename include guard.
7141         * common/common-regcache.h: Rename include guard.
7142         * common/common-inferior.h: Rename include guard.
7143         * common/common-gdbthread.h: Rename include guard.
7144         * common/common-exceptions.h: Rename include guard.
7145         * common/common-defs.h: Rename include guard.
7146         * common/common-debug.h: Rename include guard.
7147         * common/cleanups.h: Rename include guard.
7148         * common/buffer.h: Rename include guard.
7149         * common/btrace-common.h: Rename include guard.
7150         * common/break-common.h: Rename include guard.
7151         * cli/cli-utils.h: Rename include guard.
7152         * cli/cli-style.h: Rename include guard.
7153         * cli/cli-setshow.h: Rename include guard.
7154         * cli/cli-script.h: Rename include guard.
7155         * cli/cli-interp.h: Rename include guard.
7156         * cli/cli-decode.h: Rename include guard.
7157         * cli/cli-cmds.h: Rename include guard.
7158         * charset-list.h: Add include guard.
7159         * buildsym-legacy.h: Rename include guard.
7160         * bfin-tdep.h: Add include guard.
7161         * ax.h: Rename include guard.
7162         * arm-linux-tdep.h: Add include guard.
7163         * arm-fbsd-tdep.h: Add include guard.
7164         * arch/xtensa.h: Rename include guard.
7165         * arch/tic6x.h: Add include guard.
7166         * arch/i386.h: Add include guard.
7167         * arch/arm.h: Rename include guard.
7168         * arch/arm-linux.h: Rename include guard.
7169         * arch/arm-get-next-pcs.h: Rename include guard.
7170         * arch/amd64.h: Add include guard.
7171         * arch/aarch64-insn.h: Rename include guard.
7172         * arch-utils.h: Rename include guard.
7173         * annotate.h: Add include guard.
7174         * amd64-darwin-tdep.h: Rename include guard.
7175         * aarch64-linux-tdep.h: Add include guard.
7176         * aarch64-fbsd-tdep.h: Add include guard.
7177         * aarch32-linux-nat.h: Add include guard.
7178
7179 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7180
7181         * macrotab.c (macro_define_internal): New function that
7182         factorizes macro_define_object_internal and macro_define_function
7183         code.
7184         (macro_define_object_internal): Use macro_define_internal.
7185         (macro_define_function): Likewise.
7186
7187 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7188
7189         * macrocmd.c (extract_identifier): Return
7190         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7191         callers.
7192
7193 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7194
7195         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7196
7197 2019-02-05  Tom Tromey  <tom@tromey.com>
7198
7199         * target.c (target_stack::unpush): Move assertion earlier.
7200
7201 2019-01-30  Tom Tromey  <tom@tromey.com>
7202
7203         PR python/23615:
7204         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7205         (gdbpy_parse_and_eval): Likewise.
7206         * python/python-internal.h (gdbpy_allow_threads): New class.
7207
7208 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7209
7210         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7211         (aarch64_fbsd_fpregmap): Move earlier.
7212         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7213         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7214         instead of individual calls to trad_frame_set_reg_addr.
7215         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7216         earlier.
7217         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7218         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7219         instead of individual calls to trad_frame_set_reg_addr.
7220
7221 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7222
7223         * CONTRIBUTE: Replace contribution list with wiki link.
7224
7225 2019-01-25  Tom Tromey  <tom@tromey.com>
7226
7227         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7228
7229 2019-01-25  Tom Tromey  <tom@tromey.com>
7230
7231         * xtensa-linux-nat.c: Fix common/ includes.
7232         * xml-support.h: Fix common/ includes.
7233         * xml-support.c: Fix common/ includes.
7234         * x86-linux-nat.c: Fix common/ includes.
7235         * windows-nat.c: Fix common/ includes.
7236         * varobj.h: Fix common/ includes.
7237         * varobj.c: Fix common/ includes.
7238         * value.c: Fix common/ includes.
7239         * valops.c: Fix common/ includes.
7240         * utils.c: Fix common/ includes.
7241         * unittests/xml-utils-selftests.c: Fix common/ includes.
7242         * unittests/utils-selftests.c: Fix common/ includes.
7243         * unittests/unpack-selftests.c: Fix common/ includes.
7244         * unittests/tracepoint-selftests.c: Fix common/ includes.
7245         * unittests/style-selftests.c: Fix common/ includes.
7246         * unittests/string_view-selftests.c: Fix common/ includes.
7247         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7248         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7249         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7250         * unittests/rsp-low-selftests.c: Fix common/ includes.
7251         * unittests/parse-connection-spec-selftests.c: Fix common/
7252         includes.
7253         * unittests/optional-selftests.c: Fix common/ includes.
7254         * unittests/offset-type-selftests.c: Fix common/ includes.
7255         * unittests/observable-selftests.c: Fix common/ includes.
7256         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7257         * unittests/memrange-selftests.c: Fix common/ includes.
7258         * unittests/memory-map-selftests.c: Fix common/ includes.
7259         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7260         * unittests/function-view-selftests.c: Fix common/ includes.
7261         * unittests/environ-selftests.c: Fix common/ includes.
7262         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7263         * unittests/common-utils-selftests.c: Fix common/ includes.
7264         * unittests/cli-utils-selftests.c: Fix common/ includes.
7265         * unittests/array-view-selftests.c: Fix common/ includes.
7266         * ui-file.c: Fix common/ includes.
7267         * tui/tui-io.c: Fix common/ includes.
7268         * tracepoint.h: Fix common/ includes.
7269         * tracepoint.c: Fix common/ includes.
7270         * tracefile-tfile.c: Fix common/ includes.
7271         * top.h: Fix common/ includes.
7272         * top.c: Fix common/ includes.
7273         * thread.c: Fix common/ includes.
7274         * target/waitstatus.h: Fix common/ includes.
7275         * target/waitstatus.c: Fix common/ includes.
7276         * target.h: Fix common/ includes.
7277         * target.c: Fix common/ includes.
7278         * target-memory.c: Fix common/ includes.
7279         * target-descriptions.c: Fix common/ includes.
7280         * symtab.h: Fix common/ includes.
7281         * symfile.c: Fix common/ includes.
7282         * stap-probe.c: Fix common/ includes.
7283         * spu-linux-nat.c: Fix common/ includes.
7284         * sparc-nat.c: Fix common/ includes.
7285         * source.c: Fix common/ includes.
7286         * solib.c: Fix common/ includes.
7287         * solib-target.c: Fix common/ includes.
7288         * ser-unix.c: Fix common/ includes.
7289         * ser-tcp.c: Fix common/ includes.
7290         * ser-pipe.c: Fix common/ includes.
7291         * ser-base.c: Fix common/ includes.
7292         * selftest-arch.c: Fix common/ includes.
7293         * s12z-tdep.c: Fix common/ includes.
7294         * rust-exp.y: Fix common/ includes.
7295         * rs6000-aix-tdep.c: Fix common/ includes.
7296         * riscv-tdep.c: Fix common/ includes.
7297         * remote.c: Fix common/ includes.
7298         * remote-notif.h: Fix common/ includes.
7299         * remote-fileio.h: Fix common/ includes.
7300         * remote-fileio.c: Fix common/ includes.
7301         * regcache.h: Fix common/ includes.
7302         * regcache.c: Fix common/ includes.
7303         * record-btrace.c: Fix common/ includes.
7304         * python/python.c: Fix common/ includes.
7305         * python/py-type.c: Fix common/ includes.
7306         * python/py-inferior.c: Fix common/ includes.
7307         * progspace.h: Fix common/ includes.
7308         * producer.c: Fix common/ includes.
7309         * procfs.c: Fix common/ includes.
7310         * proc-api.c: Fix common/ includes.
7311         * printcmd.c: Fix common/ includes.
7312         * ppc-linux-nat.c: Fix common/ includes.
7313         * parser-defs.h: Fix common/ includes.
7314         * osdata.c: Fix common/ includes.
7315         * obsd-nat.c: Fix common/ includes.
7316         * nat/x86-linux.c: Fix common/ includes.
7317         * nat/x86-linux-dregs.c: Fix common/ includes.
7318         * nat/x86-dregs.h: Fix common/ includes.
7319         * nat/x86-dregs.c: Fix common/ includes.
7320         * nat/ppc-linux.c: Fix common/ includes.
7321         * nat/mips-linux-watch.h: Fix common/ includes.
7322         * nat/mips-linux-watch.c: Fix common/ includes.
7323         * nat/linux-waitpid.c: Fix common/ includes.
7324         * nat/linux-ptrace.h: Fix common/ includes.
7325         * nat/linux-ptrace.c: Fix common/ includes.
7326         * nat/linux-procfs.c: Fix common/ includes.
7327         * nat/linux-personality.c: Fix common/ includes.
7328         * nat/linux-osdata.c: Fix common/ includes.
7329         * nat/linux-namespaces.c: Fix common/ includes.
7330         * nat/linux-btrace.h: Fix common/ includes.
7331         * nat/linux-btrace.c: Fix common/ includes.
7332         * nat/fork-inferior.c: Fix common/ includes.
7333         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7334         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7335         * nat/aarch64-linux.c: Fix common/ includes.
7336         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7337         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7338         * namespace.h: Fix common/ includes.
7339         * mips-linux-tdep.c: Fix common/ includes.
7340         * minsyms.c: Fix common/ includes.
7341         * mi/mi-parse.h: Fix common/ includes.
7342         * mi/mi-main.c: Fix common/ includes.
7343         * mi/mi-cmd-env.c: Fix common/ includes.
7344         * memrange.h: Fix common/ includes.
7345         * memattr.c: Fix common/ includes.
7346         * maint.h: Fix common/ includes.
7347         * maint.c: Fix common/ includes.
7348         * main.c: Fix common/ includes.
7349         * machoread.c: Fix common/ includes.
7350         * location.c: Fix common/ includes.
7351         * linux-thread-db.c: Fix common/ includes.
7352         * linux-nat.c: Fix common/ includes.
7353         * linux-fork.c: Fix common/ includes.
7354         * inline-frame.c: Fix common/ includes.
7355         * infrun.c: Fix common/ includes.
7356         * inflow.c: Fix common/ includes.
7357         * inferior.h: Fix common/ includes.
7358         * inferior.c: Fix common/ includes.
7359         * infcmd.c: Fix common/ includes.
7360         * inf-ptrace.c: Fix common/ includes.
7361         * inf-child.c: Fix common/ includes.
7362         * ia64-linux-nat.c: Fix common/ includes.
7363         * i387-tdep.c: Fix common/ includes.
7364         * i386-tdep.c: Fix common/ includes.
7365         * i386-linux-tdep.c: Fix common/ includes.
7366         * i386-linux-nat.c: Fix common/ includes.
7367         * i386-go32-tdep.c: Fix common/ includes.
7368         * i386-fbsd-tdep.c: Fix common/ includes.
7369         * i386-fbsd-nat.c: Fix common/ includes.
7370         * guile/scm-type.c: Fix common/ includes.
7371         * guile/guile.c: Fix common/ includes.
7372         * go32-nat.c: Fix common/ includes.
7373         * gnu-nat.c: Fix common/ includes.
7374         * gdbthread.h: Fix common/ includes.
7375         * gdbarch-selftests.c: Fix common/ includes.
7376         * gdb_usleep.c: Fix common/ includes.
7377         * gdb_select.h: Fix common/ includes.
7378         * gdb_bfd.c: Fix common/ includes.
7379         * gcore.c: Fix common/ includes.
7380         * fork-child.c: Fix common/ includes.
7381         * findvar.c: Fix common/ includes.
7382         * fbsd-nat.c: Fix common/ includes.
7383         * event-top.c: Fix common/ includes.
7384         * event-loop.c: Fix common/ includes.
7385         * dwarf2read.c: Fix common/ includes.
7386         * dwarf2loc.c: Fix common/ includes.
7387         * dwarf2-frame.c: Fix common/ includes.
7388         * dwarf-index-cache.c: Fix common/ includes.
7389         * dtrace-probe.c: Fix common/ includes.
7390         * disasm-selftests.c: Fix common/ includes.
7391         * defs.h: Fix common/ includes.
7392         * csky-tdep.c: Fix common/ includes.
7393         * cp-valprint.c: Fix common/ includes.
7394         * cp-support.h: Fix common/ includes.
7395         * cp-support.c: Fix common/ includes.
7396         * corelow.c: Fix common/ includes.
7397         * completer.h: Fix common/ includes.
7398         * completer.c: Fix common/ includes.
7399         * compile/compile.c: Fix common/ includes.
7400         * compile/compile-loc2c.c: Fix common/ includes.
7401         * compile/compile-cplus-types.c: Fix common/ includes.
7402         * compile/compile-cplus-symbols.c: Fix common/ includes.
7403         * command.h: Fix common/ includes.
7404         * cli/cli-dump.c: Fix common/ includes.
7405         * cli/cli-cmds.c: Fix common/ includes.
7406         * charset.c: Fix common/ includes.
7407         * build-id.c: Fix common/ includes.
7408         * btrace.h: Fix common/ includes.
7409         * btrace.c: Fix common/ includes.
7410         * breakpoint.h: Fix common/ includes.
7411         * breakpoint.c: Fix common/ includes.
7412         * ax.h:
7413         (enum agent_op): Fix common/ includes.
7414         * ax-general.c (struct aop_map): Fix common/ includes.
7415         * ax-gdb.c: Fix common/ includes.
7416         * auxv.c: Fix common/ includes.
7417         * auto-load.c: Fix common/ includes.
7418         * arm-tdep.c: Fix common/ includes.
7419         * arch/riscv.c: Fix common/ includes.
7420         * arch/ppc-linux-common.c: Fix common/ includes.
7421         * arch/i386.c: Fix common/ includes.
7422         * arch/arm.c: Fix common/ includes.
7423         * arch/arm-linux.c: Fix common/ includes.
7424         * arch/arm-get-next-pcs.c: Fix common/ includes.
7425         * arch/amd64.c: Fix common/ includes.
7426         * arch/aarch64.c: Fix common/ includes.
7427         * arch/aarch64-insn.c: Fix common/ includes.
7428         * arch-utils.c: Fix common/ includes.
7429         * amd64-windows-tdep.c: Fix common/ includes.
7430         * amd64-tdep.c: Fix common/ includes.
7431         * amd64-sol2-tdep.c: Fix common/ includes.
7432         * amd64-obsd-tdep.c: Fix common/ includes.
7433         * amd64-nbsd-tdep.c: Fix common/ includes.
7434         * amd64-linux-tdep.c: Fix common/ includes.
7435         * amd64-linux-nat.c: Fix common/ includes.
7436         * amd64-fbsd-tdep.c: Fix common/ includes.
7437         * amd64-fbsd-nat.c: Fix common/ includes.
7438         * amd64-dicos-tdep.c: Fix common/ includes.
7439         * amd64-darwin-tdep.c: Fix common/ includes.
7440         * agent.c: Fix common/ includes.
7441         * ada-lang.h: Fix common/ includes.
7442         * ada-lang.c: Fix common/ includes.
7443         * aarch64-tdep.c: Fix common/ includes.
7444
7445 2019-01-25  Tom Tromey  <tom@tromey.com>
7446
7447         * common/create-version.sh: Use common/version.h.
7448
7449 2019-01-24  Pedro Alves  <palves@redhat.com>
7450
7451         * infrun.c (signal_stop, signal_print, signal_program)
7452         (signal_catch, signal_pass): Now arrays instead of pointers.
7453         (update_signals_program_target, do_target_resume)
7454         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7455         * linux-nat.c (linux_nat_target::pass_signals)
7456         (linux_nat_target::create_inferior, linux_nat_target::attach):
7457         Adjust.
7458         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7459         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7460         * procfs.c (procfs_target::pass_signals): Adjust.
7461         * record-full.c (record_full_target::resume): Adjust.
7462         * remote.c (remote_target::pass_signals)
7463         (remote_target::program_signals): Adjust.
7464         * target-debug.h (target_debug_print_signals): Now takes a
7465         gdb::array_view as parameter.  Adjust.
7466         * target.h (target_ops) <pass_signals, program_signals>: Replace
7467         pointer and length parameters with gdb::array_view.
7468         (target_pass_signals, target_program_signals): Likewise.
7469         * target-delegates.c: Regenerate.
7470
7471 2019-01-24  Pedro Alves  <palves@redhat.com>
7472
7473         * common/forward-scope-exit.h
7474         (forward_scope_exit::forward_scope_exit): Pass arguments to
7475         m_bind_function directly, instead of creating a std::bind and
7476         copying that.
7477
7478 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7479
7480         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7481         for static members.
7482         (pass_in_v_vfp_candidate): Likewise.
7483
7484 2019-01-23  Tom Tromey  <tom@tromey.com>
7485             Pedro Alves  <palves@redhat.com>
7486
7487         * regcache.c (class regcache_invalidator): Remove.
7488         (regcache::raw_write): Use make_scope_exit.
7489
7490 2019-01-23  Tom Tromey  <tom@tromey.com>
7491
7492         * ui-out.h (class ui_out_emit_type): Update comment.
7493
7494 2019-01-23  Tom Tromey  <tom@tromey.com>
7495
7496         * infrun.c (fetch_inferior_event): Update comment.
7497
7498 2019-01-23  Tom Tromey  <tom@tromey.com>
7499             Pedro Alves  <palves@redhat.com>
7500
7501         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7502         parameter.
7503         (fetch_inferior_event): Use SCOPE_EXIT.
7504
7505
7506 2019-01-23  Tom Tromey  <tom@tromey.com>
7507             Pedro Alves  <palves@redhat.com>
7508
7509         * infrun.c (disable_thread_events): Delete.
7510         (stop_all_threads): Use SCOPE_EXIT.
7511
7512 2019-01-23  Tom Tromey  <tom@tromey.com>
7513             Pedro Alves  <palves@redhat.com>
7514
7515         * symfile.c: Include forward-scope-exit.h.
7516         (clear_symtab_users_cleanup): Replace forward declaration with
7517         a FORWARD_SCOPE_EXIT.
7518         (syms_from_objfile_1): Use the forward_scope_exit and
7519         gdb::optional instead of cleanup_function.
7520         (reread_symbols): Use the forward_scope_exit instead of
7521         cleanup_function.
7522         (clear_symtab_users_cleanup): Remove function.
7523
7524 2019-01-23  Tom Tromey  <tom@tromey.com>
7525             Pedro Alves  <palves@redhat.com>
7526
7527         * linux-nat.c: Include scope-exit.h.
7528         (cleanup_target_stop): Remove.
7529         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7530         SCOPE_EXIT.
7531
7532 2019-01-23  Tom Tromey  <tom@tromey.com>
7533             Pedro Alves  <palves@redhat.com>
7534
7535         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7536         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7537
7538 2019-01-23  Tom Tromey  <tom@tromey.com>
7539             Andrew Burgess  <andrew.burgess@embecosm.com>
7540             Pedro Alves  <palves@redhat.com>
7541
7542         * infrun.c (fetch_inferior_event): Use scope_exit.
7543         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7544         * top.c (execute_command): Use scope_exit.
7545         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7546         * utils.c (do_bpstat_clear_actions_cleanup)
7547         (make_bpstat_clear_actions_cleanup): Remove.
7548
7549 2019-01-23  Tom Tromey  <tom@tromey.com>
7550             Pedro Alves  <palves@redhat.com>
7551
7552         * infrun.c: Include "common/scope-exit.h"
7553         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7554         (wait_for_inferior): Use SCOPE_EXIT.
7555         (fetch_inferior_event): Use scope_exit.
7556
7557 2019-01-23  Tom Tromey  <tom@tromey.com>
7558             Pedro Alves  <palves@redhat.com>
7559
7560         * breakpoint.c (create_breakpoint): Remove cleanup.
7561
7562 2019-01-23  Tom Tromey  <tom@tromey.com>
7563             Andrew Burgess  <andrew.burgess@embecosm.com>
7564             Pedro Alves  <palves@redhat.com>
7565
7566 2019-01-23  Pedro Alves  <palves@redhat.com>
7567
7568         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7569
7570 2019-01-23  Pedro Alves  <palves@redhat.com>
7571             Andrew Burgess  <andrew.burgess@embecosm.com>
7572
7573         * gdbthread.h: Include "common/forward-scope-exit.h".
7574         (scoped_finish_thread_state): Redefine custom class in terms of
7575         forward_scope_exit.
7576
7577 2019-01-23  Pedro Alves  <palves@redhat.com>
7578             Andrew Burgess  <andrew.burgess@embecosm.com>
7579
7580         * common/forward-scope-exit.h: New file.
7581
7582 2019-01-23  Pedro Alves  <palves@redhat.com>
7583             Andrew Burgess  <andrew.burgess@embecosm.com>
7584             Tom Tromey  <tom@tromey.com>
7585
7586         * common/scope-exit.h: New file.
7587
7588 2019-01-23  Pedro Alves  <palves@redhat.com>
7589
7590         * common/preprocessor.h (ESC): Rename to ...
7591         (ESC_PARENS): ... this.
7592         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7593         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7594
7595 2019-01-23  Tom Tromey  <tom@tromey.com>
7596
7597         * language.h (class scoped_switch_to_sym_language_if_auto):
7598         Initialize m_lang in both cases.
7599
7600 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7601
7602         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7603         with XCNEW.
7604
7605 2019-01-22  Tom Tromey  <tom@tromey.com>
7606
7607         * corelow.c: Do not include sys/file.h.
7608
7609 2019-01-22  Tom Tromey  <tom@tromey.com>
7610
7611         * tui/tui-wingeneral.h: Include gdb_curses.h.
7612
7613 2019-01-22  Tom Tromey  <tom@tromey.com>
7614
7615         * source-cache.h (class source_cache) <get_source_lines,
7616         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7617
7618 2019-01-22  Tom Tromey  <tom@tromey.com>
7619
7620         * remote-fileio.h (struct remote_target): Declare.
7621
7622 2019-01-22  Tom Tromey  <tom@tromey.com>
7623
7624         * python/py-arch.c: Do not include py-ref.h.
7625         * python/py-bpevent.c: Do not include py-ref.h.
7626         * python/py-cmd.c: Do not include py-ref.h.
7627         * python/py-continueevent.c: Do not include py-ref.h.
7628         * python/py-event.h: Do not include py-ref.h.
7629         * python/py-evtregistry.c: Do not include py-ref.h.
7630         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7631         * python/py-frame.c: Do not include py-ref.h.
7632         * python/py-framefilter.c: Do not include py-ref.h.
7633         * python/py-function.c: Do not include py-ref.h.
7634         * python/py-infevents.c: Do not include py-ref.h.
7635         * python/py-linetable.c: Do not include py-ref.h.
7636         * python/py-objfile.c: Do not include py-ref.h.
7637         * python/py-param.c: Do not include py-ref.h.
7638         * python/py-prettyprint.c: Do not include py-ref.h.
7639         * python/py-progspace.c: Do not include py-ref.h.
7640         * python/py-symbol.c: Do not include py-ref.h.
7641         * python/py-symtab.c: Do not include py-ref.h.
7642         * python/py-type.c: Do not include py-ref.h.
7643         * python/py-unwind.c: Do not include py-ref.h.
7644         * python/py-utils.c: Do not include py-ref.h.
7645         * python/py-value.c: Do not include py-ref.h.
7646         * python/py-varobj.c: Do not include py-ref.h.
7647         * python/py-xmethods.c: Do not include py-ref.h.
7648         * python/python.c: Do not include py-ref.h.
7649         * varobj.c: Do not include py-ref.h.
7650
7651 2019-01-22  Tom Tromey  <tom@tromey.com>
7652
7653         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7654         keyword for bcache.
7655
7656 2019-01-22  Tom Tromey  <tom@tromey.com>
7657
7658         * compile/compile-cplus-types.c: Remove a comment by #include.
7659
7660 2019-01-22  Tom Tromey  <tom@tromey.com>
7661
7662         * compile/gcc-c-plugin.h: Include compile-internal.h.
7663
7664 2019-01-22  Tom Tromey  <tom@tromey.com>
7665
7666         * stabsread.c (EXTERN): Do not define.
7667         (symnum, next_symbol_text_func, processing_gcc_compilation)
7668         (within_function, global_sym_chain, global_stabs)
7669         (previous_stab_code, this_object_header_files)
7670         (n_this_object_header_files)
7671         (n_allocated_this_object_header_files): Define.
7672         * stabsread.h (EXTERN): Never define.  Use "extern".
7673
7674 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7675
7676         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7677         history_value.
7678
7679 2019-01-21  Tom Tromey  <tom@tromey.com>
7680
7681         * ui-out.c: Fix includes.
7682         * tui/tui-source.c: Fix includes.
7683         * target.c: Fix includes.
7684         * remote.c: Fix includes.
7685         * regcache.c: Fix includes.
7686         * python/py-block.c: Fix includes.
7687         * printcmd.c: Fix includes.
7688         * or1k-tdep.c: Fix includes.
7689         * mi/mi-main.c: Fix includes.
7690         * m32r-tdep.c: Fix includes.
7691         * csky-tdep.c: Fix includes.
7692         * compile/compile-cplus-types.c: Fix includes.
7693         * cli/cli-interp.c: Fix includes.
7694
7695 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7696
7697         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7698         for padding.
7699
7700 2019-01-16  Tom Tromey  <tom@tromey.com>
7701
7702         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7703         earlier.
7704         (struct objfile) <msymbols_range>: Move from top level.
7705         <msymbols>: New method.
7706         (class objfile_msymbols): Remove.
7707         * symtab.c (default_collect_symbol_completion_matches_break_on):
7708         Update.
7709         * symmisc.c (dump_msymbols): Update.
7710         * stabsread.c (scan_file_globals): Update.
7711         * objc-lang.c (info_selectors_command, info_classes_command)
7712         (find_methods): Update.
7713         * minsyms.c (find_solib_trampoline_target): Update.
7714         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7715         * coffread.c (coff_symfile_read): Update.
7716         * ada-lang.c (ada_lookup_simple_minsym)
7717         (ada_collect_symbol_completion_matches): Update.
7718
7719 2019-01-16  Tom Tromey  <tom@tromey.com>
7720
7721         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7722         type.  Remove no-argument constructor.
7723         <iterator::operator++>: Simplify.
7724         <begin>: Update.
7725         <end>: Use minimal_symbol_count.
7726
7727 2019-01-16  Tom Tromey  <tom@tromey.com>
7728
7729         * objfiles.h (struct objfile) <psymtabs>: New method.
7730         (class objfile_psymtabs): Remove.
7731         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7732         typedef.
7733         <range>: New method.
7734         (require_partial_symbols): Change return type.
7735         * psymtab.c (require_partial_symbols)
7736         (psym_expand_symtabs_matching): Update.
7737         * mdebugread.c (parse_partial_symbols): Update.
7738         * dbxread.c (dbx_end_psymtab): Update.
7739
7740 2019-01-15  Tom Tromey  <tom@tromey.com>
7741
7742         * symtab.c (lookup_objfile_from_block)
7743         (lookup_symbol_in_objfile_symtabs)
7744         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7745         (find_line_symtab, info_sources_command)
7746         (default_collect_symbol_completion_matches_break_on)
7747         (make_source_files_completion_list): Update.
7748         * symmisc.c (print_objfile_statistics, dump_objfile)
7749         (maintenance_print_symbols, maintenance_info_symtabs)
7750         (maintenance_check_symtabs, maintenance_info_line_tables):
7751         Update.
7752         * source.c (select_source_symtab)
7753         (forget_cached_source_info_for_objfile): Update.
7754         * objfiles.h (class objfile_compunits): Remove.
7755         (struct objfile) <compunits_range>: New typedef.
7756         (compunits): New method.
7757         * objfiles.c (objfile_relocate1): Update.
7758         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7759         * maint.c (count_symtabs_and_blocks): Update.
7760         * linespec.c (iterate_over_all_matching_symtabs): Update.
7761         * cp-support.c (add_symbol_overload_list_qualified): Update.
7762         * coffread.c (coff_symtab_read): Update.
7763         * ada-lang.c (add_nonlocal_symbols)
7764         (ada_collect_symbol_completion_matches)
7765         (ada_add_global_exceptions): Update.
7766
7767 2019-01-15  Tom Tromey  <tom@tromey.com>
7768
7769         * progspace.h (program_space) <objfiles_safe_range>: New
7770         typedef.
7771         <objfiles_safe>: New method.
7772         * objfiles.h (class all_objfiles_safe): Remove.
7773         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7774         * jit.c (jit_inferior_exit_hook): Update.
7775
7776 2019-01-17  Tom Tromey  <tom@tromey.com>
7777
7778         * progspace.h (program_space) <objfiles_range>: New typedef.
7779         <objfiles>: New method.
7780         <objfiles_head>: Rename from objfiles.
7781         (object_files): Update.
7782         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7783         * guile/scm-pretty-print.c
7784         (ppscm_find_pretty_printer_from_objfiles): Update.
7785         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7786         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7787         Update.
7788         * python/py-progspace.c (pspy_get_objfiles): Update.
7789         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7790         Update.
7791         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7792         (objfpy_lookup_objfile_by_build_id): Update.
7793         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7794         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7795         Update.
7796         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7797         (expand_symtab_containing_pc, lookup_objfile_from_block)
7798         (lookup_static_symbol, basic_lookup_transparent_type)
7799         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7800         (find_line_symtab, info_sources_command)
7801         (default_collect_symbol_completion_matches_break_on)
7802         (make_source_files_completion_list, find_main_name): Update.
7803         * symmisc.c (print_symbol_bcache_statistics)
7804         (print_objfile_statistics, maintenance_print_symbols)
7805         (maintenance_print_msymbols, maintenance_print_objfiles)
7806         (maintenance_info_symtabs, maintenance_check_symtabs)
7807         (maintenance_expand_symtabs, maintenance_info_line_tables):
7808         Update.
7809         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7810         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7811         (map_overlay_command, unmap_overlay_command)
7812         (simple_overlay_update, expand_symtabs_matching)
7813         (map_symbol_filenames): Update.
7814         * symfile-debug.c (set_debug_symfile): Update.
7815         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7816         Update.
7817         * source.c (select_source_symtab, forget_cached_source_info):
7818         Update.
7819         * solib.c (solib_read_symbols): Update.
7820         * solib-spu.c (append_ocl_sos): Update.
7821         * psymtab.c (maintenance_print_psymbols)
7822         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7823         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7824         * printcmd.c (info_symbol_command): Update.
7825         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7826         Update.
7827         * objfiles.h (class all_objfiles): Remove.
7828         * objfiles.c (have_partial_symbols, have_full_symbols)
7829         (have_minimal_symbols, qsort_cmp, update_section_map)
7830         (shared_objfile_contains_address_p)
7831         (default_iterate_over_objfiles_in_search_order): Update.
7832         * objc-lang.c (info_selectors_command, info_classes_command)
7833         (find_methods): Update.
7834         * minsyms.c (find_solib_trampoline_target): Update.
7835         * maint.c (maintenance_info_sections)
7836         (maintenance_translate_address, count_symtabs_and_blocks):
7837         Update.
7838         * main.c (captured_main_1): Update.
7839         * linux-thread-db.c (try_thread_db_load_from_pdir)
7840         (has_libpthread): Update.
7841         * linespec.c (iterate_over_all_matching_symtabs)
7842         (search_minsyms_for_name): Update.
7843         * jit.c (jit_find_objf_with_entry_addr): Update.
7844         * hppa-tdep.c (find_unwind_entry)
7845         (hppa_lookup_stub_minimal_symbol): Update.
7846         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7847         Update.
7848         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7849         (elf_gnu_ifunc_resolve_by_got): Update.
7850         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7851         * dwarf-index-write.c (save_gdb_index_command): Update.
7852         * cp-support.c (add_symbol_overload_list_qualified): Update.
7853         * breakpoint.c (create_overlay_event_breakpoint)
7854         (create_longjmp_master_breakpoint)
7855         (create_std_terminate_master_breakpoint)
7856         (create_exception_master_breakpoint): Update.
7857         * blockframe.c (find_pc_partial_function): Update.
7858         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7859         (ada_collect_symbol_completion_matches)
7860         (ada_add_global_exceptions): Update.
7861
7862 2019-01-17  Tom Tromey  <tom@tromey.com>
7863
7864         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7865         declare VEC.
7866         (solib_target_parse_libraries): Change return type.
7867         (library_list_start_segment, library_list_start_section)
7868         (library_list_end_library, library_list_start_library); Update.
7869         (solib_target_free_library_list): Remove.
7870         (solib_target_parse_libraries): Remove cleanup.  Change return
7871         type.
7872         (solib_target_current_sos): Update.
7873
7874 2019-01-17  Tom Tromey  <tromey@bapiya>
7875
7876         * valprint.c: Replace "the the" with "the".
7877         * symtab.c: Replace "the the" with "the".
7878         * solib.c: Replace "the the" with "the".
7879         * solib-dsbt.c: Replace "the the" with "the".
7880         * linespec.c: Replace "the the" with "the".
7881         * dwarf2loc.h: Replace "the the" with "the".
7882         * amd64-windows-tdep.c: Replace "the the" with "the".
7883         * aarch64-tdep.c: Replace "the the" with "the".
7884
7885 2019-01-16  Keith Seitz  <keiths@redhat.com>
7886
7887         PR gdb/23773
7888         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7889         <builder>: Rename to ..
7890         <m_builder>: ... this and make private.
7891         (dwarf2_cu::get_builder): New method.  Change all users of
7892         `builder' to use this method.
7893         (dwarf2_start_symtab): Move to ...
7894         (dwarf2_cu::start_symtab): ... here.  Update all callers
7895         (setup_type_unit_groups): Move to ...
7896         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7897         callers.
7898         (dwarf2_cu::reset_builder): New method.
7899         (process_full_compunit, process_full_type_unit): Use
7900         dwarf2_cu::reset_builder.
7901         (follow_die_offset): Record the ancestor CU if it is different
7902         from the followed DIE's CU.
7903         (follow_die_sig_1): Likewise.
7904
7905 2019-01-15  Tom Tromey  <tom@tromey.com>
7906
7907         * remote.c (class remote_state) <buf>: Now a char_vector.
7908         <buf_size>: Remove.
7909         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7910         parameter.
7911         (remote_target::getpkt_or_notif_sane_1)
7912         (remote_target::getpkt_sane)
7913         (remote_target::getpkt_or_notif_sane): Likewise.
7914         (class remote_target) <putpkt>: New overload.
7915         (remote_target::read_frame): Change type of "buf_p".  Remove
7916         sizeof_p parameter.
7917         (packet_ok): New overload.
7918         (packet_check_result): New overload.
7919         Update all uses.
7920
7921 2019-01-14  Tom Tromey  <tom@tromey.com>
7922
7923         * remote-notif.c (handle_notification, remote_notif_ack)
7924         (remote_notif_parse): Make "buf" const.
7925         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7926         const.
7927         (remote_notif_parse, remote_notif_ack, handle_notification):
7928         Likewise.
7929         * remote.c (remote_notif_stop_parse): Make "buf" const.
7930         (remote_target::remote_parse_stop_reply): Make "buf" const.
7931         (remote_notif_stop_ack): Make "buf" const.
7932
7933 2019-01-14  Tom Tromey  <tom@tromey.com>
7934
7935         * remote.c (remote_console_output): Make parameter const.
7936
7937 2019-01-14  Tom Tromey  <tom@tromey.com>
7938
7939         * target-debug.h (target_debug_print_signals): Constify.
7940         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7941         * procfs.c (procfs_target::pass_signals): Update.
7942         * linux-nat.c (linux_nat_target::pass_signals): Update.
7943         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7944         * target-delegates.c: Rebuild.
7945         * remote.c (remote_target::program_signals): Update.
7946         (remote_target::pass_signals): Update.
7947         * target.c (target_pass_signals): Constify argument.
7948         (target_program_signals): Likewise.
7949         * target.h (struct target_ops) <pass_signals, program_signals>:
7950         Constify argument.
7951         (target_pass_signals, target_program_signals): Constify argument.
7952
7953 2019-01-14  Tom Tromey  <tom@tromey.com>
7954
7955         PR tui/28819:
7956         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7957
7958 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7959
7960         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7961         field.
7962         * rs6000-tdep.c: Include reggroups.h.
7963         (IS_V_ALIAS_PSEUDOREG): Define.
7964         (rs6000_register_name): Return names for the "vX" aliases.
7965         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7966         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7967         aliases.  Call default_register_reggroup_p for all other
7968         pseudo-registers.
7969         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7970         New functions.
7971         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7972         Handle "vX" aliases.
7973         (v_alias_pseudo_register_collect): New function.
7974         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7975         (rs6000_gdbarch_init): Initialize "vX" aliases as
7976         pseudo-registers.  Restore registration of
7977         rs6000_pseudo_register_reggroup_p with
7978         set_tdesc_pseudo_register_reggroup_p.
7979
7980 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7981
7982         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7983         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7984         set_gdbarch_num_pseudo_regs.
7985
7986 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7987
7988         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7989         Remove arg prefixname, add do_set and do_show.
7990         Add member functions set_list and show_list.
7991         * cli/cli-style.c (class cli_style_option): Update accordingly.
7992         (style_set_list): Move to file scope.
7993         (style_show_list): Likewise.
7994         (set_style): Call help_list.
7995         (show_style): Call cmd_show_list.
7996         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7997         Update to use the new macro.
7998
7999 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8000
8001         * ada-lang.c (_initialize_ada_language): Expand the help text
8002         for the "catch exception" command.
8003
8004 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8005
8006         * symtab.c (matching_obj_sections): Initialize obj,
8007         declare it closer to its usage.
8008
8009 2019-01-10  Tom Tromey  <tom@tromey.com>
8010
8011         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8012         (basic_inf_threads_range): Remove.
8013         (inf_threads_range, inf_non_exited_threads_range)
8014         (safe_inf_threads_range): Use next_adapter.
8015
8016 2019-01-10  Keith Seitz  <keiths@redhat.com>
8017
8018         PR gdb/23712
8019         PR symtab/23010
8020         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8021         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8022
8023 2019-01-10  Keith Seitz  <keiths@redhat.com>
8024
8025         PR gdb/23712
8026         PR symtab/23010
8027         * dictionary.c (pending_to_vector): Remove.
8028         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8029         Remove _1 suffix, replacing functions of the same name.  Update
8030         all callers.
8031         (dict_create_hashed, dict_create_hashed_expandable)
8032         (dict_create_linear, dict_create_linear_expandable, dict_free)
8033         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8034         Make functions static.
8035
8036 2019-01-10  Keith Seitz  <keiths@redhat.com>
8037
8038         PR gdb/23712
8039         PR symtab/23010
8040         * dictionary.h (struct dictionary): Replace declaration with
8041         multidictionary.
8042         (dict_create_hashed, dict_create_hashed_expandable)
8043         (dict_create_linear, dict_create_linear_expandable)
8044         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8045         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8046         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8047         taking multidictionary argument.
8048         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8049         * block.h (struct block) <dict>: Change to multidictionary
8050         and rename `multidict'.
8051         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8052         symmisc.c: Update all dictionary references to multidictionary.
8053
8054 2019-01-10  Keith Seitz  <keiths@redhat.com>
8055
8056         PR gdb/23712
8057         PR symtab/23010
8058         * dictionary.c: Include unordered_map.
8059         (pending_to_vector): New function.
8060         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8061         Rewrite the non-"_1" functions to take vector instead
8062         of linked list.
8063         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8064         "new" _1 versions of the same name.
8065         (multidictionary): Define.
8066         (std::hash<enum language): New definition.
8067         (collate_pending_symbols_by_language, mdict_create_hashed)
8068         (mdict_create_hashed_expandable, mdict_create_linear)
8069         (mdict_create_linear_expandable, mdict_free)
8070         (find_language_dictionary, create_new_language_dictionary)
8071         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8072         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8073         (mdict_size, mdict_empty): New functions.
8074         * dictionary.h (mdict_iterator): Define.
8075
8076 2019-01-10  Pedro Alves  <palves@redhat.com>
8077
8078         * breakpoint.c (read_uploaded_action)
8079         (create_tracepoint_from_upload): Adjust to use
8080         gdb::unique_xmalloc_ptr.
8081         * ctf.c (ctf_write_uploaded_tp):
8082         (SET_ARRAY_FIELD): Use emplace_back.
8083         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8084         * tracefile-tfile.c (tfile_write_uploaded_tp):
8085         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8086         gdb::unique_xmalloc_ptr.
8087         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8088         at_string, cond_string, cmd_strings>: Replace char pointers
8089         with gdb::unique_xmalloc_ptr.
8090
8091 2019-01-10  Pedro Alves  <palves@redhat.com>
8092
8093         * solib-target.c (library_list_start_library): Don't xstrdup name.
8094
8095 2019-01-10  Pedro Alves  <palves@redhat.com>
8096
8097         * mdebugread.c (parse_partial_symbols): Use
8098         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8099
8100 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8101
8102         * linux-fork.c (scoped_switch_fork_info)
8103         <~scoped_switch_fork_info>: Fix incorrect variable name.
8104
8105 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8106
8107         * linux-fork.c (scoped_switch_fork_info)
8108         <scoped_switch_fork_info>: Make explicit.
8109         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8110
8111 2019-01-10  Tom Tromey  <tom@tromey.com>
8112
8113         * objfiles.h (objfile::reset_psymtabs): Update.
8114         * objfiles.c (objfile::objfile): Update.
8115         * psymtab.h (psymtab_storage::obstack): Update.
8116         (psymtab_storage::m_obstack): Use gdb::optional.
8117         (class psymtab_storage): Update comment.  Remove objfile
8118         parameter.
8119         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8120
8121 2019-01-10  Tom Tromey  <tom@tromey.com>
8122
8123         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8124         <free_psymtabs>: Now private.
8125         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8126         (allocate_psymtab): Use new method.
8127
8128 2019-01-10  Tom Tromey  <tom@tromey.com>
8129
8130         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8131         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8132         * mdebugread.c (parse_partial_symbols): Use
8133         allocate_dependencies.
8134         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8135         allocate_dependencies.
8136         (process_psymtab_comp_unit_reader)
8137         (build_type_psymtab_dependencies): Likewise.
8138         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8139
8140 2019-01-10  Tom Tromey  <tom@tromey.com>
8141
8142         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8143         PSYMBOL_SET_LANGUAGE.
8144         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8145
8146 2019-01-10  Tom Tromey  <tom@tromey.com>
8147
8148         * psymtab.h (psymtab_storage::obstack): New method.
8149         <m_obstack>: Rename from obstack; now private.
8150         * psymtab.c (psymtab_storage): Update.
8151         * dwarf2read.c (create_addrmap_from_index)
8152         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8153         Update.
8154
8155 2019-01-10  Tom Tromey  <tom@tromey.com>
8156
8157         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8158         * objfiles.h (objfile::reset_psymtabs): New method.
8159
8160 2019-01-10  Tom Tromey  <tom@tromey.com>
8161
8162         * symmisc.c (print_symbol_bcache_statistics): Update.
8163         (print_objfile_statistics): Update.
8164         * symfile.c (reread_symbols): Update.
8165         * psymtab.h (class psymtab_storage): New.
8166         * psymtab.c (psymtab_storage): New constructor.
8167         (~psymtab_storage): New destructor.
8168         (require_partial_symbols): Update.
8169         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8170         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8171         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8172         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8173         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8174         (start_psymtab_common, end_psymtab_common)
8175         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8176         (allocate_psymtab): Update.
8177         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8178         Update.
8179         (dump_psymtab_addrmap, maintenance_print_psymbols)
8180         (maintenance_check_psymtabs): Update.
8181         (class objfile_psymtabs): Move to objfiles.h.
8182         * psympriv.h (discard_psymtab): Now inline.
8183         (psymtab_discarder::psymtab_discarder): Update.
8184         (psymtab_discarder::~psymtab_discarder): Update.
8185         (ALL_OBJFILE_PSYMTABS): Rewrite.
8186         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8187         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8188         Remove fields.
8189         <partial_symtabs>: New field.
8190         (class objfile_psymtabs): Move from psymtab.h.  Update.
8191         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8192         psymbol_cache.
8193         (objfile::~objfile): Don't destroy psymbol_cache.
8194         * mdebugread.c (parse_partial_symbols): Update.
8195         * dwarf2read.c (create_addrmap_from_index)
8196         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8197         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8198         (add_partial_subprogram, dwarf2_ranges_read): Update.
8199         * dwarf-index-write.c (write_address_map)
8200         (write_one_signatured_type, recursively_write_psymbols)
8201         (class debug_names, class debug_names, write_psymtabs_to_index):
8202         Update.
8203
8204 2019-01-10  Tom Tromey  <tom@tromey.com>
8205
8206         * symtab.h (SYMBOL_SET_NAMES): Update.
8207         (symbol_set_names): Update.
8208         (MSYMBOL_SET_NAMES): Update.
8209         * symtab.c (symbol_set_names): Change argument to be an
8210         objfile_per_bfd_storage.
8211         * psymtab.c (add_psymbol_to_bcache): Update.
8212         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8213
8214 2019-01-10  Tom Tromey  <tom@tromey.com>
8215
8216         * symtab.c (create_demangled_names_hash): Change argument to be an
8217         objfile_per_bfd_storage.
8218         (symbol_set_names): Update.
8219
8220 2019-01-10  Tom Tromey  <tom@tromey.com>
8221
8222         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8223         init_psymbol_list.
8224         * psymtab.c (init_psymbol_list): Do nothing if already called.
8225         * psympriv.h (init_psymbol_list): Add comment.
8226         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8227         init_psymbol_list.
8228         * dbxread.c (dbx_symfile_read): Unconditionally call
8229         init_psymbol_list.
8230
8231 2019-01-10  Tom Tromey  <tom@tromey.com>
8232
8233         * xcoffread.c (scan_xcoff_symtab): Update.
8234         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8235         "where".
8236         * mdebugread.c (parse_partial_symbols)
8237         (handle_psymbol_enumerators): Update.
8238         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8239         * dbxread.c (read_dbx_symtab): Update.
8240         * psympriv.h (psymbol_placement): New enum.
8241         (add_psymbol_to_list): Update.
8242
8243 2019-01-10  Tom Tromey  <tom@tromey.com>
8244
8245         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8246         static_psymbols parameters.
8247         (scan_xcoff_symtab): Update.
8248         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8249         static_psymbols parameters.
8250         * psympriv.h (start_psymtab_common): Update.
8251         * mdebugread.c (parse_partial_symbols): Update.
8252         * dwarf2read.c (create_partial_symtab): Update.
8253         * dbxread.c (read_dbx_symtab): Update.
8254         (start_psymtab): Remove global_psymbols and static_psymbols
8255         parameters.
8256
8257 2019-01-10  Tom Tromey  <tom@tromey.com>
8258
8259         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8260         * psymtab.c (allocate_psymtab): Add comment.
8261         * psympriv.h (allocate_psymtab): Add comment.
8262         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8263         initializations.
8264         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8265
8266 2019-01-10  Tom Tromey  <tom@tromey.com>
8267
8268         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8269         Don't declare.
8270         * mipsread.c: Include mdebugread.h.
8271         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8272         Declare.
8273         * elfread.c: Include mdebugread.h.
8274
8275 2019-01-09  Tom Tromey  <tom@tromey.com>
8276
8277         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8278         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8279         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8280         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8281         (psym_lookup_symbol, psym_find_last_source_symtab)
8282         (psym_forget_cached_source_info, psym_print_stats)
8283         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8284         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8285         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8286         (psym_find_compunit_symtab_by_address)
8287         (maintenance_print_psymbols, maintenance_info_psymtabs)
8288         (maintenance_check_psymtabs): Use ranged for.
8289         * psymtab.h (class objfile_psymtabs): New.
8290         (require_partial_symbols): Return objfile_psymtabs.
8291         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8292
8293 2019-01-09  Tom Tromey  <tom@tromey.com>
8294
8295         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8296         (find_pc_mapped_section, list_overlays_command)
8297         (map_overlay_command, unmap_overlay_command)
8298         (simple_overlay_update): Use all_objfiles.
8299         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8300         * printcmd.c (info_symbol_command): Use all_objfiles.
8301         * objfiles.h (ALL_OBJSECTIONS): Remove.
8302         * maint.c (maintenance_translate_address): Use all_objfiles.
8303         * gcore.c (gcore_create_callback): Use all_objfiles.
8304         (objfile_find_memory_regions): Likewise.
8305
8306 2019-01-09  Tom Tromey  <tom@tromey.com>
8307
8308         * symtab.c (find_line_symtab, info_sources_command)
8309         (make_source_files_completion_list): Use objfile_compunits.
8310         * source.c (select_source_symtab): Use objfile_compunits.
8311         * objfiles.h (struct objfile): Update comment.
8312         (ALL_OBJFILES): Remove.
8313         (ALL_FILETABS): Remove.
8314         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8315         objfile_compunits.
8316
8317 2019-01-09  Tom Tromey  <tom@tromey.com>
8318
8319         * symmisc.c (print_objfile_statistics, dump_objfile)
8320         (maintenance_print_symbols): Use compunit_filetabs.
8321         * source.c (forget_cached_source_info_for_objfile): Use
8322         compunit_filetabs.
8323         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8324         (ALL_FILETABS): Use compunit_filetabs.
8325         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8326         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8327
8328 2019-01-09  Tom Tromey  <tom@tromey.com>
8329
8330         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8331         (compunit_filetabs): New.
8332         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8333         compunit_filetabs.
8334         (info_sources_command, make_source_files_completion_list): Remove
8335         declaration.
8336         * symmisc.c (print_objfile_statistics, dump_objfile)
8337         (maintenance_print_symbols): Remove declaration.
8338         (maintenance_info_symtabs): Use compunit_filetabs.
8339         (maintenance_info_line_tables): Likewise.
8340         * source.c (select_source_symtab): Change local variable name.
8341         (forget_cached_source_info_for_objfile): Remove declaration.
8342         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8343         * objfiles.c (objfile_relocate1): Remove declaration.
8344         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8345         declaration.
8346         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8347         * coffread.c (coff_symtab_read): Remove declaration.
8348         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8349         compunit_filetabs.
8350
8351 2019-01-09  Tom Tromey  <tom@tromey.com>
8352
8353         * symtab.c (lookup_objfile_from_block)
8354         (find_pc_sect_compunit_symtab, search_symbols)
8355         (default_collect_symbol_completion_matches_break_on): Use
8356         objfile_compunits.
8357         * objfiles.h (ALL_COMPUNITS): Remove.
8358         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8359         * cp-support.c (add_symbol_overload_list_qualified): Use
8360         objfile_compunits.
8361         * ada-lang.c (ada_collect_symbol_completion_matches)
8362         (ada_add_global_exceptions): Use objfile_compunits.
8363
8364 2019-01-09  Tom Tromey  <tom@tromey.com>
8365
8366         * source.c (select_source_symtab)
8367         (forget_cached_source_info_for_objfile): Remove declaration.
8368         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8369         declaration.
8370         * maint.c (count_symtabs_and_blocks): Remove declaration.
8371         * cp-support.c (add_symbol_overload_list_qualified): Remove
8372         declaration.
8373         * coffread.c (coff_symtab_read): Remove declaration.
8374         * symtab.c (lookup_symbol_in_objfile_symtabs)
8375         (basic_lookup_transparent_type_1): Use objfile_compunits.
8376         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8377         (info_sources_command, search_symbols)
8378         (default_collect_symbol_completion_matches_break_on)
8379         (make_source_files_completion_list): Remove declaration.
8380         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8381         (ada_collect_symbol_completion_matches)
8382         (ada_add_global_exceptions): Remove declaration.
8383         * linespec.c (iterate_over_all_matching_symtabs): Use
8384         objfile_compunits.
8385         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8386         (class objfile_compunits): New.
8387         (ALL_COMPUNITS): Use objfile_compunits.
8388         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8389         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8390         objfile_compunits.
8391         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8392
8393 2019-01-09  Tom Tromey  <tom@tromey.com>
8394
8395         * symtab.c (search_symbols)
8396         (default_collect_symbol_completion_matches_break_on): Use
8397         objfile_msymbols.
8398         * ada-lang.c (ada_lookup_simple_minsym)
8399         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8400         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8401         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8402         objfile_msymbols.
8403         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8404         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8405         * objc-lang.c (find_methods): Use objfile_msymbols.
8406         (info_selectors_command, info_classes_command): Likewise.
8407         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8408         * objfiles.h (class objfile_msymbols): New.
8409         (ALL_OBJFILE_MSYMBOLS): Remove.
8410         (ALL_MSYMBOLS): Remove.
8411
8412 2019-01-09  Tom Tromey  <tom@tromey.com>
8413
8414         * common/next-iterator.h (next_adapter): Add Iterator template
8415         parameter.
8416         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8417         (class all_objfiles_safe): New.
8418         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8419         * objfiles.c (put_objfile_before): Update comment.
8420         (add_separate_debug_objfile): Likewise.
8421         (free_all_objfiles): Use all_objfiles_safe.
8422         (objfile_purge_solibs): Likewise.
8423
8424 2019-01-09  Tom Tromey  <tom@tromey.com>
8425
8426         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8427         (expand_symtab_containing_pc, lookup_static_symbol)
8428         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8429         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8430         all_objfiles.
8431         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8432         * breakpoint.c (create_overlay_event_breakpoint)
8433         (create_longjmp_master_breakpoint)
8434         (create_std_terminate_master_breakpoint)
8435         (create_exception_master_breakpoint): Use all_objfiles.
8436         * linux-thread-db.c (try_thread_db_load_from_pdir)
8437         (has_libpthread): Use all_objfiles.
8438         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8439         * linespec.c (iterate_over_all_matching_symtabs)
8440         (search_minsyms_for_name): Use all_objfiles.
8441         * maint.c (maintenance_info_sections): Use all_objfiles.
8442         * main.c (captured_main_1): Use all_objfiles.
8443         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8444         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8445         * guile/scm-pretty-print.c
8446         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8447         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8448         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8449         (maintenance_print_msymbols): Use all_objfiles.
8450         * source.c (select_source_symtab): Use all_objfiles.
8451         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8452         * symfile.c (remove_symbol_file_command)
8453         (expand_symtabs_matching, map_symbol_filenames): Use
8454         all_objfiles.
8455         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8456         all_objfiles.
8457         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8458         * objc-lang.c (find_methods): Use all_objfiles.
8459         * objfiles.c (have_partial_symbols, have_full_symbols)
8460         (have_minimal_symbols, qsort_cmp)
8461         (default_iterate_over_objfiles_in_search_order): Use
8462         all_objfiles.
8463         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8464         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8465         (maintenance_check_psymtabs): Use all_objfiles.
8466         (ALL_PSYMTABS): Remove.
8467         * compile/compile-object-run.c (do_module_cleanup): Use
8468         all_objfiles.
8469         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8470         * cp-support.c (add_symbol_overload_list_qualified): Use
8471         all_objfiles.
8472         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8473         Use all_objfiles.
8474         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8475         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8476         all_objfiles.
8477         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8478         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8479         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8480         Uses all_objfiles.
8481         * solib.c (solib_read_symbols): Use all_objfiles
8482
8483 2019-01-09  Tom Tromey  <tom@tromey.com>
8484
8485         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8486         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8487         all_objfiles.
8488         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8489         * symmisc.c (print_symbol_bcache_statistics)
8490         (print_objfile_statistics, maintenance_print_objfiles)
8491         (maintenance_info_symtabs, maintenance_check_symtabs)
8492         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8493         all_objfiles.
8494         * source.c (forget_cached_source_info): Use all_objfiles.
8495         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8496         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8497         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8498         * objfiles.c (update_section_map): Use all_objfiles.
8499         (shared_objfile_contains_address_p): Likewise.
8500         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8501         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8502
8503 2019-01-09  Tom Tromey  <tom@tromey.com>
8504
8505         * common/next-iterator.h: New file.
8506         * objfiles.h (class all_objfiles): New.
8507         (struct objfile_iterator): New.
8508
8509 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8510
8511         * NEWS: Move the description of the changed "frame", "select-frame",
8512          and "info frame" commands to the Changed commands section.
8513
8514 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8515
8516         * gdbtypes.c (check_stub_method_group): Remove handling of old
8517         mangling schemes.
8518         * linespec.c (find_methods): Likewise.
8519         * stabsread.c (read_member_functions): Likewise.
8520         * valops.c (search_struct_method): Likewise.
8521         (value_struct_elt_for_reference): Likewise.
8522         * NEWS: Mention this change.
8523
8524 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8525
8526         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8527         print_source_lines.
8528         * source.c (print_source_lines_base): Update line number check.
8529         (print_source_lines): New function.
8530         (source_lines_range::source_lines_range): New function.
8531         * source.h (class source_lines_range): New class.
8532         (print_source_lines): New declaration.
8533
8534 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8535
8536         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8537
8538 2019-01-08  Tom Tromey  <tom@tromey.com>
8539             Simon Marchi  <simon.marchi@ericsson.com>
8540
8541         PR gdb/24060
8542         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8543         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8544         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8545         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8546         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8547         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8548
8549 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8550
8551         * source.c (select_source_symtab): Move header comment to
8552         declaration in source.h.
8553         (forget_cached_source_info_for_objfile): Likewise.
8554         (forget_cached_source_info): Likewise.
8555         (identify_source_line): Likewise.
8556         * source.h (identify_source_line): Move declaration from symtab.h
8557         and add comment from source.c
8558         (print_source_lines): Likewise.
8559         (forget_cached_source_info_for_objfile): Likewise.
8560         (forget_cached_source_info): Likewise.
8561         (select_source_symtab): Likewise.
8562         (enum print_source_lines_flag): Move definition from symtab.h.
8563         * symtab.h (identify_source_line): Move declaration to source.h.
8564         (print_source_lines): Likewise.
8565         (forget_cached_source_info_for_objfile): Likewise.
8566         (forget_cached_source_info): Likewise.
8567         (select_source_symtab): Likewise.
8568         (enum print_source_lines_flag): Move definition to source.h.
8569         * tui/tui-hooks.c: Add 'source.h' include.
8570
8571 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8572
8573         * source.c (print_source_lines_base): Handle requests to print
8574         reverse line number sequences, and guard against empty lines
8575         string.
8576
8577 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8578
8579         * source.c (print_source_lines_base): Fix skip of '\r' if next
8580         character is '\n'.
8581
8582 2019-01-06  Tom Tromey  <tom@tromey.com>
8583
8584         * c-exp.y (struct c_parse_state) <macro_original_text,
8585         expansion_obstack>: New member.
8586         (macro_original_text, expansion_obstack): Remove globals.
8587         (scan_macro_expansion, scanning_macro_expansion)
8588         (finished_macro_expansion): Update.
8589         (scan_macro_cleanup): Remove.
8590         (yylex, c_parse): Update.
8591
8592 2019-01-06  Tom Tromey  <tom@tromey.com>
8593
8594         * c-exp.y (struct c_parse_state) <strings>: New member.
8595         (operator_stoken): Update.
8596
8597 2019-01-06  Tom Tromey  <tom@tromey.com>
8598
8599         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8600         (union type_stack_elt) <typelist_val>: Now a pointer to
8601         std::vector.
8602         (type_stack_cleanup): Don't declare.
8603         (push_typelist): Update.
8604         * parse.c (pop_typelist): Return a std::vector.
8605         (push_typelist): Take a std::vector.
8606         (follow_types): Update.  Do not free args.
8607         (type_stack_cleanup): Remove.
8608         * c-exp.y (struct c_parse_state): New.
8609         (cpstate): New global.
8610         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8611         (nonempty_typelist): Update.
8612         (func_mod): Create a new vector.
8613         (c_parse): Create a c_parse_state.
8614         (check_parameter_typelist): Do not delete params.
8615         (function_method): Update.  Do not delete type_list.
8616
8617 2019-01-06  Tom Tromey  <tom@tromey.com>
8618
8619         PR gdb/28155:
8620         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8621         check_typedef.
8622         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8623         (print_return_value): Likewise.
8624
8625 2019-01-05  Tom Tromey  <tom@tromey.com>
8626
8627         * contrib/cleanup_check.py: Remove.
8628         * contrib/gcc-with-excheck: Remove.
8629         * contrib/exsummary.py: Remove.
8630         * contrib/excheck.py: Remove.
8631
8632 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8633
8634         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8635         NULL. Initialize tpprev to NULL instead of assigning it
8636         to NULL on the next statement.
8637         * windows-nat.c (windows_delete_thread): Remove check for
8638         main_thread_id before printing thread exit notifications.
8639         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8640         Remove thread ID check against main_thread_id.
8641         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8642         windows_delete_thread.
8643         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8644
8645 2019-01-04  Tom Tromey  <tom@tromey.com>
8646
8647         * compile/compile.c (_initialize_compile): Use upper case for
8648         metasyntactic variables.
8649         * symmisc.c (_initialize_symmisc): Use upper case for
8650         metasyntactic variables.
8651         * psymtab.c (_initialize_psymtab): Use upper case for
8652         metasyntactic variables.
8653         * demangle.c (demangle_command): Use upper case for metasyntactic
8654         variables.
8655         (_initialize_demangler): Likewise.
8656         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8657         variables.
8658
8659 2019-01-03  Tom Tromey  <tom@tromey.com>
8660
8661         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8662
8663 2019-01-03  Tom Tromey  <tom@tromey.com>
8664
8665         * python/py-symtab.c (salpy_str): Update.
8666         (struct salpy_sal_object) <symtab>: Now a PyObject.
8667         (salpy_dealloc): Update.
8668         (del_objfile_sal): Use gdbpy_ref.
8669
8670 2019-01-03  Tom Tromey  <tom@tromey.com>
8671
8672         * python/py-type.c (convert_field): Use new_reference.  Return
8673         gdbpy_ref.
8674         (make_fielditem): Return gdbpy_ref.
8675         (typy_fields): Update.
8676         (typy_getitem): Update.
8677         (field_name): Return gdbpy_ref.  Use new_reference.
8678         (typy_iterator_iternext): Update.
8679
8680 2019-01-03  Tom Tromey  <tom@tromey.com>
8681
8682         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8683
8684 2019-01-03  Tom Tromey  <tom@tromey.com>
8685
8686         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8687         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8688         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8689         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8690         (pspy_set_type_printers): Likewise.
8691         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8692         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8693         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8694         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8695         (objfpy_set_type_printers): Likewise.
8696
8697 2019-01-03  Tom Tromey  <tom@tromey.com>
8698
8699         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8700         (gdbpy_print_stack): Use gdbpy_err_fetch.
8701         * python/python-internal.h (class gdbpy_err_fetch): New class.
8702         (class gdbpy_enter) <m_error_type, m_error_value,
8703         m_error_traceback>: Remove.
8704         <m_error>: New member.
8705         (gdbpy_exception_to_string): Don't declare.
8706         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8707         * python/py-value.c (convert_value_from_python): Use
8708         gdbpy_err_fetch.
8709         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8710         gdbpy_exception_to_string.
8711         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8712         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8713         gdbpy_err_fetch.
8714
8715 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8716
8717         * linux-nat.c (delete_lwp_cleanup): Delete.
8718         (struct lwp_deleter): New struct.
8719         (lwp_info_up): New typedef.
8720         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8721         lwp_info_up.
8722
8723 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8724
8725         * linux-fork.c (class scoped_switch_fork_info): New class.
8726         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8727
8728 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8729
8730         * valops.c (find_overload_match): Remove use of null_cleanup, and
8731         calls to do_cleanups.
8732
8733 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8734
8735         * compile/compile-cplus-types.c
8736         (compile_cplus_instance::decl_name): Handle changes to
8737         cp_func_name.
8738         * cp-support.c (cp_func_name): Update header comment, update
8739         return type.
8740         * cp-support.h (cp_func_name): Update return type in declaration.
8741         * valops.c (find_overload_match): Move temp_func local to top
8742         level of function and change its type.  Use temp_func to hold and
8743         delete temporary string obtained from cp_func_name.
8744
8745 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8746
8747         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8748         gdb::char_vector, remove cleanup, and update uses of `msg`.
8749
8750 2019-01-03  Jim Wilson  <jimw@sifive.com>
8751
8752         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8753
8754 2019-01-02  Tom Tromey  <tom@tromey.com>
8755
8756         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8757         (tdesc_parse_xml): Remove cleanups.
8758         * target-descriptions.h (make_cleanup_free_target_description):
8759         Don't declare.
8760         (target_desc_deleter): New struct.
8761         (target_desc_up): New typedef.
8762         * target-descriptions.c (target_desc_deleter::operator()): Rename
8763         from free_target_description.
8764         (make_cleanup_free_target_description): Remove.
8765
8766 2019-01-02  Tom Tromey  <tom@tromey.com>
8767
8768         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8769         constructor, destructor.
8770         (linespec_parser): Remove typedef.
8771         (~linespec_parser): Rename from linespec_parser_delete.
8772         (linespec_lex_to_end, linespec_complete_label)
8773         (linespec_complete): Update.
8774         (decode_line_full): Remove cleanups.
8775         (decode_line_1): Update.
8776
8777 2019-01-02  Tom Tromey  <tom@tromey.com>
8778
8779         * python/python-internal.h (inferior_to_inferior_object): Change
8780         return type.
8781         * python/py-exitedevent.c (create_exited_event_object): Update.
8782         * python/py-inferior.c (inferior_to_inferior_object): Return
8783         gdbpy_ref.
8784         (python_new_inferior, python_inferior_deleted)
8785         (thread_to_thread_object, delete_thread_object)
8786         (build_inferior_list, gdbpy_selected_inferior): Update.
8787         * python/py-infthread.c (create_thread_object): Update.  Also fail
8788         if inferior_to_inferior_object fails.
8789
8790 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8791
8792         * inferior.h (class inferior) <displaced_step_state>: New field.
8793         * infrun.h (struct displaced_step_state): Move here from
8794         infrun.c.  Initialize fields, add constructor.
8795         <inf>: Remove field.
8796         <reset>: New method.
8797         * infrun.c (struct displaced_step_inferior_state): Move to
8798         infrun.h.
8799         (displaced_step_inferior_states): Remove.
8800         (get_displaced_stepping_state): Adust.
8801         (displaced_step_in_progress_any_inferior): Adjust.
8802         (displaced_step_in_progress_thread): Adjust.
8803         (displaced_step_in_progress): Adjust.
8804         (add_displaced_stepping_state): Remove.
8805         (get_displaced_step_closure_by_addr): Adjust.
8806         (remove_displaced_stepping_state): Remove.
8807         (infrun_inferior_exit): Call displaced_step_state.reset.
8808         (use_displaced_stepping): Don't check for NULL.
8809         (displaced_step_prepare_throw): Call
8810         get_displaced_stepping_state.
8811         (displaced_step_fixup): Don't check for NULL.
8812         (prepare_for_detach): Don't check for NULL.
8813
8814 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8815
8816         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8817          in case of call that did not complete.
8818
8819 2019-01-02  Andrey Utkin  <autkin@undo.io>
8820
8821         * symfile.c (find_separate_debug_file): Fix search of debug files for
8822         remote debuggee.
8823
8824 2019-01-02  Tom Tromey  <tom@tromey.com>
8825
8826         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8827         indentation.
8828         * python/py-frame.c (frapy_older): Remove cast.
8829         (frapy_newer): Likewise.
8830         * python/py-breakpoint.c (local_setattro): Remove cast.
8831         * python/py-arch.c (archpy_name): Remove local variable.
8832         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8833
8834 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8835
8836         * unittests/basic_string_view/element_access/char/empty.cc:
8837         Fix year range in copyright header.
8838
8839 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8840
8841         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8842         Delete.
8843         <operator==>: Update with for removed field.
8844         <hash>: Likewise.
8845         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8846         <isa_features>: ...this.
8847         <abi_features>: New field.
8848         (riscv_isa_flen): Update comment.
8849         (riscv_abi_xlen): New declaration.
8850         (riscv_abi_flen): New declaration.
8851         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8852         isa_features.
8853         (riscv_abi_xlen): New function.
8854         (riscv_isa_flen): Update to get answer from isa_features.
8855         (riscv_abi_flen): New function.
8856         (riscv_has_fp_abi): Update to get answer from abi_features.
8857         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8858         xlen and flen.
8859         (riscv_call_info) <xlen, flen>: Update comment.
8860         (riscv_call_arg_struct): Remove invalid assertions
8861         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8862         is removed.
8863         (riscv_gdbarch_init): Gather isa features and abi features
8864         separately, ensure both match on the gdbarch when reusing an old
8865         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8866         a target with 64-bit float hardware.
8867
8868 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8869
8870         * source.c (search_command_helper): Stop reverse search
8871         when line 1 has been searched.
8872
8873 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8874
8875         * record-full.c (record_full_base_target::close): Rewrite
8876         record_full_core_buf_list free logic.
8877
8878 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8879
8880         * break-catch-syscall.c (print_one_catch_syscall): xfree
8881         the last text.
8882
8883 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8884
8885         * top.c (print_gdb_version): Update Copyright year in version
8886         message.
8887
8888 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8889
8890         Update copyright year range in all GDB files.
8891
8892 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8893
8894         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8895
8896 For older changes see ChangeLog-2018.
8897 \f
8898 Local Variables:
8899 mode: change-log
8900 left-margin: 8
8901 fill-column: 74
8902 version-control: never
8903 coding: utf-8
8904 End:
8905