gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c
   4         (tui_exec_info_window::maybe_allocate_content): New method.
   5         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
   6         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
   7         (make_source_or_disasm_window): Add cast.
   8         * tui/tui-data.h (union tui_which_element) <simple_string>:
   9         Remove.
  10         (struct tui_source_info): New.
  11         (struct tui_source_window_base) <execution_info>: Change type.
  12         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
  13         case, and add assert.
  14         (tui_alloc_content): Add assert.
  15
  16 2019-06-25  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
  19         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
  20         * tui/tui-data.c (tui_alloc_win_info): Remove.
  21
  22 2019-06-25  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
  25         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
  26         can_highlight.
  27
  28 2019-06-25  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
  31         make_visible_with_new_height method.
  32         (tui_win_info::make_visible_with_new_height): New method.
  33         (tui_source_window_base::do_make_visible_with_new_height)
  34         (tui_data_window::do_make_visible_with_new_height)
  35         (tui_cmd_window::do_make_visible_with_new_height): New methods.
  36         (make_visible_with_new_height): Remove.
  37         (tui_resize_all, tui_adjust_win_heights): Use
  38         make_visible_with_new_height method.
  39         * tui/tui-data.h (struct tui_win_info)
  40         <do_make_visible_with_new_height, make_visible_with_new_height>:
  41         New methods.
  42         (struct tui_source_window_base, struct tui_data_window)
  43         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
  44         methods.
  45
  46 2019-06-25  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
  49         method.
  50         (update_tab_width): Call update_tab_width method.
  51         * tui/tui-data.h (struct tui_win_info)
  52         (struct tui_source_window_base) <update_tab_width>: New methods.
  53
  54 2019-06-25  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
  57         parameter.
  58         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
  59         parameter.
  60         (tui_gen_win_info::make_visible): Update.
  61         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
  62         parameter.
  63         * tui/tui-data.h (enum tui_box): New enum.
  64         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
  65
  66 2019-06-25  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-layout.c (make_source_or_disasm_window): Always use
  69         init_and_make_win for EXEC_INFO_WIN.
  70         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
  71         longer inline.
  72         (struct tui_win_info) <~tui_win_info>: Inline.
  73         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
  74         Don't declare.
  75         * tui/tui-data.c (source_win, disasm_win): Remove globals.
  76         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
  77         Remove.
  78         (tui_initialize_static_data): Update.
  79         (~tui_gen_win_info): Handle more cleanup here.
  80         (~tui_source_window_base): Delete "execution_info".
  81         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
  82
  83 2019-06-25  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-layout.c (make_command_window): Don't set
  86         can_highlight.
  87         (show_source_disasm_command): Call the reset method.
  88         (show_data): Don't set can_highlight.  Call the reset method.
  89         (tui_gen_win_info::reset): Rename from init_gen_win_info
  90         (init_and_make_win): Simplify.  Return tui_gen_win_info.
  91         (show_source_or_disasm_and_command): Call the reset method.
  92         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
  93         (struct tui_cmd_window): Set can_highlight.
  94
  95 2019-06-25  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
  98         from make_visible.
  99         (tui_make_visible, tui_make_invisible): Rewrite.
 100         (tui_win_info::make_visible): Remove.
 101         (tui_source_window_base::make_visible): Update.
 102         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 103         method.  Moved from...
 104         (struct tui_win_info) <make_visible>: ...here.
 105
 106 2019-06-25  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-winsource.c
 109         (tui_source_window_base::do_scroll_horizontal): Remove direction
 110         parameter.
 111         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 112         direction parameter.
 113         * tui/tui-win.c (tui_win_info::forward_scroll)
 114         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 115         (tui_win_info::right_scroll): Update.
 116         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 117         direction parameter.
 118         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 119         direction parameter.
 120         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 121         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 122         Remove direction parameter.
 123         (struct tui_source_window_base, struct tui_source_window)
 124         (struct tui_disasm_window, struct tui_data_window)
 125         (struct tui_cmd_window): Update.
 126
 127 2019-06-25  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-winsource.h (tui_set_exec_info_content)
 130         (tui_show_exec_info_content, tui_erase_exec_info_content)
 131         (tui_clear_exec_info_content, tui_update_exec_info): Change
 132         argument to tui_source_window_base.
 133         * tui/tui-winsource.c (tui_set_exec_info_content)
 134         (tui_show_exec_info_content, tui_erase_exec_info_content)
 135         (tui_clear_exec_info_content, tui_update_exec_info): Change
 136         argument to tui_source_window_base.
 137
 138 2019-06-25  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 141         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 142
 143 2019-06-25  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 146         check.
 147
 148 2019-06-25  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 151         type to void.
 152         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 153         type to void.
 154         * tui/tui-source.c (tui_set_source_content): Update.
 155         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 156
 157 2019-06-25  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-win.c (window_name_completer, tui_set_focus)
 160         (tui_all_windows_info): Use name method.
 161         * tui/tui-data.h (struct tui_gen_win_info)
 162         (struct tui_source_window, struct tui_disasm_window)
 163         (struct tui_data_window, struct tui_cmd_window) <name>: New
 164         method.
 165         (tui_win_name): Don't declare.
 166         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 167         (tui_win_name): Remove.
 168
 169 2019-06-25  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-winsource.h (tui_update_source_window)
 172         (tui_update_source_window_as_is): Change parameter type.
 173         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 174         to be a tui_source_window_base.
 175         (tui_update_source_window_as_is): Likewise.
 176         * tui/tui-win.c (make_visible_with_new_height): Update.
 177
 178 2019-06-25  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-winsource.c (tui_erase_source_content)
 181         (tui_show_source_content, tui_show_exec_info_content)
 182         (tui_erase_exec_info_content): Use refresh_window method.
 183         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 184         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 185         from tui_refresh_win.
 186         (tui_data_window::refresh_window): New method.
 187         (tui_win_info::refresh, tui_source_window_base::refresh)
 188         (tui_refresh_all): Use refresh_window method.
 189         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 190         method.
 191         * tui/tui-regs.c (tui_display_register): Call refresh_window
 192         method.
 193         * tui/tui-layout.c (show_source_disasm_command)
 194         (show_source_or_disasm_and_command): Call refresh_window method.
 195         * tui/tui-data.h (struct tui_gen_win_info)
 196         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 197         New method.
 198
 199 2019-06-25  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui.c (tui_rl_other_window, tui_enable)
 202         (tui_is_window_visible, tui_get_command_dimension): Update.
 203         * tui/tui-winsource.c (tui_update_source_window_as_is)
 204         (tui_clear_source_content, tui_erase_source_content)
 205         (tui_show_source_line, tui_source_window_base::refill)
 206         (tui_source_window_base::do_scroll_horizontal)
 207         (tui_source_window_base::set_is_exec_point_at)
 208         (tui_update_breakpoint_info, tui_set_exec_info_content)
 209         (tui_alloc_source_buffer, tui_line_is_displayed)
 210         (tui_addr_is_displayed): Update.
 211         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 212         (tui_check_and_display_highlight_if_needed)
 213         (tui_win_info::make_visible, tui_win_info::refresh)
 214         (tui_refresh_all): Update.
 215         * tui/tui-windata.c (tui_first_data_item_displayed)
 216         (tui_delete_data_content_windows, tui_erase_data_content)
 217         (tui_display_all_data, tui_data_window::refresh_all)
 218         (tui_check_data_values): Update.
 219         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 220         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 221         (tui_win_info::backward_scroll, tui_refresh_all_win)
 222         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 223         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 224         (tui_source_window_base::set_new_height)
 225         (tui_data_window::set_new_height)
 226         (make_invisible_and_set_new_height)
 227         (make_visible_with_new_height, new_height_ok)
 228         (parse_scrolling_args): Update.
 229         * tui/tui-stack.c (tui_show_frame_info): Update.
 230         * tui/tui-source.c (tui_set_source_content)
 231         (tui_set_source_content_nil, tui_source_is_displayed)
 232         (tui_source_window::do_scroll_vertical): Update.
 233         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 234         (tui_display_registers_from, tui_display_reg_element_at_line)
 235         (tui_check_register_values, tui_reg_command): Update.
 236         * tui/tui-layout.c (tui_default_win_height)
 237         (show_source_disasm_command, show_data, init_and_make_win)
 238         (show_source_or_disasm_and_command): Update.
 239         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 240         (tui_redisplay_readline, tui_mld_flush)
 241         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 242         (tui_getc): Update.
 243         * tui/tui-disasm.c (tui_set_disassem_content)
 244         (tui_disasm_window::do_scroll_vertical): Update.
 245         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 246         Now virtual.
 247         (struct tui_win_info): Derive from tui_gen_win_info.
 248         <~tui_win_info>: Mark as override.
 249         <generic>: Remove member.
 250         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 251         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 252         (~tui_data_window, ~tui_win_info)
 253         (tui_free_all_source_wins_content): Update.
 254         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 255
 256 2019-06-25  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-layout.c (init_and_make_win): Use new.
 259         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 260         destructor, initializers.
 261         (tui_alloc_generic_win_info): Don't declare.
 262         * tui/tui-data.c (_locator): Add argument to constructor.
 263         (source_win, disasm_win): New globals.
 264         (exec_info): Remove.
 265         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 266         Update.
 267         (tui_alloc_generic_win_info): Remove.
 268         (init_content_element): Use new.
 269         (tui_win_info::tui_win_info): Update.
 270         (free_content_elements) <case DATA_WIN>: Use delete.
 271
 272 2019-06-25  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 275         * tui/tui-windata.c (tui_first_data_item_displayed)
 276         (tui_delete_data_content_windows): Update.
 277         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 278         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 279         (tui_display_registers_from, tui_check_register_values): Update.
 280         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 281         pointer.
 282         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 283         window.
 284         (tui_free_data_content): Update.
 285         (free_content_elements) <case DATA_WIN>: Free the window.
 286
 287 2019-06-25  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 290         Update.
 291         * tui/tui-layout.c (make_command_window)
 292         (show_source_disasm_command, show_data, init_and_make_win)
 293         (show_source_or_disasm_and_command): Update.
 294         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 295         method.
 296         <can_highight, is_highlighted>: Now bool.
 297         (tui_set_win_highlight): Don't declare.
 298         * tui/tui-data.c (tui_set_win_highlight): Remove.
 299
 300 2019-06-25  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-wingeneral.c (make_visible): Remove check of window
 303         type.
 304
 305 2019-06-25  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-win.c (tui_win_info::max_height)
 308         (tui_cmd_window::max_height): New methods.
 309         (new_height_ok): Call max_height.
 310         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 311         <max_height>: New method.
 312
 313 2019-06-25  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-win.c (tui_source_window_base::set_new_height)
 316         (tui_data_window::set_new_height): New methods.
 317         (make_invisible_and_set_new_height): Call set_new_height method.
 318         * tui/tui-data.h (struct tui_win_info)
 319         (struct tui_source_window_base, struct tui_data_window)
 320         <set_new_height>: New method.
 321
 322 2019-06-25  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 325         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 326         tui_refresh_data_win.
 327         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 328         method.
 329         (tui_refresh_all_win): Call the refresh_all method.
 330         (tui_set_focus): Likewise.
 331         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 332         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 333         Likewise.
 334
 335 2019-06-25  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-winsource.h (tui_refill_source_window)
 338         (tui_set_is_exec_point_at): Don't declare.
 339         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 340         (tui_source_window_base::refill): Rename from
 341         tui_refill_source_window.
 342         (tui_source_window_base::do_scroll_horizontal): Update.
 343         (tui_source_window_base::set_is_exec_point_at): Rename from
 344         tui_set_is_exec_point_at.
 345         (tui_update_all_breakpoint_info): Update.
 346         * tui/tui-stack.c (tui_show_frame_info): Update.
 347         * tui/tui-layout.c (show_data): Add cast.
 348         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 349         * tui/tui-data.h (struct tui_source_window_base) <refill,
 350         set_is_exec_point_at>: New methods.
 351         (tui_source_windows, tui_add_to_source_windows): Update types.
 352         (tui_add_to_source_windows): Remove redundant declaration.
 353         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 354         (tui_source_windows): Change return type.
 355         (tui_clear_source_windows_detail): Update.
 356         (tui_add_to_source_windows): Change type of parameter.
 357         (tui_free_all_source_wins_content): Update.
 358
 359 2019-06-25  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-wingeneral.c (tui_win_info::refresh)
 362         (tui_source_window_base::refresh): New methods.
 363         (tui_refresh_all): Call the refresh method.
 364         * tui/tui-data.h (struct tui_win_info)
 365         (struct tui_source_window_base) <refresh>: New method.
 366
 367 2019-06-25  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui.h (tui_is_window_visible): Return bool.
 370         * tui/tui.c (tui_is_window_visible): Return bool.
 371         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 372         (tui_make_visible, tui_make_invisible)
 373         (tui_win_info::make_visible)
 374         (tui_source_window_base::make_visible, make_all_visible)
 375         (tui_make_all_visible, tui_make_all_invisible): Update.
 376         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 377         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 378         bool.
 379         (struct tui_win_info, struct tui_source_window_base)
 380         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 381         * tui/tui-data.c (tui_init_generic_part): Update.
 382
 383 2019-06-25  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 386         (tui_source_window_base::make_visible): New methods.
 387         (make_all_visible): Make method call.
 388         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 389         (struct tui_source_window_base, struct tui_cmd_window): Override
 390         make_visible.
 391         (tui_win_is_source_type): Don't declare.
 392         * tui/tui-data.c (tui_win_is_source_type): Remove.
 393
 394 2019-06-25  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 397         NULL check.
 398
 399 2019-06-25  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 402         Inline constructor.  Add initializers for members.
 403         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 404         constructors; now inline in class.
 405
 406 2019-06-25  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-regs.c (tui_show_registers): Update.
 409         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 410         bool.
 411         * tui/tui-data.c (tui_data_window::clear_detail)
 412         (tui_data_window): Update.
 413
 414 2019-06-25  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-windata.c (tui_display_all_data)
 417         (tui_display_data_from_line, tui_display_data_from)
 418         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 419         Update.
 420         * tui/tui-regs.c (tui_last_regs_line_no)
 421         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 422         (tui_show_registers, tui_show_register_group)
 423         (tui_display_registers_from, tui_display_reg_element_at_line)
 424         (tui_display_registers_from_line, tui_check_register_values)
 425         (tui_reg_next, tui_reg_prev): Update.
 426         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 427         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 428         tui_data_window.
 429         (struct tui_win_info) <detail>: Remove.  Add new fields from
 430         tui_data_info.
 431         (TUI_DATA_WIN): Add cast.
 432         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 433         (~tui_data_window): Simplify.
 434
 435 2019-06-25  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-layout.c (show_source_disasm_command)
 438         (show_source_or_disasm_and_command): Update.
 439         * tui/tui-io.c (update_cmdwin_start_line)
 440         (tui_redisplay_readline): Update.
 441         * tui/tui-data.h (struct tui_command_info): Remove.
 442         (struct tui_win_info) <detail>: Remove command_info member.
 443         (struct tui_data_window) <start_line>: New member, from
 444         tui_command_info.
 445         (TUI_CMD_WIN): Add casts.
 446
 447 2019-06-25  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-winsource.c (tui_update_source_window)
 450         (tui_refill_source_window)
 451         (tui_source_window_base::do_scroll_horizontal)
 452         (tui_update_breakpoint_info, tui_set_exec_info_content)
 453         (tui_show_exec_info_content, tui_erase_exec_info_content)
 454         (tui_clear_exec_info_content): Update.
 455         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 456         Update.
 457         * tui/tui-win.c (make_invisible_and_set_new_height)
 458         (make_visible_with_new_height): Update.
 459         * tui/tui-source.c (tui_set_source_content)
 460         (tui_show_symtab_source): Update.
 461         * tui/tui-layout.c (extract_display_start_addr)
 462         (show_source_disasm_command, show_data)
 463         (make_source_or_disasm_window)
 464         (show_source_or_disasm_and_command): Update.
 465         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 466         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 467         "gdbarch".
 468         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 469         to tui_source_window_base.
 470         (struct tui_win_info) <detail>: Remove source_info member.
 471         (struct tui_source_window_base) <has_locator>: Inline.
 472         Move contents from tui_source_info; rename has_locator member to
 473         m_has_locator.
 474         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 475         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 476         header file.
 477         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 478         Simplify.
 479         (tui_free_all_source_wins_content): Cast to
 480         tui_source_window_base.
 481
 482 2019-06-25  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-win.c (make_invisible_and_set_new_height)
 485         (make_visible_with_new_height): Call has_locator method.
 486         * tui/tui-layout.c (show_source_disasm_command, show_data)
 487         (show_source_or_disasm_and_command): Update for bool change.
 488         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 489         (tui_win_info) <has_locator>: New method.
 490         (struct tui_source_window_base) <has_locator>: New method.
 491         (tui_win_has_locator): Don't declare.
 492         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 493         from tui_win_has_locator.
 494         (tui_source_window_base): Use false, not FALSE.
 495
 496 2019-06-25  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 499         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 500         clear_detail method directly.
 501         (tui_clear_win_detail): Remove.
 502
 503 2019-06-25  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 506         "this", not TUI_DISASM_WIN.
 507
 508 2019-06-25  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 511         declare.
 512         * tui/tui-winsource.c
 513         (tui_source_window_base::do_scroll_horizontal): Rename from
 514         tui_horizontal_source_scroll.
 515         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 516         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 517         from tui_vertical_data_scroll.
 518         * tui/tui-win.h (tui_scroll): Don't declare.
 519         * tui/tui-win.c (tui_win_info::forward_scroll)
 520         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 521         (tui_win_info::right_scroll): Rename and update.
 522         (tui_scroll_forward_command, tui_scroll_backward_command)
 523         (tui_scroll_left_command, tui_scroll_right_command): Update.
 524         (tui_scroll): Remove.
 525         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 526         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 527         from tui_vertical_source_scroll.
 528         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 529         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 530         from tui_vertical_disassem_scroll.
 531         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 532         do_scroll_horizontal>: New methods.
 533         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 534         Likewise.
 535         (struct tui_source_window_base): Add do_scroll_horizontal.
 536         (struct tui_source_window, struct tui_disasm_window): Add
 537         do_scroll_vertical.
 538         (struct tui_data_window, struct tui_cmd_window): Add
 539         do_scroll_horizontal and do_scroll_vertical.
 540         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 541
 542 2019-06-25  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-data.h (struct tui_source_window_base): New struct.
 545         (struct tui_source_window): Derive from tui_source_window_base.
 546         (struct tui_disasm_window): New struct.
 547         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 548         from tui_source_window::clear_detail.
 549         (tui_source_window_base): Rename from tui_source_window.
 550         (~tui_source_window_base): Rename from ~tui_source_window.
 551         (tui_alloc_win_info): Create a tui_disasm_window.
 552
 553 2019-06-25  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-data.h (struct tui_source_window)
 556         (struct tui_data_window): Declare destructors.
 557         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 558         destructors.
 559         (tui_win_info): Simplify.
 560
 561 2019-06-25  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-winsource.c (tui_display_main)
 564         (tui_update_source_windows_with_addr)
 565         (tui_update_all_breakpoint_info): Update.
 566         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 567         (new_height_ok, parse_scrolling_args): Update.
 568         * tui/tui-stack.c (tui_show_frame_info): Update.
 569         * tui/tui-data.h (struct tui_list): Remove.
 570         (tui_source_windows): Return a reference to a std::vector.
 571         * tui/tui-data.c (source_windows): Now a std::vector.
 572         (tui_source_windows): Change return type.
 573         (tui_clear_source_windows): Rewrite.
 574         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 575         (tui_free_all_source_wins_content): Rewrite.
 576
 577 2019-06-25  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 580         (struct tui_data_window, struct tui_cmd_window): Declare
 581         clear_detail method.
 582         * tui/tui-data.c (tui_source_window::clear_detail)
 583         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 584         methods.
 585         (tui_clear_win_detail): Simplify.
 586
 587 2019-06-25  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-layout.c (make_source_window, make_disasm_window)
 590         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 591         Return the new window.
 592         (show_source_disasm_command, show_data)
 593         (show_source_or_disasm_and_command): Update.
 594
 595 2019-06-25  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 598         parameter.  Return the new window.
 599         (show_source_disasm_command): Update and remove NULL check.
 600         (show_source_or_disasm_and_command): Update.
 601
 602 2019-06-25  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 605
 606 2019-06-25  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-data.h (struct tui_win_info): Make constructor
 609         protected.  Make destructor virtual.  Add initializers.
 610         (tui_source_window, tui_data_window, tui_cmd_window): New
 611         classes.
 612         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 613         constructor.  Add "type" parameter.
 614         (tui_source_window, tui_data_window, tui_cmd_window): New
 615         constructors.
 616         (tui_alloc_win_info): Instantiate the appropriate subclass.
 617
 618 2019-06-25  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-win.c (tui_resize_all): Use delete.
 621         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 622         destructor.
 623         (tui_free_window): Don't declare.
 624         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 625         Update.
 626
 627 2019-06-25  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-data.h (struct tui_win_info): Add constructor.
 630         * tui/tui-data.c (tui_alloc_win_info): Use new.
 631         (tui_free_window): Use delete.
 632
 633 2019-06-22  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 636         declare.
 637         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 638
 639 2019-06-22  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 642         declare.
 643         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 644
 645 2019-06-22  Tom de Vries  <tdevries@suse.de>
 646
 647         * dwarf2read.c (create_addrmap_from_aranges)
 648         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 649         instead of '%zu'.
 650
 651 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 652
 653         * dwarf2read.h (dwarf2_section_info_def): Remove.
 654         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 655         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 656         std::vector<dwarf2_section_info>.
 657         (struct dwo_file) <~dwo_file>: Remove.
 658         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 659         types field.
 660         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 661         (dwarf2_read_debug_names): Likewise.
 662         (create_debug_types_hash_table): Change parameter type to
 663         array_view, adjust code accordingly.
 664         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 665         (partial_die_info::fixup): Likewise.
 666         (determine_prefix): Likewise.
 667         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 668
 669 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 670
 671         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 672         gdb_bfd_ref_ptr.
 673         <~dwo_file>: Remove call to gdb_bfd_unref.
 674         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 675         gdb_bfd_ref_ptr::get.
 676
 677 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 678
 679         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 680         type to htab_up.
 681         * dwarf2read.c (struct dwo_file): Initialize fields.
 682         <~dwo_file>: New.
 683         (free_dwo_file): Remove, move content to ~dwo_file.
 684         (struct dwo_file_deleter): Remove.
 685         (dwo_file_up>: Remove custom deleter.
 686         (free_dwo_files): Remove.
 687         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 688         dwo_files.
 689         (process_skeletonless_type_units): Call unique_ptr::get.
 690         (allocate_dwo_file_hash_table): Add deleter to created hash
 691         table.  Change return type to htab_up.
 692         (lookup_dwo_file_slot): Don't memset dwo_file, call
 693         unique_ptr::get.
 694         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 695         (create_dwo_unit_in_dwp_v2): Likewise.
 696         (open_and_init_dwo_file): Likewise.
 697         (free_dwo_file_from_slot): Remove.
 698
 699 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 700
 701         * dwarf2read.h (struct dwarf2_section_info) <readin,
 702         is_virtual>: Change type to bool.
 703         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 704         true instead of 1.
 705
 706 2019-06-19  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-data.h (tui_init_content_element): Don't declare.
 709
 710 2019-06-19  Tom Tromey  <tom@tromey.com>
 711
 712         * tui/tui-data.h (tui_init_win_info): Don't declare.
 713
 714 2019-06-19  Tom de Vries  <tdevries@suse.de>
 715
 716         * dwarf2read.h (abstract_to_concrete): Change type to
 717         std::unordered_map<sect_offset, std::vector<sect_offset>,
 718         gdb::hash_enum<sect_offset>>.
 719
 720 2019-06-19  Tom Tromey  <tromey@adacore.com>
 721
 722         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 723         EVAL_AVOID_SIDE_EFFECTS specially.
 724
 725 2019-06-19  Tom Tromey  <tromey@adacore.com>
 726
 727         * source-cache.c (highlighter): New global.
 728         (source_cache::get_source_lines): Create a highlighter on demand.
 729
 730 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * defs.h (deprecated_interactive_hook): Delete declaration.
 733         * interps.c (clear_interpreter_hooks): Remove use of
 734         deprecated_interactive_hook.
 735         * top.c (deprecated_interactive_hook): Delete definition.
 736         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 737
 738 2019-06-18  Tom de Vries  <tdevries@suse.de>
 739
 740         PR gdb/24515
 741         * dwarf2read.h (abstract_to_concrete): Change type from
 742         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 743         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 744         * dwarf2read.c (read_variable): Update.
 745         (dwarf2_fetch_die_loc_sect_off): Update.
 746
 747 2019-06-17  Tom de Vries  <tdevries@suse.de>
 748
 749         PR gdb/24617
 750         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 751         accessing parent[parent_len - 1].
 752
 753 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 754
 755         PR gdb/24364
 756         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 757         call dtrace_process_dof with NULL dof.
 758
 759 2019-06-16  Tom de Vries  <tdevries@suse.de>
 760
 761         PR gdb/24445
 762         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 763
 764 2019-06-16  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 767         (make_all_visible): Use address of member.
 768
 769 2019-06-16  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 772         (tui_free_window, free_content, free_content_elements): Remove
 773         unnecessary cast.
 774         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 775         cast.
 776         * tui/tui-regs.c (tui_show_register_group)
 777         (tui_display_registers_from, tui_display_reg_element_at_line):
 778         Remove unnecessary cast.
 779
 780 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 781
 782         * linux-nat.c (normal_mask): Delete.
 783         (_initialize_linux_nat): Don't initialise normal_mask.
 784
 785 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 786
 787         PR gdb/24445
 788         * dwarf-index-write.h (write_psymtabs_to_index): Add
 789         dwz_basename parameter.
 790         * dwarf-index-write.c (write_gdbindex): Move file writing to
 791         write_gdbindex_1.  Change return type void.
 792         (assert_file_size): Move up, remove filename parameter.
 793         (write_gdbindex_1): New function.
 794         (write_debug_names): Change return type to void, call
 795         assert_file_size.
 796         (struct index_wip_file): New struct.
 797         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 798         file logic to index_wip_file.  Write index for dwz file if
 799         needed.
 800         (save_gdb_index_command): Pass basename of dwz file, if present.
 801         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 802         build-id of dwz file, if present.
 803         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 804         (dwarf2_get_dwz_file): Likewise.
 805         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 806         (dwarf2_get_dwz_file): Likewise.
 807
 808 2019-06-16  Tom Tromey  <tom@tromey.com>
 809
 810         * coffread.c (process_coff_symbol): Use xstrdup.
 811         * value.c (create_internalvar): Use xstrdup.
 812
 813 2019-06-16  Tom Tromey  <tom@tromey.com>
 814
 815         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 816         * breakpoint.c (stopin_command, stopat_command)
 817         (until_break_command, decode_location_default): Remove unnecessary
 818         cast.
 819         * utils.c (subset_compare): Remove unnecessary cast.
 820         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 821         cast.
 822         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 823         cast.
 824         * infcmd.c (path_command): Remove unnecessary cast.
 825         * coffread.c (decode_type): Remove unnecessary cast.
 826         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 827         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 828         * tui/tui-stack.c (tui_show_locator_content)
 829         (tui_show_frame_info): Remove unnecessary cast.
 830         * tui/tui-win.c (tui_scroll_forward_command)
 831         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 832         (parse_scrolling_args): Remove unnecessary cast.
 833         * tui/tui-data.c (init_win_info, tui_del_window)
 834         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 835         (free_content_elements): Remove unnecessary cast.
 836         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 837         unnecessary cast.
 838         * tui/tui-source.c (tui_set_source_content)
 839         (tui_vertical_source_scroll): Remove unnecessary cast.
 840         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 841         cast.
 842         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 843         * tui/tui-regs.c (tui_display_registers_from)
 844         (tui_display_register): Remove unnecessary cast.
 845         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 846         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 847         (make_visible): Remove unnecessary cast.
 848         * tui/tui-winsource.c (tui_erase_source_content)
 849         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 850         unnecessary cast.
 851         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 852         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 853         * stabsread.c (read_type, read_array_type, read_range_type):
 854         Remove unnecessary cast.
 855         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 856         (parse_symbol, parse_type, upgrade_type, parse_external)
 857         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 858         unnecessary cast.
 859         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 860
 861 2019-06-16  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-data.c (tui_alloc_generic_win_info)
 864         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 865         checks.
 866
 867 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 868             Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * f-typeprint.c (f_print_type): Don't return early for not
 871         associated or not allocated types.
 872         (f_type_print_varspec_suffix): Add print_rank parameter and print
 873         ranks of array types in case they dangling.
 874         (f_type_print_base): Add print_rank parameter.
 875
 876 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 877
 878         * NEWS: Mention new MI commands.
 879         * break-catch-throw.c (enum exception_event_kind): Move to
 880         breakpoint.h.
 881         (print_mention_exception_catchpoint): Output text as a single
 882         message.
 883         (catch_exception_command_1): Rename to...
 884         (catch_exception_event): ...this, make non-static, update header
 885         command, and change some parameter types.
 886         (catch_catch_command): Update for changes to
 887         catch_exception_command_1.
 888         (catch_throw_command): Likewise.
 889         (catch_rethrow_command): Likewise.
 890         * breakpoint.c (enum exception_event_kind): Delete.
 891         * breakpoint.h (enum exception_event_kind): Moved here from
 892         break-catch-throw.c.
 893         (catch_exception_event): Declare.
 894         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 895         (mi_cmd_catch_throw): New function.
 896         (mi_cmd_catch_rethrow): New function.
 897         (mi_cmd_catch_catch): New function.
 898         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 899         'catch-catch' entries.
 900         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 901         (mi_cmd_catch_rethrow): Declare.
 902         (mi_cmd_catch_catch): Declare.
 903
 904 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * annotate.c (annotate_source_line): Change return type to void,
 907         update implementation to match.
 908         * annotate.h (annotate_source_line): Change return type to void,
 909         update header comment.
 910         * stack.c (print_frame_info): Don't change what frame information
 911         is printed based on whether annotations are on or not.
 912
 913 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 916         (annotate_source): Make static.
 917         (annotate_source_line): Moved from source.c and renamed from
 918         identify_source_line.  Update the return type.
 919         * annotate.h (annotate_source): Delete declaration.
 920         (annotate_source_line): Declaration moved from source.h, and
 921         renamed from identify_source_line.  Return type updated.
 922         * source.c (identify_source_line): Moved to annotate.c and renamed
 923         to annotate_source_line.
 924         (info_line_command): Remove check of annotation_level.
 925         * source.h (identify_source_line): Move declaration to annotate.h
 926         and rename to annotate_source_line.
 927         * stack.c: Add 'annotate.h' include.
 928         (print_frame_info): Remove check of annotation_level before
 929         calling annotate_source_line.
 930
 931 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * source-cache.c (source_cache::get_plain_source_lines): Use
 934         open_source_file_with_line_charpos instead of just
 935         open_source_file, remove call to find_source_lines.
 936         (source_cache::get_source_lines): Likewise.
 937         * source.c (find_source_lines): Make static.
 938         (get_filename_and_charpos): Renamed into...
 939         (open_source_file_with_line_charpos): ..this along with changes to
 940         return a scoped_fd, and some other minor clean ups.
 941         (identify_source_line): Use open_source_file_with_line_charpos.
 942         (search_command_helper): Use open_source_file_with_line_charpos
 943         instead of just open_source_file, remove call to
 944         find_source_lines.
 945         * source.h (open_source_file_with_line_charpos): Declare new
 946         function.
 947         (find_source_lines): Delete declaration.
 948
 949 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 950
 951         * source.c (get_filename_and_charpos): Remove fullname
 952         parameter.
 953         (identify_source_line): Update call to get_filename_and_charpos.
 954
 955 2019-06-14  Tom Tromey  <tromey@adacore.com>
 956
 957         PR gdb/24502:
 958         * ui-style.h (skip_ansi_escape): Update comment.
 959         * ui-file.h (class no_terminal_escape_file): New class.
 960         * ui-file.c (no_terminal_escape_file::write)
 961         (no_terminal_escape_file::puts): New methods.
 962         * cli/cli-logging.c (handle_redirections): Use
 963         no_terminal_escape_file.
 964
 965 2019-06-14  Tom Tromey  <tromey@adacore.com>
 966
 967         * NEWS: Move convenience variable news above Python news.
 968
 969 2019-06-14  Tom Tromey  <tom@tromey.com>
 970
 971         * gnulib: Move directory to top-level.
 972         * configure.ac: Don't configure gnulib.
 973         * configure: Rebuild.
 974         * common/common-defs.h: Use new path to gnulib.
 975         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 976         (GNULIB_H): Remove.
 977         (INCGNU): Look in new gnulib location.
 978         (HFILES_NO_SRCDIR): Remove gnulib files.
 979         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 980         (generated_files): Remove GNULIB_H.
 981         ($(LIBGNU), all-lib): Remove targets.
 982         (distclean): Don't mention GNULIB_BUILDDIR.
 983         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 984
 985 2019-06-14  Tom Tromey  <tromey@adacore.com>
 986
 987         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 988         Warn if symbol file does not provide any symbols.
 989
 990 2019-06-14  Tom Tromey  <tromey@adacore.com>
 991
 992         * source.c (find_and_open_source): Respect basenames_may_differ.
 993
 994 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 995
 996         * annotate.c (annotate_breakpoints_invalid): Make use of
 997         scoped_restore_terminal_state.
 998         (annotate_frames_invalid): Likewise.
 999
1000 2019-06-14  Tom Tromey  <tromey@adacore.com>
1001
1002         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1003         allow assignment to an internalvar.
1004
1005 2019-06-14  Tom Tromey  <tromey@adacore.com>
1006
1007         * ada-lex.l: Allow "_" in attribute names.
1008
1009 2019-06-14  Tom Tromey  <tromey@adacore.com>
1010
1011         PR gdb/24653:
1012         * regcache.c (registers_changed): Don't call alloca.
1013         * top.c (execute_command): Don't call alloca.
1014
1015 2019-06-13  Pedro Alves  <palves@redhat.com>
1016
1017         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1018         'expression'.  When parsing an expression, error out if there's
1019         junk after "unlimited".
1020         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1021         (do_set_command): Adjust calls to is_unlimited_literal.
1022
1023 2019-06-13  Pedro Alves  <palves@redhat.com>
1024
1025         * compile/compile.c (make_compile_options_def_group): Add braces
1026         around array_view initializer.
1027         * thread.c (make_thread_apply_all_options_def_group)
1028         (make_thread_apply_all_options_def_group): Likewise.
1029
1030 2019-06-13  Pedro Alves  <palves@redhat.com>
1031
1032         * NEWS (New commands): Mention "maint test-options
1033         require-delimiter", "maint test-options unknown-is-error", "maint
1034         test-options unknown-is-operand" and "maint show
1035         test-options-completion-result".
1036         (New command options, command completion): New section.
1037         (Completion improvements): New section.
1038         Mention that you can abbreviate "unlimited".
1039
1040 2019-06-13  Pedro Alves  <palves@redhat.com>
1041
1042         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1043         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1044         * unittests/cli-utils-selftests.c (test_parse_flags)
1045         (test_parse_flags_qcs): Delete.
1046         (test_cli_utils): Don't call deleted functions.
1047
1048 2019-06-13  Pedro Alves  <palves@redhat.com>
1049
1050         * thread.c: Include "cli/cli-option.h".
1051         (tp_array_compar_ascending): Global.
1052         (tp_array_compar): Delete function.
1053         (tp_array_compar_ascending, tp_array_compar_descending): New
1054         functions.
1055         (ascending_option_def, qcs_flag_option_def)
1056         (thr_qcs_flags_option_defs)
1057         (make_thread_apply_all_options_def_group)
1058         (make_thread_apply_options_def_group): New.
1059         (thread_apply_all_command): Use gdb::option::process_options.
1060         (thread_apply_command_completer)
1061         (thread_apply_all_command_completer): New.
1062         (thread_apply_command): Use gdb::option::process_options.
1063         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1064         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1065         to generate help text of "thread apply".  Adjust "taas"'s help.
1066         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1067         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1068
1069 2019-06-13  Pedro Alves  <palves@redhat.com>
1070
1071         * thread.c (thread_apply_command): Check for invalid TID with
1072         isdigit instead of !isalpha.
1073
1074 2019-06-13  Pedro Alves  <palves@redhat.com>
1075
1076         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1077         (validate_flags_qcs): New.
1078         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1079         (validate_flags_qcs): Declare.
1080         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1081         (make_frame_apply_options_def_group): New.
1082         (frame_apply_command_count): Process options with
1083         gdb::option::process_options.
1084         (frame_apply_completer): New.
1085         (frame_apply_level_completer, frame_apply_all_completer)
1086         (frame_apply_completer): New.
1087         (_initialize_stack): Update help of "frame apply", "frame apply
1088         level", "frame apply all" and "faas" to mention supported options
1089         and install command completers.
1090         * stack.h (frame_apply_all_completer): Declare.
1091         * thread.c: Include "stack.h".
1092         (tfaas_command): Add "--".
1093         (_initialize_thread): Update help "tfaas" to mention supported
1094         options and install command completer.
1095
1096 2019-06-13  Pedro Alves  <palves@redhat.com>
1097
1098         * completer.c (complete_nested_command_line): New.
1099         (gdb_completion_word_break_characters_throw): Add assertion.
1100         * completer.h (complete_nested_command_line): Declare.
1101
1102 2019-06-13  Pedro Alves  <palves@redhat.com>
1103
1104         * stack.c (parse_backtrace_qualifiers): New.
1105         (backtrace_command): Use it.
1106         (backtrace_command_completer): Complete on qualifiers.
1107
1108 2019-06-13  Pedro Alves  <palves@redhat.com>
1109
1110         * frame.c: Include "cli/cli-option.h.
1111         (user_set_backtrace_options): New.
1112         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1113         Delete.
1114         (get_prev_frame): Adjust.
1115         (boolean_option_def, uinteger_option_def)
1116         (set_backtrace_option_defs): New.
1117         (_initialize_frame): Adjust and use
1118         gdb::option::add_setshow_cmds_for_options to install "set
1119         backtrace past-main" and "set backtrace past-entry".
1120         * frame.h: Include "cli/cli-option.h".
1121         (struct frame_print_options): Forward declare.
1122         (print_frame_arguments_all, print_frame_arguments_scalars)
1123         (print_frame_arguments_none): Declare.
1124         (print_entry_values): Delete declaration.
1125         (struct frame_print_options, user_frame_print_options): New.
1126         (struct set_backtrace_options): New.
1127         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1128         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1129         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1130         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1131         (list_args_or_locals): Add frame_print_options parameter.
1132         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1133         * python/py-framefilter.c (enumerate_args): Pass down
1134         USER_FRAME_PRINT_OPTIONS.
1135         * stack.c: Include "cli/cli-option.h".
1136         (print_frame_arguments_all, print_frame_arguments_scalars)
1137         (print_frame_arguments_none): Declare.
1138         (print_raw_frame_arguments, print_entry_values): Delete.
1139         (user_frame_print_options): New.
1140         (boolean_option_def, enum_option_def, frame_print_option_defs):
1141         New.
1142         (struct backtrace_cmd_options): New.
1143         (bt_flag_option_def): New.
1144         (backtrace_command_option_defs): New.
1145         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1146         (print_frame_arg, read_frame_arg, print_frame_args)
1147         (print_frame_info, print_frame): Add frame_print_options parameter
1148         and use it.
1149         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1150         (backtrace_command_1): Add frame_print_options and
1151         backtrace_cmd_options parameters and use them.
1152         (make_backtrace_options_def_group): New.
1153         (backtrace_command): Process command options with
1154         gdb::option::process_options.
1155         (backtrace_command_completer): New.
1156         (_initialize_stack): Extend "backtrace"'s help to mention
1157         supported options.  Install completer for "backtrace".
1158         Install some settings commands with add_setshow_cmds_for_options.
1159
1160 2019-06-13  Pedro Alves  <palves@redhat.com>
1161
1162         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1163         and that "set/show print raw frame-arguments" are now deprecated.
1164
1165         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1166         command.
1167         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1168         * stack.c (_initialize_stack): Install "set/show print
1169         raw-frame-arguments", and deprecate "set/show print raw
1170         frame-arguments".
1171         * valprint.c (_initialize_valprint): Deprecate "set/show print
1172         raw".
1173
1174 2019-06-13  Pedro Alves  <palves@redhat.com>
1175
1176         * compile/compile.c (struct compile_options): New.
1177         (compile_flag_option_def, compile_command_option_defs)
1178         (make_compile_options_def_group): New.
1179         (compile_file_command): Handle options with
1180         gdb::option::process_options.
1181         (compile_file_command_completer): New function.
1182         (compile_code_command): Handle options with
1183         gdb::option::process_options.
1184         (compile_code_command_completer): New function.
1185         (_initialize_compiler): Install completers for "compile code" and
1186         "compile file".  Mention available options in "compile code" and
1187         "compile code"'s help.
1188         * completer.c (advance_to_completion_word): New, factored out from
1189         ...
1190         (advance_to_expression_complete_word_point): ... this.
1191         (advance_to_filename_complete_word_point): New.
1192         * completer.h (advance_to_filename_complete_word_point): New
1193         declaration.
1194
1195 2019-06-13  Pedro Alves  <palves@redhat.com>
1196
1197         * compile/compile.c: Include "cli/cli-option.h".
1198         (compile_print_value): Scope data pointer is now a
1199         value_print_options pointer; adjust.
1200         (compile_print_command): Process options.  Scope data pointer is
1201         now a value_print_options pointer; adjust.
1202         (_initialize_compile): Update "compile print"'s help to include
1203         supported options.  Install a completer for "compile print".
1204         * cp-valprint.c (show_vtblprint, show_objectprint)
1205         (show_static_field_print): Delete.
1206         (_initialize_cp_valprint): Don't install "set print
1207         static-members", "set print vtbl", "set print object" here.
1208         * printcmd.c: Include "cli/cli-option.h" and
1209         "common/gdb_optional.h".
1210         (print_command_parse_format): Rework to fill in a
1211         value_print_options instead of a format_data.
1212         (print_value): Change parameter type from format_data pointer to
1213         value_print_options reference.  Adjust.
1214         (print_command_1): Process options.  Adjust to pass down a
1215         value_print_options.
1216         (print_command_completer): New.
1217         (_initialize_printcmd): Install print_command_completer as
1218         handle_brkchars completer for the "print" command.  Update
1219         "print"'s help to include supported options.
1220         * valprint.c: Include "cli/cli-option.h".
1221         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1222         here from cp-valprint.c.
1223         (boolean_option_def, uinteger_option_def)
1224         (value_print_option_defs, make_value_print_options_def_group):
1225         New.  Use gdb::option::add_setshow_cmds_for_options to install
1226         "set print elements", "set print null-stop", "set print repeats",
1227         "set print pretty", "set print union", "set print array", "set
1228         print address", "set print symbol", "set print array-indexes".
1229         * valprint.h: Include <string> and "cli/cli-option.h".
1230         (make_value_print_options_def_group): Declare.
1231         (print_value): Change parameter type from format_data pointer to
1232         value_print_options reference.
1233         (print_command_completer): Declare.
1234
1235 2019-06-13  Pedro Alves  <palves@redhat.com>
1236
1237         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1238         (COMMON_SFILES): Add maint-test-settings.c.
1239         * cli/cli-decode.c (boolean_enums): New global, factored out from
1240         ...
1241         (add_setshow_boolean_cmd): ... here.
1242         * cli/cli-decode.h (boolean_enums): Declare.
1243         * cli/cli-option.c: New file.
1244         * cli/cli-option.h: New file.
1245         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1246         factored out from ...
1247         (parse_cli_boolean_value(const char *)): ... this.
1248         (is_unlimited_literal): Change parameter type to pointer to
1249         pointer.  Adjust and advance ARG pointer.
1250         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1251         (parse_cli_var_enum): New, factored out from ...
1252         (do_set_command): ... this.  Adjust.
1253         * cli/cli-setshow.h (parse_cli_boolean_value)
1254         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1255         (parse_cli_var_enum): Declare.
1256         * cli/cli-utils.c: Include "cli/cli-option.h".
1257         (get_ulongest): New.
1258         * cli/cli-utils.h (get_ulongest): Declare.
1259         (check_for_argument): New overloads.
1260         * maint-test-options.c: New file.
1261
1262 2019-06-13  Pedro Alves  <palves@redhat.com>
1263
1264         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1265         parse a range if "-" is at the end of the string.
1266
1267 2019-06-13  Pedro Alves  <palves@redhat.com>
1268
1269         * cli/cli-setshow.c (parse_auto_binary_operation)
1270         (parse_cli_boolean_value): Don't allow "o".
1271
1272 2019-06-13  Pedro Alves  <palves@redhat.com>
1273
1274         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1275         * NEWS: Mention maint test-settings KIND.
1276         * maint-test-settings.c: New file.
1277
1278 2019-06-13  Pedro Alves  <palves@redhat.com>
1279
1280         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1281         completer.
1282         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1283         "set" completers.
1284
1285 2019-06-13  Pedro Alves  <palves@redhat.com>
1286
1287         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1288         after item.
1289
1290 2019-06-13  Pedro Alves  <palves@redhat.com>
1291
1292         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1293
1294 2019-06-13  Pedro Alves <palves@redhat.com>
1295
1296         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1297         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1298         call.
1299         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1300         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1301         calls.
1302         (check_for_argument): Skip spaces after argument.
1303
1304 2019-06-13  Pedro Alves  <palves@redhat.com>
1305
1306         * thread.c (thread_apply_command): Adjust TID parsing.
1307         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1308         detected before end of string.
1309         (tid_is_in_list): Error out if LIST is invalid.
1310
1311 2019-06-13  Pedro Alves  <palves@redhat.com>
1312
1313         * completer.c (complete_line_internal_1): Rewind completion word
1314         point.
1315         (completion_tracker::advance_custom_word_point_by): Change
1316         parameter type to int.
1317         * completer.h (completion_tracker::advance_custom_word_point_by):
1318         Likewise.
1319
1320 2019-06-13  Pedro Alves  <palves@redhat.com>
1321
1322         * completer.c (advance_to_completion_word): Handle delimiters.
1323
1324 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1325
1326         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1327
1328 2019-06-11  Tom Tromey  <tom@tromey.com>
1329
1330         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1331         (xmalloc_failed): Move to alloc.c.
1332         * alloc.c: New file.
1333         * Makefile.in (COMMON_SFILES): Add alloc.c.
1334
1335 2019-06-11  Tom Tromey  <tom@tromey.com>
1336
1337         * nat/linux-waitpid.c: Don't include server.h.
1338         (linux_debug): Remove.
1339         (my_waitpid): Update.
1340
1341 2019-06-11  Tom Tromey  <tromey@adacore.com>
1342
1343         * infcall.c (_initialize_infcall): Remove trailing newline from
1344         help.
1345         * user-regs.c (_initialize_user_regs): Remove trailing newline
1346         from help.
1347         * typeprint.c (_initialize_typeprint): Remove trailing newline
1348         from help.
1349         * reverse.c (_initialize_reverse): Remove trailing newlines from
1350         help.
1351         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1352         from help.
1353         * language.c (add_set_language_command): Remove trailing newline
1354         from help.
1355         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1356         help.
1357         * disasm.c (_initialize_disasm): Remove trailing newline from
1358         help.
1359         * top.c (init_main): Remove trailing newline from help.
1360         * interps.c (_initialize_interpreter): Remove trailing newline
1361         from help.
1362         * btrace.c (_initialize_btrace): Remove trailing newlines from
1363         help.
1364         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1365         from help.
1366         * python/python.c (_initialize_python): Remove trailing newline
1367         from help.
1368         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1369         help.
1370         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1371         from help.  Reformat some text.
1372         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1373         from help.
1374         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1375         newline from help.
1376
1377 2019-06-11  Tom Tromey  <tromey@adacore.com>
1378
1379         * darwin-nat.c (darwin_decode_exception_message)
1380         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1381
1382 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1383
1384         * valops.c (value_slice): Check for not allocated or not
1385         associated values.
1386
1387 2019-06-10  Tom de Vries  <tdevries@suse.de>
1388
1389         PR gdb/24618
1390         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1391         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1392         invalid.
1393
1394 2019-06-10  Tom de Vries  <tdevries@suse.de>
1395
1396         PR gdb/24611
1397         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1398         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1399
1400 2019-06-10  Tom de Vries  <tdevries@suse.de>
1401
1402         PR symtab/24545
1403         * symtab.c (struct demangled_name_entry): Add language field.
1404         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1405         static minimal symbol".  Set and use language field.
1406
1407 2019-06-10  Tom Tromey  <tromey@adacore.com>
1408
1409         * ada-lang.c (_initialize_ada_language): Update help text.
1410
1411 2019-06-10  Tom Tromey  <tromey@adacore.com>
1412
1413         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1414         with a newline.
1415         * guile/guile.c (handle_boot_error): Don't end warning with a
1416         newline.
1417         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1418         warning with a newline.
1419         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1420         newline.
1421         (s12z_frame_cache): Likewise.
1422         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1423         a newline.
1424         * solib-svr4.c (disable_probes_interface): Don't end warning with
1425         a newline.
1426         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1427         newline.
1428         * python/python.c (do_finish_initialization): Don't end warning
1429         with a newline.
1430
1431 2019-06-10  Tom Tromey  <tom@tromey.com>
1432
1433         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1434         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1435         gdbpy_enter.
1436
1437 2019-06-10  Tom Tromey  <tromey@adacore.com>
1438
1439         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1440         data.
1441         (elf_new_init): Don't call stabsread_new_init.
1442         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1443         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1444         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1445
1446 2019-06-10  Tom de Vries  <tdevries@suse.de>
1447
1448         PR symtab/16264
1449         PR symtab/24517
1450         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1451
1452 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1453
1454         * source.c (find_and_open_source): Also rewrite relative file
1455         names.
1456
1457 2019-04-26  Amos Bird  <amosbird@gmail.com>
1458
1459         * annotate.c (annotate_thread_exited): Add "thread-exited"
1460         annotation.
1461
1462 2019-06-06  Tom Tromey  <tromey@adacore.com>
1463
1464         * maint.h (class scoped_command_stats): Use
1465         DISABLE_COPY_AND_ASSIGN.
1466         <print_time>: New method.
1467         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1468         print_time.
1469         (scoped_command_stats::print_time): New method.
1470
1471 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1474         instructions of lengths 6 or 8 bytes.
1475
1476 2019-06-04  Pedro Alves  <palves@redhat.com>
1477
1478         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1479
1480         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1481         * breakpoint.c (condition_completer): Likewise.
1482         * cli/cli-dump.c (scan_expression): Likewise.
1483         * common/filestuff.c (mkdir_recursive): Likewise.
1484         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1485         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1486         (gdb_abspath): Likewise.
1487         * compile/compile-cplus-types.c
1488         (compile_cplus_instance::decl_name): Likewise.
1489         * completer.c (complete_explicit_location):
1490         (signal_completer, reg_or_group_completer_1): Likewise.
1491         * cp-support.c (cp_remove_params_if_any): Likewise.
1492         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1493         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1494         * infcmd.c (strip_bg_char): Likewise.
1495         * linespec.c (copy_token_string): Likewise.
1496         * mi/mi-main.c (output_cores): Likewise.
1497         * psymtab.c (psymtab_search_name):
1498         * symfile.c (test_set_ext_lang_command): Likewise.
1499         * target.c (target_fileio_read_stralloc): Likewise.
1500         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1501         * value.c (complete_internalvar): Likewise.
1502
1503 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1504
1505         Add objfile property to gdb.Type.
1506         * NEWS: Mention Python API addition.
1507         * python/py-type.c (typy_get_objfile): New method.
1508
1509 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1510
1511         * NEWS: Mention the new set|show style [title|highlight].
1512         Mention changes to "show style", "help" and "apropos".
1513
1514 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1515
1516         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1517         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1518         instead of print_help_for_command.
1519         (print_doc_of_command): New function.
1520         (help_list): Add 'apropos -v word' suggestion.
1521         (print_help_for_command): Style the command name using title style.
1522         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1523         (_initialize_cli_cmds): Describe -v in apropos_command help.
1524
1525 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1526
1527         * cli/cli-style.h (cli_style_option): Add name in constructor,
1528         add m_name class member, add constructor with intensity,
1529         add name class function.
1530         (cli_style_option::add_setshow_commands): Remove name argument.
1531         (highlight_style, title_style): New styles.
1532         * cli/cli-style.c (do_show): New function that shows a style
1533         characteristic styling the style name with itself.
1534         (set_style_name): New function.
1535         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1536         Update all callers according to the changes in cli/cli-style.h.
1537         * utils.h (fputs_highlighted): New function.
1538         * utils.c (fputs_highlighted): Likewise.
1539
1540 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1541
1542         * NEWS: Mention new pipe command and new convenience variables.
1543
1544 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1545
1546         * cli/cli-cmds.c (pipe_command): New function.
1547         (_initialize_cli_cmds): Call add_com for pipe_command.
1548         Define | as an alias for pipe.
1549         (exit_status_set_internal_vars): New function.
1550         (shell_escape): Call exit_status_set_internal_vars.
1551         cli/cli-decode.c (find_command_name_length): Recognize | as
1552         a single character command.
1553
1554 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1555
1556         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1557         top.c (execute_command_to_ui_file): New function, mostly a copy
1558         of execute_command_to_string.
1559         (execute_command_to_string): Implement by calling
1560         execute_command_to_ui_file.
1561
1562 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1563
1564         * top.h (saved_command_line): Remove declaration.
1565         * top.c (previous_saved_command_line, previous_repeat_arguments):
1566         New variables.
1567         (saved_command_line): Make static, define together with other
1568         'repeat variables'.
1569         (dont_repeat): Clear repeat_arguments.
1570         (repeat_previous, get_saved_command_line, save_command_line):
1571         New functions.
1572         (gdb_init): Initialize saved_command_line
1573         and previous_saved_command_line.
1574         * main.c (captured_main_1): Remove saved_command_line initialization.
1575         * event-top.c (handle_line_of_input): Update to use
1576         the new 'repeat' related functions instead of direct access to
1577         saved_command_line.
1578         * command.h (repeat_previous, get_saved_command_line,
1579         save_command_line): New declarations.
1580         (dont_repeat): Add comment.
1581
1582 2019-05-30  Tom Tromey  <tromey@adacore.com>
1583
1584         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1585         Fix comment.
1586         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1587
1588 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1589
1590         PR cli/24587
1591         * completer.c (complete): Initialize variable word.
1592
1593 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1594
1595         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1596         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1597         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1598         'body' is NULL to the outter 'if', protecting the '!is_define'
1599         situation as well.
1600
1601 2019-05-29  Tom Tromey  <tromey@adacore.com>
1602
1603         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1604         (dwarf_unknown): New function.
1605         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1606         (dwarf_type_encoding_name): Use dwarf_unknown.
1607
1608 2019-05-29  Tom Tromey  <tromey@adacore.com>
1609
1610         PR c++/20020:
1611         * cp-valprint.c (cp_print_value_fields): Call
1612         cp_print_static_field inside "try".
1613
1614 2019-05-29  Tom Tromey  <tromey@adacore.com>
1615
1616         * inflow.c (struct terminal_info): Add default operator=.
1617         * configure: Rebuild.
1618         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1619         -Wdeprecated-copy-dtor, -Wredundant-move.
1620
1621 2019-05-29  Tom Tromey  <tromey@adacore.com>
1622
1623         * NEWS: Add entry.
1624         * infcmd.c (print_return_value_1): Handle finish_print
1625         option.
1626         (show_print_finish): New function.
1627         (_initialize_infcmd): Add "set/show print finish" commands.
1628         * valprint.c (user_print_options): Initialize new member.
1629         * valprint.h (struct value_print_options) <finish_print>: New
1630         member.
1631
1632 2019-05-28  Tom Tromey  <tromey@adacore.com>
1633
1634         * ada-lang.c (ada_remove_Xbn_suffix)
1635         (find_old_style_renaming_symbol)
1636         (parse_old_style_renaming): Remove.
1637         (ada_find_renaming_symbol): Don't call
1638         find_old_style_renaming_symbol.
1639         (ada_is_renaming_symbol): Rename from
1640         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1641         bool.  Now static.
1642         (ada_read_var_value): Update and simplify.
1643         * ada-exp.y (write_var_or_type): Remove old code.
1644
1645 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1646
1647         * event-top.c: Remove include comment.
1648         * inflow.c (class scoped_ignore_sigttou): Move from here...
1649         * inflow.h (class scoped_ignore_sigttou): ...to here.
1650         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1651         * top.c:  Remove include comment.
1652
1653 2019-05-27  Tom Tromey  <tom@tromey.com>
1654
1655         * NEWS: Fix typo.
1656
1657 2019-05-22  Tom Tromey  <tromey@adacore.com>
1658
1659         * target.c (target_follow_exec): Constify parameter.
1660         * target-delegates.c: Rebuild.
1661         * remote.c (remote_target::follow_exec): Constify parameter.
1662         * infrun.c (follow_exec): Constify parameter.
1663         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1664         (target_follow_exec): Likewise.
1665
1666 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1667
1668         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1669         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1670
1671 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1672
1673         * NEWS: Add debugredirect and testsuite sections.
1674
1675 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1676
1677         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1678         target descriptions using exclusively floating point register name
1679         aliases.
1680
1681 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1682
1683         PR gdb/18644:
1684         * f-lang.c (build_fortran_types): Handle the case where
1685         gdbarch_floatformat_for_type returns a nullptr.
1686
1687 2019-05-21  Tom de Vries  <tdevries@suse.de>
1688
1689         PR cli/24587
1690         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1691
1692 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1693
1694         PR gdb/18644:
1695         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1696         16-byte floats.
1697         * i386-tdep.c (i386_floatformat_for_type): Use
1698         floatformats_ia64_quad for the 16-byte floating point component
1699         within a fortran 32-byte complex number.
1700
1701 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1702
1703         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1704         delete default constructor.
1705         (find_partial_die): Update to return const struct.
1706         (partial_die_parent_scope): Move variable declaration into scope
1707         of its use and change its type to auto.
1708         (guess_partial_die_structure_name): Likewise.
1709         (partial_die_info::fixup): Likewise.
1710
1711 2019-05-17  Tom Tromey  <tromey@adacore.com>
1712
1713         * source.c (find_and_open_source): Remove cast.
1714
1715 2019-05-17  Tom Tromey  <tromey@adacore.com>
1716
1717         * annotate.c (annotate_source): Make "filename" const.
1718         * annotate.h (annotate_source): Use const.
1719
1720 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1721
1722         * disasm.c (set_disassembler_options): Send errors to stderr.
1723
1724 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1725
1726         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1727         (cli_interp_base::set_logging): Check debug_redirect.
1728         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1729         * cli/cli-logging.c (debug_redirect): Add static variable.
1730         (pop_output_files): Add default param.
1731         (handle_redirections): Print debug setting.
1732         (show_logging_command): Likewise.
1733         (_initialize_cli_logging): Add debugredirect command.
1734         * interps.c (current_interp_set_logging): Add debug_redirect
1735         parameter.
1736         * interps.h (set_logging): Add debug_redirect parameter.
1737         (current_interp_set_logging): Likewise.
1738         * mi/mi-common.h: Likewise.
1739         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1740
1741 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1742             Tom Tromey  <tromey@adacore.com>
1743
1744         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1745         directly.
1746         * cli/cli-interp.h (make_logging_output): Remove declaration.
1747         * cli/cli-logging.c (make_logging_output): Remove function.
1748         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1749         directly.
1750         * ui-file.c (tee_file::tee_file): Remove bools.
1751         (tee_file::~tee_file): Remove deletes.
1752         * ui-file.h (tee_file): Remove bools.
1753
1754 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1755
1756         * mi/mi-cmds.h (mi_cmd_complete): New function.
1757         * mi/mi-main.c (mi_cmd_complete): Likewise.
1758         * mi/mi-cmds.c: Define new MI command -complete.
1759         * NEWS: Mention new -complete command.
1760
1761 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1762
1763         * completer.h (complete): New function.
1764         * completer.c (complete): Likewise.
1765         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1766         function defined in completer.h.
1767
1768 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1769
1770         * MAINTAINERS (Write After Approval): Add myself.
1771
1772 2019-05-17  Tom de Vries  <tdevries@suse.de>
1773
1774         PR gdb/24094
1775         * dwarf2read.c (struct cu_partial_die_info): New struct.
1776         (find_partial_die): Return cu_partial_die_info.
1777         (partial_die_parent_scope, guess_partial_die_structure_name)
1778         (partial_die_info::fixup): Handle new return type of find_partial_die.
1779
1780 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1781
1782         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1783         "std::string", simplifying the algorithm.
1784
1785 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1786
1787         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1788         (stap_static_probe_ops::get_probes): Likewise.
1789
1790 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1791
1792         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1793         '-')" and "else if".
1794         (stap_parse_single_operand): Join checks for
1795         "gdbarch_stap_parse_special_token_p" and
1796         "gdbarch_stap_parse_special_token" in the same "if" statement.
1797         Invert check when verifying for operation on register
1798         displacement.
1799
1800 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1801
1802         * stap-probe.c (stap_get_opcode): Update comment.
1803         (stap_get_expected_argument_type): Likewise.
1804         (handle_stap_probe): Likewise.
1805
1806 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1807
1808         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1809         return type to 'bool'.  Adjust comment.  Use 'bool' when
1810         appropriate.
1811         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1812         * stap-probe.c (stap_parse_argument_1): Likewise.
1813         (stap_is_operator): Likewise.
1814         (stap_is_generic_prefix): Likewise.
1815         (stap_is_register_prefix): Likewise.
1816         (stap_is_register_indirection_prefix): Likewise.
1817         (stap_is_integer_prefix): Likewise.
1818         (stap_generic_check_suffix): Likewise.
1819         (stap_check_integer_suffix): Likewise.
1820         (stap_check_register_suffix): Likewise.
1821         (stap_check_register_indirection_suffix): Likewise.
1822         (stap_parse_register_operand): Likewise.
1823         (stap_parse_single_operand): Likewise.
1824         (stap_parse_argument_1): Likewise.
1825         (stap_probe::get_argument_count): Likewise.
1826         (stap_is_operator): Likewise.
1827
1828 2019-05-16  Tom Tromey  <tromey@adacore.com>
1829
1830         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1831         keyword to foreach.
1832
1833 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1834
1835         * linux-thread-db.c (try_thread_db_load_1): Change return type
1836         to bool.
1837         (try_thread_db_load): Likewise.
1838         (try_thread_db_load_from_pdir_1): Likewise.
1839         (try_thread_db_load_from_pdir): Likewise.
1840         (try_thread_db_load_from_sdir): Likewise.
1841         (try_thread_db_load_from_dir): Likewise.
1842         (thread_db_load_search): Likewise.
1843         (has_libpthread): Likewise.
1844         (thread_db_load): Likewise.
1845
1846 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1847
1848         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1849         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1850         NULL, and complain/return if that's the case.
1851
1852 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1853
1854         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1855         (advance, posn, abstract_read_memory): New functions.
1856         [struct mem_read_abstraction]: New struct.
1857         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1858
1859 2019-05-14  Tom Tromey  <tromey@adacore.com>
1860
1861         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1862         value is not lval_memory.
1863
1864 2019-05-14  Tom Tromey  <tromey@adacore.com>
1865
1866         * solib.c (info_sharedlibrary_command): Style the file name.
1867
1868 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1869
1870         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1871         (aarch64_vnv_type): Likewise.
1872         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1873         * common/tdesc.c: Likewise.
1874         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1875         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1876         * features/aarch64-fpu.xml: Add ieee half view.
1877         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1878         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1879         * gdbtypes.h (struct builtin_type): Likewise.
1880         (struct objfile_type): Likewise.
1881
1882 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1883
1884         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1885         typo.
1886         * location.h (string_to_event_location): Likewise.
1887
1888 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1889
1890         GDB 8.3 released.
1891
1892 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1893
1894         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1895         New variable declaration.
1896         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1897         New variable.
1898         (print_one_breakpoint): Use ui_out::test_flags and new global
1899         variable to compute use_fixed_output.
1900         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1901         Remove.
1902         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1903         (mi_multi_location_breakpoint_output_fixed): Remove.
1904         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1905         new variable.
1906         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1907         fix_multi_location_breakpoint_output flag if version >= 3.
1908         * ui-out.h (enum ui_out_flag)
1909         <fix_multi_location_breakpoint_output>: New enumerator.
1910
1911 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1912
1913         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1914
1915 2019-05-10  Tom Tromey  <tromey@adacore.com>
1916
1917         * ada-lang.c (catch_ada_completer): New function.
1918         (_initialize_ada_language): Use it.
1919
1920 2019-05-10  Tom Tromey  <tromey@adacore.com>
1921
1922         * thread.c (print_thread_info): Make "requested_threads" const.
1923         * gdbthread.h (print_thread_info): Make "requested_threads"
1924         const.
1925         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1926         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1927
1928 2019-05-08  Tom Tromey  <tom@tromey.com>
1929
1930         * gdbtypes.c (objfile_type_data): Change type.
1931         (objfile_type, _initialize_gdbtypes): Update.
1932
1933 2019-05-08  Tom Tromey  <tom@tromey.com>
1934
1935         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1936         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1937         (_initialize_dwarf2_frame): Update.
1938
1939 2019-05-08  Tom Tromey  <tom@tromey.com>
1940
1941         * objc-lang.c (objc_objfile_data): Change type.
1942         (find_methods): Update.
1943         (_initialize_objc_lang): Remove.
1944
1945 2019-05-08  Tom Tromey  <tom@tromey.com>
1946
1947         * stabsread.c (rs6000_builtin_type_data): Change type.
1948         (rs6000_builtin_type, _initialize_stabsread): Update.
1949
1950 2019-05-08  Tom Tromey  <tom@tromey.com>
1951
1952         * mips-tdep.c (mips_pdr_data): Remove.
1953         (_initialize_mips_tdep): Update.
1954
1955 2019-05-08  Tom Tromey  <tom@tromey.com>
1956
1957         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1958         (hppa_init_objfile_priv_data, read_unwind_info)
1959         (find_unwind_entry, _initialize_hppa_tdep): Update.
1960
1961 2019-05-08  Tom Tromey  <tom@tromey.com>
1962
1963         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1964         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1965         on obstack.
1966         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1967
1968 2019-05-08  Tom Tromey  <tom@tromey.com>
1969
1970         * mdebugread.c (basic_type_data): Change type.
1971         (basic_type, _initialize_mdebugread): Update.
1972
1973 2019-05-08  Tom Tromey  <tom@tromey.com>
1974
1975         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1976
1977 2019-05-08  Tom Tromey  <tom@tromey.com>
1978
1979         * nto-tdep.c (nto_inferior_data_reg): Change type.
1980         (nto_inferior_data): Update.
1981         (nto_inferior_data_cleanup, nto_new_inferior_data)
1982         (_initialize_nto_tdep): Remove.
1983         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1984
1985 2019-05-08  Tom Tromey  <tom@tromey.com>
1986
1987         * ada-lang.c (struct ada_inferior_data): Add initializers.
1988         (ada_inferior_data): Change type.
1989         (ada_inferior_data_cleanup): Remove.
1990         (get_ada_inferior_data, ada_inferior_exit)
1991         (struct ada_pspace_data): Add initializers, destructor.
1992         (ada_pspace_data_handle): Change type.
1993         (get_ada_pspace_data): Update.
1994         (ada_pspace_data_cleanup): Remove.
1995
1996 2019-05-08  Tom Tromey  <tom@tromey.com>
1997
1998         * coffread.c (struct coff_symfile_info): Add initializers.
1999         (coff_objfile_data_key): Move lower.  Change type.
2000         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2001         Update.
2002         (coff_free_info): Remove.
2003
2004 2019-05-08  Tom Tromey  <tom@tromey.com>
2005
2006         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2007         (fbsd_pspace_data_handle): Move lower.  Change type.
2008         (get_fbsd_pspace_data): Update.
2009         (fbsd_pspace_data_cleanup): Remove.
2010         (_initialize_fbsd_tdep): Update.
2011
2012 2019-05-08  Tom Tromey  <tom@tromey.com>
2013
2014         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2015         (get_ada_tasks_pspace_data): Update.
2016         (ada_tasks_pspace_data_cleanup): Remove.
2017         (_initialize_tasks): Update.
2018         (ada_tasks_inferior_data_handle): Change type.
2019         (get_ada_tasks_inferior_data): Update.
2020         (ada_tasks_inferior_data_cleanup): Remove.
2021         (struct ada_tasks_pspace_data): Add initializers.
2022
2023 2019-05-08  Tom Tromey  <tom@tromey.com>
2024
2025         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2026         * symfile-debug.c (debug_sym_get_probes): Change type.
2027         * stap-probe.c (handle_stap_probe):
2028         (stap_static_probe_ops::get_probes): Change type.
2029         * probe.h (class static_probe_ops) <get_probes>: Change type.
2030         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2031         (parse_probes_in_pspace): Update.
2032         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2033         Update.
2034         (any_static_probe_ops::get_probes): Change type.
2035         * elfread.c (elfread_data): New typedef.
2036         (probe_key): Change type.
2037         (elf_get_probes): Likewise.  Update.
2038         (probe_key_free): Remove.
2039         (_initialize_elfread): Update.
2040         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2041         Change type.
2042         (dtrace_process_dof_probe, dtrace_process_dof)
2043         (dtrace_static_probe_ops::get_probe): Change type.
2044
2045 2019-05-08  Tom Tromey  <tom@tromey.com>
2046
2047         * xcoffread.c (struct xcoff_symfile_info): Rename from
2048         coff_symfile_info.  Add initializers.
2049         (xcoff_objfile_data_key): Move lower.  Change type.
2050         (XCOFF_DATA): Rewrite.
2051         (xcoff_free_info): Remove.
2052         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2053         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2054         (xcoff_initial_scan): Update.
2055
2056 2019-05-08  Tom Tromey  <tom@tromey.com>
2057
2058         * solib-svr4.c (struct svr4_info): Add initializers and
2059         destructor.
2060         <probes_table>: Now an htab_up.
2061         (solib_svr4_pspace_data): Change type.
2062         (free_probes_table): Simplify.
2063         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2064         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2065         (probes_table_remove_objfile_probes, register_solib_event_probe)
2066         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2067         (_initialize_svr4_solib): Update.
2068
2069 2019-05-08  Tom Tromey  <tom@tromey.com>
2070
2071         * remote.c (remote_pspace_data): Change type.
2072         (remote_pspace_data_cleanup): Remove.
2073         (get_remote_exec_file, set_pspace_remote_exec_file)
2074         (_initialize_remote): Update.
2075
2076 2019-05-08  Tom Tromey  <tom@tromey.com>
2077
2078         * breakpoint.c (breakpoint_objfile_key): Change type.
2079         (get_breakpoint_objfile_data): Update.
2080         (free_breakpoint_objfile_data): Remove.
2081         (_initialize_breakpoint): Update.
2082
2083 2019-05-08  Tom Tromey  <tom@tromey.com>
2084
2085         * linux-tdep.c (struct linux_info): Add initializers.
2086         (linux_inferior_data): Move.  Change type.
2087         (invalidate_linux_cache_inf): Update.
2088         (linux_inferior_data_cleanup): Remove.
2089         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2090
2091 2019-05-08  Tom Tromey  <tom@tromey.com>
2092
2093         * auxv.c (auxv_inferior_data): Move.  Change type.
2094         (auxv_inferior_data_cleanup): Remove.
2095         (invalidate_auxv_cache_inf): Rewrite.
2096         (get_auxv_inferior_data, _initialize_auxv): Update.
2097
2098 2019-05-08  Tom Tromey  <tom@tromey.com>
2099
2100         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2101         (symfile_debug_objfile_data_key): Change type.
2102         (symfile_debug_installed, debug_qf_has_symbols)
2103         (debug_qf_find_last_source_symtab)
2104         (debug_qf_forget_cached_source_info)
2105         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2106         (debug_qf_print_stats, debug_qf_dump)
2107         (debug_qf_expand_symtabs_for_function)
2108         (debug_qf_expand_all_symtabs)
2109         (debug_qf_expand_symtabs_with_fullname)
2110         (debug_qf_map_matching_symbols)
2111         (debug_qf_expand_symtabs_matching)
2112         (debug_qf_find_pc_sect_compunit_symtab)
2113         (debug_qf_map_symbol_filenames)
2114         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2115         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2116         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2117         (debug_sym_read_linetable, debug_sym_relocate): Update.
2118         (symfile_debug_free_objfile): Remove.
2119         (install_symfile_debug_logging, _initialize_symfile_debug):
2120         Update.
2121
2122 2019-05-08  Tom Tromey  <tom@tromey.com>
2123
2124         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2125         allocate_on_obstack.
2126         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2127         (get_dwarf2_per_objfile): Update.
2128         (set_dwarf2_per_objfile): Remove.
2129         (dwarf2_has_info, dwarf2_get_section_info): Update.
2130         (dwarf2_free_objfile): Remove.
2131         (_initialize_dwarf2_read): Update.
2132
2133 2019-05-08  Tom Tromey  <tom@tromey.com>
2134
2135         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2136         initializers.
2137         <unsupported_script_warning_printed,
2138         script_not_found_warning_printed>: Now bool.
2139         (auto_load_pspace_data): Change type.
2140         (~auto_load_pspace_info): Rename from
2141         auto_load_pspace_data_cleanup.
2142         (get_auto_load_pspace_data, init_loaded_scripts_info)
2143         (clear_section_scripts, maybe_print_unsupported_script_warning)
2144         (maybe_print_script_not_found_warning, _initialize_auto_load):
2145         Update.
2146
2147 2019-05-08  Tom Tromey  <tom@tromey.com>
2148
2149         * objfiles.c (objfile_pspace_info): Add destructor and
2150         initializers.
2151         (objfiles_pspace_data): Change type.
2152         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2153         (get_objfile_pspace_data): Update.
2154         (objfiles_bfd_data): Change type.
2155         (get_objfile_bfd_data): Update.
2156         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2157
2158 2019-05-08  Tom Tromey  <tom@tromey.com>
2159
2160         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2161         Change type.
2162         (get_catch_syscall_inferior_data): Update.
2163         (catch_syscall_inferior_data_cleanup): Remove.
2164         (_initialize_break_catch_syscall): Update.
2165
2166 2019-05-08  Tom Tromey  <tom@tromey.com>
2167
2168         * inflow.c (struct terminal_info): Add destructor and
2169         initializers.
2170         (inflow_inferior_data): Change type.
2171         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2172         (get_inflow_inferior_data, inflow_inferior_exit)
2173         (swap_terminal_info, _initialize_inflow): Update.
2174
2175 2019-05-08  Tom Tromey  <tom@tromey.com>
2176
2177         * target-dcache.c (target_dcache_cleanup): Remove.
2178         (target_dcache_aspace_key): Change type.
2179         (target_dcache_init_p, target_dcache_invalidate)
2180         (target_dcache_get, target_dcache_get_or_init)
2181         (_initialize_target_dcache): Update.
2182         * dcache.h (struct dcache_deleter): New.
2183
2184 2019-05-08  Tom Tromey  <tom@tromey.com>
2185
2186         * symtab.c (struct symbol_cache): Add destructor and
2187         initializers.
2188         (symbol_cache_key): Move.  Change type.
2189         (make_symbol_cache, free_symbol_cache): Remove.
2190         (get_symbol_cache): Update.
2191         (symbol_cache_cleanup): Remove.
2192         (ALL_PSPACES, symbol_cache_flush)
2193         (maintenance_print_symbol_cache)
2194         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2195         Update.
2196
2197 2019-05-08  Tom Tromey  <tom@tromey.com>
2198
2199         * symtab.c (struct main_info): Add destructor and initializers.
2200         (main_progspace_key): Move.  Change type.
2201         (get_main_info): Update.
2202         (main_info_cleanup): Remove.
2203         (_initialize_symtab): Update.
2204
2205 2019-05-08  Tom Tromey  <tom@tromey.com>
2206
2207         * registry.h (DECLARE_REGISTRY): Define the _key class.
2208
2209 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * NEWS: Merge two 'New commands' sections.
2212
2213 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2214
2215         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2216         parameter and use Ada language definition instead.
2217         (ada_val_print_ptr): Remove unused language parameter.
2218         (ada_val_print_num): Remove language parameter and use Ada language
2219         definition instead.
2220         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2221         parameter.
2222         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2223         parameter and use Ada language definition instead.
2224         (ada_val_print_1): Update all ada_val_print_xxx calls.
2225         Remove language parameter.
2226         (ada_val_print): Update ada_val_print_1 call.
2227
2228 2019-05-08  Tom Tromey  <tromey@adacore.com>
2229
2230         * remote.c (remote_hw_watchpoint_limit)
2231         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2232         Now static.
2233
2234 2019-05-08  Tom Tromey  <tromey@adacore.com>
2235
2236         * maint.c (_initialize_maint_cmds): Move initialization code to
2237         remote.c.
2238         (watchdog, show_watchdog): Move to remote.c.
2239         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2240         "watchdog" static.
2241         (_initialize_remote): Move initialization code from maint.c.
2242         * defs.h (watchdog): Don't declare.
2243
2244 2019-05-08  Tom Tromey  <tromey@adacore.com>
2245
2246         * tui/tui-interp.c: Include main.h.
2247         * interps.c: Include main.h.
2248         * main.h (interpreter_p): Declare.
2249         * defs.h (interpreter_p): Don't declare.
2250
2251 2019-05-08  Tom Tromey  <tromey@adacore.com>
2252
2253         * dwarf2loc.c: Include dwarf2read.h.
2254         * defs.h (read_unsigned_leb128): Don't declare.
2255         * dwarf2read.h (read_unsigned_leb128): Declare.
2256
2257 2019-05-08  Tom Tromey  <tromey@adacore.com>
2258
2259         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2260         method.
2261
2262 2019-05-08  Tom Tromey  <tromey@adacore.com>
2263
2264         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2265         when no wrap column is set.
2266
2267 2019-05-08  Tom Tromey  <tromey@adacore.com>
2268
2269         * c-lang.c (c_get_string): Handle non-C-style arrays.
2270
2271 2019-05-08  Tom Tromey  <tromey@adacore.com>
2272
2273         * typeprint.c (print_offset_data::update): Print the bit offset,
2274         not the number of bits remaining.
2275
2276 2019-05-08  Tom Tromey  <tromey@adacore.com>
2277
2278         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2279         padding at end of comment.
2280
2281 2019-05-08  Tom Tromey  <tromey@adacore.com>
2282
2283         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2284         Compare main types.
2285
2286 2019-05-06  Tom Tromey  <tom@tromey.com>
2287
2288         * common/scoped_mmap.c: Include common-defs.h.
2289         * common/scoped_mmap.h: Don't include config.h.
2290
2291 2019-05-04  Tom Tromey  <tom@tromey.com>
2292
2293         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2294         (struct aarch64_call_info): Add initializers.
2295         <si>: Now a std::vector.
2296         (pass_on_stack, aarch64_push_dummy_call): Update.
2297
2298 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2299             Tom Tromey  <tom@tromey.com>
2300
2301         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2302         (ppc_threads): Now a std::vector.  Now static.
2303         (hwdebug_find_thread_points_by_tid)
2304         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2305         Update.
2306
2307 2019-05-04  Tom Tromey  <tom@tromey.com>
2308
2309         * arc-tdep.c (arc_tdesc_init): Return bool.
2310
2311 2019-05-04  Tom Tromey  <tom@tromey.com>
2312
2313         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2314         Use gdb_assert_not_reached.
2315
2316 2019-05-04  Tom Tromey  <tom@tromey.com>
2317
2318         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2319         "false".
2320
2321 2019-05-04  Tom Tromey  <tom@tromey.com>
2322
2323         * arc-tdep.c (arc_tdesc_init): Use bool.
2324
2325 2019-05-04  Tom Tromey  <tom@tromey.com>
2326
2327         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2328
2329 2019-05-04  Tom Tromey  <tom@tromey.com>
2330
2331         * cli/cli-cmds.c (valid_command_p): Return bool.
2332
2333 2019-05-04  Tom Tromey  <tom@tromey.com>
2334
2335         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2336         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2337
2338 2019-05-04  Raul Tambre  <raul@tambre.ee>
2339
2340         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2341         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2342         operator for comparison.
2343
2344 2019-05-04  Tom Tromey  <tom@tromey.com>
2345
2346         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2347         (lookup_partial_symbol, print_partial_symbols)
2348         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2349         (psymbol_compare): Update.
2350         (add_psymbol_to_bcache): Clear the entire psymbol.
2351         (maintenance_check_psymtabs): Update.
2352         * psympriv.h (struct partial_symbol): Don't derive from
2353         general_symbol_info.
2354         <obj_section, unrelocated_address, address,
2355         set_unrelocated_address>: Update.
2356         <ginfo>: New member.
2357         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2358         (debug_names::write_psymbols): Update.
2359
2360 2019-05-04  Tom de Vries  <tdevries@suse.de>
2361
2362         * contrib/cc-with-tweaks.sh: Support -n arg.
2363
2364 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2365
2366         * corelow.c (core_target::detach): Ensure frame cache and
2367         register caches are cleared.
2368         inferior.c (exit_inferior_1): Likewise.
2369
2370 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2371             Tom Tromey  <tom@tromey.com>
2372
2373         * dictionary.c (collate_pending_symbols_by_language): Remove
2374         "struct" from foreach.
2375         * symtab.c (lookup_global_symbol_from_objfile)
2376         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2377         foreach.
2378         * ser-tcp.c (net_open): Remove "struct" from foreach.
2379         * objfiles.c (objfile_relocate, objfile_rebase)
2380         (objfile_has_symbols): Remove "struct" from foreach.
2381         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2382         from foreach.
2383         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2384         foreach.
2385         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2386         "struct" from foreach.
2387         * ada-lang.c (create_excep_cond_exprs)
2388         (ada_exception_catchpoint_cond_string): Remove "struct" from
2389         foreach.
2390
2391 2019-05-03  Tom Tromey  <tromey@adacore.com>
2392
2393         * ada-exp.y (convert_char_literal): Check suffix of each
2394         enumerator.
2395
2396 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2397
2398         PR ada/21406:
2399         * ada-exp.y (yywrap): Don't define.
2400         * ada-lex.l (%option): Add noyywrap
2401         (yywrap): Remove.
2402
2403 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2404
2405         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2406         _WIN32_WINNT to the XP level, unless already defined to a higher
2407         level.
2408
2409         * unittests/parse-connection-spec-selftests.c:
2410         * ser-tcp.c:
2411         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2412         override.
2413
2414         * symfile.c (find_separate_debug_file): Remove colon from the
2415         drive spec of DOS/Windows file names of the target, so that the
2416         file name produced from DEBUGDIR and the target's directory will
2417         be valid on DOS/Windows systems.
2418
2419 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2420
2421         * rust-lang.c (val_print_struct): Handle printing structures
2422         containing strings.
2423
2424 2019-05-02  Tom Tromey  <tromey@adacore.com>
2425
2426         * valarith.c (_initialize_valarith): Remove.
2427
2428 2019-05-01  Tom Tromey  <tromey@adacore.com>
2429
2430         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2431         bitfields.
2432
2433 2019-05-01  Tom Tromey  <tromey@adacore.com>
2434
2435         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2436         for big-endian copies.
2437
2438 2019-04-30  Ali Tamur  <tamur@google.com>
2439         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2440         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2441         (read_3_bytes): New function.
2442
2443 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2444
2445         * windows-nat.c (main_thread_id): Delete.
2446         (handle_output_debug_string): Replace main_thread_id by
2447         current_event.dwThreadId.
2448         (fake_create_process): Likewise.
2449         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2450         Do not set main_thread_id.
2451         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2452         current_event.dwThreadId.
2453         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2454
2455 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2456
2457         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2458         Use current_event.dwThreadId instead of main_thread_id.
2459
2460 2019-04-30  Tom Tromey  <tromey@adacore.com>
2461
2462         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2463         (create_excep_cond_exprs): Iterate over program spaces.
2464         (ada_exception_catchpoint_cond_string): Examine all minimal
2465         symbols for exception types.
2466
2467 2019-04-30  Tom Tromey  <tromey@adacore.com>
2468
2469         PR c++/24470:
2470         * dwarf2read.c (process_structure_scope): Handle case where type
2471         has template parameters but no symbol was created.
2472
2473 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2474             Chris January  <chris.january@arm.com>
2475
2476         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2477         qualifier.
2478         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2479
2480 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2481
2482         * f-typeprint.c (f_print_type): Update rules for printing
2483         whitespace.
2484         (f_type_print_varspec_suffix): Likewise.
2485
2486 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2487             Chris January  <chris.january@arm.com>
2488
2489         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2490         function arguments.
2491
2492 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * f-lang.c (build_fortran_types): Change name of void type to
2495         lower case.
2496         * f-typeprint.c (f_type_print_base): Print the name of the void
2497         type, rather than a fixed string.
2498         * f-valprint.c (f_decorations): Use lower case void string.
2499
2500 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2501             Chris January  <chris.january@arm.com>
2502
2503         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2504         types for Fortran.
2505
2506 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2507             Chris January  <chris.january@arm.com>
2508             David Lecomber  <david.lecomber@arm.com>
2509
2510         * f-exp.y (BINOP_INTRINSIC): New token.
2511         (exp): New parser rule handling BINOP_INTRINSIC.
2512         (f77_keywords): Add new builtin procedures.
2513         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2514         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2515         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2516         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2517         (print_unop_subexp_f): New function.
2518         (print_binop_subexp_f): New function.
2519         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2520         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2521         (dump_subexp_body_f): Likewise.
2522         (operator_check_f): Likewise.
2523         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2524         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2525
2526 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2529         UNOP_KIND.
2530         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2531         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2532         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2533         (operator_length_f): New fuction.
2534         (print_subexp_f): New function.
2535         (op_name_f): New function.
2536         (dump_subexp_body_f): New function.
2537         (operator_check_f): New function.
2538         (exp_descriptor_f): Replace standard expression handling functions
2539         with new functions.
2540         * gdb/fortran-operator.def: New file.
2541         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2542         * gdb/std-operator.def: Remove UNOP_KIND.
2543
2544 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2545
2546         * std-operator.def: Remove unbalanced, stray double quote
2547         character.
2548
2549 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2550             Chris January  <chris.january@arm.com>
2551             Daniel Everett  <daniel.everett@arm.com>
2552             Nick Forrington  <nick.forrington@arm.com>
2553             Richard Bunt  <richard.bunt@arm.com>
2554
2555         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2556         of depth when printing anonymous structs or unions.
2557         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2558         Don't print either the top-level value, or the children if the
2559         max-depth is exceeded.
2560         (ppscm_print_children): When printing the key of a map, allow one
2561         extra level of depth.
2562         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2563         print either the top-level value, or the children if the max-depth
2564         is exceeded.
2565         (print_children): When printing the key of a map, allow one extra
2566         level of depth.
2567         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2568         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2569         (user_print_options): Initialise max_depth field.
2570         (val_print_scalar_or_string_type_p): New function.
2571         (val_print): Check to see if the max depth has been reached.
2572         (val_print_check_max_depth): Define new function.
2573         (show_print_max_depth): New function.
2574         (_initialize_valprint): Add 'print max-depth' option.
2575         * valprint.h (struct value_print_options) <max_depth>: New field.
2576         (val_print_check_max_depth): Declare new function.
2577         * NEWS: Document new feature.
2578
2579 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2580
2581         * ada-lang.c (ada_language_defn): Initialise new field.
2582         * c-lang.c (c_is_string_type_p): New function.
2583         (c_language_defn): Initialise new field.
2584         (cplus_language_defn): Initialise new field.
2585         (asm_language_defn): Initialise new field.
2586         (minimal_language_defn): Initialise new field.
2587         * c-lang.h (c_is_string_type_p): Declare new function.
2588         * d-lang.c (d_language_defn): Initialise new field.
2589         * f-lang.c (f_is_string_type_p): New function.
2590         (f_language_defn): Initialise new field.
2591         * go-lang.c (go_is_string_type_p): New function.
2592         (go_language_defn): Initialise new field.
2593         * language.c (default_is_string_type_p): New function.
2594         (unknown_language_defn): Initialise new field.
2595         (auto_language_defn): Initialise new field.
2596         * language.h (struct language_defn) <la_is_string_type_p>: New
2597         member variable.
2598         (default_is_string_type_p): Declare new function.
2599         * m2-lang.c (m2_language_defn): Initialise new field.
2600         * objc-lang.c (objc_language_defn): Initialise new field.
2601         * opencl-lang.c (opencl_language_defn): Initialise new field.
2602         * p-lang.c (pascal_is_string_type_p): New function.
2603         (pascal_language_defn): Initialise new field.
2604         * rust-lang.c (rust_is_string_type_p): New function.
2605         (rust_language_defn): Initialise new field.
2606
2607 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2608
2609         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2610         New field.
2611         * ada-lang.c (ada_language_defn): Initialise new field.
2612         * c-lang.c (c_language_defn): Likewise.
2613         (cplus_language_defn): Likewise.
2614         (asm_language_defn): Likewise.
2615         (minimal_language_defn): Likewise.
2616         * d-lang.c (d_language_defn): Likewise.
2617         * f-lang.c (f_language_defn): Likewise.
2618         * go-lang.c (go_language_defn): Likewise.
2619         * language.c (unknown_language_defn): Likewise.
2620         (auto_language_defn): Likewise.
2621         * m2-lang.c (m2_language_defn): Likewise.
2622         * objc-lang.c (objc_language_defn): Likewise.
2623         * opencl-lang.c (opencl_language_defn): Likewise.
2624         * p-lang.c (pascal_language_defn): Likewise.
2625         * rust-lang.c (rust_language_defn): Likewise.
2626
2627 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2628
2629         * ada-lang.c (ada_is_character_type): Change return type to bool.
2630         (ada_is_string_type): Likewise.
2631         * ada-lang.h (ada_is_character_type): Update declaration
2632         (ada_is_string_type): Likewise.
2633
2634 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2635
2636         Support style in 'frame|thread apply'
2637
2638         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2639         * record.c (record_start, record_stop): Update callers of
2640         execute_command_to_string with false.
2641         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2642         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2643         methods.
2644         (class string_file): New constructor with term_out parameter.
2645         Override methods term_out and can_emit_style_escape.  New member
2646         term_out.
2647         (class stdio_file): Override can_emit_style_escape.
2648         (class tee_file): Override term_out and can_emit_style_escape.
2649         * utils.h (can_emit_style_escape): Remove.
2650         * utils.c (can_emit_style_escape): Likewise.
2651         Update all callers of can_emit_style_escape (SOMESTREAM) to
2652         SOMESTREAM->can_emit_style_escape.
2653         * source-cache.c (source_cache::get_source_lines): Likewise.
2654         * stack.c (frame_apply_command_count): Call execute_command_to_string
2655         passing the term_out characteristic of the current gdb_stdout.
2656         * thread.c (thr_try_catch_cmd): Likewise.
2657         * top.c (execute_command_to_string): pass term_out parameter
2658         to construct the string_file for the command output.
2659         * ui-file.c (term_cli_styling): New function (most code moved
2660         from utils.c can_emit_style_escape).
2661         (string_file::string_file, string_file::can_emit_style_escape,
2662         stdio_file::can_emit_style_escape, tee_file::term_out,
2663         tee_file::can_emit_style_escape): New functions.
2664
2665 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2666
2667         * NEWS: Mention the new set|show may-call-functions.
2668         * infcall.c (may_call_functions_p): New variable.
2669         (show_may_call_functions_p): New function.
2670         (call_function_by_hand_dummy): Throws an error if not
2671         may-call-functions.
2672         (_initialize_infcall): Call add_setshow_boolean_cmd for
2673         may-call-functions.
2674
2675 2019-04-25  Keith Seitz  <keiths@redhat.com>
2676
2677         PR c++/24367
2678         * cp-support.c (inspect_type): Don't attempt substitutions
2679         of symbol with the same name.
2680
2681 2019-04-25  Tom Tromey  <tromey@adacore.com>
2682
2683         PR gdb/24475:
2684         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2685         static.
2686
2687 2019-04-25  Tom Tromey  <tromey@adacore.com>
2688
2689         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2690         rvalue reference.
2691         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2692         (gdb_xml_parser::parse): Use std::move.
2693         * python/python-internal.h (gdbpy_convert_exception): Take a const
2694         reference.
2695         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2696         std::move.
2697         * python/py-utils.c (gdbpy_convert_exception): Take a const
2698         reference.
2699         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2700         Use std::move.
2701         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2702         Use std::move.
2703         * mi/mi-main.c (mi_print_exception): Take a const reference.
2704         * main.c (handle_command_errors): Take a const reference.
2705         * linespec.c (parse_linespec): Use std::move.
2706         * infcall.c (run_inferior_call): Use std::move.
2707         (call_function_by_hand_dummy): Use std::move.
2708         * exec.c (try_open_exec_file): Use std::move.
2709         * exceptions.h (exception_print, exception_fprintf)
2710         (exception_print_same): Update.
2711         * exceptions.c (print_exception, exception_print)
2712         (exception_fprintf, exception_print_same): Change parameters to
2713         const reference.
2714         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2715         * common/new-op.c: Use std::move.
2716         * common/common-exceptions.h (struct gdb_exception): Add move
2717         constructor.
2718         (struct gdb_exception_error, struct gdb_exception_quit, struct
2719         gdb_quit_bad_alloc): Change constructor to move constructor.
2720         (throw_exception): Change parameter to rvalue reference.
2721         * common/common-exceptions.c (throw_exception): Take rvalue
2722         reference.
2723         * cli/cli-interp.c (safe_execute_command): Use std::move.
2724         * breakpoint.c (insert_bp_location, location_to_sals): Use
2725         std::move.
2726
2727 2019-04-25  Tom Tromey  <tromey@adacore.com>
2728
2729         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2730         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2731         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2732         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2733         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2734         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2735         guile/scm-value.c: Use unpack.
2736         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2737         gdbscm_gdb_exception.
2738         (gdbscm_throw_gdb_exception): Likewise.
2739         (struct gdbscm_gdb_exception): New.
2740         (unpack): New function.
2741         (gdbscm_wrap): Use unpack.
2742
2743 2019-04-25  Tom Tromey  <tromey@adacore.com>
2744
2745         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2746         (gdb_rl_callback_handler): Use std::move.
2747         * common/common-exceptions.h (struct gdb_exception): Add move
2748         assignment operator.
2749         (throw_exception_sjlj): Change "exception" to const reference.
2750         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2751         (throw_exception_sjlj): Change "exception" to const reference.
2752
2753 2019-04-25  Tom Tromey  <tromey@adacore.com>
2754
2755         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2756         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2757         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2758         Update.
2759         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2760         Update.
2761         * mi/mi-interp.c (mi_interp::exec): Update.
2762         * linespec.c (parse_linespec): Update.
2763         * infcall.c (run_inferior_call): Update.
2764         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2765         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2766         (gdbscm_lookup_global_symbol): Update.
2767         * guile/scm-param.c (gdbscm_parameter_value): Update.
2768         * guile/scm-frame.c (gdbscm_frame_read_register)
2769         (gdbscm_frame_read_var): Update.
2770         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2771         * exec.c (try_open_exec_file): Update.
2772         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2773         (gdb_rl_callback_handler): Update.
2774         * common/common-exceptions.h (exception_none): Don't declare.
2775         * common/common-exceptions.c (exception_none): Don't define.
2776         (struct catcher) <exception>: Update.
2777         * cli/cli-interp.c (safe_execute_command): Update.
2778         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2779
2780 2019-04-25  Ali Tamur  <tamur@google.com>
2781
2782         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2783         (read_attribute_value): Likewise.
2784         (dwarf2_read_addr_index): Update comment.
2785         (read_str_index): Add DW_FORM_strx.
2786         (dwarf2_string_attr): Likewise.
2787         (dwarf2_const_value_attr): Likewise.
2788         (dump_die_shallow): Likewise.
2789         (dwarf2_fetch_constant_bytes): Likewise.
2790         (skip_form_bytes): Likewise.
2791         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2792
2793 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2794
2795         PR corefiles/11608
2796         PR corefiles/18187
2797         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2798         OFFSET.  Verify if current mapping contains an ELF header.
2799         (linux_find_memory_regions_full): Adjust call to
2800         dump_mapping_p.
2801
2802 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2803             Kang Li <kanglictf@gmail.com>
2804
2805         PR gdb/21600
2806
2807         * dwarf2-frame.c (read_initial_length): Be consistent about using
2808         unsigned representation of length.
2809         (decode_frame_entry_1): Likewise.  Check for wraparound of
2810         end pointer as well as buffer overflow.
2811
2812 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2813
2814         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2815         "vq".
2816
2817 2019-04-24  Tom Tromey  <tromey@adacore.com>
2818
2819         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2820
2821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2822
2823         * s12z-tdep.c (s12z_unwind_pc): Delete.
2824         (s12z_unwind_sp): Delete.
2825         (s12z_gdbarch_init): Don't register deleted functions with
2826         gdbarch.
2827
2828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         * rl78-tdep.c (rl78_unwind_sp): Delete.
2831         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2832
2833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2834
2835         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2836         (xstormy16_unwind_pc): Delete.
2837         (xstormy16_dummy_id): Delete.
2838         (xstormy16_gdbarch_init): Don't register deleted functions with
2839         gdbarch.
2840
2841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2842
2843         * vax-tdep.c (vax_unwind_pc): Delete.
2844         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2845
2846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2847
2848         * v850-tdep.c (v850_unwind_sp): Delete.
2849         (v850_unwind_pc): Delete.
2850         (v850_dummy_id): Delete.
2851         (v850_gdbarch_init): Don't register deleted functions with
2852         gdbarch.
2853
2854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2855
2856         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2857         (tilegx_unwind_pc): Delete.
2858         (tilegx_unwind_dummy_id): Delete.
2859         (tilegx_gdbarch_init): Don't register deleted functions with
2860         gdbarch.
2861
2862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2863
2864         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2865         (tic6x_dummy_id): Delete.
2866         (tic6x_gdbarch_init): Don't register deleted functions with
2867         gdbarch.
2868
2869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2870
2871         * sparc-tdep.c (sparc_unwind_pc): Delete.
2872         (sparc32_gdbarch_init): Don't register deleted function with
2873         gdbarch.
2874
2875 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2876
2877         * sh-tdep.c (sh_unwind_sp): Delete.
2878         (sh_unwind_pc): Delete.
2879         (sh_dummy_id): Delete.
2880         (sh_gdbarch_init): Don't register deleted functions with
2881         gdbarch.
2882
2883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2884
2885         * score-tdep.c (score_unwind_sp): Delete.
2886         (score_unwind_pc): Delete.
2887         (score_dummy_id): Delete.
2888         (score_gdbarch_init): Don't register deleted functions with
2889         gdbarch.
2890
2891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2892
2893         * rx-tdep.c (rx_unwind_pc): Delete.
2894         (rx_unwind_sp): Delete.
2895         (rx_dummy_id): Delete.
2896         (rx_gdbarch_init): Don't register deleted functions with
2897         gdbarch.  Update comment.
2898
2899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2902         (rs6000_dummy_id): Delete.
2903         (rs6000_gdbarch_init): Don't register deleted functions with
2904         gdbarch.
2905
2906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2907
2908         * or1k-tdep.c (or1k_dummy_id): Delete.
2909         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2910
2911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2912
2913         * nios2-tdep.c (nios2_dummy_id): Delete.
2914         (nios2_unwind_sp): Delete.
2915         (nios2_gdbarch_init): Don't register deleted functions with
2916         gdbarch.
2917
2918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2919
2920         * nds32-tdep.c (nds32_dummy_id): Delete.
2921         (nds32_unwind_pc): Delete.
2922         (nds32_unwind_sp): Delete.
2923         (nds32_gdbarch_init): Don't register deleted functions with
2924         gdbarch.
2925
2926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2927
2928         * msp430-tdep.c (msp430_unwind_pc): Delete.
2929         (msp430_unwind_sp): Delete.
2930         (msp430_dummy_id): Delete.
2931         (msp430_gdbarch_init): Don't register deleted functions with
2932         gdbarch.
2933
2934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2935
2936         * moxie-tdep.c (moxie_unwind_sp): Delete.
2937         (moxie_unwind_pc): Delete.
2938         (moxie_dummy_id): Delete.
2939         (moxie_gdbarch_init): Don't register deleted functions with
2940         gdbarch.
2941
2942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2943
2944         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2945         (mn10300_unwind_pc): Delete.
2946         (mn10300_unwind_sp): Delete.
2947         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2948         mn10300_unwind_sp.
2949         (mn10300_frame_unwind_init): Don't register deleted functions with
2950         gdbarch.
2951
2952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2953
2954         * mep-tdep.c (mep_unwind_pc): Delete.
2955         (mep_unwind_sp): Delete.
2956         (mep_dummy_id): Delete.
2957         (mep_gdbarch_init): Don't register deleted functions with
2958         gdbarch.
2959
2960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2961
2962         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2963         (m68hc11_unwind_sp): Delete.
2964         (m68hc11_gdbarch_init): Don't register deleted functions with
2965         gdbarch.
2966
2967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         * m32r-tdep.c (m32r_unwind_sp): Delete.
2970         (m32r_unwind_pc): Delete.
2971         (m32r_dummy_id): Delete.
2972         (m32r_gdbarch_init): Don't register deleted functions with
2973         gdbarch.
2974
2975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2976
2977         * m32c-tdep.c (m32c_unwind_pc): Delete.
2978         (m32c_unwind_sp): Delete.
2979         (m32c_dummy_id): Delete.
2980         (m32c_gdbarch_init): Don't register deleted functions with
2981         gdbarch.
2982
2983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2984
2985         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2986         (lm32_unwind_pc): Delete.
2987         (lm32_dummy_id): Delete.
2988         (lm32_gdbarch_init): Don't register deleted functions with
2989         gdbarch.
2990
2991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2992
2993         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2994         (iq2000_unwind_pc): Delete.
2995         (iq2000_dummy_id): Delete.
2996         (iq2000_gdbarch_init): Don't register deleted functions with
2997         gdbarch.
2998
2999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3000
3001         * nds32-tdep.c (nds32_type_align): Delete.
3002         (nds32_push_dummy_call): Use type_align instead.
3003
3004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3005
3006         * arm-tdep.c (arm_type_align): Only handle vector override case.
3007         (arm_push_dummy_call): Use type_align.
3008         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3009
3010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3011
3012         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3013         case.
3014         (pass_on_stack): Use type_align.
3015         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3016         function.
3017
3018 2019-04-23  Tom Tromey  <tromey@adacore.com>
3019
3020         * dwarf2read.c (line_header::file_name_at): Remove unused
3021         overload.
3022
3023 2019-04-23  Tom de Vries  <tdevries@suse.de>
3024
3025         PR gdb/24438
3026         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3027         invocation.
3028
3029
3030 2019-03-27  Ali Tamur  <tamur@google.com>
3031
3032         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3033         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3034         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3035         (dwarf_expr_context::get_addr_index): Likewise
3036         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3037         (symbol_needs_eval_context::get_addr_index): Likewise
3038         (disassemble_dwarf_expression): Add DW_OP_addrx
3039         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3040         (read_cutu_die_from_dwo): Update comment
3041         (skip_one_die): Add DW_FORM_addrx
3042         (read_attribute_value): Likewise
3043         (var_decode_location): Add DW_OP_addrx
3044         (dwarf2_const_value_attr): Add DW_FORM_addrx
3045         (dump_die_shallow): Likewise
3046         (dwarf2_fetch_constant_bytes): Likewise
3047         (decode_locdesc): Add DW_OP_addrx
3048         (skip_form_bytes): Add DW_FORM_addrx
3049
3050 2019-04-22  Ali Tamur  <tamur@google.com>
3051
3052         * MAINTAINERS (Write After Approval): Add self.
3053
3054 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3055
3056         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3057         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3058         (open_symbol_file_object): Likewise.
3059         (svr4_default_sos): Add info parameter.
3060         (svr4_read_so_list): Likewise.
3061         (svr4_current_sos_direct): Adjust functions calls to pass down
3062         info.
3063         (svr4_current_sos_1): Add info parameter.
3064         (svr4_current_sos): Call get_svr4_info, pass info down to
3065         svr4_current_sos_1.
3066         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3067         get_svr4_info.
3068         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3069         get_svr4_info.
3070         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3071         to get_svr4_info.
3072         (probes_table_remove_objfile_probes): Likewise.
3073         (register_solib_event_probe): Add info parameter.
3074         (solist_update_incremental): Pass info parameter down to
3075         svr4_read_so_list.
3076         (disable_probes_interface): Add info parameter.
3077         (svr4_handle_solib_event): Pass current_program_space to
3078         get_svr4_info.  Adjust disable_probes_interface cleanup.
3079         (svr4_create_probe_breakpoints): Add info parameter, pass it
3080         down to register_solib_event_probe.
3081         (svr4_create_solib_event_breakpoints): Add info parameter,
3082         pass it down to svr4_create_probe_breakpoints.
3083         (enable_break): Pass info down to
3084         svr4_create_solib_event_breakpoints.
3085         (svr4_solib_create_inferior_hook): Pass current_program_space to
3086         get_svr4_info.
3087         (svr4_clear_solib): Likewise.
3088
3089 2019-04-22  Pedro Alves  <palves@redhat.com>
3090
3091         * solib-svr4.c (svr4_free_objfile_observer): New.
3092         (probe_and_action::objfile): New field.
3093         (probes_table_htab_remove_objfile_probes)
3094         (probes_table_remove_objfile_probes): New functions.
3095         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3096         in the new probe_and_action.  Don't store the probe in 'lookup'.
3097         (svr4_create_probe_breakpoints): Pass objfile to
3098         register_solib_event_probe.
3099         (_initialize_svr4_solib): Register a free_objfile observer.
3100
3101 2019-04-19  Tom Tromey  <tom@tromey.com>
3102
3103         * common/queue.h: Remove.
3104
3105 2019-04-19  Tom Tromey  <tom@tromey.com>
3106
3107         * event-loop.c: Don't include "common/queue.h".
3108
3109 2019-04-19  Tom Tromey  <tom@tromey.com>
3110
3111         * remote.c (remote_target): Use delete.
3112         * remote-notif.h: Include <list>, not "common/queue.h".
3113         (notif_client_p): Remove typedef.
3114         (remote_notif_state): Add constructor, destructor, initializer.
3115         <notif_queue>: Now a std::list.
3116         (remote_notif_state_xfree): Don't declare.
3117         * remote-notif.c (remote_notif_process, handle_notification)
3118         (remote_notif_state_allocate): Update.
3119         (~remote_notif_state): Rename from remote_notif_state_xfree.
3120
3121 2019-04-19  Tom Tromey  <tom@tromey.com>
3122
3123         * symfile.c (reread_symbols): Update.
3124         * objfiles.c (objfile_register_static_link)
3125         (objfile_lookup_static_link): Update
3126         (~objfile) Don't delete static_links.
3127         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3128
3129 2019-04-19  Tom Tromey  <tom@tromey.com>
3130
3131         * type-stack.h (struct type_stack) <insert>: Constify string.
3132         * type-stack.c (type_stack::insert): Constify string.
3133         * gdbtypes.h (lookup_template_type): Update.
3134         (address_space_name_to_int): Update.
3135         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3136         const.
3137         (lookup_template_type): Make name const.
3138         * c-exp.y: Update rules.
3139         (lex_one_token, classify_name, classify_inner_name)
3140         (c_print_token): Update.
3141         * p-exp.y: Update rules.
3142         (yylex): Update.
3143         * f-exp.y: Update rules.
3144         (yylex): Update.
3145         * d-exp.y: Update rules.
3146         (lex_one_token, classify_name, classify_inner_name): Update.
3147         * parse.c (write_dollar_variable, copy_name): Return std::string.
3148         * parser-defs.h (copy_name): Change return type.
3149         * m2-exp.y: Update rules.
3150         (yylex): Update.
3151         * go-exp.y (lex_one_token): Update.
3152         Update rules.
3153         (classify_unsafe_function, classify_packaged_name)
3154         (classify_name, yylex): Update.
3155
3156 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3157
3158         * configure.ac: add --enable-source-highlight switch.
3159         * configure: Regenerate.
3160         * top.c (print_gdb_version): plumb --enable-source-highlight
3161         status to "show configuration".
3162
3163 2019-04-19  Tom Tromey  <tromey@adacore.com>
3164
3165         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3166         Check ADA_TYPE_P.
3167         (empty_record, ada_template_to_fixed_record_type_1)
3168         (template_to_static_fixed_type)
3169         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3170         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3171         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3172         macros.
3173
3174 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3175
3176         PR symtab/24423:
3177         * source.c (print_source_lines_base): Advance "iter" when a
3178         control character is seen.
3179
3180 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3181
3182         * inferior.h (struct infcall_suspend_state_deleter):
3183         Catch exception in destructor to avoid crash.
3184
3185 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3186
3187         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3188         close to the add_com "shell".
3189
3190 2019-04-18  Tom Tromey  <tromey@adacore.com>
3191
3192         * process-stratum-target.h (class process_stratum_target)
3193         <stratum>: Add "final".
3194
3195 2019-04-17  Tom Tromey  <tromey@adacore.com>
3196
3197         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3198         against nullptr before use.
3199
3200 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3201
3202         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3203
3204 2019-04-17  Jim Wilson  <jimw@sifive.com>
3205             Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3208         code read might fail, assume 4-byte breakpoint in that case.
3209
3210 2019-04-15  Leszek Swirski  <leszeks@google.com>
3211
3212         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3213         rather than a hand-rolled POD check when checking for forced MEMORY
3214         classification.
3215
3216 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3217
3218         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3219         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3220         function.
3221         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3222         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3223         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3224         declaration.
3225
3226 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3227
3228         * aarch64-linux-nat.c
3229         (aarch64_linux_nat_target::thread_architecture): Add override.
3230         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3231         each VQ.
3232
3233 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3234
3235         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3236
3237 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3238
3239         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3240         target types of size 96-bits, add some additional comments, and
3241         check that the builtin type we found was the correct size.
3242
3243 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3244
3245         * utils.c (prompt_for_continue): Don't restore the styling at the
3246         end, as applied_style has the wrong value.  This fixes styling in
3247         long lists of file names that are interrupted by the "Continue?"
3248         prompt.
3249
3250 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3251
3252         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3253         * c-lang.c (c_language_defn): Likewise.
3254         (cplus_language_defn): Likewise.
3255         (asm_language_defn): Likewise.
3256         (minimal_language_defn): Likewise.
3257         * d-lang.c (d_language_defn): Likewise.
3258         * f-lang.c (f_language_defn): Likewise.
3259         * go-lang.c (go_language_defn): Likewise.
3260         * language.c (unknown_language_defn): Likewise.
3261         (auto_language_defn): Likewise.
3262         * language.h (struct language_defn): Remove la_magic field.
3263         (LANG_MAGIC): Delete.
3264         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3265         * objc-lang.c (objc_language_defn): Likewise.
3266         * opencl-lang.c (opencl_language_defn): Likewise.
3267         * p-lang.c (pascal_language_defn): Likewise.
3268         * rust-lang.c (rust_language_defn): Likewise.
3269
3270 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3271
3272         * riscv-tdep.c (riscv_type_align): New function.
3273         (riscv_type_alignment): Delete.
3274         (riscv_arg_location): Use 'type_align'.
3275         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3276
3277 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3278
3279         * gdbtypes.c (type_align): A struct with no non-static fields also
3280         has alignment of 1.
3281
3282 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3283
3284         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3285         component to 0.
3286         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3287         member.
3288         (riscv_struct_info::analyse): New implementation using new
3289         analyse_inner member function.
3290         (riscv_struct_info::field_offset): New member function.
3291         (riscv_struct_info::m_offsets): New member variable.
3292         (riscv_struct_info::analyse_inner): New private member function,
3293         takes the old implementation of riscv_struct_info::analyse but
3294         extended to track field offsets.
3295         (riscv_call_arg_struct): Update the struct folding special cases
3296         to handle cases where empty C++ structs, which are non-zero
3297         length, are found.
3298         (riscv_arg_location): Initialise the length of each location, a
3299         non-zero length now indicates the location is in use.
3300         (riscv_push_dummy_call): Allow for the first location having a
3301         non-zero offset when setting up arguments.
3302         (riscv_return_value): Likewise, but for return values.
3303
3304 2019-04-11  Tom Tromey  <tromey@adacore.com>
3305
3306         * utils.c (internal_vproblem): Make "msg" const.
3307
3308 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3309
3310         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3311         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3312         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3313         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3314
3315 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3316
3317         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3318         function.
3319         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3320         of amd64_collect_native_gregset.
3321         (amd64_linux_nat_target::store_registers): Likewise.
3322
3323 2019-04-10  Tom Tromey  <tom@tromey.com>
3324
3325         * symtab.c (lookup_global_symbol_from_objfile)
3326         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3327         * objfiles.h (class separate_debug_iterator): New.
3328         (class separate_debug_range): New.
3329         (struct objfile) <separate_debug_objfiles>: New method.
3330         (objfile_separate_debug_iterate): Don't declare.
3331         * objfiles.c (separate_debug_iterator::operator++): Rename from
3332         objfile_separate_debug_iterate.
3333         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3334         iterator.
3335         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3336         iterator.
3337
3338 2019-04-10  Tom Tromey  <tom@tromey.com>
3339
3340         * symfile.c (reread_symbols): Remove old comment.
3341         * objfiles.c (free_all_objfiles): Fix a typo.
3342
3343 2019-04-10  Tom Tromey  <tom@tromey.com>
3344
3345         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3346         * minsyms.c (lookup_minimal_symbol): Use foreach.
3347         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3348         (lookup_minimal_symbol_solib_trampoline): Likewise.
3349         * symfile.c (reread_symbols): Use foreach.
3350
3351 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3352             Tom Tromey  <tromey@adacore.com>
3353
3354         PR rust/24414:
3355         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3356         (rust_lex_int_test): Change "value" to be LONGEST.
3357         (rust_lex_tests): Add test for long integer literal.
3358
3359 2019-04-09  Tom Tromey  <tromey@adacore.com>
3360
3361         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3362         to bool.
3363         (extended_remote_target::attach): Update.
3364         (remote_target::remote_notice_new_inferior): Update.
3365         (remote_target::add_current_inferior_and_thread): Update.
3366         * inferior.c (exit_inferior_1): Use "false".
3367         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3368
3369 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3370
3371         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3372         the "start" command.
3373
3374 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3375
3376         * python/py-inferior.c (infpy_thread_from_thread_handle):
3377         Adjust comments to reflect renaming of thread_from_thread_handle
3378         to thread_from_handle.  Adjust keywords.  Fix type error message.
3379         (inferior_object_methods): Add thread_from_handle.  Retain
3380         thread_from_thread_handle, but mark it as deprecated.
3381
3382 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3383
3384         * gdbthread.h (find_thread_by_handle): Revise declaration.
3385         * thread.c (find_thread_by_handle): Likewise.  Adjust
3386         implementation too.
3387         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3388         support for buffer objects as handles.
3389
3390 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3391
3392         * python/py-infthread.c (thpy_thread_handle): New function.
3393         (thread_object_methods): Register thpy_thread_handle.
3394
3395 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3396
3397         * gdbthread.h (thread_to_thread_handle): Declare.
3398         * thread.c (gdbtypes.h): Include.
3399         (thread_to_thread_handle): New function.
3400
3401         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3402         (target_thread_info_to_thread_handle): Declare.
3403         * target.c (target_thread_info_to_thread_handle): New function.
3404         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3405         * target-delegates.c: Regenerate.
3406
3407         * linux-thread-db.c (class thread_db_target): Add method
3408         thread_info_to_thread_handle.
3409         (thread_db_target::thread_info_to_thread_handle): Define.
3410         * remote.c (class remote_target): Add new method
3411         thread_info_to_thread_handle.
3412         (remote_target::thread_info_to_thread_handle): Define.
3413
3414 2019-04-08  Pedro Alves  <palves@redhat.com>
3415
3416         * common/common-exceptions.c (throw_exception): Don't create
3417         named object to throw; throw directly.
3418         (throw_it): Likewise.  Don't initialize gdb_exception::message
3419         here, with new; pass FMT and AP to the ctor instead.
3420         * common/common-exceptions.h: Include <string>.
3421         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3422         const char *, va_list)): New ctor.  Use std::make_shared.
3423         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3424         errors)): Delete.
3425         (gdb_exception_error::gdb_exception_error(enum errors, const char
3426         *, va_list)): New.
3427         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3428         Add assertion.
3429         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3430         errors)): Delete.
3431         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3432         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3433         Add assertion.
3434
3435 2019-04-08  Tom Tromey  <tom@tromey.com>
3436
3437         * valops.c (value_rtti_indirect_type): Replace throw_exception
3438         with throw.
3439         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3440         with throw.
3441         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3442         throw.
3443         * target.c (target_translate_tls_address): Replace throw_exception
3444         with throw.
3445         * stack.c (frame_apply_command_count): Replace throw_exception
3446         with throw.
3447         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3448         throw.
3449         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3450         with throw.
3451         * rs6000-tdep.c (rs6000_frame_cache)
3452         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3453         * remote.c: Replace throw_exception with throw.
3454         * record-full.c (record_full_message, record_full_wait_1)
3455         (record_full_restore): Replace throw_exception with throw.
3456         * record-btrace.c:
3457         (get_thread_current_frame_id, record_btrace_start_replaying)
3458         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3459         (cmd_record_btrace_start): Replace throw_exception with throw.
3460         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3461         throw.
3462         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3463         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3464         * linespec.c:
3465         (find_linespec_symbols): Replace throw_exception with throw.
3466         * infrun.c (displaced_step_prepare, resume): Replace
3467         throw_exception with throw.
3468         * infcmd.c (post_create_inferior): Replace throw_exception with
3469         throw.
3470         * inf-loop.c (inferior_event_handler): Replace throw_exception
3471         with throw.
3472         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3473         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3474         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3475         (get_prev_frame_always, get_frame_pc_if_available)
3476         (get_frame_address_in_block_if_available, get_frame_language):
3477         Replace throw_exception with throw.
3478         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3479         throw_exception with throw.
3480         * eval.c (fetch_subexp_value, evaluate_var_value)
3481         (evaluate_funcall, evaluate_subexp_standard): Replace
3482         throw_exception with throw.
3483         * dwarf2loc.c (call_site_find_chain)
3484         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3485         Replace throw_exception with throw.
3486         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3487         with throw.
3488         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3489         throw.
3490         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3491         * completer.c (complete_line_internal): Replace throw_exception
3492         with throw.
3493         * compile/compile-object-run.c (compile_object_run): Replace
3494         throw_exception with throw.
3495         * cli/cli-script.c (process_next_line): Replace throw_exception
3496         with throw.
3497         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3498         (btrace_enable, btrace_maint_update_pt_packets): Replace
3499         throw_exception with throw.
3500         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3501         throw_exception with throw.
3502         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3503         throw_exception with throw.
3504         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3505         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3506         * aarch64-tdep.c (aarch64_make_prologue_cache)
3507         (aarch64_make_stub_cache): Replace throw_exception with throw.
3508
3509 2019-04-08  Tom Tromey  <tom@tromey.com>
3510
3511         * common/common-exceptions.c (throw_exception): Rename from
3512         throw_exception_cxx.  Remove old copy.  Make argument const.
3513         (throw_it): Create and throw exception objects directly.
3514         * common/common-exceptions.h (throw_exception): Make argument
3515         const.
3516         (struct gdb_exception_error): Add constructor.
3517         (struct gdb_exception_quit): Add constructor.
3518
3519 2019-04-08  Tom Tromey  <tom@tromey.com>
3520
3521         * common/common-exceptions.h (exception_rethrow): Don't declare.
3522         (TRY_SJLJ): Update comment.
3523         (TRY, CATCH, END_CATCH): Remove.
3524         * common/common-exceptions.c (exception_rethrow): Remove.
3525
3526 2019-04-08  Tom Tromey  <tom@tromey.com>
3527
3528         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3529         Remove.
3530         (gdb_exception_error): Rename from
3531         gdb_exception_RETURN_MASK_ERROR.
3532         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3533         (gdb_quit_bad_alloc): Update.
3534         * aarch64-tdep.c: Update.
3535         * ada-lang.c: Update.
3536         * ada-typeprint.c: Update.
3537         * ada-valprint.c: Update.
3538         * amd64-tdep.c: Update.
3539         * arch-utils.c: Update.
3540         * break-catch-throw.c: Update.
3541         * breakpoint.c: Update.
3542         * btrace.c: Update.
3543         * c-varobj.c: Update.
3544         * cli/cli-cmds.c: Update.
3545         * cli/cli-interp.c: Update.
3546         * cli/cli-script.c: Update.
3547         * common/common-exceptions.c: Update.
3548         * common/new-op.c: Update.
3549         * common/selftest.c: Update.
3550         * compile/compile-c-symbols.c: Update.
3551         * compile/compile-cplus-symbols.c: Update.
3552         * compile/compile-object-load.c: Update.
3553         * compile/compile-object-run.c: Update.
3554         * completer.c: Update.
3555         * corelow.c: Update.
3556         * cp-abi.c: Update.
3557         * cp-support.c: Update.
3558         * cp-valprint.c: Update.
3559         * darwin-nat.c: Update.
3560         * disasm-selftests.c: Update.
3561         * dtrace-probe.c: Update.
3562         * dwarf-index-cache.c: Update.
3563         * dwarf-index-write.c: Update.
3564         * dwarf2-frame-tailcall.c: Update.
3565         * dwarf2-frame.c: Update.
3566         * dwarf2loc.c: Update.
3567         * dwarf2read.c: Update.
3568         * eval.c: Update.
3569         * event-loop.c: Update.
3570         * event-top.c: Update.
3571         * exec.c: Update.
3572         * f-valprint.c: Update.
3573         * fbsd-tdep.c: Update.
3574         * frame-unwind.c: Update.
3575         * frame.c: Update.
3576         * gdbtypes.c: Update.
3577         * gnu-v3-abi.c: Update.
3578         * guile/guile-internal.h: Update.
3579         * guile/scm-block.c: Update.
3580         * guile/scm-breakpoint.c: Update.
3581         * guile/scm-cmd.c: Update.
3582         * guile/scm-disasm.c: Update.
3583         * guile/scm-frame.c: Update.
3584         * guile/scm-lazy-string.c: Update.
3585         * guile/scm-math.c: Update.
3586         * guile/scm-param.c: Update.
3587         * guile/scm-ports.c: Update.
3588         * guile/scm-pretty-print.c: Update.
3589         * guile/scm-symbol.c: Update.
3590         * guile/scm-symtab.c: Update.
3591         * guile/scm-type.c: Update.
3592         * guile/scm-value.c: Update.
3593         * i386-linux-tdep.c: Update.
3594         * i386-tdep.c: Update.
3595         * inf-loop.c: Update.
3596         * infcall.c: Update.
3597         * infcmd.c: Update.
3598         * infrun.c: Update.
3599         * jit.c: Update.
3600         * language.c: Update.
3601         * linespec.c: Update.
3602         * linux-fork.c: Update.
3603         * linux-nat.c: Update.
3604         * linux-tdep.c: Update.
3605         * linux-thread-db.c: Update.
3606         * main.c: Update.
3607         * mi/mi-cmd-break.c: Update.
3608         * mi/mi-cmd-stack.c: Update.
3609         * mi/mi-interp.c: Update.
3610         * mi/mi-main.c: Update.
3611         * objc-lang.c: Update.
3612         * p-valprint.c: Update.
3613         * parse.c: Update.
3614         * ppc-linux-tdep.c: Update.
3615         * printcmd.c: Update.
3616         * python/py-arch.c: Update.
3617         * python/py-breakpoint.c: Update.
3618         * python/py-cmd.c: Update.
3619         * python/py-finishbreakpoint.c: Update.
3620         * python/py-frame.c: Update.
3621         * python/py-framefilter.c: Update.
3622         * python/py-gdb-readline.c: Update.
3623         * python/py-inferior.c: Update.
3624         * python/py-infthread.c: Update.
3625         * python/py-lazy-string.c: Update.
3626         * python/py-linetable.c: Update.
3627         * python/py-objfile.c: Update.
3628         * python/py-param.c: Update.
3629         * python/py-prettyprint.c: Update.
3630         * python/py-progspace.c: Update.
3631         * python/py-record-btrace.c: Update.
3632         * python/py-record.c: Update.
3633         * python/py-symbol.c: Update.
3634         * python/py-type.c: Update.
3635         * python/py-unwind.c: Update.
3636         * python/py-utils.c: Update.
3637         * python/py-value.c: Update.
3638         * python/python.c: Update.
3639         * record-btrace.c: Update.
3640         * record-full.c: Update.
3641         * remote-fileio.c: Update.
3642         * remote.c: Update.
3643         * riscv-tdep.c: Update.
3644         * rs6000-aix-tdep.c: Update.
3645         * rs6000-tdep.c: Update.
3646         * rust-exp.y: Update.
3647         * rust-lang.c: Update.
3648         * s390-tdep.c: Update.
3649         * selftest-arch.c: Update.
3650         * solib-dsbt.c: Update.
3651         * solib-frv.c: Update.
3652         * solib-spu.c: Update.
3653         * solib-svr4.c: Update.
3654         * solib.c: Update.
3655         * sparc64-linux-tdep.c: Update.
3656         * stack.c: Update.
3657         * symfile-mem.c: Update.
3658         * symmisc.c: Update.
3659         * target.c: Update.
3660         * thread.c: Update.
3661         * top.c: Update.
3662         * tracefile-tfile.c: Update.
3663         * tui/tui.c: Update.
3664         * typeprint.c: Update.
3665         * unittests/cli-utils-selftests.c: Update.
3666         * unittests/parse-connection-spec-selftests.c: Update.
3667         * valops.c: Update.
3668         * valprint.c: Update.
3669         * value.c: Update.
3670         * varobj.c: Update.
3671         * windows-nat.c: Update.
3672         * x86-linux-nat.c: Update.
3673         * xml-support.c: Update.
3674
3675 2019-04-08  Tom Tromey  <tom@tromey.com>
3676
3677         * xml-support.c: Use C++ exception handling.
3678         * x86-linux-nat.c: Use C++ exception handling.
3679         * windows-nat.c: Use C++ exception handling.
3680         * varobj.c: Use C++ exception handling.
3681         * value.c: Use C++ exception handling.
3682         * valprint.c: Use C++ exception handling.
3683         * valops.c: Use C++ exception handling.
3684         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3685         handling.
3686         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3687         * typeprint.c: Use C++ exception handling.
3688         * tui/tui.c: Use C++ exception handling.
3689         * tracefile-tfile.c: Use C++ exception handling.
3690         * top.c: Use C++ exception handling.
3691         * thread.c: Use C++ exception handling.
3692         * target.c: Use C++ exception handling.
3693         * symmisc.c: Use C++ exception handling.
3694         * symfile-mem.c: Use C++ exception handling.
3695         * stack.c: Use C++ exception handling.
3696         * sparc64-linux-tdep.c: Use C++ exception handling.
3697         * solib.c: Use C++ exception handling.
3698         * solib-svr4.c: Use C++ exception handling.
3699         * solib-spu.c: Use C++ exception handling.
3700         * solib-frv.c: Use C++ exception handling.
3701         * solib-dsbt.c: Use C++ exception handling.
3702         * selftest-arch.c: Use C++ exception handling.
3703         * s390-tdep.c: Use C++ exception handling.
3704         * rust-lang.c: Use C++ exception handling.
3705         * rust-exp.y: Use C++ exception handling.
3706         * rs6000-tdep.c: Use C++ exception handling.
3707         * rs6000-aix-tdep.c: Use C++ exception handling.
3708         * riscv-tdep.c: Use C++ exception handling.
3709         * remote.c: Use C++ exception handling.
3710         * remote-fileio.c: Use C++ exception handling.
3711         * record-full.c: Use C++ exception handling.
3712         * record-btrace.c: Use C++ exception handling.
3713         * python/python.c: Use C++ exception handling.
3714         * python/py-value.c: Use C++ exception handling.
3715         * python/py-utils.c: Use C++ exception handling.
3716         * python/py-unwind.c: Use C++ exception handling.
3717         * python/py-type.c: Use C++ exception handling.
3718         * python/py-symbol.c: Use C++ exception handling.
3719         * python/py-record.c: Use C++ exception handling.
3720         * python/py-record-btrace.c: Use C++ exception handling.
3721         * python/py-progspace.c: Use C++ exception handling.
3722         * python/py-prettyprint.c: Use C++ exception handling.
3723         * python/py-param.c: Use C++ exception handling.
3724         * python/py-objfile.c: Use C++ exception handling.
3725         * python/py-linetable.c: Use C++ exception handling.
3726         * python/py-lazy-string.c: Use C++ exception handling.
3727         * python/py-infthread.c: Use C++ exception handling.
3728         * python/py-inferior.c: Use C++ exception handling.
3729         * python/py-gdb-readline.c: Use C++ exception handling.
3730         * python/py-framefilter.c: Use C++ exception handling.
3731         * python/py-frame.c: Use C++ exception handling.
3732         * python/py-finishbreakpoint.c: Use C++ exception handling.
3733         * python/py-cmd.c: Use C++ exception handling.
3734         * python/py-breakpoint.c: Use C++ exception handling.
3735         * python/py-arch.c: Use C++ exception handling.
3736         * printcmd.c: Use C++ exception handling.
3737         * ppc-linux-tdep.c: Use C++ exception handling.
3738         * parse.c: Use C++ exception handling.
3739         * p-valprint.c: Use C++ exception handling.
3740         * objc-lang.c: Use C++ exception handling.
3741         * mi/mi-main.c: Use C++ exception handling.
3742         * mi/mi-interp.c: Use C++ exception handling.
3743         * mi/mi-cmd-stack.c: Use C++ exception handling.
3744         * mi/mi-cmd-break.c: Use C++ exception handling.
3745         * main.c: Use C++ exception handling.
3746         * linux-thread-db.c: Use C++ exception handling.
3747         * linux-tdep.c: Use C++ exception handling.
3748         * linux-nat.c: Use C++ exception handling.
3749         * linux-fork.c: Use C++ exception handling.
3750         * linespec.c: Use C++ exception handling.
3751         * language.c: Use C++ exception handling.
3752         * jit.c: Use C++ exception handling.
3753         * infrun.c: Use C++ exception handling.
3754         * infcmd.c: Use C++ exception handling.
3755         * infcall.c: Use C++ exception handling.
3756         * inf-loop.c: Use C++ exception handling.
3757         * i386-tdep.c: Use C++ exception handling.
3758         * i386-linux-tdep.c: Use C++ exception handling.
3759         * guile/scm-value.c: Use C++ exception handling.
3760         * guile/scm-type.c: Use C++ exception handling.
3761         * guile/scm-symtab.c: Use C++ exception handling.
3762         * guile/scm-symbol.c: Use C++ exception handling.
3763         * guile/scm-pretty-print.c: Use C++ exception handling.
3764         * guile/scm-ports.c: Use C++ exception handling.
3765         * guile/scm-param.c: Use C++ exception handling.
3766         * guile/scm-math.c: Use C++ exception handling.
3767         * guile/scm-lazy-string.c: Use C++ exception handling.
3768         * guile/scm-frame.c: Use C++ exception handling.
3769         * guile/scm-disasm.c: Use C++ exception handling.
3770         * guile/scm-cmd.c: Use C++ exception handling.
3771         * guile/scm-breakpoint.c: Use C++ exception handling.
3772         * guile/scm-block.c: Use C++ exception handling.
3773         * guile/guile-internal.h: Use C++ exception handling.
3774         * gnu-v3-abi.c: Use C++ exception handling.
3775         * gdbtypes.c: Use C++ exception handling.
3776         * frame.c: Use C++ exception handling.
3777         * frame-unwind.c: Use C++ exception handling.
3778         * fbsd-tdep.c: Use C++ exception handling.
3779         * f-valprint.c: Use C++ exception handling.
3780         * exec.c: Use C++ exception handling.
3781         * event-top.c: Use C++ exception handling.
3782         * event-loop.c: Use C++ exception handling.
3783         * eval.c: Use C++ exception handling.
3784         * dwarf2read.c: Use C++ exception handling.
3785         * dwarf2loc.c: Use C++ exception handling.
3786         * dwarf2-frame.c: Use C++ exception handling.
3787         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3788         * dwarf-index-write.c: Use C++ exception handling.
3789         * dwarf-index-cache.c: Use C++ exception handling.
3790         * dtrace-probe.c: Use C++ exception handling.
3791         * disasm-selftests.c: Use C++ exception handling.
3792         * darwin-nat.c: Use C++ exception handling.
3793         * cp-valprint.c: Use C++ exception handling.
3794         * cp-support.c: Use C++ exception handling.
3795         * cp-abi.c: Use C++ exception handling.
3796         * corelow.c: Use C++ exception handling.
3797         * completer.c: Use C++ exception handling.
3798         * compile/compile-object-run.c: Use C++ exception handling.
3799         * compile/compile-object-load.c: Use C++ exception handling.
3800         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3801         * compile/compile-c-symbols.c: Use C++ exception handling.
3802         * common/selftest.c: Use C++ exception handling.
3803         * common/new-op.c: Use C++ exception handling.
3804         * cli/cli-script.c: Use C++ exception handling.
3805         * cli/cli-interp.c: Use C++ exception handling.
3806         * cli/cli-cmds.c: Use C++ exception handling.
3807         * c-varobj.c: Use C++ exception handling.
3808         * btrace.c: Use C++ exception handling.
3809         * breakpoint.c: Use C++ exception handling.
3810         * break-catch-throw.c: Use C++ exception handling.
3811         * arch-utils.c: Use C++ exception handling.
3812         * amd64-tdep.c: Use C++ exception handling.
3813         * ada-valprint.c: Use C++ exception handling.
3814         * ada-typeprint.c: Use C++ exception handling.
3815         * ada-lang.c: Use C++ exception handling.
3816         * aarch64-tdep.c: Use C++ exception handling.
3817
3818 2019-04-08  Tom Tromey  <tom@tromey.com>
3819
3820         * xml-support.c (gdb_xml_parser::parse): Update.
3821         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3822         * value.c (show_convenience): Update.
3823         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3824         (test_parse_flags_qcs): Update.
3825         * thread.c (thr_try_catch_cmd): Update.
3826         * target.c (target_translate_tls_address): Update.
3827         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3828         (info_frame_command_core, frame_apply_command_count): Update.
3829         * rust-exp.y (rust_lex_exception_test): Update.
3830         * riscv-tdep.c (riscv_print_one_register_info): Update.
3831         * remote.c (remote_target::enable_btrace): Update.
3832         * record-btrace.c (record_btrace_enable_warn): Update.
3833         * python/py-utils.c (gdbpy_convert_exception): Update.
3834         * printcmd.c (do_one_display, print_variable_and_value): Update.
3835         * mi/mi-main.c (mi_print_exception): Update.
3836         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3837         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3838         * linux-nat.c (linux_nat_target::attach): Update.
3839         * linux-fork.c (class scoped_switch_fork_info): Update.
3840         * infrun.c (displaced_step_prepare): Update.
3841         * infcall.c (call_function_by_hand_dummy): Update.
3842         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3843         * gnu-v3-abi.c (print_one_vtable): Update.
3844         * frame.c (get_prev_frame_always): Update.
3845         * f-valprint.c (info_common_command_for_block): Update.
3846         * exec.c (try_open_exec_file): Update.
3847         * exceptions.c (print_exception, exception_print)
3848         (exception_fprintf, exception_print_same): Update.
3849         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3850         * dwarf-index-cache.c (index_cache::store)
3851         (index_cache::lookup_gdb_index): Update.
3852         * darwin-nat.c (maybe_cache_shell): Update.
3853         * cp-valprint.c (cp_print_value_fields): Update.
3854         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3855         (gcc_cplus_symbol_address): Update.
3856         * compile/compile-c-symbols.c (gcc_convert_symbol)
3857         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3858         * common/selftest.c: Update.
3859         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3860         a std::string.
3861         (exception_try_scope_entry, exception_try_scope_exit): Don't
3862         declare.
3863         (struct exception_try_scope): Remove.
3864         (TRY): Don't use exception_try_scope.
3865         (struct gdb_exception): Add constructor, operator=.
3866         <what>: New method.
3867         (struct gdb_exception_RETURN_MASK_ALL)
3868         (struct gdb_exception_RETURN_MASK_ERROR)
3869         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3870         (struct gdb_quit_bad_alloc): Update.
3871         * common/common-exceptions.c (exception_none): Change
3872         initializer.
3873         (struct catcher) <state, exception>: Initialize inline.
3874         <prev>: Remove member.
3875         (current_catcher): Remove.
3876         (catchers): New global.
3877         (exceptions_state_mc_init): Simplify.
3878         (catcher_pop): Remove.
3879         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3880         (try_scope_depth, exception_try_scope_entry)
3881         (exception_try_scope_exit): Remove.
3882         (throw_exception_sjlj): Update.
3883         (exception_messages, exception_messages_size): Remove.
3884         (throw_it): Simplify.
3885         (gdb_exception_sliced_copy): Remove.
3886         (throw_exception_cxx): Update.
3887         * cli/cli-script.c (script_from_file): Update.
3888         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3889         Update.
3890         * ada-valprint.c (ada_val_print): Update.
3891         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3892         (create_excep_cond_exprs): Update.
3893
3894 2019-04-08  Tom Tromey  <tom@tromey.com>
3895
3896         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3897         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3898         (TRY, CATCH, END_CATCH): Remove some definitions.
3899         * common/common-exceptions.c: Don't use GDB_XCPT.
3900         (catcher_list_size): Remove.
3901         (throw_exception, throw_it): Simplify.
3902
3903 2019-04-05  Tom Tromey  <tom@tromey.com>
3904
3905         Revert the header-sorting patch.
3906         * ft32-tdep.c: Revert.
3907         * frv-tdep.c: Revert.
3908         * frv-linux-tdep.c: Revert.
3909         * frame.c: Revert.
3910         * frame-unwind.c: Revert.
3911         * frame-base.c: Revert.
3912         * fork-child.c: Revert.
3913         * findvar.c: Revert.
3914         * findcmd.c: Revert.
3915         * filesystem.c: Revert.
3916         * filename-seen-cache.h: Revert.
3917         * filename-seen-cache.c: Revert.
3918         * fbsd-tdep.c: Revert.
3919         * fbsd-nat.h: Revert.
3920         * fbsd-nat.c: Revert.
3921         * f-valprint.c: Revert.
3922         * f-typeprint.c: Revert.
3923         * f-lang.c: Revert.
3924         * extension.h: Revert.
3925         * extension.c: Revert.
3926         * extension-priv.h: Revert.
3927         * expprint.c: Revert.
3928         * exec.h: Revert.
3929         * exec.c: Revert.
3930         * exceptions.c: Revert.
3931         * event-top.c: Revert.
3932         * event-loop.c: Revert.
3933         * eval.c: Revert.
3934         * elfread.c: Revert.
3935         * dwarf2read.h: Revert.
3936         * dwarf2read.c: Revert.
3937         * dwarf2loc.c: Revert.
3938         * dwarf2expr.h: Revert.
3939         * dwarf2expr.c: Revert.
3940         * dwarf2-frame.c: Revert.
3941         * dwarf2-frame-tailcall.c: Revert.
3942         * dwarf-index-write.h: Revert.
3943         * dwarf-index-write.c: Revert.
3944         * dwarf-index-common.c: Revert.
3945         * dwarf-index-cache.h: Revert.
3946         * dwarf-index-cache.c: Revert.
3947         * dummy-frame.c: Revert.
3948         * dtrace-probe.c: Revert.
3949         * disasm.h: Revert.
3950         * disasm.c: Revert.
3951         * disasm-selftests.c: Revert.
3952         * dictionary.c: Revert.
3953         * dicos-tdep.c: Revert.
3954         * demangle.c: Revert.
3955         * dcache.h: Revert.
3956         * dcache.c: Revert.
3957         * darwin-nat.h: Revert.
3958         * darwin-nat.c: Revert.
3959         * darwin-nat-info.c: Revert.
3960         * d-valprint.c: Revert.
3961         * d-namespace.c: Revert.
3962         * d-lang.c: Revert.
3963         * ctf.c: Revert.
3964         * csky-tdep.c: Revert.
3965         * csky-linux-tdep.c: Revert.
3966         * cris-tdep.c: Revert.
3967         * cris-linux-tdep.c: Revert.
3968         * cp-valprint.c: Revert.
3969         * cp-support.c: Revert.
3970         * cp-namespace.c: Revert.
3971         * cp-abi.c: Revert.
3972         * corelow.c: Revert.
3973         * corefile.c: Revert.
3974         * continuations.c: Revert.
3975         * completer.h: Revert.
3976         * completer.c: Revert.
3977         * complaints.c: Revert.
3978         * coffread.c: Revert.
3979         * coff-pe-read.c: Revert.
3980         * cli-out.h: Revert.
3981         * cli-out.c: Revert.
3982         * charset.c: Revert.
3983         * c-varobj.c: Revert.
3984         * c-valprint.c: Revert.
3985         * c-typeprint.c: Revert.
3986         * c-lang.c: Revert.
3987         * buildsym.c: Revert.
3988         * buildsym-legacy.c: Revert.
3989         * build-id.h: Revert.
3990         * build-id.c: Revert.
3991         * btrace.c: Revert.
3992         * bsd-uthread.c: Revert.
3993         * breakpoint.h: Revert.
3994         * breakpoint.c: Revert.
3995         * break-catch-throw.c: Revert.
3996         * break-catch-syscall.c: Revert.
3997         * break-catch-sig.c: Revert.
3998         * blockframe.c: Revert.
3999         * block.c: Revert.
4000         * bfin-tdep.c: Revert.
4001         * bfin-linux-tdep.c: Revert.
4002         * bfd-target.c: Revert.
4003         * bcache.c: Revert.
4004         * ax-general.c: Revert.
4005         * ax-gdb.h: Revert.
4006         * ax-gdb.c: Revert.
4007         * avr-tdep.c: Revert.
4008         * auxv.c: Revert.
4009         * auto-load.c: Revert.
4010         * arm-wince-tdep.c: Revert.
4011         * arm-tdep.c: Revert.
4012         * arm-symbian-tdep.c: Revert.
4013         * arm-pikeos-tdep.c: Revert.
4014         * arm-obsd-tdep.c: Revert.
4015         * arm-nbsd-tdep.c: Revert.
4016         * arm-nbsd-nat.c: Revert.
4017         * arm-linux-tdep.c: Revert.
4018         * arm-linux-nat.c: Revert.
4019         * arm-fbsd-tdep.c: Revert.
4020         * arm-fbsd-nat.c: Revert.
4021         * arm-bsd-tdep.c: Revert.
4022         * arch-utils.c: Revert.
4023         * arc-tdep.c: Revert.
4024         * arc-newlib-tdep.c: Revert.
4025         * annotate.h: Revert.
4026         * annotate.c: Revert.
4027         * amd64-windows-tdep.c: Revert.
4028         * amd64-windows-nat.c: Revert.
4029         * amd64-tdep.c: Revert.
4030         * amd64-sol2-tdep.c: Revert.
4031         * amd64-obsd-tdep.c: Revert.
4032         * amd64-obsd-nat.c: Revert.
4033         * amd64-nbsd-tdep.c: Revert.
4034         * amd64-nbsd-nat.c: Revert.
4035         * amd64-nat.c: Revert.
4036         * amd64-linux-tdep.c: Revert.
4037         * amd64-linux-nat.c: Revert.
4038         * amd64-fbsd-tdep.c: Revert.
4039         * amd64-fbsd-nat.c: Revert.
4040         * amd64-dicos-tdep.c: Revert.
4041         * amd64-darwin-tdep.c: Revert.
4042         * amd64-bsd-nat.c: Revert.
4043         * alpha-tdep.c: Revert.
4044         * alpha-obsd-tdep.c: Revert.
4045         * alpha-nbsd-tdep.c: Revert.
4046         * alpha-mdebug-tdep.c: Revert.
4047         * alpha-linux-tdep.c: Revert.
4048         * alpha-linux-nat.c: Revert.
4049         * alpha-bsd-tdep.c: Revert.
4050         * alpha-bsd-nat.c: Revert.
4051         * aix-thread.c: Revert.
4052         * agent.c: Revert.
4053         * addrmap.c: Revert.
4054         * ada-varobj.c: Revert.
4055         * ada-valprint.c: Revert.
4056         * ada-typeprint.c: Revert.
4057         * ada-tasks.c: Revert.
4058         * ada-lang.c: Revert.
4059         * aarch64-tdep.c: Revert.
4060         * aarch64-ravenscar-thread.c: Revert.
4061         * aarch64-newlib-tdep.c: Revert.
4062         * aarch64-linux-tdep.c: Revert.
4063         * aarch64-linux-nat.c: Revert.
4064         * aarch64-fbsd-tdep.c: Revert.
4065         * aarch64-fbsd-nat.c: Revert.
4066         * aarch32-linux-nat.c: Revert.
4067
4068 2019-04-05  Tom Tromey  <tom@tromey.com>
4069
4070         * ft32-tdep.c: Sort headers.
4071         * frv-tdep.c: Sort headers.
4072         * frv-linux-tdep.c: Sort headers.
4073         * frame.c: Sort headers.
4074         * frame-unwind.c: Sort headers.
4075         * frame-base.c: Sort headers.
4076         * fork-child.c: Sort headers.
4077         * findvar.c: Sort headers.
4078         * findcmd.c: Sort headers.
4079         * filesystem.c: Sort headers.
4080         * filename-seen-cache.h: Sort headers.
4081         * filename-seen-cache.c: Sort headers.
4082         * fbsd-tdep.c: Sort headers.
4083         * fbsd-nat.h: Sort headers.
4084         * fbsd-nat.c: Sort headers.
4085         * f-valprint.c: Sort headers.
4086         * f-typeprint.c: Sort headers.
4087         * f-lang.c: Sort headers.
4088         * extension.h: Sort headers.
4089         * extension.c: Sort headers.
4090         * extension-priv.h: Sort headers.
4091         * expprint.c: Sort headers.
4092         * exec.h: Sort headers.
4093         * exec.c: Sort headers.
4094         * exceptions.c: Sort headers.
4095         * event-top.c: Sort headers.
4096         * event-loop.c: Sort headers.
4097         * eval.c: Sort headers.
4098         * elfread.c: Sort headers.
4099         * dwarf2read.h: Sort headers.
4100         * dwarf2read.c: Sort headers.
4101         * dwarf2loc.c: Sort headers.
4102         * dwarf2expr.h: Sort headers.
4103         * dwarf2expr.c: Sort headers.
4104         * dwarf2-frame.c: Sort headers.
4105         * dwarf2-frame-tailcall.c: Sort headers.
4106         * dwarf-index-write.h: Sort headers.
4107         * dwarf-index-write.c: Sort headers.
4108         * dwarf-index-common.c: Sort headers.
4109         * dwarf-index-cache.h: Sort headers.
4110         * dwarf-index-cache.c: Sort headers.
4111         * dummy-frame.c: Sort headers.
4112         * dtrace-probe.c: Sort headers.
4113         * disasm.h: Sort headers.
4114         * disasm.c: Sort headers.
4115         * disasm-selftests.c: Sort headers.
4116         * dictionary.c: Sort headers.
4117         * dicos-tdep.c: Sort headers.
4118         * demangle.c: Sort headers.
4119         * dcache.h: Sort headers.
4120         * dcache.c: Sort headers.
4121         * darwin-nat.h: Sort headers.
4122         * darwin-nat.c: Sort headers.
4123         * darwin-nat-info.c: Sort headers.
4124         * d-valprint.c: Sort headers.
4125         * d-namespace.c: Sort headers.
4126         * d-lang.c: Sort headers.
4127         * ctf.c: Sort headers.
4128         * csky-tdep.c: Sort headers.
4129         * csky-linux-tdep.c: Sort headers.
4130         * cris-tdep.c: Sort headers.
4131         * cris-linux-tdep.c: Sort headers.
4132         * cp-valprint.c: Sort headers.
4133         * cp-support.c: Sort headers.
4134         * cp-namespace.c: Sort headers.
4135         * cp-abi.c: Sort headers.
4136         * corelow.c: Sort headers.
4137         * corefile.c: Sort headers.
4138         * continuations.c: Sort headers.
4139         * completer.h: Sort headers.
4140         * completer.c: Sort headers.
4141         * complaints.c: Sort headers.
4142         * coffread.c: Sort headers.
4143         * coff-pe-read.c: Sort headers.
4144         * cli-out.h: Sort headers.
4145         * cli-out.c: Sort headers.
4146         * charset.c: Sort headers.
4147         * c-varobj.c: Sort headers.
4148         * c-valprint.c: Sort headers.
4149         * c-typeprint.c: Sort headers.
4150         * c-lang.c: Sort headers.
4151         * buildsym.c: Sort headers.
4152         * buildsym-legacy.c: Sort headers.
4153         * build-id.h: Sort headers.
4154         * build-id.c: Sort headers.
4155         * btrace.c: Sort headers.
4156         * bsd-uthread.c: Sort headers.
4157         * breakpoint.h: Sort headers.
4158         * breakpoint.c: Sort headers.
4159         * break-catch-throw.c: Sort headers.
4160         * break-catch-syscall.c: Sort headers.
4161         * break-catch-sig.c: Sort headers.
4162         * blockframe.c: Sort headers.
4163         * block.c: Sort headers.
4164         * bfin-tdep.c: Sort headers.
4165         * bfin-linux-tdep.c: Sort headers.
4166         * bfd-target.c: Sort headers.
4167         * bcache.c: Sort headers.
4168         * ax-general.c: Sort headers.
4169         * ax-gdb.h: Sort headers.
4170         * ax-gdb.c: Sort headers.
4171         * avr-tdep.c: Sort headers.
4172         * auxv.c: Sort headers.
4173         * auto-load.c: Sort headers.
4174         * arm-wince-tdep.c: Sort headers.
4175         * arm-tdep.c: Sort headers.
4176         * arm-symbian-tdep.c: Sort headers.
4177         * arm-pikeos-tdep.c: Sort headers.
4178         * arm-obsd-tdep.c: Sort headers.
4179         * arm-nbsd-tdep.c: Sort headers.
4180         * arm-nbsd-nat.c: Sort headers.
4181         * arm-linux-tdep.c: Sort headers.
4182         * arm-linux-nat.c: Sort headers.
4183         * arm-fbsd-tdep.c: Sort headers.
4184         * arm-fbsd-nat.c: Sort headers.
4185         * arm-bsd-tdep.c: Sort headers.
4186         * arch-utils.c: Sort headers.
4187         * arc-tdep.c: Sort headers.
4188         * arc-newlib-tdep.c: Sort headers.
4189         * annotate.h: Sort headers.
4190         * annotate.c: Sort headers.
4191         * amd64-windows-tdep.c: Sort headers.
4192         * amd64-windows-nat.c: Sort headers.
4193         * amd64-tdep.c: Sort headers.
4194         * amd64-sol2-tdep.c: Sort headers.
4195         * amd64-obsd-tdep.c: Sort headers.
4196         * amd64-obsd-nat.c: Sort headers.
4197         * amd64-nbsd-tdep.c: Sort headers.
4198         * amd64-nbsd-nat.c: Sort headers.
4199         * amd64-nat.c: Sort headers.
4200         * amd64-linux-tdep.c: Sort headers.
4201         * amd64-linux-nat.c: Sort headers.
4202         * amd64-fbsd-tdep.c: Sort headers.
4203         * amd64-fbsd-nat.c: Sort headers.
4204         * amd64-dicos-tdep.c: Sort headers.
4205         * amd64-darwin-tdep.c: Sort headers.
4206         * amd64-bsd-nat.c: Sort headers.
4207         * alpha-tdep.c: Sort headers.
4208         * alpha-obsd-tdep.c: Sort headers.
4209         * alpha-nbsd-tdep.c: Sort headers.
4210         * alpha-mdebug-tdep.c: Sort headers.
4211         * alpha-linux-tdep.c: Sort headers.
4212         * alpha-linux-nat.c: Sort headers.
4213         * alpha-bsd-tdep.c: Sort headers.
4214         * alpha-bsd-nat.c: Sort headers.
4215         * aix-thread.c: Sort headers.
4216         * agent.c: Sort headers.
4217         * addrmap.c: Sort headers.
4218         * ada-varobj.c: Sort headers.
4219         * ada-valprint.c: Sort headers.
4220         * ada-typeprint.c: Sort headers.
4221         * ada-tasks.c: Sort headers.
4222         * ada-lang.c: Sort headers.
4223         * aarch64-tdep.c: Sort headers.
4224         * aarch64-ravenscar-thread.c: Sort headers.
4225         * aarch64-newlib-tdep.c: Sort headers.
4226         * aarch64-linux-tdep.c: Sort headers.
4227         * aarch64-linux-nat.c: Sort headers.
4228         * aarch64-fbsd-tdep.c: Sort headers.
4229         * aarch64-fbsd-nat.c: Sort headers.
4230         * aarch32-linux-nat.c: Sort headers.
4231
4232 2019-04-04  Tom Tromey  <tom@tromey.com>
4233
4234         * varobj.c (varobj_create): Update.
4235         * rust-exp.y (struct rust_parser) <update_innermost_block,
4236         lookup_symbol>: New methods.
4237         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4238         Rename.
4239         (rust_parser::rust_lookup_type)
4240         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4241         * printcmd.c (display_command, do_one_display): Update.
4242         * parser-defs.h (struct parser_state) <parser_state>: Add
4243         "tracker" parameter.
4244         (block_tracker): New member.
4245         (class innermost_block_tracker) <innermost_block_tracker>: Add
4246         "types" parameter.
4247         <reset>: Remove method.
4248         (innermost_block): Don't declare.
4249         (null_post_parser): Update.
4250         * parse.c (innermost_block): Remove global.
4251         (write_dollar_variable): Update.
4252         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4253         Remove "tracker_types" parameter.
4254         (parse_expression): Add "tracker" parameter.
4255         (parse_expression_for_completion): Update.
4256         (null_post_parser): Add "tracker" parameter.
4257         * p-exp.y: Update rules.
4258         * m2-exp.y: Update rules.
4259         * language.h (struct language_defn) <la_post_parser>: Add
4260         "tracker" parameter.
4261         * go-exp.y: Update rules.
4262         * f-exp.y: Update rules.
4263         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4264         parameter.
4265         * d-exp.y: Update rules.
4266         * c-exp.y: Update rules.
4267         * breakpoint.c (set_breakpoint_condition): Create an
4268         innermost_block_tracker.
4269         (watch_command_1): Likewise.
4270         * ada-lang.c (resolve): Add "tracker" parameter.
4271         (resolve_subexp): Likewise.
4272         * ada-exp.y (write_var_from_sym): Update.
4273
4274 2019-04-04  Tom Tromey  <tom@tromey.com>
4275
4276         * type-stack.h: New file.
4277         * type-stack.c: New file.
4278         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4279         type-stack.h.
4280         (insert_into_type_stack, insert_type, push_type, push_type_int)
4281         (insert_type_address_space, pop_type, pop_type_int)
4282         (pop_typelist, pop_type_stack, append_type_stack)
4283         (push_type_stack, get_type_stack, push_typelist)
4284         (follow_type_instance_flags, follow_types): Don't declare.
4285         * parse.c (type_stack): Remove global.
4286         (parse_exp_in_context): Update.
4287         (insert_into_type_stack, insert_type, push_type, push_type_int)
4288         (insert_type_address_space, pop_type, pop_type_int)
4289         (pop_typelist, pop_type_stack, append_type_stack)
4290         (push_type_stack, get_type_stack, push_typelist)
4291         (follow_type_instance_flags, follow_types): Remove (moved to
4292         type-stack.c).
4293         * f-exp.y (type_stack): New global.
4294         Update rules.
4295         (push_kind_type, f_parse): Update.
4296         * d-exp.y (type_stack): New global.
4297         Update rules.
4298         (d_parse): Update.
4299         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4300         Update rules.
4301         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4302         (HFILES_NO_SRCDIR): Add type-stack.h.
4303
4304 2019-04-04  Tom Tromey  <tom@tromey.com>
4305
4306         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4307         (rust_parser::convert_ast_to_expression, rust_parse)
4308         (rust_lex_test_completion, rust_lex_tests): Update.
4309         * parser-defs.h (struct expr_completion_state): New.
4310         (struct parser_state) <parser_state>: Add completion parameter.
4311         <mark_struct_expression, mark_completion_tag>: New methods.
4312         <parse_completion, m_completion_state>: New members.
4313         (prefixify_expression, null_post_parser): Update.
4314         (mark_struct_expression, mark_completion_tag): Don't declare.
4315         * parse.c (parse_completion, expout_last_struct)
4316         (expout_tag_completion_type, expout_completion_name): Remove
4317         globals.
4318         (parser_state::mark_struct_expression)
4319         (parser_state::mark_completion_tag): Now methods.
4320         (prefixify_expression): Add last_struct parameter.
4321         (prefixify_subexp): Likewise.
4322         (parse_exp_1): Update.
4323         (parse_exp_in_context): Add cstate parameter.  Update.
4324         (parse_expression_for_completion): Create an
4325         expr_completion_state.
4326         (null_post_parser): Add "completion" parameter.
4327         * p-exp.y: Update rules.
4328         (yylex): Update.
4329         * language.h (struct language_defn) <la_post_parser>: Add
4330         "completing" parameter.
4331         * go-exp.y: Update rules.
4332         (lex_one_token): Update.
4333         * expression.h (parse_completion): Don't declare.
4334         * d-exp.y: Update rules.
4335         (lex_one_token): Update rules.
4336         * c-exp.y: Update rules.
4337         (lex_one_token): Update.
4338         * ada-lang.c (resolve): Add "parse_completion" parameter.
4339         (resolve_subexp): Likewise.
4340         (ada_resolve_function): Likewise.
4341
4342 2019-04-04  Tom Tromey  <tom@tromey.com>
4343
4344         * parser-defs.h (struct parser_state) <start_arglist,
4345         end_arglist>: New methods.
4346         <arglist_len, m_funcall_chain>: New members.
4347         (arglist_len, start_arglist, end_arglist): Don't declare.
4348         * parse.c (arglist_len, funcall_chain): Remove global.
4349         (start_arglist, end_arglist): Remove functions.
4350         (parse_exp_in_context): Update.
4351         * p-exp.y: Update rules.
4352         * m2-exp.y: Update rules.
4353         * go-exp.y: Update rules.
4354         * f-exp.y: Update rules.
4355         * d-exp.y: Update rules.
4356         * c-exp.y: Update rules.
4357
4358 2019-04-04  Tom Tromey  <tom@tromey.com>
4359
4360         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4361         lex_operator, push_back>: New methods.
4362         Update all rules.
4363         (rust_parser::lex_hex, lex_escape): Rename and update.
4364         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4365         (rust_parser::lex_operator): Rename and update.
4366         (rust_parser::lex_number, rustyylex, rustyyerror)
4367         (rust_lex_test_init, rust_lex_test_sequence)
4368         (rust_lex_test_push_back, rust_lex_tests): Update.
4369         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4370         parameter.
4371         <lexptr, prev_lexptr>: New members.
4372         (lexptr, prev_lexptr): Don't declare.
4373         * parse.c (lexptr, prev_lexptr): Remove globals.
4374         (parse_exp_in_context): Update.
4375         * p-exp.y (yylex, yyerror): Update.
4376         * m2-exp.y (parse_number, yylex, yyerror): Update.
4377         * go-exp.y (lex_one_token, yyerror): Update.
4378         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4379         * d-exp.y (lex_one_token, yyerror): Update.
4380         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4381         (lex_one_token, yyerror): Update.
4382         * ada-lex.l (YY_INPUT): Update.
4383         (rewind_to_char): Update.
4384         * ada-exp.y (yyerror): Update.
4385
4386 2019-04-04  Tom Tromey  <tom@tromey.com>
4387
4388         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4389         * parser-defs.h (struct parser_state) <parser_state>: Add new
4390         parameter.
4391         <comma_terminates>: New member.
4392         (comma_terminates): Don't declare global.
4393         * parse.c (comma_terminates): Remove global.
4394         (parse_exp_in_context): Update.
4395         * p-exp.y (yylex): Update.
4396         * m2-exp.y (yylex): Update.
4397         * go-exp.y (lex_one_token): Update.
4398         * f-exp.y (yylex): Update.
4399         * d-exp.y (lex_one_token): Update.
4400         * c-exp.y (lex_one_token): Update.
4401         * ada-lex.l: Update.
4402
4403 2019-04-04  Tom Tromey  <tom@tromey.com>
4404
4405         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4406         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4407         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4408         * parser-defs.h (paren_depth): Don't declare.
4409         * parse.c (paren_depth): Remove global.
4410         (parse_exp_in_context): Update.
4411         * p-exp.y (paren_depth): New global.
4412         (pascal_parse): Initialize it.
4413         * m2-exp.y (paren_depth): New global.
4414         (m2_parse): Initialize it.
4415         * go-exp.y (paren_depth): New global.
4416         (go_parse): Initialize it.
4417         * f-exp.y (paren_depth): New global.
4418         (f_parse): Initialize it.
4419         * d-exp.y (paren_depth): New global.
4420         (d_parse): Initialize it.
4421         * c-exp.y (paren_depth): New global.
4422         (c_parse): Initialize it.
4423         * ada-lex.l (paren_depth): New global.
4424         (lexer_init): Initialize it.
4425
4426 2019-04-04  Tom Tromey  <tom@tromey.com>
4427
4428         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4429         (rust_parser::convert_ast_to_type)
4430         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4431         * parser-defs.h (struct parser_state) <parser_state>: Add
4432         parameters.  Initialize new members.
4433         <expression_context_block, expression_context_pc>: New members.
4434         * parse.c (expression_context_block, expression_context_pc):
4435         Remove globals.
4436         (parse_exp_in_context): Update.
4437         * p-exp.y: Update all rules.
4438         (yylex): Update.
4439         * m2-exp.y: Update all rules.
4440         (yylex): Update.
4441         * go-exp.y (yylex): Update.
4442         * f-exp.y (yylex): Update.
4443         * d-exp.y: Update all rules.
4444         (yylex): Update.
4445         * c-exp.y: Update all rules.
4446         (lex_one_token, classify_name, yylex, c_parse): Update.
4447         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4448
4449 2019-04-04  Tom Tromey  <tom@tromey.com>
4450
4451         * gdbarch.h, gdbarch.c: Rebuild.
4452         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4453         * stap-probe.h:
4454         (struct stap_parse_info): Replace "parser_state" with
4455         "expr_builder".
4456         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4457         (parser_state): New class.
4458         * parse.c (expr_builder): Rename.
4459         (expr_builder::release): Rename.
4460         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4461         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4462         (write_exp_elt_longcst, write_exp_elt_floatcst)
4463         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4464         (write_exp_string_vector, write_exp_bitstring)
4465         (write_exp_msymbol, mark_struct_expression)
4466         (write_dollar_variable)
4467         (insert_type_address_space, increase_expout_size): Replace
4468         "parser_state" with "expr_builder".
4469         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4470         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4471         "parser_state" with "expr_builder".
4472
4473 2019-04-04  Tom Tromey  <tom@tromey.com>
4474
4475         * rust-exp.y: Replace "parse_language" with method call.
4476         * p-exp.y:
4477         (yylex): Replace "parse_language" with method call.
4478         * m2-exp.y:
4479         (yylex): Replace "parse_language" with method call.
4480         * go-exp.y (classify_name): Replace "parse_language" with method
4481         call.
4482         * f-exp.y (yylex): Replace "parse_language" with method call.
4483         * d-exp.y (lex_one_token): Replace "parse_language" with method
4484         call.
4485         * c-exp.y:
4486         (lex_one_token, classify_name, yylex): Replace "parse_language"
4487         with method call.
4488         * ada-exp.y (find_primitive_type, type_char)
4489         (type_system_address): Replace "parse_language" with method call.
4490
4491 2019-04-04  Tom Tromey  <tom@tromey.com>
4492
4493         * rust-exp.y: Replace "parse_gdbarch" with method call.
4494         * parse.c (write_dollar_variable, insert_type_address_space):
4495         Replace "parse_gdbarch" with method call.
4496         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4497         call.
4498         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4499         call.
4500         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4501         "parse_gdbarch" with method call.
4502         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4503         with method call.
4504         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4505         "parse_gdbarch" with method call.
4506         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4507         "parse_gdbarch" with method call.
4508         * c-exp.y (parse_type, parse_number, classify_name): Replace
4509         "parse_gdbarch" with method call.
4510         * ada-lex.l: Replace "parse_gdbarch" with method call.
4511         * ada-exp.y (parse_type, find_primitive_type, type_char)
4512         (type_system_address): Replace "parse_gdbarch" with method call.
4513
4514 2019-04-04  Tom Tromey  <tom@tromey.com>
4515
4516         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4517         * stap-probe.c (stap_parse_argument): Update.
4518         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4519         initial_size parameter.
4520         * rust-exp.y (rust_lex_tests): Update.
4521         * parse.c (parser_state): Update.
4522         (parse_exp_in_context): Update.
4523         * parser-defs.h (struct parser_state) <parser_state>: Remove
4524         "initial_size" parameter.
4525
4526 2019-04-04  Tom Tromey  <tom@tromey.com>
4527
4528         * parser-defs.h (increase_expout_size): Don't declare.
4529         * parse.c (increase_expout_size): Now static.
4530
4531 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4532
4533         * gnu-nat.c (gnu_nat_target::wait): Fix
4534         target_waitstatus_to_string call.
4535
4536 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4537
4538         * eval.c (evaluate_subexp_standard): Handle internal functions
4539         during Fortran function call handling.
4540
4541 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4542
4543         * NEWS: Mention new internal functions.
4544         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4545         (read_base_type): Use dwarf2_init_complex_target_type.
4546         * value.c (creal_internal_fn): New function.
4547         (cimag_internal_fn): New function.
4548         (_initialize_values): Register new internal functions.
4549
4550 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4551
4552         * infrun.c (stop_all_threads): If debug_infrun, always
4553         trace the wait status after wait_one, using
4554         target_waitstatus_to_string and target_pid_to_str.
4555         (handle_inferior_event): Replace various trace of
4556         wait status kind by a single trace.
4557         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4558         wait status kind image by target_waitstatus_to_string.
4559         * target/waitstatus.c (target_waitstatus_to_string): Fix
4560         obsolete comment.
4561
4562 2019-04-01  Tom Tromey  <tromey@adacore.com>
4563
4564         PR symtab/23331:
4565         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4566
4567 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4568             Pedro Alves  <palves@redhat.com>
4569
4570         * top.c (quit_force): Call 'finalize_values'.
4571         * value.c (finalize_values): New function.
4572         * value.h (finalize_values): Declare.
4573
4574 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4575
4576         * NEWS: Announce $_gdb_major and $_gdb_minor.
4577
4578         * top.c (init_gdb_version_vars): New function.
4579         (gdb_init): Call init_gdb_version_vars.
4580
4581 2019-03-29  Tom Tromey  <tromey@adacore.com>
4582
4583         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4584         help text.  Remove dead code.
4585
4586 2019-03-29  Keith Seitz  <keiths@redhat.com>
4587
4588         From Siddhesh Poyarekar:
4589         * f-lang.h (f77_get_upperbound): Return LONGEST.
4590         (f77_get_lowerbound): Likewise.
4591         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4592         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4593         print them.
4594         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4595         plongest to format print it.
4596         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4597         (f77_get_upperbound): Likewise.
4598         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4599         LOWER_BOUND to LONGEST.
4600         (f77_create_arrayprint_offset_tbl): Likewise.
4601
4602 2019-03-29  Keith Seitz  <keiths@redhat.com>
4603
4604         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4605         %s/pulongest for TYPE_LENGTH instead of %d in format
4606         strings.
4607         * ada-typerint.c (ada_print_type): Likewise.
4608         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4609         * compile/compile-c-support.c (generate_register_struct): Likewise.
4610         * gdbtypes.c (recursive_dump_type): Likewise.
4611         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4612         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4613         instead of %d in format strings.
4614         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4615         to std::min to ULONGEST.
4616         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4617         instead of %d in format strings.
4618         * tracepoint.c (info_scope_command): Likewise.
4619         * typeprint.c (print_offset_data::update)
4620         (print_offset_data::finish): Likewise.
4621         * xtensa-tdep.c (xtensa_store_return_value)
4622         (xtensa_push_dummy_call): Likewise.
4623
4624 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4625
4626         * windows-nat.c (display_selector): Fixed format specifications
4627         for 64-bit Cygwin.
4628
4629 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4630
4631         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4632
4633 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4634
4635         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4636         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4637         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4638         (nios2_linux_init_abi): Install it.
4639
4640 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4641
4642         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4643
4644 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4645
4646         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4647
4648 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4649             Tom Tromey  <tromey@adacore.com>
4650
4651         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4652
4653 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4654
4655         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4656         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4657         method to compute the bounds of range types. Also print "[evaluated]"
4658         if the bounds' values come from a dynamic evaluation.
4659
4660 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4661
4662         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4663         whitespace when pretty printing is on.
4664
4665 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4666
4667         * ppc-linux-nat.c: Add include.
4668
4669 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4670
4671         * NEWS: Mention AArch64 Pointer Authentication.
4672
4673 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4674
4675         * arm-linux-nat.c: Add include.
4676
4677 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4678
4679         * source-cache.c (source_cache::get_source_lines): Re-read
4680         fullname after calling open_source_file.
4681
4682 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4683
4684         * NEWS: Mention TLS support for FreeBSD.
4685
4686 2019-03-25  Tom Tromey  <tromey@adacore.com>
4687
4688         * minsyms.c (BUNCH_SIZE): Update comment.
4689         (~minimal_symbol_reader): Remove old comment.
4690         (compact_minimal_symbols): Update comment.
4691         (minimal_symbol_reader::install): Remove old comment.  Update
4692         other comments.
4693
4694 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4695
4696         * s390-linux-nat.c: Add include.
4697
4698 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4699
4700         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4701         Call linux_get_hwcap.
4702         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4703         Likewise.
4704         (aarch64_linux_get_hwcap): Remove function.
4705         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4706         declaration.
4707         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4708         linux_get_hwcap.
4709         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4710         * linux-tdep.c (linux_get_hwcap): Add function.
4711         (linux_get_hwcap2): Likewise.
4712         * linux-tdep.h (linux_get_hwcap): Add declaration.
4713         (linux_get_hwcap2): Likewise.
4714         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4715         (ppc_linux_get_hwcap2): Likewise.
4716         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4717         linux_get_hwcap.
4718         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4719         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4720         (ppc_linux_nat_target::read_description): Likewise.
4721         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4722         * s390-linux-nat.c: Likewise.
4723         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4724
4725 2019-03-24  Tom Tromey  <tom@tromey.com>
4726
4727         * ada-lang.c (standard_lookup): Simplify initialization.
4728         (ada_lookup_symbol_nonlocal): Simplify return.
4729         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4730         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4731         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4732         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4733         initialization.
4734         * solib.c (solib_global_lookup): Simplify.
4735         * symtab.c (null_block_symbol): Remove.
4736         (symbol_cache_lookup): Simplify returns.
4737         (lookup_language_this): Simplify returns.
4738         (lookup_symbol_aux): Simplify return.
4739         (lookup_local_symbol): Simplify returns.
4740         (lookup_global_symbol_from_objfile): Simplify return.
4741         (lookup_symbol_in_objfile_symtabs)
4742         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4743         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4744         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4745         * cp-namespace.c (cp_lookup_bare_symbol)
4746         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4747         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4748         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4749         (cp_lookup_symbol_via_imports): Simplify initialization.
4750         (find_symbol_in_baseclass): Likewise.
4751         * symtab.h (null_block_symbol): Remove.
4752         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4753         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4754         (d_lookup_symbol_module): Likewise.
4755         (find_symbol_in_baseclass): Simplify initialization.
4756
4757 2019-03-24  Tom Tromey  <tom@tromey.com>
4758
4759         * expression.h: Don't include symtab.h.
4760         (struct block): Forward declare.
4761
4762 2019-03-24  Tom Tromey  <tom@tromey.com>
4763
4764         * c-exp.y (typebase): Remove casts.
4765         * gdbtypes.c (lookup_unsigned_typename, )
4766         (lookup_signed_typename): Remove cast.
4767         * eval.c (parse_to_comma_and_eval): Remove cast.
4768         * parse.c (write_dollar_variable): Remove cast.
4769         * block.h (struct block) <superblock>: Now const.
4770         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4771         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4772         (map_block): Make "block" const.
4773         * symfile.h (struct quick_symbol_functions)
4774         <map_matching_symbols>: Constify block argument to "callback".
4775         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4776         const.
4777         (find_pc_sect_compunit_symtab): Make "b" const.
4778         (find_symbol_at_address): Likewise.
4779         (search_symbols): Likewise.
4780         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4781         (dw2_debug_names_lookup_symbol): Likewise.
4782         (dw2_map_matching_symbols): Update.
4783         * p-valprint.c (pascal_val_print): Remove "block".
4784         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4785         (aux_add_nonlocal_symbols): Make "block" const.
4786         (resolve_subexp): Remove cast.
4787         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4788         const.
4789         (iterate_over_file_blocks): Likewise.
4790         * f-exp.y (%union) <bval>: Remove.
4791         * coffread.c (patch_opaque_types): Make "b" const.
4792         * spu-tdep.c (spu_catch_start): Make "block" const.
4793         * c-valprint.c (print_unpacked_pointer): Remove "block".
4794         * symmisc.c (dump_symtab_1): Make "b" const.
4795         (block_depth): Make "block" const.
4796         * d-exp.y (%union) <bval>: Remove.
4797         * cp-support.h (cp_lookup_rtti_type): Update.
4798         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4799         * psymtab.c (psym_lookup_symbol): Make "block" const.
4800         (maintenance_check_psymtabs): Make "b" const.
4801         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4802         (enumerate_locals, enumerate_args): Update.
4803         * python/py-symtab.c (stpy_global_block): Make "block" const.
4804         (stpy_static_block): Likewise.
4805         * inline-frame.c (block_starting_point_at): Make "new_block"
4806         const.
4807         * block.c (find_block_in_blockvector): Make return type const.
4808         (blockvector_for_pc_sect): Make "b" const.
4809         (find_block_in_blockvector): Make "b" const.
4810
4811 2019-03-23  Tom Tromey  <tom@tromey.com>
4812
4813         * varobj.c (varobj_create): Update.
4814         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4815         * printcmd.c (display_command, do_one_display): Don't reset
4816         innermost_block.
4817         * parser-defs.h (enum innermost_block_tracker_type): Move to
4818         expression.h.
4819         (innermost_block): Update comment.
4820         * parse.c (parse_exp_1): Add tracker_types parameter.
4821         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4822         tracker_types parameter.  Reset innermost_block.
4823         (parse_exp_in_context): Remove.
4824         (parse_expression_for_completion): Update.
4825         * objfiles.c (~objfile): Don't reset expression_context_block or
4826         innermost_block.
4827         * expression.h (enum innermost_block_tracker_type): Move from
4828         parser-defs.h.
4829         (parse_exp_1): Add tracker_types parameter.
4830         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4831         reset innermost_block.
4832
4833 2019-03-23  Tom Tromey  <tom@tromey.com>
4834
4835         * objfiles.h: Include bcache.h.
4836
4837 2019-03-23  Tom Tromey  <tom@tromey.com>
4838
4839         * linespec.c (get_current_search_block): Use
4840         scoped_restore_current_language.
4841         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4842
4843 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4844             Jiong Wang  <jiong.wang@arm.com>
4845
4846         * aarch64-linux-tdep.c
4847         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4848         section.
4849         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4850
4851 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4852             Jiong Wang  <jiong.wang@arm.com>
4853
4854         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4855         instructions.
4856         (aarch64_analyze_prologue_test): Add PACIASP test.
4857         (aarch64_prologue_prev_register): Unmask PC value.
4858
4859 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4860             Jiong Wang  <jiong.wang@arm.com>
4861
4862         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4863         (aarch64_dwarf2_prev_register): Unmask PC value.
4864         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4865         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4866         DW_CFA_AARCH64_negate_ra_state.
4867         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4868
4869 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4870             Jiong Wang  <jiong.wang@arm.com>
4871
4872         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4873         registers.
4874         (aarch64_pseudo_register_name): Likewise.
4875         (aarch64_pseudo_register_type): Likewise.
4876         (aarch64_pseudo_register_reggroup_p): Likewise.
4877         (aarch64_gdbarch_init): Add pauth registers.
4878         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4879         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4880         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4881         (struct gdbarch_tdep): Add regnum for ra_state.
4882
4883 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4884             Jiong Wang  <jiong.wang@arm.com>
4885
4886         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4887
4888 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4889             Jiong Wang  <jiong.wang@arm.com>
4890
4891         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4892         function.
4893         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4894         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4895         (aarch64_gdbarch_init): Add puth registers.
4896         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4897         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4898         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4899
4900 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4901             Jiong Wang  <jiong.wang@arm.com>
4902
4903         * aarch64-linux-nat.c
4904         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4905         * aarch64-linux-tdep.c
4906         (aarch64_linux_core_read_description): Likewise.
4907         (aarch64_linux_get_hwcap): New function.
4908         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4909         (aarch64_linux_get_hwcap): New declaration.
4910
4911 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4912             Jiong Wang  <jiong.wang@arm.com>
4913
4914         * aarch64-linux-nat.c
4915         (aarch64_linux_nat_target::read_description): Add pauth param.
4916         * aarch64-linux-tdep.c
4917         (aarch64_linux_core_read_description): Likewise.
4918         * aarch64-tdep.c (struct target_desc): Add in pauth.
4919         (aarch64_read_description): Add pauth param.
4920         (aarch64_gdbarch_init): Likewise.
4921         * aarch64-tdep.h (aarch64_read_description): Likewise.
4922         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4923         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4924         * features/Makefile: Add new files.
4925         * features/aarch64-pauth.c: New file.
4926         * features/aarch64-pauth.xml: New file.
4927
4928 2019-03-20  Tom Tromey  <tromey@adacore.com>
4929
4930         * infrun.c (handle_inferior_event): Rename from
4931         handle_inferior_event_1.  Create a scoped_value_mark.
4932         (handle_inferior_event): Remove.
4933
4934 2019-03-19  Tom Tromey  <tromey@adacore.com>
4935
4936         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4937         * infrun.h (print_stop_event): Add "displays" parameter.
4938         * infrun.c (print_stop_event): Add "displays" parameter.
4939
4940 2019-03-19  Pedro Alves  <palves@redhat.com>
4941
4942         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4943         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4944         to -1.  Fix TABs vs spaces.
4945         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4946         * tui/tui-out.h (tui_ui_out) Add intro comments.
4947         <m_line, m_start_of_line>: In-class initialize, and add describing
4948         comment.
4949
4950 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4951
4952         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4953         variable names.
4954         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4955
4956 2019-03-18  Pedro Alves  <palves@redhat.com>
4957             Eli Zaretskii <eliz@gnu.org>
4958
4959         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4960         m_line and m_start_of_line.
4961
4962 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4963
4964         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4965         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4966         it returns a newline.  This fixes a regression in TU mode, whereby
4967         the next line is output on the same screen line as the user input.
4968
4969 2019-03-18  Tom Tromey  <tromey@adacore.com>
4970
4971         * minsyms.c (minimal_symbol_reader::install): Remove call to
4972         obstack_blank.
4973
4974 2019-03-18  Pedro Alves  <palves@redhat.com>
4975
4976         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4977         New globals.
4978         (apply_style): New, factored out from ...
4979         (apply_ansi_escape): ... this.  Handle reverse video mode.
4980         (tui_set_reverse_mode): New function.
4981         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4982         * tui/tui-winsource.c (tui_show_source_line): Use
4983         tui_set_reverse_mode instead of setting A_STANDOUT.
4984         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4985         New setter methods.
4986
4987 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4988
4989         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4990         Handle tabs.
4991
4992 2019-03-18  Tom Tromey  <tromey@adacore.com>
4993
4994         * ada-lang.c (empty_array): Add "high" parameter.
4995         (ada_evaluate_subexp): Update.
4996
4997 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4998
4999         * unittests/string_view-selftests.c: Define
5000         _initialize_string_view_selftests unconditionally.
5001
5002 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5003
5004         PR gdb/24350
5005         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5006
5007 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5008
5009         PR gdb/24351
5010         * windows-nat.c (display_selector): Fix format specifiers.
5011
5012 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5013
5014         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5015         tui_refill_source_window instead of tui_refresh_win, to update the
5016         current execution line.  This fixes redisplay of the current line
5017         when stepping through the code with "next" or "step".
5018
5019 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5020
5021         * source-cache.c (source_cache::get_source_lines): Call
5022         find_source_lines to initialize s->nlines.  This fixes vertical
5023         scrolling of TUI source window when the DOWN arrow is pressed.
5024
5025 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5026
5027         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5028         linux-thread-db.c (_initialize_thread_db): Likewise.
5029
5030 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5031
5032         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5033         wclrtoeol in tui_show_source_line".  This reverts changes made in
5034         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5035
5036 2019-03-15  Tom Tromey  <tom@tromey.com>
5037
5038         * symtab.h (struct minimal_symbol): Derive from
5039         general_symbol_info.
5040         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5041         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5042         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5043         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5044         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5045         (MSYMBOL_SEARCH_NAME): Update.
5046         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5047         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5048         * minsyms.c (minimal_symbol_reader::record_full): Update.
5049
5050 2019-03-15  Tom Tromey  <tom@tromey.com>
5051
5052         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5053
5054 2019-03-15  Tom Tromey  <tom@tromey.com>
5055
5056         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5057         unique_xmalloc_ptr.
5058         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5059         Update.
5060         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5061         (build_minimal_symbol_hash_tables)
5062         (minimal_symbol_reader::install): Update.
5063
5064 2019-03-15  Tom Tromey  <tom@tromey.com>
5065
5066         * symtab.c (create_demangled_names_hash): Update.
5067         (symbol_set_names): Update.
5068         * objfiles.h (struct objfile_per_bfd_storage)
5069         <demangled_names_hash>: Now an htab_up.
5070         * objfiles.c (objfile_per_bfd_storage): Simplify.
5071
5072 2019-03-15  Tom Tromey  <tom@tromey.com>
5073
5074         * objfiles.h (struct objfile_per_bfd_storage): Declare
5075         destructor.
5076         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5077         New.
5078         (get_objfile_bfd_data): Use new.  Don't initialize
5079         language_of_main.
5080         (free_objfile_per_bfd_storage): Remove.
5081         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5082
5083 2019-03-15  Tom Tromey  <tom@tromey.com>
5084
5085         * symfile.c (reread_symbols): Update.
5086         * objfiles.c (objfile::objfile): Update.
5087         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5088         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5089         comment.
5090         (minimal_symbol_reader::install): Update.
5091         (terminate_minimal_symbol_table): Remove.
5092         * jit.c (jit_object_close_impl): Update.
5093
5094 2019-03-15  Tom Tromey  <tom@tromey.com>
5095
5096         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5097         initializations.
5098
5099 2019-03-15  Tom Tromey  <tom@tromey.com>
5100
5101         * objfiles.h (struct objfile_per_bfd_storage)
5102         <demangled_hash_languages>: Now a bitset.
5103         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5104         (lookup_minimal_symbol): Update.
5105
5106 2019-03-15  Tom Tromey  <tom@tromey.com>
5107
5108         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5109         Don't return the symbol.
5110         * coffread.c (record_minimal_symbol): Use record_full.
5111
5112 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5113
5114         The MS-Windows port of ncurses fails to switch to a color pair if
5115         one or both of the colors are the implicit default colors.  This
5116         change records the default colors when TUI is initialized, and
5117         then specifies them explicitly when a color pair uses the default
5118         colors.  This allows color styling in TUI mode on MS-Windows.
5119
5120         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5121         ncurses_norm_attr.
5122         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5123         colors in ncurses_norm_attr.
5124         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5125         "none", replace it with the default color recorded in
5126         ncurses_norm_attr.
5127
5128 2019-03-14  Tom Tromey  <tromey@adacore.com>
5129
5130         * source-cache.h (class source_cache) <get_source_lines>: Return
5131         std::string.
5132         * source-cache.c (source_cache::extract_lines): Handle case where
5133         first_pos==npos.  Return std::string.
5134         (source_cache::get_source_lines): Update.
5135
5136 2019-03-14  Tom Tromey  <tromey@adacore.com>
5137
5138         * NEWS: Add item for "style sources" commands.
5139         * source-cache.c (source_cache::get_source_lines): Check
5140         source_styling.
5141         * cli/cli-style.c (source_styling): New global.
5142         (_initialize_cli_style): Add "style sources" commands.
5143         (show_style_sources): New function.
5144         * cli/cli-style.h (source_styling): Declare.
5145
5146 2019-03-14  Pedro Alves  <palves@redhat.com>
5147             Tom Tromey  <tromey@adacore.com>
5148
5149         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5150         * tui/tui-winsource.c (tui_refill_source_window): New function,
5151         from...
5152         (tui_horizontal_source_scroll): ... here.  Move some logic.
5153         * cli/cli-style.c (set_style_enabled): Notify new observable.
5154         * tui/tui-hooks.c (tui_redisplay_source): New function.
5155         (tui_attach_detach_observers): Attach or detach
5156         tui_redisplay_source.
5157         * observable.h (source_styling_changed): New observable.
5158         * observable.c: Define source_styling_changed observable.
5159
5160 2019-03-13  Tom Tromey  <tromey@adacore.com>
5161
5162         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5163         (i386_gnu_nat_target::store_registers): Update.
5164         * target-debug.h (target_debug_print_std_string): New macro.
5165         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5166         * windows-tdep.c (display_one_tib): Update.
5167         * tui/tui-stack.c (tui_make_status_line): Update.
5168         * top.c (print_inferior_quit_action): Update.
5169         * thread.c (thr_try_catch_cmd): Update.
5170         (add_thread_with_info): Update.
5171         (thread_target_id_str): Update.
5172         (thr_try_catch_cmd): Update.
5173         (thread_command): Update.
5174         (thread_find_command): Update.
5175         * record-btrace.c (record_btrace_target::info_record)
5176         (record_btrace_resume_thread, record_btrace_target::resume)
5177         (record_btrace_cancel_resume, record_btrace_step_thread)
5178         (record_btrace_target::wait, record_btrace_target::wait)
5179         (record_btrace_target::wait, record_btrace_target::stop): Update.
5180         * progspace.c (print_program_space): Update.
5181         * process-stratum-target.c
5182         (process_stratum_target::thread_address_space): Update.
5183         * linux-fork.c (linux_fork_mourn_inferior)
5184         (detach_checkpoint_command, info_checkpoints_command)
5185         (linux_fork_context): Update.
5186         (linux_fork_detach): Update.
5187         (class scoped_switch_fork_info): Update.
5188         (delete_checkpoint_command): Update.
5189         * infrun.c (follow_fork_inferior): Update.
5190         (follow_fork_inferior): Update.
5191         (proceed_after_vfork_done): Update.
5192         (handle_vfork_child_exec_or_exit): Update.
5193         (follow_exec): Update.
5194         (displaced_step_prepare_throw): Update.
5195         (displaced_step_restore): Update.
5196         (start_step_over): Update.
5197         (resume_1): Update.
5198         (clear_proceed_status_thread): Update.
5199         (proceed): Update.
5200         (print_target_wait_results): Update.
5201         (do_target_wait): Update.
5202         (context_switch): Update.
5203         (stop_all_threads): Update.
5204         (restart_threads): Update.
5205         (finish_step_over): Update.
5206         (handle_signal_stop): Update.
5207         (switch_back_to_stepped_thread): Update.
5208         (keep_going_pass_signal): Update.
5209         (print_exited_reason): Update.
5210         (normal_stop): Update.
5211         * inferior.c (inferior_pid_to_str): Change return type.
5212         (print_selected_inferior): Update.
5213         (add_inferior): Update.
5214         (detach_inferior): Update.
5215         * dummy-frame.c (fprint_dummy_frames): Update.
5216         * dcache.c (dcache_info_1): Update.
5217         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5218         (btrace_fetch, btrace_clear): Update.
5219         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5220         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5221         type.
5222         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5223         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5224         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5225         * gdbarch.c, gdbarch.h: Rebuild.
5226         * gdbarch.sh (core_pid_to_str): Change return type.
5227         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5228         return type.
5229         (windows_nat_target::pid_to_str): Change return type.
5230         (windows_delete_thread): Update.
5231         (windows_nat_target::attach): Update.
5232         (windows_nat_target::files_info): Update.
5233         * target-delegates.c: Rebuild.
5234         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5235         return type.
5236         (sol_thread_target::pid_to_str): Change return type.
5237         * remote.c (class remote_target) <pid_to_str>: Change return
5238         type.
5239         (remote_target::pid_to_str): Change return type.
5240         (extended_remote_target::attach, remote_target::remote_stop_ns)
5241         (remote_target::remote_notif_remove_queued_reply)
5242         (remote_target::push_stop_reply, remote_target::disable_btrace):
5243         Update.
5244         (extended_remote_target::attach): Update.
5245         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5246         type.
5247         (gdbsim_target::pid_to_str): Change return type.
5248         * ravenscar-thread.c (struct ravenscar_thread_target)
5249         <pid_to_str>: Change return type.
5250         (ravenscar_thread_target::pid_to_str): Change return type.
5251         * procfs.c (class procfs_target) <pid_to_str>: Change return
5252         type.
5253         (procfs_target::pid_to_str): Change return type.
5254         (procfs_target::attach): Update.
5255         (procfs_target::detach): Update.
5256         (procfs_target::fetch_registers): Update.
5257         (procfs_target::store_registers): Update.
5258         (procfs_target::wait): Update.
5259         (procfs_target::files_info): Update.
5260         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5261         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5262         return type.
5263         (nto_procfs_target::pid_to_str): Change return type.
5264         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5265         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5266         return type.
5267         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5268         (exit_lwp): Update.
5269         (attach_proc_task_lwp_callback, get_detach_signal)
5270         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5271         (linux_nat_target::resume, wait_lwp, stop_callback)
5272         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5273         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5274         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5275         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5276         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5277         type.
5278         (inf_ptrace_target::attach): Update.
5279         (inf_ptrace_target::files_info): Update.
5280         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5281         type.
5282         (go32_nat_target::pid_to_str): Change return type.
5283         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5284         (gnu_nat_target::wait): Update.
5285         (gnu_nat_target::wait): Update.
5286         (gnu_nat_target::resume): Update.
5287         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5288         (fbsd_nat_target::wait): Update.
5289         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5290         type.
5291         (darwin_nat_target::attach): Update.
5292         * corelow.c (class core_target) <pid_to_str>: Change return type.
5293         (core_target::pid_to_str): Change return type.
5294         * target.c (normal_pid_to_str): Change return type.
5295         (default_pid_to_str): Likewise.
5296         (target_pid_to_str): Change return type.
5297         (target_translate_tls_address): Update.
5298         (target_announce_detach): Update.
5299         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5300         return type.
5301         (bsd_uthread_target::pid_to_str): Change return type.
5302         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5303         type.
5304         (bsd_kvm_target::pid_to_str): Change return type.
5305         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5306         return type.
5307         (aix_thread_target::pid_to_str): Change return type.
5308         * target.h (struct target_ops) <pid_to_str>: Change return type.
5309         (target_pid_to_str, normal_pid_to_str): Likewise.
5310         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5311         type.
5312         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5313         type.
5314         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5315         return type.
5316         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5317         type.
5318         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5319         type.
5320         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5321         return type.
5322
5323 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5324
5325         * NEWS: Mention that the new default MI version is 3.  Mention
5326         changes to the output of commands and events that deal with
5327         multi-location breakpoints.
5328         * breakpoint.c: Include "mi/mi-out.h".
5329         (print_one_breakpoint): Change output syntax if using MI version
5330         >= 3.
5331         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5332         New.
5333         (mi_multi_location_breakpoint_output_fixed): New.
5334         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5335         (mi_cmd_fix_multi_location_breakpoint_output): New.
5336         (mi_multi_location_breakpoint_output_fixed): New.
5337         * mi/mi-cmds.c (mi_cmds): Register command
5338         -fix-multi-location-breakpoint-output.
5339         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5340         interpreter "mi".
5341
5342 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5343
5344         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5345         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5346         instantiate mi_ui_out based on interpreter name.
5347         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5348         * mi/mi-main.c (mi_load_progress): Likewise.
5349
5350 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5351
5352         * NEWS: Combine separate "New targets" sections for 8.3.
5353
5354 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5355
5356         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5357         (ppcfbsd_init_abi): Install gdbarch
5358         "fetch_tls_load_module_address" and "get_thread_local_address"
5359         methods.
5360
5361 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5362
5363         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5364         (riscv_fbsd_init_abi): Install gdbarch
5365         "fetch_tls_load_module_address" and "get_thread_local_address"
5366         methods.
5367
5368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5369
5370         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5371         (i386fbsd_init_abi): Install gdbarch
5372         "fetch_tls_load_module_address" and "get_thread_local_address"
5373         methods.
5374
5375 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5376
5377         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5378         (amd64fbsd_init_abi): Install gdbarch
5379         "fetch_tls_load_module_address" and "get_thread_local_address"
5380         methods.
5381
5382 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5383
5384         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5385         (struct fbsd_pspace_data): New type.
5386         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5387         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5388         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5389         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5390         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5391
5392 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5393
5394         * gdbtypes.c (lookup_struct_elt): New function.
5395         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5396         * gdbtypes.h (struct struct_elt): New type.
5397         (lookup_struct_elt): New prototype.
5398
5399 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5400
5401         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5402         remove disabled code block.
5403
5404 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5405
5406         * gdbarch.sh (get_thread_local_address): New method.
5407         * gdbarch.h, gdbarch.c: Regenerate.
5408         * target.c (target_translate_tls_address): Use
5409         gdbarch_get_thread_local_address if present instead of
5410         target::get_thread_local_address.
5411
5412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5413
5414         * target.h (target::get_thread_local_address): Update comment.
5415
5416 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5417
5418         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5419         objfile->separate_debug_objfile_backlink if not NULL.
5420
5421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5422
5423         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5424         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5425         (amd64bsd_store_inferior_registers): Likewise.
5426         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5427         Enable segment base registers.
5428         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5429         PT_GETFSBASE and PT_GETGSBASE.
5430         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5431         PT_SETGSBASE.
5432         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5433         segment base registers.
5434         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5435
5436 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5437
5438         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5439         Update calls to i386_target_description to add 'segments'
5440         parameter.
5441         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5442         add segment base registers.
5443         * arch/i386.c (i386_create_target_description): Add 'segments'
5444         parameter to enable segment base registers.
5445         * arch/i386.h (i386_create_target_description): Likewise.
5446         * features/i386/32bit-segments.xml: New file.
5447         * features/i386/32bit-segments.c: Generate.
5448         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5449         call to i386_target_description to add 'segments' parameter.
5450         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5451         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5452         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5453         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5454         if feature is present.
5455         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5456         Add 'segments' parameter to call to i386_target_description.
5457         (i386_target_description): Add 'segments' parameter to enable
5458         segment base registers.
5459         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5460         to call to i386_target_description.
5461         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5462         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5463         Define I386_NUM_REGS.
5464         (i386_target_description): Add 'segments' parameter to enable
5465         segment base registers.
5466
5467 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5468
5469         PR/24325
5470         * source-cache.c: #undef open and close, to avoid unresolved
5471         externals during linking.
5472
5473 2019-03-12  Tom Tromey  <tromey@adacore.com>
5474
5475         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5476         const.  Add initializers.
5477         (_initialize_remote): Don't initialize ptid globals.
5478
5479 2019-03-12  Pedro Alves  <palves@redhat.com>
5480
5481         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5482
5483 2019-03-12  Pedro Alves  <palves@redhat.com>
5484
5485         * cp-name-parser.y (main): Remove unused 'len' variable.
5486
5487 2019-03-12  Tom Tromey  <tromey@adacore.com>
5488
5489         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5490         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5491
5492 2019-03-12  Tom Tromey  <tromey@adacore.com>
5493
5494         * linux-nat.c (iterate_over_lwps): Update.
5495         (stop_callback): Remove parameter.
5496         (stop_wait_callback, detach_callback, resume_set_callback)
5497         (select_singlestep_lwp_callback, set_ignore_sigint)
5498         (status_callback, resumed_callback, resume_clear_callback)
5499         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5500         data parameter.
5501         (linux_nat_target::detach, linux_nat_target::resume)
5502         (linux_stop_and_wait_all_lwps, select_event_lwp)
5503         (linux_nat_filter_event, linux_nat_wait_1)
5504         (linux_nat_target::kill, linux_nat_target::stop)
5505         (linux_nat_target::stop): Update.
5506         (linux_nat_resume_callback): Change type.
5507         (resume_stopped_resumed_lwps, count_events_callback)
5508         (select_event_lwp_callback): Likewise.
5509         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5510         * arm-linux-nat.c (struct update_registers_data): Remove.
5511         (update_registers_callback): Change type.
5512         (arm_linux_insert_hw_breakpoint1): Update.
5513         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5514         parameter.
5515         (x86_linux_dr_set_addr): Update.
5516         (x86_linux_dr_set_control): Update.
5517         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5518         (iterate_over_lwps): Use gdb::function_view.
5519         * nat/aarch64-linux-hw-point.c (struct
5520         aarch64_dr_update_callback_param): Remove.
5521         (debug_reg_change_callback): Change type.
5522         (aarch64_notify_debug_reg_change): Update.
5523         * s390-linux-nat.c (s390_refresh_per_info): Update.
5524
5525 2019-03-11  Tom Tromey  <tromey@adacore.com>
5526
5527         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5528         redundant assignment to "this_cu".
5529
5530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5531
5532         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5533
5534 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5535
5536         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5537         from...
5538         (rank_one_type): ... this.
5539
5540 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5541
5542         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5543         from...
5544         (rank_one_type): ... this.
5545
5546 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5547
5548         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5549         from...
5550         (rank_one_type): ... this.
5551
5552 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5553
5554         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5555         from...
5556         (rank_one_type): ... this.
5557
5558 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5559
5560         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5561         from...
5562         (rank_one_type): ... this.
5563
5564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5565
5566         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5567         from...
5568         (rank_one_type): ... this.
5569
5570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5571
5572         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5573         from...
5574         (rank_one_type): ... this.
5575
5576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5577
5578         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5579         from...
5580         (rank_one_type): ... this.
5581
5582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5583
5584         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5585         from...
5586         (rank_one_type): ... this.
5587
5588 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5589
5590         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5591         from...
5592         (rank_one_type): ... this.
5593
5594 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5595
5596         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5597         from...
5598         (rank_one_type): ... this.
5599
5600 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5601
5602         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5603         from...
5604         (rank_one_type): ... this.
5605
5606 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5607
5608         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5609         inferior-events' shows the example events.
5610
5611 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5612
5613         Support styling on native MS-Windows console
5614
5615         PR/24315
5616         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5617         on MS-Windows if $TERM is not defined.
5618
5619         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5620
5621         * posix-hdep.c (gdb_console_fputs):
5622         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5623         functions.
5624         * ui-file.h (gdb_console_fputs): Add prototype.
5625
5626         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5627         back to fputs only if the former returns zero.
5628
5629 2019-03-07  Tom Tromey  <tom@tromey.com>
5630
5631         * symmisc.c (print_symbol_bcache_statistics): Update.
5632         (print_objfile_statistics): Update.
5633         * symfile.c (allocate_symtab): Update.
5634         * stabsread.c: Don't include bcache.h.
5635         * psymtab.h (struct psymbol_bcache): Don't declare.
5636         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5637         (psymbol_bcache_init, psymbol_bcache_free)
5638         (psymbol_bcache_get_bcache): Don't declare.
5639         * psymtab.c (struct psymbol_bcache): Remove.
5640         (psymtab_storage::psymtab_storage): Update.
5641         (psymtab_storage::~psymtab_storage): Update.
5642         (psymbol_bcache_init, psymbol_bcache_free)
5643         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5644         (add_psymbol_to_bcache): Update.
5645         (allocate_psymtab): Update.
5646         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5647         macro_cache>: No longer pointers.
5648         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5649         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5650         * macrotab.c (macro_bcache): Update.
5651         * macroexp.c: Don't include bcache.h.
5652         * gdbtypes.c (check_types_worklist): Update.
5653         (types_deeply_equal): Remove TRY/CATCH.  Update.
5654         * elfread.c (elf_symtab_read): Update.
5655         * dwarf2read.c: Don't include bcache.h.
5656         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5657         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5658         (print_bcache_statistics, bcache_memory_used): Don't declare.
5659         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5660         methods.  Rename all data members.
5661         * bcache.c (struct bcache): Move to bcache.h.
5662         (bcache::expand_hash_table): Rename from expand_hash_table.
5663         (bcache): Remove.
5664         (bcache::insert): Rename from bcache_full.
5665         (bcache::compare): Rename from bcache_compare.
5666         (bcache_xmalloc): Remove.
5667         (bcache::~bcache): Rename from bcache_xfree.
5668         (bcache::print_statistics): Rename from print_bcache_statistics.
5669         (bcache::memory_used): Rename from bcache_memory_used.
5670
5671 2019-03-07  Pedro Alves  <palves@redhat.com>
5672
5673         * infrun.c (normal_stop): Also check for
5674         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5675
5676 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5677
5678         * f-lang.c (value_from_host_double): Moved to...
5679         * value.c (value_from_host_double): ...here.
5680         * value.h (value_from_host_double): Declare.
5681         * guile/scm-math.c (vlscm_convert_typed_number): Use
5682         value_from_host_double.
5683         (vlscm_convert_number): Likewise.
5684         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5685         * python/py-value.c (convert_value_from_python): Likewise.
5686
5687 2019-03-06  Tom Tromey  <tom@tromey.com>
5688
5689         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5690
5691 2019-03-06  Tom Tromey  <tom@tromey.com>
5692
5693         * utils.h (free_current_contents): Don't declare.
5694         * utils.c (free_current_contents): Remove.
5695
5696 2019-03-06  Tom Tromey  <tom@tromey.com>
5697
5698         * top.c (quit_force): Update.
5699         * main.c (captured_command_loop): Update.
5700         * common/new-op.c (operator new): Update.
5701         * common/common-exceptions.c (struct catcher)
5702         <save_cleanup_chain>: Remove member.
5703         (exceptions_state_mc_init): Update.
5704         (exception_try_scope_entry): Return nullptr.
5705         (exception_try_scope_exit, exception_rethrow)
5706         (throw_exception_sjlj, throw_exception_cxx): Update.
5707         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5708         (all_cleanups, do_cleanups, discard_cleanups)
5709         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5710         (restore_cleanups, restore_final_cleanups): Don't declare.
5711         (do_final_cleanups): Remove parameter.
5712         * common/cleanups.c (cleanup_chain, make_cleanup)
5713         (make_cleanup_dtor, all_cleanups, do_cleanups)
5714         (discard_my_cleanups, discard_cleanups)
5715         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5716         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5717         (null_cleanup): Remove.
5718         (do_final_cleanups): Remove parameter.
5719
5720 2019-03-06  Tom Tromey  <tom@tromey.com>
5721
5722         * remote.c (remote_target::remote_parse_stop_reply): Use
5723         unique_xmalloc_ptr.
5724
5725 2019-03-06  Tom Tromey  <tom@tromey.com>
5726
5727         * stabsread.c (struct stabs_field_info): Rename from field_info.
5728         <list, fnlist>: Add initializers.
5729         <obstack>: New member.
5730         (read_member_functions, read_struct_fields, read_baseclasses):
5731         Allocate on obstack.  Don't use cleanups.
5732         (read_one_struct_field, read_member_functions, read_struct_fields)
5733         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5734         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5735         (read_struct_type): Update.
5736
5737 2019-03-06  Tom Tromey  <tom@tromey.com>
5738
5739         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5740         * common/filestuff.h (make_cleanup_close): Don't declare.
5741         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5742         Remove.
5743
5744 2019-03-06  Tom Tromey  <tom@tromey.com>
5745
5746         * solib-aix.c: Use make_scope_exit.
5747
5748 2019-03-06  Tom Tromey  <tom@tromey.com>
5749
5750         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5751         Use make_scope_exit.
5752
5753 2019-03-06  Tom Tromey  <tom@tromey.com>
5754
5755         * solib-svr4.c (disable_probes_interface): Remove parameter.
5756         (svr4_handle_solib_event): Use make_scope_exit.
5757
5758 2019-03-06  Tom Tromey  <tom@tromey.com>
5759
5760         * remote.c (struct stop_reply_deleter): Remove.
5761         (stop_reply_up): Update.
5762         (struct stop_reply): Derive from notif_event.  Don't typedef.
5763         <regcache>: Now a std::vector.
5764         (stop_reply_xfree): Remove.
5765         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5766         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5767         (remote_target::discard_pending_stop_replies): Use delete.
5768         (remote_target::remote_parse_stop_reply): Update.
5769         (remote_target::process_stop_reply): Update.
5770         * remote-notif.h (struct notif_event): Add virtual destructor.
5771         Remove "dtr" member.
5772         (struct notif_client) <alloc_event>: Return a unique_ptr.
5773         (notif_event_xfree): Don't declare.
5774         (notif_event_up): New typedef.
5775         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5776         (notif_event_xfree, do_notif_event_xfree): Remove.
5777         (remote_notif_state_xfree): Update.
5778
5779 2019-03-06  Tom Tromey  <tom@tromey.com>
5780
5781         * infrun.c (displaced_step_clear_cleanup): Now a
5782         forward_scope_exit type.
5783         (displaced_step_prepare_throw): Update.
5784         (displaced_step_fixup): Update.
5785
5786 2019-03-06  Tom Tromey  <tom@tromey.com>
5787
5788         * inferior.h (class inferior): Update comment.
5789         * gdbthread.h (class thread_info): Update comment.
5790
5791 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5792             Tom Tromey  <tom@tromey.com>
5793
5794         * stabsread.h (struct stab_section_list): Remove.
5795         (coffstab_build_psymtabs): Update.
5796         * dbxread.c (symbuf_sections): Now a std::vector.
5797         (sect_idx): New global.
5798         (fill_symbuf): Update.
5799         (coffstab_build_psymtabs): Change type of stabsects parameter.
5800         Update.
5801         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5802         std::vector.
5803         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5804         (coff_locate_sections): Update.
5805         (coff_symfile_read): Remove cleanups.  Update.
5806         (init_stringtab): Add storage parameter.
5807         (free_stringtab, free_stringtab_cleanup): Remove.
5808         (init_lineno): Add storage parameter.
5809         (free_linetab, free_linetab_cleanup): Remove.
5810
5811 2019-03-06  Pedro Alves  <palves@redhat.com>
5812
5813         * linux-fork.c (fork_info::clobber_regs): Delete.
5814         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5815         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5816         comment.  Adjust.
5817         (scoped_switch_fork_info::scoped_switch_fork_info)
5818         (checkpoint_command, linux_fork_context): Adjust
5819         fork_save_infrun_state calls.
5820
5821 2019-03-06  Pedro Alves  <palves@redhat.com>
5822
5823         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5824         (inf_has_multiple_threads): Return 'bool' and rewrite using
5825         inferior_info::threads().
5826
5827 2019-03-06  Pedro Alves  <palves@redhat.com>
5828
5829         * linux-fork.c: Include <list>.
5830         (fork_list): Now a std::list instance.
5831         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5832         (forks_exist_p, find_last_fork): Adjust.
5833         (new_fork): Delete.
5834         (one_fork_p): New.
5835         (add_fork): Adjust.
5836         (free_fork): Delete, folded into fork_info::~fork_info().
5837         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5838         Adjust.
5839         (init_fork_list): Delete.
5840         (linux_fork_killall, linux_fork_mourn_inferior)
5841         (linux_fork_detach, info_checkpoints_command): Adjust.
5842         (_initialize_linux_fork): No longer call init_fork_list.
5843
5844 2019-03-06  Pedro Alves  <palves@redhat.com>
5845
5846         * linux-fork.c (new_fork): New, split out of ...
5847         (add_fork): ... this.  Return void.  Move "first fork" special
5848         case from here, to ...
5849         (checkpoint_command): ... here.
5850         * linux-linux.h (add_fork): Return void.
5851
5852 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5853
5854         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5855
5856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5857             Chris January  <chris.january@arm.com>
5858             David Lecomber  <david.lecomber@arm.com>
5859
5860         * f-exp.y: New token, UNOP_INTRINSIC.
5861         (exp): New pattern using UNOP_INTRINSIC token.
5862         (f77_keywords): Add 'abs' keyword.
5863         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5864         (value_from_host_double): New function.
5865         (evaluate_subexp_f): Support UNOP_ABS.
5866
5867 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5868
5869         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5870         types.
5871
5872 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5873
5874         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5875         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5876         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5877
5878 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5879
5880         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5881
5882 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5883             Chris January  <chris.january@arm.com>
5884
5885         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5886         * f-exp.y: Define 'KIND' token.
5887         (exp): New pattern for KIND expressions.
5888         (ptype): Handle types with a kind extension.
5889         (direct_abs_decl): Extend to spot kind extensions.
5890         (f77_keywords): Add 'kind' to the list.
5891         (push_kind_type): New function.
5892         (convert_to_kind_type): New function.
5893         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5894         * parse.c (operator_length_standard): Likewise.
5895         * parser-defs.h (enum type_pieces): Add tp_kind.
5896         * std-operator.def: Add UNOP_KIND.
5897
5898 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5899
5900         * f-exp.y (f_parse): Set yydebug.
5901
5902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5903
5904         * f-lang.c (evaluate_subexp_f): New function.
5905         (exp_descriptor_f): New global.
5906         (f_language_defn): Use exp_descriptor_f instead of
5907         exp_descriptor_standard.
5908
5909 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5910
5911         * f-exp.y (struct token): Add comments.
5912         (dot_ops): Remove uppercase versions and the end marker.
5913         (f77_keywords): Likewise.
5914         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5915         entries in the dot_ops array are case insensitive, and use
5916         strncasecmp to compare strings.  Also some whitespace cleanup in
5917         this area.  Similar for the f77_keywords array, except entries in
5918         this list might be case sensitive.
5919
5920 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * f-exp.y (struct f77_boolean_val): Add comments.
5923         (boolean_values): Remove uppercase versions, and end marker.
5924         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5925         and use strncasecmp to achieve case insensitivity.  Additionally,
5926         perform whitespace cleanup around this code.
5927
5928 2019-03-06  Tom Tromey  <tromey@adacore.com>
5929
5930         * remote-sim.c (gdbsim_target_open): Use result of
5931         gdb_argv::release.
5932
5933 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5934         Dirk Schubert  <dirk.schubert@arm.com>
5935         Chris January  <chris.january@arm.com>
5936
5937         * eval.c (evaluate_subexp_standard): Call Fortran argument
5938         wrapping logic.
5939         * f-lang.c (struct value): A value which can be passed into a
5940         Fortran function call.
5941         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5942         where appropriate.
5943         (struct type): Value ready for a Fortran function call.
5944         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5945         is needed.
5946         * f-lang.h (fortran_argument_convert): Declaration.
5947         (fortran_preserve_arg_pointer): Declaration.
5948         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5949
5950 2019-03-05  Tom Tromey  <tromey@adacore.com>
5951
5952         * python/py-prettyprint.c (print_string_repr): Remove #if.
5953         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5954
5955 2019-03-05  Tom Tromey  <tromey@adacore.com>
5956
5957         * target.c (the_dummy_target): Move later.  Change type to
5958         "dummy_target".
5959         (initialize_targets): Don't initialize the_dummy_target.
5960
5961 2019-03-05  Tom Tromey  <tromey@adacore.com>
5962
5963         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5964         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5965
5966 2019-03-05  Tom Tromey  <tromey@adacore.com>
5967
5968         * windows-nat.c (windows_nat_target::attach)
5969         (windows_nat_target::detach): Don't call gdb_flush.
5970         * valprint.c (generic_val_print, val_print, val_print_string):
5971         Don't call gdb_flush.
5972         * utils.c (defaulted_query): Don't call gdb_flush.
5973         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5974         * target.c (target_announce_detach): Don't call gdb_flush.
5975         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5976         * remote.c (extended_remote_target::attach): Don't call
5977         gdb_flush.
5978         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5979         * printcmd.c (do_examine): Don't call gdb_flush.
5980         (info_display_command): Don't call gdb_flush.
5981         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5982         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5983         * memattr.c (info_mem_command): Don't call gdb_flush.
5984         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5985         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5986         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5987         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5988         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5989         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5990         (gnu_nat_target::detach): Don't call gdb_flush.
5991         * f-valprint.c (f_val_print): Don't call gdb_flush.
5992         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5993         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5994         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5995         gdb_flush.
5996         * c-valprint.c (c_val_print): Don't call gdb_flush.
5997         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5998
5999 2019-03-05  Tom Tromey  <tromey@adacore.com>
6000
6001         * varobj.c (update_dynamic_varobj_children): Update.
6002         (install_default_visualizer): Use reset, not release.
6003         * value.c (set_internalvar): Update.
6004         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6005         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6006         ATTRIBUTE_UNUSED_RESULT.
6007
6008 2019-03-05  Tom Tromey  <tromey@adacore.com>
6009
6010         * remote.c (class scoped_remote_fd) <release>: Add
6011         ATTRIBUTE_UNUSED_RESULT.
6012
6013 2019-03-05  Tom Tromey  <tromey@adacore.com>
6014
6015         * macroexp.c (struct macro_buffer) <release>: Add
6016         ATTRIBUTE_UNUSED_RESULT.
6017
6018 2019-03-05  Tom Tromey  <tromey@adacore.com>
6019
6020         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6021         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6022         ATTRIBUTE_UNUSED_RESULT.
6023
6024 2019-03-05  Tom Tromey  <tromey@adacore.com>
6025
6026         * common/scoped_fd.h (class scoped_fd) <release>: Add
6027         ATTRIBUTE_UNUSED_RESULT.
6028
6029 2019-03-05  Tom Tromey  <tromey@adacore.com>
6030
6031         * parser-defs.h (struct parser_state) <release>: Add
6032         ATTRIBUTE_UNUSED_RESULT.
6033
6034 2019-03-05  Tom Tromey  <tromey@adacore.com>
6035
6036         * utils.h (class gdb_argv) <release>: Add
6037         ATTRIBUTE_UNUSED_RESULT.
6038         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6039
6040 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6041
6042         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6043         for-loop range, to avoid compiler warnings.
6044
6045         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6046         avoid compiler warnings about unused variables.
6047
6048         * NEWS: Mention end of support for native debugging on MS-Windows
6049         before XP.
6050
6051         PR gdb/24292
6052         * common/netstuff.c:
6053         * gdbserver/gdbreplay.c
6054         * gdbserver/remote-utils.c:
6055         * ser-tcp.c:
6056         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6057         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6058         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6059         'getaddrinfo' and 'freeaddrinfo' were not available before
6060         Windows XP, and mingw.org's MinGW headers by default define
6061         _WIN32_WINNT to 0x500.
6062
6063 2019-03-01  Gary Benson <gbenson@redhat.com>
6064
6065         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6066
6067 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6068             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6069
6070         PR gdb/8527
6071         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6072         set_sigint_trap, clear_sigint_trap.
6073
6074 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6075
6076         * target.c (target_detach): Clear the regcache and the
6077         frame cache.
6078
6079 2019-02-27  Pedro Alves  <palves@redhat.com>
6080
6081         * utils.c (set_screen_size): When we cap the height/width sizes,
6082         tweak the corresponding command variable to show "unlimited":
6083
6084 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6085             Pedro Alves  <palves@redhat.com>
6086
6087         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6088         before calling rl_set_screen_size.
6089
6090 2019-02-27  Tom Tromey  <tromey@adacore.com>
6091
6092         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6093         define.
6094         * python/py-value.c: Remove Python 2.4 workaround.
6095         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6096         workaround.
6097         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6098         Python 2.4 workaround.
6099         * python/python-internal.h: Remove Python 2.4 comment.
6100         (Py_ssize_t): Don't define.
6101         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6102         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6103         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6104         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6105         * python/python.c (do_start_initialization): Remove Python 2.4
6106         workaround.
6107         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6108         (print_children): Remove Python 2.4 workaround.
6109         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6110         workaround.
6111         (CHARBUFFERPROC_NAME): Remove.
6112         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6113         Python 2.4 workaround.
6114
6115 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6116
6117         * NEWS: Note minimum Python version.
6118
6119 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6120
6121         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6122         code from these functions.  Remove corresponding ifdefs.  Use
6123         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6124         Remove gotos and target of gotos.
6125         (infpy_search_memory): Likewise.
6126
6127 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6128
6129         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6130         (hppa_gdbarch_init): Don't register deleted functions with
6131         gdbarch.
6132
6133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6134
6135         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6136         (h8300_unwind_sp): Delete.
6137         (h8300_dummy_id): Delete.
6138         (h8300_gdbarch_init): Don't register deleted functions with
6139         gdbarch.
6140
6141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6142
6143         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6144         (ft32_unwind_pc): Delete.
6145         (ft32_unwind_sp): Delete.
6146         (ft32_gdbarch_init): Don't register deleted functions with
6147         gdbarch.
6148
6149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6150
6151         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6152         (frv_unwind_pc): Delete.
6153         (frv_unwind_sp): Delete.
6154         (frv_gdbarch_init): Don't register deleted functions with
6155         gdbarch.
6156
6157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6158
6159         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6160         (riscv_unwind_pc): Delete.
6161         (riscv_unwind_sp): Delete.
6162         (riscv_gdbarch_init): Don't register deleted functions with
6163         gdbarch.
6164
6165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6166
6167         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6168         (csky_unwind_pc): Delete.
6169         (csky_unwind_sp): Delete.
6170         (csky_gdbarch_init): Don't register deleted functions with
6171         gdbarch.
6172
6173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6174
6175         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6176         (cris_unwind_pc): Delete.
6177         (cris_unwind_sp): Delete.
6178         (cris_gdbarch_init): Don't register deleted functions with
6179         gdbarch.
6180
6181 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6182
6183         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6184         (bfin_unwind_pc): Delete.
6185         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6186
6187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6188
6189         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6190         (arm_unwind_pc): Delete.
6191         (arm_unwind_sp): Delete.
6192         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6193
6194 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6195
6196         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6197         (arc_unwind_pc): Delete.
6198         (arc_unwind_sp): Delete.
6199         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6200
6201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6204         (alpha_unwind_pc): Delete.
6205         (alpha_gdbarch_init): Don't register deleted functions with
6206         gdbarch.
6207
6208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6209
6210         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6211         (aarch64_unwind_pc): Delete.
6212         (aarch64_unwind_sp): Delete.
6213         (aarch64_gdbarch_init): Don't register deleted functions with
6214         gdbarch.
6215
6216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6217
6218         * gdbtypes.c (type_align): Don't consider static members when
6219         computing structure alignment.
6220
6221 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6222
6223         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6224         return 0 for other types.
6225         * arch-utils.c (default_type_align): Always return 0.
6226         * gdbarch.h: Regenerate.
6227         * gdbarch.sh (type_align): Extend comment.
6228         * gdbtypes.c (type_align): Add additional comments, always call
6229         gdbarch_type_align before applying the default rules.
6230         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6231         generic code will then apply a suitable default.
6232         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6233         types, return 0 for other types.
6234
6235 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6236
6237         * NEWS: Create a new section for the next release branch.
6238         Rename the section of the current branch, now that it has
6239         been cut.
6240
6241 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6242
6243         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6244         * version.in: Bump version to 8.3.50.DATE-git.
6245
6246 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6247
6248         * aix-thread.c (ptid_cmp): Remove unused variable.
6249         (get_signaled_thread): Likewise.
6250         (store_regs_user_thread): Likewise.
6251         (store_regs_kernel_thread): Likewise.
6252         (fetch_regs_kernel_thread): Remove shadowed variable.
6253
6254 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6255
6256         * features/riscv/32bit-cpu.xml: Add register numbers.
6257         * features/riscv/32bit-fpu.c: Regenerate.
6258         * features/riscv/32bit-fpu.xml: Add register numbers.
6259         * features/riscv/64bit-cpu.xml: Add register numbers.
6260         * features/riscv/64bit-fpu.c: Regenerate.
6261         * features/riscv/64bit-fpu.xml: Add register numbers.
6262
6263 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6264
6265         * NEWS: Mention two argument form of gdb.Value constructor.
6266         * python/py-value.c (convert_buffer_and_type_to_value): New
6267         function.
6268         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6269         Add support for handling an optional second argument.  Call
6270         convert_buffer_and_type_to_value as appropriate.
6271         * python/python-internal.h (Py_buffer_deleter): New struct.
6272         (Py_buffer_up): New typedef.
6273
6274 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6275
6276         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6277         instead of releasing ownership.
6278
6279 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6280
6281         * dwarf2read.c (open_and_init_dwp_file): Call
6282         elf_numsections instead of bfd_count_sections to initialize
6283         dwp_file->num_sections.
6284
6285 2019-02-25  Tom Tromey  <tromey@adacore.com>
6286
6287         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6288
6289 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6290
6291         * gcore.in: Add '--readnever' option when invoking GDB.
6292
6293 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6294
6295         * MAINTAINERS: Update my email address.
6296
6297 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6298
6299         * build-id.c (build_id_to_debug_bfd_1): New function.
6300         (build_id_to_debug_bfd): Look for separate debug file in
6301         sysroot.
6302
6303 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6304
6305         * gdbarch.sh: Update the copyright year range that is placed into
6306         generated files.
6307
6308 2019-02-22  Keith Seitz  <keiths@redhat.com>
6309
6310         PR symtab/23853
6311         * linespec.c (create_sals_line_offset): Search for the default
6312         symtab's filename instead of its fullname.
6313
6314 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6315
6316         * NEWS: Update style defaults.
6317
6318 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6319
6320         * main.c (captured_main_1): Disable styling in batch mode.
6321
6322 2019-02-20  Tom Tromey  <tom@tromey.com>
6323
6324         * symtab.c (symtab_symbol_info): Fix typos.
6325
6326 2019-02-20  Tom Tromey  <tromey@adacore.com>
6327
6328         * findcmd.c (_initialize_mem_search): Use upper case for
6329         metasyntactic variables.
6330
6331 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6332
6333         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6334         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6335
6336 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6337
6338         * top.h (source_file_name): Change to std::string.
6339         * top.c (source_file_name): Likewise.
6340         (command_line_input): Adjust.
6341         * cli/cli-script.c (script_from_file): Adjust.
6342
6343 2019-02-19  Tom Tromey  <tromey@adacore.com>
6344
6345         * ravenscar-thread.c
6346         (ravenscar_thread_target::update_thread_list): Don't call
6347         ada_build_task_list.
6348         * ada-lang.h (ada_build_task_list): Don't declare.
6349         * ada-tasks.c (struct ada_tasks_inferior_data)
6350         <task_list_valid_p>: Now bool.
6351         (read_known_tasks, ada_task_list_changed)
6352         (ada_tasks_invalidate_inferior_data): Update.
6353         (read_known_tasks_array): Return bool.
6354         (read_known_tasks_list): Likewise.
6355         (read_known_tasks): Return void.
6356         (ada_build_task_list): Now static.
6357
6358 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6361         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6362
6363 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6364
6365         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6366         variant for ada_tasks_pspace_data_handle and
6367         ada_tasks_inferior_data_handle.
6368         (ada_tasks_pspace_data_cleanup): New function.
6369         (ada_tasks_inferior_data_cleanup): New function.
6370
6371 2019-02-17  Tom Tromey  <tom@tromey.com>
6372
6373         * macrotab.h (macro_source_fullname): Return a std::string.
6374         * macrotab.c (macro_include, check_for_redefinition)
6375         (macro_undef, macro_lookup_definition, foreach_macro)
6376         (foreach_macro_in_scope): Update.
6377         (macro_source_fullname): Return a std::string.
6378         * macrocmd.c (show_pp_source_pos): Update.
6379
6380 2019-02-17  Tom Tromey  <tom@tromey.com>
6381
6382         * macrocmd.c (show_pp_source_pos): Style the file names.
6383
6384 2019-02-17  Tom Tromey  <tom@tromey.com>
6385
6386         PR tui/24197:
6387         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6388
6389 2019-02-17  Tom Tromey  <tom@tromey.com>
6390
6391         * ada-lang.c (user_select_syms): Use filtered printing.
6392         * utils.c (wrap_style): New global.
6393         (desired_style): Remove.
6394         (emit_style_escape): Add stream parameter.
6395         (set_output_style, reset_terminal_style, prompt_for_continue):
6396         Update.
6397         (flush_wrap_buffer): Only flush gdb_stdout.
6398         (wrap_here): Set wrap_style.
6399         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6400         treat escape sequences as a character.  Change when wrap buffer is
6401         flushed.
6402         (fputs_styled): Do not set the output style when the default is
6403         requested.
6404         * ui-style.h (struct ui_file_style) <is_default>: New method.
6405         * source.c (print_source_lines_base): Emit escape sequences in one
6406         piece.
6407
6408 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6409
6410         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6411         integers and enumeration types.
6412
6413 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6414
6415         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6416         instead of lookup_symbol_in_language
6417         (do_exact_match): New function.
6418         (ada_get_symbol_name_matcher): Return do_exact_match when
6419         doing a verbatim match.
6420
6421 2019-02-15  Tom Tromey  <tromey@adacore.com>
6422
6423         * ravenscar-thread.c (ravenscar_thread_target::resume)
6424         (ravenscar_thread_target::wait): Special case wildcard requests.
6425
6426 2019-02-15  Tom Tromey  <tromey@adacore.com>
6427
6428         * ravenscar-thread.c (base_ptid): Remove.
6429         (struct ravenscar_thread_target) <close>: New method.
6430         <m_base_ptid>: New member.
6431         <update_inferior_ptid, active_task, task_is_currently_active,
6432         runtime_initialized>: Declare methods.
6433         <ravenscar_thread_target>: Add constructor.
6434         (ravenscar_thread_target::task_is_currently_active)
6435         (ravenscar_thread_target::update_inferior_ptid)
6436         (ravenscar_runtime_initialized): Rename.  Now methods.
6437         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6438         (ravenscar_thread_target::update_thread_list): Update.
6439         (ravenscar_thread_target::active_task): Now method.
6440         (ravenscar_thread_target::store_registers)
6441         (ravenscar_thread_target::prepare_to_store)
6442         (ravenscar_thread_target::prepare_to_store)
6443         (ravenscar_thread_target::mourn_inferior): Update.
6444         (ravenscar_inferior_created): Use "new" to create target.
6445         (ravenscar_thread_target::get_ada_task_ptid): Update.
6446         (_initialize_ravenscar): Don't initialize base_ptid.
6447         (ravenscar_ops): Remove global.
6448
6449 2019-02-15  Tom Tromey  <tromey@adacore.com>
6450
6451         * target.h (push_target): Declare new overload.
6452         * target.c (push_target): New overload, taking an rvalue reference.
6453         * remote.c (remote_target::open_1): Use push_target overload.
6454         * corelow.c (core_target_open): Use push_target overload.
6455
6456 2019-02-15  Tom Tromey  <tromey@adacore.com>
6457
6458         * ravenscar-thread.c (is_ravenscar_task)
6459         (ravenscar_task_is_currently_active): Return bool.
6460         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6461         (_initialize_ravenscar): Remove "(void)".
6462         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6463         Return bool.
6464
6465 2019-02-15  Tom Tromey  <tromey@adacore.com>
6466
6467         * ravenscar-thread.c (ravenscar_runtime_initializer)
6468         (has_ravenscar_runtime, get_running_thread_id)
6469         (ravenscar_thread_target::resume): Fix indentation.
6470
6471 2019-02-15  Tom Tromey  <tromey@adacore.com>
6472
6473         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6474         from ravenscar_arch_ops.
6475         (sparc_ravenscar_ops::fetch_registers)
6476         (sparc_ravenscar_ops::store_registers): Now methods.
6477         (sparc_ravenscar_prepare_to_store): Remove.
6478         (sparc_ravenscar_ops): Redefine.
6479         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6480         methods and destructor.  Remove members.
6481         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6482         (ravenscar_thread_target::store_registers)
6483         (ravenscar_thread_target::prepare_to_store): Update.
6484         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6485         Remove.
6486         (struct ppc_ravenscar_powerpc_ops): Derive from
6487         ravenscar_arch_ops.
6488         (ppc_ravenscar_powerpc_ops::fetch_registers)
6489         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6490         (ppc_ravenscar_powerpc_ops): Redefine.
6491         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6492         (ppc_ravenscar_e500_ops::fetch_registers)
6493         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6494         (ppc_ravenscar_e500_ops): Redefine.
6495         * aarch64-ravenscar-thread.c
6496         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6497         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6498         (aarch64_ravenscar_fetch_registers)
6499         (aarch64_ravenscar_store_registers): Now methods.
6500         (aarch64_ravenscar_ops): Redefine.
6501
6502 2019-02-15  Tom Tromey  <tromey@adacore.com>
6503
6504         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6505         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6506         (ravenscar_thread_target::stopped_by_watchpoint)
6507         (ravenscar_thread_target::stopped_data_address)
6508         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6509
6510 2019-02-15  Tom Tromey  <tromey@adacore.com>
6511
6512         * ravenscar-thread.c: Fix some typos.
6513
6514 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6515             Tom Tromey  <tromey@adacore.com>
6516
6517         * ada-lang.c (ada_exception_sal): Change addr_string to a
6518         std::string.
6519         (create_ada_exception_catchpoint): Update.
6520
6521 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6522             Tom Tromey  <tromey@adacore.com>
6523
6524         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6525         (bp_location_ops): Remove.
6526         (base_breakpoint_allocate_location): Update.
6527         (free_bp_location): Update.
6528         * ada-lang.c (class ada_catchpoint_location)
6529         <ada_catchpoint_location>: Remove ops parameter.
6530         (ada_catchpoint_location_dtor): Remove.
6531         (ada_catchpoint_location_ops): Remove.
6532         (allocate_location_exception): Update.
6533         * breakpoint.h (struct bp_location_ops): Remove.
6534         (class bp_location) <bp_location>: Remove bp_location_ops
6535         parameter.
6536         <~bp_location>: Add destructor.
6537         <ops>: Remove.
6538
6539 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6540             Pedro Alves  <palves@redhat.com>
6541
6542         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6543         'PATH_MAX'.
6544
6545 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6546             Samuel Thibault  <samuel.thibault@gnu.org>
6547             Thomas Schwinge  <thomas@codesourcery.com>
6548
6549         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6550         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6551
6552 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6553
6554         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6555         (check_empty): Use "const char *".
6556
6557         * gnu-nat.c (gnu_nat_target::detach): Instead of
6558         'detach_inferior (pid)' call
6559         'detach_inferior (find_inferior_pid (pid))'.
6560
6561         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6562         'nat/fork-inferior.o'.
6563         * gnu-nat.c: #include "nat/fork-inferior.h".
6564
6565         * gnu-nat.c (gnu_nat_target::detach): Instead of
6566         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6567         * gnu-nat.h: #include "inf-child.h".
6568         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6569         'i386_gnu_nat_target::fetch_registers'.
6570         (gnu_store_registers): Rename/move to
6571         'i386_gnu_nat_target::store_registers'.
6572
6573         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6574         * gnu-nat.h (mach_thread_info): New function.
6575         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6576
6577         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6578
6579 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6580
6581         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6582
6583 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6584
6585         * windows-nat.c (windows_add_thread): Add new parameter
6586         "main_thread_p" with default value set to false.  Update
6587         function documentation as well as all callers.
6588         (windows_delete_thread): Likewise.
6589         (fake_create_process): Update call to windows_add_thread.
6590         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6591         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6592         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6593         call to windows_delete_thread.
6594
6595 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6596
6597         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6598
6599 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6600
6601         * symfile.c (find_separate_debug_file): Use canonical path of
6602         sysroot with child_path instead of gdb_sysroot if it is valid.
6603
6604 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6605
6606         * symfile.c (find_separate_debug_file): Use child_path to
6607         determine if an object file is under a sysroot.
6608
6609 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6610
6611         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6612         unittests/child-path-selftests.c.
6613         * common/pathstuff.c (child_path): New function.
6614         * common/pathstuff.h (child_path): New prototype.
6615         * unittests/child-path-selftests.c: New file.
6616
6617 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6618
6619         * symfile.c (find_separate_debug_file): Look for separate debug
6620         files in debug directories under the sysroot.
6621
6622 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6623
6624         * symtab.h (struct minimal_symbol data_p): New const method.
6625         (struct minimal_symbol text_p): Likewise.
6626         * symtab.c (output_source_filename): Use file name style
6627         to print file name.
6628         (print_symbol_info): Likewise.
6629         (print_msymbol_info): Use address style to print addresses.
6630         Use function name style to print executable text symbols.
6631         (expand_symtab_containing_pc): Use data_p.
6632         (find_pc_sect_compunit_symtab): Likewise.
6633
6634 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6635
6636         * breakpoint.c (describe_other_breakpoints): Use address style
6637         to print addresses.
6638         (say_where): Likewise.
6639
6640 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6641
6642         * ada-typeprint.c (print_func_type): Print function name
6643         style to print function name.
6644         * c-typeprint.c (c_print_type_1): Likewise.
6645
6646 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6647
6648         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6649         for execve.
6650
6651 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6652
6653         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6654         type_stack.
6655
6656 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6657
6658         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6659         TYPE_CODE_REF types.
6660
6661 2019-02-08  Jim Wilson  <jimw@sifive.com>
6662
6663         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6664         (riscv_linux_fregset): New.
6665         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6666
6667 2019-02-07  Tom Tromey  <tom@tromey.com>
6668
6669         * thread.c (thread_cancel_execution_command): Update.
6670         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6671         methods.
6672         (struct thread_fsm_ops): Remove.
6673         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6674         (thread_fsm_should_stop, thread_fsm_return_value)
6675         (thread_fsm_set_finished, thread_fsm_finished_p)
6676         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6677         Don't declare.
6678         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6679         * infrun.c (clear_proceed_status_thread)
6680         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6681         (print_stop_event): Update.
6682         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6683         Add constructor.
6684         (step_command_fsm_ops): Remove.
6685         (new_step_command_fsm): Remove.
6686         (step_1): Update.
6687         (step_command_fsm::should_stop): Rename from
6688         step_command_fsm_should_stop.
6689         (step_command_fsm::clean_up): Rename from
6690         step_command_fsm_clean_up.
6691         (step_command_fsm::do_async_reply_reason): Rename from
6692         step_command_fsm_async_reply_reason.
6693         (struct until_next_fsm): Inherit from thread_fsm.  Add
6694         constructor.
6695         (until_next_fsm_ops): Remove.
6696         (new_until_next_fsm): Remove.
6697         (until_next_fsm::should_stop): Rename from
6698         until_next_fsm_should_stop.
6699         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6700         (until_next_fsm::do_async_reply_reason): Rename from
6701         until_next_fsm_async_reply_reason.
6702         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6703         constructor.  Change type of breakpoint.
6704         (finish_command_fsm_ops): Remove.
6705         (new_finish_command_fsm): Remove.
6706         (finish_command_fsm::should_stop): Rename from
6707         finish_command_fsm_should_stop.
6708         (finish_command_fsm::clean_up): Rename from
6709         finish_command_fsm_clean_up.
6710         (finish_command_fsm::return_value): Rename from
6711         finish_command_fsm_return_value.
6712         (finish_command_fsm::do_async_reply_reason): Rename from
6713         finish_command_fsm_async_reply_reason.
6714         (finish_command): Update.
6715         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6716         Add constructor.
6717         (call_thread_fsm_ops): Remove.
6718         (call_thread_fsm::call_thread_fsm): Rename from
6719         new_call_thread_fsm.
6720         (call_thread_fsm::should_stop): Rename from
6721         call_thread_fsm_should_stop.
6722         (call_thread_fsm::should_notify_stop): Rename from
6723         call_thread_fsm_should_notify_stop.
6724         (run_inferior_call, call_function_by_hand_dummy): Update.
6725         * cli/cli-interp.c (should_print_stop_to_console): Update.
6726         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6727         Add constructor.  Change type of location_breakpoint,
6728         caller_breakpoint.
6729         (until_break_fsm_ops): Remove.
6730         (new_until_break_fsm): Remove.
6731         (until_break_fsm::should_stop): Rename from
6732         until_break_fsm_should_stop.
6733         (until_break_fsm::clean_up): Rename from
6734         until_break_fsm_clean_up.
6735         (until_break_fsm::do_async_reply_reason): Rename from
6736         until_break_fsm_async_reply_reason.
6737         (until_break_command): Update.
6738         * thread-fsm.c: Remove.
6739         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6740
6741 2019-02-07  Tom Tromey  <tom@tromey.com>
6742
6743         * yy-remap.h: Add include guard.
6744         * xtensa-tdep.h: Add include guard.
6745         * xcoffread.h: Rename include guard.
6746         * varobj-iter.h: Add include guard.
6747         * tui/tui.h: Rename include guard.
6748         * tui/tui-winsource.h: Rename include guard.
6749         * tui/tui-wingeneral.h: Rename include guard.
6750         * tui/tui-windata.h: Rename include guard.
6751         * tui/tui-win.h: Rename include guard.
6752         * tui/tui-stack.h: Rename include guard.
6753         * tui/tui-source.h: Rename include guard.
6754         * tui/tui-regs.h: Rename include guard.
6755         * tui/tui-out.h: Rename include guard.
6756         * tui/tui-layout.h: Rename include guard.
6757         * tui/tui-io.h: Rename include guard.
6758         * tui/tui-hooks.h: Rename include guard.
6759         * tui/tui-file.h: Rename include guard.
6760         * tui/tui-disasm.h: Rename include guard.
6761         * tui/tui-data.h: Rename include guard.
6762         * tui/tui-command.h: Rename include guard.
6763         * tic6x-tdep.h: Add include guard.
6764         * target/waitstatus.h: Rename include guard.
6765         * target/wait.h: Rename include guard.
6766         * target/target.h: Rename include guard.
6767         * target/resume.h: Rename include guard.
6768         * target-float.h: Rename include guard.
6769         * stabsread.h: Add include guard.
6770         * rs6000-tdep.h: Add include guard.
6771         * riscv-fbsd-tdep.h: Add include guard.
6772         * regformats/regdef.h: Rename include guard.
6773         * record.h: Rename include guard.
6774         * python/python.h: Rename include guard.
6775         * python/python-internal.h: Rename include guard.
6776         * python/py-stopevent.h: Rename include guard.
6777         * python/py-ref.h: Rename include guard.
6778         * python/py-record.h: Rename include guard.
6779         * python/py-record-full.h: Rename include guard.
6780         * python/py-record-btrace.h: Rename include guard.
6781         * python/py-instruction.h: Rename include guard.
6782         * python/py-events.h: Rename include guard.
6783         * python/py-event.h: Rename include guard.
6784         * procfs.h: Add include guard.
6785         * proc-utils.h: Add include guard.
6786         * p-lang.h: Add include guard.
6787         * or1k-tdep.h: Rename include guard.
6788         * observable.h: Rename include guard.
6789         * nto-tdep.h: Rename include guard.
6790         * nat/x86-linux.h: Rename include guard.
6791         * nat/x86-linux-dregs.h: Rename include guard.
6792         * nat/x86-gcc-cpuid.h: Add include guard.
6793         * nat/x86-dregs.h: Rename include guard.
6794         * nat/x86-cpuid.h: Rename include guard.
6795         * nat/ppc-linux.h: Rename include guard.
6796         * nat/mips-linux-watch.h: Rename include guard.
6797         * nat/linux-waitpid.h: Rename include guard.
6798         * nat/linux-ptrace.h: Rename include guard.
6799         * nat/linux-procfs.h: Rename include guard.
6800         * nat/linux-osdata.h: Rename include guard.
6801         * nat/linux-nat.h: Rename include guard.
6802         * nat/linux-namespaces.h: Rename include guard.
6803         * nat/linux-btrace.h: Rename include guard.
6804         * nat/glibc_thread_db.h: Rename include guard.
6805         * nat/gdb_thread_db.h: Rename include guard.
6806         * nat/gdb_ptrace.h: Rename include guard.
6807         * nat/fork-inferior.h: Rename include guard.
6808         * nat/amd64-linux-siginfo.h: Rename include guard.
6809         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6810         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6811         * nat/aarch64-linux.h: Rename include guard.
6812         * nat/aarch64-linux-hw-point.h: Rename include guard.
6813         * mn10300-tdep.h: Add include guard.
6814         * mips-linux-tdep.h: Add include guard.
6815         * mi/mi-parse.h: Rename include guard.
6816         * mi/mi-out.h: Rename include guard.
6817         * mi/mi-main.h: Rename include guard.
6818         * mi/mi-interp.h: Rename include guard.
6819         * mi/mi-getopt.h: Rename include guard.
6820         * mi/mi-console.h: Rename include guard.
6821         * mi/mi-common.h: Rename include guard.
6822         * mi/mi-cmds.h: Rename include guard.
6823         * mi/mi-cmd-break.h: Rename include guard.
6824         * m2-lang.h: Add include guard.
6825         * location.h: Rename include guard.
6826         * linux-record.h: Rename include guard.
6827         * linux-nat.h: Add include guard.
6828         * linux-fork.h: Add include guard.
6829         * i386-darwin-tdep.h: Rename include guard.
6830         * hppa-linux-offsets.h: Add include guard.
6831         * guile/guile.h: Rename include guard.
6832         * guile/guile-internal.h: Rename include guard.
6833         * gnu-nat.h: Rename include guard.
6834         * gdb-stabs.h: Rename include guard.
6835         * frv-tdep.h: Add include guard.
6836         * f-lang.h: Add include guard.
6837         * event-loop.h: Add include guard.
6838         * darwin-nat.h: Rename include guard.
6839         * cp-abi.h: Rename include guard.
6840         * config/sparc/nm-sol2.h: Rename include guard.
6841         * config/nm-nto.h: Rename include guard.
6842         * config/nm-linux.h: Add include guard.
6843         * config/i386/nm-i386gnu.h: Rename include guard.
6844         * config/djgpp/nl_types.h: Rename include guard.
6845         * config/djgpp/langinfo.h: Rename include guard.
6846         * compile/gcc-cp-plugin.h: Add include guard.
6847         * compile/gcc-c-plugin.h: Add include guard.
6848         * compile/compile.h: Rename include guard.
6849         * compile/compile-object-run.h: Rename include guard.
6850         * compile/compile-object-load.h: Rename include guard.
6851         * compile/compile-internal.h: Rename include guard.
6852         * compile/compile-cplus.h: Rename include guard.
6853         * compile/compile-c.h: Rename include guard.
6854         * common/xml-utils.h: Rename include guard.
6855         * common/x86-xstate.h: Rename include guard.
6856         * common/version.h: Rename include guard.
6857         * common/vec.h: Rename include guard.
6858         * common/tdesc.h: Rename include guard.
6859         * common/selftest.h: Rename include guard.
6860         * common/scoped_restore.h: Rename include guard.
6861         * common/scoped_mmap.h: Rename include guard.
6862         * common/scoped_fd.h: Rename include guard.
6863         * common/safe-iterator.h: Rename include guard.
6864         * common/run-time-clock.h: Rename include guard.
6865         * common/refcounted-object.h: Rename include guard.
6866         * common/queue.h: Rename include guard.
6867         * common/ptid.h: Rename include guard.
6868         * common/print-utils.h: Rename include guard.
6869         * common/preprocessor.h: Rename include guard.
6870         * common/pathstuff.h: Rename include guard.
6871         * common/observable.h: Rename include guard.
6872         * common/netstuff.h: Rename include guard.
6873         * common/job-control.h: Rename include guard.
6874         * common/host-defs.h: Rename include guard.
6875         * common/gdb_wait.h: Rename include guard.
6876         * common/gdb_vecs.h: Rename include guard.
6877         * common/gdb_unlinker.h: Rename include guard.
6878         * common/gdb_unique_ptr.h: Rename include guard.
6879         * common/gdb_tilde_expand.h: Rename include guard.
6880         * common/gdb_sys_time.h: Rename include guard.
6881         * common/gdb_string_view.h: Rename include guard.
6882         * common/gdb_splay_tree.h: Rename include guard.
6883         * common/gdb_setjmp.h: Rename include guard.
6884         * common/gdb_ref_ptr.h: Rename include guard.
6885         * common/gdb_optional.h: Rename include guard.
6886         * common/gdb_locale.h: Rename include guard.
6887         * common/gdb_assert.h: Rename include guard.
6888         * common/filtered-iterator.h: Rename include guard.
6889         * common/filestuff.h: Rename include guard.
6890         * common/fileio.h: Rename include guard.
6891         * common/environ.h: Rename include guard.
6892         * common/common-utils.h: Rename include guard.
6893         * common/common-types.h: Rename include guard.
6894         * common/common-regcache.h: Rename include guard.
6895         * common/common-inferior.h: Rename include guard.
6896         * common/common-gdbthread.h: Rename include guard.
6897         * common/common-exceptions.h: Rename include guard.
6898         * common/common-defs.h: Rename include guard.
6899         * common/common-debug.h: Rename include guard.
6900         * common/cleanups.h: Rename include guard.
6901         * common/buffer.h: Rename include guard.
6902         * common/btrace-common.h: Rename include guard.
6903         * common/break-common.h: Rename include guard.
6904         * cli/cli-utils.h: Rename include guard.
6905         * cli/cli-style.h: Rename include guard.
6906         * cli/cli-setshow.h: Rename include guard.
6907         * cli/cli-script.h: Rename include guard.
6908         * cli/cli-interp.h: Rename include guard.
6909         * cli/cli-decode.h: Rename include guard.
6910         * cli/cli-cmds.h: Rename include guard.
6911         * charset-list.h: Add include guard.
6912         * buildsym-legacy.h: Rename include guard.
6913         * bfin-tdep.h: Add include guard.
6914         * ax.h: Rename include guard.
6915         * arm-linux-tdep.h: Add include guard.
6916         * arm-fbsd-tdep.h: Add include guard.
6917         * arch/xtensa.h: Rename include guard.
6918         * arch/tic6x.h: Add include guard.
6919         * arch/i386.h: Add include guard.
6920         * arch/arm.h: Rename include guard.
6921         * arch/arm-linux.h: Rename include guard.
6922         * arch/arm-get-next-pcs.h: Rename include guard.
6923         * arch/amd64.h: Add include guard.
6924         * arch/aarch64-insn.h: Rename include guard.
6925         * arch-utils.h: Rename include guard.
6926         * annotate.h: Add include guard.
6927         * amd64-darwin-tdep.h: Rename include guard.
6928         * aarch64-linux-tdep.h: Add include guard.
6929         * aarch64-fbsd-tdep.h: Add include guard.
6930         * aarch32-linux-nat.h: Add include guard.
6931
6932 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6933
6934         * macrotab.c (macro_define_internal): New function that
6935         factorizes macro_define_object_internal and macro_define_function
6936         code.
6937         (macro_define_object_internal): Use macro_define_internal.
6938         (macro_define_function): Likewise.
6939
6940 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6941
6942         * macrocmd.c (extract_identifier): Return
6943         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6944         callers.
6945
6946 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6947
6948         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6949
6950 2019-02-05  Tom Tromey  <tom@tromey.com>
6951
6952         * target.c (target_stack::unpush): Move assertion earlier.
6953
6954 2019-01-30  Tom Tromey  <tom@tromey.com>
6955
6956         PR python/23615:
6957         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6958         (gdbpy_parse_and_eval): Likewise.
6959         * python/python-internal.h (gdbpy_allow_threads): New class.
6960
6961 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6962
6963         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6964         (aarch64_fbsd_fpregmap): Move earlier.
6965         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6966         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6967         instead of individual calls to trad_frame_set_reg_addr.
6968         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6969         earlier.
6970         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6971         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6972         instead of individual calls to trad_frame_set_reg_addr.
6973
6974 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6975
6976         * CONTRIBUTE: Replace contribution list with wiki link.
6977
6978 2019-01-25  Tom Tromey  <tom@tromey.com>
6979
6980         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6981
6982 2019-01-25  Tom Tromey  <tom@tromey.com>
6983
6984         * xtensa-linux-nat.c: Fix common/ includes.
6985         * xml-support.h: Fix common/ includes.
6986         * xml-support.c: Fix common/ includes.
6987         * x86-linux-nat.c: Fix common/ includes.
6988         * windows-nat.c: Fix common/ includes.
6989         * varobj.h: Fix common/ includes.
6990         * varobj.c: Fix common/ includes.
6991         * value.c: Fix common/ includes.
6992         * valops.c: Fix common/ includes.
6993         * utils.c: Fix common/ includes.
6994         * unittests/xml-utils-selftests.c: Fix common/ includes.
6995         * unittests/utils-selftests.c: Fix common/ includes.
6996         * unittests/unpack-selftests.c: Fix common/ includes.
6997         * unittests/tracepoint-selftests.c: Fix common/ includes.
6998         * unittests/style-selftests.c: Fix common/ includes.
6999         * unittests/string_view-selftests.c: Fix common/ includes.
7000         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7001         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7002         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7003         * unittests/rsp-low-selftests.c: Fix common/ includes.
7004         * unittests/parse-connection-spec-selftests.c: Fix common/
7005         includes.
7006         * unittests/optional-selftests.c: Fix common/ includes.
7007         * unittests/offset-type-selftests.c: Fix common/ includes.
7008         * unittests/observable-selftests.c: Fix common/ includes.
7009         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7010         * unittests/memrange-selftests.c: Fix common/ includes.
7011         * unittests/memory-map-selftests.c: Fix common/ includes.
7012         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7013         * unittests/function-view-selftests.c: Fix common/ includes.
7014         * unittests/environ-selftests.c: Fix common/ includes.
7015         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7016         * unittests/common-utils-selftests.c: Fix common/ includes.
7017         * unittests/cli-utils-selftests.c: Fix common/ includes.
7018         * unittests/array-view-selftests.c: Fix common/ includes.
7019         * ui-file.c: Fix common/ includes.
7020         * tui/tui-io.c: Fix common/ includes.
7021         * tracepoint.h: Fix common/ includes.
7022         * tracepoint.c: Fix common/ includes.
7023         * tracefile-tfile.c: Fix common/ includes.
7024         * top.h: Fix common/ includes.
7025         * top.c: Fix common/ includes.
7026         * thread.c: Fix common/ includes.
7027         * target/waitstatus.h: Fix common/ includes.
7028         * target/waitstatus.c: Fix common/ includes.
7029         * target.h: Fix common/ includes.
7030         * target.c: Fix common/ includes.
7031         * target-memory.c: Fix common/ includes.
7032         * target-descriptions.c: Fix common/ includes.
7033         * symtab.h: Fix common/ includes.
7034         * symfile.c: Fix common/ includes.
7035         * stap-probe.c: Fix common/ includes.
7036         * spu-linux-nat.c: Fix common/ includes.
7037         * sparc-nat.c: Fix common/ includes.
7038         * source.c: Fix common/ includes.
7039         * solib.c: Fix common/ includes.
7040         * solib-target.c: Fix common/ includes.
7041         * ser-unix.c: Fix common/ includes.
7042         * ser-tcp.c: Fix common/ includes.
7043         * ser-pipe.c: Fix common/ includes.
7044         * ser-base.c: Fix common/ includes.
7045         * selftest-arch.c: Fix common/ includes.
7046         * s12z-tdep.c: Fix common/ includes.
7047         * rust-exp.y: Fix common/ includes.
7048         * rs6000-aix-tdep.c: Fix common/ includes.
7049         * riscv-tdep.c: Fix common/ includes.
7050         * remote.c: Fix common/ includes.
7051         * remote-notif.h: Fix common/ includes.
7052         * remote-fileio.h: Fix common/ includes.
7053         * remote-fileio.c: Fix common/ includes.
7054         * regcache.h: Fix common/ includes.
7055         * regcache.c: Fix common/ includes.
7056         * record-btrace.c: Fix common/ includes.
7057         * python/python.c: Fix common/ includes.
7058         * python/py-type.c: Fix common/ includes.
7059         * python/py-inferior.c: Fix common/ includes.
7060         * progspace.h: Fix common/ includes.
7061         * producer.c: Fix common/ includes.
7062         * procfs.c: Fix common/ includes.
7063         * proc-api.c: Fix common/ includes.
7064         * printcmd.c: Fix common/ includes.
7065         * ppc-linux-nat.c: Fix common/ includes.
7066         * parser-defs.h: Fix common/ includes.
7067         * osdata.c: Fix common/ includes.
7068         * obsd-nat.c: Fix common/ includes.
7069         * nat/x86-linux.c: Fix common/ includes.
7070         * nat/x86-linux-dregs.c: Fix common/ includes.
7071         * nat/x86-dregs.h: Fix common/ includes.
7072         * nat/x86-dregs.c: Fix common/ includes.
7073         * nat/ppc-linux.c: Fix common/ includes.
7074         * nat/mips-linux-watch.h: Fix common/ includes.
7075         * nat/mips-linux-watch.c: Fix common/ includes.
7076         * nat/linux-waitpid.c: Fix common/ includes.
7077         * nat/linux-ptrace.h: Fix common/ includes.
7078         * nat/linux-ptrace.c: Fix common/ includes.
7079         * nat/linux-procfs.c: Fix common/ includes.
7080         * nat/linux-personality.c: Fix common/ includes.
7081         * nat/linux-osdata.c: Fix common/ includes.
7082         * nat/linux-namespaces.c: Fix common/ includes.
7083         * nat/linux-btrace.h: Fix common/ includes.
7084         * nat/linux-btrace.c: Fix common/ includes.
7085         * nat/fork-inferior.c: Fix common/ includes.
7086         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7087         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7088         * nat/aarch64-linux.c: Fix common/ includes.
7089         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7090         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7091         * namespace.h: Fix common/ includes.
7092         * mips-linux-tdep.c: Fix common/ includes.
7093         * minsyms.c: Fix common/ includes.
7094         * mi/mi-parse.h: Fix common/ includes.
7095         * mi/mi-main.c: Fix common/ includes.
7096         * mi/mi-cmd-env.c: Fix common/ includes.
7097         * memrange.h: Fix common/ includes.
7098         * memattr.c: Fix common/ includes.
7099         * maint.h: Fix common/ includes.
7100         * maint.c: Fix common/ includes.
7101         * main.c: Fix common/ includes.
7102         * machoread.c: Fix common/ includes.
7103         * location.c: Fix common/ includes.
7104         * linux-thread-db.c: Fix common/ includes.
7105         * linux-nat.c: Fix common/ includes.
7106         * linux-fork.c: Fix common/ includes.
7107         * inline-frame.c: Fix common/ includes.
7108         * infrun.c: Fix common/ includes.
7109         * inflow.c: Fix common/ includes.
7110         * inferior.h: Fix common/ includes.
7111         * inferior.c: Fix common/ includes.
7112         * infcmd.c: Fix common/ includes.
7113         * inf-ptrace.c: Fix common/ includes.
7114         * inf-child.c: Fix common/ includes.
7115         * ia64-linux-nat.c: Fix common/ includes.
7116         * i387-tdep.c: Fix common/ includes.
7117         * i386-tdep.c: Fix common/ includes.
7118         * i386-linux-tdep.c: Fix common/ includes.
7119         * i386-linux-nat.c: Fix common/ includes.
7120         * i386-go32-tdep.c: Fix common/ includes.
7121         * i386-fbsd-tdep.c: Fix common/ includes.
7122         * i386-fbsd-nat.c: Fix common/ includes.
7123         * guile/scm-type.c: Fix common/ includes.
7124         * guile/guile.c: Fix common/ includes.
7125         * go32-nat.c: Fix common/ includes.
7126         * gnu-nat.c: Fix common/ includes.
7127         * gdbthread.h: Fix common/ includes.
7128         * gdbarch-selftests.c: Fix common/ includes.
7129         * gdb_usleep.c: Fix common/ includes.
7130         * gdb_select.h: Fix common/ includes.
7131         * gdb_bfd.c: Fix common/ includes.
7132         * gcore.c: Fix common/ includes.
7133         * fork-child.c: Fix common/ includes.
7134         * findvar.c: Fix common/ includes.
7135         * fbsd-nat.c: Fix common/ includes.
7136         * event-top.c: Fix common/ includes.
7137         * event-loop.c: Fix common/ includes.
7138         * dwarf2read.c: Fix common/ includes.
7139         * dwarf2loc.c: Fix common/ includes.
7140         * dwarf2-frame.c: Fix common/ includes.
7141         * dwarf-index-cache.c: Fix common/ includes.
7142         * dtrace-probe.c: Fix common/ includes.
7143         * disasm-selftests.c: Fix common/ includes.
7144         * defs.h: Fix common/ includes.
7145         * csky-tdep.c: Fix common/ includes.
7146         * cp-valprint.c: Fix common/ includes.
7147         * cp-support.h: Fix common/ includes.
7148         * cp-support.c: Fix common/ includes.
7149         * corelow.c: Fix common/ includes.
7150         * completer.h: Fix common/ includes.
7151         * completer.c: Fix common/ includes.
7152         * compile/compile.c: Fix common/ includes.
7153         * compile/compile-loc2c.c: Fix common/ includes.
7154         * compile/compile-cplus-types.c: Fix common/ includes.
7155         * compile/compile-cplus-symbols.c: Fix common/ includes.
7156         * command.h: Fix common/ includes.
7157         * cli/cli-dump.c: Fix common/ includes.
7158         * cli/cli-cmds.c: Fix common/ includes.
7159         * charset.c: Fix common/ includes.
7160         * build-id.c: Fix common/ includes.
7161         * btrace.h: Fix common/ includes.
7162         * btrace.c: Fix common/ includes.
7163         * breakpoint.h: Fix common/ includes.
7164         * breakpoint.c: Fix common/ includes.
7165         * ax.h:
7166         (enum agent_op): Fix common/ includes.
7167         * ax-general.c (struct aop_map): Fix common/ includes.
7168         * ax-gdb.c: Fix common/ includes.
7169         * auxv.c: Fix common/ includes.
7170         * auto-load.c: Fix common/ includes.
7171         * arm-tdep.c: Fix common/ includes.
7172         * arch/riscv.c: Fix common/ includes.
7173         * arch/ppc-linux-common.c: Fix common/ includes.
7174         * arch/i386.c: Fix common/ includes.
7175         * arch/arm.c: Fix common/ includes.
7176         * arch/arm-linux.c: Fix common/ includes.
7177         * arch/arm-get-next-pcs.c: Fix common/ includes.
7178         * arch/amd64.c: Fix common/ includes.
7179         * arch/aarch64.c: Fix common/ includes.
7180         * arch/aarch64-insn.c: Fix common/ includes.
7181         * arch-utils.c: Fix common/ includes.
7182         * amd64-windows-tdep.c: Fix common/ includes.
7183         * amd64-tdep.c: Fix common/ includes.
7184         * amd64-sol2-tdep.c: Fix common/ includes.
7185         * amd64-obsd-tdep.c: Fix common/ includes.
7186         * amd64-nbsd-tdep.c: Fix common/ includes.
7187         * amd64-linux-tdep.c: Fix common/ includes.
7188         * amd64-linux-nat.c: Fix common/ includes.
7189         * amd64-fbsd-tdep.c: Fix common/ includes.
7190         * amd64-fbsd-nat.c: Fix common/ includes.
7191         * amd64-dicos-tdep.c: Fix common/ includes.
7192         * amd64-darwin-tdep.c: Fix common/ includes.
7193         * agent.c: Fix common/ includes.
7194         * ada-lang.h: Fix common/ includes.
7195         * ada-lang.c: Fix common/ includes.
7196         * aarch64-tdep.c: Fix common/ includes.
7197
7198 2019-01-25  Tom Tromey  <tom@tromey.com>
7199
7200         * common/create-version.sh: Use common/version.h.
7201
7202 2019-01-24  Pedro Alves  <palves@redhat.com>
7203
7204         * infrun.c (signal_stop, signal_print, signal_program)
7205         (signal_catch, signal_pass): Now arrays instead of pointers.
7206         (update_signals_program_target, do_target_resume)
7207         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7208         * linux-nat.c (linux_nat_target::pass_signals)
7209         (linux_nat_target::create_inferior, linux_nat_target::attach):
7210         Adjust.
7211         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7212         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7213         * procfs.c (procfs_target::pass_signals): Adjust.
7214         * record-full.c (record_full_target::resume): Adjust.
7215         * remote.c (remote_target::pass_signals)
7216         (remote_target::program_signals): Adjust.
7217         * target-debug.h (target_debug_print_signals): Now takes a
7218         gdb::array_view as parameter.  Adjust.
7219         * target.h (target_ops) <pass_signals, program_signals>: Replace
7220         pointer and length parameters with gdb::array_view.
7221         (target_pass_signals, target_program_signals): Likewise.
7222         * target-delegates.c: Regenerate.
7223
7224 2019-01-24  Pedro Alves  <palves@redhat.com>
7225
7226         * common/forward-scope-exit.h
7227         (forward_scope_exit::forward_scope_exit): Pass arguments to
7228         m_bind_function directly, instead of creating a std::bind and
7229         copying that.
7230
7231 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7232
7233         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7234         for static members.
7235         (pass_in_v_vfp_candidate): Likewise.
7236
7237 2019-01-23  Tom Tromey  <tom@tromey.com>
7238             Pedro Alves  <palves@redhat.com>
7239
7240         * regcache.c (class regcache_invalidator): Remove.
7241         (regcache::raw_write): Use make_scope_exit.
7242
7243 2019-01-23  Tom Tromey  <tom@tromey.com>
7244
7245         * ui-out.h (class ui_out_emit_type): Update comment.
7246
7247 2019-01-23  Tom Tromey  <tom@tromey.com>
7248
7249         * infrun.c (fetch_inferior_event): Update comment.
7250
7251 2019-01-23  Tom Tromey  <tom@tromey.com>
7252             Pedro Alves  <palves@redhat.com>
7253
7254         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7255         parameter.
7256         (fetch_inferior_event): Use SCOPE_EXIT.
7257
7258
7259 2019-01-23  Tom Tromey  <tom@tromey.com>
7260             Pedro Alves  <palves@redhat.com>
7261
7262         * infrun.c (disable_thread_events): Delete.
7263         (stop_all_threads): Use SCOPE_EXIT.
7264
7265 2019-01-23  Tom Tromey  <tom@tromey.com>
7266             Pedro Alves  <palves@redhat.com>
7267
7268         * symfile.c: Include forward-scope-exit.h.
7269         (clear_symtab_users_cleanup): Replace forward declaration with
7270         a FORWARD_SCOPE_EXIT.
7271         (syms_from_objfile_1): Use the forward_scope_exit and
7272         gdb::optional instead of cleanup_function.
7273         (reread_symbols): Use the forward_scope_exit instead of
7274         cleanup_function.
7275         (clear_symtab_users_cleanup): Remove function.
7276
7277 2019-01-23  Tom Tromey  <tom@tromey.com>
7278             Pedro Alves  <palves@redhat.com>
7279
7280         * linux-nat.c: Include scope-exit.h.
7281         (cleanup_target_stop): Remove.
7282         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7283         SCOPE_EXIT.
7284
7285 2019-01-23  Tom Tromey  <tom@tromey.com>
7286             Pedro Alves  <palves@redhat.com>
7287
7288         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7289         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7290
7291 2019-01-23  Tom Tromey  <tom@tromey.com>
7292             Andrew Burgess  <andrew.burgess@embecosm.com>
7293             Pedro Alves  <palves@redhat.com>
7294
7295         * infrun.c (fetch_inferior_event): Use scope_exit.
7296         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7297         * top.c (execute_command): Use scope_exit.
7298         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7299         * utils.c (do_bpstat_clear_actions_cleanup)
7300         (make_bpstat_clear_actions_cleanup): Remove.
7301
7302 2019-01-23  Tom Tromey  <tom@tromey.com>
7303             Pedro Alves  <palves@redhat.com>
7304
7305         * infrun.c: Include "common/scope-exit.h"
7306         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7307         (wait_for_inferior): Use SCOPE_EXIT.
7308         (fetch_inferior_event): Use scope_exit.
7309
7310 2019-01-23  Tom Tromey  <tom@tromey.com>
7311             Pedro Alves  <palves@redhat.com>
7312
7313         * breakpoint.c (create_breakpoint): Remove cleanup.
7314
7315 2019-01-23  Tom Tromey  <tom@tromey.com>
7316             Andrew Burgess  <andrew.burgess@embecosm.com>
7317             Pedro Alves  <palves@redhat.com>
7318
7319 2019-01-23  Pedro Alves  <palves@redhat.com>
7320
7321         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7322
7323 2019-01-23  Pedro Alves  <palves@redhat.com>
7324             Andrew Burgess  <andrew.burgess@embecosm.com>
7325
7326         * gdbthread.h: Include "common/forward-scope-exit.h".
7327         (scoped_finish_thread_state): Redefine custom class in terms of
7328         forward_scope_exit.
7329
7330 2019-01-23  Pedro Alves  <palves@redhat.com>
7331             Andrew Burgess  <andrew.burgess@embecosm.com>
7332
7333         * common/forward-scope-exit.h: New file.
7334
7335 2019-01-23  Pedro Alves  <palves@redhat.com>
7336             Andrew Burgess  <andrew.burgess@embecosm.com>
7337             Tom Tromey  <tom@tromey.com>
7338
7339         * common/scope-exit.h: New file.
7340
7341 2019-01-23  Pedro Alves  <palves@redhat.com>
7342
7343         * common/preprocessor.h (ESC): Rename to ...
7344         (ESC_PARENS): ... this.
7345         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7346         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7347
7348 2019-01-23  Tom Tromey  <tom@tromey.com>
7349
7350         * language.h (class scoped_switch_to_sym_language_if_auto):
7351         Initialize m_lang in both cases.
7352
7353 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7354
7355         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7356         with XCNEW.
7357
7358 2019-01-22  Tom Tromey  <tom@tromey.com>
7359
7360         * corelow.c: Do not include sys/file.h.
7361
7362 2019-01-22  Tom Tromey  <tom@tromey.com>
7363
7364         * tui/tui-wingeneral.h: Include gdb_curses.h.
7365
7366 2019-01-22  Tom Tromey  <tom@tromey.com>
7367
7368         * source-cache.h (class source_cache) <get_source_lines,
7369         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7370
7371 2019-01-22  Tom Tromey  <tom@tromey.com>
7372
7373         * remote-fileio.h (struct remote_target): Declare.
7374
7375 2019-01-22  Tom Tromey  <tom@tromey.com>
7376
7377         * python/py-arch.c: Do not include py-ref.h.
7378         * python/py-bpevent.c: Do not include py-ref.h.
7379         * python/py-cmd.c: Do not include py-ref.h.
7380         * python/py-continueevent.c: Do not include py-ref.h.
7381         * python/py-event.h: Do not include py-ref.h.
7382         * python/py-evtregistry.c: Do not include py-ref.h.
7383         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7384         * python/py-frame.c: Do not include py-ref.h.
7385         * python/py-framefilter.c: Do not include py-ref.h.
7386         * python/py-function.c: Do not include py-ref.h.
7387         * python/py-infevents.c: Do not include py-ref.h.
7388         * python/py-linetable.c: Do not include py-ref.h.
7389         * python/py-objfile.c: Do not include py-ref.h.
7390         * python/py-param.c: Do not include py-ref.h.
7391         * python/py-prettyprint.c: Do not include py-ref.h.
7392         * python/py-progspace.c: Do not include py-ref.h.
7393         * python/py-symbol.c: Do not include py-ref.h.
7394         * python/py-symtab.c: Do not include py-ref.h.
7395         * python/py-type.c: Do not include py-ref.h.
7396         * python/py-unwind.c: Do not include py-ref.h.
7397         * python/py-utils.c: Do not include py-ref.h.
7398         * python/py-value.c: Do not include py-ref.h.
7399         * python/py-varobj.c: Do not include py-ref.h.
7400         * python/py-xmethods.c: Do not include py-ref.h.
7401         * python/python.c: Do not include py-ref.h.
7402         * varobj.c: Do not include py-ref.h.
7403
7404 2019-01-22  Tom Tromey  <tom@tromey.com>
7405
7406         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7407         keyword for bcache.
7408
7409 2019-01-22  Tom Tromey  <tom@tromey.com>
7410
7411         * compile/compile-cplus-types.c: Remove a comment by #include.
7412
7413 2019-01-22  Tom Tromey  <tom@tromey.com>
7414
7415         * compile/gcc-c-plugin.h: Include compile-internal.h.
7416
7417 2019-01-22  Tom Tromey  <tom@tromey.com>
7418
7419         * stabsread.c (EXTERN): Do not define.
7420         (symnum, next_symbol_text_func, processing_gcc_compilation)
7421         (within_function, global_sym_chain, global_stabs)
7422         (previous_stab_code, this_object_header_files)
7423         (n_this_object_header_files)
7424         (n_allocated_this_object_header_files): Define.
7425         * stabsread.h (EXTERN): Never define.  Use "extern".
7426
7427 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7428
7429         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7430         history_value.
7431
7432 2019-01-21  Tom Tromey  <tom@tromey.com>
7433
7434         * ui-out.c: Fix includes.
7435         * tui/tui-source.c: Fix includes.
7436         * target.c: Fix includes.
7437         * remote.c: Fix includes.
7438         * regcache.c: Fix includes.
7439         * python/py-block.c: Fix includes.
7440         * printcmd.c: Fix includes.
7441         * or1k-tdep.c: Fix includes.
7442         * mi/mi-main.c: Fix includes.
7443         * m32r-tdep.c: Fix includes.
7444         * csky-tdep.c: Fix includes.
7445         * compile/compile-cplus-types.c: Fix includes.
7446         * cli/cli-interp.c: Fix includes.
7447
7448 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7449
7450         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7451         for padding.
7452
7453 2019-01-16  Tom Tromey  <tom@tromey.com>
7454
7455         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7456         earlier.
7457         (struct objfile) <msymbols_range>: Move from top level.
7458         <msymbols>: New method.
7459         (class objfile_msymbols): Remove.
7460         * symtab.c (default_collect_symbol_completion_matches_break_on):
7461         Update.
7462         * symmisc.c (dump_msymbols): Update.
7463         * stabsread.c (scan_file_globals): Update.
7464         * objc-lang.c (info_selectors_command, info_classes_command)
7465         (find_methods): Update.
7466         * minsyms.c (find_solib_trampoline_target): Update.
7467         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7468         * coffread.c (coff_symfile_read): Update.
7469         * ada-lang.c (ada_lookup_simple_minsym)
7470         (ada_collect_symbol_completion_matches): Update.
7471
7472 2019-01-16  Tom Tromey  <tom@tromey.com>
7473
7474         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7475         type.  Remove no-argument constructor.
7476         <iterator::operator++>: Simplify.
7477         <begin>: Update.
7478         <end>: Use minimal_symbol_count.
7479
7480 2019-01-16  Tom Tromey  <tom@tromey.com>
7481
7482         * objfiles.h (struct objfile) <psymtabs>: New method.
7483         (class objfile_psymtabs): Remove.
7484         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7485         typedef.
7486         <range>: New method.
7487         (require_partial_symbols): Change return type.
7488         * psymtab.c (require_partial_symbols)
7489         (psym_expand_symtabs_matching): Update.
7490         * mdebugread.c (parse_partial_symbols): Update.
7491         * dbxread.c (dbx_end_psymtab): Update.
7492
7493 2019-01-15  Tom Tromey  <tom@tromey.com>
7494
7495         * symtab.c (lookup_objfile_from_block)
7496         (lookup_symbol_in_objfile_symtabs)
7497         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7498         (find_line_symtab, info_sources_command)
7499         (default_collect_symbol_completion_matches_break_on)
7500         (make_source_files_completion_list): Update.
7501         * symmisc.c (print_objfile_statistics, dump_objfile)
7502         (maintenance_print_symbols, maintenance_info_symtabs)
7503         (maintenance_check_symtabs, maintenance_info_line_tables):
7504         Update.
7505         * source.c (select_source_symtab)
7506         (forget_cached_source_info_for_objfile): Update.
7507         * objfiles.h (class objfile_compunits): Remove.
7508         (struct objfile) <compunits_range>: New typedef.
7509         (compunits): New method.
7510         * objfiles.c (objfile_relocate1): Update.
7511         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7512         * maint.c (count_symtabs_and_blocks): Update.
7513         * linespec.c (iterate_over_all_matching_symtabs): Update.
7514         * cp-support.c (add_symbol_overload_list_qualified): Update.
7515         * coffread.c (coff_symtab_read): Update.
7516         * ada-lang.c (add_nonlocal_symbols)
7517         (ada_collect_symbol_completion_matches)
7518         (ada_add_global_exceptions): Update.
7519
7520 2019-01-15  Tom Tromey  <tom@tromey.com>
7521
7522         * progspace.h (program_space) <objfiles_safe_range>: New
7523         typedef.
7524         <objfiles_safe>: New method.
7525         * objfiles.h (class all_objfiles_safe): Remove.
7526         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7527         * jit.c (jit_inferior_exit_hook): Update.
7528
7529 2019-01-17  Tom Tromey  <tom@tromey.com>
7530
7531         * progspace.h (program_space) <objfiles_range>: New typedef.
7532         <objfiles>: New method.
7533         <objfiles_head>: Rename from objfiles.
7534         (object_files): Update.
7535         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7536         * guile/scm-pretty-print.c
7537         (ppscm_find_pretty_printer_from_objfiles): Update.
7538         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7539         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7540         Update.
7541         * python/py-progspace.c (pspy_get_objfiles): Update.
7542         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7543         Update.
7544         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7545         (objfpy_lookup_objfile_by_build_id): Update.
7546         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7547         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7548         Update.
7549         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7550         (expand_symtab_containing_pc, lookup_objfile_from_block)
7551         (lookup_static_symbol, basic_lookup_transparent_type)
7552         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7553         (find_line_symtab, info_sources_command)
7554         (default_collect_symbol_completion_matches_break_on)
7555         (make_source_files_completion_list, find_main_name): Update.
7556         * symmisc.c (print_symbol_bcache_statistics)
7557         (print_objfile_statistics, maintenance_print_symbols)
7558         (maintenance_print_msymbols, maintenance_print_objfiles)
7559         (maintenance_info_symtabs, maintenance_check_symtabs)
7560         (maintenance_expand_symtabs, maintenance_info_line_tables):
7561         Update.
7562         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7563         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7564         (map_overlay_command, unmap_overlay_command)
7565         (simple_overlay_update, expand_symtabs_matching)
7566         (map_symbol_filenames): Update.
7567         * symfile-debug.c (set_debug_symfile): Update.
7568         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7569         Update.
7570         * source.c (select_source_symtab, forget_cached_source_info):
7571         Update.
7572         * solib.c (solib_read_symbols): Update.
7573         * solib-spu.c (append_ocl_sos): Update.
7574         * psymtab.c (maintenance_print_psymbols)
7575         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7576         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7577         * printcmd.c (info_symbol_command): Update.
7578         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7579         Update.
7580         * objfiles.h (class all_objfiles): Remove.
7581         * objfiles.c (have_partial_symbols, have_full_symbols)
7582         (have_minimal_symbols, qsort_cmp, update_section_map)
7583         (shared_objfile_contains_address_p)
7584         (default_iterate_over_objfiles_in_search_order): Update.
7585         * objc-lang.c (info_selectors_command, info_classes_command)
7586         (find_methods): Update.
7587         * minsyms.c (find_solib_trampoline_target): Update.
7588         * maint.c (maintenance_info_sections)
7589         (maintenance_translate_address, count_symtabs_and_blocks):
7590         Update.
7591         * main.c (captured_main_1): Update.
7592         * linux-thread-db.c (try_thread_db_load_from_pdir)
7593         (has_libpthread): Update.
7594         * linespec.c (iterate_over_all_matching_symtabs)
7595         (search_minsyms_for_name): Update.
7596         * jit.c (jit_find_objf_with_entry_addr): Update.
7597         * hppa-tdep.c (find_unwind_entry)
7598         (hppa_lookup_stub_minimal_symbol): Update.
7599         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7600         Update.
7601         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7602         (elf_gnu_ifunc_resolve_by_got): Update.
7603         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7604         * dwarf-index-write.c (save_gdb_index_command): Update.
7605         * cp-support.c (add_symbol_overload_list_qualified): Update.
7606         * breakpoint.c (create_overlay_event_breakpoint)
7607         (create_longjmp_master_breakpoint)
7608         (create_std_terminate_master_breakpoint)
7609         (create_exception_master_breakpoint): Update.
7610         * blockframe.c (find_pc_partial_function): Update.
7611         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7612         (ada_collect_symbol_completion_matches)
7613         (ada_add_global_exceptions): Update.
7614
7615 2019-01-17  Tom Tromey  <tom@tromey.com>
7616
7617         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7618         declare VEC.
7619         (solib_target_parse_libraries): Change return type.
7620         (library_list_start_segment, library_list_start_section)
7621         (library_list_end_library, library_list_start_library); Update.
7622         (solib_target_free_library_list): Remove.
7623         (solib_target_parse_libraries): Remove cleanup.  Change return
7624         type.
7625         (solib_target_current_sos): Update.
7626
7627 2019-01-17  Tom Tromey  <tromey@bapiya>
7628
7629         * valprint.c: Replace "the the" with "the".
7630         * symtab.c: Replace "the the" with "the".
7631         * solib.c: Replace "the the" with "the".
7632         * solib-dsbt.c: Replace "the the" with "the".
7633         * linespec.c: Replace "the the" with "the".
7634         * dwarf2loc.h: Replace "the the" with "the".
7635         * amd64-windows-tdep.c: Replace "the the" with "the".
7636         * aarch64-tdep.c: Replace "the the" with "the".
7637
7638 2019-01-16  Keith Seitz  <keiths@redhat.com>
7639
7640         PR gdb/23773
7641         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7642         <builder>: Rename to ..
7643         <m_builder>: ... this and make private.
7644         (dwarf2_cu::get_builder): New method.  Change all users of
7645         `builder' to use this method.
7646         (dwarf2_start_symtab): Move to ...
7647         (dwarf2_cu::start_symtab): ... here.  Update all callers
7648         (setup_type_unit_groups): Move to ...
7649         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7650         callers.
7651         (dwarf2_cu::reset_builder): New method.
7652         (process_full_compunit, process_full_type_unit): Use
7653         dwarf2_cu::reset_builder.
7654         (follow_die_offset): Record the ancestor CU if it is different
7655         from the followed DIE's CU.
7656         (follow_die_sig_1): Likewise.
7657
7658 2019-01-15  Tom Tromey  <tom@tromey.com>
7659
7660         * remote.c (class remote_state) <buf>: Now a char_vector.
7661         <buf_size>: Remove.
7662         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7663         parameter.
7664         (remote_target::getpkt_or_notif_sane_1)
7665         (remote_target::getpkt_sane)
7666         (remote_target::getpkt_or_notif_sane): Likewise.
7667         (class remote_target) <putpkt>: New overload.
7668         (remote_target::read_frame): Change type of "buf_p".  Remove
7669         sizeof_p parameter.
7670         (packet_ok): New overload.
7671         (packet_check_result): New overload.
7672         Update all uses.
7673
7674 2019-01-14  Tom Tromey  <tom@tromey.com>
7675
7676         * remote-notif.c (handle_notification, remote_notif_ack)
7677         (remote_notif_parse): Make "buf" const.
7678         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7679         const.
7680         (remote_notif_parse, remote_notif_ack, handle_notification):
7681         Likewise.
7682         * remote.c (remote_notif_stop_parse): Make "buf" const.
7683         (remote_target::remote_parse_stop_reply): Make "buf" const.
7684         (remote_notif_stop_ack): Make "buf" const.
7685
7686 2019-01-14  Tom Tromey  <tom@tromey.com>
7687
7688         * remote.c (remote_console_output): Make parameter const.
7689
7690 2019-01-14  Tom Tromey  <tom@tromey.com>
7691
7692         * target-debug.h (target_debug_print_signals): Constify.
7693         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7694         * procfs.c (procfs_target::pass_signals): Update.
7695         * linux-nat.c (linux_nat_target::pass_signals): Update.
7696         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7697         * target-delegates.c: Rebuild.
7698         * remote.c (remote_target::program_signals): Update.
7699         (remote_target::pass_signals): Update.
7700         * target.c (target_pass_signals): Constify argument.
7701         (target_program_signals): Likewise.
7702         * target.h (struct target_ops) <pass_signals, program_signals>:
7703         Constify argument.
7704         (target_pass_signals, target_program_signals): Constify argument.
7705
7706 2019-01-14  Tom Tromey  <tom@tromey.com>
7707
7708         PR tui/28819:
7709         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7710
7711 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7712
7713         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7714         field.
7715         * rs6000-tdep.c: Include reggroups.h.
7716         (IS_V_ALIAS_PSEUDOREG): Define.
7717         (rs6000_register_name): Return names for the "vX" aliases.
7718         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7719         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7720         aliases.  Call default_register_reggroup_p for all other
7721         pseudo-registers.
7722         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7723         New functions.
7724         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7725         Handle "vX" aliases.
7726         (v_alias_pseudo_register_collect): New function.
7727         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7728         (rs6000_gdbarch_init): Initialize "vX" aliases as
7729         pseudo-registers.  Restore registration of
7730         rs6000_pseudo_register_reggroup_p with
7731         set_tdesc_pseudo_register_reggroup_p.
7732
7733 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7734
7735         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7736         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7737         set_gdbarch_num_pseudo_regs.
7738
7739 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7740
7741         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7742         Remove arg prefixname, add do_set and do_show.
7743         Add member functions set_list and show_list.
7744         * cli/cli-style.c (class cli_style_option): Update accordingly.
7745         (style_set_list): Move to file scope.
7746         (style_show_list): Likewise.
7747         (set_style): Call help_list.
7748         (show_style): Call cmd_show_list.
7749         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7750         Update to use the new macro.
7751
7752 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7753
7754         * ada-lang.c (_initialize_ada_language): Expand the help text
7755         for the "catch exception" command.
7756
7757 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7758
7759         * symtab.c (matching_obj_sections): Initialize obj,
7760         declare it closer to its usage.
7761
7762 2019-01-10  Tom Tromey  <tom@tromey.com>
7763
7764         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7765         (basic_inf_threads_range): Remove.
7766         (inf_threads_range, inf_non_exited_threads_range)
7767         (safe_inf_threads_range): Use next_adapter.
7768
7769 2019-01-10  Keith Seitz  <keiths@redhat.com>
7770
7771         PR gdb/23712
7772         PR symtab/23010
7773         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7774         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7775
7776 2019-01-10  Keith Seitz  <keiths@redhat.com>
7777
7778         PR gdb/23712
7779         PR symtab/23010
7780         * dictionary.c (pending_to_vector): Remove.
7781         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7782         Remove _1 suffix, replacing functions of the same name.  Update
7783         all callers.
7784         (dict_create_hashed, dict_create_hashed_expandable)
7785         (dict_create_linear, dict_create_linear_expandable, dict_free)
7786         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7787         Make functions static.
7788
7789 2019-01-10  Keith Seitz  <keiths@redhat.com>
7790
7791         PR gdb/23712
7792         PR symtab/23010
7793         * dictionary.h (struct dictionary): Replace declaration with
7794         multidictionary.
7795         (dict_create_hashed, dict_create_hashed_expandable)
7796         (dict_create_linear, dict_create_linear_expandable)
7797         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7798         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7799         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7800         taking multidictionary argument.
7801         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7802         * block.h (struct block) <dict>: Change to multidictionary
7803         and rename `multidict'.
7804         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7805         symmisc.c: Update all dictionary references to multidictionary.
7806
7807 2019-01-10  Keith Seitz  <keiths@redhat.com>
7808
7809         PR gdb/23712
7810         PR symtab/23010
7811         * dictionary.c: Include unordered_map.
7812         (pending_to_vector): New function.
7813         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7814         Rewrite the non-"_1" functions to take vector instead
7815         of linked list.
7816         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7817         "new" _1 versions of the same name.
7818         (multidictionary): Define.
7819         (std::hash<enum language): New definition.
7820         (collate_pending_symbols_by_language, mdict_create_hashed)
7821         (mdict_create_hashed_expandable, mdict_create_linear)
7822         (mdict_create_linear_expandable, mdict_free)
7823         (find_language_dictionary, create_new_language_dictionary)
7824         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7825         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7826         (mdict_size, mdict_empty): New functions.
7827         * dictionary.h (mdict_iterator): Define.
7828
7829 2019-01-10  Pedro Alves  <palves@redhat.com>
7830
7831         * breakpoint.c (read_uploaded_action)
7832         (create_tracepoint_from_upload): Adjust to use
7833         gdb::unique_xmalloc_ptr.
7834         * ctf.c (ctf_write_uploaded_tp):
7835         (SET_ARRAY_FIELD): Use emplace_back.
7836         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7837         * tracefile-tfile.c (tfile_write_uploaded_tp):
7838         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7839         gdb::unique_xmalloc_ptr.
7840         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7841         at_string, cond_string, cmd_strings>: Replace char pointers
7842         with gdb::unique_xmalloc_ptr.
7843
7844 2019-01-10  Pedro Alves  <palves@redhat.com>
7845
7846         * solib-target.c (library_list_start_library): Don't xstrdup name.
7847
7848 2019-01-10  Pedro Alves  <palves@redhat.com>
7849
7850         * mdebugread.c (parse_partial_symbols): Use
7851         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7852
7853 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7854
7855         * linux-fork.c (scoped_switch_fork_info)
7856         <~scoped_switch_fork_info>: Fix incorrect variable name.
7857
7858 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * linux-fork.c (scoped_switch_fork_info)
7861         <scoped_switch_fork_info>: Make explicit.
7862         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7863
7864 2019-01-10  Tom Tromey  <tom@tromey.com>
7865
7866         * objfiles.h (objfile::reset_psymtabs): Update.
7867         * objfiles.c (objfile::objfile): Update.
7868         * psymtab.h (psymtab_storage::obstack): Update.
7869         (psymtab_storage::m_obstack): Use gdb::optional.
7870         (class psymtab_storage): Update comment.  Remove objfile
7871         parameter.
7872         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7873
7874 2019-01-10  Tom Tromey  <tom@tromey.com>
7875
7876         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7877         <free_psymtabs>: Now private.
7878         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7879         (allocate_psymtab): Use new method.
7880
7881 2019-01-10  Tom Tromey  <tom@tromey.com>
7882
7883         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7884         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7885         * mdebugread.c (parse_partial_symbols): Use
7886         allocate_dependencies.
7887         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7888         allocate_dependencies.
7889         (process_psymtab_comp_unit_reader)
7890         (build_type_psymtab_dependencies): Likewise.
7891         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7892
7893 2019-01-10  Tom Tromey  <tom@tromey.com>
7894
7895         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7896         PSYMBOL_SET_LANGUAGE.
7897         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7898
7899 2019-01-10  Tom Tromey  <tom@tromey.com>
7900
7901         * psymtab.h (psymtab_storage::obstack): New method.
7902         <m_obstack>: Rename from obstack; now private.
7903         * psymtab.c (psymtab_storage): Update.
7904         * dwarf2read.c (create_addrmap_from_index)
7905         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7906         Update.
7907
7908 2019-01-10  Tom Tromey  <tom@tromey.com>
7909
7910         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7911         * objfiles.h (objfile::reset_psymtabs): New method.
7912
7913 2019-01-10  Tom Tromey  <tom@tromey.com>
7914
7915         * symmisc.c (print_symbol_bcache_statistics): Update.
7916         (print_objfile_statistics): Update.
7917         * symfile.c (reread_symbols): Update.
7918         * psymtab.h (class psymtab_storage): New.
7919         * psymtab.c (psymtab_storage): New constructor.
7920         (~psymtab_storage): New destructor.
7921         (require_partial_symbols): Update.
7922         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7923         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7924         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7925         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7926         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7927         (start_psymtab_common, end_psymtab_common)
7928         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7929         (allocate_psymtab): Update.
7930         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7931         Update.
7932         (dump_psymtab_addrmap, maintenance_print_psymbols)
7933         (maintenance_check_psymtabs): Update.
7934         (class objfile_psymtabs): Move to objfiles.h.
7935         * psympriv.h (discard_psymtab): Now inline.
7936         (psymtab_discarder::psymtab_discarder): Update.
7937         (psymtab_discarder::~psymtab_discarder): Update.
7938         (ALL_OBJFILE_PSYMTABS): Rewrite.
7939         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7940         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7941         Remove fields.
7942         <partial_symtabs>: New field.
7943         (class objfile_psymtabs): Move from psymtab.h.  Update.
7944         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7945         psymbol_cache.
7946         (objfile::~objfile): Don't destroy psymbol_cache.
7947         * mdebugread.c (parse_partial_symbols): Update.
7948         * dwarf2read.c (create_addrmap_from_index)
7949         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7950         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7951         (add_partial_subprogram, dwarf2_ranges_read): Update.
7952         * dwarf-index-write.c (write_address_map)
7953         (write_one_signatured_type, recursively_write_psymbols)
7954         (class debug_names, class debug_names, write_psymtabs_to_index):
7955         Update.
7956
7957 2019-01-10  Tom Tromey  <tom@tromey.com>
7958
7959         * symtab.h (SYMBOL_SET_NAMES): Update.
7960         (symbol_set_names): Update.
7961         (MSYMBOL_SET_NAMES): Update.
7962         * symtab.c (symbol_set_names): Change argument to be an
7963         objfile_per_bfd_storage.
7964         * psymtab.c (add_psymbol_to_bcache): Update.
7965         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7966
7967 2019-01-10  Tom Tromey  <tom@tromey.com>
7968
7969         * symtab.c (create_demangled_names_hash): Change argument to be an
7970         objfile_per_bfd_storage.
7971         (symbol_set_names): Update.
7972
7973 2019-01-10  Tom Tromey  <tom@tromey.com>
7974
7975         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7976         init_psymbol_list.
7977         * psymtab.c (init_psymbol_list): Do nothing if already called.
7978         * psympriv.h (init_psymbol_list): Add comment.
7979         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7980         init_psymbol_list.
7981         * dbxread.c (dbx_symfile_read): Unconditionally call
7982         init_psymbol_list.
7983
7984 2019-01-10  Tom Tromey  <tom@tromey.com>
7985
7986         * xcoffread.c (scan_xcoff_symtab): Update.
7987         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7988         "where".
7989         * mdebugread.c (parse_partial_symbols)
7990         (handle_psymbol_enumerators): Update.
7991         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7992         * dbxread.c (read_dbx_symtab): Update.
7993         * psympriv.h (psymbol_placement): New enum.
7994         (add_psymbol_to_list): Update.
7995
7996 2019-01-10  Tom Tromey  <tom@tromey.com>
7997
7998         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7999         static_psymbols parameters.
8000         (scan_xcoff_symtab): Update.
8001         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8002         static_psymbols parameters.
8003         * psympriv.h (start_psymtab_common): Update.
8004         * mdebugread.c (parse_partial_symbols): Update.
8005         * dwarf2read.c (create_partial_symtab): Update.
8006         * dbxread.c (read_dbx_symtab): Update.
8007         (start_psymtab): Remove global_psymbols and static_psymbols
8008         parameters.
8009
8010 2019-01-10  Tom Tromey  <tom@tromey.com>
8011
8012         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8013         * psymtab.c (allocate_psymtab): Add comment.
8014         * psympriv.h (allocate_psymtab): Add comment.
8015         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8016         initializations.
8017         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8018
8019 2019-01-10  Tom Tromey  <tom@tromey.com>
8020
8021         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8022         Don't declare.
8023         * mipsread.c: Include mdebugread.h.
8024         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8025         Declare.
8026         * elfread.c: Include mdebugread.h.
8027
8028 2019-01-09  Tom Tromey  <tom@tromey.com>
8029
8030         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8031         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8032         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8033         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8034         (psym_lookup_symbol, psym_find_last_source_symtab)
8035         (psym_forget_cached_source_info, psym_print_stats)
8036         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8037         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8038         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8039         (psym_find_compunit_symtab_by_address)
8040         (maintenance_print_psymbols, maintenance_info_psymtabs)
8041         (maintenance_check_psymtabs): Use ranged for.
8042         * psymtab.h (class objfile_psymtabs): New.
8043         (require_partial_symbols): Return objfile_psymtabs.
8044         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8045
8046 2019-01-09  Tom Tromey  <tom@tromey.com>
8047
8048         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8049         (find_pc_mapped_section, list_overlays_command)
8050         (map_overlay_command, unmap_overlay_command)
8051         (simple_overlay_update): Use all_objfiles.
8052         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8053         * printcmd.c (info_symbol_command): Use all_objfiles.
8054         * objfiles.h (ALL_OBJSECTIONS): Remove.
8055         * maint.c (maintenance_translate_address): Use all_objfiles.
8056         * gcore.c (gcore_create_callback): Use all_objfiles.
8057         (objfile_find_memory_regions): Likewise.
8058
8059 2019-01-09  Tom Tromey  <tom@tromey.com>
8060
8061         * symtab.c (find_line_symtab, info_sources_command)
8062         (make_source_files_completion_list): Use objfile_compunits.
8063         * source.c (select_source_symtab): Use objfile_compunits.
8064         * objfiles.h (struct objfile): Update comment.
8065         (ALL_OBJFILES): Remove.
8066         (ALL_FILETABS): Remove.
8067         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8068         objfile_compunits.
8069
8070 2019-01-09  Tom Tromey  <tom@tromey.com>
8071
8072         * symmisc.c (print_objfile_statistics, dump_objfile)
8073         (maintenance_print_symbols): Use compunit_filetabs.
8074         * source.c (forget_cached_source_info_for_objfile): Use
8075         compunit_filetabs.
8076         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8077         (ALL_FILETABS): Use compunit_filetabs.
8078         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8079         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8080
8081 2019-01-09  Tom Tromey  <tom@tromey.com>
8082
8083         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8084         (compunit_filetabs): New.
8085         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8086         compunit_filetabs.
8087         (info_sources_command, make_source_files_completion_list): Remove
8088         declaration.
8089         * symmisc.c (print_objfile_statistics, dump_objfile)
8090         (maintenance_print_symbols): Remove declaration.
8091         (maintenance_info_symtabs): Use compunit_filetabs.
8092         (maintenance_info_line_tables): Likewise.
8093         * source.c (select_source_symtab): Change local variable name.
8094         (forget_cached_source_info_for_objfile): Remove declaration.
8095         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8096         * objfiles.c (objfile_relocate1): Remove declaration.
8097         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8098         declaration.
8099         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8100         * coffread.c (coff_symtab_read): Remove declaration.
8101         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8102         compunit_filetabs.
8103
8104 2019-01-09  Tom Tromey  <tom@tromey.com>
8105
8106         * symtab.c (lookup_objfile_from_block)
8107         (find_pc_sect_compunit_symtab, search_symbols)
8108         (default_collect_symbol_completion_matches_break_on): Use
8109         objfile_compunits.
8110         * objfiles.h (ALL_COMPUNITS): Remove.
8111         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8112         * cp-support.c (add_symbol_overload_list_qualified): Use
8113         objfile_compunits.
8114         * ada-lang.c (ada_collect_symbol_completion_matches)
8115         (ada_add_global_exceptions): Use objfile_compunits.
8116
8117 2019-01-09  Tom Tromey  <tom@tromey.com>
8118
8119         * source.c (select_source_symtab)
8120         (forget_cached_source_info_for_objfile): Remove declaration.
8121         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8122         declaration.
8123         * maint.c (count_symtabs_and_blocks): Remove declaration.
8124         * cp-support.c (add_symbol_overload_list_qualified): Remove
8125         declaration.
8126         * coffread.c (coff_symtab_read): Remove declaration.
8127         * symtab.c (lookup_symbol_in_objfile_symtabs)
8128         (basic_lookup_transparent_type_1): Use objfile_compunits.
8129         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8130         (info_sources_command, search_symbols)
8131         (default_collect_symbol_completion_matches_break_on)
8132         (make_source_files_completion_list): Remove declaration.
8133         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8134         (ada_collect_symbol_completion_matches)
8135         (ada_add_global_exceptions): Remove declaration.
8136         * linespec.c (iterate_over_all_matching_symtabs): Use
8137         objfile_compunits.
8138         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8139         (class objfile_compunits): New.
8140         (ALL_COMPUNITS): Use objfile_compunits.
8141         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8142         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8143         objfile_compunits.
8144         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8145
8146 2019-01-09  Tom Tromey  <tom@tromey.com>
8147
8148         * symtab.c (search_symbols)
8149         (default_collect_symbol_completion_matches_break_on): Use
8150         objfile_msymbols.
8151         * ada-lang.c (ada_lookup_simple_minsym)
8152         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8153         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8154         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8155         objfile_msymbols.
8156         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8157         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8158         * objc-lang.c (find_methods): Use objfile_msymbols.
8159         (info_selectors_command, info_classes_command): Likewise.
8160         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8161         * objfiles.h (class objfile_msymbols): New.
8162         (ALL_OBJFILE_MSYMBOLS): Remove.
8163         (ALL_MSYMBOLS): Remove.
8164
8165 2019-01-09  Tom Tromey  <tom@tromey.com>
8166
8167         * common/next-iterator.h (next_adapter): Add Iterator template
8168         parameter.
8169         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8170         (class all_objfiles_safe): New.
8171         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8172         * objfiles.c (put_objfile_before): Update comment.
8173         (add_separate_debug_objfile): Likewise.
8174         (free_all_objfiles): Use all_objfiles_safe.
8175         (objfile_purge_solibs): Likewise.
8176
8177 2019-01-09  Tom Tromey  <tom@tromey.com>
8178
8179         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8180         (expand_symtab_containing_pc, lookup_static_symbol)
8181         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8182         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8183         all_objfiles.
8184         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8185         * breakpoint.c (create_overlay_event_breakpoint)
8186         (create_longjmp_master_breakpoint)
8187         (create_std_terminate_master_breakpoint)
8188         (create_exception_master_breakpoint): Use all_objfiles.
8189         * linux-thread-db.c (try_thread_db_load_from_pdir)
8190         (has_libpthread): Use all_objfiles.
8191         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8192         * linespec.c (iterate_over_all_matching_symtabs)
8193         (search_minsyms_for_name): Use all_objfiles.
8194         * maint.c (maintenance_info_sections): Use all_objfiles.
8195         * main.c (captured_main_1): Use all_objfiles.
8196         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8197         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8198         * guile/scm-pretty-print.c
8199         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8200         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8201         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8202         (maintenance_print_msymbols): Use all_objfiles.
8203         * source.c (select_source_symtab): Use all_objfiles.
8204         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8205         * symfile.c (remove_symbol_file_command)
8206         (expand_symtabs_matching, map_symbol_filenames): Use
8207         all_objfiles.
8208         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8209         all_objfiles.
8210         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8211         * objc-lang.c (find_methods): Use all_objfiles.
8212         * objfiles.c (have_partial_symbols, have_full_symbols)
8213         (have_minimal_symbols, qsort_cmp)
8214         (default_iterate_over_objfiles_in_search_order): Use
8215         all_objfiles.
8216         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8217         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8218         (maintenance_check_psymtabs): Use all_objfiles.
8219         (ALL_PSYMTABS): Remove.
8220         * compile/compile-object-run.c (do_module_cleanup): Use
8221         all_objfiles.
8222         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8223         * cp-support.c (add_symbol_overload_list_qualified): Use
8224         all_objfiles.
8225         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8226         Use all_objfiles.
8227         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8228         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8229         all_objfiles.
8230         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8231         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8232         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8233         Uses all_objfiles.
8234         * solib.c (solib_read_symbols): Use all_objfiles
8235
8236 2019-01-09  Tom Tromey  <tom@tromey.com>
8237
8238         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8239         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8240         all_objfiles.
8241         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8242         * symmisc.c (print_symbol_bcache_statistics)
8243         (print_objfile_statistics, maintenance_print_objfiles)
8244         (maintenance_info_symtabs, maintenance_check_symtabs)
8245         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8246         all_objfiles.
8247         * source.c (forget_cached_source_info): Use all_objfiles.
8248         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8249         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8250         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8251         * objfiles.c (update_section_map): Use all_objfiles.
8252         (shared_objfile_contains_address_p): Likewise.
8253         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8254         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8255
8256 2019-01-09  Tom Tromey  <tom@tromey.com>
8257
8258         * common/next-iterator.h: New file.
8259         * objfiles.h (class all_objfiles): New.
8260         (struct objfile_iterator): New.
8261
8262 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8263
8264         * NEWS: Move the description of the changed "frame", "select-frame",
8265          and "info frame" commands to the Changed commands section.
8266
8267 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8268
8269         * gdbtypes.c (check_stub_method_group): Remove handling of old
8270         mangling schemes.
8271         * linespec.c (find_methods): Likewise.
8272         * stabsread.c (read_member_functions): Likewise.
8273         * valops.c (search_struct_method): Likewise.
8274         (value_struct_elt_for_reference): Likewise.
8275         * NEWS: Mention this change.
8276
8277 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8278
8279         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8280         print_source_lines.
8281         * source.c (print_source_lines_base): Update line number check.
8282         (print_source_lines): New function.
8283         (source_lines_range::source_lines_range): New function.
8284         * source.h (class source_lines_range): New class.
8285         (print_source_lines): New declaration.
8286
8287 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8288
8289         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8290
8291 2019-01-08  Tom Tromey  <tom@tromey.com>
8292             Simon Marchi  <simon.marchi@ericsson.com>
8293
8294         PR gdb/24060
8295         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8296         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8297         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8298         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8299         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8300         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8301
8302 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8303
8304         * source.c (select_source_symtab): Move header comment to
8305         declaration in source.h.
8306         (forget_cached_source_info_for_objfile): Likewise.
8307         (forget_cached_source_info): Likewise.
8308         (identify_source_line): Likewise.
8309         * source.h (identify_source_line): Move declaration from symtab.h
8310         and add comment from source.c
8311         (print_source_lines): Likewise.
8312         (forget_cached_source_info_for_objfile): Likewise.
8313         (forget_cached_source_info): Likewise.
8314         (select_source_symtab): Likewise.
8315         (enum print_source_lines_flag): Move definition from symtab.h.
8316         * symtab.h (identify_source_line): Move declaration to source.h.
8317         (print_source_lines): Likewise.
8318         (forget_cached_source_info_for_objfile): Likewise.
8319         (forget_cached_source_info): Likewise.
8320         (select_source_symtab): Likewise.
8321         (enum print_source_lines_flag): Move definition to source.h.
8322         * tui/tui-hooks.c: Add 'source.h' include.
8323
8324 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8325
8326         * source.c (print_source_lines_base): Handle requests to print
8327         reverse line number sequences, and guard against empty lines
8328         string.
8329
8330 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8331
8332         * source.c (print_source_lines_base): Fix skip of '\r' if next
8333         character is '\n'.
8334
8335 2019-01-06  Tom Tromey  <tom@tromey.com>
8336
8337         * c-exp.y (struct c_parse_state) <macro_original_text,
8338         expansion_obstack>: New member.
8339         (macro_original_text, expansion_obstack): Remove globals.
8340         (scan_macro_expansion, scanning_macro_expansion)
8341         (finished_macro_expansion): Update.
8342         (scan_macro_cleanup): Remove.
8343         (yylex, c_parse): Update.
8344
8345 2019-01-06  Tom Tromey  <tom@tromey.com>
8346
8347         * c-exp.y (struct c_parse_state) <strings>: New member.
8348         (operator_stoken): Update.
8349
8350 2019-01-06  Tom Tromey  <tom@tromey.com>
8351
8352         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8353         (union type_stack_elt) <typelist_val>: Now a pointer to
8354         std::vector.
8355         (type_stack_cleanup): Don't declare.
8356         (push_typelist): Update.
8357         * parse.c (pop_typelist): Return a std::vector.
8358         (push_typelist): Take a std::vector.
8359         (follow_types): Update.  Do not free args.
8360         (type_stack_cleanup): Remove.
8361         * c-exp.y (struct c_parse_state): New.
8362         (cpstate): New global.
8363         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8364         (nonempty_typelist): Update.
8365         (func_mod): Create a new vector.
8366         (c_parse): Create a c_parse_state.
8367         (check_parameter_typelist): Do not delete params.
8368         (function_method): Update.  Do not delete type_list.
8369
8370 2019-01-06  Tom Tromey  <tom@tromey.com>
8371
8372         PR gdb/28155:
8373         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8374         check_typedef.
8375         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8376         (print_return_value): Likewise.
8377
8378 2019-01-05  Tom Tromey  <tom@tromey.com>
8379
8380         * contrib/cleanup_check.py: Remove.
8381         * contrib/gcc-with-excheck: Remove.
8382         * contrib/exsummary.py: Remove.
8383         * contrib/excheck.py: Remove.
8384
8385 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8386
8387         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8388         NULL. Initialize tpprev to NULL instead of assigning it
8389         to NULL on the next statement.
8390         * windows-nat.c (windows_delete_thread): Remove check for
8391         main_thread_id before printing thread exit notifications.
8392         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8393         Remove thread ID check against main_thread_id.
8394         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8395         windows_delete_thread.
8396         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8397
8398 2019-01-04  Tom Tromey  <tom@tromey.com>
8399
8400         * compile/compile.c (_initialize_compile): Use upper case for
8401         metasyntactic variables.
8402         * symmisc.c (_initialize_symmisc): Use upper case for
8403         metasyntactic variables.
8404         * psymtab.c (_initialize_psymtab): Use upper case for
8405         metasyntactic variables.
8406         * demangle.c (demangle_command): Use upper case for metasyntactic
8407         variables.
8408         (_initialize_demangler): Likewise.
8409         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8410         variables.
8411
8412 2019-01-03  Tom Tromey  <tom@tromey.com>
8413
8414         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8415
8416 2019-01-03  Tom Tromey  <tom@tromey.com>
8417
8418         * python/py-symtab.c (salpy_str): Update.
8419         (struct salpy_sal_object) <symtab>: Now a PyObject.
8420         (salpy_dealloc): Update.
8421         (del_objfile_sal): Use gdbpy_ref.
8422
8423 2019-01-03  Tom Tromey  <tom@tromey.com>
8424
8425         * python/py-type.c (convert_field): Use new_reference.  Return
8426         gdbpy_ref.
8427         (make_fielditem): Return gdbpy_ref.
8428         (typy_fields): Update.
8429         (typy_getitem): Update.
8430         (field_name): Return gdbpy_ref.  Use new_reference.
8431         (typy_iterator_iternext): Update.
8432
8433 2019-01-03  Tom Tromey  <tom@tromey.com>
8434
8435         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8436
8437 2019-01-03  Tom Tromey  <tom@tromey.com>
8438
8439         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8440         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8441         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8442         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8443         (pspy_set_type_printers): Likewise.
8444         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8445         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8446         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8447         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8448         (objfpy_set_type_printers): Likewise.
8449
8450 2019-01-03  Tom Tromey  <tom@tromey.com>
8451
8452         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8453         (gdbpy_print_stack): Use gdbpy_err_fetch.
8454         * python/python-internal.h (class gdbpy_err_fetch): New class.
8455         (class gdbpy_enter) <m_error_type, m_error_value,
8456         m_error_traceback>: Remove.
8457         <m_error>: New member.
8458         (gdbpy_exception_to_string): Don't declare.
8459         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8460         * python/py-value.c (convert_value_from_python): Use
8461         gdbpy_err_fetch.
8462         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8463         gdbpy_exception_to_string.
8464         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8465         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8466         gdbpy_err_fetch.
8467
8468 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8469
8470         * linux-nat.c (delete_lwp_cleanup): Delete.
8471         (struct lwp_deleter): New struct.
8472         (lwp_info_up): New typedef.
8473         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8474         lwp_info_up.
8475
8476 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8477
8478         * linux-fork.c (class scoped_switch_fork_info): New class.
8479         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8480
8481 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8482
8483         * valops.c (find_overload_match): Remove use of null_cleanup, and
8484         calls to do_cleanups.
8485
8486 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8487
8488         * compile/compile-cplus-types.c
8489         (compile_cplus_instance::decl_name): Handle changes to
8490         cp_func_name.
8491         * cp-support.c (cp_func_name): Update header comment, update
8492         return type.
8493         * cp-support.h (cp_func_name): Update return type in declaration.
8494         * valops.c (find_overload_match): Move temp_func local to top
8495         level of function and change its type.  Use temp_func to hold and
8496         delete temporary string obtained from cp_func_name.
8497
8498 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8499
8500         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8501         gdb::char_vector, remove cleanup, and update uses of `msg`.
8502
8503 2019-01-03  Jim Wilson  <jimw@sifive.com>
8504
8505         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8506
8507 2019-01-02  Tom Tromey  <tom@tromey.com>
8508
8509         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8510         (tdesc_parse_xml): Remove cleanups.
8511         * target-descriptions.h (make_cleanup_free_target_description):
8512         Don't declare.
8513         (target_desc_deleter): New struct.
8514         (target_desc_up): New typedef.
8515         * target-descriptions.c (target_desc_deleter::operator()): Rename
8516         from free_target_description.
8517         (make_cleanup_free_target_description): Remove.
8518
8519 2019-01-02  Tom Tromey  <tom@tromey.com>
8520
8521         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8522         constructor, destructor.
8523         (linespec_parser): Remove typedef.
8524         (~linespec_parser): Rename from linespec_parser_delete.
8525         (linespec_lex_to_end, linespec_complete_label)
8526         (linespec_complete): Update.
8527         (decode_line_full): Remove cleanups.
8528         (decode_line_1): Update.
8529
8530 2019-01-02  Tom Tromey  <tom@tromey.com>
8531
8532         * python/python-internal.h (inferior_to_inferior_object): Change
8533         return type.
8534         * python/py-exitedevent.c (create_exited_event_object): Update.
8535         * python/py-inferior.c (inferior_to_inferior_object): Return
8536         gdbpy_ref.
8537         (python_new_inferior, python_inferior_deleted)
8538         (thread_to_thread_object, delete_thread_object)
8539         (build_inferior_list, gdbpy_selected_inferior): Update.
8540         * python/py-infthread.c (create_thread_object): Update.  Also fail
8541         if inferior_to_inferior_object fails.
8542
8543 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8544
8545         * inferior.h (class inferior) <displaced_step_state>: New field.
8546         * infrun.h (struct displaced_step_state): Move here from
8547         infrun.c.  Initialize fields, add constructor.
8548         <inf>: Remove field.
8549         <reset>: New method.
8550         * infrun.c (struct displaced_step_inferior_state): Move to
8551         infrun.h.
8552         (displaced_step_inferior_states): Remove.
8553         (get_displaced_stepping_state): Adust.
8554         (displaced_step_in_progress_any_inferior): Adjust.
8555         (displaced_step_in_progress_thread): Adjust.
8556         (displaced_step_in_progress): Adjust.
8557         (add_displaced_stepping_state): Remove.
8558         (get_displaced_step_closure_by_addr): Adjust.
8559         (remove_displaced_stepping_state): Remove.
8560         (infrun_inferior_exit): Call displaced_step_state.reset.
8561         (use_displaced_stepping): Don't check for NULL.
8562         (displaced_step_prepare_throw): Call
8563         get_displaced_stepping_state.
8564         (displaced_step_fixup): Don't check for NULL.
8565         (prepare_for_detach): Don't check for NULL.
8566
8567 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8568
8569         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8570          in case of call that did not complete.
8571
8572 2019-01-02  Andrey Utkin  <autkin@undo.io>
8573
8574         * symfile.c (find_separate_debug_file): Fix search of debug files for
8575         remote debuggee.
8576
8577 2019-01-02  Tom Tromey  <tom@tromey.com>
8578
8579         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8580         indentation.
8581         * python/py-frame.c (frapy_older): Remove cast.
8582         (frapy_newer): Likewise.
8583         * python/py-breakpoint.c (local_setattro): Remove cast.
8584         * python/py-arch.c (archpy_name): Remove local variable.
8585         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8586
8587 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8588
8589         * unittests/basic_string_view/element_access/char/empty.cc:
8590         Fix year range in copyright header.
8591
8592 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8593
8594         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8595         Delete.
8596         <operator==>: Update with for removed field.
8597         <hash>: Likewise.
8598         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8599         <isa_features>: ...this.
8600         <abi_features>: New field.
8601         (riscv_isa_flen): Update comment.
8602         (riscv_abi_xlen): New declaration.
8603         (riscv_abi_flen): New declaration.
8604         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8605         isa_features.
8606         (riscv_abi_xlen): New function.
8607         (riscv_isa_flen): Update to get answer from isa_features.
8608         (riscv_abi_flen): New function.
8609         (riscv_has_fp_abi): Update to get answer from abi_features.
8610         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8611         xlen and flen.
8612         (riscv_call_info) <xlen, flen>: Update comment.
8613         (riscv_call_arg_struct): Remove invalid assertions
8614         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8615         is removed.
8616         (riscv_gdbarch_init): Gather isa features and abi features
8617         separately, ensure both match on the gdbarch when reusing an old
8618         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8619         a target with 64-bit float hardware.
8620
8621 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8622
8623         * source.c (search_command_helper): Stop reverse search
8624         when line 1 has been searched.
8625
8626 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8627
8628         * record-full.c (record_full_base_target::close): Rewrite
8629         record_full_core_buf_list free logic.
8630
8631 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8632
8633         * break-catch-syscall.c (print_one_catch_syscall): xfree
8634         the last text.
8635
8636 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8637
8638         * top.c (print_gdb_version): Update Copyright year in version
8639         message.
8640
8641 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8642
8643         Update copyright year range in all GDB files.
8644
8645 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8646
8647         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8648
8649 For older changes see ChangeLog-2018.
8650 \f
8651 Local Variables:
8652 mode: change-log
8653 left-margin: 8
8654 fill-column: 74
8655 version-control: never
8656 coding: utf-8
8657 End:
8658