gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
   4
   5 2019-08-30  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-stack.c (_initialize_tui_stack): Move later.
   8         Remove unnecessary forward declarations.
   9
  10 2019-08-30  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
  13         rerender.
  14         (tui_update_locator_fullname, tui_show_frame_info): Don't call
  15         tui_show_locator_content.
  16
  17 2019-08-30  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
  20         (tui_locator_window::rerender): Rewrite using body of previous
  21         tui_show_locator_content.
  22
  23 2019-08-30  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
  26         set_locator_fullname>: New methods.
  27         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  28         Rename from tui_set_locator_fullname.
  29         (tui_locator_window::set_locator_info): Rename from
  30         tui_set_locator_info.  Return bool.
  31         (tui_update_locator_fullname, tui_show_frame_info): Update.
  32
  33 2019-08-30  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  36
  37 2019-08-30  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
  40         call touchwin.
  41
  42 2019-08-30  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-wingeneral.c (box_win): Assume win_info and
  45         win_info->handle cannot be NULL.
  46
  47 2019-08-30  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  50         refresh_window>: Declare.
  51         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  52         resize.
  53         (tui_data_item_window::rerender): Rename from
  54         tui_display_register.
  55         (tui_data_item_window::refresh_window): New method.
  56         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  57         no-op.
  58
  59 2019-08-30  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  62         regs_column_count, current_group>: Move later.  Now private.
  63         <get_current_group>: New method.
  64         * tui/tui-regs.c (tui_reg_command): Update.
  65         * tui/tui-layout.c (tui_set_layout): Update.
  66
  67 2019-08-30  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  70         (tui_data_window::rerender): Don't call
  71         check_and_display_highlight_if_needed.
  72         (tui_data_window::refresh_all): Remove call to
  73         erase_data_content.
  74
  75 2019-08-30  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  78         (tui_data_window::display_registers_from)
  79         (tui_data_window::display_reg_element_at_line)
  80         (tui_data_window::display_registers_from_line): Remove checks of
  81         "empty".
  82
  83 2019-08-30  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
  86         Don't declare.
  87         * tui/tui-regs.c (tui_data_window::show_registers): Call
  88         rerender.
  89         (tui_data_window::rerender): Rename from display_all_data.
  90         (tui_data_window::rerender): Remove old implementation.
  91
  92 2019-08-30  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  95         text.
  96         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  97
  98 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  99             Sergio Durigan Junior  <sergiodj@redhat.com>
 100
 101         PR win32/24284
 102         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 103
 104 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 105
 106         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 107         when searching for types.
 108
 109 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 110
 111         * f-lang.c (f_language_defn): Use f_print_typedef.
 112         * f-lang.h (f_print_typedef): Declare.
 113         * f-typeprint.c (f_print_typedef): Define.
 114
 115 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 116
 117         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 118
 119 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 120
 121         * cli/cli-utils.c (info_print_options_defs): Delete.
 122         (make_info_print_options_def_group): Delete.
 123         (extract_info_print_options): Delete.
 124         (info_print_command_completer): Delete.
 125         (info_print_args_help): Add extra parameter, and optionally
 126         include text about -n flag.
 127         * cli/cli-utils.h (struct info_print_options): Delete.
 128         (extract_info_print_options): Delete declaration.
 129         (info_print_command_completer): Delete declaration.
 130         (info_print_args_help): Add extra parameter, extend header
 131         comment.
 132         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 133         search_symbols.
 134         * stack.c (struct info_print_options): New type.
 135         (info_print_options_defs): New file scoped variable.
 136         (make_info_print_options_def_group): New static function.
 137         (info_print_command_completer): New static function.
 138         (info_locals_command): Update to use new local functions.
 139         (info_args_command): Likewise.
 140         (_initialize_stack): Add extra parameter to calls to
 141         info_print_args_help.
 142         * symtab.c (search_symbols): Add extra parameter, use this to
 143         possibly excluse non-debug symbols.
 144         (symtab_symbol_info): Add extra parameter, which is passed on to
 145         search_symbols.
 146         (struct info_print_options): New type.
 147         (info_print_options_defs): New file scoped variable.
 148         (make_info_print_options_def_group): New static function.
 149         (info_print_command_completer): New static function.
 150         (info_variables_command): Update to use local functions, and pass
 151         extra parameter through to symtab_symbol_info.
 152         (info_functions_command): Likewise.
 153         (info_types_command): Pass additional argument through to
 154         symtab_symbol_info.
 155         (rbreak_command): Pass extra argument to search_symbols.
 156         (_initialize_symtab): Add extra arguments for calls to
 157         info_print_args_help, and update help text for 'info variables',
 158         'whereis', and 'info functions' commands.
 159         * symtab.h (search_symbols): Add extra argument to declaration.
 160         * NEWS: Mention new flags.
 161
 162 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 163
 164         * symtab.c (lookup_static_symbol): Call the new function (and move
 165         it down to be next to lookup_global_symbol).
 166         (struct global_sym_lookup_data): Add block_enum member and rename to...
 167         (struct global_or_static_sym_lookup_data): ...this.
 168         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 169         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 170         (lookup_symbol_global_or_static_iterator_cb): ...this.
 171         (lookup_global_or_static_symbol): New function.
 172         (lookup_global_symbol): Call new function.
 173
 174 2019-08-26  Tom de Vries  <tdevries@suse.de>
 175
 176         PR c++/24852
 177         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 178         when pc_probe.prob == NULL.
 179
 180 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 181
 182         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 183         variable symbol_linkage to symbol_linkage_.
 184
 185 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 186
 187         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 188         represent whether the symbol is static, dynamic, or we don't
 189         know.
 190
 191 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 192
 193         * gdb/rx-tdep.c (rx_register_names): New.
 194         (rx_register_name): Delete.
 195         (rx_psw_type): Delete.
 196         (rx_fpsw_type): Delete.
 197         (rx_register_type): Delete.
 198         (rx_gdbarch_init): Convert target-descriptions.
 199         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 200         * gdb/features/Makefile: Add rx.xml.
 201         * gdb/features/rx.xml: New.
 202         * gdb/features/rx.c: Generated.
 203         * gdb/NEWS: Mention target description support.
 204
 205 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 206
 207         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 208         *slot_ptr.
 209
 210 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 211
 212         * configure.ac: Don't check for 'dlfcn.h' (moved to
 213         gdbsupport/common.m4).
 214         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 215         'gdbsupport/'.
 216         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 217         * compile/compile-c-support.c: Include
 218         'gdbsupport/gdb-dlfcn.h'.
 219         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 220         * gdb-dlfcn.c: Move to...
 221         * gdbsupport/gdb-dlfcn.c: ... here.
 222         * gdb-dlfcn.h: Move to...
 223         * gdbsupport/gdb-dlfcn.h: ... here.
 224
 225 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 226
 227         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 228         the offset field signed.
 229
 230 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 231
 232         * python/lib/gdb/__init__.py (_execute_file): New function.
 233         * python/python.c (python_run_simple_file): Call gdb._execute_file
 234         on Windows.
 235
 236 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 239         all uses as this was never set to anything but a zero value.
 240
 241 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 242
 243         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 244
 245 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 246
 247         * tui/tui-data.h (tui_gen_win_info): Add an =default
 248         move constructor, required by some GCC versions.
 249
 250 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 251
 252         * go32-nat.c (go32_sysinfo): Add hygon_p.
 253
 254 2019-08-20  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 257         line_from_reg_element_no, first_reg_element_no_inline,
 258         display_all_data, delete_data_content_windows,
 259         erase_data_content>: Now private.
 260
 261 2019-08-20  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 264         (tui_unhighlight_win, tui_highlight_win)
 265         (tui_win_info::make_window): Update.
 266         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 267
 268 2019-08-20  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 271         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 272         (MAX_PID_WIDTH): Move to tui-stack.c.
 273         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 274         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 275         (MAX_PID_WIDTH): Move from tui-data.h.
 276
 277 2019-08-20  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 280         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 281         (box_win): Update.
 282         (tui_gen_win_info::make_window): Rename from tui_make_window.
 283         (tui_win_info::make_window): New method.
 284         (tui_gen_win_info::make_visible): Update.
 285         * tui/tui-source.c (tui_source_window::set_contents): Update.
 286         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 287         (tui_data_window::display_registers_from): Update.
 288         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 289         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 290         Declare.
 291         <can_box>: Remove.
 292         <title>: Remove.
 293         (struct tui_win_info) <make_window>: Declare.
 294         <can_box>: Now virtual.
 295         <title>: New member.
 296         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 297         * tui/tui-command.c (tui_cmd_window::resize): Update.
 298
 299 2019-08-20  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 302         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 303         (tui_data_window::check_register_values): Update.
 304
 305 2019-08-20  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-regs.h (struct tui_data_window): Use
 308         DISABLE_COPY_AND_ASSIGN.
 309         <regs_content>: Change type, removing unique_ptr.
 310         <tui_data_window>: Add move constructor.
 311         * tui/tui-regs.c (tui_data_window::show_registers)
 312         (tui_data_window::show_register_group)
 313         (tui_data_window::display_registers_from)
 314         (tui_data_window::display_registers_from)
 315         (tui_data_window::first_data_item_displayed)
 316         (tui_data_window::delete_data_content_windows)
 317         (tui_data_window::rerender, tui_data_window::refresh_window)
 318         (tui_data_window::check_register_values): Update.
 319
 320 2019-08-20  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 323         show_register_group>: Declare.
 324         (tui_show_register_group): Don't declare.
 325         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 326         tui_show_registers.
 327         (tui_data_window::show_register_group): Rename from
 328         tui_show_register_group.
 329         (tui_data_window::check_register_values, tui_reg_command):
 330         Update.
 331         * tui/tui-layout.c (tui_set_layout): Update.
 332
 333 2019-08-20  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 336         Declare.
 337         (tui_check_register_values): Don't declare.
 338         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 339         from tui_check_register_values.
 340         * tui/tui-hooks.c (tui_register_changed): Update.
 341
 342 2019-08-20  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-regs.c (tui_reg_layout): Move later.
 345         (tui_show_registers): Don't enable TUI mode or change layout.
 346
 347 2019-08-20  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-regs.h (struct tui_data_item_window)
 350         <~tui_data_item_window>: Remove.
 351         <content>: Now a unique_xmalloc_ptr.
 352         * tui/tui-regs.c (tui_register_format): Return a
 353         unique_xmalloc_ptr.
 354         (tui_get_register): Update.
 355         (~tui_data_item_window): Remove.
 356         (tui_data_window::display_registers_from, tui_display_register):
 357         Update.
 358         * tui/tui-io.h (tui_expand_tabs): Update.
 359         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 360         Remove "col" parameter.
 361
 362 2019-08-20  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 365         field.
 366         * tui/tui-regs.c (~tui_data_item_window): Update.
 367
 368 2019-08-20  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 371         earlier.
 372
 373 2019-08-20  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 376
 377 2019-08-20  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-source.h (struct tui_source_window): Update.
 380         * tui/tui-regs.c (tui_show_registers): Update.
 381         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 382         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 383         (NO_REGS_STRING): Remove defines.
 384
 385 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 386
 387         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 388         unnecessary thread walk if remote doesn't support the packet.
 389
 390 2019-08-19  Tom Tromey  <tromey@adacore.com>
 391
 392         * python/py-value.c (value_has_field): Fix indentation.
 393
 394 2019-08-19  Tom Tromey  <tromey@adacore.com>
 395
 396         * printcmd.c (do_one_display, info_display_command): Update.
 397         * block.h (contained_in): Return bool.  Add allow_nested
 398         parameter.
 399         * block.c (contained_in): Return bool.  Add allow_nested
 400         parameter.
 401
 402 2019-08-19  Tom Tromey  <tom@tromey.com>
 403
 404         * configure: Rebuild.
 405         * configure.ac: Disallow the combination of -static-libstdc++ and
 406         source highlight.
 407         * source-cache.c (get_language_name): Handle rust.
 408         (source_cache::get_source_lines): Ignore highlighting exceptions.
 409
 410 2019-08-16  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 413         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 414         (struct tui_source_window_base) <make_visible, refresh_window,
 415         resize>: Remove methods.
 416         <execution_info>: Remove field.
 417         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 418         (tui_show_source_line, tui_source_window_base)
 419         (~tui_source_window_base): Update.
 420         (tui_source_window_base::resize)
 421         (tui_source_window_base::make_visible)
 422         (tui_source_window_base::refresh_window): Remove.
 423         (tui_source_window_base::update_exec_info): Update.
 424         * tui/tui-source.c (tui_source_window::set_contents): Update.
 425         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 426
 427 2019-08-16  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 430         deprecated_query_hook.
 431
 432 2019-08-16  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 435         (tui_update_source_windows_with_line): Update.
 436         * tui/tui-source.h (struct tui_source_window)
 437         <show_symtab_source>: Declare.
 438         (tui_show_symtab_source): Don't declare.
 439         * tui/tui-source.c (tui_show_symtab_source): Rename from
 440         tui_show_symtab_source.
 441
 442 2019-08-16  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui-winsource.h (struct tui_source_window_base)
 445         <set_contents>: Declare.
 446         * tui/tui-winsource.c
 447         (tui_source_window_base::update_source_window_as_is): Update.
 448         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 449         Declare.
 450         (tui_set_source_content): Don't declare.
 451         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 452         tui_set_source_content.
 453         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 454         Declare.
 455         (tui_set_disassem_content): Don't declare.
 456         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 457         tui_set_disassem_content.
 458
 459 2019-08-16  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-winsource.h (struct tui_source_window_base)
 462         <update_breakpoint_info>: Declare.
 463         (tui_update_breakpoint_info): Don't declare.
 464         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 465         (tui_update_all_breakpoint_info): Update.
 466         (tui_source_window_base::update_breakpoint_info): Rename from
 467         tui_update_breakpoint_info.
 468         (tui_source_window_base::update_exec_info): Update.
 469
 470 2019-08-16  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-winsource.h (struct tui_source_window_base)
 473         <update_source_window>: Declare.
 474         (tui_update_source_window): Don't declare.
 475         * tui/tui-winsource.c
 476         (tui_source_window_base::update_source_window): Rename from
 477         tui_update_source_window.
 478         (tui_source_window_base::rerender): Update.
 479         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 480         * tui/tui-disasm.c (tui_show_disassem)
 481         (tui_show_disassem_and_update_source)
 482         (tui_disasm_window::maybe_update): Update.
 483
 484 2019-08-16  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-winsource.h (struct tui_source_window_base)
 487         <update_source_window_as_is>: Declare.
 488         (tui_update_source_window_as_is): Don't declare.
 489         * tui/tui-winsource.c (tui_update_source_window): Update
 490         (tui_source_window_base::update_source_window_as_is): Rename from
 491         tui_update_source_window_as_is.
 492         (tui_source_window_base::refill): Update.
 493         * tui/tui-source.c (tui_show_symtab_source): Update.
 494         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 495         Update.
 496
 497 2019-08-16  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-winsource.h (tui_update_source_window)
 500         (tui_update_source_window_as_is): Remove "noerror" parameter.
 501         * tui/tui-winsource.c (tui_update_source_window)
 502         (tui_update_source_window_as_is): Remove "noerror" parameter.
 503         (tui_update_source_windows_with_addr)
 504         (tui_update_source_windows_with_line)
 505         (tui_source_window_base::rerender)
 506         (tui_source_window_base::refill): Update.
 507         * tui/tui-source.h (tui_set_source_content)
 508         (tui_show_symtab_source): Remove "noerror" parameter.
 509         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 510         parameter.
 511         (tui_show_symtab_source): Likewise.
 512         (tui_source_window::maybe_update): Update.
 513         * tui/tui-disasm.c (tui_show_disassem)
 514         (tui_show_disassem_and_update_source)
 515         (tui_disasm_window::do_scroll_vertical)
 516         (tui_disasm_window::maybe_update): Update.
 517
 518 2019-08-16  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui.c (tui_is_window_visible): Update.
 521         * tui/tui-wingeneral.c (tui_make_window)
 522         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 523         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 524         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 525         (tui_set_win_height_command, parse_scrolling_args): Update.
 526         * tui/tui-source.c (tui_source_window::style_changed): Update.
 527         * tui/tui-regs.c (tui_show_registers)
 528         (tui_data_window::first_data_item_displayed)
 529         (tui_data_window::delete_data_content_windows)
 530         (tui_check_register_values, tui_reg_command): Update.
 531         * tui/tui-disasm.c (tui_show_disassem): Update.
 532         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 533         method.
 534         <is_visible>: Remove field.
 535         * tui/tui-data.c (tui_next_win, tui_prev_win)
 536         (tui_delete_invisible_windows): Update.
 537
 538 2019-08-16  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-winsource.h (struct tui_source_window_base)
 541         <m_has_locator>: Remove.
 542         * tui/tui-layout.c (show_source_disasm_command, show_data)
 543         (show_source_or_disasm_and_command): Update.
 544
 545 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 546
 547         * NEWS (Other MI changes): New subsection.
 548         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 549         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 550         * arch-utils.c (default_get_pc_address_flags): New function.
 551         * arch-utils.h (default_get_pc_address_flags): New declaration.
 552         * gdbarch.sh: Add get_pc_address_flags.
 553         * gdbarch.c: Regenerate.
 554         * gdbarch.h: Likewise.
 555         * stack.c (print_pc): New function.
 556         (print_frame_info) (print_frame): Call print_pc.
 557
 558 2019-08-16  Tom de Vries  <tdevries@suse.de>
 559
 560         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 561         print_objfile_section_info.
 562
 563 2019-08-15  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 566         calling update_cmdwin_start_line.
 567         * tui/tui-winsource.h (struct tui_source_window_base)
 568         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 569         <rerender>: Declare.
 570         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 571         Call rerender.
 572         (tui_source_window_base::set_new_height): Remove.
 573         (tui_source_window_base::rerender): Rename from
 574         do_make_visible_with_new_height.
 575         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 576         resize method.
 577         (tui_win_info::make_invisible_and_set_new_height)
 578         (tui_win_info::make_visible_with_new_height): Remove.
 579         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 580         Declare.
 581         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 582         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 583         do_make_visible_with_new_height>: Don't declare.
 584         <rerender>: Declare.
 585         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 586         set_new_height.
 587         (tui_data_window::do_make_visible_with_new_height): Remove.
 588         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 589         call tui_show_locator_content.
 590         (tui_gen_win_info::resize): Call rerender.
 591         (show_source_or_disasm_and_command): Don't call
 592         tui_show_locator_content.
 593         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 594         method.
 595         (struct tui_win_info) <rerender>: Declare.
 596         <set_new_height, make_invisible_and_set_new_height,
 597         make_visible_with_new_height>: Don't declare.
 598         * tui/tui-data.c (tui_win_list::rerender): New method.
 599         * tui/tui-command.h (struct tui_cmd_window)
 600         <do_make_visible_with_new_height>: Don't declare.
 601         * tui/tui-command.c
 602         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 603
 604 2019-08-15  Tom Tromey  <tromey@adacore.com>
 605
 606         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 607         * ada-lang.c (ada_enum_name): Likewise.
 608
 609 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 610
 611         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 612         leading underscore.
 613         (GdbOutputErrorFile): Likewise.
 614         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 615         accordingly.
 616         (execute_unwinders): Rename to have a leading underscore.
 617         (auto_load_packages): Likewise.
 618         (global scope): Adjust call to auto_load_packages accordingly.
 619         (GdbSetPythonDirectory): Likewise.
 620         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 621         instead of execute_unwinders.
 622
 623 2019-08-15  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 626         (show_data): Don't change window visibility.
 627         (tui_gen_win_info::resize): Remove special case for command
 628         window.  Use wresize, when available.
 629         (show_source_or_disasm_and_command): Don't change window
 630         visibility.
 631         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 632         <make_visible>: New method.
 633         * tui/tui-command.c (tui_cmd_window::resize): New method.
 634
 635 2019-08-15  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 638         (struct tui_source_windows): New.
 639         * tui/tui-winsource.c (tui_display_main): Update.
 640         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 641         (new_height_ok, parse_scrolling_args): Update.
 642         * tui/tui-layout.c (show_layout, show_data): Update.
 643         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 644         (tui_add_to_source_windows): Don't declare.
 645         * tui/tui-data.c (source_windows, tui_source_windows)
 646         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 647
 648 2019-08-15  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 651         Rename from reset.
 652         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 653         * tui/tui-layout.c (show_source_disasm_command, show_data):
 654         Update.
 655         (tui_gen_win_info::resize): Rename.
 656         (show_source_or_disasm_and_command): Update.
 657         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 658         reset.
 659
 660 2019-08-15  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 663         * tui/tui-interp.c (tui_interp::init): Don't call
 664         tui_initialize_static_data.
 665         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 666
 667 2019-08-15  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 670         examine tui_win_list.
 671
 672 2019-08-15  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 675         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 676         tui_clear_source_content.
 677         (tui_clear_source_content): Remove.
 678         (tui_source_window_base::do_erase_source_content): Hoist call to
 679         content.clear().
 680         * tui/tui-stack.c (tui_show_frame_info): Don't call
 681         tui_clear_source_content.
 682
 683 2019-08-15  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-winsource.h (struct tui_source_window_base)
 686         <do_erase_source_content>: New method.
 687         <erase_source_content>: New method.
 688         (tui_erase_source_content): Don't declare.
 689         * tui/tui-winsource.c (tui_clear_source_content): Update.
 690         (tui_source_window_base::do_erase_source_content): Rename from
 691         tui_erase_source_content.
 692         (tui_source_window_base::show_source_content): Update.
 693         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 694         * tui/tui-source.h (struct tui_source_window)
 695         <erase_source_content>: New method.
 696         * tui/tui-disasm.h (struct tui_disasm_window)
 697         <erase_source_content>: New method.
 698
 699 2019-08-15  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 702         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 703         constructor.
 704         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 705         * tui/tui-source.c (tui_set_source_content): Update.
 706         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 707
 708 2019-08-15  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 711         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 712         tui-source.c.
 713         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 714         Declare.
 715         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 716         method.
 717         (tui_source_window::maybe_update): Update.
 718
 719 2019-08-15  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 722         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 723         tui-disasm.c.
 724         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 725         Declare.
 726         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 727         method.
 728         (tui_disasm_window::maybe_update): Update.
 729
 730 2019-08-15  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-winsource.h (struct tui_source_window_base)
 733         <maybe_update>: Declare.
 734         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 735         method.
 736         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 737         Declare.
 738         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 739         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 740         Declare.
 741         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 742
 743 2019-08-15  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 746
 747 2019-08-15  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-wingeneral.c: Include tui-stack.h.
 750         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 751         (struct tui_locator_window): Move from tui-data.h.
 752         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 753         (tui_initialize_static_data): Move from tui-data.c.
 754         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 755         (struct tui_locator_window): Move to tui-stack.c.
 756         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 757         (tui_initialize_static_data): Move to tui-stack.c.
 758
 759 2019-08-15  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-layout.c (show_source_disasm_command)
 762         (show_source_or_disasm_and_command): Use make_visible method, not
 763         tui_make_window.
 764         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 765         Remove.
 766
 767 2019-08-15  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-wingeneral.h (tui_make_window): Update.
 770         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 771         parameter.
 772         (tui_gen_win_info::make_visible): Update.
 773         * tui/tui-regs.c (tui_data_window::display_registers_from):
 774         Update.
 775         * tui/tui-layout.c (show_source_disasm_command)
 776         (show_source_or_disasm_and_command): Update.
 777         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 778         (enum tui_box): Remove.
 779         (struct tui_win_info) <can_box>: New method.
 780         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 781         method.
 782
 783 2019-08-15  Tom de Vries  <tdevries@suse.de>
 784
 785         * linux-nat-trad.c: Include gdbarch.h.
 786
 787 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 788
 789         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 790         register sizes.
 791
 792 2019-08-14  Tom Tromey  <tromey@adacore.com>
 793
 794         * darwin-nat.c: Include gdbarch.h.
 795         * darwin-nat-info.c: Include gdbarch.h.
 796
 797 2019-08-13  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 800         Remove.
 801         * tui/tui-data.c (tui_initialize_static_data): Update.
 802
 803 2019-08-13  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-winsource.h (struct tui_exec_info_window)
 806         <~tui_exec_info_window, maybe_allocate_content, get_content,
 807         m_content>: Remove.
 808         (struct tui_source_window_base) <set_exec_info_content,
 809         show_exec_info_content>: Don't declare.
 810         * tui/tui-winsource.c
 811         (tui_exec_info_window::maybe_allocate_content): Remove.
 812         (tui_source_window_base::update_exec_info): Rename from
 813         set_exec_info_content.
 814         (tui_source_window_base::show_exec_info_content)
 815         (tui_source_window_base::update_exec_info): Remove.
 816
 817 2019-08-13  Tom Tromey  <tom@tromey.com>
 818
 819         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 820         declare.
 821         * tui/tui-winsource.c (tui_update_source_window_as_is)
 822         (tui_update_source_windows_with_addr, tui_erase_source_content):
 823         Update.
 824         (tui_clear_exec_info_content): Remove.
 825
 826 2019-08-13  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 829         declare.
 830         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 831         call tui_erase_exec_info_content.
 832         (tui_clear_exec_info_content): Rename from
 833         tui_erase_exec_info_content.
 834         (tui_clear_exec_info_content): Delete.
 835
 836 2019-08-13  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-winsource.h (struct tui_source_window_base)
 839         <show_exec_info_content>: Declare.
 840         (tui_show_exec_info_content): Don't declare.
 841         * tui/tui-winsource.c
 842         (tui_source_window_base::show_exec_info_content): Rename from
 843         tui_show_exec_info_content.
 844         (tui_source_window_base::update_exec_info): Update.
 845
 846 2019-08-13  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 849         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 850         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 851         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 852         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 853         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 854         ... here.
 855
 856 2019-08-13  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-winsource.h (struct tui_source_window_base)
 859         <update_exec_info>: Declare.
 860         (tui_update_exec_info): Don't declare.
 861         * tui/tui-winsource.c (tui_update_source_window_as_is)
 862         (tui_source_window_base::refresh_all)
 863         (tui_update_all_breakpoint_info): Update.
 864         (tui_source_window_base::update_exec_info): Rename from
 865         tui_update_exec_info.
 866         * tui/tui-stack.c (tui_show_frame_info): Update.
 867
 868 2019-08-13  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-winsource.h (struct tui_source_window_base)
 871         <set_exec_info_content>: Declare.
 872         (tui_set_exec_info_content): Don't declare.
 873         * tui/tui-winsource.c
 874         (tui_source_window_base::set_exec_info_content): Rename from
 875         tui_set_exec_info_content.
 876         (tui_update_exec_info): Update.
 877
 878 2019-08-13  Tom Tromey  <tom@tromey.com>
 879
 880         * tui/tui-winsource.h (struct tui_source_window_base)
 881         <show_source_content>: Declare.
 882         (tui_show_source_content): Don't declare.
 883         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 884         (tui_source_window_base::show_source_content): Rename from
 885         tui_show_source_content.
 886         (tui_source_window_base::refresh_all): Update.
 887         * tui/tui-layout.c (show_source_disasm_command)
 888         (show_source_or_disasm_and_command): Update.
 889
 890 2019-08-13  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-winsource.c (tui_erase_source_content)
 893         (tui_show_source_content, tui_source_window_base::refresh_all):
 894         Update.
 895         * tui/tui-wingeneral.h
 896         (tui_check_and_display_highlight_if_needed): Don't declare.
 897         * tui/tui-wingeneral.c
 898         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 899         check_and_display_highlight_if_needed.
 900         * tui/tui-win.c (tui_rehighlight_all)
 901         (tui_win_info::make_visible_with_new_height): Update.
 902         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 903         (tui_data_window::erase_data_content)
 904         (tui_data_window::display_all_data): Update.
 905         * tui/tui-data.h (struct tui_win_info)
 906         <check_and_display_highlight_if_needed>: Declare.
 907
 908 2019-08-13  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-win.c (tui_resize_all): Call
 911         tui_delete_invisible_windows.
 912         * tui/tui-layout.c (show_layout): Call
 913         tui_delete_invisible_windows.
 914         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 915         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 916
 917 2019-08-13  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 920         tui_add_win_to_layout.
 921
 922 2019-08-13  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 925         * tui/tui-layout.c (tui_default_win_height): Now static.
 926
 927 2019-08-13  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 930         single switch.
 931         (show_source_disasm_command, show_source_or_disasm_and_command):
 932         Don't check current layout.
 933
 934 2019-08-13  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-wingeneral.c (make_all_visible): Remove.
 937         (tui_make_all_invisible): Simplify.
 938         * tui/tui-layout.c (tui_make_all_invisible): Move from
 939         tui-wingeneral.c; simplify.
 940         (show_layout): Hoist call to tui_make_all_invisible.
 941         (show_data): Don't call tui_make_all_invisible.
 942
 943 2019-08-13  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 946         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 947
 948 2019-08-13  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 951         tui-data.c.
 952         (show_source_disasm_command, show_data)
 953         (show_source_or_disasm_and_command): Don't use
 954         tui_set_current_layout_to.
 955         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 956         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 957         tui-layout.c.
 958         (tui_set_current_layout_to): Remove.
 959
 960 2019-08-13  Tom Tromey  <tom@tromey.com>
 961
 962         * tui/tui-layout.c (tui_set_layout): Update.
 963         * tui/tui-data.h (struct tui_layout_def): Remove.
 964         (tui_layout_def): Don't declare.
 965         * tui/tui-data.c (layout_def): Remove.
 966         (tui_layout_def): Remove.
 967
 968 2019-08-13  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-winsource.h (struct tui_source_window_base)
 971         <clear_detail>: No longer "override".
 972         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 973         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 974         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 975         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 976         Remove.
 977         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 978
 979 2019-08-13  Tom Tromey  <tromey@adacore.com>
 980
 981         * tracepoint.c: Don't include readline.h or history.h.
 982
 983 2019-08-12  Tom Tromey  <tom@tromey.com>
 984
 985         * configure: Rebuild.
 986         * configure.ac: Check for readline 7.
 987         * NEWS: Mention readline 7 requirement.
 988         * README: Update.
 989
 990 2019-08-12  Tom Tromey  <tom@tromey.com>
 991
 992         * mingw-hdep.c (gdb_select): Remove readline hack.
 993
 994 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 995
 996         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 997         when the function fails.
 998
 999 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1000
1001         * s390-tdep.c (s390_type_align): New function.
1002         (s390_gdbarch_init): Set it as type_align gdbarch method.
1003
1004 2019-08-09  Tom de Vries  <tdevries@suse.de>
1005
1006         PR gdb/24591
1007         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1008         pc_low with relocation offset.
1009
1010 2019-08-07  Tom Tromey  <tromey@adacore.com>
1011
1012         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1013         (print_frame_args): Update.
1014         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1015         Update.
1016         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1017         * frame.h (struct frame_arg): Add initializers.
1018         <error>: Now a unique_xmalloc_ptr.
1019
1020 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1021
1022         * NEWS: Expand the Pointer Authentication entry.
1023         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1024         (aarch64_frame_unmask_lr): ... to this.
1025         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1026         Call aarch64_frame_unmask_lr.
1027         * frame.c (struct frame_info): Add "masked" variable.
1028         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1029         (fprint_frame): Check for masked pc.
1030         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1031         declarations.
1032         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1033         * stack.c (print_frame): Check for masked pc.
1034
1035 2019-08-06  Tom Tromey  <tom@tromey.com>
1036
1037         * stabsread.c (patch_block_stabs, read_one_struct_field)
1038         (read_enum_type): Use obstack_strndup.
1039         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1040         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1041         * dwarf2read.c (guess_full_die_structure_name)
1042         (anonymous_struct_prefix): Use obstack_strndup.
1043         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1044         * c-exp.y (yylex): Use obstack_strndup.
1045         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1046         (write_var_or_type): Use obstack_strndup.
1047
1048 2019-08-06  Tom Tromey  <tom@tromey.com>
1049
1050         * symfile.c (reread_symbols): Use obstack_strdup.
1051         * stabsread.c (read_type): Use obstack_strdup.
1052         * gdb_obstack.h (obstack_strdup): New overload.
1053         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1054         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1055         (dwarf2_canonicalize_name): Use obstack_strdup.
1056         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1057         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1058         Use obstack_strdup.
1059
1060 2019-08-06  Tom Tromey  <tom@tromey.com>
1061
1062         * gdb_obstack.h (obstack_strdup): Define.
1063         * gdb_obstack.c (obstack_strdup): Don't define.
1064
1065 2019-08-06  Tom Tromey  <tom@tromey.com>
1066
1067         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1068         obstack_strdup.
1069         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1070         obstack_strdup.
1071         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1072         * stabsread.c (common_block_start): Use obstack_strdup.
1073         * objfiles.c (set_objfile_main_name, objfile): Use
1074         obstack_strdup.
1075         * namespace.c (add_using_directive): Use obstack_strdup.
1076         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1077         * jit.c (finalize_symtab): Use obstack_strdup.
1078         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1079         (guess_partial_die_structure_name, partial_die_info::fixup)
1080         (dwarf2_name): Use obstack_strdup.
1081         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1082         obstack_strdup.
1083         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1084         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1085         obstack_strdup.
1086         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1087
1088 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1089
1090         * unittests/help-doc-selftests.c: New file.
1091         * Makefile.in: Add the new file.
1092
1093 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1094
1095         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1096         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1097         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1098         the trailing '.' is not output, and the first character is uppercased.
1099         (print_help_for_command): Update call to print_doc_line.
1100         (print_doc_of_command): Likewise.
1101         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1102         * cli/cli-option.c (append_indented_doc): Do not append newline.
1103         (build_help_option): Append newline after first appended_indented_doc
1104         only if a second call is done.
1105         (build_help): Append 2 new lines before each option, except the first
1106         one.
1107         * compile/compile.c (_initialize_compile): Add new lines after
1108         %OPTIONS%, when not at the end of the help.
1109         Change help doc or code
1110         producing the help doc to respect the invariants.
1111         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1112         Also removed the new line after 'Options:', as all other commands
1113         do not put an empty line between 'Options:' and the first option.
1114         * printcmd.c (_initialize_printcmd): Likewise.
1115         * stack.c (_initialize_stack): Likewise.
1116         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1117         incorrectly telling COMMAND is optional.
1118         * ada-lang.c (_initialize_ada_language): Change help doc or code
1119         producing the help doc to respect the invariants.
1120         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1121         * breakpoint.c (_initialize_breakpoint): Likewise.
1122         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1123         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1124         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1125         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1126         _initialize_cli_style): Likewise.
1127         * corelow.c (core_target_info): Likewise.
1128         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1129         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1130         * filesystem.c (_initialize_filesystem): Likewise.
1131         * frame.c (_initialize_frame): Likewise.
1132         * gnu-nat.c (add_task_commands): Likewise.
1133         * infcall.c (_initialize_infcall): Likewise.
1134         * infcmd.c (_initialize_infcmd): Likewise.
1135         * interps.c (_initialize_interpreter): Likewise.
1136         * language.c (_initialize_language): Likewise.
1137         * linux-fork.c (_initialize_linux_fork): Likewise.
1138         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1139         * maint.c (_initialize_maint_cmds): Likewise.
1140         * memattr.c (_initialize_mem): Likewise.
1141         * printcmd.c (_initialize_printcmd): Likewise.
1142         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1143         _RegEx): Likewise.
1144         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1145         * record-btrace.c (_initialize_record_btrace): Likewise.
1146         * record-full.c (_initialize_record_full): Likewise.
1147         * record.c (_initialize_record): Likewise.
1148         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1149         * regcache.c (_initialize_regcache): Likewise.
1150         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1151         _initialize_remote): Likewise.
1152         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1153         * serial.c (_initialize_serial): Likewise.
1154         * skip.c (_initialize_step_skip): Likewise.
1155         * source.c (_initialize_source): Likewise.
1156         * stack.c (_initialize_stack): Likewise.
1157         * symfile.c (_initialize_symfile): Likewise.
1158         * symtab.c (_initialize_symtab): Likewise.
1159         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1160         * top.c (init_main): Likewise.
1161         * tracefile-tfile.c (tfile_target_info): Likewise.
1162         * tracepoint.c (_initialize_tracepoint): Likewise.
1163         * tui/tui-win.c (_initialize_tui_win): Likewise.
1164         * utils.c (add_internal_problem_command): Likewise.
1165         * valprint.c (value_print_option_defs): Likewise.
1166
1167 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1168
1169         PR build/24886
1170         * configure.ac: Drop enable-libmcheck support.
1171         * configure, config.in: Rebuild.
1172         * libmcheck.m4: Remove.
1173         * acinclude.m4: Don't include it.
1174         * Makefile.in: Don't distribute it.
1175         * top.c (print_gdb_configuration): Don't mention it.
1176
1177 2019-08-06  Tom Tromey  <tom@tromey.com>
1178
1179         * utils.c (set_output_style): Sometimes pass stream to
1180         emit_style_escape.
1181         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1182         * record-btrace.c (btrace_insn_history): Update.
1183         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1184         method.
1185         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1186         Update initializers.
1187         <m_uiout>: New field.
1188         <m_di>: Move lower.
1189         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1190         Remove "uiout" parameter.
1191         (dump_insns): Update.
1192         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1193         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1194
1195 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1196
1197         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1198         (error_in_psymtab_expansion): Likewise.
1199         (lookup_symbol_via_quick_fns): Likewise.
1200         (basic_lookup_transparent_type_quick): Likewise.
1201         (basic_lookup_transparent_type_1): Likewise.
1202
1203 2019-08-06  Tom Tromey  <tromey@adacore.com>
1204
1205         * source.c (last_source_error): Now bool.
1206         (print_source_lines_base): Make "noprint" bool.  Only open
1207         source file when last_source_visited changes.
1208
1209 2019-08-06  Tom Tromey  <tromey@adacore.com>
1210
1211         * annotate.c (annotate_source_line): Use g_source_cache.
1212         * source-cache.c (source_cache::get_plain_source_lines): Change
1213         parameters.  Populate m_offset_cache.
1214         (source_cache::ensure): New method.
1215         (source_cache::get_line_charpos): New method.
1216         (extract_lines): Move lower.  Change parameters.
1217         (source_cache::get_source_lines): Move lower.
1218         * source-cache.h (class source_cache): Update comment.
1219         <get_line_charpos>: New method.
1220         <get_source_lines>: Update comment.
1221         <clear>: Clear m_offset_cache.
1222         <get_plain_source_lines>: Change parameters.
1223         <ensure>: New method
1224         <m_offset_cache>: New member.
1225         * source.c (forget_cached_source_info_for_objfile): Update.
1226         (info_source_command): Use g_source_cache.
1227         (find_source_lines, open_source_file_with_line_charpos): Remove.
1228         (print_source_lines_base, search_command_helper): Use g_source_cache.
1229         * source.h (open_source_file_with_line_charpos): Don't declare.
1230         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1231         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1232         Use g_source_cache.
1233
1234 2019-08-06  Tom Tromey  <tromey@adacore.com>
1235
1236         * source-cache.c (source_cache::get_plain_source_lines):
1237         Remove "first_line" and "last_line" parameters.
1238         (source_cache::get_source_lines): Cache plain text.
1239         * source-cache.h (class source_cache)
1240         <get_plain_source_lines>: Update.
1241
1242 2019-08-06  Tom Tromey  <tromey@adacore.com>
1243
1244         * source-cache.c (extract_lines): No longer a method.
1245         Changed type of parameter.  Include final newline.
1246         (selftests::extract_lines_test): New function.
1247         (_initialize_source_cache): Likewise.
1248         * source-cache.h (class source_cache)
1249         <extract_lines>: Don't declare.
1250
1251 2019-08-06  Tom Tromey  <tromey@adacore.com>
1252
1253         * breakpoint.c (init_breakpoint_sal): Update.
1254         (breakpoint): Update.
1255         * breakpoint.h (struct breakpoint) <filter>: Now a
1256         unique_xmalloc_ptr.
1257
1258 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1259
1260         * NEWS: Mention dictionary access on blocks.
1261         * python/py-block.c (blpy_getitem): New function.
1262         (block_object_as_mapping): New struct.
1263         (block_object_type): Use new struct for tp_as_mapping field.
1264
1265 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1266
1267         * objfiles.h (objfile): Add a comment describing partial symbols.
1268
1269 2019-08-05  Tom Tromey  <tromey@adacore.com>
1270
1271         * compile/compile.c (_initialize_compile): Use _(), not N_().
1272         * thread.c (_initialize_thread): Use _(), not N_().
1273         * stack.c (_initialize_stack): Use _(), not N_().
1274         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1275
1276 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1277
1278         * dwarf2read.c (struct dw2_symtab_iterator):
1279         <want_specific_block>: Remove.
1280         <block_index>: Change type to gdb::optional.
1281         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1282         change type of BLOCK_INDEX parameter to gdb::optional.
1283         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1284         (dw2_lookup_symbol): Don't pass argument for
1285         WANT_SPECIFIC_BLOCK.
1286         (dw2_expand_symtabs_for_function): Don't pass argument for
1287         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1288         (class dw2_debug_names_iterator)
1289         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1290         parameter, change BLOCK_INDEX type to gdb::optional.
1291         <m_want_specific_block>: Remove.
1292         <m_block_index>: Change type to gdb::optional.
1293         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1294         gdb::optional.  Re-write in function of gdb::optional.
1295         (dw2_debug_names_lookup_symbol): Don't pass argument for
1296         WANT_SPECIFIC_BLOCK.
1297         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1298         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1299         BLOCK_INDEX.
1300
1301 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1302
1303         * NEWS: Mention changes to "info sources" command.
1304
1305 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1306
1307         * symtab.c (filename_partial_match_opts): New struct type.
1308         (struct output_source_filename_data): New members
1309         regexp, c_regexp, partial_match.
1310         (output_source_filename): Use new members to decide to print file.
1311         (info_sources_option_defs): New variable.
1312         (make_info_sources_options_def_group, print_info_sources_header,
1313         info_sources_command_completer):
1314         New functions.
1315         (info_sources_command): Read new optional arguments.
1316         (_initialize_symtab): Update info sources help.
1317
1318 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1319
1320         * ada-lang.c (exception_support_info_v0): Renamed from...
1321         (default_exception_support_info): ... this.  Create new
1322         definition for v1.
1323         (ada_has_this_exception_support): Look up catch_handlers_sym.
1324         (ada_exception_support_info_sniffer): Try v0 after default.
1325
1326 2019-08-01  Tom Tromey  <tromey@adacore.com>
1327
1328         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1329         gdbarch.h.
1330
1331 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1332
1333         * s12z-tdep.c: Fix include path for s12z-opc.h.
1334
1335 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1336
1337         * NEWS: Require GNU make 3.82.
1338
1339 2019-07-16  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1342         declare.
1343
1344 2019-07-30  Tom Tromey  <tromey@adacore.com>
1345
1346         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1347
1348 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1349
1350         * printcmd.c (print_address_symbolic): Print negative offsets.
1351         (build_address_symbolic): Force signed arithmetic when computing
1352         offset.
1353
1354 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1355
1356         PR/24474: Add a function to lookup static variables.
1357         * NEWS: Mention this new function.
1358         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1359         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1360         * python/python.c (python_GdbMethods): Add new function.
1361
1362 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1363
1364         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1365         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1366         (objfpy_lookup_static_symbol): New function.
1367         (objfile_object_methods): Add new functions.
1368
1369 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1370
1371         * NEWS: Mention 'set|show print frame-info'.  Mention new
1372         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1373         backtrace argument.  Mention that python frame filtering code
1374         is now consistent with what 'backtrace' command prints.
1375
1376 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1377
1378         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1379         comments.
1380         (print_frame_info_auto, print_frame_info_source_line,
1381         print_frame_info_location, print_frame_info_source_and_location,
1382         print_frame_info_location_and_address, print_frame_info_short_location):
1383         New declarations.
1384         (struct frame_print_options): New member print_frame_info.
1385         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1386         * stack.h (get_user_print_what_frame_info): New declaration.
1387         (frame_show_address): New declaration.
1388         * stack.c (print_frame_arguments_choices): New value 'presence'.
1389         (print_frame_info_auto, print_frame_info_source_line,
1390         print_frame_info_location, print_frame_info_source_and_location,
1391         print_frame_info_location_and_address, print_frame_info_short_location,
1392         print_frame_info_choices, print_frame_info_print_what): New definitions.
1393         (print_frame_args): Only print dots for args if print frame-arguments
1394         is 'presence'.
1395         (frame_print_option_defs): New element for "frame-info".
1396         (get_user_print_what_frame_info): New function.
1397         (frame_show_address): Make non static.  Move comment to stack.h.
1398         (print_frame_info_to_print_what): New function.
1399         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1400         to decide what to print.
1401         (backtrace_command_1): Handle the new print_frame_arguments_presence
1402         value.
1403         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1404         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1405         (py_print_frame): In non-mi mode, use LOCATION as default for
1406         print_what, similarly to frame information printed directly by
1407         backtrace command. Handle frame-info user option in non MI mode.
1408
1409 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1410
1411         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1412         Add case for debugging 32-bit target on 64-bit host.  Revise
1413         comment.
1414
1415 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1416
1417         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1418         instead of find_function_entry_range_from_pc.
1419
1420 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1421
1422         * stack.c (find_frame_funname): Remove code which preferred
1423         minsym over symtab sym in "certain pathological cases".
1424
1425         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1426         parameter.  Change type of "do_demangle" to bool.
1427         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1428         Pass suitable "prefer_sym_over_minsym" flag to
1429         build_address_symbolic().  Don't output "+" for negative offsets.
1430         * printcmd.c (print_address_symbolic): Update invocation of
1431         build_address_symbolic to include a "prefer_sym_over_minsym"
1432         flag.
1433         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1434         Restrict cases in which use of minimal symbol is preferred to that
1435         of a found symbol.  Update comments.
1436
1437         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1438         for entry pc when entry pc is out of range for that FDE.
1439
1440 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1441
1442         PR gdb/24839:
1443         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1444         type.
1445
1446 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1447
1448         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1449         this function's Python signature.
1450
1451
1452 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1453
1454         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1455         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1456         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1457         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1458         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1459
1460
1461 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1462
1463         * h8300-tdep.c (h8300_register_name_common): New.
1464         h8300_register_name): Use h8300_register_name_common.
1465         (h8300s_register_name): Likewise.
1466         (h8300sx_register_name): Likewise.
1467         (h8300h_register_nam): New.
1468         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1469
1470
1471 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1472
1473         * arm-tdep.c (arm_skip_cmse_entry): New function.
1474         (arm_is_sgstubs_section): New function.
1475         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1476
1477 2019-07-22  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1480         Don't self-assign.
1481
1482 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1483
1484         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1485         type_print.
1486
1487 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1488
1489         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1490         so that GDB doesn't match any msymbols when searching in the
1491         TYPES_DOMAIN.
1492         (print_symbol_info): Print using typedef_print or type_print based
1493         on the type of the symbol.  Add updated FIXME comment moved from...
1494         (_initialize_symtab): ... move and update FIXME comment to above.
1495
1496 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * NEWS: Mention adding -q option to "info types".
1499         * symtab.c (struct info_types_options): New struct.
1500         (info_types_options_defs): New variable.
1501         (make_info_types_options_def_group): New function.
1502         (info_types_command): Use gdb::option framework to parse options.
1503         (info_types_command_completer): New function.
1504         (_initialize_symtab): Extend the help text on "info types" and
1505         register command completer.
1506
1507 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1508
1509         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1510         (lookup_symbol_in_objfile): Change int to block_enum and add a
1511         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1512
1513 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1514
1515         * MAINTAINERS (Write After Approval): Add self.
1516
1517 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1518
1519         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1520         instruction to the dummy code region.
1521
1522 2019-07-19  Tom Tromey  <tromey@adacore.com>
1523
1524         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1525         (ARGSUSED, PARAMS, __func__): Remove rules.
1526
1527 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1528
1529         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1530         * features/arm/arm-with-iwmmxt.c: Remove.
1531         * features/arm/arm-with-iwmmxt.xml: Remove.
1532         * features/arm/arm-with-m-fpa-layout.c: Remove.
1533         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1534         * features/arm/arm-with-m-vfp-d16.c: Remove.
1535         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1536         * features/arm/arm-with-m.c: Remove.
1537         * features/arm/arm-with-m.xml: Remove.
1538         * features/arm/arm-with-neon.c: Remove.
1539         * features/arm/arm-with-neon.xml: Remove.
1540         * features/arm/arm-with-vfpv2.c: Remove.
1541         * features/arm/arm-with-vfpv2.xml: Remove.
1542         * features/arm/arm-with-vfpv3.c: Remove.
1543         * features/arm/arm-with-vfpv3.xml: Remove.
1544
1545 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1546
1547         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1548
1549 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1550
1551         * arch/aarch32.c (aarch32_create_target_description): Create
1552         target descriptions using features.
1553         * arch/arm.c (arm_create_target_description)
1554         (arm_create_mprofile_target_description): Likewise.
1555         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1556
1557 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1558
1559         * Makefile.in: Add new files.
1560         * aarch32-tdep.c: New file.
1561         * aarch32-tdep.h: New file.
1562         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1563         Call aarch32_read_description.
1564         * arch/aarch32.c: New file.
1565         * arch/aarch32.h: New file.
1566         * arch/arm.c (arm_create_target_description)
1567         (arm_create_mprofile_target_description): New function.
1568         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1569         (arm_create_target_description)
1570         (arm_create_mprofile_target_description): New declaration.
1571         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1572         read_description functions.
1573         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1574         Likewise.
1575         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1576         * arm-tdep.c (tdesc_arm_list): New variable.
1577         (arm_register_g_packet_guesses): Call create description functions.
1578         (arm_read_description) (arm_read_mprofile_description): New
1579         function.
1580         * arm-tdep.h (arm_read_description)
1581         (arm_read_mprofile_description): Add declaration.
1582         * configure.tgt: Add new files.
1583
1584 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1585
1586         * top.c (new_ui_command): Open specified terminal just once.
1587
1588 2019-07-18  Tom Tromey  <tromey@adacore.com>
1589
1590         * symtab.c (main_name): Constify return type.
1591         * symfile.c (set_initial_language): Update.
1592         * symtab.h (main_name): Constify return type.
1593
1594 2019-07-17  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui-winsource.c (tui_update_source_window)
1597         (tui_update_source_window_as_is)
1598         (tui_update_source_windows_with_line): Remove return.
1599         * tui/tui-disasm.c (tui_show_disassem)
1600         (tui_show_disassem_and_update_source): Remove return.
1601         * tui/tui.c (tui_reset): Remove return.
1602         * tui/tui-wingeneral.c
1603         (tui_check_and_display_highlight_if_needed): Remove return.
1604
1605 2019-07-17  Tom Tromey  <tom@tromey.com>
1606
1607         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1608
1609 2019-07-17  Tom Tromey  <tom@tromey.com>
1610
1611         * tui/tui-winsource.h (struct tui_exec_info_window)
1612         (struct tui_source_window_base): Move from tui-data.h.
1613         * tui/tui-winsource.c: Move many method definitions from
1614         elsewhere.  Remove "structuring" comments.
1615         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1616         (tui_source_window_base::refresh_window): Move to
1617         tui-winsource.c.
1618         * tui/tui-win.c (tui_source_window_base::refresh_all)
1619         (tui_source_window_base::update_tab_width)
1620         (tui_source_window_base::set_new_height)
1621         (tui_source_window_base::do_make_visible_with_new_height): Move to
1622         tui-winsource.c.
1623         * tui/tui-source.h: Update.
1624         * tui/tui-source.c (tui_source_window_base::reset): Move to
1625         tui-winsource.c.
1626         * tui/tui-disasm.h: Update.
1627         * tui/tui-data.h (struct tui_exec_info_window): Move to
1628         tui-winsource.h.
1629         (struct tui_source_window_base): Likewise.
1630         * tui/tui-data.c (tui_source_window_base::clear_detail)
1631         (tui_source_window_base, ~tui_source_window_base): Move to
1632         tui-winsource.c.
1633
1634 2019-07-17  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-win.c (tui_resize_all)
1637         (tui_source_window_base::update_tab_width)
1638         (tui_adjust_win_heights): Update.
1639         (tui_win_info::make_invisible_and_set_new_height): Rename from
1640         make_invisible_and_set_new_height.
1641         * tui/tui-data.h (struct tui_win_info)
1642         <make_invisible_and_set_new_height>: New method.
1643
1644 2019-07-17  Tom Tromey  <tom@tromey.com>
1645
1646         * tui/tui.c: Update.
1647         * tui/tui-source.h (struct tui_source_window): Move from
1648         tui-data.h.
1649         * tui/tui-layout.c: Update.
1650         * tui/tui-disasm.c: Update.
1651         * tui/tui-data.h (struct tui_source_window): Move to
1652         tui-source.h.
1653
1654 2019-07-17  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1657         tui-data.h.
1658         * tui/tui-data.h (struct tui_disasm_window): Move to
1659         tui-disasm.h.
1660
1661 2019-07-17  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-regs.h (struct tui_data_item_window): Move from
1664         tui-data.h.
1665         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1666         * tui/tui-data.h (struct tui_data_item_window): Move to
1667         tui-regs.h.
1668         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1669
1670 2019-07-17  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui.c: Update.
1673         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1674         (tui_cmd_window::max_height): Move to tui-command.c.
1675         * tui/tui-layout.c: Update.
1676         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1677         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1678         tui-command.c.
1679         * tui/tui-command.h (struct tui_cmd_window): Move from
1680         tui-data.h.
1681         * tui/tui-command.c: Remove "structuring" comments.
1682         (tui_cmd_window::clear_detail)
1683         (tui_cmd_window::do_make_visible_with_new_height)
1684         (tui_cmd_window::max_height): Move from elsewhere.
1685
1686 2019-07-17  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1689         Now static.
1690         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1691         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1692
1693 2019-07-17  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui.c: Update.
1696         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1697         tui-regs.c.
1698         * tui/tui-windata.h: Remove file.
1699         * tui/tui-windata.c: Remove file.
1700         * tui/tui-win.c (tui_data_window::set_new_height)
1701         (tui_data_window::do_make_visible_with_new_height): Move to
1702         tui-regs.c.
1703         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1704         * tui/tui-regs.c: Remove "structuring" comments.
1705         (tui_data_window::first_data_item_displayed)
1706         (tui_data_window::delete_data_content_windows)
1707         (tui_data_window::erase_data_content)
1708         (tui_data_window::display_all_data)
1709         (tui_data_window::refresh_all)
1710         (tui_data_window::do_scroll_vertical)
1711         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1712         (tui_data_window::do_make_visible_with_new_height)
1713         (tui_data_window::refresh_window): Move from elsewhere.
1714         (_initialize_tui_regs): Move to end of file.
1715         * tui/tui-layout.c: Update.
1716         * tui/tui-hooks.c: Update.
1717         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1718         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1719         tui-regs.c.
1720         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1721
1722 2019-07-17  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1725         seen.
1726
1727 2019-07-17  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-win.c (tui_source_window_base::set_new_height)
1730         (tui_source_window_base::do_make_visible_with_new_height): Use
1731         m_has_locator field directly.
1732         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1733         method.
1734         (struct tui_source_window_base) <has_locator>: Likewise.
1735
1736 2019-07-17  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1739         Don't declare.
1740         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1741         Remove.
1742         * tui/tui-win.c (tui_source_window_base::set_new_height)
1743         (tui_source_window_base::set_new_height)
1744         (make_invisible_and_set_new_height)
1745         (tui_source_window_base::do_make_visible_with_new_height)
1746         (tui_source_window_base::do_make_visible_with_new_height):
1747         Update.
1748         * tui/tui-layout.c (show_source_disasm_command, show_data)
1749         (show_source_or_disasm_and_command): Update.
1750         * tui/tui-layout.c (show_layout): Update.
1751
1752 2019-07-17  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-layout.c (make_data_window): Remove.
1755         (show_data): Unify creation and re-initialization cases.
1756
1757 2019-07-17  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-layout.c (make_source_window, make_disasm_window):
1760         Remove.
1761         (show_data): Unify creation and re-initialization cases.
1762
1763 2019-07-17  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-layout.c (make_command_window): Remove.
1766         (show_source_disasm_command, show_source_or_disasm_and_command):
1767         Unify creation and re-initialization cases.
1768
1769 2019-07-17  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1772         creation and re-initialization cases.
1773
1774 2019-07-17  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-regs.c (tui_get_register): Return void.
1777
1778 2019-07-17  Tom Tromey  <tom@tromey.com>
1779
1780         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1781         Simplify.
1782
1783 2019-07-17  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1786         resetting.
1787
1788 2019-07-17  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1791         * tui/tui-regs.c (tui_reg_layout): New function.
1792         (tui_show_registers, tui_reg_command): Use it.
1793         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1794         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1795         parameters.
1796         (tui_layout_command): Remove.
1797
1798 2019-07-17  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-layout.h (tui/tui-layout): Return void.
1801         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1802
1803 2019-07-17  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-layout.c (show_source_disasm_command, show_data):
1806         Update.
1807         (reset_locator): Remove.
1808         (show_source_or_disasm_and_command): Update.
1809
1810 2019-07-17  Tom Tromey  <tom@tromey.com>
1811
1812         * tui/tui-source.c (tui_source_window_base::reset): Remove
1813         win_type parameter.
1814         * tui/tui-layout.c (make_command_window, make_source_window)
1815         (make_disasm_window, make_data_window)
1816         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1817         (reset_locator, show_source_or_disasm_and_command): Update.
1818         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1819         win_type parameter.
1820         (struct tui_source_window_base) <reset>: Likewise.
1821
1822 2019-07-17  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-layout.c (show_source_disasm_command): Use
1825         reset_locator.
1826         (reset_locator): New function.
1827         (init_and_make_win): Remove.
1828         (show_source_or_disasm_and_command): Use reset_locator.
1829
1830 2019-07-17  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1833         condition.
1834         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1835         Remove condition.
1836         * tui/tui-source.c (tui_source_window_base::reset): New method.
1837         * tui/tui-layout.c (make_command_window): Don't call
1838         init_and_make_win.
1839         (make_source_window, make_disasm_window): Don't call
1840         make_source_or_disasm_window.
1841         (make_data_window): Don't call init_and_make_win.  Change calling
1842         convention.
1843         (show_source_disasm_command, show_data): Simplify.
1844         (make_source_or_disasm_window): Remove.
1845         (show_source_or_disasm_and_command): Simplify.
1846         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1847         (struct tui_source_window_base) <reset>: Likewise.
1848         <execution_info>: Remove initializer.
1849         * tui/tui-data.c (tui_source_window_base): Initialize
1850         execution_info.
1851
1852 2019-07-17  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1855         variable.
1856
1857 2019-07-17  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui.c (tui_rl_other_window): Update.
1860         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1861         superclass method first.  Always iterate over regs_content.
1862         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1863         method.
1864         * tui/tui-win.c (tui_set_focus_command): Update.
1865
1866 2019-07-17  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-win.c (tui_set_focus_command): Rename from
1869         tui_set_focus.  Call tui_enable.
1870         (tui_set_focus_command): Remove.
1871
1872 2019-07-17  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1875         refresh_window.
1876         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1877         touchwin.
1878         (tui_data_window::refresh_window): Call refresh_window on data
1879         items.  Always call superclass refresh_window.
1880         (tui_win_info::refresh): Remove.
1881         (tui_source_window_base::refresh_window): Update.
1882         (tui_refresh_all): Update.
1883         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1884         refresh_window.
1885         (show_source_or_disasm_and_command): Likewise.
1886         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1887         (struct tui_source_window_base) <refresh>: Likewise.
1888
1889 2019-07-17  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-winsource.c (tui_clear_source_content)
1892         (tui_show_source_content): Update.
1893         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1894         whether content is empty.
1895         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1896         Remove.
1897
1898 2019-07-17  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1901         window's contents.
1902         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1903         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1904
1905 2019-07-17  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1908         (struct tui_data_item_window): Update.
1909
1910 2019-07-17  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1913         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1914         defines.
1915
1916 2019-07-17  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-winsource.h (tui_erase_source_content)
1919         (tui_clear_source_content): Remove "display_prompt" parameter.
1920         * tui/tui-winsource.c (tui_update_source_window_as_is)
1921         (tui_update_source_windows_with_addr): Update.
1922         (tui_clear_source_content): Remove "display_prompt" parameter.
1923         (tui_erase_source_content): Likewise.  Simplify.
1924         (tui_show_source_content): Update.
1925         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1926         * tui/tui-stack.c (tui_show_frame_info): Update.
1927         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1928         Remove defines.
1929
1930 2019-07-17  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1933         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1934         parameter.
1935         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1936         parameter.
1937
1938 2019-07-17  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-winsource.c (tui_clear_source_content)
1941         (tui_show_source_content, tui_show_exec_info_content)
1942         (tui_clear_exec_info_content): Update.
1943         * tui/tui-stack.c (tui_show_locator_content): Update.
1944         (tui_show_frame_info): Update.
1945         * tui/tui-source.h (tui_source_window): Don't declare.
1946         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1947         from tui_source_is_displayed.
1948         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1949         Remove field.
1950         (struct tui_source_window_base) <content_in_use>: New field.  Now
1951         bool.
1952         (struct tui_source_window) <showing_source_p>: New method.
1953         (TUI_SRC_WIN): Change cast.
1954         * tui/tui-data.c (tui_initialize_static_data): Update.
1955
1956 2019-07-17  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1959         location_matches_p.
1960         * tui/tui-source.c (tui_source_window::location_matches_p): New
1961         method.
1962         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1963         method.
1964         * tui/tui-data.h (struct tui_source_window_base)
1965         <location_matches_p>: New method.
1966         (struct tui_source_window, struct tui_disasm_window)
1967         <location_matches_p>: Likewise.
1968
1969 2019-07-17  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-win.c (tui_set_win_height_command): Rename from
1972         tui_set_win_height.
1973         (tui_set_win_height_command): Remove.
1974
1975 2019-07-17  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-source.c (tui_source_window): New constructor.  Add
1978         observer.
1979         (~tui_source_window): New destructor.
1980         (tui_source_window::style_changed): New method.
1981         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1982         (tui_attach_detach_observers): Update.
1983         * tui/tui-data.h (struct tui_source_window): Make constructor not
1984         inline.  Add destructor.
1985         (struct tui_source_window) <style_changed>: New method.
1986         <m_observable>: New member.
1987
1988 2019-07-17  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1991         * tui/tui-win.c (tui_resize_all): Fix typo.
1992
1993 2019-07-17  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1996         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1997         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1998         * tui/tui-win.c (window_name_completer): Use foreach.
1999         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2000         (update_tab_width): Likewise.
2001         * tui/tui-layout.c (show_layout): Update.
2002         * tui/tui-data.h (class tui_window_iterator): New.
2003         (struct all_tui_windows): New.
2004         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2005
2006 2019-07-17  Tom Tromey  <tom@tromey.com>
2007
2008         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2009         parameter.  Don't reference globals.
2010         (tui_reg_command): Update.
2011
2012 2019-07-17  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-regs.c (tui_show_registers): Simplify.
2015
2016 2019-07-17  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-regs.c (tui_show_registers): Update.
2019         (tui_show_register_group): Add win_info parameter.
2020
2021 2019-07-17  Tom Tromey  <tom@tromey.com>
2022
2023         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2024         Rename from tui_display_reg_element_at_line.
2025         (tui_data_window::display_registers_from_line): Update.
2026         * tui/tui-data.h (struct tui_data_window)
2027         <display_reg_element_at_line>: New method.
2028
2029 2019-07-17  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-regs.h (tui_display_registers_from)
2032         (tui_display_registers_from_line): Don't declare.
2033         * tui/tui-windata.c (tui_data_window::display_all_data)
2034         (tui_data_window::refresh_all)
2035         (tui_data_window::do_scroll_vertical): Update.
2036         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2037         from tui_display_registers_from.
2038         (tui_display_reg_element_at_line): Update.
2039         (tui_data_window::display_registers_from_line): Rename from
2040         tui_display_registers_from_line.
2041         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2042         display_registers_from_line>: New methods.
2043
2044 2019-07-17  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2047         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2048         from tui_erase_data_content.
2049         (tui_data_window::display_all_data)
2050         (tui_data_window::refresh_all)
2051         (tui_data_window::do_scroll_vertical): Update.
2052         * tui/tui-regs.c (tui_show_registers): Update.
2053         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2054         New method.
2055
2056 2019-07-17  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2059         declare.
2060         * tui/tui-windata.c
2061         (tui_data_window::delete_data_content_windows): Rename from
2062         tui_delete_data_content_windows.
2063         (tui_data_window::display_all_data)
2064         (tui_data_window::do_scroll_vertical): Update.
2065         * tui/tui-data.h (struct tui_data_window)
2066         <delete_data_content_windows>: New method.
2067
2068 2019-07-17  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2071         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2072
2073 2019-07-17  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2076         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2077         from tui_display_all_data.
2078         * tui/tui-win.c
2079         (tui_data_window::do_make_visible_with_new_height): Update.
2080         * tui/tui-regs.c (tui_show_registers): Update.
2081         * tui/tui-layout.c (tui_set_layout): Update.
2082         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2083         method.
2084
2085 2019-07-17  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2088         * tui/tui-windata.c (tui_display_data_from): Remove.
2089         (tui_data_window::refresh_all): Update.
2090
2091 2019-07-17  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2094         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2095         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2096         tui_display_registers_from_line.
2097         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2098         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2099         "force_display" parameter.
2100
2101 2019-07-17  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2104         declare.
2105         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2106         Rename from tui_first_reg_element_no_inline.
2107         (tui_display_reg_element_at_line)
2108         (tui_display_registers_from_line): Update.
2109         * tui/tui-data.h (struct tui_data_window)
2110         <first_reg_element_no_inline>: New method.
2111
2112 2019-07-17  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui-windata.c (tui_display_data_from)
2115         (tui_data_window::do_scroll_vertical): Update.
2116         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2117         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2118         Rename from tui_line_from_reg_element_no.
2119         (tui_display_registers_from_line): Update.
2120         * tui/tui-data.h (struct tui_data_window)
2121         <line_from_reg_element_no>: New method.
2122
2123 2019-07-17  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2126         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2127         tui_last_regs_line_no.
2128         (tui_display_reg_element_at_line)
2129         (tui_display_registers_from_line): Update.
2130         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2131         method.
2132
2133 2019-07-17  Tom Tromey  <tom@tromey.com>
2134
2135         PR tui/24722:
2136         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2137         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2138         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2139         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2140         (tui_update_breakpoint_info): Likewise.
2141         * tui/tui-hooks.c (tui_event_create_breakpoint)
2142         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2143         Update.
2144
2145 2019-07-17  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2148
2149 2019-07-17  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-winsource.c (tui_update_source_window_as_is)
2152         (tui_update_source_windows_with_addr): Update.
2153         * tui/tui-source.h (tui_set_source_content)
2154         (tui_show_symtab_source): Add "win_info" parameter.
2155         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2156         parameter.
2157         (tui_show_symtab_source): Likewise.
2158
2159 2019-07-17  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-wingeneral.c
2162         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2163
2164 2019-07-17  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2167         (struct tui_cmd_window) <can_scroll>: New method.
2168         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2169         method.
2170
2171 2019-07-17  Tom Tromey  <tromey@adacore.com>
2172
2173         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2174         do_field_signed>: Rename.  Change type of "value".
2175         * ui-out.c (ui_out::field_signed): Rename from field_int.
2176         Change type of "value".
2177         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2178         type of "value".
2179         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2180         do_field_int.  Change type of "value".
2181         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2182         do_field_int.  Change type of "value".
2183         * tracepoint.c (trace_status_mi, tfind_1)
2184         (print_one_static_tracepoint_marker): Update.
2185         * thread.c (print_thread_info_1, print_selected_thread_frame):
2186         Update.
2187         * stack.c (print_frame, print_frame_info): Update.
2188         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2189         Update.
2190         * source.c (print_source_lines_base): Update.
2191         * skip.c (info_skip_command): Update.
2192         * record-btrace.c (btrace_ui_out_decode_error)
2193         (btrace_call_history_src_line): Update.
2194         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2195         Update.
2196         * progspace.c (print_program_space): Update.
2197         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2198         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2199         do_field_int.  Change type of "value".
2200         * mi/mi-out.c (mi_ui_out::do_table_begin)
2201         (mi_ui_out::do_table_header): Update.
2202         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2203         type of "value".
2204         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2205         (mi_cmd_data_list_changed_registers, output_register)
2206         (mi_cmd_data_read_memory, mi_load_progress)
2207         (mi_cmd_trace_frame_collected): Update.
2208         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2209         Update.
2210         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2211         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2212         (mi_cmd_var_list_children, varobj_update_one): Update.
2213         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2214         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2215         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2216         * inferior.c (print_inferior): Update.
2217         * gdb_bfd.c (print_one_bfd): Update.
2218         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2219         Update.
2220         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2221         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2222         do_field_int.  Change type of "value".
2223         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2224         do_field_int.  Change type of "value".
2225         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2226         (print_one_breakpoint_location, print_it_catch_fork)
2227         (print_one_catch_fork, print_it_catch_vfork)
2228         (print_one_catch_vfork, print_it_catch_solib)
2229         (print_it_catch_exec, print_it_ranged_breakpoint)
2230         (print_mention_watchpoint, print_mention_masked_watchpoint)
2231         (bkpt_print_it, update_static_tracepoint): Update.
2232         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2233         * break-catch-syscall.c (print_it_catch_syscall): Update.
2234         * ada-tasks.c (print_ada_task_info): Update.
2235         * ada-lang.c (print_it_exception, print_mention_exception):
2236         Update.
2237
2238 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         PR breakpoints/24541
2241         * gdbarch.c: Regenerate.
2242         * gdbarch.h: Regenerate.
2243         * gdbarch.sh: Adjust return type and parameter types for
2244         'stap_adjust_register'.
2245         (i386_stap_adjust_register): Adjust signature and return new
2246         register name.
2247         * stap-probe.c (stap_parse_register_operand): Adjust use of
2248         'gdbarch_stap_adjust_register'.
2249
2250 2019-07-17  Tom Tromey  <tromey@adacore.com>
2251
2252         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2253         declare VEC.
2254         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2255         std::vector.
2256         (struct s390_process_info): Add initializers.
2257         (s390_add_process): Use new.
2258         (s390_linux_nat_target::low_forget_process): Use delete.
2259         (s390_linux_nat_target::low_new_fork)
2260         (s390_linux_nat_target::stopped_by_watchpoint)
2261         (s390_linux_nat_target::low_prepare_to_resume)
2262         (s390_linux_nat_target::insert_watchpoint)
2263         (s390_linux_nat_target::insert_hw_breakpoint)
2264         (s390_linux_nat_target::remove_watchpoint)
2265         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2266
2267 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2268
2269         * aarch64-fbsd-nat.c: Include regcache.h.
2270         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2271         argument.
2272         (aarch64_fbsd_nat_target::fetch_registers)
2273         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2274         variable.
2275         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2276
2277 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2278
2279         * fbsd-nat.c: Include gdbarch.h.
2280
2281 2019-07-15  Tom Tromey  <tromey@adacore.com>
2282
2283         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2284
2285 2019-07-15  Tom Tromey  <tromey@adacore.com>
2286
2287         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2288         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2289         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2290         * cli-out.c (cli_ui_out::do_field_int): New method.
2291         * ui-out.c (ui_out::field_unsigned): New method.
2292         * symfile.c (generic_load): Use field_unsigned.
2293         (print_transfer_performance): Likewise.
2294         * record-btrace.c (ui_out_field_uint): Remove.
2295         (btrace_call_history_insn_range, btrace_call_history): Use
2296         field_unsigned.
2297         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2298         field_unsigned.
2299         * ui-out.h (class ui_out) <field_unsigned>: New method.
2300         <do_field_unsigned>: Likewise.
2301
2302 2019-07-15  Tom Tromey  <tromey@adacore.com>
2303
2304         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2305         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2306         * target.c (flash_erase_command): Use field_string.
2307         * infrun.c (print_signal_received_reason): Use field_string.
2308         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2309         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2310         field_string.
2311         * ada-tasks.c (print_ada_task_info): Use field_string.
2312
2313 2019-07-15  Tom Tromey  <tromey@adacore.com>
2314
2315         * target.c (flash_erase_command): Use field_core_addr.
2316         * symfile.c (generic_load): Use field_core_addr.
2317         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2318         Use field_core_addr.
2319         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2320         field_core_addr.
2321
2322 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2323
2324         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2325         value if its desired type is smaller than a CORE_ADDR and signed.
2326
2327 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2328
2329         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2330         of changes to field names, and use new is_reference field to
2331         decide if a property is a reference or not.
2332         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2333         field.
2334         (struct dwarf2_property_baton): Update header comment, rename
2335         'referenced_type' to 'property_type' and update comments.
2336         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2337         default property type, store in property baton, update to take
2338         accound of renamed field.
2339         (read_func_scope): Update call to attr_to_dynamic_prop.
2340         (read_array_type): Likewise.
2341         (dwarf2_per_cu_addr_sized_int_type): New function.
2342         (read_subrange_index_type): Move type finding code to
2343         dwarf2_per_cu_addr_sized_int_type.
2344         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2345         (dwarf2_per_cu_addr_type): New function.
2346         (set_die_type): Update calls to attr_to_dynamic_prop.
2347
2348 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2349
2350         * dwarf2read.c (read_subrange_index_type): New function.
2351         (read_subrange_type): Move code into new function and call it.
2352         * gdbtypes.c (create_range_type): Add some asserts.
2353
2354 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2357         update return statements.
2358         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2359         declaration, and update comment to match.
2360         * gdbtypes.c (resolve_dynamic_array): Update call to
2361         dwarf2_evaluate_property to match new return type.
2362
2363 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2364
2365         * valarith.c (value_subscripted_rvalue): Change lowerbound
2366         parameter type from int to LONGEST.
2367         * value.h (value_subscripted_rvalue): Likewise in declaration.
2368
2369 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2370
2371         * cli/cli-utils.c (info_print_command_completer): New function.
2372         * cli/cli-utils.h: Add 'completer.h' include, and forward
2373         declaration for 'struct cmd_list_element'.
2374         (info_print_command_completer): Declare.
2375         * stack.c (_initialize_stack): Add completer for 'info locals' and
2376         'info args'.
2377         * symtab.c (_initialize_symtab): Add completer for 'info
2378         variables' and 'info functions'.
2379         * NEWS: Mention completion for additional info commands.
2380
2381 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2382
2383         * cli/cli-utils.c (extract_info_print_args): Delete.
2384         (extract_arg_maybe_quoted): Delete.
2385         (info_print_options_defs): New variable.
2386         (make_info_print_options_def_group): New function.
2387         (extract_info_print_options): Define new function.
2388         * cli/cli-utils.h (extract_info_print_args): Delete.
2389         (struct info_print_options): New structure.
2390         (extract_info_print_options): Declare new function.
2391         * stack.c (info_locals_command): Update to use new
2392         extract_info_print_options, also add a header comment.
2393         (info_args_command): Likewise.
2394         * symtab.c (info_variables_command): Likewise.
2395         (info_functions_command): Likewise.
2396
2397 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2398
2399         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2400         to extract string arguments.
2401         * common/common-utils.c (extract_string_maybe_quoted): New function.
2402         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2403
2404 2019-07-11  Tom Tromey  <tromey@adacore.com>
2405
2406         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2407         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2408         * top.h (gdbinit): Don't declare.
2409         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2410         into...
2411         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2412         * top.c (gdb_init): Don't call init_cli_cmds.
2413         (gdbinit): Remove.
2414         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2415
2416 2019-07-11  Tom Tromey  <tromey@adacore.com>
2417
2418         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2419         after it has been moved.
2420
2421 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2422
2423         * valops.c (value_must_coerce_to_target): Change return type to
2424         bool.
2425         * value.h (value_must_coerce_to_target): Likewise.
2426
2427 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2428
2429         * breakpoint.c (is_hardware_watchpoint): Remove
2430         forward-declaration.
2431         (is_masked_watchpoint): Change return type to bool.
2432         (is_tracepoint): Likewise.
2433         (is_breakpoint): Likewise.
2434         (is_hardware_watchpoint): Likewise.
2435         (is_watchpoint): Likewise.
2436         (is_no_memory_software_watchpoint): Likewise.
2437         (is_catchpoint): Likewise.
2438         (breakpoint_1): Make FILTER parameter's return type bool.
2439         is_masked_watchpoint): Change return type to bool.
2440         (save_breakpoints): Make FILTER parameter's return type bool.
2441         * breakpoint.h (is_breakpoint): Change return type to bool.
2442         (is_watchpoint): Likewise.
2443         (is_catchpoint): Likewise.
2444         (is_tracepoint): Likewise.
2445
2446 2019-07-10  Tom Tromey  <tom@tromey.com>
2447
2448         * defs.h: Don't include gdbarch.h.
2449         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2450         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2451         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2452         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2453         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2454         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2455         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2456         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2457         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2458         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2459         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2460         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2461         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2462         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2463         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2464         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2465         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2466         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2467         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2468         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2469         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2470         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2471         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2472         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2473         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2474         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2475         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2476
2477 2019-07-10  Tom Tromey  <tromey@adacore.com>
2478
2479         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2480         * breakpoint.c (init_ada_exception_breakpoint): Register as
2481         bp_catchpoint.
2482         (print_one_breakpoint_location, print_one_breakpoint): Use
2483         is_ada_exception_catchpoint.
2484         * ada-lang.c (class ada_catchpoint_location): Pass
2485         bp_loc_software_breakpoint to bp_location constructor.
2486         (is_ada_exception_catchpoint): New function.
2487
2488 2019-07-10  Tom Tromey  <tromey@adacore.com>
2489
2490         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2491         VEC.
2492         (struct arm_exidx_entry): New method operator<.
2493         (struct arm_exidx_data) <section_maps>: Change type.
2494         (arm_exidx_data_free): Remove.
2495         (arm_exidx_data_key): Change type.  Move lower.
2496         (arm_exidx_new_objfile): Update.
2497         (arm_compare_exidx_entries): Remove.
2498         (arm_find_exidx_entry, _initialize_arm_tdep)
2499
2500 2019-07-10  Tom Tromey  <tromey@adacore.com>
2501
2502         * solib-spu.c (ocl_program_data_key): Change type.
2503         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2504         Update.
2505
2506 2019-07-10  Tom Tromey  <tromey@adacore.com>
2507
2508         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2509         (struct solib_aix_inferior_data) <library_list>: Change type.
2510         (solib_aix_inferior_data_handle): Change type.
2511         (get_solib_aix_inferior_data): Update.
2512         (solib_aix_free_library_list): Remove.
2513         (library_list_start_library): Update.
2514         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2515         return type.
2516         (solib_aix_get_library_list)
2517         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2518         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2519
2520 2019-07-10  Tom Tromey  <tromey@adacore.com>
2521
2522         * solib-dsbt.c (struct dsbt_info): Add initializers.
2523         (solib_dsbt_pspace_data): Change type.
2524         (dsbt_pspace_data_cleanup): Remove.
2525         (get_dsbt_info, _initialize_dsbt_solib): Update.
2526
2527 2019-07-10  Tom Tromey  <tromey@adacore.com>
2528
2529         * spu-tdep.c (spu_overlay_data): Change type.
2530         (spu_get_overlay_table, spu_overlay_new_objfile)
2531         (_initialize_spu_tdep): Update.
2532
2533 2019-07-10  Tom Tromey  <tromey@adacore.com>
2534
2535         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2536         destructor.
2537         (dbx_objfile_data_key): Change type and declare later.
2538         (DBX_SYMFILE_INFO): Rewrite.
2539         * dbxread.c (dbx_objfile_data_key): Change type.
2540         (dbx_symfile_init): Update.
2541         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2542         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2543         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2544
2545 2019-07-10  Tom Tromey  <tromey@adacore.com>
2546
2547         * jit.c (jit_program_space_key): Change type.  Move lower.
2548         (get_jit_program_space_data): Update.
2549         (jit_program_space_data_cleanup): Remove.
2550         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2551         Update.
2552         (struct jit_program_space_data): Add initializers.
2553
2554 2019-07-10  Tom Tromey  <tromey@adacore.com>
2555
2556         * solib-darwin.c (struct darwin_info): Add initializers.
2557         (solib_darwin_pspace_data): Change type.
2558         (darwin_pspace_data_cleanup): Remove.
2559         (get_darwin_info, _initialize_darwin_solib): Update.
2560
2561 2019-07-10  Tom Tromey  <tromey@adacore.com>
2562
2563         * remote-sim.c (struct sim_inferior_data): Add initializers,
2564         constructor, and destructor.
2565         (sim_inferior_data_key): Change type.  Move lower.
2566         (check_for_duplicate_sim_descriptor): Update.
2567         (get_sim_inferior_data): Use new.  Update.
2568         (~sim_inferior_data_cleanup): Rename from
2569         sim_inferior_data_cleanup.  Simplify.
2570         (gdbsim_close_inferior, simulator_command)
2571         (sim_command_completer, _initialize_remote_sim): Update.
2572         (next_pid, INITIAL_PID): Move earlier.
2573
2574 2019-07-10  Tom Tromey  <tromey@adacore.com>
2575
2576         * python/python-internal.h (create_thread_object): Return
2577         gdbpy_ref.
2578         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2579         * python/py-inferior.c (struct threadlist_entry): Add
2580         constructor.
2581         <thread_obj>: Now a gdbpy_ref.
2582         (thread_to_thread_object): Update.
2583         (add_thread_object): Use new.
2584         (delete_thread_object): Use delete.
2585         (infpy_threads): Update.
2586         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2587         GIL.
2588
2589 2019-07-10  Tom Tromey  <tromey@adacore.com>
2590
2591         * valops.c (value_cast): Specialize error message for Ada.
2592
2593 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2594
2595         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2596
2597 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2598
2599         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2600         bpstat_should_step): Return bool, adjust comments.
2601         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2602         bpstat_should_step): Likewise.
2603
2604 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2605
2606         * features/Makefile: Use feature target descriptions for Arm.
2607         * features/arm/arm-core.c: Generate new file.
2608         * features/arm/arm-fpa.c: Likewise.
2609         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2610         * features/arm/arm-m-profile.c: Likewise.
2611         * features/arm/arm-vfpv2.c: Likewise.
2612         * features/arm/arm-vfpv3.c: Likewise.
2613         * features/arm/xscale-iwmmxt.c: Likewise.
2614         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2615
2616 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2617
2618         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2619         ptrace earlier.
2620
2621 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2622
2623         * features/aarch64-pauth.c: Regenerate.
2624
2625 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2626
2627         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2628         bool.
2629         (bpstat_what): Use false instead of 0.
2630
2631 2019-07-09  Pedro Alves  <palves@redhat.com>
2632
2633         * break-catch-throw.c (is_exception_catchpoint): New.
2634         * breakpoint.c (print_one_breakpoint_location): New parameter
2635         'raw_loc'.  Handle it.  Use
2636         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2637         looking at the breakpoint's type.
2638         (print_one_breakpoint): If handling "maint info breakpoints", also
2639         print locations of exception catchpoints.
2640         * breakpoint.h (is_exception_catchpoint): Declare.
2641
2642 2019-07-09  Pedro Alves  <palves@redhat.com>
2643
2644         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2645         "addr" field.
2646         (allocate_location_exception_catchpoint): New.
2647         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2648         (initialize_throw_catchpoint_ops): Install
2649         allocate_location_exception_catchpoint as allocate_location
2650         method.
2651         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2652         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2653         bp_loc_other.
2654         (breakpoint_address_is_meaningful): Delete.
2655         (bl_address_is_meaningful): New.
2656         (breakpoint_locations_match): Adjust comment.
2657         (bp_location_from_bp_type): New, factored out of...
2658         (bp_location::bp_location(breakpoint *)): ... this.
2659         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2660         factored out of...
2661         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2662         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2663         breakpoint_address_is_meaningful.
2664         (bp_locations_compare): Adjust comment.
2665         (update_global_location_list): Use bl_address_is_meaningful
2666         instead of breakpoint_address_is_meaningful.
2667         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2668         explicit.
2669         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2670         * python/py-breakpoint.c (bppy_get_location): No longer check
2671         whether location is null.
2672
2673 2019-07-09  Pedro Alves  <palves@redhat.com>
2674
2675         PR c++/15468
2676         * breakpoint.c (print_one_breakpoint_location): Remove
2677         single-location assert.
2678
2679 2019-07-09  Tom Tromey  <tom@tromey.com>
2680
2681         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2682         * configure: Rebuild.
2683         * configure.ac: Change common to gdbsupport.
2684         * gdbsupport: Rename from common.
2685         * acinclude.m4: Change common to gdbsupport.
2686         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2687         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2688         gdbsupport.
2689         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2690         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2691         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2692         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2693         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2694         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2695         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2696         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2697         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2698         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2699         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2700         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2701         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2702         coff-pe-read.c, command.h, compile/compile-c-support.c,
2703         compile/compile-c.h, compile/compile-cplus-symbols.c,
2704         compile/compile-cplus-types.c, compile/compile-cplus.h,
2705         compile/compile-loc2c.c, compile/compile.c, completer.c,
2706         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2707         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2708         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2709         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2710         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2711         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2712         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2713         features/aarch64-core.c, features/aarch64-fpu.c,
2714         features/aarch64-pauth.c, features/aarch64-sve.c,
2715         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2716         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2717         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2718         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2719         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2720         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2721         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2722         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2723         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2724         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2725         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2726         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2727         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2728         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2729         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2730         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2731         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2732         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2733         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2734         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2735         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2736         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2737         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2738         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2739         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2740         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2741         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2742         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2743         minsyms.c, mips-linux-tdep.c, namespace.h,
2744         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2745         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2746         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2747         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2748         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2749         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2750         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2751         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2752         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2753         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2754         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2755         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2756         procfs.c, producer.c, progspace.h, psymtab.h,
2757         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2758         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2759         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2760         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2761         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2762         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2763         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2764         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2765         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2766         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2767         target-memory.c, target.c, target.h, target/waitstatus.c,
2768         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2769         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2770         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2771         unittests/array-view-selftests.c,
2772         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2773         unittests/common-utils-selftests.c,
2774         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2775         unittests/format_pieces-selftests.c,
2776         unittests/function-view-selftests.c,
2777         unittests/lookup_name_info-selftests.c,
2778         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2779         unittests/mkdir-recursive-selftests.c,
2780         unittests/observable-selftests.c,
2781         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2782         unittests/parse-connection-spec-selftests.c,
2783         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2784         unittests/scoped_fd-selftests.c,
2785         unittests/scoped_mmap-selftests.c,
2786         unittests/scoped_restore-selftests.c,
2787         unittests/string_view-selftests.c, unittests/style-selftests.c,
2788         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2789         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2790         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2791         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2792         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2793         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2794
2795 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2796
2797         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2798         bool value.
2799         (decode_digits_ordinary): Set explicit_line field in sal.
2800         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2801         symtab_and_line that was set on an explicit line number in
2802         assembler code.  Do always update the recorded symtab and line if
2803         we do skip the prologue.
2804
2805 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2806
2807         * breakpoint.c (set_breakpoint_location_function): Remove
2808         explicit_loc parameter.
2809         (momentary_breakpoint_from_master): Update call to
2810         set_breakpoint_location_function.
2811         (add_location_to_breakpoint): Likewise.
2812
2813 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2814
2815         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2816         required features based on default bfd type when no specific bfd
2817         is present.
2818
2819 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2820
2821         * NEWS: Mention that GDB printf and eval commands can now print
2822         C-style and Ada-style convenience var strings without
2823         calling the inferior.
2824         * printcmd.c (printf_c_string): Locally print GDB internal var
2825         instead of transiting via the inferior.
2826         (printf_wide_c_string): Likewise.
2827
2828 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2829
2830         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2831
2832 2019-07-04  Tom Tromey  <tom@tromey.com>
2833
2834         PR tui/24724:
2835         * tui/tui-winsource.c (tui_clear_source_content): Update.
2836         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2837         (tui_update_breakpoint_info): Update.
2838         (tui_set_exec_info_content): Update.
2839         * tui/tui-source.c (tui_set_source_content_nil): Update.
2840         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2841         has_break.
2842         * tui/tui-data.h (enum tui_bp_flag): New.
2843         (tui_bp_flags): New enum flags type.
2844         (struct tui_source_element) <break_mode>: Change type.  Rename
2845         from has_break.
2846         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2847         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2848         constants.
2849         * tui/tui-winsource.h: Fix comment.
2850
2851 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2852
2853         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2854         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2855         (store_fpregs_to_thread)
2856         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2857         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2858         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2859         (IWMMXT_REGS_SIZE): Add define.
2860         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2861         (fetch_vfp_regs, store_vfp_regs)
2862         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2863         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2864
2865 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2866
2867         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2868         defines.
2869         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2870         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2871         (ARM_INT_REGISTER_SIZE): ...to this.
2872         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2873         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2874         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2875         (arm_linux_collect_gregset, supply_nwfpe_register)
2876         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2877         defines.
2878         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2879         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2880         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2881         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2882         (arm_return_in_memory, arm_store_return_value)
2883         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2884         (arm_record_ld_st_multiple): Likewise.
2885         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2886         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2887
2888 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2889
2890         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2891         AARCH64_DISPLACED_MODIFIED_INSNS.
2892         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2893         (aarch64_displaced_step_copy_insn): Likewise.
2894         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2895         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2896         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2897         ARM_DISPLACED_MODIFIED_INSNS.
2898         * arm-tdep.c (arm_gdbarch_init): Likewise.
2899         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2900         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2901         (struct arm_displaced_step_closure): Use
2902         ARM_DISPLACED_MODIFIED_INSNS.
2903
2904 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2905
2906         * features/Makefile: Remove unused xml files.
2907         * features/aarch64.xml: Remove.
2908         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2909         * features/i386/amd64-avx-avx512.xml: Remove.
2910         * features/i386/amd64-avx-linux.xml: Remove.
2911         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2912         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2913         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2914         * features/i386/amd64-avx-mpx.xml: Remove.
2915         * features/i386/amd64-avx.xml: Remove.
2916         * features/i386/amd64-linux.xml: Remove.
2917         * features/i386/amd64-mpx-linux.xml: Remove.
2918         * features/i386/amd64-mpx.xml: Remove.
2919         * features/i386/amd64.xml: Remove.
2920         * features/i386/i386-avx-avx512-linux.xml: Remove.
2921         * features/i386/i386-avx-avx512.xml: Remove.
2922         * features/i386/i386-avx-linux.xml: Remove.
2923         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2924         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2925         * features/i386/i386-avx-mpx-linux.xml: Remove.
2926         * features/i386/i386-avx-mpx.xml: Remove.
2927         * features/i386/i386-avx.xml: Remove.
2928         * features/i386/i386-linux.xml: Remove.
2929         * features/i386/i386-mmx-linux.xml: Remove.
2930         * features/i386/i386-mmx.xml: Remove.
2931         * features/i386/i386-mpx-linux.xml: Remove.
2932         * features/i386/i386-mpx.xml: Remove.
2933         * features/i386/i386.xml: Remove.
2934         * features/i386/x32-avx-avx512-linux.xml: Remove.
2935         * features/i386/x32-avx-linux.xml: Remove.
2936         * features/i386/x32-linux.xml: Remove.
2937
2938 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2939
2940         * regformats/aarch64.dat: Remove.
2941         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2942         * regformats/i386/amd64-avx-linux.dat: Remove.
2943         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2944         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2945         * regformats/i386/amd64-linux.dat: Remove.
2946         * regformats/i386/amd64-mpx-linux.dat: Remove.
2947         * regformats/i386/amd64.dat: Remove.
2948         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2949         * regformats/i386/i386-avx-linux.dat: Remove.
2950         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2951         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2952         * regformats/i386/i386-linux.dat: Remove.
2953         * regformats/i386/i386-mmx-linux.dat: Remove.
2954         * regformats/i386/i386-mpx-linux.dat: Remove.
2955         * regformats/i386/i386.dat: Remove.
2956         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2957         * regformats/i386/x32-avx-linux.dat: Remove.
2958         * regformats/i386/x32-linux.dat: Remove.
2959
2960 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2961
2962         * aarch64-tdep.c: Remove xml self tests.
2963         * amd64-linux-tdep.c: Likewise.
2964         * amd64-tdep.c: Likewise.
2965         * i386-linux-tdep.c: Likewise.
2966         * i386-tdep.c: Likewise.
2967
2968 2019-07-03  Pedro Alves  <palves@redhat.com>
2969
2970         PR cli/24732
2971         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2972         (pipe_cmd_option_defs): New.
2973         (make_pipe_cmd_options_def_group): New.
2974         (pipe_command): Use gdb::option::process_options.
2975         (pipe_command_completer): New function.
2976         (_initialize_cli_cmds): Install completer for "pipe" command.
2977
2978 2019-07-03  Pedro Alves  <palves@redhat.com>
2979
2980         * cli/cli-option.c (union option_value) <string>: New field.
2981         (struct option_def_and_value): Add ctor, move ctor, dtor and
2982         use DISABLE_COPY_AND_ASSIGN.
2983         (option_def_and_value::clear_value): New.
2984         (parse_option, save_option_value_in_ctx, get_val_type_str)
2985         (add_setshow_cmds_for_options): Handle var_string.
2986         * cli-option.h (union option_def::var_address) <string>: New
2987         field.
2988         (struct string_option_def): New.
2989         * maint-test-options.c (struct test_options_opts): Add default
2990         ctor and use DISABLE_COPY_AND_ASSIGN.
2991         <string_opt>: New field.
2992         (test_options_opts::~test_options_opts): New.
2993         (test_options_opts::dump): Also dump "-string".
2994         (test_options_option_defs): Install "string.
2995
2996 2019-07-03  Pedro Alves  <palves@redhat.com>
2997
2998         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2999         option_value with a null enumeration.
3000         (complete_options): Save the option values in the context.
3001         (save_option_value_in_ctx): New, factored out from ...
3002         (process_options): ... here.
3003         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3004         of the function.
3005         * maint-test-options.c (test_options_opts::dump): New, factored
3006         out from ...
3007         (maintenance_test_options_command_mode): ... here.
3008         (maintenance_test_options_command_completion_result): Delete.
3009         (maintenance_test_options_command_completion_text): Update
3010         comment.
3011         (maintenance_show_test_options_completion_result): Change
3012         prototype.  Just print
3013         maintenance_test_options_command_completion_text.
3014         (save_completion_result): New.
3015         (maintenance_test_options_completer_mode): Pass options context to
3016         complete_options, and then save a dump.
3017         (_initialize_maint_test_options): Use add_cmd to install "maint
3018         show test-options-completion-result".
3019
3020 2019-07-03  Pedro Alves  <palves@redhat.com>
3021
3022         * NEWS (New commands): Mention "with" and "maint with".
3023         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3024         (with_command, with_command_completer): New.
3025         (pipe_command): Adjust to new repeat_previous
3026         interface.
3027         (_initialize_cli_cmds): Install the "with" command and its "w"
3028         alias.
3029         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3030         declarations.
3031         * cli/cli-setshow.c (parse_cli_var_uinteger)
3032         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3033         argument strings for all var_types.
3034         (get_setshow_command_value_string): New, factored out from ...
3035         (do_show_command): ... this.
3036         * cli/cli-setshow.h: Include <string>.
3037         (get_setshow_command_value_string): Declare.
3038         * command.h (repeat_previous): Now returns const char *.  Adjust
3039         comment.
3040         * maint.c: Include "cli/cli-cmds.h".
3041         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3042         (_initialize_maint_cmds): Register the "maintenance with" command.
3043         * top.c (repeat_previous): Move bits from pipe_command here:
3044         Return the saved command line, if any; error out if there's no
3045         command to relaunch.
3046
3047 2019-07-03  Pedro Alves  <palves@redhat.com>
3048
3049         * NEWS (New commands): Mention "maint set/show test-settings"
3050         instead of "maint test-settings".
3051         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3052         (maintenance_test_settings_set_list): Rename to ...
3053         (maintenance_set_test_settings_list): ... this.
3054         (maintenance_test_settings_show_list): Rename to  ...
3055         (maintenance_show_test_settings_list): ... this.
3056         (maintenance_test_settings_cmd): Delete.
3057         (maintenance_test_settings_set_cmd): ...
3058         (maintenance_set_test_settings_cmd): ... this.
3059         (maintenance_test_settings_show_cmd): ...
3060         (maintenance_show_test_settings_cmd): ... this.
3061         (maintenance_test_settings_show_value_cmd):
3062         (maintenance_show_test_settings_value_cmd): ... this.
3063         (_initialize_maint_test_settings): No longer install the "maint
3064         test-settings" prefix command.  Rename "maint test-settings set"
3065         to "maint set test-settings", and "maint test-settings show" to
3066         "maint show test-settings".  Adjust all subcommands.
3067
3068 2019-07-03  Pedro Alves  <palves@redhat.com>
3069
3070         * maint-test-settings.c: Fix file's intro comment.  Replace all
3071         references to "test-options" with references to "test-settings",
3072         in comments.
3073
3074 2019-07-03  Pedro Alves  <palves@redhat.com>
3075
3076         * maint-test-settings.c (maintenance_test_settings_xxx)
3077         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3078         New.
3079         (maintenance_test_settings_enums): Use them.
3080         (maintenance_test_settings_enum): Default to
3081         maintenance_test_settings_xxx.
3082         (_initialize_maint_test_settings): Initialize
3083         MAINTENANCE_TEST_SETTINGS_FILENAME.
3084
3085 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3086
3087         * breakpoint.h (remove_breakpoints_inf): Change return type to
3088         void, move function documentation here.
3089         * breakpoint.c (remove_breakpoints_inf): Change return type to
3090         void, move function documentation to header.
3091
3092 2019-07-02  Pedro Alves  <palves@redhat.com>
3093
3094         * NEWS (Completion improvements): Mention "info threads".
3095         * thread.c (struct info_threads_opts, info_threads_option_defs)
3096         (make_info_threads_options_def_group): New.
3097         (info_threads_command): Use gdb::option::process_options.
3098         (info_threads_command_completer): New.
3099         (_initialize_thread): Use gdb::option::build_help to build the
3100         help text for "info threads".
3101
3102 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3103
3104         * defs.h (generic_load): Move from here...
3105         * symfile.h (generic_load): ... to here.  Rename name parameter
3106         to args.
3107         * symfile.c (generic_load): Add comment.
3108
3109 2019-07-01  Tom Tromey  <tromey@adacore.com>
3110
3111         * dwarf2read.c
3112         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3113         declaration of without_params.  Fix formatting.
3114
3115 2019-07-01  Tom Tromey  <tromey@adacore.com>
3116
3117         * ada-exp.y (find_primitive_type): Update.
3118         * ada-lang.h (ada_lookup_symbol): Update.
3119         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3120         parameter.
3121         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3122
3123 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3124
3125         PR breakpoints/24541
3126         * gdbarch.c: Regenerate.
3127         * gdbarch.h: Regenerate.
3128         * gdbarch.sh: Add 'stap_adjust_register'.
3129         * i386-tdep.c: Include '<unordered_set>'.
3130         (i386_stap_adjust_register): New function.
3131         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3132         * stap-probe.c (stap_parse_register_operand): Call
3133         'gdbarch_stap_adjust_register'.
3134
3135 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3136
3137         PR python/24742
3138         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3139         * python/python.c (do_start_initialization): Use 'xmalloc'
3140         instead of 'PyMem_Malloc'.
3141
3142 2019-06-28  Tom Tromey  <tromey@adacore.com>
3143
3144         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3145         for Ada.
3146
3147 2019-06-27  Tom Tromey  <tromey@adacore.com>
3148
3149         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3150         objfile_key.
3151         (arm_find_mapping_symbol, arm_record_special_symbol)
3152         (_initialize_arm_tdep): Update.
3153         (arm_objfile_data_free): Remove.
3154
3155 2019-06-27  Tom Tromey  <tromey@adacore.com>
3156
3157         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3158         to cp_print_static_field.
3159
3160 2019-06-26  Tom Tromey  <tromey@adacore.com>
3161
3162         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3163         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3164         declare.
3165
3166 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3167
3168         * features/aarch64-core.c (create_feature_aarch64_core):
3169         Regenerate.
3170         * features/aarch64-core.xml: Add cpsr flags.
3171
3172 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3173
3174         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3175         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3176
3177 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3178
3179         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3180         field.
3181         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3182         use.
3183         (arm_record_special_symbol): Don't insert new symbol in sorted
3184         position, push it at the end.
3185
3186 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3187
3188         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3189         (arm_mapping_symbol_s): Remove.
3190         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3191         (arm_mapping_symbol_vec): New typedef.
3192         (struct arm_per_objfile): Add constructor.
3193         <section_maps>: Change type to
3194         std::unique_ptr<arm_mapping_symbol_vec[]>.
3195         (arm_compare_mapping_symbols): Remove.
3196         (arm_find_mapping_symbol): Adjust to section_maps type change.
3197         (arm_objfile_data_free): Call delete on arm_per_objfile.
3198         (arm_record_special_symbol): Adjust to section_maps type change.
3199         Allocate arm_per_objfile with new.
3200
3201 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3202
3203         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3204         with the command prefix.
3205
3206 2019-06-25  Tom Tromey  <tom@tromey.com>
3207
3208         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3209         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3210
3211 2019-06-25  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3214         type.
3215         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3216         protected.
3217
3218 2019-06-25  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-winsource.c
3221         (tui_source_window_base::set_is_exec_point_at): Add check against
3222         LOA_ADDRESS.
3223
3224 2019-06-25  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-source.c (tui_set_source_content): Don't check before
3227         xfree.
3228         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3229
3230 2019-06-25  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-winsource.h (tui_update_source_window_as_is)
3233         (tui_alloc_source_buffer, tui_line_is_displayed)
3234         (tui_addr_is_displayed): Change type of win_info.
3235         * tui/tui-winsource.c (tui_update_source_window_as_is)
3236         (tui_clear_source_content, tui_show_source_line)
3237         (tui_show_source_content, tui_source_window_base::refill)
3238         (tui_source_window_base::set_is_exec_point_at)
3239         (tui_source_window_base::set_is_exec_point_at)
3240         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3241         (tui_alloc_source_buffer, tui_line_is_displayed)
3242         (tui_addr_is_displayed): Change type of win_info.  Update.
3243         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3244         (tui_source_window_base::do_make_visible_with_new_height):
3245         Update.
3246         * tui/tui-source.c (tui_set_source_content)
3247         (tui_set_source_content_nil)
3248         (tui_source_window::do_scroll_vertical): Update.
3249         * tui/tui-layout.c (show_layout): Update.
3250         * tui/tui-disasm.c (tui_set_disassem_content)
3251         (tui_disasm_window::do_scroll_vertical): Update.
3252         * tui/tui-data.h (tui_win_content): Remove.
3253         (struct tui_gen_win_info) <content, content_size>: Remove.
3254         (struct tui_source_element): Add initializers and destructor.
3255         (union tui_which_element, struct tui_win_element): Remove.
3256         (struct tui_source_window_base) <content>: New field.
3257         (struct tui_data_window): Remove destructor.
3258         (tui_alloc_content, tui_free_win_content)
3259         (tui_free_all_source_wins_content): Don't declare.
3260         * tui/tui-data.c (tui_initialize_static_data): Update.
3261         (init_content_element, tui_alloc_content): Remove.
3262         (~tui_gen_win_info): Update.
3263         (~tui_data_window, tui_free_all_source_wins_content)
3264         (tui_free_win_content, free_content, free_content_elements):
3265         Remove.
3266
3267 2019-06-25  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-winsource.h (tui_clear_source_content)
3270         (tui_erase_source_content, tui_show_source_content): Change type
3271         of win_info.
3272         * tui/tui-winsource.c (tui_clear_source_content)
3273         (tui_erase_source_content, tui_show_source_content): Change type
3274         of win_info.
3275         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3276         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3277         win_info.
3278         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3279         win_info.
3280         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3281
3282 2019-06-25  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-winsource.c (tui_clear_source_content)
3285         (tui_source_window_base::set_is_exec_point_at): Update.
3286         * tui/tui-source.c (tui_set_source_content_nil): Update.
3287         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3288         a bool.
3289         * tui/tui-data.c (init_content_element): Update.
3290
3291 2019-06-25  Tom Tromey  <tom@tromey.com>
3292
3293         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3294         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3295         * tui/tui-layout.c (init_and_make_win): Update.
3296         * tui/tui.h (enum tui_win_type): Update.
3297         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3298         tui_win_is_auxillary.
3299         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3300         tui_win_is_auxillary.
3301
3302 2019-06-25  Tom Tromey  <tom@tromey.com>
3303
3304         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3305         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3306         (tui_delete_data_content_windows, tui_display_all_data)
3307         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3308         Update.
3309         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3310         * tui/tui-regs.c (tui_last_regs_line_no)
3311         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3312         (tui_show_registers): Update.
3313         (tui_show_register_group): Return void.  Update.
3314         (tui_display_registers_from, tui_display_reg_element_at_line)
3315         (tui_display_registers_from_line, tui_check_register_values):
3316         Update.
3317         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3318         member.
3319         (struct tui_data_window) <regs_content>: Now a std::vector.
3320         <regs_content_count>: Remove.
3321         (tui_add_content_elements, tui_free_data_content): Don't declare.
3322         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3323         (init_content_element): Remove DATA_WIN case.  Add assert.
3324         (tui_add_content_elements): Remove.
3325         (tui_data_window): Update.
3326         (tui_free_data_content): Remove.
3327         (free_content_elements): Remove DATA_WIN case.
3328
3329 2019-06-25  Tom Tromey  <tom@tromey.com>
3330
3331         * tui/tui-data.c (tui_data_item_window): Update.
3332         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3333         * tui/tui-windata.c (tui_display_all_data)
3334         (tui_display_data_from_line): Update.
3335         (tui_check_data_values): Remove.
3336         * tui/tui-regs.c (tui_show_register_group)
3337         (tui_display_reg_element_at_line): Update.
3338         * tui/tui-hooks.c (tui_register_changed)
3339         (tui_refresh_frame_and_register_information): Call
3340         tui_check_register_values.
3341         * tui/tui-data.h (struct tui_data_window) <data_content,
3342         data_content_count, data_type>: Remove.
3343         (enum tui_data_type): Remove.
3344
3345         * tui/tui-data.c (tui_data_window::clear_detail)
3346         (~tui_data_window): Update.
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3351         declare.
3352         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3353         Rename from tui_first_data_item_displayed.  Update.
3354         (tui_data_window::refresh_all)
3355         (tui_data_window::do_scroll_vertical): Update.
3356         * tui/tui-data.h (struct tui_data_window)
3357         <first_data_item_displayed>: Declare new method.
3358
3359 2019-06-25  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3362         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3363         contents...
3364         (tui_initialize_static_data): ...here.
3365
3366 2019-06-25  Tom Tromey  <tom@tromey.com>
3367
3368         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3369         (tui_display_registers_from, tui_check_register_values): Update.
3370         (tui_display_register): Remove win_info parameter; update.
3371         (tui_get_register): Change type of parameters.
3372         * tui/tui-data.h (struct tui_data_element): Remove.
3373         (union tui_which_element) <data>: Remove.
3374         <data_window>: Change type.
3375         (struct tui_data_item_window): New.
3376         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3377         case.  Add assert.
3378         (~tui_data_item_window): New destructor.
3379         (free_content_elements): Remove DATA_ITEM_WIN case.
3380
3381 2019-06-25  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3384         Remove.
3385
3386 2019-06-25  Tom Tromey  <tom@tromey.com>
3387
3388         * tui/tui-data.h (struct tui_command_element): Remove.
3389         (union tui_which_element) <command>: Remove.
3390         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3391         assert.
3392         (free_content_elements): Remove CMD_WIN case.
3393
3394 2019-06-25  Tom Tromey  <tom@tromey.com>
3395
3396         * tui/tui-layout.c (tui_set_layout): Update.
3397         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3398         * tui/tui-data.c (layout_def): Update.
3399
3400 2019-06-25  Tom Tromey  <tom@tromey.com>
3401
3402         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3403         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3404         (tui_source_window_base::set_new_height): Update.
3405         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3406         Update.
3407         (tui_set_locator_fullname, tui_set_locator_info)
3408         (tui_show_frame_info): Update.
3409         * tui/tui-source.c (tui_set_source_content)
3410         (tui_source_is_displayed): Update.
3411         * tui/tui-layout.c (show_source_disasm_command, show_data)
3412         (show_source_or_disasm_and_command): Update.
3413         * tui/tui-disasm.c (tui_set_disassem_content)
3414         (tui_get_begin_asm_address): Update.
3415         * tui/tui-data.h (struct tui_locator_element): Remove.
3416         (union tui_which_element) <locator>: Remove.
3417         (struct tui_locator_window): New.
3418         (tui_locator_win_info_ptr): Change return type.
3419         * tui/tui-data.c (_locator): Change type.
3420         (tui_locator_win_info_ptr): Change return type.
3421         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3422         (tui_alloc_content): Add assert.
3423
3424 2019-06-25  Tom Tromey  <tom@tromey.com>
3425
3426         * tui/tui-winsource.c
3427         (tui_exec_info_window::maybe_allocate_content): New method.
3428         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3429         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3430         (make_source_or_disasm_window): Add cast.
3431         * tui/tui-data.h (union tui_which_element) <simple_string>:
3432         Remove.
3433         (struct tui_source_info): New.
3434         (struct tui_source_window_base) <execution_info>: Change type.
3435         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3436         case, and add assert.
3437         (tui_alloc_content): Add assert.
3438
3439 2019-06-25  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3442         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3443         * tui/tui-data.c (tui_alloc_win_info): Remove.
3444
3445 2019-06-25  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3448         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3449         can_highlight.
3450
3451 2019-06-25  Tom Tromey  <tom@tromey.com>
3452
3453         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3454         make_visible_with_new_height method.
3455         (tui_win_info::make_visible_with_new_height): New method.
3456         (tui_source_window_base::do_make_visible_with_new_height)
3457         (tui_data_window::do_make_visible_with_new_height)
3458         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3459         (make_visible_with_new_height): Remove.
3460         (tui_resize_all, tui_adjust_win_heights): Use
3461         make_visible_with_new_height method.
3462         * tui/tui-data.h (struct tui_win_info)
3463         <do_make_visible_with_new_height, make_visible_with_new_height>:
3464         New methods.
3465         (struct tui_source_window_base, struct tui_data_window)
3466         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3467         methods.
3468
3469 2019-06-25  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3472         method.
3473         (update_tab_width): Call update_tab_width method.
3474         * tui/tui-data.h (struct tui_win_info)
3475         (struct tui_source_window_base) <update_tab_width>: New methods.
3476
3477 2019-06-25  Tom Tromey  <tom@tromey.com>
3478
3479         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3480         parameter.
3481         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3482         parameter.
3483         (tui_gen_win_info::make_visible): Update.
3484         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3485         parameter.
3486         * tui/tui-data.h (enum tui_box): New enum.
3487         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3488
3489 2019-06-25  Tom Tromey  <tom@tromey.com>
3490
3491         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3492         init_and_make_win for EXEC_INFO_WIN.
3493         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3494         longer inline.
3495         (struct tui_win_info) <~tui_win_info>: Inline.
3496         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3497         Don't declare.
3498         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3499         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3500         Remove.
3501         (tui_initialize_static_data): Update.
3502         (~tui_gen_win_info): Handle more cleanup here.
3503         (~tui_source_window_base): Delete "execution_info".
3504         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3505
3506 2019-06-25  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-layout.c (make_command_window): Don't set
3509         can_highlight.
3510         (show_source_disasm_command): Call the reset method.
3511         (show_data): Don't set can_highlight.  Call the reset method.
3512         (tui_gen_win_info::reset): Rename from init_gen_win_info
3513         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3514         (show_source_or_disasm_and_command): Call the reset method.
3515         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3516         (struct tui_cmd_window): Set can_highlight.
3517
3518 2019-06-25  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3521         from make_visible.
3522         (tui_make_visible, tui_make_invisible): Rewrite.
3523         (tui_win_info::make_visible): Remove.
3524         (tui_source_window_base::make_visible): Update.
3525         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3526         method.  Moved from...
3527         (struct tui_win_info) <make_visible>: ...here.
3528
3529 2019-06-25  Tom Tromey  <tom@tromey.com>
3530
3531         * tui/tui-winsource.c
3532         (tui_source_window_base::do_scroll_horizontal): Remove direction
3533         parameter.
3534         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3535         direction parameter.
3536         * tui/tui-win.c (tui_win_info::forward_scroll)
3537         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3538         (tui_win_info::right_scroll): Update.
3539         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3540         direction parameter.
3541         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3542         direction parameter.
3543         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3544         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3545         Remove direction parameter.
3546         (struct tui_source_window_base, struct tui_source_window)
3547         (struct tui_disasm_window, struct tui_data_window)
3548         (struct tui_cmd_window): Update.
3549
3550 2019-06-25  Tom Tromey  <tom@tromey.com>
3551
3552         * tui/tui-winsource.h (tui_set_exec_info_content)
3553         (tui_show_exec_info_content, tui_erase_exec_info_content)
3554         (tui_clear_exec_info_content, tui_update_exec_info): Change
3555         argument to tui_source_window_base.
3556         * tui/tui-winsource.c (tui_set_exec_info_content)
3557         (tui_show_exec_info_content, tui_erase_exec_info_content)
3558         (tui_clear_exec_info_content, tui_update_exec_info): Change
3559         argument to tui_source_window_base.
3560
3561 2019-06-25  Tom Tromey  <tom@tromey.com>
3562
3563         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3564         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3565
3566 2019-06-25  Tom Tromey  <tom@tromey.com>
3567
3568         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3569         check.
3570
3571 2019-06-25  Tom Tromey  <tom@tromey.com>
3572
3573         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3574         type to void.
3575         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3576         type to void.
3577         * tui/tui-source.c (tui_set_source_content): Update.
3578         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3579
3580 2019-06-25  Tom Tromey  <tom@tromey.com>
3581
3582         * tui/tui-win.c (window_name_completer, tui_set_focus)
3583         (tui_all_windows_info): Use name method.
3584         * tui/tui-data.h (struct tui_gen_win_info)
3585         (struct tui_source_window, struct tui_disasm_window)
3586         (struct tui_data_window, struct tui_cmd_window) <name>: New
3587         method.
3588         (tui_win_name): Don't declare.
3589         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3590         (tui_win_name): Remove.
3591
3592 2019-06-25  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-winsource.h (tui_update_source_window)
3595         (tui_update_source_window_as_is): Change parameter type.
3596         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3597         to be a tui_source_window_base.
3598         (tui_update_source_window_as_is): Likewise.
3599         * tui/tui-win.c (make_visible_with_new_height): Update.
3600
3601 2019-06-25  Tom Tromey  <tom@tromey.com>
3602
3603         * tui/tui-winsource.c (tui_erase_source_content)
3604         (tui_show_source_content, tui_show_exec_info_content)
3605         (tui_erase_exec_info_content): Use refresh_window method.
3606         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3607         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3608         from tui_refresh_win.
3609         (tui_data_window::refresh_window): New method.
3610         (tui_win_info::refresh, tui_source_window_base::refresh)
3611         (tui_refresh_all): Use refresh_window method.
3612         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3613         method.
3614         * tui/tui-regs.c (tui_display_register): Call refresh_window
3615         method.
3616         * tui/tui-layout.c (show_source_disasm_command)
3617         (show_source_or_disasm_and_command): Call refresh_window method.
3618         * tui/tui-data.h (struct tui_gen_win_info)
3619         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3620         New method.
3621
3622 2019-06-25  Tom Tromey  <tom@tromey.com>
3623
3624         * tui/tui.c (tui_rl_other_window, tui_enable)
3625         (tui_is_window_visible, tui_get_command_dimension): Update.
3626         * tui/tui-winsource.c (tui_update_source_window_as_is)
3627         (tui_clear_source_content, tui_erase_source_content)
3628         (tui_show_source_line, tui_source_window_base::refill)
3629         (tui_source_window_base::do_scroll_horizontal)
3630         (tui_source_window_base::set_is_exec_point_at)
3631         (tui_update_breakpoint_info, tui_set_exec_info_content)
3632         (tui_alloc_source_buffer, tui_line_is_displayed)
3633         (tui_addr_is_displayed): Update.
3634         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3635         (tui_check_and_display_highlight_if_needed)
3636         (tui_win_info::make_visible, tui_win_info::refresh)
3637         (tui_refresh_all): Update.
3638         * tui/tui-windata.c (tui_first_data_item_displayed)
3639         (tui_delete_data_content_windows, tui_erase_data_content)
3640         (tui_display_all_data, tui_data_window::refresh_all)
3641         (tui_check_data_values): Update.
3642         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3643         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3644         (tui_win_info::backward_scroll, tui_refresh_all_win)
3645         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3646         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3647         (tui_source_window_base::set_new_height)
3648         (tui_data_window::set_new_height)
3649         (make_invisible_and_set_new_height)
3650         (make_visible_with_new_height, new_height_ok)
3651         (parse_scrolling_args): Update.
3652         * tui/tui-stack.c (tui_show_frame_info): Update.
3653         * tui/tui-source.c (tui_set_source_content)
3654         (tui_set_source_content_nil, tui_source_is_displayed)
3655         (tui_source_window::do_scroll_vertical): Update.
3656         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3657         (tui_display_registers_from, tui_display_reg_element_at_line)
3658         (tui_check_register_values, tui_reg_command): Update.
3659         * tui/tui-layout.c (tui_default_win_height)
3660         (show_source_disasm_command, show_data, init_and_make_win)
3661         (show_source_or_disasm_and_command): Update.
3662         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3663         (tui_redisplay_readline, tui_mld_flush)
3664         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3665         (tui_getc): Update.
3666         * tui/tui-disasm.c (tui_set_disassem_content)
3667         (tui_disasm_window::do_scroll_vertical): Update.
3668         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3669         Now virtual.
3670         (struct tui_win_info): Derive from tui_gen_win_info.
3671         <~tui_win_info>: Mark as override.
3672         <generic>: Remove member.
3673         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3674         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3675         (~tui_data_window, ~tui_win_info)
3676         (tui_free_all_source_wins_content): Update.
3677         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3678
3679 2019-06-25  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-layout.c (init_and_make_win): Use new.
3682         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3683         destructor, initializers.
3684         (tui_alloc_generic_win_info): Don't declare.
3685         * tui/tui-data.c (_locator): Add argument to constructor.
3686         (source_win, disasm_win): New globals.
3687         (exec_info): Remove.
3688         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3689         Update.
3690         (tui_alloc_generic_win_info): Remove.
3691         (init_content_element): Use new.
3692         (tui_win_info::tui_win_info): Update.
3693         (free_content_elements) <case DATA_WIN>: Use delete.
3694
3695 2019-06-25  Tom Tromey  <tom@tromey.com>
3696
3697         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3698         * tui/tui-windata.c (tui_first_data_item_displayed)
3699         (tui_delete_data_content_windows): Update.
3700         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3701         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3702         (tui_display_registers_from, tui_check_register_values): Update.
3703         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3704         pointer.
3705         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3706         window.
3707         (tui_free_data_content): Update.
3708         (free_content_elements) <case DATA_WIN>: Free the window.
3709
3710 2019-06-25  Tom Tromey  <tom@tromey.com>
3711
3712         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3713         Update.
3714         * tui/tui-layout.c (make_command_window)
3715         (show_source_disasm_command, show_data, init_and_make_win)
3716         (show_source_or_disasm_and_command): Update.
3717         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3718         method.
3719         <can_highight, is_highlighted>: Now bool.
3720         (tui_set_win_highlight): Don't declare.
3721         * tui/tui-data.c (tui_set_win_highlight): Remove.
3722
3723 2019-06-25  Tom Tromey  <tom@tromey.com>
3724
3725         * tui/tui-wingeneral.c (make_visible): Remove check of window
3726         type.
3727
3728 2019-06-25  Tom Tromey  <tom@tromey.com>
3729
3730         * tui/tui-win.c (tui_win_info::max_height)
3731         (tui_cmd_window::max_height): New methods.
3732         (new_height_ok): Call max_height.
3733         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3734         <max_height>: New method.
3735
3736 2019-06-25  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-win.c (tui_source_window_base::set_new_height)
3739         (tui_data_window::set_new_height): New methods.
3740         (make_invisible_and_set_new_height): Call set_new_height method.
3741         * tui/tui-data.h (struct tui_win_info)
3742         (struct tui_source_window_base, struct tui_data_window)
3743         <set_new_height>: New method.
3744
3745 2019-06-25  Tom Tromey  <tom@tromey.com>
3746
3747         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3748         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3749         tui_refresh_data_win.
3750         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3751         method.
3752         (tui_refresh_all_win): Call the refresh_all method.
3753         (tui_set_focus): Likewise.
3754         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3755         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3756         Likewise.
3757
3758 2019-06-25  Tom Tromey  <tom@tromey.com>
3759
3760         * tui/tui-winsource.h (tui_refill_source_window)
3761         (tui_set_is_exec_point_at): Don't declare.
3762         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3763         (tui_source_window_base::refill): Rename from
3764         tui_refill_source_window.
3765         (tui_source_window_base::do_scroll_horizontal): Update.
3766         (tui_source_window_base::set_is_exec_point_at): Rename from
3767         tui_set_is_exec_point_at.
3768         (tui_update_all_breakpoint_info): Update.
3769         * tui/tui-stack.c (tui_show_frame_info): Update.
3770         * tui/tui-layout.c (show_data): Add cast.
3771         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3772         * tui/tui-data.h (struct tui_source_window_base) <refill,
3773         set_is_exec_point_at>: New methods.
3774         (tui_source_windows, tui_add_to_source_windows): Update types.
3775         (tui_add_to_source_windows): Remove redundant declaration.
3776         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3777         (tui_source_windows): Change return type.
3778         (tui_clear_source_windows_detail): Update.
3779         (tui_add_to_source_windows): Change type of parameter.
3780         (tui_free_all_source_wins_content): Update.
3781
3782 2019-06-25  Tom Tromey  <tom@tromey.com>
3783
3784         * tui/tui-wingeneral.c (tui_win_info::refresh)
3785         (tui_source_window_base::refresh): New methods.
3786         (tui_refresh_all): Call the refresh method.
3787         * tui/tui-data.h (struct tui_win_info)
3788         (struct tui_source_window_base) <refresh>: New method.
3789
3790 2019-06-25  Tom Tromey  <tom@tromey.com>
3791
3792         * tui/tui.h (tui_is_window_visible): Return bool.
3793         * tui/tui.c (tui_is_window_visible): Return bool.
3794         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3795         (tui_make_visible, tui_make_invisible)
3796         (tui_win_info::make_visible)
3797         (tui_source_window_base::make_visible, make_all_visible)
3798         (tui_make_all_visible, tui_make_all_invisible): Update.
3799         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3800         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3801         bool.
3802         (struct tui_win_info, struct tui_source_window_base)
3803         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3804         * tui/tui-data.c (tui_init_generic_part): Update.
3805
3806 2019-06-25  Tom Tromey  <tom@tromey.com>
3807
3808         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3809         (tui_source_window_base::make_visible): New methods.
3810         (make_all_visible): Make method call.
3811         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3812         (struct tui_source_window_base, struct tui_cmd_window): Override
3813         make_visible.
3814         (tui_win_is_source_type): Don't declare.
3815         * tui/tui-data.c (tui_win_is_source_type): Remove.
3816
3817 2019-06-25  Tom Tromey  <tom@tromey.com>
3818
3819         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3820         NULL check.
3821
3822 2019-06-25  Tom Tromey  <tom@tromey.com>
3823
3824         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3825         Inline constructor.  Add initializers for members.
3826         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3827         constructors; now inline in class.
3828
3829 2019-06-25  Tom Tromey  <tom@tromey.com>
3830
3831         * tui/tui-regs.c (tui_show_registers): Update.
3832         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3833         bool.
3834         * tui/tui-data.c (tui_data_window::clear_detail)
3835         (tui_data_window): Update.
3836
3837 2019-06-25  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-windata.c (tui_display_all_data)
3840         (tui_display_data_from_line, tui_display_data_from)
3841         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3842         Update.
3843         * tui/tui-regs.c (tui_last_regs_line_no)
3844         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3845         (tui_show_registers, tui_show_register_group)
3846         (tui_display_registers_from, tui_display_reg_element_at_line)
3847         (tui_display_registers_from_line, tui_check_register_values)
3848         (tui_reg_next, tui_reg_prev): Update.
3849         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3850         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3851         tui_data_window.
3852         (struct tui_win_info) <detail>: Remove.  Add new fields from
3853         tui_data_info.
3854         (TUI_DATA_WIN): Add cast.
3855         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3856         (~tui_data_window): Simplify.
3857
3858 2019-06-25  Tom Tromey  <tom@tromey.com>
3859
3860         * tui/tui-layout.c (show_source_disasm_command)
3861         (show_source_or_disasm_and_command): Update.
3862         * tui/tui-io.c (update_cmdwin_start_line)
3863         (tui_redisplay_readline): Update.
3864         * tui/tui-data.h (struct tui_command_info): Remove.
3865         (struct tui_win_info) <detail>: Remove command_info member.
3866         (struct tui_data_window) <start_line>: New member, from
3867         tui_command_info.
3868         (TUI_CMD_WIN): Add casts.
3869
3870 2019-06-25  Tom Tromey  <tom@tromey.com>
3871
3872         * tui/tui-winsource.c (tui_update_source_window)
3873         (tui_refill_source_window)
3874         (tui_source_window_base::do_scroll_horizontal)
3875         (tui_update_breakpoint_info, tui_set_exec_info_content)
3876         (tui_show_exec_info_content, tui_erase_exec_info_content)
3877         (tui_clear_exec_info_content): Update.
3878         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3879         Update.
3880         * tui/tui-win.c (make_invisible_and_set_new_height)
3881         (make_visible_with_new_height): Update.
3882         * tui/tui-source.c (tui_set_source_content)
3883         (tui_show_symtab_source): Update.
3884         * tui/tui-layout.c (extract_display_start_addr)
3885         (show_source_disasm_command, show_data)
3886         (make_source_or_disasm_window)
3887         (show_source_or_disasm_and_command): Update.
3888         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3889         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3890         "gdbarch".
3891         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3892         to tui_source_window_base.
3893         (struct tui_win_info) <detail>: Remove source_info member.
3894         (struct tui_source_window_base) <has_locator>: Inline.
3895         Move contents from tui_source_info; rename has_locator member to
3896         m_has_locator.
3897         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3898         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3899         header file.
3900         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3901         Simplify.
3902         (tui_free_all_source_wins_content): Cast to
3903         tui_source_window_base.
3904
3905 2019-06-25  Tom Tromey  <tom@tromey.com>
3906
3907         * tui/tui-win.c (make_invisible_and_set_new_height)
3908         (make_visible_with_new_height): Call has_locator method.
3909         * tui/tui-layout.c (show_source_disasm_command, show_data)
3910         (show_source_or_disasm_and_command): Update for bool change.
3911         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3912         (tui_win_info) <has_locator>: New method.
3913         (struct tui_source_window_base) <has_locator>: New method.
3914         (tui_win_has_locator): Don't declare.
3915         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3916         from tui_win_has_locator.
3917         (tui_source_window_base): Use false, not FALSE.
3918
3919 2019-06-25  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3922         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3923         clear_detail method directly.
3924         (tui_clear_win_detail): Remove.
3925
3926 2019-06-25  Tom Tromey  <tom@tromey.com>
3927
3928         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3929         "this", not TUI_DISASM_WIN.
3930
3931 2019-06-25  Tom Tromey  <tom@tromey.com>
3932
3933         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3934         declare.
3935         * tui/tui-winsource.c
3936         (tui_source_window_base::do_scroll_horizontal): Rename from
3937         tui_horizontal_source_scroll.
3938         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3939         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3940         from tui_vertical_data_scroll.
3941         * tui/tui-win.h (tui_scroll): Don't declare.
3942         * tui/tui-win.c (tui_win_info::forward_scroll)
3943         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3944         (tui_win_info::right_scroll): Rename and update.
3945         (tui_scroll_forward_command, tui_scroll_backward_command)
3946         (tui_scroll_left_command, tui_scroll_right_command): Update.
3947         (tui_scroll): Remove.
3948         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3949         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3950         from tui_vertical_source_scroll.
3951         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3952         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3953         from tui_vertical_disassem_scroll.
3954         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3955         do_scroll_horizontal>: New methods.
3956         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3957         Likewise.
3958         (struct tui_source_window_base): Add do_scroll_horizontal.
3959         (struct tui_source_window, struct tui_disasm_window): Add
3960         do_scroll_vertical.
3961         (struct tui_data_window, struct tui_cmd_window): Add
3962         do_scroll_horizontal and do_scroll_vertical.
3963         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3964
3965 2019-06-25  Tom Tromey  <tom@tromey.com>
3966
3967         * tui/tui-data.h (struct tui_source_window_base): New struct.
3968         (struct tui_source_window): Derive from tui_source_window_base.
3969         (struct tui_disasm_window): New struct.
3970         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3971         from tui_source_window::clear_detail.
3972         (tui_source_window_base): Rename from tui_source_window.
3973         (~tui_source_window_base): Rename from ~tui_source_window.
3974         (tui_alloc_win_info): Create a tui_disasm_window.
3975
3976 2019-06-25  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui-data.h (struct tui_source_window)
3979         (struct tui_data_window): Declare destructors.
3980         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3981         destructors.
3982         (tui_win_info): Simplify.
3983
3984 2019-06-25  Tom Tromey  <tom@tromey.com>
3985
3986         * tui/tui-winsource.c (tui_display_main)
3987         (tui_update_source_windows_with_addr)
3988         (tui_update_all_breakpoint_info): Update.
3989         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3990         (new_height_ok, parse_scrolling_args): Update.
3991         * tui/tui-stack.c (tui_show_frame_info): Update.
3992         * tui/tui-data.h (struct tui_list): Remove.
3993         (tui_source_windows): Return a reference to a std::vector.
3994         * tui/tui-data.c (source_windows): Now a std::vector.
3995         (tui_source_windows): Change return type.
3996         (tui_clear_source_windows): Rewrite.
3997         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3998         (tui_free_all_source_wins_content): Rewrite.
3999
4000 2019-06-25  Tom Tromey  <tom@tromey.com>
4001
4002         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4003         (struct tui_data_window, struct tui_cmd_window): Declare
4004         clear_detail method.
4005         * tui/tui-data.c (tui_source_window::clear_detail)
4006         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4007         methods.
4008         (tui_clear_win_detail): Simplify.
4009
4010 2019-06-25  Tom Tromey  <tom@tromey.com>
4011
4012         * tui/tui-layout.c (make_source_window, make_disasm_window)
4013         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4014         Return the new window.
4015         (show_source_disasm_command, show_data)
4016         (show_source_or_disasm_and_command): Update.
4017
4018 2019-06-25  Tom Tromey  <tom@tromey.com>
4019
4020         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4021         parameter.  Return the new window.
4022         (show_source_disasm_command): Update and remove NULL check.
4023         (show_source_or_disasm_and_command): Update.
4024
4025 2019-06-25  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4028
4029 2019-06-25  Tom Tromey  <tom@tromey.com>
4030
4031         * tui/tui-data.h (struct tui_win_info): Make constructor
4032         protected.  Make destructor virtual.  Add initializers.
4033         (tui_source_window, tui_data_window, tui_cmd_window): New
4034         classes.
4035         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4036         constructor.  Add "type" parameter.
4037         (tui_source_window, tui_data_window, tui_cmd_window): New
4038         constructors.
4039         (tui_alloc_win_info): Instantiate the appropriate subclass.
4040
4041 2019-06-25  Tom Tromey  <tom@tromey.com>
4042
4043         * tui/tui-win.c (tui_resize_all): Use delete.
4044         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4045         destructor.
4046         (tui_free_window): Don't declare.
4047         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4048         Update.
4049
4050 2019-06-25  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-data.h (struct tui_win_info): Add constructor.
4053         * tui/tui-data.c (tui_alloc_win_info): Use new.
4054         (tui_free_window): Use delete.
4055
4056 2019-06-22  Tom Tromey  <tom@tromey.com>
4057
4058         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4059         declare.
4060         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4061
4062 2019-06-22  Tom Tromey  <tom@tromey.com>
4063
4064         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4065         declare.
4066         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4067
4068 2019-06-22  Tom de Vries  <tdevries@suse.de>
4069
4070         * dwarf2read.c (create_addrmap_from_aranges)
4071         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4072         instead of '%zu'.
4073
4074 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4075
4076         * dwarf2read.h (dwarf2_section_info_def): Remove.
4077         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4078         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4079         std::vector<dwarf2_section_info>.
4080         (struct dwo_file) <~dwo_file>: Remove.
4081         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4082         types field.
4083         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4084         (dwarf2_read_debug_names): Likewise.
4085         (create_debug_types_hash_table): Change parameter type to
4086         array_view, adjust code accordingly.
4087         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4088         (partial_die_info::fixup): Likewise.
4089         (determine_prefix): Likewise.
4090         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4091
4092 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4093
4094         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4095         gdb_bfd_ref_ptr.
4096         <~dwo_file>: Remove call to gdb_bfd_unref.
4097         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4098         gdb_bfd_ref_ptr::get.
4099
4100 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4101
4102         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4103         type to htab_up.
4104         * dwarf2read.c (struct dwo_file): Initialize fields.
4105         <~dwo_file>: New.
4106         (free_dwo_file): Remove, move content to ~dwo_file.
4107         (struct dwo_file_deleter): Remove.
4108         (dwo_file_up>: Remove custom deleter.
4109         (free_dwo_files): Remove.
4110         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4111         dwo_files.
4112         (process_skeletonless_type_units): Call unique_ptr::get.
4113         (allocate_dwo_file_hash_table): Add deleter to created hash
4114         table.  Change return type to htab_up.
4115         (lookup_dwo_file_slot): Don't memset dwo_file, call
4116         unique_ptr::get.
4117         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4118         (create_dwo_unit_in_dwp_v2): Likewise.
4119         (open_and_init_dwo_file): Likewise.
4120         (free_dwo_file_from_slot): Remove.
4121
4122 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4123
4124         * dwarf2read.h (struct dwarf2_section_info) <readin,
4125         is_virtual>: Change type to bool.
4126         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4127         true instead of 1.
4128
4129 2019-06-19  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-data.h (tui_init_content_element): Don't declare.
4132
4133 2019-06-19  Tom Tromey  <tom@tromey.com>
4134
4135         * tui/tui-data.h (tui_init_win_info): Don't declare.
4136
4137 2019-06-19  Tom de Vries  <tdevries@suse.de>
4138
4139         * dwarf2read.h (abstract_to_concrete): Change type to
4140         std::unordered_map<sect_offset, std::vector<sect_offset>,
4141         gdb::hash_enum<sect_offset>>.
4142
4143 2019-06-19  Tom Tromey  <tromey@adacore.com>
4144
4145         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4146         EVAL_AVOID_SIDE_EFFECTS specially.
4147
4148 2019-06-19  Tom Tromey  <tromey@adacore.com>
4149
4150         * source-cache.c (highlighter): New global.
4151         (source_cache::get_source_lines): Create a highlighter on demand.
4152
4153 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4154
4155         * defs.h (deprecated_interactive_hook): Delete declaration.
4156         * interps.c (clear_interpreter_hooks): Remove use of
4157         deprecated_interactive_hook.
4158         * top.c (deprecated_interactive_hook): Delete definition.
4159         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4160
4161 2019-06-18  Tom de Vries  <tdevries@suse.de>
4162
4163         PR gdb/24515
4164         * dwarf2read.h (abstract_to_concrete): Change type from
4165         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4166         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4167         * dwarf2read.c (read_variable): Update.
4168         (dwarf2_fetch_die_loc_sect_off): Update.
4169
4170 2019-06-17  Tom de Vries  <tdevries@suse.de>
4171
4172         PR gdb/24617
4173         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4174         accessing parent[parent_len - 1].
4175
4176 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4177
4178         PR gdb/24364
4179         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4180         call dtrace_process_dof with NULL dof.
4181
4182 2019-06-16  Tom de Vries  <tdevries@suse.de>
4183
4184         PR gdb/24445
4185         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4186
4187 2019-06-16  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4190         (make_all_visible): Use address of member.
4191
4192 2019-06-16  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4195         (tui_free_window, free_content, free_content_elements): Remove
4196         unnecessary cast.
4197         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4198         cast.
4199         * tui/tui-regs.c (tui_show_register_group)
4200         (tui_display_registers_from, tui_display_reg_element_at_line):
4201         Remove unnecessary cast.
4202
4203 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4204
4205         * linux-nat.c (normal_mask): Delete.
4206         (_initialize_linux_nat): Don't initialise normal_mask.
4207
4208 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4209
4210         PR gdb/24445
4211         * dwarf-index-write.h (write_psymtabs_to_index): Add
4212         dwz_basename parameter.
4213         * dwarf-index-write.c (write_gdbindex): Move file writing to
4214         write_gdbindex_1.  Change return type void.
4215         (assert_file_size): Move up, remove filename parameter.
4216         (write_gdbindex_1): New function.
4217         (write_debug_names): Change return type to void, call
4218         assert_file_size.
4219         (struct index_wip_file): New struct.
4220         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4221         file logic to index_wip_file.  Write index for dwz file if
4222         needed.
4223         (save_gdb_index_command): Pass basename of dwz file, if present.
4224         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4225         build-id of dwz file, if present.
4226         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4227         (dwarf2_get_dwz_file): Likewise.
4228         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4229         (dwarf2_get_dwz_file): Likewise.
4230
4231 2019-06-16  Tom Tromey  <tom@tromey.com>
4232
4233         * coffread.c (process_coff_symbol): Use xstrdup.
4234         * value.c (create_internalvar): Use xstrdup.
4235
4236 2019-06-16  Tom Tromey  <tom@tromey.com>
4237
4238         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4239         * breakpoint.c (stopin_command, stopat_command)
4240         (until_break_command, decode_location_default): Remove unnecessary
4241         cast.
4242         * utils.c (subset_compare): Remove unnecessary cast.
4243         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4244         cast.
4245         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4246         cast.
4247         * infcmd.c (path_command): Remove unnecessary cast.
4248         * coffread.c (decode_type): Remove unnecessary cast.
4249         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4250         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4251         * tui/tui-stack.c (tui_show_locator_content)
4252         (tui_show_frame_info): Remove unnecessary cast.
4253         * tui/tui-win.c (tui_scroll_forward_command)
4254         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4255         (parse_scrolling_args): Remove unnecessary cast.
4256         * tui/tui-data.c (init_win_info, tui_del_window)
4257         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4258         (free_content_elements): Remove unnecessary cast.
4259         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4260         unnecessary cast.
4261         * tui/tui-source.c (tui_set_source_content)
4262         (tui_vertical_source_scroll): Remove unnecessary cast.
4263         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4264         cast.
4265         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4266         * tui/tui-regs.c (tui_display_registers_from)
4267         (tui_display_register): Remove unnecessary cast.
4268         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4269         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4270         (make_visible): Remove unnecessary cast.
4271         * tui/tui-winsource.c (tui_erase_source_content)
4272         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4273         unnecessary cast.
4274         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4275         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4276         * stabsread.c (read_type, read_array_type, read_range_type):
4277         Remove unnecessary cast.
4278         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4279         (parse_symbol, parse_type, upgrade_type, parse_external)
4280         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4281         unnecessary cast.
4282         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4283
4284 2019-06-16  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-data.c (tui_alloc_generic_win_info)
4287         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4288         checks.
4289
4290 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4291             Andrew Burgess  <andrew.burgess@embecosm.com>
4292
4293         * f-typeprint.c (f_print_type): Don't return early for not
4294         associated or not allocated types.
4295         (f_type_print_varspec_suffix): Add print_rank parameter and print
4296         ranks of array types in case they dangling.
4297         (f_type_print_base): Add print_rank parameter.
4298
4299 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4300
4301         * NEWS: Mention new MI commands.
4302         * break-catch-throw.c (enum exception_event_kind): Move to
4303         breakpoint.h.
4304         (print_mention_exception_catchpoint): Output text as a single
4305         message.
4306         (catch_exception_command_1): Rename to...
4307         (catch_exception_event): ...this, make non-static, update header
4308         command, and change some parameter types.
4309         (catch_catch_command): Update for changes to
4310         catch_exception_command_1.
4311         (catch_throw_command): Likewise.
4312         (catch_rethrow_command): Likewise.
4313         * breakpoint.c (enum exception_event_kind): Delete.
4314         * breakpoint.h (enum exception_event_kind): Moved here from
4315         break-catch-throw.c.
4316         (catch_exception_event): Declare.
4317         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4318         (mi_cmd_catch_throw): New function.
4319         (mi_cmd_catch_rethrow): New function.
4320         (mi_cmd_catch_catch): New function.
4321         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4322         'catch-catch' entries.
4323         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4324         (mi_cmd_catch_rethrow): Declare.
4325         (mi_cmd_catch_catch): Declare.
4326
4327 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4328
4329         * annotate.c (annotate_source_line): Change return type to void,
4330         update implementation to match.
4331         * annotate.h (annotate_source_line): Change return type to void,
4332         update header comment.
4333         * stack.c (print_frame_info): Don't change what frame information
4334         is printed based on whether annotations are on or not.
4335
4336 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4339         (annotate_source): Make static.
4340         (annotate_source_line): Moved from source.c and renamed from
4341         identify_source_line.  Update the return type.
4342         * annotate.h (annotate_source): Delete declaration.
4343         (annotate_source_line): Declaration moved from source.h, and
4344         renamed from identify_source_line.  Return type updated.
4345         * source.c (identify_source_line): Moved to annotate.c and renamed
4346         to annotate_source_line.
4347         (info_line_command): Remove check of annotation_level.
4348         * source.h (identify_source_line): Move declaration to annotate.h
4349         and rename to annotate_source_line.
4350         * stack.c: Add 'annotate.h' include.
4351         (print_frame_info): Remove check of annotation_level before
4352         calling annotate_source_line.
4353
4354 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4355
4356         * source-cache.c (source_cache::get_plain_source_lines): Use
4357         open_source_file_with_line_charpos instead of just
4358         open_source_file, remove call to find_source_lines.
4359         (source_cache::get_source_lines): Likewise.
4360         * source.c (find_source_lines): Make static.
4361         (get_filename_and_charpos): Renamed into...
4362         (open_source_file_with_line_charpos): ..this along with changes to
4363         return a scoped_fd, and some other minor clean ups.
4364         (identify_source_line): Use open_source_file_with_line_charpos.
4365         (search_command_helper): Use open_source_file_with_line_charpos
4366         instead of just open_source_file, remove call to
4367         find_source_lines.
4368         * source.h (open_source_file_with_line_charpos): Declare new
4369         function.
4370         (find_source_lines): Delete declaration.
4371
4372 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4373
4374         * source.c (get_filename_and_charpos): Remove fullname
4375         parameter.
4376         (identify_source_line): Update call to get_filename_and_charpos.
4377
4378 2019-06-14  Tom Tromey  <tromey@adacore.com>
4379
4380         PR gdb/24502:
4381         * ui-style.h (skip_ansi_escape): Update comment.
4382         * ui-file.h (class no_terminal_escape_file): New class.
4383         * ui-file.c (no_terminal_escape_file::write)
4384         (no_terminal_escape_file::puts): New methods.
4385         * cli/cli-logging.c (handle_redirections): Use
4386         no_terminal_escape_file.
4387
4388 2019-06-14  Tom Tromey  <tromey@adacore.com>
4389
4390         * NEWS: Move convenience variable news above Python news.
4391
4392 2019-06-14  Tom Tromey  <tom@tromey.com>
4393
4394         * gnulib: Move directory to top-level.
4395         * configure.ac: Don't configure gnulib.
4396         * configure: Rebuild.
4397         * common/common-defs.h: Use new path to gnulib.
4398         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4399         (GNULIB_H): Remove.
4400         (INCGNU): Look in new gnulib location.
4401         (HFILES_NO_SRCDIR): Remove gnulib files.
4402         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4403         (generated_files): Remove GNULIB_H.
4404         ($(LIBGNU), all-lib): Remove targets.
4405         (distclean): Don't mention GNULIB_BUILDDIR.
4406         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4407
4408 2019-06-14  Tom Tromey  <tromey@adacore.com>
4409
4410         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4411         Warn if symbol file does not provide any symbols.
4412
4413 2019-06-14  Tom Tromey  <tromey@adacore.com>
4414
4415         * source.c (find_and_open_source): Respect basenames_may_differ.
4416
4417 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         * annotate.c (annotate_breakpoints_invalid): Make use of
4420         scoped_restore_terminal_state.
4421         (annotate_frames_invalid): Likewise.
4422
4423 2019-06-14  Tom Tromey  <tromey@adacore.com>
4424
4425         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4426         allow assignment to an internalvar.
4427
4428 2019-06-14  Tom Tromey  <tromey@adacore.com>
4429
4430         * ada-lex.l: Allow "_" in attribute names.
4431
4432 2019-06-14  Tom Tromey  <tromey@adacore.com>
4433
4434         PR gdb/24653:
4435         * regcache.c (registers_changed): Don't call alloca.
4436         * top.c (execute_command): Don't call alloca.
4437
4438 2019-06-13  Pedro Alves  <palves@redhat.com>
4439
4440         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4441         'expression'.  When parsing an expression, error out if there's
4442         junk after "unlimited".
4443         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4444         (do_set_command): Adjust calls to is_unlimited_literal.
4445
4446 2019-06-13  Pedro Alves  <palves@redhat.com>
4447
4448         * compile/compile.c (make_compile_options_def_group): Add braces
4449         around array_view initializer.
4450         * thread.c (make_thread_apply_all_options_def_group)
4451         (make_thread_apply_all_options_def_group): Likewise.
4452
4453 2019-06-13  Pedro Alves  <palves@redhat.com>
4454
4455         * NEWS (New commands): Mention "maint test-options
4456         require-delimiter", "maint test-options unknown-is-error", "maint
4457         test-options unknown-is-operand" and "maint show
4458         test-options-completion-result".
4459         (New command options, command completion): New section.
4460         (Completion improvements): New section.
4461         Mention that you can abbreviate "unlimited".
4462
4463 2019-06-13  Pedro Alves  <palves@redhat.com>
4464
4465         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4466         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4467         * unittests/cli-utils-selftests.c (test_parse_flags)
4468         (test_parse_flags_qcs): Delete.
4469         (test_cli_utils): Don't call deleted functions.
4470
4471 2019-06-13  Pedro Alves  <palves@redhat.com>
4472
4473         * thread.c: Include "cli/cli-option.h".
4474         (tp_array_compar_ascending): Global.
4475         (tp_array_compar): Delete function.
4476         (tp_array_compar_ascending, tp_array_compar_descending): New
4477         functions.
4478         (ascending_option_def, qcs_flag_option_def)
4479         (thr_qcs_flags_option_defs)
4480         (make_thread_apply_all_options_def_group)
4481         (make_thread_apply_options_def_group): New.
4482         (thread_apply_all_command): Use gdb::option::process_options.
4483         (thread_apply_command_completer)
4484         (thread_apply_all_command_completer): New.
4485         (thread_apply_command): Use gdb::option::process_options.
4486         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4487         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4488         to generate help text of "thread apply".  Adjust "taas"'s help.
4489         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4490         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4491
4492 2019-06-13  Pedro Alves  <palves@redhat.com>
4493
4494         * thread.c (thread_apply_command): Check for invalid TID with
4495         isdigit instead of !isalpha.
4496
4497 2019-06-13  Pedro Alves  <palves@redhat.com>
4498
4499         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4500         (validate_flags_qcs): New.
4501         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4502         (validate_flags_qcs): Declare.
4503         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4504         (make_frame_apply_options_def_group): New.
4505         (frame_apply_command_count): Process options with
4506         gdb::option::process_options.
4507         (frame_apply_completer): New.
4508         (frame_apply_level_completer, frame_apply_all_completer)
4509         (frame_apply_completer): New.
4510         (_initialize_stack): Update help of "frame apply", "frame apply
4511         level", "frame apply all" and "faas" to mention supported options
4512         and install command completers.
4513         * stack.h (frame_apply_all_completer): Declare.
4514         * thread.c: Include "stack.h".
4515         (tfaas_command): Add "--".
4516         (_initialize_thread): Update help "tfaas" to mention supported
4517         options and install command completer.
4518
4519 2019-06-13  Pedro Alves  <palves@redhat.com>
4520
4521         * completer.c (complete_nested_command_line): New.
4522         (gdb_completion_word_break_characters_throw): Add assertion.
4523         * completer.h (complete_nested_command_line): Declare.
4524
4525 2019-06-13  Pedro Alves  <palves@redhat.com>
4526
4527         * stack.c (parse_backtrace_qualifiers): New.
4528         (backtrace_command): Use it.
4529         (backtrace_command_completer): Complete on qualifiers.
4530
4531 2019-06-13  Pedro Alves  <palves@redhat.com>
4532
4533         * frame.c: Include "cli/cli-option.h.
4534         (user_set_backtrace_options): New.
4535         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4536         Delete.
4537         (get_prev_frame): Adjust.
4538         (boolean_option_def, uinteger_option_def)
4539         (set_backtrace_option_defs): New.
4540         (_initialize_frame): Adjust and use
4541         gdb::option::add_setshow_cmds_for_options to install "set
4542         backtrace past-main" and "set backtrace past-entry".
4543         * frame.h: Include "cli/cli-option.h".
4544         (struct frame_print_options): Forward declare.
4545         (print_frame_arguments_all, print_frame_arguments_scalars)
4546         (print_frame_arguments_none): Declare.
4547         (print_entry_values): Delete declaration.
4548         (struct frame_print_options, user_frame_print_options): New.
4549         (struct set_backtrace_options): New.
4550         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4551         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4552         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4553         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4554         (list_args_or_locals): Add frame_print_options parameter.
4555         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4556         * python/py-framefilter.c (enumerate_args): Pass down
4557         USER_FRAME_PRINT_OPTIONS.
4558         * stack.c: Include "cli/cli-option.h".
4559         (print_frame_arguments_all, print_frame_arguments_scalars)
4560         (print_frame_arguments_none): Declare.
4561         (print_raw_frame_arguments, print_entry_values): Delete.
4562         (user_frame_print_options): New.
4563         (boolean_option_def, enum_option_def, frame_print_option_defs):
4564         New.
4565         (struct backtrace_cmd_options): New.
4566         (bt_flag_option_def): New.
4567         (backtrace_command_option_defs): New.
4568         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4569         (print_frame_arg, read_frame_arg, print_frame_args)
4570         (print_frame_info, print_frame): Add frame_print_options parameter
4571         and use it.
4572         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4573         (backtrace_command_1): Add frame_print_options and
4574         backtrace_cmd_options parameters and use them.
4575         (make_backtrace_options_def_group): New.
4576         (backtrace_command): Process command options with
4577         gdb::option::process_options.
4578         (backtrace_command_completer): New.
4579         (_initialize_stack): Extend "backtrace"'s help to mention
4580         supported options.  Install completer for "backtrace".
4581         Install some settings commands with add_setshow_cmds_for_options.
4582
4583 2019-06-13  Pedro Alves  <palves@redhat.com>
4584
4585         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4586         and that "set/show print raw frame-arguments" are now deprecated.
4587
4588         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4589         command.
4590         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4591         * stack.c (_initialize_stack): Install "set/show print
4592         raw-frame-arguments", and deprecate "set/show print raw
4593         frame-arguments".
4594         * valprint.c (_initialize_valprint): Deprecate "set/show print
4595         raw".
4596
4597 2019-06-13  Pedro Alves  <palves@redhat.com>
4598
4599         * compile/compile.c (struct compile_options): New.
4600         (compile_flag_option_def, compile_command_option_defs)
4601         (make_compile_options_def_group): New.
4602         (compile_file_command): Handle options with
4603         gdb::option::process_options.
4604         (compile_file_command_completer): New function.
4605         (compile_code_command): Handle options with
4606         gdb::option::process_options.
4607         (compile_code_command_completer): New function.
4608         (_initialize_compiler): Install completers for "compile code" and
4609         "compile file".  Mention available options in "compile code" and
4610         "compile code"'s help.
4611         * completer.c (advance_to_completion_word): New, factored out from
4612         ...
4613         (advance_to_expression_complete_word_point): ... this.
4614         (advance_to_filename_complete_word_point): New.
4615         * completer.h (advance_to_filename_complete_word_point): New
4616         declaration.
4617
4618 2019-06-13  Pedro Alves  <palves@redhat.com>
4619
4620         * compile/compile.c: Include "cli/cli-option.h".
4621         (compile_print_value): Scope data pointer is now a
4622         value_print_options pointer; adjust.
4623         (compile_print_command): Process options.  Scope data pointer is
4624         now a value_print_options pointer; adjust.
4625         (_initialize_compile): Update "compile print"'s help to include
4626         supported options.  Install a completer for "compile print".
4627         * cp-valprint.c (show_vtblprint, show_objectprint)
4628         (show_static_field_print): Delete.
4629         (_initialize_cp_valprint): Don't install "set print
4630         static-members", "set print vtbl", "set print object" here.
4631         * printcmd.c: Include "cli/cli-option.h" and
4632         "common/gdb_optional.h".
4633         (print_command_parse_format): Rework to fill in a
4634         value_print_options instead of a format_data.
4635         (print_value): Change parameter type from format_data pointer to
4636         value_print_options reference.  Adjust.
4637         (print_command_1): Process options.  Adjust to pass down a
4638         value_print_options.
4639         (print_command_completer): New.
4640         (_initialize_printcmd): Install print_command_completer as
4641         handle_brkchars completer for the "print" command.  Update
4642         "print"'s help to include supported options.
4643         * valprint.c: Include "cli/cli-option.h".
4644         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4645         here from cp-valprint.c.
4646         (boolean_option_def, uinteger_option_def)
4647         (value_print_option_defs, make_value_print_options_def_group):
4648         New.  Use gdb::option::add_setshow_cmds_for_options to install
4649         "set print elements", "set print null-stop", "set print repeats",
4650         "set print pretty", "set print union", "set print array", "set
4651         print address", "set print symbol", "set print array-indexes".
4652         * valprint.h: Include <string> and "cli/cli-option.h".
4653         (make_value_print_options_def_group): Declare.
4654         (print_value): Change parameter type from format_data pointer to
4655         value_print_options reference.
4656         (print_command_completer): Declare.
4657
4658 2019-06-13  Pedro Alves  <palves@redhat.com>
4659
4660         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4661         (COMMON_SFILES): Add maint-test-settings.c.
4662         * cli/cli-decode.c (boolean_enums): New global, factored out from
4663         ...
4664         (add_setshow_boolean_cmd): ... here.
4665         * cli/cli-decode.h (boolean_enums): Declare.
4666         * cli/cli-option.c: New file.
4667         * cli/cli-option.h: New file.
4668         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4669         factored out from ...
4670         (parse_cli_boolean_value(const char *)): ... this.
4671         (is_unlimited_literal): Change parameter type to pointer to
4672         pointer.  Adjust and advance ARG pointer.
4673         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4674         (parse_cli_var_enum): New, factored out from ...
4675         (do_set_command): ... this.  Adjust.
4676         * cli/cli-setshow.h (parse_cli_boolean_value)
4677         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4678         (parse_cli_var_enum): Declare.
4679         * cli/cli-utils.c: Include "cli/cli-option.h".
4680         (get_ulongest): New.
4681         * cli/cli-utils.h (get_ulongest): Declare.
4682         (check_for_argument): New overloads.
4683         * maint-test-options.c: New file.
4684
4685 2019-06-13  Pedro Alves  <palves@redhat.com>
4686
4687         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4688         parse a range if "-" is at the end of the string.
4689
4690 2019-06-13  Pedro Alves  <palves@redhat.com>
4691
4692         * cli/cli-setshow.c (parse_auto_binary_operation)
4693         (parse_cli_boolean_value): Don't allow "o".
4694
4695 2019-06-13  Pedro Alves  <palves@redhat.com>
4696
4697         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4698         * NEWS: Mention maint test-settings KIND.
4699         * maint-test-settings.c: New file.
4700
4701 2019-06-13  Pedro Alves  <palves@redhat.com>
4702
4703         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4704         completer.
4705         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4706         "set" completers.
4707
4708 2019-06-13  Pedro Alves  <palves@redhat.com>
4709
4710         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4711         after item.
4712
4713 2019-06-13  Pedro Alves  <palves@redhat.com>
4714
4715         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4716
4717 2019-06-13  Pedro Alves <palves@redhat.com>
4718
4719         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4720         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4721         call.
4722         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4723         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4724         calls.
4725         (check_for_argument): Skip spaces after argument.
4726
4727 2019-06-13  Pedro Alves  <palves@redhat.com>
4728
4729         * thread.c (thread_apply_command): Adjust TID parsing.
4730         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4731         detected before end of string.
4732         (tid_is_in_list): Error out if LIST is invalid.
4733
4734 2019-06-13  Pedro Alves  <palves@redhat.com>
4735
4736         * completer.c (complete_line_internal_1): Rewind completion word
4737         point.
4738         (completion_tracker::advance_custom_word_point_by): Change
4739         parameter type to int.
4740         * completer.h (completion_tracker::advance_custom_word_point_by):
4741         Likewise.
4742
4743 2019-06-13  Pedro Alves  <palves@redhat.com>
4744
4745         * completer.c (advance_to_completion_word): Handle delimiters.
4746
4747 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4748
4749         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4750
4751 2019-06-11  Tom Tromey  <tom@tromey.com>
4752
4753         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4754         (xmalloc_failed): Move to alloc.c.
4755         * alloc.c: New file.
4756         * Makefile.in (COMMON_SFILES): Add alloc.c.
4757
4758 2019-06-11  Tom Tromey  <tom@tromey.com>
4759
4760         * nat/linux-waitpid.c: Don't include server.h.
4761         (linux_debug): Remove.
4762         (my_waitpid): Update.
4763
4764 2019-06-11  Tom Tromey  <tromey@adacore.com>
4765
4766         * infcall.c (_initialize_infcall): Remove trailing newline from
4767         help.
4768         * user-regs.c (_initialize_user_regs): Remove trailing newline
4769         from help.
4770         * typeprint.c (_initialize_typeprint): Remove trailing newline
4771         from help.
4772         * reverse.c (_initialize_reverse): Remove trailing newlines from
4773         help.
4774         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4775         from help.
4776         * language.c (add_set_language_command): Remove trailing newline
4777         from help.
4778         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4779         help.
4780         * disasm.c (_initialize_disasm): Remove trailing newline from
4781         help.
4782         * top.c (init_main): Remove trailing newline from help.
4783         * interps.c (_initialize_interpreter): Remove trailing newline
4784         from help.
4785         * btrace.c (_initialize_btrace): Remove trailing newlines from
4786         help.
4787         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4788         from help.
4789         * python/python.c (_initialize_python): Remove trailing newline
4790         from help.
4791         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4792         help.
4793         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4794         from help.  Reformat some text.
4795         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4796         from help.
4797         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4798         newline from help.
4799
4800 2019-06-11  Tom Tromey  <tromey@adacore.com>
4801
4802         * darwin-nat.c (darwin_decode_exception_message)
4803         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4804
4805 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * valops.c (value_slice): Check for not allocated or not
4808         associated values.
4809
4810 2019-06-10  Tom de Vries  <tdevries@suse.de>
4811
4812         PR gdb/24618
4813         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4814         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4815         invalid.
4816
4817 2019-06-10  Tom de Vries  <tdevries@suse.de>
4818
4819         PR gdb/24611
4820         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4821         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4822
4823 2019-06-10  Tom de Vries  <tdevries@suse.de>
4824
4825         PR symtab/24545
4826         * symtab.c (struct demangled_name_entry): Add language field.
4827         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4828         static minimal symbol".  Set and use language field.
4829
4830 2019-06-10  Tom Tromey  <tromey@adacore.com>
4831
4832         * ada-lang.c (_initialize_ada_language): Update help text.
4833
4834 2019-06-10  Tom Tromey  <tromey@adacore.com>
4835
4836         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4837         with a newline.
4838         * guile/guile.c (handle_boot_error): Don't end warning with a
4839         newline.
4840         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4841         warning with a newline.
4842         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4843         newline.
4844         (s12z_frame_cache): Likewise.
4845         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4846         a newline.
4847         * solib-svr4.c (disable_probes_interface): Don't end warning with
4848         a newline.
4849         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4850         newline.
4851         * python/python.c (do_finish_initialization): Don't end warning
4852         with a newline.
4853
4854 2019-06-10  Tom Tromey  <tom@tromey.com>
4855
4856         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4857         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4858         gdbpy_enter.
4859
4860 2019-06-10  Tom Tromey  <tromey@adacore.com>
4861
4862         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4863         data.
4864         (elf_new_init): Don't call stabsread_new_init.
4865         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4866         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4867         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4868
4869 2019-06-10  Tom de Vries  <tdevries@suse.de>
4870
4871         PR symtab/16264
4872         PR symtab/24517
4873         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4874
4875 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4876
4877         * source.c (find_and_open_source): Also rewrite relative file
4878         names.
4879
4880 2019-04-26  Amos Bird  <amosbird@gmail.com>
4881
4882         * annotate.c (annotate_thread_exited): Add "thread-exited"
4883         annotation.
4884
4885 2019-06-06  Tom Tromey  <tromey@adacore.com>
4886
4887         * maint.h (class scoped_command_stats): Use
4888         DISABLE_COPY_AND_ASSIGN.
4889         <print_time>: New method.
4890         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4891         print_time.
4892         (scoped_command_stats::print_time): New method.
4893
4894 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4895
4896         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4897         instructions of lengths 6 or 8 bytes.
4898
4899 2019-06-04  Pedro Alves  <palves@redhat.com>
4900
4901         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4902
4903         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4904         * breakpoint.c (condition_completer): Likewise.
4905         * cli/cli-dump.c (scan_expression): Likewise.
4906         * common/filestuff.c (mkdir_recursive): Likewise.
4907         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4908         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4909         (gdb_abspath): Likewise.
4910         * compile/compile-cplus-types.c
4911         (compile_cplus_instance::decl_name): Likewise.
4912         * completer.c (complete_explicit_location):
4913         (signal_completer, reg_or_group_completer_1): Likewise.
4914         * cp-support.c (cp_remove_params_if_any): Likewise.
4915         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4916         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4917         * infcmd.c (strip_bg_char): Likewise.
4918         * linespec.c (copy_token_string): Likewise.
4919         * mi/mi-main.c (output_cores): Likewise.
4920         * psymtab.c (psymtab_search_name):
4921         * symfile.c (test_set_ext_lang_command): Likewise.
4922         * target.c (target_fileio_read_stralloc): Likewise.
4923         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4924         * value.c (complete_internalvar): Likewise.
4925
4926 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4927
4928         Add objfile property to gdb.Type.
4929         * NEWS: Mention Python API addition.
4930         * python/py-type.c (typy_get_objfile): New method.
4931
4932 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4933
4934         * NEWS: Mention the new set|show style [title|highlight].
4935         Mention changes to "show style", "help" and "apropos".
4936
4937 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4938
4939         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4940         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4941         instead of print_help_for_command.
4942         (print_doc_of_command): New function.
4943         (help_list): Add 'apropos -v word' suggestion.
4944         (print_help_for_command): Style the command name using title style.
4945         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4946         (_initialize_cli_cmds): Describe -v in apropos_command help.
4947
4948 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4949
4950         * cli/cli-style.h (cli_style_option): Add name in constructor,
4951         add m_name class member, add constructor with intensity,
4952         add name class function.
4953         (cli_style_option::add_setshow_commands): Remove name argument.
4954         (highlight_style, title_style): New styles.
4955         * cli/cli-style.c (do_show): New function that shows a style
4956         characteristic styling the style name with itself.
4957         (set_style_name): New function.
4958         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4959         Update all callers according to the changes in cli/cli-style.h.
4960         * utils.h (fputs_highlighted): New function.
4961         * utils.c (fputs_highlighted): Likewise.
4962
4963 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4964
4965         * NEWS: Mention new pipe command and new convenience variables.
4966
4967 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4968
4969         * cli/cli-cmds.c (pipe_command): New function.
4970         (_initialize_cli_cmds): Call add_com for pipe_command.
4971         Define | as an alias for pipe.
4972         (exit_status_set_internal_vars): New function.
4973         (shell_escape): Call exit_status_set_internal_vars.
4974         cli/cli-decode.c (find_command_name_length): Recognize | as
4975         a single character command.
4976
4977 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4978
4979         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4980         top.c (execute_command_to_ui_file): New function, mostly a copy
4981         of execute_command_to_string.
4982         (execute_command_to_string): Implement by calling
4983         execute_command_to_ui_file.
4984
4985 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4986
4987         * top.h (saved_command_line): Remove declaration.
4988         * top.c (previous_saved_command_line, previous_repeat_arguments):
4989         New variables.
4990         (saved_command_line): Make static, define together with other
4991         'repeat variables'.
4992         (dont_repeat): Clear repeat_arguments.
4993         (repeat_previous, get_saved_command_line, save_command_line):
4994         New functions.
4995         (gdb_init): Initialize saved_command_line
4996         and previous_saved_command_line.
4997         * main.c (captured_main_1): Remove saved_command_line initialization.
4998         * event-top.c (handle_line_of_input): Update to use
4999         the new 'repeat' related functions instead of direct access to
5000         saved_command_line.
5001         * command.h (repeat_previous, get_saved_command_line,
5002         save_command_line): New declarations.
5003         (dont_repeat): Add comment.
5004
5005 2019-05-30  Tom Tromey  <tromey@adacore.com>
5006
5007         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5008         Fix comment.
5009         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5010
5011 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5012
5013         PR cli/24587
5014         * completer.c (complete): Initialize variable word.
5015
5016 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5017
5018         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5019         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5020         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5021         'body' is NULL to the outter 'if', protecting the '!is_define'
5022         situation as well.
5023
5024 2019-05-29  Tom Tromey  <tromey@adacore.com>
5025
5026         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5027         (dwarf_unknown): New function.
5028         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5029         (dwarf_type_encoding_name): Use dwarf_unknown.
5030
5031 2019-05-29  Tom Tromey  <tromey@adacore.com>
5032
5033         PR c++/20020:
5034         * cp-valprint.c (cp_print_value_fields): Call
5035         cp_print_static_field inside "try".
5036
5037 2019-05-29  Tom Tromey  <tromey@adacore.com>
5038
5039         * inflow.c (struct terminal_info): Add default operator=.
5040         * configure: Rebuild.
5041         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5042         -Wdeprecated-copy-dtor, -Wredundant-move.
5043
5044 2019-05-29  Tom Tromey  <tromey@adacore.com>
5045
5046         * NEWS: Add entry.
5047         * infcmd.c (print_return_value_1): Handle finish_print
5048         option.
5049         (show_print_finish): New function.
5050         (_initialize_infcmd): Add "set/show print finish" commands.
5051         * valprint.c (user_print_options): Initialize new member.
5052         * valprint.h (struct value_print_options) <finish_print>: New
5053         member.
5054
5055 2019-05-28  Tom Tromey  <tromey@adacore.com>
5056
5057         * ada-lang.c (ada_remove_Xbn_suffix)
5058         (find_old_style_renaming_symbol)
5059         (parse_old_style_renaming): Remove.
5060         (ada_find_renaming_symbol): Don't call
5061         find_old_style_renaming_symbol.
5062         (ada_is_renaming_symbol): Rename from
5063         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5064         bool.  Now static.
5065         (ada_read_var_value): Update and simplify.
5066         * ada-exp.y (write_var_or_type): Remove old code.
5067
5068 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5069
5070         * event-top.c: Remove include comment.
5071         * inflow.c (class scoped_ignore_sigttou): Move from here...
5072         * inflow.h (class scoped_ignore_sigttou): ...to here.
5073         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5074         * top.c:  Remove include comment.
5075
5076 2019-05-27  Tom Tromey  <tom@tromey.com>
5077
5078         * NEWS: Fix typo.
5079
5080 2019-05-22  Tom Tromey  <tromey@adacore.com>
5081
5082         * target.c (target_follow_exec): Constify parameter.
5083         * target-delegates.c: Rebuild.
5084         * remote.c (remote_target::follow_exec): Constify parameter.
5085         * infrun.c (follow_exec): Constify parameter.
5086         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5087         (target_follow_exec): Likewise.
5088
5089 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5090
5091         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5092         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5093
5094 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5095
5096         * NEWS: Add debugredirect and testsuite sections.
5097
5098 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5099
5100         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5101         target descriptions using exclusively floating point register name
5102         aliases.
5103
5104 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5105
5106         PR gdb/18644:
5107         * f-lang.c (build_fortran_types): Handle the case where
5108         gdbarch_floatformat_for_type returns a nullptr.
5109
5110 2019-05-21  Tom de Vries  <tdevries@suse.de>
5111
5112         PR cli/24587
5113         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5114
5115 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5116
5117         PR gdb/18644:
5118         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5119         16-byte floats.
5120         * i386-tdep.c (i386_floatformat_for_type): Use
5121         floatformats_ia64_quad for the 16-byte floating point component
5122         within a fortran 32-byte complex number.
5123
5124 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5127         delete default constructor.
5128         (find_partial_die): Update to return const struct.
5129         (partial_die_parent_scope): Move variable declaration into scope
5130         of its use and change its type to auto.
5131         (guess_partial_die_structure_name): Likewise.
5132         (partial_die_info::fixup): Likewise.
5133
5134 2019-05-17  Tom Tromey  <tromey@adacore.com>
5135
5136         * source.c (find_and_open_source): Remove cast.
5137
5138 2019-05-17  Tom Tromey  <tromey@adacore.com>
5139
5140         * annotate.c (annotate_source): Make "filename" const.
5141         * annotate.h (annotate_source): Use const.
5142
5143 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5144
5145         * disasm.c (set_disassembler_options): Send errors to stderr.
5146
5147 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5148
5149         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5150         (cli_interp_base::set_logging): Check debug_redirect.
5151         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5152         * cli/cli-logging.c (debug_redirect): Add static variable.
5153         (pop_output_files): Add default param.
5154         (handle_redirections): Print debug setting.
5155         (show_logging_command): Likewise.
5156         (_initialize_cli_logging): Add debugredirect command.
5157         * interps.c (current_interp_set_logging): Add debug_redirect
5158         parameter.
5159         * interps.h (set_logging): Add debug_redirect parameter.
5160         (current_interp_set_logging): Likewise.
5161         * mi/mi-common.h: Likewise.
5162         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5163
5164 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5165             Tom Tromey  <tromey@adacore.com>
5166
5167         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5168         directly.
5169         * cli/cli-interp.h (make_logging_output): Remove declaration.
5170         * cli/cli-logging.c (make_logging_output): Remove function.
5171         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5172         directly.
5173         * ui-file.c (tee_file::tee_file): Remove bools.
5174         (tee_file::~tee_file): Remove deletes.
5175         * ui-file.h (tee_file): Remove bools.
5176
5177 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5178
5179         * mi/mi-cmds.h (mi_cmd_complete): New function.
5180         * mi/mi-main.c (mi_cmd_complete): Likewise.
5181         * mi/mi-cmds.c: Define new MI command -complete.
5182         * NEWS: Mention new -complete command.
5183
5184 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5185
5186         * completer.h (complete): New function.
5187         * completer.c (complete): Likewise.
5188         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5189         function defined in completer.h.
5190
5191 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5192
5193         * MAINTAINERS (Write After Approval): Add myself.
5194
5195 2019-05-17  Tom de Vries  <tdevries@suse.de>
5196
5197         PR gdb/24094
5198         * dwarf2read.c (struct cu_partial_die_info): New struct.
5199         (find_partial_die): Return cu_partial_die_info.
5200         (partial_die_parent_scope, guess_partial_die_structure_name)
5201         (partial_die_info::fixup): Handle new return type of find_partial_die.
5202
5203 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5204
5205         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5206         "std::string", simplifying the algorithm.
5207
5208 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5209
5210         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5211         (stap_static_probe_ops::get_probes): Likewise.
5212
5213 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5214
5215         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5216         '-')" and "else if".
5217         (stap_parse_single_operand): Join checks for
5218         "gdbarch_stap_parse_special_token_p" and
5219         "gdbarch_stap_parse_special_token" in the same "if" statement.
5220         Invert check when verifying for operation on register
5221         displacement.
5222
5223 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5224
5225         * stap-probe.c (stap_get_opcode): Update comment.
5226         (stap_get_expected_argument_type): Likewise.
5227         (handle_stap_probe): Likewise.
5228
5229 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5230
5231         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5232         return type to 'bool'.  Adjust comment.  Use 'bool' when
5233         appropriate.
5234         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5235         * stap-probe.c (stap_parse_argument_1): Likewise.
5236         (stap_is_operator): Likewise.
5237         (stap_is_generic_prefix): Likewise.
5238         (stap_is_register_prefix): Likewise.
5239         (stap_is_register_indirection_prefix): Likewise.
5240         (stap_is_integer_prefix): Likewise.
5241         (stap_generic_check_suffix): Likewise.
5242         (stap_check_integer_suffix): Likewise.
5243         (stap_check_register_suffix): Likewise.
5244         (stap_check_register_indirection_suffix): Likewise.
5245         (stap_parse_register_operand): Likewise.
5246         (stap_parse_single_operand): Likewise.
5247         (stap_parse_argument_1): Likewise.
5248         (stap_probe::get_argument_count): Likewise.
5249         (stap_is_operator): Likewise.
5250
5251 2019-05-16  Tom Tromey  <tromey@adacore.com>
5252
5253         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5254         keyword to foreach.
5255
5256 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5257
5258         * linux-thread-db.c (try_thread_db_load_1): Change return type
5259         to bool.
5260         (try_thread_db_load): Likewise.
5261         (try_thread_db_load_from_pdir_1): Likewise.
5262         (try_thread_db_load_from_pdir): Likewise.
5263         (try_thread_db_load_from_sdir): Likewise.
5264         (try_thread_db_load_from_dir): Likewise.
5265         (thread_db_load_search): Likewise.
5266         (has_libpthread): Likewise.
5267         (thread_db_load): Likewise.
5268
5269 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5270
5271         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5272         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5273         NULL, and complain/return if that's the case.
5274
5275 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5276
5277         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5278         (advance, posn, abstract_read_memory): New functions.
5279         [struct mem_read_abstraction]: New struct.
5280         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5281
5282 2019-05-14  Tom Tromey  <tromey@adacore.com>
5283
5284         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5285         value is not lval_memory.
5286
5287 2019-05-14  Tom Tromey  <tromey@adacore.com>
5288
5289         * solib.c (info_sharedlibrary_command): Style the file name.
5290
5291 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5292
5293         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5294         (aarch64_vnv_type): Likewise.
5295         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5296         * common/tdesc.c: Likewise.
5297         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5298         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5299         * features/aarch64-fpu.xml: Add ieee half view.
5300         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5301         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5302         * gdbtypes.h (struct builtin_type): Likewise.
5303         (struct objfile_type): Likewise.
5304
5305 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5306
5307         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5308         typo.
5309         * location.h (string_to_event_location): Likewise.
5310
5311 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5312
5313         GDB 8.3 released.
5314
5315 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5316
5317         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5318         New variable declaration.
5319         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5320         New variable.
5321         (print_one_breakpoint): Use ui_out::test_flags and new global
5322         variable to compute use_fixed_output.
5323         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5324         Remove.
5325         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5326         (mi_multi_location_breakpoint_output_fixed): Remove.
5327         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5328         new variable.
5329         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5330         fix_multi_location_breakpoint_output flag if version >= 3.
5331         * ui-out.h (enum ui_out_flag)
5332         <fix_multi_location_breakpoint_output>: New enumerator.
5333
5334 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5335
5336         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5337
5338 2019-05-10  Tom Tromey  <tromey@adacore.com>
5339
5340         * ada-lang.c (catch_ada_completer): New function.
5341         (_initialize_ada_language): Use it.
5342
5343 2019-05-10  Tom Tromey  <tromey@adacore.com>
5344
5345         * thread.c (print_thread_info): Make "requested_threads" const.
5346         * gdbthread.h (print_thread_info): Make "requested_threads"
5347         const.
5348         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5349         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5350
5351 2019-05-08  Tom Tromey  <tom@tromey.com>
5352
5353         * gdbtypes.c (objfile_type_data): Change type.
5354         (objfile_type, _initialize_gdbtypes): Update.
5355
5356 2019-05-08  Tom Tromey  <tom@tromey.com>
5357
5358         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5359         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5360         (_initialize_dwarf2_frame): Update.
5361
5362 2019-05-08  Tom Tromey  <tom@tromey.com>
5363
5364         * objc-lang.c (objc_objfile_data): Change type.
5365         (find_methods): Update.
5366         (_initialize_objc_lang): Remove.
5367
5368 2019-05-08  Tom Tromey  <tom@tromey.com>
5369
5370         * stabsread.c (rs6000_builtin_type_data): Change type.
5371         (rs6000_builtin_type, _initialize_stabsread): Update.
5372
5373 2019-05-08  Tom Tromey  <tom@tromey.com>
5374
5375         * mips-tdep.c (mips_pdr_data): Remove.
5376         (_initialize_mips_tdep): Update.
5377
5378 2019-05-08  Tom Tromey  <tom@tromey.com>
5379
5380         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5381         (hppa_init_objfile_priv_data, read_unwind_info)
5382         (find_unwind_entry, _initialize_hppa_tdep): Update.
5383
5384 2019-05-08  Tom Tromey  <tom@tromey.com>
5385
5386         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5387         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5388         on obstack.
5389         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5390
5391 2019-05-08  Tom Tromey  <tom@tromey.com>
5392
5393         * mdebugread.c (basic_type_data): Change type.
5394         (basic_type, _initialize_mdebugread): Update.
5395
5396 2019-05-08  Tom Tromey  <tom@tromey.com>
5397
5398         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5399
5400 2019-05-08  Tom Tromey  <tom@tromey.com>
5401
5402         * nto-tdep.c (nto_inferior_data_reg): Change type.
5403         (nto_inferior_data): Update.
5404         (nto_inferior_data_cleanup, nto_new_inferior_data)
5405         (_initialize_nto_tdep): Remove.
5406         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5407
5408 2019-05-08  Tom Tromey  <tom@tromey.com>
5409
5410         * ada-lang.c (struct ada_inferior_data): Add initializers.
5411         (ada_inferior_data): Change type.
5412         (ada_inferior_data_cleanup): Remove.
5413         (get_ada_inferior_data, ada_inferior_exit)
5414         (struct ada_pspace_data): Add initializers, destructor.
5415         (ada_pspace_data_handle): Change type.
5416         (get_ada_pspace_data): Update.
5417         (ada_pspace_data_cleanup): Remove.
5418
5419 2019-05-08  Tom Tromey  <tom@tromey.com>
5420
5421         * coffread.c (struct coff_symfile_info): Add initializers.
5422         (coff_objfile_data_key): Move lower.  Change type.
5423         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5424         Update.
5425         (coff_free_info): Remove.
5426
5427 2019-05-08  Tom Tromey  <tom@tromey.com>
5428
5429         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5430         (fbsd_pspace_data_handle): Move lower.  Change type.
5431         (get_fbsd_pspace_data): Update.
5432         (fbsd_pspace_data_cleanup): Remove.
5433         (_initialize_fbsd_tdep): Update.
5434
5435 2019-05-08  Tom Tromey  <tom@tromey.com>
5436
5437         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5438         (get_ada_tasks_pspace_data): Update.
5439         (ada_tasks_pspace_data_cleanup): Remove.
5440         (_initialize_tasks): Update.
5441         (ada_tasks_inferior_data_handle): Change type.
5442         (get_ada_tasks_inferior_data): Update.
5443         (ada_tasks_inferior_data_cleanup): Remove.
5444         (struct ada_tasks_pspace_data): Add initializers.
5445
5446 2019-05-08  Tom Tromey  <tom@tromey.com>
5447
5448         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5449         * symfile-debug.c (debug_sym_get_probes): Change type.
5450         * stap-probe.c (handle_stap_probe):
5451         (stap_static_probe_ops::get_probes): Change type.
5452         * probe.h (class static_probe_ops) <get_probes>: Change type.
5453         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5454         (parse_probes_in_pspace): Update.
5455         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5456         Update.
5457         (any_static_probe_ops::get_probes): Change type.
5458         * elfread.c (elfread_data): New typedef.
5459         (probe_key): Change type.
5460         (elf_get_probes): Likewise.  Update.
5461         (probe_key_free): Remove.
5462         (_initialize_elfread): Update.
5463         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5464         Change type.
5465         (dtrace_process_dof_probe, dtrace_process_dof)
5466         (dtrace_static_probe_ops::get_probe): Change type.
5467
5468 2019-05-08  Tom Tromey  <tom@tromey.com>
5469
5470         * xcoffread.c (struct xcoff_symfile_info): Rename from
5471         coff_symfile_info.  Add initializers.
5472         (xcoff_objfile_data_key): Move lower.  Change type.
5473         (XCOFF_DATA): Rewrite.
5474         (xcoff_free_info): Remove.
5475         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5476         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5477         (xcoff_initial_scan): Update.
5478
5479 2019-05-08  Tom Tromey  <tom@tromey.com>
5480
5481         * solib-svr4.c (struct svr4_info): Add initializers and
5482         destructor.
5483         <probes_table>: Now an htab_up.
5484         (solib_svr4_pspace_data): Change type.
5485         (free_probes_table): Simplify.
5486         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5487         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5488         (probes_table_remove_objfile_probes, register_solib_event_probe)
5489         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5490         (_initialize_svr4_solib): Update.
5491
5492 2019-05-08  Tom Tromey  <tom@tromey.com>
5493
5494         * remote.c (remote_pspace_data): Change type.
5495         (remote_pspace_data_cleanup): Remove.
5496         (get_remote_exec_file, set_pspace_remote_exec_file)
5497         (_initialize_remote): Update.
5498
5499 2019-05-08  Tom Tromey  <tom@tromey.com>
5500
5501         * breakpoint.c (breakpoint_objfile_key): Change type.
5502         (get_breakpoint_objfile_data): Update.
5503         (free_breakpoint_objfile_data): Remove.
5504         (_initialize_breakpoint): Update.
5505
5506 2019-05-08  Tom Tromey  <tom@tromey.com>
5507
5508         * linux-tdep.c (struct linux_info): Add initializers.
5509         (linux_inferior_data): Move.  Change type.
5510         (invalidate_linux_cache_inf): Update.
5511         (linux_inferior_data_cleanup): Remove.
5512         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5513
5514 2019-05-08  Tom Tromey  <tom@tromey.com>
5515
5516         * auxv.c (auxv_inferior_data): Move.  Change type.
5517         (auxv_inferior_data_cleanup): Remove.
5518         (invalidate_auxv_cache_inf): Rewrite.
5519         (get_auxv_inferior_data, _initialize_auxv): Update.
5520
5521 2019-05-08  Tom Tromey  <tom@tromey.com>
5522
5523         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5524         (symfile_debug_objfile_data_key): Change type.
5525         (symfile_debug_installed, debug_qf_has_symbols)
5526         (debug_qf_find_last_source_symtab)
5527         (debug_qf_forget_cached_source_info)
5528         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5529         (debug_qf_print_stats, debug_qf_dump)
5530         (debug_qf_expand_symtabs_for_function)
5531         (debug_qf_expand_all_symtabs)
5532         (debug_qf_expand_symtabs_with_fullname)
5533         (debug_qf_map_matching_symbols)
5534         (debug_qf_expand_symtabs_matching)
5535         (debug_qf_find_pc_sect_compunit_symtab)
5536         (debug_qf_map_symbol_filenames)
5537         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5538         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5539         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5540         (debug_sym_read_linetable, debug_sym_relocate): Update.
5541         (symfile_debug_free_objfile): Remove.
5542         (install_symfile_debug_logging, _initialize_symfile_debug):
5543         Update.
5544
5545 2019-05-08  Tom Tromey  <tom@tromey.com>
5546
5547         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5548         allocate_on_obstack.
5549         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5550         (get_dwarf2_per_objfile): Update.
5551         (set_dwarf2_per_objfile): Remove.
5552         (dwarf2_has_info, dwarf2_get_section_info): Update.
5553         (dwarf2_free_objfile): Remove.
5554         (_initialize_dwarf2_read): Update.
5555
5556 2019-05-08  Tom Tromey  <tom@tromey.com>
5557
5558         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5559         initializers.
5560         <unsupported_script_warning_printed,
5561         script_not_found_warning_printed>: Now bool.
5562         (auto_load_pspace_data): Change type.
5563         (~auto_load_pspace_info): Rename from
5564         auto_load_pspace_data_cleanup.
5565         (get_auto_load_pspace_data, init_loaded_scripts_info)
5566         (clear_section_scripts, maybe_print_unsupported_script_warning)
5567         (maybe_print_script_not_found_warning, _initialize_auto_load):
5568         Update.
5569
5570 2019-05-08  Tom Tromey  <tom@tromey.com>
5571
5572         * objfiles.c (objfile_pspace_info): Add destructor and
5573         initializers.
5574         (objfiles_pspace_data): Change type.
5575         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5576         (get_objfile_pspace_data): Update.
5577         (objfiles_bfd_data): Change type.
5578         (get_objfile_bfd_data): Update.
5579         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5580
5581 2019-05-08  Tom Tromey  <tom@tromey.com>
5582
5583         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5584         Change type.
5585         (get_catch_syscall_inferior_data): Update.
5586         (catch_syscall_inferior_data_cleanup): Remove.
5587         (_initialize_break_catch_syscall): Update.
5588
5589 2019-05-08  Tom Tromey  <tom@tromey.com>
5590
5591         * inflow.c (struct terminal_info): Add destructor and
5592         initializers.
5593         (inflow_inferior_data): Change type.
5594         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5595         (get_inflow_inferior_data, inflow_inferior_exit)
5596         (swap_terminal_info, _initialize_inflow): Update.
5597
5598 2019-05-08  Tom Tromey  <tom@tromey.com>
5599
5600         * target-dcache.c (target_dcache_cleanup): Remove.
5601         (target_dcache_aspace_key): Change type.
5602         (target_dcache_init_p, target_dcache_invalidate)
5603         (target_dcache_get, target_dcache_get_or_init)
5604         (_initialize_target_dcache): Update.
5605         * dcache.h (struct dcache_deleter): New.
5606
5607 2019-05-08  Tom Tromey  <tom@tromey.com>
5608
5609         * symtab.c (struct symbol_cache): Add destructor and
5610         initializers.
5611         (symbol_cache_key): Move.  Change type.
5612         (make_symbol_cache, free_symbol_cache): Remove.
5613         (get_symbol_cache): Update.
5614         (symbol_cache_cleanup): Remove.
5615         (ALL_PSPACES, symbol_cache_flush)
5616         (maintenance_print_symbol_cache)
5617         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5618         Update.
5619
5620 2019-05-08  Tom Tromey  <tom@tromey.com>
5621
5622         * symtab.c (struct main_info): Add destructor and initializers.
5623         (main_progspace_key): Move.  Change type.
5624         (get_main_info): Update.
5625         (main_info_cleanup): Remove.
5626         (_initialize_symtab): Update.
5627
5628 2019-05-08  Tom Tromey  <tom@tromey.com>
5629
5630         * registry.h (DECLARE_REGISTRY): Define the _key class.
5631
5632 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5633
5634         * NEWS: Merge two 'New commands' sections.
5635
5636 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5637
5638         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5639         parameter and use Ada language definition instead.
5640         (ada_val_print_ptr): Remove unused language parameter.
5641         (ada_val_print_num): Remove language parameter and use Ada language
5642         definition instead.
5643         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5644         parameter.
5645         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5646         parameter and use Ada language definition instead.
5647         (ada_val_print_1): Update all ada_val_print_xxx calls.
5648         Remove language parameter.
5649         (ada_val_print): Update ada_val_print_1 call.
5650
5651 2019-05-08  Tom Tromey  <tromey@adacore.com>
5652
5653         * remote.c (remote_hw_watchpoint_limit)
5654         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5655         Now static.
5656
5657 2019-05-08  Tom Tromey  <tromey@adacore.com>
5658
5659         * maint.c (_initialize_maint_cmds): Move initialization code to
5660         remote.c.
5661         (watchdog, show_watchdog): Move to remote.c.
5662         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5663         "watchdog" static.
5664         (_initialize_remote): Move initialization code from maint.c.
5665         * defs.h (watchdog): Don't declare.
5666
5667 2019-05-08  Tom Tromey  <tromey@adacore.com>
5668
5669         * tui/tui-interp.c: Include main.h.
5670         * interps.c: Include main.h.
5671         * main.h (interpreter_p): Declare.
5672         * defs.h (interpreter_p): Don't declare.
5673
5674 2019-05-08  Tom Tromey  <tromey@adacore.com>
5675
5676         * dwarf2loc.c: Include dwarf2read.h.
5677         * defs.h (read_unsigned_leb128): Don't declare.
5678         * dwarf2read.h (read_unsigned_leb128): Declare.
5679
5680 2019-05-08  Tom Tromey  <tromey@adacore.com>
5681
5682         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5683         method.
5684
5685 2019-05-08  Tom Tromey  <tromey@adacore.com>
5686
5687         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5688         when no wrap column is set.
5689
5690 2019-05-08  Tom Tromey  <tromey@adacore.com>
5691
5692         * c-lang.c (c_get_string): Handle non-C-style arrays.
5693
5694 2019-05-08  Tom Tromey  <tromey@adacore.com>
5695
5696         * typeprint.c (print_offset_data::update): Print the bit offset,
5697         not the number of bits remaining.
5698
5699 2019-05-08  Tom Tromey  <tromey@adacore.com>
5700
5701         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5702         padding at end of comment.
5703
5704 2019-05-08  Tom Tromey  <tromey@adacore.com>
5705
5706         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5707         Compare main types.
5708
5709 2019-05-06  Tom Tromey  <tom@tromey.com>
5710
5711         * common/scoped_mmap.c: Include common-defs.h.
5712         * common/scoped_mmap.h: Don't include config.h.
5713
5714 2019-05-04  Tom Tromey  <tom@tromey.com>
5715
5716         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5717         (struct aarch64_call_info): Add initializers.
5718         <si>: Now a std::vector.
5719         (pass_on_stack, aarch64_push_dummy_call): Update.
5720
5721 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5722             Tom Tromey  <tom@tromey.com>
5723
5724         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5725         (ppc_threads): Now a std::vector.  Now static.
5726         (hwdebug_find_thread_points_by_tid)
5727         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5728         Update.
5729
5730 2019-05-04  Tom Tromey  <tom@tromey.com>
5731
5732         * arc-tdep.c (arc_tdesc_init): Return bool.
5733
5734 2019-05-04  Tom Tromey  <tom@tromey.com>
5735
5736         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5737         Use gdb_assert_not_reached.
5738
5739 2019-05-04  Tom Tromey  <tom@tromey.com>
5740
5741         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5742         "false".
5743
5744 2019-05-04  Tom Tromey  <tom@tromey.com>
5745
5746         * arc-tdep.c (arc_tdesc_init): Use bool.
5747
5748 2019-05-04  Tom Tromey  <tom@tromey.com>
5749
5750         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5751
5752 2019-05-04  Tom Tromey  <tom@tromey.com>
5753
5754         * cli/cli-cmds.c (valid_command_p): Return bool.
5755
5756 2019-05-04  Tom Tromey  <tom@tromey.com>
5757
5758         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5759         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5760
5761 2019-05-04  Raul Tambre  <raul@tambre.ee>
5762
5763         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5764         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5765         operator for comparison.
5766
5767 2019-05-04  Tom Tromey  <tom@tromey.com>
5768
5769         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5770         (lookup_partial_symbol, print_partial_symbols)
5771         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5772         (psymbol_compare): Update.
5773         (add_psymbol_to_bcache): Clear the entire psymbol.
5774         (maintenance_check_psymtabs): Update.
5775         * psympriv.h (struct partial_symbol): Don't derive from
5776         general_symbol_info.
5777         <obj_section, unrelocated_address, address,
5778         set_unrelocated_address>: Update.
5779         <ginfo>: New member.
5780         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5781         (debug_names::write_psymbols): Update.
5782
5783 2019-05-04  Tom de Vries  <tdevries@suse.de>
5784
5785         * contrib/cc-with-tweaks.sh: Support -n arg.
5786
5787 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5788
5789         * corelow.c (core_target::detach): Ensure frame cache and
5790         register caches are cleared.
5791         inferior.c (exit_inferior_1): Likewise.
5792
5793 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5794             Tom Tromey  <tom@tromey.com>
5795
5796         * dictionary.c (collate_pending_symbols_by_language): Remove
5797         "struct" from foreach.
5798         * symtab.c (lookup_global_symbol_from_objfile)
5799         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5800         foreach.
5801         * ser-tcp.c (net_open): Remove "struct" from foreach.
5802         * objfiles.c (objfile_relocate, objfile_rebase)
5803         (objfile_has_symbols): Remove "struct" from foreach.
5804         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5805         from foreach.
5806         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5807         foreach.
5808         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5809         "struct" from foreach.
5810         * ada-lang.c (create_excep_cond_exprs)
5811         (ada_exception_catchpoint_cond_string): Remove "struct" from
5812         foreach.
5813
5814 2019-05-03  Tom Tromey  <tromey@adacore.com>
5815
5816         * ada-exp.y (convert_char_literal): Check suffix of each
5817         enumerator.
5818
5819 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5820
5821         PR ada/21406:
5822         * ada-exp.y (yywrap): Don't define.
5823         * ada-lex.l (%option): Add noyywrap
5824         (yywrap): Remove.
5825
5826 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5827
5828         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5829         _WIN32_WINNT to the XP level, unless already defined to a higher
5830         level.
5831
5832         * unittests/parse-connection-spec-selftests.c:
5833         * ser-tcp.c:
5834         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5835         override.
5836
5837         * symfile.c (find_separate_debug_file): Remove colon from the
5838         drive spec of DOS/Windows file names of the target, so that the
5839         file name produced from DEBUGDIR and the target's directory will
5840         be valid on DOS/Windows systems.
5841
5842 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5843
5844         * rust-lang.c (val_print_struct): Handle printing structures
5845         containing strings.
5846
5847 2019-05-02  Tom Tromey  <tromey@adacore.com>
5848
5849         * valarith.c (_initialize_valarith): Remove.
5850
5851 2019-05-01  Tom Tromey  <tromey@adacore.com>
5852
5853         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5854         bitfields.
5855
5856 2019-05-01  Tom Tromey  <tromey@adacore.com>
5857
5858         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5859         for big-endian copies.
5860
5861 2019-04-30  Ali Tamur  <tamur@google.com>
5862         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5863         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5864         (read_3_bytes): New function.
5865
5866 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5867
5868         * windows-nat.c (main_thread_id): Delete.
5869         (handle_output_debug_string): Replace main_thread_id by
5870         current_event.dwThreadId.
5871         (fake_create_process): Likewise.
5872         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5873         Do not set main_thread_id.
5874         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5875         current_event.dwThreadId.
5876         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5877
5878 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5879
5880         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5881         Use current_event.dwThreadId instead of main_thread_id.
5882
5883 2019-04-30  Tom Tromey  <tromey@adacore.com>
5884
5885         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5886         (create_excep_cond_exprs): Iterate over program spaces.
5887         (ada_exception_catchpoint_cond_string): Examine all minimal
5888         symbols for exception types.
5889
5890 2019-04-30  Tom Tromey  <tromey@adacore.com>
5891
5892         PR c++/24470:
5893         * dwarf2read.c (process_structure_scope): Handle case where type
5894         has template parameters but no symbol was created.
5895
5896 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5897             Chris January  <chris.january@arm.com>
5898
5899         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5900         qualifier.
5901         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5902
5903 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5904
5905         * f-typeprint.c (f_print_type): Update rules for printing
5906         whitespace.
5907         (f_type_print_varspec_suffix): Likewise.
5908
5909 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5910             Chris January  <chris.january@arm.com>
5911
5912         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5913         function arguments.
5914
5915 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5916
5917         * f-lang.c (build_fortran_types): Change name of void type to
5918         lower case.
5919         * f-typeprint.c (f_type_print_base): Print the name of the void
5920         type, rather than a fixed string.
5921         * f-valprint.c (f_decorations): Use lower case void string.
5922
5923 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5924             Chris January  <chris.january@arm.com>
5925
5926         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5927         types for Fortran.
5928
5929 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5930             Chris January  <chris.january@arm.com>
5931             David Lecomber  <david.lecomber@arm.com>
5932
5933         * f-exp.y (BINOP_INTRINSIC): New token.
5934         (exp): New parser rule handling BINOP_INTRINSIC.
5935         (f77_keywords): Add new builtin procedures.
5936         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5937         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5938         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5939         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5940         (print_unop_subexp_f): New function.
5941         (print_binop_subexp_f): New function.
5942         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5943         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5944         (dump_subexp_body_f): Likewise.
5945         (operator_check_f): Likewise.
5946         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5947         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5948
5949 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5950
5951         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5952         UNOP_KIND.
5953         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5954         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5955         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5956         (operator_length_f): New fuction.
5957         (print_subexp_f): New function.
5958         (op_name_f): New function.
5959         (dump_subexp_body_f): New function.
5960         (operator_check_f): New function.
5961         (exp_descriptor_f): Replace standard expression handling functions
5962         with new functions.
5963         * gdb/fortran-operator.def: New file.
5964         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5965         * gdb/std-operator.def: Remove UNOP_KIND.
5966
5967 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5968
5969         * std-operator.def: Remove unbalanced, stray double quote
5970         character.
5971
5972 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5973             Chris January  <chris.january@arm.com>
5974             Daniel Everett  <daniel.everett@arm.com>
5975             Nick Forrington  <nick.forrington@arm.com>
5976             Richard Bunt  <richard.bunt@arm.com>
5977
5978         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5979         of depth when printing anonymous structs or unions.
5980         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5981         Don't print either the top-level value, or the children if the
5982         max-depth is exceeded.
5983         (ppscm_print_children): When printing the key of a map, allow one
5984         extra level of depth.
5985         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5986         print either the top-level value, or the children if the max-depth
5987         is exceeded.
5988         (print_children): When printing the key of a map, allow one extra
5989         level of depth.
5990         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5991         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5992         (user_print_options): Initialise max_depth field.
5993         (val_print_scalar_or_string_type_p): New function.
5994         (val_print): Check to see if the max depth has been reached.
5995         (val_print_check_max_depth): Define new function.
5996         (show_print_max_depth): New function.
5997         (_initialize_valprint): Add 'print max-depth' option.
5998         * valprint.h (struct value_print_options) <max_depth>: New field.
5999         (val_print_check_max_depth): Declare new function.
6000         * NEWS: Document new feature.
6001
6002 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         * ada-lang.c (ada_language_defn): Initialise new field.
6005         * c-lang.c (c_is_string_type_p): New function.
6006         (c_language_defn): Initialise new field.
6007         (cplus_language_defn): Initialise new field.
6008         (asm_language_defn): Initialise new field.
6009         (minimal_language_defn): Initialise new field.
6010         * c-lang.h (c_is_string_type_p): Declare new function.
6011         * d-lang.c (d_language_defn): Initialise new field.
6012         * f-lang.c (f_is_string_type_p): New function.
6013         (f_language_defn): Initialise new field.
6014         * go-lang.c (go_is_string_type_p): New function.
6015         (go_language_defn): Initialise new field.
6016         * language.c (default_is_string_type_p): New function.
6017         (unknown_language_defn): Initialise new field.
6018         (auto_language_defn): Initialise new field.
6019         * language.h (struct language_defn) <la_is_string_type_p>: New
6020         member variable.
6021         (default_is_string_type_p): Declare new function.
6022         * m2-lang.c (m2_language_defn): Initialise new field.
6023         * objc-lang.c (objc_language_defn): Initialise new field.
6024         * opencl-lang.c (opencl_language_defn): Initialise new field.
6025         * p-lang.c (pascal_is_string_type_p): New function.
6026         (pascal_language_defn): Initialise new field.
6027         * rust-lang.c (rust_is_string_type_p): New function.
6028         (rust_language_defn): Initialise new field.
6029
6030 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6031
6032         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6033         New field.
6034         * ada-lang.c (ada_language_defn): Initialise new field.
6035         * c-lang.c (c_language_defn): Likewise.
6036         (cplus_language_defn): Likewise.
6037         (asm_language_defn): Likewise.
6038         (minimal_language_defn): Likewise.
6039         * d-lang.c (d_language_defn): Likewise.
6040         * f-lang.c (f_language_defn): Likewise.
6041         * go-lang.c (go_language_defn): Likewise.
6042         * language.c (unknown_language_defn): Likewise.
6043         (auto_language_defn): Likewise.
6044         * m2-lang.c (m2_language_defn): Likewise.
6045         * objc-lang.c (objc_language_defn): Likewise.
6046         * opencl-lang.c (opencl_language_defn): Likewise.
6047         * p-lang.c (pascal_language_defn): Likewise.
6048         * rust-lang.c (rust_language_defn): Likewise.
6049
6050 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6051
6052         * ada-lang.c (ada_is_character_type): Change return type to bool.
6053         (ada_is_string_type): Likewise.
6054         * ada-lang.h (ada_is_character_type): Update declaration
6055         (ada_is_string_type): Likewise.
6056
6057 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6058
6059         Support style in 'frame|thread apply'
6060
6061         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6062         * record.c (record_start, record_stop): Update callers of
6063         execute_command_to_string with false.
6064         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6065         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6066         methods.
6067         (class string_file): New constructor with term_out parameter.
6068         Override methods term_out and can_emit_style_escape.  New member
6069         term_out.
6070         (class stdio_file): Override can_emit_style_escape.
6071         (class tee_file): Override term_out and can_emit_style_escape.
6072         * utils.h (can_emit_style_escape): Remove.
6073         * utils.c (can_emit_style_escape): Likewise.
6074         Update all callers of can_emit_style_escape (SOMESTREAM) to
6075         SOMESTREAM->can_emit_style_escape.
6076         * source-cache.c (source_cache::get_source_lines): Likewise.
6077         * stack.c (frame_apply_command_count): Call execute_command_to_string
6078         passing the term_out characteristic of the current gdb_stdout.
6079         * thread.c (thr_try_catch_cmd): Likewise.
6080         * top.c (execute_command_to_string): pass term_out parameter
6081         to construct the string_file for the command output.
6082         * ui-file.c (term_cli_styling): New function (most code moved
6083         from utils.c can_emit_style_escape).
6084         (string_file::string_file, string_file::can_emit_style_escape,
6085         stdio_file::can_emit_style_escape, tee_file::term_out,
6086         tee_file::can_emit_style_escape): New functions.
6087
6088 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6089
6090         * NEWS: Mention the new set|show may-call-functions.
6091         * infcall.c (may_call_functions_p): New variable.
6092         (show_may_call_functions_p): New function.
6093         (call_function_by_hand_dummy): Throws an error if not
6094         may-call-functions.
6095         (_initialize_infcall): Call add_setshow_boolean_cmd for
6096         may-call-functions.
6097
6098 2019-04-25  Keith Seitz  <keiths@redhat.com>
6099
6100         PR c++/24367
6101         * cp-support.c (inspect_type): Don't attempt substitutions
6102         of symbol with the same name.
6103
6104 2019-04-25  Tom Tromey  <tromey@adacore.com>
6105
6106         PR gdb/24475:
6107         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6108         static.
6109
6110 2019-04-25  Tom Tromey  <tromey@adacore.com>
6111
6112         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6113         rvalue reference.
6114         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6115         (gdb_xml_parser::parse): Use std::move.
6116         * python/python-internal.h (gdbpy_convert_exception): Take a const
6117         reference.
6118         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6119         std::move.
6120         * python/py-utils.c (gdbpy_convert_exception): Take a const
6121         reference.
6122         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6123         Use std::move.
6124         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6125         Use std::move.
6126         * mi/mi-main.c (mi_print_exception): Take a const reference.
6127         * main.c (handle_command_errors): Take a const reference.
6128         * linespec.c (parse_linespec): Use std::move.
6129         * infcall.c (run_inferior_call): Use std::move.
6130         (call_function_by_hand_dummy): Use std::move.
6131         * exec.c (try_open_exec_file): Use std::move.
6132         * exceptions.h (exception_print, exception_fprintf)
6133         (exception_print_same): Update.
6134         * exceptions.c (print_exception, exception_print)
6135         (exception_fprintf, exception_print_same): Change parameters to
6136         const reference.
6137         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6138         * common/new-op.c: Use std::move.
6139         * common/common-exceptions.h (struct gdb_exception): Add move
6140         constructor.
6141         (struct gdb_exception_error, struct gdb_exception_quit, struct
6142         gdb_quit_bad_alloc): Change constructor to move constructor.
6143         (throw_exception): Change parameter to rvalue reference.
6144         * common/common-exceptions.c (throw_exception): Take rvalue
6145         reference.
6146         * cli/cli-interp.c (safe_execute_command): Use std::move.
6147         * breakpoint.c (insert_bp_location, location_to_sals): Use
6148         std::move.
6149
6150 2019-04-25  Tom Tromey  <tromey@adacore.com>
6151
6152         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6153         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6154         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6155         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6156         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6157         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6158         guile/scm-value.c: Use unpack.
6159         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6160         gdbscm_gdb_exception.
6161         (gdbscm_throw_gdb_exception): Likewise.
6162         (struct gdbscm_gdb_exception): New.
6163         (unpack): New function.
6164         (gdbscm_wrap): Use unpack.
6165
6166 2019-04-25  Tom Tromey  <tromey@adacore.com>
6167
6168         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6169         (gdb_rl_callback_handler): Use std::move.
6170         * common/common-exceptions.h (struct gdb_exception): Add move
6171         assignment operator.
6172         (throw_exception_sjlj): Change "exception" to const reference.
6173         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6174         (throw_exception_sjlj): Change "exception" to const reference.
6175
6176 2019-04-25  Tom Tromey  <tromey@adacore.com>
6177
6178         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6179         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6180         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6181         Update.
6182         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6183         Update.
6184         * mi/mi-interp.c (mi_interp::exec): Update.
6185         * linespec.c (parse_linespec): Update.
6186         * infcall.c (run_inferior_call): Update.
6187         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6188         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6189         (gdbscm_lookup_global_symbol): Update.
6190         * guile/scm-param.c (gdbscm_parameter_value): Update.
6191         * guile/scm-frame.c (gdbscm_frame_read_register)
6192         (gdbscm_frame_read_var): Update.
6193         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6194         * exec.c (try_open_exec_file): Update.
6195         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6196         (gdb_rl_callback_handler): Update.
6197         * common/common-exceptions.h (exception_none): Don't declare.
6198         * common/common-exceptions.c (exception_none): Don't define.
6199         (struct catcher) <exception>: Update.
6200         * cli/cli-interp.c (safe_execute_command): Update.
6201         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6202
6203 2019-04-25  Ali Tamur  <tamur@google.com>
6204
6205         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6206         (read_attribute_value): Likewise.
6207         (dwarf2_read_addr_index): Update comment.
6208         (read_str_index): Add DW_FORM_strx.
6209         (dwarf2_string_attr): Likewise.
6210         (dwarf2_const_value_attr): Likewise.
6211         (dump_die_shallow): Likewise.
6212         (dwarf2_fetch_constant_bytes): Likewise.
6213         (skip_form_bytes): Likewise.
6214         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6215
6216 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6217
6218         PR corefiles/11608
6219         PR corefiles/18187
6220         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6221         OFFSET.  Verify if current mapping contains an ELF header.
6222         (linux_find_memory_regions_full): Adjust call to
6223         dump_mapping_p.
6224
6225 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6226             Kang Li <kanglictf@gmail.com>
6227
6228         PR gdb/21600
6229
6230         * dwarf2-frame.c (read_initial_length): Be consistent about using
6231         unsigned representation of length.
6232         (decode_frame_entry_1): Likewise.  Check for wraparound of
6233         end pointer as well as buffer overflow.
6234
6235 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6236
6237         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6238         "vq".
6239
6240 2019-04-24  Tom Tromey  <tromey@adacore.com>
6241
6242         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6243
6244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6245
6246         * s12z-tdep.c (s12z_unwind_pc): Delete.
6247         (s12z_unwind_sp): Delete.
6248         (s12z_gdbarch_init): Don't register deleted functions with
6249         gdbarch.
6250
6251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6252
6253         * rl78-tdep.c (rl78_unwind_sp): Delete.
6254         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6255
6256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6257
6258         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6259         (xstormy16_unwind_pc): Delete.
6260         (xstormy16_dummy_id): Delete.
6261         (xstormy16_gdbarch_init): Don't register deleted functions with
6262         gdbarch.
6263
6264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6265
6266         * vax-tdep.c (vax_unwind_pc): Delete.
6267         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6268
6269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6270
6271         * v850-tdep.c (v850_unwind_sp): Delete.
6272         (v850_unwind_pc): Delete.
6273         (v850_dummy_id): Delete.
6274         (v850_gdbarch_init): Don't register deleted functions with
6275         gdbarch.
6276
6277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6278
6279         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6280         (tilegx_unwind_pc): Delete.
6281         (tilegx_unwind_dummy_id): Delete.
6282         (tilegx_gdbarch_init): Don't register deleted functions with
6283         gdbarch.
6284
6285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6286
6287         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6288         (tic6x_dummy_id): Delete.
6289         (tic6x_gdbarch_init): Don't register deleted functions with
6290         gdbarch.
6291
6292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6293
6294         * sparc-tdep.c (sparc_unwind_pc): Delete.
6295         (sparc32_gdbarch_init): Don't register deleted function with
6296         gdbarch.
6297
6298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6299
6300         * sh-tdep.c (sh_unwind_sp): Delete.
6301         (sh_unwind_pc): Delete.
6302         (sh_dummy_id): Delete.
6303         (sh_gdbarch_init): Don't register deleted functions with
6304         gdbarch.
6305
6306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * score-tdep.c (score_unwind_sp): Delete.
6309         (score_unwind_pc): Delete.
6310         (score_dummy_id): Delete.
6311         (score_gdbarch_init): Don't register deleted functions with
6312         gdbarch.
6313
6314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6315
6316         * rx-tdep.c (rx_unwind_pc): Delete.
6317         (rx_unwind_sp): Delete.
6318         (rx_dummy_id): Delete.
6319         (rx_gdbarch_init): Don't register deleted functions with
6320         gdbarch.  Update comment.
6321
6322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6323
6324         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6325         (rs6000_dummy_id): Delete.
6326         (rs6000_gdbarch_init): Don't register deleted functions with
6327         gdbarch.
6328
6329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6330
6331         * or1k-tdep.c (or1k_dummy_id): Delete.
6332         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6333
6334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6335
6336         * nios2-tdep.c (nios2_dummy_id): Delete.
6337         (nios2_unwind_sp): Delete.
6338         (nios2_gdbarch_init): Don't register deleted functions with
6339         gdbarch.
6340
6341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6342
6343         * nds32-tdep.c (nds32_dummy_id): Delete.
6344         (nds32_unwind_pc): Delete.
6345         (nds32_unwind_sp): Delete.
6346         (nds32_gdbarch_init): Don't register deleted functions with
6347         gdbarch.
6348
6349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6350
6351         * msp430-tdep.c (msp430_unwind_pc): Delete.
6352         (msp430_unwind_sp): Delete.
6353         (msp430_dummy_id): Delete.
6354         (msp430_gdbarch_init): Don't register deleted functions with
6355         gdbarch.
6356
6357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6358
6359         * moxie-tdep.c (moxie_unwind_sp): Delete.
6360         (moxie_unwind_pc): Delete.
6361         (moxie_dummy_id): Delete.
6362         (moxie_gdbarch_init): Don't register deleted functions with
6363         gdbarch.
6364
6365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6366
6367         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6368         (mn10300_unwind_pc): Delete.
6369         (mn10300_unwind_sp): Delete.
6370         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6371         mn10300_unwind_sp.
6372         (mn10300_frame_unwind_init): Don't register deleted functions with
6373         gdbarch.
6374
6375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6376
6377         * mep-tdep.c (mep_unwind_pc): Delete.
6378         (mep_unwind_sp): Delete.
6379         (mep_dummy_id): Delete.
6380         (mep_gdbarch_init): Don't register deleted functions with
6381         gdbarch.
6382
6383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6384
6385         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6386         (m68hc11_unwind_sp): Delete.
6387         (m68hc11_gdbarch_init): Don't register deleted functions with
6388         gdbarch.
6389
6390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6391
6392         * m32r-tdep.c (m32r_unwind_sp): Delete.
6393         (m32r_unwind_pc): Delete.
6394         (m32r_dummy_id): Delete.
6395         (m32r_gdbarch_init): Don't register deleted functions with
6396         gdbarch.
6397
6398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6399
6400         * m32c-tdep.c (m32c_unwind_pc): Delete.
6401         (m32c_unwind_sp): Delete.
6402         (m32c_dummy_id): Delete.
6403         (m32c_gdbarch_init): Don't register deleted functions with
6404         gdbarch.
6405
6406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6407
6408         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6409         (lm32_unwind_pc): Delete.
6410         (lm32_dummy_id): Delete.
6411         (lm32_gdbarch_init): Don't register deleted functions with
6412         gdbarch.
6413
6414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6415
6416         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6417         (iq2000_unwind_pc): Delete.
6418         (iq2000_dummy_id): Delete.
6419         (iq2000_gdbarch_init): Don't register deleted functions with
6420         gdbarch.
6421
6422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6423
6424         * nds32-tdep.c (nds32_type_align): Delete.
6425         (nds32_push_dummy_call): Use type_align instead.
6426
6427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6428
6429         * arm-tdep.c (arm_type_align): Only handle vector override case.
6430         (arm_push_dummy_call): Use type_align.
6431         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6432
6433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6434
6435         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6436         case.
6437         (pass_on_stack): Use type_align.
6438         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6439         function.
6440
6441 2019-04-23  Tom Tromey  <tromey@adacore.com>
6442
6443         * dwarf2read.c (line_header::file_name_at): Remove unused
6444         overload.
6445
6446 2019-04-23  Tom de Vries  <tdevries@suse.de>
6447
6448         PR gdb/24438
6449         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6450         invocation.
6451
6452
6453 2019-03-27  Ali Tamur  <tamur@google.com>
6454
6455         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6456         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6457         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6458         (dwarf_expr_context::get_addr_index): Likewise
6459         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6460         (symbol_needs_eval_context::get_addr_index): Likewise
6461         (disassemble_dwarf_expression): Add DW_OP_addrx
6462         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6463         (read_cutu_die_from_dwo): Update comment
6464         (skip_one_die): Add DW_FORM_addrx
6465         (read_attribute_value): Likewise
6466         (var_decode_location): Add DW_OP_addrx
6467         (dwarf2_const_value_attr): Add DW_FORM_addrx
6468         (dump_die_shallow): Likewise
6469         (dwarf2_fetch_constant_bytes): Likewise
6470         (decode_locdesc): Add DW_OP_addrx
6471         (skip_form_bytes): Add DW_FORM_addrx
6472
6473 2019-04-22  Ali Tamur  <tamur@google.com>
6474
6475         * MAINTAINERS (Write After Approval): Add self.
6476
6477 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6478
6479         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6480         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6481         (open_symbol_file_object): Likewise.
6482         (svr4_default_sos): Add info parameter.
6483         (svr4_read_so_list): Likewise.
6484         (svr4_current_sos_direct): Adjust functions calls to pass down
6485         info.
6486         (svr4_current_sos_1): Add info parameter.
6487         (svr4_current_sos): Call get_svr4_info, pass info down to
6488         svr4_current_sos_1.
6489         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6490         get_svr4_info.
6491         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6492         get_svr4_info.
6493         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6494         to get_svr4_info.
6495         (probes_table_remove_objfile_probes): Likewise.
6496         (register_solib_event_probe): Add info parameter.
6497         (solist_update_incremental): Pass info parameter down to
6498         svr4_read_so_list.
6499         (disable_probes_interface): Add info parameter.
6500         (svr4_handle_solib_event): Pass current_program_space to
6501         get_svr4_info.  Adjust disable_probes_interface cleanup.
6502         (svr4_create_probe_breakpoints): Add info parameter, pass it
6503         down to register_solib_event_probe.
6504         (svr4_create_solib_event_breakpoints): Add info parameter,
6505         pass it down to svr4_create_probe_breakpoints.
6506         (enable_break): Pass info down to
6507         svr4_create_solib_event_breakpoints.
6508         (svr4_solib_create_inferior_hook): Pass current_program_space to
6509         get_svr4_info.
6510         (svr4_clear_solib): Likewise.
6511
6512 2019-04-22  Pedro Alves  <palves@redhat.com>
6513
6514         * solib-svr4.c (svr4_free_objfile_observer): New.
6515         (probe_and_action::objfile): New field.
6516         (probes_table_htab_remove_objfile_probes)
6517         (probes_table_remove_objfile_probes): New functions.
6518         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6519         in the new probe_and_action.  Don't store the probe in 'lookup'.
6520         (svr4_create_probe_breakpoints): Pass objfile to
6521         register_solib_event_probe.
6522         (_initialize_svr4_solib): Register a free_objfile observer.
6523
6524 2019-04-19  Tom Tromey  <tom@tromey.com>
6525
6526         * common/queue.h: Remove.
6527
6528 2019-04-19  Tom Tromey  <tom@tromey.com>
6529
6530         * event-loop.c: Don't include "common/queue.h".
6531
6532 2019-04-19  Tom Tromey  <tom@tromey.com>
6533
6534         * remote.c (remote_target): Use delete.
6535         * remote-notif.h: Include <list>, not "common/queue.h".
6536         (notif_client_p): Remove typedef.
6537         (remote_notif_state): Add constructor, destructor, initializer.
6538         <notif_queue>: Now a std::list.
6539         (remote_notif_state_xfree): Don't declare.
6540         * remote-notif.c (remote_notif_process, handle_notification)
6541         (remote_notif_state_allocate): Update.
6542         (~remote_notif_state): Rename from remote_notif_state_xfree.
6543
6544 2019-04-19  Tom Tromey  <tom@tromey.com>
6545
6546         * symfile.c (reread_symbols): Update.
6547         * objfiles.c (objfile_register_static_link)
6548         (objfile_lookup_static_link): Update
6549         (~objfile) Don't delete static_links.
6550         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6551
6552 2019-04-19  Tom Tromey  <tom@tromey.com>
6553
6554         * type-stack.h (struct type_stack) <insert>: Constify string.
6555         * type-stack.c (type_stack::insert): Constify string.
6556         * gdbtypes.h (lookup_template_type): Update.
6557         (address_space_name_to_int): Update.
6558         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6559         const.
6560         (lookup_template_type): Make name const.
6561         * c-exp.y: Update rules.
6562         (lex_one_token, classify_name, classify_inner_name)
6563         (c_print_token): Update.
6564         * p-exp.y: Update rules.
6565         (yylex): Update.
6566         * f-exp.y: Update rules.
6567         (yylex): Update.
6568         * d-exp.y: Update rules.
6569         (lex_one_token, classify_name, classify_inner_name): Update.
6570         * parse.c (write_dollar_variable, copy_name): Return std::string.
6571         * parser-defs.h (copy_name): Change return type.
6572         * m2-exp.y: Update rules.
6573         (yylex): Update.
6574         * go-exp.y (lex_one_token): Update.
6575         Update rules.
6576         (classify_unsafe_function, classify_packaged_name)
6577         (classify_name, yylex): Update.
6578
6579 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6580
6581         * configure.ac: add --enable-source-highlight switch.
6582         * configure: Regenerate.
6583         * top.c (print_gdb_version): plumb --enable-source-highlight
6584         status to "show configuration".
6585
6586 2019-04-19  Tom Tromey  <tromey@adacore.com>
6587
6588         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6589         Check ADA_TYPE_P.
6590         (empty_record, ada_template_to_fixed_record_type_1)
6591         (template_to_static_fixed_type)
6592         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6593         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6594         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6595         macros.
6596
6597 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6598
6599         PR symtab/24423:
6600         * source.c (print_source_lines_base): Advance "iter" when a
6601         control character is seen.
6602
6603 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6604
6605         * inferior.h (struct infcall_suspend_state_deleter):
6606         Catch exception in destructor to avoid crash.
6607
6608 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6609
6610         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6611         close to the add_com "shell".
6612
6613 2019-04-18  Tom Tromey  <tromey@adacore.com>
6614
6615         * process-stratum-target.h (class process_stratum_target)
6616         <stratum>: Add "final".
6617
6618 2019-04-17  Tom Tromey  <tromey@adacore.com>
6619
6620         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6621         against nullptr before use.
6622
6623 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6624
6625         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6626
6627 2019-04-17  Jim Wilson  <jimw@sifive.com>
6628             Andrew Burgess  <andrew.burgess@embecosm.com>
6629
6630         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6631         code read might fail, assume 4-byte breakpoint in that case.
6632
6633 2019-04-15  Leszek Swirski  <leszeks@google.com>
6634
6635         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6636         rather than a hand-rolled POD check when checking for forced MEMORY
6637         classification.
6638
6639 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6640
6641         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6642         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6643         function.
6644         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6645         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6646         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6647         declaration.
6648
6649 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6650
6651         * aarch64-linux-nat.c
6652         (aarch64_linux_nat_target::thread_architecture): Add override.
6653         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6654         each VQ.
6655
6656 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6657
6658         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6659
6660 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6663         target types of size 96-bits, add some additional comments, and
6664         check that the builtin type we found was the correct size.
6665
6666 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6667
6668         * utils.c (prompt_for_continue): Don't restore the styling at the
6669         end, as applied_style has the wrong value.  This fixes styling in
6670         long lists of file names that are interrupted by the "Continue?"
6671         prompt.
6672
6673 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6674
6675         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6676         * c-lang.c (c_language_defn): Likewise.
6677         (cplus_language_defn): Likewise.
6678         (asm_language_defn): Likewise.
6679         (minimal_language_defn): Likewise.
6680         * d-lang.c (d_language_defn): Likewise.
6681         * f-lang.c (f_language_defn): Likewise.
6682         * go-lang.c (go_language_defn): Likewise.
6683         * language.c (unknown_language_defn): Likewise.
6684         (auto_language_defn): Likewise.
6685         * language.h (struct language_defn): Remove la_magic field.
6686         (LANG_MAGIC): Delete.
6687         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6688         * objc-lang.c (objc_language_defn): Likewise.
6689         * opencl-lang.c (opencl_language_defn): Likewise.
6690         * p-lang.c (pascal_language_defn): Likewise.
6691         * rust-lang.c (rust_language_defn): Likewise.
6692
6693 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6694
6695         * riscv-tdep.c (riscv_type_align): New function.
6696         (riscv_type_alignment): Delete.
6697         (riscv_arg_location): Use 'type_align'.
6698         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6699
6700 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6701
6702         * gdbtypes.c (type_align): A struct with no non-static fields also
6703         has alignment of 1.
6704
6705 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6706
6707         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6708         component to 0.
6709         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6710         member.
6711         (riscv_struct_info::analyse): New implementation using new
6712         analyse_inner member function.
6713         (riscv_struct_info::field_offset): New member function.
6714         (riscv_struct_info::m_offsets): New member variable.
6715         (riscv_struct_info::analyse_inner): New private member function,
6716         takes the old implementation of riscv_struct_info::analyse but
6717         extended to track field offsets.
6718         (riscv_call_arg_struct): Update the struct folding special cases
6719         to handle cases where empty C++ structs, which are non-zero
6720         length, are found.
6721         (riscv_arg_location): Initialise the length of each location, a
6722         non-zero length now indicates the location is in use.
6723         (riscv_push_dummy_call): Allow for the first location having a
6724         non-zero offset when setting up arguments.
6725         (riscv_return_value): Likewise, but for return values.
6726
6727 2019-04-11  Tom Tromey  <tromey@adacore.com>
6728
6729         * utils.c (internal_vproblem): Make "msg" const.
6730
6731 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6732
6733         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6734         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6735         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6736         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6737
6738 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6739
6740         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6741         function.
6742         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6743         of amd64_collect_native_gregset.
6744         (amd64_linux_nat_target::store_registers): Likewise.
6745
6746 2019-04-10  Tom Tromey  <tom@tromey.com>
6747
6748         * symtab.c (lookup_global_symbol_from_objfile)
6749         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6750         * objfiles.h (class separate_debug_iterator): New.
6751         (class separate_debug_range): New.
6752         (struct objfile) <separate_debug_objfiles>: New method.
6753         (objfile_separate_debug_iterate): Don't declare.
6754         * objfiles.c (separate_debug_iterator::operator++): Rename from
6755         objfile_separate_debug_iterate.
6756         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6757         iterator.
6758         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6759         iterator.
6760
6761 2019-04-10  Tom Tromey  <tom@tromey.com>
6762
6763         * symfile.c (reread_symbols): Remove old comment.
6764         * objfiles.c (free_all_objfiles): Fix a typo.
6765
6766 2019-04-10  Tom Tromey  <tom@tromey.com>
6767
6768         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6769         * minsyms.c (lookup_minimal_symbol): Use foreach.
6770         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6771         (lookup_minimal_symbol_solib_trampoline): Likewise.
6772         * symfile.c (reread_symbols): Use foreach.
6773
6774 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6775             Tom Tromey  <tromey@adacore.com>
6776
6777         PR rust/24414:
6778         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6779         (rust_lex_int_test): Change "value" to be LONGEST.
6780         (rust_lex_tests): Add test for long integer literal.
6781
6782 2019-04-09  Tom Tromey  <tromey@adacore.com>
6783
6784         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6785         to bool.
6786         (extended_remote_target::attach): Update.
6787         (remote_target::remote_notice_new_inferior): Update.
6788         (remote_target::add_current_inferior_and_thread): Update.
6789         * inferior.c (exit_inferior_1): Use "false".
6790         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6791
6792 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6793
6794         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6795         the "start" command.
6796
6797 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6798
6799         * python/py-inferior.c (infpy_thread_from_thread_handle):
6800         Adjust comments to reflect renaming of thread_from_thread_handle
6801         to thread_from_handle.  Adjust keywords.  Fix type error message.
6802         (inferior_object_methods): Add thread_from_handle.  Retain
6803         thread_from_thread_handle, but mark it as deprecated.
6804
6805 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6806
6807         * gdbthread.h (find_thread_by_handle): Revise declaration.
6808         * thread.c (find_thread_by_handle): Likewise.  Adjust
6809         implementation too.
6810         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6811         support for buffer objects as handles.
6812
6813 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6814
6815         * python/py-infthread.c (thpy_thread_handle): New function.
6816         (thread_object_methods): Register thpy_thread_handle.
6817
6818 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6819
6820         * gdbthread.h (thread_to_thread_handle): Declare.
6821         * thread.c (gdbtypes.h): Include.
6822         (thread_to_thread_handle): New function.
6823
6824         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6825         (target_thread_info_to_thread_handle): Declare.
6826         * target.c (target_thread_info_to_thread_handle): New function.
6827         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6828         * target-delegates.c: Regenerate.
6829
6830         * linux-thread-db.c (class thread_db_target): Add method
6831         thread_info_to_thread_handle.
6832         (thread_db_target::thread_info_to_thread_handle): Define.
6833         * remote.c (class remote_target): Add new method
6834         thread_info_to_thread_handle.
6835         (remote_target::thread_info_to_thread_handle): Define.
6836
6837 2019-04-08  Pedro Alves  <palves@redhat.com>
6838
6839         * common/common-exceptions.c (throw_exception): Don't create
6840         named object to throw; throw directly.
6841         (throw_it): Likewise.  Don't initialize gdb_exception::message
6842         here, with new; pass FMT and AP to the ctor instead.
6843         * common/common-exceptions.h: Include <string>.
6844         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6845         const char *, va_list)): New ctor.  Use std::make_shared.
6846         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6847         errors)): Delete.
6848         (gdb_exception_error::gdb_exception_error(enum errors, const char
6849         *, va_list)): New.
6850         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6851         Add assertion.
6852         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6853         errors)): Delete.
6854         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6855         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6856         Add assertion.
6857
6858 2019-04-08  Tom Tromey  <tom@tromey.com>
6859
6860         * valops.c (value_rtti_indirect_type): Replace throw_exception
6861         with throw.
6862         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6863         with throw.
6864         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6865         throw.
6866         * target.c (target_translate_tls_address): Replace throw_exception
6867         with throw.
6868         * stack.c (frame_apply_command_count): Replace throw_exception
6869         with throw.
6870         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6871         throw.
6872         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6873         with throw.
6874         * rs6000-tdep.c (rs6000_frame_cache)
6875         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6876         * remote.c: Replace throw_exception with throw.
6877         * record-full.c (record_full_message, record_full_wait_1)
6878         (record_full_restore): Replace throw_exception with throw.
6879         * record-btrace.c:
6880         (get_thread_current_frame_id, record_btrace_start_replaying)
6881         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6882         (cmd_record_btrace_start): Replace throw_exception with throw.
6883         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6884         throw.
6885         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6886         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6887         * linespec.c:
6888         (find_linespec_symbols): Replace throw_exception with throw.
6889         * infrun.c (displaced_step_prepare, resume): Replace
6890         throw_exception with throw.
6891         * infcmd.c (post_create_inferior): Replace throw_exception with
6892         throw.
6893         * inf-loop.c (inferior_event_handler): Replace throw_exception
6894         with throw.
6895         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6896         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6897         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6898         (get_prev_frame_always, get_frame_pc_if_available)
6899         (get_frame_address_in_block_if_available, get_frame_language):
6900         Replace throw_exception with throw.
6901         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6902         throw_exception with throw.
6903         * eval.c (fetch_subexp_value, evaluate_var_value)
6904         (evaluate_funcall, evaluate_subexp_standard): Replace
6905         throw_exception with throw.
6906         * dwarf2loc.c (call_site_find_chain)
6907         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6908         Replace throw_exception with throw.
6909         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6910         with throw.
6911         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6912         throw.
6913         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6914         * completer.c (complete_line_internal): Replace throw_exception
6915         with throw.
6916         * compile/compile-object-run.c (compile_object_run): Replace
6917         throw_exception with throw.
6918         * cli/cli-script.c (process_next_line): Replace throw_exception
6919         with throw.
6920         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6921         (btrace_enable, btrace_maint_update_pt_packets): Replace
6922         throw_exception with throw.
6923         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6924         throw_exception with throw.
6925         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6926         throw_exception with throw.
6927         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6928         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6929         * aarch64-tdep.c (aarch64_make_prologue_cache)
6930         (aarch64_make_stub_cache): Replace throw_exception with throw.
6931
6932 2019-04-08  Tom Tromey  <tom@tromey.com>
6933
6934         * common/common-exceptions.c (throw_exception): Rename from
6935         throw_exception_cxx.  Remove old copy.  Make argument const.
6936         (throw_it): Create and throw exception objects directly.
6937         * common/common-exceptions.h (throw_exception): Make argument
6938         const.
6939         (struct gdb_exception_error): Add constructor.
6940         (struct gdb_exception_quit): Add constructor.
6941
6942 2019-04-08  Tom Tromey  <tom@tromey.com>
6943
6944         * common/common-exceptions.h (exception_rethrow): Don't declare.
6945         (TRY_SJLJ): Update comment.
6946         (TRY, CATCH, END_CATCH): Remove.
6947         * common/common-exceptions.c (exception_rethrow): Remove.
6948
6949 2019-04-08  Tom Tromey  <tom@tromey.com>
6950
6951         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6952         Remove.
6953         (gdb_exception_error): Rename from
6954         gdb_exception_RETURN_MASK_ERROR.
6955         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6956         (gdb_quit_bad_alloc): Update.
6957         * aarch64-tdep.c: Update.
6958         * ada-lang.c: Update.
6959         * ada-typeprint.c: Update.
6960         * ada-valprint.c: Update.
6961         * amd64-tdep.c: Update.
6962         * arch-utils.c: Update.
6963         * break-catch-throw.c: Update.
6964         * breakpoint.c: Update.
6965         * btrace.c: Update.
6966         * c-varobj.c: Update.
6967         * cli/cli-cmds.c: Update.
6968         * cli/cli-interp.c: Update.
6969         * cli/cli-script.c: Update.
6970         * common/common-exceptions.c: Update.
6971         * common/new-op.c: Update.
6972         * common/selftest.c: Update.
6973         * compile/compile-c-symbols.c: Update.
6974         * compile/compile-cplus-symbols.c: Update.
6975         * compile/compile-object-load.c: Update.
6976         * compile/compile-object-run.c: Update.
6977         * completer.c: Update.
6978         * corelow.c: Update.
6979         * cp-abi.c: Update.
6980         * cp-support.c: Update.
6981         * cp-valprint.c: Update.
6982         * darwin-nat.c: Update.
6983         * disasm-selftests.c: Update.
6984         * dtrace-probe.c: Update.
6985         * dwarf-index-cache.c: Update.
6986         * dwarf-index-write.c: Update.
6987         * dwarf2-frame-tailcall.c: Update.
6988         * dwarf2-frame.c: Update.
6989         * dwarf2loc.c: Update.
6990         * dwarf2read.c: Update.
6991         * eval.c: Update.
6992         * event-loop.c: Update.
6993         * event-top.c: Update.
6994         * exec.c: Update.
6995         * f-valprint.c: Update.
6996         * fbsd-tdep.c: Update.
6997         * frame-unwind.c: Update.
6998         * frame.c: Update.
6999         * gdbtypes.c: Update.
7000         * gnu-v3-abi.c: Update.
7001         * guile/guile-internal.h: Update.
7002         * guile/scm-block.c: Update.
7003         * guile/scm-breakpoint.c: Update.
7004         * guile/scm-cmd.c: Update.
7005         * guile/scm-disasm.c: Update.
7006         * guile/scm-frame.c: Update.
7007         * guile/scm-lazy-string.c: Update.
7008         * guile/scm-math.c: Update.
7009         * guile/scm-param.c: Update.
7010         * guile/scm-ports.c: Update.
7011         * guile/scm-pretty-print.c: Update.
7012         * guile/scm-symbol.c: Update.
7013         * guile/scm-symtab.c: Update.
7014         * guile/scm-type.c: Update.
7015         * guile/scm-value.c: Update.
7016         * i386-linux-tdep.c: Update.
7017         * i386-tdep.c: Update.
7018         * inf-loop.c: Update.
7019         * infcall.c: Update.
7020         * infcmd.c: Update.
7021         * infrun.c: Update.
7022         * jit.c: Update.
7023         * language.c: Update.
7024         * linespec.c: Update.
7025         * linux-fork.c: Update.
7026         * linux-nat.c: Update.
7027         * linux-tdep.c: Update.
7028         * linux-thread-db.c: Update.
7029         * main.c: Update.
7030         * mi/mi-cmd-break.c: Update.
7031         * mi/mi-cmd-stack.c: Update.
7032         * mi/mi-interp.c: Update.
7033         * mi/mi-main.c: Update.
7034         * objc-lang.c: Update.
7035         * p-valprint.c: Update.
7036         * parse.c: Update.
7037         * ppc-linux-tdep.c: Update.
7038         * printcmd.c: Update.
7039         * python/py-arch.c: Update.
7040         * python/py-breakpoint.c: Update.
7041         * python/py-cmd.c: Update.
7042         * python/py-finishbreakpoint.c: Update.
7043         * python/py-frame.c: Update.
7044         * python/py-framefilter.c: Update.
7045         * python/py-gdb-readline.c: Update.
7046         * python/py-inferior.c: Update.
7047         * python/py-infthread.c: Update.
7048         * python/py-lazy-string.c: Update.
7049         * python/py-linetable.c: Update.
7050         * python/py-objfile.c: Update.
7051         * python/py-param.c: Update.
7052         * python/py-prettyprint.c: Update.
7053         * python/py-progspace.c: Update.
7054         * python/py-record-btrace.c: Update.
7055         * python/py-record.c: Update.
7056         * python/py-symbol.c: Update.
7057         * python/py-type.c: Update.
7058         * python/py-unwind.c: Update.
7059         * python/py-utils.c: Update.
7060         * python/py-value.c: Update.
7061         * python/python.c: Update.
7062         * record-btrace.c: Update.
7063         * record-full.c: Update.
7064         * remote-fileio.c: Update.
7065         * remote.c: Update.
7066         * riscv-tdep.c: Update.
7067         * rs6000-aix-tdep.c: Update.
7068         * rs6000-tdep.c: Update.
7069         * rust-exp.y: Update.
7070         * rust-lang.c: Update.
7071         * s390-tdep.c: Update.
7072         * selftest-arch.c: Update.
7073         * solib-dsbt.c: Update.
7074         * solib-frv.c: Update.
7075         * solib-spu.c: Update.
7076         * solib-svr4.c: Update.
7077         * solib.c: Update.
7078         * sparc64-linux-tdep.c: Update.
7079         * stack.c: Update.
7080         * symfile-mem.c: Update.
7081         * symmisc.c: Update.
7082         * target.c: Update.
7083         * thread.c: Update.
7084         * top.c: Update.
7085         * tracefile-tfile.c: Update.
7086         * tui/tui.c: Update.
7087         * typeprint.c: Update.
7088         * unittests/cli-utils-selftests.c: Update.
7089         * unittests/parse-connection-spec-selftests.c: Update.
7090         * valops.c: Update.
7091         * valprint.c: Update.
7092         * value.c: Update.
7093         * varobj.c: Update.
7094         * windows-nat.c: Update.
7095         * x86-linux-nat.c: Update.
7096         * xml-support.c: Update.
7097
7098 2019-04-08  Tom Tromey  <tom@tromey.com>
7099
7100         * xml-support.c: Use C++ exception handling.
7101         * x86-linux-nat.c: Use C++ exception handling.
7102         * windows-nat.c: Use C++ exception handling.
7103         * varobj.c: Use C++ exception handling.
7104         * value.c: Use C++ exception handling.
7105         * valprint.c: Use C++ exception handling.
7106         * valops.c: Use C++ exception handling.
7107         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7108         handling.
7109         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7110         * typeprint.c: Use C++ exception handling.
7111         * tui/tui.c: Use C++ exception handling.
7112         * tracefile-tfile.c: Use C++ exception handling.
7113         * top.c: Use C++ exception handling.
7114         * thread.c: Use C++ exception handling.
7115         * target.c: Use C++ exception handling.
7116         * symmisc.c: Use C++ exception handling.
7117         * symfile-mem.c: Use C++ exception handling.
7118         * stack.c: Use C++ exception handling.
7119         * sparc64-linux-tdep.c: Use C++ exception handling.
7120         * solib.c: Use C++ exception handling.
7121         * solib-svr4.c: Use C++ exception handling.
7122         * solib-spu.c: Use C++ exception handling.
7123         * solib-frv.c: Use C++ exception handling.
7124         * solib-dsbt.c: Use C++ exception handling.
7125         * selftest-arch.c: Use C++ exception handling.
7126         * s390-tdep.c: Use C++ exception handling.
7127         * rust-lang.c: Use C++ exception handling.
7128         * rust-exp.y: Use C++ exception handling.
7129         * rs6000-tdep.c: Use C++ exception handling.
7130         * rs6000-aix-tdep.c: Use C++ exception handling.
7131         * riscv-tdep.c: Use C++ exception handling.
7132         * remote.c: Use C++ exception handling.
7133         * remote-fileio.c: Use C++ exception handling.
7134         * record-full.c: Use C++ exception handling.
7135         * record-btrace.c: Use C++ exception handling.
7136         * python/python.c: Use C++ exception handling.
7137         * python/py-value.c: Use C++ exception handling.
7138         * python/py-utils.c: Use C++ exception handling.
7139         * python/py-unwind.c: Use C++ exception handling.
7140         * python/py-type.c: Use C++ exception handling.
7141         * python/py-symbol.c: Use C++ exception handling.
7142         * python/py-record.c: Use C++ exception handling.
7143         * python/py-record-btrace.c: Use C++ exception handling.
7144         * python/py-progspace.c: Use C++ exception handling.
7145         * python/py-prettyprint.c: Use C++ exception handling.
7146         * python/py-param.c: Use C++ exception handling.
7147         * python/py-objfile.c: Use C++ exception handling.
7148         * python/py-linetable.c: Use C++ exception handling.
7149         * python/py-lazy-string.c: Use C++ exception handling.
7150         * python/py-infthread.c: Use C++ exception handling.
7151         * python/py-inferior.c: Use C++ exception handling.
7152         * python/py-gdb-readline.c: Use C++ exception handling.
7153         * python/py-framefilter.c: Use C++ exception handling.
7154         * python/py-frame.c: Use C++ exception handling.
7155         * python/py-finishbreakpoint.c: Use C++ exception handling.
7156         * python/py-cmd.c: Use C++ exception handling.
7157         * python/py-breakpoint.c: Use C++ exception handling.
7158         * python/py-arch.c: Use C++ exception handling.
7159         * printcmd.c: Use C++ exception handling.
7160         * ppc-linux-tdep.c: Use C++ exception handling.
7161         * parse.c: Use C++ exception handling.
7162         * p-valprint.c: Use C++ exception handling.
7163         * objc-lang.c: Use C++ exception handling.
7164         * mi/mi-main.c: Use C++ exception handling.
7165         * mi/mi-interp.c: Use C++ exception handling.
7166         * mi/mi-cmd-stack.c: Use C++ exception handling.
7167         * mi/mi-cmd-break.c: Use C++ exception handling.
7168         * main.c: Use C++ exception handling.
7169         * linux-thread-db.c: Use C++ exception handling.
7170         * linux-tdep.c: Use C++ exception handling.
7171         * linux-nat.c: Use C++ exception handling.
7172         * linux-fork.c: Use C++ exception handling.
7173         * linespec.c: Use C++ exception handling.
7174         * language.c: Use C++ exception handling.
7175         * jit.c: Use C++ exception handling.
7176         * infrun.c: Use C++ exception handling.
7177         * infcmd.c: Use C++ exception handling.
7178         * infcall.c: Use C++ exception handling.
7179         * inf-loop.c: Use C++ exception handling.
7180         * i386-tdep.c: Use C++ exception handling.
7181         * i386-linux-tdep.c: Use C++ exception handling.
7182         * guile/scm-value.c: Use C++ exception handling.
7183         * guile/scm-type.c: Use C++ exception handling.
7184         * guile/scm-symtab.c: Use C++ exception handling.
7185         * guile/scm-symbol.c: Use C++ exception handling.
7186         * guile/scm-pretty-print.c: Use C++ exception handling.
7187         * guile/scm-ports.c: Use C++ exception handling.
7188         * guile/scm-param.c: Use C++ exception handling.
7189         * guile/scm-math.c: Use C++ exception handling.
7190         * guile/scm-lazy-string.c: Use C++ exception handling.
7191         * guile/scm-frame.c: Use C++ exception handling.
7192         * guile/scm-disasm.c: Use C++ exception handling.
7193         * guile/scm-cmd.c: Use C++ exception handling.
7194         * guile/scm-breakpoint.c: Use C++ exception handling.
7195         * guile/scm-block.c: Use C++ exception handling.
7196         * guile/guile-internal.h: Use C++ exception handling.
7197         * gnu-v3-abi.c: Use C++ exception handling.
7198         * gdbtypes.c: Use C++ exception handling.
7199         * frame.c: Use C++ exception handling.
7200         * frame-unwind.c: Use C++ exception handling.
7201         * fbsd-tdep.c: Use C++ exception handling.
7202         * f-valprint.c: Use C++ exception handling.
7203         * exec.c: Use C++ exception handling.
7204         * event-top.c: Use C++ exception handling.
7205         * event-loop.c: Use C++ exception handling.
7206         * eval.c: Use C++ exception handling.
7207         * dwarf2read.c: Use C++ exception handling.
7208         * dwarf2loc.c: Use C++ exception handling.
7209         * dwarf2-frame.c: Use C++ exception handling.
7210         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7211         * dwarf-index-write.c: Use C++ exception handling.
7212         * dwarf-index-cache.c: Use C++ exception handling.
7213         * dtrace-probe.c: Use C++ exception handling.
7214         * disasm-selftests.c: Use C++ exception handling.
7215         * darwin-nat.c: Use C++ exception handling.
7216         * cp-valprint.c: Use C++ exception handling.
7217         * cp-support.c: Use C++ exception handling.
7218         * cp-abi.c: Use C++ exception handling.
7219         * corelow.c: Use C++ exception handling.
7220         * completer.c: Use C++ exception handling.
7221         * compile/compile-object-run.c: Use C++ exception handling.
7222         * compile/compile-object-load.c: Use C++ exception handling.
7223         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7224         * compile/compile-c-symbols.c: Use C++ exception handling.
7225         * common/selftest.c: Use C++ exception handling.
7226         * common/new-op.c: Use C++ exception handling.
7227         * cli/cli-script.c: Use C++ exception handling.
7228         * cli/cli-interp.c: Use C++ exception handling.
7229         * cli/cli-cmds.c: Use C++ exception handling.
7230         * c-varobj.c: Use C++ exception handling.
7231         * btrace.c: Use C++ exception handling.
7232         * breakpoint.c: Use C++ exception handling.
7233         * break-catch-throw.c: Use C++ exception handling.
7234         * arch-utils.c: Use C++ exception handling.
7235         * amd64-tdep.c: Use C++ exception handling.
7236         * ada-valprint.c: Use C++ exception handling.
7237         * ada-typeprint.c: Use C++ exception handling.
7238         * ada-lang.c: Use C++ exception handling.
7239         * aarch64-tdep.c: Use C++ exception handling.
7240
7241 2019-04-08  Tom Tromey  <tom@tromey.com>
7242
7243         * xml-support.c (gdb_xml_parser::parse): Update.
7244         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7245         * value.c (show_convenience): Update.
7246         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7247         (test_parse_flags_qcs): Update.
7248         * thread.c (thr_try_catch_cmd): Update.
7249         * target.c (target_translate_tls_address): Update.
7250         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7251         (info_frame_command_core, frame_apply_command_count): Update.
7252         * rust-exp.y (rust_lex_exception_test): Update.
7253         * riscv-tdep.c (riscv_print_one_register_info): Update.
7254         * remote.c (remote_target::enable_btrace): Update.
7255         * record-btrace.c (record_btrace_enable_warn): Update.
7256         * python/py-utils.c (gdbpy_convert_exception): Update.
7257         * printcmd.c (do_one_display, print_variable_and_value): Update.
7258         * mi/mi-main.c (mi_print_exception): Update.
7259         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7260         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7261         * linux-nat.c (linux_nat_target::attach): Update.
7262         * linux-fork.c (class scoped_switch_fork_info): Update.
7263         * infrun.c (displaced_step_prepare): Update.
7264         * infcall.c (call_function_by_hand_dummy): Update.
7265         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7266         * gnu-v3-abi.c (print_one_vtable): Update.
7267         * frame.c (get_prev_frame_always): Update.
7268         * f-valprint.c (info_common_command_for_block): Update.
7269         * exec.c (try_open_exec_file): Update.
7270         * exceptions.c (print_exception, exception_print)
7271         (exception_fprintf, exception_print_same): Update.
7272         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7273         * dwarf-index-cache.c (index_cache::store)
7274         (index_cache::lookup_gdb_index): Update.
7275         * darwin-nat.c (maybe_cache_shell): Update.
7276         * cp-valprint.c (cp_print_value_fields): Update.
7277         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7278         (gcc_cplus_symbol_address): Update.
7279         * compile/compile-c-symbols.c (gcc_convert_symbol)
7280         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7281         * common/selftest.c: Update.
7282         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7283         a std::string.
7284         (exception_try_scope_entry, exception_try_scope_exit): Don't
7285         declare.
7286         (struct exception_try_scope): Remove.
7287         (TRY): Don't use exception_try_scope.
7288         (struct gdb_exception): Add constructor, operator=.
7289         <what>: New method.
7290         (struct gdb_exception_RETURN_MASK_ALL)
7291         (struct gdb_exception_RETURN_MASK_ERROR)
7292         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7293         (struct gdb_quit_bad_alloc): Update.
7294         * common/common-exceptions.c (exception_none): Change
7295         initializer.
7296         (struct catcher) <state, exception>: Initialize inline.
7297         <prev>: Remove member.
7298         (current_catcher): Remove.
7299         (catchers): New global.
7300         (exceptions_state_mc_init): Simplify.
7301         (catcher_pop): Remove.
7302         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7303         (try_scope_depth, exception_try_scope_entry)
7304         (exception_try_scope_exit): Remove.
7305         (throw_exception_sjlj): Update.
7306         (exception_messages, exception_messages_size): Remove.
7307         (throw_it): Simplify.
7308         (gdb_exception_sliced_copy): Remove.
7309         (throw_exception_cxx): Update.
7310         * cli/cli-script.c (script_from_file): Update.
7311         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7312         Update.
7313         * ada-valprint.c (ada_val_print): Update.
7314         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7315         (create_excep_cond_exprs): Update.
7316
7317 2019-04-08  Tom Tromey  <tom@tromey.com>
7318
7319         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7320         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7321         (TRY, CATCH, END_CATCH): Remove some definitions.
7322         * common/common-exceptions.c: Don't use GDB_XCPT.
7323         (catcher_list_size): Remove.
7324         (throw_exception, throw_it): Simplify.
7325
7326 2019-04-05  Tom Tromey  <tom@tromey.com>
7327
7328         Revert the header-sorting patch.
7329         * ft32-tdep.c: Revert.
7330         * frv-tdep.c: Revert.
7331         * frv-linux-tdep.c: Revert.
7332         * frame.c: Revert.
7333         * frame-unwind.c: Revert.
7334         * frame-base.c: Revert.
7335         * fork-child.c: Revert.
7336         * findvar.c: Revert.
7337         * findcmd.c: Revert.
7338         * filesystem.c: Revert.
7339         * filename-seen-cache.h: Revert.
7340         * filename-seen-cache.c: Revert.
7341         * fbsd-tdep.c: Revert.
7342         * fbsd-nat.h: Revert.
7343         * fbsd-nat.c: Revert.
7344         * f-valprint.c: Revert.
7345         * f-typeprint.c: Revert.
7346         * f-lang.c: Revert.
7347         * extension.h: Revert.
7348         * extension.c: Revert.
7349         * extension-priv.h: Revert.
7350         * expprint.c: Revert.
7351         * exec.h: Revert.
7352         * exec.c: Revert.
7353         * exceptions.c: Revert.
7354         * event-top.c: Revert.
7355         * event-loop.c: Revert.
7356         * eval.c: Revert.
7357         * elfread.c: Revert.
7358         * dwarf2read.h: Revert.
7359         * dwarf2read.c: Revert.
7360         * dwarf2loc.c: Revert.
7361         * dwarf2expr.h: Revert.
7362         * dwarf2expr.c: Revert.
7363         * dwarf2-frame.c: Revert.
7364         * dwarf2-frame-tailcall.c: Revert.
7365         * dwarf-index-write.h: Revert.
7366         * dwarf-index-write.c: Revert.
7367         * dwarf-index-common.c: Revert.
7368         * dwarf-index-cache.h: Revert.
7369         * dwarf-index-cache.c: Revert.
7370         * dummy-frame.c: Revert.
7371         * dtrace-probe.c: Revert.
7372         * disasm.h: Revert.
7373         * disasm.c: Revert.
7374         * disasm-selftests.c: Revert.
7375         * dictionary.c: Revert.
7376         * dicos-tdep.c: Revert.
7377         * demangle.c: Revert.
7378         * dcache.h: Revert.
7379         * dcache.c: Revert.
7380         * darwin-nat.h: Revert.
7381         * darwin-nat.c: Revert.
7382         * darwin-nat-info.c: Revert.
7383         * d-valprint.c: Revert.
7384         * d-namespace.c: Revert.
7385         * d-lang.c: Revert.
7386         * ctf.c: Revert.
7387         * csky-tdep.c: Revert.
7388         * csky-linux-tdep.c: Revert.
7389         * cris-tdep.c: Revert.
7390         * cris-linux-tdep.c: Revert.
7391         * cp-valprint.c: Revert.
7392         * cp-support.c: Revert.
7393         * cp-namespace.c: Revert.
7394         * cp-abi.c: Revert.
7395         * corelow.c: Revert.
7396         * corefile.c: Revert.
7397         * continuations.c: Revert.
7398         * completer.h: Revert.
7399         * completer.c: Revert.
7400         * complaints.c: Revert.
7401         * coffread.c: Revert.
7402         * coff-pe-read.c: Revert.
7403         * cli-out.h: Revert.
7404         * cli-out.c: Revert.
7405         * charset.c: Revert.
7406         * c-varobj.c: Revert.
7407         * c-valprint.c: Revert.
7408         * c-typeprint.c: Revert.
7409         * c-lang.c: Revert.
7410         * buildsym.c: Revert.
7411         * buildsym-legacy.c: Revert.
7412         * build-id.h: Revert.
7413         * build-id.c: Revert.
7414         * btrace.c: Revert.
7415         * bsd-uthread.c: Revert.
7416         * breakpoint.h: Revert.
7417         * breakpoint.c: Revert.
7418         * break-catch-throw.c: Revert.
7419         * break-catch-syscall.c: Revert.
7420         * break-catch-sig.c: Revert.
7421         * blockframe.c: Revert.
7422         * block.c: Revert.
7423         * bfin-tdep.c: Revert.
7424         * bfin-linux-tdep.c: Revert.
7425         * bfd-target.c: Revert.
7426         * bcache.c: Revert.
7427         * ax-general.c: Revert.
7428         * ax-gdb.h: Revert.
7429         * ax-gdb.c: Revert.
7430         * avr-tdep.c: Revert.
7431         * auxv.c: Revert.
7432         * auto-load.c: Revert.
7433         * arm-wince-tdep.c: Revert.
7434         * arm-tdep.c: Revert.
7435         * arm-symbian-tdep.c: Revert.
7436         * arm-pikeos-tdep.c: Revert.
7437         * arm-obsd-tdep.c: Revert.
7438         * arm-nbsd-tdep.c: Revert.
7439         * arm-nbsd-nat.c: Revert.
7440         * arm-linux-tdep.c: Revert.
7441         * arm-linux-nat.c: Revert.
7442         * arm-fbsd-tdep.c: Revert.
7443         * arm-fbsd-nat.c: Revert.
7444         * arm-bsd-tdep.c: Revert.
7445         * arch-utils.c: Revert.
7446         * arc-tdep.c: Revert.
7447         * arc-newlib-tdep.c: Revert.
7448         * annotate.h: Revert.
7449         * annotate.c: Revert.
7450         * amd64-windows-tdep.c: Revert.
7451         * amd64-windows-nat.c: Revert.
7452         * amd64-tdep.c: Revert.
7453         * amd64-sol2-tdep.c: Revert.
7454         * amd64-obsd-tdep.c: Revert.
7455         * amd64-obsd-nat.c: Revert.
7456         * amd64-nbsd-tdep.c: Revert.
7457         * amd64-nbsd-nat.c: Revert.
7458         * amd64-nat.c: Revert.
7459         * amd64-linux-tdep.c: Revert.
7460         * amd64-linux-nat.c: Revert.
7461         * amd64-fbsd-tdep.c: Revert.
7462         * amd64-fbsd-nat.c: Revert.
7463         * amd64-dicos-tdep.c: Revert.
7464         * amd64-darwin-tdep.c: Revert.
7465         * amd64-bsd-nat.c: Revert.
7466         * alpha-tdep.c: Revert.
7467         * alpha-obsd-tdep.c: Revert.
7468         * alpha-nbsd-tdep.c: Revert.
7469         * alpha-mdebug-tdep.c: Revert.
7470         * alpha-linux-tdep.c: Revert.
7471         * alpha-linux-nat.c: Revert.
7472         * alpha-bsd-tdep.c: Revert.
7473         * alpha-bsd-nat.c: Revert.
7474         * aix-thread.c: Revert.
7475         * agent.c: Revert.
7476         * addrmap.c: Revert.
7477         * ada-varobj.c: Revert.
7478         * ada-valprint.c: Revert.
7479         * ada-typeprint.c: Revert.
7480         * ada-tasks.c: Revert.
7481         * ada-lang.c: Revert.
7482         * aarch64-tdep.c: Revert.
7483         * aarch64-ravenscar-thread.c: Revert.
7484         * aarch64-newlib-tdep.c: Revert.
7485         * aarch64-linux-tdep.c: Revert.
7486         * aarch64-linux-nat.c: Revert.
7487         * aarch64-fbsd-tdep.c: Revert.
7488         * aarch64-fbsd-nat.c: Revert.
7489         * aarch32-linux-nat.c: Revert.
7490
7491 2019-04-05  Tom Tromey  <tom@tromey.com>
7492
7493         * ft32-tdep.c: Sort headers.
7494         * frv-tdep.c: Sort headers.
7495         * frv-linux-tdep.c: Sort headers.
7496         * frame.c: Sort headers.
7497         * frame-unwind.c: Sort headers.
7498         * frame-base.c: Sort headers.
7499         * fork-child.c: Sort headers.
7500         * findvar.c: Sort headers.
7501         * findcmd.c: Sort headers.
7502         * filesystem.c: Sort headers.
7503         * filename-seen-cache.h: Sort headers.
7504         * filename-seen-cache.c: Sort headers.
7505         * fbsd-tdep.c: Sort headers.
7506         * fbsd-nat.h: Sort headers.
7507         * fbsd-nat.c: Sort headers.
7508         * f-valprint.c: Sort headers.
7509         * f-typeprint.c: Sort headers.
7510         * f-lang.c: Sort headers.
7511         * extension.h: Sort headers.
7512         * extension.c: Sort headers.
7513         * extension-priv.h: Sort headers.
7514         * expprint.c: Sort headers.
7515         * exec.h: Sort headers.
7516         * exec.c: Sort headers.
7517         * exceptions.c: Sort headers.
7518         * event-top.c: Sort headers.
7519         * event-loop.c: Sort headers.
7520         * eval.c: Sort headers.
7521         * elfread.c: Sort headers.
7522         * dwarf2read.h: Sort headers.
7523         * dwarf2read.c: Sort headers.
7524         * dwarf2loc.c: Sort headers.
7525         * dwarf2expr.h: Sort headers.
7526         * dwarf2expr.c: Sort headers.
7527         * dwarf2-frame.c: Sort headers.
7528         * dwarf2-frame-tailcall.c: Sort headers.
7529         * dwarf-index-write.h: Sort headers.
7530         * dwarf-index-write.c: Sort headers.
7531         * dwarf-index-common.c: Sort headers.
7532         * dwarf-index-cache.h: Sort headers.
7533         * dwarf-index-cache.c: Sort headers.
7534         * dummy-frame.c: Sort headers.
7535         * dtrace-probe.c: Sort headers.
7536         * disasm.h: Sort headers.
7537         * disasm.c: Sort headers.
7538         * disasm-selftests.c: Sort headers.
7539         * dictionary.c: Sort headers.
7540         * dicos-tdep.c: Sort headers.
7541         * demangle.c: Sort headers.
7542         * dcache.h: Sort headers.
7543         * dcache.c: Sort headers.
7544         * darwin-nat.h: Sort headers.
7545         * darwin-nat.c: Sort headers.
7546         * darwin-nat-info.c: Sort headers.
7547         * d-valprint.c: Sort headers.
7548         * d-namespace.c: Sort headers.
7549         * d-lang.c: Sort headers.
7550         * ctf.c: Sort headers.
7551         * csky-tdep.c: Sort headers.
7552         * csky-linux-tdep.c: Sort headers.
7553         * cris-tdep.c: Sort headers.
7554         * cris-linux-tdep.c: Sort headers.
7555         * cp-valprint.c: Sort headers.
7556         * cp-support.c: Sort headers.
7557         * cp-namespace.c: Sort headers.
7558         * cp-abi.c: Sort headers.
7559         * corelow.c: Sort headers.
7560         * corefile.c: Sort headers.
7561         * continuations.c: Sort headers.
7562         * completer.h: Sort headers.
7563         * completer.c: Sort headers.
7564         * complaints.c: Sort headers.
7565         * coffread.c: Sort headers.
7566         * coff-pe-read.c: Sort headers.
7567         * cli-out.h: Sort headers.
7568         * cli-out.c: Sort headers.
7569         * charset.c: Sort headers.
7570         * c-varobj.c: Sort headers.
7571         * c-valprint.c: Sort headers.
7572         * c-typeprint.c: Sort headers.
7573         * c-lang.c: Sort headers.
7574         * buildsym.c: Sort headers.
7575         * buildsym-legacy.c: Sort headers.
7576         * build-id.h: Sort headers.
7577         * build-id.c: Sort headers.
7578         * btrace.c: Sort headers.
7579         * bsd-uthread.c: Sort headers.
7580         * breakpoint.h: Sort headers.
7581         * breakpoint.c: Sort headers.
7582         * break-catch-throw.c: Sort headers.
7583         * break-catch-syscall.c: Sort headers.
7584         * break-catch-sig.c: Sort headers.
7585         * blockframe.c: Sort headers.
7586         * block.c: Sort headers.
7587         * bfin-tdep.c: Sort headers.
7588         * bfin-linux-tdep.c: Sort headers.
7589         * bfd-target.c: Sort headers.
7590         * bcache.c: Sort headers.
7591         * ax-general.c: Sort headers.
7592         * ax-gdb.h: Sort headers.
7593         * ax-gdb.c: Sort headers.
7594         * avr-tdep.c: Sort headers.
7595         * auxv.c: Sort headers.
7596         * auto-load.c: Sort headers.
7597         * arm-wince-tdep.c: Sort headers.
7598         * arm-tdep.c: Sort headers.
7599         * arm-symbian-tdep.c: Sort headers.
7600         * arm-pikeos-tdep.c: Sort headers.
7601         * arm-obsd-tdep.c: Sort headers.
7602         * arm-nbsd-tdep.c: Sort headers.
7603         * arm-nbsd-nat.c: Sort headers.
7604         * arm-linux-tdep.c: Sort headers.
7605         * arm-linux-nat.c: Sort headers.
7606         * arm-fbsd-tdep.c: Sort headers.
7607         * arm-fbsd-nat.c: Sort headers.
7608         * arm-bsd-tdep.c: Sort headers.
7609         * arch-utils.c: Sort headers.
7610         * arc-tdep.c: Sort headers.
7611         * arc-newlib-tdep.c: Sort headers.
7612         * annotate.h: Sort headers.
7613         * annotate.c: Sort headers.
7614         * amd64-windows-tdep.c: Sort headers.
7615         * amd64-windows-nat.c: Sort headers.
7616         * amd64-tdep.c: Sort headers.
7617         * amd64-sol2-tdep.c: Sort headers.
7618         * amd64-obsd-tdep.c: Sort headers.
7619         * amd64-obsd-nat.c: Sort headers.
7620         * amd64-nbsd-tdep.c: Sort headers.
7621         * amd64-nbsd-nat.c: Sort headers.
7622         * amd64-nat.c: Sort headers.
7623         * amd64-linux-tdep.c: Sort headers.
7624         * amd64-linux-nat.c: Sort headers.
7625         * amd64-fbsd-tdep.c: Sort headers.
7626         * amd64-fbsd-nat.c: Sort headers.
7627         * amd64-dicos-tdep.c: Sort headers.
7628         * amd64-darwin-tdep.c: Sort headers.
7629         * amd64-bsd-nat.c: Sort headers.
7630         * alpha-tdep.c: Sort headers.
7631         * alpha-obsd-tdep.c: Sort headers.
7632         * alpha-nbsd-tdep.c: Sort headers.
7633         * alpha-mdebug-tdep.c: Sort headers.
7634         * alpha-linux-tdep.c: Sort headers.
7635         * alpha-linux-nat.c: Sort headers.
7636         * alpha-bsd-tdep.c: Sort headers.
7637         * alpha-bsd-nat.c: Sort headers.
7638         * aix-thread.c: Sort headers.
7639         * agent.c: Sort headers.
7640         * addrmap.c: Sort headers.
7641         * ada-varobj.c: Sort headers.
7642         * ada-valprint.c: Sort headers.
7643         * ada-typeprint.c: Sort headers.
7644         * ada-tasks.c: Sort headers.
7645         * ada-lang.c: Sort headers.
7646         * aarch64-tdep.c: Sort headers.
7647         * aarch64-ravenscar-thread.c: Sort headers.
7648         * aarch64-newlib-tdep.c: Sort headers.
7649         * aarch64-linux-tdep.c: Sort headers.
7650         * aarch64-linux-nat.c: Sort headers.
7651         * aarch64-fbsd-tdep.c: Sort headers.
7652         * aarch64-fbsd-nat.c: Sort headers.
7653         * aarch32-linux-nat.c: Sort headers.
7654
7655 2019-04-04  Tom Tromey  <tom@tromey.com>
7656
7657         * varobj.c (varobj_create): Update.
7658         * rust-exp.y (struct rust_parser) <update_innermost_block,
7659         lookup_symbol>: New methods.
7660         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7661         Rename.
7662         (rust_parser::rust_lookup_type)
7663         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7664         * printcmd.c (display_command, do_one_display): Update.
7665         * parser-defs.h (struct parser_state) <parser_state>: Add
7666         "tracker" parameter.
7667         (block_tracker): New member.
7668         (class innermost_block_tracker) <innermost_block_tracker>: Add
7669         "types" parameter.
7670         <reset>: Remove method.
7671         (innermost_block): Don't declare.
7672         (null_post_parser): Update.
7673         * parse.c (innermost_block): Remove global.
7674         (write_dollar_variable): Update.
7675         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7676         Remove "tracker_types" parameter.
7677         (parse_expression): Add "tracker" parameter.
7678         (parse_expression_for_completion): Update.
7679         (null_post_parser): Add "tracker" parameter.
7680         * p-exp.y: Update rules.
7681         * m2-exp.y: Update rules.
7682         * language.h (struct language_defn) <la_post_parser>: Add
7683         "tracker" parameter.
7684         * go-exp.y: Update rules.
7685         * f-exp.y: Update rules.
7686         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7687         parameter.
7688         * d-exp.y: Update rules.
7689         * c-exp.y: Update rules.
7690         * breakpoint.c (set_breakpoint_condition): Create an
7691         innermost_block_tracker.
7692         (watch_command_1): Likewise.
7693         * ada-lang.c (resolve): Add "tracker" parameter.
7694         (resolve_subexp): Likewise.
7695         * ada-exp.y (write_var_from_sym): Update.
7696
7697 2019-04-04  Tom Tromey  <tom@tromey.com>
7698
7699         * type-stack.h: New file.
7700         * type-stack.c: New file.
7701         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7702         type-stack.h.
7703         (insert_into_type_stack, insert_type, push_type, push_type_int)
7704         (insert_type_address_space, pop_type, pop_type_int)
7705         (pop_typelist, pop_type_stack, append_type_stack)
7706         (push_type_stack, get_type_stack, push_typelist)
7707         (follow_type_instance_flags, follow_types): Don't declare.
7708         * parse.c (type_stack): Remove global.
7709         (parse_exp_in_context): Update.
7710         (insert_into_type_stack, insert_type, push_type, push_type_int)
7711         (insert_type_address_space, pop_type, pop_type_int)
7712         (pop_typelist, pop_type_stack, append_type_stack)
7713         (push_type_stack, get_type_stack, push_typelist)
7714         (follow_type_instance_flags, follow_types): Remove (moved to
7715         type-stack.c).
7716         * f-exp.y (type_stack): New global.
7717         Update rules.
7718         (push_kind_type, f_parse): Update.
7719         * d-exp.y (type_stack): New global.
7720         Update rules.
7721         (d_parse): Update.
7722         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7723         Update rules.
7724         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7725         (HFILES_NO_SRCDIR): Add type-stack.h.
7726
7727 2019-04-04  Tom Tromey  <tom@tromey.com>
7728
7729         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7730         (rust_parser::convert_ast_to_expression, rust_parse)
7731         (rust_lex_test_completion, rust_lex_tests): Update.
7732         * parser-defs.h (struct expr_completion_state): New.
7733         (struct parser_state) <parser_state>: Add completion parameter.
7734         <mark_struct_expression, mark_completion_tag>: New methods.
7735         <parse_completion, m_completion_state>: New members.
7736         (prefixify_expression, null_post_parser): Update.
7737         (mark_struct_expression, mark_completion_tag): Don't declare.
7738         * parse.c (parse_completion, expout_last_struct)
7739         (expout_tag_completion_type, expout_completion_name): Remove
7740         globals.
7741         (parser_state::mark_struct_expression)
7742         (parser_state::mark_completion_tag): Now methods.
7743         (prefixify_expression): Add last_struct parameter.
7744         (prefixify_subexp): Likewise.
7745         (parse_exp_1): Update.
7746         (parse_exp_in_context): Add cstate parameter.  Update.
7747         (parse_expression_for_completion): Create an
7748         expr_completion_state.
7749         (null_post_parser): Add "completion" parameter.
7750         * p-exp.y: Update rules.
7751         (yylex): Update.
7752         * language.h (struct language_defn) <la_post_parser>: Add
7753         "completing" parameter.
7754         * go-exp.y: Update rules.
7755         (lex_one_token): Update.
7756         * expression.h (parse_completion): Don't declare.
7757         * d-exp.y: Update rules.
7758         (lex_one_token): Update rules.
7759         * c-exp.y: Update rules.
7760         (lex_one_token): Update.
7761         * ada-lang.c (resolve): Add "parse_completion" parameter.
7762         (resolve_subexp): Likewise.
7763         (ada_resolve_function): Likewise.
7764
7765 2019-04-04  Tom Tromey  <tom@tromey.com>
7766
7767         * parser-defs.h (struct parser_state) <start_arglist,
7768         end_arglist>: New methods.
7769         <arglist_len, m_funcall_chain>: New members.
7770         (arglist_len, start_arglist, end_arglist): Don't declare.
7771         * parse.c (arglist_len, funcall_chain): Remove global.
7772         (start_arglist, end_arglist): Remove functions.
7773         (parse_exp_in_context): Update.
7774         * p-exp.y: Update rules.
7775         * m2-exp.y: Update rules.
7776         * go-exp.y: Update rules.
7777         * f-exp.y: Update rules.
7778         * d-exp.y: Update rules.
7779         * c-exp.y: Update rules.
7780
7781 2019-04-04  Tom Tromey  <tom@tromey.com>
7782
7783         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7784         lex_operator, push_back>: New methods.
7785         Update all rules.
7786         (rust_parser::lex_hex, lex_escape): Rename and update.
7787         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7788         (rust_parser::lex_operator): Rename and update.
7789         (rust_parser::lex_number, rustyylex, rustyyerror)
7790         (rust_lex_test_init, rust_lex_test_sequence)
7791         (rust_lex_test_push_back, rust_lex_tests): Update.
7792         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7793         parameter.
7794         <lexptr, prev_lexptr>: New members.
7795         (lexptr, prev_lexptr): Don't declare.
7796         * parse.c (lexptr, prev_lexptr): Remove globals.
7797         (parse_exp_in_context): Update.
7798         * p-exp.y (yylex, yyerror): Update.
7799         * m2-exp.y (parse_number, yylex, yyerror): Update.
7800         * go-exp.y (lex_one_token, yyerror): Update.
7801         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7802         * d-exp.y (lex_one_token, yyerror): Update.
7803         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7804         (lex_one_token, yyerror): Update.
7805         * ada-lex.l (YY_INPUT): Update.
7806         (rewind_to_char): Update.
7807         * ada-exp.y (yyerror): Update.
7808
7809 2019-04-04  Tom Tromey  <tom@tromey.com>
7810
7811         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7812         * parser-defs.h (struct parser_state) <parser_state>: Add new
7813         parameter.
7814         <comma_terminates>: New member.
7815         (comma_terminates): Don't declare global.
7816         * parse.c (comma_terminates): Remove global.
7817         (parse_exp_in_context): Update.
7818         * p-exp.y (yylex): Update.
7819         * m2-exp.y (yylex): Update.
7820         * go-exp.y (lex_one_token): Update.
7821         * f-exp.y (yylex): Update.
7822         * d-exp.y (lex_one_token): Update.
7823         * c-exp.y (lex_one_token): Update.
7824         * ada-lex.l: Update.
7825
7826 2019-04-04  Tom Tromey  <tom@tromey.com>
7827
7828         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7829         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7830         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7831         * parser-defs.h (paren_depth): Don't declare.
7832         * parse.c (paren_depth): Remove global.
7833         (parse_exp_in_context): Update.
7834         * p-exp.y (paren_depth): New global.
7835         (pascal_parse): Initialize it.
7836         * m2-exp.y (paren_depth): New global.
7837         (m2_parse): Initialize it.
7838         * go-exp.y (paren_depth): New global.
7839         (go_parse): Initialize it.
7840         * f-exp.y (paren_depth): New global.
7841         (f_parse): Initialize it.
7842         * d-exp.y (paren_depth): New global.
7843         (d_parse): Initialize it.
7844         * c-exp.y (paren_depth): New global.
7845         (c_parse): Initialize it.
7846         * ada-lex.l (paren_depth): New global.
7847         (lexer_init): Initialize it.
7848
7849 2019-04-04  Tom Tromey  <tom@tromey.com>
7850
7851         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7852         (rust_parser::convert_ast_to_type)
7853         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7854         * parser-defs.h (struct parser_state) <parser_state>: Add
7855         parameters.  Initialize new members.
7856         <expression_context_block, expression_context_pc>: New members.
7857         * parse.c (expression_context_block, expression_context_pc):
7858         Remove globals.
7859         (parse_exp_in_context): Update.
7860         * p-exp.y: Update all rules.
7861         (yylex): Update.
7862         * m2-exp.y: Update all rules.
7863         (yylex): Update.
7864         * go-exp.y (yylex): Update.
7865         * f-exp.y (yylex): Update.
7866         * d-exp.y: Update all rules.
7867         (yylex): Update.
7868         * c-exp.y: Update all rules.
7869         (lex_one_token, classify_name, yylex, c_parse): Update.
7870         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7871
7872 2019-04-04  Tom Tromey  <tom@tromey.com>
7873
7874         * gdbarch.h, gdbarch.c: Rebuild.
7875         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7876         * stap-probe.h:
7877         (struct stap_parse_info): Replace "parser_state" with
7878         "expr_builder".
7879         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7880         (parser_state): New class.
7881         * parse.c (expr_builder): Rename.
7882         (expr_builder::release): Rename.
7883         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7884         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7885         (write_exp_elt_longcst, write_exp_elt_floatcst)
7886         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7887         (write_exp_string_vector, write_exp_bitstring)
7888         (write_exp_msymbol, mark_struct_expression)
7889         (write_dollar_variable)
7890         (insert_type_address_space, increase_expout_size): Replace
7891         "parser_state" with "expr_builder".
7892         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7893         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7894         "parser_state" with "expr_builder".
7895
7896 2019-04-04  Tom Tromey  <tom@tromey.com>
7897
7898         * rust-exp.y: Replace "parse_language" with method call.
7899         * p-exp.y:
7900         (yylex): Replace "parse_language" with method call.
7901         * m2-exp.y:
7902         (yylex): Replace "parse_language" with method call.
7903         * go-exp.y (classify_name): Replace "parse_language" with method
7904         call.
7905         * f-exp.y (yylex): Replace "parse_language" with method call.
7906         * d-exp.y (lex_one_token): Replace "parse_language" with method
7907         call.
7908         * c-exp.y:
7909         (lex_one_token, classify_name, yylex): Replace "parse_language"
7910         with method call.
7911         * ada-exp.y (find_primitive_type, type_char)
7912         (type_system_address): Replace "parse_language" with method call.
7913
7914 2019-04-04  Tom Tromey  <tom@tromey.com>
7915
7916         * rust-exp.y: Replace "parse_gdbarch" with method call.
7917         * parse.c (write_dollar_variable, insert_type_address_space):
7918         Replace "parse_gdbarch" with method call.
7919         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7920         call.
7921         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7922         call.
7923         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7924         "parse_gdbarch" with method call.
7925         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7926         with method call.
7927         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7928         "parse_gdbarch" with method call.
7929         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7930         "parse_gdbarch" with method call.
7931         * c-exp.y (parse_type, parse_number, classify_name): Replace
7932         "parse_gdbarch" with method call.
7933         * ada-lex.l: Replace "parse_gdbarch" with method call.
7934         * ada-exp.y (parse_type, find_primitive_type, type_char)
7935         (type_system_address): Replace "parse_gdbarch" with method call.
7936
7937 2019-04-04  Tom Tromey  <tom@tromey.com>
7938
7939         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7940         * stap-probe.c (stap_parse_argument): Update.
7941         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7942         initial_size parameter.
7943         * rust-exp.y (rust_lex_tests): Update.
7944         * parse.c (parser_state): Update.
7945         (parse_exp_in_context): Update.
7946         * parser-defs.h (struct parser_state) <parser_state>: Remove
7947         "initial_size" parameter.
7948
7949 2019-04-04  Tom Tromey  <tom@tromey.com>
7950
7951         * parser-defs.h (increase_expout_size): Don't declare.
7952         * parse.c (increase_expout_size): Now static.
7953
7954 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7955
7956         * gnu-nat.c (gnu_nat_target::wait): Fix
7957         target_waitstatus_to_string call.
7958
7959 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7960
7961         * eval.c (evaluate_subexp_standard): Handle internal functions
7962         during Fortran function call handling.
7963
7964 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7965
7966         * NEWS: Mention new internal functions.
7967         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7968         (read_base_type): Use dwarf2_init_complex_target_type.
7969         * value.c (creal_internal_fn): New function.
7970         (cimag_internal_fn): New function.
7971         (_initialize_values): Register new internal functions.
7972
7973 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7974
7975         * infrun.c (stop_all_threads): If debug_infrun, always
7976         trace the wait status after wait_one, using
7977         target_waitstatus_to_string and target_pid_to_str.
7978         (handle_inferior_event): Replace various trace of
7979         wait status kind by a single trace.
7980         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7981         wait status kind image by target_waitstatus_to_string.
7982         * target/waitstatus.c (target_waitstatus_to_string): Fix
7983         obsolete comment.
7984
7985 2019-04-01  Tom Tromey  <tromey@adacore.com>
7986
7987         PR symtab/23331:
7988         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7989
7990 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7991             Pedro Alves  <palves@redhat.com>
7992
7993         * top.c (quit_force): Call 'finalize_values'.
7994         * value.c (finalize_values): New function.
7995         * value.h (finalize_values): Declare.
7996
7997 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7998
7999         * NEWS: Announce $_gdb_major and $_gdb_minor.
8000
8001         * top.c (init_gdb_version_vars): New function.
8002         (gdb_init): Call init_gdb_version_vars.
8003
8004 2019-03-29  Tom Tromey  <tromey@adacore.com>
8005
8006         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8007         help text.  Remove dead code.
8008
8009 2019-03-29  Keith Seitz  <keiths@redhat.com>
8010
8011         From Siddhesh Poyarekar:
8012         * f-lang.h (f77_get_upperbound): Return LONGEST.
8013         (f77_get_lowerbound): Likewise.
8014         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8015         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8016         print them.
8017         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8018         plongest to format print it.
8019         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8020         (f77_get_upperbound): Likewise.
8021         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8022         LOWER_BOUND to LONGEST.
8023         (f77_create_arrayprint_offset_tbl): Likewise.
8024
8025 2019-03-29  Keith Seitz  <keiths@redhat.com>
8026
8027         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8028         %s/pulongest for TYPE_LENGTH instead of %d in format
8029         strings.
8030         * ada-typerint.c (ada_print_type): Likewise.
8031         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8032         * compile/compile-c-support.c (generate_register_struct): Likewise.
8033         * gdbtypes.c (recursive_dump_type): Likewise.
8034         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8035         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8036         instead of %d in format strings.
8037         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8038         to std::min to ULONGEST.
8039         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8040         instead of %d in format strings.
8041         * tracepoint.c (info_scope_command): Likewise.
8042         * typeprint.c (print_offset_data::update)
8043         (print_offset_data::finish): Likewise.
8044         * xtensa-tdep.c (xtensa_store_return_value)
8045         (xtensa_push_dummy_call): Likewise.
8046
8047 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8048
8049         * windows-nat.c (display_selector): Fixed format specifications
8050         for 64-bit Cygwin.
8051
8052 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8053
8054         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8055
8056 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8057
8058         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8059         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8060         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8061         (nios2_linux_init_abi): Install it.
8062
8063 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8064
8065         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8066
8067 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8068
8069         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8070
8071 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8072             Tom Tromey  <tromey@adacore.com>
8073
8074         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8075
8076 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8077
8078         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8079         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8080         method to compute the bounds of range types. Also print "[evaluated]"
8081         if the bounds' values come from a dynamic evaluation.
8082
8083 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8086         whitespace when pretty printing is on.
8087
8088 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8089
8090         * ppc-linux-nat.c: Add include.
8091
8092 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8093
8094         * NEWS: Mention AArch64 Pointer Authentication.
8095
8096 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8097
8098         * arm-linux-nat.c: Add include.
8099
8100 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8101
8102         * source-cache.c (source_cache::get_source_lines): Re-read
8103         fullname after calling open_source_file.
8104
8105 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8106
8107         * NEWS: Mention TLS support for FreeBSD.
8108
8109 2019-03-25  Tom Tromey  <tromey@adacore.com>
8110
8111         * minsyms.c (BUNCH_SIZE): Update comment.
8112         (~minimal_symbol_reader): Remove old comment.
8113         (compact_minimal_symbols): Update comment.
8114         (minimal_symbol_reader::install): Remove old comment.  Update
8115         other comments.
8116
8117 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8118
8119         * s390-linux-nat.c: Add include.
8120
8121 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8122
8123         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8124         Call linux_get_hwcap.
8125         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8126         Likewise.
8127         (aarch64_linux_get_hwcap): Remove function.
8128         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8129         declaration.
8130         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8131         linux_get_hwcap.
8132         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8133         * linux-tdep.c (linux_get_hwcap): Add function.
8134         (linux_get_hwcap2): Likewise.
8135         * linux-tdep.h (linux_get_hwcap): Add declaration.
8136         (linux_get_hwcap2): Likewise.
8137         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8138         (ppc_linux_get_hwcap2): Likewise.
8139         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8140         linux_get_hwcap.
8141         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8142         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8143         (ppc_linux_nat_target::read_description): Likewise.
8144         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8145         * s390-linux-nat.c: Likewise.
8146         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8147
8148 2019-03-24  Tom Tromey  <tom@tromey.com>
8149
8150         * ada-lang.c (standard_lookup): Simplify initialization.
8151         (ada_lookup_symbol_nonlocal): Simplify return.
8152         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8153         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8154         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8155         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8156         initialization.
8157         * solib.c (solib_global_lookup): Simplify.
8158         * symtab.c (null_block_symbol): Remove.
8159         (symbol_cache_lookup): Simplify returns.
8160         (lookup_language_this): Simplify returns.
8161         (lookup_symbol_aux): Simplify return.
8162         (lookup_local_symbol): Simplify returns.
8163         (lookup_global_symbol_from_objfile): Simplify return.
8164         (lookup_symbol_in_objfile_symtabs)
8165         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8166         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8167         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8168         * cp-namespace.c (cp_lookup_bare_symbol)
8169         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8170         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8171         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8172         (cp_lookup_symbol_via_imports): Simplify initialization.
8173         (find_symbol_in_baseclass): Likewise.
8174         * symtab.h (null_block_symbol): Remove.
8175         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8176         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8177         (d_lookup_symbol_module): Likewise.
8178         (find_symbol_in_baseclass): Simplify initialization.
8179
8180 2019-03-24  Tom Tromey  <tom@tromey.com>
8181
8182         * expression.h: Don't include symtab.h.
8183         (struct block): Forward declare.
8184
8185 2019-03-24  Tom Tromey  <tom@tromey.com>
8186
8187         * c-exp.y (typebase): Remove casts.
8188         * gdbtypes.c (lookup_unsigned_typename, )
8189         (lookup_signed_typename): Remove cast.
8190         * eval.c (parse_to_comma_and_eval): Remove cast.
8191         * parse.c (write_dollar_variable): Remove cast.
8192         * block.h (struct block) <superblock>: Now const.
8193         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8194         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8195         (map_block): Make "block" const.
8196         * symfile.h (struct quick_symbol_functions)
8197         <map_matching_symbols>: Constify block argument to "callback".
8198         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8199         const.
8200         (find_pc_sect_compunit_symtab): Make "b" const.
8201         (find_symbol_at_address): Likewise.
8202         (search_symbols): Likewise.
8203         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8204         (dw2_debug_names_lookup_symbol): Likewise.
8205         (dw2_map_matching_symbols): Update.
8206         * p-valprint.c (pascal_val_print): Remove "block".
8207         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8208         (aux_add_nonlocal_symbols): Make "block" const.
8209         (resolve_subexp): Remove cast.
8210         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8211         const.
8212         (iterate_over_file_blocks): Likewise.
8213         * f-exp.y (%union) <bval>: Remove.
8214         * coffread.c (patch_opaque_types): Make "b" const.
8215         * spu-tdep.c (spu_catch_start): Make "block" const.
8216         * c-valprint.c (print_unpacked_pointer): Remove "block".
8217         * symmisc.c (dump_symtab_1): Make "b" const.
8218         (block_depth): Make "block" const.
8219         * d-exp.y (%union) <bval>: Remove.
8220         * cp-support.h (cp_lookup_rtti_type): Update.
8221         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8222         * psymtab.c (psym_lookup_symbol): Make "block" const.
8223         (maintenance_check_psymtabs): Make "b" const.
8224         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8225         (enumerate_locals, enumerate_args): Update.
8226         * python/py-symtab.c (stpy_global_block): Make "block" const.
8227         (stpy_static_block): Likewise.
8228         * inline-frame.c (block_starting_point_at): Make "new_block"
8229         const.
8230         * block.c (find_block_in_blockvector): Make return type const.
8231         (blockvector_for_pc_sect): Make "b" const.
8232         (find_block_in_blockvector): Make "b" const.
8233
8234 2019-03-23  Tom Tromey  <tom@tromey.com>
8235
8236         * varobj.c (varobj_create): Update.
8237         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8238         * printcmd.c (display_command, do_one_display): Don't reset
8239         innermost_block.
8240         * parser-defs.h (enum innermost_block_tracker_type): Move to
8241         expression.h.
8242         (innermost_block): Update comment.
8243         * parse.c (parse_exp_1): Add tracker_types parameter.
8244         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8245         tracker_types parameter.  Reset innermost_block.
8246         (parse_exp_in_context): Remove.
8247         (parse_expression_for_completion): Update.
8248         * objfiles.c (~objfile): Don't reset expression_context_block or
8249         innermost_block.
8250         * expression.h (enum innermost_block_tracker_type): Move from
8251         parser-defs.h.
8252         (parse_exp_1): Add tracker_types parameter.
8253         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8254         reset innermost_block.
8255
8256 2019-03-23  Tom Tromey  <tom@tromey.com>
8257
8258         * objfiles.h: Include bcache.h.
8259
8260 2019-03-23  Tom Tromey  <tom@tromey.com>
8261
8262         * linespec.c (get_current_search_block): Use
8263         scoped_restore_current_language.
8264         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8265
8266 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8267             Jiong Wang  <jiong.wang@arm.com>
8268
8269         * aarch64-linux-tdep.c
8270         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8271         section.
8272         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8273
8274 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8275             Jiong Wang  <jiong.wang@arm.com>
8276
8277         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8278         instructions.
8279         (aarch64_analyze_prologue_test): Add PACIASP test.
8280         (aarch64_prologue_prev_register): Unmask PC value.
8281
8282 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8283             Jiong Wang  <jiong.wang@arm.com>
8284
8285         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8286         (aarch64_dwarf2_prev_register): Unmask PC value.
8287         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8288         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8289         DW_CFA_AARCH64_negate_ra_state.
8290         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8291
8292 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8293             Jiong Wang  <jiong.wang@arm.com>
8294
8295         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8296         registers.
8297         (aarch64_pseudo_register_name): Likewise.
8298         (aarch64_pseudo_register_type): Likewise.
8299         (aarch64_pseudo_register_reggroup_p): Likewise.
8300         (aarch64_gdbarch_init): Add pauth registers.
8301         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8302         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8303         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8304         (struct gdbarch_tdep): Add regnum for ra_state.
8305
8306 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8307             Jiong Wang  <jiong.wang@arm.com>
8308
8309         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8310
8311 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8312             Jiong Wang  <jiong.wang@arm.com>
8313
8314         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8315         function.
8316         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8317         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8318         (aarch64_gdbarch_init): Add puth registers.
8319         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8320         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8321         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8322
8323 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8324             Jiong Wang  <jiong.wang@arm.com>
8325
8326         * aarch64-linux-nat.c
8327         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8328         * aarch64-linux-tdep.c
8329         (aarch64_linux_core_read_description): Likewise.
8330         (aarch64_linux_get_hwcap): New function.
8331         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8332         (aarch64_linux_get_hwcap): New declaration.
8333
8334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8335             Jiong Wang  <jiong.wang@arm.com>
8336
8337         * aarch64-linux-nat.c
8338         (aarch64_linux_nat_target::read_description): Add pauth param.
8339         * aarch64-linux-tdep.c
8340         (aarch64_linux_core_read_description): Likewise.
8341         * aarch64-tdep.c (struct target_desc): Add in pauth.
8342         (aarch64_read_description): Add pauth param.
8343         (aarch64_gdbarch_init): Likewise.
8344         * aarch64-tdep.h (aarch64_read_description): Likewise.
8345         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8346         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8347         * features/Makefile: Add new files.
8348         * features/aarch64-pauth.c: New file.
8349         * features/aarch64-pauth.xml: New file.
8350
8351 2019-03-20  Tom Tromey  <tromey@adacore.com>
8352
8353         * infrun.c (handle_inferior_event): Rename from
8354         handle_inferior_event_1.  Create a scoped_value_mark.
8355         (handle_inferior_event): Remove.
8356
8357 2019-03-19  Tom Tromey  <tromey@adacore.com>
8358
8359         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8360         * infrun.h (print_stop_event): Add "displays" parameter.
8361         * infrun.c (print_stop_event): Add "displays" parameter.
8362
8363 2019-03-19  Pedro Alves  <palves@redhat.com>
8364
8365         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8366         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8367         to -1.  Fix TABs vs spaces.
8368         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8369         * tui/tui-out.h (tui_ui_out) Add intro comments.
8370         <m_line, m_start_of_line>: In-class initialize, and add describing
8371         comment.
8372
8373 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8374
8375         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8376         variable names.
8377         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8378
8379 2019-03-18  Pedro Alves  <palves@redhat.com>
8380             Eli Zaretskii <eliz@gnu.org>
8381
8382         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8383         m_line and m_start_of_line.
8384
8385 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8386
8387         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8388         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8389         it returns a newline.  This fixes a regression in TU mode, whereby
8390         the next line is output on the same screen line as the user input.
8391
8392 2019-03-18  Tom Tromey  <tromey@adacore.com>
8393
8394         * minsyms.c (minimal_symbol_reader::install): Remove call to
8395         obstack_blank.
8396
8397 2019-03-18  Pedro Alves  <palves@redhat.com>
8398
8399         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8400         New globals.
8401         (apply_style): New, factored out from ...
8402         (apply_ansi_escape): ... this.  Handle reverse video mode.
8403         (tui_set_reverse_mode): New function.
8404         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8405         * tui/tui-winsource.c (tui_show_source_line): Use
8406         tui_set_reverse_mode instead of setting A_STANDOUT.
8407         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8408         New setter methods.
8409
8410 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8411
8412         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8413         Handle tabs.
8414
8415 2019-03-18  Tom Tromey  <tromey@adacore.com>
8416
8417         * ada-lang.c (empty_array): Add "high" parameter.
8418         (ada_evaluate_subexp): Update.
8419
8420 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8421
8422         * unittests/string_view-selftests.c: Define
8423         _initialize_string_view_selftests unconditionally.
8424
8425 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8426
8427         PR gdb/24350
8428         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8429
8430 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8431
8432         PR gdb/24351
8433         * windows-nat.c (display_selector): Fix format specifiers.
8434
8435 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8436
8437         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8438         tui_refill_source_window instead of tui_refresh_win, to update the
8439         current execution line.  This fixes redisplay of the current line
8440         when stepping through the code with "next" or "step".
8441
8442 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8443
8444         * source-cache.c (source_cache::get_source_lines): Call
8445         find_source_lines to initialize s->nlines.  This fixes vertical
8446         scrolling of TUI source window when the DOWN arrow is pressed.
8447
8448 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8449
8450         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8451         linux-thread-db.c (_initialize_thread_db): Likewise.
8452
8453 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8454
8455         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8456         wclrtoeol in tui_show_source_line".  This reverts changes made in
8457         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8458
8459 2019-03-15  Tom Tromey  <tom@tromey.com>
8460
8461         * symtab.h (struct minimal_symbol): Derive from
8462         general_symbol_info.
8463         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8464         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8465         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8466         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8467         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8468         (MSYMBOL_SEARCH_NAME): Update.
8469         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8470         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8471         * minsyms.c (minimal_symbol_reader::record_full): Update.
8472
8473 2019-03-15  Tom Tromey  <tom@tromey.com>
8474
8475         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8476
8477 2019-03-15  Tom Tromey  <tom@tromey.com>
8478
8479         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8480         unique_xmalloc_ptr.
8481         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8482         Update.
8483         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8484         (build_minimal_symbol_hash_tables)
8485         (minimal_symbol_reader::install): Update.
8486
8487 2019-03-15  Tom Tromey  <tom@tromey.com>
8488
8489         * symtab.c (create_demangled_names_hash): Update.
8490         (symbol_set_names): Update.
8491         * objfiles.h (struct objfile_per_bfd_storage)
8492         <demangled_names_hash>: Now an htab_up.
8493         * objfiles.c (objfile_per_bfd_storage): Simplify.
8494
8495 2019-03-15  Tom Tromey  <tom@tromey.com>
8496
8497         * objfiles.h (struct objfile_per_bfd_storage): Declare
8498         destructor.
8499         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8500         New.
8501         (get_objfile_bfd_data): Use new.  Don't initialize
8502         language_of_main.
8503         (free_objfile_per_bfd_storage): Remove.
8504         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8505
8506 2019-03-15  Tom Tromey  <tom@tromey.com>
8507
8508         * symfile.c (reread_symbols): Update.
8509         * objfiles.c (objfile::objfile): Update.
8510         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8511         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8512         comment.
8513         (minimal_symbol_reader::install): Update.
8514         (terminate_minimal_symbol_table): Remove.
8515         * jit.c (jit_object_close_impl): Update.
8516
8517 2019-03-15  Tom Tromey  <tom@tromey.com>
8518
8519         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8520         initializations.
8521
8522 2019-03-15  Tom Tromey  <tom@tromey.com>
8523
8524         * objfiles.h (struct objfile_per_bfd_storage)
8525         <demangled_hash_languages>: Now a bitset.
8526         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8527         (lookup_minimal_symbol): Update.
8528
8529 2019-03-15  Tom Tromey  <tom@tromey.com>
8530
8531         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8532         Don't return the symbol.
8533         * coffread.c (record_minimal_symbol): Use record_full.
8534
8535 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8536
8537         The MS-Windows port of ncurses fails to switch to a color pair if
8538         one or both of the colors are the implicit default colors.  This
8539         change records the default colors when TUI is initialized, and
8540         then specifies them explicitly when a color pair uses the default
8541         colors.  This allows color styling in TUI mode on MS-Windows.
8542
8543         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8544         ncurses_norm_attr.
8545         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8546         colors in ncurses_norm_attr.
8547         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8548         "none", replace it with the default color recorded in
8549         ncurses_norm_attr.
8550
8551 2019-03-14  Tom Tromey  <tromey@adacore.com>
8552
8553         * source-cache.h (class source_cache) <get_source_lines>: Return
8554         std::string.
8555         * source-cache.c (source_cache::extract_lines): Handle case where
8556         first_pos==npos.  Return std::string.
8557         (source_cache::get_source_lines): Update.
8558
8559 2019-03-14  Tom Tromey  <tromey@adacore.com>
8560
8561         * NEWS: Add item for "style sources" commands.
8562         * source-cache.c (source_cache::get_source_lines): Check
8563         source_styling.
8564         * cli/cli-style.c (source_styling): New global.
8565         (_initialize_cli_style): Add "style sources" commands.
8566         (show_style_sources): New function.
8567         * cli/cli-style.h (source_styling): Declare.
8568
8569 2019-03-14  Pedro Alves  <palves@redhat.com>
8570             Tom Tromey  <tromey@adacore.com>
8571
8572         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8573         * tui/tui-winsource.c (tui_refill_source_window): New function,
8574         from...
8575         (tui_horizontal_source_scroll): ... here.  Move some logic.
8576         * cli/cli-style.c (set_style_enabled): Notify new observable.
8577         * tui/tui-hooks.c (tui_redisplay_source): New function.
8578         (tui_attach_detach_observers): Attach or detach
8579         tui_redisplay_source.
8580         * observable.h (source_styling_changed): New observable.
8581         * observable.c: Define source_styling_changed observable.
8582
8583 2019-03-13  Tom Tromey  <tromey@adacore.com>
8584
8585         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8586         (i386_gnu_nat_target::store_registers): Update.
8587         * target-debug.h (target_debug_print_std_string): New macro.
8588         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8589         * windows-tdep.c (display_one_tib): Update.
8590         * tui/tui-stack.c (tui_make_status_line): Update.
8591         * top.c (print_inferior_quit_action): Update.
8592         * thread.c (thr_try_catch_cmd): Update.
8593         (add_thread_with_info): Update.
8594         (thread_target_id_str): Update.
8595         (thr_try_catch_cmd): Update.
8596         (thread_command): Update.
8597         (thread_find_command): Update.
8598         * record-btrace.c (record_btrace_target::info_record)
8599         (record_btrace_resume_thread, record_btrace_target::resume)
8600         (record_btrace_cancel_resume, record_btrace_step_thread)
8601         (record_btrace_target::wait, record_btrace_target::wait)
8602         (record_btrace_target::wait, record_btrace_target::stop): Update.
8603         * progspace.c (print_program_space): Update.
8604         * process-stratum-target.c
8605         (process_stratum_target::thread_address_space): Update.
8606         * linux-fork.c (linux_fork_mourn_inferior)
8607         (detach_checkpoint_command, info_checkpoints_command)
8608         (linux_fork_context): Update.
8609         (linux_fork_detach): Update.
8610         (class scoped_switch_fork_info): Update.
8611         (delete_checkpoint_command): Update.
8612         * infrun.c (follow_fork_inferior): Update.
8613         (follow_fork_inferior): Update.
8614         (proceed_after_vfork_done): Update.
8615         (handle_vfork_child_exec_or_exit): Update.
8616         (follow_exec): Update.
8617         (displaced_step_prepare_throw): Update.
8618         (displaced_step_restore): Update.
8619         (start_step_over): Update.
8620         (resume_1): Update.
8621         (clear_proceed_status_thread): Update.
8622         (proceed): Update.
8623         (print_target_wait_results): Update.
8624         (do_target_wait): Update.
8625         (context_switch): Update.
8626         (stop_all_threads): Update.
8627         (restart_threads): Update.
8628         (finish_step_over): Update.
8629         (handle_signal_stop): Update.
8630         (switch_back_to_stepped_thread): Update.
8631         (keep_going_pass_signal): Update.
8632         (print_exited_reason): Update.
8633         (normal_stop): Update.
8634         * inferior.c (inferior_pid_to_str): Change return type.
8635         (print_selected_inferior): Update.
8636         (add_inferior): Update.
8637         (detach_inferior): Update.
8638         * dummy-frame.c (fprint_dummy_frames): Update.
8639         * dcache.c (dcache_info_1): Update.
8640         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8641         (btrace_fetch, btrace_clear): Update.
8642         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8643         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8644         type.
8645         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8646         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8647         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8648         * gdbarch.c, gdbarch.h: Rebuild.
8649         * gdbarch.sh (core_pid_to_str): Change return type.
8650         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8651         return type.
8652         (windows_nat_target::pid_to_str): Change return type.
8653         (windows_delete_thread): Update.
8654         (windows_nat_target::attach): Update.
8655         (windows_nat_target::files_info): Update.
8656         * target-delegates.c: Rebuild.
8657         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8658         return type.
8659         (sol_thread_target::pid_to_str): Change return type.
8660         * remote.c (class remote_target) <pid_to_str>: Change return
8661         type.
8662         (remote_target::pid_to_str): Change return type.
8663         (extended_remote_target::attach, remote_target::remote_stop_ns)
8664         (remote_target::remote_notif_remove_queued_reply)
8665         (remote_target::push_stop_reply, remote_target::disable_btrace):
8666         Update.
8667         (extended_remote_target::attach): Update.
8668         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8669         type.
8670         (gdbsim_target::pid_to_str): Change return type.
8671         * ravenscar-thread.c (struct ravenscar_thread_target)
8672         <pid_to_str>: Change return type.
8673         (ravenscar_thread_target::pid_to_str): Change return type.
8674         * procfs.c (class procfs_target) <pid_to_str>: Change return
8675         type.
8676         (procfs_target::pid_to_str): Change return type.
8677         (procfs_target::attach): Update.
8678         (procfs_target::detach): Update.
8679         (procfs_target::fetch_registers): Update.
8680         (procfs_target::store_registers): Update.
8681         (procfs_target::wait): Update.
8682         (procfs_target::files_info): Update.
8683         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8684         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8685         return type.
8686         (nto_procfs_target::pid_to_str): Change return type.
8687         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8688         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8689         return type.
8690         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8691         (exit_lwp): Update.
8692         (attach_proc_task_lwp_callback, get_detach_signal)
8693         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8694         (linux_nat_target::resume, wait_lwp, stop_callback)
8695         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8696         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8697         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8698         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8699         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8700         type.
8701         (inf_ptrace_target::attach): Update.
8702         (inf_ptrace_target::files_info): Update.
8703         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8704         type.
8705         (go32_nat_target::pid_to_str): Change return type.
8706         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8707         (gnu_nat_target::wait): Update.
8708         (gnu_nat_target::wait): Update.
8709         (gnu_nat_target::resume): Update.
8710         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8711         (fbsd_nat_target::wait): Update.
8712         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8713         type.
8714         (darwin_nat_target::attach): Update.
8715         * corelow.c (class core_target) <pid_to_str>: Change return type.
8716         (core_target::pid_to_str): Change return type.
8717         * target.c (normal_pid_to_str): Change return type.
8718         (default_pid_to_str): Likewise.
8719         (target_pid_to_str): Change return type.
8720         (target_translate_tls_address): Update.
8721         (target_announce_detach): Update.
8722         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8723         return type.
8724         (bsd_uthread_target::pid_to_str): Change return type.
8725         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8726         type.
8727         (bsd_kvm_target::pid_to_str): Change return type.
8728         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8729         return type.
8730         (aix_thread_target::pid_to_str): Change return type.
8731         * target.h (struct target_ops) <pid_to_str>: Change return type.
8732         (target_pid_to_str, normal_pid_to_str): Likewise.
8733         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8734         type.
8735         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8736         type.
8737         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8738         return type.
8739         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8740         type.
8741         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8742         type.
8743         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8744         return type.
8745
8746 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8747
8748         * NEWS: Mention that the new default MI version is 3.  Mention
8749         changes to the output of commands and events that deal with
8750         multi-location breakpoints.
8751         * breakpoint.c: Include "mi/mi-out.h".
8752         (print_one_breakpoint): Change output syntax if using MI version
8753         >= 3.
8754         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8755         New.
8756         (mi_multi_location_breakpoint_output_fixed): New.
8757         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8758         (mi_cmd_fix_multi_location_breakpoint_output): New.
8759         (mi_multi_location_breakpoint_output_fixed): New.
8760         * mi/mi-cmds.c (mi_cmds): Register command
8761         -fix-multi-location-breakpoint-output.
8762         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8763         interpreter "mi".
8764
8765 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8766
8767         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8768         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8769         instantiate mi_ui_out based on interpreter name.
8770         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8771         * mi/mi-main.c (mi_load_progress): Likewise.
8772
8773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8774
8775         * NEWS: Combine separate "New targets" sections for 8.3.
8776
8777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8778
8779         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8780         (ppcfbsd_init_abi): Install gdbarch
8781         "fetch_tls_load_module_address" and "get_thread_local_address"
8782         methods.
8783
8784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8785
8786         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8787         (riscv_fbsd_init_abi): Install gdbarch
8788         "fetch_tls_load_module_address" and "get_thread_local_address"
8789         methods.
8790
8791 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8792
8793         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8794         (i386fbsd_init_abi): Install gdbarch
8795         "fetch_tls_load_module_address" and "get_thread_local_address"
8796         methods.
8797
8798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8799
8800         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8801         (amd64fbsd_init_abi): Install gdbarch
8802         "fetch_tls_load_module_address" and "get_thread_local_address"
8803         methods.
8804
8805 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8806
8807         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8808         (struct fbsd_pspace_data): New type.
8809         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8810         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8811         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8812         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8813         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8814
8815 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8816
8817         * gdbtypes.c (lookup_struct_elt): New function.
8818         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8819         * gdbtypes.h (struct struct_elt): New type.
8820         (lookup_struct_elt): New prototype.
8821
8822 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8823
8824         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8825         remove disabled code block.
8826
8827 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8828
8829         * gdbarch.sh (get_thread_local_address): New method.
8830         * gdbarch.h, gdbarch.c: Regenerate.
8831         * target.c (target_translate_tls_address): Use
8832         gdbarch_get_thread_local_address if present instead of
8833         target::get_thread_local_address.
8834
8835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8836
8837         * target.h (target::get_thread_local_address): Update comment.
8838
8839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8840
8841         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8842         objfile->separate_debug_objfile_backlink if not NULL.
8843
8844 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8845
8846         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8847         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8848         (amd64bsd_store_inferior_registers): Likewise.
8849         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8850         Enable segment base registers.
8851         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8852         PT_GETFSBASE and PT_GETGSBASE.
8853         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8854         PT_SETGSBASE.
8855         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8856         segment base registers.
8857         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8858
8859 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8860
8861         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8862         Update calls to i386_target_description to add 'segments'
8863         parameter.
8864         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8865         add segment base registers.
8866         * arch/i386.c (i386_create_target_description): Add 'segments'
8867         parameter to enable segment base registers.
8868         * arch/i386.h (i386_create_target_description): Likewise.
8869         * features/i386/32bit-segments.xml: New file.
8870         * features/i386/32bit-segments.c: Generate.
8871         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8872         call to i386_target_description to add 'segments' parameter.
8873         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8874         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8875         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8876         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8877         if feature is present.
8878         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8879         Add 'segments' parameter to call to i386_target_description.
8880         (i386_target_description): Add 'segments' parameter to enable
8881         segment base registers.
8882         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8883         to call to i386_target_description.
8884         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8885         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8886         Define I386_NUM_REGS.
8887         (i386_target_description): Add 'segments' parameter to enable
8888         segment base registers.
8889
8890 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8891
8892         PR/24325
8893         * source-cache.c: #undef open and close, to avoid unresolved
8894         externals during linking.
8895
8896 2019-03-12  Tom Tromey  <tromey@adacore.com>
8897
8898         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8899         const.  Add initializers.
8900         (_initialize_remote): Don't initialize ptid globals.
8901
8902 2019-03-12  Pedro Alves  <palves@redhat.com>
8903
8904         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8905
8906 2019-03-12  Pedro Alves  <palves@redhat.com>
8907
8908         * cp-name-parser.y (main): Remove unused 'len' variable.
8909
8910 2019-03-12  Tom Tromey  <tromey@adacore.com>
8911
8912         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8913         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8914
8915 2019-03-12  Tom Tromey  <tromey@adacore.com>
8916
8917         * linux-nat.c (iterate_over_lwps): Update.
8918         (stop_callback): Remove parameter.
8919         (stop_wait_callback, detach_callback, resume_set_callback)
8920         (select_singlestep_lwp_callback, set_ignore_sigint)
8921         (status_callback, resumed_callback, resume_clear_callback)
8922         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8923         data parameter.
8924         (linux_nat_target::detach, linux_nat_target::resume)
8925         (linux_stop_and_wait_all_lwps, select_event_lwp)
8926         (linux_nat_filter_event, linux_nat_wait_1)
8927         (linux_nat_target::kill, linux_nat_target::stop)
8928         (linux_nat_target::stop): Update.
8929         (linux_nat_resume_callback): Change type.
8930         (resume_stopped_resumed_lwps, count_events_callback)
8931         (select_event_lwp_callback): Likewise.
8932         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8933         * arm-linux-nat.c (struct update_registers_data): Remove.
8934         (update_registers_callback): Change type.
8935         (arm_linux_insert_hw_breakpoint1): Update.
8936         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8937         parameter.
8938         (x86_linux_dr_set_addr): Update.
8939         (x86_linux_dr_set_control): Update.
8940         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8941         (iterate_over_lwps): Use gdb::function_view.
8942         * nat/aarch64-linux-hw-point.c (struct
8943         aarch64_dr_update_callback_param): Remove.
8944         (debug_reg_change_callback): Change type.
8945         (aarch64_notify_debug_reg_change): Update.
8946         * s390-linux-nat.c (s390_refresh_per_info): Update.
8947
8948 2019-03-11  Tom Tromey  <tromey@adacore.com>
8949
8950         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8951         redundant assignment to "this_cu".
8952
8953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8954
8955         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8956
8957 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8958
8959         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8960         from...
8961         (rank_one_type): ... this.
8962
8963 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8964
8965         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8966         from...
8967         (rank_one_type): ... this.
8968
8969 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8970
8971         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8972         from...
8973         (rank_one_type): ... this.
8974
8975 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8976
8977         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8978         from...
8979         (rank_one_type): ... this.
8980
8981 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8982
8983         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8984         from...
8985         (rank_one_type): ... this.
8986
8987 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8988
8989         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8990         from...
8991         (rank_one_type): ... this.
8992
8993 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8994
8995         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8996         from...
8997         (rank_one_type): ... this.
8998
8999 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9000
9001         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9002         from...
9003         (rank_one_type): ... this.
9004
9005 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9006
9007         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9008         from...
9009         (rank_one_type): ... this.
9010
9011 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9012
9013         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9014         from...
9015         (rank_one_type): ... this.
9016
9017 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9018
9019         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9020         from...
9021         (rank_one_type): ... this.
9022
9023 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9024
9025         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9026         from...
9027         (rank_one_type): ... this.
9028
9029 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9030
9031         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9032         inferior-events' shows the example events.
9033
9034 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9035
9036         Support styling on native MS-Windows console
9037
9038         PR/24315
9039         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9040         on MS-Windows if $TERM is not defined.
9041
9042         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9043
9044         * posix-hdep.c (gdb_console_fputs):
9045         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9046         functions.
9047         * ui-file.h (gdb_console_fputs): Add prototype.
9048
9049         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9050         back to fputs only if the former returns zero.
9051
9052 2019-03-07  Tom Tromey  <tom@tromey.com>
9053
9054         * symmisc.c (print_symbol_bcache_statistics): Update.
9055         (print_objfile_statistics): Update.
9056         * symfile.c (allocate_symtab): Update.
9057         * stabsread.c: Don't include bcache.h.
9058         * psymtab.h (struct psymbol_bcache): Don't declare.
9059         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9060         (psymbol_bcache_init, psymbol_bcache_free)
9061         (psymbol_bcache_get_bcache): Don't declare.
9062         * psymtab.c (struct psymbol_bcache): Remove.
9063         (psymtab_storage::psymtab_storage): Update.
9064         (psymtab_storage::~psymtab_storage): Update.
9065         (psymbol_bcache_init, psymbol_bcache_free)
9066         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9067         (add_psymbol_to_bcache): Update.
9068         (allocate_psymtab): Update.
9069         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9070         macro_cache>: No longer pointers.
9071         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9072         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9073         * macrotab.c (macro_bcache): Update.
9074         * macroexp.c: Don't include bcache.h.
9075         * gdbtypes.c (check_types_worklist): Update.
9076         (types_deeply_equal): Remove TRY/CATCH.  Update.
9077         * elfread.c (elf_symtab_read): Update.
9078         * dwarf2read.c: Don't include bcache.h.
9079         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9080         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9081         (print_bcache_statistics, bcache_memory_used): Don't declare.
9082         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9083         methods.  Rename all data members.
9084         * bcache.c (struct bcache): Move to bcache.h.
9085         (bcache::expand_hash_table): Rename from expand_hash_table.
9086         (bcache): Remove.
9087         (bcache::insert): Rename from bcache_full.
9088         (bcache::compare): Rename from bcache_compare.
9089         (bcache_xmalloc): Remove.
9090         (bcache::~bcache): Rename from bcache_xfree.
9091         (bcache::print_statistics): Rename from print_bcache_statistics.
9092         (bcache::memory_used): Rename from bcache_memory_used.
9093
9094 2019-03-07  Pedro Alves  <palves@redhat.com>
9095
9096         * infrun.c (normal_stop): Also check for
9097         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9098
9099 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9100
9101         * f-lang.c (value_from_host_double): Moved to...
9102         * value.c (value_from_host_double): ...here.
9103         * value.h (value_from_host_double): Declare.
9104         * guile/scm-math.c (vlscm_convert_typed_number): Use
9105         value_from_host_double.
9106         (vlscm_convert_number): Likewise.
9107         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9108         * python/py-value.c (convert_value_from_python): Likewise.
9109
9110 2019-03-06  Tom Tromey  <tom@tromey.com>
9111
9112         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9113
9114 2019-03-06  Tom Tromey  <tom@tromey.com>
9115
9116         * utils.h (free_current_contents): Don't declare.
9117         * utils.c (free_current_contents): Remove.
9118
9119 2019-03-06  Tom Tromey  <tom@tromey.com>
9120
9121         * top.c (quit_force): Update.
9122         * main.c (captured_command_loop): Update.
9123         * common/new-op.c (operator new): Update.
9124         * common/common-exceptions.c (struct catcher)
9125         <save_cleanup_chain>: Remove member.
9126         (exceptions_state_mc_init): Update.
9127         (exception_try_scope_entry): Return nullptr.
9128         (exception_try_scope_exit, exception_rethrow)
9129         (throw_exception_sjlj, throw_exception_cxx): Update.
9130         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9131         (all_cleanups, do_cleanups, discard_cleanups)
9132         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9133         (restore_cleanups, restore_final_cleanups): Don't declare.
9134         (do_final_cleanups): Remove parameter.
9135         * common/cleanups.c (cleanup_chain, make_cleanup)
9136         (make_cleanup_dtor, all_cleanups, do_cleanups)
9137         (discard_my_cleanups, discard_cleanups)
9138         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9139         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9140         (null_cleanup): Remove.
9141         (do_final_cleanups): Remove parameter.
9142
9143 2019-03-06  Tom Tromey  <tom@tromey.com>
9144
9145         * remote.c (remote_target::remote_parse_stop_reply): Use
9146         unique_xmalloc_ptr.
9147
9148 2019-03-06  Tom Tromey  <tom@tromey.com>
9149
9150         * stabsread.c (struct stabs_field_info): Rename from field_info.
9151         <list, fnlist>: Add initializers.
9152         <obstack>: New member.
9153         (read_member_functions, read_struct_fields, read_baseclasses):
9154         Allocate on obstack.  Don't use cleanups.
9155         (read_one_struct_field, read_member_functions, read_struct_fields)
9156         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9157         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9158         (read_struct_type): Update.
9159
9160 2019-03-06  Tom Tromey  <tom@tromey.com>
9161
9162         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9163         * common/filestuff.h (make_cleanup_close): Don't declare.
9164         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9165         Remove.
9166
9167 2019-03-06  Tom Tromey  <tom@tromey.com>
9168
9169         * solib-aix.c: Use make_scope_exit.
9170
9171 2019-03-06  Tom Tromey  <tom@tromey.com>
9172
9173         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9174         Use make_scope_exit.
9175
9176 2019-03-06  Tom Tromey  <tom@tromey.com>
9177
9178         * solib-svr4.c (disable_probes_interface): Remove parameter.
9179         (svr4_handle_solib_event): Use make_scope_exit.
9180
9181 2019-03-06  Tom Tromey  <tom@tromey.com>
9182
9183         * remote.c (struct stop_reply_deleter): Remove.
9184         (stop_reply_up): Update.
9185         (struct stop_reply): Derive from notif_event.  Don't typedef.
9186         <regcache>: Now a std::vector.
9187         (stop_reply_xfree): Remove.
9188         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9189         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9190         (remote_target::discard_pending_stop_replies): Use delete.
9191         (remote_target::remote_parse_stop_reply): Update.
9192         (remote_target::process_stop_reply): Update.
9193         * remote-notif.h (struct notif_event): Add virtual destructor.
9194         Remove "dtr" member.
9195         (struct notif_client) <alloc_event>: Return a unique_ptr.
9196         (notif_event_xfree): Don't declare.
9197         (notif_event_up): New typedef.
9198         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9199         (notif_event_xfree, do_notif_event_xfree): Remove.
9200         (remote_notif_state_xfree): Update.
9201
9202 2019-03-06  Tom Tromey  <tom@tromey.com>
9203
9204         * infrun.c (displaced_step_clear_cleanup): Now a
9205         forward_scope_exit type.
9206         (displaced_step_prepare_throw): Update.
9207         (displaced_step_fixup): Update.
9208
9209 2019-03-06  Tom Tromey  <tom@tromey.com>
9210
9211         * inferior.h (class inferior): Update comment.
9212         * gdbthread.h (class thread_info): Update comment.
9213
9214 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9215             Tom Tromey  <tom@tromey.com>
9216
9217         * stabsread.h (struct stab_section_list): Remove.
9218         (coffstab_build_psymtabs): Update.
9219         * dbxread.c (symbuf_sections): Now a std::vector.
9220         (sect_idx): New global.
9221         (fill_symbuf): Update.
9222         (coffstab_build_psymtabs): Change type of stabsects parameter.
9223         Update.
9224         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9225         std::vector.
9226         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9227         (coff_locate_sections): Update.
9228         (coff_symfile_read): Remove cleanups.  Update.
9229         (init_stringtab): Add storage parameter.
9230         (free_stringtab, free_stringtab_cleanup): Remove.
9231         (init_lineno): Add storage parameter.
9232         (free_linetab, free_linetab_cleanup): Remove.
9233
9234 2019-03-06  Pedro Alves  <palves@redhat.com>
9235
9236         * linux-fork.c (fork_info::clobber_regs): Delete.
9237         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9238         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9239         comment.  Adjust.
9240         (scoped_switch_fork_info::scoped_switch_fork_info)
9241         (checkpoint_command, linux_fork_context): Adjust
9242         fork_save_infrun_state calls.
9243
9244 2019-03-06  Pedro Alves  <palves@redhat.com>
9245
9246         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9247         (inf_has_multiple_threads): Return 'bool' and rewrite using
9248         inferior_info::threads().
9249
9250 2019-03-06  Pedro Alves  <palves@redhat.com>
9251
9252         * linux-fork.c: Include <list>.
9253         (fork_list): Now a std::list instance.
9254         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9255         (forks_exist_p, find_last_fork): Adjust.
9256         (new_fork): Delete.
9257         (one_fork_p): New.
9258         (add_fork): Adjust.
9259         (free_fork): Delete, folded into fork_info::~fork_info().
9260         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9261         Adjust.
9262         (init_fork_list): Delete.
9263         (linux_fork_killall, linux_fork_mourn_inferior)
9264         (linux_fork_detach, info_checkpoints_command): Adjust.
9265         (_initialize_linux_fork): No longer call init_fork_list.
9266
9267 2019-03-06  Pedro Alves  <palves@redhat.com>
9268
9269         * linux-fork.c (new_fork): New, split out of ...
9270         (add_fork): ... this.  Return void.  Move "first fork" special
9271         case from here, to ...
9272         (checkpoint_command): ... here.
9273         * linux-linux.h (add_fork): Return void.
9274
9275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9276
9277         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9278
9279 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9280             Chris January  <chris.january@arm.com>
9281             David Lecomber  <david.lecomber@arm.com>
9282
9283         * f-exp.y: New token, UNOP_INTRINSIC.
9284         (exp): New pattern using UNOP_INTRINSIC token.
9285         (f77_keywords): Add 'abs' keyword.
9286         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9287         (value_from_host_double): New function.
9288         (evaluate_subexp_f): Support UNOP_ABS.
9289
9290 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9291
9292         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9293         types.
9294
9295 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9296
9297         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9298         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9299         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9300
9301 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9302
9303         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9304
9305 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9306             Chris January  <chris.january@arm.com>
9307
9308         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9309         * f-exp.y: Define 'KIND' token.
9310         (exp): New pattern for KIND expressions.
9311         (ptype): Handle types with a kind extension.
9312         (direct_abs_decl): Extend to spot kind extensions.
9313         (f77_keywords): Add 'kind' to the list.
9314         (push_kind_type): New function.
9315         (convert_to_kind_type): New function.
9316         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9317         * parse.c (operator_length_standard): Likewise.
9318         * parser-defs.h (enum type_pieces): Add tp_kind.
9319         * std-operator.def: Add UNOP_KIND.
9320
9321 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * f-exp.y (f_parse): Set yydebug.
9324
9325 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9326
9327         * f-lang.c (evaluate_subexp_f): New function.
9328         (exp_descriptor_f): New global.
9329         (f_language_defn): Use exp_descriptor_f instead of
9330         exp_descriptor_standard.
9331
9332 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9333
9334         * f-exp.y (struct token): Add comments.
9335         (dot_ops): Remove uppercase versions and the end marker.
9336         (f77_keywords): Likewise.
9337         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9338         entries in the dot_ops array are case insensitive, and use
9339         strncasecmp to compare strings.  Also some whitespace cleanup in
9340         this area.  Similar for the f77_keywords array, except entries in
9341         this list might be case sensitive.
9342
9343 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9344
9345         * f-exp.y (struct f77_boolean_val): Add comments.
9346         (boolean_values): Remove uppercase versions, and end marker.
9347         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9348         and use strncasecmp to achieve case insensitivity.  Additionally,
9349         perform whitespace cleanup around this code.
9350
9351 2019-03-06  Tom Tromey  <tromey@adacore.com>
9352
9353         * remote-sim.c (gdbsim_target_open): Use result of
9354         gdb_argv::release.
9355
9356 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9357         Dirk Schubert  <dirk.schubert@arm.com>
9358         Chris January  <chris.january@arm.com>
9359
9360         * eval.c (evaluate_subexp_standard): Call Fortran argument
9361         wrapping logic.
9362         * f-lang.c (struct value): A value which can be passed into a
9363         Fortran function call.
9364         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9365         where appropriate.
9366         (struct type): Value ready for a Fortran function call.
9367         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9368         is needed.
9369         * f-lang.h (fortran_argument_convert): Declaration.
9370         (fortran_preserve_arg_pointer): Declaration.
9371         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9372
9373 2019-03-05  Tom Tromey  <tromey@adacore.com>
9374
9375         * python/py-prettyprint.c (print_string_repr): Remove #if.
9376         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9377
9378 2019-03-05  Tom Tromey  <tromey@adacore.com>
9379
9380         * target.c (the_dummy_target): Move later.  Change type to
9381         "dummy_target".
9382         (initialize_targets): Don't initialize the_dummy_target.
9383
9384 2019-03-05  Tom Tromey  <tromey@adacore.com>
9385
9386         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9387         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9388
9389 2019-03-05  Tom Tromey  <tromey@adacore.com>
9390
9391         * windows-nat.c (windows_nat_target::attach)
9392         (windows_nat_target::detach): Don't call gdb_flush.
9393         * valprint.c (generic_val_print, val_print, val_print_string):
9394         Don't call gdb_flush.
9395         * utils.c (defaulted_query): Don't call gdb_flush.
9396         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9397         * target.c (target_announce_detach): Don't call gdb_flush.
9398         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9399         * remote.c (extended_remote_target::attach): Don't call
9400         gdb_flush.
9401         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9402         * printcmd.c (do_examine): Don't call gdb_flush.
9403         (info_display_command): Don't call gdb_flush.
9404         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9405         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9406         * memattr.c (info_mem_command): Don't call gdb_flush.
9407         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9408         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9409         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9410         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9411         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9412         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9413         (gnu_nat_target::detach): Don't call gdb_flush.
9414         * f-valprint.c (f_val_print): Don't call gdb_flush.
9415         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9416         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9417         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9418         gdb_flush.
9419         * c-valprint.c (c_val_print): Don't call gdb_flush.
9420         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9421
9422 2019-03-05  Tom Tromey  <tromey@adacore.com>
9423
9424         * varobj.c (update_dynamic_varobj_children): Update.
9425         (install_default_visualizer): Use reset, not release.
9426         * value.c (set_internalvar): Update.
9427         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9428         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9429         ATTRIBUTE_UNUSED_RESULT.
9430
9431 2019-03-05  Tom Tromey  <tromey@adacore.com>
9432
9433         * remote.c (class scoped_remote_fd) <release>: Add
9434         ATTRIBUTE_UNUSED_RESULT.
9435
9436 2019-03-05  Tom Tromey  <tromey@adacore.com>
9437
9438         * macroexp.c (struct macro_buffer) <release>: Add
9439         ATTRIBUTE_UNUSED_RESULT.
9440
9441 2019-03-05  Tom Tromey  <tromey@adacore.com>
9442
9443         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9444         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9445         ATTRIBUTE_UNUSED_RESULT.
9446
9447 2019-03-05  Tom Tromey  <tromey@adacore.com>
9448
9449         * common/scoped_fd.h (class scoped_fd) <release>: Add
9450         ATTRIBUTE_UNUSED_RESULT.
9451
9452 2019-03-05  Tom Tromey  <tromey@adacore.com>
9453
9454         * parser-defs.h (struct parser_state) <release>: Add
9455         ATTRIBUTE_UNUSED_RESULT.
9456
9457 2019-03-05  Tom Tromey  <tromey@adacore.com>
9458
9459         * utils.h (class gdb_argv) <release>: Add
9460         ATTRIBUTE_UNUSED_RESULT.
9461         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9462
9463 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9464
9465         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9466         for-loop range, to avoid compiler warnings.
9467
9468         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9469         avoid compiler warnings about unused variables.
9470
9471         * NEWS: Mention end of support for native debugging on MS-Windows
9472         before XP.
9473
9474         PR gdb/24292
9475         * common/netstuff.c:
9476         * gdbserver/gdbreplay.c
9477         * gdbserver/remote-utils.c:
9478         * ser-tcp.c:
9479         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9480         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9481         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9482         'getaddrinfo' and 'freeaddrinfo' were not available before
9483         Windows XP, and mingw.org's MinGW headers by default define
9484         _WIN32_WINNT to 0x500.
9485
9486 2019-03-01  Gary Benson <gbenson@redhat.com>
9487
9488         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9489
9490 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9491             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9492
9493         PR gdb/8527
9494         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9495         set_sigint_trap, clear_sigint_trap.
9496
9497 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9498
9499         * target.c (target_detach): Clear the regcache and the
9500         frame cache.
9501
9502 2019-02-27  Pedro Alves  <palves@redhat.com>
9503
9504         * utils.c (set_screen_size): When we cap the height/width sizes,
9505         tweak the corresponding command variable to show "unlimited":
9506
9507 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9508             Pedro Alves  <palves@redhat.com>
9509
9510         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9511         before calling rl_set_screen_size.
9512
9513 2019-02-27  Tom Tromey  <tromey@adacore.com>
9514
9515         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9516         define.
9517         * python/py-value.c: Remove Python 2.4 workaround.
9518         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9519         workaround.
9520         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9521         Python 2.4 workaround.
9522         * python/python-internal.h: Remove Python 2.4 comment.
9523         (Py_ssize_t): Don't define.
9524         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9525         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9526         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9527         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9528         * python/python.c (do_start_initialization): Remove Python 2.4
9529         workaround.
9530         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9531         (print_children): Remove Python 2.4 workaround.
9532         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9533         workaround.
9534         (CHARBUFFERPROC_NAME): Remove.
9535         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9536         Python 2.4 workaround.
9537
9538 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9539
9540         * NEWS: Note minimum Python version.
9541
9542 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9543
9544         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9545         code from these functions.  Remove corresponding ifdefs.  Use
9546         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9547         Remove gotos and target of gotos.
9548         (infpy_search_memory): Likewise.
9549
9550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9551
9552         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9553         (hppa_gdbarch_init): Don't register deleted functions with
9554         gdbarch.
9555
9556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9557
9558         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9559         (h8300_unwind_sp): Delete.
9560         (h8300_dummy_id): Delete.
9561         (h8300_gdbarch_init): Don't register deleted functions with
9562         gdbarch.
9563
9564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9565
9566         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9567         (ft32_unwind_pc): Delete.
9568         (ft32_unwind_sp): Delete.
9569         (ft32_gdbarch_init): Don't register deleted functions with
9570         gdbarch.
9571
9572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9573
9574         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9575         (frv_unwind_pc): Delete.
9576         (frv_unwind_sp): Delete.
9577         (frv_gdbarch_init): Don't register deleted functions with
9578         gdbarch.
9579
9580 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9581
9582         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9583         (riscv_unwind_pc): Delete.
9584         (riscv_unwind_sp): Delete.
9585         (riscv_gdbarch_init): Don't register deleted functions with
9586         gdbarch.
9587
9588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9589
9590         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9591         (csky_unwind_pc): Delete.
9592         (csky_unwind_sp): Delete.
9593         (csky_gdbarch_init): Don't register deleted functions with
9594         gdbarch.
9595
9596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9597
9598         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9599         (cris_unwind_pc): Delete.
9600         (cris_unwind_sp): Delete.
9601         (cris_gdbarch_init): Don't register deleted functions with
9602         gdbarch.
9603
9604 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9605
9606         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9607         (bfin_unwind_pc): Delete.
9608         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9609
9610 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9611
9612         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9613         (arm_unwind_pc): Delete.
9614         (arm_unwind_sp): Delete.
9615         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9616
9617 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9618
9619         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9620         (arc_unwind_pc): Delete.
9621         (arc_unwind_sp): Delete.
9622         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9623
9624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9625
9626         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9627         (alpha_unwind_pc): Delete.
9628         (alpha_gdbarch_init): Don't register deleted functions with
9629         gdbarch.
9630
9631 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9632
9633         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9634         (aarch64_unwind_pc): Delete.
9635         (aarch64_unwind_sp): Delete.
9636         (aarch64_gdbarch_init): Don't register deleted functions with
9637         gdbarch.
9638
9639 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9640
9641         * gdbtypes.c (type_align): Don't consider static members when
9642         computing structure alignment.
9643
9644 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9645
9646         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9647         return 0 for other types.
9648         * arch-utils.c (default_type_align): Always return 0.
9649         * gdbarch.h: Regenerate.
9650         * gdbarch.sh (type_align): Extend comment.
9651         * gdbtypes.c (type_align): Add additional comments, always call
9652         gdbarch_type_align before applying the default rules.
9653         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9654         generic code will then apply a suitable default.
9655         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9656         types, return 0 for other types.
9657
9658 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9659
9660         * NEWS: Create a new section for the next release branch.
9661         Rename the section of the current branch, now that it has
9662         been cut.
9663
9664 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9665
9666         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9667         * version.in: Bump version to 8.3.50.DATE-git.
9668
9669 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9670
9671         * aix-thread.c (ptid_cmp): Remove unused variable.
9672         (get_signaled_thread): Likewise.
9673         (store_regs_user_thread): Likewise.
9674         (store_regs_kernel_thread): Likewise.
9675         (fetch_regs_kernel_thread): Remove shadowed variable.
9676
9677 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9678
9679         * features/riscv/32bit-cpu.xml: Add register numbers.
9680         * features/riscv/32bit-fpu.c: Regenerate.
9681         * features/riscv/32bit-fpu.xml: Add register numbers.
9682         * features/riscv/64bit-cpu.xml: Add register numbers.
9683         * features/riscv/64bit-fpu.c: Regenerate.
9684         * features/riscv/64bit-fpu.xml: Add register numbers.
9685
9686 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9687
9688         * NEWS: Mention two argument form of gdb.Value constructor.
9689         * python/py-value.c (convert_buffer_and_type_to_value): New
9690         function.
9691         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9692         Add support for handling an optional second argument.  Call
9693         convert_buffer_and_type_to_value as appropriate.
9694         * python/python-internal.h (Py_buffer_deleter): New struct.
9695         (Py_buffer_up): New typedef.
9696
9697 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9698
9699         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9700         instead of releasing ownership.
9701
9702 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9703
9704         * dwarf2read.c (open_and_init_dwp_file): Call
9705         elf_numsections instead of bfd_count_sections to initialize
9706         dwp_file->num_sections.
9707
9708 2019-02-25  Tom Tromey  <tromey@adacore.com>
9709
9710         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9711
9712 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9713
9714         * gcore.in: Add '--readnever' option when invoking GDB.
9715
9716 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9717
9718         * MAINTAINERS: Update my email address.
9719
9720 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9721
9722         * build-id.c (build_id_to_debug_bfd_1): New function.
9723         (build_id_to_debug_bfd): Look for separate debug file in
9724         sysroot.
9725
9726 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9727
9728         * gdbarch.sh: Update the copyright year range that is placed into
9729         generated files.
9730
9731 2019-02-22  Keith Seitz  <keiths@redhat.com>
9732
9733         PR symtab/23853
9734         * linespec.c (create_sals_line_offset): Search for the default
9735         symtab's filename instead of its fullname.
9736
9737 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9738
9739         * NEWS: Update style defaults.
9740
9741 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9742
9743         * main.c (captured_main_1): Disable styling in batch mode.
9744
9745 2019-02-20  Tom Tromey  <tom@tromey.com>
9746
9747         * symtab.c (symtab_symbol_info): Fix typos.
9748
9749 2019-02-20  Tom Tromey  <tromey@adacore.com>
9750
9751         * findcmd.c (_initialize_mem_search): Use upper case for
9752         metasyntactic variables.
9753
9754 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9755
9756         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9757         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9758
9759 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9760
9761         * top.h (source_file_name): Change to std::string.
9762         * top.c (source_file_name): Likewise.
9763         (command_line_input): Adjust.
9764         * cli/cli-script.c (script_from_file): Adjust.
9765
9766 2019-02-19  Tom Tromey  <tromey@adacore.com>
9767
9768         * ravenscar-thread.c
9769         (ravenscar_thread_target::update_thread_list): Don't call
9770         ada_build_task_list.
9771         * ada-lang.h (ada_build_task_list): Don't declare.
9772         * ada-tasks.c (struct ada_tasks_inferior_data)
9773         <task_list_valid_p>: Now bool.
9774         (read_known_tasks, ada_task_list_changed)
9775         (ada_tasks_invalidate_inferior_data): Update.
9776         (read_known_tasks_array): Return bool.
9777         (read_known_tasks_list): Likewise.
9778         (read_known_tasks): Return void.
9779         (ada_build_task_list): Now static.
9780
9781 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9782
9783         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9784         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9785
9786 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9787
9788         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9789         variant for ada_tasks_pspace_data_handle and
9790         ada_tasks_inferior_data_handle.
9791         (ada_tasks_pspace_data_cleanup): New function.
9792         (ada_tasks_inferior_data_cleanup): New function.
9793
9794 2019-02-17  Tom Tromey  <tom@tromey.com>
9795
9796         * macrotab.h (macro_source_fullname): Return a std::string.
9797         * macrotab.c (macro_include, check_for_redefinition)
9798         (macro_undef, macro_lookup_definition, foreach_macro)
9799         (foreach_macro_in_scope): Update.
9800         (macro_source_fullname): Return a std::string.
9801         * macrocmd.c (show_pp_source_pos): Update.
9802
9803 2019-02-17  Tom Tromey  <tom@tromey.com>
9804
9805         * macrocmd.c (show_pp_source_pos): Style the file names.
9806
9807 2019-02-17  Tom Tromey  <tom@tromey.com>
9808
9809         PR tui/24197:
9810         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9811
9812 2019-02-17  Tom Tromey  <tom@tromey.com>
9813
9814         * ada-lang.c (user_select_syms): Use filtered printing.
9815         * utils.c (wrap_style): New global.
9816         (desired_style): Remove.
9817         (emit_style_escape): Add stream parameter.
9818         (set_output_style, reset_terminal_style, prompt_for_continue):
9819         Update.
9820         (flush_wrap_buffer): Only flush gdb_stdout.
9821         (wrap_here): Set wrap_style.
9822         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9823         treat escape sequences as a character.  Change when wrap buffer is
9824         flushed.
9825         (fputs_styled): Do not set the output style when the default is
9826         requested.
9827         * ui-style.h (struct ui_file_style) <is_default>: New method.
9828         * source.c (print_source_lines_base): Emit escape sequences in one
9829         piece.
9830
9831 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9832
9833         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9834         integers and enumeration types.
9835
9836 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9837
9838         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9839         instead of lookup_symbol_in_language
9840         (do_exact_match): New function.
9841         (ada_get_symbol_name_matcher): Return do_exact_match when
9842         doing a verbatim match.
9843
9844 2019-02-15  Tom Tromey  <tromey@adacore.com>
9845
9846         * ravenscar-thread.c (ravenscar_thread_target::resume)
9847         (ravenscar_thread_target::wait): Special case wildcard requests.
9848
9849 2019-02-15  Tom Tromey  <tromey@adacore.com>
9850
9851         * ravenscar-thread.c (base_ptid): Remove.
9852         (struct ravenscar_thread_target) <close>: New method.
9853         <m_base_ptid>: New member.
9854         <update_inferior_ptid, active_task, task_is_currently_active,
9855         runtime_initialized>: Declare methods.
9856         <ravenscar_thread_target>: Add constructor.
9857         (ravenscar_thread_target::task_is_currently_active)
9858         (ravenscar_thread_target::update_inferior_ptid)
9859         (ravenscar_runtime_initialized): Rename.  Now methods.
9860         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9861         (ravenscar_thread_target::update_thread_list): Update.
9862         (ravenscar_thread_target::active_task): Now method.
9863         (ravenscar_thread_target::store_registers)
9864         (ravenscar_thread_target::prepare_to_store)
9865         (ravenscar_thread_target::prepare_to_store)
9866         (ravenscar_thread_target::mourn_inferior): Update.
9867         (ravenscar_inferior_created): Use "new" to create target.
9868         (ravenscar_thread_target::get_ada_task_ptid): Update.
9869         (_initialize_ravenscar): Don't initialize base_ptid.
9870         (ravenscar_ops): Remove global.
9871
9872 2019-02-15  Tom Tromey  <tromey@adacore.com>
9873
9874         * target.h (push_target): Declare new overload.
9875         * target.c (push_target): New overload, taking an rvalue reference.
9876         * remote.c (remote_target::open_1): Use push_target overload.
9877         * corelow.c (core_target_open): Use push_target overload.
9878
9879 2019-02-15  Tom Tromey  <tromey@adacore.com>
9880
9881         * ravenscar-thread.c (is_ravenscar_task)
9882         (ravenscar_task_is_currently_active): Return bool.
9883         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9884         (_initialize_ravenscar): Remove "(void)".
9885         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9886         Return bool.
9887
9888 2019-02-15  Tom Tromey  <tromey@adacore.com>
9889
9890         * ravenscar-thread.c (ravenscar_runtime_initializer)
9891         (has_ravenscar_runtime, get_running_thread_id)
9892         (ravenscar_thread_target::resume): Fix indentation.
9893
9894 2019-02-15  Tom Tromey  <tromey@adacore.com>
9895
9896         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9897         from ravenscar_arch_ops.
9898         (sparc_ravenscar_ops::fetch_registers)
9899         (sparc_ravenscar_ops::store_registers): Now methods.
9900         (sparc_ravenscar_prepare_to_store): Remove.
9901         (sparc_ravenscar_ops): Redefine.
9902         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9903         methods and destructor.  Remove members.
9904         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9905         (ravenscar_thread_target::store_registers)
9906         (ravenscar_thread_target::prepare_to_store): Update.
9907         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9908         Remove.
9909         (struct ppc_ravenscar_powerpc_ops): Derive from
9910         ravenscar_arch_ops.
9911         (ppc_ravenscar_powerpc_ops::fetch_registers)
9912         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9913         (ppc_ravenscar_powerpc_ops): Redefine.
9914         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9915         (ppc_ravenscar_e500_ops::fetch_registers)
9916         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9917         (ppc_ravenscar_e500_ops): Redefine.
9918         * aarch64-ravenscar-thread.c
9919         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9920         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9921         (aarch64_ravenscar_fetch_registers)
9922         (aarch64_ravenscar_store_registers): Now methods.
9923         (aarch64_ravenscar_ops): Redefine.
9924
9925 2019-02-15  Tom Tromey  <tromey@adacore.com>
9926
9927         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9928         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9929         (ravenscar_thread_target::stopped_by_watchpoint)
9930         (ravenscar_thread_target::stopped_data_address)
9931         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9932
9933 2019-02-15  Tom Tromey  <tromey@adacore.com>
9934
9935         * ravenscar-thread.c: Fix some typos.
9936
9937 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9938             Tom Tromey  <tromey@adacore.com>
9939
9940         * ada-lang.c (ada_exception_sal): Change addr_string to a
9941         std::string.
9942         (create_ada_exception_catchpoint): Update.
9943
9944 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9945             Tom Tromey  <tromey@adacore.com>
9946
9947         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9948         (bp_location_ops): Remove.
9949         (base_breakpoint_allocate_location): Update.
9950         (free_bp_location): Update.
9951         * ada-lang.c (class ada_catchpoint_location)
9952         <ada_catchpoint_location>: Remove ops parameter.
9953         (ada_catchpoint_location_dtor): Remove.
9954         (ada_catchpoint_location_ops): Remove.
9955         (allocate_location_exception): Update.
9956         * breakpoint.h (struct bp_location_ops): Remove.
9957         (class bp_location) <bp_location>: Remove bp_location_ops
9958         parameter.
9959         <~bp_location>: Add destructor.
9960         <ops>: Remove.
9961
9962 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9963             Pedro Alves  <palves@redhat.com>
9964
9965         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9966         'PATH_MAX'.
9967
9968 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9969             Samuel Thibault  <samuel.thibault@gnu.org>
9970             Thomas Schwinge  <thomas@codesourcery.com>
9971
9972         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9973         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9974
9975 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9976
9977         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9978         (check_empty): Use "const char *".
9979
9980         * gnu-nat.c (gnu_nat_target::detach): Instead of
9981         'detach_inferior (pid)' call
9982         'detach_inferior (find_inferior_pid (pid))'.
9983
9984         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9985         'nat/fork-inferior.o'.
9986         * gnu-nat.c: #include "nat/fork-inferior.h".
9987
9988         * gnu-nat.c (gnu_nat_target::detach): Instead of
9989         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9990         * gnu-nat.h: #include "inf-child.h".
9991         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9992         'i386_gnu_nat_target::fetch_registers'.
9993         (gnu_store_registers): Rename/move to
9994         'i386_gnu_nat_target::store_registers'.
9995
9996         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9997         * gnu-nat.h (mach_thread_info): New function.
9998         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9999
10000         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10001
10002 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10003
10004         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10005
10006 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10007
10008         * windows-nat.c (windows_add_thread): Add new parameter
10009         "main_thread_p" with default value set to false.  Update
10010         function documentation as well as all callers.
10011         (windows_delete_thread): Likewise.
10012         (fake_create_process): Update call to windows_add_thread.
10013         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10014         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10015         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10016         call to windows_delete_thread.
10017
10018 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10019
10020         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10021
10022 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10023
10024         * symfile.c (find_separate_debug_file): Use canonical path of
10025         sysroot with child_path instead of gdb_sysroot if it is valid.
10026
10027 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10028
10029         * symfile.c (find_separate_debug_file): Use child_path to
10030         determine if an object file is under a sysroot.
10031
10032 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10033
10034         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10035         unittests/child-path-selftests.c.
10036         * common/pathstuff.c (child_path): New function.
10037         * common/pathstuff.h (child_path): New prototype.
10038         * unittests/child-path-selftests.c: New file.
10039
10040 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10041
10042         * symfile.c (find_separate_debug_file): Look for separate debug
10043         files in debug directories under the sysroot.
10044
10045 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10046
10047         * symtab.h (struct minimal_symbol data_p): New const method.
10048         (struct minimal_symbol text_p): Likewise.
10049         * symtab.c (output_source_filename): Use file name style
10050         to print file name.
10051         (print_symbol_info): Likewise.
10052         (print_msymbol_info): Use address style to print addresses.
10053         Use function name style to print executable text symbols.
10054         (expand_symtab_containing_pc): Use data_p.
10055         (find_pc_sect_compunit_symtab): Likewise.
10056
10057 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10058
10059         * breakpoint.c (describe_other_breakpoints): Use address style
10060         to print addresses.
10061         (say_where): Likewise.
10062
10063 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10064
10065         * ada-typeprint.c (print_func_type): Print function name
10066         style to print function name.
10067         * c-typeprint.c (c_print_type_1): Likewise.
10068
10069 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10070
10071         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10072         for execve.
10073
10074 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10075
10076         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10077         type_stack.
10078
10079 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10080
10081         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10082         TYPE_CODE_REF types.
10083
10084 2019-02-08  Jim Wilson  <jimw@sifive.com>
10085
10086         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10087         (riscv_linux_fregset): New.
10088         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10089
10090 2019-02-07  Tom Tromey  <tom@tromey.com>
10091
10092         * thread.c (thread_cancel_execution_command): Update.
10093         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10094         methods.
10095         (struct thread_fsm_ops): Remove.
10096         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10097         (thread_fsm_should_stop, thread_fsm_return_value)
10098         (thread_fsm_set_finished, thread_fsm_finished_p)
10099         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10100         Don't declare.
10101         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10102         * infrun.c (clear_proceed_status_thread)
10103         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10104         (print_stop_event): Update.
10105         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10106         Add constructor.
10107         (step_command_fsm_ops): Remove.
10108         (new_step_command_fsm): Remove.
10109         (step_1): Update.
10110         (step_command_fsm::should_stop): Rename from
10111         step_command_fsm_should_stop.
10112         (step_command_fsm::clean_up): Rename from
10113         step_command_fsm_clean_up.
10114         (step_command_fsm::do_async_reply_reason): Rename from
10115         step_command_fsm_async_reply_reason.
10116         (struct until_next_fsm): Inherit from thread_fsm.  Add
10117         constructor.
10118         (until_next_fsm_ops): Remove.
10119         (new_until_next_fsm): Remove.
10120         (until_next_fsm::should_stop): Rename from
10121         until_next_fsm_should_stop.
10122         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10123         (until_next_fsm::do_async_reply_reason): Rename from
10124         until_next_fsm_async_reply_reason.
10125         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10126         constructor.  Change type of breakpoint.
10127         (finish_command_fsm_ops): Remove.
10128         (new_finish_command_fsm): Remove.
10129         (finish_command_fsm::should_stop): Rename from
10130         finish_command_fsm_should_stop.
10131         (finish_command_fsm::clean_up): Rename from
10132         finish_command_fsm_clean_up.
10133         (finish_command_fsm::return_value): Rename from
10134         finish_command_fsm_return_value.
10135         (finish_command_fsm::do_async_reply_reason): Rename from
10136         finish_command_fsm_async_reply_reason.
10137         (finish_command): Update.
10138         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10139         Add constructor.
10140         (call_thread_fsm_ops): Remove.
10141         (call_thread_fsm::call_thread_fsm): Rename from
10142         new_call_thread_fsm.
10143         (call_thread_fsm::should_stop): Rename from
10144         call_thread_fsm_should_stop.
10145         (call_thread_fsm::should_notify_stop): Rename from
10146         call_thread_fsm_should_notify_stop.
10147         (run_inferior_call, call_function_by_hand_dummy): Update.
10148         * cli/cli-interp.c (should_print_stop_to_console): Update.
10149         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10150         Add constructor.  Change type of location_breakpoint,
10151         caller_breakpoint.
10152         (until_break_fsm_ops): Remove.
10153         (new_until_break_fsm): Remove.
10154         (until_break_fsm::should_stop): Rename from
10155         until_break_fsm_should_stop.
10156         (until_break_fsm::clean_up): Rename from
10157         until_break_fsm_clean_up.
10158         (until_break_fsm::do_async_reply_reason): Rename from
10159         until_break_fsm_async_reply_reason.
10160         (until_break_command): Update.
10161         * thread-fsm.c: Remove.
10162         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10163
10164 2019-02-07  Tom Tromey  <tom@tromey.com>
10165
10166         * yy-remap.h: Add include guard.
10167         * xtensa-tdep.h: Add include guard.
10168         * xcoffread.h: Rename include guard.
10169         * varobj-iter.h: Add include guard.
10170         * tui/tui.h: Rename include guard.
10171         * tui/tui-winsource.h: Rename include guard.
10172         * tui/tui-wingeneral.h: Rename include guard.
10173         * tui/tui-windata.h: Rename include guard.
10174         * tui/tui-win.h: Rename include guard.
10175         * tui/tui-stack.h: Rename include guard.
10176         * tui/tui-source.h: Rename include guard.
10177         * tui/tui-regs.h: Rename include guard.
10178         * tui/tui-out.h: Rename include guard.
10179         * tui/tui-layout.h: Rename include guard.
10180         * tui/tui-io.h: Rename include guard.
10181         * tui/tui-hooks.h: Rename include guard.
10182         * tui/tui-file.h: Rename include guard.
10183         * tui/tui-disasm.h: Rename include guard.
10184         * tui/tui-data.h: Rename include guard.
10185         * tui/tui-command.h: Rename include guard.
10186         * tic6x-tdep.h: Add include guard.
10187         * target/waitstatus.h: Rename include guard.
10188         * target/wait.h: Rename include guard.
10189         * target/target.h: Rename include guard.
10190         * target/resume.h: Rename include guard.
10191         * target-float.h: Rename include guard.
10192         * stabsread.h: Add include guard.
10193         * rs6000-tdep.h: Add include guard.
10194         * riscv-fbsd-tdep.h: Add include guard.
10195         * regformats/regdef.h: Rename include guard.
10196         * record.h: Rename include guard.
10197         * python/python.h: Rename include guard.
10198         * python/python-internal.h: Rename include guard.
10199         * python/py-stopevent.h: Rename include guard.
10200         * python/py-ref.h: Rename include guard.
10201         * python/py-record.h: Rename include guard.
10202         * python/py-record-full.h: Rename include guard.
10203         * python/py-record-btrace.h: Rename include guard.
10204         * python/py-instruction.h: Rename include guard.
10205         * python/py-events.h: Rename include guard.
10206         * python/py-event.h: Rename include guard.
10207         * procfs.h: Add include guard.
10208         * proc-utils.h: Add include guard.
10209         * p-lang.h: Add include guard.
10210         * or1k-tdep.h: Rename include guard.
10211         * observable.h: Rename include guard.
10212         * nto-tdep.h: Rename include guard.
10213         * nat/x86-linux.h: Rename include guard.
10214         * nat/x86-linux-dregs.h: Rename include guard.
10215         * nat/x86-gcc-cpuid.h: Add include guard.
10216         * nat/x86-dregs.h: Rename include guard.
10217         * nat/x86-cpuid.h: Rename include guard.
10218         * nat/ppc-linux.h: Rename include guard.
10219         * nat/mips-linux-watch.h: Rename include guard.
10220         * nat/linux-waitpid.h: Rename include guard.
10221         * nat/linux-ptrace.h: Rename include guard.
10222         * nat/linux-procfs.h: Rename include guard.
10223         * nat/linux-osdata.h: Rename include guard.
10224         * nat/linux-nat.h: Rename include guard.
10225         * nat/linux-namespaces.h: Rename include guard.
10226         * nat/linux-btrace.h: Rename include guard.
10227         * nat/glibc_thread_db.h: Rename include guard.
10228         * nat/gdb_thread_db.h: Rename include guard.
10229         * nat/gdb_ptrace.h: Rename include guard.
10230         * nat/fork-inferior.h: Rename include guard.
10231         * nat/amd64-linux-siginfo.h: Rename include guard.
10232         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10233         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10234         * nat/aarch64-linux.h: Rename include guard.
10235         * nat/aarch64-linux-hw-point.h: Rename include guard.
10236         * mn10300-tdep.h: Add include guard.
10237         * mips-linux-tdep.h: Add include guard.
10238         * mi/mi-parse.h: Rename include guard.
10239         * mi/mi-out.h: Rename include guard.
10240         * mi/mi-main.h: Rename include guard.
10241         * mi/mi-interp.h: Rename include guard.
10242         * mi/mi-getopt.h: Rename include guard.
10243         * mi/mi-console.h: Rename include guard.
10244         * mi/mi-common.h: Rename include guard.
10245         * mi/mi-cmds.h: Rename include guard.
10246         * mi/mi-cmd-break.h: Rename include guard.
10247         * m2-lang.h: Add include guard.
10248         * location.h: Rename include guard.
10249         * linux-record.h: Rename include guard.
10250         * linux-nat.h: Add include guard.
10251         * linux-fork.h: Add include guard.
10252         * i386-darwin-tdep.h: Rename include guard.
10253         * hppa-linux-offsets.h: Add include guard.
10254         * guile/guile.h: Rename include guard.
10255         * guile/guile-internal.h: Rename include guard.
10256         * gnu-nat.h: Rename include guard.
10257         * gdb-stabs.h: Rename include guard.
10258         * frv-tdep.h: Add include guard.
10259         * f-lang.h: Add include guard.
10260         * event-loop.h: Add include guard.
10261         * darwin-nat.h: Rename include guard.
10262         * cp-abi.h: Rename include guard.
10263         * config/sparc/nm-sol2.h: Rename include guard.
10264         * config/nm-nto.h: Rename include guard.
10265         * config/nm-linux.h: Add include guard.
10266         * config/i386/nm-i386gnu.h: Rename include guard.
10267         * config/djgpp/nl_types.h: Rename include guard.
10268         * config/djgpp/langinfo.h: Rename include guard.
10269         * compile/gcc-cp-plugin.h: Add include guard.
10270         * compile/gcc-c-plugin.h: Add include guard.
10271         * compile/compile.h: Rename include guard.
10272         * compile/compile-object-run.h: Rename include guard.
10273         * compile/compile-object-load.h: Rename include guard.
10274         * compile/compile-internal.h: Rename include guard.
10275         * compile/compile-cplus.h: Rename include guard.
10276         * compile/compile-c.h: Rename include guard.
10277         * common/xml-utils.h: Rename include guard.
10278         * common/x86-xstate.h: Rename include guard.
10279         * common/version.h: Rename include guard.
10280         * common/vec.h: Rename include guard.
10281         * common/tdesc.h: Rename include guard.
10282         * common/selftest.h: Rename include guard.
10283         * common/scoped_restore.h: Rename include guard.
10284         * common/scoped_mmap.h: Rename include guard.
10285         * common/scoped_fd.h: Rename include guard.
10286         * common/safe-iterator.h: Rename include guard.
10287         * common/run-time-clock.h: Rename include guard.
10288         * common/refcounted-object.h: Rename include guard.
10289         * common/queue.h: Rename include guard.
10290         * common/ptid.h: Rename include guard.
10291         * common/print-utils.h: Rename include guard.
10292         * common/preprocessor.h: Rename include guard.
10293         * common/pathstuff.h: Rename include guard.
10294         * common/observable.h: Rename include guard.
10295         * common/netstuff.h: Rename include guard.
10296         * common/job-control.h: Rename include guard.
10297         * common/host-defs.h: Rename include guard.
10298         * common/gdb_wait.h: Rename include guard.
10299         * common/gdb_vecs.h: Rename include guard.
10300         * common/gdb_unlinker.h: Rename include guard.
10301         * common/gdb_unique_ptr.h: Rename include guard.
10302         * common/gdb_tilde_expand.h: Rename include guard.
10303         * common/gdb_sys_time.h: Rename include guard.
10304         * common/gdb_string_view.h: Rename include guard.
10305         * common/gdb_splay_tree.h: Rename include guard.
10306         * common/gdb_setjmp.h: Rename include guard.
10307         * common/gdb_ref_ptr.h: Rename include guard.
10308         * common/gdb_optional.h: Rename include guard.
10309         * common/gdb_locale.h: Rename include guard.
10310         * common/gdb_assert.h: Rename include guard.
10311         * common/filtered-iterator.h: Rename include guard.
10312         * common/filestuff.h: Rename include guard.
10313         * common/fileio.h: Rename include guard.
10314         * common/environ.h: Rename include guard.
10315         * common/common-utils.h: Rename include guard.
10316         * common/common-types.h: Rename include guard.
10317         * common/common-regcache.h: Rename include guard.
10318         * common/common-inferior.h: Rename include guard.
10319         * common/common-gdbthread.h: Rename include guard.
10320         * common/common-exceptions.h: Rename include guard.
10321         * common/common-defs.h: Rename include guard.
10322         * common/common-debug.h: Rename include guard.
10323         * common/cleanups.h: Rename include guard.
10324         * common/buffer.h: Rename include guard.
10325         * common/btrace-common.h: Rename include guard.
10326         * common/break-common.h: Rename include guard.
10327         * cli/cli-utils.h: Rename include guard.
10328         * cli/cli-style.h: Rename include guard.
10329         * cli/cli-setshow.h: Rename include guard.
10330         * cli/cli-script.h: Rename include guard.
10331         * cli/cli-interp.h: Rename include guard.
10332         * cli/cli-decode.h: Rename include guard.
10333         * cli/cli-cmds.h: Rename include guard.
10334         * charset-list.h: Add include guard.
10335         * buildsym-legacy.h: Rename include guard.
10336         * bfin-tdep.h: Add include guard.
10337         * ax.h: Rename include guard.
10338         * arm-linux-tdep.h: Add include guard.
10339         * arm-fbsd-tdep.h: Add include guard.
10340         * arch/xtensa.h: Rename include guard.
10341         * arch/tic6x.h: Add include guard.
10342         * arch/i386.h: Add include guard.
10343         * arch/arm.h: Rename include guard.
10344         * arch/arm-linux.h: Rename include guard.
10345         * arch/arm-get-next-pcs.h: Rename include guard.
10346         * arch/amd64.h: Add include guard.
10347         * arch/aarch64-insn.h: Rename include guard.
10348         * arch-utils.h: Rename include guard.
10349         * annotate.h: Add include guard.
10350         * amd64-darwin-tdep.h: Rename include guard.
10351         * aarch64-linux-tdep.h: Add include guard.
10352         * aarch64-fbsd-tdep.h: Add include guard.
10353         * aarch32-linux-nat.h: Add include guard.
10354
10355 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10356
10357         * macrotab.c (macro_define_internal): New function that
10358         factorizes macro_define_object_internal and macro_define_function
10359         code.
10360         (macro_define_object_internal): Use macro_define_internal.
10361         (macro_define_function): Likewise.
10362
10363 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10364
10365         * macrocmd.c (extract_identifier): Return
10366         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10367         callers.
10368
10369 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10370
10371         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10372
10373 2019-02-05  Tom Tromey  <tom@tromey.com>
10374
10375         * target.c (target_stack::unpush): Move assertion earlier.
10376
10377 2019-01-30  Tom Tromey  <tom@tromey.com>
10378
10379         PR python/23615:
10380         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10381         (gdbpy_parse_and_eval): Likewise.
10382         * python/python-internal.h (gdbpy_allow_threads): New class.
10383
10384 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10385
10386         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10387         (aarch64_fbsd_fpregmap): Move earlier.
10388         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10389         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10390         instead of individual calls to trad_frame_set_reg_addr.
10391         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10392         earlier.
10393         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10394         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10395         instead of individual calls to trad_frame_set_reg_addr.
10396
10397 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10398
10399         * CONTRIBUTE: Replace contribution list with wiki link.
10400
10401 2019-01-25  Tom Tromey  <tom@tromey.com>
10402
10403         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10404
10405 2019-01-25  Tom Tromey  <tom@tromey.com>
10406
10407         * xtensa-linux-nat.c: Fix common/ includes.
10408         * xml-support.h: Fix common/ includes.
10409         * xml-support.c: Fix common/ includes.
10410         * x86-linux-nat.c: Fix common/ includes.
10411         * windows-nat.c: Fix common/ includes.
10412         * varobj.h: Fix common/ includes.
10413         * varobj.c: Fix common/ includes.
10414         * value.c: Fix common/ includes.
10415         * valops.c: Fix common/ includes.
10416         * utils.c: Fix common/ includes.
10417         * unittests/xml-utils-selftests.c: Fix common/ includes.
10418         * unittests/utils-selftests.c: Fix common/ includes.
10419         * unittests/unpack-selftests.c: Fix common/ includes.
10420         * unittests/tracepoint-selftests.c: Fix common/ includes.
10421         * unittests/style-selftests.c: Fix common/ includes.
10422         * unittests/string_view-selftests.c: Fix common/ includes.
10423         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10424         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10425         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10426         * unittests/rsp-low-selftests.c: Fix common/ includes.
10427         * unittests/parse-connection-spec-selftests.c: Fix common/
10428         includes.
10429         * unittests/optional-selftests.c: Fix common/ includes.
10430         * unittests/offset-type-selftests.c: Fix common/ includes.
10431         * unittests/observable-selftests.c: Fix common/ includes.
10432         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10433         * unittests/memrange-selftests.c: Fix common/ includes.
10434         * unittests/memory-map-selftests.c: Fix common/ includes.
10435         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10436         * unittests/function-view-selftests.c: Fix common/ includes.
10437         * unittests/environ-selftests.c: Fix common/ includes.
10438         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10439         * unittests/common-utils-selftests.c: Fix common/ includes.
10440         * unittests/cli-utils-selftests.c: Fix common/ includes.
10441         * unittests/array-view-selftests.c: Fix common/ includes.
10442         * ui-file.c: Fix common/ includes.
10443         * tui/tui-io.c: Fix common/ includes.
10444         * tracepoint.h: Fix common/ includes.
10445         * tracepoint.c: Fix common/ includes.
10446         * tracefile-tfile.c: Fix common/ includes.
10447         * top.h: Fix common/ includes.
10448         * top.c: Fix common/ includes.
10449         * thread.c: Fix common/ includes.
10450         * target/waitstatus.h: Fix common/ includes.
10451         * target/waitstatus.c: Fix common/ includes.
10452         * target.h: Fix common/ includes.
10453         * target.c: Fix common/ includes.
10454         * target-memory.c: Fix common/ includes.
10455         * target-descriptions.c: Fix common/ includes.
10456         * symtab.h: Fix common/ includes.
10457         * symfile.c: Fix common/ includes.
10458         * stap-probe.c: Fix common/ includes.
10459         * spu-linux-nat.c: Fix common/ includes.
10460         * sparc-nat.c: Fix common/ includes.
10461         * source.c: Fix common/ includes.
10462         * solib.c: Fix common/ includes.
10463         * solib-target.c: Fix common/ includes.
10464         * ser-unix.c: Fix common/ includes.
10465         * ser-tcp.c: Fix common/ includes.
10466         * ser-pipe.c: Fix common/ includes.
10467         * ser-base.c: Fix common/ includes.
10468         * selftest-arch.c: Fix common/ includes.
10469         * s12z-tdep.c: Fix common/ includes.
10470         * rust-exp.y: Fix common/ includes.
10471         * rs6000-aix-tdep.c: Fix common/ includes.
10472         * riscv-tdep.c: Fix common/ includes.
10473         * remote.c: Fix common/ includes.
10474         * remote-notif.h: Fix common/ includes.
10475         * remote-fileio.h: Fix common/ includes.
10476         * remote-fileio.c: Fix common/ includes.
10477         * regcache.h: Fix common/ includes.
10478         * regcache.c: Fix common/ includes.
10479         * record-btrace.c: Fix common/ includes.
10480         * python/python.c: Fix common/ includes.
10481         * python/py-type.c: Fix common/ includes.
10482         * python/py-inferior.c: Fix common/ includes.
10483         * progspace.h: Fix common/ includes.
10484         * producer.c: Fix common/ includes.
10485         * procfs.c: Fix common/ includes.
10486         * proc-api.c: Fix common/ includes.
10487         * printcmd.c: Fix common/ includes.
10488         * ppc-linux-nat.c: Fix common/ includes.
10489         * parser-defs.h: Fix common/ includes.
10490         * osdata.c: Fix common/ includes.
10491         * obsd-nat.c: Fix common/ includes.
10492         * nat/x86-linux.c: Fix common/ includes.
10493         * nat/x86-linux-dregs.c: Fix common/ includes.
10494         * nat/x86-dregs.h: Fix common/ includes.
10495         * nat/x86-dregs.c: Fix common/ includes.
10496         * nat/ppc-linux.c: Fix common/ includes.
10497         * nat/mips-linux-watch.h: Fix common/ includes.
10498         * nat/mips-linux-watch.c: Fix common/ includes.
10499         * nat/linux-waitpid.c: Fix common/ includes.
10500         * nat/linux-ptrace.h: Fix common/ includes.
10501         * nat/linux-ptrace.c: Fix common/ includes.
10502         * nat/linux-procfs.c: Fix common/ includes.
10503         * nat/linux-personality.c: Fix common/ includes.
10504         * nat/linux-osdata.c: Fix common/ includes.
10505         * nat/linux-namespaces.c: Fix common/ includes.
10506         * nat/linux-btrace.h: Fix common/ includes.
10507         * nat/linux-btrace.c: Fix common/ includes.
10508         * nat/fork-inferior.c: Fix common/ includes.
10509         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10510         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10511         * nat/aarch64-linux.c: Fix common/ includes.
10512         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10513         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10514         * namespace.h: Fix common/ includes.
10515         * mips-linux-tdep.c: Fix common/ includes.
10516         * minsyms.c: Fix common/ includes.
10517         * mi/mi-parse.h: Fix common/ includes.
10518         * mi/mi-main.c: Fix common/ includes.
10519         * mi/mi-cmd-env.c: Fix common/ includes.
10520         * memrange.h: Fix common/ includes.
10521         * memattr.c: Fix common/ includes.
10522         * maint.h: Fix common/ includes.
10523         * maint.c: Fix common/ includes.
10524         * main.c: Fix common/ includes.
10525         * machoread.c: Fix common/ includes.
10526         * location.c: Fix common/ includes.
10527         * linux-thread-db.c: Fix common/ includes.
10528         * linux-nat.c: Fix common/ includes.
10529         * linux-fork.c: Fix common/ includes.
10530         * inline-frame.c: Fix common/ includes.
10531         * infrun.c: Fix common/ includes.
10532         * inflow.c: Fix common/ includes.
10533         * inferior.h: Fix common/ includes.
10534         * inferior.c: Fix common/ includes.
10535         * infcmd.c: Fix common/ includes.
10536         * inf-ptrace.c: Fix common/ includes.
10537         * inf-child.c: Fix common/ includes.
10538         * ia64-linux-nat.c: Fix common/ includes.
10539         * i387-tdep.c: Fix common/ includes.
10540         * i386-tdep.c: Fix common/ includes.
10541         * i386-linux-tdep.c: Fix common/ includes.
10542         * i386-linux-nat.c: Fix common/ includes.
10543         * i386-go32-tdep.c: Fix common/ includes.
10544         * i386-fbsd-tdep.c: Fix common/ includes.
10545         * i386-fbsd-nat.c: Fix common/ includes.
10546         * guile/scm-type.c: Fix common/ includes.
10547         * guile/guile.c: Fix common/ includes.
10548         * go32-nat.c: Fix common/ includes.
10549         * gnu-nat.c: Fix common/ includes.
10550         * gdbthread.h: Fix common/ includes.
10551         * gdbarch-selftests.c: Fix common/ includes.
10552         * gdb_usleep.c: Fix common/ includes.
10553         * gdb_select.h: Fix common/ includes.
10554         * gdb_bfd.c: Fix common/ includes.
10555         * gcore.c: Fix common/ includes.
10556         * fork-child.c: Fix common/ includes.
10557         * findvar.c: Fix common/ includes.
10558         * fbsd-nat.c: Fix common/ includes.
10559         * event-top.c: Fix common/ includes.
10560         * event-loop.c: Fix common/ includes.
10561         * dwarf2read.c: Fix common/ includes.
10562         * dwarf2loc.c: Fix common/ includes.
10563         * dwarf2-frame.c: Fix common/ includes.
10564         * dwarf-index-cache.c: Fix common/ includes.
10565         * dtrace-probe.c: Fix common/ includes.
10566         * disasm-selftests.c: Fix common/ includes.
10567         * defs.h: Fix common/ includes.
10568         * csky-tdep.c: Fix common/ includes.
10569         * cp-valprint.c: Fix common/ includes.
10570         * cp-support.h: Fix common/ includes.
10571         * cp-support.c: Fix common/ includes.
10572         * corelow.c: Fix common/ includes.
10573         * completer.h: Fix common/ includes.
10574         * completer.c: Fix common/ includes.
10575         * compile/compile.c: Fix common/ includes.
10576         * compile/compile-loc2c.c: Fix common/ includes.
10577         * compile/compile-cplus-types.c: Fix common/ includes.
10578         * compile/compile-cplus-symbols.c: Fix common/ includes.
10579         * command.h: Fix common/ includes.
10580         * cli/cli-dump.c: Fix common/ includes.
10581         * cli/cli-cmds.c: Fix common/ includes.
10582         * charset.c: Fix common/ includes.
10583         * build-id.c: Fix common/ includes.
10584         * btrace.h: Fix common/ includes.
10585         * btrace.c: Fix common/ includes.
10586         * breakpoint.h: Fix common/ includes.
10587         * breakpoint.c: Fix common/ includes.
10588         * ax.h:
10589         (enum agent_op): Fix common/ includes.
10590         * ax-general.c (struct aop_map): Fix common/ includes.
10591         * ax-gdb.c: Fix common/ includes.
10592         * auxv.c: Fix common/ includes.
10593         * auto-load.c: Fix common/ includes.
10594         * arm-tdep.c: Fix common/ includes.
10595         * arch/riscv.c: Fix common/ includes.
10596         * arch/ppc-linux-common.c: Fix common/ includes.
10597         * arch/i386.c: Fix common/ includes.
10598         * arch/arm.c: Fix common/ includes.
10599         * arch/arm-linux.c: Fix common/ includes.
10600         * arch/arm-get-next-pcs.c: Fix common/ includes.
10601         * arch/amd64.c: Fix common/ includes.
10602         * arch/aarch64.c: Fix common/ includes.
10603         * arch/aarch64-insn.c: Fix common/ includes.
10604         * arch-utils.c: Fix common/ includes.
10605         * amd64-windows-tdep.c: Fix common/ includes.
10606         * amd64-tdep.c: Fix common/ includes.
10607         * amd64-sol2-tdep.c: Fix common/ includes.
10608         * amd64-obsd-tdep.c: Fix common/ includes.
10609         * amd64-nbsd-tdep.c: Fix common/ includes.
10610         * amd64-linux-tdep.c: Fix common/ includes.
10611         * amd64-linux-nat.c: Fix common/ includes.
10612         * amd64-fbsd-tdep.c: Fix common/ includes.
10613         * amd64-fbsd-nat.c: Fix common/ includes.
10614         * amd64-dicos-tdep.c: Fix common/ includes.
10615         * amd64-darwin-tdep.c: Fix common/ includes.
10616         * agent.c: Fix common/ includes.
10617         * ada-lang.h: Fix common/ includes.
10618         * ada-lang.c: Fix common/ includes.
10619         * aarch64-tdep.c: Fix common/ includes.
10620
10621 2019-01-25  Tom Tromey  <tom@tromey.com>
10622
10623         * common/create-version.sh: Use common/version.h.
10624
10625 2019-01-24  Pedro Alves  <palves@redhat.com>
10626
10627         * infrun.c (signal_stop, signal_print, signal_program)
10628         (signal_catch, signal_pass): Now arrays instead of pointers.
10629         (update_signals_program_target, do_target_resume)
10630         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10631         * linux-nat.c (linux_nat_target::pass_signals)
10632         (linux_nat_target::create_inferior, linux_nat_target::attach):
10633         Adjust.
10634         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10635         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10636         * procfs.c (procfs_target::pass_signals): Adjust.
10637         * record-full.c (record_full_target::resume): Adjust.
10638         * remote.c (remote_target::pass_signals)
10639         (remote_target::program_signals): Adjust.
10640         * target-debug.h (target_debug_print_signals): Now takes a
10641         gdb::array_view as parameter.  Adjust.
10642         * target.h (target_ops) <pass_signals, program_signals>: Replace
10643         pointer and length parameters with gdb::array_view.
10644         (target_pass_signals, target_program_signals): Likewise.
10645         * target-delegates.c: Regenerate.
10646
10647 2019-01-24  Pedro Alves  <palves@redhat.com>
10648
10649         * common/forward-scope-exit.h
10650         (forward_scope_exit::forward_scope_exit): Pass arguments to
10651         m_bind_function directly, instead of creating a std::bind and
10652         copying that.
10653
10654 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10655
10656         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10657         for static members.
10658         (pass_in_v_vfp_candidate): Likewise.
10659
10660 2019-01-23  Tom Tromey  <tom@tromey.com>
10661             Pedro Alves  <palves@redhat.com>
10662
10663         * regcache.c (class regcache_invalidator): Remove.
10664         (regcache::raw_write): Use make_scope_exit.
10665
10666 2019-01-23  Tom Tromey  <tom@tromey.com>
10667
10668         * ui-out.h (class ui_out_emit_type): Update comment.
10669
10670 2019-01-23  Tom Tromey  <tom@tromey.com>
10671
10672         * infrun.c (fetch_inferior_event): Update comment.
10673
10674 2019-01-23  Tom Tromey  <tom@tromey.com>
10675             Pedro Alves  <palves@redhat.com>
10676
10677         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10678         parameter.
10679         (fetch_inferior_event): Use SCOPE_EXIT.
10680
10681
10682 2019-01-23  Tom Tromey  <tom@tromey.com>
10683             Pedro Alves  <palves@redhat.com>
10684
10685         * infrun.c (disable_thread_events): Delete.
10686         (stop_all_threads): Use SCOPE_EXIT.
10687
10688 2019-01-23  Tom Tromey  <tom@tromey.com>
10689             Pedro Alves  <palves@redhat.com>
10690
10691         * symfile.c: Include forward-scope-exit.h.
10692         (clear_symtab_users_cleanup): Replace forward declaration with
10693         a FORWARD_SCOPE_EXIT.
10694         (syms_from_objfile_1): Use the forward_scope_exit and
10695         gdb::optional instead of cleanup_function.
10696         (reread_symbols): Use the forward_scope_exit instead of
10697         cleanup_function.
10698         (clear_symtab_users_cleanup): Remove function.
10699
10700 2019-01-23  Tom Tromey  <tom@tromey.com>
10701             Pedro Alves  <palves@redhat.com>
10702
10703         * linux-nat.c: Include scope-exit.h.
10704         (cleanup_target_stop): Remove.
10705         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10706         SCOPE_EXIT.
10707
10708 2019-01-23  Tom Tromey  <tom@tromey.com>
10709             Pedro Alves  <palves@redhat.com>
10710
10711         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10712         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10713
10714 2019-01-23  Tom Tromey  <tom@tromey.com>
10715             Andrew Burgess  <andrew.burgess@embecosm.com>
10716             Pedro Alves  <palves@redhat.com>
10717
10718         * infrun.c (fetch_inferior_event): Use scope_exit.
10719         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10720         * top.c (execute_command): Use scope_exit.
10721         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10722         * utils.c (do_bpstat_clear_actions_cleanup)
10723         (make_bpstat_clear_actions_cleanup): Remove.
10724
10725 2019-01-23  Tom Tromey  <tom@tromey.com>
10726             Pedro Alves  <palves@redhat.com>
10727
10728         * infrun.c: Include "common/scope-exit.h"
10729         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10730         (wait_for_inferior): Use SCOPE_EXIT.
10731         (fetch_inferior_event): Use scope_exit.
10732
10733 2019-01-23  Tom Tromey  <tom@tromey.com>
10734             Pedro Alves  <palves@redhat.com>
10735
10736         * breakpoint.c (create_breakpoint): Remove cleanup.
10737
10738 2019-01-23  Tom Tromey  <tom@tromey.com>
10739             Andrew Burgess  <andrew.burgess@embecosm.com>
10740             Pedro Alves  <palves@redhat.com>
10741
10742 2019-01-23  Pedro Alves  <palves@redhat.com>
10743
10744         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10745
10746 2019-01-23  Pedro Alves  <palves@redhat.com>
10747             Andrew Burgess  <andrew.burgess@embecosm.com>
10748
10749         * gdbthread.h: Include "common/forward-scope-exit.h".
10750         (scoped_finish_thread_state): Redefine custom class in terms of
10751         forward_scope_exit.
10752
10753 2019-01-23  Pedro Alves  <palves@redhat.com>
10754             Andrew Burgess  <andrew.burgess@embecosm.com>
10755
10756         * common/forward-scope-exit.h: New file.
10757
10758 2019-01-23  Pedro Alves  <palves@redhat.com>
10759             Andrew Burgess  <andrew.burgess@embecosm.com>
10760             Tom Tromey  <tom@tromey.com>
10761
10762         * common/scope-exit.h: New file.
10763
10764 2019-01-23  Pedro Alves  <palves@redhat.com>
10765
10766         * common/preprocessor.h (ESC): Rename to ...
10767         (ESC_PARENS): ... this.
10768         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10769         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10770
10771 2019-01-23  Tom Tromey  <tom@tromey.com>
10772
10773         * language.h (class scoped_switch_to_sym_language_if_auto):
10774         Initialize m_lang in both cases.
10775
10776 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10777
10778         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10779         with XCNEW.
10780
10781 2019-01-22  Tom Tromey  <tom@tromey.com>
10782
10783         * corelow.c: Do not include sys/file.h.
10784
10785 2019-01-22  Tom Tromey  <tom@tromey.com>
10786
10787         * tui/tui-wingeneral.h: Include gdb_curses.h.
10788
10789 2019-01-22  Tom Tromey  <tom@tromey.com>
10790
10791         * source-cache.h (class source_cache) <get_source_lines,
10792         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10793
10794 2019-01-22  Tom Tromey  <tom@tromey.com>
10795
10796         * remote-fileio.h (struct remote_target): Declare.
10797
10798 2019-01-22  Tom Tromey  <tom@tromey.com>
10799
10800         * python/py-arch.c: Do not include py-ref.h.
10801         * python/py-bpevent.c: Do not include py-ref.h.
10802         * python/py-cmd.c: Do not include py-ref.h.
10803         * python/py-continueevent.c: Do not include py-ref.h.
10804         * python/py-event.h: Do not include py-ref.h.
10805         * python/py-evtregistry.c: Do not include py-ref.h.
10806         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10807         * python/py-frame.c: Do not include py-ref.h.
10808         * python/py-framefilter.c: Do not include py-ref.h.
10809         * python/py-function.c: Do not include py-ref.h.
10810         * python/py-infevents.c: Do not include py-ref.h.
10811         * python/py-linetable.c: Do not include py-ref.h.
10812         * python/py-objfile.c: Do not include py-ref.h.
10813         * python/py-param.c: Do not include py-ref.h.
10814         * python/py-prettyprint.c: Do not include py-ref.h.
10815         * python/py-progspace.c: Do not include py-ref.h.
10816         * python/py-symbol.c: Do not include py-ref.h.
10817         * python/py-symtab.c: Do not include py-ref.h.
10818         * python/py-type.c: Do not include py-ref.h.
10819         * python/py-unwind.c: Do not include py-ref.h.
10820         * python/py-utils.c: Do not include py-ref.h.
10821         * python/py-value.c: Do not include py-ref.h.
10822         * python/py-varobj.c: Do not include py-ref.h.
10823         * python/py-xmethods.c: Do not include py-ref.h.
10824         * python/python.c: Do not include py-ref.h.
10825         * varobj.c: Do not include py-ref.h.
10826
10827 2019-01-22  Tom Tromey  <tom@tromey.com>
10828
10829         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10830         keyword for bcache.
10831
10832 2019-01-22  Tom Tromey  <tom@tromey.com>
10833
10834         * compile/compile-cplus-types.c: Remove a comment by #include.
10835
10836 2019-01-22  Tom Tromey  <tom@tromey.com>
10837
10838         * compile/gcc-c-plugin.h: Include compile-internal.h.
10839
10840 2019-01-22  Tom Tromey  <tom@tromey.com>
10841
10842         * stabsread.c (EXTERN): Do not define.
10843         (symnum, next_symbol_text_func, processing_gcc_compilation)
10844         (within_function, global_sym_chain, global_stabs)
10845         (previous_stab_code, this_object_header_files)
10846         (n_this_object_header_files)
10847         (n_allocated_this_object_header_files): Define.
10848         * stabsread.h (EXTERN): Never define.  Use "extern".
10849
10850 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10851
10852         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10853         history_value.
10854
10855 2019-01-21  Tom Tromey  <tom@tromey.com>
10856
10857         * ui-out.c: Fix includes.
10858         * tui/tui-source.c: Fix includes.
10859         * target.c: Fix includes.
10860         * remote.c: Fix includes.
10861         * regcache.c: Fix includes.
10862         * python/py-block.c: Fix includes.
10863         * printcmd.c: Fix includes.
10864         * or1k-tdep.c: Fix includes.
10865         * mi/mi-main.c: Fix includes.
10866         * m32r-tdep.c: Fix includes.
10867         * csky-tdep.c: Fix includes.
10868         * compile/compile-cplus-types.c: Fix includes.
10869         * cli/cli-interp.c: Fix includes.
10870
10871 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10872
10873         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10874         for padding.
10875
10876 2019-01-16  Tom Tromey  <tom@tromey.com>
10877
10878         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10879         earlier.
10880         (struct objfile) <msymbols_range>: Move from top level.
10881         <msymbols>: New method.
10882         (class objfile_msymbols): Remove.
10883         * symtab.c (default_collect_symbol_completion_matches_break_on):
10884         Update.
10885         * symmisc.c (dump_msymbols): Update.
10886         * stabsread.c (scan_file_globals): Update.
10887         * objc-lang.c (info_selectors_command, info_classes_command)
10888         (find_methods): Update.
10889         * minsyms.c (find_solib_trampoline_target): Update.
10890         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10891         * coffread.c (coff_symfile_read): Update.
10892         * ada-lang.c (ada_lookup_simple_minsym)
10893         (ada_collect_symbol_completion_matches): Update.
10894
10895 2019-01-16  Tom Tromey  <tom@tromey.com>
10896
10897         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10898         type.  Remove no-argument constructor.
10899         <iterator::operator++>: Simplify.
10900         <begin>: Update.
10901         <end>: Use minimal_symbol_count.
10902
10903 2019-01-16  Tom Tromey  <tom@tromey.com>
10904
10905         * objfiles.h (struct objfile) <psymtabs>: New method.
10906         (class objfile_psymtabs): Remove.
10907         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10908         typedef.
10909         <range>: New method.
10910         (require_partial_symbols): Change return type.
10911         * psymtab.c (require_partial_symbols)
10912         (psym_expand_symtabs_matching): Update.
10913         * mdebugread.c (parse_partial_symbols): Update.
10914         * dbxread.c (dbx_end_psymtab): Update.
10915
10916 2019-01-15  Tom Tromey  <tom@tromey.com>
10917
10918         * symtab.c (lookup_objfile_from_block)
10919         (lookup_symbol_in_objfile_symtabs)
10920         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10921         (find_line_symtab, info_sources_command)
10922         (default_collect_symbol_completion_matches_break_on)
10923         (make_source_files_completion_list): Update.
10924         * symmisc.c (print_objfile_statistics, dump_objfile)
10925         (maintenance_print_symbols, maintenance_info_symtabs)
10926         (maintenance_check_symtabs, maintenance_info_line_tables):
10927         Update.
10928         * source.c (select_source_symtab)
10929         (forget_cached_source_info_for_objfile): Update.
10930         * objfiles.h (class objfile_compunits): Remove.
10931         (struct objfile) <compunits_range>: New typedef.
10932         (compunits): New method.
10933         * objfiles.c (objfile_relocate1): Update.
10934         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10935         * maint.c (count_symtabs_and_blocks): Update.
10936         * linespec.c (iterate_over_all_matching_symtabs): Update.
10937         * cp-support.c (add_symbol_overload_list_qualified): Update.
10938         * coffread.c (coff_symtab_read): Update.
10939         * ada-lang.c (add_nonlocal_symbols)
10940         (ada_collect_symbol_completion_matches)
10941         (ada_add_global_exceptions): Update.
10942
10943 2019-01-15  Tom Tromey  <tom@tromey.com>
10944
10945         * progspace.h (program_space) <objfiles_safe_range>: New
10946         typedef.
10947         <objfiles_safe>: New method.
10948         * objfiles.h (class all_objfiles_safe): Remove.
10949         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10950         * jit.c (jit_inferior_exit_hook): Update.
10951
10952 2019-01-17  Tom Tromey  <tom@tromey.com>
10953
10954         * progspace.h (program_space) <objfiles_range>: New typedef.
10955         <objfiles>: New method.
10956         <objfiles_head>: Rename from objfiles.
10957         (object_files): Update.
10958         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10959         * guile/scm-pretty-print.c
10960         (ppscm_find_pretty_printer_from_objfiles): Update.
10961         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10962         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10963         Update.
10964         * python/py-progspace.c (pspy_get_objfiles): Update.
10965         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10966         Update.
10967         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10968         (objfpy_lookup_objfile_by_build_id): Update.
10969         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10970         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10971         Update.
10972         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10973         (expand_symtab_containing_pc, lookup_objfile_from_block)
10974         (lookup_static_symbol, basic_lookup_transparent_type)
10975         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10976         (find_line_symtab, info_sources_command)
10977         (default_collect_symbol_completion_matches_break_on)
10978         (make_source_files_completion_list, find_main_name): Update.
10979         * symmisc.c (print_symbol_bcache_statistics)
10980         (print_objfile_statistics, maintenance_print_symbols)
10981         (maintenance_print_msymbols, maintenance_print_objfiles)
10982         (maintenance_info_symtabs, maintenance_check_symtabs)
10983         (maintenance_expand_symtabs, maintenance_info_line_tables):
10984         Update.
10985         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10986         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10987         (map_overlay_command, unmap_overlay_command)
10988         (simple_overlay_update, expand_symtabs_matching)
10989         (map_symbol_filenames): Update.
10990         * symfile-debug.c (set_debug_symfile): Update.
10991         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10992         Update.
10993         * source.c (select_source_symtab, forget_cached_source_info):
10994         Update.
10995         * solib.c (solib_read_symbols): Update.
10996         * solib-spu.c (append_ocl_sos): Update.
10997         * psymtab.c (maintenance_print_psymbols)
10998         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10999         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11000         * printcmd.c (info_symbol_command): Update.
11001         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11002         Update.
11003         * objfiles.h (class all_objfiles): Remove.
11004         * objfiles.c (have_partial_symbols, have_full_symbols)
11005         (have_minimal_symbols, qsort_cmp, update_section_map)
11006         (shared_objfile_contains_address_p)
11007         (default_iterate_over_objfiles_in_search_order): Update.
11008         * objc-lang.c (info_selectors_command, info_classes_command)
11009         (find_methods): Update.
11010         * minsyms.c (find_solib_trampoline_target): Update.
11011         * maint.c (maintenance_info_sections)
11012         (maintenance_translate_address, count_symtabs_and_blocks):
11013         Update.
11014         * main.c (captured_main_1): Update.
11015         * linux-thread-db.c (try_thread_db_load_from_pdir)
11016         (has_libpthread): Update.
11017         * linespec.c (iterate_over_all_matching_symtabs)
11018         (search_minsyms_for_name): Update.
11019         * jit.c (jit_find_objf_with_entry_addr): Update.
11020         * hppa-tdep.c (find_unwind_entry)
11021         (hppa_lookup_stub_minimal_symbol): Update.
11022         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11023         Update.
11024         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11025         (elf_gnu_ifunc_resolve_by_got): Update.
11026         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11027         * dwarf-index-write.c (save_gdb_index_command): Update.
11028         * cp-support.c (add_symbol_overload_list_qualified): Update.
11029         * breakpoint.c (create_overlay_event_breakpoint)
11030         (create_longjmp_master_breakpoint)
11031         (create_std_terminate_master_breakpoint)
11032         (create_exception_master_breakpoint): Update.
11033         * blockframe.c (find_pc_partial_function): Update.
11034         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11035         (ada_collect_symbol_completion_matches)
11036         (ada_add_global_exceptions): Update.
11037
11038 2019-01-17  Tom Tromey  <tom@tromey.com>
11039
11040         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11041         declare VEC.
11042         (solib_target_parse_libraries): Change return type.
11043         (library_list_start_segment, library_list_start_section)
11044         (library_list_end_library, library_list_start_library); Update.
11045         (solib_target_free_library_list): Remove.
11046         (solib_target_parse_libraries): Remove cleanup.  Change return
11047         type.
11048         (solib_target_current_sos): Update.
11049
11050 2019-01-17  Tom Tromey  <tromey@bapiya>
11051
11052         * valprint.c: Replace "the the" with "the".
11053         * symtab.c: Replace "the the" with "the".
11054         * solib.c: Replace "the the" with "the".
11055         * solib-dsbt.c: Replace "the the" with "the".
11056         * linespec.c: Replace "the the" with "the".
11057         * dwarf2loc.h: Replace "the the" with "the".
11058         * amd64-windows-tdep.c: Replace "the the" with "the".
11059         * aarch64-tdep.c: Replace "the the" with "the".
11060
11061 2019-01-16  Keith Seitz  <keiths@redhat.com>
11062
11063         PR gdb/23773
11064         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11065         <builder>: Rename to ..
11066         <m_builder>: ... this and make private.
11067         (dwarf2_cu::get_builder): New method.  Change all users of
11068         `builder' to use this method.
11069         (dwarf2_start_symtab): Move to ...
11070         (dwarf2_cu::start_symtab): ... here.  Update all callers
11071         (setup_type_unit_groups): Move to ...
11072         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11073         callers.
11074         (dwarf2_cu::reset_builder): New method.
11075         (process_full_compunit, process_full_type_unit): Use
11076         dwarf2_cu::reset_builder.
11077         (follow_die_offset): Record the ancestor CU if it is different
11078         from the followed DIE's CU.
11079         (follow_die_sig_1): Likewise.
11080
11081 2019-01-15  Tom Tromey  <tom@tromey.com>
11082
11083         * remote.c (class remote_state) <buf>: Now a char_vector.
11084         <buf_size>: Remove.
11085         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11086         parameter.
11087         (remote_target::getpkt_or_notif_sane_1)
11088         (remote_target::getpkt_sane)
11089         (remote_target::getpkt_or_notif_sane): Likewise.
11090         (class remote_target) <putpkt>: New overload.
11091         (remote_target::read_frame): Change type of "buf_p".  Remove
11092         sizeof_p parameter.
11093         (packet_ok): New overload.
11094         (packet_check_result): New overload.
11095         Update all uses.
11096
11097 2019-01-14  Tom Tromey  <tom@tromey.com>
11098
11099         * remote-notif.c (handle_notification, remote_notif_ack)
11100         (remote_notif_parse): Make "buf" const.
11101         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11102         const.
11103         (remote_notif_parse, remote_notif_ack, handle_notification):
11104         Likewise.
11105         * remote.c (remote_notif_stop_parse): Make "buf" const.
11106         (remote_target::remote_parse_stop_reply): Make "buf" const.
11107         (remote_notif_stop_ack): Make "buf" const.
11108
11109 2019-01-14  Tom Tromey  <tom@tromey.com>
11110
11111         * remote.c (remote_console_output): Make parameter const.
11112
11113 2019-01-14  Tom Tromey  <tom@tromey.com>
11114
11115         * target-debug.h (target_debug_print_signals): Constify.
11116         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11117         * procfs.c (procfs_target::pass_signals): Update.
11118         * linux-nat.c (linux_nat_target::pass_signals): Update.
11119         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11120         * target-delegates.c: Rebuild.
11121         * remote.c (remote_target::program_signals): Update.
11122         (remote_target::pass_signals): Update.
11123         * target.c (target_pass_signals): Constify argument.
11124         (target_program_signals): Likewise.
11125         * target.h (struct target_ops) <pass_signals, program_signals>:
11126         Constify argument.
11127         (target_pass_signals, target_program_signals): Constify argument.
11128
11129 2019-01-14  Tom Tromey  <tom@tromey.com>
11130
11131         PR tui/28819:
11132         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11133
11134 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11135
11136         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11137         field.
11138         * rs6000-tdep.c: Include reggroups.h.
11139         (IS_V_ALIAS_PSEUDOREG): Define.
11140         (rs6000_register_name): Return names for the "vX" aliases.
11141         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11142         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11143         aliases.  Call default_register_reggroup_p for all other
11144         pseudo-registers.
11145         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11146         New functions.
11147         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11148         Handle "vX" aliases.
11149         (v_alias_pseudo_register_collect): New function.
11150         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11151         (rs6000_gdbarch_init): Initialize "vX" aliases as
11152         pseudo-registers.  Restore registration of
11153         rs6000_pseudo_register_reggroup_p with
11154         set_tdesc_pseudo_register_reggroup_p.
11155
11156 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11157
11158         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11159         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11160         set_gdbarch_num_pseudo_regs.
11161
11162 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11163
11164         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11165         Remove arg prefixname, add do_set and do_show.
11166         Add member functions set_list and show_list.
11167         * cli/cli-style.c (class cli_style_option): Update accordingly.
11168         (style_set_list): Move to file scope.
11169         (style_show_list): Likewise.
11170         (set_style): Call help_list.
11171         (show_style): Call cmd_show_list.
11172         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11173         Update to use the new macro.
11174
11175 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11176
11177         * ada-lang.c (_initialize_ada_language): Expand the help text
11178         for the "catch exception" command.
11179
11180 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11181
11182         * symtab.c (matching_obj_sections): Initialize obj,
11183         declare it closer to its usage.
11184
11185 2019-01-10  Tom Tromey  <tom@tromey.com>
11186
11187         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11188         (basic_inf_threads_range): Remove.
11189         (inf_threads_range, inf_non_exited_threads_range)
11190         (safe_inf_threads_range): Use next_adapter.
11191
11192 2019-01-10  Keith Seitz  <keiths@redhat.com>
11193
11194         PR gdb/23712
11195         PR symtab/23010
11196         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11197         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11198
11199 2019-01-10  Keith Seitz  <keiths@redhat.com>
11200
11201         PR gdb/23712
11202         PR symtab/23010
11203         * dictionary.c (pending_to_vector): Remove.
11204         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11205         Remove _1 suffix, replacing functions of the same name.  Update
11206         all callers.
11207         (dict_create_hashed, dict_create_hashed_expandable)
11208         (dict_create_linear, dict_create_linear_expandable, dict_free)
11209         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11210         Make functions static.
11211
11212 2019-01-10  Keith Seitz  <keiths@redhat.com>
11213
11214         PR gdb/23712
11215         PR symtab/23010
11216         * dictionary.h (struct dictionary): Replace declaration with
11217         multidictionary.
11218         (dict_create_hashed, dict_create_hashed_expandable)
11219         (dict_create_linear, dict_create_linear_expandable)
11220         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11221         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11222         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11223         taking multidictionary argument.
11224         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11225         * block.h (struct block) <dict>: Change to multidictionary
11226         and rename `multidict'.
11227         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11228         symmisc.c: Update all dictionary references to multidictionary.
11229
11230 2019-01-10  Keith Seitz  <keiths@redhat.com>
11231
11232         PR gdb/23712
11233         PR symtab/23010
11234         * dictionary.c: Include unordered_map.
11235         (pending_to_vector): New function.
11236         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11237         Rewrite the non-"_1" functions to take vector instead
11238         of linked list.
11239         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11240         "new" _1 versions of the same name.
11241         (multidictionary): Define.
11242         (std::hash<enum language): New definition.
11243         (collate_pending_symbols_by_language, mdict_create_hashed)
11244         (mdict_create_hashed_expandable, mdict_create_linear)
11245         (mdict_create_linear_expandable, mdict_free)
11246         (find_language_dictionary, create_new_language_dictionary)
11247         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11248         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11249         (mdict_size, mdict_empty): New functions.
11250         * dictionary.h (mdict_iterator): Define.
11251
11252 2019-01-10  Pedro Alves  <palves@redhat.com>
11253
11254         * breakpoint.c (read_uploaded_action)
11255         (create_tracepoint_from_upload): Adjust to use
11256         gdb::unique_xmalloc_ptr.
11257         * ctf.c (ctf_write_uploaded_tp):
11258         (SET_ARRAY_FIELD): Use emplace_back.
11259         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11260         * tracefile-tfile.c (tfile_write_uploaded_tp):
11261         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11262         gdb::unique_xmalloc_ptr.
11263         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11264         at_string, cond_string, cmd_strings>: Replace char pointers
11265         with gdb::unique_xmalloc_ptr.
11266
11267 2019-01-10  Pedro Alves  <palves@redhat.com>
11268
11269         * solib-target.c (library_list_start_library): Don't xstrdup name.
11270
11271 2019-01-10  Pedro Alves  <palves@redhat.com>
11272
11273         * mdebugread.c (parse_partial_symbols): Use
11274         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11275
11276 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11277
11278         * linux-fork.c (scoped_switch_fork_info)
11279         <~scoped_switch_fork_info>: Fix incorrect variable name.
11280
11281 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11282
11283         * linux-fork.c (scoped_switch_fork_info)
11284         <scoped_switch_fork_info>: Make explicit.
11285         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11286
11287 2019-01-10  Tom Tromey  <tom@tromey.com>
11288
11289         * objfiles.h (objfile::reset_psymtabs): Update.
11290         * objfiles.c (objfile::objfile): Update.
11291         * psymtab.h (psymtab_storage::obstack): Update.
11292         (psymtab_storage::m_obstack): Use gdb::optional.
11293         (class psymtab_storage): Update comment.  Remove objfile
11294         parameter.
11295         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11296
11297 2019-01-10  Tom Tromey  <tom@tromey.com>
11298
11299         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11300         <free_psymtabs>: Now private.
11301         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11302         (allocate_psymtab): Use new method.
11303
11304 2019-01-10  Tom Tromey  <tom@tromey.com>
11305
11306         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11307         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11308         * mdebugread.c (parse_partial_symbols): Use
11309         allocate_dependencies.
11310         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11311         allocate_dependencies.
11312         (process_psymtab_comp_unit_reader)
11313         (build_type_psymtab_dependencies): Likewise.
11314         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11315
11316 2019-01-10  Tom Tromey  <tom@tromey.com>
11317
11318         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11319         PSYMBOL_SET_LANGUAGE.
11320         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11321
11322 2019-01-10  Tom Tromey  <tom@tromey.com>
11323
11324         * psymtab.h (psymtab_storage::obstack): New method.
11325         <m_obstack>: Rename from obstack; now private.
11326         * psymtab.c (psymtab_storage): Update.
11327         * dwarf2read.c (create_addrmap_from_index)
11328         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11329         Update.
11330
11331 2019-01-10  Tom Tromey  <tom@tromey.com>
11332
11333         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11334         * objfiles.h (objfile::reset_psymtabs): New method.
11335
11336 2019-01-10  Tom Tromey  <tom@tromey.com>
11337
11338         * symmisc.c (print_symbol_bcache_statistics): Update.
11339         (print_objfile_statistics): Update.
11340         * symfile.c (reread_symbols): Update.
11341         * psymtab.h (class psymtab_storage): New.
11342         * psymtab.c (psymtab_storage): New constructor.
11343         (~psymtab_storage): New destructor.
11344         (require_partial_symbols): Update.
11345         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11346         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11347         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11348         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11349         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11350         (start_psymtab_common, end_psymtab_common)
11351         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11352         (allocate_psymtab): Update.
11353         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11354         Update.
11355         (dump_psymtab_addrmap, maintenance_print_psymbols)
11356         (maintenance_check_psymtabs): Update.
11357         (class objfile_psymtabs): Move to objfiles.h.
11358         * psympriv.h (discard_psymtab): Now inline.
11359         (psymtab_discarder::psymtab_discarder): Update.
11360         (psymtab_discarder::~psymtab_discarder): Update.
11361         (ALL_OBJFILE_PSYMTABS): Rewrite.
11362         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11363         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11364         Remove fields.
11365         <partial_symtabs>: New field.
11366         (class objfile_psymtabs): Move from psymtab.h.  Update.
11367         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11368         psymbol_cache.
11369         (objfile::~objfile): Don't destroy psymbol_cache.
11370         * mdebugread.c (parse_partial_symbols): Update.
11371         * dwarf2read.c (create_addrmap_from_index)
11372         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11373         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11374         (add_partial_subprogram, dwarf2_ranges_read): Update.
11375         * dwarf-index-write.c (write_address_map)
11376         (write_one_signatured_type, recursively_write_psymbols)
11377         (class debug_names, class debug_names, write_psymtabs_to_index):
11378         Update.
11379
11380 2019-01-10  Tom Tromey  <tom@tromey.com>
11381
11382         * symtab.h (SYMBOL_SET_NAMES): Update.
11383         (symbol_set_names): Update.
11384         (MSYMBOL_SET_NAMES): Update.
11385         * symtab.c (symbol_set_names): Change argument to be an
11386         objfile_per_bfd_storage.
11387         * psymtab.c (add_psymbol_to_bcache): Update.
11388         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11389
11390 2019-01-10  Tom Tromey  <tom@tromey.com>
11391
11392         * symtab.c (create_demangled_names_hash): Change argument to be an
11393         objfile_per_bfd_storage.
11394         (symbol_set_names): Update.
11395
11396 2019-01-10  Tom Tromey  <tom@tromey.com>
11397
11398         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11399         init_psymbol_list.
11400         * psymtab.c (init_psymbol_list): Do nothing if already called.
11401         * psympriv.h (init_psymbol_list): Add comment.
11402         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11403         init_psymbol_list.
11404         * dbxread.c (dbx_symfile_read): Unconditionally call
11405         init_psymbol_list.
11406
11407 2019-01-10  Tom Tromey  <tom@tromey.com>
11408
11409         * xcoffread.c (scan_xcoff_symtab): Update.
11410         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11411         "where".
11412         * mdebugread.c (parse_partial_symbols)
11413         (handle_psymbol_enumerators): Update.
11414         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11415         * dbxread.c (read_dbx_symtab): Update.
11416         * psympriv.h (psymbol_placement): New enum.
11417         (add_psymbol_to_list): Update.
11418
11419 2019-01-10  Tom Tromey  <tom@tromey.com>
11420
11421         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11422         static_psymbols parameters.
11423         (scan_xcoff_symtab): Update.
11424         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11425         static_psymbols parameters.
11426         * psympriv.h (start_psymtab_common): Update.
11427         * mdebugread.c (parse_partial_symbols): Update.
11428         * dwarf2read.c (create_partial_symtab): Update.
11429         * dbxread.c (read_dbx_symtab): Update.
11430         (start_psymtab): Remove global_psymbols and static_psymbols
11431         parameters.
11432
11433 2019-01-10  Tom Tromey  <tom@tromey.com>
11434
11435         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11436         * psymtab.c (allocate_psymtab): Add comment.
11437         * psympriv.h (allocate_psymtab): Add comment.
11438         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11439         initializations.
11440         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11441
11442 2019-01-10  Tom Tromey  <tom@tromey.com>
11443
11444         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11445         Don't declare.
11446         * mipsread.c: Include mdebugread.h.
11447         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11448         Declare.
11449         * elfread.c: Include mdebugread.h.
11450
11451 2019-01-09  Tom Tromey  <tom@tromey.com>
11452
11453         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11454         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11455         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11456         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11457         (psym_lookup_symbol, psym_find_last_source_symtab)
11458         (psym_forget_cached_source_info, psym_print_stats)
11459         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11460         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11461         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11462         (psym_find_compunit_symtab_by_address)
11463         (maintenance_print_psymbols, maintenance_info_psymtabs)
11464         (maintenance_check_psymtabs): Use ranged for.
11465         * psymtab.h (class objfile_psymtabs): New.
11466         (require_partial_symbols): Return objfile_psymtabs.
11467         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11468
11469 2019-01-09  Tom Tromey  <tom@tromey.com>
11470
11471         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11472         (find_pc_mapped_section, list_overlays_command)
11473         (map_overlay_command, unmap_overlay_command)
11474         (simple_overlay_update): Use all_objfiles.
11475         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11476         * printcmd.c (info_symbol_command): Use all_objfiles.
11477         * objfiles.h (ALL_OBJSECTIONS): Remove.
11478         * maint.c (maintenance_translate_address): Use all_objfiles.
11479         * gcore.c (gcore_create_callback): Use all_objfiles.
11480         (objfile_find_memory_regions): Likewise.
11481
11482 2019-01-09  Tom Tromey  <tom@tromey.com>
11483
11484         * symtab.c (find_line_symtab, info_sources_command)
11485         (make_source_files_completion_list): Use objfile_compunits.
11486         * source.c (select_source_symtab): Use objfile_compunits.
11487         * objfiles.h (struct objfile): Update comment.
11488         (ALL_OBJFILES): Remove.
11489         (ALL_FILETABS): Remove.
11490         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11491         objfile_compunits.
11492
11493 2019-01-09  Tom Tromey  <tom@tromey.com>
11494
11495         * symmisc.c (print_objfile_statistics, dump_objfile)
11496         (maintenance_print_symbols): Use compunit_filetabs.
11497         * source.c (forget_cached_source_info_for_objfile): Use
11498         compunit_filetabs.
11499         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11500         (ALL_FILETABS): Use compunit_filetabs.
11501         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11502         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11503
11504 2019-01-09  Tom Tromey  <tom@tromey.com>
11505
11506         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11507         (compunit_filetabs): New.
11508         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11509         compunit_filetabs.
11510         (info_sources_command, make_source_files_completion_list): Remove
11511         declaration.
11512         * symmisc.c (print_objfile_statistics, dump_objfile)
11513         (maintenance_print_symbols): Remove declaration.
11514         (maintenance_info_symtabs): Use compunit_filetabs.
11515         (maintenance_info_line_tables): Likewise.
11516         * source.c (select_source_symtab): Change local variable name.
11517         (forget_cached_source_info_for_objfile): Remove declaration.
11518         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11519         * objfiles.c (objfile_relocate1): Remove declaration.
11520         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11521         declaration.
11522         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11523         * coffread.c (coff_symtab_read): Remove declaration.
11524         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11525         compunit_filetabs.
11526
11527 2019-01-09  Tom Tromey  <tom@tromey.com>
11528
11529         * symtab.c (lookup_objfile_from_block)
11530         (find_pc_sect_compunit_symtab, search_symbols)
11531         (default_collect_symbol_completion_matches_break_on): Use
11532         objfile_compunits.
11533         * objfiles.h (ALL_COMPUNITS): Remove.
11534         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11535         * cp-support.c (add_symbol_overload_list_qualified): Use
11536         objfile_compunits.
11537         * ada-lang.c (ada_collect_symbol_completion_matches)
11538         (ada_add_global_exceptions): Use objfile_compunits.
11539
11540 2019-01-09  Tom Tromey  <tom@tromey.com>
11541
11542         * source.c (select_source_symtab)
11543         (forget_cached_source_info_for_objfile): Remove declaration.
11544         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11545         declaration.
11546         * maint.c (count_symtabs_and_blocks): Remove declaration.
11547         * cp-support.c (add_symbol_overload_list_qualified): Remove
11548         declaration.
11549         * coffread.c (coff_symtab_read): Remove declaration.
11550         * symtab.c (lookup_symbol_in_objfile_symtabs)
11551         (basic_lookup_transparent_type_1): Use objfile_compunits.
11552         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11553         (info_sources_command, search_symbols)
11554         (default_collect_symbol_completion_matches_break_on)
11555         (make_source_files_completion_list): Remove declaration.
11556         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11557         (ada_collect_symbol_completion_matches)
11558         (ada_add_global_exceptions): Remove declaration.
11559         * linespec.c (iterate_over_all_matching_symtabs): Use
11560         objfile_compunits.
11561         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11562         (class objfile_compunits): New.
11563         (ALL_COMPUNITS): Use objfile_compunits.
11564         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11565         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11566         objfile_compunits.
11567         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11568
11569 2019-01-09  Tom Tromey  <tom@tromey.com>
11570
11571         * symtab.c (search_symbols)
11572         (default_collect_symbol_completion_matches_break_on): Use
11573         objfile_msymbols.
11574         * ada-lang.c (ada_lookup_simple_minsym)
11575         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11576         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11577         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11578         objfile_msymbols.
11579         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11580         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11581         * objc-lang.c (find_methods): Use objfile_msymbols.
11582         (info_selectors_command, info_classes_command): Likewise.
11583         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11584         * objfiles.h (class objfile_msymbols): New.
11585         (ALL_OBJFILE_MSYMBOLS): Remove.
11586         (ALL_MSYMBOLS): Remove.
11587
11588 2019-01-09  Tom Tromey  <tom@tromey.com>
11589
11590         * common/next-iterator.h (next_adapter): Add Iterator template
11591         parameter.
11592         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11593         (class all_objfiles_safe): New.
11594         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11595         * objfiles.c (put_objfile_before): Update comment.
11596         (add_separate_debug_objfile): Likewise.
11597         (free_all_objfiles): Use all_objfiles_safe.
11598         (objfile_purge_solibs): Likewise.
11599
11600 2019-01-09  Tom Tromey  <tom@tromey.com>
11601
11602         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11603         (expand_symtab_containing_pc, lookup_static_symbol)
11604         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11605         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11606         all_objfiles.
11607         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11608         * breakpoint.c (create_overlay_event_breakpoint)
11609         (create_longjmp_master_breakpoint)
11610         (create_std_terminate_master_breakpoint)
11611         (create_exception_master_breakpoint): Use all_objfiles.
11612         * linux-thread-db.c (try_thread_db_load_from_pdir)
11613         (has_libpthread): Use all_objfiles.
11614         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11615         * linespec.c (iterate_over_all_matching_symtabs)
11616         (search_minsyms_for_name): Use all_objfiles.
11617         * maint.c (maintenance_info_sections): Use all_objfiles.
11618         * main.c (captured_main_1): Use all_objfiles.
11619         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11620         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11621         * guile/scm-pretty-print.c
11622         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11623         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11624         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11625         (maintenance_print_msymbols): Use all_objfiles.
11626         * source.c (select_source_symtab): Use all_objfiles.
11627         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11628         * symfile.c (remove_symbol_file_command)
11629         (expand_symtabs_matching, map_symbol_filenames): Use
11630         all_objfiles.
11631         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11632         all_objfiles.
11633         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11634         * objc-lang.c (find_methods): Use all_objfiles.
11635         * objfiles.c (have_partial_symbols, have_full_symbols)
11636         (have_minimal_symbols, qsort_cmp)
11637         (default_iterate_over_objfiles_in_search_order): Use
11638         all_objfiles.
11639         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11640         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11641         (maintenance_check_psymtabs): Use all_objfiles.
11642         (ALL_PSYMTABS): Remove.
11643         * compile/compile-object-run.c (do_module_cleanup): Use
11644         all_objfiles.
11645         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11646         * cp-support.c (add_symbol_overload_list_qualified): Use
11647         all_objfiles.
11648         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11649         Use all_objfiles.
11650         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11651         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11652         all_objfiles.
11653         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11654         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11655         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11656         Uses all_objfiles.
11657         * solib.c (solib_read_symbols): Use all_objfiles
11658
11659 2019-01-09  Tom Tromey  <tom@tromey.com>
11660
11661         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11662         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11663         all_objfiles.
11664         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11665         * symmisc.c (print_symbol_bcache_statistics)
11666         (print_objfile_statistics, maintenance_print_objfiles)
11667         (maintenance_info_symtabs, maintenance_check_symtabs)
11668         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11669         all_objfiles.
11670         * source.c (forget_cached_source_info): Use all_objfiles.
11671         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11672         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11673         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11674         * objfiles.c (update_section_map): Use all_objfiles.
11675         (shared_objfile_contains_address_p): Likewise.
11676         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11677         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11678
11679 2019-01-09  Tom Tromey  <tom@tromey.com>
11680
11681         * common/next-iterator.h: New file.
11682         * objfiles.h (class all_objfiles): New.
11683         (struct objfile_iterator): New.
11684
11685 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11686
11687         * NEWS: Move the description of the changed "frame", "select-frame",
11688          and "info frame" commands to the Changed commands section.
11689
11690 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11691
11692         * gdbtypes.c (check_stub_method_group): Remove handling of old
11693         mangling schemes.
11694         * linespec.c (find_methods): Likewise.
11695         * stabsread.c (read_member_functions): Likewise.
11696         * valops.c (search_struct_method): Likewise.
11697         (value_struct_elt_for_reference): Likewise.
11698         * NEWS: Mention this change.
11699
11700 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11701
11702         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11703         print_source_lines.
11704         * source.c (print_source_lines_base): Update line number check.
11705         (print_source_lines): New function.
11706         (source_lines_range::source_lines_range): New function.
11707         * source.h (class source_lines_range): New class.
11708         (print_source_lines): New declaration.
11709
11710 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11711
11712         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11713
11714 2019-01-08  Tom Tromey  <tom@tromey.com>
11715             Simon Marchi  <simon.marchi@ericsson.com>
11716
11717         PR gdb/24060
11718         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11719         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11720         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11721         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11722         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11723         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11724
11725 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11726
11727         * source.c (select_source_symtab): Move header comment to
11728         declaration in source.h.
11729         (forget_cached_source_info_for_objfile): Likewise.
11730         (forget_cached_source_info): Likewise.
11731         (identify_source_line): Likewise.
11732         * source.h (identify_source_line): Move declaration from symtab.h
11733         and add comment from source.c
11734         (print_source_lines): Likewise.
11735         (forget_cached_source_info_for_objfile): Likewise.
11736         (forget_cached_source_info): Likewise.
11737         (select_source_symtab): Likewise.
11738         (enum print_source_lines_flag): Move definition from symtab.h.
11739         * symtab.h (identify_source_line): Move declaration to source.h.
11740         (print_source_lines): Likewise.
11741         (forget_cached_source_info_for_objfile): Likewise.
11742         (forget_cached_source_info): Likewise.
11743         (select_source_symtab): Likewise.
11744         (enum print_source_lines_flag): Move definition to source.h.
11745         * tui/tui-hooks.c: Add 'source.h' include.
11746
11747 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11748
11749         * source.c (print_source_lines_base): Handle requests to print
11750         reverse line number sequences, and guard against empty lines
11751         string.
11752
11753 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11754
11755         * source.c (print_source_lines_base): Fix skip of '\r' if next
11756         character is '\n'.
11757
11758 2019-01-06  Tom Tromey  <tom@tromey.com>
11759
11760         * c-exp.y (struct c_parse_state) <macro_original_text,
11761         expansion_obstack>: New member.
11762         (macro_original_text, expansion_obstack): Remove globals.
11763         (scan_macro_expansion, scanning_macro_expansion)
11764         (finished_macro_expansion): Update.
11765         (scan_macro_cleanup): Remove.
11766         (yylex, c_parse): Update.
11767
11768 2019-01-06  Tom Tromey  <tom@tromey.com>
11769
11770         * c-exp.y (struct c_parse_state) <strings>: New member.
11771         (operator_stoken): Update.
11772
11773 2019-01-06  Tom Tromey  <tom@tromey.com>
11774
11775         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11776         (union type_stack_elt) <typelist_val>: Now a pointer to
11777         std::vector.
11778         (type_stack_cleanup): Don't declare.
11779         (push_typelist): Update.
11780         * parse.c (pop_typelist): Return a std::vector.
11781         (push_typelist): Take a std::vector.
11782         (follow_types): Update.  Do not free args.
11783         (type_stack_cleanup): Remove.
11784         * c-exp.y (struct c_parse_state): New.
11785         (cpstate): New global.
11786         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11787         (nonempty_typelist): Update.
11788         (func_mod): Create a new vector.
11789         (c_parse): Create a c_parse_state.
11790         (check_parameter_typelist): Do not delete params.
11791         (function_method): Update.  Do not delete type_list.
11792
11793 2019-01-06  Tom Tromey  <tom@tromey.com>
11794
11795         PR gdb/28155:
11796         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11797         check_typedef.
11798         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11799         (print_return_value): Likewise.
11800
11801 2019-01-05  Tom Tromey  <tom@tromey.com>
11802
11803         * contrib/cleanup_check.py: Remove.
11804         * contrib/gcc-with-excheck: Remove.
11805         * contrib/exsummary.py: Remove.
11806         * contrib/excheck.py: Remove.
11807
11808 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11809
11810         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11811         NULL. Initialize tpprev to NULL instead of assigning it
11812         to NULL on the next statement.
11813         * windows-nat.c (windows_delete_thread): Remove check for
11814         main_thread_id before printing thread exit notifications.
11815         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11816         Remove thread ID check against main_thread_id.
11817         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11818         windows_delete_thread.
11819         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11820
11821 2019-01-04  Tom Tromey  <tom@tromey.com>
11822
11823         * compile/compile.c (_initialize_compile): Use upper case for
11824         metasyntactic variables.
11825         * symmisc.c (_initialize_symmisc): Use upper case for
11826         metasyntactic variables.
11827         * psymtab.c (_initialize_psymtab): Use upper case for
11828         metasyntactic variables.
11829         * demangle.c (demangle_command): Use upper case for metasyntactic
11830         variables.
11831         (_initialize_demangler): Likewise.
11832         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11833         variables.
11834
11835 2019-01-03  Tom Tromey  <tom@tromey.com>
11836
11837         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11838
11839 2019-01-03  Tom Tromey  <tom@tromey.com>
11840
11841         * python/py-symtab.c (salpy_str): Update.
11842         (struct salpy_sal_object) <symtab>: Now a PyObject.
11843         (salpy_dealloc): Update.
11844         (del_objfile_sal): Use gdbpy_ref.
11845
11846 2019-01-03  Tom Tromey  <tom@tromey.com>
11847
11848         * python/py-type.c (convert_field): Use new_reference.  Return
11849         gdbpy_ref.
11850         (make_fielditem): Return gdbpy_ref.
11851         (typy_fields): Update.
11852         (typy_getitem): Update.
11853         (field_name): Return gdbpy_ref.  Use new_reference.
11854         (typy_iterator_iternext): Update.
11855
11856 2019-01-03  Tom Tromey  <tom@tromey.com>
11857
11858         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11859
11860 2019-01-03  Tom Tromey  <tom@tromey.com>
11861
11862         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11863         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11864         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11865         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11866         (pspy_set_type_printers): Likewise.
11867         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11868         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11869         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11870         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11871         (objfpy_set_type_printers): Likewise.
11872
11873 2019-01-03  Tom Tromey  <tom@tromey.com>
11874
11875         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11876         (gdbpy_print_stack): Use gdbpy_err_fetch.
11877         * python/python-internal.h (class gdbpy_err_fetch): New class.
11878         (class gdbpy_enter) <m_error_type, m_error_value,
11879         m_error_traceback>: Remove.
11880         <m_error>: New member.
11881         (gdbpy_exception_to_string): Don't declare.
11882         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11883         * python/py-value.c (convert_value_from_python): Use
11884         gdbpy_err_fetch.
11885         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11886         gdbpy_exception_to_string.
11887         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11888         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11889         gdbpy_err_fetch.
11890
11891 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11892
11893         * linux-nat.c (delete_lwp_cleanup): Delete.
11894         (struct lwp_deleter): New struct.
11895         (lwp_info_up): New typedef.
11896         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11897         lwp_info_up.
11898
11899 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11900
11901         * linux-fork.c (class scoped_switch_fork_info): New class.
11902         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11903
11904 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11905
11906         * valops.c (find_overload_match): Remove use of null_cleanup, and
11907         calls to do_cleanups.
11908
11909 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11910
11911         * compile/compile-cplus-types.c
11912         (compile_cplus_instance::decl_name): Handle changes to
11913         cp_func_name.
11914         * cp-support.c (cp_func_name): Update header comment, update
11915         return type.
11916         * cp-support.h (cp_func_name): Update return type in declaration.
11917         * valops.c (find_overload_match): Move temp_func local to top
11918         level of function and change its type.  Use temp_func to hold and
11919         delete temporary string obtained from cp_func_name.
11920
11921 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11922
11923         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11924         gdb::char_vector, remove cleanup, and update uses of `msg`.
11925
11926 2019-01-03  Jim Wilson  <jimw@sifive.com>
11927
11928         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11929
11930 2019-01-02  Tom Tromey  <tom@tromey.com>
11931
11932         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11933         (tdesc_parse_xml): Remove cleanups.
11934         * target-descriptions.h (make_cleanup_free_target_description):
11935         Don't declare.
11936         (target_desc_deleter): New struct.
11937         (target_desc_up): New typedef.
11938         * target-descriptions.c (target_desc_deleter::operator()): Rename
11939         from free_target_description.
11940         (make_cleanup_free_target_description): Remove.
11941
11942 2019-01-02  Tom Tromey  <tom@tromey.com>
11943
11944         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11945         constructor, destructor.
11946         (linespec_parser): Remove typedef.
11947         (~linespec_parser): Rename from linespec_parser_delete.
11948         (linespec_lex_to_end, linespec_complete_label)
11949         (linespec_complete): Update.
11950         (decode_line_full): Remove cleanups.
11951         (decode_line_1): Update.
11952
11953 2019-01-02  Tom Tromey  <tom@tromey.com>
11954
11955         * python/python-internal.h (inferior_to_inferior_object): Change
11956         return type.
11957         * python/py-exitedevent.c (create_exited_event_object): Update.
11958         * python/py-inferior.c (inferior_to_inferior_object): Return
11959         gdbpy_ref.
11960         (python_new_inferior, python_inferior_deleted)
11961         (thread_to_thread_object, delete_thread_object)
11962         (build_inferior_list, gdbpy_selected_inferior): Update.
11963         * python/py-infthread.c (create_thread_object): Update.  Also fail
11964         if inferior_to_inferior_object fails.
11965
11966 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11967
11968         * inferior.h (class inferior) <displaced_step_state>: New field.
11969         * infrun.h (struct displaced_step_state): Move here from
11970         infrun.c.  Initialize fields, add constructor.
11971         <inf>: Remove field.
11972         <reset>: New method.
11973         * infrun.c (struct displaced_step_inferior_state): Move to
11974         infrun.h.
11975         (displaced_step_inferior_states): Remove.
11976         (get_displaced_stepping_state): Adust.
11977         (displaced_step_in_progress_any_inferior): Adjust.
11978         (displaced_step_in_progress_thread): Adjust.
11979         (displaced_step_in_progress): Adjust.
11980         (add_displaced_stepping_state): Remove.
11981         (get_displaced_step_closure_by_addr): Adjust.
11982         (remove_displaced_stepping_state): Remove.
11983         (infrun_inferior_exit): Call displaced_step_state.reset.
11984         (use_displaced_stepping): Don't check for NULL.
11985         (displaced_step_prepare_throw): Call
11986         get_displaced_stepping_state.
11987         (displaced_step_fixup): Don't check for NULL.
11988         (prepare_for_detach): Don't check for NULL.
11989
11990 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11991
11992         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11993          in case of call that did not complete.
11994
11995 2019-01-02  Andrey Utkin  <autkin@undo.io>
11996
11997         * symfile.c (find_separate_debug_file): Fix search of debug files for
11998         remote debuggee.
11999
12000 2019-01-02  Tom Tromey  <tom@tromey.com>
12001
12002         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12003         indentation.
12004         * python/py-frame.c (frapy_older): Remove cast.
12005         (frapy_newer): Likewise.
12006         * python/py-breakpoint.c (local_setattro): Remove cast.
12007         * python/py-arch.c (archpy_name): Remove local variable.
12008         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12009
12010 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12011
12012         * unittests/basic_string_view/element_access/char/empty.cc:
12013         Fix year range in copyright header.
12014
12015 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12016
12017         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12018         Delete.
12019         <operator==>: Update with for removed field.
12020         <hash>: Likewise.
12021         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12022         <isa_features>: ...this.
12023         <abi_features>: New field.
12024         (riscv_isa_flen): Update comment.
12025         (riscv_abi_xlen): New declaration.
12026         (riscv_abi_flen): New declaration.
12027         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12028         isa_features.
12029         (riscv_abi_xlen): New function.
12030         (riscv_isa_flen): Update to get answer from isa_features.
12031         (riscv_abi_flen): New function.
12032         (riscv_has_fp_abi): Update to get answer from abi_features.
12033         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12034         xlen and flen.
12035         (riscv_call_info) <xlen, flen>: Update comment.
12036         (riscv_call_arg_struct): Remove invalid assertions
12037         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12038         is removed.
12039         (riscv_gdbarch_init): Gather isa features and abi features
12040         separately, ensure both match on the gdbarch when reusing an old
12041         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12042         a target with 64-bit float hardware.
12043
12044 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12045
12046         * source.c (search_command_helper): Stop reverse search
12047         when line 1 has been searched.
12048
12049 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12050
12051         * record-full.c (record_full_base_target::close): Rewrite
12052         record_full_core_buf_list free logic.
12053
12054 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12055
12056         * break-catch-syscall.c (print_one_catch_syscall): xfree
12057         the last text.
12058
12059 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12060
12061         * top.c (print_gdb_version): Update Copyright year in version
12062         message.
12063
12064 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12065
12066         Update copyright year range in all GDB files.
12067
12068 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12069
12070         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12071
12072 For older changes see ChangeLog-2018.
12073 \f
12074 Local Variables:
12075 mode: change-log
12076 left-margin: 8
12077 fill-column: 74
12078 version-control: never
12079 coding: utf-8
12080 End:
12081