gdb/ChangeLog

   1 2019-06-10  Tom de Vries  <tdevries@suse.de>
   2
   3         PR gdb/24618
   4         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
   5         sure an empty slot (defined by a 32-bit zero pair) is recognized as
   6         invalid.
   7
   8 2019-06-10  Tom de Vries  <tdevries@suse.de>
   9
  10         PR gdb/24611
  11         * linespec.c (linespec_lexer_lex_string): Remove incorrect
  12         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
  13
  14 2019-06-10  Tom de Vries  <tdevries@suse.de>
  15
  16         PR symtab/24545
  17         * symtab.c (struct demangled_name_entry): Add language field.
  18         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
  19         static minimal symbol".  Set and use language field.
  20
  21 2019-06-10  Tom Tromey  <tromey@adacore.com>
  22
  23         * ada-lang.c (_initialize_ada_language): Update help text.
  24
  25 2019-06-10  Tom Tromey  <tromey@adacore.com>
  26
  27         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
  28         with a newline.
  29         * guile/guile.c (handle_boot_error): Don't end warning with a
  30         newline.
  31         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
  32         warning with a newline.
  33         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
  34         newline.
  35         (s12z_frame_cache): Likewise.
  36         * dwarf-index-cache.c (index_cache::store): Don't end warning with
  37         a newline.
  38         * solib-svr4.c (disable_probes_interface): Don't end warning with
  39         a newline.
  40         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
  41         newline.
  42         * python/python.c (do_finish_initialization): Don't end warning
  43         with a newline.
  44
  45 2019-06-10  Tom Tromey  <tom@tromey.com>
  46
  47         * python/py-breakpoint.c (gdbpy_breakpoint_created)
  48         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
  49         gdbpy_enter.
  50
  51 2019-06-10  Tom Tromey  <tromey@adacore.com>
  52
  53         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
  54         data.
  55         (elf_new_init): Don't call stabsread_new_init.
  56         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
  57         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
  58         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
  59
  60 2019-06-10  Tom de Vries  <tdevries@suse.de>
  61
  62         PR symtab/16264
  63         PR symtab/24517
  64         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
  65
  66 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
  67
  68         * source.c (find_and_open_source): Also rewrite relative file
  69         names.
  70
  71 2019-04-26  Amos Bird  <amosbird@gmail.com>
  72
  73         * annotate.c (annotate_thread_exited): Add "thread-exited"
  74         annotation.
  75
  76 2019-06-06  Tom Tromey  <tromey@adacore.com>
  77
  78         * maint.h (class scoped_command_stats): Use
  79         DISABLE_COPY_AND_ASSIGN.
  80         <print_time>: New method.
  81         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
  82         print_time.
  83         (scoped_command_stats::print_time): New method.
  84
  85 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
  86
  87         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
  88         instructions of lengths 6 or 8 bytes.
  89
  90 2019-06-04  Pedro Alves  <palves@redhat.com>
  91
  92         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
  93
  94         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
  95         * breakpoint.c (condition_completer): Likewise.
  96         * cli/cli-dump.c (scan_expression): Likewise.
  97         * common/filestuff.c (mkdir_recursive): Likewise.
  98         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
  99         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 100         (gdb_abspath): Likewise.
 101         * compile/compile-cplus-types.c
 102         (compile_cplus_instance::decl_name): Likewise.
 103         * completer.c (complete_explicit_location):
 104         (signal_completer, reg_or_group_completer_1): Likewise.
 105         * cp-support.c (cp_remove_params_if_any): Likewise.
 106         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 107         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 108         * infcmd.c (strip_bg_char): Likewise.
 109         * linespec.c (copy_token_string): Likewise.
 110         * mi/mi-main.c (output_cores): Likewise.
 111         * psymtab.c (psymtab_search_name):
 112         * symfile.c (test_set_ext_lang_command): Likewise.
 113         * target.c (target_fileio_read_stralloc): Likewise.
 114         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 115         * value.c (complete_internalvar): Likewise.
 116
 117 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 118
 119         Add objfile property to gdb.Type.
 120         * NEWS: Mention Python API addition.
 121         * python/py-type.c (typy_get_objfile): New method.
 122
 123 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 124
 125         * NEWS: Mention the new set|show style [title|highlight].
 126         Mention changes to "show style", "help" and "apropos".
 127
 128 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 129
 130         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 131         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 132         instead of print_help_for_command.
 133         (print_doc_of_command): New function.
 134         (help_list): Add 'apropos -v word' suggestion.
 135         (print_help_for_command): Style the command name using title style.
 136         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 137         (_initialize_cli_cmds): Describe -v in apropos_command help.
 138
 139 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 140
 141         * cli/cli-style.h (cli_style_option): Add name in constructor,
 142         add m_name class member, add constructor with intensity,
 143         add name class function.
 144         (cli_style_option::add_setshow_commands): Remove name argument.
 145         (highlight_style, title_style): New styles.
 146         * cli/cli-style.c (do_show): New function that shows a style
 147         characteristic styling the style name with itself.
 148         (set_style_name): New function.
 149         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 150         Update all callers according to the changes in cli/cli-style.h.
 151         * utils.h (fputs_highlighted): New function.
 152         * utils.c (fputs_highlighted): Likewise.
 153
 154 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 155
 156         * NEWS: Mention new pipe command and new convenience variables.
 157
 158 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 159
 160         * cli/cli-cmds.c (pipe_command): New function.
 161         (_initialize_cli_cmds): Call add_com for pipe_command.
 162         Define | as an alias for pipe.
 163         (exit_status_set_internal_vars): New function.
 164         (shell_escape): Call exit_status_set_internal_vars.
 165         cli/cli-decode.c (find_command_name_length): Recognize | as
 166         a single character command.
 167
 168 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 169
 170         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 171         top.c (execute_command_to_ui_file): New function, mostly a copy
 172         of execute_command_to_string.
 173         (execute_command_to_string): Implement by calling
 174         execute_command_to_ui_file.
 175
 176 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 177
 178         * top.h (saved_command_line): Remove declaration.
 179         * top.c (previous_saved_command_line, previous_repeat_arguments):
 180         New variables.
 181         (saved_command_line): Make static, define together with other
 182         'repeat variables'.
 183         (dont_repeat): Clear repeat_arguments.
 184         (repeat_previous, get_saved_command_line, save_command_line):
 185         New functions.
 186         (gdb_init): Initialize saved_command_line
 187         and previous_saved_command_line.
 188         * main.c (captured_main_1): Remove saved_command_line initialization.
 189         * event-top.c (handle_line_of_input): Update to use
 190         the new 'repeat' related functions instead of direct access to
 191         saved_command_line.
 192         * command.h (repeat_previous, get_saved_command_line,
 193         save_command_line): New declarations.
 194         (dont_repeat): Add comment.
 195
 196 2019-05-30  Tom Tromey  <tromey@adacore.com>
 197
 198         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 199         Fix comment.
 200         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 201
 202 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 203
 204         PR cli/24587
 205         * completer.c (complete): Initialize variable word.
 206
 207 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 208
 209         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 210         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 211         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 212         'body' is NULL to the outter 'if', protecting the '!is_define'
 213         situation as well.
 214
 215 2019-05-29  Tom Tromey  <tromey@adacore.com>
 216
 217         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 218         (dwarf_unknown): New function.
 219         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 220         (dwarf_type_encoding_name): Use dwarf_unknown.
 221
 222 2019-05-29  Tom Tromey  <tromey@adacore.com>
 223
 224         PR c++/20020:
 225         * cp-valprint.c (cp_print_value_fields): Call
 226         cp_print_static_field inside "try".
 227
 228 2019-05-29  Tom Tromey  <tromey@adacore.com>
 229
 230         * inflow.c (struct terminal_info): Add default operator=.
 231         * configure: Rebuild.
 232         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 233         -Wdeprecated-copy-dtor, -Wredundant-move.
 234
 235 2019-05-29  Tom Tromey  <tromey@adacore.com>
 236
 237         * NEWS: Add entry.
 238         * infcmd.c (print_return_value_1): Handle finish_print
 239         option.
 240         (show_print_finish): New function.
 241         (_initialize_infcmd): Add "set/show print finish" commands.
 242         * valprint.c (user_print_options): Initialize new member.
 243         * valprint.h (struct value_print_options) <finish_print>: New
 244         member.
 245
 246 2019-05-28  Tom Tromey  <tromey@adacore.com>
 247
 248         * ada-lang.c (ada_remove_Xbn_suffix)
 249         (find_old_style_renaming_symbol)
 250         (parse_old_style_renaming): Remove.
 251         (ada_find_renaming_symbol): Don't call
 252         find_old_style_renaming_symbol.
 253         (ada_is_renaming_symbol): Rename from
 254         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 255         bool.  Now static.
 256         (ada_read_var_value): Update and simplify.
 257         * ada-exp.y (write_var_or_type): Remove old code.
 258
 259 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 260
 261         * event-top.c: Remove include comment.
 262         * inflow.c (class scoped_ignore_sigttou): Move from here...
 263         * inflow.h (class scoped_ignore_sigttou): ...to here.
 264         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 265         * top.c:  Remove include comment.
 266
 267 2019-05-27  Tom Tromey  <tom@tromey.com>
 268
 269         * NEWS: Fix typo.
 270
 271 2019-05-22  Tom Tromey  <tromey@adacore.com>
 272
 273         * target.c (target_follow_exec): Constify parameter.
 274         * target-delegates.c: Rebuild.
 275         * remote.c (remote_target::follow_exec): Constify parameter.
 276         * infrun.c (follow_exec): Constify parameter.
 277         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 278         (target_follow_exec): Likewise.
 279
 280 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 281
 282         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 283         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 284
 285 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 286
 287         * NEWS: Add debugredirect and testsuite sections.
 288
 289 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 290
 291         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 292         target descriptions using exclusively floating point register name
 293         aliases.
 294
 295 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 296
 297         PR gdb/18644:
 298         * f-lang.c (build_fortran_types): Handle the case where
 299         gdbarch_floatformat_for_type returns a nullptr.
 300
 301 2019-05-21  Tom de Vries  <tdevries@suse.de>
 302
 303         PR cli/24587
 304         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 305
 306 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 307
 308         PR gdb/18644:
 309         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 310         16-byte floats.
 311         * i386-tdep.c (i386_floatformat_for_type): Use
 312         floatformats_ia64_quad for the 16-byte floating point component
 313         within a fortran 32-byte complex number.
 314
 315 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 316
 317         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 318         delete default constructor.
 319         (find_partial_die): Update to return const struct.
 320         (partial_die_parent_scope): Move variable declaration into scope
 321         of its use and change its type to auto.
 322         (guess_partial_die_structure_name): Likewise.
 323         (partial_die_info::fixup): Likewise.
 324
 325 2019-05-17  Tom Tromey  <tromey@adacore.com>
 326
 327         * source.c (find_and_open_source): Remove cast.
 328
 329 2019-05-17  Tom Tromey  <tromey@adacore.com>
 330
 331         * annotate.c (annotate_source): Make "filename" const.
 332         * annotate.h (annotate_source): Use const.
 333
 334 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 335
 336         * disasm.c (set_disassembler_options): Send errors to stderr.
 337
 338 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 339
 340         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 341         (cli_interp_base::set_logging): Check debug_redirect.
 342         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 343         * cli/cli-logging.c (debug_redirect): Add static variable.
 344         (pop_output_files): Add default param.
 345         (handle_redirections): Print debug setting.
 346         (show_logging_command): Likewise.
 347         (_initialize_cli_logging): Add debugredirect command.
 348         * interps.c (current_interp_set_logging): Add debug_redirect
 349         parameter.
 350         * interps.h (set_logging): Add debug_redirect parameter.
 351         (current_interp_set_logging): Likewise.
 352         * mi/mi-common.h: Likewise.
 353         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 354
 355 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 356             Tom Tromey  <tromey@adacore.com>
 357
 358         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 359         directly.
 360         * cli/cli-interp.h (make_logging_output): Remove declaration.
 361         * cli/cli-logging.c (make_logging_output): Remove function.
 362         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 363         directly.
 364         * ui-file.c (tee_file::tee_file): Remove bools.
 365         (tee_file::~tee_file): Remove deletes.
 366         * ui-file.h (tee_file): Remove bools.
 367
 368 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 369
 370         * mi/mi-cmds.h (mi_cmd_complete): New function.
 371         * mi/mi-main.c (mi_cmd_complete): Likewise.
 372         * mi/mi-cmds.c: Define new MI command -complete.
 373         * NEWS: Mention new -complete command.
 374
 375 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 376
 377         * completer.h (complete): New function.
 378         * completer.c (complete): Likewise.
 379         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 380         function defined in completer.h.
 381
 382 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 383
 384        * MAINTAINERS (Write After Approval): Add myself.
 385
 386 2019-05-17  Tom de Vries  <tdevries@suse.de>
 387
 388         PR gdb/24094
 389         * dwarf2read.c (struct cu_partial_die_info): New struct.
 390         (find_partial_die): Return cu_partial_die_info.
 391         (partial_die_parent_scope, guess_partial_die_structure_name)
 392         (partial_die_info::fixup): Handle new return type of find_partial_die.
 393
 394 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 395
 396         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 397         "std::string", simplifying the algorithm.
 398
 399 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 400
 401         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 402         (stap_static_probe_ops::get_probes): Likewise.
 403
 404 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 405
 406         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 407         '-')" and "else if".
 408         (stap_parse_single_operand): Join checks for
 409         "gdbarch_stap_parse_special_token_p" and
 410         "gdbarch_stap_parse_special_token" in the same "if" statement.
 411         Invert check when verifying for operation on register
 412         displacement.
 413
 414 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 415
 416         * stap-probe.c (stap_get_opcode): Update comment.
 417         (stap_get_expected_argument_type): Likewise.
 418         (handle_stap_probe): Likewise.
 419
 420 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 421
 422         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 423         return type to 'bool'.  Adjust comment.  Use 'bool' when
 424         appropriate.
 425         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 426         * stap-probe.c (stap_parse_argument_1): Likewise.
 427         (stap_is_operator): Likewise.
 428         (stap_is_generic_prefix): Likewise.
 429         (stap_is_register_prefix): Likewise.
 430         (stap_is_register_indirection_prefix): Likewise.
 431         (stap_is_integer_prefix): Likewise.
 432         (stap_generic_check_suffix): Likewise.
 433         (stap_check_integer_suffix): Likewise.
 434         (stap_check_register_suffix): Likewise.
 435         (stap_check_register_indirection_suffix): Likewise.
 436         (stap_parse_register_operand): Likewise.
 437         (stap_parse_single_operand): Likewise.
 438         (stap_parse_argument_1): Likewise.
 439         (stap_probe::get_argument_count): Likewise.
 440         (stap_is_operator): Likewise.
 441
 442 2019-05-16  Tom Tromey  <tromey@adacore.com>
 443
 444         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 445         keyword to foreach.
 446
 447 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 448
 449         * linux-thread-db.c (try_thread_db_load_1): Change return type
 450         to bool.
 451         (try_thread_db_load): Likewise.
 452         (try_thread_db_load_from_pdir_1): Likewise.
 453         (try_thread_db_load_from_pdir): Likewise.
 454         (try_thread_db_load_from_sdir): Likewise.
 455         (try_thread_db_load_from_dir): Likewise.
 456         (thread_db_load_search): Likewise.
 457         (has_libpthread): Likewise.
 458         (thread_db_load): Likewise.
 459
 460 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 461
 462         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 463         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 464         NULL, and complain/return if that's the case.
 465
 466 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 467
 468         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 469         (advance, posn, abstract_read_memory): New functions.
 470         [struct mem_read_abstraction]: New struct.
 471         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 472
 473 2019-05-14  Tom Tromey  <tromey@adacore.com>
 474
 475         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 476         value is not lval_memory.
 477
 478 2019-05-14  Tom Tromey  <tromey@adacore.com>
 479
 480         * solib.c (info_sharedlibrary_command): Style the file name.
 481
 482 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 483
 484         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 485         (aarch64_vnv_type): Likewise.
 486         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 487         * common/tdesc.c: Likewise.
 488         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 489         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 490         * features/aarch64-fpu.xml: Add ieee half view.
 491         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 492         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 493         * gdbtypes.h (struct builtin_type): Likewise.
 494         (struct objfile_type): Likewise.
 495
 496 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 497
 498         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 499         typo.
 500         * location.h (string_to_event_location): Likewise.
 501
 502 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 503
 504         GDB 8.3 released.
 505
 506 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 507
 508         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 509         New variable declaration.
 510         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 511         New variable.
 512         (print_one_breakpoint): Use ui_out::test_flags and new global
 513         variable to compute use_fixed_output.
 514         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 515         Remove.
 516         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 517         (mi_multi_location_breakpoint_output_fixed): Remove.
 518         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 519         new variable.
 520         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 521         fix_multi_location_breakpoint_output flag if version >= 3.
 522         * ui-out.h (enum ui_out_flag)
 523         <fix_multi_location_breakpoint_output>: New enumerator.
 524
 525 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 526
 527         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 528
 529 2019-05-10  Tom Tromey  <tromey@adacore.com>
 530
 531         * ada-lang.c (catch_ada_completer): New function.
 532         (_initialize_ada_language): Use it.
 533
 534 2019-05-10  Tom Tromey  <tromey@adacore.com>
 535
 536         * thread.c (print_thread_info): Make "requested_threads" const.
 537         * gdbthread.h (print_thread_info): Make "requested_threads"
 538         const.
 539         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 540         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 541
 542 2019-05-08  Tom Tromey  <tom@tromey.com>
 543
 544         * gdbtypes.c (objfile_type_data): Change type.
 545         (objfile_type, _initialize_gdbtypes): Update.
 546
 547 2019-05-08  Tom Tromey  <tom@tromey.com>
 548
 549         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 550         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 551         (_initialize_dwarf2_frame): Update.
 552
 553 2019-05-08  Tom Tromey  <tom@tromey.com>
 554
 555         * objc-lang.c (objc_objfile_data): Change type.
 556         (find_methods): Update.
 557         (_initialize_objc_lang): Remove.
 558
 559 2019-05-08  Tom Tromey  <tom@tromey.com>
 560
 561         * stabsread.c (rs6000_builtin_type_data): Change type.
 562         (rs6000_builtin_type, _initialize_stabsread): Update.
 563
 564 2019-05-08  Tom Tromey  <tom@tromey.com>
 565
 566         * mips-tdep.c (mips_pdr_data): Remove.
 567         (_initialize_mips_tdep): Update.
 568
 569 2019-05-08  Tom Tromey  <tom@tromey.com>
 570
 571         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 572         (hppa_init_objfile_priv_data, read_unwind_info)
 573         (find_unwind_entry, _initialize_hppa_tdep): Update.
 574
 575 2019-05-08  Tom Tromey  <tom@tromey.com>
 576
 577         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 578         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 579         on obstack.
 580         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 581
 582 2019-05-08  Tom Tromey  <tom@tromey.com>
 583
 584         * mdebugread.c (basic_type_data): Change type.
 585         (basic_type, _initialize_mdebugread): Update.
 586
 587 2019-05-08  Tom Tromey  <tom@tromey.com>
 588
 589         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 590
 591 2019-05-08  Tom Tromey  <tom@tromey.com>
 592
 593         * nto-tdep.c (nto_inferior_data_reg): Change type.
 594         (nto_inferior_data): Update.
 595         (nto_inferior_data_cleanup, nto_new_inferior_data)
 596         (_initialize_nto_tdep): Remove.
 597         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 598
 599 2019-05-08  Tom Tromey  <tom@tromey.com>
 600
 601         * ada-lang.c (struct ada_inferior_data): Add initializers.
 602         (ada_inferior_data): Change type.
 603         (ada_inferior_data_cleanup): Remove.
 604         (get_ada_inferior_data, ada_inferior_exit)
 605         (struct ada_pspace_data): Add initializers, destructor.
 606         (ada_pspace_data_handle): Change type.
 607         (get_ada_pspace_data): Update.
 608         (ada_pspace_data_cleanup): Remove.
 609
 610 2019-05-08  Tom Tromey  <tom@tromey.com>
 611
 612         * coffread.c (struct coff_symfile_info): Add initializers.
 613         (coff_objfile_data_key): Move lower.  Change type.
 614         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 615         Update.
 616         (coff_free_info): Remove.
 617
 618 2019-05-08  Tom Tromey  <tom@tromey.com>
 619
 620         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 621         (fbsd_pspace_data_handle): Move lower.  Change type.
 622         (get_fbsd_pspace_data): Update.
 623         (fbsd_pspace_data_cleanup): Remove.
 624         (_initialize_fbsd_tdep): Update.
 625
 626 2019-05-08  Tom Tromey  <tom@tromey.com>
 627
 628         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 629         (get_ada_tasks_pspace_data): Update.
 630         (ada_tasks_pspace_data_cleanup): Remove.
 631         (_initialize_tasks): Update.
 632         (ada_tasks_inferior_data_handle): Change type.
 633         (get_ada_tasks_inferior_data): Update.
 634         (ada_tasks_inferior_data_cleanup): Remove.
 635         (struct ada_tasks_pspace_data): Add initializers.
 636
 637 2019-05-08  Tom Tromey  <tom@tromey.com>
 638
 639         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 640         * symfile-debug.c (debug_sym_get_probes): Change type.
 641         * stap-probe.c (handle_stap_probe):
 642         (stap_static_probe_ops::get_probes): Change type.
 643         * probe.h (class static_probe_ops) <get_probes>: Change type.
 644         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 645         (parse_probes_in_pspace): Update.
 646         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 647         Update.
 648         (any_static_probe_ops::get_probes): Change type.
 649         * elfread.c (elfread_data): New typedef.
 650         (probe_key): Change type.
 651         (elf_get_probes): Likewise.  Update.
 652         (probe_key_free): Remove.
 653         (_initialize_elfread): Update.
 654         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 655         Change type.
 656         (dtrace_process_dof_probe, dtrace_process_dof)
 657         (dtrace_static_probe_ops::get_probe): Change type.
 658
 659 2019-05-08  Tom Tromey  <tom@tromey.com>
 660
 661         * xcoffread.c (struct xcoff_symfile_info): Rename from
 662         coff_symfile_info.  Add initializers.
 663         (xcoff_objfile_data_key): Move lower.  Change type.
 664         (XCOFF_DATA): Rewrite.
 665         (xcoff_free_info): Remove.
 666         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 667         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 668         (xcoff_initial_scan): Update.
 669
 670 2019-05-08  Tom Tromey  <tom@tromey.com>
 671
 672         * solib-svr4.c (struct svr4_info): Add initializers and
 673         destructor.
 674         <probes_table>: Now an htab_up.
 675         (solib_svr4_pspace_data): Change type.
 676         (free_probes_table): Simplify.
 677         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 678         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 679         (probes_table_remove_objfile_probes, register_solib_event_probe)
 680         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 681         (_initialize_svr4_solib): Update.
 682
 683 2019-05-08  Tom Tromey  <tom@tromey.com>
 684
 685         * remote.c (remote_pspace_data): Change type.
 686         (remote_pspace_data_cleanup): Remove.
 687         (get_remote_exec_file, set_pspace_remote_exec_file)
 688         (_initialize_remote): Update.
 689
 690 2019-05-08  Tom Tromey  <tom@tromey.com>
 691
 692         * breakpoint.c (breakpoint_objfile_key): Change type.
 693         (get_breakpoint_objfile_data): Update.
 694         (free_breakpoint_objfile_data): Remove.
 695         (_initialize_breakpoint): Update.
 696
 697 2019-05-08  Tom Tromey  <tom@tromey.com>
 698
 699         * linux-tdep.c (struct linux_info): Add initializers.
 700         (linux_inferior_data): Move.  Change type.
 701         (invalidate_linux_cache_inf): Update.
 702         (linux_inferior_data_cleanup): Remove.
 703         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 704
 705 2019-05-08  Tom Tromey  <tom@tromey.com>
 706
 707         * auxv.c (auxv_inferior_data): Move.  Change type.
 708         (auxv_inferior_data_cleanup): Remove.
 709         (invalidate_auxv_cache_inf): Rewrite.
 710         (get_auxv_inferior_data, _initialize_auxv): Update.
 711
 712 2019-05-08  Tom Tromey  <tom@tromey.com>
 713
 714         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 715         (symfile_debug_objfile_data_key): Change type.
 716         (symfile_debug_installed, debug_qf_has_symbols)
 717         (debug_qf_find_last_source_symtab)
 718         (debug_qf_forget_cached_source_info)
 719         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 720         (debug_qf_print_stats, debug_qf_dump)
 721         (debug_qf_expand_symtabs_for_function)
 722         (debug_qf_expand_all_symtabs)
 723         (debug_qf_expand_symtabs_with_fullname)
 724         (debug_qf_map_matching_symbols)
 725         (debug_qf_expand_symtabs_matching)
 726         (debug_qf_find_pc_sect_compunit_symtab)
 727         (debug_qf_map_symbol_filenames)
 728         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 729         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 730         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 731         (debug_sym_read_linetable, debug_sym_relocate): Update.
 732         (symfile_debug_free_objfile): Remove.
 733         (install_symfile_debug_logging, _initialize_symfile_debug):
 734         Update.
 735
 736 2019-05-08  Tom Tromey  <tom@tromey.com>
 737
 738         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 739         allocate_on_obstack.
 740         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 741         (get_dwarf2_per_objfile): Update.
 742         (set_dwarf2_per_objfile): Remove.
 743         (dwarf2_has_info, dwarf2_get_section_info): Update.
 744         (dwarf2_free_objfile): Remove.
 745         (_initialize_dwarf2_read): Update.
 746
 747 2019-05-08  Tom Tromey  <tom@tromey.com>
 748
 749         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 750         initializers.
 751         <unsupported_script_warning_printed,
 752         script_not_found_warning_printed>: Now bool.
 753         (auto_load_pspace_data): Change type.
 754         (~auto_load_pspace_info): Rename from
 755         auto_load_pspace_data_cleanup.
 756         (get_auto_load_pspace_data, init_loaded_scripts_info)
 757         (clear_section_scripts, maybe_print_unsupported_script_warning)
 758         (maybe_print_script_not_found_warning, _initialize_auto_load):
 759         Update.
 760
 761 2019-05-08  Tom Tromey  <tom@tromey.com>
 762
 763         * objfiles.c (objfile_pspace_info): Add destructor and
 764         initializers.
 765         (objfiles_pspace_data): Change type.
 766         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 767         (get_objfile_pspace_data): Update.
 768         (objfiles_bfd_data): Change type.
 769         (get_objfile_bfd_data): Update.
 770         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 771
 772 2019-05-08  Tom Tromey  <tom@tromey.com>
 773
 774         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 775         Change type.
 776         (get_catch_syscall_inferior_data): Update.
 777         (catch_syscall_inferior_data_cleanup): Remove.
 778         (_initialize_break_catch_syscall): Update.
 779
 780 2019-05-08  Tom Tromey  <tom@tromey.com>
 781
 782         * inflow.c (struct terminal_info): Add destructor and
 783         initializers.
 784         (inflow_inferior_data): Change type.
 785         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 786         (get_inflow_inferior_data, inflow_inferior_exit)
 787         (swap_terminal_info, _initialize_inflow): Update.
 788
 789 2019-05-08  Tom Tromey  <tom@tromey.com>
 790
 791         * target-dcache.c (target_dcache_cleanup): Remove.
 792         (target_dcache_aspace_key): Change type.
 793         (target_dcache_init_p, target_dcache_invalidate)
 794         (target_dcache_get, target_dcache_get_or_init)
 795         (_initialize_target_dcache): Update.
 796         * dcache.h (struct dcache_deleter): New.
 797
 798 2019-05-08  Tom Tromey  <tom@tromey.com>
 799
 800         * symtab.c (struct symbol_cache): Add destructor and
 801         initializers.
 802         (symbol_cache_key): Move.  Change type.
 803         (make_symbol_cache, free_symbol_cache): Remove.
 804         (get_symbol_cache): Update.
 805         (symbol_cache_cleanup): Remove.
 806         (ALL_PSPACES, symbol_cache_flush)
 807         (maintenance_print_symbol_cache)
 808         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 809         Update.
 810
 811 2019-05-08  Tom Tromey  <tom@tromey.com>
 812
 813         * symtab.c (struct main_info): Add destructor and initializers.
 814         (main_progspace_key): Move.  Change type.
 815         (get_main_info): Update.
 816         (main_info_cleanup): Remove.
 817         (_initialize_symtab): Update.
 818
 819 2019-05-08  Tom Tromey  <tom@tromey.com>
 820
 821         * registry.h (DECLARE_REGISTRY): Define the _key class.
 822
 823 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * NEWS: Merge two 'New commands' sections.
 826
 827 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 828
 829         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 830         parameter and use Ada language definition instead.
 831         (ada_val_print_ptr): Remove unused language parameter.
 832         (ada_val_print_num): Remove language parameter and use Ada language
 833         definition instead.
 834         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 835         parameter.
 836         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 837         parameter and use Ada language definition instead.
 838         (ada_val_print_1): Update all ada_val_print_xxx calls.
 839         Remove language parameter.
 840         (ada_val_print): Update ada_val_print_1 call.
 841
 842 2019-05-08  Tom Tromey  <tromey@adacore.com>
 843
 844         * remote.c (remote_hw_watchpoint_limit)
 845         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 846         Now static.
 847
 848 2019-05-08  Tom Tromey  <tromey@adacore.com>
 849
 850         * maint.c (_initialize_maint_cmds): Move initialization code to
 851         remote.c.
 852         (watchdog, show_watchdog): Move to remote.c.
 853         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 854         "watchdog" static.
 855         (_initialize_remote): Move initialization code from maint.c.
 856         * defs.h (watchdog): Don't declare.
 857
 858 2019-05-08  Tom Tromey  <tromey@adacore.com>
 859
 860         * tui/tui-interp.c: Include main.h.
 861         * interps.c: Include main.h.
 862         * main.h (interpreter_p): Declare.
 863         * defs.h (interpreter_p): Don't declare.
 864
 865 2019-05-08  Tom Tromey  <tromey@adacore.com>
 866
 867         * dwarf2loc.c: Include dwarf2read.h.
 868         * defs.h (read_unsigned_leb128): Don't declare.
 869         * dwarf2read.h (read_unsigned_leb128): Declare.
 870
 871 2019-05-08  Tom Tromey  <tromey@adacore.com>
 872
 873         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 874         method.
 875
 876 2019-05-08  Tom Tromey  <tromey@adacore.com>
 877
 878         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 879         when no wrap column is set.
 880
 881 2019-05-08  Tom Tromey  <tromey@adacore.com>
 882
 883         * c-lang.c (c_get_string): Handle non-C-style arrays.
 884
 885 2019-05-08  Tom Tromey  <tromey@adacore.com>
 886
 887         * typeprint.c (print_offset_data::update): Print the bit offset,
 888         not the number of bits remaining.
 889
 890 2019-05-08  Tom Tromey  <tromey@adacore.com>
 891
 892         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 893         padding at end of comment.
 894
 895 2019-05-08  Tom Tromey  <tromey@adacore.com>
 896
 897         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 898         Compare main types.
 899
 900 2019-05-06  Tom Tromey  <tom@tromey.com>
 901
 902         * common/scoped_mmap.c: Include common-defs.h.
 903         * common/scoped_mmap.h: Don't include config.h.
 904
 905 2019-05-04  Tom Tromey  <tom@tromey.com>
 906
 907         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 908         (struct aarch64_call_info): Add initializers.
 909         <si>: Now a std::vector.
 910         (pass_on_stack, aarch64_push_dummy_call): Update.
 911
 912 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 913             Tom Tromey  <tom@tromey.com>
 914
 915         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 916         (ppc_threads): Now a std::vector.  Now static.
 917         (hwdebug_find_thread_points_by_tid)
 918         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 919         Update.
 920
 921 2019-05-04  Tom Tromey  <tom@tromey.com>
 922
 923         * arc-tdep.c (arc_tdesc_init): Return bool.
 924
 925 2019-05-04  Tom Tromey  <tom@tromey.com>
 926
 927         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 928         Use gdb_assert_not_reached.
 929
 930 2019-05-04  Tom Tromey  <tom@tromey.com>
 931
 932         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 933         "false".
 934
 935 2019-05-04  Tom Tromey  <tom@tromey.com>
 936
 937         * arc-tdep.c (arc_tdesc_init): Use bool.
 938
 939 2019-05-04  Tom Tromey  <tom@tromey.com>
 940
 941         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 942
 943 2019-05-04  Tom Tromey  <tom@tromey.com>
 944
 945         * cli/cli-cmds.c (valid_command_p): Return bool.
 946
 947 2019-05-04  Tom Tromey  <tom@tromey.com>
 948
 949         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 950         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 951
 952 2019-05-04  Raul Tambre  <raul@tambre.ee>
 953
 954         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 955         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 956         operator for comparison.
 957
 958 2019-05-04  Tom Tromey  <tom@tromey.com>
 959
 960         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 961         (lookup_partial_symbol, print_partial_symbols)
 962         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 963         (psymbol_compare): Update.
 964         (add_psymbol_to_bcache): Clear the entire psymbol.
 965         (maintenance_check_psymtabs): Update.
 966         * psympriv.h (struct partial_symbol): Don't derive from
 967         general_symbol_info.
 968         <obj_section, unrelocated_address, address,
 969         set_unrelocated_address>: Update.
 970         <ginfo>: New member.
 971         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 972         (debug_names::write_psymbols): Update.
 973
 974 2019-05-04  Tom de Vries  <tdevries@suse.de>
 975
 976         * contrib/cc-with-tweaks.sh: Support -n arg.
 977
 978 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 979
 980         * corelow.c (core_target::detach): Ensure frame cache and
 981         register caches are cleared.
 982         inferior.c (exit_inferior_1): Likewise.
 983
 984 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 985             Tom Tromey  <tom@tromey.com>
 986
 987         * dictionary.c (collate_pending_symbols_by_language): Remove
 988         "struct" from foreach.
 989         * symtab.c (lookup_global_symbol_from_objfile)
 990         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 991         foreach.
 992         * ser-tcp.c (net_open): Remove "struct" from foreach.
 993         * objfiles.c (objfile_relocate, objfile_rebase)
 994         (objfile_has_symbols): Remove "struct" from foreach.
 995         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 996         from foreach.
 997         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 998         foreach.
 999         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1000         "struct" from foreach.
1001         * ada-lang.c (create_excep_cond_exprs)
1002         (ada_exception_catchpoint_cond_string): Remove "struct" from
1003         foreach.
1004
1005 2019-05-03  Tom Tromey  <tromey@adacore.com>
1006
1007         * ada-exp.y (convert_char_literal): Check suffix of each
1008         enumerator.
1009
1010 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1011
1012         PR ada/21406:
1013         * ada-exp.y (yywrap): Don't define.
1014         * ada-lex.l (%option): Add noyywrap
1015         (yywrap): Remove.
1016
1017 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1018
1019         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1020         _WIN32_WINNT to the XP level, unless already defined to a higher
1021         level.
1022
1023         * unittests/parse-connection-spec-selftests.c:
1024         * ser-tcp.c:
1025         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1026         override.
1027
1028         * symfile.c (find_separate_debug_file): Remove colon from the
1029         drive spec of DOS/Windows file names of the target, so that the
1030         file name produced from DEBUGDIR and the target's directory will
1031         be valid on DOS/Windows systems.
1032
1033 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * rust-lang.c (val_print_struct): Handle printing structures
1036         containing strings.
1037
1038 2019-05-02  Tom Tromey  <tromey@adacore.com>
1039
1040         * valarith.c (_initialize_valarith): Remove.
1041
1042 2019-05-01  Tom Tromey  <tromey@adacore.com>
1043
1044         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1045         bitfields.
1046
1047 2019-05-01  Tom Tromey  <tromey@adacore.com>
1048
1049         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1050         for big-endian copies.
1051
1052 2019-04-30  Ali Tamur  <tamur@google.com>
1053         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1054         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1055         (read_3_bytes): New function.
1056
1057 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1058
1059         * windows-nat.c (main_thread_id): Delete.
1060         (handle_output_debug_string): Replace main_thread_id by
1061         current_event.dwThreadId.
1062         (fake_create_process): Likewise.
1063         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1064         Do not set main_thread_id.
1065         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1066         current_event.dwThreadId.
1067         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1068
1069 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1070
1071         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1072         Use current_event.dwThreadId instead of main_thread_id.
1073
1074 2019-04-30  Tom Tromey  <tromey@adacore.com>
1075
1076         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1077         (create_excep_cond_exprs): Iterate over program spaces.
1078         (ada_exception_catchpoint_cond_string): Examine all minimal
1079         symbols for exception types.
1080
1081 2019-04-30  Tom Tromey  <tromey@adacore.com>
1082
1083         PR c++/24470:
1084         * dwarf2read.c (process_structure_scope): Handle case where type
1085         has template parameters but no symbol was created.
1086
1087 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1088             Chris January  <chris.january@arm.com>
1089
1090         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1091         qualifier.
1092         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1093
1094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * f-typeprint.c (f_print_type): Update rules for printing
1097         whitespace.
1098         (f_type_print_varspec_suffix): Likewise.
1099
1100 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1101             Chris January  <chris.january@arm.com>
1102
1103         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1104         function arguments.
1105
1106 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1107
1108         * f-lang.c (build_fortran_types): Change name of void type to
1109         lower case.
1110         * f-typeprint.c (f_type_print_base): Print the name of the void
1111         type, rather than a fixed string.
1112         * f-valprint.c (f_decorations): Use lower case void string.
1113
1114 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1115             Chris January  <chris.january@arm.com>
1116
1117         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1118         types for Fortran.
1119
1120 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1121             Chris January  <chris.january@arm.com>
1122             David Lecomber  <david.lecomber@arm.com>
1123
1124         * f-exp.y (BINOP_INTRINSIC): New token.
1125         (exp): New parser rule handling BINOP_INTRINSIC.
1126         (f77_keywords): Add new builtin procedures.
1127         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1128         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1129         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1130         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1131         (print_unop_subexp_f): New function.
1132         (print_binop_subexp_f): New function.
1133         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1134         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1135         (dump_subexp_body_f): Likewise.
1136         (operator_check_f): Likewise.
1137         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1138         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1139
1140 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1141
1142         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1143         UNOP_KIND.
1144         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1145         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1146         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1147         (operator_length_f): New fuction.
1148         (print_subexp_f): New function.
1149         (op_name_f): New function.
1150         (dump_subexp_body_f): New function.
1151         (operator_check_f): New function.
1152         (exp_descriptor_f): Replace standard expression handling functions
1153         with new functions.
1154         * gdb/fortran-operator.def: New file.
1155         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1156         * gdb/std-operator.def: Remove UNOP_KIND.
1157
1158 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1159
1160         * std-operator.def: Remove unbalanced, stray double quote
1161         character.
1162
1163 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1164             Chris January  <chris.january@arm.com>
1165             Daniel Everett  <daniel.everett@arm.com>
1166             Nick Forrington  <nick.forrington@arm.com>
1167             Richard Bunt  <richard.bunt@arm.com>
1168
1169         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1170         of depth when printing anonymous structs or unions.
1171         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1172         Don't print either the top-level value, or the children if the
1173         max-depth is exceeded.
1174         (ppscm_print_children): When printing the key of a map, allow one
1175         extra level of depth.
1176         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1177         print either the top-level value, or the children if the max-depth
1178         is exceeded.
1179         (print_children): When printing the key of a map, allow one extra
1180         level of depth.
1181         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1182         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1183         (user_print_options): Initialise max_depth field.
1184         (val_print_scalar_or_string_type_p): New function.
1185         (val_print): Check to see if the max depth has been reached.
1186         (val_print_check_max_depth): Define new function.
1187         (show_print_max_depth): New function.
1188         (_initialize_valprint): Add 'print max-depth' option.
1189         * valprint.h (struct value_print_options) <max_depth>: New field.
1190         (val_print_check_max_depth): Declare new function.
1191         * NEWS: Document new feature.
1192
1193 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1194
1195         * ada-lang.c (ada_language_defn): Initialise new field.
1196         * c-lang.c (c_is_string_type_p): New function.
1197         (c_language_defn): Initialise new field.
1198         (cplus_language_defn): Initialise new field.
1199         (asm_language_defn): Initialise new field.
1200         (minimal_language_defn): Initialise new field.
1201         * c-lang.h (c_is_string_type_p): Declare new function.
1202         * d-lang.c (d_language_defn): Initialise new field.
1203         * f-lang.c (f_is_string_type_p): New function.
1204         (f_language_defn): Initialise new field.
1205         * go-lang.c (go_is_string_type_p): New function.
1206         (go_language_defn): Initialise new field.
1207         * language.c (default_is_string_type_p): New function.
1208         (unknown_language_defn): Initialise new field.
1209         (auto_language_defn): Initialise new field.
1210         * language.h (struct language_defn) <la_is_string_type_p>: New
1211         member variable.
1212         (default_is_string_type_p): Declare new function.
1213         * m2-lang.c (m2_language_defn): Initialise new field.
1214         * objc-lang.c (objc_language_defn): Initialise new field.
1215         * opencl-lang.c (opencl_language_defn): Initialise new field.
1216         * p-lang.c (pascal_is_string_type_p): New function.
1217         (pascal_language_defn): Initialise new field.
1218         * rust-lang.c (rust_is_string_type_p): New function.
1219         (rust_language_defn): Initialise new field.
1220
1221 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1222
1223         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1224         New field.
1225         * ada-lang.c (ada_language_defn): Initialise new field.
1226         * c-lang.c (c_language_defn): Likewise.
1227         (cplus_language_defn): Likewise.
1228         (asm_language_defn): Likewise.
1229         (minimal_language_defn): Likewise.
1230         * d-lang.c (d_language_defn): Likewise.
1231         * f-lang.c (f_language_defn): Likewise.
1232         * go-lang.c (go_language_defn): Likewise.
1233         * language.c (unknown_language_defn): Likewise.
1234         (auto_language_defn): Likewise.
1235         * m2-lang.c (m2_language_defn): Likewise.
1236         * objc-lang.c (objc_language_defn): Likewise.
1237         * opencl-lang.c (opencl_language_defn): Likewise.
1238         * p-lang.c (pascal_language_defn): Likewise.
1239         * rust-lang.c (rust_language_defn): Likewise.
1240
1241 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * ada-lang.c (ada_is_character_type): Change return type to bool.
1244         (ada_is_string_type): Likewise.
1245         * ada-lang.h (ada_is_character_type): Update declaration
1246         (ada_is_string_type): Likewise.
1247
1248 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1249
1250         Support style in 'frame|thread apply'
1251
1252         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1253         * record.c (record_start, record_stop): Update callers of
1254         execute_command_to_string with false.
1255         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1256         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1257         methods.
1258         (class string_file): New constructor with term_out parameter.
1259         Override methods term_out and can_emit_style_escape.  New member
1260         term_out.
1261         (class stdio_file): Override can_emit_style_escape.
1262         (class tee_file): Override term_out and can_emit_style_escape.
1263         * utils.h (can_emit_style_escape): Remove.
1264         * utils.c (can_emit_style_escape): Likewise.
1265         Update all callers of can_emit_style_escape (SOMESTREAM) to
1266         SOMESTREAM->can_emit_style_escape.
1267         * source-cache.c (source_cache::get_source_lines): Likewise.
1268         * stack.c (frame_apply_command_count): Call execute_command_to_string
1269         passing the term_out characteristic of the current gdb_stdout.
1270         * thread.c (thr_try_catch_cmd): Likewise.
1271         * top.c (execute_command_to_string): pass term_out parameter
1272         to construct the string_file for the command output.
1273         * ui-file.c (term_cli_styling): New function (most code moved
1274         from utils.c can_emit_style_escape).
1275         (string_file::string_file, string_file::can_emit_style_escape,
1276         stdio_file::can_emit_style_escape, tee_file::term_out,
1277         tee_file::can_emit_style_escape): New functions.
1278
1279 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1280
1281         * NEWS: Mention the new set|show may-call-functions.
1282         * infcall.c (may_call_functions_p): New variable.
1283         (show_may_call_functions_p): New function.
1284         (call_function_by_hand_dummy): Throws an error if not
1285         may-call-functions.
1286         (_initialize_infcall): Call add_setshow_boolean_cmd for
1287         may-call-functions.
1288
1289 2019-04-25  Keith Seitz  <keiths@redhat.com>
1290
1291         PR c++/24367
1292         * cp-support.c (inspect_type): Don't attempt substitutions
1293         of symbol with the same name.
1294
1295 2019-04-25  Tom Tromey  <tromey@adacore.com>
1296
1297         PR gdb/24475:
1298         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1299         static.
1300
1301 2019-04-25  Tom Tromey  <tromey@adacore.com>
1302
1303         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1304         rvalue reference.
1305         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1306         (gdb_xml_parser::parse): Use std::move.
1307         * python/python-internal.h (gdbpy_convert_exception): Take a const
1308         reference.
1309         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1310         std::move.
1311         * python/py-utils.c (gdbpy_convert_exception): Take a const
1312         reference.
1313         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1314         Use std::move.
1315         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1316         Use std::move.
1317         * mi/mi-main.c (mi_print_exception): Take a const reference.
1318         * main.c (handle_command_errors): Take a const reference.
1319         * linespec.c (parse_linespec): Use std::move.
1320         * infcall.c (run_inferior_call): Use std::move.
1321         (call_function_by_hand_dummy): Use std::move.
1322         * exec.c (try_open_exec_file): Use std::move.
1323         * exceptions.h (exception_print, exception_fprintf)
1324         (exception_print_same): Update.
1325         * exceptions.c (print_exception, exception_print)
1326         (exception_fprintf, exception_print_same): Change parameters to
1327         const reference.
1328         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1329         * common/new-op.c: Use std::move.
1330         * common/common-exceptions.h (struct gdb_exception): Add move
1331         constructor.
1332         (struct gdb_exception_error, struct gdb_exception_quit, struct
1333         gdb_quit_bad_alloc): Change constructor to move constructor.
1334         (throw_exception): Change parameter to rvalue reference.
1335         * common/common-exceptions.c (throw_exception): Take rvalue
1336         reference.
1337         * cli/cli-interp.c (safe_execute_command): Use std::move.
1338         * breakpoint.c (insert_bp_location, location_to_sals): Use
1339         std::move.
1340
1341 2019-04-25  Tom Tromey  <tromey@adacore.com>
1342
1343         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1344         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1345         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1346         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1347         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1348         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1349         guile/scm-value.c: Use unpack.
1350         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1351         gdbscm_gdb_exception.
1352         (gdbscm_throw_gdb_exception): Likewise.
1353         (struct gdbscm_gdb_exception): New.
1354         (unpack): New function.
1355         (gdbscm_wrap): Use unpack.
1356
1357 2019-04-25  Tom Tromey  <tromey@adacore.com>
1358
1359         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1360         (gdb_rl_callback_handler): Use std::move.
1361         * common/common-exceptions.h (struct gdb_exception): Add move
1362         assignment operator.
1363         (throw_exception_sjlj): Change "exception" to const reference.
1364         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1365         (throw_exception_sjlj): Change "exception" to const reference.
1366
1367 2019-04-25  Tom Tromey  <tromey@adacore.com>
1368
1369         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1370         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1371         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1372         Update.
1373         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1374         Update.
1375         * mi/mi-interp.c (mi_interp::exec): Update.
1376         * linespec.c (parse_linespec): Update.
1377         * infcall.c (run_inferior_call): Update.
1378         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1379         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1380         (gdbscm_lookup_global_symbol): Update.
1381         * guile/scm-param.c (gdbscm_parameter_value): Update.
1382         * guile/scm-frame.c (gdbscm_frame_read_register)
1383         (gdbscm_frame_read_var): Update.
1384         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1385         * exec.c (try_open_exec_file): Update.
1386         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1387         (gdb_rl_callback_handler): Update.
1388         * common/common-exceptions.h (exception_none): Don't declare.
1389         * common/common-exceptions.c (exception_none): Don't define.
1390         (struct catcher) <exception>: Update.
1391         * cli/cli-interp.c (safe_execute_command): Update.
1392         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1393
1394 2019-04-25  Ali Tamur  <tamur@google.com>
1395
1396         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1397         (read_attribute_value): Likewise.
1398         (dwarf2_read_addr_index): Update comment.
1399         (read_str_index): Add DW_FORM_strx.
1400         (dwarf2_string_attr): Likewise.
1401         (dwarf2_const_value_attr): Likewise.
1402         (dump_die_shallow): Likewise.
1403         (dwarf2_fetch_constant_bytes): Likewise.
1404         (skip_form_bytes): Likewise.
1405         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1406
1407 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1408
1409         PR corefiles/11608
1410         PR corefiles/18187
1411         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1412         OFFSET.  Verify if current mapping contains an ELF header.
1413         (linux_find_memory_regions_full): Adjust call to
1414         dump_mapping_p.
1415
1416 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1417             Kang Li <kanglictf@gmail.com>
1418
1419         PR gdb/21600
1420
1421         * dwarf2-frame.c (read_initial_length): Be consistent about using
1422         unsigned representation of length.
1423         (decode_frame_entry_1): Likewise.  Check for wraparound of
1424         end pointer as well as buffer overflow.
1425
1426 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1427
1428         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1429         "vq".
1430
1431 2019-04-24  Tom Tromey  <tromey@adacore.com>
1432
1433         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1434
1435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1436
1437         * s12z-tdep.c (s12z_unwind_pc): Delete.
1438         (s12z_unwind_sp): Delete.
1439         (s12z_gdbarch_init): Don't register deleted functions with
1440         gdbarch.
1441
1442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1443
1444         * rl78-tdep.c (rl78_unwind_sp): Delete.
1445         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1446
1447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1448
1449         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1450         (xstormy16_unwind_pc): Delete.
1451         (xstormy16_dummy_id): Delete.
1452         (xstormy16_gdbarch_init): Don't register deleted functions with
1453         gdbarch.
1454
1455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1456
1457         * vax-tdep.c (vax_unwind_pc): Delete.
1458         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1459
1460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1461
1462         * v850-tdep.c (v850_unwind_sp): Delete.
1463         (v850_unwind_pc): Delete.
1464         (v850_dummy_id): Delete.
1465         (v850_gdbarch_init): Don't register deleted functions with
1466         gdbarch.
1467
1468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1469
1470         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1471         (tilegx_unwind_pc): Delete.
1472         (tilegx_unwind_dummy_id): Delete.
1473         (tilegx_gdbarch_init): Don't register deleted functions with
1474         gdbarch.
1475
1476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1477
1478         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1479         (tic6x_dummy_id): Delete.
1480         (tic6x_gdbarch_init): Don't register deleted functions with
1481         gdbarch.
1482
1483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1484
1485         * sparc-tdep.c (sparc_unwind_pc): Delete.
1486         (sparc32_gdbarch_init): Don't register deleted function with
1487         gdbarch.
1488
1489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1490
1491         * sh-tdep.c (sh_unwind_sp): Delete.
1492         (sh_unwind_pc): Delete.
1493         (sh_dummy_id): Delete.
1494         (sh_gdbarch_init): Don't register deleted functions with
1495         gdbarch.
1496
1497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1498
1499         * score-tdep.c (score_unwind_sp): Delete.
1500         (score_unwind_pc): Delete.
1501         (score_dummy_id): Delete.
1502         (score_gdbarch_init): Don't register deleted functions with
1503         gdbarch.
1504
1505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * rx-tdep.c (rx_unwind_pc): Delete.
1508         (rx_unwind_sp): Delete.
1509         (rx_dummy_id): Delete.
1510         (rx_gdbarch_init): Don't register deleted functions with
1511         gdbarch.  Update comment.
1512
1513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1514
1515         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1516         (rs6000_dummy_id): Delete.
1517         (rs6000_gdbarch_init): Don't register deleted functions with
1518         gdbarch.
1519
1520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1521
1522         * or1k-tdep.c (or1k_dummy_id): Delete.
1523         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1524
1525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1526
1527         * nios2-tdep.c (nios2_dummy_id): Delete.
1528         (nios2_unwind_sp): Delete.
1529         (nios2_gdbarch_init): Don't register deleted functions with
1530         gdbarch.
1531
1532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1533
1534         * nds32-tdep.c (nds32_dummy_id): Delete.
1535         (nds32_unwind_pc): Delete.
1536         (nds32_unwind_sp): Delete.
1537         (nds32_gdbarch_init): Don't register deleted functions with
1538         gdbarch.
1539
1540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * msp430-tdep.c (msp430_unwind_pc): Delete.
1543         (msp430_unwind_sp): Delete.
1544         (msp430_dummy_id): Delete.
1545         (msp430_gdbarch_init): Don't register deleted functions with
1546         gdbarch.
1547
1548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1549
1550         * moxie-tdep.c (moxie_unwind_sp): Delete.
1551         (moxie_unwind_pc): Delete.
1552         (moxie_dummy_id): Delete.
1553         (moxie_gdbarch_init): Don't register deleted functions with
1554         gdbarch.
1555
1556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1559         (mn10300_unwind_pc): Delete.
1560         (mn10300_unwind_sp): Delete.
1561         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1562         mn10300_unwind_sp.
1563         (mn10300_frame_unwind_init): Don't register deleted functions with
1564         gdbarch.
1565
1566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1567
1568         * mep-tdep.c (mep_unwind_pc): Delete.
1569         (mep_unwind_sp): Delete.
1570         (mep_dummy_id): Delete.
1571         (mep_gdbarch_init): Don't register deleted functions with
1572         gdbarch.
1573
1574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1575
1576         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1577         (m68hc11_unwind_sp): Delete.
1578         (m68hc11_gdbarch_init): Don't register deleted functions with
1579         gdbarch.
1580
1581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1582
1583         * m32r-tdep.c (m32r_unwind_sp): Delete.
1584         (m32r_unwind_pc): Delete.
1585         (m32r_dummy_id): Delete.
1586         (m32r_gdbarch_init): Don't register deleted functions with
1587         gdbarch.
1588
1589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1590
1591         * m32c-tdep.c (m32c_unwind_pc): Delete.
1592         (m32c_unwind_sp): Delete.
1593         (m32c_dummy_id): Delete.
1594         (m32c_gdbarch_init): Don't register deleted functions with
1595         gdbarch.
1596
1597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1598
1599         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1600         (lm32_unwind_pc): Delete.
1601         (lm32_dummy_id): Delete.
1602         (lm32_gdbarch_init): Don't register deleted functions with
1603         gdbarch.
1604
1605 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1606
1607         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1608         (iq2000_unwind_pc): Delete.
1609         (iq2000_dummy_id): Delete.
1610         (iq2000_gdbarch_init): Don't register deleted functions with
1611         gdbarch.
1612
1613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1614
1615         * nds32-tdep.c (nds32_type_align): Delete.
1616         (nds32_push_dummy_call): Use type_align instead.
1617
1618 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1619
1620         * arm-tdep.c (arm_type_align): Only handle vector override case.
1621         (arm_push_dummy_call): Use type_align.
1622         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1623
1624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1625
1626         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1627         case.
1628         (pass_on_stack): Use type_align.
1629         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1630         function.
1631
1632 2019-04-23  Tom Tromey  <tromey@adacore.com>
1633
1634         * dwarf2read.c (line_header::file_name_at): Remove unused
1635         overload.
1636
1637 2019-04-23  Tom de Vries  <tdevries@suse.de>
1638
1639         PR gdb/24438
1640         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1641         invocation.
1642
1643
1644 2019-03-27  Ali Tamur  <tamur@google.com>
1645
1646         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1647         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1648         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1649         (dwarf_expr_context::get_addr_index): Likewise
1650         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1651         (symbol_needs_eval_context::get_addr_index): Likewise
1652         (disassemble_dwarf_expression): Add DW_OP_addrx
1653         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1654         (read_cutu_die_from_dwo): Update comment
1655         (skip_one_die): Add DW_FORM_addrx
1656         (read_attribute_value): Likewise
1657         (var_decode_location): Add DW_OP_addrx
1658         (dwarf2_const_value_attr): Add DW_FORM_addrx
1659         (dump_die_shallow): Likewise
1660         (dwarf2_fetch_constant_bytes): Likewise
1661         (decode_locdesc): Add DW_OP_addrx
1662         (skip_form_bytes): Add DW_FORM_addrx
1663
1664 2019-04-22  Ali Tamur  <tamur@google.com>
1665
1666         * MAINTAINERS (Write After Approval): Add self.
1667
1668 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1669
1670         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1671         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1672         (open_symbol_file_object): Likewise.
1673         (svr4_default_sos): Add info parameter.
1674         (svr4_read_so_list): Likewise.
1675         (svr4_current_sos_direct): Adjust functions calls to pass down
1676         info.
1677         (svr4_current_sos_1): Add info parameter.
1678         (svr4_current_sos): Call get_svr4_info, pass info down to
1679         svr4_current_sos_1.
1680         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1681         get_svr4_info.
1682         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1683         get_svr4_info.
1684         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1685         to get_svr4_info.
1686         (probes_table_remove_objfile_probes): Likewise.
1687         (register_solib_event_probe): Add info parameter.
1688         (solist_update_incremental): Pass info parameter down to
1689         svr4_read_so_list.
1690         (disable_probes_interface): Add info parameter.
1691         (svr4_handle_solib_event): Pass current_program_space to
1692         get_svr4_info.  Adjust disable_probes_interface cleanup.
1693         (svr4_create_probe_breakpoints): Add info parameter, pass it
1694         down to register_solib_event_probe.
1695         (svr4_create_solib_event_breakpoints): Add info parameter,
1696         pass it down to svr4_create_probe_breakpoints.
1697         (enable_break): Pass info down to
1698         svr4_create_solib_event_breakpoints.
1699         (svr4_solib_create_inferior_hook): Pass current_program_space to
1700         get_svr4_info.
1701         (svr4_clear_solib): Likewise.
1702
1703 2019-04-22  Pedro Alves  <palves@redhat.com>
1704
1705         * solib-svr4.c (svr4_free_objfile_observer): New.
1706         (probe_and_action::objfile): New field.
1707         (probes_table_htab_remove_objfile_probes)
1708         (probes_table_remove_objfile_probes): New functions.
1709         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1710         in the new probe_and_action.  Don't store the probe in 'lookup'.
1711         (svr4_create_probe_breakpoints): Pass objfile to
1712         register_solib_event_probe.
1713         (_initialize_svr4_solib): Register a free_objfile observer.
1714
1715 2019-04-19  Tom Tromey  <tom@tromey.com>
1716
1717         * common/queue.h: Remove.
1718
1719 2019-04-19  Tom Tromey  <tom@tromey.com>
1720
1721         * event-loop.c: Don't include "common/queue.h".
1722
1723 2019-04-19  Tom Tromey  <tom@tromey.com>
1724
1725         * remote.c (remote_target): Use delete.
1726         * remote-notif.h: Include <list>, not "common/queue.h".
1727         (notif_client_p): Remove typedef.
1728         (remote_notif_state): Add constructor, destructor, initializer.
1729         <notif_queue>: Now a std::list.
1730         (remote_notif_state_xfree): Don't declare.
1731         * remote-notif.c (remote_notif_process, handle_notification)
1732         (remote_notif_state_allocate): Update.
1733         (~remote_notif_state): Rename from remote_notif_state_xfree.
1734
1735 2019-04-19  Tom Tromey  <tom@tromey.com>
1736
1737         * symfile.c (reread_symbols): Update.
1738         * objfiles.c (objfile_register_static_link)
1739         (objfile_lookup_static_link): Update
1740         (~objfile) Don't delete static_links.
1741         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1742
1743 2019-04-19  Tom Tromey  <tom@tromey.com>
1744
1745         * type-stack.h (struct type_stack) <insert>: Constify string.
1746         * type-stack.c (type_stack::insert): Constify string.
1747         * gdbtypes.h (lookup_template_type): Update.
1748         (address_space_name_to_int): Update.
1749         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1750         const.
1751         (lookup_template_type): Make name const.
1752         * c-exp.y: Update rules.
1753         (lex_one_token, classify_name, classify_inner_name)
1754         (c_print_token): Update.
1755         * p-exp.y: Update rules.
1756         (yylex): Update.
1757         * f-exp.y: Update rules.
1758         (yylex): Update.
1759         * d-exp.y: Update rules.
1760         (lex_one_token, classify_name, classify_inner_name): Update.
1761         * parse.c (write_dollar_variable, copy_name): Return std::string.
1762         * parser-defs.h (copy_name): Change return type.
1763         * m2-exp.y: Update rules.
1764         (yylex): Update.
1765         * go-exp.y (lex_one_token): Update.
1766         Update rules.
1767         (classify_unsafe_function, classify_packaged_name)
1768         (classify_name, yylex): Update.
1769
1770 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1771
1772         * configure.ac: add --enable-source-highlight switch.
1773         * configure: Regenerate.
1774         * top.c (print_gdb_version): plumb --enable-source-highlight
1775         status to "show configuration".
1776
1777 2019-04-19  Tom Tromey  <tromey@adacore.com>
1778
1779         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1780         Check ADA_TYPE_P.
1781         (empty_record, ada_template_to_fixed_record_type_1)
1782         (template_to_static_fixed_type)
1783         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1784         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1785         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1786         macros.
1787
1788 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1789
1790         PR symtab/24423:
1791         * source.c (print_source_lines_base): Advance "iter" when a
1792         control character is seen.
1793
1794 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1795
1796         * inferior.h (struct infcall_suspend_state_deleter):
1797         Catch exception in destructor to avoid crash.
1798
1799 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1800
1801         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1802         close to the add_com "shell".
1803
1804 2019-04-18  Tom Tromey  <tromey@adacore.com>
1805
1806         * process-stratum-target.h (class process_stratum_target)
1807         <stratum>: Add "final".
1808
1809 2019-04-17  Tom Tromey  <tromey@adacore.com>
1810
1811         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1812         against nullptr before use.
1813
1814 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1815
1816         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1817
1818 2019-04-17  Jim Wilson  <jimw@sifive.com>
1819             Andrew Burgess  <andrew.burgess@embecosm.com>
1820
1821         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1822         code read might fail, assume 4-byte breakpoint in that case.
1823
1824 2019-04-15  Leszek Swirski  <leszeks@google.com>
1825
1826         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1827         rather than a hand-rolled POD check when checking for forced MEMORY
1828         classification.
1829
1830 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1831
1832         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1833         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1834         function.
1835         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1836         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1837         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1838         declaration.
1839
1840 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1841
1842         * aarch64-linux-nat.c
1843         (aarch64_linux_nat_target::thread_architecture): Add override.
1844         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1845         each VQ.
1846
1847 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1848
1849         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1850
1851 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1852
1853         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1854         target types of size 96-bits, add some additional comments, and
1855         check that the builtin type we found was the correct size.
1856
1857 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1858
1859         * utils.c (prompt_for_continue): Don't restore the styling at the
1860         end, as applied_style has the wrong value.  This fixes styling in
1861         long lists of file names that are interrupted by the "Continue?"
1862         prompt.
1863
1864 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1865
1866         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1867         * c-lang.c (c_language_defn): Likewise.
1868         (cplus_language_defn): Likewise.
1869         (asm_language_defn): Likewise.
1870         (minimal_language_defn): Likewise.
1871         * d-lang.c (d_language_defn): Likewise.
1872         * f-lang.c (f_language_defn): Likewise.
1873         * go-lang.c (go_language_defn): Likewise.
1874         * language.c (unknown_language_defn): Likewise.
1875         (auto_language_defn): Likewise.
1876         * language.h (struct language_defn): Remove la_magic field.
1877         (LANG_MAGIC): Delete.
1878         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1879         * objc-lang.c (objc_language_defn): Likewise.
1880         * opencl-lang.c (opencl_language_defn): Likewise.
1881         * p-lang.c (pascal_language_defn): Likewise.
1882         * rust-lang.c (rust_language_defn): Likewise.
1883
1884 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1885
1886         * riscv-tdep.c (riscv_type_align): New function.
1887         (riscv_type_alignment): Delete.
1888         (riscv_arg_location): Use 'type_align'.
1889         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1890
1891 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1892
1893         * gdbtypes.c (type_align): A struct with no non-static fields also
1894         has alignment of 1.
1895
1896 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1897
1898         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1899         component to 0.
1900         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1901         member.
1902         (riscv_struct_info::analyse): New implementation using new
1903         analyse_inner member function.
1904         (riscv_struct_info::field_offset): New member function.
1905         (riscv_struct_info::m_offsets): New member variable.
1906         (riscv_struct_info::analyse_inner): New private member function,
1907         takes the old implementation of riscv_struct_info::analyse but
1908         extended to track field offsets.
1909         (riscv_call_arg_struct): Update the struct folding special cases
1910         to handle cases where empty C++ structs, which are non-zero
1911         length, are found.
1912         (riscv_arg_location): Initialise the length of each location, a
1913         non-zero length now indicates the location is in use.
1914         (riscv_push_dummy_call): Allow for the first location having a
1915         non-zero offset when setting up arguments.
1916         (riscv_return_value): Likewise, but for return values.
1917
1918 2019-04-11  Tom Tromey  <tromey@adacore.com>
1919
1920         * utils.c (internal_vproblem): Make "msg" const.
1921
1922 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1923
1924         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1925         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1926         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1927         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1928
1929 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1930
1931         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1932         function.
1933         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1934         of amd64_collect_native_gregset.
1935         (amd64_linux_nat_target::store_registers): Likewise.
1936
1937 2019-04-10  Tom Tromey  <tom@tromey.com>
1938
1939         * symtab.c (lookup_global_symbol_from_objfile)
1940         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1941         * objfiles.h (class separate_debug_iterator): New.
1942         (class separate_debug_range): New.
1943         (struct objfile) <separate_debug_objfiles>: New method.
1944         (objfile_separate_debug_iterate): Don't declare.
1945         * objfiles.c (separate_debug_iterator::operator++): Rename from
1946         objfile_separate_debug_iterate.
1947         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1948         iterator.
1949         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1950         iterator.
1951
1952 2019-04-10  Tom Tromey  <tom@tromey.com>
1953
1954         * symfile.c (reread_symbols): Remove old comment.
1955         * objfiles.c (free_all_objfiles): Fix a typo.
1956
1957 2019-04-10  Tom Tromey  <tom@tromey.com>
1958
1959         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1960         * minsyms.c (lookup_minimal_symbol): Use foreach.
1961         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1962         (lookup_minimal_symbol_solib_trampoline): Likewise.
1963         * symfile.c (reread_symbols): Use foreach.
1964
1965 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1966             Tom Tromey  <tromey@adacore.com>
1967
1968         PR rust/24414:
1969         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1970         (rust_lex_int_test): Change "value" to be LONGEST.
1971         (rust_lex_tests): Add test for long integer literal.
1972
1973 2019-04-09  Tom Tromey  <tromey@adacore.com>
1974
1975         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1976         to bool.
1977         (extended_remote_target::attach): Update.
1978         (remote_target::remote_notice_new_inferior): Update.
1979         (remote_target::add_current_inferior_and_thread): Update.
1980         * inferior.c (exit_inferior_1): Use "false".
1981         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1982
1983 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1984
1985         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1986         the "start" command.
1987
1988 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1989
1990         * python/py-inferior.c (infpy_thread_from_thread_handle):
1991         Adjust comments to reflect renaming of thread_from_thread_handle
1992         to thread_from_handle.  Adjust keywords.  Fix type error message.
1993         (inferior_object_methods): Add thread_from_handle.  Retain
1994         thread_from_thread_handle, but mark it as deprecated.
1995
1996 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1997
1998         * gdbthread.h (find_thread_by_handle): Revise declaration.
1999         * thread.c (find_thread_by_handle): Likewise.  Adjust
2000         implementation too.
2001         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2002         support for buffer objects as handles.
2003
2004 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2005
2006         * python/py-infthread.c (thpy_thread_handle): New function.
2007         (thread_object_methods): Register thpy_thread_handle.
2008
2009 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2010
2011         * gdbthread.h (thread_to_thread_handle): Declare.
2012         * thread.c (gdbtypes.h): Include.
2013         (thread_to_thread_handle): New function.
2014
2015         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2016         (target_thread_info_to_thread_handle): Declare.
2017         * target.c (target_thread_info_to_thread_handle): New function.
2018         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2019         * target-delegates.c: Regenerate.
2020
2021         * linux-thread-db.c (class thread_db_target): Add method
2022         thread_info_to_thread_handle.
2023         (thread_db_target::thread_info_to_thread_handle): Define.
2024         * remote.c (class remote_target): Add new method
2025         thread_info_to_thread_handle.
2026         (remote_target::thread_info_to_thread_handle): Define.
2027
2028 2019-04-08  Pedro Alves  <palves@redhat.com>
2029
2030         * common/common-exceptions.c (throw_exception): Don't create
2031         named object to throw; throw directly.
2032         (throw_it): Likewise.  Don't initialize gdb_exception::message
2033         here, with new; pass FMT and AP to the ctor instead.
2034         * common/common-exceptions.h: Include <string>.
2035         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2036         const char *, va_list)): New ctor.  Use std::make_shared.
2037         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2038         errors)): Delete.
2039         (gdb_exception_error::gdb_exception_error(enum errors, const char
2040         *, va_list)): New.
2041         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2042         Add assertion.
2043         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2044         errors)): Delete.
2045         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2046         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2047         Add assertion.
2048
2049 2019-04-08  Tom Tromey  <tom@tromey.com>
2050
2051         * valops.c (value_rtti_indirect_type): Replace throw_exception
2052         with throw.
2053         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2054         with throw.
2055         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2056         throw.
2057         * target.c (target_translate_tls_address): Replace throw_exception
2058         with throw.
2059         * stack.c (frame_apply_command_count): Replace throw_exception
2060         with throw.
2061         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2062         throw.
2063         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2064         with throw.
2065         * rs6000-tdep.c (rs6000_frame_cache)
2066         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2067         * remote.c: Replace throw_exception with throw.
2068         * record-full.c (record_full_message, record_full_wait_1)
2069         (record_full_restore): Replace throw_exception with throw.
2070         * record-btrace.c:
2071         (get_thread_current_frame_id, record_btrace_start_replaying)
2072         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2073         (cmd_record_btrace_start): Replace throw_exception with throw.
2074         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2075         throw.
2076         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2077         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2078         * linespec.c:
2079         (find_linespec_symbols): Replace throw_exception with throw.
2080         * infrun.c (displaced_step_prepare, resume): Replace
2081         throw_exception with throw.
2082         * infcmd.c (post_create_inferior): Replace throw_exception with
2083         throw.
2084         * inf-loop.c (inferior_event_handler): Replace throw_exception
2085         with throw.
2086         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2087         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2088         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2089         (get_prev_frame_always, get_frame_pc_if_available)
2090         (get_frame_address_in_block_if_available, get_frame_language):
2091         Replace throw_exception with throw.
2092         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2093         throw_exception with throw.
2094         * eval.c (fetch_subexp_value, evaluate_var_value)
2095         (evaluate_funcall, evaluate_subexp_standard): Replace
2096         throw_exception with throw.
2097         * dwarf2loc.c (call_site_find_chain)
2098         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2099         Replace throw_exception with throw.
2100         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2101         with throw.
2102         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2103         throw.
2104         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2105         * completer.c (complete_line_internal): Replace throw_exception
2106         with throw.
2107         * compile/compile-object-run.c (compile_object_run): Replace
2108         throw_exception with throw.
2109         * cli/cli-script.c (process_next_line): Replace throw_exception
2110         with throw.
2111         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2112         (btrace_enable, btrace_maint_update_pt_packets): Replace
2113         throw_exception with throw.
2114         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2115         throw_exception with throw.
2116         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2117         throw_exception with throw.
2118         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2119         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2120         * aarch64-tdep.c (aarch64_make_prologue_cache)
2121         (aarch64_make_stub_cache): Replace throw_exception with throw.
2122
2123 2019-04-08  Tom Tromey  <tom@tromey.com>
2124
2125         * common/common-exceptions.c (throw_exception): Rename from
2126         throw_exception_cxx.  Remove old copy.  Make argument const.
2127         (throw_it): Create and throw exception objects directly.
2128         * common/common-exceptions.h (throw_exception): Make argument
2129         const.
2130         (struct gdb_exception_error): Add constructor.
2131         (struct gdb_exception_quit): Add constructor.
2132
2133 2019-04-08  Tom Tromey  <tom@tromey.com>
2134
2135         * common/common-exceptions.h (exception_rethrow): Don't declare.
2136         (TRY_SJLJ): Update comment.
2137         (TRY, CATCH, END_CATCH): Remove.
2138         * common/common-exceptions.c (exception_rethrow): Remove.
2139
2140 2019-04-08  Tom Tromey  <tom@tromey.com>
2141
2142         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2143         Remove.
2144         (gdb_exception_error): Rename from
2145         gdb_exception_RETURN_MASK_ERROR.
2146         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2147         (gdb_quit_bad_alloc): Update.
2148         * aarch64-tdep.c: Update.
2149         * ada-lang.c: Update.
2150         * ada-typeprint.c: Update.
2151         * ada-valprint.c: Update.
2152         * amd64-tdep.c: Update.
2153         * arch-utils.c: Update.
2154         * break-catch-throw.c: Update.
2155         * breakpoint.c: Update.
2156         * btrace.c: Update.
2157         * c-varobj.c: Update.
2158         * cli/cli-cmds.c: Update.
2159         * cli/cli-interp.c: Update.
2160         * cli/cli-script.c: Update.
2161         * common/common-exceptions.c: Update.
2162         * common/new-op.c: Update.
2163         * common/selftest.c: Update.
2164         * compile/compile-c-symbols.c: Update.
2165         * compile/compile-cplus-symbols.c: Update.
2166         * compile/compile-object-load.c: Update.
2167         * compile/compile-object-run.c: Update.
2168         * completer.c: Update.
2169         * corelow.c: Update.
2170         * cp-abi.c: Update.
2171         * cp-support.c: Update.
2172         * cp-valprint.c: Update.
2173         * darwin-nat.c: Update.
2174         * disasm-selftests.c: Update.
2175         * dtrace-probe.c: Update.
2176         * dwarf-index-cache.c: Update.
2177         * dwarf-index-write.c: Update.
2178         * dwarf2-frame-tailcall.c: Update.
2179         * dwarf2-frame.c: Update.
2180         * dwarf2loc.c: Update.
2181         * dwarf2read.c: Update.
2182         * eval.c: Update.
2183         * event-loop.c: Update.
2184         * event-top.c: Update.
2185         * exec.c: Update.
2186         * f-valprint.c: Update.
2187         * fbsd-tdep.c: Update.
2188         * frame-unwind.c: Update.
2189         * frame.c: Update.
2190         * gdbtypes.c: Update.
2191         * gnu-v3-abi.c: Update.
2192         * guile/guile-internal.h: Update.
2193         * guile/scm-block.c: Update.
2194         * guile/scm-breakpoint.c: Update.
2195         * guile/scm-cmd.c: Update.
2196         * guile/scm-disasm.c: Update.
2197         * guile/scm-frame.c: Update.
2198         * guile/scm-lazy-string.c: Update.
2199         * guile/scm-math.c: Update.
2200         * guile/scm-param.c: Update.
2201         * guile/scm-ports.c: Update.
2202         * guile/scm-pretty-print.c: Update.
2203         * guile/scm-symbol.c: Update.
2204         * guile/scm-symtab.c: Update.
2205         * guile/scm-type.c: Update.
2206         * guile/scm-value.c: Update.
2207         * i386-linux-tdep.c: Update.
2208         * i386-tdep.c: Update.
2209         * inf-loop.c: Update.
2210         * infcall.c: Update.
2211         * infcmd.c: Update.
2212         * infrun.c: Update.
2213         * jit.c: Update.
2214         * language.c: Update.
2215         * linespec.c: Update.
2216         * linux-fork.c: Update.
2217         * linux-nat.c: Update.
2218         * linux-tdep.c: Update.
2219         * linux-thread-db.c: Update.
2220         * main.c: Update.
2221         * mi/mi-cmd-break.c: Update.
2222         * mi/mi-cmd-stack.c: Update.
2223         * mi/mi-interp.c: Update.
2224         * mi/mi-main.c: Update.
2225         * objc-lang.c: Update.
2226         * p-valprint.c: Update.
2227         * parse.c: Update.
2228         * ppc-linux-tdep.c: Update.
2229         * printcmd.c: Update.
2230         * python/py-arch.c: Update.
2231         * python/py-breakpoint.c: Update.
2232         * python/py-cmd.c: Update.
2233         * python/py-finishbreakpoint.c: Update.
2234         * python/py-frame.c: Update.
2235         * python/py-framefilter.c: Update.
2236         * python/py-gdb-readline.c: Update.
2237         * python/py-inferior.c: Update.
2238         * python/py-infthread.c: Update.
2239         * python/py-lazy-string.c: Update.
2240         * python/py-linetable.c: Update.
2241         * python/py-objfile.c: Update.
2242         * python/py-param.c: Update.
2243         * python/py-prettyprint.c: Update.
2244         * python/py-progspace.c: Update.
2245         * python/py-record-btrace.c: Update.
2246         * python/py-record.c: Update.
2247         * python/py-symbol.c: Update.
2248         * python/py-type.c: Update.
2249         * python/py-unwind.c: Update.
2250         * python/py-utils.c: Update.
2251         * python/py-value.c: Update.
2252         * python/python.c: Update.
2253         * record-btrace.c: Update.
2254         * record-full.c: Update.
2255         * remote-fileio.c: Update.
2256         * remote.c: Update.
2257         * riscv-tdep.c: Update.
2258         * rs6000-aix-tdep.c: Update.
2259         * rs6000-tdep.c: Update.
2260         * rust-exp.y: Update.
2261         * rust-lang.c: Update.
2262         * s390-tdep.c: Update.
2263         * selftest-arch.c: Update.
2264         * solib-dsbt.c: Update.
2265         * solib-frv.c: Update.
2266         * solib-spu.c: Update.
2267         * solib-svr4.c: Update.
2268         * solib.c: Update.
2269         * sparc64-linux-tdep.c: Update.
2270         * stack.c: Update.
2271         * symfile-mem.c: Update.
2272         * symmisc.c: Update.
2273         * target.c: Update.
2274         * thread.c: Update.
2275         * top.c: Update.
2276         * tracefile-tfile.c: Update.
2277         * tui/tui.c: Update.
2278         * typeprint.c: Update.
2279         * unittests/cli-utils-selftests.c: Update.
2280         * unittests/parse-connection-spec-selftests.c: Update.
2281         * valops.c: Update.
2282         * valprint.c: Update.
2283         * value.c: Update.
2284         * varobj.c: Update.
2285         * windows-nat.c: Update.
2286         * x86-linux-nat.c: Update.
2287         * xml-support.c: Update.
2288
2289 2019-04-08  Tom Tromey  <tom@tromey.com>
2290
2291         * xml-support.c: Use C++ exception handling.
2292         * x86-linux-nat.c: Use C++ exception handling.
2293         * windows-nat.c: Use C++ exception handling.
2294         * varobj.c: Use C++ exception handling.
2295         * value.c: Use C++ exception handling.
2296         * valprint.c: Use C++ exception handling.
2297         * valops.c: Use C++ exception handling.
2298         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2299         handling.
2300         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2301         * typeprint.c: Use C++ exception handling.
2302         * tui/tui.c: Use C++ exception handling.
2303         * tracefile-tfile.c: Use C++ exception handling.
2304         * top.c: Use C++ exception handling.
2305         * thread.c: Use C++ exception handling.
2306         * target.c: Use C++ exception handling.
2307         * symmisc.c: Use C++ exception handling.
2308         * symfile-mem.c: Use C++ exception handling.
2309         * stack.c: Use C++ exception handling.
2310         * sparc64-linux-tdep.c: Use C++ exception handling.
2311         * solib.c: Use C++ exception handling.
2312         * solib-svr4.c: Use C++ exception handling.
2313         * solib-spu.c: Use C++ exception handling.
2314         * solib-frv.c: Use C++ exception handling.
2315         * solib-dsbt.c: Use C++ exception handling.
2316         * selftest-arch.c: Use C++ exception handling.
2317         * s390-tdep.c: Use C++ exception handling.
2318         * rust-lang.c: Use C++ exception handling.
2319         * rust-exp.y: Use C++ exception handling.
2320         * rs6000-tdep.c: Use C++ exception handling.
2321         * rs6000-aix-tdep.c: Use C++ exception handling.
2322         * riscv-tdep.c: Use C++ exception handling.
2323         * remote.c: Use C++ exception handling.
2324         * remote-fileio.c: Use C++ exception handling.
2325         * record-full.c: Use C++ exception handling.
2326         * record-btrace.c: Use C++ exception handling.
2327         * python/python.c: Use C++ exception handling.
2328         * python/py-value.c: Use C++ exception handling.
2329         * python/py-utils.c: Use C++ exception handling.
2330         * python/py-unwind.c: Use C++ exception handling.
2331         * python/py-type.c: Use C++ exception handling.
2332         * python/py-symbol.c: Use C++ exception handling.
2333         * python/py-record.c: Use C++ exception handling.
2334         * python/py-record-btrace.c: Use C++ exception handling.
2335         * python/py-progspace.c: Use C++ exception handling.
2336         * python/py-prettyprint.c: Use C++ exception handling.
2337         * python/py-param.c: Use C++ exception handling.
2338         * python/py-objfile.c: Use C++ exception handling.
2339         * python/py-linetable.c: Use C++ exception handling.
2340         * python/py-lazy-string.c: Use C++ exception handling.
2341         * python/py-infthread.c: Use C++ exception handling.
2342         * python/py-inferior.c: Use C++ exception handling.
2343         * python/py-gdb-readline.c: Use C++ exception handling.
2344         * python/py-framefilter.c: Use C++ exception handling.
2345         * python/py-frame.c: Use C++ exception handling.
2346         * python/py-finishbreakpoint.c: Use C++ exception handling.
2347         * python/py-cmd.c: Use C++ exception handling.
2348         * python/py-breakpoint.c: Use C++ exception handling.
2349         * python/py-arch.c: Use C++ exception handling.
2350         * printcmd.c: Use C++ exception handling.
2351         * ppc-linux-tdep.c: Use C++ exception handling.
2352         * parse.c: Use C++ exception handling.
2353         * p-valprint.c: Use C++ exception handling.
2354         * objc-lang.c: Use C++ exception handling.
2355         * mi/mi-main.c: Use C++ exception handling.
2356         * mi/mi-interp.c: Use C++ exception handling.
2357         * mi/mi-cmd-stack.c: Use C++ exception handling.
2358         * mi/mi-cmd-break.c: Use C++ exception handling.
2359         * main.c: Use C++ exception handling.
2360         * linux-thread-db.c: Use C++ exception handling.
2361         * linux-tdep.c: Use C++ exception handling.
2362         * linux-nat.c: Use C++ exception handling.
2363         * linux-fork.c: Use C++ exception handling.
2364         * linespec.c: Use C++ exception handling.
2365         * language.c: Use C++ exception handling.
2366         * jit.c: Use C++ exception handling.
2367         * infrun.c: Use C++ exception handling.
2368         * infcmd.c: Use C++ exception handling.
2369         * infcall.c: Use C++ exception handling.
2370         * inf-loop.c: Use C++ exception handling.
2371         * i386-tdep.c: Use C++ exception handling.
2372         * i386-linux-tdep.c: Use C++ exception handling.
2373         * guile/scm-value.c: Use C++ exception handling.
2374         * guile/scm-type.c: Use C++ exception handling.
2375         * guile/scm-symtab.c: Use C++ exception handling.
2376         * guile/scm-symbol.c: Use C++ exception handling.
2377         * guile/scm-pretty-print.c: Use C++ exception handling.
2378         * guile/scm-ports.c: Use C++ exception handling.
2379         * guile/scm-param.c: Use C++ exception handling.
2380         * guile/scm-math.c: Use C++ exception handling.
2381         * guile/scm-lazy-string.c: Use C++ exception handling.
2382         * guile/scm-frame.c: Use C++ exception handling.
2383         * guile/scm-disasm.c: Use C++ exception handling.
2384         * guile/scm-cmd.c: Use C++ exception handling.
2385         * guile/scm-breakpoint.c: Use C++ exception handling.
2386         * guile/scm-block.c: Use C++ exception handling.
2387         * guile/guile-internal.h: Use C++ exception handling.
2388         * gnu-v3-abi.c: Use C++ exception handling.
2389         * gdbtypes.c: Use C++ exception handling.
2390         * frame.c: Use C++ exception handling.
2391         * frame-unwind.c: Use C++ exception handling.
2392         * fbsd-tdep.c: Use C++ exception handling.
2393         * f-valprint.c: Use C++ exception handling.
2394         * exec.c: Use C++ exception handling.
2395         * event-top.c: Use C++ exception handling.
2396         * event-loop.c: Use C++ exception handling.
2397         * eval.c: Use C++ exception handling.
2398         * dwarf2read.c: Use C++ exception handling.
2399         * dwarf2loc.c: Use C++ exception handling.
2400         * dwarf2-frame.c: Use C++ exception handling.
2401         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2402         * dwarf-index-write.c: Use C++ exception handling.
2403         * dwarf-index-cache.c: Use C++ exception handling.
2404         * dtrace-probe.c: Use C++ exception handling.
2405         * disasm-selftests.c: Use C++ exception handling.
2406         * darwin-nat.c: Use C++ exception handling.
2407         * cp-valprint.c: Use C++ exception handling.
2408         * cp-support.c: Use C++ exception handling.
2409         * cp-abi.c: Use C++ exception handling.
2410         * corelow.c: Use C++ exception handling.
2411         * completer.c: Use C++ exception handling.
2412         * compile/compile-object-run.c: Use C++ exception handling.
2413         * compile/compile-object-load.c: Use C++ exception handling.
2414         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2415         * compile/compile-c-symbols.c: Use C++ exception handling.
2416         * common/selftest.c: Use C++ exception handling.
2417         * common/new-op.c: Use C++ exception handling.
2418         * cli/cli-script.c: Use C++ exception handling.
2419         * cli/cli-interp.c: Use C++ exception handling.
2420         * cli/cli-cmds.c: Use C++ exception handling.
2421         * c-varobj.c: Use C++ exception handling.
2422         * btrace.c: Use C++ exception handling.
2423         * breakpoint.c: Use C++ exception handling.
2424         * break-catch-throw.c: Use C++ exception handling.
2425         * arch-utils.c: Use C++ exception handling.
2426         * amd64-tdep.c: Use C++ exception handling.
2427         * ada-valprint.c: Use C++ exception handling.
2428         * ada-typeprint.c: Use C++ exception handling.
2429         * ada-lang.c: Use C++ exception handling.
2430         * aarch64-tdep.c: Use C++ exception handling.
2431
2432 2019-04-08  Tom Tromey  <tom@tromey.com>
2433
2434         * xml-support.c (gdb_xml_parser::parse): Update.
2435         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2436         * value.c (show_convenience): Update.
2437         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2438         (test_parse_flags_qcs): Update.
2439         * thread.c (thr_try_catch_cmd): Update.
2440         * target.c (target_translate_tls_address): Update.
2441         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2442         (info_frame_command_core, frame_apply_command_count): Update.
2443         * rust-exp.y (rust_lex_exception_test): Update.
2444         * riscv-tdep.c (riscv_print_one_register_info): Update.
2445         * remote.c (remote_target::enable_btrace): Update.
2446         * record-btrace.c (record_btrace_enable_warn): Update.
2447         * python/py-utils.c (gdbpy_convert_exception): Update.
2448         * printcmd.c (do_one_display, print_variable_and_value): Update.
2449         * mi/mi-main.c (mi_print_exception): Update.
2450         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2451         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2452         * linux-nat.c (linux_nat_target::attach): Update.
2453         * linux-fork.c (class scoped_switch_fork_info): Update.
2454         * infrun.c (displaced_step_prepare): Update.
2455         * infcall.c (call_function_by_hand_dummy): Update.
2456         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2457         * gnu-v3-abi.c (print_one_vtable): Update.
2458         * frame.c (get_prev_frame_always): Update.
2459         * f-valprint.c (info_common_command_for_block): Update.
2460         * exec.c (try_open_exec_file): Update.
2461         * exceptions.c (print_exception, exception_print)
2462         (exception_fprintf, exception_print_same): Update.
2463         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2464         * dwarf-index-cache.c (index_cache::store)
2465         (index_cache::lookup_gdb_index): Update.
2466         * darwin-nat.c (maybe_cache_shell): Update.
2467         * cp-valprint.c (cp_print_value_fields): Update.
2468         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2469         (gcc_cplus_symbol_address): Update.
2470         * compile/compile-c-symbols.c (gcc_convert_symbol)
2471         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2472         * common/selftest.c: Update.
2473         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2474         a std::string.
2475         (exception_try_scope_entry, exception_try_scope_exit): Don't
2476         declare.
2477         (struct exception_try_scope): Remove.
2478         (TRY): Don't use exception_try_scope.
2479         (struct gdb_exception): Add constructor, operator=.
2480         <what>: New method.
2481         (struct gdb_exception_RETURN_MASK_ALL)
2482         (struct gdb_exception_RETURN_MASK_ERROR)
2483         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2484         (struct gdb_quit_bad_alloc): Update.
2485         * common/common-exceptions.c (exception_none): Change
2486         initializer.
2487         (struct catcher) <state, exception>: Initialize inline.
2488         <prev>: Remove member.
2489         (current_catcher): Remove.
2490         (catchers): New global.
2491         (exceptions_state_mc_init): Simplify.
2492         (catcher_pop): Remove.
2493         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2494         (try_scope_depth, exception_try_scope_entry)
2495         (exception_try_scope_exit): Remove.
2496         (throw_exception_sjlj): Update.
2497         (exception_messages, exception_messages_size): Remove.
2498         (throw_it): Simplify.
2499         (gdb_exception_sliced_copy): Remove.
2500         (throw_exception_cxx): Update.
2501         * cli/cli-script.c (script_from_file): Update.
2502         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2503         Update.
2504         * ada-valprint.c (ada_val_print): Update.
2505         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2506         (create_excep_cond_exprs): Update.
2507
2508 2019-04-08  Tom Tromey  <tom@tromey.com>
2509
2510         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2511         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2512         (TRY, CATCH, END_CATCH): Remove some definitions.
2513         * common/common-exceptions.c: Don't use GDB_XCPT.
2514         (catcher_list_size): Remove.
2515         (throw_exception, throw_it): Simplify.
2516
2517 2019-04-05  Tom Tromey  <tom@tromey.com>
2518
2519         Revert the header-sorting patch.
2520         * ft32-tdep.c: Revert.
2521         * frv-tdep.c: Revert.
2522         * frv-linux-tdep.c: Revert.
2523         * frame.c: Revert.
2524         * frame-unwind.c: Revert.
2525         * frame-base.c: Revert.
2526         * fork-child.c: Revert.
2527         * findvar.c: Revert.
2528         * findcmd.c: Revert.
2529         * filesystem.c: Revert.
2530         * filename-seen-cache.h: Revert.
2531         * filename-seen-cache.c: Revert.
2532         * fbsd-tdep.c: Revert.
2533         * fbsd-nat.h: Revert.
2534         * fbsd-nat.c: Revert.
2535         * f-valprint.c: Revert.
2536         * f-typeprint.c: Revert.
2537         * f-lang.c: Revert.
2538         * extension.h: Revert.
2539         * extension.c: Revert.
2540         * extension-priv.h: Revert.
2541         * expprint.c: Revert.
2542         * exec.h: Revert.
2543         * exec.c: Revert.
2544         * exceptions.c: Revert.
2545         * event-top.c: Revert.
2546         * event-loop.c: Revert.
2547         * eval.c: Revert.
2548         * elfread.c: Revert.
2549         * dwarf2read.h: Revert.
2550         * dwarf2read.c: Revert.
2551         * dwarf2loc.c: Revert.
2552         * dwarf2expr.h: Revert.
2553         * dwarf2expr.c: Revert.
2554         * dwarf2-frame.c: Revert.
2555         * dwarf2-frame-tailcall.c: Revert.
2556         * dwarf-index-write.h: Revert.
2557         * dwarf-index-write.c: Revert.
2558         * dwarf-index-common.c: Revert.
2559         * dwarf-index-cache.h: Revert.
2560         * dwarf-index-cache.c: Revert.
2561         * dummy-frame.c: Revert.
2562         * dtrace-probe.c: Revert.
2563         * disasm.h: Revert.
2564         * disasm.c: Revert.
2565         * disasm-selftests.c: Revert.
2566         * dictionary.c: Revert.
2567         * dicos-tdep.c: Revert.
2568         * demangle.c: Revert.
2569         * dcache.h: Revert.
2570         * dcache.c: Revert.
2571         * darwin-nat.h: Revert.
2572         * darwin-nat.c: Revert.
2573         * darwin-nat-info.c: Revert.
2574         * d-valprint.c: Revert.
2575         * d-namespace.c: Revert.
2576         * d-lang.c: Revert.
2577         * ctf.c: Revert.
2578         * csky-tdep.c: Revert.
2579         * csky-linux-tdep.c: Revert.
2580         * cris-tdep.c: Revert.
2581         * cris-linux-tdep.c: Revert.
2582         * cp-valprint.c: Revert.
2583         * cp-support.c: Revert.
2584         * cp-namespace.c: Revert.
2585         * cp-abi.c: Revert.
2586         * corelow.c: Revert.
2587         * corefile.c: Revert.
2588         * continuations.c: Revert.
2589         * completer.h: Revert.
2590         * completer.c: Revert.
2591         * complaints.c: Revert.
2592         * coffread.c: Revert.
2593         * coff-pe-read.c: Revert.
2594         * cli-out.h: Revert.
2595         * cli-out.c: Revert.
2596         * charset.c: Revert.
2597         * c-varobj.c: Revert.
2598         * c-valprint.c: Revert.
2599         * c-typeprint.c: Revert.
2600         * c-lang.c: Revert.
2601         * buildsym.c: Revert.
2602         * buildsym-legacy.c: Revert.
2603         * build-id.h: Revert.
2604         * build-id.c: Revert.
2605         * btrace.c: Revert.
2606         * bsd-uthread.c: Revert.
2607         * breakpoint.h: Revert.
2608         * breakpoint.c: Revert.
2609         * break-catch-throw.c: Revert.
2610         * break-catch-syscall.c: Revert.
2611         * break-catch-sig.c: Revert.
2612         * blockframe.c: Revert.
2613         * block.c: Revert.
2614         * bfin-tdep.c: Revert.
2615         * bfin-linux-tdep.c: Revert.
2616         * bfd-target.c: Revert.
2617         * bcache.c: Revert.
2618         * ax-general.c: Revert.
2619         * ax-gdb.h: Revert.
2620         * ax-gdb.c: Revert.
2621         * avr-tdep.c: Revert.
2622         * auxv.c: Revert.
2623         * auto-load.c: Revert.
2624         * arm-wince-tdep.c: Revert.
2625         * arm-tdep.c: Revert.
2626         * arm-symbian-tdep.c: Revert.
2627         * arm-pikeos-tdep.c: Revert.
2628         * arm-obsd-tdep.c: Revert.
2629         * arm-nbsd-tdep.c: Revert.
2630         * arm-nbsd-nat.c: Revert.
2631         * arm-linux-tdep.c: Revert.
2632         * arm-linux-nat.c: Revert.
2633         * arm-fbsd-tdep.c: Revert.
2634         * arm-fbsd-nat.c: Revert.
2635         * arm-bsd-tdep.c: Revert.
2636         * arch-utils.c: Revert.
2637         * arc-tdep.c: Revert.
2638         * arc-newlib-tdep.c: Revert.
2639         * annotate.h: Revert.
2640         * annotate.c: Revert.
2641         * amd64-windows-tdep.c: Revert.
2642         * amd64-windows-nat.c: Revert.
2643         * amd64-tdep.c: Revert.
2644         * amd64-sol2-tdep.c: Revert.
2645         * amd64-obsd-tdep.c: Revert.
2646         * amd64-obsd-nat.c: Revert.
2647         * amd64-nbsd-tdep.c: Revert.
2648         * amd64-nbsd-nat.c: Revert.
2649         * amd64-nat.c: Revert.
2650         * amd64-linux-tdep.c: Revert.
2651         * amd64-linux-nat.c: Revert.
2652         * amd64-fbsd-tdep.c: Revert.
2653         * amd64-fbsd-nat.c: Revert.
2654         * amd64-dicos-tdep.c: Revert.
2655         * amd64-darwin-tdep.c: Revert.
2656         * amd64-bsd-nat.c: Revert.
2657         * alpha-tdep.c: Revert.
2658         * alpha-obsd-tdep.c: Revert.
2659         * alpha-nbsd-tdep.c: Revert.
2660         * alpha-mdebug-tdep.c: Revert.
2661         * alpha-linux-tdep.c: Revert.
2662         * alpha-linux-nat.c: Revert.
2663         * alpha-bsd-tdep.c: Revert.
2664         * alpha-bsd-nat.c: Revert.
2665         * aix-thread.c: Revert.
2666         * agent.c: Revert.
2667         * addrmap.c: Revert.
2668         * ada-varobj.c: Revert.
2669         * ada-valprint.c: Revert.
2670         * ada-typeprint.c: Revert.
2671         * ada-tasks.c: Revert.
2672         * ada-lang.c: Revert.
2673         * aarch64-tdep.c: Revert.
2674         * aarch64-ravenscar-thread.c: Revert.
2675         * aarch64-newlib-tdep.c: Revert.
2676         * aarch64-linux-tdep.c: Revert.
2677         * aarch64-linux-nat.c: Revert.
2678         * aarch64-fbsd-tdep.c: Revert.
2679         * aarch64-fbsd-nat.c: Revert.
2680         * aarch32-linux-nat.c: Revert.
2681
2682 2019-04-05  Tom Tromey  <tom@tromey.com>
2683
2684         * ft32-tdep.c: Sort headers.
2685         * frv-tdep.c: Sort headers.
2686         * frv-linux-tdep.c: Sort headers.
2687         * frame.c: Sort headers.
2688         * frame-unwind.c: Sort headers.
2689         * frame-base.c: Sort headers.
2690         * fork-child.c: Sort headers.
2691         * findvar.c: Sort headers.
2692         * findcmd.c: Sort headers.
2693         * filesystem.c: Sort headers.
2694         * filename-seen-cache.h: Sort headers.
2695         * filename-seen-cache.c: Sort headers.
2696         * fbsd-tdep.c: Sort headers.
2697         * fbsd-nat.h: Sort headers.
2698         * fbsd-nat.c: Sort headers.
2699         * f-valprint.c: Sort headers.
2700         * f-typeprint.c: Sort headers.
2701         * f-lang.c: Sort headers.
2702         * extension.h: Sort headers.
2703         * extension.c: Sort headers.
2704         * extension-priv.h: Sort headers.
2705         * expprint.c: Sort headers.
2706         * exec.h: Sort headers.
2707         * exec.c: Sort headers.
2708         * exceptions.c: Sort headers.
2709         * event-top.c: Sort headers.
2710         * event-loop.c: Sort headers.
2711         * eval.c: Sort headers.
2712         * elfread.c: Sort headers.
2713         * dwarf2read.h: Sort headers.
2714         * dwarf2read.c: Sort headers.
2715         * dwarf2loc.c: Sort headers.
2716         * dwarf2expr.h: Sort headers.
2717         * dwarf2expr.c: Sort headers.
2718         * dwarf2-frame.c: Sort headers.
2719         * dwarf2-frame-tailcall.c: Sort headers.
2720         * dwarf-index-write.h: Sort headers.
2721         * dwarf-index-write.c: Sort headers.
2722         * dwarf-index-common.c: Sort headers.
2723         * dwarf-index-cache.h: Sort headers.
2724         * dwarf-index-cache.c: Sort headers.
2725         * dummy-frame.c: Sort headers.
2726         * dtrace-probe.c: Sort headers.
2727         * disasm.h: Sort headers.
2728         * disasm.c: Sort headers.
2729         * disasm-selftests.c: Sort headers.
2730         * dictionary.c: Sort headers.
2731         * dicos-tdep.c: Sort headers.
2732         * demangle.c: Sort headers.
2733         * dcache.h: Sort headers.
2734         * dcache.c: Sort headers.
2735         * darwin-nat.h: Sort headers.
2736         * darwin-nat.c: Sort headers.
2737         * darwin-nat-info.c: Sort headers.
2738         * d-valprint.c: Sort headers.
2739         * d-namespace.c: Sort headers.
2740         * d-lang.c: Sort headers.
2741         * ctf.c: Sort headers.
2742         * csky-tdep.c: Sort headers.
2743         * csky-linux-tdep.c: Sort headers.
2744         * cris-tdep.c: Sort headers.
2745         * cris-linux-tdep.c: Sort headers.
2746         * cp-valprint.c: Sort headers.
2747         * cp-support.c: Sort headers.
2748         * cp-namespace.c: Sort headers.
2749         * cp-abi.c: Sort headers.
2750         * corelow.c: Sort headers.
2751         * corefile.c: Sort headers.
2752         * continuations.c: Sort headers.
2753         * completer.h: Sort headers.
2754         * completer.c: Sort headers.
2755         * complaints.c: Sort headers.
2756         * coffread.c: Sort headers.
2757         * coff-pe-read.c: Sort headers.
2758         * cli-out.h: Sort headers.
2759         * cli-out.c: Sort headers.
2760         * charset.c: Sort headers.
2761         * c-varobj.c: Sort headers.
2762         * c-valprint.c: Sort headers.
2763         * c-typeprint.c: Sort headers.
2764         * c-lang.c: Sort headers.
2765         * buildsym.c: Sort headers.
2766         * buildsym-legacy.c: Sort headers.
2767         * build-id.h: Sort headers.
2768         * build-id.c: Sort headers.
2769         * btrace.c: Sort headers.
2770         * bsd-uthread.c: Sort headers.
2771         * breakpoint.h: Sort headers.
2772         * breakpoint.c: Sort headers.
2773         * break-catch-throw.c: Sort headers.
2774         * break-catch-syscall.c: Sort headers.
2775         * break-catch-sig.c: Sort headers.
2776         * blockframe.c: Sort headers.
2777         * block.c: Sort headers.
2778         * bfin-tdep.c: Sort headers.
2779         * bfin-linux-tdep.c: Sort headers.
2780         * bfd-target.c: Sort headers.
2781         * bcache.c: Sort headers.
2782         * ax-general.c: Sort headers.
2783         * ax-gdb.h: Sort headers.
2784         * ax-gdb.c: Sort headers.
2785         * avr-tdep.c: Sort headers.
2786         * auxv.c: Sort headers.
2787         * auto-load.c: Sort headers.
2788         * arm-wince-tdep.c: Sort headers.
2789         * arm-tdep.c: Sort headers.
2790         * arm-symbian-tdep.c: Sort headers.
2791         * arm-pikeos-tdep.c: Sort headers.
2792         * arm-obsd-tdep.c: Sort headers.
2793         * arm-nbsd-tdep.c: Sort headers.
2794         * arm-nbsd-nat.c: Sort headers.
2795         * arm-linux-tdep.c: Sort headers.
2796         * arm-linux-nat.c: Sort headers.
2797         * arm-fbsd-tdep.c: Sort headers.
2798         * arm-fbsd-nat.c: Sort headers.
2799         * arm-bsd-tdep.c: Sort headers.
2800         * arch-utils.c: Sort headers.
2801         * arc-tdep.c: Sort headers.
2802         * arc-newlib-tdep.c: Sort headers.
2803         * annotate.h: Sort headers.
2804         * annotate.c: Sort headers.
2805         * amd64-windows-tdep.c: Sort headers.
2806         * amd64-windows-nat.c: Sort headers.
2807         * amd64-tdep.c: Sort headers.
2808         * amd64-sol2-tdep.c: Sort headers.
2809         * amd64-obsd-tdep.c: Sort headers.
2810         * amd64-obsd-nat.c: Sort headers.
2811         * amd64-nbsd-tdep.c: Sort headers.
2812         * amd64-nbsd-nat.c: Sort headers.
2813         * amd64-nat.c: Sort headers.
2814         * amd64-linux-tdep.c: Sort headers.
2815         * amd64-linux-nat.c: Sort headers.
2816         * amd64-fbsd-tdep.c: Sort headers.
2817         * amd64-fbsd-nat.c: Sort headers.
2818         * amd64-dicos-tdep.c: Sort headers.
2819         * amd64-darwin-tdep.c: Sort headers.
2820         * amd64-bsd-nat.c: Sort headers.
2821         * alpha-tdep.c: Sort headers.
2822         * alpha-obsd-tdep.c: Sort headers.
2823         * alpha-nbsd-tdep.c: Sort headers.
2824         * alpha-mdebug-tdep.c: Sort headers.
2825         * alpha-linux-tdep.c: Sort headers.
2826         * alpha-linux-nat.c: Sort headers.
2827         * alpha-bsd-tdep.c: Sort headers.
2828         * alpha-bsd-nat.c: Sort headers.
2829         * aix-thread.c: Sort headers.
2830         * agent.c: Sort headers.
2831         * addrmap.c: Sort headers.
2832         * ada-varobj.c: Sort headers.
2833         * ada-valprint.c: Sort headers.
2834         * ada-typeprint.c: Sort headers.
2835         * ada-tasks.c: Sort headers.
2836         * ada-lang.c: Sort headers.
2837         * aarch64-tdep.c: Sort headers.
2838         * aarch64-ravenscar-thread.c: Sort headers.
2839         * aarch64-newlib-tdep.c: Sort headers.
2840         * aarch64-linux-tdep.c: Sort headers.
2841         * aarch64-linux-nat.c: Sort headers.
2842         * aarch64-fbsd-tdep.c: Sort headers.
2843         * aarch64-fbsd-nat.c: Sort headers.
2844         * aarch32-linux-nat.c: Sort headers.
2845
2846 2019-04-04  Tom Tromey  <tom@tromey.com>
2847
2848         * varobj.c (varobj_create): Update.
2849         * rust-exp.y (struct rust_parser) <update_innermost_block,
2850         lookup_symbol>: New methods.
2851         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2852         Rename.
2853         (rust_parser::rust_lookup_type)
2854         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2855         * printcmd.c (display_command, do_one_display): Update.
2856         * parser-defs.h (struct parser_state) <parser_state>: Add
2857         "tracker" parameter.
2858         (block_tracker): New member.
2859         (class innermost_block_tracker) <innermost_block_tracker>: Add
2860         "types" parameter.
2861         <reset>: Remove method.
2862         (innermost_block): Don't declare.
2863         (null_post_parser): Update.
2864         * parse.c (innermost_block): Remove global.
2865         (write_dollar_variable): Update.
2866         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2867         Remove "tracker_types" parameter.
2868         (parse_expression): Add "tracker" parameter.
2869         (parse_expression_for_completion): Update.
2870         (null_post_parser): Add "tracker" parameter.
2871         * p-exp.y: Update rules.
2872         * m2-exp.y: Update rules.
2873         * language.h (struct language_defn) <la_post_parser>: Add
2874         "tracker" parameter.
2875         * go-exp.y: Update rules.
2876         * f-exp.y: Update rules.
2877         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2878         parameter.
2879         * d-exp.y: Update rules.
2880         * c-exp.y: Update rules.
2881         * breakpoint.c (set_breakpoint_condition): Create an
2882         innermost_block_tracker.
2883         (watch_command_1): Likewise.
2884         * ada-lang.c (resolve): Add "tracker" parameter.
2885         (resolve_subexp): Likewise.
2886         * ada-exp.y (write_var_from_sym): Update.
2887
2888 2019-04-04  Tom Tromey  <tom@tromey.com>
2889
2890         * type-stack.h: New file.
2891         * type-stack.c: New file.
2892         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2893         type-stack.h.
2894         (insert_into_type_stack, insert_type, push_type, push_type_int)
2895         (insert_type_address_space, pop_type, pop_type_int)
2896         (pop_typelist, pop_type_stack, append_type_stack)
2897         (push_type_stack, get_type_stack, push_typelist)
2898         (follow_type_instance_flags, follow_types): Don't declare.
2899         * parse.c (type_stack): Remove global.
2900         (parse_exp_in_context): Update.
2901         (insert_into_type_stack, insert_type, push_type, push_type_int)
2902         (insert_type_address_space, pop_type, pop_type_int)
2903         (pop_typelist, pop_type_stack, append_type_stack)
2904         (push_type_stack, get_type_stack, push_typelist)
2905         (follow_type_instance_flags, follow_types): Remove (moved to
2906         type-stack.c).
2907         * f-exp.y (type_stack): New global.
2908         Update rules.
2909         (push_kind_type, f_parse): Update.
2910         * d-exp.y (type_stack): New global.
2911         Update rules.
2912         (d_parse): Update.
2913         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2914         Update rules.
2915         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2916         (HFILES_NO_SRCDIR): Add type-stack.h.
2917
2918 2019-04-04  Tom Tromey  <tom@tromey.com>
2919
2920         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2921         (rust_parser::convert_ast_to_expression, rust_parse)
2922         (rust_lex_test_completion, rust_lex_tests): Update.
2923         * parser-defs.h (struct expr_completion_state): New.
2924         (struct parser_state) <parser_state>: Add completion parameter.
2925         <mark_struct_expression, mark_completion_tag>: New methods.
2926         <parse_completion, m_completion_state>: New members.
2927         (prefixify_expression, null_post_parser): Update.
2928         (mark_struct_expression, mark_completion_tag): Don't declare.
2929         * parse.c (parse_completion, expout_last_struct)
2930         (expout_tag_completion_type, expout_completion_name): Remove
2931         globals.
2932         (parser_state::mark_struct_expression)
2933         (parser_state::mark_completion_tag): Now methods.
2934         (prefixify_expression): Add last_struct parameter.
2935         (prefixify_subexp): Likewise.
2936         (parse_exp_1): Update.
2937         (parse_exp_in_context): Add cstate parameter.  Update.
2938         (parse_expression_for_completion): Create an
2939         expr_completion_state.
2940         (null_post_parser): Add "completion" parameter.
2941         * p-exp.y: Update rules.
2942         (yylex): Update.
2943         * language.h (struct language_defn) <la_post_parser>: Add
2944         "completing" parameter.
2945         * go-exp.y: Update rules.
2946         (lex_one_token): Update.
2947         * expression.h (parse_completion): Don't declare.
2948         * d-exp.y: Update rules.
2949         (lex_one_token): Update rules.
2950         * c-exp.y: Update rules.
2951         (lex_one_token): Update.
2952         * ada-lang.c (resolve): Add "parse_completion" parameter.
2953         (resolve_subexp): Likewise.
2954         (ada_resolve_function): Likewise.
2955
2956 2019-04-04  Tom Tromey  <tom@tromey.com>
2957
2958         * parser-defs.h (struct parser_state) <start_arglist,
2959         end_arglist>: New methods.
2960         <arglist_len, m_funcall_chain>: New members.
2961         (arglist_len, start_arglist, end_arglist): Don't declare.
2962         * parse.c (arglist_len, funcall_chain): Remove global.
2963         (start_arglist, end_arglist): Remove functions.
2964         (parse_exp_in_context): Update.
2965         * p-exp.y: Update rules.
2966         * m2-exp.y: Update rules.
2967         * go-exp.y: Update rules.
2968         * f-exp.y: Update rules.
2969         * d-exp.y: Update rules.
2970         * c-exp.y: Update rules.
2971
2972 2019-04-04  Tom Tromey  <tom@tromey.com>
2973
2974         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2975         lex_operator, push_back>: New methods.
2976         Update all rules.
2977         (rust_parser::lex_hex, lex_escape): Rename and update.
2978         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2979         (rust_parser::lex_operator): Rename and update.
2980         (rust_parser::lex_number, rustyylex, rustyyerror)
2981         (rust_lex_test_init, rust_lex_test_sequence)
2982         (rust_lex_test_push_back, rust_lex_tests): Update.
2983         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2984         parameter.
2985         <lexptr, prev_lexptr>: New members.
2986         (lexptr, prev_lexptr): Don't declare.
2987         * parse.c (lexptr, prev_lexptr): Remove globals.
2988         (parse_exp_in_context): Update.
2989         * p-exp.y (yylex, yyerror): Update.
2990         * m2-exp.y (parse_number, yylex, yyerror): Update.
2991         * go-exp.y (lex_one_token, yyerror): Update.
2992         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2993         * d-exp.y (lex_one_token, yyerror): Update.
2994         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2995         (lex_one_token, yyerror): Update.
2996         * ada-lex.l (YY_INPUT): Update.
2997         (rewind_to_char): Update.
2998         * ada-exp.y (yyerror): Update.
2999
3000 2019-04-04  Tom Tromey  <tom@tromey.com>
3001
3002         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3003         * parser-defs.h (struct parser_state) <parser_state>: Add new
3004         parameter.
3005         <comma_terminates>: New member.
3006         (comma_terminates): Don't declare global.
3007         * parse.c (comma_terminates): Remove global.
3008         (parse_exp_in_context): Update.
3009         * p-exp.y (yylex): Update.
3010         * m2-exp.y (yylex): Update.
3011         * go-exp.y (lex_one_token): Update.
3012         * f-exp.y (yylex): Update.
3013         * d-exp.y (lex_one_token): Update.
3014         * c-exp.y (lex_one_token): Update.
3015         * ada-lex.l: Update.
3016
3017 2019-04-04  Tom Tromey  <tom@tromey.com>
3018
3019         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3020         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3021         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3022         * parser-defs.h (paren_depth): Don't declare.
3023         * parse.c (paren_depth): Remove global.
3024         (parse_exp_in_context): Update.
3025         * p-exp.y (paren_depth): New global.
3026         (pascal_parse): Initialize it.
3027         * m2-exp.y (paren_depth): New global.
3028         (m2_parse): Initialize it.
3029         * go-exp.y (paren_depth): New global.
3030         (go_parse): Initialize it.
3031         * f-exp.y (paren_depth): New global.
3032         (f_parse): Initialize it.
3033         * d-exp.y (paren_depth): New global.
3034         (d_parse): Initialize it.
3035         * c-exp.y (paren_depth): New global.
3036         (c_parse): Initialize it.
3037         * ada-lex.l (paren_depth): New global.
3038         (lexer_init): Initialize it.
3039
3040 2019-04-04  Tom Tromey  <tom@tromey.com>
3041
3042         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3043         (rust_parser::convert_ast_to_type)
3044         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3045         * parser-defs.h (struct parser_state) <parser_state>: Add
3046         parameters.  Initialize new members.
3047         <expression_context_block, expression_context_pc>: New members.
3048         * parse.c (expression_context_block, expression_context_pc):
3049         Remove globals.
3050         (parse_exp_in_context): Update.
3051         * p-exp.y: Update all rules.
3052         (yylex): Update.
3053         * m2-exp.y: Update all rules.
3054         (yylex): Update.
3055         * go-exp.y (yylex): Update.
3056         * f-exp.y (yylex): Update.
3057         * d-exp.y: Update all rules.
3058         (yylex): Update.
3059         * c-exp.y: Update all rules.
3060         (lex_one_token, classify_name, yylex, c_parse): Update.
3061         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3062
3063 2019-04-04  Tom Tromey  <tom@tromey.com>
3064
3065         * gdbarch.h, gdbarch.c: Rebuild.
3066         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3067         * stap-probe.h:
3068         (struct stap_parse_info): Replace "parser_state" with
3069         "expr_builder".
3070         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3071         (parser_state): New class.
3072         * parse.c (expr_builder): Rename.
3073         (expr_builder::release): Rename.
3074         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3075         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3076         (write_exp_elt_longcst, write_exp_elt_floatcst)
3077         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3078         (write_exp_string_vector, write_exp_bitstring)
3079         (write_exp_msymbol, mark_struct_expression)
3080         (write_dollar_variable)
3081         (insert_type_address_space, increase_expout_size): Replace
3082         "parser_state" with "expr_builder".
3083         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3084         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3085         "parser_state" with "expr_builder".
3086
3087 2019-04-04  Tom Tromey  <tom@tromey.com>
3088
3089         * rust-exp.y: Replace "parse_language" with method call.
3090         * p-exp.y:
3091         (yylex): Replace "parse_language" with method call.
3092         * m2-exp.y:
3093         (yylex): Replace "parse_language" with method call.
3094         * go-exp.y (classify_name): Replace "parse_language" with method
3095         call.
3096         * f-exp.y (yylex): Replace "parse_language" with method call.
3097         * d-exp.y (lex_one_token): Replace "parse_language" with method
3098         call.
3099         * c-exp.y:
3100         (lex_one_token, classify_name, yylex): Replace "parse_language"
3101         with method call.
3102         * ada-exp.y (find_primitive_type, type_char)
3103         (type_system_address): Replace "parse_language" with method call.
3104
3105 2019-04-04  Tom Tromey  <tom@tromey.com>
3106
3107         * rust-exp.y: Replace "parse_gdbarch" with method call.
3108         * parse.c (write_dollar_variable, insert_type_address_space):
3109         Replace "parse_gdbarch" with method call.
3110         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3111         call.
3112         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3113         call.
3114         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3115         "parse_gdbarch" with method call.
3116         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3117         with method call.
3118         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3119         "parse_gdbarch" with method call.
3120         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3121         "parse_gdbarch" with method call.
3122         * c-exp.y (parse_type, parse_number, classify_name): Replace
3123         "parse_gdbarch" with method call.
3124         * ada-lex.l: Replace "parse_gdbarch" with method call.
3125         * ada-exp.y (parse_type, find_primitive_type, type_char)
3126         (type_system_address): Replace "parse_gdbarch" with method call.
3127
3128 2019-04-04  Tom Tromey  <tom@tromey.com>
3129
3130         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3131         * stap-probe.c (stap_parse_argument): Update.
3132         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3133         initial_size parameter.
3134         * rust-exp.y (rust_lex_tests): Update.
3135         * parse.c (parser_state): Update.
3136         (parse_exp_in_context): Update.
3137         * parser-defs.h (struct parser_state) <parser_state>: Remove
3138         "initial_size" parameter.
3139
3140 2019-04-04  Tom Tromey  <tom@tromey.com>
3141
3142         * parser-defs.h (increase_expout_size): Don't declare.
3143         * parse.c (increase_expout_size): Now static.
3144
3145 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3146
3147         * gnu-nat.c (gnu_nat_target::wait): Fix
3148         target_waitstatus_to_string call.
3149
3150 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3151
3152         * eval.c (evaluate_subexp_standard): Handle internal functions
3153         during Fortran function call handling.
3154
3155 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * NEWS: Mention new internal functions.
3158         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3159         (read_base_type): Use dwarf2_init_complex_target_type.
3160         * value.c (creal_internal_fn): New function.
3161         (cimag_internal_fn): New function.
3162         (_initialize_values): Register new internal functions.
3163
3164 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3165
3166         * infrun.c (stop_all_threads): If debug_infrun, always
3167         trace the wait status after wait_one, using
3168         target_waitstatus_to_string and target_pid_to_str.
3169         (handle_inferior_event): Replace various trace of
3170         wait status kind by a single trace.
3171         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3172         wait status kind image by target_waitstatus_to_string.
3173         * target/waitstatus.c (target_waitstatus_to_string): Fix
3174         obsolete comment.
3175
3176 2019-04-01  Tom Tromey  <tromey@adacore.com>
3177
3178         PR symtab/23331:
3179         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3180
3181 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3182             Pedro Alves  <palves@redhat.com>
3183
3184         * top.c (quit_force): Call 'finalize_values'.
3185         * value.c (finalize_values): New function.
3186         * value.h (finalize_values): Declare.
3187
3188 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3189
3190         * NEWS: Announce $_gdb_major and $_gdb_minor.
3191
3192         * top.c (init_gdb_version_vars): New function.
3193         (gdb_init): Call init_gdb_version_vars.
3194
3195 2019-03-29  Tom Tromey  <tromey@adacore.com>
3196
3197         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3198         help text.  Remove dead code.
3199
3200 2019-03-29  Keith Seitz  <keiths@redhat.com>
3201
3202         From Siddhesh Poyarekar:
3203         * f-lang.h (f77_get_upperbound): Return LONGEST.
3204         (f77_get_lowerbound): Likewise.
3205         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3206         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3207         print them.
3208         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3209         plongest to format print it.
3210         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3211         (f77_get_upperbound): Likewise.
3212         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3213         LOWER_BOUND to LONGEST.
3214         (f77_create_arrayprint_offset_tbl): Likewise.
3215
3216 2019-03-29  Keith Seitz  <keiths@redhat.com>
3217
3218         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3219         %s/pulongest for TYPE_LENGTH instead of %d in format
3220         strings.
3221         * ada-typerint.c (ada_print_type): Likewise.
3222         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3223         * compile/compile-c-support.c (generate_register_struct): Likewise.
3224         * gdbtypes.c (recursive_dump_type): Likewise.
3225         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3226         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3227         instead of %d in format strings.
3228         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3229         to std::min to ULONGEST.
3230         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3231         instead of %d in format strings.
3232         * tracepoint.c (info_scope_command): Likewise.
3233         * typeprint.c (print_offset_data::update)
3234         (print_offset_data::finish): Likewise.
3235         * xtensa-tdep.c (xtensa_store_return_value)
3236         (xtensa_push_dummy_call): Likewise.
3237
3238 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3239
3240         * windows-nat.c (display_selector): Fixed format specifications
3241         for 64-bit Cygwin.
3242
3243 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3244
3245         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3246
3247 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3248
3249         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3250         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3251         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3252         (nios2_linux_init_abi): Install it.
3253
3254 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3255
3256         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3257
3258 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3259
3260         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3261
3262 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3263             Tom Tromey  <tromey@adacore.com>
3264
3265         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3266
3267 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3268
3269         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3270         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3271         method to compute the bounds of range types. Also print "[evaluated]"
3272         if the bounds' values come from a dynamic evaluation.
3273
3274 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3275
3276         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3277         whitespace when pretty printing is on.
3278
3279 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3280
3281         * ppc-linux-nat.c: Add include.
3282
3283 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3284
3285         * NEWS: Mention AArch64 Pointer Authentication.
3286
3287 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3288
3289         * arm-linux-nat.c: Add include.
3290
3291 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3292
3293         * source-cache.c (source_cache::get_source_lines): Re-read
3294         fullname after calling open_source_file.
3295
3296 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3297
3298         * NEWS: Mention TLS support for FreeBSD.
3299
3300 2019-03-25  Tom Tromey  <tromey@adacore.com>
3301
3302         * minsyms.c (BUNCH_SIZE): Update comment.
3303         (~minimal_symbol_reader): Remove old comment.
3304         (compact_minimal_symbols): Update comment.
3305         (minimal_symbol_reader::install): Remove old comment.  Update
3306         other comments.
3307
3308 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3309
3310         * s390-linux-nat.c: Add include.
3311
3312 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3313
3314         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3315         Call linux_get_hwcap.
3316         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3317         Likewise.
3318         (aarch64_linux_get_hwcap): Remove function.
3319         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3320         declaration.
3321         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3322         linux_get_hwcap.
3323         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3324         * linux-tdep.c (linux_get_hwcap): Add function.
3325         (linux_get_hwcap2): Likewise.
3326         * linux-tdep.h (linux_get_hwcap): Add declaration.
3327         (linux_get_hwcap2): Likewise.
3328         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3329         (ppc_linux_get_hwcap2): Likewise.
3330         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3331         linux_get_hwcap.
3332         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3333         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3334         (ppc_linux_nat_target::read_description): Likewise.
3335         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3336         * s390-linux-nat.c: Likewise.
3337         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3338
3339 2019-03-24  Tom Tromey  <tom@tromey.com>
3340
3341         * ada-lang.c (standard_lookup): Simplify initialization.
3342         (ada_lookup_symbol_nonlocal): Simplify return.
3343         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3344         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3345         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3346         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3347         initialization.
3348         * solib.c (solib_global_lookup): Simplify.
3349         * symtab.c (null_block_symbol): Remove.
3350         (symbol_cache_lookup): Simplify returns.
3351         (lookup_language_this): Simplify returns.
3352         (lookup_symbol_aux): Simplify return.
3353         (lookup_local_symbol): Simplify returns.
3354         (lookup_global_symbol_from_objfile): Simplify return.
3355         (lookup_symbol_in_objfile_symtabs)
3356         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3357         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3358         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3359         * cp-namespace.c (cp_lookup_bare_symbol)
3360         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3361         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3362         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3363         (cp_lookup_symbol_via_imports): Simplify initialization.
3364         (find_symbol_in_baseclass): Likewise.
3365         * symtab.h (null_block_symbol): Remove.
3366         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3367         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3368         (d_lookup_symbol_module): Likewise.
3369         (find_symbol_in_baseclass): Simplify initialization.
3370
3371 2019-03-24  Tom Tromey  <tom@tromey.com>
3372
3373         * expression.h: Don't include symtab.h.
3374         (struct block): Forward declare.
3375
3376 2019-03-24  Tom Tromey  <tom@tromey.com>
3377
3378         * c-exp.y (typebase): Remove casts.
3379         * gdbtypes.c (lookup_unsigned_typename, )
3380         (lookup_signed_typename): Remove cast.
3381         * eval.c (parse_to_comma_and_eval): Remove cast.
3382         * parse.c (write_dollar_variable): Remove cast.
3383         * block.h (struct block) <superblock>: Now const.
3384         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3385         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3386         (map_block): Make "block" const.
3387         * symfile.h (struct quick_symbol_functions)
3388         <map_matching_symbols>: Constify block argument to "callback".
3389         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3390         const.
3391         (find_pc_sect_compunit_symtab): Make "b" const.
3392         (find_symbol_at_address): Likewise.
3393         (search_symbols): Likewise.
3394         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3395         (dw2_debug_names_lookup_symbol): Likewise.
3396         (dw2_map_matching_symbols): Update.
3397         * p-valprint.c (pascal_val_print): Remove "block".
3398         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3399         (aux_add_nonlocal_symbols): Make "block" const.
3400         (resolve_subexp): Remove cast.
3401         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3402         const.
3403         (iterate_over_file_blocks): Likewise.
3404         * f-exp.y (%union) <bval>: Remove.
3405         * coffread.c (patch_opaque_types): Make "b" const.
3406         * spu-tdep.c (spu_catch_start): Make "block" const.
3407         * c-valprint.c (print_unpacked_pointer): Remove "block".
3408         * symmisc.c (dump_symtab_1): Make "b" const.
3409         (block_depth): Make "block" const.
3410         * d-exp.y (%union) <bval>: Remove.
3411         * cp-support.h (cp_lookup_rtti_type): Update.
3412         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3413         * psymtab.c (psym_lookup_symbol): Make "block" const.
3414         (maintenance_check_psymtabs): Make "b" const.
3415         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3416         (enumerate_locals, enumerate_args): Update.
3417         * python/py-symtab.c (stpy_global_block): Make "block" const.
3418         (stpy_static_block): Likewise.
3419         * inline-frame.c (block_starting_point_at): Make "new_block"
3420         const.
3421         * block.c (find_block_in_blockvector): Make return type const.
3422         (blockvector_for_pc_sect): Make "b" const.
3423         (find_block_in_blockvector): Make "b" const.
3424
3425 2019-03-23  Tom Tromey  <tom@tromey.com>
3426
3427         * varobj.c (varobj_create): Update.
3428         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3429         * printcmd.c (display_command, do_one_display): Don't reset
3430         innermost_block.
3431         * parser-defs.h (enum innermost_block_tracker_type): Move to
3432         expression.h.
3433         (innermost_block): Update comment.
3434         * parse.c (parse_exp_1): Add tracker_types parameter.
3435         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3436         tracker_types parameter.  Reset innermost_block.
3437         (parse_exp_in_context): Remove.
3438         (parse_expression_for_completion): Update.
3439         * objfiles.c (~objfile): Don't reset expression_context_block or
3440         innermost_block.
3441         * expression.h (enum innermost_block_tracker_type): Move from
3442         parser-defs.h.
3443         (parse_exp_1): Add tracker_types parameter.
3444         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3445         reset innermost_block.
3446
3447 2019-03-23  Tom Tromey  <tom@tromey.com>
3448
3449         * objfiles.h: Include bcache.h.
3450
3451 2019-03-23  Tom Tromey  <tom@tromey.com>
3452
3453         * linespec.c (get_current_search_block): Use
3454         scoped_restore_current_language.
3455         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3456
3457 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3458             Jiong Wang  <jiong.wang@arm.com>
3459
3460         * aarch64-linux-tdep.c
3461         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3462         section.
3463         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3464
3465 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3466             Jiong Wang  <jiong.wang@arm.com>
3467
3468         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3469         instructions.
3470         (aarch64_analyze_prologue_test): Add PACIASP test.
3471         (aarch64_prologue_prev_register): Unmask PC value.
3472
3473 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3474             Jiong Wang  <jiong.wang@arm.com>
3475
3476         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3477         (aarch64_dwarf2_prev_register): Unmask PC value.
3478         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3479         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3480         DW_CFA_AARCH64_negate_ra_state.
3481         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3482
3483 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3484             Jiong Wang  <jiong.wang@arm.com>
3485
3486         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3487         registers.
3488         (aarch64_pseudo_register_name): Likewise.
3489         (aarch64_pseudo_register_type): Likewise.
3490         (aarch64_pseudo_register_reggroup_p): Likewise.
3491         (aarch64_gdbarch_init): Add pauth registers.
3492         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3493         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3494         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3495         (struct gdbarch_tdep): Add regnum for ra_state.
3496
3497 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3498             Jiong Wang  <jiong.wang@arm.com>
3499
3500         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3501
3502 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3503             Jiong Wang  <jiong.wang@arm.com>
3504
3505         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3506         function.
3507         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3508         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3509         (aarch64_gdbarch_init): Add puth registers.
3510         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3511         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3512         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3513
3514 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3515             Jiong Wang  <jiong.wang@arm.com>
3516
3517         * aarch64-linux-nat.c
3518         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3519         * aarch64-linux-tdep.c
3520         (aarch64_linux_core_read_description): Likewise.
3521         (aarch64_linux_get_hwcap): New function.
3522         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3523         (aarch64_linux_get_hwcap): New declaration.
3524
3525 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3526             Jiong Wang  <jiong.wang@arm.com>
3527
3528         * aarch64-linux-nat.c
3529         (aarch64_linux_nat_target::read_description): Add pauth param.
3530         * aarch64-linux-tdep.c
3531         (aarch64_linux_core_read_description): Likewise.
3532         * aarch64-tdep.c (struct target_desc): Add in pauth.
3533         (aarch64_read_description): Add pauth param.
3534         (aarch64_gdbarch_init): Likewise.
3535         * aarch64-tdep.h (aarch64_read_description): Likewise.
3536         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3537         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3538         * features/Makefile: Add new files.
3539         * features/aarch64-pauth.c: New file.
3540         * features/aarch64-pauth.xml: New file.
3541
3542 2019-03-20  Tom Tromey  <tromey@adacore.com>
3543
3544         * infrun.c (handle_inferior_event): Rename from
3545         handle_inferior_event_1.  Create a scoped_value_mark.
3546         (handle_inferior_event): Remove.
3547
3548 2019-03-19  Tom Tromey  <tromey@adacore.com>
3549
3550         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3551         * infrun.h (print_stop_event): Add "displays" parameter.
3552         * infrun.c (print_stop_event): Add "displays" parameter.
3553
3554 2019-03-19  Pedro Alves  <palves@redhat.com>
3555
3556         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3557         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3558         to -1.  Fix TABs vs spaces.
3559         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3560         * tui/tui-out.h (tui_ui_out) Add intro comments.
3561         <m_line, m_start_of_line>: In-class initialize, and add describing
3562         comment.
3563
3564 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3565
3566         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3567         variable names.
3568         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3569
3570 2019-03-18  Pedro Alves  <palves@redhat.com>
3571             Eli Zaretskii <eliz@gnu.org>
3572
3573         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3574         m_line and m_start_of_line.
3575
3576 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3577
3578         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3579         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3580         it returns a newline.  This fixes a regression in TU mode, whereby
3581         the next line is output on the same screen line as the user input.
3582
3583 2019-03-18  Tom Tromey  <tromey@adacore.com>
3584
3585         * minsyms.c (minimal_symbol_reader::install): Remove call to
3586         obstack_blank.
3587
3588 2019-03-18  Pedro Alves  <palves@redhat.com>
3589
3590         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3591         New globals.
3592         (apply_style): New, factored out from ...
3593         (apply_ansi_escape): ... this.  Handle reverse video mode.
3594         (tui_set_reverse_mode): New function.
3595         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3596         * tui/tui-winsource.c (tui_show_source_line): Use
3597         tui_set_reverse_mode instead of setting A_STANDOUT.
3598         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3599         New setter methods.
3600
3601 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3602
3603         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3604         Handle tabs.
3605
3606 2019-03-18  Tom Tromey  <tromey@adacore.com>
3607
3608         * ada-lang.c (empty_array): Add "high" parameter.
3609         (ada_evaluate_subexp): Update.
3610
3611 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3612
3613         * unittests/string_view-selftests.c: Define
3614         _initialize_string_view_selftests unconditionally.
3615
3616 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3617
3618         PR gdb/24350
3619         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3620
3621 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3622
3623         PR gdb/24351
3624         * windows-nat.c (display_selector): Fix format specifiers.
3625
3626 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3627
3628         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3629         tui_refill_source_window instead of tui_refresh_win, to update the
3630         current execution line.  This fixes redisplay of the current line
3631         when stepping through the code with "next" or "step".
3632
3633 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3634
3635         * source-cache.c (source_cache::get_source_lines): Call
3636         find_source_lines to initialize s->nlines.  This fixes vertical
3637         scrolling of TUI source window when the DOWN arrow is pressed.
3638
3639 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3640
3641         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3642         linux-thread-db.c (_initialize_thread_db): Likewise.
3643
3644 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3645
3646         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3647         wclrtoeol in tui_show_source_line".  This reverts changes made in
3648         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3649
3650 2019-03-15  Tom Tromey  <tom@tromey.com>
3651
3652         * symtab.h (struct minimal_symbol): Derive from
3653         general_symbol_info.
3654         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3655         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3656         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3657         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3658         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3659         (MSYMBOL_SEARCH_NAME): Update.
3660         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3661         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3662         * minsyms.c (minimal_symbol_reader::record_full): Update.
3663
3664 2019-03-15  Tom Tromey  <tom@tromey.com>
3665
3666         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3667
3668 2019-03-15  Tom Tromey  <tom@tromey.com>
3669
3670         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3671         unique_xmalloc_ptr.
3672         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3673         Update.
3674         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3675         (build_minimal_symbol_hash_tables)
3676         (minimal_symbol_reader::install): Update.
3677
3678 2019-03-15  Tom Tromey  <tom@tromey.com>
3679
3680         * symtab.c (create_demangled_names_hash): Update.
3681         (symbol_set_names): Update.
3682         * objfiles.h (struct objfile_per_bfd_storage)
3683         <demangled_names_hash>: Now an htab_up.
3684         * objfiles.c (objfile_per_bfd_storage): Simplify.
3685
3686 2019-03-15  Tom Tromey  <tom@tromey.com>
3687
3688         * objfiles.h (struct objfile_per_bfd_storage): Declare
3689         destructor.
3690         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3691         New.
3692         (get_objfile_bfd_data): Use new.  Don't initialize
3693         language_of_main.
3694         (free_objfile_per_bfd_storage): Remove.
3695         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3696
3697 2019-03-15  Tom Tromey  <tom@tromey.com>
3698
3699         * symfile.c (reread_symbols): Update.
3700         * objfiles.c (objfile::objfile): Update.
3701         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3702         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3703         comment.
3704         (minimal_symbol_reader::install): Update.
3705         (terminate_minimal_symbol_table): Remove.
3706         * jit.c (jit_object_close_impl): Update.
3707
3708 2019-03-15  Tom Tromey  <tom@tromey.com>
3709
3710         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3711         initializations.
3712
3713 2019-03-15  Tom Tromey  <tom@tromey.com>
3714
3715         * objfiles.h (struct objfile_per_bfd_storage)
3716         <demangled_hash_languages>: Now a bitset.
3717         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3718         (lookup_minimal_symbol): Update.
3719
3720 2019-03-15  Tom Tromey  <tom@tromey.com>
3721
3722         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3723         Don't return the symbol.
3724         * coffread.c (record_minimal_symbol): Use record_full.
3725
3726 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3727
3728         The MS-Windows port of ncurses fails to switch to a color pair if
3729         one or both of the colors are the implicit default colors.  This
3730         change records the default colors when TUI is initialized, and
3731         then specifies them explicitly when a color pair uses the default
3732         colors.  This allows color styling in TUI mode on MS-Windows.
3733
3734         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3735         ncurses_norm_attr.
3736         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3737         colors in ncurses_norm_attr.
3738         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3739         "none", replace it with the default color recorded in
3740         ncurses_norm_attr.
3741
3742 2019-03-14  Tom Tromey  <tromey@adacore.com>
3743
3744         * source-cache.h (class source_cache) <get_source_lines>: Return
3745         std::string.
3746         * source-cache.c (source_cache::extract_lines): Handle case where
3747         first_pos==npos.  Return std::string.
3748         (source_cache::get_source_lines): Update.
3749
3750 2019-03-14  Tom Tromey  <tromey@adacore.com>
3751
3752         * NEWS: Add item for "style sources" commands.
3753         * source-cache.c (source_cache::get_source_lines): Check
3754         source_styling.
3755         * cli/cli-style.c (source_styling): New global.
3756         (_initialize_cli_style): Add "style sources" commands.
3757         (show_style_sources): New function.
3758         * cli/cli-style.h (source_styling): Declare.
3759
3760 2019-03-14  Pedro Alves  <palves@redhat.com>
3761             Tom Tromey  <tromey@adacore.com>
3762
3763         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3764         * tui/tui-winsource.c (tui_refill_source_window): New function,
3765         from...
3766         (tui_horizontal_source_scroll): ... here.  Move some logic.
3767         * cli/cli-style.c (set_style_enabled): Notify new observable.
3768         * tui/tui-hooks.c (tui_redisplay_source): New function.
3769         (tui_attach_detach_observers): Attach or detach
3770         tui_redisplay_source.
3771         * observable.h (source_styling_changed): New observable.
3772         * observable.c: Define source_styling_changed observable.
3773
3774 2019-03-13  Tom Tromey  <tromey@adacore.com>
3775
3776         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3777         (i386_gnu_nat_target::store_registers): Update.
3778         * target-debug.h (target_debug_print_std_string): New macro.
3779         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3780         * windows-tdep.c (display_one_tib): Update.
3781         * tui/tui-stack.c (tui_make_status_line): Update.
3782         * top.c (print_inferior_quit_action): Update.
3783         * thread.c (thr_try_catch_cmd): Update.
3784         (add_thread_with_info): Update.
3785         (thread_target_id_str): Update.
3786         (thr_try_catch_cmd): Update.
3787         (thread_command): Update.
3788         (thread_find_command): Update.
3789         * record-btrace.c (record_btrace_target::info_record)
3790         (record_btrace_resume_thread, record_btrace_target::resume)
3791         (record_btrace_cancel_resume, record_btrace_step_thread)
3792         (record_btrace_target::wait, record_btrace_target::wait)
3793         (record_btrace_target::wait, record_btrace_target::stop): Update.
3794         * progspace.c (print_program_space): Update.
3795         * process-stratum-target.c
3796         (process_stratum_target::thread_address_space): Update.
3797         * linux-fork.c (linux_fork_mourn_inferior)
3798         (detach_checkpoint_command, info_checkpoints_command)
3799         (linux_fork_context): Update.
3800         (linux_fork_detach): Update.
3801         (class scoped_switch_fork_info): Update.
3802         (delete_checkpoint_command): Update.
3803         * infrun.c (follow_fork_inferior): Update.
3804         (follow_fork_inferior): Update.
3805         (proceed_after_vfork_done): Update.
3806         (handle_vfork_child_exec_or_exit): Update.
3807         (follow_exec): Update.
3808         (displaced_step_prepare_throw): Update.
3809         (displaced_step_restore): Update.
3810         (start_step_over): Update.
3811         (resume_1): Update.
3812         (clear_proceed_status_thread): Update.
3813         (proceed): Update.
3814         (print_target_wait_results): Update.
3815         (do_target_wait): Update.
3816         (context_switch): Update.
3817         (stop_all_threads): Update.
3818         (restart_threads): Update.
3819         (finish_step_over): Update.
3820         (handle_signal_stop): Update.
3821         (switch_back_to_stepped_thread): Update.
3822         (keep_going_pass_signal): Update.
3823         (print_exited_reason): Update.
3824         (normal_stop): Update.
3825         * inferior.c (inferior_pid_to_str): Change return type.
3826         (print_selected_inferior): Update.
3827         (add_inferior): Update.
3828         (detach_inferior): Update.
3829         * dummy-frame.c (fprint_dummy_frames): Update.
3830         * dcache.c (dcache_info_1): Update.
3831         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3832         (btrace_fetch, btrace_clear): Update.
3833         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3834         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3835         type.
3836         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3837         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3838         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3839         * gdbarch.c, gdbarch.h: Rebuild.
3840         * gdbarch.sh (core_pid_to_str): Change return type.
3841         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3842         return type.
3843         (windows_nat_target::pid_to_str): Change return type.
3844         (windows_delete_thread): Update.
3845         (windows_nat_target::attach): Update.
3846         (windows_nat_target::files_info): Update.
3847         * target-delegates.c: Rebuild.
3848         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3849         return type.
3850         (sol_thread_target::pid_to_str): Change return type.
3851         * remote.c (class remote_target) <pid_to_str>: Change return
3852         type.
3853         (remote_target::pid_to_str): Change return type.
3854         (extended_remote_target::attach, remote_target::remote_stop_ns)
3855         (remote_target::remote_notif_remove_queued_reply)
3856         (remote_target::push_stop_reply, remote_target::disable_btrace):
3857         Update.
3858         (extended_remote_target::attach): Update.
3859         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3860         type.
3861         (gdbsim_target::pid_to_str): Change return type.
3862         * ravenscar-thread.c (struct ravenscar_thread_target)
3863         <pid_to_str>: Change return type.
3864         (ravenscar_thread_target::pid_to_str): Change return type.
3865         * procfs.c (class procfs_target) <pid_to_str>: Change return
3866         type.
3867         (procfs_target::pid_to_str): Change return type.
3868         (procfs_target::attach): Update.
3869         (procfs_target::detach): Update.
3870         (procfs_target::fetch_registers): Update.
3871         (procfs_target::store_registers): Update.
3872         (procfs_target::wait): Update.
3873         (procfs_target::files_info): Update.
3874         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3875         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3876         return type.
3877         (nto_procfs_target::pid_to_str): Change return type.
3878         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3879         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3880         return type.
3881         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3882         (exit_lwp): Update.
3883         (attach_proc_task_lwp_callback, get_detach_signal)
3884         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3885         (linux_nat_target::resume, wait_lwp, stop_callback)
3886         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3887         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3888         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3889         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3890         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3891         type.
3892         (inf_ptrace_target::attach): Update.
3893         (inf_ptrace_target::files_info): Update.
3894         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3895         type.
3896         (go32_nat_target::pid_to_str): Change return type.
3897         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3898         (gnu_nat_target::wait): Update.
3899         (gnu_nat_target::wait): Update.
3900         (gnu_nat_target::resume): Update.
3901         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3902         (fbsd_nat_target::wait): Update.
3903         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3904         type.
3905         (darwin_nat_target::attach): Update.
3906         * corelow.c (class core_target) <pid_to_str>: Change return type.
3907         (core_target::pid_to_str): Change return type.
3908         * target.c (normal_pid_to_str): Change return type.
3909         (default_pid_to_str): Likewise.
3910         (target_pid_to_str): Change return type.
3911         (target_translate_tls_address): Update.
3912         (target_announce_detach): Update.
3913         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3914         return type.
3915         (bsd_uthread_target::pid_to_str): Change return type.
3916         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3917         type.
3918         (bsd_kvm_target::pid_to_str): Change return type.
3919         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3920         return type.
3921         (aix_thread_target::pid_to_str): Change return type.
3922         * target.h (struct target_ops) <pid_to_str>: Change return type.
3923         (target_pid_to_str, normal_pid_to_str): Likewise.
3924         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3925         type.
3926         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3927         type.
3928         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3929         return type.
3930         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3931         type.
3932         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3933         type.
3934         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3935         return type.
3936
3937 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3938
3939         * NEWS: Mention that the new default MI version is 3.  Mention
3940         changes to the output of commands and events that deal with
3941         multi-location breakpoints.
3942         * breakpoint.c: Include "mi/mi-out.h".
3943         (print_one_breakpoint): Change output syntax if using MI version
3944         >= 3.
3945         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3946         New.
3947         (mi_multi_location_breakpoint_output_fixed): New.
3948         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3949         (mi_cmd_fix_multi_location_breakpoint_output): New.
3950         (mi_multi_location_breakpoint_output_fixed): New.
3951         * mi/mi-cmds.c (mi_cmds): Register command
3952         -fix-multi-location-breakpoint-output.
3953         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3954         interpreter "mi".
3955
3956 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3957
3958         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3959         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3960         instantiate mi_ui_out based on interpreter name.
3961         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3962         * mi/mi-main.c (mi_load_progress): Likewise.
3963
3964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3965
3966         * NEWS: Combine separate "New targets" sections for 8.3.
3967
3968 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3969
3970         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3971         (ppcfbsd_init_abi): Install gdbarch
3972         "fetch_tls_load_module_address" and "get_thread_local_address"
3973         methods.
3974
3975 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3976
3977         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3978         (riscv_fbsd_init_abi): Install gdbarch
3979         "fetch_tls_load_module_address" and "get_thread_local_address"
3980         methods.
3981
3982 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3983
3984         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3985         (i386fbsd_init_abi): Install gdbarch
3986         "fetch_tls_load_module_address" and "get_thread_local_address"
3987         methods.
3988
3989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3990
3991         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3992         (amd64fbsd_init_abi): Install gdbarch
3993         "fetch_tls_load_module_address" and "get_thread_local_address"
3994         methods.
3995
3996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3997
3998         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3999         (struct fbsd_pspace_data): New type.
4000         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4001         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4002         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4003         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4004         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4005
4006 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4007
4008         * gdbtypes.c (lookup_struct_elt): New function.
4009         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4010         * gdbtypes.h (struct struct_elt): New type.
4011         (lookup_struct_elt): New prototype.
4012
4013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4014
4015         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4016         remove disabled code block.
4017
4018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4019
4020         * gdbarch.sh (get_thread_local_address): New method.
4021         * gdbarch.h, gdbarch.c: Regenerate.
4022         * target.c (target_translate_tls_address): Use
4023         gdbarch_get_thread_local_address if present instead of
4024         target::get_thread_local_address.
4025
4026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4027
4028         * target.h (target::get_thread_local_address): Update comment.
4029
4030 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4031
4032         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4033         objfile->separate_debug_objfile_backlink if not NULL.
4034
4035 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4036
4037         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4038         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4039         (amd64bsd_store_inferior_registers): Likewise.
4040         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4041         Enable segment base registers.
4042         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4043         PT_GETFSBASE and PT_GETGSBASE.
4044         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4045         PT_SETGSBASE.
4046         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4047         segment base registers.
4048         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4049
4050 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4051
4052         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4053         Update calls to i386_target_description to add 'segments'
4054         parameter.
4055         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4056         add segment base registers.
4057         * arch/i386.c (i386_create_target_description): Add 'segments'
4058         parameter to enable segment base registers.
4059         * arch/i386.h (i386_create_target_description): Likewise.
4060         * features/i386/32bit-segments.xml: New file.
4061         * features/i386/32bit-segments.c: Generate.
4062         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4063         call to i386_target_description to add 'segments' parameter.
4064         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4065         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4066         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4067         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4068         if feature is present.
4069         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4070         Add 'segments' parameter to call to i386_target_description.
4071         (i386_target_description): Add 'segments' parameter to enable
4072         segment base registers.
4073         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4074         to call to i386_target_description.
4075         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4076         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4077         Define I386_NUM_REGS.
4078         (i386_target_description): Add 'segments' parameter to enable
4079         segment base registers.
4080
4081 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4082
4083         PR/24325
4084         * source-cache.c: #undef open and close, to avoid unresolved
4085         externals during linking.
4086
4087 2019-03-12  Tom Tromey  <tromey@adacore.com>
4088
4089         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4090         const.  Add initializers.
4091         (_initialize_remote): Don't initialize ptid globals.
4092
4093 2019-03-12  Pedro Alves  <palves@redhat.com>
4094
4095         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4096
4097 2019-03-12  Pedro Alves  <palves@redhat.com>
4098
4099         * cp-name-parser.y (main): Remove unused 'len' variable.
4100
4101 2019-03-12  Tom Tromey  <tromey@adacore.com>
4102
4103         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4104         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4105
4106 2019-03-12  Tom Tromey  <tromey@adacore.com>
4107
4108         * linux-nat.c (iterate_over_lwps): Update.
4109         (stop_callback): Remove parameter.
4110         (stop_wait_callback, detach_callback, resume_set_callback)
4111         (select_singlestep_lwp_callback, set_ignore_sigint)
4112         (status_callback, resumed_callback, resume_clear_callback)
4113         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4114         data parameter.
4115         (linux_nat_target::detach, linux_nat_target::resume)
4116         (linux_stop_and_wait_all_lwps, select_event_lwp)
4117         (linux_nat_filter_event, linux_nat_wait_1)
4118         (linux_nat_target::kill, linux_nat_target::stop)
4119         (linux_nat_target::stop): Update.
4120         (linux_nat_resume_callback): Change type.
4121         (resume_stopped_resumed_lwps, count_events_callback)
4122         (select_event_lwp_callback): Likewise.
4123         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4124         * arm-linux-nat.c (struct update_registers_data): Remove.
4125         (update_registers_callback): Change type.
4126         (arm_linux_insert_hw_breakpoint1): Update.
4127         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4128         parameter.
4129         (x86_linux_dr_set_addr): Update.
4130         (x86_linux_dr_set_control): Update.
4131         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4132         (iterate_over_lwps): Use gdb::function_view.
4133         * nat/aarch64-linux-hw-point.c (struct
4134         aarch64_dr_update_callback_param): Remove.
4135         (debug_reg_change_callback): Change type.
4136         (aarch64_notify_debug_reg_change): Update.
4137         * s390-linux-nat.c (s390_refresh_per_info): Update.
4138
4139 2019-03-11  Tom Tromey  <tromey@adacore.com>
4140
4141         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4142         redundant assignment to "this_cu".
4143
4144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4145
4146         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4147
4148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4149
4150         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4151         from...
4152         (rank_one_type): ... this.
4153
4154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4155
4156         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4157         from...
4158         (rank_one_type): ... this.
4159
4160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4161
4162         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4163         from...
4164         (rank_one_type): ... this.
4165
4166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4167
4168         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4169         from...
4170         (rank_one_type): ... this.
4171
4172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4173
4174         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4175         from...
4176         (rank_one_type): ... this.
4177
4178 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4179
4180         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4181         from...
4182         (rank_one_type): ... this.
4183
4184 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4185
4186         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4187         from...
4188         (rank_one_type): ... this.
4189
4190 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4191
4192         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4193         from...
4194         (rank_one_type): ... this.
4195
4196 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4197
4198         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4199         from...
4200         (rank_one_type): ... this.
4201
4202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4203
4204         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4205         from...
4206         (rank_one_type): ... this.
4207
4208 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4209
4210         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4211         from...
4212         (rank_one_type): ... this.
4213
4214 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4215
4216         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4217         from...
4218         (rank_one_type): ... this.
4219
4220 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4221
4222         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4223         inferior-events' shows the example events.
4224
4225 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4226
4227         Support styling on native MS-Windows console
4228
4229         PR/24315
4230         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4231         on MS-Windows if $TERM is not defined.
4232
4233         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4234
4235         * posix-hdep.c (gdb_console_fputs):
4236         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4237         functions.
4238         * ui-file.h (gdb_console_fputs): Add prototype.
4239
4240         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4241         back to fputs only if the former returns zero.
4242
4243 2019-03-07  Tom Tromey  <tom@tromey.com>
4244
4245         * symmisc.c (print_symbol_bcache_statistics): Update.
4246         (print_objfile_statistics): Update.
4247         * symfile.c (allocate_symtab): Update.
4248         * stabsread.c: Don't include bcache.h.
4249         * psymtab.h (struct psymbol_bcache): Don't declare.
4250         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4251         (psymbol_bcache_init, psymbol_bcache_free)
4252         (psymbol_bcache_get_bcache): Don't declare.
4253         * psymtab.c (struct psymbol_bcache): Remove.
4254         (psymtab_storage::psymtab_storage): Update.
4255         (psymtab_storage::~psymtab_storage): Update.
4256         (psymbol_bcache_init, psymbol_bcache_free)
4257         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4258         (add_psymbol_to_bcache): Update.
4259         (allocate_psymtab): Update.
4260         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4261         macro_cache>: No longer pointers.
4262         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4263         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4264         * macrotab.c (macro_bcache): Update.
4265         * macroexp.c: Don't include bcache.h.
4266         * gdbtypes.c (check_types_worklist): Update.
4267         (types_deeply_equal): Remove TRY/CATCH.  Update.
4268         * elfread.c (elf_symtab_read): Update.
4269         * dwarf2read.c: Don't include bcache.h.
4270         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4271         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4272         (print_bcache_statistics, bcache_memory_used): Don't declare.
4273         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4274         methods.  Rename all data members.
4275         * bcache.c (struct bcache): Move to bcache.h.
4276         (bcache::expand_hash_table): Rename from expand_hash_table.
4277         (bcache): Remove.
4278         (bcache::insert): Rename from bcache_full.
4279         (bcache::compare): Rename from bcache_compare.
4280         (bcache_xmalloc): Remove.
4281         (bcache::~bcache): Rename from bcache_xfree.
4282         (bcache::print_statistics): Rename from print_bcache_statistics.
4283         (bcache::memory_used): Rename from bcache_memory_used.
4284
4285 2019-03-07  Pedro Alves  <palves@redhat.com>
4286
4287         * infrun.c (normal_stop): Also check for
4288         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4289
4290 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * f-lang.c (value_from_host_double): Moved to...
4293         * value.c (value_from_host_double): ...here.
4294         * value.h (value_from_host_double): Declare.
4295         * guile/scm-math.c (vlscm_convert_typed_number): Use
4296         value_from_host_double.
4297         (vlscm_convert_number): Likewise.
4298         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4299         * python/py-value.c (convert_value_from_python): Likewise.
4300
4301 2019-03-06  Tom Tromey  <tom@tromey.com>
4302
4303         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4304
4305 2019-03-06  Tom Tromey  <tom@tromey.com>
4306
4307         * utils.h (free_current_contents): Don't declare.
4308         * utils.c (free_current_contents): Remove.
4309
4310 2019-03-06  Tom Tromey  <tom@tromey.com>
4311
4312         * top.c (quit_force): Update.
4313         * main.c (captured_command_loop): Update.
4314         * common/new-op.c (operator new): Update.
4315         * common/common-exceptions.c (struct catcher)
4316         <save_cleanup_chain>: Remove member.
4317         (exceptions_state_mc_init): Update.
4318         (exception_try_scope_entry): Return nullptr.
4319         (exception_try_scope_exit, exception_rethrow)
4320         (throw_exception_sjlj, throw_exception_cxx): Update.
4321         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4322         (all_cleanups, do_cleanups, discard_cleanups)
4323         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4324         (restore_cleanups, restore_final_cleanups): Don't declare.
4325         (do_final_cleanups): Remove parameter.
4326         * common/cleanups.c (cleanup_chain, make_cleanup)
4327         (make_cleanup_dtor, all_cleanups, do_cleanups)
4328         (discard_my_cleanups, discard_cleanups)
4329         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4330         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4331         (null_cleanup): Remove.
4332         (do_final_cleanups): Remove parameter.
4333
4334 2019-03-06  Tom Tromey  <tom@tromey.com>
4335
4336         * remote.c (remote_target::remote_parse_stop_reply): Use
4337         unique_xmalloc_ptr.
4338
4339 2019-03-06  Tom Tromey  <tom@tromey.com>
4340
4341         * stabsread.c (struct stabs_field_info): Rename from field_info.
4342         <list, fnlist>: Add initializers.
4343         <obstack>: New member.
4344         (read_member_functions, read_struct_fields, read_baseclasses):
4345         Allocate on obstack.  Don't use cleanups.
4346         (read_one_struct_field, read_member_functions, read_struct_fields)
4347         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4348         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4349         (read_struct_type): Update.
4350
4351 2019-03-06  Tom Tromey  <tom@tromey.com>
4352
4353         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4354         * common/filestuff.h (make_cleanup_close): Don't declare.
4355         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4356         Remove.
4357
4358 2019-03-06  Tom Tromey  <tom@tromey.com>
4359
4360         * solib-aix.c: Use make_scope_exit.
4361
4362 2019-03-06  Tom Tromey  <tom@tromey.com>
4363
4364         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4365         Use make_scope_exit.
4366
4367 2019-03-06  Tom Tromey  <tom@tromey.com>
4368
4369         * solib-svr4.c (disable_probes_interface): Remove parameter.
4370         (svr4_handle_solib_event): Use make_scope_exit.
4371
4372 2019-03-06  Tom Tromey  <tom@tromey.com>
4373
4374         * remote.c (struct stop_reply_deleter): Remove.
4375         (stop_reply_up): Update.
4376         (struct stop_reply): Derive from notif_event.  Don't typedef.
4377         <regcache>: Now a std::vector.
4378         (stop_reply_xfree): Remove.
4379         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4380         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4381         (remote_target::discard_pending_stop_replies): Use delete.
4382         (remote_target::remote_parse_stop_reply): Update.
4383         (remote_target::process_stop_reply): Update.
4384         * remote-notif.h (struct notif_event): Add virtual destructor.
4385         Remove "dtr" member.
4386         (struct notif_client) <alloc_event>: Return a unique_ptr.
4387         (notif_event_xfree): Don't declare.
4388         (notif_event_up): New typedef.
4389         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4390         (notif_event_xfree, do_notif_event_xfree): Remove.
4391         (remote_notif_state_xfree): Update.
4392
4393 2019-03-06  Tom Tromey  <tom@tromey.com>
4394
4395         * infrun.c (displaced_step_clear_cleanup): Now a
4396         forward_scope_exit type.
4397         (displaced_step_prepare_throw): Update.
4398         (displaced_step_fixup): Update.
4399
4400 2019-03-06  Tom Tromey  <tom@tromey.com>
4401
4402         * inferior.h (class inferior): Update comment.
4403         * gdbthread.h (class thread_info): Update comment.
4404
4405 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4406             Tom Tromey  <tom@tromey.com>
4407
4408         * stabsread.h (struct stab_section_list): Remove.
4409         (coffstab_build_psymtabs): Update.
4410         * dbxread.c (symbuf_sections): Now a std::vector.
4411         (sect_idx): New global.
4412         (fill_symbuf): Update.
4413         (coffstab_build_psymtabs): Change type of stabsects parameter.
4414         Update.
4415         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4416         std::vector.
4417         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4418         (coff_locate_sections): Update.
4419         (coff_symfile_read): Remove cleanups.  Update.
4420         (init_stringtab): Add storage parameter.
4421         (free_stringtab, free_stringtab_cleanup): Remove.
4422         (init_lineno): Add storage parameter.
4423         (free_linetab, free_linetab_cleanup): Remove.
4424
4425 2019-03-06  Pedro Alves  <palves@redhat.com>
4426
4427         * linux-fork.c (fork_info::clobber_regs): Delete.
4428         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4429         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4430         comment.  Adjust.
4431         (scoped_switch_fork_info::scoped_switch_fork_info)
4432         (checkpoint_command, linux_fork_context): Adjust
4433         fork_save_infrun_state calls.
4434
4435 2019-03-06  Pedro Alves  <palves@redhat.com>
4436
4437         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4438         (inf_has_multiple_threads): Return 'bool' and rewrite using
4439         inferior_info::threads().
4440
4441 2019-03-06  Pedro Alves  <palves@redhat.com>
4442
4443         * linux-fork.c: Include <list>.
4444         (fork_list): Now a std::list instance.
4445         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4446         (forks_exist_p, find_last_fork): Adjust.
4447         (new_fork): Delete.
4448         (one_fork_p): New.
4449         (add_fork): Adjust.
4450         (free_fork): Delete, folded into fork_info::~fork_info().
4451         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4452         Adjust.
4453         (init_fork_list): Delete.
4454         (linux_fork_killall, linux_fork_mourn_inferior)
4455         (linux_fork_detach, info_checkpoints_command): Adjust.
4456         (_initialize_linux_fork): No longer call init_fork_list.
4457
4458 2019-03-06  Pedro Alves  <palves@redhat.com>
4459
4460         * linux-fork.c (new_fork): New, split out of ...
4461         (add_fork): ... this.  Return void.  Move "first fork" special
4462         case from here, to ...
4463         (checkpoint_command): ... here.
4464         * linux-linux.h (add_fork): Return void.
4465
4466 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4467
4468         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4469
4470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4471             Chris January  <chris.january@arm.com>
4472             David Lecomber  <david.lecomber@arm.com>
4473
4474         * f-exp.y: New token, UNOP_INTRINSIC.
4475         (exp): New pattern using UNOP_INTRINSIC token.
4476         (f77_keywords): Add 'abs' keyword.
4477         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4478         (value_from_host_double): New function.
4479         (evaluate_subexp_f): Support UNOP_ABS.
4480
4481 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4484         types.
4485
4486 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4487
4488         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4489         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4490         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4491
4492 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4493
4494         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4495
4496 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4497             Chris January  <chris.january@arm.com>
4498
4499         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4500         * f-exp.y: Define 'KIND' token.
4501         (exp): New pattern for KIND expressions.
4502         (ptype): Handle types with a kind extension.
4503         (direct_abs_decl): Extend to spot kind extensions.
4504         (f77_keywords): Add 'kind' to the list.
4505         (push_kind_type): New function.
4506         (convert_to_kind_type): New function.
4507         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4508         * parse.c (operator_length_standard): Likewise.
4509         * parser-defs.h (enum type_pieces): Add tp_kind.
4510         * std-operator.def: Add UNOP_KIND.
4511
4512 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4513
4514         * f-exp.y (f_parse): Set yydebug.
4515
4516 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * f-lang.c (evaluate_subexp_f): New function.
4519         (exp_descriptor_f): New global.
4520         (f_language_defn): Use exp_descriptor_f instead of
4521         exp_descriptor_standard.
4522
4523 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4524
4525         * f-exp.y (struct token): Add comments.
4526         (dot_ops): Remove uppercase versions and the end marker.
4527         (f77_keywords): Likewise.
4528         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4529         entries in the dot_ops array are case insensitive, and use
4530         strncasecmp to compare strings.  Also some whitespace cleanup in
4531         this area.  Similar for the f77_keywords array, except entries in
4532         this list might be case sensitive.
4533
4534 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4535
4536         * f-exp.y (struct f77_boolean_val): Add comments.
4537         (boolean_values): Remove uppercase versions, and end marker.
4538         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4539         and use strncasecmp to achieve case insensitivity.  Additionally,
4540         perform whitespace cleanup around this code.
4541
4542 2019-03-06  Tom Tromey  <tromey@adacore.com>
4543
4544         * remote-sim.c (gdbsim_target_open): Use result of
4545         gdb_argv::release.
4546
4547 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4548         Dirk Schubert  <dirk.schubert@arm.com>
4549         Chris January  <chris.january@arm.com>
4550
4551         * eval.c (evaluate_subexp_standard): Call Fortran argument
4552         wrapping logic.
4553         * f-lang.c (struct value): A value which can be passed into a
4554         Fortran function call.
4555         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4556         where appropriate.
4557         (struct type): Value ready for a Fortran function call.
4558         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4559         is needed.
4560         * f-lang.h (fortran_argument_convert): Declaration.
4561         (fortran_preserve_arg_pointer): Declaration.
4562         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4563
4564 2019-03-05  Tom Tromey  <tromey@adacore.com>
4565
4566         * python/py-prettyprint.c (print_string_repr): Remove #if.
4567         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4568
4569 2019-03-05  Tom Tromey  <tromey@adacore.com>
4570
4571         * target.c (the_dummy_target): Move later.  Change type to
4572         "dummy_target".
4573         (initialize_targets): Don't initialize the_dummy_target.
4574
4575 2019-03-05  Tom Tromey  <tromey@adacore.com>
4576
4577         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4578         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4579
4580 2019-03-05  Tom Tromey  <tromey@adacore.com>
4581
4582         * windows-nat.c (windows_nat_target::attach)
4583         (windows_nat_target::detach): Don't call gdb_flush.
4584         * valprint.c (generic_val_print, val_print, val_print_string):
4585         Don't call gdb_flush.
4586         * utils.c (defaulted_query): Don't call gdb_flush.
4587         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4588         * target.c (target_announce_detach): Don't call gdb_flush.
4589         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4590         * remote.c (extended_remote_target::attach): Don't call
4591         gdb_flush.
4592         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4593         * printcmd.c (do_examine): Don't call gdb_flush.
4594         (info_display_command): Don't call gdb_flush.
4595         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4596         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4597         * memattr.c (info_mem_command): Don't call gdb_flush.
4598         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4599         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4600         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4601         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4602         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4603         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4604         (gnu_nat_target::detach): Don't call gdb_flush.
4605         * f-valprint.c (f_val_print): Don't call gdb_flush.
4606         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4607         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4608         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4609         gdb_flush.
4610         * c-valprint.c (c_val_print): Don't call gdb_flush.
4611         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4612
4613 2019-03-05  Tom Tromey  <tromey@adacore.com>
4614
4615         * varobj.c (update_dynamic_varobj_children): Update.
4616         (install_default_visualizer): Use reset, not release.
4617         * value.c (set_internalvar): Update.
4618         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4619         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4620         ATTRIBUTE_UNUSED_RESULT.
4621
4622 2019-03-05  Tom Tromey  <tromey@adacore.com>
4623
4624         * remote.c (class scoped_remote_fd) <release>: Add
4625         ATTRIBUTE_UNUSED_RESULT.
4626
4627 2019-03-05  Tom Tromey  <tromey@adacore.com>
4628
4629         * macroexp.c (struct macro_buffer) <release>: Add
4630         ATTRIBUTE_UNUSED_RESULT.
4631
4632 2019-03-05  Tom Tromey  <tromey@adacore.com>
4633
4634         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4635         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4636         ATTRIBUTE_UNUSED_RESULT.
4637
4638 2019-03-05  Tom Tromey  <tromey@adacore.com>
4639
4640         * common/scoped_fd.h (class scoped_fd) <release>: Add
4641         ATTRIBUTE_UNUSED_RESULT.
4642
4643 2019-03-05  Tom Tromey  <tromey@adacore.com>
4644
4645         * parser-defs.h (struct parser_state) <release>: Add
4646         ATTRIBUTE_UNUSED_RESULT.
4647
4648 2019-03-05  Tom Tromey  <tromey@adacore.com>
4649
4650         * utils.h (class gdb_argv) <release>: Add
4651         ATTRIBUTE_UNUSED_RESULT.
4652         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4653
4654 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4655
4656         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4657         for-loop range, to avoid compiler warnings.
4658
4659         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4660         avoid compiler warnings about unused variables.
4661
4662         * NEWS: Mention end of support for native debugging on MS-Windows
4663         before XP.
4664
4665         PR gdb/24292
4666         * common/netstuff.c:
4667         * gdbserver/gdbreplay.c
4668         * gdbserver/remote-utils.c:
4669         * ser-tcp.c:
4670         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4671         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4672         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4673         'getaddrinfo' and 'freeaddrinfo' were not available before
4674         Windows XP, and mingw.org's MinGW headers by default define
4675         _WIN32_WINNT to 0x500.
4676
4677 2019-03-01  Gary Benson <gbenson@redhat.com>
4678
4679         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4680
4681 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4682             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4683
4684         PR gdb/8527
4685         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4686         set_sigint_trap, clear_sigint_trap.
4687
4688 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4689
4690         * target.c (target_detach): Clear the regcache and the
4691         frame cache.
4692
4693 2019-02-27  Pedro Alves  <palves@redhat.com>
4694
4695         * utils.c (set_screen_size): When we cap the height/width sizes,
4696         tweak the corresponding command variable to show "unlimited":
4697
4698 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4699             Pedro Alves  <palves@redhat.com>
4700
4701         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4702         before calling rl_set_screen_size.
4703
4704 2019-02-27  Tom Tromey  <tromey@adacore.com>
4705
4706         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4707         define.
4708         * python/py-value.c: Remove Python 2.4 workaround.
4709         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4710         workaround.
4711         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4712         Python 2.4 workaround.
4713         * python/python-internal.h: Remove Python 2.4 comment.
4714         (Py_ssize_t): Don't define.
4715         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4716         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4717         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4718         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4719         * python/python.c (do_start_initialization): Remove Python 2.4
4720         workaround.
4721         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4722         (print_children): Remove Python 2.4 workaround.
4723         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4724         workaround.
4725         (CHARBUFFERPROC_NAME): Remove.
4726         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4727         Python 2.4 workaround.
4728
4729 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4730
4731         * NEWS: Note minimum Python version.
4732
4733 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4734
4735         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4736         code from these functions.  Remove corresponding ifdefs.  Use
4737         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4738         Remove gotos and target of gotos.
4739         (infpy_search_memory): Likewise.
4740
4741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4742
4743         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4744         (hppa_gdbarch_init): Don't register deleted functions with
4745         gdbarch.
4746
4747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4748
4749         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4750         (h8300_unwind_sp): Delete.
4751         (h8300_dummy_id): Delete.
4752         (h8300_gdbarch_init): Don't register deleted functions with
4753         gdbarch.
4754
4755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4756
4757         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4758         (ft32_unwind_pc): Delete.
4759         (ft32_unwind_sp): Delete.
4760         (ft32_gdbarch_init): Don't register deleted functions with
4761         gdbarch.
4762
4763 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4764
4765         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4766         (frv_unwind_pc): Delete.
4767         (frv_unwind_sp): Delete.
4768         (frv_gdbarch_init): Don't register deleted functions with
4769         gdbarch.
4770
4771 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4772
4773         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4774         (riscv_unwind_pc): Delete.
4775         (riscv_unwind_sp): Delete.
4776         (riscv_gdbarch_init): Don't register deleted functions with
4777         gdbarch.
4778
4779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4780
4781         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4782         (csky_unwind_pc): Delete.
4783         (csky_unwind_sp): Delete.
4784         (csky_gdbarch_init): Don't register deleted functions with
4785         gdbarch.
4786
4787 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4788
4789         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4790         (cris_unwind_pc): Delete.
4791         (cris_unwind_sp): Delete.
4792         (cris_gdbarch_init): Don't register deleted functions with
4793         gdbarch.
4794
4795 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4796
4797         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4798         (bfin_unwind_pc): Delete.
4799         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4800
4801 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4802
4803         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4804         (arm_unwind_pc): Delete.
4805         (arm_unwind_sp): Delete.
4806         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4807
4808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4809
4810         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4811         (arc_unwind_pc): Delete.
4812         (arc_unwind_sp): Delete.
4813         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4814
4815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4816
4817         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4818         (alpha_unwind_pc): Delete.
4819         (alpha_gdbarch_init): Don't register deleted functions with
4820         gdbarch.
4821
4822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4825         (aarch64_unwind_pc): Delete.
4826         (aarch64_unwind_sp): Delete.
4827         (aarch64_gdbarch_init): Don't register deleted functions with
4828         gdbarch.
4829
4830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4831
4832         * gdbtypes.c (type_align): Don't consider static members when
4833         computing structure alignment.
4834
4835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4836
4837         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4838         return 0 for other types.
4839         * arch-utils.c (default_type_align): Always return 0.
4840         * gdbarch.h: Regenerate.
4841         * gdbarch.sh (type_align): Extend comment.
4842         * gdbtypes.c (type_align): Add additional comments, always call
4843         gdbarch_type_align before applying the default rules.
4844         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4845         generic code will then apply a suitable default.
4846         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4847         types, return 0 for other types.
4848
4849 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4850
4851         * NEWS: Create a new section for the next release branch.
4852         Rename the section of the current branch, now that it has
4853         been cut.
4854
4855 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4856
4857         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4858         * version.in: Bump version to 8.3.50.DATE-git.
4859
4860 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4861
4862         * aix-thread.c (ptid_cmp): Remove unused variable.
4863         (get_signaled_thread): Likewise.
4864         (store_regs_user_thread): Likewise.
4865         (store_regs_kernel_thread): Likewise.
4866         (fetch_regs_kernel_thread): Remove shadowed variable.
4867
4868 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4869
4870         * features/riscv/32bit-cpu.xml: Add register numbers.
4871         * features/riscv/32bit-fpu.c: Regenerate.
4872         * features/riscv/32bit-fpu.xml: Add register numbers.
4873         * features/riscv/64bit-cpu.xml: Add register numbers.
4874         * features/riscv/64bit-fpu.c: Regenerate.
4875         * features/riscv/64bit-fpu.xml: Add register numbers.
4876
4877 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4878
4879         * NEWS: Mention two argument form of gdb.Value constructor.
4880         * python/py-value.c (convert_buffer_and_type_to_value): New
4881         function.
4882         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4883         Add support for handling an optional second argument.  Call
4884         convert_buffer_and_type_to_value as appropriate.
4885         * python/python-internal.h (Py_buffer_deleter): New struct.
4886         (Py_buffer_up): New typedef.
4887
4888 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4889
4890         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4891         instead of releasing ownership.
4892
4893 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4894
4895         * dwarf2read.c (open_and_init_dwp_file): Call
4896         elf_numsections instead of bfd_count_sections to initialize
4897         dwp_file->num_sections.
4898
4899 2019-02-25  Tom Tromey  <tromey@adacore.com>
4900
4901         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4902
4903 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4904
4905         * gcore.in: Add '--readnever' option when invoking GDB.
4906
4907 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4908
4909         * MAINTAINERS: Update my email address.
4910
4911 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4912
4913         * build-id.c (build_id_to_debug_bfd_1): New function.
4914         (build_id_to_debug_bfd): Look for separate debug file in
4915         sysroot.
4916
4917 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4918
4919         * gdbarch.sh: Update the copyright year range that is placed into
4920         generated files.
4921
4922 2019-02-22  Keith Seitz  <keiths@redhat.com>
4923
4924         PR symtab/23853
4925         * linespec.c (create_sals_line_offset): Search for the default
4926         symtab's filename instead of its fullname.
4927
4928 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4929
4930         * NEWS: Update style defaults.
4931
4932 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4933
4934         * main.c (captured_main_1): Disable styling in batch mode.
4935
4936 2019-02-20  Tom Tromey  <tom@tromey.com>
4937
4938         * symtab.c (symtab_symbol_info): Fix typos.
4939
4940 2019-02-20  Tom Tromey  <tromey@adacore.com>
4941
4942         * findcmd.c (_initialize_mem_search): Use upper case for
4943         metasyntactic variables.
4944
4945 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4946
4947         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4948         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4949
4950 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4951
4952         * top.h (source_file_name): Change to std::string.
4953         * top.c (source_file_name): Likewise.
4954         (command_line_input): Adjust.
4955         * cli/cli-script.c (script_from_file): Adjust.
4956
4957 2019-02-19  Tom Tromey  <tromey@adacore.com>
4958
4959         * ravenscar-thread.c
4960         (ravenscar_thread_target::update_thread_list): Don't call
4961         ada_build_task_list.
4962         * ada-lang.h (ada_build_task_list): Don't declare.
4963         * ada-tasks.c (struct ada_tasks_inferior_data)
4964         <task_list_valid_p>: Now bool.
4965         (read_known_tasks, ada_task_list_changed)
4966         (ada_tasks_invalidate_inferior_data): Update.
4967         (read_known_tasks_array): Return bool.
4968         (read_known_tasks_list): Likewise.
4969         (read_known_tasks): Return void.
4970         (ada_build_task_list): Now static.
4971
4972 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4973
4974         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4975         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4976
4977 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4978
4979         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4980         variant for ada_tasks_pspace_data_handle and
4981         ada_tasks_inferior_data_handle.
4982         (ada_tasks_pspace_data_cleanup): New function.
4983         (ada_tasks_inferior_data_cleanup): New function.
4984
4985 2019-02-17  Tom Tromey  <tom@tromey.com>
4986
4987         * macrotab.h (macro_source_fullname): Return a std::string.
4988         * macrotab.c (macro_include, check_for_redefinition)
4989         (macro_undef, macro_lookup_definition, foreach_macro)
4990         (foreach_macro_in_scope): Update.
4991         (macro_source_fullname): Return a std::string.
4992         * macrocmd.c (show_pp_source_pos): Update.
4993
4994 2019-02-17  Tom Tromey  <tom@tromey.com>
4995
4996         * macrocmd.c (show_pp_source_pos): Style the file names.
4997
4998 2019-02-17  Tom Tromey  <tom@tromey.com>
4999
5000         PR tui/24197:
5001         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5002
5003 2019-02-17  Tom Tromey  <tom@tromey.com>
5004
5005         * ada-lang.c (user_select_syms): Use filtered printing.
5006         * utils.c (wrap_style): New global.
5007         (desired_style): Remove.
5008         (emit_style_escape): Add stream parameter.
5009         (set_output_style, reset_terminal_style, prompt_for_continue):
5010         Update.
5011         (flush_wrap_buffer): Only flush gdb_stdout.
5012         (wrap_here): Set wrap_style.
5013         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5014         treat escape sequences as a character.  Change when wrap buffer is
5015         flushed.
5016         (fputs_styled): Do not set the output style when the default is
5017         requested.
5018         * ui-style.h (struct ui_file_style) <is_default>: New method.
5019         * source.c (print_source_lines_base): Emit escape sequences in one
5020         piece.
5021
5022 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5023
5024         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5025         integers and enumeration types.
5026
5027 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5028
5029         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5030         instead of lookup_symbol_in_language
5031         (do_exact_match): New function.
5032         (ada_get_symbol_name_matcher): Return do_exact_match when
5033         doing a verbatim match.
5034
5035 2019-02-15  Tom Tromey  <tromey@adacore.com>
5036
5037         * ravenscar-thread.c (ravenscar_thread_target::resume)
5038         (ravenscar_thread_target::wait): Special case wildcard requests.
5039
5040 2019-02-15  Tom Tromey  <tromey@adacore.com>
5041
5042         * ravenscar-thread.c (base_ptid): Remove.
5043         (struct ravenscar_thread_target) <close>: New method.
5044         <m_base_ptid>: New member.
5045         <update_inferior_ptid, active_task, task_is_currently_active,
5046         runtime_initialized>: Declare methods.
5047         <ravenscar_thread_target>: Add constructor.
5048         (ravenscar_thread_target::task_is_currently_active)
5049         (ravenscar_thread_target::update_inferior_ptid)
5050         (ravenscar_runtime_initialized): Rename.  Now methods.
5051         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5052         (ravenscar_thread_target::update_thread_list): Update.
5053         (ravenscar_thread_target::active_task): Now method.
5054         (ravenscar_thread_target::store_registers)
5055         (ravenscar_thread_target::prepare_to_store)
5056         (ravenscar_thread_target::prepare_to_store)
5057         (ravenscar_thread_target::mourn_inferior): Update.
5058         (ravenscar_inferior_created): Use "new" to create target.
5059         (ravenscar_thread_target::get_ada_task_ptid): Update.
5060         (_initialize_ravenscar): Don't initialize base_ptid.
5061         (ravenscar_ops): Remove global.
5062
5063 2019-02-15  Tom Tromey  <tromey@adacore.com>
5064
5065         * target.h (push_target): Declare new overload.
5066         * target.c (push_target): New overload, taking an rvalue reference.
5067         * remote.c (remote_target::open_1): Use push_target overload.
5068         * corelow.c (core_target_open): Use push_target overload.
5069
5070 2019-02-15  Tom Tromey  <tromey@adacore.com>
5071
5072         * ravenscar-thread.c (is_ravenscar_task)
5073         (ravenscar_task_is_currently_active): Return bool.
5074         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5075         (_initialize_ravenscar): Remove "(void)".
5076         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5077         Return bool.
5078
5079 2019-02-15  Tom Tromey  <tromey@adacore.com>
5080
5081         * ravenscar-thread.c (ravenscar_runtime_initializer)
5082         (has_ravenscar_runtime, get_running_thread_id)
5083         (ravenscar_thread_target::resume): Fix indentation.
5084
5085 2019-02-15  Tom Tromey  <tromey@adacore.com>
5086
5087         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5088         from ravenscar_arch_ops.
5089         (sparc_ravenscar_ops::fetch_registers)
5090         (sparc_ravenscar_ops::store_registers): Now methods.
5091         (sparc_ravenscar_prepare_to_store): Remove.
5092         (sparc_ravenscar_ops): Redefine.
5093         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5094         methods and destructor.  Remove members.
5095         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5096         (ravenscar_thread_target::store_registers)
5097         (ravenscar_thread_target::prepare_to_store): Update.
5098         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5099         Remove.
5100         (struct ppc_ravenscar_powerpc_ops): Derive from
5101         ravenscar_arch_ops.
5102         (ppc_ravenscar_powerpc_ops::fetch_registers)
5103         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5104         (ppc_ravenscar_powerpc_ops): Redefine.
5105         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5106         (ppc_ravenscar_e500_ops::fetch_registers)
5107         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5108         (ppc_ravenscar_e500_ops): Redefine.
5109         * aarch64-ravenscar-thread.c
5110         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5111         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5112         (aarch64_ravenscar_fetch_registers)
5113         (aarch64_ravenscar_store_registers): Now methods.
5114         (aarch64_ravenscar_ops): Redefine.
5115
5116 2019-02-15  Tom Tromey  <tromey@adacore.com>
5117
5118         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5119         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5120         (ravenscar_thread_target::stopped_by_watchpoint)
5121         (ravenscar_thread_target::stopped_data_address)
5122         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5123
5124 2019-02-15  Tom Tromey  <tromey@adacore.com>
5125
5126         * ravenscar-thread.c: Fix some typos.
5127
5128 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5129             Tom Tromey  <tromey@adacore.com>
5130
5131         * ada-lang.c (ada_exception_sal): Change addr_string to a
5132         std::string.
5133         (create_ada_exception_catchpoint): Update.
5134
5135 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5136             Tom Tromey  <tromey@adacore.com>
5137
5138         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5139         (bp_location_ops): Remove.
5140         (base_breakpoint_allocate_location): Update.
5141         (free_bp_location): Update.
5142         * ada-lang.c (class ada_catchpoint_location)
5143         <ada_catchpoint_location>: Remove ops parameter.
5144         (ada_catchpoint_location_dtor): Remove.
5145         (ada_catchpoint_location_ops): Remove.
5146         (allocate_location_exception): Update.
5147         * breakpoint.h (struct bp_location_ops): Remove.
5148         (class bp_location) <bp_location>: Remove bp_location_ops
5149         parameter.
5150         <~bp_location>: Add destructor.
5151         <ops>: Remove.
5152
5153 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5154             Pedro Alves  <palves@redhat.com>
5155
5156         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5157         'PATH_MAX'.
5158
5159 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5160             Samuel Thibault  <samuel.thibault@gnu.org>
5161             Thomas Schwinge  <thomas@codesourcery.com>
5162
5163         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5164         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5165
5166 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5167
5168         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5169         (check_empty): Use "const char *".
5170
5171         * gnu-nat.c (gnu_nat_target::detach): Instead of
5172         'detach_inferior (pid)' call
5173         'detach_inferior (find_inferior_pid (pid))'.
5174
5175         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5176         'nat/fork-inferior.o'.
5177         * gnu-nat.c: #include "nat/fork-inferior.h".
5178
5179         * gnu-nat.c (gnu_nat_target::detach): Instead of
5180         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5181         * gnu-nat.h: #include "inf-child.h".
5182         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5183         'i386_gnu_nat_target::fetch_registers'.
5184         (gnu_store_registers): Rename/move to
5185         'i386_gnu_nat_target::store_registers'.
5186
5187         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5188         * gnu-nat.h (mach_thread_info): New function.
5189         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5190
5191         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5192
5193 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5194
5195         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5196
5197 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5198
5199         * windows-nat.c (windows_add_thread): Add new parameter
5200         "main_thread_p" with default value set to false.  Update
5201         function documentation as well as all callers.
5202         (windows_delete_thread): Likewise.
5203         (fake_create_process): Update call to windows_add_thread.
5204         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5205         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5206         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5207         call to windows_delete_thread.
5208
5209 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5210
5211         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5212
5213 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5214
5215         * symfile.c (find_separate_debug_file): Use canonical path of
5216         sysroot with child_path instead of gdb_sysroot if it is valid.
5217
5218 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5219
5220         * symfile.c (find_separate_debug_file): Use child_path to
5221         determine if an object file is under a sysroot.
5222
5223 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5224
5225         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5226         unittests/child-path-selftests.c.
5227         * common/pathstuff.c (child_path): New function.
5228         * common/pathstuff.h (child_path): New prototype.
5229         * unittests/child-path-selftests.c: New file.
5230
5231 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5232
5233         * symfile.c (find_separate_debug_file): Look for separate debug
5234         files in debug directories under the sysroot.
5235
5236 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5237
5238         * symtab.h (struct minimal_symbol data_p): New const method.
5239         (struct minimal_symbol text_p): Likewise.
5240         * symtab.c (output_source_filename): Use file name style
5241         to print file name.
5242         (print_symbol_info): Likewise.
5243         (print_msymbol_info): Use address style to print addresses.
5244         Use function name style to print executable text symbols.
5245         (expand_symtab_containing_pc): Use data_p.
5246         (find_pc_sect_compunit_symtab): Likewise.
5247
5248 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5249
5250         * breakpoint.c (describe_other_breakpoints): Use address style
5251         to print addresses.
5252         (say_where): Likewise.
5253
5254 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5255
5256         * ada-typeprint.c (print_func_type): Print function name
5257         style to print function name.
5258         * c-typeprint.c (c_print_type_1): Likewise.
5259
5260 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5261
5262         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5263         for execve.
5264
5265 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5266
5267         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5268         type_stack.
5269
5270 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5271
5272         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5273         TYPE_CODE_REF types.
5274
5275 2019-02-08  Jim Wilson  <jimw@sifive.com>
5276
5277         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5278         (riscv_linux_fregset): New.
5279         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5280
5281 2019-02-07  Tom Tromey  <tom@tromey.com>
5282
5283         * thread.c (thread_cancel_execution_command): Update.
5284         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5285         methods.
5286         (struct thread_fsm_ops): Remove.
5287         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5288         (thread_fsm_should_stop, thread_fsm_return_value)
5289         (thread_fsm_set_finished, thread_fsm_finished_p)
5290         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5291         Don't declare.
5292         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5293         * infrun.c (clear_proceed_status_thread)
5294         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5295         (print_stop_event): Update.
5296         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5297         Add constructor.
5298         (step_command_fsm_ops): Remove.
5299         (new_step_command_fsm): Remove.
5300         (step_1): Update.
5301         (step_command_fsm::should_stop): Rename from
5302         step_command_fsm_should_stop.
5303         (step_command_fsm::clean_up): Rename from
5304         step_command_fsm_clean_up.
5305         (step_command_fsm::do_async_reply_reason): Rename from
5306         step_command_fsm_async_reply_reason.
5307         (struct until_next_fsm): Inherit from thread_fsm.  Add
5308         constructor.
5309         (until_next_fsm_ops): Remove.
5310         (new_until_next_fsm): Remove.
5311         (until_next_fsm::should_stop): Rename from
5312         until_next_fsm_should_stop.
5313         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5314         (until_next_fsm::do_async_reply_reason): Rename from
5315         until_next_fsm_async_reply_reason.
5316         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5317         constructor.  Change type of breakpoint.
5318         (finish_command_fsm_ops): Remove.
5319         (new_finish_command_fsm): Remove.
5320         (finish_command_fsm::should_stop): Rename from
5321         finish_command_fsm_should_stop.
5322         (finish_command_fsm::clean_up): Rename from
5323         finish_command_fsm_clean_up.
5324         (finish_command_fsm::return_value): Rename from
5325         finish_command_fsm_return_value.
5326         (finish_command_fsm::do_async_reply_reason): Rename from
5327         finish_command_fsm_async_reply_reason.
5328         (finish_command): Update.
5329         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5330         Add constructor.
5331         (call_thread_fsm_ops): Remove.
5332         (call_thread_fsm::call_thread_fsm): Rename from
5333         new_call_thread_fsm.
5334         (call_thread_fsm::should_stop): Rename from
5335         call_thread_fsm_should_stop.
5336         (call_thread_fsm::should_notify_stop): Rename from
5337         call_thread_fsm_should_notify_stop.
5338         (run_inferior_call, call_function_by_hand_dummy): Update.
5339         * cli/cli-interp.c (should_print_stop_to_console): Update.
5340         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5341         Add constructor.  Change type of location_breakpoint,
5342         caller_breakpoint.
5343         (until_break_fsm_ops): Remove.
5344         (new_until_break_fsm): Remove.
5345         (until_break_fsm::should_stop): Rename from
5346         until_break_fsm_should_stop.
5347         (until_break_fsm::clean_up): Rename from
5348         until_break_fsm_clean_up.
5349         (until_break_fsm::do_async_reply_reason): Rename from
5350         until_break_fsm_async_reply_reason.
5351         (until_break_command): Update.
5352         * thread-fsm.c: Remove.
5353         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5354
5355 2019-02-07  Tom Tromey  <tom@tromey.com>
5356
5357         * yy-remap.h: Add include guard.
5358         * xtensa-tdep.h: Add include guard.
5359         * xcoffread.h: Rename include guard.
5360         * varobj-iter.h: Add include guard.
5361         * tui/tui.h: Rename include guard.
5362         * tui/tui-winsource.h: Rename include guard.
5363         * tui/tui-wingeneral.h: Rename include guard.
5364         * tui/tui-windata.h: Rename include guard.
5365         * tui/tui-win.h: Rename include guard.
5366         * tui/tui-stack.h: Rename include guard.
5367         * tui/tui-source.h: Rename include guard.
5368         * tui/tui-regs.h: Rename include guard.
5369         * tui/tui-out.h: Rename include guard.
5370         * tui/tui-layout.h: Rename include guard.
5371         * tui/tui-io.h: Rename include guard.
5372         * tui/tui-hooks.h: Rename include guard.
5373         * tui/tui-file.h: Rename include guard.
5374         * tui/tui-disasm.h: Rename include guard.
5375         * tui/tui-data.h: Rename include guard.
5376         * tui/tui-command.h: Rename include guard.
5377         * tic6x-tdep.h: Add include guard.
5378         * target/waitstatus.h: Rename include guard.
5379         * target/wait.h: Rename include guard.
5380         * target/target.h: Rename include guard.
5381         * target/resume.h: Rename include guard.
5382         * target-float.h: Rename include guard.
5383         * stabsread.h: Add include guard.
5384         * rs6000-tdep.h: Add include guard.
5385         * riscv-fbsd-tdep.h: Add include guard.
5386         * regformats/regdef.h: Rename include guard.
5387         * record.h: Rename include guard.
5388         * python/python.h: Rename include guard.
5389         * python/python-internal.h: Rename include guard.
5390         * python/py-stopevent.h: Rename include guard.
5391         * python/py-ref.h: Rename include guard.
5392         * python/py-record.h: Rename include guard.
5393         * python/py-record-full.h: Rename include guard.
5394         * python/py-record-btrace.h: Rename include guard.
5395         * python/py-instruction.h: Rename include guard.
5396         * python/py-events.h: Rename include guard.
5397         * python/py-event.h: Rename include guard.
5398         * procfs.h: Add include guard.
5399         * proc-utils.h: Add include guard.
5400         * p-lang.h: Add include guard.
5401         * or1k-tdep.h: Rename include guard.
5402         * observable.h: Rename include guard.
5403         * nto-tdep.h: Rename include guard.
5404         * nat/x86-linux.h: Rename include guard.
5405         * nat/x86-linux-dregs.h: Rename include guard.
5406         * nat/x86-gcc-cpuid.h: Add include guard.
5407         * nat/x86-dregs.h: Rename include guard.
5408         * nat/x86-cpuid.h: Rename include guard.
5409         * nat/ppc-linux.h: Rename include guard.
5410         * nat/mips-linux-watch.h: Rename include guard.
5411         * nat/linux-waitpid.h: Rename include guard.
5412         * nat/linux-ptrace.h: Rename include guard.
5413         * nat/linux-procfs.h: Rename include guard.
5414         * nat/linux-osdata.h: Rename include guard.
5415         * nat/linux-nat.h: Rename include guard.
5416         * nat/linux-namespaces.h: Rename include guard.
5417         * nat/linux-btrace.h: Rename include guard.
5418         * nat/glibc_thread_db.h: Rename include guard.
5419         * nat/gdb_thread_db.h: Rename include guard.
5420         * nat/gdb_ptrace.h: Rename include guard.
5421         * nat/fork-inferior.h: Rename include guard.
5422         * nat/amd64-linux-siginfo.h: Rename include guard.
5423         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5424         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5425         * nat/aarch64-linux.h: Rename include guard.
5426         * nat/aarch64-linux-hw-point.h: Rename include guard.
5427         * mn10300-tdep.h: Add include guard.
5428         * mips-linux-tdep.h: Add include guard.
5429         * mi/mi-parse.h: Rename include guard.
5430         * mi/mi-out.h: Rename include guard.
5431         * mi/mi-main.h: Rename include guard.
5432         * mi/mi-interp.h: Rename include guard.
5433         * mi/mi-getopt.h: Rename include guard.
5434         * mi/mi-console.h: Rename include guard.
5435         * mi/mi-common.h: Rename include guard.
5436         * mi/mi-cmds.h: Rename include guard.
5437         * mi/mi-cmd-break.h: Rename include guard.
5438         * m2-lang.h: Add include guard.
5439         * location.h: Rename include guard.
5440         * linux-record.h: Rename include guard.
5441         * linux-nat.h: Add include guard.
5442         * linux-fork.h: Add include guard.
5443         * i386-darwin-tdep.h: Rename include guard.
5444         * hppa-linux-offsets.h: Add include guard.
5445         * guile/guile.h: Rename include guard.
5446         * guile/guile-internal.h: Rename include guard.
5447         * gnu-nat.h: Rename include guard.
5448         * gdb-stabs.h: Rename include guard.
5449         * frv-tdep.h: Add include guard.
5450         * f-lang.h: Add include guard.
5451         * event-loop.h: Add include guard.
5452         * darwin-nat.h: Rename include guard.
5453         * cp-abi.h: Rename include guard.
5454         * config/sparc/nm-sol2.h: Rename include guard.
5455         * config/nm-nto.h: Rename include guard.
5456         * config/nm-linux.h: Add include guard.
5457         * config/i386/nm-i386gnu.h: Rename include guard.
5458         * config/djgpp/nl_types.h: Rename include guard.
5459         * config/djgpp/langinfo.h: Rename include guard.
5460         * compile/gcc-cp-plugin.h: Add include guard.
5461         * compile/gcc-c-plugin.h: Add include guard.
5462         * compile/compile.h: Rename include guard.
5463         * compile/compile-object-run.h: Rename include guard.
5464         * compile/compile-object-load.h: Rename include guard.
5465         * compile/compile-internal.h: Rename include guard.
5466         * compile/compile-cplus.h: Rename include guard.
5467         * compile/compile-c.h: Rename include guard.
5468         * common/xml-utils.h: Rename include guard.
5469         * common/x86-xstate.h: Rename include guard.
5470         * common/version.h: Rename include guard.
5471         * common/vec.h: Rename include guard.
5472         * common/tdesc.h: Rename include guard.
5473         * common/selftest.h: Rename include guard.
5474         * common/scoped_restore.h: Rename include guard.
5475         * common/scoped_mmap.h: Rename include guard.
5476         * common/scoped_fd.h: Rename include guard.
5477         * common/safe-iterator.h: Rename include guard.
5478         * common/run-time-clock.h: Rename include guard.
5479         * common/refcounted-object.h: Rename include guard.
5480         * common/queue.h: Rename include guard.
5481         * common/ptid.h: Rename include guard.
5482         * common/print-utils.h: Rename include guard.
5483         * common/preprocessor.h: Rename include guard.
5484         * common/pathstuff.h: Rename include guard.
5485         * common/observable.h: Rename include guard.
5486         * common/netstuff.h: Rename include guard.
5487         * common/job-control.h: Rename include guard.
5488         * common/host-defs.h: Rename include guard.
5489         * common/gdb_wait.h: Rename include guard.
5490         * common/gdb_vecs.h: Rename include guard.
5491         * common/gdb_unlinker.h: Rename include guard.
5492         * common/gdb_unique_ptr.h: Rename include guard.
5493         * common/gdb_tilde_expand.h: Rename include guard.
5494         * common/gdb_sys_time.h: Rename include guard.
5495         * common/gdb_string_view.h: Rename include guard.
5496         * common/gdb_splay_tree.h: Rename include guard.
5497         * common/gdb_setjmp.h: Rename include guard.
5498         * common/gdb_ref_ptr.h: Rename include guard.
5499         * common/gdb_optional.h: Rename include guard.
5500         * common/gdb_locale.h: Rename include guard.
5501         * common/gdb_assert.h: Rename include guard.
5502         * common/filtered-iterator.h: Rename include guard.
5503         * common/filestuff.h: Rename include guard.
5504         * common/fileio.h: Rename include guard.
5505         * common/environ.h: Rename include guard.
5506         * common/common-utils.h: Rename include guard.
5507         * common/common-types.h: Rename include guard.
5508         * common/common-regcache.h: Rename include guard.
5509         * common/common-inferior.h: Rename include guard.
5510         * common/common-gdbthread.h: Rename include guard.
5511         * common/common-exceptions.h: Rename include guard.
5512         * common/common-defs.h: Rename include guard.
5513         * common/common-debug.h: Rename include guard.
5514         * common/cleanups.h: Rename include guard.
5515         * common/buffer.h: Rename include guard.
5516         * common/btrace-common.h: Rename include guard.
5517         * common/break-common.h: Rename include guard.
5518         * cli/cli-utils.h: Rename include guard.
5519         * cli/cli-style.h: Rename include guard.
5520         * cli/cli-setshow.h: Rename include guard.
5521         * cli/cli-script.h: Rename include guard.
5522         * cli/cli-interp.h: Rename include guard.
5523         * cli/cli-decode.h: Rename include guard.
5524         * cli/cli-cmds.h: Rename include guard.
5525         * charset-list.h: Add include guard.
5526         * buildsym-legacy.h: Rename include guard.
5527         * bfin-tdep.h: Add include guard.
5528         * ax.h: Rename include guard.
5529         * arm-linux-tdep.h: Add include guard.
5530         * arm-fbsd-tdep.h: Add include guard.
5531         * arch/xtensa.h: Rename include guard.
5532         * arch/tic6x.h: Add include guard.
5533         * arch/i386.h: Add include guard.
5534         * arch/arm.h: Rename include guard.
5535         * arch/arm-linux.h: Rename include guard.
5536         * arch/arm-get-next-pcs.h: Rename include guard.
5537         * arch/amd64.h: Add include guard.
5538         * arch/aarch64-insn.h: Rename include guard.
5539         * arch-utils.h: Rename include guard.
5540         * annotate.h: Add include guard.
5541         * amd64-darwin-tdep.h: Rename include guard.
5542         * aarch64-linux-tdep.h: Add include guard.
5543         * aarch64-fbsd-tdep.h: Add include guard.
5544         * aarch32-linux-nat.h: Add include guard.
5545
5546 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5547
5548         * macrotab.c (macro_define_internal): New function that
5549         factorizes macro_define_object_internal and macro_define_function
5550         code.
5551         (macro_define_object_internal): Use macro_define_internal.
5552         (macro_define_function): Likewise.
5553
5554 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5555
5556         * macrocmd.c (extract_identifier): Return
5557         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5558         callers.
5559
5560 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5561
5562         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5563
5564 2019-02-05  Tom Tromey  <tom@tromey.com>
5565
5566         * target.c (target_stack::unpush): Move assertion earlier.
5567
5568 2019-01-30  Tom Tromey  <tom@tromey.com>
5569
5570         PR python/23615:
5571         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5572         (gdbpy_parse_and_eval): Likewise.
5573         * python/python-internal.h (gdbpy_allow_threads): New class.
5574
5575 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5576
5577         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5578         (aarch64_fbsd_fpregmap): Move earlier.
5579         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5580         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5581         instead of individual calls to trad_frame_set_reg_addr.
5582         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5583         earlier.
5584         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5585         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5586         instead of individual calls to trad_frame_set_reg_addr.
5587
5588 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5589
5590         * CONTRIBUTE: Replace contribution list with wiki link.
5591
5592 2019-01-25  Tom Tromey  <tom@tromey.com>
5593
5594         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5595
5596 2019-01-25  Tom Tromey  <tom@tromey.com>
5597
5598         * xtensa-linux-nat.c: Fix common/ includes.
5599         * xml-support.h: Fix common/ includes.
5600         * xml-support.c: Fix common/ includes.
5601         * x86-linux-nat.c: Fix common/ includes.
5602         * windows-nat.c: Fix common/ includes.
5603         * varobj.h: Fix common/ includes.
5604         * varobj.c: Fix common/ includes.
5605         * value.c: Fix common/ includes.
5606         * valops.c: Fix common/ includes.
5607         * utils.c: Fix common/ includes.
5608         * unittests/xml-utils-selftests.c: Fix common/ includes.
5609         * unittests/utils-selftests.c: Fix common/ includes.
5610         * unittests/unpack-selftests.c: Fix common/ includes.
5611         * unittests/tracepoint-selftests.c: Fix common/ includes.
5612         * unittests/style-selftests.c: Fix common/ includes.
5613         * unittests/string_view-selftests.c: Fix common/ includes.
5614         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5615         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5616         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5617         * unittests/rsp-low-selftests.c: Fix common/ includes.
5618         * unittests/parse-connection-spec-selftests.c: Fix common/
5619         includes.
5620         * unittests/optional-selftests.c: Fix common/ includes.
5621         * unittests/offset-type-selftests.c: Fix common/ includes.
5622         * unittests/observable-selftests.c: Fix common/ includes.
5623         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5624         * unittests/memrange-selftests.c: Fix common/ includes.
5625         * unittests/memory-map-selftests.c: Fix common/ includes.
5626         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5627         * unittests/function-view-selftests.c: Fix common/ includes.
5628         * unittests/environ-selftests.c: Fix common/ includes.
5629         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5630         * unittests/common-utils-selftests.c: Fix common/ includes.
5631         * unittests/cli-utils-selftests.c: Fix common/ includes.
5632         * unittests/array-view-selftests.c: Fix common/ includes.
5633         * ui-file.c: Fix common/ includes.
5634         * tui/tui-io.c: Fix common/ includes.
5635         * tracepoint.h: Fix common/ includes.
5636         * tracepoint.c: Fix common/ includes.
5637         * tracefile-tfile.c: Fix common/ includes.
5638         * top.h: Fix common/ includes.
5639         * top.c: Fix common/ includes.
5640         * thread.c: Fix common/ includes.
5641         * target/waitstatus.h: Fix common/ includes.
5642         * target/waitstatus.c: Fix common/ includes.
5643         * target.h: Fix common/ includes.
5644         * target.c: Fix common/ includes.
5645         * target-memory.c: Fix common/ includes.
5646         * target-descriptions.c: Fix common/ includes.
5647         * symtab.h: Fix common/ includes.
5648         * symfile.c: Fix common/ includes.
5649         * stap-probe.c: Fix common/ includes.
5650         * spu-linux-nat.c: Fix common/ includes.
5651         * sparc-nat.c: Fix common/ includes.
5652         * source.c: Fix common/ includes.
5653         * solib.c: Fix common/ includes.
5654         * solib-target.c: Fix common/ includes.
5655         * ser-unix.c: Fix common/ includes.
5656         * ser-tcp.c: Fix common/ includes.
5657         * ser-pipe.c: Fix common/ includes.
5658         * ser-base.c: Fix common/ includes.
5659         * selftest-arch.c: Fix common/ includes.
5660         * s12z-tdep.c: Fix common/ includes.
5661         * rust-exp.y: Fix common/ includes.
5662         * rs6000-aix-tdep.c: Fix common/ includes.
5663         * riscv-tdep.c: Fix common/ includes.
5664         * remote.c: Fix common/ includes.
5665         * remote-notif.h: Fix common/ includes.
5666         * remote-fileio.h: Fix common/ includes.
5667         * remote-fileio.c: Fix common/ includes.
5668         * regcache.h: Fix common/ includes.
5669         * regcache.c: Fix common/ includes.
5670         * record-btrace.c: Fix common/ includes.
5671         * python/python.c: Fix common/ includes.
5672         * python/py-type.c: Fix common/ includes.
5673         * python/py-inferior.c: Fix common/ includes.
5674         * progspace.h: Fix common/ includes.
5675         * producer.c: Fix common/ includes.
5676         * procfs.c: Fix common/ includes.
5677         * proc-api.c: Fix common/ includes.
5678         * printcmd.c: Fix common/ includes.
5679         * ppc-linux-nat.c: Fix common/ includes.
5680         * parser-defs.h: Fix common/ includes.
5681         * osdata.c: Fix common/ includes.
5682         * obsd-nat.c: Fix common/ includes.
5683         * nat/x86-linux.c: Fix common/ includes.
5684         * nat/x86-linux-dregs.c: Fix common/ includes.
5685         * nat/x86-dregs.h: Fix common/ includes.
5686         * nat/x86-dregs.c: Fix common/ includes.
5687         * nat/ppc-linux.c: Fix common/ includes.
5688         * nat/mips-linux-watch.h: Fix common/ includes.
5689         * nat/mips-linux-watch.c: Fix common/ includes.
5690         * nat/linux-waitpid.c: Fix common/ includes.
5691         * nat/linux-ptrace.h: Fix common/ includes.
5692         * nat/linux-ptrace.c: Fix common/ includes.
5693         * nat/linux-procfs.c: Fix common/ includes.
5694         * nat/linux-personality.c: Fix common/ includes.
5695         * nat/linux-osdata.c: Fix common/ includes.
5696         * nat/linux-namespaces.c: Fix common/ includes.
5697         * nat/linux-btrace.h: Fix common/ includes.
5698         * nat/linux-btrace.c: Fix common/ includes.
5699         * nat/fork-inferior.c: Fix common/ includes.
5700         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5701         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5702         * nat/aarch64-linux.c: Fix common/ includes.
5703         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5704         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5705         * namespace.h: Fix common/ includes.
5706         * mips-linux-tdep.c: Fix common/ includes.
5707         * minsyms.c: Fix common/ includes.
5708         * mi/mi-parse.h: Fix common/ includes.
5709         * mi/mi-main.c: Fix common/ includes.
5710         * mi/mi-cmd-env.c: Fix common/ includes.
5711         * memrange.h: Fix common/ includes.
5712         * memattr.c: Fix common/ includes.
5713         * maint.h: Fix common/ includes.
5714         * maint.c: Fix common/ includes.
5715         * main.c: Fix common/ includes.
5716         * machoread.c: Fix common/ includes.
5717         * location.c: Fix common/ includes.
5718         * linux-thread-db.c: Fix common/ includes.
5719         * linux-nat.c: Fix common/ includes.
5720         * linux-fork.c: Fix common/ includes.
5721         * inline-frame.c: Fix common/ includes.
5722         * infrun.c: Fix common/ includes.
5723         * inflow.c: Fix common/ includes.
5724         * inferior.h: Fix common/ includes.
5725         * inferior.c: Fix common/ includes.
5726         * infcmd.c: Fix common/ includes.
5727         * inf-ptrace.c: Fix common/ includes.
5728         * inf-child.c: Fix common/ includes.
5729         * ia64-linux-nat.c: Fix common/ includes.
5730         * i387-tdep.c: Fix common/ includes.
5731         * i386-tdep.c: Fix common/ includes.
5732         * i386-linux-tdep.c: Fix common/ includes.
5733         * i386-linux-nat.c: Fix common/ includes.
5734         * i386-go32-tdep.c: Fix common/ includes.
5735         * i386-fbsd-tdep.c: Fix common/ includes.
5736         * i386-fbsd-nat.c: Fix common/ includes.
5737         * guile/scm-type.c: Fix common/ includes.
5738         * guile/guile.c: Fix common/ includes.
5739         * go32-nat.c: Fix common/ includes.
5740         * gnu-nat.c: Fix common/ includes.
5741         * gdbthread.h: Fix common/ includes.
5742         * gdbarch-selftests.c: Fix common/ includes.
5743         * gdb_usleep.c: Fix common/ includes.
5744         * gdb_select.h: Fix common/ includes.
5745         * gdb_bfd.c: Fix common/ includes.
5746         * gcore.c: Fix common/ includes.
5747         * fork-child.c: Fix common/ includes.
5748         * findvar.c: Fix common/ includes.
5749         * fbsd-nat.c: Fix common/ includes.
5750         * event-top.c: Fix common/ includes.
5751         * event-loop.c: Fix common/ includes.
5752         * dwarf2read.c: Fix common/ includes.
5753         * dwarf2loc.c: Fix common/ includes.
5754         * dwarf2-frame.c: Fix common/ includes.
5755         * dwarf-index-cache.c: Fix common/ includes.
5756         * dtrace-probe.c: Fix common/ includes.
5757         * disasm-selftests.c: Fix common/ includes.
5758         * defs.h: Fix common/ includes.
5759         * csky-tdep.c: Fix common/ includes.
5760         * cp-valprint.c: Fix common/ includes.
5761         * cp-support.h: Fix common/ includes.
5762         * cp-support.c: Fix common/ includes.
5763         * corelow.c: Fix common/ includes.
5764         * completer.h: Fix common/ includes.
5765         * completer.c: Fix common/ includes.
5766         * compile/compile.c: Fix common/ includes.
5767         * compile/compile-loc2c.c: Fix common/ includes.
5768         * compile/compile-cplus-types.c: Fix common/ includes.
5769         * compile/compile-cplus-symbols.c: Fix common/ includes.
5770         * command.h: Fix common/ includes.
5771         * cli/cli-dump.c: Fix common/ includes.
5772         * cli/cli-cmds.c: Fix common/ includes.
5773         * charset.c: Fix common/ includes.
5774         * build-id.c: Fix common/ includes.
5775         * btrace.h: Fix common/ includes.
5776         * btrace.c: Fix common/ includes.
5777         * breakpoint.h: Fix common/ includes.
5778         * breakpoint.c: Fix common/ includes.
5779         * ax.h:
5780         (enum agent_op): Fix common/ includes.
5781         * ax-general.c (struct aop_map): Fix common/ includes.
5782         * ax-gdb.c: Fix common/ includes.
5783         * auxv.c: Fix common/ includes.
5784         * auto-load.c: Fix common/ includes.
5785         * arm-tdep.c: Fix common/ includes.
5786         * arch/riscv.c: Fix common/ includes.
5787         * arch/ppc-linux-common.c: Fix common/ includes.
5788         * arch/i386.c: Fix common/ includes.
5789         * arch/arm.c: Fix common/ includes.
5790         * arch/arm-linux.c: Fix common/ includes.
5791         * arch/arm-get-next-pcs.c: Fix common/ includes.
5792         * arch/amd64.c: Fix common/ includes.
5793         * arch/aarch64.c: Fix common/ includes.
5794         * arch/aarch64-insn.c: Fix common/ includes.
5795         * arch-utils.c: Fix common/ includes.
5796         * amd64-windows-tdep.c: Fix common/ includes.
5797         * amd64-tdep.c: Fix common/ includes.
5798         * amd64-sol2-tdep.c: Fix common/ includes.
5799         * amd64-obsd-tdep.c: Fix common/ includes.
5800         * amd64-nbsd-tdep.c: Fix common/ includes.
5801         * amd64-linux-tdep.c: Fix common/ includes.
5802         * amd64-linux-nat.c: Fix common/ includes.
5803         * amd64-fbsd-tdep.c: Fix common/ includes.
5804         * amd64-fbsd-nat.c: Fix common/ includes.
5805         * amd64-dicos-tdep.c: Fix common/ includes.
5806         * amd64-darwin-tdep.c: Fix common/ includes.
5807         * agent.c: Fix common/ includes.
5808         * ada-lang.h: Fix common/ includes.
5809         * ada-lang.c: Fix common/ includes.
5810         * aarch64-tdep.c: Fix common/ includes.
5811
5812 2019-01-25  Tom Tromey  <tom@tromey.com>
5813
5814         * common/create-version.sh: Use common/version.h.
5815
5816 2019-01-24  Pedro Alves  <palves@redhat.com>
5817
5818         * infrun.c (signal_stop, signal_print, signal_program)
5819         (signal_catch, signal_pass): Now arrays instead of pointers.
5820         (update_signals_program_target, do_target_resume)
5821         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5822         * linux-nat.c (linux_nat_target::pass_signals)
5823         (linux_nat_target::create_inferior, linux_nat_target::attach):
5824         Adjust.
5825         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5826         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5827         * procfs.c (procfs_target::pass_signals): Adjust.
5828         * record-full.c (record_full_target::resume): Adjust.
5829         * remote.c (remote_target::pass_signals)
5830         (remote_target::program_signals): Adjust.
5831         * target-debug.h (target_debug_print_signals): Now takes a
5832         gdb::array_view as parameter.  Adjust.
5833         * target.h (target_ops) <pass_signals, program_signals>: Replace
5834         pointer and length parameters with gdb::array_view.
5835         (target_pass_signals, target_program_signals): Likewise.
5836         * target-delegates.c: Regenerate.
5837
5838 2019-01-24  Pedro Alves  <palves@redhat.com>
5839
5840         * common/forward-scope-exit.h
5841         (forward_scope_exit::forward_scope_exit): Pass arguments to
5842         m_bind_function directly, instead of creating a std::bind and
5843         copying that.
5844
5845 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5846
5847         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5848         for static members.
5849         (pass_in_v_vfp_candidate): Likewise.
5850
5851 2019-01-23  Tom Tromey  <tom@tromey.com>
5852             Pedro Alves  <palves@redhat.com>
5853
5854         * regcache.c (class regcache_invalidator): Remove.
5855         (regcache::raw_write): Use make_scope_exit.
5856
5857 2019-01-23  Tom Tromey  <tom@tromey.com>
5858
5859         * ui-out.h (class ui_out_emit_type): Update comment.
5860
5861 2019-01-23  Tom Tromey  <tom@tromey.com>
5862
5863         * infrun.c (fetch_inferior_event): Update comment.
5864
5865 2019-01-23  Tom Tromey  <tom@tromey.com>
5866             Pedro Alves  <palves@redhat.com>
5867
5868         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5869         parameter.
5870         (fetch_inferior_event): Use SCOPE_EXIT.
5871
5872
5873 2019-01-23  Tom Tromey  <tom@tromey.com>
5874             Pedro Alves  <palves@redhat.com>
5875
5876         * infrun.c (disable_thread_events): Delete.
5877         (stop_all_threads): Use SCOPE_EXIT.
5878
5879 2019-01-23  Tom Tromey  <tom@tromey.com>
5880             Pedro Alves  <palves@redhat.com>
5881
5882         * symfile.c: Include forward-scope-exit.h.
5883         (clear_symtab_users_cleanup): Replace forward declaration with
5884         a FORWARD_SCOPE_EXIT.
5885         (syms_from_objfile_1): Use the forward_scope_exit and
5886         gdb::optional instead of cleanup_function.
5887         (reread_symbols): Use the forward_scope_exit instead of
5888         cleanup_function.
5889         (clear_symtab_users_cleanup): Remove function.
5890
5891 2019-01-23  Tom Tromey  <tom@tromey.com>
5892             Pedro Alves  <palves@redhat.com>
5893
5894         * linux-nat.c: Include scope-exit.h.
5895         (cleanup_target_stop): Remove.
5896         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5897         SCOPE_EXIT.
5898
5899 2019-01-23  Tom Tromey  <tom@tromey.com>
5900             Pedro Alves  <palves@redhat.com>
5901
5902         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5903         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5904
5905 2019-01-23  Tom Tromey  <tom@tromey.com>
5906             Andrew Burgess  <andrew.burgess@embecosm.com>
5907             Pedro Alves  <palves@redhat.com>
5908
5909         * infrun.c (fetch_inferior_event): Use scope_exit.
5910         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5911         * top.c (execute_command): Use scope_exit.
5912         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5913         * utils.c (do_bpstat_clear_actions_cleanup)
5914         (make_bpstat_clear_actions_cleanup): Remove.
5915
5916 2019-01-23  Tom Tromey  <tom@tromey.com>
5917             Pedro Alves  <palves@redhat.com>
5918
5919         * infrun.c: Include "common/scope-exit.h"
5920         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5921         (wait_for_inferior): Use SCOPE_EXIT.
5922         (fetch_inferior_event): Use scope_exit.
5923
5924 2019-01-23  Tom Tromey  <tom@tromey.com>
5925             Pedro Alves  <palves@redhat.com>
5926
5927         * breakpoint.c (create_breakpoint): Remove cleanup.
5928
5929 2019-01-23  Tom Tromey  <tom@tromey.com>
5930             Andrew Burgess  <andrew.burgess@embecosm.com>
5931             Pedro Alves  <palves@redhat.com>
5932
5933 2019-01-23  Pedro Alves  <palves@redhat.com>
5934
5935         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5936
5937 2019-01-23  Pedro Alves  <palves@redhat.com>
5938             Andrew Burgess  <andrew.burgess@embecosm.com>
5939
5940         * gdbthread.h: Include "common/forward-scope-exit.h".
5941         (scoped_finish_thread_state): Redefine custom class in terms of
5942         forward_scope_exit.
5943
5944 2019-01-23  Pedro Alves  <palves@redhat.com>
5945             Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * common/forward-scope-exit.h: New file.
5948
5949 2019-01-23  Pedro Alves  <palves@redhat.com>
5950             Andrew Burgess  <andrew.burgess@embecosm.com>
5951             Tom Tromey  <tom@tromey.com>
5952
5953         * common/scope-exit.h: New file.
5954
5955 2019-01-23  Pedro Alves  <palves@redhat.com>
5956
5957         * common/preprocessor.h (ESC): Rename to ...
5958         (ESC_PARENS): ... this.
5959         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5960         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5961
5962 2019-01-23  Tom Tromey  <tom@tromey.com>
5963
5964         * language.h (class scoped_switch_to_sym_language_if_auto):
5965         Initialize m_lang in both cases.
5966
5967 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5968
5969         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5970         with XCNEW.
5971
5972 2019-01-22  Tom Tromey  <tom@tromey.com>
5973
5974         * corelow.c: Do not include sys/file.h.
5975
5976 2019-01-22  Tom Tromey  <tom@tromey.com>
5977
5978         * tui/tui-wingeneral.h: Include gdb_curses.h.
5979
5980 2019-01-22  Tom Tromey  <tom@tromey.com>
5981
5982         * source-cache.h (class source_cache) <get_source_lines,
5983         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5984
5985 2019-01-22  Tom Tromey  <tom@tromey.com>
5986
5987         * remote-fileio.h (struct remote_target): Declare.
5988
5989 2019-01-22  Tom Tromey  <tom@tromey.com>
5990
5991         * python/py-arch.c: Do not include py-ref.h.
5992         * python/py-bpevent.c: Do not include py-ref.h.
5993         * python/py-cmd.c: Do not include py-ref.h.
5994         * python/py-continueevent.c: Do not include py-ref.h.
5995         * python/py-event.h: Do not include py-ref.h.
5996         * python/py-evtregistry.c: Do not include py-ref.h.
5997         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5998         * python/py-frame.c: Do not include py-ref.h.
5999         * python/py-framefilter.c: Do not include py-ref.h.
6000         * python/py-function.c: Do not include py-ref.h.
6001         * python/py-infevents.c: Do not include py-ref.h.
6002         * python/py-linetable.c: Do not include py-ref.h.
6003         * python/py-objfile.c: Do not include py-ref.h.
6004         * python/py-param.c: Do not include py-ref.h.
6005         * python/py-prettyprint.c: Do not include py-ref.h.
6006         * python/py-progspace.c: Do not include py-ref.h.
6007         * python/py-symbol.c: Do not include py-ref.h.
6008         * python/py-symtab.c: Do not include py-ref.h.
6009         * python/py-type.c: Do not include py-ref.h.
6010         * python/py-unwind.c: Do not include py-ref.h.
6011         * python/py-utils.c: Do not include py-ref.h.
6012         * python/py-value.c: Do not include py-ref.h.
6013         * python/py-varobj.c: Do not include py-ref.h.
6014         * python/py-xmethods.c: Do not include py-ref.h.
6015         * python/python.c: Do not include py-ref.h.
6016         * varobj.c: Do not include py-ref.h.
6017
6018 2019-01-22  Tom Tromey  <tom@tromey.com>
6019
6020         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6021         keyword for bcache.
6022
6023 2019-01-22  Tom Tromey  <tom@tromey.com>
6024
6025         * compile/compile-cplus-types.c: Remove a comment by #include.
6026
6027 2019-01-22  Tom Tromey  <tom@tromey.com>
6028
6029         * compile/gcc-c-plugin.h: Include compile-internal.h.
6030
6031 2019-01-22  Tom Tromey  <tom@tromey.com>
6032
6033         * stabsread.c (EXTERN): Do not define.
6034         (symnum, next_symbol_text_func, processing_gcc_compilation)
6035         (within_function, global_sym_chain, global_stabs)
6036         (previous_stab_code, this_object_header_files)
6037         (n_this_object_header_files)
6038         (n_allocated_this_object_header_files): Define.
6039         * stabsread.h (EXTERN): Never define.  Use "extern".
6040
6041 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6042
6043         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6044         history_value.
6045
6046 2019-01-21  Tom Tromey  <tom@tromey.com>
6047
6048         * ui-out.c: Fix includes.
6049         * tui/tui-source.c: Fix includes.
6050         * target.c: Fix includes.
6051         * remote.c: Fix includes.
6052         * regcache.c: Fix includes.
6053         * python/py-block.c: Fix includes.
6054         * printcmd.c: Fix includes.
6055         * or1k-tdep.c: Fix includes.
6056         * mi/mi-main.c: Fix includes.
6057         * m32r-tdep.c: Fix includes.
6058         * csky-tdep.c: Fix includes.
6059         * compile/compile-cplus-types.c: Fix includes.
6060         * cli/cli-interp.c: Fix includes.
6061
6062 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6063
6064         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6065         for padding.
6066
6067 2019-01-16  Tom Tromey  <tom@tromey.com>
6068
6069         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6070         earlier.
6071         (struct objfile) <msymbols_range>: Move from top level.
6072         <msymbols>: New method.
6073         (class objfile_msymbols): Remove.
6074         * symtab.c (default_collect_symbol_completion_matches_break_on):
6075         Update.
6076         * symmisc.c (dump_msymbols): Update.
6077         * stabsread.c (scan_file_globals): Update.
6078         * objc-lang.c (info_selectors_command, info_classes_command)
6079         (find_methods): Update.
6080         * minsyms.c (find_solib_trampoline_target): Update.
6081         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6082         * coffread.c (coff_symfile_read): Update.
6083         * ada-lang.c (ada_lookup_simple_minsym)
6084         (ada_collect_symbol_completion_matches): Update.
6085
6086 2019-01-16  Tom Tromey  <tom@tromey.com>
6087
6088         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6089         type.  Remove no-argument constructor.
6090         <iterator::operator++>: Simplify.
6091         <begin>: Update.
6092         <end>: Use minimal_symbol_count.
6093
6094 2019-01-16  Tom Tromey  <tom@tromey.com>
6095
6096         * objfiles.h (struct objfile) <psymtabs>: New method.
6097         (class objfile_psymtabs): Remove.
6098         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6099         typedef.
6100         <range>: New method.
6101         (require_partial_symbols): Change return type.
6102         * psymtab.c (require_partial_symbols)
6103         (psym_expand_symtabs_matching): Update.
6104         * mdebugread.c (parse_partial_symbols): Update.
6105         * dbxread.c (dbx_end_psymtab): Update.
6106
6107 2019-01-15  Tom Tromey  <tom@tromey.com>
6108
6109         * symtab.c (lookup_objfile_from_block)
6110         (lookup_symbol_in_objfile_symtabs)
6111         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6112         (find_line_symtab, info_sources_command)
6113         (default_collect_symbol_completion_matches_break_on)
6114         (make_source_files_completion_list): Update.
6115         * symmisc.c (print_objfile_statistics, dump_objfile)
6116         (maintenance_print_symbols, maintenance_info_symtabs)
6117         (maintenance_check_symtabs, maintenance_info_line_tables):
6118         Update.
6119         * source.c (select_source_symtab)
6120         (forget_cached_source_info_for_objfile): Update.
6121         * objfiles.h (class objfile_compunits): Remove.
6122         (struct objfile) <compunits_range>: New typedef.
6123         (compunits): New method.
6124         * objfiles.c (objfile_relocate1): Update.
6125         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6126         * maint.c (count_symtabs_and_blocks): Update.
6127         * linespec.c (iterate_over_all_matching_symtabs): Update.
6128         * cp-support.c (add_symbol_overload_list_qualified): Update.
6129         * coffread.c (coff_symtab_read): Update.
6130         * ada-lang.c (add_nonlocal_symbols)
6131         (ada_collect_symbol_completion_matches)
6132         (ada_add_global_exceptions): Update.
6133
6134 2019-01-15  Tom Tromey  <tom@tromey.com>
6135
6136         * progspace.h (program_space) <objfiles_safe_range>: New
6137         typedef.
6138         <objfiles_safe>: New method.
6139         * objfiles.h (class all_objfiles_safe): Remove.
6140         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6141         * jit.c (jit_inferior_exit_hook): Update.
6142
6143 2019-01-17  Tom Tromey  <tom@tromey.com>
6144
6145         * progspace.h (program_space) <objfiles_range>: New typedef.
6146         <objfiles>: New method.
6147         <objfiles_head>: Rename from objfiles.
6148         (object_files): Update.
6149         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6150         * guile/scm-pretty-print.c
6151         (ppscm_find_pretty_printer_from_objfiles): Update.
6152         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6153         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6154         Update.
6155         * python/py-progspace.c (pspy_get_objfiles): Update.
6156         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6157         Update.
6158         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6159         (objfpy_lookup_objfile_by_build_id): Update.
6160         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6161         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6162         Update.
6163         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6164         (expand_symtab_containing_pc, lookup_objfile_from_block)
6165         (lookup_static_symbol, basic_lookup_transparent_type)
6166         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6167         (find_line_symtab, info_sources_command)
6168         (default_collect_symbol_completion_matches_break_on)
6169         (make_source_files_completion_list, find_main_name): Update.
6170         * symmisc.c (print_symbol_bcache_statistics)
6171         (print_objfile_statistics, maintenance_print_symbols)
6172         (maintenance_print_msymbols, maintenance_print_objfiles)
6173         (maintenance_info_symtabs, maintenance_check_symtabs)
6174         (maintenance_expand_symtabs, maintenance_info_line_tables):
6175         Update.
6176         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6177         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6178         (map_overlay_command, unmap_overlay_command)
6179         (simple_overlay_update, expand_symtabs_matching)
6180         (map_symbol_filenames): Update.
6181         * symfile-debug.c (set_debug_symfile): Update.
6182         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6183         Update.
6184         * source.c (select_source_symtab, forget_cached_source_info):
6185         Update.
6186         * solib.c (solib_read_symbols): Update.
6187         * solib-spu.c (append_ocl_sos): Update.
6188         * psymtab.c (maintenance_print_psymbols)
6189         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6190         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6191         * printcmd.c (info_symbol_command): Update.
6192         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6193         Update.
6194         * objfiles.h (class all_objfiles): Remove.
6195         * objfiles.c (have_partial_symbols, have_full_symbols)
6196         (have_minimal_symbols, qsort_cmp, update_section_map)
6197         (shared_objfile_contains_address_p)
6198         (default_iterate_over_objfiles_in_search_order): Update.
6199         * objc-lang.c (info_selectors_command, info_classes_command)
6200         (find_methods): Update.
6201         * minsyms.c (find_solib_trampoline_target): Update.
6202         * maint.c (maintenance_info_sections)
6203         (maintenance_translate_address, count_symtabs_and_blocks):
6204         Update.
6205         * main.c (captured_main_1): Update.
6206         * linux-thread-db.c (try_thread_db_load_from_pdir)
6207         (has_libpthread): Update.
6208         * linespec.c (iterate_over_all_matching_symtabs)
6209         (search_minsyms_for_name): Update.
6210         * jit.c (jit_find_objf_with_entry_addr): Update.
6211         * hppa-tdep.c (find_unwind_entry)
6212         (hppa_lookup_stub_minimal_symbol): Update.
6213         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6214         Update.
6215         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6216         (elf_gnu_ifunc_resolve_by_got): Update.
6217         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6218         * dwarf-index-write.c (save_gdb_index_command): Update.
6219         * cp-support.c (add_symbol_overload_list_qualified): Update.
6220         * breakpoint.c (create_overlay_event_breakpoint)
6221         (create_longjmp_master_breakpoint)
6222         (create_std_terminate_master_breakpoint)
6223         (create_exception_master_breakpoint): Update.
6224         * blockframe.c (find_pc_partial_function): Update.
6225         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6226         (ada_collect_symbol_completion_matches)
6227         (ada_add_global_exceptions): Update.
6228
6229 2019-01-17  Tom Tromey  <tom@tromey.com>
6230
6231         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6232         declare VEC.
6233         (solib_target_parse_libraries): Change return type.
6234         (library_list_start_segment, library_list_start_section)
6235         (library_list_end_library, library_list_start_library); Update.
6236         (solib_target_free_library_list): Remove.
6237         (solib_target_parse_libraries): Remove cleanup.  Change return
6238         type.
6239         (solib_target_current_sos): Update.
6240
6241 2019-01-17  Tom Tromey  <tromey@bapiya>
6242
6243         * valprint.c: Replace "the the" with "the".
6244         * symtab.c: Replace "the the" with "the".
6245         * solib.c: Replace "the the" with "the".
6246         * solib-dsbt.c: Replace "the the" with "the".
6247         * linespec.c: Replace "the the" with "the".
6248         * dwarf2loc.h: Replace "the the" with "the".
6249         * amd64-windows-tdep.c: Replace "the the" with "the".
6250         * aarch64-tdep.c: Replace "the the" with "the".
6251
6252 2019-01-16  Keith Seitz  <keiths@redhat.com>
6253
6254         PR gdb/23773
6255         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6256         <builder>: Rename to ..
6257         <m_builder>: ... this and make private.
6258         (dwarf2_cu::get_builder): New method.  Change all users of
6259         `builder' to use this method.
6260         (dwarf2_start_symtab): Move to ...
6261         (dwarf2_cu::start_symtab): ... here.  Update all callers
6262         (setup_type_unit_groups): Move to ...
6263         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6264         callers.
6265         (dwarf2_cu::reset_builder): New method.
6266         (process_full_compunit, process_full_type_unit): Use
6267         dwarf2_cu::reset_builder.
6268         (follow_die_offset): Record the ancestor CU if it is different
6269         from the followed DIE's CU.
6270         (follow_die_sig_1): Likewise.
6271
6272 2019-01-15  Tom Tromey  <tom@tromey.com>
6273
6274         * remote.c (class remote_state) <buf>: Now a char_vector.
6275         <buf_size>: Remove.
6276         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6277         parameter.
6278         (remote_target::getpkt_or_notif_sane_1)
6279         (remote_target::getpkt_sane)
6280         (remote_target::getpkt_or_notif_sane): Likewise.
6281         (class remote_target) <putpkt>: New overload.
6282         (remote_target::read_frame): Change type of "buf_p".  Remove
6283         sizeof_p parameter.
6284         (packet_ok): New overload.
6285         (packet_check_result): New overload.
6286         Update all uses.
6287
6288 2019-01-14  Tom Tromey  <tom@tromey.com>
6289
6290         * remote-notif.c (handle_notification, remote_notif_ack)
6291         (remote_notif_parse): Make "buf" const.
6292         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6293         const.
6294         (remote_notif_parse, remote_notif_ack, handle_notification):
6295         Likewise.
6296         * remote.c (remote_notif_stop_parse): Make "buf" const.
6297         (remote_target::remote_parse_stop_reply): Make "buf" const.
6298         (remote_notif_stop_ack): Make "buf" const.
6299
6300 2019-01-14  Tom Tromey  <tom@tromey.com>
6301
6302         * remote.c (remote_console_output): Make parameter const.
6303
6304 2019-01-14  Tom Tromey  <tom@tromey.com>
6305
6306         * target-debug.h (target_debug_print_signals): Constify.
6307         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6308         * procfs.c (procfs_target::pass_signals): Update.
6309         * linux-nat.c (linux_nat_target::pass_signals): Update.
6310         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6311         * target-delegates.c: Rebuild.
6312         * remote.c (remote_target::program_signals): Update.
6313         (remote_target::pass_signals): Update.
6314         * target.c (target_pass_signals): Constify argument.
6315         (target_program_signals): Likewise.
6316         * target.h (struct target_ops) <pass_signals, program_signals>:
6317         Constify argument.
6318         (target_pass_signals, target_program_signals): Constify argument.
6319
6320 2019-01-14  Tom Tromey  <tom@tromey.com>
6321
6322         PR tui/28819:
6323         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6324
6325 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6326
6327         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6328         field.
6329         * rs6000-tdep.c: Include reggroups.h.
6330         (IS_V_ALIAS_PSEUDOREG): Define.
6331         (rs6000_register_name): Return names for the "vX" aliases.
6332         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6333         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6334         aliases.  Call default_register_reggroup_p for all other
6335         pseudo-registers.
6336         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6337         New functions.
6338         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6339         Handle "vX" aliases.
6340         (v_alias_pseudo_register_collect): New function.
6341         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6342         (rs6000_gdbarch_init): Initialize "vX" aliases as
6343         pseudo-registers.  Restore registration of
6344         rs6000_pseudo_register_reggroup_p with
6345         set_tdesc_pseudo_register_reggroup_p.
6346
6347 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6348
6349         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6350         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6351         set_gdbarch_num_pseudo_regs.
6352
6353 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6354
6355         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6356         Remove arg prefixname, add do_set and do_show.
6357         Add member functions set_list and show_list.
6358         * cli/cli-style.c (class cli_style_option): Update accordingly.
6359         (style_set_list): Move to file scope.
6360         (style_show_list): Likewise.
6361         (set_style): Call help_list.
6362         (show_style): Call cmd_show_list.
6363         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6364         Update to use the new macro.
6365
6366 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6367
6368         * ada-lang.c (_initialize_ada_language): Expand the help text
6369         for the "catch exception" command.
6370
6371 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6372
6373         * symtab.c (matching_obj_sections): Initialize obj,
6374         declare it closer to its usage.
6375
6376 2019-01-10  Tom Tromey  <tom@tromey.com>
6377
6378         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6379         (basic_inf_threads_range): Remove.
6380         (inf_threads_range, inf_non_exited_threads_range)
6381         (safe_inf_threads_range): Use next_adapter.
6382
6383 2019-01-10  Keith Seitz  <keiths@redhat.com>
6384
6385         PR gdb/23712
6386         PR symtab/23010
6387         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6388         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6389
6390 2019-01-10  Keith Seitz  <keiths@redhat.com>
6391
6392         PR gdb/23712
6393         PR symtab/23010
6394         * dictionary.c (pending_to_vector): Remove.
6395         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6396         Remove _1 suffix, replacing functions of the same name.  Update
6397         all callers.
6398         (dict_create_hashed, dict_create_hashed_expandable)
6399         (dict_create_linear, dict_create_linear_expandable, dict_free)
6400         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6401         Make functions static.
6402
6403 2019-01-10  Keith Seitz  <keiths@redhat.com>
6404
6405         PR gdb/23712
6406         PR symtab/23010
6407         * dictionary.h (struct dictionary): Replace declaration with
6408         multidictionary.
6409         (dict_create_hashed, dict_create_hashed_expandable)
6410         (dict_create_linear, dict_create_linear_expandable)
6411         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6412         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6413         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6414         taking multidictionary argument.
6415         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6416         * block.h (struct block) <dict>: Change to multidictionary
6417         and rename `multidict'.
6418         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6419         symmisc.c: Update all dictionary references to multidictionary.
6420
6421 2019-01-10  Keith Seitz  <keiths@redhat.com>
6422
6423         PR gdb/23712
6424         PR symtab/23010
6425         * dictionary.c: Include unordered_map.
6426         (pending_to_vector): New function.
6427         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6428         Rewrite the non-"_1" functions to take vector instead
6429         of linked list.
6430         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6431         "new" _1 versions of the same name.
6432         (multidictionary): Define.
6433         (std::hash<enum language): New definition.
6434         (collate_pending_symbols_by_language, mdict_create_hashed)
6435         (mdict_create_hashed_expandable, mdict_create_linear)
6436         (mdict_create_linear_expandable, mdict_free)
6437         (find_language_dictionary, create_new_language_dictionary)
6438         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6439         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6440         (mdict_size, mdict_empty): New functions.
6441         * dictionary.h (mdict_iterator): Define.
6442
6443 2019-01-10  Pedro Alves  <palves@redhat.com>
6444
6445         * breakpoint.c (read_uploaded_action)
6446         (create_tracepoint_from_upload): Adjust to use
6447         gdb::unique_xmalloc_ptr.
6448         * ctf.c (ctf_write_uploaded_tp):
6449         (SET_ARRAY_FIELD): Use emplace_back.
6450         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6451         * tracefile-tfile.c (tfile_write_uploaded_tp):
6452         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6453         gdb::unique_xmalloc_ptr.
6454         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6455         at_string, cond_string, cmd_strings>: Replace char pointers
6456         with gdb::unique_xmalloc_ptr.
6457
6458 2019-01-10  Pedro Alves  <palves@redhat.com>
6459
6460         * solib-target.c (library_list_start_library): Don't xstrdup name.
6461
6462 2019-01-10  Pedro Alves  <palves@redhat.com>
6463
6464         * mdebugread.c (parse_partial_symbols): Use
6465         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6466
6467 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         * linux-fork.c (scoped_switch_fork_info)
6470         <~scoped_switch_fork_info>: Fix incorrect variable name.
6471
6472 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6473
6474         * linux-fork.c (scoped_switch_fork_info)
6475         <scoped_switch_fork_info>: Make explicit.
6476         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6477
6478 2019-01-10  Tom Tromey  <tom@tromey.com>
6479
6480         * objfiles.h (objfile::reset_psymtabs): Update.
6481         * objfiles.c (objfile::objfile): Update.
6482         * psymtab.h (psymtab_storage::obstack): Update.
6483         (psymtab_storage::m_obstack): Use gdb::optional.
6484         (class psymtab_storage): Update comment.  Remove objfile
6485         parameter.
6486         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6487
6488 2019-01-10  Tom Tromey  <tom@tromey.com>
6489
6490         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6491         <free_psymtabs>: Now private.
6492         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6493         (allocate_psymtab): Use new method.
6494
6495 2019-01-10  Tom Tromey  <tom@tromey.com>
6496
6497         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6498         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6499         * mdebugread.c (parse_partial_symbols): Use
6500         allocate_dependencies.
6501         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6502         allocate_dependencies.
6503         (process_psymtab_comp_unit_reader)
6504         (build_type_psymtab_dependencies): Likewise.
6505         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6506
6507 2019-01-10  Tom Tromey  <tom@tromey.com>
6508
6509         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6510         PSYMBOL_SET_LANGUAGE.
6511         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6512
6513 2019-01-10  Tom Tromey  <tom@tromey.com>
6514
6515         * psymtab.h (psymtab_storage::obstack): New method.
6516         <m_obstack>: Rename from obstack; now private.
6517         * psymtab.c (psymtab_storage): Update.
6518         * dwarf2read.c (create_addrmap_from_index)
6519         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6520         Update.
6521
6522 2019-01-10  Tom Tromey  <tom@tromey.com>
6523
6524         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6525         * objfiles.h (objfile::reset_psymtabs): New method.
6526
6527 2019-01-10  Tom Tromey  <tom@tromey.com>
6528
6529         * symmisc.c (print_symbol_bcache_statistics): Update.
6530         (print_objfile_statistics): Update.
6531         * symfile.c (reread_symbols): Update.
6532         * psymtab.h (class psymtab_storage): New.
6533         * psymtab.c (psymtab_storage): New constructor.
6534         (~psymtab_storage): New destructor.
6535         (require_partial_symbols): Update.
6536         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6537         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6538         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6539         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6540         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6541         (start_psymtab_common, end_psymtab_common)
6542         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6543         (allocate_psymtab): Update.
6544         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6545         Update.
6546         (dump_psymtab_addrmap, maintenance_print_psymbols)
6547         (maintenance_check_psymtabs): Update.
6548         (class objfile_psymtabs): Move to objfiles.h.
6549         * psympriv.h (discard_psymtab): Now inline.
6550         (psymtab_discarder::psymtab_discarder): Update.
6551         (psymtab_discarder::~psymtab_discarder): Update.
6552         (ALL_OBJFILE_PSYMTABS): Rewrite.
6553         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6554         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6555         Remove fields.
6556         <partial_symtabs>: New field.
6557         (class objfile_psymtabs): Move from psymtab.h.  Update.
6558         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6559         psymbol_cache.
6560         (objfile::~objfile): Don't destroy psymbol_cache.
6561         * mdebugread.c (parse_partial_symbols): Update.
6562         * dwarf2read.c (create_addrmap_from_index)
6563         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6564         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6565         (add_partial_subprogram, dwarf2_ranges_read): Update.
6566         * dwarf-index-write.c (write_address_map)
6567         (write_one_signatured_type, recursively_write_psymbols)
6568         (class debug_names, class debug_names, write_psymtabs_to_index):
6569         Update.
6570
6571 2019-01-10  Tom Tromey  <tom@tromey.com>
6572
6573         * symtab.h (SYMBOL_SET_NAMES): Update.
6574         (symbol_set_names): Update.
6575         (MSYMBOL_SET_NAMES): Update.
6576         * symtab.c (symbol_set_names): Change argument to be an
6577         objfile_per_bfd_storage.
6578         * psymtab.c (add_psymbol_to_bcache): Update.
6579         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6580
6581 2019-01-10  Tom Tromey  <tom@tromey.com>
6582
6583         * symtab.c (create_demangled_names_hash): Change argument to be an
6584         objfile_per_bfd_storage.
6585         (symbol_set_names): Update.
6586
6587 2019-01-10  Tom Tromey  <tom@tromey.com>
6588
6589         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6590         init_psymbol_list.
6591         * psymtab.c (init_psymbol_list): Do nothing if already called.
6592         * psympriv.h (init_psymbol_list): Add comment.
6593         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6594         init_psymbol_list.
6595         * dbxread.c (dbx_symfile_read): Unconditionally call
6596         init_psymbol_list.
6597
6598 2019-01-10  Tom Tromey  <tom@tromey.com>
6599
6600         * xcoffread.c (scan_xcoff_symtab): Update.
6601         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6602         "where".
6603         * mdebugread.c (parse_partial_symbols)
6604         (handle_psymbol_enumerators): Update.
6605         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6606         * dbxread.c (read_dbx_symtab): Update.
6607         * psympriv.h (psymbol_placement): New enum.
6608         (add_psymbol_to_list): Update.
6609
6610 2019-01-10  Tom Tromey  <tom@tromey.com>
6611
6612         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6613         static_psymbols parameters.
6614         (scan_xcoff_symtab): Update.
6615         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6616         static_psymbols parameters.
6617         * psympriv.h (start_psymtab_common): Update.
6618         * mdebugread.c (parse_partial_symbols): Update.
6619         * dwarf2read.c (create_partial_symtab): Update.
6620         * dbxread.c (read_dbx_symtab): Update.
6621         (start_psymtab): Remove global_psymbols and static_psymbols
6622         parameters.
6623
6624 2019-01-10  Tom Tromey  <tom@tromey.com>
6625
6626         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6627         * psymtab.c (allocate_psymtab): Add comment.
6628         * psympriv.h (allocate_psymtab): Add comment.
6629         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6630         initializations.
6631         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6632
6633 2019-01-10  Tom Tromey  <tom@tromey.com>
6634
6635         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6636         Don't declare.
6637         * mipsread.c: Include mdebugread.h.
6638         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6639         Declare.
6640         * elfread.c: Include mdebugread.h.
6641
6642 2019-01-09  Tom Tromey  <tom@tromey.com>
6643
6644         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6645         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6646         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6647         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6648         (psym_lookup_symbol, psym_find_last_source_symtab)
6649         (psym_forget_cached_source_info, psym_print_stats)
6650         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6651         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6652         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6653         (psym_find_compunit_symtab_by_address)
6654         (maintenance_print_psymbols, maintenance_info_psymtabs)
6655         (maintenance_check_psymtabs): Use ranged for.
6656         * psymtab.h (class objfile_psymtabs): New.
6657         (require_partial_symbols): Return objfile_psymtabs.
6658         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6659
6660 2019-01-09  Tom Tromey  <tom@tromey.com>
6661
6662         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6663         (find_pc_mapped_section, list_overlays_command)
6664         (map_overlay_command, unmap_overlay_command)
6665         (simple_overlay_update): Use all_objfiles.
6666         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6667         * printcmd.c (info_symbol_command): Use all_objfiles.
6668         * objfiles.h (ALL_OBJSECTIONS): Remove.
6669         * maint.c (maintenance_translate_address): Use all_objfiles.
6670         * gcore.c (gcore_create_callback): Use all_objfiles.
6671         (objfile_find_memory_regions): Likewise.
6672
6673 2019-01-09  Tom Tromey  <tom@tromey.com>
6674
6675         * symtab.c (find_line_symtab, info_sources_command)
6676         (make_source_files_completion_list): Use objfile_compunits.
6677         * source.c (select_source_symtab): Use objfile_compunits.
6678         * objfiles.h (struct objfile): Update comment.
6679         (ALL_OBJFILES): Remove.
6680         (ALL_FILETABS): Remove.
6681         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6682         objfile_compunits.
6683
6684 2019-01-09  Tom Tromey  <tom@tromey.com>
6685
6686         * symmisc.c (print_objfile_statistics, dump_objfile)
6687         (maintenance_print_symbols): Use compunit_filetabs.
6688         * source.c (forget_cached_source_info_for_objfile): Use
6689         compunit_filetabs.
6690         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6691         (ALL_FILETABS): Use compunit_filetabs.
6692         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6693         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6694
6695 2019-01-09  Tom Tromey  <tom@tromey.com>
6696
6697         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6698         (compunit_filetabs): New.
6699         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6700         compunit_filetabs.
6701         (info_sources_command, make_source_files_completion_list): Remove
6702         declaration.
6703         * symmisc.c (print_objfile_statistics, dump_objfile)
6704         (maintenance_print_symbols): Remove declaration.
6705         (maintenance_info_symtabs): Use compunit_filetabs.
6706         (maintenance_info_line_tables): Likewise.
6707         * source.c (select_source_symtab): Change local variable name.
6708         (forget_cached_source_info_for_objfile): Remove declaration.
6709         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6710         * objfiles.c (objfile_relocate1): Remove declaration.
6711         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6712         declaration.
6713         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6714         * coffread.c (coff_symtab_read): Remove declaration.
6715         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6716         compunit_filetabs.
6717
6718 2019-01-09  Tom Tromey  <tom@tromey.com>
6719
6720         * symtab.c (lookup_objfile_from_block)
6721         (find_pc_sect_compunit_symtab, search_symbols)
6722         (default_collect_symbol_completion_matches_break_on): Use
6723         objfile_compunits.
6724         * objfiles.h (ALL_COMPUNITS): Remove.
6725         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6726         * cp-support.c (add_symbol_overload_list_qualified): Use
6727         objfile_compunits.
6728         * ada-lang.c (ada_collect_symbol_completion_matches)
6729         (ada_add_global_exceptions): Use objfile_compunits.
6730
6731 2019-01-09  Tom Tromey  <tom@tromey.com>
6732
6733         * source.c (select_source_symtab)
6734         (forget_cached_source_info_for_objfile): Remove declaration.
6735         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6736         declaration.
6737         * maint.c (count_symtabs_and_blocks): Remove declaration.
6738         * cp-support.c (add_symbol_overload_list_qualified): Remove
6739         declaration.
6740         * coffread.c (coff_symtab_read): Remove declaration.
6741         * symtab.c (lookup_symbol_in_objfile_symtabs)
6742         (basic_lookup_transparent_type_1): Use objfile_compunits.
6743         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6744         (info_sources_command, search_symbols)
6745         (default_collect_symbol_completion_matches_break_on)
6746         (make_source_files_completion_list): Remove declaration.
6747         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6748         (ada_collect_symbol_completion_matches)
6749         (ada_add_global_exceptions): Remove declaration.
6750         * linespec.c (iterate_over_all_matching_symtabs): Use
6751         objfile_compunits.
6752         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6753         (class objfile_compunits): New.
6754         (ALL_COMPUNITS): Use objfile_compunits.
6755         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6756         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6757         objfile_compunits.
6758         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6759
6760 2019-01-09  Tom Tromey  <tom@tromey.com>
6761
6762         * symtab.c (search_symbols)
6763         (default_collect_symbol_completion_matches_break_on): Use
6764         objfile_msymbols.
6765         * ada-lang.c (ada_lookup_simple_minsym)
6766         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6767         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6768         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6769         objfile_msymbols.
6770         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6771         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6772         * objc-lang.c (find_methods): Use objfile_msymbols.
6773         (info_selectors_command, info_classes_command): Likewise.
6774         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6775         * objfiles.h (class objfile_msymbols): New.
6776         (ALL_OBJFILE_MSYMBOLS): Remove.
6777         (ALL_MSYMBOLS): Remove.
6778
6779 2019-01-09  Tom Tromey  <tom@tromey.com>
6780
6781         * common/next-iterator.h (next_adapter): Add Iterator template
6782         parameter.
6783         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6784         (class all_objfiles_safe): New.
6785         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6786         * objfiles.c (put_objfile_before): Update comment.
6787         (add_separate_debug_objfile): Likewise.
6788         (free_all_objfiles): Use all_objfiles_safe.
6789         (objfile_purge_solibs): Likewise.
6790
6791 2019-01-09  Tom Tromey  <tom@tromey.com>
6792
6793         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6794         (expand_symtab_containing_pc, lookup_static_symbol)
6795         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6796         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6797         all_objfiles.
6798         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6799         * breakpoint.c (create_overlay_event_breakpoint)
6800         (create_longjmp_master_breakpoint)
6801         (create_std_terminate_master_breakpoint)
6802         (create_exception_master_breakpoint): Use all_objfiles.
6803         * linux-thread-db.c (try_thread_db_load_from_pdir)
6804         (has_libpthread): Use all_objfiles.
6805         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6806         * linespec.c (iterate_over_all_matching_symtabs)
6807         (search_minsyms_for_name): Use all_objfiles.
6808         * maint.c (maintenance_info_sections): Use all_objfiles.
6809         * main.c (captured_main_1): Use all_objfiles.
6810         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6811         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6812         * guile/scm-pretty-print.c
6813         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6814         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6815         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6816         (maintenance_print_msymbols): Use all_objfiles.
6817         * source.c (select_source_symtab): Use all_objfiles.
6818         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6819         * symfile.c (remove_symbol_file_command)
6820         (expand_symtabs_matching, map_symbol_filenames): Use
6821         all_objfiles.
6822         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6823         all_objfiles.
6824         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6825         * objc-lang.c (find_methods): Use all_objfiles.
6826         * objfiles.c (have_partial_symbols, have_full_symbols)
6827         (have_minimal_symbols, qsort_cmp)
6828         (default_iterate_over_objfiles_in_search_order): Use
6829         all_objfiles.
6830         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6831         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6832         (maintenance_check_psymtabs): Use all_objfiles.
6833         (ALL_PSYMTABS): Remove.
6834         * compile/compile-object-run.c (do_module_cleanup): Use
6835         all_objfiles.
6836         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6837         * cp-support.c (add_symbol_overload_list_qualified): Use
6838         all_objfiles.
6839         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6840         Use all_objfiles.
6841         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6842         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6843         all_objfiles.
6844         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6845         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6846         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6847         Uses all_objfiles.
6848         * solib.c (solib_read_symbols): Use all_objfiles
6849
6850 2019-01-09  Tom Tromey  <tom@tromey.com>
6851
6852         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6853         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6854         all_objfiles.
6855         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6856         * symmisc.c (print_symbol_bcache_statistics)
6857         (print_objfile_statistics, maintenance_print_objfiles)
6858         (maintenance_info_symtabs, maintenance_check_symtabs)
6859         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6860         all_objfiles.
6861         * source.c (forget_cached_source_info): Use all_objfiles.
6862         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6863         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6864         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6865         * objfiles.c (update_section_map): Use all_objfiles.
6866         (shared_objfile_contains_address_p): Likewise.
6867         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6868         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6869
6870 2019-01-09  Tom Tromey  <tom@tromey.com>
6871
6872         * common/next-iterator.h: New file.
6873         * objfiles.h (class all_objfiles): New.
6874         (struct objfile_iterator): New.
6875
6876 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6877
6878         * NEWS: Move the description of the changed "frame", "select-frame",
6879          and "info frame" commands to the Changed commands section.
6880
6881 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6882
6883         * gdbtypes.c (check_stub_method_group): Remove handling of old
6884         mangling schemes.
6885         * linespec.c (find_methods): Likewise.
6886         * stabsread.c (read_member_functions): Likewise.
6887         * valops.c (search_struct_method): Likewise.
6888         (value_struct_elt_for_reference): Likewise.
6889         * NEWS: Mention this change.
6890
6891 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6892
6893         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6894         print_source_lines.
6895         * source.c (print_source_lines_base): Update line number check.
6896         (print_source_lines): New function.
6897         (source_lines_range::source_lines_range): New function.
6898         * source.h (class source_lines_range): New class.
6899         (print_source_lines): New declaration.
6900
6901 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6902
6903         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6904
6905 2019-01-08  Tom Tromey  <tom@tromey.com>
6906             Simon Marchi  <simon.marchi@ericsson.com>
6907
6908         PR gdb/24060
6909         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6910         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6911         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6912         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6913         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6914         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6915
6916 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6917
6918         * source.c (select_source_symtab): Move header comment to
6919         declaration in source.h.
6920         (forget_cached_source_info_for_objfile): Likewise.
6921         (forget_cached_source_info): Likewise.
6922         (identify_source_line): Likewise.
6923         * source.h (identify_source_line): Move declaration from symtab.h
6924         and add comment from source.c
6925         (print_source_lines): Likewise.
6926         (forget_cached_source_info_for_objfile): Likewise.
6927         (forget_cached_source_info): Likewise.
6928         (select_source_symtab): Likewise.
6929         (enum print_source_lines_flag): Move definition from symtab.h.
6930         * symtab.h (identify_source_line): Move declaration to source.h.
6931         (print_source_lines): Likewise.
6932         (forget_cached_source_info_for_objfile): Likewise.
6933         (forget_cached_source_info): Likewise.
6934         (select_source_symtab): Likewise.
6935         (enum print_source_lines_flag): Move definition to source.h.
6936         * tui/tui-hooks.c: Add 'source.h' include.
6937
6938 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6939
6940         * source.c (print_source_lines_base): Handle requests to print
6941         reverse line number sequences, and guard against empty lines
6942         string.
6943
6944 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6945
6946         * source.c (print_source_lines_base): Fix skip of '\r' if next
6947         character is '\n'.
6948
6949 2019-01-06  Tom Tromey  <tom@tromey.com>
6950
6951         * c-exp.y (struct c_parse_state) <macro_original_text,
6952         expansion_obstack>: New member.
6953         (macro_original_text, expansion_obstack): Remove globals.
6954         (scan_macro_expansion, scanning_macro_expansion)
6955         (finished_macro_expansion): Update.
6956         (scan_macro_cleanup): Remove.
6957         (yylex, c_parse): Update.
6958
6959 2019-01-06  Tom Tromey  <tom@tromey.com>
6960
6961         * c-exp.y (struct c_parse_state) <strings>: New member.
6962         (operator_stoken): Update.
6963
6964 2019-01-06  Tom Tromey  <tom@tromey.com>
6965
6966         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6967         (union type_stack_elt) <typelist_val>: Now a pointer to
6968         std::vector.
6969         (type_stack_cleanup): Don't declare.
6970         (push_typelist): Update.
6971         * parse.c (pop_typelist): Return a std::vector.
6972         (push_typelist): Take a std::vector.
6973         (follow_types): Update.  Do not free args.
6974         (type_stack_cleanup): Remove.
6975         * c-exp.y (struct c_parse_state): New.
6976         (cpstate): New global.
6977         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6978         (nonempty_typelist): Update.
6979         (func_mod): Create a new vector.
6980         (c_parse): Create a c_parse_state.
6981         (check_parameter_typelist): Do not delete params.
6982         (function_method): Update.  Do not delete type_list.
6983
6984 2019-01-06  Tom Tromey  <tom@tromey.com>
6985
6986         PR gdb/28155:
6987         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6988         check_typedef.
6989         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6990         (print_return_value): Likewise.
6991
6992 2019-01-05  Tom Tromey  <tom@tromey.com>
6993
6994         * contrib/cleanup_check.py: Remove.
6995         * contrib/gcc-with-excheck: Remove.
6996         * contrib/exsummary.py: Remove.
6997         * contrib/excheck.py: Remove.
6998
6999 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7000
7001         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7002         NULL. Initialize tpprev to NULL instead of assigning it
7003         to NULL on the next statement.
7004         * windows-nat.c (windows_delete_thread): Remove check for
7005         main_thread_id before printing thread exit notifications.
7006         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7007         Remove thread ID check against main_thread_id.
7008         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7009         windows_delete_thread.
7010         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7011
7012 2019-01-04  Tom Tromey  <tom@tromey.com>
7013
7014         * compile/compile.c (_initialize_compile): Use upper case for
7015         metasyntactic variables.
7016         * symmisc.c (_initialize_symmisc): Use upper case for
7017         metasyntactic variables.
7018         * psymtab.c (_initialize_psymtab): Use upper case for
7019         metasyntactic variables.
7020         * demangle.c (demangle_command): Use upper case for metasyntactic
7021         variables.
7022         (_initialize_demangler): Likewise.
7023         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7024         variables.
7025
7026 2019-01-03  Tom Tromey  <tom@tromey.com>
7027
7028         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7029
7030 2019-01-03  Tom Tromey  <tom@tromey.com>
7031
7032         * python/py-symtab.c (salpy_str): Update.
7033         (struct salpy_sal_object) <symtab>: Now a PyObject.
7034         (salpy_dealloc): Update.
7035         (del_objfile_sal): Use gdbpy_ref.
7036
7037 2019-01-03  Tom Tromey  <tom@tromey.com>
7038
7039         * python/py-type.c (convert_field): Use new_reference.  Return
7040         gdbpy_ref.
7041         (make_fielditem): Return gdbpy_ref.
7042         (typy_fields): Update.
7043         (typy_getitem): Update.
7044         (field_name): Return gdbpy_ref.  Use new_reference.
7045         (typy_iterator_iternext): Update.
7046
7047 2019-01-03  Tom Tromey  <tom@tromey.com>
7048
7049         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7050
7051 2019-01-03  Tom Tromey  <tom@tromey.com>
7052
7053         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7054         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7055         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7056         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7057         (pspy_set_type_printers): Likewise.
7058         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7059         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7060         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7061         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7062         (objfpy_set_type_printers): Likewise.
7063
7064 2019-01-03  Tom Tromey  <tom@tromey.com>
7065
7066         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7067         (gdbpy_print_stack): Use gdbpy_err_fetch.
7068         * python/python-internal.h (class gdbpy_err_fetch): New class.
7069         (class gdbpy_enter) <m_error_type, m_error_value,
7070         m_error_traceback>: Remove.
7071         <m_error>: New member.
7072         (gdbpy_exception_to_string): Don't declare.
7073         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7074         * python/py-value.c (convert_value_from_python): Use
7075         gdbpy_err_fetch.
7076         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7077         gdbpy_exception_to_string.
7078         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7079         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7080         gdbpy_err_fetch.
7081
7082 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7083
7084         * linux-nat.c (delete_lwp_cleanup): Delete.
7085         (struct lwp_deleter): New struct.
7086         (lwp_info_up): New typedef.
7087         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7088         lwp_info_up.
7089
7090 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7091
7092         * linux-fork.c (class scoped_switch_fork_info): New class.
7093         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7094
7095 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7096
7097         * valops.c (find_overload_match): Remove use of null_cleanup, and
7098         calls to do_cleanups.
7099
7100 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * compile/compile-cplus-types.c
7103         (compile_cplus_instance::decl_name): Handle changes to
7104         cp_func_name.
7105         * cp-support.c (cp_func_name): Update header comment, update
7106         return type.
7107         * cp-support.h (cp_func_name): Update return type in declaration.
7108         * valops.c (find_overload_match): Move temp_func local to top
7109         level of function and change its type.  Use temp_func to hold and
7110         delete temporary string obtained from cp_func_name.
7111
7112 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7115         gdb::char_vector, remove cleanup, and update uses of `msg`.
7116
7117 2019-01-03  Jim Wilson  <jimw@sifive.com>
7118
7119         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7120
7121 2019-01-02  Tom Tromey  <tom@tromey.com>
7122
7123         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7124         (tdesc_parse_xml): Remove cleanups.
7125         * target-descriptions.h (make_cleanup_free_target_description):
7126         Don't declare.
7127         (target_desc_deleter): New struct.
7128         (target_desc_up): New typedef.
7129         * target-descriptions.c (target_desc_deleter::operator()): Rename
7130         from free_target_description.
7131         (make_cleanup_free_target_description): Remove.
7132
7133 2019-01-02  Tom Tromey  <tom@tromey.com>
7134
7135         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7136         constructor, destructor.
7137         (linespec_parser): Remove typedef.
7138         (~linespec_parser): Rename from linespec_parser_delete.
7139         (linespec_lex_to_end, linespec_complete_label)
7140         (linespec_complete): Update.
7141         (decode_line_full): Remove cleanups.
7142         (decode_line_1): Update.
7143
7144 2019-01-02  Tom Tromey  <tom@tromey.com>
7145
7146         * python/python-internal.h (inferior_to_inferior_object): Change
7147         return type.
7148         * python/py-exitedevent.c (create_exited_event_object): Update.
7149         * python/py-inferior.c (inferior_to_inferior_object): Return
7150         gdbpy_ref.
7151         (python_new_inferior, python_inferior_deleted)
7152         (thread_to_thread_object, delete_thread_object)
7153         (build_inferior_list, gdbpy_selected_inferior): Update.
7154         * python/py-infthread.c (create_thread_object): Update.  Also fail
7155         if inferior_to_inferior_object fails.
7156
7157 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7158
7159         * inferior.h (class inferior) <displaced_step_state>: New field.
7160         * infrun.h (struct displaced_step_state): Move here from
7161         infrun.c.  Initialize fields, add constructor.
7162         <inf>: Remove field.
7163         <reset>: New method.
7164         * infrun.c (struct displaced_step_inferior_state): Move to
7165         infrun.h.
7166         (displaced_step_inferior_states): Remove.
7167         (get_displaced_stepping_state): Adust.
7168         (displaced_step_in_progress_any_inferior): Adjust.
7169         (displaced_step_in_progress_thread): Adjust.
7170         (displaced_step_in_progress): Adjust.
7171         (add_displaced_stepping_state): Remove.
7172         (get_displaced_step_closure_by_addr): Adjust.
7173         (remove_displaced_stepping_state): Remove.
7174         (infrun_inferior_exit): Call displaced_step_state.reset.
7175         (use_displaced_stepping): Don't check for NULL.
7176         (displaced_step_prepare_throw): Call
7177         get_displaced_stepping_state.
7178         (displaced_step_fixup): Don't check for NULL.
7179         (prepare_for_detach): Don't check for NULL.
7180
7181 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7182
7183         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7184          in case of call that did not complete.
7185
7186 2019-01-02  Andrey Utkin  <autkin@undo.io>
7187
7188         * symfile.c (find_separate_debug_file): Fix search of debug files for
7189         remote debuggee.
7190
7191 2019-01-02  Tom Tromey  <tom@tromey.com>
7192
7193         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7194         indentation.
7195         * python/py-frame.c (frapy_older): Remove cast.
7196         (frapy_newer): Likewise.
7197         * python/py-breakpoint.c (local_setattro): Remove cast.
7198         * python/py-arch.c (archpy_name): Remove local variable.
7199         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7200
7201 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7202
7203         * unittests/basic_string_view/element_access/char/empty.cc:
7204         Fix year range in copyright header.
7205
7206 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7207
7208         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7209         Delete.
7210         <operator==>: Update with for removed field.
7211         <hash>: Likewise.
7212         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7213         <isa_features>: ...this.
7214         <abi_features>: New field.
7215         (riscv_isa_flen): Update comment.
7216         (riscv_abi_xlen): New declaration.
7217         (riscv_abi_flen): New declaration.
7218         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7219         isa_features.
7220         (riscv_abi_xlen): New function.
7221         (riscv_isa_flen): Update to get answer from isa_features.
7222         (riscv_abi_flen): New function.
7223         (riscv_has_fp_abi): Update to get answer from abi_features.
7224         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7225         xlen and flen.
7226         (riscv_call_info) <xlen, flen>: Update comment.
7227         (riscv_call_arg_struct): Remove invalid assertions
7228         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7229         is removed.
7230         (riscv_gdbarch_init): Gather isa features and abi features
7231         separately, ensure both match on the gdbarch when reusing an old
7232         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7233         a target with 64-bit float hardware.
7234
7235 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7236
7237         * source.c (search_command_helper): Stop reverse search
7238         when line 1 has been searched.
7239
7240 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7241
7242         * record-full.c (record_full_base_target::close): Rewrite
7243         record_full_core_buf_list free logic.
7244
7245 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7246
7247         * break-catch-syscall.c (print_one_catch_syscall): xfree
7248         the last text.
7249
7250 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7251
7252         * top.c (print_gdb_version): Update Copyright year in version
7253         message.
7254
7255 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7256
7257         Update copyright year range in all GDB files.
7258
7259 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7260
7261         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7262
7263 For older changes see ChangeLog-2018.
7264 \f
7265 Local Variables:
7266 mode: change-log
7267 left-margin: 8
7268 fill-column: 74
7269 version-control: never
7270 coding: utf-8
7271 End:
7272