gdb/ChangeLog

   1 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * features/Makefile: Remove unused xml files.
   4         * features/aarch64.xml: Remove.
   5         * features/i386/amd64-avx-avx512-linux.xml: Remove.
   6         * features/i386/amd64-avx-avx512.xml: Remove.
   7         * features/i386/amd64-avx-linux.xml: Remove.
   8         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
   9         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
  10         * features/i386/amd64-avx-mpx-linux.xml: Remove.
  11         * features/i386/amd64-avx-mpx.xml: Remove.
  12         * features/i386/amd64-avx.xml: Remove.
  13         * features/i386/amd64-linux.xml: Remove.
  14         * features/i386/amd64-mpx-linux.xml: Remove.
  15         * features/i386/amd64-mpx.xml: Remove.
  16         * features/i386/amd64.xml: Remove.
  17         * features/i386/i386-avx-avx512-linux.xml: Remove.
  18         * features/i386/i386-avx-avx512.xml: Remove.
  19         * features/i386/i386-avx-linux.xml: Remove.
  20         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
  21         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
  22         * features/i386/i386-avx-mpx-linux.xml: Remove.
  23         * features/i386/i386-avx-mpx.xml: Remove.
  24         * features/i386/i386-avx.xml: Remove.
  25         * features/i386/i386-linux.xml: Remove.
  26         * features/i386/i386-mmx-linux.xml: Remove.
  27         * features/i386/i386-mmx.xml: Remove.
  28         * features/i386/i386-mpx-linux.xml: Remove.
  29         * features/i386/i386-mpx.xml: Remove.
  30         * features/i386/i386.xml: Remove.
  31         * features/i386/x32-avx-avx512-linux.xml: Remove.
  32         * features/i386/x32-avx-linux.xml: Remove.
  33         * features/i386/x32-linux.xml: Remove.
  34
  35 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
  36
  37         * regformats/aarch64.dat: Remove.
  38         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
  39         * regformats/i386/amd64-avx-linux.dat: Remove.
  40         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
  41         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
  42         * regformats/i386/amd64-linux.dat: Remove.
  43         * regformats/i386/amd64-mpx-linux.dat: Remove.
  44         * regformats/i386/amd64.dat: Remove.
  45         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
  46         * regformats/i386/i386-avx-linux.dat: Remove.
  47         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
  48         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
  49         * regformats/i386/i386-linux.dat: Remove.
  50         * regformats/i386/i386-mmx-linux.dat: Remove.
  51         * regformats/i386/i386-mpx-linux.dat: Remove.
  52         * regformats/i386/i386.dat: Remove.
  53         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
  54         * regformats/i386/x32-avx-linux.dat: Remove.
  55         * regformats/i386/x32-linux.dat: Remove.
  56
  57 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
  58
  59         * aarch64-tdep.c: Remove xml self tests.
  60         * amd64-linux-tdep.c: Likewise.
  61         * amd64-tdep.c: Likewise.
  62         * i386-linux-tdep.c: Likewise.
  63         * i386-tdep.c: Likewise.
  64
  65 2019-07-03  Pedro Alves  <palves@redhat.com>
  66
  67         PR cli/24732
  68         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
  69         (pipe_cmd_option_defs): New.
  70         (make_pipe_cmd_options_def_group): New.
  71         (pipe_command): Use gdb::option::process_options.
  72         (pipe_command_completer): New function.
  73         (_initialize_cli_cmds): Install completer for "pipe" command.
  74
  75 2019-07-03  Pedro Alves  <palves@redhat.com>
  76
  77         * cli/cli-option.c (union option_value) <string>: New field.
  78         (struct option_def_and_value): Add ctor, move ctor, dtor and
  79         use DISABLE_COPY_AND_ASSIGN.
  80         (option_def_and_value::clear_value): New.
  81         (parse_option, save_option_value_in_ctx, get_val_type_str)
  82         (add_setshow_cmds_for_options): Handle var_string.
  83         * cli-option.h (union option_def::var_address) <string>: New
  84         field.
  85         (struct string_option_def): New.
  86         * maint-test-options.c (struct test_options_opts): Add default
  87         ctor and use DISABLE_COPY_AND_ASSIGN.
  88         <string_opt>: New field.
  89         (test_options_opts::~test_options_opts): New.
  90         (test_options_opts::dump): Also dump "-string".
  91         (test_options_option_defs): Install "string.
  92
  93 2019-07-03  Pedro Alves  <palves@redhat.com>
  94
  95         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
  96         option_value with a null enumeration.
  97         (complete_options): Save the option values in the context.
  98         (save_option_value_in_ctx): New, factored out from ...
  99         (process_options): ... here.
 100         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 101         of the function.
 102         * maint-test-options.c (test_options_opts::dump): New, factored
 103         out from ...
 104         (maintenance_test_options_command_mode): ... here.
 105         (maintenance_test_options_command_completion_result): Delete.
 106         (maintenance_test_options_command_completion_text): Update
 107         comment.
 108         (maintenance_show_test_options_completion_result): Change
 109         prototype.  Just print
 110         maintenance_test_options_command_completion_text.
 111         (save_completion_result): New.
 112         (maintenance_test_options_completer_mode): Pass options context to
 113         complete_options, and then save a dump.
 114         (_initialize_maint_test_options): Use add_cmd to install "maint
 115         show test-options-completion-result".
 116
 117 2019-07-03  Pedro Alves  <palves@redhat.com>
 118
 119         * NEWS (New commands): Mention "with" and "maint with".
 120         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 121         (with_command, with_command_completer): New.
 122         (pipe_command): Adjust to new repeat_previous
 123         interface.
 124         (_initialize_cli_cmds): Install the "with" command and its "w"
 125         alias.
 126         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 127         declarations.
 128         * cli/cli-setshow.c (parse_cli_var_uinteger)
 129         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 130         argument strings for all var_types.
 131         (get_setshow_command_value_string): New, factored out from ...
 132         (do_show_command): ... this.
 133         * cli/cli-setshow.h: Include <string>.
 134         (get_setshow_command_value_string): Declare.
 135         * command.h (repeat_previous): Now returns const char *.  Adjust
 136         comment.
 137         * maint.c: Include "cli/cli-cmds.h".
 138         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 139         (_initialize_maint_cmds): Register the "maintenance with" command.
 140         * top.c (repeat_previous): Move bits from pipe_command here:
 141         Return the saved command line, if any; error out if there's no
 142         command to relaunch.
 143
 144 2019-07-03  Pedro Alves  <palves@redhat.com>
 145
 146         * NEWS (New commands): Mention "maint set/show test-settings"
 147         instead of "maint test-settings".
 148         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 149         (maintenance_test_settings_set_list): Rename to ...
 150         (maintenance_set_test_settings_list): ... this.
 151         (maintenance_test_settings_show_list): Rename to  ...
 152         (maintenance_show_test_settings_list): ... this.
 153         (maintenance_test_settings_cmd): Delete.
 154         (maintenance_test_settings_set_cmd): ...
 155         (maintenance_set_test_settings_cmd): ... this.
 156         (maintenance_test_settings_show_cmd): ...
 157         (maintenance_show_test_settings_cmd): ... this.
 158         (maintenance_test_settings_show_value_cmd):
 159         (maintenance_show_test_settings_value_cmd): ... this.
 160         (_initialize_maint_test_settings): No longer install the "maint
 161         test-settings" prefix command.  Rename "maint test-settings set"
 162         to "maint set test-settings", and "maint test-settings show" to
 163         "maint show test-settings".  Adjust all subcommands.
 164
 165 2019-07-03  Pedro Alves  <palves@redhat.com>
 166
 167         * maint-test-settings.c: Fix file's intro comment.  Replace all
 168         references to "test-options" with references to "test-settings",
 169         in comments.
 170
 171 2019-07-03  Pedro Alves  <palves@redhat.com>
 172
 173         * maint-test-settings.c (maintenance_test_settings_xxx)
 174         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 175         New.
 176         (maintenance_test_settings_enums): Use them.
 177         (maintenance_test_settings_enum): Default to
 178         maintenance_test_settings_xxx.
 179         (_initialize_maint_test_settings): Initialize
 180         MAINTENANCE_TEST_SETTINGS_FILENAME.
 181
 182 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 183
 184         * breakpoint.h (remove_breakpoints_inf): Change return type to
 185         void, move function documentation here.
 186         * breakpoint.c (remove_breakpoints_inf): Change return type to
 187         void, move function documentation to header.
 188
 189 2019-07-02  Pedro Alves  <palves@redhat.com>
 190
 191         * NEWS (Completion improvements): Mention "info threads".
 192         * thread.c (struct info_threads_opts, info_threads_option_defs)
 193         (make_info_threads_options_def_group): New.
 194         (info_threads_command): Use gdb::option::process_options.
 195         (info_threads_command_completer): New.
 196         (_initialize_thread): Use gdb::option::build_help to build the
 197         help text for "info threads".
 198
 199 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 200
 201         * defs.h (generic_load): Move from here...
 202         * symfile.h (generic_load): ... to here.  Rename name parameter
 203         to args.
 204         * symfile.c (generic_load): Add comment.
 205
 206 2019-07-01  Tom Tromey  <tromey@adacore.com>
 207
 208         * dwarf2read.c
 209         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 210         declaration of without_params.  Fix formatting.
 211
 212 2019-07-01  Tom Tromey  <tromey@adacore.com>
 213
 214         * ada-exp.y (find_primitive_type): Update.
 215         * ada-lang.h (ada_lookup_symbol): Update.
 216         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 217         parameter.
 218         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 219
 220 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 221
 222         PR breakpoints/24541
 223         * gdbarch.c: Regenerate.
 224         * gdbarch.h: Regenerate.
 225         * gdbarch.sh: Add 'stap_adjust_register'.
 226         * i386-tdep.c: Include '<unordered_set>'.
 227         (i386_stap_adjust_register): New function.
 228         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 229         * stap-probe.c (stap_parse_register_operand): Call
 230         'gdbarch_stap_adjust_register'.
 231
 232 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 233
 234         PR python/24742
 235         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 236         * python/python.c (do_start_initialization): Use 'xmalloc'
 237         instead of 'PyMem_Malloc'.
 238
 239 2019-06-28  Tom Tromey  <tromey@adacore.com>
 240
 241         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 242         for Ada.
 243
 244 2019-06-27  Tom Tromey  <tromey@adacore.com>
 245
 246         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 247         objfile_key.
 248         (arm_find_mapping_symbol, arm_record_special_symbol)
 249         (_initialize_arm_tdep): Update.
 250         (arm_objfile_data_free): Remove.
 251
 252 2019-06-27  Tom Tromey  <tromey@adacore.com>
 253
 254         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 255         to cp_print_static_field.
 256
 257 2019-06-26  Tom Tromey  <tromey@adacore.com>
 258
 259         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 260         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 261         declare.
 262
 263 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 264
 265         * features/aarch64-core.c (create_feature_aarch64_core):
 266         Regenerate.
 267         * features/aarch64-core.xml: Add cpsr flags.
 268
 269 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 270
 271         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 272         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 273
 274 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 275
 276         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 277         field.
 278         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 279         use.
 280         (arm_record_special_symbol): Don't insert new symbol in sorted
 281         position, push it at the end.
 282
 283 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 284
 285         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 286         (arm_mapping_symbol_s): Remove.
 287         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 288         (arm_mapping_symbol_vec): New typedef.
 289         (struct arm_per_objfile): Add constructor.
 290         <section_maps>: Change type to
 291         std::unique_ptr<arm_mapping_symbol_vec[]>.
 292         (arm_compare_mapping_symbols): Remove.
 293         (arm_find_mapping_symbol): Adjust to section_maps type change.
 294         (arm_objfile_data_free): Call delete on arm_per_objfile.
 295         (arm_record_special_symbol): Adjust to section_maps type change.
 296         Allocate arm_per_objfile with new.
 297
 298 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 299
 300         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 301         with the command prefix.
 302
 303 2019-06-25  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 306         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 307
 308 2019-06-25  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 311         type.
 312         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 313         protected.
 314
 315 2019-06-25  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-winsource.c
 318         (tui_source_window_base::set_is_exec_point_at): Add check against
 319         LOA_ADDRESS.
 320
 321 2019-06-25  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-source.c (tui_set_source_content): Don't check before
 324         xfree.
 325         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 326
 327 2019-06-25  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-winsource.h (tui_update_source_window_as_is)
 330         (tui_alloc_source_buffer, tui_line_is_displayed)
 331         (tui_addr_is_displayed): Change type of win_info.
 332         * tui/tui-winsource.c (tui_update_source_window_as_is)
 333         (tui_clear_source_content, tui_show_source_line)
 334         (tui_show_source_content, tui_source_window_base::refill)
 335         (tui_source_window_base::set_is_exec_point_at)
 336         (tui_source_window_base::set_is_exec_point_at)
 337         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 338         (tui_alloc_source_buffer, tui_line_is_displayed)
 339         (tui_addr_is_displayed): Change type of win_info.  Update.
 340         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 341         (tui_source_window_base::do_make_visible_with_new_height):
 342         Update.
 343         * tui/tui-source.c (tui_set_source_content)
 344         (tui_set_source_content_nil)
 345         (tui_source_window::do_scroll_vertical): Update.
 346         * tui/tui-layout.c (show_layout): Update.
 347         * tui/tui-disasm.c (tui_set_disassem_content)
 348         (tui_disasm_window::do_scroll_vertical): Update.
 349         * tui/tui-data.h (tui_win_content): Remove.
 350         (struct tui_gen_win_info) <content, content_size>: Remove.
 351         (struct tui_source_element): Add initializers and destructor.
 352         (union tui_which_element, struct tui_win_element): Remove.
 353         (struct tui_source_window_base) <content>: New field.
 354         (struct tui_data_window): Remove destructor.
 355         (tui_alloc_content, tui_free_win_content)
 356         (tui_free_all_source_wins_content): Don't declare.
 357         * tui/tui-data.c (tui_initialize_static_data): Update.
 358         (init_content_element, tui_alloc_content): Remove.
 359         (~tui_gen_win_info): Update.
 360         (~tui_data_window, tui_free_all_source_wins_content)
 361         (tui_free_win_content, free_content, free_content_elements):
 362         Remove.
 363
 364 2019-06-25  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-winsource.h (tui_clear_source_content)
 367         (tui_erase_source_content, tui_show_source_content): Change type
 368         of win_info.
 369         * tui/tui-winsource.c (tui_clear_source_content)
 370         (tui_erase_source_content, tui_show_source_content): Change type
 371         of win_info.
 372         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 373         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 374         win_info.
 375         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 376         win_info.
 377         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 378
 379 2019-06-25  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-winsource.c (tui_clear_source_content)
 382         (tui_source_window_base::set_is_exec_point_at): Update.
 383         * tui/tui-source.c (tui_set_source_content_nil): Update.
 384         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 385         a bool.
 386         * tui/tui-data.c (init_content_element): Update.
 387
 388 2019-06-25  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 391         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 392         * tui/tui-layout.c (init_and_make_win): Update.
 393         * tui/tui.h (enum tui_win_type): Update.
 394         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 395         tui_win_is_auxillary.
 396         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 397         tui_win_is_auxillary.
 398
 399 2019-06-25  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 402         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 403         (tui_delete_data_content_windows, tui_display_all_data)
 404         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 405         Update.
 406         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 407         * tui/tui-regs.c (tui_last_regs_line_no)
 408         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 409         (tui_show_registers): Update.
 410         (tui_show_register_group): Return void.  Update.
 411         (tui_display_registers_from, tui_display_reg_element_at_line)
 412         (tui_display_registers_from_line, tui_check_register_values):
 413         Update.
 414         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 415         member.
 416         (struct tui_data_window) <regs_content>: Now a std::vector.
 417         <regs_content_count>: Remove.
 418         (tui_add_content_elements, tui_free_data_content): Don't declare.
 419         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 420         (init_content_element): Remove DATA_WIN case.  Add assert.
 421         (tui_add_content_elements): Remove.
 422         (tui_data_window): Update.
 423         (tui_free_data_content): Remove.
 424         (free_content_elements): Remove DATA_WIN case.
 425
 426 2019-06-25  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-data.c (tui_data_item_window): Update.
 429         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 430         * tui/tui-windata.c (tui_display_all_data)
 431         (tui_display_data_from_line): Update.
 432         (tui_check_data_values): Remove.
 433         * tui/tui-regs.c (tui_show_register_group)
 434         (tui_display_reg_element_at_line): Update.
 435         * tui/tui-hooks.c (tui_register_changed)
 436         (tui_refresh_frame_and_register_information): Call
 437         tui_check_register_values.
 438         * tui/tui-data.h (struct tui_data_window) <data_content,
 439         data_content_count, data_type>: Remove.
 440         (enum tui_data_type): Remove.
 441
 442         * tui/tui-data.c (tui_data_window::clear_detail)
 443         (~tui_data_window): Update.
 444
 445 2019-06-25  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 448         declare.
 449         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 450         Rename from tui_first_data_item_displayed.  Update.
 451         (tui_data_window::refresh_all)
 452         (tui_data_window::do_scroll_vertical): Update.
 453         * tui/tui-data.h (struct tui_data_window)
 454         <first_data_item_displayed>: Declare new method.
 455
 456 2019-06-25  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 459         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 460         contents...
 461         (tui_initialize_static_data): ...here.
 462
 463 2019-06-25  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 466         (tui_display_registers_from, tui_check_register_values): Update.
 467         (tui_display_register): Remove win_info parameter; update.
 468         (tui_get_register): Change type of parameters.
 469         * tui/tui-data.h (struct tui_data_element): Remove.
 470         (union tui_which_element) <data>: Remove.
 471         <data_window>: Change type.
 472         (struct tui_data_item_window): New.
 473         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 474         case.  Add assert.
 475         (~tui_data_item_window): New destructor.
 476         (free_content_elements): Remove DATA_ITEM_WIN case.
 477
 478 2019-06-25  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 481         Remove.
 482
 483 2019-06-25  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-data.h (struct tui_command_element): Remove.
 486         (union tui_which_element) <command>: Remove.
 487         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 488         assert.
 489         (free_content_elements): Remove CMD_WIN case.
 490
 491 2019-06-25  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-layout.c (tui_set_layout): Update.
 494         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 495         * tui/tui-data.c (layout_def): Update.
 496
 497 2019-06-25  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 500         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 501         (tui_source_window_base::set_new_height): Update.
 502         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 503         Update.
 504         (tui_set_locator_fullname, tui_set_locator_info)
 505         (tui_show_frame_info): Update.
 506         * tui/tui-source.c (tui_set_source_content)
 507         (tui_source_is_displayed): Update.
 508         * tui/tui-layout.c (show_source_disasm_command, show_data)
 509         (show_source_or_disasm_and_command): Update.
 510         * tui/tui-disasm.c (tui_set_disassem_content)
 511         (tui_get_begin_asm_address): Update.
 512         * tui/tui-data.h (struct tui_locator_element): Remove.
 513         (union tui_which_element) <locator>: Remove.
 514         (struct tui_locator_window): New.
 515         (tui_locator_win_info_ptr): Change return type.
 516         * tui/tui-data.c (_locator): Change type.
 517         (tui_locator_win_info_ptr): Change return type.
 518         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 519         (tui_alloc_content): Add assert.
 520
 521 2019-06-25  Tom Tromey  <tom@tromey.com>
 522
 523         * tui/tui-winsource.c
 524         (tui_exec_info_window::maybe_allocate_content): New method.
 525         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 526         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 527         (make_source_or_disasm_window): Add cast.
 528         * tui/tui-data.h (union tui_which_element) <simple_string>:
 529         Remove.
 530         (struct tui_source_info): New.
 531         (struct tui_source_window_base) <execution_info>: Change type.
 532         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 533         case, and add assert.
 534         (tui_alloc_content): Add assert.
 535
 536 2019-06-25  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 539         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 540         * tui/tui-data.c (tui_alloc_win_info): Remove.
 541
 542 2019-06-25  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 545         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 546         can_highlight.
 547
 548 2019-06-25  Tom Tromey  <tom@tromey.com>
 549
 550         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 551         make_visible_with_new_height method.
 552         (tui_win_info::make_visible_with_new_height): New method.
 553         (tui_source_window_base::do_make_visible_with_new_height)
 554         (tui_data_window::do_make_visible_with_new_height)
 555         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 556         (make_visible_with_new_height): Remove.
 557         (tui_resize_all, tui_adjust_win_heights): Use
 558         make_visible_with_new_height method.
 559         * tui/tui-data.h (struct tui_win_info)
 560         <do_make_visible_with_new_height, make_visible_with_new_height>:
 561         New methods.
 562         (struct tui_source_window_base, struct tui_data_window)
 563         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 564         methods.
 565
 566 2019-06-25  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 569         method.
 570         (update_tab_width): Call update_tab_width method.
 571         * tui/tui-data.h (struct tui_win_info)
 572         (struct tui_source_window_base) <update_tab_width>: New methods.
 573
 574 2019-06-25  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 577         parameter.
 578         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 579         parameter.
 580         (tui_gen_win_info::make_visible): Update.
 581         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 582         parameter.
 583         * tui/tui-data.h (enum tui_box): New enum.
 584         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 585
 586 2019-06-25  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 589         init_and_make_win for EXEC_INFO_WIN.
 590         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 591         longer inline.
 592         (struct tui_win_info) <~tui_win_info>: Inline.
 593         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 594         Don't declare.
 595         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 596         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 597         Remove.
 598         (tui_initialize_static_data): Update.
 599         (~tui_gen_win_info): Handle more cleanup here.
 600         (~tui_source_window_base): Delete "execution_info".
 601         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 602
 603 2019-06-25  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-layout.c (make_command_window): Don't set
 606         can_highlight.
 607         (show_source_disasm_command): Call the reset method.
 608         (show_data): Don't set can_highlight.  Call the reset method.
 609         (tui_gen_win_info::reset): Rename from init_gen_win_info
 610         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 611         (show_source_or_disasm_and_command): Call the reset method.
 612         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 613         (struct tui_cmd_window): Set can_highlight.
 614
 615 2019-06-25  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 618         from make_visible.
 619         (tui_make_visible, tui_make_invisible): Rewrite.
 620         (tui_win_info::make_visible): Remove.
 621         (tui_source_window_base::make_visible): Update.
 622         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 623         method.  Moved from...
 624         (struct tui_win_info) <make_visible>: ...here.
 625
 626 2019-06-25  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-winsource.c
 629         (tui_source_window_base::do_scroll_horizontal): Remove direction
 630         parameter.
 631         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 632         direction parameter.
 633         * tui/tui-win.c (tui_win_info::forward_scroll)
 634         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 635         (tui_win_info::right_scroll): Update.
 636         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 637         direction parameter.
 638         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 639         direction parameter.
 640         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 641         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 642         Remove direction parameter.
 643         (struct tui_source_window_base, struct tui_source_window)
 644         (struct tui_disasm_window, struct tui_data_window)
 645         (struct tui_cmd_window): Update.
 646
 647 2019-06-25  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-winsource.h (tui_set_exec_info_content)
 650         (tui_show_exec_info_content, tui_erase_exec_info_content)
 651         (tui_clear_exec_info_content, tui_update_exec_info): Change
 652         argument to tui_source_window_base.
 653         * tui/tui-winsource.c (tui_set_exec_info_content)
 654         (tui_show_exec_info_content, tui_erase_exec_info_content)
 655         (tui_clear_exec_info_content, tui_update_exec_info): Change
 656         argument to tui_source_window_base.
 657
 658 2019-06-25  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 661         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 662
 663 2019-06-25  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 666         check.
 667
 668 2019-06-25  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 671         type to void.
 672         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 673         type to void.
 674         * tui/tui-source.c (tui_set_source_content): Update.
 675         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 676
 677 2019-06-25  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui-win.c (window_name_completer, tui_set_focus)
 680         (tui_all_windows_info): Use name method.
 681         * tui/tui-data.h (struct tui_gen_win_info)
 682         (struct tui_source_window, struct tui_disasm_window)
 683         (struct tui_data_window, struct tui_cmd_window) <name>: New
 684         method.
 685         (tui_win_name): Don't declare.
 686         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 687         (tui_win_name): Remove.
 688
 689 2019-06-25  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-winsource.h (tui_update_source_window)
 692         (tui_update_source_window_as_is): Change parameter type.
 693         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 694         to be a tui_source_window_base.
 695         (tui_update_source_window_as_is): Likewise.
 696         * tui/tui-win.c (make_visible_with_new_height): Update.
 697
 698 2019-06-25  Tom Tromey  <tom@tromey.com>
 699
 700         * tui/tui-winsource.c (tui_erase_source_content)
 701         (tui_show_source_content, tui_show_exec_info_content)
 702         (tui_erase_exec_info_content): Use refresh_window method.
 703         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 704         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 705         from tui_refresh_win.
 706         (tui_data_window::refresh_window): New method.
 707         (tui_win_info::refresh, tui_source_window_base::refresh)
 708         (tui_refresh_all): Use refresh_window method.
 709         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 710         method.
 711         * tui/tui-regs.c (tui_display_register): Call refresh_window
 712         method.
 713         * tui/tui-layout.c (show_source_disasm_command)
 714         (show_source_or_disasm_and_command): Call refresh_window method.
 715         * tui/tui-data.h (struct tui_gen_win_info)
 716         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 717         New method.
 718
 719 2019-06-25  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui.c (tui_rl_other_window, tui_enable)
 722         (tui_is_window_visible, tui_get_command_dimension): Update.
 723         * tui/tui-winsource.c (tui_update_source_window_as_is)
 724         (tui_clear_source_content, tui_erase_source_content)
 725         (tui_show_source_line, tui_source_window_base::refill)
 726         (tui_source_window_base::do_scroll_horizontal)
 727         (tui_source_window_base::set_is_exec_point_at)
 728         (tui_update_breakpoint_info, tui_set_exec_info_content)
 729         (tui_alloc_source_buffer, tui_line_is_displayed)
 730         (tui_addr_is_displayed): Update.
 731         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 732         (tui_check_and_display_highlight_if_needed)
 733         (tui_win_info::make_visible, tui_win_info::refresh)
 734         (tui_refresh_all): Update.
 735         * tui/tui-windata.c (tui_first_data_item_displayed)
 736         (tui_delete_data_content_windows, tui_erase_data_content)
 737         (tui_display_all_data, tui_data_window::refresh_all)
 738         (tui_check_data_values): Update.
 739         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 740         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 741         (tui_win_info::backward_scroll, tui_refresh_all_win)
 742         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 743         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 744         (tui_source_window_base::set_new_height)
 745         (tui_data_window::set_new_height)
 746         (make_invisible_and_set_new_height)
 747         (make_visible_with_new_height, new_height_ok)
 748         (parse_scrolling_args): Update.
 749         * tui/tui-stack.c (tui_show_frame_info): Update.
 750         * tui/tui-source.c (tui_set_source_content)
 751         (tui_set_source_content_nil, tui_source_is_displayed)
 752         (tui_source_window::do_scroll_vertical): Update.
 753         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 754         (tui_display_registers_from, tui_display_reg_element_at_line)
 755         (tui_check_register_values, tui_reg_command): Update.
 756         * tui/tui-layout.c (tui_default_win_height)
 757         (show_source_disasm_command, show_data, init_and_make_win)
 758         (show_source_or_disasm_and_command): Update.
 759         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 760         (tui_redisplay_readline, tui_mld_flush)
 761         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 762         (tui_getc): Update.
 763         * tui/tui-disasm.c (tui_set_disassem_content)
 764         (tui_disasm_window::do_scroll_vertical): Update.
 765         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 766         Now virtual.
 767         (struct tui_win_info): Derive from tui_gen_win_info.
 768         <~tui_win_info>: Mark as override.
 769         <generic>: Remove member.
 770         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 771         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 772         (~tui_data_window, ~tui_win_info)
 773         (tui_free_all_source_wins_content): Update.
 774         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 775
 776 2019-06-25  Tom Tromey  <tom@tromey.com>
 777
 778         * tui/tui-layout.c (init_and_make_win): Use new.
 779         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 780         destructor, initializers.
 781         (tui_alloc_generic_win_info): Don't declare.
 782         * tui/tui-data.c (_locator): Add argument to constructor.
 783         (source_win, disasm_win): New globals.
 784         (exec_info): Remove.
 785         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 786         Update.
 787         (tui_alloc_generic_win_info): Remove.
 788         (init_content_element): Use new.
 789         (tui_win_info::tui_win_info): Update.
 790         (free_content_elements) <case DATA_WIN>: Use delete.
 791
 792 2019-06-25  Tom Tromey  <tom@tromey.com>
 793
 794         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 795         * tui/tui-windata.c (tui_first_data_item_displayed)
 796         (tui_delete_data_content_windows): Update.
 797         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 798         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 799         (tui_display_registers_from, tui_check_register_values): Update.
 800         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 801         pointer.
 802         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 803         window.
 804         (tui_free_data_content): Update.
 805         (free_content_elements) <case DATA_WIN>: Free the window.
 806
 807 2019-06-25  Tom Tromey  <tom@tromey.com>
 808
 809         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 810         Update.
 811         * tui/tui-layout.c (make_command_window)
 812         (show_source_disasm_command, show_data, init_and_make_win)
 813         (show_source_or_disasm_and_command): Update.
 814         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 815         method.
 816         <can_highight, is_highlighted>: Now bool.
 817         (tui_set_win_highlight): Don't declare.
 818         * tui/tui-data.c (tui_set_win_highlight): Remove.
 819
 820 2019-06-25  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-wingeneral.c (make_visible): Remove check of window
 823         type.
 824
 825 2019-06-25  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-win.c (tui_win_info::max_height)
 828         (tui_cmd_window::max_height): New methods.
 829         (new_height_ok): Call max_height.
 830         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 831         <max_height>: New method.
 832
 833 2019-06-25  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-win.c (tui_source_window_base::set_new_height)
 836         (tui_data_window::set_new_height): New methods.
 837         (make_invisible_and_set_new_height): Call set_new_height method.
 838         * tui/tui-data.h (struct tui_win_info)
 839         (struct tui_source_window_base, struct tui_data_window)
 840         <set_new_height>: New method.
 841
 842 2019-06-25  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 845         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 846         tui_refresh_data_win.
 847         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 848         method.
 849         (tui_refresh_all_win): Call the refresh_all method.
 850         (tui_set_focus): Likewise.
 851         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 852         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 853         Likewise.
 854
 855 2019-06-25  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-winsource.h (tui_refill_source_window)
 858         (tui_set_is_exec_point_at): Don't declare.
 859         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 860         (tui_source_window_base::refill): Rename from
 861         tui_refill_source_window.
 862         (tui_source_window_base::do_scroll_horizontal): Update.
 863         (tui_source_window_base::set_is_exec_point_at): Rename from
 864         tui_set_is_exec_point_at.
 865         (tui_update_all_breakpoint_info): Update.
 866         * tui/tui-stack.c (tui_show_frame_info): Update.
 867         * tui/tui-layout.c (show_data): Add cast.
 868         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 869         * tui/tui-data.h (struct tui_source_window_base) <refill,
 870         set_is_exec_point_at>: New methods.
 871         (tui_source_windows, tui_add_to_source_windows): Update types.
 872         (tui_add_to_source_windows): Remove redundant declaration.
 873         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 874         (tui_source_windows): Change return type.
 875         (tui_clear_source_windows_detail): Update.
 876         (tui_add_to_source_windows): Change type of parameter.
 877         (tui_free_all_source_wins_content): Update.
 878
 879 2019-06-25  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-wingeneral.c (tui_win_info::refresh)
 882         (tui_source_window_base::refresh): New methods.
 883         (tui_refresh_all): Call the refresh method.
 884         * tui/tui-data.h (struct tui_win_info)
 885         (struct tui_source_window_base) <refresh>: New method.
 886
 887 2019-06-25  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui.h (tui_is_window_visible): Return bool.
 890         * tui/tui.c (tui_is_window_visible): Return bool.
 891         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 892         (tui_make_visible, tui_make_invisible)
 893         (tui_win_info::make_visible)
 894         (tui_source_window_base::make_visible, make_all_visible)
 895         (tui_make_all_visible, tui_make_all_invisible): Update.
 896         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 897         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 898         bool.
 899         (struct tui_win_info, struct tui_source_window_base)
 900         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 901         * tui/tui-data.c (tui_init_generic_part): Update.
 902
 903 2019-06-25  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 906         (tui_source_window_base::make_visible): New methods.
 907         (make_all_visible): Make method call.
 908         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 909         (struct tui_source_window_base, struct tui_cmd_window): Override
 910         make_visible.
 911         (tui_win_is_source_type): Don't declare.
 912         * tui/tui-data.c (tui_win_is_source_type): Remove.
 913
 914 2019-06-25  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 917         NULL check.
 918
 919 2019-06-25  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 922         Inline constructor.  Add initializers for members.
 923         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 924         constructors; now inline in class.
 925
 926 2019-06-25  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-regs.c (tui_show_registers): Update.
 929         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 930         bool.
 931         * tui/tui-data.c (tui_data_window::clear_detail)
 932         (tui_data_window): Update.
 933
 934 2019-06-25  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-windata.c (tui_display_all_data)
 937         (tui_display_data_from_line, tui_display_data_from)
 938         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 939         Update.
 940         * tui/tui-regs.c (tui_last_regs_line_no)
 941         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 942         (tui_show_registers, tui_show_register_group)
 943         (tui_display_registers_from, tui_display_reg_element_at_line)
 944         (tui_display_registers_from_line, tui_check_register_values)
 945         (tui_reg_next, tui_reg_prev): Update.
 946         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 947         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 948         tui_data_window.
 949         (struct tui_win_info) <detail>: Remove.  Add new fields from
 950         tui_data_info.
 951         (TUI_DATA_WIN): Add cast.
 952         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 953         (~tui_data_window): Simplify.
 954
 955 2019-06-25  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui-layout.c (show_source_disasm_command)
 958         (show_source_or_disasm_and_command): Update.
 959         * tui/tui-io.c (update_cmdwin_start_line)
 960         (tui_redisplay_readline): Update.
 961         * tui/tui-data.h (struct tui_command_info): Remove.
 962         (struct tui_win_info) <detail>: Remove command_info member.
 963         (struct tui_data_window) <start_line>: New member, from
 964         tui_command_info.
 965         (TUI_CMD_WIN): Add casts.
 966
 967 2019-06-25  Tom Tromey  <tom@tromey.com>
 968
 969         * tui/tui-winsource.c (tui_update_source_window)
 970         (tui_refill_source_window)
 971         (tui_source_window_base::do_scroll_horizontal)
 972         (tui_update_breakpoint_info, tui_set_exec_info_content)
 973         (tui_show_exec_info_content, tui_erase_exec_info_content)
 974         (tui_clear_exec_info_content): Update.
 975         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 976         Update.
 977         * tui/tui-win.c (make_invisible_and_set_new_height)
 978         (make_visible_with_new_height): Update.
 979         * tui/tui-source.c (tui_set_source_content)
 980         (tui_show_symtab_source): Update.
 981         * tui/tui-layout.c (extract_display_start_addr)
 982         (show_source_disasm_command, show_data)
 983         (make_source_or_disasm_window)
 984         (show_source_or_disasm_and_command): Update.
 985         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 986         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 987         "gdbarch".
 988         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 989         to tui_source_window_base.
 990         (struct tui_win_info) <detail>: Remove source_info member.
 991         (struct tui_source_window_base) <has_locator>: Inline.
 992         Move contents from tui_source_info; rename has_locator member to
 993         m_has_locator.
 994         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 995         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 996         header file.
 997         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 998         Simplify.
 999         (tui_free_all_source_wins_content): Cast to
1000         tui_source_window_base.
1001
1002 2019-06-25  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-win.c (make_invisible_and_set_new_height)
1005         (make_visible_with_new_height): Call has_locator method.
1006         * tui/tui-layout.c (show_source_disasm_command, show_data)
1007         (show_source_or_disasm_and_command): Update for bool change.
1008         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1009         (tui_win_info) <has_locator>: New method.
1010         (struct tui_source_window_base) <has_locator>: New method.
1011         (tui_win_has_locator): Don't declare.
1012         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1013         from tui_win_has_locator.
1014         (tui_source_window_base): Use false, not FALSE.
1015
1016 2019-06-25  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1019         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1020         clear_detail method directly.
1021         (tui_clear_win_detail): Remove.
1022
1023 2019-06-25  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1026         "this", not TUI_DISASM_WIN.
1027
1028 2019-06-25  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1031         declare.
1032         * tui/tui-winsource.c
1033         (tui_source_window_base::do_scroll_horizontal): Rename from
1034         tui_horizontal_source_scroll.
1035         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1036         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1037         from tui_vertical_data_scroll.
1038         * tui/tui-win.h (tui_scroll): Don't declare.
1039         * tui/tui-win.c (tui_win_info::forward_scroll)
1040         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1041         (tui_win_info::right_scroll): Rename and update.
1042         (tui_scroll_forward_command, tui_scroll_backward_command)
1043         (tui_scroll_left_command, tui_scroll_right_command): Update.
1044         (tui_scroll): Remove.
1045         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1046         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1047         from tui_vertical_source_scroll.
1048         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1049         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1050         from tui_vertical_disassem_scroll.
1051         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1052         do_scroll_horizontal>: New methods.
1053         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1054         Likewise.
1055         (struct tui_source_window_base): Add do_scroll_horizontal.
1056         (struct tui_source_window, struct tui_disasm_window): Add
1057         do_scroll_vertical.
1058         (struct tui_data_window, struct tui_cmd_window): Add
1059         do_scroll_horizontal and do_scroll_vertical.
1060         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1061
1062 2019-06-25  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-data.h (struct tui_source_window_base): New struct.
1065         (struct tui_source_window): Derive from tui_source_window_base.
1066         (struct tui_disasm_window): New struct.
1067         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1068         from tui_source_window::clear_detail.
1069         (tui_source_window_base): Rename from tui_source_window.
1070         (~tui_source_window_base): Rename from ~tui_source_window.
1071         (tui_alloc_win_info): Create a tui_disasm_window.
1072
1073 2019-06-25  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-data.h (struct tui_source_window)
1076         (struct tui_data_window): Declare destructors.
1077         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1078         destructors.
1079         (tui_win_info): Simplify.
1080
1081 2019-06-25  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui-winsource.c (tui_display_main)
1084         (tui_update_source_windows_with_addr)
1085         (tui_update_all_breakpoint_info): Update.
1086         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1087         (new_height_ok, parse_scrolling_args): Update.
1088         * tui/tui-stack.c (tui_show_frame_info): Update.
1089         * tui/tui-data.h (struct tui_list): Remove.
1090         (tui_source_windows): Return a reference to a std::vector.
1091         * tui/tui-data.c (source_windows): Now a std::vector.
1092         (tui_source_windows): Change return type.
1093         (tui_clear_source_windows): Rewrite.
1094         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1095         (tui_free_all_source_wins_content): Rewrite.
1096
1097 2019-06-25  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1100         (struct tui_data_window, struct tui_cmd_window): Declare
1101         clear_detail method.
1102         * tui/tui-data.c (tui_source_window::clear_detail)
1103         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1104         methods.
1105         (tui_clear_win_detail): Simplify.
1106
1107 2019-06-25  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui-layout.c (make_source_window, make_disasm_window)
1110         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1111         Return the new window.
1112         (show_source_disasm_command, show_data)
1113         (show_source_or_disasm_and_command): Update.
1114
1115 2019-06-25  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1118         parameter.  Return the new window.
1119         (show_source_disasm_command): Update and remove NULL check.
1120         (show_source_or_disasm_and_command): Update.
1121
1122 2019-06-25  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1125
1126 2019-06-25  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-data.h (struct tui_win_info): Make constructor
1129         protected.  Make destructor virtual.  Add initializers.
1130         (tui_source_window, tui_data_window, tui_cmd_window): New
1131         classes.
1132         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1133         constructor.  Add "type" parameter.
1134         (tui_source_window, tui_data_window, tui_cmd_window): New
1135         constructors.
1136         (tui_alloc_win_info): Instantiate the appropriate subclass.
1137
1138 2019-06-25  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-win.c (tui_resize_all): Use delete.
1141         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1142         destructor.
1143         (tui_free_window): Don't declare.
1144         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1145         Update.
1146
1147 2019-06-25  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-data.h (struct tui_win_info): Add constructor.
1150         * tui/tui-data.c (tui_alloc_win_info): Use new.
1151         (tui_free_window): Use delete.
1152
1153 2019-06-22  Tom Tromey  <tom@tromey.com>
1154
1155         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1156         declare.
1157         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1158
1159 2019-06-22  Tom Tromey  <tom@tromey.com>
1160
1161         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1162         declare.
1163         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1164
1165 2019-06-22  Tom de Vries  <tdevries@suse.de>
1166
1167         * dwarf2read.c (create_addrmap_from_aranges)
1168         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1169         instead of '%zu'.
1170
1171 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1172
1173         * dwarf2read.h (dwarf2_section_info_def): Remove.
1174         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1175         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1176         std::vector<dwarf2_section_info>.
1177         (struct dwo_file) <~dwo_file>: Remove.
1178         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1179         types field.
1180         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1181         (dwarf2_read_debug_names): Likewise.
1182         (create_debug_types_hash_table): Change parameter type to
1183         array_view, adjust code accordingly.
1184         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1185         (partial_die_info::fixup): Likewise.
1186         (determine_prefix): Likewise.
1187         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1188
1189 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1190
1191         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1192         gdb_bfd_ref_ptr.
1193         <~dwo_file>: Remove call to gdb_bfd_unref.
1194         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1195         gdb_bfd_ref_ptr::get.
1196
1197 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1198
1199         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1200         type to htab_up.
1201         * dwarf2read.c (struct dwo_file): Initialize fields.
1202         <~dwo_file>: New.
1203         (free_dwo_file): Remove, move content to ~dwo_file.
1204         (struct dwo_file_deleter): Remove.
1205         (dwo_file_up>: Remove custom deleter.
1206         (free_dwo_files): Remove.
1207         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1208         dwo_files.
1209         (process_skeletonless_type_units): Call unique_ptr::get.
1210         (allocate_dwo_file_hash_table): Add deleter to created hash
1211         table.  Change return type to htab_up.
1212         (lookup_dwo_file_slot): Don't memset dwo_file, call
1213         unique_ptr::get.
1214         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1215         (create_dwo_unit_in_dwp_v2): Likewise.
1216         (open_and_init_dwo_file): Likewise.
1217         (free_dwo_file_from_slot): Remove.
1218
1219 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1220
1221         * dwarf2read.h (struct dwarf2_section_info) <readin,
1222         is_virtual>: Change type to bool.
1223         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1224         true instead of 1.
1225
1226 2019-06-19  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-data.h (tui_init_content_element): Don't declare.
1229
1230 2019-06-19  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-data.h (tui_init_win_info): Don't declare.
1233
1234 2019-06-19  Tom de Vries  <tdevries@suse.de>
1235
1236         * dwarf2read.h (abstract_to_concrete): Change type to
1237         std::unordered_map<sect_offset, std::vector<sect_offset>,
1238         gdb::hash_enum<sect_offset>>.
1239
1240 2019-06-19  Tom Tromey  <tromey@adacore.com>
1241
1242         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1243         EVAL_AVOID_SIDE_EFFECTS specially.
1244
1245 2019-06-19  Tom Tromey  <tromey@adacore.com>
1246
1247         * source-cache.c (highlighter): New global.
1248         (source_cache::get_source_lines): Create a highlighter on demand.
1249
1250 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * defs.h (deprecated_interactive_hook): Delete declaration.
1253         * interps.c (clear_interpreter_hooks): Remove use of
1254         deprecated_interactive_hook.
1255         * top.c (deprecated_interactive_hook): Delete definition.
1256         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1257
1258 2019-06-18  Tom de Vries  <tdevries@suse.de>
1259
1260         PR gdb/24515
1261         * dwarf2read.h (abstract_to_concrete): Change type from
1262         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1263         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1264         * dwarf2read.c (read_variable): Update.
1265         (dwarf2_fetch_die_loc_sect_off): Update.
1266
1267 2019-06-17  Tom de Vries  <tdevries@suse.de>
1268
1269         PR gdb/24617
1270         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1271         accessing parent[parent_len - 1].
1272
1273 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1274
1275         PR gdb/24364
1276         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1277         call dtrace_process_dof with NULL dof.
1278
1279 2019-06-16  Tom de Vries  <tdevries@suse.de>
1280
1281         PR gdb/24445
1282         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1283
1284 2019-06-16  Tom Tromey  <tom@tromey.com>
1285
1286         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1287         (make_all_visible): Use address of member.
1288
1289 2019-06-16  Tom Tromey  <tom@tromey.com>
1290
1291         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1292         (tui_free_window, free_content, free_content_elements): Remove
1293         unnecessary cast.
1294         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1295         cast.
1296         * tui/tui-regs.c (tui_show_register_group)
1297         (tui_display_registers_from, tui_display_reg_element_at_line):
1298         Remove unnecessary cast.
1299
1300 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * linux-nat.c (normal_mask): Delete.
1303         (_initialize_linux_nat): Don't initialise normal_mask.
1304
1305 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1306
1307         PR gdb/24445
1308         * dwarf-index-write.h (write_psymtabs_to_index): Add
1309         dwz_basename parameter.
1310         * dwarf-index-write.c (write_gdbindex): Move file writing to
1311         write_gdbindex_1.  Change return type void.
1312         (assert_file_size): Move up, remove filename parameter.
1313         (write_gdbindex_1): New function.
1314         (write_debug_names): Change return type to void, call
1315         assert_file_size.
1316         (struct index_wip_file): New struct.
1317         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1318         file logic to index_wip_file.  Write index for dwz file if
1319         needed.
1320         (save_gdb_index_command): Pass basename of dwz file, if present.
1321         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1322         build-id of dwz file, if present.
1323         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1324         (dwarf2_get_dwz_file): Likewise.
1325         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1326         (dwarf2_get_dwz_file): Likewise.
1327
1328 2019-06-16  Tom Tromey  <tom@tromey.com>
1329
1330         * coffread.c (process_coff_symbol): Use xstrdup.
1331         * value.c (create_internalvar): Use xstrdup.
1332
1333 2019-06-16  Tom Tromey  <tom@tromey.com>
1334
1335         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1336         * breakpoint.c (stopin_command, stopat_command)
1337         (until_break_command, decode_location_default): Remove unnecessary
1338         cast.
1339         * utils.c (subset_compare): Remove unnecessary cast.
1340         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1341         cast.
1342         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1343         cast.
1344         * infcmd.c (path_command): Remove unnecessary cast.
1345         * coffread.c (decode_type): Remove unnecessary cast.
1346         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1347         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1348         * tui/tui-stack.c (tui_show_locator_content)
1349         (tui_show_frame_info): Remove unnecessary cast.
1350         * tui/tui-win.c (tui_scroll_forward_command)
1351         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1352         (parse_scrolling_args): Remove unnecessary cast.
1353         * tui/tui-data.c (init_win_info, tui_del_window)
1354         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1355         (free_content_elements): Remove unnecessary cast.
1356         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1357         unnecessary cast.
1358         * tui/tui-source.c (tui_set_source_content)
1359         (tui_vertical_source_scroll): Remove unnecessary cast.
1360         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1361         cast.
1362         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1363         * tui/tui-regs.c (tui_display_registers_from)
1364         (tui_display_register): Remove unnecessary cast.
1365         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1366         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1367         (make_visible): Remove unnecessary cast.
1368         * tui/tui-winsource.c (tui_erase_source_content)
1369         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1370         unnecessary cast.
1371         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1372         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1373         * stabsread.c (read_type, read_array_type, read_range_type):
1374         Remove unnecessary cast.
1375         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1376         (parse_symbol, parse_type, upgrade_type, parse_external)
1377         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1378         unnecessary cast.
1379         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1380
1381 2019-06-16  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-data.c (tui_alloc_generic_win_info)
1384         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1385         checks.
1386
1387 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1388             Andrew Burgess  <andrew.burgess@embecosm.com>
1389
1390         * f-typeprint.c (f_print_type): Don't return early for not
1391         associated or not allocated types.
1392         (f_type_print_varspec_suffix): Add print_rank parameter and print
1393         ranks of array types in case they dangling.
1394         (f_type_print_base): Add print_rank parameter.
1395
1396 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1397
1398         * NEWS: Mention new MI commands.
1399         * break-catch-throw.c (enum exception_event_kind): Move to
1400         breakpoint.h.
1401         (print_mention_exception_catchpoint): Output text as a single
1402         message.
1403         (catch_exception_command_1): Rename to...
1404         (catch_exception_event): ...this, make non-static, update header
1405         command, and change some parameter types.
1406         (catch_catch_command): Update for changes to
1407         catch_exception_command_1.
1408         (catch_throw_command): Likewise.
1409         (catch_rethrow_command): Likewise.
1410         * breakpoint.c (enum exception_event_kind): Delete.
1411         * breakpoint.h (enum exception_event_kind): Moved here from
1412         break-catch-throw.c.
1413         (catch_exception_event): Declare.
1414         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1415         (mi_cmd_catch_throw): New function.
1416         (mi_cmd_catch_rethrow): New function.
1417         (mi_cmd_catch_catch): New function.
1418         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1419         'catch-catch' entries.
1420         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1421         (mi_cmd_catch_rethrow): Declare.
1422         (mi_cmd_catch_catch): Declare.
1423
1424 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1425
1426         * annotate.c (annotate_source_line): Change return type to void,
1427         update implementation to match.
1428         * annotate.h (annotate_source_line): Change return type to void,
1429         update header comment.
1430         * stack.c (print_frame_info): Don't change what frame information
1431         is printed based on whether annotations are on or not.
1432
1433 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1434
1435         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1436         (annotate_source): Make static.
1437         (annotate_source_line): Moved from source.c and renamed from
1438         identify_source_line.  Update the return type.
1439         * annotate.h (annotate_source): Delete declaration.
1440         (annotate_source_line): Declaration moved from source.h, and
1441         renamed from identify_source_line.  Return type updated.
1442         * source.c (identify_source_line): Moved to annotate.c and renamed
1443         to annotate_source_line.
1444         (info_line_command): Remove check of annotation_level.
1445         * source.h (identify_source_line): Move declaration to annotate.h
1446         and rename to annotate_source_line.
1447         * stack.c: Add 'annotate.h' include.
1448         (print_frame_info): Remove check of annotation_level before
1449         calling annotate_source_line.
1450
1451 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * source-cache.c (source_cache::get_plain_source_lines): Use
1454         open_source_file_with_line_charpos instead of just
1455         open_source_file, remove call to find_source_lines.
1456         (source_cache::get_source_lines): Likewise.
1457         * source.c (find_source_lines): Make static.
1458         (get_filename_and_charpos): Renamed into...
1459         (open_source_file_with_line_charpos): ..this along with changes to
1460         return a scoped_fd, and some other minor clean ups.
1461         (identify_source_line): Use open_source_file_with_line_charpos.
1462         (search_command_helper): Use open_source_file_with_line_charpos
1463         instead of just open_source_file, remove call to
1464         find_source_lines.
1465         * source.h (open_source_file_with_line_charpos): Declare new
1466         function.
1467         (find_source_lines): Delete declaration.
1468
1469 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1470
1471         * source.c (get_filename_and_charpos): Remove fullname
1472         parameter.
1473         (identify_source_line): Update call to get_filename_and_charpos.
1474
1475 2019-06-14  Tom Tromey  <tromey@adacore.com>
1476
1477         PR gdb/24502:
1478         * ui-style.h (skip_ansi_escape): Update comment.
1479         * ui-file.h (class no_terminal_escape_file): New class.
1480         * ui-file.c (no_terminal_escape_file::write)
1481         (no_terminal_escape_file::puts): New methods.
1482         * cli/cli-logging.c (handle_redirections): Use
1483         no_terminal_escape_file.
1484
1485 2019-06-14  Tom Tromey  <tromey@adacore.com>
1486
1487         * NEWS: Move convenience variable news above Python news.
1488
1489 2019-06-14  Tom Tromey  <tom@tromey.com>
1490
1491         * gnulib: Move directory to top-level.
1492         * configure.ac: Don't configure gnulib.
1493         * configure: Rebuild.
1494         * common/common-defs.h: Use new path to gnulib.
1495         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1496         (GNULIB_H): Remove.
1497         (INCGNU): Look in new gnulib location.
1498         (HFILES_NO_SRCDIR): Remove gnulib files.
1499         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1500         (generated_files): Remove GNULIB_H.
1501         ($(LIBGNU), all-lib): Remove targets.
1502         (distclean): Don't mention GNULIB_BUILDDIR.
1503         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1504
1505 2019-06-14  Tom Tromey  <tromey@adacore.com>
1506
1507         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1508         Warn if symbol file does not provide any symbols.
1509
1510 2019-06-14  Tom Tromey  <tromey@adacore.com>
1511
1512         * source.c (find_and_open_source): Respect basenames_may_differ.
1513
1514 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1515
1516         * annotate.c (annotate_breakpoints_invalid): Make use of
1517         scoped_restore_terminal_state.
1518         (annotate_frames_invalid): Likewise.
1519
1520 2019-06-14  Tom Tromey  <tromey@adacore.com>
1521
1522         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1523         allow assignment to an internalvar.
1524
1525 2019-06-14  Tom Tromey  <tromey@adacore.com>
1526
1527         * ada-lex.l: Allow "_" in attribute names.
1528
1529 2019-06-14  Tom Tromey  <tromey@adacore.com>
1530
1531         PR gdb/24653:
1532         * regcache.c (registers_changed): Don't call alloca.
1533         * top.c (execute_command): Don't call alloca.
1534
1535 2019-06-13  Pedro Alves  <palves@redhat.com>
1536
1537         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1538         'expression'.  When parsing an expression, error out if there's
1539         junk after "unlimited".
1540         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1541         (do_set_command): Adjust calls to is_unlimited_literal.
1542
1543 2019-06-13  Pedro Alves  <palves@redhat.com>
1544
1545         * compile/compile.c (make_compile_options_def_group): Add braces
1546         around array_view initializer.
1547         * thread.c (make_thread_apply_all_options_def_group)
1548         (make_thread_apply_all_options_def_group): Likewise.
1549
1550 2019-06-13  Pedro Alves  <palves@redhat.com>
1551
1552         * NEWS (New commands): Mention "maint test-options
1553         require-delimiter", "maint test-options unknown-is-error", "maint
1554         test-options unknown-is-operand" and "maint show
1555         test-options-completion-result".
1556         (New command options, command completion): New section.
1557         (Completion improvements): New section.
1558         Mention that you can abbreviate "unlimited".
1559
1560 2019-06-13  Pedro Alves  <palves@redhat.com>
1561
1562         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1563         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1564         * unittests/cli-utils-selftests.c (test_parse_flags)
1565         (test_parse_flags_qcs): Delete.
1566         (test_cli_utils): Don't call deleted functions.
1567
1568 2019-06-13  Pedro Alves  <palves@redhat.com>
1569
1570         * thread.c: Include "cli/cli-option.h".
1571         (tp_array_compar_ascending): Global.
1572         (tp_array_compar): Delete function.
1573         (tp_array_compar_ascending, tp_array_compar_descending): New
1574         functions.
1575         (ascending_option_def, qcs_flag_option_def)
1576         (thr_qcs_flags_option_defs)
1577         (make_thread_apply_all_options_def_group)
1578         (make_thread_apply_options_def_group): New.
1579         (thread_apply_all_command): Use gdb::option::process_options.
1580         (thread_apply_command_completer)
1581         (thread_apply_all_command_completer): New.
1582         (thread_apply_command): Use gdb::option::process_options.
1583         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1584         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1585         to generate help text of "thread apply".  Adjust "taas"'s help.
1586         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1587         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1588
1589 2019-06-13  Pedro Alves  <palves@redhat.com>
1590
1591         * thread.c (thread_apply_command): Check for invalid TID with
1592         isdigit instead of !isalpha.
1593
1594 2019-06-13  Pedro Alves  <palves@redhat.com>
1595
1596         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1597         (validate_flags_qcs): New.
1598         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1599         (validate_flags_qcs): Declare.
1600         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1601         (make_frame_apply_options_def_group): New.
1602         (frame_apply_command_count): Process options with
1603         gdb::option::process_options.
1604         (frame_apply_completer): New.
1605         (frame_apply_level_completer, frame_apply_all_completer)
1606         (frame_apply_completer): New.
1607         (_initialize_stack): Update help of "frame apply", "frame apply
1608         level", "frame apply all" and "faas" to mention supported options
1609         and install command completers.
1610         * stack.h (frame_apply_all_completer): Declare.
1611         * thread.c: Include "stack.h".
1612         (tfaas_command): Add "--".
1613         (_initialize_thread): Update help "tfaas" to mention supported
1614         options and install command completer.
1615
1616 2019-06-13  Pedro Alves  <palves@redhat.com>
1617
1618         * completer.c (complete_nested_command_line): New.
1619         (gdb_completion_word_break_characters_throw): Add assertion.
1620         * completer.h (complete_nested_command_line): Declare.
1621
1622 2019-06-13  Pedro Alves  <palves@redhat.com>
1623
1624         * stack.c (parse_backtrace_qualifiers): New.
1625         (backtrace_command): Use it.
1626         (backtrace_command_completer): Complete on qualifiers.
1627
1628 2019-06-13  Pedro Alves  <palves@redhat.com>
1629
1630         * frame.c: Include "cli/cli-option.h.
1631         (user_set_backtrace_options): New.
1632         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1633         Delete.
1634         (get_prev_frame): Adjust.
1635         (boolean_option_def, uinteger_option_def)
1636         (set_backtrace_option_defs): New.
1637         (_initialize_frame): Adjust and use
1638         gdb::option::add_setshow_cmds_for_options to install "set
1639         backtrace past-main" and "set backtrace past-entry".
1640         * frame.h: Include "cli/cli-option.h".
1641         (struct frame_print_options): Forward declare.
1642         (print_frame_arguments_all, print_frame_arguments_scalars)
1643         (print_frame_arguments_none): Declare.
1644         (print_entry_values): Delete declaration.
1645         (struct frame_print_options, user_frame_print_options): New.
1646         (struct set_backtrace_options): New.
1647         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1648         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1649         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1650         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1651         (list_args_or_locals): Add frame_print_options parameter.
1652         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1653         * python/py-framefilter.c (enumerate_args): Pass down
1654         USER_FRAME_PRINT_OPTIONS.
1655         * stack.c: Include "cli/cli-option.h".
1656         (print_frame_arguments_all, print_frame_arguments_scalars)
1657         (print_frame_arguments_none): Declare.
1658         (print_raw_frame_arguments, print_entry_values): Delete.
1659         (user_frame_print_options): New.
1660         (boolean_option_def, enum_option_def, frame_print_option_defs):
1661         New.
1662         (struct backtrace_cmd_options): New.
1663         (bt_flag_option_def): New.
1664         (backtrace_command_option_defs): New.
1665         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1666         (print_frame_arg, read_frame_arg, print_frame_args)
1667         (print_frame_info, print_frame): Add frame_print_options parameter
1668         and use it.
1669         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1670         (backtrace_command_1): Add frame_print_options and
1671         backtrace_cmd_options parameters and use them.
1672         (make_backtrace_options_def_group): New.
1673         (backtrace_command): Process command options with
1674         gdb::option::process_options.
1675         (backtrace_command_completer): New.
1676         (_initialize_stack): Extend "backtrace"'s help to mention
1677         supported options.  Install completer for "backtrace".
1678         Install some settings commands with add_setshow_cmds_for_options.
1679
1680 2019-06-13  Pedro Alves  <palves@redhat.com>
1681
1682         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1683         and that "set/show print raw frame-arguments" are now deprecated.
1684
1685         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1686         command.
1687         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1688         * stack.c (_initialize_stack): Install "set/show print
1689         raw-frame-arguments", and deprecate "set/show print raw
1690         frame-arguments".
1691         * valprint.c (_initialize_valprint): Deprecate "set/show print
1692         raw".
1693
1694 2019-06-13  Pedro Alves  <palves@redhat.com>
1695
1696         * compile/compile.c (struct compile_options): New.
1697         (compile_flag_option_def, compile_command_option_defs)
1698         (make_compile_options_def_group): New.
1699         (compile_file_command): Handle options with
1700         gdb::option::process_options.
1701         (compile_file_command_completer): New function.
1702         (compile_code_command): Handle options with
1703         gdb::option::process_options.
1704         (compile_code_command_completer): New function.
1705         (_initialize_compiler): Install completers for "compile code" and
1706         "compile file".  Mention available options in "compile code" and
1707         "compile code"'s help.
1708         * completer.c (advance_to_completion_word): New, factored out from
1709         ...
1710         (advance_to_expression_complete_word_point): ... this.
1711         (advance_to_filename_complete_word_point): New.
1712         * completer.h (advance_to_filename_complete_word_point): New
1713         declaration.
1714
1715 2019-06-13  Pedro Alves  <palves@redhat.com>
1716
1717         * compile/compile.c: Include "cli/cli-option.h".
1718         (compile_print_value): Scope data pointer is now a
1719         value_print_options pointer; adjust.
1720         (compile_print_command): Process options.  Scope data pointer is
1721         now a value_print_options pointer; adjust.
1722         (_initialize_compile): Update "compile print"'s help to include
1723         supported options.  Install a completer for "compile print".
1724         * cp-valprint.c (show_vtblprint, show_objectprint)
1725         (show_static_field_print): Delete.
1726         (_initialize_cp_valprint): Don't install "set print
1727         static-members", "set print vtbl", "set print object" here.
1728         * printcmd.c: Include "cli/cli-option.h" and
1729         "common/gdb_optional.h".
1730         (print_command_parse_format): Rework to fill in a
1731         value_print_options instead of a format_data.
1732         (print_value): Change parameter type from format_data pointer to
1733         value_print_options reference.  Adjust.
1734         (print_command_1): Process options.  Adjust to pass down a
1735         value_print_options.
1736         (print_command_completer): New.
1737         (_initialize_printcmd): Install print_command_completer as
1738         handle_brkchars completer for the "print" command.  Update
1739         "print"'s help to include supported options.
1740         * valprint.c: Include "cli/cli-option.h".
1741         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1742         here from cp-valprint.c.
1743         (boolean_option_def, uinteger_option_def)
1744         (value_print_option_defs, make_value_print_options_def_group):
1745         New.  Use gdb::option::add_setshow_cmds_for_options to install
1746         "set print elements", "set print null-stop", "set print repeats",
1747         "set print pretty", "set print union", "set print array", "set
1748         print address", "set print symbol", "set print array-indexes".
1749         * valprint.h: Include <string> and "cli/cli-option.h".
1750         (make_value_print_options_def_group): Declare.
1751         (print_value): Change parameter type from format_data pointer to
1752         value_print_options reference.
1753         (print_command_completer): Declare.
1754
1755 2019-06-13  Pedro Alves  <palves@redhat.com>
1756
1757         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1758         (COMMON_SFILES): Add maint-test-settings.c.
1759         * cli/cli-decode.c (boolean_enums): New global, factored out from
1760         ...
1761         (add_setshow_boolean_cmd): ... here.
1762         * cli/cli-decode.h (boolean_enums): Declare.
1763         * cli/cli-option.c: New file.
1764         * cli/cli-option.h: New file.
1765         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1766         factored out from ...
1767         (parse_cli_boolean_value(const char *)): ... this.
1768         (is_unlimited_literal): Change parameter type to pointer to
1769         pointer.  Adjust and advance ARG pointer.
1770         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1771         (parse_cli_var_enum): New, factored out from ...
1772         (do_set_command): ... this.  Adjust.
1773         * cli/cli-setshow.h (parse_cli_boolean_value)
1774         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1775         (parse_cli_var_enum): Declare.
1776         * cli/cli-utils.c: Include "cli/cli-option.h".
1777         (get_ulongest): New.
1778         * cli/cli-utils.h (get_ulongest): Declare.
1779         (check_for_argument): New overloads.
1780         * maint-test-options.c: New file.
1781
1782 2019-06-13  Pedro Alves  <palves@redhat.com>
1783
1784         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1785         parse a range if "-" is at the end of the string.
1786
1787 2019-06-13  Pedro Alves  <palves@redhat.com>
1788
1789         * cli/cli-setshow.c (parse_auto_binary_operation)
1790         (parse_cli_boolean_value): Don't allow "o".
1791
1792 2019-06-13  Pedro Alves  <palves@redhat.com>
1793
1794         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1795         * NEWS: Mention maint test-settings KIND.
1796         * maint-test-settings.c: New file.
1797
1798 2019-06-13  Pedro Alves  <palves@redhat.com>
1799
1800         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1801         completer.
1802         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1803         "set" completers.
1804
1805 2019-06-13  Pedro Alves  <palves@redhat.com>
1806
1807         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1808         after item.
1809
1810 2019-06-13  Pedro Alves  <palves@redhat.com>
1811
1812         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1813
1814 2019-06-13  Pedro Alves <palves@redhat.com>
1815
1816         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1817         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1818         call.
1819         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1820         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1821         calls.
1822         (check_for_argument): Skip spaces after argument.
1823
1824 2019-06-13  Pedro Alves  <palves@redhat.com>
1825
1826         * thread.c (thread_apply_command): Adjust TID parsing.
1827         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1828         detected before end of string.
1829         (tid_is_in_list): Error out if LIST is invalid.
1830
1831 2019-06-13  Pedro Alves  <palves@redhat.com>
1832
1833         * completer.c (complete_line_internal_1): Rewind completion word
1834         point.
1835         (completion_tracker::advance_custom_word_point_by): Change
1836         parameter type to int.
1837         * completer.h (completion_tracker::advance_custom_word_point_by):
1838         Likewise.
1839
1840 2019-06-13  Pedro Alves  <palves@redhat.com>
1841
1842         * completer.c (advance_to_completion_word): Handle delimiters.
1843
1844 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1845
1846         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1847
1848 2019-06-11  Tom Tromey  <tom@tromey.com>
1849
1850         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1851         (xmalloc_failed): Move to alloc.c.
1852         * alloc.c: New file.
1853         * Makefile.in (COMMON_SFILES): Add alloc.c.
1854
1855 2019-06-11  Tom Tromey  <tom@tromey.com>
1856
1857         * nat/linux-waitpid.c: Don't include server.h.
1858         (linux_debug): Remove.
1859         (my_waitpid): Update.
1860
1861 2019-06-11  Tom Tromey  <tromey@adacore.com>
1862
1863         * infcall.c (_initialize_infcall): Remove trailing newline from
1864         help.
1865         * user-regs.c (_initialize_user_regs): Remove trailing newline
1866         from help.
1867         * typeprint.c (_initialize_typeprint): Remove trailing newline
1868         from help.
1869         * reverse.c (_initialize_reverse): Remove trailing newlines from
1870         help.
1871         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1872         from help.
1873         * language.c (add_set_language_command): Remove trailing newline
1874         from help.
1875         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1876         help.
1877         * disasm.c (_initialize_disasm): Remove trailing newline from
1878         help.
1879         * top.c (init_main): Remove trailing newline from help.
1880         * interps.c (_initialize_interpreter): Remove trailing newline
1881         from help.
1882         * btrace.c (_initialize_btrace): Remove trailing newlines from
1883         help.
1884         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1885         from help.
1886         * python/python.c (_initialize_python): Remove trailing newline
1887         from help.
1888         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1889         help.
1890         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1891         from help.  Reformat some text.
1892         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1893         from help.
1894         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1895         newline from help.
1896
1897 2019-06-11  Tom Tromey  <tromey@adacore.com>
1898
1899         * darwin-nat.c (darwin_decode_exception_message)
1900         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1901
1902 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1903
1904         * valops.c (value_slice): Check for not allocated or not
1905         associated values.
1906
1907 2019-06-10  Tom de Vries  <tdevries@suse.de>
1908
1909         PR gdb/24618
1910         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1911         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1912         invalid.
1913
1914 2019-06-10  Tom de Vries  <tdevries@suse.de>
1915
1916         PR gdb/24611
1917         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1918         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1919
1920 2019-06-10  Tom de Vries  <tdevries@suse.de>
1921
1922         PR symtab/24545
1923         * symtab.c (struct demangled_name_entry): Add language field.
1924         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1925         static minimal symbol".  Set and use language field.
1926
1927 2019-06-10  Tom Tromey  <tromey@adacore.com>
1928
1929         * ada-lang.c (_initialize_ada_language): Update help text.
1930
1931 2019-06-10  Tom Tromey  <tromey@adacore.com>
1932
1933         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1934         with a newline.
1935         * guile/guile.c (handle_boot_error): Don't end warning with a
1936         newline.
1937         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1938         warning with a newline.
1939         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1940         newline.
1941         (s12z_frame_cache): Likewise.
1942         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1943         a newline.
1944         * solib-svr4.c (disable_probes_interface): Don't end warning with
1945         a newline.
1946         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1947         newline.
1948         * python/python.c (do_finish_initialization): Don't end warning
1949         with a newline.
1950
1951 2019-06-10  Tom Tromey  <tom@tromey.com>
1952
1953         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1954         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1955         gdbpy_enter.
1956
1957 2019-06-10  Tom Tromey  <tromey@adacore.com>
1958
1959         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1960         data.
1961         (elf_new_init): Don't call stabsread_new_init.
1962         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1963         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1964         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1965
1966 2019-06-10  Tom de Vries  <tdevries@suse.de>
1967
1968         PR symtab/16264
1969         PR symtab/24517
1970         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1971
1972 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1973
1974         * source.c (find_and_open_source): Also rewrite relative file
1975         names.
1976
1977 2019-04-26  Amos Bird  <amosbird@gmail.com>
1978
1979         * annotate.c (annotate_thread_exited): Add "thread-exited"
1980         annotation.
1981
1982 2019-06-06  Tom Tromey  <tromey@adacore.com>
1983
1984         * maint.h (class scoped_command_stats): Use
1985         DISABLE_COPY_AND_ASSIGN.
1986         <print_time>: New method.
1987         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1988         print_time.
1989         (scoped_command_stats::print_time): New method.
1990
1991 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1992
1993         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1994         instructions of lengths 6 or 8 bytes.
1995
1996 2019-06-04  Pedro Alves  <palves@redhat.com>
1997
1998         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1999
2000         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2001         * breakpoint.c (condition_completer): Likewise.
2002         * cli/cli-dump.c (scan_expression): Likewise.
2003         * common/filestuff.c (mkdir_recursive): Likewise.
2004         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2005         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2006         (gdb_abspath): Likewise.
2007         * compile/compile-cplus-types.c
2008         (compile_cplus_instance::decl_name): Likewise.
2009         * completer.c (complete_explicit_location):
2010         (signal_completer, reg_or_group_completer_1): Likewise.
2011         * cp-support.c (cp_remove_params_if_any): Likewise.
2012         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2013         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2014         * infcmd.c (strip_bg_char): Likewise.
2015         * linespec.c (copy_token_string): Likewise.
2016         * mi/mi-main.c (output_cores): Likewise.
2017         * psymtab.c (psymtab_search_name):
2018         * symfile.c (test_set_ext_lang_command): Likewise.
2019         * target.c (target_fileio_read_stralloc): Likewise.
2020         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2021         * value.c (complete_internalvar): Likewise.
2022
2023 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2024
2025         Add objfile property to gdb.Type.
2026         * NEWS: Mention Python API addition.
2027         * python/py-type.c (typy_get_objfile): New method.
2028
2029 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2030
2031         * NEWS: Mention the new set|show style [title|highlight].
2032         Mention changes to "show style", "help" and "apropos".
2033
2034 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2035
2036         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2037         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2038         instead of print_help_for_command.
2039         (print_doc_of_command): New function.
2040         (help_list): Add 'apropos -v word' suggestion.
2041         (print_help_for_command): Style the command name using title style.
2042         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2043         (_initialize_cli_cmds): Describe -v in apropos_command help.
2044
2045 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2046
2047         * cli/cli-style.h (cli_style_option): Add name in constructor,
2048         add m_name class member, add constructor with intensity,
2049         add name class function.
2050         (cli_style_option::add_setshow_commands): Remove name argument.
2051         (highlight_style, title_style): New styles.
2052         * cli/cli-style.c (do_show): New function that shows a style
2053         characteristic styling the style name with itself.
2054         (set_style_name): New function.
2055         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2056         Update all callers according to the changes in cli/cli-style.h.
2057         * utils.h (fputs_highlighted): New function.
2058         * utils.c (fputs_highlighted): Likewise.
2059
2060 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2061
2062         * NEWS: Mention new pipe command and new convenience variables.
2063
2064 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2065
2066         * cli/cli-cmds.c (pipe_command): New function.
2067         (_initialize_cli_cmds): Call add_com for pipe_command.
2068         Define | as an alias for pipe.
2069         (exit_status_set_internal_vars): New function.
2070         (shell_escape): Call exit_status_set_internal_vars.
2071         cli/cli-decode.c (find_command_name_length): Recognize | as
2072         a single character command.
2073
2074 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2075
2076         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2077         top.c (execute_command_to_ui_file): New function, mostly a copy
2078         of execute_command_to_string.
2079         (execute_command_to_string): Implement by calling
2080         execute_command_to_ui_file.
2081
2082 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2083
2084         * top.h (saved_command_line): Remove declaration.
2085         * top.c (previous_saved_command_line, previous_repeat_arguments):
2086         New variables.
2087         (saved_command_line): Make static, define together with other
2088         'repeat variables'.
2089         (dont_repeat): Clear repeat_arguments.
2090         (repeat_previous, get_saved_command_line, save_command_line):
2091         New functions.
2092         (gdb_init): Initialize saved_command_line
2093         and previous_saved_command_line.
2094         * main.c (captured_main_1): Remove saved_command_line initialization.
2095         * event-top.c (handle_line_of_input): Update to use
2096         the new 'repeat' related functions instead of direct access to
2097         saved_command_line.
2098         * command.h (repeat_previous, get_saved_command_line,
2099         save_command_line): New declarations.
2100         (dont_repeat): Add comment.
2101
2102 2019-05-30  Tom Tromey  <tromey@adacore.com>
2103
2104         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2105         Fix comment.
2106         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2107
2108 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2109
2110         PR cli/24587
2111         * completer.c (complete): Initialize variable word.
2112
2113 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2114
2115         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2116         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2117         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2118         'body' is NULL to the outter 'if', protecting the '!is_define'
2119         situation as well.
2120
2121 2019-05-29  Tom Tromey  <tromey@adacore.com>
2122
2123         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2124         (dwarf_unknown): New function.
2125         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2126         (dwarf_type_encoding_name): Use dwarf_unknown.
2127
2128 2019-05-29  Tom Tromey  <tromey@adacore.com>
2129
2130         PR c++/20020:
2131         * cp-valprint.c (cp_print_value_fields): Call
2132         cp_print_static_field inside "try".
2133
2134 2019-05-29  Tom Tromey  <tromey@adacore.com>
2135
2136         * inflow.c (struct terminal_info): Add default operator=.
2137         * configure: Rebuild.
2138         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2139         -Wdeprecated-copy-dtor, -Wredundant-move.
2140
2141 2019-05-29  Tom Tromey  <tromey@adacore.com>
2142
2143         * NEWS: Add entry.
2144         * infcmd.c (print_return_value_1): Handle finish_print
2145         option.
2146         (show_print_finish): New function.
2147         (_initialize_infcmd): Add "set/show print finish" commands.
2148         * valprint.c (user_print_options): Initialize new member.
2149         * valprint.h (struct value_print_options) <finish_print>: New
2150         member.
2151
2152 2019-05-28  Tom Tromey  <tromey@adacore.com>
2153
2154         * ada-lang.c (ada_remove_Xbn_suffix)
2155         (find_old_style_renaming_symbol)
2156         (parse_old_style_renaming): Remove.
2157         (ada_find_renaming_symbol): Don't call
2158         find_old_style_renaming_symbol.
2159         (ada_is_renaming_symbol): Rename from
2160         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2161         bool.  Now static.
2162         (ada_read_var_value): Update and simplify.
2163         * ada-exp.y (write_var_or_type): Remove old code.
2164
2165 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2166
2167         * event-top.c: Remove include comment.
2168         * inflow.c (class scoped_ignore_sigttou): Move from here...
2169         * inflow.h (class scoped_ignore_sigttou): ...to here.
2170         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2171         * top.c:  Remove include comment.
2172
2173 2019-05-27  Tom Tromey  <tom@tromey.com>
2174
2175         * NEWS: Fix typo.
2176
2177 2019-05-22  Tom Tromey  <tromey@adacore.com>
2178
2179         * target.c (target_follow_exec): Constify parameter.
2180         * target-delegates.c: Rebuild.
2181         * remote.c (remote_target::follow_exec): Constify parameter.
2182         * infrun.c (follow_exec): Constify parameter.
2183         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2184         (target_follow_exec): Likewise.
2185
2186 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2187
2188         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2189         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2190
2191 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2192
2193         * NEWS: Add debugredirect and testsuite sections.
2194
2195 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2196
2197         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2198         target descriptions using exclusively floating point register name
2199         aliases.
2200
2201 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         PR gdb/18644:
2204         * f-lang.c (build_fortran_types): Handle the case where
2205         gdbarch_floatformat_for_type returns a nullptr.
2206
2207 2019-05-21  Tom de Vries  <tdevries@suse.de>
2208
2209         PR cli/24587
2210         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2211
2212 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2213
2214         PR gdb/18644:
2215         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2216         16-byte floats.
2217         * i386-tdep.c (i386_floatformat_for_type): Use
2218         floatformats_ia64_quad for the 16-byte floating point component
2219         within a fortran 32-byte complex number.
2220
2221 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2222
2223         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2224         delete default constructor.
2225         (find_partial_die): Update to return const struct.
2226         (partial_die_parent_scope): Move variable declaration into scope
2227         of its use and change its type to auto.
2228         (guess_partial_die_structure_name): Likewise.
2229         (partial_die_info::fixup): Likewise.
2230
2231 2019-05-17  Tom Tromey  <tromey@adacore.com>
2232
2233         * source.c (find_and_open_source): Remove cast.
2234
2235 2019-05-17  Tom Tromey  <tromey@adacore.com>
2236
2237         * annotate.c (annotate_source): Make "filename" const.
2238         * annotate.h (annotate_source): Use const.
2239
2240 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2241
2242         * disasm.c (set_disassembler_options): Send errors to stderr.
2243
2244 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2245
2246         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2247         (cli_interp_base::set_logging): Check debug_redirect.
2248         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2249         * cli/cli-logging.c (debug_redirect): Add static variable.
2250         (pop_output_files): Add default param.
2251         (handle_redirections): Print debug setting.
2252         (show_logging_command): Likewise.
2253         (_initialize_cli_logging): Add debugredirect command.
2254         * interps.c (current_interp_set_logging): Add debug_redirect
2255         parameter.
2256         * interps.h (set_logging): Add debug_redirect parameter.
2257         (current_interp_set_logging): Likewise.
2258         * mi/mi-common.h: Likewise.
2259         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2260
2261 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2262             Tom Tromey  <tromey@adacore.com>
2263
2264         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2265         directly.
2266         * cli/cli-interp.h (make_logging_output): Remove declaration.
2267         * cli/cli-logging.c (make_logging_output): Remove function.
2268         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2269         directly.
2270         * ui-file.c (tee_file::tee_file): Remove bools.
2271         (tee_file::~tee_file): Remove deletes.
2272         * ui-file.h (tee_file): Remove bools.
2273
2274 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2275
2276         * mi/mi-cmds.h (mi_cmd_complete): New function.
2277         * mi/mi-main.c (mi_cmd_complete): Likewise.
2278         * mi/mi-cmds.c: Define new MI command -complete.
2279         * NEWS: Mention new -complete command.
2280
2281 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2282
2283         * completer.h (complete): New function.
2284         * completer.c (complete): Likewise.
2285         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2286         function defined in completer.h.
2287
2288 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2289
2290         * MAINTAINERS (Write After Approval): Add myself.
2291
2292 2019-05-17  Tom de Vries  <tdevries@suse.de>
2293
2294         PR gdb/24094
2295         * dwarf2read.c (struct cu_partial_die_info): New struct.
2296         (find_partial_die): Return cu_partial_die_info.
2297         (partial_die_parent_scope, guess_partial_die_structure_name)
2298         (partial_die_info::fixup): Handle new return type of find_partial_die.
2299
2300 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2301
2302         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2303         "std::string", simplifying the algorithm.
2304
2305 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2306
2307         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2308         (stap_static_probe_ops::get_probes): Likewise.
2309
2310 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2311
2312         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2313         '-')" and "else if".
2314         (stap_parse_single_operand): Join checks for
2315         "gdbarch_stap_parse_special_token_p" and
2316         "gdbarch_stap_parse_special_token" in the same "if" statement.
2317         Invert check when verifying for operation on register
2318         displacement.
2319
2320 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2321
2322         * stap-probe.c (stap_get_opcode): Update comment.
2323         (stap_get_expected_argument_type): Likewise.
2324         (handle_stap_probe): Likewise.
2325
2326 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2327
2328         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2329         return type to 'bool'.  Adjust comment.  Use 'bool' when
2330         appropriate.
2331         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2332         * stap-probe.c (stap_parse_argument_1): Likewise.
2333         (stap_is_operator): Likewise.
2334         (stap_is_generic_prefix): Likewise.
2335         (stap_is_register_prefix): Likewise.
2336         (stap_is_register_indirection_prefix): Likewise.
2337         (stap_is_integer_prefix): Likewise.
2338         (stap_generic_check_suffix): Likewise.
2339         (stap_check_integer_suffix): Likewise.
2340         (stap_check_register_suffix): Likewise.
2341         (stap_check_register_indirection_suffix): Likewise.
2342         (stap_parse_register_operand): Likewise.
2343         (stap_parse_single_operand): Likewise.
2344         (stap_parse_argument_1): Likewise.
2345         (stap_probe::get_argument_count): Likewise.
2346         (stap_is_operator): Likewise.
2347
2348 2019-05-16  Tom Tromey  <tromey@adacore.com>
2349
2350         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2351         keyword to foreach.
2352
2353 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2354
2355         * linux-thread-db.c (try_thread_db_load_1): Change return type
2356         to bool.
2357         (try_thread_db_load): Likewise.
2358         (try_thread_db_load_from_pdir_1): Likewise.
2359         (try_thread_db_load_from_pdir): Likewise.
2360         (try_thread_db_load_from_sdir): Likewise.
2361         (try_thread_db_load_from_dir): Likewise.
2362         (thread_db_load_search): Likewise.
2363         (has_libpthread): Likewise.
2364         (thread_db_load): Likewise.
2365
2366 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2367
2368         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2369         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2370         NULL, and complain/return if that's the case.
2371
2372 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2373
2374         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2375         (advance, posn, abstract_read_memory): New functions.
2376         [struct mem_read_abstraction]: New struct.
2377         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2378
2379 2019-05-14  Tom Tromey  <tromey@adacore.com>
2380
2381         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2382         value is not lval_memory.
2383
2384 2019-05-14  Tom Tromey  <tromey@adacore.com>
2385
2386         * solib.c (info_sharedlibrary_command): Style the file name.
2387
2388 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2389
2390         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2391         (aarch64_vnv_type): Likewise.
2392         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2393         * common/tdesc.c: Likewise.
2394         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2395         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2396         * features/aarch64-fpu.xml: Add ieee half view.
2397         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2398         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2399         * gdbtypes.h (struct builtin_type): Likewise.
2400         (struct objfile_type): Likewise.
2401
2402 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2403
2404         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2405         typo.
2406         * location.h (string_to_event_location): Likewise.
2407
2408 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2409
2410         GDB 8.3 released.
2411
2412 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2413
2414         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2415         New variable declaration.
2416         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2417         New variable.
2418         (print_one_breakpoint): Use ui_out::test_flags and new global
2419         variable to compute use_fixed_output.
2420         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2421         Remove.
2422         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2423         (mi_multi_location_breakpoint_output_fixed): Remove.
2424         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2425         new variable.
2426         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2427         fix_multi_location_breakpoint_output flag if version >= 3.
2428         * ui-out.h (enum ui_out_flag)
2429         <fix_multi_location_breakpoint_output>: New enumerator.
2430
2431 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2432
2433         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2434
2435 2019-05-10  Tom Tromey  <tromey@adacore.com>
2436
2437         * ada-lang.c (catch_ada_completer): New function.
2438         (_initialize_ada_language): Use it.
2439
2440 2019-05-10  Tom Tromey  <tromey@adacore.com>
2441
2442         * thread.c (print_thread_info): Make "requested_threads" const.
2443         * gdbthread.h (print_thread_info): Make "requested_threads"
2444         const.
2445         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2446         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2447
2448 2019-05-08  Tom Tromey  <tom@tromey.com>
2449
2450         * gdbtypes.c (objfile_type_data): Change type.
2451         (objfile_type, _initialize_gdbtypes): Update.
2452
2453 2019-05-08  Tom Tromey  <tom@tromey.com>
2454
2455         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2456         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2457         (_initialize_dwarf2_frame): Update.
2458
2459 2019-05-08  Tom Tromey  <tom@tromey.com>
2460
2461         * objc-lang.c (objc_objfile_data): Change type.
2462         (find_methods): Update.
2463         (_initialize_objc_lang): Remove.
2464
2465 2019-05-08  Tom Tromey  <tom@tromey.com>
2466
2467         * stabsread.c (rs6000_builtin_type_data): Change type.
2468         (rs6000_builtin_type, _initialize_stabsread): Update.
2469
2470 2019-05-08  Tom Tromey  <tom@tromey.com>
2471
2472         * mips-tdep.c (mips_pdr_data): Remove.
2473         (_initialize_mips_tdep): Update.
2474
2475 2019-05-08  Tom Tromey  <tom@tromey.com>
2476
2477         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2478         (hppa_init_objfile_priv_data, read_unwind_info)
2479         (find_unwind_entry, _initialize_hppa_tdep): Update.
2480
2481 2019-05-08  Tom Tromey  <tom@tromey.com>
2482
2483         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2484         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2485         on obstack.
2486         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2487
2488 2019-05-08  Tom Tromey  <tom@tromey.com>
2489
2490         * mdebugread.c (basic_type_data): Change type.
2491         (basic_type, _initialize_mdebugread): Update.
2492
2493 2019-05-08  Tom Tromey  <tom@tromey.com>
2494
2495         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2496
2497 2019-05-08  Tom Tromey  <tom@tromey.com>
2498
2499         * nto-tdep.c (nto_inferior_data_reg): Change type.
2500         (nto_inferior_data): Update.
2501         (nto_inferior_data_cleanup, nto_new_inferior_data)
2502         (_initialize_nto_tdep): Remove.
2503         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2504
2505 2019-05-08  Tom Tromey  <tom@tromey.com>
2506
2507         * ada-lang.c (struct ada_inferior_data): Add initializers.
2508         (ada_inferior_data): Change type.
2509         (ada_inferior_data_cleanup): Remove.
2510         (get_ada_inferior_data, ada_inferior_exit)
2511         (struct ada_pspace_data): Add initializers, destructor.
2512         (ada_pspace_data_handle): Change type.
2513         (get_ada_pspace_data): Update.
2514         (ada_pspace_data_cleanup): Remove.
2515
2516 2019-05-08  Tom Tromey  <tom@tromey.com>
2517
2518         * coffread.c (struct coff_symfile_info): Add initializers.
2519         (coff_objfile_data_key): Move lower.  Change type.
2520         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2521         Update.
2522         (coff_free_info): Remove.
2523
2524 2019-05-08  Tom Tromey  <tom@tromey.com>
2525
2526         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2527         (fbsd_pspace_data_handle): Move lower.  Change type.
2528         (get_fbsd_pspace_data): Update.
2529         (fbsd_pspace_data_cleanup): Remove.
2530         (_initialize_fbsd_tdep): Update.
2531
2532 2019-05-08  Tom Tromey  <tom@tromey.com>
2533
2534         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2535         (get_ada_tasks_pspace_data): Update.
2536         (ada_tasks_pspace_data_cleanup): Remove.
2537         (_initialize_tasks): Update.
2538         (ada_tasks_inferior_data_handle): Change type.
2539         (get_ada_tasks_inferior_data): Update.
2540         (ada_tasks_inferior_data_cleanup): Remove.
2541         (struct ada_tasks_pspace_data): Add initializers.
2542
2543 2019-05-08  Tom Tromey  <tom@tromey.com>
2544
2545         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2546         * symfile-debug.c (debug_sym_get_probes): Change type.
2547         * stap-probe.c (handle_stap_probe):
2548         (stap_static_probe_ops::get_probes): Change type.
2549         * probe.h (class static_probe_ops) <get_probes>: Change type.
2550         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2551         (parse_probes_in_pspace): Update.
2552         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2553         Update.
2554         (any_static_probe_ops::get_probes): Change type.
2555         * elfread.c (elfread_data): New typedef.
2556         (probe_key): Change type.
2557         (elf_get_probes): Likewise.  Update.
2558         (probe_key_free): Remove.
2559         (_initialize_elfread): Update.
2560         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2561         Change type.
2562         (dtrace_process_dof_probe, dtrace_process_dof)
2563         (dtrace_static_probe_ops::get_probe): Change type.
2564
2565 2019-05-08  Tom Tromey  <tom@tromey.com>
2566
2567         * xcoffread.c (struct xcoff_symfile_info): Rename from
2568         coff_symfile_info.  Add initializers.
2569         (xcoff_objfile_data_key): Move lower.  Change type.
2570         (XCOFF_DATA): Rewrite.
2571         (xcoff_free_info): Remove.
2572         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2573         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2574         (xcoff_initial_scan): Update.
2575
2576 2019-05-08  Tom Tromey  <tom@tromey.com>
2577
2578         * solib-svr4.c (struct svr4_info): Add initializers and
2579         destructor.
2580         <probes_table>: Now an htab_up.
2581         (solib_svr4_pspace_data): Change type.
2582         (free_probes_table): Simplify.
2583         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2584         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2585         (probes_table_remove_objfile_probes, register_solib_event_probe)
2586         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2587         (_initialize_svr4_solib): Update.
2588
2589 2019-05-08  Tom Tromey  <tom@tromey.com>
2590
2591         * remote.c (remote_pspace_data): Change type.
2592         (remote_pspace_data_cleanup): Remove.
2593         (get_remote_exec_file, set_pspace_remote_exec_file)
2594         (_initialize_remote): Update.
2595
2596 2019-05-08  Tom Tromey  <tom@tromey.com>
2597
2598         * breakpoint.c (breakpoint_objfile_key): Change type.
2599         (get_breakpoint_objfile_data): Update.
2600         (free_breakpoint_objfile_data): Remove.
2601         (_initialize_breakpoint): Update.
2602
2603 2019-05-08  Tom Tromey  <tom@tromey.com>
2604
2605         * linux-tdep.c (struct linux_info): Add initializers.
2606         (linux_inferior_data): Move.  Change type.
2607         (invalidate_linux_cache_inf): Update.
2608         (linux_inferior_data_cleanup): Remove.
2609         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2610
2611 2019-05-08  Tom Tromey  <tom@tromey.com>
2612
2613         * auxv.c (auxv_inferior_data): Move.  Change type.
2614         (auxv_inferior_data_cleanup): Remove.
2615         (invalidate_auxv_cache_inf): Rewrite.
2616         (get_auxv_inferior_data, _initialize_auxv): Update.
2617
2618 2019-05-08  Tom Tromey  <tom@tromey.com>
2619
2620         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2621         (symfile_debug_objfile_data_key): Change type.
2622         (symfile_debug_installed, debug_qf_has_symbols)
2623         (debug_qf_find_last_source_symtab)
2624         (debug_qf_forget_cached_source_info)
2625         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2626         (debug_qf_print_stats, debug_qf_dump)
2627         (debug_qf_expand_symtabs_for_function)
2628         (debug_qf_expand_all_symtabs)
2629         (debug_qf_expand_symtabs_with_fullname)
2630         (debug_qf_map_matching_symbols)
2631         (debug_qf_expand_symtabs_matching)
2632         (debug_qf_find_pc_sect_compunit_symtab)
2633         (debug_qf_map_symbol_filenames)
2634         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2635         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2636         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2637         (debug_sym_read_linetable, debug_sym_relocate): Update.
2638         (symfile_debug_free_objfile): Remove.
2639         (install_symfile_debug_logging, _initialize_symfile_debug):
2640         Update.
2641
2642 2019-05-08  Tom Tromey  <tom@tromey.com>
2643
2644         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2645         allocate_on_obstack.
2646         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2647         (get_dwarf2_per_objfile): Update.
2648         (set_dwarf2_per_objfile): Remove.
2649         (dwarf2_has_info, dwarf2_get_section_info): Update.
2650         (dwarf2_free_objfile): Remove.
2651         (_initialize_dwarf2_read): Update.
2652
2653 2019-05-08  Tom Tromey  <tom@tromey.com>
2654
2655         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2656         initializers.
2657         <unsupported_script_warning_printed,
2658         script_not_found_warning_printed>: Now bool.
2659         (auto_load_pspace_data): Change type.
2660         (~auto_load_pspace_info): Rename from
2661         auto_load_pspace_data_cleanup.
2662         (get_auto_load_pspace_data, init_loaded_scripts_info)
2663         (clear_section_scripts, maybe_print_unsupported_script_warning)
2664         (maybe_print_script_not_found_warning, _initialize_auto_load):
2665         Update.
2666
2667 2019-05-08  Tom Tromey  <tom@tromey.com>
2668
2669         * objfiles.c (objfile_pspace_info): Add destructor and
2670         initializers.
2671         (objfiles_pspace_data): Change type.
2672         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2673         (get_objfile_pspace_data): Update.
2674         (objfiles_bfd_data): Change type.
2675         (get_objfile_bfd_data): Update.
2676         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2677
2678 2019-05-08  Tom Tromey  <tom@tromey.com>
2679
2680         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2681         Change type.
2682         (get_catch_syscall_inferior_data): Update.
2683         (catch_syscall_inferior_data_cleanup): Remove.
2684         (_initialize_break_catch_syscall): Update.
2685
2686 2019-05-08  Tom Tromey  <tom@tromey.com>
2687
2688         * inflow.c (struct terminal_info): Add destructor and
2689         initializers.
2690         (inflow_inferior_data): Change type.
2691         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2692         (get_inflow_inferior_data, inflow_inferior_exit)
2693         (swap_terminal_info, _initialize_inflow): Update.
2694
2695 2019-05-08  Tom Tromey  <tom@tromey.com>
2696
2697         * target-dcache.c (target_dcache_cleanup): Remove.
2698         (target_dcache_aspace_key): Change type.
2699         (target_dcache_init_p, target_dcache_invalidate)
2700         (target_dcache_get, target_dcache_get_or_init)
2701         (_initialize_target_dcache): Update.
2702         * dcache.h (struct dcache_deleter): New.
2703
2704 2019-05-08  Tom Tromey  <tom@tromey.com>
2705
2706         * symtab.c (struct symbol_cache): Add destructor and
2707         initializers.
2708         (symbol_cache_key): Move.  Change type.
2709         (make_symbol_cache, free_symbol_cache): Remove.
2710         (get_symbol_cache): Update.
2711         (symbol_cache_cleanup): Remove.
2712         (ALL_PSPACES, symbol_cache_flush)
2713         (maintenance_print_symbol_cache)
2714         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2715         Update.
2716
2717 2019-05-08  Tom Tromey  <tom@tromey.com>
2718
2719         * symtab.c (struct main_info): Add destructor and initializers.
2720         (main_progspace_key): Move.  Change type.
2721         (get_main_info): Update.
2722         (main_info_cleanup): Remove.
2723         (_initialize_symtab): Update.
2724
2725 2019-05-08  Tom Tromey  <tom@tromey.com>
2726
2727         * registry.h (DECLARE_REGISTRY): Define the _key class.
2728
2729 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2730
2731         * NEWS: Merge two 'New commands' sections.
2732
2733 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2734
2735         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2736         parameter and use Ada language definition instead.
2737         (ada_val_print_ptr): Remove unused language parameter.
2738         (ada_val_print_num): Remove language parameter and use Ada language
2739         definition instead.
2740         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2741         parameter.
2742         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2743         parameter and use Ada language definition instead.
2744         (ada_val_print_1): Update all ada_val_print_xxx calls.
2745         Remove language parameter.
2746         (ada_val_print): Update ada_val_print_1 call.
2747
2748 2019-05-08  Tom Tromey  <tromey@adacore.com>
2749
2750         * remote.c (remote_hw_watchpoint_limit)
2751         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2752         Now static.
2753
2754 2019-05-08  Tom Tromey  <tromey@adacore.com>
2755
2756         * maint.c (_initialize_maint_cmds): Move initialization code to
2757         remote.c.
2758         (watchdog, show_watchdog): Move to remote.c.
2759         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2760         "watchdog" static.
2761         (_initialize_remote): Move initialization code from maint.c.
2762         * defs.h (watchdog): Don't declare.
2763
2764 2019-05-08  Tom Tromey  <tromey@adacore.com>
2765
2766         * tui/tui-interp.c: Include main.h.
2767         * interps.c: Include main.h.
2768         * main.h (interpreter_p): Declare.
2769         * defs.h (interpreter_p): Don't declare.
2770
2771 2019-05-08  Tom Tromey  <tromey@adacore.com>
2772
2773         * dwarf2loc.c: Include dwarf2read.h.
2774         * defs.h (read_unsigned_leb128): Don't declare.
2775         * dwarf2read.h (read_unsigned_leb128): Declare.
2776
2777 2019-05-08  Tom Tromey  <tromey@adacore.com>
2778
2779         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2780         method.
2781
2782 2019-05-08  Tom Tromey  <tromey@adacore.com>
2783
2784         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2785         when no wrap column is set.
2786
2787 2019-05-08  Tom Tromey  <tromey@adacore.com>
2788
2789         * c-lang.c (c_get_string): Handle non-C-style arrays.
2790
2791 2019-05-08  Tom Tromey  <tromey@adacore.com>
2792
2793         * typeprint.c (print_offset_data::update): Print the bit offset,
2794         not the number of bits remaining.
2795
2796 2019-05-08  Tom Tromey  <tromey@adacore.com>
2797
2798         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2799         padding at end of comment.
2800
2801 2019-05-08  Tom Tromey  <tromey@adacore.com>
2802
2803         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2804         Compare main types.
2805
2806 2019-05-06  Tom Tromey  <tom@tromey.com>
2807
2808         * common/scoped_mmap.c: Include common-defs.h.
2809         * common/scoped_mmap.h: Don't include config.h.
2810
2811 2019-05-04  Tom Tromey  <tom@tromey.com>
2812
2813         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2814         (struct aarch64_call_info): Add initializers.
2815         <si>: Now a std::vector.
2816         (pass_on_stack, aarch64_push_dummy_call): Update.
2817
2818 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2819             Tom Tromey  <tom@tromey.com>
2820
2821         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2822         (ppc_threads): Now a std::vector.  Now static.
2823         (hwdebug_find_thread_points_by_tid)
2824         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2825         Update.
2826
2827 2019-05-04  Tom Tromey  <tom@tromey.com>
2828
2829         * arc-tdep.c (arc_tdesc_init): Return bool.
2830
2831 2019-05-04  Tom Tromey  <tom@tromey.com>
2832
2833         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2834         Use gdb_assert_not_reached.
2835
2836 2019-05-04  Tom Tromey  <tom@tromey.com>
2837
2838         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2839         "false".
2840
2841 2019-05-04  Tom Tromey  <tom@tromey.com>
2842
2843         * arc-tdep.c (arc_tdesc_init): Use bool.
2844
2845 2019-05-04  Tom Tromey  <tom@tromey.com>
2846
2847         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2848
2849 2019-05-04  Tom Tromey  <tom@tromey.com>
2850
2851         * cli/cli-cmds.c (valid_command_p): Return bool.
2852
2853 2019-05-04  Tom Tromey  <tom@tromey.com>
2854
2855         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2856         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2857
2858 2019-05-04  Raul Tambre  <raul@tambre.ee>
2859
2860         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2861         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2862         operator for comparison.
2863
2864 2019-05-04  Tom Tromey  <tom@tromey.com>
2865
2866         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2867         (lookup_partial_symbol, print_partial_symbols)
2868         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2869         (psymbol_compare): Update.
2870         (add_psymbol_to_bcache): Clear the entire psymbol.
2871         (maintenance_check_psymtabs): Update.
2872         * psympriv.h (struct partial_symbol): Don't derive from
2873         general_symbol_info.
2874         <obj_section, unrelocated_address, address,
2875         set_unrelocated_address>: Update.
2876         <ginfo>: New member.
2877         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2878         (debug_names::write_psymbols): Update.
2879
2880 2019-05-04  Tom de Vries  <tdevries@suse.de>
2881
2882         * contrib/cc-with-tweaks.sh: Support -n arg.
2883
2884 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2885
2886         * corelow.c (core_target::detach): Ensure frame cache and
2887         register caches are cleared.
2888         inferior.c (exit_inferior_1): Likewise.
2889
2890 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2891             Tom Tromey  <tom@tromey.com>
2892
2893         * dictionary.c (collate_pending_symbols_by_language): Remove
2894         "struct" from foreach.
2895         * symtab.c (lookup_global_symbol_from_objfile)
2896         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2897         foreach.
2898         * ser-tcp.c (net_open): Remove "struct" from foreach.
2899         * objfiles.c (objfile_relocate, objfile_rebase)
2900         (objfile_has_symbols): Remove "struct" from foreach.
2901         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2902         from foreach.
2903         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2904         foreach.
2905         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2906         "struct" from foreach.
2907         * ada-lang.c (create_excep_cond_exprs)
2908         (ada_exception_catchpoint_cond_string): Remove "struct" from
2909         foreach.
2910
2911 2019-05-03  Tom Tromey  <tromey@adacore.com>
2912
2913         * ada-exp.y (convert_char_literal): Check suffix of each
2914         enumerator.
2915
2916 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2917
2918         PR ada/21406:
2919         * ada-exp.y (yywrap): Don't define.
2920         * ada-lex.l (%option): Add noyywrap
2921         (yywrap): Remove.
2922
2923 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2924
2925         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2926         _WIN32_WINNT to the XP level, unless already defined to a higher
2927         level.
2928
2929         * unittests/parse-connection-spec-selftests.c:
2930         * ser-tcp.c:
2931         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2932         override.
2933
2934         * symfile.c (find_separate_debug_file): Remove colon from the
2935         drive spec of DOS/Windows file names of the target, so that the
2936         file name produced from DEBUGDIR and the target's directory will
2937         be valid on DOS/Windows systems.
2938
2939 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * rust-lang.c (val_print_struct): Handle printing structures
2942         containing strings.
2943
2944 2019-05-02  Tom Tromey  <tromey@adacore.com>
2945
2946         * valarith.c (_initialize_valarith): Remove.
2947
2948 2019-05-01  Tom Tromey  <tromey@adacore.com>
2949
2950         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2951         bitfields.
2952
2953 2019-05-01  Tom Tromey  <tromey@adacore.com>
2954
2955         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2956         for big-endian copies.
2957
2958 2019-04-30  Ali Tamur  <tamur@google.com>
2959         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2960         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2961         (read_3_bytes): New function.
2962
2963 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2964
2965         * windows-nat.c (main_thread_id): Delete.
2966         (handle_output_debug_string): Replace main_thread_id by
2967         current_event.dwThreadId.
2968         (fake_create_process): Likewise.
2969         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2970         Do not set main_thread_id.
2971         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2972         current_event.dwThreadId.
2973         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2974
2975 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2976
2977         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2978         Use current_event.dwThreadId instead of main_thread_id.
2979
2980 2019-04-30  Tom Tromey  <tromey@adacore.com>
2981
2982         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2983         (create_excep_cond_exprs): Iterate over program spaces.
2984         (ada_exception_catchpoint_cond_string): Examine all minimal
2985         symbols for exception types.
2986
2987 2019-04-30  Tom Tromey  <tromey@adacore.com>
2988
2989         PR c++/24470:
2990         * dwarf2read.c (process_structure_scope): Handle case where type
2991         has template parameters but no symbol was created.
2992
2993 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2994             Chris January  <chris.january@arm.com>
2995
2996         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2997         qualifier.
2998         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2999
3000 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * f-typeprint.c (f_print_type): Update rules for printing
3003         whitespace.
3004         (f_type_print_varspec_suffix): Likewise.
3005
3006 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3007             Chris January  <chris.january@arm.com>
3008
3009         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3010         function arguments.
3011
3012 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * f-lang.c (build_fortran_types): Change name of void type to
3015         lower case.
3016         * f-typeprint.c (f_type_print_base): Print the name of the void
3017         type, rather than a fixed string.
3018         * f-valprint.c (f_decorations): Use lower case void string.
3019
3020 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3021             Chris January  <chris.january@arm.com>
3022
3023         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3024         types for Fortran.
3025
3026 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3027             Chris January  <chris.january@arm.com>
3028             David Lecomber  <david.lecomber@arm.com>
3029
3030         * f-exp.y (BINOP_INTRINSIC): New token.
3031         (exp): New parser rule handling BINOP_INTRINSIC.
3032         (f77_keywords): Add new builtin procedures.
3033         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3034         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3035         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3036         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3037         (print_unop_subexp_f): New function.
3038         (print_binop_subexp_f): New function.
3039         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3040         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3041         (dump_subexp_body_f): Likewise.
3042         (operator_check_f): Likewise.
3043         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3044         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3045
3046 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3047
3048         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3049         UNOP_KIND.
3050         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3051         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3052         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3053         (operator_length_f): New fuction.
3054         (print_subexp_f): New function.
3055         (op_name_f): New function.
3056         (dump_subexp_body_f): New function.
3057         (operator_check_f): New function.
3058         (exp_descriptor_f): Replace standard expression handling functions
3059         with new functions.
3060         * gdb/fortran-operator.def: New file.
3061         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3062         * gdb/std-operator.def: Remove UNOP_KIND.
3063
3064 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3065
3066         * std-operator.def: Remove unbalanced, stray double quote
3067         character.
3068
3069 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3070             Chris January  <chris.january@arm.com>
3071             Daniel Everett  <daniel.everett@arm.com>
3072             Nick Forrington  <nick.forrington@arm.com>
3073             Richard Bunt  <richard.bunt@arm.com>
3074
3075         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3076         of depth when printing anonymous structs or unions.
3077         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3078         Don't print either the top-level value, or the children if the
3079         max-depth is exceeded.
3080         (ppscm_print_children): When printing the key of a map, allow one
3081         extra level of depth.
3082         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3083         print either the top-level value, or the children if the max-depth
3084         is exceeded.
3085         (print_children): When printing the key of a map, allow one extra
3086         level of depth.
3087         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3088         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3089         (user_print_options): Initialise max_depth field.
3090         (val_print_scalar_or_string_type_p): New function.
3091         (val_print): Check to see if the max depth has been reached.
3092         (val_print_check_max_depth): Define new function.
3093         (show_print_max_depth): New function.
3094         (_initialize_valprint): Add 'print max-depth' option.
3095         * valprint.h (struct value_print_options) <max_depth>: New field.
3096         (val_print_check_max_depth): Declare new function.
3097         * NEWS: Document new feature.
3098
3099 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * ada-lang.c (ada_language_defn): Initialise new field.
3102         * c-lang.c (c_is_string_type_p): New function.
3103         (c_language_defn): Initialise new field.
3104         (cplus_language_defn): Initialise new field.
3105         (asm_language_defn): Initialise new field.
3106         (minimal_language_defn): Initialise new field.
3107         * c-lang.h (c_is_string_type_p): Declare new function.
3108         * d-lang.c (d_language_defn): Initialise new field.
3109         * f-lang.c (f_is_string_type_p): New function.
3110         (f_language_defn): Initialise new field.
3111         * go-lang.c (go_is_string_type_p): New function.
3112         (go_language_defn): Initialise new field.
3113         * language.c (default_is_string_type_p): New function.
3114         (unknown_language_defn): Initialise new field.
3115         (auto_language_defn): Initialise new field.
3116         * language.h (struct language_defn) <la_is_string_type_p>: New
3117         member variable.
3118         (default_is_string_type_p): Declare new function.
3119         * m2-lang.c (m2_language_defn): Initialise new field.
3120         * objc-lang.c (objc_language_defn): Initialise new field.
3121         * opencl-lang.c (opencl_language_defn): Initialise new field.
3122         * p-lang.c (pascal_is_string_type_p): New function.
3123         (pascal_language_defn): Initialise new field.
3124         * rust-lang.c (rust_is_string_type_p): New function.
3125         (rust_language_defn): Initialise new field.
3126
3127 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3128
3129         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3130         New field.
3131         * ada-lang.c (ada_language_defn): Initialise new field.
3132         * c-lang.c (c_language_defn): Likewise.
3133         (cplus_language_defn): Likewise.
3134         (asm_language_defn): Likewise.
3135         (minimal_language_defn): Likewise.
3136         * d-lang.c (d_language_defn): Likewise.
3137         * f-lang.c (f_language_defn): Likewise.
3138         * go-lang.c (go_language_defn): Likewise.
3139         * language.c (unknown_language_defn): Likewise.
3140         (auto_language_defn): Likewise.
3141         * m2-lang.c (m2_language_defn): Likewise.
3142         * objc-lang.c (objc_language_defn): Likewise.
3143         * opencl-lang.c (opencl_language_defn): Likewise.
3144         * p-lang.c (pascal_language_defn): Likewise.
3145         * rust-lang.c (rust_language_defn): Likewise.
3146
3147 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3148
3149         * ada-lang.c (ada_is_character_type): Change return type to bool.
3150         (ada_is_string_type): Likewise.
3151         * ada-lang.h (ada_is_character_type): Update declaration
3152         (ada_is_string_type): Likewise.
3153
3154 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3155
3156         Support style in 'frame|thread apply'
3157
3158         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3159         * record.c (record_start, record_stop): Update callers of
3160         execute_command_to_string with false.
3161         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3162         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3163         methods.
3164         (class string_file): New constructor with term_out parameter.
3165         Override methods term_out and can_emit_style_escape.  New member
3166         term_out.
3167         (class stdio_file): Override can_emit_style_escape.
3168         (class tee_file): Override term_out and can_emit_style_escape.
3169         * utils.h (can_emit_style_escape): Remove.
3170         * utils.c (can_emit_style_escape): Likewise.
3171         Update all callers of can_emit_style_escape (SOMESTREAM) to
3172         SOMESTREAM->can_emit_style_escape.
3173         * source-cache.c (source_cache::get_source_lines): Likewise.
3174         * stack.c (frame_apply_command_count): Call execute_command_to_string
3175         passing the term_out characteristic of the current gdb_stdout.
3176         * thread.c (thr_try_catch_cmd): Likewise.
3177         * top.c (execute_command_to_string): pass term_out parameter
3178         to construct the string_file for the command output.
3179         * ui-file.c (term_cli_styling): New function (most code moved
3180         from utils.c can_emit_style_escape).
3181         (string_file::string_file, string_file::can_emit_style_escape,
3182         stdio_file::can_emit_style_escape, tee_file::term_out,
3183         tee_file::can_emit_style_escape): New functions.
3184
3185 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3186
3187         * NEWS: Mention the new set|show may-call-functions.
3188         * infcall.c (may_call_functions_p): New variable.
3189         (show_may_call_functions_p): New function.
3190         (call_function_by_hand_dummy): Throws an error if not
3191         may-call-functions.
3192         (_initialize_infcall): Call add_setshow_boolean_cmd for
3193         may-call-functions.
3194
3195 2019-04-25  Keith Seitz  <keiths@redhat.com>
3196
3197         PR c++/24367
3198         * cp-support.c (inspect_type): Don't attempt substitutions
3199         of symbol with the same name.
3200
3201 2019-04-25  Tom Tromey  <tromey@adacore.com>
3202
3203         PR gdb/24475:
3204         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3205         static.
3206
3207 2019-04-25  Tom Tromey  <tromey@adacore.com>
3208
3209         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3210         rvalue reference.
3211         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3212         (gdb_xml_parser::parse): Use std::move.
3213         * python/python-internal.h (gdbpy_convert_exception): Take a const
3214         reference.
3215         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3216         std::move.
3217         * python/py-utils.c (gdbpy_convert_exception): Take a const
3218         reference.
3219         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3220         Use std::move.
3221         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3222         Use std::move.
3223         * mi/mi-main.c (mi_print_exception): Take a const reference.
3224         * main.c (handle_command_errors): Take a const reference.
3225         * linespec.c (parse_linespec): Use std::move.
3226         * infcall.c (run_inferior_call): Use std::move.
3227         (call_function_by_hand_dummy): Use std::move.
3228         * exec.c (try_open_exec_file): Use std::move.
3229         * exceptions.h (exception_print, exception_fprintf)
3230         (exception_print_same): Update.
3231         * exceptions.c (print_exception, exception_print)
3232         (exception_fprintf, exception_print_same): Change parameters to
3233         const reference.
3234         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3235         * common/new-op.c: Use std::move.
3236         * common/common-exceptions.h (struct gdb_exception): Add move
3237         constructor.
3238         (struct gdb_exception_error, struct gdb_exception_quit, struct
3239         gdb_quit_bad_alloc): Change constructor to move constructor.
3240         (throw_exception): Change parameter to rvalue reference.
3241         * common/common-exceptions.c (throw_exception): Take rvalue
3242         reference.
3243         * cli/cli-interp.c (safe_execute_command): Use std::move.
3244         * breakpoint.c (insert_bp_location, location_to_sals): Use
3245         std::move.
3246
3247 2019-04-25  Tom Tromey  <tromey@adacore.com>
3248
3249         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3250         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3251         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3252         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3253         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3254         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3255         guile/scm-value.c: Use unpack.
3256         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3257         gdbscm_gdb_exception.
3258         (gdbscm_throw_gdb_exception): Likewise.
3259         (struct gdbscm_gdb_exception): New.
3260         (unpack): New function.
3261         (gdbscm_wrap): Use unpack.
3262
3263 2019-04-25  Tom Tromey  <tromey@adacore.com>
3264
3265         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3266         (gdb_rl_callback_handler): Use std::move.
3267         * common/common-exceptions.h (struct gdb_exception): Add move
3268         assignment operator.
3269         (throw_exception_sjlj): Change "exception" to const reference.
3270         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3271         (throw_exception_sjlj): Change "exception" to const reference.
3272
3273 2019-04-25  Tom Tromey  <tromey@adacore.com>
3274
3275         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3276         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3277         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3278         Update.
3279         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3280         Update.
3281         * mi/mi-interp.c (mi_interp::exec): Update.
3282         * linespec.c (parse_linespec): Update.
3283         * infcall.c (run_inferior_call): Update.
3284         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3285         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3286         (gdbscm_lookup_global_symbol): Update.
3287         * guile/scm-param.c (gdbscm_parameter_value): Update.
3288         * guile/scm-frame.c (gdbscm_frame_read_register)
3289         (gdbscm_frame_read_var): Update.
3290         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3291         * exec.c (try_open_exec_file): Update.
3292         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3293         (gdb_rl_callback_handler): Update.
3294         * common/common-exceptions.h (exception_none): Don't declare.
3295         * common/common-exceptions.c (exception_none): Don't define.
3296         (struct catcher) <exception>: Update.
3297         * cli/cli-interp.c (safe_execute_command): Update.
3298         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3299
3300 2019-04-25  Ali Tamur  <tamur@google.com>
3301
3302         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3303         (read_attribute_value): Likewise.
3304         (dwarf2_read_addr_index): Update comment.
3305         (read_str_index): Add DW_FORM_strx.
3306         (dwarf2_string_attr): Likewise.
3307         (dwarf2_const_value_attr): Likewise.
3308         (dump_die_shallow): Likewise.
3309         (dwarf2_fetch_constant_bytes): Likewise.
3310         (skip_form_bytes): Likewise.
3311         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3312
3313 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3314
3315         PR corefiles/11608
3316         PR corefiles/18187
3317         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3318         OFFSET.  Verify if current mapping contains an ELF header.
3319         (linux_find_memory_regions_full): Adjust call to
3320         dump_mapping_p.
3321
3322 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3323             Kang Li <kanglictf@gmail.com>
3324
3325         PR gdb/21600
3326
3327         * dwarf2-frame.c (read_initial_length): Be consistent about using
3328         unsigned representation of length.
3329         (decode_frame_entry_1): Likewise.  Check for wraparound of
3330         end pointer as well as buffer overflow.
3331
3332 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3333
3334         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3335         "vq".
3336
3337 2019-04-24  Tom Tromey  <tromey@adacore.com>
3338
3339         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3340
3341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3342
3343         * s12z-tdep.c (s12z_unwind_pc): Delete.
3344         (s12z_unwind_sp): Delete.
3345         (s12z_gdbarch_init): Don't register deleted functions with
3346         gdbarch.
3347
3348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3349
3350         * rl78-tdep.c (rl78_unwind_sp): Delete.
3351         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3352
3353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3354
3355         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3356         (xstormy16_unwind_pc): Delete.
3357         (xstormy16_dummy_id): Delete.
3358         (xstormy16_gdbarch_init): Don't register deleted functions with
3359         gdbarch.
3360
3361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3362
3363         * vax-tdep.c (vax_unwind_pc): Delete.
3364         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3365
3366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3367
3368         * v850-tdep.c (v850_unwind_sp): Delete.
3369         (v850_unwind_pc): Delete.
3370         (v850_dummy_id): Delete.
3371         (v850_gdbarch_init): Don't register deleted functions with
3372         gdbarch.
3373
3374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3375
3376         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3377         (tilegx_unwind_pc): Delete.
3378         (tilegx_unwind_dummy_id): Delete.
3379         (tilegx_gdbarch_init): Don't register deleted functions with
3380         gdbarch.
3381
3382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3383
3384         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3385         (tic6x_dummy_id): Delete.
3386         (tic6x_gdbarch_init): Don't register deleted functions with
3387         gdbarch.
3388
3389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3390
3391         * sparc-tdep.c (sparc_unwind_pc): Delete.
3392         (sparc32_gdbarch_init): Don't register deleted function with
3393         gdbarch.
3394
3395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3396
3397         * sh-tdep.c (sh_unwind_sp): Delete.
3398         (sh_unwind_pc): Delete.
3399         (sh_dummy_id): Delete.
3400         (sh_gdbarch_init): Don't register deleted functions with
3401         gdbarch.
3402
3403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3404
3405         * score-tdep.c (score_unwind_sp): Delete.
3406         (score_unwind_pc): Delete.
3407         (score_dummy_id): Delete.
3408         (score_gdbarch_init): Don't register deleted functions with
3409         gdbarch.
3410
3411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3412
3413         * rx-tdep.c (rx_unwind_pc): Delete.
3414         (rx_unwind_sp): Delete.
3415         (rx_dummy_id): Delete.
3416         (rx_gdbarch_init): Don't register deleted functions with
3417         gdbarch.  Update comment.
3418
3419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3420
3421         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3422         (rs6000_dummy_id): Delete.
3423         (rs6000_gdbarch_init): Don't register deleted functions with
3424         gdbarch.
3425
3426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3427
3428         * or1k-tdep.c (or1k_dummy_id): Delete.
3429         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3430
3431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3432
3433         * nios2-tdep.c (nios2_dummy_id): Delete.
3434         (nios2_unwind_sp): Delete.
3435         (nios2_gdbarch_init): Don't register deleted functions with
3436         gdbarch.
3437
3438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3439
3440         * nds32-tdep.c (nds32_dummy_id): Delete.
3441         (nds32_unwind_pc): Delete.
3442         (nds32_unwind_sp): Delete.
3443         (nds32_gdbarch_init): Don't register deleted functions with
3444         gdbarch.
3445
3446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3447
3448         * msp430-tdep.c (msp430_unwind_pc): Delete.
3449         (msp430_unwind_sp): Delete.
3450         (msp430_dummy_id): Delete.
3451         (msp430_gdbarch_init): Don't register deleted functions with
3452         gdbarch.
3453
3454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3455
3456         * moxie-tdep.c (moxie_unwind_sp): Delete.
3457         (moxie_unwind_pc): Delete.
3458         (moxie_dummy_id): Delete.
3459         (moxie_gdbarch_init): Don't register deleted functions with
3460         gdbarch.
3461
3462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3465         (mn10300_unwind_pc): Delete.
3466         (mn10300_unwind_sp): Delete.
3467         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3468         mn10300_unwind_sp.
3469         (mn10300_frame_unwind_init): Don't register deleted functions with
3470         gdbarch.
3471
3472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         * mep-tdep.c (mep_unwind_pc): Delete.
3475         (mep_unwind_sp): Delete.
3476         (mep_dummy_id): Delete.
3477         (mep_gdbarch_init): Don't register deleted functions with
3478         gdbarch.
3479
3480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3481
3482         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3483         (m68hc11_unwind_sp): Delete.
3484         (m68hc11_gdbarch_init): Don't register deleted functions with
3485         gdbarch.
3486
3487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3488
3489         * m32r-tdep.c (m32r_unwind_sp): Delete.
3490         (m32r_unwind_pc): Delete.
3491         (m32r_dummy_id): Delete.
3492         (m32r_gdbarch_init): Don't register deleted functions with
3493         gdbarch.
3494
3495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3496
3497         * m32c-tdep.c (m32c_unwind_pc): Delete.
3498         (m32c_unwind_sp): Delete.
3499         (m32c_dummy_id): Delete.
3500         (m32c_gdbarch_init): Don't register deleted functions with
3501         gdbarch.
3502
3503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3504
3505         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3506         (lm32_unwind_pc): Delete.
3507         (lm32_dummy_id): Delete.
3508         (lm32_gdbarch_init): Don't register deleted functions with
3509         gdbarch.
3510
3511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3512
3513         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3514         (iq2000_unwind_pc): Delete.
3515         (iq2000_dummy_id): Delete.
3516         (iq2000_gdbarch_init): Don't register deleted functions with
3517         gdbarch.
3518
3519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3520
3521         * nds32-tdep.c (nds32_type_align): Delete.
3522         (nds32_push_dummy_call): Use type_align instead.
3523
3524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3525
3526         * arm-tdep.c (arm_type_align): Only handle vector override case.
3527         (arm_push_dummy_call): Use type_align.
3528         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3529
3530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3531
3532         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3533         case.
3534         (pass_on_stack): Use type_align.
3535         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3536         function.
3537
3538 2019-04-23  Tom Tromey  <tromey@adacore.com>
3539
3540         * dwarf2read.c (line_header::file_name_at): Remove unused
3541         overload.
3542
3543 2019-04-23  Tom de Vries  <tdevries@suse.de>
3544
3545         PR gdb/24438
3546         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3547         invocation.
3548
3549
3550 2019-03-27  Ali Tamur  <tamur@google.com>
3551
3552         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3553         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3554         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3555         (dwarf_expr_context::get_addr_index): Likewise
3556         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3557         (symbol_needs_eval_context::get_addr_index): Likewise
3558         (disassemble_dwarf_expression): Add DW_OP_addrx
3559         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3560         (read_cutu_die_from_dwo): Update comment
3561         (skip_one_die): Add DW_FORM_addrx
3562         (read_attribute_value): Likewise
3563         (var_decode_location): Add DW_OP_addrx
3564         (dwarf2_const_value_attr): Add DW_FORM_addrx
3565         (dump_die_shallow): Likewise
3566         (dwarf2_fetch_constant_bytes): Likewise
3567         (decode_locdesc): Add DW_OP_addrx
3568         (skip_form_bytes): Add DW_FORM_addrx
3569
3570 2019-04-22  Ali Tamur  <tamur@google.com>
3571
3572         * MAINTAINERS (Write After Approval): Add self.
3573
3574 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3575
3576         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3577         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3578         (open_symbol_file_object): Likewise.
3579         (svr4_default_sos): Add info parameter.
3580         (svr4_read_so_list): Likewise.
3581         (svr4_current_sos_direct): Adjust functions calls to pass down
3582         info.
3583         (svr4_current_sos_1): Add info parameter.
3584         (svr4_current_sos): Call get_svr4_info, pass info down to
3585         svr4_current_sos_1.
3586         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3587         get_svr4_info.
3588         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3589         get_svr4_info.
3590         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3591         to get_svr4_info.
3592         (probes_table_remove_objfile_probes): Likewise.
3593         (register_solib_event_probe): Add info parameter.
3594         (solist_update_incremental): Pass info parameter down to
3595         svr4_read_so_list.
3596         (disable_probes_interface): Add info parameter.
3597         (svr4_handle_solib_event): Pass current_program_space to
3598         get_svr4_info.  Adjust disable_probes_interface cleanup.
3599         (svr4_create_probe_breakpoints): Add info parameter, pass it
3600         down to register_solib_event_probe.
3601         (svr4_create_solib_event_breakpoints): Add info parameter,
3602         pass it down to svr4_create_probe_breakpoints.
3603         (enable_break): Pass info down to
3604         svr4_create_solib_event_breakpoints.
3605         (svr4_solib_create_inferior_hook): Pass current_program_space to
3606         get_svr4_info.
3607         (svr4_clear_solib): Likewise.
3608
3609 2019-04-22  Pedro Alves  <palves@redhat.com>
3610
3611         * solib-svr4.c (svr4_free_objfile_observer): New.
3612         (probe_and_action::objfile): New field.
3613         (probes_table_htab_remove_objfile_probes)
3614         (probes_table_remove_objfile_probes): New functions.
3615         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3616         in the new probe_and_action.  Don't store the probe in 'lookup'.
3617         (svr4_create_probe_breakpoints): Pass objfile to
3618         register_solib_event_probe.
3619         (_initialize_svr4_solib): Register a free_objfile observer.
3620
3621 2019-04-19  Tom Tromey  <tom@tromey.com>
3622
3623         * common/queue.h: Remove.
3624
3625 2019-04-19  Tom Tromey  <tom@tromey.com>
3626
3627         * event-loop.c: Don't include "common/queue.h".
3628
3629 2019-04-19  Tom Tromey  <tom@tromey.com>
3630
3631         * remote.c (remote_target): Use delete.
3632         * remote-notif.h: Include <list>, not "common/queue.h".
3633         (notif_client_p): Remove typedef.
3634         (remote_notif_state): Add constructor, destructor, initializer.
3635         <notif_queue>: Now a std::list.
3636         (remote_notif_state_xfree): Don't declare.
3637         * remote-notif.c (remote_notif_process, handle_notification)
3638         (remote_notif_state_allocate): Update.
3639         (~remote_notif_state): Rename from remote_notif_state_xfree.
3640
3641 2019-04-19  Tom Tromey  <tom@tromey.com>
3642
3643         * symfile.c (reread_symbols): Update.
3644         * objfiles.c (objfile_register_static_link)
3645         (objfile_lookup_static_link): Update
3646         (~objfile) Don't delete static_links.
3647         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3648
3649 2019-04-19  Tom Tromey  <tom@tromey.com>
3650
3651         * type-stack.h (struct type_stack) <insert>: Constify string.
3652         * type-stack.c (type_stack::insert): Constify string.
3653         * gdbtypes.h (lookup_template_type): Update.
3654         (address_space_name_to_int): Update.
3655         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3656         const.
3657         (lookup_template_type): Make name const.
3658         * c-exp.y: Update rules.
3659         (lex_one_token, classify_name, classify_inner_name)
3660         (c_print_token): Update.
3661         * p-exp.y: Update rules.
3662         (yylex): Update.
3663         * f-exp.y: Update rules.
3664         (yylex): Update.
3665         * d-exp.y: Update rules.
3666         (lex_one_token, classify_name, classify_inner_name): Update.
3667         * parse.c (write_dollar_variable, copy_name): Return std::string.
3668         * parser-defs.h (copy_name): Change return type.
3669         * m2-exp.y: Update rules.
3670         (yylex): Update.
3671         * go-exp.y (lex_one_token): Update.
3672         Update rules.
3673         (classify_unsafe_function, classify_packaged_name)
3674         (classify_name, yylex): Update.
3675
3676 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3677
3678         * configure.ac: add --enable-source-highlight switch.
3679         * configure: Regenerate.
3680         * top.c (print_gdb_version): plumb --enable-source-highlight
3681         status to "show configuration".
3682
3683 2019-04-19  Tom Tromey  <tromey@adacore.com>
3684
3685         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3686         Check ADA_TYPE_P.
3687         (empty_record, ada_template_to_fixed_record_type_1)
3688         (template_to_static_fixed_type)
3689         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3690         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3691         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3692         macros.
3693
3694 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3695
3696         PR symtab/24423:
3697         * source.c (print_source_lines_base): Advance "iter" when a
3698         control character is seen.
3699
3700 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3701
3702         * inferior.h (struct infcall_suspend_state_deleter):
3703         Catch exception in destructor to avoid crash.
3704
3705 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3706
3707         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3708         close to the add_com "shell".
3709
3710 2019-04-18  Tom Tromey  <tromey@adacore.com>
3711
3712         * process-stratum-target.h (class process_stratum_target)
3713         <stratum>: Add "final".
3714
3715 2019-04-17  Tom Tromey  <tromey@adacore.com>
3716
3717         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3718         against nullptr before use.
3719
3720 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3721
3722         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3723
3724 2019-04-17  Jim Wilson  <jimw@sifive.com>
3725             Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3728         code read might fail, assume 4-byte breakpoint in that case.
3729
3730 2019-04-15  Leszek Swirski  <leszeks@google.com>
3731
3732         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3733         rather than a hand-rolled POD check when checking for forced MEMORY
3734         classification.
3735
3736 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3737
3738         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3739         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3740         function.
3741         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3742         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3743         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3744         declaration.
3745
3746 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3747
3748         * aarch64-linux-nat.c
3749         (aarch64_linux_nat_target::thread_architecture): Add override.
3750         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3751         each VQ.
3752
3753 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3754
3755         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3756
3757 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3760         target types of size 96-bits, add some additional comments, and
3761         check that the builtin type we found was the correct size.
3762
3763 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3764
3765         * utils.c (prompt_for_continue): Don't restore the styling at the
3766         end, as applied_style has the wrong value.  This fixes styling in
3767         long lists of file names that are interrupted by the "Continue?"
3768         prompt.
3769
3770 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3773         * c-lang.c (c_language_defn): Likewise.
3774         (cplus_language_defn): Likewise.
3775         (asm_language_defn): Likewise.
3776         (minimal_language_defn): Likewise.
3777         * d-lang.c (d_language_defn): Likewise.
3778         * f-lang.c (f_language_defn): Likewise.
3779         * go-lang.c (go_language_defn): Likewise.
3780         * language.c (unknown_language_defn): Likewise.
3781         (auto_language_defn): Likewise.
3782         * language.h (struct language_defn): Remove la_magic field.
3783         (LANG_MAGIC): Delete.
3784         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3785         * objc-lang.c (objc_language_defn): Likewise.
3786         * opencl-lang.c (opencl_language_defn): Likewise.
3787         * p-lang.c (pascal_language_defn): Likewise.
3788         * rust-lang.c (rust_language_defn): Likewise.
3789
3790 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * riscv-tdep.c (riscv_type_align): New function.
3793         (riscv_type_alignment): Delete.
3794         (riscv_arg_location): Use 'type_align'.
3795         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3796
3797 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * gdbtypes.c (type_align): A struct with no non-static fields also
3800         has alignment of 1.
3801
3802 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3803
3804         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3805         component to 0.
3806         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3807         member.
3808         (riscv_struct_info::analyse): New implementation using new
3809         analyse_inner member function.
3810         (riscv_struct_info::field_offset): New member function.
3811         (riscv_struct_info::m_offsets): New member variable.
3812         (riscv_struct_info::analyse_inner): New private member function,
3813         takes the old implementation of riscv_struct_info::analyse but
3814         extended to track field offsets.
3815         (riscv_call_arg_struct): Update the struct folding special cases
3816         to handle cases where empty C++ structs, which are non-zero
3817         length, are found.
3818         (riscv_arg_location): Initialise the length of each location, a
3819         non-zero length now indicates the location is in use.
3820         (riscv_push_dummy_call): Allow for the first location having a
3821         non-zero offset when setting up arguments.
3822         (riscv_return_value): Likewise, but for return values.
3823
3824 2019-04-11  Tom Tromey  <tromey@adacore.com>
3825
3826         * utils.c (internal_vproblem): Make "msg" const.
3827
3828 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3829
3830         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3831         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3832         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3833         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3834
3835 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3836
3837         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3838         function.
3839         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3840         of amd64_collect_native_gregset.
3841         (amd64_linux_nat_target::store_registers): Likewise.
3842
3843 2019-04-10  Tom Tromey  <tom@tromey.com>
3844
3845         * symtab.c (lookup_global_symbol_from_objfile)
3846         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3847         * objfiles.h (class separate_debug_iterator): New.
3848         (class separate_debug_range): New.
3849         (struct objfile) <separate_debug_objfiles>: New method.
3850         (objfile_separate_debug_iterate): Don't declare.
3851         * objfiles.c (separate_debug_iterator::operator++): Rename from
3852         objfile_separate_debug_iterate.
3853         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3854         iterator.
3855         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3856         iterator.
3857
3858 2019-04-10  Tom Tromey  <tom@tromey.com>
3859
3860         * symfile.c (reread_symbols): Remove old comment.
3861         * objfiles.c (free_all_objfiles): Fix a typo.
3862
3863 2019-04-10  Tom Tromey  <tom@tromey.com>
3864
3865         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3866         * minsyms.c (lookup_minimal_symbol): Use foreach.
3867         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3868         (lookup_minimal_symbol_solib_trampoline): Likewise.
3869         * symfile.c (reread_symbols): Use foreach.
3870
3871 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3872             Tom Tromey  <tromey@adacore.com>
3873
3874         PR rust/24414:
3875         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3876         (rust_lex_int_test): Change "value" to be LONGEST.
3877         (rust_lex_tests): Add test for long integer literal.
3878
3879 2019-04-09  Tom Tromey  <tromey@adacore.com>
3880
3881         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3882         to bool.
3883         (extended_remote_target::attach): Update.
3884         (remote_target::remote_notice_new_inferior): Update.
3885         (remote_target::add_current_inferior_and_thread): Update.
3886         * inferior.c (exit_inferior_1): Use "false".
3887         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3888
3889 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3890
3891         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3892         the "start" command.
3893
3894 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3895
3896         * python/py-inferior.c (infpy_thread_from_thread_handle):
3897         Adjust comments to reflect renaming of thread_from_thread_handle
3898         to thread_from_handle.  Adjust keywords.  Fix type error message.
3899         (inferior_object_methods): Add thread_from_handle.  Retain
3900         thread_from_thread_handle, but mark it as deprecated.
3901
3902 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3903
3904         * gdbthread.h (find_thread_by_handle): Revise declaration.
3905         * thread.c (find_thread_by_handle): Likewise.  Adjust
3906         implementation too.
3907         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3908         support for buffer objects as handles.
3909
3910 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3911
3912         * python/py-infthread.c (thpy_thread_handle): New function.
3913         (thread_object_methods): Register thpy_thread_handle.
3914
3915 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3916
3917         * gdbthread.h (thread_to_thread_handle): Declare.
3918         * thread.c (gdbtypes.h): Include.
3919         (thread_to_thread_handle): New function.
3920
3921         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3922         (target_thread_info_to_thread_handle): Declare.
3923         * target.c (target_thread_info_to_thread_handle): New function.
3924         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3925         * target-delegates.c: Regenerate.
3926
3927         * linux-thread-db.c (class thread_db_target): Add method
3928         thread_info_to_thread_handle.
3929         (thread_db_target::thread_info_to_thread_handle): Define.
3930         * remote.c (class remote_target): Add new method
3931         thread_info_to_thread_handle.
3932         (remote_target::thread_info_to_thread_handle): Define.
3933
3934 2019-04-08  Pedro Alves  <palves@redhat.com>
3935
3936         * common/common-exceptions.c (throw_exception): Don't create
3937         named object to throw; throw directly.
3938         (throw_it): Likewise.  Don't initialize gdb_exception::message
3939         here, with new; pass FMT and AP to the ctor instead.
3940         * common/common-exceptions.h: Include <string>.
3941         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3942         const char *, va_list)): New ctor.  Use std::make_shared.
3943         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3944         errors)): Delete.
3945         (gdb_exception_error::gdb_exception_error(enum errors, const char
3946         *, va_list)): New.
3947         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3948         Add assertion.
3949         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3950         errors)): Delete.
3951         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3952         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3953         Add assertion.
3954
3955 2019-04-08  Tom Tromey  <tom@tromey.com>
3956
3957         * valops.c (value_rtti_indirect_type): Replace throw_exception
3958         with throw.
3959         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3960         with throw.
3961         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3962         throw.
3963         * target.c (target_translate_tls_address): Replace throw_exception
3964         with throw.
3965         * stack.c (frame_apply_command_count): Replace throw_exception
3966         with throw.
3967         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3968         throw.
3969         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3970         with throw.
3971         * rs6000-tdep.c (rs6000_frame_cache)
3972         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3973         * remote.c: Replace throw_exception with throw.
3974         * record-full.c (record_full_message, record_full_wait_1)
3975         (record_full_restore): Replace throw_exception with throw.
3976         * record-btrace.c:
3977         (get_thread_current_frame_id, record_btrace_start_replaying)
3978         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3979         (cmd_record_btrace_start): Replace throw_exception with throw.
3980         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3981         throw.
3982         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3983         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3984         * linespec.c:
3985         (find_linespec_symbols): Replace throw_exception with throw.
3986         * infrun.c (displaced_step_prepare, resume): Replace
3987         throw_exception with throw.
3988         * infcmd.c (post_create_inferior): Replace throw_exception with
3989         throw.
3990         * inf-loop.c (inferior_event_handler): Replace throw_exception
3991         with throw.
3992         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3993         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3994         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3995         (get_prev_frame_always, get_frame_pc_if_available)
3996         (get_frame_address_in_block_if_available, get_frame_language):
3997         Replace throw_exception with throw.
3998         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3999         throw_exception with throw.
4000         * eval.c (fetch_subexp_value, evaluate_var_value)
4001         (evaluate_funcall, evaluate_subexp_standard): Replace
4002         throw_exception with throw.
4003         * dwarf2loc.c (call_site_find_chain)
4004         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4005         Replace throw_exception with throw.
4006         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4007         with throw.
4008         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4009         throw.
4010         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4011         * completer.c (complete_line_internal): Replace throw_exception
4012         with throw.
4013         * compile/compile-object-run.c (compile_object_run): Replace
4014         throw_exception with throw.
4015         * cli/cli-script.c (process_next_line): Replace throw_exception
4016         with throw.
4017         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4018         (btrace_enable, btrace_maint_update_pt_packets): Replace
4019         throw_exception with throw.
4020         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4021         throw_exception with throw.
4022         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4023         throw_exception with throw.
4024         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4025         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4026         * aarch64-tdep.c (aarch64_make_prologue_cache)
4027         (aarch64_make_stub_cache): Replace throw_exception with throw.
4028
4029 2019-04-08  Tom Tromey  <tom@tromey.com>
4030
4031         * common/common-exceptions.c (throw_exception): Rename from
4032         throw_exception_cxx.  Remove old copy.  Make argument const.
4033         (throw_it): Create and throw exception objects directly.
4034         * common/common-exceptions.h (throw_exception): Make argument
4035         const.
4036         (struct gdb_exception_error): Add constructor.
4037         (struct gdb_exception_quit): Add constructor.
4038
4039 2019-04-08  Tom Tromey  <tom@tromey.com>
4040
4041         * common/common-exceptions.h (exception_rethrow): Don't declare.
4042         (TRY_SJLJ): Update comment.
4043         (TRY, CATCH, END_CATCH): Remove.
4044         * common/common-exceptions.c (exception_rethrow): Remove.
4045
4046 2019-04-08  Tom Tromey  <tom@tromey.com>
4047
4048         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4049         Remove.
4050         (gdb_exception_error): Rename from
4051         gdb_exception_RETURN_MASK_ERROR.
4052         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4053         (gdb_quit_bad_alloc): Update.
4054         * aarch64-tdep.c: Update.
4055         * ada-lang.c: Update.
4056         * ada-typeprint.c: Update.
4057         * ada-valprint.c: Update.
4058         * amd64-tdep.c: Update.
4059         * arch-utils.c: Update.
4060         * break-catch-throw.c: Update.
4061         * breakpoint.c: Update.
4062         * btrace.c: Update.
4063         * c-varobj.c: Update.
4064         * cli/cli-cmds.c: Update.
4065         * cli/cli-interp.c: Update.
4066         * cli/cli-script.c: Update.
4067         * common/common-exceptions.c: Update.
4068         * common/new-op.c: Update.
4069         * common/selftest.c: Update.
4070         * compile/compile-c-symbols.c: Update.
4071         * compile/compile-cplus-symbols.c: Update.
4072         * compile/compile-object-load.c: Update.
4073         * compile/compile-object-run.c: Update.
4074         * completer.c: Update.
4075         * corelow.c: Update.
4076         * cp-abi.c: Update.
4077         * cp-support.c: Update.
4078         * cp-valprint.c: Update.
4079         * darwin-nat.c: Update.
4080         * disasm-selftests.c: Update.
4081         * dtrace-probe.c: Update.
4082         * dwarf-index-cache.c: Update.
4083         * dwarf-index-write.c: Update.
4084         * dwarf2-frame-tailcall.c: Update.
4085         * dwarf2-frame.c: Update.
4086         * dwarf2loc.c: Update.
4087         * dwarf2read.c: Update.
4088         * eval.c: Update.
4089         * event-loop.c: Update.
4090         * event-top.c: Update.
4091         * exec.c: Update.
4092         * f-valprint.c: Update.
4093         * fbsd-tdep.c: Update.
4094         * frame-unwind.c: Update.
4095         * frame.c: Update.
4096         * gdbtypes.c: Update.
4097         * gnu-v3-abi.c: Update.
4098         * guile/guile-internal.h: Update.
4099         * guile/scm-block.c: Update.
4100         * guile/scm-breakpoint.c: Update.
4101         * guile/scm-cmd.c: Update.
4102         * guile/scm-disasm.c: Update.
4103         * guile/scm-frame.c: Update.
4104         * guile/scm-lazy-string.c: Update.
4105         * guile/scm-math.c: Update.
4106         * guile/scm-param.c: Update.
4107         * guile/scm-ports.c: Update.
4108         * guile/scm-pretty-print.c: Update.
4109         * guile/scm-symbol.c: Update.
4110         * guile/scm-symtab.c: Update.
4111         * guile/scm-type.c: Update.
4112         * guile/scm-value.c: Update.
4113         * i386-linux-tdep.c: Update.
4114         * i386-tdep.c: Update.
4115         * inf-loop.c: Update.
4116         * infcall.c: Update.
4117         * infcmd.c: Update.
4118         * infrun.c: Update.
4119         * jit.c: Update.
4120         * language.c: Update.
4121         * linespec.c: Update.
4122         * linux-fork.c: Update.
4123         * linux-nat.c: Update.
4124         * linux-tdep.c: Update.
4125         * linux-thread-db.c: Update.
4126         * main.c: Update.
4127         * mi/mi-cmd-break.c: Update.
4128         * mi/mi-cmd-stack.c: Update.
4129         * mi/mi-interp.c: Update.
4130         * mi/mi-main.c: Update.
4131         * objc-lang.c: Update.
4132         * p-valprint.c: Update.
4133         * parse.c: Update.
4134         * ppc-linux-tdep.c: Update.
4135         * printcmd.c: Update.
4136         * python/py-arch.c: Update.
4137         * python/py-breakpoint.c: Update.
4138         * python/py-cmd.c: Update.
4139         * python/py-finishbreakpoint.c: Update.
4140         * python/py-frame.c: Update.
4141         * python/py-framefilter.c: Update.
4142         * python/py-gdb-readline.c: Update.
4143         * python/py-inferior.c: Update.
4144         * python/py-infthread.c: Update.
4145         * python/py-lazy-string.c: Update.
4146         * python/py-linetable.c: Update.
4147         * python/py-objfile.c: Update.
4148         * python/py-param.c: Update.
4149         * python/py-prettyprint.c: Update.
4150         * python/py-progspace.c: Update.
4151         * python/py-record-btrace.c: Update.
4152         * python/py-record.c: Update.
4153         * python/py-symbol.c: Update.
4154         * python/py-type.c: Update.
4155         * python/py-unwind.c: Update.
4156         * python/py-utils.c: Update.
4157         * python/py-value.c: Update.
4158         * python/python.c: Update.
4159         * record-btrace.c: Update.
4160         * record-full.c: Update.
4161         * remote-fileio.c: Update.
4162         * remote.c: Update.
4163         * riscv-tdep.c: Update.
4164         * rs6000-aix-tdep.c: Update.
4165         * rs6000-tdep.c: Update.
4166         * rust-exp.y: Update.
4167         * rust-lang.c: Update.
4168         * s390-tdep.c: Update.
4169         * selftest-arch.c: Update.
4170         * solib-dsbt.c: Update.
4171         * solib-frv.c: Update.
4172         * solib-spu.c: Update.
4173         * solib-svr4.c: Update.
4174         * solib.c: Update.
4175         * sparc64-linux-tdep.c: Update.
4176         * stack.c: Update.
4177         * symfile-mem.c: Update.
4178         * symmisc.c: Update.
4179         * target.c: Update.
4180         * thread.c: Update.
4181         * top.c: Update.
4182         * tracefile-tfile.c: Update.
4183         * tui/tui.c: Update.
4184         * typeprint.c: Update.
4185         * unittests/cli-utils-selftests.c: Update.
4186         * unittests/parse-connection-spec-selftests.c: Update.
4187         * valops.c: Update.
4188         * valprint.c: Update.
4189         * value.c: Update.
4190         * varobj.c: Update.
4191         * windows-nat.c: Update.
4192         * x86-linux-nat.c: Update.
4193         * xml-support.c: Update.
4194
4195 2019-04-08  Tom Tromey  <tom@tromey.com>
4196
4197         * xml-support.c: Use C++ exception handling.
4198         * x86-linux-nat.c: Use C++ exception handling.
4199         * windows-nat.c: Use C++ exception handling.
4200         * varobj.c: Use C++ exception handling.
4201         * value.c: Use C++ exception handling.
4202         * valprint.c: Use C++ exception handling.
4203         * valops.c: Use C++ exception handling.
4204         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4205         handling.
4206         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4207         * typeprint.c: Use C++ exception handling.
4208         * tui/tui.c: Use C++ exception handling.
4209         * tracefile-tfile.c: Use C++ exception handling.
4210         * top.c: Use C++ exception handling.
4211         * thread.c: Use C++ exception handling.
4212         * target.c: Use C++ exception handling.
4213         * symmisc.c: Use C++ exception handling.
4214         * symfile-mem.c: Use C++ exception handling.
4215         * stack.c: Use C++ exception handling.
4216         * sparc64-linux-tdep.c: Use C++ exception handling.
4217         * solib.c: Use C++ exception handling.
4218         * solib-svr4.c: Use C++ exception handling.
4219         * solib-spu.c: Use C++ exception handling.
4220         * solib-frv.c: Use C++ exception handling.
4221         * solib-dsbt.c: Use C++ exception handling.
4222         * selftest-arch.c: Use C++ exception handling.
4223         * s390-tdep.c: Use C++ exception handling.
4224         * rust-lang.c: Use C++ exception handling.
4225         * rust-exp.y: Use C++ exception handling.
4226         * rs6000-tdep.c: Use C++ exception handling.
4227         * rs6000-aix-tdep.c: Use C++ exception handling.
4228         * riscv-tdep.c: Use C++ exception handling.
4229         * remote.c: Use C++ exception handling.
4230         * remote-fileio.c: Use C++ exception handling.
4231         * record-full.c: Use C++ exception handling.
4232         * record-btrace.c: Use C++ exception handling.
4233         * python/python.c: Use C++ exception handling.
4234         * python/py-value.c: Use C++ exception handling.
4235         * python/py-utils.c: Use C++ exception handling.
4236         * python/py-unwind.c: Use C++ exception handling.
4237         * python/py-type.c: Use C++ exception handling.
4238         * python/py-symbol.c: Use C++ exception handling.
4239         * python/py-record.c: Use C++ exception handling.
4240         * python/py-record-btrace.c: Use C++ exception handling.
4241         * python/py-progspace.c: Use C++ exception handling.
4242         * python/py-prettyprint.c: Use C++ exception handling.
4243         * python/py-param.c: Use C++ exception handling.
4244         * python/py-objfile.c: Use C++ exception handling.
4245         * python/py-linetable.c: Use C++ exception handling.
4246         * python/py-lazy-string.c: Use C++ exception handling.
4247         * python/py-infthread.c: Use C++ exception handling.
4248         * python/py-inferior.c: Use C++ exception handling.
4249         * python/py-gdb-readline.c: Use C++ exception handling.
4250         * python/py-framefilter.c: Use C++ exception handling.
4251         * python/py-frame.c: Use C++ exception handling.
4252         * python/py-finishbreakpoint.c: Use C++ exception handling.
4253         * python/py-cmd.c: Use C++ exception handling.
4254         * python/py-breakpoint.c: Use C++ exception handling.
4255         * python/py-arch.c: Use C++ exception handling.
4256         * printcmd.c: Use C++ exception handling.
4257         * ppc-linux-tdep.c: Use C++ exception handling.
4258         * parse.c: Use C++ exception handling.
4259         * p-valprint.c: Use C++ exception handling.
4260         * objc-lang.c: Use C++ exception handling.
4261         * mi/mi-main.c: Use C++ exception handling.
4262         * mi/mi-interp.c: Use C++ exception handling.
4263         * mi/mi-cmd-stack.c: Use C++ exception handling.
4264         * mi/mi-cmd-break.c: Use C++ exception handling.
4265         * main.c: Use C++ exception handling.
4266         * linux-thread-db.c: Use C++ exception handling.
4267         * linux-tdep.c: Use C++ exception handling.
4268         * linux-nat.c: Use C++ exception handling.
4269         * linux-fork.c: Use C++ exception handling.
4270         * linespec.c: Use C++ exception handling.
4271         * language.c: Use C++ exception handling.
4272         * jit.c: Use C++ exception handling.
4273         * infrun.c: Use C++ exception handling.
4274         * infcmd.c: Use C++ exception handling.
4275         * infcall.c: Use C++ exception handling.
4276         * inf-loop.c: Use C++ exception handling.
4277         * i386-tdep.c: Use C++ exception handling.
4278         * i386-linux-tdep.c: Use C++ exception handling.
4279         * guile/scm-value.c: Use C++ exception handling.
4280         * guile/scm-type.c: Use C++ exception handling.
4281         * guile/scm-symtab.c: Use C++ exception handling.
4282         * guile/scm-symbol.c: Use C++ exception handling.
4283         * guile/scm-pretty-print.c: Use C++ exception handling.
4284         * guile/scm-ports.c: Use C++ exception handling.
4285         * guile/scm-param.c: Use C++ exception handling.
4286         * guile/scm-math.c: Use C++ exception handling.
4287         * guile/scm-lazy-string.c: Use C++ exception handling.
4288         * guile/scm-frame.c: Use C++ exception handling.
4289         * guile/scm-disasm.c: Use C++ exception handling.
4290         * guile/scm-cmd.c: Use C++ exception handling.
4291         * guile/scm-breakpoint.c: Use C++ exception handling.
4292         * guile/scm-block.c: Use C++ exception handling.
4293         * guile/guile-internal.h: Use C++ exception handling.
4294         * gnu-v3-abi.c: Use C++ exception handling.
4295         * gdbtypes.c: Use C++ exception handling.
4296         * frame.c: Use C++ exception handling.
4297         * frame-unwind.c: Use C++ exception handling.
4298         * fbsd-tdep.c: Use C++ exception handling.
4299         * f-valprint.c: Use C++ exception handling.
4300         * exec.c: Use C++ exception handling.
4301         * event-top.c: Use C++ exception handling.
4302         * event-loop.c: Use C++ exception handling.
4303         * eval.c: Use C++ exception handling.
4304         * dwarf2read.c: Use C++ exception handling.
4305         * dwarf2loc.c: Use C++ exception handling.
4306         * dwarf2-frame.c: Use C++ exception handling.
4307         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4308         * dwarf-index-write.c: Use C++ exception handling.
4309         * dwarf-index-cache.c: Use C++ exception handling.
4310         * dtrace-probe.c: Use C++ exception handling.
4311         * disasm-selftests.c: Use C++ exception handling.
4312         * darwin-nat.c: Use C++ exception handling.
4313         * cp-valprint.c: Use C++ exception handling.
4314         * cp-support.c: Use C++ exception handling.
4315         * cp-abi.c: Use C++ exception handling.
4316         * corelow.c: Use C++ exception handling.
4317         * completer.c: Use C++ exception handling.
4318         * compile/compile-object-run.c: Use C++ exception handling.
4319         * compile/compile-object-load.c: Use C++ exception handling.
4320         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4321         * compile/compile-c-symbols.c: Use C++ exception handling.
4322         * common/selftest.c: Use C++ exception handling.
4323         * common/new-op.c: Use C++ exception handling.
4324         * cli/cli-script.c: Use C++ exception handling.
4325         * cli/cli-interp.c: Use C++ exception handling.
4326         * cli/cli-cmds.c: Use C++ exception handling.
4327         * c-varobj.c: Use C++ exception handling.
4328         * btrace.c: Use C++ exception handling.
4329         * breakpoint.c: Use C++ exception handling.
4330         * break-catch-throw.c: Use C++ exception handling.
4331         * arch-utils.c: Use C++ exception handling.
4332         * amd64-tdep.c: Use C++ exception handling.
4333         * ada-valprint.c: Use C++ exception handling.
4334         * ada-typeprint.c: Use C++ exception handling.
4335         * ada-lang.c: Use C++ exception handling.
4336         * aarch64-tdep.c: Use C++ exception handling.
4337
4338 2019-04-08  Tom Tromey  <tom@tromey.com>
4339
4340         * xml-support.c (gdb_xml_parser::parse): Update.
4341         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4342         * value.c (show_convenience): Update.
4343         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4344         (test_parse_flags_qcs): Update.
4345         * thread.c (thr_try_catch_cmd): Update.
4346         * target.c (target_translate_tls_address): Update.
4347         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4348         (info_frame_command_core, frame_apply_command_count): Update.
4349         * rust-exp.y (rust_lex_exception_test): Update.
4350         * riscv-tdep.c (riscv_print_one_register_info): Update.
4351         * remote.c (remote_target::enable_btrace): Update.
4352         * record-btrace.c (record_btrace_enable_warn): Update.
4353         * python/py-utils.c (gdbpy_convert_exception): Update.
4354         * printcmd.c (do_one_display, print_variable_and_value): Update.
4355         * mi/mi-main.c (mi_print_exception): Update.
4356         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4357         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4358         * linux-nat.c (linux_nat_target::attach): Update.
4359         * linux-fork.c (class scoped_switch_fork_info): Update.
4360         * infrun.c (displaced_step_prepare): Update.
4361         * infcall.c (call_function_by_hand_dummy): Update.
4362         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4363         * gnu-v3-abi.c (print_one_vtable): Update.
4364         * frame.c (get_prev_frame_always): Update.
4365         * f-valprint.c (info_common_command_for_block): Update.
4366         * exec.c (try_open_exec_file): Update.
4367         * exceptions.c (print_exception, exception_print)
4368         (exception_fprintf, exception_print_same): Update.
4369         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4370         * dwarf-index-cache.c (index_cache::store)
4371         (index_cache::lookup_gdb_index): Update.
4372         * darwin-nat.c (maybe_cache_shell): Update.
4373         * cp-valprint.c (cp_print_value_fields): Update.
4374         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4375         (gcc_cplus_symbol_address): Update.
4376         * compile/compile-c-symbols.c (gcc_convert_symbol)
4377         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4378         * common/selftest.c: Update.
4379         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4380         a std::string.
4381         (exception_try_scope_entry, exception_try_scope_exit): Don't
4382         declare.
4383         (struct exception_try_scope): Remove.
4384         (TRY): Don't use exception_try_scope.
4385         (struct gdb_exception): Add constructor, operator=.
4386         <what>: New method.
4387         (struct gdb_exception_RETURN_MASK_ALL)
4388         (struct gdb_exception_RETURN_MASK_ERROR)
4389         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4390         (struct gdb_quit_bad_alloc): Update.
4391         * common/common-exceptions.c (exception_none): Change
4392         initializer.
4393         (struct catcher) <state, exception>: Initialize inline.
4394         <prev>: Remove member.
4395         (current_catcher): Remove.
4396         (catchers): New global.
4397         (exceptions_state_mc_init): Simplify.
4398         (catcher_pop): Remove.
4399         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4400         (try_scope_depth, exception_try_scope_entry)
4401         (exception_try_scope_exit): Remove.
4402         (throw_exception_sjlj): Update.
4403         (exception_messages, exception_messages_size): Remove.
4404         (throw_it): Simplify.
4405         (gdb_exception_sliced_copy): Remove.
4406         (throw_exception_cxx): Update.
4407         * cli/cli-script.c (script_from_file): Update.
4408         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4409         Update.
4410         * ada-valprint.c (ada_val_print): Update.
4411         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4412         (create_excep_cond_exprs): Update.
4413
4414 2019-04-08  Tom Tromey  <tom@tromey.com>
4415
4416         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4417         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4418         (TRY, CATCH, END_CATCH): Remove some definitions.
4419         * common/common-exceptions.c: Don't use GDB_XCPT.
4420         (catcher_list_size): Remove.
4421         (throw_exception, throw_it): Simplify.
4422
4423 2019-04-05  Tom Tromey  <tom@tromey.com>
4424
4425         Revert the header-sorting patch.
4426         * ft32-tdep.c: Revert.
4427         * frv-tdep.c: Revert.
4428         * frv-linux-tdep.c: Revert.
4429         * frame.c: Revert.
4430         * frame-unwind.c: Revert.
4431         * frame-base.c: Revert.
4432         * fork-child.c: Revert.
4433         * findvar.c: Revert.
4434         * findcmd.c: Revert.
4435         * filesystem.c: Revert.
4436         * filename-seen-cache.h: Revert.
4437         * filename-seen-cache.c: Revert.
4438         * fbsd-tdep.c: Revert.
4439         * fbsd-nat.h: Revert.
4440         * fbsd-nat.c: Revert.
4441         * f-valprint.c: Revert.
4442         * f-typeprint.c: Revert.
4443         * f-lang.c: Revert.
4444         * extension.h: Revert.
4445         * extension.c: Revert.
4446         * extension-priv.h: Revert.
4447         * expprint.c: Revert.
4448         * exec.h: Revert.
4449         * exec.c: Revert.
4450         * exceptions.c: Revert.
4451         * event-top.c: Revert.
4452         * event-loop.c: Revert.
4453         * eval.c: Revert.
4454         * elfread.c: Revert.
4455         * dwarf2read.h: Revert.
4456         * dwarf2read.c: Revert.
4457         * dwarf2loc.c: Revert.
4458         * dwarf2expr.h: Revert.
4459         * dwarf2expr.c: Revert.
4460         * dwarf2-frame.c: Revert.
4461         * dwarf2-frame-tailcall.c: Revert.
4462         * dwarf-index-write.h: Revert.
4463         * dwarf-index-write.c: Revert.
4464         * dwarf-index-common.c: Revert.
4465         * dwarf-index-cache.h: Revert.
4466         * dwarf-index-cache.c: Revert.
4467         * dummy-frame.c: Revert.
4468         * dtrace-probe.c: Revert.
4469         * disasm.h: Revert.
4470         * disasm.c: Revert.
4471         * disasm-selftests.c: Revert.
4472         * dictionary.c: Revert.
4473         * dicos-tdep.c: Revert.
4474         * demangle.c: Revert.
4475         * dcache.h: Revert.
4476         * dcache.c: Revert.
4477         * darwin-nat.h: Revert.
4478         * darwin-nat.c: Revert.
4479         * darwin-nat-info.c: Revert.
4480         * d-valprint.c: Revert.
4481         * d-namespace.c: Revert.
4482         * d-lang.c: Revert.
4483         * ctf.c: Revert.
4484         * csky-tdep.c: Revert.
4485         * csky-linux-tdep.c: Revert.
4486         * cris-tdep.c: Revert.
4487         * cris-linux-tdep.c: Revert.
4488         * cp-valprint.c: Revert.
4489         * cp-support.c: Revert.
4490         * cp-namespace.c: Revert.
4491         * cp-abi.c: Revert.
4492         * corelow.c: Revert.
4493         * corefile.c: Revert.
4494         * continuations.c: Revert.
4495         * completer.h: Revert.
4496         * completer.c: Revert.
4497         * complaints.c: Revert.
4498         * coffread.c: Revert.
4499         * coff-pe-read.c: Revert.
4500         * cli-out.h: Revert.
4501         * cli-out.c: Revert.
4502         * charset.c: Revert.
4503         * c-varobj.c: Revert.
4504         * c-valprint.c: Revert.
4505         * c-typeprint.c: Revert.
4506         * c-lang.c: Revert.
4507         * buildsym.c: Revert.
4508         * buildsym-legacy.c: Revert.
4509         * build-id.h: Revert.
4510         * build-id.c: Revert.
4511         * btrace.c: Revert.
4512         * bsd-uthread.c: Revert.
4513         * breakpoint.h: Revert.
4514         * breakpoint.c: Revert.
4515         * break-catch-throw.c: Revert.
4516         * break-catch-syscall.c: Revert.
4517         * break-catch-sig.c: Revert.
4518         * blockframe.c: Revert.
4519         * block.c: Revert.
4520         * bfin-tdep.c: Revert.
4521         * bfin-linux-tdep.c: Revert.
4522         * bfd-target.c: Revert.
4523         * bcache.c: Revert.
4524         * ax-general.c: Revert.
4525         * ax-gdb.h: Revert.
4526         * ax-gdb.c: Revert.
4527         * avr-tdep.c: Revert.
4528         * auxv.c: Revert.
4529         * auto-load.c: Revert.
4530         * arm-wince-tdep.c: Revert.
4531         * arm-tdep.c: Revert.
4532         * arm-symbian-tdep.c: Revert.
4533         * arm-pikeos-tdep.c: Revert.
4534         * arm-obsd-tdep.c: Revert.
4535         * arm-nbsd-tdep.c: Revert.
4536         * arm-nbsd-nat.c: Revert.
4537         * arm-linux-tdep.c: Revert.
4538         * arm-linux-nat.c: Revert.
4539         * arm-fbsd-tdep.c: Revert.
4540         * arm-fbsd-nat.c: Revert.
4541         * arm-bsd-tdep.c: Revert.
4542         * arch-utils.c: Revert.
4543         * arc-tdep.c: Revert.
4544         * arc-newlib-tdep.c: Revert.
4545         * annotate.h: Revert.
4546         * annotate.c: Revert.
4547         * amd64-windows-tdep.c: Revert.
4548         * amd64-windows-nat.c: Revert.
4549         * amd64-tdep.c: Revert.
4550         * amd64-sol2-tdep.c: Revert.
4551         * amd64-obsd-tdep.c: Revert.
4552         * amd64-obsd-nat.c: Revert.
4553         * amd64-nbsd-tdep.c: Revert.
4554         * amd64-nbsd-nat.c: Revert.
4555         * amd64-nat.c: Revert.
4556         * amd64-linux-tdep.c: Revert.
4557         * amd64-linux-nat.c: Revert.
4558         * amd64-fbsd-tdep.c: Revert.
4559         * amd64-fbsd-nat.c: Revert.
4560         * amd64-dicos-tdep.c: Revert.
4561         * amd64-darwin-tdep.c: Revert.
4562         * amd64-bsd-nat.c: Revert.
4563         * alpha-tdep.c: Revert.
4564         * alpha-obsd-tdep.c: Revert.
4565         * alpha-nbsd-tdep.c: Revert.
4566         * alpha-mdebug-tdep.c: Revert.
4567         * alpha-linux-tdep.c: Revert.
4568         * alpha-linux-nat.c: Revert.
4569         * alpha-bsd-tdep.c: Revert.
4570         * alpha-bsd-nat.c: Revert.
4571         * aix-thread.c: Revert.
4572         * agent.c: Revert.
4573         * addrmap.c: Revert.
4574         * ada-varobj.c: Revert.
4575         * ada-valprint.c: Revert.
4576         * ada-typeprint.c: Revert.
4577         * ada-tasks.c: Revert.
4578         * ada-lang.c: Revert.
4579         * aarch64-tdep.c: Revert.
4580         * aarch64-ravenscar-thread.c: Revert.
4581         * aarch64-newlib-tdep.c: Revert.
4582         * aarch64-linux-tdep.c: Revert.
4583         * aarch64-linux-nat.c: Revert.
4584         * aarch64-fbsd-tdep.c: Revert.
4585         * aarch64-fbsd-nat.c: Revert.
4586         * aarch32-linux-nat.c: Revert.
4587
4588 2019-04-05  Tom Tromey  <tom@tromey.com>
4589
4590         * ft32-tdep.c: Sort headers.
4591         * frv-tdep.c: Sort headers.
4592         * frv-linux-tdep.c: Sort headers.
4593         * frame.c: Sort headers.
4594         * frame-unwind.c: Sort headers.
4595         * frame-base.c: Sort headers.
4596         * fork-child.c: Sort headers.
4597         * findvar.c: Sort headers.
4598         * findcmd.c: Sort headers.
4599         * filesystem.c: Sort headers.
4600         * filename-seen-cache.h: Sort headers.
4601         * filename-seen-cache.c: Sort headers.
4602         * fbsd-tdep.c: Sort headers.
4603         * fbsd-nat.h: Sort headers.
4604         * fbsd-nat.c: Sort headers.
4605         * f-valprint.c: Sort headers.
4606         * f-typeprint.c: Sort headers.
4607         * f-lang.c: Sort headers.
4608         * extension.h: Sort headers.
4609         * extension.c: Sort headers.
4610         * extension-priv.h: Sort headers.
4611         * expprint.c: Sort headers.
4612         * exec.h: Sort headers.
4613         * exec.c: Sort headers.
4614         * exceptions.c: Sort headers.
4615         * event-top.c: Sort headers.
4616         * event-loop.c: Sort headers.
4617         * eval.c: Sort headers.
4618         * elfread.c: Sort headers.
4619         * dwarf2read.h: Sort headers.
4620         * dwarf2read.c: Sort headers.
4621         * dwarf2loc.c: Sort headers.
4622         * dwarf2expr.h: Sort headers.
4623         * dwarf2expr.c: Sort headers.
4624         * dwarf2-frame.c: Sort headers.
4625         * dwarf2-frame-tailcall.c: Sort headers.
4626         * dwarf-index-write.h: Sort headers.
4627         * dwarf-index-write.c: Sort headers.
4628         * dwarf-index-common.c: Sort headers.
4629         * dwarf-index-cache.h: Sort headers.
4630         * dwarf-index-cache.c: Sort headers.
4631         * dummy-frame.c: Sort headers.
4632         * dtrace-probe.c: Sort headers.
4633         * disasm.h: Sort headers.
4634         * disasm.c: Sort headers.
4635         * disasm-selftests.c: Sort headers.
4636         * dictionary.c: Sort headers.
4637         * dicos-tdep.c: Sort headers.
4638         * demangle.c: Sort headers.
4639         * dcache.h: Sort headers.
4640         * dcache.c: Sort headers.
4641         * darwin-nat.h: Sort headers.
4642         * darwin-nat.c: Sort headers.
4643         * darwin-nat-info.c: Sort headers.
4644         * d-valprint.c: Sort headers.
4645         * d-namespace.c: Sort headers.
4646         * d-lang.c: Sort headers.
4647         * ctf.c: Sort headers.
4648         * csky-tdep.c: Sort headers.
4649         * csky-linux-tdep.c: Sort headers.
4650         * cris-tdep.c: Sort headers.
4651         * cris-linux-tdep.c: Sort headers.
4652         * cp-valprint.c: Sort headers.
4653         * cp-support.c: Sort headers.
4654         * cp-namespace.c: Sort headers.
4655         * cp-abi.c: Sort headers.
4656         * corelow.c: Sort headers.
4657         * corefile.c: Sort headers.
4658         * continuations.c: Sort headers.
4659         * completer.h: Sort headers.
4660         * completer.c: Sort headers.
4661         * complaints.c: Sort headers.
4662         * coffread.c: Sort headers.
4663         * coff-pe-read.c: Sort headers.
4664         * cli-out.h: Sort headers.
4665         * cli-out.c: Sort headers.
4666         * charset.c: Sort headers.
4667         * c-varobj.c: Sort headers.
4668         * c-valprint.c: Sort headers.
4669         * c-typeprint.c: Sort headers.
4670         * c-lang.c: Sort headers.
4671         * buildsym.c: Sort headers.
4672         * buildsym-legacy.c: Sort headers.
4673         * build-id.h: Sort headers.
4674         * build-id.c: Sort headers.
4675         * btrace.c: Sort headers.
4676         * bsd-uthread.c: Sort headers.
4677         * breakpoint.h: Sort headers.
4678         * breakpoint.c: Sort headers.
4679         * break-catch-throw.c: Sort headers.
4680         * break-catch-syscall.c: Sort headers.
4681         * break-catch-sig.c: Sort headers.
4682         * blockframe.c: Sort headers.
4683         * block.c: Sort headers.
4684         * bfin-tdep.c: Sort headers.
4685         * bfin-linux-tdep.c: Sort headers.
4686         * bfd-target.c: Sort headers.
4687         * bcache.c: Sort headers.
4688         * ax-general.c: Sort headers.
4689         * ax-gdb.h: Sort headers.
4690         * ax-gdb.c: Sort headers.
4691         * avr-tdep.c: Sort headers.
4692         * auxv.c: Sort headers.
4693         * auto-load.c: Sort headers.
4694         * arm-wince-tdep.c: Sort headers.
4695         * arm-tdep.c: Sort headers.
4696         * arm-symbian-tdep.c: Sort headers.
4697         * arm-pikeos-tdep.c: Sort headers.
4698         * arm-obsd-tdep.c: Sort headers.
4699         * arm-nbsd-tdep.c: Sort headers.
4700         * arm-nbsd-nat.c: Sort headers.
4701         * arm-linux-tdep.c: Sort headers.
4702         * arm-linux-nat.c: Sort headers.
4703         * arm-fbsd-tdep.c: Sort headers.
4704         * arm-fbsd-nat.c: Sort headers.
4705         * arm-bsd-tdep.c: Sort headers.
4706         * arch-utils.c: Sort headers.
4707         * arc-tdep.c: Sort headers.
4708         * arc-newlib-tdep.c: Sort headers.
4709         * annotate.h: Sort headers.
4710         * annotate.c: Sort headers.
4711         * amd64-windows-tdep.c: Sort headers.
4712         * amd64-windows-nat.c: Sort headers.
4713         * amd64-tdep.c: Sort headers.
4714         * amd64-sol2-tdep.c: Sort headers.
4715         * amd64-obsd-tdep.c: Sort headers.
4716         * amd64-obsd-nat.c: Sort headers.
4717         * amd64-nbsd-tdep.c: Sort headers.
4718         * amd64-nbsd-nat.c: Sort headers.
4719         * amd64-nat.c: Sort headers.
4720         * amd64-linux-tdep.c: Sort headers.
4721         * amd64-linux-nat.c: Sort headers.
4722         * amd64-fbsd-tdep.c: Sort headers.
4723         * amd64-fbsd-nat.c: Sort headers.
4724         * amd64-dicos-tdep.c: Sort headers.
4725         * amd64-darwin-tdep.c: Sort headers.
4726         * amd64-bsd-nat.c: Sort headers.
4727         * alpha-tdep.c: Sort headers.
4728         * alpha-obsd-tdep.c: Sort headers.
4729         * alpha-nbsd-tdep.c: Sort headers.
4730         * alpha-mdebug-tdep.c: Sort headers.
4731         * alpha-linux-tdep.c: Sort headers.
4732         * alpha-linux-nat.c: Sort headers.
4733         * alpha-bsd-tdep.c: Sort headers.
4734         * alpha-bsd-nat.c: Sort headers.
4735         * aix-thread.c: Sort headers.
4736         * agent.c: Sort headers.
4737         * addrmap.c: Sort headers.
4738         * ada-varobj.c: Sort headers.
4739         * ada-valprint.c: Sort headers.
4740         * ada-typeprint.c: Sort headers.
4741         * ada-tasks.c: Sort headers.
4742         * ada-lang.c: Sort headers.
4743         * aarch64-tdep.c: Sort headers.
4744         * aarch64-ravenscar-thread.c: Sort headers.
4745         * aarch64-newlib-tdep.c: Sort headers.
4746         * aarch64-linux-tdep.c: Sort headers.
4747         * aarch64-linux-nat.c: Sort headers.
4748         * aarch64-fbsd-tdep.c: Sort headers.
4749         * aarch64-fbsd-nat.c: Sort headers.
4750         * aarch32-linux-nat.c: Sort headers.
4751
4752 2019-04-04  Tom Tromey  <tom@tromey.com>
4753
4754         * varobj.c (varobj_create): Update.
4755         * rust-exp.y (struct rust_parser) <update_innermost_block,
4756         lookup_symbol>: New methods.
4757         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4758         Rename.
4759         (rust_parser::rust_lookup_type)
4760         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4761         * printcmd.c (display_command, do_one_display): Update.
4762         * parser-defs.h (struct parser_state) <parser_state>: Add
4763         "tracker" parameter.
4764         (block_tracker): New member.
4765         (class innermost_block_tracker) <innermost_block_tracker>: Add
4766         "types" parameter.
4767         <reset>: Remove method.
4768         (innermost_block): Don't declare.
4769         (null_post_parser): Update.
4770         * parse.c (innermost_block): Remove global.
4771         (write_dollar_variable): Update.
4772         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4773         Remove "tracker_types" parameter.
4774         (parse_expression): Add "tracker" parameter.
4775         (parse_expression_for_completion): Update.
4776         (null_post_parser): Add "tracker" parameter.
4777         * p-exp.y: Update rules.
4778         * m2-exp.y: Update rules.
4779         * language.h (struct language_defn) <la_post_parser>: Add
4780         "tracker" parameter.
4781         * go-exp.y: Update rules.
4782         * f-exp.y: Update rules.
4783         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4784         parameter.
4785         * d-exp.y: Update rules.
4786         * c-exp.y: Update rules.
4787         * breakpoint.c (set_breakpoint_condition): Create an
4788         innermost_block_tracker.
4789         (watch_command_1): Likewise.
4790         * ada-lang.c (resolve): Add "tracker" parameter.
4791         (resolve_subexp): Likewise.
4792         * ada-exp.y (write_var_from_sym): Update.
4793
4794 2019-04-04  Tom Tromey  <tom@tromey.com>
4795
4796         * type-stack.h: New file.
4797         * type-stack.c: New file.
4798         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4799         type-stack.h.
4800         (insert_into_type_stack, insert_type, push_type, push_type_int)
4801         (insert_type_address_space, pop_type, pop_type_int)
4802         (pop_typelist, pop_type_stack, append_type_stack)
4803         (push_type_stack, get_type_stack, push_typelist)
4804         (follow_type_instance_flags, follow_types): Don't declare.
4805         * parse.c (type_stack): Remove global.
4806         (parse_exp_in_context): Update.
4807         (insert_into_type_stack, insert_type, push_type, push_type_int)
4808         (insert_type_address_space, pop_type, pop_type_int)
4809         (pop_typelist, pop_type_stack, append_type_stack)
4810         (push_type_stack, get_type_stack, push_typelist)
4811         (follow_type_instance_flags, follow_types): Remove (moved to
4812         type-stack.c).
4813         * f-exp.y (type_stack): New global.
4814         Update rules.
4815         (push_kind_type, f_parse): Update.
4816         * d-exp.y (type_stack): New global.
4817         Update rules.
4818         (d_parse): Update.
4819         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4820         Update rules.
4821         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4822         (HFILES_NO_SRCDIR): Add type-stack.h.
4823
4824 2019-04-04  Tom Tromey  <tom@tromey.com>
4825
4826         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4827         (rust_parser::convert_ast_to_expression, rust_parse)
4828         (rust_lex_test_completion, rust_lex_tests): Update.
4829         * parser-defs.h (struct expr_completion_state): New.
4830         (struct parser_state) <parser_state>: Add completion parameter.
4831         <mark_struct_expression, mark_completion_tag>: New methods.
4832         <parse_completion, m_completion_state>: New members.
4833         (prefixify_expression, null_post_parser): Update.
4834         (mark_struct_expression, mark_completion_tag): Don't declare.
4835         * parse.c (parse_completion, expout_last_struct)
4836         (expout_tag_completion_type, expout_completion_name): Remove
4837         globals.
4838         (parser_state::mark_struct_expression)
4839         (parser_state::mark_completion_tag): Now methods.
4840         (prefixify_expression): Add last_struct parameter.
4841         (prefixify_subexp): Likewise.
4842         (parse_exp_1): Update.
4843         (parse_exp_in_context): Add cstate parameter.  Update.
4844         (parse_expression_for_completion): Create an
4845         expr_completion_state.
4846         (null_post_parser): Add "completion" parameter.
4847         * p-exp.y: Update rules.
4848         (yylex): Update.
4849         * language.h (struct language_defn) <la_post_parser>: Add
4850         "completing" parameter.
4851         * go-exp.y: Update rules.
4852         (lex_one_token): Update.
4853         * expression.h (parse_completion): Don't declare.
4854         * d-exp.y: Update rules.
4855         (lex_one_token): Update rules.
4856         * c-exp.y: Update rules.
4857         (lex_one_token): Update.
4858         * ada-lang.c (resolve): Add "parse_completion" parameter.
4859         (resolve_subexp): Likewise.
4860         (ada_resolve_function): Likewise.
4861
4862 2019-04-04  Tom Tromey  <tom@tromey.com>
4863
4864         * parser-defs.h (struct parser_state) <start_arglist,
4865         end_arglist>: New methods.
4866         <arglist_len, m_funcall_chain>: New members.
4867         (arglist_len, start_arglist, end_arglist): Don't declare.
4868         * parse.c (arglist_len, funcall_chain): Remove global.
4869         (start_arglist, end_arglist): Remove functions.
4870         (parse_exp_in_context): Update.
4871         * p-exp.y: Update rules.
4872         * m2-exp.y: Update rules.
4873         * go-exp.y: Update rules.
4874         * f-exp.y: Update rules.
4875         * d-exp.y: Update rules.
4876         * c-exp.y: Update rules.
4877
4878 2019-04-04  Tom Tromey  <tom@tromey.com>
4879
4880         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4881         lex_operator, push_back>: New methods.
4882         Update all rules.
4883         (rust_parser::lex_hex, lex_escape): Rename and update.
4884         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4885         (rust_parser::lex_operator): Rename and update.
4886         (rust_parser::lex_number, rustyylex, rustyyerror)
4887         (rust_lex_test_init, rust_lex_test_sequence)
4888         (rust_lex_test_push_back, rust_lex_tests): Update.
4889         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4890         parameter.
4891         <lexptr, prev_lexptr>: New members.
4892         (lexptr, prev_lexptr): Don't declare.
4893         * parse.c (lexptr, prev_lexptr): Remove globals.
4894         (parse_exp_in_context): Update.
4895         * p-exp.y (yylex, yyerror): Update.
4896         * m2-exp.y (parse_number, yylex, yyerror): Update.
4897         * go-exp.y (lex_one_token, yyerror): Update.
4898         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4899         * d-exp.y (lex_one_token, yyerror): Update.
4900         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4901         (lex_one_token, yyerror): Update.
4902         * ada-lex.l (YY_INPUT): Update.
4903         (rewind_to_char): Update.
4904         * ada-exp.y (yyerror): Update.
4905
4906 2019-04-04  Tom Tromey  <tom@tromey.com>
4907
4908         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4909         * parser-defs.h (struct parser_state) <parser_state>: Add new
4910         parameter.
4911         <comma_terminates>: New member.
4912         (comma_terminates): Don't declare global.
4913         * parse.c (comma_terminates): Remove global.
4914         (parse_exp_in_context): Update.
4915         * p-exp.y (yylex): Update.
4916         * m2-exp.y (yylex): Update.
4917         * go-exp.y (lex_one_token): Update.
4918         * f-exp.y (yylex): Update.
4919         * d-exp.y (lex_one_token): Update.
4920         * c-exp.y (lex_one_token): Update.
4921         * ada-lex.l: Update.
4922
4923 2019-04-04  Tom Tromey  <tom@tromey.com>
4924
4925         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4926         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4927         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4928         * parser-defs.h (paren_depth): Don't declare.
4929         * parse.c (paren_depth): Remove global.
4930         (parse_exp_in_context): Update.
4931         * p-exp.y (paren_depth): New global.
4932         (pascal_parse): Initialize it.
4933         * m2-exp.y (paren_depth): New global.
4934         (m2_parse): Initialize it.
4935         * go-exp.y (paren_depth): New global.
4936         (go_parse): Initialize it.
4937         * f-exp.y (paren_depth): New global.
4938         (f_parse): Initialize it.
4939         * d-exp.y (paren_depth): New global.
4940         (d_parse): Initialize it.
4941         * c-exp.y (paren_depth): New global.
4942         (c_parse): Initialize it.
4943         * ada-lex.l (paren_depth): New global.
4944         (lexer_init): Initialize it.
4945
4946 2019-04-04  Tom Tromey  <tom@tromey.com>
4947
4948         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4949         (rust_parser::convert_ast_to_type)
4950         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4951         * parser-defs.h (struct parser_state) <parser_state>: Add
4952         parameters.  Initialize new members.
4953         <expression_context_block, expression_context_pc>: New members.
4954         * parse.c (expression_context_block, expression_context_pc):
4955         Remove globals.
4956         (parse_exp_in_context): Update.
4957         * p-exp.y: Update all rules.
4958         (yylex): Update.
4959         * m2-exp.y: Update all rules.
4960         (yylex): Update.
4961         * go-exp.y (yylex): Update.
4962         * f-exp.y (yylex): Update.
4963         * d-exp.y: Update all rules.
4964         (yylex): Update.
4965         * c-exp.y: Update all rules.
4966         (lex_one_token, classify_name, yylex, c_parse): Update.
4967         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4968
4969 2019-04-04  Tom Tromey  <tom@tromey.com>
4970
4971         * gdbarch.h, gdbarch.c: Rebuild.
4972         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4973         * stap-probe.h:
4974         (struct stap_parse_info): Replace "parser_state" with
4975         "expr_builder".
4976         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4977         (parser_state): New class.
4978         * parse.c (expr_builder): Rename.
4979         (expr_builder::release): Rename.
4980         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4981         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4982         (write_exp_elt_longcst, write_exp_elt_floatcst)
4983         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4984         (write_exp_string_vector, write_exp_bitstring)
4985         (write_exp_msymbol, mark_struct_expression)
4986         (write_dollar_variable)
4987         (insert_type_address_space, increase_expout_size): Replace
4988         "parser_state" with "expr_builder".
4989         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4990         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4991         "parser_state" with "expr_builder".
4992
4993 2019-04-04  Tom Tromey  <tom@tromey.com>
4994
4995         * rust-exp.y: Replace "parse_language" with method call.
4996         * p-exp.y:
4997         (yylex): Replace "parse_language" with method call.
4998         * m2-exp.y:
4999         (yylex): Replace "parse_language" with method call.
5000         * go-exp.y (classify_name): Replace "parse_language" with method
5001         call.
5002         * f-exp.y (yylex): Replace "parse_language" with method call.
5003         * d-exp.y (lex_one_token): Replace "parse_language" with method
5004         call.
5005         * c-exp.y:
5006         (lex_one_token, classify_name, yylex): Replace "parse_language"
5007         with method call.
5008         * ada-exp.y (find_primitive_type, type_char)
5009         (type_system_address): Replace "parse_language" with method call.
5010
5011 2019-04-04  Tom Tromey  <tom@tromey.com>
5012
5013         * rust-exp.y: Replace "parse_gdbarch" with method call.
5014         * parse.c (write_dollar_variable, insert_type_address_space):
5015         Replace "parse_gdbarch" with method call.
5016         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5017         call.
5018         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5019         call.
5020         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5021         "parse_gdbarch" with method call.
5022         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5023         with method call.
5024         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5025         "parse_gdbarch" with method call.
5026         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5027         "parse_gdbarch" with method call.
5028         * c-exp.y (parse_type, parse_number, classify_name): Replace
5029         "parse_gdbarch" with method call.
5030         * ada-lex.l: Replace "parse_gdbarch" with method call.
5031         * ada-exp.y (parse_type, find_primitive_type, type_char)
5032         (type_system_address): Replace "parse_gdbarch" with method call.
5033
5034 2019-04-04  Tom Tromey  <tom@tromey.com>
5035
5036         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5037         * stap-probe.c (stap_parse_argument): Update.
5038         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5039         initial_size parameter.
5040         * rust-exp.y (rust_lex_tests): Update.
5041         * parse.c (parser_state): Update.
5042         (parse_exp_in_context): Update.
5043         * parser-defs.h (struct parser_state) <parser_state>: Remove
5044         "initial_size" parameter.
5045
5046 2019-04-04  Tom Tromey  <tom@tromey.com>
5047
5048         * parser-defs.h (increase_expout_size): Don't declare.
5049         * parse.c (increase_expout_size): Now static.
5050
5051 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5052
5053         * gnu-nat.c (gnu_nat_target::wait): Fix
5054         target_waitstatus_to_string call.
5055
5056 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5057
5058         * eval.c (evaluate_subexp_standard): Handle internal functions
5059         during Fortran function call handling.
5060
5061 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5062
5063         * NEWS: Mention new internal functions.
5064         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5065         (read_base_type): Use dwarf2_init_complex_target_type.
5066         * value.c (creal_internal_fn): New function.
5067         (cimag_internal_fn): New function.
5068         (_initialize_values): Register new internal functions.
5069
5070 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5071
5072         * infrun.c (stop_all_threads): If debug_infrun, always
5073         trace the wait status after wait_one, using
5074         target_waitstatus_to_string and target_pid_to_str.
5075         (handle_inferior_event): Replace various trace of
5076         wait status kind by a single trace.
5077         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5078         wait status kind image by target_waitstatus_to_string.
5079         * target/waitstatus.c (target_waitstatus_to_string): Fix
5080         obsolete comment.
5081
5082 2019-04-01  Tom Tromey  <tromey@adacore.com>
5083
5084         PR symtab/23331:
5085         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5086
5087 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5088             Pedro Alves  <palves@redhat.com>
5089
5090         * top.c (quit_force): Call 'finalize_values'.
5091         * value.c (finalize_values): New function.
5092         * value.h (finalize_values): Declare.
5093
5094 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5095
5096         * NEWS: Announce $_gdb_major and $_gdb_minor.
5097
5098         * top.c (init_gdb_version_vars): New function.
5099         (gdb_init): Call init_gdb_version_vars.
5100
5101 2019-03-29  Tom Tromey  <tromey@adacore.com>
5102
5103         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5104         help text.  Remove dead code.
5105
5106 2019-03-29  Keith Seitz  <keiths@redhat.com>
5107
5108         From Siddhesh Poyarekar:
5109         * f-lang.h (f77_get_upperbound): Return LONGEST.
5110         (f77_get_lowerbound): Likewise.
5111         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5112         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5113         print them.
5114         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5115         plongest to format print it.
5116         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5117         (f77_get_upperbound): Likewise.
5118         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5119         LOWER_BOUND to LONGEST.
5120         (f77_create_arrayprint_offset_tbl): Likewise.
5121
5122 2019-03-29  Keith Seitz  <keiths@redhat.com>
5123
5124         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5125         %s/pulongest for TYPE_LENGTH instead of %d in format
5126         strings.
5127         * ada-typerint.c (ada_print_type): Likewise.
5128         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5129         * compile/compile-c-support.c (generate_register_struct): Likewise.
5130         * gdbtypes.c (recursive_dump_type): Likewise.
5131         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5132         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5133         instead of %d in format strings.
5134         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5135         to std::min to ULONGEST.
5136         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5137         instead of %d in format strings.
5138         * tracepoint.c (info_scope_command): Likewise.
5139         * typeprint.c (print_offset_data::update)
5140         (print_offset_data::finish): Likewise.
5141         * xtensa-tdep.c (xtensa_store_return_value)
5142         (xtensa_push_dummy_call): Likewise.
5143
5144 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5145
5146         * windows-nat.c (display_selector): Fixed format specifications
5147         for 64-bit Cygwin.
5148
5149 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5150
5151         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5152
5153 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5154
5155         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5156         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5157         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5158         (nios2_linux_init_abi): Install it.
5159
5160 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5161
5162         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5163
5164 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5165
5166         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5167
5168 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5169             Tom Tromey  <tromey@adacore.com>
5170
5171         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5172
5173 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5174
5175         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5176         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5177         method to compute the bounds of range types. Also print "[evaluated]"
5178         if the bounds' values come from a dynamic evaluation.
5179
5180 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5181
5182         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5183         whitespace when pretty printing is on.
5184
5185 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5186
5187         * ppc-linux-nat.c: Add include.
5188
5189 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5190
5191         * NEWS: Mention AArch64 Pointer Authentication.
5192
5193 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5194
5195         * arm-linux-nat.c: Add include.
5196
5197 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5198
5199         * source-cache.c (source_cache::get_source_lines): Re-read
5200         fullname after calling open_source_file.
5201
5202 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5203
5204         * NEWS: Mention TLS support for FreeBSD.
5205
5206 2019-03-25  Tom Tromey  <tromey@adacore.com>
5207
5208         * minsyms.c (BUNCH_SIZE): Update comment.
5209         (~minimal_symbol_reader): Remove old comment.
5210         (compact_minimal_symbols): Update comment.
5211         (minimal_symbol_reader::install): Remove old comment.  Update
5212         other comments.
5213
5214 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5215
5216         * s390-linux-nat.c: Add include.
5217
5218 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5219
5220         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5221         Call linux_get_hwcap.
5222         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5223         Likewise.
5224         (aarch64_linux_get_hwcap): Remove function.
5225         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5226         declaration.
5227         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5228         linux_get_hwcap.
5229         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5230         * linux-tdep.c (linux_get_hwcap): Add function.
5231         (linux_get_hwcap2): Likewise.
5232         * linux-tdep.h (linux_get_hwcap): Add declaration.
5233         (linux_get_hwcap2): Likewise.
5234         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5235         (ppc_linux_get_hwcap2): Likewise.
5236         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5237         linux_get_hwcap.
5238         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5239         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5240         (ppc_linux_nat_target::read_description): Likewise.
5241         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5242         * s390-linux-nat.c: Likewise.
5243         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5244
5245 2019-03-24  Tom Tromey  <tom@tromey.com>
5246
5247         * ada-lang.c (standard_lookup): Simplify initialization.
5248         (ada_lookup_symbol_nonlocal): Simplify return.
5249         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5250         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5251         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5252         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5253         initialization.
5254         * solib.c (solib_global_lookup): Simplify.
5255         * symtab.c (null_block_symbol): Remove.
5256         (symbol_cache_lookup): Simplify returns.
5257         (lookup_language_this): Simplify returns.
5258         (lookup_symbol_aux): Simplify return.
5259         (lookup_local_symbol): Simplify returns.
5260         (lookup_global_symbol_from_objfile): Simplify return.
5261         (lookup_symbol_in_objfile_symtabs)
5262         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5263         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5264         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5265         * cp-namespace.c (cp_lookup_bare_symbol)
5266         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5267         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5268         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5269         (cp_lookup_symbol_via_imports): Simplify initialization.
5270         (find_symbol_in_baseclass): Likewise.
5271         * symtab.h (null_block_symbol): Remove.
5272         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5273         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5274         (d_lookup_symbol_module): Likewise.
5275         (find_symbol_in_baseclass): Simplify initialization.
5276
5277 2019-03-24  Tom Tromey  <tom@tromey.com>
5278
5279         * expression.h: Don't include symtab.h.
5280         (struct block): Forward declare.
5281
5282 2019-03-24  Tom Tromey  <tom@tromey.com>
5283
5284         * c-exp.y (typebase): Remove casts.
5285         * gdbtypes.c (lookup_unsigned_typename, )
5286         (lookup_signed_typename): Remove cast.
5287         * eval.c (parse_to_comma_and_eval): Remove cast.
5288         * parse.c (write_dollar_variable): Remove cast.
5289         * block.h (struct block) <superblock>: Now const.
5290         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5291         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5292         (map_block): Make "block" const.
5293         * symfile.h (struct quick_symbol_functions)
5294         <map_matching_symbols>: Constify block argument to "callback".
5295         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5296         const.
5297         (find_pc_sect_compunit_symtab): Make "b" const.
5298         (find_symbol_at_address): Likewise.
5299         (search_symbols): Likewise.
5300         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5301         (dw2_debug_names_lookup_symbol): Likewise.
5302         (dw2_map_matching_symbols): Update.
5303         * p-valprint.c (pascal_val_print): Remove "block".
5304         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5305         (aux_add_nonlocal_symbols): Make "block" const.
5306         (resolve_subexp): Remove cast.
5307         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5308         const.
5309         (iterate_over_file_blocks): Likewise.
5310         * f-exp.y (%union) <bval>: Remove.
5311         * coffread.c (patch_opaque_types): Make "b" const.
5312         * spu-tdep.c (spu_catch_start): Make "block" const.
5313         * c-valprint.c (print_unpacked_pointer): Remove "block".
5314         * symmisc.c (dump_symtab_1): Make "b" const.
5315         (block_depth): Make "block" const.
5316         * d-exp.y (%union) <bval>: Remove.
5317         * cp-support.h (cp_lookup_rtti_type): Update.
5318         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5319         * psymtab.c (psym_lookup_symbol): Make "block" const.
5320         (maintenance_check_psymtabs): Make "b" const.
5321         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5322         (enumerate_locals, enumerate_args): Update.
5323         * python/py-symtab.c (stpy_global_block): Make "block" const.
5324         (stpy_static_block): Likewise.
5325         * inline-frame.c (block_starting_point_at): Make "new_block"
5326         const.
5327         * block.c (find_block_in_blockvector): Make return type const.
5328         (blockvector_for_pc_sect): Make "b" const.
5329         (find_block_in_blockvector): Make "b" const.
5330
5331 2019-03-23  Tom Tromey  <tom@tromey.com>
5332
5333         * varobj.c (varobj_create): Update.
5334         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5335         * printcmd.c (display_command, do_one_display): Don't reset
5336         innermost_block.
5337         * parser-defs.h (enum innermost_block_tracker_type): Move to
5338         expression.h.
5339         (innermost_block): Update comment.
5340         * parse.c (parse_exp_1): Add tracker_types parameter.
5341         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5342         tracker_types parameter.  Reset innermost_block.
5343         (parse_exp_in_context): Remove.
5344         (parse_expression_for_completion): Update.
5345         * objfiles.c (~objfile): Don't reset expression_context_block or
5346         innermost_block.
5347         * expression.h (enum innermost_block_tracker_type): Move from
5348         parser-defs.h.
5349         (parse_exp_1): Add tracker_types parameter.
5350         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5351         reset innermost_block.
5352
5353 2019-03-23  Tom Tromey  <tom@tromey.com>
5354
5355         * objfiles.h: Include bcache.h.
5356
5357 2019-03-23  Tom Tromey  <tom@tromey.com>
5358
5359         * linespec.c (get_current_search_block): Use
5360         scoped_restore_current_language.
5361         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5362
5363 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5364             Jiong Wang  <jiong.wang@arm.com>
5365
5366         * aarch64-linux-tdep.c
5367         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5368         section.
5369         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5370
5371 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5372             Jiong Wang  <jiong.wang@arm.com>
5373
5374         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5375         instructions.
5376         (aarch64_analyze_prologue_test): Add PACIASP test.
5377         (aarch64_prologue_prev_register): Unmask PC value.
5378
5379 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5380             Jiong Wang  <jiong.wang@arm.com>
5381
5382         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5383         (aarch64_dwarf2_prev_register): Unmask PC value.
5384         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5385         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5386         DW_CFA_AARCH64_negate_ra_state.
5387         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5388
5389 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5390             Jiong Wang  <jiong.wang@arm.com>
5391
5392         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5393         registers.
5394         (aarch64_pseudo_register_name): Likewise.
5395         (aarch64_pseudo_register_type): Likewise.
5396         (aarch64_pseudo_register_reggroup_p): Likewise.
5397         (aarch64_gdbarch_init): Add pauth registers.
5398         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5399         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5400         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5401         (struct gdbarch_tdep): Add regnum for ra_state.
5402
5403 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5404             Jiong Wang  <jiong.wang@arm.com>
5405
5406         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5407
5408 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5409             Jiong Wang  <jiong.wang@arm.com>
5410
5411         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5412         function.
5413         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5414         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5415         (aarch64_gdbarch_init): Add puth registers.
5416         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5417         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5418         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5419
5420 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5421             Jiong Wang  <jiong.wang@arm.com>
5422
5423         * aarch64-linux-nat.c
5424         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5425         * aarch64-linux-tdep.c
5426         (aarch64_linux_core_read_description): Likewise.
5427         (aarch64_linux_get_hwcap): New function.
5428         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5429         (aarch64_linux_get_hwcap): New declaration.
5430
5431 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5432             Jiong Wang  <jiong.wang@arm.com>
5433
5434         * aarch64-linux-nat.c
5435         (aarch64_linux_nat_target::read_description): Add pauth param.
5436         * aarch64-linux-tdep.c
5437         (aarch64_linux_core_read_description): Likewise.
5438         * aarch64-tdep.c (struct target_desc): Add in pauth.
5439         (aarch64_read_description): Add pauth param.
5440         (aarch64_gdbarch_init): Likewise.
5441         * aarch64-tdep.h (aarch64_read_description): Likewise.
5442         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5443         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5444         * features/Makefile: Add new files.
5445         * features/aarch64-pauth.c: New file.
5446         * features/aarch64-pauth.xml: New file.
5447
5448 2019-03-20  Tom Tromey  <tromey@adacore.com>
5449
5450         * infrun.c (handle_inferior_event): Rename from
5451         handle_inferior_event_1.  Create a scoped_value_mark.
5452         (handle_inferior_event): Remove.
5453
5454 2019-03-19  Tom Tromey  <tromey@adacore.com>
5455
5456         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5457         * infrun.h (print_stop_event): Add "displays" parameter.
5458         * infrun.c (print_stop_event): Add "displays" parameter.
5459
5460 2019-03-19  Pedro Alves  <palves@redhat.com>
5461
5462         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5463         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5464         to -1.  Fix TABs vs spaces.
5465         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5466         * tui/tui-out.h (tui_ui_out) Add intro comments.
5467         <m_line, m_start_of_line>: In-class initialize, and add describing
5468         comment.
5469
5470 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5471
5472         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5473         variable names.
5474         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5475
5476 2019-03-18  Pedro Alves  <palves@redhat.com>
5477             Eli Zaretskii <eliz@gnu.org>
5478
5479         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5480         m_line and m_start_of_line.
5481
5482 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5483
5484         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5485         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5486         it returns a newline.  This fixes a regression in TU mode, whereby
5487         the next line is output on the same screen line as the user input.
5488
5489 2019-03-18  Tom Tromey  <tromey@adacore.com>
5490
5491         * minsyms.c (minimal_symbol_reader::install): Remove call to
5492         obstack_blank.
5493
5494 2019-03-18  Pedro Alves  <palves@redhat.com>
5495
5496         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5497         New globals.
5498         (apply_style): New, factored out from ...
5499         (apply_ansi_escape): ... this.  Handle reverse video mode.
5500         (tui_set_reverse_mode): New function.
5501         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5502         * tui/tui-winsource.c (tui_show_source_line): Use
5503         tui_set_reverse_mode instead of setting A_STANDOUT.
5504         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5505         New setter methods.
5506
5507 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5508
5509         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5510         Handle tabs.
5511
5512 2019-03-18  Tom Tromey  <tromey@adacore.com>
5513
5514         * ada-lang.c (empty_array): Add "high" parameter.
5515         (ada_evaluate_subexp): Update.
5516
5517 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5518
5519         * unittests/string_view-selftests.c: Define
5520         _initialize_string_view_selftests unconditionally.
5521
5522 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5523
5524         PR gdb/24350
5525         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5526
5527 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5528
5529         PR gdb/24351
5530         * windows-nat.c (display_selector): Fix format specifiers.
5531
5532 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5533
5534         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5535         tui_refill_source_window instead of tui_refresh_win, to update the
5536         current execution line.  This fixes redisplay of the current line
5537         when stepping through the code with "next" or "step".
5538
5539 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5540
5541         * source-cache.c (source_cache::get_source_lines): Call
5542         find_source_lines to initialize s->nlines.  This fixes vertical
5543         scrolling of TUI source window when the DOWN arrow is pressed.
5544
5545 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5546
5547         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5548         linux-thread-db.c (_initialize_thread_db): Likewise.
5549
5550 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5551
5552         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5553         wclrtoeol in tui_show_source_line".  This reverts changes made in
5554         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5555
5556 2019-03-15  Tom Tromey  <tom@tromey.com>
5557
5558         * symtab.h (struct minimal_symbol): Derive from
5559         general_symbol_info.
5560         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5561         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5562         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5563         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5564         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5565         (MSYMBOL_SEARCH_NAME): Update.
5566         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5567         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5568         * minsyms.c (minimal_symbol_reader::record_full): Update.
5569
5570 2019-03-15  Tom Tromey  <tom@tromey.com>
5571
5572         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5573
5574 2019-03-15  Tom Tromey  <tom@tromey.com>
5575
5576         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5577         unique_xmalloc_ptr.
5578         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5579         Update.
5580         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5581         (build_minimal_symbol_hash_tables)
5582         (minimal_symbol_reader::install): Update.
5583
5584 2019-03-15  Tom Tromey  <tom@tromey.com>
5585
5586         * symtab.c (create_demangled_names_hash): Update.
5587         (symbol_set_names): Update.
5588         * objfiles.h (struct objfile_per_bfd_storage)
5589         <demangled_names_hash>: Now an htab_up.
5590         * objfiles.c (objfile_per_bfd_storage): Simplify.
5591
5592 2019-03-15  Tom Tromey  <tom@tromey.com>
5593
5594         * objfiles.h (struct objfile_per_bfd_storage): Declare
5595         destructor.
5596         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5597         New.
5598         (get_objfile_bfd_data): Use new.  Don't initialize
5599         language_of_main.
5600         (free_objfile_per_bfd_storage): Remove.
5601         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5602
5603 2019-03-15  Tom Tromey  <tom@tromey.com>
5604
5605         * symfile.c (reread_symbols): Update.
5606         * objfiles.c (objfile::objfile): Update.
5607         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5608         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5609         comment.
5610         (minimal_symbol_reader::install): Update.
5611         (terminate_minimal_symbol_table): Remove.
5612         * jit.c (jit_object_close_impl): Update.
5613
5614 2019-03-15  Tom Tromey  <tom@tromey.com>
5615
5616         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5617         initializations.
5618
5619 2019-03-15  Tom Tromey  <tom@tromey.com>
5620
5621         * objfiles.h (struct objfile_per_bfd_storage)
5622         <demangled_hash_languages>: Now a bitset.
5623         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5624         (lookup_minimal_symbol): Update.
5625
5626 2019-03-15  Tom Tromey  <tom@tromey.com>
5627
5628         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5629         Don't return the symbol.
5630         * coffread.c (record_minimal_symbol): Use record_full.
5631
5632 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5633
5634         The MS-Windows port of ncurses fails to switch to a color pair if
5635         one or both of the colors are the implicit default colors.  This
5636         change records the default colors when TUI is initialized, and
5637         then specifies them explicitly when a color pair uses the default
5638         colors.  This allows color styling in TUI mode on MS-Windows.
5639
5640         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5641         ncurses_norm_attr.
5642         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5643         colors in ncurses_norm_attr.
5644         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5645         "none", replace it with the default color recorded in
5646         ncurses_norm_attr.
5647
5648 2019-03-14  Tom Tromey  <tromey@adacore.com>
5649
5650         * source-cache.h (class source_cache) <get_source_lines>: Return
5651         std::string.
5652         * source-cache.c (source_cache::extract_lines): Handle case where
5653         first_pos==npos.  Return std::string.
5654         (source_cache::get_source_lines): Update.
5655
5656 2019-03-14  Tom Tromey  <tromey@adacore.com>
5657
5658         * NEWS: Add item for "style sources" commands.
5659         * source-cache.c (source_cache::get_source_lines): Check
5660         source_styling.
5661         * cli/cli-style.c (source_styling): New global.
5662         (_initialize_cli_style): Add "style sources" commands.
5663         (show_style_sources): New function.
5664         * cli/cli-style.h (source_styling): Declare.
5665
5666 2019-03-14  Pedro Alves  <palves@redhat.com>
5667             Tom Tromey  <tromey@adacore.com>
5668
5669         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5670         * tui/tui-winsource.c (tui_refill_source_window): New function,
5671         from...
5672         (tui_horizontal_source_scroll): ... here.  Move some logic.
5673         * cli/cli-style.c (set_style_enabled): Notify new observable.
5674         * tui/tui-hooks.c (tui_redisplay_source): New function.
5675         (tui_attach_detach_observers): Attach or detach
5676         tui_redisplay_source.
5677         * observable.h (source_styling_changed): New observable.
5678         * observable.c: Define source_styling_changed observable.
5679
5680 2019-03-13  Tom Tromey  <tromey@adacore.com>
5681
5682         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5683         (i386_gnu_nat_target::store_registers): Update.
5684         * target-debug.h (target_debug_print_std_string): New macro.
5685         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5686         * windows-tdep.c (display_one_tib): Update.
5687         * tui/tui-stack.c (tui_make_status_line): Update.
5688         * top.c (print_inferior_quit_action): Update.
5689         * thread.c (thr_try_catch_cmd): Update.
5690         (add_thread_with_info): Update.
5691         (thread_target_id_str): Update.
5692         (thr_try_catch_cmd): Update.
5693         (thread_command): Update.
5694         (thread_find_command): Update.
5695         * record-btrace.c (record_btrace_target::info_record)
5696         (record_btrace_resume_thread, record_btrace_target::resume)
5697         (record_btrace_cancel_resume, record_btrace_step_thread)
5698         (record_btrace_target::wait, record_btrace_target::wait)
5699         (record_btrace_target::wait, record_btrace_target::stop): Update.
5700         * progspace.c (print_program_space): Update.
5701         * process-stratum-target.c
5702         (process_stratum_target::thread_address_space): Update.
5703         * linux-fork.c (linux_fork_mourn_inferior)
5704         (detach_checkpoint_command, info_checkpoints_command)
5705         (linux_fork_context): Update.
5706         (linux_fork_detach): Update.
5707         (class scoped_switch_fork_info): Update.
5708         (delete_checkpoint_command): Update.
5709         * infrun.c (follow_fork_inferior): Update.
5710         (follow_fork_inferior): Update.
5711         (proceed_after_vfork_done): Update.
5712         (handle_vfork_child_exec_or_exit): Update.
5713         (follow_exec): Update.
5714         (displaced_step_prepare_throw): Update.
5715         (displaced_step_restore): Update.
5716         (start_step_over): Update.
5717         (resume_1): Update.
5718         (clear_proceed_status_thread): Update.
5719         (proceed): Update.
5720         (print_target_wait_results): Update.
5721         (do_target_wait): Update.
5722         (context_switch): Update.
5723         (stop_all_threads): Update.
5724         (restart_threads): Update.
5725         (finish_step_over): Update.
5726         (handle_signal_stop): Update.
5727         (switch_back_to_stepped_thread): Update.
5728         (keep_going_pass_signal): Update.
5729         (print_exited_reason): Update.
5730         (normal_stop): Update.
5731         * inferior.c (inferior_pid_to_str): Change return type.
5732         (print_selected_inferior): Update.
5733         (add_inferior): Update.
5734         (detach_inferior): Update.
5735         * dummy-frame.c (fprint_dummy_frames): Update.
5736         * dcache.c (dcache_info_1): Update.
5737         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5738         (btrace_fetch, btrace_clear): Update.
5739         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5740         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5741         type.
5742         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5743         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5744         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5745         * gdbarch.c, gdbarch.h: Rebuild.
5746         * gdbarch.sh (core_pid_to_str): Change return type.
5747         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5748         return type.
5749         (windows_nat_target::pid_to_str): Change return type.
5750         (windows_delete_thread): Update.
5751         (windows_nat_target::attach): Update.
5752         (windows_nat_target::files_info): Update.
5753         * target-delegates.c: Rebuild.
5754         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5755         return type.
5756         (sol_thread_target::pid_to_str): Change return type.
5757         * remote.c (class remote_target) <pid_to_str>: Change return
5758         type.
5759         (remote_target::pid_to_str): Change return type.
5760         (extended_remote_target::attach, remote_target::remote_stop_ns)
5761         (remote_target::remote_notif_remove_queued_reply)
5762         (remote_target::push_stop_reply, remote_target::disable_btrace):
5763         Update.
5764         (extended_remote_target::attach): Update.
5765         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5766         type.
5767         (gdbsim_target::pid_to_str): Change return type.
5768         * ravenscar-thread.c (struct ravenscar_thread_target)
5769         <pid_to_str>: Change return type.
5770         (ravenscar_thread_target::pid_to_str): Change return type.
5771         * procfs.c (class procfs_target) <pid_to_str>: Change return
5772         type.
5773         (procfs_target::pid_to_str): Change return type.
5774         (procfs_target::attach): Update.
5775         (procfs_target::detach): Update.
5776         (procfs_target::fetch_registers): Update.
5777         (procfs_target::store_registers): Update.
5778         (procfs_target::wait): Update.
5779         (procfs_target::files_info): Update.
5780         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5781         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5782         return type.
5783         (nto_procfs_target::pid_to_str): Change return type.
5784         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5785         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5786         return type.
5787         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5788         (exit_lwp): Update.
5789         (attach_proc_task_lwp_callback, get_detach_signal)
5790         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5791         (linux_nat_target::resume, wait_lwp, stop_callback)
5792         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5793         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5794         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5795         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5796         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5797         type.
5798         (inf_ptrace_target::attach): Update.
5799         (inf_ptrace_target::files_info): Update.
5800         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5801         type.
5802         (go32_nat_target::pid_to_str): Change return type.
5803         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5804         (gnu_nat_target::wait): Update.
5805         (gnu_nat_target::wait): Update.
5806         (gnu_nat_target::resume): Update.
5807         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5808         (fbsd_nat_target::wait): Update.
5809         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5810         type.
5811         (darwin_nat_target::attach): Update.
5812         * corelow.c (class core_target) <pid_to_str>: Change return type.
5813         (core_target::pid_to_str): Change return type.
5814         * target.c (normal_pid_to_str): Change return type.
5815         (default_pid_to_str): Likewise.
5816         (target_pid_to_str): Change return type.
5817         (target_translate_tls_address): Update.
5818         (target_announce_detach): Update.
5819         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5820         return type.
5821         (bsd_uthread_target::pid_to_str): Change return type.
5822         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5823         type.
5824         (bsd_kvm_target::pid_to_str): Change return type.
5825         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5826         return type.
5827         (aix_thread_target::pid_to_str): Change return type.
5828         * target.h (struct target_ops) <pid_to_str>: Change return type.
5829         (target_pid_to_str, normal_pid_to_str): Likewise.
5830         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5831         type.
5832         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5833         type.
5834         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5835         return type.
5836         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5837         type.
5838         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5839         type.
5840         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5841         return type.
5842
5843 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5844
5845         * NEWS: Mention that the new default MI version is 3.  Mention
5846         changes to the output of commands and events that deal with
5847         multi-location breakpoints.
5848         * breakpoint.c: Include "mi/mi-out.h".
5849         (print_one_breakpoint): Change output syntax if using MI version
5850         >= 3.
5851         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5852         New.
5853         (mi_multi_location_breakpoint_output_fixed): New.
5854         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5855         (mi_cmd_fix_multi_location_breakpoint_output): New.
5856         (mi_multi_location_breakpoint_output_fixed): New.
5857         * mi/mi-cmds.c (mi_cmds): Register command
5858         -fix-multi-location-breakpoint-output.
5859         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5860         interpreter "mi".
5861
5862 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5863
5864         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5865         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5866         instantiate mi_ui_out based on interpreter name.
5867         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5868         * mi/mi-main.c (mi_load_progress): Likewise.
5869
5870 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5871
5872         * NEWS: Combine separate "New targets" sections for 8.3.
5873
5874 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5875
5876         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5877         (ppcfbsd_init_abi): Install gdbarch
5878         "fetch_tls_load_module_address" and "get_thread_local_address"
5879         methods.
5880
5881 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5882
5883         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5884         (riscv_fbsd_init_abi): Install gdbarch
5885         "fetch_tls_load_module_address" and "get_thread_local_address"
5886         methods.
5887
5888 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5889
5890         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5891         (i386fbsd_init_abi): Install gdbarch
5892         "fetch_tls_load_module_address" and "get_thread_local_address"
5893         methods.
5894
5895 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5896
5897         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5898         (amd64fbsd_init_abi): Install gdbarch
5899         "fetch_tls_load_module_address" and "get_thread_local_address"
5900         methods.
5901
5902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5903
5904         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5905         (struct fbsd_pspace_data): New type.
5906         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5907         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5908         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5909         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5910         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5911
5912 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5913
5914         * gdbtypes.c (lookup_struct_elt): New function.
5915         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5916         * gdbtypes.h (struct struct_elt): New type.
5917         (lookup_struct_elt): New prototype.
5918
5919 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5920
5921         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5922         remove disabled code block.
5923
5924 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5925
5926         * gdbarch.sh (get_thread_local_address): New method.
5927         * gdbarch.h, gdbarch.c: Regenerate.
5928         * target.c (target_translate_tls_address): Use
5929         gdbarch_get_thread_local_address if present instead of
5930         target::get_thread_local_address.
5931
5932 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5933
5934         * target.h (target::get_thread_local_address): Update comment.
5935
5936 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5937
5938         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5939         objfile->separate_debug_objfile_backlink if not NULL.
5940
5941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5942
5943         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5944         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5945         (amd64bsd_store_inferior_registers): Likewise.
5946         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5947         Enable segment base registers.
5948         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5949         PT_GETFSBASE and PT_GETGSBASE.
5950         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5951         PT_SETGSBASE.
5952         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5953         segment base registers.
5954         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5955
5956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5957
5958         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5959         Update calls to i386_target_description to add 'segments'
5960         parameter.
5961         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5962         add segment base registers.
5963         * arch/i386.c (i386_create_target_description): Add 'segments'
5964         parameter to enable segment base registers.
5965         * arch/i386.h (i386_create_target_description): Likewise.
5966         * features/i386/32bit-segments.xml: New file.
5967         * features/i386/32bit-segments.c: Generate.
5968         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5969         call to i386_target_description to add 'segments' parameter.
5970         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5971         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5972         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5973         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5974         if feature is present.
5975         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5976         Add 'segments' parameter to call to i386_target_description.
5977         (i386_target_description): Add 'segments' parameter to enable
5978         segment base registers.
5979         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5980         to call to i386_target_description.
5981         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5982         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5983         Define I386_NUM_REGS.
5984         (i386_target_description): Add 'segments' parameter to enable
5985         segment base registers.
5986
5987 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5988
5989         PR/24325
5990         * source-cache.c: #undef open and close, to avoid unresolved
5991         externals during linking.
5992
5993 2019-03-12  Tom Tromey  <tromey@adacore.com>
5994
5995         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5996         const.  Add initializers.
5997         (_initialize_remote): Don't initialize ptid globals.
5998
5999 2019-03-12  Pedro Alves  <palves@redhat.com>
6000
6001         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6002
6003 2019-03-12  Pedro Alves  <palves@redhat.com>
6004
6005         * cp-name-parser.y (main): Remove unused 'len' variable.
6006
6007 2019-03-12  Tom Tromey  <tromey@adacore.com>
6008
6009         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6010         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6011
6012 2019-03-12  Tom Tromey  <tromey@adacore.com>
6013
6014         * linux-nat.c (iterate_over_lwps): Update.
6015         (stop_callback): Remove parameter.
6016         (stop_wait_callback, detach_callback, resume_set_callback)
6017         (select_singlestep_lwp_callback, set_ignore_sigint)
6018         (status_callback, resumed_callback, resume_clear_callback)
6019         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6020         data parameter.
6021         (linux_nat_target::detach, linux_nat_target::resume)
6022         (linux_stop_and_wait_all_lwps, select_event_lwp)
6023         (linux_nat_filter_event, linux_nat_wait_1)
6024         (linux_nat_target::kill, linux_nat_target::stop)
6025         (linux_nat_target::stop): Update.
6026         (linux_nat_resume_callback): Change type.
6027         (resume_stopped_resumed_lwps, count_events_callback)
6028         (select_event_lwp_callback): Likewise.
6029         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6030         * arm-linux-nat.c (struct update_registers_data): Remove.
6031         (update_registers_callback): Change type.
6032         (arm_linux_insert_hw_breakpoint1): Update.
6033         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6034         parameter.
6035         (x86_linux_dr_set_addr): Update.
6036         (x86_linux_dr_set_control): Update.
6037         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6038         (iterate_over_lwps): Use gdb::function_view.
6039         * nat/aarch64-linux-hw-point.c (struct
6040         aarch64_dr_update_callback_param): Remove.
6041         (debug_reg_change_callback): Change type.
6042         (aarch64_notify_debug_reg_change): Update.
6043         * s390-linux-nat.c (s390_refresh_per_info): Update.
6044
6045 2019-03-11  Tom Tromey  <tromey@adacore.com>
6046
6047         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6048         redundant assignment to "this_cu".
6049
6050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6051
6052         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6053
6054 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6055
6056         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6057         from...
6058         (rank_one_type): ... this.
6059
6060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6061
6062         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6063         from...
6064         (rank_one_type): ... this.
6065
6066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6067
6068         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6069         from...
6070         (rank_one_type): ... this.
6071
6072 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6073
6074         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6075         from...
6076         (rank_one_type): ... this.
6077
6078 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6079
6080         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6081         from...
6082         (rank_one_type): ... this.
6083
6084 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6085
6086         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6087         from...
6088         (rank_one_type): ... this.
6089
6090 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6091
6092         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6093         from...
6094         (rank_one_type): ... this.
6095
6096 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6097
6098         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6099         from...
6100         (rank_one_type): ... this.
6101
6102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6103
6104         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6105         from...
6106         (rank_one_type): ... this.
6107
6108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6109
6110         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6111         from...
6112         (rank_one_type): ... this.
6113
6114 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6115
6116         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6117         from...
6118         (rank_one_type): ... this.
6119
6120 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6121
6122         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6123         from...
6124         (rank_one_type): ... this.
6125
6126 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6127
6128         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6129         inferior-events' shows the example events.
6130
6131 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6132
6133         Support styling on native MS-Windows console
6134
6135         PR/24315
6136         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6137         on MS-Windows if $TERM is not defined.
6138
6139         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6140
6141         * posix-hdep.c (gdb_console_fputs):
6142         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6143         functions.
6144         * ui-file.h (gdb_console_fputs): Add prototype.
6145
6146         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6147         back to fputs only if the former returns zero.
6148
6149 2019-03-07  Tom Tromey  <tom@tromey.com>
6150
6151         * symmisc.c (print_symbol_bcache_statistics): Update.
6152         (print_objfile_statistics): Update.
6153         * symfile.c (allocate_symtab): Update.
6154         * stabsread.c: Don't include bcache.h.
6155         * psymtab.h (struct psymbol_bcache): Don't declare.
6156         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6157         (psymbol_bcache_init, psymbol_bcache_free)
6158         (psymbol_bcache_get_bcache): Don't declare.
6159         * psymtab.c (struct psymbol_bcache): Remove.
6160         (psymtab_storage::psymtab_storage): Update.
6161         (psymtab_storage::~psymtab_storage): Update.
6162         (psymbol_bcache_init, psymbol_bcache_free)
6163         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6164         (add_psymbol_to_bcache): Update.
6165         (allocate_psymtab): Update.
6166         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6167         macro_cache>: No longer pointers.
6168         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6169         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6170         * macrotab.c (macro_bcache): Update.
6171         * macroexp.c: Don't include bcache.h.
6172         * gdbtypes.c (check_types_worklist): Update.
6173         (types_deeply_equal): Remove TRY/CATCH.  Update.
6174         * elfread.c (elf_symtab_read): Update.
6175         * dwarf2read.c: Don't include bcache.h.
6176         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6177         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6178         (print_bcache_statistics, bcache_memory_used): Don't declare.
6179         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6180         methods.  Rename all data members.
6181         * bcache.c (struct bcache): Move to bcache.h.
6182         (bcache::expand_hash_table): Rename from expand_hash_table.
6183         (bcache): Remove.
6184         (bcache::insert): Rename from bcache_full.
6185         (bcache::compare): Rename from bcache_compare.
6186         (bcache_xmalloc): Remove.
6187         (bcache::~bcache): Rename from bcache_xfree.
6188         (bcache::print_statistics): Rename from print_bcache_statistics.
6189         (bcache::memory_used): Rename from bcache_memory_used.
6190
6191 2019-03-07  Pedro Alves  <palves@redhat.com>
6192
6193         * infrun.c (normal_stop): Also check for
6194         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6195
6196 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6197
6198         * f-lang.c (value_from_host_double): Moved to...
6199         * value.c (value_from_host_double): ...here.
6200         * value.h (value_from_host_double): Declare.
6201         * guile/scm-math.c (vlscm_convert_typed_number): Use
6202         value_from_host_double.
6203         (vlscm_convert_number): Likewise.
6204         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6205         * python/py-value.c (convert_value_from_python): Likewise.
6206
6207 2019-03-06  Tom Tromey  <tom@tromey.com>
6208
6209         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6210
6211 2019-03-06  Tom Tromey  <tom@tromey.com>
6212
6213         * utils.h (free_current_contents): Don't declare.
6214         * utils.c (free_current_contents): Remove.
6215
6216 2019-03-06  Tom Tromey  <tom@tromey.com>
6217
6218         * top.c (quit_force): Update.
6219         * main.c (captured_command_loop): Update.
6220         * common/new-op.c (operator new): Update.
6221         * common/common-exceptions.c (struct catcher)
6222         <save_cleanup_chain>: Remove member.
6223         (exceptions_state_mc_init): Update.
6224         (exception_try_scope_entry): Return nullptr.
6225         (exception_try_scope_exit, exception_rethrow)
6226         (throw_exception_sjlj, throw_exception_cxx): Update.
6227         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6228         (all_cleanups, do_cleanups, discard_cleanups)
6229         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6230         (restore_cleanups, restore_final_cleanups): Don't declare.
6231         (do_final_cleanups): Remove parameter.
6232         * common/cleanups.c (cleanup_chain, make_cleanup)
6233         (make_cleanup_dtor, all_cleanups, do_cleanups)
6234         (discard_my_cleanups, discard_cleanups)
6235         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6236         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6237         (null_cleanup): Remove.
6238         (do_final_cleanups): Remove parameter.
6239
6240 2019-03-06  Tom Tromey  <tom@tromey.com>
6241
6242         * remote.c (remote_target::remote_parse_stop_reply): Use
6243         unique_xmalloc_ptr.
6244
6245 2019-03-06  Tom Tromey  <tom@tromey.com>
6246
6247         * stabsread.c (struct stabs_field_info): Rename from field_info.
6248         <list, fnlist>: Add initializers.
6249         <obstack>: New member.
6250         (read_member_functions, read_struct_fields, read_baseclasses):
6251         Allocate on obstack.  Don't use cleanups.
6252         (read_one_struct_field, read_member_functions, read_struct_fields)
6253         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6254         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6255         (read_struct_type): Update.
6256
6257 2019-03-06  Tom Tromey  <tom@tromey.com>
6258
6259         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6260         * common/filestuff.h (make_cleanup_close): Don't declare.
6261         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6262         Remove.
6263
6264 2019-03-06  Tom Tromey  <tom@tromey.com>
6265
6266         * solib-aix.c: Use make_scope_exit.
6267
6268 2019-03-06  Tom Tromey  <tom@tromey.com>
6269
6270         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6271         Use make_scope_exit.
6272
6273 2019-03-06  Tom Tromey  <tom@tromey.com>
6274
6275         * solib-svr4.c (disable_probes_interface): Remove parameter.
6276         (svr4_handle_solib_event): Use make_scope_exit.
6277
6278 2019-03-06  Tom Tromey  <tom@tromey.com>
6279
6280         * remote.c (struct stop_reply_deleter): Remove.
6281         (stop_reply_up): Update.
6282         (struct stop_reply): Derive from notif_event.  Don't typedef.
6283         <regcache>: Now a std::vector.
6284         (stop_reply_xfree): Remove.
6285         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6286         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6287         (remote_target::discard_pending_stop_replies): Use delete.
6288         (remote_target::remote_parse_stop_reply): Update.
6289         (remote_target::process_stop_reply): Update.
6290         * remote-notif.h (struct notif_event): Add virtual destructor.
6291         Remove "dtr" member.
6292         (struct notif_client) <alloc_event>: Return a unique_ptr.
6293         (notif_event_xfree): Don't declare.
6294         (notif_event_up): New typedef.
6295         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6296         (notif_event_xfree, do_notif_event_xfree): Remove.
6297         (remote_notif_state_xfree): Update.
6298
6299 2019-03-06  Tom Tromey  <tom@tromey.com>
6300
6301         * infrun.c (displaced_step_clear_cleanup): Now a
6302         forward_scope_exit type.
6303         (displaced_step_prepare_throw): Update.
6304         (displaced_step_fixup): Update.
6305
6306 2019-03-06  Tom Tromey  <tom@tromey.com>
6307
6308         * inferior.h (class inferior): Update comment.
6309         * gdbthread.h (class thread_info): Update comment.
6310
6311 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6312             Tom Tromey  <tom@tromey.com>
6313
6314         * stabsread.h (struct stab_section_list): Remove.
6315         (coffstab_build_psymtabs): Update.
6316         * dbxread.c (symbuf_sections): Now a std::vector.
6317         (sect_idx): New global.
6318         (fill_symbuf): Update.
6319         (coffstab_build_psymtabs): Change type of stabsects parameter.
6320         Update.
6321         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6322         std::vector.
6323         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6324         (coff_locate_sections): Update.
6325         (coff_symfile_read): Remove cleanups.  Update.
6326         (init_stringtab): Add storage parameter.
6327         (free_stringtab, free_stringtab_cleanup): Remove.
6328         (init_lineno): Add storage parameter.
6329         (free_linetab, free_linetab_cleanup): Remove.
6330
6331 2019-03-06  Pedro Alves  <palves@redhat.com>
6332
6333         * linux-fork.c (fork_info::clobber_regs): Delete.
6334         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6335         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6336         comment.  Adjust.
6337         (scoped_switch_fork_info::scoped_switch_fork_info)
6338         (checkpoint_command, linux_fork_context): Adjust
6339         fork_save_infrun_state calls.
6340
6341 2019-03-06  Pedro Alves  <palves@redhat.com>
6342
6343         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6344         (inf_has_multiple_threads): Return 'bool' and rewrite using
6345         inferior_info::threads().
6346
6347 2019-03-06  Pedro Alves  <palves@redhat.com>
6348
6349         * linux-fork.c: Include <list>.
6350         (fork_list): Now a std::list instance.
6351         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6352         (forks_exist_p, find_last_fork): Adjust.
6353         (new_fork): Delete.
6354         (one_fork_p): New.
6355         (add_fork): Adjust.
6356         (free_fork): Delete, folded into fork_info::~fork_info().
6357         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6358         Adjust.
6359         (init_fork_list): Delete.
6360         (linux_fork_killall, linux_fork_mourn_inferior)
6361         (linux_fork_detach, info_checkpoints_command): Adjust.
6362         (_initialize_linux_fork): No longer call init_fork_list.
6363
6364 2019-03-06  Pedro Alves  <palves@redhat.com>
6365
6366         * linux-fork.c (new_fork): New, split out of ...
6367         (add_fork): ... this.  Return void.  Move "first fork" special
6368         case from here, to ...
6369         (checkpoint_command): ... here.
6370         * linux-linux.h (add_fork): Return void.
6371
6372 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6373
6374         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6375
6376 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6377             Chris January  <chris.january@arm.com>
6378             David Lecomber  <david.lecomber@arm.com>
6379
6380         * f-exp.y: New token, UNOP_INTRINSIC.
6381         (exp): New pattern using UNOP_INTRINSIC token.
6382         (f77_keywords): Add 'abs' keyword.
6383         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6384         (value_from_host_double): New function.
6385         (evaluate_subexp_f): Support UNOP_ABS.
6386
6387 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6388
6389         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6390         types.
6391
6392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6393
6394         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6395         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6396         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6397
6398 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6399
6400         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6401
6402 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6403             Chris January  <chris.january@arm.com>
6404
6405         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6406         * f-exp.y: Define 'KIND' token.
6407         (exp): New pattern for KIND expressions.
6408         (ptype): Handle types with a kind extension.
6409         (direct_abs_decl): Extend to spot kind extensions.
6410         (f77_keywords): Add 'kind' to the list.
6411         (push_kind_type): New function.
6412         (convert_to_kind_type): New function.
6413         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6414         * parse.c (operator_length_standard): Likewise.
6415         * parser-defs.h (enum type_pieces): Add tp_kind.
6416         * std-operator.def: Add UNOP_KIND.
6417
6418 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6419
6420         * f-exp.y (f_parse): Set yydebug.
6421
6422 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6423
6424         * f-lang.c (evaluate_subexp_f): New function.
6425         (exp_descriptor_f): New global.
6426         (f_language_defn): Use exp_descriptor_f instead of
6427         exp_descriptor_standard.
6428
6429 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6430
6431         * f-exp.y (struct token): Add comments.
6432         (dot_ops): Remove uppercase versions and the end marker.
6433         (f77_keywords): Likewise.
6434         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6435         entries in the dot_ops array are case insensitive, and use
6436         strncasecmp to compare strings.  Also some whitespace cleanup in
6437         this area.  Similar for the f77_keywords array, except entries in
6438         this list might be case sensitive.
6439
6440 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6441
6442         * f-exp.y (struct f77_boolean_val): Add comments.
6443         (boolean_values): Remove uppercase versions, and end marker.
6444         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6445         and use strncasecmp to achieve case insensitivity.  Additionally,
6446         perform whitespace cleanup around this code.
6447
6448 2019-03-06  Tom Tromey  <tromey@adacore.com>
6449
6450         * remote-sim.c (gdbsim_target_open): Use result of
6451         gdb_argv::release.
6452
6453 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6454         Dirk Schubert  <dirk.schubert@arm.com>
6455         Chris January  <chris.january@arm.com>
6456
6457         * eval.c (evaluate_subexp_standard): Call Fortran argument
6458         wrapping logic.
6459         * f-lang.c (struct value): A value which can be passed into a
6460         Fortran function call.
6461         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6462         where appropriate.
6463         (struct type): Value ready for a Fortran function call.
6464         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6465         is needed.
6466         * f-lang.h (fortran_argument_convert): Declaration.
6467         (fortran_preserve_arg_pointer): Declaration.
6468         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6469
6470 2019-03-05  Tom Tromey  <tromey@adacore.com>
6471
6472         * python/py-prettyprint.c (print_string_repr): Remove #if.
6473         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6474
6475 2019-03-05  Tom Tromey  <tromey@adacore.com>
6476
6477         * target.c (the_dummy_target): Move later.  Change type to
6478         "dummy_target".
6479         (initialize_targets): Don't initialize the_dummy_target.
6480
6481 2019-03-05  Tom Tromey  <tromey@adacore.com>
6482
6483         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6484         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6485
6486 2019-03-05  Tom Tromey  <tromey@adacore.com>
6487
6488         * windows-nat.c (windows_nat_target::attach)
6489         (windows_nat_target::detach): Don't call gdb_flush.
6490         * valprint.c (generic_val_print, val_print, val_print_string):
6491         Don't call gdb_flush.
6492         * utils.c (defaulted_query): Don't call gdb_flush.
6493         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6494         * target.c (target_announce_detach): Don't call gdb_flush.
6495         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6496         * remote.c (extended_remote_target::attach): Don't call
6497         gdb_flush.
6498         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6499         * printcmd.c (do_examine): Don't call gdb_flush.
6500         (info_display_command): Don't call gdb_flush.
6501         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6502         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6503         * memattr.c (info_mem_command): Don't call gdb_flush.
6504         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6505         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6506         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6507         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6508         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6509         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6510         (gnu_nat_target::detach): Don't call gdb_flush.
6511         * f-valprint.c (f_val_print): Don't call gdb_flush.
6512         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6513         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6514         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6515         gdb_flush.
6516         * c-valprint.c (c_val_print): Don't call gdb_flush.
6517         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6518
6519 2019-03-05  Tom Tromey  <tromey@adacore.com>
6520
6521         * varobj.c (update_dynamic_varobj_children): Update.
6522         (install_default_visualizer): Use reset, not release.
6523         * value.c (set_internalvar): Update.
6524         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6525         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6526         ATTRIBUTE_UNUSED_RESULT.
6527
6528 2019-03-05  Tom Tromey  <tromey@adacore.com>
6529
6530         * remote.c (class scoped_remote_fd) <release>: Add
6531         ATTRIBUTE_UNUSED_RESULT.
6532
6533 2019-03-05  Tom Tromey  <tromey@adacore.com>
6534
6535         * macroexp.c (struct macro_buffer) <release>: Add
6536         ATTRIBUTE_UNUSED_RESULT.
6537
6538 2019-03-05  Tom Tromey  <tromey@adacore.com>
6539
6540         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6541         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6542         ATTRIBUTE_UNUSED_RESULT.
6543
6544 2019-03-05  Tom Tromey  <tromey@adacore.com>
6545
6546         * common/scoped_fd.h (class scoped_fd) <release>: Add
6547         ATTRIBUTE_UNUSED_RESULT.
6548
6549 2019-03-05  Tom Tromey  <tromey@adacore.com>
6550
6551         * parser-defs.h (struct parser_state) <release>: Add
6552         ATTRIBUTE_UNUSED_RESULT.
6553
6554 2019-03-05  Tom Tromey  <tromey@adacore.com>
6555
6556         * utils.h (class gdb_argv) <release>: Add
6557         ATTRIBUTE_UNUSED_RESULT.
6558         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6559
6560 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6561
6562         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6563         for-loop range, to avoid compiler warnings.
6564
6565         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6566         avoid compiler warnings about unused variables.
6567
6568         * NEWS: Mention end of support for native debugging on MS-Windows
6569         before XP.
6570
6571         PR gdb/24292
6572         * common/netstuff.c:
6573         * gdbserver/gdbreplay.c
6574         * gdbserver/remote-utils.c:
6575         * ser-tcp.c:
6576         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6577         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6578         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6579         'getaddrinfo' and 'freeaddrinfo' were not available before
6580         Windows XP, and mingw.org's MinGW headers by default define
6581         _WIN32_WINNT to 0x500.
6582
6583 2019-03-01  Gary Benson <gbenson@redhat.com>
6584
6585         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6586
6587 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6588             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6589
6590         PR gdb/8527
6591         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6592         set_sigint_trap, clear_sigint_trap.
6593
6594 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6595
6596         * target.c (target_detach): Clear the regcache and the
6597         frame cache.
6598
6599 2019-02-27  Pedro Alves  <palves@redhat.com>
6600
6601         * utils.c (set_screen_size): When we cap the height/width sizes,
6602         tweak the corresponding command variable to show "unlimited":
6603
6604 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6605             Pedro Alves  <palves@redhat.com>
6606
6607         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6608         before calling rl_set_screen_size.
6609
6610 2019-02-27  Tom Tromey  <tromey@adacore.com>
6611
6612         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6613         define.
6614         * python/py-value.c: Remove Python 2.4 workaround.
6615         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6616         workaround.
6617         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6618         Python 2.4 workaround.
6619         * python/python-internal.h: Remove Python 2.4 comment.
6620         (Py_ssize_t): Don't define.
6621         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6622         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6623         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6624         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6625         * python/python.c (do_start_initialization): Remove Python 2.4
6626         workaround.
6627         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6628         (print_children): Remove Python 2.4 workaround.
6629         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6630         workaround.
6631         (CHARBUFFERPROC_NAME): Remove.
6632         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6633         Python 2.4 workaround.
6634
6635 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6636
6637         * NEWS: Note minimum Python version.
6638
6639 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6640
6641         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6642         code from these functions.  Remove corresponding ifdefs.  Use
6643         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6644         Remove gotos and target of gotos.
6645         (infpy_search_memory): Likewise.
6646
6647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6648
6649         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6650         (hppa_gdbarch_init): Don't register deleted functions with
6651         gdbarch.
6652
6653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6654
6655         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6656         (h8300_unwind_sp): Delete.
6657         (h8300_dummy_id): Delete.
6658         (h8300_gdbarch_init): Don't register deleted functions with
6659         gdbarch.
6660
6661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6662
6663         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6664         (ft32_unwind_pc): Delete.
6665         (ft32_unwind_sp): Delete.
6666         (ft32_gdbarch_init): Don't register deleted functions with
6667         gdbarch.
6668
6669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6670
6671         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6672         (frv_unwind_pc): Delete.
6673         (frv_unwind_sp): Delete.
6674         (frv_gdbarch_init): Don't register deleted functions with
6675         gdbarch.
6676
6677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6678
6679         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6680         (riscv_unwind_pc): Delete.
6681         (riscv_unwind_sp): Delete.
6682         (riscv_gdbarch_init): Don't register deleted functions with
6683         gdbarch.
6684
6685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6686
6687         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6688         (csky_unwind_pc): Delete.
6689         (csky_unwind_sp): Delete.
6690         (csky_gdbarch_init): Don't register deleted functions with
6691         gdbarch.
6692
6693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6694
6695         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6696         (cris_unwind_pc): Delete.
6697         (cris_unwind_sp): Delete.
6698         (cris_gdbarch_init): Don't register deleted functions with
6699         gdbarch.
6700
6701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6702
6703         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6704         (bfin_unwind_pc): Delete.
6705         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6706
6707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6708
6709         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6710         (arm_unwind_pc): Delete.
6711         (arm_unwind_sp): Delete.
6712         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6713
6714 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6715
6716         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6717         (arc_unwind_pc): Delete.
6718         (arc_unwind_sp): Delete.
6719         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6720
6721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6722
6723         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6724         (alpha_unwind_pc): Delete.
6725         (alpha_gdbarch_init): Don't register deleted functions with
6726         gdbarch.
6727
6728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6729
6730         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6731         (aarch64_unwind_pc): Delete.
6732         (aarch64_unwind_sp): Delete.
6733         (aarch64_gdbarch_init): Don't register deleted functions with
6734         gdbarch.
6735
6736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6737
6738         * gdbtypes.c (type_align): Don't consider static members when
6739         computing structure alignment.
6740
6741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6742
6743         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6744         return 0 for other types.
6745         * arch-utils.c (default_type_align): Always return 0.
6746         * gdbarch.h: Regenerate.
6747         * gdbarch.sh (type_align): Extend comment.
6748         * gdbtypes.c (type_align): Add additional comments, always call
6749         gdbarch_type_align before applying the default rules.
6750         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6751         generic code will then apply a suitable default.
6752         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6753         types, return 0 for other types.
6754
6755 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6756
6757         * NEWS: Create a new section for the next release branch.
6758         Rename the section of the current branch, now that it has
6759         been cut.
6760
6761 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6762
6763         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6764         * version.in: Bump version to 8.3.50.DATE-git.
6765
6766 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6767
6768         * aix-thread.c (ptid_cmp): Remove unused variable.
6769         (get_signaled_thread): Likewise.
6770         (store_regs_user_thread): Likewise.
6771         (store_regs_kernel_thread): Likewise.
6772         (fetch_regs_kernel_thread): Remove shadowed variable.
6773
6774 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6775
6776         * features/riscv/32bit-cpu.xml: Add register numbers.
6777         * features/riscv/32bit-fpu.c: Regenerate.
6778         * features/riscv/32bit-fpu.xml: Add register numbers.
6779         * features/riscv/64bit-cpu.xml: Add register numbers.
6780         * features/riscv/64bit-fpu.c: Regenerate.
6781         * features/riscv/64bit-fpu.xml: Add register numbers.
6782
6783 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6784
6785         * NEWS: Mention two argument form of gdb.Value constructor.
6786         * python/py-value.c (convert_buffer_and_type_to_value): New
6787         function.
6788         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6789         Add support for handling an optional second argument.  Call
6790         convert_buffer_and_type_to_value as appropriate.
6791         * python/python-internal.h (Py_buffer_deleter): New struct.
6792         (Py_buffer_up): New typedef.
6793
6794 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6795
6796         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6797         instead of releasing ownership.
6798
6799 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6800
6801         * dwarf2read.c (open_and_init_dwp_file): Call
6802         elf_numsections instead of bfd_count_sections to initialize
6803         dwp_file->num_sections.
6804
6805 2019-02-25  Tom Tromey  <tromey@adacore.com>
6806
6807         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6808
6809 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6810
6811         * gcore.in: Add '--readnever' option when invoking GDB.
6812
6813 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6814
6815         * MAINTAINERS: Update my email address.
6816
6817 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6818
6819         * build-id.c (build_id_to_debug_bfd_1): New function.
6820         (build_id_to_debug_bfd): Look for separate debug file in
6821         sysroot.
6822
6823 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6824
6825         * gdbarch.sh: Update the copyright year range that is placed into
6826         generated files.
6827
6828 2019-02-22  Keith Seitz  <keiths@redhat.com>
6829
6830         PR symtab/23853
6831         * linespec.c (create_sals_line_offset): Search for the default
6832         symtab's filename instead of its fullname.
6833
6834 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6835
6836         * NEWS: Update style defaults.
6837
6838 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6839
6840         * main.c (captured_main_1): Disable styling in batch mode.
6841
6842 2019-02-20  Tom Tromey  <tom@tromey.com>
6843
6844         * symtab.c (symtab_symbol_info): Fix typos.
6845
6846 2019-02-20  Tom Tromey  <tromey@adacore.com>
6847
6848         * findcmd.c (_initialize_mem_search): Use upper case for
6849         metasyntactic variables.
6850
6851 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6852
6853         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6854         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6855
6856 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6857
6858         * top.h (source_file_name): Change to std::string.
6859         * top.c (source_file_name): Likewise.
6860         (command_line_input): Adjust.
6861         * cli/cli-script.c (script_from_file): Adjust.
6862
6863 2019-02-19  Tom Tromey  <tromey@adacore.com>
6864
6865         * ravenscar-thread.c
6866         (ravenscar_thread_target::update_thread_list): Don't call
6867         ada_build_task_list.
6868         * ada-lang.h (ada_build_task_list): Don't declare.
6869         * ada-tasks.c (struct ada_tasks_inferior_data)
6870         <task_list_valid_p>: Now bool.
6871         (read_known_tasks, ada_task_list_changed)
6872         (ada_tasks_invalidate_inferior_data): Update.
6873         (read_known_tasks_array): Return bool.
6874         (read_known_tasks_list): Likewise.
6875         (read_known_tasks): Return void.
6876         (ada_build_task_list): Now static.
6877
6878 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6879
6880         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6881         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6882
6883 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6884
6885         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6886         variant for ada_tasks_pspace_data_handle and
6887         ada_tasks_inferior_data_handle.
6888         (ada_tasks_pspace_data_cleanup): New function.
6889         (ada_tasks_inferior_data_cleanup): New function.
6890
6891 2019-02-17  Tom Tromey  <tom@tromey.com>
6892
6893         * macrotab.h (macro_source_fullname): Return a std::string.
6894         * macrotab.c (macro_include, check_for_redefinition)
6895         (macro_undef, macro_lookup_definition, foreach_macro)
6896         (foreach_macro_in_scope): Update.
6897         (macro_source_fullname): Return a std::string.
6898         * macrocmd.c (show_pp_source_pos): Update.
6899
6900 2019-02-17  Tom Tromey  <tom@tromey.com>
6901
6902         * macrocmd.c (show_pp_source_pos): Style the file names.
6903
6904 2019-02-17  Tom Tromey  <tom@tromey.com>
6905
6906         PR tui/24197:
6907         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6908
6909 2019-02-17  Tom Tromey  <tom@tromey.com>
6910
6911         * ada-lang.c (user_select_syms): Use filtered printing.
6912         * utils.c (wrap_style): New global.
6913         (desired_style): Remove.
6914         (emit_style_escape): Add stream parameter.
6915         (set_output_style, reset_terminal_style, prompt_for_continue):
6916         Update.
6917         (flush_wrap_buffer): Only flush gdb_stdout.
6918         (wrap_here): Set wrap_style.
6919         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6920         treat escape sequences as a character.  Change when wrap buffer is
6921         flushed.
6922         (fputs_styled): Do not set the output style when the default is
6923         requested.
6924         * ui-style.h (struct ui_file_style) <is_default>: New method.
6925         * source.c (print_source_lines_base): Emit escape sequences in one
6926         piece.
6927
6928 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6929
6930         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6931         integers and enumeration types.
6932
6933 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6934
6935         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6936         instead of lookup_symbol_in_language
6937         (do_exact_match): New function.
6938         (ada_get_symbol_name_matcher): Return do_exact_match when
6939         doing a verbatim match.
6940
6941 2019-02-15  Tom Tromey  <tromey@adacore.com>
6942
6943         * ravenscar-thread.c (ravenscar_thread_target::resume)
6944         (ravenscar_thread_target::wait): Special case wildcard requests.
6945
6946 2019-02-15  Tom Tromey  <tromey@adacore.com>
6947
6948         * ravenscar-thread.c (base_ptid): Remove.
6949         (struct ravenscar_thread_target) <close>: New method.
6950         <m_base_ptid>: New member.
6951         <update_inferior_ptid, active_task, task_is_currently_active,
6952         runtime_initialized>: Declare methods.
6953         <ravenscar_thread_target>: Add constructor.
6954         (ravenscar_thread_target::task_is_currently_active)
6955         (ravenscar_thread_target::update_inferior_ptid)
6956         (ravenscar_runtime_initialized): Rename.  Now methods.
6957         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6958         (ravenscar_thread_target::update_thread_list): Update.
6959         (ravenscar_thread_target::active_task): Now method.
6960         (ravenscar_thread_target::store_registers)
6961         (ravenscar_thread_target::prepare_to_store)
6962         (ravenscar_thread_target::prepare_to_store)
6963         (ravenscar_thread_target::mourn_inferior): Update.
6964         (ravenscar_inferior_created): Use "new" to create target.
6965         (ravenscar_thread_target::get_ada_task_ptid): Update.
6966         (_initialize_ravenscar): Don't initialize base_ptid.
6967         (ravenscar_ops): Remove global.
6968
6969 2019-02-15  Tom Tromey  <tromey@adacore.com>
6970
6971         * target.h (push_target): Declare new overload.
6972         * target.c (push_target): New overload, taking an rvalue reference.
6973         * remote.c (remote_target::open_1): Use push_target overload.
6974         * corelow.c (core_target_open): Use push_target overload.
6975
6976 2019-02-15  Tom Tromey  <tromey@adacore.com>
6977
6978         * ravenscar-thread.c (is_ravenscar_task)
6979         (ravenscar_task_is_currently_active): Return bool.
6980         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6981         (_initialize_ravenscar): Remove "(void)".
6982         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6983         Return bool.
6984
6985 2019-02-15  Tom Tromey  <tromey@adacore.com>
6986
6987         * ravenscar-thread.c (ravenscar_runtime_initializer)
6988         (has_ravenscar_runtime, get_running_thread_id)
6989         (ravenscar_thread_target::resume): Fix indentation.
6990
6991 2019-02-15  Tom Tromey  <tromey@adacore.com>
6992
6993         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6994         from ravenscar_arch_ops.
6995         (sparc_ravenscar_ops::fetch_registers)
6996         (sparc_ravenscar_ops::store_registers): Now methods.
6997         (sparc_ravenscar_prepare_to_store): Remove.
6998         (sparc_ravenscar_ops): Redefine.
6999         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7000         methods and destructor.  Remove members.
7001         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7002         (ravenscar_thread_target::store_registers)
7003         (ravenscar_thread_target::prepare_to_store): Update.
7004         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7005         Remove.
7006         (struct ppc_ravenscar_powerpc_ops): Derive from
7007         ravenscar_arch_ops.
7008         (ppc_ravenscar_powerpc_ops::fetch_registers)
7009         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7010         (ppc_ravenscar_powerpc_ops): Redefine.
7011         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7012         (ppc_ravenscar_e500_ops::fetch_registers)
7013         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7014         (ppc_ravenscar_e500_ops): Redefine.
7015         * aarch64-ravenscar-thread.c
7016         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7017         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7018         (aarch64_ravenscar_fetch_registers)
7019         (aarch64_ravenscar_store_registers): Now methods.
7020         (aarch64_ravenscar_ops): Redefine.
7021
7022 2019-02-15  Tom Tromey  <tromey@adacore.com>
7023
7024         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7025         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7026         (ravenscar_thread_target::stopped_by_watchpoint)
7027         (ravenscar_thread_target::stopped_data_address)
7028         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7029
7030 2019-02-15  Tom Tromey  <tromey@adacore.com>
7031
7032         * ravenscar-thread.c: Fix some typos.
7033
7034 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7035             Tom Tromey  <tromey@adacore.com>
7036
7037         * ada-lang.c (ada_exception_sal): Change addr_string to a
7038         std::string.
7039         (create_ada_exception_catchpoint): Update.
7040
7041 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7042             Tom Tromey  <tromey@adacore.com>
7043
7044         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7045         (bp_location_ops): Remove.
7046         (base_breakpoint_allocate_location): Update.
7047         (free_bp_location): Update.
7048         * ada-lang.c (class ada_catchpoint_location)
7049         <ada_catchpoint_location>: Remove ops parameter.
7050         (ada_catchpoint_location_dtor): Remove.
7051         (ada_catchpoint_location_ops): Remove.
7052         (allocate_location_exception): Update.
7053         * breakpoint.h (struct bp_location_ops): Remove.
7054         (class bp_location) <bp_location>: Remove bp_location_ops
7055         parameter.
7056         <~bp_location>: Add destructor.
7057         <ops>: Remove.
7058
7059 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7060             Pedro Alves  <palves@redhat.com>
7061
7062         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7063         'PATH_MAX'.
7064
7065 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7066             Samuel Thibault  <samuel.thibault@gnu.org>
7067             Thomas Schwinge  <thomas@codesourcery.com>
7068
7069         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7070         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7071
7072 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7073
7074         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7075         (check_empty): Use "const char *".
7076
7077         * gnu-nat.c (gnu_nat_target::detach): Instead of
7078         'detach_inferior (pid)' call
7079         'detach_inferior (find_inferior_pid (pid))'.
7080
7081         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7082         'nat/fork-inferior.o'.
7083         * gnu-nat.c: #include "nat/fork-inferior.h".
7084
7085         * gnu-nat.c (gnu_nat_target::detach): Instead of
7086         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7087         * gnu-nat.h: #include "inf-child.h".
7088         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7089         'i386_gnu_nat_target::fetch_registers'.
7090         (gnu_store_registers): Rename/move to
7091         'i386_gnu_nat_target::store_registers'.
7092
7093         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7094         * gnu-nat.h (mach_thread_info): New function.
7095         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7096
7097         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7098
7099 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7100
7101         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7102
7103 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7104
7105         * windows-nat.c (windows_add_thread): Add new parameter
7106         "main_thread_p" with default value set to false.  Update
7107         function documentation as well as all callers.
7108         (windows_delete_thread): Likewise.
7109         (fake_create_process): Update call to windows_add_thread.
7110         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7111         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7112         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7113         call to windows_delete_thread.
7114
7115 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7116
7117         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7118
7119 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7120
7121         * symfile.c (find_separate_debug_file): Use canonical path of
7122         sysroot with child_path instead of gdb_sysroot if it is valid.
7123
7124 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7125
7126         * symfile.c (find_separate_debug_file): Use child_path to
7127         determine if an object file is under a sysroot.
7128
7129 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7130
7131         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7132         unittests/child-path-selftests.c.
7133         * common/pathstuff.c (child_path): New function.
7134         * common/pathstuff.h (child_path): New prototype.
7135         * unittests/child-path-selftests.c: New file.
7136
7137 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7138
7139         * symfile.c (find_separate_debug_file): Look for separate debug
7140         files in debug directories under the sysroot.
7141
7142 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7143
7144         * symtab.h (struct minimal_symbol data_p): New const method.
7145         (struct minimal_symbol text_p): Likewise.
7146         * symtab.c (output_source_filename): Use file name style
7147         to print file name.
7148         (print_symbol_info): Likewise.
7149         (print_msymbol_info): Use address style to print addresses.
7150         Use function name style to print executable text symbols.
7151         (expand_symtab_containing_pc): Use data_p.
7152         (find_pc_sect_compunit_symtab): Likewise.
7153
7154 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7155
7156         * breakpoint.c (describe_other_breakpoints): Use address style
7157         to print addresses.
7158         (say_where): Likewise.
7159
7160 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7161
7162         * ada-typeprint.c (print_func_type): Print function name
7163         style to print function name.
7164         * c-typeprint.c (c_print_type_1): Likewise.
7165
7166 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7167
7168         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7169         for execve.
7170
7171 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7172
7173         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7174         type_stack.
7175
7176 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7177
7178         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7179         TYPE_CODE_REF types.
7180
7181 2019-02-08  Jim Wilson  <jimw@sifive.com>
7182
7183         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7184         (riscv_linux_fregset): New.
7185         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7186
7187 2019-02-07  Tom Tromey  <tom@tromey.com>
7188
7189         * thread.c (thread_cancel_execution_command): Update.
7190         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7191         methods.
7192         (struct thread_fsm_ops): Remove.
7193         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7194         (thread_fsm_should_stop, thread_fsm_return_value)
7195         (thread_fsm_set_finished, thread_fsm_finished_p)
7196         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7197         Don't declare.
7198         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7199         * infrun.c (clear_proceed_status_thread)
7200         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7201         (print_stop_event): Update.
7202         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7203         Add constructor.
7204         (step_command_fsm_ops): Remove.
7205         (new_step_command_fsm): Remove.
7206         (step_1): Update.
7207         (step_command_fsm::should_stop): Rename from
7208         step_command_fsm_should_stop.
7209         (step_command_fsm::clean_up): Rename from
7210         step_command_fsm_clean_up.
7211         (step_command_fsm::do_async_reply_reason): Rename from
7212         step_command_fsm_async_reply_reason.
7213         (struct until_next_fsm): Inherit from thread_fsm.  Add
7214         constructor.
7215         (until_next_fsm_ops): Remove.
7216         (new_until_next_fsm): Remove.
7217         (until_next_fsm::should_stop): Rename from
7218         until_next_fsm_should_stop.
7219         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7220         (until_next_fsm::do_async_reply_reason): Rename from
7221         until_next_fsm_async_reply_reason.
7222         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7223         constructor.  Change type of breakpoint.
7224         (finish_command_fsm_ops): Remove.
7225         (new_finish_command_fsm): Remove.
7226         (finish_command_fsm::should_stop): Rename from
7227         finish_command_fsm_should_stop.
7228         (finish_command_fsm::clean_up): Rename from
7229         finish_command_fsm_clean_up.
7230         (finish_command_fsm::return_value): Rename from
7231         finish_command_fsm_return_value.
7232         (finish_command_fsm::do_async_reply_reason): Rename from
7233         finish_command_fsm_async_reply_reason.
7234         (finish_command): Update.
7235         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7236         Add constructor.
7237         (call_thread_fsm_ops): Remove.
7238         (call_thread_fsm::call_thread_fsm): Rename from
7239         new_call_thread_fsm.
7240         (call_thread_fsm::should_stop): Rename from
7241         call_thread_fsm_should_stop.
7242         (call_thread_fsm::should_notify_stop): Rename from
7243         call_thread_fsm_should_notify_stop.
7244         (run_inferior_call, call_function_by_hand_dummy): Update.
7245         * cli/cli-interp.c (should_print_stop_to_console): Update.
7246         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7247         Add constructor.  Change type of location_breakpoint,
7248         caller_breakpoint.
7249         (until_break_fsm_ops): Remove.
7250         (new_until_break_fsm): Remove.
7251         (until_break_fsm::should_stop): Rename from
7252         until_break_fsm_should_stop.
7253         (until_break_fsm::clean_up): Rename from
7254         until_break_fsm_clean_up.
7255         (until_break_fsm::do_async_reply_reason): Rename from
7256         until_break_fsm_async_reply_reason.
7257         (until_break_command): Update.
7258         * thread-fsm.c: Remove.
7259         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7260
7261 2019-02-07  Tom Tromey  <tom@tromey.com>
7262
7263         * yy-remap.h: Add include guard.
7264         * xtensa-tdep.h: Add include guard.
7265         * xcoffread.h: Rename include guard.
7266         * varobj-iter.h: Add include guard.
7267         * tui/tui.h: Rename include guard.
7268         * tui/tui-winsource.h: Rename include guard.
7269         * tui/tui-wingeneral.h: Rename include guard.
7270         * tui/tui-windata.h: Rename include guard.
7271         * tui/tui-win.h: Rename include guard.
7272         * tui/tui-stack.h: Rename include guard.
7273         * tui/tui-source.h: Rename include guard.
7274         * tui/tui-regs.h: Rename include guard.
7275         * tui/tui-out.h: Rename include guard.
7276         * tui/tui-layout.h: Rename include guard.
7277         * tui/tui-io.h: Rename include guard.
7278         * tui/tui-hooks.h: Rename include guard.
7279         * tui/tui-file.h: Rename include guard.
7280         * tui/tui-disasm.h: Rename include guard.
7281         * tui/tui-data.h: Rename include guard.
7282         * tui/tui-command.h: Rename include guard.
7283         * tic6x-tdep.h: Add include guard.
7284         * target/waitstatus.h: Rename include guard.
7285         * target/wait.h: Rename include guard.
7286         * target/target.h: Rename include guard.
7287         * target/resume.h: Rename include guard.
7288         * target-float.h: Rename include guard.
7289         * stabsread.h: Add include guard.
7290         * rs6000-tdep.h: Add include guard.
7291         * riscv-fbsd-tdep.h: Add include guard.
7292         * regformats/regdef.h: Rename include guard.
7293         * record.h: Rename include guard.
7294         * python/python.h: Rename include guard.
7295         * python/python-internal.h: Rename include guard.
7296         * python/py-stopevent.h: Rename include guard.
7297         * python/py-ref.h: Rename include guard.
7298         * python/py-record.h: Rename include guard.
7299         * python/py-record-full.h: Rename include guard.
7300         * python/py-record-btrace.h: Rename include guard.
7301         * python/py-instruction.h: Rename include guard.
7302         * python/py-events.h: Rename include guard.
7303         * python/py-event.h: Rename include guard.
7304         * procfs.h: Add include guard.
7305         * proc-utils.h: Add include guard.
7306         * p-lang.h: Add include guard.
7307         * or1k-tdep.h: Rename include guard.
7308         * observable.h: Rename include guard.
7309         * nto-tdep.h: Rename include guard.
7310         * nat/x86-linux.h: Rename include guard.
7311         * nat/x86-linux-dregs.h: Rename include guard.
7312         * nat/x86-gcc-cpuid.h: Add include guard.
7313         * nat/x86-dregs.h: Rename include guard.
7314         * nat/x86-cpuid.h: Rename include guard.
7315         * nat/ppc-linux.h: Rename include guard.
7316         * nat/mips-linux-watch.h: Rename include guard.
7317         * nat/linux-waitpid.h: Rename include guard.
7318         * nat/linux-ptrace.h: Rename include guard.
7319         * nat/linux-procfs.h: Rename include guard.
7320         * nat/linux-osdata.h: Rename include guard.
7321         * nat/linux-nat.h: Rename include guard.
7322         * nat/linux-namespaces.h: Rename include guard.
7323         * nat/linux-btrace.h: Rename include guard.
7324         * nat/glibc_thread_db.h: Rename include guard.
7325         * nat/gdb_thread_db.h: Rename include guard.
7326         * nat/gdb_ptrace.h: Rename include guard.
7327         * nat/fork-inferior.h: Rename include guard.
7328         * nat/amd64-linux-siginfo.h: Rename include guard.
7329         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7330         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7331         * nat/aarch64-linux.h: Rename include guard.
7332         * nat/aarch64-linux-hw-point.h: Rename include guard.
7333         * mn10300-tdep.h: Add include guard.
7334         * mips-linux-tdep.h: Add include guard.
7335         * mi/mi-parse.h: Rename include guard.
7336         * mi/mi-out.h: Rename include guard.
7337         * mi/mi-main.h: Rename include guard.
7338         * mi/mi-interp.h: Rename include guard.
7339         * mi/mi-getopt.h: Rename include guard.
7340         * mi/mi-console.h: Rename include guard.
7341         * mi/mi-common.h: Rename include guard.
7342         * mi/mi-cmds.h: Rename include guard.
7343         * mi/mi-cmd-break.h: Rename include guard.
7344         * m2-lang.h: Add include guard.
7345         * location.h: Rename include guard.
7346         * linux-record.h: Rename include guard.
7347         * linux-nat.h: Add include guard.
7348         * linux-fork.h: Add include guard.
7349         * i386-darwin-tdep.h: Rename include guard.
7350         * hppa-linux-offsets.h: Add include guard.
7351         * guile/guile.h: Rename include guard.
7352         * guile/guile-internal.h: Rename include guard.
7353         * gnu-nat.h: Rename include guard.
7354         * gdb-stabs.h: Rename include guard.
7355         * frv-tdep.h: Add include guard.
7356         * f-lang.h: Add include guard.
7357         * event-loop.h: Add include guard.
7358         * darwin-nat.h: Rename include guard.
7359         * cp-abi.h: Rename include guard.
7360         * config/sparc/nm-sol2.h: Rename include guard.
7361         * config/nm-nto.h: Rename include guard.
7362         * config/nm-linux.h: Add include guard.
7363         * config/i386/nm-i386gnu.h: Rename include guard.
7364         * config/djgpp/nl_types.h: Rename include guard.
7365         * config/djgpp/langinfo.h: Rename include guard.
7366         * compile/gcc-cp-plugin.h: Add include guard.
7367         * compile/gcc-c-plugin.h: Add include guard.
7368         * compile/compile.h: Rename include guard.
7369         * compile/compile-object-run.h: Rename include guard.
7370         * compile/compile-object-load.h: Rename include guard.
7371         * compile/compile-internal.h: Rename include guard.
7372         * compile/compile-cplus.h: Rename include guard.
7373         * compile/compile-c.h: Rename include guard.
7374         * common/xml-utils.h: Rename include guard.
7375         * common/x86-xstate.h: Rename include guard.
7376         * common/version.h: Rename include guard.
7377         * common/vec.h: Rename include guard.
7378         * common/tdesc.h: Rename include guard.
7379         * common/selftest.h: Rename include guard.
7380         * common/scoped_restore.h: Rename include guard.
7381         * common/scoped_mmap.h: Rename include guard.
7382         * common/scoped_fd.h: Rename include guard.
7383         * common/safe-iterator.h: Rename include guard.
7384         * common/run-time-clock.h: Rename include guard.
7385         * common/refcounted-object.h: Rename include guard.
7386         * common/queue.h: Rename include guard.
7387         * common/ptid.h: Rename include guard.
7388         * common/print-utils.h: Rename include guard.
7389         * common/preprocessor.h: Rename include guard.
7390         * common/pathstuff.h: Rename include guard.
7391         * common/observable.h: Rename include guard.
7392         * common/netstuff.h: Rename include guard.
7393         * common/job-control.h: Rename include guard.
7394         * common/host-defs.h: Rename include guard.
7395         * common/gdb_wait.h: Rename include guard.
7396         * common/gdb_vecs.h: Rename include guard.
7397         * common/gdb_unlinker.h: Rename include guard.
7398         * common/gdb_unique_ptr.h: Rename include guard.
7399         * common/gdb_tilde_expand.h: Rename include guard.
7400         * common/gdb_sys_time.h: Rename include guard.
7401         * common/gdb_string_view.h: Rename include guard.
7402         * common/gdb_splay_tree.h: Rename include guard.
7403         * common/gdb_setjmp.h: Rename include guard.
7404         * common/gdb_ref_ptr.h: Rename include guard.
7405         * common/gdb_optional.h: Rename include guard.
7406         * common/gdb_locale.h: Rename include guard.
7407         * common/gdb_assert.h: Rename include guard.
7408         * common/filtered-iterator.h: Rename include guard.
7409         * common/filestuff.h: Rename include guard.
7410         * common/fileio.h: Rename include guard.
7411         * common/environ.h: Rename include guard.
7412         * common/common-utils.h: Rename include guard.
7413         * common/common-types.h: Rename include guard.
7414         * common/common-regcache.h: Rename include guard.
7415         * common/common-inferior.h: Rename include guard.
7416         * common/common-gdbthread.h: Rename include guard.
7417         * common/common-exceptions.h: Rename include guard.
7418         * common/common-defs.h: Rename include guard.
7419         * common/common-debug.h: Rename include guard.
7420         * common/cleanups.h: Rename include guard.
7421         * common/buffer.h: Rename include guard.
7422         * common/btrace-common.h: Rename include guard.
7423         * common/break-common.h: Rename include guard.
7424         * cli/cli-utils.h: Rename include guard.
7425         * cli/cli-style.h: Rename include guard.
7426         * cli/cli-setshow.h: Rename include guard.
7427         * cli/cli-script.h: Rename include guard.
7428         * cli/cli-interp.h: Rename include guard.
7429         * cli/cli-decode.h: Rename include guard.
7430         * cli/cli-cmds.h: Rename include guard.
7431         * charset-list.h: Add include guard.
7432         * buildsym-legacy.h: Rename include guard.
7433         * bfin-tdep.h: Add include guard.
7434         * ax.h: Rename include guard.
7435         * arm-linux-tdep.h: Add include guard.
7436         * arm-fbsd-tdep.h: Add include guard.
7437         * arch/xtensa.h: Rename include guard.
7438         * arch/tic6x.h: Add include guard.
7439         * arch/i386.h: Add include guard.
7440         * arch/arm.h: Rename include guard.
7441         * arch/arm-linux.h: Rename include guard.
7442         * arch/arm-get-next-pcs.h: Rename include guard.
7443         * arch/amd64.h: Add include guard.
7444         * arch/aarch64-insn.h: Rename include guard.
7445         * arch-utils.h: Rename include guard.
7446         * annotate.h: Add include guard.
7447         * amd64-darwin-tdep.h: Rename include guard.
7448         * aarch64-linux-tdep.h: Add include guard.
7449         * aarch64-fbsd-tdep.h: Add include guard.
7450         * aarch32-linux-nat.h: Add include guard.
7451
7452 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7453
7454         * macrotab.c (macro_define_internal): New function that
7455         factorizes macro_define_object_internal and macro_define_function
7456         code.
7457         (macro_define_object_internal): Use macro_define_internal.
7458         (macro_define_function): Likewise.
7459
7460 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7461
7462         * macrocmd.c (extract_identifier): Return
7463         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7464         callers.
7465
7466 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7467
7468         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7469
7470 2019-02-05  Tom Tromey  <tom@tromey.com>
7471
7472         * target.c (target_stack::unpush): Move assertion earlier.
7473
7474 2019-01-30  Tom Tromey  <tom@tromey.com>
7475
7476         PR python/23615:
7477         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7478         (gdbpy_parse_and_eval): Likewise.
7479         * python/python-internal.h (gdbpy_allow_threads): New class.
7480
7481 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7482
7483         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7484         (aarch64_fbsd_fpregmap): Move earlier.
7485         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7486         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7487         instead of individual calls to trad_frame_set_reg_addr.
7488         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7489         earlier.
7490         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7491         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7492         instead of individual calls to trad_frame_set_reg_addr.
7493
7494 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7495
7496         * CONTRIBUTE: Replace contribution list with wiki link.
7497
7498 2019-01-25  Tom Tromey  <tom@tromey.com>
7499
7500         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7501
7502 2019-01-25  Tom Tromey  <tom@tromey.com>
7503
7504         * xtensa-linux-nat.c: Fix common/ includes.
7505         * xml-support.h: Fix common/ includes.
7506         * xml-support.c: Fix common/ includes.
7507         * x86-linux-nat.c: Fix common/ includes.
7508         * windows-nat.c: Fix common/ includes.
7509         * varobj.h: Fix common/ includes.
7510         * varobj.c: Fix common/ includes.
7511         * value.c: Fix common/ includes.
7512         * valops.c: Fix common/ includes.
7513         * utils.c: Fix common/ includes.
7514         * unittests/xml-utils-selftests.c: Fix common/ includes.
7515         * unittests/utils-selftests.c: Fix common/ includes.
7516         * unittests/unpack-selftests.c: Fix common/ includes.
7517         * unittests/tracepoint-selftests.c: Fix common/ includes.
7518         * unittests/style-selftests.c: Fix common/ includes.
7519         * unittests/string_view-selftests.c: Fix common/ includes.
7520         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7521         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7522         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7523         * unittests/rsp-low-selftests.c: Fix common/ includes.
7524         * unittests/parse-connection-spec-selftests.c: Fix common/
7525         includes.
7526         * unittests/optional-selftests.c: Fix common/ includes.
7527         * unittests/offset-type-selftests.c: Fix common/ includes.
7528         * unittests/observable-selftests.c: Fix common/ includes.
7529         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7530         * unittests/memrange-selftests.c: Fix common/ includes.
7531         * unittests/memory-map-selftests.c: Fix common/ includes.
7532         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7533         * unittests/function-view-selftests.c: Fix common/ includes.
7534         * unittests/environ-selftests.c: Fix common/ includes.
7535         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7536         * unittests/common-utils-selftests.c: Fix common/ includes.
7537         * unittests/cli-utils-selftests.c: Fix common/ includes.
7538         * unittests/array-view-selftests.c: Fix common/ includes.
7539         * ui-file.c: Fix common/ includes.
7540         * tui/tui-io.c: Fix common/ includes.
7541         * tracepoint.h: Fix common/ includes.
7542         * tracepoint.c: Fix common/ includes.
7543         * tracefile-tfile.c: Fix common/ includes.
7544         * top.h: Fix common/ includes.
7545         * top.c: Fix common/ includes.
7546         * thread.c: Fix common/ includes.
7547         * target/waitstatus.h: Fix common/ includes.
7548         * target/waitstatus.c: Fix common/ includes.
7549         * target.h: Fix common/ includes.
7550         * target.c: Fix common/ includes.
7551         * target-memory.c: Fix common/ includes.
7552         * target-descriptions.c: Fix common/ includes.
7553         * symtab.h: Fix common/ includes.
7554         * symfile.c: Fix common/ includes.
7555         * stap-probe.c: Fix common/ includes.
7556         * spu-linux-nat.c: Fix common/ includes.
7557         * sparc-nat.c: Fix common/ includes.
7558         * source.c: Fix common/ includes.
7559         * solib.c: Fix common/ includes.
7560         * solib-target.c: Fix common/ includes.
7561         * ser-unix.c: Fix common/ includes.
7562         * ser-tcp.c: Fix common/ includes.
7563         * ser-pipe.c: Fix common/ includes.
7564         * ser-base.c: Fix common/ includes.
7565         * selftest-arch.c: Fix common/ includes.
7566         * s12z-tdep.c: Fix common/ includes.
7567         * rust-exp.y: Fix common/ includes.
7568         * rs6000-aix-tdep.c: Fix common/ includes.
7569         * riscv-tdep.c: Fix common/ includes.
7570         * remote.c: Fix common/ includes.
7571         * remote-notif.h: Fix common/ includes.
7572         * remote-fileio.h: Fix common/ includes.
7573         * remote-fileio.c: Fix common/ includes.
7574         * regcache.h: Fix common/ includes.
7575         * regcache.c: Fix common/ includes.
7576         * record-btrace.c: Fix common/ includes.
7577         * python/python.c: Fix common/ includes.
7578         * python/py-type.c: Fix common/ includes.
7579         * python/py-inferior.c: Fix common/ includes.
7580         * progspace.h: Fix common/ includes.
7581         * producer.c: Fix common/ includes.
7582         * procfs.c: Fix common/ includes.
7583         * proc-api.c: Fix common/ includes.
7584         * printcmd.c: Fix common/ includes.
7585         * ppc-linux-nat.c: Fix common/ includes.
7586         * parser-defs.h: Fix common/ includes.
7587         * osdata.c: Fix common/ includes.
7588         * obsd-nat.c: Fix common/ includes.
7589         * nat/x86-linux.c: Fix common/ includes.
7590         * nat/x86-linux-dregs.c: Fix common/ includes.
7591         * nat/x86-dregs.h: Fix common/ includes.
7592         * nat/x86-dregs.c: Fix common/ includes.
7593         * nat/ppc-linux.c: Fix common/ includes.
7594         * nat/mips-linux-watch.h: Fix common/ includes.
7595         * nat/mips-linux-watch.c: Fix common/ includes.
7596         * nat/linux-waitpid.c: Fix common/ includes.
7597         * nat/linux-ptrace.h: Fix common/ includes.
7598         * nat/linux-ptrace.c: Fix common/ includes.
7599         * nat/linux-procfs.c: Fix common/ includes.
7600         * nat/linux-personality.c: Fix common/ includes.
7601         * nat/linux-osdata.c: Fix common/ includes.
7602         * nat/linux-namespaces.c: Fix common/ includes.
7603         * nat/linux-btrace.h: Fix common/ includes.
7604         * nat/linux-btrace.c: Fix common/ includes.
7605         * nat/fork-inferior.c: Fix common/ includes.
7606         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7607         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7608         * nat/aarch64-linux.c: Fix common/ includes.
7609         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7610         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7611         * namespace.h: Fix common/ includes.
7612         * mips-linux-tdep.c: Fix common/ includes.
7613         * minsyms.c: Fix common/ includes.
7614         * mi/mi-parse.h: Fix common/ includes.
7615         * mi/mi-main.c: Fix common/ includes.
7616         * mi/mi-cmd-env.c: Fix common/ includes.
7617         * memrange.h: Fix common/ includes.
7618         * memattr.c: Fix common/ includes.
7619         * maint.h: Fix common/ includes.
7620         * maint.c: Fix common/ includes.
7621         * main.c: Fix common/ includes.
7622         * machoread.c: Fix common/ includes.
7623         * location.c: Fix common/ includes.
7624         * linux-thread-db.c: Fix common/ includes.
7625         * linux-nat.c: Fix common/ includes.
7626         * linux-fork.c: Fix common/ includes.
7627         * inline-frame.c: Fix common/ includes.
7628         * infrun.c: Fix common/ includes.
7629         * inflow.c: Fix common/ includes.
7630         * inferior.h: Fix common/ includes.
7631         * inferior.c: Fix common/ includes.
7632         * infcmd.c: Fix common/ includes.
7633         * inf-ptrace.c: Fix common/ includes.
7634         * inf-child.c: Fix common/ includes.
7635         * ia64-linux-nat.c: Fix common/ includes.
7636         * i387-tdep.c: Fix common/ includes.
7637         * i386-tdep.c: Fix common/ includes.
7638         * i386-linux-tdep.c: Fix common/ includes.
7639         * i386-linux-nat.c: Fix common/ includes.
7640         * i386-go32-tdep.c: Fix common/ includes.
7641         * i386-fbsd-tdep.c: Fix common/ includes.
7642         * i386-fbsd-nat.c: Fix common/ includes.
7643         * guile/scm-type.c: Fix common/ includes.
7644         * guile/guile.c: Fix common/ includes.
7645         * go32-nat.c: Fix common/ includes.
7646         * gnu-nat.c: Fix common/ includes.
7647         * gdbthread.h: Fix common/ includes.
7648         * gdbarch-selftests.c: Fix common/ includes.
7649         * gdb_usleep.c: Fix common/ includes.
7650         * gdb_select.h: Fix common/ includes.
7651         * gdb_bfd.c: Fix common/ includes.
7652         * gcore.c: Fix common/ includes.
7653         * fork-child.c: Fix common/ includes.
7654         * findvar.c: Fix common/ includes.
7655         * fbsd-nat.c: Fix common/ includes.
7656         * event-top.c: Fix common/ includes.
7657         * event-loop.c: Fix common/ includes.
7658         * dwarf2read.c: Fix common/ includes.
7659         * dwarf2loc.c: Fix common/ includes.
7660         * dwarf2-frame.c: Fix common/ includes.
7661         * dwarf-index-cache.c: Fix common/ includes.
7662         * dtrace-probe.c: Fix common/ includes.
7663         * disasm-selftests.c: Fix common/ includes.
7664         * defs.h: Fix common/ includes.
7665         * csky-tdep.c: Fix common/ includes.
7666         * cp-valprint.c: Fix common/ includes.
7667         * cp-support.h: Fix common/ includes.
7668         * cp-support.c: Fix common/ includes.
7669         * corelow.c: Fix common/ includes.
7670         * completer.h: Fix common/ includes.
7671         * completer.c: Fix common/ includes.
7672         * compile/compile.c: Fix common/ includes.
7673         * compile/compile-loc2c.c: Fix common/ includes.
7674         * compile/compile-cplus-types.c: Fix common/ includes.
7675         * compile/compile-cplus-symbols.c: Fix common/ includes.
7676         * command.h: Fix common/ includes.
7677         * cli/cli-dump.c: Fix common/ includes.
7678         * cli/cli-cmds.c: Fix common/ includes.
7679         * charset.c: Fix common/ includes.
7680         * build-id.c: Fix common/ includes.
7681         * btrace.h: Fix common/ includes.
7682         * btrace.c: Fix common/ includes.
7683         * breakpoint.h: Fix common/ includes.
7684         * breakpoint.c: Fix common/ includes.
7685         * ax.h:
7686         (enum agent_op): Fix common/ includes.
7687         * ax-general.c (struct aop_map): Fix common/ includes.
7688         * ax-gdb.c: Fix common/ includes.
7689         * auxv.c: Fix common/ includes.
7690         * auto-load.c: Fix common/ includes.
7691         * arm-tdep.c: Fix common/ includes.
7692         * arch/riscv.c: Fix common/ includes.
7693         * arch/ppc-linux-common.c: Fix common/ includes.
7694         * arch/i386.c: Fix common/ includes.
7695         * arch/arm.c: Fix common/ includes.
7696         * arch/arm-linux.c: Fix common/ includes.
7697         * arch/arm-get-next-pcs.c: Fix common/ includes.
7698         * arch/amd64.c: Fix common/ includes.
7699         * arch/aarch64.c: Fix common/ includes.
7700         * arch/aarch64-insn.c: Fix common/ includes.
7701         * arch-utils.c: Fix common/ includes.
7702         * amd64-windows-tdep.c: Fix common/ includes.
7703         * amd64-tdep.c: Fix common/ includes.
7704         * amd64-sol2-tdep.c: Fix common/ includes.
7705         * amd64-obsd-tdep.c: Fix common/ includes.
7706         * amd64-nbsd-tdep.c: Fix common/ includes.
7707         * amd64-linux-tdep.c: Fix common/ includes.
7708         * amd64-linux-nat.c: Fix common/ includes.
7709         * amd64-fbsd-tdep.c: Fix common/ includes.
7710         * amd64-fbsd-nat.c: Fix common/ includes.
7711         * amd64-dicos-tdep.c: Fix common/ includes.
7712         * amd64-darwin-tdep.c: Fix common/ includes.
7713         * agent.c: Fix common/ includes.
7714         * ada-lang.h: Fix common/ includes.
7715         * ada-lang.c: Fix common/ includes.
7716         * aarch64-tdep.c: Fix common/ includes.
7717
7718 2019-01-25  Tom Tromey  <tom@tromey.com>
7719
7720         * common/create-version.sh: Use common/version.h.
7721
7722 2019-01-24  Pedro Alves  <palves@redhat.com>
7723
7724         * infrun.c (signal_stop, signal_print, signal_program)
7725         (signal_catch, signal_pass): Now arrays instead of pointers.
7726         (update_signals_program_target, do_target_resume)
7727         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7728         * linux-nat.c (linux_nat_target::pass_signals)
7729         (linux_nat_target::create_inferior, linux_nat_target::attach):
7730         Adjust.
7731         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7732         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7733         * procfs.c (procfs_target::pass_signals): Adjust.
7734         * record-full.c (record_full_target::resume): Adjust.
7735         * remote.c (remote_target::pass_signals)
7736         (remote_target::program_signals): Adjust.
7737         * target-debug.h (target_debug_print_signals): Now takes a
7738         gdb::array_view as parameter.  Adjust.
7739         * target.h (target_ops) <pass_signals, program_signals>: Replace
7740         pointer and length parameters with gdb::array_view.
7741         (target_pass_signals, target_program_signals): Likewise.
7742         * target-delegates.c: Regenerate.
7743
7744 2019-01-24  Pedro Alves  <palves@redhat.com>
7745
7746         * common/forward-scope-exit.h
7747         (forward_scope_exit::forward_scope_exit): Pass arguments to
7748         m_bind_function directly, instead of creating a std::bind and
7749         copying that.
7750
7751 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7752
7753         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7754         for static members.
7755         (pass_in_v_vfp_candidate): Likewise.
7756
7757 2019-01-23  Tom Tromey  <tom@tromey.com>
7758             Pedro Alves  <palves@redhat.com>
7759
7760         * regcache.c (class regcache_invalidator): Remove.
7761         (regcache::raw_write): Use make_scope_exit.
7762
7763 2019-01-23  Tom Tromey  <tom@tromey.com>
7764
7765         * ui-out.h (class ui_out_emit_type): Update comment.
7766
7767 2019-01-23  Tom Tromey  <tom@tromey.com>
7768
7769         * infrun.c (fetch_inferior_event): Update comment.
7770
7771 2019-01-23  Tom Tromey  <tom@tromey.com>
7772             Pedro Alves  <palves@redhat.com>
7773
7774         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7775         parameter.
7776         (fetch_inferior_event): Use SCOPE_EXIT.
7777
7778
7779 2019-01-23  Tom Tromey  <tom@tromey.com>
7780             Pedro Alves  <palves@redhat.com>
7781
7782         * infrun.c (disable_thread_events): Delete.
7783         (stop_all_threads): Use SCOPE_EXIT.
7784
7785 2019-01-23  Tom Tromey  <tom@tromey.com>
7786             Pedro Alves  <palves@redhat.com>
7787
7788         * symfile.c: Include forward-scope-exit.h.
7789         (clear_symtab_users_cleanup): Replace forward declaration with
7790         a FORWARD_SCOPE_EXIT.
7791         (syms_from_objfile_1): Use the forward_scope_exit and
7792         gdb::optional instead of cleanup_function.
7793         (reread_symbols): Use the forward_scope_exit instead of
7794         cleanup_function.
7795         (clear_symtab_users_cleanup): Remove function.
7796
7797 2019-01-23  Tom Tromey  <tom@tromey.com>
7798             Pedro Alves  <palves@redhat.com>
7799
7800         * linux-nat.c: Include scope-exit.h.
7801         (cleanup_target_stop): Remove.
7802         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7803         SCOPE_EXIT.
7804
7805 2019-01-23  Tom Tromey  <tom@tromey.com>
7806             Pedro Alves  <palves@redhat.com>
7807
7808         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7809         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7810
7811 2019-01-23  Tom Tromey  <tom@tromey.com>
7812             Andrew Burgess  <andrew.burgess@embecosm.com>
7813             Pedro Alves  <palves@redhat.com>
7814
7815         * infrun.c (fetch_inferior_event): Use scope_exit.
7816         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7817         * top.c (execute_command): Use scope_exit.
7818         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7819         * utils.c (do_bpstat_clear_actions_cleanup)
7820         (make_bpstat_clear_actions_cleanup): Remove.
7821
7822 2019-01-23  Tom Tromey  <tom@tromey.com>
7823             Pedro Alves  <palves@redhat.com>
7824
7825         * infrun.c: Include "common/scope-exit.h"
7826         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7827         (wait_for_inferior): Use SCOPE_EXIT.
7828         (fetch_inferior_event): Use scope_exit.
7829
7830 2019-01-23  Tom Tromey  <tom@tromey.com>
7831             Pedro Alves  <palves@redhat.com>
7832
7833         * breakpoint.c (create_breakpoint): Remove cleanup.
7834
7835 2019-01-23  Tom Tromey  <tom@tromey.com>
7836             Andrew Burgess  <andrew.burgess@embecosm.com>
7837             Pedro Alves  <palves@redhat.com>
7838
7839 2019-01-23  Pedro Alves  <palves@redhat.com>
7840
7841         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7842
7843 2019-01-23  Pedro Alves  <palves@redhat.com>
7844             Andrew Burgess  <andrew.burgess@embecosm.com>
7845
7846         * gdbthread.h: Include "common/forward-scope-exit.h".
7847         (scoped_finish_thread_state): Redefine custom class in terms of
7848         forward_scope_exit.
7849
7850 2019-01-23  Pedro Alves  <palves@redhat.com>
7851             Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * common/forward-scope-exit.h: New file.
7854
7855 2019-01-23  Pedro Alves  <palves@redhat.com>
7856             Andrew Burgess  <andrew.burgess@embecosm.com>
7857             Tom Tromey  <tom@tromey.com>
7858
7859         * common/scope-exit.h: New file.
7860
7861 2019-01-23  Pedro Alves  <palves@redhat.com>
7862
7863         * common/preprocessor.h (ESC): Rename to ...
7864         (ESC_PARENS): ... this.
7865         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7866         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7867
7868 2019-01-23  Tom Tromey  <tom@tromey.com>
7869
7870         * language.h (class scoped_switch_to_sym_language_if_auto):
7871         Initialize m_lang in both cases.
7872
7873 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7874
7875         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7876         with XCNEW.
7877
7878 2019-01-22  Tom Tromey  <tom@tromey.com>
7879
7880         * corelow.c: Do not include sys/file.h.
7881
7882 2019-01-22  Tom Tromey  <tom@tromey.com>
7883
7884         * tui/tui-wingeneral.h: Include gdb_curses.h.
7885
7886 2019-01-22  Tom Tromey  <tom@tromey.com>
7887
7888         * source-cache.h (class source_cache) <get_source_lines,
7889         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7890
7891 2019-01-22  Tom Tromey  <tom@tromey.com>
7892
7893         * remote-fileio.h (struct remote_target): Declare.
7894
7895 2019-01-22  Tom Tromey  <tom@tromey.com>
7896
7897         * python/py-arch.c: Do not include py-ref.h.
7898         * python/py-bpevent.c: Do not include py-ref.h.
7899         * python/py-cmd.c: Do not include py-ref.h.
7900         * python/py-continueevent.c: Do not include py-ref.h.
7901         * python/py-event.h: Do not include py-ref.h.
7902         * python/py-evtregistry.c: Do not include py-ref.h.
7903         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7904         * python/py-frame.c: Do not include py-ref.h.
7905         * python/py-framefilter.c: Do not include py-ref.h.
7906         * python/py-function.c: Do not include py-ref.h.
7907         * python/py-infevents.c: Do not include py-ref.h.
7908         * python/py-linetable.c: Do not include py-ref.h.
7909         * python/py-objfile.c: Do not include py-ref.h.
7910         * python/py-param.c: Do not include py-ref.h.
7911         * python/py-prettyprint.c: Do not include py-ref.h.
7912         * python/py-progspace.c: Do not include py-ref.h.
7913         * python/py-symbol.c: Do not include py-ref.h.
7914         * python/py-symtab.c: Do not include py-ref.h.
7915         * python/py-type.c: Do not include py-ref.h.
7916         * python/py-unwind.c: Do not include py-ref.h.
7917         * python/py-utils.c: Do not include py-ref.h.
7918         * python/py-value.c: Do not include py-ref.h.
7919         * python/py-varobj.c: Do not include py-ref.h.
7920         * python/py-xmethods.c: Do not include py-ref.h.
7921         * python/python.c: Do not include py-ref.h.
7922         * varobj.c: Do not include py-ref.h.
7923
7924 2019-01-22  Tom Tromey  <tom@tromey.com>
7925
7926         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7927         keyword for bcache.
7928
7929 2019-01-22  Tom Tromey  <tom@tromey.com>
7930
7931         * compile/compile-cplus-types.c: Remove a comment by #include.
7932
7933 2019-01-22  Tom Tromey  <tom@tromey.com>
7934
7935         * compile/gcc-c-plugin.h: Include compile-internal.h.
7936
7937 2019-01-22  Tom Tromey  <tom@tromey.com>
7938
7939         * stabsread.c (EXTERN): Do not define.
7940         (symnum, next_symbol_text_func, processing_gcc_compilation)
7941         (within_function, global_sym_chain, global_stabs)
7942         (previous_stab_code, this_object_header_files)
7943         (n_this_object_header_files)
7944         (n_allocated_this_object_header_files): Define.
7945         * stabsread.h (EXTERN): Never define.  Use "extern".
7946
7947 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7948
7949         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7950         history_value.
7951
7952 2019-01-21  Tom Tromey  <tom@tromey.com>
7953
7954         * ui-out.c: Fix includes.
7955         * tui/tui-source.c: Fix includes.
7956         * target.c: Fix includes.
7957         * remote.c: Fix includes.
7958         * regcache.c: Fix includes.
7959         * python/py-block.c: Fix includes.
7960         * printcmd.c: Fix includes.
7961         * or1k-tdep.c: Fix includes.
7962         * mi/mi-main.c: Fix includes.
7963         * m32r-tdep.c: Fix includes.
7964         * csky-tdep.c: Fix includes.
7965         * compile/compile-cplus-types.c: Fix includes.
7966         * cli/cli-interp.c: Fix includes.
7967
7968 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7969
7970         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7971         for padding.
7972
7973 2019-01-16  Tom Tromey  <tom@tromey.com>
7974
7975         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7976         earlier.
7977         (struct objfile) <msymbols_range>: Move from top level.
7978         <msymbols>: New method.
7979         (class objfile_msymbols): Remove.
7980         * symtab.c (default_collect_symbol_completion_matches_break_on):
7981         Update.
7982         * symmisc.c (dump_msymbols): Update.
7983         * stabsread.c (scan_file_globals): Update.
7984         * objc-lang.c (info_selectors_command, info_classes_command)
7985         (find_methods): Update.
7986         * minsyms.c (find_solib_trampoline_target): Update.
7987         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7988         * coffread.c (coff_symfile_read): Update.
7989         * ada-lang.c (ada_lookup_simple_minsym)
7990         (ada_collect_symbol_completion_matches): Update.
7991
7992 2019-01-16  Tom Tromey  <tom@tromey.com>
7993
7994         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7995         type.  Remove no-argument constructor.
7996         <iterator::operator++>: Simplify.
7997         <begin>: Update.
7998         <end>: Use minimal_symbol_count.
7999
8000 2019-01-16  Tom Tromey  <tom@tromey.com>
8001
8002         * objfiles.h (struct objfile) <psymtabs>: New method.
8003         (class objfile_psymtabs): Remove.
8004         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8005         typedef.
8006         <range>: New method.
8007         (require_partial_symbols): Change return type.
8008         * psymtab.c (require_partial_symbols)
8009         (psym_expand_symtabs_matching): Update.
8010         * mdebugread.c (parse_partial_symbols): Update.
8011         * dbxread.c (dbx_end_psymtab): Update.
8012
8013 2019-01-15  Tom Tromey  <tom@tromey.com>
8014
8015         * symtab.c (lookup_objfile_from_block)
8016         (lookup_symbol_in_objfile_symtabs)
8017         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8018         (find_line_symtab, info_sources_command)
8019         (default_collect_symbol_completion_matches_break_on)
8020         (make_source_files_completion_list): Update.
8021         * symmisc.c (print_objfile_statistics, dump_objfile)
8022         (maintenance_print_symbols, maintenance_info_symtabs)
8023         (maintenance_check_symtabs, maintenance_info_line_tables):
8024         Update.
8025         * source.c (select_source_symtab)
8026         (forget_cached_source_info_for_objfile): Update.
8027         * objfiles.h (class objfile_compunits): Remove.
8028         (struct objfile) <compunits_range>: New typedef.
8029         (compunits): New method.
8030         * objfiles.c (objfile_relocate1): Update.
8031         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8032         * maint.c (count_symtabs_and_blocks): Update.
8033         * linespec.c (iterate_over_all_matching_symtabs): Update.
8034         * cp-support.c (add_symbol_overload_list_qualified): Update.
8035         * coffread.c (coff_symtab_read): Update.
8036         * ada-lang.c (add_nonlocal_symbols)
8037         (ada_collect_symbol_completion_matches)
8038         (ada_add_global_exceptions): Update.
8039
8040 2019-01-15  Tom Tromey  <tom@tromey.com>
8041
8042         * progspace.h (program_space) <objfiles_safe_range>: New
8043         typedef.
8044         <objfiles_safe>: New method.
8045         * objfiles.h (class all_objfiles_safe): Remove.
8046         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8047         * jit.c (jit_inferior_exit_hook): Update.
8048
8049 2019-01-17  Tom Tromey  <tom@tromey.com>
8050
8051         * progspace.h (program_space) <objfiles_range>: New typedef.
8052         <objfiles>: New method.
8053         <objfiles_head>: Rename from objfiles.
8054         (object_files): Update.
8055         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8056         * guile/scm-pretty-print.c
8057         (ppscm_find_pretty_printer_from_objfiles): Update.
8058         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8059         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8060         Update.
8061         * python/py-progspace.c (pspy_get_objfiles): Update.
8062         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8063         Update.
8064         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8065         (objfpy_lookup_objfile_by_build_id): Update.
8066         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8067         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8068         Update.
8069         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8070         (expand_symtab_containing_pc, lookup_objfile_from_block)
8071         (lookup_static_symbol, basic_lookup_transparent_type)
8072         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8073         (find_line_symtab, info_sources_command)
8074         (default_collect_symbol_completion_matches_break_on)
8075         (make_source_files_completion_list, find_main_name): Update.
8076         * symmisc.c (print_symbol_bcache_statistics)
8077         (print_objfile_statistics, maintenance_print_symbols)
8078         (maintenance_print_msymbols, maintenance_print_objfiles)
8079         (maintenance_info_symtabs, maintenance_check_symtabs)
8080         (maintenance_expand_symtabs, maintenance_info_line_tables):
8081         Update.
8082         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8083         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8084         (map_overlay_command, unmap_overlay_command)
8085         (simple_overlay_update, expand_symtabs_matching)
8086         (map_symbol_filenames): Update.
8087         * symfile-debug.c (set_debug_symfile): Update.
8088         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8089         Update.
8090         * source.c (select_source_symtab, forget_cached_source_info):
8091         Update.
8092         * solib.c (solib_read_symbols): Update.
8093         * solib-spu.c (append_ocl_sos): Update.
8094         * psymtab.c (maintenance_print_psymbols)
8095         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8096         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8097         * printcmd.c (info_symbol_command): Update.
8098         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8099         Update.
8100         * objfiles.h (class all_objfiles): Remove.
8101         * objfiles.c (have_partial_symbols, have_full_symbols)
8102         (have_minimal_symbols, qsort_cmp, update_section_map)
8103         (shared_objfile_contains_address_p)
8104         (default_iterate_over_objfiles_in_search_order): Update.
8105         * objc-lang.c (info_selectors_command, info_classes_command)
8106         (find_methods): Update.
8107         * minsyms.c (find_solib_trampoline_target): Update.
8108         * maint.c (maintenance_info_sections)
8109         (maintenance_translate_address, count_symtabs_and_blocks):
8110         Update.
8111         * main.c (captured_main_1): Update.
8112         * linux-thread-db.c (try_thread_db_load_from_pdir)
8113         (has_libpthread): Update.
8114         * linespec.c (iterate_over_all_matching_symtabs)
8115         (search_minsyms_for_name): Update.
8116         * jit.c (jit_find_objf_with_entry_addr): Update.
8117         * hppa-tdep.c (find_unwind_entry)
8118         (hppa_lookup_stub_minimal_symbol): Update.
8119         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8120         Update.
8121         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8122         (elf_gnu_ifunc_resolve_by_got): Update.
8123         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8124         * dwarf-index-write.c (save_gdb_index_command): Update.
8125         * cp-support.c (add_symbol_overload_list_qualified): Update.
8126         * breakpoint.c (create_overlay_event_breakpoint)
8127         (create_longjmp_master_breakpoint)
8128         (create_std_terminate_master_breakpoint)
8129         (create_exception_master_breakpoint): Update.
8130         * blockframe.c (find_pc_partial_function): Update.
8131         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8132         (ada_collect_symbol_completion_matches)
8133         (ada_add_global_exceptions): Update.
8134
8135 2019-01-17  Tom Tromey  <tom@tromey.com>
8136
8137         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8138         declare VEC.
8139         (solib_target_parse_libraries): Change return type.
8140         (library_list_start_segment, library_list_start_section)
8141         (library_list_end_library, library_list_start_library); Update.
8142         (solib_target_free_library_list): Remove.
8143         (solib_target_parse_libraries): Remove cleanup.  Change return
8144         type.
8145         (solib_target_current_sos): Update.
8146
8147 2019-01-17  Tom Tromey  <tromey@bapiya>
8148
8149         * valprint.c: Replace "the the" with "the".
8150         * symtab.c: Replace "the the" with "the".
8151         * solib.c: Replace "the the" with "the".
8152         * solib-dsbt.c: Replace "the the" with "the".
8153         * linespec.c: Replace "the the" with "the".
8154         * dwarf2loc.h: Replace "the the" with "the".
8155         * amd64-windows-tdep.c: Replace "the the" with "the".
8156         * aarch64-tdep.c: Replace "the the" with "the".
8157
8158 2019-01-16  Keith Seitz  <keiths@redhat.com>
8159
8160         PR gdb/23773
8161         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8162         <builder>: Rename to ..
8163         <m_builder>: ... this and make private.
8164         (dwarf2_cu::get_builder): New method.  Change all users of
8165         `builder' to use this method.
8166         (dwarf2_start_symtab): Move to ...
8167         (dwarf2_cu::start_symtab): ... here.  Update all callers
8168         (setup_type_unit_groups): Move to ...
8169         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8170         callers.
8171         (dwarf2_cu::reset_builder): New method.
8172         (process_full_compunit, process_full_type_unit): Use
8173         dwarf2_cu::reset_builder.
8174         (follow_die_offset): Record the ancestor CU if it is different
8175         from the followed DIE's CU.
8176         (follow_die_sig_1): Likewise.
8177
8178 2019-01-15  Tom Tromey  <tom@tromey.com>
8179
8180         * remote.c (class remote_state) <buf>: Now a char_vector.
8181         <buf_size>: Remove.
8182         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8183         parameter.
8184         (remote_target::getpkt_or_notif_sane_1)
8185         (remote_target::getpkt_sane)
8186         (remote_target::getpkt_or_notif_sane): Likewise.
8187         (class remote_target) <putpkt>: New overload.
8188         (remote_target::read_frame): Change type of "buf_p".  Remove
8189         sizeof_p parameter.
8190         (packet_ok): New overload.
8191         (packet_check_result): New overload.
8192         Update all uses.
8193
8194 2019-01-14  Tom Tromey  <tom@tromey.com>
8195
8196         * remote-notif.c (handle_notification, remote_notif_ack)
8197         (remote_notif_parse): Make "buf" const.
8198         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8199         const.
8200         (remote_notif_parse, remote_notif_ack, handle_notification):
8201         Likewise.
8202         * remote.c (remote_notif_stop_parse): Make "buf" const.
8203         (remote_target::remote_parse_stop_reply): Make "buf" const.
8204         (remote_notif_stop_ack): Make "buf" const.
8205
8206 2019-01-14  Tom Tromey  <tom@tromey.com>
8207
8208         * remote.c (remote_console_output): Make parameter const.
8209
8210 2019-01-14  Tom Tromey  <tom@tromey.com>
8211
8212         * target-debug.h (target_debug_print_signals): Constify.
8213         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8214         * procfs.c (procfs_target::pass_signals): Update.
8215         * linux-nat.c (linux_nat_target::pass_signals): Update.
8216         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8217         * target-delegates.c: Rebuild.
8218         * remote.c (remote_target::program_signals): Update.
8219         (remote_target::pass_signals): Update.
8220         * target.c (target_pass_signals): Constify argument.
8221         (target_program_signals): Likewise.
8222         * target.h (struct target_ops) <pass_signals, program_signals>:
8223         Constify argument.
8224         (target_pass_signals, target_program_signals): Constify argument.
8225
8226 2019-01-14  Tom Tromey  <tom@tromey.com>
8227
8228         PR tui/28819:
8229         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8230
8231 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8232
8233         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8234         field.
8235         * rs6000-tdep.c: Include reggroups.h.
8236         (IS_V_ALIAS_PSEUDOREG): Define.
8237         (rs6000_register_name): Return names for the "vX" aliases.
8238         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8239         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8240         aliases.  Call default_register_reggroup_p for all other
8241         pseudo-registers.
8242         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8243         New functions.
8244         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8245         Handle "vX" aliases.
8246         (v_alias_pseudo_register_collect): New function.
8247         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8248         (rs6000_gdbarch_init): Initialize "vX" aliases as
8249         pseudo-registers.  Restore registration of
8250         rs6000_pseudo_register_reggroup_p with
8251         set_tdesc_pseudo_register_reggroup_p.
8252
8253 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8254
8255         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8256         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8257         set_gdbarch_num_pseudo_regs.
8258
8259 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8260
8261         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8262         Remove arg prefixname, add do_set and do_show.
8263         Add member functions set_list and show_list.
8264         * cli/cli-style.c (class cli_style_option): Update accordingly.
8265         (style_set_list): Move to file scope.
8266         (style_show_list): Likewise.
8267         (set_style): Call help_list.
8268         (show_style): Call cmd_show_list.
8269         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8270         Update to use the new macro.
8271
8272 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8273
8274         * ada-lang.c (_initialize_ada_language): Expand the help text
8275         for the "catch exception" command.
8276
8277 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8278
8279         * symtab.c (matching_obj_sections): Initialize obj,
8280         declare it closer to its usage.
8281
8282 2019-01-10  Tom Tromey  <tom@tromey.com>
8283
8284         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8285         (basic_inf_threads_range): Remove.
8286         (inf_threads_range, inf_non_exited_threads_range)
8287         (safe_inf_threads_range): Use next_adapter.
8288
8289 2019-01-10  Keith Seitz  <keiths@redhat.com>
8290
8291         PR gdb/23712
8292         PR symtab/23010
8293         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8294         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8295
8296 2019-01-10  Keith Seitz  <keiths@redhat.com>
8297
8298         PR gdb/23712
8299         PR symtab/23010
8300         * dictionary.c (pending_to_vector): Remove.
8301         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8302         Remove _1 suffix, replacing functions of the same name.  Update
8303         all callers.
8304         (dict_create_hashed, dict_create_hashed_expandable)
8305         (dict_create_linear, dict_create_linear_expandable, dict_free)
8306         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8307         Make functions static.
8308
8309 2019-01-10  Keith Seitz  <keiths@redhat.com>
8310
8311         PR gdb/23712
8312         PR symtab/23010
8313         * dictionary.h (struct dictionary): Replace declaration with
8314         multidictionary.
8315         (dict_create_hashed, dict_create_hashed_expandable)
8316         (dict_create_linear, dict_create_linear_expandable)
8317         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8318         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8319         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8320         taking multidictionary argument.
8321         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8322         * block.h (struct block) <dict>: Change to multidictionary
8323         and rename `multidict'.
8324         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8325         symmisc.c: Update all dictionary references to multidictionary.
8326
8327 2019-01-10  Keith Seitz  <keiths@redhat.com>
8328
8329         PR gdb/23712
8330         PR symtab/23010
8331         * dictionary.c: Include unordered_map.
8332         (pending_to_vector): New function.
8333         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8334         Rewrite the non-"_1" functions to take vector instead
8335         of linked list.
8336         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8337         "new" _1 versions of the same name.
8338         (multidictionary): Define.
8339         (std::hash<enum language): New definition.
8340         (collate_pending_symbols_by_language, mdict_create_hashed)
8341         (mdict_create_hashed_expandable, mdict_create_linear)
8342         (mdict_create_linear_expandable, mdict_free)
8343         (find_language_dictionary, create_new_language_dictionary)
8344         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8345         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8346         (mdict_size, mdict_empty): New functions.
8347         * dictionary.h (mdict_iterator): Define.
8348
8349 2019-01-10  Pedro Alves  <palves@redhat.com>
8350
8351         * breakpoint.c (read_uploaded_action)
8352         (create_tracepoint_from_upload): Adjust to use
8353         gdb::unique_xmalloc_ptr.
8354         * ctf.c (ctf_write_uploaded_tp):
8355         (SET_ARRAY_FIELD): Use emplace_back.
8356         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8357         * tracefile-tfile.c (tfile_write_uploaded_tp):
8358         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8359         gdb::unique_xmalloc_ptr.
8360         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8361         at_string, cond_string, cmd_strings>: Replace char pointers
8362         with gdb::unique_xmalloc_ptr.
8363
8364 2019-01-10  Pedro Alves  <palves@redhat.com>
8365
8366         * solib-target.c (library_list_start_library): Don't xstrdup name.
8367
8368 2019-01-10  Pedro Alves  <palves@redhat.com>
8369
8370         * mdebugread.c (parse_partial_symbols): Use
8371         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8372
8373 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8374
8375         * linux-fork.c (scoped_switch_fork_info)
8376         <~scoped_switch_fork_info>: Fix incorrect variable name.
8377
8378 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8379
8380         * linux-fork.c (scoped_switch_fork_info)
8381         <scoped_switch_fork_info>: Make explicit.
8382         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8383
8384 2019-01-10  Tom Tromey  <tom@tromey.com>
8385
8386         * objfiles.h (objfile::reset_psymtabs): Update.
8387         * objfiles.c (objfile::objfile): Update.
8388         * psymtab.h (psymtab_storage::obstack): Update.
8389         (psymtab_storage::m_obstack): Use gdb::optional.
8390         (class psymtab_storage): Update comment.  Remove objfile
8391         parameter.
8392         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8393
8394 2019-01-10  Tom Tromey  <tom@tromey.com>
8395
8396         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8397         <free_psymtabs>: Now private.
8398         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8399         (allocate_psymtab): Use new method.
8400
8401 2019-01-10  Tom Tromey  <tom@tromey.com>
8402
8403         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8404         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8405         * mdebugread.c (parse_partial_symbols): Use
8406         allocate_dependencies.
8407         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8408         allocate_dependencies.
8409         (process_psymtab_comp_unit_reader)
8410         (build_type_psymtab_dependencies): Likewise.
8411         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8412
8413 2019-01-10  Tom Tromey  <tom@tromey.com>
8414
8415         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8416         PSYMBOL_SET_LANGUAGE.
8417         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8418
8419 2019-01-10  Tom Tromey  <tom@tromey.com>
8420
8421         * psymtab.h (psymtab_storage::obstack): New method.
8422         <m_obstack>: Rename from obstack; now private.
8423         * psymtab.c (psymtab_storage): Update.
8424         * dwarf2read.c (create_addrmap_from_index)
8425         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8426         Update.
8427
8428 2019-01-10  Tom Tromey  <tom@tromey.com>
8429
8430         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8431         * objfiles.h (objfile::reset_psymtabs): New method.
8432
8433 2019-01-10  Tom Tromey  <tom@tromey.com>
8434
8435         * symmisc.c (print_symbol_bcache_statistics): Update.
8436         (print_objfile_statistics): Update.
8437         * symfile.c (reread_symbols): Update.
8438         * psymtab.h (class psymtab_storage): New.
8439         * psymtab.c (psymtab_storage): New constructor.
8440         (~psymtab_storage): New destructor.
8441         (require_partial_symbols): Update.
8442         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8443         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8444         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8445         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8446         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8447         (start_psymtab_common, end_psymtab_common)
8448         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8449         (allocate_psymtab): Update.
8450         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8451         Update.
8452         (dump_psymtab_addrmap, maintenance_print_psymbols)
8453         (maintenance_check_psymtabs): Update.
8454         (class objfile_psymtabs): Move to objfiles.h.
8455         * psympriv.h (discard_psymtab): Now inline.
8456         (psymtab_discarder::psymtab_discarder): Update.
8457         (psymtab_discarder::~psymtab_discarder): Update.
8458         (ALL_OBJFILE_PSYMTABS): Rewrite.
8459         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8460         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8461         Remove fields.
8462         <partial_symtabs>: New field.
8463         (class objfile_psymtabs): Move from psymtab.h.  Update.
8464         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8465         psymbol_cache.
8466         (objfile::~objfile): Don't destroy psymbol_cache.
8467         * mdebugread.c (parse_partial_symbols): Update.
8468         * dwarf2read.c (create_addrmap_from_index)
8469         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8470         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8471         (add_partial_subprogram, dwarf2_ranges_read): Update.
8472         * dwarf-index-write.c (write_address_map)
8473         (write_one_signatured_type, recursively_write_psymbols)
8474         (class debug_names, class debug_names, write_psymtabs_to_index):
8475         Update.
8476
8477 2019-01-10  Tom Tromey  <tom@tromey.com>
8478
8479         * symtab.h (SYMBOL_SET_NAMES): Update.
8480         (symbol_set_names): Update.
8481         (MSYMBOL_SET_NAMES): Update.
8482         * symtab.c (symbol_set_names): Change argument to be an
8483         objfile_per_bfd_storage.
8484         * psymtab.c (add_psymbol_to_bcache): Update.
8485         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8486
8487 2019-01-10  Tom Tromey  <tom@tromey.com>
8488
8489         * symtab.c (create_demangled_names_hash): Change argument to be an
8490         objfile_per_bfd_storage.
8491         (symbol_set_names): Update.
8492
8493 2019-01-10  Tom Tromey  <tom@tromey.com>
8494
8495         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8496         init_psymbol_list.
8497         * psymtab.c (init_psymbol_list): Do nothing if already called.
8498         * psympriv.h (init_psymbol_list): Add comment.
8499         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8500         init_psymbol_list.
8501         * dbxread.c (dbx_symfile_read): Unconditionally call
8502         init_psymbol_list.
8503
8504 2019-01-10  Tom Tromey  <tom@tromey.com>
8505
8506         * xcoffread.c (scan_xcoff_symtab): Update.
8507         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8508         "where".
8509         * mdebugread.c (parse_partial_symbols)
8510         (handle_psymbol_enumerators): Update.
8511         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8512         * dbxread.c (read_dbx_symtab): Update.
8513         * psympriv.h (psymbol_placement): New enum.
8514         (add_psymbol_to_list): Update.
8515
8516 2019-01-10  Tom Tromey  <tom@tromey.com>
8517
8518         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8519         static_psymbols parameters.
8520         (scan_xcoff_symtab): Update.
8521         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8522         static_psymbols parameters.
8523         * psympriv.h (start_psymtab_common): Update.
8524         * mdebugread.c (parse_partial_symbols): Update.
8525         * dwarf2read.c (create_partial_symtab): Update.
8526         * dbxread.c (read_dbx_symtab): Update.
8527         (start_psymtab): Remove global_psymbols and static_psymbols
8528         parameters.
8529
8530 2019-01-10  Tom Tromey  <tom@tromey.com>
8531
8532         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8533         * psymtab.c (allocate_psymtab): Add comment.
8534         * psympriv.h (allocate_psymtab): Add comment.
8535         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8536         initializations.
8537         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8538
8539 2019-01-10  Tom Tromey  <tom@tromey.com>
8540
8541         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8542         Don't declare.
8543         * mipsread.c: Include mdebugread.h.
8544         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8545         Declare.
8546         * elfread.c: Include mdebugread.h.
8547
8548 2019-01-09  Tom Tromey  <tom@tromey.com>
8549
8550         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8551         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8552         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8553         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8554         (psym_lookup_symbol, psym_find_last_source_symtab)
8555         (psym_forget_cached_source_info, psym_print_stats)
8556         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8557         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8558         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8559         (psym_find_compunit_symtab_by_address)
8560         (maintenance_print_psymbols, maintenance_info_psymtabs)
8561         (maintenance_check_psymtabs): Use ranged for.
8562         * psymtab.h (class objfile_psymtabs): New.
8563         (require_partial_symbols): Return objfile_psymtabs.
8564         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8565
8566 2019-01-09  Tom Tromey  <tom@tromey.com>
8567
8568         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8569         (find_pc_mapped_section, list_overlays_command)
8570         (map_overlay_command, unmap_overlay_command)
8571         (simple_overlay_update): Use all_objfiles.
8572         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8573         * printcmd.c (info_symbol_command): Use all_objfiles.
8574         * objfiles.h (ALL_OBJSECTIONS): Remove.
8575         * maint.c (maintenance_translate_address): Use all_objfiles.
8576         * gcore.c (gcore_create_callback): Use all_objfiles.
8577         (objfile_find_memory_regions): Likewise.
8578
8579 2019-01-09  Tom Tromey  <tom@tromey.com>
8580
8581         * symtab.c (find_line_symtab, info_sources_command)
8582         (make_source_files_completion_list): Use objfile_compunits.
8583         * source.c (select_source_symtab): Use objfile_compunits.
8584         * objfiles.h (struct objfile): Update comment.
8585         (ALL_OBJFILES): Remove.
8586         (ALL_FILETABS): Remove.
8587         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8588         objfile_compunits.
8589
8590 2019-01-09  Tom Tromey  <tom@tromey.com>
8591
8592         * symmisc.c (print_objfile_statistics, dump_objfile)
8593         (maintenance_print_symbols): Use compunit_filetabs.
8594         * source.c (forget_cached_source_info_for_objfile): Use
8595         compunit_filetabs.
8596         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8597         (ALL_FILETABS): Use compunit_filetabs.
8598         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8599         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8600
8601 2019-01-09  Tom Tromey  <tom@tromey.com>
8602
8603         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8604         (compunit_filetabs): New.
8605         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8606         compunit_filetabs.
8607         (info_sources_command, make_source_files_completion_list): Remove
8608         declaration.
8609         * symmisc.c (print_objfile_statistics, dump_objfile)
8610         (maintenance_print_symbols): Remove declaration.
8611         (maintenance_info_symtabs): Use compunit_filetabs.
8612         (maintenance_info_line_tables): Likewise.
8613         * source.c (select_source_symtab): Change local variable name.
8614         (forget_cached_source_info_for_objfile): Remove declaration.
8615         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8616         * objfiles.c (objfile_relocate1): Remove declaration.
8617         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8618         declaration.
8619         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8620         * coffread.c (coff_symtab_read): Remove declaration.
8621         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8622         compunit_filetabs.
8623
8624 2019-01-09  Tom Tromey  <tom@tromey.com>
8625
8626         * symtab.c (lookup_objfile_from_block)
8627         (find_pc_sect_compunit_symtab, search_symbols)
8628         (default_collect_symbol_completion_matches_break_on): Use
8629         objfile_compunits.
8630         * objfiles.h (ALL_COMPUNITS): Remove.
8631         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8632         * cp-support.c (add_symbol_overload_list_qualified): Use
8633         objfile_compunits.
8634         * ada-lang.c (ada_collect_symbol_completion_matches)
8635         (ada_add_global_exceptions): Use objfile_compunits.
8636
8637 2019-01-09  Tom Tromey  <tom@tromey.com>
8638
8639         * source.c (select_source_symtab)
8640         (forget_cached_source_info_for_objfile): Remove declaration.
8641         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8642         declaration.
8643         * maint.c (count_symtabs_and_blocks): Remove declaration.
8644         * cp-support.c (add_symbol_overload_list_qualified): Remove
8645         declaration.
8646         * coffread.c (coff_symtab_read): Remove declaration.
8647         * symtab.c (lookup_symbol_in_objfile_symtabs)
8648         (basic_lookup_transparent_type_1): Use objfile_compunits.
8649         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8650         (info_sources_command, search_symbols)
8651         (default_collect_symbol_completion_matches_break_on)
8652         (make_source_files_completion_list): Remove declaration.
8653         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8654         (ada_collect_symbol_completion_matches)
8655         (ada_add_global_exceptions): Remove declaration.
8656         * linespec.c (iterate_over_all_matching_symtabs): Use
8657         objfile_compunits.
8658         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8659         (class objfile_compunits): New.
8660         (ALL_COMPUNITS): Use objfile_compunits.
8661         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8662         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8663         objfile_compunits.
8664         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8665
8666 2019-01-09  Tom Tromey  <tom@tromey.com>
8667
8668         * symtab.c (search_symbols)
8669         (default_collect_symbol_completion_matches_break_on): Use
8670         objfile_msymbols.
8671         * ada-lang.c (ada_lookup_simple_minsym)
8672         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8673         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8674         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8675         objfile_msymbols.
8676         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8677         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8678         * objc-lang.c (find_methods): Use objfile_msymbols.
8679         (info_selectors_command, info_classes_command): Likewise.
8680         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8681         * objfiles.h (class objfile_msymbols): New.
8682         (ALL_OBJFILE_MSYMBOLS): Remove.
8683         (ALL_MSYMBOLS): Remove.
8684
8685 2019-01-09  Tom Tromey  <tom@tromey.com>
8686
8687         * common/next-iterator.h (next_adapter): Add Iterator template
8688         parameter.
8689         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8690         (class all_objfiles_safe): New.
8691         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8692         * objfiles.c (put_objfile_before): Update comment.
8693         (add_separate_debug_objfile): Likewise.
8694         (free_all_objfiles): Use all_objfiles_safe.
8695         (objfile_purge_solibs): Likewise.
8696
8697 2019-01-09  Tom Tromey  <tom@tromey.com>
8698
8699         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8700         (expand_symtab_containing_pc, lookup_static_symbol)
8701         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8702         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8703         all_objfiles.
8704         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8705         * breakpoint.c (create_overlay_event_breakpoint)
8706         (create_longjmp_master_breakpoint)
8707         (create_std_terminate_master_breakpoint)
8708         (create_exception_master_breakpoint): Use all_objfiles.
8709         * linux-thread-db.c (try_thread_db_load_from_pdir)
8710         (has_libpthread): Use all_objfiles.
8711         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8712         * linespec.c (iterate_over_all_matching_symtabs)
8713         (search_minsyms_for_name): Use all_objfiles.
8714         * maint.c (maintenance_info_sections): Use all_objfiles.
8715         * main.c (captured_main_1): Use all_objfiles.
8716         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8717         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8718         * guile/scm-pretty-print.c
8719         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8720         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8721         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8722         (maintenance_print_msymbols): Use all_objfiles.
8723         * source.c (select_source_symtab): Use all_objfiles.
8724         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8725         * symfile.c (remove_symbol_file_command)
8726         (expand_symtabs_matching, map_symbol_filenames): Use
8727         all_objfiles.
8728         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8729         all_objfiles.
8730         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8731         * objc-lang.c (find_methods): Use all_objfiles.
8732         * objfiles.c (have_partial_symbols, have_full_symbols)
8733         (have_minimal_symbols, qsort_cmp)
8734         (default_iterate_over_objfiles_in_search_order): Use
8735         all_objfiles.
8736         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8737         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8738         (maintenance_check_psymtabs): Use all_objfiles.
8739         (ALL_PSYMTABS): Remove.
8740         * compile/compile-object-run.c (do_module_cleanup): Use
8741         all_objfiles.
8742         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8743         * cp-support.c (add_symbol_overload_list_qualified): Use
8744         all_objfiles.
8745         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8746         Use all_objfiles.
8747         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8748         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8749         all_objfiles.
8750         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8751         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8752         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8753         Uses all_objfiles.
8754         * solib.c (solib_read_symbols): Use all_objfiles
8755
8756 2019-01-09  Tom Tromey  <tom@tromey.com>
8757
8758         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8759         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8760         all_objfiles.
8761         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8762         * symmisc.c (print_symbol_bcache_statistics)
8763         (print_objfile_statistics, maintenance_print_objfiles)
8764         (maintenance_info_symtabs, maintenance_check_symtabs)
8765         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8766         all_objfiles.
8767         * source.c (forget_cached_source_info): Use all_objfiles.
8768         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8769         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8770         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8771         * objfiles.c (update_section_map): Use all_objfiles.
8772         (shared_objfile_contains_address_p): Likewise.
8773         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8774         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8775
8776 2019-01-09  Tom Tromey  <tom@tromey.com>
8777
8778         * common/next-iterator.h: New file.
8779         * objfiles.h (class all_objfiles): New.
8780         (struct objfile_iterator): New.
8781
8782 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8783
8784         * NEWS: Move the description of the changed "frame", "select-frame",
8785          and "info frame" commands to the Changed commands section.
8786
8787 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8788
8789         * gdbtypes.c (check_stub_method_group): Remove handling of old
8790         mangling schemes.
8791         * linespec.c (find_methods): Likewise.
8792         * stabsread.c (read_member_functions): Likewise.
8793         * valops.c (search_struct_method): Likewise.
8794         (value_struct_elt_for_reference): Likewise.
8795         * NEWS: Mention this change.
8796
8797 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8798
8799         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8800         print_source_lines.
8801         * source.c (print_source_lines_base): Update line number check.
8802         (print_source_lines): New function.
8803         (source_lines_range::source_lines_range): New function.
8804         * source.h (class source_lines_range): New class.
8805         (print_source_lines): New declaration.
8806
8807 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8808
8809         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8810
8811 2019-01-08  Tom Tromey  <tom@tromey.com>
8812             Simon Marchi  <simon.marchi@ericsson.com>
8813
8814         PR gdb/24060
8815         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8816         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8817         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8818         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8819         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8820         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8821
8822 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * source.c (select_source_symtab): Move header comment to
8825         declaration in source.h.
8826         (forget_cached_source_info_for_objfile): Likewise.
8827         (forget_cached_source_info): Likewise.
8828         (identify_source_line): Likewise.
8829         * source.h (identify_source_line): Move declaration from symtab.h
8830         and add comment from source.c
8831         (print_source_lines): Likewise.
8832         (forget_cached_source_info_for_objfile): Likewise.
8833         (forget_cached_source_info): Likewise.
8834         (select_source_symtab): Likewise.
8835         (enum print_source_lines_flag): Move definition from symtab.h.
8836         * symtab.h (identify_source_line): Move declaration to source.h.
8837         (print_source_lines): Likewise.
8838         (forget_cached_source_info_for_objfile): Likewise.
8839         (forget_cached_source_info): Likewise.
8840         (select_source_symtab): Likewise.
8841         (enum print_source_lines_flag): Move definition to source.h.
8842         * tui/tui-hooks.c: Add 'source.h' include.
8843
8844 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8845
8846         * source.c (print_source_lines_base): Handle requests to print
8847         reverse line number sequences, and guard against empty lines
8848         string.
8849
8850 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * source.c (print_source_lines_base): Fix skip of '\r' if next
8853         character is '\n'.
8854
8855 2019-01-06  Tom Tromey  <tom@tromey.com>
8856
8857         * c-exp.y (struct c_parse_state) <macro_original_text,
8858         expansion_obstack>: New member.
8859         (macro_original_text, expansion_obstack): Remove globals.
8860         (scan_macro_expansion, scanning_macro_expansion)
8861         (finished_macro_expansion): Update.
8862         (scan_macro_cleanup): Remove.
8863         (yylex, c_parse): Update.
8864
8865 2019-01-06  Tom Tromey  <tom@tromey.com>
8866
8867         * c-exp.y (struct c_parse_state) <strings>: New member.
8868         (operator_stoken): Update.
8869
8870 2019-01-06  Tom Tromey  <tom@tromey.com>
8871
8872         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8873         (union type_stack_elt) <typelist_val>: Now a pointer to
8874         std::vector.
8875         (type_stack_cleanup): Don't declare.
8876         (push_typelist): Update.
8877         * parse.c (pop_typelist): Return a std::vector.
8878         (push_typelist): Take a std::vector.
8879         (follow_types): Update.  Do not free args.
8880         (type_stack_cleanup): Remove.
8881         * c-exp.y (struct c_parse_state): New.
8882         (cpstate): New global.
8883         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8884         (nonempty_typelist): Update.
8885         (func_mod): Create a new vector.
8886         (c_parse): Create a c_parse_state.
8887         (check_parameter_typelist): Do not delete params.
8888         (function_method): Update.  Do not delete type_list.
8889
8890 2019-01-06  Tom Tromey  <tom@tromey.com>
8891
8892         PR gdb/28155:
8893         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8894         check_typedef.
8895         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8896         (print_return_value): Likewise.
8897
8898 2019-01-05  Tom Tromey  <tom@tromey.com>
8899
8900         * contrib/cleanup_check.py: Remove.
8901         * contrib/gcc-with-excheck: Remove.
8902         * contrib/exsummary.py: Remove.
8903         * contrib/excheck.py: Remove.
8904
8905 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8906
8907         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8908         NULL. Initialize tpprev to NULL instead of assigning it
8909         to NULL on the next statement.
8910         * windows-nat.c (windows_delete_thread): Remove check for
8911         main_thread_id before printing thread exit notifications.
8912         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8913         Remove thread ID check against main_thread_id.
8914         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8915         windows_delete_thread.
8916         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8917
8918 2019-01-04  Tom Tromey  <tom@tromey.com>
8919
8920         * compile/compile.c (_initialize_compile): Use upper case for
8921         metasyntactic variables.
8922         * symmisc.c (_initialize_symmisc): Use upper case for
8923         metasyntactic variables.
8924         * psymtab.c (_initialize_psymtab): Use upper case for
8925         metasyntactic variables.
8926         * demangle.c (demangle_command): Use upper case for metasyntactic
8927         variables.
8928         (_initialize_demangler): Likewise.
8929         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8930         variables.
8931
8932 2019-01-03  Tom Tromey  <tom@tromey.com>
8933
8934         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8935
8936 2019-01-03  Tom Tromey  <tom@tromey.com>
8937
8938         * python/py-symtab.c (salpy_str): Update.
8939         (struct salpy_sal_object) <symtab>: Now a PyObject.
8940         (salpy_dealloc): Update.
8941         (del_objfile_sal): Use gdbpy_ref.
8942
8943 2019-01-03  Tom Tromey  <tom@tromey.com>
8944
8945         * python/py-type.c (convert_field): Use new_reference.  Return
8946         gdbpy_ref.
8947         (make_fielditem): Return gdbpy_ref.
8948         (typy_fields): Update.
8949         (typy_getitem): Update.
8950         (field_name): Return gdbpy_ref.  Use new_reference.
8951         (typy_iterator_iternext): Update.
8952
8953 2019-01-03  Tom Tromey  <tom@tromey.com>
8954
8955         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8956
8957 2019-01-03  Tom Tromey  <tom@tromey.com>
8958
8959         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8960         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8961         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8962         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8963         (pspy_set_type_printers): Likewise.
8964         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8965         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8966         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8967         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8968         (objfpy_set_type_printers): Likewise.
8969
8970 2019-01-03  Tom Tromey  <tom@tromey.com>
8971
8972         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8973         (gdbpy_print_stack): Use gdbpy_err_fetch.
8974         * python/python-internal.h (class gdbpy_err_fetch): New class.
8975         (class gdbpy_enter) <m_error_type, m_error_value,
8976         m_error_traceback>: Remove.
8977         <m_error>: New member.
8978         (gdbpy_exception_to_string): Don't declare.
8979         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8980         * python/py-value.c (convert_value_from_python): Use
8981         gdbpy_err_fetch.
8982         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8983         gdbpy_exception_to_string.
8984         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8985         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8986         gdbpy_err_fetch.
8987
8988 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8989
8990         * linux-nat.c (delete_lwp_cleanup): Delete.
8991         (struct lwp_deleter): New struct.
8992         (lwp_info_up): New typedef.
8993         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8994         lwp_info_up.
8995
8996 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8997
8998         * linux-fork.c (class scoped_switch_fork_info): New class.
8999         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9000
9001 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9002
9003         * valops.c (find_overload_match): Remove use of null_cleanup, and
9004         calls to do_cleanups.
9005
9006 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9007
9008         * compile/compile-cplus-types.c
9009         (compile_cplus_instance::decl_name): Handle changes to
9010         cp_func_name.
9011         * cp-support.c (cp_func_name): Update header comment, update
9012         return type.
9013         * cp-support.h (cp_func_name): Update return type in declaration.
9014         * valops.c (find_overload_match): Move temp_func local to top
9015         level of function and change its type.  Use temp_func to hold and
9016         delete temporary string obtained from cp_func_name.
9017
9018 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9019
9020         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9021         gdb::char_vector, remove cleanup, and update uses of `msg`.
9022
9023 2019-01-03  Jim Wilson  <jimw@sifive.com>
9024
9025         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9026
9027 2019-01-02  Tom Tromey  <tom@tromey.com>
9028
9029         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9030         (tdesc_parse_xml): Remove cleanups.
9031         * target-descriptions.h (make_cleanup_free_target_description):
9032         Don't declare.
9033         (target_desc_deleter): New struct.
9034         (target_desc_up): New typedef.
9035         * target-descriptions.c (target_desc_deleter::operator()): Rename
9036         from free_target_description.
9037         (make_cleanup_free_target_description): Remove.
9038
9039 2019-01-02  Tom Tromey  <tom@tromey.com>
9040
9041         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9042         constructor, destructor.
9043         (linespec_parser): Remove typedef.
9044         (~linespec_parser): Rename from linespec_parser_delete.
9045         (linespec_lex_to_end, linespec_complete_label)
9046         (linespec_complete): Update.
9047         (decode_line_full): Remove cleanups.
9048         (decode_line_1): Update.
9049
9050 2019-01-02  Tom Tromey  <tom@tromey.com>
9051
9052         * python/python-internal.h (inferior_to_inferior_object): Change
9053         return type.
9054         * python/py-exitedevent.c (create_exited_event_object): Update.
9055         * python/py-inferior.c (inferior_to_inferior_object): Return
9056         gdbpy_ref.
9057         (python_new_inferior, python_inferior_deleted)
9058         (thread_to_thread_object, delete_thread_object)
9059         (build_inferior_list, gdbpy_selected_inferior): Update.
9060         * python/py-infthread.c (create_thread_object): Update.  Also fail
9061         if inferior_to_inferior_object fails.
9062
9063 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9064
9065         * inferior.h (class inferior) <displaced_step_state>: New field.
9066         * infrun.h (struct displaced_step_state): Move here from
9067         infrun.c.  Initialize fields, add constructor.
9068         <inf>: Remove field.
9069         <reset>: New method.
9070         * infrun.c (struct displaced_step_inferior_state): Move to
9071         infrun.h.
9072         (displaced_step_inferior_states): Remove.
9073         (get_displaced_stepping_state): Adust.
9074         (displaced_step_in_progress_any_inferior): Adjust.
9075         (displaced_step_in_progress_thread): Adjust.
9076         (displaced_step_in_progress): Adjust.
9077         (add_displaced_stepping_state): Remove.
9078         (get_displaced_step_closure_by_addr): Adjust.
9079         (remove_displaced_stepping_state): Remove.
9080         (infrun_inferior_exit): Call displaced_step_state.reset.
9081         (use_displaced_stepping): Don't check for NULL.
9082         (displaced_step_prepare_throw): Call
9083         get_displaced_stepping_state.
9084         (displaced_step_fixup): Don't check for NULL.
9085         (prepare_for_detach): Don't check for NULL.
9086
9087 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9088
9089         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9090          in case of call that did not complete.
9091
9092 2019-01-02  Andrey Utkin  <autkin@undo.io>
9093
9094         * symfile.c (find_separate_debug_file): Fix search of debug files for
9095         remote debuggee.
9096
9097 2019-01-02  Tom Tromey  <tom@tromey.com>
9098
9099         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9100         indentation.
9101         * python/py-frame.c (frapy_older): Remove cast.
9102         (frapy_newer): Likewise.
9103         * python/py-breakpoint.c (local_setattro): Remove cast.
9104         * python/py-arch.c (archpy_name): Remove local variable.
9105         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9106
9107 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9108
9109         * unittests/basic_string_view/element_access/char/empty.cc:
9110         Fix year range in copyright header.
9111
9112 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9113
9114         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9115         Delete.
9116         <operator==>: Update with for removed field.
9117         <hash>: Likewise.
9118         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9119         <isa_features>: ...this.
9120         <abi_features>: New field.
9121         (riscv_isa_flen): Update comment.
9122         (riscv_abi_xlen): New declaration.
9123         (riscv_abi_flen): New declaration.
9124         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9125         isa_features.
9126         (riscv_abi_xlen): New function.
9127         (riscv_isa_flen): Update to get answer from isa_features.
9128         (riscv_abi_flen): New function.
9129         (riscv_has_fp_abi): Update to get answer from abi_features.
9130         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9131         xlen and flen.
9132         (riscv_call_info) <xlen, flen>: Update comment.
9133         (riscv_call_arg_struct): Remove invalid assertions
9134         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9135         is removed.
9136         (riscv_gdbarch_init): Gather isa features and abi features
9137         separately, ensure both match on the gdbarch when reusing an old
9138         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9139         a target with 64-bit float hardware.
9140
9141 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9142
9143         * source.c (search_command_helper): Stop reverse search
9144         when line 1 has been searched.
9145
9146 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9147
9148         * record-full.c (record_full_base_target::close): Rewrite
9149         record_full_core_buf_list free logic.
9150
9151 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9152
9153         * break-catch-syscall.c (print_one_catch_syscall): xfree
9154         the last text.
9155
9156 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9157
9158         * top.c (print_gdb_version): Update Copyright year in version
9159         message.
9160
9161 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9162
9163         Update copyright year range in all GDB files.
9164
9165 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9166
9167         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9168
9169 For older changes see ChangeLog-2018.
9170 \f
9171 Local Variables:
9172 mode: change-log
9173 left-margin: 8
9174 fill-column: 74
9175 version-control: never
9176 coding: utf-8
9177 End:
9178