gdb/ChangeLog

   1 2019-05-22  Tom Tromey  <tromey@adacore.com>
   2
   3         * target.c (target_follow_exec): Constify parameter.
   4         * target-delegates.c: Rebuild.
   5         * remote.c (remote_target::follow_exec): Constify parameter.
   6         * infrun.c (follow_exec): Constify parameter.
   7         * target.h (struct target_ops) <follow_exec>: Constify parameter.
   8         (target_follow_exec): Likewise.
   9
  10 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  11
  12         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
  13         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
  14
  15 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  16
  17         * NEWS: Add debugredirect and testsuite sections.
  18
  19 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
  20
  21         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
  22         target descriptions using exclusively floating point register name
  23         aliases.
  24
  25 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  26
  27         PR gdb/18644:
  28         * f-lang.c (build_fortran_types): Handle the case where
  29         gdbarch_floatformat_for_type returns a nullptr.
  30
  31 2019-05-21  Tom de Vries  <tdevries@suse.de>
  32
  33         PR cli/24587
  34         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
  35
  36 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  37
  38         PR gdb/18644:
  39         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
  40         16-byte floats.
  41         * i386-tdep.c (i386_floatformat_for_type): Use
  42         floatformats_ia64_quad for the 16-byte floating point component
  43         within a fortran 32-byte complex number.
  44
  45 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  46
  47         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
  48         delete default constructor.
  49         (find_partial_die): Update to return const struct.
  50         (partial_die_parent_scope): Move variable declaration into scope
  51         of its use and change its type to auto.
  52         (guess_partial_die_structure_name): Likewise.
  53         (partial_die_info::fixup): Likewise.
  54
  55 2019-05-17  Tom Tromey  <tromey@adacore.com>
  56
  57         * source.c (find_and_open_source): Remove cast.
  58
  59 2019-05-17  Tom Tromey  <tromey@adacore.com>
  60
  61         * annotate.c (annotate_source): Make "filename" const.
  62         * annotate.h (annotate_source): Use const.
  63
  64 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  65
  66         * disasm.c (set_disassembler_options): Send errors to stderr.
  67
  68 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  69
  70         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  71         (cli_interp_base::set_logging): Check debug_redirect.
  72         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  73         * cli/cli-logging.c (debug_redirect): Add static variable.
  74         (pop_output_files): Add default param.
  75         (handle_redirections): Print debug setting.
  76         (show_logging_command): Likewise.
  77         (_initialize_cli_logging): Add debugredirect command.
  78         * interps.c (current_interp_set_logging): Add debug_redirect
  79         parameter.
  80         * interps.h (set_logging): Add debug_redirect parameter.
  81         (current_interp_set_logging): Likewise.
  82         * mi/mi-common.h: Likewise.
  83         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  84
  85 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  86             Tom Tromey  <tromey@adacore.com>
  87
  88         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
  89         directly.
  90         * cli/cli-interp.h (make_logging_output): Remove declaration.
  91         * cli/cli-logging.c (make_logging_output): Remove function.
  92         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
  93         directly.
  94         * ui-file.c (tee_file::tee_file): Remove bools.
  95         (tee_file::~tee_file): Remove deletes.
  96         * ui-file.h (tee_file): Remove bools.
  97
  98 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
  99
 100         * mi/mi-cmds.h (mi_cmd_complete): New function.
 101         * mi/mi-main.c (mi_cmd_complete): Likewise.
 102         * mi/mi-cmds.c: Define new MI command -complete.
 103         * NEWS: Mention new -complete command.
 104
 105 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 106
 107         * completer.h (complete): New function.
 108         * completer.c (complete): Likewise.
 109         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 110         function defined in completer.h.
 111
 112 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 113
 114        * MAINTAINERS (Write After Approval): Add myself.
 115
 116 2019-05-17  Tom de Vries  <tdevries@suse.de>
 117
 118         PR gdb/24094
 119         * dwarf2read.c (struct cu_partial_die_info): New struct.
 120         (find_partial_die): Return cu_partial_die_info.
 121         (partial_die_parent_scope, guess_partial_die_structure_name)
 122         (partial_die_info::fixup): Handle new return type of find_partial_die.
 123
 124 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 125
 126         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 127         "std::string", simplifying the algorithm.
 128
 129 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 130
 131         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 132         (stap_static_probe_ops::get_probes): Likewise.
 133
 134 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 135
 136         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 137         '-')" and "else if".
 138         (stap_parse_single_operand): Join checks for
 139         "gdbarch_stap_parse_special_token_p" and
 140         "gdbarch_stap_parse_special_token" in the same "if" statement.
 141         Invert check when verifying for operation on register
 142         displacement.
 143
 144 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 145
 146         * stap-probe.c (stap_get_opcode): Update comment.
 147         (stap_get_expected_argument_type): Likewise.
 148         (handle_stap_probe): Likewise.
 149
 150 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 151
 152         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 153         return type to 'bool'.  Adjust comment.  Use 'bool' when
 154         appropriate.
 155         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 156         * stap-probe.c (stap_parse_argument_1): Likewise.
 157         (stap_is_operator): Likewise.
 158         (stap_is_generic_prefix): Likewise.
 159         (stap_is_register_prefix): Likewise.
 160         (stap_is_register_indirection_prefix): Likewise.
 161         (stap_is_integer_prefix): Likewise.
 162         (stap_generic_check_suffix): Likewise.
 163         (stap_check_integer_suffix): Likewise.
 164         (stap_check_register_suffix): Likewise.
 165         (stap_check_register_indirection_suffix): Likewise.
 166         (stap_parse_register_operand): Likewise.
 167         (stap_parse_single_operand): Likewise.
 168         (stap_parse_argument_1): Likewise.
 169         (stap_probe::get_argument_count): Likewise.
 170         (stap_is_operator): Likewise.
 171
 172 2019-05-16  Tom Tromey  <tromey@adacore.com>
 173
 174         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 175         keyword to foreach.
 176
 177 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 178
 179         * linux-thread-db.c (try_thread_db_load_1): Change return type
 180         to bool.
 181         (try_thread_db_load): Likewise.
 182         (try_thread_db_load_from_pdir_1): Likewise.
 183         (try_thread_db_load_from_pdir): Likewise.
 184         (try_thread_db_load_from_sdir): Likewise.
 185         (try_thread_db_load_from_dir): Likewise.
 186         (thread_db_load_search): Likewise.
 187         (has_libpthread): Likewise.
 188         (thread_db_load): Likewise.
 189
 190 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 191
 192         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 193         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 194         NULL, and complain/return if that's the case.
 195
 196 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 197
 198         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 199         (advance, posn, abstract_read_memory): New functions.
 200         [struct mem_read_abstraction]: New struct.
 201         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 202
 203 2019-05-14  Tom Tromey  <tromey@adacore.com>
 204
 205         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 206         value is not lval_memory.
 207
 208 2019-05-14  Tom Tromey  <tromey@adacore.com>
 209
 210         * solib.c (info_sharedlibrary_command): Style the file name.
 211
 212 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 213
 214         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 215         (aarch64_vnv_type): Likewise.
 216         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 217         * common/tdesc.c: Likewise.
 218         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 219         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 220         * features/aarch64-fpu.xml: Add ieee half view.
 221         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 222         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 223         * gdbtypes.h (struct builtin_type): Likewise.
 224         (struct objfile_type): Likewise.
 225
 226 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 227
 228         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 229         typo.
 230         * location.h (string_to_event_location): Likewise.
 231
 232 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 233
 234         GDB 8.3 released.
 235
 236 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 237
 238         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 239         New variable declaration.
 240         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 241         New variable.
 242         (print_one_breakpoint): Use ui_out::test_flags and new global
 243         variable to compute use_fixed_output.
 244         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 245         Remove.
 246         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 247         (mi_multi_location_breakpoint_output_fixed): Remove.
 248         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 249         new variable.
 250         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 251         fix_multi_location_breakpoint_output flag if version >= 3.
 252         * ui-out.h (enum ui_out_flag)
 253         <fix_multi_location_breakpoint_output>: New enumerator.
 254
 255 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 256
 257         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 258
 259 2019-05-10  Tom Tromey  <tromey@adacore.com>
 260
 261         * ada-lang.c (catch_ada_completer): New function.
 262         (_initialize_ada_language): Use it.
 263
 264 2019-05-10  Tom Tromey  <tromey@adacore.com>
 265
 266         * thread.c (print_thread_info): Make "requested_threads" const.
 267         * gdbthread.h (print_thread_info): Make "requested_threads"
 268         const.
 269         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 270         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 271
 272 2019-05-08  Tom Tromey  <tom@tromey.com>
 273
 274         * gdbtypes.c (objfile_type_data): Change type.
 275         (objfile_type, _initialize_gdbtypes): Update.
 276
 277 2019-05-08  Tom Tromey  <tom@tromey.com>
 278
 279         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 280         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 281         (_initialize_dwarf2_frame): Update.
 282
 283 2019-05-08  Tom Tromey  <tom@tromey.com>
 284
 285         * objc-lang.c (objc_objfile_data): Change type.
 286         (find_methods): Update.
 287         (_initialize_objc_lang): Remove.
 288
 289 2019-05-08  Tom Tromey  <tom@tromey.com>
 290
 291         * stabsread.c (rs6000_builtin_type_data): Change type.
 292         (rs6000_builtin_type, _initialize_stabsread): Update.
 293
 294 2019-05-08  Tom Tromey  <tom@tromey.com>
 295
 296         * mips-tdep.c (mips_pdr_data): Remove.
 297         (_initialize_mips_tdep): Update.
 298
 299 2019-05-08  Tom Tromey  <tom@tromey.com>
 300
 301         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 302         (hppa_init_objfile_priv_data, read_unwind_info)
 303         (find_unwind_entry, _initialize_hppa_tdep): Update.
 304
 305 2019-05-08  Tom Tromey  <tom@tromey.com>
 306
 307         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 308         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 309         on obstack.
 310         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 311
 312 2019-05-08  Tom Tromey  <tom@tromey.com>
 313
 314         * mdebugread.c (basic_type_data): Change type.
 315         (basic_type, _initialize_mdebugread): Update.
 316
 317 2019-05-08  Tom Tromey  <tom@tromey.com>
 318
 319         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 320
 321 2019-05-08  Tom Tromey  <tom@tromey.com>
 322
 323         * nto-tdep.c (nto_inferior_data_reg): Change type.
 324         (nto_inferior_data): Update.
 325         (nto_inferior_data_cleanup, nto_new_inferior_data)
 326         (_initialize_nto_tdep): Remove.
 327         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 328
 329 2019-05-08  Tom Tromey  <tom@tromey.com>
 330
 331         * ada-lang.c (struct ada_inferior_data): Add initializers.
 332         (ada_inferior_data): Change type.
 333         (ada_inferior_data_cleanup): Remove.
 334         (get_ada_inferior_data, ada_inferior_exit)
 335         (struct ada_pspace_data): Add initializers, destructor.
 336         (ada_pspace_data_handle): Change type.
 337         (get_ada_pspace_data): Update.
 338         (ada_pspace_data_cleanup): Remove.
 339
 340 2019-05-08  Tom Tromey  <tom@tromey.com>
 341
 342         * coffread.c (struct coff_symfile_info): Add initializers.
 343         (coff_objfile_data_key): Move lower.  Change type.
 344         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 345         Update.
 346         (coff_free_info): Remove.
 347
 348 2019-05-08  Tom Tromey  <tom@tromey.com>
 349
 350         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 351         (fbsd_pspace_data_handle): Move lower.  Change type.
 352         (get_fbsd_pspace_data): Update.
 353         (fbsd_pspace_data_cleanup): Remove.
 354         (_initialize_fbsd_tdep): Update.
 355
 356 2019-05-08  Tom Tromey  <tom@tromey.com>
 357
 358         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 359         (get_ada_tasks_pspace_data): Update.
 360         (ada_tasks_pspace_data_cleanup): Remove.
 361         (_initialize_tasks): Update.
 362         (ada_tasks_inferior_data_handle): Change type.
 363         (get_ada_tasks_inferior_data): Update.
 364         (ada_tasks_inferior_data_cleanup): Remove.
 365         (struct ada_tasks_pspace_data): Add initializers.
 366
 367 2019-05-08  Tom Tromey  <tom@tromey.com>
 368
 369         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 370         * symfile-debug.c (debug_sym_get_probes): Change type.
 371         * stap-probe.c (handle_stap_probe):
 372         (stap_static_probe_ops::get_probes): Change type.
 373         * probe.h (class static_probe_ops) <get_probes>: Change type.
 374         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 375         (parse_probes_in_pspace): Update.
 376         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 377         Update.
 378         (any_static_probe_ops::get_probes): Change type.
 379         * elfread.c (elfread_data): New typedef.
 380         (probe_key): Change type.
 381         (elf_get_probes): Likewise.  Update.
 382         (probe_key_free): Remove.
 383         (_initialize_elfread): Update.
 384         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 385         Change type.
 386         (dtrace_process_dof_probe, dtrace_process_dof)
 387         (dtrace_static_probe_ops::get_probe): Change type.
 388
 389 2019-05-08  Tom Tromey  <tom@tromey.com>
 390
 391         * xcoffread.c (struct xcoff_symfile_info): Rename from
 392         coff_symfile_info.  Add initializers.
 393         (xcoff_objfile_data_key): Move lower.  Change type.
 394         (XCOFF_DATA): Rewrite.
 395         (xcoff_free_info): Remove.
 396         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 397         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 398         (xcoff_initial_scan): Update.
 399
 400 2019-05-08  Tom Tromey  <tom@tromey.com>
 401
 402         * solib-svr4.c (struct svr4_info): Add initializers and
 403         destructor.
 404         <probes_table>: Now an htab_up.
 405         (solib_svr4_pspace_data): Change type.
 406         (free_probes_table): Simplify.
 407         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 408         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 409         (probes_table_remove_objfile_probes, register_solib_event_probe)
 410         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 411         (_initialize_svr4_solib): Update.
 412
 413 2019-05-08  Tom Tromey  <tom@tromey.com>
 414
 415         * remote.c (remote_pspace_data): Change type.
 416         (remote_pspace_data_cleanup): Remove.
 417         (get_remote_exec_file, set_pspace_remote_exec_file)
 418         (_initialize_remote): Update.
 419
 420 2019-05-08  Tom Tromey  <tom@tromey.com>
 421
 422         * breakpoint.c (breakpoint_objfile_key): Change type.
 423         (get_breakpoint_objfile_data): Update.
 424         (free_breakpoint_objfile_data): Remove.
 425         (_initialize_breakpoint): Update.
 426
 427 2019-05-08  Tom Tromey  <tom@tromey.com>
 428
 429         * linux-tdep.c (struct linux_info): Add initializers.
 430         (linux_inferior_data): Move.  Change type.
 431         (invalidate_linux_cache_inf): Update.
 432         (linux_inferior_data_cleanup): Remove.
 433         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 434
 435 2019-05-08  Tom Tromey  <tom@tromey.com>
 436
 437         * auxv.c (auxv_inferior_data): Move.  Change type.
 438         (auxv_inferior_data_cleanup): Remove.
 439         (invalidate_auxv_cache_inf): Rewrite.
 440         (get_auxv_inferior_data, _initialize_auxv): Update.
 441
 442 2019-05-08  Tom Tromey  <tom@tromey.com>
 443
 444         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 445         (symfile_debug_objfile_data_key): Change type.
 446         (symfile_debug_installed, debug_qf_has_symbols)
 447         (debug_qf_find_last_source_symtab)
 448         (debug_qf_forget_cached_source_info)
 449         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 450         (debug_qf_print_stats, debug_qf_dump)
 451         (debug_qf_expand_symtabs_for_function)
 452         (debug_qf_expand_all_symtabs)
 453         (debug_qf_expand_symtabs_with_fullname)
 454         (debug_qf_map_matching_symbols)
 455         (debug_qf_expand_symtabs_matching)
 456         (debug_qf_find_pc_sect_compunit_symtab)
 457         (debug_qf_map_symbol_filenames)
 458         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 459         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 460         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 461         (debug_sym_read_linetable, debug_sym_relocate): Update.
 462         (symfile_debug_free_objfile): Remove.
 463         (install_symfile_debug_logging, _initialize_symfile_debug):
 464         Update.
 465
 466 2019-05-08  Tom Tromey  <tom@tromey.com>
 467
 468         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 469         allocate_on_obstack.
 470         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 471         (get_dwarf2_per_objfile): Update.
 472         (set_dwarf2_per_objfile): Remove.
 473         (dwarf2_has_info, dwarf2_get_section_info): Update.
 474         (dwarf2_free_objfile): Remove.
 475         (_initialize_dwarf2_read): Update.
 476
 477 2019-05-08  Tom Tromey  <tom@tromey.com>
 478
 479         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 480         initializers.
 481         <unsupported_script_warning_printed,
 482         script_not_found_warning_printed>: Now bool.
 483         (auto_load_pspace_data): Change type.
 484         (~auto_load_pspace_info): Rename from
 485         auto_load_pspace_data_cleanup.
 486         (get_auto_load_pspace_data, init_loaded_scripts_info)
 487         (clear_section_scripts, maybe_print_unsupported_script_warning)
 488         (maybe_print_script_not_found_warning, _initialize_auto_load):
 489         Update.
 490
 491 2019-05-08  Tom Tromey  <tom@tromey.com>
 492
 493         * objfiles.c (objfile_pspace_info): Add destructor and
 494         initializers.
 495         (objfiles_pspace_data): Change type.
 496         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 497         (get_objfile_pspace_data): Update.
 498         (objfiles_bfd_data): Change type.
 499         (get_objfile_bfd_data): Update.
 500         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 501
 502 2019-05-08  Tom Tromey  <tom@tromey.com>
 503
 504         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 505         Change type.
 506         (get_catch_syscall_inferior_data): Update.
 507         (catch_syscall_inferior_data_cleanup): Remove.
 508         (_initialize_break_catch_syscall): Update.
 509
 510 2019-05-08  Tom Tromey  <tom@tromey.com>
 511
 512         * inflow.c (struct terminal_info): Add destructor and
 513         initializers.
 514         (inflow_inferior_data): Change type.
 515         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 516         (get_inflow_inferior_data, inflow_inferior_exit)
 517         (swap_terminal_info, _initialize_inflow): Update.
 518
 519 2019-05-08  Tom Tromey  <tom@tromey.com>
 520
 521         * target-dcache.c (target_dcache_cleanup): Remove.
 522         (target_dcache_aspace_key): Change type.
 523         (target_dcache_init_p, target_dcache_invalidate)
 524         (target_dcache_get, target_dcache_get_or_init)
 525         (_initialize_target_dcache): Update.
 526         * dcache.h (struct dcache_deleter): New.
 527
 528 2019-05-08  Tom Tromey  <tom@tromey.com>
 529
 530         * symtab.c (struct symbol_cache): Add destructor and
 531         initializers.
 532         (symbol_cache_key): Move.  Change type.
 533         (make_symbol_cache, free_symbol_cache): Remove.
 534         (get_symbol_cache): Update.
 535         (symbol_cache_cleanup): Remove.
 536         (ALL_PSPACES, symbol_cache_flush)
 537         (maintenance_print_symbol_cache)
 538         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 539         Update.
 540
 541 2019-05-08  Tom Tromey  <tom@tromey.com>
 542
 543         * symtab.c (struct main_info): Add destructor and initializers.
 544         (main_progspace_key): Move.  Change type.
 545         (get_main_info): Update.
 546         (main_info_cleanup): Remove.
 547         (_initialize_symtab): Update.
 548
 549 2019-05-08  Tom Tromey  <tom@tromey.com>
 550
 551         * registry.h (DECLARE_REGISTRY): Define the _key class.
 552
 553 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 554
 555         * NEWS: Merge two 'New commands' sections.
 556
 557 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 558
 559         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 560         parameter and use Ada language definition instead.
 561         (ada_val_print_ptr): Remove unused language parameter.
 562         (ada_val_print_num): Remove language parameter and use Ada language
 563         definition instead.
 564         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 565         parameter.
 566         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 567         parameter and use Ada language definition instead.
 568         (ada_val_print_1): Update all ada_val_print_xxx calls.
 569         Remove language parameter.
 570         (ada_val_print): Update ada_val_print_1 call.
 571
 572 2019-05-08  Tom Tromey  <tromey@adacore.com>
 573
 574         * remote.c (remote_hw_watchpoint_limit)
 575         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 576         Now static.
 577
 578 2019-05-08  Tom Tromey  <tromey@adacore.com>
 579
 580         * maint.c (_initialize_maint_cmds): Move initialization code to
 581         remote.c.
 582         (watchdog, show_watchdog): Move to remote.c.
 583         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 584         "watchdog" static.
 585         (_initialize_remote): Move initialization code from maint.c.
 586         * defs.h (watchdog): Don't declare.
 587
 588 2019-05-08  Tom Tromey  <tromey@adacore.com>
 589
 590         * tui/tui-interp.c: Include main.h.
 591         * interps.c: Include main.h.
 592         * main.h (interpreter_p): Declare.
 593         * defs.h (interpreter_p): Don't declare.
 594
 595 2019-05-08  Tom Tromey  <tromey@adacore.com>
 596
 597         * dwarf2loc.c: Include dwarf2read.h.
 598         * defs.h (read_unsigned_leb128): Don't declare.
 599         * dwarf2read.h (read_unsigned_leb128): Declare.
 600
 601 2019-05-08  Tom Tromey  <tromey@adacore.com>
 602
 603         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 604         method.
 605
 606 2019-05-08  Tom Tromey  <tromey@adacore.com>
 607
 608         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 609         when no wrap column is set.
 610
 611 2019-05-08  Tom Tromey  <tromey@adacore.com>
 612
 613         * c-lang.c (c_get_string): Handle non-C-style arrays.
 614
 615 2019-05-08  Tom Tromey  <tromey@adacore.com>
 616
 617         * typeprint.c (print_offset_data::update): Print the bit offset,
 618         not the number of bits remaining.
 619
 620 2019-05-08  Tom Tromey  <tromey@adacore.com>
 621
 622         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 623         padding at end of comment.
 624
 625 2019-05-08  Tom Tromey  <tromey@adacore.com>
 626
 627         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 628         Compare main types.
 629
 630 2019-05-06  Tom Tromey  <tom@tromey.com>
 631
 632         * common/scoped_mmap.c: Include common-defs.h.
 633         * common/scoped_mmap.h: Don't include config.h.
 634
 635 2019-05-04  Tom Tromey  <tom@tromey.com>
 636
 637         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 638         (struct aarch64_call_info): Add initializers.
 639         <si>: Now a std::vector.
 640         (pass_on_stack, aarch64_push_dummy_call): Update.
 641
 642 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 643             Tom Tromey  <tom@tromey.com>
 644
 645         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 646         (ppc_threads): Now a std::vector.  Now static.
 647         (hwdebug_find_thread_points_by_tid)
 648         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 649         Update.
 650
 651 2019-05-04  Tom Tromey  <tom@tromey.com>
 652
 653         * arc-tdep.c (arc_tdesc_init): Return bool.
 654
 655 2019-05-04  Tom Tromey  <tom@tromey.com>
 656
 657         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 658         Use gdb_assert_not_reached.
 659
 660 2019-05-04  Tom Tromey  <tom@tromey.com>
 661
 662         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 663         "false".
 664
 665 2019-05-04  Tom Tromey  <tom@tromey.com>
 666
 667         * arc-tdep.c (arc_tdesc_init): Use bool.
 668
 669 2019-05-04  Tom Tromey  <tom@tromey.com>
 670
 671         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 672
 673 2019-05-04  Tom Tromey  <tom@tromey.com>
 674
 675         * cli/cli-cmds.c (valid_command_p): Return bool.
 676
 677 2019-05-04  Tom Tromey  <tom@tromey.com>
 678
 679         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 680         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 681
 682 2019-05-04  Raul Tambre  <raul@tambre.ee>
 683
 684         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 685         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 686         operator for comparison.
 687
 688 2019-05-04  Tom Tromey  <tom@tromey.com>
 689
 690         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 691         (lookup_partial_symbol, print_partial_symbols)
 692         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 693         (psymbol_compare): Update.
 694         (add_psymbol_to_bcache): Clear the entire psymbol.
 695         (maintenance_check_psymtabs): Update.
 696         * psympriv.h (struct partial_symbol): Don't derive from
 697         general_symbol_info.
 698         <obj_section, unrelocated_address, address,
 699         set_unrelocated_address>: Update.
 700         <ginfo>: New member.
 701         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 702         (debug_names::write_psymbols): Update.
 703
 704 2019-05-04  Tom de Vries  <tdevries@suse.de>
 705
 706         * contrib/cc-with-tweaks.sh: Support -n arg.
 707
 708 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 709
 710         * corelow.c (core_target::detach): Ensure frame cache and
 711         register caches are cleared.
 712         inferior.c (exit_inferior_1): Likewise.
 713
 714 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 715             Tom Tromey  <tom@tromey.com>
 716
 717         * dictionary.c (collate_pending_symbols_by_language): Remove
 718         "struct" from foreach.
 719         * symtab.c (lookup_global_symbol_from_objfile)
 720         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 721         foreach.
 722         * ser-tcp.c (net_open): Remove "struct" from foreach.
 723         * objfiles.c (objfile_relocate, objfile_rebase)
 724         (objfile_has_symbols): Remove "struct" from foreach.
 725         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 726         from foreach.
 727         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 728         foreach.
 729         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 730         "struct" from foreach.
 731         * ada-lang.c (create_excep_cond_exprs)
 732         (ada_exception_catchpoint_cond_string): Remove "struct" from
 733         foreach.
 734
 735 2019-05-03  Tom Tromey  <tromey@adacore.com>
 736
 737         * ada-exp.y (convert_char_literal): Check suffix of each
 738         enumerator.
 739
 740 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 741
 742         PR ada/21406:
 743         * ada-exp.y (yywrap): Don't define.
 744         * ada-lex.l (%option): Add noyywrap
 745         (yywrap): Remove.
 746
 747 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 748
 749         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 750         _WIN32_WINNT to the XP level, unless already defined to a higher
 751         level.
 752
 753         * unittests/parse-connection-spec-selftests.c:
 754         * ser-tcp.c:
 755         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 756         override.
 757
 758         * symfile.c (find_separate_debug_file): Remove colon from the
 759         drive spec of DOS/Windows file names of the target, so that the
 760         file name produced from DEBUGDIR and the target's directory will
 761         be valid on DOS/Windows systems.
 762
 763 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 764
 765         * rust-lang.c (val_print_struct): Handle printing structures
 766         containing strings.
 767
 768 2019-05-02  Tom Tromey  <tromey@adacore.com>
 769
 770         * valarith.c (_initialize_valarith): Remove.
 771
 772 2019-05-01  Tom Tromey  <tromey@adacore.com>
 773
 774         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 775         bitfields.
 776
 777 2019-05-01  Tom Tromey  <tromey@adacore.com>
 778
 779         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 780         for big-endian copies.
 781
 782 2019-04-30  Ali Tamur  <tamur@google.com>
 783         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 784         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 785         (read_3_bytes): New function.
 786
 787 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 788
 789         * windows-nat.c (main_thread_id): Delete.
 790         (handle_output_debug_string): Replace main_thread_id by
 791         current_event.dwThreadId.
 792         (fake_create_process): Likewise.
 793         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 794         Do not set main_thread_id.
 795         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 796         current_event.dwThreadId.
 797         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 798
 799 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 800
 801         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 802         Use current_event.dwThreadId instead of main_thread_id.
 803
 804 2019-04-30  Tom Tromey  <tromey@adacore.com>
 805
 806         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 807         (create_excep_cond_exprs): Iterate over program spaces.
 808         (ada_exception_catchpoint_cond_string): Examine all minimal
 809         symbols for exception types.
 810
 811 2019-04-30  Tom Tromey  <tromey@adacore.com>
 812
 813         PR c++/24470:
 814         * dwarf2read.c (process_structure_scope): Handle case where type
 815         has template parameters but no symbol was created.
 816
 817 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 818             Chris January  <chris.january@arm.com>
 819
 820         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 821         qualifier.
 822         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 823
 824 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 825
 826         * f-typeprint.c (f_print_type): Update rules for printing
 827         whitespace.
 828         (f_type_print_varspec_suffix): Likewise.
 829
 830 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 831             Chris January  <chris.january@arm.com>
 832
 833         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 834         function arguments.
 835
 836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * f-lang.c (build_fortran_types): Change name of void type to
 839         lower case.
 840         * f-typeprint.c (f_type_print_base): Print the name of the void
 841         type, rather than a fixed string.
 842         * f-valprint.c (f_decorations): Use lower case void string.
 843
 844 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 845             Chris January  <chris.january@arm.com>
 846
 847         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 848         types for Fortran.
 849
 850 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 851             Chris January  <chris.january@arm.com>
 852             David Lecomber  <david.lecomber@arm.com>
 853
 854         * f-exp.y (BINOP_INTRINSIC): New token.
 855         (exp): New parser rule handling BINOP_INTRINSIC.
 856         (f77_keywords): Add new builtin procedures.
 857         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 858         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 859         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 860         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 861         (print_unop_subexp_f): New function.
 862         (print_binop_subexp_f): New function.
 863         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 864         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 865         (dump_subexp_body_f): Likewise.
 866         (operator_check_f): Likewise.
 867         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 868         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 869
 870 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 871
 872         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 873         UNOP_KIND.
 874         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 875         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 876         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 877         (operator_length_f): New fuction.
 878         (print_subexp_f): New function.
 879         (op_name_f): New function.
 880         (dump_subexp_body_f): New function.
 881         (operator_check_f): New function.
 882         (exp_descriptor_f): Replace standard expression handling functions
 883         with new functions.
 884         * gdb/fortran-operator.def: New file.
 885         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 886         * gdb/std-operator.def: Remove UNOP_KIND.
 887
 888 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * std-operator.def: Remove unbalanced, stray double quote
 891         character.
 892
 893 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 894             Chris January  <chris.january@arm.com>
 895             Daniel Everett  <daniel.everett@arm.com>
 896             Nick Forrington  <nick.forrington@arm.com>
 897             Richard Bunt  <richard.bunt@arm.com>
 898
 899         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 900         of depth when printing anonymous structs or unions.
 901         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 902         Don't print either the top-level value, or the children if the
 903         max-depth is exceeded.
 904         (ppscm_print_children): When printing the key of a map, allow one
 905         extra level of depth.
 906         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 907         print either the top-level value, or the children if the max-depth
 908         is exceeded.
 909         (print_children): When printing the key of a map, allow one extra
 910         level of depth.
 911         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 912         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 913         (user_print_options): Initialise max_depth field.
 914         (val_print_scalar_or_string_type_p): New function.
 915         (val_print): Check to see if the max depth has been reached.
 916         (val_print_check_max_depth): Define new function.
 917         (show_print_max_depth): New function.
 918         (_initialize_valprint): Add 'print max-depth' option.
 919         * valprint.h (struct value_print_options) <max_depth>: New field.
 920         (val_print_check_max_depth): Declare new function.
 921         * NEWS: Document new feature.
 922
 923 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * ada-lang.c (ada_language_defn): Initialise new field.
 926         * c-lang.c (c_is_string_type_p): New function.
 927         (c_language_defn): Initialise new field.
 928         (cplus_language_defn): Initialise new field.
 929         (asm_language_defn): Initialise new field.
 930         (minimal_language_defn): Initialise new field.
 931         * c-lang.h (c_is_string_type_p): Declare new function.
 932         * d-lang.c (d_language_defn): Initialise new field.
 933         * f-lang.c (f_is_string_type_p): New function.
 934         (f_language_defn): Initialise new field.
 935         * go-lang.c (go_is_string_type_p): New function.
 936         (go_language_defn): Initialise new field.
 937         * language.c (default_is_string_type_p): New function.
 938         (unknown_language_defn): Initialise new field.
 939         (auto_language_defn): Initialise new field.
 940         * language.h (struct language_defn) <la_is_string_type_p>: New
 941         member variable.
 942         (default_is_string_type_p): Declare new function.
 943         * m2-lang.c (m2_language_defn): Initialise new field.
 944         * objc-lang.c (objc_language_defn): Initialise new field.
 945         * opencl-lang.c (opencl_language_defn): Initialise new field.
 946         * p-lang.c (pascal_is_string_type_p): New function.
 947         (pascal_language_defn): Initialise new field.
 948         * rust-lang.c (rust_is_string_type_p): New function.
 949         (rust_language_defn): Initialise new field.
 950
 951 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 952
 953         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 954         New field.
 955         * ada-lang.c (ada_language_defn): Initialise new field.
 956         * c-lang.c (c_language_defn): Likewise.
 957         (cplus_language_defn): Likewise.
 958         (asm_language_defn): Likewise.
 959         (minimal_language_defn): Likewise.
 960         * d-lang.c (d_language_defn): Likewise.
 961         * f-lang.c (f_language_defn): Likewise.
 962         * go-lang.c (go_language_defn): Likewise.
 963         * language.c (unknown_language_defn): Likewise.
 964         (auto_language_defn): Likewise.
 965         * m2-lang.c (m2_language_defn): Likewise.
 966         * objc-lang.c (objc_language_defn): Likewise.
 967         * opencl-lang.c (opencl_language_defn): Likewise.
 968         * p-lang.c (pascal_language_defn): Likewise.
 969         * rust-lang.c (rust_language_defn): Likewise.
 970
 971 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 972
 973         * ada-lang.c (ada_is_character_type): Change return type to bool.
 974         (ada_is_string_type): Likewise.
 975         * ada-lang.h (ada_is_character_type): Update declaration
 976         (ada_is_string_type): Likewise.
 977
 978 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 979
 980         Support style in 'frame|thread apply'
 981
 982         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 983         * record.c (record_start, record_stop): Update callers of
 984         execute_command_to_string with false.
 985         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 986         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 987         methods.
 988         (class string_file): New constructor with term_out parameter.
 989         Override methods term_out and can_emit_style_escape.  New member
 990         term_out.
 991         (class stdio_file): Override can_emit_style_escape.
 992         (class tee_file): Override term_out and can_emit_style_escape.
 993         * utils.h (can_emit_style_escape): Remove.
 994         * utils.c (can_emit_style_escape): Likewise.
 995         Update all callers of can_emit_style_escape (SOMESTREAM) to
 996         SOMESTREAM->can_emit_style_escape.
 997         * source-cache.c (source_cache::get_source_lines): Likewise.
 998         * stack.c (frame_apply_command_count): Call execute_command_to_string
 999         passing the term_out characteristic of the current gdb_stdout.
1000         * thread.c (thr_try_catch_cmd): Likewise.
1001         * top.c (execute_command_to_string): pass term_out parameter
1002         to construct the string_file for the command output.
1003         * ui-file.c (term_cli_styling): New function (most code moved
1004         from utils.c can_emit_style_escape).
1005         (string_file::string_file, string_file::can_emit_style_escape,
1006         stdio_file::can_emit_style_escape, tee_file::term_out,
1007         tee_file::can_emit_style_escape): New functions.
1008
1009 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1010
1011         * NEWS: Mention the new set|show may-call-functions.
1012         * infcall.c (may_call_functions_p): New variable.
1013         (show_may_call_functions_p): New function.
1014         (call_function_by_hand_dummy): Throws an error if not
1015         may-call-functions.
1016         (_initialize_infcall): Call add_setshow_boolean_cmd for
1017         may-call-functions.
1018
1019 2019-04-25  Keith Seitz  <keiths@redhat.com>
1020
1021         PR c++/24367
1022         * cp-support.c (inspect_type): Don't attempt substitutions
1023         of symbol with the same name.
1024
1025 2019-04-25  Tom Tromey  <tromey@adacore.com>
1026
1027         PR gdb/24475:
1028         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1029         static.
1030
1031 2019-04-25  Tom Tromey  <tromey@adacore.com>
1032
1033         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1034         rvalue reference.
1035         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1036         (gdb_xml_parser::parse): Use std::move.
1037         * python/python-internal.h (gdbpy_convert_exception): Take a const
1038         reference.
1039         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1040         std::move.
1041         * python/py-utils.c (gdbpy_convert_exception): Take a const
1042         reference.
1043         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1044         Use std::move.
1045         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1046         Use std::move.
1047         * mi/mi-main.c (mi_print_exception): Take a const reference.
1048         * main.c (handle_command_errors): Take a const reference.
1049         * linespec.c (parse_linespec): Use std::move.
1050         * infcall.c (run_inferior_call): Use std::move.
1051         (call_function_by_hand_dummy): Use std::move.
1052         * exec.c (try_open_exec_file): Use std::move.
1053         * exceptions.h (exception_print, exception_fprintf)
1054         (exception_print_same): Update.
1055         * exceptions.c (print_exception, exception_print)
1056         (exception_fprintf, exception_print_same): Change parameters to
1057         const reference.
1058         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1059         * common/new-op.c: Use std::move.
1060         * common/common-exceptions.h (struct gdb_exception): Add move
1061         constructor.
1062         (struct gdb_exception_error, struct gdb_exception_quit, struct
1063         gdb_quit_bad_alloc): Change constructor to move constructor.
1064         (throw_exception): Change parameter to rvalue reference.
1065         * common/common-exceptions.c (throw_exception): Take rvalue
1066         reference.
1067         * cli/cli-interp.c (safe_execute_command): Use std::move.
1068         * breakpoint.c (insert_bp_location, location_to_sals): Use
1069         std::move.
1070
1071 2019-04-25  Tom Tromey  <tromey@adacore.com>
1072
1073         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1074         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1075         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1076         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1077         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1078         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1079         guile/scm-value.c: Use unpack.
1080         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1081         gdbscm_gdb_exception.
1082         (gdbscm_throw_gdb_exception): Likewise.
1083         (struct gdbscm_gdb_exception): New.
1084         (unpack): New function.
1085         (gdbscm_wrap): Use unpack.
1086
1087 2019-04-25  Tom Tromey  <tromey@adacore.com>
1088
1089         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1090         (gdb_rl_callback_handler): Use std::move.
1091         * common/common-exceptions.h (struct gdb_exception): Add move
1092         assignment operator.
1093         (throw_exception_sjlj): Change "exception" to const reference.
1094         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1095         (throw_exception_sjlj): Change "exception" to const reference.
1096
1097 2019-04-25  Tom Tromey  <tromey@adacore.com>
1098
1099         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1100         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1101         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1102         Update.
1103         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1104         Update.
1105         * mi/mi-interp.c (mi_interp::exec): Update.
1106         * linespec.c (parse_linespec): Update.
1107         * infcall.c (run_inferior_call): Update.
1108         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1109         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1110         (gdbscm_lookup_global_symbol): Update.
1111         * guile/scm-param.c (gdbscm_parameter_value): Update.
1112         * guile/scm-frame.c (gdbscm_frame_read_register)
1113         (gdbscm_frame_read_var): Update.
1114         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1115         * exec.c (try_open_exec_file): Update.
1116         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1117         (gdb_rl_callback_handler): Update.
1118         * common/common-exceptions.h (exception_none): Don't declare.
1119         * common/common-exceptions.c (exception_none): Don't define.
1120         (struct catcher) <exception>: Update.
1121         * cli/cli-interp.c (safe_execute_command): Update.
1122         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1123
1124 2019-04-25  Ali Tamur  <tamur@google.com>
1125
1126         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1127         (read_attribute_value): Likewise.
1128         (dwarf2_read_addr_index): Update comment.
1129         (read_str_index): Add DW_FORM_strx.
1130         (dwarf2_string_attr): Likewise.
1131         (dwarf2_const_value_attr): Likewise.
1132         (dump_die_shallow): Likewise.
1133         (dwarf2_fetch_constant_bytes): Likewise.
1134         (skip_form_bytes): Likewise.
1135         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1136
1137 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1138
1139         PR corefiles/11608
1140         PR corefiles/18187
1141         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1142         OFFSET.  Verify if current mapping contains an ELF header.
1143         (linux_find_memory_regions_full): Adjust call to
1144         dump_mapping_p.
1145
1146 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1147             Kang Li <kanglictf@gmail.com>
1148
1149         PR gdb/21600
1150
1151         * dwarf2-frame.c (read_initial_length): Be consistent about using
1152         unsigned representation of length.
1153         (decode_frame_entry_1): Likewise.  Check for wraparound of
1154         end pointer as well as buffer overflow.
1155
1156 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1157
1158         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1159         "vq".
1160
1161 2019-04-24  Tom Tromey  <tromey@adacore.com>
1162
1163         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1164
1165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1166
1167         * s12z-tdep.c (s12z_unwind_pc): Delete.
1168         (s12z_unwind_sp): Delete.
1169         (s12z_gdbarch_init): Don't register deleted functions with
1170         gdbarch.
1171
1172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * rl78-tdep.c (rl78_unwind_sp): Delete.
1175         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1176
1177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1178
1179         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1180         (xstormy16_unwind_pc): Delete.
1181         (xstormy16_dummy_id): Delete.
1182         (xstormy16_gdbarch_init): Don't register deleted functions with
1183         gdbarch.
1184
1185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * vax-tdep.c (vax_unwind_pc): Delete.
1188         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1189
1190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1191
1192         * v850-tdep.c (v850_unwind_sp): Delete.
1193         (v850_unwind_pc): Delete.
1194         (v850_dummy_id): Delete.
1195         (v850_gdbarch_init): Don't register deleted functions with
1196         gdbarch.
1197
1198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1199
1200         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1201         (tilegx_unwind_pc): Delete.
1202         (tilegx_unwind_dummy_id): Delete.
1203         (tilegx_gdbarch_init): Don't register deleted functions with
1204         gdbarch.
1205
1206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1207
1208         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1209         (tic6x_dummy_id): Delete.
1210         (tic6x_gdbarch_init): Don't register deleted functions with
1211         gdbarch.
1212
1213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * sparc-tdep.c (sparc_unwind_pc): Delete.
1216         (sparc32_gdbarch_init): Don't register deleted function with
1217         gdbarch.
1218
1219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1220
1221         * sh-tdep.c (sh_unwind_sp): Delete.
1222         (sh_unwind_pc): Delete.
1223         (sh_dummy_id): Delete.
1224         (sh_gdbarch_init): Don't register deleted functions with
1225         gdbarch.
1226
1227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1228
1229         * score-tdep.c (score_unwind_sp): Delete.
1230         (score_unwind_pc): Delete.
1231         (score_dummy_id): Delete.
1232         (score_gdbarch_init): Don't register deleted functions with
1233         gdbarch.
1234
1235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * rx-tdep.c (rx_unwind_pc): Delete.
1238         (rx_unwind_sp): Delete.
1239         (rx_dummy_id): Delete.
1240         (rx_gdbarch_init): Don't register deleted functions with
1241         gdbarch.  Update comment.
1242
1243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1244
1245         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1246         (rs6000_dummy_id): Delete.
1247         (rs6000_gdbarch_init): Don't register deleted functions with
1248         gdbarch.
1249
1250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * or1k-tdep.c (or1k_dummy_id): Delete.
1253         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1254
1255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * nios2-tdep.c (nios2_dummy_id): Delete.
1258         (nios2_unwind_sp): Delete.
1259         (nios2_gdbarch_init): Don't register deleted functions with
1260         gdbarch.
1261
1262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1263
1264         * nds32-tdep.c (nds32_dummy_id): Delete.
1265         (nds32_unwind_pc): Delete.
1266         (nds32_unwind_sp): Delete.
1267         (nds32_gdbarch_init): Don't register deleted functions with
1268         gdbarch.
1269
1270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1271
1272         * msp430-tdep.c (msp430_unwind_pc): Delete.
1273         (msp430_unwind_sp): Delete.
1274         (msp430_dummy_id): Delete.
1275         (msp430_gdbarch_init): Don't register deleted functions with
1276         gdbarch.
1277
1278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1279
1280         * moxie-tdep.c (moxie_unwind_sp): Delete.
1281         (moxie_unwind_pc): Delete.
1282         (moxie_dummy_id): Delete.
1283         (moxie_gdbarch_init): Don't register deleted functions with
1284         gdbarch.
1285
1286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1289         (mn10300_unwind_pc): Delete.
1290         (mn10300_unwind_sp): Delete.
1291         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1292         mn10300_unwind_sp.
1293         (mn10300_frame_unwind_init): Don't register deleted functions with
1294         gdbarch.
1295
1296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1297
1298         * mep-tdep.c (mep_unwind_pc): Delete.
1299         (mep_unwind_sp): Delete.
1300         (mep_dummy_id): Delete.
1301         (mep_gdbarch_init): Don't register deleted functions with
1302         gdbarch.
1303
1304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1305
1306         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1307         (m68hc11_unwind_sp): Delete.
1308         (m68hc11_gdbarch_init): Don't register deleted functions with
1309         gdbarch.
1310
1311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1312
1313         * m32r-tdep.c (m32r_unwind_sp): Delete.
1314         (m32r_unwind_pc): Delete.
1315         (m32r_dummy_id): Delete.
1316         (m32r_gdbarch_init): Don't register deleted functions with
1317         gdbarch.
1318
1319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * m32c-tdep.c (m32c_unwind_pc): Delete.
1322         (m32c_unwind_sp): Delete.
1323         (m32c_dummy_id): Delete.
1324         (m32c_gdbarch_init): Don't register deleted functions with
1325         gdbarch.
1326
1327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1328
1329         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1330         (lm32_unwind_pc): Delete.
1331         (lm32_dummy_id): Delete.
1332         (lm32_gdbarch_init): Don't register deleted functions with
1333         gdbarch.
1334
1335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1338         (iq2000_unwind_pc): Delete.
1339         (iq2000_dummy_id): Delete.
1340         (iq2000_gdbarch_init): Don't register deleted functions with
1341         gdbarch.
1342
1343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1344
1345         * nds32-tdep.c (nds32_type_align): Delete.
1346         (nds32_push_dummy_call): Use type_align instead.
1347
1348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1349
1350         * arm-tdep.c (arm_type_align): Only handle vector override case.
1351         (arm_push_dummy_call): Use type_align.
1352         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1353
1354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1355
1356         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1357         case.
1358         (pass_on_stack): Use type_align.
1359         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1360         function.
1361
1362 2019-04-23  Tom Tromey  <tromey@adacore.com>
1363
1364         * dwarf2read.c (line_header::file_name_at): Remove unused
1365         overload.
1366
1367 2019-04-23  Tom de Vries  <tdevries@suse.de>
1368
1369         PR gdb/24438
1370         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1371         invocation.
1372
1373
1374 2019-03-27  Ali Tamur  <tamur@google.com>
1375
1376         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1377         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1378         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1379         (dwarf_expr_context::get_addr_index): Likewise
1380         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1381         (symbol_needs_eval_context::get_addr_index): Likewise
1382         (disassemble_dwarf_expression): Add DW_OP_addrx
1383         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1384         (read_cutu_die_from_dwo): Update comment
1385         (skip_one_die): Add DW_FORM_addrx
1386         (read_attribute_value): Likewise
1387         (var_decode_location): Add DW_OP_addrx
1388         (dwarf2_const_value_attr): Add DW_FORM_addrx
1389         (dump_die_shallow): Likewise
1390         (dwarf2_fetch_constant_bytes): Likewise
1391         (decode_locdesc): Add DW_OP_addrx
1392         (skip_form_bytes): Add DW_FORM_addrx
1393
1394 2019-04-22  Ali Tamur  <tamur@google.com>
1395
1396         * MAINTAINERS (Write After Approval): Add self.
1397
1398 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1399
1400         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1401         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1402         (open_symbol_file_object): Likewise.
1403         (svr4_default_sos): Add info parameter.
1404         (svr4_read_so_list): Likewise.
1405         (svr4_current_sos_direct): Adjust functions calls to pass down
1406         info.
1407         (svr4_current_sos_1): Add info parameter.
1408         (svr4_current_sos): Call get_svr4_info, pass info down to
1409         svr4_current_sos_1.
1410         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1411         get_svr4_info.
1412         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1413         get_svr4_info.
1414         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1415         to get_svr4_info.
1416         (probes_table_remove_objfile_probes): Likewise.
1417         (register_solib_event_probe): Add info parameter.
1418         (solist_update_incremental): Pass info parameter down to
1419         svr4_read_so_list.
1420         (disable_probes_interface): Add info parameter.
1421         (svr4_handle_solib_event): Pass current_program_space to
1422         get_svr4_info.  Adjust disable_probes_interface cleanup.
1423         (svr4_create_probe_breakpoints): Add info parameter, pass it
1424         down to register_solib_event_probe.
1425         (svr4_create_solib_event_breakpoints): Add info parameter,
1426         pass it down to svr4_create_probe_breakpoints.
1427         (enable_break): Pass info down to
1428         svr4_create_solib_event_breakpoints.
1429         (svr4_solib_create_inferior_hook): Pass current_program_space to
1430         get_svr4_info.
1431         (svr4_clear_solib): Likewise.
1432
1433 2019-04-22  Pedro Alves  <palves@redhat.com>
1434
1435         * solib-svr4.c (svr4_free_objfile_observer): New.
1436         (probe_and_action::objfile): New field.
1437         (probes_table_htab_remove_objfile_probes)
1438         (probes_table_remove_objfile_probes): New functions.
1439         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1440         in the new probe_and_action.  Don't store the probe in 'lookup'.
1441         (svr4_create_probe_breakpoints): Pass objfile to
1442         register_solib_event_probe.
1443         (_initialize_svr4_solib): Register a free_objfile observer.
1444
1445 2019-04-19  Tom Tromey  <tom@tromey.com>
1446
1447         * common/queue.h: Remove.
1448
1449 2019-04-19  Tom Tromey  <tom@tromey.com>
1450
1451         * event-loop.c: Don't include "common/queue.h".
1452
1453 2019-04-19  Tom Tromey  <tom@tromey.com>
1454
1455         * remote.c (remote_target): Use delete.
1456         * remote-notif.h: Include <list>, not "common/queue.h".
1457         (notif_client_p): Remove typedef.
1458         (remote_notif_state): Add constructor, destructor, initializer.
1459         <notif_queue>: Now a std::list.
1460         (remote_notif_state_xfree): Don't declare.
1461         * remote-notif.c (remote_notif_process, handle_notification)
1462         (remote_notif_state_allocate): Update.
1463         (~remote_notif_state): Rename from remote_notif_state_xfree.
1464
1465 2019-04-19  Tom Tromey  <tom@tromey.com>
1466
1467         * symfile.c (reread_symbols): Update.
1468         * objfiles.c (objfile_register_static_link)
1469         (objfile_lookup_static_link): Update
1470         (~objfile) Don't delete static_links.
1471         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1472
1473 2019-04-19  Tom Tromey  <tom@tromey.com>
1474
1475         * type-stack.h (struct type_stack) <insert>: Constify string.
1476         * type-stack.c (type_stack::insert): Constify string.
1477         * gdbtypes.h (lookup_template_type): Update.
1478         (address_space_name_to_int): Update.
1479         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1480         const.
1481         (lookup_template_type): Make name const.
1482         * c-exp.y: Update rules.
1483         (lex_one_token, classify_name, classify_inner_name)
1484         (c_print_token): Update.
1485         * p-exp.y: Update rules.
1486         (yylex): Update.
1487         * f-exp.y: Update rules.
1488         (yylex): Update.
1489         * d-exp.y: Update rules.
1490         (lex_one_token, classify_name, classify_inner_name): Update.
1491         * parse.c (write_dollar_variable, copy_name): Return std::string.
1492         * parser-defs.h (copy_name): Change return type.
1493         * m2-exp.y: Update rules.
1494         (yylex): Update.
1495         * go-exp.y (lex_one_token): Update.
1496         Update rules.
1497         (classify_unsafe_function, classify_packaged_name)
1498         (classify_name, yylex): Update.
1499
1500 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1501
1502         * configure.ac: add --enable-source-highlight switch.
1503         * configure: Regenerate.
1504         * top.c (print_gdb_version): plumb --enable-source-highlight
1505         status to "show configuration".
1506
1507 2019-04-19  Tom Tromey  <tromey@adacore.com>
1508
1509         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1510         Check ADA_TYPE_P.
1511         (empty_record, ada_template_to_fixed_record_type_1)
1512         (template_to_static_fixed_type)
1513         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1514         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1515         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1516         macros.
1517
1518 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1519
1520         PR symtab/24423:
1521         * source.c (print_source_lines_base): Advance "iter" when a
1522         control character is seen.
1523
1524 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1525
1526         * inferior.h (struct infcall_suspend_state_deleter):
1527         Catch exception in destructor to avoid crash.
1528
1529 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1530
1531         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1532         close to the add_com "shell".
1533
1534 2019-04-18  Tom Tromey  <tromey@adacore.com>
1535
1536         * process-stratum-target.h (class process_stratum_target)
1537         <stratum>: Add "final".
1538
1539 2019-04-17  Tom Tromey  <tromey@adacore.com>
1540
1541         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1542         against nullptr before use.
1543
1544 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1545
1546         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1547
1548 2019-04-17  Jim Wilson  <jimw@sifive.com>
1549             Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1552         code read might fail, assume 4-byte breakpoint in that case.
1553
1554 2019-04-15  Leszek Swirski  <leszeks@google.com>
1555
1556         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1557         rather than a hand-rolled POD check when checking for forced MEMORY
1558         classification.
1559
1560 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1561
1562         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1563         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1564         function.
1565         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1566         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1567         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1568         declaration.
1569
1570 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1571
1572         * aarch64-linux-nat.c
1573         (aarch64_linux_nat_target::thread_architecture): Add override.
1574         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1575         each VQ.
1576
1577 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1578
1579         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1580
1581 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1582
1583         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1584         target types of size 96-bits, add some additional comments, and
1585         check that the builtin type we found was the correct size.
1586
1587 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1588
1589         * utils.c (prompt_for_continue): Don't restore the styling at the
1590         end, as applied_style has the wrong value.  This fixes styling in
1591         long lists of file names that are interrupted by the "Continue?"
1592         prompt.
1593
1594 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1595
1596         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1597         * c-lang.c (c_language_defn): Likewise.
1598         (cplus_language_defn): Likewise.
1599         (asm_language_defn): Likewise.
1600         (minimal_language_defn): Likewise.
1601         * d-lang.c (d_language_defn): Likewise.
1602         * f-lang.c (f_language_defn): Likewise.
1603         * go-lang.c (go_language_defn): Likewise.
1604         * language.c (unknown_language_defn): Likewise.
1605         (auto_language_defn): Likewise.
1606         * language.h (struct language_defn): Remove la_magic field.
1607         (LANG_MAGIC): Delete.
1608         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1609         * objc-lang.c (objc_language_defn): Likewise.
1610         * opencl-lang.c (opencl_language_defn): Likewise.
1611         * p-lang.c (pascal_language_defn): Likewise.
1612         * rust-lang.c (rust_language_defn): Likewise.
1613
1614 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1615
1616         * riscv-tdep.c (riscv_type_align): New function.
1617         (riscv_type_alignment): Delete.
1618         (riscv_arg_location): Use 'type_align'.
1619         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1620
1621 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1622
1623         * gdbtypes.c (type_align): A struct with no non-static fields also
1624         has alignment of 1.
1625
1626 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1627
1628         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1629         component to 0.
1630         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1631         member.
1632         (riscv_struct_info::analyse): New implementation using new
1633         analyse_inner member function.
1634         (riscv_struct_info::field_offset): New member function.
1635         (riscv_struct_info::m_offsets): New member variable.
1636         (riscv_struct_info::analyse_inner): New private member function,
1637         takes the old implementation of riscv_struct_info::analyse but
1638         extended to track field offsets.
1639         (riscv_call_arg_struct): Update the struct folding special cases
1640         to handle cases where empty C++ structs, which are non-zero
1641         length, are found.
1642         (riscv_arg_location): Initialise the length of each location, a
1643         non-zero length now indicates the location is in use.
1644         (riscv_push_dummy_call): Allow for the first location having a
1645         non-zero offset when setting up arguments.
1646         (riscv_return_value): Likewise, but for return values.
1647
1648 2019-04-11  Tom Tromey  <tromey@adacore.com>
1649
1650         * utils.c (internal_vproblem): Make "msg" const.
1651
1652 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1653
1654         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1655         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1656         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1657         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1658
1659 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1660
1661         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1662         function.
1663         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1664         of amd64_collect_native_gregset.
1665         (amd64_linux_nat_target::store_registers): Likewise.
1666
1667 2019-04-10  Tom Tromey  <tom@tromey.com>
1668
1669         * symtab.c (lookup_global_symbol_from_objfile)
1670         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1671         * objfiles.h (class separate_debug_iterator): New.
1672         (class separate_debug_range): New.
1673         (struct objfile) <separate_debug_objfiles>: New method.
1674         (objfile_separate_debug_iterate): Don't declare.
1675         * objfiles.c (separate_debug_iterator::operator++): Rename from
1676         objfile_separate_debug_iterate.
1677         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1678         iterator.
1679         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1680         iterator.
1681
1682 2019-04-10  Tom Tromey  <tom@tromey.com>
1683
1684         * symfile.c (reread_symbols): Remove old comment.
1685         * objfiles.c (free_all_objfiles): Fix a typo.
1686
1687 2019-04-10  Tom Tromey  <tom@tromey.com>
1688
1689         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1690         * minsyms.c (lookup_minimal_symbol): Use foreach.
1691         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1692         (lookup_minimal_symbol_solib_trampoline): Likewise.
1693         * symfile.c (reread_symbols): Use foreach.
1694
1695 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1696             Tom Tromey  <tromey@adacore.com>
1697
1698         PR rust/24414:
1699         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1700         (rust_lex_int_test): Change "value" to be LONGEST.
1701         (rust_lex_tests): Add test for long integer literal.
1702
1703 2019-04-09  Tom Tromey  <tromey@adacore.com>
1704
1705         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1706         to bool.
1707         (extended_remote_target::attach): Update.
1708         (remote_target::remote_notice_new_inferior): Update.
1709         (remote_target::add_current_inferior_and_thread): Update.
1710         * inferior.c (exit_inferior_1): Use "false".
1711         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1712
1713 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1714
1715         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1716         the "start" command.
1717
1718 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1719
1720         * python/py-inferior.c (infpy_thread_from_thread_handle):
1721         Adjust comments to reflect renaming of thread_from_thread_handle
1722         to thread_from_handle.  Adjust keywords.  Fix type error message.
1723         (inferior_object_methods): Add thread_from_handle.  Retain
1724         thread_from_thread_handle, but mark it as deprecated.
1725
1726 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1727
1728         * gdbthread.h (find_thread_by_handle): Revise declaration.
1729         * thread.c (find_thread_by_handle): Likewise.  Adjust
1730         implementation too.
1731         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1732         support for buffer objects as handles.
1733
1734 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1735
1736         * python/py-infthread.c (thpy_thread_handle): New function.
1737         (thread_object_methods): Register thpy_thread_handle.
1738
1739 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1740
1741         * gdbthread.h (thread_to_thread_handle): Declare.
1742         * thread.c (gdbtypes.h): Include.
1743         (thread_to_thread_handle): New function.
1744
1745         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1746         (target_thread_info_to_thread_handle): Declare.
1747         * target.c (target_thread_info_to_thread_handle): New function.
1748         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1749         * target-delegates.c: Regenerate.
1750
1751         * linux-thread-db.c (class thread_db_target): Add method
1752         thread_info_to_thread_handle.
1753         (thread_db_target::thread_info_to_thread_handle): Define.
1754         * remote.c (class remote_target): Add new method
1755         thread_info_to_thread_handle.
1756         (remote_target::thread_info_to_thread_handle): Define.
1757
1758 2019-04-08  Pedro Alves  <palves@redhat.com>
1759
1760         * common/common-exceptions.c (throw_exception): Don't create
1761         named object to throw; throw directly.
1762         (throw_it): Likewise.  Don't initialize gdb_exception::message
1763         here, with new; pass FMT and AP to the ctor instead.
1764         * common/common-exceptions.h: Include <string>.
1765         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1766         const char *, va_list)): New ctor.  Use std::make_shared.
1767         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1768         errors)): Delete.
1769         (gdb_exception_error::gdb_exception_error(enum errors, const char
1770         *, va_list)): New.
1771         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1772         Add assertion.
1773         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1774         errors)): Delete.
1775         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1776         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1777         Add assertion.
1778
1779 2019-04-08  Tom Tromey  <tom@tromey.com>
1780
1781         * valops.c (value_rtti_indirect_type): Replace throw_exception
1782         with throw.
1783         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1784         with throw.
1785         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1786         throw.
1787         * target.c (target_translate_tls_address): Replace throw_exception
1788         with throw.
1789         * stack.c (frame_apply_command_count): Replace throw_exception
1790         with throw.
1791         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1792         throw.
1793         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1794         with throw.
1795         * rs6000-tdep.c (rs6000_frame_cache)
1796         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1797         * remote.c: Replace throw_exception with throw.
1798         * record-full.c (record_full_message, record_full_wait_1)
1799         (record_full_restore): Replace throw_exception with throw.
1800         * record-btrace.c:
1801         (get_thread_current_frame_id, record_btrace_start_replaying)
1802         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1803         (cmd_record_btrace_start): Replace throw_exception with throw.
1804         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1805         throw.
1806         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1807         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1808         * linespec.c:
1809         (find_linespec_symbols): Replace throw_exception with throw.
1810         * infrun.c (displaced_step_prepare, resume): Replace
1811         throw_exception with throw.
1812         * infcmd.c (post_create_inferior): Replace throw_exception with
1813         throw.
1814         * inf-loop.c (inferior_event_handler): Replace throw_exception
1815         with throw.
1816         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1817         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1818         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1819         (get_prev_frame_always, get_frame_pc_if_available)
1820         (get_frame_address_in_block_if_available, get_frame_language):
1821         Replace throw_exception with throw.
1822         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1823         throw_exception with throw.
1824         * eval.c (fetch_subexp_value, evaluate_var_value)
1825         (evaluate_funcall, evaluate_subexp_standard): Replace
1826         throw_exception with throw.
1827         * dwarf2loc.c (call_site_find_chain)
1828         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1829         Replace throw_exception with throw.
1830         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1831         with throw.
1832         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1833         throw.
1834         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1835         * completer.c (complete_line_internal): Replace throw_exception
1836         with throw.
1837         * compile/compile-object-run.c (compile_object_run): Replace
1838         throw_exception with throw.
1839         * cli/cli-script.c (process_next_line): Replace throw_exception
1840         with throw.
1841         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1842         (btrace_enable, btrace_maint_update_pt_packets): Replace
1843         throw_exception with throw.
1844         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1845         throw_exception with throw.
1846         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1847         throw_exception with throw.
1848         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1849         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1850         * aarch64-tdep.c (aarch64_make_prologue_cache)
1851         (aarch64_make_stub_cache): Replace throw_exception with throw.
1852
1853 2019-04-08  Tom Tromey  <tom@tromey.com>
1854
1855         * common/common-exceptions.c (throw_exception): Rename from
1856         throw_exception_cxx.  Remove old copy.  Make argument const.
1857         (throw_it): Create and throw exception objects directly.
1858         * common/common-exceptions.h (throw_exception): Make argument
1859         const.
1860         (struct gdb_exception_error): Add constructor.
1861         (struct gdb_exception_quit): Add constructor.
1862
1863 2019-04-08  Tom Tromey  <tom@tromey.com>
1864
1865         * common/common-exceptions.h (exception_rethrow): Don't declare.
1866         (TRY_SJLJ): Update comment.
1867         (TRY, CATCH, END_CATCH): Remove.
1868         * common/common-exceptions.c (exception_rethrow): Remove.
1869
1870 2019-04-08  Tom Tromey  <tom@tromey.com>
1871
1872         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1873         Remove.
1874         (gdb_exception_error): Rename from
1875         gdb_exception_RETURN_MASK_ERROR.
1876         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1877         (gdb_quit_bad_alloc): Update.
1878         * aarch64-tdep.c: Update.
1879         * ada-lang.c: Update.
1880         * ada-typeprint.c: Update.
1881         * ada-valprint.c: Update.
1882         * amd64-tdep.c: Update.
1883         * arch-utils.c: Update.
1884         * break-catch-throw.c: Update.
1885         * breakpoint.c: Update.
1886         * btrace.c: Update.
1887         * c-varobj.c: Update.
1888         * cli/cli-cmds.c: Update.
1889         * cli/cli-interp.c: Update.
1890         * cli/cli-script.c: Update.
1891         * common/common-exceptions.c: Update.
1892         * common/new-op.c: Update.
1893         * common/selftest.c: Update.
1894         * compile/compile-c-symbols.c: Update.
1895         * compile/compile-cplus-symbols.c: Update.
1896         * compile/compile-object-load.c: Update.
1897         * compile/compile-object-run.c: Update.
1898         * completer.c: Update.
1899         * corelow.c: Update.
1900         * cp-abi.c: Update.
1901         * cp-support.c: Update.
1902         * cp-valprint.c: Update.
1903         * darwin-nat.c: Update.
1904         * disasm-selftests.c: Update.
1905         * dtrace-probe.c: Update.
1906         * dwarf-index-cache.c: Update.
1907         * dwarf-index-write.c: Update.
1908         * dwarf2-frame-tailcall.c: Update.
1909         * dwarf2-frame.c: Update.
1910         * dwarf2loc.c: Update.
1911         * dwarf2read.c: Update.
1912         * eval.c: Update.
1913         * event-loop.c: Update.
1914         * event-top.c: Update.
1915         * exec.c: Update.
1916         * f-valprint.c: Update.
1917         * fbsd-tdep.c: Update.
1918         * frame-unwind.c: Update.
1919         * frame.c: Update.
1920         * gdbtypes.c: Update.
1921         * gnu-v3-abi.c: Update.
1922         * guile/guile-internal.h: Update.
1923         * guile/scm-block.c: Update.
1924         * guile/scm-breakpoint.c: Update.
1925         * guile/scm-cmd.c: Update.
1926         * guile/scm-disasm.c: Update.
1927         * guile/scm-frame.c: Update.
1928         * guile/scm-lazy-string.c: Update.
1929         * guile/scm-math.c: Update.
1930         * guile/scm-param.c: Update.
1931         * guile/scm-ports.c: Update.
1932         * guile/scm-pretty-print.c: Update.
1933         * guile/scm-symbol.c: Update.
1934         * guile/scm-symtab.c: Update.
1935         * guile/scm-type.c: Update.
1936         * guile/scm-value.c: Update.
1937         * i386-linux-tdep.c: Update.
1938         * i386-tdep.c: Update.
1939         * inf-loop.c: Update.
1940         * infcall.c: Update.
1941         * infcmd.c: Update.
1942         * infrun.c: Update.
1943         * jit.c: Update.
1944         * language.c: Update.
1945         * linespec.c: Update.
1946         * linux-fork.c: Update.
1947         * linux-nat.c: Update.
1948         * linux-tdep.c: Update.
1949         * linux-thread-db.c: Update.
1950         * main.c: Update.
1951         * mi/mi-cmd-break.c: Update.
1952         * mi/mi-cmd-stack.c: Update.
1953         * mi/mi-interp.c: Update.
1954         * mi/mi-main.c: Update.
1955         * objc-lang.c: Update.
1956         * p-valprint.c: Update.
1957         * parse.c: Update.
1958         * ppc-linux-tdep.c: Update.
1959         * printcmd.c: Update.
1960         * python/py-arch.c: Update.
1961         * python/py-breakpoint.c: Update.
1962         * python/py-cmd.c: Update.
1963         * python/py-finishbreakpoint.c: Update.
1964         * python/py-frame.c: Update.
1965         * python/py-framefilter.c: Update.
1966         * python/py-gdb-readline.c: Update.
1967         * python/py-inferior.c: Update.
1968         * python/py-infthread.c: Update.
1969         * python/py-lazy-string.c: Update.
1970         * python/py-linetable.c: Update.
1971         * python/py-objfile.c: Update.
1972         * python/py-param.c: Update.
1973         * python/py-prettyprint.c: Update.
1974         * python/py-progspace.c: Update.
1975         * python/py-record-btrace.c: Update.
1976         * python/py-record.c: Update.
1977         * python/py-symbol.c: Update.
1978         * python/py-type.c: Update.
1979         * python/py-unwind.c: Update.
1980         * python/py-utils.c: Update.
1981         * python/py-value.c: Update.
1982         * python/python.c: Update.
1983         * record-btrace.c: Update.
1984         * record-full.c: Update.
1985         * remote-fileio.c: Update.
1986         * remote.c: Update.
1987         * riscv-tdep.c: Update.
1988         * rs6000-aix-tdep.c: Update.
1989         * rs6000-tdep.c: Update.
1990         * rust-exp.y: Update.
1991         * rust-lang.c: Update.
1992         * s390-tdep.c: Update.
1993         * selftest-arch.c: Update.
1994         * solib-dsbt.c: Update.
1995         * solib-frv.c: Update.
1996         * solib-spu.c: Update.
1997         * solib-svr4.c: Update.
1998         * solib.c: Update.
1999         * sparc64-linux-tdep.c: Update.
2000         * stack.c: Update.
2001         * symfile-mem.c: Update.
2002         * symmisc.c: Update.
2003         * target.c: Update.
2004         * thread.c: Update.
2005         * top.c: Update.
2006         * tracefile-tfile.c: Update.
2007         * tui/tui.c: Update.
2008         * typeprint.c: Update.
2009         * unittests/cli-utils-selftests.c: Update.
2010         * unittests/parse-connection-spec-selftests.c: Update.
2011         * valops.c: Update.
2012         * valprint.c: Update.
2013         * value.c: Update.
2014         * varobj.c: Update.
2015         * windows-nat.c: Update.
2016         * x86-linux-nat.c: Update.
2017         * xml-support.c: Update.
2018
2019 2019-04-08  Tom Tromey  <tom@tromey.com>
2020
2021         * xml-support.c: Use C++ exception handling.
2022         * x86-linux-nat.c: Use C++ exception handling.
2023         * windows-nat.c: Use C++ exception handling.
2024         * varobj.c: Use C++ exception handling.
2025         * value.c: Use C++ exception handling.
2026         * valprint.c: Use C++ exception handling.
2027         * valops.c: Use C++ exception handling.
2028         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2029         handling.
2030         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2031         * typeprint.c: Use C++ exception handling.
2032         * tui/tui.c: Use C++ exception handling.
2033         * tracefile-tfile.c: Use C++ exception handling.
2034         * top.c: Use C++ exception handling.
2035         * thread.c: Use C++ exception handling.
2036         * target.c: Use C++ exception handling.
2037         * symmisc.c: Use C++ exception handling.
2038         * symfile-mem.c: Use C++ exception handling.
2039         * stack.c: Use C++ exception handling.
2040         * sparc64-linux-tdep.c: Use C++ exception handling.
2041         * solib.c: Use C++ exception handling.
2042         * solib-svr4.c: Use C++ exception handling.
2043         * solib-spu.c: Use C++ exception handling.
2044         * solib-frv.c: Use C++ exception handling.
2045         * solib-dsbt.c: Use C++ exception handling.
2046         * selftest-arch.c: Use C++ exception handling.
2047         * s390-tdep.c: Use C++ exception handling.
2048         * rust-lang.c: Use C++ exception handling.
2049         * rust-exp.y: Use C++ exception handling.
2050         * rs6000-tdep.c: Use C++ exception handling.
2051         * rs6000-aix-tdep.c: Use C++ exception handling.
2052         * riscv-tdep.c: Use C++ exception handling.
2053         * remote.c: Use C++ exception handling.
2054         * remote-fileio.c: Use C++ exception handling.
2055         * record-full.c: Use C++ exception handling.
2056         * record-btrace.c: Use C++ exception handling.
2057         * python/python.c: Use C++ exception handling.
2058         * python/py-value.c: Use C++ exception handling.
2059         * python/py-utils.c: Use C++ exception handling.
2060         * python/py-unwind.c: Use C++ exception handling.
2061         * python/py-type.c: Use C++ exception handling.
2062         * python/py-symbol.c: Use C++ exception handling.
2063         * python/py-record.c: Use C++ exception handling.
2064         * python/py-record-btrace.c: Use C++ exception handling.
2065         * python/py-progspace.c: Use C++ exception handling.
2066         * python/py-prettyprint.c: Use C++ exception handling.
2067         * python/py-param.c: Use C++ exception handling.
2068         * python/py-objfile.c: Use C++ exception handling.
2069         * python/py-linetable.c: Use C++ exception handling.
2070         * python/py-lazy-string.c: Use C++ exception handling.
2071         * python/py-infthread.c: Use C++ exception handling.
2072         * python/py-inferior.c: Use C++ exception handling.
2073         * python/py-gdb-readline.c: Use C++ exception handling.
2074         * python/py-framefilter.c: Use C++ exception handling.
2075         * python/py-frame.c: Use C++ exception handling.
2076         * python/py-finishbreakpoint.c: Use C++ exception handling.
2077         * python/py-cmd.c: Use C++ exception handling.
2078         * python/py-breakpoint.c: Use C++ exception handling.
2079         * python/py-arch.c: Use C++ exception handling.
2080         * printcmd.c: Use C++ exception handling.
2081         * ppc-linux-tdep.c: Use C++ exception handling.
2082         * parse.c: Use C++ exception handling.
2083         * p-valprint.c: Use C++ exception handling.
2084         * objc-lang.c: Use C++ exception handling.
2085         * mi/mi-main.c: Use C++ exception handling.
2086         * mi/mi-interp.c: Use C++ exception handling.
2087         * mi/mi-cmd-stack.c: Use C++ exception handling.
2088         * mi/mi-cmd-break.c: Use C++ exception handling.
2089         * main.c: Use C++ exception handling.
2090         * linux-thread-db.c: Use C++ exception handling.
2091         * linux-tdep.c: Use C++ exception handling.
2092         * linux-nat.c: Use C++ exception handling.
2093         * linux-fork.c: Use C++ exception handling.
2094         * linespec.c: Use C++ exception handling.
2095         * language.c: Use C++ exception handling.
2096         * jit.c: Use C++ exception handling.
2097         * infrun.c: Use C++ exception handling.
2098         * infcmd.c: Use C++ exception handling.
2099         * infcall.c: Use C++ exception handling.
2100         * inf-loop.c: Use C++ exception handling.
2101         * i386-tdep.c: Use C++ exception handling.
2102         * i386-linux-tdep.c: Use C++ exception handling.
2103         * guile/scm-value.c: Use C++ exception handling.
2104         * guile/scm-type.c: Use C++ exception handling.
2105         * guile/scm-symtab.c: Use C++ exception handling.
2106         * guile/scm-symbol.c: Use C++ exception handling.
2107         * guile/scm-pretty-print.c: Use C++ exception handling.
2108         * guile/scm-ports.c: Use C++ exception handling.
2109         * guile/scm-param.c: Use C++ exception handling.
2110         * guile/scm-math.c: Use C++ exception handling.
2111         * guile/scm-lazy-string.c: Use C++ exception handling.
2112         * guile/scm-frame.c: Use C++ exception handling.
2113         * guile/scm-disasm.c: Use C++ exception handling.
2114         * guile/scm-cmd.c: Use C++ exception handling.
2115         * guile/scm-breakpoint.c: Use C++ exception handling.
2116         * guile/scm-block.c: Use C++ exception handling.
2117         * guile/guile-internal.h: Use C++ exception handling.
2118         * gnu-v3-abi.c: Use C++ exception handling.
2119         * gdbtypes.c: Use C++ exception handling.
2120         * frame.c: Use C++ exception handling.
2121         * frame-unwind.c: Use C++ exception handling.
2122         * fbsd-tdep.c: Use C++ exception handling.
2123         * f-valprint.c: Use C++ exception handling.
2124         * exec.c: Use C++ exception handling.
2125         * event-top.c: Use C++ exception handling.
2126         * event-loop.c: Use C++ exception handling.
2127         * eval.c: Use C++ exception handling.
2128         * dwarf2read.c: Use C++ exception handling.
2129         * dwarf2loc.c: Use C++ exception handling.
2130         * dwarf2-frame.c: Use C++ exception handling.
2131         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2132         * dwarf-index-write.c: Use C++ exception handling.
2133         * dwarf-index-cache.c: Use C++ exception handling.
2134         * dtrace-probe.c: Use C++ exception handling.
2135         * disasm-selftests.c: Use C++ exception handling.
2136         * darwin-nat.c: Use C++ exception handling.
2137         * cp-valprint.c: Use C++ exception handling.
2138         * cp-support.c: Use C++ exception handling.
2139         * cp-abi.c: Use C++ exception handling.
2140         * corelow.c: Use C++ exception handling.
2141         * completer.c: Use C++ exception handling.
2142         * compile/compile-object-run.c: Use C++ exception handling.
2143         * compile/compile-object-load.c: Use C++ exception handling.
2144         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2145         * compile/compile-c-symbols.c: Use C++ exception handling.
2146         * common/selftest.c: Use C++ exception handling.
2147         * common/new-op.c: Use C++ exception handling.
2148         * cli/cli-script.c: Use C++ exception handling.
2149         * cli/cli-interp.c: Use C++ exception handling.
2150         * cli/cli-cmds.c: Use C++ exception handling.
2151         * c-varobj.c: Use C++ exception handling.
2152         * btrace.c: Use C++ exception handling.
2153         * breakpoint.c: Use C++ exception handling.
2154         * break-catch-throw.c: Use C++ exception handling.
2155         * arch-utils.c: Use C++ exception handling.
2156         * amd64-tdep.c: Use C++ exception handling.
2157         * ada-valprint.c: Use C++ exception handling.
2158         * ada-typeprint.c: Use C++ exception handling.
2159         * ada-lang.c: Use C++ exception handling.
2160         * aarch64-tdep.c: Use C++ exception handling.
2161
2162 2019-04-08  Tom Tromey  <tom@tromey.com>
2163
2164         * xml-support.c (gdb_xml_parser::parse): Update.
2165         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2166         * value.c (show_convenience): Update.
2167         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2168         (test_parse_flags_qcs): Update.
2169         * thread.c (thr_try_catch_cmd): Update.
2170         * target.c (target_translate_tls_address): Update.
2171         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2172         (info_frame_command_core, frame_apply_command_count): Update.
2173         * rust-exp.y (rust_lex_exception_test): Update.
2174         * riscv-tdep.c (riscv_print_one_register_info): Update.
2175         * remote.c (remote_target::enable_btrace): Update.
2176         * record-btrace.c (record_btrace_enable_warn): Update.
2177         * python/py-utils.c (gdbpy_convert_exception): Update.
2178         * printcmd.c (do_one_display, print_variable_and_value): Update.
2179         * mi/mi-main.c (mi_print_exception): Update.
2180         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2181         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2182         * linux-nat.c (linux_nat_target::attach): Update.
2183         * linux-fork.c (class scoped_switch_fork_info): Update.
2184         * infrun.c (displaced_step_prepare): Update.
2185         * infcall.c (call_function_by_hand_dummy): Update.
2186         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2187         * gnu-v3-abi.c (print_one_vtable): Update.
2188         * frame.c (get_prev_frame_always): Update.
2189         * f-valprint.c (info_common_command_for_block): Update.
2190         * exec.c (try_open_exec_file): Update.
2191         * exceptions.c (print_exception, exception_print)
2192         (exception_fprintf, exception_print_same): Update.
2193         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2194         * dwarf-index-cache.c (index_cache::store)
2195         (index_cache::lookup_gdb_index): Update.
2196         * darwin-nat.c (maybe_cache_shell): Update.
2197         * cp-valprint.c (cp_print_value_fields): Update.
2198         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2199         (gcc_cplus_symbol_address): Update.
2200         * compile/compile-c-symbols.c (gcc_convert_symbol)
2201         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2202         * common/selftest.c: Update.
2203         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2204         a std::string.
2205         (exception_try_scope_entry, exception_try_scope_exit): Don't
2206         declare.
2207         (struct exception_try_scope): Remove.
2208         (TRY): Don't use exception_try_scope.
2209         (struct gdb_exception): Add constructor, operator=.
2210         <what>: New method.
2211         (struct gdb_exception_RETURN_MASK_ALL)
2212         (struct gdb_exception_RETURN_MASK_ERROR)
2213         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2214         (struct gdb_quit_bad_alloc): Update.
2215         * common/common-exceptions.c (exception_none): Change
2216         initializer.
2217         (struct catcher) <state, exception>: Initialize inline.
2218         <prev>: Remove member.
2219         (current_catcher): Remove.
2220         (catchers): New global.
2221         (exceptions_state_mc_init): Simplify.
2222         (catcher_pop): Remove.
2223         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2224         (try_scope_depth, exception_try_scope_entry)
2225         (exception_try_scope_exit): Remove.
2226         (throw_exception_sjlj): Update.
2227         (exception_messages, exception_messages_size): Remove.
2228         (throw_it): Simplify.
2229         (gdb_exception_sliced_copy): Remove.
2230         (throw_exception_cxx): Update.
2231         * cli/cli-script.c (script_from_file): Update.
2232         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2233         Update.
2234         * ada-valprint.c (ada_val_print): Update.
2235         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2236         (create_excep_cond_exprs): Update.
2237
2238 2019-04-08  Tom Tromey  <tom@tromey.com>
2239
2240         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2241         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2242         (TRY, CATCH, END_CATCH): Remove some definitions.
2243         * common/common-exceptions.c: Don't use GDB_XCPT.
2244         (catcher_list_size): Remove.
2245         (throw_exception, throw_it): Simplify.
2246
2247 2019-04-05  Tom Tromey  <tom@tromey.com>
2248
2249         Revert the header-sorting patch.
2250         * ft32-tdep.c: Revert.
2251         * frv-tdep.c: Revert.
2252         * frv-linux-tdep.c: Revert.
2253         * frame.c: Revert.
2254         * frame-unwind.c: Revert.
2255         * frame-base.c: Revert.
2256         * fork-child.c: Revert.
2257         * findvar.c: Revert.
2258         * findcmd.c: Revert.
2259         * filesystem.c: Revert.
2260         * filename-seen-cache.h: Revert.
2261         * filename-seen-cache.c: Revert.
2262         * fbsd-tdep.c: Revert.
2263         * fbsd-nat.h: Revert.
2264         * fbsd-nat.c: Revert.
2265         * f-valprint.c: Revert.
2266         * f-typeprint.c: Revert.
2267         * f-lang.c: Revert.
2268         * extension.h: Revert.
2269         * extension.c: Revert.
2270         * extension-priv.h: Revert.
2271         * expprint.c: Revert.
2272         * exec.h: Revert.
2273         * exec.c: Revert.
2274         * exceptions.c: Revert.
2275         * event-top.c: Revert.
2276         * event-loop.c: Revert.
2277         * eval.c: Revert.
2278         * elfread.c: Revert.
2279         * dwarf2read.h: Revert.
2280         * dwarf2read.c: Revert.
2281         * dwarf2loc.c: Revert.
2282         * dwarf2expr.h: Revert.
2283         * dwarf2expr.c: Revert.
2284         * dwarf2-frame.c: Revert.
2285         * dwarf2-frame-tailcall.c: Revert.
2286         * dwarf-index-write.h: Revert.
2287         * dwarf-index-write.c: Revert.
2288         * dwarf-index-common.c: Revert.
2289         * dwarf-index-cache.h: Revert.
2290         * dwarf-index-cache.c: Revert.
2291         * dummy-frame.c: Revert.
2292         * dtrace-probe.c: Revert.
2293         * disasm.h: Revert.
2294         * disasm.c: Revert.
2295         * disasm-selftests.c: Revert.
2296         * dictionary.c: Revert.
2297         * dicos-tdep.c: Revert.
2298         * demangle.c: Revert.
2299         * dcache.h: Revert.
2300         * dcache.c: Revert.
2301         * darwin-nat.h: Revert.
2302         * darwin-nat.c: Revert.
2303         * darwin-nat-info.c: Revert.
2304         * d-valprint.c: Revert.
2305         * d-namespace.c: Revert.
2306         * d-lang.c: Revert.
2307         * ctf.c: Revert.
2308         * csky-tdep.c: Revert.
2309         * csky-linux-tdep.c: Revert.
2310         * cris-tdep.c: Revert.
2311         * cris-linux-tdep.c: Revert.
2312         * cp-valprint.c: Revert.
2313         * cp-support.c: Revert.
2314         * cp-namespace.c: Revert.
2315         * cp-abi.c: Revert.
2316         * corelow.c: Revert.
2317         * corefile.c: Revert.
2318         * continuations.c: Revert.
2319         * completer.h: Revert.
2320         * completer.c: Revert.
2321         * complaints.c: Revert.
2322         * coffread.c: Revert.
2323         * coff-pe-read.c: Revert.
2324         * cli-out.h: Revert.
2325         * cli-out.c: Revert.
2326         * charset.c: Revert.
2327         * c-varobj.c: Revert.
2328         * c-valprint.c: Revert.
2329         * c-typeprint.c: Revert.
2330         * c-lang.c: Revert.
2331         * buildsym.c: Revert.
2332         * buildsym-legacy.c: Revert.
2333         * build-id.h: Revert.
2334         * build-id.c: Revert.
2335         * btrace.c: Revert.
2336         * bsd-uthread.c: Revert.
2337         * breakpoint.h: Revert.
2338         * breakpoint.c: Revert.
2339         * break-catch-throw.c: Revert.
2340         * break-catch-syscall.c: Revert.
2341         * break-catch-sig.c: Revert.
2342         * blockframe.c: Revert.
2343         * block.c: Revert.
2344         * bfin-tdep.c: Revert.
2345         * bfin-linux-tdep.c: Revert.
2346         * bfd-target.c: Revert.
2347         * bcache.c: Revert.
2348         * ax-general.c: Revert.
2349         * ax-gdb.h: Revert.
2350         * ax-gdb.c: Revert.
2351         * avr-tdep.c: Revert.
2352         * auxv.c: Revert.
2353         * auto-load.c: Revert.
2354         * arm-wince-tdep.c: Revert.
2355         * arm-tdep.c: Revert.
2356         * arm-symbian-tdep.c: Revert.
2357         * arm-pikeos-tdep.c: Revert.
2358         * arm-obsd-tdep.c: Revert.
2359         * arm-nbsd-tdep.c: Revert.
2360         * arm-nbsd-nat.c: Revert.
2361         * arm-linux-tdep.c: Revert.
2362         * arm-linux-nat.c: Revert.
2363         * arm-fbsd-tdep.c: Revert.
2364         * arm-fbsd-nat.c: Revert.
2365         * arm-bsd-tdep.c: Revert.
2366         * arch-utils.c: Revert.
2367         * arc-tdep.c: Revert.
2368         * arc-newlib-tdep.c: Revert.
2369         * annotate.h: Revert.
2370         * annotate.c: Revert.
2371         * amd64-windows-tdep.c: Revert.
2372         * amd64-windows-nat.c: Revert.
2373         * amd64-tdep.c: Revert.
2374         * amd64-sol2-tdep.c: Revert.
2375         * amd64-obsd-tdep.c: Revert.
2376         * amd64-obsd-nat.c: Revert.
2377         * amd64-nbsd-tdep.c: Revert.
2378         * amd64-nbsd-nat.c: Revert.
2379         * amd64-nat.c: Revert.
2380         * amd64-linux-tdep.c: Revert.
2381         * amd64-linux-nat.c: Revert.
2382         * amd64-fbsd-tdep.c: Revert.
2383         * amd64-fbsd-nat.c: Revert.
2384         * amd64-dicos-tdep.c: Revert.
2385         * amd64-darwin-tdep.c: Revert.
2386         * amd64-bsd-nat.c: Revert.
2387         * alpha-tdep.c: Revert.
2388         * alpha-obsd-tdep.c: Revert.
2389         * alpha-nbsd-tdep.c: Revert.
2390         * alpha-mdebug-tdep.c: Revert.
2391         * alpha-linux-tdep.c: Revert.
2392         * alpha-linux-nat.c: Revert.
2393         * alpha-bsd-tdep.c: Revert.
2394         * alpha-bsd-nat.c: Revert.
2395         * aix-thread.c: Revert.
2396         * agent.c: Revert.
2397         * addrmap.c: Revert.
2398         * ada-varobj.c: Revert.
2399         * ada-valprint.c: Revert.
2400         * ada-typeprint.c: Revert.
2401         * ada-tasks.c: Revert.
2402         * ada-lang.c: Revert.
2403         * aarch64-tdep.c: Revert.
2404         * aarch64-ravenscar-thread.c: Revert.
2405         * aarch64-newlib-tdep.c: Revert.
2406         * aarch64-linux-tdep.c: Revert.
2407         * aarch64-linux-nat.c: Revert.
2408         * aarch64-fbsd-tdep.c: Revert.
2409         * aarch64-fbsd-nat.c: Revert.
2410         * aarch32-linux-nat.c: Revert.
2411
2412 2019-04-05  Tom Tromey  <tom@tromey.com>
2413
2414         * ft32-tdep.c: Sort headers.
2415         * frv-tdep.c: Sort headers.
2416         * frv-linux-tdep.c: Sort headers.
2417         * frame.c: Sort headers.
2418         * frame-unwind.c: Sort headers.
2419         * frame-base.c: Sort headers.
2420         * fork-child.c: Sort headers.
2421         * findvar.c: Sort headers.
2422         * findcmd.c: Sort headers.
2423         * filesystem.c: Sort headers.
2424         * filename-seen-cache.h: Sort headers.
2425         * filename-seen-cache.c: Sort headers.
2426         * fbsd-tdep.c: Sort headers.
2427         * fbsd-nat.h: Sort headers.
2428         * fbsd-nat.c: Sort headers.
2429         * f-valprint.c: Sort headers.
2430         * f-typeprint.c: Sort headers.
2431         * f-lang.c: Sort headers.
2432         * extension.h: Sort headers.
2433         * extension.c: Sort headers.
2434         * extension-priv.h: Sort headers.
2435         * expprint.c: Sort headers.
2436         * exec.h: Sort headers.
2437         * exec.c: Sort headers.
2438         * exceptions.c: Sort headers.
2439         * event-top.c: Sort headers.
2440         * event-loop.c: Sort headers.
2441         * eval.c: Sort headers.
2442         * elfread.c: Sort headers.
2443         * dwarf2read.h: Sort headers.
2444         * dwarf2read.c: Sort headers.
2445         * dwarf2loc.c: Sort headers.
2446         * dwarf2expr.h: Sort headers.
2447         * dwarf2expr.c: Sort headers.
2448         * dwarf2-frame.c: Sort headers.
2449         * dwarf2-frame-tailcall.c: Sort headers.
2450         * dwarf-index-write.h: Sort headers.
2451         * dwarf-index-write.c: Sort headers.
2452         * dwarf-index-common.c: Sort headers.
2453         * dwarf-index-cache.h: Sort headers.
2454         * dwarf-index-cache.c: Sort headers.
2455         * dummy-frame.c: Sort headers.
2456         * dtrace-probe.c: Sort headers.
2457         * disasm.h: Sort headers.
2458         * disasm.c: Sort headers.
2459         * disasm-selftests.c: Sort headers.
2460         * dictionary.c: Sort headers.
2461         * dicos-tdep.c: Sort headers.
2462         * demangle.c: Sort headers.
2463         * dcache.h: Sort headers.
2464         * dcache.c: Sort headers.
2465         * darwin-nat.h: Sort headers.
2466         * darwin-nat.c: Sort headers.
2467         * darwin-nat-info.c: Sort headers.
2468         * d-valprint.c: Sort headers.
2469         * d-namespace.c: Sort headers.
2470         * d-lang.c: Sort headers.
2471         * ctf.c: Sort headers.
2472         * csky-tdep.c: Sort headers.
2473         * csky-linux-tdep.c: Sort headers.
2474         * cris-tdep.c: Sort headers.
2475         * cris-linux-tdep.c: Sort headers.
2476         * cp-valprint.c: Sort headers.
2477         * cp-support.c: Sort headers.
2478         * cp-namespace.c: Sort headers.
2479         * cp-abi.c: Sort headers.
2480         * corelow.c: Sort headers.
2481         * corefile.c: Sort headers.
2482         * continuations.c: Sort headers.
2483         * completer.h: Sort headers.
2484         * completer.c: Sort headers.
2485         * complaints.c: Sort headers.
2486         * coffread.c: Sort headers.
2487         * coff-pe-read.c: Sort headers.
2488         * cli-out.h: Sort headers.
2489         * cli-out.c: Sort headers.
2490         * charset.c: Sort headers.
2491         * c-varobj.c: Sort headers.
2492         * c-valprint.c: Sort headers.
2493         * c-typeprint.c: Sort headers.
2494         * c-lang.c: Sort headers.
2495         * buildsym.c: Sort headers.
2496         * buildsym-legacy.c: Sort headers.
2497         * build-id.h: Sort headers.
2498         * build-id.c: Sort headers.
2499         * btrace.c: Sort headers.
2500         * bsd-uthread.c: Sort headers.
2501         * breakpoint.h: Sort headers.
2502         * breakpoint.c: Sort headers.
2503         * break-catch-throw.c: Sort headers.
2504         * break-catch-syscall.c: Sort headers.
2505         * break-catch-sig.c: Sort headers.
2506         * blockframe.c: Sort headers.
2507         * block.c: Sort headers.
2508         * bfin-tdep.c: Sort headers.
2509         * bfin-linux-tdep.c: Sort headers.
2510         * bfd-target.c: Sort headers.
2511         * bcache.c: Sort headers.
2512         * ax-general.c: Sort headers.
2513         * ax-gdb.h: Sort headers.
2514         * ax-gdb.c: Sort headers.
2515         * avr-tdep.c: Sort headers.
2516         * auxv.c: Sort headers.
2517         * auto-load.c: Sort headers.
2518         * arm-wince-tdep.c: Sort headers.
2519         * arm-tdep.c: Sort headers.
2520         * arm-symbian-tdep.c: Sort headers.
2521         * arm-pikeos-tdep.c: Sort headers.
2522         * arm-obsd-tdep.c: Sort headers.
2523         * arm-nbsd-tdep.c: Sort headers.
2524         * arm-nbsd-nat.c: Sort headers.
2525         * arm-linux-tdep.c: Sort headers.
2526         * arm-linux-nat.c: Sort headers.
2527         * arm-fbsd-tdep.c: Sort headers.
2528         * arm-fbsd-nat.c: Sort headers.
2529         * arm-bsd-tdep.c: Sort headers.
2530         * arch-utils.c: Sort headers.
2531         * arc-tdep.c: Sort headers.
2532         * arc-newlib-tdep.c: Sort headers.
2533         * annotate.h: Sort headers.
2534         * annotate.c: Sort headers.
2535         * amd64-windows-tdep.c: Sort headers.
2536         * amd64-windows-nat.c: Sort headers.
2537         * amd64-tdep.c: Sort headers.
2538         * amd64-sol2-tdep.c: Sort headers.
2539         * amd64-obsd-tdep.c: Sort headers.
2540         * amd64-obsd-nat.c: Sort headers.
2541         * amd64-nbsd-tdep.c: Sort headers.
2542         * amd64-nbsd-nat.c: Sort headers.
2543         * amd64-nat.c: Sort headers.
2544         * amd64-linux-tdep.c: Sort headers.
2545         * amd64-linux-nat.c: Sort headers.
2546         * amd64-fbsd-tdep.c: Sort headers.
2547         * amd64-fbsd-nat.c: Sort headers.
2548         * amd64-dicos-tdep.c: Sort headers.
2549         * amd64-darwin-tdep.c: Sort headers.
2550         * amd64-bsd-nat.c: Sort headers.
2551         * alpha-tdep.c: Sort headers.
2552         * alpha-obsd-tdep.c: Sort headers.
2553         * alpha-nbsd-tdep.c: Sort headers.
2554         * alpha-mdebug-tdep.c: Sort headers.
2555         * alpha-linux-tdep.c: Sort headers.
2556         * alpha-linux-nat.c: Sort headers.
2557         * alpha-bsd-tdep.c: Sort headers.
2558         * alpha-bsd-nat.c: Sort headers.
2559         * aix-thread.c: Sort headers.
2560         * agent.c: Sort headers.
2561         * addrmap.c: Sort headers.
2562         * ada-varobj.c: Sort headers.
2563         * ada-valprint.c: Sort headers.
2564         * ada-typeprint.c: Sort headers.
2565         * ada-tasks.c: Sort headers.
2566         * ada-lang.c: Sort headers.
2567         * aarch64-tdep.c: Sort headers.
2568         * aarch64-ravenscar-thread.c: Sort headers.
2569         * aarch64-newlib-tdep.c: Sort headers.
2570         * aarch64-linux-tdep.c: Sort headers.
2571         * aarch64-linux-nat.c: Sort headers.
2572         * aarch64-fbsd-tdep.c: Sort headers.
2573         * aarch64-fbsd-nat.c: Sort headers.
2574         * aarch32-linux-nat.c: Sort headers.
2575
2576 2019-04-04  Tom Tromey  <tom@tromey.com>
2577
2578         * varobj.c (varobj_create): Update.
2579         * rust-exp.y (struct rust_parser) <update_innermost_block,
2580         lookup_symbol>: New methods.
2581         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2582         Rename.
2583         (rust_parser::rust_lookup_type)
2584         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2585         * printcmd.c (display_command, do_one_display): Update.
2586         * parser-defs.h (struct parser_state) <parser_state>: Add
2587         "tracker" parameter.
2588         (block_tracker): New member.
2589         (class innermost_block_tracker) <innermost_block_tracker>: Add
2590         "types" parameter.
2591         <reset>: Remove method.
2592         (innermost_block): Don't declare.
2593         (null_post_parser): Update.
2594         * parse.c (innermost_block): Remove global.
2595         (write_dollar_variable): Update.
2596         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2597         Remove "tracker_types" parameter.
2598         (parse_expression): Add "tracker" parameter.
2599         (parse_expression_for_completion): Update.
2600         (null_post_parser): Add "tracker" parameter.
2601         * p-exp.y: Update rules.
2602         * m2-exp.y: Update rules.
2603         * language.h (struct language_defn) <la_post_parser>: Add
2604         "tracker" parameter.
2605         * go-exp.y: Update rules.
2606         * f-exp.y: Update rules.
2607         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2608         parameter.
2609         * d-exp.y: Update rules.
2610         * c-exp.y: Update rules.
2611         * breakpoint.c (set_breakpoint_condition): Create an
2612         innermost_block_tracker.
2613         (watch_command_1): Likewise.
2614         * ada-lang.c (resolve): Add "tracker" parameter.
2615         (resolve_subexp): Likewise.
2616         * ada-exp.y (write_var_from_sym): Update.
2617
2618 2019-04-04  Tom Tromey  <tom@tromey.com>
2619
2620         * type-stack.h: New file.
2621         * type-stack.c: New file.
2622         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2623         type-stack.h.
2624         (insert_into_type_stack, insert_type, push_type, push_type_int)
2625         (insert_type_address_space, pop_type, pop_type_int)
2626         (pop_typelist, pop_type_stack, append_type_stack)
2627         (push_type_stack, get_type_stack, push_typelist)
2628         (follow_type_instance_flags, follow_types): Don't declare.
2629         * parse.c (type_stack): Remove global.
2630         (parse_exp_in_context): Update.
2631         (insert_into_type_stack, insert_type, push_type, push_type_int)
2632         (insert_type_address_space, pop_type, pop_type_int)
2633         (pop_typelist, pop_type_stack, append_type_stack)
2634         (push_type_stack, get_type_stack, push_typelist)
2635         (follow_type_instance_flags, follow_types): Remove (moved to
2636         type-stack.c).
2637         * f-exp.y (type_stack): New global.
2638         Update rules.
2639         (push_kind_type, f_parse): Update.
2640         * d-exp.y (type_stack): New global.
2641         Update rules.
2642         (d_parse): Update.
2643         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2644         Update rules.
2645         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2646         (HFILES_NO_SRCDIR): Add type-stack.h.
2647
2648 2019-04-04  Tom Tromey  <tom@tromey.com>
2649
2650         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2651         (rust_parser::convert_ast_to_expression, rust_parse)
2652         (rust_lex_test_completion, rust_lex_tests): Update.
2653         * parser-defs.h (struct expr_completion_state): New.
2654         (struct parser_state) <parser_state>: Add completion parameter.
2655         <mark_struct_expression, mark_completion_tag>: New methods.
2656         <parse_completion, m_completion_state>: New members.
2657         (prefixify_expression, null_post_parser): Update.
2658         (mark_struct_expression, mark_completion_tag): Don't declare.
2659         * parse.c (parse_completion, expout_last_struct)
2660         (expout_tag_completion_type, expout_completion_name): Remove
2661         globals.
2662         (parser_state::mark_struct_expression)
2663         (parser_state::mark_completion_tag): Now methods.
2664         (prefixify_expression): Add last_struct parameter.
2665         (prefixify_subexp): Likewise.
2666         (parse_exp_1): Update.
2667         (parse_exp_in_context): Add cstate parameter.  Update.
2668         (parse_expression_for_completion): Create an
2669         expr_completion_state.
2670         (null_post_parser): Add "completion" parameter.
2671         * p-exp.y: Update rules.
2672         (yylex): Update.
2673         * language.h (struct language_defn) <la_post_parser>: Add
2674         "completing" parameter.
2675         * go-exp.y: Update rules.
2676         (lex_one_token): Update.
2677         * expression.h (parse_completion): Don't declare.
2678         * d-exp.y: Update rules.
2679         (lex_one_token): Update rules.
2680         * c-exp.y: Update rules.
2681         (lex_one_token): Update.
2682         * ada-lang.c (resolve): Add "parse_completion" parameter.
2683         (resolve_subexp): Likewise.
2684         (ada_resolve_function): Likewise.
2685
2686 2019-04-04  Tom Tromey  <tom@tromey.com>
2687
2688         * parser-defs.h (struct parser_state) <start_arglist,
2689         end_arglist>: New methods.
2690         <arglist_len, m_funcall_chain>: New members.
2691         (arglist_len, start_arglist, end_arglist): Don't declare.
2692         * parse.c (arglist_len, funcall_chain): Remove global.
2693         (start_arglist, end_arglist): Remove functions.
2694         (parse_exp_in_context): Update.
2695         * p-exp.y: Update rules.
2696         * m2-exp.y: Update rules.
2697         * go-exp.y: Update rules.
2698         * f-exp.y: Update rules.
2699         * d-exp.y: Update rules.
2700         * c-exp.y: Update rules.
2701
2702 2019-04-04  Tom Tromey  <tom@tromey.com>
2703
2704         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2705         lex_operator, push_back>: New methods.
2706         Update all rules.
2707         (rust_parser::lex_hex, lex_escape): Rename and update.
2708         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2709         (rust_parser::lex_operator): Rename and update.
2710         (rust_parser::lex_number, rustyylex, rustyyerror)
2711         (rust_lex_test_init, rust_lex_test_sequence)
2712         (rust_lex_test_push_back, rust_lex_tests): Update.
2713         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2714         parameter.
2715         <lexptr, prev_lexptr>: New members.
2716         (lexptr, prev_lexptr): Don't declare.
2717         * parse.c (lexptr, prev_lexptr): Remove globals.
2718         (parse_exp_in_context): Update.
2719         * p-exp.y (yylex, yyerror): Update.
2720         * m2-exp.y (parse_number, yylex, yyerror): Update.
2721         * go-exp.y (lex_one_token, yyerror): Update.
2722         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2723         * d-exp.y (lex_one_token, yyerror): Update.
2724         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2725         (lex_one_token, yyerror): Update.
2726         * ada-lex.l (YY_INPUT): Update.
2727         (rewind_to_char): Update.
2728         * ada-exp.y (yyerror): Update.
2729
2730 2019-04-04  Tom Tromey  <tom@tromey.com>
2731
2732         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2733         * parser-defs.h (struct parser_state) <parser_state>: Add new
2734         parameter.
2735         <comma_terminates>: New member.
2736         (comma_terminates): Don't declare global.
2737         * parse.c (comma_terminates): Remove global.
2738         (parse_exp_in_context): Update.
2739         * p-exp.y (yylex): Update.
2740         * m2-exp.y (yylex): Update.
2741         * go-exp.y (lex_one_token): Update.
2742         * f-exp.y (yylex): Update.
2743         * d-exp.y (lex_one_token): Update.
2744         * c-exp.y (lex_one_token): Update.
2745         * ada-lex.l: Update.
2746
2747 2019-04-04  Tom Tromey  <tom@tromey.com>
2748
2749         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2750         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2751         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2752         * parser-defs.h (paren_depth): Don't declare.
2753         * parse.c (paren_depth): Remove global.
2754         (parse_exp_in_context): Update.
2755         * p-exp.y (paren_depth): New global.
2756         (pascal_parse): Initialize it.
2757         * m2-exp.y (paren_depth): New global.
2758         (m2_parse): Initialize it.
2759         * go-exp.y (paren_depth): New global.
2760         (go_parse): Initialize it.
2761         * f-exp.y (paren_depth): New global.
2762         (f_parse): Initialize it.
2763         * d-exp.y (paren_depth): New global.
2764         (d_parse): Initialize it.
2765         * c-exp.y (paren_depth): New global.
2766         (c_parse): Initialize it.
2767         * ada-lex.l (paren_depth): New global.
2768         (lexer_init): Initialize it.
2769
2770 2019-04-04  Tom Tromey  <tom@tromey.com>
2771
2772         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2773         (rust_parser::convert_ast_to_type)
2774         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2775         * parser-defs.h (struct parser_state) <parser_state>: Add
2776         parameters.  Initialize new members.
2777         <expression_context_block, expression_context_pc>: New members.
2778         * parse.c (expression_context_block, expression_context_pc):
2779         Remove globals.
2780         (parse_exp_in_context): Update.
2781         * p-exp.y: Update all rules.
2782         (yylex): Update.
2783         * m2-exp.y: Update all rules.
2784         (yylex): Update.
2785         * go-exp.y (yylex): Update.
2786         * f-exp.y (yylex): Update.
2787         * d-exp.y: Update all rules.
2788         (yylex): Update.
2789         * c-exp.y: Update all rules.
2790         (lex_one_token, classify_name, yylex, c_parse): Update.
2791         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2792
2793 2019-04-04  Tom Tromey  <tom@tromey.com>
2794
2795         * gdbarch.h, gdbarch.c: Rebuild.
2796         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2797         * stap-probe.h:
2798         (struct stap_parse_info): Replace "parser_state" with
2799         "expr_builder".
2800         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2801         (parser_state): New class.
2802         * parse.c (expr_builder): Rename.
2803         (expr_builder::release): Rename.
2804         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2805         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2806         (write_exp_elt_longcst, write_exp_elt_floatcst)
2807         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2808         (write_exp_string_vector, write_exp_bitstring)
2809         (write_exp_msymbol, mark_struct_expression)
2810         (write_dollar_variable)
2811         (insert_type_address_space, increase_expout_size): Replace
2812         "parser_state" with "expr_builder".
2813         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2814         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2815         "parser_state" with "expr_builder".
2816
2817 2019-04-04  Tom Tromey  <tom@tromey.com>
2818
2819         * rust-exp.y: Replace "parse_language" with method call.
2820         * p-exp.y:
2821         (yylex): Replace "parse_language" with method call.
2822         * m2-exp.y:
2823         (yylex): Replace "parse_language" with method call.
2824         * go-exp.y (classify_name): Replace "parse_language" with method
2825         call.
2826         * f-exp.y (yylex): Replace "parse_language" with method call.
2827         * d-exp.y (lex_one_token): Replace "parse_language" with method
2828         call.
2829         * c-exp.y:
2830         (lex_one_token, classify_name, yylex): Replace "parse_language"
2831         with method call.
2832         * ada-exp.y (find_primitive_type, type_char)
2833         (type_system_address): Replace "parse_language" with method call.
2834
2835 2019-04-04  Tom Tromey  <tom@tromey.com>
2836
2837         * rust-exp.y: Replace "parse_gdbarch" with method call.
2838         * parse.c (write_dollar_variable, insert_type_address_space):
2839         Replace "parse_gdbarch" with method call.
2840         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2841         call.
2842         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2843         call.
2844         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2845         "parse_gdbarch" with method call.
2846         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2847         with method call.
2848         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2849         "parse_gdbarch" with method call.
2850         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2851         "parse_gdbarch" with method call.
2852         * c-exp.y (parse_type, parse_number, classify_name): Replace
2853         "parse_gdbarch" with method call.
2854         * ada-lex.l: Replace "parse_gdbarch" with method call.
2855         * ada-exp.y (parse_type, find_primitive_type, type_char)
2856         (type_system_address): Replace "parse_gdbarch" with method call.
2857
2858 2019-04-04  Tom Tromey  <tom@tromey.com>
2859
2860         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2861         * stap-probe.c (stap_parse_argument): Update.
2862         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2863         initial_size parameter.
2864         * rust-exp.y (rust_lex_tests): Update.
2865         * parse.c (parser_state): Update.
2866         (parse_exp_in_context): Update.
2867         * parser-defs.h (struct parser_state) <parser_state>: Remove
2868         "initial_size" parameter.
2869
2870 2019-04-04  Tom Tromey  <tom@tromey.com>
2871
2872         * parser-defs.h (increase_expout_size): Don't declare.
2873         * parse.c (increase_expout_size): Now static.
2874
2875 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2876
2877         * gnu-nat.c (gnu_nat_target::wait): Fix
2878         target_waitstatus_to_string call.
2879
2880 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2881
2882         * eval.c (evaluate_subexp_standard): Handle internal functions
2883         during Fortran function call handling.
2884
2885 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * NEWS: Mention new internal functions.
2888         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2889         (read_base_type): Use dwarf2_init_complex_target_type.
2890         * value.c (creal_internal_fn): New function.
2891         (cimag_internal_fn): New function.
2892         (_initialize_values): Register new internal functions.
2893
2894 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2895
2896         * infrun.c (stop_all_threads): If debug_infrun, always
2897         trace the wait status after wait_one, using
2898         target_waitstatus_to_string and target_pid_to_str.
2899         (handle_inferior_event): Replace various trace of
2900         wait status kind by a single trace.
2901         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2902         wait status kind image by target_waitstatus_to_string.
2903         * target/waitstatus.c (target_waitstatus_to_string): Fix
2904         obsolete comment.
2905
2906 2019-04-01  Tom Tromey  <tromey@adacore.com>
2907
2908         PR symtab/23331:
2909         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2910
2911 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2912             Pedro Alves  <palves@redhat.com>
2913
2914         * top.c (quit_force): Call 'finalize_values'.
2915         * value.c (finalize_values): New function.
2916         * value.h (finalize_values): Declare.
2917
2918 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2919
2920         * NEWS: Announce $_gdb_major and $_gdb_minor.
2921
2922         * top.c (init_gdb_version_vars): New function.
2923         (gdb_init): Call init_gdb_version_vars.
2924
2925 2019-03-29  Tom Tromey  <tromey@adacore.com>
2926
2927         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2928         help text.  Remove dead code.
2929
2930 2019-03-29  Keith Seitz  <keiths@redhat.com>
2931
2932         From Siddhesh Poyarekar:
2933         * f-lang.h (f77_get_upperbound): Return LONGEST.
2934         (f77_get_lowerbound): Likewise.
2935         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2936         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2937         print them.
2938         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2939         plongest to format print it.
2940         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2941         (f77_get_upperbound): Likewise.
2942         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2943         LOWER_BOUND to LONGEST.
2944         (f77_create_arrayprint_offset_tbl): Likewise.
2945
2946 2019-03-29  Keith Seitz  <keiths@redhat.com>
2947
2948         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2949         %s/pulongest for TYPE_LENGTH instead of %d in format
2950         strings.
2951         * ada-typerint.c (ada_print_type): Likewise.
2952         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2953         * compile/compile-c-support.c (generate_register_struct): Likewise.
2954         * gdbtypes.c (recursive_dump_type): Likewise.
2955         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2956         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2957         instead of %d in format strings.
2958         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2959         to std::min to ULONGEST.
2960         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2961         instead of %d in format strings.
2962         * tracepoint.c (info_scope_command): Likewise.
2963         * typeprint.c (print_offset_data::update)
2964         (print_offset_data::finish): Likewise.
2965         * xtensa-tdep.c (xtensa_store_return_value)
2966         (xtensa_push_dummy_call): Likewise.
2967
2968 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2969
2970         * windows-nat.c (display_selector): Fixed format specifications
2971         for 64-bit Cygwin.
2972
2973 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2974
2975         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2976
2977 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2978
2979         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2980         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2981         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2982         (nios2_linux_init_abi): Install it.
2983
2984 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2985
2986         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2987
2988 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2989
2990         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2991
2992 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2993             Tom Tromey  <tromey@adacore.com>
2994
2995         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2996
2997 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2998
2999         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3000         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3001         method to compute the bounds of range types. Also print "[evaluated]"
3002         if the bounds' values come from a dynamic evaluation.
3003
3004 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3005
3006         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3007         whitespace when pretty printing is on.
3008
3009 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3010
3011         * ppc-linux-nat.c: Add include.
3012
3013 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3014
3015         * NEWS: Mention AArch64 Pointer Authentication.
3016
3017 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3018
3019         * arm-linux-nat.c: Add include.
3020
3021 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3022
3023         * source-cache.c (source_cache::get_source_lines): Re-read
3024         fullname after calling open_source_file.
3025
3026 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3027
3028         * NEWS: Mention TLS support for FreeBSD.
3029
3030 2019-03-25  Tom Tromey  <tromey@adacore.com>
3031
3032         * minsyms.c (BUNCH_SIZE): Update comment.
3033         (~minimal_symbol_reader): Remove old comment.
3034         (compact_minimal_symbols): Update comment.
3035         (minimal_symbol_reader::install): Remove old comment.  Update
3036         other comments.
3037
3038 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3039
3040         * s390-linux-nat.c: Add include.
3041
3042 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3043
3044         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3045         Call linux_get_hwcap.
3046         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3047         Likewise.
3048         (aarch64_linux_get_hwcap): Remove function.
3049         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3050         declaration.
3051         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3052         linux_get_hwcap.
3053         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3054         * linux-tdep.c (linux_get_hwcap): Add function.
3055         (linux_get_hwcap2): Likewise.
3056         * linux-tdep.h (linux_get_hwcap): Add declaration.
3057         (linux_get_hwcap2): Likewise.
3058         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3059         (ppc_linux_get_hwcap2): Likewise.
3060         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3061         linux_get_hwcap.
3062         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3063         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3064         (ppc_linux_nat_target::read_description): Likewise.
3065         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3066         * s390-linux-nat.c: Likewise.
3067         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3068
3069 2019-03-24  Tom Tromey  <tom@tromey.com>
3070
3071         * ada-lang.c (standard_lookup): Simplify initialization.
3072         (ada_lookup_symbol_nonlocal): Simplify return.
3073         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3074         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3075         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3076         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3077         initialization.
3078         * solib.c (solib_global_lookup): Simplify.
3079         * symtab.c (null_block_symbol): Remove.
3080         (symbol_cache_lookup): Simplify returns.
3081         (lookup_language_this): Simplify returns.
3082         (lookup_symbol_aux): Simplify return.
3083         (lookup_local_symbol): Simplify returns.
3084         (lookup_global_symbol_from_objfile): Simplify return.
3085         (lookup_symbol_in_objfile_symtabs)
3086         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3087         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3088         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3089         * cp-namespace.c (cp_lookup_bare_symbol)
3090         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3091         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3092         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3093         (cp_lookup_symbol_via_imports): Simplify initialization.
3094         (find_symbol_in_baseclass): Likewise.
3095         * symtab.h (null_block_symbol): Remove.
3096         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3097         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3098         (d_lookup_symbol_module): Likewise.
3099         (find_symbol_in_baseclass): Simplify initialization.
3100
3101 2019-03-24  Tom Tromey  <tom@tromey.com>
3102
3103         * expression.h: Don't include symtab.h.
3104         (struct block): Forward declare.
3105
3106 2019-03-24  Tom Tromey  <tom@tromey.com>
3107
3108         * c-exp.y (typebase): Remove casts.
3109         * gdbtypes.c (lookup_unsigned_typename, )
3110         (lookup_signed_typename): Remove cast.
3111         * eval.c (parse_to_comma_and_eval): Remove cast.
3112         * parse.c (write_dollar_variable): Remove cast.
3113         * block.h (struct block) <superblock>: Now const.
3114         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3115         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3116         (map_block): Make "block" const.
3117         * symfile.h (struct quick_symbol_functions)
3118         <map_matching_symbols>: Constify block argument to "callback".
3119         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3120         const.
3121         (find_pc_sect_compunit_symtab): Make "b" const.
3122         (find_symbol_at_address): Likewise.
3123         (search_symbols): Likewise.
3124         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3125         (dw2_debug_names_lookup_symbol): Likewise.
3126         (dw2_map_matching_symbols): Update.
3127         * p-valprint.c (pascal_val_print): Remove "block".
3128         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3129         (aux_add_nonlocal_symbols): Make "block" const.
3130         (resolve_subexp): Remove cast.
3131         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3132         const.
3133         (iterate_over_file_blocks): Likewise.
3134         * f-exp.y (%union) <bval>: Remove.
3135         * coffread.c (patch_opaque_types): Make "b" const.
3136         * spu-tdep.c (spu_catch_start): Make "block" const.
3137         * c-valprint.c (print_unpacked_pointer): Remove "block".
3138         * symmisc.c (dump_symtab_1): Make "b" const.
3139         (block_depth): Make "block" const.
3140         * d-exp.y (%union) <bval>: Remove.
3141         * cp-support.h (cp_lookup_rtti_type): Update.
3142         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3143         * psymtab.c (psym_lookup_symbol): Make "block" const.
3144         (maintenance_check_psymtabs): Make "b" const.
3145         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3146         (enumerate_locals, enumerate_args): Update.
3147         * python/py-symtab.c (stpy_global_block): Make "block" const.
3148         (stpy_static_block): Likewise.
3149         * inline-frame.c (block_starting_point_at): Make "new_block"
3150         const.
3151         * block.c (find_block_in_blockvector): Make return type const.
3152         (blockvector_for_pc_sect): Make "b" const.
3153         (find_block_in_blockvector): Make "b" const.
3154
3155 2019-03-23  Tom Tromey  <tom@tromey.com>
3156
3157         * varobj.c (varobj_create): Update.
3158         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3159         * printcmd.c (display_command, do_one_display): Don't reset
3160         innermost_block.
3161         * parser-defs.h (enum innermost_block_tracker_type): Move to
3162         expression.h.
3163         (innermost_block): Update comment.
3164         * parse.c (parse_exp_1): Add tracker_types parameter.
3165         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3166         tracker_types parameter.  Reset innermost_block.
3167         (parse_exp_in_context): Remove.
3168         (parse_expression_for_completion): Update.
3169         * objfiles.c (~objfile): Don't reset expression_context_block or
3170         innermost_block.
3171         * expression.h (enum innermost_block_tracker_type): Move from
3172         parser-defs.h.
3173         (parse_exp_1): Add tracker_types parameter.
3174         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3175         reset innermost_block.
3176
3177 2019-03-23  Tom Tromey  <tom@tromey.com>
3178
3179         * objfiles.h: Include bcache.h.
3180
3181 2019-03-23  Tom Tromey  <tom@tromey.com>
3182
3183         * linespec.c (get_current_search_block): Use
3184         scoped_restore_current_language.
3185         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3186
3187 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3188             Jiong Wang  <jiong.wang@arm.com>
3189
3190         * aarch64-linux-tdep.c
3191         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3192         section.
3193         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3194
3195 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3196             Jiong Wang  <jiong.wang@arm.com>
3197
3198         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3199         instructions.
3200         (aarch64_analyze_prologue_test): Add PACIASP test.
3201         (aarch64_prologue_prev_register): Unmask PC value.
3202
3203 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3204             Jiong Wang  <jiong.wang@arm.com>
3205
3206         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3207         (aarch64_dwarf2_prev_register): Unmask PC value.
3208         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3209         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3210         DW_CFA_AARCH64_negate_ra_state.
3211         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3212
3213 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3214             Jiong Wang  <jiong.wang@arm.com>
3215
3216         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3217         registers.
3218         (aarch64_pseudo_register_name): Likewise.
3219         (aarch64_pseudo_register_type): Likewise.
3220         (aarch64_pseudo_register_reggroup_p): Likewise.
3221         (aarch64_gdbarch_init): Add pauth registers.
3222         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3223         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3224         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3225         (struct gdbarch_tdep): Add regnum for ra_state.
3226
3227 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3228             Jiong Wang  <jiong.wang@arm.com>
3229
3230         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3231
3232 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3233             Jiong Wang  <jiong.wang@arm.com>
3234
3235         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3236         function.
3237         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3238         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3239         (aarch64_gdbarch_init): Add puth registers.
3240         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3241         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3242         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3243
3244 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3245             Jiong Wang  <jiong.wang@arm.com>
3246
3247         * aarch64-linux-nat.c
3248         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3249         * aarch64-linux-tdep.c
3250         (aarch64_linux_core_read_description): Likewise.
3251         (aarch64_linux_get_hwcap): New function.
3252         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3253         (aarch64_linux_get_hwcap): New declaration.
3254
3255 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3256             Jiong Wang  <jiong.wang@arm.com>
3257
3258         * aarch64-linux-nat.c
3259         (aarch64_linux_nat_target::read_description): Add pauth param.
3260         * aarch64-linux-tdep.c
3261         (aarch64_linux_core_read_description): Likewise.
3262         * aarch64-tdep.c (struct target_desc): Add in pauth.
3263         (aarch64_read_description): Add pauth param.
3264         (aarch64_gdbarch_init): Likewise.
3265         * aarch64-tdep.h (aarch64_read_description): Likewise.
3266         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3267         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3268         * features/Makefile: Add new files.
3269         * features/aarch64-pauth.c: New file.
3270         * features/aarch64-pauth.xml: New file.
3271
3272 2019-03-20  Tom Tromey  <tromey@adacore.com>
3273
3274         * infrun.c (handle_inferior_event): Rename from
3275         handle_inferior_event_1.  Create a scoped_value_mark.
3276         (handle_inferior_event): Remove.
3277
3278 2019-03-19  Tom Tromey  <tromey@adacore.com>
3279
3280         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3281         * infrun.h (print_stop_event): Add "displays" parameter.
3282         * infrun.c (print_stop_event): Add "displays" parameter.
3283
3284 2019-03-19  Pedro Alves  <palves@redhat.com>
3285
3286         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3287         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3288         to -1.  Fix TABs vs spaces.
3289         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3290         * tui/tui-out.h (tui_ui_out) Add intro comments.
3291         <m_line, m_start_of_line>: In-class initialize, and add describing
3292         comment.
3293
3294 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3295
3296         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3297         variable names.
3298         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3299
3300 2019-03-18  Pedro Alves  <palves@redhat.com>
3301             Eli Zaretskii <eliz@gnu.org>
3302
3303         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3304         m_line and m_start_of_line.
3305
3306 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3307
3308         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3309         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3310         it returns a newline.  This fixes a regression in TU mode, whereby
3311         the next line is output on the same screen line as the user input.
3312
3313 2019-03-18  Tom Tromey  <tromey@adacore.com>
3314
3315         * minsyms.c (minimal_symbol_reader::install): Remove call to
3316         obstack_blank.
3317
3318 2019-03-18  Pedro Alves  <palves@redhat.com>
3319
3320         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3321         New globals.
3322         (apply_style): New, factored out from ...
3323         (apply_ansi_escape): ... this.  Handle reverse video mode.
3324         (tui_set_reverse_mode): New function.
3325         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3326         * tui/tui-winsource.c (tui_show_source_line): Use
3327         tui_set_reverse_mode instead of setting A_STANDOUT.
3328         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3329         New setter methods.
3330
3331 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3332
3333         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3334         Handle tabs.
3335
3336 2019-03-18  Tom Tromey  <tromey@adacore.com>
3337
3338         * ada-lang.c (empty_array): Add "high" parameter.
3339         (ada_evaluate_subexp): Update.
3340
3341 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3342
3343         * unittests/string_view-selftests.c: Define
3344         _initialize_string_view_selftests unconditionally.
3345
3346 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3347
3348         PR gdb/24350
3349         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3350
3351 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3352
3353         PR gdb/24351
3354         * windows-nat.c (display_selector): Fix format specifiers.
3355
3356 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3357
3358         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3359         tui_refill_source_window instead of tui_refresh_win, to update the
3360         current execution line.  This fixes redisplay of the current line
3361         when stepping through the code with "next" or "step".
3362
3363 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3364
3365         * source-cache.c (source_cache::get_source_lines): Call
3366         find_source_lines to initialize s->nlines.  This fixes vertical
3367         scrolling of TUI source window when the DOWN arrow is pressed.
3368
3369 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3370
3371         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3372         linux-thread-db.c (_initialize_thread_db): Likewise.
3373
3374 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3375
3376         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3377         wclrtoeol in tui_show_source_line".  This reverts changes made in
3378         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3379
3380 2019-03-15  Tom Tromey  <tom@tromey.com>
3381
3382         * symtab.h (struct minimal_symbol): Derive from
3383         general_symbol_info.
3384         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3385         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3386         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3387         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3388         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3389         (MSYMBOL_SEARCH_NAME): Update.
3390         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3391         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3392         * minsyms.c (minimal_symbol_reader::record_full): Update.
3393
3394 2019-03-15  Tom Tromey  <tom@tromey.com>
3395
3396         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3397
3398 2019-03-15  Tom Tromey  <tom@tromey.com>
3399
3400         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3401         unique_xmalloc_ptr.
3402         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3403         Update.
3404         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3405         (build_minimal_symbol_hash_tables)
3406         (minimal_symbol_reader::install): Update.
3407
3408 2019-03-15  Tom Tromey  <tom@tromey.com>
3409
3410         * symtab.c (create_demangled_names_hash): Update.
3411         (symbol_set_names): Update.
3412         * objfiles.h (struct objfile_per_bfd_storage)
3413         <demangled_names_hash>: Now an htab_up.
3414         * objfiles.c (objfile_per_bfd_storage): Simplify.
3415
3416 2019-03-15  Tom Tromey  <tom@tromey.com>
3417
3418         * objfiles.h (struct objfile_per_bfd_storage): Declare
3419         destructor.
3420         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3421         New.
3422         (get_objfile_bfd_data): Use new.  Don't initialize
3423         language_of_main.
3424         (free_objfile_per_bfd_storage): Remove.
3425         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3426
3427 2019-03-15  Tom Tromey  <tom@tromey.com>
3428
3429         * symfile.c (reread_symbols): Update.
3430         * objfiles.c (objfile::objfile): Update.
3431         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3432         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3433         comment.
3434         (minimal_symbol_reader::install): Update.
3435         (terminate_minimal_symbol_table): Remove.
3436         * jit.c (jit_object_close_impl): Update.
3437
3438 2019-03-15  Tom Tromey  <tom@tromey.com>
3439
3440         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3441         initializations.
3442
3443 2019-03-15  Tom Tromey  <tom@tromey.com>
3444
3445         * objfiles.h (struct objfile_per_bfd_storage)
3446         <demangled_hash_languages>: Now a bitset.
3447         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3448         (lookup_minimal_symbol): Update.
3449
3450 2019-03-15  Tom Tromey  <tom@tromey.com>
3451
3452         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3453         Don't return the symbol.
3454         * coffread.c (record_minimal_symbol): Use record_full.
3455
3456 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3457
3458         The MS-Windows port of ncurses fails to switch to a color pair if
3459         one or both of the colors are the implicit default colors.  This
3460         change records the default colors when TUI is initialized, and
3461         then specifies them explicitly when a color pair uses the default
3462         colors.  This allows color styling in TUI mode on MS-Windows.
3463
3464         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3465         ncurses_norm_attr.
3466         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3467         colors in ncurses_norm_attr.
3468         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3469         "none", replace it with the default color recorded in
3470         ncurses_norm_attr.
3471
3472 2019-03-14  Tom Tromey  <tromey@adacore.com>
3473
3474         * source-cache.h (class source_cache) <get_source_lines>: Return
3475         std::string.
3476         * source-cache.c (source_cache::extract_lines): Handle case where
3477         first_pos==npos.  Return std::string.
3478         (source_cache::get_source_lines): Update.
3479
3480 2019-03-14  Tom Tromey  <tromey@adacore.com>
3481
3482         * NEWS: Add item for "style sources" commands.
3483         * source-cache.c (source_cache::get_source_lines): Check
3484         source_styling.
3485         * cli/cli-style.c (source_styling): New global.
3486         (_initialize_cli_style): Add "style sources" commands.
3487         (show_style_sources): New function.
3488         * cli/cli-style.h (source_styling): Declare.
3489
3490 2019-03-14  Pedro Alves  <palves@redhat.com>
3491             Tom Tromey  <tromey@adacore.com>
3492
3493         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3494         * tui/tui-winsource.c (tui_refill_source_window): New function,
3495         from...
3496         (tui_horizontal_source_scroll): ... here.  Move some logic.
3497         * cli/cli-style.c (set_style_enabled): Notify new observable.
3498         * tui/tui-hooks.c (tui_redisplay_source): New function.
3499         (tui_attach_detach_observers): Attach or detach
3500         tui_redisplay_source.
3501         * observable.h (source_styling_changed): New observable.
3502         * observable.c: Define source_styling_changed observable.
3503
3504 2019-03-13  Tom Tromey  <tromey@adacore.com>
3505
3506         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3507         (i386_gnu_nat_target::store_registers): Update.
3508         * target-debug.h (target_debug_print_std_string): New macro.
3509         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3510         * windows-tdep.c (display_one_tib): Update.
3511         * tui/tui-stack.c (tui_make_status_line): Update.
3512         * top.c (print_inferior_quit_action): Update.
3513         * thread.c (thr_try_catch_cmd): Update.
3514         (add_thread_with_info): Update.
3515         (thread_target_id_str): Update.
3516         (thr_try_catch_cmd): Update.
3517         (thread_command): Update.
3518         (thread_find_command): Update.
3519         * record-btrace.c (record_btrace_target::info_record)
3520         (record_btrace_resume_thread, record_btrace_target::resume)
3521         (record_btrace_cancel_resume, record_btrace_step_thread)
3522         (record_btrace_target::wait, record_btrace_target::wait)
3523         (record_btrace_target::wait, record_btrace_target::stop): Update.
3524         * progspace.c (print_program_space): Update.
3525         * process-stratum-target.c
3526         (process_stratum_target::thread_address_space): Update.
3527         * linux-fork.c (linux_fork_mourn_inferior)
3528         (detach_checkpoint_command, info_checkpoints_command)
3529         (linux_fork_context): Update.
3530         (linux_fork_detach): Update.
3531         (class scoped_switch_fork_info): Update.
3532         (delete_checkpoint_command): Update.
3533         * infrun.c (follow_fork_inferior): Update.
3534         (follow_fork_inferior): Update.
3535         (proceed_after_vfork_done): Update.
3536         (handle_vfork_child_exec_or_exit): Update.
3537         (follow_exec): Update.
3538         (displaced_step_prepare_throw): Update.
3539         (displaced_step_restore): Update.
3540         (start_step_over): Update.
3541         (resume_1): Update.
3542         (clear_proceed_status_thread): Update.
3543         (proceed): Update.
3544         (print_target_wait_results): Update.
3545         (do_target_wait): Update.
3546         (context_switch): Update.
3547         (stop_all_threads): Update.
3548         (restart_threads): Update.
3549         (finish_step_over): Update.
3550         (handle_signal_stop): Update.
3551         (switch_back_to_stepped_thread): Update.
3552         (keep_going_pass_signal): Update.
3553         (print_exited_reason): Update.
3554         (normal_stop): Update.
3555         * inferior.c (inferior_pid_to_str): Change return type.
3556         (print_selected_inferior): Update.
3557         (add_inferior): Update.
3558         (detach_inferior): Update.
3559         * dummy-frame.c (fprint_dummy_frames): Update.
3560         * dcache.c (dcache_info_1): Update.
3561         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3562         (btrace_fetch, btrace_clear): Update.
3563         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3564         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3565         type.
3566         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3567         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3568         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3569         * gdbarch.c, gdbarch.h: Rebuild.
3570         * gdbarch.sh (core_pid_to_str): Change return type.
3571         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3572         return type.
3573         (windows_nat_target::pid_to_str): Change return type.
3574         (windows_delete_thread): Update.
3575         (windows_nat_target::attach): Update.
3576         (windows_nat_target::files_info): Update.
3577         * target-delegates.c: Rebuild.
3578         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3579         return type.
3580         (sol_thread_target::pid_to_str): Change return type.
3581         * remote.c (class remote_target) <pid_to_str>: Change return
3582         type.
3583         (remote_target::pid_to_str): Change return type.
3584         (extended_remote_target::attach, remote_target::remote_stop_ns)
3585         (remote_target::remote_notif_remove_queued_reply)
3586         (remote_target::push_stop_reply, remote_target::disable_btrace):
3587         Update.
3588         (extended_remote_target::attach): Update.
3589         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3590         type.
3591         (gdbsim_target::pid_to_str): Change return type.
3592         * ravenscar-thread.c (struct ravenscar_thread_target)
3593         <pid_to_str>: Change return type.
3594         (ravenscar_thread_target::pid_to_str): Change return type.
3595         * procfs.c (class procfs_target) <pid_to_str>: Change return
3596         type.
3597         (procfs_target::pid_to_str): Change return type.
3598         (procfs_target::attach): Update.
3599         (procfs_target::detach): Update.
3600         (procfs_target::fetch_registers): Update.
3601         (procfs_target::store_registers): Update.
3602         (procfs_target::wait): Update.
3603         (procfs_target::files_info): Update.
3604         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3605         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3606         return type.
3607         (nto_procfs_target::pid_to_str): Change return type.
3608         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3609         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3610         return type.
3611         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3612         (exit_lwp): Update.
3613         (attach_proc_task_lwp_callback, get_detach_signal)
3614         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3615         (linux_nat_target::resume, wait_lwp, stop_callback)
3616         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3617         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3618         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3619         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3620         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3621         type.
3622         (inf_ptrace_target::attach): Update.
3623         (inf_ptrace_target::files_info): Update.
3624         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3625         type.
3626         (go32_nat_target::pid_to_str): Change return type.
3627         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3628         (gnu_nat_target::wait): Update.
3629         (gnu_nat_target::wait): Update.
3630         (gnu_nat_target::resume): Update.
3631         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3632         (fbsd_nat_target::wait): Update.
3633         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3634         type.
3635         (darwin_nat_target::attach): Update.
3636         * corelow.c (class core_target) <pid_to_str>: Change return type.
3637         (core_target::pid_to_str): Change return type.
3638         * target.c (normal_pid_to_str): Change return type.
3639         (default_pid_to_str): Likewise.
3640         (target_pid_to_str): Change return type.
3641         (target_translate_tls_address): Update.
3642         (target_announce_detach): Update.
3643         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3644         return type.
3645         (bsd_uthread_target::pid_to_str): Change return type.
3646         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3647         type.
3648         (bsd_kvm_target::pid_to_str): Change return type.
3649         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3650         return type.
3651         (aix_thread_target::pid_to_str): Change return type.
3652         * target.h (struct target_ops) <pid_to_str>: Change return type.
3653         (target_pid_to_str, normal_pid_to_str): Likewise.
3654         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3655         type.
3656         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3657         type.
3658         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3659         return type.
3660         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3661         type.
3662         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3663         type.
3664         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3665         return type.
3666
3667 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3668
3669         * NEWS: Mention that the new default MI version is 3.  Mention
3670         changes to the output of commands and events that deal with
3671         multi-location breakpoints.
3672         * breakpoint.c: Include "mi/mi-out.h".
3673         (print_one_breakpoint): Change output syntax if using MI version
3674         >= 3.
3675         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3676         New.
3677         (mi_multi_location_breakpoint_output_fixed): New.
3678         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3679         (mi_cmd_fix_multi_location_breakpoint_output): New.
3680         (mi_multi_location_breakpoint_output_fixed): New.
3681         * mi/mi-cmds.c (mi_cmds): Register command
3682         -fix-multi-location-breakpoint-output.
3683         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3684         interpreter "mi".
3685
3686 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3687
3688         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3689         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3690         instantiate mi_ui_out based on interpreter name.
3691         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3692         * mi/mi-main.c (mi_load_progress): Likewise.
3693
3694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3695
3696         * NEWS: Combine separate "New targets" sections for 8.3.
3697
3698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3699
3700         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3701         (ppcfbsd_init_abi): Install gdbarch
3702         "fetch_tls_load_module_address" and "get_thread_local_address"
3703         methods.
3704
3705 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3706
3707         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3708         (riscv_fbsd_init_abi): Install gdbarch
3709         "fetch_tls_load_module_address" and "get_thread_local_address"
3710         methods.
3711
3712 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3713
3714         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3715         (i386fbsd_init_abi): Install gdbarch
3716         "fetch_tls_load_module_address" and "get_thread_local_address"
3717         methods.
3718
3719 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3720
3721         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3722         (amd64fbsd_init_abi): Install gdbarch
3723         "fetch_tls_load_module_address" and "get_thread_local_address"
3724         methods.
3725
3726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3727
3728         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3729         (struct fbsd_pspace_data): New type.
3730         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3731         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3732         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3733         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3734         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3735
3736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3737
3738         * gdbtypes.c (lookup_struct_elt): New function.
3739         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3740         * gdbtypes.h (struct struct_elt): New type.
3741         (lookup_struct_elt): New prototype.
3742
3743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3744
3745         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3746         remove disabled code block.
3747
3748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3749
3750         * gdbarch.sh (get_thread_local_address): New method.
3751         * gdbarch.h, gdbarch.c: Regenerate.
3752         * target.c (target_translate_tls_address): Use
3753         gdbarch_get_thread_local_address if present instead of
3754         target::get_thread_local_address.
3755
3756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3757
3758         * target.h (target::get_thread_local_address): Update comment.
3759
3760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3761
3762         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3763         objfile->separate_debug_objfile_backlink if not NULL.
3764
3765 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3766
3767         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3768         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3769         (amd64bsd_store_inferior_registers): Likewise.
3770         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3771         Enable segment base registers.
3772         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3773         PT_GETFSBASE and PT_GETGSBASE.
3774         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3775         PT_SETGSBASE.
3776         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3777         segment base registers.
3778         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3779
3780 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3781
3782         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3783         Update calls to i386_target_description to add 'segments'
3784         parameter.
3785         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3786         add segment base registers.
3787         * arch/i386.c (i386_create_target_description): Add 'segments'
3788         parameter to enable segment base registers.
3789         * arch/i386.h (i386_create_target_description): Likewise.
3790         * features/i386/32bit-segments.xml: New file.
3791         * features/i386/32bit-segments.c: Generate.
3792         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3793         call to i386_target_description to add 'segments' parameter.
3794         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3795         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3796         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3797         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3798         if feature is present.
3799         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3800         Add 'segments' parameter to call to i386_target_description.
3801         (i386_target_description): Add 'segments' parameter to enable
3802         segment base registers.
3803         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3804         to call to i386_target_description.
3805         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3806         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3807         Define I386_NUM_REGS.
3808         (i386_target_description): Add 'segments' parameter to enable
3809         segment base registers.
3810
3811 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3812
3813         PR/24325
3814         * source-cache.c: #undef open and close, to avoid unresolved
3815         externals during linking.
3816
3817 2019-03-12  Tom Tromey  <tromey@adacore.com>
3818
3819         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3820         const.  Add initializers.
3821         (_initialize_remote): Don't initialize ptid globals.
3822
3823 2019-03-12  Pedro Alves  <palves@redhat.com>
3824
3825         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3826
3827 2019-03-12  Pedro Alves  <palves@redhat.com>
3828
3829         * cp-name-parser.y (main): Remove unused 'len' variable.
3830
3831 2019-03-12  Tom Tromey  <tromey@adacore.com>
3832
3833         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3834         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3835
3836 2019-03-12  Tom Tromey  <tromey@adacore.com>
3837
3838         * linux-nat.c (iterate_over_lwps): Update.
3839         (stop_callback): Remove parameter.
3840         (stop_wait_callback, detach_callback, resume_set_callback)
3841         (select_singlestep_lwp_callback, set_ignore_sigint)
3842         (status_callback, resumed_callback, resume_clear_callback)
3843         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3844         data parameter.
3845         (linux_nat_target::detach, linux_nat_target::resume)
3846         (linux_stop_and_wait_all_lwps, select_event_lwp)
3847         (linux_nat_filter_event, linux_nat_wait_1)
3848         (linux_nat_target::kill, linux_nat_target::stop)
3849         (linux_nat_target::stop): Update.
3850         (linux_nat_resume_callback): Change type.
3851         (resume_stopped_resumed_lwps, count_events_callback)
3852         (select_event_lwp_callback): Likewise.
3853         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3854         * arm-linux-nat.c (struct update_registers_data): Remove.
3855         (update_registers_callback): Change type.
3856         (arm_linux_insert_hw_breakpoint1): Update.
3857         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3858         parameter.
3859         (x86_linux_dr_set_addr): Update.
3860         (x86_linux_dr_set_control): Update.
3861         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3862         (iterate_over_lwps): Use gdb::function_view.
3863         * nat/aarch64-linux-hw-point.c (struct
3864         aarch64_dr_update_callback_param): Remove.
3865         (debug_reg_change_callback): Change type.
3866         (aarch64_notify_debug_reg_change): Update.
3867         * s390-linux-nat.c (s390_refresh_per_info): Update.
3868
3869 2019-03-11  Tom Tromey  <tromey@adacore.com>
3870
3871         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3872         redundant assignment to "this_cu".
3873
3874 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3875
3876         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3877
3878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3879
3880         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3881         from...
3882         (rank_one_type): ... this.
3883
3884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3885
3886         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3887         from...
3888         (rank_one_type): ... this.
3889
3890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3891
3892         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3893         from...
3894         (rank_one_type): ... this.
3895
3896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3897
3898         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3899         from...
3900         (rank_one_type): ... this.
3901
3902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3903
3904         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3905         from...
3906         (rank_one_type): ... this.
3907
3908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3909
3910         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3911         from...
3912         (rank_one_type): ... this.
3913
3914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3915
3916         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3917         from...
3918         (rank_one_type): ... this.
3919
3920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3921
3922         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3923         from...
3924         (rank_one_type): ... this.
3925
3926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3927
3928         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3929         from...
3930         (rank_one_type): ... this.
3931
3932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3933
3934         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3935         from...
3936         (rank_one_type): ... this.
3937
3938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3939
3940         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3941         from...
3942         (rank_one_type): ... this.
3943
3944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3945
3946         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3947         from...
3948         (rank_one_type): ... this.
3949
3950 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3951
3952         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3953         inferior-events' shows the example events.
3954
3955 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3956
3957         Support styling on native MS-Windows console
3958
3959         PR/24315
3960         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3961         on MS-Windows if $TERM is not defined.
3962
3963         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3964
3965         * posix-hdep.c (gdb_console_fputs):
3966         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3967         functions.
3968         * ui-file.h (gdb_console_fputs): Add prototype.
3969
3970         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3971         back to fputs only if the former returns zero.
3972
3973 2019-03-07  Tom Tromey  <tom@tromey.com>
3974
3975         * symmisc.c (print_symbol_bcache_statistics): Update.
3976         (print_objfile_statistics): Update.
3977         * symfile.c (allocate_symtab): Update.
3978         * stabsread.c: Don't include bcache.h.
3979         * psymtab.h (struct psymbol_bcache): Don't declare.
3980         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3981         (psymbol_bcache_init, psymbol_bcache_free)
3982         (psymbol_bcache_get_bcache): Don't declare.
3983         * psymtab.c (struct psymbol_bcache): Remove.
3984         (psymtab_storage::psymtab_storage): Update.
3985         (psymtab_storage::~psymtab_storage): Update.
3986         (psymbol_bcache_init, psymbol_bcache_free)
3987         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3988         (add_psymbol_to_bcache): Update.
3989         (allocate_psymtab): Update.
3990         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3991         macro_cache>: No longer pointers.
3992         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3993         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3994         * macrotab.c (macro_bcache): Update.
3995         * macroexp.c: Don't include bcache.h.
3996         * gdbtypes.c (check_types_worklist): Update.
3997         (types_deeply_equal): Remove TRY/CATCH.  Update.
3998         * elfread.c (elf_symtab_read): Update.
3999         * dwarf2read.c: Don't include bcache.h.
4000         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4001         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4002         (print_bcache_statistics, bcache_memory_used): Don't declare.
4003         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4004         methods.  Rename all data members.
4005         * bcache.c (struct bcache): Move to bcache.h.
4006         (bcache::expand_hash_table): Rename from expand_hash_table.
4007         (bcache): Remove.
4008         (bcache::insert): Rename from bcache_full.
4009         (bcache::compare): Rename from bcache_compare.
4010         (bcache_xmalloc): Remove.
4011         (bcache::~bcache): Rename from bcache_xfree.
4012         (bcache::print_statistics): Rename from print_bcache_statistics.
4013         (bcache::memory_used): Rename from bcache_memory_used.
4014
4015 2019-03-07  Pedro Alves  <palves@redhat.com>
4016
4017         * infrun.c (normal_stop): Also check for
4018         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4019
4020 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4021
4022         * f-lang.c (value_from_host_double): Moved to...
4023         * value.c (value_from_host_double): ...here.
4024         * value.h (value_from_host_double): Declare.
4025         * guile/scm-math.c (vlscm_convert_typed_number): Use
4026         value_from_host_double.
4027         (vlscm_convert_number): Likewise.
4028         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4029         * python/py-value.c (convert_value_from_python): Likewise.
4030
4031 2019-03-06  Tom Tromey  <tom@tromey.com>
4032
4033         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4034
4035 2019-03-06  Tom Tromey  <tom@tromey.com>
4036
4037         * utils.h (free_current_contents): Don't declare.
4038         * utils.c (free_current_contents): Remove.
4039
4040 2019-03-06  Tom Tromey  <tom@tromey.com>
4041
4042         * top.c (quit_force): Update.
4043         * main.c (captured_command_loop): Update.
4044         * common/new-op.c (operator new): Update.
4045         * common/common-exceptions.c (struct catcher)
4046         <save_cleanup_chain>: Remove member.
4047         (exceptions_state_mc_init): Update.
4048         (exception_try_scope_entry): Return nullptr.
4049         (exception_try_scope_exit, exception_rethrow)
4050         (throw_exception_sjlj, throw_exception_cxx): Update.
4051         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4052         (all_cleanups, do_cleanups, discard_cleanups)
4053         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4054         (restore_cleanups, restore_final_cleanups): Don't declare.
4055         (do_final_cleanups): Remove parameter.
4056         * common/cleanups.c (cleanup_chain, make_cleanup)
4057         (make_cleanup_dtor, all_cleanups, do_cleanups)
4058         (discard_my_cleanups, discard_cleanups)
4059         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4060         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4061         (null_cleanup): Remove.
4062         (do_final_cleanups): Remove parameter.
4063
4064 2019-03-06  Tom Tromey  <tom@tromey.com>
4065
4066         * remote.c (remote_target::remote_parse_stop_reply): Use
4067         unique_xmalloc_ptr.
4068
4069 2019-03-06  Tom Tromey  <tom@tromey.com>
4070
4071         * stabsread.c (struct stabs_field_info): Rename from field_info.
4072         <list, fnlist>: Add initializers.
4073         <obstack>: New member.
4074         (read_member_functions, read_struct_fields, read_baseclasses):
4075         Allocate on obstack.  Don't use cleanups.
4076         (read_one_struct_field, read_member_functions, read_struct_fields)
4077         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4078         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4079         (read_struct_type): Update.
4080
4081 2019-03-06  Tom Tromey  <tom@tromey.com>
4082
4083         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4084         * common/filestuff.h (make_cleanup_close): Don't declare.
4085         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4086         Remove.
4087
4088 2019-03-06  Tom Tromey  <tom@tromey.com>
4089
4090         * solib-aix.c: Use make_scope_exit.
4091
4092 2019-03-06  Tom Tromey  <tom@tromey.com>
4093
4094         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4095         Use make_scope_exit.
4096
4097 2019-03-06  Tom Tromey  <tom@tromey.com>
4098
4099         * solib-svr4.c (disable_probes_interface): Remove parameter.
4100         (svr4_handle_solib_event): Use make_scope_exit.
4101
4102 2019-03-06  Tom Tromey  <tom@tromey.com>
4103
4104         * remote.c (struct stop_reply_deleter): Remove.
4105         (stop_reply_up): Update.
4106         (struct stop_reply): Derive from notif_event.  Don't typedef.
4107         <regcache>: Now a std::vector.
4108         (stop_reply_xfree): Remove.
4109         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4110         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4111         (remote_target::discard_pending_stop_replies): Use delete.
4112         (remote_target::remote_parse_stop_reply): Update.
4113         (remote_target::process_stop_reply): Update.
4114         * remote-notif.h (struct notif_event): Add virtual destructor.
4115         Remove "dtr" member.
4116         (struct notif_client) <alloc_event>: Return a unique_ptr.
4117         (notif_event_xfree): Don't declare.
4118         (notif_event_up): New typedef.
4119         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4120         (notif_event_xfree, do_notif_event_xfree): Remove.
4121         (remote_notif_state_xfree): Update.
4122
4123 2019-03-06  Tom Tromey  <tom@tromey.com>
4124
4125         * infrun.c (displaced_step_clear_cleanup): Now a
4126         forward_scope_exit type.
4127         (displaced_step_prepare_throw): Update.
4128         (displaced_step_fixup): Update.
4129
4130 2019-03-06  Tom Tromey  <tom@tromey.com>
4131
4132         * inferior.h (class inferior): Update comment.
4133         * gdbthread.h (class thread_info): Update comment.
4134
4135 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4136             Tom Tromey  <tom@tromey.com>
4137
4138         * stabsread.h (struct stab_section_list): Remove.
4139         (coffstab_build_psymtabs): Update.
4140         * dbxread.c (symbuf_sections): Now a std::vector.
4141         (sect_idx): New global.
4142         (fill_symbuf): Update.
4143         (coffstab_build_psymtabs): Change type of stabsects parameter.
4144         Update.
4145         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4146         std::vector.
4147         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4148         (coff_locate_sections): Update.
4149         (coff_symfile_read): Remove cleanups.  Update.
4150         (init_stringtab): Add storage parameter.
4151         (free_stringtab, free_stringtab_cleanup): Remove.
4152         (init_lineno): Add storage parameter.
4153         (free_linetab, free_linetab_cleanup): Remove.
4154
4155 2019-03-06  Pedro Alves  <palves@redhat.com>
4156
4157         * linux-fork.c (fork_info::clobber_regs): Delete.
4158         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4159         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4160         comment.  Adjust.
4161         (scoped_switch_fork_info::scoped_switch_fork_info)
4162         (checkpoint_command, linux_fork_context): Adjust
4163         fork_save_infrun_state calls.
4164
4165 2019-03-06  Pedro Alves  <palves@redhat.com>
4166
4167         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4168         (inf_has_multiple_threads): Return 'bool' and rewrite using
4169         inferior_info::threads().
4170
4171 2019-03-06  Pedro Alves  <palves@redhat.com>
4172
4173         * linux-fork.c: Include <list>.
4174         (fork_list): Now a std::list instance.
4175         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4176         (forks_exist_p, find_last_fork): Adjust.
4177         (new_fork): Delete.
4178         (one_fork_p): New.
4179         (add_fork): Adjust.
4180         (free_fork): Delete, folded into fork_info::~fork_info().
4181         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4182         Adjust.
4183         (init_fork_list): Delete.
4184         (linux_fork_killall, linux_fork_mourn_inferior)
4185         (linux_fork_detach, info_checkpoints_command): Adjust.
4186         (_initialize_linux_fork): No longer call init_fork_list.
4187
4188 2019-03-06  Pedro Alves  <palves@redhat.com>
4189
4190         * linux-fork.c (new_fork): New, split out of ...
4191         (add_fork): ... this.  Return void.  Move "first fork" special
4192         case from here, to ...
4193         (checkpoint_command): ... here.
4194         * linux-linux.h (add_fork): Return void.
4195
4196 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4197
4198         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4199
4200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4201             Chris January  <chris.january@arm.com>
4202             David Lecomber  <david.lecomber@arm.com>
4203
4204         * f-exp.y: New token, UNOP_INTRINSIC.
4205         (exp): New pattern using UNOP_INTRINSIC token.
4206         (f77_keywords): Add 'abs' keyword.
4207         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4208         (value_from_host_double): New function.
4209         (evaluate_subexp_f): Support UNOP_ABS.
4210
4211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4212
4213         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4214         types.
4215
4216 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4217
4218         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4219         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4220         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4221
4222 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4223
4224         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4225
4226 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4227             Chris January  <chris.january@arm.com>
4228
4229         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4230         * f-exp.y: Define 'KIND' token.
4231         (exp): New pattern for KIND expressions.
4232         (ptype): Handle types with a kind extension.
4233         (direct_abs_decl): Extend to spot kind extensions.
4234         (f77_keywords): Add 'kind' to the list.
4235         (push_kind_type): New function.
4236         (convert_to_kind_type): New function.
4237         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4238         * parse.c (operator_length_standard): Likewise.
4239         * parser-defs.h (enum type_pieces): Add tp_kind.
4240         * std-operator.def: Add UNOP_KIND.
4241
4242 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4243
4244         * f-exp.y (f_parse): Set yydebug.
4245
4246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * f-lang.c (evaluate_subexp_f): New function.
4249         (exp_descriptor_f): New global.
4250         (f_language_defn): Use exp_descriptor_f instead of
4251         exp_descriptor_standard.
4252
4253 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4254
4255         * f-exp.y (struct token): Add comments.
4256         (dot_ops): Remove uppercase versions and the end marker.
4257         (f77_keywords): Likewise.
4258         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4259         entries in the dot_ops array are case insensitive, and use
4260         strncasecmp to compare strings.  Also some whitespace cleanup in
4261         this area.  Similar for the f77_keywords array, except entries in
4262         this list might be case sensitive.
4263
4264 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * f-exp.y (struct f77_boolean_val): Add comments.
4267         (boolean_values): Remove uppercase versions, and end marker.
4268         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4269         and use strncasecmp to achieve case insensitivity.  Additionally,
4270         perform whitespace cleanup around this code.
4271
4272 2019-03-06  Tom Tromey  <tromey@adacore.com>
4273
4274         * remote-sim.c (gdbsim_target_open): Use result of
4275         gdb_argv::release.
4276
4277 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4278         Dirk Schubert  <dirk.schubert@arm.com>
4279         Chris January  <chris.january@arm.com>
4280
4281         * eval.c (evaluate_subexp_standard): Call Fortran argument
4282         wrapping logic.
4283         * f-lang.c (struct value): A value which can be passed into a
4284         Fortran function call.
4285         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4286         where appropriate.
4287         (struct type): Value ready for a Fortran function call.
4288         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4289         is needed.
4290         * f-lang.h (fortran_argument_convert): Declaration.
4291         (fortran_preserve_arg_pointer): Declaration.
4292         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4293
4294 2019-03-05  Tom Tromey  <tromey@adacore.com>
4295
4296         * python/py-prettyprint.c (print_string_repr): Remove #if.
4297         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4298
4299 2019-03-05  Tom Tromey  <tromey@adacore.com>
4300
4301         * target.c (the_dummy_target): Move later.  Change type to
4302         "dummy_target".
4303         (initialize_targets): Don't initialize the_dummy_target.
4304
4305 2019-03-05  Tom Tromey  <tromey@adacore.com>
4306
4307         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4308         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4309
4310 2019-03-05  Tom Tromey  <tromey@adacore.com>
4311
4312         * windows-nat.c (windows_nat_target::attach)
4313         (windows_nat_target::detach): Don't call gdb_flush.
4314         * valprint.c (generic_val_print, val_print, val_print_string):
4315         Don't call gdb_flush.
4316         * utils.c (defaulted_query): Don't call gdb_flush.
4317         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4318         * target.c (target_announce_detach): Don't call gdb_flush.
4319         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4320         * remote.c (extended_remote_target::attach): Don't call
4321         gdb_flush.
4322         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4323         * printcmd.c (do_examine): Don't call gdb_flush.
4324         (info_display_command): Don't call gdb_flush.
4325         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4326         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4327         * memattr.c (info_mem_command): Don't call gdb_flush.
4328         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4329         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4330         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4331         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4332         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4333         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4334         (gnu_nat_target::detach): Don't call gdb_flush.
4335         * f-valprint.c (f_val_print): Don't call gdb_flush.
4336         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4337         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4338         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4339         gdb_flush.
4340         * c-valprint.c (c_val_print): Don't call gdb_flush.
4341         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4342
4343 2019-03-05  Tom Tromey  <tromey@adacore.com>
4344
4345         * varobj.c (update_dynamic_varobj_children): Update.
4346         (install_default_visualizer): Use reset, not release.
4347         * value.c (set_internalvar): Update.
4348         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4349         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4350         ATTRIBUTE_UNUSED_RESULT.
4351
4352 2019-03-05  Tom Tromey  <tromey@adacore.com>
4353
4354         * remote.c (class scoped_remote_fd) <release>: Add
4355         ATTRIBUTE_UNUSED_RESULT.
4356
4357 2019-03-05  Tom Tromey  <tromey@adacore.com>
4358
4359         * macroexp.c (struct macro_buffer) <release>: Add
4360         ATTRIBUTE_UNUSED_RESULT.
4361
4362 2019-03-05  Tom Tromey  <tromey@adacore.com>
4363
4364         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4365         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4366         ATTRIBUTE_UNUSED_RESULT.
4367
4368 2019-03-05  Tom Tromey  <tromey@adacore.com>
4369
4370         * common/scoped_fd.h (class scoped_fd) <release>: Add
4371         ATTRIBUTE_UNUSED_RESULT.
4372
4373 2019-03-05  Tom Tromey  <tromey@adacore.com>
4374
4375         * parser-defs.h (struct parser_state) <release>: Add
4376         ATTRIBUTE_UNUSED_RESULT.
4377
4378 2019-03-05  Tom Tromey  <tromey@adacore.com>
4379
4380         * utils.h (class gdb_argv) <release>: Add
4381         ATTRIBUTE_UNUSED_RESULT.
4382         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4383
4384 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4385
4386         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4387         for-loop range, to avoid compiler warnings.
4388
4389         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4390         avoid compiler warnings about unused variables.
4391
4392         * NEWS: Mention end of support for native debugging on MS-Windows
4393         before XP.
4394
4395         PR gdb/24292
4396         * common/netstuff.c:
4397         * gdbserver/gdbreplay.c
4398         * gdbserver/remote-utils.c:
4399         * ser-tcp.c:
4400         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4401         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4402         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4403         'getaddrinfo' and 'freeaddrinfo' were not available before
4404         Windows XP, and mingw.org's MinGW headers by default define
4405         _WIN32_WINNT to 0x500.
4406
4407 2019-03-01  Gary Benson <gbenson@redhat.com>
4408
4409         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4410
4411 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4412             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4413
4414         PR gdb/8527
4415         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4416         set_sigint_trap, clear_sigint_trap.
4417
4418 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4419
4420         * target.c (target_detach): Clear the regcache and the
4421         frame cache.
4422
4423 2019-02-27  Pedro Alves  <palves@redhat.com>
4424
4425         * utils.c (set_screen_size): When we cap the height/width sizes,
4426         tweak the corresponding command variable to show "unlimited":
4427
4428 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4429             Pedro Alves  <palves@redhat.com>
4430
4431         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4432         before calling rl_set_screen_size.
4433
4434 2019-02-27  Tom Tromey  <tromey@adacore.com>
4435
4436         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4437         define.
4438         * python/py-value.c: Remove Python 2.4 workaround.
4439         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4440         workaround.
4441         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4442         Python 2.4 workaround.
4443         * python/python-internal.h: Remove Python 2.4 comment.
4444         (Py_ssize_t): Don't define.
4445         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4446         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4447         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4448         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4449         * python/python.c (do_start_initialization): Remove Python 2.4
4450         workaround.
4451         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4452         (print_children): Remove Python 2.4 workaround.
4453         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4454         workaround.
4455         (CHARBUFFERPROC_NAME): Remove.
4456         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4457         Python 2.4 workaround.
4458
4459 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4460
4461         * NEWS: Note minimum Python version.
4462
4463 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4464
4465         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4466         code from these functions.  Remove corresponding ifdefs.  Use
4467         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4468         Remove gotos and target of gotos.
4469         (infpy_search_memory): Likewise.
4470
4471 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4474         (hppa_gdbarch_init): Don't register deleted functions with
4475         gdbarch.
4476
4477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4478
4479         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4480         (h8300_unwind_sp): Delete.
4481         (h8300_dummy_id): Delete.
4482         (h8300_gdbarch_init): Don't register deleted functions with
4483         gdbarch.
4484
4485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4486
4487         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4488         (ft32_unwind_pc): Delete.
4489         (ft32_unwind_sp): Delete.
4490         (ft32_gdbarch_init): Don't register deleted functions with
4491         gdbarch.
4492
4493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4496         (frv_unwind_pc): Delete.
4497         (frv_unwind_sp): Delete.
4498         (frv_gdbarch_init): Don't register deleted functions with
4499         gdbarch.
4500
4501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4504         (riscv_unwind_pc): Delete.
4505         (riscv_unwind_sp): Delete.
4506         (riscv_gdbarch_init): Don't register deleted functions with
4507         gdbarch.
4508
4509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4510
4511         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4512         (csky_unwind_pc): Delete.
4513         (csky_unwind_sp): Delete.
4514         (csky_gdbarch_init): Don't register deleted functions with
4515         gdbarch.
4516
4517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4518
4519         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4520         (cris_unwind_pc): Delete.
4521         (cris_unwind_sp): Delete.
4522         (cris_gdbarch_init): Don't register deleted functions with
4523         gdbarch.
4524
4525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4528         (bfin_unwind_pc): Delete.
4529         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4530
4531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4532
4533         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4534         (arm_unwind_pc): Delete.
4535         (arm_unwind_sp): Delete.
4536         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4537
4538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4541         (arc_unwind_pc): Delete.
4542         (arc_unwind_sp): Delete.
4543         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4544
4545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4548         (alpha_unwind_pc): Delete.
4549         (alpha_gdbarch_init): Don't register deleted functions with
4550         gdbarch.
4551
4552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4553
4554         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4555         (aarch64_unwind_pc): Delete.
4556         (aarch64_unwind_sp): Delete.
4557         (aarch64_gdbarch_init): Don't register deleted functions with
4558         gdbarch.
4559
4560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4561
4562         * gdbtypes.c (type_align): Don't consider static members when
4563         computing structure alignment.
4564
4565 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4566
4567         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4568         return 0 for other types.
4569         * arch-utils.c (default_type_align): Always return 0.
4570         * gdbarch.h: Regenerate.
4571         * gdbarch.sh (type_align): Extend comment.
4572         * gdbtypes.c (type_align): Add additional comments, always call
4573         gdbarch_type_align before applying the default rules.
4574         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4575         generic code will then apply a suitable default.
4576         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4577         types, return 0 for other types.
4578
4579 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4580
4581         * NEWS: Create a new section for the next release branch.
4582         Rename the section of the current branch, now that it has
4583         been cut.
4584
4585 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4586
4587         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4588         * version.in: Bump version to 8.3.50.DATE-git.
4589
4590 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4591
4592         * aix-thread.c (ptid_cmp): Remove unused variable.
4593         (get_signaled_thread): Likewise.
4594         (store_regs_user_thread): Likewise.
4595         (store_regs_kernel_thread): Likewise.
4596         (fetch_regs_kernel_thread): Remove shadowed variable.
4597
4598 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * features/riscv/32bit-cpu.xml: Add register numbers.
4601         * features/riscv/32bit-fpu.c: Regenerate.
4602         * features/riscv/32bit-fpu.xml: Add register numbers.
4603         * features/riscv/64bit-cpu.xml: Add register numbers.
4604         * features/riscv/64bit-fpu.c: Regenerate.
4605         * features/riscv/64bit-fpu.xml: Add register numbers.
4606
4607 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4608
4609         * NEWS: Mention two argument form of gdb.Value constructor.
4610         * python/py-value.c (convert_buffer_and_type_to_value): New
4611         function.
4612         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4613         Add support for handling an optional second argument.  Call
4614         convert_buffer_and_type_to_value as appropriate.
4615         * python/python-internal.h (Py_buffer_deleter): New struct.
4616         (Py_buffer_up): New typedef.
4617
4618 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4619
4620         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4621         instead of releasing ownership.
4622
4623 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4624
4625         * dwarf2read.c (open_and_init_dwp_file): Call
4626         elf_numsections instead of bfd_count_sections to initialize
4627         dwp_file->num_sections.
4628
4629 2019-02-25  Tom Tromey  <tromey@adacore.com>
4630
4631         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4632
4633 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4634
4635         * gcore.in: Add '--readnever' option when invoking GDB.
4636
4637 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4638
4639         * MAINTAINERS: Update my email address.
4640
4641 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4642
4643         * build-id.c (build_id_to_debug_bfd_1): New function.
4644         (build_id_to_debug_bfd): Look for separate debug file in
4645         sysroot.
4646
4647 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4648
4649         * gdbarch.sh: Update the copyright year range that is placed into
4650         generated files.
4651
4652 2019-02-22  Keith Seitz  <keiths@redhat.com>
4653
4654         PR symtab/23853
4655         * linespec.c (create_sals_line_offset): Search for the default
4656         symtab's filename instead of its fullname.
4657
4658 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4659
4660         * NEWS: Update style defaults.
4661
4662 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4663
4664         * main.c (captured_main_1): Disable styling in batch mode.
4665
4666 2019-02-20  Tom Tromey  <tom@tromey.com>
4667
4668         * symtab.c (symtab_symbol_info): Fix typos.
4669
4670 2019-02-20  Tom Tromey  <tromey@adacore.com>
4671
4672         * findcmd.c (_initialize_mem_search): Use upper case for
4673         metasyntactic variables.
4674
4675 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4676
4677         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4678         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4679
4680 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4681
4682         * top.h (source_file_name): Change to std::string.
4683         * top.c (source_file_name): Likewise.
4684         (command_line_input): Adjust.
4685         * cli/cli-script.c (script_from_file): Adjust.
4686
4687 2019-02-19  Tom Tromey  <tromey@adacore.com>
4688
4689         * ravenscar-thread.c
4690         (ravenscar_thread_target::update_thread_list): Don't call
4691         ada_build_task_list.
4692         * ada-lang.h (ada_build_task_list): Don't declare.
4693         * ada-tasks.c (struct ada_tasks_inferior_data)
4694         <task_list_valid_p>: Now bool.
4695         (read_known_tasks, ada_task_list_changed)
4696         (ada_tasks_invalidate_inferior_data): Update.
4697         (read_known_tasks_array): Return bool.
4698         (read_known_tasks_list): Likewise.
4699         (read_known_tasks): Return void.
4700         (ada_build_task_list): Now static.
4701
4702 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4703
4704         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4705         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4706
4707 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4708
4709         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4710         variant for ada_tasks_pspace_data_handle and
4711         ada_tasks_inferior_data_handle.
4712         (ada_tasks_pspace_data_cleanup): New function.
4713         (ada_tasks_inferior_data_cleanup): New function.
4714
4715 2019-02-17  Tom Tromey  <tom@tromey.com>
4716
4717         * macrotab.h (macro_source_fullname): Return a std::string.
4718         * macrotab.c (macro_include, check_for_redefinition)
4719         (macro_undef, macro_lookup_definition, foreach_macro)
4720         (foreach_macro_in_scope): Update.
4721         (macro_source_fullname): Return a std::string.
4722         * macrocmd.c (show_pp_source_pos): Update.
4723
4724 2019-02-17  Tom Tromey  <tom@tromey.com>
4725
4726         * macrocmd.c (show_pp_source_pos): Style the file names.
4727
4728 2019-02-17  Tom Tromey  <tom@tromey.com>
4729
4730         PR tui/24197:
4731         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4732
4733 2019-02-17  Tom Tromey  <tom@tromey.com>
4734
4735         * ada-lang.c (user_select_syms): Use filtered printing.
4736         * utils.c (wrap_style): New global.
4737         (desired_style): Remove.
4738         (emit_style_escape): Add stream parameter.
4739         (set_output_style, reset_terminal_style, prompt_for_continue):
4740         Update.
4741         (flush_wrap_buffer): Only flush gdb_stdout.
4742         (wrap_here): Set wrap_style.
4743         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4744         treat escape sequences as a character.  Change when wrap buffer is
4745         flushed.
4746         (fputs_styled): Do not set the output style when the default is
4747         requested.
4748         * ui-style.h (struct ui_file_style) <is_default>: New method.
4749         * source.c (print_source_lines_base): Emit escape sequences in one
4750         piece.
4751
4752 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4753
4754         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4755         integers and enumeration types.
4756
4757 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4758
4759         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4760         instead of lookup_symbol_in_language
4761         (do_exact_match): New function.
4762         (ada_get_symbol_name_matcher): Return do_exact_match when
4763         doing a verbatim match.
4764
4765 2019-02-15  Tom Tromey  <tromey@adacore.com>
4766
4767         * ravenscar-thread.c (ravenscar_thread_target::resume)
4768         (ravenscar_thread_target::wait): Special case wildcard requests.
4769
4770 2019-02-15  Tom Tromey  <tromey@adacore.com>
4771
4772         * ravenscar-thread.c (base_ptid): Remove.
4773         (struct ravenscar_thread_target) <close>: New method.
4774         <m_base_ptid>: New member.
4775         <update_inferior_ptid, active_task, task_is_currently_active,
4776         runtime_initialized>: Declare methods.
4777         <ravenscar_thread_target>: Add constructor.
4778         (ravenscar_thread_target::task_is_currently_active)
4779         (ravenscar_thread_target::update_inferior_ptid)
4780         (ravenscar_runtime_initialized): Rename.  Now methods.
4781         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4782         (ravenscar_thread_target::update_thread_list): Update.
4783         (ravenscar_thread_target::active_task): Now method.
4784         (ravenscar_thread_target::store_registers)
4785         (ravenscar_thread_target::prepare_to_store)
4786         (ravenscar_thread_target::prepare_to_store)
4787         (ravenscar_thread_target::mourn_inferior): Update.
4788         (ravenscar_inferior_created): Use "new" to create target.
4789         (ravenscar_thread_target::get_ada_task_ptid): Update.
4790         (_initialize_ravenscar): Don't initialize base_ptid.
4791         (ravenscar_ops): Remove global.
4792
4793 2019-02-15  Tom Tromey  <tromey@adacore.com>
4794
4795         * target.h (push_target): Declare new overload.
4796         * target.c (push_target): New overload, taking an rvalue reference.
4797         * remote.c (remote_target::open_1): Use push_target overload.
4798         * corelow.c (core_target_open): Use push_target overload.
4799
4800 2019-02-15  Tom Tromey  <tromey@adacore.com>
4801
4802         * ravenscar-thread.c (is_ravenscar_task)
4803         (ravenscar_task_is_currently_active): Return bool.
4804         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4805         (_initialize_ravenscar): Remove "(void)".
4806         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4807         Return bool.
4808
4809 2019-02-15  Tom Tromey  <tromey@adacore.com>
4810
4811         * ravenscar-thread.c (ravenscar_runtime_initializer)
4812         (has_ravenscar_runtime, get_running_thread_id)
4813         (ravenscar_thread_target::resume): Fix indentation.
4814
4815 2019-02-15  Tom Tromey  <tromey@adacore.com>
4816
4817         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4818         from ravenscar_arch_ops.
4819         (sparc_ravenscar_ops::fetch_registers)
4820         (sparc_ravenscar_ops::store_registers): Now methods.
4821         (sparc_ravenscar_prepare_to_store): Remove.
4822         (sparc_ravenscar_ops): Redefine.
4823         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4824         methods and destructor.  Remove members.
4825         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4826         (ravenscar_thread_target::store_registers)
4827         (ravenscar_thread_target::prepare_to_store): Update.
4828         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4829         Remove.
4830         (struct ppc_ravenscar_powerpc_ops): Derive from
4831         ravenscar_arch_ops.
4832         (ppc_ravenscar_powerpc_ops::fetch_registers)
4833         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4834         (ppc_ravenscar_powerpc_ops): Redefine.
4835         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4836         (ppc_ravenscar_e500_ops::fetch_registers)
4837         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4838         (ppc_ravenscar_e500_ops): Redefine.
4839         * aarch64-ravenscar-thread.c
4840         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4841         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4842         (aarch64_ravenscar_fetch_registers)
4843         (aarch64_ravenscar_store_registers): Now methods.
4844         (aarch64_ravenscar_ops): Redefine.
4845
4846 2019-02-15  Tom Tromey  <tromey@adacore.com>
4847
4848         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4849         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4850         (ravenscar_thread_target::stopped_by_watchpoint)
4851         (ravenscar_thread_target::stopped_data_address)
4852         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4853
4854 2019-02-15  Tom Tromey  <tromey@adacore.com>
4855
4856         * ravenscar-thread.c: Fix some typos.
4857
4858 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4859             Tom Tromey  <tromey@adacore.com>
4860
4861         * ada-lang.c (ada_exception_sal): Change addr_string to a
4862         std::string.
4863         (create_ada_exception_catchpoint): Update.
4864
4865 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4866             Tom Tromey  <tromey@adacore.com>
4867
4868         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4869         (bp_location_ops): Remove.
4870         (base_breakpoint_allocate_location): Update.
4871         (free_bp_location): Update.
4872         * ada-lang.c (class ada_catchpoint_location)
4873         <ada_catchpoint_location>: Remove ops parameter.
4874         (ada_catchpoint_location_dtor): Remove.
4875         (ada_catchpoint_location_ops): Remove.
4876         (allocate_location_exception): Update.
4877         * breakpoint.h (struct bp_location_ops): Remove.
4878         (class bp_location) <bp_location>: Remove bp_location_ops
4879         parameter.
4880         <~bp_location>: Add destructor.
4881         <ops>: Remove.
4882
4883 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4884             Pedro Alves  <palves@redhat.com>
4885
4886         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4887         'PATH_MAX'.
4888
4889 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4890             Samuel Thibault  <samuel.thibault@gnu.org>
4891             Thomas Schwinge  <thomas@codesourcery.com>
4892
4893         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4894         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4895
4896 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4897
4898         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4899         (check_empty): Use "const char *".
4900
4901         * gnu-nat.c (gnu_nat_target::detach): Instead of
4902         'detach_inferior (pid)' call
4903         'detach_inferior (find_inferior_pid (pid))'.
4904
4905         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4906         'nat/fork-inferior.o'.
4907         * gnu-nat.c: #include "nat/fork-inferior.h".
4908
4909         * gnu-nat.c (gnu_nat_target::detach): Instead of
4910         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4911         * gnu-nat.h: #include "inf-child.h".
4912         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4913         'i386_gnu_nat_target::fetch_registers'.
4914         (gnu_store_registers): Rename/move to
4915         'i386_gnu_nat_target::store_registers'.
4916
4917         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4918         * gnu-nat.h (mach_thread_info): New function.
4919         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4920
4921         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4922
4923 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4924
4925         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4926
4927 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4928
4929         * windows-nat.c (windows_add_thread): Add new parameter
4930         "main_thread_p" with default value set to false.  Update
4931         function documentation as well as all callers.
4932         (windows_delete_thread): Likewise.
4933         (fake_create_process): Update call to windows_add_thread.
4934         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4935         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4936         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4937         call to windows_delete_thread.
4938
4939 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4940
4941         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4942
4943 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4944
4945         * symfile.c (find_separate_debug_file): Use canonical path of
4946         sysroot with child_path instead of gdb_sysroot if it is valid.
4947
4948 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4949
4950         * symfile.c (find_separate_debug_file): Use child_path to
4951         determine if an object file is under a sysroot.
4952
4953 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4954
4955         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4956         unittests/child-path-selftests.c.
4957         * common/pathstuff.c (child_path): New function.
4958         * common/pathstuff.h (child_path): New prototype.
4959         * unittests/child-path-selftests.c: New file.
4960
4961 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4962
4963         * symfile.c (find_separate_debug_file): Look for separate debug
4964         files in debug directories under the sysroot.
4965
4966 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4967
4968         * symtab.h (struct minimal_symbol data_p): New const method.
4969         (struct minimal_symbol text_p): Likewise.
4970         * symtab.c (output_source_filename): Use file name style
4971         to print file name.
4972         (print_symbol_info): Likewise.
4973         (print_msymbol_info): Use address style to print addresses.
4974         Use function name style to print executable text symbols.
4975         (expand_symtab_containing_pc): Use data_p.
4976         (find_pc_sect_compunit_symtab): Likewise.
4977
4978 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4979
4980         * breakpoint.c (describe_other_breakpoints): Use address style
4981         to print addresses.
4982         (say_where): Likewise.
4983
4984 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4985
4986         * ada-typeprint.c (print_func_type): Print function name
4987         style to print function name.
4988         * c-typeprint.c (c_print_type_1): Likewise.
4989
4990 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4991
4992         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4993         for execve.
4994
4995 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4996
4997         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4998         type_stack.
4999
5000 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5001
5002         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5003         TYPE_CODE_REF types.
5004
5005 2019-02-08  Jim Wilson  <jimw@sifive.com>
5006
5007         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5008         (riscv_linux_fregset): New.
5009         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5010
5011 2019-02-07  Tom Tromey  <tom@tromey.com>
5012
5013         * thread.c (thread_cancel_execution_command): Update.
5014         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5015         methods.
5016         (struct thread_fsm_ops): Remove.
5017         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5018         (thread_fsm_should_stop, thread_fsm_return_value)
5019         (thread_fsm_set_finished, thread_fsm_finished_p)
5020         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5021         Don't declare.
5022         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5023         * infrun.c (clear_proceed_status_thread)
5024         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5025         (print_stop_event): Update.
5026         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5027         Add constructor.
5028         (step_command_fsm_ops): Remove.
5029         (new_step_command_fsm): Remove.
5030         (step_1): Update.
5031         (step_command_fsm::should_stop): Rename from
5032         step_command_fsm_should_stop.
5033         (step_command_fsm::clean_up): Rename from
5034         step_command_fsm_clean_up.
5035         (step_command_fsm::do_async_reply_reason): Rename from
5036         step_command_fsm_async_reply_reason.
5037         (struct until_next_fsm): Inherit from thread_fsm.  Add
5038         constructor.
5039         (until_next_fsm_ops): Remove.
5040         (new_until_next_fsm): Remove.
5041         (until_next_fsm::should_stop): Rename from
5042         until_next_fsm_should_stop.
5043         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5044         (until_next_fsm::do_async_reply_reason): Rename from
5045         until_next_fsm_async_reply_reason.
5046         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5047         constructor.  Change type of breakpoint.
5048         (finish_command_fsm_ops): Remove.
5049         (new_finish_command_fsm): Remove.
5050         (finish_command_fsm::should_stop): Rename from
5051         finish_command_fsm_should_stop.
5052         (finish_command_fsm::clean_up): Rename from
5053         finish_command_fsm_clean_up.
5054         (finish_command_fsm::return_value): Rename from
5055         finish_command_fsm_return_value.
5056         (finish_command_fsm::do_async_reply_reason): Rename from
5057         finish_command_fsm_async_reply_reason.
5058         (finish_command): Update.
5059         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5060         Add constructor.
5061         (call_thread_fsm_ops): Remove.
5062         (call_thread_fsm::call_thread_fsm): Rename from
5063         new_call_thread_fsm.
5064         (call_thread_fsm::should_stop): Rename from
5065         call_thread_fsm_should_stop.
5066         (call_thread_fsm::should_notify_stop): Rename from
5067         call_thread_fsm_should_notify_stop.
5068         (run_inferior_call, call_function_by_hand_dummy): Update.
5069         * cli/cli-interp.c (should_print_stop_to_console): Update.
5070         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5071         Add constructor.  Change type of location_breakpoint,
5072         caller_breakpoint.
5073         (until_break_fsm_ops): Remove.
5074         (new_until_break_fsm): Remove.
5075         (until_break_fsm::should_stop): Rename from
5076         until_break_fsm_should_stop.
5077         (until_break_fsm::clean_up): Rename from
5078         until_break_fsm_clean_up.
5079         (until_break_fsm::do_async_reply_reason): Rename from
5080         until_break_fsm_async_reply_reason.
5081         (until_break_command): Update.
5082         * thread-fsm.c: Remove.
5083         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5084
5085 2019-02-07  Tom Tromey  <tom@tromey.com>
5086
5087         * yy-remap.h: Add include guard.
5088         * xtensa-tdep.h: Add include guard.
5089         * xcoffread.h: Rename include guard.
5090         * varobj-iter.h: Add include guard.
5091         * tui/tui.h: Rename include guard.
5092         * tui/tui-winsource.h: Rename include guard.
5093         * tui/tui-wingeneral.h: Rename include guard.
5094         * tui/tui-windata.h: Rename include guard.
5095         * tui/tui-win.h: Rename include guard.
5096         * tui/tui-stack.h: Rename include guard.
5097         * tui/tui-source.h: Rename include guard.
5098         * tui/tui-regs.h: Rename include guard.
5099         * tui/tui-out.h: Rename include guard.
5100         * tui/tui-layout.h: Rename include guard.
5101         * tui/tui-io.h: Rename include guard.
5102         * tui/tui-hooks.h: Rename include guard.
5103         * tui/tui-file.h: Rename include guard.
5104         * tui/tui-disasm.h: Rename include guard.
5105         * tui/tui-data.h: Rename include guard.
5106         * tui/tui-command.h: Rename include guard.
5107         * tic6x-tdep.h: Add include guard.
5108         * target/waitstatus.h: Rename include guard.
5109         * target/wait.h: Rename include guard.
5110         * target/target.h: Rename include guard.
5111         * target/resume.h: Rename include guard.
5112         * target-float.h: Rename include guard.
5113         * stabsread.h: Add include guard.
5114         * rs6000-tdep.h: Add include guard.
5115         * riscv-fbsd-tdep.h: Add include guard.
5116         * regformats/regdef.h: Rename include guard.
5117         * record.h: Rename include guard.
5118         * python/python.h: Rename include guard.
5119         * python/python-internal.h: Rename include guard.
5120         * python/py-stopevent.h: Rename include guard.
5121         * python/py-ref.h: Rename include guard.
5122         * python/py-record.h: Rename include guard.
5123         * python/py-record-full.h: Rename include guard.
5124         * python/py-record-btrace.h: Rename include guard.
5125         * python/py-instruction.h: Rename include guard.
5126         * python/py-events.h: Rename include guard.
5127         * python/py-event.h: Rename include guard.
5128         * procfs.h: Add include guard.
5129         * proc-utils.h: Add include guard.
5130         * p-lang.h: Add include guard.
5131         * or1k-tdep.h: Rename include guard.
5132         * observable.h: Rename include guard.
5133         * nto-tdep.h: Rename include guard.
5134         * nat/x86-linux.h: Rename include guard.
5135         * nat/x86-linux-dregs.h: Rename include guard.
5136         * nat/x86-gcc-cpuid.h: Add include guard.
5137         * nat/x86-dregs.h: Rename include guard.
5138         * nat/x86-cpuid.h: Rename include guard.
5139         * nat/ppc-linux.h: Rename include guard.
5140         * nat/mips-linux-watch.h: Rename include guard.
5141         * nat/linux-waitpid.h: Rename include guard.
5142         * nat/linux-ptrace.h: Rename include guard.
5143         * nat/linux-procfs.h: Rename include guard.
5144         * nat/linux-osdata.h: Rename include guard.
5145         * nat/linux-nat.h: Rename include guard.
5146         * nat/linux-namespaces.h: Rename include guard.
5147         * nat/linux-btrace.h: Rename include guard.
5148         * nat/glibc_thread_db.h: Rename include guard.
5149         * nat/gdb_thread_db.h: Rename include guard.
5150         * nat/gdb_ptrace.h: Rename include guard.
5151         * nat/fork-inferior.h: Rename include guard.
5152         * nat/amd64-linux-siginfo.h: Rename include guard.
5153         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5154         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5155         * nat/aarch64-linux.h: Rename include guard.
5156         * nat/aarch64-linux-hw-point.h: Rename include guard.
5157         * mn10300-tdep.h: Add include guard.
5158         * mips-linux-tdep.h: Add include guard.
5159         * mi/mi-parse.h: Rename include guard.
5160         * mi/mi-out.h: Rename include guard.
5161         * mi/mi-main.h: Rename include guard.
5162         * mi/mi-interp.h: Rename include guard.
5163         * mi/mi-getopt.h: Rename include guard.
5164         * mi/mi-console.h: Rename include guard.
5165         * mi/mi-common.h: Rename include guard.
5166         * mi/mi-cmds.h: Rename include guard.
5167         * mi/mi-cmd-break.h: Rename include guard.
5168         * m2-lang.h: Add include guard.
5169         * location.h: Rename include guard.
5170         * linux-record.h: Rename include guard.
5171         * linux-nat.h: Add include guard.
5172         * linux-fork.h: Add include guard.
5173         * i386-darwin-tdep.h: Rename include guard.
5174         * hppa-linux-offsets.h: Add include guard.
5175         * guile/guile.h: Rename include guard.
5176         * guile/guile-internal.h: Rename include guard.
5177         * gnu-nat.h: Rename include guard.
5178         * gdb-stabs.h: Rename include guard.
5179         * frv-tdep.h: Add include guard.
5180         * f-lang.h: Add include guard.
5181         * event-loop.h: Add include guard.
5182         * darwin-nat.h: Rename include guard.
5183         * cp-abi.h: Rename include guard.
5184         * config/sparc/nm-sol2.h: Rename include guard.
5185         * config/nm-nto.h: Rename include guard.
5186         * config/nm-linux.h: Add include guard.
5187         * config/i386/nm-i386gnu.h: Rename include guard.
5188         * config/djgpp/nl_types.h: Rename include guard.
5189         * config/djgpp/langinfo.h: Rename include guard.
5190         * compile/gcc-cp-plugin.h: Add include guard.
5191         * compile/gcc-c-plugin.h: Add include guard.
5192         * compile/compile.h: Rename include guard.
5193         * compile/compile-object-run.h: Rename include guard.
5194         * compile/compile-object-load.h: Rename include guard.
5195         * compile/compile-internal.h: Rename include guard.
5196         * compile/compile-cplus.h: Rename include guard.
5197         * compile/compile-c.h: Rename include guard.
5198         * common/xml-utils.h: Rename include guard.
5199         * common/x86-xstate.h: Rename include guard.
5200         * common/version.h: Rename include guard.
5201         * common/vec.h: Rename include guard.
5202         * common/tdesc.h: Rename include guard.
5203         * common/selftest.h: Rename include guard.
5204         * common/scoped_restore.h: Rename include guard.
5205         * common/scoped_mmap.h: Rename include guard.
5206         * common/scoped_fd.h: Rename include guard.
5207         * common/safe-iterator.h: Rename include guard.
5208         * common/run-time-clock.h: Rename include guard.
5209         * common/refcounted-object.h: Rename include guard.
5210         * common/queue.h: Rename include guard.
5211         * common/ptid.h: Rename include guard.
5212         * common/print-utils.h: Rename include guard.
5213         * common/preprocessor.h: Rename include guard.
5214         * common/pathstuff.h: Rename include guard.
5215         * common/observable.h: Rename include guard.
5216         * common/netstuff.h: Rename include guard.
5217         * common/job-control.h: Rename include guard.
5218         * common/host-defs.h: Rename include guard.
5219         * common/gdb_wait.h: Rename include guard.
5220         * common/gdb_vecs.h: Rename include guard.
5221         * common/gdb_unlinker.h: Rename include guard.
5222         * common/gdb_unique_ptr.h: Rename include guard.
5223         * common/gdb_tilde_expand.h: Rename include guard.
5224         * common/gdb_sys_time.h: Rename include guard.
5225         * common/gdb_string_view.h: Rename include guard.
5226         * common/gdb_splay_tree.h: Rename include guard.
5227         * common/gdb_setjmp.h: Rename include guard.
5228         * common/gdb_ref_ptr.h: Rename include guard.
5229         * common/gdb_optional.h: Rename include guard.
5230         * common/gdb_locale.h: Rename include guard.
5231         * common/gdb_assert.h: Rename include guard.
5232         * common/filtered-iterator.h: Rename include guard.
5233         * common/filestuff.h: Rename include guard.
5234         * common/fileio.h: Rename include guard.
5235         * common/environ.h: Rename include guard.
5236         * common/common-utils.h: Rename include guard.
5237         * common/common-types.h: Rename include guard.
5238         * common/common-regcache.h: Rename include guard.
5239         * common/common-inferior.h: Rename include guard.
5240         * common/common-gdbthread.h: Rename include guard.
5241         * common/common-exceptions.h: Rename include guard.
5242         * common/common-defs.h: Rename include guard.
5243         * common/common-debug.h: Rename include guard.
5244         * common/cleanups.h: Rename include guard.
5245         * common/buffer.h: Rename include guard.
5246         * common/btrace-common.h: Rename include guard.
5247         * common/break-common.h: Rename include guard.
5248         * cli/cli-utils.h: Rename include guard.
5249         * cli/cli-style.h: Rename include guard.
5250         * cli/cli-setshow.h: Rename include guard.
5251         * cli/cli-script.h: Rename include guard.
5252         * cli/cli-interp.h: Rename include guard.
5253         * cli/cli-decode.h: Rename include guard.
5254         * cli/cli-cmds.h: Rename include guard.
5255         * charset-list.h: Add include guard.
5256         * buildsym-legacy.h: Rename include guard.
5257         * bfin-tdep.h: Add include guard.
5258         * ax.h: Rename include guard.
5259         * arm-linux-tdep.h: Add include guard.
5260         * arm-fbsd-tdep.h: Add include guard.
5261         * arch/xtensa.h: Rename include guard.
5262         * arch/tic6x.h: Add include guard.
5263         * arch/i386.h: Add include guard.
5264         * arch/arm.h: Rename include guard.
5265         * arch/arm-linux.h: Rename include guard.
5266         * arch/arm-get-next-pcs.h: Rename include guard.
5267         * arch/amd64.h: Add include guard.
5268         * arch/aarch64-insn.h: Rename include guard.
5269         * arch-utils.h: Rename include guard.
5270         * annotate.h: Add include guard.
5271         * amd64-darwin-tdep.h: Rename include guard.
5272         * aarch64-linux-tdep.h: Add include guard.
5273         * aarch64-fbsd-tdep.h: Add include guard.
5274         * aarch32-linux-nat.h: Add include guard.
5275
5276 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5277
5278         * macrotab.c (macro_define_internal): New function that
5279         factorizes macro_define_object_internal and macro_define_function
5280         code.
5281         (macro_define_object_internal): Use macro_define_internal.
5282         (macro_define_function): Likewise.
5283
5284 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5285
5286         * macrocmd.c (extract_identifier): Return
5287         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5288         callers.
5289
5290 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5291
5292         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5293
5294 2019-02-05  Tom Tromey  <tom@tromey.com>
5295
5296         * target.c (target_stack::unpush): Move assertion earlier.
5297
5298 2019-01-30  Tom Tromey  <tom@tromey.com>
5299
5300         PR python/23615:
5301         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5302         (gdbpy_parse_and_eval): Likewise.
5303         * python/python-internal.h (gdbpy_allow_threads): New class.
5304
5305 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5306
5307         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5308         (aarch64_fbsd_fpregmap): Move earlier.
5309         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5310         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5311         instead of individual calls to trad_frame_set_reg_addr.
5312         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5313         earlier.
5314         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5315         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5316         instead of individual calls to trad_frame_set_reg_addr.
5317
5318 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5319
5320         * CONTRIBUTE: Replace contribution list with wiki link.
5321
5322 2019-01-25  Tom Tromey  <tom@tromey.com>
5323
5324         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5325
5326 2019-01-25  Tom Tromey  <tom@tromey.com>
5327
5328         * xtensa-linux-nat.c: Fix common/ includes.
5329         * xml-support.h: Fix common/ includes.
5330         * xml-support.c: Fix common/ includes.
5331         * x86-linux-nat.c: Fix common/ includes.
5332         * windows-nat.c: Fix common/ includes.
5333         * varobj.h: Fix common/ includes.
5334         * varobj.c: Fix common/ includes.
5335         * value.c: Fix common/ includes.
5336         * valops.c: Fix common/ includes.
5337         * utils.c: Fix common/ includes.
5338         * unittests/xml-utils-selftests.c: Fix common/ includes.
5339         * unittests/utils-selftests.c: Fix common/ includes.
5340         * unittests/unpack-selftests.c: Fix common/ includes.
5341         * unittests/tracepoint-selftests.c: Fix common/ includes.
5342         * unittests/style-selftests.c: Fix common/ includes.
5343         * unittests/string_view-selftests.c: Fix common/ includes.
5344         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5345         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5346         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5347         * unittests/rsp-low-selftests.c: Fix common/ includes.
5348         * unittests/parse-connection-spec-selftests.c: Fix common/
5349         includes.
5350         * unittests/optional-selftests.c: Fix common/ includes.
5351         * unittests/offset-type-selftests.c: Fix common/ includes.
5352         * unittests/observable-selftests.c: Fix common/ includes.
5353         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5354         * unittests/memrange-selftests.c: Fix common/ includes.
5355         * unittests/memory-map-selftests.c: Fix common/ includes.
5356         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5357         * unittests/function-view-selftests.c: Fix common/ includes.
5358         * unittests/environ-selftests.c: Fix common/ includes.
5359         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5360         * unittests/common-utils-selftests.c: Fix common/ includes.
5361         * unittests/cli-utils-selftests.c: Fix common/ includes.
5362         * unittests/array-view-selftests.c: Fix common/ includes.
5363         * ui-file.c: Fix common/ includes.
5364         * tui/tui-io.c: Fix common/ includes.
5365         * tracepoint.h: Fix common/ includes.
5366         * tracepoint.c: Fix common/ includes.
5367         * tracefile-tfile.c: Fix common/ includes.
5368         * top.h: Fix common/ includes.
5369         * top.c: Fix common/ includes.
5370         * thread.c: Fix common/ includes.
5371         * target/waitstatus.h: Fix common/ includes.
5372         * target/waitstatus.c: Fix common/ includes.
5373         * target.h: Fix common/ includes.
5374         * target.c: Fix common/ includes.
5375         * target-memory.c: Fix common/ includes.
5376         * target-descriptions.c: Fix common/ includes.
5377         * symtab.h: Fix common/ includes.
5378         * symfile.c: Fix common/ includes.
5379         * stap-probe.c: Fix common/ includes.
5380         * spu-linux-nat.c: Fix common/ includes.
5381         * sparc-nat.c: Fix common/ includes.
5382         * source.c: Fix common/ includes.
5383         * solib.c: Fix common/ includes.
5384         * solib-target.c: Fix common/ includes.
5385         * ser-unix.c: Fix common/ includes.
5386         * ser-tcp.c: Fix common/ includes.
5387         * ser-pipe.c: Fix common/ includes.
5388         * ser-base.c: Fix common/ includes.
5389         * selftest-arch.c: Fix common/ includes.
5390         * s12z-tdep.c: Fix common/ includes.
5391         * rust-exp.y: Fix common/ includes.
5392         * rs6000-aix-tdep.c: Fix common/ includes.
5393         * riscv-tdep.c: Fix common/ includes.
5394         * remote.c: Fix common/ includes.
5395         * remote-notif.h: Fix common/ includes.
5396         * remote-fileio.h: Fix common/ includes.
5397         * remote-fileio.c: Fix common/ includes.
5398         * regcache.h: Fix common/ includes.
5399         * regcache.c: Fix common/ includes.
5400         * record-btrace.c: Fix common/ includes.
5401         * python/python.c: Fix common/ includes.
5402         * python/py-type.c: Fix common/ includes.
5403         * python/py-inferior.c: Fix common/ includes.
5404         * progspace.h: Fix common/ includes.
5405         * producer.c: Fix common/ includes.
5406         * procfs.c: Fix common/ includes.
5407         * proc-api.c: Fix common/ includes.
5408         * printcmd.c: Fix common/ includes.
5409         * ppc-linux-nat.c: Fix common/ includes.
5410         * parser-defs.h: Fix common/ includes.
5411         * osdata.c: Fix common/ includes.
5412         * obsd-nat.c: Fix common/ includes.
5413         * nat/x86-linux.c: Fix common/ includes.
5414         * nat/x86-linux-dregs.c: Fix common/ includes.
5415         * nat/x86-dregs.h: Fix common/ includes.
5416         * nat/x86-dregs.c: Fix common/ includes.
5417         * nat/ppc-linux.c: Fix common/ includes.
5418         * nat/mips-linux-watch.h: Fix common/ includes.
5419         * nat/mips-linux-watch.c: Fix common/ includes.
5420         * nat/linux-waitpid.c: Fix common/ includes.
5421         * nat/linux-ptrace.h: Fix common/ includes.
5422         * nat/linux-ptrace.c: Fix common/ includes.
5423         * nat/linux-procfs.c: Fix common/ includes.
5424         * nat/linux-personality.c: Fix common/ includes.
5425         * nat/linux-osdata.c: Fix common/ includes.
5426         * nat/linux-namespaces.c: Fix common/ includes.
5427         * nat/linux-btrace.h: Fix common/ includes.
5428         * nat/linux-btrace.c: Fix common/ includes.
5429         * nat/fork-inferior.c: Fix common/ includes.
5430         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5431         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5432         * nat/aarch64-linux.c: Fix common/ includes.
5433         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5434         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5435         * namespace.h: Fix common/ includes.
5436         * mips-linux-tdep.c: Fix common/ includes.
5437         * minsyms.c: Fix common/ includes.
5438         * mi/mi-parse.h: Fix common/ includes.
5439         * mi/mi-main.c: Fix common/ includes.
5440         * mi/mi-cmd-env.c: Fix common/ includes.
5441         * memrange.h: Fix common/ includes.
5442         * memattr.c: Fix common/ includes.
5443         * maint.h: Fix common/ includes.
5444         * maint.c: Fix common/ includes.
5445         * main.c: Fix common/ includes.
5446         * machoread.c: Fix common/ includes.
5447         * location.c: Fix common/ includes.
5448         * linux-thread-db.c: Fix common/ includes.
5449         * linux-nat.c: Fix common/ includes.
5450         * linux-fork.c: Fix common/ includes.
5451         * inline-frame.c: Fix common/ includes.
5452         * infrun.c: Fix common/ includes.
5453         * inflow.c: Fix common/ includes.
5454         * inferior.h: Fix common/ includes.
5455         * inferior.c: Fix common/ includes.
5456         * infcmd.c: Fix common/ includes.
5457         * inf-ptrace.c: Fix common/ includes.
5458         * inf-child.c: Fix common/ includes.
5459         * ia64-linux-nat.c: Fix common/ includes.
5460         * i387-tdep.c: Fix common/ includes.
5461         * i386-tdep.c: Fix common/ includes.
5462         * i386-linux-tdep.c: Fix common/ includes.
5463         * i386-linux-nat.c: Fix common/ includes.
5464         * i386-go32-tdep.c: Fix common/ includes.
5465         * i386-fbsd-tdep.c: Fix common/ includes.
5466         * i386-fbsd-nat.c: Fix common/ includes.
5467         * guile/scm-type.c: Fix common/ includes.
5468         * guile/guile.c: Fix common/ includes.
5469         * go32-nat.c: Fix common/ includes.
5470         * gnu-nat.c: Fix common/ includes.
5471         * gdbthread.h: Fix common/ includes.
5472         * gdbarch-selftests.c: Fix common/ includes.
5473         * gdb_usleep.c: Fix common/ includes.
5474         * gdb_select.h: Fix common/ includes.
5475         * gdb_bfd.c: Fix common/ includes.
5476         * gcore.c: Fix common/ includes.
5477         * fork-child.c: Fix common/ includes.
5478         * findvar.c: Fix common/ includes.
5479         * fbsd-nat.c: Fix common/ includes.
5480         * event-top.c: Fix common/ includes.
5481         * event-loop.c: Fix common/ includes.
5482         * dwarf2read.c: Fix common/ includes.
5483         * dwarf2loc.c: Fix common/ includes.
5484         * dwarf2-frame.c: Fix common/ includes.
5485         * dwarf-index-cache.c: Fix common/ includes.
5486         * dtrace-probe.c: Fix common/ includes.
5487         * disasm-selftests.c: Fix common/ includes.
5488         * defs.h: Fix common/ includes.
5489         * csky-tdep.c: Fix common/ includes.
5490         * cp-valprint.c: Fix common/ includes.
5491         * cp-support.h: Fix common/ includes.
5492         * cp-support.c: Fix common/ includes.
5493         * corelow.c: Fix common/ includes.
5494         * completer.h: Fix common/ includes.
5495         * completer.c: Fix common/ includes.
5496         * compile/compile.c: Fix common/ includes.
5497         * compile/compile-loc2c.c: Fix common/ includes.
5498         * compile/compile-cplus-types.c: Fix common/ includes.
5499         * compile/compile-cplus-symbols.c: Fix common/ includes.
5500         * command.h: Fix common/ includes.
5501         * cli/cli-dump.c: Fix common/ includes.
5502         * cli/cli-cmds.c: Fix common/ includes.
5503         * charset.c: Fix common/ includes.
5504         * build-id.c: Fix common/ includes.
5505         * btrace.h: Fix common/ includes.
5506         * btrace.c: Fix common/ includes.
5507         * breakpoint.h: Fix common/ includes.
5508         * breakpoint.c: Fix common/ includes.
5509         * ax.h:
5510         (enum agent_op): Fix common/ includes.
5511         * ax-general.c (struct aop_map): Fix common/ includes.
5512         * ax-gdb.c: Fix common/ includes.
5513         * auxv.c: Fix common/ includes.
5514         * auto-load.c: Fix common/ includes.
5515         * arm-tdep.c: Fix common/ includes.
5516         * arch/riscv.c: Fix common/ includes.
5517         * arch/ppc-linux-common.c: Fix common/ includes.
5518         * arch/i386.c: Fix common/ includes.
5519         * arch/arm.c: Fix common/ includes.
5520         * arch/arm-linux.c: Fix common/ includes.
5521         * arch/arm-get-next-pcs.c: Fix common/ includes.
5522         * arch/amd64.c: Fix common/ includes.
5523         * arch/aarch64.c: Fix common/ includes.
5524         * arch/aarch64-insn.c: Fix common/ includes.
5525         * arch-utils.c: Fix common/ includes.
5526         * amd64-windows-tdep.c: Fix common/ includes.
5527         * amd64-tdep.c: Fix common/ includes.
5528         * amd64-sol2-tdep.c: Fix common/ includes.
5529         * amd64-obsd-tdep.c: Fix common/ includes.
5530         * amd64-nbsd-tdep.c: Fix common/ includes.
5531         * amd64-linux-tdep.c: Fix common/ includes.
5532         * amd64-linux-nat.c: Fix common/ includes.
5533         * amd64-fbsd-tdep.c: Fix common/ includes.
5534         * amd64-fbsd-nat.c: Fix common/ includes.
5535         * amd64-dicos-tdep.c: Fix common/ includes.
5536         * amd64-darwin-tdep.c: Fix common/ includes.
5537         * agent.c: Fix common/ includes.
5538         * ada-lang.h: Fix common/ includes.
5539         * ada-lang.c: Fix common/ includes.
5540         * aarch64-tdep.c: Fix common/ includes.
5541
5542 2019-01-25  Tom Tromey  <tom@tromey.com>
5543
5544         * common/create-version.sh: Use common/version.h.
5545
5546 2019-01-24  Pedro Alves  <palves@redhat.com>
5547
5548         * infrun.c (signal_stop, signal_print, signal_program)
5549         (signal_catch, signal_pass): Now arrays instead of pointers.
5550         (update_signals_program_target, do_target_resume)
5551         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5552         * linux-nat.c (linux_nat_target::pass_signals)
5553         (linux_nat_target::create_inferior, linux_nat_target::attach):
5554         Adjust.
5555         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5556         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5557         * procfs.c (procfs_target::pass_signals): Adjust.
5558         * record-full.c (record_full_target::resume): Adjust.
5559         * remote.c (remote_target::pass_signals)
5560         (remote_target::program_signals): Adjust.
5561         * target-debug.h (target_debug_print_signals): Now takes a
5562         gdb::array_view as parameter.  Adjust.
5563         * target.h (target_ops) <pass_signals, program_signals>: Replace
5564         pointer and length parameters with gdb::array_view.
5565         (target_pass_signals, target_program_signals): Likewise.
5566         * target-delegates.c: Regenerate.
5567
5568 2019-01-24  Pedro Alves  <palves@redhat.com>
5569
5570         * common/forward-scope-exit.h
5571         (forward_scope_exit::forward_scope_exit): Pass arguments to
5572         m_bind_function directly, instead of creating a std::bind and
5573         copying that.
5574
5575 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5576
5577         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5578         for static members.
5579         (pass_in_v_vfp_candidate): Likewise.
5580
5581 2019-01-23  Tom Tromey  <tom@tromey.com>
5582             Pedro Alves  <palves@redhat.com>
5583
5584         * regcache.c (class regcache_invalidator): Remove.
5585         (regcache::raw_write): Use make_scope_exit.
5586
5587 2019-01-23  Tom Tromey  <tom@tromey.com>
5588
5589         * ui-out.h (class ui_out_emit_type): Update comment.
5590
5591 2019-01-23  Tom Tromey  <tom@tromey.com>
5592
5593         * infrun.c (fetch_inferior_event): Update comment.
5594
5595 2019-01-23  Tom Tromey  <tom@tromey.com>
5596             Pedro Alves  <palves@redhat.com>
5597
5598         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5599         parameter.
5600         (fetch_inferior_event): Use SCOPE_EXIT.
5601
5602
5603 2019-01-23  Tom Tromey  <tom@tromey.com>
5604             Pedro Alves  <palves@redhat.com>
5605
5606         * infrun.c (disable_thread_events): Delete.
5607         (stop_all_threads): Use SCOPE_EXIT.
5608
5609 2019-01-23  Tom Tromey  <tom@tromey.com>
5610             Pedro Alves  <palves@redhat.com>
5611
5612         * symfile.c: Include forward-scope-exit.h.
5613         (clear_symtab_users_cleanup): Replace forward declaration with
5614         a FORWARD_SCOPE_EXIT.
5615         (syms_from_objfile_1): Use the forward_scope_exit and
5616         gdb::optional instead of cleanup_function.
5617         (reread_symbols): Use the forward_scope_exit instead of
5618         cleanup_function.
5619         (clear_symtab_users_cleanup): Remove function.
5620
5621 2019-01-23  Tom Tromey  <tom@tromey.com>
5622             Pedro Alves  <palves@redhat.com>
5623
5624         * linux-nat.c: Include scope-exit.h.
5625         (cleanup_target_stop): Remove.
5626         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5627         SCOPE_EXIT.
5628
5629 2019-01-23  Tom Tromey  <tom@tromey.com>
5630             Pedro Alves  <palves@redhat.com>
5631
5632         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5633         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5634
5635 2019-01-23  Tom Tromey  <tom@tromey.com>
5636             Andrew Burgess  <andrew.burgess@embecosm.com>
5637             Pedro Alves  <palves@redhat.com>
5638
5639         * infrun.c (fetch_inferior_event): Use scope_exit.
5640         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5641         * top.c (execute_command): Use scope_exit.
5642         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5643         * utils.c (do_bpstat_clear_actions_cleanup)
5644         (make_bpstat_clear_actions_cleanup): Remove.
5645
5646 2019-01-23  Tom Tromey  <tom@tromey.com>
5647             Pedro Alves  <palves@redhat.com>
5648
5649         * infrun.c: Include "common/scope-exit.h"
5650         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5651         (wait_for_inferior): Use SCOPE_EXIT.
5652         (fetch_inferior_event): Use scope_exit.
5653
5654 2019-01-23  Tom Tromey  <tom@tromey.com>
5655             Pedro Alves  <palves@redhat.com>
5656
5657         * breakpoint.c (create_breakpoint): Remove cleanup.
5658
5659 2019-01-23  Tom Tromey  <tom@tromey.com>
5660             Andrew Burgess  <andrew.burgess@embecosm.com>
5661             Pedro Alves  <palves@redhat.com>
5662
5663 2019-01-23  Pedro Alves  <palves@redhat.com>
5664
5665         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5666
5667 2019-01-23  Pedro Alves  <palves@redhat.com>
5668             Andrew Burgess  <andrew.burgess@embecosm.com>
5669
5670         * gdbthread.h: Include "common/forward-scope-exit.h".
5671         (scoped_finish_thread_state): Redefine custom class in terms of
5672         forward_scope_exit.
5673
5674 2019-01-23  Pedro Alves  <palves@redhat.com>
5675             Andrew Burgess  <andrew.burgess@embecosm.com>
5676
5677         * common/forward-scope-exit.h: New file.
5678
5679 2019-01-23  Pedro Alves  <palves@redhat.com>
5680             Andrew Burgess  <andrew.burgess@embecosm.com>
5681             Tom Tromey  <tom@tromey.com>
5682
5683         * common/scope-exit.h: New file.
5684
5685 2019-01-23  Pedro Alves  <palves@redhat.com>
5686
5687         * common/preprocessor.h (ESC): Rename to ...
5688         (ESC_PARENS): ... this.
5689         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5690         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5691
5692 2019-01-23  Tom Tromey  <tom@tromey.com>
5693
5694         * language.h (class scoped_switch_to_sym_language_if_auto):
5695         Initialize m_lang in both cases.
5696
5697 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5698
5699         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5700         with XCNEW.
5701
5702 2019-01-22  Tom Tromey  <tom@tromey.com>
5703
5704         * corelow.c: Do not include sys/file.h.
5705
5706 2019-01-22  Tom Tromey  <tom@tromey.com>
5707
5708         * tui/tui-wingeneral.h: Include gdb_curses.h.
5709
5710 2019-01-22  Tom Tromey  <tom@tromey.com>
5711
5712         * source-cache.h (class source_cache) <get_source_lines,
5713         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5714
5715 2019-01-22  Tom Tromey  <tom@tromey.com>
5716
5717         * remote-fileio.h (struct remote_target): Declare.
5718
5719 2019-01-22  Tom Tromey  <tom@tromey.com>
5720
5721         * python/py-arch.c: Do not include py-ref.h.
5722         * python/py-bpevent.c: Do not include py-ref.h.
5723         * python/py-cmd.c: Do not include py-ref.h.
5724         * python/py-continueevent.c: Do not include py-ref.h.
5725         * python/py-event.h: Do not include py-ref.h.
5726         * python/py-evtregistry.c: Do not include py-ref.h.
5727         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5728         * python/py-frame.c: Do not include py-ref.h.
5729         * python/py-framefilter.c: Do not include py-ref.h.
5730         * python/py-function.c: Do not include py-ref.h.
5731         * python/py-infevents.c: Do not include py-ref.h.
5732         * python/py-linetable.c: Do not include py-ref.h.
5733         * python/py-objfile.c: Do not include py-ref.h.
5734         * python/py-param.c: Do not include py-ref.h.
5735         * python/py-prettyprint.c: Do not include py-ref.h.
5736         * python/py-progspace.c: Do not include py-ref.h.
5737         * python/py-symbol.c: Do not include py-ref.h.
5738         * python/py-symtab.c: Do not include py-ref.h.
5739         * python/py-type.c: Do not include py-ref.h.
5740         * python/py-unwind.c: Do not include py-ref.h.
5741         * python/py-utils.c: Do not include py-ref.h.
5742         * python/py-value.c: Do not include py-ref.h.
5743         * python/py-varobj.c: Do not include py-ref.h.
5744         * python/py-xmethods.c: Do not include py-ref.h.
5745         * python/python.c: Do not include py-ref.h.
5746         * varobj.c: Do not include py-ref.h.
5747
5748 2019-01-22  Tom Tromey  <tom@tromey.com>
5749
5750         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5751         keyword for bcache.
5752
5753 2019-01-22  Tom Tromey  <tom@tromey.com>
5754
5755         * compile/compile-cplus-types.c: Remove a comment by #include.
5756
5757 2019-01-22  Tom Tromey  <tom@tromey.com>
5758
5759         * compile/gcc-c-plugin.h: Include compile-internal.h.
5760
5761 2019-01-22  Tom Tromey  <tom@tromey.com>
5762
5763         * stabsread.c (EXTERN): Do not define.
5764         (symnum, next_symbol_text_func, processing_gcc_compilation)
5765         (within_function, global_sym_chain, global_stabs)
5766         (previous_stab_code, this_object_header_files)
5767         (n_this_object_header_files)
5768         (n_allocated_this_object_header_files): Define.
5769         * stabsread.h (EXTERN): Never define.  Use "extern".
5770
5771 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5772
5773         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5774         history_value.
5775
5776 2019-01-21  Tom Tromey  <tom@tromey.com>
5777
5778         * ui-out.c: Fix includes.
5779         * tui/tui-source.c: Fix includes.
5780         * target.c: Fix includes.
5781         * remote.c: Fix includes.
5782         * regcache.c: Fix includes.
5783         * python/py-block.c: Fix includes.
5784         * printcmd.c: Fix includes.
5785         * or1k-tdep.c: Fix includes.
5786         * mi/mi-main.c: Fix includes.
5787         * m32r-tdep.c: Fix includes.
5788         * csky-tdep.c: Fix includes.
5789         * compile/compile-cplus-types.c: Fix includes.
5790         * cli/cli-interp.c: Fix includes.
5791
5792 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5793
5794         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5795         for padding.
5796
5797 2019-01-16  Tom Tromey  <tom@tromey.com>
5798
5799         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5800         earlier.
5801         (struct objfile) <msymbols_range>: Move from top level.
5802         <msymbols>: New method.
5803         (class objfile_msymbols): Remove.
5804         * symtab.c (default_collect_symbol_completion_matches_break_on):
5805         Update.
5806         * symmisc.c (dump_msymbols): Update.
5807         * stabsread.c (scan_file_globals): Update.
5808         * objc-lang.c (info_selectors_command, info_classes_command)
5809         (find_methods): Update.
5810         * minsyms.c (find_solib_trampoline_target): Update.
5811         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5812         * coffread.c (coff_symfile_read): Update.
5813         * ada-lang.c (ada_lookup_simple_minsym)
5814         (ada_collect_symbol_completion_matches): Update.
5815
5816 2019-01-16  Tom Tromey  <tom@tromey.com>
5817
5818         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5819         type.  Remove no-argument constructor.
5820         <iterator::operator++>: Simplify.
5821         <begin>: Update.
5822         <end>: Use minimal_symbol_count.
5823
5824 2019-01-16  Tom Tromey  <tom@tromey.com>
5825
5826         * objfiles.h (struct objfile) <psymtabs>: New method.
5827         (class objfile_psymtabs): Remove.
5828         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5829         typedef.
5830         <range>: New method.
5831         (require_partial_symbols): Change return type.
5832         * psymtab.c (require_partial_symbols)
5833         (psym_expand_symtabs_matching): Update.
5834         * mdebugread.c (parse_partial_symbols): Update.
5835         * dbxread.c (dbx_end_psymtab): Update.
5836
5837 2019-01-15  Tom Tromey  <tom@tromey.com>
5838
5839         * symtab.c (lookup_objfile_from_block)
5840         (lookup_symbol_in_objfile_symtabs)
5841         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5842         (find_line_symtab, info_sources_command)
5843         (default_collect_symbol_completion_matches_break_on)
5844         (make_source_files_completion_list): Update.
5845         * symmisc.c (print_objfile_statistics, dump_objfile)
5846         (maintenance_print_symbols, maintenance_info_symtabs)
5847         (maintenance_check_symtabs, maintenance_info_line_tables):
5848         Update.
5849         * source.c (select_source_symtab)
5850         (forget_cached_source_info_for_objfile): Update.
5851         * objfiles.h (class objfile_compunits): Remove.
5852         (struct objfile) <compunits_range>: New typedef.
5853         (compunits): New method.
5854         * objfiles.c (objfile_relocate1): Update.
5855         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5856         * maint.c (count_symtabs_and_blocks): Update.
5857         * linespec.c (iterate_over_all_matching_symtabs): Update.
5858         * cp-support.c (add_symbol_overload_list_qualified): Update.
5859         * coffread.c (coff_symtab_read): Update.
5860         * ada-lang.c (add_nonlocal_symbols)
5861         (ada_collect_symbol_completion_matches)
5862         (ada_add_global_exceptions): Update.
5863
5864 2019-01-15  Tom Tromey  <tom@tromey.com>
5865
5866         * progspace.h (program_space) <objfiles_safe_range>: New
5867         typedef.
5868         <objfiles_safe>: New method.
5869         * objfiles.h (class all_objfiles_safe): Remove.
5870         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5871         * jit.c (jit_inferior_exit_hook): Update.
5872
5873 2019-01-17  Tom Tromey  <tom@tromey.com>
5874
5875         * progspace.h (program_space) <objfiles_range>: New typedef.
5876         <objfiles>: New method.
5877         <objfiles_head>: Rename from objfiles.
5878         (object_files): Update.
5879         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5880         * guile/scm-pretty-print.c
5881         (ppscm_find_pretty_printer_from_objfiles): Update.
5882         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5883         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5884         Update.
5885         * python/py-progspace.c (pspy_get_objfiles): Update.
5886         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5887         Update.
5888         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5889         (objfpy_lookup_objfile_by_build_id): Update.
5890         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5891         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5892         Update.
5893         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5894         (expand_symtab_containing_pc, lookup_objfile_from_block)
5895         (lookup_static_symbol, basic_lookup_transparent_type)
5896         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5897         (find_line_symtab, info_sources_command)
5898         (default_collect_symbol_completion_matches_break_on)
5899         (make_source_files_completion_list, find_main_name): Update.
5900         * symmisc.c (print_symbol_bcache_statistics)
5901         (print_objfile_statistics, maintenance_print_symbols)
5902         (maintenance_print_msymbols, maintenance_print_objfiles)
5903         (maintenance_info_symtabs, maintenance_check_symtabs)
5904         (maintenance_expand_symtabs, maintenance_info_line_tables):
5905         Update.
5906         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5907         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5908         (map_overlay_command, unmap_overlay_command)
5909         (simple_overlay_update, expand_symtabs_matching)
5910         (map_symbol_filenames): Update.
5911         * symfile-debug.c (set_debug_symfile): Update.
5912         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5913         Update.
5914         * source.c (select_source_symtab, forget_cached_source_info):
5915         Update.
5916         * solib.c (solib_read_symbols): Update.
5917         * solib-spu.c (append_ocl_sos): Update.
5918         * psymtab.c (maintenance_print_psymbols)
5919         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5920         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5921         * printcmd.c (info_symbol_command): Update.
5922         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5923         Update.
5924         * objfiles.h (class all_objfiles): Remove.
5925         * objfiles.c (have_partial_symbols, have_full_symbols)
5926         (have_minimal_symbols, qsort_cmp, update_section_map)
5927         (shared_objfile_contains_address_p)
5928         (default_iterate_over_objfiles_in_search_order): Update.
5929         * objc-lang.c (info_selectors_command, info_classes_command)
5930         (find_methods): Update.
5931         * minsyms.c (find_solib_trampoline_target): Update.
5932         * maint.c (maintenance_info_sections)
5933         (maintenance_translate_address, count_symtabs_and_blocks):
5934         Update.
5935         * main.c (captured_main_1): Update.
5936         * linux-thread-db.c (try_thread_db_load_from_pdir)
5937         (has_libpthread): Update.
5938         * linespec.c (iterate_over_all_matching_symtabs)
5939         (search_minsyms_for_name): Update.
5940         * jit.c (jit_find_objf_with_entry_addr): Update.
5941         * hppa-tdep.c (find_unwind_entry)
5942         (hppa_lookup_stub_minimal_symbol): Update.
5943         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5944         Update.
5945         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5946         (elf_gnu_ifunc_resolve_by_got): Update.
5947         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5948         * dwarf-index-write.c (save_gdb_index_command): Update.
5949         * cp-support.c (add_symbol_overload_list_qualified): Update.
5950         * breakpoint.c (create_overlay_event_breakpoint)
5951         (create_longjmp_master_breakpoint)
5952         (create_std_terminate_master_breakpoint)
5953         (create_exception_master_breakpoint): Update.
5954         * blockframe.c (find_pc_partial_function): Update.
5955         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5956         (ada_collect_symbol_completion_matches)
5957         (ada_add_global_exceptions): Update.
5958
5959 2019-01-17  Tom Tromey  <tom@tromey.com>
5960
5961         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5962         declare VEC.
5963         (solib_target_parse_libraries): Change return type.
5964         (library_list_start_segment, library_list_start_section)
5965         (library_list_end_library, library_list_start_library); Update.
5966         (solib_target_free_library_list): Remove.
5967         (solib_target_parse_libraries): Remove cleanup.  Change return
5968         type.
5969         (solib_target_current_sos): Update.
5970
5971 2019-01-17  Tom Tromey  <tromey@bapiya>
5972
5973         * valprint.c: Replace "the the" with "the".
5974         * symtab.c: Replace "the the" with "the".
5975         * solib.c: Replace "the the" with "the".
5976         * solib-dsbt.c: Replace "the the" with "the".
5977         * linespec.c: Replace "the the" with "the".
5978         * dwarf2loc.h: Replace "the the" with "the".
5979         * amd64-windows-tdep.c: Replace "the the" with "the".
5980         * aarch64-tdep.c: Replace "the the" with "the".
5981
5982 2019-01-16  Keith Seitz  <keiths@redhat.com>
5983
5984         PR gdb/23773
5985         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5986         <builder>: Rename to ..
5987         <m_builder>: ... this and make private.
5988         (dwarf2_cu::get_builder): New method.  Change all users of
5989         `builder' to use this method.
5990         (dwarf2_start_symtab): Move to ...
5991         (dwarf2_cu::start_symtab): ... here.  Update all callers
5992         (setup_type_unit_groups): Move to ...
5993         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5994         callers.
5995         (dwarf2_cu::reset_builder): New method.
5996         (process_full_compunit, process_full_type_unit): Use
5997         dwarf2_cu::reset_builder.
5998         (follow_die_offset): Record the ancestor CU if it is different
5999         from the followed DIE's CU.
6000         (follow_die_sig_1): Likewise.
6001
6002 2019-01-15  Tom Tromey  <tom@tromey.com>
6003
6004         * remote.c (class remote_state) <buf>: Now a char_vector.
6005         <buf_size>: Remove.
6006         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6007         parameter.
6008         (remote_target::getpkt_or_notif_sane_1)
6009         (remote_target::getpkt_sane)
6010         (remote_target::getpkt_or_notif_sane): Likewise.
6011         (class remote_target) <putpkt>: New overload.
6012         (remote_target::read_frame): Change type of "buf_p".  Remove
6013         sizeof_p parameter.
6014         (packet_ok): New overload.
6015         (packet_check_result): New overload.
6016         Update all uses.
6017
6018 2019-01-14  Tom Tromey  <tom@tromey.com>
6019
6020         * remote-notif.c (handle_notification, remote_notif_ack)
6021         (remote_notif_parse): Make "buf" const.
6022         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6023         const.
6024         (remote_notif_parse, remote_notif_ack, handle_notification):
6025         Likewise.
6026         * remote.c (remote_notif_stop_parse): Make "buf" const.
6027         (remote_target::remote_parse_stop_reply): Make "buf" const.
6028         (remote_notif_stop_ack): Make "buf" const.
6029
6030 2019-01-14  Tom Tromey  <tom@tromey.com>
6031
6032         * remote.c (remote_console_output): Make parameter const.
6033
6034 2019-01-14  Tom Tromey  <tom@tromey.com>
6035
6036         * target-debug.h (target_debug_print_signals): Constify.
6037         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6038         * procfs.c (procfs_target::pass_signals): Update.
6039         * linux-nat.c (linux_nat_target::pass_signals): Update.
6040         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6041         * target-delegates.c: Rebuild.
6042         * remote.c (remote_target::program_signals): Update.
6043         (remote_target::pass_signals): Update.
6044         * target.c (target_pass_signals): Constify argument.
6045         (target_program_signals): Likewise.
6046         * target.h (struct target_ops) <pass_signals, program_signals>:
6047         Constify argument.
6048         (target_pass_signals, target_program_signals): Constify argument.
6049
6050 2019-01-14  Tom Tromey  <tom@tromey.com>
6051
6052         PR tui/28819:
6053         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6054
6055 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6056
6057         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6058         field.
6059         * rs6000-tdep.c: Include reggroups.h.
6060         (IS_V_ALIAS_PSEUDOREG): Define.
6061         (rs6000_register_name): Return names for the "vX" aliases.
6062         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6063         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6064         aliases.  Call default_register_reggroup_p for all other
6065         pseudo-registers.
6066         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6067         New functions.
6068         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6069         Handle "vX" aliases.
6070         (v_alias_pseudo_register_collect): New function.
6071         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6072         (rs6000_gdbarch_init): Initialize "vX" aliases as
6073         pseudo-registers.  Restore registration of
6074         rs6000_pseudo_register_reggroup_p with
6075         set_tdesc_pseudo_register_reggroup_p.
6076
6077 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6078
6079         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6080         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6081         set_gdbarch_num_pseudo_regs.
6082
6083 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6084
6085         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6086         Remove arg prefixname, add do_set and do_show.
6087         Add member functions set_list and show_list.
6088         * cli/cli-style.c (class cli_style_option): Update accordingly.
6089         (style_set_list): Move to file scope.
6090         (style_show_list): Likewise.
6091         (set_style): Call help_list.
6092         (show_style): Call cmd_show_list.
6093         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6094         Update to use the new macro.
6095
6096 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6097
6098         * ada-lang.c (_initialize_ada_language): Expand the help text
6099         for the "catch exception" command.
6100
6101 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6102
6103         * symtab.c (matching_obj_sections): Initialize obj,
6104         declare it closer to its usage.
6105
6106 2019-01-10  Tom Tromey  <tom@tromey.com>
6107
6108         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6109         (basic_inf_threads_range): Remove.
6110         (inf_threads_range, inf_non_exited_threads_range)
6111         (safe_inf_threads_range): Use next_adapter.
6112
6113 2019-01-10  Keith Seitz  <keiths@redhat.com>
6114
6115         PR gdb/23712
6116         PR symtab/23010
6117         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6118         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6119
6120 2019-01-10  Keith Seitz  <keiths@redhat.com>
6121
6122         PR gdb/23712
6123         PR symtab/23010
6124         * dictionary.c (pending_to_vector): Remove.
6125         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6126         Remove _1 suffix, replacing functions of the same name.  Update
6127         all callers.
6128         (dict_create_hashed, dict_create_hashed_expandable)
6129         (dict_create_linear, dict_create_linear_expandable, dict_free)
6130         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6131         Make functions static.
6132
6133 2019-01-10  Keith Seitz  <keiths@redhat.com>
6134
6135         PR gdb/23712
6136         PR symtab/23010
6137         * dictionary.h (struct dictionary): Replace declaration with
6138         multidictionary.
6139         (dict_create_hashed, dict_create_hashed_expandable)
6140         (dict_create_linear, dict_create_linear_expandable)
6141         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6142         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6143         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6144         taking multidictionary argument.
6145         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6146         * block.h (struct block) <dict>: Change to multidictionary
6147         and rename `multidict'.
6148         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6149         symmisc.c: Update all dictionary references to multidictionary.
6150
6151 2019-01-10  Keith Seitz  <keiths@redhat.com>
6152
6153         PR gdb/23712
6154         PR symtab/23010
6155         * dictionary.c: Include unordered_map.
6156         (pending_to_vector): New function.
6157         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6158         Rewrite the non-"_1" functions to take vector instead
6159         of linked list.
6160         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6161         "new" _1 versions of the same name.
6162         (multidictionary): Define.
6163         (std::hash<enum language): New definition.
6164         (collate_pending_symbols_by_language, mdict_create_hashed)
6165         (mdict_create_hashed_expandable, mdict_create_linear)
6166         (mdict_create_linear_expandable, mdict_free)
6167         (find_language_dictionary, create_new_language_dictionary)
6168         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6169         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6170         (mdict_size, mdict_empty): New functions.
6171         * dictionary.h (mdict_iterator): Define.
6172
6173 2019-01-10  Pedro Alves  <palves@redhat.com>
6174
6175         * breakpoint.c (read_uploaded_action)
6176         (create_tracepoint_from_upload): Adjust to use
6177         gdb::unique_xmalloc_ptr.
6178         * ctf.c (ctf_write_uploaded_tp):
6179         (SET_ARRAY_FIELD): Use emplace_back.
6180         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6181         * tracefile-tfile.c (tfile_write_uploaded_tp):
6182         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6183         gdb::unique_xmalloc_ptr.
6184         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6185         at_string, cond_string, cmd_strings>: Replace char pointers
6186         with gdb::unique_xmalloc_ptr.
6187
6188 2019-01-10  Pedro Alves  <palves@redhat.com>
6189
6190         * solib-target.c (library_list_start_library): Don't xstrdup name.
6191
6192 2019-01-10  Pedro Alves  <palves@redhat.com>
6193
6194         * mdebugread.c (parse_partial_symbols): Use
6195         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6196
6197 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6198
6199         * linux-fork.c (scoped_switch_fork_info)
6200         <~scoped_switch_fork_info>: Fix incorrect variable name.
6201
6202 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * linux-fork.c (scoped_switch_fork_info)
6205         <scoped_switch_fork_info>: Make explicit.
6206         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6207
6208 2019-01-10  Tom Tromey  <tom@tromey.com>
6209
6210         * objfiles.h (objfile::reset_psymtabs): Update.
6211         * objfiles.c (objfile::objfile): Update.
6212         * psymtab.h (psymtab_storage::obstack): Update.
6213         (psymtab_storage::m_obstack): Use gdb::optional.
6214         (class psymtab_storage): Update comment.  Remove objfile
6215         parameter.
6216         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6217
6218 2019-01-10  Tom Tromey  <tom@tromey.com>
6219
6220         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6221         <free_psymtabs>: Now private.
6222         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6223         (allocate_psymtab): Use new method.
6224
6225 2019-01-10  Tom Tromey  <tom@tromey.com>
6226
6227         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6228         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6229         * mdebugread.c (parse_partial_symbols): Use
6230         allocate_dependencies.
6231         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6232         allocate_dependencies.
6233         (process_psymtab_comp_unit_reader)
6234         (build_type_psymtab_dependencies): Likewise.
6235         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6236
6237 2019-01-10  Tom Tromey  <tom@tromey.com>
6238
6239         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6240         PSYMBOL_SET_LANGUAGE.
6241         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6242
6243 2019-01-10  Tom Tromey  <tom@tromey.com>
6244
6245         * psymtab.h (psymtab_storage::obstack): New method.
6246         <m_obstack>: Rename from obstack; now private.
6247         * psymtab.c (psymtab_storage): Update.
6248         * dwarf2read.c (create_addrmap_from_index)
6249         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6250         Update.
6251
6252 2019-01-10  Tom Tromey  <tom@tromey.com>
6253
6254         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6255         * objfiles.h (objfile::reset_psymtabs): New method.
6256
6257 2019-01-10  Tom Tromey  <tom@tromey.com>
6258
6259         * symmisc.c (print_symbol_bcache_statistics): Update.
6260         (print_objfile_statistics): Update.
6261         * symfile.c (reread_symbols): Update.
6262         * psymtab.h (class psymtab_storage): New.
6263         * psymtab.c (psymtab_storage): New constructor.
6264         (~psymtab_storage): New destructor.
6265         (require_partial_symbols): Update.
6266         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6267         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6268         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6269         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6270         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6271         (start_psymtab_common, end_psymtab_common)
6272         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6273         (allocate_psymtab): Update.
6274         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6275         Update.
6276         (dump_psymtab_addrmap, maintenance_print_psymbols)
6277         (maintenance_check_psymtabs): Update.
6278         (class objfile_psymtabs): Move to objfiles.h.
6279         * psympriv.h (discard_psymtab): Now inline.
6280         (psymtab_discarder::psymtab_discarder): Update.
6281         (psymtab_discarder::~psymtab_discarder): Update.
6282         (ALL_OBJFILE_PSYMTABS): Rewrite.
6283         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6284         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6285         Remove fields.
6286         <partial_symtabs>: New field.
6287         (class objfile_psymtabs): Move from psymtab.h.  Update.
6288         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6289         psymbol_cache.
6290         (objfile::~objfile): Don't destroy psymbol_cache.
6291         * mdebugread.c (parse_partial_symbols): Update.
6292         * dwarf2read.c (create_addrmap_from_index)
6293         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6294         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6295         (add_partial_subprogram, dwarf2_ranges_read): Update.
6296         * dwarf-index-write.c (write_address_map)
6297         (write_one_signatured_type, recursively_write_psymbols)
6298         (class debug_names, class debug_names, write_psymtabs_to_index):
6299         Update.
6300
6301 2019-01-10  Tom Tromey  <tom@tromey.com>
6302
6303         * symtab.h (SYMBOL_SET_NAMES): Update.
6304         (symbol_set_names): Update.
6305         (MSYMBOL_SET_NAMES): Update.
6306         * symtab.c (symbol_set_names): Change argument to be an
6307         objfile_per_bfd_storage.
6308         * psymtab.c (add_psymbol_to_bcache): Update.
6309         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6310
6311 2019-01-10  Tom Tromey  <tom@tromey.com>
6312
6313         * symtab.c (create_demangled_names_hash): Change argument to be an
6314         objfile_per_bfd_storage.
6315         (symbol_set_names): Update.
6316
6317 2019-01-10  Tom Tromey  <tom@tromey.com>
6318
6319         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6320         init_psymbol_list.
6321         * psymtab.c (init_psymbol_list): Do nothing if already called.
6322         * psympriv.h (init_psymbol_list): Add comment.
6323         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6324         init_psymbol_list.
6325         * dbxread.c (dbx_symfile_read): Unconditionally call
6326         init_psymbol_list.
6327
6328 2019-01-10  Tom Tromey  <tom@tromey.com>
6329
6330         * xcoffread.c (scan_xcoff_symtab): Update.
6331         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6332         "where".
6333         * mdebugread.c (parse_partial_symbols)
6334         (handle_psymbol_enumerators): Update.
6335         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6336         * dbxread.c (read_dbx_symtab): Update.
6337         * psympriv.h (psymbol_placement): New enum.
6338         (add_psymbol_to_list): Update.
6339
6340 2019-01-10  Tom Tromey  <tom@tromey.com>
6341
6342         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6343         static_psymbols parameters.
6344         (scan_xcoff_symtab): Update.
6345         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6346         static_psymbols parameters.
6347         * psympriv.h (start_psymtab_common): Update.
6348         * mdebugread.c (parse_partial_symbols): Update.
6349         * dwarf2read.c (create_partial_symtab): Update.
6350         * dbxread.c (read_dbx_symtab): Update.
6351         (start_psymtab): Remove global_psymbols and static_psymbols
6352         parameters.
6353
6354 2019-01-10  Tom Tromey  <tom@tromey.com>
6355
6356         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6357         * psymtab.c (allocate_psymtab): Add comment.
6358         * psympriv.h (allocate_psymtab): Add comment.
6359         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6360         initializations.
6361         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6362
6363 2019-01-10  Tom Tromey  <tom@tromey.com>
6364
6365         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6366         Don't declare.
6367         * mipsread.c: Include mdebugread.h.
6368         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6369         Declare.
6370         * elfread.c: Include mdebugread.h.
6371
6372 2019-01-09  Tom Tromey  <tom@tromey.com>
6373
6374         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6375         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6376         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6377         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6378         (psym_lookup_symbol, psym_find_last_source_symtab)
6379         (psym_forget_cached_source_info, psym_print_stats)
6380         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6381         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6382         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6383         (psym_find_compunit_symtab_by_address)
6384         (maintenance_print_psymbols, maintenance_info_psymtabs)
6385         (maintenance_check_psymtabs): Use ranged for.
6386         * psymtab.h (class objfile_psymtabs): New.
6387         (require_partial_symbols): Return objfile_psymtabs.
6388         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6389
6390 2019-01-09  Tom Tromey  <tom@tromey.com>
6391
6392         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6393         (find_pc_mapped_section, list_overlays_command)
6394         (map_overlay_command, unmap_overlay_command)
6395         (simple_overlay_update): Use all_objfiles.
6396         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6397         * printcmd.c (info_symbol_command): Use all_objfiles.
6398         * objfiles.h (ALL_OBJSECTIONS): Remove.
6399         * maint.c (maintenance_translate_address): Use all_objfiles.
6400         * gcore.c (gcore_create_callback): Use all_objfiles.
6401         (objfile_find_memory_regions): Likewise.
6402
6403 2019-01-09  Tom Tromey  <tom@tromey.com>
6404
6405         * symtab.c (find_line_symtab, info_sources_command)
6406         (make_source_files_completion_list): Use objfile_compunits.
6407         * source.c (select_source_symtab): Use objfile_compunits.
6408         * objfiles.h (struct objfile): Update comment.
6409         (ALL_OBJFILES): Remove.
6410         (ALL_FILETABS): Remove.
6411         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6412         objfile_compunits.
6413
6414 2019-01-09  Tom Tromey  <tom@tromey.com>
6415
6416         * symmisc.c (print_objfile_statistics, dump_objfile)
6417         (maintenance_print_symbols): Use compunit_filetabs.
6418         * source.c (forget_cached_source_info_for_objfile): Use
6419         compunit_filetabs.
6420         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6421         (ALL_FILETABS): Use compunit_filetabs.
6422         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6423         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6424
6425 2019-01-09  Tom Tromey  <tom@tromey.com>
6426
6427         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6428         (compunit_filetabs): New.
6429         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6430         compunit_filetabs.
6431         (info_sources_command, make_source_files_completion_list): Remove
6432         declaration.
6433         * symmisc.c (print_objfile_statistics, dump_objfile)
6434         (maintenance_print_symbols): Remove declaration.
6435         (maintenance_info_symtabs): Use compunit_filetabs.
6436         (maintenance_info_line_tables): Likewise.
6437         * source.c (select_source_symtab): Change local variable name.
6438         (forget_cached_source_info_for_objfile): Remove declaration.
6439         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6440         * objfiles.c (objfile_relocate1): Remove declaration.
6441         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6442         declaration.
6443         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6444         * coffread.c (coff_symtab_read): Remove declaration.
6445         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6446         compunit_filetabs.
6447
6448 2019-01-09  Tom Tromey  <tom@tromey.com>
6449
6450         * symtab.c (lookup_objfile_from_block)
6451         (find_pc_sect_compunit_symtab, search_symbols)
6452         (default_collect_symbol_completion_matches_break_on): Use
6453         objfile_compunits.
6454         * objfiles.h (ALL_COMPUNITS): Remove.
6455         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6456         * cp-support.c (add_symbol_overload_list_qualified): Use
6457         objfile_compunits.
6458         * ada-lang.c (ada_collect_symbol_completion_matches)
6459         (ada_add_global_exceptions): Use objfile_compunits.
6460
6461 2019-01-09  Tom Tromey  <tom@tromey.com>
6462
6463         * source.c (select_source_symtab)
6464         (forget_cached_source_info_for_objfile): Remove declaration.
6465         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6466         declaration.
6467         * maint.c (count_symtabs_and_blocks): Remove declaration.
6468         * cp-support.c (add_symbol_overload_list_qualified): Remove
6469         declaration.
6470         * coffread.c (coff_symtab_read): Remove declaration.
6471         * symtab.c (lookup_symbol_in_objfile_symtabs)
6472         (basic_lookup_transparent_type_1): Use objfile_compunits.
6473         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6474         (info_sources_command, search_symbols)
6475         (default_collect_symbol_completion_matches_break_on)
6476         (make_source_files_completion_list): Remove declaration.
6477         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6478         (ada_collect_symbol_completion_matches)
6479         (ada_add_global_exceptions): Remove declaration.
6480         * linespec.c (iterate_over_all_matching_symtabs): Use
6481         objfile_compunits.
6482         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6483         (class objfile_compunits): New.
6484         (ALL_COMPUNITS): Use objfile_compunits.
6485         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6486         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6487         objfile_compunits.
6488         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6489
6490 2019-01-09  Tom Tromey  <tom@tromey.com>
6491
6492         * symtab.c (search_symbols)
6493         (default_collect_symbol_completion_matches_break_on): Use
6494         objfile_msymbols.
6495         * ada-lang.c (ada_lookup_simple_minsym)
6496         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6497         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6498         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6499         objfile_msymbols.
6500         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6501         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6502         * objc-lang.c (find_methods): Use objfile_msymbols.
6503         (info_selectors_command, info_classes_command): Likewise.
6504         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6505         * objfiles.h (class objfile_msymbols): New.
6506         (ALL_OBJFILE_MSYMBOLS): Remove.
6507         (ALL_MSYMBOLS): Remove.
6508
6509 2019-01-09  Tom Tromey  <tom@tromey.com>
6510
6511         * common/next-iterator.h (next_adapter): Add Iterator template
6512         parameter.
6513         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6514         (class all_objfiles_safe): New.
6515         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6516         * objfiles.c (put_objfile_before): Update comment.
6517         (add_separate_debug_objfile): Likewise.
6518         (free_all_objfiles): Use all_objfiles_safe.
6519         (objfile_purge_solibs): Likewise.
6520
6521 2019-01-09  Tom Tromey  <tom@tromey.com>
6522
6523         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6524         (expand_symtab_containing_pc, lookup_static_symbol)
6525         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6526         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6527         all_objfiles.
6528         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6529         * breakpoint.c (create_overlay_event_breakpoint)
6530         (create_longjmp_master_breakpoint)
6531         (create_std_terminate_master_breakpoint)
6532         (create_exception_master_breakpoint): Use all_objfiles.
6533         * linux-thread-db.c (try_thread_db_load_from_pdir)
6534         (has_libpthread): Use all_objfiles.
6535         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6536         * linespec.c (iterate_over_all_matching_symtabs)
6537         (search_minsyms_for_name): Use all_objfiles.
6538         * maint.c (maintenance_info_sections): Use all_objfiles.
6539         * main.c (captured_main_1): Use all_objfiles.
6540         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6541         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6542         * guile/scm-pretty-print.c
6543         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6544         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6545         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6546         (maintenance_print_msymbols): Use all_objfiles.
6547         * source.c (select_source_symtab): Use all_objfiles.
6548         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6549         * symfile.c (remove_symbol_file_command)
6550         (expand_symtabs_matching, map_symbol_filenames): Use
6551         all_objfiles.
6552         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6553         all_objfiles.
6554         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6555         * objc-lang.c (find_methods): Use all_objfiles.
6556         * objfiles.c (have_partial_symbols, have_full_symbols)
6557         (have_minimal_symbols, qsort_cmp)
6558         (default_iterate_over_objfiles_in_search_order): Use
6559         all_objfiles.
6560         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6561         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6562         (maintenance_check_psymtabs): Use all_objfiles.
6563         (ALL_PSYMTABS): Remove.
6564         * compile/compile-object-run.c (do_module_cleanup): Use
6565         all_objfiles.
6566         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6567         * cp-support.c (add_symbol_overload_list_qualified): Use
6568         all_objfiles.
6569         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6570         Use all_objfiles.
6571         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6572         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6573         all_objfiles.
6574         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6575         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6576         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6577         Uses all_objfiles.
6578         * solib.c (solib_read_symbols): Use all_objfiles
6579
6580 2019-01-09  Tom Tromey  <tom@tromey.com>
6581
6582         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6583         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6584         all_objfiles.
6585         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6586         * symmisc.c (print_symbol_bcache_statistics)
6587         (print_objfile_statistics, maintenance_print_objfiles)
6588         (maintenance_info_symtabs, maintenance_check_symtabs)
6589         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6590         all_objfiles.
6591         * source.c (forget_cached_source_info): Use all_objfiles.
6592         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6593         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6594         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6595         * objfiles.c (update_section_map): Use all_objfiles.
6596         (shared_objfile_contains_address_p): Likewise.
6597         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6598         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6599
6600 2019-01-09  Tom Tromey  <tom@tromey.com>
6601
6602         * common/next-iterator.h: New file.
6603         * objfiles.h (class all_objfiles): New.
6604         (struct objfile_iterator): New.
6605
6606 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6607
6608         * NEWS: Move the description of the changed "frame", "select-frame",
6609          and "info frame" commands to the Changed commands section.
6610
6611 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6612
6613         * gdbtypes.c (check_stub_method_group): Remove handling of old
6614         mangling schemes.
6615         * linespec.c (find_methods): Likewise.
6616         * stabsread.c (read_member_functions): Likewise.
6617         * valops.c (search_struct_method): Likewise.
6618         (value_struct_elt_for_reference): Likewise.
6619         * NEWS: Mention this change.
6620
6621 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6622
6623         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6624         print_source_lines.
6625         * source.c (print_source_lines_base): Update line number check.
6626         (print_source_lines): New function.
6627         (source_lines_range::source_lines_range): New function.
6628         * source.h (class source_lines_range): New class.
6629         (print_source_lines): New declaration.
6630
6631 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6632
6633         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6634
6635 2019-01-08  Tom Tromey  <tom@tromey.com>
6636             Simon Marchi  <simon.marchi@ericsson.com>
6637
6638         PR gdb/24060
6639         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6640         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6641         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6642         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6643         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6644         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6645
6646 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6647
6648         * source.c (select_source_symtab): Move header comment to
6649         declaration in source.h.
6650         (forget_cached_source_info_for_objfile): Likewise.
6651         (forget_cached_source_info): Likewise.
6652         (identify_source_line): Likewise.
6653         * source.h (identify_source_line): Move declaration from symtab.h
6654         and add comment from source.c
6655         (print_source_lines): Likewise.
6656         (forget_cached_source_info_for_objfile): Likewise.
6657         (forget_cached_source_info): Likewise.
6658         (select_source_symtab): Likewise.
6659         (enum print_source_lines_flag): Move definition from symtab.h.
6660         * symtab.h (identify_source_line): Move declaration to source.h.
6661         (print_source_lines): Likewise.
6662         (forget_cached_source_info_for_objfile): Likewise.
6663         (forget_cached_source_info): Likewise.
6664         (select_source_symtab): Likewise.
6665         (enum print_source_lines_flag): Move definition to source.h.
6666         * tui/tui-hooks.c: Add 'source.h' include.
6667
6668 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6669
6670         * source.c (print_source_lines_base): Handle requests to print
6671         reverse line number sequences, and guard against empty lines
6672         string.
6673
6674 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6675
6676         * source.c (print_source_lines_base): Fix skip of '\r' if next
6677         character is '\n'.
6678
6679 2019-01-06  Tom Tromey  <tom@tromey.com>
6680
6681         * c-exp.y (struct c_parse_state) <macro_original_text,
6682         expansion_obstack>: New member.
6683         (macro_original_text, expansion_obstack): Remove globals.
6684         (scan_macro_expansion, scanning_macro_expansion)
6685         (finished_macro_expansion): Update.
6686         (scan_macro_cleanup): Remove.
6687         (yylex, c_parse): Update.
6688
6689 2019-01-06  Tom Tromey  <tom@tromey.com>
6690
6691         * c-exp.y (struct c_parse_state) <strings>: New member.
6692         (operator_stoken): Update.
6693
6694 2019-01-06  Tom Tromey  <tom@tromey.com>
6695
6696         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6697         (union type_stack_elt) <typelist_val>: Now a pointer to
6698         std::vector.
6699         (type_stack_cleanup): Don't declare.
6700         (push_typelist): Update.
6701         * parse.c (pop_typelist): Return a std::vector.
6702         (push_typelist): Take a std::vector.
6703         (follow_types): Update.  Do not free args.
6704         (type_stack_cleanup): Remove.
6705         * c-exp.y (struct c_parse_state): New.
6706         (cpstate): New global.
6707         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6708         (nonempty_typelist): Update.
6709         (func_mod): Create a new vector.
6710         (c_parse): Create a c_parse_state.
6711         (check_parameter_typelist): Do not delete params.
6712         (function_method): Update.  Do not delete type_list.
6713
6714 2019-01-06  Tom Tromey  <tom@tromey.com>
6715
6716         PR gdb/28155:
6717         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6718         check_typedef.
6719         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6720         (print_return_value): Likewise.
6721
6722 2019-01-05  Tom Tromey  <tom@tromey.com>
6723
6724         * contrib/cleanup_check.py: Remove.
6725         * contrib/gcc-with-excheck: Remove.
6726         * contrib/exsummary.py: Remove.
6727         * contrib/excheck.py: Remove.
6728
6729 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6730
6731         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6732         NULL. Initialize tpprev to NULL instead of assigning it
6733         to NULL on the next statement.
6734         * windows-nat.c (windows_delete_thread): Remove check for
6735         main_thread_id before printing thread exit notifications.
6736         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6737         Remove thread ID check against main_thread_id.
6738         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6739         windows_delete_thread.
6740         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6741
6742 2019-01-04  Tom Tromey  <tom@tromey.com>
6743
6744         * compile/compile.c (_initialize_compile): Use upper case for
6745         metasyntactic variables.
6746         * symmisc.c (_initialize_symmisc): Use upper case for
6747         metasyntactic variables.
6748         * psymtab.c (_initialize_psymtab): Use upper case for
6749         metasyntactic variables.
6750         * demangle.c (demangle_command): Use upper case for metasyntactic
6751         variables.
6752         (_initialize_demangler): Likewise.
6753         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6754         variables.
6755
6756 2019-01-03  Tom Tromey  <tom@tromey.com>
6757
6758         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6759
6760 2019-01-03  Tom Tromey  <tom@tromey.com>
6761
6762         * python/py-symtab.c (salpy_str): Update.
6763         (struct salpy_sal_object) <symtab>: Now a PyObject.
6764         (salpy_dealloc): Update.
6765         (del_objfile_sal): Use gdbpy_ref.
6766
6767 2019-01-03  Tom Tromey  <tom@tromey.com>
6768
6769         * python/py-type.c (convert_field): Use new_reference.  Return
6770         gdbpy_ref.
6771         (make_fielditem): Return gdbpy_ref.
6772         (typy_fields): Update.
6773         (typy_getitem): Update.
6774         (field_name): Return gdbpy_ref.  Use new_reference.
6775         (typy_iterator_iternext): Update.
6776
6777 2019-01-03  Tom Tromey  <tom@tromey.com>
6778
6779         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6780
6781 2019-01-03  Tom Tromey  <tom@tromey.com>
6782
6783         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6784         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6785         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6786         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6787         (pspy_set_type_printers): Likewise.
6788         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6789         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6790         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6791         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6792         (objfpy_set_type_printers): Likewise.
6793
6794 2019-01-03  Tom Tromey  <tom@tromey.com>
6795
6796         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6797         (gdbpy_print_stack): Use gdbpy_err_fetch.
6798         * python/python-internal.h (class gdbpy_err_fetch): New class.
6799         (class gdbpy_enter) <m_error_type, m_error_value,
6800         m_error_traceback>: Remove.
6801         <m_error>: New member.
6802         (gdbpy_exception_to_string): Don't declare.
6803         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6804         * python/py-value.c (convert_value_from_python): Use
6805         gdbpy_err_fetch.
6806         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6807         gdbpy_exception_to_string.
6808         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6809         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6810         gdbpy_err_fetch.
6811
6812 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6813
6814         * linux-nat.c (delete_lwp_cleanup): Delete.
6815         (struct lwp_deleter): New struct.
6816         (lwp_info_up): New typedef.
6817         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6818         lwp_info_up.
6819
6820 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6821
6822         * linux-fork.c (class scoped_switch_fork_info): New class.
6823         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6824
6825 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6826
6827         * valops.c (find_overload_match): Remove use of null_cleanup, and
6828         calls to do_cleanups.
6829
6830 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6831
6832         * compile/compile-cplus-types.c
6833         (compile_cplus_instance::decl_name): Handle changes to
6834         cp_func_name.
6835         * cp-support.c (cp_func_name): Update header comment, update
6836         return type.
6837         * cp-support.h (cp_func_name): Update return type in declaration.
6838         * valops.c (find_overload_match): Move temp_func local to top
6839         level of function and change its type.  Use temp_func to hold and
6840         delete temporary string obtained from cp_func_name.
6841
6842 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6843
6844         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6845         gdb::char_vector, remove cleanup, and update uses of `msg`.
6846
6847 2019-01-03  Jim Wilson  <jimw@sifive.com>
6848
6849         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6850
6851 2019-01-02  Tom Tromey  <tom@tromey.com>
6852
6853         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6854         (tdesc_parse_xml): Remove cleanups.
6855         * target-descriptions.h (make_cleanup_free_target_description):
6856         Don't declare.
6857         (target_desc_deleter): New struct.
6858         (target_desc_up): New typedef.
6859         * target-descriptions.c (target_desc_deleter::operator()): Rename
6860         from free_target_description.
6861         (make_cleanup_free_target_description): Remove.
6862
6863 2019-01-02  Tom Tromey  <tom@tromey.com>
6864
6865         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6866         constructor, destructor.
6867         (linespec_parser): Remove typedef.
6868         (~linespec_parser): Rename from linespec_parser_delete.
6869         (linespec_lex_to_end, linespec_complete_label)
6870         (linespec_complete): Update.
6871         (decode_line_full): Remove cleanups.
6872         (decode_line_1): Update.
6873
6874 2019-01-02  Tom Tromey  <tom@tromey.com>
6875
6876         * python/python-internal.h (inferior_to_inferior_object): Change
6877         return type.
6878         * python/py-exitedevent.c (create_exited_event_object): Update.
6879         * python/py-inferior.c (inferior_to_inferior_object): Return
6880         gdbpy_ref.
6881         (python_new_inferior, python_inferior_deleted)
6882         (thread_to_thread_object, delete_thread_object)
6883         (build_inferior_list, gdbpy_selected_inferior): Update.
6884         * python/py-infthread.c (create_thread_object): Update.  Also fail
6885         if inferior_to_inferior_object fails.
6886
6887 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6888
6889         * inferior.h (class inferior) <displaced_step_state>: New field.
6890         * infrun.h (struct displaced_step_state): Move here from
6891         infrun.c.  Initialize fields, add constructor.
6892         <inf>: Remove field.
6893         <reset>: New method.
6894         * infrun.c (struct displaced_step_inferior_state): Move to
6895         infrun.h.
6896         (displaced_step_inferior_states): Remove.
6897         (get_displaced_stepping_state): Adust.
6898         (displaced_step_in_progress_any_inferior): Adjust.
6899         (displaced_step_in_progress_thread): Adjust.
6900         (displaced_step_in_progress): Adjust.
6901         (add_displaced_stepping_state): Remove.
6902         (get_displaced_step_closure_by_addr): Adjust.
6903         (remove_displaced_stepping_state): Remove.
6904         (infrun_inferior_exit): Call displaced_step_state.reset.
6905         (use_displaced_stepping): Don't check for NULL.
6906         (displaced_step_prepare_throw): Call
6907         get_displaced_stepping_state.
6908         (displaced_step_fixup): Don't check for NULL.
6909         (prepare_for_detach): Don't check for NULL.
6910
6911 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6912
6913         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6914          in case of call that did not complete.
6915
6916 2019-01-02  Andrey Utkin  <autkin@undo.io>
6917
6918         * symfile.c (find_separate_debug_file): Fix search of debug files for
6919         remote debuggee.
6920
6921 2019-01-02  Tom Tromey  <tom@tromey.com>
6922
6923         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6924         indentation.
6925         * python/py-frame.c (frapy_older): Remove cast.
6926         (frapy_newer): Likewise.
6927         * python/py-breakpoint.c (local_setattro): Remove cast.
6928         * python/py-arch.c (archpy_name): Remove local variable.
6929         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6930
6931 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6932
6933         * unittests/basic_string_view/element_access/char/empty.cc:
6934         Fix year range in copyright header.
6935
6936 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6937
6938         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6939         Delete.
6940         <operator==>: Update with for removed field.
6941         <hash>: Likewise.
6942         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6943         <isa_features>: ...this.
6944         <abi_features>: New field.
6945         (riscv_isa_flen): Update comment.
6946         (riscv_abi_xlen): New declaration.
6947         (riscv_abi_flen): New declaration.
6948         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6949         isa_features.
6950         (riscv_abi_xlen): New function.
6951         (riscv_isa_flen): Update to get answer from isa_features.
6952         (riscv_abi_flen): New function.
6953         (riscv_has_fp_abi): Update to get answer from abi_features.
6954         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6955         xlen and flen.
6956         (riscv_call_info) <xlen, flen>: Update comment.
6957         (riscv_call_arg_struct): Remove invalid assertions
6958         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6959         is removed.
6960         (riscv_gdbarch_init): Gather isa features and abi features
6961         separately, ensure both match on the gdbarch when reusing an old
6962         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6963         a target with 64-bit float hardware.
6964
6965 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6966
6967         * source.c (search_command_helper): Stop reverse search
6968         when line 1 has been searched.
6969
6970 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6971
6972         * record-full.c (record_full_base_target::close): Rewrite
6973         record_full_core_buf_list free logic.
6974
6975 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6976
6977         * break-catch-syscall.c (print_one_catch_syscall): xfree
6978         the last text.
6979
6980 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6981
6982         * top.c (print_gdb_version): Update Copyright year in version
6983         message.
6984
6985 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6986
6987         Update copyright year range in all GDB files.
6988
6989 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6990
6991         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6992
6993 For older changes see ChangeLog-2018.
6994 \f
6995 Local Variables:
6996 mode: change-log
6997 left-margin: 8
6998 fill-column: 74
6999 version-control: never
7000 coding: utf-8
7001 End:
7002