gdb/ChangeLog

   1 2019-08-16  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_window_base)
   4         <update_source_window_as_is>: Declare.
   5         (tui_update_source_window_as_is): Don't declare.
   6         * tui/tui-winsource.c (tui_update_source_window): Update
   7         (tui_source_window_base::update_source_window_as_is): Rename from
   8         tui_update_source_window_as_is.
   9         (tui_source_window_base::refill): Update.
  10         * tui/tui-source.c (tui_show_symtab_source): Update.
  11         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
  12         Update.
  13
  14 2019-08-16  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-winsource.h (tui_update_source_window)
  17         (tui_update_source_window_as_is): Remove "noerror" parameter.
  18         * tui/tui-winsource.c (tui_update_source_window)
  19         (tui_update_source_window_as_is): Remove "noerror" parameter.
  20         (tui_update_source_windows_with_addr)
  21         (tui_update_source_windows_with_line)
  22         (tui_source_window_base::rerender)
  23         (tui_source_window_base::refill): Update.
  24         * tui/tui-source.h (tui_set_source_content)
  25         (tui_show_symtab_source): Remove "noerror" parameter.
  26         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
  27         parameter.
  28         (tui_show_symtab_source): Likewise.
  29         (tui_source_window::maybe_update): Update.
  30         * tui/tui-disasm.c (tui_show_disassem)
  31         (tui_show_disassem_and_update_source)
  32         (tui_disasm_window::do_scroll_vertical)
  33         (tui_disasm_window::maybe_update): Update.
  34
  35 2019-08-16  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui.c (tui_is_window_visible): Update.
  38         * tui/tui-wingeneral.c (tui_make_window)
  39         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
  40         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
  41         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
  42         (tui_set_win_height_command, parse_scrolling_args): Update.
  43         * tui/tui-source.c (tui_source_window::style_changed): Update.
  44         * tui/tui-regs.c (tui_show_registers)
  45         (tui_data_window::first_data_item_displayed)
  46         (tui_data_window::delete_data_content_windows)
  47         (tui_check_register_values, tui_reg_command): Update.
  48         * tui/tui-disasm.c (tui_show_disassem): Update.
  49         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
  50         method.
  51         <is_visible>: Remove field.
  52         * tui/tui-data.c (tui_next_win, tui_prev_win)
  53         (tui_delete_invisible_windows): Update.
  54
  55 2019-08-16  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-winsource.h (struct tui_source_window_base)
  58         <m_has_locator>: Remove.
  59         * tui/tui-layout.c (show_source_disasm_command, show_data)
  60         (show_source_or_disasm_and_command): Update.
  61
  62 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
  63
  64         * NEWS (Other MI changes): New subsection.
  65         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
  66         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
  67         * arch-utils.c (default_get_pc_address_flags): New function.
  68         * arch-utils.h (default_get_pc_address_flags): New declaration.
  69         * gdbarch.sh: Add get_pc_address_flags.
  70         * gdbarch.c: Regenerate.
  71         * gdbarch.h: Likewise.
  72         * stack.c (print_pc): New function.
  73         (print_frame_info) (print_frame): Call print_pc.
  74
  75 2019-08-16  Tom de Vries  <tdevries@suse.de>
  76
  77         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
  78         print_objfile_section_info.
  79
  80 2019-08-15  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
  83         calling update_cmdwin_start_line.
  84         * tui/tui-winsource.h (struct tui_source_window_base)
  85         <do_make_visible_with_new_height, set_new_height>: Don't declare.
  86         <rerender>: Declare.
  87         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
  88         Call rerender.
  89         (tui_source_window_base::set_new_height): Remove.
  90         (tui_source_window_base::rerender): Rename from
  91         do_make_visible_with_new_height.
  92         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
  93         resize method.
  94         (tui_win_info::make_invisible_and_set_new_height)
  95         (tui_win_info::make_visible_with_new_height): Remove.
  96         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
  97         Declare.
  98         * tui/tui-stack.c (tui_locator_window::rerender): New method.
  99         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 100         do_make_visible_with_new_height>: Don't declare.
 101         <rerender>: Declare.
 102         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 103         set_new_height.
 104         (tui_data_window::do_make_visible_with_new_height): Remove.
 105         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 106         call tui_show_locator_content.
 107         (tui_gen_win_info::resize): Call rerender.
 108         (show_source_or_disasm_and_command): Don't call
 109         tui_show_locator_content.
 110         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 111         method.
 112         (struct tui_win_info) <rerender>: Declare.
 113         <set_new_height, make_invisible_and_set_new_height,
 114         make_visible_with_new_height>: Don't declare.
 115         * tui/tui-data.c (tui_win_list::rerender): New method.
 116         * tui/tui-command.h (struct tui_cmd_window)
 117         <do_make_visible_with_new_height>: Don't declare.
 118         * tui/tui-command.c
 119         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 120
 121 2019-08-15  Tom Tromey  <tromey@adacore.com>
 122
 123         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 124         * ada-lang.c (ada_enum_name): Likewise.
 125
 126 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 127
 128         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 129         leading underscore.
 130         (GdbOutputErrorFile): Likewise.
 131         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 132         accordingly.
 133         (execute_unwinders): Rename to have a leading underscore.
 134         (auto_load_packages): Likewise.
 135         (global scope): Adjust call to auto_load_packages accordingly.
 136         (GdbSetPythonDirectory): Likewise.
 137         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 138         instead of execute_unwinders.
 139
 140 2019-08-15  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 143         (show_data): Don't change window visibility.
 144         (tui_gen_win_info::resize): Remove special case for command
 145         window.  Use wresize, when available.
 146         (show_source_or_disasm_and_command): Don't change window
 147         visibility.
 148         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 149         <make_visible>: New method.
 150         * tui/tui-command.c (tui_cmd_window::resize): New method.
 151
 152 2019-08-15  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 155         (struct tui_source_windows): New.
 156         * tui/tui-winsource.c (tui_display_main): Update.
 157         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 158         (new_height_ok, parse_scrolling_args): Update.
 159         * tui/tui-layout.c (show_layout, show_data): Update.
 160         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 161         (tui_add_to_source_windows): Don't declare.
 162         * tui/tui-data.c (source_windows, tui_source_windows)
 163         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 164
 165 2019-08-15  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 168         Rename from reset.
 169         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 170         * tui/tui-layout.c (show_source_disasm_command, show_data):
 171         Update.
 172         (tui_gen_win_info::resize): Rename.
 173         (show_source_or_disasm_and_command): Update.
 174         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 175         reset.
 176
 177 2019-08-15  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 180         * tui/tui-interp.c (tui_interp::init): Don't call
 181         tui_initialize_static_data.
 182         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 183
 184 2019-08-15  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 187         examine tui_win_list.
 188
 189 2019-08-15  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 192         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 193         tui_clear_source_content.
 194         (tui_clear_source_content): Remove.
 195         (tui_source_window_base::do_erase_source_content): Hoist call to
 196         content.clear().
 197         * tui/tui-stack.c (tui_show_frame_info): Don't call
 198         tui_clear_source_content.
 199
 200 2019-08-15  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-winsource.h (struct tui_source_window_base)
 203         <do_erase_source_content>: New method.
 204         <erase_source_content>: New method.
 205         (tui_erase_source_content): Don't declare.
 206         * tui/tui-winsource.c (tui_clear_source_content): Update.
 207         (tui_source_window_base::do_erase_source_content): Rename from
 208         tui_erase_source_content.
 209         (tui_source_window_base::show_source_content): Update.
 210         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 211         * tui/tui-source.h (struct tui_source_window)
 212         <erase_source_content>: New method.
 213         * tui/tui-disasm.h (struct tui_disasm_window)
 214         <erase_source_content>: New method.
 215
 216 2019-08-15  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 219         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 220         constructor.
 221         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 222         * tui/tui-source.c (tui_set_source_content): Update.
 223         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 224
 225 2019-08-15  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 228         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 229         tui-source.c.
 230         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 231         Declare.
 232         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 233         method.
 234         (tui_source_window::maybe_update): Update.
 235
 236 2019-08-15  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 239         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 240         tui-disasm.c.
 241         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 242         Declare.
 243         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 244         method.
 245         (tui_disasm_window::maybe_update): Update.
 246
 247 2019-08-15  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-winsource.h (struct tui_source_window_base)
 250         <maybe_update>: Declare.
 251         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 252         method.
 253         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 254         Declare.
 255         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 256         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 257         Declare.
 258         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 259
 260 2019-08-15  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 263
 264 2019-08-15  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-wingeneral.c: Include tui-stack.h.
 267         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 268         (struct tui_locator_window): Move from tui-data.h.
 269         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 270         (tui_initialize_static_data): Move from tui-data.c.
 271         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 272         (struct tui_locator_window): Move to tui-stack.c.
 273         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 274         (tui_initialize_static_data): Move to tui-stack.c.
 275
 276 2019-08-15  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-layout.c (show_source_disasm_command)
 279         (show_source_or_disasm_and_command): Use make_visible method, not
 280         tui_make_window.
 281         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 282         Remove.
 283
 284 2019-08-15  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-wingeneral.h (tui_make_window): Update.
 287         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 288         parameter.
 289         (tui_gen_win_info::make_visible): Update.
 290         * tui/tui-regs.c (tui_data_window::display_registers_from):
 291         Update.
 292         * tui/tui-layout.c (show_source_disasm_command)
 293         (show_source_or_disasm_and_command): Update.
 294         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 295         (enum tui_box): Remove.
 296         (struct tui_win_info) <can_box>: New method.
 297         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 298         method.
 299
 300 2019-08-15  Tom de Vries  <tdevries@suse.de>
 301
 302         * linux-nat-trad.c: Include gdbarch.h.
 303
 304 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 305
 306         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 307         register sizes.
 308
 309 2019-08-14  Tom Tromey  <tromey@adacore.com>
 310
 311         * darwin-nat.c: Include gdbarch.h.
 312         * darwin-nat-info.c: Include gdbarch.h.
 313
 314 2019-08-13  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 317         Remove.
 318         * tui/tui-data.c (tui_initialize_static_data): Update.
 319
 320 2019-08-13  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-winsource.h (struct tui_exec_info_window)
 323         <~tui_exec_info_window, maybe_allocate_content, get_content,
 324         m_content>: Remove.
 325         (struct tui_source_window_base) <set_exec_info_content,
 326         show_exec_info_content>: Don't declare.
 327         * tui/tui-winsource.c
 328         (tui_exec_info_window::maybe_allocate_content): Remove.
 329         (tui_source_window_base::update_exec_info): Rename from
 330         set_exec_info_content.
 331         (tui_source_window_base::show_exec_info_content)
 332         (tui_source_window_base::update_exec_info): Remove.
 333
 334 2019-08-13  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 337         declare.
 338         * tui/tui-winsource.c (tui_update_source_window_as_is)
 339         (tui_update_source_windows_with_addr, tui_erase_source_content):
 340         Update.
 341         (tui_clear_exec_info_content): Remove.
 342
 343 2019-08-13  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 346         declare.
 347         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 348         call tui_erase_exec_info_content.
 349         (tui_clear_exec_info_content): Rename from
 350         tui_erase_exec_info_content.
 351         (tui_clear_exec_info_content): Delete.
 352
 353 2019-08-13  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-winsource.h (struct tui_source_window_base)
 356         <show_exec_info_content>: Declare.
 357         (tui_show_exec_info_content): Don't declare.
 358         * tui/tui-winsource.c
 359         (tui_source_window_base::show_exec_info_content): Rename from
 360         tui_show_exec_info_content.
 361         (tui_source_window_base::update_exec_info): Update.
 362
 363 2019-08-13  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 366         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 367         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 368         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 369         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 370         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 371         ... here.
 372
 373 2019-08-13  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-winsource.h (struct tui_source_window_base)
 376         <update_exec_info>: Declare.
 377         (tui_update_exec_info): Don't declare.
 378         * tui/tui-winsource.c (tui_update_source_window_as_is)
 379         (tui_source_window_base::refresh_all)
 380         (tui_update_all_breakpoint_info): Update.
 381         (tui_source_window_base::update_exec_info): Rename from
 382         tui_update_exec_info.
 383         * tui/tui-stack.c (tui_show_frame_info): Update.
 384
 385 2019-08-13  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-winsource.h (struct tui_source_window_base)
 388         <set_exec_info_content>: Declare.
 389         (tui_set_exec_info_content): Don't declare.
 390         * tui/tui-winsource.c
 391         (tui_source_window_base::set_exec_info_content): Rename from
 392         tui_set_exec_info_content.
 393         (tui_update_exec_info): Update.
 394
 395 2019-08-13  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-winsource.h (struct tui_source_window_base)
 398         <show_source_content>: Declare.
 399         (tui_show_source_content): Don't declare.
 400         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 401         (tui_source_window_base::show_source_content): Rename from
 402         tui_show_source_content.
 403         (tui_source_window_base::refresh_all): Update.
 404         * tui/tui-layout.c (show_source_disasm_command)
 405         (show_source_or_disasm_and_command): Update.
 406
 407 2019-08-13  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-winsource.c (tui_erase_source_content)
 410         (tui_show_source_content, tui_source_window_base::refresh_all):
 411         Update.
 412         * tui/tui-wingeneral.h
 413         (tui_check_and_display_highlight_if_needed): Don't declare.
 414         * tui/tui-wingeneral.c
 415         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 416         check_and_display_highlight_if_needed.
 417         * tui/tui-win.c (tui_rehighlight_all)
 418         (tui_win_info::make_visible_with_new_height): Update.
 419         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 420         (tui_data_window::erase_data_content)
 421         (tui_data_window::display_all_data): Update.
 422         * tui/tui-data.h (struct tui_win_info)
 423         <check_and_display_highlight_if_needed>: Declare.
 424
 425 2019-08-13  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-win.c (tui_resize_all): Call
 428         tui_delete_invisible_windows.
 429         * tui/tui-layout.c (show_layout): Call
 430         tui_delete_invisible_windows.
 431         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 432         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 433
 434 2019-08-13  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 437         tui_add_win_to_layout.
 438
 439 2019-08-13  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 442         * tui/tui-layout.c (tui_default_win_height): Now static.
 443
 444 2019-08-13  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 447         single switch.
 448         (show_source_disasm_command, show_source_or_disasm_and_command):
 449         Don't check current layout.
 450
 451 2019-08-13  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-wingeneral.c (make_all_visible): Remove.
 454         (tui_make_all_invisible): Simplify.
 455         * tui/tui-layout.c (tui_make_all_invisible): Move from
 456         tui-wingeneral.c; simplify.
 457         (show_layout): Hoist call to tui_make_all_invisible.
 458         (show_data): Don't call tui_make_all_invisible.
 459
 460 2019-08-13  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 463         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 464
 465 2019-08-13  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 468         tui-data.c.
 469         (show_source_disasm_command, show_data)
 470         (show_source_or_disasm_and_command): Don't use
 471         tui_set_current_layout_to.
 472         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 473         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 474         tui-layout.c.
 475         (tui_set_current_layout_to): Remove.
 476
 477 2019-08-13  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-layout.c (tui_set_layout): Update.
 480         * tui/tui-data.h (struct tui_layout_def): Remove.
 481         (tui_layout_def): Don't declare.
 482         * tui/tui-data.c (layout_def): Remove.
 483         (tui_layout_def): Remove.
 484
 485 2019-08-13  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-winsource.h (struct tui_source_window_base)
 488         <clear_detail>: No longer "override".
 489         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 490         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 491         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 492         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 493         Remove.
 494         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 495
 496 2019-08-13  Tom Tromey  <tromey@adacore.com>
 497
 498         * tracepoint.c: Don't include readline.h or history.h.
 499
 500 2019-08-12  Tom Tromey  <tom@tromey.com>
 501
 502         * configure: Rebuild.
 503         * configure.ac: Check for readline 7.
 504         * NEWS: Mention readline 7 requirement.
 505         * README: Update.
 506
 507 2019-08-12  Tom Tromey  <tom@tromey.com>
 508
 509         * mingw-hdep.c (gdb_select): Remove readline hack.
 510
 511 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 512
 513         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 514         when the function fails.
 515
 516 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 517
 518         * s390-tdep.c (s390_type_align): New function.
 519         (s390_gdbarch_init): Set it as type_align gdbarch method.
 520
 521 2019-08-09  Tom de Vries  <tdevries@suse.de>
 522
 523         PR gdb/24591
 524         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 525         pc_low with relocation offset.
 526
 527 2019-08-07  Tom Tromey  <tromey@adacore.com>
 528
 529         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 530         (print_frame_args): Update.
 531         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 532         Update.
 533         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 534         * frame.h (struct frame_arg): Add initializers.
 535         <error>: Now a unique_xmalloc_ptr.
 536
 537 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 538
 539         * NEWS: Expand the Pointer Authentication entry.
 540         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 541         (aarch64_frame_unmask_lr): ... to this.
 542         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 543         Call aarch64_frame_unmask_lr.
 544         * frame.c (struct frame_info): Add "masked" variable.
 545         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 546         (fprint_frame): Check for masked pc.
 547         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 548         declarations.
 549         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 550         * stack.c (print_frame): Check for masked pc.
 551
 552 2019-08-06  Tom Tromey  <tom@tromey.com>
 553
 554         * stabsread.c (patch_block_stabs, read_one_struct_field)
 555         (read_enum_type): Use obstack_strndup.
 556         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 557         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 558         * dwarf2read.c (guess_full_die_structure_name)
 559         (anonymous_struct_prefix): Use obstack_strndup.
 560         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 561         * c-exp.y (yylex): Use obstack_strndup.
 562         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 563         (write_var_or_type): Use obstack_strndup.
 564
 565 2019-08-06  Tom Tromey  <tom@tromey.com>
 566
 567         * symfile.c (reread_symbols): Use obstack_strdup.
 568         * stabsread.c (read_type): Use obstack_strdup.
 569         * gdb_obstack.h (obstack_strdup): New overload.
 570         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 571         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 572         (dwarf2_canonicalize_name): Use obstack_strdup.
 573         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 574         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 575         Use obstack_strdup.
 576
 577 2019-08-06  Tom Tromey  <tom@tromey.com>
 578
 579         * gdb_obstack.h (obstack_strdup): Define.
 580         * gdb_obstack.c (obstack_strdup): Don't define.
 581
 582 2019-08-06  Tom Tromey  <tom@tromey.com>
 583
 584         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 585         obstack_strdup.
 586         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 587         obstack_strdup.
 588         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 589         * stabsread.c (common_block_start): Use obstack_strdup.
 590         * objfiles.c (set_objfile_main_name, objfile): Use
 591         obstack_strdup.
 592         * namespace.c (add_using_directive): Use obstack_strdup.
 593         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 594         * jit.c (finalize_symtab): Use obstack_strdup.
 595         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 596         (guess_partial_die_structure_name, partial_die_info::fixup)
 597         (dwarf2_name): Use obstack_strdup.
 598         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 599         obstack_strdup.
 600         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 601         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 602         obstack_strdup.
 603         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 604
 605 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 606
 607         * unittests/help-doc-selftests.c: New file.
 608         * Makefile.in: Add the new file.
 609
 610 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 611
 612         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 613         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 614         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 615         the trailing '.' is not output, and the first character is uppercased.
 616         (print_help_for_command): Update call to print_doc_line.
 617         (print_doc_of_command): Likewise.
 618         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 619         * cli/cli-option.c (append_indented_doc): Do not append newline.
 620         (build_help_option): Append newline after first appended_indented_doc
 621         only if a second call is done.
 622         (build_help): Append 2 new lines before each option, except the first
 623         one.
 624         * compile/compile.c (_initialize_compile): Add new lines after
 625         %OPTIONS%, when not at the end of the help.
 626         Change help doc or code
 627         producing the help doc to respect the invariants.
 628         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 629         Also removed the new line after 'Options:', as all other commands
 630         do not put an empty line between 'Options:' and the first option.
 631         * printcmd.c (_initialize_printcmd): Likewise.
 632         * stack.c (_initialize_stack): Likewise.
 633         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 634         incorrectly telling COMMAND is optional.
 635         * ada-lang.c (_initialize_ada_language): Change help doc or code
 636         producing the help doc to respect the invariants.
 637         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 638         * breakpoint.c (_initialize_breakpoint): Likewise.
 639         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 640         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 641         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 642         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 643         _initialize_cli_style): Likewise.
 644         * corelow.c (core_target_info): Likewise.
 645         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 646         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 647         * filesystem.c (_initialize_filesystem): Likewise.
 648         * frame.c (_initialize_frame): Likewise.
 649         * gnu-nat.c (add_task_commands): Likewise.
 650         * infcall.c (_initialize_infcall): Likewise.
 651         * infcmd.c (_initialize_infcmd): Likewise.
 652         * interps.c (_initialize_interpreter): Likewise.
 653         * language.c (_initialize_language): Likewise.
 654         * linux-fork.c (_initialize_linux_fork): Likewise.
 655         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 656         * maint.c (_initialize_maint_cmds): Likewise.
 657         * memattr.c (_initialize_mem): Likewise.
 658         * printcmd.c (_initialize_printcmd): Likewise.
 659         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 660         _RegEx): Likewise.
 661         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 662         * record-btrace.c (_initialize_record_btrace): Likewise.
 663         * record-full.c (_initialize_record_full): Likewise.
 664         * record.c (_initialize_record): Likewise.
 665         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 666         * regcache.c (_initialize_regcache): Likewise.
 667         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 668         _initialize_remote): Likewise.
 669         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 670         * serial.c (_initialize_serial): Likewise.
 671         * skip.c (_initialize_step_skip): Likewise.
 672         * source.c (_initialize_source): Likewise.
 673         * stack.c (_initialize_stack): Likewise.
 674         * symfile.c (_initialize_symfile): Likewise.
 675         * symtab.c (_initialize_symtab): Likewise.
 676         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 677         * top.c (init_main): Likewise.
 678         * tracefile-tfile.c (tfile_target_info): Likewise.
 679         * tracepoint.c (_initialize_tracepoint): Likewise.
 680         * tui/tui-win.c (_initialize_tui_win): Likewise.
 681         * utils.c (add_internal_problem_command): Likewise.
 682         * valprint.c (value_print_option_defs): Likewise.
 683
 684 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 685
 686         PR build/24886
 687         * configure.ac: Drop enable-libmcheck support.
 688         * configure, config.in: Rebuild.
 689         * libmcheck.m4: Remove.
 690         * acinclude.m4: Don't include it.
 691         * Makefile.in: Don't distribute it.
 692         * top.c (print_gdb_configuration): Don't mention it.
 693
 694 2019-08-06  Tom Tromey  <tom@tromey.com>
 695
 696         * utils.c (set_output_style): Sometimes pass stream to
 697         emit_style_escape.
 698         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 699         * record-btrace.c (btrace_insn_history): Update.
 700         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 701         method.
 702         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 703         Update initializers.
 704         <m_uiout>: New field.
 705         <m_di>: Move lower.
 706         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 707         Remove "uiout" parameter.
 708         (dump_insns): Update.
 709         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 710         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 711
 712 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 713
 714         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 715         (error_in_psymtab_expansion): Likewise.
 716         (lookup_symbol_via_quick_fns): Likewise.
 717         (basic_lookup_transparent_type_quick): Likewise.
 718         (basic_lookup_transparent_type_1): Likewise.
 719
 720 2019-08-06  Tom Tromey  <tromey@adacore.com>
 721
 722         * source.c (last_source_error): Now bool.
 723         (print_source_lines_base): Make "noprint" bool.  Only open
 724         source file when last_source_visited changes.
 725
 726 2019-08-06  Tom Tromey  <tromey@adacore.com>
 727
 728         * annotate.c (annotate_source_line): Use g_source_cache.
 729         * source-cache.c (source_cache::get_plain_source_lines): Change
 730         parameters.  Populate m_offset_cache.
 731         (source_cache::ensure): New method.
 732         (source_cache::get_line_charpos): New method.
 733         (extract_lines): Move lower.  Change parameters.
 734         (source_cache::get_source_lines): Move lower.
 735         * source-cache.h (class source_cache): Update comment.
 736         <get_line_charpos>: New method.
 737         <get_source_lines>: Update comment.
 738         <clear>: Clear m_offset_cache.
 739         <get_plain_source_lines>: Change parameters.
 740         <ensure>: New method
 741         <m_offset_cache>: New member.
 742         * source.c (forget_cached_source_info_for_objfile): Update.
 743         (info_source_command): Use g_source_cache.
 744         (find_source_lines, open_source_file_with_line_charpos): Remove.
 745         (print_source_lines_base, search_command_helper): Use g_source_cache.
 746         * source.h (open_source_file_with_line_charpos): Don't declare.
 747         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 748         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 749         Use g_source_cache.
 750
 751 2019-08-06  Tom Tromey  <tromey@adacore.com>
 752
 753         * source-cache.c (source_cache::get_plain_source_lines):
 754         Remove "first_line" and "last_line" parameters.
 755         (source_cache::get_source_lines): Cache plain text.
 756         * source-cache.h (class source_cache)
 757         <get_plain_source_lines>: Update.
 758
 759 2019-08-06  Tom Tromey  <tromey@adacore.com>
 760
 761         * source-cache.c (extract_lines): No longer a method.
 762         Changed type of parameter.  Include final newline.
 763         (selftests::extract_lines_test): New function.
 764         (_initialize_source_cache): Likewise.
 765         * source-cache.h (class source_cache)
 766         <extract_lines>: Don't declare.
 767
 768 2019-08-06  Tom Tromey  <tromey@adacore.com>
 769
 770         * breakpoint.c (init_breakpoint_sal): Update.
 771         (breakpoint): Update.
 772         * breakpoint.h (struct breakpoint) <filter>: Now a
 773         unique_xmalloc_ptr.
 774
 775 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 776
 777         * NEWS: Mention dictionary access on blocks.
 778         * python/py-block.c (blpy_getitem): New function.
 779         (block_object_as_mapping): New struct.
 780         (block_object_type): Use new struct for tp_as_mapping field.
 781
 782 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 783
 784         * objfiles.h (objfile): Add a comment describing partial symbols.
 785
 786 2019-08-05  Tom Tromey  <tromey@adacore.com>
 787
 788         * compile/compile.c (_initialize_compile): Use _(), not N_().
 789         * thread.c (_initialize_thread): Use _(), not N_().
 790         * stack.c (_initialize_stack): Use _(), not N_().
 791         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 792
 793 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 794
 795         * dwarf2read.c (struct dw2_symtab_iterator):
 796         <want_specific_block>: Remove.
 797         <block_index>: Change type to gdb::optional.
 798         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 799         change type of BLOCK_INDEX parameter to gdb::optional.
 800         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 801         (dw2_lookup_symbol): Don't pass argument for
 802         WANT_SPECIFIC_BLOCK.
 803         (dw2_expand_symtabs_for_function): Don't pass argument for
 804         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 805         (class dw2_debug_names_iterator)
 806         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 807         parameter, change BLOCK_INDEX type to gdb::optional.
 808         <m_want_specific_block>: Remove.
 809         <m_block_index>: Change type to gdb::optional.
 810         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 811         gdb::optional.  Re-write in function of gdb::optional.
 812         (dw2_debug_names_lookup_symbol): Don't pass argument for
 813         WANT_SPECIFIC_BLOCK.
 814         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 815         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 816         BLOCK_INDEX.
 817
 818 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 819
 820         * NEWS: Mention changes to "info sources" command.
 821
 822 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 823
 824         * symtab.c (filename_partial_match_opts): New struct type.
 825         (struct output_source_filename_data): New members
 826         regexp, c_regexp, partial_match.
 827         (output_source_filename): Use new members to decide to print file.
 828         (info_sources_option_defs): New variable.
 829         (make_info_sources_options_def_group, print_info_sources_header,
 830         info_sources_command_completer):
 831         New functions.
 832         (info_sources_command): Read new optional arguments.
 833         (_initialize_symtab): Update info sources help.
 834
 835 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 836
 837         * ada-lang.c (exception_support_info_v0): Renamed from...
 838         (default_exception_support_info): ... this.  Create new
 839         definition for v1.
 840         (ada_has_this_exception_support): Look up catch_handlers_sym.
 841         (ada_exception_support_info_sniffer): Try v0 after default.
 842
 843 2019-08-01  Tom Tromey  <tromey@adacore.com>
 844
 845         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 846         gdbarch.h.
 847
 848 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 849
 850         * s12z-tdep.c: Fix include path for s12z-opc.h.
 851
 852 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 853
 854         * NEWS: Require GNU make 3.82.
 855
 856 2019-07-16  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 859         declare.
 860
 861 2019-07-30  Tom Tromey  <tromey@adacore.com>
 862
 863         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 864
 865 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 866
 867         * printcmd.c (print_address_symbolic): Print negative offsets.
 868         (build_address_symbolic): Force signed arithmetic when computing
 869         offset.
 870
 871 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 872
 873         PR/24474: Add a function to lookup static variables.
 874         * NEWS: Mention this new function.
 875         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 876         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 877         * python/python.c (python_GdbMethods): Add new function.
 878
 879 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 880
 881         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 882         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 883         (objfpy_lookup_static_symbol): New function.
 884         (objfile_object_methods): Add new functions.
 885
 886 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 887
 888         * NEWS: Mention 'set|show print frame-info'.  Mention new
 889         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 890         backtrace argument.  Mention that python frame filtering code
 891         is now consistent with what 'backtrace' command prints.
 892
 893 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 894
 895         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 896         comments.
 897         (print_frame_info_auto, print_frame_info_source_line,
 898         print_frame_info_location, print_frame_info_source_and_location,
 899         print_frame_info_location_and_address, print_frame_info_short_location):
 900         New declarations.
 901         (struct frame_print_options): New member print_frame_info.
 902         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 903         * stack.h (get_user_print_what_frame_info): New declaration.
 904         (frame_show_address): New declaration.
 905         * stack.c (print_frame_arguments_choices): New value 'presence'.
 906         (print_frame_info_auto, print_frame_info_source_line,
 907         print_frame_info_location, print_frame_info_source_and_location,
 908         print_frame_info_location_and_address, print_frame_info_short_location,
 909         print_frame_info_choices, print_frame_info_print_what): New definitions.
 910         (print_frame_args): Only print dots for args if print frame-arguments
 911         is 'presence'.
 912         (frame_print_option_defs): New element for "frame-info".
 913         (get_user_print_what_frame_info): New function.
 914         (frame_show_address): Make non static.  Move comment to stack.h.
 915         (print_frame_info_to_print_what): New function.
 916         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 917         to decide what to print.
 918         (backtrace_command_1): Handle the new print_frame_arguments_presence
 919         value.
 920         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 921         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 922         (py_print_frame): In non-mi mode, use LOCATION as default for
 923         print_what, similarly to frame information printed directly by
 924         backtrace command. Handle frame-info user option in non MI mode.
 925
 926 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 927
 928         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 929         Add case for debugging 32-bit target on 64-bit host.  Revise
 930         comment.
 931
 932 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 933
 934         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 935         instead of find_function_entry_range_from_pc.
 936
 937 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 938
 939         * stack.c (find_frame_funname): Remove code which preferred
 940         minsym over symtab sym in "certain pathological cases".
 941
 942         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 943         parameter.  Change type of "do_demangle" to bool.
 944         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 945         Pass suitable "prefer_sym_over_minsym" flag to
 946         build_address_symbolic().  Don't output "+" for negative offsets.
 947         * printcmd.c (print_address_symbolic): Update invocation of
 948         build_address_symbolic to include a "prefer_sym_over_minsym"
 949         flag.
 950         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 951         Restrict cases in which use of minimal symbol is preferred to that
 952         of a found symbol.  Update comments.
 953
 954         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 955         for entry pc when entry pc is out of range for that FDE.
 956
 957 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 958
 959         PR gdb/24839:
 960         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 961         type.
 962
 963 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 964
 965         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 966         this function's Python signature.
 967
 968
 969 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 970
 971         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 972         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 973         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 974         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 975         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 976
 977
 978 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 979
 980         * h8300-tdep.c (h8300_register_name_common): New.
 981         h8300_register_name): Use h8300_register_name_common.
 982         (h8300s_register_name): Likewise.
 983         (h8300sx_register_name): Likewise.
 984         (h8300h_register_nam): New.
 985         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 986
 987
 988 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 989
 990         * arm-tdep.c (arm_skip_cmse_entry): New function.
 991         (arm_is_sgstubs_section): New function.
 992         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 993
 994 2019-07-22  Tom Tromey  <tom@tromey.com>
 995
 996         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 997         Don't self-assign.
 998
 999 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1002         type_print.
1003
1004 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1005
1006         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1007         so that GDB doesn't match any msymbols when searching in the
1008         TYPES_DOMAIN.
1009         (print_symbol_info): Print using typedef_print or type_print based
1010         on the type of the symbol.  Add updated FIXME comment moved from...
1011         (_initialize_symtab): ... move and update FIXME comment to above.
1012
1013 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1014
1015         * NEWS: Mention adding -q option to "info types".
1016         * symtab.c (struct info_types_options): New struct.
1017         (info_types_options_defs): New variable.
1018         (make_info_types_options_def_group): New function.
1019         (info_types_command): Use gdb::option framework to parse options.
1020         (info_types_command_completer): New function.
1021         (_initialize_symtab): Extend the help text on "info types" and
1022         register command completer.
1023
1024 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1025
1026         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1027         (lookup_symbol_in_objfile): Change int to block_enum and add a
1028         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1029
1030 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1031
1032         * MAINTAINERS (Write After Approval): Add self.
1033
1034 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1035
1036         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1037         instruction to the dummy code region.
1038
1039 2019-07-19  Tom Tromey  <tromey@adacore.com>
1040
1041         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1042         (ARGSUSED, PARAMS, __func__): Remove rules.
1043
1044 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1045
1046         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1047         * features/arm/arm-with-iwmmxt.c: Remove.
1048         * features/arm/arm-with-iwmmxt.xml: Remove.
1049         * features/arm/arm-with-m-fpa-layout.c: Remove.
1050         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1051         * features/arm/arm-with-m-vfp-d16.c: Remove.
1052         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1053         * features/arm/arm-with-m.c: Remove.
1054         * features/arm/arm-with-m.xml: Remove.
1055         * features/arm/arm-with-neon.c: Remove.
1056         * features/arm/arm-with-neon.xml: Remove.
1057         * features/arm/arm-with-vfpv2.c: Remove.
1058         * features/arm/arm-with-vfpv2.xml: Remove.
1059         * features/arm/arm-with-vfpv3.c: Remove.
1060         * features/arm/arm-with-vfpv3.xml: Remove.
1061
1062 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1063
1064         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1065
1066 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1067
1068         * arch/aarch32.c (aarch32_create_target_description): Create
1069         target descriptions using features.
1070         * arch/arm.c (arm_create_target_description)
1071         (arm_create_mprofile_target_description): Likewise.
1072         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1073
1074 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1075
1076         * Makefile.in: Add new files.
1077         * aarch32-tdep.c: New file.
1078         * aarch32-tdep.h: New file.
1079         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1080         Call aarch32_read_description.
1081         * arch/aarch32.c: New file.
1082         * arch/aarch32.h: New file.
1083         * arch/arm.c (arm_create_target_description)
1084         (arm_create_mprofile_target_description): New function.
1085         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1086         (arm_create_target_description)
1087         (arm_create_mprofile_target_description): New declaration.
1088         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1089         read_description functions.
1090         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1091         Likewise.
1092         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1093         * arm-tdep.c (tdesc_arm_list): New variable.
1094         (arm_register_g_packet_guesses): Call create description functions.
1095         (arm_read_description) (arm_read_mprofile_description): New
1096         function.
1097         * arm-tdep.h (arm_read_description)
1098         (arm_read_mprofile_description): Add declaration.
1099         * configure.tgt: Add new files.
1100
1101 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1102
1103         * top.c (new_ui_command): Open specified terminal just once.
1104
1105 2019-07-18  Tom Tromey  <tromey@adacore.com>
1106
1107         * symtab.c (main_name): Constify return type.
1108         * symfile.c (set_initial_language): Update.
1109         * symtab.h (main_name): Constify return type.
1110
1111 2019-07-17  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui-winsource.c (tui_update_source_window)
1114         (tui_update_source_window_as_is)
1115         (tui_update_source_windows_with_line): Remove return.
1116         * tui/tui-disasm.c (tui_show_disassem)
1117         (tui_show_disassem_and_update_source): Remove return.
1118         * tui/tui.c (tui_reset): Remove return.
1119         * tui/tui-wingeneral.c
1120         (tui_check_and_display_highlight_if_needed): Remove return.
1121
1122 2019-07-17  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1125
1126 2019-07-17  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-winsource.h (struct tui_exec_info_window)
1129         (struct tui_source_window_base): Move from tui-data.h.
1130         * tui/tui-winsource.c: Move many method definitions from
1131         elsewhere.  Remove "structuring" comments.
1132         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1133         (tui_source_window_base::refresh_window): Move to
1134         tui-winsource.c.
1135         * tui/tui-win.c (tui_source_window_base::refresh_all)
1136         (tui_source_window_base::update_tab_width)
1137         (tui_source_window_base::set_new_height)
1138         (tui_source_window_base::do_make_visible_with_new_height): Move to
1139         tui-winsource.c.
1140         * tui/tui-source.h: Update.
1141         * tui/tui-source.c (tui_source_window_base::reset): Move to
1142         tui-winsource.c.
1143         * tui/tui-disasm.h: Update.
1144         * tui/tui-data.h (struct tui_exec_info_window): Move to
1145         tui-winsource.h.
1146         (struct tui_source_window_base): Likewise.
1147         * tui/tui-data.c (tui_source_window_base::clear_detail)
1148         (tui_source_window_base, ~tui_source_window_base): Move to
1149         tui-winsource.c.
1150
1151 2019-07-17  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-win.c (tui_resize_all)
1154         (tui_source_window_base::update_tab_width)
1155         (tui_adjust_win_heights): Update.
1156         (tui_win_info::make_invisible_and_set_new_height): Rename from
1157         make_invisible_and_set_new_height.
1158         * tui/tui-data.h (struct tui_win_info)
1159         <make_invisible_and_set_new_height>: New method.
1160
1161 2019-07-17  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui.c: Update.
1164         * tui/tui-source.h (struct tui_source_window): Move from
1165         tui-data.h.
1166         * tui/tui-layout.c: Update.
1167         * tui/tui-disasm.c: Update.
1168         * tui/tui-data.h (struct tui_source_window): Move to
1169         tui-source.h.
1170
1171 2019-07-17  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1174         tui-data.h.
1175         * tui/tui-data.h (struct tui_disasm_window): Move to
1176         tui-disasm.h.
1177
1178 2019-07-17  Tom Tromey  <tom@tromey.com>
1179
1180         * tui/tui-regs.h (struct tui_data_item_window): Move from
1181         tui-data.h.
1182         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1183         * tui/tui-data.h (struct tui_data_item_window): Move to
1184         tui-regs.h.
1185         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1186
1187 2019-07-17  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui.c: Update.
1190         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1191         (tui_cmd_window::max_height): Move to tui-command.c.
1192         * tui/tui-layout.c: Update.
1193         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1194         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1195         tui-command.c.
1196         * tui/tui-command.h (struct tui_cmd_window): Move from
1197         tui-data.h.
1198         * tui/tui-command.c: Remove "structuring" comments.
1199         (tui_cmd_window::clear_detail)
1200         (tui_cmd_window::do_make_visible_with_new_height)
1201         (tui_cmd_window::max_height): Move from elsewhere.
1202
1203 2019-07-17  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1206         Now static.
1207         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1208         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1209
1210 2019-07-17  Tom Tromey  <tom@tromey.com>
1211
1212         * tui/tui.c: Update.
1213         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1214         tui-regs.c.
1215         * tui/tui-windata.h: Remove file.
1216         * tui/tui-windata.c: Remove file.
1217         * tui/tui-win.c (tui_data_window::set_new_height)
1218         (tui_data_window::do_make_visible_with_new_height): Move to
1219         tui-regs.c.
1220         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1221         * tui/tui-regs.c: Remove "structuring" comments.
1222         (tui_data_window::first_data_item_displayed)
1223         (tui_data_window::delete_data_content_windows)
1224         (tui_data_window::erase_data_content)
1225         (tui_data_window::display_all_data)
1226         (tui_data_window::refresh_all)
1227         (tui_data_window::do_scroll_vertical)
1228         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1229         (tui_data_window::do_make_visible_with_new_height)
1230         (tui_data_window::refresh_window): Move from elsewhere.
1231         (_initialize_tui_regs): Move to end of file.
1232         * tui/tui-layout.c: Update.
1233         * tui/tui-hooks.c: Update.
1234         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1235         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1236         tui-regs.c.
1237         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1238
1239 2019-07-17  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1242         seen.
1243
1244 2019-07-17  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui-win.c (tui_source_window_base::set_new_height)
1247         (tui_source_window_base::do_make_visible_with_new_height): Use
1248         m_has_locator field directly.
1249         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1250         method.
1251         (struct tui_source_window_base) <has_locator>: Likewise.
1252
1253 2019-07-17  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1256         Don't declare.
1257         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1258         Remove.
1259         * tui/tui-win.c (tui_source_window_base::set_new_height)
1260         (tui_source_window_base::set_new_height)
1261         (make_invisible_and_set_new_height)
1262         (tui_source_window_base::do_make_visible_with_new_height)
1263         (tui_source_window_base::do_make_visible_with_new_height):
1264         Update.
1265         * tui/tui-layout.c (show_source_disasm_command, show_data)
1266         (show_source_or_disasm_and_command): Update.
1267         * tui/tui-layout.c (show_layout): Update.
1268
1269 2019-07-17  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-layout.c (make_data_window): Remove.
1272         (show_data): Unify creation and re-initialization cases.
1273
1274 2019-07-17  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-layout.c (make_source_window, make_disasm_window):
1277         Remove.
1278         (show_data): Unify creation and re-initialization cases.
1279
1280 2019-07-17  Tom Tromey  <tom@tromey.com>
1281
1282         * tui/tui-layout.c (make_command_window): Remove.
1283         (show_source_disasm_command, show_source_or_disasm_and_command):
1284         Unify creation and re-initialization cases.
1285
1286 2019-07-17  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1289         creation and re-initialization cases.
1290
1291 2019-07-17  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-regs.c (tui_get_register): Return void.
1294
1295 2019-07-17  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1298         Simplify.
1299
1300 2019-07-17  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1303         resetting.
1304
1305 2019-07-17  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1308         * tui/tui-regs.c (tui_reg_layout): New function.
1309         (tui_show_registers, tui_reg_command): Use it.
1310         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1311         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1312         parameters.
1313         (tui_layout_command): Remove.
1314
1315 2019-07-17  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-layout.h (tui/tui-layout): Return void.
1318         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1319
1320 2019-07-17  Tom Tromey  <tom@tromey.com>
1321
1322         * tui/tui-layout.c (show_source_disasm_command, show_data):
1323         Update.
1324         (reset_locator): Remove.
1325         (show_source_or_disasm_and_command): Update.
1326
1327 2019-07-17  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-source.c (tui_source_window_base::reset): Remove
1330         win_type parameter.
1331         * tui/tui-layout.c (make_command_window, make_source_window)
1332         (make_disasm_window, make_data_window)
1333         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1334         (reset_locator, show_source_or_disasm_and_command): Update.
1335         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1336         win_type parameter.
1337         (struct tui_source_window_base) <reset>: Likewise.
1338
1339 2019-07-17  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-layout.c (show_source_disasm_command): Use
1342         reset_locator.
1343         (reset_locator): New function.
1344         (init_and_make_win): Remove.
1345         (show_source_or_disasm_and_command): Use reset_locator.
1346
1347 2019-07-17  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1350         condition.
1351         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1352         Remove condition.
1353         * tui/tui-source.c (tui_source_window_base::reset): New method.
1354         * tui/tui-layout.c (make_command_window): Don't call
1355         init_and_make_win.
1356         (make_source_window, make_disasm_window): Don't call
1357         make_source_or_disasm_window.
1358         (make_data_window): Don't call init_and_make_win.  Change calling
1359         convention.
1360         (show_source_disasm_command, show_data): Simplify.
1361         (make_source_or_disasm_window): Remove.
1362         (show_source_or_disasm_and_command): Simplify.
1363         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1364         (struct tui_source_window_base) <reset>: Likewise.
1365         <execution_info>: Remove initializer.
1366         * tui/tui-data.c (tui_source_window_base): Initialize
1367         execution_info.
1368
1369 2019-07-17  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1372         variable.
1373
1374 2019-07-17  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui.c (tui_rl_other_window): Update.
1377         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1378         superclass method first.  Always iterate over regs_content.
1379         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1380         method.
1381         * tui/tui-win.c (tui_set_focus_command): Update.
1382
1383 2019-07-17  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-win.c (tui_set_focus_command): Rename from
1386         tui_set_focus.  Call tui_enable.
1387         (tui_set_focus_command): Remove.
1388
1389 2019-07-17  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1392         refresh_window.
1393         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1394         touchwin.
1395         (tui_data_window::refresh_window): Call refresh_window on data
1396         items.  Always call superclass refresh_window.
1397         (tui_win_info::refresh): Remove.
1398         (tui_source_window_base::refresh_window): Update.
1399         (tui_refresh_all): Update.
1400         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1401         refresh_window.
1402         (show_source_or_disasm_and_command): Likewise.
1403         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1404         (struct tui_source_window_base) <refresh>: Likewise.
1405
1406 2019-07-17  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-winsource.c (tui_clear_source_content)
1409         (tui_show_source_content): Update.
1410         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1411         whether content is empty.
1412         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1413         Remove.
1414
1415 2019-07-17  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1418         window's contents.
1419         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1420         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1421
1422 2019-07-17  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1425         (struct tui_data_item_window): Update.
1426
1427 2019-07-17  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1430         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1431         defines.
1432
1433 2019-07-17  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-winsource.h (tui_erase_source_content)
1436         (tui_clear_source_content): Remove "display_prompt" parameter.
1437         * tui/tui-winsource.c (tui_update_source_window_as_is)
1438         (tui_update_source_windows_with_addr): Update.
1439         (tui_clear_source_content): Remove "display_prompt" parameter.
1440         (tui_erase_source_content): Likewise.  Simplify.
1441         (tui_show_source_content): Update.
1442         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1443         * tui/tui-stack.c (tui_show_frame_info): Update.
1444         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1445         Remove defines.
1446
1447 2019-07-17  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1450         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1451         parameter.
1452         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1453         parameter.
1454
1455 2019-07-17  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-winsource.c (tui_clear_source_content)
1458         (tui_show_source_content, tui_show_exec_info_content)
1459         (tui_clear_exec_info_content): Update.
1460         * tui/tui-stack.c (tui_show_locator_content): Update.
1461         (tui_show_frame_info): Update.
1462         * tui/tui-source.h (tui_source_window): Don't declare.
1463         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1464         from tui_source_is_displayed.
1465         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1466         Remove field.
1467         (struct tui_source_window_base) <content_in_use>: New field.  Now
1468         bool.
1469         (struct tui_source_window) <showing_source_p>: New method.
1470         (TUI_SRC_WIN): Change cast.
1471         * tui/tui-data.c (tui_initialize_static_data): Update.
1472
1473 2019-07-17  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1476         location_matches_p.
1477         * tui/tui-source.c (tui_source_window::location_matches_p): New
1478         method.
1479         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1480         method.
1481         * tui/tui-data.h (struct tui_source_window_base)
1482         <location_matches_p>: New method.
1483         (struct tui_source_window, struct tui_disasm_window)
1484         <location_matches_p>: Likewise.
1485
1486 2019-07-17  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-win.c (tui_set_win_height_command): Rename from
1489         tui_set_win_height.
1490         (tui_set_win_height_command): Remove.
1491
1492 2019-07-17  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-source.c (tui_source_window): New constructor.  Add
1495         observer.
1496         (~tui_source_window): New destructor.
1497         (tui_source_window::style_changed): New method.
1498         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1499         (tui_attach_detach_observers): Update.
1500         * tui/tui-data.h (struct tui_source_window): Make constructor not
1501         inline.  Add destructor.
1502         (struct tui_source_window) <style_changed>: New method.
1503         <m_observable>: New member.
1504
1505 2019-07-17  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1508         * tui/tui-win.c (tui_resize_all): Fix typo.
1509
1510 2019-07-17  Tom Tromey  <tom@tromey.com>
1511
1512         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1513         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1514         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1515         * tui/tui-win.c (window_name_completer): Use foreach.
1516         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1517         (update_tab_width): Likewise.
1518         * tui/tui-layout.c (show_layout): Update.
1519         * tui/tui-data.h (class tui_window_iterator): New.
1520         (struct all_tui_windows): New.
1521         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1522
1523 2019-07-17  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1526         parameter.  Don't reference globals.
1527         (tui_reg_command): Update.
1528
1529 2019-07-17  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-regs.c (tui_show_registers): Simplify.
1532
1533 2019-07-17  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-regs.c (tui_show_registers): Update.
1536         (tui_show_register_group): Add win_info parameter.
1537
1538 2019-07-17  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1541         Rename from tui_display_reg_element_at_line.
1542         (tui_data_window::display_registers_from_line): Update.
1543         * tui/tui-data.h (struct tui_data_window)
1544         <display_reg_element_at_line>: New method.
1545
1546 2019-07-17  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-regs.h (tui_display_registers_from)
1549         (tui_display_registers_from_line): Don't declare.
1550         * tui/tui-windata.c (tui_data_window::display_all_data)
1551         (tui_data_window::refresh_all)
1552         (tui_data_window::do_scroll_vertical): Update.
1553         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1554         from tui_display_registers_from.
1555         (tui_display_reg_element_at_line): Update.
1556         (tui_data_window::display_registers_from_line): Rename from
1557         tui_display_registers_from_line.
1558         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1559         display_registers_from_line>: New methods.
1560
1561 2019-07-17  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1564         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1565         from tui_erase_data_content.
1566         (tui_data_window::display_all_data)
1567         (tui_data_window::refresh_all)
1568         (tui_data_window::do_scroll_vertical): Update.
1569         * tui/tui-regs.c (tui_show_registers): Update.
1570         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1571         New method.
1572
1573 2019-07-17  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1576         declare.
1577         * tui/tui-windata.c
1578         (tui_data_window::delete_data_content_windows): Rename from
1579         tui_delete_data_content_windows.
1580         (tui_data_window::display_all_data)
1581         (tui_data_window::do_scroll_vertical): Update.
1582         * tui/tui-data.h (struct tui_data_window)
1583         <delete_data_content_windows>: New method.
1584
1585 2019-07-17  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1588         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1589
1590 2019-07-17  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1593         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1594         from tui_display_all_data.
1595         * tui/tui-win.c
1596         (tui_data_window::do_make_visible_with_new_height): Update.
1597         * tui/tui-regs.c (tui_show_registers): Update.
1598         * tui/tui-layout.c (tui_set_layout): Update.
1599         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1600         method.
1601
1602 2019-07-17  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1605         * tui/tui-windata.c (tui_display_data_from): Remove.
1606         (tui_data_window::refresh_all): Update.
1607
1608 2019-07-17  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1611         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1612         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1613         tui_display_registers_from_line.
1614         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1615         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1616         "force_display" parameter.
1617
1618 2019-07-17  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1621         declare.
1622         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1623         Rename from tui_first_reg_element_no_inline.
1624         (tui_display_reg_element_at_line)
1625         (tui_display_registers_from_line): Update.
1626         * tui/tui-data.h (struct tui_data_window)
1627         <first_reg_element_no_inline>: New method.
1628
1629 2019-07-17  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-windata.c (tui_display_data_from)
1632         (tui_data_window::do_scroll_vertical): Update.
1633         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1634         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1635         Rename from tui_line_from_reg_element_no.
1636         (tui_display_registers_from_line): Update.
1637         * tui/tui-data.h (struct tui_data_window)
1638         <line_from_reg_element_no>: New method.
1639
1640 2019-07-17  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1643         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1644         tui_last_regs_line_no.
1645         (tui_display_reg_element_at_line)
1646         (tui_display_registers_from_line): Update.
1647         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1648         method.
1649
1650 2019-07-17  Tom Tromey  <tom@tromey.com>
1651
1652         PR tui/24722:
1653         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1654         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1655         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1656         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1657         (tui_update_breakpoint_info): Likewise.
1658         * tui/tui-hooks.c (tui_event_create_breakpoint)
1659         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1660         Update.
1661
1662 2019-07-17  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1665
1666 2019-07-17  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-winsource.c (tui_update_source_window_as_is)
1669         (tui_update_source_windows_with_addr): Update.
1670         * tui/tui-source.h (tui_set_source_content)
1671         (tui_show_symtab_source): Add "win_info" parameter.
1672         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1673         parameter.
1674         (tui_show_symtab_source): Likewise.
1675
1676 2019-07-17  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-wingeneral.c
1679         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1680
1681 2019-07-17  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1684         (struct tui_cmd_window) <can_scroll>: New method.
1685         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1686         method.
1687
1688 2019-07-17  Tom Tromey  <tromey@adacore.com>
1689
1690         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1691         do_field_signed>: Rename.  Change type of "value".
1692         * ui-out.c (ui_out::field_signed): Rename from field_int.
1693         Change type of "value".
1694         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1695         type of "value".
1696         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1697         do_field_int.  Change type of "value".
1698         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1699         do_field_int.  Change type of "value".
1700         * tracepoint.c (trace_status_mi, tfind_1)
1701         (print_one_static_tracepoint_marker): Update.
1702         * thread.c (print_thread_info_1, print_selected_thread_frame):
1703         Update.
1704         * stack.c (print_frame, print_frame_info): Update.
1705         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1706         Update.
1707         * source.c (print_source_lines_base): Update.
1708         * skip.c (info_skip_command): Update.
1709         * record-btrace.c (btrace_ui_out_decode_error)
1710         (btrace_call_history_src_line): Update.
1711         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1712         Update.
1713         * progspace.c (print_program_space): Update.
1714         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1715         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1716         do_field_int.  Change type of "value".
1717         * mi/mi-out.c (mi_ui_out::do_table_begin)
1718         (mi_ui_out::do_table_header): Update.
1719         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1720         type of "value".
1721         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1722         (mi_cmd_data_list_changed_registers, output_register)
1723         (mi_cmd_data_read_memory, mi_load_progress)
1724         (mi_cmd_trace_frame_collected): Update.
1725         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1726         Update.
1727         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1728         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1729         (mi_cmd_var_list_children, varobj_update_one): Update.
1730         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1731         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1732         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1733         * inferior.c (print_inferior): Update.
1734         * gdb_bfd.c (print_one_bfd): Update.
1735         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1736         Update.
1737         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1738         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1739         do_field_int.  Change type of "value".
1740         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1741         do_field_int.  Change type of "value".
1742         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1743         (print_one_breakpoint_location, print_it_catch_fork)
1744         (print_one_catch_fork, print_it_catch_vfork)
1745         (print_one_catch_vfork, print_it_catch_solib)
1746         (print_it_catch_exec, print_it_ranged_breakpoint)
1747         (print_mention_watchpoint, print_mention_masked_watchpoint)
1748         (bkpt_print_it, update_static_tracepoint): Update.
1749         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1750         * break-catch-syscall.c (print_it_catch_syscall): Update.
1751         * ada-tasks.c (print_ada_task_info): Update.
1752         * ada-lang.c (print_it_exception, print_mention_exception):
1753         Update.
1754
1755 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         PR breakpoints/24541
1758         * gdbarch.c: Regenerate.
1759         * gdbarch.h: Regenerate.
1760         * gdbarch.sh: Adjust return type and parameter types for
1761         'stap_adjust_register'.
1762         (i386_stap_adjust_register): Adjust signature and return new
1763         register name.
1764         * stap-probe.c (stap_parse_register_operand): Adjust use of
1765         'gdbarch_stap_adjust_register'.
1766
1767 2019-07-17  Tom Tromey  <tromey@adacore.com>
1768
1769         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1770         declare VEC.
1771         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1772         std::vector.
1773         (struct s390_process_info): Add initializers.
1774         (s390_add_process): Use new.
1775         (s390_linux_nat_target::low_forget_process): Use delete.
1776         (s390_linux_nat_target::low_new_fork)
1777         (s390_linux_nat_target::stopped_by_watchpoint)
1778         (s390_linux_nat_target::low_prepare_to_resume)
1779         (s390_linux_nat_target::insert_watchpoint)
1780         (s390_linux_nat_target::insert_hw_breakpoint)
1781         (s390_linux_nat_target::remove_watchpoint)
1782         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1783
1784 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1785
1786         * aarch64-fbsd-nat.c: Include regcache.h.
1787         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1788         argument.
1789         (aarch64_fbsd_nat_target::fetch_registers)
1790         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1791         variable.
1792         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1793
1794 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1795
1796         * fbsd-nat.c: Include gdbarch.h.
1797
1798 2019-07-15  Tom Tromey  <tromey@adacore.com>
1799
1800         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1801
1802 2019-07-15  Tom Tromey  <tromey@adacore.com>
1803
1804         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1805         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1806         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1807         * cli-out.c (cli_ui_out::do_field_int): New method.
1808         * ui-out.c (ui_out::field_unsigned): New method.
1809         * symfile.c (generic_load): Use field_unsigned.
1810         (print_transfer_performance): Likewise.
1811         * record-btrace.c (ui_out_field_uint): Remove.
1812         (btrace_call_history_insn_range, btrace_call_history): Use
1813         field_unsigned.
1814         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1815         field_unsigned.
1816         * ui-out.h (class ui_out) <field_unsigned>: New method.
1817         <do_field_unsigned>: Likewise.
1818
1819 2019-07-15  Tom Tromey  <tromey@adacore.com>
1820
1821         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1822         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1823         * target.c (flash_erase_command): Use field_string.
1824         * infrun.c (print_signal_received_reason): Use field_string.
1825         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1826         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1827         field_string.
1828         * ada-tasks.c (print_ada_task_info): Use field_string.
1829
1830 2019-07-15  Tom Tromey  <tromey@adacore.com>
1831
1832         * target.c (flash_erase_command): Use field_core_addr.
1833         * symfile.c (generic_load): Use field_core_addr.
1834         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1835         Use field_core_addr.
1836         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1837         field_core_addr.
1838
1839 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1840
1841         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1842         value if its desired type is smaller than a CORE_ADDR and signed.
1843
1844 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1845
1846         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1847         of changes to field names, and use new is_reference field to
1848         decide if a property is a reference or not.
1849         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1850         field.
1851         (struct dwarf2_property_baton): Update header comment, rename
1852         'referenced_type' to 'property_type' and update comments.
1853         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1854         default property type, store in property baton, update to take
1855         accound of renamed field.
1856         (read_func_scope): Update call to attr_to_dynamic_prop.
1857         (read_array_type): Likewise.
1858         (dwarf2_per_cu_addr_sized_int_type): New function.
1859         (read_subrange_index_type): Move type finding code to
1860         dwarf2_per_cu_addr_sized_int_type.
1861         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1862         (dwarf2_per_cu_addr_type): New function.
1863         (set_die_type): Update calls to attr_to_dynamic_prop.
1864
1865 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1866
1867         * dwarf2read.c (read_subrange_index_type): New function.
1868         (read_subrange_type): Move code into new function and call it.
1869         * gdbtypes.c (create_range_type): Add some asserts.
1870
1871 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1872
1873         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1874         update return statements.
1875         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1876         declaration, and update comment to match.
1877         * gdbtypes.c (resolve_dynamic_array): Update call to
1878         dwarf2_evaluate_property to match new return type.
1879
1880 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1881
1882         * valarith.c (value_subscripted_rvalue): Change lowerbound
1883         parameter type from int to LONGEST.
1884         * value.h (value_subscripted_rvalue): Likewise in declaration.
1885
1886 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1887
1888         * cli/cli-utils.c (info_print_command_completer): New function.
1889         * cli/cli-utils.h: Add 'completer.h' include, and forward
1890         declaration for 'struct cmd_list_element'.
1891         (info_print_command_completer): Declare.
1892         * stack.c (_initialize_stack): Add completer for 'info locals' and
1893         'info args'.
1894         * symtab.c (_initialize_symtab): Add completer for 'info
1895         variables' and 'info functions'.
1896         * NEWS: Mention completion for additional info commands.
1897
1898 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         * cli/cli-utils.c (extract_info_print_args): Delete.
1901         (extract_arg_maybe_quoted): Delete.
1902         (info_print_options_defs): New variable.
1903         (make_info_print_options_def_group): New function.
1904         (extract_info_print_options): Define new function.
1905         * cli/cli-utils.h (extract_info_print_args): Delete.
1906         (struct info_print_options): New structure.
1907         (extract_info_print_options): Declare new function.
1908         * stack.c (info_locals_command): Update to use new
1909         extract_info_print_options, also add a header comment.
1910         (info_args_command): Likewise.
1911         * symtab.c (info_variables_command): Likewise.
1912         (info_functions_command): Likewise.
1913
1914 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1915
1916         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1917         to extract string arguments.
1918         * common/common-utils.c (extract_string_maybe_quoted): New function.
1919         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1920
1921 2019-07-11  Tom Tromey  <tromey@adacore.com>
1922
1923         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1924         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1925         * top.h (gdbinit): Don't declare.
1926         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1927         into...
1928         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1929         * top.c (gdb_init): Don't call init_cli_cmds.
1930         (gdbinit): Remove.
1931         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1932
1933 2019-07-11  Tom Tromey  <tromey@adacore.com>
1934
1935         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1936         after it has been moved.
1937
1938 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1939
1940         * valops.c (value_must_coerce_to_target): Change return type to
1941         bool.
1942         * value.h (value_must_coerce_to_target): Likewise.
1943
1944 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1945
1946         * breakpoint.c (is_hardware_watchpoint): Remove
1947         forward-declaration.
1948         (is_masked_watchpoint): Change return type to bool.
1949         (is_tracepoint): Likewise.
1950         (is_breakpoint): Likewise.
1951         (is_hardware_watchpoint): Likewise.
1952         (is_watchpoint): Likewise.
1953         (is_no_memory_software_watchpoint): Likewise.
1954         (is_catchpoint): Likewise.
1955         (breakpoint_1): Make FILTER parameter's return type bool.
1956         is_masked_watchpoint): Change return type to bool.
1957         (save_breakpoints): Make FILTER parameter's return type bool.
1958         * breakpoint.h (is_breakpoint): Change return type to bool.
1959         (is_watchpoint): Likewise.
1960         (is_catchpoint): Likewise.
1961         (is_tracepoint): Likewise.
1962
1963 2019-07-10  Tom Tromey  <tom@tromey.com>
1964
1965         * defs.h: Don't include gdbarch.h.
1966         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1967         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1968         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1969         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1970         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1971         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1972         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1973         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1974         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1975         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1976         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1977         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1978         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1979         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1980         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1981         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1982         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1983         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1984         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1985         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1986         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1987         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1988         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1989         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1990         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1991         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1992         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1993
1994 2019-07-10  Tom Tromey  <tromey@adacore.com>
1995
1996         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1997         * breakpoint.c (init_ada_exception_breakpoint): Register as
1998         bp_catchpoint.
1999         (print_one_breakpoint_location, print_one_breakpoint): Use
2000         is_ada_exception_catchpoint.
2001         * ada-lang.c (class ada_catchpoint_location): Pass
2002         bp_loc_software_breakpoint to bp_location constructor.
2003         (is_ada_exception_catchpoint): New function.
2004
2005 2019-07-10  Tom Tromey  <tromey@adacore.com>
2006
2007         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2008         VEC.
2009         (struct arm_exidx_entry): New method operator<.
2010         (struct arm_exidx_data) <section_maps>: Change type.
2011         (arm_exidx_data_free): Remove.
2012         (arm_exidx_data_key): Change type.  Move lower.
2013         (arm_exidx_new_objfile): Update.
2014         (arm_compare_exidx_entries): Remove.
2015         (arm_find_exidx_entry, _initialize_arm_tdep)
2016
2017 2019-07-10  Tom Tromey  <tromey@adacore.com>
2018
2019         * solib-spu.c (ocl_program_data_key): Change type.
2020         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2021         Update.
2022
2023 2019-07-10  Tom Tromey  <tromey@adacore.com>
2024
2025         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2026         (struct solib_aix_inferior_data) <library_list>: Change type.
2027         (solib_aix_inferior_data_handle): Change type.
2028         (get_solib_aix_inferior_data): Update.
2029         (solib_aix_free_library_list): Remove.
2030         (library_list_start_library): Update.
2031         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2032         return type.
2033         (solib_aix_get_library_list)
2034         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2035         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2036
2037 2019-07-10  Tom Tromey  <tromey@adacore.com>
2038
2039         * solib-dsbt.c (struct dsbt_info): Add initializers.
2040         (solib_dsbt_pspace_data): Change type.
2041         (dsbt_pspace_data_cleanup): Remove.
2042         (get_dsbt_info, _initialize_dsbt_solib): Update.
2043
2044 2019-07-10  Tom Tromey  <tromey@adacore.com>
2045
2046         * spu-tdep.c (spu_overlay_data): Change type.
2047         (spu_get_overlay_table, spu_overlay_new_objfile)
2048         (_initialize_spu_tdep): Update.
2049
2050 2019-07-10  Tom Tromey  <tromey@adacore.com>
2051
2052         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2053         destructor.
2054         (dbx_objfile_data_key): Change type and declare later.
2055         (DBX_SYMFILE_INFO): Rewrite.
2056         * dbxread.c (dbx_objfile_data_key): Change type.
2057         (dbx_symfile_init): Update.
2058         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2059         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2060         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2061
2062 2019-07-10  Tom Tromey  <tromey@adacore.com>
2063
2064         * jit.c (jit_program_space_key): Change type.  Move lower.
2065         (get_jit_program_space_data): Update.
2066         (jit_program_space_data_cleanup): Remove.
2067         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2068         Update.
2069         (struct jit_program_space_data): Add initializers.
2070
2071 2019-07-10  Tom Tromey  <tromey@adacore.com>
2072
2073         * solib-darwin.c (struct darwin_info): Add initializers.
2074         (solib_darwin_pspace_data): Change type.
2075         (darwin_pspace_data_cleanup): Remove.
2076         (get_darwin_info, _initialize_darwin_solib): Update.
2077
2078 2019-07-10  Tom Tromey  <tromey@adacore.com>
2079
2080         * remote-sim.c (struct sim_inferior_data): Add initializers,
2081         constructor, and destructor.
2082         (sim_inferior_data_key): Change type.  Move lower.
2083         (check_for_duplicate_sim_descriptor): Update.
2084         (get_sim_inferior_data): Use new.  Update.
2085         (~sim_inferior_data_cleanup): Rename from
2086         sim_inferior_data_cleanup.  Simplify.
2087         (gdbsim_close_inferior, simulator_command)
2088         (sim_command_completer, _initialize_remote_sim): Update.
2089         (next_pid, INITIAL_PID): Move earlier.
2090
2091 2019-07-10  Tom Tromey  <tromey@adacore.com>
2092
2093         * python/python-internal.h (create_thread_object): Return
2094         gdbpy_ref.
2095         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2096         * python/py-inferior.c (struct threadlist_entry): Add
2097         constructor.
2098         <thread_obj>: Now a gdbpy_ref.
2099         (thread_to_thread_object): Update.
2100         (add_thread_object): Use new.
2101         (delete_thread_object): Use delete.
2102         (infpy_threads): Update.
2103         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2104         GIL.
2105
2106 2019-07-10  Tom Tromey  <tromey@adacore.com>
2107
2108         * valops.c (value_cast): Specialize error message for Ada.
2109
2110 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2111
2112         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2113
2114 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2115
2116         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2117         bpstat_should_step): Return bool, adjust comments.
2118         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2119         bpstat_should_step): Likewise.
2120
2121 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2122
2123         * features/Makefile: Use feature target descriptions for Arm.
2124         * features/arm/arm-core.c: Generate new file.
2125         * features/arm/arm-fpa.c: Likewise.
2126         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2127         * features/arm/arm-m-profile.c: Likewise.
2128         * features/arm/arm-vfpv2.c: Likewise.
2129         * features/arm/arm-vfpv3.c: Likewise.
2130         * features/arm/xscale-iwmmxt.c: Likewise.
2131         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2132
2133 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2134
2135         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2136         ptrace earlier.
2137
2138 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2139
2140         * features/aarch64-pauth.c: Regenerate.
2141
2142 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2143
2144         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2145         bool.
2146         (bpstat_what): Use false instead of 0.
2147
2148 2019-07-09  Pedro Alves  <palves@redhat.com>
2149
2150         * break-catch-throw.c (is_exception_catchpoint): New.
2151         * breakpoint.c (print_one_breakpoint_location): New parameter
2152         'raw_loc'.  Handle it.  Use
2153         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2154         looking at the breakpoint's type.
2155         (print_one_breakpoint): If handling "maint info breakpoints", also
2156         print locations of exception catchpoints.
2157         * breakpoint.h (is_exception_catchpoint): Declare.
2158
2159 2019-07-09  Pedro Alves  <palves@redhat.com>
2160
2161         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2162         "addr" field.
2163         (allocate_location_exception_catchpoint): New.
2164         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2165         (initialize_throw_catchpoint_ops): Install
2166         allocate_location_exception_catchpoint as allocate_location
2167         method.
2168         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2169         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2170         bp_loc_other.
2171         (breakpoint_address_is_meaningful): Delete.
2172         (bl_address_is_meaningful): New.
2173         (breakpoint_locations_match): Adjust comment.
2174         (bp_location_from_bp_type): New, factored out of...
2175         (bp_location::bp_location(breakpoint *)): ... this.
2176         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2177         factored out of...
2178         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2179         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2180         breakpoint_address_is_meaningful.
2181         (bp_locations_compare): Adjust comment.
2182         (update_global_location_list): Use bl_address_is_meaningful
2183         instead of breakpoint_address_is_meaningful.
2184         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2185         explicit.
2186         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2187         * python/py-breakpoint.c (bppy_get_location): No longer check
2188         whether location is null.
2189
2190 2019-07-09  Pedro Alves  <palves@redhat.com>
2191
2192         PR c++/15468
2193         * breakpoint.c (print_one_breakpoint_location): Remove
2194         single-location assert.
2195
2196 2019-07-09  Tom Tromey  <tom@tromey.com>
2197
2198         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2199         * configure: Rebuild.
2200         * configure.ac: Change common to gdbsupport.
2201         * gdbsupport: Rename from common.
2202         * acinclude.m4: Change common to gdbsupport.
2203         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2204         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2205         gdbsupport.
2206         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2207         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2208         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2209         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2210         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2211         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2212         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2213         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2214         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2215         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2216         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2217         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2218         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2219         coff-pe-read.c, command.h, compile/compile-c-support.c,
2220         compile/compile-c.h, compile/compile-cplus-symbols.c,
2221         compile/compile-cplus-types.c, compile/compile-cplus.h,
2222         compile/compile-loc2c.c, compile/compile.c, completer.c,
2223         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2224         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2225         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2226         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2227         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2228         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2229         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2230         features/aarch64-core.c, features/aarch64-fpu.c,
2231         features/aarch64-pauth.c, features/aarch64-sve.c,
2232         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2233         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2234         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2235         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2236         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2237         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2238         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2239         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2240         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2241         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2242         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2243         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2244         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2245         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2246         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2247         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2248         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2249         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2250         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2251         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2252         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2253         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2254         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2255         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2256         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2257         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2258         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2259         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2260         minsyms.c, mips-linux-tdep.c, namespace.h,
2261         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2262         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2263         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2264         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2265         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2266         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2267         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2268         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2269         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2270         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2271         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2272         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2273         procfs.c, producer.c, progspace.h, psymtab.h,
2274         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2275         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2276         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2277         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2278         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2279         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2280         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2281         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2282         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2283         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2284         target-memory.c, target.c, target.h, target/waitstatus.c,
2285         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2286         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2287         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2288         unittests/array-view-selftests.c,
2289         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2290         unittests/common-utils-selftests.c,
2291         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2292         unittests/format_pieces-selftests.c,
2293         unittests/function-view-selftests.c,
2294         unittests/lookup_name_info-selftests.c,
2295         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2296         unittests/mkdir-recursive-selftests.c,
2297         unittests/observable-selftests.c,
2298         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2299         unittests/parse-connection-spec-selftests.c,
2300         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2301         unittests/scoped_fd-selftests.c,
2302         unittests/scoped_mmap-selftests.c,
2303         unittests/scoped_restore-selftests.c,
2304         unittests/string_view-selftests.c, unittests/style-selftests.c,
2305         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2306         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2307         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2308         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2309         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2310         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2311
2312 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2315         bool value.
2316         (decode_digits_ordinary): Set explicit_line field in sal.
2317         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2318         symtab_and_line that was set on an explicit line number in
2319         assembler code.  Do always update the recorded symtab and line if
2320         we do skip the prologue.
2321
2322 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2323
2324         * breakpoint.c (set_breakpoint_location_function): Remove
2325         explicit_loc parameter.
2326         (momentary_breakpoint_from_master): Update call to
2327         set_breakpoint_location_function.
2328         (add_location_to_breakpoint): Likewise.
2329
2330 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2331
2332         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2333         required features based on default bfd type when no specific bfd
2334         is present.
2335
2336 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2337
2338         * NEWS: Mention that GDB printf and eval commands can now print
2339         C-style and Ada-style convenience var strings without
2340         calling the inferior.
2341         * printcmd.c (printf_c_string): Locally print GDB internal var
2342         instead of transiting via the inferior.
2343         (printf_wide_c_string): Likewise.
2344
2345 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2346
2347         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2348
2349 2019-07-04  Tom Tromey  <tom@tromey.com>
2350
2351         PR tui/24724:
2352         * tui/tui-winsource.c (tui_clear_source_content): Update.
2353         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2354         (tui_update_breakpoint_info): Update.
2355         (tui_set_exec_info_content): Update.
2356         * tui/tui-source.c (tui_set_source_content_nil): Update.
2357         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2358         has_break.
2359         * tui/tui-data.h (enum tui_bp_flag): New.
2360         (tui_bp_flags): New enum flags type.
2361         (struct tui_source_element) <break_mode>: Change type.  Rename
2362         from has_break.
2363         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2364         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2365         constants.
2366         * tui/tui-winsource.h: Fix comment.
2367
2368 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2369
2370         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2371         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2372         (store_fpregs_to_thread)
2373         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2374         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2375         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2376         (IWMMXT_REGS_SIZE): Add define.
2377         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2378         (fetch_vfp_regs, store_vfp_regs)
2379         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2380         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2381
2382 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2383
2384         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2385         defines.
2386         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2387         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2388         (ARM_INT_REGISTER_SIZE): ...to this.
2389         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2390         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2391         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2392         (arm_linux_collect_gregset, supply_nwfpe_register)
2393         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2394         defines.
2395         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2396         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2397         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2398         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2399         (arm_return_in_memory, arm_store_return_value)
2400         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2401         (arm_record_ld_st_multiple): Likewise.
2402         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2403         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2404
2405 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2406
2407         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2408         AARCH64_DISPLACED_MODIFIED_INSNS.
2409         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2410         (aarch64_displaced_step_copy_insn): Likewise.
2411         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2412         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2413         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2414         ARM_DISPLACED_MODIFIED_INSNS.
2415         * arm-tdep.c (arm_gdbarch_init): Likewise.
2416         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2417         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2418         (struct arm_displaced_step_closure): Use
2419         ARM_DISPLACED_MODIFIED_INSNS.
2420
2421 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2422
2423         * features/Makefile: Remove unused xml files.
2424         * features/aarch64.xml: Remove.
2425         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2426         * features/i386/amd64-avx-avx512.xml: Remove.
2427         * features/i386/amd64-avx-linux.xml: Remove.
2428         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2429         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2430         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2431         * features/i386/amd64-avx-mpx.xml: Remove.
2432         * features/i386/amd64-avx.xml: Remove.
2433         * features/i386/amd64-linux.xml: Remove.
2434         * features/i386/amd64-mpx-linux.xml: Remove.
2435         * features/i386/amd64-mpx.xml: Remove.
2436         * features/i386/amd64.xml: Remove.
2437         * features/i386/i386-avx-avx512-linux.xml: Remove.
2438         * features/i386/i386-avx-avx512.xml: Remove.
2439         * features/i386/i386-avx-linux.xml: Remove.
2440         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2441         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2442         * features/i386/i386-avx-mpx-linux.xml: Remove.
2443         * features/i386/i386-avx-mpx.xml: Remove.
2444         * features/i386/i386-avx.xml: Remove.
2445         * features/i386/i386-linux.xml: Remove.
2446         * features/i386/i386-mmx-linux.xml: Remove.
2447         * features/i386/i386-mmx.xml: Remove.
2448         * features/i386/i386-mpx-linux.xml: Remove.
2449         * features/i386/i386-mpx.xml: Remove.
2450         * features/i386/i386.xml: Remove.
2451         * features/i386/x32-avx-avx512-linux.xml: Remove.
2452         * features/i386/x32-avx-linux.xml: Remove.
2453         * features/i386/x32-linux.xml: Remove.
2454
2455 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2456
2457         * regformats/aarch64.dat: Remove.
2458         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2459         * regformats/i386/amd64-avx-linux.dat: Remove.
2460         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2461         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2462         * regformats/i386/amd64-linux.dat: Remove.
2463         * regformats/i386/amd64-mpx-linux.dat: Remove.
2464         * regformats/i386/amd64.dat: Remove.
2465         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2466         * regformats/i386/i386-avx-linux.dat: Remove.
2467         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2468         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2469         * regformats/i386/i386-linux.dat: Remove.
2470         * regformats/i386/i386-mmx-linux.dat: Remove.
2471         * regformats/i386/i386-mpx-linux.dat: Remove.
2472         * regformats/i386/i386.dat: Remove.
2473         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2474         * regformats/i386/x32-avx-linux.dat: Remove.
2475         * regformats/i386/x32-linux.dat: Remove.
2476
2477 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2478
2479         * aarch64-tdep.c: Remove xml self tests.
2480         * amd64-linux-tdep.c: Likewise.
2481         * amd64-tdep.c: Likewise.
2482         * i386-linux-tdep.c: Likewise.
2483         * i386-tdep.c: Likewise.
2484
2485 2019-07-03  Pedro Alves  <palves@redhat.com>
2486
2487         PR cli/24732
2488         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2489         (pipe_cmd_option_defs): New.
2490         (make_pipe_cmd_options_def_group): New.
2491         (pipe_command): Use gdb::option::process_options.
2492         (pipe_command_completer): New function.
2493         (_initialize_cli_cmds): Install completer for "pipe" command.
2494
2495 2019-07-03  Pedro Alves  <palves@redhat.com>
2496
2497         * cli/cli-option.c (union option_value) <string>: New field.
2498         (struct option_def_and_value): Add ctor, move ctor, dtor and
2499         use DISABLE_COPY_AND_ASSIGN.
2500         (option_def_and_value::clear_value): New.
2501         (parse_option, save_option_value_in_ctx, get_val_type_str)
2502         (add_setshow_cmds_for_options): Handle var_string.
2503         * cli-option.h (union option_def::var_address) <string>: New
2504         field.
2505         (struct string_option_def): New.
2506         * maint-test-options.c (struct test_options_opts): Add default
2507         ctor and use DISABLE_COPY_AND_ASSIGN.
2508         <string_opt>: New field.
2509         (test_options_opts::~test_options_opts): New.
2510         (test_options_opts::dump): Also dump "-string".
2511         (test_options_option_defs): Install "string.
2512
2513 2019-07-03  Pedro Alves  <palves@redhat.com>
2514
2515         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2516         option_value with a null enumeration.
2517         (complete_options): Save the option values in the context.
2518         (save_option_value_in_ctx): New, factored out from ...
2519         (process_options): ... here.
2520         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2521         of the function.
2522         * maint-test-options.c (test_options_opts::dump): New, factored
2523         out from ...
2524         (maintenance_test_options_command_mode): ... here.
2525         (maintenance_test_options_command_completion_result): Delete.
2526         (maintenance_test_options_command_completion_text): Update
2527         comment.
2528         (maintenance_show_test_options_completion_result): Change
2529         prototype.  Just print
2530         maintenance_test_options_command_completion_text.
2531         (save_completion_result): New.
2532         (maintenance_test_options_completer_mode): Pass options context to
2533         complete_options, and then save a dump.
2534         (_initialize_maint_test_options): Use add_cmd to install "maint
2535         show test-options-completion-result".
2536
2537 2019-07-03  Pedro Alves  <palves@redhat.com>
2538
2539         * NEWS (New commands): Mention "with" and "maint with".
2540         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2541         (with_command, with_command_completer): New.
2542         (pipe_command): Adjust to new repeat_previous
2543         interface.
2544         (_initialize_cli_cmds): Install the "with" command and its "w"
2545         alias.
2546         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2547         declarations.
2548         * cli/cli-setshow.c (parse_cli_var_uinteger)
2549         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2550         argument strings for all var_types.
2551         (get_setshow_command_value_string): New, factored out from ...
2552         (do_show_command): ... this.
2553         * cli/cli-setshow.h: Include <string>.
2554         (get_setshow_command_value_string): Declare.
2555         * command.h (repeat_previous): Now returns const char *.  Adjust
2556         comment.
2557         * maint.c: Include "cli/cli-cmds.h".
2558         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2559         (_initialize_maint_cmds): Register the "maintenance with" command.
2560         * top.c (repeat_previous): Move bits from pipe_command here:
2561         Return the saved command line, if any; error out if there's no
2562         command to relaunch.
2563
2564 2019-07-03  Pedro Alves  <palves@redhat.com>
2565
2566         * NEWS (New commands): Mention "maint set/show test-settings"
2567         instead of "maint test-settings".
2568         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2569         (maintenance_test_settings_set_list): Rename to ...
2570         (maintenance_set_test_settings_list): ... this.
2571         (maintenance_test_settings_show_list): Rename to  ...
2572         (maintenance_show_test_settings_list): ... this.
2573         (maintenance_test_settings_cmd): Delete.
2574         (maintenance_test_settings_set_cmd): ...
2575         (maintenance_set_test_settings_cmd): ... this.
2576         (maintenance_test_settings_show_cmd): ...
2577         (maintenance_show_test_settings_cmd): ... this.
2578         (maintenance_test_settings_show_value_cmd):
2579         (maintenance_show_test_settings_value_cmd): ... this.
2580         (_initialize_maint_test_settings): No longer install the "maint
2581         test-settings" prefix command.  Rename "maint test-settings set"
2582         to "maint set test-settings", and "maint test-settings show" to
2583         "maint show test-settings".  Adjust all subcommands.
2584
2585 2019-07-03  Pedro Alves  <palves@redhat.com>
2586
2587         * maint-test-settings.c: Fix file's intro comment.  Replace all
2588         references to "test-options" with references to "test-settings",
2589         in comments.
2590
2591 2019-07-03  Pedro Alves  <palves@redhat.com>
2592
2593         * maint-test-settings.c (maintenance_test_settings_xxx)
2594         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2595         New.
2596         (maintenance_test_settings_enums): Use them.
2597         (maintenance_test_settings_enum): Default to
2598         maintenance_test_settings_xxx.
2599         (_initialize_maint_test_settings): Initialize
2600         MAINTENANCE_TEST_SETTINGS_FILENAME.
2601
2602 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2603
2604         * breakpoint.h (remove_breakpoints_inf): Change return type to
2605         void, move function documentation here.
2606         * breakpoint.c (remove_breakpoints_inf): Change return type to
2607         void, move function documentation to header.
2608
2609 2019-07-02  Pedro Alves  <palves@redhat.com>
2610
2611         * NEWS (Completion improvements): Mention "info threads".
2612         * thread.c (struct info_threads_opts, info_threads_option_defs)
2613         (make_info_threads_options_def_group): New.
2614         (info_threads_command): Use gdb::option::process_options.
2615         (info_threads_command_completer): New.
2616         (_initialize_thread): Use gdb::option::build_help to build the
2617         help text for "info threads".
2618
2619 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2620
2621         * defs.h (generic_load): Move from here...
2622         * symfile.h (generic_load): ... to here.  Rename name parameter
2623         to args.
2624         * symfile.c (generic_load): Add comment.
2625
2626 2019-07-01  Tom Tromey  <tromey@adacore.com>
2627
2628         * dwarf2read.c
2629         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2630         declaration of without_params.  Fix formatting.
2631
2632 2019-07-01  Tom Tromey  <tromey@adacore.com>
2633
2634         * ada-exp.y (find_primitive_type): Update.
2635         * ada-lang.h (ada_lookup_symbol): Update.
2636         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2637         parameter.
2638         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2639
2640 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2641
2642         PR breakpoints/24541
2643         * gdbarch.c: Regenerate.
2644         * gdbarch.h: Regenerate.
2645         * gdbarch.sh: Add 'stap_adjust_register'.
2646         * i386-tdep.c: Include '<unordered_set>'.
2647         (i386_stap_adjust_register): New function.
2648         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2649         * stap-probe.c (stap_parse_register_operand): Call
2650         'gdbarch_stap_adjust_register'.
2651
2652 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2653
2654         PR python/24742
2655         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2656         * python/python.c (do_start_initialization): Use 'xmalloc'
2657         instead of 'PyMem_Malloc'.
2658
2659 2019-06-28  Tom Tromey  <tromey@adacore.com>
2660
2661         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2662         for Ada.
2663
2664 2019-06-27  Tom Tromey  <tromey@adacore.com>
2665
2666         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2667         objfile_key.
2668         (arm_find_mapping_symbol, arm_record_special_symbol)
2669         (_initialize_arm_tdep): Update.
2670         (arm_objfile_data_free): Remove.
2671
2672 2019-06-27  Tom Tromey  <tromey@adacore.com>
2673
2674         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2675         to cp_print_static_field.
2676
2677 2019-06-26  Tom Tromey  <tromey@adacore.com>
2678
2679         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2680         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2681         declare.
2682
2683 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2684
2685         * features/aarch64-core.c (create_feature_aarch64_core):
2686         Regenerate.
2687         * features/aarch64-core.xml: Add cpsr flags.
2688
2689 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2690
2691         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2692         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2693
2694 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2695
2696         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2697         field.
2698         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2699         use.
2700         (arm_record_special_symbol): Don't insert new symbol in sorted
2701         position, push it at the end.
2702
2703 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2704
2705         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2706         (arm_mapping_symbol_s): Remove.
2707         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2708         (arm_mapping_symbol_vec): New typedef.
2709         (struct arm_per_objfile): Add constructor.
2710         <section_maps>: Change type to
2711         std::unique_ptr<arm_mapping_symbol_vec[]>.
2712         (arm_compare_mapping_symbols): Remove.
2713         (arm_find_mapping_symbol): Adjust to section_maps type change.
2714         (arm_objfile_data_free): Call delete on arm_per_objfile.
2715         (arm_record_special_symbol): Adjust to section_maps type change.
2716         Allocate arm_per_objfile with new.
2717
2718 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2719
2720         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2721         with the command prefix.
2722
2723 2019-06-25  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2726         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2727
2728 2019-06-25  Tom Tromey  <tom@tromey.com>
2729
2730         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2731         type.
2732         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2733         protected.
2734
2735 2019-06-25  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-winsource.c
2738         (tui_source_window_base::set_is_exec_point_at): Add check against
2739         LOA_ADDRESS.
2740
2741 2019-06-25  Tom Tromey  <tom@tromey.com>
2742
2743         * tui/tui-source.c (tui_set_source_content): Don't check before
2744         xfree.
2745         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2746
2747 2019-06-25  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui-winsource.h (tui_update_source_window_as_is)
2750         (tui_alloc_source_buffer, tui_line_is_displayed)
2751         (tui_addr_is_displayed): Change type of win_info.
2752         * tui/tui-winsource.c (tui_update_source_window_as_is)
2753         (tui_clear_source_content, tui_show_source_line)
2754         (tui_show_source_content, tui_source_window_base::refill)
2755         (tui_source_window_base::set_is_exec_point_at)
2756         (tui_source_window_base::set_is_exec_point_at)
2757         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2758         (tui_alloc_source_buffer, tui_line_is_displayed)
2759         (tui_addr_is_displayed): Change type of win_info.  Update.
2760         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2761         (tui_source_window_base::do_make_visible_with_new_height):
2762         Update.
2763         * tui/tui-source.c (tui_set_source_content)
2764         (tui_set_source_content_nil)
2765         (tui_source_window::do_scroll_vertical): Update.
2766         * tui/tui-layout.c (show_layout): Update.
2767         * tui/tui-disasm.c (tui_set_disassem_content)
2768         (tui_disasm_window::do_scroll_vertical): Update.
2769         * tui/tui-data.h (tui_win_content): Remove.
2770         (struct tui_gen_win_info) <content, content_size>: Remove.
2771         (struct tui_source_element): Add initializers and destructor.
2772         (union tui_which_element, struct tui_win_element): Remove.
2773         (struct tui_source_window_base) <content>: New field.
2774         (struct tui_data_window): Remove destructor.
2775         (tui_alloc_content, tui_free_win_content)
2776         (tui_free_all_source_wins_content): Don't declare.
2777         * tui/tui-data.c (tui_initialize_static_data): Update.
2778         (init_content_element, tui_alloc_content): Remove.
2779         (~tui_gen_win_info): Update.
2780         (~tui_data_window, tui_free_all_source_wins_content)
2781         (tui_free_win_content, free_content, free_content_elements):
2782         Remove.
2783
2784 2019-06-25  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-winsource.h (tui_clear_source_content)
2787         (tui_erase_source_content, tui_show_source_content): Change type
2788         of win_info.
2789         * tui/tui-winsource.c (tui_clear_source_content)
2790         (tui_erase_source_content, tui_show_source_content): Change type
2791         of win_info.
2792         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2793         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2794         win_info.
2795         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2796         win_info.
2797         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2798
2799 2019-06-25  Tom Tromey  <tom@tromey.com>
2800
2801         * tui/tui-winsource.c (tui_clear_source_content)
2802         (tui_source_window_base::set_is_exec_point_at): Update.
2803         * tui/tui-source.c (tui_set_source_content_nil): Update.
2804         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2805         a bool.
2806         * tui/tui-data.c (init_content_element): Update.
2807
2808 2019-06-25  Tom Tromey  <tom@tromey.com>
2809
2810         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2811         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2812         * tui/tui-layout.c (init_and_make_win): Update.
2813         * tui/tui.h (enum tui_win_type): Update.
2814         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2815         tui_win_is_auxillary.
2816         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2817         tui_win_is_auxillary.
2818
2819 2019-06-25  Tom Tromey  <tom@tromey.com>
2820
2821         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2822         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2823         (tui_delete_data_content_windows, tui_display_all_data)
2824         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2825         Update.
2826         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2827         * tui/tui-regs.c (tui_last_regs_line_no)
2828         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2829         (tui_show_registers): Update.
2830         (tui_show_register_group): Return void.  Update.
2831         (tui_display_registers_from, tui_display_reg_element_at_line)
2832         (tui_display_registers_from_line, tui_check_register_values):
2833         Update.
2834         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2835         member.
2836         (struct tui_data_window) <regs_content>: Now a std::vector.
2837         <regs_content_count>: Remove.
2838         (tui_add_content_elements, tui_free_data_content): Don't declare.
2839         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2840         (init_content_element): Remove DATA_WIN case.  Add assert.
2841         (tui_add_content_elements): Remove.
2842         (tui_data_window): Update.
2843         (tui_free_data_content): Remove.
2844         (free_content_elements): Remove DATA_WIN case.
2845
2846 2019-06-25  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-data.c (tui_data_item_window): Update.
2849         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2850         * tui/tui-windata.c (tui_display_all_data)
2851         (tui_display_data_from_line): Update.
2852         (tui_check_data_values): Remove.
2853         * tui/tui-regs.c (tui_show_register_group)
2854         (tui_display_reg_element_at_line): Update.
2855         * tui/tui-hooks.c (tui_register_changed)
2856         (tui_refresh_frame_and_register_information): Call
2857         tui_check_register_values.
2858         * tui/tui-data.h (struct tui_data_window) <data_content,
2859         data_content_count, data_type>: Remove.
2860         (enum tui_data_type): Remove.
2861
2862         * tui/tui-data.c (tui_data_window::clear_detail)
2863         (~tui_data_window): Update.
2864
2865 2019-06-25  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2868         declare.
2869         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2870         Rename from tui_first_data_item_displayed.  Update.
2871         (tui_data_window::refresh_all)
2872         (tui_data_window::do_scroll_vertical): Update.
2873         * tui/tui-data.h (struct tui_data_window)
2874         <first_data_item_displayed>: Declare new method.
2875
2876 2019-06-25  Tom Tromey  <tom@tromey.com>
2877
2878         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2879         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2880         contents...
2881         (tui_initialize_static_data): ...here.
2882
2883 2019-06-25  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2886         (tui_display_registers_from, tui_check_register_values): Update.
2887         (tui_display_register): Remove win_info parameter; update.
2888         (tui_get_register): Change type of parameters.
2889         * tui/tui-data.h (struct tui_data_element): Remove.
2890         (union tui_which_element) <data>: Remove.
2891         <data_window>: Change type.
2892         (struct tui_data_item_window): New.
2893         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2894         case.  Add assert.
2895         (~tui_data_item_window): New destructor.
2896         (free_content_elements): Remove DATA_ITEM_WIN case.
2897
2898 2019-06-25  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2901         Remove.
2902
2903 2019-06-25  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-data.h (struct tui_command_element): Remove.
2906         (union tui_which_element) <command>: Remove.
2907         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2908         assert.
2909         (free_content_elements): Remove CMD_WIN case.
2910
2911 2019-06-25  Tom Tromey  <tom@tromey.com>
2912
2913         * tui/tui-layout.c (tui_set_layout): Update.
2914         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2915         * tui/tui-data.c (layout_def): Update.
2916
2917 2019-06-25  Tom Tromey  <tom@tromey.com>
2918
2919         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2920         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2921         (tui_source_window_base::set_new_height): Update.
2922         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2923         Update.
2924         (tui_set_locator_fullname, tui_set_locator_info)
2925         (tui_show_frame_info): Update.
2926         * tui/tui-source.c (tui_set_source_content)
2927         (tui_source_is_displayed): Update.
2928         * tui/tui-layout.c (show_source_disasm_command, show_data)
2929         (show_source_or_disasm_and_command): Update.
2930         * tui/tui-disasm.c (tui_set_disassem_content)
2931         (tui_get_begin_asm_address): Update.
2932         * tui/tui-data.h (struct tui_locator_element): Remove.
2933         (union tui_which_element) <locator>: Remove.
2934         (struct tui_locator_window): New.
2935         (tui_locator_win_info_ptr): Change return type.
2936         * tui/tui-data.c (_locator): Change type.
2937         (tui_locator_win_info_ptr): Change return type.
2938         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2939         (tui_alloc_content): Add assert.
2940
2941 2019-06-25  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-winsource.c
2944         (tui_exec_info_window::maybe_allocate_content): New method.
2945         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2946         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2947         (make_source_or_disasm_window): Add cast.
2948         * tui/tui-data.h (union tui_which_element) <simple_string>:
2949         Remove.
2950         (struct tui_source_info): New.
2951         (struct tui_source_window_base) <execution_info>: Change type.
2952         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2953         case, and add assert.
2954         (tui_alloc_content): Add assert.
2955
2956 2019-06-25  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2959         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2960         * tui/tui-data.c (tui_alloc_win_info): Remove.
2961
2962 2019-06-25  Tom Tromey  <tom@tromey.com>
2963
2964         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2965         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2966         can_highlight.
2967
2968 2019-06-25  Tom Tromey  <tom@tromey.com>
2969
2970         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2971         make_visible_with_new_height method.
2972         (tui_win_info::make_visible_with_new_height): New method.
2973         (tui_source_window_base::do_make_visible_with_new_height)
2974         (tui_data_window::do_make_visible_with_new_height)
2975         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2976         (make_visible_with_new_height): Remove.
2977         (tui_resize_all, tui_adjust_win_heights): Use
2978         make_visible_with_new_height method.
2979         * tui/tui-data.h (struct tui_win_info)
2980         <do_make_visible_with_new_height, make_visible_with_new_height>:
2981         New methods.
2982         (struct tui_source_window_base, struct tui_data_window)
2983         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2984         methods.
2985
2986 2019-06-25  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2989         method.
2990         (update_tab_width): Call update_tab_width method.
2991         * tui/tui-data.h (struct tui_win_info)
2992         (struct tui_source_window_base) <update_tab_width>: New methods.
2993
2994 2019-06-25  Tom Tromey  <tom@tromey.com>
2995
2996         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2997         parameter.
2998         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2999         parameter.
3000         (tui_gen_win_info::make_visible): Update.
3001         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3002         parameter.
3003         * tui/tui-data.h (enum tui_box): New enum.
3004         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3005
3006 2019-06-25  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3009         init_and_make_win for EXEC_INFO_WIN.
3010         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3011         longer inline.
3012         (struct tui_win_info) <~tui_win_info>: Inline.
3013         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3014         Don't declare.
3015         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3016         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3017         Remove.
3018         (tui_initialize_static_data): Update.
3019         (~tui_gen_win_info): Handle more cleanup here.
3020         (~tui_source_window_base): Delete "execution_info".
3021         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3022
3023 2019-06-25  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-layout.c (make_command_window): Don't set
3026         can_highlight.
3027         (show_source_disasm_command): Call the reset method.
3028         (show_data): Don't set can_highlight.  Call the reset method.
3029         (tui_gen_win_info::reset): Rename from init_gen_win_info
3030         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3031         (show_source_or_disasm_and_command): Call the reset method.
3032         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3033         (struct tui_cmd_window): Set can_highlight.
3034
3035 2019-06-25  Tom Tromey  <tom@tromey.com>
3036
3037         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3038         from make_visible.
3039         (tui_make_visible, tui_make_invisible): Rewrite.
3040         (tui_win_info::make_visible): Remove.
3041         (tui_source_window_base::make_visible): Update.
3042         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3043         method.  Moved from...
3044         (struct tui_win_info) <make_visible>: ...here.
3045
3046 2019-06-25  Tom Tromey  <tom@tromey.com>
3047
3048         * tui/tui-winsource.c
3049         (tui_source_window_base::do_scroll_horizontal): Remove direction
3050         parameter.
3051         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3052         direction parameter.
3053         * tui/tui-win.c (tui_win_info::forward_scroll)
3054         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3055         (tui_win_info::right_scroll): Update.
3056         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3057         direction parameter.
3058         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3059         direction parameter.
3060         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3061         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3062         Remove direction parameter.
3063         (struct tui_source_window_base, struct tui_source_window)
3064         (struct tui_disasm_window, struct tui_data_window)
3065         (struct tui_cmd_window): Update.
3066
3067 2019-06-25  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-winsource.h (tui_set_exec_info_content)
3070         (tui_show_exec_info_content, tui_erase_exec_info_content)
3071         (tui_clear_exec_info_content, tui_update_exec_info): Change
3072         argument to tui_source_window_base.
3073         * tui/tui-winsource.c (tui_set_exec_info_content)
3074         (tui_show_exec_info_content, tui_erase_exec_info_content)
3075         (tui_clear_exec_info_content, tui_update_exec_info): Change
3076         argument to tui_source_window_base.
3077
3078 2019-06-25  Tom Tromey  <tom@tromey.com>
3079
3080         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3081         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3082
3083 2019-06-25  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3086         check.
3087
3088 2019-06-25  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3091         type to void.
3092         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3093         type to void.
3094         * tui/tui-source.c (tui_set_source_content): Update.
3095         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3096
3097 2019-06-25  Tom Tromey  <tom@tromey.com>
3098
3099         * tui/tui-win.c (window_name_completer, tui_set_focus)
3100         (tui_all_windows_info): Use name method.
3101         * tui/tui-data.h (struct tui_gen_win_info)
3102         (struct tui_source_window, struct tui_disasm_window)
3103         (struct tui_data_window, struct tui_cmd_window) <name>: New
3104         method.
3105         (tui_win_name): Don't declare.
3106         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3107         (tui_win_name): Remove.
3108
3109 2019-06-25  Tom Tromey  <tom@tromey.com>
3110
3111         * tui/tui-winsource.h (tui_update_source_window)
3112         (tui_update_source_window_as_is): Change parameter type.
3113         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3114         to be a tui_source_window_base.
3115         (tui_update_source_window_as_is): Likewise.
3116         * tui/tui-win.c (make_visible_with_new_height): Update.
3117
3118 2019-06-25  Tom Tromey  <tom@tromey.com>
3119
3120         * tui/tui-winsource.c (tui_erase_source_content)
3121         (tui_show_source_content, tui_show_exec_info_content)
3122         (tui_erase_exec_info_content): Use refresh_window method.
3123         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3124         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3125         from tui_refresh_win.
3126         (tui_data_window::refresh_window): New method.
3127         (tui_win_info::refresh, tui_source_window_base::refresh)
3128         (tui_refresh_all): Use refresh_window method.
3129         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3130         method.
3131         * tui/tui-regs.c (tui_display_register): Call refresh_window
3132         method.
3133         * tui/tui-layout.c (show_source_disasm_command)
3134         (show_source_or_disasm_and_command): Call refresh_window method.
3135         * tui/tui-data.h (struct tui_gen_win_info)
3136         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3137         New method.
3138
3139 2019-06-25  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui.c (tui_rl_other_window, tui_enable)
3142         (tui_is_window_visible, tui_get_command_dimension): Update.
3143         * tui/tui-winsource.c (tui_update_source_window_as_is)
3144         (tui_clear_source_content, tui_erase_source_content)
3145         (tui_show_source_line, tui_source_window_base::refill)
3146         (tui_source_window_base::do_scroll_horizontal)
3147         (tui_source_window_base::set_is_exec_point_at)
3148         (tui_update_breakpoint_info, tui_set_exec_info_content)
3149         (tui_alloc_source_buffer, tui_line_is_displayed)
3150         (tui_addr_is_displayed): Update.
3151         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3152         (tui_check_and_display_highlight_if_needed)
3153         (tui_win_info::make_visible, tui_win_info::refresh)
3154         (tui_refresh_all): Update.
3155         * tui/tui-windata.c (tui_first_data_item_displayed)
3156         (tui_delete_data_content_windows, tui_erase_data_content)
3157         (tui_display_all_data, tui_data_window::refresh_all)
3158         (tui_check_data_values): Update.
3159         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3160         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3161         (tui_win_info::backward_scroll, tui_refresh_all_win)
3162         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3163         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3164         (tui_source_window_base::set_new_height)
3165         (tui_data_window::set_new_height)
3166         (make_invisible_and_set_new_height)
3167         (make_visible_with_new_height, new_height_ok)
3168         (parse_scrolling_args): Update.
3169         * tui/tui-stack.c (tui_show_frame_info): Update.
3170         * tui/tui-source.c (tui_set_source_content)
3171         (tui_set_source_content_nil, tui_source_is_displayed)
3172         (tui_source_window::do_scroll_vertical): Update.
3173         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3174         (tui_display_registers_from, tui_display_reg_element_at_line)
3175         (tui_check_register_values, tui_reg_command): Update.
3176         * tui/tui-layout.c (tui_default_win_height)
3177         (show_source_disasm_command, show_data, init_and_make_win)
3178         (show_source_or_disasm_and_command): Update.
3179         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3180         (tui_redisplay_readline, tui_mld_flush)
3181         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3182         (tui_getc): Update.
3183         * tui/tui-disasm.c (tui_set_disassem_content)
3184         (tui_disasm_window::do_scroll_vertical): Update.
3185         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3186         Now virtual.
3187         (struct tui_win_info): Derive from tui_gen_win_info.
3188         <~tui_win_info>: Mark as override.
3189         <generic>: Remove member.
3190         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3191         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3192         (~tui_data_window, ~tui_win_info)
3193         (tui_free_all_source_wins_content): Update.
3194         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3195
3196 2019-06-25  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-layout.c (init_and_make_win): Use new.
3199         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3200         destructor, initializers.
3201         (tui_alloc_generic_win_info): Don't declare.
3202         * tui/tui-data.c (_locator): Add argument to constructor.
3203         (source_win, disasm_win): New globals.
3204         (exec_info): Remove.
3205         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3206         Update.
3207         (tui_alloc_generic_win_info): Remove.
3208         (init_content_element): Use new.
3209         (tui_win_info::tui_win_info): Update.
3210         (free_content_elements) <case DATA_WIN>: Use delete.
3211
3212 2019-06-25  Tom Tromey  <tom@tromey.com>
3213
3214         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3215         * tui/tui-windata.c (tui_first_data_item_displayed)
3216         (tui_delete_data_content_windows): Update.
3217         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3218         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3219         (tui_display_registers_from, tui_check_register_values): Update.
3220         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3221         pointer.
3222         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3223         window.
3224         (tui_free_data_content): Update.
3225         (free_content_elements) <case DATA_WIN>: Free the window.
3226
3227 2019-06-25  Tom Tromey  <tom@tromey.com>
3228
3229         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3230         Update.
3231         * tui/tui-layout.c (make_command_window)
3232         (show_source_disasm_command, show_data, init_and_make_win)
3233         (show_source_or_disasm_and_command): Update.
3234         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3235         method.
3236         <can_highight, is_highlighted>: Now bool.
3237         (tui_set_win_highlight): Don't declare.
3238         * tui/tui-data.c (tui_set_win_highlight): Remove.
3239
3240 2019-06-25  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui-wingeneral.c (make_visible): Remove check of window
3243         type.
3244
3245 2019-06-25  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-win.c (tui_win_info::max_height)
3248         (tui_cmd_window::max_height): New methods.
3249         (new_height_ok): Call max_height.
3250         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3251         <max_height>: New method.
3252
3253 2019-06-25  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-win.c (tui_source_window_base::set_new_height)
3256         (tui_data_window::set_new_height): New methods.
3257         (make_invisible_and_set_new_height): Call set_new_height method.
3258         * tui/tui-data.h (struct tui_win_info)
3259         (struct tui_source_window_base, struct tui_data_window)
3260         <set_new_height>: New method.
3261
3262 2019-06-25  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3265         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3266         tui_refresh_data_win.
3267         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3268         method.
3269         (tui_refresh_all_win): Call the refresh_all method.
3270         (tui_set_focus): Likewise.
3271         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3272         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3273         Likewise.
3274
3275 2019-06-25  Tom Tromey  <tom@tromey.com>
3276
3277         * tui/tui-winsource.h (tui_refill_source_window)
3278         (tui_set_is_exec_point_at): Don't declare.
3279         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3280         (tui_source_window_base::refill): Rename from
3281         tui_refill_source_window.
3282         (tui_source_window_base::do_scroll_horizontal): Update.
3283         (tui_source_window_base::set_is_exec_point_at): Rename from
3284         tui_set_is_exec_point_at.
3285         (tui_update_all_breakpoint_info): Update.
3286         * tui/tui-stack.c (tui_show_frame_info): Update.
3287         * tui/tui-layout.c (show_data): Add cast.
3288         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3289         * tui/tui-data.h (struct tui_source_window_base) <refill,
3290         set_is_exec_point_at>: New methods.
3291         (tui_source_windows, tui_add_to_source_windows): Update types.
3292         (tui_add_to_source_windows): Remove redundant declaration.
3293         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3294         (tui_source_windows): Change return type.
3295         (tui_clear_source_windows_detail): Update.
3296         (tui_add_to_source_windows): Change type of parameter.
3297         (tui_free_all_source_wins_content): Update.
3298
3299 2019-06-25  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-wingeneral.c (tui_win_info::refresh)
3302         (tui_source_window_base::refresh): New methods.
3303         (tui_refresh_all): Call the refresh method.
3304         * tui/tui-data.h (struct tui_win_info)
3305         (struct tui_source_window_base) <refresh>: New method.
3306
3307 2019-06-25  Tom Tromey  <tom@tromey.com>
3308
3309         * tui/tui.h (tui_is_window_visible): Return bool.
3310         * tui/tui.c (tui_is_window_visible): Return bool.
3311         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3312         (tui_make_visible, tui_make_invisible)
3313         (tui_win_info::make_visible)
3314         (tui_source_window_base::make_visible, make_all_visible)
3315         (tui_make_all_visible, tui_make_all_invisible): Update.
3316         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3317         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3318         bool.
3319         (struct tui_win_info, struct tui_source_window_base)
3320         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3321         * tui/tui-data.c (tui_init_generic_part): Update.
3322
3323 2019-06-25  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3326         (tui_source_window_base::make_visible): New methods.
3327         (make_all_visible): Make method call.
3328         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3329         (struct tui_source_window_base, struct tui_cmd_window): Override
3330         make_visible.
3331         (tui_win_is_source_type): Don't declare.
3332         * tui/tui-data.c (tui_win_is_source_type): Remove.
3333
3334 2019-06-25  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3337         NULL check.
3338
3339 2019-06-25  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3342         Inline constructor.  Add initializers for members.
3343         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3344         constructors; now inline in class.
3345
3346 2019-06-25  Tom Tromey  <tom@tromey.com>
3347
3348         * tui/tui-regs.c (tui_show_registers): Update.
3349         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3350         bool.
3351         * tui/tui-data.c (tui_data_window::clear_detail)
3352         (tui_data_window): Update.
3353
3354 2019-06-25  Tom Tromey  <tom@tromey.com>
3355
3356         * tui/tui-windata.c (tui_display_all_data)
3357         (tui_display_data_from_line, tui_display_data_from)
3358         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3359         Update.
3360         * tui/tui-regs.c (tui_last_regs_line_no)
3361         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3362         (tui_show_registers, tui_show_register_group)
3363         (tui_display_registers_from, tui_display_reg_element_at_line)
3364         (tui_display_registers_from_line, tui_check_register_values)
3365         (tui_reg_next, tui_reg_prev): Update.
3366         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3367         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3368         tui_data_window.
3369         (struct tui_win_info) <detail>: Remove.  Add new fields from
3370         tui_data_info.
3371         (TUI_DATA_WIN): Add cast.
3372         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3373         (~tui_data_window): Simplify.
3374
3375 2019-06-25  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-layout.c (show_source_disasm_command)
3378         (show_source_or_disasm_and_command): Update.
3379         * tui/tui-io.c (update_cmdwin_start_line)
3380         (tui_redisplay_readline): Update.
3381         * tui/tui-data.h (struct tui_command_info): Remove.
3382         (struct tui_win_info) <detail>: Remove command_info member.
3383         (struct tui_data_window) <start_line>: New member, from
3384         tui_command_info.
3385         (TUI_CMD_WIN): Add casts.
3386
3387 2019-06-25  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui-winsource.c (tui_update_source_window)
3390         (tui_refill_source_window)
3391         (tui_source_window_base::do_scroll_horizontal)
3392         (tui_update_breakpoint_info, tui_set_exec_info_content)
3393         (tui_show_exec_info_content, tui_erase_exec_info_content)
3394         (tui_clear_exec_info_content): Update.
3395         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3396         Update.
3397         * tui/tui-win.c (make_invisible_and_set_new_height)
3398         (make_visible_with_new_height): Update.
3399         * tui/tui-source.c (tui_set_source_content)
3400         (tui_show_symtab_source): Update.
3401         * tui/tui-layout.c (extract_display_start_addr)
3402         (show_source_disasm_command, show_data)
3403         (make_source_or_disasm_window)
3404         (show_source_or_disasm_and_command): Update.
3405         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3406         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3407         "gdbarch".
3408         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3409         to tui_source_window_base.
3410         (struct tui_win_info) <detail>: Remove source_info member.
3411         (struct tui_source_window_base) <has_locator>: Inline.
3412         Move contents from tui_source_info; rename has_locator member to
3413         m_has_locator.
3414         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3415         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3416         header file.
3417         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3418         Simplify.
3419         (tui_free_all_source_wins_content): Cast to
3420         tui_source_window_base.
3421
3422 2019-06-25  Tom Tromey  <tom@tromey.com>
3423
3424         * tui/tui-win.c (make_invisible_and_set_new_height)
3425         (make_visible_with_new_height): Call has_locator method.
3426         * tui/tui-layout.c (show_source_disasm_command, show_data)
3427         (show_source_or_disasm_and_command): Update for bool change.
3428         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3429         (tui_win_info) <has_locator>: New method.
3430         (struct tui_source_window_base) <has_locator>: New method.
3431         (tui_win_has_locator): Don't declare.
3432         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3433         from tui_win_has_locator.
3434         (tui_source_window_base): Use false, not FALSE.
3435
3436 2019-06-25  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3439         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3440         clear_detail method directly.
3441         (tui_clear_win_detail): Remove.
3442
3443 2019-06-25  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3446         "this", not TUI_DISASM_WIN.
3447
3448 2019-06-25  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3451         declare.
3452         * tui/tui-winsource.c
3453         (tui_source_window_base::do_scroll_horizontal): Rename from
3454         tui_horizontal_source_scroll.
3455         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3456         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3457         from tui_vertical_data_scroll.
3458         * tui/tui-win.h (tui_scroll): Don't declare.
3459         * tui/tui-win.c (tui_win_info::forward_scroll)
3460         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3461         (tui_win_info::right_scroll): Rename and update.
3462         (tui_scroll_forward_command, tui_scroll_backward_command)
3463         (tui_scroll_left_command, tui_scroll_right_command): Update.
3464         (tui_scroll): Remove.
3465         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3466         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3467         from tui_vertical_source_scroll.
3468         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3469         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3470         from tui_vertical_disassem_scroll.
3471         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3472         do_scroll_horizontal>: New methods.
3473         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3474         Likewise.
3475         (struct tui_source_window_base): Add do_scroll_horizontal.
3476         (struct tui_source_window, struct tui_disasm_window): Add
3477         do_scroll_vertical.
3478         (struct tui_data_window, struct tui_cmd_window): Add
3479         do_scroll_horizontal and do_scroll_vertical.
3480         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3481
3482 2019-06-25  Tom Tromey  <tom@tromey.com>
3483
3484         * tui/tui-data.h (struct tui_source_window_base): New struct.
3485         (struct tui_source_window): Derive from tui_source_window_base.
3486         (struct tui_disasm_window): New struct.
3487         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3488         from tui_source_window::clear_detail.
3489         (tui_source_window_base): Rename from tui_source_window.
3490         (~tui_source_window_base): Rename from ~tui_source_window.
3491         (tui_alloc_win_info): Create a tui_disasm_window.
3492
3493 2019-06-25  Tom Tromey  <tom@tromey.com>
3494
3495         * tui/tui-data.h (struct tui_source_window)
3496         (struct tui_data_window): Declare destructors.
3497         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3498         destructors.
3499         (tui_win_info): Simplify.
3500
3501 2019-06-25  Tom Tromey  <tom@tromey.com>
3502
3503         * tui/tui-winsource.c (tui_display_main)
3504         (tui_update_source_windows_with_addr)
3505         (tui_update_all_breakpoint_info): Update.
3506         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3507         (new_height_ok, parse_scrolling_args): Update.
3508         * tui/tui-stack.c (tui_show_frame_info): Update.
3509         * tui/tui-data.h (struct tui_list): Remove.
3510         (tui_source_windows): Return a reference to a std::vector.
3511         * tui/tui-data.c (source_windows): Now a std::vector.
3512         (tui_source_windows): Change return type.
3513         (tui_clear_source_windows): Rewrite.
3514         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3515         (tui_free_all_source_wins_content): Rewrite.
3516
3517 2019-06-25  Tom Tromey  <tom@tromey.com>
3518
3519         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3520         (struct tui_data_window, struct tui_cmd_window): Declare
3521         clear_detail method.
3522         * tui/tui-data.c (tui_source_window::clear_detail)
3523         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3524         methods.
3525         (tui_clear_win_detail): Simplify.
3526
3527 2019-06-25  Tom Tromey  <tom@tromey.com>
3528
3529         * tui/tui-layout.c (make_source_window, make_disasm_window)
3530         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3531         Return the new window.
3532         (show_source_disasm_command, show_data)
3533         (show_source_or_disasm_and_command): Update.
3534
3535 2019-06-25  Tom Tromey  <tom@tromey.com>
3536
3537         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3538         parameter.  Return the new window.
3539         (show_source_disasm_command): Update and remove NULL check.
3540         (show_source_or_disasm_and_command): Update.
3541
3542 2019-06-25  Tom Tromey  <tom@tromey.com>
3543
3544         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-data.h (struct tui_win_info): Make constructor
3549         protected.  Make destructor virtual.  Add initializers.
3550         (tui_source_window, tui_data_window, tui_cmd_window): New
3551         classes.
3552         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3553         constructor.  Add "type" parameter.
3554         (tui_source_window, tui_data_window, tui_cmd_window): New
3555         constructors.
3556         (tui_alloc_win_info): Instantiate the appropriate subclass.
3557
3558 2019-06-25  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-win.c (tui_resize_all): Use delete.
3561         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3562         destructor.
3563         (tui_free_window): Don't declare.
3564         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3565         Update.
3566
3567 2019-06-25  Tom Tromey  <tom@tromey.com>
3568
3569         * tui/tui-data.h (struct tui_win_info): Add constructor.
3570         * tui/tui-data.c (tui_alloc_win_info): Use new.
3571         (tui_free_window): Use delete.
3572
3573 2019-06-22  Tom Tromey  <tom@tromey.com>
3574
3575         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3576         declare.
3577         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3578
3579 2019-06-22  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3582         declare.
3583         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3584
3585 2019-06-22  Tom de Vries  <tdevries@suse.de>
3586
3587         * dwarf2read.c (create_addrmap_from_aranges)
3588         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3589         instead of '%zu'.
3590
3591 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3592
3593         * dwarf2read.h (dwarf2_section_info_def): Remove.
3594         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3595         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3596         std::vector<dwarf2_section_info>.
3597         (struct dwo_file) <~dwo_file>: Remove.
3598         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3599         types field.
3600         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3601         (dwarf2_read_debug_names): Likewise.
3602         (create_debug_types_hash_table): Change parameter type to
3603         array_view, adjust code accordingly.
3604         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3605         (partial_die_info::fixup): Likewise.
3606         (determine_prefix): Likewise.
3607         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3608
3609 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3610
3611         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3612         gdb_bfd_ref_ptr.
3613         <~dwo_file>: Remove call to gdb_bfd_unref.
3614         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3615         gdb_bfd_ref_ptr::get.
3616
3617 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3618
3619         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3620         type to htab_up.
3621         * dwarf2read.c (struct dwo_file): Initialize fields.
3622         <~dwo_file>: New.
3623         (free_dwo_file): Remove, move content to ~dwo_file.
3624         (struct dwo_file_deleter): Remove.
3625         (dwo_file_up>: Remove custom deleter.
3626         (free_dwo_files): Remove.
3627         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3628         dwo_files.
3629         (process_skeletonless_type_units): Call unique_ptr::get.
3630         (allocate_dwo_file_hash_table): Add deleter to created hash
3631         table.  Change return type to htab_up.
3632         (lookup_dwo_file_slot): Don't memset dwo_file, call
3633         unique_ptr::get.
3634         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3635         (create_dwo_unit_in_dwp_v2): Likewise.
3636         (open_and_init_dwo_file): Likewise.
3637         (free_dwo_file_from_slot): Remove.
3638
3639 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3640
3641         * dwarf2read.h (struct dwarf2_section_info) <readin,
3642         is_virtual>: Change type to bool.
3643         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3644         true instead of 1.
3645
3646 2019-06-19  Tom Tromey  <tom@tromey.com>
3647
3648         * tui/tui-data.h (tui_init_content_element): Don't declare.
3649
3650 2019-06-19  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-data.h (tui_init_win_info): Don't declare.
3653
3654 2019-06-19  Tom de Vries  <tdevries@suse.de>
3655
3656         * dwarf2read.h (abstract_to_concrete): Change type to
3657         std::unordered_map<sect_offset, std::vector<sect_offset>,
3658         gdb::hash_enum<sect_offset>>.
3659
3660 2019-06-19  Tom Tromey  <tromey@adacore.com>
3661
3662         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3663         EVAL_AVOID_SIDE_EFFECTS specially.
3664
3665 2019-06-19  Tom Tromey  <tromey@adacore.com>
3666
3667         * source-cache.c (highlighter): New global.
3668         (source_cache::get_source_lines): Create a highlighter on demand.
3669
3670 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3671
3672         * defs.h (deprecated_interactive_hook): Delete declaration.
3673         * interps.c (clear_interpreter_hooks): Remove use of
3674         deprecated_interactive_hook.
3675         * top.c (deprecated_interactive_hook): Delete definition.
3676         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3677
3678 2019-06-18  Tom de Vries  <tdevries@suse.de>
3679
3680         PR gdb/24515
3681         * dwarf2read.h (abstract_to_concrete): Change type from
3682         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3683         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3684         * dwarf2read.c (read_variable): Update.
3685         (dwarf2_fetch_die_loc_sect_off): Update.
3686
3687 2019-06-17  Tom de Vries  <tdevries@suse.de>
3688
3689         PR gdb/24617
3690         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3691         accessing parent[parent_len - 1].
3692
3693 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3694
3695         PR gdb/24364
3696         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3697         call dtrace_process_dof with NULL dof.
3698
3699 2019-06-16  Tom de Vries  <tdevries@suse.de>
3700
3701         PR gdb/24445
3702         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3703
3704 2019-06-16  Tom Tromey  <tom@tromey.com>
3705
3706         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3707         (make_all_visible): Use address of member.
3708
3709 2019-06-16  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3712         (tui_free_window, free_content, free_content_elements): Remove
3713         unnecessary cast.
3714         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3715         cast.
3716         * tui/tui-regs.c (tui_show_register_group)
3717         (tui_display_registers_from, tui_display_reg_element_at_line):
3718         Remove unnecessary cast.
3719
3720 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3721
3722         * linux-nat.c (normal_mask): Delete.
3723         (_initialize_linux_nat): Don't initialise normal_mask.
3724
3725 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3726
3727         PR gdb/24445
3728         * dwarf-index-write.h (write_psymtabs_to_index): Add
3729         dwz_basename parameter.
3730         * dwarf-index-write.c (write_gdbindex): Move file writing to
3731         write_gdbindex_1.  Change return type void.
3732         (assert_file_size): Move up, remove filename parameter.
3733         (write_gdbindex_1): New function.
3734         (write_debug_names): Change return type to void, call
3735         assert_file_size.
3736         (struct index_wip_file): New struct.
3737         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3738         file logic to index_wip_file.  Write index for dwz file if
3739         needed.
3740         (save_gdb_index_command): Pass basename of dwz file, if present.
3741         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3742         build-id of dwz file, if present.
3743         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3744         (dwarf2_get_dwz_file): Likewise.
3745         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3746         (dwarf2_get_dwz_file): Likewise.
3747
3748 2019-06-16  Tom Tromey  <tom@tromey.com>
3749
3750         * coffread.c (process_coff_symbol): Use xstrdup.
3751         * value.c (create_internalvar): Use xstrdup.
3752
3753 2019-06-16  Tom Tromey  <tom@tromey.com>
3754
3755         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3756         * breakpoint.c (stopin_command, stopat_command)
3757         (until_break_command, decode_location_default): Remove unnecessary
3758         cast.
3759         * utils.c (subset_compare): Remove unnecessary cast.
3760         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3761         cast.
3762         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3763         cast.
3764         * infcmd.c (path_command): Remove unnecessary cast.
3765         * coffread.c (decode_type): Remove unnecessary cast.
3766         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3767         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3768         * tui/tui-stack.c (tui_show_locator_content)
3769         (tui_show_frame_info): Remove unnecessary cast.
3770         * tui/tui-win.c (tui_scroll_forward_command)
3771         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3772         (parse_scrolling_args): Remove unnecessary cast.
3773         * tui/tui-data.c (init_win_info, tui_del_window)
3774         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3775         (free_content_elements): Remove unnecessary cast.
3776         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3777         unnecessary cast.
3778         * tui/tui-source.c (tui_set_source_content)
3779         (tui_vertical_source_scroll): Remove unnecessary cast.
3780         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3781         cast.
3782         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3783         * tui/tui-regs.c (tui_display_registers_from)
3784         (tui_display_register): Remove unnecessary cast.
3785         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3786         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3787         (make_visible): Remove unnecessary cast.
3788         * tui/tui-winsource.c (tui_erase_source_content)
3789         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3790         unnecessary cast.
3791         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3792         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3793         * stabsread.c (read_type, read_array_type, read_range_type):
3794         Remove unnecessary cast.
3795         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3796         (parse_symbol, parse_type, upgrade_type, parse_external)
3797         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3798         unnecessary cast.
3799         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3800
3801 2019-06-16  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-data.c (tui_alloc_generic_win_info)
3804         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3805         checks.
3806
3807 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3808             Andrew Burgess  <andrew.burgess@embecosm.com>
3809
3810         * f-typeprint.c (f_print_type): Don't return early for not
3811         associated or not allocated types.
3812         (f_type_print_varspec_suffix): Add print_rank parameter and print
3813         ranks of array types in case they dangling.
3814         (f_type_print_base): Add print_rank parameter.
3815
3816 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3817
3818         * NEWS: Mention new MI commands.
3819         * break-catch-throw.c (enum exception_event_kind): Move to
3820         breakpoint.h.
3821         (print_mention_exception_catchpoint): Output text as a single
3822         message.
3823         (catch_exception_command_1): Rename to...
3824         (catch_exception_event): ...this, make non-static, update header
3825         command, and change some parameter types.
3826         (catch_catch_command): Update for changes to
3827         catch_exception_command_1.
3828         (catch_throw_command): Likewise.
3829         (catch_rethrow_command): Likewise.
3830         * breakpoint.c (enum exception_event_kind): Delete.
3831         * breakpoint.h (enum exception_event_kind): Moved here from
3832         break-catch-throw.c.
3833         (catch_exception_event): Declare.
3834         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3835         (mi_cmd_catch_throw): New function.
3836         (mi_cmd_catch_rethrow): New function.
3837         (mi_cmd_catch_catch): New function.
3838         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3839         'catch-catch' entries.
3840         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3841         (mi_cmd_catch_rethrow): Declare.
3842         (mi_cmd_catch_catch): Declare.
3843
3844 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3845
3846         * annotate.c (annotate_source_line): Change return type to void,
3847         update implementation to match.
3848         * annotate.h (annotate_source_line): Change return type to void,
3849         update header comment.
3850         * stack.c (print_frame_info): Don't change what frame information
3851         is printed based on whether annotations are on or not.
3852
3853 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3856         (annotate_source): Make static.
3857         (annotate_source_line): Moved from source.c and renamed from
3858         identify_source_line.  Update the return type.
3859         * annotate.h (annotate_source): Delete declaration.
3860         (annotate_source_line): Declaration moved from source.h, and
3861         renamed from identify_source_line.  Return type updated.
3862         * source.c (identify_source_line): Moved to annotate.c and renamed
3863         to annotate_source_line.
3864         (info_line_command): Remove check of annotation_level.
3865         * source.h (identify_source_line): Move declaration to annotate.h
3866         and rename to annotate_source_line.
3867         * stack.c: Add 'annotate.h' include.
3868         (print_frame_info): Remove check of annotation_level before
3869         calling annotate_source_line.
3870
3871 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3872
3873         * source-cache.c (source_cache::get_plain_source_lines): Use
3874         open_source_file_with_line_charpos instead of just
3875         open_source_file, remove call to find_source_lines.
3876         (source_cache::get_source_lines): Likewise.
3877         * source.c (find_source_lines): Make static.
3878         (get_filename_and_charpos): Renamed into...
3879         (open_source_file_with_line_charpos): ..this along with changes to
3880         return a scoped_fd, and some other minor clean ups.
3881         (identify_source_line): Use open_source_file_with_line_charpos.
3882         (search_command_helper): Use open_source_file_with_line_charpos
3883         instead of just open_source_file, remove call to
3884         find_source_lines.
3885         * source.h (open_source_file_with_line_charpos): Declare new
3886         function.
3887         (find_source_lines): Delete declaration.
3888
3889 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * source.c (get_filename_and_charpos): Remove fullname
3892         parameter.
3893         (identify_source_line): Update call to get_filename_and_charpos.
3894
3895 2019-06-14  Tom Tromey  <tromey@adacore.com>
3896
3897         PR gdb/24502:
3898         * ui-style.h (skip_ansi_escape): Update comment.
3899         * ui-file.h (class no_terminal_escape_file): New class.
3900         * ui-file.c (no_terminal_escape_file::write)
3901         (no_terminal_escape_file::puts): New methods.
3902         * cli/cli-logging.c (handle_redirections): Use
3903         no_terminal_escape_file.
3904
3905 2019-06-14  Tom Tromey  <tromey@adacore.com>
3906
3907         * NEWS: Move convenience variable news above Python news.
3908
3909 2019-06-14  Tom Tromey  <tom@tromey.com>
3910
3911         * gnulib: Move directory to top-level.
3912         * configure.ac: Don't configure gnulib.
3913         * configure: Rebuild.
3914         * common/common-defs.h: Use new path to gnulib.
3915         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3916         (GNULIB_H): Remove.
3917         (INCGNU): Look in new gnulib location.
3918         (HFILES_NO_SRCDIR): Remove gnulib files.
3919         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3920         (generated_files): Remove GNULIB_H.
3921         ($(LIBGNU), all-lib): Remove targets.
3922         (distclean): Don't mention GNULIB_BUILDDIR.
3923         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3924
3925 2019-06-14  Tom Tromey  <tromey@adacore.com>
3926
3927         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3928         Warn if symbol file does not provide any symbols.
3929
3930 2019-06-14  Tom Tromey  <tromey@adacore.com>
3931
3932         * source.c (find_and_open_source): Respect basenames_may_differ.
3933
3934 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3935
3936         * annotate.c (annotate_breakpoints_invalid): Make use of
3937         scoped_restore_terminal_state.
3938         (annotate_frames_invalid): Likewise.
3939
3940 2019-06-14  Tom Tromey  <tromey@adacore.com>
3941
3942         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3943         allow assignment to an internalvar.
3944
3945 2019-06-14  Tom Tromey  <tromey@adacore.com>
3946
3947         * ada-lex.l: Allow "_" in attribute names.
3948
3949 2019-06-14  Tom Tromey  <tromey@adacore.com>
3950
3951         PR gdb/24653:
3952         * regcache.c (registers_changed): Don't call alloca.
3953         * top.c (execute_command): Don't call alloca.
3954
3955 2019-06-13  Pedro Alves  <palves@redhat.com>
3956
3957         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3958         'expression'.  When parsing an expression, error out if there's
3959         junk after "unlimited".
3960         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3961         (do_set_command): Adjust calls to is_unlimited_literal.
3962
3963 2019-06-13  Pedro Alves  <palves@redhat.com>
3964
3965         * compile/compile.c (make_compile_options_def_group): Add braces
3966         around array_view initializer.
3967         * thread.c (make_thread_apply_all_options_def_group)
3968         (make_thread_apply_all_options_def_group): Likewise.
3969
3970 2019-06-13  Pedro Alves  <palves@redhat.com>
3971
3972         * NEWS (New commands): Mention "maint test-options
3973         require-delimiter", "maint test-options unknown-is-error", "maint
3974         test-options unknown-is-operand" and "maint show
3975         test-options-completion-result".
3976         (New command options, command completion): New section.
3977         (Completion improvements): New section.
3978         Mention that you can abbreviate "unlimited".
3979
3980 2019-06-13  Pedro Alves  <palves@redhat.com>
3981
3982         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3983         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3984         * unittests/cli-utils-selftests.c (test_parse_flags)
3985         (test_parse_flags_qcs): Delete.
3986         (test_cli_utils): Don't call deleted functions.
3987
3988 2019-06-13  Pedro Alves  <palves@redhat.com>
3989
3990         * thread.c: Include "cli/cli-option.h".
3991         (tp_array_compar_ascending): Global.
3992         (tp_array_compar): Delete function.
3993         (tp_array_compar_ascending, tp_array_compar_descending): New
3994         functions.
3995         (ascending_option_def, qcs_flag_option_def)
3996         (thr_qcs_flags_option_defs)
3997         (make_thread_apply_all_options_def_group)
3998         (make_thread_apply_options_def_group): New.
3999         (thread_apply_all_command): Use gdb::option::process_options.
4000         (thread_apply_command_completer)
4001         (thread_apply_all_command_completer): New.
4002         (thread_apply_command): Use gdb::option::process_options.
4003         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4004         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4005         to generate help text of "thread apply".  Adjust "taas"'s help.
4006         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4007         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4008
4009 2019-06-13  Pedro Alves  <palves@redhat.com>
4010
4011         * thread.c (thread_apply_command): Check for invalid TID with
4012         isdigit instead of !isalpha.
4013
4014 2019-06-13  Pedro Alves  <palves@redhat.com>
4015
4016         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4017         (validate_flags_qcs): New.
4018         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4019         (validate_flags_qcs): Declare.
4020         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4021         (make_frame_apply_options_def_group): New.
4022         (frame_apply_command_count): Process options with
4023         gdb::option::process_options.
4024         (frame_apply_completer): New.
4025         (frame_apply_level_completer, frame_apply_all_completer)
4026         (frame_apply_completer): New.
4027         (_initialize_stack): Update help of "frame apply", "frame apply
4028         level", "frame apply all" and "faas" to mention supported options
4029         and install command completers.
4030         * stack.h (frame_apply_all_completer): Declare.
4031         * thread.c: Include "stack.h".
4032         (tfaas_command): Add "--".
4033         (_initialize_thread): Update help "tfaas" to mention supported
4034         options and install command completer.
4035
4036 2019-06-13  Pedro Alves  <palves@redhat.com>
4037
4038         * completer.c (complete_nested_command_line): New.
4039         (gdb_completion_word_break_characters_throw): Add assertion.
4040         * completer.h (complete_nested_command_line): Declare.
4041
4042 2019-06-13  Pedro Alves  <palves@redhat.com>
4043
4044         * stack.c (parse_backtrace_qualifiers): New.
4045         (backtrace_command): Use it.
4046         (backtrace_command_completer): Complete on qualifiers.
4047
4048 2019-06-13  Pedro Alves  <palves@redhat.com>
4049
4050         * frame.c: Include "cli/cli-option.h.
4051         (user_set_backtrace_options): New.
4052         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4053         Delete.
4054         (get_prev_frame): Adjust.
4055         (boolean_option_def, uinteger_option_def)
4056         (set_backtrace_option_defs): New.
4057         (_initialize_frame): Adjust and use
4058         gdb::option::add_setshow_cmds_for_options to install "set
4059         backtrace past-main" and "set backtrace past-entry".
4060         * frame.h: Include "cli/cli-option.h".
4061         (struct frame_print_options): Forward declare.
4062         (print_frame_arguments_all, print_frame_arguments_scalars)
4063         (print_frame_arguments_none): Declare.
4064         (print_entry_values): Delete declaration.
4065         (struct frame_print_options, user_frame_print_options): New.
4066         (struct set_backtrace_options): New.
4067         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4068         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4069         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4070         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4071         (list_args_or_locals): Add frame_print_options parameter.
4072         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4073         * python/py-framefilter.c (enumerate_args): Pass down
4074         USER_FRAME_PRINT_OPTIONS.
4075         * stack.c: Include "cli/cli-option.h".
4076         (print_frame_arguments_all, print_frame_arguments_scalars)
4077         (print_frame_arguments_none): Declare.
4078         (print_raw_frame_arguments, print_entry_values): Delete.
4079         (user_frame_print_options): New.
4080         (boolean_option_def, enum_option_def, frame_print_option_defs):
4081         New.
4082         (struct backtrace_cmd_options): New.
4083         (bt_flag_option_def): New.
4084         (backtrace_command_option_defs): New.
4085         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4086         (print_frame_arg, read_frame_arg, print_frame_args)
4087         (print_frame_info, print_frame): Add frame_print_options parameter
4088         and use it.
4089         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4090         (backtrace_command_1): Add frame_print_options and
4091         backtrace_cmd_options parameters and use them.
4092         (make_backtrace_options_def_group): New.
4093         (backtrace_command): Process command options with
4094         gdb::option::process_options.
4095         (backtrace_command_completer): New.
4096         (_initialize_stack): Extend "backtrace"'s help to mention
4097         supported options.  Install completer for "backtrace".
4098         Install some settings commands with add_setshow_cmds_for_options.
4099
4100 2019-06-13  Pedro Alves  <palves@redhat.com>
4101
4102         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4103         and that "set/show print raw frame-arguments" are now deprecated.
4104
4105         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4106         command.
4107         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4108         * stack.c (_initialize_stack): Install "set/show print
4109         raw-frame-arguments", and deprecate "set/show print raw
4110         frame-arguments".
4111         * valprint.c (_initialize_valprint): Deprecate "set/show print
4112         raw".
4113
4114 2019-06-13  Pedro Alves  <palves@redhat.com>
4115
4116         * compile/compile.c (struct compile_options): New.
4117         (compile_flag_option_def, compile_command_option_defs)
4118         (make_compile_options_def_group): New.
4119         (compile_file_command): Handle options with
4120         gdb::option::process_options.
4121         (compile_file_command_completer): New function.
4122         (compile_code_command): Handle options with
4123         gdb::option::process_options.
4124         (compile_code_command_completer): New function.
4125         (_initialize_compiler): Install completers for "compile code" and
4126         "compile file".  Mention available options in "compile code" and
4127         "compile code"'s help.
4128         * completer.c (advance_to_completion_word): New, factored out from
4129         ...
4130         (advance_to_expression_complete_word_point): ... this.
4131         (advance_to_filename_complete_word_point): New.
4132         * completer.h (advance_to_filename_complete_word_point): New
4133         declaration.
4134
4135 2019-06-13  Pedro Alves  <palves@redhat.com>
4136
4137         * compile/compile.c: Include "cli/cli-option.h".
4138         (compile_print_value): Scope data pointer is now a
4139         value_print_options pointer; adjust.
4140         (compile_print_command): Process options.  Scope data pointer is
4141         now a value_print_options pointer; adjust.
4142         (_initialize_compile): Update "compile print"'s help to include
4143         supported options.  Install a completer for "compile print".
4144         * cp-valprint.c (show_vtblprint, show_objectprint)
4145         (show_static_field_print): Delete.
4146         (_initialize_cp_valprint): Don't install "set print
4147         static-members", "set print vtbl", "set print object" here.
4148         * printcmd.c: Include "cli/cli-option.h" and
4149         "common/gdb_optional.h".
4150         (print_command_parse_format): Rework to fill in a
4151         value_print_options instead of a format_data.
4152         (print_value): Change parameter type from format_data pointer to
4153         value_print_options reference.  Adjust.
4154         (print_command_1): Process options.  Adjust to pass down a
4155         value_print_options.
4156         (print_command_completer): New.
4157         (_initialize_printcmd): Install print_command_completer as
4158         handle_brkchars completer for the "print" command.  Update
4159         "print"'s help to include supported options.
4160         * valprint.c: Include "cli/cli-option.h".
4161         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4162         here from cp-valprint.c.
4163         (boolean_option_def, uinteger_option_def)
4164         (value_print_option_defs, make_value_print_options_def_group):
4165         New.  Use gdb::option::add_setshow_cmds_for_options to install
4166         "set print elements", "set print null-stop", "set print repeats",
4167         "set print pretty", "set print union", "set print array", "set
4168         print address", "set print symbol", "set print array-indexes".
4169         * valprint.h: Include <string> and "cli/cli-option.h".
4170         (make_value_print_options_def_group): Declare.
4171         (print_value): Change parameter type from format_data pointer to
4172         value_print_options reference.
4173         (print_command_completer): Declare.
4174
4175 2019-06-13  Pedro Alves  <palves@redhat.com>
4176
4177         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4178         (COMMON_SFILES): Add maint-test-settings.c.
4179         * cli/cli-decode.c (boolean_enums): New global, factored out from
4180         ...
4181         (add_setshow_boolean_cmd): ... here.
4182         * cli/cli-decode.h (boolean_enums): Declare.
4183         * cli/cli-option.c: New file.
4184         * cli/cli-option.h: New file.
4185         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4186         factored out from ...
4187         (parse_cli_boolean_value(const char *)): ... this.
4188         (is_unlimited_literal): Change parameter type to pointer to
4189         pointer.  Adjust and advance ARG pointer.
4190         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4191         (parse_cli_var_enum): New, factored out from ...
4192         (do_set_command): ... this.  Adjust.
4193         * cli/cli-setshow.h (parse_cli_boolean_value)
4194         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4195         (parse_cli_var_enum): Declare.
4196         * cli/cli-utils.c: Include "cli/cli-option.h".
4197         (get_ulongest): New.
4198         * cli/cli-utils.h (get_ulongest): Declare.
4199         (check_for_argument): New overloads.
4200         * maint-test-options.c: New file.
4201
4202 2019-06-13  Pedro Alves  <palves@redhat.com>
4203
4204         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4205         parse a range if "-" is at the end of the string.
4206
4207 2019-06-13  Pedro Alves  <palves@redhat.com>
4208
4209         * cli/cli-setshow.c (parse_auto_binary_operation)
4210         (parse_cli_boolean_value): Don't allow "o".
4211
4212 2019-06-13  Pedro Alves  <palves@redhat.com>
4213
4214         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4215         * NEWS: Mention maint test-settings KIND.
4216         * maint-test-settings.c: New file.
4217
4218 2019-06-13  Pedro Alves  <palves@redhat.com>
4219
4220         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4221         completer.
4222         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4223         "set" completers.
4224
4225 2019-06-13  Pedro Alves  <palves@redhat.com>
4226
4227         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4228         after item.
4229
4230 2019-06-13  Pedro Alves  <palves@redhat.com>
4231
4232         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4233
4234 2019-06-13  Pedro Alves <palves@redhat.com>
4235
4236         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4237         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4238         call.
4239         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4240         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4241         calls.
4242         (check_for_argument): Skip spaces after argument.
4243
4244 2019-06-13  Pedro Alves  <palves@redhat.com>
4245
4246         * thread.c (thread_apply_command): Adjust TID parsing.
4247         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4248         detected before end of string.
4249         (tid_is_in_list): Error out if LIST is invalid.
4250
4251 2019-06-13  Pedro Alves  <palves@redhat.com>
4252
4253         * completer.c (complete_line_internal_1): Rewind completion word
4254         point.
4255         (completion_tracker::advance_custom_word_point_by): Change
4256         parameter type to int.
4257         * completer.h (completion_tracker::advance_custom_word_point_by):
4258         Likewise.
4259
4260 2019-06-13  Pedro Alves  <palves@redhat.com>
4261
4262         * completer.c (advance_to_completion_word): Handle delimiters.
4263
4264 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4265
4266         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4267
4268 2019-06-11  Tom Tromey  <tom@tromey.com>
4269
4270         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4271         (xmalloc_failed): Move to alloc.c.
4272         * alloc.c: New file.
4273         * Makefile.in (COMMON_SFILES): Add alloc.c.
4274
4275 2019-06-11  Tom Tromey  <tom@tromey.com>
4276
4277         * nat/linux-waitpid.c: Don't include server.h.
4278         (linux_debug): Remove.
4279         (my_waitpid): Update.
4280
4281 2019-06-11  Tom Tromey  <tromey@adacore.com>
4282
4283         * infcall.c (_initialize_infcall): Remove trailing newline from
4284         help.
4285         * user-regs.c (_initialize_user_regs): Remove trailing newline
4286         from help.
4287         * typeprint.c (_initialize_typeprint): Remove trailing newline
4288         from help.
4289         * reverse.c (_initialize_reverse): Remove trailing newlines from
4290         help.
4291         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4292         from help.
4293         * language.c (add_set_language_command): Remove trailing newline
4294         from help.
4295         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4296         help.
4297         * disasm.c (_initialize_disasm): Remove trailing newline from
4298         help.
4299         * top.c (init_main): Remove trailing newline from help.
4300         * interps.c (_initialize_interpreter): Remove trailing newline
4301         from help.
4302         * btrace.c (_initialize_btrace): Remove trailing newlines from
4303         help.
4304         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4305         from help.
4306         * python/python.c (_initialize_python): Remove trailing newline
4307         from help.
4308         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4309         help.
4310         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4311         from help.  Reformat some text.
4312         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4313         from help.
4314         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4315         newline from help.
4316
4317 2019-06-11  Tom Tromey  <tromey@adacore.com>
4318
4319         * darwin-nat.c (darwin_decode_exception_message)
4320         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4321
4322 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * valops.c (value_slice): Check for not allocated or not
4325         associated values.
4326
4327 2019-06-10  Tom de Vries  <tdevries@suse.de>
4328
4329         PR gdb/24618
4330         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4331         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4332         invalid.
4333
4334 2019-06-10  Tom de Vries  <tdevries@suse.de>
4335
4336         PR gdb/24611
4337         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4338         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4339
4340 2019-06-10  Tom de Vries  <tdevries@suse.de>
4341
4342         PR symtab/24545
4343         * symtab.c (struct demangled_name_entry): Add language field.
4344         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4345         static minimal symbol".  Set and use language field.
4346
4347 2019-06-10  Tom Tromey  <tromey@adacore.com>
4348
4349         * ada-lang.c (_initialize_ada_language): Update help text.
4350
4351 2019-06-10  Tom Tromey  <tromey@adacore.com>
4352
4353         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4354         with a newline.
4355         * guile/guile.c (handle_boot_error): Don't end warning with a
4356         newline.
4357         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4358         warning with a newline.
4359         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4360         newline.
4361         (s12z_frame_cache): Likewise.
4362         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4363         a newline.
4364         * solib-svr4.c (disable_probes_interface): Don't end warning with
4365         a newline.
4366         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4367         newline.
4368         * python/python.c (do_finish_initialization): Don't end warning
4369         with a newline.
4370
4371 2019-06-10  Tom Tromey  <tom@tromey.com>
4372
4373         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4374         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4375         gdbpy_enter.
4376
4377 2019-06-10  Tom Tromey  <tromey@adacore.com>
4378
4379         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4380         data.
4381         (elf_new_init): Don't call stabsread_new_init.
4382         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4383         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4384         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4385
4386 2019-06-10  Tom de Vries  <tdevries@suse.de>
4387
4388         PR symtab/16264
4389         PR symtab/24517
4390         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4391
4392 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4393
4394         * source.c (find_and_open_source): Also rewrite relative file
4395         names.
4396
4397 2019-04-26  Amos Bird  <amosbird@gmail.com>
4398
4399         * annotate.c (annotate_thread_exited): Add "thread-exited"
4400         annotation.
4401
4402 2019-06-06  Tom Tromey  <tromey@adacore.com>
4403
4404         * maint.h (class scoped_command_stats): Use
4405         DISABLE_COPY_AND_ASSIGN.
4406         <print_time>: New method.
4407         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4408         print_time.
4409         (scoped_command_stats::print_time): New method.
4410
4411 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4412
4413         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4414         instructions of lengths 6 or 8 bytes.
4415
4416 2019-06-04  Pedro Alves  <palves@redhat.com>
4417
4418         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4419
4420         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4421         * breakpoint.c (condition_completer): Likewise.
4422         * cli/cli-dump.c (scan_expression): Likewise.
4423         * common/filestuff.c (mkdir_recursive): Likewise.
4424         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4425         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4426         (gdb_abspath): Likewise.
4427         * compile/compile-cplus-types.c
4428         (compile_cplus_instance::decl_name): Likewise.
4429         * completer.c (complete_explicit_location):
4430         (signal_completer, reg_or_group_completer_1): Likewise.
4431         * cp-support.c (cp_remove_params_if_any): Likewise.
4432         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4433         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4434         * infcmd.c (strip_bg_char): Likewise.
4435         * linespec.c (copy_token_string): Likewise.
4436         * mi/mi-main.c (output_cores): Likewise.
4437         * psymtab.c (psymtab_search_name):
4438         * symfile.c (test_set_ext_lang_command): Likewise.
4439         * target.c (target_fileio_read_stralloc): Likewise.
4440         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4441         * value.c (complete_internalvar): Likewise.
4442
4443 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4444
4445         Add objfile property to gdb.Type.
4446         * NEWS: Mention Python API addition.
4447         * python/py-type.c (typy_get_objfile): New method.
4448
4449 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4450
4451         * NEWS: Mention the new set|show style [title|highlight].
4452         Mention changes to "show style", "help" and "apropos".
4453
4454 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4455
4456         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4457         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4458         instead of print_help_for_command.
4459         (print_doc_of_command): New function.
4460         (help_list): Add 'apropos -v word' suggestion.
4461         (print_help_for_command): Style the command name using title style.
4462         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4463         (_initialize_cli_cmds): Describe -v in apropos_command help.
4464
4465 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4466
4467         * cli/cli-style.h (cli_style_option): Add name in constructor,
4468         add m_name class member, add constructor with intensity,
4469         add name class function.
4470         (cli_style_option::add_setshow_commands): Remove name argument.
4471         (highlight_style, title_style): New styles.
4472         * cli/cli-style.c (do_show): New function that shows a style
4473         characteristic styling the style name with itself.
4474         (set_style_name): New function.
4475         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4476         Update all callers according to the changes in cli/cli-style.h.
4477         * utils.h (fputs_highlighted): New function.
4478         * utils.c (fputs_highlighted): Likewise.
4479
4480 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4481
4482         * NEWS: Mention new pipe command and new convenience variables.
4483
4484 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4485
4486         * cli/cli-cmds.c (pipe_command): New function.
4487         (_initialize_cli_cmds): Call add_com for pipe_command.
4488         Define | as an alias for pipe.
4489         (exit_status_set_internal_vars): New function.
4490         (shell_escape): Call exit_status_set_internal_vars.
4491         cli/cli-decode.c (find_command_name_length): Recognize | as
4492         a single character command.
4493
4494 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4495
4496         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4497         top.c (execute_command_to_ui_file): New function, mostly a copy
4498         of execute_command_to_string.
4499         (execute_command_to_string): Implement by calling
4500         execute_command_to_ui_file.
4501
4502 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4503
4504         * top.h (saved_command_line): Remove declaration.
4505         * top.c (previous_saved_command_line, previous_repeat_arguments):
4506         New variables.
4507         (saved_command_line): Make static, define together with other
4508         'repeat variables'.
4509         (dont_repeat): Clear repeat_arguments.
4510         (repeat_previous, get_saved_command_line, save_command_line):
4511         New functions.
4512         (gdb_init): Initialize saved_command_line
4513         and previous_saved_command_line.
4514         * main.c (captured_main_1): Remove saved_command_line initialization.
4515         * event-top.c (handle_line_of_input): Update to use
4516         the new 'repeat' related functions instead of direct access to
4517         saved_command_line.
4518         * command.h (repeat_previous, get_saved_command_line,
4519         save_command_line): New declarations.
4520         (dont_repeat): Add comment.
4521
4522 2019-05-30  Tom Tromey  <tromey@adacore.com>
4523
4524         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4525         Fix comment.
4526         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4527
4528 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4529
4530         PR cli/24587
4531         * completer.c (complete): Initialize variable word.
4532
4533 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4534
4535         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4536         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4537         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4538         'body' is NULL to the outter 'if', protecting the '!is_define'
4539         situation as well.
4540
4541 2019-05-29  Tom Tromey  <tromey@adacore.com>
4542
4543         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4544         (dwarf_unknown): New function.
4545         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4546         (dwarf_type_encoding_name): Use dwarf_unknown.
4547
4548 2019-05-29  Tom Tromey  <tromey@adacore.com>
4549
4550         PR c++/20020:
4551         * cp-valprint.c (cp_print_value_fields): Call
4552         cp_print_static_field inside "try".
4553
4554 2019-05-29  Tom Tromey  <tromey@adacore.com>
4555
4556         * inflow.c (struct terminal_info): Add default operator=.
4557         * configure: Rebuild.
4558         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4559         -Wdeprecated-copy-dtor, -Wredundant-move.
4560
4561 2019-05-29  Tom Tromey  <tromey@adacore.com>
4562
4563         * NEWS: Add entry.
4564         * infcmd.c (print_return_value_1): Handle finish_print
4565         option.
4566         (show_print_finish): New function.
4567         (_initialize_infcmd): Add "set/show print finish" commands.
4568         * valprint.c (user_print_options): Initialize new member.
4569         * valprint.h (struct value_print_options) <finish_print>: New
4570         member.
4571
4572 2019-05-28  Tom Tromey  <tromey@adacore.com>
4573
4574         * ada-lang.c (ada_remove_Xbn_suffix)
4575         (find_old_style_renaming_symbol)
4576         (parse_old_style_renaming): Remove.
4577         (ada_find_renaming_symbol): Don't call
4578         find_old_style_renaming_symbol.
4579         (ada_is_renaming_symbol): Rename from
4580         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4581         bool.  Now static.
4582         (ada_read_var_value): Update and simplify.
4583         * ada-exp.y (write_var_or_type): Remove old code.
4584
4585 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4586
4587         * event-top.c: Remove include comment.
4588         * inflow.c (class scoped_ignore_sigttou): Move from here...
4589         * inflow.h (class scoped_ignore_sigttou): ...to here.
4590         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4591         * top.c:  Remove include comment.
4592
4593 2019-05-27  Tom Tromey  <tom@tromey.com>
4594
4595         * NEWS: Fix typo.
4596
4597 2019-05-22  Tom Tromey  <tromey@adacore.com>
4598
4599         * target.c (target_follow_exec): Constify parameter.
4600         * target-delegates.c: Rebuild.
4601         * remote.c (remote_target::follow_exec): Constify parameter.
4602         * infrun.c (follow_exec): Constify parameter.
4603         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4604         (target_follow_exec): Likewise.
4605
4606 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4607
4608         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4609         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4610
4611 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4612
4613         * NEWS: Add debugredirect and testsuite sections.
4614
4615 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4616
4617         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4618         target descriptions using exclusively floating point register name
4619         aliases.
4620
4621 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         PR gdb/18644:
4624         * f-lang.c (build_fortran_types): Handle the case where
4625         gdbarch_floatformat_for_type returns a nullptr.
4626
4627 2019-05-21  Tom de Vries  <tdevries@suse.de>
4628
4629         PR cli/24587
4630         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4631
4632 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4633
4634         PR gdb/18644:
4635         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4636         16-byte floats.
4637         * i386-tdep.c (i386_floatformat_for_type): Use
4638         floatformats_ia64_quad for the 16-byte floating point component
4639         within a fortran 32-byte complex number.
4640
4641 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4642
4643         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4644         delete default constructor.
4645         (find_partial_die): Update to return const struct.
4646         (partial_die_parent_scope): Move variable declaration into scope
4647         of its use and change its type to auto.
4648         (guess_partial_die_structure_name): Likewise.
4649         (partial_die_info::fixup): Likewise.
4650
4651 2019-05-17  Tom Tromey  <tromey@adacore.com>
4652
4653         * source.c (find_and_open_source): Remove cast.
4654
4655 2019-05-17  Tom Tromey  <tromey@adacore.com>
4656
4657         * annotate.c (annotate_source): Make "filename" const.
4658         * annotate.h (annotate_source): Use const.
4659
4660 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4661
4662         * disasm.c (set_disassembler_options): Send errors to stderr.
4663
4664 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4665
4666         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4667         (cli_interp_base::set_logging): Check debug_redirect.
4668         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4669         * cli/cli-logging.c (debug_redirect): Add static variable.
4670         (pop_output_files): Add default param.
4671         (handle_redirections): Print debug setting.
4672         (show_logging_command): Likewise.
4673         (_initialize_cli_logging): Add debugredirect command.
4674         * interps.c (current_interp_set_logging): Add debug_redirect
4675         parameter.
4676         * interps.h (set_logging): Add debug_redirect parameter.
4677         (current_interp_set_logging): Likewise.
4678         * mi/mi-common.h: Likewise.
4679         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4680
4681 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4682             Tom Tromey  <tromey@adacore.com>
4683
4684         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4685         directly.
4686         * cli/cli-interp.h (make_logging_output): Remove declaration.
4687         * cli/cli-logging.c (make_logging_output): Remove function.
4688         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4689         directly.
4690         * ui-file.c (tee_file::tee_file): Remove bools.
4691         (tee_file::~tee_file): Remove deletes.
4692         * ui-file.h (tee_file): Remove bools.
4693
4694 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4695
4696         * mi/mi-cmds.h (mi_cmd_complete): New function.
4697         * mi/mi-main.c (mi_cmd_complete): Likewise.
4698         * mi/mi-cmds.c: Define new MI command -complete.
4699         * NEWS: Mention new -complete command.
4700
4701 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4702
4703         * completer.h (complete): New function.
4704         * completer.c (complete): Likewise.
4705         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4706         function defined in completer.h.
4707
4708 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4709
4710         * MAINTAINERS (Write After Approval): Add myself.
4711
4712 2019-05-17  Tom de Vries  <tdevries@suse.de>
4713
4714         PR gdb/24094
4715         * dwarf2read.c (struct cu_partial_die_info): New struct.
4716         (find_partial_die): Return cu_partial_die_info.
4717         (partial_die_parent_scope, guess_partial_die_structure_name)
4718         (partial_die_info::fixup): Handle new return type of find_partial_die.
4719
4720 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4721
4722         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4723         "std::string", simplifying the algorithm.
4724
4725 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4726
4727         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4728         (stap_static_probe_ops::get_probes): Likewise.
4729
4730 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4731
4732         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4733         '-')" and "else if".
4734         (stap_parse_single_operand): Join checks for
4735         "gdbarch_stap_parse_special_token_p" and
4736         "gdbarch_stap_parse_special_token" in the same "if" statement.
4737         Invert check when verifying for operation on register
4738         displacement.
4739
4740 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4741
4742         * stap-probe.c (stap_get_opcode): Update comment.
4743         (stap_get_expected_argument_type): Likewise.
4744         (handle_stap_probe): Likewise.
4745
4746 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4747
4748         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4749         return type to 'bool'.  Adjust comment.  Use 'bool' when
4750         appropriate.
4751         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4752         * stap-probe.c (stap_parse_argument_1): Likewise.
4753         (stap_is_operator): Likewise.
4754         (stap_is_generic_prefix): Likewise.
4755         (stap_is_register_prefix): Likewise.
4756         (stap_is_register_indirection_prefix): Likewise.
4757         (stap_is_integer_prefix): Likewise.
4758         (stap_generic_check_suffix): Likewise.
4759         (stap_check_integer_suffix): Likewise.
4760         (stap_check_register_suffix): Likewise.
4761         (stap_check_register_indirection_suffix): Likewise.
4762         (stap_parse_register_operand): Likewise.
4763         (stap_parse_single_operand): Likewise.
4764         (stap_parse_argument_1): Likewise.
4765         (stap_probe::get_argument_count): Likewise.
4766         (stap_is_operator): Likewise.
4767
4768 2019-05-16  Tom Tromey  <tromey@adacore.com>
4769
4770         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4771         keyword to foreach.
4772
4773 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4774
4775         * linux-thread-db.c (try_thread_db_load_1): Change return type
4776         to bool.
4777         (try_thread_db_load): Likewise.
4778         (try_thread_db_load_from_pdir_1): Likewise.
4779         (try_thread_db_load_from_pdir): Likewise.
4780         (try_thread_db_load_from_sdir): Likewise.
4781         (try_thread_db_load_from_dir): Likewise.
4782         (thread_db_load_search): Likewise.
4783         (has_libpthread): Likewise.
4784         (thread_db_load): Likewise.
4785
4786 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4787
4788         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4789         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4790         NULL, and complain/return if that's the case.
4791
4792 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4793
4794         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4795         (advance, posn, abstract_read_memory): New functions.
4796         [struct mem_read_abstraction]: New struct.
4797         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4798
4799 2019-05-14  Tom Tromey  <tromey@adacore.com>
4800
4801         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4802         value is not lval_memory.
4803
4804 2019-05-14  Tom Tromey  <tromey@adacore.com>
4805
4806         * solib.c (info_sharedlibrary_command): Style the file name.
4807
4808 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4809
4810         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4811         (aarch64_vnv_type): Likewise.
4812         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4813         * common/tdesc.c: Likewise.
4814         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4815         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4816         * features/aarch64-fpu.xml: Add ieee half view.
4817         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4818         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4819         * gdbtypes.h (struct builtin_type): Likewise.
4820         (struct objfile_type): Likewise.
4821
4822 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4823
4824         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4825         typo.
4826         * location.h (string_to_event_location): Likewise.
4827
4828 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4829
4830         GDB 8.3 released.
4831
4832 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4833
4834         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4835         New variable declaration.
4836         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4837         New variable.
4838         (print_one_breakpoint): Use ui_out::test_flags and new global
4839         variable to compute use_fixed_output.
4840         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4841         Remove.
4842         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4843         (mi_multi_location_breakpoint_output_fixed): Remove.
4844         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4845         new variable.
4846         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4847         fix_multi_location_breakpoint_output flag if version >= 3.
4848         * ui-out.h (enum ui_out_flag)
4849         <fix_multi_location_breakpoint_output>: New enumerator.
4850
4851 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4852
4853         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4854
4855 2019-05-10  Tom Tromey  <tromey@adacore.com>
4856
4857         * ada-lang.c (catch_ada_completer): New function.
4858         (_initialize_ada_language): Use it.
4859
4860 2019-05-10  Tom Tromey  <tromey@adacore.com>
4861
4862         * thread.c (print_thread_info): Make "requested_threads" const.
4863         * gdbthread.h (print_thread_info): Make "requested_threads"
4864         const.
4865         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4866         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4867
4868 2019-05-08  Tom Tromey  <tom@tromey.com>
4869
4870         * gdbtypes.c (objfile_type_data): Change type.
4871         (objfile_type, _initialize_gdbtypes): Update.
4872
4873 2019-05-08  Tom Tromey  <tom@tromey.com>
4874
4875         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4876         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4877         (_initialize_dwarf2_frame): Update.
4878
4879 2019-05-08  Tom Tromey  <tom@tromey.com>
4880
4881         * objc-lang.c (objc_objfile_data): Change type.
4882         (find_methods): Update.
4883         (_initialize_objc_lang): Remove.
4884
4885 2019-05-08  Tom Tromey  <tom@tromey.com>
4886
4887         * stabsread.c (rs6000_builtin_type_data): Change type.
4888         (rs6000_builtin_type, _initialize_stabsread): Update.
4889
4890 2019-05-08  Tom Tromey  <tom@tromey.com>
4891
4892         * mips-tdep.c (mips_pdr_data): Remove.
4893         (_initialize_mips_tdep): Update.
4894
4895 2019-05-08  Tom Tromey  <tom@tromey.com>
4896
4897         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4898         (hppa_init_objfile_priv_data, read_unwind_info)
4899         (find_unwind_entry, _initialize_hppa_tdep): Update.
4900
4901 2019-05-08  Tom Tromey  <tom@tromey.com>
4902
4903         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4904         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4905         on obstack.
4906         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4907
4908 2019-05-08  Tom Tromey  <tom@tromey.com>
4909
4910         * mdebugread.c (basic_type_data): Change type.
4911         (basic_type, _initialize_mdebugread): Update.
4912
4913 2019-05-08  Tom Tromey  <tom@tromey.com>
4914
4915         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4916
4917 2019-05-08  Tom Tromey  <tom@tromey.com>
4918
4919         * nto-tdep.c (nto_inferior_data_reg): Change type.
4920         (nto_inferior_data): Update.
4921         (nto_inferior_data_cleanup, nto_new_inferior_data)
4922         (_initialize_nto_tdep): Remove.
4923         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4924
4925 2019-05-08  Tom Tromey  <tom@tromey.com>
4926
4927         * ada-lang.c (struct ada_inferior_data): Add initializers.
4928         (ada_inferior_data): Change type.
4929         (ada_inferior_data_cleanup): Remove.
4930         (get_ada_inferior_data, ada_inferior_exit)
4931         (struct ada_pspace_data): Add initializers, destructor.
4932         (ada_pspace_data_handle): Change type.
4933         (get_ada_pspace_data): Update.
4934         (ada_pspace_data_cleanup): Remove.
4935
4936 2019-05-08  Tom Tromey  <tom@tromey.com>
4937
4938         * coffread.c (struct coff_symfile_info): Add initializers.
4939         (coff_objfile_data_key): Move lower.  Change type.
4940         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4941         Update.
4942         (coff_free_info): Remove.
4943
4944 2019-05-08  Tom Tromey  <tom@tromey.com>
4945
4946         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4947         (fbsd_pspace_data_handle): Move lower.  Change type.
4948         (get_fbsd_pspace_data): Update.
4949         (fbsd_pspace_data_cleanup): Remove.
4950         (_initialize_fbsd_tdep): Update.
4951
4952 2019-05-08  Tom Tromey  <tom@tromey.com>
4953
4954         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4955         (get_ada_tasks_pspace_data): Update.
4956         (ada_tasks_pspace_data_cleanup): Remove.
4957         (_initialize_tasks): Update.
4958         (ada_tasks_inferior_data_handle): Change type.
4959         (get_ada_tasks_inferior_data): Update.
4960         (ada_tasks_inferior_data_cleanup): Remove.
4961         (struct ada_tasks_pspace_data): Add initializers.
4962
4963 2019-05-08  Tom Tromey  <tom@tromey.com>
4964
4965         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4966         * symfile-debug.c (debug_sym_get_probes): Change type.
4967         * stap-probe.c (handle_stap_probe):
4968         (stap_static_probe_ops::get_probes): Change type.
4969         * probe.h (class static_probe_ops) <get_probes>: Change type.
4970         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4971         (parse_probes_in_pspace): Update.
4972         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4973         Update.
4974         (any_static_probe_ops::get_probes): Change type.
4975         * elfread.c (elfread_data): New typedef.
4976         (probe_key): Change type.
4977         (elf_get_probes): Likewise.  Update.
4978         (probe_key_free): Remove.
4979         (_initialize_elfread): Update.
4980         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4981         Change type.
4982         (dtrace_process_dof_probe, dtrace_process_dof)
4983         (dtrace_static_probe_ops::get_probe): Change type.
4984
4985 2019-05-08  Tom Tromey  <tom@tromey.com>
4986
4987         * xcoffread.c (struct xcoff_symfile_info): Rename from
4988         coff_symfile_info.  Add initializers.
4989         (xcoff_objfile_data_key): Move lower.  Change type.
4990         (XCOFF_DATA): Rewrite.
4991         (xcoff_free_info): Remove.
4992         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4993         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4994         (xcoff_initial_scan): Update.
4995
4996 2019-05-08  Tom Tromey  <tom@tromey.com>
4997
4998         * solib-svr4.c (struct svr4_info): Add initializers and
4999         destructor.
5000         <probes_table>: Now an htab_up.
5001         (solib_svr4_pspace_data): Change type.
5002         (free_probes_table): Simplify.
5003         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5004         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5005         (probes_table_remove_objfile_probes, register_solib_event_probe)
5006         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5007         (_initialize_svr4_solib): Update.
5008
5009 2019-05-08  Tom Tromey  <tom@tromey.com>
5010
5011         * remote.c (remote_pspace_data): Change type.
5012         (remote_pspace_data_cleanup): Remove.
5013         (get_remote_exec_file, set_pspace_remote_exec_file)
5014         (_initialize_remote): Update.
5015
5016 2019-05-08  Tom Tromey  <tom@tromey.com>
5017
5018         * breakpoint.c (breakpoint_objfile_key): Change type.
5019         (get_breakpoint_objfile_data): Update.
5020         (free_breakpoint_objfile_data): Remove.
5021         (_initialize_breakpoint): Update.
5022
5023 2019-05-08  Tom Tromey  <tom@tromey.com>
5024
5025         * linux-tdep.c (struct linux_info): Add initializers.
5026         (linux_inferior_data): Move.  Change type.
5027         (invalidate_linux_cache_inf): Update.
5028         (linux_inferior_data_cleanup): Remove.
5029         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5030
5031 2019-05-08  Tom Tromey  <tom@tromey.com>
5032
5033         * auxv.c (auxv_inferior_data): Move.  Change type.
5034         (auxv_inferior_data_cleanup): Remove.
5035         (invalidate_auxv_cache_inf): Rewrite.
5036         (get_auxv_inferior_data, _initialize_auxv): Update.
5037
5038 2019-05-08  Tom Tromey  <tom@tromey.com>
5039
5040         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5041         (symfile_debug_objfile_data_key): Change type.
5042         (symfile_debug_installed, debug_qf_has_symbols)
5043         (debug_qf_find_last_source_symtab)
5044         (debug_qf_forget_cached_source_info)
5045         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5046         (debug_qf_print_stats, debug_qf_dump)
5047         (debug_qf_expand_symtabs_for_function)
5048         (debug_qf_expand_all_symtabs)
5049         (debug_qf_expand_symtabs_with_fullname)
5050         (debug_qf_map_matching_symbols)
5051         (debug_qf_expand_symtabs_matching)
5052         (debug_qf_find_pc_sect_compunit_symtab)
5053         (debug_qf_map_symbol_filenames)
5054         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5055         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5056         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5057         (debug_sym_read_linetable, debug_sym_relocate): Update.
5058         (symfile_debug_free_objfile): Remove.
5059         (install_symfile_debug_logging, _initialize_symfile_debug):
5060         Update.
5061
5062 2019-05-08  Tom Tromey  <tom@tromey.com>
5063
5064         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5065         allocate_on_obstack.
5066         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5067         (get_dwarf2_per_objfile): Update.
5068         (set_dwarf2_per_objfile): Remove.
5069         (dwarf2_has_info, dwarf2_get_section_info): Update.
5070         (dwarf2_free_objfile): Remove.
5071         (_initialize_dwarf2_read): Update.
5072
5073 2019-05-08  Tom Tromey  <tom@tromey.com>
5074
5075         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5076         initializers.
5077         <unsupported_script_warning_printed,
5078         script_not_found_warning_printed>: Now bool.
5079         (auto_load_pspace_data): Change type.
5080         (~auto_load_pspace_info): Rename from
5081         auto_load_pspace_data_cleanup.
5082         (get_auto_load_pspace_data, init_loaded_scripts_info)
5083         (clear_section_scripts, maybe_print_unsupported_script_warning)
5084         (maybe_print_script_not_found_warning, _initialize_auto_load):
5085         Update.
5086
5087 2019-05-08  Tom Tromey  <tom@tromey.com>
5088
5089         * objfiles.c (objfile_pspace_info): Add destructor and
5090         initializers.
5091         (objfiles_pspace_data): Change type.
5092         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5093         (get_objfile_pspace_data): Update.
5094         (objfiles_bfd_data): Change type.
5095         (get_objfile_bfd_data): Update.
5096         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5097
5098 2019-05-08  Tom Tromey  <tom@tromey.com>
5099
5100         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5101         Change type.
5102         (get_catch_syscall_inferior_data): Update.
5103         (catch_syscall_inferior_data_cleanup): Remove.
5104         (_initialize_break_catch_syscall): Update.
5105
5106 2019-05-08  Tom Tromey  <tom@tromey.com>
5107
5108         * inflow.c (struct terminal_info): Add destructor and
5109         initializers.
5110         (inflow_inferior_data): Change type.
5111         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5112         (get_inflow_inferior_data, inflow_inferior_exit)
5113         (swap_terminal_info, _initialize_inflow): Update.
5114
5115 2019-05-08  Tom Tromey  <tom@tromey.com>
5116
5117         * target-dcache.c (target_dcache_cleanup): Remove.
5118         (target_dcache_aspace_key): Change type.
5119         (target_dcache_init_p, target_dcache_invalidate)
5120         (target_dcache_get, target_dcache_get_or_init)
5121         (_initialize_target_dcache): Update.
5122         * dcache.h (struct dcache_deleter): New.
5123
5124 2019-05-08  Tom Tromey  <tom@tromey.com>
5125
5126         * symtab.c (struct symbol_cache): Add destructor and
5127         initializers.
5128         (symbol_cache_key): Move.  Change type.
5129         (make_symbol_cache, free_symbol_cache): Remove.
5130         (get_symbol_cache): Update.
5131         (symbol_cache_cleanup): Remove.
5132         (ALL_PSPACES, symbol_cache_flush)
5133         (maintenance_print_symbol_cache)
5134         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5135         Update.
5136
5137 2019-05-08  Tom Tromey  <tom@tromey.com>
5138
5139         * symtab.c (struct main_info): Add destructor and initializers.
5140         (main_progspace_key): Move.  Change type.
5141         (get_main_info): Update.
5142         (main_info_cleanup): Remove.
5143         (_initialize_symtab): Update.
5144
5145 2019-05-08  Tom Tromey  <tom@tromey.com>
5146
5147         * registry.h (DECLARE_REGISTRY): Define the _key class.
5148
5149 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5150
5151         * NEWS: Merge two 'New commands' sections.
5152
5153 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5154
5155         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5156         parameter and use Ada language definition instead.
5157         (ada_val_print_ptr): Remove unused language parameter.
5158         (ada_val_print_num): Remove language parameter and use Ada language
5159         definition instead.
5160         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5161         parameter.
5162         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5163         parameter and use Ada language definition instead.
5164         (ada_val_print_1): Update all ada_val_print_xxx calls.
5165         Remove language parameter.
5166         (ada_val_print): Update ada_val_print_1 call.
5167
5168 2019-05-08  Tom Tromey  <tromey@adacore.com>
5169
5170         * remote.c (remote_hw_watchpoint_limit)
5171         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5172         Now static.
5173
5174 2019-05-08  Tom Tromey  <tromey@adacore.com>
5175
5176         * maint.c (_initialize_maint_cmds): Move initialization code to
5177         remote.c.
5178         (watchdog, show_watchdog): Move to remote.c.
5179         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5180         "watchdog" static.
5181         (_initialize_remote): Move initialization code from maint.c.
5182         * defs.h (watchdog): Don't declare.
5183
5184 2019-05-08  Tom Tromey  <tromey@adacore.com>
5185
5186         * tui/tui-interp.c: Include main.h.
5187         * interps.c: Include main.h.
5188         * main.h (interpreter_p): Declare.
5189         * defs.h (interpreter_p): Don't declare.
5190
5191 2019-05-08  Tom Tromey  <tromey@adacore.com>
5192
5193         * dwarf2loc.c: Include dwarf2read.h.
5194         * defs.h (read_unsigned_leb128): Don't declare.
5195         * dwarf2read.h (read_unsigned_leb128): Declare.
5196
5197 2019-05-08  Tom Tromey  <tromey@adacore.com>
5198
5199         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5200         method.
5201
5202 2019-05-08  Tom Tromey  <tromey@adacore.com>
5203
5204         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5205         when no wrap column is set.
5206
5207 2019-05-08  Tom Tromey  <tromey@adacore.com>
5208
5209         * c-lang.c (c_get_string): Handle non-C-style arrays.
5210
5211 2019-05-08  Tom Tromey  <tromey@adacore.com>
5212
5213         * typeprint.c (print_offset_data::update): Print the bit offset,
5214         not the number of bits remaining.
5215
5216 2019-05-08  Tom Tromey  <tromey@adacore.com>
5217
5218         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5219         padding at end of comment.
5220
5221 2019-05-08  Tom Tromey  <tromey@adacore.com>
5222
5223         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5224         Compare main types.
5225
5226 2019-05-06  Tom Tromey  <tom@tromey.com>
5227
5228         * common/scoped_mmap.c: Include common-defs.h.
5229         * common/scoped_mmap.h: Don't include config.h.
5230
5231 2019-05-04  Tom Tromey  <tom@tromey.com>
5232
5233         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5234         (struct aarch64_call_info): Add initializers.
5235         <si>: Now a std::vector.
5236         (pass_on_stack, aarch64_push_dummy_call): Update.
5237
5238 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5239             Tom Tromey  <tom@tromey.com>
5240
5241         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5242         (ppc_threads): Now a std::vector.  Now static.
5243         (hwdebug_find_thread_points_by_tid)
5244         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5245         Update.
5246
5247 2019-05-04  Tom Tromey  <tom@tromey.com>
5248
5249         * arc-tdep.c (arc_tdesc_init): Return bool.
5250
5251 2019-05-04  Tom Tromey  <tom@tromey.com>
5252
5253         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5254         Use gdb_assert_not_reached.
5255
5256 2019-05-04  Tom Tromey  <tom@tromey.com>
5257
5258         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5259         "false".
5260
5261 2019-05-04  Tom Tromey  <tom@tromey.com>
5262
5263         * arc-tdep.c (arc_tdesc_init): Use bool.
5264
5265 2019-05-04  Tom Tromey  <tom@tromey.com>
5266
5267         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5268
5269 2019-05-04  Tom Tromey  <tom@tromey.com>
5270
5271         * cli/cli-cmds.c (valid_command_p): Return bool.
5272
5273 2019-05-04  Tom Tromey  <tom@tromey.com>
5274
5275         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5276         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5277
5278 2019-05-04  Raul Tambre  <raul@tambre.ee>
5279
5280         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5281         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5282         operator for comparison.
5283
5284 2019-05-04  Tom Tromey  <tom@tromey.com>
5285
5286         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5287         (lookup_partial_symbol, print_partial_symbols)
5288         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5289         (psymbol_compare): Update.
5290         (add_psymbol_to_bcache): Clear the entire psymbol.
5291         (maintenance_check_psymtabs): Update.
5292         * psympriv.h (struct partial_symbol): Don't derive from
5293         general_symbol_info.
5294         <obj_section, unrelocated_address, address,
5295         set_unrelocated_address>: Update.
5296         <ginfo>: New member.
5297         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5298         (debug_names::write_psymbols): Update.
5299
5300 2019-05-04  Tom de Vries  <tdevries@suse.de>
5301
5302         * contrib/cc-with-tweaks.sh: Support -n arg.
5303
5304 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5305
5306         * corelow.c (core_target::detach): Ensure frame cache and
5307         register caches are cleared.
5308         inferior.c (exit_inferior_1): Likewise.
5309
5310 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5311             Tom Tromey  <tom@tromey.com>
5312
5313         * dictionary.c (collate_pending_symbols_by_language): Remove
5314         "struct" from foreach.
5315         * symtab.c (lookup_global_symbol_from_objfile)
5316         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5317         foreach.
5318         * ser-tcp.c (net_open): Remove "struct" from foreach.
5319         * objfiles.c (objfile_relocate, objfile_rebase)
5320         (objfile_has_symbols): Remove "struct" from foreach.
5321         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5322         from foreach.
5323         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5324         foreach.
5325         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5326         "struct" from foreach.
5327         * ada-lang.c (create_excep_cond_exprs)
5328         (ada_exception_catchpoint_cond_string): Remove "struct" from
5329         foreach.
5330
5331 2019-05-03  Tom Tromey  <tromey@adacore.com>
5332
5333         * ada-exp.y (convert_char_literal): Check suffix of each
5334         enumerator.
5335
5336 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5337
5338         PR ada/21406:
5339         * ada-exp.y (yywrap): Don't define.
5340         * ada-lex.l (%option): Add noyywrap
5341         (yywrap): Remove.
5342
5343 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5344
5345         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5346         _WIN32_WINNT to the XP level, unless already defined to a higher
5347         level.
5348
5349         * unittests/parse-connection-spec-selftests.c:
5350         * ser-tcp.c:
5351         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5352         override.
5353
5354         * symfile.c (find_separate_debug_file): Remove colon from the
5355         drive spec of DOS/Windows file names of the target, so that the
5356         file name produced from DEBUGDIR and the target's directory will
5357         be valid on DOS/Windows systems.
5358
5359 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5360
5361         * rust-lang.c (val_print_struct): Handle printing structures
5362         containing strings.
5363
5364 2019-05-02  Tom Tromey  <tromey@adacore.com>
5365
5366         * valarith.c (_initialize_valarith): Remove.
5367
5368 2019-05-01  Tom Tromey  <tromey@adacore.com>
5369
5370         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5371         bitfields.
5372
5373 2019-05-01  Tom Tromey  <tromey@adacore.com>
5374
5375         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5376         for big-endian copies.
5377
5378 2019-04-30  Ali Tamur  <tamur@google.com>
5379         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5380         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5381         (read_3_bytes): New function.
5382
5383 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5384
5385         * windows-nat.c (main_thread_id): Delete.
5386         (handle_output_debug_string): Replace main_thread_id by
5387         current_event.dwThreadId.
5388         (fake_create_process): Likewise.
5389         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5390         Do not set main_thread_id.
5391         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5392         current_event.dwThreadId.
5393         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5394
5395 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5396
5397         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5398         Use current_event.dwThreadId instead of main_thread_id.
5399
5400 2019-04-30  Tom Tromey  <tromey@adacore.com>
5401
5402         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5403         (create_excep_cond_exprs): Iterate over program spaces.
5404         (ada_exception_catchpoint_cond_string): Examine all minimal
5405         symbols for exception types.
5406
5407 2019-04-30  Tom Tromey  <tromey@adacore.com>
5408
5409         PR c++/24470:
5410         * dwarf2read.c (process_structure_scope): Handle case where type
5411         has template parameters but no symbol was created.
5412
5413 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5414             Chris January  <chris.january@arm.com>
5415
5416         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5417         qualifier.
5418         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5419
5420 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5421
5422         * f-typeprint.c (f_print_type): Update rules for printing
5423         whitespace.
5424         (f_type_print_varspec_suffix): Likewise.
5425
5426 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5427             Chris January  <chris.january@arm.com>
5428
5429         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5430         function arguments.
5431
5432 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * f-lang.c (build_fortran_types): Change name of void type to
5435         lower case.
5436         * f-typeprint.c (f_type_print_base): Print the name of the void
5437         type, rather than a fixed string.
5438         * f-valprint.c (f_decorations): Use lower case void string.
5439
5440 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5441             Chris January  <chris.january@arm.com>
5442
5443         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5444         types for Fortran.
5445
5446 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5447             Chris January  <chris.january@arm.com>
5448             David Lecomber  <david.lecomber@arm.com>
5449
5450         * f-exp.y (BINOP_INTRINSIC): New token.
5451         (exp): New parser rule handling BINOP_INTRINSIC.
5452         (f77_keywords): Add new builtin procedures.
5453         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5454         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5455         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5456         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5457         (print_unop_subexp_f): New function.
5458         (print_binop_subexp_f): New function.
5459         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5460         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5461         (dump_subexp_body_f): Likewise.
5462         (operator_check_f): Likewise.
5463         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5464         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5465
5466 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5467
5468         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5469         UNOP_KIND.
5470         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5471         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5472         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5473         (operator_length_f): New fuction.
5474         (print_subexp_f): New function.
5475         (op_name_f): New function.
5476         (dump_subexp_body_f): New function.
5477         (operator_check_f): New function.
5478         (exp_descriptor_f): Replace standard expression handling functions
5479         with new functions.
5480         * gdb/fortran-operator.def: New file.
5481         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5482         * gdb/std-operator.def: Remove UNOP_KIND.
5483
5484 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5485
5486         * std-operator.def: Remove unbalanced, stray double quote
5487         character.
5488
5489 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5490             Chris January  <chris.january@arm.com>
5491             Daniel Everett  <daniel.everett@arm.com>
5492             Nick Forrington  <nick.forrington@arm.com>
5493             Richard Bunt  <richard.bunt@arm.com>
5494
5495         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5496         of depth when printing anonymous structs or unions.
5497         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5498         Don't print either the top-level value, or the children if the
5499         max-depth is exceeded.
5500         (ppscm_print_children): When printing the key of a map, allow one
5501         extra level of depth.
5502         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5503         print either the top-level value, or the children if the max-depth
5504         is exceeded.
5505         (print_children): When printing the key of a map, allow one extra
5506         level of depth.
5507         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5508         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5509         (user_print_options): Initialise max_depth field.
5510         (val_print_scalar_or_string_type_p): New function.
5511         (val_print): Check to see if the max depth has been reached.
5512         (val_print_check_max_depth): Define new function.
5513         (show_print_max_depth): New function.
5514         (_initialize_valprint): Add 'print max-depth' option.
5515         * valprint.h (struct value_print_options) <max_depth>: New field.
5516         (val_print_check_max_depth): Declare new function.
5517         * NEWS: Document new feature.
5518
5519 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5520
5521         * ada-lang.c (ada_language_defn): Initialise new field.
5522         * c-lang.c (c_is_string_type_p): New function.
5523         (c_language_defn): Initialise new field.
5524         (cplus_language_defn): Initialise new field.
5525         (asm_language_defn): Initialise new field.
5526         (minimal_language_defn): Initialise new field.
5527         * c-lang.h (c_is_string_type_p): Declare new function.
5528         * d-lang.c (d_language_defn): Initialise new field.
5529         * f-lang.c (f_is_string_type_p): New function.
5530         (f_language_defn): Initialise new field.
5531         * go-lang.c (go_is_string_type_p): New function.
5532         (go_language_defn): Initialise new field.
5533         * language.c (default_is_string_type_p): New function.
5534         (unknown_language_defn): Initialise new field.
5535         (auto_language_defn): Initialise new field.
5536         * language.h (struct language_defn) <la_is_string_type_p>: New
5537         member variable.
5538         (default_is_string_type_p): Declare new function.
5539         * m2-lang.c (m2_language_defn): Initialise new field.
5540         * objc-lang.c (objc_language_defn): Initialise new field.
5541         * opencl-lang.c (opencl_language_defn): Initialise new field.
5542         * p-lang.c (pascal_is_string_type_p): New function.
5543         (pascal_language_defn): Initialise new field.
5544         * rust-lang.c (rust_is_string_type_p): New function.
5545         (rust_language_defn): Initialise new field.
5546
5547 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5548
5549         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5550         New field.
5551         * ada-lang.c (ada_language_defn): Initialise new field.
5552         * c-lang.c (c_language_defn): Likewise.
5553         (cplus_language_defn): Likewise.
5554         (asm_language_defn): Likewise.
5555         (minimal_language_defn): Likewise.
5556         * d-lang.c (d_language_defn): Likewise.
5557         * f-lang.c (f_language_defn): Likewise.
5558         * go-lang.c (go_language_defn): Likewise.
5559         * language.c (unknown_language_defn): Likewise.
5560         (auto_language_defn): Likewise.
5561         * m2-lang.c (m2_language_defn): Likewise.
5562         * objc-lang.c (objc_language_defn): Likewise.
5563         * opencl-lang.c (opencl_language_defn): Likewise.
5564         * p-lang.c (pascal_language_defn): Likewise.
5565         * rust-lang.c (rust_language_defn): Likewise.
5566
5567 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5568
5569         * ada-lang.c (ada_is_character_type): Change return type to bool.
5570         (ada_is_string_type): Likewise.
5571         * ada-lang.h (ada_is_character_type): Update declaration
5572         (ada_is_string_type): Likewise.
5573
5574 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5575
5576         Support style in 'frame|thread apply'
5577
5578         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5579         * record.c (record_start, record_stop): Update callers of
5580         execute_command_to_string with false.
5581         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5582         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5583         methods.
5584         (class string_file): New constructor with term_out parameter.
5585         Override methods term_out and can_emit_style_escape.  New member
5586         term_out.
5587         (class stdio_file): Override can_emit_style_escape.
5588         (class tee_file): Override term_out and can_emit_style_escape.
5589         * utils.h (can_emit_style_escape): Remove.
5590         * utils.c (can_emit_style_escape): Likewise.
5591         Update all callers of can_emit_style_escape (SOMESTREAM) to
5592         SOMESTREAM->can_emit_style_escape.
5593         * source-cache.c (source_cache::get_source_lines): Likewise.
5594         * stack.c (frame_apply_command_count): Call execute_command_to_string
5595         passing the term_out characteristic of the current gdb_stdout.
5596         * thread.c (thr_try_catch_cmd): Likewise.
5597         * top.c (execute_command_to_string): pass term_out parameter
5598         to construct the string_file for the command output.
5599         * ui-file.c (term_cli_styling): New function (most code moved
5600         from utils.c can_emit_style_escape).
5601         (string_file::string_file, string_file::can_emit_style_escape,
5602         stdio_file::can_emit_style_escape, tee_file::term_out,
5603         tee_file::can_emit_style_escape): New functions.
5604
5605 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5606
5607         * NEWS: Mention the new set|show may-call-functions.
5608         * infcall.c (may_call_functions_p): New variable.
5609         (show_may_call_functions_p): New function.
5610         (call_function_by_hand_dummy): Throws an error if not
5611         may-call-functions.
5612         (_initialize_infcall): Call add_setshow_boolean_cmd for
5613         may-call-functions.
5614
5615 2019-04-25  Keith Seitz  <keiths@redhat.com>
5616
5617         PR c++/24367
5618         * cp-support.c (inspect_type): Don't attempt substitutions
5619         of symbol with the same name.
5620
5621 2019-04-25  Tom Tromey  <tromey@adacore.com>
5622
5623         PR gdb/24475:
5624         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5625         static.
5626
5627 2019-04-25  Tom Tromey  <tromey@adacore.com>
5628
5629         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5630         rvalue reference.
5631         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5632         (gdb_xml_parser::parse): Use std::move.
5633         * python/python-internal.h (gdbpy_convert_exception): Take a const
5634         reference.
5635         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5636         std::move.
5637         * python/py-utils.c (gdbpy_convert_exception): Take a const
5638         reference.
5639         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5640         Use std::move.
5641         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5642         Use std::move.
5643         * mi/mi-main.c (mi_print_exception): Take a const reference.
5644         * main.c (handle_command_errors): Take a const reference.
5645         * linespec.c (parse_linespec): Use std::move.
5646         * infcall.c (run_inferior_call): Use std::move.
5647         (call_function_by_hand_dummy): Use std::move.
5648         * exec.c (try_open_exec_file): Use std::move.
5649         * exceptions.h (exception_print, exception_fprintf)
5650         (exception_print_same): Update.
5651         * exceptions.c (print_exception, exception_print)
5652         (exception_fprintf, exception_print_same): Change parameters to
5653         const reference.
5654         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5655         * common/new-op.c: Use std::move.
5656         * common/common-exceptions.h (struct gdb_exception): Add move
5657         constructor.
5658         (struct gdb_exception_error, struct gdb_exception_quit, struct
5659         gdb_quit_bad_alloc): Change constructor to move constructor.
5660         (throw_exception): Change parameter to rvalue reference.
5661         * common/common-exceptions.c (throw_exception): Take rvalue
5662         reference.
5663         * cli/cli-interp.c (safe_execute_command): Use std::move.
5664         * breakpoint.c (insert_bp_location, location_to_sals): Use
5665         std::move.
5666
5667 2019-04-25  Tom Tromey  <tromey@adacore.com>
5668
5669         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5670         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5671         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5672         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5673         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5674         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5675         guile/scm-value.c: Use unpack.
5676         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5677         gdbscm_gdb_exception.
5678         (gdbscm_throw_gdb_exception): Likewise.
5679         (struct gdbscm_gdb_exception): New.
5680         (unpack): New function.
5681         (gdbscm_wrap): Use unpack.
5682
5683 2019-04-25  Tom Tromey  <tromey@adacore.com>
5684
5685         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5686         (gdb_rl_callback_handler): Use std::move.
5687         * common/common-exceptions.h (struct gdb_exception): Add move
5688         assignment operator.
5689         (throw_exception_sjlj): Change "exception" to const reference.
5690         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5691         (throw_exception_sjlj): Change "exception" to const reference.
5692
5693 2019-04-25  Tom Tromey  <tromey@adacore.com>
5694
5695         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5696         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5697         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5698         Update.
5699         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5700         Update.
5701         * mi/mi-interp.c (mi_interp::exec): Update.
5702         * linespec.c (parse_linespec): Update.
5703         * infcall.c (run_inferior_call): Update.
5704         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5705         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5706         (gdbscm_lookup_global_symbol): Update.
5707         * guile/scm-param.c (gdbscm_parameter_value): Update.
5708         * guile/scm-frame.c (gdbscm_frame_read_register)
5709         (gdbscm_frame_read_var): Update.
5710         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5711         * exec.c (try_open_exec_file): Update.
5712         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5713         (gdb_rl_callback_handler): Update.
5714         * common/common-exceptions.h (exception_none): Don't declare.
5715         * common/common-exceptions.c (exception_none): Don't define.
5716         (struct catcher) <exception>: Update.
5717         * cli/cli-interp.c (safe_execute_command): Update.
5718         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5719
5720 2019-04-25  Ali Tamur  <tamur@google.com>
5721
5722         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5723         (read_attribute_value): Likewise.
5724         (dwarf2_read_addr_index): Update comment.
5725         (read_str_index): Add DW_FORM_strx.
5726         (dwarf2_string_attr): Likewise.
5727         (dwarf2_const_value_attr): Likewise.
5728         (dump_die_shallow): Likewise.
5729         (dwarf2_fetch_constant_bytes): Likewise.
5730         (skip_form_bytes): Likewise.
5731         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5732
5733 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5734
5735         PR corefiles/11608
5736         PR corefiles/18187
5737         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5738         OFFSET.  Verify if current mapping contains an ELF header.
5739         (linux_find_memory_regions_full): Adjust call to
5740         dump_mapping_p.
5741
5742 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5743             Kang Li <kanglictf@gmail.com>
5744
5745         PR gdb/21600
5746
5747         * dwarf2-frame.c (read_initial_length): Be consistent about using
5748         unsigned representation of length.
5749         (decode_frame_entry_1): Likewise.  Check for wraparound of
5750         end pointer as well as buffer overflow.
5751
5752 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5753
5754         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5755         "vq".
5756
5757 2019-04-24  Tom Tromey  <tromey@adacore.com>
5758
5759         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5760
5761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5762
5763         * s12z-tdep.c (s12z_unwind_pc): Delete.
5764         (s12z_unwind_sp): Delete.
5765         (s12z_gdbarch_init): Don't register deleted functions with
5766         gdbarch.
5767
5768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5769
5770         * rl78-tdep.c (rl78_unwind_sp): Delete.
5771         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5772
5773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5774
5775         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5776         (xstormy16_unwind_pc): Delete.
5777         (xstormy16_dummy_id): Delete.
5778         (xstormy16_gdbarch_init): Don't register deleted functions with
5779         gdbarch.
5780
5781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5782
5783         * vax-tdep.c (vax_unwind_pc): Delete.
5784         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5785
5786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5787
5788         * v850-tdep.c (v850_unwind_sp): Delete.
5789         (v850_unwind_pc): Delete.
5790         (v850_dummy_id): Delete.
5791         (v850_gdbarch_init): Don't register deleted functions with
5792         gdbarch.
5793
5794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5795
5796         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5797         (tilegx_unwind_pc): Delete.
5798         (tilegx_unwind_dummy_id): Delete.
5799         (tilegx_gdbarch_init): Don't register deleted functions with
5800         gdbarch.
5801
5802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5803
5804         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5805         (tic6x_dummy_id): Delete.
5806         (tic6x_gdbarch_init): Don't register deleted functions with
5807         gdbarch.
5808
5809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5810
5811         * sparc-tdep.c (sparc_unwind_pc): Delete.
5812         (sparc32_gdbarch_init): Don't register deleted function with
5813         gdbarch.
5814
5815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * sh-tdep.c (sh_unwind_sp): Delete.
5818         (sh_unwind_pc): Delete.
5819         (sh_dummy_id): Delete.
5820         (sh_gdbarch_init): Don't register deleted functions with
5821         gdbarch.
5822
5823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5824
5825         * score-tdep.c (score_unwind_sp): Delete.
5826         (score_unwind_pc): Delete.
5827         (score_dummy_id): Delete.
5828         (score_gdbarch_init): Don't register deleted functions with
5829         gdbarch.
5830
5831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5832
5833         * rx-tdep.c (rx_unwind_pc): Delete.
5834         (rx_unwind_sp): Delete.
5835         (rx_dummy_id): Delete.
5836         (rx_gdbarch_init): Don't register deleted functions with
5837         gdbarch.  Update comment.
5838
5839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5840
5841         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5842         (rs6000_dummy_id): Delete.
5843         (rs6000_gdbarch_init): Don't register deleted functions with
5844         gdbarch.
5845
5846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5847
5848         * or1k-tdep.c (or1k_dummy_id): Delete.
5849         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5850
5851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5852
5853         * nios2-tdep.c (nios2_dummy_id): Delete.
5854         (nios2_unwind_sp): Delete.
5855         (nios2_gdbarch_init): Don't register deleted functions with
5856         gdbarch.
5857
5858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5859
5860         * nds32-tdep.c (nds32_dummy_id): Delete.
5861         (nds32_unwind_pc): Delete.
5862         (nds32_unwind_sp): Delete.
5863         (nds32_gdbarch_init): Don't register deleted functions with
5864         gdbarch.
5865
5866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5867
5868         * msp430-tdep.c (msp430_unwind_pc): Delete.
5869         (msp430_unwind_sp): Delete.
5870         (msp430_dummy_id): Delete.
5871         (msp430_gdbarch_init): Don't register deleted functions with
5872         gdbarch.
5873
5874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5875
5876         * moxie-tdep.c (moxie_unwind_sp): Delete.
5877         (moxie_unwind_pc): Delete.
5878         (moxie_dummy_id): Delete.
5879         (moxie_gdbarch_init): Don't register deleted functions with
5880         gdbarch.
5881
5882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5885         (mn10300_unwind_pc): Delete.
5886         (mn10300_unwind_sp): Delete.
5887         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5888         mn10300_unwind_sp.
5889         (mn10300_frame_unwind_init): Don't register deleted functions with
5890         gdbarch.
5891
5892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5893
5894         * mep-tdep.c (mep_unwind_pc): Delete.
5895         (mep_unwind_sp): Delete.
5896         (mep_dummy_id): Delete.
5897         (mep_gdbarch_init): Don't register deleted functions with
5898         gdbarch.
5899
5900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5901
5902         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5903         (m68hc11_unwind_sp): Delete.
5904         (m68hc11_gdbarch_init): Don't register deleted functions with
5905         gdbarch.
5906
5907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5908
5909         * m32r-tdep.c (m32r_unwind_sp): Delete.
5910         (m32r_unwind_pc): Delete.
5911         (m32r_dummy_id): Delete.
5912         (m32r_gdbarch_init): Don't register deleted functions with
5913         gdbarch.
5914
5915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5916
5917         * m32c-tdep.c (m32c_unwind_pc): Delete.
5918         (m32c_unwind_sp): Delete.
5919         (m32c_dummy_id): Delete.
5920         (m32c_gdbarch_init): Don't register deleted functions with
5921         gdbarch.
5922
5923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5924
5925         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5926         (lm32_unwind_pc): Delete.
5927         (lm32_dummy_id): Delete.
5928         (lm32_gdbarch_init): Don't register deleted functions with
5929         gdbarch.
5930
5931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5932
5933         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5934         (iq2000_unwind_pc): Delete.
5935         (iq2000_dummy_id): Delete.
5936         (iq2000_gdbarch_init): Don't register deleted functions with
5937         gdbarch.
5938
5939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * nds32-tdep.c (nds32_type_align): Delete.
5942         (nds32_push_dummy_call): Use type_align instead.
5943
5944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5945
5946         * arm-tdep.c (arm_type_align): Only handle vector override case.
5947         (arm_push_dummy_call): Use type_align.
5948         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5949
5950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5951
5952         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5953         case.
5954         (pass_on_stack): Use type_align.
5955         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5956         function.
5957
5958 2019-04-23  Tom Tromey  <tromey@adacore.com>
5959
5960         * dwarf2read.c (line_header::file_name_at): Remove unused
5961         overload.
5962
5963 2019-04-23  Tom de Vries  <tdevries@suse.de>
5964
5965         PR gdb/24438
5966         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5967         invocation.
5968
5969
5970 2019-03-27  Ali Tamur  <tamur@google.com>
5971
5972         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5973         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5974         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5975         (dwarf_expr_context::get_addr_index): Likewise
5976         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5977         (symbol_needs_eval_context::get_addr_index): Likewise
5978         (disassemble_dwarf_expression): Add DW_OP_addrx
5979         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5980         (read_cutu_die_from_dwo): Update comment
5981         (skip_one_die): Add DW_FORM_addrx
5982         (read_attribute_value): Likewise
5983         (var_decode_location): Add DW_OP_addrx
5984         (dwarf2_const_value_attr): Add DW_FORM_addrx
5985         (dump_die_shallow): Likewise
5986         (dwarf2_fetch_constant_bytes): Likewise
5987         (decode_locdesc): Add DW_OP_addrx
5988         (skip_form_bytes): Add DW_FORM_addrx
5989
5990 2019-04-22  Ali Tamur  <tamur@google.com>
5991
5992         * MAINTAINERS (Write After Approval): Add self.
5993
5994 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5995
5996         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5997         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5998         (open_symbol_file_object): Likewise.
5999         (svr4_default_sos): Add info parameter.
6000         (svr4_read_so_list): Likewise.
6001         (svr4_current_sos_direct): Adjust functions calls to pass down
6002         info.
6003         (svr4_current_sos_1): Add info parameter.
6004         (svr4_current_sos): Call get_svr4_info, pass info down to
6005         svr4_current_sos_1.
6006         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6007         get_svr4_info.
6008         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6009         get_svr4_info.
6010         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6011         to get_svr4_info.
6012         (probes_table_remove_objfile_probes): Likewise.
6013         (register_solib_event_probe): Add info parameter.
6014         (solist_update_incremental): Pass info parameter down to
6015         svr4_read_so_list.
6016         (disable_probes_interface): Add info parameter.
6017         (svr4_handle_solib_event): Pass current_program_space to
6018         get_svr4_info.  Adjust disable_probes_interface cleanup.
6019         (svr4_create_probe_breakpoints): Add info parameter, pass it
6020         down to register_solib_event_probe.
6021         (svr4_create_solib_event_breakpoints): Add info parameter,
6022         pass it down to svr4_create_probe_breakpoints.
6023         (enable_break): Pass info down to
6024         svr4_create_solib_event_breakpoints.
6025         (svr4_solib_create_inferior_hook): Pass current_program_space to
6026         get_svr4_info.
6027         (svr4_clear_solib): Likewise.
6028
6029 2019-04-22  Pedro Alves  <palves@redhat.com>
6030
6031         * solib-svr4.c (svr4_free_objfile_observer): New.
6032         (probe_and_action::objfile): New field.
6033         (probes_table_htab_remove_objfile_probes)
6034         (probes_table_remove_objfile_probes): New functions.
6035         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6036         in the new probe_and_action.  Don't store the probe in 'lookup'.
6037         (svr4_create_probe_breakpoints): Pass objfile to
6038         register_solib_event_probe.
6039         (_initialize_svr4_solib): Register a free_objfile observer.
6040
6041 2019-04-19  Tom Tromey  <tom@tromey.com>
6042
6043         * common/queue.h: Remove.
6044
6045 2019-04-19  Tom Tromey  <tom@tromey.com>
6046
6047         * event-loop.c: Don't include "common/queue.h".
6048
6049 2019-04-19  Tom Tromey  <tom@tromey.com>
6050
6051         * remote.c (remote_target): Use delete.
6052         * remote-notif.h: Include <list>, not "common/queue.h".
6053         (notif_client_p): Remove typedef.
6054         (remote_notif_state): Add constructor, destructor, initializer.
6055         <notif_queue>: Now a std::list.
6056         (remote_notif_state_xfree): Don't declare.
6057         * remote-notif.c (remote_notif_process, handle_notification)
6058         (remote_notif_state_allocate): Update.
6059         (~remote_notif_state): Rename from remote_notif_state_xfree.
6060
6061 2019-04-19  Tom Tromey  <tom@tromey.com>
6062
6063         * symfile.c (reread_symbols): Update.
6064         * objfiles.c (objfile_register_static_link)
6065         (objfile_lookup_static_link): Update
6066         (~objfile) Don't delete static_links.
6067         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6068
6069 2019-04-19  Tom Tromey  <tom@tromey.com>
6070
6071         * type-stack.h (struct type_stack) <insert>: Constify string.
6072         * type-stack.c (type_stack::insert): Constify string.
6073         * gdbtypes.h (lookup_template_type): Update.
6074         (address_space_name_to_int): Update.
6075         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6076         const.
6077         (lookup_template_type): Make name const.
6078         * c-exp.y: Update rules.
6079         (lex_one_token, classify_name, classify_inner_name)
6080         (c_print_token): Update.
6081         * p-exp.y: Update rules.
6082         (yylex): Update.
6083         * f-exp.y: Update rules.
6084         (yylex): Update.
6085         * d-exp.y: Update rules.
6086         (lex_one_token, classify_name, classify_inner_name): Update.
6087         * parse.c (write_dollar_variable, copy_name): Return std::string.
6088         * parser-defs.h (copy_name): Change return type.
6089         * m2-exp.y: Update rules.
6090         (yylex): Update.
6091         * go-exp.y (lex_one_token): Update.
6092         Update rules.
6093         (classify_unsafe_function, classify_packaged_name)
6094         (classify_name, yylex): Update.
6095
6096 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6097
6098         * configure.ac: add --enable-source-highlight switch.
6099         * configure: Regenerate.
6100         * top.c (print_gdb_version): plumb --enable-source-highlight
6101         status to "show configuration".
6102
6103 2019-04-19  Tom Tromey  <tromey@adacore.com>
6104
6105         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6106         Check ADA_TYPE_P.
6107         (empty_record, ada_template_to_fixed_record_type_1)
6108         (template_to_static_fixed_type)
6109         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6110         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6111         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6112         macros.
6113
6114 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6115
6116         PR symtab/24423:
6117         * source.c (print_source_lines_base): Advance "iter" when a
6118         control character is seen.
6119
6120 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6121
6122         * inferior.h (struct infcall_suspend_state_deleter):
6123         Catch exception in destructor to avoid crash.
6124
6125 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6126
6127         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6128         close to the add_com "shell".
6129
6130 2019-04-18  Tom Tromey  <tromey@adacore.com>
6131
6132         * process-stratum-target.h (class process_stratum_target)
6133         <stratum>: Add "final".
6134
6135 2019-04-17  Tom Tromey  <tromey@adacore.com>
6136
6137         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6138         against nullptr before use.
6139
6140 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6141
6142         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6143
6144 2019-04-17  Jim Wilson  <jimw@sifive.com>
6145             Andrew Burgess  <andrew.burgess@embecosm.com>
6146
6147         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6148         code read might fail, assume 4-byte breakpoint in that case.
6149
6150 2019-04-15  Leszek Swirski  <leszeks@google.com>
6151
6152         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6153         rather than a hand-rolled POD check when checking for forced MEMORY
6154         classification.
6155
6156 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6157
6158         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6159         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6160         function.
6161         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6162         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6163         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6164         declaration.
6165
6166 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6167
6168         * aarch64-linux-nat.c
6169         (aarch64_linux_nat_target::thread_architecture): Add override.
6170         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6171         each VQ.
6172
6173 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6174
6175         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6176
6177 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6178
6179         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6180         target types of size 96-bits, add some additional comments, and
6181         check that the builtin type we found was the correct size.
6182
6183 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6184
6185         * utils.c (prompt_for_continue): Don't restore the styling at the
6186         end, as applied_style has the wrong value.  This fixes styling in
6187         long lists of file names that are interrupted by the "Continue?"
6188         prompt.
6189
6190 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6191
6192         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6193         * c-lang.c (c_language_defn): Likewise.
6194         (cplus_language_defn): Likewise.
6195         (asm_language_defn): Likewise.
6196         (minimal_language_defn): Likewise.
6197         * d-lang.c (d_language_defn): Likewise.
6198         * f-lang.c (f_language_defn): Likewise.
6199         * go-lang.c (go_language_defn): Likewise.
6200         * language.c (unknown_language_defn): Likewise.
6201         (auto_language_defn): Likewise.
6202         * language.h (struct language_defn): Remove la_magic field.
6203         (LANG_MAGIC): Delete.
6204         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6205         * objc-lang.c (objc_language_defn): Likewise.
6206         * opencl-lang.c (opencl_language_defn): Likewise.
6207         * p-lang.c (pascal_language_defn): Likewise.
6208         * rust-lang.c (rust_language_defn): Likewise.
6209
6210 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6211
6212         * riscv-tdep.c (riscv_type_align): New function.
6213         (riscv_type_alignment): Delete.
6214         (riscv_arg_location): Use 'type_align'.
6215         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6216
6217 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6218
6219         * gdbtypes.c (type_align): A struct with no non-static fields also
6220         has alignment of 1.
6221
6222 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6223
6224         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6225         component to 0.
6226         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6227         member.
6228         (riscv_struct_info::analyse): New implementation using new
6229         analyse_inner member function.
6230         (riscv_struct_info::field_offset): New member function.
6231         (riscv_struct_info::m_offsets): New member variable.
6232         (riscv_struct_info::analyse_inner): New private member function,
6233         takes the old implementation of riscv_struct_info::analyse but
6234         extended to track field offsets.
6235         (riscv_call_arg_struct): Update the struct folding special cases
6236         to handle cases where empty C++ structs, which are non-zero
6237         length, are found.
6238         (riscv_arg_location): Initialise the length of each location, a
6239         non-zero length now indicates the location is in use.
6240         (riscv_push_dummy_call): Allow for the first location having a
6241         non-zero offset when setting up arguments.
6242         (riscv_return_value): Likewise, but for return values.
6243
6244 2019-04-11  Tom Tromey  <tromey@adacore.com>
6245
6246         * utils.c (internal_vproblem): Make "msg" const.
6247
6248 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6249
6250         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6251         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6252         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6253         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6254
6255 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6256
6257         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6258         function.
6259         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6260         of amd64_collect_native_gregset.
6261         (amd64_linux_nat_target::store_registers): Likewise.
6262
6263 2019-04-10  Tom Tromey  <tom@tromey.com>
6264
6265         * symtab.c (lookup_global_symbol_from_objfile)
6266         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6267         * objfiles.h (class separate_debug_iterator): New.
6268         (class separate_debug_range): New.
6269         (struct objfile) <separate_debug_objfiles>: New method.
6270         (objfile_separate_debug_iterate): Don't declare.
6271         * objfiles.c (separate_debug_iterator::operator++): Rename from
6272         objfile_separate_debug_iterate.
6273         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6274         iterator.
6275         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6276         iterator.
6277
6278 2019-04-10  Tom Tromey  <tom@tromey.com>
6279
6280         * symfile.c (reread_symbols): Remove old comment.
6281         * objfiles.c (free_all_objfiles): Fix a typo.
6282
6283 2019-04-10  Tom Tromey  <tom@tromey.com>
6284
6285         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6286         * minsyms.c (lookup_minimal_symbol): Use foreach.
6287         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6288         (lookup_minimal_symbol_solib_trampoline): Likewise.
6289         * symfile.c (reread_symbols): Use foreach.
6290
6291 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6292             Tom Tromey  <tromey@adacore.com>
6293
6294         PR rust/24414:
6295         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6296         (rust_lex_int_test): Change "value" to be LONGEST.
6297         (rust_lex_tests): Add test for long integer literal.
6298
6299 2019-04-09  Tom Tromey  <tromey@adacore.com>
6300
6301         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6302         to bool.
6303         (extended_remote_target::attach): Update.
6304         (remote_target::remote_notice_new_inferior): Update.
6305         (remote_target::add_current_inferior_and_thread): Update.
6306         * inferior.c (exit_inferior_1): Use "false".
6307         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6308
6309 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6310
6311         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6312         the "start" command.
6313
6314 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6315
6316         * python/py-inferior.c (infpy_thread_from_thread_handle):
6317         Adjust comments to reflect renaming of thread_from_thread_handle
6318         to thread_from_handle.  Adjust keywords.  Fix type error message.
6319         (inferior_object_methods): Add thread_from_handle.  Retain
6320         thread_from_thread_handle, but mark it as deprecated.
6321
6322 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6323
6324         * gdbthread.h (find_thread_by_handle): Revise declaration.
6325         * thread.c (find_thread_by_handle): Likewise.  Adjust
6326         implementation too.
6327         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6328         support for buffer objects as handles.
6329
6330 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6331
6332         * python/py-infthread.c (thpy_thread_handle): New function.
6333         (thread_object_methods): Register thpy_thread_handle.
6334
6335 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6336
6337         * gdbthread.h (thread_to_thread_handle): Declare.
6338         * thread.c (gdbtypes.h): Include.
6339         (thread_to_thread_handle): New function.
6340
6341         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6342         (target_thread_info_to_thread_handle): Declare.
6343         * target.c (target_thread_info_to_thread_handle): New function.
6344         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6345         * target-delegates.c: Regenerate.
6346
6347         * linux-thread-db.c (class thread_db_target): Add method
6348         thread_info_to_thread_handle.
6349         (thread_db_target::thread_info_to_thread_handle): Define.
6350         * remote.c (class remote_target): Add new method
6351         thread_info_to_thread_handle.
6352         (remote_target::thread_info_to_thread_handle): Define.
6353
6354 2019-04-08  Pedro Alves  <palves@redhat.com>
6355
6356         * common/common-exceptions.c (throw_exception): Don't create
6357         named object to throw; throw directly.
6358         (throw_it): Likewise.  Don't initialize gdb_exception::message
6359         here, with new; pass FMT and AP to the ctor instead.
6360         * common/common-exceptions.h: Include <string>.
6361         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6362         const char *, va_list)): New ctor.  Use std::make_shared.
6363         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6364         errors)): Delete.
6365         (gdb_exception_error::gdb_exception_error(enum errors, const char
6366         *, va_list)): New.
6367         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6368         Add assertion.
6369         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6370         errors)): Delete.
6371         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6372         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6373         Add assertion.
6374
6375 2019-04-08  Tom Tromey  <tom@tromey.com>
6376
6377         * valops.c (value_rtti_indirect_type): Replace throw_exception
6378         with throw.
6379         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6380         with throw.
6381         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6382         throw.
6383         * target.c (target_translate_tls_address): Replace throw_exception
6384         with throw.
6385         * stack.c (frame_apply_command_count): Replace throw_exception
6386         with throw.
6387         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6388         throw.
6389         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6390         with throw.
6391         * rs6000-tdep.c (rs6000_frame_cache)
6392         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6393         * remote.c: Replace throw_exception with throw.
6394         * record-full.c (record_full_message, record_full_wait_1)
6395         (record_full_restore): Replace throw_exception with throw.
6396         * record-btrace.c:
6397         (get_thread_current_frame_id, record_btrace_start_replaying)
6398         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6399         (cmd_record_btrace_start): Replace throw_exception with throw.
6400         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6401         throw.
6402         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6403         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6404         * linespec.c:
6405         (find_linespec_symbols): Replace throw_exception with throw.
6406         * infrun.c (displaced_step_prepare, resume): Replace
6407         throw_exception with throw.
6408         * infcmd.c (post_create_inferior): Replace throw_exception with
6409         throw.
6410         * inf-loop.c (inferior_event_handler): Replace throw_exception
6411         with throw.
6412         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6413         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6414         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6415         (get_prev_frame_always, get_frame_pc_if_available)
6416         (get_frame_address_in_block_if_available, get_frame_language):
6417         Replace throw_exception with throw.
6418         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6419         throw_exception with throw.
6420         * eval.c (fetch_subexp_value, evaluate_var_value)
6421         (evaluate_funcall, evaluate_subexp_standard): Replace
6422         throw_exception with throw.
6423         * dwarf2loc.c (call_site_find_chain)
6424         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6425         Replace throw_exception with throw.
6426         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6427         with throw.
6428         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6429         throw.
6430         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6431         * completer.c (complete_line_internal): Replace throw_exception
6432         with throw.
6433         * compile/compile-object-run.c (compile_object_run): Replace
6434         throw_exception with throw.
6435         * cli/cli-script.c (process_next_line): Replace throw_exception
6436         with throw.
6437         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6438         (btrace_enable, btrace_maint_update_pt_packets): Replace
6439         throw_exception with throw.
6440         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6441         throw_exception with throw.
6442         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6443         throw_exception with throw.
6444         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6445         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6446         * aarch64-tdep.c (aarch64_make_prologue_cache)
6447         (aarch64_make_stub_cache): Replace throw_exception with throw.
6448
6449 2019-04-08  Tom Tromey  <tom@tromey.com>
6450
6451         * common/common-exceptions.c (throw_exception): Rename from
6452         throw_exception_cxx.  Remove old copy.  Make argument const.
6453         (throw_it): Create and throw exception objects directly.
6454         * common/common-exceptions.h (throw_exception): Make argument
6455         const.
6456         (struct gdb_exception_error): Add constructor.
6457         (struct gdb_exception_quit): Add constructor.
6458
6459 2019-04-08  Tom Tromey  <tom@tromey.com>
6460
6461         * common/common-exceptions.h (exception_rethrow): Don't declare.
6462         (TRY_SJLJ): Update comment.
6463         (TRY, CATCH, END_CATCH): Remove.
6464         * common/common-exceptions.c (exception_rethrow): Remove.
6465
6466 2019-04-08  Tom Tromey  <tom@tromey.com>
6467
6468         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6469         Remove.
6470         (gdb_exception_error): Rename from
6471         gdb_exception_RETURN_MASK_ERROR.
6472         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6473         (gdb_quit_bad_alloc): Update.
6474         * aarch64-tdep.c: Update.
6475         * ada-lang.c: Update.
6476         * ada-typeprint.c: Update.
6477         * ada-valprint.c: Update.
6478         * amd64-tdep.c: Update.
6479         * arch-utils.c: Update.
6480         * break-catch-throw.c: Update.
6481         * breakpoint.c: Update.
6482         * btrace.c: Update.
6483         * c-varobj.c: Update.
6484         * cli/cli-cmds.c: Update.
6485         * cli/cli-interp.c: Update.
6486         * cli/cli-script.c: Update.
6487         * common/common-exceptions.c: Update.
6488         * common/new-op.c: Update.
6489         * common/selftest.c: Update.
6490         * compile/compile-c-symbols.c: Update.
6491         * compile/compile-cplus-symbols.c: Update.
6492         * compile/compile-object-load.c: Update.
6493         * compile/compile-object-run.c: Update.
6494         * completer.c: Update.
6495         * corelow.c: Update.
6496         * cp-abi.c: Update.
6497         * cp-support.c: Update.
6498         * cp-valprint.c: Update.
6499         * darwin-nat.c: Update.
6500         * disasm-selftests.c: Update.
6501         * dtrace-probe.c: Update.
6502         * dwarf-index-cache.c: Update.
6503         * dwarf-index-write.c: Update.
6504         * dwarf2-frame-tailcall.c: Update.
6505         * dwarf2-frame.c: Update.
6506         * dwarf2loc.c: Update.
6507         * dwarf2read.c: Update.
6508         * eval.c: Update.
6509         * event-loop.c: Update.
6510         * event-top.c: Update.
6511         * exec.c: Update.
6512         * f-valprint.c: Update.
6513         * fbsd-tdep.c: Update.
6514         * frame-unwind.c: Update.
6515         * frame.c: Update.
6516         * gdbtypes.c: Update.
6517         * gnu-v3-abi.c: Update.
6518         * guile/guile-internal.h: Update.
6519         * guile/scm-block.c: Update.
6520         * guile/scm-breakpoint.c: Update.
6521         * guile/scm-cmd.c: Update.
6522         * guile/scm-disasm.c: Update.
6523         * guile/scm-frame.c: Update.
6524         * guile/scm-lazy-string.c: Update.
6525         * guile/scm-math.c: Update.
6526         * guile/scm-param.c: Update.
6527         * guile/scm-ports.c: Update.
6528         * guile/scm-pretty-print.c: Update.
6529         * guile/scm-symbol.c: Update.
6530         * guile/scm-symtab.c: Update.
6531         * guile/scm-type.c: Update.
6532         * guile/scm-value.c: Update.
6533         * i386-linux-tdep.c: Update.
6534         * i386-tdep.c: Update.
6535         * inf-loop.c: Update.
6536         * infcall.c: Update.
6537         * infcmd.c: Update.
6538         * infrun.c: Update.
6539         * jit.c: Update.
6540         * language.c: Update.
6541         * linespec.c: Update.
6542         * linux-fork.c: Update.
6543         * linux-nat.c: Update.
6544         * linux-tdep.c: Update.
6545         * linux-thread-db.c: Update.
6546         * main.c: Update.
6547         * mi/mi-cmd-break.c: Update.
6548         * mi/mi-cmd-stack.c: Update.
6549         * mi/mi-interp.c: Update.
6550         * mi/mi-main.c: Update.
6551         * objc-lang.c: Update.
6552         * p-valprint.c: Update.
6553         * parse.c: Update.
6554         * ppc-linux-tdep.c: Update.
6555         * printcmd.c: Update.
6556         * python/py-arch.c: Update.
6557         * python/py-breakpoint.c: Update.
6558         * python/py-cmd.c: Update.
6559         * python/py-finishbreakpoint.c: Update.
6560         * python/py-frame.c: Update.
6561         * python/py-framefilter.c: Update.
6562         * python/py-gdb-readline.c: Update.
6563         * python/py-inferior.c: Update.
6564         * python/py-infthread.c: Update.
6565         * python/py-lazy-string.c: Update.
6566         * python/py-linetable.c: Update.
6567         * python/py-objfile.c: Update.
6568         * python/py-param.c: Update.
6569         * python/py-prettyprint.c: Update.
6570         * python/py-progspace.c: Update.
6571         * python/py-record-btrace.c: Update.
6572         * python/py-record.c: Update.
6573         * python/py-symbol.c: Update.
6574         * python/py-type.c: Update.
6575         * python/py-unwind.c: Update.
6576         * python/py-utils.c: Update.
6577         * python/py-value.c: Update.
6578         * python/python.c: Update.
6579         * record-btrace.c: Update.
6580         * record-full.c: Update.
6581         * remote-fileio.c: Update.
6582         * remote.c: Update.
6583         * riscv-tdep.c: Update.
6584         * rs6000-aix-tdep.c: Update.
6585         * rs6000-tdep.c: Update.
6586         * rust-exp.y: Update.
6587         * rust-lang.c: Update.
6588         * s390-tdep.c: Update.
6589         * selftest-arch.c: Update.
6590         * solib-dsbt.c: Update.
6591         * solib-frv.c: Update.
6592         * solib-spu.c: Update.
6593         * solib-svr4.c: Update.
6594         * solib.c: Update.
6595         * sparc64-linux-tdep.c: Update.
6596         * stack.c: Update.
6597         * symfile-mem.c: Update.
6598         * symmisc.c: Update.
6599         * target.c: Update.
6600         * thread.c: Update.
6601         * top.c: Update.
6602         * tracefile-tfile.c: Update.
6603         * tui/tui.c: Update.
6604         * typeprint.c: Update.
6605         * unittests/cli-utils-selftests.c: Update.
6606         * unittests/parse-connection-spec-selftests.c: Update.
6607         * valops.c: Update.
6608         * valprint.c: Update.
6609         * value.c: Update.
6610         * varobj.c: Update.
6611         * windows-nat.c: Update.
6612         * x86-linux-nat.c: Update.
6613         * xml-support.c: Update.
6614
6615 2019-04-08  Tom Tromey  <tom@tromey.com>
6616
6617         * xml-support.c: Use C++ exception handling.
6618         * x86-linux-nat.c: Use C++ exception handling.
6619         * windows-nat.c: Use C++ exception handling.
6620         * varobj.c: Use C++ exception handling.
6621         * value.c: Use C++ exception handling.
6622         * valprint.c: Use C++ exception handling.
6623         * valops.c: Use C++ exception handling.
6624         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6625         handling.
6626         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6627         * typeprint.c: Use C++ exception handling.
6628         * tui/tui.c: Use C++ exception handling.
6629         * tracefile-tfile.c: Use C++ exception handling.
6630         * top.c: Use C++ exception handling.
6631         * thread.c: Use C++ exception handling.
6632         * target.c: Use C++ exception handling.
6633         * symmisc.c: Use C++ exception handling.
6634         * symfile-mem.c: Use C++ exception handling.
6635         * stack.c: Use C++ exception handling.
6636         * sparc64-linux-tdep.c: Use C++ exception handling.
6637         * solib.c: Use C++ exception handling.
6638         * solib-svr4.c: Use C++ exception handling.
6639         * solib-spu.c: Use C++ exception handling.
6640         * solib-frv.c: Use C++ exception handling.
6641         * solib-dsbt.c: Use C++ exception handling.
6642         * selftest-arch.c: Use C++ exception handling.
6643         * s390-tdep.c: Use C++ exception handling.
6644         * rust-lang.c: Use C++ exception handling.
6645         * rust-exp.y: Use C++ exception handling.
6646         * rs6000-tdep.c: Use C++ exception handling.
6647         * rs6000-aix-tdep.c: Use C++ exception handling.
6648         * riscv-tdep.c: Use C++ exception handling.
6649         * remote.c: Use C++ exception handling.
6650         * remote-fileio.c: Use C++ exception handling.
6651         * record-full.c: Use C++ exception handling.
6652         * record-btrace.c: Use C++ exception handling.
6653         * python/python.c: Use C++ exception handling.
6654         * python/py-value.c: Use C++ exception handling.
6655         * python/py-utils.c: Use C++ exception handling.
6656         * python/py-unwind.c: Use C++ exception handling.
6657         * python/py-type.c: Use C++ exception handling.
6658         * python/py-symbol.c: Use C++ exception handling.
6659         * python/py-record.c: Use C++ exception handling.
6660         * python/py-record-btrace.c: Use C++ exception handling.
6661         * python/py-progspace.c: Use C++ exception handling.
6662         * python/py-prettyprint.c: Use C++ exception handling.
6663         * python/py-param.c: Use C++ exception handling.
6664         * python/py-objfile.c: Use C++ exception handling.
6665         * python/py-linetable.c: Use C++ exception handling.
6666         * python/py-lazy-string.c: Use C++ exception handling.
6667         * python/py-infthread.c: Use C++ exception handling.
6668         * python/py-inferior.c: Use C++ exception handling.
6669         * python/py-gdb-readline.c: Use C++ exception handling.
6670         * python/py-framefilter.c: Use C++ exception handling.
6671         * python/py-frame.c: Use C++ exception handling.
6672         * python/py-finishbreakpoint.c: Use C++ exception handling.
6673         * python/py-cmd.c: Use C++ exception handling.
6674         * python/py-breakpoint.c: Use C++ exception handling.
6675         * python/py-arch.c: Use C++ exception handling.
6676         * printcmd.c: Use C++ exception handling.
6677         * ppc-linux-tdep.c: Use C++ exception handling.
6678         * parse.c: Use C++ exception handling.
6679         * p-valprint.c: Use C++ exception handling.
6680         * objc-lang.c: Use C++ exception handling.
6681         * mi/mi-main.c: Use C++ exception handling.
6682         * mi/mi-interp.c: Use C++ exception handling.
6683         * mi/mi-cmd-stack.c: Use C++ exception handling.
6684         * mi/mi-cmd-break.c: Use C++ exception handling.
6685         * main.c: Use C++ exception handling.
6686         * linux-thread-db.c: Use C++ exception handling.
6687         * linux-tdep.c: Use C++ exception handling.
6688         * linux-nat.c: Use C++ exception handling.
6689         * linux-fork.c: Use C++ exception handling.
6690         * linespec.c: Use C++ exception handling.
6691         * language.c: Use C++ exception handling.
6692         * jit.c: Use C++ exception handling.
6693         * infrun.c: Use C++ exception handling.
6694         * infcmd.c: Use C++ exception handling.
6695         * infcall.c: Use C++ exception handling.
6696         * inf-loop.c: Use C++ exception handling.
6697         * i386-tdep.c: Use C++ exception handling.
6698         * i386-linux-tdep.c: Use C++ exception handling.
6699         * guile/scm-value.c: Use C++ exception handling.
6700         * guile/scm-type.c: Use C++ exception handling.
6701         * guile/scm-symtab.c: Use C++ exception handling.
6702         * guile/scm-symbol.c: Use C++ exception handling.
6703         * guile/scm-pretty-print.c: Use C++ exception handling.
6704         * guile/scm-ports.c: Use C++ exception handling.
6705         * guile/scm-param.c: Use C++ exception handling.
6706         * guile/scm-math.c: Use C++ exception handling.
6707         * guile/scm-lazy-string.c: Use C++ exception handling.
6708         * guile/scm-frame.c: Use C++ exception handling.
6709         * guile/scm-disasm.c: Use C++ exception handling.
6710         * guile/scm-cmd.c: Use C++ exception handling.
6711         * guile/scm-breakpoint.c: Use C++ exception handling.
6712         * guile/scm-block.c: Use C++ exception handling.
6713         * guile/guile-internal.h: Use C++ exception handling.
6714         * gnu-v3-abi.c: Use C++ exception handling.
6715         * gdbtypes.c: Use C++ exception handling.
6716         * frame.c: Use C++ exception handling.
6717         * frame-unwind.c: Use C++ exception handling.
6718         * fbsd-tdep.c: Use C++ exception handling.
6719         * f-valprint.c: Use C++ exception handling.
6720         * exec.c: Use C++ exception handling.
6721         * event-top.c: Use C++ exception handling.
6722         * event-loop.c: Use C++ exception handling.
6723         * eval.c: Use C++ exception handling.
6724         * dwarf2read.c: Use C++ exception handling.
6725         * dwarf2loc.c: Use C++ exception handling.
6726         * dwarf2-frame.c: Use C++ exception handling.
6727         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6728         * dwarf-index-write.c: Use C++ exception handling.
6729         * dwarf-index-cache.c: Use C++ exception handling.
6730         * dtrace-probe.c: Use C++ exception handling.
6731         * disasm-selftests.c: Use C++ exception handling.
6732         * darwin-nat.c: Use C++ exception handling.
6733         * cp-valprint.c: Use C++ exception handling.
6734         * cp-support.c: Use C++ exception handling.
6735         * cp-abi.c: Use C++ exception handling.
6736         * corelow.c: Use C++ exception handling.
6737         * completer.c: Use C++ exception handling.
6738         * compile/compile-object-run.c: Use C++ exception handling.
6739         * compile/compile-object-load.c: Use C++ exception handling.
6740         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6741         * compile/compile-c-symbols.c: Use C++ exception handling.
6742         * common/selftest.c: Use C++ exception handling.
6743         * common/new-op.c: Use C++ exception handling.
6744         * cli/cli-script.c: Use C++ exception handling.
6745         * cli/cli-interp.c: Use C++ exception handling.
6746         * cli/cli-cmds.c: Use C++ exception handling.
6747         * c-varobj.c: Use C++ exception handling.
6748         * btrace.c: Use C++ exception handling.
6749         * breakpoint.c: Use C++ exception handling.
6750         * break-catch-throw.c: Use C++ exception handling.
6751         * arch-utils.c: Use C++ exception handling.
6752         * amd64-tdep.c: Use C++ exception handling.
6753         * ada-valprint.c: Use C++ exception handling.
6754         * ada-typeprint.c: Use C++ exception handling.
6755         * ada-lang.c: Use C++ exception handling.
6756         * aarch64-tdep.c: Use C++ exception handling.
6757
6758 2019-04-08  Tom Tromey  <tom@tromey.com>
6759
6760         * xml-support.c (gdb_xml_parser::parse): Update.
6761         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6762         * value.c (show_convenience): Update.
6763         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6764         (test_parse_flags_qcs): Update.
6765         * thread.c (thr_try_catch_cmd): Update.
6766         * target.c (target_translate_tls_address): Update.
6767         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6768         (info_frame_command_core, frame_apply_command_count): Update.
6769         * rust-exp.y (rust_lex_exception_test): Update.
6770         * riscv-tdep.c (riscv_print_one_register_info): Update.
6771         * remote.c (remote_target::enable_btrace): Update.
6772         * record-btrace.c (record_btrace_enable_warn): Update.
6773         * python/py-utils.c (gdbpy_convert_exception): Update.
6774         * printcmd.c (do_one_display, print_variable_and_value): Update.
6775         * mi/mi-main.c (mi_print_exception): Update.
6776         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6777         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6778         * linux-nat.c (linux_nat_target::attach): Update.
6779         * linux-fork.c (class scoped_switch_fork_info): Update.
6780         * infrun.c (displaced_step_prepare): Update.
6781         * infcall.c (call_function_by_hand_dummy): Update.
6782         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6783         * gnu-v3-abi.c (print_one_vtable): Update.
6784         * frame.c (get_prev_frame_always): Update.
6785         * f-valprint.c (info_common_command_for_block): Update.
6786         * exec.c (try_open_exec_file): Update.
6787         * exceptions.c (print_exception, exception_print)
6788         (exception_fprintf, exception_print_same): Update.
6789         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6790         * dwarf-index-cache.c (index_cache::store)
6791         (index_cache::lookup_gdb_index): Update.
6792         * darwin-nat.c (maybe_cache_shell): Update.
6793         * cp-valprint.c (cp_print_value_fields): Update.
6794         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6795         (gcc_cplus_symbol_address): Update.
6796         * compile/compile-c-symbols.c (gcc_convert_symbol)
6797         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6798         * common/selftest.c: Update.
6799         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6800         a std::string.
6801         (exception_try_scope_entry, exception_try_scope_exit): Don't
6802         declare.
6803         (struct exception_try_scope): Remove.
6804         (TRY): Don't use exception_try_scope.
6805         (struct gdb_exception): Add constructor, operator=.
6806         <what>: New method.
6807         (struct gdb_exception_RETURN_MASK_ALL)
6808         (struct gdb_exception_RETURN_MASK_ERROR)
6809         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6810         (struct gdb_quit_bad_alloc): Update.
6811         * common/common-exceptions.c (exception_none): Change
6812         initializer.
6813         (struct catcher) <state, exception>: Initialize inline.
6814         <prev>: Remove member.
6815         (current_catcher): Remove.
6816         (catchers): New global.
6817         (exceptions_state_mc_init): Simplify.
6818         (catcher_pop): Remove.
6819         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6820         (try_scope_depth, exception_try_scope_entry)
6821         (exception_try_scope_exit): Remove.
6822         (throw_exception_sjlj): Update.
6823         (exception_messages, exception_messages_size): Remove.
6824         (throw_it): Simplify.
6825         (gdb_exception_sliced_copy): Remove.
6826         (throw_exception_cxx): Update.
6827         * cli/cli-script.c (script_from_file): Update.
6828         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6829         Update.
6830         * ada-valprint.c (ada_val_print): Update.
6831         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6832         (create_excep_cond_exprs): Update.
6833
6834 2019-04-08  Tom Tromey  <tom@tromey.com>
6835
6836         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6837         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6838         (TRY, CATCH, END_CATCH): Remove some definitions.
6839         * common/common-exceptions.c: Don't use GDB_XCPT.
6840         (catcher_list_size): Remove.
6841         (throw_exception, throw_it): Simplify.
6842
6843 2019-04-05  Tom Tromey  <tom@tromey.com>
6844
6845         Revert the header-sorting patch.
6846         * ft32-tdep.c: Revert.
6847         * frv-tdep.c: Revert.
6848         * frv-linux-tdep.c: Revert.
6849         * frame.c: Revert.
6850         * frame-unwind.c: Revert.
6851         * frame-base.c: Revert.
6852         * fork-child.c: Revert.
6853         * findvar.c: Revert.
6854         * findcmd.c: Revert.
6855         * filesystem.c: Revert.
6856         * filename-seen-cache.h: Revert.
6857         * filename-seen-cache.c: Revert.
6858         * fbsd-tdep.c: Revert.
6859         * fbsd-nat.h: Revert.
6860         * fbsd-nat.c: Revert.
6861         * f-valprint.c: Revert.
6862         * f-typeprint.c: Revert.
6863         * f-lang.c: Revert.
6864         * extension.h: Revert.
6865         * extension.c: Revert.
6866         * extension-priv.h: Revert.
6867         * expprint.c: Revert.
6868         * exec.h: Revert.
6869         * exec.c: Revert.
6870         * exceptions.c: Revert.
6871         * event-top.c: Revert.
6872         * event-loop.c: Revert.
6873         * eval.c: Revert.
6874         * elfread.c: Revert.
6875         * dwarf2read.h: Revert.
6876         * dwarf2read.c: Revert.
6877         * dwarf2loc.c: Revert.
6878         * dwarf2expr.h: Revert.
6879         * dwarf2expr.c: Revert.
6880         * dwarf2-frame.c: Revert.
6881         * dwarf2-frame-tailcall.c: Revert.
6882         * dwarf-index-write.h: Revert.
6883         * dwarf-index-write.c: Revert.
6884         * dwarf-index-common.c: Revert.
6885         * dwarf-index-cache.h: Revert.
6886         * dwarf-index-cache.c: Revert.
6887         * dummy-frame.c: Revert.
6888         * dtrace-probe.c: Revert.
6889         * disasm.h: Revert.
6890         * disasm.c: Revert.
6891         * disasm-selftests.c: Revert.
6892         * dictionary.c: Revert.
6893         * dicos-tdep.c: Revert.
6894         * demangle.c: Revert.
6895         * dcache.h: Revert.
6896         * dcache.c: Revert.
6897         * darwin-nat.h: Revert.
6898         * darwin-nat.c: Revert.
6899         * darwin-nat-info.c: Revert.
6900         * d-valprint.c: Revert.
6901         * d-namespace.c: Revert.
6902         * d-lang.c: Revert.
6903         * ctf.c: Revert.
6904         * csky-tdep.c: Revert.
6905         * csky-linux-tdep.c: Revert.
6906         * cris-tdep.c: Revert.
6907         * cris-linux-tdep.c: Revert.
6908         * cp-valprint.c: Revert.
6909         * cp-support.c: Revert.
6910         * cp-namespace.c: Revert.
6911         * cp-abi.c: Revert.
6912         * corelow.c: Revert.
6913         * corefile.c: Revert.
6914         * continuations.c: Revert.
6915         * completer.h: Revert.
6916         * completer.c: Revert.
6917         * complaints.c: Revert.
6918         * coffread.c: Revert.
6919         * coff-pe-read.c: Revert.
6920         * cli-out.h: Revert.
6921         * cli-out.c: Revert.
6922         * charset.c: Revert.
6923         * c-varobj.c: Revert.
6924         * c-valprint.c: Revert.
6925         * c-typeprint.c: Revert.
6926         * c-lang.c: Revert.
6927         * buildsym.c: Revert.
6928         * buildsym-legacy.c: Revert.
6929         * build-id.h: Revert.
6930         * build-id.c: Revert.
6931         * btrace.c: Revert.
6932         * bsd-uthread.c: Revert.
6933         * breakpoint.h: Revert.
6934         * breakpoint.c: Revert.
6935         * break-catch-throw.c: Revert.
6936         * break-catch-syscall.c: Revert.
6937         * break-catch-sig.c: Revert.
6938         * blockframe.c: Revert.
6939         * block.c: Revert.
6940         * bfin-tdep.c: Revert.
6941         * bfin-linux-tdep.c: Revert.
6942         * bfd-target.c: Revert.
6943         * bcache.c: Revert.
6944         * ax-general.c: Revert.
6945         * ax-gdb.h: Revert.
6946         * ax-gdb.c: Revert.
6947         * avr-tdep.c: Revert.
6948         * auxv.c: Revert.
6949         * auto-load.c: Revert.
6950         * arm-wince-tdep.c: Revert.
6951         * arm-tdep.c: Revert.
6952         * arm-symbian-tdep.c: Revert.
6953         * arm-pikeos-tdep.c: Revert.
6954         * arm-obsd-tdep.c: Revert.
6955         * arm-nbsd-tdep.c: Revert.
6956         * arm-nbsd-nat.c: Revert.
6957         * arm-linux-tdep.c: Revert.
6958         * arm-linux-nat.c: Revert.
6959         * arm-fbsd-tdep.c: Revert.
6960         * arm-fbsd-nat.c: Revert.
6961         * arm-bsd-tdep.c: Revert.
6962         * arch-utils.c: Revert.
6963         * arc-tdep.c: Revert.
6964         * arc-newlib-tdep.c: Revert.
6965         * annotate.h: Revert.
6966         * annotate.c: Revert.
6967         * amd64-windows-tdep.c: Revert.
6968         * amd64-windows-nat.c: Revert.
6969         * amd64-tdep.c: Revert.
6970         * amd64-sol2-tdep.c: Revert.
6971         * amd64-obsd-tdep.c: Revert.
6972         * amd64-obsd-nat.c: Revert.
6973         * amd64-nbsd-tdep.c: Revert.
6974         * amd64-nbsd-nat.c: Revert.
6975         * amd64-nat.c: Revert.
6976         * amd64-linux-tdep.c: Revert.
6977         * amd64-linux-nat.c: Revert.
6978         * amd64-fbsd-tdep.c: Revert.
6979         * amd64-fbsd-nat.c: Revert.
6980         * amd64-dicos-tdep.c: Revert.
6981         * amd64-darwin-tdep.c: Revert.
6982         * amd64-bsd-nat.c: Revert.
6983         * alpha-tdep.c: Revert.
6984         * alpha-obsd-tdep.c: Revert.
6985         * alpha-nbsd-tdep.c: Revert.
6986         * alpha-mdebug-tdep.c: Revert.
6987         * alpha-linux-tdep.c: Revert.
6988         * alpha-linux-nat.c: Revert.
6989         * alpha-bsd-tdep.c: Revert.
6990         * alpha-bsd-nat.c: Revert.
6991         * aix-thread.c: Revert.
6992         * agent.c: Revert.
6993         * addrmap.c: Revert.
6994         * ada-varobj.c: Revert.
6995         * ada-valprint.c: Revert.
6996         * ada-typeprint.c: Revert.
6997         * ada-tasks.c: Revert.
6998         * ada-lang.c: Revert.
6999         * aarch64-tdep.c: Revert.
7000         * aarch64-ravenscar-thread.c: Revert.
7001         * aarch64-newlib-tdep.c: Revert.
7002         * aarch64-linux-tdep.c: Revert.
7003         * aarch64-linux-nat.c: Revert.
7004         * aarch64-fbsd-tdep.c: Revert.
7005         * aarch64-fbsd-nat.c: Revert.
7006         * aarch32-linux-nat.c: Revert.
7007
7008 2019-04-05  Tom Tromey  <tom@tromey.com>
7009
7010         * ft32-tdep.c: Sort headers.
7011         * frv-tdep.c: Sort headers.
7012         * frv-linux-tdep.c: Sort headers.
7013         * frame.c: Sort headers.
7014         * frame-unwind.c: Sort headers.
7015         * frame-base.c: Sort headers.
7016         * fork-child.c: Sort headers.
7017         * findvar.c: Sort headers.
7018         * findcmd.c: Sort headers.
7019         * filesystem.c: Sort headers.
7020         * filename-seen-cache.h: Sort headers.
7021         * filename-seen-cache.c: Sort headers.
7022         * fbsd-tdep.c: Sort headers.
7023         * fbsd-nat.h: Sort headers.
7024         * fbsd-nat.c: Sort headers.
7025         * f-valprint.c: Sort headers.
7026         * f-typeprint.c: Sort headers.
7027         * f-lang.c: Sort headers.
7028         * extension.h: Sort headers.
7029         * extension.c: Sort headers.
7030         * extension-priv.h: Sort headers.
7031         * expprint.c: Sort headers.
7032         * exec.h: Sort headers.
7033         * exec.c: Sort headers.
7034         * exceptions.c: Sort headers.
7035         * event-top.c: Sort headers.
7036         * event-loop.c: Sort headers.
7037         * eval.c: Sort headers.
7038         * elfread.c: Sort headers.
7039         * dwarf2read.h: Sort headers.
7040         * dwarf2read.c: Sort headers.
7041         * dwarf2loc.c: Sort headers.
7042         * dwarf2expr.h: Sort headers.
7043         * dwarf2expr.c: Sort headers.
7044         * dwarf2-frame.c: Sort headers.
7045         * dwarf2-frame-tailcall.c: Sort headers.
7046         * dwarf-index-write.h: Sort headers.
7047         * dwarf-index-write.c: Sort headers.
7048         * dwarf-index-common.c: Sort headers.
7049         * dwarf-index-cache.h: Sort headers.
7050         * dwarf-index-cache.c: Sort headers.
7051         * dummy-frame.c: Sort headers.
7052         * dtrace-probe.c: Sort headers.
7053         * disasm.h: Sort headers.
7054         * disasm.c: Sort headers.
7055         * disasm-selftests.c: Sort headers.
7056         * dictionary.c: Sort headers.
7057         * dicos-tdep.c: Sort headers.
7058         * demangle.c: Sort headers.
7059         * dcache.h: Sort headers.
7060         * dcache.c: Sort headers.
7061         * darwin-nat.h: Sort headers.
7062         * darwin-nat.c: Sort headers.
7063         * darwin-nat-info.c: Sort headers.
7064         * d-valprint.c: Sort headers.
7065         * d-namespace.c: Sort headers.
7066         * d-lang.c: Sort headers.
7067         * ctf.c: Sort headers.
7068         * csky-tdep.c: Sort headers.
7069         * csky-linux-tdep.c: Sort headers.
7070         * cris-tdep.c: Sort headers.
7071         * cris-linux-tdep.c: Sort headers.
7072         * cp-valprint.c: Sort headers.
7073         * cp-support.c: Sort headers.
7074         * cp-namespace.c: Sort headers.
7075         * cp-abi.c: Sort headers.
7076         * corelow.c: Sort headers.
7077         * corefile.c: Sort headers.
7078         * continuations.c: Sort headers.
7079         * completer.h: Sort headers.
7080         * completer.c: Sort headers.
7081         * complaints.c: Sort headers.
7082         * coffread.c: Sort headers.
7083         * coff-pe-read.c: Sort headers.
7084         * cli-out.h: Sort headers.
7085         * cli-out.c: Sort headers.
7086         * charset.c: Sort headers.
7087         * c-varobj.c: Sort headers.
7088         * c-valprint.c: Sort headers.
7089         * c-typeprint.c: Sort headers.
7090         * c-lang.c: Sort headers.
7091         * buildsym.c: Sort headers.
7092         * buildsym-legacy.c: Sort headers.
7093         * build-id.h: Sort headers.
7094         * build-id.c: Sort headers.
7095         * btrace.c: Sort headers.
7096         * bsd-uthread.c: Sort headers.
7097         * breakpoint.h: Sort headers.
7098         * breakpoint.c: Sort headers.
7099         * break-catch-throw.c: Sort headers.
7100         * break-catch-syscall.c: Sort headers.
7101         * break-catch-sig.c: Sort headers.
7102         * blockframe.c: Sort headers.
7103         * block.c: Sort headers.
7104         * bfin-tdep.c: Sort headers.
7105         * bfin-linux-tdep.c: Sort headers.
7106         * bfd-target.c: Sort headers.
7107         * bcache.c: Sort headers.
7108         * ax-general.c: Sort headers.
7109         * ax-gdb.h: Sort headers.
7110         * ax-gdb.c: Sort headers.
7111         * avr-tdep.c: Sort headers.
7112         * auxv.c: Sort headers.
7113         * auto-load.c: Sort headers.
7114         * arm-wince-tdep.c: Sort headers.
7115         * arm-tdep.c: Sort headers.
7116         * arm-symbian-tdep.c: Sort headers.
7117         * arm-pikeos-tdep.c: Sort headers.
7118         * arm-obsd-tdep.c: Sort headers.
7119         * arm-nbsd-tdep.c: Sort headers.
7120         * arm-nbsd-nat.c: Sort headers.
7121         * arm-linux-tdep.c: Sort headers.
7122         * arm-linux-nat.c: Sort headers.
7123         * arm-fbsd-tdep.c: Sort headers.
7124         * arm-fbsd-nat.c: Sort headers.
7125         * arm-bsd-tdep.c: Sort headers.
7126         * arch-utils.c: Sort headers.
7127         * arc-tdep.c: Sort headers.
7128         * arc-newlib-tdep.c: Sort headers.
7129         * annotate.h: Sort headers.
7130         * annotate.c: Sort headers.
7131         * amd64-windows-tdep.c: Sort headers.
7132         * amd64-windows-nat.c: Sort headers.
7133         * amd64-tdep.c: Sort headers.
7134         * amd64-sol2-tdep.c: Sort headers.
7135         * amd64-obsd-tdep.c: Sort headers.
7136         * amd64-obsd-nat.c: Sort headers.
7137         * amd64-nbsd-tdep.c: Sort headers.
7138         * amd64-nbsd-nat.c: Sort headers.
7139         * amd64-nat.c: Sort headers.
7140         * amd64-linux-tdep.c: Sort headers.
7141         * amd64-linux-nat.c: Sort headers.
7142         * amd64-fbsd-tdep.c: Sort headers.
7143         * amd64-fbsd-nat.c: Sort headers.
7144         * amd64-dicos-tdep.c: Sort headers.
7145         * amd64-darwin-tdep.c: Sort headers.
7146         * amd64-bsd-nat.c: Sort headers.
7147         * alpha-tdep.c: Sort headers.
7148         * alpha-obsd-tdep.c: Sort headers.
7149         * alpha-nbsd-tdep.c: Sort headers.
7150         * alpha-mdebug-tdep.c: Sort headers.
7151         * alpha-linux-tdep.c: Sort headers.
7152         * alpha-linux-nat.c: Sort headers.
7153         * alpha-bsd-tdep.c: Sort headers.
7154         * alpha-bsd-nat.c: Sort headers.
7155         * aix-thread.c: Sort headers.
7156         * agent.c: Sort headers.
7157         * addrmap.c: Sort headers.
7158         * ada-varobj.c: Sort headers.
7159         * ada-valprint.c: Sort headers.
7160         * ada-typeprint.c: Sort headers.
7161         * ada-tasks.c: Sort headers.
7162         * ada-lang.c: Sort headers.
7163         * aarch64-tdep.c: Sort headers.
7164         * aarch64-ravenscar-thread.c: Sort headers.
7165         * aarch64-newlib-tdep.c: Sort headers.
7166         * aarch64-linux-tdep.c: Sort headers.
7167         * aarch64-linux-nat.c: Sort headers.
7168         * aarch64-fbsd-tdep.c: Sort headers.
7169         * aarch64-fbsd-nat.c: Sort headers.
7170         * aarch32-linux-nat.c: Sort headers.
7171
7172 2019-04-04  Tom Tromey  <tom@tromey.com>
7173
7174         * varobj.c (varobj_create): Update.
7175         * rust-exp.y (struct rust_parser) <update_innermost_block,
7176         lookup_symbol>: New methods.
7177         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7178         Rename.
7179         (rust_parser::rust_lookup_type)
7180         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7181         * printcmd.c (display_command, do_one_display): Update.
7182         * parser-defs.h (struct parser_state) <parser_state>: Add
7183         "tracker" parameter.
7184         (block_tracker): New member.
7185         (class innermost_block_tracker) <innermost_block_tracker>: Add
7186         "types" parameter.
7187         <reset>: Remove method.
7188         (innermost_block): Don't declare.
7189         (null_post_parser): Update.
7190         * parse.c (innermost_block): Remove global.
7191         (write_dollar_variable): Update.
7192         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7193         Remove "tracker_types" parameter.
7194         (parse_expression): Add "tracker" parameter.
7195         (parse_expression_for_completion): Update.
7196         (null_post_parser): Add "tracker" parameter.
7197         * p-exp.y: Update rules.
7198         * m2-exp.y: Update rules.
7199         * language.h (struct language_defn) <la_post_parser>: Add
7200         "tracker" parameter.
7201         * go-exp.y: Update rules.
7202         * f-exp.y: Update rules.
7203         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7204         parameter.
7205         * d-exp.y: Update rules.
7206         * c-exp.y: Update rules.
7207         * breakpoint.c (set_breakpoint_condition): Create an
7208         innermost_block_tracker.
7209         (watch_command_1): Likewise.
7210         * ada-lang.c (resolve): Add "tracker" parameter.
7211         (resolve_subexp): Likewise.
7212         * ada-exp.y (write_var_from_sym): Update.
7213
7214 2019-04-04  Tom Tromey  <tom@tromey.com>
7215
7216         * type-stack.h: New file.
7217         * type-stack.c: New file.
7218         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7219         type-stack.h.
7220         (insert_into_type_stack, insert_type, push_type, push_type_int)
7221         (insert_type_address_space, pop_type, pop_type_int)
7222         (pop_typelist, pop_type_stack, append_type_stack)
7223         (push_type_stack, get_type_stack, push_typelist)
7224         (follow_type_instance_flags, follow_types): Don't declare.
7225         * parse.c (type_stack): Remove global.
7226         (parse_exp_in_context): Update.
7227         (insert_into_type_stack, insert_type, push_type, push_type_int)
7228         (insert_type_address_space, pop_type, pop_type_int)
7229         (pop_typelist, pop_type_stack, append_type_stack)
7230         (push_type_stack, get_type_stack, push_typelist)
7231         (follow_type_instance_flags, follow_types): Remove (moved to
7232         type-stack.c).
7233         * f-exp.y (type_stack): New global.
7234         Update rules.
7235         (push_kind_type, f_parse): Update.
7236         * d-exp.y (type_stack): New global.
7237         Update rules.
7238         (d_parse): Update.
7239         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7240         Update rules.
7241         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7242         (HFILES_NO_SRCDIR): Add type-stack.h.
7243
7244 2019-04-04  Tom Tromey  <tom@tromey.com>
7245
7246         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7247         (rust_parser::convert_ast_to_expression, rust_parse)
7248         (rust_lex_test_completion, rust_lex_tests): Update.
7249         * parser-defs.h (struct expr_completion_state): New.
7250         (struct parser_state) <parser_state>: Add completion parameter.
7251         <mark_struct_expression, mark_completion_tag>: New methods.
7252         <parse_completion, m_completion_state>: New members.
7253         (prefixify_expression, null_post_parser): Update.
7254         (mark_struct_expression, mark_completion_tag): Don't declare.
7255         * parse.c (parse_completion, expout_last_struct)
7256         (expout_tag_completion_type, expout_completion_name): Remove
7257         globals.
7258         (parser_state::mark_struct_expression)
7259         (parser_state::mark_completion_tag): Now methods.
7260         (prefixify_expression): Add last_struct parameter.
7261         (prefixify_subexp): Likewise.
7262         (parse_exp_1): Update.
7263         (parse_exp_in_context): Add cstate parameter.  Update.
7264         (parse_expression_for_completion): Create an
7265         expr_completion_state.
7266         (null_post_parser): Add "completion" parameter.
7267         * p-exp.y: Update rules.
7268         (yylex): Update.
7269         * language.h (struct language_defn) <la_post_parser>: Add
7270         "completing" parameter.
7271         * go-exp.y: Update rules.
7272         (lex_one_token): Update.
7273         * expression.h (parse_completion): Don't declare.
7274         * d-exp.y: Update rules.
7275         (lex_one_token): Update rules.
7276         * c-exp.y: Update rules.
7277         (lex_one_token): Update.
7278         * ada-lang.c (resolve): Add "parse_completion" parameter.
7279         (resolve_subexp): Likewise.
7280         (ada_resolve_function): Likewise.
7281
7282 2019-04-04  Tom Tromey  <tom@tromey.com>
7283
7284         * parser-defs.h (struct parser_state) <start_arglist,
7285         end_arglist>: New methods.
7286         <arglist_len, m_funcall_chain>: New members.
7287         (arglist_len, start_arglist, end_arglist): Don't declare.
7288         * parse.c (arglist_len, funcall_chain): Remove global.
7289         (start_arglist, end_arglist): Remove functions.
7290         (parse_exp_in_context): Update.
7291         * p-exp.y: Update rules.
7292         * m2-exp.y: Update rules.
7293         * go-exp.y: Update rules.
7294         * f-exp.y: Update rules.
7295         * d-exp.y: Update rules.
7296         * c-exp.y: Update rules.
7297
7298 2019-04-04  Tom Tromey  <tom@tromey.com>
7299
7300         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7301         lex_operator, push_back>: New methods.
7302         Update all rules.
7303         (rust_parser::lex_hex, lex_escape): Rename and update.
7304         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7305         (rust_parser::lex_operator): Rename and update.
7306         (rust_parser::lex_number, rustyylex, rustyyerror)
7307         (rust_lex_test_init, rust_lex_test_sequence)
7308         (rust_lex_test_push_back, rust_lex_tests): Update.
7309         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7310         parameter.
7311         <lexptr, prev_lexptr>: New members.
7312         (lexptr, prev_lexptr): Don't declare.
7313         * parse.c (lexptr, prev_lexptr): Remove globals.
7314         (parse_exp_in_context): Update.
7315         * p-exp.y (yylex, yyerror): Update.
7316         * m2-exp.y (parse_number, yylex, yyerror): Update.
7317         * go-exp.y (lex_one_token, yyerror): Update.
7318         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7319         * d-exp.y (lex_one_token, yyerror): Update.
7320         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7321         (lex_one_token, yyerror): Update.
7322         * ada-lex.l (YY_INPUT): Update.
7323         (rewind_to_char): Update.
7324         * ada-exp.y (yyerror): Update.
7325
7326 2019-04-04  Tom Tromey  <tom@tromey.com>
7327
7328         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7329         * parser-defs.h (struct parser_state) <parser_state>: Add new
7330         parameter.
7331         <comma_terminates>: New member.
7332         (comma_terminates): Don't declare global.
7333         * parse.c (comma_terminates): Remove global.
7334         (parse_exp_in_context): Update.
7335         * p-exp.y (yylex): Update.
7336         * m2-exp.y (yylex): Update.
7337         * go-exp.y (lex_one_token): Update.
7338         * f-exp.y (yylex): Update.
7339         * d-exp.y (lex_one_token): Update.
7340         * c-exp.y (lex_one_token): Update.
7341         * ada-lex.l: Update.
7342
7343 2019-04-04  Tom Tromey  <tom@tromey.com>
7344
7345         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7346         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7347         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7348         * parser-defs.h (paren_depth): Don't declare.
7349         * parse.c (paren_depth): Remove global.
7350         (parse_exp_in_context): Update.
7351         * p-exp.y (paren_depth): New global.
7352         (pascal_parse): Initialize it.
7353         * m2-exp.y (paren_depth): New global.
7354         (m2_parse): Initialize it.
7355         * go-exp.y (paren_depth): New global.
7356         (go_parse): Initialize it.
7357         * f-exp.y (paren_depth): New global.
7358         (f_parse): Initialize it.
7359         * d-exp.y (paren_depth): New global.
7360         (d_parse): Initialize it.
7361         * c-exp.y (paren_depth): New global.
7362         (c_parse): Initialize it.
7363         * ada-lex.l (paren_depth): New global.
7364         (lexer_init): Initialize it.
7365
7366 2019-04-04  Tom Tromey  <tom@tromey.com>
7367
7368         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7369         (rust_parser::convert_ast_to_type)
7370         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7371         * parser-defs.h (struct parser_state) <parser_state>: Add
7372         parameters.  Initialize new members.
7373         <expression_context_block, expression_context_pc>: New members.
7374         * parse.c (expression_context_block, expression_context_pc):
7375         Remove globals.
7376         (parse_exp_in_context): Update.
7377         * p-exp.y: Update all rules.
7378         (yylex): Update.
7379         * m2-exp.y: Update all rules.
7380         (yylex): Update.
7381         * go-exp.y (yylex): Update.
7382         * f-exp.y (yylex): Update.
7383         * d-exp.y: Update all rules.
7384         (yylex): Update.
7385         * c-exp.y: Update all rules.
7386         (lex_one_token, classify_name, yylex, c_parse): Update.
7387         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7388
7389 2019-04-04  Tom Tromey  <tom@tromey.com>
7390
7391         * gdbarch.h, gdbarch.c: Rebuild.
7392         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7393         * stap-probe.h:
7394         (struct stap_parse_info): Replace "parser_state" with
7395         "expr_builder".
7396         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7397         (parser_state): New class.
7398         * parse.c (expr_builder): Rename.
7399         (expr_builder::release): Rename.
7400         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7401         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7402         (write_exp_elt_longcst, write_exp_elt_floatcst)
7403         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7404         (write_exp_string_vector, write_exp_bitstring)
7405         (write_exp_msymbol, mark_struct_expression)
7406         (write_dollar_variable)
7407         (insert_type_address_space, increase_expout_size): Replace
7408         "parser_state" with "expr_builder".
7409         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7410         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7411         "parser_state" with "expr_builder".
7412
7413 2019-04-04  Tom Tromey  <tom@tromey.com>
7414
7415         * rust-exp.y: Replace "parse_language" with method call.
7416         * p-exp.y:
7417         (yylex): Replace "parse_language" with method call.
7418         * m2-exp.y:
7419         (yylex): Replace "parse_language" with method call.
7420         * go-exp.y (classify_name): Replace "parse_language" with method
7421         call.
7422         * f-exp.y (yylex): Replace "parse_language" with method call.
7423         * d-exp.y (lex_one_token): Replace "parse_language" with method
7424         call.
7425         * c-exp.y:
7426         (lex_one_token, classify_name, yylex): Replace "parse_language"
7427         with method call.
7428         * ada-exp.y (find_primitive_type, type_char)
7429         (type_system_address): Replace "parse_language" with method call.
7430
7431 2019-04-04  Tom Tromey  <tom@tromey.com>
7432
7433         * rust-exp.y: Replace "parse_gdbarch" with method call.
7434         * parse.c (write_dollar_variable, insert_type_address_space):
7435         Replace "parse_gdbarch" with method call.
7436         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7437         call.
7438         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7439         call.
7440         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7441         "parse_gdbarch" with method call.
7442         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7443         with method call.
7444         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7445         "parse_gdbarch" with method call.
7446         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7447         "parse_gdbarch" with method call.
7448         * c-exp.y (parse_type, parse_number, classify_name): Replace
7449         "parse_gdbarch" with method call.
7450         * ada-lex.l: Replace "parse_gdbarch" with method call.
7451         * ada-exp.y (parse_type, find_primitive_type, type_char)
7452         (type_system_address): Replace "parse_gdbarch" with method call.
7453
7454 2019-04-04  Tom Tromey  <tom@tromey.com>
7455
7456         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7457         * stap-probe.c (stap_parse_argument): Update.
7458         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7459         initial_size parameter.
7460         * rust-exp.y (rust_lex_tests): Update.
7461         * parse.c (parser_state): Update.
7462         (parse_exp_in_context): Update.
7463         * parser-defs.h (struct parser_state) <parser_state>: Remove
7464         "initial_size" parameter.
7465
7466 2019-04-04  Tom Tromey  <tom@tromey.com>
7467
7468         * parser-defs.h (increase_expout_size): Don't declare.
7469         * parse.c (increase_expout_size): Now static.
7470
7471 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7472
7473         * gnu-nat.c (gnu_nat_target::wait): Fix
7474         target_waitstatus_to_string call.
7475
7476 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7477
7478         * eval.c (evaluate_subexp_standard): Handle internal functions
7479         during Fortran function call handling.
7480
7481 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7482
7483         * NEWS: Mention new internal functions.
7484         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7485         (read_base_type): Use dwarf2_init_complex_target_type.
7486         * value.c (creal_internal_fn): New function.
7487         (cimag_internal_fn): New function.
7488         (_initialize_values): Register new internal functions.
7489
7490 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7491
7492         * infrun.c (stop_all_threads): If debug_infrun, always
7493         trace the wait status after wait_one, using
7494         target_waitstatus_to_string and target_pid_to_str.
7495         (handle_inferior_event): Replace various trace of
7496         wait status kind by a single trace.
7497         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7498         wait status kind image by target_waitstatus_to_string.
7499         * target/waitstatus.c (target_waitstatus_to_string): Fix
7500         obsolete comment.
7501
7502 2019-04-01  Tom Tromey  <tromey@adacore.com>
7503
7504         PR symtab/23331:
7505         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7506
7507 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7508             Pedro Alves  <palves@redhat.com>
7509
7510         * top.c (quit_force): Call 'finalize_values'.
7511         * value.c (finalize_values): New function.
7512         * value.h (finalize_values): Declare.
7513
7514 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7515
7516         * NEWS: Announce $_gdb_major and $_gdb_minor.
7517
7518         * top.c (init_gdb_version_vars): New function.
7519         (gdb_init): Call init_gdb_version_vars.
7520
7521 2019-03-29  Tom Tromey  <tromey@adacore.com>
7522
7523         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7524         help text.  Remove dead code.
7525
7526 2019-03-29  Keith Seitz  <keiths@redhat.com>
7527
7528         From Siddhesh Poyarekar:
7529         * f-lang.h (f77_get_upperbound): Return LONGEST.
7530         (f77_get_lowerbound): Likewise.
7531         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7532         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7533         print them.
7534         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7535         plongest to format print it.
7536         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7537         (f77_get_upperbound): Likewise.
7538         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7539         LOWER_BOUND to LONGEST.
7540         (f77_create_arrayprint_offset_tbl): Likewise.
7541
7542 2019-03-29  Keith Seitz  <keiths@redhat.com>
7543
7544         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7545         %s/pulongest for TYPE_LENGTH instead of %d in format
7546         strings.
7547         * ada-typerint.c (ada_print_type): Likewise.
7548         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7549         * compile/compile-c-support.c (generate_register_struct): Likewise.
7550         * gdbtypes.c (recursive_dump_type): Likewise.
7551         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7552         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7553         instead of %d in format strings.
7554         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7555         to std::min to ULONGEST.
7556         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7557         instead of %d in format strings.
7558         * tracepoint.c (info_scope_command): Likewise.
7559         * typeprint.c (print_offset_data::update)
7560         (print_offset_data::finish): Likewise.
7561         * xtensa-tdep.c (xtensa_store_return_value)
7562         (xtensa_push_dummy_call): Likewise.
7563
7564 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7565
7566         * windows-nat.c (display_selector): Fixed format specifications
7567         for 64-bit Cygwin.
7568
7569 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7570
7571         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7572
7573 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7574
7575         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7576         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7577         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7578         (nios2_linux_init_abi): Install it.
7579
7580 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7581
7582         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7583
7584 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7585
7586         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7587
7588 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7589             Tom Tromey  <tromey@adacore.com>
7590
7591         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7592
7593 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7594
7595         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7596         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7597         method to compute the bounds of range types. Also print "[evaluated]"
7598         if the bounds' values come from a dynamic evaluation.
7599
7600 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7601
7602         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7603         whitespace when pretty printing is on.
7604
7605 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7606
7607         * ppc-linux-nat.c: Add include.
7608
7609 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7610
7611         * NEWS: Mention AArch64 Pointer Authentication.
7612
7613 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7614
7615         * arm-linux-nat.c: Add include.
7616
7617 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7618
7619         * source-cache.c (source_cache::get_source_lines): Re-read
7620         fullname after calling open_source_file.
7621
7622 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7623
7624         * NEWS: Mention TLS support for FreeBSD.
7625
7626 2019-03-25  Tom Tromey  <tromey@adacore.com>
7627
7628         * minsyms.c (BUNCH_SIZE): Update comment.
7629         (~minimal_symbol_reader): Remove old comment.
7630         (compact_minimal_symbols): Update comment.
7631         (minimal_symbol_reader::install): Remove old comment.  Update
7632         other comments.
7633
7634 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7635
7636         * s390-linux-nat.c: Add include.
7637
7638 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7639
7640         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7641         Call linux_get_hwcap.
7642         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7643         Likewise.
7644         (aarch64_linux_get_hwcap): Remove function.
7645         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7646         declaration.
7647         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7648         linux_get_hwcap.
7649         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7650         * linux-tdep.c (linux_get_hwcap): Add function.
7651         (linux_get_hwcap2): Likewise.
7652         * linux-tdep.h (linux_get_hwcap): Add declaration.
7653         (linux_get_hwcap2): Likewise.
7654         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7655         (ppc_linux_get_hwcap2): Likewise.
7656         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7657         linux_get_hwcap.
7658         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7659         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7660         (ppc_linux_nat_target::read_description): Likewise.
7661         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7662         * s390-linux-nat.c: Likewise.
7663         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7664
7665 2019-03-24  Tom Tromey  <tom@tromey.com>
7666
7667         * ada-lang.c (standard_lookup): Simplify initialization.
7668         (ada_lookup_symbol_nonlocal): Simplify return.
7669         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7670         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7671         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7672         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7673         initialization.
7674         * solib.c (solib_global_lookup): Simplify.
7675         * symtab.c (null_block_symbol): Remove.
7676         (symbol_cache_lookup): Simplify returns.
7677         (lookup_language_this): Simplify returns.
7678         (lookup_symbol_aux): Simplify return.
7679         (lookup_local_symbol): Simplify returns.
7680         (lookup_global_symbol_from_objfile): Simplify return.
7681         (lookup_symbol_in_objfile_symtabs)
7682         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7683         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7684         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7685         * cp-namespace.c (cp_lookup_bare_symbol)
7686         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7687         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7688         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7689         (cp_lookup_symbol_via_imports): Simplify initialization.
7690         (find_symbol_in_baseclass): Likewise.
7691         * symtab.h (null_block_symbol): Remove.
7692         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7693         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7694         (d_lookup_symbol_module): Likewise.
7695         (find_symbol_in_baseclass): Simplify initialization.
7696
7697 2019-03-24  Tom Tromey  <tom@tromey.com>
7698
7699         * expression.h: Don't include symtab.h.
7700         (struct block): Forward declare.
7701
7702 2019-03-24  Tom Tromey  <tom@tromey.com>
7703
7704         * c-exp.y (typebase): Remove casts.
7705         * gdbtypes.c (lookup_unsigned_typename, )
7706         (lookup_signed_typename): Remove cast.
7707         * eval.c (parse_to_comma_and_eval): Remove cast.
7708         * parse.c (write_dollar_variable): Remove cast.
7709         * block.h (struct block) <superblock>: Now const.
7710         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7711         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7712         (map_block): Make "block" const.
7713         * symfile.h (struct quick_symbol_functions)
7714         <map_matching_symbols>: Constify block argument to "callback".
7715         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7716         const.
7717         (find_pc_sect_compunit_symtab): Make "b" const.
7718         (find_symbol_at_address): Likewise.
7719         (search_symbols): Likewise.
7720         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7721         (dw2_debug_names_lookup_symbol): Likewise.
7722         (dw2_map_matching_symbols): Update.
7723         * p-valprint.c (pascal_val_print): Remove "block".
7724         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7725         (aux_add_nonlocal_symbols): Make "block" const.
7726         (resolve_subexp): Remove cast.
7727         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7728         const.
7729         (iterate_over_file_blocks): Likewise.
7730         * f-exp.y (%union) <bval>: Remove.
7731         * coffread.c (patch_opaque_types): Make "b" const.
7732         * spu-tdep.c (spu_catch_start): Make "block" const.
7733         * c-valprint.c (print_unpacked_pointer): Remove "block".
7734         * symmisc.c (dump_symtab_1): Make "b" const.
7735         (block_depth): Make "block" const.
7736         * d-exp.y (%union) <bval>: Remove.
7737         * cp-support.h (cp_lookup_rtti_type): Update.
7738         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7739         * psymtab.c (psym_lookup_symbol): Make "block" const.
7740         (maintenance_check_psymtabs): Make "b" const.
7741         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7742         (enumerate_locals, enumerate_args): Update.
7743         * python/py-symtab.c (stpy_global_block): Make "block" const.
7744         (stpy_static_block): Likewise.
7745         * inline-frame.c (block_starting_point_at): Make "new_block"
7746         const.
7747         * block.c (find_block_in_blockvector): Make return type const.
7748         (blockvector_for_pc_sect): Make "b" const.
7749         (find_block_in_blockvector): Make "b" const.
7750
7751 2019-03-23  Tom Tromey  <tom@tromey.com>
7752
7753         * varobj.c (varobj_create): Update.
7754         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7755         * printcmd.c (display_command, do_one_display): Don't reset
7756         innermost_block.
7757         * parser-defs.h (enum innermost_block_tracker_type): Move to
7758         expression.h.
7759         (innermost_block): Update comment.
7760         * parse.c (parse_exp_1): Add tracker_types parameter.
7761         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7762         tracker_types parameter.  Reset innermost_block.
7763         (parse_exp_in_context): Remove.
7764         (parse_expression_for_completion): Update.
7765         * objfiles.c (~objfile): Don't reset expression_context_block or
7766         innermost_block.
7767         * expression.h (enum innermost_block_tracker_type): Move from
7768         parser-defs.h.
7769         (parse_exp_1): Add tracker_types parameter.
7770         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7771         reset innermost_block.
7772
7773 2019-03-23  Tom Tromey  <tom@tromey.com>
7774
7775         * objfiles.h: Include bcache.h.
7776
7777 2019-03-23  Tom Tromey  <tom@tromey.com>
7778
7779         * linespec.c (get_current_search_block): Use
7780         scoped_restore_current_language.
7781         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7782
7783 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7784             Jiong Wang  <jiong.wang@arm.com>
7785
7786         * aarch64-linux-tdep.c
7787         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7788         section.
7789         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7790
7791 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7792             Jiong Wang  <jiong.wang@arm.com>
7793
7794         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7795         instructions.
7796         (aarch64_analyze_prologue_test): Add PACIASP test.
7797         (aarch64_prologue_prev_register): Unmask PC value.
7798
7799 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7800             Jiong Wang  <jiong.wang@arm.com>
7801
7802         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7803         (aarch64_dwarf2_prev_register): Unmask PC value.
7804         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7805         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7806         DW_CFA_AARCH64_negate_ra_state.
7807         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7808
7809 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7810             Jiong Wang  <jiong.wang@arm.com>
7811
7812         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7813         registers.
7814         (aarch64_pseudo_register_name): Likewise.
7815         (aarch64_pseudo_register_type): Likewise.
7816         (aarch64_pseudo_register_reggroup_p): Likewise.
7817         (aarch64_gdbarch_init): Add pauth registers.
7818         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7819         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7820         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7821         (struct gdbarch_tdep): Add regnum for ra_state.
7822
7823 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7824             Jiong Wang  <jiong.wang@arm.com>
7825
7826         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7827
7828 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7829             Jiong Wang  <jiong.wang@arm.com>
7830
7831         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7832         function.
7833         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7834         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7835         (aarch64_gdbarch_init): Add puth registers.
7836         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7837         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7838         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7839
7840 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7841             Jiong Wang  <jiong.wang@arm.com>
7842
7843         * aarch64-linux-nat.c
7844         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7845         * aarch64-linux-tdep.c
7846         (aarch64_linux_core_read_description): Likewise.
7847         (aarch64_linux_get_hwcap): New function.
7848         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7849         (aarch64_linux_get_hwcap): New declaration.
7850
7851 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7852             Jiong Wang  <jiong.wang@arm.com>
7853
7854         * aarch64-linux-nat.c
7855         (aarch64_linux_nat_target::read_description): Add pauth param.
7856         * aarch64-linux-tdep.c
7857         (aarch64_linux_core_read_description): Likewise.
7858         * aarch64-tdep.c (struct target_desc): Add in pauth.
7859         (aarch64_read_description): Add pauth param.
7860         (aarch64_gdbarch_init): Likewise.
7861         * aarch64-tdep.h (aarch64_read_description): Likewise.
7862         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7863         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7864         * features/Makefile: Add new files.
7865         * features/aarch64-pauth.c: New file.
7866         * features/aarch64-pauth.xml: New file.
7867
7868 2019-03-20  Tom Tromey  <tromey@adacore.com>
7869
7870         * infrun.c (handle_inferior_event): Rename from
7871         handle_inferior_event_1.  Create a scoped_value_mark.
7872         (handle_inferior_event): Remove.
7873
7874 2019-03-19  Tom Tromey  <tromey@adacore.com>
7875
7876         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7877         * infrun.h (print_stop_event): Add "displays" parameter.
7878         * infrun.c (print_stop_event): Add "displays" parameter.
7879
7880 2019-03-19  Pedro Alves  <palves@redhat.com>
7881
7882         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7883         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7884         to -1.  Fix TABs vs spaces.
7885         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7886         * tui/tui-out.h (tui_ui_out) Add intro comments.
7887         <m_line, m_start_of_line>: In-class initialize, and add describing
7888         comment.
7889
7890 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7891
7892         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7893         variable names.
7894         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7895
7896 2019-03-18  Pedro Alves  <palves@redhat.com>
7897             Eli Zaretskii <eliz@gnu.org>
7898
7899         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7900         m_line and m_start_of_line.
7901
7902 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7903
7904         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7905         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7906         it returns a newline.  This fixes a regression in TU mode, whereby
7907         the next line is output on the same screen line as the user input.
7908
7909 2019-03-18  Tom Tromey  <tromey@adacore.com>
7910
7911         * minsyms.c (minimal_symbol_reader::install): Remove call to
7912         obstack_blank.
7913
7914 2019-03-18  Pedro Alves  <palves@redhat.com>
7915
7916         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7917         New globals.
7918         (apply_style): New, factored out from ...
7919         (apply_ansi_escape): ... this.  Handle reverse video mode.
7920         (tui_set_reverse_mode): New function.
7921         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7922         * tui/tui-winsource.c (tui_show_source_line): Use
7923         tui_set_reverse_mode instead of setting A_STANDOUT.
7924         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7925         New setter methods.
7926
7927 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7928
7929         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7930         Handle tabs.
7931
7932 2019-03-18  Tom Tromey  <tromey@adacore.com>
7933
7934         * ada-lang.c (empty_array): Add "high" parameter.
7935         (ada_evaluate_subexp): Update.
7936
7937 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7938
7939         * unittests/string_view-selftests.c: Define
7940         _initialize_string_view_selftests unconditionally.
7941
7942 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7943
7944         PR gdb/24350
7945         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7946
7947 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7948
7949         PR gdb/24351
7950         * windows-nat.c (display_selector): Fix format specifiers.
7951
7952 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7953
7954         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7955         tui_refill_source_window instead of tui_refresh_win, to update the
7956         current execution line.  This fixes redisplay of the current line
7957         when stepping through the code with "next" or "step".
7958
7959 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7960
7961         * source-cache.c (source_cache::get_source_lines): Call
7962         find_source_lines to initialize s->nlines.  This fixes vertical
7963         scrolling of TUI source window when the DOWN arrow is pressed.
7964
7965 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7966
7967         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7968         linux-thread-db.c (_initialize_thread_db): Likewise.
7969
7970 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7971
7972         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7973         wclrtoeol in tui_show_source_line".  This reverts changes made in
7974         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7975
7976 2019-03-15  Tom Tromey  <tom@tromey.com>
7977
7978         * symtab.h (struct minimal_symbol): Derive from
7979         general_symbol_info.
7980         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7981         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7982         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7983         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7984         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7985         (MSYMBOL_SEARCH_NAME): Update.
7986         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7987         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7988         * minsyms.c (minimal_symbol_reader::record_full): Update.
7989
7990 2019-03-15  Tom Tromey  <tom@tromey.com>
7991
7992         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7993
7994 2019-03-15  Tom Tromey  <tom@tromey.com>
7995
7996         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7997         unique_xmalloc_ptr.
7998         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7999         Update.
8000         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8001         (build_minimal_symbol_hash_tables)
8002         (minimal_symbol_reader::install): Update.
8003
8004 2019-03-15  Tom Tromey  <tom@tromey.com>
8005
8006         * symtab.c (create_demangled_names_hash): Update.
8007         (symbol_set_names): Update.
8008         * objfiles.h (struct objfile_per_bfd_storage)
8009         <demangled_names_hash>: Now an htab_up.
8010         * objfiles.c (objfile_per_bfd_storage): Simplify.
8011
8012 2019-03-15  Tom Tromey  <tom@tromey.com>
8013
8014         * objfiles.h (struct objfile_per_bfd_storage): Declare
8015         destructor.
8016         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8017         New.
8018         (get_objfile_bfd_data): Use new.  Don't initialize
8019         language_of_main.
8020         (free_objfile_per_bfd_storage): Remove.
8021         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8022
8023 2019-03-15  Tom Tromey  <tom@tromey.com>
8024
8025         * symfile.c (reread_symbols): Update.
8026         * objfiles.c (objfile::objfile): Update.
8027         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8028         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8029         comment.
8030         (minimal_symbol_reader::install): Update.
8031         (terminate_minimal_symbol_table): Remove.
8032         * jit.c (jit_object_close_impl): Update.
8033
8034 2019-03-15  Tom Tromey  <tom@tromey.com>
8035
8036         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8037         initializations.
8038
8039 2019-03-15  Tom Tromey  <tom@tromey.com>
8040
8041         * objfiles.h (struct objfile_per_bfd_storage)
8042         <demangled_hash_languages>: Now a bitset.
8043         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8044         (lookup_minimal_symbol): Update.
8045
8046 2019-03-15  Tom Tromey  <tom@tromey.com>
8047
8048         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8049         Don't return the symbol.
8050         * coffread.c (record_minimal_symbol): Use record_full.
8051
8052 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8053
8054         The MS-Windows port of ncurses fails to switch to a color pair if
8055         one or both of the colors are the implicit default colors.  This
8056         change records the default colors when TUI is initialized, and
8057         then specifies them explicitly when a color pair uses the default
8058         colors.  This allows color styling in TUI mode on MS-Windows.
8059
8060         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8061         ncurses_norm_attr.
8062         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8063         colors in ncurses_norm_attr.
8064         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8065         "none", replace it with the default color recorded in
8066         ncurses_norm_attr.
8067
8068 2019-03-14  Tom Tromey  <tromey@adacore.com>
8069
8070         * source-cache.h (class source_cache) <get_source_lines>: Return
8071         std::string.
8072         * source-cache.c (source_cache::extract_lines): Handle case where
8073         first_pos==npos.  Return std::string.
8074         (source_cache::get_source_lines): Update.
8075
8076 2019-03-14  Tom Tromey  <tromey@adacore.com>
8077
8078         * NEWS: Add item for "style sources" commands.
8079         * source-cache.c (source_cache::get_source_lines): Check
8080         source_styling.
8081         * cli/cli-style.c (source_styling): New global.
8082         (_initialize_cli_style): Add "style sources" commands.
8083         (show_style_sources): New function.
8084         * cli/cli-style.h (source_styling): Declare.
8085
8086 2019-03-14  Pedro Alves  <palves@redhat.com>
8087             Tom Tromey  <tromey@adacore.com>
8088
8089         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8090         * tui/tui-winsource.c (tui_refill_source_window): New function,
8091         from...
8092         (tui_horizontal_source_scroll): ... here.  Move some logic.
8093         * cli/cli-style.c (set_style_enabled): Notify new observable.
8094         * tui/tui-hooks.c (tui_redisplay_source): New function.
8095         (tui_attach_detach_observers): Attach or detach
8096         tui_redisplay_source.
8097         * observable.h (source_styling_changed): New observable.
8098         * observable.c: Define source_styling_changed observable.
8099
8100 2019-03-13  Tom Tromey  <tromey@adacore.com>
8101
8102         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8103         (i386_gnu_nat_target::store_registers): Update.
8104         * target-debug.h (target_debug_print_std_string): New macro.
8105         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8106         * windows-tdep.c (display_one_tib): Update.
8107         * tui/tui-stack.c (tui_make_status_line): Update.
8108         * top.c (print_inferior_quit_action): Update.
8109         * thread.c (thr_try_catch_cmd): Update.
8110         (add_thread_with_info): Update.
8111         (thread_target_id_str): Update.
8112         (thr_try_catch_cmd): Update.
8113         (thread_command): Update.
8114         (thread_find_command): Update.
8115         * record-btrace.c (record_btrace_target::info_record)
8116         (record_btrace_resume_thread, record_btrace_target::resume)
8117         (record_btrace_cancel_resume, record_btrace_step_thread)
8118         (record_btrace_target::wait, record_btrace_target::wait)
8119         (record_btrace_target::wait, record_btrace_target::stop): Update.
8120         * progspace.c (print_program_space): Update.
8121         * process-stratum-target.c
8122         (process_stratum_target::thread_address_space): Update.
8123         * linux-fork.c (linux_fork_mourn_inferior)
8124         (detach_checkpoint_command, info_checkpoints_command)
8125         (linux_fork_context): Update.
8126         (linux_fork_detach): Update.
8127         (class scoped_switch_fork_info): Update.
8128         (delete_checkpoint_command): Update.
8129         * infrun.c (follow_fork_inferior): Update.
8130         (follow_fork_inferior): Update.
8131         (proceed_after_vfork_done): Update.
8132         (handle_vfork_child_exec_or_exit): Update.
8133         (follow_exec): Update.
8134         (displaced_step_prepare_throw): Update.
8135         (displaced_step_restore): Update.
8136         (start_step_over): Update.
8137         (resume_1): Update.
8138         (clear_proceed_status_thread): Update.
8139         (proceed): Update.
8140         (print_target_wait_results): Update.
8141         (do_target_wait): Update.
8142         (context_switch): Update.
8143         (stop_all_threads): Update.
8144         (restart_threads): Update.
8145         (finish_step_over): Update.
8146         (handle_signal_stop): Update.
8147         (switch_back_to_stepped_thread): Update.
8148         (keep_going_pass_signal): Update.
8149         (print_exited_reason): Update.
8150         (normal_stop): Update.
8151         * inferior.c (inferior_pid_to_str): Change return type.
8152         (print_selected_inferior): Update.
8153         (add_inferior): Update.
8154         (detach_inferior): Update.
8155         * dummy-frame.c (fprint_dummy_frames): Update.
8156         * dcache.c (dcache_info_1): Update.
8157         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8158         (btrace_fetch, btrace_clear): Update.
8159         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8160         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8161         type.
8162         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8163         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8164         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8165         * gdbarch.c, gdbarch.h: Rebuild.
8166         * gdbarch.sh (core_pid_to_str): Change return type.
8167         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8168         return type.
8169         (windows_nat_target::pid_to_str): Change return type.
8170         (windows_delete_thread): Update.
8171         (windows_nat_target::attach): Update.
8172         (windows_nat_target::files_info): Update.
8173         * target-delegates.c: Rebuild.
8174         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8175         return type.
8176         (sol_thread_target::pid_to_str): Change return type.
8177         * remote.c (class remote_target) <pid_to_str>: Change return
8178         type.
8179         (remote_target::pid_to_str): Change return type.
8180         (extended_remote_target::attach, remote_target::remote_stop_ns)
8181         (remote_target::remote_notif_remove_queued_reply)
8182         (remote_target::push_stop_reply, remote_target::disable_btrace):
8183         Update.
8184         (extended_remote_target::attach): Update.
8185         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8186         type.
8187         (gdbsim_target::pid_to_str): Change return type.
8188         * ravenscar-thread.c (struct ravenscar_thread_target)
8189         <pid_to_str>: Change return type.
8190         (ravenscar_thread_target::pid_to_str): Change return type.
8191         * procfs.c (class procfs_target) <pid_to_str>: Change return
8192         type.
8193         (procfs_target::pid_to_str): Change return type.
8194         (procfs_target::attach): Update.
8195         (procfs_target::detach): Update.
8196         (procfs_target::fetch_registers): Update.
8197         (procfs_target::store_registers): Update.
8198         (procfs_target::wait): Update.
8199         (procfs_target::files_info): Update.
8200         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8201         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8202         return type.
8203         (nto_procfs_target::pid_to_str): Change return type.
8204         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8205         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8206         return type.
8207         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8208         (exit_lwp): Update.
8209         (attach_proc_task_lwp_callback, get_detach_signal)
8210         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8211         (linux_nat_target::resume, wait_lwp, stop_callback)
8212         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8213         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8214         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8215         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8216         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8217         type.
8218         (inf_ptrace_target::attach): Update.
8219         (inf_ptrace_target::files_info): Update.
8220         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8221         type.
8222         (go32_nat_target::pid_to_str): Change return type.
8223         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8224         (gnu_nat_target::wait): Update.
8225         (gnu_nat_target::wait): Update.
8226         (gnu_nat_target::resume): Update.
8227         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8228         (fbsd_nat_target::wait): Update.
8229         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8230         type.
8231         (darwin_nat_target::attach): Update.
8232         * corelow.c (class core_target) <pid_to_str>: Change return type.
8233         (core_target::pid_to_str): Change return type.
8234         * target.c (normal_pid_to_str): Change return type.
8235         (default_pid_to_str): Likewise.
8236         (target_pid_to_str): Change return type.
8237         (target_translate_tls_address): Update.
8238         (target_announce_detach): Update.
8239         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8240         return type.
8241         (bsd_uthread_target::pid_to_str): Change return type.
8242         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8243         type.
8244         (bsd_kvm_target::pid_to_str): Change return type.
8245         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8246         return type.
8247         (aix_thread_target::pid_to_str): Change return type.
8248         * target.h (struct target_ops) <pid_to_str>: Change return type.
8249         (target_pid_to_str, normal_pid_to_str): Likewise.
8250         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8251         type.
8252         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8253         type.
8254         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8255         return type.
8256         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8257         type.
8258         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8259         type.
8260         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8261         return type.
8262
8263 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8264
8265         * NEWS: Mention that the new default MI version is 3.  Mention
8266         changes to the output of commands and events that deal with
8267         multi-location breakpoints.
8268         * breakpoint.c: Include "mi/mi-out.h".
8269         (print_one_breakpoint): Change output syntax if using MI version
8270         >= 3.
8271         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8272         New.
8273         (mi_multi_location_breakpoint_output_fixed): New.
8274         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8275         (mi_cmd_fix_multi_location_breakpoint_output): New.
8276         (mi_multi_location_breakpoint_output_fixed): New.
8277         * mi/mi-cmds.c (mi_cmds): Register command
8278         -fix-multi-location-breakpoint-output.
8279         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8280         interpreter "mi".
8281
8282 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8283
8284         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8285         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8286         instantiate mi_ui_out based on interpreter name.
8287         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8288         * mi/mi-main.c (mi_load_progress): Likewise.
8289
8290 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8291
8292         * NEWS: Combine separate "New targets" sections for 8.3.
8293
8294 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8295
8296         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8297         (ppcfbsd_init_abi): Install gdbarch
8298         "fetch_tls_load_module_address" and "get_thread_local_address"
8299         methods.
8300
8301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8302
8303         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8304         (riscv_fbsd_init_abi): Install gdbarch
8305         "fetch_tls_load_module_address" and "get_thread_local_address"
8306         methods.
8307
8308 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8309
8310         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8311         (i386fbsd_init_abi): Install gdbarch
8312         "fetch_tls_load_module_address" and "get_thread_local_address"
8313         methods.
8314
8315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8316
8317         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8318         (amd64fbsd_init_abi): Install gdbarch
8319         "fetch_tls_load_module_address" and "get_thread_local_address"
8320         methods.
8321
8322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8323
8324         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8325         (struct fbsd_pspace_data): New type.
8326         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8327         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8328         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8329         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8330         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8331
8332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8333
8334         * gdbtypes.c (lookup_struct_elt): New function.
8335         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8336         * gdbtypes.h (struct struct_elt): New type.
8337         (lookup_struct_elt): New prototype.
8338
8339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8340
8341         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8342         remove disabled code block.
8343
8344 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8345
8346         * gdbarch.sh (get_thread_local_address): New method.
8347         * gdbarch.h, gdbarch.c: Regenerate.
8348         * target.c (target_translate_tls_address): Use
8349         gdbarch_get_thread_local_address if present instead of
8350         target::get_thread_local_address.
8351
8352 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8353
8354         * target.h (target::get_thread_local_address): Update comment.
8355
8356 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8357
8358         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8359         objfile->separate_debug_objfile_backlink if not NULL.
8360
8361 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8362
8363         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8364         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8365         (amd64bsd_store_inferior_registers): Likewise.
8366         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8367         Enable segment base registers.
8368         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8369         PT_GETFSBASE and PT_GETGSBASE.
8370         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8371         PT_SETGSBASE.
8372         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8373         segment base registers.
8374         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8375
8376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8377
8378         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8379         Update calls to i386_target_description to add 'segments'
8380         parameter.
8381         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8382         add segment base registers.
8383         * arch/i386.c (i386_create_target_description): Add 'segments'
8384         parameter to enable segment base registers.
8385         * arch/i386.h (i386_create_target_description): Likewise.
8386         * features/i386/32bit-segments.xml: New file.
8387         * features/i386/32bit-segments.c: Generate.
8388         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8389         call to i386_target_description to add 'segments' parameter.
8390         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8391         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8392         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8393         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8394         if feature is present.
8395         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8396         Add 'segments' parameter to call to i386_target_description.
8397         (i386_target_description): Add 'segments' parameter to enable
8398         segment base registers.
8399         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8400         to call to i386_target_description.
8401         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8402         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8403         Define I386_NUM_REGS.
8404         (i386_target_description): Add 'segments' parameter to enable
8405         segment base registers.
8406
8407 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8408
8409         PR/24325
8410         * source-cache.c: #undef open and close, to avoid unresolved
8411         externals during linking.
8412
8413 2019-03-12  Tom Tromey  <tromey@adacore.com>
8414
8415         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8416         const.  Add initializers.
8417         (_initialize_remote): Don't initialize ptid globals.
8418
8419 2019-03-12  Pedro Alves  <palves@redhat.com>
8420
8421         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8422
8423 2019-03-12  Pedro Alves  <palves@redhat.com>
8424
8425         * cp-name-parser.y (main): Remove unused 'len' variable.
8426
8427 2019-03-12  Tom Tromey  <tromey@adacore.com>
8428
8429         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8430         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8431
8432 2019-03-12  Tom Tromey  <tromey@adacore.com>
8433
8434         * linux-nat.c (iterate_over_lwps): Update.
8435         (stop_callback): Remove parameter.
8436         (stop_wait_callback, detach_callback, resume_set_callback)
8437         (select_singlestep_lwp_callback, set_ignore_sigint)
8438         (status_callback, resumed_callback, resume_clear_callback)
8439         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8440         data parameter.
8441         (linux_nat_target::detach, linux_nat_target::resume)
8442         (linux_stop_and_wait_all_lwps, select_event_lwp)
8443         (linux_nat_filter_event, linux_nat_wait_1)
8444         (linux_nat_target::kill, linux_nat_target::stop)
8445         (linux_nat_target::stop): Update.
8446         (linux_nat_resume_callback): Change type.
8447         (resume_stopped_resumed_lwps, count_events_callback)
8448         (select_event_lwp_callback): Likewise.
8449         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8450         * arm-linux-nat.c (struct update_registers_data): Remove.
8451         (update_registers_callback): Change type.
8452         (arm_linux_insert_hw_breakpoint1): Update.
8453         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8454         parameter.
8455         (x86_linux_dr_set_addr): Update.
8456         (x86_linux_dr_set_control): Update.
8457         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8458         (iterate_over_lwps): Use gdb::function_view.
8459         * nat/aarch64-linux-hw-point.c (struct
8460         aarch64_dr_update_callback_param): Remove.
8461         (debug_reg_change_callback): Change type.
8462         (aarch64_notify_debug_reg_change): Update.
8463         * s390-linux-nat.c (s390_refresh_per_info): Update.
8464
8465 2019-03-11  Tom Tromey  <tromey@adacore.com>
8466
8467         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8468         redundant assignment to "this_cu".
8469
8470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8471
8472         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8473
8474 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8475
8476         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8477         from...
8478         (rank_one_type): ... this.
8479
8480 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8481
8482         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8483         from...
8484         (rank_one_type): ... this.
8485
8486 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8487
8488         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8489         from...
8490         (rank_one_type): ... this.
8491
8492 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8493
8494         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8495         from...
8496         (rank_one_type): ... this.
8497
8498 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8499
8500         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8501         from...
8502         (rank_one_type): ... this.
8503
8504 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8505
8506         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8507         from...
8508         (rank_one_type): ... this.
8509
8510 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8511
8512         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8513         from...
8514         (rank_one_type): ... this.
8515
8516 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8517
8518         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8519         from...
8520         (rank_one_type): ... this.
8521
8522 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8523
8524         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8525         from...
8526         (rank_one_type): ... this.
8527
8528 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8529
8530         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8531         from...
8532         (rank_one_type): ... this.
8533
8534 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8535
8536         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8537         from...
8538         (rank_one_type): ... this.
8539
8540 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8541
8542         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8543         from...
8544         (rank_one_type): ... this.
8545
8546 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8547
8548         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8549         inferior-events' shows the example events.
8550
8551 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8552
8553         Support styling on native MS-Windows console
8554
8555         PR/24315
8556         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8557         on MS-Windows if $TERM is not defined.
8558
8559         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8560
8561         * posix-hdep.c (gdb_console_fputs):
8562         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8563         functions.
8564         * ui-file.h (gdb_console_fputs): Add prototype.
8565
8566         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8567         back to fputs only if the former returns zero.
8568
8569 2019-03-07  Tom Tromey  <tom@tromey.com>
8570
8571         * symmisc.c (print_symbol_bcache_statistics): Update.
8572         (print_objfile_statistics): Update.
8573         * symfile.c (allocate_symtab): Update.
8574         * stabsread.c: Don't include bcache.h.
8575         * psymtab.h (struct psymbol_bcache): Don't declare.
8576         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8577         (psymbol_bcache_init, psymbol_bcache_free)
8578         (psymbol_bcache_get_bcache): Don't declare.
8579         * psymtab.c (struct psymbol_bcache): Remove.
8580         (psymtab_storage::psymtab_storage): Update.
8581         (psymtab_storage::~psymtab_storage): Update.
8582         (psymbol_bcache_init, psymbol_bcache_free)
8583         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8584         (add_psymbol_to_bcache): Update.
8585         (allocate_psymtab): Update.
8586         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8587         macro_cache>: No longer pointers.
8588         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8589         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8590         * macrotab.c (macro_bcache): Update.
8591         * macroexp.c: Don't include bcache.h.
8592         * gdbtypes.c (check_types_worklist): Update.
8593         (types_deeply_equal): Remove TRY/CATCH.  Update.
8594         * elfread.c (elf_symtab_read): Update.
8595         * dwarf2read.c: Don't include bcache.h.
8596         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8597         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8598         (print_bcache_statistics, bcache_memory_used): Don't declare.
8599         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8600         methods.  Rename all data members.
8601         * bcache.c (struct bcache): Move to bcache.h.
8602         (bcache::expand_hash_table): Rename from expand_hash_table.
8603         (bcache): Remove.
8604         (bcache::insert): Rename from bcache_full.
8605         (bcache::compare): Rename from bcache_compare.
8606         (bcache_xmalloc): Remove.
8607         (bcache::~bcache): Rename from bcache_xfree.
8608         (bcache::print_statistics): Rename from print_bcache_statistics.
8609         (bcache::memory_used): Rename from bcache_memory_used.
8610
8611 2019-03-07  Pedro Alves  <palves@redhat.com>
8612
8613         * infrun.c (normal_stop): Also check for
8614         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8615
8616 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8617
8618         * f-lang.c (value_from_host_double): Moved to...
8619         * value.c (value_from_host_double): ...here.
8620         * value.h (value_from_host_double): Declare.
8621         * guile/scm-math.c (vlscm_convert_typed_number): Use
8622         value_from_host_double.
8623         (vlscm_convert_number): Likewise.
8624         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8625         * python/py-value.c (convert_value_from_python): Likewise.
8626
8627 2019-03-06  Tom Tromey  <tom@tromey.com>
8628
8629         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8630
8631 2019-03-06  Tom Tromey  <tom@tromey.com>
8632
8633         * utils.h (free_current_contents): Don't declare.
8634         * utils.c (free_current_contents): Remove.
8635
8636 2019-03-06  Tom Tromey  <tom@tromey.com>
8637
8638         * top.c (quit_force): Update.
8639         * main.c (captured_command_loop): Update.
8640         * common/new-op.c (operator new): Update.
8641         * common/common-exceptions.c (struct catcher)
8642         <save_cleanup_chain>: Remove member.
8643         (exceptions_state_mc_init): Update.
8644         (exception_try_scope_entry): Return nullptr.
8645         (exception_try_scope_exit, exception_rethrow)
8646         (throw_exception_sjlj, throw_exception_cxx): Update.
8647         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8648         (all_cleanups, do_cleanups, discard_cleanups)
8649         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8650         (restore_cleanups, restore_final_cleanups): Don't declare.
8651         (do_final_cleanups): Remove parameter.
8652         * common/cleanups.c (cleanup_chain, make_cleanup)
8653         (make_cleanup_dtor, all_cleanups, do_cleanups)
8654         (discard_my_cleanups, discard_cleanups)
8655         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8656         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8657         (null_cleanup): Remove.
8658         (do_final_cleanups): Remove parameter.
8659
8660 2019-03-06  Tom Tromey  <tom@tromey.com>
8661
8662         * remote.c (remote_target::remote_parse_stop_reply): Use
8663         unique_xmalloc_ptr.
8664
8665 2019-03-06  Tom Tromey  <tom@tromey.com>
8666
8667         * stabsread.c (struct stabs_field_info): Rename from field_info.
8668         <list, fnlist>: Add initializers.
8669         <obstack>: New member.
8670         (read_member_functions, read_struct_fields, read_baseclasses):
8671         Allocate on obstack.  Don't use cleanups.
8672         (read_one_struct_field, read_member_functions, read_struct_fields)
8673         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8674         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8675         (read_struct_type): Update.
8676
8677 2019-03-06  Tom Tromey  <tom@tromey.com>
8678
8679         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8680         * common/filestuff.h (make_cleanup_close): Don't declare.
8681         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8682         Remove.
8683
8684 2019-03-06  Tom Tromey  <tom@tromey.com>
8685
8686         * solib-aix.c: Use make_scope_exit.
8687
8688 2019-03-06  Tom Tromey  <tom@tromey.com>
8689
8690         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8691         Use make_scope_exit.
8692
8693 2019-03-06  Tom Tromey  <tom@tromey.com>
8694
8695         * solib-svr4.c (disable_probes_interface): Remove parameter.
8696         (svr4_handle_solib_event): Use make_scope_exit.
8697
8698 2019-03-06  Tom Tromey  <tom@tromey.com>
8699
8700         * remote.c (struct stop_reply_deleter): Remove.
8701         (stop_reply_up): Update.
8702         (struct stop_reply): Derive from notif_event.  Don't typedef.
8703         <regcache>: Now a std::vector.
8704         (stop_reply_xfree): Remove.
8705         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8706         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8707         (remote_target::discard_pending_stop_replies): Use delete.
8708         (remote_target::remote_parse_stop_reply): Update.
8709         (remote_target::process_stop_reply): Update.
8710         * remote-notif.h (struct notif_event): Add virtual destructor.
8711         Remove "dtr" member.
8712         (struct notif_client) <alloc_event>: Return a unique_ptr.
8713         (notif_event_xfree): Don't declare.
8714         (notif_event_up): New typedef.
8715         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8716         (notif_event_xfree, do_notif_event_xfree): Remove.
8717         (remote_notif_state_xfree): Update.
8718
8719 2019-03-06  Tom Tromey  <tom@tromey.com>
8720
8721         * infrun.c (displaced_step_clear_cleanup): Now a
8722         forward_scope_exit type.
8723         (displaced_step_prepare_throw): Update.
8724         (displaced_step_fixup): Update.
8725
8726 2019-03-06  Tom Tromey  <tom@tromey.com>
8727
8728         * inferior.h (class inferior): Update comment.
8729         * gdbthread.h (class thread_info): Update comment.
8730
8731 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8732             Tom Tromey  <tom@tromey.com>
8733
8734         * stabsread.h (struct stab_section_list): Remove.
8735         (coffstab_build_psymtabs): Update.
8736         * dbxread.c (symbuf_sections): Now a std::vector.
8737         (sect_idx): New global.
8738         (fill_symbuf): Update.
8739         (coffstab_build_psymtabs): Change type of stabsects parameter.
8740         Update.
8741         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8742         std::vector.
8743         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8744         (coff_locate_sections): Update.
8745         (coff_symfile_read): Remove cleanups.  Update.
8746         (init_stringtab): Add storage parameter.
8747         (free_stringtab, free_stringtab_cleanup): Remove.
8748         (init_lineno): Add storage parameter.
8749         (free_linetab, free_linetab_cleanup): Remove.
8750
8751 2019-03-06  Pedro Alves  <palves@redhat.com>
8752
8753         * linux-fork.c (fork_info::clobber_regs): Delete.
8754         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8755         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8756         comment.  Adjust.
8757         (scoped_switch_fork_info::scoped_switch_fork_info)
8758         (checkpoint_command, linux_fork_context): Adjust
8759         fork_save_infrun_state calls.
8760
8761 2019-03-06  Pedro Alves  <palves@redhat.com>
8762
8763         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8764         (inf_has_multiple_threads): Return 'bool' and rewrite using
8765         inferior_info::threads().
8766
8767 2019-03-06  Pedro Alves  <palves@redhat.com>
8768
8769         * linux-fork.c: Include <list>.
8770         (fork_list): Now a std::list instance.
8771         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8772         (forks_exist_p, find_last_fork): Adjust.
8773         (new_fork): Delete.
8774         (one_fork_p): New.
8775         (add_fork): Adjust.
8776         (free_fork): Delete, folded into fork_info::~fork_info().
8777         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8778         Adjust.
8779         (init_fork_list): Delete.
8780         (linux_fork_killall, linux_fork_mourn_inferior)
8781         (linux_fork_detach, info_checkpoints_command): Adjust.
8782         (_initialize_linux_fork): No longer call init_fork_list.
8783
8784 2019-03-06  Pedro Alves  <palves@redhat.com>
8785
8786         * linux-fork.c (new_fork): New, split out of ...
8787         (add_fork): ... this.  Return void.  Move "first fork" special
8788         case from here, to ...
8789         (checkpoint_command): ... here.
8790         * linux-linux.h (add_fork): Return void.
8791
8792 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8793
8794         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8795
8796 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8797             Chris January  <chris.january@arm.com>
8798             David Lecomber  <david.lecomber@arm.com>
8799
8800         * f-exp.y: New token, UNOP_INTRINSIC.
8801         (exp): New pattern using UNOP_INTRINSIC token.
8802         (f77_keywords): Add 'abs' keyword.
8803         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8804         (value_from_host_double): New function.
8805         (evaluate_subexp_f): Support UNOP_ABS.
8806
8807 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8808
8809         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8810         types.
8811
8812 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8813
8814         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8815         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8816         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8817
8818 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8819
8820         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8821
8822 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8823             Chris January  <chris.january@arm.com>
8824
8825         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8826         * f-exp.y: Define 'KIND' token.
8827         (exp): New pattern for KIND expressions.
8828         (ptype): Handle types with a kind extension.
8829         (direct_abs_decl): Extend to spot kind extensions.
8830         (f77_keywords): Add 'kind' to the list.
8831         (push_kind_type): New function.
8832         (convert_to_kind_type): New function.
8833         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8834         * parse.c (operator_length_standard): Likewise.
8835         * parser-defs.h (enum type_pieces): Add tp_kind.
8836         * std-operator.def: Add UNOP_KIND.
8837
8838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * f-exp.y (f_parse): Set yydebug.
8841
8842 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8843
8844         * f-lang.c (evaluate_subexp_f): New function.
8845         (exp_descriptor_f): New global.
8846         (f_language_defn): Use exp_descriptor_f instead of
8847         exp_descriptor_standard.
8848
8849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8850
8851         * f-exp.y (struct token): Add comments.
8852         (dot_ops): Remove uppercase versions and the end marker.
8853         (f77_keywords): Likewise.
8854         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8855         entries in the dot_ops array are case insensitive, and use
8856         strncasecmp to compare strings.  Also some whitespace cleanup in
8857         this area.  Similar for the f77_keywords array, except entries in
8858         this list might be case sensitive.
8859
8860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8861
8862         * f-exp.y (struct f77_boolean_val): Add comments.
8863         (boolean_values): Remove uppercase versions, and end marker.
8864         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8865         and use strncasecmp to achieve case insensitivity.  Additionally,
8866         perform whitespace cleanup around this code.
8867
8868 2019-03-06  Tom Tromey  <tromey@adacore.com>
8869
8870         * remote-sim.c (gdbsim_target_open): Use result of
8871         gdb_argv::release.
8872
8873 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8874         Dirk Schubert  <dirk.schubert@arm.com>
8875         Chris January  <chris.january@arm.com>
8876
8877         * eval.c (evaluate_subexp_standard): Call Fortran argument
8878         wrapping logic.
8879         * f-lang.c (struct value): A value which can be passed into a
8880         Fortran function call.
8881         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8882         where appropriate.
8883         (struct type): Value ready for a Fortran function call.
8884         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8885         is needed.
8886         * f-lang.h (fortran_argument_convert): Declaration.
8887         (fortran_preserve_arg_pointer): Declaration.
8888         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8889
8890 2019-03-05  Tom Tromey  <tromey@adacore.com>
8891
8892         * python/py-prettyprint.c (print_string_repr): Remove #if.
8893         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8894
8895 2019-03-05  Tom Tromey  <tromey@adacore.com>
8896
8897         * target.c (the_dummy_target): Move later.  Change type to
8898         "dummy_target".
8899         (initialize_targets): Don't initialize the_dummy_target.
8900
8901 2019-03-05  Tom Tromey  <tromey@adacore.com>
8902
8903         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8904         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8905
8906 2019-03-05  Tom Tromey  <tromey@adacore.com>
8907
8908         * windows-nat.c (windows_nat_target::attach)
8909         (windows_nat_target::detach): Don't call gdb_flush.
8910         * valprint.c (generic_val_print, val_print, val_print_string):
8911         Don't call gdb_flush.
8912         * utils.c (defaulted_query): Don't call gdb_flush.
8913         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8914         * target.c (target_announce_detach): Don't call gdb_flush.
8915         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8916         * remote.c (extended_remote_target::attach): Don't call
8917         gdb_flush.
8918         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8919         * printcmd.c (do_examine): Don't call gdb_flush.
8920         (info_display_command): Don't call gdb_flush.
8921         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8922         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8923         * memattr.c (info_mem_command): Don't call gdb_flush.
8924         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8925         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8926         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8927         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8928         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8929         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8930         (gnu_nat_target::detach): Don't call gdb_flush.
8931         * f-valprint.c (f_val_print): Don't call gdb_flush.
8932         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8933         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8934         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8935         gdb_flush.
8936         * c-valprint.c (c_val_print): Don't call gdb_flush.
8937         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8938
8939 2019-03-05  Tom Tromey  <tromey@adacore.com>
8940
8941         * varobj.c (update_dynamic_varobj_children): Update.
8942         (install_default_visualizer): Use reset, not release.
8943         * value.c (set_internalvar): Update.
8944         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8945         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8946         ATTRIBUTE_UNUSED_RESULT.
8947
8948 2019-03-05  Tom Tromey  <tromey@adacore.com>
8949
8950         * remote.c (class scoped_remote_fd) <release>: Add
8951         ATTRIBUTE_UNUSED_RESULT.
8952
8953 2019-03-05  Tom Tromey  <tromey@adacore.com>
8954
8955         * macroexp.c (struct macro_buffer) <release>: Add
8956         ATTRIBUTE_UNUSED_RESULT.
8957
8958 2019-03-05  Tom Tromey  <tromey@adacore.com>
8959
8960         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8961         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8962         ATTRIBUTE_UNUSED_RESULT.
8963
8964 2019-03-05  Tom Tromey  <tromey@adacore.com>
8965
8966         * common/scoped_fd.h (class scoped_fd) <release>: Add
8967         ATTRIBUTE_UNUSED_RESULT.
8968
8969 2019-03-05  Tom Tromey  <tromey@adacore.com>
8970
8971         * parser-defs.h (struct parser_state) <release>: Add
8972         ATTRIBUTE_UNUSED_RESULT.
8973
8974 2019-03-05  Tom Tromey  <tromey@adacore.com>
8975
8976         * utils.h (class gdb_argv) <release>: Add
8977         ATTRIBUTE_UNUSED_RESULT.
8978         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8979
8980 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8981
8982         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8983         for-loop range, to avoid compiler warnings.
8984
8985         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8986         avoid compiler warnings about unused variables.
8987
8988         * NEWS: Mention end of support for native debugging on MS-Windows
8989         before XP.
8990
8991         PR gdb/24292
8992         * common/netstuff.c:
8993         * gdbserver/gdbreplay.c
8994         * gdbserver/remote-utils.c:
8995         * ser-tcp.c:
8996         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8997         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8998         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8999         'getaddrinfo' and 'freeaddrinfo' were not available before
9000         Windows XP, and mingw.org's MinGW headers by default define
9001         _WIN32_WINNT to 0x500.
9002
9003 2019-03-01  Gary Benson <gbenson@redhat.com>
9004
9005         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9006
9007 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9008             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9009
9010         PR gdb/8527
9011         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9012         set_sigint_trap, clear_sigint_trap.
9013
9014 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9015
9016         * target.c (target_detach): Clear the regcache and the
9017         frame cache.
9018
9019 2019-02-27  Pedro Alves  <palves@redhat.com>
9020
9021         * utils.c (set_screen_size): When we cap the height/width sizes,
9022         tweak the corresponding command variable to show "unlimited":
9023
9024 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9025             Pedro Alves  <palves@redhat.com>
9026
9027         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9028         before calling rl_set_screen_size.
9029
9030 2019-02-27  Tom Tromey  <tromey@adacore.com>
9031
9032         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9033         define.
9034         * python/py-value.c: Remove Python 2.4 workaround.
9035         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9036         workaround.
9037         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9038         Python 2.4 workaround.
9039         * python/python-internal.h: Remove Python 2.4 comment.
9040         (Py_ssize_t): Don't define.
9041         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9042         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9043         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9044         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9045         * python/python.c (do_start_initialization): Remove Python 2.4
9046         workaround.
9047         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9048         (print_children): Remove Python 2.4 workaround.
9049         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9050         workaround.
9051         (CHARBUFFERPROC_NAME): Remove.
9052         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9053         Python 2.4 workaround.
9054
9055 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9056
9057         * NEWS: Note minimum Python version.
9058
9059 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9060
9061         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9062         code from these functions.  Remove corresponding ifdefs.  Use
9063         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9064         Remove gotos and target of gotos.
9065         (infpy_search_memory): Likewise.
9066
9067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9068
9069         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9070         (hppa_gdbarch_init): Don't register deleted functions with
9071         gdbarch.
9072
9073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9074
9075         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9076         (h8300_unwind_sp): Delete.
9077         (h8300_dummy_id): Delete.
9078         (h8300_gdbarch_init): Don't register deleted functions with
9079         gdbarch.
9080
9081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9082
9083         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9084         (ft32_unwind_pc): Delete.
9085         (ft32_unwind_sp): Delete.
9086         (ft32_gdbarch_init): Don't register deleted functions with
9087         gdbarch.
9088
9089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9090
9091         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9092         (frv_unwind_pc): Delete.
9093         (frv_unwind_sp): Delete.
9094         (frv_gdbarch_init): Don't register deleted functions with
9095         gdbarch.
9096
9097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9098
9099         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9100         (riscv_unwind_pc): Delete.
9101         (riscv_unwind_sp): Delete.
9102         (riscv_gdbarch_init): Don't register deleted functions with
9103         gdbarch.
9104
9105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9106
9107         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9108         (csky_unwind_pc): Delete.
9109         (csky_unwind_sp): Delete.
9110         (csky_gdbarch_init): Don't register deleted functions with
9111         gdbarch.
9112
9113 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9114
9115         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9116         (cris_unwind_pc): Delete.
9117         (cris_unwind_sp): Delete.
9118         (cris_gdbarch_init): Don't register deleted functions with
9119         gdbarch.
9120
9121 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9122
9123         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9124         (bfin_unwind_pc): Delete.
9125         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9126
9127 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9128
9129         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9130         (arm_unwind_pc): Delete.
9131         (arm_unwind_sp): Delete.
9132         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9133
9134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9135
9136         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9137         (arc_unwind_pc): Delete.
9138         (arc_unwind_sp): Delete.
9139         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9140
9141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9142
9143         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9144         (alpha_unwind_pc): Delete.
9145         (alpha_gdbarch_init): Don't register deleted functions with
9146         gdbarch.
9147
9148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9149
9150         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9151         (aarch64_unwind_pc): Delete.
9152         (aarch64_unwind_sp): Delete.
9153         (aarch64_gdbarch_init): Don't register deleted functions with
9154         gdbarch.
9155
9156 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9157
9158         * gdbtypes.c (type_align): Don't consider static members when
9159         computing structure alignment.
9160
9161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9162
9163         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9164         return 0 for other types.
9165         * arch-utils.c (default_type_align): Always return 0.
9166         * gdbarch.h: Regenerate.
9167         * gdbarch.sh (type_align): Extend comment.
9168         * gdbtypes.c (type_align): Add additional comments, always call
9169         gdbarch_type_align before applying the default rules.
9170         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9171         generic code will then apply a suitable default.
9172         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9173         types, return 0 for other types.
9174
9175 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9176
9177         * NEWS: Create a new section for the next release branch.
9178         Rename the section of the current branch, now that it has
9179         been cut.
9180
9181 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9182
9183         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9184         * version.in: Bump version to 8.3.50.DATE-git.
9185
9186 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9187
9188         * aix-thread.c (ptid_cmp): Remove unused variable.
9189         (get_signaled_thread): Likewise.
9190         (store_regs_user_thread): Likewise.
9191         (store_regs_kernel_thread): Likewise.
9192         (fetch_regs_kernel_thread): Remove shadowed variable.
9193
9194 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9195
9196         * features/riscv/32bit-cpu.xml: Add register numbers.
9197         * features/riscv/32bit-fpu.c: Regenerate.
9198         * features/riscv/32bit-fpu.xml: Add register numbers.
9199         * features/riscv/64bit-cpu.xml: Add register numbers.
9200         * features/riscv/64bit-fpu.c: Regenerate.
9201         * features/riscv/64bit-fpu.xml: Add register numbers.
9202
9203 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9204
9205         * NEWS: Mention two argument form of gdb.Value constructor.
9206         * python/py-value.c (convert_buffer_and_type_to_value): New
9207         function.
9208         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9209         Add support for handling an optional second argument.  Call
9210         convert_buffer_and_type_to_value as appropriate.
9211         * python/python-internal.h (Py_buffer_deleter): New struct.
9212         (Py_buffer_up): New typedef.
9213
9214 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9215
9216         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9217         instead of releasing ownership.
9218
9219 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9220
9221         * dwarf2read.c (open_and_init_dwp_file): Call
9222         elf_numsections instead of bfd_count_sections to initialize
9223         dwp_file->num_sections.
9224
9225 2019-02-25  Tom Tromey  <tromey@adacore.com>
9226
9227         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9228
9229 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9230
9231         * gcore.in: Add '--readnever' option when invoking GDB.
9232
9233 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9234
9235         * MAINTAINERS: Update my email address.
9236
9237 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9238
9239         * build-id.c (build_id_to_debug_bfd_1): New function.
9240         (build_id_to_debug_bfd): Look for separate debug file in
9241         sysroot.
9242
9243 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9244
9245         * gdbarch.sh: Update the copyright year range that is placed into
9246         generated files.
9247
9248 2019-02-22  Keith Seitz  <keiths@redhat.com>
9249
9250         PR symtab/23853
9251         * linespec.c (create_sals_line_offset): Search for the default
9252         symtab's filename instead of its fullname.
9253
9254 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9255
9256         * NEWS: Update style defaults.
9257
9258 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9259
9260         * main.c (captured_main_1): Disable styling in batch mode.
9261
9262 2019-02-20  Tom Tromey  <tom@tromey.com>
9263
9264         * symtab.c (symtab_symbol_info): Fix typos.
9265
9266 2019-02-20  Tom Tromey  <tromey@adacore.com>
9267
9268         * findcmd.c (_initialize_mem_search): Use upper case for
9269         metasyntactic variables.
9270
9271 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9272
9273         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9274         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9275
9276 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9277
9278         * top.h (source_file_name): Change to std::string.
9279         * top.c (source_file_name): Likewise.
9280         (command_line_input): Adjust.
9281         * cli/cli-script.c (script_from_file): Adjust.
9282
9283 2019-02-19  Tom Tromey  <tromey@adacore.com>
9284
9285         * ravenscar-thread.c
9286         (ravenscar_thread_target::update_thread_list): Don't call
9287         ada_build_task_list.
9288         * ada-lang.h (ada_build_task_list): Don't declare.
9289         * ada-tasks.c (struct ada_tasks_inferior_data)
9290         <task_list_valid_p>: Now bool.
9291         (read_known_tasks, ada_task_list_changed)
9292         (ada_tasks_invalidate_inferior_data): Update.
9293         (read_known_tasks_array): Return bool.
9294         (read_known_tasks_list): Likewise.
9295         (read_known_tasks): Return void.
9296         (ada_build_task_list): Now static.
9297
9298 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9299
9300         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9301         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9302
9303 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9304
9305         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9306         variant for ada_tasks_pspace_data_handle and
9307         ada_tasks_inferior_data_handle.
9308         (ada_tasks_pspace_data_cleanup): New function.
9309         (ada_tasks_inferior_data_cleanup): New function.
9310
9311 2019-02-17  Tom Tromey  <tom@tromey.com>
9312
9313         * macrotab.h (macro_source_fullname): Return a std::string.
9314         * macrotab.c (macro_include, check_for_redefinition)
9315         (macro_undef, macro_lookup_definition, foreach_macro)
9316         (foreach_macro_in_scope): Update.
9317         (macro_source_fullname): Return a std::string.
9318         * macrocmd.c (show_pp_source_pos): Update.
9319
9320 2019-02-17  Tom Tromey  <tom@tromey.com>
9321
9322         * macrocmd.c (show_pp_source_pos): Style the file names.
9323
9324 2019-02-17  Tom Tromey  <tom@tromey.com>
9325
9326         PR tui/24197:
9327         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9328
9329 2019-02-17  Tom Tromey  <tom@tromey.com>
9330
9331         * ada-lang.c (user_select_syms): Use filtered printing.
9332         * utils.c (wrap_style): New global.
9333         (desired_style): Remove.
9334         (emit_style_escape): Add stream parameter.
9335         (set_output_style, reset_terminal_style, prompt_for_continue):
9336         Update.
9337         (flush_wrap_buffer): Only flush gdb_stdout.
9338         (wrap_here): Set wrap_style.
9339         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9340         treat escape sequences as a character.  Change when wrap buffer is
9341         flushed.
9342         (fputs_styled): Do not set the output style when the default is
9343         requested.
9344         * ui-style.h (struct ui_file_style) <is_default>: New method.
9345         * source.c (print_source_lines_base): Emit escape sequences in one
9346         piece.
9347
9348 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9349
9350         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9351         integers and enumeration types.
9352
9353 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9354
9355         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9356         instead of lookup_symbol_in_language
9357         (do_exact_match): New function.
9358         (ada_get_symbol_name_matcher): Return do_exact_match when
9359         doing a verbatim match.
9360
9361 2019-02-15  Tom Tromey  <tromey@adacore.com>
9362
9363         * ravenscar-thread.c (ravenscar_thread_target::resume)
9364         (ravenscar_thread_target::wait): Special case wildcard requests.
9365
9366 2019-02-15  Tom Tromey  <tromey@adacore.com>
9367
9368         * ravenscar-thread.c (base_ptid): Remove.
9369         (struct ravenscar_thread_target) <close>: New method.
9370         <m_base_ptid>: New member.
9371         <update_inferior_ptid, active_task, task_is_currently_active,
9372         runtime_initialized>: Declare methods.
9373         <ravenscar_thread_target>: Add constructor.
9374         (ravenscar_thread_target::task_is_currently_active)
9375         (ravenscar_thread_target::update_inferior_ptid)
9376         (ravenscar_runtime_initialized): Rename.  Now methods.
9377         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9378         (ravenscar_thread_target::update_thread_list): Update.
9379         (ravenscar_thread_target::active_task): Now method.
9380         (ravenscar_thread_target::store_registers)
9381         (ravenscar_thread_target::prepare_to_store)
9382         (ravenscar_thread_target::prepare_to_store)
9383         (ravenscar_thread_target::mourn_inferior): Update.
9384         (ravenscar_inferior_created): Use "new" to create target.
9385         (ravenscar_thread_target::get_ada_task_ptid): Update.
9386         (_initialize_ravenscar): Don't initialize base_ptid.
9387         (ravenscar_ops): Remove global.
9388
9389 2019-02-15  Tom Tromey  <tromey@adacore.com>
9390
9391         * target.h (push_target): Declare new overload.
9392         * target.c (push_target): New overload, taking an rvalue reference.
9393         * remote.c (remote_target::open_1): Use push_target overload.
9394         * corelow.c (core_target_open): Use push_target overload.
9395
9396 2019-02-15  Tom Tromey  <tromey@adacore.com>
9397
9398         * ravenscar-thread.c (is_ravenscar_task)
9399         (ravenscar_task_is_currently_active): Return bool.
9400         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9401         (_initialize_ravenscar): Remove "(void)".
9402         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9403         Return bool.
9404
9405 2019-02-15  Tom Tromey  <tromey@adacore.com>
9406
9407         * ravenscar-thread.c (ravenscar_runtime_initializer)
9408         (has_ravenscar_runtime, get_running_thread_id)
9409         (ravenscar_thread_target::resume): Fix indentation.
9410
9411 2019-02-15  Tom Tromey  <tromey@adacore.com>
9412
9413         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9414         from ravenscar_arch_ops.
9415         (sparc_ravenscar_ops::fetch_registers)
9416         (sparc_ravenscar_ops::store_registers): Now methods.
9417         (sparc_ravenscar_prepare_to_store): Remove.
9418         (sparc_ravenscar_ops): Redefine.
9419         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9420         methods and destructor.  Remove members.
9421         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9422         (ravenscar_thread_target::store_registers)
9423         (ravenscar_thread_target::prepare_to_store): Update.
9424         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9425         Remove.
9426         (struct ppc_ravenscar_powerpc_ops): Derive from
9427         ravenscar_arch_ops.
9428         (ppc_ravenscar_powerpc_ops::fetch_registers)
9429         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9430         (ppc_ravenscar_powerpc_ops): Redefine.
9431         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9432         (ppc_ravenscar_e500_ops::fetch_registers)
9433         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9434         (ppc_ravenscar_e500_ops): Redefine.
9435         * aarch64-ravenscar-thread.c
9436         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9437         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9438         (aarch64_ravenscar_fetch_registers)
9439         (aarch64_ravenscar_store_registers): Now methods.
9440         (aarch64_ravenscar_ops): Redefine.
9441
9442 2019-02-15  Tom Tromey  <tromey@adacore.com>
9443
9444         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9445         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9446         (ravenscar_thread_target::stopped_by_watchpoint)
9447         (ravenscar_thread_target::stopped_data_address)
9448         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9449
9450 2019-02-15  Tom Tromey  <tromey@adacore.com>
9451
9452         * ravenscar-thread.c: Fix some typos.
9453
9454 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9455             Tom Tromey  <tromey@adacore.com>
9456
9457         * ada-lang.c (ada_exception_sal): Change addr_string to a
9458         std::string.
9459         (create_ada_exception_catchpoint): Update.
9460
9461 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9462             Tom Tromey  <tromey@adacore.com>
9463
9464         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9465         (bp_location_ops): Remove.
9466         (base_breakpoint_allocate_location): Update.
9467         (free_bp_location): Update.
9468         * ada-lang.c (class ada_catchpoint_location)
9469         <ada_catchpoint_location>: Remove ops parameter.
9470         (ada_catchpoint_location_dtor): Remove.
9471         (ada_catchpoint_location_ops): Remove.
9472         (allocate_location_exception): Update.
9473         * breakpoint.h (struct bp_location_ops): Remove.
9474         (class bp_location) <bp_location>: Remove bp_location_ops
9475         parameter.
9476         <~bp_location>: Add destructor.
9477         <ops>: Remove.
9478
9479 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9480             Pedro Alves  <palves@redhat.com>
9481
9482         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9483         'PATH_MAX'.
9484
9485 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9486             Samuel Thibault  <samuel.thibault@gnu.org>
9487             Thomas Schwinge  <thomas@codesourcery.com>
9488
9489         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9490         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9491
9492 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9493
9494         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9495         (check_empty): Use "const char *".
9496
9497         * gnu-nat.c (gnu_nat_target::detach): Instead of
9498         'detach_inferior (pid)' call
9499         'detach_inferior (find_inferior_pid (pid))'.
9500
9501         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9502         'nat/fork-inferior.o'.
9503         * gnu-nat.c: #include "nat/fork-inferior.h".
9504
9505         * gnu-nat.c (gnu_nat_target::detach): Instead of
9506         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9507         * gnu-nat.h: #include "inf-child.h".
9508         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9509         'i386_gnu_nat_target::fetch_registers'.
9510         (gnu_store_registers): Rename/move to
9511         'i386_gnu_nat_target::store_registers'.
9512
9513         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9514         * gnu-nat.h (mach_thread_info): New function.
9515         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9516
9517         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9518
9519 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9520
9521         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9522
9523 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9524
9525         * windows-nat.c (windows_add_thread): Add new parameter
9526         "main_thread_p" with default value set to false.  Update
9527         function documentation as well as all callers.
9528         (windows_delete_thread): Likewise.
9529         (fake_create_process): Update call to windows_add_thread.
9530         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9531         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9532         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9533         call to windows_delete_thread.
9534
9535 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9536
9537         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9538
9539 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9540
9541         * symfile.c (find_separate_debug_file): Use canonical path of
9542         sysroot with child_path instead of gdb_sysroot if it is valid.
9543
9544 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9545
9546         * symfile.c (find_separate_debug_file): Use child_path to
9547         determine if an object file is under a sysroot.
9548
9549 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9550
9551         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9552         unittests/child-path-selftests.c.
9553         * common/pathstuff.c (child_path): New function.
9554         * common/pathstuff.h (child_path): New prototype.
9555         * unittests/child-path-selftests.c: New file.
9556
9557 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9558
9559         * symfile.c (find_separate_debug_file): Look for separate debug
9560         files in debug directories under the sysroot.
9561
9562 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9563
9564         * symtab.h (struct minimal_symbol data_p): New const method.
9565         (struct minimal_symbol text_p): Likewise.
9566         * symtab.c (output_source_filename): Use file name style
9567         to print file name.
9568         (print_symbol_info): Likewise.
9569         (print_msymbol_info): Use address style to print addresses.
9570         Use function name style to print executable text symbols.
9571         (expand_symtab_containing_pc): Use data_p.
9572         (find_pc_sect_compunit_symtab): Likewise.
9573
9574 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9575
9576         * breakpoint.c (describe_other_breakpoints): Use address style
9577         to print addresses.
9578         (say_where): Likewise.
9579
9580 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9581
9582         * ada-typeprint.c (print_func_type): Print function name
9583         style to print function name.
9584         * c-typeprint.c (c_print_type_1): Likewise.
9585
9586 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9587
9588         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9589         for execve.
9590
9591 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9592
9593         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9594         type_stack.
9595
9596 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9597
9598         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9599         TYPE_CODE_REF types.
9600
9601 2019-02-08  Jim Wilson  <jimw@sifive.com>
9602
9603         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9604         (riscv_linux_fregset): New.
9605         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9606
9607 2019-02-07  Tom Tromey  <tom@tromey.com>
9608
9609         * thread.c (thread_cancel_execution_command): Update.
9610         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9611         methods.
9612         (struct thread_fsm_ops): Remove.
9613         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9614         (thread_fsm_should_stop, thread_fsm_return_value)
9615         (thread_fsm_set_finished, thread_fsm_finished_p)
9616         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9617         Don't declare.
9618         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9619         * infrun.c (clear_proceed_status_thread)
9620         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9621         (print_stop_event): Update.
9622         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9623         Add constructor.
9624         (step_command_fsm_ops): Remove.
9625         (new_step_command_fsm): Remove.
9626         (step_1): Update.
9627         (step_command_fsm::should_stop): Rename from
9628         step_command_fsm_should_stop.
9629         (step_command_fsm::clean_up): Rename from
9630         step_command_fsm_clean_up.
9631         (step_command_fsm::do_async_reply_reason): Rename from
9632         step_command_fsm_async_reply_reason.
9633         (struct until_next_fsm): Inherit from thread_fsm.  Add
9634         constructor.
9635         (until_next_fsm_ops): Remove.
9636         (new_until_next_fsm): Remove.
9637         (until_next_fsm::should_stop): Rename from
9638         until_next_fsm_should_stop.
9639         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9640         (until_next_fsm::do_async_reply_reason): Rename from
9641         until_next_fsm_async_reply_reason.
9642         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9643         constructor.  Change type of breakpoint.
9644         (finish_command_fsm_ops): Remove.
9645         (new_finish_command_fsm): Remove.
9646         (finish_command_fsm::should_stop): Rename from
9647         finish_command_fsm_should_stop.
9648         (finish_command_fsm::clean_up): Rename from
9649         finish_command_fsm_clean_up.
9650         (finish_command_fsm::return_value): Rename from
9651         finish_command_fsm_return_value.
9652         (finish_command_fsm::do_async_reply_reason): Rename from
9653         finish_command_fsm_async_reply_reason.
9654         (finish_command): Update.
9655         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9656         Add constructor.
9657         (call_thread_fsm_ops): Remove.
9658         (call_thread_fsm::call_thread_fsm): Rename from
9659         new_call_thread_fsm.
9660         (call_thread_fsm::should_stop): Rename from
9661         call_thread_fsm_should_stop.
9662         (call_thread_fsm::should_notify_stop): Rename from
9663         call_thread_fsm_should_notify_stop.
9664         (run_inferior_call, call_function_by_hand_dummy): Update.
9665         * cli/cli-interp.c (should_print_stop_to_console): Update.
9666         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9667         Add constructor.  Change type of location_breakpoint,
9668         caller_breakpoint.
9669         (until_break_fsm_ops): Remove.
9670         (new_until_break_fsm): Remove.
9671         (until_break_fsm::should_stop): Rename from
9672         until_break_fsm_should_stop.
9673         (until_break_fsm::clean_up): Rename from
9674         until_break_fsm_clean_up.
9675         (until_break_fsm::do_async_reply_reason): Rename from
9676         until_break_fsm_async_reply_reason.
9677         (until_break_command): Update.
9678         * thread-fsm.c: Remove.
9679         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9680
9681 2019-02-07  Tom Tromey  <tom@tromey.com>
9682
9683         * yy-remap.h: Add include guard.
9684         * xtensa-tdep.h: Add include guard.
9685         * xcoffread.h: Rename include guard.
9686         * varobj-iter.h: Add include guard.
9687         * tui/tui.h: Rename include guard.
9688         * tui/tui-winsource.h: Rename include guard.
9689         * tui/tui-wingeneral.h: Rename include guard.
9690         * tui/tui-windata.h: Rename include guard.
9691         * tui/tui-win.h: Rename include guard.
9692         * tui/tui-stack.h: Rename include guard.
9693         * tui/tui-source.h: Rename include guard.
9694         * tui/tui-regs.h: Rename include guard.
9695         * tui/tui-out.h: Rename include guard.
9696         * tui/tui-layout.h: Rename include guard.
9697         * tui/tui-io.h: Rename include guard.
9698         * tui/tui-hooks.h: Rename include guard.
9699         * tui/tui-file.h: Rename include guard.
9700         * tui/tui-disasm.h: Rename include guard.
9701         * tui/tui-data.h: Rename include guard.
9702         * tui/tui-command.h: Rename include guard.
9703         * tic6x-tdep.h: Add include guard.
9704         * target/waitstatus.h: Rename include guard.
9705         * target/wait.h: Rename include guard.
9706         * target/target.h: Rename include guard.
9707         * target/resume.h: Rename include guard.
9708         * target-float.h: Rename include guard.
9709         * stabsread.h: Add include guard.
9710         * rs6000-tdep.h: Add include guard.
9711         * riscv-fbsd-tdep.h: Add include guard.
9712         * regformats/regdef.h: Rename include guard.
9713         * record.h: Rename include guard.
9714         * python/python.h: Rename include guard.
9715         * python/python-internal.h: Rename include guard.
9716         * python/py-stopevent.h: Rename include guard.
9717         * python/py-ref.h: Rename include guard.
9718         * python/py-record.h: Rename include guard.
9719         * python/py-record-full.h: Rename include guard.
9720         * python/py-record-btrace.h: Rename include guard.
9721         * python/py-instruction.h: Rename include guard.
9722         * python/py-events.h: Rename include guard.
9723         * python/py-event.h: Rename include guard.
9724         * procfs.h: Add include guard.
9725         * proc-utils.h: Add include guard.
9726         * p-lang.h: Add include guard.
9727         * or1k-tdep.h: Rename include guard.
9728         * observable.h: Rename include guard.
9729         * nto-tdep.h: Rename include guard.
9730         * nat/x86-linux.h: Rename include guard.
9731         * nat/x86-linux-dregs.h: Rename include guard.
9732         * nat/x86-gcc-cpuid.h: Add include guard.
9733         * nat/x86-dregs.h: Rename include guard.
9734         * nat/x86-cpuid.h: Rename include guard.
9735         * nat/ppc-linux.h: Rename include guard.
9736         * nat/mips-linux-watch.h: Rename include guard.
9737         * nat/linux-waitpid.h: Rename include guard.
9738         * nat/linux-ptrace.h: Rename include guard.
9739         * nat/linux-procfs.h: Rename include guard.
9740         * nat/linux-osdata.h: Rename include guard.
9741         * nat/linux-nat.h: Rename include guard.
9742         * nat/linux-namespaces.h: Rename include guard.
9743         * nat/linux-btrace.h: Rename include guard.
9744         * nat/glibc_thread_db.h: Rename include guard.
9745         * nat/gdb_thread_db.h: Rename include guard.
9746         * nat/gdb_ptrace.h: Rename include guard.
9747         * nat/fork-inferior.h: Rename include guard.
9748         * nat/amd64-linux-siginfo.h: Rename include guard.
9749         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9750         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9751         * nat/aarch64-linux.h: Rename include guard.
9752         * nat/aarch64-linux-hw-point.h: Rename include guard.
9753         * mn10300-tdep.h: Add include guard.
9754         * mips-linux-tdep.h: Add include guard.
9755         * mi/mi-parse.h: Rename include guard.
9756         * mi/mi-out.h: Rename include guard.
9757         * mi/mi-main.h: Rename include guard.
9758         * mi/mi-interp.h: Rename include guard.
9759         * mi/mi-getopt.h: Rename include guard.
9760         * mi/mi-console.h: Rename include guard.
9761         * mi/mi-common.h: Rename include guard.
9762         * mi/mi-cmds.h: Rename include guard.
9763         * mi/mi-cmd-break.h: Rename include guard.
9764         * m2-lang.h: Add include guard.
9765         * location.h: Rename include guard.
9766         * linux-record.h: Rename include guard.
9767         * linux-nat.h: Add include guard.
9768         * linux-fork.h: Add include guard.
9769         * i386-darwin-tdep.h: Rename include guard.
9770         * hppa-linux-offsets.h: Add include guard.
9771         * guile/guile.h: Rename include guard.
9772         * guile/guile-internal.h: Rename include guard.
9773         * gnu-nat.h: Rename include guard.
9774         * gdb-stabs.h: Rename include guard.
9775         * frv-tdep.h: Add include guard.
9776         * f-lang.h: Add include guard.
9777         * event-loop.h: Add include guard.
9778         * darwin-nat.h: Rename include guard.
9779         * cp-abi.h: Rename include guard.
9780         * config/sparc/nm-sol2.h: Rename include guard.
9781         * config/nm-nto.h: Rename include guard.
9782         * config/nm-linux.h: Add include guard.
9783         * config/i386/nm-i386gnu.h: Rename include guard.
9784         * config/djgpp/nl_types.h: Rename include guard.
9785         * config/djgpp/langinfo.h: Rename include guard.
9786         * compile/gcc-cp-plugin.h: Add include guard.
9787         * compile/gcc-c-plugin.h: Add include guard.
9788         * compile/compile.h: Rename include guard.
9789         * compile/compile-object-run.h: Rename include guard.
9790         * compile/compile-object-load.h: Rename include guard.
9791         * compile/compile-internal.h: Rename include guard.
9792         * compile/compile-cplus.h: Rename include guard.
9793         * compile/compile-c.h: Rename include guard.
9794         * common/xml-utils.h: Rename include guard.
9795         * common/x86-xstate.h: Rename include guard.
9796         * common/version.h: Rename include guard.
9797         * common/vec.h: Rename include guard.
9798         * common/tdesc.h: Rename include guard.
9799         * common/selftest.h: Rename include guard.
9800         * common/scoped_restore.h: Rename include guard.
9801         * common/scoped_mmap.h: Rename include guard.
9802         * common/scoped_fd.h: Rename include guard.
9803         * common/safe-iterator.h: Rename include guard.
9804         * common/run-time-clock.h: Rename include guard.
9805         * common/refcounted-object.h: Rename include guard.
9806         * common/queue.h: Rename include guard.
9807         * common/ptid.h: Rename include guard.
9808         * common/print-utils.h: Rename include guard.
9809         * common/preprocessor.h: Rename include guard.
9810         * common/pathstuff.h: Rename include guard.
9811         * common/observable.h: Rename include guard.
9812         * common/netstuff.h: Rename include guard.
9813         * common/job-control.h: Rename include guard.
9814         * common/host-defs.h: Rename include guard.
9815         * common/gdb_wait.h: Rename include guard.
9816         * common/gdb_vecs.h: Rename include guard.
9817         * common/gdb_unlinker.h: Rename include guard.
9818         * common/gdb_unique_ptr.h: Rename include guard.
9819         * common/gdb_tilde_expand.h: Rename include guard.
9820         * common/gdb_sys_time.h: Rename include guard.
9821         * common/gdb_string_view.h: Rename include guard.
9822         * common/gdb_splay_tree.h: Rename include guard.
9823         * common/gdb_setjmp.h: Rename include guard.
9824         * common/gdb_ref_ptr.h: Rename include guard.
9825         * common/gdb_optional.h: Rename include guard.
9826         * common/gdb_locale.h: Rename include guard.
9827         * common/gdb_assert.h: Rename include guard.
9828         * common/filtered-iterator.h: Rename include guard.
9829         * common/filestuff.h: Rename include guard.
9830         * common/fileio.h: Rename include guard.
9831         * common/environ.h: Rename include guard.
9832         * common/common-utils.h: Rename include guard.
9833         * common/common-types.h: Rename include guard.
9834         * common/common-regcache.h: Rename include guard.
9835         * common/common-inferior.h: Rename include guard.
9836         * common/common-gdbthread.h: Rename include guard.
9837         * common/common-exceptions.h: Rename include guard.
9838         * common/common-defs.h: Rename include guard.
9839         * common/common-debug.h: Rename include guard.
9840         * common/cleanups.h: Rename include guard.
9841         * common/buffer.h: Rename include guard.
9842         * common/btrace-common.h: Rename include guard.
9843         * common/break-common.h: Rename include guard.
9844         * cli/cli-utils.h: Rename include guard.
9845         * cli/cli-style.h: Rename include guard.
9846         * cli/cli-setshow.h: Rename include guard.
9847         * cli/cli-script.h: Rename include guard.
9848         * cli/cli-interp.h: Rename include guard.
9849         * cli/cli-decode.h: Rename include guard.
9850         * cli/cli-cmds.h: Rename include guard.
9851         * charset-list.h: Add include guard.
9852         * buildsym-legacy.h: Rename include guard.
9853         * bfin-tdep.h: Add include guard.
9854         * ax.h: Rename include guard.
9855         * arm-linux-tdep.h: Add include guard.
9856         * arm-fbsd-tdep.h: Add include guard.
9857         * arch/xtensa.h: Rename include guard.
9858         * arch/tic6x.h: Add include guard.
9859         * arch/i386.h: Add include guard.
9860         * arch/arm.h: Rename include guard.
9861         * arch/arm-linux.h: Rename include guard.
9862         * arch/arm-get-next-pcs.h: Rename include guard.
9863         * arch/amd64.h: Add include guard.
9864         * arch/aarch64-insn.h: Rename include guard.
9865         * arch-utils.h: Rename include guard.
9866         * annotate.h: Add include guard.
9867         * amd64-darwin-tdep.h: Rename include guard.
9868         * aarch64-linux-tdep.h: Add include guard.
9869         * aarch64-fbsd-tdep.h: Add include guard.
9870         * aarch32-linux-nat.h: Add include guard.
9871
9872 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9873
9874         * macrotab.c (macro_define_internal): New function that
9875         factorizes macro_define_object_internal and macro_define_function
9876         code.
9877         (macro_define_object_internal): Use macro_define_internal.
9878         (macro_define_function): Likewise.
9879
9880 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9881
9882         * macrocmd.c (extract_identifier): Return
9883         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9884         callers.
9885
9886 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9887
9888         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9889
9890 2019-02-05  Tom Tromey  <tom@tromey.com>
9891
9892         * target.c (target_stack::unpush): Move assertion earlier.
9893
9894 2019-01-30  Tom Tromey  <tom@tromey.com>
9895
9896         PR python/23615:
9897         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9898         (gdbpy_parse_and_eval): Likewise.
9899         * python/python-internal.h (gdbpy_allow_threads): New class.
9900
9901 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9902
9903         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9904         (aarch64_fbsd_fpregmap): Move earlier.
9905         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9906         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9907         instead of individual calls to trad_frame_set_reg_addr.
9908         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9909         earlier.
9910         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9911         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9912         instead of individual calls to trad_frame_set_reg_addr.
9913
9914 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9915
9916         * CONTRIBUTE: Replace contribution list with wiki link.
9917
9918 2019-01-25  Tom Tromey  <tom@tromey.com>
9919
9920         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9921
9922 2019-01-25  Tom Tromey  <tom@tromey.com>
9923
9924         * xtensa-linux-nat.c: Fix common/ includes.
9925         * xml-support.h: Fix common/ includes.
9926         * xml-support.c: Fix common/ includes.
9927         * x86-linux-nat.c: Fix common/ includes.
9928         * windows-nat.c: Fix common/ includes.
9929         * varobj.h: Fix common/ includes.
9930         * varobj.c: Fix common/ includes.
9931         * value.c: Fix common/ includes.
9932         * valops.c: Fix common/ includes.
9933         * utils.c: Fix common/ includes.
9934         * unittests/xml-utils-selftests.c: Fix common/ includes.
9935         * unittests/utils-selftests.c: Fix common/ includes.
9936         * unittests/unpack-selftests.c: Fix common/ includes.
9937         * unittests/tracepoint-selftests.c: Fix common/ includes.
9938         * unittests/style-selftests.c: Fix common/ includes.
9939         * unittests/string_view-selftests.c: Fix common/ includes.
9940         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9941         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9942         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9943         * unittests/rsp-low-selftests.c: Fix common/ includes.
9944         * unittests/parse-connection-spec-selftests.c: Fix common/
9945         includes.
9946         * unittests/optional-selftests.c: Fix common/ includes.
9947         * unittests/offset-type-selftests.c: Fix common/ includes.
9948         * unittests/observable-selftests.c: Fix common/ includes.
9949         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9950         * unittests/memrange-selftests.c: Fix common/ includes.
9951         * unittests/memory-map-selftests.c: Fix common/ includes.
9952         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9953         * unittests/function-view-selftests.c: Fix common/ includes.
9954         * unittests/environ-selftests.c: Fix common/ includes.
9955         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9956         * unittests/common-utils-selftests.c: Fix common/ includes.
9957         * unittests/cli-utils-selftests.c: Fix common/ includes.
9958         * unittests/array-view-selftests.c: Fix common/ includes.
9959         * ui-file.c: Fix common/ includes.
9960         * tui/tui-io.c: Fix common/ includes.
9961         * tracepoint.h: Fix common/ includes.
9962         * tracepoint.c: Fix common/ includes.
9963         * tracefile-tfile.c: Fix common/ includes.
9964         * top.h: Fix common/ includes.
9965         * top.c: Fix common/ includes.
9966         * thread.c: Fix common/ includes.
9967         * target/waitstatus.h: Fix common/ includes.
9968         * target/waitstatus.c: Fix common/ includes.
9969         * target.h: Fix common/ includes.
9970         * target.c: Fix common/ includes.
9971         * target-memory.c: Fix common/ includes.
9972         * target-descriptions.c: Fix common/ includes.
9973         * symtab.h: Fix common/ includes.
9974         * symfile.c: Fix common/ includes.
9975         * stap-probe.c: Fix common/ includes.
9976         * spu-linux-nat.c: Fix common/ includes.
9977         * sparc-nat.c: Fix common/ includes.
9978         * source.c: Fix common/ includes.
9979         * solib.c: Fix common/ includes.
9980         * solib-target.c: Fix common/ includes.
9981         * ser-unix.c: Fix common/ includes.
9982         * ser-tcp.c: Fix common/ includes.
9983         * ser-pipe.c: Fix common/ includes.
9984         * ser-base.c: Fix common/ includes.
9985         * selftest-arch.c: Fix common/ includes.
9986         * s12z-tdep.c: Fix common/ includes.
9987         * rust-exp.y: Fix common/ includes.
9988         * rs6000-aix-tdep.c: Fix common/ includes.
9989         * riscv-tdep.c: Fix common/ includes.
9990         * remote.c: Fix common/ includes.
9991         * remote-notif.h: Fix common/ includes.
9992         * remote-fileio.h: Fix common/ includes.
9993         * remote-fileio.c: Fix common/ includes.
9994         * regcache.h: Fix common/ includes.
9995         * regcache.c: Fix common/ includes.
9996         * record-btrace.c: Fix common/ includes.
9997         * python/python.c: Fix common/ includes.
9998         * python/py-type.c: Fix common/ includes.
9999         * python/py-inferior.c: Fix common/ includes.
10000         * progspace.h: Fix common/ includes.
10001         * producer.c: Fix common/ includes.
10002         * procfs.c: Fix common/ includes.
10003         * proc-api.c: Fix common/ includes.
10004         * printcmd.c: Fix common/ includes.
10005         * ppc-linux-nat.c: Fix common/ includes.
10006         * parser-defs.h: Fix common/ includes.
10007         * osdata.c: Fix common/ includes.
10008         * obsd-nat.c: Fix common/ includes.
10009         * nat/x86-linux.c: Fix common/ includes.
10010         * nat/x86-linux-dregs.c: Fix common/ includes.
10011         * nat/x86-dregs.h: Fix common/ includes.
10012         * nat/x86-dregs.c: Fix common/ includes.
10013         * nat/ppc-linux.c: Fix common/ includes.
10014         * nat/mips-linux-watch.h: Fix common/ includes.
10015         * nat/mips-linux-watch.c: Fix common/ includes.
10016         * nat/linux-waitpid.c: Fix common/ includes.
10017         * nat/linux-ptrace.h: Fix common/ includes.
10018         * nat/linux-ptrace.c: Fix common/ includes.
10019         * nat/linux-procfs.c: Fix common/ includes.
10020         * nat/linux-personality.c: Fix common/ includes.
10021         * nat/linux-osdata.c: Fix common/ includes.
10022         * nat/linux-namespaces.c: Fix common/ includes.
10023         * nat/linux-btrace.h: Fix common/ includes.
10024         * nat/linux-btrace.c: Fix common/ includes.
10025         * nat/fork-inferior.c: Fix common/ includes.
10026         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10027         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10028         * nat/aarch64-linux.c: Fix common/ includes.
10029         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10030         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10031         * namespace.h: Fix common/ includes.
10032         * mips-linux-tdep.c: Fix common/ includes.
10033         * minsyms.c: Fix common/ includes.
10034         * mi/mi-parse.h: Fix common/ includes.
10035         * mi/mi-main.c: Fix common/ includes.
10036         * mi/mi-cmd-env.c: Fix common/ includes.
10037         * memrange.h: Fix common/ includes.
10038         * memattr.c: Fix common/ includes.
10039         * maint.h: Fix common/ includes.
10040         * maint.c: Fix common/ includes.
10041         * main.c: Fix common/ includes.
10042         * machoread.c: Fix common/ includes.
10043         * location.c: Fix common/ includes.
10044         * linux-thread-db.c: Fix common/ includes.
10045         * linux-nat.c: Fix common/ includes.
10046         * linux-fork.c: Fix common/ includes.
10047         * inline-frame.c: Fix common/ includes.
10048         * infrun.c: Fix common/ includes.
10049         * inflow.c: Fix common/ includes.
10050         * inferior.h: Fix common/ includes.
10051         * inferior.c: Fix common/ includes.
10052         * infcmd.c: Fix common/ includes.
10053         * inf-ptrace.c: Fix common/ includes.
10054         * inf-child.c: Fix common/ includes.
10055         * ia64-linux-nat.c: Fix common/ includes.
10056         * i387-tdep.c: Fix common/ includes.
10057         * i386-tdep.c: Fix common/ includes.
10058         * i386-linux-tdep.c: Fix common/ includes.
10059         * i386-linux-nat.c: Fix common/ includes.
10060         * i386-go32-tdep.c: Fix common/ includes.
10061         * i386-fbsd-tdep.c: Fix common/ includes.
10062         * i386-fbsd-nat.c: Fix common/ includes.
10063         * guile/scm-type.c: Fix common/ includes.
10064         * guile/guile.c: Fix common/ includes.
10065         * go32-nat.c: Fix common/ includes.
10066         * gnu-nat.c: Fix common/ includes.
10067         * gdbthread.h: Fix common/ includes.
10068         * gdbarch-selftests.c: Fix common/ includes.
10069         * gdb_usleep.c: Fix common/ includes.
10070         * gdb_select.h: Fix common/ includes.
10071         * gdb_bfd.c: Fix common/ includes.
10072         * gcore.c: Fix common/ includes.
10073         * fork-child.c: Fix common/ includes.
10074         * findvar.c: Fix common/ includes.
10075         * fbsd-nat.c: Fix common/ includes.
10076         * event-top.c: Fix common/ includes.
10077         * event-loop.c: Fix common/ includes.
10078         * dwarf2read.c: Fix common/ includes.
10079         * dwarf2loc.c: Fix common/ includes.
10080         * dwarf2-frame.c: Fix common/ includes.
10081         * dwarf-index-cache.c: Fix common/ includes.
10082         * dtrace-probe.c: Fix common/ includes.
10083         * disasm-selftests.c: Fix common/ includes.
10084         * defs.h: Fix common/ includes.
10085         * csky-tdep.c: Fix common/ includes.
10086         * cp-valprint.c: Fix common/ includes.
10087         * cp-support.h: Fix common/ includes.
10088         * cp-support.c: Fix common/ includes.
10089         * corelow.c: Fix common/ includes.
10090         * completer.h: Fix common/ includes.
10091         * completer.c: Fix common/ includes.
10092         * compile/compile.c: Fix common/ includes.
10093         * compile/compile-loc2c.c: Fix common/ includes.
10094         * compile/compile-cplus-types.c: Fix common/ includes.
10095         * compile/compile-cplus-symbols.c: Fix common/ includes.
10096         * command.h: Fix common/ includes.
10097         * cli/cli-dump.c: Fix common/ includes.
10098         * cli/cli-cmds.c: Fix common/ includes.
10099         * charset.c: Fix common/ includes.
10100         * build-id.c: Fix common/ includes.
10101         * btrace.h: Fix common/ includes.
10102         * btrace.c: Fix common/ includes.
10103         * breakpoint.h: Fix common/ includes.
10104         * breakpoint.c: Fix common/ includes.
10105         * ax.h:
10106         (enum agent_op): Fix common/ includes.
10107         * ax-general.c (struct aop_map): Fix common/ includes.
10108         * ax-gdb.c: Fix common/ includes.
10109         * auxv.c: Fix common/ includes.
10110         * auto-load.c: Fix common/ includes.
10111         * arm-tdep.c: Fix common/ includes.
10112         * arch/riscv.c: Fix common/ includes.
10113         * arch/ppc-linux-common.c: Fix common/ includes.
10114         * arch/i386.c: Fix common/ includes.
10115         * arch/arm.c: Fix common/ includes.
10116         * arch/arm-linux.c: Fix common/ includes.
10117         * arch/arm-get-next-pcs.c: Fix common/ includes.
10118         * arch/amd64.c: Fix common/ includes.
10119         * arch/aarch64.c: Fix common/ includes.
10120         * arch/aarch64-insn.c: Fix common/ includes.
10121         * arch-utils.c: Fix common/ includes.
10122         * amd64-windows-tdep.c: Fix common/ includes.
10123         * amd64-tdep.c: Fix common/ includes.
10124         * amd64-sol2-tdep.c: Fix common/ includes.
10125         * amd64-obsd-tdep.c: Fix common/ includes.
10126         * amd64-nbsd-tdep.c: Fix common/ includes.
10127         * amd64-linux-tdep.c: Fix common/ includes.
10128         * amd64-linux-nat.c: Fix common/ includes.
10129         * amd64-fbsd-tdep.c: Fix common/ includes.
10130         * amd64-fbsd-nat.c: Fix common/ includes.
10131         * amd64-dicos-tdep.c: Fix common/ includes.
10132         * amd64-darwin-tdep.c: Fix common/ includes.
10133         * agent.c: Fix common/ includes.
10134         * ada-lang.h: Fix common/ includes.
10135         * ada-lang.c: Fix common/ includes.
10136         * aarch64-tdep.c: Fix common/ includes.
10137
10138 2019-01-25  Tom Tromey  <tom@tromey.com>
10139
10140         * common/create-version.sh: Use common/version.h.
10141
10142 2019-01-24  Pedro Alves  <palves@redhat.com>
10143
10144         * infrun.c (signal_stop, signal_print, signal_program)
10145         (signal_catch, signal_pass): Now arrays instead of pointers.
10146         (update_signals_program_target, do_target_resume)
10147         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10148         * linux-nat.c (linux_nat_target::pass_signals)
10149         (linux_nat_target::create_inferior, linux_nat_target::attach):
10150         Adjust.
10151         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10152         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10153         * procfs.c (procfs_target::pass_signals): Adjust.
10154         * record-full.c (record_full_target::resume): Adjust.
10155         * remote.c (remote_target::pass_signals)
10156         (remote_target::program_signals): Adjust.
10157         * target-debug.h (target_debug_print_signals): Now takes a
10158         gdb::array_view as parameter.  Adjust.
10159         * target.h (target_ops) <pass_signals, program_signals>: Replace
10160         pointer and length parameters with gdb::array_view.
10161         (target_pass_signals, target_program_signals): Likewise.
10162         * target-delegates.c: Regenerate.
10163
10164 2019-01-24  Pedro Alves  <palves@redhat.com>
10165
10166         * common/forward-scope-exit.h
10167         (forward_scope_exit::forward_scope_exit): Pass arguments to
10168         m_bind_function directly, instead of creating a std::bind and
10169         copying that.
10170
10171 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10172
10173         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10174         for static members.
10175         (pass_in_v_vfp_candidate): Likewise.
10176
10177 2019-01-23  Tom Tromey  <tom@tromey.com>
10178             Pedro Alves  <palves@redhat.com>
10179
10180         * regcache.c (class regcache_invalidator): Remove.
10181         (regcache::raw_write): Use make_scope_exit.
10182
10183 2019-01-23  Tom Tromey  <tom@tromey.com>
10184
10185         * ui-out.h (class ui_out_emit_type): Update comment.
10186
10187 2019-01-23  Tom Tromey  <tom@tromey.com>
10188
10189         * infrun.c (fetch_inferior_event): Update comment.
10190
10191 2019-01-23  Tom Tromey  <tom@tromey.com>
10192             Pedro Alves  <palves@redhat.com>
10193
10194         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10195         parameter.
10196         (fetch_inferior_event): Use SCOPE_EXIT.
10197
10198
10199 2019-01-23  Tom Tromey  <tom@tromey.com>
10200             Pedro Alves  <palves@redhat.com>
10201
10202         * infrun.c (disable_thread_events): Delete.
10203         (stop_all_threads): Use SCOPE_EXIT.
10204
10205 2019-01-23  Tom Tromey  <tom@tromey.com>
10206             Pedro Alves  <palves@redhat.com>
10207
10208         * symfile.c: Include forward-scope-exit.h.
10209         (clear_symtab_users_cleanup): Replace forward declaration with
10210         a FORWARD_SCOPE_EXIT.
10211         (syms_from_objfile_1): Use the forward_scope_exit and
10212         gdb::optional instead of cleanup_function.
10213         (reread_symbols): Use the forward_scope_exit instead of
10214         cleanup_function.
10215         (clear_symtab_users_cleanup): Remove function.
10216
10217 2019-01-23  Tom Tromey  <tom@tromey.com>
10218             Pedro Alves  <palves@redhat.com>
10219
10220         * linux-nat.c: Include scope-exit.h.
10221         (cleanup_target_stop): Remove.
10222         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10223         SCOPE_EXIT.
10224
10225 2019-01-23  Tom Tromey  <tom@tromey.com>
10226             Pedro Alves  <palves@redhat.com>
10227
10228         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10229         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10230
10231 2019-01-23  Tom Tromey  <tom@tromey.com>
10232             Andrew Burgess  <andrew.burgess@embecosm.com>
10233             Pedro Alves  <palves@redhat.com>
10234
10235         * infrun.c (fetch_inferior_event): Use scope_exit.
10236         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10237         * top.c (execute_command): Use scope_exit.
10238         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10239         * utils.c (do_bpstat_clear_actions_cleanup)
10240         (make_bpstat_clear_actions_cleanup): Remove.
10241
10242 2019-01-23  Tom Tromey  <tom@tromey.com>
10243             Pedro Alves  <palves@redhat.com>
10244
10245         * infrun.c: Include "common/scope-exit.h"
10246         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10247         (wait_for_inferior): Use SCOPE_EXIT.
10248         (fetch_inferior_event): Use scope_exit.
10249
10250 2019-01-23  Tom Tromey  <tom@tromey.com>
10251             Pedro Alves  <palves@redhat.com>
10252
10253         * breakpoint.c (create_breakpoint): Remove cleanup.
10254
10255 2019-01-23  Tom Tromey  <tom@tromey.com>
10256             Andrew Burgess  <andrew.burgess@embecosm.com>
10257             Pedro Alves  <palves@redhat.com>
10258
10259 2019-01-23  Pedro Alves  <palves@redhat.com>
10260
10261         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10262
10263 2019-01-23  Pedro Alves  <palves@redhat.com>
10264             Andrew Burgess  <andrew.burgess@embecosm.com>
10265
10266         * gdbthread.h: Include "common/forward-scope-exit.h".
10267         (scoped_finish_thread_state): Redefine custom class in terms of
10268         forward_scope_exit.
10269
10270 2019-01-23  Pedro Alves  <palves@redhat.com>
10271             Andrew Burgess  <andrew.burgess@embecosm.com>
10272
10273         * common/forward-scope-exit.h: New file.
10274
10275 2019-01-23  Pedro Alves  <palves@redhat.com>
10276             Andrew Burgess  <andrew.burgess@embecosm.com>
10277             Tom Tromey  <tom@tromey.com>
10278
10279         * common/scope-exit.h: New file.
10280
10281 2019-01-23  Pedro Alves  <palves@redhat.com>
10282
10283         * common/preprocessor.h (ESC): Rename to ...
10284         (ESC_PARENS): ... this.
10285         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10286         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10287
10288 2019-01-23  Tom Tromey  <tom@tromey.com>
10289
10290         * language.h (class scoped_switch_to_sym_language_if_auto):
10291         Initialize m_lang in both cases.
10292
10293 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10294
10295         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10296         with XCNEW.
10297
10298 2019-01-22  Tom Tromey  <tom@tromey.com>
10299
10300         * corelow.c: Do not include sys/file.h.
10301
10302 2019-01-22  Tom Tromey  <tom@tromey.com>
10303
10304         * tui/tui-wingeneral.h: Include gdb_curses.h.
10305
10306 2019-01-22  Tom Tromey  <tom@tromey.com>
10307
10308         * source-cache.h (class source_cache) <get_source_lines,
10309         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10310
10311 2019-01-22  Tom Tromey  <tom@tromey.com>
10312
10313         * remote-fileio.h (struct remote_target): Declare.
10314
10315 2019-01-22  Tom Tromey  <tom@tromey.com>
10316
10317         * python/py-arch.c: Do not include py-ref.h.
10318         * python/py-bpevent.c: Do not include py-ref.h.
10319         * python/py-cmd.c: Do not include py-ref.h.
10320         * python/py-continueevent.c: Do not include py-ref.h.
10321         * python/py-event.h: Do not include py-ref.h.
10322         * python/py-evtregistry.c: Do not include py-ref.h.
10323         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10324         * python/py-frame.c: Do not include py-ref.h.
10325         * python/py-framefilter.c: Do not include py-ref.h.
10326         * python/py-function.c: Do not include py-ref.h.
10327         * python/py-infevents.c: Do not include py-ref.h.
10328         * python/py-linetable.c: Do not include py-ref.h.
10329         * python/py-objfile.c: Do not include py-ref.h.
10330         * python/py-param.c: Do not include py-ref.h.
10331         * python/py-prettyprint.c: Do not include py-ref.h.
10332         * python/py-progspace.c: Do not include py-ref.h.
10333         * python/py-symbol.c: Do not include py-ref.h.
10334         * python/py-symtab.c: Do not include py-ref.h.
10335         * python/py-type.c: Do not include py-ref.h.
10336         * python/py-unwind.c: Do not include py-ref.h.
10337         * python/py-utils.c: Do not include py-ref.h.
10338         * python/py-value.c: Do not include py-ref.h.
10339         * python/py-varobj.c: Do not include py-ref.h.
10340         * python/py-xmethods.c: Do not include py-ref.h.
10341         * python/python.c: Do not include py-ref.h.
10342         * varobj.c: Do not include py-ref.h.
10343
10344 2019-01-22  Tom Tromey  <tom@tromey.com>
10345
10346         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10347         keyword for bcache.
10348
10349 2019-01-22  Tom Tromey  <tom@tromey.com>
10350
10351         * compile/compile-cplus-types.c: Remove a comment by #include.
10352
10353 2019-01-22  Tom Tromey  <tom@tromey.com>
10354
10355         * compile/gcc-c-plugin.h: Include compile-internal.h.
10356
10357 2019-01-22  Tom Tromey  <tom@tromey.com>
10358
10359         * stabsread.c (EXTERN): Do not define.
10360         (symnum, next_symbol_text_func, processing_gcc_compilation)
10361         (within_function, global_sym_chain, global_stabs)
10362         (previous_stab_code, this_object_header_files)
10363         (n_this_object_header_files)
10364         (n_allocated_this_object_header_files): Define.
10365         * stabsread.h (EXTERN): Never define.  Use "extern".
10366
10367 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10368
10369         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10370         history_value.
10371
10372 2019-01-21  Tom Tromey  <tom@tromey.com>
10373
10374         * ui-out.c: Fix includes.
10375         * tui/tui-source.c: Fix includes.
10376         * target.c: Fix includes.
10377         * remote.c: Fix includes.
10378         * regcache.c: Fix includes.
10379         * python/py-block.c: Fix includes.
10380         * printcmd.c: Fix includes.
10381         * or1k-tdep.c: Fix includes.
10382         * mi/mi-main.c: Fix includes.
10383         * m32r-tdep.c: Fix includes.
10384         * csky-tdep.c: Fix includes.
10385         * compile/compile-cplus-types.c: Fix includes.
10386         * cli/cli-interp.c: Fix includes.
10387
10388 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10389
10390         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10391         for padding.
10392
10393 2019-01-16  Tom Tromey  <tom@tromey.com>
10394
10395         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10396         earlier.
10397         (struct objfile) <msymbols_range>: Move from top level.
10398         <msymbols>: New method.
10399         (class objfile_msymbols): Remove.
10400         * symtab.c (default_collect_symbol_completion_matches_break_on):
10401         Update.
10402         * symmisc.c (dump_msymbols): Update.
10403         * stabsread.c (scan_file_globals): Update.
10404         * objc-lang.c (info_selectors_command, info_classes_command)
10405         (find_methods): Update.
10406         * minsyms.c (find_solib_trampoline_target): Update.
10407         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10408         * coffread.c (coff_symfile_read): Update.
10409         * ada-lang.c (ada_lookup_simple_minsym)
10410         (ada_collect_symbol_completion_matches): Update.
10411
10412 2019-01-16  Tom Tromey  <tom@tromey.com>
10413
10414         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10415         type.  Remove no-argument constructor.
10416         <iterator::operator++>: Simplify.
10417         <begin>: Update.
10418         <end>: Use minimal_symbol_count.
10419
10420 2019-01-16  Tom Tromey  <tom@tromey.com>
10421
10422         * objfiles.h (struct objfile) <psymtabs>: New method.
10423         (class objfile_psymtabs): Remove.
10424         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10425         typedef.
10426         <range>: New method.
10427         (require_partial_symbols): Change return type.
10428         * psymtab.c (require_partial_symbols)
10429         (psym_expand_symtabs_matching): Update.
10430         * mdebugread.c (parse_partial_symbols): Update.
10431         * dbxread.c (dbx_end_psymtab): Update.
10432
10433 2019-01-15  Tom Tromey  <tom@tromey.com>
10434
10435         * symtab.c (lookup_objfile_from_block)
10436         (lookup_symbol_in_objfile_symtabs)
10437         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10438         (find_line_symtab, info_sources_command)
10439         (default_collect_symbol_completion_matches_break_on)
10440         (make_source_files_completion_list): Update.
10441         * symmisc.c (print_objfile_statistics, dump_objfile)
10442         (maintenance_print_symbols, maintenance_info_symtabs)
10443         (maintenance_check_symtabs, maintenance_info_line_tables):
10444         Update.
10445         * source.c (select_source_symtab)
10446         (forget_cached_source_info_for_objfile): Update.
10447         * objfiles.h (class objfile_compunits): Remove.
10448         (struct objfile) <compunits_range>: New typedef.
10449         (compunits): New method.
10450         * objfiles.c (objfile_relocate1): Update.
10451         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10452         * maint.c (count_symtabs_and_blocks): Update.
10453         * linespec.c (iterate_over_all_matching_symtabs): Update.
10454         * cp-support.c (add_symbol_overload_list_qualified): Update.
10455         * coffread.c (coff_symtab_read): Update.
10456         * ada-lang.c (add_nonlocal_symbols)
10457         (ada_collect_symbol_completion_matches)
10458         (ada_add_global_exceptions): Update.
10459
10460 2019-01-15  Tom Tromey  <tom@tromey.com>
10461
10462         * progspace.h (program_space) <objfiles_safe_range>: New
10463         typedef.
10464         <objfiles_safe>: New method.
10465         * objfiles.h (class all_objfiles_safe): Remove.
10466         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10467         * jit.c (jit_inferior_exit_hook): Update.
10468
10469 2019-01-17  Tom Tromey  <tom@tromey.com>
10470
10471         * progspace.h (program_space) <objfiles_range>: New typedef.
10472         <objfiles>: New method.
10473         <objfiles_head>: Rename from objfiles.
10474         (object_files): Update.
10475         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10476         * guile/scm-pretty-print.c
10477         (ppscm_find_pretty_printer_from_objfiles): Update.
10478         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10479         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10480         Update.
10481         * python/py-progspace.c (pspy_get_objfiles): Update.
10482         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10483         Update.
10484         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10485         (objfpy_lookup_objfile_by_build_id): Update.
10486         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10487         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10488         Update.
10489         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10490         (expand_symtab_containing_pc, lookup_objfile_from_block)
10491         (lookup_static_symbol, basic_lookup_transparent_type)
10492         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10493         (find_line_symtab, info_sources_command)
10494         (default_collect_symbol_completion_matches_break_on)
10495         (make_source_files_completion_list, find_main_name): Update.
10496         * symmisc.c (print_symbol_bcache_statistics)
10497         (print_objfile_statistics, maintenance_print_symbols)
10498         (maintenance_print_msymbols, maintenance_print_objfiles)
10499         (maintenance_info_symtabs, maintenance_check_symtabs)
10500         (maintenance_expand_symtabs, maintenance_info_line_tables):
10501         Update.
10502         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10503         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10504         (map_overlay_command, unmap_overlay_command)
10505         (simple_overlay_update, expand_symtabs_matching)
10506         (map_symbol_filenames): Update.
10507         * symfile-debug.c (set_debug_symfile): Update.
10508         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10509         Update.
10510         * source.c (select_source_symtab, forget_cached_source_info):
10511         Update.
10512         * solib.c (solib_read_symbols): Update.
10513         * solib-spu.c (append_ocl_sos): Update.
10514         * psymtab.c (maintenance_print_psymbols)
10515         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10516         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10517         * printcmd.c (info_symbol_command): Update.
10518         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10519         Update.
10520         * objfiles.h (class all_objfiles): Remove.
10521         * objfiles.c (have_partial_symbols, have_full_symbols)
10522         (have_minimal_symbols, qsort_cmp, update_section_map)
10523         (shared_objfile_contains_address_p)
10524         (default_iterate_over_objfiles_in_search_order): Update.
10525         * objc-lang.c (info_selectors_command, info_classes_command)
10526         (find_methods): Update.
10527         * minsyms.c (find_solib_trampoline_target): Update.
10528         * maint.c (maintenance_info_sections)
10529         (maintenance_translate_address, count_symtabs_and_blocks):
10530         Update.
10531         * main.c (captured_main_1): Update.
10532         * linux-thread-db.c (try_thread_db_load_from_pdir)
10533         (has_libpthread): Update.
10534         * linespec.c (iterate_over_all_matching_symtabs)
10535         (search_minsyms_for_name): Update.
10536         * jit.c (jit_find_objf_with_entry_addr): Update.
10537         * hppa-tdep.c (find_unwind_entry)
10538         (hppa_lookup_stub_minimal_symbol): Update.
10539         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10540         Update.
10541         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10542         (elf_gnu_ifunc_resolve_by_got): Update.
10543         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10544         * dwarf-index-write.c (save_gdb_index_command): Update.
10545         * cp-support.c (add_symbol_overload_list_qualified): Update.
10546         * breakpoint.c (create_overlay_event_breakpoint)
10547         (create_longjmp_master_breakpoint)
10548         (create_std_terminate_master_breakpoint)
10549         (create_exception_master_breakpoint): Update.
10550         * blockframe.c (find_pc_partial_function): Update.
10551         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10552         (ada_collect_symbol_completion_matches)
10553         (ada_add_global_exceptions): Update.
10554
10555 2019-01-17  Tom Tromey  <tom@tromey.com>
10556
10557         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10558         declare VEC.
10559         (solib_target_parse_libraries): Change return type.
10560         (library_list_start_segment, library_list_start_section)
10561         (library_list_end_library, library_list_start_library); Update.
10562         (solib_target_free_library_list): Remove.
10563         (solib_target_parse_libraries): Remove cleanup.  Change return
10564         type.
10565         (solib_target_current_sos): Update.
10566
10567 2019-01-17  Tom Tromey  <tromey@bapiya>
10568
10569         * valprint.c: Replace "the the" with "the".
10570         * symtab.c: Replace "the the" with "the".
10571         * solib.c: Replace "the the" with "the".
10572         * solib-dsbt.c: Replace "the the" with "the".
10573         * linespec.c: Replace "the the" with "the".
10574         * dwarf2loc.h: Replace "the the" with "the".
10575         * amd64-windows-tdep.c: Replace "the the" with "the".
10576         * aarch64-tdep.c: Replace "the the" with "the".
10577
10578 2019-01-16  Keith Seitz  <keiths@redhat.com>
10579
10580         PR gdb/23773
10581         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10582         <builder>: Rename to ..
10583         <m_builder>: ... this and make private.
10584         (dwarf2_cu::get_builder): New method.  Change all users of
10585         `builder' to use this method.
10586         (dwarf2_start_symtab): Move to ...
10587         (dwarf2_cu::start_symtab): ... here.  Update all callers
10588         (setup_type_unit_groups): Move to ...
10589         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10590         callers.
10591         (dwarf2_cu::reset_builder): New method.
10592         (process_full_compunit, process_full_type_unit): Use
10593         dwarf2_cu::reset_builder.
10594         (follow_die_offset): Record the ancestor CU if it is different
10595         from the followed DIE's CU.
10596         (follow_die_sig_1): Likewise.
10597
10598 2019-01-15  Tom Tromey  <tom@tromey.com>
10599
10600         * remote.c (class remote_state) <buf>: Now a char_vector.
10601         <buf_size>: Remove.
10602         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10603         parameter.
10604         (remote_target::getpkt_or_notif_sane_1)
10605         (remote_target::getpkt_sane)
10606         (remote_target::getpkt_or_notif_sane): Likewise.
10607         (class remote_target) <putpkt>: New overload.
10608         (remote_target::read_frame): Change type of "buf_p".  Remove
10609         sizeof_p parameter.
10610         (packet_ok): New overload.
10611         (packet_check_result): New overload.
10612         Update all uses.
10613
10614 2019-01-14  Tom Tromey  <tom@tromey.com>
10615
10616         * remote-notif.c (handle_notification, remote_notif_ack)
10617         (remote_notif_parse): Make "buf" const.
10618         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10619         const.
10620         (remote_notif_parse, remote_notif_ack, handle_notification):
10621         Likewise.
10622         * remote.c (remote_notif_stop_parse): Make "buf" const.
10623         (remote_target::remote_parse_stop_reply): Make "buf" const.
10624         (remote_notif_stop_ack): Make "buf" const.
10625
10626 2019-01-14  Tom Tromey  <tom@tromey.com>
10627
10628         * remote.c (remote_console_output): Make parameter const.
10629
10630 2019-01-14  Tom Tromey  <tom@tromey.com>
10631
10632         * target-debug.h (target_debug_print_signals): Constify.
10633         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10634         * procfs.c (procfs_target::pass_signals): Update.
10635         * linux-nat.c (linux_nat_target::pass_signals): Update.
10636         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10637         * target-delegates.c: Rebuild.
10638         * remote.c (remote_target::program_signals): Update.
10639         (remote_target::pass_signals): Update.
10640         * target.c (target_pass_signals): Constify argument.
10641         (target_program_signals): Likewise.
10642         * target.h (struct target_ops) <pass_signals, program_signals>:
10643         Constify argument.
10644         (target_pass_signals, target_program_signals): Constify argument.
10645
10646 2019-01-14  Tom Tromey  <tom@tromey.com>
10647
10648         PR tui/28819:
10649         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10650
10651 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10652
10653         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10654         field.
10655         * rs6000-tdep.c: Include reggroups.h.
10656         (IS_V_ALIAS_PSEUDOREG): Define.
10657         (rs6000_register_name): Return names for the "vX" aliases.
10658         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10659         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10660         aliases.  Call default_register_reggroup_p for all other
10661         pseudo-registers.
10662         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10663         New functions.
10664         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10665         Handle "vX" aliases.
10666         (v_alias_pseudo_register_collect): New function.
10667         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10668         (rs6000_gdbarch_init): Initialize "vX" aliases as
10669         pseudo-registers.  Restore registration of
10670         rs6000_pseudo_register_reggroup_p with
10671         set_tdesc_pseudo_register_reggroup_p.
10672
10673 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10674
10675         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10676         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10677         set_gdbarch_num_pseudo_regs.
10678
10679 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10680
10681         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10682         Remove arg prefixname, add do_set and do_show.
10683         Add member functions set_list and show_list.
10684         * cli/cli-style.c (class cli_style_option): Update accordingly.
10685         (style_set_list): Move to file scope.
10686         (style_show_list): Likewise.
10687         (set_style): Call help_list.
10688         (show_style): Call cmd_show_list.
10689         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10690         Update to use the new macro.
10691
10692 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10693
10694         * ada-lang.c (_initialize_ada_language): Expand the help text
10695         for the "catch exception" command.
10696
10697 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10698
10699         * symtab.c (matching_obj_sections): Initialize obj,
10700         declare it closer to its usage.
10701
10702 2019-01-10  Tom Tromey  <tom@tromey.com>
10703
10704         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10705         (basic_inf_threads_range): Remove.
10706         (inf_threads_range, inf_non_exited_threads_range)
10707         (safe_inf_threads_range): Use next_adapter.
10708
10709 2019-01-10  Keith Seitz  <keiths@redhat.com>
10710
10711         PR gdb/23712
10712         PR symtab/23010
10713         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10714         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10715
10716 2019-01-10  Keith Seitz  <keiths@redhat.com>
10717
10718         PR gdb/23712
10719         PR symtab/23010
10720         * dictionary.c (pending_to_vector): Remove.
10721         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10722         Remove _1 suffix, replacing functions of the same name.  Update
10723         all callers.
10724         (dict_create_hashed, dict_create_hashed_expandable)
10725         (dict_create_linear, dict_create_linear_expandable, dict_free)
10726         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10727         Make functions static.
10728
10729 2019-01-10  Keith Seitz  <keiths@redhat.com>
10730
10731         PR gdb/23712
10732         PR symtab/23010
10733         * dictionary.h (struct dictionary): Replace declaration with
10734         multidictionary.
10735         (dict_create_hashed, dict_create_hashed_expandable)
10736         (dict_create_linear, dict_create_linear_expandable)
10737         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10738         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10739         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10740         taking multidictionary argument.
10741         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10742         * block.h (struct block) <dict>: Change to multidictionary
10743         and rename `multidict'.
10744         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10745         symmisc.c: Update all dictionary references to multidictionary.
10746
10747 2019-01-10  Keith Seitz  <keiths@redhat.com>
10748
10749         PR gdb/23712
10750         PR symtab/23010
10751         * dictionary.c: Include unordered_map.
10752         (pending_to_vector): New function.
10753         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10754         Rewrite the non-"_1" functions to take vector instead
10755         of linked list.
10756         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10757         "new" _1 versions of the same name.
10758         (multidictionary): Define.
10759         (std::hash<enum language): New definition.
10760         (collate_pending_symbols_by_language, mdict_create_hashed)
10761         (mdict_create_hashed_expandable, mdict_create_linear)
10762         (mdict_create_linear_expandable, mdict_free)
10763         (find_language_dictionary, create_new_language_dictionary)
10764         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10765         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10766         (mdict_size, mdict_empty): New functions.
10767         * dictionary.h (mdict_iterator): Define.
10768
10769 2019-01-10  Pedro Alves  <palves@redhat.com>
10770
10771         * breakpoint.c (read_uploaded_action)
10772         (create_tracepoint_from_upload): Adjust to use
10773         gdb::unique_xmalloc_ptr.
10774         * ctf.c (ctf_write_uploaded_tp):
10775         (SET_ARRAY_FIELD): Use emplace_back.
10776         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10777         * tracefile-tfile.c (tfile_write_uploaded_tp):
10778         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10779         gdb::unique_xmalloc_ptr.
10780         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10781         at_string, cond_string, cmd_strings>: Replace char pointers
10782         with gdb::unique_xmalloc_ptr.
10783
10784 2019-01-10  Pedro Alves  <palves@redhat.com>
10785
10786         * solib-target.c (library_list_start_library): Don't xstrdup name.
10787
10788 2019-01-10  Pedro Alves  <palves@redhat.com>
10789
10790         * mdebugread.c (parse_partial_symbols): Use
10791         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10792
10793 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10794
10795         * linux-fork.c (scoped_switch_fork_info)
10796         <~scoped_switch_fork_info>: Fix incorrect variable name.
10797
10798 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10799
10800         * linux-fork.c (scoped_switch_fork_info)
10801         <scoped_switch_fork_info>: Make explicit.
10802         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10803
10804 2019-01-10  Tom Tromey  <tom@tromey.com>
10805
10806         * objfiles.h (objfile::reset_psymtabs): Update.
10807         * objfiles.c (objfile::objfile): Update.
10808         * psymtab.h (psymtab_storage::obstack): Update.
10809         (psymtab_storage::m_obstack): Use gdb::optional.
10810         (class psymtab_storage): Update comment.  Remove objfile
10811         parameter.
10812         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10813
10814 2019-01-10  Tom Tromey  <tom@tromey.com>
10815
10816         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10817         <free_psymtabs>: Now private.
10818         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10819         (allocate_psymtab): Use new method.
10820
10821 2019-01-10  Tom Tromey  <tom@tromey.com>
10822
10823         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10824         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10825         * mdebugread.c (parse_partial_symbols): Use
10826         allocate_dependencies.
10827         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10828         allocate_dependencies.
10829         (process_psymtab_comp_unit_reader)
10830         (build_type_psymtab_dependencies): Likewise.
10831         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10832
10833 2019-01-10  Tom Tromey  <tom@tromey.com>
10834
10835         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10836         PSYMBOL_SET_LANGUAGE.
10837         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10838
10839 2019-01-10  Tom Tromey  <tom@tromey.com>
10840
10841         * psymtab.h (psymtab_storage::obstack): New method.
10842         <m_obstack>: Rename from obstack; now private.
10843         * psymtab.c (psymtab_storage): Update.
10844         * dwarf2read.c (create_addrmap_from_index)
10845         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10846         Update.
10847
10848 2019-01-10  Tom Tromey  <tom@tromey.com>
10849
10850         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10851         * objfiles.h (objfile::reset_psymtabs): New method.
10852
10853 2019-01-10  Tom Tromey  <tom@tromey.com>
10854
10855         * symmisc.c (print_symbol_bcache_statistics): Update.
10856         (print_objfile_statistics): Update.
10857         * symfile.c (reread_symbols): Update.
10858         * psymtab.h (class psymtab_storage): New.
10859         * psymtab.c (psymtab_storage): New constructor.
10860         (~psymtab_storage): New destructor.
10861         (require_partial_symbols): Update.
10862         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10863         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10864         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10865         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10866         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10867         (start_psymtab_common, end_psymtab_common)
10868         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10869         (allocate_psymtab): Update.
10870         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10871         Update.
10872         (dump_psymtab_addrmap, maintenance_print_psymbols)
10873         (maintenance_check_psymtabs): Update.
10874         (class objfile_psymtabs): Move to objfiles.h.
10875         * psympriv.h (discard_psymtab): Now inline.
10876         (psymtab_discarder::psymtab_discarder): Update.
10877         (psymtab_discarder::~psymtab_discarder): Update.
10878         (ALL_OBJFILE_PSYMTABS): Rewrite.
10879         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10880         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10881         Remove fields.
10882         <partial_symtabs>: New field.
10883         (class objfile_psymtabs): Move from psymtab.h.  Update.
10884         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10885         psymbol_cache.
10886         (objfile::~objfile): Don't destroy psymbol_cache.
10887         * mdebugread.c (parse_partial_symbols): Update.
10888         * dwarf2read.c (create_addrmap_from_index)
10889         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10890         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10891         (add_partial_subprogram, dwarf2_ranges_read): Update.
10892         * dwarf-index-write.c (write_address_map)
10893         (write_one_signatured_type, recursively_write_psymbols)
10894         (class debug_names, class debug_names, write_psymtabs_to_index):
10895         Update.
10896
10897 2019-01-10  Tom Tromey  <tom@tromey.com>
10898
10899         * symtab.h (SYMBOL_SET_NAMES): Update.
10900         (symbol_set_names): Update.
10901         (MSYMBOL_SET_NAMES): Update.
10902         * symtab.c (symbol_set_names): Change argument to be an
10903         objfile_per_bfd_storage.
10904         * psymtab.c (add_psymbol_to_bcache): Update.
10905         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10906
10907 2019-01-10  Tom Tromey  <tom@tromey.com>
10908
10909         * symtab.c (create_demangled_names_hash): Change argument to be an
10910         objfile_per_bfd_storage.
10911         (symbol_set_names): Update.
10912
10913 2019-01-10  Tom Tromey  <tom@tromey.com>
10914
10915         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10916         init_psymbol_list.
10917         * psymtab.c (init_psymbol_list): Do nothing if already called.
10918         * psympriv.h (init_psymbol_list): Add comment.
10919         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10920         init_psymbol_list.
10921         * dbxread.c (dbx_symfile_read): Unconditionally call
10922         init_psymbol_list.
10923
10924 2019-01-10  Tom Tromey  <tom@tromey.com>
10925
10926         * xcoffread.c (scan_xcoff_symtab): Update.
10927         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10928         "where".
10929         * mdebugread.c (parse_partial_symbols)
10930         (handle_psymbol_enumerators): Update.
10931         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10932         * dbxread.c (read_dbx_symtab): Update.
10933         * psympriv.h (psymbol_placement): New enum.
10934         (add_psymbol_to_list): Update.
10935
10936 2019-01-10  Tom Tromey  <tom@tromey.com>
10937
10938         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10939         static_psymbols parameters.
10940         (scan_xcoff_symtab): Update.
10941         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10942         static_psymbols parameters.
10943         * psympriv.h (start_psymtab_common): Update.
10944         * mdebugread.c (parse_partial_symbols): Update.
10945         * dwarf2read.c (create_partial_symtab): Update.
10946         * dbxread.c (read_dbx_symtab): Update.
10947         (start_psymtab): Remove global_psymbols and static_psymbols
10948         parameters.
10949
10950 2019-01-10  Tom Tromey  <tom@tromey.com>
10951
10952         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10953         * psymtab.c (allocate_psymtab): Add comment.
10954         * psympriv.h (allocate_psymtab): Add comment.
10955         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10956         initializations.
10957         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10958
10959 2019-01-10  Tom Tromey  <tom@tromey.com>
10960
10961         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10962         Don't declare.
10963         * mipsread.c: Include mdebugread.h.
10964         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10965         Declare.
10966         * elfread.c: Include mdebugread.h.
10967
10968 2019-01-09  Tom Tromey  <tom@tromey.com>
10969
10970         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10971         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10972         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10973         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10974         (psym_lookup_symbol, psym_find_last_source_symtab)
10975         (psym_forget_cached_source_info, psym_print_stats)
10976         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10977         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10978         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10979         (psym_find_compunit_symtab_by_address)
10980         (maintenance_print_psymbols, maintenance_info_psymtabs)
10981         (maintenance_check_psymtabs): Use ranged for.
10982         * psymtab.h (class objfile_psymtabs): New.
10983         (require_partial_symbols): Return objfile_psymtabs.
10984         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10985
10986 2019-01-09  Tom Tromey  <tom@tromey.com>
10987
10988         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10989         (find_pc_mapped_section, list_overlays_command)
10990         (map_overlay_command, unmap_overlay_command)
10991         (simple_overlay_update): Use all_objfiles.
10992         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10993         * printcmd.c (info_symbol_command): Use all_objfiles.
10994         * objfiles.h (ALL_OBJSECTIONS): Remove.
10995         * maint.c (maintenance_translate_address): Use all_objfiles.
10996         * gcore.c (gcore_create_callback): Use all_objfiles.
10997         (objfile_find_memory_regions): Likewise.
10998
10999 2019-01-09  Tom Tromey  <tom@tromey.com>
11000
11001         * symtab.c (find_line_symtab, info_sources_command)
11002         (make_source_files_completion_list): Use objfile_compunits.
11003         * source.c (select_source_symtab): Use objfile_compunits.
11004         * objfiles.h (struct objfile): Update comment.
11005         (ALL_OBJFILES): Remove.
11006         (ALL_FILETABS): Remove.
11007         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11008         objfile_compunits.
11009
11010 2019-01-09  Tom Tromey  <tom@tromey.com>
11011
11012         * symmisc.c (print_objfile_statistics, dump_objfile)
11013         (maintenance_print_symbols): Use compunit_filetabs.
11014         * source.c (forget_cached_source_info_for_objfile): Use
11015         compunit_filetabs.
11016         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11017         (ALL_FILETABS): Use compunit_filetabs.
11018         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11019         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11020
11021 2019-01-09  Tom Tromey  <tom@tromey.com>
11022
11023         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11024         (compunit_filetabs): New.
11025         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11026         compunit_filetabs.
11027         (info_sources_command, make_source_files_completion_list): Remove
11028         declaration.
11029         * symmisc.c (print_objfile_statistics, dump_objfile)
11030         (maintenance_print_symbols): Remove declaration.
11031         (maintenance_info_symtabs): Use compunit_filetabs.
11032         (maintenance_info_line_tables): Likewise.
11033         * source.c (select_source_symtab): Change local variable name.
11034         (forget_cached_source_info_for_objfile): Remove declaration.
11035         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11036         * objfiles.c (objfile_relocate1): Remove declaration.
11037         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11038         declaration.
11039         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11040         * coffread.c (coff_symtab_read): Remove declaration.
11041         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11042         compunit_filetabs.
11043
11044 2019-01-09  Tom Tromey  <tom@tromey.com>
11045
11046         * symtab.c (lookup_objfile_from_block)
11047         (find_pc_sect_compunit_symtab, search_symbols)
11048         (default_collect_symbol_completion_matches_break_on): Use
11049         objfile_compunits.
11050         * objfiles.h (ALL_COMPUNITS): Remove.
11051         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11052         * cp-support.c (add_symbol_overload_list_qualified): Use
11053         objfile_compunits.
11054         * ada-lang.c (ada_collect_symbol_completion_matches)
11055         (ada_add_global_exceptions): Use objfile_compunits.
11056
11057 2019-01-09  Tom Tromey  <tom@tromey.com>
11058
11059         * source.c (select_source_symtab)
11060         (forget_cached_source_info_for_objfile): Remove declaration.
11061         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11062         declaration.
11063         * maint.c (count_symtabs_and_blocks): Remove declaration.
11064         * cp-support.c (add_symbol_overload_list_qualified): Remove
11065         declaration.
11066         * coffread.c (coff_symtab_read): Remove declaration.
11067         * symtab.c (lookup_symbol_in_objfile_symtabs)
11068         (basic_lookup_transparent_type_1): Use objfile_compunits.
11069         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11070         (info_sources_command, search_symbols)
11071         (default_collect_symbol_completion_matches_break_on)
11072         (make_source_files_completion_list): Remove declaration.
11073         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11074         (ada_collect_symbol_completion_matches)
11075         (ada_add_global_exceptions): Remove declaration.
11076         * linespec.c (iterate_over_all_matching_symtabs): Use
11077         objfile_compunits.
11078         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11079         (class objfile_compunits): New.
11080         (ALL_COMPUNITS): Use objfile_compunits.
11081         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11082         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11083         objfile_compunits.
11084         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11085
11086 2019-01-09  Tom Tromey  <tom@tromey.com>
11087
11088         * symtab.c (search_symbols)
11089         (default_collect_symbol_completion_matches_break_on): Use
11090         objfile_msymbols.
11091         * ada-lang.c (ada_lookup_simple_minsym)
11092         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11093         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11094         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11095         objfile_msymbols.
11096         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11097         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11098         * objc-lang.c (find_methods): Use objfile_msymbols.
11099         (info_selectors_command, info_classes_command): Likewise.
11100         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11101         * objfiles.h (class objfile_msymbols): New.
11102         (ALL_OBJFILE_MSYMBOLS): Remove.
11103         (ALL_MSYMBOLS): Remove.
11104
11105 2019-01-09  Tom Tromey  <tom@tromey.com>
11106
11107         * common/next-iterator.h (next_adapter): Add Iterator template
11108         parameter.
11109         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11110         (class all_objfiles_safe): New.
11111         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11112         * objfiles.c (put_objfile_before): Update comment.
11113         (add_separate_debug_objfile): Likewise.
11114         (free_all_objfiles): Use all_objfiles_safe.
11115         (objfile_purge_solibs): Likewise.
11116
11117 2019-01-09  Tom Tromey  <tom@tromey.com>
11118
11119         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11120         (expand_symtab_containing_pc, lookup_static_symbol)
11121         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11122         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11123         all_objfiles.
11124         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11125         * breakpoint.c (create_overlay_event_breakpoint)
11126         (create_longjmp_master_breakpoint)
11127         (create_std_terminate_master_breakpoint)
11128         (create_exception_master_breakpoint): Use all_objfiles.
11129         * linux-thread-db.c (try_thread_db_load_from_pdir)
11130         (has_libpthread): Use all_objfiles.
11131         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11132         * linespec.c (iterate_over_all_matching_symtabs)
11133         (search_minsyms_for_name): Use all_objfiles.
11134         * maint.c (maintenance_info_sections): Use all_objfiles.
11135         * main.c (captured_main_1): Use all_objfiles.
11136         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11137         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11138         * guile/scm-pretty-print.c
11139         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11140         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11141         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11142         (maintenance_print_msymbols): Use all_objfiles.
11143         * source.c (select_source_symtab): Use all_objfiles.
11144         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11145         * symfile.c (remove_symbol_file_command)
11146         (expand_symtabs_matching, map_symbol_filenames): Use
11147         all_objfiles.
11148         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11149         all_objfiles.
11150         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11151         * objc-lang.c (find_methods): Use all_objfiles.
11152         * objfiles.c (have_partial_symbols, have_full_symbols)
11153         (have_minimal_symbols, qsort_cmp)
11154         (default_iterate_over_objfiles_in_search_order): Use
11155         all_objfiles.
11156         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11157         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11158         (maintenance_check_psymtabs): Use all_objfiles.
11159         (ALL_PSYMTABS): Remove.
11160         * compile/compile-object-run.c (do_module_cleanup): Use
11161         all_objfiles.
11162         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11163         * cp-support.c (add_symbol_overload_list_qualified): Use
11164         all_objfiles.
11165         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11166         Use all_objfiles.
11167         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11168         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11169         all_objfiles.
11170         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11171         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11172         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11173         Uses all_objfiles.
11174         * solib.c (solib_read_symbols): Use all_objfiles
11175
11176 2019-01-09  Tom Tromey  <tom@tromey.com>
11177
11178         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11179         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11180         all_objfiles.
11181         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11182         * symmisc.c (print_symbol_bcache_statistics)
11183         (print_objfile_statistics, maintenance_print_objfiles)
11184         (maintenance_info_symtabs, maintenance_check_symtabs)
11185         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11186         all_objfiles.
11187         * source.c (forget_cached_source_info): Use all_objfiles.
11188         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11189         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11190         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11191         * objfiles.c (update_section_map): Use all_objfiles.
11192         (shared_objfile_contains_address_p): Likewise.
11193         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11194         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11195
11196 2019-01-09  Tom Tromey  <tom@tromey.com>
11197
11198         * common/next-iterator.h: New file.
11199         * objfiles.h (class all_objfiles): New.
11200         (struct objfile_iterator): New.
11201
11202 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11203
11204         * NEWS: Move the description of the changed "frame", "select-frame",
11205          and "info frame" commands to the Changed commands section.
11206
11207 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11208
11209         * gdbtypes.c (check_stub_method_group): Remove handling of old
11210         mangling schemes.
11211         * linespec.c (find_methods): Likewise.
11212         * stabsread.c (read_member_functions): Likewise.
11213         * valops.c (search_struct_method): Likewise.
11214         (value_struct_elt_for_reference): Likewise.
11215         * NEWS: Mention this change.
11216
11217 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11218
11219         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11220         print_source_lines.
11221         * source.c (print_source_lines_base): Update line number check.
11222         (print_source_lines): New function.
11223         (source_lines_range::source_lines_range): New function.
11224         * source.h (class source_lines_range): New class.
11225         (print_source_lines): New declaration.
11226
11227 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11228
11229         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11230
11231 2019-01-08  Tom Tromey  <tom@tromey.com>
11232             Simon Marchi  <simon.marchi@ericsson.com>
11233
11234         PR gdb/24060
11235         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11236         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11237         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11238         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11239         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11240         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11241
11242 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11243
11244         * source.c (select_source_symtab): Move header comment to
11245         declaration in source.h.
11246         (forget_cached_source_info_for_objfile): Likewise.
11247         (forget_cached_source_info): Likewise.
11248         (identify_source_line): Likewise.
11249         * source.h (identify_source_line): Move declaration from symtab.h
11250         and add comment from source.c
11251         (print_source_lines): Likewise.
11252         (forget_cached_source_info_for_objfile): Likewise.
11253         (forget_cached_source_info): Likewise.
11254         (select_source_symtab): Likewise.
11255         (enum print_source_lines_flag): Move definition from symtab.h.
11256         * symtab.h (identify_source_line): Move declaration to source.h.
11257         (print_source_lines): Likewise.
11258         (forget_cached_source_info_for_objfile): Likewise.
11259         (forget_cached_source_info): Likewise.
11260         (select_source_symtab): Likewise.
11261         (enum print_source_lines_flag): Move definition to source.h.
11262         * tui/tui-hooks.c: Add 'source.h' include.
11263
11264 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11265
11266         * source.c (print_source_lines_base): Handle requests to print
11267         reverse line number sequences, and guard against empty lines
11268         string.
11269
11270 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11271
11272         * source.c (print_source_lines_base): Fix skip of '\r' if next
11273         character is '\n'.
11274
11275 2019-01-06  Tom Tromey  <tom@tromey.com>
11276
11277         * c-exp.y (struct c_parse_state) <macro_original_text,
11278         expansion_obstack>: New member.
11279         (macro_original_text, expansion_obstack): Remove globals.
11280         (scan_macro_expansion, scanning_macro_expansion)
11281         (finished_macro_expansion): Update.
11282         (scan_macro_cleanup): Remove.
11283         (yylex, c_parse): Update.
11284
11285 2019-01-06  Tom Tromey  <tom@tromey.com>
11286
11287         * c-exp.y (struct c_parse_state) <strings>: New member.
11288         (operator_stoken): Update.
11289
11290 2019-01-06  Tom Tromey  <tom@tromey.com>
11291
11292         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11293         (union type_stack_elt) <typelist_val>: Now a pointer to
11294         std::vector.
11295         (type_stack_cleanup): Don't declare.
11296         (push_typelist): Update.
11297         * parse.c (pop_typelist): Return a std::vector.
11298         (push_typelist): Take a std::vector.
11299         (follow_types): Update.  Do not free args.
11300         (type_stack_cleanup): Remove.
11301         * c-exp.y (struct c_parse_state): New.
11302         (cpstate): New global.
11303         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11304         (nonempty_typelist): Update.
11305         (func_mod): Create a new vector.
11306         (c_parse): Create a c_parse_state.
11307         (check_parameter_typelist): Do not delete params.
11308         (function_method): Update.  Do not delete type_list.
11309
11310 2019-01-06  Tom Tromey  <tom@tromey.com>
11311
11312         PR gdb/28155:
11313         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11314         check_typedef.
11315         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11316         (print_return_value): Likewise.
11317
11318 2019-01-05  Tom Tromey  <tom@tromey.com>
11319
11320         * contrib/cleanup_check.py: Remove.
11321         * contrib/gcc-with-excheck: Remove.
11322         * contrib/exsummary.py: Remove.
11323         * contrib/excheck.py: Remove.
11324
11325 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11326
11327         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11328         NULL. Initialize tpprev to NULL instead of assigning it
11329         to NULL on the next statement.
11330         * windows-nat.c (windows_delete_thread): Remove check for
11331         main_thread_id before printing thread exit notifications.
11332         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11333         Remove thread ID check against main_thread_id.
11334         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11335         windows_delete_thread.
11336         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11337
11338 2019-01-04  Tom Tromey  <tom@tromey.com>
11339
11340         * compile/compile.c (_initialize_compile): Use upper case for
11341         metasyntactic variables.
11342         * symmisc.c (_initialize_symmisc): Use upper case for
11343         metasyntactic variables.
11344         * psymtab.c (_initialize_psymtab): Use upper case for
11345         metasyntactic variables.
11346         * demangle.c (demangle_command): Use upper case for metasyntactic
11347         variables.
11348         (_initialize_demangler): Likewise.
11349         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11350         variables.
11351
11352 2019-01-03  Tom Tromey  <tom@tromey.com>
11353
11354         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11355
11356 2019-01-03  Tom Tromey  <tom@tromey.com>
11357
11358         * python/py-symtab.c (salpy_str): Update.
11359         (struct salpy_sal_object) <symtab>: Now a PyObject.
11360         (salpy_dealloc): Update.
11361         (del_objfile_sal): Use gdbpy_ref.
11362
11363 2019-01-03  Tom Tromey  <tom@tromey.com>
11364
11365         * python/py-type.c (convert_field): Use new_reference.  Return
11366         gdbpy_ref.
11367         (make_fielditem): Return gdbpy_ref.
11368         (typy_fields): Update.
11369         (typy_getitem): Update.
11370         (field_name): Return gdbpy_ref.  Use new_reference.
11371         (typy_iterator_iternext): Update.
11372
11373 2019-01-03  Tom Tromey  <tom@tromey.com>
11374
11375         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11376
11377 2019-01-03  Tom Tromey  <tom@tromey.com>
11378
11379         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11380         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11381         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11382         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11383         (pspy_set_type_printers): Likewise.
11384         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11385         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11386         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11387         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11388         (objfpy_set_type_printers): Likewise.
11389
11390 2019-01-03  Tom Tromey  <tom@tromey.com>
11391
11392         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11393         (gdbpy_print_stack): Use gdbpy_err_fetch.
11394         * python/python-internal.h (class gdbpy_err_fetch): New class.
11395         (class gdbpy_enter) <m_error_type, m_error_value,
11396         m_error_traceback>: Remove.
11397         <m_error>: New member.
11398         (gdbpy_exception_to_string): Don't declare.
11399         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11400         * python/py-value.c (convert_value_from_python): Use
11401         gdbpy_err_fetch.
11402         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11403         gdbpy_exception_to_string.
11404         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11405         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11406         gdbpy_err_fetch.
11407
11408 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11409
11410         * linux-nat.c (delete_lwp_cleanup): Delete.
11411         (struct lwp_deleter): New struct.
11412         (lwp_info_up): New typedef.
11413         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11414         lwp_info_up.
11415
11416 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11417
11418         * linux-fork.c (class scoped_switch_fork_info): New class.
11419         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11420
11421 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11422
11423         * valops.c (find_overload_match): Remove use of null_cleanup, and
11424         calls to do_cleanups.
11425
11426 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11427
11428         * compile/compile-cplus-types.c
11429         (compile_cplus_instance::decl_name): Handle changes to
11430         cp_func_name.
11431         * cp-support.c (cp_func_name): Update header comment, update
11432         return type.
11433         * cp-support.h (cp_func_name): Update return type in declaration.
11434         * valops.c (find_overload_match): Move temp_func local to top
11435         level of function and change its type.  Use temp_func to hold and
11436         delete temporary string obtained from cp_func_name.
11437
11438 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11439
11440         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11441         gdb::char_vector, remove cleanup, and update uses of `msg`.
11442
11443 2019-01-03  Jim Wilson  <jimw@sifive.com>
11444
11445         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11446
11447 2019-01-02  Tom Tromey  <tom@tromey.com>
11448
11449         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11450         (tdesc_parse_xml): Remove cleanups.
11451         * target-descriptions.h (make_cleanup_free_target_description):
11452         Don't declare.
11453         (target_desc_deleter): New struct.
11454         (target_desc_up): New typedef.
11455         * target-descriptions.c (target_desc_deleter::operator()): Rename
11456         from free_target_description.
11457         (make_cleanup_free_target_description): Remove.
11458
11459 2019-01-02  Tom Tromey  <tom@tromey.com>
11460
11461         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11462         constructor, destructor.
11463         (linespec_parser): Remove typedef.
11464         (~linespec_parser): Rename from linespec_parser_delete.
11465         (linespec_lex_to_end, linespec_complete_label)
11466         (linespec_complete): Update.
11467         (decode_line_full): Remove cleanups.
11468         (decode_line_1): Update.
11469
11470 2019-01-02  Tom Tromey  <tom@tromey.com>
11471
11472         * python/python-internal.h (inferior_to_inferior_object): Change
11473         return type.
11474         * python/py-exitedevent.c (create_exited_event_object): Update.
11475         * python/py-inferior.c (inferior_to_inferior_object): Return
11476         gdbpy_ref.
11477         (python_new_inferior, python_inferior_deleted)
11478         (thread_to_thread_object, delete_thread_object)
11479         (build_inferior_list, gdbpy_selected_inferior): Update.
11480         * python/py-infthread.c (create_thread_object): Update.  Also fail
11481         if inferior_to_inferior_object fails.
11482
11483 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11484
11485         * inferior.h (class inferior) <displaced_step_state>: New field.
11486         * infrun.h (struct displaced_step_state): Move here from
11487         infrun.c.  Initialize fields, add constructor.
11488         <inf>: Remove field.
11489         <reset>: New method.
11490         * infrun.c (struct displaced_step_inferior_state): Move to
11491         infrun.h.
11492         (displaced_step_inferior_states): Remove.
11493         (get_displaced_stepping_state): Adust.
11494         (displaced_step_in_progress_any_inferior): Adjust.
11495         (displaced_step_in_progress_thread): Adjust.
11496         (displaced_step_in_progress): Adjust.
11497         (add_displaced_stepping_state): Remove.
11498         (get_displaced_step_closure_by_addr): Adjust.
11499         (remove_displaced_stepping_state): Remove.
11500         (infrun_inferior_exit): Call displaced_step_state.reset.
11501         (use_displaced_stepping): Don't check for NULL.
11502         (displaced_step_prepare_throw): Call
11503         get_displaced_stepping_state.
11504         (displaced_step_fixup): Don't check for NULL.
11505         (prepare_for_detach): Don't check for NULL.
11506
11507 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11508
11509         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11510          in case of call that did not complete.
11511
11512 2019-01-02  Andrey Utkin  <autkin@undo.io>
11513
11514         * symfile.c (find_separate_debug_file): Fix search of debug files for
11515         remote debuggee.
11516
11517 2019-01-02  Tom Tromey  <tom@tromey.com>
11518
11519         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11520         indentation.
11521         * python/py-frame.c (frapy_older): Remove cast.
11522         (frapy_newer): Likewise.
11523         * python/py-breakpoint.c (local_setattro): Remove cast.
11524         * python/py-arch.c (archpy_name): Remove local variable.
11525         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11526
11527 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11528
11529         * unittests/basic_string_view/element_access/char/empty.cc:
11530         Fix year range in copyright header.
11531
11532 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11533
11534         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11535         Delete.
11536         <operator==>: Update with for removed field.
11537         <hash>: Likewise.
11538         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11539         <isa_features>: ...this.
11540         <abi_features>: New field.
11541         (riscv_isa_flen): Update comment.
11542         (riscv_abi_xlen): New declaration.
11543         (riscv_abi_flen): New declaration.
11544         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11545         isa_features.
11546         (riscv_abi_xlen): New function.
11547         (riscv_isa_flen): Update to get answer from isa_features.
11548         (riscv_abi_flen): New function.
11549         (riscv_has_fp_abi): Update to get answer from abi_features.
11550         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11551         xlen and flen.
11552         (riscv_call_info) <xlen, flen>: Update comment.
11553         (riscv_call_arg_struct): Remove invalid assertions
11554         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11555         is removed.
11556         (riscv_gdbarch_init): Gather isa features and abi features
11557         separately, ensure both match on the gdbarch when reusing an old
11558         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11559         a target with 64-bit float hardware.
11560
11561 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11562
11563         * source.c (search_command_helper): Stop reverse search
11564         when line 1 has been searched.
11565
11566 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11567
11568         * record-full.c (record_full_base_target::close): Rewrite
11569         record_full_core_buf_list free logic.
11570
11571 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11572
11573         * break-catch-syscall.c (print_one_catch_syscall): xfree
11574         the last text.
11575
11576 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11577
11578         * top.c (print_gdb_version): Update Copyright year in version
11579         message.
11580
11581 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11582
11583         Update copyright year range in all GDB files.
11584
11585 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11586
11587         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11588
11589 For older changes see ChangeLog-2018.
11590 \f
11591 Local Variables:
11592 mode: change-log
11593 left-margin: 8
11594 fill-column: 74
11595 version-control: never
11596 coding: utf-8
11597 End:
11598