gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
   4         Inline constructor.  Add initializers for members.
   5         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
   6         constructors; now inline in class.
   7
   8 2019-06-25  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-regs.c (tui_show_registers): Update.
  11         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
  12         bool.
  13         * tui/tui-data.c (tui_data_window::clear_detail)
  14         (tui_data_window): Update.
  15
  16 2019-06-25  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-windata.c (tui_display_all_data)
  19         (tui_display_data_from_line, tui_display_data_from)
  20         (tui_check_data_values, tui_data_window::do_scroll_vertical):
  21         Update.
  22         * tui/tui-regs.c (tui_last_regs_line_no)
  23         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
  24         (tui_show_registers, tui_show_register_group)
  25         (tui_display_registers_from, tui_display_reg_element_at_line)
  26         (tui_display_registers_from_line, tui_check_register_values)
  27         (tui_reg_next, tui_reg_prev): Update.
  28         * tui/tui-layout.c (tui_set_layout, show_data): Update.
  29         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
  30         tui_data_window.
  31         (struct tui_win_info) <detail>: Remove.  Add new fields from
  32         tui_data_info.
  33         (TUI_DATA_WIN): Add cast.
  34         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
  35         (~tui_data_window): Simplify.
  36
  37 2019-06-25  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-layout.c (show_source_disasm_command)
  40         (show_source_or_disasm_and_command): Update.
  41         * tui/tui-io.c (update_cmdwin_start_line)
  42         (tui_redisplay_readline): Update.
  43         * tui/tui-data.h (struct tui_command_info): Remove.
  44         (struct tui_win_info) <detail>: Remove command_info member.
  45         (struct tui_data_window) <start_line>: New member, from
  46         tui_command_info.
  47         (TUI_CMD_WIN): Add casts.
  48
  49 2019-06-25  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-winsource.c (tui_update_source_window)
  52         (tui_refill_source_window)
  53         (tui_source_window_base::do_scroll_horizontal)
  54         (tui_update_breakpoint_info, tui_set_exec_info_content)
  55         (tui_show_exec_info_content, tui_erase_exec_info_content)
  56         (tui_clear_exec_info_content): Update.
  57         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
  58         Update.
  59         * tui/tui-win.c (make_invisible_and_set_new_height)
  60         (make_visible_with_new_height): Update.
  61         * tui/tui-source.c (tui_set_source_content)
  62         (tui_show_symtab_source): Update.
  63         * tui/tui-layout.c (extract_display_start_addr)
  64         (show_source_disasm_command, show_data)
  65         (make_source_or_disasm_window)
  66         (show_source_or_disasm_and_command): Update.
  67         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
  68         (tui_disasm_window::do_scroll_vertical): Remove shadowing
  69         "gdbarch".
  70         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
  71         to tui_source_window_base.
  72         (struct tui_win_info) <detail>: Remove source_info member.
  73         (struct tui_source_window_base) <has_locator>: Inline.
  74         Move contents from tui_source_info; rename has_locator member to
  75         m_has_locator.
  76         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
  77         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
  78         header file.
  79         (tui_source_window_base::clear_detail, ~tui_source_window_base):
  80         Simplify.
  81         (tui_free_all_source_wins_content): Cast to
  82         tui_source_window_base.
  83
  84 2019-06-25  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-win.c (make_invisible_and_set_new_height)
  87         (make_visible_with_new_height): Call has_locator method.
  88         * tui/tui-layout.c (show_source_disasm_command, show_data)
  89         (show_source_or_disasm_and_command): Update for bool change.
  90         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
  91         (tui_win_info) <has_locator>: New method.
  92         (struct tui_source_window_base) <has_locator>: New method.
  93         (tui_win_has_locator): Don't declare.
  94         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
  95         from tui_win_has_locator.
  96         (tui_source_window_base): Use false, not FALSE.
  97
  98 2019-06-25  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 101         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 102         clear_detail method directly.
 103         (tui_clear_win_detail): Remove.
 104
 105 2019-06-25  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 108         "this", not TUI_DISASM_WIN.
 109
 110 2019-06-25  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 113         declare.
 114         * tui/tui-winsource.c
 115         (tui_source_window_base::do_scroll_horizontal): Rename from
 116         tui_horizontal_source_scroll.
 117         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 118         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 119         from tui_vertical_data_scroll.
 120         * tui/tui-win.h (tui_scroll): Don't declare.
 121         * tui/tui-win.c (tui_win_info::forward_scroll)
 122         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 123         (tui_win_info::right_scroll): Rename and update.
 124         (tui_scroll_forward_command, tui_scroll_backward_command)
 125         (tui_scroll_left_command, tui_scroll_right_command): Update.
 126         (tui_scroll): Remove.
 127         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 128         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 129         from tui_vertical_source_scroll.
 130         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 131         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 132         from tui_vertical_disassem_scroll.
 133         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 134         do_scroll_horizontal>: New methods.
 135         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 136         Likewise.
 137         (struct tui_source_window_base): Add do_scroll_horizontal.
 138         (struct tui_source_window, struct tui_disasm_window): Add
 139         do_scroll_vertical.
 140         (struct tui_data_window, struct tui_cmd_window): Add
 141         do_scroll_horizontal and do_scroll_vertical.
 142         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 143
 144 2019-06-25  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-data.h (struct tui_source_window_base): New struct.
 147         (struct tui_source_window): Derive from tui_source_window_base.
 148         (struct tui_disasm_window): New struct.
 149         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 150         from tui_source_window::clear_detail.
 151         (tui_source_window_base): Rename from tui_source_window.
 152         (~tui_source_window_base): Rename from ~tui_source_window.
 153         (tui_alloc_win_info): Create a tui_disasm_window.
 154
 155 2019-06-25  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui-data.h (struct tui_source_window)
 158         (struct tui_data_window): Declare destructors.
 159         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 160         destructors.
 161         (tui_win_info): Simplify.
 162
 163 2019-06-25  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-winsource.c (tui_display_main)
 166         (tui_update_source_windows_with_addr)
 167         (tui_update_all_breakpoint_info): Update.
 168         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 169         (new_height_ok, parse_scrolling_args): Update.
 170         * tui/tui-stack.c (tui_show_frame_info): Update.
 171         * tui/tui-data.h (struct tui_list): Remove.
 172         (tui_source_windows): Return a reference to a std::vector.
 173         * tui/tui-data.c (source_windows): Now a std::vector.
 174         (tui_source_windows): Change return type.
 175         (tui_clear_source_windows): Rewrite.
 176         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 177         (tui_free_all_source_wins_content): Rewrite.
 178
 179 2019-06-25  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 182         (struct tui_data_window, struct tui_cmd_window): Declare
 183         clear_detail method.
 184         * tui/tui-data.c (tui_source_window::clear_detail)
 185         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 186         methods.
 187         (tui_clear_win_detail): Simplify.
 188
 189 2019-06-25  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-layout.c (make_source_window, make_disasm_window)
 192         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 193         Return the new window.
 194         (show_source_disasm_command, show_data)
 195         (show_source_or_disasm_and_command): Update.
 196
 197 2019-06-25  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 200         parameter.  Return the new window.
 201         (show_source_disasm_command): Update and remove NULL check.
 202         (show_source_or_disasm_and_command): Update.
 203
 204 2019-06-25  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 207
 208 2019-06-25  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-data.h (struct tui_win_info): Make constructor
 211         protected.  Make destructor virtual.  Add initializers.
 212         (tui_source_window, tui_data_window, tui_cmd_window): New
 213         classes.
 214         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 215         constructor.  Add "type" parameter.
 216         (tui_source_window, tui_data_window, tui_cmd_window): New
 217         constructors.
 218         (tui_alloc_win_info): Instantiate the appropriate subclass.
 219
 220 2019-06-25  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-win.c (tui_resize_all): Use delete.
 223         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 224         destructor.
 225         (tui_free_window): Don't declare.
 226         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 227         Update.
 228
 229 2019-06-25  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-data.h (struct tui_win_info): Add constructor.
 232         * tui/tui-data.c (tui_alloc_win_info): Use new.
 233         (tui_free_window): Use delete.
 234
 235 2019-06-22  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 238         declare.
 239         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 240
 241 2019-06-22  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 244         declare.
 245         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 246
 247 2019-06-22  Tom de Vries  <tdevries@suse.de>
 248
 249         * dwarf2read.c (create_addrmap_from_aranges)
 250         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 251         instead of '%zu'.
 252
 253 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 254
 255         * dwarf2read.h (dwarf2_section_info_def): Remove.
 256         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 257         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 258         std::vector<dwarf2_section_info>.
 259         (struct dwo_file) <~dwo_file>: Remove.
 260         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 261         types field.
 262         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 263         (dwarf2_read_debug_names): Likewise.
 264         (create_debug_types_hash_table): Change parameter type to
 265         array_view, adjust code accordingly.
 266         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 267         (partial_die_info::fixup): Likewise.
 268         (determine_prefix): Likewise.
 269         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 270
 271 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 272
 273         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 274         gdb_bfd_ref_ptr.
 275         <~dwo_file>: Remove call to gdb_bfd_unref.
 276         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 277         gdb_bfd_ref_ptr::get.
 278
 279 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 280
 281         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 282         type to htab_up.
 283         * dwarf2read.c (struct dwo_file): Initialize fields.
 284         <~dwo_file>: New.
 285         (free_dwo_file): Remove, move content to ~dwo_file.
 286         (struct dwo_file_deleter): Remove.
 287         (dwo_file_up>: Remove custom deleter.
 288         (free_dwo_files): Remove.
 289         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 290         dwo_files.
 291         (process_skeletonless_type_units): Call unique_ptr::get.
 292         (allocate_dwo_file_hash_table): Add deleter to created hash
 293         table.  Change return type to htab_up.
 294         (lookup_dwo_file_slot): Don't memset dwo_file, call
 295         unique_ptr::get.
 296         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 297         (create_dwo_unit_in_dwp_v2): Likewise.
 298         (open_and_init_dwo_file): Likewise.
 299         (free_dwo_file_from_slot): Remove.
 300
 301 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 302
 303         * dwarf2read.h (struct dwarf2_section_info) <readin,
 304         is_virtual>: Change type to bool.
 305         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 306         true instead of 1.
 307
 308 2019-06-19  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-data.h (tui_init_content_element): Don't declare.
 311
 312 2019-06-19  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-data.h (tui_init_win_info): Don't declare.
 315
 316 2019-06-19  Tom de Vries  <tdevries@suse.de>
 317
 318         * dwarf2read.h (abstract_to_concrete): Change type to
 319         std::unordered_map<sect_offset, std::vector<sect_offset>,
 320         gdb::hash_enum<sect_offset>>.
 321
 322 2019-06-19  Tom Tromey  <tromey@adacore.com>
 323
 324         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 325         EVAL_AVOID_SIDE_EFFECTS specially.
 326
 327 2019-06-19  Tom Tromey  <tromey@adacore.com>
 328
 329         * source-cache.c (highlighter): New global.
 330         (source_cache::get_source_lines): Create a highlighter on demand.
 331
 332 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 333
 334         * defs.h (deprecated_interactive_hook): Delete declaration.
 335         * interps.c (clear_interpreter_hooks): Remove use of
 336         deprecated_interactive_hook.
 337         * top.c (deprecated_interactive_hook): Delete definition.
 338         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 339
 340 2019-06-18  Tom de Vries  <tdevries@suse.de>
 341
 342         PR gdb/24515
 343         * dwarf2read.h (abstract_to_concrete): Change type from
 344         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 345         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 346         * dwarf2read.c (read_variable): Update.
 347         (dwarf2_fetch_die_loc_sect_off): Update.
 348
 349 2019-06-17  Tom de Vries  <tdevries@suse.de>
 350
 351         PR gdb/24617
 352         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 353         accessing parent[parent_len - 1].
 354
 355 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 356
 357         PR gdb/24364
 358         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 359         call dtrace_process_dof with NULL dof.
 360
 361 2019-06-16  Tom de Vries  <tdevries@suse.de>
 362
 363         PR gdb/24445
 364         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 365
 366 2019-06-16  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 369         (make_all_visible): Use address of member.
 370
 371 2019-06-16  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 374         (tui_free_window, free_content, free_content_elements): Remove
 375         unnecessary cast.
 376         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 377         cast.
 378         * tui/tui-regs.c (tui_show_register_group)
 379         (tui_display_registers_from, tui_display_reg_element_at_line):
 380         Remove unnecessary cast.
 381
 382 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 383
 384         * linux-nat.c (normal_mask): Delete.
 385         (_initialize_linux_nat): Don't initialise normal_mask.
 386
 387 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 388
 389         PR gdb/24445
 390         * dwarf-index-write.h (write_psymtabs_to_index): Add
 391         dwz_basename parameter.
 392         * dwarf-index-write.c (write_gdbindex): Move file writing to
 393         write_gdbindex_1.  Change return type void.
 394         (assert_file_size): Move up, remove filename parameter.
 395         (write_gdbindex_1): New function.
 396         (write_debug_names): Change return type to void, call
 397         assert_file_size.
 398         (struct index_wip_file): New struct.
 399         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 400         file logic to index_wip_file.  Write index for dwz file if
 401         needed.
 402         (save_gdb_index_command): Pass basename of dwz file, if present.
 403         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 404         build-id of dwz file, if present.
 405         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 406         (dwarf2_get_dwz_file): Likewise.
 407         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 408         (dwarf2_get_dwz_file): Likewise.
 409
 410 2019-06-16  Tom Tromey  <tom@tromey.com>
 411
 412         * coffread.c (process_coff_symbol): Use xstrdup.
 413         * value.c (create_internalvar): Use xstrdup.
 414
 415 2019-06-16  Tom Tromey  <tom@tromey.com>
 416
 417         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 418         * breakpoint.c (stopin_command, stopat_command)
 419         (until_break_command, decode_location_default): Remove unnecessary
 420         cast.
 421         * utils.c (subset_compare): Remove unnecessary cast.
 422         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 423         cast.
 424         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 425         cast.
 426         * infcmd.c (path_command): Remove unnecessary cast.
 427         * coffread.c (decode_type): Remove unnecessary cast.
 428         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 429         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 430         * tui/tui-stack.c (tui_show_locator_content)
 431         (tui_show_frame_info): Remove unnecessary cast.
 432         * tui/tui-win.c (tui_scroll_forward_command)
 433         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 434         (parse_scrolling_args): Remove unnecessary cast.
 435         * tui/tui-data.c (init_win_info, tui_del_window)
 436         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 437         (free_content_elements): Remove unnecessary cast.
 438         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 439         unnecessary cast.
 440         * tui/tui-source.c (tui_set_source_content)
 441         (tui_vertical_source_scroll): Remove unnecessary cast.
 442         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 443         cast.
 444         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 445         * tui/tui-regs.c (tui_display_registers_from)
 446         (tui_display_register): Remove unnecessary cast.
 447         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 448         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 449         (make_visible): Remove unnecessary cast.
 450         * tui/tui-winsource.c (tui_erase_source_content)
 451         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 452         unnecessary cast.
 453         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 454         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 455         * stabsread.c (read_type, read_array_type, read_range_type):
 456         Remove unnecessary cast.
 457         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 458         (parse_symbol, parse_type, upgrade_type, parse_external)
 459         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 460         unnecessary cast.
 461         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 462
 463 2019-06-16  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-data.c (tui_alloc_generic_win_info)
 466         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 467         checks.
 468
 469 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 470             Andrew Burgess  <andrew.burgess@embecosm.com>
 471
 472         * f-typeprint.c (f_print_type): Don't return early for not
 473         associated or not allocated types.
 474         (f_type_print_varspec_suffix): Add print_rank parameter and print
 475         ranks of array types in case they dangling.
 476         (f_type_print_base): Add print_rank parameter.
 477
 478 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 479
 480         * NEWS: Mention new MI commands.
 481         * break-catch-throw.c (enum exception_event_kind): Move to
 482         breakpoint.h.
 483         (print_mention_exception_catchpoint): Output text as a single
 484         message.
 485         (catch_exception_command_1): Rename to...
 486         (catch_exception_event): ...this, make non-static, update header
 487         command, and change some parameter types.
 488         (catch_catch_command): Update for changes to
 489         catch_exception_command_1.
 490         (catch_throw_command): Likewise.
 491         (catch_rethrow_command): Likewise.
 492         * breakpoint.c (enum exception_event_kind): Delete.
 493         * breakpoint.h (enum exception_event_kind): Moved here from
 494         break-catch-throw.c.
 495         (catch_exception_event): Declare.
 496         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 497         (mi_cmd_catch_throw): New function.
 498         (mi_cmd_catch_rethrow): New function.
 499         (mi_cmd_catch_catch): New function.
 500         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 501         'catch-catch' entries.
 502         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 503         (mi_cmd_catch_rethrow): Declare.
 504         (mi_cmd_catch_catch): Declare.
 505
 506 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * annotate.c (annotate_source_line): Change return type to void,
 509         update implementation to match.
 510         * annotate.h (annotate_source_line): Change return type to void,
 511         update header comment.
 512         * stack.c (print_frame_info): Don't change what frame information
 513         is printed based on whether annotations are on or not.
 514
 515 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 516
 517         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 518         (annotate_source): Make static.
 519         (annotate_source_line): Moved from source.c and renamed from
 520         identify_source_line.  Update the return type.
 521         * annotate.h (annotate_source): Delete declaration.
 522         (annotate_source_line): Declaration moved from source.h, and
 523         renamed from identify_source_line.  Return type updated.
 524         * source.c (identify_source_line): Moved to annotate.c and renamed
 525         to annotate_source_line.
 526         (info_line_command): Remove check of annotation_level.
 527         * source.h (identify_source_line): Move declaration to annotate.h
 528         and rename to annotate_source_line.
 529         * stack.c: Add 'annotate.h' include.
 530         (print_frame_info): Remove check of annotation_level before
 531         calling annotate_source_line.
 532
 533 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 534
 535         * source-cache.c (source_cache::get_plain_source_lines): Use
 536         open_source_file_with_line_charpos instead of just
 537         open_source_file, remove call to find_source_lines.
 538         (source_cache::get_source_lines): Likewise.
 539         * source.c (find_source_lines): Make static.
 540         (get_filename_and_charpos): Renamed into...
 541         (open_source_file_with_line_charpos): ..this along with changes to
 542         return a scoped_fd, and some other minor clean ups.
 543         (identify_source_line): Use open_source_file_with_line_charpos.
 544         (search_command_helper): Use open_source_file_with_line_charpos
 545         instead of just open_source_file, remove call to
 546         find_source_lines.
 547         * source.h (open_source_file_with_line_charpos): Declare new
 548         function.
 549         (find_source_lines): Delete declaration.
 550
 551 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 552
 553         * source.c (get_filename_and_charpos): Remove fullname
 554         parameter.
 555         (identify_source_line): Update call to get_filename_and_charpos.
 556
 557 2019-06-14  Tom Tromey  <tromey@adacore.com>
 558
 559         PR gdb/24502:
 560         * ui-style.h (skip_ansi_escape): Update comment.
 561         * ui-file.h (class no_terminal_escape_file): New class.
 562         * ui-file.c (no_terminal_escape_file::write)
 563         (no_terminal_escape_file::puts): New methods.
 564         * cli/cli-logging.c (handle_redirections): Use
 565         no_terminal_escape_file.
 566
 567 2019-06-14  Tom Tromey  <tromey@adacore.com>
 568
 569         * NEWS: Move convenience variable news above Python news.
 570
 571 2019-06-14  Tom Tromey  <tom@tromey.com>
 572
 573         * gnulib: Move directory to top-level.
 574         * configure.ac: Don't configure gnulib.
 575         * configure: Rebuild.
 576         * common/common-defs.h: Use new path to gnulib.
 577         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 578         (GNULIB_H): Remove.
 579         (INCGNU): Look in new gnulib location.
 580         (HFILES_NO_SRCDIR): Remove gnulib files.
 581         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 582         (generated_files): Remove GNULIB_H.
 583         ($(LIBGNU), all-lib): Remove targets.
 584         (distclean): Don't mention GNULIB_BUILDDIR.
 585         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 586
 587 2019-06-14  Tom Tromey  <tromey@adacore.com>
 588
 589         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 590         Warn if symbol file does not provide any symbols.
 591
 592 2019-06-14  Tom Tromey  <tromey@adacore.com>
 593
 594         * source.c (find_and_open_source): Respect basenames_may_differ.
 595
 596 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 597
 598         * annotate.c (annotate_breakpoints_invalid): Make use of
 599         scoped_restore_terminal_state.
 600         (annotate_frames_invalid): Likewise.
 601
 602 2019-06-14  Tom Tromey  <tromey@adacore.com>
 603
 604         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 605         allow assignment to an internalvar.
 606
 607 2019-06-14  Tom Tromey  <tromey@adacore.com>
 608
 609         * ada-lex.l: Allow "_" in attribute names.
 610
 611 2019-06-14  Tom Tromey  <tromey@adacore.com>
 612
 613         PR gdb/24653:
 614         * regcache.c (registers_changed): Don't call alloca.
 615         * top.c (execute_command): Don't call alloca.
 616
 617 2019-06-13  Pedro Alves  <palves@redhat.com>
 618
 619         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 620         'expression'.  When parsing an expression, error out if there's
 621         junk after "unlimited".
 622         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 623         (do_set_command): Adjust calls to is_unlimited_literal.
 624
 625 2019-06-13  Pedro Alves  <palves@redhat.com>
 626
 627         * compile/compile.c (make_compile_options_def_group): Add braces
 628         around array_view initializer.
 629         * thread.c (make_thread_apply_all_options_def_group)
 630         (make_thread_apply_all_options_def_group): Likewise.
 631
 632 2019-06-13  Pedro Alves  <palves@redhat.com>
 633
 634         * NEWS (New commands): Mention "maint test-options
 635         require-delimiter", "maint test-options unknown-is-error", "maint
 636         test-options unknown-is-operand" and "maint show
 637         test-options-completion-result".
 638         (New command options, command completion): New section.
 639         (Completion improvements): New section.
 640         Mention that you can abbreviate "unlimited".
 641
 642 2019-06-13  Pedro Alves  <palves@redhat.com>
 643
 644         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 645         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 646         * unittests/cli-utils-selftests.c (test_parse_flags)
 647         (test_parse_flags_qcs): Delete.
 648         (test_cli_utils): Don't call deleted functions.
 649
 650 2019-06-13  Pedro Alves  <palves@redhat.com>
 651
 652         * thread.c: Include "cli/cli-option.h".
 653         (tp_array_compar_ascending): Global.
 654         (tp_array_compar): Delete function.
 655         (tp_array_compar_ascending, tp_array_compar_descending): New
 656         functions.
 657         (ascending_option_def, qcs_flag_option_def)
 658         (thr_qcs_flags_option_defs)
 659         (make_thread_apply_all_options_def_group)
 660         (make_thread_apply_options_def_group): New.
 661         (thread_apply_all_command): Use gdb::option::process_options.
 662         (thread_apply_command_completer)
 663         (thread_apply_all_command_completer): New.
 664         (thread_apply_command): Use gdb::option::process_options.
 665         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 666         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 667         to generate help text of "thread apply".  Adjust "taas"'s help.
 668         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 669         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 670
 671 2019-06-13  Pedro Alves  <palves@redhat.com>
 672
 673         * thread.c (thread_apply_command): Check for invalid TID with
 674         isdigit instead of !isalpha.
 675
 676 2019-06-13  Pedro Alves  <palves@redhat.com>
 677
 678         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 679         (validate_flags_qcs): New.
 680         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 681         (validate_flags_qcs): Declare.
 682         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 683         (make_frame_apply_options_def_group): New.
 684         (frame_apply_command_count): Process options with
 685         gdb::option::process_options.
 686         (frame_apply_completer): New.
 687         (frame_apply_level_completer, frame_apply_all_completer)
 688         (frame_apply_completer): New.
 689         (_initialize_stack): Update help of "frame apply", "frame apply
 690         level", "frame apply all" and "faas" to mention supported options
 691         and install command completers.
 692         * stack.h (frame_apply_all_completer): Declare.
 693         * thread.c: Include "stack.h".
 694         (tfaas_command): Add "--".
 695         (_initialize_thread): Update help "tfaas" to mention supported
 696         options and install command completer.
 697
 698 2019-06-13  Pedro Alves  <palves@redhat.com>
 699
 700         * completer.c (complete_nested_command_line): New.
 701         (gdb_completion_word_break_characters_throw): Add assertion.
 702         * completer.h (complete_nested_command_line): Declare.
 703
 704 2019-06-13  Pedro Alves  <palves@redhat.com>
 705
 706         * stack.c (parse_backtrace_qualifiers): New.
 707         (backtrace_command): Use it.
 708         (backtrace_command_completer): Complete on qualifiers.
 709
 710 2019-06-13  Pedro Alves  <palves@redhat.com>
 711
 712         * frame.c: Include "cli/cli-option.h.
 713         (user_set_backtrace_options): New.
 714         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 715         Delete.
 716         (get_prev_frame): Adjust.
 717         (boolean_option_def, uinteger_option_def)
 718         (set_backtrace_option_defs): New.
 719         (_initialize_frame): Adjust and use
 720         gdb::option::add_setshow_cmds_for_options to install "set
 721         backtrace past-main" and "set backtrace past-entry".
 722         * frame.h: Include "cli/cli-option.h".
 723         (struct frame_print_options): Forward declare.
 724         (print_frame_arguments_all, print_frame_arguments_scalars)
 725         (print_frame_arguments_none): Declare.
 726         (print_entry_values): Delete declaration.
 727         (struct frame_print_options, user_frame_print_options): New.
 728         (struct set_backtrace_options): New.
 729         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 730         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 731         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 732         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 733         (list_args_or_locals): Add frame_print_options parameter.
 734         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 735         * python/py-framefilter.c (enumerate_args): Pass down
 736         USER_FRAME_PRINT_OPTIONS.
 737         * stack.c: Include "cli/cli-option.h".
 738         (print_frame_arguments_all, print_frame_arguments_scalars)
 739         (print_frame_arguments_none): Declare.
 740         (print_raw_frame_arguments, print_entry_values): Delete.
 741         (user_frame_print_options): New.
 742         (boolean_option_def, enum_option_def, frame_print_option_defs):
 743         New.
 744         (struct backtrace_cmd_options): New.
 745         (bt_flag_option_def): New.
 746         (backtrace_command_option_defs): New.
 747         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 748         (print_frame_arg, read_frame_arg, print_frame_args)
 749         (print_frame_info, print_frame): Add frame_print_options parameter
 750         and use it.
 751         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 752         (backtrace_command_1): Add frame_print_options and
 753         backtrace_cmd_options parameters and use them.
 754         (make_backtrace_options_def_group): New.
 755         (backtrace_command): Process command options with
 756         gdb::option::process_options.
 757         (backtrace_command_completer): New.
 758         (_initialize_stack): Extend "backtrace"'s help to mention
 759         supported options.  Install completer for "backtrace".
 760         Install some settings commands with add_setshow_cmds_for_options.
 761
 762 2019-06-13  Pedro Alves  <palves@redhat.com>
 763
 764         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 765         and that "set/show print raw frame-arguments" are now deprecated.
 766
 767         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 768         command.
 769         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 770         * stack.c (_initialize_stack): Install "set/show print
 771         raw-frame-arguments", and deprecate "set/show print raw
 772         frame-arguments".
 773         * valprint.c (_initialize_valprint): Deprecate "set/show print
 774         raw".
 775
 776 2019-06-13  Pedro Alves  <palves@redhat.com>
 777
 778         * compile/compile.c (struct compile_options): New.
 779         (compile_flag_option_def, compile_command_option_defs)
 780         (make_compile_options_def_group): New.
 781         (compile_file_command): Handle options with
 782         gdb::option::process_options.
 783         (compile_file_command_completer): New function.
 784         (compile_code_command): Handle options with
 785         gdb::option::process_options.
 786         (compile_code_command_completer): New function.
 787         (_initialize_compiler): Install completers for "compile code" and
 788         "compile file".  Mention available options in "compile code" and
 789         "compile code"'s help.
 790         * completer.c (advance_to_completion_word): New, factored out from
 791         ...
 792         (advance_to_expression_complete_word_point): ... this.
 793         (advance_to_filename_complete_word_point): New.
 794         * completer.h (advance_to_filename_complete_word_point): New
 795         declaration.
 796
 797 2019-06-13  Pedro Alves  <palves@redhat.com>
 798
 799         * compile/compile.c: Include "cli/cli-option.h".
 800         (compile_print_value): Scope data pointer is now a
 801         value_print_options pointer; adjust.
 802         (compile_print_command): Process options.  Scope data pointer is
 803         now a value_print_options pointer; adjust.
 804         (_initialize_compile): Update "compile print"'s help to include
 805         supported options.  Install a completer for "compile print".
 806         * cp-valprint.c (show_vtblprint, show_objectprint)
 807         (show_static_field_print): Delete.
 808         (_initialize_cp_valprint): Don't install "set print
 809         static-members", "set print vtbl", "set print object" here.
 810         * printcmd.c: Include "cli/cli-option.h" and
 811         "common/gdb_optional.h".
 812         (print_command_parse_format): Rework to fill in a
 813         value_print_options instead of a format_data.
 814         (print_value): Change parameter type from format_data pointer to
 815         value_print_options reference.  Adjust.
 816         (print_command_1): Process options.  Adjust to pass down a
 817         value_print_options.
 818         (print_command_completer): New.
 819         (_initialize_printcmd): Install print_command_completer as
 820         handle_brkchars completer for the "print" command.  Update
 821         "print"'s help to include supported options.
 822         * valprint.c: Include "cli/cli-option.h".
 823         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 824         here from cp-valprint.c.
 825         (boolean_option_def, uinteger_option_def)
 826         (value_print_option_defs, make_value_print_options_def_group):
 827         New.  Use gdb::option::add_setshow_cmds_for_options to install
 828         "set print elements", "set print null-stop", "set print repeats",
 829         "set print pretty", "set print union", "set print array", "set
 830         print address", "set print symbol", "set print array-indexes".
 831         * valprint.h: Include <string> and "cli/cli-option.h".
 832         (make_value_print_options_def_group): Declare.
 833         (print_value): Change parameter type from format_data pointer to
 834         value_print_options reference.
 835         (print_command_completer): Declare.
 836
 837 2019-06-13  Pedro Alves  <palves@redhat.com>
 838
 839         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 840         (COMMON_SFILES): Add maint-test-settings.c.
 841         * cli/cli-decode.c (boolean_enums): New global, factored out from
 842         ...
 843         (add_setshow_boolean_cmd): ... here.
 844         * cli/cli-decode.h (boolean_enums): Declare.
 845         * cli/cli-option.c: New file.
 846         * cli/cli-option.h: New file.
 847         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 848         factored out from ...
 849         (parse_cli_boolean_value(const char *)): ... this.
 850         (is_unlimited_literal): Change parameter type to pointer to
 851         pointer.  Adjust and advance ARG pointer.
 852         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 853         (parse_cli_var_enum): New, factored out from ...
 854         (do_set_command): ... this.  Adjust.
 855         * cli/cli-setshow.h (parse_cli_boolean_value)
 856         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 857         (parse_cli_var_enum): Declare.
 858         * cli/cli-utils.c: Include "cli/cli-option.h".
 859         (get_ulongest): New.
 860         * cli/cli-utils.h (get_ulongest): Declare.
 861         (check_for_argument): New overloads.
 862         * maint-test-options.c: New file.
 863
 864 2019-06-13  Pedro Alves  <palves@redhat.com>
 865
 866         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 867         parse a range if "-" is at the end of the string.
 868
 869 2019-06-13  Pedro Alves  <palves@redhat.com>
 870
 871         * cli/cli-setshow.c (parse_auto_binary_operation)
 872         (parse_cli_boolean_value): Don't allow "o".
 873
 874 2019-06-13  Pedro Alves  <palves@redhat.com>
 875
 876         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 877         * NEWS: Mention maint test-settings KIND.
 878         * maint-test-settings.c: New file.
 879
 880 2019-06-13  Pedro Alves  <palves@redhat.com>
 881
 882         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 883         completer.
 884         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 885         "set" completers.
 886
 887 2019-06-13  Pedro Alves  <palves@redhat.com>
 888
 889         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 890         after item.
 891
 892 2019-06-13  Pedro Alves  <palves@redhat.com>
 893
 894         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 895
 896 2019-06-13  Pedro Alves <palves@redhat.com>
 897
 898         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 899         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 900         call.
 901         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 902         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 903         calls.
 904         (check_for_argument): Skip spaces after argument.
 905
 906 2019-06-13  Pedro Alves  <palves@redhat.com>
 907
 908         * thread.c (thread_apply_command): Adjust TID parsing.
 909         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 910         detected before end of string.
 911         (tid_is_in_list): Error out if LIST is invalid.
 912
 913 2019-06-13  Pedro Alves  <palves@redhat.com>
 914
 915         * completer.c (complete_line_internal_1): Rewind completion word
 916         point.
 917         (completion_tracker::advance_custom_word_point_by): Change
 918         parameter type to int.
 919         * completer.h (completion_tracker::advance_custom_word_point_by):
 920         Likewise.
 921
 922 2019-06-13  Pedro Alves  <palves@redhat.com>
 923
 924         * completer.c (advance_to_completion_word): Handle delimiters.
 925
 926 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 927
 928         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 929
 930 2019-06-11  Tom Tromey  <tom@tromey.com>
 931
 932         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 933         (xmalloc_failed): Move to alloc.c.
 934         * alloc.c: New file.
 935         * Makefile.in (COMMON_SFILES): Add alloc.c.
 936
 937 2019-06-11  Tom Tromey  <tom@tromey.com>
 938
 939         * nat/linux-waitpid.c: Don't include server.h.
 940         (linux_debug): Remove.
 941         (my_waitpid): Update.
 942
 943 2019-06-11  Tom Tromey  <tromey@adacore.com>
 944
 945         * infcall.c (_initialize_infcall): Remove trailing newline from
 946         help.
 947         * user-regs.c (_initialize_user_regs): Remove trailing newline
 948         from help.
 949         * typeprint.c (_initialize_typeprint): Remove trailing newline
 950         from help.
 951         * reverse.c (_initialize_reverse): Remove trailing newlines from
 952         help.
 953         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 954         from help.
 955         * language.c (add_set_language_command): Remove trailing newline
 956         from help.
 957         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 958         help.
 959         * disasm.c (_initialize_disasm): Remove trailing newline from
 960         help.
 961         * top.c (init_main): Remove trailing newline from help.
 962         * interps.c (_initialize_interpreter): Remove trailing newline
 963         from help.
 964         * btrace.c (_initialize_btrace): Remove trailing newlines from
 965         help.
 966         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 967         from help.
 968         * python/python.c (_initialize_python): Remove trailing newline
 969         from help.
 970         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 971         help.
 972         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 973         from help.  Reformat some text.
 974         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 975         from help.
 976         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 977         newline from help.
 978
 979 2019-06-11  Tom Tromey  <tromey@adacore.com>
 980
 981         * darwin-nat.c (darwin_decode_exception_message)
 982         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 983
 984 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * valops.c (value_slice): Check for not allocated or not
 987         associated values.
 988
 989 2019-06-10  Tom de Vries  <tdevries@suse.de>
 990
 991         PR gdb/24618
 992         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 993         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 994         invalid.
 995
 996 2019-06-10  Tom de Vries  <tdevries@suse.de>
 997
 998         PR gdb/24611
 999         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1000         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1001
1002 2019-06-10  Tom de Vries  <tdevries@suse.de>
1003
1004         PR symtab/24545
1005         * symtab.c (struct demangled_name_entry): Add language field.
1006         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1007         static minimal symbol".  Set and use language field.
1008
1009 2019-06-10  Tom Tromey  <tromey@adacore.com>
1010
1011         * ada-lang.c (_initialize_ada_language): Update help text.
1012
1013 2019-06-10  Tom Tromey  <tromey@adacore.com>
1014
1015         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1016         with a newline.
1017         * guile/guile.c (handle_boot_error): Don't end warning with a
1018         newline.
1019         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1020         warning with a newline.
1021         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1022         newline.
1023         (s12z_frame_cache): Likewise.
1024         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1025         a newline.
1026         * solib-svr4.c (disable_probes_interface): Don't end warning with
1027         a newline.
1028         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1029         newline.
1030         * python/python.c (do_finish_initialization): Don't end warning
1031         with a newline.
1032
1033 2019-06-10  Tom Tromey  <tom@tromey.com>
1034
1035         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1036         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1037         gdbpy_enter.
1038
1039 2019-06-10  Tom Tromey  <tromey@adacore.com>
1040
1041         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1042         data.
1043         (elf_new_init): Don't call stabsread_new_init.
1044         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1045         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1046         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1047
1048 2019-06-10  Tom de Vries  <tdevries@suse.de>
1049
1050         PR symtab/16264
1051         PR symtab/24517
1052         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1053
1054 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1055
1056         * source.c (find_and_open_source): Also rewrite relative file
1057         names.
1058
1059 2019-04-26  Amos Bird  <amosbird@gmail.com>
1060
1061         * annotate.c (annotate_thread_exited): Add "thread-exited"
1062         annotation.
1063
1064 2019-06-06  Tom Tromey  <tromey@adacore.com>
1065
1066         * maint.h (class scoped_command_stats): Use
1067         DISABLE_COPY_AND_ASSIGN.
1068         <print_time>: New method.
1069         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1070         print_time.
1071         (scoped_command_stats::print_time): New method.
1072
1073 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1076         instructions of lengths 6 or 8 bytes.
1077
1078 2019-06-04  Pedro Alves  <palves@redhat.com>
1079
1080         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1081
1082         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1083         * breakpoint.c (condition_completer): Likewise.
1084         * cli/cli-dump.c (scan_expression): Likewise.
1085         * common/filestuff.c (mkdir_recursive): Likewise.
1086         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1087         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1088         (gdb_abspath): Likewise.
1089         * compile/compile-cplus-types.c
1090         (compile_cplus_instance::decl_name): Likewise.
1091         * completer.c (complete_explicit_location):
1092         (signal_completer, reg_or_group_completer_1): Likewise.
1093         * cp-support.c (cp_remove_params_if_any): Likewise.
1094         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1095         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1096         * infcmd.c (strip_bg_char): Likewise.
1097         * linespec.c (copy_token_string): Likewise.
1098         * mi/mi-main.c (output_cores): Likewise.
1099         * psymtab.c (psymtab_search_name):
1100         * symfile.c (test_set_ext_lang_command): Likewise.
1101         * target.c (target_fileio_read_stralloc): Likewise.
1102         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1103         * value.c (complete_internalvar): Likewise.
1104
1105 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1106
1107         Add objfile property to gdb.Type.
1108         * NEWS: Mention Python API addition.
1109         * python/py-type.c (typy_get_objfile): New method.
1110
1111 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1112
1113         * NEWS: Mention the new set|show style [title|highlight].
1114         Mention changes to "show style", "help" and "apropos".
1115
1116 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1117
1118         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1119         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1120         instead of print_help_for_command.
1121         (print_doc_of_command): New function.
1122         (help_list): Add 'apropos -v word' suggestion.
1123         (print_help_for_command): Style the command name using title style.
1124         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1125         (_initialize_cli_cmds): Describe -v in apropos_command help.
1126
1127 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1128
1129         * cli/cli-style.h (cli_style_option): Add name in constructor,
1130         add m_name class member, add constructor with intensity,
1131         add name class function.
1132         (cli_style_option::add_setshow_commands): Remove name argument.
1133         (highlight_style, title_style): New styles.
1134         * cli/cli-style.c (do_show): New function that shows a style
1135         characteristic styling the style name with itself.
1136         (set_style_name): New function.
1137         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1138         Update all callers according to the changes in cli/cli-style.h.
1139         * utils.h (fputs_highlighted): New function.
1140         * utils.c (fputs_highlighted): Likewise.
1141
1142 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1143
1144         * NEWS: Mention new pipe command and new convenience variables.
1145
1146 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1147
1148         * cli/cli-cmds.c (pipe_command): New function.
1149         (_initialize_cli_cmds): Call add_com for pipe_command.
1150         Define | as an alias for pipe.
1151         (exit_status_set_internal_vars): New function.
1152         (shell_escape): Call exit_status_set_internal_vars.
1153         cli/cli-decode.c (find_command_name_length): Recognize | as
1154         a single character command.
1155
1156 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1157
1158         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1159         top.c (execute_command_to_ui_file): New function, mostly a copy
1160         of execute_command_to_string.
1161         (execute_command_to_string): Implement by calling
1162         execute_command_to_ui_file.
1163
1164 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1165
1166         * top.h (saved_command_line): Remove declaration.
1167         * top.c (previous_saved_command_line, previous_repeat_arguments):
1168         New variables.
1169         (saved_command_line): Make static, define together with other
1170         'repeat variables'.
1171         (dont_repeat): Clear repeat_arguments.
1172         (repeat_previous, get_saved_command_line, save_command_line):
1173         New functions.
1174         (gdb_init): Initialize saved_command_line
1175         and previous_saved_command_line.
1176         * main.c (captured_main_1): Remove saved_command_line initialization.
1177         * event-top.c (handle_line_of_input): Update to use
1178         the new 'repeat' related functions instead of direct access to
1179         saved_command_line.
1180         * command.h (repeat_previous, get_saved_command_line,
1181         save_command_line): New declarations.
1182         (dont_repeat): Add comment.
1183
1184 2019-05-30  Tom Tromey  <tromey@adacore.com>
1185
1186         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1187         Fix comment.
1188         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1189
1190 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1191
1192         PR cli/24587
1193         * completer.c (complete): Initialize variable word.
1194
1195 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1196
1197         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1198         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1199         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1200         'body' is NULL to the outter 'if', protecting the '!is_define'
1201         situation as well.
1202
1203 2019-05-29  Tom Tromey  <tromey@adacore.com>
1204
1205         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1206         (dwarf_unknown): New function.
1207         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1208         (dwarf_type_encoding_name): Use dwarf_unknown.
1209
1210 2019-05-29  Tom Tromey  <tromey@adacore.com>
1211
1212         PR c++/20020:
1213         * cp-valprint.c (cp_print_value_fields): Call
1214         cp_print_static_field inside "try".
1215
1216 2019-05-29  Tom Tromey  <tromey@adacore.com>
1217
1218         * inflow.c (struct terminal_info): Add default operator=.
1219         * configure: Rebuild.
1220         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1221         -Wdeprecated-copy-dtor, -Wredundant-move.
1222
1223 2019-05-29  Tom Tromey  <tromey@adacore.com>
1224
1225         * NEWS: Add entry.
1226         * infcmd.c (print_return_value_1): Handle finish_print
1227         option.
1228         (show_print_finish): New function.
1229         (_initialize_infcmd): Add "set/show print finish" commands.
1230         * valprint.c (user_print_options): Initialize new member.
1231         * valprint.h (struct value_print_options) <finish_print>: New
1232         member.
1233
1234 2019-05-28  Tom Tromey  <tromey@adacore.com>
1235
1236         * ada-lang.c (ada_remove_Xbn_suffix)
1237         (find_old_style_renaming_symbol)
1238         (parse_old_style_renaming): Remove.
1239         (ada_find_renaming_symbol): Don't call
1240         find_old_style_renaming_symbol.
1241         (ada_is_renaming_symbol): Rename from
1242         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1243         bool.  Now static.
1244         (ada_read_var_value): Update and simplify.
1245         * ada-exp.y (write_var_or_type): Remove old code.
1246
1247 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1248
1249         * event-top.c: Remove include comment.
1250         * inflow.c (class scoped_ignore_sigttou): Move from here...
1251         * inflow.h (class scoped_ignore_sigttou): ...to here.
1252         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1253         * top.c:  Remove include comment.
1254
1255 2019-05-27  Tom Tromey  <tom@tromey.com>
1256
1257         * NEWS: Fix typo.
1258
1259 2019-05-22  Tom Tromey  <tromey@adacore.com>
1260
1261         * target.c (target_follow_exec): Constify parameter.
1262         * target-delegates.c: Rebuild.
1263         * remote.c (remote_target::follow_exec): Constify parameter.
1264         * infrun.c (follow_exec): Constify parameter.
1265         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1266         (target_follow_exec): Likewise.
1267
1268 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1269
1270         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1271         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1272
1273 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1274
1275         * NEWS: Add debugredirect and testsuite sections.
1276
1277 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1278
1279         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1280         target descriptions using exclusively floating point register name
1281         aliases.
1282
1283 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         PR gdb/18644:
1286         * f-lang.c (build_fortran_types): Handle the case where
1287         gdbarch_floatformat_for_type returns a nullptr.
1288
1289 2019-05-21  Tom de Vries  <tdevries@suse.de>
1290
1291         PR cli/24587
1292         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1293
1294 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1295
1296         PR gdb/18644:
1297         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1298         16-byte floats.
1299         * i386-tdep.c (i386_floatformat_for_type): Use
1300         floatformats_ia64_quad for the 16-byte floating point component
1301         within a fortran 32-byte complex number.
1302
1303 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1306         delete default constructor.
1307         (find_partial_die): Update to return const struct.
1308         (partial_die_parent_scope): Move variable declaration into scope
1309         of its use and change its type to auto.
1310         (guess_partial_die_structure_name): Likewise.
1311         (partial_die_info::fixup): Likewise.
1312
1313 2019-05-17  Tom Tromey  <tromey@adacore.com>
1314
1315         * source.c (find_and_open_source): Remove cast.
1316
1317 2019-05-17  Tom Tromey  <tromey@adacore.com>
1318
1319         * annotate.c (annotate_source): Make "filename" const.
1320         * annotate.h (annotate_source): Use const.
1321
1322 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1323
1324         * disasm.c (set_disassembler_options): Send errors to stderr.
1325
1326 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1327
1328         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1329         (cli_interp_base::set_logging): Check debug_redirect.
1330         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1331         * cli/cli-logging.c (debug_redirect): Add static variable.
1332         (pop_output_files): Add default param.
1333         (handle_redirections): Print debug setting.
1334         (show_logging_command): Likewise.
1335         (_initialize_cli_logging): Add debugredirect command.
1336         * interps.c (current_interp_set_logging): Add debug_redirect
1337         parameter.
1338         * interps.h (set_logging): Add debug_redirect parameter.
1339         (current_interp_set_logging): Likewise.
1340         * mi/mi-common.h: Likewise.
1341         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1342
1343 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1344             Tom Tromey  <tromey@adacore.com>
1345
1346         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1347         directly.
1348         * cli/cli-interp.h (make_logging_output): Remove declaration.
1349         * cli/cli-logging.c (make_logging_output): Remove function.
1350         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1351         directly.
1352         * ui-file.c (tee_file::tee_file): Remove bools.
1353         (tee_file::~tee_file): Remove deletes.
1354         * ui-file.h (tee_file): Remove bools.
1355
1356 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1357
1358         * mi/mi-cmds.h (mi_cmd_complete): New function.
1359         * mi/mi-main.c (mi_cmd_complete): Likewise.
1360         * mi/mi-cmds.c: Define new MI command -complete.
1361         * NEWS: Mention new -complete command.
1362
1363 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1364
1365         * completer.h (complete): New function.
1366         * completer.c (complete): Likewise.
1367         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1368         function defined in completer.h.
1369
1370 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1371
1372         * MAINTAINERS (Write After Approval): Add myself.
1373
1374 2019-05-17  Tom de Vries  <tdevries@suse.de>
1375
1376         PR gdb/24094
1377         * dwarf2read.c (struct cu_partial_die_info): New struct.
1378         (find_partial_die): Return cu_partial_die_info.
1379         (partial_die_parent_scope, guess_partial_die_structure_name)
1380         (partial_die_info::fixup): Handle new return type of find_partial_die.
1381
1382 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1383
1384         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1385         "std::string", simplifying the algorithm.
1386
1387 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1388
1389         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1390         (stap_static_probe_ops::get_probes): Likewise.
1391
1392 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1393
1394         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1395         '-')" and "else if".
1396         (stap_parse_single_operand): Join checks for
1397         "gdbarch_stap_parse_special_token_p" and
1398         "gdbarch_stap_parse_special_token" in the same "if" statement.
1399         Invert check when verifying for operation on register
1400         displacement.
1401
1402 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1403
1404         * stap-probe.c (stap_get_opcode): Update comment.
1405         (stap_get_expected_argument_type): Likewise.
1406         (handle_stap_probe): Likewise.
1407
1408 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1409
1410         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1411         return type to 'bool'.  Adjust comment.  Use 'bool' when
1412         appropriate.
1413         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1414         * stap-probe.c (stap_parse_argument_1): Likewise.
1415         (stap_is_operator): Likewise.
1416         (stap_is_generic_prefix): Likewise.
1417         (stap_is_register_prefix): Likewise.
1418         (stap_is_register_indirection_prefix): Likewise.
1419         (stap_is_integer_prefix): Likewise.
1420         (stap_generic_check_suffix): Likewise.
1421         (stap_check_integer_suffix): Likewise.
1422         (stap_check_register_suffix): Likewise.
1423         (stap_check_register_indirection_suffix): Likewise.
1424         (stap_parse_register_operand): Likewise.
1425         (stap_parse_single_operand): Likewise.
1426         (stap_parse_argument_1): Likewise.
1427         (stap_probe::get_argument_count): Likewise.
1428         (stap_is_operator): Likewise.
1429
1430 2019-05-16  Tom Tromey  <tromey@adacore.com>
1431
1432         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1433         keyword to foreach.
1434
1435 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1436
1437         * linux-thread-db.c (try_thread_db_load_1): Change return type
1438         to bool.
1439         (try_thread_db_load): Likewise.
1440         (try_thread_db_load_from_pdir_1): Likewise.
1441         (try_thread_db_load_from_pdir): Likewise.
1442         (try_thread_db_load_from_sdir): Likewise.
1443         (try_thread_db_load_from_dir): Likewise.
1444         (thread_db_load_search): Likewise.
1445         (has_libpthread): Likewise.
1446         (thread_db_load): Likewise.
1447
1448 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1449
1450         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1451         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1452         NULL, and complain/return if that's the case.
1453
1454 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1455
1456         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1457         (advance, posn, abstract_read_memory): New functions.
1458         [struct mem_read_abstraction]: New struct.
1459         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1460
1461 2019-05-14  Tom Tromey  <tromey@adacore.com>
1462
1463         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1464         value is not lval_memory.
1465
1466 2019-05-14  Tom Tromey  <tromey@adacore.com>
1467
1468         * solib.c (info_sharedlibrary_command): Style the file name.
1469
1470 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1471
1472         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1473         (aarch64_vnv_type): Likewise.
1474         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1475         * common/tdesc.c: Likewise.
1476         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1477         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1478         * features/aarch64-fpu.xml: Add ieee half view.
1479         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1480         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1481         * gdbtypes.h (struct builtin_type): Likewise.
1482         (struct objfile_type): Likewise.
1483
1484 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1485
1486         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1487         typo.
1488         * location.h (string_to_event_location): Likewise.
1489
1490 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1491
1492         GDB 8.3 released.
1493
1494 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1495
1496         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1497         New variable declaration.
1498         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1499         New variable.
1500         (print_one_breakpoint): Use ui_out::test_flags and new global
1501         variable to compute use_fixed_output.
1502         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1503         Remove.
1504         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1505         (mi_multi_location_breakpoint_output_fixed): Remove.
1506         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1507         new variable.
1508         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1509         fix_multi_location_breakpoint_output flag if version >= 3.
1510         * ui-out.h (enum ui_out_flag)
1511         <fix_multi_location_breakpoint_output>: New enumerator.
1512
1513 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1514
1515         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1516
1517 2019-05-10  Tom Tromey  <tromey@adacore.com>
1518
1519         * ada-lang.c (catch_ada_completer): New function.
1520         (_initialize_ada_language): Use it.
1521
1522 2019-05-10  Tom Tromey  <tromey@adacore.com>
1523
1524         * thread.c (print_thread_info): Make "requested_threads" const.
1525         * gdbthread.h (print_thread_info): Make "requested_threads"
1526         const.
1527         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1528         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1529
1530 2019-05-08  Tom Tromey  <tom@tromey.com>
1531
1532         * gdbtypes.c (objfile_type_data): Change type.
1533         (objfile_type, _initialize_gdbtypes): Update.
1534
1535 2019-05-08  Tom Tromey  <tom@tromey.com>
1536
1537         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1538         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1539         (_initialize_dwarf2_frame): Update.
1540
1541 2019-05-08  Tom Tromey  <tom@tromey.com>
1542
1543         * objc-lang.c (objc_objfile_data): Change type.
1544         (find_methods): Update.
1545         (_initialize_objc_lang): Remove.
1546
1547 2019-05-08  Tom Tromey  <tom@tromey.com>
1548
1549         * stabsread.c (rs6000_builtin_type_data): Change type.
1550         (rs6000_builtin_type, _initialize_stabsread): Update.
1551
1552 2019-05-08  Tom Tromey  <tom@tromey.com>
1553
1554         * mips-tdep.c (mips_pdr_data): Remove.
1555         (_initialize_mips_tdep): Update.
1556
1557 2019-05-08  Tom Tromey  <tom@tromey.com>
1558
1559         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1560         (hppa_init_objfile_priv_data, read_unwind_info)
1561         (find_unwind_entry, _initialize_hppa_tdep): Update.
1562
1563 2019-05-08  Tom Tromey  <tom@tromey.com>
1564
1565         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1566         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1567         on obstack.
1568         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1569
1570 2019-05-08  Tom Tromey  <tom@tromey.com>
1571
1572         * mdebugread.c (basic_type_data): Change type.
1573         (basic_type, _initialize_mdebugread): Update.
1574
1575 2019-05-08  Tom Tromey  <tom@tromey.com>
1576
1577         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1578
1579 2019-05-08  Tom Tromey  <tom@tromey.com>
1580
1581         * nto-tdep.c (nto_inferior_data_reg): Change type.
1582         (nto_inferior_data): Update.
1583         (nto_inferior_data_cleanup, nto_new_inferior_data)
1584         (_initialize_nto_tdep): Remove.
1585         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1586
1587 2019-05-08  Tom Tromey  <tom@tromey.com>
1588
1589         * ada-lang.c (struct ada_inferior_data): Add initializers.
1590         (ada_inferior_data): Change type.
1591         (ada_inferior_data_cleanup): Remove.
1592         (get_ada_inferior_data, ada_inferior_exit)
1593         (struct ada_pspace_data): Add initializers, destructor.
1594         (ada_pspace_data_handle): Change type.
1595         (get_ada_pspace_data): Update.
1596         (ada_pspace_data_cleanup): Remove.
1597
1598 2019-05-08  Tom Tromey  <tom@tromey.com>
1599
1600         * coffread.c (struct coff_symfile_info): Add initializers.
1601         (coff_objfile_data_key): Move lower.  Change type.
1602         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1603         Update.
1604         (coff_free_info): Remove.
1605
1606 2019-05-08  Tom Tromey  <tom@tromey.com>
1607
1608         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1609         (fbsd_pspace_data_handle): Move lower.  Change type.
1610         (get_fbsd_pspace_data): Update.
1611         (fbsd_pspace_data_cleanup): Remove.
1612         (_initialize_fbsd_tdep): Update.
1613
1614 2019-05-08  Tom Tromey  <tom@tromey.com>
1615
1616         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1617         (get_ada_tasks_pspace_data): Update.
1618         (ada_tasks_pspace_data_cleanup): Remove.
1619         (_initialize_tasks): Update.
1620         (ada_tasks_inferior_data_handle): Change type.
1621         (get_ada_tasks_inferior_data): Update.
1622         (ada_tasks_inferior_data_cleanup): Remove.
1623         (struct ada_tasks_pspace_data): Add initializers.
1624
1625 2019-05-08  Tom Tromey  <tom@tromey.com>
1626
1627         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1628         * symfile-debug.c (debug_sym_get_probes): Change type.
1629         * stap-probe.c (handle_stap_probe):
1630         (stap_static_probe_ops::get_probes): Change type.
1631         * probe.h (class static_probe_ops) <get_probes>: Change type.
1632         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1633         (parse_probes_in_pspace): Update.
1634         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1635         Update.
1636         (any_static_probe_ops::get_probes): Change type.
1637         * elfread.c (elfread_data): New typedef.
1638         (probe_key): Change type.
1639         (elf_get_probes): Likewise.  Update.
1640         (probe_key_free): Remove.
1641         (_initialize_elfread): Update.
1642         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1643         Change type.
1644         (dtrace_process_dof_probe, dtrace_process_dof)
1645         (dtrace_static_probe_ops::get_probe): Change type.
1646
1647 2019-05-08  Tom Tromey  <tom@tromey.com>
1648
1649         * xcoffread.c (struct xcoff_symfile_info): Rename from
1650         coff_symfile_info.  Add initializers.
1651         (xcoff_objfile_data_key): Move lower.  Change type.
1652         (XCOFF_DATA): Rewrite.
1653         (xcoff_free_info): Remove.
1654         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1655         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1656         (xcoff_initial_scan): Update.
1657
1658 2019-05-08  Tom Tromey  <tom@tromey.com>
1659
1660         * solib-svr4.c (struct svr4_info): Add initializers and
1661         destructor.
1662         <probes_table>: Now an htab_up.
1663         (solib_svr4_pspace_data): Change type.
1664         (free_probes_table): Simplify.
1665         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1666         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1667         (probes_table_remove_objfile_probes, register_solib_event_probe)
1668         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1669         (_initialize_svr4_solib): Update.
1670
1671 2019-05-08  Tom Tromey  <tom@tromey.com>
1672
1673         * remote.c (remote_pspace_data): Change type.
1674         (remote_pspace_data_cleanup): Remove.
1675         (get_remote_exec_file, set_pspace_remote_exec_file)
1676         (_initialize_remote): Update.
1677
1678 2019-05-08  Tom Tromey  <tom@tromey.com>
1679
1680         * breakpoint.c (breakpoint_objfile_key): Change type.
1681         (get_breakpoint_objfile_data): Update.
1682         (free_breakpoint_objfile_data): Remove.
1683         (_initialize_breakpoint): Update.
1684
1685 2019-05-08  Tom Tromey  <tom@tromey.com>
1686
1687         * linux-tdep.c (struct linux_info): Add initializers.
1688         (linux_inferior_data): Move.  Change type.
1689         (invalidate_linux_cache_inf): Update.
1690         (linux_inferior_data_cleanup): Remove.
1691         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1692
1693 2019-05-08  Tom Tromey  <tom@tromey.com>
1694
1695         * auxv.c (auxv_inferior_data): Move.  Change type.
1696         (auxv_inferior_data_cleanup): Remove.
1697         (invalidate_auxv_cache_inf): Rewrite.
1698         (get_auxv_inferior_data, _initialize_auxv): Update.
1699
1700 2019-05-08  Tom Tromey  <tom@tromey.com>
1701
1702         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1703         (symfile_debug_objfile_data_key): Change type.
1704         (symfile_debug_installed, debug_qf_has_symbols)
1705         (debug_qf_find_last_source_symtab)
1706         (debug_qf_forget_cached_source_info)
1707         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1708         (debug_qf_print_stats, debug_qf_dump)
1709         (debug_qf_expand_symtabs_for_function)
1710         (debug_qf_expand_all_symtabs)
1711         (debug_qf_expand_symtabs_with_fullname)
1712         (debug_qf_map_matching_symbols)
1713         (debug_qf_expand_symtabs_matching)
1714         (debug_qf_find_pc_sect_compunit_symtab)
1715         (debug_qf_map_symbol_filenames)
1716         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1717         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1718         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1719         (debug_sym_read_linetable, debug_sym_relocate): Update.
1720         (symfile_debug_free_objfile): Remove.
1721         (install_symfile_debug_logging, _initialize_symfile_debug):
1722         Update.
1723
1724 2019-05-08  Tom Tromey  <tom@tromey.com>
1725
1726         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1727         allocate_on_obstack.
1728         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1729         (get_dwarf2_per_objfile): Update.
1730         (set_dwarf2_per_objfile): Remove.
1731         (dwarf2_has_info, dwarf2_get_section_info): Update.
1732         (dwarf2_free_objfile): Remove.
1733         (_initialize_dwarf2_read): Update.
1734
1735 2019-05-08  Tom Tromey  <tom@tromey.com>
1736
1737         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1738         initializers.
1739         <unsupported_script_warning_printed,
1740         script_not_found_warning_printed>: Now bool.
1741         (auto_load_pspace_data): Change type.
1742         (~auto_load_pspace_info): Rename from
1743         auto_load_pspace_data_cleanup.
1744         (get_auto_load_pspace_data, init_loaded_scripts_info)
1745         (clear_section_scripts, maybe_print_unsupported_script_warning)
1746         (maybe_print_script_not_found_warning, _initialize_auto_load):
1747         Update.
1748
1749 2019-05-08  Tom Tromey  <tom@tromey.com>
1750
1751         * objfiles.c (objfile_pspace_info): Add destructor and
1752         initializers.
1753         (objfiles_pspace_data): Change type.
1754         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1755         (get_objfile_pspace_data): Update.
1756         (objfiles_bfd_data): Change type.
1757         (get_objfile_bfd_data): Update.
1758         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1759
1760 2019-05-08  Tom Tromey  <tom@tromey.com>
1761
1762         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1763         Change type.
1764         (get_catch_syscall_inferior_data): Update.
1765         (catch_syscall_inferior_data_cleanup): Remove.
1766         (_initialize_break_catch_syscall): Update.
1767
1768 2019-05-08  Tom Tromey  <tom@tromey.com>
1769
1770         * inflow.c (struct terminal_info): Add destructor and
1771         initializers.
1772         (inflow_inferior_data): Change type.
1773         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1774         (get_inflow_inferior_data, inflow_inferior_exit)
1775         (swap_terminal_info, _initialize_inflow): Update.
1776
1777 2019-05-08  Tom Tromey  <tom@tromey.com>
1778
1779         * target-dcache.c (target_dcache_cleanup): Remove.
1780         (target_dcache_aspace_key): Change type.
1781         (target_dcache_init_p, target_dcache_invalidate)
1782         (target_dcache_get, target_dcache_get_or_init)
1783         (_initialize_target_dcache): Update.
1784         * dcache.h (struct dcache_deleter): New.
1785
1786 2019-05-08  Tom Tromey  <tom@tromey.com>
1787
1788         * symtab.c (struct symbol_cache): Add destructor and
1789         initializers.
1790         (symbol_cache_key): Move.  Change type.
1791         (make_symbol_cache, free_symbol_cache): Remove.
1792         (get_symbol_cache): Update.
1793         (symbol_cache_cleanup): Remove.
1794         (ALL_PSPACES, symbol_cache_flush)
1795         (maintenance_print_symbol_cache)
1796         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1797         Update.
1798
1799 2019-05-08  Tom Tromey  <tom@tromey.com>
1800
1801         * symtab.c (struct main_info): Add destructor and initializers.
1802         (main_progspace_key): Move.  Change type.
1803         (get_main_info): Update.
1804         (main_info_cleanup): Remove.
1805         (_initialize_symtab): Update.
1806
1807 2019-05-08  Tom Tromey  <tom@tromey.com>
1808
1809         * registry.h (DECLARE_REGISTRY): Define the _key class.
1810
1811 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1812
1813         * NEWS: Merge two 'New commands' sections.
1814
1815 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1816
1817         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1818         parameter and use Ada language definition instead.
1819         (ada_val_print_ptr): Remove unused language parameter.
1820         (ada_val_print_num): Remove language parameter and use Ada language
1821         definition instead.
1822         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1823         parameter.
1824         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1825         parameter and use Ada language definition instead.
1826         (ada_val_print_1): Update all ada_val_print_xxx calls.
1827         Remove language parameter.
1828         (ada_val_print): Update ada_val_print_1 call.
1829
1830 2019-05-08  Tom Tromey  <tromey@adacore.com>
1831
1832         * remote.c (remote_hw_watchpoint_limit)
1833         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1834         Now static.
1835
1836 2019-05-08  Tom Tromey  <tromey@adacore.com>
1837
1838         * maint.c (_initialize_maint_cmds): Move initialization code to
1839         remote.c.
1840         (watchdog, show_watchdog): Move to remote.c.
1841         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1842         "watchdog" static.
1843         (_initialize_remote): Move initialization code from maint.c.
1844         * defs.h (watchdog): Don't declare.
1845
1846 2019-05-08  Tom Tromey  <tromey@adacore.com>
1847
1848         * tui/tui-interp.c: Include main.h.
1849         * interps.c: Include main.h.
1850         * main.h (interpreter_p): Declare.
1851         * defs.h (interpreter_p): Don't declare.
1852
1853 2019-05-08  Tom Tromey  <tromey@adacore.com>
1854
1855         * dwarf2loc.c: Include dwarf2read.h.
1856         * defs.h (read_unsigned_leb128): Don't declare.
1857         * dwarf2read.h (read_unsigned_leb128): Declare.
1858
1859 2019-05-08  Tom Tromey  <tromey@adacore.com>
1860
1861         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1862         method.
1863
1864 2019-05-08  Tom Tromey  <tromey@adacore.com>
1865
1866         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1867         when no wrap column is set.
1868
1869 2019-05-08  Tom Tromey  <tromey@adacore.com>
1870
1871         * c-lang.c (c_get_string): Handle non-C-style arrays.
1872
1873 2019-05-08  Tom Tromey  <tromey@adacore.com>
1874
1875         * typeprint.c (print_offset_data::update): Print the bit offset,
1876         not the number of bits remaining.
1877
1878 2019-05-08  Tom Tromey  <tromey@adacore.com>
1879
1880         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1881         padding at end of comment.
1882
1883 2019-05-08  Tom Tromey  <tromey@adacore.com>
1884
1885         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1886         Compare main types.
1887
1888 2019-05-06  Tom Tromey  <tom@tromey.com>
1889
1890         * common/scoped_mmap.c: Include common-defs.h.
1891         * common/scoped_mmap.h: Don't include config.h.
1892
1893 2019-05-04  Tom Tromey  <tom@tromey.com>
1894
1895         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1896         (struct aarch64_call_info): Add initializers.
1897         <si>: Now a std::vector.
1898         (pass_on_stack, aarch64_push_dummy_call): Update.
1899
1900 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1901             Tom Tromey  <tom@tromey.com>
1902
1903         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1904         (ppc_threads): Now a std::vector.  Now static.
1905         (hwdebug_find_thread_points_by_tid)
1906         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1907         Update.
1908
1909 2019-05-04  Tom Tromey  <tom@tromey.com>
1910
1911         * arc-tdep.c (arc_tdesc_init): Return bool.
1912
1913 2019-05-04  Tom Tromey  <tom@tromey.com>
1914
1915         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1916         Use gdb_assert_not_reached.
1917
1918 2019-05-04  Tom Tromey  <tom@tromey.com>
1919
1920         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1921         "false".
1922
1923 2019-05-04  Tom Tromey  <tom@tromey.com>
1924
1925         * arc-tdep.c (arc_tdesc_init): Use bool.
1926
1927 2019-05-04  Tom Tromey  <tom@tromey.com>
1928
1929         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1930
1931 2019-05-04  Tom Tromey  <tom@tromey.com>
1932
1933         * cli/cli-cmds.c (valid_command_p): Return bool.
1934
1935 2019-05-04  Tom Tromey  <tom@tromey.com>
1936
1937         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1938         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1939
1940 2019-05-04  Raul Tambre  <raul@tambre.ee>
1941
1942         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1943         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1944         operator for comparison.
1945
1946 2019-05-04  Tom Tromey  <tom@tromey.com>
1947
1948         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1949         (lookup_partial_symbol, print_partial_symbols)
1950         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1951         (psymbol_compare): Update.
1952         (add_psymbol_to_bcache): Clear the entire psymbol.
1953         (maintenance_check_psymtabs): Update.
1954         * psympriv.h (struct partial_symbol): Don't derive from
1955         general_symbol_info.
1956         <obj_section, unrelocated_address, address,
1957         set_unrelocated_address>: Update.
1958         <ginfo>: New member.
1959         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1960         (debug_names::write_psymbols): Update.
1961
1962 2019-05-04  Tom de Vries  <tdevries@suse.de>
1963
1964         * contrib/cc-with-tweaks.sh: Support -n arg.
1965
1966 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1967
1968         * corelow.c (core_target::detach): Ensure frame cache and
1969         register caches are cleared.
1970         inferior.c (exit_inferior_1): Likewise.
1971
1972 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1973             Tom Tromey  <tom@tromey.com>
1974
1975         * dictionary.c (collate_pending_symbols_by_language): Remove
1976         "struct" from foreach.
1977         * symtab.c (lookup_global_symbol_from_objfile)
1978         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1979         foreach.
1980         * ser-tcp.c (net_open): Remove "struct" from foreach.
1981         * objfiles.c (objfile_relocate, objfile_rebase)
1982         (objfile_has_symbols): Remove "struct" from foreach.
1983         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1984         from foreach.
1985         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1986         foreach.
1987         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1988         "struct" from foreach.
1989         * ada-lang.c (create_excep_cond_exprs)
1990         (ada_exception_catchpoint_cond_string): Remove "struct" from
1991         foreach.
1992
1993 2019-05-03  Tom Tromey  <tromey@adacore.com>
1994
1995         * ada-exp.y (convert_char_literal): Check suffix of each
1996         enumerator.
1997
1998 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1999
2000         PR ada/21406:
2001         * ada-exp.y (yywrap): Don't define.
2002         * ada-lex.l (%option): Add noyywrap
2003         (yywrap): Remove.
2004
2005 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2006
2007         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2008         _WIN32_WINNT to the XP level, unless already defined to a higher
2009         level.
2010
2011         * unittests/parse-connection-spec-selftests.c:
2012         * ser-tcp.c:
2013         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2014         override.
2015
2016         * symfile.c (find_separate_debug_file): Remove colon from the
2017         drive spec of DOS/Windows file names of the target, so that the
2018         file name produced from DEBUGDIR and the target's directory will
2019         be valid on DOS/Windows systems.
2020
2021 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2022
2023         * rust-lang.c (val_print_struct): Handle printing structures
2024         containing strings.
2025
2026 2019-05-02  Tom Tromey  <tromey@adacore.com>
2027
2028         * valarith.c (_initialize_valarith): Remove.
2029
2030 2019-05-01  Tom Tromey  <tromey@adacore.com>
2031
2032         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2033         bitfields.
2034
2035 2019-05-01  Tom Tromey  <tromey@adacore.com>
2036
2037         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2038         for big-endian copies.
2039
2040 2019-04-30  Ali Tamur  <tamur@google.com>
2041         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2042         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2043         (read_3_bytes): New function.
2044
2045 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2046
2047         * windows-nat.c (main_thread_id): Delete.
2048         (handle_output_debug_string): Replace main_thread_id by
2049         current_event.dwThreadId.
2050         (fake_create_process): Likewise.
2051         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2052         Do not set main_thread_id.
2053         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2054         current_event.dwThreadId.
2055         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2056
2057 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2058
2059         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2060         Use current_event.dwThreadId instead of main_thread_id.
2061
2062 2019-04-30  Tom Tromey  <tromey@adacore.com>
2063
2064         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2065         (create_excep_cond_exprs): Iterate over program spaces.
2066         (ada_exception_catchpoint_cond_string): Examine all minimal
2067         symbols for exception types.
2068
2069 2019-04-30  Tom Tromey  <tromey@adacore.com>
2070
2071         PR c++/24470:
2072         * dwarf2read.c (process_structure_scope): Handle case where type
2073         has template parameters but no symbol was created.
2074
2075 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2076             Chris January  <chris.january@arm.com>
2077
2078         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2079         qualifier.
2080         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2081
2082 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * f-typeprint.c (f_print_type): Update rules for printing
2085         whitespace.
2086         (f_type_print_varspec_suffix): Likewise.
2087
2088 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2089             Chris January  <chris.january@arm.com>
2090
2091         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2092         function arguments.
2093
2094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2095
2096         * f-lang.c (build_fortran_types): Change name of void type to
2097         lower case.
2098         * f-typeprint.c (f_type_print_base): Print the name of the void
2099         type, rather than a fixed string.
2100         * f-valprint.c (f_decorations): Use lower case void string.
2101
2102 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2103             Chris January  <chris.january@arm.com>
2104
2105         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2106         types for Fortran.
2107
2108 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2109             Chris January  <chris.january@arm.com>
2110             David Lecomber  <david.lecomber@arm.com>
2111
2112         * f-exp.y (BINOP_INTRINSIC): New token.
2113         (exp): New parser rule handling BINOP_INTRINSIC.
2114         (f77_keywords): Add new builtin procedures.
2115         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2116         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2117         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2118         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2119         (print_unop_subexp_f): New function.
2120         (print_binop_subexp_f): New function.
2121         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2122         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2123         (dump_subexp_body_f): Likewise.
2124         (operator_check_f): Likewise.
2125         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2126         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2127
2128 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2129
2130         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2131         UNOP_KIND.
2132         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2133         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2134         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2135         (operator_length_f): New fuction.
2136         (print_subexp_f): New function.
2137         (op_name_f): New function.
2138         (dump_subexp_body_f): New function.
2139         (operator_check_f): New function.
2140         (exp_descriptor_f): Replace standard expression handling functions
2141         with new functions.
2142         * gdb/fortran-operator.def: New file.
2143         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2144         * gdb/std-operator.def: Remove UNOP_KIND.
2145
2146 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2147
2148         * std-operator.def: Remove unbalanced, stray double quote
2149         character.
2150
2151 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2152             Chris January  <chris.january@arm.com>
2153             Daniel Everett  <daniel.everett@arm.com>
2154             Nick Forrington  <nick.forrington@arm.com>
2155             Richard Bunt  <richard.bunt@arm.com>
2156
2157         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2158         of depth when printing anonymous structs or unions.
2159         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2160         Don't print either the top-level value, or the children if the
2161         max-depth is exceeded.
2162         (ppscm_print_children): When printing the key of a map, allow one
2163         extra level of depth.
2164         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2165         print either the top-level value, or the children if the max-depth
2166         is exceeded.
2167         (print_children): When printing the key of a map, allow one extra
2168         level of depth.
2169         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2170         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2171         (user_print_options): Initialise max_depth field.
2172         (val_print_scalar_or_string_type_p): New function.
2173         (val_print): Check to see if the max depth has been reached.
2174         (val_print_check_max_depth): Define new function.
2175         (show_print_max_depth): New function.
2176         (_initialize_valprint): Add 'print max-depth' option.
2177         * valprint.h (struct value_print_options) <max_depth>: New field.
2178         (val_print_check_max_depth): Declare new function.
2179         * NEWS: Document new feature.
2180
2181 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2182
2183         * ada-lang.c (ada_language_defn): Initialise new field.
2184         * c-lang.c (c_is_string_type_p): New function.
2185         (c_language_defn): Initialise new field.
2186         (cplus_language_defn): Initialise new field.
2187         (asm_language_defn): Initialise new field.
2188         (minimal_language_defn): Initialise new field.
2189         * c-lang.h (c_is_string_type_p): Declare new function.
2190         * d-lang.c (d_language_defn): Initialise new field.
2191         * f-lang.c (f_is_string_type_p): New function.
2192         (f_language_defn): Initialise new field.
2193         * go-lang.c (go_is_string_type_p): New function.
2194         (go_language_defn): Initialise new field.
2195         * language.c (default_is_string_type_p): New function.
2196         (unknown_language_defn): Initialise new field.
2197         (auto_language_defn): Initialise new field.
2198         * language.h (struct language_defn) <la_is_string_type_p>: New
2199         member variable.
2200         (default_is_string_type_p): Declare new function.
2201         * m2-lang.c (m2_language_defn): Initialise new field.
2202         * objc-lang.c (objc_language_defn): Initialise new field.
2203         * opencl-lang.c (opencl_language_defn): Initialise new field.
2204         * p-lang.c (pascal_is_string_type_p): New function.
2205         (pascal_language_defn): Initialise new field.
2206         * rust-lang.c (rust_is_string_type_p): New function.
2207         (rust_language_defn): Initialise new field.
2208
2209 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2212         New field.
2213         * ada-lang.c (ada_language_defn): Initialise new field.
2214         * c-lang.c (c_language_defn): Likewise.
2215         (cplus_language_defn): Likewise.
2216         (asm_language_defn): Likewise.
2217         (minimal_language_defn): Likewise.
2218         * d-lang.c (d_language_defn): Likewise.
2219         * f-lang.c (f_language_defn): Likewise.
2220         * go-lang.c (go_language_defn): Likewise.
2221         * language.c (unknown_language_defn): Likewise.
2222         (auto_language_defn): Likewise.
2223         * m2-lang.c (m2_language_defn): Likewise.
2224         * objc-lang.c (objc_language_defn): Likewise.
2225         * opencl-lang.c (opencl_language_defn): Likewise.
2226         * p-lang.c (pascal_language_defn): Likewise.
2227         * rust-lang.c (rust_language_defn): Likewise.
2228
2229 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2230
2231         * ada-lang.c (ada_is_character_type): Change return type to bool.
2232         (ada_is_string_type): Likewise.
2233         * ada-lang.h (ada_is_character_type): Update declaration
2234         (ada_is_string_type): Likewise.
2235
2236 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2237
2238         Support style in 'frame|thread apply'
2239
2240         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2241         * record.c (record_start, record_stop): Update callers of
2242         execute_command_to_string with false.
2243         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2244         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2245         methods.
2246         (class string_file): New constructor with term_out parameter.
2247         Override methods term_out and can_emit_style_escape.  New member
2248         term_out.
2249         (class stdio_file): Override can_emit_style_escape.
2250         (class tee_file): Override term_out and can_emit_style_escape.
2251         * utils.h (can_emit_style_escape): Remove.
2252         * utils.c (can_emit_style_escape): Likewise.
2253         Update all callers of can_emit_style_escape (SOMESTREAM) to
2254         SOMESTREAM->can_emit_style_escape.
2255         * source-cache.c (source_cache::get_source_lines): Likewise.
2256         * stack.c (frame_apply_command_count): Call execute_command_to_string
2257         passing the term_out characteristic of the current gdb_stdout.
2258         * thread.c (thr_try_catch_cmd): Likewise.
2259         * top.c (execute_command_to_string): pass term_out parameter
2260         to construct the string_file for the command output.
2261         * ui-file.c (term_cli_styling): New function (most code moved
2262         from utils.c can_emit_style_escape).
2263         (string_file::string_file, string_file::can_emit_style_escape,
2264         stdio_file::can_emit_style_escape, tee_file::term_out,
2265         tee_file::can_emit_style_escape): New functions.
2266
2267 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2268
2269         * NEWS: Mention the new set|show may-call-functions.
2270         * infcall.c (may_call_functions_p): New variable.
2271         (show_may_call_functions_p): New function.
2272         (call_function_by_hand_dummy): Throws an error if not
2273         may-call-functions.
2274         (_initialize_infcall): Call add_setshow_boolean_cmd for
2275         may-call-functions.
2276
2277 2019-04-25  Keith Seitz  <keiths@redhat.com>
2278
2279         PR c++/24367
2280         * cp-support.c (inspect_type): Don't attempt substitutions
2281         of symbol with the same name.
2282
2283 2019-04-25  Tom Tromey  <tromey@adacore.com>
2284
2285         PR gdb/24475:
2286         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2287         static.
2288
2289 2019-04-25  Tom Tromey  <tromey@adacore.com>
2290
2291         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2292         rvalue reference.
2293         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2294         (gdb_xml_parser::parse): Use std::move.
2295         * python/python-internal.h (gdbpy_convert_exception): Take a const
2296         reference.
2297         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2298         std::move.
2299         * python/py-utils.c (gdbpy_convert_exception): Take a const
2300         reference.
2301         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2302         Use std::move.
2303         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2304         Use std::move.
2305         * mi/mi-main.c (mi_print_exception): Take a const reference.
2306         * main.c (handle_command_errors): Take a const reference.
2307         * linespec.c (parse_linespec): Use std::move.
2308         * infcall.c (run_inferior_call): Use std::move.
2309         (call_function_by_hand_dummy): Use std::move.
2310         * exec.c (try_open_exec_file): Use std::move.
2311         * exceptions.h (exception_print, exception_fprintf)
2312         (exception_print_same): Update.
2313         * exceptions.c (print_exception, exception_print)
2314         (exception_fprintf, exception_print_same): Change parameters to
2315         const reference.
2316         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2317         * common/new-op.c: Use std::move.
2318         * common/common-exceptions.h (struct gdb_exception): Add move
2319         constructor.
2320         (struct gdb_exception_error, struct gdb_exception_quit, struct
2321         gdb_quit_bad_alloc): Change constructor to move constructor.
2322         (throw_exception): Change parameter to rvalue reference.
2323         * common/common-exceptions.c (throw_exception): Take rvalue
2324         reference.
2325         * cli/cli-interp.c (safe_execute_command): Use std::move.
2326         * breakpoint.c (insert_bp_location, location_to_sals): Use
2327         std::move.
2328
2329 2019-04-25  Tom Tromey  <tromey@adacore.com>
2330
2331         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2332         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2333         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2334         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2335         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2336         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2337         guile/scm-value.c: Use unpack.
2338         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2339         gdbscm_gdb_exception.
2340         (gdbscm_throw_gdb_exception): Likewise.
2341         (struct gdbscm_gdb_exception): New.
2342         (unpack): New function.
2343         (gdbscm_wrap): Use unpack.
2344
2345 2019-04-25  Tom Tromey  <tromey@adacore.com>
2346
2347         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2348         (gdb_rl_callback_handler): Use std::move.
2349         * common/common-exceptions.h (struct gdb_exception): Add move
2350         assignment operator.
2351         (throw_exception_sjlj): Change "exception" to const reference.
2352         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2353         (throw_exception_sjlj): Change "exception" to const reference.
2354
2355 2019-04-25  Tom Tromey  <tromey@adacore.com>
2356
2357         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2358         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2359         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2360         Update.
2361         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2362         Update.
2363         * mi/mi-interp.c (mi_interp::exec): Update.
2364         * linespec.c (parse_linespec): Update.
2365         * infcall.c (run_inferior_call): Update.
2366         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2367         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2368         (gdbscm_lookup_global_symbol): Update.
2369         * guile/scm-param.c (gdbscm_parameter_value): Update.
2370         * guile/scm-frame.c (gdbscm_frame_read_register)
2371         (gdbscm_frame_read_var): Update.
2372         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2373         * exec.c (try_open_exec_file): Update.
2374         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2375         (gdb_rl_callback_handler): Update.
2376         * common/common-exceptions.h (exception_none): Don't declare.
2377         * common/common-exceptions.c (exception_none): Don't define.
2378         (struct catcher) <exception>: Update.
2379         * cli/cli-interp.c (safe_execute_command): Update.
2380         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2381
2382 2019-04-25  Ali Tamur  <tamur@google.com>
2383
2384         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2385         (read_attribute_value): Likewise.
2386         (dwarf2_read_addr_index): Update comment.
2387         (read_str_index): Add DW_FORM_strx.
2388         (dwarf2_string_attr): Likewise.
2389         (dwarf2_const_value_attr): Likewise.
2390         (dump_die_shallow): Likewise.
2391         (dwarf2_fetch_constant_bytes): Likewise.
2392         (skip_form_bytes): Likewise.
2393         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2394
2395 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2396
2397         PR corefiles/11608
2398         PR corefiles/18187
2399         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2400         OFFSET.  Verify if current mapping contains an ELF header.
2401         (linux_find_memory_regions_full): Adjust call to
2402         dump_mapping_p.
2403
2404 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2405             Kang Li <kanglictf@gmail.com>
2406
2407         PR gdb/21600
2408
2409         * dwarf2-frame.c (read_initial_length): Be consistent about using
2410         unsigned representation of length.
2411         (decode_frame_entry_1): Likewise.  Check for wraparound of
2412         end pointer as well as buffer overflow.
2413
2414 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2415
2416         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2417         "vq".
2418
2419 2019-04-24  Tom Tromey  <tromey@adacore.com>
2420
2421         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2422
2423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * s12z-tdep.c (s12z_unwind_pc): Delete.
2426         (s12z_unwind_sp): Delete.
2427         (s12z_gdbarch_init): Don't register deleted functions with
2428         gdbarch.
2429
2430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         * rl78-tdep.c (rl78_unwind_sp): Delete.
2433         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2434
2435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2438         (xstormy16_unwind_pc): Delete.
2439         (xstormy16_dummy_id): Delete.
2440         (xstormy16_gdbarch_init): Don't register deleted functions with
2441         gdbarch.
2442
2443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2444
2445         * vax-tdep.c (vax_unwind_pc): Delete.
2446         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2447
2448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2449
2450         * v850-tdep.c (v850_unwind_sp): Delete.
2451         (v850_unwind_pc): Delete.
2452         (v850_dummy_id): Delete.
2453         (v850_gdbarch_init): Don't register deleted functions with
2454         gdbarch.
2455
2456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2457
2458         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2459         (tilegx_unwind_pc): Delete.
2460         (tilegx_unwind_dummy_id): Delete.
2461         (tilegx_gdbarch_init): Don't register deleted functions with
2462         gdbarch.
2463
2464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2465
2466         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2467         (tic6x_dummy_id): Delete.
2468         (tic6x_gdbarch_init): Don't register deleted functions with
2469         gdbarch.
2470
2471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2472
2473         * sparc-tdep.c (sparc_unwind_pc): Delete.
2474         (sparc32_gdbarch_init): Don't register deleted function with
2475         gdbarch.
2476
2477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2478
2479         * sh-tdep.c (sh_unwind_sp): Delete.
2480         (sh_unwind_pc): Delete.
2481         (sh_dummy_id): Delete.
2482         (sh_gdbarch_init): Don't register deleted functions with
2483         gdbarch.
2484
2485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2486
2487         * score-tdep.c (score_unwind_sp): Delete.
2488         (score_unwind_pc): Delete.
2489         (score_dummy_id): Delete.
2490         (score_gdbarch_init): Don't register deleted functions with
2491         gdbarch.
2492
2493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2494
2495         * rx-tdep.c (rx_unwind_pc): Delete.
2496         (rx_unwind_sp): Delete.
2497         (rx_dummy_id): Delete.
2498         (rx_gdbarch_init): Don't register deleted functions with
2499         gdbarch.  Update comment.
2500
2501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2502
2503         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2504         (rs6000_dummy_id): Delete.
2505         (rs6000_gdbarch_init): Don't register deleted functions with
2506         gdbarch.
2507
2508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2509
2510         * or1k-tdep.c (or1k_dummy_id): Delete.
2511         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2512
2513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * nios2-tdep.c (nios2_dummy_id): Delete.
2516         (nios2_unwind_sp): Delete.
2517         (nios2_gdbarch_init): Don't register deleted functions with
2518         gdbarch.
2519
2520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * nds32-tdep.c (nds32_dummy_id): Delete.
2523         (nds32_unwind_pc): Delete.
2524         (nds32_unwind_sp): Delete.
2525         (nds32_gdbarch_init): Don't register deleted functions with
2526         gdbarch.
2527
2528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2529
2530         * msp430-tdep.c (msp430_unwind_pc): Delete.
2531         (msp430_unwind_sp): Delete.
2532         (msp430_dummy_id): Delete.
2533         (msp430_gdbarch_init): Don't register deleted functions with
2534         gdbarch.
2535
2536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2537
2538         * moxie-tdep.c (moxie_unwind_sp): Delete.
2539         (moxie_unwind_pc): Delete.
2540         (moxie_dummy_id): Delete.
2541         (moxie_gdbarch_init): Don't register deleted functions with
2542         gdbarch.
2543
2544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2545
2546         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2547         (mn10300_unwind_pc): Delete.
2548         (mn10300_unwind_sp): Delete.
2549         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2550         mn10300_unwind_sp.
2551         (mn10300_frame_unwind_init): Don't register deleted functions with
2552         gdbarch.
2553
2554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2555
2556         * mep-tdep.c (mep_unwind_pc): Delete.
2557         (mep_unwind_sp): Delete.
2558         (mep_dummy_id): Delete.
2559         (mep_gdbarch_init): Don't register deleted functions with
2560         gdbarch.
2561
2562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2563
2564         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2565         (m68hc11_unwind_sp): Delete.
2566         (m68hc11_gdbarch_init): Don't register deleted functions with
2567         gdbarch.
2568
2569 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2570
2571         * m32r-tdep.c (m32r_unwind_sp): Delete.
2572         (m32r_unwind_pc): Delete.
2573         (m32r_dummy_id): Delete.
2574         (m32r_gdbarch_init): Don't register deleted functions with
2575         gdbarch.
2576
2577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2578
2579         * m32c-tdep.c (m32c_unwind_pc): Delete.
2580         (m32c_unwind_sp): Delete.
2581         (m32c_dummy_id): Delete.
2582         (m32c_gdbarch_init): Don't register deleted functions with
2583         gdbarch.
2584
2585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2586
2587         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2588         (lm32_unwind_pc): Delete.
2589         (lm32_dummy_id): Delete.
2590         (lm32_gdbarch_init): Don't register deleted functions with
2591         gdbarch.
2592
2593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2594
2595         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2596         (iq2000_unwind_pc): Delete.
2597         (iq2000_dummy_id): Delete.
2598         (iq2000_gdbarch_init): Don't register deleted functions with
2599         gdbarch.
2600
2601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2602
2603         * nds32-tdep.c (nds32_type_align): Delete.
2604         (nds32_push_dummy_call): Use type_align instead.
2605
2606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2607
2608         * arm-tdep.c (arm_type_align): Only handle vector override case.
2609         (arm_push_dummy_call): Use type_align.
2610         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2611
2612 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2613
2614         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2615         case.
2616         (pass_on_stack): Use type_align.
2617         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2618         function.
2619
2620 2019-04-23  Tom Tromey  <tromey@adacore.com>
2621
2622         * dwarf2read.c (line_header::file_name_at): Remove unused
2623         overload.
2624
2625 2019-04-23  Tom de Vries  <tdevries@suse.de>
2626
2627         PR gdb/24438
2628         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2629         invocation.
2630
2631
2632 2019-03-27  Ali Tamur  <tamur@google.com>
2633
2634         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2635         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2636         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2637         (dwarf_expr_context::get_addr_index): Likewise
2638         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2639         (symbol_needs_eval_context::get_addr_index): Likewise
2640         (disassemble_dwarf_expression): Add DW_OP_addrx
2641         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2642         (read_cutu_die_from_dwo): Update comment
2643         (skip_one_die): Add DW_FORM_addrx
2644         (read_attribute_value): Likewise
2645         (var_decode_location): Add DW_OP_addrx
2646         (dwarf2_const_value_attr): Add DW_FORM_addrx
2647         (dump_die_shallow): Likewise
2648         (dwarf2_fetch_constant_bytes): Likewise
2649         (decode_locdesc): Add DW_OP_addrx
2650         (skip_form_bytes): Add DW_FORM_addrx
2651
2652 2019-04-22  Ali Tamur  <tamur@google.com>
2653
2654         * MAINTAINERS (Write After Approval): Add self.
2655
2656 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2657
2658         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2659         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2660         (open_symbol_file_object): Likewise.
2661         (svr4_default_sos): Add info parameter.
2662         (svr4_read_so_list): Likewise.
2663         (svr4_current_sos_direct): Adjust functions calls to pass down
2664         info.
2665         (svr4_current_sos_1): Add info parameter.
2666         (svr4_current_sos): Call get_svr4_info, pass info down to
2667         svr4_current_sos_1.
2668         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2669         get_svr4_info.
2670         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2671         get_svr4_info.
2672         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2673         to get_svr4_info.
2674         (probes_table_remove_objfile_probes): Likewise.
2675         (register_solib_event_probe): Add info parameter.
2676         (solist_update_incremental): Pass info parameter down to
2677         svr4_read_so_list.
2678         (disable_probes_interface): Add info parameter.
2679         (svr4_handle_solib_event): Pass current_program_space to
2680         get_svr4_info.  Adjust disable_probes_interface cleanup.
2681         (svr4_create_probe_breakpoints): Add info parameter, pass it
2682         down to register_solib_event_probe.
2683         (svr4_create_solib_event_breakpoints): Add info parameter,
2684         pass it down to svr4_create_probe_breakpoints.
2685         (enable_break): Pass info down to
2686         svr4_create_solib_event_breakpoints.
2687         (svr4_solib_create_inferior_hook): Pass current_program_space to
2688         get_svr4_info.
2689         (svr4_clear_solib): Likewise.
2690
2691 2019-04-22  Pedro Alves  <palves@redhat.com>
2692
2693         * solib-svr4.c (svr4_free_objfile_observer): New.
2694         (probe_and_action::objfile): New field.
2695         (probes_table_htab_remove_objfile_probes)
2696         (probes_table_remove_objfile_probes): New functions.
2697         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2698         in the new probe_and_action.  Don't store the probe in 'lookup'.
2699         (svr4_create_probe_breakpoints): Pass objfile to
2700         register_solib_event_probe.
2701         (_initialize_svr4_solib): Register a free_objfile observer.
2702
2703 2019-04-19  Tom Tromey  <tom@tromey.com>
2704
2705         * common/queue.h: Remove.
2706
2707 2019-04-19  Tom Tromey  <tom@tromey.com>
2708
2709         * event-loop.c: Don't include "common/queue.h".
2710
2711 2019-04-19  Tom Tromey  <tom@tromey.com>
2712
2713         * remote.c (remote_target): Use delete.
2714         * remote-notif.h: Include <list>, not "common/queue.h".
2715         (notif_client_p): Remove typedef.
2716         (remote_notif_state): Add constructor, destructor, initializer.
2717         <notif_queue>: Now a std::list.
2718         (remote_notif_state_xfree): Don't declare.
2719         * remote-notif.c (remote_notif_process, handle_notification)
2720         (remote_notif_state_allocate): Update.
2721         (~remote_notif_state): Rename from remote_notif_state_xfree.
2722
2723 2019-04-19  Tom Tromey  <tom@tromey.com>
2724
2725         * symfile.c (reread_symbols): Update.
2726         * objfiles.c (objfile_register_static_link)
2727         (objfile_lookup_static_link): Update
2728         (~objfile) Don't delete static_links.
2729         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2730
2731 2019-04-19  Tom Tromey  <tom@tromey.com>
2732
2733         * type-stack.h (struct type_stack) <insert>: Constify string.
2734         * type-stack.c (type_stack::insert): Constify string.
2735         * gdbtypes.h (lookup_template_type): Update.
2736         (address_space_name_to_int): Update.
2737         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2738         const.
2739         (lookup_template_type): Make name const.
2740         * c-exp.y: Update rules.
2741         (lex_one_token, classify_name, classify_inner_name)
2742         (c_print_token): Update.
2743         * p-exp.y: Update rules.
2744         (yylex): Update.
2745         * f-exp.y: Update rules.
2746         (yylex): Update.
2747         * d-exp.y: Update rules.
2748         (lex_one_token, classify_name, classify_inner_name): Update.
2749         * parse.c (write_dollar_variable, copy_name): Return std::string.
2750         * parser-defs.h (copy_name): Change return type.
2751         * m2-exp.y: Update rules.
2752         (yylex): Update.
2753         * go-exp.y (lex_one_token): Update.
2754         Update rules.
2755         (classify_unsafe_function, classify_packaged_name)
2756         (classify_name, yylex): Update.
2757
2758 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2759
2760         * configure.ac: add --enable-source-highlight switch.
2761         * configure: Regenerate.
2762         * top.c (print_gdb_version): plumb --enable-source-highlight
2763         status to "show configuration".
2764
2765 2019-04-19  Tom Tromey  <tromey@adacore.com>
2766
2767         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2768         Check ADA_TYPE_P.
2769         (empty_record, ada_template_to_fixed_record_type_1)
2770         (template_to_static_fixed_type)
2771         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2772         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2773         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2774         macros.
2775
2776 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2777
2778         PR symtab/24423:
2779         * source.c (print_source_lines_base): Advance "iter" when a
2780         control character is seen.
2781
2782 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2783
2784         * inferior.h (struct infcall_suspend_state_deleter):
2785         Catch exception in destructor to avoid crash.
2786
2787 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2788
2789         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2790         close to the add_com "shell".
2791
2792 2019-04-18  Tom Tromey  <tromey@adacore.com>
2793
2794         * process-stratum-target.h (class process_stratum_target)
2795         <stratum>: Add "final".
2796
2797 2019-04-17  Tom Tromey  <tromey@adacore.com>
2798
2799         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2800         against nullptr before use.
2801
2802 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2803
2804         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2805
2806 2019-04-17  Jim Wilson  <jimw@sifive.com>
2807             Andrew Burgess  <andrew.burgess@embecosm.com>
2808
2809         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2810         code read might fail, assume 4-byte breakpoint in that case.
2811
2812 2019-04-15  Leszek Swirski  <leszeks@google.com>
2813
2814         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2815         rather than a hand-rolled POD check when checking for forced MEMORY
2816         classification.
2817
2818 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2819
2820         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2821         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2822         function.
2823         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2824         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2825         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2826         declaration.
2827
2828 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2829
2830         * aarch64-linux-nat.c
2831         (aarch64_linux_nat_target::thread_architecture): Add override.
2832         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2833         each VQ.
2834
2835 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2836
2837         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2838
2839 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2840
2841         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2842         target types of size 96-bits, add some additional comments, and
2843         check that the builtin type we found was the correct size.
2844
2845 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2846
2847         * utils.c (prompt_for_continue): Don't restore the styling at the
2848         end, as applied_style has the wrong value.  This fixes styling in
2849         long lists of file names that are interrupted by the "Continue?"
2850         prompt.
2851
2852 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2853
2854         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2855         * c-lang.c (c_language_defn): Likewise.
2856         (cplus_language_defn): Likewise.
2857         (asm_language_defn): Likewise.
2858         (minimal_language_defn): Likewise.
2859         * d-lang.c (d_language_defn): Likewise.
2860         * f-lang.c (f_language_defn): Likewise.
2861         * go-lang.c (go_language_defn): Likewise.
2862         * language.c (unknown_language_defn): Likewise.
2863         (auto_language_defn): Likewise.
2864         * language.h (struct language_defn): Remove la_magic field.
2865         (LANG_MAGIC): Delete.
2866         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2867         * objc-lang.c (objc_language_defn): Likewise.
2868         * opencl-lang.c (opencl_language_defn): Likewise.
2869         * p-lang.c (pascal_language_defn): Likewise.
2870         * rust-lang.c (rust_language_defn): Likewise.
2871
2872 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2873
2874         * riscv-tdep.c (riscv_type_align): New function.
2875         (riscv_type_alignment): Delete.
2876         (riscv_arg_location): Use 'type_align'.
2877         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2878
2879 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2880
2881         * gdbtypes.c (type_align): A struct with no non-static fields also
2882         has alignment of 1.
2883
2884 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2887         component to 0.
2888         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2889         member.
2890         (riscv_struct_info::analyse): New implementation using new
2891         analyse_inner member function.
2892         (riscv_struct_info::field_offset): New member function.
2893         (riscv_struct_info::m_offsets): New member variable.
2894         (riscv_struct_info::analyse_inner): New private member function,
2895         takes the old implementation of riscv_struct_info::analyse but
2896         extended to track field offsets.
2897         (riscv_call_arg_struct): Update the struct folding special cases
2898         to handle cases where empty C++ structs, which are non-zero
2899         length, are found.
2900         (riscv_arg_location): Initialise the length of each location, a
2901         non-zero length now indicates the location is in use.
2902         (riscv_push_dummy_call): Allow for the first location having a
2903         non-zero offset when setting up arguments.
2904         (riscv_return_value): Likewise, but for return values.
2905
2906 2019-04-11  Tom Tromey  <tromey@adacore.com>
2907
2908         * utils.c (internal_vproblem): Make "msg" const.
2909
2910 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2911
2912         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2913         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2914         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2915         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2916
2917 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2918
2919         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2920         function.
2921         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2922         of amd64_collect_native_gregset.
2923         (amd64_linux_nat_target::store_registers): Likewise.
2924
2925 2019-04-10  Tom Tromey  <tom@tromey.com>
2926
2927         * symtab.c (lookup_global_symbol_from_objfile)
2928         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2929         * objfiles.h (class separate_debug_iterator): New.
2930         (class separate_debug_range): New.
2931         (struct objfile) <separate_debug_objfiles>: New method.
2932         (objfile_separate_debug_iterate): Don't declare.
2933         * objfiles.c (separate_debug_iterator::operator++): Rename from
2934         objfile_separate_debug_iterate.
2935         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2936         iterator.
2937         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2938         iterator.
2939
2940 2019-04-10  Tom Tromey  <tom@tromey.com>
2941
2942         * symfile.c (reread_symbols): Remove old comment.
2943         * objfiles.c (free_all_objfiles): Fix a typo.
2944
2945 2019-04-10  Tom Tromey  <tom@tromey.com>
2946
2947         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2948         * minsyms.c (lookup_minimal_symbol): Use foreach.
2949         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2950         (lookup_minimal_symbol_solib_trampoline): Likewise.
2951         * symfile.c (reread_symbols): Use foreach.
2952
2953 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2954             Tom Tromey  <tromey@adacore.com>
2955
2956         PR rust/24414:
2957         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2958         (rust_lex_int_test): Change "value" to be LONGEST.
2959         (rust_lex_tests): Add test for long integer literal.
2960
2961 2019-04-09  Tom Tromey  <tromey@adacore.com>
2962
2963         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2964         to bool.
2965         (extended_remote_target::attach): Update.
2966         (remote_target::remote_notice_new_inferior): Update.
2967         (remote_target::add_current_inferior_and_thread): Update.
2968         * inferior.c (exit_inferior_1): Use "false".
2969         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2970
2971 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2972
2973         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2974         the "start" command.
2975
2976 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2977
2978         * python/py-inferior.c (infpy_thread_from_thread_handle):
2979         Adjust comments to reflect renaming of thread_from_thread_handle
2980         to thread_from_handle.  Adjust keywords.  Fix type error message.
2981         (inferior_object_methods): Add thread_from_handle.  Retain
2982         thread_from_thread_handle, but mark it as deprecated.
2983
2984 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2985
2986         * gdbthread.h (find_thread_by_handle): Revise declaration.
2987         * thread.c (find_thread_by_handle): Likewise.  Adjust
2988         implementation too.
2989         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2990         support for buffer objects as handles.
2991
2992 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2993
2994         * python/py-infthread.c (thpy_thread_handle): New function.
2995         (thread_object_methods): Register thpy_thread_handle.
2996
2997 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2998
2999         * gdbthread.h (thread_to_thread_handle): Declare.
3000         * thread.c (gdbtypes.h): Include.
3001         (thread_to_thread_handle): New function.
3002
3003         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3004         (target_thread_info_to_thread_handle): Declare.
3005         * target.c (target_thread_info_to_thread_handle): New function.
3006         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3007         * target-delegates.c: Regenerate.
3008
3009         * linux-thread-db.c (class thread_db_target): Add method
3010         thread_info_to_thread_handle.
3011         (thread_db_target::thread_info_to_thread_handle): Define.
3012         * remote.c (class remote_target): Add new method
3013         thread_info_to_thread_handle.
3014         (remote_target::thread_info_to_thread_handle): Define.
3015
3016 2019-04-08  Pedro Alves  <palves@redhat.com>
3017
3018         * common/common-exceptions.c (throw_exception): Don't create
3019         named object to throw; throw directly.
3020         (throw_it): Likewise.  Don't initialize gdb_exception::message
3021         here, with new; pass FMT and AP to the ctor instead.
3022         * common/common-exceptions.h: Include <string>.
3023         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3024         const char *, va_list)): New ctor.  Use std::make_shared.
3025         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3026         errors)): Delete.
3027         (gdb_exception_error::gdb_exception_error(enum errors, const char
3028         *, va_list)): New.
3029         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3030         Add assertion.
3031         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3032         errors)): Delete.
3033         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3034         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3035         Add assertion.
3036
3037 2019-04-08  Tom Tromey  <tom@tromey.com>
3038
3039         * valops.c (value_rtti_indirect_type): Replace throw_exception
3040         with throw.
3041         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3042         with throw.
3043         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3044         throw.
3045         * target.c (target_translate_tls_address): Replace throw_exception
3046         with throw.
3047         * stack.c (frame_apply_command_count): Replace throw_exception
3048         with throw.
3049         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3050         throw.
3051         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3052         with throw.
3053         * rs6000-tdep.c (rs6000_frame_cache)
3054         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3055         * remote.c: Replace throw_exception with throw.
3056         * record-full.c (record_full_message, record_full_wait_1)
3057         (record_full_restore): Replace throw_exception with throw.
3058         * record-btrace.c:
3059         (get_thread_current_frame_id, record_btrace_start_replaying)
3060         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3061         (cmd_record_btrace_start): Replace throw_exception with throw.
3062         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3063         throw.
3064         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3065         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3066         * linespec.c:
3067         (find_linespec_symbols): Replace throw_exception with throw.
3068         * infrun.c (displaced_step_prepare, resume): Replace
3069         throw_exception with throw.
3070         * infcmd.c (post_create_inferior): Replace throw_exception with
3071         throw.
3072         * inf-loop.c (inferior_event_handler): Replace throw_exception
3073         with throw.
3074         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3075         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3076         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3077         (get_prev_frame_always, get_frame_pc_if_available)
3078         (get_frame_address_in_block_if_available, get_frame_language):
3079         Replace throw_exception with throw.
3080         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3081         throw_exception with throw.
3082         * eval.c (fetch_subexp_value, evaluate_var_value)
3083         (evaluate_funcall, evaluate_subexp_standard): Replace
3084         throw_exception with throw.
3085         * dwarf2loc.c (call_site_find_chain)
3086         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3087         Replace throw_exception with throw.
3088         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3089         with throw.
3090         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3091         throw.
3092         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3093         * completer.c (complete_line_internal): Replace throw_exception
3094         with throw.
3095         * compile/compile-object-run.c (compile_object_run): Replace
3096         throw_exception with throw.
3097         * cli/cli-script.c (process_next_line): Replace throw_exception
3098         with throw.
3099         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3100         (btrace_enable, btrace_maint_update_pt_packets): Replace
3101         throw_exception with throw.
3102         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3103         throw_exception with throw.
3104         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3105         throw_exception with throw.
3106         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3107         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3108         * aarch64-tdep.c (aarch64_make_prologue_cache)
3109         (aarch64_make_stub_cache): Replace throw_exception with throw.
3110
3111 2019-04-08  Tom Tromey  <tom@tromey.com>
3112
3113         * common/common-exceptions.c (throw_exception): Rename from
3114         throw_exception_cxx.  Remove old copy.  Make argument const.
3115         (throw_it): Create and throw exception objects directly.
3116         * common/common-exceptions.h (throw_exception): Make argument
3117         const.
3118         (struct gdb_exception_error): Add constructor.
3119         (struct gdb_exception_quit): Add constructor.
3120
3121 2019-04-08  Tom Tromey  <tom@tromey.com>
3122
3123         * common/common-exceptions.h (exception_rethrow): Don't declare.
3124         (TRY_SJLJ): Update comment.
3125         (TRY, CATCH, END_CATCH): Remove.
3126         * common/common-exceptions.c (exception_rethrow): Remove.
3127
3128 2019-04-08  Tom Tromey  <tom@tromey.com>
3129
3130         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3131         Remove.
3132         (gdb_exception_error): Rename from
3133         gdb_exception_RETURN_MASK_ERROR.
3134         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3135         (gdb_quit_bad_alloc): Update.
3136         * aarch64-tdep.c: Update.
3137         * ada-lang.c: Update.
3138         * ada-typeprint.c: Update.
3139         * ada-valprint.c: Update.
3140         * amd64-tdep.c: Update.
3141         * arch-utils.c: Update.
3142         * break-catch-throw.c: Update.
3143         * breakpoint.c: Update.
3144         * btrace.c: Update.
3145         * c-varobj.c: Update.
3146         * cli/cli-cmds.c: Update.
3147         * cli/cli-interp.c: Update.
3148         * cli/cli-script.c: Update.
3149         * common/common-exceptions.c: Update.
3150         * common/new-op.c: Update.
3151         * common/selftest.c: Update.
3152         * compile/compile-c-symbols.c: Update.
3153         * compile/compile-cplus-symbols.c: Update.
3154         * compile/compile-object-load.c: Update.
3155         * compile/compile-object-run.c: Update.
3156         * completer.c: Update.
3157         * corelow.c: Update.
3158         * cp-abi.c: Update.
3159         * cp-support.c: Update.
3160         * cp-valprint.c: Update.
3161         * darwin-nat.c: Update.
3162         * disasm-selftests.c: Update.
3163         * dtrace-probe.c: Update.
3164         * dwarf-index-cache.c: Update.
3165         * dwarf-index-write.c: Update.
3166         * dwarf2-frame-tailcall.c: Update.
3167         * dwarf2-frame.c: Update.
3168         * dwarf2loc.c: Update.
3169         * dwarf2read.c: Update.
3170         * eval.c: Update.
3171         * event-loop.c: Update.
3172         * event-top.c: Update.
3173         * exec.c: Update.
3174         * f-valprint.c: Update.
3175         * fbsd-tdep.c: Update.
3176         * frame-unwind.c: Update.
3177         * frame.c: Update.
3178         * gdbtypes.c: Update.
3179         * gnu-v3-abi.c: Update.
3180         * guile/guile-internal.h: Update.
3181         * guile/scm-block.c: Update.
3182         * guile/scm-breakpoint.c: Update.
3183         * guile/scm-cmd.c: Update.
3184         * guile/scm-disasm.c: Update.
3185         * guile/scm-frame.c: Update.
3186         * guile/scm-lazy-string.c: Update.
3187         * guile/scm-math.c: Update.
3188         * guile/scm-param.c: Update.
3189         * guile/scm-ports.c: Update.
3190         * guile/scm-pretty-print.c: Update.
3191         * guile/scm-symbol.c: Update.
3192         * guile/scm-symtab.c: Update.
3193         * guile/scm-type.c: Update.
3194         * guile/scm-value.c: Update.
3195         * i386-linux-tdep.c: Update.
3196         * i386-tdep.c: Update.
3197         * inf-loop.c: Update.
3198         * infcall.c: Update.
3199         * infcmd.c: Update.
3200         * infrun.c: Update.
3201         * jit.c: Update.
3202         * language.c: Update.
3203         * linespec.c: Update.
3204         * linux-fork.c: Update.
3205         * linux-nat.c: Update.
3206         * linux-tdep.c: Update.
3207         * linux-thread-db.c: Update.
3208         * main.c: Update.
3209         * mi/mi-cmd-break.c: Update.
3210         * mi/mi-cmd-stack.c: Update.
3211         * mi/mi-interp.c: Update.
3212         * mi/mi-main.c: Update.
3213         * objc-lang.c: Update.
3214         * p-valprint.c: Update.
3215         * parse.c: Update.
3216         * ppc-linux-tdep.c: Update.
3217         * printcmd.c: Update.
3218         * python/py-arch.c: Update.
3219         * python/py-breakpoint.c: Update.
3220         * python/py-cmd.c: Update.
3221         * python/py-finishbreakpoint.c: Update.
3222         * python/py-frame.c: Update.
3223         * python/py-framefilter.c: Update.
3224         * python/py-gdb-readline.c: Update.
3225         * python/py-inferior.c: Update.
3226         * python/py-infthread.c: Update.
3227         * python/py-lazy-string.c: Update.
3228         * python/py-linetable.c: Update.
3229         * python/py-objfile.c: Update.
3230         * python/py-param.c: Update.
3231         * python/py-prettyprint.c: Update.
3232         * python/py-progspace.c: Update.
3233         * python/py-record-btrace.c: Update.
3234         * python/py-record.c: Update.
3235         * python/py-symbol.c: Update.
3236         * python/py-type.c: Update.
3237         * python/py-unwind.c: Update.
3238         * python/py-utils.c: Update.
3239         * python/py-value.c: Update.
3240         * python/python.c: Update.
3241         * record-btrace.c: Update.
3242         * record-full.c: Update.
3243         * remote-fileio.c: Update.
3244         * remote.c: Update.
3245         * riscv-tdep.c: Update.
3246         * rs6000-aix-tdep.c: Update.
3247         * rs6000-tdep.c: Update.
3248         * rust-exp.y: Update.
3249         * rust-lang.c: Update.
3250         * s390-tdep.c: Update.
3251         * selftest-arch.c: Update.
3252         * solib-dsbt.c: Update.
3253         * solib-frv.c: Update.
3254         * solib-spu.c: Update.
3255         * solib-svr4.c: Update.
3256         * solib.c: Update.
3257         * sparc64-linux-tdep.c: Update.
3258         * stack.c: Update.
3259         * symfile-mem.c: Update.
3260         * symmisc.c: Update.
3261         * target.c: Update.
3262         * thread.c: Update.
3263         * top.c: Update.
3264         * tracefile-tfile.c: Update.
3265         * tui/tui.c: Update.
3266         * typeprint.c: Update.
3267         * unittests/cli-utils-selftests.c: Update.
3268         * unittests/parse-connection-spec-selftests.c: Update.
3269         * valops.c: Update.
3270         * valprint.c: Update.
3271         * value.c: Update.
3272         * varobj.c: Update.
3273         * windows-nat.c: Update.
3274         * x86-linux-nat.c: Update.
3275         * xml-support.c: Update.
3276
3277 2019-04-08  Tom Tromey  <tom@tromey.com>
3278
3279         * xml-support.c: Use C++ exception handling.
3280         * x86-linux-nat.c: Use C++ exception handling.
3281         * windows-nat.c: Use C++ exception handling.
3282         * varobj.c: Use C++ exception handling.
3283         * value.c: Use C++ exception handling.
3284         * valprint.c: Use C++ exception handling.
3285         * valops.c: Use C++ exception handling.
3286         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3287         handling.
3288         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3289         * typeprint.c: Use C++ exception handling.
3290         * tui/tui.c: Use C++ exception handling.
3291         * tracefile-tfile.c: Use C++ exception handling.
3292         * top.c: Use C++ exception handling.
3293         * thread.c: Use C++ exception handling.
3294         * target.c: Use C++ exception handling.
3295         * symmisc.c: Use C++ exception handling.
3296         * symfile-mem.c: Use C++ exception handling.
3297         * stack.c: Use C++ exception handling.
3298         * sparc64-linux-tdep.c: Use C++ exception handling.
3299         * solib.c: Use C++ exception handling.
3300         * solib-svr4.c: Use C++ exception handling.
3301         * solib-spu.c: Use C++ exception handling.
3302         * solib-frv.c: Use C++ exception handling.
3303         * solib-dsbt.c: Use C++ exception handling.
3304         * selftest-arch.c: Use C++ exception handling.
3305         * s390-tdep.c: Use C++ exception handling.
3306         * rust-lang.c: Use C++ exception handling.
3307         * rust-exp.y: Use C++ exception handling.
3308         * rs6000-tdep.c: Use C++ exception handling.
3309         * rs6000-aix-tdep.c: Use C++ exception handling.
3310         * riscv-tdep.c: Use C++ exception handling.
3311         * remote.c: Use C++ exception handling.
3312         * remote-fileio.c: Use C++ exception handling.
3313         * record-full.c: Use C++ exception handling.
3314         * record-btrace.c: Use C++ exception handling.
3315         * python/python.c: Use C++ exception handling.
3316         * python/py-value.c: Use C++ exception handling.
3317         * python/py-utils.c: Use C++ exception handling.
3318         * python/py-unwind.c: Use C++ exception handling.
3319         * python/py-type.c: Use C++ exception handling.
3320         * python/py-symbol.c: Use C++ exception handling.
3321         * python/py-record.c: Use C++ exception handling.
3322         * python/py-record-btrace.c: Use C++ exception handling.
3323         * python/py-progspace.c: Use C++ exception handling.
3324         * python/py-prettyprint.c: Use C++ exception handling.
3325         * python/py-param.c: Use C++ exception handling.
3326         * python/py-objfile.c: Use C++ exception handling.
3327         * python/py-linetable.c: Use C++ exception handling.
3328         * python/py-lazy-string.c: Use C++ exception handling.
3329         * python/py-infthread.c: Use C++ exception handling.
3330         * python/py-inferior.c: Use C++ exception handling.
3331         * python/py-gdb-readline.c: Use C++ exception handling.
3332         * python/py-framefilter.c: Use C++ exception handling.
3333         * python/py-frame.c: Use C++ exception handling.
3334         * python/py-finishbreakpoint.c: Use C++ exception handling.
3335         * python/py-cmd.c: Use C++ exception handling.
3336         * python/py-breakpoint.c: Use C++ exception handling.
3337         * python/py-arch.c: Use C++ exception handling.
3338         * printcmd.c: Use C++ exception handling.
3339         * ppc-linux-tdep.c: Use C++ exception handling.
3340         * parse.c: Use C++ exception handling.
3341         * p-valprint.c: Use C++ exception handling.
3342         * objc-lang.c: Use C++ exception handling.
3343         * mi/mi-main.c: Use C++ exception handling.
3344         * mi/mi-interp.c: Use C++ exception handling.
3345         * mi/mi-cmd-stack.c: Use C++ exception handling.
3346         * mi/mi-cmd-break.c: Use C++ exception handling.
3347         * main.c: Use C++ exception handling.
3348         * linux-thread-db.c: Use C++ exception handling.
3349         * linux-tdep.c: Use C++ exception handling.
3350         * linux-nat.c: Use C++ exception handling.
3351         * linux-fork.c: Use C++ exception handling.
3352         * linespec.c: Use C++ exception handling.
3353         * language.c: Use C++ exception handling.
3354         * jit.c: Use C++ exception handling.
3355         * infrun.c: Use C++ exception handling.
3356         * infcmd.c: Use C++ exception handling.
3357         * infcall.c: Use C++ exception handling.
3358         * inf-loop.c: Use C++ exception handling.
3359         * i386-tdep.c: Use C++ exception handling.
3360         * i386-linux-tdep.c: Use C++ exception handling.
3361         * guile/scm-value.c: Use C++ exception handling.
3362         * guile/scm-type.c: Use C++ exception handling.
3363         * guile/scm-symtab.c: Use C++ exception handling.
3364         * guile/scm-symbol.c: Use C++ exception handling.
3365         * guile/scm-pretty-print.c: Use C++ exception handling.
3366         * guile/scm-ports.c: Use C++ exception handling.
3367         * guile/scm-param.c: Use C++ exception handling.
3368         * guile/scm-math.c: Use C++ exception handling.
3369         * guile/scm-lazy-string.c: Use C++ exception handling.
3370         * guile/scm-frame.c: Use C++ exception handling.
3371         * guile/scm-disasm.c: Use C++ exception handling.
3372         * guile/scm-cmd.c: Use C++ exception handling.
3373         * guile/scm-breakpoint.c: Use C++ exception handling.
3374         * guile/scm-block.c: Use C++ exception handling.
3375         * guile/guile-internal.h: Use C++ exception handling.
3376         * gnu-v3-abi.c: Use C++ exception handling.
3377         * gdbtypes.c: Use C++ exception handling.
3378         * frame.c: Use C++ exception handling.
3379         * frame-unwind.c: Use C++ exception handling.
3380         * fbsd-tdep.c: Use C++ exception handling.
3381         * f-valprint.c: Use C++ exception handling.
3382         * exec.c: Use C++ exception handling.
3383         * event-top.c: Use C++ exception handling.
3384         * event-loop.c: Use C++ exception handling.
3385         * eval.c: Use C++ exception handling.
3386         * dwarf2read.c: Use C++ exception handling.
3387         * dwarf2loc.c: Use C++ exception handling.
3388         * dwarf2-frame.c: Use C++ exception handling.
3389         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3390         * dwarf-index-write.c: Use C++ exception handling.
3391         * dwarf-index-cache.c: Use C++ exception handling.
3392         * dtrace-probe.c: Use C++ exception handling.
3393         * disasm-selftests.c: Use C++ exception handling.
3394         * darwin-nat.c: Use C++ exception handling.
3395         * cp-valprint.c: Use C++ exception handling.
3396         * cp-support.c: Use C++ exception handling.
3397         * cp-abi.c: Use C++ exception handling.
3398         * corelow.c: Use C++ exception handling.
3399         * completer.c: Use C++ exception handling.
3400         * compile/compile-object-run.c: Use C++ exception handling.
3401         * compile/compile-object-load.c: Use C++ exception handling.
3402         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3403         * compile/compile-c-symbols.c: Use C++ exception handling.
3404         * common/selftest.c: Use C++ exception handling.
3405         * common/new-op.c: Use C++ exception handling.
3406         * cli/cli-script.c: Use C++ exception handling.
3407         * cli/cli-interp.c: Use C++ exception handling.
3408         * cli/cli-cmds.c: Use C++ exception handling.
3409         * c-varobj.c: Use C++ exception handling.
3410         * btrace.c: Use C++ exception handling.
3411         * breakpoint.c: Use C++ exception handling.
3412         * break-catch-throw.c: Use C++ exception handling.
3413         * arch-utils.c: Use C++ exception handling.
3414         * amd64-tdep.c: Use C++ exception handling.
3415         * ada-valprint.c: Use C++ exception handling.
3416         * ada-typeprint.c: Use C++ exception handling.
3417         * ada-lang.c: Use C++ exception handling.
3418         * aarch64-tdep.c: Use C++ exception handling.
3419
3420 2019-04-08  Tom Tromey  <tom@tromey.com>
3421
3422         * xml-support.c (gdb_xml_parser::parse): Update.
3423         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3424         * value.c (show_convenience): Update.
3425         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3426         (test_parse_flags_qcs): Update.
3427         * thread.c (thr_try_catch_cmd): Update.
3428         * target.c (target_translate_tls_address): Update.
3429         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3430         (info_frame_command_core, frame_apply_command_count): Update.
3431         * rust-exp.y (rust_lex_exception_test): Update.
3432         * riscv-tdep.c (riscv_print_one_register_info): Update.
3433         * remote.c (remote_target::enable_btrace): Update.
3434         * record-btrace.c (record_btrace_enable_warn): Update.
3435         * python/py-utils.c (gdbpy_convert_exception): Update.
3436         * printcmd.c (do_one_display, print_variable_and_value): Update.
3437         * mi/mi-main.c (mi_print_exception): Update.
3438         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3439         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3440         * linux-nat.c (linux_nat_target::attach): Update.
3441         * linux-fork.c (class scoped_switch_fork_info): Update.
3442         * infrun.c (displaced_step_prepare): Update.
3443         * infcall.c (call_function_by_hand_dummy): Update.
3444         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3445         * gnu-v3-abi.c (print_one_vtable): Update.
3446         * frame.c (get_prev_frame_always): Update.
3447         * f-valprint.c (info_common_command_for_block): Update.
3448         * exec.c (try_open_exec_file): Update.
3449         * exceptions.c (print_exception, exception_print)
3450         (exception_fprintf, exception_print_same): Update.
3451         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3452         * dwarf-index-cache.c (index_cache::store)
3453         (index_cache::lookup_gdb_index): Update.
3454         * darwin-nat.c (maybe_cache_shell): Update.
3455         * cp-valprint.c (cp_print_value_fields): Update.
3456         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3457         (gcc_cplus_symbol_address): Update.
3458         * compile/compile-c-symbols.c (gcc_convert_symbol)
3459         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3460         * common/selftest.c: Update.
3461         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3462         a std::string.
3463         (exception_try_scope_entry, exception_try_scope_exit): Don't
3464         declare.
3465         (struct exception_try_scope): Remove.
3466         (TRY): Don't use exception_try_scope.
3467         (struct gdb_exception): Add constructor, operator=.
3468         <what>: New method.
3469         (struct gdb_exception_RETURN_MASK_ALL)
3470         (struct gdb_exception_RETURN_MASK_ERROR)
3471         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3472         (struct gdb_quit_bad_alloc): Update.
3473         * common/common-exceptions.c (exception_none): Change
3474         initializer.
3475         (struct catcher) <state, exception>: Initialize inline.
3476         <prev>: Remove member.
3477         (current_catcher): Remove.
3478         (catchers): New global.
3479         (exceptions_state_mc_init): Simplify.
3480         (catcher_pop): Remove.
3481         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3482         (try_scope_depth, exception_try_scope_entry)
3483         (exception_try_scope_exit): Remove.
3484         (throw_exception_sjlj): Update.
3485         (exception_messages, exception_messages_size): Remove.
3486         (throw_it): Simplify.
3487         (gdb_exception_sliced_copy): Remove.
3488         (throw_exception_cxx): Update.
3489         * cli/cli-script.c (script_from_file): Update.
3490         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3491         Update.
3492         * ada-valprint.c (ada_val_print): Update.
3493         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3494         (create_excep_cond_exprs): Update.
3495
3496 2019-04-08  Tom Tromey  <tom@tromey.com>
3497
3498         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3499         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3500         (TRY, CATCH, END_CATCH): Remove some definitions.
3501         * common/common-exceptions.c: Don't use GDB_XCPT.
3502         (catcher_list_size): Remove.
3503         (throw_exception, throw_it): Simplify.
3504
3505 2019-04-05  Tom Tromey  <tom@tromey.com>
3506
3507         Revert the header-sorting patch.
3508         * ft32-tdep.c: Revert.
3509         * frv-tdep.c: Revert.
3510         * frv-linux-tdep.c: Revert.
3511         * frame.c: Revert.
3512         * frame-unwind.c: Revert.
3513         * frame-base.c: Revert.
3514         * fork-child.c: Revert.
3515         * findvar.c: Revert.
3516         * findcmd.c: Revert.
3517         * filesystem.c: Revert.
3518         * filename-seen-cache.h: Revert.
3519         * filename-seen-cache.c: Revert.
3520         * fbsd-tdep.c: Revert.
3521         * fbsd-nat.h: Revert.
3522         * fbsd-nat.c: Revert.
3523         * f-valprint.c: Revert.
3524         * f-typeprint.c: Revert.
3525         * f-lang.c: Revert.
3526         * extension.h: Revert.
3527         * extension.c: Revert.
3528         * extension-priv.h: Revert.
3529         * expprint.c: Revert.
3530         * exec.h: Revert.
3531         * exec.c: Revert.
3532         * exceptions.c: Revert.
3533         * event-top.c: Revert.
3534         * event-loop.c: Revert.
3535         * eval.c: Revert.
3536         * elfread.c: Revert.
3537         * dwarf2read.h: Revert.
3538         * dwarf2read.c: Revert.
3539         * dwarf2loc.c: Revert.
3540         * dwarf2expr.h: Revert.
3541         * dwarf2expr.c: Revert.
3542         * dwarf2-frame.c: Revert.
3543         * dwarf2-frame-tailcall.c: Revert.
3544         * dwarf-index-write.h: Revert.
3545         * dwarf-index-write.c: Revert.
3546         * dwarf-index-common.c: Revert.
3547         * dwarf-index-cache.h: Revert.
3548         * dwarf-index-cache.c: Revert.
3549         * dummy-frame.c: Revert.
3550         * dtrace-probe.c: Revert.
3551         * disasm.h: Revert.
3552         * disasm.c: Revert.
3553         * disasm-selftests.c: Revert.
3554         * dictionary.c: Revert.
3555         * dicos-tdep.c: Revert.
3556         * demangle.c: Revert.
3557         * dcache.h: Revert.
3558         * dcache.c: Revert.
3559         * darwin-nat.h: Revert.
3560         * darwin-nat.c: Revert.
3561         * darwin-nat-info.c: Revert.
3562         * d-valprint.c: Revert.
3563         * d-namespace.c: Revert.
3564         * d-lang.c: Revert.
3565         * ctf.c: Revert.
3566         * csky-tdep.c: Revert.
3567         * csky-linux-tdep.c: Revert.
3568         * cris-tdep.c: Revert.
3569         * cris-linux-tdep.c: Revert.
3570         * cp-valprint.c: Revert.
3571         * cp-support.c: Revert.
3572         * cp-namespace.c: Revert.
3573         * cp-abi.c: Revert.
3574         * corelow.c: Revert.
3575         * corefile.c: Revert.
3576         * continuations.c: Revert.
3577         * completer.h: Revert.
3578         * completer.c: Revert.
3579         * complaints.c: Revert.
3580         * coffread.c: Revert.
3581         * coff-pe-read.c: Revert.
3582         * cli-out.h: Revert.
3583         * cli-out.c: Revert.
3584         * charset.c: Revert.
3585         * c-varobj.c: Revert.
3586         * c-valprint.c: Revert.
3587         * c-typeprint.c: Revert.
3588         * c-lang.c: Revert.
3589         * buildsym.c: Revert.
3590         * buildsym-legacy.c: Revert.
3591         * build-id.h: Revert.
3592         * build-id.c: Revert.
3593         * btrace.c: Revert.
3594         * bsd-uthread.c: Revert.
3595         * breakpoint.h: Revert.
3596         * breakpoint.c: Revert.
3597         * break-catch-throw.c: Revert.
3598         * break-catch-syscall.c: Revert.
3599         * break-catch-sig.c: Revert.
3600         * blockframe.c: Revert.
3601         * block.c: Revert.
3602         * bfin-tdep.c: Revert.
3603         * bfin-linux-tdep.c: Revert.
3604         * bfd-target.c: Revert.
3605         * bcache.c: Revert.
3606         * ax-general.c: Revert.
3607         * ax-gdb.h: Revert.
3608         * ax-gdb.c: Revert.
3609         * avr-tdep.c: Revert.
3610         * auxv.c: Revert.
3611         * auto-load.c: Revert.
3612         * arm-wince-tdep.c: Revert.
3613         * arm-tdep.c: Revert.
3614         * arm-symbian-tdep.c: Revert.
3615         * arm-pikeos-tdep.c: Revert.
3616         * arm-obsd-tdep.c: Revert.
3617         * arm-nbsd-tdep.c: Revert.
3618         * arm-nbsd-nat.c: Revert.
3619         * arm-linux-tdep.c: Revert.
3620         * arm-linux-nat.c: Revert.
3621         * arm-fbsd-tdep.c: Revert.
3622         * arm-fbsd-nat.c: Revert.
3623         * arm-bsd-tdep.c: Revert.
3624         * arch-utils.c: Revert.
3625         * arc-tdep.c: Revert.
3626         * arc-newlib-tdep.c: Revert.
3627         * annotate.h: Revert.
3628         * annotate.c: Revert.
3629         * amd64-windows-tdep.c: Revert.
3630         * amd64-windows-nat.c: Revert.
3631         * amd64-tdep.c: Revert.
3632         * amd64-sol2-tdep.c: Revert.
3633         * amd64-obsd-tdep.c: Revert.
3634         * amd64-obsd-nat.c: Revert.
3635         * amd64-nbsd-tdep.c: Revert.
3636         * amd64-nbsd-nat.c: Revert.
3637         * amd64-nat.c: Revert.
3638         * amd64-linux-tdep.c: Revert.
3639         * amd64-linux-nat.c: Revert.
3640         * amd64-fbsd-tdep.c: Revert.
3641         * amd64-fbsd-nat.c: Revert.
3642         * amd64-dicos-tdep.c: Revert.
3643         * amd64-darwin-tdep.c: Revert.
3644         * amd64-bsd-nat.c: Revert.
3645         * alpha-tdep.c: Revert.
3646         * alpha-obsd-tdep.c: Revert.
3647         * alpha-nbsd-tdep.c: Revert.
3648         * alpha-mdebug-tdep.c: Revert.
3649         * alpha-linux-tdep.c: Revert.
3650         * alpha-linux-nat.c: Revert.
3651         * alpha-bsd-tdep.c: Revert.
3652         * alpha-bsd-nat.c: Revert.
3653         * aix-thread.c: Revert.
3654         * agent.c: Revert.
3655         * addrmap.c: Revert.
3656         * ada-varobj.c: Revert.
3657         * ada-valprint.c: Revert.
3658         * ada-typeprint.c: Revert.
3659         * ada-tasks.c: Revert.
3660         * ada-lang.c: Revert.
3661         * aarch64-tdep.c: Revert.
3662         * aarch64-ravenscar-thread.c: Revert.
3663         * aarch64-newlib-tdep.c: Revert.
3664         * aarch64-linux-tdep.c: Revert.
3665         * aarch64-linux-nat.c: Revert.
3666         * aarch64-fbsd-tdep.c: Revert.
3667         * aarch64-fbsd-nat.c: Revert.
3668         * aarch32-linux-nat.c: Revert.
3669
3670 2019-04-05  Tom Tromey  <tom@tromey.com>
3671
3672         * ft32-tdep.c: Sort headers.
3673         * frv-tdep.c: Sort headers.
3674         * frv-linux-tdep.c: Sort headers.
3675         * frame.c: Sort headers.
3676         * frame-unwind.c: Sort headers.
3677         * frame-base.c: Sort headers.
3678         * fork-child.c: Sort headers.
3679         * findvar.c: Sort headers.
3680         * findcmd.c: Sort headers.
3681         * filesystem.c: Sort headers.
3682         * filename-seen-cache.h: Sort headers.
3683         * filename-seen-cache.c: Sort headers.
3684         * fbsd-tdep.c: Sort headers.
3685         * fbsd-nat.h: Sort headers.
3686         * fbsd-nat.c: Sort headers.
3687         * f-valprint.c: Sort headers.
3688         * f-typeprint.c: Sort headers.
3689         * f-lang.c: Sort headers.
3690         * extension.h: Sort headers.
3691         * extension.c: Sort headers.
3692         * extension-priv.h: Sort headers.
3693         * expprint.c: Sort headers.
3694         * exec.h: Sort headers.
3695         * exec.c: Sort headers.
3696         * exceptions.c: Sort headers.
3697         * event-top.c: Sort headers.
3698         * event-loop.c: Sort headers.
3699         * eval.c: Sort headers.
3700         * elfread.c: Sort headers.
3701         * dwarf2read.h: Sort headers.
3702         * dwarf2read.c: Sort headers.
3703         * dwarf2loc.c: Sort headers.
3704         * dwarf2expr.h: Sort headers.
3705         * dwarf2expr.c: Sort headers.
3706         * dwarf2-frame.c: Sort headers.
3707         * dwarf2-frame-tailcall.c: Sort headers.
3708         * dwarf-index-write.h: Sort headers.
3709         * dwarf-index-write.c: Sort headers.
3710         * dwarf-index-common.c: Sort headers.
3711         * dwarf-index-cache.h: Sort headers.
3712         * dwarf-index-cache.c: Sort headers.
3713         * dummy-frame.c: Sort headers.
3714         * dtrace-probe.c: Sort headers.
3715         * disasm.h: Sort headers.
3716         * disasm.c: Sort headers.
3717         * disasm-selftests.c: Sort headers.
3718         * dictionary.c: Sort headers.
3719         * dicos-tdep.c: Sort headers.
3720         * demangle.c: Sort headers.
3721         * dcache.h: Sort headers.
3722         * dcache.c: Sort headers.
3723         * darwin-nat.h: Sort headers.
3724         * darwin-nat.c: Sort headers.
3725         * darwin-nat-info.c: Sort headers.
3726         * d-valprint.c: Sort headers.
3727         * d-namespace.c: Sort headers.
3728         * d-lang.c: Sort headers.
3729         * ctf.c: Sort headers.
3730         * csky-tdep.c: Sort headers.
3731         * csky-linux-tdep.c: Sort headers.
3732         * cris-tdep.c: Sort headers.
3733         * cris-linux-tdep.c: Sort headers.
3734         * cp-valprint.c: Sort headers.
3735         * cp-support.c: Sort headers.
3736         * cp-namespace.c: Sort headers.
3737         * cp-abi.c: Sort headers.
3738         * corelow.c: Sort headers.
3739         * corefile.c: Sort headers.
3740         * continuations.c: Sort headers.
3741         * completer.h: Sort headers.
3742         * completer.c: Sort headers.
3743         * complaints.c: Sort headers.
3744         * coffread.c: Sort headers.
3745         * coff-pe-read.c: Sort headers.
3746         * cli-out.h: Sort headers.
3747         * cli-out.c: Sort headers.
3748         * charset.c: Sort headers.
3749         * c-varobj.c: Sort headers.
3750         * c-valprint.c: Sort headers.
3751         * c-typeprint.c: Sort headers.
3752         * c-lang.c: Sort headers.
3753         * buildsym.c: Sort headers.
3754         * buildsym-legacy.c: Sort headers.
3755         * build-id.h: Sort headers.
3756         * build-id.c: Sort headers.
3757         * btrace.c: Sort headers.
3758         * bsd-uthread.c: Sort headers.
3759         * breakpoint.h: Sort headers.
3760         * breakpoint.c: Sort headers.
3761         * break-catch-throw.c: Sort headers.
3762         * break-catch-syscall.c: Sort headers.
3763         * break-catch-sig.c: Sort headers.
3764         * blockframe.c: Sort headers.
3765         * block.c: Sort headers.
3766         * bfin-tdep.c: Sort headers.
3767         * bfin-linux-tdep.c: Sort headers.
3768         * bfd-target.c: Sort headers.
3769         * bcache.c: Sort headers.
3770         * ax-general.c: Sort headers.
3771         * ax-gdb.h: Sort headers.
3772         * ax-gdb.c: Sort headers.
3773         * avr-tdep.c: Sort headers.
3774         * auxv.c: Sort headers.
3775         * auto-load.c: Sort headers.
3776         * arm-wince-tdep.c: Sort headers.
3777         * arm-tdep.c: Sort headers.
3778         * arm-symbian-tdep.c: Sort headers.
3779         * arm-pikeos-tdep.c: Sort headers.
3780         * arm-obsd-tdep.c: Sort headers.
3781         * arm-nbsd-tdep.c: Sort headers.
3782         * arm-nbsd-nat.c: Sort headers.
3783         * arm-linux-tdep.c: Sort headers.
3784         * arm-linux-nat.c: Sort headers.
3785         * arm-fbsd-tdep.c: Sort headers.
3786         * arm-fbsd-nat.c: Sort headers.
3787         * arm-bsd-tdep.c: Sort headers.
3788         * arch-utils.c: Sort headers.
3789         * arc-tdep.c: Sort headers.
3790         * arc-newlib-tdep.c: Sort headers.
3791         * annotate.h: Sort headers.
3792         * annotate.c: Sort headers.
3793         * amd64-windows-tdep.c: Sort headers.
3794         * amd64-windows-nat.c: Sort headers.
3795         * amd64-tdep.c: Sort headers.
3796         * amd64-sol2-tdep.c: Sort headers.
3797         * amd64-obsd-tdep.c: Sort headers.
3798         * amd64-obsd-nat.c: Sort headers.
3799         * amd64-nbsd-tdep.c: Sort headers.
3800         * amd64-nbsd-nat.c: Sort headers.
3801         * amd64-nat.c: Sort headers.
3802         * amd64-linux-tdep.c: Sort headers.
3803         * amd64-linux-nat.c: Sort headers.
3804         * amd64-fbsd-tdep.c: Sort headers.
3805         * amd64-fbsd-nat.c: Sort headers.
3806         * amd64-dicos-tdep.c: Sort headers.
3807         * amd64-darwin-tdep.c: Sort headers.
3808         * amd64-bsd-nat.c: Sort headers.
3809         * alpha-tdep.c: Sort headers.
3810         * alpha-obsd-tdep.c: Sort headers.
3811         * alpha-nbsd-tdep.c: Sort headers.
3812         * alpha-mdebug-tdep.c: Sort headers.
3813         * alpha-linux-tdep.c: Sort headers.
3814         * alpha-linux-nat.c: Sort headers.
3815         * alpha-bsd-tdep.c: Sort headers.
3816         * alpha-bsd-nat.c: Sort headers.
3817         * aix-thread.c: Sort headers.
3818         * agent.c: Sort headers.
3819         * addrmap.c: Sort headers.
3820         * ada-varobj.c: Sort headers.
3821         * ada-valprint.c: Sort headers.
3822         * ada-typeprint.c: Sort headers.
3823         * ada-tasks.c: Sort headers.
3824         * ada-lang.c: Sort headers.
3825         * aarch64-tdep.c: Sort headers.
3826         * aarch64-ravenscar-thread.c: Sort headers.
3827         * aarch64-newlib-tdep.c: Sort headers.
3828         * aarch64-linux-tdep.c: Sort headers.
3829         * aarch64-linux-nat.c: Sort headers.
3830         * aarch64-fbsd-tdep.c: Sort headers.
3831         * aarch64-fbsd-nat.c: Sort headers.
3832         * aarch32-linux-nat.c: Sort headers.
3833
3834 2019-04-04  Tom Tromey  <tom@tromey.com>
3835
3836         * varobj.c (varobj_create): Update.
3837         * rust-exp.y (struct rust_parser) <update_innermost_block,
3838         lookup_symbol>: New methods.
3839         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3840         Rename.
3841         (rust_parser::rust_lookup_type)
3842         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3843         * printcmd.c (display_command, do_one_display): Update.
3844         * parser-defs.h (struct parser_state) <parser_state>: Add
3845         "tracker" parameter.
3846         (block_tracker): New member.
3847         (class innermost_block_tracker) <innermost_block_tracker>: Add
3848         "types" parameter.
3849         <reset>: Remove method.
3850         (innermost_block): Don't declare.
3851         (null_post_parser): Update.
3852         * parse.c (innermost_block): Remove global.
3853         (write_dollar_variable): Update.
3854         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3855         Remove "tracker_types" parameter.
3856         (parse_expression): Add "tracker" parameter.
3857         (parse_expression_for_completion): Update.
3858         (null_post_parser): Add "tracker" parameter.
3859         * p-exp.y: Update rules.
3860         * m2-exp.y: Update rules.
3861         * language.h (struct language_defn) <la_post_parser>: Add
3862         "tracker" parameter.
3863         * go-exp.y: Update rules.
3864         * f-exp.y: Update rules.
3865         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3866         parameter.
3867         * d-exp.y: Update rules.
3868         * c-exp.y: Update rules.
3869         * breakpoint.c (set_breakpoint_condition): Create an
3870         innermost_block_tracker.
3871         (watch_command_1): Likewise.
3872         * ada-lang.c (resolve): Add "tracker" parameter.
3873         (resolve_subexp): Likewise.
3874         * ada-exp.y (write_var_from_sym): Update.
3875
3876 2019-04-04  Tom Tromey  <tom@tromey.com>
3877
3878         * type-stack.h: New file.
3879         * type-stack.c: New file.
3880         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3881         type-stack.h.
3882         (insert_into_type_stack, insert_type, push_type, push_type_int)
3883         (insert_type_address_space, pop_type, pop_type_int)
3884         (pop_typelist, pop_type_stack, append_type_stack)
3885         (push_type_stack, get_type_stack, push_typelist)
3886         (follow_type_instance_flags, follow_types): Don't declare.
3887         * parse.c (type_stack): Remove global.
3888         (parse_exp_in_context): Update.
3889         (insert_into_type_stack, insert_type, push_type, push_type_int)
3890         (insert_type_address_space, pop_type, pop_type_int)
3891         (pop_typelist, pop_type_stack, append_type_stack)
3892         (push_type_stack, get_type_stack, push_typelist)
3893         (follow_type_instance_flags, follow_types): Remove (moved to
3894         type-stack.c).
3895         * f-exp.y (type_stack): New global.
3896         Update rules.
3897         (push_kind_type, f_parse): Update.
3898         * d-exp.y (type_stack): New global.
3899         Update rules.
3900         (d_parse): Update.
3901         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3902         Update rules.
3903         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3904         (HFILES_NO_SRCDIR): Add type-stack.h.
3905
3906 2019-04-04  Tom Tromey  <tom@tromey.com>
3907
3908         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3909         (rust_parser::convert_ast_to_expression, rust_parse)
3910         (rust_lex_test_completion, rust_lex_tests): Update.
3911         * parser-defs.h (struct expr_completion_state): New.
3912         (struct parser_state) <parser_state>: Add completion parameter.
3913         <mark_struct_expression, mark_completion_tag>: New methods.
3914         <parse_completion, m_completion_state>: New members.
3915         (prefixify_expression, null_post_parser): Update.
3916         (mark_struct_expression, mark_completion_tag): Don't declare.
3917         * parse.c (parse_completion, expout_last_struct)
3918         (expout_tag_completion_type, expout_completion_name): Remove
3919         globals.
3920         (parser_state::mark_struct_expression)
3921         (parser_state::mark_completion_tag): Now methods.
3922         (prefixify_expression): Add last_struct parameter.
3923         (prefixify_subexp): Likewise.
3924         (parse_exp_1): Update.
3925         (parse_exp_in_context): Add cstate parameter.  Update.
3926         (parse_expression_for_completion): Create an
3927         expr_completion_state.
3928         (null_post_parser): Add "completion" parameter.
3929         * p-exp.y: Update rules.
3930         (yylex): Update.
3931         * language.h (struct language_defn) <la_post_parser>: Add
3932         "completing" parameter.
3933         * go-exp.y: Update rules.
3934         (lex_one_token): Update.
3935         * expression.h (parse_completion): Don't declare.
3936         * d-exp.y: Update rules.
3937         (lex_one_token): Update rules.
3938         * c-exp.y: Update rules.
3939         (lex_one_token): Update.
3940         * ada-lang.c (resolve): Add "parse_completion" parameter.
3941         (resolve_subexp): Likewise.
3942         (ada_resolve_function): Likewise.
3943
3944 2019-04-04  Tom Tromey  <tom@tromey.com>
3945
3946         * parser-defs.h (struct parser_state) <start_arglist,
3947         end_arglist>: New methods.
3948         <arglist_len, m_funcall_chain>: New members.
3949         (arglist_len, start_arglist, end_arglist): Don't declare.
3950         * parse.c (arglist_len, funcall_chain): Remove global.
3951         (start_arglist, end_arglist): Remove functions.
3952         (parse_exp_in_context): Update.
3953         * p-exp.y: Update rules.
3954         * m2-exp.y: Update rules.
3955         * go-exp.y: Update rules.
3956         * f-exp.y: Update rules.
3957         * d-exp.y: Update rules.
3958         * c-exp.y: Update rules.
3959
3960 2019-04-04  Tom Tromey  <tom@tromey.com>
3961
3962         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3963         lex_operator, push_back>: New methods.
3964         Update all rules.
3965         (rust_parser::lex_hex, lex_escape): Rename and update.
3966         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3967         (rust_parser::lex_operator): Rename and update.
3968         (rust_parser::lex_number, rustyylex, rustyyerror)
3969         (rust_lex_test_init, rust_lex_test_sequence)
3970         (rust_lex_test_push_back, rust_lex_tests): Update.
3971         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3972         parameter.
3973         <lexptr, prev_lexptr>: New members.
3974         (lexptr, prev_lexptr): Don't declare.
3975         * parse.c (lexptr, prev_lexptr): Remove globals.
3976         (parse_exp_in_context): Update.
3977         * p-exp.y (yylex, yyerror): Update.
3978         * m2-exp.y (parse_number, yylex, yyerror): Update.
3979         * go-exp.y (lex_one_token, yyerror): Update.
3980         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3981         * d-exp.y (lex_one_token, yyerror): Update.
3982         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3983         (lex_one_token, yyerror): Update.
3984         * ada-lex.l (YY_INPUT): Update.
3985         (rewind_to_char): Update.
3986         * ada-exp.y (yyerror): Update.
3987
3988 2019-04-04  Tom Tromey  <tom@tromey.com>
3989
3990         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3991         * parser-defs.h (struct parser_state) <parser_state>: Add new
3992         parameter.
3993         <comma_terminates>: New member.
3994         (comma_terminates): Don't declare global.
3995         * parse.c (comma_terminates): Remove global.
3996         (parse_exp_in_context): Update.
3997         * p-exp.y (yylex): Update.
3998         * m2-exp.y (yylex): Update.
3999         * go-exp.y (lex_one_token): Update.
4000         * f-exp.y (yylex): Update.
4001         * d-exp.y (lex_one_token): Update.
4002         * c-exp.y (lex_one_token): Update.
4003         * ada-lex.l: Update.
4004
4005 2019-04-04  Tom Tromey  <tom@tromey.com>
4006
4007         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4008         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4009         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4010         * parser-defs.h (paren_depth): Don't declare.
4011         * parse.c (paren_depth): Remove global.
4012         (parse_exp_in_context): Update.
4013         * p-exp.y (paren_depth): New global.
4014         (pascal_parse): Initialize it.
4015         * m2-exp.y (paren_depth): New global.
4016         (m2_parse): Initialize it.
4017         * go-exp.y (paren_depth): New global.
4018         (go_parse): Initialize it.
4019         * f-exp.y (paren_depth): New global.
4020         (f_parse): Initialize it.
4021         * d-exp.y (paren_depth): New global.
4022         (d_parse): Initialize it.
4023         * c-exp.y (paren_depth): New global.
4024         (c_parse): Initialize it.
4025         * ada-lex.l (paren_depth): New global.
4026         (lexer_init): Initialize it.
4027
4028 2019-04-04  Tom Tromey  <tom@tromey.com>
4029
4030         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4031         (rust_parser::convert_ast_to_type)
4032         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4033         * parser-defs.h (struct parser_state) <parser_state>: Add
4034         parameters.  Initialize new members.
4035         <expression_context_block, expression_context_pc>: New members.
4036         * parse.c (expression_context_block, expression_context_pc):
4037         Remove globals.
4038         (parse_exp_in_context): Update.
4039         * p-exp.y: Update all rules.
4040         (yylex): Update.
4041         * m2-exp.y: Update all rules.
4042         (yylex): Update.
4043         * go-exp.y (yylex): Update.
4044         * f-exp.y (yylex): Update.
4045         * d-exp.y: Update all rules.
4046         (yylex): Update.
4047         * c-exp.y: Update all rules.
4048         (lex_one_token, classify_name, yylex, c_parse): Update.
4049         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4050
4051 2019-04-04  Tom Tromey  <tom@tromey.com>
4052
4053         * gdbarch.h, gdbarch.c: Rebuild.
4054         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4055         * stap-probe.h:
4056         (struct stap_parse_info): Replace "parser_state" with
4057         "expr_builder".
4058         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4059         (parser_state): New class.
4060         * parse.c (expr_builder): Rename.
4061         (expr_builder::release): Rename.
4062         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4063         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4064         (write_exp_elt_longcst, write_exp_elt_floatcst)
4065         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4066         (write_exp_string_vector, write_exp_bitstring)
4067         (write_exp_msymbol, mark_struct_expression)
4068         (write_dollar_variable)
4069         (insert_type_address_space, increase_expout_size): Replace
4070         "parser_state" with "expr_builder".
4071         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4072         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4073         "parser_state" with "expr_builder".
4074
4075 2019-04-04  Tom Tromey  <tom@tromey.com>
4076
4077         * rust-exp.y: Replace "parse_language" with method call.
4078         * p-exp.y:
4079         (yylex): Replace "parse_language" with method call.
4080         * m2-exp.y:
4081         (yylex): Replace "parse_language" with method call.
4082         * go-exp.y (classify_name): Replace "parse_language" with method
4083         call.
4084         * f-exp.y (yylex): Replace "parse_language" with method call.
4085         * d-exp.y (lex_one_token): Replace "parse_language" with method
4086         call.
4087         * c-exp.y:
4088         (lex_one_token, classify_name, yylex): Replace "parse_language"
4089         with method call.
4090         * ada-exp.y (find_primitive_type, type_char)
4091         (type_system_address): Replace "parse_language" with method call.
4092
4093 2019-04-04  Tom Tromey  <tom@tromey.com>
4094
4095         * rust-exp.y: Replace "parse_gdbarch" with method call.
4096         * parse.c (write_dollar_variable, insert_type_address_space):
4097         Replace "parse_gdbarch" with method call.
4098         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4099         call.
4100         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4101         call.
4102         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4103         "parse_gdbarch" with method call.
4104         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4105         with method call.
4106         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4107         "parse_gdbarch" with method call.
4108         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4109         "parse_gdbarch" with method call.
4110         * c-exp.y (parse_type, parse_number, classify_name): Replace
4111         "parse_gdbarch" with method call.
4112         * ada-lex.l: Replace "parse_gdbarch" with method call.
4113         * ada-exp.y (parse_type, find_primitive_type, type_char)
4114         (type_system_address): Replace "parse_gdbarch" with method call.
4115
4116 2019-04-04  Tom Tromey  <tom@tromey.com>
4117
4118         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4119         * stap-probe.c (stap_parse_argument): Update.
4120         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4121         initial_size parameter.
4122         * rust-exp.y (rust_lex_tests): Update.
4123         * parse.c (parser_state): Update.
4124         (parse_exp_in_context): Update.
4125         * parser-defs.h (struct parser_state) <parser_state>: Remove
4126         "initial_size" parameter.
4127
4128 2019-04-04  Tom Tromey  <tom@tromey.com>
4129
4130         * parser-defs.h (increase_expout_size): Don't declare.
4131         * parse.c (increase_expout_size): Now static.
4132
4133 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4134
4135         * gnu-nat.c (gnu_nat_target::wait): Fix
4136         target_waitstatus_to_string call.
4137
4138 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * eval.c (evaluate_subexp_standard): Handle internal functions
4141         during Fortran function call handling.
4142
4143 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4144
4145         * NEWS: Mention new internal functions.
4146         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4147         (read_base_type): Use dwarf2_init_complex_target_type.
4148         * value.c (creal_internal_fn): New function.
4149         (cimag_internal_fn): New function.
4150         (_initialize_values): Register new internal functions.
4151
4152 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4153
4154         * infrun.c (stop_all_threads): If debug_infrun, always
4155         trace the wait status after wait_one, using
4156         target_waitstatus_to_string and target_pid_to_str.
4157         (handle_inferior_event): Replace various trace of
4158         wait status kind by a single trace.
4159         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4160         wait status kind image by target_waitstatus_to_string.
4161         * target/waitstatus.c (target_waitstatus_to_string): Fix
4162         obsolete comment.
4163
4164 2019-04-01  Tom Tromey  <tromey@adacore.com>
4165
4166         PR symtab/23331:
4167         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4168
4169 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4170             Pedro Alves  <palves@redhat.com>
4171
4172         * top.c (quit_force): Call 'finalize_values'.
4173         * value.c (finalize_values): New function.
4174         * value.h (finalize_values): Declare.
4175
4176 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4177
4178         * NEWS: Announce $_gdb_major and $_gdb_minor.
4179
4180         * top.c (init_gdb_version_vars): New function.
4181         (gdb_init): Call init_gdb_version_vars.
4182
4183 2019-03-29  Tom Tromey  <tromey@adacore.com>
4184
4185         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4186         help text.  Remove dead code.
4187
4188 2019-03-29  Keith Seitz  <keiths@redhat.com>
4189
4190         From Siddhesh Poyarekar:
4191         * f-lang.h (f77_get_upperbound): Return LONGEST.
4192         (f77_get_lowerbound): Likewise.
4193         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4194         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4195         print them.
4196         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4197         plongest to format print it.
4198         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4199         (f77_get_upperbound): Likewise.
4200         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4201         LOWER_BOUND to LONGEST.
4202         (f77_create_arrayprint_offset_tbl): Likewise.
4203
4204 2019-03-29  Keith Seitz  <keiths@redhat.com>
4205
4206         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4207         %s/pulongest for TYPE_LENGTH instead of %d in format
4208         strings.
4209         * ada-typerint.c (ada_print_type): Likewise.
4210         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4211         * compile/compile-c-support.c (generate_register_struct): Likewise.
4212         * gdbtypes.c (recursive_dump_type): Likewise.
4213         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4214         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4215         instead of %d in format strings.
4216         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4217         to std::min to ULONGEST.
4218         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4219         instead of %d in format strings.
4220         * tracepoint.c (info_scope_command): Likewise.
4221         * typeprint.c (print_offset_data::update)
4222         (print_offset_data::finish): Likewise.
4223         * xtensa-tdep.c (xtensa_store_return_value)
4224         (xtensa_push_dummy_call): Likewise.
4225
4226 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4227
4228         * windows-nat.c (display_selector): Fixed format specifications
4229         for 64-bit Cygwin.
4230
4231 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4232
4233         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4234
4235 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4236
4237         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4238         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4239         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4240         (nios2_linux_init_abi): Install it.
4241
4242 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4243
4244         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4245
4246 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4247
4248         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4249
4250 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4251             Tom Tromey  <tromey@adacore.com>
4252
4253         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4254
4255 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4256
4257         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4258         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4259         method to compute the bounds of range types. Also print "[evaluated]"
4260         if the bounds' values come from a dynamic evaluation.
4261
4262 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4263
4264         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4265         whitespace when pretty printing is on.
4266
4267 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4268
4269         * ppc-linux-nat.c: Add include.
4270
4271 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4272
4273         * NEWS: Mention AArch64 Pointer Authentication.
4274
4275 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4276
4277         * arm-linux-nat.c: Add include.
4278
4279 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4280
4281         * source-cache.c (source_cache::get_source_lines): Re-read
4282         fullname after calling open_source_file.
4283
4284 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4285
4286         * NEWS: Mention TLS support for FreeBSD.
4287
4288 2019-03-25  Tom Tromey  <tromey@adacore.com>
4289
4290         * minsyms.c (BUNCH_SIZE): Update comment.
4291         (~minimal_symbol_reader): Remove old comment.
4292         (compact_minimal_symbols): Update comment.
4293         (minimal_symbol_reader::install): Remove old comment.  Update
4294         other comments.
4295
4296 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4297
4298         * s390-linux-nat.c: Add include.
4299
4300 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4301
4302         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4303         Call linux_get_hwcap.
4304         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4305         Likewise.
4306         (aarch64_linux_get_hwcap): Remove function.
4307         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4308         declaration.
4309         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4310         linux_get_hwcap.
4311         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4312         * linux-tdep.c (linux_get_hwcap): Add function.
4313         (linux_get_hwcap2): Likewise.
4314         * linux-tdep.h (linux_get_hwcap): Add declaration.
4315         (linux_get_hwcap2): Likewise.
4316         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4317         (ppc_linux_get_hwcap2): Likewise.
4318         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4319         linux_get_hwcap.
4320         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4321         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4322         (ppc_linux_nat_target::read_description): Likewise.
4323         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4324         * s390-linux-nat.c: Likewise.
4325         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4326
4327 2019-03-24  Tom Tromey  <tom@tromey.com>
4328
4329         * ada-lang.c (standard_lookup): Simplify initialization.
4330         (ada_lookup_symbol_nonlocal): Simplify return.
4331         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4332         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4333         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4334         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4335         initialization.
4336         * solib.c (solib_global_lookup): Simplify.
4337         * symtab.c (null_block_symbol): Remove.
4338         (symbol_cache_lookup): Simplify returns.
4339         (lookup_language_this): Simplify returns.
4340         (lookup_symbol_aux): Simplify return.
4341         (lookup_local_symbol): Simplify returns.
4342         (lookup_global_symbol_from_objfile): Simplify return.
4343         (lookup_symbol_in_objfile_symtabs)
4344         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4345         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4346         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4347         * cp-namespace.c (cp_lookup_bare_symbol)
4348         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4349         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4350         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4351         (cp_lookup_symbol_via_imports): Simplify initialization.
4352         (find_symbol_in_baseclass): Likewise.
4353         * symtab.h (null_block_symbol): Remove.
4354         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4355         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4356         (d_lookup_symbol_module): Likewise.
4357         (find_symbol_in_baseclass): Simplify initialization.
4358
4359 2019-03-24  Tom Tromey  <tom@tromey.com>
4360
4361         * expression.h: Don't include symtab.h.
4362         (struct block): Forward declare.
4363
4364 2019-03-24  Tom Tromey  <tom@tromey.com>
4365
4366         * c-exp.y (typebase): Remove casts.
4367         * gdbtypes.c (lookup_unsigned_typename, )
4368         (lookup_signed_typename): Remove cast.
4369         * eval.c (parse_to_comma_and_eval): Remove cast.
4370         * parse.c (write_dollar_variable): Remove cast.
4371         * block.h (struct block) <superblock>: Now const.
4372         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4373         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4374         (map_block): Make "block" const.
4375         * symfile.h (struct quick_symbol_functions)
4376         <map_matching_symbols>: Constify block argument to "callback".
4377         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4378         const.
4379         (find_pc_sect_compunit_symtab): Make "b" const.
4380         (find_symbol_at_address): Likewise.
4381         (search_symbols): Likewise.
4382         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4383         (dw2_debug_names_lookup_symbol): Likewise.
4384         (dw2_map_matching_symbols): Update.
4385         * p-valprint.c (pascal_val_print): Remove "block".
4386         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4387         (aux_add_nonlocal_symbols): Make "block" const.
4388         (resolve_subexp): Remove cast.
4389         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4390         const.
4391         (iterate_over_file_blocks): Likewise.
4392         * f-exp.y (%union) <bval>: Remove.
4393         * coffread.c (patch_opaque_types): Make "b" const.
4394         * spu-tdep.c (spu_catch_start): Make "block" const.
4395         * c-valprint.c (print_unpacked_pointer): Remove "block".
4396         * symmisc.c (dump_symtab_1): Make "b" const.
4397         (block_depth): Make "block" const.
4398         * d-exp.y (%union) <bval>: Remove.
4399         * cp-support.h (cp_lookup_rtti_type): Update.
4400         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4401         * psymtab.c (psym_lookup_symbol): Make "block" const.
4402         (maintenance_check_psymtabs): Make "b" const.
4403         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4404         (enumerate_locals, enumerate_args): Update.
4405         * python/py-symtab.c (stpy_global_block): Make "block" const.
4406         (stpy_static_block): Likewise.
4407         * inline-frame.c (block_starting_point_at): Make "new_block"
4408         const.
4409         * block.c (find_block_in_blockvector): Make return type const.
4410         (blockvector_for_pc_sect): Make "b" const.
4411         (find_block_in_blockvector): Make "b" const.
4412
4413 2019-03-23  Tom Tromey  <tom@tromey.com>
4414
4415         * varobj.c (varobj_create): Update.
4416         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4417         * printcmd.c (display_command, do_one_display): Don't reset
4418         innermost_block.
4419         * parser-defs.h (enum innermost_block_tracker_type): Move to
4420         expression.h.
4421         (innermost_block): Update comment.
4422         * parse.c (parse_exp_1): Add tracker_types parameter.
4423         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4424         tracker_types parameter.  Reset innermost_block.
4425         (parse_exp_in_context): Remove.
4426         (parse_expression_for_completion): Update.
4427         * objfiles.c (~objfile): Don't reset expression_context_block or
4428         innermost_block.
4429         * expression.h (enum innermost_block_tracker_type): Move from
4430         parser-defs.h.
4431         (parse_exp_1): Add tracker_types parameter.
4432         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4433         reset innermost_block.
4434
4435 2019-03-23  Tom Tromey  <tom@tromey.com>
4436
4437         * objfiles.h: Include bcache.h.
4438
4439 2019-03-23  Tom Tromey  <tom@tromey.com>
4440
4441         * linespec.c (get_current_search_block): Use
4442         scoped_restore_current_language.
4443         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4444
4445 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4446             Jiong Wang  <jiong.wang@arm.com>
4447
4448         * aarch64-linux-tdep.c
4449         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4450         section.
4451         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4452
4453 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4454             Jiong Wang  <jiong.wang@arm.com>
4455
4456         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4457         instructions.
4458         (aarch64_analyze_prologue_test): Add PACIASP test.
4459         (aarch64_prologue_prev_register): Unmask PC value.
4460
4461 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4462             Jiong Wang  <jiong.wang@arm.com>
4463
4464         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4465         (aarch64_dwarf2_prev_register): Unmask PC value.
4466         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4467         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4468         DW_CFA_AARCH64_negate_ra_state.
4469         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4470
4471 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4472             Jiong Wang  <jiong.wang@arm.com>
4473
4474         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4475         registers.
4476         (aarch64_pseudo_register_name): Likewise.
4477         (aarch64_pseudo_register_type): Likewise.
4478         (aarch64_pseudo_register_reggroup_p): Likewise.
4479         (aarch64_gdbarch_init): Add pauth registers.
4480         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4481         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4482         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4483         (struct gdbarch_tdep): Add regnum for ra_state.
4484
4485 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4486             Jiong Wang  <jiong.wang@arm.com>
4487
4488         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4489
4490 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4491             Jiong Wang  <jiong.wang@arm.com>
4492
4493         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4494         function.
4495         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4496         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4497         (aarch64_gdbarch_init): Add puth registers.
4498         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4499         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4500         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4501
4502 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4503             Jiong Wang  <jiong.wang@arm.com>
4504
4505         * aarch64-linux-nat.c
4506         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4507         * aarch64-linux-tdep.c
4508         (aarch64_linux_core_read_description): Likewise.
4509         (aarch64_linux_get_hwcap): New function.
4510         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4511         (aarch64_linux_get_hwcap): New declaration.
4512
4513 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4514             Jiong Wang  <jiong.wang@arm.com>
4515
4516         * aarch64-linux-nat.c
4517         (aarch64_linux_nat_target::read_description): Add pauth param.
4518         * aarch64-linux-tdep.c
4519         (aarch64_linux_core_read_description): Likewise.
4520         * aarch64-tdep.c (struct target_desc): Add in pauth.
4521         (aarch64_read_description): Add pauth param.
4522         (aarch64_gdbarch_init): Likewise.
4523         * aarch64-tdep.h (aarch64_read_description): Likewise.
4524         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4525         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4526         * features/Makefile: Add new files.
4527         * features/aarch64-pauth.c: New file.
4528         * features/aarch64-pauth.xml: New file.
4529
4530 2019-03-20  Tom Tromey  <tromey@adacore.com>
4531
4532         * infrun.c (handle_inferior_event): Rename from
4533         handle_inferior_event_1.  Create a scoped_value_mark.
4534         (handle_inferior_event): Remove.
4535
4536 2019-03-19  Tom Tromey  <tromey@adacore.com>
4537
4538         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4539         * infrun.h (print_stop_event): Add "displays" parameter.
4540         * infrun.c (print_stop_event): Add "displays" parameter.
4541
4542 2019-03-19  Pedro Alves  <palves@redhat.com>
4543
4544         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4545         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4546         to -1.  Fix TABs vs spaces.
4547         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4548         * tui/tui-out.h (tui_ui_out) Add intro comments.
4549         <m_line, m_start_of_line>: In-class initialize, and add describing
4550         comment.
4551
4552 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4553
4554         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4555         variable names.
4556         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4557
4558 2019-03-18  Pedro Alves  <palves@redhat.com>
4559             Eli Zaretskii <eliz@gnu.org>
4560
4561         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4562         m_line and m_start_of_line.
4563
4564 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4565
4566         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4567         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4568         it returns a newline.  This fixes a regression in TU mode, whereby
4569         the next line is output on the same screen line as the user input.
4570
4571 2019-03-18  Tom Tromey  <tromey@adacore.com>
4572
4573         * minsyms.c (minimal_symbol_reader::install): Remove call to
4574         obstack_blank.
4575
4576 2019-03-18  Pedro Alves  <palves@redhat.com>
4577
4578         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4579         New globals.
4580         (apply_style): New, factored out from ...
4581         (apply_ansi_escape): ... this.  Handle reverse video mode.
4582         (tui_set_reverse_mode): New function.
4583         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4584         * tui/tui-winsource.c (tui_show_source_line): Use
4585         tui_set_reverse_mode instead of setting A_STANDOUT.
4586         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4587         New setter methods.
4588
4589 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4590
4591         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4592         Handle tabs.
4593
4594 2019-03-18  Tom Tromey  <tromey@adacore.com>
4595
4596         * ada-lang.c (empty_array): Add "high" parameter.
4597         (ada_evaluate_subexp): Update.
4598
4599 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4600
4601         * unittests/string_view-selftests.c: Define
4602         _initialize_string_view_selftests unconditionally.
4603
4604 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4605
4606         PR gdb/24350
4607         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4608
4609 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4610
4611         PR gdb/24351
4612         * windows-nat.c (display_selector): Fix format specifiers.
4613
4614 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4615
4616         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4617         tui_refill_source_window instead of tui_refresh_win, to update the
4618         current execution line.  This fixes redisplay of the current line
4619         when stepping through the code with "next" or "step".
4620
4621 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4622
4623         * source-cache.c (source_cache::get_source_lines): Call
4624         find_source_lines to initialize s->nlines.  This fixes vertical
4625         scrolling of TUI source window when the DOWN arrow is pressed.
4626
4627 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4628
4629         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4630         linux-thread-db.c (_initialize_thread_db): Likewise.
4631
4632 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4633
4634         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4635         wclrtoeol in tui_show_source_line".  This reverts changes made in
4636         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4637
4638 2019-03-15  Tom Tromey  <tom@tromey.com>
4639
4640         * symtab.h (struct minimal_symbol): Derive from
4641         general_symbol_info.
4642         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4643         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4644         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4645         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4646         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4647         (MSYMBOL_SEARCH_NAME): Update.
4648         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4649         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4650         * minsyms.c (minimal_symbol_reader::record_full): Update.
4651
4652 2019-03-15  Tom Tromey  <tom@tromey.com>
4653
4654         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4655
4656 2019-03-15  Tom Tromey  <tom@tromey.com>
4657
4658         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4659         unique_xmalloc_ptr.
4660         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4661         Update.
4662         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4663         (build_minimal_symbol_hash_tables)
4664         (minimal_symbol_reader::install): Update.
4665
4666 2019-03-15  Tom Tromey  <tom@tromey.com>
4667
4668         * symtab.c (create_demangled_names_hash): Update.
4669         (symbol_set_names): Update.
4670         * objfiles.h (struct objfile_per_bfd_storage)
4671         <demangled_names_hash>: Now an htab_up.
4672         * objfiles.c (objfile_per_bfd_storage): Simplify.
4673
4674 2019-03-15  Tom Tromey  <tom@tromey.com>
4675
4676         * objfiles.h (struct objfile_per_bfd_storage): Declare
4677         destructor.
4678         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4679         New.
4680         (get_objfile_bfd_data): Use new.  Don't initialize
4681         language_of_main.
4682         (free_objfile_per_bfd_storage): Remove.
4683         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4684
4685 2019-03-15  Tom Tromey  <tom@tromey.com>
4686
4687         * symfile.c (reread_symbols): Update.
4688         * objfiles.c (objfile::objfile): Update.
4689         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4690         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4691         comment.
4692         (minimal_symbol_reader::install): Update.
4693         (terminate_minimal_symbol_table): Remove.
4694         * jit.c (jit_object_close_impl): Update.
4695
4696 2019-03-15  Tom Tromey  <tom@tromey.com>
4697
4698         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4699         initializations.
4700
4701 2019-03-15  Tom Tromey  <tom@tromey.com>
4702
4703         * objfiles.h (struct objfile_per_bfd_storage)
4704         <demangled_hash_languages>: Now a bitset.
4705         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4706         (lookup_minimal_symbol): Update.
4707
4708 2019-03-15  Tom Tromey  <tom@tromey.com>
4709
4710         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4711         Don't return the symbol.
4712         * coffread.c (record_minimal_symbol): Use record_full.
4713
4714 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4715
4716         The MS-Windows port of ncurses fails to switch to a color pair if
4717         one or both of the colors are the implicit default colors.  This
4718         change records the default colors when TUI is initialized, and
4719         then specifies them explicitly when a color pair uses the default
4720         colors.  This allows color styling in TUI mode on MS-Windows.
4721
4722         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4723         ncurses_norm_attr.
4724         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4725         colors in ncurses_norm_attr.
4726         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4727         "none", replace it with the default color recorded in
4728         ncurses_norm_attr.
4729
4730 2019-03-14  Tom Tromey  <tromey@adacore.com>
4731
4732         * source-cache.h (class source_cache) <get_source_lines>: Return
4733         std::string.
4734         * source-cache.c (source_cache::extract_lines): Handle case where
4735         first_pos==npos.  Return std::string.
4736         (source_cache::get_source_lines): Update.
4737
4738 2019-03-14  Tom Tromey  <tromey@adacore.com>
4739
4740         * NEWS: Add item for "style sources" commands.
4741         * source-cache.c (source_cache::get_source_lines): Check
4742         source_styling.
4743         * cli/cli-style.c (source_styling): New global.
4744         (_initialize_cli_style): Add "style sources" commands.
4745         (show_style_sources): New function.
4746         * cli/cli-style.h (source_styling): Declare.
4747
4748 2019-03-14  Pedro Alves  <palves@redhat.com>
4749             Tom Tromey  <tromey@adacore.com>
4750
4751         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4752         * tui/tui-winsource.c (tui_refill_source_window): New function,
4753         from...
4754         (tui_horizontal_source_scroll): ... here.  Move some logic.
4755         * cli/cli-style.c (set_style_enabled): Notify new observable.
4756         * tui/tui-hooks.c (tui_redisplay_source): New function.
4757         (tui_attach_detach_observers): Attach or detach
4758         tui_redisplay_source.
4759         * observable.h (source_styling_changed): New observable.
4760         * observable.c: Define source_styling_changed observable.
4761
4762 2019-03-13  Tom Tromey  <tromey@adacore.com>
4763
4764         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4765         (i386_gnu_nat_target::store_registers): Update.
4766         * target-debug.h (target_debug_print_std_string): New macro.
4767         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4768         * windows-tdep.c (display_one_tib): Update.
4769         * tui/tui-stack.c (tui_make_status_line): Update.
4770         * top.c (print_inferior_quit_action): Update.
4771         * thread.c (thr_try_catch_cmd): Update.
4772         (add_thread_with_info): Update.
4773         (thread_target_id_str): Update.
4774         (thr_try_catch_cmd): Update.
4775         (thread_command): Update.
4776         (thread_find_command): Update.
4777         * record-btrace.c (record_btrace_target::info_record)
4778         (record_btrace_resume_thread, record_btrace_target::resume)
4779         (record_btrace_cancel_resume, record_btrace_step_thread)
4780         (record_btrace_target::wait, record_btrace_target::wait)
4781         (record_btrace_target::wait, record_btrace_target::stop): Update.
4782         * progspace.c (print_program_space): Update.
4783         * process-stratum-target.c
4784         (process_stratum_target::thread_address_space): Update.
4785         * linux-fork.c (linux_fork_mourn_inferior)
4786         (detach_checkpoint_command, info_checkpoints_command)
4787         (linux_fork_context): Update.
4788         (linux_fork_detach): Update.
4789         (class scoped_switch_fork_info): Update.
4790         (delete_checkpoint_command): Update.
4791         * infrun.c (follow_fork_inferior): Update.
4792         (follow_fork_inferior): Update.
4793         (proceed_after_vfork_done): Update.
4794         (handle_vfork_child_exec_or_exit): Update.
4795         (follow_exec): Update.
4796         (displaced_step_prepare_throw): Update.
4797         (displaced_step_restore): Update.
4798         (start_step_over): Update.
4799         (resume_1): Update.
4800         (clear_proceed_status_thread): Update.
4801         (proceed): Update.
4802         (print_target_wait_results): Update.
4803         (do_target_wait): Update.
4804         (context_switch): Update.
4805         (stop_all_threads): Update.
4806         (restart_threads): Update.
4807         (finish_step_over): Update.
4808         (handle_signal_stop): Update.
4809         (switch_back_to_stepped_thread): Update.
4810         (keep_going_pass_signal): Update.
4811         (print_exited_reason): Update.
4812         (normal_stop): Update.
4813         * inferior.c (inferior_pid_to_str): Change return type.
4814         (print_selected_inferior): Update.
4815         (add_inferior): Update.
4816         (detach_inferior): Update.
4817         * dummy-frame.c (fprint_dummy_frames): Update.
4818         * dcache.c (dcache_info_1): Update.
4819         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4820         (btrace_fetch, btrace_clear): Update.
4821         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4822         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4823         type.
4824         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4825         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4826         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4827         * gdbarch.c, gdbarch.h: Rebuild.
4828         * gdbarch.sh (core_pid_to_str): Change return type.
4829         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4830         return type.
4831         (windows_nat_target::pid_to_str): Change return type.
4832         (windows_delete_thread): Update.
4833         (windows_nat_target::attach): Update.
4834         (windows_nat_target::files_info): Update.
4835         * target-delegates.c: Rebuild.
4836         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4837         return type.
4838         (sol_thread_target::pid_to_str): Change return type.
4839         * remote.c (class remote_target) <pid_to_str>: Change return
4840         type.
4841         (remote_target::pid_to_str): Change return type.
4842         (extended_remote_target::attach, remote_target::remote_stop_ns)
4843         (remote_target::remote_notif_remove_queued_reply)
4844         (remote_target::push_stop_reply, remote_target::disable_btrace):
4845         Update.
4846         (extended_remote_target::attach): Update.
4847         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4848         type.
4849         (gdbsim_target::pid_to_str): Change return type.
4850         * ravenscar-thread.c (struct ravenscar_thread_target)
4851         <pid_to_str>: Change return type.
4852         (ravenscar_thread_target::pid_to_str): Change return type.
4853         * procfs.c (class procfs_target) <pid_to_str>: Change return
4854         type.
4855         (procfs_target::pid_to_str): Change return type.
4856         (procfs_target::attach): Update.
4857         (procfs_target::detach): Update.
4858         (procfs_target::fetch_registers): Update.
4859         (procfs_target::store_registers): Update.
4860         (procfs_target::wait): Update.
4861         (procfs_target::files_info): Update.
4862         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4863         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4864         return type.
4865         (nto_procfs_target::pid_to_str): Change return type.
4866         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4867         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4868         return type.
4869         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4870         (exit_lwp): Update.
4871         (attach_proc_task_lwp_callback, get_detach_signal)
4872         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4873         (linux_nat_target::resume, wait_lwp, stop_callback)
4874         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4875         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4876         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4877         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4878         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4879         type.
4880         (inf_ptrace_target::attach): Update.
4881         (inf_ptrace_target::files_info): Update.
4882         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4883         type.
4884         (go32_nat_target::pid_to_str): Change return type.
4885         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4886         (gnu_nat_target::wait): Update.
4887         (gnu_nat_target::wait): Update.
4888         (gnu_nat_target::resume): Update.
4889         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4890         (fbsd_nat_target::wait): Update.
4891         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4892         type.
4893         (darwin_nat_target::attach): Update.
4894         * corelow.c (class core_target) <pid_to_str>: Change return type.
4895         (core_target::pid_to_str): Change return type.
4896         * target.c (normal_pid_to_str): Change return type.
4897         (default_pid_to_str): Likewise.
4898         (target_pid_to_str): Change return type.
4899         (target_translate_tls_address): Update.
4900         (target_announce_detach): Update.
4901         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4902         return type.
4903         (bsd_uthread_target::pid_to_str): Change return type.
4904         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4905         type.
4906         (bsd_kvm_target::pid_to_str): Change return type.
4907         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4908         return type.
4909         (aix_thread_target::pid_to_str): Change return type.
4910         * target.h (struct target_ops) <pid_to_str>: Change return type.
4911         (target_pid_to_str, normal_pid_to_str): Likewise.
4912         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4913         type.
4914         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4915         type.
4916         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4917         return type.
4918         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4919         type.
4920         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4921         type.
4922         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4923         return type.
4924
4925 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4926
4927         * NEWS: Mention that the new default MI version is 3.  Mention
4928         changes to the output of commands and events that deal with
4929         multi-location breakpoints.
4930         * breakpoint.c: Include "mi/mi-out.h".
4931         (print_one_breakpoint): Change output syntax if using MI version
4932         >= 3.
4933         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4934         New.
4935         (mi_multi_location_breakpoint_output_fixed): New.
4936         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4937         (mi_cmd_fix_multi_location_breakpoint_output): New.
4938         (mi_multi_location_breakpoint_output_fixed): New.
4939         * mi/mi-cmds.c (mi_cmds): Register command
4940         -fix-multi-location-breakpoint-output.
4941         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4942         interpreter "mi".
4943
4944 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4945
4946         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4947         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4948         instantiate mi_ui_out based on interpreter name.
4949         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4950         * mi/mi-main.c (mi_load_progress): Likewise.
4951
4952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4953
4954         * NEWS: Combine separate "New targets" sections for 8.3.
4955
4956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4957
4958         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4959         (ppcfbsd_init_abi): Install gdbarch
4960         "fetch_tls_load_module_address" and "get_thread_local_address"
4961         methods.
4962
4963 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4964
4965         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4966         (riscv_fbsd_init_abi): Install gdbarch
4967         "fetch_tls_load_module_address" and "get_thread_local_address"
4968         methods.
4969
4970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4971
4972         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4973         (i386fbsd_init_abi): Install gdbarch
4974         "fetch_tls_load_module_address" and "get_thread_local_address"
4975         methods.
4976
4977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4978
4979         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4980         (amd64fbsd_init_abi): Install gdbarch
4981         "fetch_tls_load_module_address" and "get_thread_local_address"
4982         methods.
4983
4984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4985
4986         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4987         (struct fbsd_pspace_data): New type.
4988         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4989         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4990         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4991         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4992         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4993
4994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4995
4996         * gdbtypes.c (lookup_struct_elt): New function.
4997         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4998         * gdbtypes.h (struct struct_elt): New type.
4999         (lookup_struct_elt): New prototype.
5000
5001 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5002
5003         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5004         remove disabled code block.
5005
5006 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5007
5008         * gdbarch.sh (get_thread_local_address): New method.
5009         * gdbarch.h, gdbarch.c: Regenerate.
5010         * target.c (target_translate_tls_address): Use
5011         gdbarch_get_thread_local_address if present instead of
5012         target::get_thread_local_address.
5013
5014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5015
5016         * target.h (target::get_thread_local_address): Update comment.
5017
5018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5019
5020         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5021         objfile->separate_debug_objfile_backlink if not NULL.
5022
5023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5024
5025         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5026         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5027         (amd64bsd_store_inferior_registers): Likewise.
5028         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5029         Enable segment base registers.
5030         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5031         PT_GETFSBASE and PT_GETGSBASE.
5032         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5033         PT_SETGSBASE.
5034         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5035         segment base registers.
5036         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5037
5038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5039
5040         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5041         Update calls to i386_target_description to add 'segments'
5042         parameter.
5043         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5044         add segment base registers.
5045         * arch/i386.c (i386_create_target_description): Add 'segments'
5046         parameter to enable segment base registers.
5047         * arch/i386.h (i386_create_target_description): Likewise.
5048         * features/i386/32bit-segments.xml: New file.
5049         * features/i386/32bit-segments.c: Generate.
5050         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5051         call to i386_target_description to add 'segments' parameter.
5052         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5053         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5054         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5055         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5056         if feature is present.
5057         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5058         Add 'segments' parameter to call to i386_target_description.
5059         (i386_target_description): Add 'segments' parameter to enable
5060         segment base registers.
5061         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5062         to call to i386_target_description.
5063         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5064         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5065         Define I386_NUM_REGS.
5066         (i386_target_description): Add 'segments' parameter to enable
5067         segment base registers.
5068
5069 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5070
5071         PR/24325
5072         * source-cache.c: #undef open and close, to avoid unresolved
5073         externals during linking.
5074
5075 2019-03-12  Tom Tromey  <tromey@adacore.com>
5076
5077         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5078         const.  Add initializers.
5079         (_initialize_remote): Don't initialize ptid globals.
5080
5081 2019-03-12  Pedro Alves  <palves@redhat.com>
5082
5083         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5084
5085 2019-03-12  Pedro Alves  <palves@redhat.com>
5086
5087         * cp-name-parser.y (main): Remove unused 'len' variable.
5088
5089 2019-03-12  Tom Tromey  <tromey@adacore.com>
5090
5091         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5092         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5093
5094 2019-03-12  Tom Tromey  <tromey@adacore.com>
5095
5096         * linux-nat.c (iterate_over_lwps): Update.
5097         (stop_callback): Remove parameter.
5098         (stop_wait_callback, detach_callback, resume_set_callback)
5099         (select_singlestep_lwp_callback, set_ignore_sigint)
5100         (status_callback, resumed_callback, resume_clear_callback)
5101         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5102         data parameter.
5103         (linux_nat_target::detach, linux_nat_target::resume)
5104         (linux_stop_and_wait_all_lwps, select_event_lwp)
5105         (linux_nat_filter_event, linux_nat_wait_1)
5106         (linux_nat_target::kill, linux_nat_target::stop)
5107         (linux_nat_target::stop): Update.
5108         (linux_nat_resume_callback): Change type.
5109         (resume_stopped_resumed_lwps, count_events_callback)
5110         (select_event_lwp_callback): Likewise.
5111         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5112         * arm-linux-nat.c (struct update_registers_data): Remove.
5113         (update_registers_callback): Change type.
5114         (arm_linux_insert_hw_breakpoint1): Update.
5115         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5116         parameter.
5117         (x86_linux_dr_set_addr): Update.
5118         (x86_linux_dr_set_control): Update.
5119         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5120         (iterate_over_lwps): Use gdb::function_view.
5121         * nat/aarch64-linux-hw-point.c (struct
5122         aarch64_dr_update_callback_param): Remove.
5123         (debug_reg_change_callback): Change type.
5124         (aarch64_notify_debug_reg_change): Update.
5125         * s390-linux-nat.c (s390_refresh_per_info): Update.
5126
5127 2019-03-11  Tom Tromey  <tromey@adacore.com>
5128
5129         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5130         redundant assignment to "this_cu".
5131
5132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5133
5134         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5135
5136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5137
5138         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5139         from...
5140         (rank_one_type): ... this.
5141
5142 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5143
5144         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5145         from...
5146         (rank_one_type): ... this.
5147
5148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5149
5150         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5151         from...
5152         (rank_one_type): ... this.
5153
5154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5155
5156         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5157         from...
5158         (rank_one_type): ... this.
5159
5160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5161
5162         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5163         from...
5164         (rank_one_type): ... this.
5165
5166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5167
5168         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5169         from...
5170         (rank_one_type): ... this.
5171
5172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5173
5174         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5175         from...
5176         (rank_one_type): ... this.
5177
5178 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5179
5180         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5181         from...
5182         (rank_one_type): ... this.
5183
5184 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5185
5186         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5187         from...
5188         (rank_one_type): ... this.
5189
5190 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5191
5192         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5193         from...
5194         (rank_one_type): ... this.
5195
5196 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5197
5198         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5199         from...
5200         (rank_one_type): ... this.
5201
5202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5203
5204         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5205         from...
5206         (rank_one_type): ... this.
5207
5208 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5209
5210         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5211         inferior-events' shows the example events.
5212
5213 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5214
5215         Support styling on native MS-Windows console
5216
5217         PR/24315
5218         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5219         on MS-Windows if $TERM is not defined.
5220
5221         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5222
5223         * posix-hdep.c (gdb_console_fputs):
5224         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5225         functions.
5226         * ui-file.h (gdb_console_fputs): Add prototype.
5227
5228         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5229         back to fputs only if the former returns zero.
5230
5231 2019-03-07  Tom Tromey  <tom@tromey.com>
5232
5233         * symmisc.c (print_symbol_bcache_statistics): Update.
5234         (print_objfile_statistics): Update.
5235         * symfile.c (allocate_symtab): Update.
5236         * stabsread.c: Don't include bcache.h.
5237         * psymtab.h (struct psymbol_bcache): Don't declare.
5238         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5239         (psymbol_bcache_init, psymbol_bcache_free)
5240         (psymbol_bcache_get_bcache): Don't declare.
5241         * psymtab.c (struct psymbol_bcache): Remove.
5242         (psymtab_storage::psymtab_storage): Update.
5243         (psymtab_storage::~psymtab_storage): Update.
5244         (psymbol_bcache_init, psymbol_bcache_free)
5245         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5246         (add_psymbol_to_bcache): Update.
5247         (allocate_psymtab): Update.
5248         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5249         macro_cache>: No longer pointers.
5250         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5251         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5252         * macrotab.c (macro_bcache): Update.
5253         * macroexp.c: Don't include bcache.h.
5254         * gdbtypes.c (check_types_worklist): Update.
5255         (types_deeply_equal): Remove TRY/CATCH.  Update.
5256         * elfread.c (elf_symtab_read): Update.
5257         * dwarf2read.c: Don't include bcache.h.
5258         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5259         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5260         (print_bcache_statistics, bcache_memory_used): Don't declare.
5261         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5262         methods.  Rename all data members.
5263         * bcache.c (struct bcache): Move to bcache.h.
5264         (bcache::expand_hash_table): Rename from expand_hash_table.
5265         (bcache): Remove.
5266         (bcache::insert): Rename from bcache_full.
5267         (bcache::compare): Rename from bcache_compare.
5268         (bcache_xmalloc): Remove.
5269         (bcache::~bcache): Rename from bcache_xfree.
5270         (bcache::print_statistics): Rename from print_bcache_statistics.
5271         (bcache::memory_used): Rename from bcache_memory_used.
5272
5273 2019-03-07  Pedro Alves  <palves@redhat.com>
5274
5275         * infrun.c (normal_stop): Also check for
5276         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5277
5278 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5279
5280         * f-lang.c (value_from_host_double): Moved to...
5281         * value.c (value_from_host_double): ...here.
5282         * value.h (value_from_host_double): Declare.
5283         * guile/scm-math.c (vlscm_convert_typed_number): Use
5284         value_from_host_double.
5285         (vlscm_convert_number): Likewise.
5286         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5287         * python/py-value.c (convert_value_from_python): Likewise.
5288
5289 2019-03-06  Tom Tromey  <tom@tromey.com>
5290
5291         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5292
5293 2019-03-06  Tom Tromey  <tom@tromey.com>
5294
5295         * utils.h (free_current_contents): Don't declare.
5296         * utils.c (free_current_contents): Remove.
5297
5298 2019-03-06  Tom Tromey  <tom@tromey.com>
5299
5300         * top.c (quit_force): Update.
5301         * main.c (captured_command_loop): Update.
5302         * common/new-op.c (operator new): Update.
5303         * common/common-exceptions.c (struct catcher)
5304         <save_cleanup_chain>: Remove member.
5305         (exceptions_state_mc_init): Update.
5306         (exception_try_scope_entry): Return nullptr.
5307         (exception_try_scope_exit, exception_rethrow)
5308         (throw_exception_sjlj, throw_exception_cxx): Update.
5309         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5310         (all_cleanups, do_cleanups, discard_cleanups)
5311         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5312         (restore_cleanups, restore_final_cleanups): Don't declare.
5313         (do_final_cleanups): Remove parameter.
5314         * common/cleanups.c (cleanup_chain, make_cleanup)
5315         (make_cleanup_dtor, all_cleanups, do_cleanups)
5316         (discard_my_cleanups, discard_cleanups)
5317         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5318         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5319         (null_cleanup): Remove.
5320         (do_final_cleanups): Remove parameter.
5321
5322 2019-03-06  Tom Tromey  <tom@tromey.com>
5323
5324         * remote.c (remote_target::remote_parse_stop_reply): Use
5325         unique_xmalloc_ptr.
5326
5327 2019-03-06  Tom Tromey  <tom@tromey.com>
5328
5329         * stabsread.c (struct stabs_field_info): Rename from field_info.
5330         <list, fnlist>: Add initializers.
5331         <obstack>: New member.
5332         (read_member_functions, read_struct_fields, read_baseclasses):
5333         Allocate on obstack.  Don't use cleanups.
5334         (read_one_struct_field, read_member_functions, read_struct_fields)
5335         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5336         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5337         (read_struct_type): Update.
5338
5339 2019-03-06  Tom Tromey  <tom@tromey.com>
5340
5341         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5342         * common/filestuff.h (make_cleanup_close): Don't declare.
5343         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5344         Remove.
5345
5346 2019-03-06  Tom Tromey  <tom@tromey.com>
5347
5348         * solib-aix.c: Use make_scope_exit.
5349
5350 2019-03-06  Tom Tromey  <tom@tromey.com>
5351
5352         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5353         Use make_scope_exit.
5354
5355 2019-03-06  Tom Tromey  <tom@tromey.com>
5356
5357         * solib-svr4.c (disable_probes_interface): Remove parameter.
5358         (svr4_handle_solib_event): Use make_scope_exit.
5359
5360 2019-03-06  Tom Tromey  <tom@tromey.com>
5361
5362         * remote.c (struct stop_reply_deleter): Remove.
5363         (stop_reply_up): Update.
5364         (struct stop_reply): Derive from notif_event.  Don't typedef.
5365         <regcache>: Now a std::vector.
5366         (stop_reply_xfree): Remove.
5367         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5368         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5369         (remote_target::discard_pending_stop_replies): Use delete.
5370         (remote_target::remote_parse_stop_reply): Update.
5371         (remote_target::process_stop_reply): Update.
5372         * remote-notif.h (struct notif_event): Add virtual destructor.
5373         Remove "dtr" member.
5374         (struct notif_client) <alloc_event>: Return a unique_ptr.
5375         (notif_event_xfree): Don't declare.
5376         (notif_event_up): New typedef.
5377         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5378         (notif_event_xfree, do_notif_event_xfree): Remove.
5379         (remote_notif_state_xfree): Update.
5380
5381 2019-03-06  Tom Tromey  <tom@tromey.com>
5382
5383         * infrun.c (displaced_step_clear_cleanup): Now a
5384         forward_scope_exit type.
5385         (displaced_step_prepare_throw): Update.
5386         (displaced_step_fixup): Update.
5387
5388 2019-03-06  Tom Tromey  <tom@tromey.com>
5389
5390         * inferior.h (class inferior): Update comment.
5391         * gdbthread.h (class thread_info): Update comment.
5392
5393 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5394             Tom Tromey  <tom@tromey.com>
5395
5396         * stabsread.h (struct stab_section_list): Remove.
5397         (coffstab_build_psymtabs): Update.
5398         * dbxread.c (symbuf_sections): Now a std::vector.
5399         (sect_idx): New global.
5400         (fill_symbuf): Update.
5401         (coffstab_build_psymtabs): Change type of stabsects parameter.
5402         Update.
5403         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5404         std::vector.
5405         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5406         (coff_locate_sections): Update.
5407         (coff_symfile_read): Remove cleanups.  Update.
5408         (init_stringtab): Add storage parameter.
5409         (free_stringtab, free_stringtab_cleanup): Remove.
5410         (init_lineno): Add storage parameter.
5411         (free_linetab, free_linetab_cleanup): Remove.
5412
5413 2019-03-06  Pedro Alves  <palves@redhat.com>
5414
5415         * linux-fork.c (fork_info::clobber_regs): Delete.
5416         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5417         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5418         comment.  Adjust.
5419         (scoped_switch_fork_info::scoped_switch_fork_info)
5420         (checkpoint_command, linux_fork_context): Adjust
5421         fork_save_infrun_state calls.
5422
5423 2019-03-06  Pedro Alves  <palves@redhat.com>
5424
5425         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5426         (inf_has_multiple_threads): Return 'bool' and rewrite using
5427         inferior_info::threads().
5428
5429 2019-03-06  Pedro Alves  <palves@redhat.com>
5430
5431         * linux-fork.c: Include <list>.
5432         (fork_list): Now a std::list instance.
5433         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5434         (forks_exist_p, find_last_fork): Adjust.
5435         (new_fork): Delete.
5436         (one_fork_p): New.
5437         (add_fork): Adjust.
5438         (free_fork): Delete, folded into fork_info::~fork_info().
5439         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5440         Adjust.
5441         (init_fork_list): Delete.
5442         (linux_fork_killall, linux_fork_mourn_inferior)
5443         (linux_fork_detach, info_checkpoints_command): Adjust.
5444         (_initialize_linux_fork): No longer call init_fork_list.
5445
5446 2019-03-06  Pedro Alves  <palves@redhat.com>
5447
5448         * linux-fork.c (new_fork): New, split out of ...
5449         (add_fork): ... this.  Return void.  Move "first fork" special
5450         case from here, to ...
5451         (checkpoint_command): ... here.
5452         * linux-linux.h (add_fork): Return void.
5453
5454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5455
5456         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5457
5458 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5459             Chris January  <chris.january@arm.com>
5460             David Lecomber  <david.lecomber@arm.com>
5461
5462         * f-exp.y: New token, UNOP_INTRINSIC.
5463         (exp): New pattern using UNOP_INTRINSIC token.
5464         (f77_keywords): Add 'abs' keyword.
5465         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5466         (value_from_host_double): New function.
5467         (evaluate_subexp_f): Support UNOP_ABS.
5468
5469 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5470
5471         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5472         types.
5473
5474 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5477         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5478         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5479
5480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5481
5482         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5483
5484 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5485             Chris January  <chris.january@arm.com>
5486
5487         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5488         * f-exp.y: Define 'KIND' token.
5489         (exp): New pattern for KIND expressions.
5490         (ptype): Handle types with a kind extension.
5491         (direct_abs_decl): Extend to spot kind extensions.
5492         (f77_keywords): Add 'kind' to the list.
5493         (push_kind_type): New function.
5494         (convert_to_kind_type): New function.
5495         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5496         * parse.c (operator_length_standard): Likewise.
5497         * parser-defs.h (enum type_pieces): Add tp_kind.
5498         * std-operator.def: Add UNOP_KIND.
5499
5500 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5501
5502         * f-exp.y (f_parse): Set yydebug.
5503
5504 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5505
5506         * f-lang.c (evaluate_subexp_f): New function.
5507         (exp_descriptor_f): New global.
5508         (f_language_defn): Use exp_descriptor_f instead of
5509         exp_descriptor_standard.
5510
5511 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5512
5513         * f-exp.y (struct token): Add comments.
5514         (dot_ops): Remove uppercase versions and the end marker.
5515         (f77_keywords): Likewise.
5516         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5517         entries in the dot_ops array are case insensitive, and use
5518         strncasecmp to compare strings.  Also some whitespace cleanup in
5519         this area.  Similar for the f77_keywords array, except entries in
5520         this list might be case sensitive.
5521
5522 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5523
5524         * f-exp.y (struct f77_boolean_val): Add comments.
5525         (boolean_values): Remove uppercase versions, and end marker.
5526         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5527         and use strncasecmp to achieve case insensitivity.  Additionally,
5528         perform whitespace cleanup around this code.
5529
5530 2019-03-06  Tom Tromey  <tromey@adacore.com>
5531
5532         * remote-sim.c (gdbsim_target_open): Use result of
5533         gdb_argv::release.
5534
5535 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5536         Dirk Schubert  <dirk.schubert@arm.com>
5537         Chris January  <chris.january@arm.com>
5538
5539         * eval.c (evaluate_subexp_standard): Call Fortran argument
5540         wrapping logic.
5541         * f-lang.c (struct value): A value which can be passed into a
5542         Fortran function call.
5543         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5544         where appropriate.
5545         (struct type): Value ready for a Fortran function call.
5546         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5547         is needed.
5548         * f-lang.h (fortran_argument_convert): Declaration.
5549         (fortran_preserve_arg_pointer): Declaration.
5550         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5551
5552 2019-03-05  Tom Tromey  <tromey@adacore.com>
5553
5554         * python/py-prettyprint.c (print_string_repr): Remove #if.
5555         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5556
5557 2019-03-05  Tom Tromey  <tromey@adacore.com>
5558
5559         * target.c (the_dummy_target): Move later.  Change type to
5560         "dummy_target".
5561         (initialize_targets): Don't initialize the_dummy_target.
5562
5563 2019-03-05  Tom Tromey  <tromey@adacore.com>
5564
5565         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5566         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5567
5568 2019-03-05  Tom Tromey  <tromey@adacore.com>
5569
5570         * windows-nat.c (windows_nat_target::attach)
5571         (windows_nat_target::detach): Don't call gdb_flush.
5572         * valprint.c (generic_val_print, val_print, val_print_string):
5573         Don't call gdb_flush.
5574         * utils.c (defaulted_query): Don't call gdb_flush.
5575         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5576         * target.c (target_announce_detach): Don't call gdb_flush.
5577         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5578         * remote.c (extended_remote_target::attach): Don't call
5579         gdb_flush.
5580         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5581         * printcmd.c (do_examine): Don't call gdb_flush.
5582         (info_display_command): Don't call gdb_flush.
5583         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5584         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5585         * memattr.c (info_mem_command): Don't call gdb_flush.
5586         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5587         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5588         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5589         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5590         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5591         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5592         (gnu_nat_target::detach): Don't call gdb_flush.
5593         * f-valprint.c (f_val_print): Don't call gdb_flush.
5594         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5595         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5596         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5597         gdb_flush.
5598         * c-valprint.c (c_val_print): Don't call gdb_flush.
5599         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5600
5601 2019-03-05  Tom Tromey  <tromey@adacore.com>
5602
5603         * varobj.c (update_dynamic_varobj_children): Update.
5604         (install_default_visualizer): Use reset, not release.
5605         * value.c (set_internalvar): Update.
5606         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5607         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5608         ATTRIBUTE_UNUSED_RESULT.
5609
5610 2019-03-05  Tom Tromey  <tromey@adacore.com>
5611
5612         * remote.c (class scoped_remote_fd) <release>: Add
5613         ATTRIBUTE_UNUSED_RESULT.
5614
5615 2019-03-05  Tom Tromey  <tromey@adacore.com>
5616
5617         * macroexp.c (struct macro_buffer) <release>: Add
5618         ATTRIBUTE_UNUSED_RESULT.
5619
5620 2019-03-05  Tom Tromey  <tromey@adacore.com>
5621
5622         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5623         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5624         ATTRIBUTE_UNUSED_RESULT.
5625
5626 2019-03-05  Tom Tromey  <tromey@adacore.com>
5627
5628         * common/scoped_fd.h (class scoped_fd) <release>: Add
5629         ATTRIBUTE_UNUSED_RESULT.
5630
5631 2019-03-05  Tom Tromey  <tromey@adacore.com>
5632
5633         * parser-defs.h (struct parser_state) <release>: Add
5634         ATTRIBUTE_UNUSED_RESULT.
5635
5636 2019-03-05  Tom Tromey  <tromey@adacore.com>
5637
5638         * utils.h (class gdb_argv) <release>: Add
5639         ATTRIBUTE_UNUSED_RESULT.
5640         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5641
5642 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5643
5644         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5645         for-loop range, to avoid compiler warnings.
5646
5647         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5648         avoid compiler warnings about unused variables.
5649
5650         * NEWS: Mention end of support for native debugging on MS-Windows
5651         before XP.
5652
5653         PR gdb/24292
5654         * common/netstuff.c:
5655         * gdbserver/gdbreplay.c
5656         * gdbserver/remote-utils.c:
5657         * ser-tcp.c:
5658         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5659         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5660         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5661         'getaddrinfo' and 'freeaddrinfo' were not available before
5662         Windows XP, and mingw.org's MinGW headers by default define
5663         _WIN32_WINNT to 0x500.
5664
5665 2019-03-01  Gary Benson <gbenson@redhat.com>
5666
5667         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5668
5669 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5670             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5671
5672         PR gdb/8527
5673         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5674         set_sigint_trap, clear_sigint_trap.
5675
5676 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5677
5678         * target.c (target_detach): Clear the regcache and the
5679         frame cache.
5680
5681 2019-02-27  Pedro Alves  <palves@redhat.com>
5682
5683         * utils.c (set_screen_size): When we cap the height/width sizes,
5684         tweak the corresponding command variable to show "unlimited":
5685
5686 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5687             Pedro Alves  <palves@redhat.com>
5688
5689         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5690         before calling rl_set_screen_size.
5691
5692 2019-02-27  Tom Tromey  <tromey@adacore.com>
5693
5694         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5695         define.
5696         * python/py-value.c: Remove Python 2.4 workaround.
5697         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5698         workaround.
5699         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5700         Python 2.4 workaround.
5701         * python/python-internal.h: Remove Python 2.4 comment.
5702         (Py_ssize_t): Don't define.
5703         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5704         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5705         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5706         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5707         * python/python.c (do_start_initialization): Remove Python 2.4
5708         workaround.
5709         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5710         (print_children): Remove Python 2.4 workaround.
5711         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5712         workaround.
5713         (CHARBUFFERPROC_NAME): Remove.
5714         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5715         Python 2.4 workaround.
5716
5717 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5718
5719         * NEWS: Note minimum Python version.
5720
5721 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5722
5723         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5724         code from these functions.  Remove corresponding ifdefs.  Use
5725         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5726         Remove gotos and target of gotos.
5727         (infpy_search_memory): Likewise.
5728
5729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5730
5731         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5732         (hppa_gdbarch_init): Don't register deleted functions with
5733         gdbarch.
5734
5735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5736
5737         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5738         (h8300_unwind_sp): Delete.
5739         (h8300_dummy_id): Delete.
5740         (h8300_gdbarch_init): Don't register deleted functions with
5741         gdbarch.
5742
5743 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5744
5745         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5746         (ft32_unwind_pc): Delete.
5747         (ft32_unwind_sp): Delete.
5748         (ft32_gdbarch_init): Don't register deleted functions with
5749         gdbarch.
5750
5751 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5752
5753         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5754         (frv_unwind_pc): Delete.
5755         (frv_unwind_sp): Delete.
5756         (frv_gdbarch_init): Don't register deleted functions with
5757         gdbarch.
5758
5759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5760
5761         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5762         (riscv_unwind_pc): Delete.
5763         (riscv_unwind_sp): Delete.
5764         (riscv_gdbarch_init): Don't register deleted functions with
5765         gdbarch.
5766
5767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5768
5769         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5770         (csky_unwind_pc): Delete.
5771         (csky_unwind_sp): Delete.
5772         (csky_gdbarch_init): Don't register deleted functions with
5773         gdbarch.
5774
5775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5776
5777         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5778         (cris_unwind_pc): Delete.
5779         (cris_unwind_sp): Delete.
5780         (cris_gdbarch_init): Don't register deleted functions with
5781         gdbarch.
5782
5783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5784
5785         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5786         (bfin_unwind_pc): Delete.
5787         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5788
5789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5790
5791         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5792         (arm_unwind_pc): Delete.
5793         (arm_unwind_sp): Delete.
5794         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5795
5796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5797
5798         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5799         (arc_unwind_pc): Delete.
5800         (arc_unwind_sp): Delete.
5801         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5802
5803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5804
5805         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5806         (alpha_unwind_pc): Delete.
5807         (alpha_gdbarch_init): Don't register deleted functions with
5808         gdbarch.
5809
5810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5811
5812         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5813         (aarch64_unwind_pc): Delete.
5814         (aarch64_unwind_sp): Delete.
5815         (aarch64_gdbarch_init): Don't register deleted functions with
5816         gdbarch.
5817
5818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5819
5820         * gdbtypes.c (type_align): Don't consider static members when
5821         computing structure alignment.
5822
5823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5824
5825         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5826         return 0 for other types.
5827         * arch-utils.c (default_type_align): Always return 0.
5828         * gdbarch.h: Regenerate.
5829         * gdbarch.sh (type_align): Extend comment.
5830         * gdbtypes.c (type_align): Add additional comments, always call
5831         gdbarch_type_align before applying the default rules.
5832         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5833         generic code will then apply a suitable default.
5834         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5835         types, return 0 for other types.
5836
5837 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5838
5839         * NEWS: Create a new section for the next release branch.
5840         Rename the section of the current branch, now that it has
5841         been cut.
5842
5843 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5844
5845         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5846         * version.in: Bump version to 8.3.50.DATE-git.
5847
5848 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5849
5850         * aix-thread.c (ptid_cmp): Remove unused variable.
5851         (get_signaled_thread): Likewise.
5852         (store_regs_user_thread): Likewise.
5853         (store_regs_kernel_thread): Likewise.
5854         (fetch_regs_kernel_thread): Remove shadowed variable.
5855
5856 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5857
5858         * features/riscv/32bit-cpu.xml: Add register numbers.
5859         * features/riscv/32bit-fpu.c: Regenerate.
5860         * features/riscv/32bit-fpu.xml: Add register numbers.
5861         * features/riscv/64bit-cpu.xml: Add register numbers.
5862         * features/riscv/64bit-fpu.c: Regenerate.
5863         * features/riscv/64bit-fpu.xml: Add register numbers.
5864
5865 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5866
5867         * NEWS: Mention two argument form of gdb.Value constructor.
5868         * python/py-value.c (convert_buffer_and_type_to_value): New
5869         function.
5870         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5871         Add support for handling an optional second argument.  Call
5872         convert_buffer_and_type_to_value as appropriate.
5873         * python/python-internal.h (Py_buffer_deleter): New struct.
5874         (Py_buffer_up): New typedef.
5875
5876 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5877
5878         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5879         instead of releasing ownership.
5880
5881 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5882
5883         * dwarf2read.c (open_and_init_dwp_file): Call
5884         elf_numsections instead of bfd_count_sections to initialize
5885         dwp_file->num_sections.
5886
5887 2019-02-25  Tom Tromey  <tromey@adacore.com>
5888
5889         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5890
5891 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5892
5893         * gcore.in: Add '--readnever' option when invoking GDB.
5894
5895 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5896
5897         * MAINTAINERS: Update my email address.
5898
5899 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5900
5901         * build-id.c (build_id_to_debug_bfd_1): New function.
5902         (build_id_to_debug_bfd): Look for separate debug file in
5903         sysroot.
5904
5905 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * gdbarch.sh: Update the copyright year range that is placed into
5908         generated files.
5909
5910 2019-02-22  Keith Seitz  <keiths@redhat.com>
5911
5912         PR symtab/23853
5913         * linespec.c (create_sals_line_offset): Search for the default
5914         symtab's filename instead of its fullname.
5915
5916 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5917
5918         * NEWS: Update style defaults.
5919
5920 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5921
5922         * main.c (captured_main_1): Disable styling in batch mode.
5923
5924 2019-02-20  Tom Tromey  <tom@tromey.com>
5925
5926         * symtab.c (symtab_symbol_info): Fix typos.
5927
5928 2019-02-20  Tom Tromey  <tromey@adacore.com>
5929
5930         * findcmd.c (_initialize_mem_search): Use upper case for
5931         metasyntactic variables.
5932
5933 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5934
5935         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5936         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5937
5938 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5939
5940         * top.h (source_file_name): Change to std::string.
5941         * top.c (source_file_name): Likewise.
5942         (command_line_input): Adjust.
5943         * cli/cli-script.c (script_from_file): Adjust.
5944
5945 2019-02-19  Tom Tromey  <tromey@adacore.com>
5946
5947         * ravenscar-thread.c
5948         (ravenscar_thread_target::update_thread_list): Don't call
5949         ada_build_task_list.
5950         * ada-lang.h (ada_build_task_list): Don't declare.
5951         * ada-tasks.c (struct ada_tasks_inferior_data)
5952         <task_list_valid_p>: Now bool.
5953         (read_known_tasks, ada_task_list_changed)
5954         (ada_tasks_invalidate_inferior_data): Update.
5955         (read_known_tasks_array): Return bool.
5956         (read_known_tasks_list): Likewise.
5957         (read_known_tasks): Return void.
5958         (ada_build_task_list): Now static.
5959
5960 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5961
5962         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5963         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5964
5965 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5966
5967         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5968         variant for ada_tasks_pspace_data_handle and
5969         ada_tasks_inferior_data_handle.
5970         (ada_tasks_pspace_data_cleanup): New function.
5971         (ada_tasks_inferior_data_cleanup): New function.
5972
5973 2019-02-17  Tom Tromey  <tom@tromey.com>
5974
5975         * macrotab.h (macro_source_fullname): Return a std::string.
5976         * macrotab.c (macro_include, check_for_redefinition)
5977         (macro_undef, macro_lookup_definition, foreach_macro)
5978         (foreach_macro_in_scope): Update.
5979         (macro_source_fullname): Return a std::string.
5980         * macrocmd.c (show_pp_source_pos): Update.
5981
5982 2019-02-17  Tom Tromey  <tom@tromey.com>
5983
5984         * macrocmd.c (show_pp_source_pos): Style the file names.
5985
5986 2019-02-17  Tom Tromey  <tom@tromey.com>
5987
5988         PR tui/24197:
5989         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5990
5991 2019-02-17  Tom Tromey  <tom@tromey.com>
5992
5993         * ada-lang.c (user_select_syms): Use filtered printing.
5994         * utils.c (wrap_style): New global.
5995         (desired_style): Remove.
5996         (emit_style_escape): Add stream parameter.
5997         (set_output_style, reset_terminal_style, prompt_for_continue):
5998         Update.
5999         (flush_wrap_buffer): Only flush gdb_stdout.
6000         (wrap_here): Set wrap_style.
6001         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6002         treat escape sequences as a character.  Change when wrap buffer is
6003         flushed.
6004         (fputs_styled): Do not set the output style when the default is
6005         requested.
6006         * ui-style.h (struct ui_file_style) <is_default>: New method.
6007         * source.c (print_source_lines_base): Emit escape sequences in one
6008         piece.
6009
6010 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6011
6012         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6013         integers and enumeration types.
6014
6015 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6016
6017         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6018         instead of lookup_symbol_in_language
6019         (do_exact_match): New function.
6020         (ada_get_symbol_name_matcher): Return do_exact_match when
6021         doing a verbatim match.
6022
6023 2019-02-15  Tom Tromey  <tromey@adacore.com>
6024
6025         * ravenscar-thread.c (ravenscar_thread_target::resume)
6026         (ravenscar_thread_target::wait): Special case wildcard requests.
6027
6028 2019-02-15  Tom Tromey  <tromey@adacore.com>
6029
6030         * ravenscar-thread.c (base_ptid): Remove.
6031         (struct ravenscar_thread_target) <close>: New method.
6032         <m_base_ptid>: New member.
6033         <update_inferior_ptid, active_task, task_is_currently_active,
6034         runtime_initialized>: Declare methods.
6035         <ravenscar_thread_target>: Add constructor.
6036         (ravenscar_thread_target::task_is_currently_active)
6037         (ravenscar_thread_target::update_inferior_ptid)
6038         (ravenscar_runtime_initialized): Rename.  Now methods.
6039         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6040         (ravenscar_thread_target::update_thread_list): Update.
6041         (ravenscar_thread_target::active_task): Now method.
6042         (ravenscar_thread_target::store_registers)
6043         (ravenscar_thread_target::prepare_to_store)
6044         (ravenscar_thread_target::prepare_to_store)
6045         (ravenscar_thread_target::mourn_inferior): Update.
6046         (ravenscar_inferior_created): Use "new" to create target.
6047         (ravenscar_thread_target::get_ada_task_ptid): Update.
6048         (_initialize_ravenscar): Don't initialize base_ptid.
6049         (ravenscar_ops): Remove global.
6050
6051 2019-02-15  Tom Tromey  <tromey@adacore.com>
6052
6053         * target.h (push_target): Declare new overload.
6054         * target.c (push_target): New overload, taking an rvalue reference.
6055         * remote.c (remote_target::open_1): Use push_target overload.
6056         * corelow.c (core_target_open): Use push_target overload.
6057
6058 2019-02-15  Tom Tromey  <tromey@adacore.com>
6059
6060         * ravenscar-thread.c (is_ravenscar_task)
6061         (ravenscar_task_is_currently_active): Return bool.
6062         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6063         (_initialize_ravenscar): Remove "(void)".
6064         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6065         Return bool.
6066
6067 2019-02-15  Tom Tromey  <tromey@adacore.com>
6068
6069         * ravenscar-thread.c (ravenscar_runtime_initializer)
6070         (has_ravenscar_runtime, get_running_thread_id)
6071         (ravenscar_thread_target::resume): Fix indentation.
6072
6073 2019-02-15  Tom Tromey  <tromey@adacore.com>
6074
6075         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6076         from ravenscar_arch_ops.
6077         (sparc_ravenscar_ops::fetch_registers)
6078         (sparc_ravenscar_ops::store_registers): Now methods.
6079         (sparc_ravenscar_prepare_to_store): Remove.
6080         (sparc_ravenscar_ops): Redefine.
6081         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6082         methods and destructor.  Remove members.
6083         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6084         (ravenscar_thread_target::store_registers)
6085         (ravenscar_thread_target::prepare_to_store): Update.
6086         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6087         Remove.
6088         (struct ppc_ravenscar_powerpc_ops): Derive from
6089         ravenscar_arch_ops.
6090         (ppc_ravenscar_powerpc_ops::fetch_registers)
6091         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6092         (ppc_ravenscar_powerpc_ops): Redefine.
6093         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6094         (ppc_ravenscar_e500_ops::fetch_registers)
6095         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6096         (ppc_ravenscar_e500_ops): Redefine.
6097         * aarch64-ravenscar-thread.c
6098         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6099         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6100         (aarch64_ravenscar_fetch_registers)
6101         (aarch64_ravenscar_store_registers): Now methods.
6102         (aarch64_ravenscar_ops): Redefine.
6103
6104 2019-02-15  Tom Tromey  <tromey@adacore.com>
6105
6106         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6107         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6108         (ravenscar_thread_target::stopped_by_watchpoint)
6109         (ravenscar_thread_target::stopped_data_address)
6110         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6111
6112 2019-02-15  Tom Tromey  <tromey@adacore.com>
6113
6114         * ravenscar-thread.c: Fix some typos.
6115
6116 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6117             Tom Tromey  <tromey@adacore.com>
6118
6119         * ada-lang.c (ada_exception_sal): Change addr_string to a
6120         std::string.
6121         (create_ada_exception_catchpoint): Update.
6122
6123 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6124             Tom Tromey  <tromey@adacore.com>
6125
6126         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6127         (bp_location_ops): Remove.
6128         (base_breakpoint_allocate_location): Update.
6129         (free_bp_location): Update.
6130         * ada-lang.c (class ada_catchpoint_location)
6131         <ada_catchpoint_location>: Remove ops parameter.
6132         (ada_catchpoint_location_dtor): Remove.
6133         (ada_catchpoint_location_ops): Remove.
6134         (allocate_location_exception): Update.
6135         * breakpoint.h (struct bp_location_ops): Remove.
6136         (class bp_location) <bp_location>: Remove bp_location_ops
6137         parameter.
6138         <~bp_location>: Add destructor.
6139         <ops>: Remove.
6140
6141 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6142             Pedro Alves  <palves@redhat.com>
6143
6144         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6145         'PATH_MAX'.
6146
6147 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6148             Samuel Thibault  <samuel.thibault@gnu.org>
6149             Thomas Schwinge  <thomas@codesourcery.com>
6150
6151         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6152         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6153
6154 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6155
6156         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6157         (check_empty): Use "const char *".
6158
6159         * gnu-nat.c (gnu_nat_target::detach): Instead of
6160         'detach_inferior (pid)' call
6161         'detach_inferior (find_inferior_pid (pid))'.
6162
6163         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6164         'nat/fork-inferior.o'.
6165         * gnu-nat.c: #include "nat/fork-inferior.h".
6166
6167         * gnu-nat.c (gnu_nat_target::detach): Instead of
6168         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6169         * gnu-nat.h: #include "inf-child.h".
6170         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6171         'i386_gnu_nat_target::fetch_registers'.
6172         (gnu_store_registers): Rename/move to
6173         'i386_gnu_nat_target::store_registers'.
6174
6175         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6176         * gnu-nat.h (mach_thread_info): New function.
6177         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6178
6179         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6180
6181 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6182
6183         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6184
6185 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6186
6187         * windows-nat.c (windows_add_thread): Add new parameter
6188         "main_thread_p" with default value set to false.  Update
6189         function documentation as well as all callers.
6190         (windows_delete_thread): Likewise.
6191         (fake_create_process): Update call to windows_add_thread.
6192         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6193         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6194         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6195         call to windows_delete_thread.
6196
6197 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6198
6199         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6200
6201 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6202
6203         * symfile.c (find_separate_debug_file): Use canonical path of
6204         sysroot with child_path instead of gdb_sysroot if it is valid.
6205
6206 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6207
6208         * symfile.c (find_separate_debug_file): Use child_path to
6209         determine if an object file is under a sysroot.
6210
6211 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6212
6213         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6214         unittests/child-path-selftests.c.
6215         * common/pathstuff.c (child_path): New function.
6216         * common/pathstuff.h (child_path): New prototype.
6217         * unittests/child-path-selftests.c: New file.
6218
6219 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6220
6221         * symfile.c (find_separate_debug_file): Look for separate debug
6222         files in debug directories under the sysroot.
6223
6224 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6225
6226         * symtab.h (struct minimal_symbol data_p): New const method.
6227         (struct minimal_symbol text_p): Likewise.
6228         * symtab.c (output_source_filename): Use file name style
6229         to print file name.
6230         (print_symbol_info): Likewise.
6231         (print_msymbol_info): Use address style to print addresses.
6232         Use function name style to print executable text symbols.
6233         (expand_symtab_containing_pc): Use data_p.
6234         (find_pc_sect_compunit_symtab): Likewise.
6235
6236 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6237
6238         * breakpoint.c (describe_other_breakpoints): Use address style
6239         to print addresses.
6240         (say_where): Likewise.
6241
6242 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6243
6244         * ada-typeprint.c (print_func_type): Print function name
6245         style to print function name.
6246         * c-typeprint.c (c_print_type_1): Likewise.
6247
6248 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6249
6250         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6251         for execve.
6252
6253 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6254
6255         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6256         type_stack.
6257
6258 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6259
6260         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6261         TYPE_CODE_REF types.
6262
6263 2019-02-08  Jim Wilson  <jimw@sifive.com>
6264
6265         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6266         (riscv_linux_fregset): New.
6267         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6268
6269 2019-02-07  Tom Tromey  <tom@tromey.com>
6270
6271         * thread.c (thread_cancel_execution_command): Update.
6272         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6273         methods.
6274         (struct thread_fsm_ops): Remove.
6275         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6276         (thread_fsm_should_stop, thread_fsm_return_value)
6277         (thread_fsm_set_finished, thread_fsm_finished_p)
6278         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6279         Don't declare.
6280         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6281         * infrun.c (clear_proceed_status_thread)
6282         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6283         (print_stop_event): Update.
6284         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6285         Add constructor.
6286         (step_command_fsm_ops): Remove.
6287         (new_step_command_fsm): Remove.
6288         (step_1): Update.
6289         (step_command_fsm::should_stop): Rename from
6290         step_command_fsm_should_stop.
6291         (step_command_fsm::clean_up): Rename from
6292         step_command_fsm_clean_up.
6293         (step_command_fsm::do_async_reply_reason): Rename from
6294         step_command_fsm_async_reply_reason.
6295         (struct until_next_fsm): Inherit from thread_fsm.  Add
6296         constructor.
6297         (until_next_fsm_ops): Remove.
6298         (new_until_next_fsm): Remove.
6299         (until_next_fsm::should_stop): Rename from
6300         until_next_fsm_should_stop.
6301         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6302         (until_next_fsm::do_async_reply_reason): Rename from
6303         until_next_fsm_async_reply_reason.
6304         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6305         constructor.  Change type of breakpoint.
6306         (finish_command_fsm_ops): Remove.
6307         (new_finish_command_fsm): Remove.
6308         (finish_command_fsm::should_stop): Rename from
6309         finish_command_fsm_should_stop.
6310         (finish_command_fsm::clean_up): Rename from
6311         finish_command_fsm_clean_up.
6312         (finish_command_fsm::return_value): Rename from
6313         finish_command_fsm_return_value.
6314         (finish_command_fsm::do_async_reply_reason): Rename from
6315         finish_command_fsm_async_reply_reason.
6316         (finish_command): Update.
6317         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6318         Add constructor.
6319         (call_thread_fsm_ops): Remove.
6320         (call_thread_fsm::call_thread_fsm): Rename from
6321         new_call_thread_fsm.
6322         (call_thread_fsm::should_stop): Rename from
6323         call_thread_fsm_should_stop.
6324         (call_thread_fsm::should_notify_stop): Rename from
6325         call_thread_fsm_should_notify_stop.
6326         (run_inferior_call, call_function_by_hand_dummy): Update.
6327         * cli/cli-interp.c (should_print_stop_to_console): Update.
6328         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6329         Add constructor.  Change type of location_breakpoint,
6330         caller_breakpoint.
6331         (until_break_fsm_ops): Remove.
6332         (new_until_break_fsm): Remove.
6333         (until_break_fsm::should_stop): Rename from
6334         until_break_fsm_should_stop.
6335         (until_break_fsm::clean_up): Rename from
6336         until_break_fsm_clean_up.
6337         (until_break_fsm::do_async_reply_reason): Rename from
6338         until_break_fsm_async_reply_reason.
6339         (until_break_command): Update.
6340         * thread-fsm.c: Remove.
6341         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6342
6343 2019-02-07  Tom Tromey  <tom@tromey.com>
6344
6345         * yy-remap.h: Add include guard.
6346         * xtensa-tdep.h: Add include guard.
6347         * xcoffread.h: Rename include guard.
6348         * varobj-iter.h: Add include guard.
6349         * tui/tui.h: Rename include guard.
6350         * tui/tui-winsource.h: Rename include guard.
6351         * tui/tui-wingeneral.h: Rename include guard.
6352         * tui/tui-windata.h: Rename include guard.
6353         * tui/tui-win.h: Rename include guard.
6354         * tui/tui-stack.h: Rename include guard.
6355         * tui/tui-source.h: Rename include guard.
6356         * tui/tui-regs.h: Rename include guard.
6357         * tui/tui-out.h: Rename include guard.
6358         * tui/tui-layout.h: Rename include guard.
6359         * tui/tui-io.h: Rename include guard.
6360         * tui/tui-hooks.h: Rename include guard.
6361         * tui/tui-file.h: Rename include guard.
6362         * tui/tui-disasm.h: Rename include guard.
6363         * tui/tui-data.h: Rename include guard.
6364         * tui/tui-command.h: Rename include guard.
6365         * tic6x-tdep.h: Add include guard.
6366         * target/waitstatus.h: Rename include guard.
6367         * target/wait.h: Rename include guard.
6368         * target/target.h: Rename include guard.
6369         * target/resume.h: Rename include guard.
6370         * target-float.h: Rename include guard.
6371         * stabsread.h: Add include guard.
6372         * rs6000-tdep.h: Add include guard.
6373         * riscv-fbsd-tdep.h: Add include guard.
6374         * regformats/regdef.h: Rename include guard.
6375         * record.h: Rename include guard.
6376         * python/python.h: Rename include guard.
6377         * python/python-internal.h: Rename include guard.
6378         * python/py-stopevent.h: Rename include guard.
6379         * python/py-ref.h: Rename include guard.
6380         * python/py-record.h: Rename include guard.
6381         * python/py-record-full.h: Rename include guard.
6382         * python/py-record-btrace.h: Rename include guard.
6383         * python/py-instruction.h: Rename include guard.
6384         * python/py-events.h: Rename include guard.
6385         * python/py-event.h: Rename include guard.
6386         * procfs.h: Add include guard.
6387         * proc-utils.h: Add include guard.
6388         * p-lang.h: Add include guard.
6389         * or1k-tdep.h: Rename include guard.
6390         * observable.h: Rename include guard.
6391         * nto-tdep.h: Rename include guard.
6392         * nat/x86-linux.h: Rename include guard.
6393         * nat/x86-linux-dregs.h: Rename include guard.
6394         * nat/x86-gcc-cpuid.h: Add include guard.
6395         * nat/x86-dregs.h: Rename include guard.
6396         * nat/x86-cpuid.h: Rename include guard.
6397         * nat/ppc-linux.h: Rename include guard.
6398         * nat/mips-linux-watch.h: Rename include guard.
6399         * nat/linux-waitpid.h: Rename include guard.
6400         * nat/linux-ptrace.h: Rename include guard.
6401         * nat/linux-procfs.h: Rename include guard.
6402         * nat/linux-osdata.h: Rename include guard.
6403         * nat/linux-nat.h: Rename include guard.
6404         * nat/linux-namespaces.h: Rename include guard.
6405         * nat/linux-btrace.h: Rename include guard.
6406         * nat/glibc_thread_db.h: Rename include guard.
6407         * nat/gdb_thread_db.h: Rename include guard.
6408         * nat/gdb_ptrace.h: Rename include guard.
6409         * nat/fork-inferior.h: Rename include guard.
6410         * nat/amd64-linux-siginfo.h: Rename include guard.
6411         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6412         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6413         * nat/aarch64-linux.h: Rename include guard.
6414         * nat/aarch64-linux-hw-point.h: Rename include guard.
6415         * mn10300-tdep.h: Add include guard.
6416         * mips-linux-tdep.h: Add include guard.
6417         * mi/mi-parse.h: Rename include guard.
6418         * mi/mi-out.h: Rename include guard.
6419         * mi/mi-main.h: Rename include guard.
6420         * mi/mi-interp.h: Rename include guard.
6421         * mi/mi-getopt.h: Rename include guard.
6422         * mi/mi-console.h: Rename include guard.
6423         * mi/mi-common.h: Rename include guard.
6424         * mi/mi-cmds.h: Rename include guard.
6425         * mi/mi-cmd-break.h: Rename include guard.
6426         * m2-lang.h: Add include guard.
6427         * location.h: Rename include guard.
6428         * linux-record.h: Rename include guard.
6429         * linux-nat.h: Add include guard.
6430         * linux-fork.h: Add include guard.
6431         * i386-darwin-tdep.h: Rename include guard.
6432         * hppa-linux-offsets.h: Add include guard.
6433         * guile/guile.h: Rename include guard.
6434         * guile/guile-internal.h: Rename include guard.
6435         * gnu-nat.h: Rename include guard.
6436         * gdb-stabs.h: Rename include guard.
6437         * frv-tdep.h: Add include guard.
6438         * f-lang.h: Add include guard.
6439         * event-loop.h: Add include guard.
6440         * darwin-nat.h: Rename include guard.
6441         * cp-abi.h: Rename include guard.
6442         * config/sparc/nm-sol2.h: Rename include guard.
6443         * config/nm-nto.h: Rename include guard.
6444         * config/nm-linux.h: Add include guard.
6445         * config/i386/nm-i386gnu.h: Rename include guard.
6446         * config/djgpp/nl_types.h: Rename include guard.
6447         * config/djgpp/langinfo.h: Rename include guard.
6448         * compile/gcc-cp-plugin.h: Add include guard.
6449         * compile/gcc-c-plugin.h: Add include guard.
6450         * compile/compile.h: Rename include guard.
6451         * compile/compile-object-run.h: Rename include guard.
6452         * compile/compile-object-load.h: Rename include guard.
6453         * compile/compile-internal.h: Rename include guard.
6454         * compile/compile-cplus.h: Rename include guard.
6455         * compile/compile-c.h: Rename include guard.
6456         * common/xml-utils.h: Rename include guard.
6457         * common/x86-xstate.h: Rename include guard.
6458         * common/version.h: Rename include guard.
6459         * common/vec.h: Rename include guard.
6460         * common/tdesc.h: Rename include guard.
6461         * common/selftest.h: Rename include guard.
6462         * common/scoped_restore.h: Rename include guard.
6463         * common/scoped_mmap.h: Rename include guard.
6464         * common/scoped_fd.h: Rename include guard.
6465         * common/safe-iterator.h: Rename include guard.
6466         * common/run-time-clock.h: Rename include guard.
6467         * common/refcounted-object.h: Rename include guard.
6468         * common/queue.h: Rename include guard.
6469         * common/ptid.h: Rename include guard.
6470         * common/print-utils.h: Rename include guard.
6471         * common/preprocessor.h: Rename include guard.
6472         * common/pathstuff.h: Rename include guard.
6473         * common/observable.h: Rename include guard.
6474         * common/netstuff.h: Rename include guard.
6475         * common/job-control.h: Rename include guard.
6476         * common/host-defs.h: Rename include guard.
6477         * common/gdb_wait.h: Rename include guard.
6478         * common/gdb_vecs.h: Rename include guard.
6479         * common/gdb_unlinker.h: Rename include guard.
6480         * common/gdb_unique_ptr.h: Rename include guard.
6481         * common/gdb_tilde_expand.h: Rename include guard.
6482         * common/gdb_sys_time.h: Rename include guard.
6483         * common/gdb_string_view.h: Rename include guard.
6484         * common/gdb_splay_tree.h: Rename include guard.
6485         * common/gdb_setjmp.h: Rename include guard.
6486         * common/gdb_ref_ptr.h: Rename include guard.
6487         * common/gdb_optional.h: Rename include guard.
6488         * common/gdb_locale.h: Rename include guard.
6489         * common/gdb_assert.h: Rename include guard.
6490         * common/filtered-iterator.h: Rename include guard.
6491         * common/filestuff.h: Rename include guard.
6492         * common/fileio.h: Rename include guard.
6493         * common/environ.h: Rename include guard.
6494         * common/common-utils.h: Rename include guard.
6495         * common/common-types.h: Rename include guard.
6496         * common/common-regcache.h: Rename include guard.
6497         * common/common-inferior.h: Rename include guard.
6498         * common/common-gdbthread.h: Rename include guard.
6499         * common/common-exceptions.h: Rename include guard.
6500         * common/common-defs.h: Rename include guard.
6501         * common/common-debug.h: Rename include guard.
6502         * common/cleanups.h: Rename include guard.
6503         * common/buffer.h: Rename include guard.
6504         * common/btrace-common.h: Rename include guard.
6505         * common/break-common.h: Rename include guard.
6506         * cli/cli-utils.h: Rename include guard.
6507         * cli/cli-style.h: Rename include guard.
6508         * cli/cli-setshow.h: Rename include guard.
6509         * cli/cli-script.h: Rename include guard.
6510         * cli/cli-interp.h: Rename include guard.
6511         * cli/cli-decode.h: Rename include guard.
6512         * cli/cli-cmds.h: Rename include guard.
6513         * charset-list.h: Add include guard.
6514         * buildsym-legacy.h: Rename include guard.
6515         * bfin-tdep.h: Add include guard.
6516         * ax.h: Rename include guard.
6517         * arm-linux-tdep.h: Add include guard.
6518         * arm-fbsd-tdep.h: Add include guard.
6519         * arch/xtensa.h: Rename include guard.
6520         * arch/tic6x.h: Add include guard.
6521         * arch/i386.h: Add include guard.
6522         * arch/arm.h: Rename include guard.
6523         * arch/arm-linux.h: Rename include guard.
6524         * arch/arm-get-next-pcs.h: Rename include guard.
6525         * arch/amd64.h: Add include guard.
6526         * arch/aarch64-insn.h: Rename include guard.
6527         * arch-utils.h: Rename include guard.
6528         * annotate.h: Add include guard.
6529         * amd64-darwin-tdep.h: Rename include guard.
6530         * aarch64-linux-tdep.h: Add include guard.
6531         * aarch64-fbsd-tdep.h: Add include guard.
6532         * aarch32-linux-nat.h: Add include guard.
6533
6534 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6535
6536         * macrotab.c (macro_define_internal): New function that
6537         factorizes macro_define_object_internal and macro_define_function
6538         code.
6539         (macro_define_object_internal): Use macro_define_internal.
6540         (macro_define_function): Likewise.
6541
6542 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6543
6544         * macrocmd.c (extract_identifier): Return
6545         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6546         callers.
6547
6548 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6549
6550         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6551
6552 2019-02-05  Tom Tromey  <tom@tromey.com>
6553
6554         * target.c (target_stack::unpush): Move assertion earlier.
6555
6556 2019-01-30  Tom Tromey  <tom@tromey.com>
6557
6558         PR python/23615:
6559         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6560         (gdbpy_parse_and_eval): Likewise.
6561         * python/python-internal.h (gdbpy_allow_threads): New class.
6562
6563 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6564
6565         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6566         (aarch64_fbsd_fpregmap): Move earlier.
6567         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6568         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6569         instead of individual calls to trad_frame_set_reg_addr.
6570         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6571         earlier.
6572         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6573         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6574         instead of individual calls to trad_frame_set_reg_addr.
6575
6576 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6577
6578         * CONTRIBUTE: Replace contribution list with wiki link.
6579
6580 2019-01-25  Tom Tromey  <tom@tromey.com>
6581
6582         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6583
6584 2019-01-25  Tom Tromey  <tom@tromey.com>
6585
6586         * xtensa-linux-nat.c: Fix common/ includes.
6587         * xml-support.h: Fix common/ includes.
6588         * xml-support.c: Fix common/ includes.
6589         * x86-linux-nat.c: Fix common/ includes.
6590         * windows-nat.c: Fix common/ includes.
6591         * varobj.h: Fix common/ includes.
6592         * varobj.c: Fix common/ includes.
6593         * value.c: Fix common/ includes.
6594         * valops.c: Fix common/ includes.
6595         * utils.c: Fix common/ includes.
6596         * unittests/xml-utils-selftests.c: Fix common/ includes.
6597         * unittests/utils-selftests.c: Fix common/ includes.
6598         * unittests/unpack-selftests.c: Fix common/ includes.
6599         * unittests/tracepoint-selftests.c: Fix common/ includes.
6600         * unittests/style-selftests.c: Fix common/ includes.
6601         * unittests/string_view-selftests.c: Fix common/ includes.
6602         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6603         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6604         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6605         * unittests/rsp-low-selftests.c: Fix common/ includes.
6606         * unittests/parse-connection-spec-selftests.c: Fix common/
6607         includes.
6608         * unittests/optional-selftests.c: Fix common/ includes.
6609         * unittests/offset-type-selftests.c: Fix common/ includes.
6610         * unittests/observable-selftests.c: Fix common/ includes.
6611         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6612         * unittests/memrange-selftests.c: Fix common/ includes.
6613         * unittests/memory-map-selftests.c: Fix common/ includes.
6614         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6615         * unittests/function-view-selftests.c: Fix common/ includes.
6616         * unittests/environ-selftests.c: Fix common/ includes.
6617         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6618         * unittests/common-utils-selftests.c: Fix common/ includes.
6619         * unittests/cli-utils-selftests.c: Fix common/ includes.
6620         * unittests/array-view-selftests.c: Fix common/ includes.
6621         * ui-file.c: Fix common/ includes.
6622         * tui/tui-io.c: Fix common/ includes.
6623         * tracepoint.h: Fix common/ includes.
6624         * tracepoint.c: Fix common/ includes.
6625         * tracefile-tfile.c: Fix common/ includes.
6626         * top.h: Fix common/ includes.
6627         * top.c: Fix common/ includes.
6628         * thread.c: Fix common/ includes.
6629         * target/waitstatus.h: Fix common/ includes.
6630         * target/waitstatus.c: Fix common/ includes.
6631         * target.h: Fix common/ includes.
6632         * target.c: Fix common/ includes.
6633         * target-memory.c: Fix common/ includes.
6634         * target-descriptions.c: Fix common/ includes.
6635         * symtab.h: Fix common/ includes.
6636         * symfile.c: Fix common/ includes.
6637         * stap-probe.c: Fix common/ includes.
6638         * spu-linux-nat.c: Fix common/ includes.
6639         * sparc-nat.c: Fix common/ includes.
6640         * source.c: Fix common/ includes.
6641         * solib.c: Fix common/ includes.
6642         * solib-target.c: Fix common/ includes.
6643         * ser-unix.c: Fix common/ includes.
6644         * ser-tcp.c: Fix common/ includes.
6645         * ser-pipe.c: Fix common/ includes.
6646         * ser-base.c: Fix common/ includes.
6647         * selftest-arch.c: Fix common/ includes.
6648         * s12z-tdep.c: Fix common/ includes.
6649         * rust-exp.y: Fix common/ includes.
6650         * rs6000-aix-tdep.c: Fix common/ includes.
6651         * riscv-tdep.c: Fix common/ includes.
6652         * remote.c: Fix common/ includes.
6653         * remote-notif.h: Fix common/ includes.
6654         * remote-fileio.h: Fix common/ includes.
6655         * remote-fileio.c: Fix common/ includes.
6656         * regcache.h: Fix common/ includes.
6657         * regcache.c: Fix common/ includes.
6658         * record-btrace.c: Fix common/ includes.
6659         * python/python.c: Fix common/ includes.
6660         * python/py-type.c: Fix common/ includes.
6661         * python/py-inferior.c: Fix common/ includes.
6662         * progspace.h: Fix common/ includes.
6663         * producer.c: Fix common/ includes.
6664         * procfs.c: Fix common/ includes.
6665         * proc-api.c: Fix common/ includes.
6666         * printcmd.c: Fix common/ includes.
6667         * ppc-linux-nat.c: Fix common/ includes.
6668         * parser-defs.h: Fix common/ includes.
6669         * osdata.c: Fix common/ includes.
6670         * obsd-nat.c: Fix common/ includes.
6671         * nat/x86-linux.c: Fix common/ includes.
6672         * nat/x86-linux-dregs.c: Fix common/ includes.
6673         * nat/x86-dregs.h: Fix common/ includes.
6674         * nat/x86-dregs.c: Fix common/ includes.
6675         * nat/ppc-linux.c: Fix common/ includes.
6676         * nat/mips-linux-watch.h: Fix common/ includes.
6677         * nat/mips-linux-watch.c: Fix common/ includes.
6678         * nat/linux-waitpid.c: Fix common/ includes.
6679         * nat/linux-ptrace.h: Fix common/ includes.
6680         * nat/linux-ptrace.c: Fix common/ includes.
6681         * nat/linux-procfs.c: Fix common/ includes.
6682         * nat/linux-personality.c: Fix common/ includes.
6683         * nat/linux-osdata.c: Fix common/ includes.
6684         * nat/linux-namespaces.c: Fix common/ includes.
6685         * nat/linux-btrace.h: Fix common/ includes.
6686         * nat/linux-btrace.c: Fix common/ includes.
6687         * nat/fork-inferior.c: Fix common/ includes.
6688         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6689         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6690         * nat/aarch64-linux.c: Fix common/ includes.
6691         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6692         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6693         * namespace.h: Fix common/ includes.
6694         * mips-linux-tdep.c: Fix common/ includes.
6695         * minsyms.c: Fix common/ includes.
6696         * mi/mi-parse.h: Fix common/ includes.
6697         * mi/mi-main.c: Fix common/ includes.
6698         * mi/mi-cmd-env.c: Fix common/ includes.
6699         * memrange.h: Fix common/ includes.
6700         * memattr.c: Fix common/ includes.
6701         * maint.h: Fix common/ includes.
6702         * maint.c: Fix common/ includes.
6703         * main.c: Fix common/ includes.
6704         * machoread.c: Fix common/ includes.
6705         * location.c: Fix common/ includes.
6706         * linux-thread-db.c: Fix common/ includes.
6707         * linux-nat.c: Fix common/ includes.
6708         * linux-fork.c: Fix common/ includes.
6709         * inline-frame.c: Fix common/ includes.
6710         * infrun.c: Fix common/ includes.
6711         * inflow.c: Fix common/ includes.
6712         * inferior.h: Fix common/ includes.
6713         * inferior.c: Fix common/ includes.
6714         * infcmd.c: Fix common/ includes.
6715         * inf-ptrace.c: Fix common/ includes.
6716         * inf-child.c: Fix common/ includes.
6717         * ia64-linux-nat.c: Fix common/ includes.
6718         * i387-tdep.c: Fix common/ includes.
6719         * i386-tdep.c: Fix common/ includes.
6720         * i386-linux-tdep.c: Fix common/ includes.
6721         * i386-linux-nat.c: Fix common/ includes.
6722         * i386-go32-tdep.c: Fix common/ includes.
6723         * i386-fbsd-tdep.c: Fix common/ includes.
6724         * i386-fbsd-nat.c: Fix common/ includes.
6725         * guile/scm-type.c: Fix common/ includes.
6726         * guile/guile.c: Fix common/ includes.
6727         * go32-nat.c: Fix common/ includes.
6728         * gnu-nat.c: Fix common/ includes.
6729         * gdbthread.h: Fix common/ includes.
6730         * gdbarch-selftests.c: Fix common/ includes.
6731         * gdb_usleep.c: Fix common/ includes.
6732         * gdb_select.h: Fix common/ includes.
6733         * gdb_bfd.c: Fix common/ includes.
6734         * gcore.c: Fix common/ includes.
6735         * fork-child.c: Fix common/ includes.
6736         * findvar.c: Fix common/ includes.
6737         * fbsd-nat.c: Fix common/ includes.
6738         * event-top.c: Fix common/ includes.
6739         * event-loop.c: Fix common/ includes.
6740         * dwarf2read.c: Fix common/ includes.
6741         * dwarf2loc.c: Fix common/ includes.
6742         * dwarf2-frame.c: Fix common/ includes.
6743         * dwarf-index-cache.c: Fix common/ includes.
6744         * dtrace-probe.c: Fix common/ includes.
6745         * disasm-selftests.c: Fix common/ includes.
6746         * defs.h: Fix common/ includes.
6747         * csky-tdep.c: Fix common/ includes.
6748         * cp-valprint.c: Fix common/ includes.
6749         * cp-support.h: Fix common/ includes.
6750         * cp-support.c: Fix common/ includes.
6751         * corelow.c: Fix common/ includes.
6752         * completer.h: Fix common/ includes.
6753         * completer.c: Fix common/ includes.
6754         * compile/compile.c: Fix common/ includes.
6755         * compile/compile-loc2c.c: Fix common/ includes.
6756         * compile/compile-cplus-types.c: Fix common/ includes.
6757         * compile/compile-cplus-symbols.c: Fix common/ includes.
6758         * command.h: Fix common/ includes.
6759         * cli/cli-dump.c: Fix common/ includes.
6760         * cli/cli-cmds.c: Fix common/ includes.
6761         * charset.c: Fix common/ includes.
6762         * build-id.c: Fix common/ includes.
6763         * btrace.h: Fix common/ includes.
6764         * btrace.c: Fix common/ includes.
6765         * breakpoint.h: Fix common/ includes.
6766         * breakpoint.c: Fix common/ includes.
6767         * ax.h:
6768         (enum agent_op): Fix common/ includes.
6769         * ax-general.c (struct aop_map): Fix common/ includes.
6770         * ax-gdb.c: Fix common/ includes.
6771         * auxv.c: Fix common/ includes.
6772         * auto-load.c: Fix common/ includes.
6773         * arm-tdep.c: Fix common/ includes.
6774         * arch/riscv.c: Fix common/ includes.
6775         * arch/ppc-linux-common.c: Fix common/ includes.
6776         * arch/i386.c: Fix common/ includes.
6777         * arch/arm.c: Fix common/ includes.
6778         * arch/arm-linux.c: Fix common/ includes.
6779         * arch/arm-get-next-pcs.c: Fix common/ includes.
6780         * arch/amd64.c: Fix common/ includes.
6781         * arch/aarch64.c: Fix common/ includes.
6782         * arch/aarch64-insn.c: Fix common/ includes.
6783         * arch-utils.c: Fix common/ includes.
6784         * amd64-windows-tdep.c: Fix common/ includes.
6785         * amd64-tdep.c: Fix common/ includes.
6786         * amd64-sol2-tdep.c: Fix common/ includes.
6787         * amd64-obsd-tdep.c: Fix common/ includes.
6788         * amd64-nbsd-tdep.c: Fix common/ includes.
6789         * amd64-linux-tdep.c: Fix common/ includes.
6790         * amd64-linux-nat.c: Fix common/ includes.
6791         * amd64-fbsd-tdep.c: Fix common/ includes.
6792         * amd64-fbsd-nat.c: Fix common/ includes.
6793         * amd64-dicos-tdep.c: Fix common/ includes.
6794         * amd64-darwin-tdep.c: Fix common/ includes.
6795         * agent.c: Fix common/ includes.
6796         * ada-lang.h: Fix common/ includes.
6797         * ada-lang.c: Fix common/ includes.
6798         * aarch64-tdep.c: Fix common/ includes.
6799
6800 2019-01-25  Tom Tromey  <tom@tromey.com>
6801
6802         * common/create-version.sh: Use common/version.h.
6803
6804 2019-01-24  Pedro Alves  <palves@redhat.com>
6805
6806         * infrun.c (signal_stop, signal_print, signal_program)
6807         (signal_catch, signal_pass): Now arrays instead of pointers.
6808         (update_signals_program_target, do_target_resume)
6809         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6810         * linux-nat.c (linux_nat_target::pass_signals)
6811         (linux_nat_target::create_inferior, linux_nat_target::attach):
6812         Adjust.
6813         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6814         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6815         * procfs.c (procfs_target::pass_signals): Adjust.
6816         * record-full.c (record_full_target::resume): Adjust.
6817         * remote.c (remote_target::pass_signals)
6818         (remote_target::program_signals): Adjust.
6819         * target-debug.h (target_debug_print_signals): Now takes a
6820         gdb::array_view as parameter.  Adjust.
6821         * target.h (target_ops) <pass_signals, program_signals>: Replace
6822         pointer and length parameters with gdb::array_view.
6823         (target_pass_signals, target_program_signals): Likewise.
6824         * target-delegates.c: Regenerate.
6825
6826 2019-01-24  Pedro Alves  <palves@redhat.com>
6827
6828         * common/forward-scope-exit.h
6829         (forward_scope_exit::forward_scope_exit): Pass arguments to
6830         m_bind_function directly, instead of creating a std::bind and
6831         copying that.
6832
6833 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6834
6835         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6836         for static members.
6837         (pass_in_v_vfp_candidate): Likewise.
6838
6839 2019-01-23  Tom Tromey  <tom@tromey.com>
6840             Pedro Alves  <palves@redhat.com>
6841
6842         * regcache.c (class regcache_invalidator): Remove.
6843         (regcache::raw_write): Use make_scope_exit.
6844
6845 2019-01-23  Tom Tromey  <tom@tromey.com>
6846
6847         * ui-out.h (class ui_out_emit_type): Update comment.
6848
6849 2019-01-23  Tom Tromey  <tom@tromey.com>
6850
6851         * infrun.c (fetch_inferior_event): Update comment.
6852
6853 2019-01-23  Tom Tromey  <tom@tromey.com>
6854             Pedro Alves  <palves@redhat.com>
6855
6856         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6857         parameter.
6858         (fetch_inferior_event): Use SCOPE_EXIT.
6859
6860
6861 2019-01-23  Tom Tromey  <tom@tromey.com>
6862             Pedro Alves  <palves@redhat.com>
6863
6864         * infrun.c (disable_thread_events): Delete.
6865         (stop_all_threads): Use SCOPE_EXIT.
6866
6867 2019-01-23  Tom Tromey  <tom@tromey.com>
6868             Pedro Alves  <palves@redhat.com>
6869
6870         * symfile.c: Include forward-scope-exit.h.
6871         (clear_symtab_users_cleanup): Replace forward declaration with
6872         a FORWARD_SCOPE_EXIT.
6873         (syms_from_objfile_1): Use the forward_scope_exit and
6874         gdb::optional instead of cleanup_function.
6875         (reread_symbols): Use the forward_scope_exit instead of
6876         cleanup_function.
6877         (clear_symtab_users_cleanup): Remove function.
6878
6879 2019-01-23  Tom Tromey  <tom@tromey.com>
6880             Pedro Alves  <palves@redhat.com>
6881
6882         * linux-nat.c: Include scope-exit.h.
6883         (cleanup_target_stop): Remove.
6884         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6885         SCOPE_EXIT.
6886
6887 2019-01-23  Tom Tromey  <tom@tromey.com>
6888             Pedro Alves  <palves@redhat.com>
6889
6890         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6891         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6892
6893 2019-01-23  Tom Tromey  <tom@tromey.com>
6894             Andrew Burgess  <andrew.burgess@embecosm.com>
6895             Pedro Alves  <palves@redhat.com>
6896
6897         * infrun.c (fetch_inferior_event): Use scope_exit.
6898         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6899         * top.c (execute_command): Use scope_exit.
6900         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6901         * utils.c (do_bpstat_clear_actions_cleanup)
6902         (make_bpstat_clear_actions_cleanup): Remove.
6903
6904 2019-01-23  Tom Tromey  <tom@tromey.com>
6905             Pedro Alves  <palves@redhat.com>
6906
6907         * infrun.c: Include "common/scope-exit.h"
6908         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6909         (wait_for_inferior): Use SCOPE_EXIT.
6910         (fetch_inferior_event): Use scope_exit.
6911
6912 2019-01-23  Tom Tromey  <tom@tromey.com>
6913             Pedro Alves  <palves@redhat.com>
6914
6915         * breakpoint.c (create_breakpoint): Remove cleanup.
6916
6917 2019-01-23  Tom Tromey  <tom@tromey.com>
6918             Andrew Burgess  <andrew.burgess@embecosm.com>
6919             Pedro Alves  <palves@redhat.com>
6920
6921 2019-01-23  Pedro Alves  <palves@redhat.com>
6922
6923         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6924
6925 2019-01-23  Pedro Alves  <palves@redhat.com>
6926             Andrew Burgess  <andrew.burgess@embecosm.com>
6927
6928         * gdbthread.h: Include "common/forward-scope-exit.h".
6929         (scoped_finish_thread_state): Redefine custom class in terms of
6930         forward_scope_exit.
6931
6932 2019-01-23  Pedro Alves  <palves@redhat.com>
6933             Andrew Burgess  <andrew.burgess@embecosm.com>
6934
6935         * common/forward-scope-exit.h: New file.
6936
6937 2019-01-23  Pedro Alves  <palves@redhat.com>
6938             Andrew Burgess  <andrew.burgess@embecosm.com>
6939             Tom Tromey  <tom@tromey.com>
6940
6941         * common/scope-exit.h: New file.
6942
6943 2019-01-23  Pedro Alves  <palves@redhat.com>
6944
6945         * common/preprocessor.h (ESC): Rename to ...
6946         (ESC_PARENS): ... this.
6947         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6948         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6949
6950 2019-01-23  Tom Tromey  <tom@tromey.com>
6951
6952         * language.h (class scoped_switch_to_sym_language_if_auto):
6953         Initialize m_lang in both cases.
6954
6955 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6956
6957         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6958         with XCNEW.
6959
6960 2019-01-22  Tom Tromey  <tom@tromey.com>
6961
6962         * corelow.c: Do not include sys/file.h.
6963
6964 2019-01-22  Tom Tromey  <tom@tromey.com>
6965
6966         * tui/tui-wingeneral.h: Include gdb_curses.h.
6967
6968 2019-01-22  Tom Tromey  <tom@tromey.com>
6969
6970         * source-cache.h (class source_cache) <get_source_lines,
6971         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6972
6973 2019-01-22  Tom Tromey  <tom@tromey.com>
6974
6975         * remote-fileio.h (struct remote_target): Declare.
6976
6977 2019-01-22  Tom Tromey  <tom@tromey.com>
6978
6979         * python/py-arch.c: Do not include py-ref.h.
6980         * python/py-bpevent.c: Do not include py-ref.h.
6981         * python/py-cmd.c: Do not include py-ref.h.
6982         * python/py-continueevent.c: Do not include py-ref.h.
6983         * python/py-event.h: Do not include py-ref.h.
6984         * python/py-evtregistry.c: Do not include py-ref.h.
6985         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6986         * python/py-frame.c: Do not include py-ref.h.
6987         * python/py-framefilter.c: Do not include py-ref.h.
6988         * python/py-function.c: Do not include py-ref.h.
6989         * python/py-infevents.c: Do not include py-ref.h.
6990         * python/py-linetable.c: Do not include py-ref.h.
6991         * python/py-objfile.c: Do not include py-ref.h.
6992         * python/py-param.c: Do not include py-ref.h.
6993         * python/py-prettyprint.c: Do not include py-ref.h.
6994         * python/py-progspace.c: Do not include py-ref.h.
6995         * python/py-symbol.c: Do not include py-ref.h.
6996         * python/py-symtab.c: Do not include py-ref.h.
6997         * python/py-type.c: Do not include py-ref.h.
6998         * python/py-unwind.c: Do not include py-ref.h.
6999         * python/py-utils.c: Do not include py-ref.h.
7000         * python/py-value.c: Do not include py-ref.h.
7001         * python/py-varobj.c: Do not include py-ref.h.
7002         * python/py-xmethods.c: Do not include py-ref.h.
7003         * python/python.c: Do not include py-ref.h.
7004         * varobj.c: Do not include py-ref.h.
7005
7006 2019-01-22  Tom Tromey  <tom@tromey.com>
7007
7008         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7009         keyword for bcache.
7010
7011 2019-01-22  Tom Tromey  <tom@tromey.com>
7012
7013         * compile/compile-cplus-types.c: Remove a comment by #include.
7014
7015 2019-01-22  Tom Tromey  <tom@tromey.com>
7016
7017         * compile/gcc-c-plugin.h: Include compile-internal.h.
7018
7019 2019-01-22  Tom Tromey  <tom@tromey.com>
7020
7021         * stabsread.c (EXTERN): Do not define.
7022         (symnum, next_symbol_text_func, processing_gcc_compilation)
7023         (within_function, global_sym_chain, global_stabs)
7024         (previous_stab_code, this_object_header_files)
7025         (n_this_object_header_files)
7026         (n_allocated_this_object_header_files): Define.
7027         * stabsread.h (EXTERN): Never define.  Use "extern".
7028
7029 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7030
7031         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7032         history_value.
7033
7034 2019-01-21  Tom Tromey  <tom@tromey.com>
7035
7036         * ui-out.c: Fix includes.
7037         * tui/tui-source.c: Fix includes.
7038         * target.c: Fix includes.
7039         * remote.c: Fix includes.
7040         * regcache.c: Fix includes.
7041         * python/py-block.c: Fix includes.
7042         * printcmd.c: Fix includes.
7043         * or1k-tdep.c: Fix includes.
7044         * mi/mi-main.c: Fix includes.
7045         * m32r-tdep.c: Fix includes.
7046         * csky-tdep.c: Fix includes.
7047         * compile/compile-cplus-types.c: Fix includes.
7048         * cli/cli-interp.c: Fix includes.
7049
7050 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7051
7052         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7053         for padding.
7054
7055 2019-01-16  Tom Tromey  <tom@tromey.com>
7056
7057         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7058         earlier.
7059         (struct objfile) <msymbols_range>: Move from top level.
7060         <msymbols>: New method.
7061         (class objfile_msymbols): Remove.
7062         * symtab.c (default_collect_symbol_completion_matches_break_on):
7063         Update.
7064         * symmisc.c (dump_msymbols): Update.
7065         * stabsread.c (scan_file_globals): Update.
7066         * objc-lang.c (info_selectors_command, info_classes_command)
7067         (find_methods): Update.
7068         * minsyms.c (find_solib_trampoline_target): Update.
7069         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7070         * coffread.c (coff_symfile_read): Update.
7071         * ada-lang.c (ada_lookup_simple_minsym)
7072         (ada_collect_symbol_completion_matches): Update.
7073
7074 2019-01-16  Tom Tromey  <tom@tromey.com>
7075
7076         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7077         type.  Remove no-argument constructor.
7078         <iterator::operator++>: Simplify.
7079         <begin>: Update.
7080         <end>: Use minimal_symbol_count.
7081
7082 2019-01-16  Tom Tromey  <tom@tromey.com>
7083
7084         * objfiles.h (struct objfile) <psymtabs>: New method.
7085         (class objfile_psymtabs): Remove.
7086         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7087         typedef.
7088         <range>: New method.
7089         (require_partial_symbols): Change return type.
7090         * psymtab.c (require_partial_symbols)
7091         (psym_expand_symtabs_matching): Update.
7092         * mdebugread.c (parse_partial_symbols): Update.
7093         * dbxread.c (dbx_end_psymtab): Update.
7094
7095 2019-01-15  Tom Tromey  <tom@tromey.com>
7096
7097         * symtab.c (lookup_objfile_from_block)
7098         (lookup_symbol_in_objfile_symtabs)
7099         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7100         (find_line_symtab, info_sources_command)
7101         (default_collect_symbol_completion_matches_break_on)
7102         (make_source_files_completion_list): Update.
7103         * symmisc.c (print_objfile_statistics, dump_objfile)
7104         (maintenance_print_symbols, maintenance_info_symtabs)
7105         (maintenance_check_symtabs, maintenance_info_line_tables):
7106         Update.
7107         * source.c (select_source_symtab)
7108         (forget_cached_source_info_for_objfile): Update.
7109         * objfiles.h (class objfile_compunits): Remove.
7110         (struct objfile) <compunits_range>: New typedef.
7111         (compunits): New method.
7112         * objfiles.c (objfile_relocate1): Update.
7113         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7114         * maint.c (count_symtabs_and_blocks): Update.
7115         * linespec.c (iterate_over_all_matching_symtabs): Update.
7116         * cp-support.c (add_symbol_overload_list_qualified): Update.
7117         * coffread.c (coff_symtab_read): Update.
7118         * ada-lang.c (add_nonlocal_symbols)
7119         (ada_collect_symbol_completion_matches)
7120         (ada_add_global_exceptions): Update.
7121
7122 2019-01-15  Tom Tromey  <tom@tromey.com>
7123
7124         * progspace.h (program_space) <objfiles_safe_range>: New
7125         typedef.
7126         <objfiles_safe>: New method.
7127         * objfiles.h (class all_objfiles_safe): Remove.
7128         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7129         * jit.c (jit_inferior_exit_hook): Update.
7130
7131 2019-01-17  Tom Tromey  <tom@tromey.com>
7132
7133         * progspace.h (program_space) <objfiles_range>: New typedef.
7134         <objfiles>: New method.
7135         <objfiles_head>: Rename from objfiles.
7136         (object_files): Update.
7137         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7138         * guile/scm-pretty-print.c
7139         (ppscm_find_pretty_printer_from_objfiles): Update.
7140         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7141         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7142         Update.
7143         * python/py-progspace.c (pspy_get_objfiles): Update.
7144         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7145         Update.
7146         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7147         (objfpy_lookup_objfile_by_build_id): Update.
7148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7149         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7150         Update.
7151         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7152         (expand_symtab_containing_pc, lookup_objfile_from_block)
7153         (lookup_static_symbol, basic_lookup_transparent_type)
7154         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7155         (find_line_symtab, info_sources_command)
7156         (default_collect_symbol_completion_matches_break_on)
7157         (make_source_files_completion_list, find_main_name): Update.
7158         * symmisc.c (print_symbol_bcache_statistics)
7159         (print_objfile_statistics, maintenance_print_symbols)
7160         (maintenance_print_msymbols, maintenance_print_objfiles)
7161         (maintenance_info_symtabs, maintenance_check_symtabs)
7162         (maintenance_expand_symtabs, maintenance_info_line_tables):
7163         Update.
7164         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7165         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7166         (map_overlay_command, unmap_overlay_command)
7167         (simple_overlay_update, expand_symtabs_matching)
7168         (map_symbol_filenames): Update.
7169         * symfile-debug.c (set_debug_symfile): Update.
7170         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7171         Update.
7172         * source.c (select_source_symtab, forget_cached_source_info):
7173         Update.
7174         * solib.c (solib_read_symbols): Update.
7175         * solib-spu.c (append_ocl_sos): Update.
7176         * psymtab.c (maintenance_print_psymbols)
7177         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7178         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7179         * printcmd.c (info_symbol_command): Update.
7180         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7181         Update.
7182         * objfiles.h (class all_objfiles): Remove.
7183         * objfiles.c (have_partial_symbols, have_full_symbols)
7184         (have_minimal_symbols, qsort_cmp, update_section_map)
7185         (shared_objfile_contains_address_p)
7186         (default_iterate_over_objfiles_in_search_order): Update.
7187         * objc-lang.c (info_selectors_command, info_classes_command)
7188         (find_methods): Update.
7189         * minsyms.c (find_solib_trampoline_target): Update.
7190         * maint.c (maintenance_info_sections)
7191         (maintenance_translate_address, count_symtabs_and_blocks):
7192         Update.
7193         * main.c (captured_main_1): Update.
7194         * linux-thread-db.c (try_thread_db_load_from_pdir)
7195         (has_libpthread): Update.
7196         * linespec.c (iterate_over_all_matching_symtabs)
7197         (search_minsyms_for_name): Update.
7198         * jit.c (jit_find_objf_with_entry_addr): Update.
7199         * hppa-tdep.c (find_unwind_entry)
7200         (hppa_lookup_stub_minimal_symbol): Update.
7201         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7202         Update.
7203         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7204         (elf_gnu_ifunc_resolve_by_got): Update.
7205         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7206         * dwarf-index-write.c (save_gdb_index_command): Update.
7207         * cp-support.c (add_symbol_overload_list_qualified): Update.
7208         * breakpoint.c (create_overlay_event_breakpoint)
7209         (create_longjmp_master_breakpoint)
7210         (create_std_terminate_master_breakpoint)
7211         (create_exception_master_breakpoint): Update.
7212         * blockframe.c (find_pc_partial_function): Update.
7213         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7214         (ada_collect_symbol_completion_matches)
7215         (ada_add_global_exceptions): Update.
7216
7217 2019-01-17  Tom Tromey  <tom@tromey.com>
7218
7219         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7220         declare VEC.
7221         (solib_target_parse_libraries): Change return type.
7222         (library_list_start_segment, library_list_start_section)
7223         (library_list_end_library, library_list_start_library); Update.
7224         (solib_target_free_library_list): Remove.
7225         (solib_target_parse_libraries): Remove cleanup.  Change return
7226         type.
7227         (solib_target_current_sos): Update.
7228
7229 2019-01-17  Tom Tromey  <tromey@bapiya>
7230
7231         * valprint.c: Replace "the the" with "the".
7232         * symtab.c: Replace "the the" with "the".
7233         * solib.c: Replace "the the" with "the".
7234         * solib-dsbt.c: Replace "the the" with "the".
7235         * linespec.c: Replace "the the" with "the".
7236         * dwarf2loc.h: Replace "the the" with "the".
7237         * amd64-windows-tdep.c: Replace "the the" with "the".
7238         * aarch64-tdep.c: Replace "the the" with "the".
7239
7240 2019-01-16  Keith Seitz  <keiths@redhat.com>
7241
7242         PR gdb/23773
7243         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7244         <builder>: Rename to ..
7245         <m_builder>: ... this and make private.
7246         (dwarf2_cu::get_builder): New method.  Change all users of
7247         `builder' to use this method.
7248         (dwarf2_start_symtab): Move to ...
7249         (dwarf2_cu::start_symtab): ... here.  Update all callers
7250         (setup_type_unit_groups): Move to ...
7251         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7252         callers.
7253         (dwarf2_cu::reset_builder): New method.
7254         (process_full_compunit, process_full_type_unit): Use
7255         dwarf2_cu::reset_builder.
7256         (follow_die_offset): Record the ancestor CU if it is different
7257         from the followed DIE's CU.
7258         (follow_die_sig_1): Likewise.
7259
7260 2019-01-15  Tom Tromey  <tom@tromey.com>
7261
7262         * remote.c (class remote_state) <buf>: Now a char_vector.
7263         <buf_size>: Remove.
7264         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7265         parameter.
7266         (remote_target::getpkt_or_notif_sane_1)
7267         (remote_target::getpkt_sane)
7268         (remote_target::getpkt_or_notif_sane): Likewise.
7269         (class remote_target) <putpkt>: New overload.
7270         (remote_target::read_frame): Change type of "buf_p".  Remove
7271         sizeof_p parameter.
7272         (packet_ok): New overload.
7273         (packet_check_result): New overload.
7274         Update all uses.
7275
7276 2019-01-14  Tom Tromey  <tom@tromey.com>
7277
7278         * remote-notif.c (handle_notification, remote_notif_ack)
7279         (remote_notif_parse): Make "buf" const.
7280         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7281         const.
7282         (remote_notif_parse, remote_notif_ack, handle_notification):
7283         Likewise.
7284         * remote.c (remote_notif_stop_parse): Make "buf" const.
7285         (remote_target::remote_parse_stop_reply): Make "buf" const.
7286         (remote_notif_stop_ack): Make "buf" const.
7287
7288 2019-01-14  Tom Tromey  <tom@tromey.com>
7289
7290         * remote.c (remote_console_output): Make parameter const.
7291
7292 2019-01-14  Tom Tromey  <tom@tromey.com>
7293
7294         * target-debug.h (target_debug_print_signals): Constify.
7295         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7296         * procfs.c (procfs_target::pass_signals): Update.
7297         * linux-nat.c (linux_nat_target::pass_signals): Update.
7298         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7299         * target-delegates.c: Rebuild.
7300         * remote.c (remote_target::program_signals): Update.
7301         (remote_target::pass_signals): Update.
7302         * target.c (target_pass_signals): Constify argument.
7303         (target_program_signals): Likewise.
7304         * target.h (struct target_ops) <pass_signals, program_signals>:
7305         Constify argument.
7306         (target_pass_signals, target_program_signals): Constify argument.
7307
7308 2019-01-14  Tom Tromey  <tom@tromey.com>
7309
7310         PR tui/28819:
7311         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7312
7313 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7314
7315         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7316         field.
7317         * rs6000-tdep.c: Include reggroups.h.
7318         (IS_V_ALIAS_PSEUDOREG): Define.
7319         (rs6000_register_name): Return names for the "vX" aliases.
7320         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7321         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7322         aliases.  Call default_register_reggroup_p for all other
7323         pseudo-registers.
7324         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7325         New functions.
7326         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7327         Handle "vX" aliases.
7328         (v_alias_pseudo_register_collect): New function.
7329         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7330         (rs6000_gdbarch_init): Initialize "vX" aliases as
7331         pseudo-registers.  Restore registration of
7332         rs6000_pseudo_register_reggroup_p with
7333         set_tdesc_pseudo_register_reggroup_p.
7334
7335 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7336
7337         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7338         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7339         set_gdbarch_num_pseudo_regs.
7340
7341 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7342
7343         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7344         Remove arg prefixname, add do_set and do_show.
7345         Add member functions set_list and show_list.
7346         * cli/cli-style.c (class cli_style_option): Update accordingly.
7347         (style_set_list): Move to file scope.
7348         (style_show_list): Likewise.
7349         (set_style): Call help_list.
7350         (show_style): Call cmd_show_list.
7351         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7352         Update to use the new macro.
7353
7354 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7355
7356         * ada-lang.c (_initialize_ada_language): Expand the help text
7357         for the "catch exception" command.
7358
7359 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7360
7361         * symtab.c (matching_obj_sections): Initialize obj,
7362         declare it closer to its usage.
7363
7364 2019-01-10  Tom Tromey  <tom@tromey.com>
7365
7366         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7367         (basic_inf_threads_range): Remove.
7368         (inf_threads_range, inf_non_exited_threads_range)
7369         (safe_inf_threads_range): Use next_adapter.
7370
7371 2019-01-10  Keith Seitz  <keiths@redhat.com>
7372
7373         PR gdb/23712
7374         PR symtab/23010
7375         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7376         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7377
7378 2019-01-10  Keith Seitz  <keiths@redhat.com>
7379
7380         PR gdb/23712
7381         PR symtab/23010
7382         * dictionary.c (pending_to_vector): Remove.
7383         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7384         Remove _1 suffix, replacing functions of the same name.  Update
7385         all callers.
7386         (dict_create_hashed, dict_create_hashed_expandable)
7387         (dict_create_linear, dict_create_linear_expandable, dict_free)
7388         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7389         Make functions static.
7390
7391 2019-01-10  Keith Seitz  <keiths@redhat.com>
7392
7393         PR gdb/23712
7394         PR symtab/23010
7395         * dictionary.h (struct dictionary): Replace declaration with
7396         multidictionary.
7397         (dict_create_hashed, dict_create_hashed_expandable)
7398         (dict_create_linear, dict_create_linear_expandable)
7399         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7400         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7401         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7402         taking multidictionary argument.
7403         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7404         * block.h (struct block) <dict>: Change to multidictionary
7405         and rename `multidict'.
7406         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7407         symmisc.c: Update all dictionary references to multidictionary.
7408
7409 2019-01-10  Keith Seitz  <keiths@redhat.com>
7410
7411         PR gdb/23712
7412         PR symtab/23010
7413         * dictionary.c: Include unordered_map.
7414         (pending_to_vector): New function.
7415         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7416         Rewrite the non-"_1" functions to take vector instead
7417         of linked list.
7418         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7419         "new" _1 versions of the same name.
7420         (multidictionary): Define.
7421         (std::hash<enum language): New definition.
7422         (collate_pending_symbols_by_language, mdict_create_hashed)
7423         (mdict_create_hashed_expandable, mdict_create_linear)
7424         (mdict_create_linear_expandable, mdict_free)
7425         (find_language_dictionary, create_new_language_dictionary)
7426         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7427         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7428         (mdict_size, mdict_empty): New functions.
7429         * dictionary.h (mdict_iterator): Define.
7430
7431 2019-01-10  Pedro Alves  <palves@redhat.com>
7432
7433         * breakpoint.c (read_uploaded_action)
7434         (create_tracepoint_from_upload): Adjust to use
7435         gdb::unique_xmalloc_ptr.
7436         * ctf.c (ctf_write_uploaded_tp):
7437         (SET_ARRAY_FIELD): Use emplace_back.
7438         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7439         * tracefile-tfile.c (tfile_write_uploaded_tp):
7440         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7441         gdb::unique_xmalloc_ptr.
7442         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7443         at_string, cond_string, cmd_strings>: Replace char pointers
7444         with gdb::unique_xmalloc_ptr.
7445
7446 2019-01-10  Pedro Alves  <palves@redhat.com>
7447
7448         * solib-target.c (library_list_start_library): Don't xstrdup name.
7449
7450 2019-01-10  Pedro Alves  <palves@redhat.com>
7451
7452         * mdebugread.c (parse_partial_symbols): Use
7453         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7454
7455 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7456
7457         * linux-fork.c (scoped_switch_fork_info)
7458         <~scoped_switch_fork_info>: Fix incorrect variable name.
7459
7460 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         * linux-fork.c (scoped_switch_fork_info)
7463         <scoped_switch_fork_info>: Make explicit.
7464         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7465
7466 2019-01-10  Tom Tromey  <tom@tromey.com>
7467
7468         * objfiles.h (objfile::reset_psymtabs): Update.
7469         * objfiles.c (objfile::objfile): Update.
7470         * psymtab.h (psymtab_storage::obstack): Update.
7471         (psymtab_storage::m_obstack): Use gdb::optional.
7472         (class psymtab_storage): Update comment.  Remove objfile
7473         parameter.
7474         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7475
7476 2019-01-10  Tom Tromey  <tom@tromey.com>
7477
7478         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7479         <free_psymtabs>: Now private.
7480         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7481         (allocate_psymtab): Use new method.
7482
7483 2019-01-10  Tom Tromey  <tom@tromey.com>
7484
7485         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7486         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7487         * mdebugread.c (parse_partial_symbols): Use
7488         allocate_dependencies.
7489         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7490         allocate_dependencies.
7491         (process_psymtab_comp_unit_reader)
7492         (build_type_psymtab_dependencies): Likewise.
7493         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7494
7495 2019-01-10  Tom Tromey  <tom@tromey.com>
7496
7497         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7498         PSYMBOL_SET_LANGUAGE.
7499         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7500
7501 2019-01-10  Tom Tromey  <tom@tromey.com>
7502
7503         * psymtab.h (psymtab_storage::obstack): New method.
7504         <m_obstack>: Rename from obstack; now private.
7505         * psymtab.c (psymtab_storage): Update.
7506         * dwarf2read.c (create_addrmap_from_index)
7507         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7508         Update.
7509
7510 2019-01-10  Tom Tromey  <tom@tromey.com>
7511
7512         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7513         * objfiles.h (objfile::reset_psymtabs): New method.
7514
7515 2019-01-10  Tom Tromey  <tom@tromey.com>
7516
7517         * symmisc.c (print_symbol_bcache_statistics): Update.
7518         (print_objfile_statistics): Update.
7519         * symfile.c (reread_symbols): Update.
7520         * psymtab.h (class psymtab_storage): New.
7521         * psymtab.c (psymtab_storage): New constructor.
7522         (~psymtab_storage): New destructor.
7523         (require_partial_symbols): Update.
7524         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7525         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7526         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7527         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7528         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7529         (start_psymtab_common, end_psymtab_common)
7530         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7531         (allocate_psymtab): Update.
7532         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7533         Update.
7534         (dump_psymtab_addrmap, maintenance_print_psymbols)
7535         (maintenance_check_psymtabs): Update.
7536         (class objfile_psymtabs): Move to objfiles.h.
7537         * psympriv.h (discard_psymtab): Now inline.
7538         (psymtab_discarder::psymtab_discarder): Update.
7539         (psymtab_discarder::~psymtab_discarder): Update.
7540         (ALL_OBJFILE_PSYMTABS): Rewrite.
7541         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7542         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7543         Remove fields.
7544         <partial_symtabs>: New field.
7545         (class objfile_psymtabs): Move from psymtab.h.  Update.
7546         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7547         psymbol_cache.
7548         (objfile::~objfile): Don't destroy psymbol_cache.
7549         * mdebugread.c (parse_partial_symbols): Update.
7550         * dwarf2read.c (create_addrmap_from_index)
7551         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7552         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7553         (add_partial_subprogram, dwarf2_ranges_read): Update.
7554         * dwarf-index-write.c (write_address_map)
7555         (write_one_signatured_type, recursively_write_psymbols)
7556         (class debug_names, class debug_names, write_psymtabs_to_index):
7557         Update.
7558
7559 2019-01-10  Tom Tromey  <tom@tromey.com>
7560
7561         * symtab.h (SYMBOL_SET_NAMES): Update.
7562         (symbol_set_names): Update.
7563         (MSYMBOL_SET_NAMES): Update.
7564         * symtab.c (symbol_set_names): Change argument to be an
7565         objfile_per_bfd_storage.
7566         * psymtab.c (add_psymbol_to_bcache): Update.
7567         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7568
7569 2019-01-10  Tom Tromey  <tom@tromey.com>
7570
7571         * symtab.c (create_demangled_names_hash): Change argument to be an
7572         objfile_per_bfd_storage.
7573         (symbol_set_names): Update.
7574
7575 2019-01-10  Tom Tromey  <tom@tromey.com>
7576
7577         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7578         init_psymbol_list.
7579         * psymtab.c (init_psymbol_list): Do nothing if already called.
7580         * psympriv.h (init_psymbol_list): Add comment.
7581         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7582         init_psymbol_list.
7583         * dbxread.c (dbx_symfile_read): Unconditionally call
7584         init_psymbol_list.
7585
7586 2019-01-10  Tom Tromey  <tom@tromey.com>
7587
7588         * xcoffread.c (scan_xcoff_symtab): Update.
7589         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7590         "where".
7591         * mdebugread.c (parse_partial_symbols)
7592         (handle_psymbol_enumerators): Update.
7593         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7594         * dbxread.c (read_dbx_symtab): Update.
7595         * psympriv.h (psymbol_placement): New enum.
7596         (add_psymbol_to_list): Update.
7597
7598 2019-01-10  Tom Tromey  <tom@tromey.com>
7599
7600         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7601         static_psymbols parameters.
7602         (scan_xcoff_symtab): Update.
7603         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7604         static_psymbols parameters.
7605         * psympriv.h (start_psymtab_common): Update.
7606         * mdebugread.c (parse_partial_symbols): Update.
7607         * dwarf2read.c (create_partial_symtab): Update.
7608         * dbxread.c (read_dbx_symtab): Update.
7609         (start_psymtab): Remove global_psymbols and static_psymbols
7610         parameters.
7611
7612 2019-01-10  Tom Tromey  <tom@tromey.com>
7613
7614         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7615         * psymtab.c (allocate_psymtab): Add comment.
7616         * psympriv.h (allocate_psymtab): Add comment.
7617         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7618         initializations.
7619         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7620
7621 2019-01-10  Tom Tromey  <tom@tromey.com>
7622
7623         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7624         Don't declare.
7625         * mipsread.c: Include mdebugread.h.
7626         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7627         Declare.
7628         * elfread.c: Include mdebugread.h.
7629
7630 2019-01-09  Tom Tromey  <tom@tromey.com>
7631
7632         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7633         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7634         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7635         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7636         (psym_lookup_symbol, psym_find_last_source_symtab)
7637         (psym_forget_cached_source_info, psym_print_stats)
7638         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7639         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7640         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7641         (psym_find_compunit_symtab_by_address)
7642         (maintenance_print_psymbols, maintenance_info_psymtabs)
7643         (maintenance_check_psymtabs): Use ranged for.
7644         * psymtab.h (class objfile_psymtabs): New.
7645         (require_partial_symbols): Return objfile_psymtabs.
7646         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7647
7648 2019-01-09  Tom Tromey  <tom@tromey.com>
7649
7650         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7651         (find_pc_mapped_section, list_overlays_command)
7652         (map_overlay_command, unmap_overlay_command)
7653         (simple_overlay_update): Use all_objfiles.
7654         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7655         * printcmd.c (info_symbol_command): Use all_objfiles.
7656         * objfiles.h (ALL_OBJSECTIONS): Remove.
7657         * maint.c (maintenance_translate_address): Use all_objfiles.
7658         * gcore.c (gcore_create_callback): Use all_objfiles.
7659         (objfile_find_memory_regions): Likewise.
7660
7661 2019-01-09  Tom Tromey  <tom@tromey.com>
7662
7663         * symtab.c (find_line_symtab, info_sources_command)
7664         (make_source_files_completion_list): Use objfile_compunits.
7665         * source.c (select_source_symtab): Use objfile_compunits.
7666         * objfiles.h (struct objfile): Update comment.
7667         (ALL_OBJFILES): Remove.
7668         (ALL_FILETABS): Remove.
7669         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7670         objfile_compunits.
7671
7672 2019-01-09  Tom Tromey  <tom@tromey.com>
7673
7674         * symmisc.c (print_objfile_statistics, dump_objfile)
7675         (maintenance_print_symbols): Use compunit_filetabs.
7676         * source.c (forget_cached_source_info_for_objfile): Use
7677         compunit_filetabs.
7678         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7679         (ALL_FILETABS): Use compunit_filetabs.
7680         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7681         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7682
7683 2019-01-09  Tom Tromey  <tom@tromey.com>
7684
7685         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7686         (compunit_filetabs): New.
7687         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7688         compunit_filetabs.
7689         (info_sources_command, make_source_files_completion_list): Remove
7690         declaration.
7691         * symmisc.c (print_objfile_statistics, dump_objfile)
7692         (maintenance_print_symbols): Remove declaration.
7693         (maintenance_info_symtabs): Use compunit_filetabs.
7694         (maintenance_info_line_tables): Likewise.
7695         * source.c (select_source_symtab): Change local variable name.
7696         (forget_cached_source_info_for_objfile): Remove declaration.
7697         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7698         * objfiles.c (objfile_relocate1): Remove declaration.
7699         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7700         declaration.
7701         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7702         * coffread.c (coff_symtab_read): Remove declaration.
7703         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7704         compunit_filetabs.
7705
7706 2019-01-09  Tom Tromey  <tom@tromey.com>
7707
7708         * symtab.c (lookup_objfile_from_block)
7709         (find_pc_sect_compunit_symtab, search_symbols)
7710         (default_collect_symbol_completion_matches_break_on): Use
7711         objfile_compunits.
7712         * objfiles.h (ALL_COMPUNITS): Remove.
7713         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7714         * cp-support.c (add_symbol_overload_list_qualified): Use
7715         objfile_compunits.
7716         * ada-lang.c (ada_collect_symbol_completion_matches)
7717         (ada_add_global_exceptions): Use objfile_compunits.
7718
7719 2019-01-09  Tom Tromey  <tom@tromey.com>
7720
7721         * source.c (select_source_symtab)
7722         (forget_cached_source_info_for_objfile): Remove declaration.
7723         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7724         declaration.
7725         * maint.c (count_symtabs_and_blocks): Remove declaration.
7726         * cp-support.c (add_symbol_overload_list_qualified): Remove
7727         declaration.
7728         * coffread.c (coff_symtab_read): Remove declaration.
7729         * symtab.c (lookup_symbol_in_objfile_symtabs)
7730         (basic_lookup_transparent_type_1): Use objfile_compunits.
7731         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7732         (info_sources_command, search_symbols)
7733         (default_collect_symbol_completion_matches_break_on)
7734         (make_source_files_completion_list): Remove declaration.
7735         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7736         (ada_collect_symbol_completion_matches)
7737         (ada_add_global_exceptions): Remove declaration.
7738         * linespec.c (iterate_over_all_matching_symtabs): Use
7739         objfile_compunits.
7740         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7741         (class objfile_compunits): New.
7742         (ALL_COMPUNITS): Use objfile_compunits.
7743         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7744         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7745         objfile_compunits.
7746         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7747
7748 2019-01-09  Tom Tromey  <tom@tromey.com>
7749
7750         * symtab.c (search_symbols)
7751         (default_collect_symbol_completion_matches_break_on): Use
7752         objfile_msymbols.
7753         * ada-lang.c (ada_lookup_simple_minsym)
7754         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7755         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7756         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7757         objfile_msymbols.
7758         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7759         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7760         * objc-lang.c (find_methods): Use objfile_msymbols.
7761         (info_selectors_command, info_classes_command): Likewise.
7762         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7763         * objfiles.h (class objfile_msymbols): New.
7764         (ALL_OBJFILE_MSYMBOLS): Remove.
7765         (ALL_MSYMBOLS): Remove.
7766
7767 2019-01-09  Tom Tromey  <tom@tromey.com>
7768
7769         * common/next-iterator.h (next_adapter): Add Iterator template
7770         parameter.
7771         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7772         (class all_objfiles_safe): New.
7773         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7774         * objfiles.c (put_objfile_before): Update comment.
7775         (add_separate_debug_objfile): Likewise.
7776         (free_all_objfiles): Use all_objfiles_safe.
7777         (objfile_purge_solibs): Likewise.
7778
7779 2019-01-09  Tom Tromey  <tom@tromey.com>
7780
7781         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7782         (expand_symtab_containing_pc, lookup_static_symbol)
7783         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7784         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7785         all_objfiles.
7786         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7787         * breakpoint.c (create_overlay_event_breakpoint)
7788         (create_longjmp_master_breakpoint)
7789         (create_std_terminate_master_breakpoint)
7790         (create_exception_master_breakpoint): Use all_objfiles.
7791         * linux-thread-db.c (try_thread_db_load_from_pdir)
7792         (has_libpthread): Use all_objfiles.
7793         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7794         * linespec.c (iterate_over_all_matching_symtabs)
7795         (search_minsyms_for_name): Use all_objfiles.
7796         * maint.c (maintenance_info_sections): Use all_objfiles.
7797         * main.c (captured_main_1): Use all_objfiles.
7798         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7799         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7800         * guile/scm-pretty-print.c
7801         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7802         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7803         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7804         (maintenance_print_msymbols): Use all_objfiles.
7805         * source.c (select_source_symtab): Use all_objfiles.
7806         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7807         * symfile.c (remove_symbol_file_command)
7808         (expand_symtabs_matching, map_symbol_filenames): Use
7809         all_objfiles.
7810         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7811         all_objfiles.
7812         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7813         * objc-lang.c (find_methods): Use all_objfiles.
7814         * objfiles.c (have_partial_symbols, have_full_symbols)
7815         (have_minimal_symbols, qsort_cmp)
7816         (default_iterate_over_objfiles_in_search_order): Use
7817         all_objfiles.
7818         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7819         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7820         (maintenance_check_psymtabs): Use all_objfiles.
7821         (ALL_PSYMTABS): Remove.
7822         * compile/compile-object-run.c (do_module_cleanup): Use
7823         all_objfiles.
7824         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7825         * cp-support.c (add_symbol_overload_list_qualified): Use
7826         all_objfiles.
7827         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7828         Use all_objfiles.
7829         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7830         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7831         all_objfiles.
7832         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7833         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7834         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7835         Uses all_objfiles.
7836         * solib.c (solib_read_symbols): Use all_objfiles
7837
7838 2019-01-09  Tom Tromey  <tom@tromey.com>
7839
7840         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7841         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7842         all_objfiles.
7843         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7844         * symmisc.c (print_symbol_bcache_statistics)
7845         (print_objfile_statistics, maintenance_print_objfiles)
7846         (maintenance_info_symtabs, maintenance_check_symtabs)
7847         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7848         all_objfiles.
7849         * source.c (forget_cached_source_info): Use all_objfiles.
7850         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7851         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7852         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7853         * objfiles.c (update_section_map): Use all_objfiles.
7854         (shared_objfile_contains_address_p): Likewise.
7855         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7856         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7857
7858 2019-01-09  Tom Tromey  <tom@tromey.com>
7859
7860         * common/next-iterator.h: New file.
7861         * objfiles.h (class all_objfiles): New.
7862         (struct objfile_iterator): New.
7863
7864 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7865
7866         * NEWS: Move the description of the changed "frame", "select-frame",
7867          and "info frame" commands to the Changed commands section.
7868
7869 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7870
7871         * gdbtypes.c (check_stub_method_group): Remove handling of old
7872         mangling schemes.
7873         * linespec.c (find_methods): Likewise.
7874         * stabsread.c (read_member_functions): Likewise.
7875         * valops.c (search_struct_method): Likewise.
7876         (value_struct_elt_for_reference): Likewise.
7877         * NEWS: Mention this change.
7878
7879 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7880
7881         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7882         print_source_lines.
7883         * source.c (print_source_lines_base): Update line number check.
7884         (print_source_lines): New function.
7885         (source_lines_range::source_lines_range): New function.
7886         * source.h (class source_lines_range): New class.
7887         (print_source_lines): New declaration.
7888
7889 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7890
7891         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7892
7893 2019-01-08  Tom Tromey  <tom@tromey.com>
7894             Simon Marchi  <simon.marchi@ericsson.com>
7895
7896         PR gdb/24060
7897         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7898         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7899         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7900         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7901         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7902         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7903
7904 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7905
7906         * source.c (select_source_symtab): Move header comment to
7907         declaration in source.h.
7908         (forget_cached_source_info_for_objfile): Likewise.
7909         (forget_cached_source_info): Likewise.
7910         (identify_source_line): Likewise.
7911         * source.h (identify_source_line): Move declaration from symtab.h
7912         and add comment from source.c
7913         (print_source_lines): Likewise.
7914         (forget_cached_source_info_for_objfile): Likewise.
7915         (forget_cached_source_info): Likewise.
7916         (select_source_symtab): Likewise.
7917         (enum print_source_lines_flag): Move definition from symtab.h.
7918         * symtab.h (identify_source_line): Move declaration to source.h.
7919         (print_source_lines): Likewise.
7920         (forget_cached_source_info_for_objfile): Likewise.
7921         (forget_cached_source_info): Likewise.
7922         (select_source_symtab): Likewise.
7923         (enum print_source_lines_flag): Move definition to source.h.
7924         * tui/tui-hooks.c: Add 'source.h' include.
7925
7926 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7927
7928         * source.c (print_source_lines_base): Handle requests to print
7929         reverse line number sequences, and guard against empty lines
7930         string.
7931
7932 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7933
7934         * source.c (print_source_lines_base): Fix skip of '\r' if next
7935         character is '\n'.
7936
7937 2019-01-06  Tom Tromey  <tom@tromey.com>
7938
7939         * c-exp.y (struct c_parse_state) <macro_original_text,
7940         expansion_obstack>: New member.
7941         (macro_original_text, expansion_obstack): Remove globals.
7942         (scan_macro_expansion, scanning_macro_expansion)
7943         (finished_macro_expansion): Update.
7944         (scan_macro_cleanup): Remove.
7945         (yylex, c_parse): Update.
7946
7947 2019-01-06  Tom Tromey  <tom@tromey.com>
7948
7949         * c-exp.y (struct c_parse_state) <strings>: New member.
7950         (operator_stoken): Update.
7951
7952 2019-01-06  Tom Tromey  <tom@tromey.com>
7953
7954         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7955         (union type_stack_elt) <typelist_val>: Now a pointer to
7956         std::vector.
7957         (type_stack_cleanup): Don't declare.
7958         (push_typelist): Update.
7959         * parse.c (pop_typelist): Return a std::vector.
7960         (push_typelist): Take a std::vector.
7961         (follow_types): Update.  Do not free args.
7962         (type_stack_cleanup): Remove.
7963         * c-exp.y (struct c_parse_state): New.
7964         (cpstate): New global.
7965         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7966         (nonempty_typelist): Update.
7967         (func_mod): Create a new vector.
7968         (c_parse): Create a c_parse_state.
7969         (check_parameter_typelist): Do not delete params.
7970         (function_method): Update.  Do not delete type_list.
7971
7972 2019-01-06  Tom Tromey  <tom@tromey.com>
7973
7974         PR gdb/28155:
7975         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7976         check_typedef.
7977         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7978         (print_return_value): Likewise.
7979
7980 2019-01-05  Tom Tromey  <tom@tromey.com>
7981
7982         * contrib/cleanup_check.py: Remove.
7983         * contrib/gcc-with-excheck: Remove.
7984         * contrib/exsummary.py: Remove.
7985         * contrib/excheck.py: Remove.
7986
7987 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7988
7989         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7990         NULL. Initialize tpprev to NULL instead of assigning it
7991         to NULL on the next statement.
7992         * windows-nat.c (windows_delete_thread): Remove check for
7993         main_thread_id before printing thread exit notifications.
7994         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7995         Remove thread ID check against main_thread_id.
7996         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7997         windows_delete_thread.
7998         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7999
8000 2019-01-04  Tom Tromey  <tom@tromey.com>
8001
8002         * compile/compile.c (_initialize_compile): Use upper case for
8003         metasyntactic variables.
8004         * symmisc.c (_initialize_symmisc): Use upper case for
8005         metasyntactic variables.
8006         * psymtab.c (_initialize_psymtab): Use upper case for
8007         metasyntactic variables.
8008         * demangle.c (demangle_command): Use upper case for metasyntactic
8009         variables.
8010         (_initialize_demangler): Likewise.
8011         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8012         variables.
8013
8014 2019-01-03  Tom Tromey  <tom@tromey.com>
8015
8016         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8017
8018 2019-01-03  Tom Tromey  <tom@tromey.com>
8019
8020         * python/py-symtab.c (salpy_str): Update.
8021         (struct salpy_sal_object) <symtab>: Now a PyObject.
8022         (salpy_dealloc): Update.
8023         (del_objfile_sal): Use gdbpy_ref.
8024
8025 2019-01-03  Tom Tromey  <tom@tromey.com>
8026
8027         * python/py-type.c (convert_field): Use new_reference.  Return
8028         gdbpy_ref.
8029         (make_fielditem): Return gdbpy_ref.
8030         (typy_fields): Update.
8031         (typy_getitem): Update.
8032         (field_name): Return gdbpy_ref.  Use new_reference.
8033         (typy_iterator_iternext): Update.
8034
8035 2019-01-03  Tom Tromey  <tom@tromey.com>
8036
8037         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8038
8039 2019-01-03  Tom Tromey  <tom@tromey.com>
8040
8041         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8042         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8043         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8044         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8045         (pspy_set_type_printers): Likewise.
8046         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8047         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8048         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8049         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8050         (objfpy_set_type_printers): Likewise.
8051
8052 2019-01-03  Tom Tromey  <tom@tromey.com>
8053
8054         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8055         (gdbpy_print_stack): Use gdbpy_err_fetch.
8056         * python/python-internal.h (class gdbpy_err_fetch): New class.
8057         (class gdbpy_enter) <m_error_type, m_error_value,
8058         m_error_traceback>: Remove.
8059         <m_error>: New member.
8060         (gdbpy_exception_to_string): Don't declare.
8061         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8062         * python/py-value.c (convert_value_from_python): Use
8063         gdbpy_err_fetch.
8064         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8065         gdbpy_exception_to_string.
8066         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8067         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8068         gdbpy_err_fetch.
8069
8070 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8071
8072         * linux-nat.c (delete_lwp_cleanup): Delete.
8073         (struct lwp_deleter): New struct.
8074         (lwp_info_up): New typedef.
8075         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8076         lwp_info_up.
8077
8078 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8079
8080         * linux-fork.c (class scoped_switch_fork_info): New class.
8081         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8082
8083 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         * valops.c (find_overload_match): Remove use of null_cleanup, and
8086         calls to do_cleanups.
8087
8088 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8089
8090         * compile/compile-cplus-types.c
8091         (compile_cplus_instance::decl_name): Handle changes to
8092         cp_func_name.
8093         * cp-support.c (cp_func_name): Update header comment, update
8094         return type.
8095         * cp-support.h (cp_func_name): Update return type in declaration.
8096         * valops.c (find_overload_match): Move temp_func local to top
8097         level of function and change its type.  Use temp_func to hold and
8098         delete temporary string obtained from cp_func_name.
8099
8100 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8101
8102         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8103         gdb::char_vector, remove cleanup, and update uses of `msg`.
8104
8105 2019-01-03  Jim Wilson  <jimw@sifive.com>
8106
8107         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8108
8109 2019-01-02  Tom Tromey  <tom@tromey.com>
8110
8111         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8112         (tdesc_parse_xml): Remove cleanups.
8113         * target-descriptions.h (make_cleanup_free_target_description):
8114         Don't declare.
8115         (target_desc_deleter): New struct.
8116         (target_desc_up): New typedef.
8117         * target-descriptions.c (target_desc_deleter::operator()): Rename
8118         from free_target_description.
8119         (make_cleanup_free_target_description): Remove.
8120
8121 2019-01-02  Tom Tromey  <tom@tromey.com>
8122
8123         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8124         constructor, destructor.
8125         (linespec_parser): Remove typedef.
8126         (~linespec_parser): Rename from linespec_parser_delete.
8127         (linespec_lex_to_end, linespec_complete_label)
8128         (linespec_complete): Update.
8129         (decode_line_full): Remove cleanups.
8130         (decode_line_1): Update.
8131
8132 2019-01-02  Tom Tromey  <tom@tromey.com>
8133
8134         * python/python-internal.h (inferior_to_inferior_object): Change
8135         return type.
8136         * python/py-exitedevent.c (create_exited_event_object): Update.
8137         * python/py-inferior.c (inferior_to_inferior_object): Return
8138         gdbpy_ref.
8139         (python_new_inferior, python_inferior_deleted)
8140         (thread_to_thread_object, delete_thread_object)
8141         (build_inferior_list, gdbpy_selected_inferior): Update.
8142         * python/py-infthread.c (create_thread_object): Update.  Also fail
8143         if inferior_to_inferior_object fails.
8144
8145 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8146
8147         * inferior.h (class inferior) <displaced_step_state>: New field.
8148         * infrun.h (struct displaced_step_state): Move here from
8149         infrun.c.  Initialize fields, add constructor.
8150         <inf>: Remove field.
8151         <reset>: New method.
8152         * infrun.c (struct displaced_step_inferior_state): Move to
8153         infrun.h.
8154         (displaced_step_inferior_states): Remove.
8155         (get_displaced_stepping_state): Adust.
8156         (displaced_step_in_progress_any_inferior): Adjust.
8157         (displaced_step_in_progress_thread): Adjust.
8158         (displaced_step_in_progress): Adjust.
8159         (add_displaced_stepping_state): Remove.
8160         (get_displaced_step_closure_by_addr): Adjust.
8161         (remove_displaced_stepping_state): Remove.
8162         (infrun_inferior_exit): Call displaced_step_state.reset.
8163         (use_displaced_stepping): Don't check for NULL.
8164         (displaced_step_prepare_throw): Call
8165         get_displaced_stepping_state.
8166         (displaced_step_fixup): Don't check for NULL.
8167         (prepare_for_detach): Don't check for NULL.
8168
8169 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8170
8171         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8172          in case of call that did not complete.
8173
8174 2019-01-02  Andrey Utkin  <autkin@undo.io>
8175
8176         * symfile.c (find_separate_debug_file): Fix search of debug files for
8177         remote debuggee.
8178
8179 2019-01-02  Tom Tromey  <tom@tromey.com>
8180
8181         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8182         indentation.
8183         * python/py-frame.c (frapy_older): Remove cast.
8184         (frapy_newer): Likewise.
8185         * python/py-breakpoint.c (local_setattro): Remove cast.
8186         * python/py-arch.c (archpy_name): Remove local variable.
8187         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8188
8189 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8190
8191         * unittests/basic_string_view/element_access/char/empty.cc:
8192         Fix year range in copyright header.
8193
8194 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8195
8196         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8197         Delete.
8198         <operator==>: Update with for removed field.
8199         <hash>: Likewise.
8200         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8201         <isa_features>: ...this.
8202         <abi_features>: New field.
8203         (riscv_isa_flen): Update comment.
8204         (riscv_abi_xlen): New declaration.
8205         (riscv_abi_flen): New declaration.
8206         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8207         isa_features.
8208         (riscv_abi_xlen): New function.
8209         (riscv_isa_flen): Update to get answer from isa_features.
8210         (riscv_abi_flen): New function.
8211         (riscv_has_fp_abi): Update to get answer from abi_features.
8212         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8213         xlen and flen.
8214         (riscv_call_info) <xlen, flen>: Update comment.
8215         (riscv_call_arg_struct): Remove invalid assertions
8216         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8217         is removed.
8218         (riscv_gdbarch_init): Gather isa features and abi features
8219         separately, ensure both match on the gdbarch when reusing an old
8220         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8221         a target with 64-bit float hardware.
8222
8223 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8224
8225         * source.c (search_command_helper): Stop reverse search
8226         when line 1 has been searched.
8227
8228 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8229
8230         * record-full.c (record_full_base_target::close): Rewrite
8231         record_full_core_buf_list free logic.
8232
8233 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8234
8235         * break-catch-syscall.c (print_one_catch_syscall): xfree
8236         the last text.
8237
8238 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8239
8240         * top.c (print_gdb_version): Update Copyright year in version
8241         message.
8242
8243 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8244
8245         Update copyright year range in all GDB files.
8246
8247 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8248
8249         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8250
8251 For older changes see ChangeLog-2018.
8252 \f
8253 Local Variables:
8254 mode: change-log
8255 left-margin: 8
8256 fill-column: 74
8257 version-control: never
8258 coding: utf-8
8259 End:
8260