gdb/ChangeLog

   1 2018-08-08  Jim Wilson  <jimw@sifive.com>
   2
   3         * riscv-tdep.c (enum opcode): Add jump, branch, lr, and sc opcodes.
   4         (decode_register_index_short): New.
   5         (decode_j_type_insn, decode_cj_type_insn): New.
   6         (decode_b_type_insn, decode_cb_type_insn): New.
   7         (riscv_insn::decode): Add support for jumps, branches, lr, and sc.  New
   8         local xlen.  Check xlen when decoding ambiguous compressed insns.  In
   9         compressed decode, use is_c_lui_insn instead of is_lui_insn, and
  10         is_c_sw_insn instead of is_sw_insn.
  11         (riscv_next_pc, riscv_next_pc_atomic_sequence): New.
  12         (riscv_software_single_step): New.
  13         * riscv-tdep.h (riscv_software_single_step): Declare.
  14
  15         * riscv-tdep.c (riscv_isa_xlen): Drop static.
  16         * riscv-tdep.h (riscv_isa_xlen): Add extern declaration.
  17
  18 2018-08-08  Andrew Burgess  <andrew.burgess@embecosm.com>
  19
  20         PR gdb/18050:
  21         * target.c (dispose_inferior): Don't dispose of inferiors that are
  22         already killed.
  23
  24 2018-08-08  Szabolcs Nagy  <szabolcs.nagy@arm.com>
  25
  26         * remote.c (remote_target::download_tracepoint): Change char* to
  27         const char*.
  28
  29 2018-08-07  Simon Marchi  <simon.marchi@polymtl.ca>
  30
  31         * target.h (target_options_to_string): Return an std::string.
  32         * target.c (str_comma_list_concat_elem): Return void, use
  33         std::string.
  34         (do_option): Likewise.
  35         (target_options_to_string): Return an std::string.
  36         * linux-nat.c (linux_nat_target::wait): Adjust.
  37         * target-debug.h (target_debug_print_options): Adjust.
  38
  39 2018-08-07  Tom Tromey  <tom@tromey.com>
  40
  41         * Makefile.in (CPPFLAGS): New variable.
  42         (INTERNAL_CPPFLAGS): Use it.
  43
  44 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  45
  46         * NEWS: Mention the index cache.
  47
  48 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  49
  50         * common/pathstuff.h (get_standard_cache_dir): New.
  51         * common/pathstuff.c (get_standard_cache_dir): New.
  52         * build-id.h (build_id_to_string): New.
  53         * dwarf-index-common.h (INDEX4_SUFFIX, INDEX5_SUFFIX,
  54         DEBUG_STR_SUFFIX): Move to here.
  55         * dwarf-index-write.c (INDEX4_SUFFIX, INDEX5_SUFFIX,
  56         DEBUG_STR_SUFFIX): Move from there.
  57         (write_psymtabs_to_index): Make non-static, add basename
  58         parameter.  Write to temporary files, rename when done.
  59         (save_gdb_index_command): Adjust call to
  60         write_psymtabs_to_index.
  61         * dwarf2read.h (dwarf2_per_objfile) <index_cache_res>: New
  62         field.
  63         * dwarf2read.c (dwz_file) <index_cache_res>: New field.
  64         (get_gdb_index_contents_from_cache): New.
  65         (get_gdb_index_contents_from_cache_dwz): New.
  66         (dwarf2_initialize_objfile): Read index from cache.
  67         (dwarf2_build_psymtabs): Save to index.
  68         * dwarf-index-cache.h: New file.
  69         * dwarf-index-cache.c: New file.
  70         * dwarf-index-write.h: New file.
  71
  72 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  73
  74         * gnulib/aclocal.m4: Re-generate.
  75         * gnulib/config.in: Re-generate.
  76         * gnulib/configure: Re-generate.
  77         * gnulib/import/Makefile.am: Re-generate.
  78         * gnulib/import/Makefile.in: Re-generate.
  79         * gnulib/import/m4/gnulib-cache.m4: Re-generate.
  80         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
  81         * gnulib/import/m4/mkdir.m4: New file.
  82         * gnulib/import/mkdir.c: New file.
  83         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkdir
  84         module.
  85
  86 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  87
  88         * Makefile.in (COMMON_SFILES): Add common/scoped_mmap.c.
  89         * common/scoped_mmap.c: New file.
  90         * common/scoped_mmap.h (destroy): New method.
  91         (~scoped_mmap, reset): Use destroy.
  92         (scoped_mmap): New move constructor.
  93         (mmap_file): New declaration.
  94         * unittests/scoped_mmap-selftests.c (test_normal,
  95         test_invalid_filename, run_tests): New functions.
  96         (_initialize_scoped_mmap_selftests): Register selftest.
  97
  98 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
  99
 100         * dwarf2read.c (read_gdb_index_from_section): Rename to...
 101         (read_gdb_index_from_buffer): ... this.  Remove section
 102         parameter, add buffer parameter.
 103         (get_gdb_index_contents_ftype,
 104         get_gdb_index_contents_dwz_ftype): New typedefs.
 105         (dwarf2_read_gdb_index): Add callback parameters to get the
 106         index contents.
 107         (get_gdb_index_contents_from_section): New.
 108         (dwarf2_initialize_objfile): Update call to
 109         dwarf2_read_gdb_index.
 110
 111 2018-08-07  Simon Marchi  <simon.marchi@ericsson.com>
 112
 113         * common/filestuff.h (gdb_fopen_cloexec): New overload.
 114         (gdb_open_cloexec): Likewise.
 115         * nat/linux-osdata.c (command_from_pid): Use string_printf.
 116         (commandline_from_pid): Likewise.
 117         (linux_xfer_osdata_threads): Likewise.
 118         (linux_xfer_osdata_fds): Likewise.
 119         * ada-lang.c (is_package_name): Likewise.
 120         * auxv.c (procfs_xfer_auxv): Likewise.
 121         * breakpoint.c (print_one_breakpoint_location): Use
 122         uiout::field_fmt.
 123         (print_one_catch_solib): Use string_printf.
 124         * coff-pe-read.c (add_pe_exported_sym): Likewise.
 125         (add_pe_forwarded_sym): Likewise.
 126         * dwarf2read.c (create_type_unit_group): Likewise.
 127         (build_error_marker_type): Likewise.
 128         * infcall.c (get_function_name): Likewise.
 129         * valprint.c (print_converted_chars_to_obstack): Likewise.
 130         * xtensa-tdep.c (xtensa_register_type): Likewise.
 131
 132 2018-08-06  Simon Marchi  <simon.marchi@ericsson.com>
 133
 134         * remote.c (remote_target::download_tracepoint): Fix format
 135         string errors.
 136
 137 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 138
 139         * tracefile.c: Include common/byte-vector.h.
 140         (trace_save): Change type of buf to gdb::byte_vector.  Initialize
 141         with trace_regblock_size if needed.  Update uses of buf.
 142
 143 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 144
 145         * tracepoint.h (collection_list) <m_regs_mask>: Change type to
 146         std::vector<unsigned char>.
 147         * tracepoint.c (collection_list::collection_list): Remove
 148         m_regs_mask initializer from initializer list.  Resize
 149         m_regs_mask using the largest remote register number.
 150         (collection_list::add_remote_register): Remove size check on
 151         m_regs_mask.  Use at to access element.
 152         (collection_list::stringify): Change type of temp_buf to
 153         gdb::char_vector.  Update uses of temp_buf.  Resize if needed to
 154         stringify the register mask.  Use pack_hex_byte for the register
 155         mask.
 156
 157 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 158
 159         * tracepoint.h (class collection_list) <add_register>: Remove.
 160         <add_remote_register, add_ax_registers, add_local_register>:
 161         Declare.
 162         <add_memrange>: Add scope parameter.
 163         * tracepoint.c (encode_actions_1): Likewise.
 164         (collection_list::add_register): Rename to ...
 165         (collection_list::add_remote_register): ... this.  Update
 166         comment.
 167         (collection_list::add_ax_registers, add_local_register): New
 168         methods.
 169         (collection_list::add_memrange): Add scope parameter.  Call
 170         add_local_register instead of add_register.
 171         (finalize_tracepoint_aexpr): New function.
 172         (collection_list::collect_symbol): Update calls to add_memrange.
 173         Call add_local_register instead of add_register.  Call
 174         add_ax_registers.  Call finalize_tracepoint_aexpr.
 175         (encode_actions_1): Get remote regnos for $reg action.  Call
 176         add_remote_register, add_ax_registers, and add_local_register.
 177         Update call to add_memrange.  Call finalize_tracepoint_aexpr.
 178         (validate_actionline): Call finalize_tracepoint_aexpr.
 179
 180 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 181
 182         * remote.c (remote_target::download_tracepoint): Remove BUF_SIZE.
 183         Replace array buf with gdb::char_vector buf, of size
 184         get_remote_packet_size ().  Replace references to buf and
 185         BUF_SIZE to buf.data () and buf.size ().  Replace strcpy, strcat
 186         and xsnprintf with snprintf.  Raise errors if the buffer is too
 187         small.
 188
 189 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 190
 191         * remote.c (remote_target::download_tracepoint): Fix the has_more
 192         predicate in the QTDP action list iteration.
 193
 194 2018-08-06  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 195
 196         * remote.c (remote_target::download_tracepoint): Fix indentation
 197         in for block.
 198
 199 2018-08-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 200
 201         * proc-api.c (_initialize_proc_api): Remove c, unused.
 202         * procfs.c (procfs_init_inferior): Remove signals, unused.
 203         (procfs_target::make_corefile_notes): Remove old_chain, fpregs,
 204         unused.
 205
 206 2018-08-06  Sergey Korolev  <s.korolev@ndmsystems.com>
 207             Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * linux-nat.c (linux_nat_target::follow_fork): Avoid using
 210         'W_STOPCODE (0)' as this could be ambiguous.
 211
 212 2018-08-03  Sergio Durigan Junior  <sergiodj@redhat.com>
 213
 214         * ser-tcp.c (net_open): Fix thinko when deciding whether to
 215         disable TCP's Nagle algorithm (use "ai_protocol" instead of
 216         "ai_socktype").
 217
 218 2018-08-02  Tom Tromey  <tom@tromey.com>
 219
 220         PR symtab/16842.
 221         * dwarf2read.c (read_func_scope): Set symtab on template parameter
 222         symbols.
 223         (process_structure_scope): Likewise.
 224
 225 2018-08-02  Xavier Roirand  <roirand@adacore.com>
 226
 227         PR gdb/22629:
 228         * darwin-nat.c (darwin_kill_inferior): Fix handling of
 229         kill inferior.
 230
 231 2018-08-02  Tom Tromey  <tom@tromey.com>
 232
 233         * darwin-nat.c (find_inferior_task_it, darwin_find_thread)
 234         (darwin_suspend_inferior, darwin_resume_inferior)
 235         (darwin_decode_notify_message, darwin_resume_inferior_threads)
 236         (darwin_check_new_threads): Check result of get_darwin_inferior.
 237
 238 2018-07-31  Joel Brobecker  <brobecker@adacore.com>
 239
 240         GDB 8.1.1 released.
 241
 242 2018-07-31  Jan Vrany  <jan.vrany@fit.cvut.cz>
 243
 244         * varobj.c (varobj_get_path_expr_parent): Report an error if
 245         parent is a dynamic varobj.
 246
 247 2018-07-31  Simon Marchi  <simon.marchi@ericsson.com>
 248
 249         * gnulib/aclocal.m4: Re-generate.
 250         * gnulib/config.in: Re-generate.
 251         * gnulib/configure: Re-generate.
 252         * gnulib/import/Makefile.in: Re-generate.
 253         * gnulib/import/m4/gnulib-comp.m4: Re-generate.
 254         * gnulib/import/m4/onceonly.m4: Re-generate.
 255
 256 2018-07-31  Simon Marchi  <simon.marchi@ericsson.com>
 257
 258         * target-descriptions.c (struct xml_test_tdesc): New.
 259         (xml_tdesc): Change type to std::vector<xml_test_tdesc>.
 260         (record_xml_tdesc): Update.
 261         (maintenance_check_xml_descriptions): Update.
 262         * target-descriptions.h (record_xml_tdesc): Update comment.
 263
 264 2018-07-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 265
 266         * eval.c (evaluate_subexp_for_sizeof): Check for array type before
 267         checking array bounds are defined.
 268
 269 2018-07-30  Tom Tromey  <tom@tromey.com>
 270
 271         * nat/linux-osdata.c (pid_pgid_entry::operator<): Fix
 272         irreflexivity violation.
 273
 274 2018-07-30  Tom Tromey  <tom@tromey.com>
 275
 276         * cli/cli-decode.c (lookup_cmd): Remove lint code.
 277         * value.c (unpack_long): Remove lint code.
 278         * valops.c (value_ind): Remove lint code.
 279         * valarith.c (value_x_binop, value_x_unop, value_equal)
 280         (value_pos): Remove lint code.
 281
 282 2018-07-28  Tom de Vries  <tdevries@suse.de>
 283
 284         * eval.c (evaluate_subexp_for_sizeof): Interpret size of dynamic type
 285         with undefined upper bound as <optimized out>.
 286
 287 2018-07-27  Sergio Durigan Junior  <sergiodj@redhat.com>
 288
 289         * gcore.in: Rename variable "name" to "prefix".  Expand
 290         "usage" text.
 291
 292 2018-07-14  Jon Turney  <jon.turney@dronecode.org.uk>
 293
 294         * windows-nat.c (windows_nat_target::create_inferior): Update to
 295         call close() in global namespace.
 296
 297 2018-07-26  Tom Tromey  <tom@tromey.com>
 298
 299         * dwarf-index-write.c (add_address_entry): Don't add objfile
 300         offsets.
 301         * dbxread.c (find_stab_function): Rename from
 302         find_stab_function_addr.  Return a bound_minimal_symbol.
 303         (read_dbx_symtab): Use raw_text_low, raw_text_high.
 304         Don't add objfile offsets.
 305         (end_psymtab): Use raw_text_low, raw_text_high,
 306         MSYMBOL_VALUE_RAW_ADDRESS.
 307         (read_ofile_symtab): Update.
 308         (process_one_symbol): Update.
 309         * dwarf2read.c (create_addrmap_from_index): Don't add objfile
 310         offsets.
 311         (dw2_relocate): Remove.
 312         (dw2_find_pc_sect_symtab): Bias PC by the text offset before
 313         searching addrmap.
 314         (dwarf2_gdb_index_functions, dwarf2_debug_names_functions):
 315         Update.
 316         (process_psymtab_comp_unit_reader, add_partial_symbol)
 317         (add_partial_subprogram, dwarf2_ranges_read): Update.
 318         (load_partial_dies): Update.
 319         (add_address_entry): Don't add objfile offsets.
 320         (dwarf2_build_include_psymtabs): Update.
 321         (create_addrmap_from_aranges): Don't add objfile offsets.
 322         (dw2_find_pc_sect_compunit_symtab): Update.
 323         * mdebugread.c (parse_symbol): Don't add objfile offsets.
 324         (parse_lines): Remove 'pst' parameter, replace with 'textlow'.
 325         Update.
 326         (parse_partial_symbols): Don't add objfile offsets.  Use
 327         raw_text_low, raw_text_high.  Update.
 328         (handle_psymbol_enumerators, psymtab_to_symtab_1): Update.
 329         * objfiles.c (objfile_relocate1): Don't relocate psymtabs_addrmap
 330         or call 'relocate' quick function.  Clear psymbol_map.
 331         * psympriv.h (struct partial_symbol) <address>: Add section
 332         offset.
 333         <set_unrelocated_address>: Rename from set_address.
 334         <raw_text_low, raw_text_high>: New methods.
 335         <text_low, text_high>: Add objfile parameter.
 336         (add_psymbol_to_bcache): Add 'section' parameter.  Call
 337         set_unrelocated_address.
 338         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
 339         (find_pc_psymbol): Update.
 340         (fixup_psymbol_section, relocate_psymtabs): Remove.
 341         (dump_psymtab, psym_functions): Update.
 342         (add_psymbol_to_bcache, add_psymbol_to_list): Add 'section'
 343         parameter.
 344         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 345         (start_psymtab_common): Update.
 346         * symfile-debug.c (debug_qf_relocate): Remove.
 347         (debug_sym_quick_functions): Update.
 348         * symfile.h (struct quick_symbol_functions) <relocate>: Remove.
 349         * xcoffread.c (scan_xcoff_symtab): Don't add objfile offsets.
 350         Update.
 351
 352 2018-07-26  Tom Tromey  <tromey@redhat.com>
 353
 354         * dbxread.c (end_psymtab): Use text_high_valid and
 355         text_low_valid.
 356         * mdebugread.c (parse_partial_symbols): Use text_low_valid.
 357         (psymtab_to_symtab_1): Use text_high_valid and text_low_valid.
 358         * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
 359         Update comment.
 360         <text_low_valid, text_high_valid>: New fields.
 361         <set_text_low, set_text_high>: Update.
 362         * xcoffread.c (scan_xcoff_symtab): Use text_low_valid.
 363
 364 2018-07-26  Tom Tromey  <tom@tromey.com>
 365
 366         * dbxread.c (read_dbx_symtab, end_psymtab, read_ofile_symtab):
 367         Update.
 368         * dwarf2read.c (dwarf2_create_include_psymtab): Don't initialize
 369         textlow and texthigh fields.
 370         (process_psymtab_comp_unit_reader, dwarf2_build_include_psymtabs):
 371         Update.
 372         * mdebugread.c (parse_lines, parse_partial_symbols)
 373         (psymtab_to_symtab_1): Update.
 374         * psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
 375         Rename fields.  Update comment.  Now private.
 376         <text_low, text_high, set_text_low, set_text_high>: New methods.
 377         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
 378         (find_pc_sect_psymbol, relocate_psymtabs, dump_psymtab)
 379         (start_psymtab_common, maintenance_info_psymtabs)
 380         (maintenance_check_psymtabs): Update.
 381         * xcoffread.c (xcoff_end_psymtab): Don't initialize textlow and
 382         texthigh fields.
 383         (scan_xcoff_symtab): Update.
 384
 385 2018-07-26  Tom Tromey  <tromey@redhat.com>
 386
 387         * psympriv.h (struct partial_symbol) <unrelocated_address,
 388         address, set_address>: New methods.
 389         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymbol)
 390         (fixup_psymbol_section, relocate_psymtabs): Update.
 391         (print_partial_symbols): Add 'objfile' parameter.  Update.
 392         (dump_psymtab, add_psymbol_to_bcache, psym_fill_psymbol_map):
 393         Update.
 394
 395 2018-07-26  Tom Tromey  <tom@tromey.com>
 396
 397         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 398         (debug_names::write_psymbols): Update.
 399         * psympriv.h (struct partial_symbol): Derive from
 400         general_symbol_info.
 401         <obj_section>: New method.
 402         (PSYMBOL_DOMAIN, PSYMBOL_CLASS): Remove.n
 403         * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymtab)
 404         (find_pc_sect_psymbol, fixup_psymbol_section)
 405         (match_partial_symbol, lookup_partial_symbol, relocate_psymtabs)
 406         (print_partial_symbols, recursively_search_psymtabs)
 407         (compare_psymbols, psymbol_hash, psymbol_compare)
 408         (add_psymbol_to_bcache, maintenance_check_psymtabs)
 409         (psymbol_name_matches, psym_fill_psymbol_map): Update.
 410
 411 2018-07-26  Tom Tromey  <tromey@redhat.com>
 412
 413         * dbxread.c (end_psymtab): Remove dead code.
 414
 415 2018-07-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 416
 417         * dwarf2-frame-tailcall.c (tailcall_frame_sniffer): Exit early if
 418         DWARF unwinders are disabled.
 419         * dwarf2-frame.c: Add dwarf2read.h include.
 420         (dwarf2_frame_sniffer): Exit early if DWARF unwinders are
 421         disabled.
 422         (dwarf2_frame_unwinders_enabled_p): Define.
 423         (show_dwarf_unwinders_enabled_p): New function.
 424         (_initialize_dwarf2_frame): Register switch to control DWARF
 425         unwinder use.
 426         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Declare.
 427         * dwarf2read.c (set_dwarf_cmdlist): Remove static keyword.
 428         (show_dwarf_cmdlist): Remove static keyword.
 429         * dwarf2read.h (set_dwarf_cmdlist): Declare.
 430         (show_dwarf_cmdlist): Declare.
 431         * NEWS: Document new feature.
 432
 433 2018-07-26  Tom de Vries  <tdevries@suse.de>
 434
 435         PR breakpoints/23366
 436         * infcmd.c (info_program_command): Handle ptid == minus_one_ptid.
 437
 438 2018-07-26  Tom de Vries  <tdevries@suse.de>
 439
 440         * dwarf2read.c (read_subrange_type): Warn if DW_AT_upper_bound or
 441         DW_AT_count can't be translated to a dynamic prop.
 442
 443 2018-07-25  Tom de Vries  <tdevries@suse.de>
 444
 445         * dwarf2loc.c (dwarf2_locexpr_baton_eval): Wrap ctx.eval call in
 446         try/catch.
 447
 448 2018-07-25  Jan Vrany  <jan.vrany@fit.cvut.cz>
 449
 450         * breakpoint.c (enable_disable_bp_num_loc): Notify observers.
 451
 452 2018-07-25  Joel Brobecker  <brobecker@adacore.com>
 453
 454         * MAINTAINERS (Global Maintainers): Add Tom Tromey.
 455
 456 2018-07-24  Keith Seitz  <keiths@redhat.comt
 457
 458         PR symtab/23010
 459         * dwarf2read.c (dw2_add_symbol_to_list): New function.
 460         (fixup_go_packaging, new_symbol): Use dw2_add_symbol_to_list
 461         instead of add_symbol_to_list.
 462         (read_file_scope): Call prepare_one_comp_unit before reading
 463         any other DIEs.
 464
 465 2018-07-24  Simon Marchi  <simon.marchi@ericsson.com>
 466
 467         * common/scoped_mmap.h (class scoped_mmap): Fix indentation.
 468
 469 2018-07-24  Tom Tromey  <tom@tromey.com>
 470
 471         * utils.c (malloc, realloc, free): Don't declare.
 472         * configure, config.in: Rebuild.
 473         * configure.ac: Don't check for declarations of free, malloc, or
 474         realloc.
 475
 476 2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 477
 478         * aarch64-linux-nat.c
 479         (aarch64_linux_nat_target::stopped_data_address): Remove unused
 480         variable.
 481         * arm-linux-nat.c (fetch_regs): Likewise.
 482         (store_regs): Likewise.
 483         (fetch_vfp_regs): Likewise.
 484         (store_vfp_regs): Likewise.
 485         (arm_linux_nat_target::insert_hw_breakpoint): Likewise.
 486         (arm_linux_nat_target::remove_hw_breakpoint): Likewise.
 487         (arm_linux_nat_target::insert_watchpoint): Likewise.
 488         (arm_linux_nat_target::remove_watchpoint): Likewise.
 489         * mips-linux-nat.c (mips_linux_nat_target::insert_watchpoint):
 490         Likewise.
 491         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs):
 492         Likewise.
 493         * ppc-linux-nat.c (fetch_register): Likewise.
 494         (fetch_all_gp_regs): Likewise.
 495         (fetch_ppc_registers): Likewise.
 496         (store_all_gp_regs): Likewise.
 497         (store_ppc_registers): Likewise.
 498         (hwdebug_insert_point): Likewise.
 499         (can_use_watchpoint_cond_accel): Likewise.
 500         * remote-sim.c (gdb_os_write_stdout): Likewise.
 501
 502 2018-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 503             Tom Tromey  <tom@tromey.com>
 504
 505         * warning.m4 (AM_GDB_WARNINGS): Add -Wunused-variable and special
 506         test for it.
 507         * configure: Rebuild.
 508
 509 2018-07-22  Tom Tromey  <tom@tromey.com>
 510
 511         * regformats/regdat.sh: Define xmltarget_${name} inside
 512         #ifndef IN_PROCESS_AGENT.
 513
 514 2018-07-22  Tom Tromey  <tom@tromey.com>
 515
 516         * value.c (value_fetch_lazy_bitfield): Remove unused variable.
 517
 518 2018-07-22  Tom Tromey  <tom@tromey.com>
 519
 520         * symfile.c (reread_symbols): Notify iter, not objfile.
 521
 522 2018-07-22  Tom Tromey  <tom@tromey.com>
 523
 524         * ravenscar-thread.c (ravenscar_thread_target::store_registers):
 525         Use arch_ops.
 526         (ravenscar_thread_target::prepare_to_store): Likewise.
 527
 528 2018-07-22  Tom Tromey  <tom@tromey.com>
 529
 530         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Remove
 531         unused variable.  Call value_fetch_lazy when needed.
 532         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 533         Remove unused variable.  Call value_fetch_lazy when needed.
 534
 535 2018-07-22  Tom Tromey  <tom@tromey.com>
 536
 537         * m32c-tdep.c (mark_dma): Return void.
 538         (make_regs): Remove unused declarations.
 539
 540 2018-07-22  Tom Tromey  <tom@tromey.com>
 541
 542         * guile/scm-cmd.c (gdbscm_dont_repeat): Call
 543         cmdscm_get_valid_command_smob_arg_unsafe for effect.
 544         * guile/scm-block.c (gdbscm_make_block_syms_iter): Call
 545         bkscm_get_valid_block_smob_arg_unsafe for effect.
 546
 547 2018-07-22  Tom Tromey  <tom@tromey.com>
 548
 549         * bfin-tdep.c (bfin_push_dummy_call): Use arg_type, not
 550         value_type.
 551
 552 2018-07-22  Tom Tromey  <tom@tromey.com>
 553
 554         * windows-nat.c (saved_context): Conditionally define.
 555         * remote.c (remote_target::remote_btrace_maybe_reopen):
 556         Conditionally declare "warned".
 557         * inflow.c (sigquit_ours): Conditionally define.
 558         (new_tty): Move "tty" declaration inside #if.
 559         * guile/guile.c (guile_datadir): Conditionally define.
 560         * charset.c (set_be_le_names): Move some declarations inside #if.
 561         * btrace.c (parse_xml_btrace): Move "errcode" declaration inside
 562         #if.
 563         (parse_xml_btrace_conf): Likewise.
 564
 565 2018-07-22  Tom Tromey  <tom@tromey.com>
 566
 567         * spu-tdep.c (spu_get_overlay_table): Remove unused variable.
 568
 569 2018-07-22  Tom Tromey  <tom@tromey.com>
 570
 571         * guile/scm-value.c (gdbscm_value_call): Remove unused variables.
 572         * guile/scm-math.c (vlscm_unop_gdbthrow, vlscm_binop_gdbthrow)
 573         (vlscm_convert_typed_value_from_scheme): Remove unused variable.
 574         * buildsym-legacy.c (get_macro_table): Remove unused variable.
 575         * stack.c (frame_apply_level_command): Remove unused variable.
 576         * tic6x-tdep.c (tic6x_push_dummy_call): Remove unused variable.
 577         * sparc64-tdep.c (adi_examine_command): Remove unused variable.
 578         * rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call): Remove
 579         unused variable.
 580         * nios2-tdep.c (nios2_push_dummy_call): Remove unused variable.
 581         * mep-tdep.c (mep_push_dummy_call): Remove unused variable.
 582         * ada-lang.c (ada_lookup_symbol_list_worker): Remove unused
 583         variable.
 584         * amd64-tdep.c (amd64_supply_xsave): Remove unused variable.
 585         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Remove unused
 586         variable.
 587         * breakpoint.c (check_no_tracepoint_commands, update_watchpoint):
 588         Remove unused variable.
 589         * cli/cli-script.c (recurse_read_control_structure): Remove unused
 590         variable.
 591         * common/tdesc.c (print_xml_feature::visit): Remove unused
 592         variable.
 593         * compile/compile-object-load.c (store_regs): Remove unused
 594         variables.
 595         * complaints.c (clear_complaints): Remove unused variable.
 596         * corelow.c (core_target_open): Remove unused variable.
 597         * fbsd-tdep.c (fbsd_core_info_proc_status): Remove unused
 598         variable.
 599         * guile/scm-frame.c (gdbscm_frame_read_var): Remove unused
 600         variable.
 601         * guile/scm-symtab.c (stscm_print_sal_smob): Remove unused
 602         variable.
 603         * guile/scm-type.c (gdbscm_field_baseclass_p): Remove unused
 604         variable.
 605         * guile/scm-utils.c (gdbscm_parse_function_args): Remove unused
 606         variable.
 607         * hppa-tdep.c (hppa_stub_frame_unwind_cache): Remove unused
 608         variable.
 609         * ia64-tdep.c (examine_prologue): Remove unused variable.
 610         * infcall.c (run_inferior_call): Remove unused variable.
 611         * inferior.c (exit_inferior): Remove unused variable.
 612         * infrun.c (infrun_thread_ptid_changed): Remove unused variable.
 613         * linespec.c (decode_line_2): Remove unused variable.
 614         * linux-nat.c (super_close): Remove.
 615         * linux-tdep.c (linux_info_proc): Remove unused variable.
 616         * mi/mi-main.c (mi_execute_command): Remove unused variable.
 617         * microblaze-linux-tdep.c (microblaze_linux_sigtramp_cache):
 618         Remove unused variable.
 619         * parse.c (find_minsym_type_and_address): Remove unused variable.
 620         * printcmd.c (info_symbol_command, printf_floating): Remove unused
 621         variable.
 622         * python/py-breakpoint.c (bppy_set_commands): Remove unused
 623         variable.
 624         * python/py-unwind.c (unwind_infopy_dealloc): Remove unused
 625         variables.
 626         * record-btrace.c (record_btrace_target::store_registers): Remove
 627         unused variable.
 628         (cmd_show_record_btrace_cpu): Remove unused variable.
 629         * riscv-tdep.c (riscv_register_reggroup_p)
 630         (riscv_push_dummy_call, riscv_return_value): Remove unused
 631         variable.
 632         * rust-exp.y (literal): Remove unused variable.
 633         * rust-lang.c (rust_evaluate_subexp) <OP_RUST_ARARAY>: Remove
 634         unused variable.
 635         <STRUCTOP_ANONYMOUS>: Likewise.
 636         * s390-linux-tdep.c (s390_linux_init_abi_31)
 637         (s390_linux_init_abi_64): Remove unused variable.
 638         * ser-ming2.c (ser_windows_read_prim, pipe_select_thread)
 639         (file_select_thread, net_windows_open, _initialize_ser_windows):
 640         Remove unused variables.
 641         * symtab.c (find_pc_sect_line): Remove unused variable.
 642         * target-memory.c (compute_garbled_blocks): Remove unused
 643         variable.
 644         (target_write_memory_blocks): Remove unused variable.
 645         * target.c (target_stack::unpush): Remove unused variables.
 646         * tracepoint.c (start_tracing, all_tracepoint_actions)
 647         (merge_uploaded_trace_state_variables)
 648         (print_one_static_tracepoint_marker): Remove unused variable.
 649         * unittests/basic_string_view/element_access/char/1.cc (test01):
 650         Remove unused variable.
 651         * windows-nat.c (windows_continue, windows_add_all_dlls)
 652         (do_initial_windows_stuff, windows_nat_target::create_inferior):
 653         Remove unused variables.
 654
 655 2018-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
 656
 657         * arm-tdep.c (arm_gdbarch_init): Declare attr_arch and
 658         attr_profile in HAVE_ELF.
 659         * rs6000-tdep.c (bfd_uses_spe_extensions): Declare vector_abi in
 660         HAVE_ELF.
 661
 662 2018-07-20  Simon Marchi  <simon.marchi@polymtl.ca>
 663
 664         * frame.c (frame_register_unwind): Change parameter name.
 665         (frame_unwind_register): Likewise.
 666         (frame_unwind_register_value): Likewise.
 667         (frame_unwind_register_signed): Likewise.
 668         (frame_unwind_register_unsigned): Likewise.
 669         * frame.h (frame_register_unwind): Likewise.
 670         (frame_unwind_register): Likewise.
 671         (frame_unwind_register_value): Likewise.
 672         (frame_unwind_register_signed): Likewise.
 673         (frame_unwind_register_unsigned): Likewise.
 674         (frame_unwind_arch): Likewise.
 675
 676 2018-07-20  Maciej W. Rozycki  <macro@mips.com>
 677
 678         * MAINTAINERS: Update my e-mail address, downgrade to MIPS I-IV
 679         ISA maintenance.
 680
 681 2018-07-20  Maciej W. Rozycki  <macro@mips.com>
 682
 683         * mips-linux-nat.c (mips_linux_nat_target::read_description):
 684         Call `get_ptrace_pid' rather than extracting the ptrace PID by
 685         hand.
 686
 687 2018-07-20  Keith Seitz  <keiths@redhat.com>
 688
 689         * buildsym.h (struct buildsym_compunit) <m_objfile, m_subfiles,
 690         m_main_subfile, m_comp_dir, m_producer, m_debugformat,
 691         m_compunit_symtab, m_language>: Add "m_" prefix.
 692         Update all uses.
 693         * buildsym.c: Update all uses.
 694
 695 2018-07-20  Tom Tromey  <tom@tromey.com>
 696
 697         * buildsym-legacy.h (record_line): Don't use record_line_ftype.
 698         * buildsym.h (record_line_ftype): Remove typedef.
 699
 700 2018-07-20  Tom Tromey  <tom@tromey.com>
 701
 702         * buildsym-legacy.h (augment_type_symtab): Don't declare.
 703         (end_expandable_symtab): Likewise.
 704         (end_symtab_get_static_block): Likewise.
 705         (end_symtab_from_static_block): Likewise.
 706         * buildsym-legacy.c (augment_type_symtab): Remove.
 707         (end_expandable_symtab): Remove.
 708         (end_symtab_get_static_block): Remove.
 709         (end_symtab_from_static_block): Remove.
 710
 711 2018-07-20  Tom Tromey  <tom@tromey.com>
 712
 713         * dwarf2read.c: Include buildsym.h.
 714         (struct dwarf2_cu) <builder>: New method.
 715         (fixup_go_packaging): Update.
 716         (process_full_comp_unit, process_full_type_unit): Update.  Don't
 717         use scoped_free_pendings.
 718         (using_directives): Add "cu" parameter, remove "language".
 719         (read_import_statement, setup_type_unit_groups, )
 720         (read_func_scope, read_lexical_block_scope)
 721         (dwarf2_record_block_ranges, read_namespace): Update.
 722         (lnp_state_machine::lnp_state_machine): Add cu parameter.
 723         (lnp_state_machine::handle_end_sequence): Update.
 724         (class lnp_state_machine) <m_cu>: New member.
 725         <m_record_line_callback>: Remove.
 726         <m_currently_recording_lines>: New member.
 727         (lnp_state_machine::handle_set_file): Update.
 728         (noop_record_line): Remove.
 729         (dwarf_record_line_p): Add cu parameter.
 730         (dwarf_record_line_1, dwarf_finish_line): Likewise.
 731         (lnp_state_machine::record_line)
 732         (lnp_state_machine::lnp_state_machine)
 733         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
 734         (dwarf_decode_lines): Update.
 735         (dwarf2_start_subfile): Add cu parameter.
 736         (dwarf2_start_symtab, new_symbol): Update.
 737         (macro_start_file, dwarf_decode_macro_bytes): Add cu parameter.
 738         Remove dwarf2_per_objfile parameter.
 739         (dwarf_decode_macros): Update.
 740
 741 2018-07-20  Tom Tromey  <tom@tromey.com>
 742
 743         * stabsread.c (define_symbol): Update.
 744         * buildsym-legacy.h (get_buildsym_compunit): Declare.
 745         * dwarf2read.c (new_symbol): Update.
 746         * cp-support.h (cp_scan_for_anonymous_namespaces): Update.
 747         * cp-namespace.c: Include buildsym.h.
 748         (cp_scan_for_anonymous_namespaces): Add "compunit" parameter.
 749         * buildsym-legacy.c (get_buildsym_compunit): New function.
 750
 751 2018-07-20  Tom Tromey  <tom@tromey.com>
 752
 753         * xcoffread.c: Include buildsym-legacy.h.
 754         * windows-nat.c: Include buildsym-legacy.h.
 755         * stabsread.c: Include buildsym-legacy.h.
 756         * mdebugread.c: Include buildsym-legacy.h.
 757         * buildsym-legacy.h: New file.
 758         * buildsym-legacy.c: New file, from buildsym.c.
 759         * go32-nat.c: Include buildsym-legacy.h.
 760         * dwarf2read.c: Include buildsym-legacy.h.
 761         * dbxread.c: Include buildsym-legacy.h.
 762         * cp-namespace.c: Include buildsym-legacy.h.
 763         * coffread.c: Include buildsym-legacy.h.
 764         * buildsym.h: Move some contents to buildsym-legacy.h.
 765         * buildsym.c: Include buildsym-legacy.h.  Move many functions to
 766         buildsym-legacy.c.
 767         * Makefile.in (HFILES_NO_SRCDIR): Add buildsym-legacy.h.
 768
 769 2018-07-20  Tom Tromey  <tom@tromey.com>
 770
 771         * buildsym.h (struct buildsym_compunit): Move from buildsym.c.
 772         * buildsym.c (struct buildsym_compunit): Move to buildsym.h.
 773         (buildsym_compunit::buildsym_compunit)
 774         (buildsym_compunit::~buildsym_compunit)
 775         (buildsym_compunit::get_macro_table): Define.
 776
 777 2018-07-20  Tom Tromey  <tom@tromey.com>
 778
 779         * buildsym.c (reset_symtab_globals): Remove.
 780         (buildsym_compunit::end_symtab_from_static_block): Update.
 781         (buildsym_compunit::augment_type_symtab): Update.
 782         (end_symtab_from_static_block): Call free_buildsym_compunit.
 783         (augment_type_symtab, end_symtab, end_expandable_symtab):
 784         Likewise.
 785
 786 2018-07-20  Tom Tromey  <tom@tromey.com>
 787
 788         * arch-utils.c: Do not include buildsym.h.
 789         * mipsread.c: Do not include buildsym.h.
 790         * machoread.c: Do not include buildsym.h.
 791         * elfread.c: Do not include buildsym.h.
 792
 793 2018-07-20  Tom Tromey  <tom@tromey.com>
 794
 795         * buildsym.c (buildsym_compunit::buildsym_compunit): Do more
 796         initialization.
 797         (buildsym_compunit): Add new constructor.
 798         (struct buildsym_compunit) <get_last_source_file, finish_block,
 799         record_block_range, start_subfile, patch_subfile_names,
 800         push_subfile, pop_subfile, record_line, get_compunit_symtab,
 801         set_last_source_start_addr, get_last_source_start_addr,
 802         get_local_using_directives, set_local_using_directives,
 803         get_global_using_directives, outermost_context_p,
 804         get_current_context_stack, get_context_stack_depth,
 805         get_current_subfile, get_local_symbols, get_file_symbols,
 806         get_global_symbols, record_debugformat, record_producer,
 807         push_context, pop_context, end_symtab_get_static_block,
 808         end_symtab_from_static_block, end_symtab, end_expandable_symtab>:
 809         New public methods.
 810         <record_pending_block, finish_block_internal, make_blockvector,
 811         watch_main_source_file_lossage, end_symtab_with_blockvector>: New
 812         private methods.
 813         Update all users.
 814
 815 2018-05-22  Tom Tromey  <tom@tromey.com>
 816
 817         * buildsym.c (record_pending_block): Move earlier.  Remove objfile
 818         parameter.
 819         (finish_block_internal): Update.
 820
 821 2018-07-20  Tom Tromey  <tom@tromey.com>
 822
 823         * buildsym.c (record_pending_block): Move earlier.  Remove objfile
 824         parameter.
 825         (finish_block_internal): Update.
 826
 827 2018-07-20  Tom Tromey  <tom@tromey.com>
 828
 829         * buildsym.h (EXTERN): Don't define or undef.
 830         * buildsym.c (EXTERN): Don't define.
 831
 832 2018-07-20  Tom Tromey  <tom@tromey.com>
 833
 834         * buildsym.c: Remove TODO comment.
 835
 836 2018-07-20  Tom Tromey  <tom@tromey.com>
 837
 838         * coffread.c (coff_symtab_read): Update.
 839         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
 840         (xcoff_new_init): Update.
 841         * mipsread.c (mipscoff_new_init): Update.
 842         * mdebugread.c (mdebug_build_psymtabs): Update.
 843         * elfread.c (elf_new_init): Update.
 844         * dwarf2read.c (process_full_comp_unit, process_full_type_unit):
 845         Update.
 846         * dbxread.c (dbx_new_init, dbx_psymtab_to_symtab_1)
 847         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 848         (stabsect_build_psymtabs): Update.
 849         * buildsym.h (buildsym_init): Don't declare.
 850         * buildsym.c: Update comment.
 851         (prepare_for_building): Remove.
 852         (start_symtab, restart_symtab): Update.
 853         (reset_symtab_globals): Update comment.
 854         (buildsym_init): Remove.
 855
 856 2018-07-20  Tom Tromey  <tom@tromey.com>
 857
 858         * xcoffread.c (read_xcoff_symtab, process_xcoff_symbol): Update.
 859         * stabsread.c (patch_block_stabs, define_symbol, read_type)
 860         (read_enum_type, common_block_start, common_block_end)
 861         (cleanup_undefined_types_1, finish_global_stabs): Update.
 862         * mdebugread.c (psymtab_to_symtab_1): Update.
 863         * dwarf2read.c (fixup_go_packaging, read_func_scope)
 864         (read_lexical_block_scope, new_symbol): Update.
 865         * dbxread.c (process_one_symbol): Update.
 866         * coffread.c (coff_symtab_read, process_coff_symbol)
 867         (coff_read_enum_type): Update.
 868         * buildsym.h (file_symbols, global_symbols, local_symbols): Don't
 869         declare.
 870         (get_local_symbols, get_file_symbols, get_global_symbols): New
 871         functions.
 872         * buildsym.c (~buildsym_compunit): Clean up m_file_symbols and
 873         m_global_symbols.
 874         <m_file_symbols, m_local_symbols, m_global_symbols>: New members.
 875         (~scoped_free_pendings): Update.
 876         (finish_block, prepare_for_building, reset_symtab_globals)
 877         (end_symtab_get_static_block, end_symtab_with_blockvector)
 878         (augment_type_symtab, push_context): Update.
 879         (get_local_symbols, get_file_symbols, get_global_symbols): New
 880         functions.
 881         (buildsym_init): Update.
 882
 883 2018-07-20  Tom Tromey  <tom@tromey.com>
 884
 885         * dwarf2read.c (process_full_comp_unit): Do not set list_in_scope.
 886         (process_full_type_unit): Likewise.
 887         (dwarf2_start_symtab): Set list_in_scope.
 888
 889 2018-07-20  Tom Tromey  <tom@tromey.com>
 890
 891         * dwarf2read.c (process_psymtab_comp_unit_reader)
 892         (build_type_psymtabs_reader): Do not set list_in_scope.
 893
 894 2018-07-20  Tom Tromey  <tom@tromey.com>
 895
 896         * buildsym.c (free_pendings): Remove.
 897         (add_symbol_to_list, scoped_free_pendings)
 898         (finish_block_internal, buildsym_init): Update.
 899
 900 2018-07-20  Tom Tromey  <tom@tromey.com>
 901
 902         * xcoffread.c (read_xcoff_symtab): Update.
 903         * dwarf2read.c (read_func_scope, read_lexical_block_scope):
 904         Update.
 905         * dbxread.c (process_one_symbol): Update.
 906         * coffread.c (coff_symtab_read): Update.
 907         * buildsym.h (finish_block): Update.
 908         * buildsym.c (finish_block): Remove "listhead" argument.
 909         (end_symtab_get_static_block): Update.
 910
 911 2018-07-20  Tom Tromey  <tom@tromey.com>
 912
 913         * buildsym.h (class scoped_free_pendings): Remove constructor.
 914         * buildsym.c (struct buildsym_compunit) <free_pending_blocks>: New
 915         method.
 916         <m_pending_block_obstack, m_pending_blocks>: New members.
 917         (pending_block_obstack, pending_blocks): Remove.
 918         (scoped_free_pendings::scoped_free_pendings): Default.
 919         (~scoped_free_pendings): Update.
 920         (free_pending_blocks): Remove.
 921         (finish_block_internal, record_pending_block, make_blockvector)
 922         (end_symtab_get_static_block, augment_type_symtab, push_context)
 923         (buildsym_init): Update.
 924
 925 2018-07-20  Tom Tromey  <tom@tromey.com>
 926
 927         * buildsym.c (struct buildsym_compunit) <m_pending_addrmap,
 928         m_pending_addrmap_obstack, m_pending_addrmap_interesting>: New
 929         members.
 930         (pending_addrmap, pending_addrmap_obstack)
 931         (pending_addrmap_interesting): Remove.
 932         (scoped_free_pendings, record_block_range, make_blockvector)
 933         (prepare_for_building, reset_symtab_globals, buildsym_init):
 934         Update.
 935
 936 2018-07-20  Tom Tromey  <tom@tromey.com>
 937
 938         * xcoffread.c (process_linenos): Update.
 939         * stabsread.c (define_symbol, read_type, read_enum_type): Update.
 940         * mdebugread.c (psymtab_to_symtab_1): Update.
 941         * dwarf2read.c (setup_type_unit_groups)
 942         (lnp_state_machine::handle_set_file, dwarf_record_line_p)
 943         (lnp_state_machine::record_line, dwarf_decode_lines): Update.
 944         * dbxread.c (process_one_symbol): Update.
 945         * coffread.c (coff_symtab_read, enter_linenos)
 946         (process_coff_symbol): Update.
 947         * buildsym.h (current_subfile): Don't declare.
 948         (get_current_subfile): Declare.
 949         * buildsym.c (struct buildsym_compunit) <m_current_subfile>: New
 950         member.
 951         (start_subfile, free_buildsym_compunit, push_subfile)
 952         (prepare_for_building, start_symtab): Update.
 953         (get_current_subfile): New function.
 954
 955 2018-07-20  Tom Tromey  <tom@tromey.com>
 956
 957         * coffread.c (coff_symtab_read): Update.
 958         * xcoffread.c (read_xcoff_symtab): Update.
 959         * dwarf2read.c (new_symbol): Update.
 960         (read_func_scope, read_lexical_block_scope): Update.
 961         * dbxread.c (process_one_symbol): Update.
 962         * buildsym.h (context_stack, context_stack_depth): Don't declare.
 963         (outermost_context_p): Remove macro.
 964         (outermost_context_p, get_current_context_stack)
 965         (get_context_stack_depth): Declare.
 966         (pop_context): Return struct context_stack.
 967         * buildsym.c (struct buildsym_compunit) <m_context_stack: New
 968         member.
 969         (context_stack_size): Remove.
 970         (INITIAL_CONTEXT_STACK_SIZE): Remove.
 971         (prepare_for_building, end_symtab_get_static_block)
 972         (augment_type_symtab, push_context): Update.
 973         (pop_context): Return struct context_stack.
 974         (outermost_context_p, get_current_context_stack)
 975         (get_context_stack_depth): New functions.
 976         (buildsym_init): Update.
 977
 978 2018-07-20  Tom Tromey  <tom@tromey.com>
 979
 980         * rust-exp.y: Now a pure parser.  Update all rules.
 981         (%union): Move earlier.
 982         (current_parser, work_obstack): Remove globals.
 983         (rust_parser, ~rust_parser): Update.
 984         (class rust_parser) <copy_name, concat3, crate_name, super_name,
 985         lex_character, lex_number, lex_string, lex_identifier,
 986         rust_lookup_type, convert_params_to_types, convert_ast_to_type,
 987         convert_name, convert_params_to_expression,
 988         convert_ast_to_expression, ast_basic_type, ast_operation,
 989         ast_compound_assignment, rust_op, ast_literal, ast_dliteral,
 990         ast_structop, ast_structop_anonymous, ast_unary, ast_cast,
 991         ast_call_ish, ast_path, ast_string, ast_struct, ast_range,
 992         ast_array_type, ast_slice_type, ast_reference_type,
 993         ast_pointer_type, ast_function_type, ast_tuple_type>: New methods.
 994         (rust_parse): Update.
 995         (rustyyerror, rustyylex): Add parser parameter.
 996         (rust_lex_test_one, rust_lex_int_test, rust_lex_exception_test)
 997         (rust_lex_stringish_test, rust_lex_test_sequence)
 998         (rust_lex_test_trailing_dot, rust_lex_test_completion)
 999         (rust_lex_test_push_back, rust_lex_tests): Update.
1000
1001 2018-07-19  Pedro Alves  <palves@redhat.com>
1002
1003         * guile/guile-internal.h (gdbscm_scm_to_c_string): Now returns a
1004         gdb::unique_xmalloc_ptr.
1005         * guile/scm-breakpoint.c (gdbscm_set_breakpoint_condition_x):
1006         Adjust to use dbscm_wrap and gdb::unique_xmalloc_ptr.
1007         * guile/scm-exception.c (gdbscm_exception_message_to_string): Use
1008         copy-initialization.
1009         * guile/scm-pretty-print.c (ppscm_print_children): Use
1010         gdb::unique_xmalloc_ptr instead of cleanups.
1011         (gdbscm_apply_val_pretty_printer): Remove cleanups.
1012         * guile/scm-string.c (gdbscm_scm_to_c_string): Now returns a
1013         gdb::unique_xmalloc_ptr.
1014         * guile/scm-type.c (gdbscm_type_field, gdbscm_type_has_field_p):
1015         Adjust to use gdb::unique_xmalloc_ptr.
1016         * guile/scm-utils.c (extract_arg): Adjust.
1017         * guile/scm-value.c (gdbscm_value_field): Adjust to use
1018         gdb::unique_xmalloc_ptr instead of a cleanup.
1019
1020 2018-07-19  Tom Tromey  <tom@tromey.com>
1021
1022         * utils.c (do_value_free_to_mark)
1023         (make_cleanup_value_free_to_mark): Remove.
1024         * utils.h (make_cleanup_value_free_to_mark): Remove.
1025
1026 2018-07-19  Pedro Alves  <palves@redhat.com>
1027
1028         * guile/guile-internal.h (gdbscm_wrap): Really make 'args' a
1029         forwarding reference.
1030
1031 2018-07-18  Pedro Alves  <palves@redhat.com>
1032
1033         * guile/guile.c (gdbscm_execute_gdb_command): Adjust to use
1034         gdbscm_wrap.  Use gdb::unique_xmalloc_ptr<char> instead of a
1035         cleanup.
1036
1037 2018-07-18  Pedro Alves  <palves@redhat.com>
1038
1039         * guile/guile-internal.h: Add comment about mixing GDB and Scheme
1040         exceptions.
1041         (GDBSCM_HANDLE_GDB_EXCEPTION_WITH_CLEANUPS): Delete.
1042         (gdbscm_wrap): New.
1043         * guile/scm-frame.c (gdbscm_frame_read_register): Use xfree
1044         directly instead of a cleanup.
1045         * guile/scm-math.c (vlscm_unop_gdbthrow): New, factored out from ...
1046         (vlscm_unop): ... this.  Reimplement using gdbscm_wrap.
1047         (vlscm_binop_gdbthrow): New, factored out from ...
1048         (vlscm_binop): ... this.  Reimplement using gdbscm_wrap.
1049         (vlscm_rich_compare): Use gdbscm_wrap.
1050         * guile/scm-symbol.c (gdbscm_lookup_symbol): Use xfree directly
1051         instead of a cleanup.
1052         (gdbscm_lookup_global_symbol): Use xfree directly instead of a
1053         cleanup.
1054         * guile/scm-type.c (gdbscm_type_field, gdbscm_type_has_field_p):
1055         Use xfree directly instead of a cleanup.
1056         * guile/scm-value.c (gdbscm_make_value, gdbscm_make_lazy_value):
1057         Adjust to use gdbscm_wrap and scoped_value_mark.
1058         (gdbscm_value_optimized_out_p): Adjust to use gdbscm_wrap.
1059         (gdbscm_value_address, gdbscm_value_dereference)
1060         (gdbscm_value_referenced_value): Adjust to use gdbscm_wrap and
1061         scoped_value_mark.
1062         (gdbscm_value_dynamic_type): Use scoped_value_mark.
1063         (vlscm_do_cast, gdbscm_value_field): Adjust to use gdbscm_wrap and
1064         scoped_value_mark.
1065         (gdbscm_value_subscript, gdbscm_value_call): Adjust to use
1066         gdbscm_wrap and scoped_value_mark.
1067         (gdbscm_value_to_string): Use xfree directly instead of a
1068         cleanup.  Move 'buffer' unique_ptr to TRY scope.
1069         (gdbscm_value_to_lazy_string): Use xfree directly instead of a
1070         cleanup.  Move 'buffer' unique_ptr to TRY scope.  Use
1071         scoped_value_mark.
1072         (gdbscm_value_fetch_lazy_x): Use gdbscm_wrap.
1073         (gdbscm_parse_and_eval): Adjust to use gdbscm_wrap and
1074         scoped_value_mark.
1075         (gdbscm_history_ref, gdbscm_history_append_x): Adjust to use
1076         gdbscm_wrap.
1077
1078 2018-07-18  Tom de Vries  <tdevries@suse.de>
1079
1080         * findvar.c (default_read_var_value): Also resolve dynamic type for
1081         LOC_OPTIMIZED_OUT vars.
1082
1083 2018-07-18  Maciej W. Rozycki  <macro@mips.com>
1084
1085         * mips-tdep.c (micromips_next_pc): Add SYSCALL instruction
1086         decoding.
1087
1088 2018-07-17  Tom Tromey  <tom@tromey.com>
1089
1090         * guile/scm-param.c (pascm_set_func, pascm_show_func)
1091         (compute_enum_list, pascm_set_param_value_x)
1092         (gdbscm_parameter_value): Update.
1093         * guile/guile-internal.h (gdbscm_scm_to_string): Update.
1094         (gdbscm_scm_to_host_string): Update.
1095         * guile/scm-math.c (vlscm_convert_typed_value_from_scheme):
1096         Update.
1097         * guile/scm-cmd.c (cmdscm_add_completion): Update.
1098         * guile/scm-pretty-print.c (ppscm_print_string_repr): Update.
1099         * guile/scm-string.c (gdbscm_scm_to_string): Return
1100         unique_xmalloc_ptr.
1101         (gdbscm_scm_to_host_string): Likewise.
1102
1103 2018-07-17  Tom Tromey  <tom@tromey.com>
1104
1105         * guile/guile.c (gdbscm_eval_from_control_command): Update.
1106         * guile/guile-internal.h (gdbscm_safe_eval_string): Update.
1107         * guile/scm-objfile.c (gdbscm_execute_objfile_script): Update.
1108         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Return
1109         unique_xmalloc_ptr.
1110
1111 2018-07-17  Tom Tromey  <tom@tromey.com>
1112
1113         * guile/scm-param.c (pascm_signal_setshow_error): Update.
1114         * guile/guile-internal.h (gdbscm_exception_message_to_string):
1115         Update.
1116         * guile/scm-cmd.c (cmdscm_function): Update.
1117         * guile/scm-pretty-print.c
1118         (ppscm_print_exception_unless_memory_error): Update.
1119         * guile/scm-exception.c (gdbscm_exception_message_to_string):
1120         Return unique_xmalloc_ptr.
1121
1122 2018-07-17  Tom Tromey  <tom@tromey.com>
1123
1124         * guile/scm-pretty-print.c (ppscm_make_pp_type_error_exception):
1125         Use string_printf.
1126
1127 2018-07-17  Jim Wilson  <jimw@sifive.com>
1128
1129         * riscv-tdep.c (riscv_has_feature): Delete comment that refers to
1130         set_gdbarch_decr_pc_after_break.  Call riscv_read_misa_reg always.
1131         (riscv_gdbarch_init): Delete local has_compressed_isa.  Delete now
1132         unecessary braces after EF_RISCV_RVC test.  Delete call to
1133         set_gdbarch_decr_pc_after_break.
1134
1135         * riscv-tdep.h (DECLARE_CSR): Use RISCV_FIRST_CSR_REGNUM instead of
1136         RISCV_LAST_FP_REGNUM + 1.
1137         (RSICV_CSR_LEGACY_MISA_REGNUM): Add RISCV_FIRST_CSR_REGNUM.
1138
1139 2018-07-17  Tom Tromey  <tom@tromey.com>
1140
1141         * configure.ac: Remove --disable-gdbcli.
1142         * configure: Rebuild.
1143         * Makefile.in (SUBDIR_CLI_DEPS, SUBDIR_CLI_LDFLAGS)
1144         (SUBDIR_CLI_CFLAGS): Remove.
1145         (SFILES): Use SUBDIR_CLI_SRCS.
1146         (COMMON_OBS): Use SUBDIR_CLI_OBS.
1147
1148 2018-07-17  Tom Tromey  <tom@tromey.com>
1149
1150         PR gdb/18624:
1151         * coffread.c (coff_symtab_read): Use scoped_free_pendings.
1152
1153 2018-07-16  Jim Wilson  <jimw@sifive.com>
1154
1155         * riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi.
1156
1157 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
1158
1159         * ia64-libunwind-tdep.c (libunwind_frame_cache): Remove unused
1160         variable.
1161         (libunwind_frame_sniffer): Likewise.
1162         (libunwind_frame_prev_register): Likewise.
1163         (libunwind_sigtramp_frame_sniffer): Likewise.
1164         * ia64-tdep.c (ia64_access_reg): Likewise.
1165         (ia64_access_rse_reg): Likewise.
1166         (ia64_libunwind_sigtramp_frame_this_id): Likewise.
1167         * ia64-vms-tdep.c (ia64_vms_find_proc_info_x): Likewise.
1168
1169 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
1170
1171         * ia64-vms-tdep.c (ia64_vms_find_proc_info_x): Add cast.
1172
1173 2018-07-16  Simon Marchi  <simon.marchi@ericsson.com>
1174
1175         * remote-sim.c (gdbsim_target::close,
1176         gdbsim_target::mourn_inferior): Remove unused variables.
1177
1178 2018-07-16  Simon Marchi  <simon.marchi@polymtl.ca>
1179
1180         * ia64-tdep.c (ktab_buf): New global.
1181         (getunwind_table): Return a gdb::optional<gdb::byte_vector>.
1182         (get_kernel_table): Adjust.
1183
1184 2018-07-16  Tom Tromey  <tom@tromey.com>
1185
1186         * xcoffread.c (read_xcoff_symtab): Use outermost_context_p.
1187         * dwarf2read.c (using_directives, new_symbol): Use
1188         outermost_context_p.
1189         * dbxread.c (process_one_symbol): Use outermost_context_p.
1190         * coffread.c (coff_symtab_read): Use outermost_context_p.
1191
1192 2018-07-16  Tom Tromey  <tom@tromey.com>
1193
1194         * dwarf2read.c (using_directives, read_func_scope)
1195         (read_lexical_block_scope): Update.
1196         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1197         * buildsym.h (local_using_directives, global_using_directives):
1198         Don't declare.
1199         (get_local_using_directives, set_local_using_directives)
1200         (get_global_using_directives): Declare.
1201         * buildsym.c (struct buildsym_compunit) <m_local_using_directives,
1202         m_global_using_directives>: New members.
1203         (finish_block_internal, prepare_for_building)
1204         (reset_symtab_globals, end_symtab_get_static_block)
1205         (push_context): Update.
1206         (get_local_using_directives, set_local_using_directives)
1207         (get_global_using_directives): New functions.
1208         (buildsym_init): Update.
1209
1210 2018-07-16  Tom Tromey  <tom@tromey.com>
1211
1212         * xcoffread.c (xcoff_initial_scan): Don't call
1213         free_pending_blocks.
1214         * dbxread.c (dbx_symfile_read): Don't call free_pending_blocks.
1215         * buildsym.h (class scoped_free_pendings): Add constructor.
1216         (free_pending_blocks): Don't declare.
1217         * buildsym.c (scoped_free_pendings::scoped_free_pendings): New.
1218         (free_pending_blocks): Now static.
1219
1220 2018-07-16  Tom Tromey  <tom@tromey.com>
1221
1222         * buildsym.h (push_subfile, pop_subfile): Update declarations.
1223         * buildsym.c (struct buildsym_compunit) <m_subfile_stack>: New
1224         member.
1225         (struct subfile_stack): Remove.
1226         (subfile_stack): Remove.
1227         (push_subfile, pop_subfile, buildsym_init): Update.
1228
1229 2018-07-16  Tom Tromey  <tom@tromey.com>
1230
1231         * buildsym.c (push_subfile): Use gdb_assert.
1232         (pop_subfile): Use gdb_assert.
1233
1234 2018-07-16  Tom Tromey  <tom@tromey.com>
1235
1236         * buildsym.h (merge_symbol_lists): Remove.
1237         * buildsym.c (merge_symbol_lists): Remove.
1238
1239 2018-07-16  Tom Tromey  <tom@tromey.com>
1240
1241         * stabsread.c (scan_file_globals): Update comment.
1242         * stabsread.h (scan_file_globals): Move from buildsym.h.
1243         * buildsym.h (scan_file_globals): Move to stabsread.h.
1244
1245 2018-07-16  Tom Tromey  <tom@tromey.com>
1246
1247         * xcoffread.c (xcoff_new_init): Update.
1248         * mipsread.c (mipscoff_new_init): Update.
1249         * mdebugread.c (mdebug_build_psymtabs): Update.
1250         * elfread.c (elf_new_init): Update.
1251         * dbxread.c (dbx_new_init, coffstab_build_psymtabs)
1252         (elfstab_build_psymtabs, stabsect_build_psymtabs): Update.
1253         * buildsym.h (buildsym_new_init): Don't declare.
1254         * buildsym.c (buildsym_new_init): Remove.
1255
1256 2018-07-16  Tom Tromey  <tom@tromey.com>
1257
1258         * stabsread.h (within_function): Move from buildsym.h.
1259         * stabsread.c (start_stabs): Clear within_function.
1260         * coffread.c (coff_start_symtab): Clear within_function.
1261         * buildsym.h (within_function): Move to stabsread.h.
1262         * buildsym.c (prepare_for_building): Update.
1263
1264 2018-07-16  Tom Tromey  <tom@tromey.com>
1265
1266         * stabsread.h (processing_gcc_compilation): Move from buildsym.h.
1267         * dwarf2read.c (dwarf2_start_symtab): Don't set
1268         processing_gcc_compilation.
1269         * buildsym.h (processing_gcc_compilation): Move to stabsread.h.
1270
1271 2018-07-16  Tom Tromey  <tom@tromey.com>
1272
1273         * stabsread.h (HASHSIZE, hashname, symnum, next_symbol_text)
1274         (next_symbol_text_func): Move from buildsym.h.
1275         * stabsread.c (hashname): Move from buildsym.c.
1276         * buildsym.h (HASHSIZE, symnum, next_symbol_text)
1277         (next_symbol_text_func, hashname): Move to stabsread.h.
1278         * buildsym.c: Don't include bcache.h
1279         (hashname): Move to stasbread.c.
1280
1281 2018-07-16  Tom Tromey  <tom@tromey.com>
1282
1283         * buildsym.h (context_stack_size): Don't declare.
1284         * buildsym.c (context_stack_size): New global.
1285
1286 2018-07-16  Tom Tromey  <tom@tromey.com>
1287
1288         * dbxread.c (processing_acc_compilation): New global.
1289         * buildsym.h (processing_acc_compilation): Don't declare.
1290
1291 2018-07-16  Tom Tromey  <tom@tromey.com>
1292
1293         * xcoffread.c (aix_process_linenos, complete_symtab): Update.
1294         * dbxread.c (read_ofile_symtab): Update.
1295         * coffread.c (coff_start_symtab, coff_end_symtab): Update.
1296         * buildsym.h (last_source_start_addr): Remove.
1297         (set_last_source_start_addr, get_last_source_start_addr):
1298         Declare.
1299         * buildsym.c (buildsym_compunit::buildsym_compunit): Add last_addr
1300         parameter.
1301         (struct buildsym_compunit) <m_last_source_start_addr>: New
1302         member.
1303         (prepare_for_building): Remove start_addr parameter.
1304         (start_symtab, restart_symtab, end_symtab_get_static_block)
1305         (end_symtab_with_blockvector): Update.
1306         (set_last_source_start_addr, get_last_source_start_addr): New
1307         functions.
1308
1309 2018-07-16  Tom Tromey  <tom@tromey.com>
1310
1311         * buildsym.c (struct buildsym_compunit) <m_have_line_numbers>: New
1312         member.
1313         (have_line_numbers): Remove.
1314         (record_line, prepare_for_building, end_symtab_get_static_block)
1315         (augment_type_symtab): Update.
1316
1317 2018-07-16  Tom Tromey  <tom@tromey.com>
1318
1319         * buildsym.c (~buildsym_compunit): Free the macro table.
1320         (struct buildsym_compunit) <get_macro_table, release_macros>: New
1321         methods.
1322         <m_pending_macros>: New member.
1323         (pending_macros): Remove.
1324         (~scoped_free_pendings, get_macro_table, prepare_for_building)
1325         (reset_symtab_globals, end_symtab_get_static_block)
1326         (end_symtab_with_blockvector, augment_type_symtab)
1327         (buildsym_init): Update.
1328
1329 2018-07-16  Tom Tromey  <tom@tromey.com>
1330
1331         * buildsym.c (buildsym_compunit::buildsym_compunit): Add name
1332         parameter.
1333         (buildsym_compunit::set_last_source_file): New method.
1334         <m_last_source_file>: New member.
1335         (prepare_for_building): Remove "name" parameter.
1336         (start_symtab, restart_symtab, reset_symtab_globals): Update.
1337         (last_source_file): Remove.
1338         (set_last_source_file, get_last_source_file): Update.
1339
1340 2018-07-16  Tom Tromey  <tom@tromey.com>
1341
1342         * buildsym.c (prepare_for_building): Add assert.
1343
1344 2018-07-16  Tom Tromey  <tom@tromey.com>
1345
1346         * buildsym.c (~buildsym_compunit): Update.
1347         (struct buildsym_compunit) <comp_unit>: Now a unique_xmalloc_ptr.
1348         (start_subfile, patch_subfile_names)
1349         (end_symtab_with_blockvector): Update.
1350
1351 2018-07-16  Tom Tromey  <tom@tromey.com>
1352
1353         * buildsym.c (struct buildsym_compunit): Add constructor,
1354         destructor, initializers.
1355         (start_buildsym_compunit): Remove.
1356         (free_buildsym_compunit): Use "delete".
1357         (start_symtab, restart_symtab): Use "new".
1358
1359 2018-07-13  Simon Marchi  <simon.marchi@polymtl.ca>
1360
1361         * symfile.c (set_objfile_default_section_offset): Remove struct
1362         keyword.
1363
1364 2018-07-14  Stafford Horne  <shorne@gmail.com>
1365
1366         * (Responsible Maintainers): Add myself as or1k maintainer.
1367
1368 2018-07-13  Tom Tromey  <tom@tromey.com>
1369
1370         * symfile.c (set_objfile_default_section_offset): Use extra braces
1371         around initializer.
1372
1373 2018-07-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
1374
1375         * s390-tdep.c (s390_displaced_step_fixup): Adjust PC for a
1376         non-branching basr.
1377
1378 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1379
1380         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1381         unittests/cli-utils-selftests.c
1382         * unittests/cli-utils-selftests.c: New file.
1383
1384 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1385
1386         * NEWS: Mention new commands. Mention change to 'thread apply'.
1387
1388 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1389
1390         * thread.c (thr_try_catch_cmd): New function.
1391         (thread_apply_all_command): Handle qcs flags.
1392         (thread_apply_command): Handle qcs flags.
1393         (taas_command): New function.
1394         (tfaas_command): New function.
1395         (_initialize_thread): Update to setup the new commands 'taas
1396         and 'tfaas'. Change doc string for 'thread apply'.
1397
1398 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1399
1400         * stack.c: (trailing_outermost_frame): New function, mostly
1401         extracted from backtrace_command_1.
1402         (leading_innermost_frame): New function.
1403         (backtrace_command_1): Update to call trailing_outermost_frame.
1404         (frame_apply_command_count): New function.
1405         (frame_apply_level_command): New function.
1406         (frame_apply_all_command): New function.
1407         (frame_apply_command): New function.
1408         (faas_command): New function.
1409         (frame_cmd_list): New variable.
1410         (_initialize_stack): Update to setup the new commands 'frame apply'
1411         and 'faas'.
1412
1413 2018-07-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1414
1415         * cli-utils.c (number_or_range_parser::get_number): Only handle
1416         numbers or convenience var as numbers.
1417         (parse_flags): New function.
1418         (parse_flags_qcs): New function.
1419         (number_or_range_parser::finished): Ensure parsing end is detected
1420         before end of string.
1421         * cli-utils.h (parse_flags): New function.
1422         (parse_flags_qcs): New function.
1423         (number_or_range_parser): Remove m_finished bool.
1424         (number_or_range_parser::skip_range): Set m_in_range to false.
1425
1426 2018-07-12  Sergio Durigan Junior  <sergiodj@redhat.com>
1427
1428         * ser-tcp.c (try_connect): Declare 'ioarg' as 'u_long' if building
1429         on Windows.
1430
1431 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
1432             Jan Kratochvil  <jan.kratochvil@redhat.com>
1433             Paul Fertser  <fercerpav@gmail.com>
1434             Tsutomu Seki  <sekiriki@gmail.com>
1435             Pedro Alves  <palves@redhat.com>
1436
1437         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1438         'unittests/parse-connection-spec-selftests.c'.
1439         (COMMON_SFILES): Add 'common/netstuff.c'.
1440         (HFILES_NO_SRCDIR): Add 'common/netstuff.h'.
1441         * NEWS (Changes since GDB 8.2): Mention IPv6 support.
1442         * common/netstuff.c: New file.
1443         * common/netstuff.h: New file.
1444         * ser-tcp.c: Include 'netstuff.h' and 'wspiapi.h'.
1445         (wait_for_connect): Update comment.  New parameter
1446         'gdb::optional<int> sock' instead of 'struct serial *scb'.
1447         Use 'sock' directly instead of 'scb->fd'.
1448         (try_connect): New function, with code from 'net_open'.
1449         (net_open): Rewrite main loop to deal with multiple
1450         sockets/addresses.  Handle IPv6-style hostnames; implement
1451         support for IPv6 connections.
1452         * unittests/parse-connection-spec-selftests.c: New file.
1453
1454 2018-07-11  Pedro Alves  <palves@redhat.com>
1455
1456         PR gdb/23377
1457         * remote.c (remote_target::remote_detach_pid): Call
1458         set_current_process.
1459
1460 2018-07-11  Pedro Alves  <palves@redhat.com>
1461
1462         * h8300-tdep.c (h8300_gdbarch_init): Remove
1463         set_gdbarch_ecoff_reg_to_regnum calls.
1464
1465 2018-07-11  Sergio Durigan Junior  <sergiodj@redhat.com>
1466
1467         PR c++/23373
1468         * c-typeprint.c (c_type_print_base_struct_union): Don't print
1469         offsets/sizes for static members of a class/struct.
1470
1471 2018-07-11  Alan Hayward  <alan.hayward@arm.com>
1472
1473         * target-descriptions.c (tdesc_register_bitsize): Rename.
1474         * target-descriptions.h (tdesc_register_bitsize): Likewise.
1475         * rs6000-tdep.c (rs6000_gdbarch_init): Use new name.
1476         * aarch64-tdep.c (aarch64_get_tdesc_vq): Convert size.
1477
1478 2018-07-10  Tom Tromey  <tom@tromey.com>
1479
1480         * breakpoint.c (moribund_locations): Now static and a
1481         std::vector.
1482         (breakpoint_init_inferior, moribund_breakpoint_here_p)
1483         (build_bpstat_chain, update_global_location_list)
1484         (breakpoint_retire_moribund): Update.
1485         * breakpoint.h (bp_location_p): Remove typedef.  Don't declare
1486         VEC.
1487
1488 2018-07-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1489
1490         * riscv-tdep.c (riscv_is_fp_regno_p): New function.
1491         (riscv_register_reggroup_p): Use new function, remove unneeded
1492         parenthesis.
1493         (riscv_push_dummy_call): Extend assert to compare against xlen or
1494         flen based on register type.
1495
1496 2018-07-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * riscv-tdep.c (riscv_print_arg_location): Use TYPE_SAFE_NAME.
1499
1500 2018-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1501
1502         * remote.c (show_hardware_watchpoint_limit): New function.
1503         (show_hardware_watchpoint_length_limit): New function.
1504         (show_hardware_breakpoint_limit): New function.
1505         (_initialize_remote): Use add_setshow_zuinteger_unlimited_cmd
1506         where appropriate, update help text.
1507
1508 2018-07-09  Tom Tromey  <tom@tromey.com>
1509
1510         * Makefile.in (CDEPS): Don't mention XM_CDEPS.
1511         (CLIBS): Don't mention NAT_CLIBS.
1512
1513 2018-07-09  Tom Tromey  <tom@tromey.com>
1514
1515         * Makefile.in (ADD_FILES, ADD_DEPS): Remove.
1516         (LIBGDB_OBS, clean mostlyclean): Update.
1517         (gdb$(EXEEXT), insight$(EXEEXT)): Update.
1518
1519 2018-07-09  Tom Tromey  <tom@tromey.com>
1520
1521         * Makefile.in (%.c: %.y): Use ECHO_YACC.
1522         (%.c: %.l): Use ECHO_LEX.  Just fail if flex not available.
1523         * silent-rules.mk (ECHO_YACC, ECHO_LEX): New variables.
1524
1525 2018-07-09  Tom Tromey  <tom@tromey.com>
1526
1527         * Makefile.in (ALLDEPFILES): Remove exec.c.
1528         (COMMON_OBS): Remove exec.o.
1529         (COMMON_SFILES): Add exec.c.
1530
1531 2018-07-09  Tom Tromey  <tom@tromey.com>
1532
1533         * Makefile.in (LINT, LINTFLAGS, LINTFILES, lint): Remove.
1534
1535 2018-07-09  Tom Tromey  <tom@tromey.com>
1536
1537         * Makefile.in (clean mostlyclean): Remove stamp-version.
1538         (version.c): Depend on stamp-version.
1539         (stamp-version): New rule, from version.c rule.
1540
1541 2018-07-09  Tom Tromey  <tom@tromey.com>
1542
1543         * Makefile.in (init.c): Depend on stamp-init.
1544         (stamp-init): New rule, from init.c rule.
1545         (clean mostlyclean): Remove stamp-init.
1546
1547 2018-07-09  Tom Tromey  <tom@tromey.com>
1548
1549         * Makefile.in (INIT_FILES): Remove CONFIG_SRCS,
1550         SUBDIR_GCC_COMPILE_SRCS.
1551
1552 2018-07-09  Tom Tromey  <tom@tromey.com>
1553
1554         * Makefile.in (init.c): Remove some unused sed rules.
1555
1556 2018-07-09  Tom Tromey  <tom@tromey.com>
1557
1558         * Makefile.in (TSOBS): Remove.
1559         (INIT_FILES): Update.
1560         (LIBGDB_OBS): Update.
1561         (COMMON_SFILES): Add inflow.c.
1562         (SFILES): Remove inflow.c.
1563
1564 2018-07-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
1565
1566         * contrib/gdb-add-index.sh ($dwarf5): New, use it.
1567
1568 2018-07-07  Simon Marchi  <simon.marchi@polymtl.ca>
1569
1570         * ia64-libunwind-tdep.c (get_reg_name, get_fpreg_name,
1571         get_saveloc_name, is_signal_frame_name, step_name,
1572         init_remote_name, create_addr_space_name,
1573         destroy_addr_space_name, search_unwind_table_name,
1574         find_dyn_list_name): Constify.
1575
1576 2018-07-05  Simon Marchi  <simon.marchi@polymtl.ca>
1577
1578         * darwin-nat.c (darwin_pthread_kill): New function.
1579         (darwin_resume_thread): Use darwin_pthread_kill.
1580
1581 2018-07-05  Tom de Vries  <tdevries@suse.de>
1582
1583         * macroexp.c (macro_buffer) <operator=>: New member function.
1584
1585 2018-07-04  Tom Tromey  <tom@tromey.com>
1586
1587         * darwin-nat.c (darwin_attach_pid): Use exit_inferior.
1588
1589 2018-07-04  Simon Marchi  <simon.marchi@polymtl.ca>
1590
1591         * common/common-defs.h (HAVE_USEFUL_SBRK): Define.
1592         * main.c: Use HAVE_USEFUL_SBRK instead of HAVE_SBRK.
1593         * maint.c: Likewise.
1594         * top.c: Likewise.
1595
1596 2018-07-04  Joel Brobecker  <brobecker@adacore.com>
1597
1598         * NEWS: Create a new section for the next release branch.
1599         Rename the section of the current branch, now that it has
1600         been cut.
1601
1602 2018-07-04  Joel Brobecker  <brobecker@adacore.com>
1603
1604         GDB 8.2 branch created (1b919490e8ba30bf1d6941df0ed112b0e557017e):
1605         * version.in: Bump version to 8.2.50.DATE-git.
1606
1607 2018-07-04  Vyacheslav Barinov  <v.barinov@samsung.com>
1608             Pedro Alves  <palves@redhat.com>
1609
1610         * linux-nat.c (linux_init_ptrace): Rename to ...
1611         (linux_init_ptrace_procfs): ... this.  Call
1612         linux_proc_init_warnings.
1613         (linux_nat_target::post_attach)
1614         (linux_nat_target::post_startup_inferior): Adjust.
1615         * nat/linux-procfs.c (linux_proc_init_warnings): Define function.
1616         * nat/linux-procfs.h (linux_proc_init_warnings): Declare function.
1617
1618 2018-07-04  Tom de Vries  <tdevries@suse.de>
1619
1620         * dwarf2read.c (error_check_comp_unit_head): Move dwarf version
1621         check ...
1622         (read_comp_unit_head): ... here.
1623
1624 2018-07-03  Tom Tromey  <tom@tromey.com>
1625
1626         * tracepoint.c (process_tracepoint_on_disconnect, start_tracing)
1627         (stop_tracing, tstatus_command)
1628         (find_matching_tracepoint_location, merge_uploaded_tracepoints)
1629         (print_one_static_tracepoint_marker): Update.
1630         * breakpoint.c (static_tracepoints_here, all_tracepoints): Return
1631         std::vector.
1632         * breakpoint.h (breakpoint_p): Remove typedef.  Don't declare
1633         VEC.
1634         (all_tracepoints, static_tracepoints_here): Return std::vector.
1635
1636 2018-07-03  Tom Tromey  <tom@tromey.com>
1637
1638         * common/ptid.c (ptid_equal): Remove.
1639         * common/ptid.h (ptid_equal): Don't declare.
1640         * ada-tasks.c: Update.
1641         * breakpoint.c: Update.
1642         * common/agent.c: Update.
1643         * corelow.c: Update.
1644         * darwin-nat-info.c: Update.
1645         * darwin-nat.c: Update.
1646         * dcache.c: Update.
1647         * dtrace-probe.c: Update.
1648         * dummy-frame.c: Update.
1649         * fbsd-nat.c: Update.
1650         * frame.c: Update.
1651         * gdbthread.h: Update.
1652         * gnu-nat.c: Update.
1653         * go32-nat.c: Update.
1654         * inf-loop.c: Update.
1655         * inf-ptrace.c: Update.
1656         * infcall.c: Update.
1657         * infcmd.c: Update.
1658         * inflow.c: Update.
1659         * infrun.c: Update.
1660         * linux-fork.c: Update.
1661         * linux-nat.c: Update.
1662         * linux-thread-db.c: Update.
1663         * mi/mi-cmd-var.c: Update.
1664         * mi/mi-interp.c: Update.
1665         * mi/mi-main.c: Update.
1666         * nto-procfs.c: Update.
1667         * ppc-linux-tdep.c: Update.
1668         * procfs.c: Update.
1669         * python/py-inferior.c: Update.
1670         * python/py-record-btrace.c: Update.
1671         * python/py-record.c: Update.
1672         * ravenscar-thread.c: Update.
1673         * regcache.c: Update.
1674         * remote-sim.c: Update.
1675         * remote.c: Update.
1676         * sol-thread.c: Update.
1677         * solib.c: Update.
1678         * target.c: Update.
1679         * tui/tui-stack.c: Update.
1680         * varobj.c: Update.
1681         * windows-nat.c: Update.
1682         * windows-tdep.c: Update.
1683
1684 2018-07-03  Tom Tromey  <tom@tromey.com>
1685
1686         * common/ptid.c (ptid_match): Remove.
1687         * common/ptid.h (ptid_match): Don't declare.
1688         * fbsd-nat.c: Update.
1689         * infcmd.c: Update.
1690         * infrun.c: Update.
1691         * linux-nat.c: Update.
1692         * record-btrace.c: Update.
1693         * regcache.c: Update.
1694         * remote.c: Update.
1695
1696 2018-07-03  Tom Tromey  <tom@tromey.com>
1697
1698         * common/ptid.c (ptid_tid_p): Remove.
1699         * common/ptid.h (ptid_tid_p): Don't declare.
1700         * sol-thread.c: Update.
1701
1702 2018-07-03  Tom Tromey  <tom@tromey.com>
1703
1704         * common/ptid.c (ptid_lwp_p): Remove.
1705         * common/ptid.h (ptid_lwp_p): Don't declare.
1706         * fbsd-nat.c: Update.
1707         * linux-nat.c: Update.
1708         * nat/linux-procfs.c: Update.
1709         * nat/x86-linux-dregs.c: Update.
1710         * sol-thread.c: Update.
1711
1712 2018-07-03  Tom Tromey  <tom@tromey.com>
1713
1714         * common/ptid.c (ptid_is_pid): Remove.
1715         * common/ptid.h (ptid_is_pid): Don't declare.
1716         * infrun.c: Update.
1717         * linux-nat.c: Update.
1718         * mi/mi-interp.c: Update.
1719         * remote.c: Update.
1720         * thread.c: Update.
1721
1722 2018-07-03  Tom Tromey  <tom@tromey.com>
1723
1724         * common/ptid.c (ptid_get_tid): Remove.
1725         * common/ptid.h (ptid_get_tid): Don't declare.
1726         * ada-tasks.c: Update.
1727         * aix-thread.c: Update.
1728         * bsd-uthread.c: Update.
1729         * darwin-nat.c: Update.
1730         * fbsd-nat.c: Update.
1731         * i386-darwin-nat.c: Update.
1732         * infrun.c: Update.
1733         * linux-tdep.c: Update.
1734         * nto-procfs.c: Update.
1735         * ppc-ravenscar-thread.c: Update.
1736         * python/py-infthread.c: Update.
1737         * ravenscar-thread.c: Update.
1738         * sol-thread.c: Update.
1739         * sparc-ravenscar-thread.c: Update.
1740         * windows-nat.c: Update.
1741
1742 2018-07-03  Tom Tromey  <tom@tromey.com>
1743
1744         * common/ptid.c (ptid_get_lwp): Remove.
1745         * common/ptid.h (ptid_get_lwp): Don't declare.
1746         * aarch64-linux-nat.c: Update.
1747         * ada-tasks.c: Update.
1748         * aix-thread.c: Update.
1749         * amd64-linux-nat.c: Update.
1750         * arm-linux-nat.c: Update.
1751         * corelow.c: Update.
1752         * fbsd-nat.c: Update.
1753         * fbsd-tdep.c: Update.
1754         * gnu-nat.c: Update.
1755         * i386-cygwin-tdep.c: Update.
1756         * i386-gnu-nat.c: Update.
1757         * i386-linux-nat.c: Update.
1758         * ia64-linux-nat.c: Update.
1759         * inf-ptrace.c: Update.
1760         * infrun.c: Update.
1761         * linux-fork.c: Update.
1762         * linux-nat.c: Update.
1763         * linux-tdep.c: Update.
1764         * linux-thread-db.c: Update.
1765         * mips-linux-nat.c: Update.
1766         * nat/aarch64-linux-hw-point.c: Update.
1767         * nat/aarch64-linux.c: Update.
1768         * nat/linux-btrace.c: Update.
1769         * nat/linux-osdata.c: Update.
1770         * nat/linux-procfs.c: Update.
1771         * nat/x86-linux-dregs.c: Update.
1772         * obsd-nat.c: Update.
1773         * ppc-fbsd-nat.c: Update.
1774         * ppc-linux-nat.c: Update.
1775         * procfs.c: Update.
1776         * python/py-infthread.c: Update.
1777         * ravenscar-thread.c: Update.
1778         * remote.c: Update.
1779         * s390-linux-nat.c: Update.
1780         * sol-thread.c: Update.
1781         * sol2-tdep.c: Update.
1782         * spu-linux-nat.c: Update.
1783         * x86-linux-nat.c: Update.
1784         * xtensa-linux-nat.c: Update.
1785
1786 2018-07-03  Tom Tromey  <tom@tromey.com>
1787
1788         * common/ptid.c (ptid_get_pid): Remove.
1789         * common/ptid.h (ptid_get_pid): Don't declare.
1790         * aarch64-linux-nat.c: Update.
1791         * ada-lang.c: Update.
1792         * aix-thread.c: Update.
1793         * alpha-bsd-nat.c: Update.
1794         * amd64-fbsd-nat.c: Update.
1795         * amd64-linux-nat.c: Update.
1796         * arm-linux-nat.c: Update.
1797         * arm-nbsd-nat.c: Update.
1798         * auxv.c: Update.
1799         * break-catch-syscall.c: Update.
1800         * breakpoint.c: Update.
1801         * bsd-uthread.c: Update.
1802         * corelow.c: Update.
1803         * ctf.c: Update.
1804         * darwin-nat.c: Update.
1805         * fbsd-nat.c: Update.
1806         * fbsd-tdep.c: Update.
1807         * gcore.c: Update.
1808         * gnu-nat.c: Update.
1809         * hppa-nbsd-nat.c: Update.
1810         * hppa-obsd-nat.c: Update.
1811         * i386-fbsd-nat.c: Update.
1812         * ia64-linux-nat.c: Update.
1813         * inf-ptrace.c: Update.
1814         * infcmd.c: Update.
1815         * inferior.c: Update.
1816         * inferior.h: Update.
1817         * inflow.c: Update.
1818         * infrun.c: Update.
1819         * linux-fork.c: Update.
1820         * linux-nat.c: Update.
1821         * linux-tdep.c: Update.
1822         * linux-thread-db.c: Update.
1823         * m68k-bsd-nat.c: Update.
1824         * mi/mi-interp.c: Update.
1825         * mi/mi-main.c: Update.
1826         * mips-linux-nat.c: Update.
1827         * mips-nbsd-nat.c: Update.
1828         * mips64-obsd-nat.c: Update.
1829         * nat/aarch64-linux-hw-point.c: Update.
1830         * nat/aarch64-linux.c: Update.
1831         * nat/linux-btrace.c: Update.
1832         * nat/linux-osdata.c: Update.
1833         * nat/linux-procfs.c: Update.
1834         * nat/x86-linux-dregs.c: Update.
1835         * nto-procfs.c: Update.
1836         * obsd-nat.c: Update.
1837         * ppc-linux-nat.c: Update.
1838         * ppc-nbsd-nat.c: Update.
1839         * ppc-obsd-nat.c: Update.
1840         * proc-service.c: Update.
1841         * procfs.c: Update.
1842         * python/py-inferior.c: Update.
1843         * python/py-infthread.c: Update.
1844         * ravenscar-thread.c: Update.
1845         * record.c: Update.
1846         * remote-sim.c: Update.
1847         * remote.c: Update.
1848         * rs6000-nat.c: Update.
1849         * s390-linux-nat.c: Update.
1850         * sh-nbsd-nat.c: Update.
1851         * sol-thread.c: Update.
1852         * sparc-nat.c: Update.
1853         * sparc64-tdep.c: Update.
1854         * spu-linux-nat.c: Update.
1855         * spu-tdep.c: Update.
1856         * target-debug.h: Update.
1857         * target.c: Update.
1858         * thread.c: Update.
1859         * tid-parse.c: Update.
1860         * tracefile-tfile.c: Update.
1861         * vax-bsd-nat.c: Update.
1862         * windows-nat.c: Update.
1863         * x86-linux-nat.c: Update.
1864         * x86-nat.c: Update.
1865
1866 2018-07-03  Tom Tromey  <tom@tromey.com>
1867
1868         * common/ptid.c (pid_to_ptid): Remove.
1869         * common/ptid.h (pid_to_ptid): Don't declare.
1870         * aix-thread.c: Update.
1871         * arm-linux-nat.c: Update.
1872         * common/ptid.c: Update.
1873         * common/ptid.h: Update.
1874         * corelow.c: Update.
1875         * ctf.c: Update.
1876         * darwin-nat.c: Update.
1877         * fbsd-nat.c: Update.
1878         * fork-child.c: Update.
1879         * gnu-nat.c: Update.
1880         * go32-nat.c: Update.
1881         * inf-ptrace.c: Update.
1882         * infcmd.c: Update.
1883         * inferior.c: Update.
1884         * infrun.c: Update.
1885         * linux-fork.c: Update.
1886         * linux-nat.c: Update.
1887         * nat/aarch64-linux-hw-point.c: Update.
1888         * nat/fork-inferior.c: Update.
1889         * nat/x86-linux-dregs.c: Update.
1890         * nto-procfs.c: Update.
1891         * obsd-nat.c: Update.
1892         * procfs.c: Update.
1893         * progspace.c: Update.
1894         * remote.c: Update.
1895         * rs6000-nat.c: Update.
1896         * s390-linux-nat.c: Update.
1897         * sol-thread.c: Update.
1898         * spu-linux-nat.c: Update.
1899         * target.c: Update.
1900         * top.c: Update.
1901         * tracefile-tfile.c: Update.
1902         * windows-nat.c: Update.
1903
1904 2018-07-03  Tom Tromey  <tom@tromey.com>
1905
1906         * common/ptid.h (ptid_build): Don't declare.
1907         * common/ptid.c (ptid_build): Remove.
1908         * aix-thread.c: Update.
1909         * bsd-kvm.c: Update.
1910         * bsd-uthread.c: Update.
1911         * common/agent.c: Update.
1912         * common/ptid.c: Update.
1913         * common/ptid.h: Update.
1914         * corelow.c: Update.
1915         * darwin-nat.c: Update.
1916         * fbsd-nat.c: Update.
1917         * gnu-nat.c: Update.
1918         * linux-fork.c: Update.
1919         * linux-nat.c: Update.
1920         * linux-thread-db.c: Update.
1921         * nat/linux-osdata.c: Update.
1922         * nat/linux-procfs.c: Update.
1923         * nto-procfs.c: Update.
1924         * obsd-nat.c: Update.
1925         * proc-service.c: Update.
1926         * procfs.c: Update.
1927         * ravenscar-thread.c: Update.
1928         * remote-sim.c: Update.
1929         * remote.c: Update.
1930         * sol-thread.c: Update.
1931         * target.c: Update.
1932         * windows-nat.c: Update.
1933
1934 2018-07-03  Tom Tromey  <tom@tromey.com>
1935
1936         * infrun.c (follow_exec): Use exit_inferior_silent.
1937         * inferior.c (exit_inferior_num_silent): Remove.
1938         * inferior.h (exit_inferior_num_silent): Don't declare.
1939
1940 2018-07-03  Tom Tromey  <tom@tromey.com>
1941
1942         PR cli/23340:
1943         * darwin-nat.c (darwin_attach_pid): Reset inferior and
1944         inferior_ptid on error.
1945
1946 2018-07-02  Maciej W. Rozycki  <macro@mips.com>
1947             Simon Marchi  <simon.marchi@polymtl.ca>
1948
1949         PR tdep/8282
1950         * disasm.h (gdb_disassembler): Add
1951         `m_disassembler_options_holder'. member
1952         * disasm.c (get_all_disassembler_options): New function.
1953         (gdb_disassembler::gdb_disassembler): Use it.
1954         (gdb_buffered_insn_length_init_dis): Likewise.
1955         (gdb_buffered_insn_length): Adjust accordingly.
1956         (set_disassembler_options): Handle options with arguments.
1957         (show_disassembler_options_sfunc): Likewise.  Add a leading new
1958         line if showing options with descriptions.
1959         (disassembler_options_completer): Adapt to using the
1960         `disasm_options_and_args_t' structure.
1961         * mips-tdep.c (mips_disassembler_options): New variable.
1962         (mips_disassembler_options_o32): Likewise.
1963         (mips_disassembler_options_n32): Likewise.
1964         (mips_disassembler_options_n64): Likewise.
1965         (gdb_print_insn_mips): Don't set `disassembler_options'.
1966         (gdb_print_insn_mips_n32, gdb_print_insn_mips_n64): Remove
1967         functions.
1968         (mips_gdbarch_init): Always set `gdbarch_print_insn' to
1969         `gdb_print_insn_mips'.  Set `gdbarch_disassembler_options',
1970         `gdbarch_disassembler_options_implicit' and
1971         `gdbarch_valid_disassembler_options'.
1972         * arm-tdep.c (_initialize_arm_tdep): Adapt to using the
1973         `disasm_options_and_args_t' structure.
1974         * gdbarch.sh (disassembler_options_implicit): New `gdbarch'
1975         method.
1976         (valid_disassembler_options): Switch from `disasm_options_t' to
1977         the `disasm_options_and_args_t' structure.
1978         * NEWS: Document `set disassembler-options' support for the MIPS
1979         target.
1980         * gdbarch.h: Regenerate.
1981         * gdbarch.c: Regenerate.
1982
1983 2018-07-02  Sebastian Huber  <sebastian.huber@embedded-brains.de>
1984
1985         * riscv-tdep.c (riscv_register_aliases): Swap "fp" and "s0" entries.
1986
1987 2018-06-29  Joel Brobecker  <brobecker@adacore.com>
1988
1989         * amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing
1990         parameter in call to amd64_target_description.
1991         * amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise.
1992         * amd64-fbsd-tdep.c (amd64fbsd_core_read_description)
1993         (amd64fbsd_init_abi): Likewise.
1994         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1995         * amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise.
1996         * amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise.
1997         * amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise.
1998
1999 2018-06-29  Pedro Alves  <palves@redhat.com>
2000
2001         * gdb/amd64-tdep.h (amd64_create_target_description): Add
2002         "segments" parameter.
2003         * gdb/amd64-tdep.c (amd64_none_init_abi, amd64_x32_none_init_abi)
2004         (_initialize_amd64_tdep): Update call to
2005         amd64_create_target_description.
2006         (amd64_target_description): Add "segments" parameter.  Adjust
2007         the implementation to use it.
2008         * gdb/amd64-linux-tdep.c (amd64_linux_read_description): Update
2009         call to amd64_create_target_description.
2010         * gdb/amd64-windows-tdep.c (amd64_windows_init_abi): Likewise.
2011         * gdb/arch/amd64.h (amd64_create_target_description): Add
2012         "segments" register.
2013         * gdb/arch/amd64.c (amd64_create_target_description): Add
2014         "segments" parameter.  Call create_feature_i386_64bit_segments
2015         only if SEGMENTS is true.
2016         * gdb/gdbserver/win32-i386-low.c (i386_arch_setup): Update
2017         call to amd64_create_target_description.
2018
2019 2018-06-29  Pedro Alves  <palves@redhat.com>
2020
2021         * thread.c (thread_target_id_str): New, factored out from ...
2022         (print_thread_info_1): ... here.  Use it to compute the max
2023         "Target Id" column width.
2024
2025 2018-06-29  Pedro Alves  <palves@redhat.com>
2026
2027         * remote.c (remote_target::extra_thread_info): Delete
2028         'display_buf' and 'n' locals.  from the cache, regardless of
2029         packet mechanims is in use.  Use cache for qThreadExtra and qP
2030         methods too.
2031
2032 2018-06-29  Pedro Alves  <palves@redhat.com>
2033
2034         * blockframe.c (find_pc_sect_containing_function): New function.
2035         * breakpoint.c (print_breakpoint_location): Don't call
2036         find_pc_sect_function.
2037         * linespec.c (create_sals_line_offset): Record the location's
2038         symbol in the sal.
2039         * linespec.c (convert_address_location_to_sals): Fill in sal's
2040         symbol with find_pc_sect_containing_function.
2041         * symtab.c (find_function_start_sal): Rename to ...
2042         (find_function_start_sal_1): ... this.
2043         (find_function_start_sal): Reimplement as wrapper around
2044         find_function_start_sal_1, and use
2045         find_pc_sect_containing_function to fill in the sal's symbol.
2046         (find_function_start_sal(symbol*, bool)): Adjust.
2047         * symtab.h (find_pc_function, find_pc_sect_function): Adjust
2048         comments.
2049         (find_pc_sect_containing_function): Declare.
2050
2051 2018-06-29  Pedro Alves  <palves@redhat.com>
2052
2053         * inline-frame.c (stopped_by_user_bp_inline_frame): Return
2054         true if the the location has no symbol.
2055
2056 2018-06-28  Tom Tromey  <tom@tromey.com>
2057
2058         * NEWS: Mention --enable-codesign.
2059         * silent-rules.mk (ECHO_SIGN): New variable.
2060         * configure.ac: Add --enable-codesign.
2061         * configure: Rebuild.
2062         * Makefile.in (CODESIGN, CODESIGN_CERT): New variables.
2063         (gdb$(EXEEXT)): Optionally invoke codesign.
2064
2065 2018-06-28  Pedro Alves  <palves@redhat.com>
2066
2067         * gdbthread.h (struct thread_suspend_state) <stop_pc>: Extend
2068         comments.
2069         (switch_to_thread_no_regs): Adjust comment.
2070         * infcmd.c (stop_pc): Delete.
2071         (post_create_inferior, info_program_command): Replace references
2072         to stop_pc with references to thread_info->suspend.stop_pc.
2073         * inferior.h (stop_pc): Delete declaration.
2074         * infrun.c (proceed, handle_syscall_event, fill_in_stop_func)
2075         (handle_inferior_event_1, handle_signal_stop)
2076         (process_event_stop_test, keep_going_stepped_thread)
2077         (handle_step_into_function, handle_step_into_function_backward)
2078         (print_stop_location): Replace references to stop_pc with
2079         references to thread_info->suspend.stop_pc.
2080         (struct infcall_suspend_state) <stop_pc>: Delete field.
2081         (save_infcall_suspend_state, restore_infcall_suspend_state):
2082         Remove references to inf_stat->stop_pc.
2083         * linux-fork.c (fork_load_infrun_state): Likewise.
2084         * record-btrace.c (record_btrace_set_replay): Likewise.
2085         * record-full.c (record_full_goto_entry): Likewise.
2086         * remote.c (print_one_stopped_thread): Likewise.
2087         * target.c (target_resume): Extend comment.
2088         * thread.c (set_executing_thread): New.
2089         (set_executing): Use it.
2090         (switch_to_thread_no_regs, switch_to_no_thread, switch_to_thread):
2091         Remove references to stop_pc.
2092
2093 2018-06-28  Pedro Alves  <palves@redhat.com>
2094
2095         * infrun.c (handle_inferior_event_1) <TARGET_WAITKIND_EXECD>:
2096         Moving fetching stop_pc until after ecs->event_thread is refreshed.
2097
2098 2018-06-28  Tom Tromey  <tom@tromey.com>
2099
2100         * coffread.c (coff_symfile_finish): Update.
2101         * xcoffread.c (xcoff_symfile_finish): Update.
2102         * elfread.c (elf_symfile_finish): Update.
2103         * symfile.h (dwarf2_free_objfile): Don't declare.
2104         * dwarf2read.c (_initialize_dwarf2_read): Use
2105         register_objfile_data_with_cleanup.
2106         (dwarf2_free_objfile): Now static.  Change signature.
2107
2108 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2109
2110         * symfile.c (add_symbol_file_command, _initialize_symfile): Add
2111         option "-o" to add-symbol-file-load to add an offset to each
2112         section's load address.
2113         * symfile.c (set_objfile_default_section_offset): New function.
2114
2115 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2116
2117         * symfile.c (add_symbol_file_command): Make sure that sections
2118         with the same name are sorted in the same order.
2119
2120 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2121
2122         * symfile.c (add_symbol_file_command, _initialize_symfile): Do not
2123         require the second argument.  If omitted, load sections at the
2124         addresses specified in the file.
2125
2126 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2127
2128         * symfile.c (symbol_file_command, symbol_file_add_main_1)
2129         (_initialize_symfile): Add option "-o" to symbol-file to add an
2130         offset to each section of the symbol file.
2131
2132 2018-06-28  Petr Tesarik  <ptesarik@suse.cz>
2133
2134         * MAINTAINERS (Write After Approval): Add Petr Tesarik.
2135
2136 2018-06-27  Tom Tromey  <tom@tromey.com>
2137
2138         * stack.c (_initialize_stack): Update "func" help text.
2139
2140 2018-06-27  Tom Tromey  <tom@tromey.com>
2141
2142         * python/py-unwind.c (unwind_info_object) <saved_regs>: Now a
2143         std::vector.
2144         (unwind_infopy_str, pyuw_create_unwind_info)
2145         (unwind_infopy_add_saved_register, pyuw_sniffer)
2146         (unwind_infopy_dealloc, unwind_infopy_add_saved_register):
2147         Update.
2148         (struct saved_reg): Add constructor.
2149         <value>: Now a gdbpy_ref<>.
2150
2151 2018-06-27  Tom Tromey  <tom@tromey.com>
2152
2153         * machoread.c (macho_symfile_read): Define "symbol_table" earlier.
2154
2155 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2156
2157         * gdb-gdb.py.in: Format using autopep8.
2158
2159 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2160
2161         * gdb-gdb.py.in (CoreAddrPrettyPrinter): New class.
2162         (type_lookup_function): Recognize CORE_ADDR values.
2163
2164 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2165
2166         * gdb-gdb.py.in (StructMainTypePrettyPrinter) <to_string>: Don't
2167         print tag_name.
2168
2169 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2170
2171         * gdb-gdb.py.in (TypeFlag) <__cmp__>: Remove.
2172         <__lt__>: Add.
2173
2174 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2175
2176         * gdb-gdb.py: Move to...
2177         * gdb-gdb.py.in: ... here.
2178         * configure.ac (AC_CONFIG_FILES): Add gdb-gdb.py.
2179         * Makefile.in (all): Add gdb-gdb.gdb and gdb-gdb.py as
2180         dependencies.
2181         (distclean): Remove gdb-gdb.py when cleaning.
2182         (gdb-gdb.py, gdb-gdb.gdb): New rules.
2183         * configure: Re-generate.
2184
2185 2018-06-27  Pedro Alves  <palves@redhat.com>
2186
2187         * proc-service.c (get_ps_regcache): New.
2188         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs)
2189         (ps_lsetfpregs): Use it.
2190
2191 2018-06-27  Omair Javaid  <omair.javaid@linaro.org>
2192
2193         PR gdb/21695
2194         * dwarf2read.c (lnp_state_machine::check_line_address): Update declaration.
2195         (dwarf_decode_lines_1): Adjust.
2196
2197 2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
2198
2199         * fbsd-nat.h (class fbsd_nat_target) <find_memory_regions>: Add
2200         override.
2201         <info_proc>: Likewise.
2202
2203 2018-06-26  Joel Brobecker  <brobecker@adacore.com>
2204
2205         * windows-nat.c (do_windows_fetch_inferior_registers): Rename
2206         to windows_fetch_one_register, and only handle the case of
2207         fetching one register.  Move the code that reloads the context
2208         and iterates over all registers if R is negative to...
2209         (windows_nat_target::fetch_registers): ... here.
2210         (do_windows_store_inferior_registers): Rename to
2211         windows_store_one_register, and only handle the case of storing
2212         one register.  Move the code that handles the case where r is
2213         negative to...
2214         (windows_nat_target::store_registers) ... here.
2215
2216 2018-06-26  Tom Tromey  <tom@tromey.com>
2217
2218         PR rust/22574:
2219         * typeprint.c (whatis_exp): Allow ptype/o for Rust.
2220         * rust-lang.c (rust_print_struct_def): Add podata parameter.
2221         Update.
2222         (rust_internal_print_type): Add podata parameter.
2223         (rust_print_type): Update.
2224
2225 2018-06-26  Tom Tromey  <tom@tromey.com>
2226
2227         * typeprint.h (struct print_offset_data) <update, finish,
2228         maybe_print_hole>: New methods.
2229         <indentation>: New constant.
2230         * typeprint.c (print_offset_data::indentation): Define.
2231         (print_offset_data::maybe_print_hole, print_offset_data::update)
2232         (print_offset_data::finish): Move from c-typeprint.c and rename.
2233         * c-typeprint.c (OFFSET_SPC_LEN): Remove.
2234         (print_spaces_filtered_with_print_options): Update.
2235         (c_print_type_union_field_offset, maybe_print_hole)
2236         (c_print_type_struct_field_offset): Move to typeprint.c and
2237         rename.
2238         (c_type_print_base_struct_union): Update.
2239
2240 2018-06-25  Pedro Alves  <palves@redhat.com>
2241
2242         * gdbthread.h (thread_info_ref, delete_thread)
2243         (delete_thread_silent, first_thread_of_inferior)
2244         (any_thread_of_inferior, switch_to_thread)
2245         (enable_thread_stack_temporaries)
2246         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
2247         (get_last_thread_stack_temporary)
2248         (value_in_thread_stack_temporaries, can_access_registers_thread):
2249         Spell out "struct thread_info" instead of just "thread_info".
2250         * inferior.h (notice_new_inferior): Likewise.
2251
2252 2018-06-25  Pedro Alves  <palves@redhat.com>
2253
2254         * windows-nat.c (windows_delete_thread): Use find_thread_ptid and
2255         pass thread_info pointer to delete_thread.
2256         (windows_nat_target::detach): Pass inferior pointer to
2257         detach_inferior.
2258         * aix-thread.c (sync_threadlists): Pass thread_info pointer to
2259         delete_thread.
2260         * bsd-kvm.c (bsd_kvm_target::close): Use discard_all_inferiors.
2261         * darwin-nat.c (darwin_check_new_threads): Use find_thread_ptid
2262         and pass a thread_info pointer to delete_thread.
2263         * fbsd-nat.c (fbsd_nat_target::wait): Use find_thread_ptid and
2264         pass thread_info pointer to delete_thread.
2265         * go32-nat.c (go32_nat_target::mourn_inferior): Remove
2266         delete_thread_silent call.
2267         * procfs.c (procfs_target::detach): Pass inferior pointer to
2268         detach_inferior.
2269         (procfs_target::wait): Pass thread_info pointer to delete_thread.
2270         * remote-sim.c (gdbsim_target::mourn_inferior): Remove
2271         delete_thread_silent call.
2272         * windows-nat.c (windows_delete_thread): Use find_thread_ptid and
2273         pass thread_info pointer to delete_thread.
2274         (windows_nat_target::detach): Pass inferior pointer to
2275         delete_inferior.
2276
2277 2018-06-22  Alan Hayward  <alan.hayward@arm.com>
2278
2279         * regcache.c (readable_regcache::read_part): Fix asserts.
2280         (reg_buffer::raw_collect_part): New function.
2281         (regcache::write_part): Fix asserts.
2282         (reg_buffer::raw_supply_part): New function.
2283         (regcache::transfer_regset_register): New helper function.
2284         (regcache::transfer_regset): Call new functions.
2285         (regcache_supply_regset): Use gdb_byte*.
2286         (regcache::supply_regset): Likewise.
2287         (regcache_collect_regset): Likewise.
2288         (regcache::collect_regset): Likewise.
2289         * regcache.h (reg_buffer::raw_collect_part): New declaration.
2290         (reg_buffer::raw_supply_part): Likewise.
2291         (regcache::transfer_regset_register): Likewise.
2292         (regcache::transfer_regset): Use gdb_byte*.
2293
2294 2018-06-22  Alan Hayward  <alan.hayward@arm.com>
2295
2296         * nat/aarch64-sve-linux-ptrace.h (HAS_SVE_STATE): Use &.
2297
2298 2018-06-21  Pedro Alves  <palves@redhat.com>
2299
2300         * ada-lang.h (ada_get_task_number): Take a thread_info pointer
2301         instead of a ptid_t.  All callers adjusted.
2302         * ada-tasks.c (ada_get_task_number): Likewise.  All callers
2303         adjusted.
2304         (print_ada_task_info, display_current_task_id, task_command_1):
2305         Adjust.
2306         * breakpoint.c (watchpoint_in_thread_scope): Adjust to use
2307         inferior_thread.
2308         (breakpoint_kind): Adjust.
2309         (remove_breakpoints_pid): Rename to ...
2310         (remove_breakpoints_inf): ... this.  Adjust to take an inferior
2311         pointer.  All callers adjusted.
2312         (bpstat_clear_actions): Use inferior_thread.
2313         (get_bpstat_thread): New.
2314         (bpstat_do_actions): Use it.
2315         (bpstat_check_breakpoint_conditions, bpstat_stop_status): Adjust
2316         to take a thread_info pointer.  All callers adjusted.
2317         (set_longjmp_breakpoint_for_call_dummy, set_momentary_breakpoint)
2318         (breakpoint_re_set_thread): Use inferior_thread.
2319         * breakpoint.h (struct inferior): Forward declare.
2320         (bpstat_stop_status): Update.
2321         (remove_breakpoints_pid): Delete.
2322         (remove_breakpoints_inf): New.
2323         * bsd-uthread.c (bsd_uthread_target::wait)
2324         (bsd_uthread_target::update_thread_list): Use find_thread_ptid.
2325         * btrace.c (btrace_add_pc, btrace_enable, btrace_fetch)
2326         (maint_btrace_packet_history_cmd)
2327         (maint_btrace_clear_packet_history_cmd): Adjust.
2328         (maint_btrace_clear_cmd, maint_info_btrace_cmd): Adjust to use
2329         inferior_thread.
2330         * cli/cli-interp.c: Include "inferior.h".
2331         * common/refcounted-object.h (struct
2332         refcounted_object_ref_policy): New.
2333         * compile/compile-object-load.c: Include gdbthread.h.
2334         (store_regs): Use inferior_thread.
2335         * corelow.c (core_target::close): Use current_inferior.
2336         (core_target_open): Adjust to use first_thread_of_inferior and use
2337         the current inferior.
2338         * ctf.c (ctf_target::close): Adjust to use current_inferior.
2339         * dummy-frame.c (dummy_frame_id) <ptid>: Delete, replaced by ...
2340         <thread>: ... this new field.  All references adjusted.
2341         (dummy_frame_pop, dummy_frame_discard, register_dummy_frame_dtor):
2342         Take a thread_info pointer instead of a ptid_t.
2343         * dummy-frame.h (dummy_frame_push, dummy_frame_pop)
2344         (dummy_frame_discard, register_dummy_frame_dtor): Take a
2345         thread_info pointer instead of a ptid_t.
2346         * elfread.c: Include "inferior.h".
2347         (elf_gnu_ifunc_resolver_stop, elf_gnu_ifunc_resolver_return_stop):
2348         Use inferior_thread.
2349         * eval.c (evaluate_subexp): Likewise.
2350         * frame.c (frame_pop, has_stack_frames, find_frame_sal): Use
2351         inferior_thread.
2352         * gdb_proc_service.h (struct thread_info): Forward declare.
2353         (struct ps_prochandle) <ptid>: Delete, replaced by ...
2354         <thread>: ... this new field.  All references adjusted.
2355         * gdbarch.h, gdbarch.c: Regenerate.
2356         * gdbarch.sh (get_syscall_number): Replace 'ptid' parameter with a
2357         'thread' parameter.  All implementations and callers adjusted.
2358         * gdbthread.h (thread_info) <set_running>: New method.
2359         (delete_thread, delete_thread_silent): Take a thread_info pointer
2360         instead of a ptid.
2361         (global_thread_id_to_ptid, ptid_to_global_thread_id): Delete.
2362         (first_thread_of_process): Delete, replaced by ...
2363         (first_thread_of_inferior): ... this new function.  All callers
2364         adjusted.
2365         (any_live_thread_of_process): Delete, replaced by ...
2366         (any_live_thread_of_inferior): ... this new function.  All callers
2367         adjusted.
2368         (switch_to_thread, switch_to_no_thread): Declare.
2369         (is_executing): Delete.
2370         (enable_thread_stack_temporaries): Update comment.
2371         <enable_thread_stack_temporaries>: Take a thread_info pointer
2372         instead of a ptid_t.  Incref the thread.
2373         <~enable_thread_stack_temporaries>: Decref the thread.
2374         <m_ptid>: Delete
2375         <m_thr>: New.
2376         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
2377         (get_last_thread_stack_temporary)
2378         (value_in_thread_stack_temporaries, can_access_registers_thread):
2379         Take a thread_info pointer instead of a ptid_t.  All callers
2380         adjusted.
2381         * infcall.c (get_call_return_value): Use inferior_thread.
2382         (run_inferior_call): Work with thread pointers instead of ptid_t.
2383         (call_function_by_hand_dummy): Work with thread pointers instead
2384         of ptid_t.  Use thread_info_ref.
2385         * infcmd.c (proceed_thread_callback): Access thread's state
2386         directly.
2387         (ensure_valid_thread, ensure_not_running): Use inferior_thread,
2388         access thread's state directly.
2389         (continue_command): Use inferior_thread.
2390         (info_program_command): Use find_thread_ptid and access thread
2391         state directly.
2392         (proceed_after_attach_callback): Use thread state directly.
2393         (notice_new_inferior): Take a thread_info pointer instead of a
2394         ptid_t.  All callers adjusted.
2395         (exit_inferior): Take an inferior pointer instead of a pid.  All
2396         callers adjusted.
2397         (exit_inferior_silent): New.
2398         (detach_inferior): Delete.
2399         (valid_gdb_inferior_id, pid_to_gdb_inferior_id)
2400         (gdb_inferior_id_to_pid, in_inferior_list): Delete.
2401         (detach_inferior_command, kill_inferior_command): Use
2402         find_inferior_id instead of valid_gdb_inferior_id and
2403         gdb_inferior_id_to_pid.
2404         (inferior_command): Use inferior and thread pointers.
2405         * inferior.h (struct thread_info): Forward declare.
2406         (notice_new_inferior): Take a thread_info pointer instead of a
2407         ptid_t.  All callers adjusted.
2408         (detach_inferior): Delete declaration.
2409         (exit_inferior, exit_inferior_silent): Take an inferior pointer
2410         instead of a pid.  All callers adjusted.
2411         (gdb_inferior_id_to_pid, pid_to_gdb_inferior_id, in_inferior_list)
2412         (valid_gdb_inferior_id): Delete.
2413         * infrun.c (follow_fork_inferior, proceed_after_vfork_done)
2414         (handle_vfork_child_exec_or_exit, follow_exec): Adjust.
2415         (struct displaced_step_inferior_state) <pid>: Delete, replaced by
2416         ...
2417         <inf>: ... this new field.
2418         <step_ptid>: Delete, replaced by ...
2419         <step_thread>: ... this new field.
2420         (get_displaced_stepping_state): Take an inferior pointer instead
2421         of a pid.  All callers adjusted.
2422         (displaced_step_in_progress_any_inferior): Adjust.
2423         (displaced_step_in_progress_thread): Take a thread pointer instead
2424         of a ptid_t.  All callers adjusted.
2425         (displaced_step_in_progress, add_displaced_stepping_state): Take
2426         an inferior pointer instead of a pid.  All callers adjusted.
2427         (get_displaced_step_closure_by_addr): Adjust.
2428         (remove_displaced_stepping_state): Take an inferior pointer
2429         instead of a pid.  All callers adjusted.
2430         (displaced_step_prepare_throw, displaced_step_prepare)
2431         (displaced_step_fixup): Take a thread pointer instead of a ptid_t.
2432         All callers adjusted.
2433         (start_step_over): Adjust.
2434         (infrun_thread_ptid_changed): Remove bit updating ptids in the
2435         displaced step queue.
2436         (do_target_resume): Adjust.
2437         (fetch_inferior_event): Use inferior_thread.
2438         (context_switch, get_inferior_stop_soon): Take an
2439         execution_control_state pointer instead of a ptid_t.  All callers
2440         adjusted.
2441         (switch_to_thread_cleanup): Delete.
2442         (stop_all_threads): Use scoped_restore_current_thread.
2443         * inline-frame.c: Include "gdbthread.h".
2444         (inline_state) <inline_state>: Take a thread pointer instead of a
2445         ptid_t.  All callers adjusted.
2446         <ptid>: Delete, replaced by ...
2447         <thread>: ... this new field.
2448         (find_inline_frame_state): Take a thread pointer instead of a
2449         ptid_t.  All callers adjusted.
2450         (skip_inline_frames, step_into_inline_frame)
2451         (inline_skipped_frames, inline_skipped_symbol): Take a thread
2452         pointer instead of a ptid_t.  All callers adjusted.
2453         * inline-frame.h (skip_inline_frames, step_into_inline_frame)
2454         (inline_skipped_frames, inline_skipped_symbol): Likewise.
2455         * linux-fork.c (delete_checkpoint_command): Adjust to use thread
2456         pointers directly.
2457         * linux-nat.c (get_detach_signal): Likewise.
2458         * linux-thread-db.c (thread_from_lwp): New 'stopped' parameter.
2459         (thread_db_notice_clone): Adjust.
2460         (thread_db_find_new_threads_silently)
2461         (thread_db_find_new_threads_2, thread_db_find_new_threads_1): Take
2462         a thread pointer instead of a ptid_t.  All callers adjusted.
2463         * mi/mi-cmd-var.c: Include "inferior.h".
2464         (mi_cmd_var_update_iter): Update to use thread pointers.
2465         * mi/mi-interp.c (mi_new_thread): Update to use the thread's
2466         inferior directly.
2467         (mi_output_running_pid, mi_inferior_count): Delete, bits factored
2468         out to ...
2469         (mi_output_running): ... this new function.
2470         (mi_on_resume_1): Adjust to use it.
2471         (mi_user_selected_context_changed): Adjust to use inferior_thread.
2472         * mi/mi-main.c (proceed_thread): Adjust to use thread pointers
2473         directly.
2474         (interrupt_thread_callback): : Adjust to use thread and inferior
2475         pointers.
2476         * proc-service.c: Include "gdbthread.h".
2477         (ps_pglobal_lookup): Adjust to use the thread's inferior directly.
2478         * progspace-and-thread.c: Include "inferior.h".
2479         * progspace.c: Include "inferior.h".
2480         * python/py-exitedevent.c (create_exited_event_object): Adjust to
2481         hold a reference to an inferior_object.
2482         * python/py-finishbreakpoint.c (bpfinishpy_init): Adjust to use
2483         inferior_thread.
2484         * python/py-inferior.c (struct inferior_object): Give the type a
2485         tag name instead of a typedef.
2486         (python_on_normal_stop): No need to check if the current thread is
2487         listed.
2488         (inferior_to_inferior_object): Change return type to
2489         inferior_object.  All callers adjusted.
2490         (find_thread_object): Delete, bits factored out to ...
2491         (thread_to_thread_object): ... this new function.
2492         * python/py-infthread.c (create_thread_object): Use
2493         inferior_to_inferior_object.
2494         (thpy_is_stopped): Use thread pointer directly.
2495         (gdbpy_selected_thread): Use inferior_thread.
2496         * python/py-record-btrace.c (btpy_list_object) <ptid>: Delete
2497         field, replaced with ...
2498         <thread>: ... this new field.  All users adjusted.
2499         (btpy_insn_or_gap_new): Drop const.
2500         (btpy_list_new): Take a thread pointer instead of a ptid_t.  All
2501         callers adjusted.
2502         * python/py-record.c: Include "gdbthread.h".
2503         (recpy_insn_new, recpy_func_new): Take a thread pointer instead of
2504         a ptid_t.  All callers adjusted.
2505         (gdbpy_current_recording): Use inferior_thread.
2506         * python/py-record.h (recpy_record_object) <ptid>: Delete
2507         field, replaced with ...
2508         <thread>: ... this new field.  All users adjusted.
2509         (recpy_element_object) <ptid>: Delete
2510         field, replaced with ...
2511         <thread>: ... this new field.  All users adjusted.
2512         (recpy_insn_new, recpy_func_new): Take a thread pointer instead of
2513         a ptid_t.  All callers adjusted.
2514         * python/py-threadevent.c: Include "gdbthread.h".
2515         (get_event_thread): Use thread_to_thread_object.
2516         * python/python-internal.h (struct inferior_object): Forward
2517         declare.
2518         (find_thread_object, find_inferior_object): Delete declarations.
2519         (thread_to_thread_object, inferior_to_inferior_object): New
2520         declarations.
2521         * record-btrace.c: Include "inferior.h".
2522         (require_btrace_thread): Use inferior_thread.
2523         (record_btrace_frame_sniffer)
2524         (record_btrace_tailcall_frame_sniffer): Use inferior_thread.
2525         (get_thread_current_frame): Use scoped_restore_current_thread and
2526         switch_to_thread.
2527         (get_thread_current_frame): Use thread pointer directly.
2528         (record_btrace_replay_at_breakpoint): Use thread's inferior
2529         pointer directly.
2530         * record-full.c: Include "inferior.h".
2531         * regcache.c: Include "gdbthread.h".
2532         (get_thread_arch_regcache): Use the inferior's address space
2533         directly.
2534         (get_thread_regcache, registers_changed_thread): New.
2535         * regcache.h (get_thread_regcache(thread_info *thread)): New
2536         overload.
2537         (registers_changed_thread): New.
2538         (remote_target) <remote_detach_1>: Swap order of parameters.
2539         (remote_add_thread): <remote_add_thread>: Return the new thread.
2540         (get_remote_thread_info(ptid_t)): New overload.
2541         (remote_target::remote_notice_new_inferior): Use thread pointers
2542         directly.
2543         (remote_target::process_initial_stop_replies): Use
2544         thread_info::set_running.
2545         (remote_target::remote_detach_1, remote_target::detach)
2546         (extended_remote_target::detach): Adjust.
2547         * stack.c (frame_show_address): Use inferior_thread.
2548         * target-debug.h (target_debug_print_thread_info_pp): New.
2549         * target-delegates.c: Regenerate.
2550         * target.c (default_thread_address_space): Delete.
2551         (memory_xfer_partial_1): Use current_inferior.
2552         (target_detach): Use current_inferior.
2553         (target_thread_address_space): Delete.
2554         (generic_mourn_inferior): Use current_inferior.
2555         * target.h (struct target_ops) <thread_address_space>: Delete.
2556         (target_thread_address_space): Delete.
2557         * thread.c (init_thread_list): Use ALL_THREADS_SAFE.  Use thread
2558         pointers directly.
2559         (delete_thread_1, delete_thread, delete_thread_silent): Take a
2560         thread pointer instead of a ptid_t.  Adjust all callers.
2561         (ptid_to_global_thread_id, global_thread_id_to_ptid): Delete.
2562         (first_thread_of_process): Delete, replaced by ...
2563         (first_thread_of_inferior): ... this new function.  All callers
2564         adjusted.
2565         (any_thread_of_process): Rename to ...
2566         (any_thread_of_inferior): ... this, and take an inferior pointer.
2567         (any_live_thread_of_process): Rename to ...
2568         (any_live_thread_of_inferior): ... this, and take an inferior
2569         pointer.
2570         (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
2571         (value_in_thread_stack_temporaries)
2572         (get_last_thread_stack_temporary): Take a thread pointer instead
2573         of a ptid_t.  Adjust all callers.
2574         (thread_info::set_running): New.
2575         (validate_registers_access): Use inferior_thread.
2576         (can_access_registers_ptid): Rename to ...
2577         (can_access_registers_thread): ... this, and take a thread
2578         pointer.
2579         (print_thread_info_1): Adjust to compare thread pointers instead
2580         of ptids.
2581         (switch_to_no_thread, switch_to_thread): Make extern.
2582         (scoped_restore_current_thread::~scoped_restore_current_thread):
2583         Use m_thread pointer directly.
2584         (scoped_restore_current_thread::scoped_restore_current_thread):
2585         Use inferior_thread.
2586         (thread_command): Use thread pointer directly.
2587         (thread_num_make_value_helper): Use inferior_thread.
2588         * top.c (execute_command): Use inferior_thread.
2589         * tui/tui-interp.c: Include "inferior.h".
2590         * varobj.c (varobj_create): Use inferior_thread.
2591         (value_of_root_1): Use find_thread_global_id instead of
2592         global_thread_id_to_ptid.
2593
2594 2018-06-21  Alan Hayward  <alan.hayward@arm.com>
2595
2596         * regcache.c (readable_regcache::read_part): Avoid memcpy when
2597         possible.
2598         (regcache::write_part): Likewise.
2599         (readable_regcache::cooked_read_part): Update comment.
2600         (readable_regcache::cooked_write_part): Likewise.
2601         * regcache.h: (readable_regcache::read_part): Likewise.
2602         (regcache::write_part): Likewise.
2603
2604 2018-06-21  Richard Bunt  <richard.bunt@arm.com>
2605             Dirk Schubert  <dirk.schubert@arm.com>
2606
2607         * aarch64-linux-nat.c (post_attach): New.
2608         (aarch64_linux_nat_target::post_attach): Override post_attach to
2609         record the number of hardware debug registers.
2610
2611 2018-06-20  Tom Tromey  <tom@tromey.com>
2612
2613         * python/py-param.c (add_setshow_generic): Make parameters const.
2614         (parmpy_init): Update.
2615
2616 2018-06-20  Simon Marchi  <simon.marchi@polymtl.ca>
2617
2618         * regcache.h (regcache_cooked_read_ftype): Rename to...
2619         (register_read_ftype): ...this, change type to function_view.
2620         (class reg_buffer) <save>: Remove src parameter.
2621         (readonly_detached_regcache) <readonly_detached_regcache>: Make
2622         parameter non-const in first overload.  Remove src parameter in
2623         second overload.
2624         * regcache.c (do_cooked_read): Remove.
2625         (readonly_detached_regcache::readonly_detached_regcache): Make
2626         parameter non-const, adjust call to other constructor.
2627         (reg_buffer::save): Remove src parameter.
2628         * frame.c (do_frame_register_read): Remove.
2629         (frame_save_as_regcache): Use lambda function.
2630         * ppc-linux-tdep.c (ppu2spu_unwind_register): Change type of src
2631         parameter to ppu2spu_data *.
2632         (ppu2spu_sniffer): Use lambda function.
2633
2634 2018-06-20  Simon Marchi  <simon.marchi@polymtl.ca>
2635
2636         * record-full.c (record_full_target::insert_breakpoint): Remove
2637         "struct" keyword, add const.
2638
2639 2018-06-19  Simon Marchi  <simon.marchi@ericsson.com>
2640
2641         * common/common-defs.h (PACKAGE_NAME, PACKAGE_VERSION,
2642         PACKAGE_STRING, PACKAGE_TARNAME): Undefine.
2643         * configure.ac: Remove AC_PREREQ, add missing quoting.
2644         * gnulib/configure.ac: Modernize usage of
2645         AC_INIT/AM_INIT_AUTOMAKE.  Remove AC_PREREQ.
2646         * gnulib/update-gnulib.sh (AUTOCONF_VERSION): Bump to 2.69.
2647         (AUTOMAKE_VERSION): Bump to 1.15.1.
2648         * configure: Re-generate.
2649         * config.in: Re-generate.
2650         * aclocal.m4: Re-generate.
2651         * gnulib/aclocal.m4: Re-generate.
2652         * gnulib/config.in: Re-generate.
2653         * gnulib/configure: Re-generate.
2654         * gnulib/import/Makefile.in: Re-generate.
2655
2656 2018-06-19  Pedro Alves  <palves@redhat.com>
2657
2658         * minsyms.c (msym_prefer_to_msym_type): New, factored out from ...
2659         (lookup_minimal_symbol_by_pc_section): ... here with
2660         gdb_assert_not_reached added.
2661
2662 2018-06-19  Pedro Alves  <palves@redhat.com>
2663
2664         * inline-frame.c (stopped_by_user_bp_inline_frame): Replace PC
2665         parameter with a block parameter.  Compare location's block symbol
2666         with the frame's block instead of addresses.
2667         (skip_inline_frames): Pass the current block instead of the
2668         frame's address.  Break out as soon as we determine the frame
2669         should not be skipped.
2670
2671 2018-06-18  Tom Tromey  <tom@tromey.com>
2672
2673         * solib-aix.c (solib_aix_get_section_offsets): Return
2674         unique_xmalloc_ptr.
2675         (solib_aix_solib_create_inferior_hook): Update.
2676
2677 2018-06-18  Tom Tromey  <tom@tromey.com>
2678
2679         * solib-darwin.c (darwin_current_sos): Use unique_xmalloc_ptr.
2680
2681 2018-06-18  Tom Tromey  <tom@tromey.com>
2682
2683         * solib-frv.c (frv_relocate_main_executable): Use
2684         unique_xmalloc_ptr.
2685         * solib-dsbt.c (dsbt_relocate_main_executable): Use
2686         unique_xmalloc_ptr.
2687
2688 2018-06-18  Tom Tromey  <tom@tromey.com>
2689
2690         * objfiles.h (inhibit_section_map_updates): Update.
2691         (resume_section_map_updates, resume_section_map_updates_cleanup):
2692         Remove.
2693         * solib-svr4.c (svr4_handle_solib_event): Update.
2694         * objfiles.c (inhibit_section_map_updates): Return
2695         scoped_restore_tmpl<int>.
2696         (resume_section_map_updates, resume_section_map_updates_cleanup):
2697         Remove.
2698
2699 2018-06-18  Tom Tromey  <tom@tromey.com>
2700
2701         * valprint.h (read_string): Update.
2702         * valprint.c (read_string): Change type of "buffer".
2703         (val_print_string): Update.
2704         * python/py-value.c (valpy_string): Update.
2705         * language.h (struct language_defn) <la_get_string>: Change
2706         type of "buffer".
2707         (default_get_string, c_get_string): Update.
2708         * language.c (default_get_string): Change type of "buffer".
2709         * guile/scm-value.c (gdbscm_value_to_string): Update.
2710         * c-lang.c (c_get_string): Change type of "buffer".
2711
2712 2018-06-18  Tom Tromey  <tom@tromey.com>
2713
2714         * ser-mingw.c (struct pipe_state_destroyer): New.
2715         (pipe_state_up): New typedef.
2716         (cleanup_pipe_state): Remove.
2717         (pipe_windows_open): Use pipe_state_up.  Don't release argv.
2718
2719 2018-06-18  Tom Tromey  <tom@tromey.com>
2720
2721         * rust-lang.h (rust_yyerror): Don't declare.
2722         * rust-lang.c (rust_language_defn): Update.
2723         * rust-exp.y (yyerror): Now static.
2724         * parse.c (parse_exp_in_context_1): Update.
2725         * p-lang.h (p_yyerror): Don't declare.
2726         * p-lang.c (p_language_defn): Update.
2727         * p-exp.y (yyerror): Now static.
2728         * opencl-lang.c (opencl_language_defn): Update.
2729         * objc-lang.c (objc_language_defn): Update.
2730         * m2-lang.h (m2_yyerror): Don't declare.
2731         * m2-lang.c (m2_language_defn): Update.
2732         * m2-exp.y (yyerror): Now static.
2733         * language.h (struct language_defn) <la_error>: Remove.
2734         * language.c (unk_lang_error): Remove.
2735         (unknown_language_defn, auto_language_defn): Remove.
2736         * go-lang.h (go_yyerror): Don't declare.
2737         * go-lang.c (go_language_defn): Update.
2738         * go-exp.y (yyerror): Now static.
2739         * f-lang.h (f_yyerror): Don't declare.
2740         * f-lang.c (f_language_defn): Update.
2741         * f-exp.y (yyerror): Now static.
2742         * d-lang.h (d_yyerror): Don't declare.
2743         * d-lang.c (d_language_defn): Update.
2744         * d-exp.y (yyerror): Now static.
2745         * c-lang.h (c_yyerror): Don't declare.
2746         * c-lang.c (c_language_defn, cplus_language_defn)
2747         (asm_language_defn, minimal_language_defn): Update.
2748         * c-exp.y (yyerror): Now static.
2749         * ada-lang.h (ada_yyerror): Don't declare.
2750         * ada-lang.c (ada_language_defn): Update.
2751         * ada-exp.y (yyerror): Now static.
2752
2753 2018-06-18  Alan Hayward  <alan.hayward@arm.com>
2754
2755         * aarch64-linux-nat.c (fetch_sveregs_from_thread): New function.
2756         (store_sveregs_to_thread): Likewise.
2757         (aarch64_linux_fetch_inferior_registers): Check for SVE.
2758         (aarch64_linux_store_inferior_registers): Likewise.
2759         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_get_sveregs): New
2760         function.
2761         (aarch64_sve_regs_copy_to_regcache): Likewise.
2762         (aarch64_sve_regs_copy_from_regcache): Likewise.
2763         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_sveregs): New
2764         declaration.
2765         (aarch64_sve_regs_copy_to_regcache): Likewise.
2766         (aarch64_sve_regs_copy_from_regcache): Likewise.
2767         (sve_context): Structure from Linux headers.
2768         (SVE_SIG_ZREGS_SIZE): Define from Linux headers.
2769         (SVE_SIG_ZREG_SIZE): Likewise.
2770         (SVE_SIG_PREG_SIZE): Likewise.
2771         (SVE_SIG_FFR_SIZE): Likewise.
2772         (SVE_SIG_REGS_OFFSET): Likewise.
2773         (SVE_SIG_ZREGS_OFFSET): Likewise.
2774         (SVE_SIG_ZREG_OFFSET): Likewise.
2775         (SVE_SIG_ZREGS_SIZE): Likewise.
2776         (SVE_SIG_PREGS_OFFSET): Likewise.
2777         (SVE_SIG_PREG_OFFSET): Likewise.
2778         (SVE_SIG_PREGS_SIZE): Likewise.
2779         (SVE_SIG_FFR_OFFSET): Likewise.
2780         (SVE_SIG_REGS_SIZE): Likewise.
2781         (SVE_SIG_CONTEXT_SIZE): Likewise.
2782         (SVE_PT_REGS_MASK): Likewise.
2783         (SVE_PT_REGS_FPSIMD): Likewise.
2784         (SVE_PT_REGS_SVE): Likewise.
2785         (SVE_PT_VL_INHERIT): Likewise.
2786         (SVE_PT_VL_ONEXEC): Likewise.
2787         (SVE_PT_REGS_OFFSET): Likewise.
2788         (SVE_PT_FPSIMD_OFFSET): Likewise.
2789         (SVE_PT_FPSIMD_SIZE): Likewise.
2790         (SVE_PT_SVE_ZREG_SIZE): Likewise.
2791         (SVE_PT_SVE_PREG_SIZE): Likewise.
2792         (SVE_PT_SVE_FFR_SIZE): Likewise.
2793         (SVE_PT_SVE_FPSR_SIZE): Likewise.
2794         (SVE_PT_SVE_FPCR_SIZE): Likewise.
2795         (__SVE_SIG_TO_PT): Likewise.
2796         (SVE_PT_SVE_OFFSET): Likewise.
2797         (SVE_PT_SVE_ZREGS_OFFSET): Likewise.
2798         (SVE_PT_SVE_ZREG_OFFSET): Likewise.
2799         (SVE_PT_SVE_ZREGS_SIZE): Likewise.
2800         (SVE_PT_SVE_PREGS_OFFSET): Likewise.
2801         (SVE_PT_SVE_PREG_OFFSET): Likewise.
2802         (SVE_PT_SVE_PREGS_SIZE): Likewise.
2803         (SVE_PT_SVE_FFR_OFFSET): Likewise.
2804         (SVE_PT_SVE_FPSR_OFFSET): Likewise.
2805         (SVE_PT_SVE_FPCR_OFFSET): Likewise.
2806         (SVE_PT_SVE_SIZE): Likewise.
2807         (SVE_PT_SIZE): Likewise.
2808         (HAS_SVE_STATE): New define.
2809
2810 2018-06-18  Alan Hayward  <alan.hayward@arm.com>
2811
2812         * nat/aarch64-sve-linux-sigcontext.h: New file.
2813         * nat/aarch64-sve-linux-ptrace.h (SVE_VQ_BYTES): Move to
2814         new files.
2815         (SVE_VQ_MIN): Likewise.
2816         (SVE_VQ_MAX): Likewise.
2817         (SVE_VL_MIN): Likewise.
2818         (SVE_VL_MAX): Likewise.
2819         (SVE_NUM_ZREGS): Likewise.
2820         (SVE_NUM_PREGS): Likewise.
2821         (sve_vl_valid): Likewise.
2822         (struct user_sve_header): Likewise.
2823
2824 2018-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2825             Richard Bunt <Richard.Bunt@arm.com>
2826
2827         * linux-nat.c (stop_wait_callback): Don't discard SIGSTOP if it
2828         was requested by GDB.
2829
2830 2018-06-15  Tom de Vries  <tdevries@suse.de>
2831
2832         * MAINTAINERS (Write After Approval): Add Tom de Vries.
2833
2834 2018-06-14  Simon Marchi  <simon.marchi@polymtl.ca>
2835
2836         * gnulib/update-gnulib.sh: Print expected versions of
2837         autoconf/aclocal.
2838
2839 2018-06-14  Simon Marchi  <simon.marchi@ericsson.com>
2840
2841         * arch-utils.c (default_type_align): Use type_length_units.
2842         * gdbtypes.c (type_align): Use type_length_units.
2843
2844 2018-06-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2845
2846         * cli/cli-script.c (_initialize_cli_script): Fix online documentation
2847         of 'define' command.
2848
2849 2018-06-14  Tom de Vries  <tdevries@suse.de>
2850
2851         PR cli/22573
2852         * infcmd.c (print_return_value_1): Use get_user_print_options instead of
2853         get_no_prettyformat_print_options.
2854
2855 2018-06-13  Simon Marchi  <simon.marchi@ericsson.com>
2856
2857         * sparc-nat.h: Include target.h.
2858         * sparc64-linux-nat.c (class sparc64_linux_nat_target)
2859         <fetch_registers>: Remove this argument in function call.
2860         <store_registers>: Remove this argument in function call, remove
2861         extra semicolon.
2862         <low_forget_process>: Call sparc64_forget_process instead of
2863         sparc_forget_process.
2864
2865 2018-06-13  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2866
2867         * procfs.c (_initialize_procfs): Use add_inf_child_target.
2868         (procfs_target::make_corefile_notes): Adjust to new
2869         target_read_alloc return type.
2870
2871 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2872             Stephen Roberts  <stephen.roberts@arm.com>
2873
2874         PR gdb/22882
2875         * infrun.c (fetch_inferior_event): If GDB is not proceeding then
2876         run INF_EXEC_COMPLETE handler, even when not calling normal_stop.
2877         Move should_notify_stop local into more inner scope.
2878
2879 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2880             Stephen Roberts  <stephen.roberts@arm.com>
2881
2882         PR gdb/22882
2883         * infrun.c (resume_1): Add call to mark_async_event_handler.
2884
2885 2018-06-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * infrun.c (do_target_wait): Change old version of $pc printed.
2888
2889 2018-06-11  Simon Marchi  <simon.marchi@ericsson.com>
2890
2891         * dwarf2read.c (read_index_from_section): Rename to...
2892         (read_gdb_index_from_section): ... this, update all callers.
2893         (dwarf2_read_index): Rename to...
2894         (dwarf2_read_gdb_index): ... this, update all callers.
2895
2896 2018-06-11  John David Anglin  <danglin@gcc.gnu.org>
2897
2898         * gdb/hppa-linux-nat.c
2899         (hppa_linux_nat_target::fetch_inferior_registers): Rename to
2900         hppa_linux_nat_target::fetch_registers.
2901
2902 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
2903
2904         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Add mappings.
2905         * aarch64-tdep.h (AARCH64_DWARF_SVE_VG): Add define.
2906         (AARCH64_DWARF_SVE_FFR): Likewise.
2907         (AARCH64_DWARF_SVE_P0): Likewise.
2908         (AARCH64_DWARF_SVE_Z0): Likewise.
2909
2910 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
2911
2912         * common/common-regcache.h (raw_compare): New function.
2913         * regcache.c (regcache::raw_compare): Likewise.
2914         * regcache.h (regcache::raw_compare): New declaration.
2915
2916 2018-06-11  Alan Hayward  <alan.hayward@arm.com>
2917
2918         * common/common-regcache.h (reg_buffer_common): New structure.
2919         * regcache.c (reg_buffer::invalidate): Move from detached_regcache.
2920         (reg_buffer::raw_supply): Likewise.
2921         (reg_buffer::raw_supply_integer): Likewise.
2922         (reg_buffer::raw_supply_zeroed): Likewise.
2923         (reg_buffer::raw_collect): Likewise.
2924         (reg_buffer::raw_collect_integer): Likewise.
2925         * regcache.h (reg_buffer::invalidate): Move from detached_regcache.
2926         (reg_buffer::raw_supply): Likewise.
2927         (reg_buffer::raw_supply_integer): Likewise.
2928         (reg_buffer::raw_supply_zeroed): Likewise.
2929         (reg_buffer::raw_collect): Likewise.
2930         (reg_buffer::raw_collect_integer): Likewise.
2931
2932 2018-06-10  Tom Tromey  <tom@tromey.com>
2933
2934         * remote.c (stop_reply_p): Remove typedef.  Don't declare queue.
2935         (class remote_state) <stop_reply_queue>: Now std::vector.
2936         (remote_state::~remote_state)
2937         (remote_target::stop_reply_queue_length): Update.
2938         (struct queue_iter_param, remove_child_of_pending_fork)
2939         (struct check_pending_event_prevents_wildcard_vcont_callback_data)
2940         (check_pending_event_prevents_wildcard_vcont_callback)
2941         (remove_stop_reply_for_inferior)
2942         (remove_stop_reply_of_remote_state)
2943         (remote_notif_remove_once_on_match)
2944         (stop_reply_match_ptid_and_ws)
2945         (remote_kill_child_of_pending_fork): Remove.
2946         (remote_target::remove_new_fork_children)
2947         (remote_target::check_pending_events_prevent_wildcard_vcont)
2948         (remote_target::discard_pending_stop_replies)
2949         (remote_target::discard_pending_stop_replies_in_queue)
2950         (remote_target::remote_notif_remove_queued_reply)
2951         (remote_target::queued_stop_reply)
2952         (remote_target::push_stop_reply, remote_target::peek_stop_reply)
2953         (remote_target::wait, remote_target::kill_new_fork_children)
2954         (remote_target::async): Update.
2955
2956 2018-06-10  Tom Tromey  <tom@tromey.com>
2957
2958         * record-full.c (record_full_arch_list_cleanups): Remove.
2959         (record_full_message): Use try/catch.
2960         (record_full_wait_cleanups): Remove.
2961         (record_full_wait_1): Use try/catch.
2962         (record_full_restore): Likewise.
2963
2964 2018-06-10  Tom Tromey  <tom@tromey.com>
2965
2966         * record-full.c (record_full_breakpoint_p): Remove typedef.  Don't
2967         declare VEC.  Add constructor.
2968         <in_target_beneath>: Now bool.
2969         (record_full_breakpoints): Now a std::vector, static.
2970         (record_full_sync_record_breakpoints)
2971         (record_full_init_record_breakpoints)
2972         (record_full_target::insert_breakpoint)
2973         (record_full_target::remove_breakpoint): Update.  Don't use XNEW.
2974
2975 2018-06-10  Simon Marchi  <simon.marchi@polymtl.ca>
2976
2977         * dwarf2read.c (process_cu_includes): Remove struct keyword.
2978         * serial.c (serial_interface_lookup): Remove struct keyword.
2979
2980 2018-06-10  Tom Tromey  <tom@tromey.com>
2981
2982         * procfs.c (procfs_target::xfer_partial): Use "beneath" as a
2983         method.
2984         * nto-procfs.c (nto_procfs_target::xfer_partial): Use "beneath" as
2985         a method.
2986         * go32-nat.c (go32_nat_target::xfer_partial): Use "beneath" as a
2987         method.
2988         * arm-linux-nat.c (arm_linux_nat_target::read_description): Use
2989         "beneath" as a method.
2990         * arm-fbsd-nat.c (arm_fbsd_nat_target::read_description):
2991         Use "beneath" as a method.
2992
2993 2018-06-10  Tom Tromey  <tom@tromey.com>
2994
2995         * tracefile.c (struct trace_file_writer_deleter): New.
2996         <operator()>: Rename from trace_file_writer_xfree.
2997         (trace_file_writer_up): New typedef.
2998         (tsave_command, trace_save_tfile, trace_save_ctf): Update.
2999
3000 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
3001
3002         * regcache.h (reg_buffer) <~reg_buffer>: Use default destructor.
3003         <m_registers, m_register_status>: Change type to
3004         std::unique_ptr.
3005         * regcache.c (reg_buffer::reg_buffer): Use new instead of
3006         XCNEWVEC.
3007
3008 2018-06-09  Simon Marchi  <simon.marchi@ericsson.com>
3009
3010         * common/common-regcache.h (enum register_status): Add
3011         underlying type "signed char".
3012         * regcache.h (reg_buffer) <m_register_status>: Change type to
3013         register_status *.
3014         * regcache.c (reg_buffer::reg_buffer): Alocate arrays of
3015         register_status instead of signed char.
3016         (reg_buffer::save): Use REG_UNKNOWN instead of 0.
3017         (reg_buffer::get_register_status): Remove cast.
3018         (readable_regcache::raw_read): Remove cast.
3019         (readable_regcache::cooked_read): Remove cast.
3020
3021 2018-06-09  Tom Tromey  <tom@tromey.com>
3022
3023         * source.c (reverse_search_command, forward_search_command): Use
3024         scoped_fd.
3025
3026 2018-06-09  Tom Tromey  <tom@tromey.com>
3027
3028         * serial.c (serial_ops_p): Remove typedef.  Don't declare VEC.
3029         (serial_ops_list): Now static, std::vector.
3030         (serial_interface_lookup, serial_add_interface): Update.
3031
3032 2018-06-09  Tom Tromey  <tom@tromey.com>
3033
3034         * dwarf2read.c (process_cu_includes): Update.
3035         (process_full_comp_unit): Update.
3036         * dwarf2read.h (struct dwarf2_per_objfile) <just_read_cus>: Now a
3037         std::vector.
3038
3039 2018-06-08  Paul Koning  <paul_koning@dell.com>
3040
3041         PR gdb/23252
3042
3043         * python/python.c (do_start_initialization):
3044         Avoid call to internal Python API.
3045         (init__gdb_module): New function.
3046
3047 2018-06-08  Gary Benson <gbenson@redhat.com>
3048
3049         * linux-thread-db.c (valprint.h): New include.
3050         (struct check_thread_db_info): New structure.
3051         (check_thread_db_on_load, tdb_testinfo): New static globals.
3052         (check_thread_db, check_thread_db_callback): New functions.
3053         (try_thread_db_load_1): Run integrity checks if requested.
3054         (maintenance_check_libthread_db): New function.
3055         (_initialize_thread_db): Register "maint check libthread-db"
3056         and "maint set/show check-libthread-db".
3057         * NEWS: Mention the above new commands.
3058
3059 2018-06-08  Tom Tromey  <tom@tromey.com>
3060
3061         * windows-nat.c (windows_nat_target::xfer_partial): "beneath" is
3062         now a method.
3063
3064 2018-06-08  Tom Tromey  <tom@tromey.com>
3065
3066         * btrace.c (parse_xml_raw): Use gdb::unique_xmalloc_ptr.
3067
3068 2018-06-08  Tom Tromey  <tom@tromey.com>
3069
3070         * common/btrace-common.h (struct btrace_data): Add constructor,
3071         destructor, move assignment operator.
3072         <empty, clear, fini>: New methods.
3073         <format>: Initialize.
3074         (btrace_data_init, btrace_data_fini, btrace_data_clear)
3075         (btrace_data_empty): Don't declare.
3076         * common/btrace-common.c (btrace_data_init): Remove.
3077         (btrace_data::fini): Rename from btrace_data_fini.
3078         (btrace_data::empty): Rename from btrace_data_empty.
3079         (btrace_data::clear): Rename from btrace_data_clear.  Return
3080         bool.
3081         * btrace.h (make_cleanup_btrace_data): Don't declare.
3082         * btrace.c (btrace_add_pc, btrace_stitch_trace, btrace_clear)
3083         (parse_xml_btrace): Update.
3084         (do_btrace_data_cleanup, make_cleanup_btrace_data): Remove.
3085         (maint_btrace_clear_packet_history_cmd): Update.
3086
3087 2018-06-07  Pedro Alves  <palves@redhat.com>
3088
3089         * target.h (target_ops) <beneath>: Now a method.  All references
3090         updated.
3091         (class target_stack): New.
3092         * target.c (g_target_stack): New.
3093         (g_current_top_target): Delete.
3094         (current_top_target): Get the top target out of g_target_stack.
3095         (target_stack::push, target_stack::unpush): New.
3096         (push_target, unpush_target): Reimplement.
3097         (target_is_pushed): Reimplement in terms of g_target_stack.
3098         (target_ops::beneath, target_stack::find_beneath): New.
3099
3100 2018-06-07  Pedro Alves  <palves@redhat.com>
3101
3102         * target.h (find_target_beneath): Delete declaration.
3103         * target.c (find_target_beneath): Delete definition.
3104         * aix-thread.c: All callers of find_target_beneath adjusted to
3105         call target_ops::beneath instead.
3106         * bsd-uthread.c: Likewise.
3107         * linux-thread-db.c: Likewise.
3108         * ravenscar-thread.c: Likewise.
3109         * sol-thread.c: Likewise.
3110         * spu-multiarch.c: Likewise.
3111
3112 2018-06-07  Pedro Alves  <palves@redhat.com>
3113
3114         * target.h (target_ops) <beneath>: Now a method.  All references
3115         updated.
3116         (target_ops) <m_beneath>: New.
3117         * target.c (target_ops::beneath): New.
3118         * corelow.c: Adjust all references to target_ops::beneath.
3119         * linux-thread-db.c: Likewise.
3120         * make-target-delegates: Likewise.
3121         * record-btrace.c: Likewise.
3122         * record-full.c: Likewise.
3123         * remote.c: Likewise.
3124         * target.c: Likewise.
3125         * target-delegates.c: Regenerate.
3126
3127 2018-06-07  Pedro Alves  <palves@redhat.com>
3128
3129         * target.h (target_stack): Delete.
3130         (current_top_target): Declare function.
3131         * target.c (target_stack): Delete.
3132         (g_current_top_target): New.
3133         (current_top_target): New function.
3134         * auxv.c: Use current_top_target instead of target_stack
3135         throughout.
3136         * avr-tdep.c: Likewise.
3137         * breakpoint.c: Likewise.
3138         * corefile.c: Likewise.
3139         * elfread.c: Likewise.
3140         * eval.c: Likewise.
3141         * exceptions.c: Likewise.
3142         * frame.c: Likewise.
3143         * gdbarch-selftests.c: Likewise.
3144         * gnu-v3-abi.c: Likewise.
3145         * ia64-tdep.c: Likewise.
3146         * ia64-vms-tdep.c: Likewise.
3147         * infcall.c: Likewise.
3148         * infcmd.c: Likewise.
3149         * infrun.c: Likewise.
3150         * linespec.c: Likewise.
3151         * linux-tdep.c: Likewise.
3152         * minsyms.c: Likewise.
3153         * ppc-linux-nat.c: Likewise.
3154         * ppc-linux-tdep.c: Likewise.
3155         * procfs.c: Likewise.
3156         * regcache.c: Likewise.
3157         * remote.c: Likewise.
3158         * rs6000-tdep.c: Likewise.
3159         * s390-linux-nat.c: Likewise.
3160         * s390-tdep.c: Likewise.
3161         * solib-aix.c: Likewise.
3162         * solib-darwin.c: Likewise.
3163         * solib-dsbt.c: Likewise.
3164         * solib-spu.c: Likewise.
3165         * solib-svr4.c: Likewise.
3166         * solib-target.c: Likewise.
3167         * sparc-tdep.c: Likewise.
3168         * sparc64-tdep.c: Likewise.
3169         * spu-tdep.c: Likewise.
3170         * symfile.c: Likewise.
3171         * symtab.c: Likewise.
3172         * target-descriptions.c: Likewise.
3173         * target-memory.c: Likewise.
3174         * target.c: Likewise.
3175         * target.h: Likewise.
3176         * tracefile-tfile.c: Likewise.
3177         * tracepoint.c: Likewise.
3178         * valops.c: Likewise.
3179         * valprint.c: Likewise.
3180         * value.c: Likewise.
3181         * windows-tdep.c: Likewise.
3182         * mi/mi-main.c: Likewise.
3183
3184 2018-06-07  Tom Tromey  <tom@tromey.com>
3185
3186         * valprint.h (build_address_symbolic): Declare.
3187         * printcmd.c (print_address_symbolic): Update.
3188         (build_address_symbolic): Change "name" and "filename" to
3189         std::string.
3190         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3191         Update.
3192         * defs.h (build_address_symbolic): Remove declaration.
3193
3194 2018-06-07  Alan Hayward  <alan.hayward@arm.com>
3195
3196         * aarch64-tdep.c (AARCH64_SVE_V0_REGNUM): Add define.
3197         (aarch64_vnv_type): Add function.
3198         (aarch64_pseudo_register_name): Add V regs for SVE.
3199         (aarch64_pseudo_register_type): Likewise.
3200         (aarch64_pseudo_register_reggroup_p): Likewise.
3201         (aarch64_pseudo_read_value_2): Use V0 offset for SVE
3202         (aarch64_pseudo_read_value): Add V regs for SVE.
3203         (aarch64_pseudo_write_2): Use V0 offset for SVE
3204         (aarch64_pseudo_write): Add V regs for SVE.
3205         * aarch64-tdep.h (struct gdbarch_tdep): Add vnv_type.
3206
3207 2018-06-06  Sergio Durigan Junior  <sergiodj@redhat.com>
3208
3209         * arch/aarch64.h (sve_vq_from_vl): Guard with #ifndef.
3210         (sve_vl_from_vq): Likewise.
3211
3212 2018-06-05  Tom Tromey  <tom@tromey.com>
3213
3214         * cli/cli-cmds.c (show_version): Update.
3215         * top.c (print_gdb_version): Add "interactive" parameter.
3216         Update.
3217         * main.c (captured_main_1): Update.
3218         * top.h (print_gdb_version): Add "interactive" parameter and a
3219         comment.
3220
3221 2018-06-05  David Malcolm  <dmalcolm@redhat.com>
3222
3223         * common/enum-flags.h: Add trailing semicolon to example in
3224         comment.
3225
3226 2018-06-05  Tom Tromey  <tom@tromey.com>
3227
3228         PR cli/12326:
3229         * NEWS: Add entry about pager.
3230         * utils.c (pagination_disabled_for_command): New global.
3231         (prompt_for_continue): Allow "c" response to prompt.
3232         (reinitialize_more_filter): Clear
3233         pagination_disabled_for_command.
3234         (fputs_maybe_filtered): Check pagination_disabled_for_command.
3235
3236 2018-06-04  Tom Tromey  <tom@tromey.com>
3237
3238         * ada-lang.h (ada_lookup_symbol_list): Update.
3239         * ada-lang.c (resolve_subexp): Update.
3240         (symbols_are_identical_enums): Change type of syms.  Remove nsyms
3241         parameter.
3242         (remove_extra_symbols, remove_irrelevant_renamings): Likewise.
3243         (ada_lookup_symbol_list_worker, ada_lookup_symbol_list): Change
3244         results parameter to std::vector.
3245         (ada_iterate_over_symbols, ada_lookup_symbol, get_var_value):
3246         Update.
3247         * ada-exp.y (block_lookup): Update.
3248         (select_possible_type_sym): Change type of syms.  Remove nsyms
3249         parameter.
3250         (write_var_or_type, write_name_assoc): Update.
3251
3252 2018-06-04  Joel Brobecker  <brobecker@adacore.com>
3253
3254         * windows-nat.c (windows_nat_target::xfer_partial): Return
3255         TARGET_XFER_E_IO if we need to delegate to the target beneath
3256         but BENEATH is NULL.
3257
3258 2018-06-04  Simon Marchi  <simon.marchi@ericsson.com>
3259
3260         * Makefile.in (config.status): Add configure.nat as a
3261         dependency.
3262
3263 2018-06-04  Tom Tromey  <tom@tromey.com>
3264
3265         * cp-name-parser.y (cpname_state): Add method declarations.
3266         (HANDLE_QUAL): Update.
3267         (cpname_state::d_grab, cpname_state::fill_comp)
3268         (cpname_state::make_operator, cpname_state::make_dtor)
3269         (cpname_state::make_builtin_type, cpname_state::make_name)
3270         (cpname_state::d_qualify, cpname_state::d_int_type)
3271         (cpname_state::d_unary, cpname_state::d_binary): Now methods.
3272         (%union): Move earlier.
3273
3274 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3275
3276         * elfread.c (elf_symfile_segments): Use ELF_SECTION_IN_SEGMENT.
3277
3278 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3279
3280         * aarch64-tdep.c (aarch64_pseudo_read_value_1): New helper func.
3281         (aarch64_pseudo_write_1): Likewise.
3282         (aarch64_pseudo_read_value): Use helper.
3283         (aarch64_pseudo_write): Likewise.
3284
3285 2018-06-04  Pedro Alves  <palves@redhat.com>
3286
3287         * darwin-nat.c (darwin_ops): Delete.
3288         (darwin_attach_pid): Use get_native_target.
3289
3290 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3291
3292         * aarch64-tdep.c (aarch64_get_tdesc_vq): Use uint64_t for VQ.
3293         * aarch64-tdep.h (struct gdbarch_tdep): Likewise.
3294
3295 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3296
3297         * aarch64-linux-nat.c (aarch64_linux_read_description): Support SVE.
3298         * aarch64-tdep.c (aarch64_get_tdesc_vq): New function.
3299         (aarch64_gdbarch_init): Check for SVE.
3300         * aarch64-tdep.h (gdbarch_tdep::has_sve): New function.
3301
3302 2018-06-04  Alan Hayward  <alan.hayward@arm.com>
3303
3304         * aarch64-tdep.c (aarch64_read_description): Use uint64_t for VQ.
3305         * aarch64-tdep.h (aarch64_read_description): Likewise.
3306         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3307         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3308         * features/aarch64-sve.c (create_feature_aarch64_sve): Likewise.
3309         * nat/aarch64-sve-linux-ptrace.c(aarch64_sve_get_vq): Likewise.
3310         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_get_vq): Likewise.
3311
3312 2018-06-02  Simon Marchi  <simon.marchi@ericsson.com>
3313
3314         * value.c (value_fetch_lazy_bitfield): New.
3315         (value_fetch_lazy_memory): New.
3316         (value_fetch_lazy_register): New.
3317         (value_fetch_lazy): Factor out to smaller functions.
3318
3319 2018-06-01  Tom Tromey  <tom@tromey.com>
3320
3321         * cp-name-parser.y (backslashable, represented): Now const.
3322
3323 2018-06-01  Tom Tromey  <tom@tromey.com>
3324
3325         * cp-name-parser.y: Include parser-defs.h.
3326         (parser_fprintf): Remove declaration.
3327
3328 2018-06-01  Tom Tromey  <tom@tromey.com>
3329
3330         * cp-name-parser.y: Use %pure-parser, %lex-param, and
3331         %parse-param.
3332         (lexptr, prev_lexptr, error_lexptr, global_errmsg, demangle_info)
3333         (global_result): Remove globals.
3334         (struct cpname_state): New.
3335         (yyparse): Don't declare.
3336         (yylex, yyerror): Move declarations after %union.
3337         (d_grab, fill_comp, make_operator, make_dtor, make_builtin_type)
3338         (make_name): Add state parameter.
3339         Update all callers.
3340         (d_qualify, d_int_type, d_unary, d_binary, parse_number) Add state
3341         parameter.
3342         (HANDLE_QUAL, HANDLE_SPECIAL, HANDLE_TOKEN2, HANDLE_TOKEN3):
3343         Update.
3344         (yylex): Add lvalp, state parameters.
3345         (yyerror): Add state parameter.
3346         (cp_demangled_name_to_comp): Update.
3347
3348 2018-06-01  Tom Tromey  <tom@tromey.com>
3349
3350         * cp-name-parser.y (parser_fprintf): Declare.
3351         (GDB_YY_REMAP_PREFIX): Define.
3352         Include yy-remap.h.  Don't redefine yy* identifiers.
3353
3354 2018-06-01  Tom Tromey  <tom@tromey.com>
3355
3356         * python/py-type.c (typy_legacy_template_argument): Update.
3357         * cp-support.h (cp_demangled_name_to_comp): Update.
3358         * cp-name-parser.y (cp_demangled_name_to_comp): Change errmsg
3359         parameter to be a "std::string *".
3360         (main): Update.
3361
3362 2018-06-01  H.J. Lu  <hongjiu.lu@intel.com>
3363
3364         * ada-lex.l: Include "diagnostics.h" instead of
3365         "common/diagnostics.h".
3366         * unittests/environ-selftests.c: Likewise.
3367         * common/diagnostics.h: Moved to ../include.
3368
3369 2018-06-01  Joel Brobecker  <brobecker@adacore.com>
3370
3371         * breakpoint.c (breakpoint_re_set): Temporarily force language_mode
3372         to language_mode_manual while calling breakpoint_re_set_one.
3373
3374 2018-06-01  Tom Tromey  <tom@tromey.com>
3375
3376         * valops.c (value_cast_structs, destructor_name_p): Update.
3377         * symtab.c (gdb_mangle_name): Update.
3378         * stabsread.c (define_symbol, read_cpp_abbrev, read_baseclasses):
3379         Update.
3380         * p-valprint.c (pascal_object_is_vtbl_ptr_type)
3381         (pascal_object_print_value_fields, pascal_object_print_value):
3382         Update.
3383         * p-typeprint.c (pascal_type_print_derivation_info): Update.
3384         * linespec.c (find_methods): Update.
3385         * gdbtypes.h (type_name_no_tag): Remove.
3386         (type_name_or_error): Rename from type_name_no_tag_or_error.
3387         * gdbtypes.c (type_name_no_tag): Remove.
3388         (type_name_or_error): Rename from type_name_no_tag_or_error.
3389         (lookup_struct_elt_type, check_typedef): Update.
3390         * expprint.c (print_subexp_standard): Update.
3391         * dwarf2read.c (dwarf2_add_field, load_partial_dies): Update.
3392         * d-namespace.c (d_lookup_nested_symbol): Update.
3393         * cp-valprint.c (cp_is_vtbl_ptr_type, cp_print_value_fields)
3394         (cp_print_class_member): Update.
3395         * cp-namespace.c (cp_lookup_nested_symbol): Update.
3396         * completer.c (add_struct_fields): Update.
3397         * c-typeprint.c (cp_type_print_derivation_info)
3398         (c_type_print_varspec_prefix, c_type_print_base_struct_union):
3399         Update.
3400         * ada-lang.c (parse_old_style_renaming, xget_renaming_scope)
3401         (ada_prefer_type, ada_is_exception_sym): Update.
3402
3403 2018-06-01  Tom Tromey  <tom@tromey.com>
3404
3405         * valops.c (enum_constant_from_type, value_namespace_elt)
3406         (value_maybe_namespace_elt): Update.
3407         * valarith.c (find_size_for_pointer_math): Update.
3408         * target-descriptions.c (make_gdb_type): Update.
3409         * symmisc.c (print_symbol): Update.
3410         * stabsread.c (define_symbol, read_type)
3411         (complain_about_struct_wipeout, add_undefined_type)
3412         (cleanup_undefined_types_1): Update.
3413         * rust-lang.c (rust_tuple_type_p, rust_slice_type_p)
3414         (rust_range_type_p, val_print_struct, rust_print_struct_def)
3415         (rust_internal_print_type, rust_composite_type)
3416         (rust_evaluate_funcall, rust_evaluate_subexp)
3417         (rust_inclusive_range_type_p): Update.
3418         * python/py-type.c (typy_get_tag): Update.
3419         * p-typeprint.c (pascal_type_print_base): Update.
3420         * mdebugread.c (parse_symbol, parse_type): Update.
3421         * m2-typeprint.c (m2_long_set, m2_record_fields, m2_enum):
3422         Update.
3423         * guile/scm-type.c (gdbscm_type_tag): Update.
3424         * go-lang.c (sixg_string_p): Update.
3425         * gnu-v3-abi.c (build_gdb_vtable_type, build_std_type_info_type):
3426         Update.
3427         * gdbtypes.h (struct main_type) <tag_name>: Remove.
3428         (TYPE_TAG_NAME): Remove.
3429         * gdbtypes.c (type_name_no_tag): Simplify.
3430         (check_typedef, check_types_equal, recursive_dump_type)
3431         (copy_type_recursive, arch_composite_type): Update.
3432         * f-typeprint.c (f_type_print_base): Update.  Print "Type" prefix
3433         in summary mode when needed.
3434         * eval.c (evaluate_funcall): Update.
3435         * dwarf2read.c (fixup_go_packaging, read_structure_type)
3436         (process_structure_scope, read_enumeration_type)
3437         (read_namespace_type, read_module_type, determine_prefix): Update.
3438         * cp-support.c (inspect_type): Update.
3439         * coffread.c (process_coff_symbol, decode_base_type): Update.
3440         * c-varobj.c (c_is_path_expr_parent): Update.
3441         * c-typeprint.c (c_type_print_base_struct_union): Update.
3442         (c_type_print_base_1): Update.  Print struct/class/union/enum in
3443         summary when using C language.
3444         * ax-gdb.c (gen_struct_ref, gen_namespace_elt)
3445         (gen_maybe_namespace_elt): Update.
3446         * ada-lang.c (ada_type_name): Simplify.
3447         (empty_record, ada_template_to_fixed_record_type_1)
3448         (template_to_static_fixed_type)
3449         (to_record_with_fixed_variant_part, ada_check_typedef): Update.
3450
3451 2018-06-01  Tom Tromey  <tom@tromey.com>
3452
3453         * dwarf2read.c (dwarf2_compute_name): Pass CU's language to
3454         c_print_type.
3455         * c-typeprint.c (c_print_type_1): Add "language" parameter.
3456         (c_print_type): Update.
3457         (c_print_type): New overload.
3458         (c_type_print_varspec_prefix, c_type_print_args)
3459         (c_type_print_varspec_suffix, c_print_type_no_offsets)
3460         (c_type_print_base_struct_union, c_type_print_base_1)
3461         (cp_type_print_method_args): Add "language" parameter.
3462         (c_type_print_base): Update.
3463         * c-lang.h (c_print_type): Add new overload.
3464
3465 2018-06-01  Tom Tromey  <tom@tromey.com>
3466
3467         * typeprint.h (c_type_print_varspec_suffix): Don't declare.
3468         * c-typeprint.c (c_type_print_varspec_suffix): Now static.
3469
3470 2018-06-01  Alan Hayward  <alan.hayward@arm.com>
3471
3472         * aarch64-tdep.c (aarch64_sve_register_names): New const
3473         var.
3474         * arch/aarch64.h (enum aarch64_regnum): Add SVE entries.
3475         (AARCH64_SVE_Z_REGS_NUM): New define.
3476         (AARCH64_SVE_P_REGS_NUM): Likewise.
3477         (AARCH64_SVE_NUM_REGS): Likewise.
3478
3479 2018-05-31  Uros Bizjak  <ubizjak@gmail.com>
3480
3481         * nat/linux-ptrace.h [__alpha__]
3482         (GDB_ARCH_IS_TRAP_BRKPT, GDB_ARCH_IS_TRAP_HWBKPT): Remove
3483         definitions.
3484
3485 2018-05-31  Maciej W. Rozycki  <macro@mips.com>
3486
3487         * arch-utils.c (gdbarch_info_fill): Set `default_byte_order' to
3488         the endianness selected.
3489         * NEWS: Document `set endian auto' mode operation update.
3490
3491 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
3492
3493         * Makefile.in: Add new header.
3494         * gdb/arch/aarch64.h (sve_vg_from_vl): New macro.
3495         (sve_vl_from_vg): Likewise.
3496         (sve_vq_from_vl): Likewise.
3497         (sve_vl_from_vq): Likewise.
3498         (sve_vq_from_vg): Likewise.
3499         (sve_vg_from_vq): Likewise.
3500         * configure.nat: Add new c file.
3501         * nat/aarch64-sve-linux-ptrace.c: New file.
3502         * nat/aarch64-sve-linux-ptrace.h: New file.
3503
3504 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
3505
3506         * aarch64-linux-nat.c (aarch64_linux_read_description):
3507         Add parmeter zero.
3508         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3509         Likewise.
3510         * aarch64-tdep.c (tdesc_aarch64_list): Add.
3511         (aarch64_read_description): Use VQ to index tdesc_aarch64_list.
3512         (aarch64_gdbarch_init): Add parmeter zero.
3513         * aarch64-tdep.h (aarch64_read_description): Add VQ parmeter.
3514         * arch/aarch64.c (aarch64_create_target_description): Check VQ.
3515         * arch/aarch64.h (aarch64_create_target_description): Add VQ.
3516         parmeter.
3517         * doc/gdb.texinfo: Describe SVE feature
3518         * features/aarch64-sve.c: New file.
3519
3520 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
3521
3522         PR gdb/23210
3523         * gdbarch.sh (significant_addr_bit): Default to zero when
3524         not set by target architecture.
3525         * gdbarch.c: Re-generated.
3526         * utils.c (address_significant): Update.
3527
3528 2018-05-30  Joel Brobecker  <brobecker@adacore.com>
3529
3530         * stack.c (func_command): Remove trailing newline in call to error.
3531
3532 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3533
3534         * regcache.h (regcache_raw_collect): Remove, update callers to
3535         use regcache::raw_collect.
3536         * regcache.c (regcache_raw_collect): Remove.
3537
3538 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3539
3540         * regcache.h (regcache_raw_supply): Remove, update callers to
3541         use detached_regcache::raw_supply.
3542         * regcache.c (regcache_raw_supply): Remove.
3543
3544 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3545
3546         * regcache.h (regcache_cooked_write_part): Remove, update
3547         callers to use regcache::cooked_write_part.
3548         * regcache.c (regcache_cooked_write_part): Remove.
3549
3550 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3551
3552         * regcache.h (regcache_cooked_read_part): Remove, update callers
3553         to use readable_regcache::cooked_read_part.
3554         * regcache.c (regcache_cooked_read_part): Remove.
3555
3556 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3557
3558         * regcache.h (regcache_cooked_read_value): Remove, update
3559         callers to use readable_regcache::cooked_read_value.
3560         * regcache.c (regcache_cooked_read_value): Remove.
3561
3562 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3563
3564         * regcache.h (regcache_cooked_write): Remove, update callers to
3565         use regcache::cooked_write.
3566         * regcache.c (regcache_cooked_write): Remove.
3567
3568 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3569
3570         * regcache.h (regcache_invalidate): Remove, update callers to
3571         use detached_regcache::invalidate instead.
3572         * regcache.c (regcache_invalidate): Remove.
3573
3574 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3575
3576         * regcache.h (regcache_raw_write_part): Remove, update callers
3577         to use regcache::raw_write_part instead.
3578         * regcache.c (regcache_raw_write_part): Remove.
3579
3580 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3581
3582         * regcache.h (regcache_raw_read_part): Remove, update callers to
3583         use readable_regcache::raw_read_part instead.
3584         * regcache.c (regcache_raw_read_part): Remove.
3585
3586 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3587
3588         * regcache.h (regcache_cooked_read): Remove, update callers to
3589         use readable_regcache::cooked_read instead.
3590         * regcache.c (regcache_cooked_read): Remove.
3591
3592 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3593
3594         * regcache.h (regcache_raw_write): Remove, update callers to use
3595         regcache::raw_write instead.
3596         * regcache.c (regcache_raw_write): Remove.
3597
3598 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3599
3600         * regcache.h (regcache_raw_read): Remove, update callers to use
3601         readable_regcache::raw_read instead.
3602         * regcache.c (regcache_raw_read): Remove.
3603
3604 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3605
3606         * regcache.h (regcache_raw_update): Remove, update callers to
3607         use readable_regcache::raw_update instead.
3608         * regcache.c (regcache_raw_update): Remove.
3609
3610 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3611
3612         * regcache.h (regcache_register_status): Remove, update callers
3613         to use reg_buffer::get_register_status directly instead.
3614         * regcache.c (regcache_register_status): Remove.
3615
3616 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3617
3618         * regcache.h (regcache_get_ptid): Remove, update all callers to
3619         call regcache::ptid instead.
3620         * regcache.c (regcache_get_ptid): Remove.
3621
3622 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
3623
3624         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
3625
3626 2018-05-30  Pedro Alves  <palves@redhat.com>
3627
3628         * common/common-exceptions.h (exception_rethrow): Use
3629         ATTRIBUTE_NORETURN.
3630
3631 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
3632
3633         * breakpoint.c (print_solib_event, check_status_catch_solib):
3634         Remove struct keyword in range-based for loops.
3635         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
3636         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
3637         Likewise.
3638         * linespec.c (find_superclass_methods, search_minsyms_for_name):
3639         Likewise.
3640         * symfile.c (addr_info_make_relative): Likewise.
3641         * thread.c (value_in_thread_stack_temporaries): Likewise.
3642
3643 2018-06-12  Weimin Pan  <weimin.pan@oracle.com>
3644
3645         PR gdb/16841
3646         * valops.c (value_struct_elt_for_reference): Call check_typedef on
3647         aggregate type to get its real type before accessing it.
3648
3649 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
3650
3651         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
3652         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
3653         * coff-pe-read.c (add_pe_forwarded_sym): Replace
3654         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
3655         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
3656         * jit.c (jit_breakpoint_re_set_internal): Likewise.
3657         * printcmd.c (info_address_command): Likewise.
3658
3659 2018-05-29  Tom Tromey  <tom@tromey.com>
3660
3661         * windows-nat.c (handle_exception): Update fall-through comment.
3662
3663 2018-05-29  Tom Tromey  <tom@tromey.com>
3664
3665         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
3666         (struct program_space) <added_solibs>: Now a std::vector.
3667         * breakpoint.c (print_solib_event): Update.
3668         (check_status_catch_solib): Update.
3669         * progspace.c (clear_program_space_solib_cache): Update.
3670         * solib.c (update_solib_list): Update.
3671
3672 2018-05-29  Tom Tromey  <tom@tromey.com>
3673
3674         * python/py-type.c (typy_richcompare): Update.
3675         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
3676         * gdbtypes.h (types_deeply_equal): Return bool.
3677         (types_equal): Likewise.
3678         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
3679         declare VEC.
3680         (check_types_equal): Change worklist to std::vector.  Return
3681         bool.
3682         (struct type_equality_entry): Add constructor.
3683         (compare_maybe_null_strings): Return bool.
3684         (check_types_worklist): Return bool.  Change worklist to
3685         std::vector.
3686         (types_deeply_equal): Use std::vector.
3687         (types_equal): Return bool.
3688         (compare_maybe_null_strings): Simplify.
3689
3690 2018-05-29  Tom Tromey  <tom@tromey.com>
3691
3692         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
3693
3694 2018-05-29  Tom Tromey  <tom@tromey.com>
3695
3696         * objc-lang.h: Don't include cp-support.h.
3697         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
3698         declare VEC.
3699
3700 2018-05-27  Tom Tromey  <tom@tromey.com>
3701
3702         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
3703
3704 2018-05-25  Tom Tromey  <tom@tromey.com>
3705
3706         * value.c (value::location): Initialize.
3707
3708 2018-05-25  Tom Tromey  <tom@tromey.com>
3709
3710         * dbxread.c (init_bincl_list): Remove.
3711         (bincl_list): Now a std::vector.
3712         (bincls_allocated, next_bincl): Remove.
3713         (free_bincl_list, do_free_bincl_list_cleanup)
3714         (make_cleanup_free_bincl_list): Remove.
3715         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
3716         unique_xmalloc_ptr.
3717         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
3718         (struct header_file_location): Add constructor.
3719         (add_bincl_to_list): Remove.
3720
3721 2018-05-25  Tom Tromey  <tom@tromey.com>
3722
3723         * tui/tui.c (tui_enable): Update.
3724         * mi/mi-interp.c (mi_interp::init): Update.
3725         * interps.h (class interp) <name>: New method.
3726         <m_name>: Rename from name.
3727         (~scoped_restore_interp): Update.
3728         * interps.c (interp::interp): Update.
3729         (interp_add, interp_set, interp_lookup_existing)
3730         (current_interp_named_p): Update.
3731
3732 2018-05-25  Tom Tromey  <tom@tromey.com>
3733
3734         * interps.c (interp_name): Remove.
3735         * mi/mi-interp.c (mi_interp::init): Update.
3736         * interps.h (interp_name): Remove.
3737         (~scoped_restore_interp): Update.
3738         * tui/tui.c (tui_enable): Update.
3739
3740 2018-05-25  Tom Tromey  <tom@tromey.com>
3741
3742         * utils.c (fputs_maybe_filtered): Update.
3743         * linespec.c (decode_line_full): Update.
3744         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
3745         (mi_print_breakpoint_for_event, mi_solib_loaded)
3746         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
3747         (mi_user_selected_context_changed): Update.
3748         * mi/mi-main.c (mi_execute_command): Update.
3749         * cli/cli-script.c (execute_control_command): Update.
3750         * python/python.c (execute_gdb_command): Update.
3751         * solib.c (info_sharedlibrary_command): Update.
3752         * interps.c (interp_ui_out): Remove.
3753         * interps.h (interp_ui_out): Remove.
3754
3755 2018-05-25  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
3758         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
3759         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
3760
3761 2018-05-25  Tom Tromey  <tom@tromey.com>
3762
3763         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
3764         * interps.c (interp_exec): Use scoped_restore.
3765
3766 2018-05-25  Tom Tromey  <tom@tromey.com>
3767
3768         * remote.c (remote_target::remote_file_get): Use
3769         gdb::byte_vector.
3770         (remote_target::remote_file_put): Likewise.
3771
3772 2018-05-25  Tom Tromey  <tom@tromey.com>
3773
3774         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
3775         a std::string.
3776         (get_pe_section_index, add_pe_exported_sym): Update.
3777         (read_pe_exported_syms): Use gdb::def_vector.
3778
3779 2018-05-25  Tom Tromey  <tom@tromey.com>
3780
3781         * frame.c (remove_prev_frame): Remove.
3782         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
3783
3784 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
3785
3786         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
3787         Remove prototypes.
3788         * mips-linux-nat.c (supply_fpregset): Always call
3789         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
3790         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
3791         `mips_fill_fpregset'.
3792         * mips-linux-tdep.c (mips_supply_fpregset)
3793         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
3794         (mips_fill_fpregset_wrapper): Remove functions.
3795         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
3796         (mips_linux_fpregset): Remove variable.
3797         (mips_linux_iterate_over_regset_sections): Use
3798         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
3799         (mips_linux_o32_sigframe_init): Remove comment.
3800
3801 2018-05-25  Pedro Alves  <palves@redhat.com>
3802
3803         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
3804         (struct readahead_cache, struct packet_reg, struct
3805         remote_arch_state, class remote_state): Move higher up in the
3806         file.
3807         (remote_target::m_remote_state): Now an object instead of a pointer.
3808         (remote_target::get_remote_state): Adjust.
3809
3810 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * stack.c (select_and_print_frame): Delete.
3813         (struct function_bounds): Move struct within function.
3814         (func_command): Most content moved into new function
3815         find_frame_for_function, use new function, print result, add
3816         function comment.
3817         (find_frame_for_function): New function, now returns a result.
3818
3819 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3820
3821         * stack.c (iterate_over_block_arg_vars): Fix comment.
3822         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
3823
3824 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3825
3826         PR gdb/23203
3827         * frame.c
3828         (scoped_restore_selected_frame::scoped_restore_selected_frame):
3829         Define.
3830         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
3831         Define.
3832         * frame.h (class scoped_restore_selected_frame): New class.
3833         * stack.c (print_frame_local_vars): Remove catching and rethrowing
3834         of any exception, use scoped_restore_selected_frame to restore the
3835         frame instead.
3836
3837 2018-05-24  Pedro Alves  <palves@redhat.com>
3838
3839         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
3840         override.
3841
3842 2018-05-23  Tom Tromey  <tom@tromey.com>
3843
3844         * complaints.c (struct complaints): Remove.
3845         (symfile_complaint_book): Remove.
3846         (series): New global.
3847         (complaint_internal): Update.
3848         (clear_complaints): Update.
3849
3850 2018-05-23  Tom Tromey  <tom@tromey.com>
3851
3852         * complaints.c (counters): New global.
3853         (struct complain): Remove.
3854         (struct complaints) <root>: Remove.
3855         (complaint_sentinel): Remove.
3856         (symfile_complaint_book): Update.
3857         (find_complaint) Remove.
3858         (complaint_internal, clear_complaints): Update.
3859
3860 2018-05-23  Tom Tromey  <tom@tromey.com>
3861
3862         * complaints.c (struct complain) <file, line>: Remove.
3863         (find_complaint): Remove file, line parameters.
3864         (complaint_internal): Update.
3865
3866 2018-05-23  Tom Tromey  <tom@tromey.com>
3867
3868         * complaints.c (vcomplaint): Remove.
3869         (complaint_internal) Merge in contents of vcomplaint.
3870
3871 2018-05-23  Tom Tromey  <tom@tromey.com>
3872
3873         * complaints.c (struct complaints) <explanation>: Remove.
3874         (symfile_explanations): Remove.
3875         (symfile_complaint_book): Update.
3876         (vcomplaint): Update.
3877         (struct explanation): Remove.
3878
3879 2018-05-23  Tom Tromey  <tom@tromey.com>
3880
3881         * complaints.c (symfile_complaints): Remove.
3882         (complaint_internal): Remove "complaints" parameter.
3883         (clear_complaints, vcomplaint): Remove "c" parameter.
3884         (get_complaints): Remove.
3885         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
3886         (dwarf2_debug_line_missing_file_complaint)
3887         (dwarf2_debug_line_missing_end_sequence_complaint)
3888         (dwarf2_complex_location_expr_complaint)
3889         (dwarf2_const_value_length_mismatch_complaint)
3890         (dwarf2_section_buffer_overflow_complaint)
3891         (dwarf2_macro_malformed_definition_complaint)
3892         (dwarf2_invalid_attrib_class_complaint)
3893         (create_addrmap_from_index, dw2_symtab_iter_next)
3894         (dw2_expand_marked_cus)
3895         (dw2_debug_names_iterator::find_vec_in_debug_names)
3896         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
3897         (create_debug_type_hash_table, init_cutu_and_read_dies)
3898         (partial_die_parent_scope, add_partial_enumeration)
3899         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
3900         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
3901         (read_import_statement, read_file_scope, create_dwo_cu_reader)
3902         (create_cus_hash_table, create_dwp_hash_table)
3903         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
3904         (dwarf2_rnglists_process, dwarf2_ranges_process)
3905         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
3906         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
3907         (handle_struct_member_die, process_structure_scope)
3908         (read_array_type, read_common_block, read_module_type)
3909         (read_tag_pointer_type, read_typedef, read_base_type)
3910         (read_subrange_type, load_partial_dies, partial_die_info::read)
3911         (partial_die_info::read, partial_die_info::read)
3912         (partial_die_info::read, read_checked_initial_length_and_offset)
3913         (dwarf2_string_attr, read_formatted_entries)
3914         (dwarf_decode_line_header)
3915         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
3916         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
3917         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
3918         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
3919         (get_signatured_type, get_DW_AT_signature_type)
3920         (decode_locdesc, file_file_name, consume_improper_spaces)
3921         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
3922         (dwarf_decode_macro_bytes, dwarf_decode_macros)
3923         (dwarf2_symbol_mark_computed, set_die_type)
3924         (read_attribute_value): Update.
3925         * stap-probe.c (handle_stap_probe, get_stap_base_address):
3926         Update.
3927         * dbxread.c (unknown_symtype_complaint)
3928         (lbrac_mismatch_complaint, repeated_header_complaint)
3929         (set_namestring, function_outside_compilation_unit_complaint)
3930         (read_dbx_symtab, process_one_symbol): Update.
3931         * gdbtypes.c (stub_noname_complaint): Update.
3932         * windows-nat.c (handle_unload_dll): Update.
3933         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
3934         (decode_base_type): Update.
3935         * xcoffread.c (bf_notfound_complaint, ef_complaint)
3936         (eb_complaint, record_include_begin, record_include_end)
3937         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
3938         (process_xcoff_symbol, read_symbol)
3939         (function_outside_compilation_unit_complaint)
3940         (scan_xcoff_symtab): Update.
3941         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
3942         * buildsym.c (finish_block_internal, make_blockvector)
3943         (end_symtab_get_static_block, augment_type_symtab): Update.
3944         * dtrace-probe.c (dtrace_process_dof)
3945         (dtrace_static_probe_ops::get_probes): Update.
3946         * complaints.h (struct complaint): Don't declare.
3947         (symfile_complaints): Remove.
3948         (complaint_internal): Remove "complaints" parameter.
3949         (complaint): Likewise.
3950         (clear_complaints): Likewise.
3951         * symfile.c (syms_from_objfile_1, finish_new_objfile)
3952         (reread_symbols): Update.
3953         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
3954         (dwarf2_frame_cache, decode_frame_entry): Update.
3955         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
3956         * objc-lang.c (lookup_objc_class, lookup_child_selector)
3957         (info_selectors_command): Update.
3958         * macrotab.c (macro_include, check_for_redefinition)
3959         (macro_undef): Update.
3960         * objfiles.c (filter_overlapping_sections): Update.
3961         * stabsread.c (invalid_cpp_abbrev_complaint)
3962         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
3963         (define_symbol, error_type, read_type, rs6000_builtin_type)
3964         (stabs_method_name_from_physname, read_member_functions)
3965         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
3966         (attach_fields_to_type, complain_about_struct_wipeout)
3967         (read_range_type, read_args, common_block_start)
3968         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
3969         Update.
3970         * mdebugread.c (index_complaint, unknown_ext_complaint)
3971         (basic_type_complaint, bad_tag_guess_complaint)
3972         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
3973         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
3974         (parse_procedure, parse_lines)
3975         (function_outside_compilation_unit_complaint)
3976         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
3977         (bad_tag_guess_complaint, reg_value_complaint): Update.
3978         * cp-support.c (demangled_name_complaint): Update.
3979         * macroscope.c (sal_macro_scope): Update.
3980         * dwarf-index-write.c (class debug_names): Update.
3981
3982 2018-05-23  Tom Tromey  <tom@tromey.com>
3983
3984         * complaints.c (clear_complaints): Remove "noisy" parameter.
3985         * complaints.h (clear_complaints): Update.
3986         * symfile.c (syms_from_objfile_1, finish_new_objfile)
3987         (reread_symbols): Update.
3988
3989 2018-05-23  Tom Tromey  <tom@tromey.com>
3990
3991         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
3992         SUBSEQUENT_MESSAGE.
3993         (vcomplaint, clear_complaints): Update.
3994         (symfile_explanations): Remove some messages.
3995
3996 2018-05-23  Tom Tromey  <tom@tromey.com>
3997
3998         * complaints.c (internal_complaint): Remove.
3999         * complaints.h (internal_complaint): Remove.
4000
4001 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
4002
4003         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
4004
4005 2018-05-22  Pedro Alves  <palves@redhat.com>
4006
4007         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
4008         (remote_fileio_badfd, remote_fileio_return_errno)
4009         (remote_fileio_return_success, remote_fileio_func_open)
4010         (remote_fileio_func_open, remote_fileio_func_close)
4011         (remote_fileio_func_read, remote_fileio_func_write)
4012         (remote_fileio_func_lseek, remote_fileio_func_rename)
4013         (remote_fileio_func_unlink, remote_fileio_func_stat)
4014         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
4015         (remote_fileio_func_isatty, remote_fileio_func_system): Add
4016         remote_target parameter.
4017         (remote_fio_func_map) <func>: Add remote_target parameter.
4018         (do_remote_fileio_request, remote_fileio_request):
4019         * remote-fileio.h (remote_fileio_request):
4020         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
4021         remote_target parameter.
4022         (remote_notif_process, handle_notification): Adjust to pass down
4023         the remote.
4024         (remote_notif_state_allocate): Add remote_target parameter.  Save
4025         it.
4026         * remote-notif.h (struct remote_target): Forward declare.
4027         (struct notif_client) <parse, ack, can_get_pending_events>: Add
4028         remote_target parameter.
4029         (struct remote_notif_state) <remote>: New field.
4030         (remote_notif_ack, remote_notif_parse): Add remote_target
4031         parameter.
4032         (remote_notif_state_allocate, remote_notif_state_allocate): Add
4033         remote_target parameter.
4034         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
4035         (threads_listing_context, rmt_thread_action, protocol_feature)
4036         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
4037         (packet_result, struct threads_listing_context, remote_state):
4038         Move definitions and declarations higher up.
4039         (remote_target) <~remote_target>: Declare.
4040         (remote_download_command_source, remote_file_put, remote_file_get)
4041         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
4042         (remote_hostio_pread_vFile, remote_hostio_send_command)
4043         (remote_hostio_set_filesystem, remote_hostio_open)
4044         (remote_hostio_close, remote_hostio_unlink, remote_state)
4045         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
4046         (get_memory_write_packet_size, get_memory_read_packet_size)
4047         (append_pending_thread_resumptions, remote_detach_1)
4048         (append_resumption, remote_resume_with_vcont)
4049         (add_current_inferior_and_thread, wait_ns, wait_as)
4050         (process_stop_reply, remote_notice_new_inferior)
4051         (process_initial_stop_replies, remote_add_thread)
4052         (btrace_sync_conf, remote_btrace_maybe_reopen)
4053         (remove_new_fork_children, kill_new_fork_children)
4054         (discard_pending_stop_replies, stop_reply_queue_length)
4055         (check_pending_events_prevent_wildcard_vcont)
4056         (discard_pending_stop_replies_in_queue, stop_reply)
4057         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
4058         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
4059         (remote_interrupt_as, remote_interrupt_ns)
4060         (remote_get_noisy_reply, remote_query_attached)
4061         (remote_add_inferior, remote_current_thread, get_current_thread)
4062         (set_thread, set_general_thread, set_continue_thread)
4063         (set_general_process, write_ptid)
4064         (remote_unpack_thread_info_response, remote_get_threadinfo)
4065         (parse_threadlist_response, remote_get_threadlist)
4066         (remote_threadlist_iterator, remote_get_threads_with_ql)
4067         (remote_get_threads_with_qxfer)
4068         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
4069         (get_offsets, remote_check_symbols, remote_supported_packet)
4070         (remote_query_supported, remote_packet_size)
4071         (remote_serial_quit_handler, remote_detach_pid)
4072         (remote_vcont_probe, remote_resume_with_hc)
4073         (send_interrupt_sequence, interrupt_query)
4074         (remote_notif_get_pending_events, fetch_register_using_p)
4075         (send_g_packet, process_g_packet, fetch_registers_using_g)
4076         (store_register_using_P, store_registers_using_G)
4077         (set_remote_traceframe, check_binary_download)
4078         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
4079         (remote_xfer_live_readonly_partial, remote_read_bytes)
4080         (remote_send_printf, remote_flash_write, readchar)
4081         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
4082         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
4083         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
4084         (extended_remote_disable_randomization, extended_remote_run)
4085         (send_environment_packet, extended_remote_environment_support)
4086         (extended_remote_set_inferior_cwd, remote_write_qxfer)
4087         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
4088         (packet_command): Now methods of ...
4089         (remote_target): ... this class.
4090         (m_remote_state) <remote_target>: New field.
4091         (struct remote_state) <stop_reply_queue,
4092         remote_async_inferior_event_token, wait_forever_enabled_p>: New
4093         fields.
4094         (remote_state::remote_state): Allocate stop_reply_queue.
4095         (remote_state): Delete global.
4096         (get_remote_state_raw): Delete.
4097         (remote_target::get_remote_state): Allocate m_remote_state on
4098         demand.
4099         (get_current_remote_target): New.
4100         (remote_ops, extended_remote_ops): Delete.
4101         (wait_forever_enabled_p, remote_async_inferior_event_token):
4102         Delete, moved to struct remote_state.
4103         (remote_target::close): Delete self.  Destruction bits split to
4104         ...
4105         (remote_target::~remote_target): ... this.
4106         (show_memory_packet_size): Adjust to use
4107         get_current_remote_target.
4108         (struct protocol_feature) <func>: Add remote_target parameter.
4109         All callers adjusted.
4110         (curr_quit_handler_target): New.
4111         (remote_serial_quit_handler): Reimplement.
4112         (remote_target::open_1): Adjust to use get_current_remote_target.
4113         Heap-allocate remote_target/extended_remote_target instances.
4114         (vcont_builder::vcont_builder): Add remote_target parameter, and
4115         save it in m_remote.  All callers adjusted.
4116         (vcont_builder::m_remote): New field.
4117         (vcont_builder::restart, vcont_builder::flush)
4118         (vcont_builder::push_action): Use it.
4119         (remote_target::commit_resume): Use it.
4120         (struct queue_iter_param) <remote>: New field.
4121         (remote_target::remove_new_fork_children): Fill in 'remote' field.
4122         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
4123         (check_pending_event_prevents_wildcard_vcont_callback)
4124         (remote_target::check_pending_events_prevent_wildcard_vcont)
4125         (remote_target::discard_pending_stop_replies)
4126         (remote_target::discard_pending_stop_replies_in_queue)
4127         (remote_target::remote_notif_remove_queued_reply): Fill in
4128         'remote' field.
4129         (remote_notif_get_pending_events): New.
4130         (remote_target::readchar, remote_target::remote_serial_write):
4131         Save/restore curr_quit_handler_target.
4132         (putpkt): New.
4133         (kill_new_fork_children): Fill in 'remote' field.
4134         (packet_command): Use get_current_remote_target, defer to
4135         remote_target method of same name.
4136         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
4137         parameter, and save it in m_remote.  All callers adjusted.
4138         (scoped_remote_fd::release): Use m_remote.
4139         (scoped_remote_fd::m_remote): New field.
4140         (remote_file_put, remote_file_get, remote_file_delete): Use
4141         get_current_remote_target, defer to remote_target method of same
4142         name.
4143         (remote_btrace_reset): Add remote_state paremeter.  Update all
4144         callers.
4145         (remote_async_inferior_event_handler). Pass down 'data'.
4146         (remote_new_objfile): Use get_current_remote_target.
4147         (remote_target::vcont_r_supported): New.
4148         (set_range_stepping): Use get_current_remote_target and
4149         remote_target::vcont_r_supported.
4150         (_initialize_remote): Don't allocate 'remote_state' and
4151         'stop_reply_queue' globals.
4152         * remote.h (struct remote_target): Forward declare.
4153         (getpkt, putpkt, remote_notif_get_pending_events): Add
4154         'remote_target' parameter.
4155
4156 2018-05-22  Pedro Alves  <palves@redhat.com>
4157
4158         * remote.c (vcont_builder): Now a class.  Make all data members
4159         private.
4160         (vcont_builder) <vcont_builder, restart, flush, push_action>:
4161         Declare methods.
4162         (vcont_builder_restart): Rename to ...
4163         (vcont_builder::restart): ... this.
4164         (vcont_builder_flush): Rename to ...
4165         (vcont_builder::flush): ... this.
4166         (vcont_builder_push_action): Rename to ...
4167         (vcont_builder::push_action): ... this.
4168         (remote_target::commit_resume): Adjust.
4169
4170 2018-05-22  Pedro Alves  <palves@redhat.com>
4171
4172         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
4173         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
4174         (get_fixed_memory_packet_size): New.
4175         (get_memory_packet_size): Use it.
4176         (set_memory_packet_size): Don't override the config size with
4177         DEFAULT_MAX_MEMORY_PACKET_SIZE.
4178         (show_memory_packet_size): Use get_fixed_memory_packet_size.
4179         Don't refer to get_memory_packet_size if not connected to a remote
4180         target.  Show "(default)" if configured size is 0.
4181
4182 2018-05-22  Pedro Alves  <palves@redhat.com>
4183
4184         * remote.c (remote_target::mourn_inferior): Move
4185         discard_pending_stop_replies call here from ...
4186         (_initialize_remote): ... here.
4187
4188 2018-05-22  Pedro Alves  <palves@redhat.com>
4189
4190         * remote.c (compare_section_command): Remove set_general_process
4191         call.
4192
4193 2018-05-22  Pedro Alves  <palves@redhat.com>
4194
4195         * remote.c (struct packet_reg, struct remote_arch_state):
4196         Move higher up in the file.
4197         (remote_state) <m_arch_states>: Store remote_arch_state values
4198         instead of remote_arch_state pointers.
4199         (remote_state::get_remote_arch_state): Adjust.
4200
4201 2018-05-22  Pedro Alves  <palves@redhat.com>
4202
4203         * remote.c: Include <unordered_map>.
4204         (remote_state): Now a class.
4205         (remote_state) <get_remote_arch_state>: Declare method.
4206         <get_remote_arch_state>: New field.
4207         (remote_arch_state) <remote_arch_state>: Declare ctor.
4208         <regs>: Now a unique_ptr.
4209         (remote_gdbarch_data_handle): Delete.
4210         (get_remote_arch_state): Delete.
4211         (remote_state::get_remote_arch_state): New.
4212         (get_remote_state): Adjust to call remote_state's
4213         get_remote_arch_state method.
4214         (init_remote_state): Delete, bits factored out to ...
4215         (remote_arch_state::remote_arch_state): ... this new method.
4216         (get_remote_packet_size, get_memory_packet_size)
4217         (process_g_packet, remote_target::fetch_registers)
4218         (remote_target::prepare_to_store, store_registers_using_G)
4219         (remote_target::store_registers, remote_target::get_trace_status):
4220         Adjust to call remote_state's method.
4221         (_initialize_remote): Remove reference to
4222         remote_gdbarch_data_handle.
4223
4224 2018-05-22  Pedro Alves  <palves@redhat.com>
4225
4226         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
4227         pread>: New method declarations.
4228         (remote_target::open_1): Adjust.
4229         (readahead_cache_invalidate): Rename to ...
4230         (readahead_cache::invalidate): ... this, and adjust to be a class
4231         method.
4232         (readahead_cache_invalidate_fd): Rename to ...
4233         (readahead_cache::invalidate_fd): ... this, and adjust to be a
4234         class method.
4235         (remote_hostio_pwrite): Adjust.
4236         (remote_hostio_pread_from_cache): Rename to ...
4237         (readahead_cache::pread): ... this, and adjust to be a class
4238         method.
4239         (remote_hostio_close): Adjust.
4240
4241 2018-05-22  Pedro Alves  <palves@redhat.com>
4242
4243         * remote.c (remote_hostio_close_cleanup): Delete.
4244         (class scoped_remote_fd): New.
4245         (remote_file_put, remote_file_get): Use it.
4246
4247 2018-05-22  Pedro Alves  <palves@redhat.com>
4248
4249         (struct vCont_action_support): Use bool and initialize all fields.
4250         (struct readahead_cache): Initialize all fields.
4251         (remote_state): Use bool and initialize all fields.
4252         (remote_state::remote_state, remote_state::~remote_state): New.
4253         (new_remote_state): Delete.
4254         (_initialize_remote): Use new to allocate remote_state.
4255
4256 2018-05-22  Pedro Alves  <palves@redhat.com>
4257             張俊芝  <zjz@zjz.name>
4258
4259         PR gdb/22973
4260         * c-exp.y: Include "c-support.h".
4261         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
4262         of tolower.  Use c_ident_is_alpha to scan names.
4263         * c-lang.c: Include "c-support.h".
4264         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
4265         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
4266         * c-support.h: New file, with bits factored out from ...
4267         * cp-name-parser.y: ... this file.
4268         Include "c-support.h".
4269         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
4270         c-support.h and renamed.
4271         (symbol_end, yylex): Adjust.
4272
4273 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4274
4275         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
4276         parameter type to CORE_ADDR.
4277         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
4278         parameter type in declaration to CORE_ADDR.
4279         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
4280         target_auxv_search to get AT_HWCAP and use the result to get the
4281         target description.
4282         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
4283         to CORE_ADDR. Remove the cast of the return value to unsigned
4284         long. Fix error predicate of target_auxv_search.
4285         (ppc_linux_nat_target::read_description): Change the type of the
4286         hwcap variable to CORE_ADDR.
4287
4288 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4289
4290         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
4291         if the size of fpscr is larger than 32 bits.
4292
4293 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4294
4295         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
4296         (ppc32_linux_vsxregmap): New global.
4297         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
4298         regcache_supply_regset, and regcache_collect_regset.
4299         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
4300         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
4301         (fetch_vsx_register, store_vsx_register): Remove.
4302         (fetch_vsx_registers): Add regno parameter. Get regset using
4303         ppc_linux_vsxregset. Use regset to supply registers.
4304         (store_vsx_registers): Add regno parameter. Get regset using
4305         ppc_linux_vsxregset. Use regset to collect registers.
4306         (fetch_register): Call fetch_vsx_registers instead of
4307         fetch_vsx_register.
4308         (store_register): Call store_vsx_registers instead of
4309         store_vsx_register.
4310         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
4311         new regno parameter.
4312         (store_ppc_registers): Call store_vsx_registers with -1 for the
4313         new regno parameter.
4314         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
4315         (ppc_collect_vsxregset): Remove.
4316
4317 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4318
4319         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
4320         offset fields.
4321         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
4322         for vector register offset fields.
4323         (ppc64_fbsd_reg_offsets): Likewise.
4324         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
4325         to vector register offset fields.
4326         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
4327         to vector register offset fields.
4328         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
4329         vector register offset fields.
4330         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
4331         initializers for vector register offset fields.
4332         (rs6000_aix64_reg_offsets): Likewise.
4333         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
4334         (ppc_supply_vrregset): Remove.
4335         (ppc_collect_vrregset): Remove.
4336         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
4337         (ppc_linux_vrregset) : New function.
4338         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
4339         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
4340         (ppc32_linux_vrregset): Remove.
4341         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
4342         and use result instead of ppc32_linux_vrregset.
4343         (ppc32_linux_reg_offsets): Remove initializers for vector register
4344         offset fields.
4345         (ppc64_linux_reg_offsets): Likewise.
4346         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
4347         * ppc-linux-nat.c: Include regset.h.
4348         (gdb_vrregset_t): Adjust comment to account for little-endian
4349         mode.
4350         (supply_vrregset, fill_vrregset): Remove.
4351         (fetch_altivec_register, store_altivec_register): Remove.
4352         (fetch_altivec_registers): Add regno parameter. Get regset using
4353         ppc_linux_vrregset. Use regset to supply registers.
4354         (store_altivec_registers): Add regno parameter. Get regset using
4355         ppc_linux_vrregset. Use regset to collect registers.
4356         (fetch_register): Call fetch_altivec_registers instead of
4357         fetch_altivec_register.
4358         (store_register): Call store_altivec_registers instead of
4359         store_altivec_register.
4360         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
4361         the new regno parameter.
4362         (store_ppc_registers): Call store_altivec_registers with -1 for
4363         the new regno parameter.
4364
4365 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4366
4367         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
4368         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
4369         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
4370         (gdb_vrregset_t): Change array type size to
4371         PPC_LINUX_SIZEOF_VRREGSET.
4372         (gdb_vsxregset_t): Change array type size to
4373         PPC_LINUX_SIZEOF_VSXREGSET.
4374         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
4375         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
4376         PPC_LINUX_SIZEOF_VSXREGSET.
4377
4378 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4379
4380         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
4381         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
4382         nat/ppc-linux.c.
4383         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
4384         ppc_linux_target_wordsize with tid.
4385         (ppc_linux_nat_target::read_description): Call ppc_linux_target
4386         wordsize with tid.
4387         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
4388         (ppc64_64bit_inferior_p): Add static and inline specifiers.
4389         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
4390         tid parameter. Remove static specifier.
4391         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
4392         (ppc_linux_target_wordsize): New declaration.
4393
4394 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4395
4396         * arch/ppc-linux-common.c: New file.
4397         * arch/ppc-linux-common.h: New file.
4398         * arch/ppc-linux-tdesc.h: New file.
4399         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
4400         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
4401         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
4402         arch/ppc-linux-tdesc.h.
4403         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
4404         arch/ppc-linux-tdesc.h.
4405         (ppc_linux_nat_target::read_description): Remove target
4406         description matching code. Fill a ppc_linux_features struct and
4407         call ppc_linux_match_description with it. Move comment about ISA
4408         2.05 to ppc-linux-common.c.
4409         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
4410         arch/ppc-linux-tdesc.h.
4411         (ppc_linux_core_read_description): Remove target description
4412         matching code. Fill a ppc_linux_features struct and call
4413         ppc_linux_match_description with it.
4414         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
4415         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
4416         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
4417         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
4418         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
4419         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
4420         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
4421         (tdesc_powerpc_e500l): Remove.
4422
4423 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
4424
4425         * ada-lang.c (catch_assert_command): Pass empty string instead
4426         of NULL for excep_string argument.
4427
4428 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
4429
4430         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
4431         the width of the requested register exceeds the width of the
4432         `ptrace' data type.
4433
4434 2018-05-21  Tom Tromey  <tom@tromey.com>
4435
4436         * printcmd.c (output_command): Remove.
4437         (output_command_const): Rename to output_command.
4438         * valprint.h (output_command): Rename from output_command_const.
4439         * tracepoint.c (trace_dump_actions): Call output_command.
4440
4441 2018-05-21  Tom Tromey  <tom@tromey.com>
4442
4443         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
4444         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
4445         * ada-lang.h (create_ada_exception_catchpoint): Update.
4446         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
4447         std::string.
4448         (create_excep_cond_exprs, ~ada_catchpoint)
4449         (should_stop_exception, print_one_exception)
4450         (print_mention_exception, print_recreate_exception): Update.
4451         (ada_get_next_arg): Remove.
4452         (catch_ada_exception_command_split): Use std::string.  Change type
4453         of "excep_string", "cond_string".
4454         (catch_ada_exception_command): Update.
4455         (create_ada_exception_catchpoint): Change type of excep_string.
4456         (ada_exception_sal): Remove excep_string parameter.
4457         (~ada_catchpoint): Remove.
4458
4459 2018-05-21  Tom Tromey  <tom@tromey.com>
4460
4461         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
4462         cleanup.
4463
4464 2018-05-21  Tom Tromey  <tom@tromey.com>
4465
4466         * ada-lang.c (ada_exception_message_1, ada_exception_message):
4467         Return unique_xmalloc_ptr.
4468         (print_it_exception): Update.
4469
4470 2018-05-21  Tom Tromey  <tom@tromey.com>
4471
4472         * tracepoint.c (trace_dump_actions): Use std::string.
4473
4474 2018-05-21  Tom Tromey  <tom@tromey.com>
4475
4476         * symfile.c (reread_symbols): Use std::string for original_name.
4477
4478 2018-05-21  Tom Tromey  <tom@tromey.com>
4479
4480         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
4481         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
4482         constructor.
4483
4484 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
4485
4486         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
4487         instance to...
4488         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
4489         * objfiles.c (get_objfile_bfd_data): Allocate
4490         objfile_per_bfd_storage with obstack_new when allocating on
4491         obstack.
4492
4493 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
4494
4495         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
4496         OBSTACK_ZALLOC.
4497         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
4498         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
4499         * mdebugread.c (mdebug_build_psymtabs): Likewise.
4500         (add_pending): Likewise.
4501         (parse_symbol): Likewise.
4502         (parse_partial_symbols): Likewise.
4503         (psymtab_to_symtab_1): Likewise.
4504         (new_psymtab): Likewise.
4505         (elfmdebug_build_psymtabs): Likewise.
4506         * minsyms.c (terminate_minimal_symbol_table): Likewise.
4507         * objfiles.c (get_objfile_bfd_data): Likewise.
4508         (objfile_register_static_link): Likewise.
4509         * psymtab.c (allocate_psymtab): Likewise.
4510         * stabsread.c (read_member_functions): Likewise.
4511         * xcoffread.c (xcoff_end_psymtab): Likewise.
4512
4513 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
4514
4515         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
4516         compiler supports std::is_trivially_constructible.
4517         * common/poison.h: Include obstack.h.
4518         (IsMallocable): Define to is_trivially_constructible if the
4519         compiler supports it, define to true_type otherwise.
4520         (xobnew): New.
4521         (XOBNEW): Redefine.
4522         (xobnewvec): New.
4523         (XOBNEWVEC): Redefine.
4524         * gdb_obstack.h (obstack_zalloc): New.
4525         (OBSTACK_ZALLOC): Redefine.
4526         (obstack_calloc): New.
4527         (OBSTACK_CALLOC): Redefine.
4528         (obstack_new): New.
4529         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
4530         (gdbarch_obstack): New declaration in gdbarch.h, definition in
4531         gdbarch.c.
4532         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
4533         obstack_calloc/obstack_zalloc.
4534         (gdbarch_obstack_zalloc): Remove.
4535         * target-descriptions.c (tdesc_data_init): Use obstack_new.
4536
4537 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4538
4539         * stack.c (backtrace_command_1): Remove useless variable int i.
4540
4541 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4542
4543         * stack.c (print_frame_info): Fix comment.
4544
4545 2018-05-18  Tom Tromey  <tom@tromey.com>
4546
4547         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
4548         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
4549         (~dwarf2_per_objfile): Update
4550         (dwarf2_get_dwz_file): Use new.
4551         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
4552         unique_ptr.
4553
4554 2018-05-18  Tom Tromey  <tom@tromey.com>
4555
4556         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
4557         unique_ptr.
4558         * dwarf2read.c (struct dwp_file): Add constructor and
4559         initializers.
4560         (open_and_init_dwp_file): Return a unique_ptr.
4561         (dwarf2_per_objfile, create_dwp_hash_table)
4562         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
4563         (lookup_dwo_unit_in_dwp): Update.
4564         (open_and_init_dwp_file, get_dwp_file): Update.
4565
4566 2018-05-18  Tom Tromey  <tom@tromey.com>
4567
4568         * dwarf2read.c (dwarf2_per_objfile): Update.
4569         (struct mapped_index): Add initializers.
4570         (dwarf2_read_index): Use new.
4571         (dw2_symtab_iter_init): Update.
4572         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
4573         unique_ptr.
4574
4575 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
4576
4577         * dwarf2read.c (mapped_index) <total_size>: Remove.
4578
4579 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
4580
4581         * unittests/format_pieces-selftests.c (test_format_specifier):
4582         Add ARI comments.
4583
4584 2018-05-18  Tom Tromey  <tom@tromey.com>
4585
4586         * c-typeprint.c (maybe_print_hole): New function.
4587         (c_print_type_struct_field_offset): Update.
4588         (c_type_print_base_struct_union): Call maybe_print_hole.
4589
4590 2018-05-17  Keith Seitz  <keiths@redhat.com>
4591
4592         * breakpoint.c (build_bpstat_chain): New function, moved from
4593         bpstat_stop_status.
4594         (bpstat_stop_status): Add optional parameter, `stop_chain'.
4595         If no stop chain is passed, call build_bpstat_chain to build it.
4596         * breakpoint.h (build_bpstat_chain): Declare.
4597         (bpstat_stop_status): Move documentation here from breakpoint.c.
4598         * infrun.c (handle_signal_stop): Before eliding inlined frames,
4599         build the stop chain and pass it to skip_inline_frames.
4600         Pass this stop chain to bpstat_stop_status.
4601         * inline-frame.c: Include breakpoint.h.
4602         (stopped_by_user_bp_inline_frame): New function.
4603         (skip_inline_frames): Add parameter `stop_chain'.
4604         Move documention to inline-frame.h.
4605         If non-NULL, use stopped_by_user_bp_inline_frame to determine
4606         whether the frame should be elided.
4607         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
4608         Add moved documentation and update for new parameter.
4609
4610 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
4611
4612         PR cli/14975
4613         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4614         unittests/format_pieces-selftests.c.
4615         * common/format.h (format_piece) <operator==>: New.
4616         (format_pieces) <operator[]>: Remove.
4617         * common/format.c (format_pieces::format_pieces): Handle \e.
4618         * unittests/format_pieces-selftests.c: New.
4619
4620 2018-05-17  Tom Tromey  <tom@tromey.com>
4621
4622         PR symtab/23010:
4623         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
4624         (dw2_instantiate_symtab): Add skip_partial parameter.
4625         (dw2_find_last_source_symtab, dw2_map_expand_apply)
4626         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
4627         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
4628         (dw2_expand_symtabs_matching_one)
4629         (dw2_find_pc_sect_compunit_symtab)
4630         (dw2_debug_names_lookup_symbol)
4631         (dw2_debug_names_expand_symtabs_for_function): Update.
4632         (init_cutu_and_read_dies): Add skip_partial parameter.
4633         (process_psymtab_comp_unit, build_type_psymtabs_1)
4634         (process_skeletonless_type_unit, load_partial_comp_unit)
4635         (psymtab_to_symtab_1): Update.
4636         (load_full_comp_unit): Add skip_partial parameter.
4637         (process_imported_unit_die, dwarf2_read_addr_index)
4638         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
4639         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
4640         (read_signatured_type): Update.
4641
4642 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
4643
4644         * value.c (release_value): Remove unused variable.
4645         (record_latest_value): Likewise.
4646         (access_value_history): Likewise.
4647         (preserve_values): Likewise.
4648
4649 2018-05-17  Tom Tromey  <tom@tromey.com>
4650
4651         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
4652         Initialize.
4653
4654 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
4655
4656         PR gdb/22286
4657         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
4658         Also handle registers whose width is not a multiple of
4659         PTRACE_TYPE_RET.
4660         (linux_nat_trad_target::store_register): Likewise.
4661
4662 2018-05-16  Tom Tromey  <tom@tromey.com>
4663
4664         * gdbcore.h (core_bfd): Redefine.
4665         * corelow.c (core_target::close): Update.
4666         (core_target_open): Update.
4667         * progspace.h (struct program_space) <cbfd>: Now a
4668         gdb_bfd_ref_ptr.
4669
4670 2018-05-16  Tom Tromey  <tom@tromey.com>
4671
4672         PR cli/19551:
4673         * symfile-add-flags.h (enum symfile_add_flags)
4674         <SYMFILE_NOT_FILENAME>: New constant.
4675         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
4676         objfile name from BFD.
4677         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
4678         * minidebug.c (find_separate_debug_file_in_section): Put
4679         ".gnu_debugdata" into BFD's file name.
4680
4681 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
4682
4683         * regcache.c (regcache_read_ftype, regcache_write_ftype):
4684         Remove.
4685
4686 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
4687
4688         PR binutils/21446
4689         * aarch64-tdep.c (aarch64_analyze_prologue,
4690         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
4691         Indicate not interested in errors.
4692
4693 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
4694
4695         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
4696         Supply the MIPS_ZERO_REGNUM register.
4697
4698 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
4699
4700         * mips-tdep.c (mask_address_var): Make variable static.
4701
4702 2018-05-14  Tom Tromey  <tom@tromey.com>
4703
4704         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
4705
4706 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4707
4708         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
4709         FXSAVE_ADDR for the mxcsr register.
4710
4711 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
4712
4713         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
4714
4715 2018-05-11  Pedro Alves  <palves@redhat.com>
4716
4717         * corelow.c (core_target) <core_target>: No longer inline.
4718         Initialize m_core_gdbarch, m_core_vec and build the section table
4719         here.
4720         <~core_target>: New.
4721         <core_gdbarch, get_core_register_section>: New methods.
4722         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
4723         factored out from ...
4724         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
4725         (core_ops): Delete.
4726         (sniff_core_bfd): Add gdbarch parameter.
4727         (core_close): Delete, merged into ...
4728         (core_target::close): ... here.  Delete self.
4729         (core_close_cleanup): Delete.
4730         (core_target_open): Allocate a core_target on the heap.  Use a
4731         unique_ptr instead of a cleanup.  Bits moved into the core_target
4732         ctor.  Adjust to use core_target methods instead of globals.
4733         (get_core_register_section): Rename to ...
4734         (core_target::get_core_register_section): ... this and adjust.
4735         (struct get_core_registers_cb_data): New.
4736         (get_core_registers_cb): Use it.  Use bool.
4737         (core_target::fetch_registers, core_target::files_info)
4738         (core_target::xfer_partial, core_target::read_description)
4739         (core_target::pid_to, core_target::thread_name): Adjust to
4740         reference class fields instead of globals.
4741         * target.h (struct target_ops_deleter, target_ops_up): New.
4742
4743 2018-05-11  Pedro Alves  <palves@redhat.com>
4744
4745         * corefile.c (core_file_command): Move to corelow.c.
4746         * corelow.c (the_core_target): Delete.
4747         (core_file_command): Moved from corefile.c.  Check exec_bfd
4748         instead of the_core_target.  Use target_detach instead of calling
4749         into the_core_target directly.
4750         (maybe_say_no_core_file_now): New.
4751         (core_target::detach): Use it.
4752         (_initialize_corelow): Remove references to the_core_target.
4753         * gdbcore.h (the_core_target): Delete.
4754
4755 2018-05-11  Tom Tromey  <tromey@redhat.com>
4756             Pedro Alves  <palves@redhat.com>
4757
4758         * corefile.c (core_bfd): Remove.
4759         * gdbcore.h (core_bfd): Now a macro.
4760         * progspace.h (struct program_space) <cbfd>: New field.
4761
4762 2018-05-11  Tom Tromey  <tom@tromey.com>
4763
4764         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
4765         gdb::def_vector.
4766
4767 2018-05-10  Tom Tromey  <tom@tromey.com>
4768
4769         * configure: Rebuild.
4770         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
4771
4772 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
4773
4774         PR server/23158:
4775         * regformats/regdat.sh: Adjust script, following the addition
4776         of the new expedite_regs parameter to init_target_desc.
4777
4778 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
4779
4780         PR gdb/23127
4781         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
4782         set_gdbarch_significant_addr_bit.
4783         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
4784         set_gdbarch_significant_addr_bit.
4785         * utils.c (address_significant): Update to sign extend addr.
4786
4787 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
4788
4789         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
4790         (xtensa_linux_init_abi): Limit tdep->num_regs by
4791         tdep->num_nopriv_regs.
4792         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
4793         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
4794         not initialized.
4795
4796 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
4797
4798         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
4799
4800 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4801
4802         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
4803         (I387_MXCSR_INIT_VAL): New constant.
4804         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
4805         buffer if it was supplied by the inferior.
4806         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
4807         (i387_xsave_get_clear_bv): New function.
4808         (i387_supply_xsave): Only read x87 control registers from the
4809         xsave buffer if the feature is enabled, and the state will have
4810         been written, otherwise, provide a suitable default.
4811         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
4812         including x87 control registers.  Update control registers if they
4813         have changed from the default value, and mark features as enabled
4814         as required.
4815         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
4816
4817 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
4818
4819         * spu-tdep.c (info_spu_event_command): Fix output formatting.
4820
4821 2018-05-07  Tom Tromey  <tom@tromey.com>
4822
4823         * configure: Rebuild.
4824         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
4825
4826 2018-05-07  Tom Tromey  <tom@tromey.com>
4827
4828         PR tdep/20362:
4829         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
4830         bit.  Use correct value for VDIV.
4831
4832 2018-05-04  Tom Tromey  <tom@tromey.com>
4833
4834         * configure: Rebuild.
4835         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
4836
4837 2018-05-04  Tom Tromey  <tom@tromey.com>
4838
4839         * linux-record.c (record_linux_system_call) <case
4840         RECORD_SYS_RECVFROM>: Add "break".
4841
4842 2018-05-04  Tom Tromey  <tom@tromey.com>
4843
4844         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
4845         Add missing "break".
4846         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
4847         Add missing "break".
4848
4849 2018-05-04  Tom Tromey  <tom@tromey.com>
4850
4851         * rs6000-tdep.c (ppc_process_record_op4)
4852         (ppc_process_record_op63): Add fall-through comment.
4853
4854 2018-05-04  Tom Tromey  <tom@tromey.com>
4855
4856         * i386-tdep.c (i386_process_record): Add fall-through comment.
4857
4858 2018-05-04  Tom Tromey  <tom@tromey.com>
4859
4860         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
4861         comment.
4862
4863 2018-05-04  Tom Tromey  <tom@tromey.com>
4864
4865         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
4866         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
4867         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
4868         comment.
4869         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
4870         comment.
4871         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
4872         comment.
4873
4874 2018-05-04  Tom Tromey  <tom@tromey.com>
4875
4876         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
4877
4878 2018-05-04  Tom Tromey  <tom@tromey.com>
4879
4880         * s390-tdep.c (s390_process_record): Fix fall-through comments.
4881         * xcoffread.c (scan_xcoff_symtab): Move comment later.
4882         * symfile.c (section_is_mapped): Fix fall-through comment.
4883         * stabsread.c (define_symbol, read_member_functions): Fix
4884         fall-through comment.
4885         * s390-linux-tdep.c (s390_process_record): Fix fall-through
4886         comment.
4887         * remote.c (remote_wait_as): Fix fall-through comment.
4888         * p-exp.y (yylex): Fix fall-through comment.
4889         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
4890         comment.
4891         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
4892         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
4893         * jv-exp.y (yylex): Fix fall-through comment.
4894         * go-exp.y (lex_one_token): Fix fall-through comment.
4895         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
4896         fall-through comment.
4897         * f-exp.y (yylex): Fix fall-through comment.
4898         * dwarf2read.c (process_die): Fix fall-through comments.
4899         * dbxread.c (process_one_symbol): Fix fall-through comment.
4900         * d-exp.y (lex_one_token): Fix fall-through comment.
4901         * cp-name-parser.y (yylex): Fix fall-through comment.
4902         * coffread.c (coff_symtab_read): Fix fall-through comment.
4903         * c-exp.y (lex_one_token): Fix fall-through comment.
4904         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
4905         comment.
4906         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
4907         comment.
4908
4909 2018-05-04  Tom Tromey  <tom@tromey.com>
4910
4911         PR python/22730:
4912         * NEWS: Mention gdb.execute change.
4913         * gdbcmd.h (execute_control_command): Don't declare.
4914         * python/python.c (execute_gdb_command): Use read_command_lines_1,
4915         execute_control_commands, execute_control_commands_to_string.
4916         * cli/cli-script.h (execute_control_commands)
4917         (execute_control_commands_to_string): Declare.
4918         (execute_control_command): Add from_tty parameter.
4919         * cli/cli-script.c (execute_control_commands)
4920         (execute_control_commands_to_string): New functions.
4921         (execute_user_command): Use execute_control_commands.
4922         (execute_control_command_1): Add "from_tty" parameter.  Update.
4923         (execute_control_command): Likewise.
4924
4925 2018-05-04  Tom Tromey  <tom@tromey.com>
4926
4927         PR python/22731:
4928         * NEWS: Mention that breakpoint commands are writable.
4929         * python/py-breakpoint.c (bppy_set_commands): New function.
4930         (breakpoint_object_getset) <"commands">: Use it.
4931
4932 2018-05-04  Tom Tromey  <tom@tromey.com>
4933
4934         * tracepoint.c (actions_command): Update.
4935         * mi/mi-cmd-break.c (mi_command_line_array)
4936         (mi_command_line_array_cnt, mi_command_line_array_ptr)
4937         (mi_read_next_line): Remove.
4938         (mi_cmd_break_commands): Update.
4939         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
4940         function_view.
4941         * cli/cli-script.c (get_command_line): Update.
4942         (process_next_line): Use function_view.  Constify.
4943         (recurse_read_control_structure, read_command_lines)
4944         (read_command_lines_1): Change argument types to function_view.
4945         (do_define_command, document_command): Update.
4946         * breakpoint.h (check_tracepoint_command): Don't declare.
4947         * breakpoint.c (check_tracepoint_command): Remove.
4948         (commands_command_1, create_tracepoint_from_upload): Update.
4949
4950 2018-05-04  Tom Tromey  <tom@tromey.com>
4951
4952         PR gdb/11750:
4953         * cli/cli-script.h (enum command_control_type) <define_control>:
4954         New constant.
4955         * cli/cli-script.c (multi_line_command_p): Handle define_control.
4956         (build_command_line, execute_control_command_1)
4957         (process_next_line): Likewise.
4958         (do_define_command): New function, extracted from define_command.
4959         (define_command): Use it.
4960
4961 2018-05-04  Tom Tromey  <tom@tromey.com>
4962
4963         * tracepoint.c (actions_command): Update.
4964         * cli/cli-script.h (read_command_lines): Update.
4965         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
4966         (MAX_TMPBUF): Remove define.
4967         (define_command): Use string_printf.
4968         (document_command): Likewise.
4969         * breakpoint.c (commands_command_1): Update.
4970
4971 2018-05-04  Tom Tromey  <tom@tromey.com>
4972
4973         * top.c (execute_command): Update.
4974         * cli/cli-script.h (print_command_lines): Now varargs.
4975         * cli/cli-script.c (print_command_lines): Now varargs.
4976         (execute_control_command_1) <case while_control, case if_control>:
4977         Update.
4978
4979 2018-05-04  Tom Tromey  <tom@tromey.com>
4980
4981         * tracepoint.c (all_tracepoint_actions): Rename from
4982         all_tracepoint_actions_and_cleanup.  Change return type.
4983         (actions_command, encode_actions_1, encode_actions)
4984         (trace_dump_actions, tdump_command): Update.
4985         * remote.c (remote_download_command_source): Update.
4986         * python/python.c (gdbpy_eval_from_control_command)
4987         (python_command, python_interactive_command): Update.
4988         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
4989         * guile/guile.c (guile_command)
4990         (gdbscm_eval_from_control_command, guile_command): Update.
4991         * compile/compile.c (compile_code_command)
4992         (compile_print_command, compile_to_object): Update.
4993         * cli/cli-script.h (struct command_lines_deleter): New.
4994         (counted_command_line): New typedef.
4995         (struct command_line): Add constructor, destructor.
4996         <body_list>: Remove.
4997         <body_list_0, body_list_1>: New members.
4998         (command_line_up): Remove typedef.
4999         (read_command_lines, read_command_lines_1, get_command_line):
5000         Update.
5001         (copy_command_lines): Don't declare.
5002         * cli/cli-script.c (build_command_line): Use "new".
5003         (get_command_line): Return counted_command_line.
5004         (print_command_lines, execute_user_command)
5005         (execute_control_command_1, while_command, if_command): Update.
5006         (realloc_body_list): Remove.
5007         (process_next_line, recurse_read_control_structure): Update.
5008         (read_command_lines, read_command_lines_1): Return counted_command_line.
5009         (free_command_lines): Use "delete".
5010         (copy_command_lines): Remove.
5011         (define_command, document_command, show_user_1): Update.
5012         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
5013         a counted_command_line.
5014         * breakpoint.h (counted_command_line): Remove typedef.
5015         (breakpoint_set_commands): Update.
5016         * breakpoint.c (check_no_tracepoint_commands)
5017         (validate_commands_for_breakpoint): Update.
5018         (breakpoint_set_commands): Change commands to be a
5019         counted_command_line.
5020         (commands_command_1, update_dprintf_command_list)
5021         (create_tracepoint_from_upload): Update.
5022
5023 2018-05-04  Tom Tromey  <tom@tromey.com>
5024
5025         * cli/cli-decode.h (cmd_list_element): New constructor.
5026         (~cmd_list_element): New destructor.
5027         (struct cmd_list_element): Add initializers.
5028         * cli/cli-decode.c (do_add_cmd): Use "new".
5029         (delete_cmd): Use "delete".
5030
5031 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
5032             Pedro Alves <palves@redhat.com>
5033
5034         PR breakpoints/19806 and support for PR external/20207.
5035         * NEWS: Mention Aarch64 watchpoint improvements.
5036         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
5037         watchpoints and PR external/20207 watchpoints.
5038         * nat/aarch64-linux-hw-point.c
5039         (kernel_supports_any_contiguous_range): New.
5040         (aarch64_watchpoint_offset): New.
5041         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
5042         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
5043         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
5044         (aarch64_align_watchpoint): New parameters aligned_offset_p and
5045         next_addr_orig_p.  Support PR external/20207 watchpoints.
5046         (aarch64_downgrade_regs): New.
5047         (aarch64_dr_state_insert_one_point): New parameters offset and
5048         addr_orig.
5049         (aarch64_dr_state_remove_one_point): Likewise.
5050         (aarch64_handle_breakpoint): Update caller.
5051         (aarch64_handle_aligned_watchpoint): Likewise.
5052         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
5053         aligned_offset.
5054         (aarch64_linux_set_debug_regs): Remove const from state.  Call
5055         aarch64_downgrade_regs.
5056         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
5057         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
5058         (DR_CONTROL_MASK): ... this.
5059         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
5060         (unsigned int aarch64_watchpoint_offset): New prototype.
5061         (aarch64_linux_set_debug_regs): Remove const from state.
5062         * utils.c (align_up, align_down): Move to ...
5063         * common/common-utils.c (align_up, align_down): ... here.
5064         * utils.h (align_up, align_down): Move to ...
5065         * common/common-utils.h (align_up, align_down): ... here.
5066
5067 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
5068
5069         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
5070         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
5071         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
5072         Re-implement to match the ABI as summarized in GCC's
5073         gcc/config/sparc/sparc.c.  All callers updated.
5074         (sparc32_store_arguments): Remove assertion.
5075
5076 2018-05-04  Tom Tromey  <tom@tromey.com>
5077
5078         * printcmd.c: Don't include tui.h.
5079         (decode_format): Use skip_spaces.
5080
5081 2018-05-04  Tom Tromey  <tom@tromey.com>
5082
5083         PR gdb/22619:
5084         * printcmd.c (last_count): New global.
5085         (x_command): Use saved count when repeating.
5086
5087 2018-05-04  Tom Tromey  <tom@tromey.com>
5088
5089         * nto-procfs.c (do_closedir_cleanup): Remove.
5090         (procfs_pidlist): Use gdb_dir_up.
5091         * procfs.c (do_closedir_cleanup): Remove.
5092         (proc_update_threads): Use gdb_dir_up.
5093         * common/filestuff.h (struct gdb_dir_deleter): New.
5094         (gdb_dir_up): New typedef.
5095
5096 2018-05-04  Tom Tromey  <tom@tromey.com>
5097
5098         * ada-lang.c (print_mention_exception): Use std::string.
5099
5100 2018-05-04  Tom Tromey  <tom@tromey.com>
5101
5102         * ada-lang.c (create_excep_cond_exprs): Update.
5103         (ada_exception_catchpoint_cond_string): Use std::string.
5104
5105 2018-05-04  Tom Tromey  <tom@tromey.com>
5106
5107         * ada-lang.c (xget_renaming_scope): Return std::string.
5108         (old_renaming_is_invisible): Update.
5109
5110 2018-05-04  Tom Tromey  <tom@tromey.com>
5111
5112         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
5113         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
5114
5115 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
5116
5117         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
5118
5119 2018-05-04  Tom Tromey  <tom@tromey.com>
5120
5121         * remote.c (remote_query_supported_append): Change type.
5122         (remote_check_symbols): Update.
5123
5124 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
5125
5126         PR gdb/11420
5127         * configure.ac: Prepend libpython.
5128         * python/python-config.py: Likewise.
5129         * configure: Regenerate.
5130
5131 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
5132
5133         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
5134
5135 2018-05-03  Pedro Alves  <palves@redhat.com>
5136
5137         * s390-linux-nat.c
5138         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
5139         override.  Write 'true' instead of '1'.
5140         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
5141         declaration.
5142
5143 2018-05-02  Pedro Alves  <palves@redhat.com>
5144
5145         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
5146         add_inf_child_target.
5147         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
5148         add_inf_child_target.
5149         * aix-thread.c (aix_thread_target_info): New.
5150         (aix_thread_target) <shortname, longname, doc>: Delete.
5151         <info>: New.
5152         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
5153         add_inf_child_target.
5154         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
5155         add_inf_child_target.
5156         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
5157         add_inf_child_target.
5158         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
5159         add_inf_child_target.
5160         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
5161         add_inf_child_target.
5162         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
5163         add_inf_child_target.
5164         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
5165         add_inf_child_target.
5166         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
5167         add_inf_child_target.
5168         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
5169         add_inf_child_target.
5170         * bfd-target.c (target_bfd_target_info): New.
5171         (target_bfd) <shortname, longname, doc>: Delete.
5172         <info>: New.
5173         * bsd-kvm.c (bsd_kvm_target_info): New.
5174         (bsd_kvm_target) <shortname, longname, doc>: Delete.
5175         <info>: New.
5176         (bsd_kvm_target::open): Rename to ...
5177         (bsd_kvm_target_open): ... this.  Adjust.
5178         * bsd-uthread.c (bsd_uthread_target_info): New.
5179         (bsd_uthread_target) <shortname, longname, doc>: Delete.
5180         <info>: New.
5181         * corefile.c (core_file_command): Adjust.
5182         * corelow.c (core_target_info): New.
5183         (core_target) <shortname, longname, doc>: Delete.
5184         <info>: New.
5185         (core_target::open): Rename to ...
5186         (core_target_open): ... this.  Adjust.
5187         * ctf.c (ctf_target_info): New.
5188         (ctf_target) <shortname, longname, doc>: Delete.
5189         <info>: New.
5190         (ctf_target::open): Rename to ...
5191         (ctf_target_open): ... this.
5192         (_initialize_ctf): Adjust.
5193         * exec.c (exec_target_info): New.
5194         (exec_target) <shortname, longname, doc>: Delete.
5195         <info>: New.
5196         (exec_target::open): Rename to ...
5197         (exec_target_open): ... this.
5198         * gdbcore.h (core_target_open): Declare.
5199         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
5200         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
5201         add_inf_child_target.
5202         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
5203         add_inf_child_target.
5204         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
5205         add_inf_child_target.
5206         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
5207         add_inf_child_target.
5208         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
5209         add_inf_child_target.
5210         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
5211         add_inf_child_target.
5212         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
5213         add_inf_child_target.
5214         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
5215         add_inf_child_target.
5216         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
5217         add_inf_child_target.
5218         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
5219         add_inf_child_target.
5220         * inf-child.c (inf_child_target_info): New.
5221         (inf_child_target::info): New.
5222         (inf_child_open_target): Remove 'target' parameter.  Use
5223         get_native_target instead.
5224         (inf_child_target::open): Delete.
5225         (add_inf_child_target): New.
5226         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
5227         Delete.
5228         <info>: New.
5229         (add_inf_child_target): Declare.
5230         (inf_child_open_target): Declare.
5231         * linux-thread-db.c (thread_db_target_info): New.
5232         (thread_db_target) <shortname, longname, doc>: Delete.
5233         <info>: New.
5234         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
5235         add_inf_child_target.
5236         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
5237         add_inf_child_target.
5238         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
5239         add_inf_child_target.
5240         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
5241         add_inf_child_target.
5242         * make-target-delegates (print_class): Adjust.
5243         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
5244         add_inf_child_target.
5245         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
5246         add_inf_child_target.
5247         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
5248         add_inf_child_target.
5249         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
5250         add_inf_child_target.
5251         * nto-procfs.c (nto_native_target_info): New.
5252         (nto_procfs_target_native) <shortname, longname, doc>:
5253         Delete.
5254         <info>: New.
5255         (nto_procfs_target_info): New.
5256         (nto_procfs_target_procfs) <shortname, longname, doc>:
5257         Delete.
5258         <info>: New.
5259         (init_procfs_targets): Adjust.
5260         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
5261         add_inf_child_target.
5262         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
5263         add_inf_child_target.
5264         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
5265         add_inf_child_target.
5266         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
5267         add_inf_child_target.
5268         * ravenscar-thread.c (ravenscar_target_info): New.
5269         (ravenscar_thread_target) <shortname, longname, doc>:
5270         Delete.
5271         <info>: New.
5272         * record-btrace.c (record_btrace_target_info):
5273         (record_btrace_target) <shortname, longname, doc>: Delete.
5274         <info>: New.
5275         (record_btrace_target::open): Rename to ...
5276         (record_btrace_target_open): ... this.  Adjust.
5277         * record-full.c (record_longname, record_doc): New.
5278         (record_full_base_target) <shortname, longname, doc>: Delete.
5279         <info>: New.
5280         (record_full_target_info): New.
5281         (record_full_target): <shortname>: Delete.
5282         <info>: New.
5283         (record_full_core_open_1, record_full_open_1): Update comments.
5284         (record_full_base_target::open): Rename to ...
5285         (record_full_open): ... this.
5286         (cmd_record_full_restore): Update.
5287         (_initialize_record_full): Update.
5288         * remote-sim.c (remote_sim_target_info): New.
5289         (gdbsim_target) <shortname, longname, doc>: Delete.
5290         <info>: New.
5291         (gdbsim_target::open): Rename to ...
5292         (gdbsim_target_open): ... this.
5293         (_initialize_remote_sim): Adjust.
5294         * remote.c (remote_doc): New.
5295         (remote_target_info): New.
5296         (remote_target) <shortname, longname, doc>: Delete.
5297         <info>: New.
5298         (extended_remote_target_info): New.
5299         (extended_remote_target) <shortname, longname, doc>: Delete.
5300         <info>: New.
5301         (remote_target::open_1): Make static.  Adjust.
5302         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
5303         * s390-linux-nat.c (_initialize_s390_nat): Use
5304         add_inf_child_target.
5305         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
5306         add_inf_child_target.
5307         * sol-thread.c (thread_db_target_info): New.
5308         (sol_thread_target) <shortname, longname, doc>: Delete.
5309         <info>: New.
5310         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
5311         add_inf_child_target.
5312         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
5313         add_inf_child_target.
5314         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
5315         add_inf_child_target.
5316         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
5317         add_inf_child_target.
5318         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
5319         add_inf_child_target.
5320         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
5321         add_inf_child_target.
5322         * spu-linux-nat.c (_initialize_spu_nat): Use
5323         add_inf_child_target.
5324         * spu-multiarch.c (spu_multiarch_target_info): New.
5325         (spu_multiarch_target) <shortname, longname, doc>: Delete.
5326         <info>: New.
5327         * target-delegates.c: Regenerate.
5328         * target.c: Include <unordered_map>.
5329         (target_ops_p): Delete.
5330         (DEF_VEC_P(target_ops_p)): Delete.
5331         (target_factories): New.
5332         (test_target_info): New.
5333         (test_target_ops::info): New.
5334         (open_target): Adjust to use target_factories.
5335         (add_target_with_completer): Rename to ...
5336         (add_target): ... this.  Change prototype.  Register target_info
5337         and open callback in target_factories.  Register target_info in
5338         command context instead of target_ops.
5339         (add_target): Delete old implementation.
5340         (add_deprecated_target_alias): Change prototype.  Adjust.
5341         (the_native_target): New.
5342         (set_native_target, get_native_target): New.
5343         (find_default_run_target): Use the_native_target.
5344         (find_attach_target, find_run_target): Simplify.
5345         (target_ops::open): Delete.
5346         (dummy_target_info): New.
5347         (dummy_target::shortname, dummy_target::longname)
5348         (dummy_target::doc): Delete.
5349         (dummy_target::info): New.
5350         (debug_target::shortname, debug_target::longname)
5351         (debug_target::doc): Delete.
5352         (debug_target::info): New.
5353         * target.h (struct target_info): New.
5354         (target_ops::~target_ops): Add comment.
5355         (target_ops::info): New.
5356         (target_ops::shortname, target_ops::longname, target_ops::doc): No
5357         longer virtual.  Implement in terms of target_info.
5358         (set_native_target, get_native_target): Declare.
5359         (target_open_ftype): New.
5360         (add_target, add_target_with_completer)
5361         (add_deprecated_target_alias): Change prototype.
5362         (test_target) <shortname, longname, doc>: Delete.
5363         <info>: New.
5364         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
5365         add_inf_child_target.
5366         * tracefile-tfile.c (tfile_target_info): New.
5367         (tfile_target) <shortname, longname, doc>: Delete.
5368         <info>: New.
5369         (tfile_target::open): Rename to ...
5370         (tfile_target_open): ... this.
5371         (_initialize_tracefile_tfile): Adjust.
5372         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
5373         add_inf_child_target.
5374         * windows-nat.c (_initialize_windows_nat): Use
5375         add_inf_child_target.
5376         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
5377         add_inf_child_target.
5378
5379 2018-05-02  Pedro Alves  <palves@redhat.com>
5380
5381         * linux-nat.h (linux_nat_target) <low_new_thread,
5382         low_delete_thread, low_new_fork, low_forget_process,
5383         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
5384         New virtual methods.
5385         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
5386         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
5387         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
5388         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
5389         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
5390         Delete.
5391         * linux-fork.c (delete_fork): Adjust to call low method.
5392         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
5393         (linux_nat_new_fork, linux_nat_forget_process_hook)
5394         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
5395         (linux_nat_status_is_event):
5396         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
5397         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
5398         to call low method.
5399         (sigtrap_is_event): Rename to ...
5400         (linux_nat_target::low_status_is_event): ... this.
5401         (linux_nat_set_status_is_event): Delete.
5402         (save_stop_reason, linux_nat_wait_1)
5403         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
5404         low methods.
5405         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
5406         (linux_nat_set_new_fork, linux_nat_set_forget_process)
5407         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
5408         (linux_nat_set_prepare_to_resume): Delete.
5409         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
5410         low virtual methods.
5411         * amd64-linux-nat.c: Likewise.
5412         * arm-linux-nat.c: Likewise.
5413         * i386-linux-nat.c: Likewise.
5414         * ia64-linux-nat.c: Likewise.
5415         * mips-linux-nat.c: Likewise.
5416         * ppc-linux-nat.c: Likewise.
5417         * s390-linux-nat.c: Likewise.
5418         * sparc64-linux-nat.c: Likewise.
5419         * x86-linux-nat.c: Likewise.
5420         * x86-linux-nat.h: Include "nat/x86-linux.h".
5421         (x86_linux_nat_target) <low_new_fork, low_forget_process,
5422         low_prepare_to_resume, low_new_thread, low_delete_thread>:
5423         Override methods.
5424
5425 2018-05-02  Pedro Alves  <palves@redhat.com>
5426
5427         * target.h (target_ops)
5428         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
5429         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
5430         stopped_by_watchpoint, have_continuable_watchpoint,
5431         stopped_data_address, watchpoint_addr_within_range,
5432         can_accel_watchpoint_condition, can_run, thread_alive,
5433         has_all_memory, has_memory, has_stack, has_registers,
5434         has_execution, can_async_p, is_async_p, supports_non_stop,
5435         always_non_stop_p, can_execute_reverse, supports_multi_process,
5436         supports_enable_disable_tracepoint,
5437         supports_disable_randomization, supports_string_tracing,
5438         supports_evaluation_of_breakpoint_conditions,
5439         can_run_breakpoint_commands, filesystem_is_local,
5440         can_download_tracepoint, get_trace_state_variable_value,
5441         set_trace_notes, get_tib_address, use_agent, can_use_agent,
5442         record_is_replaying, record_will_replay,
5443         augmented_libraries_svr4_read>: Adjust to return bool.
5444         * aarch64-linux-nat.c: All implementations adjusted.
5445         * aix-thread.c: All implementations adjusted.
5446         * arm-linux-nat.c: All implementations adjusted.
5447         * breakpoint.c: All implementations adjusted.
5448         * bsd-kvm.c: All implementations adjusted.
5449         * bsd-uthread.c: All implementations adjusted.
5450         * corelow.c: All implementations adjusted.
5451         * ctf.c: All implementations adjusted.
5452         * darwin-nat.c: All implementations adjusted.
5453         * darwin-nat.h: All implementations adjusted.
5454         * exec.c: All implementations adjusted.
5455         * fbsd-nat.c: All implementations adjusted.
5456         * fbsd-nat.h: All implementations adjusted.
5457         * gnu-nat.c: All implementations adjusted.
5458         * gnu-nat.h: All implementations adjusted.
5459         * go32-nat.c: All implementations adjusted.
5460         * ia64-linux-nat.c: All implementations adjusted.
5461         * inf-child.c: All implementations adjusted.
5462         * inf-child.h: All implementations adjusted.
5463         * inf-ptrace.c: All implementations adjusted.
5464         * inf-ptrace.h: All implementations adjusted.
5465         * linux-nat.c: All implementations adjusted.
5466         * linux-nat.h: All implementations adjusted.
5467         * mips-linux-nat.c: All implementations adjusted.
5468         * nto-procfs.c: All implementations adjusted.
5469         * ppc-linux-nat.c: All implementations adjusted.
5470         * procfs.c: All implementations adjusted.
5471         * ravenscar-thread.c: All implementations adjusted.
5472         * record-btrace.c: All implementations adjusted.
5473         * record-full.c: All implementations adjusted.
5474         * remote-sim.c: All implementations adjusted.
5475         * remote.c: All implementations adjusted.
5476         * s390-linux-nat.c: All implementations adjusted.
5477         * sol-thread.c: All implementations adjusted.
5478         * spu-multiarch.c: All implementations adjusted.
5479         * target-delegates.c: All implementations adjusted.
5480         * target.c: All implementations adjusted.
5481         * target.h: All implementations adjusted.
5482         * tracefile-tfile.c: All implementations adjusted.
5483         * tracefile.c: All implementations adjusted.
5484         * tracefile.h: All implementations adjusted.
5485         * windows-nat.c: All implementations adjusted.
5486         * x86-linux-nat.h: All implementations adjusted.
5487         * x86-nat.h: All implementations adjusted.
5488
5489 2018-05-02  Pedro Alves  <palves@redhat.com>
5490
5491         * make-target-delegates (scan_target_h): Don't trim lines here.
5492         Replace sequences of tabs and/or whitespace with a single
5493         whitespace.
5494         (top level, parsing methods): Trim each line before processing it
5495         here.
5496
5497 2018-05-02  Pedro Alves  <palves@redhat.com>
5498             John Baldwin  <jhb@freebsd.org>
5499
5500         * target.h (enum strata) <debug_stratum>: New.
5501         (struct target_ops) <all delegation methods>: Replace by C++
5502         virtual methods, and drop "to_" prefix.  All references updated
5503         throughout.
5504         <to_shortname, to_longname, to_doc, to_data,
5505         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
5506         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
5507         virtual methods.  All references updated throughout.
5508         <can_attach, supports_terminal_ours, can_create_inferior,
5509         get_thread_control_capabilities, attach_no_wait>: New
5510         virtual methods.
5511         <insert_breakpoint, remove_breakpoint>: Now
5512         TARGET_DEFAULT_NORETURN methods.
5513         <info_proc>: Now returns bool.
5514         <to_magic>: Delete.
5515         (OPS_MAGIC): Delete.
5516         (current_target): Delete.  All references replaced by references
5517         to ...
5518         (target_stack): ... this.  New.
5519         (target_shortname, target_longname): Adjust.
5520         (target_can_run): Now a function declaration.
5521         (default_child_has_all_memory, default_child_has_memory)
5522         (default_child_has_stack, default_child_has_registers)
5523         (default_child_has_execution): Remove target_ops parameter.
5524         (complete_target_initialization): Delete.
5525         (memory_breakpoint_target): New template class.
5526         (test_target_ops): Refactor as a C++ class with virtual methods.
5527         * make-target-delegates (NAME_PART): Tighten.
5528         (POINTER_PART, CP_SYMBOL): New.
5529         (SIMPLE_RETURN_PART): Reimplement.
5530         (VEC_RETURN_PART): Expect less.
5531         (RETURN_PART, VIRTUAL_PART): New.
5532         (METHOD): Adjust to C++ virtual methods.
5533         (scan_target_h): Remove reference to C99.
5534         (dname): Output "target_ops::" prefix.
5535         (write_function_header): Adjust to output a C++ class method.
5536         (write_declaration): New.
5537         (write_delegator): Adjust to output a C++ class method.
5538         (tdname): Output "dummy_target::" prefix.
5539         (write_tdefault, write_debugmethod): Adjust to output a C++ class
5540         method.
5541         (tdefault_names, debug_names): Delete.
5542         (return_types, tdefaults, styles, argtypes_array): New.
5543         (top level): All methods are delegators.
5544         (print_class): New.
5545         (top level): Print dummy_target and debug_target classes.
5546         * target-delegates.c: Regenerate.
5547         * target-debug.h (target_debug_print_enum_info_proc_what)
5548         (target_debug_print_thread_control_capabilities)
5549         (target_debug_print_thread_info_p): New.
5550         * target.c (dummy_target): Delete.
5551         (the_dummy_target, the_debug_target): New.
5552         (target_stack): Now extern.
5553         (set_targetdebug): Push/unpush debug target.
5554         (default_child_has_all_memory, default_child_has_memory)
5555         (default_child_has_stack, default_child_has_registers)
5556         (default_child_has_execution): Remove target_ops parameter.
5557         (complete_target_initialization): Delete.
5558         (add_target_with_completer): No longer call
5559         complete_target_initialization.
5560         (target_supports_terminal_ours): Use regular delegation.
5561         (update_current_target): Delete.
5562         (push_target): No longer check magic number.  Don't call
5563         update_current_target.
5564         (unpush_target): Don't call update_current_target.
5565         (target_is_pushed): No longer check magic number.
5566         (target_require_runnable): Skip for all stratums over
5567         process_stratum.
5568         (target_ops::info_proc): New.
5569         (target_info_proc): Use find_target_at and
5570         find_default_run_target.
5571         (target_supports_disable_randomization): Use regular delegation.
5572         (target_get_osdata): Use find_target_at.
5573         (target_ops::open, target_ops::close, target_ops::can_attach)
5574         (target_ops::attach, target_ops::can_create_inferior)
5575         (target_ops::create_inferior, target_ops::can_run)
5576         (target_can_run): New.
5577         (default_fileio_target): Use regular delegation.
5578         (target_ops::fileio_open, target_ops::fileio_pwrite)
5579         (target_ops::fileio_pread, target_ops::fileio_fstat)
5580         (target_ops::fileio_close, target_ops::fileio_unlink)
5581         (target_ops::fileio_readlink): New.
5582         (target_fileio_open_1, target_fileio_unlink)
5583         (target_fileio_readlink): Always call the target method.  Handle
5584         FILEIO_ENOSYS.
5585         (return_zero, return_zero_has_execution): Delete.
5586         (init_dummy_target): Delete.
5587         (dummy_target::dummy_target, dummy_target::shortname)
5588         (dummy_target::longname, dummy_target::doc)
5589         (debug_target::debug_target, debug_target::shortname)
5590         (debug_target::longname, debug_target::doc): New.
5591         (target_supports_delete_record): Use regular delegation.
5592         (setup_target_debug): Delete.
5593         (maintenance_print_target_stack): Skip debug_stratum.
5594         (initialize_targets): Instantiate the_dummy_target and
5595         the_debug_target.
5596         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
5597         use target_stack.
5598         (target_auxv_search, fprint_target_auxv): Adjust.
5599         (info_auxv_command): Adjust to use target_stack.
5600         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
5601         * exceptions.c (print_flush): Handle a NULL target_stack.
5602         * regcache.c (target_ops_no_register): Refactor as class with
5603         virtual methods.
5604
5605         * exec.c (exec_target): New class.
5606         (exec_ops): Now an exec_target.
5607         (exec_open, exec_close_1, exec_get_section_table)
5608         (exec_xfer_partial, exec_files_info, exec_has_memory)
5609         (exec_make_note_section): Refactor as exec_target methods.
5610         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
5611         Delete.
5612         (exec_target::find_memory_regions): New.
5613         (_initialize_exec): Don't call init_exec_ops.
5614         * gdbcore.h (exec_file_clear): Delete.
5615
5616         * corefile.c (core_target): Delete.
5617         (core_file_command): Adjust.
5618         * corelow.c (core_target): New class.
5619         (the_core_target): New.
5620         (core_close): Remove target_ops parameter.
5621         (core_close_cleanup): Adjust.
5622         (core_target::close): New.
5623         (core_open, core_detach, get_core_registers, core_files_info)
5624         (core_xfer_partial, core_thread_alive, core_read_description)
5625         (core_pid_to_str, core_thread_name, core_has_memory)
5626         (core_has_stack, core_has_registers, core_info_proc): Rework as
5627         core_target methods.
5628         (ignore, core_remove_breakpoint, init_core_ops): Delete.
5629         (_initialize_corelow): Initialize the_core_target.
5630         * gdbcore.h (core_target): Delete.
5631         (the_core_target): New.
5632
5633         * ctf.c: (ctf_target): New class.
5634         (ctf_ops): Now a ctf_target.
5635         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
5636         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
5637         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
5638         methods.
5639         (init_ctf_ops): Delete.
5640         (_initialize_ctf): Don't call it.
5641         * tracefile-tfile.c (tfile_target): New class.
5642         (tfile_ops): Now a tfile_target.
5643         (tfile_open, tfile_close, tfile_files_info)
5644         (tfile_get_tracepoint_status, tfile_trace_find)
5645         (tfile_fetch_registers, tfile_xfer_partial)
5646         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
5647         Refactor as tfile_target methods.
5648         (tfile_xfer_partial_features): Remove target_ops parameter.
5649         (init_tfile_ops): Delete.
5650         (_initialize_tracefile_tfile): Don't call it.
5651         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
5652         (tracefile_has_stack, tracefile_has_registers)
5653         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
5654         tracefile_target methods.
5655         (init_tracefile_ops): Delete.
5656         (tracefile_target::tracefile_target): New.
5657         * tracefile.h: Include "target.h".
5658         (tracefile_target): New class.
5659         (init_tracefile_ops): Delete.
5660
5661         * spu-multiarch.c (spu_multiarch_target): New class.
5662         (spu_ops): Now a spu_multiarch_target.
5663         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
5664         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
5665         (spu_search_memory, spu_mourn_inferior): Refactor as
5666         spu_multiarch_target methods.
5667         (init_spu_ops): Delete.
5668         (_initialize_spu_multiarch): Remove references to init_spu_ops,
5669         complete_target_initialization.
5670
5671         * ravenscar-thread.c (ravenscar_thread_target): New class.
5672         (ravenscar_ops): Now a ravenscar_thread_target.
5673         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
5674         (ravenscar_thread_alive, ravenscar_pid_to_str)
5675         (ravenscar_fetch_registers, ravenscar_store_registers)
5676         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
5677         (ravenscar_stopped_by_hw_breakpoint)
5678         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
5679         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
5680         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
5681         methods.
5682         (init_ravenscar_thread_ops): Delete.
5683         (_initialize_ravenscar): Remove references to
5684         init_ravenscar_thread_ops and complete_target_initialization.
5685
5686         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
5687         (bsd_uthread_target): New class.
5688         (bsd_uthread_ops): Now a bsd_uthread_target.
5689         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
5690         (bsd_uthread_close, bsd_uthread_mourn_inferior)
5691         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
5692         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
5693         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
5694         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
5695         (bsd_uthread_target): Delete function.
5696         (_initialize_bsd_uthread): Remove reference to
5697         complete_target_initialization.
5698
5699         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
5700         (target_bfd): ... this new class.
5701         (target_bfd_xfer_partial, target_bfd_get_section_table)
5702         (target_bfd_close): Refactor as target_bfd methods.
5703         (target_bfd::~target_bfd): New.
5704         (target_bfd_reopen): Adjust.
5705         (target_bfd::close): New.
5706
5707         * record-btrace.c (record_btrace_target): New class.
5708         (record_btrace_ops): Now a record_btrace_target.
5709         (record_btrace_open, record_btrace_stop_recording)
5710         (record_btrace_disconnect, record_btrace_close)
5711         (record_btrace_async, record_btrace_info)
5712         (record_btrace_insn_history, record_btrace_insn_history_range)
5713         (record_btrace_insn_history_from, record_btrace_call_history)
5714         (record_btrace_call_history_range)
5715         (record_btrace_call_history_from, record_btrace_record_method)
5716         (record_btrace_is_replaying, record_btrace_will_replay)
5717         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
5718         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
5719         (record_btrace_store_registers, record_btrace_prepare_to_store)
5720         (record_btrace_to_get_unwinder)
5721         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
5722         (record_btrace_commit_resume, record_btrace_wait)
5723         (record_btrace_stop, record_btrace_can_execute_reverse)
5724         (record_btrace_stopped_by_sw_breakpoint)
5725         (record_btrace_supports_stopped_by_sw_breakpoint)
5726         (record_btrace_stopped_by_hw_breakpoint)
5727         (record_btrace_supports_stopped_by_hw_breakpoint)
5728         (record_btrace_update_thread_list, record_btrace_thread_alive)
5729         (record_btrace_goto_begin, record_btrace_goto_end)
5730         (record_btrace_goto, record_btrace_stop_replaying_all)
5731         (record_btrace_execution_direction)
5732         (record_btrace_prepare_to_generate_core)
5733         (record_btrace_done_generating_core): Refactor as
5734         record_btrace_target methods.
5735         (init_record_btrace_ops): Delete.
5736         (_initialize_record_btrace): Remove reference to
5737         init_record_btrace_ops.
5738         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
5739         the execution_direction global.
5740         (record_full_base_target, record_full_target)
5741         (record_full_core_target): New classes.
5742         (record_full_ops): Now a record_full_target.
5743         (record_full_core_ops): Now a record_full_core_target.
5744         (record_full_target::detach, record_full_target::disconnect)
5745         (record_full_core_target::disconnect)
5746         (record_full_target::mourn_inferior, record_full_target::kill):
5747         New.
5748         (record_full_open, record_full_close, record_full_async): Refactor
5749         as methods of the record_full_base_target class.
5750         (record_full_resume, record_full_commit_resume): Refactor
5751         as methods of the record_full_target class.
5752         (record_full_wait, record_full_stopped_by_watchpoint)
5753         (record_full_stopped_data_address)
5754         (record_full_stopped_by_sw_breakpoint)
5755         (record_full_supports_stopped_by_sw_breakpoint)
5756         (record_full_stopped_by_hw_breakpoint)
5757         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
5758         methods of the record_full_base_target class.
5759         (record_full_store_registers, record_full_xfer_partial)
5760         (record_full_insert_breakpoint, record_full_remove_breakpoint):
5761         Refactor as methods of the record_full_target class.
5762         (record_full_can_execute_reverse, record_full_get_bookmark)
5763         (record_full_goto_bookmark, record_full_execution_direction)
5764         (record_full_record_method, record_full_info, record_full_delete)
5765         (record_full_is_replaying, record_full_will_replay)
5766         (record_full_goto_begin, record_full_goto_end, record_full_goto)
5767         (record_full_stop_replaying): Refactor as methods of the
5768         record_full_base_target class.
5769         (record_full_core_resume, record_full_core_kill)
5770         (record_full_core_fetch_registers)
5771         (record_full_core_prepare_to_store)
5772         (record_full_core_store_registers, record_full_core_xfer_partial)
5773         (record_full_core_insert_breakpoint)
5774         (record_full_core_remove_breakpoint)
5775         (record_full_core_has_execution): Refactor
5776         as methods of the record_full_core_target class.
5777         (record_full_base_target::supports_delete_record): New.
5778         (init_record_full_ops): Delete.
5779         (init_record_full_core_ops): Delete.
5780         (record_full_save): Refactor as method of the
5781         record_full_base_target class.
5782         (_initialize_record_full): Remove references to
5783         init_record_full_ops and init_record_full_core_ops.
5784
5785         * remote.c (remote_target, extended_remote_target): New classes.
5786         (remote_ops): Now a remote_target.
5787         (extended_remote_ops): Now an extended_remote_target.
5788         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
5789         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
5790         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
5791         (remote_pass_signals, remote_set_syscall_catchpoint)
5792         (remote_program_signals, )
5793         (remote_thread_always_alive): Remove target_ops parameter.
5794         (remote_thread_alive, remote_thread_name)
5795         (remote_update_thread_list, remote_threads_extra_info)
5796         (remote_static_tracepoint_marker_at)
5797         (remote_static_tracepoint_markers_by_strid)
5798         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
5799         (remote_open): Refactor as methods of remote_target.
5800         (extended_remote_open, extended_remote_detach)
5801         (extended_remote_attach, extended_remote_post_attach):
5802         (extended_remote_supports_disable_randomization)
5803         (extended_remote_create_inferior): : Refactor as method of
5804         extended_remote_target.
5805         (remote_set_permissions, remote_open_1, remote_detach)
5806         (remote_follow_fork, remote_follow_exec, remote_disconnect)
5807         (remote_resume, remote_commit_resume, remote_stop)
5808         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
5809         (remote_terminal_ours, remote_wait, remote_fetch_registers)
5810         (remote_prepare_to_store, remote_store_registers)
5811         (remote_flash_erase, remote_flash_done, remote_files_info)
5812         (remote_kill, remote_mourn, remote_insert_breakpoint)
5813         (remote_remove_breakpoint, remote_insert_watchpoint)
5814         (remote_watchpoint_addr_within_range)
5815         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
5816         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
5817         (remote_supports_stopped_by_sw_breakpoint)
5818         (remote_stopped_by_hw_breakpoint)
5819         (remote_supports_stopped_by_hw_breakpoint)
5820         (remote_stopped_by_watchpoint, remote_stopped_data_address)
5821         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
5822         (remote_verify_memory): Refactor as methods of remote_target.
5823         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
5824         parameter.
5825         (remote_xfer_partial, remote_get_memory_xfer_limit)
5826         (remote_search_memory, remote_rcmd, remote_memory_map)
5827         (remote_pid_to_str, remote_get_thread_local_address)
5828         (remote_get_tib_address, remote_read_description): Refactor as
5829         methods of remote_target.
5830         (remote_target::fileio_open, remote_target::fileio_pwrite)
5831         (remote_target::fileio_pread, remote_target::fileio_close): New.
5832         (remote_hostio_readlink, remote_hostio_fstat)
5833         (remote_filesystem_is_local, remote_can_execute_reverse)
5834         (remote_supports_non_stop, remote_supports_disable_randomization)
5835         (remote_supports_multi_process, remote_supports_cond_breakpoints)
5836         (remote_supports_enable_disable_tracepoint)
5837         (remote_supports_string_tracing)
5838         (remote_can_run_breakpoint_commands, remote_trace_init)
5839         (remote_download_tracepoint, remote_can_download_tracepoint)
5840         (remote_download_trace_state_variable, remote_enable_tracepoint)
5841         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
5842         (remote_trace_start, remote_get_trace_status)
5843         (remote_get_tracepoint_status, remote_trace_stop)
5844         (remote_trace_find, remote_get_trace_state_variable_value)
5845         (remote_save_trace_data, remote_get_raw_trace_data)
5846         (remote_set_disconnected_tracing, remote_core_of_thread)
5847         (remote_set_circular_trace_buffer, remote_traceframe_info)
5848         (remote_get_min_fast_tracepoint_insn_len)
5849         (remote_set_trace_buffer_size, remote_set_trace_notes)
5850         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
5851         (remote_disable_btrace, remote_teardown_btrace)
5852         (remote_read_btrace, remote_btrace_conf)
5853         (remote_augmented_libraries_svr4_read, remote_load)
5854         (remote_pid_to_exec_file, remote_can_do_single_step)
5855         (remote_execution_direction, remote_thread_handle_to_thread_info):
5856         Refactor as methods of remote_target.
5857         (init_remote_ops, init_extended_remote_ops): Delete.
5858         (remote_can_async_p, remote_is_async_p, remote_async)
5859         (remote_thread_events, remote_upload_tracepoints)
5860         (remote_upload_trace_state_variables): Refactor as methods of
5861         remote_target.
5862         (_initialize_remote): Remove references to init_remote_ops and
5863         init_extended_remote_ops.
5864
5865         * remote-sim.c (gdbsim_target): New class.
5866         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
5867         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
5868         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
5869         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
5870         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
5871         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
5872         Refactor as methods of gdbsim_target.
5873         (gdbsim_ops): Now a gdbsim_target.
5874         (init_gdbsim_ops): Delete.
5875         (gdbsim_cntrl_c): Adjust.
5876         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
5877
5878         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
5879         (the_amd64_linux_nat_target): New.
5880         (amd64_linux_fetch_inferior_registers)
5881         (amd64_linux_store_inferior_registers): Refactor as methods of
5882         amd64_linux_nat_target.
5883         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
5884         * i386-linux-nat.c: Don't include "linux-nat.h".
5885         (i386_linux_nat_target): New class.
5886         (the_i386_linux_nat_target): New.
5887         (i386_linux_fetch_inferior_registers)
5888         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
5889         as methods of i386_linux_nat_target.
5890         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
5891         * inf-child.c (inf_child_ops): Delete.
5892         (inf_child_fetch_inferior_registers)
5893         (inf_child_store_inferior_registers): Delete.
5894         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
5895         methods of inf_child_target.
5896         (inf_child_target::supports_terminal_ours)
5897         (inf_child_target::terminal_init)
5898         (inf_child_target::terminal_inferior)
5899         (inf_child_target::terminal_ours_for_output)
5900         (inf_child_target::terminal_ours, inf_child_target::interrupt)
5901         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
5902         New.
5903         (inf_child_open, inf_child_disconnect, inf_child_close)
5904         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
5905         (inf_child_post_startup_inferior, inf_child_can_run)
5906         (inf_child_pid_to_exec_file): Refactor as methods of
5907         inf_child_target.
5908         (inf_child_follow_fork): Delete.
5909         (inf_child_target::can_create_inferior)
5910         (inf_child_target::can_attach): New.
5911         (inf_child_target::has_all_memory, inf_child_target::has_memory)
5912         (inf_child_target::has_stack, inf_child_target::has_registers)
5913         (inf_child_target::has_execution): New.
5914         (inf_child_fileio_open, inf_child_fileio_pwrite)
5915         (inf_child_fileio_pread, inf_child_fileio_fstat)
5916         (inf_child_fileio_close, inf_child_fileio_unlink)
5917         (inf_child_fileio_readlink, inf_child_use_agent)
5918         (inf_child_can_use_agent): Refactor as methods of
5919         inf_child_target.
5920         (return_zero, inf_child_target): Delete.
5921         (inf_child_target::inf_child_target): New.
5922         * inf-child.h: Include "target.h".
5923         (inf_child_target): Delete function prototype.
5924         (inf_child_target): New class.
5925         (inf_child_open_target, inf_child_mourn_inferior)
5926         (inf_child_maybe_unpush_target): Delete.
5927         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
5928         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
5929         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
5930         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
5931         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
5932         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
5933         (inf_ptrace_wait, inf_ptrace_xfer_partial)
5934         (inf_ptrace_thread_alive, inf_ptrace_files_info)
5935         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
5936         methods of inf_ptrace_target.
5937         (inf_ptrace_target): Delete function.
5938         * inf-ptrace.h: Include "inf-child.h".
5939         (inf_ptrace_target): Delete function declaration.
5940         (inf_ptrace_target): New class.
5941         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
5942         * linux-nat.c (linux_target): New.
5943         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
5944         (linux_nat_target::~linux_nat_target): New.
5945         (linux_child_post_attach, linux_child_post_startup_inferior)
5946         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
5947         (linux_child_remove_fork_catchpoint)
5948         (linux_child_insert_vfork_catchpoint)
5949         (linux_child_remove_vfork_catchpoint)
5950         (linux_child_insert_exec_catchpoint)
5951         (linux_child_remove_exec_catchpoint)
5952         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
5953         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
5954         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
5955         (linux_nat_stopped_data_address)
5956         (linux_nat_stopped_by_sw_breakpoint)
5957         (linux_nat_supports_stopped_by_sw_breakpoint)
5958         (linux_nat_stopped_by_hw_breakpoint)
5959         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
5960         (linux_nat_kill, linux_nat_mourn_inferior)
5961         (linux_nat_xfer_partial, linux_nat_thread_alive)
5962         (linux_nat_update_thread_list, linux_nat_pid_to_str)
5963         (linux_nat_thread_name, linux_child_pid_to_exec_file)
5964         (linux_child_static_tracepoint_markers_by_strid)
5965         (linux_nat_is_async_p, linux_nat_can_async_p)
5966         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
5967         (linux_nat_supports_multi_process)
5968         (linux_nat_supports_disable_randomization, linux_nat_async)
5969         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
5970         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
5971         (linux_nat_fileio_open, linux_nat_fileio_readlink)
5972         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
5973         methods of linux_nat_target.
5974         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
5975         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
5976         parameter.
5977         (check_stopped_by_watchpoint): Adjust.
5978         (linux_xfer_partial): Delete.
5979         (linux_target_install_ops, linux_target, linux_nat_add_target):
5980         Delete.
5981         (linux_nat_target::linux_nat_target): New.
5982         * linux-nat.h: Include "inf-ptrace.h".
5983         (linux_nat_target): New.
5984         (linux_target, linux_target_install_ops, linux_nat_add_target):
5985         Delete function declarations.
5986         (linux_target): Declare global.
5987         * linux-thread-db.c (thread_db_target): New.
5988         (thread_db_target::thread_db_target): New.
5989         (thread_db_ops): Delete.
5990         (the_thread_db_target): New.
5991         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
5992         (thread_db_update_thread_list, thread_db_pid_to_str)
5993         (thread_db_extra_thread_info)
5994         (thread_db_thread_handle_to_thread_info)
5995         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
5996         (thread_db_resume): Refactor as methods of thread_db_target.
5997         (init_thread_db_ops): Delete.
5998         (_initialize_thread_db): Remove reference to init_thread_db_ops.
5999         * x86-linux-nat.c: Don't include "linux-nat.h".
6000         (super_post_startup_inferior): Delete.
6001         (x86_linux_nat_target::~x86_linux_nat_target): New.
6002         (x86_linux_child_post_startup_inferior)
6003         (x86_linux_read_description, x86_linux_enable_btrace)
6004         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
6005         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
6006         methods of x86_linux_nat_target.
6007         (x86_linux_create_target): Delete.  Bits folded ...
6008         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
6009         pointer.
6010         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
6011         (x86_linux_nat_target): New class.
6012         (x86_linux_create_target): Delete.
6013         (x86_linux_add_target): Now takes a linux_nat_target pointer.
6014         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
6015         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
6016         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
6017         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
6018         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
6019         make extern.
6020         (x86_use_watchpoints): Delete.
6021         * x86-nat.h: Include "breakpoint.h" and "target.h".
6022         (x86_use_watchpoints): Delete.
6023         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
6024         (x86_stopped_by_watchpoint, x86_stopped_data_address)
6025         (x86_insert_watchpoint, x86_remove_watchpoint)
6026         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
6027         (x86_stopped_by_hw_breakpoint): New declarations.
6028         (x86_nat_target): New template class.
6029
6030         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
6031         (the_ppc_linux_nat_target): New.
6032         (ppc_linux_fetch_inferior_registers)
6033         (ppc_linux_can_use_hw_breakpoint)
6034         (ppc_linux_region_ok_for_hw_watchpoint)
6035         (ppc_linux_ranged_break_num_registers)
6036         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
6037         (ppc_linux_insert_mask_watchpoint)
6038         (ppc_linux_remove_mask_watchpoint)
6039         (ppc_linux_can_accel_watchpoint_condition)
6040         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
6041         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
6042         (ppc_linux_watchpoint_addr_within_range)
6043         (ppc_linux_masked_watch_num_registers)
6044         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
6045         (ppc_linux_read_description): Refactor as methods of
6046         ppc_linux_nat_target.
6047         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
6048
6049         * procfs.c (procfs_xfer_partial): Delete forward declaration.
6050         (procfs_target): New class.
6051         (the_procfs_target): New.
6052         (procfs_target): Delete function.
6053         (procfs_auxv_parse, procfs_attach, procfs_detach)
6054         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
6055         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
6056         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
6057         (procfs_create_inferior, procfs_update_thread_list)
6058         (procfs_thread_alive, procfs_pid_to_str)
6059         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
6060         (procfs_stopped_data_address, procfs_insert_watchpoint)
6061         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
6062         (proc_find_memory_regions, procfs_info_proc)
6063         (procfs_make_note_section): Refactor as methods of procfs_target.
6064         (_initialize_procfs): Adjust.
6065         * sol-thread.c (sol_thread_target): New class.
6066         (sol_thread_ops): Now a sol_thread_target.
6067         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
6068         (sol_thread_fetch_registers, sol_thread_store_registers)
6069         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
6070         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
6071         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
6072         (init_sol_thread_ops): Delete.
6073         (_initialize_sol_thread): Adjust.  Remove references to
6074         init_sol_thread_ops and complete_target_initialization.
6075
6076         * windows-nat.c (windows_nat_target): New class.
6077         (windows_fetch_inferior_registers)
6078         (windows_store_inferior_registers, windows_resume, windows_wait)
6079         (windows_attach, windows_detach, windows_pid_to_exec_file)
6080         (windows_files_info, windows_create_inferior)
6081         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
6082         (windows_close, windows_pid_to_str, windows_xfer_partial)
6083         (windows_get_tib_address, windows_get_ada_task_ptid)
6084         (windows_thread_name, windows_thread_alive): Refactor as
6085         windows_nat_target methods.
6086         (do_initial_windows_stuff): Adjust.
6087         (windows_target): Delete function.
6088         (_initialize_windows_nat): Adjust.
6089
6090         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
6091         (darwin_mourn_inferior, darwin_kill_inferior)
6092         (darwin_create_inferior, darwin_attach, darwin_detach)
6093         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
6094         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
6095         (darwin_supports_multi_process): Refactor as darwin_nat_target
6096         methods.
6097         (darwin_resume_to, darwin_files_info): Delete.
6098         (_initialize_darwin_inferior): Rename to ...
6099         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
6100         * darwin-nat.h: Include "inf-child.h".
6101         (darwin_nat_target): New class.
6102         (darwin_complete_target): Delete.
6103         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
6104         (darwin_target): New.
6105         (i386_darwin_fetch_inferior_registers)
6106         (i386_darwin_store_inferior_registers): Refactor as methods of
6107         darwin_nat_target.
6108         (darwin_complete_target): Delete, with ...
6109         (_initialize_i386_darwin_nat): ... bits factored out here.
6110
6111         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
6112         (the_alpha_linux_nat_target): New.
6113         (alpha_linux_register_u_offset): Refactor as
6114         alpha_linux_nat_target method.
6115         (_initialize_alpha_linux_nat): Adjust.
6116         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
6117         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
6118         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
6119         methods of linux_nat_trad_target.
6120         (linux_trad_target): Delete.
6121         * linux-nat-trad.h (linux_trad_target): Delete function.
6122         (linux_nat_trad_target): New class.
6123         * mips-linux-nat.c (mips_linux_nat_target): New class.
6124         (super_fetch_registers, super_store_registers, super_close):
6125         Delete.
6126         (the_mips_linux_nat_target): New.
6127         (mips64_linux_regsets_fetch_registers)
6128         (mips64_linux_regsets_store_registers)
6129         (mips64_linux_fetch_registers, mips64_linux_store_registers)
6130         (mips_linux_register_u_offset, mips_linux_read_description)
6131         (mips_linux_can_use_hw_breakpoint)
6132         (mips_linux_stopped_by_watchpoint)
6133         (mips_linux_stopped_data_address)
6134         (mips_linux_region_ok_for_hw_watchpoint)
6135         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
6136         (mips_linux_close): Refactor as methods of mips_linux_nat.
6137         (_initialize_mips_linux_nat): Adjust to C++ification.
6138
6139         * aix-thread.c (aix_thread_target): New class.
6140         (aix_thread_ops): Now an aix_thread_target.
6141         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
6142         (aix_thread_fetch_registers, aix_thread_store_registers)
6143         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
6144         (aix_thread_thread_alive, aix_thread_pid_to_str)
6145         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
6146         Refactor as methods of aix_thread_target.
6147         (init_aix_thread_ops): Delete.
6148         (_initialize_aix_thread): Remove references to init_aix_thread_ops
6149         and complete_target_initialization.
6150         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
6151         (rs6000_nat_target): New class.
6152         (the_rs6000_nat_target): New.
6153         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
6154         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
6155         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
6156         (super_create_inferior): Delete.
6157         (_initialize_rs6000_nat): Adjust to C++ification.
6158
6159         * arm-linux-nat.c (arm_linux_nat_target): New class.
6160         (the_arm_linux_nat_target): New.
6161         (arm_linux_fetch_inferior_registers)
6162         (arm_linux_store_inferior_registers, arm_linux_read_description)
6163         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
6164         (arm_linux_remove_hw_breakpoint)
6165         (arm_linux_region_ok_for_hw_watchpoint)
6166         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
6167         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
6168         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
6169         arm_linux_nat_target.
6170         (_initialize_arm_linux_nat): Adjust to C++ification.
6171
6172         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
6173         (the_aarch64_linux_nat_target): New.
6174         (aarch64_linux_fetch_inferior_registers)
6175         (aarch64_linux_store_inferior_registers)
6176         (aarch64_linux_child_post_startup_inferior)
6177         (aarch64_linux_read_description)
6178         (aarch64_linux_can_use_hw_breakpoint)
6179         (aarch64_linux_insert_hw_breakpoint)
6180         (aarch64_linux_remove_hw_breakpoint)
6181         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
6182         (aarch64_linux_region_ok_for_hw_watchpoint)
6183         (aarch64_linux_stopped_data_address)
6184         (aarch64_linux_stopped_by_watchpoint)
6185         (aarch64_linux_watchpoint_addr_within_range)
6186         (aarch64_linux_can_do_single_step): Refactor as methods of
6187         aarch64_linux_nat_target.
6188         (super_post_startup_inferior): Delete.
6189         (_initialize_aarch64_linux_nat): Adjust to C++ification.
6190
6191         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
6192         (the_hppa_linux_nat_target): New.
6193         (hppa_linux_fetch_inferior_registers)
6194         (hppa_linux_store_inferior_registers): Refactor as methods of
6195         hppa_linux_nat_target.
6196         (_initialize_hppa_linux_nat): Adjust to C++ification.
6197
6198         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
6199         (the_ia64_linux_nat_target): New.
6200         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
6201         (ia64_linux_stopped_data_address)
6202         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
6203         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
6204         ia64_linux_nat_target methods.
6205         (super_xfer_partial): Delete.
6206         (_initialize_ia64_linux_nat): Adjust to C++ification.
6207
6208         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
6209         (the_m32r_linux_nat_target): New.
6210         (m32r_linux_fetch_inferior_registers)
6211         (m32r_linux_store_inferior_registers): Refactor as
6212         m32r_linux_nat_target methods.
6213         (_initialize_m32r_linux_nat): Adjust to C++ification.
6214
6215         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
6216         (the_m68k_linux_nat_target): New.
6217         (m68k_linux_fetch_inferior_registers)
6218         (m68k_linux_store_inferior_registers): Refactor as
6219         m68k_linux_nat_target methods.
6220         (_initialize_m68k_linux_nat): Adjust to C++ification.
6221
6222         * s390-linux-nat.c (s390_linux_nat_target): New class.
6223         (the_s390_linux_nat_target): New.
6224         (s390_linux_fetch_inferior_registers)
6225         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
6226         (s390_insert_watchpoint, s390_remove_watchpoint)
6227         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
6228         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
6229         (s390_auxv_parse, s390_read_description): Refactor as methods of
6230         s390_linux_nat_target.
6231         (_initialize_s390_nat): Adjust to C++ification.
6232
6233         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
6234         (the_sparc_linux_nat_target): New.
6235         (_initialize_sparc_linux_nat): Adjust to C++ification.
6236         * sparc-nat.c (sparc_fetch_inferior_registers)
6237         (sparc_store_inferior_registers): Remove target_ops parameter.
6238         * sparc-nat.h (sparc_fetch_inferior_registers)
6239         (sparc_store_inferior_registers): Remove target_ops parameter.
6240         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
6241         (the_sparc64_linux_nat_target): New.
6242         (_initialize_sparc64_linux_nat): Adjust to C++ification.
6243
6244         * spu-linux-nat.c (spu_linux_nat_target): New class.
6245         (the_spu_linux_nat_target): New.
6246         (spu_child_post_startup_inferior, spu_child_post_attach)
6247         (spu_child_wait, spu_fetch_inferior_registers)
6248         (spu_store_inferior_registers, spu_xfer_partial)
6249         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
6250         methods.
6251         (_initialize_spu_nat): Adjust to C++ification.
6252
6253         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
6254         (the_tilegx_linux_nat_target): New.
6255         (fetch_inferior_registers, store_inferior_registers):
6256         Refactor as methods.
6257         (_initialize_tile_linux_nat): Adjust to C++ification.
6258
6259         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
6260         (the_xtensa_linux_nat_target): New.
6261         (xtensa_linux_fetch_inferior_registers)
6262         (xtensa_linux_store_inferior_registers): Refactor as
6263         xtensa_linux_nat_target methods.
6264         (_initialize_xtensa_linux_nat): Adjust to C++ification.
6265
6266         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
6267         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
6268         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
6269         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
6270         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
6271         (fbsd_stopped_by_sw_breakpoint)
6272         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
6273         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
6274         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
6275         (fbsd_post_startup_inferior, fbsd_post_attach)
6276         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
6277         (fbsd_set_syscall_catchpoint)
6278         (super_xfer_partial, super_resume, super_wait)
6279         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
6280         (fbsd_handle_debug_trap): Remove target_ops parameter.
6281         (fbsd_nat_add_target): Delete.
6282         * fbsd-nat.h: Include "inf-ptrace.h".
6283         (fbsd_nat_add_target): Delete.
6284         (USE_SIGTRAP_SIGINFO): Define.
6285         (fbsd_nat_target): New class.
6286
6287         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
6288         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
6289         (amd64bsd_target): Delete.
6290         * amd64-bsd-nat.h: New file.
6291         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
6292         "x86-bsd-nat.h".
6293         (amd64_fbsd_nat_target): New class.
6294         (the_amd64_fbsd_nat_target): New.
6295         (amd64fbsd_read_description): Refactor as method of
6296         amd64_fbsd_nat_target.
6297         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
6298         (_initialize_amd64fbsd_nat): Adjust to C++ification.
6299         * amd64-nat.h (amd64bsd_target): Delete function declaration.
6300         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
6301         (i386bsd_store_inferior_registers): Remove target_ops parameter.
6302         (i386bsd_target): Delete.
6303         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
6304         (i386bsd_fetch_inferior_registers)
6305         (i386bsd_store_inferior_registers): Declare.
6306         (i386_bsd_nat_target): New class.
6307         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
6308         (the_i386_fbsd_nat_target): New.
6309         (i386fbsd_resume, i386fbsd_read_description): Refactor as
6310         i386_fbsd_nat_target methods.
6311         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
6312         (_initialize_i386fbsd_nat): Adjust to C++ification.
6313         * x86-bsd-nat.c (super_mourn_inferior): Delete.
6314         (x86bsd_mourn_inferior, x86bsd_target): Delete.
6315         (_initialize_x86_bsd_nat): Adjust to C++ification.
6316         * x86-bsd-nat.h: Include "x86-nat.h".
6317         (x86bsd_target): Delete declaration.
6318         (x86bsd_nat_target): New class.
6319
6320         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
6321         (the_aarch64_fbsd_nat_target): New.
6322         (aarch64_fbsd_fetch_inferior_registers)
6323         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
6324         aarch64_fbsd_nat_target.
6325         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
6326         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
6327         (the_alpha_bsd_nat_target): New.
6328         (alphabsd_fetch_inferior_registers)
6329         (alphabsd_store_inferior_registers): Refactor as
6330         alpha_bsd_nat_target methods.
6331         (_initialize_alphabsd_nat): Refactor as methods of
6332         alpha_bsd_nat_target.
6333         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
6334         (the_amd64_nbsd_nat_target): New.
6335         (_initialize_amd64nbsd_nat): Adjust to C++ification.
6336         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
6337         (the_amd64_obsd_nat_target): New.
6338         (_initialize_amd64obsd_nat): Adjust to C++ification.
6339         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
6340         (the_arm_fbsd_nat_target): New.
6341         (arm_fbsd_fetch_inferior_registers)
6342         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
6343         (_initialize_arm_fbsd_nat): Refactor as methods of
6344         arm_fbsd_nat_target.
6345         (_initialize_arm_fbsd_nat): Adjust to C++ification.
6346         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
6347         (the_arm_netbsd_nat_target): New.
6348         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
6349         arm_netbsd_nat_target.
6350         (_initialize_arm_netbsd_nat): Adjust to C++ification.
6351         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
6352         (the_hppa_nbsd_nat_target): New.
6353         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
6354         hppa_nbsd_nat_target methods.
6355         (_initialize_hppanbsd_nat): Adjust to C++ification.
6356         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
6357         (the_hppa_obsd_nat_target): New.
6358         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
6359         methods of hppa_obsd_nat_target.
6360         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
6361         add_target.
6362         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
6363         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
6364         add_target.
6365         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
6366         (_initialize_i386obsd_nat): Use add_target.
6367         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
6368         (the_m68k_bsd_nat_target): New.
6369         (m68kbsd_fetch_inferior_registers)
6370         (m68kbsd_store_inferior_registers): Refactor as methods of
6371         m68k_bsd_nat_target.
6372         (_initialize_m68kbsd_nat): Adjust to C++ification.
6373         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
6374         (the_mips_fbsd_nat_target): New.
6375         (mips_fbsd_fetch_inferior_registers)
6376         (mips_fbsd_store_inferior_registers): Refactor as methods of
6377         mips_fbsd_nat_target.
6378         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
6379         add_target.
6380         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
6381         (the_mips_nbsd_nat_target): New.
6382         (mipsnbsd_fetch_inferior_registers)
6383         (mipsnbsd_store_inferior_registers): Refactor as methods of
6384         mips_nbsd_nat_target.
6385         (_initialize_mipsnbsd_nat): Adjust to C++ification.
6386         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
6387         (the_mips64_obsd_nat_target): New.
6388         (mips64obsd_fetch_inferior_registers)
6389         (mips64obsd_store_inferior_registers): Refactor as methods of
6390         mips64_obsd_nat_target.
6391         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
6392         add_target.
6393         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
6394         nbsd_nat_target.
6395         * nbsd-nat.h: Include "inf-ptrace.h".
6396         (nbsd_nat_target): New class.
6397         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
6398         (obsd_wait): Refactor as methods of obsd_nat_target.
6399         (obsd_add_target): Delete.
6400         * obsd-nat.h: Include "inf-ptrace.h".
6401         (obsd_nat_target): New class.
6402         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
6403         (the_ppc_fbsd_nat_target): New.
6404         (ppcfbsd_fetch_inferior_registers)
6405         (ppcfbsd_store_inferior_registers): Refactor as methods of
6406         ppc_fbsd_nat_target.
6407         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
6408         add_target.
6409         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
6410         (the_ppc_nbsd_nat_target): New.
6411         (ppcnbsd_fetch_inferior_registers)
6412         (ppcnbsd_store_inferior_registers): Refactor as methods of
6413         ppc_nbsd_nat_target.
6414         (_initialize_ppcnbsd_nat): Adjust to C++ification.
6415         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
6416         (the_ppc_obsd_nat_target): New.
6417         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
6418         methods of ppc_obsd_nat_target.
6419         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
6420         add_target.
6421         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
6422         (the_sh_nbsd_nat_target): New.
6423         (shnbsd_fetch_inferior_registers)
6424         (shnbsd_store_inferior_registers): Refactor as methods of
6425         sh_nbsd_nat_target.
6426         (_initialize_shnbsd_nat): Adjust to C++ification.
6427         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
6428         (inf_ptrace_xfer_partial): Delete.
6429         (sparc_xfer_partial, sparc_target): Delete.
6430         * sparc-nat.h (sparc_fetch_inferior_registers)
6431         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
6432         (sparc_target): Delete function declaration.
6433         (sparc_target): New template class.
6434         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
6435         (_initialize_sparcnbsd_nat): Adjust to C++ification.
6436         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
6437         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
6438         add_target.
6439         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
6440         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
6441         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
6442         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
6443         add_target.
6444         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
6445         (the_vax_bsd_nat_target): New.
6446         (vaxbsd_fetch_inferior_registers)
6447         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
6448         methods.
6449         (_initialize_vaxbsd_nat): Adjust to C++ification.
6450
6451         * bsd-kvm.c (bsd_kvm_target): New class.
6452         (bsd_kvm_ops): Now a bsd_kvm_target.
6453         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
6454         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
6455         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
6456         bsd_kvm_target.
6457         (bsd_kvm_return_one): Delete.
6458         (bsd_kvm_add_target): Adjust to C++ification.
6459
6460         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
6461         (nto_procfs_target_procfs): New classes.
6462         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
6463         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
6464         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
6465         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
6466         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
6467         (procfs_remove_hw_breakpoint, procfs_resume)
6468         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
6469         (procfs_kill_inferior, procfs_store_registers)
6470         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
6471         as methods of nto_procfs_target.
6472         (nto_procfs_ops): Now an nto_procfs_target_procfs.
6473         (nto_native_ops): Delete.
6474         (procfs_open, procfs_native_open): Delete.
6475         (nto_native_ops): Now an nto_procfs_target_native.
6476         (init_procfs_targets): Adjust to C++ification.
6477         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
6478         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
6479         Refactor as methods of nto_procfs_target.
6480
6481         * go32-nat.c (go32_nat_target): New class.
6482         (the_go32_nat_target): New.
6483         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
6484         (go32_store_registers, go32_xfer_partial, go32_files_info)
6485         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
6486         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
6487         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
6488         (go32_pid_to_str): Refactor as methods of go32_nat_target.
6489         (go32_target): Delete.
6490         (_initialize_go32_nat): Adjust to C++ification.
6491
6492         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
6493         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
6494         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
6495         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
6496         gnu_nat_target.
6497         (gnu_target): Delete.
6498         * gnu-nat.h (gnu_target): Delete.
6499         (gnu_nat_target): New class.
6500         * i386-gnu-nat.c (gnu_base_target): New.
6501         (i386_gnu_nat_target): New class.
6502         (the_i386_gnu_nat_target): New.
6503         (_initialize_i386gnu_nat): Adjust to C++ification.
6504
6505 2018-05-02  Pedro Alves  <palves@redhat.com>
6506
6507         * bfd-target.c (target_bfd_xclose): Rename to ...
6508         (target_bfd_close): ... this.
6509         (target_bfd_reopen): Adjust.
6510         * target.c (target_close): Remove references to to_xclose.
6511         * target.h (target_ops::to_xclose): Delete.
6512         (target_ops::to_close): Update comments.
6513
6514 2018-05-02  Pedro Alves  <palves@redhat.com>
6515
6516         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
6517         "linux-nat.h".
6518         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
6519         * inf-ptrace.c (inf_ptrace_register_u_offset)
6520         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
6521         (inf_ptrace_store_register, inf_ptrace_store_registers)
6522         (inf_ptrace_trad_target): Move to ...
6523         * linux-nat-trad.c: ... this new file.
6524         * linux-nat-trad.h: New file.
6525         * linux-nat.c (linux_target_install_ops): Make extern.
6526         (linux_trad_target): Delete.
6527         * linux-nat.h (linux_trad_target): Delete declaration.
6528         (linux_target_install_ops): Declare.
6529         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
6530         "linux-nat.h".
6531
6532 2018-05-02  Pedro Alves  <palves@redhat.com>
6533
6534         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
6535         procfs_target/add_target here.
6536         * procfs.c (procfs_target): Make static.
6537         (_initialize_procfs): Call add_target here.
6538         * procfs.h (struct target_ops): Remove forward declaration.
6539         (procfs_target): Remove declaration.
6540         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
6541
6542 2018-05-02  Pedro Alves  <palves@redhat.com>
6543
6544         * procfs.c (procfs_stopped_by_watchpoint)
6545         (procfs_insert_watchpoint, procfs_remove_watchpoint)
6546         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
6547         Forward declare.
6548         (procfs_use_watchpoints): Delete, move contents...
6549         (procfs_target): ... here.
6550         * procfs.h (procfs_use_watchpoints): Delete declaration.
6551         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
6552         procfs_use_watchpoints.
6553         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
6554         procfs_use_watchpoints.
6555
6556 2018-05-02  Tom Tromey  <tom@tromey.com>
6557
6558         PR python/20084:
6559         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
6560         and var_zuinteger_unlimited.
6561         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
6562         and PARAM_ZUINTEGER_UNLIMITED.
6563         (set_parameter_value): Handle var_zuinteger and
6564         var_zuinteger_unlimited.
6565         (add_setshow_generic): Likewise.
6566         (parmpy_init): Likewise.
6567
6568 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
6569
6570         PR rust/23124
6571         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
6572         pointer is not null before dereferencing it.
6573
6574 2018-04-30  Tom Tromey  <tom@tromey.com>
6575
6576         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
6577         is_mi_like_p.
6578
6579 2018-04-30  Tom Tromey  <tom@tromey.com>
6580
6581         * breakpoint.c (mention): Remove use of is_mi_like_p.
6582         (print_mention_ranged_breakpoint): Likewise.
6583         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
6584         of is_mi_like_p.
6585
6586 2018-04-30  Tom Tromey  <tom@tromey.com>
6587
6588         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
6589
6590 2018-04-30  Tom Tromey  <tom@tromey.com>
6591
6592         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
6593         (info_spu_event_command): Remove some uses of is_mi_like_p.
6594
6595 2018-04-30  Tom Tromey  <tom@tromey.com>
6596
6597         * python/py-framefilter.c (py_print_single_arg)
6598         (enumerate_locals, py_print_args, py_print_frame): Remove some
6599         uses of is_mi_like_p.
6600
6601 2018-04-30  Tom Tromey  <tom@tromey.com>
6602
6603         * ui-out.c: Update.
6604         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
6605         * ui-out.h (ui_out::is_mi_like_p): Now const.
6606         (ui_out::do_is_mi_like_p): Now const.
6607         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
6608
6609 2018-04-30  Tom Tromey  <tom@tromey.com>
6610
6611         * varobj.c (varobj_set_visualizer): Use new_reference.
6612         * python/python.c (gdbpy_decode_line): Use new_reference.
6613         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
6614         new_reference.
6615
6616 2018-04-30  Tom Tromey  <tom@tromey.com>
6617
6618         * varobj.c (install_new_value): Use new_reference.
6619         * value.h (value_incref): Return void.  Swap intro comment with
6620         value_decref.
6621         * value.c (set_value_parent): Use new_reference.
6622         (value_incref): Return void.  Update intro comment.
6623         (release_value): Use new_reference.
6624         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
6625
6626 2018-04-30  Tom Tromey  <tom@tromey.com>
6627
6628         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
6629         * gdb_bfd.h (new_bfd_ref): Remove.
6630         (gdb_bfd_open): Update comment.
6631         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
6632         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
6633         (gdb_bfd_fdopenr): Use new_reference.
6634         * exec.c (exec_file_attach): Use new_reference.
6635
6636 2018-04-30  Tom Tromey  <tom@tromey.com>
6637
6638         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
6639         method.
6640
6641 2018-04-30  Tom Tromey  <tom@tromey.com>
6642
6643         * jit.c (jit_read_code_entry): Use type_align.
6644         * i386-tdep.c (i386_gdbarch_init): Don't call
6645         set_gdbarch_long_long_align_bit.
6646         * gdbarch.sh: Remove long_long_align_bit.
6647         * gdbarch.c, gdbarch.h: Rebuild.
6648         * arc-tdep.c (arc_type_align): New function.
6649         (arc_gdbarch_init): Use arc_type_align.  Don't call
6650         set_gdbarch_long_long_align_bit.
6651
6652 2018-04-30  Tom Tromey  <tom@tromey.com>
6653
6654         * rust-lang.c (rust_type_alignment): Remove.
6655         (rust_composite_type): Use type_align.
6656
6657 2018-04-30  Tom Tromey  <tom@tromey.com>
6658
6659         * NEWS: Mention Type.align.
6660         * python/py-type.c (typy_get_alignof): New function.
6661         (type_object_getset): Add "alignof".
6662
6663 2018-04-30  Tom Tromey  <tom@tromey.com>
6664
6665         PR exp/17095:
6666         * NEWS: Update.
6667         * std-operator.def (UNOP_ALIGNOF): New operator.
6668         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
6669         New.
6670         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
6671         * c-lang.c (c_op_print_tab): Add alignof.
6672         * c-exp.y (ALIGNOF): New token.
6673         (exp): Add "ALIGNOF" production.
6674         (ident_tokens): Add _Alignof and alignof.
6675
6676 2018-04-30  Tom Tromey  <tom@tromey.com>
6677
6678         * i386-tdep.c (i386_type_align): New function.
6679         (i386_gdbarch_init): Update.
6680         * gdbarch.sh (type_align): New method.
6681         * gdbarch.c, gdbarch.h: Rebuild.
6682         * arch-utils.h (default_type_align): Declare.
6683         * arch-utils.c (default_type_align): New function.
6684         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
6685         (struct type) <align_log2>: New field.
6686         <instance_flags>: Now a bitfield.
6687         (TYPE_RAW_ALIGN): New macro.
6688         (type_align, type_raw_align, set_type_align): Declare.
6689         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
6690         functions.
6691         * dwarf2read.c (quirk_rust_enum): Set type alignment.
6692         (get_alignment, maybe_set_alignment): New functions.
6693         (read_structure_type, read_enumeration_type, read_array_type)
6694         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
6695         (read_subrange_type, read_base_type): Set type alignment.
6696
6697 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
6698
6699         * dwarf2read.c (read_index_from_section): Use bool.
6700
6701 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
6702
6703         PR gdb/22950
6704         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
6705         with #ifdef.
6706
6707 2018-04-29  John Reiser  <jreiser@BitWagon.com>
6708
6709         PR build/22873
6710         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
6711         last step, and do it atomically.
6712
6713 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
6714
6715         * compile/compile-c-types.c (convert_int, convert_float):
6716         Update for C FE v1.
6717
6718 2018-04-27  Tom Tromey  <tom@tromey.com>
6719
6720         PR rust/22545:
6721         * rust-lang.c (rust_inclusive_range_type_p): New function.
6722         (rust_range): Handle inclusive ranges.
6723         (rust_compute_range): Likewise.
6724         * rust-exp.y (struct rust_op) <inclusive>: New field.
6725         (DOTDOTEQ): New constant.
6726         (range_expr): Add "..=" productions.
6727         (operator_tokens): Add "..=" token.
6728         (ast_range): Add "inclusive" parameter.
6729         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
6730         ranges.
6731         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
6732         bounds values.
6733         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
6734         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
6735         Update comments.
6736         * expprint.c (print_subexp_standard): Handle new bounds values.
6737         (dump_subexp_body_standard): Likewise.
6738
6739 2018-04-27  Tom Tromey  <tom@tromey.com>
6740
6741         * configure: Rebuild.
6742         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
6743         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
6744         "OVERRIDE".
6745         (class symbol_needs_eval_context): Likewise.
6746         * dwarf2read.c (mock_mapped_index::symbol_name_count)
6747         (mock_mapped_index::symbol_name_at): Use "override".  Remove
6748         "virtual".
6749         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
6750         "override".
6751         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
6752         * aarch64-tdep.c (instruction_reader::read): Use "override".
6753         (instruction_reader_test::read): Likewise.
6754         * arm-tdep.c (instruction_reader::read): Use "override".
6755         (instruction_reader_thumb::read): Likewise.
6756
6757 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
6758
6759         PR remote/9665
6760         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
6761         instead of remote_send.
6762         (remote_send): Remove.
6763
6764 2018-04-26  Pedro Alves  <palves@redhat.com>
6765
6766         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
6767         find_function_start_sal instead of find_pc_line.
6768
6769 2018-04-26  Pedro Alves  <palves@redhat.com>
6770
6771         * breakpoint.c (set_breakpoint_location_function): Handle
6772         mst_data_gnu_ifunc.
6773         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
6774         * elfread.c (elf_symtab_read): Give data symbols with
6775         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
6776         (elf_rel_plt_read): Update comment.
6777         * linespec.c (convert_linespec_to_sals): Handle
6778         mst_data_gnu_ifunc.
6779         (minsym_found): Handle mst_data_gnu_ifunc.
6780         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
6781         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
6782         * parse.c (find_minsym_type_and_address): Handle
6783         mst_data_gnu_ifunc.
6784         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
6785         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
6786         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
6787         comment.
6788         <mst_data_gnu_ifunc>: New enumerator.
6789
6790 2018-04-26  Pedro Alves  <palves@redhat.com>
6791
6792         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
6793         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
6794         'want_trampoline' parameter by a lookup_msym_prefer parameter.
6795         Handle it.
6796         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
6797         (lookup_minimal_symbol_by_pc): Adjust.
6798         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
6799         (lookup_solib_trampoline_symbol_by_pc): Adjust.
6800         * minsyms.h (lookup_msym_prefer): New enum.
6801         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
6802         parameter by a lookup_msym_prefer parameter.
6803
6804 2018-04-26  Pedro Alves  <palves@redhat.com>
6805
6806         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
6807         ends in "@plt" instead of looking at the symbol's section.
6808
6809 2018-04-26  Pedro Alves  <palves@redhat.com>
6810
6811         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
6812         all references.
6813         (find_pc_partial_function_gnu_ifunc): Rename to ...
6814         (find_pc_partial_function): ... this, and remove references to
6815         'is_gnu_ifunc_p'.
6816         (find_pc_partial_function): Delete old implementation.
6817         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
6818
6819 2018-04-26  Pedro Alves  <palves@redhat.com>
6820
6821         * linespec.c (struct bound_minimal_symbol_search_key): New.
6822         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
6823         skip first line if we found a GNU ifunc minimal symbol by name.
6824         (compare_msymbols): Change parameters to work with a destructured
6825         lhs minsym.
6826         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
6827         functions.
6828
6829 2018-04-26  Pedro Alves  <palves@redhat.com>
6830
6831         * breakpoint.c (set_breakpoint_location_function): Don't resolve
6832         ifunc targets here.  Instead, if we have an ifunc minsym, use its
6833         address/name.
6834         (add_location_to_breakpoint): Store the minsym and the objfile in
6835         the breakpoint location.
6836         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
6837         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
6838         Record the minsym in the sal.
6839         * symtab.h (symtab_and_line) <msymbol>: New field.
6840
6841 2018-04-26  Pedro Alves  <palves@redhat.com>
6842
6843         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
6844         unless we actually resolved the ifunc.
6845
6846 2018-04-26  Pedro Alves  <palves@redhat.com>
6847
6848         * c-exp.y (variable production): Prefer ifunc minsyms over
6849         regular function symbols.
6850         * symtab.c (find_gnu_ifunc): New function.
6851         * minsyms.h (lookup_msym_prefer): New enum.
6852         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
6853         parameter by a lookup_msym_prefer parameter.
6854         * symtab.h (find_gnu_ifunc): New declaration.
6855
6856 2018-04-26  Pedro Alves  <palves@redhat.com>
6857
6858         * blockframe.c (find_gnu_ifunc_target_type): New function.
6859         (find_function_type): New.
6860         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
6861         return a value with a memory address.
6862         (eval_call): For calls to GNU ifunc functions, try to find the
6863         type of the target function from the type that the resolver
6864         returns.
6865         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
6866         symbols.
6867         * infcall.c (find_function_return_type): Delete.
6868         (find_function_addr): Add 'function_type' parameter.  For calls to
6869         GNU ifunc functions, try to find the type of the target function
6870         from the type that the resolver returns, and return it via
6871         FUNCTION_TYPE.
6872         (call_function_by_hand_dummy): Adjust to use the function type
6873         returned by find_function_addr.
6874         (find_function_addr): Add 'function_type' parameter and move
6875         description here.
6876         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
6877         declarations.
6878
6879 2018-04-26  Pedro Alves  <palves@redhat.com>
6880
6881         * c-exp.y (variable production): Skip finding an alias for ifunc
6882         symbols.
6883
6884 2018-04-26  Pedro Alves  <palves@redhat.com>
6885
6886         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
6887
6888 2018-04-25  Pedro Alves  <palves@redhat.com>
6889
6890         * infcmd.c (kill_command): Print the pid as string, not the whole
6891         thread's ptid.  Add comment.  s/has been killed/killed/ in output
6892         message.
6893         * remote.c (remote_detach_1): Print the pid as string, not the
6894         whole thread's ptid.
6895
6896 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
6897             Sergio Durigan Junior  <sergiodj@redhat.com>
6898             Pedro Alves  <palves@redhat.com>
6899
6900         * infcmd.c (kill_command): Print message when inferior has
6901         been killed.
6902         * inferior.c (print_inferior_events): Remove 'static'.  Set as
6903         '1'.
6904         (add_inferior): Improve message printed when
6905         'print_inferior_events' is on.
6906         (exit_inferior): Remove message printed when
6907         'print_inferior_events' is on.
6908         (detach_inferior): Improve message printed when
6909         'print_inferior_events' is on.
6910         (initialize_inferiors): Use 'add_inferior_silent' to set
6911         'current_inferior_'.
6912         * inferior.h (print_inferior_events): Declare here as
6913         'extern'.
6914         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
6915         '[Detaching...]' messages when 'print_inferior_events' is on.
6916         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
6917         as prefix/suffix for messages.  Remove periods.  Fix erroneous
6918         'Detaching after fork from child...', replace it by '... from
6919         parent...'.
6920         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
6921         prefix/suffix when printing 'Detaching...' messages.  Print
6922         them when 'print_inferior_events' is on.
6923         * remote.c (remote_detach_1): Print message when detaching
6924         from inferior and '!is_fork_parent'.
6925
6926 2018-04-24  Tom Tromey  <tom@tromey.com>
6927
6928         * cli-out.h: Reindent.
6929
6930 2018-04-24  Tom Tromey  <tom@tromey.com>
6931
6932         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
6933         (cli_ui_out::do_field_string): Use fputs_filtered.
6934         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
6935
6936 2018-04-23  Tom Tromey  <tom@tromey.com>
6937
6938         * guile/scm-frame.c (gdbscm_frame_read_var): Use
6939         gdb::unique_xmalloc_ptr.
6940
6941 2018-04-23  Tom Tromey  <tom@tromey.com>
6942
6943         * configure: Rebuild.
6944
6945 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
6946
6947         PR gdb/23095
6948         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
6949         prepare_for_testing.  Set normal_bp to r_debug_state if target
6950         is bsd.
6951
6952 2018-04-21  Pedro Alves  <palves@redhat.com>
6953             Rajendra SY  <rajendra.sy@gmail.com>
6954
6955         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
6956         * remote.c (extended_remote_attach): In all-stop mode, mark the
6957         thread as executing.
6958
6959 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6960
6961         * thread.c (thread_apply_all_command): Fix comment.
6962         (thread_command): Fix comment.
6963
6964 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
6965
6966         * common/tdesc.h (tdesc_create_feature): Remove xml filename
6967         parameter.
6968         * features/aarch64-core.c (create_feature_aarch64_core):
6969         Regenerate.
6970         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
6971         Likewise.
6972         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
6973         Likewise.
6974         * features/i386/32bit-avx512.c
6975         (create_feature_i386_32bit_avx512): Likewise.
6976         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
6977         Likewise.
6978         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
6979         Likewise.
6980         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
6981         Likewise.
6982         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
6983         Likewise.
6984         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
6985         Likewise.
6986         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
6987         Likewise.
6988         * features/i386/64bit-avx512.c
6989         (create_feature_i386_64bit_avx512): Likewise.
6990         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
6991         Likewise.
6992         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
6993         Likewise.
6994         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
6995         Likewise.
6996         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
6997         Likewise.
6998         * features/i386/64bit-segments.c
6999         (create_feature_i386_64bit_segments): Likewise.
7000         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
7001         Likewise.
7002         * features/i386/x32-core.c
7003         (create_feature_i386_x32_core): Likewise.
7004         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
7005         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
7006         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
7007         * target-descriptions.c: In generated code, don't pass xml
7008         filename.
7009
7010 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7011
7012         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
7013         (print_xml_feature::visit_post): Likewise.
7014         (print_xml_feature::visit): Likewise.
7015         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
7016         (print_xml_feature): Add new class.
7017         * regformats/regdat.sh: Null xmltarget on feature targets.
7018         * target-descriptions.c (struct target_desc): Add xmltarget.
7019         (maintenance_check_tdesc_xml_convert): Add unittest function.
7020         (tdesc_get_features_xml): Add function to get xml.
7021         (maintenance_check_xml_descriptions): Test xml generation.
7022         * xml-tdesc.c (string_read_description_xml): Add function.
7023         * xml-tdesc.h (string_read_description_xml): Add declaration.
7024
7025 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7026
7027         * features/Makefile: Add feature marker to targets with new style
7028         target descriptions.
7029         * regformats/aarch64.dat: Regenerate.
7030         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
7031         * regformats/i386/amd64-avx-linux.dat: Likewise.
7032         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
7033         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
7034         * regformats/i386/amd64-linux.dat: Likewise.
7035         * regformats/i386/amd64-mpx-linux.dat: Likewise.
7036         * regformats/i386/amd64.dat: Likewise.
7037         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
7038         * regformats/i386/i386-avx-linux.dat: Likewise.
7039         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
7040         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
7041         * regformats/i386/i386-linux.dat: Likewise.
7042         * regformats/i386/i386-mmx-linux.dat: Likewise.
7043         * regformats/i386/i386-mpx-linux.dat: Likewise.
7044         * regformats/i386/i386.dat: Likewise.
7045         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
7046         * regformats/i386/x32-avx-linux.dat: Likewise.
7047         * regformats/i386/x32-linux.dat: Likewise.
7048         * regformats/tic6x-c62x-linux.dat: Likewise.
7049         * regformats/tic6x-c64x-linux.dat: Likewise.
7050         * regformats/tic6x-c64xp-linux.dat: Likewise.
7051         * regformats/regdat.sh: Parse feature marker.
7052
7053 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7054
7055         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
7056         (tdesc_osabi_name): Likewise.
7057         * target-descriptions.c (tdesc_architecture_name): Add new
7058         function.
7059         (tdesc_osabi_name): Likewise.
7060
7061 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7062
7063         * common/tdesc.c (tdesc_predefined_type): Move to here.
7064         (tdesc_named_type): Likewise.
7065         (tdesc_create_vector): Likewise.
7066         (tdesc_create_struct): Likewise.
7067         (tdesc_set_struct_size): Likewise.
7068         (tdesc_create_union): Likewise.
7069         (tdesc_create_flags): Likewise.
7070         (tdesc_create_enum): Likewise.
7071         (tdesc_add_field): Likewise.
7072         (tdesc_add_typed_bitfield): Likewise.
7073         (tdesc_add_bitfield): Likewise.
7074         (tdesc_add_flag): Likewise.
7075         (tdesc_add_enum_value): Likewise.
7076         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
7077         (struct tdesc_type_vector): Likewise.
7078         (struct tdesc_type_field): Likewise.
7079         (struct tdesc_type_with_fields): Likewise.
7080         (tdesc_create_enum): Add declaration.
7081         (tdesc_add_typed_bitfield): Likewise.
7082         (tdesc_add_enum_value): Likewise.
7083         * target-descriptions.c (tdesc_type_field): Move from here.
7084         (tdesc_type_builtin): Likewise.
7085         (tdesc_type_vector): Likewise.
7086         (tdesc_type_with_fields): Likewise.
7087         (tdesc_predefined_types): Likewise.
7088         (tdesc_named_type): Likewise.
7089         (tdesc_create_vector): Likewise.
7090         (tdesc_create_struct): Likewise.
7091         (tdesc_set_struct_size): Likewise.
7092         (tdesc_create_union): Likewise.
7093         (tdesc_create_flags): Likewise.
7094         (tdesc_create_enum): Likewise.
7095         (tdesc_add_field): Likewise.
7096         (tdesc_add_typed_bitfield): Likewise.
7097         (tdesc_add_bitfield): Likewise.
7098         (tdesc_add_flag): Likewise.
7099         (tdesc_add_enum_value): Likewise.
7100         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
7101         (tdesc_add_typed_bitfield): Likewise.
7102         (tdesc_add_enum_value): Likewise.
7103
7104 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7105
7106         * common/tdesc.c (tdesc_feature::accept): Move to here.
7107         (tdesc_feature::operator==): Likewise.
7108         (tdesc_create_reg): Likewise.
7109         * common/tdesc.h (tdesc_type_kind): Likewise.
7110         (struct tdesc_type): Likewise.
7111         (struct tdesc_feature): Likewise.
7112         * regformats/regdat.sh: Create a feature.
7113         * target-descriptions.c (tdesc_type_kind): Move from here.
7114         (tdesc_type): Likewise.
7115         (tdesc_type_up): Likewise.
7116         (tdesc_feature): Likewise.
7117         (tdesc_create_reg): Likewise.
7118
7119 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
7120
7121         * Makefile.in: Add arch/tdesc.c
7122         * common/tdesc.c: New file.
7123         * common/tdesc.h (tdesc_element_visitor): Move to here.
7124         (tdesc_element): Likewise.
7125         (tdesc_reg): Likewise.
7126         (tdesc_reg_up): Likewise.
7127         * regformats/regdef.h (reg): Add offset to constructors.
7128         * target-descriptions.c (tdesc_element_visitor): Move from here.
7129         (tdesc_element): Likewise.
7130         (tdesc_reg): Likewise.
7131         (tdesc_reg_up): Likewise.
7132
7133 2018-04-17  Tom Tromey  <tom@tromey.com>
7134
7135         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
7136         discriminant field.
7137
7138 2018-04-17  Tom Tromey  <tom@tromey.com>
7139
7140         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
7141
7142 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7143
7144         * symtab.c (print_symbol_info): Skip printing filename and line
7145         number when `last' is NULL.
7146         (symtab_symbol_info): Use empty string instead of NULL for first
7147         invocation of print_symbol_info.
7148         (rbreak_command): Pass NULL to `last' parameter of
7149         print_symbol_info.
7150
7151 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
7152
7153         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
7154         instead of nullptr.
7155
7156 2018-04-16  Pedro Alves  <palves@redhat.com>
7157
7158         * MAINTAINERS (sh): Remove.
7159         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
7160         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
7161         (ALLDEPFILES): Remove sh64-tdep.c.
7162         * NEWS: Mentions that support for SH-5/SH64 is removed.
7163         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
7164         (sh*-*-openbsd*): Ditto.
7165         (sh64-*-elf*): Remove.
7166         (sh*): Remove.
7167         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
7168         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
7169         * sh-tdep.c: No longer include "sh64-tdep.h".
7170         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
7171         * sh64-tdep.c, sh64-tdep.h: Remove files.
7172
7173 2018-04-16  Pedro Alves  <palves@redhat.com>
7174
7175         * MAINTAINERS: Remove m88k.
7176         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
7177         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
7178         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
7179         * NEWS: Mention that support for m88k was removed.
7180         * configure.host (m88*-*-*): Remove support.
7181         * configure.nat (m88k-*-*): Remove support.
7182         * configure.tgt (m88*-*-openbsd*): Remove.
7183         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
7184
7185 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
7186
7187         * configure.tgt (x86_tobjs): New variable.
7188         (amd64_tobjs, i386_tobjs): Use it.
7189
7190 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7191
7192         * symtab.c (print_symbol_info): Precede the symbol definition by
7193         the line number when available.
7194         * NEWS: Advertise this enhancement.
7195
7196 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7197
7198         * NEWS (New options): announce set/show record btrace cpu.
7199         * btrace.c: Include record-btrace.h.
7200         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
7201         the vendor is unknown.
7202         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
7203         Maybe overwrite the btrace configuration's cpu.
7204         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
7205         (btrace_fetch): Add cpu parameter.  Update callers.
7206         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
7207         Maybe overwrite the btrace configuration's cpu.  Skip enabling
7208         errata workarounds if the vendor is unknown.
7209         * python/py-record-btrace.c: Include record-btrace.h.
7210         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
7211         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
7212         * record-btrace.c (record_btrace_cpu_state_kind): New.
7213         (record_btrace_cpu): New.
7214         (set_record_btrace_cpu_cmdlist): New.
7215         (record_btrace_get_cpu): New.
7216         (require_btrace_thread, record_btrace_info)
7217         (record_btrace_resume_thread): Call record_btrace_get_cpu.
7218         (cmd_set_record_btrace_cpu_none): New.
7219         (cmd_set_record_btrace_cpu_auto): New.
7220         (cmd_set_record_btrace_cpu): New.
7221         (cmd_show_record_btrace_cpu): New.
7222         (_initialize_record_btrace): Initialize set/show record btrace cpu
7223         commands.
7224         * record-btrace.h (record_btrace_get_cpu): New.
7225
7226 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7227
7228         * record.c (set_record_command): Fix typo in message.
7229
7230 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7231
7232         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
7233
7234 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
7235
7236         * infrun.c (process_event_stop_test): Call
7237         gdbarch_in_indirect_branch_thunk.
7238         * gdbarch.sh (in_indirect_branch_thunk): New.
7239         * gdbarch.c: Regenerated.
7240         * gdbarch.h: Regenerated.
7241         * x86-tdep.h: New.
7242         * x86-tdep.c: New.
7243         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
7244         (HFILES_NO_SRCDIR): Add x86-tdep.h.
7245         (ALLDEPFILES): Add x86-tdep.c.
7246         * arch-utils.h (default_in_indirect_branch_thunk): New.
7247         * arch-utils.c (default_in_indirect_branch_thunk): New.
7248         * i386-tdep: Include x86-tdep.h.
7249         (i386_in_indirect_branch_thunk): New.
7250         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
7251         function.
7252         * amd64-tdep: Include x86-tdep.h.
7253         (amd64_in_indirect_branch_thunk): New.
7254         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
7255
7256 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
7257
7258         PR gdb/23053
7259         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
7260         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
7261         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
7262         regression.
7263
7264 2018-04-12  Tom Tromey  <tom@tromey.com>
7265
7266         * rust-lang.c (rust_print_struct_def): Remove univariant code.
7267         (rust_evaluate_subexp): Likewise.
7268
7269 2018-04-12  Pedro Alves  <palves@redhat.com>
7270
7271         * procfs.c (procfs_detach): Make forward declaration's prototype
7272         match definition's protototype.
7273         (proc_get_LDT_entry): Remove stale do_cleanups call.
7274
7275 2018-04-12  Pedro Alves  <palves@redhat.com>
7276
7277         * target.h (target_ops::to_has_exited): Delete.
7278         (target_has_exited): Delete.
7279         * target-delegates.c: Regenerate.
7280
7281 2018-04-11  Pedro Alves  <palves@redhat.com>
7282
7283         * target.c (fileio_fh_t::t): Add comment.
7284         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
7285         (target_fileio_close): Handle a NULL target.
7286         (invalidate_fileio_fh): New.
7287         (target_close): Call it.
7288         * remote.c (remote_hostio_send_command): No longer check whether
7289         remote_desc is open.
7290
7291 2018-04-11  Pedro Alves  <palves@redhat.com>
7292
7293         * target.c (fileio_fh_t): Make it a named struct instead of a
7294         typedef.
7295         (fileio_fh_t::is_closed): New method.
7296         (DEF_VEC_O (fileio_fh_t)): Remove.
7297         (fileio_fhandles): Now a std::vector.
7298         (is_closed_fileio_fh): Delete.
7299         (acquire_fileio_fd): Adjust.  Rename parameters.
7300         (release_fileio_fd): Adjust.
7301         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
7302         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
7303         (target_fileio_close): Adjust.
7304
7305 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
7306
7307         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
7308         index.
7309
7310 2018-04-10  Pedro Alves  <palves@redhat.com>
7311
7312         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
7313         (scoped_finish_thread_state): New class.
7314         * infcmd.c (run_command_1): Use it instead of finish_thread_state
7315         cleanup.
7316         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
7317         (fetch_inferior_event, normal_stop): Likewise.
7318         * thread.c (finish_thread_state_cleanup): Delete.
7319
7320 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7321             Pedro Alves  <palves@redhat.com>
7322
7323         * value.c: Include "selftest.h" and "common/array-view.h".
7324         (struct range) <operator ==>: New.
7325         (test_ranges_contain): New.
7326         (check_ranges_vector): New.
7327         (test_insert_into_bit_range_vector): New.
7328         (_initialize_values): Register selftests.
7329         * common/array-view.h (operator==, operator!=): New.
7330
7331 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7332
7333         * common/gdb_vecs.h (unordered_remove): Add overload that takes
7334         an iterator.
7335         * inline-frame.c: Include <algorithm>.
7336         (struct inline_state): Add constructor.
7337         (inline_state_s): Remove.
7338         (DEF_VEC_O(inline_state_s)): Remove.
7339         (inline_states): Change type to std::vector.
7340         (find_inline_frame_state): Adjust to std::vector.
7341         (allocate_inline_frame_state): Remove.
7342         (clear_inline_frame_state): Adjust to std::vector.
7343         (skip_inline_frames): Adjust to std::vector.
7344
7345 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7346
7347         * tracepoint.h (struct trace_state_variable): Add constructor.
7348         <name>: Change type to std::string.
7349         * tracepoint.c (tsv_s): Remove.
7350         (DEF_VEC_O(tsv_s)): Remove.
7351         (tvariables): Change to std::vector.
7352         (create_trace_state_variable): Adjust to std::vector.
7353         (find_trace_state_variable): Likewise.
7354         (find_trace_state_variable_by_number): Likewise.
7355         (delete_trace_state_variable): Likewise.
7356         (trace_variable_command): Adjust to std::string.
7357         (delete_trace_variable_command): Likewise.
7358         (tvariables_info_1): Adjust to std::vector.
7359         (save_trace_state_variables): Likewise.
7360         (start_tracing): Likewise.
7361         (merge_uploaded_trace_state_variables): Adjust to std::vector
7362         and std::string.
7363         * target.h (struct target_ops)
7364         <to_download_trace_state_variable>: Pass reference to
7365         trace_state_variable.
7366         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
7367         * target-delegates.c: Re-generate.
7368         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
7369         (mi_tsv_deleted): Likewise.
7370         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
7371         * remote.c (remote_download_trace_state_variable): Change
7372         pointer to reference and adjust.
7373         * make-target-delegates (parse_argtypes): Handle references.
7374         (write_function_header): Likewise.
7375         (munge_type): Likewise.
7376
7377 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7378
7379         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7380         string_view-selftests.c.
7381         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
7382         testsuite.
7383         * unittests/basic_string_view/cons/char/1.cc: Likewise.
7384         * unittests/basic_string_view/cons/char/2.cc: Likewise.
7385         * unittests/basic_string_view/cons/char/3.cc: Likewise.
7386         * unittests/basic_string_view/element_access/char/1.cc:
7387         Likewise.
7388         * unittests/basic_string_view/element_access/char/empty.cc:
7389         Likewise.
7390         * unittests/basic_string_view/element_access/char/front_back.cc:
7391         Likewise.
7392         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
7393         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
7394         Likewise.
7395         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
7396         Likewise.
7397         * unittests/basic_string_view/modifiers/swap/char/1.cc:
7398         Likewise.
7399         * unittests/basic_string_view/operations/compare/char/1.cc:
7400         Likewise.
7401         * unittests/basic_string_view/operations/compare/char/13650.cc:
7402         Likewise.
7403         * unittests/basic_string_view/operations/copy/char/1.cc:
7404         Likewise.
7405         * unittests/basic_string_view/operations/data/char/1.cc:
7406         Likewise.
7407         * unittests/basic_string_view/operations/find/char/1.cc:
7408         Likewise.
7409         * unittests/basic_string_view/operations/find/char/2.cc:
7410         Likewise.
7411         * unittests/basic_string_view/operations/find/char/3.cc:
7412         Likewise.
7413         * unittests/basic_string_view/operations/find/char/4.cc:
7414         Likewise.
7415         * unittests/basic_string_view/operations/rfind/char/1.cc:
7416         Likewise.
7417         * unittests/basic_string_view/operations/rfind/char/2.cc:
7418         Likewise.
7419         * unittests/basic_string_view/operations/rfind/char/3.cc:
7420         Likewise.
7421         * unittests/basic_string_view/operations/substr/char/1.cc:
7422         Likewise.
7423         * unittests/basic_string_view/operators/char/2.cc: Likewise.
7424         * unittests/string_view-selftests.c: New file.
7425
7426 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7427
7428         * unittests/basic_string_view/capacity/1.cc: New file.
7429         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
7430         * unittests/basic_string_view/cons/char/1.cc: New file.
7431         * unittests/basic_string_view/cons/char/2.cc: New file.
7432         * unittests/basic_string_view/cons/char/3.cc: New file.
7433         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
7434         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
7435         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
7436         * unittests/basic_string_view/element_access/char/1.cc: New file.
7437         * unittests/basic_string_view/element_access/char/2.cc: New file.
7438         * unittests/basic_string_view/element_access/char/empty.cc: New file.
7439         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
7440         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
7441         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
7442         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
7443         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
7444         * unittests/basic_string_view/include.cc: New file.
7445         * unittests/basic_string_view/inserters/char/1.cc: New file.
7446         * unittests/basic_string_view/inserters/char/2.cc: New file.
7447         * unittests/basic_string_view/inserters/char/3.cc: New file.
7448         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
7449         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
7450         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
7451         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
7452         * unittests/basic_string_view/literals/types.cc: New file.
7453         * unittests/basic_string_view/literals/values.cc: New file.
7454         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
7455         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
7456         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
7457         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
7458         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
7459         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
7460         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
7461         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
7462         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
7463         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
7464         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
7465         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
7466         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
7467         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
7468         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
7469         * unittests/basic_string_view/operations/data/char/1.cc: New file.
7470         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
7471         * unittests/basic_string_view/operations/find/char/1.cc: New file.
7472         * unittests/basic_string_view/operations/find/char/2.cc: New file.
7473         * unittests/basic_string_view/operations/find/char/3.cc: New file.
7474         * unittests/basic_string_view/operations/find/char/4.cc: New file.
7475         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
7476         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
7477         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
7478         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
7479         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
7480         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
7481         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
7482         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
7483         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
7484         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
7485         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
7486         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
7487         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
7488         * unittests/basic_string_view/operators/char/2.cc: New file.
7489         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
7490         * unittests/basic_string_view/range_access/char/1.cc: New file.
7491         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
7492         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
7493         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
7494         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
7495         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
7496         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
7497         * unittests/basic_string_view/requirements/typedefs.cc: New file.
7498         * unittests/basic_string_view/typedefs.cc: New file.
7499         * unittests/basic_string_view/types/1.cc: New file.
7500
7501 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7502
7503         * common/gdb_string_view.h: Remove libstdc++ implementation
7504         details, adjust to gdb reality.
7505         * common/gdb_string_view.tcc: Likewise.
7506         * cli/cli-script.c (struct string_view): Remove.
7507         (user_args) <m_args>: Change element type to gdb::string_view.
7508         (user_args::insert_args): Adjust.
7509
7510 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7511
7512         * common/gdb_string_view.h: New file.
7513         * common/gdb_string_view.tcc: New file.
7514
7515 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
7516
7517         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
7518         * configure: Re-generate.
7519
7520 2018-04-09  Pedro Alves  <palves@redhat.com>
7521
7522         * gdbarch.sh: Include "observable.h" instead of "observer.h".
7523         (set_target_gdbarch): Call
7524         gdb::observers::architecture_changed.notify instead of
7525         observer_notify_architecture_changed.
7526
7527 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7528
7529         * tracepoint.c (struct current_traceframe_cleanup): Remove.
7530         (do_restore_current_traceframe_cleanup): Remove.
7531         (restore_current_traceframe_cleanup_dtor): Remove.
7532         (make_cleanup_restore_current_traceframe): Remove.
7533         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
7534         New.
7535         * tracepoint.h (struct scoped_restore_current_traceframe): New.
7536         * infrun.c (fetch_inferior_event): Use
7537         scoped_restore_current_traceframe.
7538
7539 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7540
7541         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
7542         Remove.
7543         <n_allocated_type_units>: Remove.
7544         <all_type_units>: Change to std::vector.
7545         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
7546         to std::vector change.
7547         (dwarf2_per_objfile::get_cutu): Likewise.
7548         (dwarf2_per_objfile::get_tu): Likewise.
7549         (create_signatured_type_table_from_index): Likewise.
7550         (create_signatured_type_table_from_debug_names): Likewise.
7551         (dw2_symtab_iter_next): Likewise.
7552         (dw2_print_stats): Likewise.
7553         (dw2_expand_all_symtabs): Likewise.
7554         (dw2_expand_marked_cus): Likewise.
7555         (dw2_debug_names_iterator::next): Likewise.
7556         (dwarf2_initialize_objfile): Likewise.
7557         (add_signatured_type_cu_to_table): Likewise.
7558         (create_all_type_units): Likewise.
7559         (add_type_unit): Likewise.
7560         (struct tu_abbrev_offset): Add constructor.
7561         (build_type_psymtabs_1): Adjust to std::vector change.
7562         (print_tu_stats): Likewise.
7563         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
7564         (write_debug_names): Likewise.
7565
7566 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7567
7568         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
7569         Make an std::vector.
7570         <n_comp_units>: Remove.
7571         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
7572         to std::vector change.
7573         (dwarf2_per_objfile::get_cutu): Likewise.
7574         (dwarf2_per_objfile::get_cu): Likewise.
7575         (create_cus_from_index): Likewise.
7576         (create_addrmap_from_index): Likewise.
7577         (create_addrmap_from_aranges): Likewise.
7578         (dwarf2_read_index): Likewise.
7579         (dw2_find_last_source_symtab): Likewise.
7580         (dw2_map_symtabs_matching_filename): Likewise.
7581         (dw2_symtab_iter_next): Likewise.
7582         (dw2_print_stats): Likewise.
7583         (dw2_expand_all_symtabs): Likewise.
7584         (dw2_expand_symtabs_with_fullname): Likewise.
7585         (dw2_expand_marked_cus): Likewise.
7586         (dw2_map_symbol_filenames): Likewise.
7587         (create_cus_from_debug_names): Likewise.
7588         (dwarf2_read_debug_names): Likewise.
7589         (dw2_debug_names_iterator::next): Likewise.
7590         (dwarf2_initialize_objfile): Likewise.
7591         (set_partial_user): Likewise.
7592         (dwarf2_build_psymtabs_hard): Likewise.
7593         (read_comp_units_from_section): Remove arguments, adjust to
7594         std::vector change.
7595         (create_all_comp_units): Adjust to std::vector and
7596         read_comp_units_from_section changes.
7597         (dwarf2_find_containing_comp_unit): Adjust to std::vector
7598         change.
7599         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
7600         (psyms_seen_size): Likewise.
7601         (write_gdbindex): Likewise.
7602         (write_debug_names): Likewise.
7603
7604 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7605
7606         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
7607         with dwarf2_per_objfile.
7608         (create_cus_from_index): Likewise.
7609         (create_signatured_type_table_from_index): Likewise.
7610         (dwarf2_read_index): Likewise.
7611         (dwarf2_initialize_objfile): Likewise.
7612         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
7613         per_cu rather than get_dwarf2_per_objfile.
7614
7615 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7616
7617         * dwarf2read.h (struct signatured_type): Forward declare.
7618         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
7619         New methods.
7620         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
7621         (dw2_get_cutu): ...this.
7622         (dwarf2_per_objfile::get_cu): Rename from...
7623         (dw2_get_cu): ...this.
7624         (dwarf2_per_objfile::get_tu): New.
7625         (create_addrmap_from_index): Adjust.
7626         (create_addrmap_from_aranges): Adjust.
7627         (dw2_find_last_source_symtab): Adjust.
7628         (dw2_map_symtabs_matching_filename): Adjust.
7629         (dw2_symtab_iter_next): Adjust.
7630         (dw2_print_stats): Adjust.
7631         (dw2_expand_all_symtabs): Adjust.
7632         (dw2_expand_symtabs_with_fullname): Adjust.
7633         (dw2_expand_marked_cus): Adjust.
7634         (dw_expand_symtabs_matching_file_matcher): Adjust.
7635         (dw2_map_symbol_filenames): Adjust.
7636         (dw2_debug_names_iterator::next): Adjust.
7637         (dwarf2_initialize_objfile): Adjust.
7638         (set_partial_user): Adjust.
7639         (dwarf2_build_psymtabs_hard): Adjust.
7640
7641 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7642
7643         * dwarf2read.c (create_signatured_type_table_from_debug_names):
7644         Remove unused variables.
7645         (dw2_map_symtabs_matching_filename): Likewise.
7646         (dwarf2_record_block_ranges): Likewise.
7647         (dwarf2_read_addr_index): Likewise.
7648         (follow_die_offset): Likewise.
7649
7650 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7651
7652         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
7653         to symbol_file_add_main.
7654
7655 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7656
7657         PR mi/22299
7658         * mi/mi-console.c (do_fputc_async_safe): New.
7659         (mi_console_file::write_async_safe): New.
7660         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
7661         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
7662         New.
7663         * ui-file.c (ui_file::putstrn): Adjust call to
7664         fputstrn_unfiltered.
7665         * utils.c (printchar): Replace do_fputs and do_fprintf
7666         parameters by do_fputc.
7667         (fputstr_filtered): Adjust call to printchar.
7668         (fputstr_unfiltered): Likewise.
7669         (fputstrn_filtered): Likewise.
7670         (fputstrn_unfiltered): Add do_fputc parameter, pass to
7671         printchar.
7672         * utils.h (do_fputc_ftype): New typedef.
7673         (fputstrn_unfiltered): Add do_fputc parameter.
7674
7675 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7676
7677         * regformats/i386/i386-avx.dat: Remove.
7678
7679 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
7680
7681         PR gdb/22979
7682         * amd64-tdep.c (amd64_none_init_abi): New function.
7683         (amd64_x32_none_init_abi): New function.
7684         (_initialize_amd64_tdep): Register handlers for x86-64 and
7685         x64_32 with GDB_OSABI_NONE.
7686         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
7687         GDB_OSABI_NONE osabi.
7688
7689 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
7690
7691         PR gdb/22980
7692         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
7693         GDB_OSABI_NONE.
7694         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
7695         * osabi.c (gdb_osabi_names): Add "unknown" entry.
7696
7697 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
7698
7699         * common/byte-vector.h (char_vector): New type.
7700         * target.h (target_read_alloc): Return
7701         gdb::optional<byte_vector>.
7702         (target_read_stralloc): Return gdb::optional<char_vector>.
7703         (target_get_osdata): Return gdb::optional<char_vector>.
7704         * target.c (target_read_alloc_1): Templatize.  Replacement
7705         manual memory management with vector.
7706         (target_read_alloc): Change return type, adjust.
7707         (target_read_stralloc): Change return type, adjust.
7708         (target_get_osdata): Change return type, adjust.
7709         * auxv.c (struct auxv_info) <length>: Remove.
7710         <data>: Change type to gdb::optional<byte_vector>.
7711         (auxv_inferior_data_cleanup): Free auxv_info with delete.
7712         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
7713         (target_auxv_search): Adjust.
7714         (fprint_target_auxv): Adjust.
7715         * avr-tdep.c (avr_io_reg_read_command): Adjust.
7716         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
7717         (linux_make_corefile_notes): Adjust.
7718         * osdata.c (get_osdata): Adjust.
7719         * remote.c (remote_get_threads_with_qxfer): Adjust.
7720         (remote_memory_map): Adjust.
7721         (remote_traceframe_info): Adjust.
7722         (btrace_read_config): Adjust.
7723         (remote_read_btrace): Adjust.
7724         (remote_pid_to_exec_file): Adjust.
7725         * solib-aix.c (solib_aix_get_library_list): Adjust.
7726         * solib-dsbt.c (decode_loadmap): Don't free buf.
7727         (dsbt_get_initial_loadmaps): Adjust.
7728         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
7729         * solib-target.c (solib_target_current_sos): Adjust.
7730         * tracepoint.c (sdata_make_value): Adjust.
7731         * xml-support.c (xinclude_start_include): Adjust.
7732         (xml_fetch_content_from_file): Adjust.
7733         * xml-support.h (xml_fetch_another): Change return type.
7734         (xml_fetch_content_from_file): Change return type.
7735         * xml-syscall.c (xml_init_syscalls_info): Adjust.
7736         * xml-tdesc.c (file_read_description_xml): Adjust.
7737         (fetch_available_features_from_target): Change return type.
7738         (target_fetch_description_xml): Adjust.
7739         (target_read_description_xml): Adjust.
7740
7741 2018-04-06  Tom Tromey  <tom@tromey.com>
7742
7743         * value.c (~value): Update.
7744         (struct value) <contents>: Now unique_xmalloc_ptr.
7745         (value_contents_bits_eq, allocate_value_contents)
7746         (value_contents_raw, value_contents_all_raw)
7747         (value_contents_for_printing, value_contents_for_printing_const)
7748         (set_value_enclosing_type): Update.
7749
7750 2018-04-06  Tom Tromey  <tom@tromey.com>
7751
7752         * value.c (range_s): Remove typedef, VEC.
7753         (struct range): Add operator<.
7754         (range_lessthan): Remove.
7755         (ranges_contain): Change type.
7756         (~value): Update.
7757         (struct value) <unavailable, optimized_out>: Now std::vector.
7758         (value_entirely_available)
7759         (value_entirely_covered_by_range_vector)
7760         (value_entirely_unavailable, value_entirely_optimized_out):
7761         Update.
7762         (insert_into_bit_range_vector): Change argument type.
7763         (find_first_range_overlap): Likewise.
7764         (struct ranges_and_idx, value_contents_bits_eq)
7765         (require_not_optimized_out, require_available): Update.
7766         (ranges_copy_adjusted): Change argument types.
7767         (value_optimized_out, value_copy, value_fetch_lazy): Update.
7768
7769 2018-04-06  Tom Tromey  <tom@tromey.com>
7770
7771         * value.c (~value): Update.
7772         (struct value) <parent>: Now a value_ref_ptr.
7773         (value_parent, set_value_parent, value_address, value_copy):
7774         Update.
7775
7776 2018-04-06  Tom Tromey  <tom@tromey.com>
7777
7778         * value.c (struct value): Add constructor, destructor, and member
7779         initializers.
7780         (allocate_value_lazy, value_decref): Update.
7781
7782 2018-04-06  Tom Tromey  <tom@tromey.com>
7783
7784         * value.c (struct value) <released, next>: Remove.
7785         (all_values): Now a std::vector.
7786         (allocate_value_lazy): Update.
7787         (value_next): Remove.
7788         (value_mark, value_free_to_mark, release_value)
7789         (value_release_to_mark): Update.
7790
7791 2018-04-06  Tom Tromey  <tom@tromey.com>
7792
7793         * value.h (fetch_subexp_value, value_release_to_mark): Update.
7794         (free_value_chain): Remove.
7795         * value.c (free_value_chain): Remove.
7796         (value_release_to_mark): Return a std::vector.
7797         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
7798         std::vector.
7799         (check_condition): Update.
7800         * eval.c (fetch_subexp_value): Change "val_chain" to a
7801         std::vector.
7802         * breakpoint.c (update_watchpoint): Update.
7803         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
7804
7805 2018-04-06  Tom Tromey  <tom@tromey.com>
7806
7807         * value.h (free_all_values): Remove.
7808         * value.c (free_all_values): Remove.
7809
7810 2018-04-06  Tom Tromey  <tom@tromey.com>
7811
7812         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
7813         (value_history_chain, value_history_count): Remove.
7814         (value_history): New global.
7815         (record_latest_value, access_value_history, show_values)
7816         (preserve_values): Update.
7817
7818 2018-04-06  Tom Tromey  <tom@tromey.com>
7819
7820         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
7821         * varobj.c (varobj_set_display_format, varobj_set_value)
7822         (install_default_visualizer, construct_visualizer)
7823         (install_new_value, ~varobj, varobj_get_value_type)
7824         (my_value_of_variable, varobj_editable_p): Update.
7825         * c-varobj.c (c_describe_child, c_value_of_variable)
7826         (cplus_number_of_children, cplus_describe_child): Update.
7827         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
7828         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
7829         (ada_value_of_variable, ada_value_is_changeable_p): Update.
7830
7831 2018-04-06  Tom Tromey  <tom@tromey.com>
7832
7833         * printcmd.c (last_examine_address): Change type to
7834         value_ref_ptr.
7835         (do_examine, x_command): Update.
7836
7837 2018-04-06  Tom Tromey  <tom@tromey.com>
7838
7839         * value.c (release_value): Update.
7840         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
7841         (struct bpstats) <val>: Now a value_ref_ptr.
7842         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
7843         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
7844         (~watchpoint, print_it_watchpoint, watch_command_1)
7845         (invalidate_bp_value_on_memory_change): Update.
7846
7847 2018-04-06  Tom Tromey  <tom@tromey.com>
7848
7849         * varobj.c (varobj_clear_saved_item)
7850         (update_dynamic_varobj_children, install_new_value, ~varobj):
7851         Update.
7852         * value.h (value_incref): Move declaration earlier.
7853         (value_decref): Rename from value_free.
7854         (struct value_ref_policy): New.
7855         (value_ref_ptr): New typedef.
7856         (struct value_deleter): Remove.
7857         (gdb_value_up): Remove typedef.
7858         (release_value): Change return type.
7859         (release_value_or_incref): Remove.
7860         * value.c (set_value_parent): Update.
7861         (value_incref): Change return type.
7862         (value_decref): Rename from value_free.
7863         (value_free_to_mark, free_all_values, free_value_chain): Update.
7864         (release_value): Return value_ref_ptr.
7865         (release_value_or_incref): Remove.
7866         (record_latest_value, set_internalvar, clear_internalvar):
7867         Update.
7868         * stack.c (info_frame_command): Don't call value_free.
7869         * python/py-value.c (valpy_dealloc, valpy_new)
7870         (value_to_value_object): Update.
7871         * printcmd.c (do_examine): Update.
7872         * opencl-lang.c (lval_func_free_closure): Update.
7873         * mi/mi-main.c (register_changed_p): Don't call value_free.
7874         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
7875         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
7876         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
7877         value_free.
7878         * guile/scm-value.c (vlscm_free_value_smob)
7879         (vlscm_scm_from_value): Update.
7880         * frame.c (frame_register_unwind, frame_unwind_register_signed)
7881         (frame_unwind_register_unsigned, get_frame_register_bytes)
7882         (put_frame_register_bytes): Don't call value_free.
7883         * findvar.c (address_from_register): Don't call value_free.
7884         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
7885         * dwarf2loc.c (entry_data_value_free_closure)
7886         (value_of_dwarf_reg_entry, free_pieced_value_closure)
7887         (dwarf2_evaluate_loc_desc_full): Update.
7888         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
7889         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
7890         (~watchpoint, watch_command_1)
7891         (invalidate_bp_value_on_memory_change): Update.
7892         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
7893
7894 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
7895
7896         PR gdb/23022
7897         * warning.m4: Add -Wno-error=deprecated-register.
7898         * configure: Re-generate.
7899
7900 2018-04-05  Tom Tromey  <tom@tromey.com>
7901
7902         * linespec.h: Remove include of "vec.h".
7903
7904 2018-04-05  Tom Tromey  <tom@tromey.com>
7905
7906         * linespec.c (typep): Remove typedef.
7907         (find_methods, find_superclass_methods): Take a std::vector.
7908         (find_method): Use std::vector.
7909
7910 2018-04-05  Tom Tromey  <tom@tromey.com>
7911
7912         * utils.c (compare_strings): Remove.
7913         * utils.h (compare_strings): Remove.
7914         * objc-lang.h (find_imps): Update.
7915         * objc-lang.c (find_methods): Take a std::vector.
7916         (uniquify_strings, find_imps): Likewise.
7917         * linespec.c (find_methods): Take a std::vector.
7918         (decode_objc): Use std::vector.
7919         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
7920         a std::vector.
7921         (find_method, find_function_symbols): Use std::vector.
7922
7923 2018-04-05  Tom Tromey  <tom@tromey.com>
7924
7925         * completer.c (completion_tracker::completion_tracker): Remove
7926         cast.
7927         (completion_tracker::discard_completions): Likewise.
7928         * breakpoint.c (ambiguous_names_p): Remove cast.
7929         * ada-lang.c (_initialize_ada_language): Remove cast.
7930         * utils.h (streq): Update.
7931         (streq_hash): Add new declaration.
7932         * utils.c (streq): Return bool.
7933         (streq_hash): New function.
7934
7935 2018-04-05  Tom Tromey  <tom@tromey.com>
7936
7937         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
7938         Remove a string copy.
7939
7940 2018-04-05  Tom Tromey  <tom@tromey.com>
7941
7942         * linespec.c (filter_results): Use std::vector.
7943         (decode_line_2, decode_line_full): Update.
7944
7945 2018-04-05  Tom Tromey  <tom@tromey.com>
7946
7947         * linespec.c (canonical_to_fullform): Return std::string.
7948         (filter_results): Update.
7949         (struct decode_line_2_item): Add constructor.
7950         <fullform, displayform>: Now std::string.
7951         (decode_line_2_compare_items): Now a std::sort comparator.
7952         (decode_line_2): Update.
7953
7954 2018-04-05  Tom Tromey  <tom@tromey.com>
7955
7956         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
7957         (unexpected_linespec_error): Update.
7958         (linespec_parse_basic, parse_linespec): Update.
7959
7960 2018-04-05  Tom Tromey  <tom@tromey.com>
7961
7962         * linespec.c (linespec_parse_basic): Reindent.
7963
7964 2018-04-05  Tom Tromey  <tom@tromey.com>
7965
7966         * minsyms.h (iterate_over_minimal_symbols): Update.
7967         * minsyms.c (iterate_over_minimal_symbols): Take a
7968         gdb::function_view.
7969         * linespec.c (struct collect_minsyms): Remove.
7970         (compare_msyms): Now a std::sort comparator.
7971         (add_minsym): Add parameters.
7972         (search_minsyms_for_name): Update.  Use std::vector.
7973
7974 2018-04-03  Tom Tromey  <tom@tromey.com>
7975
7976         * mipsread.c (read_alphacoff_dynamic_symtab): Use
7977         gdb::byte_vector.
7978
7979 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
7980
7981         * MAINTAINERS (Write After Approval): Add Weimin Pan.
7982
7983 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
7984
7985         PR gdb/16959
7986         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
7987         printing static type.
7988
7989 2018-04-01  Tom Tromey  <tom@tromey.com>
7990
7991         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
7992         (rs6000_xfer_shared_libraries): Update.
7993
7994 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
7995
7996         * common/gdb_vecs.h (char_ptr): Remove.
7997         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
7998
7999 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
8000
8001         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
8002         with std::vector.
8003         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
8004
8005 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
8006
8007         * tracepoint.h (struct uploaded_tp): Initialize fields.
8008         <actions, step_actions, cmd_strings>: Change type to
8009         std::vector<char *>.
8010         * tracepoint.c (get_uploaded_tp): Allocate with new.
8011         (free_uploaded_tps): Free with delete.
8012         (parse_tracepoint_definition): Adjust to std::vector change.
8013         * breakpoint.c (read_uploaded_action): Likewise.
8014         (create_tracepoint_from_upload): Likewise.
8015         * ctf.c (ctf_write_uploaded_tp): Likewise.
8016         (SET_ARRAY_FIELD): Likewise.
8017         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
8018
8019 2018-03-30  Tom Tromey  <tom@tromey.com>
8020
8021         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
8022         std::unique_ptr.
8023         (svr4_keep_data_in_core): Update.
8024         (svr4_read_so_list): Update.
8025
8026 2018-03-30  Tom Tromey  <tom@tromey.com>
8027
8028         * windows-nat.c (handle_output_debug_string, handle_exception):
8029         Update.
8030         * target.h (target_read_string): Update.
8031         * target.c (target_read_string): Change "string" to
8032         unique_xmalloc_ptr.
8033         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
8034         Update.
8035         * solib-frv.c (frv_current_sos): Update.
8036         * solib-dsbt.c (dsbt_current_sos): Update.
8037         * solib-darwin.c (darwin_current_sos): Update.
8038         * linux-thread-db.c (inferior_has_bug): Update.
8039         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
8040         Update.  Remove alloca.
8041         * ada-lang.c (ada_main_name): Update.
8042
8043 2018-03-30  Tom Tromey  <tom@tromey.com>
8044
8045         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
8046         (struct dwo_file_deleter): New.
8047         (dwo_file_up): New typedef.
8048         (open_and_init_dwo_file): Use dwo_file_up.
8049         (free_dwo_file_cleanup): Remove.
8050
8051 2018-03-30  Tom Tromey  <tom@tromey.com>
8052
8053         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
8054         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
8055
8056 2018-03-30  Tom Tromey  <tom@tromey.com>
8057
8058         * dwarf2read.c (class free_cached_comp_units): New class.
8059         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
8060         (free_cached_comp_units): Remove function.
8061
8062 2018-03-30  Tom Tromey  <tom@tromey.com>
8063
8064         * utils.h (make_cleanup_unpush_target): Remove.
8065         * inf-ptrace.c (struct target_unpusher): New.
8066         (target_unpush_up) New typedef.
8067         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
8068         target_unpush_up.
8069         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
8070
8071 2018-03-27  Tom Tromey  <tom@tromey.com>
8072
8073         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
8074
8075 2018-03-27  Pedro Alves  <palves@redhat.com>
8076             Tom Tromey  <tom@tromey.com>
8077
8078         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
8079         destructor.  Now a class.
8080         (gdb_readline_wrapper_cleanup): Remove function.
8081         (gdb_readline_wrapper): Remove cleanups.
8082
8083 2018-03-27  Tom Tromey  <tom@tromey.com>
8084
8085         * typeprint.h (struct type_print_options) <local_typedefs,
8086         global_typedefs>: Remove "struct" keyword.
8087         (class typedef_hash_table): New class.
8088         (recursively_update_typedef_hash, add_template_parameters)
8089         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
8090         (find_typedef_in_hash): Don't declare.
8091         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
8092         (typedef_hash_table::recursively_update): Rename from
8093         recursively_update_typedef_hash.  Now a member.
8094         (typedef_hash_table::add_template_parameters): Rename from
8095         add_template_parameters.  Now a member.
8096         (typedef_hash_table::typedef_hash_table): Now a constructor;
8097         rename from create_typedef_hash.
8098         (typedef_hash_table::~typedef_hash_table): Now a destructor;
8099         rename from free_typedef_hash.
8100         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
8101         (do_free_global_table): Remove.
8102         (typedef_hash_table::typedef_hash_table): New constructor; renamed
8103         from copy_type_recursive.
8104         (create_global_typedef_table): Remove.
8105         (typedef_hash_table::find_global_typedef): Now a member of
8106         typedef_hash_table.
8107         (typedef_hash_table::find_typedef): Rename from
8108         find_typedef_in_hash; now a member.
8109         (whatis_exp): Update.
8110         * extension.h (struct ext_lang_type_printers): Add constructor and
8111         destructor.
8112         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
8113         declare.
8114         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
8115         Now a constructor; rename from start_ext_lang_type_printers.
8116         (ext_lang_type_printers): Now a destructor; rename from
8117         free_ext_lang_type_printers.
8118         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
8119         Update.
8120         (c_type_print_base_struct_union): Update.  Remove cleanups.
8121
8122 2018-03-27  Tom Tromey  <tom@tromey.com>
8123
8124         * dwarf-index-write.c: Include <cmath>.
8125
8126 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
8127
8128         * NEWS: Add entry describing new "set|show varsize-limit" command.
8129         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
8130         command.
8131         * printcmd.c (_initialize_printcmd): Add "set var" alias of
8132         "set variable".
8133
8134 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
8135
8136         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
8137         dwarf-index-write.c
8138         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
8139         * dwarf-index-common.c: New file.
8140         * dwarf-index-common.h: New file.
8141         * dwarf-index-write.c: New file.
8142         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
8143         (struct dwarf2_section_info): Move from here.
8144         (dwarf2_section_info_def): Likewise.
8145         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
8146         (offset_type): Likewise.
8147         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
8148         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
8149         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
8150         (byte_swap): Likewise.
8151         (MAYBE_SWAP): Likewise.
8152         (dwarf2_per_cu_ptr): Likewise.
8153         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
8154         (struct tu_stats): Likewise.
8155         (struct dwarf2_per_objfile): Likewise.
8156         (struct dwarf2_per_cu_data): Likewise.
8157         (struct signatured_type): Likewise.
8158         (sig_type_ptr): Likewise.
8159         (DEF_VEC_P (sig_type_ptr)): Likewise.
8160         (INDEX4_SUFFIX): Likewise.
8161         (INDEX5_SUFFIX): Likewise.
8162         (DEBUG_STR_SUFFIX): Likewise.
8163         (dwarf2_read_section): Make non-static.
8164         (mapped_index_string_hash): Move from here.
8165         (dwarf5_djb_hash): Likewise.
8166         (file_write): Likewise.
8167         (class data_buf): Likewise.
8168         (struct symtab_index_entry): Likewise.
8169         (struct mapped_symtab): Likewise.
8170         (find_slot): Likewise.
8171         (hash_expand): Likewise.
8172         (add_index_entry): Likewise.
8173         (uniquify_cu_indices): Likewise.
8174         (class c_str_view): Likewise.
8175         (class c_str_view_hasher): Likewise.
8176         (class vector_hasher): Likewise.
8177         (write_hash_table): Likewise.
8178         (psym_index_map): Likewise.
8179         (struct addrmap_index_data): Likewise.
8180         (add_address_entry): Likewise.
8181         (add_address_entry_worker): Likewise.
8182         (write_address_map): Likewise.
8183         (symbol_kind): Likewise.
8184         (write_psymbols): Likewise.
8185         (struct signatured_type_index_data): Likewise.
8186         (write_one_signatured_type): Likewise.
8187         (recursively_count_psymbols): Likewise.
8188         (recursively_write_psymbols): Likewise.
8189         (class debug_names): Likewise.
8190         (check_dwarf64_offsets): Likewise.
8191         (psyms_seen_size): Likewise.
8192         (write_gdbindex): Likewise.
8193         (write_debug_names): Likewise.
8194         (assert_file_size): Likewise.
8195         (write_psymtabs_to_index): Likewise.
8196         (save_gdb_index_command): Likewise.
8197         (_initialize_dwarf2_read): Don't register the "save gdb-index"
8198         command.
8199         * dwarf2read.h: New file.
8200
8201 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
8202
8203         PR gdb/22670
8204         * dwarf2read.c (dwarf2_physname): Do not return the demangled
8205         symbol name if the CU's language stores symbol names in linkage
8206         format.
8207         * language.h (struct language_defn)
8208         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
8209         all instances of this struct.
8210
8211 2018-03-26  Tom Tromey  <tom@tromey.com>
8212
8213         * stack.c (backtrace_command_1): Remove verbose code.
8214
8215 2018-03-26  Tom Tromey  <tom@tromey.com>
8216
8217         * python/py-framefilter.c (py_print_type): Don't catch
8218         exceptions.  Return void.
8219         (py_print_value): Likewise.
8220         (py_print_single_arg): Likewise.
8221         (enumerate_args): Don't catch exceptions.
8222         (py_print_args): Likewise.
8223         (py_print_frame): Likewise.
8224         (gdbpy_apply_frame_filter): Catch exceptions here.
8225
8226 2018-03-26  Tom Tromey  <tom@tromey.com>
8227
8228         * stack.c (_initialize_stack): Remove trailing newlines from help
8229         text.  Add "Usage" line to "backtrace" help.
8230
8231 2018-03-26  Tom Tromey  <tom@tromey.com>
8232
8233         PR python/16486:
8234         * python/py-framefilter.c (py_print_args): Call wrap_hint.
8235
8236 2018-03-26  Tom Tromey  <tom@tromey.com>
8237
8238         * python/py-framefilter.c (py_print_single_arg): Return
8239         EXT_LANG_BT_ERROR from catch.
8240
8241 2018-03-26  Tom Tromey  <tom@tromey.com>
8242
8243         PR backtrace/15584:
8244         * stack.c (backtrace_command_1): Move some code into no-filters
8245         "if".
8246
8247 2018-03-26  Tom Tromey  <tom@tromey.com>
8248
8249         * python/py-framefilter.c (throw_quit_or_print_exception): New
8250         function.
8251         (gdbpy_apply_frame_filter): Use it.
8252
8253 2018-03-26  Tom Tromey  <tom@tromey.com>
8254
8255         PR cli/17716:
8256         * python/py-framefilter.c (py_print_type, py_print_value)
8257         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
8258         RETURN_MASK_ERROR.
8259
8260 2018-03-26  Tom Tromey  <tom@tromey.com>
8261
8262         * python/py-framefilter.c (enumerate_args): Use
8263         gdb::unique_xmalloc_ptr.
8264
8265 2018-03-26  Tom Tromey  <tom@tromey.com>
8266
8267         * python/py-framefilter.c (py_print_frame): Return
8268         EXT_LANG_BT_OK.
8269         (gdbpy_apply_frame_filter): Update comment.
8270         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
8271         Remove.
8272         <EXT_LANG_BT_NO_FILTERS>: Change value.
8273
8274 2018-03-26  Tom Tromey  <tom@tromey.com>
8275
8276         PR backtrace/15582:
8277         * stack.c (backtrace_command): Parse "hide" argument.
8278         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
8279         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
8280         constant.
8281
8282 2018-03-26  Tom Tromey  <tom@tromey.com>
8283
8284         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
8285         add "flags".
8286         (backtrace_command): Remove "fulltrace", add "flags".
8287
8288 2018-03-26  Tom Tromey  <tom@tromey.com>
8289
8290         * stack.c (backtrace_command): Rewrite command line parsing.
8291
8292 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
8293
8294         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
8295
8296 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
8297
8298         * filename-seen-cache.h: Add include guard.
8299
8300 2018-03-26  Keith Seitz  <keiths@redhat.com>
8301
8302         * symfile.c (place_section): Remove "struct" from section_addr_info
8303         in comment.
8304         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
8305         "struct" keyword from section_addr_info.
8306
8307 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
8308
8309         * regformats/regdef.h (reg): Add constructors.
8310
8311 2018-03-25  Pedro Alves  <palves@redhat.com>
8312
8313         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
8314         if then/else bodies in var_func_name extraction.
8315
8316 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
8317
8318         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
8319         lookup_minimal_symbol() to find symbol entry.
8320         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
8321
8322 2018-03-23  Keith Seitz  <keiths@redhat.com>
8323
8324         PR c++/22968
8325         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
8326         nested type definitions for C++, too.
8327
8328 2018-03-23  Tom Tromey  <tom@tromey.com>
8329
8330         * machoread.c (struct oso_el): Add a constructor.  Don't define as
8331         a typedef.
8332         (macho_register_oso): Remove.
8333         (macho_symtab_read): Take a std::vector.
8334         (oso_el_compare_name): Now a std::sort comparator.
8335         (macho_symfile_read_all_oso): Take a std::vector.
8336         (macho_symfile_read): Use std::vector.  Remove cleanups.
8337
8338 2018-03-22  Tom Tromey  <tom@tromey.com>
8339
8340         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
8341         (record_full_goto_bookmark): Use std::string.
8342
8343 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
8344
8345         PR tdep/18295
8346         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
8347         a single mask.
8348
8349 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
8350
8351         * rs6000-tdep.c (store_insn_p): New function.
8352         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
8353         and cr_reg to their unshifted values. Use store_insn_p to
8354         match LR saves using either R1 or fdata->alloca_reg. Use
8355         store_insn_p to match CR saves. Set alloca_reg_offset
8356         when alloca_reg and framep are set. Remove lr_reg shift
8357         when assigning to fdata->lr_register.
8358
8359 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
8360
8361         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
8362         command line args instead of emitting a warning.
8363
8364 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
8365
8366         * tracepoint.h (struct static_tracepoint_marker): Initialize
8367         fields, define default constructor, move constructor and move
8368         assignment, disable the rest.
8369         <str_id, extra>: Make std::string.
8370         (release_static_tracepoint_marker): Remove.
8371         (free_current_marker): Remove.
8372         * tracepoint.c (free_current_marker): Remove.
8373         (parse_static_tracepoint_marker_definition): Adjust to
8374         std::string, use new hex2str overload.
8375         (release_static_tracepoint_marker): Remove.
8376         (print_one_static_tracepoint_marker): Get marker by reference
8377         and adjust to std::string.
8378         (info_static_tracepoint_markers_command): Adjust to std::vector
8379         changes
8380         * target.h (static_tracepoint_marker_p): Remove typedef.
8381         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
8382         (struct target_ops) <to_static_tracepoint_marker_at>: Return
8383         bool.
8384         <to_static_tracepoint_markers_by_strid>: Return std::vector.
8385         * target-debug.h
8386         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
8387         (target_debug_print_std_vector_static_tracepoint_marker): New.
8388         (target_debug_print_struct_static_tracepoint_marker_p): Rename
8389         to...
8390         (target_debug_print_static_tracepoint_marker_p): ... this.
8391         * target-delegates.c: Re-generate.
8392         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
8393         Make std::string.
8394         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
8395         (decode_static_tracepoint_spec): Adjust to std::vector.
8396         (tracepoint_print_one_detail): Adjust to std::string.
8397         (strace_marker_decode_location): Adjust to std::string.
8398         (update_static_tracepoint): Adjust to std::string, remove call
8399         to release_static_tracepoint_marker.
8400         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
8401         Adjust to std::vector.
8402         * remote.c (remote_static_tracepoint_marker_at): Return bool.
8403         (remote_static_tracepoint_markers_by_strid): Adjust to
8404         std::vector.
8405         * common/rsp-low.h (hex2str): New overload with explicit count
8406         of bytes.
8407         * common/rsp-low.c (hex2str): New overload with explicit count
8408         of bytes.
8409         * unittests/rsp-low-selftests.c (test_hex2str): New function.
8410         (_initialize_rsp_low_selftests): Add test_hex2str test.
8411         * unittests/tracepoint-selftests.c
8412         (test_parse_static_tracepoint_marker_definition): Adjust to
8413         std::string.
8414
8415 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
8416
8417         * tracepoint.c (parse_static_tracepoint_marker_definition):
8418         Consider case where the definition is followed by more
8419         definitions.
8420         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8421         tracepoint-selftests.c.
8422         * unittests/tracepoint-selftests.c: New.
8423
8424 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
8425
8426         * MAINTAINERS (Write After Approval): Add Pedro Franco de
8427         Carvalho.
8428
8429 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
8430
8431         * symtab.c (find_pc_sect_line): fixed indentation.
8432
8433 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
8434
8435         * symtab.c (find_pc_sect_line): now uses binary search.
8436
8437 2018-03-19  Tom Tromey  <tom@tromey.com>
8438
8439         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
8440         "IDENT" production.
8441
8442 2018-03-19  Pedro Alves  <palves@redhat.com>
8443             Tom Tromey  <tom@tromey.com>
8444
8445         * unittests/observable-selftests.c: New file.
8446         * common/observable.h: New file.
8447         * observable.h: New file.
8448         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
8449         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
8450         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
8451         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
8452         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
8453         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
8454         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
8455         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
8456         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
8457         python/py-breakpoint.c, python/py-finishbreakpoint.c,
8458         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
8459         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
8460         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
8461         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
8462         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
8463         tui/tui-interp.c, valops.c: Update all users.
8464         * tui/tui-hooks.c (tui_bp_created_observer)
8465         (tui_bp_deleted_observer, tui_bp_modified_observer)
8466         (tui_inferior_exit_observer, tui_before_prompt_observer)
8467         (tui_normal_stop_observer, tui_register_changed_observer):
8468         Remove.
8469         (tui_observers_token): New global.
8470         (attach_or_detach, tui_attach_detach_observers): New functions.
8471         (tui_install_hooks, tui_remove_hooks): Use
8472         tui_attach_detach_observers.
8473         * record-btrace.c (record_btrace_thread_observer): Remove.
8474         (record_btrace_thread_observer_token): New global.
8475         * observer.sh: Remove.
8476         * observer.c: Rename to observable.c.
8477         * observable.c (namespace gdb_observers): Define new objects.
8478         (observer_debug): Move into gdb_observers namespace.
8479         (struct observer, struct observer_list, xalloc_observer_list_node)
8480         (xfree_observer_list_node, generic_observer_attach)
8481         (generic_observer_detach, generic_observer_notify): Remove.
8482         (_initialize_observer): Update.
8483         Don't include observer.inc.
8484         * Makefile.in (generated_files): Remove observer.h, observer.inc.
8485         (clean mostlyclean): Likewise.
8486         (observer.h, observer.inc): Remove targets.
8487         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
8488         (COMMON_SFILES): Use observable.c, not observer.c.
8489         * .gitignore: Remove observer.h.
8490
8491 2018-03-18  Tom Tromey  <tom@tromey.com>
8492
8493         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
8494         gdb::def_vector.
8495         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
8496
8497 2018-03-17  Tom Tromey  <tom@tromey.com>
8498
8499         * auto-load.c (auto_load_objfile_script_1): Use std::string.
8500
8501 2018-03-17  Tom Tromey  <tom@tromey.com>
8502
8503         * target.c (class scoped_target_fd): New.
8504         (target_fileio_close_cleanup): Remove.
8505         (target_fileio_read_alloc_1): Use scoped_target_fd.
8506
8507 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
8508
8509         * silent-rules.mk: New.
8510         * Makefile.in: Include silent-rules.mk
8511         (srcdir, VPATH, top_srcdir): Move up.
8512         (COMPILE): Add ECHO_CXX.
8513         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
8514         (init.c): Add ECHO_INIT_C.
8515         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
8516         (version.c): Add ECHO_GEN.
8517         (printcmd.o): Add ECHO_CXX.
8518         (target-float.o): Add ECHO_CXX.
8519         (ada-exp.o): Add ECHO_CXX.
8520         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
8521         (insight$(EXEEXT)): Add ECHO_CXXLD.
8522         * gnulib/configure.ac: Add AM_SILENT_RULES.
8523         * gnulib/aclocal.m4: Re-generate.
8524         * gnulib/configure: Re-generate.
8525         * gnulib/import/Makefile.in: Re-generate.
8526
8527 2018-03-16  Tom Tromey  <tom@tromey.com>
8528
8529         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
8530         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
8531         * utils.c (do_free_section_addr_info)
8532         (make_cleanup_free_section_addr_info): Remove.
8533         * symfile.h (struct other_sections): Add constructor.
8534         (struct section_addr_info): Remove.
8535         (section_addr_info): New typedef.
8536         (struct sym_fns) <sym_offsets>: Change type of parameter.
8537         (build_section_addr_info_from_objfile)
8538         (relative_addr_info_to_section_offsets, addr_info_make_relative)
8539         (default_symfile_offsets, symbol_file_add)
8540         (symbol_file_add_from_bfd)
8541         (build_section_addr_info_from_section_table): Update.
8542         (alloc_section_addr_info, free_section_addr_info): Don't declare.
8543         * symfile.c (alloc_section_addr_info): Remove.
8544         (build_section_addr_info_from_section_table): Change return type.
8545         Update.
8546         (build_section_addr_info_from_bfd)
8547         (build_section_addr_info_from_objfile): Likewise.
8548         (free_section_addr_info): Remove.
8549         (relative_addr_info_to_section_offsets): Change type of "addrs".
8550         (addrs_section_compar): Now a std::sort comparator.
8551         (addrs_section_sort): Change return type.
8552         (addr_info_make_relative): Change type of "addrs".  Update.
8553         (default_symfile_offsets, syms_from_objfile_1)
8554         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
8555         (symbol_file_add_separate): Update.
8556         (symbol_file_add): Change type of "addrs".  Update.
8557         (add_symbol_file_command): Update.  Remove cleanups.
8558         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
8559         cleanups.
8560         * symfile-debug.c (debug_sym_offsets): Change type of "info".
8561         * solib.c (solib_read_symbols): Update.
8562         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
8563         * machoread.c (macho_symfile_offsets): Update.
8564         * jit.c (jit_bfd_try_read_symtab): Update.
8565
8566 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
8567
8568         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8569         unittests/utils-selftests.c.
8570         * unittests/utils-selftests.c: New file.
8571
8572 2018-03-14  Tom Tromey  <tom@tromey.com>
8573
8574         PR cli/14977:
8575         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
8576         for NULL.
8577
8578 2018-03-14  Tom Tromey  <tom@tromey.com>
8579
8580         PR cli/19918:
8581         * printcmd.c (printf_pointer): Allow "-" in format.
8582
8583 2018-03-14  Tom Tromey  <tom@tromey.com>
8584
8585         * printcmd.c (_initialize_printcmd): Add usage to printf.
8586
8587 2018-03-14  Yao Qi  <qiyao@sourceware.org>
8588
8589         * MAINTAINERS: Update my email address.
8590
8591 2018-03-13  Tom Tromey  <tom@tromey.com>
8592
8593         * machoread.c (macho_check_dsym): Change filenamep to a
8594         std::string*.
8595         (macho_symfile_read): Update.
8596         * symfile.c (load_command): Use std::string.
8597
8598 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8599
8600         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
8601         to error message string.
8602         (riscv_register_name): Use xsnprintf instead of sprintf.
8603         (riscv_insn::fetch_instruction): Use gdb_assert instead of
8604         internal_error.
8605         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
8606         error.
8607         (riscv_push_dummy_call): Likewise.
8608
8609 2018-03-12  Tom Tromey  <tom@tromey.com>
8610
8611         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
8612         Use gdb::byte_vector.
8613         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
8614
8615 2018-03-12  Yao Qi  <yao.qi@linaro.org>
8616
8617         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
8618         parameter type to readable_regcache.
8619         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
8620         the declaration.
8621
8622 2018-03-11  Tom Tromey  <tom@tromey.com>
8623
8624         * dwarf2read.c (struct nextfield): Add initializers.
8625         (struct nextfnfield): Remove.
8626         (struct fnfieldlist): Add initializers.  Remove "length" and
8627         "head", use std::vector.
8628         (struct decl_field_list): Remove.
8629         (struct field_info): Add initializers.
8630         <fields, baseclasses>: Now std::vector.
8631         <nbaseclasses, nfnfields, typedef_field_list_count,
8632         nested_types_list_count>: Remove.
8633         (dwarf2_add_field, dwarf2_add_type_defn)
8634         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
8635         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
8636         (process_structure_scope): Update.
8637
8638 2018-03-11  Tom Tromey  <tom@tromey.com>
8639
8640         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
8641         for use by std::sort.
8642         (build_type_psymtabs_1): Use std::vector.
8643
8644 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
8645
8646         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
8647         and LIBMPFR in the printed configuration.
8648
8649 2018-03-08  Tom Tromey  <tom@tromey.com>
8650
8651         * source.c (get_filename_and_charpos): Use scoped_fd.
8652         * nto-procfs.c (procfs_open_1): Use scoped_fd.
8653         (procfs_pidlist): Likewise.
8654         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
8655         (iterate_over_mappings): Likewise.
8656
8657 2018-03-08  Tom Tromey  <tom@tromey.com>
8658
8659         * infcall.c (struct call_return_meta_info)
8660         <stack_temporaries_enabled>: Remove.
8661         (get_call_return_value, call_function_by_hand_dummy): Update.
8662         * thread.c (disable_thread_stack_temporaries): Remove.
8663         (enable_thread_stack_temporaries): Remove.
8664         (thread_stack_temporaries_enabled_p): Return bool.
8665         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
8666         (get_last_thread_stack_temporary): Update.
8667         * eval.c (evaluate_subexp): Update.
8668         * gdbthread.h (class enable_thread_stack_temporaries): Now a
8669         class, not a function.
8670         (value_ptr, value_vec): Remove typedefs.
8671         (class thread_info) <stack_temporaries_enabled>: Now bool.
8672         <stack_temporaries>: Now a std::vector.
8673         (thread_stack_temporaries_enabled_p)
8674         (value_in_thread_stack_temporaries): Return bool.
8675
8676 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
8677
8678         * remote.c (putpkt_binary): Fix omitted bytes reporting.
8679         (getpkt_or_notif_sane_1): Likewise.
8680
8681 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
8682
8683         * build-id.c (build_id_to_debug_bfd): Use std::string.
8684
8685 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
8686
8687         * build-id.c (find_separate_debug_file_by_buildid): Return
8688         std::string.
8689         * build-id.h (find_separate_debug_file_by_buildid): Return
8690         std::string.
8691         * coffread.c (coff_symfile_read): Adjust to std::string.
8692         * elfread.c (elf_symfile_read): Adjust to std::string.
8693         * symfile.c (separate_debug_file_exists): Change parameter to
8694         std::string.
8695         (find_separate_debug_file): Return std::string.
8696         (find_separate_debug_file_by_debuglink): Return std::string.
8697         * symfile.h (find_separate_debug_file_by_debuglink): Return
8698         std::string.
8699
8700 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
8701
8702         * common/xml-utils.c (xml_escape_text): Move code to...
8703         (xml_escape_text_append): ... this new function.
8704         * common/xml-utils.h (xml_escape_text_append): New declaration.
8705         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
8706         New function.
8707         (_initialize_xml_utils): register test_xml_escape_text_append as
8708         a selftest.
8709
8710 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
8711
8712         * defs.h: Remove MAX_REGISTER_SIZE.
8713         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
8714         asserts.
8715         * python/py-unwind.c (pyuw_sniffer): Likewise.
8716
8717 2018-03-07  Tom Tromey  <tom@tromey.com>
8718
8719         * linux-tdep.c (linux_info_proc): Update.
8720         * target.h (struct target_ops) <to_fileio_readlink>: Return
8721         optional<string>.
8722         (target_fileio_readlink): Return optional<string>.
8723         * remote.c (remote_hostio_readlink): Return optional<string>.
8724         * inf-child.c (inf_child_fileio_readlink): Return
8725         optional<string>.
8726         * target.c (target_fileio_readlink): Return optional<string>.
8727
8728 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8729
8730         * regcache.c (cooked_read_test): Add riscv to the list of
8731         architectures that have a save_reggroup.
8732
8733 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
8734
8735         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
8736         value is not a dynamic class object.
8737
8738 2018-03-06  Tom Tromey  <tom@tromey.com>
8739
8740         * rust-exp.y: Formatting fixes.
8741
8742 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8743
8744         * riscv-tdep.c (riscv_register_name): Remove target description
8745         support.
8746         (riscv_gdbarch_init): Remove target description check.
8747
8748 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8749
8750         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
8751         comment.
8752         * riscv-tdep.h: Likewise.
8753
8754 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8755
8756         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
8757         (riscv_pseudo_register_write): Delete.
8758         (riscv_gdbarch_init): Remove all use of pseudo registers.
8759
8760 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
8761
8762         * record-btrace.c (btrace_print_lines): Replace cleanup
8763         parameter with RAII equivalents.
8764         (btrace_insn_history): Replace cleanup with RAII equivalents.
8765         * ui-out.h (make_cleanup_ui_out_list_begin_end,
8766         make_cleanup_ui_out_tuple_begin_end): Remove.
8767         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
8768         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
8769         make_cleanup_ui_out_list_begin_end): Remove.
8770
8771 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
8772
8773         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
8774         parameter types to std::vector.  Use bool.
8775         (record_btrace_wait): Replace VEC(tp_t) with
8776         std::vector<thread_info *>.
8777         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
8778
8779 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
8780
8781         * record-btrace.c (record_btrace_disable_callback): Remove.
8782         (struct scoped_btrace_disable): New.
8783         (record_btrace_open): Use scoped_btrace_disable.
8784
8785 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8786
8787         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
8788         reading values from registers.
8789
8790 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8791
8792         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
8793         where appropriate.
8794
8795 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8796
8797         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
8798         change parameter type.  Use GDB's print functions, and use
8799         core_addr_to_string where appropriate.
8800         (riscv_push_dummy_call): Use core_addr_to_string where
8801         appropriate, update call to riscv_print_arg_location, and reindent
8802         a few lines.
8803         (riscv_return_value): Update call to riscv_print_arg_location.
8804
8805 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8806             Tim Newsome <tim@sifive.com>
8807             Albert Ou <a0u@eecs.berkeley.edu>
8808             Darius Rad <darius@bluespec.com>
8809
8810         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
8811         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
8812         (ALLDEPFILES): Add riscv-tdep.c
8813         * configure.tgt: Add riscv support.
8814         * riscv-tdep.c: New file.
8815         * riscv-tdep.h: New file.
8816         * NEWS: Mention new target.
8817         * MAINTAINERS: Add entry for riscv.
8818
8819 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8820
8821         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
8822         fields within aggregates.
8823
8824 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
8825
8826         * record-btrace.c (btrace_print_lines): Change type of flags to
8827         gdb_disassembly_flags.
8828
8829 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
8830
8831         * fbsd-nat.c: Include "inf-ptrace.h".
8832         (USE_SIGTRAP_SIGINFO): Conditionally define.
8833         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
8834         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
8835         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
8836         function.
8837         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
8838         Likewise.
8839         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
8840         Likewise.
8841         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
8842         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
8843         "supports_stopped_by_hw_breakpoint" target methods.
8844
8845 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
8846
8847         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
8848         * fbsd-nat.c (debug_fbsd_nat): New variable.
8849         (show_fbsd_nat_debug): New function.
8850         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
8851         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
8852
8853 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
8854
8855         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
8856         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
8857         prototype.
8858         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
8859         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
8860         method.
8861
8862 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8863
8864         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
8865         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
8866
8867 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8868
8869         * charset.c (struct charset_vector): New.
8870         (charsets): Change type to charset_vector.
8871         (find_charset_names): Adjust.
8872         (add_one): Adjust.
8873         (_initialize_charset): Adjust.
8874
8875 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8876
8877         * progspace.h (struct program_space) <deleted_solibs>: Change
8878         type to std::vector<std::string>.
8879         * progspace.c (clear_program_space_solib_cache): Adjust.
8880         * breakpoint.c (print_solib_event): Adjust.
8881         (check_status_catch_solib): Adjust.
8882         * solib.c (update_solib_list): Adjust.
8883         * ui-out.h (class ui_out) <field_string>: New overload.
8884         * ui-out.c (ui_out::field_string): New overload.
8885
8886 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8887
8888         * progspace.h (struct program_space): Add constructor and
8889         destructor, initialize fields.
8890         (add_program_space): Remove.
8891         * progspace.c (add_program_space): Rename to...
8892         (program_space::program_space): ... this.
8893         (release_program_space): Rename to...
8894         (program_space::~program_space): ... this.
8895         (delete_program_space): Use delete to delete program_space.
8896         (initialize_progspace): Use new to allocate program_space.
8897         * inferior.c (add_inferior_with_spaces): Likewise.
8898         (clone_inferior_command): Likewise.
8899         * infrun.c (follow_fork_inferior): Likewise.
8900         (handle_vfork_child_exec_or_exit): Likewise.
8901
8902 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8903
8904         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
8905         (delim_string_to_char_ptr_vec): Return std::vector of
8906         gdb::unique_xmalloc_ptr.
8907         (dirnames_to_char_ptr_vec_append): Take std::vector of
8908         gdb::unique_xmalloc_ptr.
8909         (dirnames_to_char_ptr_vec): Return std::vector of
8910         gdb::unique_xmalloc_ptr.
8911         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
8912         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
8913         (delim_string_to_char_ptr_vec): Return an std::vector of
8914         gdb::unique_xmalloc_ptr, adjust the code.
8915         (dirnames_to_char_ptr_vec_append): Take an std::vector of
8916         gdb::unique_xmalloc_ptr, adjust the code.
8917         (dirnames_to_char_ptr_vec): Return an std::vector of
8918         gdb::unique_xmalloc_ptr, adjust the code.
8919         * auto-load.c (auto_load_safe_path_vec): Change type to
8920         std::vector of gdb::unique_xmalloc_ptr.
8921         (auto_load_expand_dir_vars): Return an std::vector of
8922         gdb::unique_xmalloc_ptr, adjust the code.
8923         (auto_load_safe_path_vec_update): Adjust.
8924         (filename_is_in_auto_load_safe_path_vec): Adjust.
8925         (auto_load_objfile_script_1): Adjust.
8926         * build-id.c (build_id_to_debug_bfd): Adjust.
8927         * linux-thread-db.c (thread_db_load_search): Adjust.
8928         * source.c (add_path): Adjust.
8929         (openp): Adjust.
8930         * symfile.c (find_separate_debug_file): Adjust.
8931         * utils.c (do_free_char_ptr_vec): Remove.
8932         (make_cleanup_free_char_ptr_vec): Remove.
8933
8934 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8935
8936         PR gdb/22907
8937         * common/pathstuff.c: Conditionally include "<windows.h>".
8938
8939 2018-03-01  Georg Sauthoff  <mail@georg.so>
8940
8941         PR gdb/22888
8942         * gcore.in: Quote variables and switch interpreter to bash.
8943
8944 2018-03-01  Tom Tromey  <tom@tromey.com>
8945
8946         * dwarf2read.c (alloc_discriminant_info): Fix default_index
8947         assertion.  Add assertion for discriminant_index.
8948         (quirk_rust_enum): Use correct base type name in univariant case.
8949
8950 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
8951
8952         * record.c (get_call_history_modifiers): Return a
8953         record_print_flags.
8954         (cmd_record_call_history): Adjust.
8955         * record-btrace.c (record_btrace_call_history): Adjust.
8956         (record_btrace_call_history_range): Adjust.
8957         (record_btrace_call_history_from): Adjust.
8958         * target-debug.h (target_debug_print_record_print_flags): New.
8959         * target-delegates.c: Re-generate.
8960         * target.c (target_call_history): Change flags type.
8961         (target_call_history_from): Likewise.
8962         (target_call_history_range): Likewise.
8963         * target.h (struct target_ops) <target_call_history>: Likewise.
8964         (target_call_history_from): Likewise.
8965         (target_call_history_range): Likewise.
8966
8967 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8968             Simon Marchi  <simon.marchi@polymtl.ca>
8969
8970         * common/common-utils.c: Include "sys/stat.h".
8971         (is_regular_file): Move here from "source.c"; change return
8972         type to "bool".
8973         * common/common-utils.h (is_regular_file): New prototype.
8974         * common/pathstuff.c (contains_dir_separator): New function.
8975         * common/pathstuff.h (contains_dir_separator): New prototype.
8976         * source.c: Don't include "sys/stat.h".
8977         (is_regular_file): Move to "common/common-utils.c".
8978
8979 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8980
8981         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
8982         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
8983         * auto-load.c: Include "common/pathstuff.h".
8984         * common/common-def.h (current_directory): Move here.
8985         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
8986         function.
8987         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
8988         prototype.
8989         * common/pathstuff.c: New file.
8990         * common/pathstuff.h: New file.
8991         * compile/compile.c: Include "common/pathstuff.h".
8992         * defs.h (current_directory): Move to "common/common-defs.h".
8993         * dwarf2read.c: Include "common/pathstuff.h".
8994         * exec.c: Likewise.
8995         * guile/scm-safe-call.c: Likewise.
8996         * linux-thread-db.c: Likewise.
8997         * main.c: Likewise.
8998         * nto-tdep.c: Likewise.
8999         * objfiles.c: Likewise.
9000         * source.c: Likewise.
9001         * symtab.c: Likewise.
9002         * utils.c: Include "common/pathstuff.h".
9003         (gdb_realpath): Move to "common/pathstuff.c".
9004         (gdb_realpath_keepfile): Likewise.
9005         (gdb_abspath): Likewise.
9006         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
9007         (gdb_realpath_keepfile): Likewise.
9008         (gdb_abspath): Likewise.
9009
9010 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
9011
9012         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
9013         wildcard process pid for super_resume for kernels with a
9014         specific bug.
9015
9016 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
9017
9018         * compile/compile.c (get_args): Add additional comments
9019         explaining function.
9020
9021 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
9022             Tom Tromey  <tom@tromey.com>
9023
9024         * target.h (memory_write_request_s): Remove typedef.  Don't define
9025         VEC.
9026         (target_write_memory_blocks): Change argument to std::vector.
9027         (struct memory_write_request): Add constructor.
9028         * target-memory.c (compare_block_starting_address): Return bool.
9029         Change argument types.
9030         (claim_memory): Change arguments to use std::vector.
9031         (split_regular_and_flash_blocks, blocks_to_erase)
9032         (compute_garbled_blocks): Likewise.
9033         (cleanup_request_data, cleanup_write_requests_vector): Remove.
9034         (target_write_memory_blocks): Change argument to std::vector.
9035         * symfile.c (struct load_section_data): Add constructor and
9036         destructor.  Use std::vector for "requests".
9037         (struct load_progress_data): Add initializers.
9038         (load_section_callback): Update.  Use "new".
9039         (clear_memory_write_data): Remove.
9040         (generic_load): Update.
9041
9042 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
9043
9044         * arch/aarch64.h: Use common/tdesc.h.
9045
9046 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
9047
9048         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
9049         architecture with a 64-bit ABI.
9050
9051 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
9052
9053         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
9054         ahead of target description loading.
9055
9056 2018-02-26  Tom Tromey  <tom@tromey.com>
9057
9058         * stack.c (backtrace_command_1): Update.
9059         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
9060         of "flags".
9061         * python/py-framefilter.c (py_print_frame)
9062         (gdbpy_apply_frame_filter): Change type of "flags".
9063         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
9064         of "flags".
9065         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
9066         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
9067         * extension.h (enum frame_filter_flag): Rename from
9068         frame_filter_flags.
9069         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
9070         (apply_ext_lang_frame_filter): Change type of "flags".
9071         * extension.c (apply_ext_lang_frame_filter): Change type of
9072         "flags".
9073         * extension-priv.h (struct extension_language_ops)
9074         <apply_frame_filter>: Change type of "flags".
9075
9076 2018-02-26  Tom Tromey  <tom@tromey.com>
9077
9078         PR python/16497:
9079         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
9080         off-by-one in py_end computation.
9081         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
9082         PRINT_MORE_FRAMES.
9083         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
9084         constant.
9085
9086 2018-02-26  Tom Tromey  <tom@tromey.com>
9087
9088         * dwarf2read.c (struct variant_field): New.
9089         (struct nextfield) <variant>: New field.
9090         (dwarf2_add_field): Handle DW_TAG_variant_part.
9091         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
9092         discriminated union.
9093         (read_structure_type): Handle DW_TAG_variant_part.
9094         (handle_struct_member_die): New function, extracted from
9095         process_structure_scope.  Handle DW_TAG_variant.
9096         (process_structure_scope): Handle discriminated unions.  Call
9097         handle_struct_member_die.
9098
9099 2018-02-26  Tom Tromey  <tom@tromey.com>
9100
9101         * rust-lang.h (rust_last_path_segment): Declare.
9102         * rust-lang.c (rust_last_path_segment): Now public.  Change
9103         contract.
9104         (struct disr_info): Remove.
9105         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
9106         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
9107         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
9108         (rust_enum_p, rust_enum_variant): New function.
9109         (rust_underscore_fields): Remove "offset" parameter.
9110         (rust_print_enum): New function.
9111         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
9112         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
9113         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
9114         enums.
9115         (rust_internal_print_type): New function, from rust_print_type.
9116         Remove enum code.
9117         (rust_print_type): Call rust_internal_print_type.
9118         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
9119         Update enum handling.
9120         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
9121         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
9122         (rust_union_quirks): New functions.
9123         (process_full_comp_unit, process_full_type_unit): Call
9124         rust_union_quirks.
9125         (process_structure_scope): Update rust_unions if necessary.
9126
9127 2018-02-26  Tom Tromey  <tom@tromey.com>
9128
9129         * value.h (value_union_variant): Declare.
9130         * valops.c (value_union_variant): New function.
9131         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
9132         (struct discriminant_info): New.
9133         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
9134         enumerator.
9135         (struct main_type) <flag_discriminated_union>: New field.
9136
9137 2018-02-26  Tom Tromey  <tom@tromey.com>
9138
9139         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9140         unittests/unpack-selftests.c.
9141         * unittests/unpack-selftests.c: New file.
9142         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
9143
9144 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9145
9146         * dwarf2read.c (struct partial_die_info) <read>: New method.
9147         (read_partial_die): Remove the declaration.
9148         (load_partial_dies): Update.
9149         (partial_die_info::partial_die_info):
9150         (read_partial_die): Change it to partial_die_info::read.
9151
9152 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9153
9154         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
9155         (fixup_partial_die): Remove declaration.
9156         (scan_partial_symbols): Update.
9157         (partial_die_parent_scope): Likewise.
9158         (partial_die_full_name): Likewise.
9159         (fixup_partial_die): Change it to partial_die_info::fixup.
9160
9161 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9162
9163         * dwarf2read.c (read_partial_die): Update the declaration.
9164         (load_partial_dies): Caller update.
9165         (read_partial_die): Remove one argument abbrev_len.
9166
9167 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9168
9169         * dwarf2read.c (struct partial_die_info): Add ctor, delete
9170         assignment operator.
9171         (load_partial_dies): Use ctor and copy ctor.
9172         (read_partial_die): Update.
9173         (dwarf2_cu::find_partial_die): Use ctor.
9174
9175 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9176
9177         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
9178         (find_partial_die_in_comp_unit): Change it to
9179         dwarf2_cu::find_partial_die.
9180         (find_partial_die): Update.
9181
9182 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9183
9184         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
9185         is NULL.
9186
9187 2018-02-26  Yao Qi  <yao.qi@linaro.org>
9188
9189         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
9190
9191 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
9192
9193         * arch/amd64.h: Use common/tdesc.h.
9194         * arch/i386.c: Likewise.
9195         * arch/i386.h: Likewise.
9196         * arch/tic6x.c: Likewise.
9197         * arch/tdesc.h: Move file from here...
9198         * common/tdesc.h: ...to here.
9199         * features/aarch64-core.c: Regenerate.
9200         * features/aarch64-fpu.c: Regenerate.
9201         * features/i386/32bit-avx.c: Regenerate.
9202         * features/i386/32bit-avx512.c: Regenerate.
9203         * features/i386/32bit-core.c: Regenerate.
9204         * features/i386/32bit-linux.c: Regenerate.
9205         * features/i386/32bit-mpx.c: Regenerate.
9206         * features/i386/32bit-pkeys.c: Regenerate.
9207         * features/i386/32bit-sse.c: Regenerate.
9208         * features/i386/64bit-avx.c: Regenerate.
9209         * features/i386/64bit-avx512.c: Regenerate.
9210         * features/i386/64bit-core.c: Regenerate.
9211         * features/i386/64bit-linux.c: Regenerate.
9212         * features/i386/64bit-mpx.c: Regenerate.
9213         * features/i386/64bit-pkeys.c: Regenerate.
9214         * features/i386/64bit-segments.c: Regenerate.
9215         * features/i386/64bit-sse.c: Regenerate.
9216         * features/i386/x32-core.c: Regenerate.
9217         * features/tic6x-c6xp.c: Regenerate.
9218         * features/tic6x-core.c: Regenerate.
9219         * features/tic6x-gp.c: Regenerate.
9220         * target-descriptions.c: Use common/tdesc.h.
9221         * target-descriptions.h: Likewise.
9222
9223 2018-02-24  Tom Tromey  <tom@tromey.com>
9224
9225         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
9226         (try_thread_db_load_from_dir, thread_db_load_search): Use
9227         std::string.
9228         (info_auto_load_libthread_db_compare): Return bool.  Change
9229         argument types.
9230         (info_auto_load_libthread_db): Use std::vector, std::string.
9231         Remove cleanups.
9232
9233 2018-02-24  Tom Tromey  <tom@tromey.com>
9234
9235         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
9236         std::string.
9237         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
9238         std::string*.
9239         * gdbarch.c: Rebuild.
9240         * gdbarch.h: Rebuild.
9241         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
9242         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
9243         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
9244         std::string*.
9245
9246 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
9247
9248         * gdbtypes.h (sect_offset): Change type to uint64_t.
9249         (sect_offset_str): New function.
9250         * dwarf2read.c (create_addrmap_from_aranges): Use
9251         sect_offset_str.
9252         (error_check_comp_unit_head): Likewise.
9253         (create_debug_type_hash_table): Likewise.
9254         (read_cutu_die_from_dwo): Likewise.
9255         (init_cutu_and_read_dies): Likewise.
9256         (init_cutu_and_read_dies_no_follow): Likewise.
9257         (process_psymtab_comp_unit_reader): Likewise.
9258         (partial_die_parent_scope): Likewise.
9259         (peek_die_abbrev): Likewise.
9260         (process_queue): Likewise.
9261         (dwarf2_physname): Likewise.
9262         (read_namespace_alias): Likewise.
9263         (read_import_statement): Likewise.
9264         (create_dwo_cu_reader): Likewise.
9265         (create_cus_hash_table): Likewise.
9266         (lookup_dwo_cutu): Likewise.
9267         (inherit_abstract_dies): Likewise.
9268         (read_func_scope): Likewise.
9269         (read_call_site_scope): Likewise.
9270         (dwarf2_add_member_fn): Likewise.
9271         (read_common_block): Likewise.
9272         (read_module_type): Likewise.
9273         (read_typedef): Likewise.
9274         (read_subrange_type): Likewise.
9275         (load_partial_dies): Likewise.
9276         (read_partial_die): Likewise.
9277         (find_partial_die): Likewise.
9278         (read_str_index): Likewise.
9279         (dwarf2_string_attr): Likewise.
9280         (build_error_marker_type): Likewise.
9281         (lookup_die_type): Likewise.
9282         (dump_die_shallow): Likewise.
9283         (follow_die_ref): Likewise.
9284         (dwarf2_fetch_die_loc_sect_off): Likewise.
9285         (dwarf2_fetch_constant_bytes): Likewise.
9286         (follow_die_sig): Likewise.
9287         (get_signatured_type): Likewise.
9288         (get_DW_AT_signature_type): Likewise.
9289         (dwarf2_find_containing_comp_unit): Likewise.
9290         (set_die_type): Likewise.
9291
9292 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
9293
9294         * arch/aarch64.c: Include "common-defs.h".
9295         * arch/amd64.c: Likewise.
9296         * arch/i386.c: Likewise.
9297
9298 2018-02-21  Tom Tromey  <tom@tromey.com>
9299
9300         * value.h: (extract_field_op): Update.
9301         * eval.c (extract_field_op): Return a const char *.
9302         * expression.h (parse_expression_for_completion): Update.
9303         * completer.c (complete_expression): Update.
9304         (add_struct_fields): Make fieldname const.
9305         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
9306         (mark_completion_tag, parse_exp_in_context_1): Update.
9307         (parse_expression_for_completion): Change "name" to
9308         unique_xmalloc_ptr*.
9309
9310 2018-02-21  Tom Tromey  <tom@tromey.com>
9311
9312         * infcall.c (call_function_by_hand_dummy): Use std::vector.
9313
9314 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9315
9316         * avr-tdep.c (avr_read_pc): Change parameter type to
9317         readable_regcache.
9318         * gdbarch.sh (read_pc): Likewise.
9319         * gdbarch.c: Re-generated.
9320         * gdbarch.h: Re-generated.
9321         * hppa-tdep.c (hppa_read_pc): Change parameter type to
9322         readable_regcache.
9323         * ia64-tdep.c (ia64_read_pc): Likewise.
9324         * mips-tdep.c (mips_read_pc): Likewise.
9325         * spu-tdep.c (spu_read_pc): Likewise.
9326
9327 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9328
9329         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
9330         * regcache-dump.c: New file.
9331         * regcache.c: Move register_dump to regcache-dump.c.
9332         (maintenance_print_registers): Likewise.
9333         (maintenance_print_raw_registers): Likewise.
9334         (maintenance_print_cooked_registers): Likewise.
9335         (maintenance_print_register_groups): Likewise.
9336         (maintenance_print_remote_registers): Likewise.
9337         (_initialize_regcache): Likewise.
9338         * regcache.h (register_dump): Moved from regcache.c.
9339
9340 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9341
9342         * regcache.c (regcache::regcache): Update.
9343         (regcache::invalidate): Move it to detached_regcache::invalidate.
9344         (get_thread_arch_aspace_regcache): Update.
9345         (regcache::raw_update): Update.
9346         (regcache::cooked_read): Remove some code.
9347         (regcache::cooked_read_value): Likewise.
9348         (regcache::raw_write): Remove assert on m_readonly_p.
9349         (regcache::raw_supply_integer): Move it to
9350         detached_regcache::raw_supply_integer.
9351         (regcache::raw_supply_zeroed): Likewise.
9352         * regcache.h (detached_regcache) <raw_supply_integer>: New
9353         declaration.
9354         <raw_supply_zeroed, invalidate>: Likewise.
9355         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
9356         <invalidate>: Likewise.
9357         <m_readonly_p>: Removed.
9358
9359 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9360
9361         * infcmd.c (get_return_value): Let stop_regs point to
9362         get_current_regcache.
9363         * regcache.c (regcache::regcache): Remove.
9364         (register_dump_reg_buffer): New class.
9365         (regcache_print): Adjust.
9366         * regcache.h (regcache): Remove constructors.
9367
9368 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9369
9370         * regcache.c (class register_dump): New class.
9371         (register_dump_regcache, register_dump_none): New class.
9372         (register_dump_remote, register_dump_groups): New class.
9373         (regcache_print): Update.
9374         * regcache.h (regcache_dump_what): Move it to regcache.c.
9375         (regcache) <dump>: Remove.
9376
9377 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9378
9379         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
9380          reg_buffer_rw *.
9381         (jit_unwind_reg_set_impl): Call raw_supply.
9382         (jit_frame_sniffer): Use reg_buffer_rw.
9383         * record-full.c (record_full_core_regbuf): Change its type.
9384         (record_full_core_open_1): Use reg_buffer_rw.
9385         (record_full_close): Likewise.
9386         (record_full_core_fetch_registers): Use regcache->raw_supply.
9387         (record_full_core_store_registers): Likewise.
9388         * regcache.c (regcache::get_register_status): Move it to
9389         reg_buffer.
9390         (regcache_raw_set_cached_value): Remove.
9391         (regcache::raw_set_cached_value): Remove.
9392         (regcache::raw_write): Call raw_supply.
9393         (regcache::raw_supply): Move it to reg_buffer_rw.
9394         * regcache.h (regcache_raw_set_cached_value): Remove.
9395         (reg_buffer_rw): New class.
9396
9397 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9398
9399         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
9400         readonly_detached_regcache.
9401         (dummy_frame_prev_register): Use regcache->cooked_read.
9402         * frame.c (frame_save_as_regcache): Change return type.
9403         (frame_pop): Update.
9404         * frame.h (frame_save_as_regcache): Update declaration.
9405         * inferior.h (get_infcall_suspend_state_regcache): Update
9406         declaration.
9407         * infrun.c (infcall_suspend_state) <registers>: use
9408         readonly_detached_regcache.
9409         (save_infcall_suspend_state): Don't use regcache_dup.
9410         (get_infcall_suspend_state_regcache): Change return type.
9411         * linux-fork.c (struct fork_info) <savedregs>: Change to
9412         readonly_detached_regcache.
9413         <pc>: New field.
9414         (fork_save_infrun_state): Don't use regcache_dup.
9415         (info_checkpoints_command): Adjust.
9416         * mi/mi-main.c (register_changed_p): Update declaration.
9417         (mi_cmd_data_list_changed_registers): Use
9418         readonly_detached_regcache.
9419         (register_changed_p): Change parameter type to
9420         readonly_detached_regcache.
9421         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
9422         readonly_detached_regcache.
9423         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
9424         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
9425         New.
9426         (regcache::save): Move it to reg_buffer.
9427         (regcache::restore): Change parameter type.
9428         (regcache_dup): Remove.
9429         * regcache.h (reg_buffer) <save>: New method.
9430         (readonly_detached_regcache): New class.
9431         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
9432         readonly_detached_regcache.
9433         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
9434
9435 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9436
9437         * frame.c (frame_save_as_regcache): Use regcache method save.
9438         (frame_pop): Use regcache method restore.
9439         * infrun.c (restore_infcall_suspend_state): Likewise.
9440         * linux-fork.c (fork_load_infrun_state): Likewise.
9441         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
9442         save.
9443         * regcache.c (regcache_save): Remove.
9444         (regcache::restore): More asserts.
9445         (regcache_cpy): Remove.
9446         * regcache.h (regcache_save): Remove the declaration.
9447         (regcache::restore): Move from private to public.
9448         Remove the friend declaration of regcache_cpy.
9449         (regcache_cpy): Remove declaration.
9450
9451 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9452
9453         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
9454         parameter type to 'readable_regcache *'.
9455         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
9456         * arm-tdep.c (arm_neon_quad_read): Likewise.
9457         (arm_pseudo_read): Likewise.
9458         * avr-tdep.c (avr_pseudo_register_read): Likewise.
9459         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
9460         * frv-tdep.c (frv_pseudo_register_read): Likewise.
9461         * gdbarch.c: Re-generated.
9462         * gdbarch.h: Re-generated.
9463         * gdbarch.sh (pseudo_register_read): Change parameter type to
9464         'readable_regcache *'.
9465         (pseudo_register_read_value): Likewise.
9466         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
9467         (h8300_pseudo_register_read): Likewise.
9468         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
9469         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
9470         (i386_pseudo_register_read_into_value): Likewise.
9471         (i386_pseudo_register_read_value): Likewise.
9472         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
9473         declaration.
9474         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
9475         * m32c-tdep.c (m32c_raw_read): Likewise.
9476         (m32c_read_flg): Likewise.
9477         (m32c_banked_register): Likewise.
9478         (m32c_banked_read): Likewise.
9479         (m32c_sb_read): Likewise.
9480         (m32c_part_read): Likewise.
9481         (m32c_cat_read): Likewise.
9482         (m32c_r3r2r1r0_read): Likewise.
9483         (m32c_pseudo_register_read): Likewise.
9484         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
9485         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
9486         (mep_pseudo_cr64_read): Likewise.
9487         (mep_pseudo_register_read): Likewise.
9488         * mips-tdep.c (mips_pseudo_register_read): Likewise.
9489         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
9490         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
9491         * regcache.c (regcache::raw_read): Move it to readable_regcache.
9492         (regcache::cooked_read): Likewise.
9493         (regcache::cooked_read_value): Likewise.
9494         (regcache_cooked_read_signed):
9495         (regcache::cooked_read): Likewise.
9496         * regcache.h (readable_regcache): New class.
9497         (regcache): Inherit readable_regcache.  Move some methods to
9498         readable_regcache.
9499         * rl78-tdep.c (rl78_pseudo_register_read): Change
9500         parameter type to 'readable_regcache *'.
9501         * rs6000-tdep.c (do_regcache_raw_read): Remove.
9502         (e500_pseudo_register_read): Change parameter type to
9503         'readable_regcache *'.
9504         (dfp_pseudo_register_read): Likewise.
9505         (vsx_pseudo_register_read): Likewise.
9506         (efpr_pseudo_register_read): Likewise.
9507         * s390-tdep.c (s390_pseudo_register_read): Likewise.
9508         * sh-tdep.c (sh_pseudo_register_read): Likewise.
9509         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
9510         (sh64_pseudo_register_read): Likewise.
9511         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
9512         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
9513         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
9514         (spu_pseudo_register_read): Likewise.
9515         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
9516         (xtensa_pseudo_register_read): Likewise.
9517
9518 2018-02-21  Yao Qi  <yao.qi@linaro.org>
9519
9520         * regcache.c (regcache::regcache): Call reg_buffer ctor.
9521         (regcache::arch): Move it to reg_buffer::arch.
9522         (regcache::register_buffer): Likewise.
9523         (regcache::assert_regnum): Likewise.
9524         (regcache::num_raw_registers): Likewise.
9525         * regcache.h (reg_buffer): New class.
9526         (regcache): Inherit reg_buffer.
9527
9528 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
9529
9530         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
9531         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
9532
9533 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
9534
9535         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
9536
9537 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
9538
9539         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
9540         (SFILES): Remove common/*.c files.
9541         (COMMON_OBS): Remove some *.o files built from common/*.c files.
9542         * common/common.host: Add common reference.
9543         * configure.ac: Likewise.
9544         * configure: Regenerate.
9545
9546 2018-02-16  Yao Qi  <yao.qi@linaro.org>
9547
9548         * block.c (block_namespace_info): Inherit allocate_on_obstack.
9549         (block_initialize_namespace): Use new.
9550         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
9551         (dwarf2_free_objfile): Use delete.
9552         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
9553         (copy_type_recursive): Use new.
9554         * gdb_obstack.h (allocate_on_obstack): New.
9555
9556 2018-02-15  Yao Qi  <yao.qi@linaro.org>
9557
9558         PR gdb/22849
9559         * inferior.c (exit_inferior_1): Reset inf->control.
9560
9561 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
9562
9563         * ada-lang.c (ada_to_fixed_value_create): Delete advance
9564         declaration.
9565
9566 2018-02-14  Pedro Alves  <palves@redhat.com>
9567
9568         * frame-unwind.c (frame_unwind_try_unwinder): Always call
9569         frame_cleanup_after_sniffer on exception.
9570
9571 2018-02-14  Tom Tromey  <tom@tromey.com>
9572
9573         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
9574         const.
9575         (solib_bfd_open): Make pathname const.
9576         * solib.c (solib_bfd_open): Make pathname const.
9577         * solib-spu.c (spu_bfd_fopen): Make name const.
9578         (spu_bfd_open): Make pathname const.
9579         * solib-darwin.c (darwin_bfd_open): Make pathname const.
9580         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
9581
9582 2018-02-14  Tom Tromey  <tom@tromey.com>
9583
9584         * symfile.c (symfile_bfd_open): Update.
9585         * source.h (openp, source_full_path_of, find_and_open_source):
9586         Change argument type to unique_xmalloc_ptr.
9587         * source.c (openp): Take a unique_xmalloc_ptr.
9588         (source_full_path_of, find_and_open_source): Likewise.
9589         (open_source_file, symtab_to_fullname): Update.
9590         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
9591         unique_xmalloc_ptr.
9592         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
9593         (exec_file_find): Update.
9594         * psymtab.c (psymtab_to_fullname): Update.
9595         * nto-tdep.h (nto_find_and_open_solib): Update.
9596         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
9597         unique_xmalloc_ptr.
9598         * exec.c (exec_file_attach): Update.
9599         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
9600         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
9601
9602 2018-02-14  Tom Tromey  <tom@tromey.com>
9603
9604         * solib.c: Include source.h.
9605         * nto-tdep.c: Include source.h.
9606         * mi/mi-cmd-env.c: Include source.h.
9607         * infcmd.c: Include source.h.
9608         * exec.c: Include source.h.
9609         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
9610         (add_path, directory_switch, source_path, init_source_path): Move
9611         declarations...
9612         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
9613         (add_path, directory_switch, source_path, init_source_path):
9614         ...here.
9615
9616 2018-02-14  Tom Tromey  <tom@tromey.com>
9617
9618         * solist.h (exec_file_find, solib_find): Return
9619         unique_xmalloc_ptr.
9620         (solib_bfd_fopen): Take a const char *.
9621         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
9622         (exec_file_find, solib_find): Likewise.
9623         (solib_bfd_fopen): Do not take ownership of "pathname".
9624         (solib_bfd_open): Use unique_xmalloc_ptr.
9625         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
9626         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
9627         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
9628         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
9629
9630 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
9631
9632         * ada-lang.c (name_match_type_from_name): Remove reference to
9633         ada_name_for_lookup in function's documentation.
9634         * ada-lang.h (ada_name_for_lookup): Delete declaration.
9635
9636 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
9637
9638         * defs.h (enum openp_flags): New enum.
9639         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
9640         Move to enum openp_flags.
9641         (openp_flags): New enum flags.
9642         (openp): Change parameter type to openp_flags.
9643         * source.c (openp): Change parameter type to openp_flags.
9644         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
9645         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
9646
9647 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
9648
9649         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
9650         per-command.
9651
9652 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9653
9654         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
9655         into...
9656         (class dwarf2_queue_guard): ...the destructor of this new class.
9657         (dw2_do_instantiate_symtab): Create instance of the new class
9658         dwarf2_queue_guard, remove cleanup.
9659
9660 2018-02-09  Tom Tromey  <tom@tromey.com>
9661
9662         * source.c (find_source_lines): Don't reference past the end of
9663         the vector.
9664
9665 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9666
9667         * remote.c (remote_btrace_maybe_reopen): Change error message.
9668         * btrace.c (btrace_enable): Likewise.
9669         (parse_xml_btrace): Likewise.
9670         (parse_xml_btrace_conf): Likewise.
9671
9672 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9673
9674         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
9675         (linux_enable_pt, linux_enable_bts): Call
9676         diagnose_perf_event_open_fail.
9677
9678 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9679
9680         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
9681         Remove parameter and change return type.  Update callers.  Move it.
9682         (linux_enable_bts, linux_enable_pt): Improve error message.
9683         (linux_enable_pt): Remove zero buffer size check.
9684         (linux_enable_btrace): Improve error messages.  Remove NULL return
9685         check.
9686
9687 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9688
9689         * btrace.c (btrace_enable): Remove target_supports_btrace call.
9690         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
9691         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
9692         (linux_supports_pt, linux_supports_btrace): Remove.
9693         (linux_enable_bts): Call cpu_supports_bts.
9694         * nat/linux-btrace.h (linux_supports_btrace): Remove.
9695         * remote.c (remote_supports_btrace): Remove.
9696         (init_remote_ops): Remove remote_supports_btrace.
9697         * target-delegates.c: Regenerated.
9698         * target.c (target_supports_btrace): Remove.
9699         * target.h (target_ops) <to_supports_btrace>: Remove
9700         (target_supports_btrace): Remove.
9701         * x86-linux-nat.c (x86_linux_create_target): Remove
9702         linux_supports_btrace.
9703
9704 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9705
9706         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
9707         btrace failed.
9708         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
9709         exception and use message in own exception.
9710
9711 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9712
9713         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
9714         (perf_event_pt_event_type): Use gdb_file_up.
9715         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
9716         scoped_fd, and scoped_mmap.
9717
9718 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9719
9720         * common/scoped_mmap.h: New.
9721         * unittests/scoped_mmap-selftest.c: New.
9722         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9723         unittests/scoped_mmap-selftest.c.
9724
9725 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
9726
9727         * common/scoped_fd.h: New.
9728         * unittests/scoped_fd-selftest.c: New.
9729         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9730         unittests/scoped_fd-selftest.c.
9731
9732 2018-02-09  Tom Tromey  <tom@tromey.com>
9733
9734         * auto-load.c (auto_load_section_scripts): Use
9735         gdb::unique_xmalloc_ptr.
9736
9737 2018-02-09  Tom Tromey  <tom@tromey.com>
9738
9739         * auto-load.c (execute_script_contents): Use std::string.
9740
9741 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
9742
9743         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
9744         Python function, rather than a new command.
9745
9746 2018-02-08  Tom Tromey  <tom@tromey.com>
9747
9748         * solib.c (solib_find_1): Use std::string.
9749         (solib_bfd_fopen): Use unique_xmalloc_ptr.
9750
9751 2018-02-08  Tom Tromey  <tom@tromey.com>
9752
9753         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
9754
9755 2018-02-08  Tom Tromey  <tom@tromey.com>
9756
9757         * source.c (find_source_lines): Use gdb::def_vector.
9758
9759 2018-02-08  Tom Tromey  <tom@tromey.com>
9760
9761         * macrocmd.c (struct temporary_macro_definition): New.
9762         (macro_define_command): Use temporary_macro_definition.  Remove
9763         cleanups.
9764         (free_macro_definition_ptr): Remove.
9765
9766 2018-02-08  Tom Tromey  <tom@tromey.com>
9767
9768         * macroexp.c (maybe_expand): Use std::string.
9769
9770 2018-02-08  Tom Tromey  <tom@tromey.com>
9771
9772         * macroexp.c (struct macro_buffer): Add initializers for some
9773         members.
9774         (init_buffer, init_shared_buffer, free_buffer)
9775         (free_buffer_return_text): Remove.
9776         (macro_buffer): New constructors.
9777         (~macro_buffer): New destructor.
9778         (macro_buffer::set_shared): New method.
9779         (macro_buffer::resize_buffer, macro_buffer::appendc)
9780         (macro_buffer::appendmem): Now methods, not free functions.
9781         (set_token, append_tokens_without_splicing, stringify)
9782         (macro_stringify): Update.
9783         (gather_arguments): Change return type.  Remove argc_p argument,
9784         add args_ptr argument.  Use std::vector.
9785         (substitute_args): Remove argc argument.  Accept std::vector.
9786         (expand): Update.  Use std::vector.
9787         (scan, macro_expand, macro_expand_next): Update.
9788
9789 2018-02-08  Tom Tromey  <tom@tromey.com>
9790
9791         * symtab.c (default_collect_symbol_completion_matches_break_on):
9792         Use unique_xmalloc_ptr.
9793         * macroscope.h: (sal_macro_scope, user_macro_scope)
9794         (default_macro_scope): Return unique_xmalloc_ptr.
9795         * macroscope.c (sal_macro_scope, user_macro_scope)
9796         (default_macro_scope): Return unique_xmalloc_ptr.
9797         * macroexp.h (macro_expand, macro_expand_once): Return
9798         unique_xmalloc_ptr.
9799         * macroexp.c (macro_expand, macro_expand_once): Return
9800         unique_xmalloc_ptr.
9801         * macrocmd.c (macro_expand_command, macro_expand_once_command)
9802         (info_macro_command, info_macros_command): Use
9803         unique_xmalloc_ptr.
9804         * compile/compile-c-support.c (write_macro_definitions): Use
9805         unique_xmalloc_ptr.
9806         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
9807
9808 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
9809
9810         * value.c (value_static_field): Assign field type instead of
9811         containing type when returning an optimized out value.
9812
9813 2018-02-06  Yao Qi  <yao.qi@linaro.org>
9814
9815         * ft32-tdep.c (ft32_read_pc): Remove.
9816         (ft32_write_pc): Remove.
9817         (ft32_gdbarch_init): Update.
9818         * m32r-tdep.c (m32r_read_pc): Remove.
9819         (m32r_gdbarch_init): Update.
9820         * mep-tdep.c (mep_read_pc): Remove.
9821         (mep_gdbarch_init): Update.
9822         * microblaze-tdep.c (microblaze_write_pc): Remove.
9823         (microblaze_gdbarch_init): Update.
9824         * mn10300-tdep.c (mn10300_read_pc): Remove.
9825         (mn10300_write_pc): Remove.
9826         (mn10300_gdbarch_init): Update.
9827         * moxie-tdep.c (moxie_read_pc): Remove.
9828         (moxie_write_pc): Remove.
9829         (moxie_gdbarch_init): Update.
9830
9831 2018-02-06  Yao Qi  <yao.qi@linaro.org>
9832
9833         * expprint.c (print_subexp_standard): Handle
9834         OP_F77_UNDETERMINED_ARGLIST.
9835         (dump_subexp_body_standard): Likewise.
9836
9837 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
9838
9839         * target-descriptions.c (tdesc_element_visitor) Add empty
9840         implementations.
9841         (tdesc_type): Move make_gdb_type from here.
9842         (tdesc_type_builtin): Likewise.
9843         (tdesc_type_vector): Likewise.
9844         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
9845         (make_gdb_type_struct): Move from tdesc_type_with_fields.
9846         (make_gdb_type_union): Likewise.
9847         (make_gdb_type_flags): Likewise.
9848         (make_gdb_type_enum): Likewise.
9849         (make_gdb_type): New function.
9850         (tdesc_register_type): Use static make_gdb_type.
9851
9852 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
9853
9854         * infcmd.c (default_print_one_register_info): Align natural-format
9855         column values consistently one under another.
9856         (pad_to_column): New function.
9857
9858 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
9859
9860         * dwarf2read.c (dwarf2_physname): Move commment.
9861
9862 2018-02-01  Leszek Swirski  <leszeks@google.com>
9863
9864         * varobj.c (varobj_formatted_print_options): Allow recursive
9865         pretty printing if pretty printing is enabled.
9866
9867 2018-02-01  Leszek Swirski  <leszeks@google.com>
9868
9869         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
9870         names after a structop as a filename.
9871
9872 2018-02-01  Yao Qi  <yao.qi@linaro.org>
9873
9874         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
9875         (arm_record_coproc_data_proc): Likewise.
9876
9877 2018-02-01  Yao Qi  <yao.qi@linaro.org>
9878
9879         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
9880
9881 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
9882
9883         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
9884         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
9885
9886 2018-01-31  Pedro Alves  <palves@redhat.com>
9887
9888         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
9889         * inflow.c (child_terminal_save_inferior): Wrap reference to
9890         tcgetpgrp in HAVE_TERMIOS_H.
9891         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
9892         _WIN32.
9893         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
9894         always iterate over all inferiors.
9895         (gdbsim_cntrl_c): Adjust.
9896         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
9897
9898 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
9899
9900         * gdbtypes.c (lookup_array_range_type): Make sure the array's
9901         index type is objfile-owned if the element type is as well.
9902
9903 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
9904
9905         GDB 8.1 released.
9906
9907 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
9908
9909         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
9910         "features/s390x-linux64.c".
9911         (_initialize_s390_linux_tdep): Remove initialization of tdescs
9912         s390_linux32 and s390x_linux64.
9913         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
9914         default tdesc.
9915         * s390-tdep.c: Include "features/s390-linux32.c" and
9916         "features/s390x-linux64.c".
9917         (s390_tdesc_valid): Add check for tdesc_has_registers.
9918         (s390_gdbarch_init): Make sure there is always a valid tdesc.
9919         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
9920         tdesc_s390x_linux64.
9921         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
9922         tdesc_s390x_linux64 to...
9923         * s390-tdep.h: ...here.
9924
9925 2018-01-30  Pedro Alves  <palves@redhat.com>
9926
9927         PR gdb/13211
9928         * config.in, configure: Regenerate.
9929         * configure.ac: Check for getpgid.
9930         * go32-nat.c (go32_pass_ctrlc): New.
9931         (go32_target): Install it.
9932         * inf-child.c (inf_child_target): Install
9933         child_terminal_save_inferior, child_pass_ctrlc and
9934         child_interrupt.
9935         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
9936         (inf_ptrace_target): No longer install it.
9937         * infcmd.c (interrupt_target_1): Adjust.
9938         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
9939         (child_interrupt): Declare.
9940         (inferior::terminal_state): New.
9941         * inflow.c (struct terminal_info): Update comments.
9942         (inferior_process_group): Delete.
9943         (terminal_is_ours): Delete.
9944         (gdb_tty_state): New.
9945         (child_terminal_init): Adjust.
9946         (is_gdb_terminal, sharing_input_terminal_1)
9947         (sharing_input_terminal): New functions.
9948         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
9949         Set the process's actual process group in the foreground if
9950         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
9951         mark terminal as the inferior's if not sharing GDB's terminal.
9952         Don't check attach_flag.
9953         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
9954         pass down a target_terminal_state.
9955         (child_terminal_save_inferior): New, factored out from ...
9956         (child_terminal_ours_1): ... this.  Handle
9957         target_terminal_state::is_ours_for_output.
9958         (child_interrupt, child_pass_ctrlc): New.
9959         (inflow_inferior_exit): Clear the inferior's terminal_state.
9960         (copy_terminal_info): Copy the inferior's terminal state.
9961         (_initialize_inflow): Remove reference to terminal_is_ours.
9962         * inflow.h (inferior_process_group): Delete.
9963         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
9964         * procfs.c (procfs_target): Don't install procfs_interrupt.
9965         (procfs_interrupt): Delete.
9966         * remote.c (remote_serial_quit_handler): Adjust.
9967         (remote_interrupt): Remove ptid parameter.  Adjust.
9968         * target-delegates.c: Regenerate.
9969         * target.c: Include "terminal.h".
9970         (target_terminal::terminal_state): Rename to ...
9971         (target_terminal::m_terminal_state): ... this.
9972         (target_terminal::init): Adjust.
9973         (target_terminal::inferior): Adjust to per-inferior
9974         terminal_state.
9975         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
9976         (target_terminal::ours, target_terminal::ours_for_output): Use
9977         target_terminal_is_ours_kind.
9978         (target_interrupt): Remove ptid parameter.  Adjust.
9979         (default_target_pass_ctrlc): Adjust.
9980         * target.h (target_ops::to_terminal_save_inferior): New field.
9981         (target_ops::to_interrupt): Remove ptid_t parameter.
9982         (target_interrupt): Remove ptid_t parameter.  Update comment.
9983         (target_pass_ctrlc): Update comment.
9984         * target/target.h (target_terminal_state): New scoped enum,
9985         factored out of ...
9986         (target_terminal::terminal_state): ... here.
9987         (target_terminal::inferior): Update comments.
9988         (target_terminal::restore_inferior): New.
9989         (target_terminal::is_inferior, target_terminal::is_ours)
9990         (target_terminal::is_ours_for_output): Adjust.
9991         (target_terminal::scoped_restore_terminal_state): Adjust to
9992         rename, and call restore_inferior() instead of inferior().
9993         (target_terminal::scoped_restore_terminal_state::m_state): Change
9994         type.
9995         (target_terminal::terminal_state): Rename to ...
9996         (target_terminal::m_terminal_state): ... this and change type.
9997
9998 2018-01-30  Pedro Alves  <palves@redhat.com>
9999
10000         * linux-nat.c (wait_for_signal): New function.
10001         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
10002         directly.
10003         (async_terminal_is_ours)
10004         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
10005         (linux_nat_add_target): Don't override
10006         to_terminal_inferior/to_terminal_ours.
10007
10008 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10009
10010         * remote.c (remote_follow_fork): Don't call "detach_inferior".
10011
10012 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
10013
10014         * dwarf2read.c (free_dwo_files): Add forward-declaration.
10015         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
10016         dwarf2_per_objfile_free here.
10017         (dwarf2_per_objfile_free): Remove.
10018         (_initialize_dwarf2_read): Don't register
10019         dwarf2_per_objfile_free as a registry cleanup.
10020
10021 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
10022
10023         Avoid compilation errors in MinGW native builds
10024
10025         The error is triggered by including python-internal.h, and the
10026         error message is:
10027
10028              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
10029                       from build-gnulib/import/math.h:27,
10030                       from d:/usr/Python26/include/pyport.h:235,
10031                       from d:/usr/Python26/include/Python.h:58,
10032                       from python/python-internal.h:94,
10033                       from python/py-arch.c:24:
10034              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
10035         using ::hypot;
10036                 ^~~~~
10037
10038         This happens because Python headers define 'hypot' to expand t
10039         '_hypot' in the Windows builds.
10040         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
10041         'hypoth'.  This avoids a compilation error.
10042
10043 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
10044
10045         * MAINTAINERS (Write After Approval): Fix ordering.
10046
10047 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
10048
10049         * MAINTAINERS (Write After Approval): Add Alan Hayward.
10050
10051 2018-01-26  Alan Modra  <amodra@gmail.com>
10052
10053         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
10054         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
10055         Remove nop.  Make const.  Comment.
10056         (powerpc32_plt_stub_so_2): New.
10057         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
10058         Correct count.  Update uses.
10059         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
10060         Move common code reading PLT entry word.  Correct
10061         powerpc32_plt_stub PLT address calculation.
10062         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
10063         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
10064         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
10065         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
10066         (ppc64_standard_linkage8): Likewise.
10067         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
10068         Correct insns description.
10069         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
10070
10071 2018-01-24  Pedro Alves  <palves@redhat.com>
10072
10073         GCC PR libstdc++/83906
10074         * gdbtypes.c (operator==(const dynamic_prop &,
10075         const dynamic_prop &)): New.
10076         (operator==(const range_bounds &, const range_bounds &)): New.
10077         (check_types_equal): Use them instead of memcmp.
10078         * gdbtypes.h (operator==(const dynamic_prop &,
10079         const dynamic_prop &)): Declare.
10080         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
10081         (operator==(const range_bounds &, const range_bounds &)): Declare.
10082         (operator!=(const range_bounds &, const range_bounds &)): Declare.
10083
10084 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10085
10086         * s390-linux-tdep.c (s390_record_address_mask)
10087         (s390_record_calc_disp_common, s390_record_calc_disp)
10088         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
10089         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
10090         (s390_process_record): Move to s390-tdep.c.
10091         (s390_linux_init_abi_any): Adjust.
10092         * s390-tdep.c (s390_record_address_mask)
10093         (s390_record_calc_disp_common, s390_record_calc_disp)
10094         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
10095         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
10096         (s390_process_record): Moved from s390-linux-tdep.c
10097         (s390_gdbarch_init): Adjust.
10098
10099 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10100
10101         * s390-linux-nat.c (s390-tdep.h): New include.
10102         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
10103         (HFILES_NO_SRCDIR): Add s390-tdep.h.
10104         (ALLDEPFILES): Add s390-tdep.c.
10105         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
10106         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
10107         * s390-tdep.h: ...this.  New file.
10108         * s390-linux-tdep.c (s390-tdep.h): New include.
10109         (_initialize_s390_tdep): Rename to...
10110         (_initialize_s390_linux_tdep): ...this and adjust.
10111         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
10112         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
10113         s390-tdep.h.
10114         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
10115         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
10116         (s390_is_partial_instruction, s390_software_single_step)
10117         (is_non_branch_ril, s390_displaced_step_copy_insn)
10118         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
10119         (s390_prologue_data, s390_addr, s390_store, s390_load)
10120         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
10121         (s390_register_call_saved, s390_guess_tracepoint_registers)
10122         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
10123         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
10124         (s390_pseudo_register_name, s390_pseudo_register_type)
10125         (s390_pseudo_register_read, s390_pseudo_register_write)
10126         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
10127         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
10128         (s390_addr_bits_remove, s390_address_class_type_flags)
10129         (s390_address_class_type_flags_to_name)
10130         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
10131         (s390_function_arg_float, s390_function_arg_vector)
10132         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
10133         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
10134         (s390_frame_align, s390_register_return_value, s390_return_value)
10135         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
10136         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
10137         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
10138         (s390_trad_frame_prev_register, s390_unwind_cache)
10139         (s390_prologue_frame_unwind_cache)
10140         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
10141         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
10142         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
10143         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
10144         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
10145         (s390_frame_base_address, s390_local_base_address)
10146         (s390_frame_base, s390_gcc_target_options)
10147         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
10148         (s390_validate_reg_range, s390_tdesc_valid)
10149         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
10150         * s390-tdep.c: ...this.  New file.
10151
10152 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10153
10154         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
10155         (s390_process_record, s390_gdbarch_tdep_alloc)
10156         (s390_linux_init_abi_any): Use/set new hook.
10157
10158 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10159
10160         * s390-linux-tdep.c (osabi.h): New include.
10161         (s390_linux_init_abi_31, s390_linux_init_abi_64)
10162         (s390_linux_init_abi_any): New functions.
10163         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
10164
10165 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10166
10167         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
10168         tdesc_has_registers check
10169
10170 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10171
10172         * s390-linux-tdep.c (s390_tdesc_valid): New function.
10173         (s390_validate_reg_range): New macro.
10174         (s390_gdbarch_init): Adjust.
10175
10176 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10177
10178         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
10179         (s390_gdbarch_tdep_alloc): Adjust.
10180         (s390_gdbarch_init): Adjust.
10181
10182 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10183
10184         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
10185         <have_tdb>: Change type to bool.
10186         (s390_gdbarch_tdep_alloc): Adjust.
10187         (s390_gdbarch_init): Adjust.
10188
10189 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10190
10191         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
10192         (gdbarch_tdep) <have_upper, have_vx>: New fields.
10193         (s390_gdbarch_tdep_alloc): New function.
10194         (s390_gdbarch_init): Allocate tdep at start and use its fields
10195         instead of separate variables.
10196
10197 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
10198
10199         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
10200         when looking for cached gdbarch and add comment for remaining.
10201
10202 2018-01-22  Pedro Alves  <palves@redhat.com>
10203             Sergio Durigan Junior  <sergiodj@redhat.com>
10204
10205         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
10206         case.
10207
10208 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
10209
10210         * MAINTAINERS: Update my company e-mail address.
10211
10212 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10213
10214         * regcache.c (cooked_write_test): New function.
10215         (_initialize_regcache): Register the test.
10216
10217 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10218
10219         * ia64-tdep.c (ia64_pseudo_register_read): Call
10220         regcache->cooked_read instead of regcache_cooked_read_unsigned.
10221         * m32c-tdep.c (m32c_cat_read): Likewise.
10222         (m32c_r3r2r1r0_read): Likewise.
10223         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
10224         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
10225
10226 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10227
10228         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
10229         method raw_read instead of regcache_raw_read.
10230         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
10231         * arm-tdep.c (arm_neon_quad_read): Likewise.
10232         * avr-tdep.c (avr_pseudo_register_read): Likewise.
10233         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
10234         * frv-tdep.c (frv_pseudo_register_read): Likewise.
10235         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
10236         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
10237         (i386_pseudo_register_read_into_value): Likewise.
10238         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
10239         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
10240         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
10241         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
10242         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
10243         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
10244         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
10245         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
10246         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
10247
10248 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10249
10250         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
10251         * configure.tgt: Remove target mt.
10252         * mt-tdep.c: Remove.
10253         * regcache.c (cooked_read_test): Remove the check for mt.
10254
10255 2018-01-22  Yao Qi  <yao.qi@linaro.org>
10256
10257         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
10258         instead of gdbarch_pseudo_register_read_value.
10259
10260 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
10261
10262         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
10263         language is Ada.
10264
10265 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
10266
10267         * linespec.c (create_sals_line_offset): Remove code that preserved
10268         the symtab_and_line's line number.
10269
10270 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10271
10272         * varobj.c (varobj_create): Don't set valid_block when creating a
10273         floating varobj.
10274
10275 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10276
10277         * varobj.c (varobj_create): Remove out of date comment.
10278
10279 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10280
10281         PR mi/20395
10282         * ada-exp.y (write_var_from_sym): Pass extra parameter when
10283         updating innermost block.
10284         * parse.c (innermost_block_tracker::update): Take extra type
10285         parameter, and check types match before updating innermost block.
10286         (write_dollar_variable): Update innermost block for registers.
10287         * parser-defs.h (enum innermost_block_tracker_type): New enum.
10288         (innermost_block_tracker::innermost_block_tracker): Initialise
10289         m_types member.
10290         (innermost_block_tracker::reset): Take type parameter.
10291         (innermost_block_tracker::update): Take type parameter, and pass
10292         type through as needed.
10293         (innermost_block_tracker::m_types): New member.
10294         * varobj.c (varobj_create): Pass type when reseting innermost
10295         block.
10296
10297 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10298
10299         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
10300         * ada-lang.c (resolve_subexp): Likewise.
10301         * breakpoint.c (set_breakpoint_condition) Likewise.
10302         (watch_command_1) Likewise.
10303         * c-exp.y (variable): Likewise.
10304         * d-exp.y (PrimaryExpression): Likewise.
10305         * f-exp.y (variable): Likewise.
10306         * go-exp.y (variable): Likewise.
10307         * m2-exp.y (variable): Likewise.
10308         * objfiles.c (objfile::~objfile): Likewise.
10309         * p-exp.y (variable): Likewise.
10310         * parse.c (innermost_block): Change type.
10311         * parser-defs.h (class innermost_block_tracker): New.
10312         (innermost_block): Change to innermost_block_tracker.
10313         * printcmd.c (display_command): Switch to innermost_block API.
10314         (do_one_display): Likewise.
10315         * rust-exp.y (do_one_display): Likewise.
10316         * symfile.c (clear_symtab_users): Likewise.
10317         * varobj.c (varobj_create): Switch to innermost_block API, replace
10318         use of innermost_block with block stored on varobj object.
10319
10320 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10321
10322         * expression.h (innermost_block): Remove declaration.
10323         * varobj.c: Add 'parser-defs.h' include.
10324
10325 2018-01-19  Tom Tromey  <tom@tromey.com>
10326
10327         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
10328         symbols in the static and global blocks.
10329
10330 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
10331
10332         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
10333         gdb_ptrace.h, and move including gdb_wait.h ...
10334         * nat/linux-ptrace.h: ... to here.
10335
10336 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
10337
10338         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
10339         inf_ptrace_detach_success.
10340         (inf_ptrace_detach_success): Add inferior parameter, use it
10341         instead of inferior_ptid, pass it to detach_inferior.
10342         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
10343         parameter.
10344         * inferior.c (detach_inferior): Add overload that takes an
10345         inferior object.
10346         * inferior.h (detach_inferior): Likewise.
10347         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
10348         use inferior_ptid, adjust call to inf_ptrace_detach_success.
10349         * linux-thread-db.c (thread_db_detach): Use inf parameter.
10350
10351 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
10352
10353         * target.h (struct target_ops) <to_detach>: Add inferior
10354         parameter.
10355         (target_detach): Likewise.
10356         * target.c (dispose_inferior): Pass inferior down.
10357         (target_detach): Pass inferior down.  Assert that it is equal to
10358         the current inferior.
10359         * aix-thread.c (aix_thread_detach): Pass inferior down.
10360         * corefile.c (core_file_command): Pass current_inferior() down.
10361         * corelow.c (core_detach): Add inferior parameter.
10362         * darwin-nat.c (darwin_detach): Likewise.
10363         * gnu-nat.c (gnu_detach): Likewise.
10364         * inf-ptrace.c (inf_ptrace_detach): Likewise.
10365         * infcmd.c (detach_command): Pass current_inferior() down to
10366         target_detach.
10367         * infrun.c (follow_fork_inferior): Pass parent_inf to
10368         target_detach.
10369         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
10370         target_detach.
10371         * linux-nat.c (linux_nat_detach): Add inferior parameter.
10372         * linux-thread-db.c (thread_db_detach): Likewise.
10373         * nto-procfs.c (procfs_detach): Likewise.
10374         * procfs.c (procfs_detach): Likewise.
10375         * record.c (record_detach): Likewise.
10376         * record.h (struct inferior): Forward-declare.
10377         (record_detach): Add inferior parameter.
10378         * remote-sim.c (gdbsim_detach): Likewise.
10379         * remote.c (remote_detach_1): Likewise.
10380         (remote_detach): Likewise.
10381         (extended_remote_detach): Likewise.
10382         * sol-thread.c (sol_thread_detach): Likewise.
10383         * target-debug.h (target_debug_print_inferior_p): New macro.
10384         * target-delegates.c: Re-generate.
10385         * top.c (kill_or_detach): Pass inferior down to target_detach.
10386         * windows-nat.c (windows_detach): Add inferior parameter.
10387
10388 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
10389
10390         * target.h (struct target_ops) <to_detach>: Remove args
10391         parameter.
10392         (target_detach): Likewise.
10393         * target.c (dispose_inferior): Adjust.
10394         (target_detach): Remove args parameter, adjust.
10395         * aix-thread.c (aix_thread_detach): Adjust.
10396         * corefile.c (core_file_command): Adjust.
10397         * corelow.c (core_detach): Adjust.
10398         * darwin-nat.c (darwin_detach): Adjust.
10399         * gnu-nat.c (gnu_detach): Adjust.
10400         * inf-ptrace.c (inf_ptrace_detach): Adjust.
10401         * infcmd.c (detach_command): Adjust
10402         * infrun.c (follow_fork_inferior): Adjust.
10403         (handle_vfork_child_exec_or_exit): Adjust.
10404         * linux-fork.c (linux_fork_detach): Remove args parameter.
10405         * linux-fork.h (linux_fork_detach): Likewise.
10406         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
10407         * linux-thread-db.c (thread_db_detach): Likewise.
10408         * nto-procfs.c (procfs_detach): Likewise.
10409         * procfs.c (procfs_detach): Likewise.
10410         (do_detach): Remove signo parameter.
10411         * record.c (record_detach): Remove args parameter.
10412         * record.h (record_detach): Likewise.
10413         * remote-sim.c (gdbsim_detach): Likewise.
10414         * remote.c (remote_detach_1): Likewise.
10415         (remote_detach): Likewise.
10416         (extended_remote_detach): Likewise.
10417         * sol-thread.c (sol_thread_detach): Likewise.
10418         * target-delegates.c: Re-generate.
10419         * top.c (struct qt_args) <args>: Remove field.
10420         (kill_or_detach): Don't pass args.
10421         (quit_force): Don't set args.
10422         * windows-nat.c (windows_detach): Remove args parameter.
10423
10424 2018-01-19  Yao Qi  <yao.qi@linaro.org>
10425
10426         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
10427         (arm_linux_init_abi): Install it.
10428
10429 2018-01-19  Yao Qi  <yao.qi@linaro.org>
10430
10431         * osabi.c (gdb_osabi_names): Extend the regexp for
10432         arm-linux-gnueabihf.
10433
10434 2018-01-18  Yao Qi  <yao.qi@linaro.org>
10435
10436         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
10437         m_abbrevs.
10438         (abbrev_table::add_abbrev): Update.
10439         (abbrev_table::lookup_abbrev): Update.
10440
10441 2018-01-18  Yao Qi  <yao.qi@linaro.org>
10442
10443         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
10444
10445 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
10446
10447         * compile/compile.c (compile_to_object): Convert "triplet_rx"
10448         to "std::string".
10449
10450 2018-01-17  Tom Tromey  <tom@tromey.com>
10451
10452         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
10453
10454 2018-01-17  Tom Tromey  <tom@tromey.com>
10455
10456         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
10457         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
10458         (create_array_type_with_stride): Update.
10459         * dwarf2read.c (set_die_type): Update.
10460
10461 2018-01-17  Tom Tromey  <tom@tromey.com>
10462
10463         * dwarf2read.c (delayed_method_info): Remove typedef.
10464         (dwarf2_cu::method_info): Now a std::vector.
10465         (add_to_method_list): Update.
10466         (free_delayed_list): Remove.
10467         (compute_delayed_physnames): Update.
10468         (process_full_comp_unit, process_full_type_unit): Clear the method
10469         list.  Remove cleanups.
10470         (psymtab_include_file_name): Add name_holder parameter.  Use
10471         unique_xmalloc_ptr.
10472         (dwarf_decode_lines): Update.
10473
10474 2018-01-17  Tom Tromey  <tom@tromey.com>
10475             Simon Marchi  <simon.marchi@ericsson.com>
10476
10477         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
10478         (dwarf2_per_objfile::free_cached_comp_units)
10479         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
10480         (init_cutu_and_read_dies_no_follow): Update.
10481         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
10482         (dwarf2_cu::~dwarf2_cu): New.
10483         (free_heap_comp_unit, free_stack_comp_unit): Remove.
10484         (age_cached_comp_units, free_one_cached_comp_unit): Update.
10485
10486 2018-01-17  Tom Tromey  <tom@tromey.com>
10487             Simon Marchi  <simon.marchi@ericsson.com>
10488
10489         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
10490         (struct die_reader_specs) <abbrev_table>: New member.
10491         (struct abbrev_table): Add constructor.
10492         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
10493         <abbrev_obstack>: Now an auto_obstack.
10494         (abbrev_table_up): New typedef.
10495         (init_cu_die_reader): Add abbrev_table parameter.
10496         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
10497         Add result_dwo_abbrev_table.
10498         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
10499         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
10500         Update.
10501         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
10502         parameter.
10503         (skip_children): Update.
10504         (abbrev_table::alloc_abbrev): Rename from
10505         abbrev_table_alloc_abbrev.
10506         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
10507         (abbrev_table::lookup_abbrev): Rename from
10508         abbrev_table_lookup_abbrev.
10509         (abbrev_table_read_table): Return abbrev_table_up.
10510         (abbrev_table_free, abbrev_table_free_cleanup)
10511         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
10512         (load_partial_dies): Update.
10513
10514 2018-01-17  Tom Tromey  <tom@tromey.com>
10515
10516         * dwarf2read.c (dwarf2_compute_name): Update comment.
10517         (read_func_scope, read_variable): Update.
10518         (new_symbol): Remove.
10519         (new_symbol_full): Rename to new_symbol.
10520
10521 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
10522
10523         PR gdb/16577
10524         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
10525         a warning instead of throwing an error, set section size to 0 and return
10526         NULL.
10527         * gdb_bfd.h (gdb_bfd_map_section): Update description.
10528
10529 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
10530
10531         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
10532         std::string.
10533         (linux_ptrace_attach_fail_reason_string): Likewise.
10534         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
10535         Likewise.
10536         (linux_ptrace_attach_fail_reason_string): Likewise.
10537         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
10538
10539 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
10540
10541         * linux-nat.c (linux_nat_attach): Remove xstrdup.
10542
10543 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
10544
10545         PR gdb/21559
10546         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
10547         checking for fs_base/gs_base fields in struct user_regs_struct.
10548         * configure: Regenerate.
10549
10550 2018-01-17  Yao Qi  <yao.qi@linaro.org>
10551
10552         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
10553         function.
10554         (aarch64_linux_init_abi): Install it to gdbarch hook
10555         gcc_target_options.
10556
10557 2018-01-15  Pedro Alves  <palves@redhat.com>
10558
10559         * common/signals-state-save-restore.c
10560         (save_original_signals_state): Fix typos.
10561
10562 2017-01-12  Tom Tromey  <tom@tromey.com>
10563             Sergio Durigan Junior  <sergiodj@redhat.com>
10564
10565         * Makefile.in (install-only): Install gdb-add-index.
10566
10567 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
10568
10569         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
10570
10571 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
10572
10573         * infrun.c (keep_going_pass_signal): Clear step-over info when
10574         insert_breakpoints fails.
10575
10576 2018-01-11  Pedro Alves  <palves@redhat.com>
10577
10578         PR gdb/22583
10579         * infrun.c (resume): Rename to ...
10580         (resume_1): ... this.
10581         (resume): Reimplement as wrapper around resume_1.
10582
10583 2018-01-11  Pedro Alves  <palves@redhat.com>
10584
10585         PR remote/22597
10586         * remote.c (remote_parse_stop_reply): Default to the last-set
10587         general thread instead of to 'magic_null_ptid'.
10588
10589 2018-01-10  Pedro Alves  <palves@redhat.com>
10590
10591         * language.h (language_get_symbol_name_matcher): Rename ...
10592         (get_symbol_name_matcher): ... this.
10593         * language.c (language_get_symbol_name_matcher): Ditto.
10594         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
10595         callers adjusted.
10596
10597 2018-01-10  Pedro Alves  <palves@redhat.com>
10598
10599         PR gdb/22670
10600         * dwarf2read.c
10601         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
10602         Adjust to use language_get_symbol_name_matcher instead of
10603         language_defn::la_get_symbol_name_matcher.
10604         * language.c (language_get_symbol_name_matcher): If in Ada mode
10605         and the lookup name is a verbatim match, return Ada's matcher.
10606         * language.h (language_get_symbol_name_matcher): Adjust comment.
10607         (ada_lookup_name_info::verbatim_p):: New method.
10608
10609 2018-01-10  Pedro Alves  <palves@redhat.com>
10610
10611         PR gdb/22670
10612         * ada-lang.c (ada_collect_symbol_completion_matches): If the
10613         minsym's language is language_auto or language_cplus, pass down
10614         language_ada instead.
10615         * symtab.c (compare_symbol_name): Don't frob symbol language here.
10616
10617 2018-01-10  Pedro Alves  <palves@redhat.com>
10618
10619         PR gdb/22670
10620         * minsyms.c (linkage_name_str): New function.
10621         (iterate_over_minimal_symbols): Use it.
10622
10623 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10624
10625         * NEWS: Document that 'info proc' now works on FreeBSD.
10626
10627 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10628
10629         * configure.ac: Check for kinfo_getfile in libutil.
10630         * configure: Regenerate.
10631         * config.in: Regenerate.
10632         * fbsd-nat.c: Include "fbsd-tdep.h".
10633         (fbsd_fetch_cmdline): New.
10634         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
10635         rather than calling error.
10636         (fbsd_info_proc): New.
10637         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
10638         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
10639         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
10640
10641 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10642
10643         * fbsd-nat.c (struct free_deleter): Remove.
10644         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
10645
10646 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10647
10648         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
10649         NULL for an empty pathname.
10650
10651 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
10652
10653         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
10654         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
10655         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
10656         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
10657         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
10658         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
10659         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
10660         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
10661         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
10662         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
10663         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
10664         (fbsd_core_fetch_timeval, fbsd_print_sigset)
10665         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
10666         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
10667         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
10668
10669 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
10670
10671         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
10672         (gnu_xfer_auxv): New function.
10673         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
10674         TARGET_OBJECT_AUXV.
10675
10676 2018-01-08  Yao Qi  <yao.qi@linaro.org>
10677             Simon Marchi  <simon.marchi@ericsson.com>
10678
10679         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
10680         common/selftest.c.
10681         (COMMON_OBS): Remove selftest.o.
10682         * configure.ac: Append selftest-arch.c and common/selftest.c to
10683         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
10684         * configure: Re-generated.
10685         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
10686         GDB_SELF_TEST.
10687         (maintenance_info_selftests): Likewise.
10688
10689 2018-01-08  Xavier Roirand  <roirand@adacore.com>
10690
10691         * ada-valprint.c (val_print_packed_array_elements): Use
10692         proper number of elements when printing an array indexed
10693         by an enumeration type.
10694
10695 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
10696
10697         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
10698         (dw2_get_file_names_reader): Adjust.
10699         (lookup_dwo_signatured_type): Adjust.
10700         (lookup_dwp_signatured_type): Adjust.
10701         (lookup_signatured_type): Adjust.
10702         (create_type_unit_group): Adjust.
10703         (get_type_unit_group): Adjust.
10704         (process_psymtab_comp_unit_reader): Adjust.
10705         (build_type_psymtabs_reader): Adjust.
10706         (scan_partial_symbols): Adjust.
10707         (add_partial_symbol): Adjust.
10708         (add_partial_subprogram): Adjust.
10709         (peek_die_abbrev): Adjust.
10710         (fixup_go_packaging): Adjust.
10711         (process_imported_unit_die): Adjust.
10712         (dwarf2_compute_name): Adjust.
10713         (dwarf2_physname): Adjust.
10714         (read_import_statement): Adjust.
10715         (handle_DW_AT_stmt_list): Adjust.
10716         (read_file_scope): Adjust.
10717         (read_func_scope): Adjust.
10718         (read_lexical_block_scope): Adjust.
10719         (read_call_site_scope): Adjust.
10720         (read_variable): Adjust.
10721         (dwarf2_rnglists_process): Adjust.
10722         (dwarf2_ranges_process): Adjust.
10723         (dwarf2_ranges_read): Adjust.
10724         (dwarf2_get_pc_bounds): Adjust.
10725         (dwarf2_record_block_ranges): Adjust.
10726         (dwarf2_add_field): Adjust.
10727         (dwarf2_add_member_fn): Adjust.
10728         (read_structure_type): Adjust.
10729         (process_structure_scope): Adjust.
10730         (read_enumeration_type): Adjust.
10731         (read_array_type): Adjust.
10732         (mark_common_block_symbol_computed): Adjust.
10733         (read_common_block): Adjust.
10734         (read_namespace_type): Adjust.
10735         (read_namespace): Adjust.
10736         (read_module_type): Adjust.
10737         (read_tag_pointer_type): Adjust.
10738         (read_tag_ptr_to_member_type): Adjust.
10739         (read_tag_string_type): Adjust.
10740         (read_subroutine_type): Adjust.
10741         (read_typedef): Adjust.
10742         (read_base_type): Adjust.
10743         (attr_to_dynamic_prop): Adjust.
10744         (read_subrange_type): Adjust.
10745         (read_unspecified_type): Adjust.
10746         (dwarf2_read_abbrevs): Adjust.
10747         (load_partial_dies): Adjust.
10748         (read_partial_die): Adjust.
10749         (find_partial_die): Adjust.
10750         (guess_partial_die_structure_name): Adjust.
10751         (fixup_partial_die): Adjust.
10752         (read_attribute_value): Adjust.
10753         (read_addr_index): Adjust.
10754         (read_addr_index_from_leb128): Adjust.
10755         (read_str_index): Adjust.
10756         (dwarf2_string_attr): Adjust.
10757         (get_debug_line_section): Adjust.
10758         (dwarf_decode_line_header): Adjust.
10759         (lnp_state_machine::check_line_address): Adjust.
10760         (dwarf_decode_lines_1): Adjust.
10761         (dwarf_decode_lines): Adjust.
10762         (dwarf2_start_symtab): Adjust.
10763         (var_decode_location): Adjust.
10764         (new_symbol_full): Adjust.
10765         (dwarf2_const_value_data): Adjust.
10766         (dwarf2_const_value_attr): Adjust.
10767         (dwarf2_const_value): Adjust.
10768         (die_type): Adjust.
10769         (die_containing_type): Adjust.
10770         (build_error_marker_type): Adjust.
10771         (lookup_die_type): Adjust.
10772         (guess_full_die_structure_name): Adjust.
10773         (anonymous_struct_prefix): Adjust.
10774         (determine_prefix): Adjust.
10775         (dwarf2_name): Adjust.
10776         (follow_die_ref_or_sig): Adjust.
10777         (follow_die_offset): Adjust.
10778         (follow_die_ref): Adjust.
10779         (follow_die_sig_1): Adjust.
10780         (follow_die_sig): Adjust.
10781         (get_signatured_type): Adjust.
10782         (get_DW_AT_signature_type): Adjust.
10783         (decode_locdesc): Adjust.
10784         (dwarf_decode_macros): Adjust.
10785         (cu_debug_loc_section): Adjust.
10786         (fill_in_loclist_baton): Adjust.
10787         (dwarf2_symbol_mark_computed): Adjust.
10788         (init_one_comp_unit): Don't assign
10789         dwarf2_cu::dwarf2_per_objfile.
10790         (set_die_type): Adjust.
10791
10792 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
10793
10794         * dwarf2read.c (struct mapped_debug_names): Add constructor.
10795         <dwarf2_per_objfile>: New field.
10796         (dwarf2_per_objfile): Remove global.
10797         (get_dwarf2_per_objfile): New function.
10798         (set_dwarf2_per_objfile): New function.
10799         (dwarf2_build_psymtabs_hard): Change objfile parameter to
10800         dwarf2_per_objfile.
10801         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
10802         (read_abbrev_offset): Likewise.
10803         (read_indirect_string): Likewise.
10804         (read_indirect_line_string): Likewise.
10805         (read_indirect_string_at_offset): Likewise.
10806         (read_indirect_string_from_dwz): Likewise.
10807         (dwarf2_find_containing_comp_unit): Change objfile parameter to
10808         dwarf2_per_objfile.
10809         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
10810         (create_all_comp_units): Change objfile parameter to
10811         dwarf2_per_objfile.
10812         (create_all_type_units): Likewise.
10813         (process_queue): Add dwarf2_per_objfile parameter.
10814         (read_and_check_comp_unit_head): Likewise.
10815         (lookup_dwo_unit_in_dwp): Likewise.
10816         (get_dwp_file): Likewise.
10817         (process_cu_includes): Likewise.
10818         (struct free_dwo_file_cleanup_data): New struct.
10819         (dwarf2_has_info): Use get_dwarf2_per_objfile and
10820         set_dwarf2_per_objfile.
10821         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
10822         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
10823         context, adjust calls.
10824         (dw2_instantiate_symtab): Likewise.
10825         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
10826         (dw2_get_cu): Likewise.
10827         (create_cu_from_index_list): Change objfile parameter to
10828         dwarf2_per_objfile.
10829         (create_cus_from_index_list): Get dwarf2_per_objfile from
10830         context, adjust calls.
10831         (create_cus_from_index): Likewise.
10832         (create_signatured_type_table_from_index): Change objfile
10833         parameter to dwarf2_per_objfile.
10834         (create_signatured_type_table_from_debug_names): Change objfile
10835         parameter to dwarf2_per_objfile.
10836         (create_addrmap_from_index): Likewise.
10837         (create_addrmap_from_aranges): Likewise.
10838         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
10839         (dw2_setup): Remove.
10840         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
10841         context.
10842         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
10843         get_dwarf2_per_objfile.
10844         (dw2_forget_cached_source_info): Likewise.
10845         (dw2_map_symtabs_matching_filename): Likewise.
10846         (struct dw2_symtab_iterator) <index>: Remove.
10847         <dwarf2_per_objfile>: New field.
10848         (dw2_symtab_iter_init): Replace index parameter with
10849         dwarf2_per_objfile.
10850         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
10851         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
10852         (dw2_print_stats): Likewise.
10853         (dw2_dump): Likewise.
10854         (dw2_expand_symtabs_for_function): Likewise.
10855         (dw2_expand_all_symtabs): Likewise.
10856         (dw2_expand_symtabs_with_fullname): Likewise.
10857         (dw2_expand_marked_cus): Replace index and objfile parameters
10858         with dwarf2_per_objfile.
10859         (dw_expand_symtabs_matching_file_matcher): Add
10860         dwarf2_per_objfile parameter and adjust calls.
10861         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
10862         adjust calls.
10863         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
10864         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
10865         adjust calls.
10866         (create_cus_from_debug_names_list): Replace objfile parameter
10867         with dwarf2_per_objfile and adjust calls.
10868         (create_cus_from_debug_names): Likewise.
10869         (dwarf2_read_debug_names): Likewise.
10870         (mapped_debug_names::namei_to_name): Adjust call.
10871         (dw2_debug_names_iterator::next): Likewise.
10872         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
10873         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
10874         (dw2_debug_names_dump): Likewise.
10875         (dw2_debug_names_expand_symtabs_for_function): Likewise.
10876         (dw2_debug_names_expand_symtabs_matching): Likewise.
10877         (dwarf2_initialize_objfile): Likewise.
10878         (dwarf2_build_psymtabs): Likewise.
10879         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
10880         this_cu.
10881         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
10882         (read_and_check_comp_unit_head): Likewise.
10883         (read_abbrev_offset): Likewise.
10884         (create_debug_type_hash_table): Likewise.
10885         (create_debug_types_hash_table): Likewise.
10886         (create_all_type_units): Replace objfile parameter with
10887         dwarf2_per_objfile.
10888         (add_type_unit): Add dwarf2_per_objfile parameter.
10889         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
10890         with dwarf2_per_objfile.
10891         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
10892         (lookup_dwp_signatured_type): Likewise.
10893         (lookup_signatured_type): Likewise.
10894         (read_cutu_die_from_dwo): Likewise.
10895         (init_tu_and_read_dwo_dies): Likewise.
10896         (init_cutu_and_read_dies): Likewise.
10897         (init_cutu_and_read_dies_no_follow): Likewise.
10898         (allocate_type_unit_groups_table): Add objfile parameter.
10899         (create_type_unit_group): Use dwarf2_per_objfile from cu.
10900         (get_type_unit_group): Likewise.
10901         (process_psymtab_comp_unit): Update call.
10902         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
10903         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
10904         (print_tu_stats): Likewise.
10905         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
10906         in void* parameter.
10907         (build_type_psymtabs): Change objfile parameter to
10908         dwarf2_per_objfile.
10909         (process_skeletonless_type_unit): Use dwarf2_per_objfile
10910         passed in void* parameter.
10911         (process_skeletonless_type_units): Change objfile parameter to
10912         dwarf2_per_objfile.
10913         (set_partial_user): Likewise.
10914         (dwarf2_build_psymtabs_hard): Likewise.
10915         (read_comp_units_from_section): Likewise.
10916         (create_all_comp_units): Likewise.
10917         (scan_partial_symbols): Update calls.
10918         (add_partial_symbol): Likewise.
10919         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
10920         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
10921         (process_queue): Add dwarf2_per_objfile parameter.
10922         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
10923         (compute_compunit_symtab_includes): Likewise.
10924         (process_cu_includes): Add dwarf2_per_objfile parameter.
10925         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
10926         (process_full_type_unit): Likewise.
10927         (process_imported_unit_die): Update call.
10928         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
10929         (read_file_scope): Likewise.
10930         (allocate_dwo_file_hash_table): Add objfile parameter.
10931         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
10932         (create_cus_hash_table): Likewise.
10933         (create_dwp_hash_table): Likewise.
10934         (create_dwo_unit_in_dwp_v1): Likewise.
10935         (create_dwp_v2_section): Likewise.
10936         (create_dwo_unit_in_dwp_v2): Likewise.
10937         (lookup_dwo_unit_in_dwp): Likewise.
10938         (try_open_dwop_file): Likewise.
10939         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
10940         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
10941         cleanup to include a reference to dwarf2_per_objfile.
10942         (open_dwp_file): Add dwarf2_per_objfile parameter.
10943         (open_and_init_dwp_file): Likewise.
10944         (get_dwp_file): Likewise.
10945         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
10946         (queue_and_load_all_dwo_tus): Update call.
10947         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
10948         data.
10949         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
10950         (dwarf2_ranges_process): Likewise.
10951         (dwarf2_get_pc_bounds): Likewise.
10952         (mark_common_block_symbol_computed): Likewise.
10953         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
10954         (dwarf2_read_abbrevs): Update call.
10955         (read_partial_die): Use dwarf2_per_objfile from cu.
10956         (find_partial_die): Likewise.
10957         (fixup_partial_die): Likewise.
10958         (read_attribute_value): Likewise.
10959         (read_indirect_string_at_offset_from): Add objfile parameter.
10960         (read_indirect_string_at_offset): Add dwarf2_per_objfile
10961         parameter.
10962         (read_indirect_string_from_dwz): Add objfile parameter.
10963         (read_indirect_string): Add objfile parameter.
10964         (read_addr_index_1): Add dwarf2_per_objfile parameter.
10965         (read_addr_index): Use dwarf2_per_objfile from cu.
10966         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
10967         call dw2_setup.
10968         (read_str_index): Use dwarf2_per_objfile from cu.
10969         (get_debug_line_section): Likewise.
10970         (read_formatted_entries): Add dwarf2_per_objfile parameter.
10971         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
10972         (new_symbol_full): Use dwarf2_per_objfile from cu.
10973         (build_error_marker_type): Likewise.
10974         (lookup_die_type): Likewise.
10975         (determine_prefix): Likewise.
10976         (follow_die_offset): Likewise.
10977         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
10978         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
10979         (dwarf2_fetch_die_type_sect_off): Likewise.
10980         (dwarf2_get_die_type): Likewise.
10981         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
10982         (get_signatured_type): Likewise.
10983         (get_DW_AT_signature_type): Likewise.
10984         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
10985         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
10986         (cu_debug_loc_section): Likewise.
10987         (fill_in_loclist_baton): Likewise.
10988         (dwarf2_symbol_mark_computed): Likewise.
10989         (dwarf2_find_containing_comp_unit): Change objfile parameter to
10990         dwarf2_per_objfile.
10991         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
10992         parameter.
10993         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
10994         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
10995         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
10996         (set_die_type): Use dwarf2_free_objfile from cu.
10997         (get_die_type_at_offset): Likewise.
10998         (dwarf2_per_objfile_free): Don't assign global variable.
10999         (debug_names) <constructor>: Add dwarf2_per_objfile
11000         parameter, update m_debugstrlookup construction.
11001         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
11002         parameter.
11003         <m_dwarf2_per_objfile>: New field.
11004         <lookup>: Use m_dwarf2_per_objfile.
11005         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
11006         (psyms_seen_size): Likewise.
11007         (write_gdbindex): Replace objfile parameter with
11008         dwarf2_per_objfile.
11009         (write_debug_names): Likewise.
11010         (write_psymtabs_to_index): Likewise.
11011         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
11012         calls.
11013
11014 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
11015
11016         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
11017         <dwarf2_per_objfile>: New field.
11018         (struct dwarf2_per_cu_data) <objfile>: Remove.
11019         <dwarf2_per_objfile>: New field.
11020         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
11021         of objfile.
11022         (create_signatured_type_table_from_index): Likewise.
11023         (create_debug_type_hash_table): Likewise.
11024         (fill_in_sig_entry_from_dwo_entry): Likewise.
11025         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
11026         (create_type_unit_group): Assign dwarf2_per_objfile instead of
11027         objfile.
11028         (create_partial_symtab): Access objfile through
11029         dwarf2_per_objfile.
11030         (process_psymtab_comp_unit_reader): Likewise.
11031         (read_comp_units_from_section): Likewise.
11032         (scan_partial_symbols): Likewise.
11033         (add_partial_symbol): Likewise.
11034         (add_partial_subprogram): Likewise.
11035         (peek_die_abbrev): Likewise.
11036         (fixup_go_packaging): Likewise.
11037         (process_full_comp_unit): Likewise.
11038         (process_full_type_unit): Likewise.
11039         (process_imported_unit_die): Likewise.
11040         (dwarf2_compute_name): Likewise.
11041         (dwarf2_physname): Likewise.
11042         (read_import_statement): Likewise.
11043         (create_cus_hash_table): Assign dwarf2_physname instead of
11044         objfile.
11045         (read_func_scope): Access objfile through dwarf2_per_objfile.
11046         (read_lexical_block_scope): Likewise.
11047         (read_call_site_scope): Likewise.
11048         (read_variable): Likewise.
11049         (dwarf2_rnglists_process): Likewise.
11050         (dwarf2_ranges_process): Likewise.
11051         (dwarf2_ranges_read): Likewise.
11052         (dwarf2_record_block_ranges): Likewise.
11053         (dwarf2_add_field): Likewise.
11054         (dwarf2_add_member_fn): Likewise.
11055         (read_structure_type): Likewise.
11056         (process_structure_scope): Likewise.
11057         (read_enumeration_type): Likewise.
11058         (read_array_type): Likewise.
11059         (read_common_block): Likewise.
11060         (read_namespace_type): Likewise.
11061         (read_namespace): Likewise.
11062         (read_module_type): Likewise.
11063         (read_tag_pointer_type): Likewise.
11064         (read_tag_ptr_to_member_type): Likewise.
11065         (read_tag_string_type): Likewise.
11066         (read_subroutine_type): Likewise.
11067         (read_typedef): Likewise.
11068         (read_base_type): Likewise.
11069         (attr_to_dynamic_prop): Likewise.
11070         (read_subrange_type): Likewise.
11071         (read_unspecified_type): Likewise.
11072         (load_partial_dies): Likewise.
11073         (read_partial_die): Likewise.
11074         (find_partial_die): Likewise.
11075         (guess_partial_die_structure_name): Likewise.
11076         (fixup_partial_die): Likewise.
11077         (read_attribute_value): Likewise.
11078         (read_addr_index_from_leb128): Likewise.
11079         (dwarf2_read_addr_index): Likewise.
11080         (dwarf2_string_attr): Likewise.
11081         (lnp_state_machine::check_line_address): Likewise.
11082         (dwarf_decode_lines_1): Likewise.
11083         (dwarf_decode_lines): Likewise.
11084         (dwarf2_start_symtab): Likewise.
11085         (var_decode_location): Likewise.
11086         (new_symbol_full): Likewise.
11087         (dwarf2_const_value_data): Likewise.
11088         (dwarf2_const_value_attr): Likewise.
11089         (dwarf2_const_value): Likewise.
11090         (die_type): Likewise.
11091         (die_containing_type): Likewise.
11092         (lookup_die_type): Likewise.
11093         (guess_full_die_structure_name): Likewise.
11094         (anonymous_struct_prefix): Likewise.
11095         (dwarf2_name): Likewise.
11096         (follow_die_ref_or_sig): Likewise.
11097         (follow_die_offset): Likewise.
11098         (follow_die_ref): Likewise.
11099         (dwarf2_fetch_die_loc_sect_off): Likewise.
11100         (dwarf2_fetch_constant_bytes): Likewise.
11101         (dwarf2_fetch_die_type_sect_off): Likewise.
11102         (dwarf2_get_die_type): Likewise.
11103         (follow_die_sig): Likewise.
11104         (decode_locdesc): Likewise.
11105         (dwarf2_per_cu_objfile): Likewise.
11106         (dwarf2_per_cu_text_offset): Likewise.
11107         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
11108         objfile.
11109         (set_die_type): Access objfile through
11110         dwarf2_per_objfile.
11111
11112 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
11113
11114         * valprint.c (converted_character_d): Remove typedef.
11115         (DEF_VEC_O (converted_character_d)): Remove.
11116         (count_next_character): Use std::vector.
11117         (print_converted_chars_to_obstack): Likewise.
11118         (generic_printstr): Likewise.
11119
11120 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
11121
11122         * xml-support.h (struct gdb_xml_value): Add constructor.
11123         <value>: Change type to unique_xmalloc_ptr.
11124         (gdb_xml_value_s): Remove typedef.
11125         (DEF_VEC_O (gdb_xml_value_s)): Remove.
11126         (gdb_xml_element_start_handler): Change parameter type to
11127         std::vector.
11128         (xml_find_attribute): Likewise.
11129         * xml-support.c (xml_find_attribute): Change parameter type to
11130         std::vector and adjust.
11131         (gdb_xml_values_cleanup): Remove.
11132         (gdb_xml_parser::start_element): Adjust to std::vector.
11133         (xinclude_start_include): Change paraeter type to std::vector
11134         and adjust.
11135         * btrace.c (check_xml_btrace_version): Likewise.
11136         (parse_xml_btrace_block): Likewise.
11137         (parse_xml_btrace_pt_config_cpu): Likewise.
11138         (parse_xml_btrace_pt): Likewise.
11139         (parse_xml_btrace_conf_bts): Likewise.
11140         (parse_xml_btrace_conf_pt): Likewise.
11141         * memory-map.c (memory_map_start_memory): Likewise.
11142         (memory_map_start_property): Likewise.
11143         * osdata.c (osdata_start_osdata): Likewise.
11144         (osdata_start_item): Likewise.
11145         (osdata_start_column): Likewise.
11146         * remote.c (start_thread): Likewise.
11147         * solib-aix.c (library_list_start_library): Likewise.
11148         (library_list_start_list): Likewise.
11149         * solib-svr4.c (library_list_start_library): Likewise.
11150         (svr4_library_list_start_list): Likewise.
11151         * solib-target.c (library_list_start_segment): Likewise.
11152         (library_list_start_section): Likewise.
11153         (library_list_start_library): Likewise.
11154         (library_list_start_list): Likewise.
11155         * tracepoint.c (traceframe_info_start_memory): Likewise.
11156         (traceframe_info_start_tvar): Likewise.
11157         * xml-syscall.c (syscall_start_syscall): Likewise.
11158         * xml-tdesc.c (tdesc_start_target): Likewise.
11159         (tdesc_start_feature): Likewise.
11160         (tdesc_start_reg): Likewise.
11161         (tdesc_start_union): Likewise.
11162         (tdesc_start_struct): Likewise.
11163         (tdesc_start_flags): Likewise.
11164         (tdesc_start_enum): Likewise.
11165         (tdesc_start_field): Likewise.
11166         (tdesc_start_enum_value): Likewise.
11167         (tdesc_start_vector): Likewise.
11168
11169 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
11170
11171         * extension.h (struct xmethod_worker) <clone>: Remove.
11172         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
11173         Remove.
11174         (python_xmethod_worker::clone): Remove.
11175         * valops.c (find_overload_match): Use std::move instead of
11176         clone.
11177
11178 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
11179
11180         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
11181         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
11182         <free_xmethod_worker_data>: Remove.
11183         <get_matching_xmethod_workers>: Chance VEC to std::vector.
11184         <get_xmethod_arg_types>: Remove.
11185         <get_xmethod_result_type>: Remove.
11186         <invoke_xmethod>: Remove.
11187         * extension.c (new_xmethod_worker): Remove.
11188         (clone_xmethod_worker): Remove.
11189         (get_matching_xmethod_workers): Return void, pass std::vector by
11190         pointer.
11191         (get_xmethod_arg_types): Rename to...
11192         (xmethod_worker::get_arg_types): ... this, and adjust.
11193         (get_xmethod_result_type): Rename to...
11194         (xmethod_worker::get_result_type): ... this, and adjust.
11195         (invoke_xmethod): Remove.
11196         (free_xmethod_worker): Remove.
11197         (free_xmethod_worker_vec): Remove.
11198         * extension.h (enum ext_lang_rc): Move here from
11199         extension-priv.h.
11200         (struct xmethod_worker): Add constructor and destructor.
11201         <data>: Remove.
11202         <value>: Remove.
11203         <invoke, clone, do_get_result_type, do_get_arg_types>: New
11204         virtual pure methods.
11205         <get_arg_types, get_result_type>: New methods.
11206         (xmethod_worker_ptr): Remove typedef.
11207         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
11208         (xmethod_worker_vec): Remove typedef.
11209         (xmethod_worker_up): New typedef.
11210         (invoke_xmethod): Remove.
11211         (clone_xmethod_worker): Remove.
11212         (free_xmethod_worker): Remove.
11213         (free_xmethod_worker_vec): Remove.
11214         (get_xmethod_arg_types): Remove.
11215         (get_xmethod_result_type): Remove.
11216         * valops.c (find_method_list): Use std::vector, don't use
11217         intermediate vector.
11218         (value_find_oload_method_list): Use std::vector.
11219         (find_overload_match): Use std::vector.
11220         (find_oload_champ): Use std::vector.
11221         * value.c (value_free): Use operator delete.
11222         (value_of_xmethod): Rename to...
11223         (value_from_xmethod): ... this.  Don't assign
11224         xmethod_worker::value, take rvalue-reference.
11225         (result_type_of_xmethod): Adjust.
11226         (call_xmethod): Adjust.
11227         * value.h: Include extension.h.
11228         (struct xmethod_worker): Don't forward-declare.
11229         (value_of_xmethod): Rename to...
11230         (value_from_xmethod): ... this, take rvalue-reference.
11231         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
11232         (struct python_xmethod_worker): ... this, add constructor and
11233         destructor.
11234         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
11235         (gdbpy_free_xmethod_worker_data): Rename to...
11236         (python_xmethod_worker::~python_xmethod_worker): ... this and
11237         adjust.
11238         (gdbpy_clone_xmethod_worker_data): Rename to...
11239         (python_xmethod_worker::clone): ... this and adjust.
11240         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
11241         temporary vector.
11242         (gdbpy_get_xmethod_arg_types): Rename to...
11243         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
11244         (gdbpy_get_xmethod_result_type): Rename to...
11245         (python_xmethod_worker::do_get_result_type): ... this and
11246         adjust.
11247         (gdbpy_invoke_xmethod): Rename to...
11248         (python_xmethod_worker::invoke): ... this and adjust.
11249         (new_python_xmethod_worker): Rename to...
11250         (python_xmethod_worker::python_xmethod_worker): ... this and
11251         adjust.
11252         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
11253         Remove.
11254         (gdbpy_free_xmethod_worker_data): Remove.
11255         (gdbpy_get_matching_xmethod_workers): Use std::vector.
11256         (gdbpy_get_xmethod_arg_types): Remove.
11257         (gdbpy_get_xmethod_result_type): Remove.
11258         (gdbpy_invoke_xmethod): Remove.
11259         * python/python.c (python_extension_ops): Remove obsolete
11260         callbacks.
11261
11262 2018-01-05  Pedro Alves  <palves@redhat.com>
11263
11264         PR gdb/18653
11265         * common/signals-state-save-restore.c
11266         (save_original_signals_state): New parameter 'quiet'.  Warn if we
11267         find a custom handler preinstalled, instead of internal erroring.
11268         But only warn if !quiet.
11269         * common/signals-state-save-restore.h
11270         (save_original_signals_state): New parameter 'quiet'.
11271         * main.c (captured_main_1): Move save_original_signals_state call
11272         after option handling, and pass QUIET.
11273
11274 2018-01-05  Pedro Alves  <palves@redhat.com>
11275
11276         * spu-tdep.c (spu_catch_start): Pass
11277         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
11278
11279 2018-01-05  Pedro Alves  <palves@redhat.com>
11280
11281         PR gdb/22670
11282         * ada-lang.c (literal_symbol_name_matcher): New function.
11283         (ada_get_symbol_name_matcher): Use it for
11284         symbol_name_match_type::SEARCH_NAME.
11285         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
11286         it down instead of assuming symbol_name_match_type::FULL.
11287         * block.h (block_lookup_symbol): New parameter 'match_type'.
11288         * c-valprint.c (print_unpacked_pointer): Use
11289         lookup_symbol_search_name instead of lookup_symbol.
11290         * compile/compile-object-load.c (get_out_value_type): Pass down
11291         symbol_name_match_type::SEARCH_NAME.
11292         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
11293         symbol_name_match_type::FULL.
11294         * cp-support.c (cp_get_symbol_name_matcher): Handle
11295         symbol_name_match_type::SEARCH_NAME.
11296         * infrun.c (insert_exception_resume_breakpoint): Use
11297         lookup_symbol_search_name.
11298         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
11299         * psymtab.c (maintenance_check_psymtabs): Use
11300         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
11301         * stack.c (print_frame_args): Use lookup_symbol_search_name and
11302         SYMBOL_SEARCH_NAME.
11303         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
11304         if symbol_name_match_type::SEARCH_NAME.
11305         (lookup_symbol_in_language): Pass down
11306         symbol_name_match_type::FULL.
11307         (lookup_symbol_search_name): New.
11308         (lookup_language_this): Pass down
11309         symbol_name_match_type::SEARCH_NAME.
11310         (lookup_symbol_aux, lookup_local_symbol): New parameter
11311         'match_type'.  Pass it down.
11312         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
11313         (lookup_symbol_search_name): New declaration.
11314         (lookup_symbol_in_block): New 'match_type' parameter.
11315
11316 2018-01-05  Pedro Alves  <palves@redhat.com>
11317
11318         PR gdb/22670
11319         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
11320         ada_lookup_symbol.
11321         (ada_lookup_symbol): Reimplement in terms of
11322         ada_lookup_symbol_list, bits factored out from
11323         ada_lookup_encoded_symbol.
11324
11325 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11326
11327         * ada-exp.y (write_object_renaming): When subscripting an array
11328         using a symbol as the index, pass the block in call to
11329         ada_lookup_encoded_symbol when looking that symbol up.
11330
11331 2018-01-05  Jerome Guitton  <guitton@adacore.com>
11332
11333         * ada-lang.c (ada_array_length): Use ada_index_type instead of
11334         TYPE_INDEX_TYPE.
11335
11336 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11337
11338         * ada-lang.c (ada_to_fixed_value_create): Add handling of
11339         the case where VALUE_LVAL (val0) is not lval_memory.
11340
11341 2018-01-05  Xavier Roirand  <roirand@adacore.com>
11342
11343         * ada-valprint.c (print_optional_low_bound): Handle
11344         character-indexed array printing like boolean-indexed array
11345         printing.
11346
11347 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11348
11349         * NEWS: Create a new section for the next release branch.
11350         Rename the section of the current branch, now that it has
11351         been cut.
11352
11353 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
11354
11355         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
11356         * version.in: Bump version to 8.1.50.DATE-git.
11357
11358 2018-01-03  Xavier Roirand  <roirand@adacore.com>
11359
11360         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
11361         Add field.
11362         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
11363         Add field.
11364         (default_exception_support_info) <catch_handlers_sym>: Add field.
11365         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
11366         (ada_exception_name_addr_1): Add "catch handlers" handling.
11367         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
11368         Update all callers.
11369         (create_excep_cond_exprs) <ex>: Add parameter.
11370         (re_set_exception): Update create_excep_cond_exprs call.
11371         (print_it_exception, print_one_exception, print_mention_exception)
11372         (print_recreate_exception): Add "catch handler" handling.
11373         (allocate_location_catch_handlers, re_set_catch_handlers)
11374         (check_status_catch_handlers, print_it_catch_handlers)
11375         (print_one_catch_handlers, print_mention_catch_handlers)
11376         (print_recreate_catch_handlers): New function.
11377         (catch_handlers_breakpoint_ops): New variable.
11378         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
11379         Add parameter.  Add "catch handler" handling.
11380         (ada_exception_sym_name, ada_exception_breakpoint_ops):
11381         Add "catch handler" handling.
11382         (ada_exception_catchpoint_cond_string): Add "catch handler"
11383         handling.
11384         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
11385         call.
11386         (catch_ada_handlers_command): New function.
11387         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
11388         operations structure.
11389         (_initialize_ada_language): Add "catch handlers" command entry.
11390         * NEWS: Document "catch handlers" feature.
11391
11392 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
11393
11394         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
11395         account when creating the array type of the slice.
11396         (ada_value_slice): Likewise.
11397
11398 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
11399
11400         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
11401         New enum value.
11402         (create_array_type_with_stride): Add byte_stride_prop parameter.
11403         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
11404         New parameter.  Update all callers in this file.
11405         (array_type_has_dynamic_stride): New function.
11406         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
11407         of arrays with dynamic byte strides.
11408         * dwarf2read.c (read_array_type): Add support for dynamic
11409         DW_AT_byte_stride attributes.
11410
11411 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
11412
11413         * dwarf2read.c (read_unspecified_type): Treat
11414         DW_TAG_enumeration_type DIEs from Ada units as stubs.
11415
11416 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11417
11418         Update copyright year range in all GDB files.
11419
11420 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11421
11422         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
11423         and gdb/testsuite/gdb.base/step-line.c.
11424
11425 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11426
11427         * copyright.py (main): Dump the contents of
11428         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
11429         even if BY_HAND is empty.
11430
11431 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11432
11433         * top.c (print_gdb_version): Update Copyright year in version
11434         message.
11435
11436 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
11437
11438         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
11439
11440 For older changes see ChangeLog-2017.
11441 \f
11442 Local Variables:
11443 mode: change-log
11444 left-margin: 8
11445 fill-column: 74
11446 version-control: never
11447 coding: utf-8
11448 End: