gdb/ChangeLog

   1 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
   4         Add case for debugging 32-bit target on 64-bit host.  Revise
   5         comment.
   6
   7 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
   8
   9         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
  10         instead of find_function_entry_range_from_pc.
  11
  12 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  13
  14         * stack.c (find_frame_funname): Remove code which preferred
  15         minsym over symtab sym in "certain pathological cases".
  16
  17         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
  18         parameter.  Change type of "do_demangle" to bool.
  19         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  20         Pass suitable "prefer_sym_over_minsym" flag to
  21         build_address_symbolic().  Don't output "+" for negative offsets.
  22         * printcmd.c (print_address_symbolic): Update invocation of
  23         build_address_symbolic to include a "prefer_sym_over_minsym"
  24         flag.
  25         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
  26         Restrict cases in which use of minimal symbol is preferred to that
  27         of a found symbol.  Update comments.
  28
  29         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
  30         for entry pc when entry pc is out of range for that FDE.
  31
  32         * printcmd.c (print_address_symbolic): Print negative offsets.
  33         (build_address_symbolic): Force signed arithmetic when computing
  34         offset.
  35
  36 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
  37
  38         PR gdb/24839:
  39         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
  40         type.
  41
  42 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
  43
  44         * python/py-objfile.c (add_separate_debug_file): Fix comment about
  45         this function's Python signature.
  46
  47
  48 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
  49
  50         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
  51         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  52         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  53         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
  54         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
  55
  56
  57 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
  58
  59         * h8300-tdep.c (h8300_register_name_common): New.
  60         h8300_register_name): Use h8300_register_name_common.
  61         (h8300s_register_name): Likewise.
  62         (h8300sx_register_name): Likewise.
  63         (h8300h_register_nam): New.
  64         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
  65
  66
  67 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
  68
  69         * arm-tdep.c (arm_skip_cmse_entry): New function.
  70         (arm_is_sgstubs_section): New function.
  71         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
  72
  73 2019-07-22  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
  76         Don't self-assign.
  77
  78 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  79
  80         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
  81         type_print.
  82
  83 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  84
  85         * symtab.c (search_symbols): Adjust msymbol matching type arrays
  86         so that GDB doesn't match any msymbols when searching in the
  87         TYPES_DOMAIN.
  88         (print_symbol_info): Print using typedef_print or type_print based
  89         on the type of the symbol.  Add updated FIXME comment moved from...
  90         (_initialize_symtab): ... move and update FIXME comment to above.
  91
  92 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  93
  94         * NEWS: Mention adding -q option to "info types".
  95         * symtab.c (struct info_types_options): New struct.
  96         (info_types_options_defs): New variable.
  97         (make_info_types_options_def_group): New function.
  98         (info_types_command): Use gdb::option framework to parse options.
  99         (info_types_command_completer): New function.
 100         (_initialize_symtab): Extend the help text on "info types" and
 101         register command completer.
 102
 103 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 104
 105         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 106         (lookup_symbol_in_objfile): Change int to block_enum and add a
 107         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 108
 109 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 110
 111         * MAINTAINERS (Write After Approval): Add self.
 112
 113 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 114
 115         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 116         instruction to the dummy code region.
 117
 118 2019-07-19  Tom Tromey  <tromey@adacore.com>
 119
 120         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 121         (ARGSUSED, PARAMS, __func__): Remove rules.
 122
 123 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 124
 125         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 126         * features/arm/arm-with-iwmmxt.c: Remove.
 127         * features/arm/arm-with-iwmmxt.xml: Remove.
 128         * features/arm/arm-with-m-fpa-layout.c: Remove.
 129         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 130         * features/arm/arm-with-m-vfp-d16.c: Remove.
 131         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 132         * features/arm/arm-with-m.c: Remove.
 133         * features/arm/arm-with-m.xml: Remove.
 134         * features/arm/arm-with-neon.c: Remove.
 135         * features/arm/arm-with-neon.xml: Remove.
 136         * features/arm/arm-with-vfpv2.c: Remove.
 137         * features/arm/arm-with-vfpv2.xml: Remove.
 138         * features/arm/arm-with-vfpv3.c: Remove.
 139         * features/arm/arm-with-vfpv3.xml: Remove.
 140
 141 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 142
 143         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 144
 145 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 146
 147         * arch/aarch32.c (aarch32_create_target_description): Create
 148         target descriptions using features.
 149         * arch/arm.c (arm_create_target_description)
 150         (arm_create_mprofile_target_description): Likewise.
 151         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 152
 153 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 154
 155         * Makefile.in: Add new files.
 156         * aarch32-tdep.c: New file.
 157         * aarch32-tdep.h: New file.
 158         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 159         Call aarch32_read_description.
 160         * arch/aarch32.c: New file.
 161         * arch/aarch32.h: New file.
 162         * arch/arm.c (arm_create_target_description)
 163         (arm_create_mprofile_target_description): New function.
 164         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 165         (arm_create_target_description)
 166         (arm_create_mprofile_target_description): New declaration.
 167         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 168         read_description functions.
 169         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 170         Likewise.
 171         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 172         * arm-tdep.c (tdesc_arm_list): New variable.
 173         (arm_register_g_packet_guesses): Call create description functions.
 174         (arm_read_description) (arm_read_mprofile_description): New
 175         function.
 176         * arm-tdep.h (arm_read_description)
 177         (arm_read_mprofile_description): Add declaration.
 178         * configure.tgt: Add new files.
 179
 180 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 181
 182         * top.c (new_ui_command): Open specified terminal just once.
 183
 184 2019-07-18  Tom Tromey  <tromey@adacore.com>
 185
 186         * symtab.c (main_name): Constify return type.
 187         * symfile.c (set_initial_language): Update.
 188         * symtab.h (main_name): Constify return type.
 189
 190 2019-07-17  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-winsource.c (tui_update_source_window)
 193         (tui_update_source_window_as_is)
 194         (tui_update_source_windows_with_line): Remove return.
 195         * tui/tui-disasm.c (tui_show_disassem)
 196         (tui_show_disassem_and_update_source): Remove return.
 197         * tui/tui.c (tui_reset): Remove return.
 198         * tui/tui-wingeneral.c
 199         (tui_check_and_display_highlight_if_needed): Remove return.
 200
 201 2019-07-17  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 204
 205 2019-07-17  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-winsource.h (struct tui_exec_info_window)
 208         (struct tui_source_window_base): Move from tui-data.h.
 209         * tui/tui-winsource.c: Move many method definitions from
 210         elsewhere.  Remove "structuring" comments.
 211         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 212         (tui_source_window_base::refresh_window): Move to
 213         tui-winsource.c.
 214         * tui/tui-win.c (tui_source_window_base::refresh_all)
 215         (tui_source_window_base::update_tab_width)
 216         (tui_source_window_base::set_new_height)
 217         (tui_source_window_base::do_make_visible_with_new_height): Move to
 218         tui-winsource.c.
 219         * tui/tui-source.h: Update.
 220         * tui/tui-source.c (tui_source_window_base::reset): Move to
 221         tui-winsource.c.
 222         * tui/tui-disasm.h: Update.
 223         * tui/tui-data.h (struct tui_exec_info_window): Move to
 224         tui-winsource.h.
 225         (struct tui_source_window_base): Likewise.
 226         * tui/tui-data.c (tui_source_window_base::clear_detail)
 227         (tui_source_window_base, ~tui_source_window_base): Move to
 228         tui-winsource.c.
 229
 230 2019-07-17  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-win.c (tui_resize_all)
 233         (tui_source_window_base::update_tab_width)
 234         (tui_adjust_win_heights): Update.
 235         (tui_win_info::make_invisible_and_set_new_height): Rename from
 236         make_invisible_and_set_new_height.
 237         * tui/tui-data.h (struct tui_win_info)
 238         <make_invisible_and_set_new_height>: New method.
 239
 240 2019-07-17  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui.c: Update.
 243         * tui/tui-source.h (struct tui_source_window): Move from
 244         tui-data.h.
 245         * tui/tui-layout.c: Update.
 246         * tui/tui-disasm.c: Update.
 247         * tui/tui-data.h (struct tui_source_window): Move to
 248         tui-source.h.
 249
 250 2019-07-17  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 253         tui-data.h.
 254         * tui/tui-data.h (struct tui_disasm_window): Move to
 255         tui-disasm.h.
 256
 257 2019-07-17  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-regs.h (struct tui_data_item_window): Move from
 260         tui-data.h.
 261         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 262         * tui/tui-data.h (struct tui_data_item_window): Move to
 263         tui-regs.h.
 264         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 265
 266 2019-07-17  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui.c: Update.
 269         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 270         (tui_cmd_window::max_height): Move to tui-command.c.
 271         * tui/tui-layout.c: Update.
 272         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 273         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 274         tui-command.c.
 275         * tui/tui-command.h (struct tui_cmd_window): Move from
 276         tui-data.h.
 277         * tui/tui-command.c: Remove "structuring" comments.
 278         (tui_cmd_window::clear_detail)
 279         (tui_cmd_window::do_make_visible_with_new_height)
 280         (tui_cmd_window::max_height): Move from elsewhere.
 281
 282 2019-07-17  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 285         Now static.
 286         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 287         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 288
 289 2019-07-17  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui.c: Update.
 292         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 293         tui-regs.c.
 294         * tui/tui-windata.h: Remove file.
 295         * tui/tui-windata.c: Remove file.
 296         * tui/tui-win.c (tui_data_window::set_new_height)
 297         (tui_data_window::do_make_visible_with_new_height): Move to
 298         tui-regs.c.
 299         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 300         * tui/tui-regs.c: Remove "structuring" comments.
 301         (tui_data_window::first_data_item_displayed)
 302         (tui_data_window::delete_data_content_windows)
 303         (tui_data_window::erase_data_content)
 304         (tui_data_window::display_all_data)
 305         (tui_data_window::refresh_all)
 306         (tui_data_window::do_scroll_vertical)
 307         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 308         (tui_data_window::do_make_visible_with_new_height)
 309         (tui_data_window::refresh_window): Move from elsewhere.
 310         (_initialize_tui_regs): Move to end of file.
 311         * tui/tui-layout.c: Update.
 312         * tui/tui-hooks.c: Update.
 313         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 314         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 315         tui-regs.c.
 316         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 321         seen.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-win.c (tui_source_window_base::set_new_height)
 326         (tui_source_window_base::do_make_visible_with_new_height): Use
 327         m_has_locator field directly.
 328         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 329         method.
 330         (struct tui_source_window_base) <has_locator>: Likewise.
 331
 332 2019-07-17  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 335         Don't declare.
 336         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 337         Remove.
 338         * tui/tui-win.c (tui_source_window_base::set_new_height)
 339         (tui_source_window_base::set_new_height)
 340         (make_invisible_and_set_new_height)
 341         (tui_source_window_base::do_make_visible_with_new_height)
 342         (tui_source_window_base::do_make_visible_with_new_height):
 343         Update.
 344         * tui/tui-layout.c (show_source_disasm_command, show_data)
 345         (show_source_or_disasm_and_command): Update.
 346         * tui/tui-layout.c (show_layout): Update.
 347
 348 2019-07-17  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-layout.c (make_data_window): Remove.
 351         (show_data): Unify creation and re-initialization cases.
 352
 353 2019-07-17  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-layout.c (make_source_window, make_disasm_window):
 356         Remove.
 357         (show_data): Unify creation and re-initialization cases.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-layout.c (make_command_window): Remove.
 362         (show_source_disasm_command, show_source_or_disasm_and_command):
 363         Unify creation and re-initialization cases.
 364
 365 2019-07-17  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 368         creation and re-initialization cases.
 369
 370 2019-07-17  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-regs.c (tui_get_register): Return void.
 373
 374 2019-07-17  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 377         Simplify.
 378
 379 2019-07-17  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 382         resetting.
 383
 384 2019-07-17  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 387         * tui/tui-regs.c (tui_reg_layout): New function.
 388         (tui_show_registers, tui_reg_command): Use it.
 389         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 390         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 391         parameters.
 392         (tui_layout_command): Remove.
 393
 394 2019-07-17  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui-layout.h (tui/tui-layout): Return void.
 397         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 398
 399 2019-07-17  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-layout.c (show_source_disasm_command, show_data):
 402         Update.
 403         (reset_locator): Remove.
 404         (show_source_or_disasm_and_command): Update.
 405
 406 2019-07-17  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-source.c (tui_source_window_base::reset): Remove
 409         win_type parameter.
 410         * tui/tui-layout.c (make_command_window, make_source_window)
 411         (make_disasm_window, make_data_window)
 412         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 413         (reset_locator, show_source_or_disasm_and_command): Update.
 414         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 415         win_type parameter.
 416         (struct tui_source_window_base) <reset>: Likewise.
 417
 418 2019-07-17  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-layout.c (show_source_disasm_command): Use
 421         reset_locator.
 422         (reset_locator): New function.
 423         (init_and_make_win): Remove.
 424         (show_source_or_disasm_and_command): Use reset_locator.
 425
 426 2019-07-17  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 429         condition.
 430         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 431         Remove condition.
 432         * tui/tui-source.c (tui_source_window_base::reset): New method.
 433         * tui/tui-layout.c (make_command_window): Don't call
 434         init_and_make_win.
 435         (make_source_window, make_disasm_window): Don't call
 436         make_source_or_disasm_window.
 437         (make_data_window): Don't call init_and_make_win.  Change calling
 438         convention.
 439         (show_source_disasm_command, show_data): Simplify.
 440         (make_source_or_disasm_window): Remove.
 441         (show_source_or_disasm_and_command): Simplify.
 442         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 443         (struct tui_source_window_base) <reset>: Likewise.
 444         <execution_info>: Remove initializer.
 445         * tui/tui-data.c (tui_source_window_base): Initialize
 446         execution_info.
 447
 448 2019-07-17  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 451         variable.
 452
 453 2019-07-17  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui.c (tui_rl_other_window): Update.
 456         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 457         superclass method first.  Always iterate over regs_content.
 458         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 459         method.
 460         * tui/tui-win.c (tui_set_focus_command): Update.
 461
 462 2019-07-17  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-win.c (tui_set_focus_command): Rename from
 465         tui_set_focus.  Call tui_enable.
 466         (tui_set_focus_command): Remove.
 467
 468 2019-07-17  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 471         refresh_window.
 472         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 473         touchwin.
 474         (tui_data_window::refresh_window): Call refresh_window on data
 475         items.  Always call superclass refresh_window.
 476         (tui_win_info::refresh): Remove.
 477         (tui_source_window_base::refresh_window): Update.
 478         (tui_refresh_all): Update.
 479         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 480         refresh_window.
 481         (show_source_or_disasm_and_command): Likewise.
 482         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 483         (struct tui_source_window_base) <refresh>: Likewise.
 484
 485 2019-07-17  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-winsource.c (tui_clear_source_content)
 488         (tui_show_source_content): Update.
 489         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 490         whether content is empty.
 491         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 492         Remove.
 493
 494 2019-07-17  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 497         window's contents.
 498         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 499         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 500
 501 2019-07-17  Tom Tromey  <tom@tromey.com>
 502
 503         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 504         (struct tui_data_item_window): Update.
 505
 506 2019-07-17  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 509         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 510         defines.
 511
 512 2019-07-17  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-winsource.h (tui_erase_source_content)
 515         (tui_clear_source_content): Remove "display_prompt" parameter.
 516         * tui/tui-winsource.c (tui_update_source_window_as_is)
 517         (tui_update_source_windows_with_addr): Update.
 518         (tui_clear_source_content): Remove "display_prompt" parameter.
 519         (tui_erase_source_content): Likewise.  Simplify.
 520         (tui_show_source_content): Update.
 521         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 522         * tui/tui-stack.c (tui_show_frame_info): Update.
 523         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 524         Remove defines.
 525
 526 2019-07-17  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 529         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 530         parameter.
 531         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 532         parameter.
 533
 534 2019-07-17  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-winsource.c (tui_clear_source_content)
 537         (tui_show_source_content, tui_show_exec_info_content)
 538         (tui_clear_exec_info_content): Update.
 539         * tui/tui-stack.c (tui_show_locator_content): Update.
 540         (tui_show_frame_info): Update.
 541         * tui/tui-source.h (tui_source_window): Don't declare.
 542         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 543         from tui_source_is_displayed.
 544         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 545         Remove field.
 546         (struct tui_source_window_base) <content_in_use>: New field.  Now
 547         bool.
 548         (struct tui_source_window) <showing_source_p>: New method.
 549         (TUI_SRC_WIN): Change cast.
 550         * tui/tui-data.c (tui_initialize_static_data): Update.
 551
 552 2019-07-17  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 555         location_matches_p.
 556         * tui/tui-source.c (tui_source_window::location_matches_p): New
 557         method.
 558         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 559         method.
 560         * tui/tui-data.h (struct tui_source_window_base)
 561         <location_matches_p>: New method.
 562         (struct tui_source_window, struct tui_disasm_window)
 563         <location_matches_p>: Likewise.
 564
 565 2019-07-17  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-win.c (tui_set_win_height_command): Rename from
 568         tui_set_win_height.
 569         (tui_set_win_height_command): Remove.
 570
 571 2019-07-17  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-source.c (tui_source_window): New constructor.  Add
 574         observer.
 575         (~tui_source_window): New destructor.
 576         (tui_source_window::style_changed): New method.
 577         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 578         (tui_attach_detach_observers): Update.
 579         * tui/tui-data.h (struct tui_source_window): Make constructor not
 580         inline.  Add destructor.
 581         (struct tui_source_window) <style_changed>: New method.
 582         <m_observable>: New member.
 583
 584 2019-07-17  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 587         * tui/tui-win.c (tui_resize_all): Fix typo.
 588
 589 2019-07-17  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 592         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 593         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 594         * tui/tui-win.c (window_name_completer): Use foreach.
 595         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 596         (update_tab_width): Likewise.
 597         * tui/tui-layout.c (show_layout): Update.
 598         * tui/tui-data.h (class tui_window_iterator): New.
 599         (struct all_tui_windows): New.
 600         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 601
 602 2019-07-17  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 605         parameter.  Don't reference globals.
 606         (tui_reg_command): Update.
 607
 608 2019-07-17  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-regs.c (tui_show_registers): Simplify.
 611
 612 2019-07-17  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-regs.c (tui_show_registers): Update.
 615         (tui_show_register_group): Add win_info parameter.
 616
 617 2019-07-17  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 620         Rename from tui_display_reg_element_at_line.
 621         (tui_data_window::display_registers_from_line): Update.
 622         * tui/tui-data.h (struct tui_data_window)
 623         <display_reg_element_at_line>: New method.
 624
 625 2019-07-17  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-regs.h (tui_display_registers_from)
 628         (tui_display_registers_from_line): Don't declare.
 629         * tui/tui-windata.c (tui_data_window::display_all_data)
 630         (tui_data_window::refresh_all)
 631         (tui_data_window::do_scroll_vertical): Update.
 632         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 633         from tui_display_registers_from.
 634         (tui_display_reg_element_at_line): Update.
 635         (tui_data_window::display_registers_from_line): Rename from
 636         tui_display_registers_from_line.
 637         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 638         display_registers_from_line>: New methods.
 639
 640 2019-07-17  Tom Tromey  <tom@tromey.com>
 641
 642         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 643         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 644         from tui_erase_data_content.
 645         (tui_data_window::display_all_data)
 646         (tui_data_window::refresh_all)
 647         (tui_data_window::do_scroll_vertical): Update.
 648         * tui/tui-regs.c (tui_show_registers): Update.
 649         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 650         New method.
 651
 652 2019-07-17  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 655         declare.
 656         * tui/tui-windata.c
 657         (tui_data_window::delete_data_content_windows): Rename from
 658         tui_delete_data_content_windows.
 659         (tui_data_window::display_all_data)
 660         (tui_data_window::do_scroll_vertical): Update.
 661         * tui/tui-data.h (struct tui_data_window)
 662         <delete_data_content_windows>: New method.
 663
 664 2019-07-17  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 667         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 668
 669 2019-07-17  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 672         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 673         from tui_display_all_data.
 674         * tui/tui-win.c
 675         (tui_data_window::do_make_visible_with_new_height): Update.
 676         * tui/tui-regs.c (tui_show_registers): Update.
 677         * tui/tui-layout.c (tui_set_layout): Update.
 678         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 679         method.
 680
 681 2019-07-17  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 684         * tui/tui-windata.c (tui_display_data_from): Remove.
 685         (tui_data_window::refresh_all): Update.
 686
 687 2019-07-17  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 690         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 691         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 692         tui_display_registers_from_line.
 693         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 694         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 695         "force_display" parameter.
 696
 697 2019-07-17  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 700         declare.
 701         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 702         Rename from tui_first_reg_element_no_inline.
 703         (tui_display_reg_element_at_line)
 704         (tui_display_registers_from_line): Update.
 705         * tui/tui-data.h (struct tui_data_window)
 706         <first_reg_element_no_inline>: New method.
 707
 708 2019-07-17  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-windata.c (tui_display_data_from)
 711         (tui_data_window::do_scroll_vertical): Update.
 712         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 713         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 714         Rename from tui_line_from_reg_element_no.
 715         (tui_display_registers_from_line): Update.
 716         * tui/tui-data.h (struct tui_data_window)
 717         <line_from_reg_element_no>: New method.
 718
 719 2019-07-17  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 722         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 723         tui_last_regs_line_no.
 724         (tui_display_reg_element_at_line)
 725         (tui_display_registers_from_line): Update.
 726         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 727         method.
 728
 729 2019-07-17  Tom Tromey  <tom@tromey.com>
 730
 731         PR tui/24722:
 732         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 733         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 734         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 735         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 736         (tui_update_breakpoint_info): Likewise.
 737         * tui/tui-hooks.c (tui_event_create_breakpoint)
 738         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 739         Update.
 740
 741 2019-07-17  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 744
 745 2019-07-17  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-winsource.c (tui_update_source_window_as_is)
 748         (tui_update_source_windows_with_addr): Update.
 749         * tui/tui-source.h (tui_set_source_content)
 750         (tui_show_symtab_source): Add "win_info" parameter.
 751         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 752         parameter.
 753         (tui_show_symtab_source): Likewise.
 754
 755 2019-07-17  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-wingeneral.c
 758         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 759
 760 2019-07-17  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 763         (struct tui_cmd_window) <can_scroll>: New method.
 764         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 765         method.
 766
 767 2019-07-17  Tom Tromey  <tromey@adacore.com>
 768
 769         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 770         do_field_signed>: Rename.  Change type of "value".
 771         * ui-out.c (ui_out::field_signed): Rename from field_int.
 772         Change type of "value".
 773         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 774         type of "value".
 775         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 776         do_field_int.  Change type of "value".
 777         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 778         do_field_int.  Change type of "value".
 779         * tracepoint.c (trace_status_mi, tfind_1)
 780         (print_one_static_tracepoint_marker): Update.
 781         * thread.c (print_thread_info_1, print_selected_thread_frame):
 782         Update.
 783         * stack.c (print_frame, print_frame_info): Update.
 784         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 785         Update.
 786         * source.c (print_source_lines_base): Update.
 787         * skip.c (info_skip_command): Update.
 788         * record-btrace.c (btrace_ui_out_decode_error)
 789         (btrace_call_history_src_line): Update.
 790         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 791         Update.
 792         * progspace.c (print_program_space): Update.
 793         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 794         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 795         do_field_int.  Change type of "value".
 796         * mi/mi-out.c (mi_ui_out::do_table_begin)
 797         (mi_ui_out::do_table_header): Update.
 798         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 799         type of "value".
 800         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 801         (mi_cmd_data_list_changed_registers, output_register)
 802         (mi_cmd_data_read_memory, mi_load_progress)
 803         (mi_cmd_trace_frame_collected): Update.
 804         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 805         Update.
 806         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 807         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 808         (mi_cmd_var_list_children, varobj_update_one): Update.
 809         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 810         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 811         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 812         * inferior.c (print_inferior): Update.
 813         * gdb_bfd.c (print_one_bfd): Update.
 814         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 815         Update.
 816         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 817         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 818         do_field_int.  Change type of "value".
 819         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 820         do_field_int.  Change type of "value".
 821         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 822         (print_one_breakpoint_location, print_it_catch_fork)
 823         (print_one_catch_fork, print_it_catch_vfork)
 824         (print_one_catch_vfork, print_it_catch_solib)
 825         (print_it_catch_exec, print_it_ranged_breakpoint)
 826         (print_mention_watchpoint, print_mention_masked_watchpoint)
 827         (bkpt_print_it, update_static_tracepoint): Update.
 828         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 829         * break-catch-syscall.c (print_it_catch_syscall): Update.
 830         * ada-tasks.c (print_ada_task_info): Update.
 831         * ada-lang.c (print_it_exception, print_mention_exception):
 832         Update.
 833
 834 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 835
 836         PR breakpoints/24541
 837         * gdbarch.c: Regenerate.
 838         * gdbarch.h: Regenerate.
 839         * gdbarch.sh: Adjust return type and parameter types for
 840         'stap_adjust_register'.
 841         (i386_stap_adjust_register): Adjust signature and return new
 842         register name.
 843         * stap-probe.c (stap_parse_register_operand): Adjust use of
 844         'gdbarch_stap_adjust_register'.
 845
 846 2019-07-17  Tom Tromey  <tromey@adacore.com>
 847
 848         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 849         declare VEC.
 850         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 851         std::vector.
 852         (struct s390_process_info): Add initializers.
 853         (s390_add_process): Use new.
 854         (s390_linux_nat_target::low_forget_process): Use delete.
 855         (s390_linux_nat_target::low_new_fork)
 856         (s390_linux_nat_target::stopped_by_watchpoint)
 857         (s390_linux_nat_target::low_prepare_to_resume)
 858         (s390_linux_nat_target::insert_watchpoint)
 859         (s390_linux_nat_target::insert_hw_breakpoint)
 860         (s390_linux_nat_target::remove_watchpoint)
 861         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 862
 863 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 864
 865         * aarch64-fbsd-nat.c: Include regcache.h.
 866         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 867         argument.
 868         (aarch64_fbsd_nat_target::fetch_registers)
 869         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 870         variable.
 871         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 872
 873 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 874
 875         * fbsd-nat.c: Include gdbarch.h.
 876
 877 2019-07-15  Tom Tromey  <tromey@adacore.com>
 878
 879         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 880
 881 2019-07-15  Tom Tromey  <tromey@adacore.com>
 882
 883         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 884         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 885         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 886         * cli-out.c (cli_ui_out::do_field_int): New method.
 887         * ui-out.c (ui_out::field_unsigned): New method.
 888         * symfile.c (generic_load): Use field_unsigned.
 889         (print_transfer_performance): Likewise.
 890         * record-btrace.c (ui_out_field_uint): Remove.
 891         (btrace_call_history_insn_range, btrace_call_history): Use
 892         field_unsigned.
 893         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 894         field_unsigned.
 895         * ui-out.h (class ui_out) <field_unsigned>: New method.
 896         <do_field_unsigned>: Likewise.
 897
 898 2019-07-15  Tom Tromey  <tromey@adacore.com>
 899
 900         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 901         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 902         * target.c (flash_erase_command): Use field_string.
 903         * infrun.c (print_signal_received_reason): Use field_string.
 904         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 905         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 906         field_string.
 907         * ada-tasks.c (print_ada_task_info): Use field_string.
 908
 909 2019-07-15  Tom Tromey  <tromey@adacore.com>
 910
 911         * target.c (flash_erase_command): Use field_core_addr.
 912         * symfile.c (generic_load): Use field_core_addr.
 913         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 914         Use field_core_addr.
 915         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 916         field_core_addr.
 917
 918 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 919
 920         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 921         value if its desired type is smaller than a CORE_ADDR and signed.
 922
 923 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 926         of changes to field names, and use new is_reference field to
 927         decide if a property is a reference or not.
 928         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 929         field.
 930         (struct dwarf2_property_baton): Update header comment, rename
 931         'referenced_type' to 'property_type' and update comments.
 932         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 933         default property type, store in property baton, update to take
 934         accound of renamed field.
 935         (read_func_scope): Update call to attr_to_dynamic_prop.
 936         (read_array_type): Likewise.
 937         (dwarf2_per_cu_addr_sized_int_type): New function.
 938         (read_subrange_index_type): Move type finding code to
 939         dwarf2_per_cu_addr_sized_int_type.
 940         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 941         (dwarf2_per_cu_addr_type): New function.
 942         (set_die_type): Update calls to attr_to_dynamic_prop.
 943
 944 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 945
 946         * dwarf2read.c (read_subrange_index_type): New function.
 947         (read_subrange_type): Move code into new function and call it.
 948         * gdbtypes.c (create_range_type): Add some asserts.
 949
 950 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 951
 952         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 953         update return statements.
 954         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 955         declaration, and update comment to match.
 956         * gdbtypes.c (resolve_dynamic_array): Update call to
 957         dwarf2_evaluate_property to match new return type.
 958
 959 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 960
 961         * valarith.c (value_subscripted_rvalue): Change lowerbound
 962         parameter type from int to LONGEST.
 963         * value.h (value_subscripted_rvalue): Likewise in declaration.
 964
 965 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 966
 967         * cli/cli-utils.c (info_print_command_completer): New function.
 968         * cli/cli-utils.h: Add 'completer.h' include, and forward
 969         declaration for 'struct cmd_list_element'.
 970         (info_print_command_completer): Declare.
 971         * stack.c (_initialize_stack): Add completer for 'info locals' and
 972         'info args'.
 973         * symtab.c (_initialize_symtab): Add completer for 'info
 974         variables' and 'info functions'.
 975         * NEWS: Mention completion for additional info commands.
 976
 977 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 978
 979         * cli/cli-utils.c (extract_info_print_args): Delete.
 980         (extract_arg_maybe_quoted): Delete.
 981         (info_print_options_defs): New variable.
 982         (make_info_print_options_def_group): New function.
 983         (extract_info_print_options): Define new function.
 984         * cli/cli-utils.h (extract_info_print_args): Delete.
 985         (struct info_print_options): New structure.
 986         (extract_info_print_options): Declare new function.
 987         * stack.c (info_locals_command): Update to use new
 988         extract_info_print_options, also add a header comment.
 989         (info_args_command): Likewise.
 990         * symtab.c (info_variables_command): Likewise.
 991         (info_functions_command): Likewise.
 992
 993 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 994
 995         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 996         to extract string arguments.
 997         * common/common-utils.c (extract_string_maybe_quoted): New function.
 998         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 999
1000 2019-07-11  Tom Tromey  <tromey@adacore.com>
1001
1002         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1003         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1004         * top.h (gdbinit): Don't declare.
1005         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1006         into...
1007         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1008         * top.c (gdb_init): Don't call init_cli_cmds.
1009         (gdbinit): Remove.
1010         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1011
1012 2019-07-11  Tom Tromey  <tromey@adacore.com>
1013
1014         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1015         after it has been moved.
1016
1017 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1018
1019         * valops.c (value_must_coerce_to_target): Change return type to
1020         bool.
1021         * value.h (value_must_coerce_to_target): Likewise.
1022
1023 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1024
1025         * breakpoint.c (is_hardware_watchpoint): Remove
1026         forward-declaration.
1027         (is_masked_watchpoint): Change return type to bool.
1028         (is_tracepoint): Likewise.
1029         (is_breakpoint): Likewise.
1030         (is_hardware_watchpoint): Likewise.
1031         (is_watchpoint): Likewise.
1032         (is_no_memory_software_watchpoint): Likewise.
1033         (is_catchpoint): Likewise.
1034         (breakpoint_1): Make FILTER parameter's return type bool.
1035         is_masked_watchpoint): Change return type to bool.
1036         (save_breakpoints): Make FILTER parameter's return type bool.
1037         * breakpoint.h (is_breakpoint): Change return type to bool.
1038         (is_watchpoint): Likewise.
1039         (is_catchpoint): Likewise.
1040         (is_tracepoint): Likewise.
1041
1042 2019-07-10  Tom Tromey  <tom@tromey.com>
1043
1044         * defs.h: Don't include gdbarch.h.
1045         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1046         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1047         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1048         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1049         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1050         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1051         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1052         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1053         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1054         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1055         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1056         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1057         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1058         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1059         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1060         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1061         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1062         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1063         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1064         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1065         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1066         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1067         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1068         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1069         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1070         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1071         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1072
1073 2019-07-10  Tom Tromey  <tromey@adacore.com>
1074
1075         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1076         * breakpoint.c (init_ada_exception_breakpoint): Register as
1077         bp_catchpoint.
1078         (print_one_breakpoint_location, print_one_breakpoint): Use
1079         is_ada_exception_catchpoint.
1080         * ada-lang.c (class ada_catchpoint_location): Pass
1081         bp_loc_software_breakpoint to bp_location constructor.
1082         (is_ada_exception_catchpoint): New function.
1083
1084 2019-07-10  Tom Tromey  <tromey@adacore.com>
1085
1086         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1087         VEC.
1088         (struct arm_exidx_entry): New method operator<.
1089         (struct arm_exidx_data) <section_maps>: Change type.
1090         (arm_exidx_data_free): Remove.
1091         (arm_exidx_data_key): Change type.  Move lower.
1092         (arm_exidx_new_objfile): Update.
1093         (arm_compare_exidx_entries): Remove.
1094         (arm_find_exidx_entry, _initialize_arm_tdep)
1095
1096 2019-07-10  Tom Tromey  <tromey@adacore.com>
1097
1098         * solib-spu.c (ocl_program_data_key): Change type.
1099         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1100         Update.
1101
1102 2019-07-10  Tom Tromey  <tromey@adacore.com>
1103
1104         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1105         (struct solib_aix_inferior_data) <library_list>: Change type.
1106         (solib_aix_inferior_data_handle): Change type.
1107         (get_solib_aix_inferior_data): Update.
1108         (solib_aix_free_library_list): Remove.
1109         (library_list_start_library): Update.
1110         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1111         return type.
1112         (solib_aix_get_library_list)
1113         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1114         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1115
1116 2019-07-10  Tom Tromey  <tromey@adacore.com>
1117
1118         * solib-dsbt.c (struct dsbt_info): Add initializers.
1119         (solib_dsbt_pspace_data): Change type.
1120         (dsbt_pspace_data_cleanup): Remove.
1121         (get_dsbt_info, _initialize_dsbt_solib): Update.
1122
1123 2019-07-10  Tom Tromey  <tromey@adacore.com>
1124
1125         * spu-tdep.c (spu_overlay_data): Change type.
1126         (spu_get_overlay_table, spu_overlay_new_objfile)
1127         (_initialize_spu_tdep): Update.
1128
1129 2019-07-10  Tom Tromey  <tromey@adacore.com>
1130
1131         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1132         destructor.
1133         (dbx_objfile_data_key): Change type and declare later.
1134         (DBX_SYMFILE_INFO): Rewrite.
1135         * dbxread.c (dbx_objfile_data_key): Change type.
1136         (dbx_symfile_init): Update.
1137         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1138         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1139         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1140
1141 2019-07-10  Tom Tromey  <tromey@adacore.com>
1142
1143         * jit.c (jit_program_space_key): Change type.  Move lower.
1144         (get_jit_program_space_data): Update.
1145         (jit_program_space_data_cleanup): Remove.
1146         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1147         Update.
1148         (struct jit_program_space_data): Add initializers.
1149
1150 2019-07-10  Tom Tromey  <tromey@adacore.com>
1151
1152         * solib-darwin.c (struct darwin_info): Add initializers.
1153         (solib_darwin_pspace_data): Change type.
1154         (darwin_pspace_data_cleanup): Remove.
1155         (get_darwin_info, _initialize_darwin_solib): Update.
1156
1157 2019-07-10  Tom Tromey  <tromey@adacore.com>
1158
1159         * remote-sim.c (struct sim_inferior_data): Add initializers,
1160         constructor, and destructor.
1161         (sim_inferior_data_key): Change type.  Move lower.
1162         (check_for_duplicate_sim_descriptor): Update.
1163         (get_sim_inferior_data): Use new.  Update.
1164         (~sim_inferior_data_cleanup): Rename from
1165         sim_inferior_data_cleanup.  Simplify.
1166         (gdbsim_close_inferior, simulator_command)
1167         (sim_command_completer, _initialize_remote_sim): Update.
1168         (next_pid, INITIAL_PID): Move earlier.
1169
1170 2019-07-10  Tom Tromey  <tromey@adacore.com>
1171
1172         * python/python-internal.h (create_thread_object): Return
1173         gdbpy_ref.
1174         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1175         * python/py-inferior.c (struct threadlist_entry): Add
1176         constructor.
1177         <thread_obj>: Now a gdbpy_ref.
1178         (thread_to_thread_object): Update.
1179         (add_thread_object): Use new.
1180         (delete_thread_object): Use delete.
1181         (infpy_threads): Update.
1182         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1183         GIL.
1184
1185 2019-07-10  Tom Tromey  <tromey@adacore.com>
1186
1187         * valops.c (value_cast): Specialize error message for Ada.
1188
1189 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1190
1191         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1192
1193 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1194
1195         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1196         bpstat_should_step): Return bool, adjust comments.
1197         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1198         bpstat_should_step): Likewise.
1199
1200 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1201
1202         * features/Makefile: Use feature target descriptions for Arm.
1203         * features/arm/arm-core.c: Generate new file.
1204         * features/arm/arm-fpa.c: Likewise.
1205         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1206         * features/arm/arm-m-profile.c: Likewise.
1207         * features/arm/arm-vfpv2.c: Likewise.
1208         * features/arm/arm-vfpv3.c: Likewise.
1209         * features/arm/xscale-iwmmxt.c: Likewise.
1210         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1211
1212 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1213
1214         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1215         ptrace earlier.
1216
1217 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1218
1219         * features/aarch64-pauth.c: Regenerate.
1220
1221 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1222
1223         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1224         bool.
1225         (bpstat_what): Use false instead of 0.
1226
1227 2019-07-09  Pedro Alves  <palves@redhat.com>
1228
1229         * break-catch-throw.c (is_exception_catchpoint): New.
1230         * breakpoint.c (print_one_breakpoint_location): New parameter
1231         'raw_loc'.  Handle it.  Use
1232         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1233         looking at the breakpoint's type.
1234         (print_one_breakpoint): If handling "maint info breakpoints", also
1235         print locations of exception catchpoints.
1236         * breakpoint.h (is_exception_catchpoint): Declare.
1237
1238 2019-07-09  Pedro Alves  <palves@redhat.com>
1239
1240         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1241         "addr" field.
1242         (allocate_location_exception_catchpoint): New.
1243         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1244         (initialize_throw_catchpoint_ops): Install
1245         allocate_location_exception_catchpoint as allocate_location
1246         method.
1247         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1248         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1249         bp_loc_other.
1250         (breakpoint_address_is_meaningful): Delete.
1251         (bl_address_is_meaningful): New.
1252         (breakpoint_locations_match): Adjust comment.
1253         (bp_location_from_bp_type): New, factored out of...
1254         (bp_location::bp_location(breakpoint *)): ... this.
1255         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1256         factored out of...
1257         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1258         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1259         breakpoint_address_is_meaningful.
1260         (bp_locations_compare): Adjust comment.
1261         (update_global_location_list): Use bl_address_is_meaningful
1262         instead of breakpoint_address_is_meaningful.
1263         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1264         explicit.
1265         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1266         * python/py-breakpoint.c (bppy_get_location): No longer check
1267         whether location is null.
1268
1269 2019-07-09  Pedro Alves  <palves@redhat.com>
1270
1271         PR c++/15468
1272         * breakpoint.c (print_one_breakpoint_location): Remove
1273         single-location assert.
1274
1275 2019-07-09  Tom Tromey  <tom@tromey.com>
1276
1277         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1278         * configure: Rebuild.
1279         * configure.ac: Change common to gdbsupport.
1280         * gdbsupport: Rename from common.
1281         * acinclude.m4: Change common to gdbsupport.
1282         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1283         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1284         gdbsupport.
1285         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1286         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1287         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1288         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1289         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1290         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1291         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1292         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1293         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1294         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1295         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1296         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1297         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1298         coff-pe-read.c, command.h, compile/compile-c-support.c,
1299         compile/compile-c.h, compile/compile-cplus-symbols.c,
1300         compile/compile-cplus-types.c, compile/compile-cplus.h,
1301         compile/compile-loc2c.c, compile/compile.c, completer.c,
1302         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1303         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1304         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1305         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1306         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1307         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1308         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1309         features/aarch64-core.c, features/aarch64-fpu.c,
1310         features/aarch64-pauth.c, features/aarch64-sve.c,
1311         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1312         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1313         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1314         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1315         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1316         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1317         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1318         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1319         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1320         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1321         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1322         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1323         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1324         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1325         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1326         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1327         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1328         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1329         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1330         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1331         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1332         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1333         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1334         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1335         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1336         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1337         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1338         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1339         minsyms.c, mips-linux-tdep.c, namespace.h,
1340         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1341         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1342         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1343         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1344         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1345         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1346         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1347         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1348         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1349         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1350         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1351         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1352         procfs.c, producer.c, progspace.h, psymtab.h,
1353         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1354         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1355         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1356         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1357         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1358         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1359         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1360         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1361         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1362         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1363         target-memory.c, target.c, target.h, target/waitstatus.c,
1364         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1365         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1366         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1367         unittests/array-view-selftests.c,
1368         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1369         unittests/common-utils-selftests.c,
1370         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1371         unittests/format_pieces-selftests.c,
1372         unittests/function-view-selftests.c,
1373         unittests/lookup_name_info-selftests.c,
1374         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1375         unittests/mkdir-recursive-selftests.c,
1376         unittests/observable-selftests.c,
1377         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1378         unittests/parse-connection-spec-selftests.c,
1379         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1380         unittests/scoped_fd-selftests.c,
1381         unittests/scoped_mmap-selftests.c,
1382         unittests/scoped_restore-selftests.c,
1383         unittests/string_view-selftests.c, unittests/style-selftests.c,
1384         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1385         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1386         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1387         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1388         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1389         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1390
1391 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1394         bool value.
1395         (decode_digits_ordinary): Set explicit_line field in sal.
1396         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1397         symtab_and_line that was set on an explicit line number in
1398         assembler code.  Do always update the recorded symtab and line if
1399         we do skip the prologue.
1400
1401 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1402
1403         * breakpoint.c (set_breakpoint_location_function): Remove
1404         explicit_loc parameter.
1405         (momentary_breakpoint_from_master): Update call to
1406         set_breakpoint_location_function.
1407         (add_location_to_breakpoint): Likewise.
1408
1409 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1410
1411         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1412         required features based on default bfd type when no specific bfd
1413         is present.
1414
1415 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1416
1417         * NEWS: Mention that GDB printf and eval commands can now print
1418         C-style and Ada-style convenience var strings without
1419         calling the inferior.
1420         * printcmd.c (printf_c_string): Locally print GDB internal var
1421         instead of transiting via the inferior.
1422         (printf_wide_c_string): Likewise.
1423
1424 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1425
1426         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1427
1428 2019-07-04  Tom Tromey  <tom@tromey.com>
1429
1430         PR tui/24724:
1431         * tui/tui-winsource.c (tui_clear_source_content): Update.
1432         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1433         (tui_update_breakpoint_info): Update.
1434         (tui_set_exec_info_content): Update.
1435         * tui/tui-source.c (tui_set_source_content_nil): Update.
1436         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1437         has_break.
1438         * tui/tui-data.h (enum tui_bp_flag): New.
1439         (tui_bp_flags): New enum flags type.
1440         (struct tui_source_element) <break_mode>: Change type.  Rename
1441         from has_break.
1442         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1443         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1444         constants.
1445         * tui/tui-winsource.h: Fix comment.
1446
1447 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1448
1449         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1450         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1451         (store_fpregs_to_thread)
1452         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1453         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1454         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1455         (IWMMXT_REGS_SIZE): Add define.
1456         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1457         (fetch_vfp_regs, store_vfp_regs)
1458         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1459         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1460
1461 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1462
1463         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1464         defines.
1465         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1466         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1467         (ARM_INT_REGISTER_SIZE): ...to this.
1468         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1469         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1470         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1471         (arm_linux_collect_gregset, supply_nwfpe_register)
1472         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1473         defines.
1474         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1475         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1476         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1477         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1478         (arm_return_in_memory, arm_store_return_value)
1479         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1480         (arm_record_ld_st_multiple): Likewise.
1481         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1482         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1483
1484 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1485
1486         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1487         AARCH64_DISPLACED_MODIFIED_INSNS.
1488         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1489         (aarch64_displaced_step_copy_insn): Likewise.
1490         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1491         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1492         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1493         ARM_DISPLACED_MODIFIED_INSNS.
1494         * arm-tdep.c (arm_gdbarch_init): Likewise.
1495         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1496         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1497         (struct arm_displaced_step_closure): Use
1498         ARM_DISPLACED_MODIFIED_INSNS.
1499
1500 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1501
1502         * features/Makefile: Remove unused xml files.
1503         * features/aarch64.xml: Remove.
1504         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1505         * features/i386/amd64-avx-avx512.xml: Remove.
1506         * features/i386/amd64-avx-linux.xml: Remove.
1507         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1508         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1509         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1510         * features/i386/amd64-avx-mpx.xml: Remove.
1511         * features/i386/amd64-avx.xml: Remove.
1512         * features/i386/amd64-linux.xml: Remove.
1513         * features/i386/amd64-mpx-linux.xml: Remove.
1514         * features/i386/amd64-mpx.xml: Remove.
1515         * features/i386/amd64.xml: Remove.
1516         * features/i386/i386-avx-avx512-linux.xml: Remove.
1517         * features/i386/i386-avx-avx512.xml: Remove.
1518         * features/i386/i386-avx-linux.xml: Remove.
1519         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1520         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1521         * features/i386/i386-avx-mpx-linux.xml: Remove.
1522         * features/i386/i386-avx-mpx.xml: Remove.
1523         * features/i386/i386-avx.xml: Remove.
1524         * features/i386/i386-linux.xml: Remove.
1525         * features/i386/i386-mmx-linux.xml: Remove.
1526         * features/i386/i386-mmx.xml: Remove.
1527         * features/i386/i386-mpx-linux.xml: Remove.
1528         * features/i386/i386-mpx.xml: Remove.
1529         * features/i386/i386.xml: Remove.
1530         * features/i386/x32-avx-avx512-linux.xml: Remove.
1531         * features/i386/x32-avx-linux.xml: Remove.
1532         * features/i386/x32-linux.xml: Remove.
1533
1534 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1535
1536         * regformats/aarch64.dat: Remove.
1537         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1538         * regformats/i386/amd64-avx-linux.dat: Remove.
1539         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1540         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1541         * regformats/i386/amd64-linux.dat: Remove.
1542         * regformats/i386/amd64-mpx-linux.dat: Remove.
1543         * regformats/i386/amd64.dat: Remove.
1544         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1545         * regformats/i386/i386-avx-linux.dat: Remove.
1546         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1547         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1548         * regformats/i386/i386-linux.dat: Remove.
1549         * regformats/i386/i386-mmx-linux.dat: Remove.
1550         * regformats/i386/i386-mpx-linux.dat: Remove.
1551         * regformats/i386/i386.dat: Remove.
1552         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1553         * regformats/i386/x32-avx-linux.dat: Remove.
1554         * regformats/i386/x32-linux.dat: Remove.
1555
1556 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1557
1558         * aarch64-tdep.c: Remove xml self tests.
1559         * amd64-linux-tdep.c: Likewise.
1560         * amd64-tdep.c: Likewise.
1561         * i386-linux-tdep.c: Likewise.
1562         * i386-tdep.c: Likewise.
1563
1564 2019-07-03  Pedro Alves  <palves@redhat.com>
1565
1566         PR cli/24732
1567         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1568         (pipe_cmd_option_defs): New.
1569         (make_pipe_cmd_options_def_group): New.
1570         (pipe_command): Use gdb::option::process_options.
1571         (pipe_command_completer): New function.
1572         (_initialize_cli_cmds): Install completer for "pipe" command.
1573
1574 2019-07-03  Pedro Alves  <palves@redhat.com>
1575
1576         * cli/cli-option.c (union option_value) <string>: New field.
1577         (struct option_def_and_value): Add ctor, move ctor, dtor and
1578         use DISABLE_COPY_AND_ASSIGN.
1579         (option_def_and_value::clear_value): New.
1580         (parse_option, save_option_value_in_ctx, get_val_type_str)
1581         (add_setshow_cmds_for_options): Handle var_string.
1582         * cli-option.h (union option_def::var_address) <string>: New
1583         field.
1584         (struct string_option_def): New.
1585         * maint-test-options.c (struct test_options_opts): Add default
1586         ctor and use DISABLE_COPY_AND_ASSIGN.
1587         <string_opt>: New field.
1588         (test_options_opts::~test_options_opts): New.
1589         (test_options_opts::dump): Also dump "-string".
1590         (test_options_option_defs): Install "string.
1591
1592 2019-07-03  Pedro Alves  <palves@redhat.com>
1593
1594         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1595         option_value with a null enumeration.
1596         (complete_options): Save the option values in the context.
1597         (save_option_value_in_ctx): New, factored out from ...
1598         (process_options): ... here.
1599         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1600         of the function.
1601         * maint-test-options.c (test_options_opts::dump): New, factored
1602         out from ...
1603         (maintenance_test_options_command_mode): ... here.
1604         (maintenance_test_options_command_completion_result): Delete.
1605         (maintenance_test_options_command_completion_text): Update
1606         comment.
1607         (maintenance_show_test_options_completion_result): Change
1608         prototype.  Just print
1609         maintenance_test_options_command_completion_text.
1610         (save_completion_result): New.
1611         (maintenance_test_options_completer_mode): Pass options context to
1612         complete_options, and then save a dump.
1613         (_initialize_maint_test_options): Use add_cmd to install "maint
1614         show test-options-completion-result".
1615
1616 2019-07-03  Pedro Alves  <palves@redhat.com>
1617
1618         * NEWS (New commands): Mention "with" and "maint with".
1619         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1620         (with_command, with_command_completer): New.
1621         (pipe_command): Adjust to new repeat_previous
1622         interface.
1623         (_initialize_cli_cmds): Install the "with" command and its "w"
1624         alias.
1625         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1626         declarations.
1627         * cli/cli-setshow.c (parse_cli_var_uinteger)
1628         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1629         argument strings for all var_types.
1630         (get_setshow_command_value_string): New, factored out from ...
1631         (do_show_command): ... this.
1632         * cli/cli-setshow.h: Include <string>.
1633         (get_setshow_command_value_string): Declare.
1634         * command.h (repeat_previous): Now returns const char *.  Adjust
1635         comment.
1636         * maint.c: Include "cli/cli-cmds.h".
1637         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1638         (_initialize_maint_cmds): Register the "maintenance with" command.
1639         * top.c (repeat_previous): Move bits from pipe_command here:
1640         Return the saved command line, if any; error out if there's no
1641         command to relaunch.
1642
1643 2019-07-03  Pedro Alves  <palves@redhat.com>
1644
1645         * NEWS (New commands): Mention "maint set/show test-settings"
1646         instead of "maint test-settings".
1647         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1648         (maintenance_test_settings_set_list): Rename to ...
1649         (maintenance_set_test_settings_list): ... this.
1650         (maintenance_test_settings_show_list): Rename to  ...
1651         (maintenance_show_test_settings_list): ... this.
1652         (maintenance_test_settings_cmd): Delete.
1653         (maintenance_test_settings_set_cmd): ...
1654         (maintenance_set_test_settings_cmd): ... this.
1655         (maintenance_test_settings_show_cmd): ...
1656         (maintenance_show_test_settings_cmd): ... this.
1657         (maintenance_test_settings_show_value_cmd):
1658         (maintenance_show_test_settings_value_cmd): ... this.
1659         (_initialize_maint_test_settings): No longer install the "maint
1660         test-settings" prefix command.  Rename "maint test-settings set"
1661         to "maint set test-settings", and "maint test-settings show" to
1662         "maint show test-settings".  Adjust all subcommands.
1663
1664 2019-07-03  Pedro Alves  <palves@redhat.com>
1665
1666         * maint-test-settings.c: Fix file's intro comment.  Replace all
1667         references to "test-options" with references to "test-settings",
1668         in comments.
1669
1670 2019-07-03  Pedro Alves  <palves@redhat.com>
1671
1672         * maint-test-settings.c (maintenance_test_settings_xxx)
1673         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1674         New.
1675         (maintenance_test_settings_enums): Use them.
1676         (maintenance_test_settings_enum): Default to
1677         maintenance_test_settings_xxx.
1678         (_initialize_maint_test_settings): Initialize
1679         MAINTENANCE_TEST_SETTINGS_FILENAME.
1680
1681 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1682
1683         * breakpoint.h (remove_breakpoints_inf): Change return type to
1684         void, move function documentation here.
1685         * breakpoint.c (remove_breakpoints_inf): Change return type to
1686         void, move function documentation to header.
1687
1688 2019-07-02  Pedro Alves  <palves@redhat.com>
1689
1690         * NEWS (Completion improvements): Mention "info threads".
1691         * thread.c (struct info_threads_opts, info_threads_option_defs)
1692         (make_info_threads_options_def_group): New.
1693         (info_threads_command): Use gdb::option::process_options.
1694         (info_threads_command_completer): New.
1695         (_initialize_thread): Use gdb::option::build_help to build the
1696         help text for "info threads".
1697
1698 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1699
1700         * defs.h (generic_load): Move from here...
1701         * symfile.h (generic_load): ... to here.  Rename name parameter
1702         to args.
1703         * symfile.c (generic_load): Add comment.
1704
1705 2019-07-01  Tom Tromey  <tromey@adacore.com>
1706
1707         * dwarf2read.c
1708         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1709         declaration of without_params.  Fix formatting.
1710
1711 2019-07-01  Tom Tromey  <tromey@adacore.com>
1712
1713         * ada-exp.y (find_primitive_type): Update.
1714         * ada-lang.h (ada_lookup_symbol): Update.
1715         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1716         parameter.
1717         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1718
1719 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1720
1721         PR breakpoints/24541
1722         * gdbarch.c: Regenerate.
1723         * gdbarch.h: Regenerate.
1724         * gdbarch.sh: Add 'stap_adjust_register'.
1725         * i386-tdep.c: Include '<unordered_set>'.
1726         (i386_stap_adjust_register): New function.
1727         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1728         * stap-probe.c (stap_parse_register_operand): Call
1729         'gdbarch_stap_adjust_register'.
1730
1731 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1732
1733         PR python/24742
1734         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1735         * python/python.c (do_start_initialization): Use 'xmalloc'
1736         instead of 'PyMem_Malloc'.
1737
1738 2019-06-28  Tom Tromey  <tromey@adacore.com>
1739
1740         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1741         for Ada.
1742
1743 2019-06-27  Tom Tromey  <tromey@adacore.com>
1744
1745         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1746         objfile_key.
1747         (arm_find_mapping_symbol, arm_record_special_symbol)
1748         (_initialize_arm_tdep): Update.
1749         (arm_objfile_data_free): Remove.
1750
1751 2019-06-27  Tom Tromey  <tromey@adacore.com>
1752
1753         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1754         to cp_print_static_field.
1755
1756 2019-06-26  Tom Tromey  <tromey@adacore.com>
1757
1758         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1759         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1760         declare.
1761
1762 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1763
1764         * features/aarch64-core.c (create_feature_aarch64_core):
1765         Regenerate.
1766         * features/aarch64-core.xml: Add cpsr flags.
1767
1768 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1769
1770         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1771         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1772
1773 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1774
1775         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1776         field.
1777         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1778         use.
1779         (arm_record_special_symbol): Don't insert new symbol in sorted
1780         position, push it at the end.
1781
1782 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1783
1784         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1785         (arm_mapping_symbol_s): Remove.
1786         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1787         (arm_mapping_symbol_vec): New typedef.
1788         (struct arm_per_objfile): Add constructor.
1789         <section_maps>: Change type to
1790         std::unique_ptr<arm_mapping_symbol_vec[]>.
1791         (arm_compare_mapping_symbols): Remove.
1792         (arm_find_mapping_symbol): Adjust to section_maps type change.
1793         (arm_objfile_data_free): Call delete on arm_per_objfile.
1794         (arm_record_special_symbol): Adjust to section_maps type change.
1795         Allocate arm_per_objfile with new.
1796
1797 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1798
1799         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1800         with the command prefix.
1801
1802 2019-06-25  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1805         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1806
1807 2019-06-25  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1810         type.
1811         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1812         protected.
1813
1814 2019-06-25  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-winsource.c
1817         (tui_source_window_base::set_is_exec_point_at): Add check against
1818         LOA_ADDRESS.
1819
1820 2019-06-25  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-source.c (tui_set_source_content): Don't check before
1823         xfree.
1824         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1825
1826 2019-06-25  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-winsource.h (tui_update_source_window_as_is)
1829         (tui_alloc_source_buffer, tui_line_is_displayed)
1830         (tui_addr_is_displayed): Change type of win_info.
1831         * tui/tui-winsource.c (tui_update_source_window_as_is)
1832         (tui_clear_source_content, tui_show_source_line)
1833         (tui_show_source_content, tui_source_window_base::refill)
1834         (tui_source_window_base::set_is_exec_point_at)
1835         (tui_source_window_base::set_is_exec_point_at)
1836         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1837         (tui_alloc_source_buffer, tui_line_is_displayed)
1838         (tui_addr_is_displayed): Change type of win_info.  Update.
1839         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1840         (tui_source_window_base::do_make_visible_with_new_height):
1841         Update.
1842         * tui/tui-source.c (tui_set_source_content)
1843         (tui_set_source_content_nil)
1844         (tui_source_window::do_scroll_vertical): Update.
1845         * tui/tui-layout.c (show_layout): Update.
1846         * tui/tui-disasm.c (tui_set_disassem_content)
1847         (tui_disasm_window::do_scroll_vertical): Update.
1848         * tui/tui-data.h (tui_win_content): Remove.
1849         (struct tui_gen_win_info) <content, content_size>: Remove.
1850         (struct tui_source_element): Add initializers and destructor.
1851         (union tui_which_element, struct tui_win_element): Remove.
1852         (struct tui_source_window_base) <content>: New field.
1853         (struct tui_data_window): Remove destructor.
1854         (tui_alloc_content, tui_free_win_content)
1855         (tui_free_all_source_wins_content): Don't declare.
1856         * tui/tui-data.c (tui_initialize_static_data): Update.
1857         (init_content_element, tui_alloc_content): Remove.
1858         (~tui_gen_win_info): Update.
1859         (~tui_data_window, tui_free_all_source_wins_content)
1860         (tui_free_win_content, free_content, free_content_elements):
1861         Remove.
1862
1863 2019-06-25  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-winsource.h (tui_clear_source_content)
1866         (tui_erase_source_content, tui_show_source_content): Change type
1867         of win_info.
1868         * tui/tui-winsource.c (tui_clear_source_content)
1869         (tui_erase_source_content, tui_show_source_content): Change type
1870         of win_info.
1871         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1872         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1873         win_info.
1874         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1875         win_info.
1876         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1877
1878 2019-06-25  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-winsource.c (tui_clear_source_content)
1881         (tui_source_window_base::set_is_exec_point_at): Update.
1882         * tui/tui-source.c (tui_set_source_content_nil): Update.
1883         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1884         a bool.
1885         * tui/tui-data.c (init_content_element): Update.
1886
1887 2019-06-25  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1890         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1891         * tui/tui-layout.c (init_and_make_win): Update.
1892         * tui/tui.h (enum tui_win_type): Update.
1893         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1894         tui_win_is_auxillary.
1895         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1896         tui_win_is_auxillary.
1897
1898 2019-06-25  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1901         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1902         (tui_delete_data_content_windows, tui_display_all_data)
1903         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1904         Update.
1905         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1906         * tui/tui-regs.c (tui_last_regs_line_no)
1907         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1908         (tui_show_registers): Update.
1909         (tui_show_register_group): Return void.  Update.
1910         (tui_display_registers_from, tui_display_reg_element_at_line)
1911         (tui_display_registers_from_line, tui_check_register_values):
1912         Update.
1913         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1914         member.
1915         (struct tui_data_window) <regs_content>: Now a std::vector.
1916         <regs_content_count>: Remove.
1917         (tui_add_content_elements, tui_free_data_content): Don't declare.
1918         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1919         (init_content_element): Remove DATA_WIN case.  Add assert.
1920         (tui_add_content_elements): Remove.
1921         (tui_data_window): Update.
1922         (tui_free_data_content): Remove.
1923         (free_content_elements): Remove DATA_WIN case.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-data.c (tui_data_item_window): Update.
1928         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1929         * tui/tui-windata.c (tui_display_all_data)
1930         (tui_display_data_from_line): Update.
1931         (tui_check_data_values): Remove.
1932         * tui/tui-regs.c (tui_show_register_group)
1933         (tui_display_reg_element_at_line): Update.
1934         * tui/tui-hooks.c (tui_register_changed)
1935         (tui_refresh_frame_and_register_information): Call
1936         tui_check_register_values.
1937         * tui/tui-data.h (struct tui_data_window) <data_content,
1938         data_content_count, data_type>: Remove.
1939         (enum tui_data_type): Remove.
1940
1941         * tui/tui-data.c (tui_data_window::clear_detail)
1942         (~tui_data_window): Update.
1943
1944 2019-06-25  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1947         declare.
1948         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1949         Rename from tui_first_data_item_displayed.  Update.
1950         (tui_data_window::refresh_all)
1951         (tui_data_window::do_scroll_vertical): Update.
1952         * tui/tui-data.h (struct tui_data_window)
1953         <first_data_item_displayed>: Declare new method.
1954
1955 2019-06-25  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1958         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1959         contents...
1960         (tui_initialize_static_data): ...here.
1961
1962 2019-06-25  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1965         (tui_display_registers_from, tui_check_register_values): Update.
1966         (tui_display_register): Remove win_info parameter; update.
1967         (tui_get_register): Change type of parameters.
1968         * tui/tui-data.h (struct tui_data_element): Remove.
1969         (union tui_which_element) <data>: Remove.
1970         <data_window>: Change type.
1971         (struct tui_data_item_window): New.
1972         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1973         case.  Add assert.
1974         (~tui_data_item_window): New destructor.
1975         (free_content_elements): Remove DATA_ITEM_WIN case.
1976
1977 2019-06-25  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1980         Remove.
1981
1982 2019-06-25  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-data.h (struct tui_command_element): Remove.
1985         (union tui_which_element) <command>: Remove.
1986         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1987         assert.
1988         (free_content_elements): Remove CMD_WIN case.
1989
1990 2019-06-25  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-layout.c (tui_set_layout): Update.
1993         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1994         * tui/tui-data.c (layout_def): Update.
1995
1996 2019-06-25  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1999         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2000         (tui_source_window_base::set_new_height): Update.
2001         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2002         Update.
2003         (tui_set_locator_fullname, tui_set_locator_info)
2004         (tui_show_frame_info): Update.
2005         * tui/tui-source.c (tui_set_source_content)
2006         (tui_source_is_displayed): Update.
2007         * tui/tui-layout.c (show_source_disasm_command, show_data)
2008         (show_source_or_disasm_and_command): Update.
2009         * tui/tui-disasm.c (tui_set_disassem_content)
2010         (tui_get_begin_asm_address): Update.
2011         * tui/tui-data.h (struct tui_locator_element): Remove.
2012         (union tui_which_element) <locator>: Remove.
2013         (struct tui_locator_window): New.
2014         (tui_locator_win_info_ptr): Change return type.
2015         * tui/tui-data.c (_locator): Change type.
2016         (tui_locator_win_info_ptr): Change return type.
2017         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2018         (tui_alloc_content): Add assert.
2019
2020 2019-06-25  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-winsource.c
2023         (tui_exec_info_window::maybe_allocate_content): New method.
2024         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2025         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2026         (make_source_or_disasm_window): Add cast.
2027         * tui/tui-data.h (union tui_which_element) <simple_string>:
2028         Remove.
2029         (struct tui_source_info): New.
2030         (struct tui_source_window_base) <execution_info>: Change type.
2031         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2032         case, and add assert.
2033         (tui_alloc_content): Add assert.
2034
2035 2019-06-25  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2038         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2039         * tui/tui-data.c (tui_alloc_win_info): Remove.
2040
2041 2019-06-25  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2044         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2045         can_highlight.
2046
2047 2019-06-25  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2050         make_visible_with_new_height method.
2051         (tui_win_info::make_visible_with_new_height): New method.
2052         (tui_source_window_base::do_make_visible_with_new_height)
2053         (tui_data_window::do_make_visible_with_new_height)
2054         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2055         (make_visible_with_new_height): Remove.
2056         (tui_resize_all, tui_adjust_win_heights): Use
2057         make_visible_with_new_height method.
2058         * tui/tui-data.h (struct tui_win_info)
2059         <do_make_visible_with_new_height, make_visible_with_new_height>:
2060         New methods.
2061         (struct tui_source_window_base, struct tui_data_window)
2062         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2063         methods.
2064
2065 2019-06-25  Tom Tromey  <tom@tromey.com>
2066
2067         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2068         method.
2069         (update_tab_width): Call update_tab_width method.
2070         * tui/tui-data.h (struct tui_win_info)
2071         (struct tui_source_window_base) <update_tab_width>: New methods.
2072
2073 2019-06-25  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2076         parameter.
2077         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2078         parameter.
2079         (tui_gen_win_info::make_visible): Update.
2080         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2081         parameter.
2082         * tui/tui-data.h (enum tui_box): New enum.
2083         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2088         init_and_make_win for EXEC_INFO_WIN.
2089         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2090         longer inline.
2091         (struct tui_win_info) <~tui_win_info>: Inline.
2092         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2093         Don't declare.
2094         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2095         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2096         Remove.
2097         (tui_initialize_static_data): Update.
2098         (~tui_gen_win_info): Handle more cleanup here.
2099         (~tui_source_window_base): Delete "execution_info".
2100         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-layout.c (make_command_window): Don't set
2105         can_highlight.
2106         (show_source_disasm_command): Call the reset method.
2107         (show_data): Don't set can_highlight.  Call the reset method.
2108         (tui_gen_win_info::reset): Rename from init_gen_win_info
2109         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2110         (show_source_or_disasm_and_command): Call the reset method.
2111         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2112         (struct tui_cmd_window): Set can_highlight.
2113
2114 2019-06-25  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2117         from make_visible.
2118         (tui_make_visible, tui_make_invisible): Rewrite.
2119         (tui_win_info::make_visible): Remove.
2120         (tui_source_window_base::make_visible): Update.
2121         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2122         method.  Moved from...
2123         (struct tui_win_info) <make_visible>: ...here.
2124
2125 2019-06-25  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-winsource.c
2128         (tui_source_window_base::do_scroll_horizontal): Remove direction
2129         parameter.
2130         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2131         direction parameter.
2132         * tui/tui-win.c (tui_win_info::forward_scroll)
2133         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2134         (tui_win_info::right_scroll): Update.
2135         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2136         direction parameter.
2137         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2138         direction parameter.
2139         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2140         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2141         Remove direction parameter.
2142         (struct tui_source_window_base, struct tui_source_window)
2143         (struct tui_disasm_window, struct tui_data_window)
2144         (struct tui_cmd_window): Update.
2145
2146 2019-06-25  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-winsource.h (tui_set_exec_info_content)
2149         (tui_show_exec_info_content, tui_erase_exec_info_content)
2150         (tui_clear_exec_info_content, tui_update_exec_info): Change
2151         argument to tui_source_window_base.
2152         * tui/tui-winsource.c (tui_set_exec_info_content)
2153         (tui_show_exec_info_content, tui_erase_exec_info_content)
2154         (tui_clear_exec_info_content, tui_update_exec_info): Change
2155         argument to tui_source_window_base.
2156
2157 2019-06-25  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2160         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2161
2162 2019-06-25  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2165         check.
2166
2167 2019-06-25  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2170         type to void.
2171         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2172         type to void.
2173         * tui/tui-source.c (tui_set_source_content): Update.
2174         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2175
2176 2019-06-25  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-win.c (window_name_completer, tui_set_focus)
2179         (tui_all_windows_info): Use name method.
2180         * tui/tui-data.h (struct tui_gen_win_info)
2181         (struct tui_source_window, struct tui_disasm_window)
2182         (struct tui_data_window, struct tui_cmd_window) <name>: New
2183         method.
2184         (tui_win_name): Don't declare.
2185         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2186         (tui_win_name): Remove.
2187
2188 2019-06-25  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui-winsource.h (tui_update_source_window)
2191         (tui_update_source_window_as_is): Change parameter type.
2192         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2193         to be a tui_source_window_base.
2194         (tui_update_source_window_as_is): Likewise.
2195         * tui/tui-win.c (make_visible_with_new_height): Update.
2196
2197 2019-06-25  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-winsource.c (tui_erase_source_content)
2200         (tui_show_source_content, tui_show_exec_info_content)
2201         (tui_erase_exec_info_content): Use refresh_window method.
2202         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2203         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2204         from tui_refresh_win.
2205         (tui_data_window::refresh_window): New method.
2206         (tui_win_info::refresh, tui_source_window_base::refresh)
2207         (tui_refresh_all): Use refresh_window method.
2208         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2209         method.
2210         * tui/tui-regs.c (tui_display_register): Call refresh_window
2211         method.
2212         * tui/tui-layout.c (show_source_disasm_command)
2213         (show_source_or_disasm_and_command): Call refresh_window method.
2214         * tui/tui-data.h (struct tui_gen_win_info)
2215         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2216         New method.
2217
2218 2019-06-25  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui.c (tui_rl_other_window, tui_enable)
2221         (tui_is_window_visible, tui_get_command_dimension): Update.
2222         * tui/tui-winsource.c (tui_update_source_window_as_is)
2223         (tui_clear_source_content, tui_erase_source_content)
2224         (tui_show_source_line, tui_source_window_base::refill)
2225         (tui_source_window_base::do_scroll_horizontal)
2226         (tui_source_window_base::set_is_exec_point_at)
2227         (tui_update_breakpoint_info, tui_set_exec_info_content)
2228         (tui_alloc_source_buffer, tui_line_is_displayed)
2229         (tui_addr_is_displayed): Update.
2230         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2231         (tui_check_and_display_highlight_if_needed)
2232         (tui_win_info::make_visible, tui_win_info::refresh)
2233         (tui_refresh_all): Update.
2234         * tui/tui-windata.c (tui_first_data_item_displayed)
2235         (tui_delete_data_content_windows, tui_erase_data_content)
2236         (tui_display_all_data, tui_data_window::refresh_all)
2237         (tui_check_data_values): Update.
2238         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2239         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2240         (tui_win_info::backward_scroll, tui_refresh_all_win)
2241         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2242         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2243         (tui_source_window_base::set_new_height)
2244         (tui_data_window::set_new_height)
2245         (make_invisible_and_set_new_height)
2246         (make_visible_with_new_height, new_height_ok)
2247         (parse_scrolling_args): Update.
2248         * tui/tui-stack.c (tui_show_frame_info): Update.
2249         * tui/tui-source.c (tui_set_source_content)
2250         (tui_set_source_content_nil, tui_source_is_displayed)
2251         (tui_source_window::do_scroll_vertical): Update.
2252         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2253         (tui_display_registers_from, tui_display_reg_element_at_line)
2254         (tui_check_register_values, tui_reg_command): Update.
2255         * tui/tui-layout.c (tui_default_win_height)
2256         (show_source_disasm_command, show_data, init_and_make_win)
2257         (show_source_or_disasm_and_command): Update.
2258         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2259         (tui_redisplay_readline, tui_mld_flush)
2260         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2261         (tui_getc): Update.
2262         * tui/tui-disasm.c (tui_set_disassem_content)
2263         (tui_disasm_window::do_scroll_vertical): Update.
2264         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2265         Now virtual.
2266         (struct tui_win_info): Derive from tui_gen_win_info.
2267         <~tui_win_info>: Mark as override.
2268         <generic>: Remove member.
2269         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2270         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2271         (~tui_data_window, ~tui_win_info)
2272         (tui_free_all_source_wins_content): Update.
2273         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2274
2275 2019-06-25  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-layout.c (init_and_make_win): Use new.
2278         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2279         destructor, initializers.
2280         (tui_alloc_generic_win_info): Don't declare.
2281         * tui/tui-data.c (_locator): Add argument to constructor.
2282         (source_win, disasm_win): New globals.
2283         (exec_info): Remove.
2284         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2285         Update.
2286         (tui_alloc_generic_win_info): Remove.
2287         (init_content_element): Use new.
2288         (tui_win_info::tui_win_info): Update.
2289         (free_content_elements) <case DATA_WIN>: Use delete.
2290
2291 2019-06-25  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2294         * tui/tui-windata.c (tui_first_data_item_displayed)
2295         (tui_delete_data_content_windows): Update.
2296         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2297         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2298         (tui_display_registers_from, tui_check_register_values): Update.
2299         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2300         pointer.
2301         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2302         window.
2303         (tui_free_data_content): Update.
2304         (free_content_elements) <case DATA_WIN>: Free the window.
2305
2306 2019-06-25  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2309         Update.
2310         * tui/tui-layout.c (make_command_window)
2311         (show_source_disasm_command, show_data, init_and_make_win)
2312         (show_source_or_disasm_and_command): Update.
2313         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2314         method.
2315         <can_highight, is_highlighted>: Now bool.
2316         (tui_set_win_highlight): Don't declare.
2317         * tui/tui-data.c (tui_set_win_highlight): Remove.
2318
2319 2019-06-25  Tom Tromey  <tom@tromey.com>
2320
2321         * tui/tui-wingeneral.c (make_visible): Remove check of window
2322         type.
2323
2324 2019-06-25  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-win.c (tui_win_info::max_height)
2327         (tui_cmd_window::max_height): New methods.
2328         (new_height_ok): Call max_height.
2329         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2330         <max_height>: New method.
2331
2332 2019-06-25  Tom Tromey  <tom@tromey.com>
2333
2334         * tui/tui-win.c (tui_source_window_base::set_new_height)
2335         (tui_data_window::set_new_height): New methods.
2336         (make_invisible_and_set_new_height): Call set_new_height method.
2337         * tui/tui-data.h (struct tui_win_info)
2338         (struct tui_source_window_base, struct tui_data_window)
2339         <set_new_height>: New method.
2340
2341 2019-06-25  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2344         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2345         tui_refresh_data_win.
2346         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2347         method.
2348         (tui_refresh_all_win): Call the refresh_all method.
2349         (tui_set_focus): Likewise.
2350         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2351         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2352         Likewise.
2353
2354 2019-06-25  Tom Tromey  <tom@tromey.com>
2355
2356         * tui/tui-winsource.h (tui_refill_source_window)
2357         (tui_set_is_exec_point_at): Don't declare.
2358         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2359         (tui_source_window_base::refill): Rename from
2360         tui_refill_source_window.
2361         (tui_source_window_base::do_scroll_horizontal): Update.
2362         (tui_source_window_base::set_is_exec_point_at): Rename from
2363         tui_set_is_exec_point_at.
2364         (tui_update_all_breakpoint_info): Update.
2365         * tui/tui-stack.c (tui_show_frame_info): Update.
2366         * tui/tui-layout.c (show_data): Add cast.
2367         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2368         * tui/tui-data.h (struct tui_source_window_base) <refill,
2369         set_is_exec_point_at>: New methods.
2370         (tui_source_windows, tui_add_to_source_windows): Update types.
2371         (tui_add_to_source_windows): Remove redundant declaration.
2372         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2373         (tui_source_windows): Change return type.
2374         (tui_clear_source_windows_detail): Update.
2375         (tui_add_to_source_windows): Change type of parameter.
2376         (tui_free_all_source_wins_content): Update.
2377
2378 2019-06-25  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui-wingeneral.c (tui_win_info::refresh)
2381         (tui_source_window_base::refresh): New methods.
2382         (tui_refresh_all): Call the refresh method.
2383         * tui/tui-data.h (struct tui_win_info)
2384         (struct tui_source_window_base) <refresh>: New method.
2385
2386 2019-06-25  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui.h (tui_is_window_visible): Return bool.
2389         * tui/tui.c (tui_is_window_visible): Return bool.
2390         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2391         (tui_make_visible, tui_make_invisible)
2392         (tui_win_info::make_visible)
2393         (tui_source_window_base::make_visible, make_all_visible)
2394         (tui_make_all_visible, tui_make_all_invisible): Update.
2395         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2396         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2397         bool.
2398         (struct tui_win_info, struct tui_source_window_base)
2399         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2400         * tui/tui-data.c (tui_init_generic_part): Update.
2401
2402 2019-06-25  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2405         (tui_source_window_base::make_visible): New methods.
2406         (make_all_visible): Make method call.
2407         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2408         (struct tui_source_window_base, struct tui_cmd_window): Override
2409         make_visible.
2410         (tui_win_is_source_type): Don't declare.
2411         * tui/tui-data.c (tui_win_is_source_type): Remove.
2412
2413 2019-06-25  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2416         NULL check.
2417
2418 2019-06-25  Tom Tromey  <tom@tromey.com>
2419
2420         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2421         Inline constructor.  Add initializers for members.
2422         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2423         constructors; now inline in class.
2424
2425 2019-06-25  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-regs.c (tui_show_registers): Update.
2428         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2429         bool.
2430         * tui/tui-data.c (tui_data_window::clear_detail)
2431         (tui_data_window): Update.
2432
2433 2019-06-25  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-windata.c (tui_display_all_data)
2436         (tui_display_data_from_line, tui_display_data_from)
2437         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2438         Update.
2439         * tui/tui-regs.c (tui_last_regs_line_no)
2440         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2441         (tui_show_registers, tui_show_register_group)
2442         (tui_display_registers_from, tui_display_reg_element_at_line)
2443         (tui_display_registers_from_line, tui_check_register_values)
2444         (tui_reg_next, tui_reg_prev): Update.
2445         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2446         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2447         tui_data_window.
2448         (struct tui_win_info) <detail>: Remove.  Add new fields from
2449         tui_data_info.
2450         (TUI_DATA_WIN): Add cast.
2451         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2452         (~tui_data_window): Simplify.
2453
2454 2019-06-25  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-layout.c (show_source_disasm_command)
2457         (show_source_or_disasm_and_command): Update.
2458         * tui/tui-io.c (update_cmdwin_start_line)
2459         (tui_redisplay_readline): Update.
2460         * tui/tui-data.h (struct tui_command_info): Remove.
2461         (struct tui_win_info) <detail>: Remove command_info member.
2462         (struct tui_data_window) <start_line>: New member, from
2463         tui_command_info.
2464         (TUI_CMD_WIN): Add casts.
2465
2466 2019-06-25  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-winsource.c (tui_update_source_window)
2469         (tui_refill_source_window)
2470         (tui_source_window_base::do_scroll_horizontal)
2471         (tui_update_breakpoint_info, tui_set_exec_info_content)
2472         (tui_show_exec_info_content, tui_erase_exec_info_content)
2473         (tui_clear_exec_info_content): Update.
2474         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2475         Update.
2476         * tui/tui-win.c (make_invisible_and_set_new_height)
2477         (make_visible_with_new_height): Update.
2478         * tui/tui-source.c (tui_set_source_content)
2479         (tui_show_symtab_source): Update.
2480         * tui/tui-layout.c (extract_display_start_addr)
2481         (show_source_disasm_command, show_data)
2482         (make_source_or_disasm_window)
2483         (show_source_or_disasm_and_command): Update.
2484         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2485         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2486         "gdbarch".
2487         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2488         to tui_source_window_base.
2489         (struct tui_win_info) <detail>: Remove source_info member.
2490         (struct tui_source_window_base) <has_locator>: Inline.
2491         Move contents from tui_source_info; rename has_locator member to
2492         m_has_locator.
2493         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2494         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2495         header file.
2496         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2497         Simplify.
2498         (tui_free_all_source_wins_content): Cast to
2499         tui_source_window_base.
2500
2501 2019-06-25  Tom Tromey  <tom@tromey.com>
2502
2503         * tui/tui-win.c (make_invisible_and_set_new_height)
2504         (make_visible_with_new_height): Call has_locator method.
2505         * tui/tui-layout.c (show_source_disasm_command, show_data)
2506         (show_source_or_disasm_and_command): Update for bool change.
2507         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2508         (tui_win_info) <has_locator>: New method.
2509         (struct tui_source_window_base) <has_locator>: New method.
2510         (tui_win_has_locator): Don't declare.
2511         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2512         from tui_win_has_locator.
2513         (tui_source_window_base): Use false, not FALSE.
2514
2515 2019-06-25  Tom Tromey  <tom@tromey.com>
2516
2517         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2518         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2519         clear_detail method directly.
2520         (tui_clear_win_detail): Remove.
2521
2522 2019-06-25  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2525         "this", not TUI_DISASM_WIN.
2526
2527 2019-06-25  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2530         declare.
2531         * tui/tui-winsource.c
2532         (tui_source_window_base::do_scroll_horizontal): Rename from
2533         tui_horizontal_source_scroll.
2534         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2535         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2536         from tui_vertical_data_scroll.
2537         * tui/tui-win.h (tui_scroll): Don't declare.
2538         * tui/tui-win.c (tui_win_info::forward_scroll)
2539         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2540         (tui_win_info::right_scroll): Rename and update.
2541         (tui_scroll_forward_command, tui_scroll_backward_command)
2542         (tui_scroll_left_command, tui_scroll_right_command): Update.
2543         (tui_scroll): Remove.
2544         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2545         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2546         from tui_vertical_source_scroll.
2547         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2548         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2549         from tui_vertical_disassem_scroll.
2550         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2551         do_scroll_horizontal>: New methods.
2552         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2553         Likewise.
2554         (struct tui_source_window_base): Add do_scroll_horizontal.
2555         (struct tui_source_window, struct tui_disasm_window): Add
2556         do_scroll_vertical.
2557         (struct tui_data_window, struct tui_cmd_window): Add
2558         do_scroll_horizontal and do_scroll_vertical.
2559         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2560
2561 2019-06-25  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-data.h (struct tui_source_window_base): New struct.
2564         (struct tui_source_window): Derive from tui_source_window_base.
2565         (struct tui_disasm_window): New struct.
2566         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2567         from tui_source_window::clear_detail.
2568         (tui_source_window_base): Rename from tui_source_window.
2569         (~tui_source_window_base): Rename from ~tui_source_window.
2570         (tui_alloc_win_info): Create a tui_disasm_window.
2571
2572 2019-06-25  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-data.h (struct tui_source_window)
2575         (struct tui_data_window): Declare destructors.
2576         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2577         destructors.
2578         (tui_win_info): Simplify.
2579
2580 2019-06-25  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-winsource.c (tui_display_main)
2583         (tui_update_source_windows_with_addr)
2584         (tui_update_all_breakpoint_info): Update.
2585         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2586         (new_height_ok, parse_scrolling_args): Update.
2587         * tui/tui-stack.c (tui_show_frame_info): Update.
2588         * tui/tui-data.h (struct tui_list): Remove.
2589         (tui_source_windows): Return a reference to a std::vector.
2590         * tui/tui-data.c (source_windows): Now a std::vector.
2591         (tui_source_windows): Change return type.
2592         (tui_clear_source_windows): Rewrite.
2593         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2594         (tui_free_all_source_wins_content): Rewrite.
2595
2596 2019-06-25  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2599         (struct tui_data_window, struct tui_cmd_window): Declare
2600         clear_detail method.
2601         * tui/tui-data.c (tui_source_window::clear_detail)
2602         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2603         methods.
2604         (tui_clear_win_detail): Simplify.
2605
2606 2019-06-25  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-layout.c (make_source_window, make_disasm_window)
2609         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2610         Return the new window.
2611         (show_source_disasm_command, show_data)
2612         (show_source_or_disasm_and_command): Update.
2613
2614 2019-06-25  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2617         parameter.  Return the new window.
2618         (show_source_disasm_command): Update and remove NULL check.
2619         (show_source_or_disasm_and_command): Update.
2620
2621 2019-06-25  Tom Tromey  <tom@tromey.com>
2622
2623         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2624
2625 2019-06-25  Tom Tromey  <tom@tromey.com>
2626
2627         * tui/tui-data.h (struct tui_win_info): Make constructor
2628         protected.  Make destructor virtual.  Add initializers.
2629         (tui_source_window, tui_data_window, tui_cmd_window): New
2630         classes.
2631         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2632         constructor.  Add "type" parameter.
2633         (tui_source_window, tui_data_window, tui_cmd_window): New
2634         constructors.
2635         (tui_alloc_win_info): Instantiate the appropriate subclass.
2636
2637 2019-06-25  Tom Tromey  <tom@tromey.com>
2638
2639         * tui/tui-win.c (tui_resize_all): Use delete.
2640         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2641         destructor.
2642         (tui_free_window): Don't declare.
2643         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2644         Update.
2645
2646 2019-06-25  Tom Tromey  <tom@tromey.com>
2647
2648         * tui/tui-data.h (struct tui_win_info): Add constructor.
2649         * tui/tui-data.c (tui_alloc_win_info): Use new.
2650         (tui_free_window): Use delete.
2651
2652 2019-06-22  Tom Tromey  <tom@tromey.com>
2653
2654         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2655         declare.
2656         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2657
2658 2019-06-22  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2661         declare.
2662         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2663
2664 2019-06-22  Tom de Vries  <tdevries@suse.de>
2665
2666         * dwarf2read.c (create_addrmap_from_aranges)
2667         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2668         instead of '%zu'.
2669
2670 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2671
2672         * dwarf2read.h (dwarf2_section_info_def): Remove.
2673         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2674         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2675         std::vector<dwarf2_section_info>.
2676         (struct dwo_file) <~dwo_file>: Remove.
2677         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2678         types field.
2679         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2680         (dwarf2_read_debug_names): Likewise.
2681         (create_debug_types_hash_table): Change parameter type to
2682         array_view, adjust code accordingly.
2683         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2684         (partial_die_info::fixup): Likewise.
2685         (determine_prefix): Likewise.
2686         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2687
2688 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2689
2690         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2691         gdb_bfd_ref_ptr.
2692         <~dwo_file>: Remove call to gdb_bfd_unref.
2693         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2694         gdb_bfd_ref_ptr::get.
2695
2696 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2697
2698         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2699         type to htab_up.
2700         * dwarf2read.c (struct dwo_file): Initialize fields.
2701         <~dwo_file>: New.
2702         (free_dwo_file): Remove, move content to ~dwo_file.
2703         (struct dwo_file_deleter): Remove.
2704         (dwo_file_up>: Remove custom deleter.
2705         (free_dwo_files): Remove.
2706         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2707         dwo_files.
2708         (process_skeletonless_type_units): Call unique_ptr::get.
2709         (allocate_dwo_file_hash_table): Add deleter to created hash
2710         table.  Change return type to htab_up.
2711         (lookup_dwo_file_slot): Don't memset dwo_file, call
2712         unique_ptr::get.
2713         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2714         (create_dwo_unit_in_dwp_v2): Likewise.
2715         (open_and_init_dwo_file): Likewise.
2716         (free_dwo_file_from_slot): Remove.
2717
2718 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2719
2720         * dwarf2read.h (struct dwarf2_section_info) <readin,
2721         is_virtual>: Change type to bool.
2722         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2723         true instead of 1.
2724
2725 2019-06-19  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-data.h (tui_init_content_element): Don't declare.
2728
2729 2019-06-19  Tom Tromey  <tom@tromey.com>
2730
2731         * tui/tui-data.h (tui_init_win_info): Don't declare.
2732
2733 2019-06-19  Tom de Vries  <tdevries@suse.de>
2734
2735         * dwarf2read.h (abstract_to_concrete): Change type to
2736         std::unordered_map<sect_offset, std::vector<sect_offset>,
2737         gdb::hash_enum<sect_offset>>.
2738
2739 2019-06-19  Tom Tromey  <tromey@adacore.com>
2740
2741         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2742         EVAL_AVOID_SIDE_EFFECTS specially.
2743
2744 2019-06-19  Tom Tromey  <tromey@adacore.com>
2745
2746         * source-cache.c (highlighter): New global.
2747         (source_cache::get_source_lines): Create a highlighter on demand.
2748
2749 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * defs.h (deprecated_interactive_hook): Delete declaration.
2752         * interps.c (clear_interpreter_hooks): Remove use of
2753         deprecated_interactive_hook.
2754         * top.c (deprecated_interactive_hook): Delete definition.
2755         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2756
2757 2019-06-18  Tom de Vries  <tdevries@suse.de>
2758
2759         PR gdb/24515
2760         * dwarf2read.h (abstract_to_concrete): Change type from
2761         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2762         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2763         * dwarf2read.c (read_variable): Update.
2764         (dwarf2_fetch_die_loc_sect_off): Update.
2765
2766 2019-06-17  Tom de Vries  <tdevries@suse.de>
2767
2768         PR gdb/24617
2769         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2770         accessing parent[parent_len - 1].
2771
2772 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2773
2774         PR gdb/24364
2775         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2776         call dtrace_process_dof with NULL dof.
2777
2778 2019-06-16  Tom de Vries  <tdevries@suse.de>
2779
2780         PR gdb/24445
2781         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2782
2783 2019-06-16  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2786         (make_all_visible): Use address of member.
2787
2788 2019-06-16  Tom Tromey  <tom@tromey.com>
2789
2790         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2791         (tui_free_window, free_content, free_content_elements): Remove
2792         unnecessary cast.
2793         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2794         cast.
2795         * tui/tui-regs.c (tui_show_register_group)
2796         (tui_display_registers_from, tui_display_reg_element_at_line):
2797         Remove unnecessary cast.
2798
2799 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2800
2801         * linux-nat.c (normal_mask): Delete.
2802         (_initialize_linux_nat): Don't initialise normal_mask.
2803
2804 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2805
2806         PR gdb/24445
2807         * dwarf-index-write.h (write_psymtabs_to_index): Add
2808         dwz_basename parameter.
2809         * dwarf-index-write.c (write_gdbindex): Move file writing to
2810         write_gdbindex_1.  Change return type void.
2811         (assert_file_size): Move up, remove filename parameter.
2812         (write_gdbindex_1): New function.
2813         (write_debug_names): Change return type to void, call
2814         assert_file_size.
2815         (struct index_wip_file): New struct.
2816         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2817         file logic to index_wip_file.  Write index for dwz file if
2818         needed.
2819         (save_gdb_index_command): Pass basename of dwz file, if present.
2820         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2821         build-id of dwz file, if present.
2822         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2823         (dwarf2_get_dwz_file): Likewise.
2824         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2825         (dwarf2_get_dwz_file): Likewise.
2826
2827 2019-06-16  Tom Tromey  <tom@tromey.com>
2828
2829         * coffread.c (process_coff_symbol): Use xstrdup.
2830         * value.c (create_internalvar): Use xstrdup.
2831
2832 2019-06-16  Tom Tromey  <tom@tromey.com>
2833
2834         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2835         * breakpoint.c (stopin_command, stopat_command)
2836         (until_break_command, decode_location_default): Remove unnecessary
2837         cast.
2838         * utils.c (subset_compare): Remove unnecessary cast.
2839         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2840         cast.
2841         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2842         cast.
2843         * infcmd.c (path_command): Remove unnecessary cast.
2844         * coffread.c (decode_type): Remove unnecessary cast.
2845         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2846         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2847         * tui/tui-stack.c (tui_show_locator_content)
2848         (tui_show_frame_info): Remove unnecessary cast.
2849         * tui/tui-win.c (tui_scroll_forward_command)
2850         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2851         (parse_scrolling_args): Remove unnecessary cast.
2852         * tui/tui-data.c (init_win_info, tui_del_window)
2853         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2854         (free_content_elements): Remove unnecessary cast.
2855         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2856         unnecessary cast.
2857         * tui/tui-source.c (tui_set_source_content)
2858         (tui_vertical_source_scroll): Remove unnecessary cast.
2859         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2860         cast.
2861         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2862         * tui/tui-regs.c (tui_display_registers_from)
2863         (tui_display_register): Remove unnecessary cast.
2864         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2865         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2866         (make_visible): Remove unnecessary cast.
2867         * tui/tui-winsource.c (tui_erase_source_content)
2868         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2869         unnecessary cast.
2870         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2871         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2872         * stabsread.c (read_type, read_array_type, read_range_type):
2873         Remove unnecessary cast.
2874         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2875         (parse_symbol, parse_type, upgrade_type, parse_external)
2876         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2877         unnecessary cast.
2878         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2879
2880 2019-06-16  Tom Tromey  <tom@tromey.com>
2881
2882         * tui/tui-data.c (tui_alloc_generic_win_info)
2883         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2884         checks.
2885
2886 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2887             Andrew Burgess  <andrew.burgess@embecosm.com>
2888
2889         * f-typeprint.c (f_print_type): Don't return early for not
2890         associated or not allocated types.
2891         (f_type_print_varspec_suffix): Add print_rank parameter and print
2892         ranks of array types in case they dangling.
2893         (f_type_print_base): Add print_rank parameter.
2894
2895 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2896
2897         * NEWS: Mention new MI commands.
2898         * break-catch-throw.c (enum exception_event_kind): Move to
2899         breakpoint.h.
2900         (print_mention_exception_catchpoint): Output text as a single
2901         message.
2902         (catch_exception_command_1): Rename to...
2903         (catch_exception_event): ...this, make non-static, update header
2904         command, and change some parameter types.
2905         (catch_catch_command): Update for changes to
2906         catch_exception_command_1.
2907         (catch_throw_command): Likewise.
2908         (catch_rethrow_command): Likewise.
2909         * breakpoint.c (enum exception_event_kind): Delete.
2910         * breakpoint.h (enum exception_event_kind): Moved here from
2911         break-catch-throw.c.
2912         (catch_exception_event): Declare.
2913         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2914         (mi_cmd_catch_throw): New function.
2915         (mi_cmd_catch_rethrow): New function.
2916         (mi_cmd_catch_catch): New function.
2917         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2918         'catch-catch' entries.
2919         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2920         (mi_cmd_catch_rethrow): Declare.
2921         (mi_cmd_catch_catch): Declare.
2922
2923 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2924
2925         * annotate.c (annotate_source_line): Change return type to void,
2926         update implementation to match.
2927         * annotate.h (annotate_source_line): Change return type to void,
2928         update header comment.
2929         * stack.c (print_frame_info): Don't change what frame information
2930         is printed based on whether annotations are on or not.
2931
2932 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2933
2934         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2935         (annotate_source): Make static.
2936         (annotate_source_line): Moved from source.c and renamed from
2937         identify_source_line.  Update the return type.
2938         * annotate.h (annotate_source): Delete declaration.
2939         (annotate_source_line): Declaration moved from source.h, and
2940         renamed from identify_source_line.  Return type updated.
2941         * source.c (identify_source_line): Moved to annotate.c and renamed
2942         to annotate_source_line.
2943         (info_line_command): Remove check of annotation_level.
2944         * source.h (identify_source_line): Move declaration to annotate.h
2945         and rename to annotate_source_line.
2946         * stack.c: Add 'annotate.h' include.
2947         (print_frame_info): Remove check of annotation_level before
2948         calling annotate_source_line.
2949
2950 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2951
2952         * source-cache.c (source_cache::get_plain_source_lines): Use
2953         open_source_file_with_line_charpos instead of just
2954         open_source_file, remove call to find_source_lines.
2955         (source_cache::get_source_lines): Likewise.
2956         * source.c (find_source_lines): Make static.
2957         (get_filename_and_charpos): Renamed into...
2958         (open_source_file_with_line_charpos): ..this along with changes to
2959         return a scoped_fd, and some other minor clean ups.
2960         (identify_source_line): Use open_source_file_with_line_charpos.
2961         (search_command_helper): Use open_source_file_with_line_charpos
2962         instead of just open_source_file, remove call to
2963         find_source_lines.
2964         * source.h (open_source_file_with_line_charpos): Declare new
2965         function.
2966         (find_source_lines): Delete declaration.
2967
2968 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2969
2970         * source.c (get_filename_and_charpos): Remove fullname
2971         parameter.
2972         (identify_source_line): Update call to get_filename_and_charpos.
2973
2974 2019-06-14  Tom Tromey  <tromey@adacore.com>
2975
2976         PR gdb/24502:
2977         * ui-style.h (skip_ansi_escape): Update comment.
2978         * ui-file.h (class no_terminal_escape_file): New class.
2979         * ui-file.c (no_terminal_escape_file::write)
2980         (no_terminal_escape_file::puts): New methods.
2981         * cli/cli-logging.c (handle_redirections): Use
2982         no_terminal_escape_file.
2983
2984 2019-06-14  Tom Tromey  <tromey@adacore.com>
2985
2986         * NEWS: Move convenience variable news above Python news.
2987
2988 2019-06-14  Tom Tromey  <tom@tromey.com>
2989
2990         * gnulib: Move directory to top-level.
2991         * configure.ac: Don't configure gnulib.
2992         * configure: Rebuild.
2993         * common/common-defs.h: Use new path to gnulib.
2994         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2995         (GNULIB_H): Remove.
2996         (INCGNU): Look in new gnulib location.
2997         (HFILES_NO_SRCDIR): Remove gnulib files.
2998         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2999         (generated_files): Remove GNULIB_H.
3000         ($(LIBGNU), all-lib): Remove targets.
3001         (distclean): Don't mention GNULIB_BUILDDIR.
3002         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3003
3004 2019-06-14  Tom Tromey  <tromey@adacore.com>
3005
3006         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3007         Warn if symbol file does not provide any symbols.
3008
3009 2019-06-14  Tom Tromey  <tromey@adacore.com>
3010
3011         * source.c (find_and_open_source): Respect basenames_may_differ.
3012
3013 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3014
3015         * annotate.c (annotate_breakpoints_invalid): Make use of
3016         scoped_restore_terminal_state.
3017         (annotate_frames_invalid): Likewise.
3018
3019 2019-06-14  Tom Tromey  <tromey@adacore.com>
3020
3021         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3022         allow assignment to an internalvar.
3023
3024 2019-06-14  Tom Tromey  <tromey@adacore.com>
3025
3026         * ada-lex.l: Allow "_" in attribute names.
3027
3028 2019-06-14  Tom Tromey  <tromey@adacore.com>
3029
3030         PR gdb/24653:
3031         * regcache.c (registers_changed): Don't call alloca.
3032         * top.c (execute_command): Don't call alloca.
3033
3034 2019-06-13  Pedro Alves  <palves@redhat.com>
3035
3036         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3037         'expression'.  When parsing an expression, error out if there's
3038         junk after "unlimited".
3039         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3040         (do_set_command): Adjust calls to is_unlimited_literal.
3041
3042 2019-06-13  Pedro Alves  <palves@redhat.com>
3043
3044         * compile/compile.c (make_compile_options_def_group): Add braces
3045         around array_view initializer.
3046         * thread.c (make_thread_apply_all_options_def_group)
3047         (make_thread_apply_all_options_def_group): Likewise.
3048
3049 2019-06-13  Pedro Alves  <palves@redhat.com>
3050
3051         * NEWS (New commands): Mention "maint test-options
3052         require-delimiter", "maint test-options unknown-is-error", "maint
3053         test-options unknown-is-operand" and "maint show
3054         test-options-completion-result".
3055         (New command options, command completion): New section.
3056         (Completion improvements): New section.
3057         Mention that you can abbreviate "unlimited".
3058
3059 2019-06-13  Pedro Alves  <palves@redhat.com>
3060
3061         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3062         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3063         * unittests/cli-utils-selftests.c (test_parse_flags)
3064         (test_parse_flags_qcs): Delete.
3065         (test_cli_utils): Don't call deleted functions.
3066
3067 2019-06-13  Pedro Alves  <palves@redhat.com>
3068
3069         * thread.c: Include "cli/cli-option.h".
3070         (tp_array_compar_ascending): Global.
3071         (tp_array_compar): Delete function.
3072         (tp_array_compar_ascending, tp_array_compar_descending): New
3073         functions.
3074         (ascending_option_def, qcs_flag_option_def)
3075         (thr_qcs_flags_option_defs)
3076         (make_thread_apply_all_options_def_group)
3077         (make_thread_apply_options_def_group): New.
3078         (thread_apply_all_command): Use gdb::option::process_options.
3079         (thread_apply_command_completer)
3080         (thread_apply_all_command_completer): New.
3081         (thread_apply_command): Use gdb::option::process_options.
3082         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3083         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3084         to generate help text of "thread apply".  Adjust "taas"'s help.
3085         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3086         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3087
3088 2019-06-13  Pedro Alves  <palves@redhat.com>
3089
3090         * thread.c (thread_apply_command): Check for invalid TID with
3091         isdigit instead of !isalpha.
3092
3093 2019-06-13  Pedro Alves  <palves@redhat.com>
3094
3095         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3096         (validate_flags_qcs): New.
3097         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3098         (validate_flags_qcs): Declare.
3099         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3100         (make_frame_apply_options_def_group): New.
3101         (frame_apply_command_count): Process options with
3102         gdb::option::process_options.
3103         (frame_apply_completer): New.
3104         (frame_apply_level_completer, frame_apply_all_completer)
3105         (frame_apply_completer): New.
3106         (_initialize_stack): Update help of "frame apply", "frame apply
3107         level", "frame apply all" and "faas" to mention supported options
3108         and install command completers.
3109         * stack.h (frame_apply_all_completer): Declare.
3110         * thread.c: Include "stack.h".
3111         (tfaas_command): Add "--".
3112         (_initialize_thread): Update help "tfaas" to mention supported
3113         options and install command completer.
3114
3115 2019-06-13  Pedro Alves  <palves@redhat.com>
3116
3117         * completer.c (complete_nested_command_line): New.
3118         (gdb_completion_word_break_characters_throw): Add assertion.
3119         * completer.h (complete_nested_command_line): Declare.
3120
3121 2019-06-13  Pedro Alves  <palves@redhat.com>
3122
3123         * stack.c (parse_backtrace_qualifiers): New.
3124         (backtrace_command): Use it.
3125         (backtrace_command_completer): Complete on qualifiers.
3126
3127 2019-06-13  Pedro Alves  <palves@redhat.com>
3128
3129         * frame.c: Include "cli/cli-option.h.
3130         (user_set_backtrace_options): New.
3131         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3132         Delete.
3133         (get_prev_frame): Adjust.
3134         (boolean_option_def, uinteger_option_def)
3135         (set_backtrace_option_defs): New.
3136         (_initialize_frame): Adjust and use
3137         gdb::option::add_setshow_cmds_for_options to install "set
3138         backtrace past-main" and "set backtrace past-entry".
3139         * frame.h: Include "cli/cli-option.h".
3140         (struct frame_print_options): Forward declare.
3141         (print_frame_arguments_all, print_frame_arguments_scalars)
3142         (print_frame_arguments_none): Declare.
3143         (print_entry_values): Delete declaration.
3144         (struct frame_print_options, user_frame_print_options): New.
3145         (struct set_backtrace_options): New.
3146         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3147         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3148         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3149         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3150         (list_args_or_locals): Add frame_print_options parameter.
3151         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3152         * python/py-framefilter.c (enumerate_args): Pass down
3153         USER_FRAME_PRINT_OPTIONS.
3154         * stack.c: Include "cli/cli-option.h".
3155         (print_frame_arguments_all, print_frame_arguments_scalars)
3156         (print_frame_arguments_none): Declare.
3157         (print_raw_frame_arguments, print_entry_values): Delete.
3158         (user_frame_print_options): New.
3159         (boolean_option_def, enum_option_def, frame_print_option_defs):
3160         New.
3161         (struct backtrace_cmd_options): New.
3162         (bt_flag_option_def): New.
3163         (backtrace_command_option_defs): New.
3164         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3165         (print_frame_arg, read_frame_arg, print_frame_args)
3166         (print_frame_info, print_frame): Add frame_print_options parameter
3167         and use it.
3168         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3169         (backtrace_command_1): Add frame_print_options and
3170         backtrace_cmd_options parameters and use them.
3171         (make_backtrace_options_def_group): New.
3172         (backtrace_command): Process command options with
3173         gdb::option::process_options.
3174         (backtrace_command_completer): New.
3175         (_initialize_stack): Extend "backtrace"'s help to mention
3176         supported options.  Install completer for "backtrace".
3177         Install some settings commands with add_setshow_cmds_for_options.
3178
3179 2019-06-13  Pedro Alves  <palves@redhat.com>
3180
3181         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3182         and that "set/show print raw frame-arguments" are now deprecated.
3183
3184         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3185         command.
3186         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3187         * stack.c (_initialize_stack): Install "set/show print
3188         raw-frame-arguments", and deprecate "set/show print raw
3189         frame-arguments".
3190         * valprint.c (_initialize_valprint): Deprecate "set/show print
3191         raw".
3192
3193 2019-06-13  Pedro Alves  <palves@redhat.com>
3194
3195         * compile/compile.c (struct compile_options): New.
3196         (compile_flag_option_def, compile_command_option_defs)
3197         (make_compile_options_def_group): New.
3198         (compile_file_command): Handle options with
3199         gdb::option::process_options.
3200         (compile_file_command_completer): New function.
3201         (compile_code_command): Handle options with
3202         gdb::option::process_options.
3203         (compile_code_command_completer): New function.
3204         (_initialize_compiler): Install completers for "compile code" and
3205         "compile file".  Mention available options in "compile code" and
3206         "compile code"'s help.
3207         * completer.c (advance_to_completion_word): New, factored out from
3208         ...
3209         (advance_to_expression_complete_word_point): ... this.
3210         (advance_to_filename_complete_word_point): New.
3211         * completer.h (advance_to_filename_complete_word_point): New
3212         declaration.
3213
3214 2019-06-13  Pedro Alves  <palves@redhat.com>
3215
3216         * compile/compile.c: Include "cli/cli-option.h".
3217         (compile_print_value): Scope data pointer is now a
3218         value_print_options pointer; adjust.
3219         (compile_print_command): Process options.  Scope data pointer is
3220         now a value_print_options pointer; adjust.
3221         (_initialize_compile): Update "compile print"'s help to include
3222         supported options.  Install a completer for "compile print".
3223         * cp-valprint.c (show_vtblprint, show_objectprint)
3224         (show_static_field_print): Delete.
3225         (_initialize_cp_valprint): Don't install "set print
3226         static-members", "set print vtbl", "set print object" here.
3227         * printcmd.c: Include "cli/cli-option.h" and
3228         "common/gdb_optional.h".
3229         (print_command_parse_format): Rework to fill in a
3230         value_print_options instead of a format_data.
3231         (print_value): Change parameter type from format_data pointer to
3232         value_print_options reference.  Adjust.
3233         (print_command_1): Process options.  Adjust to pass down a
3234         value_print_options.
3235         (print_command_completer): New.
3236         (_initialize_printcmd): Install print_command_completer as
3237         handle_brkchars completer for the "print" command.  Update
3238         "print"'s help to include supported options.
3239         * valprint.c: Include "cli/cli-option.h".
3240         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3241         here from cp-valprint.c.
3242         (boolean_option_def, uinteger_option_def)
3243         (value_print_option_defs, make_value_print_options_def_group):
3244         New.  Use gdb::option::add_setshow_cmds_for_options to install
3245         "set print elements", "set print null-stop", "set print repeats",
3246         "set print pretty", "set print union", "set print array", "set
3247         print address", "set print symbol", "set print array-indexes".
3248         * valprint.h: Include <string> and "cli/cli-option.h".
3249         (make_value_print_options_def_group): Declare.
3250         (print_value): Change parameter type from format_data pointer to
3251         value_print_options reference.
3252         (print_command_completer): Declare.
3253
3254 2019-06-13  Pedro Alves  <palves@redhat.com>
3255
3256         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3257         (COMMON_SFILES): Add maint-test-settings.c.
3258         * cli/cli-decode.c (boolean_enums): New global, factored out from
3259         ...
3260         (add_setshow_boolean_cmd): ... here.
3261         * cli/cli-decode.h (boolean_enums): Declare.
3262         * cli/cli-option.c: New file.
3263         * cli/cli-option.h: New file.
3264         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3265         factored out from ...
3266         (parse_cli_boolean_value(const char *)): ... this.
3267         (is_unlimited_literal): Change parameter type to pointer to
3268         pointer.  Adjust and advance ARG pointer.
3269         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3270         (parse_cli_var_enum): New, factored out from ...
3271         (do_set_command): ... this.  Adjust.
3272         * cli/cli-setshow.h (parse_cli_boolean_value)
3273         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3274         (parse_cli_var_enum): Declare.
3275         * cli/cli-utils.c: Include "cli/cli-option.h".
3276         (get_ulongest): New.
3277         * cli/cli-utils.h (get_ulongest): Declare.
3278         (check_for_argument): New overloads.
3279         * maint-test-options.c: New file.
3280
3281 2019-06-13  Pedro Alves  <palves@redhat.com>
3282
3283         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3284         parse a range if "-" is at the end of the string.
3285
3286 2019-06-13  Pedro Alves  <palves@redhat.com>
3287
3288         * cli/cli-setshow.c (parse_auto_binary_operation)
3289         (parse_cli_boolean_value): Don't allow "o".
3290
3291 2019-06-13  Pedro Alves  <palves@redhat.com>
3292
3293         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3294         * NEWS: Mention maint test-settings KIND.
3295         * maint-test-settings.c: New file.
3296
3297 2019-06-13  Pedro Alves  <palves@redhat.com>
3298
3299         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3300         completer.
3301         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3302         "set" completers.
3303
3304 2019-06-13  Pedro Alves  <palves@redhat.com>
3305
3306         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3307         after item.
3308
3309 2019-06-13  Pedro Alves  <palves@redhat.com>
3310
3311         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3312
3313 2019-06-13  Pedro Alves <palves@redhat.com>
3314
3315         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3316         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3317         call.
3318         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3319         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3320         calls.
3321         (check_for_argument): Skip spaces after argument.
3322
3323 2019-06-13  Pedro Alves  <palves@redhat.com>
3324
3325         * thread.c (thread_apply_command): Adjust TID parsing.
3326         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3327         detected before end of string.
3328         (tid_is_in_list): Error out if LIST is invalid.
3329
3330 2019-06-13  Pedro Alves  <palves@redhat.com>
3331
3332         * completer.c (complete_line_internal_1): Rewind completion word
3333         point.
3334         (completion_tracker::advance_custom_word_point_by): Change
3335         parameter type to int.
3336         * completer.h (completion_tracker::advance_custom_word_point_by):
3337         Likewise.
3338
3339 2019-06-13  Pedro Alves  <palves@redhat.com>
3340
3341         * completer.c (advance_to_completion_word): Handle delimiters.
3342
3343 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3344
3345         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3346
3347 2019-06-11  Tom Tromey  <tom@tromey.com>
3348
3349         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3350         (xmalloc_failed): Move to alloc.c.
3351         * alloc.c: New file.
3352         * Makefile.in (COMMON_SFILES): Add alloc.c.
3353
3354 2019-06-11  Tom Tromey  <tom@tromey.com>
3355
3356         * nat/linux-waitpid.c: Don't include server.h.
3357         (linux_debug): Remove.
3358         (my_waitpid): Update.
3359
3360 2019-06-11  Tom Tromey  <tromey@adacore.com>
3361
3362         * infcall.c (_initialize_infcall): Remove trailing newline from
3363         help.
3364         * user-regs.c (_initialize_user_regs): Remove trailing newline
3365         from help.
3366         * typeprint.c (_initialize_typeprint): Remove trailing newline
3367         from help.
3368         * reverse.c (_initialize_reverse): Remove trailing newlines from
3369         help.
3370         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3371         from help.
3372         * language.c (add_set_language_command): Remove trailing newline
3373         from help.
3374         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3375         help.
3376         * disasm.c (_initialize_disasm): Remove trailing newline from
3377         help.
3378         * top.c (init_main): Remove trailing newline from help.
3379         * interps.c (_initialize_interpreter): Remove trailing newline
3380         from help.
3381         * btrace.c (_initialize_btrace): Remove trailing newlines from
3382         help.
3383         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3384         from help.
3385         * python/python.c (_initialize_python): Remove trailing newline
3386         from help.
3387         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3388         help.
3389         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3390         from help.  Reformat some text.
3391         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3392         from help.
3393         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3394         newline from help.
3395
3396 2019-06-11  Tom Tromey  <tromey@adacore.com>
3397
3398         * darwin-nat.c (darwin_decode_exception_message)
3399         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3400
3401 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3402
3403         * valops.c (value_slice): Check for not allocated or not
3404         associated values.
3405
3406 2019-06-10  Tom de Vries  <tdevries@suse.de>
3407
3408         PR gdb/24618
3409         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3410         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3411         invalid.
3412
3413 2019-06-10  Tom de Vries  <tdevries@suse.de>
3414
3415         PR gdb/24611
3416         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3417         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3418
3419 2019-06-10  Tom de Vries  <tdevries@suse.de>
3420
3421         PR symtab/24545
3422         * symtab.c (struct demangled_name_entry): Add language field.
3423         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3424         static minimal symbol".  Set and use language field.
3425
3426 2019-06-10  Tom Tromey  <tromey@adacore.com>
3427
3428         * ada-lang.c (_initialize_ada_language): Update help text.
3429
3430 2019-06-10  Tom Tromey  <tromey@adacore.com>
3431
3432         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3433         with a newline.
3434         * guile/guile.c (handle_boot_error): Don't end warning with a
3435         newline.
3436         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3437         warning with a newline.
3438         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3439         newline.
3440         (s12z_frame_cache): Likewise.
3441         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3442         a newline.
3443         * solib-svr4.c (disable_probes_interface): Don't end warning with
3444         a newline.
3445         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3446         newline.
3447         * python/python.c (do_finish_initialization): Don't end warning
3448         with a newline.
3449
3450 2019-06-10  Tom Tromey  <tom@tromey.com>
3451
3452         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3453         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3454         gdbpy_enter.
3455
3456 2019-06-10  Tom Tromey  <tromey@adacore.com>
3457
3458         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3459         data.
3460         (elf_new_init): Don't call stabsread_new_init.
3461         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3462         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3463         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3464
3465 2019-06-10  Tom de Vries  <tdevries@suse.de>
3466
3467         PR symtab/16264
3468         PR symtab/24517
3469         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3470
3471 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3472
3473         * source.c (find_and_open_source): Also rewrite relative file
3474         names.
3475
3476 2019-04-26  Amos Bird  <amosbird@gmail.com>
3477
3478         * annotate.c (annotate_thread_exited): Add "thread-exited"
3479         annotation.
3480
3481 2019-06-06  Tom Tromey  <tromey@adacore.com>
3482
3483         * maint.h (class scoped_command_stats): Use
3484         DISABLE_COPY_AND_ASSIGN.
3485         <print_time>: New method.
3486         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3487         print_time.
3488         (scoped_command_stats::print_time): New method.
3489
3490 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3491
3492         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3493         instructions of lengths 6 or 8 bytes.
3494
3495 2019-06-04  Pedro Alves  <palves@redhat.com>
3496
3497         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3498
3499         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3500         * breakpoint.c (condition_completer): Likewise.
3501         * cli/cli-dump.c (scan_expression): Likewise.
3502         * common/filestuff.c (mkdir_recursive): Likewise.
3503         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3504         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3505         (gdb_abspath): Likewise.
3506         * compile/compile-cplus-types.c
3507         (compile_cplus_instance::decl_name): Likewise.
3508         * completer.c (complete_explicit_location):
3509         (signal_completer, reg_or_group_completer_1): Likewise.
3510         * cp-support.c (cp_remove_params_if_any): Likewise.
3511         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3512         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3513         * infcmd.c (strip_bg_char): Likewise.
3514         * linespec.c (copy_token_string): Likewise.
3515         * mi/mi-main.c (output_cores): Likewise.
3516         * psymtab.c (psymtab_search_name):
3517         * symfile.c (test_set_ext_lang_command): Likewise.
3518         * target.c (target_fileio_read_stralloc): Likewise.
3519         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3520         * value.c (complete_internalvar): Likewise.
3521
3522 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3523
3524         Add objfile property to gdb.Type.
3525         * NEWS: Mention Python API addition.
3526         * python/py-type.c (typy_get_objfile): New method.
3527
3528 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3529
3530         * NEWS: Mention the new set|show style [title|highlight].
3531         Mention changes to "show style", "help" and "apropos".
3532
3533 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3534
3535         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3536         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3537         instead of print_help_for_command.
3538         (print_doc_of_command): New function.
3539         (help_list): Add 'apropos -v word' suggestion.
3540         (print_help_for_command): Style the command name using title style.
3541         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3542         (_initialize_cli_cmds): Describe -v in apropos_command help.
3543
3544 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3545
3546         * cli/cli-style.h (cli_style_option): Add name in constructor,
3547         add m_name class member, add constructor with intensity,
3548         add name class function.
3549         (cli_style_option::add_setshow_commands): Remove name argument.
3550         (highlight_style, title_style): New styles.
3551         * cli/cli-style.c (do_show): New function that shows a style
3552         characteristic styling the style name with itself.
3553         (set_style_name): New function.
3554         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3555         Update all callers according to the changes in cli/cli-style.h.
3556         * utils.h (fputs_highlighted): New function.
3557         * utils.c (fputs_highlighted): Likewise.
3558
3559 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3560
3561         * NEWS: Mention new pipe command and new convenience variables.
3562
3563 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3564
3565         * cli/cli-cmds.c (pipe_command): New function.
3566         (_initialize_cli_cmds): Call add_com for pipe_command.
3567         Define | as an alias for pipe.
3568         (exit_status_set_internal_vars): New function.
3569         (shell_escape): Call exit_status_set_internal_vars.
3570         cli/cli-decode.c (find_command_name_length): Recognize | as
3571         a single character command.
3572
3573 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3574
3575         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3576         top.c (execute_command_to_ui_file): New function, mostly a copy
3577         of execute_command_to_string.
3578         (execute_command_to_string): Implement by calling
3579         execute_command_to_ui_file.
3580
3581 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3582
3583         * top.h (saved_command_line): Remove declaration.
3584         * top.c (previous_saved_command_line, previous_repeat_arguments):
3585         New variables.
3586         (saved_command_line): Make static, define together with other
3587         'repeat variables'.
3588         (dont_repeat): Clear repeat_arguments.
3589         (repeat_previous, get_saved_command_line, save_command_line):
3590         New functions.
3591         (gdb_init): Initialize saved_command_line
3592         and previous_saved_command_line.
3593         * main.c (captured_main_1): Remove saved_command_line initialization.
3594         * event-top.c (handle_line_of_input): Update to use
3595         the new 'repeat' related functions instead of direct access to
3596         saved_command_line.
3597         * command.h (repeat_previous, get_saved_command_line,
3598         save_command_line): New declarations.
3599         (dont_repeat): Add comment.
3600
3601 2019-05-30  Tom Tromey  <tromey@adacore.com>
3602
3603         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3604         Fix comment.
3605         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3606
3607 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3608
3609         PR cli/24587
3610         * completer.c (complete): Initialize variable word.
3611
3612 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3613
3614         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3615         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3616         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3617         'body' is NULL to the outter 'if', protecting the '!is_define'
3618         situation as well.
3619
3620 2019-05-29  Tom Tromey  <tromey@adacore.com>
3621
3622         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3623         (dwarf_unknown): New function.
3624         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3625         (dwarf_type_encoding_name): Use dwarf_unknown.
3626
3627 2019-05-29  Tom Tromey  <tromey@adacore.com>
3628
3629         PR c++/20020:
3630         * cp-valprint.c (cp_print_value_fields): Call
3631         cp_print_static_field inside "try".
3632
3633 2019-05-29  Tom Tromey  <tromey@adacore.com>
3634
3635         * inflow.c (struct terminal_info): Add default operator=.
3636         * configure: Rebuild.
3637         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3638         -Wdeprecated-copy-dtor, -Wredundant-move.
3639
3640 2019-05-29  Tom Tromey  <tromey@adacore.com>
3641
3642         * NEWS: Add entry.
3643         * infcmd.c (print_return_value_1): Handle finish_print
3644         option.
3645         (show_print_finish): New function.
3646         (_initialize_infcmd): Add "set/show print finish" commands.
3647         * valprint.c (user_print_options): Initialize new member.
3648         * valprint.h (struct value_print_options) <finish_print>: New
3649         member.
3650
3651 2019-05-28  Tom Tromey  <tromey@adacore.com>
3652
3653         * ada-lang.c (ada_remove_Xbn_suffix)
3654         (find_old_style_renaming_symbol)
3655         (parse_old_style_renaming): Remove.
3656         (ada_find_renaming_symbol): Don't call
3657         find_old_style_renaming_symbol.
3658         (ada_is_renaming_symbol): Rename from
3659         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3660         bool.  Now static.
3661         (ada_read_var_value): Update and simplify.
3662         * ada-exp.y (write_var_or_type): Remove old code.
3663
3664 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3665
3666         * event-top.c: Remove include comment.
3667         * inflow.c (class scoped_ignore_sigttou): Move from here...
3668         * inflow.h (class scoped_ignore_sigttou): ...to here.
3669         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3670         * top.c:  Remove include comment.
3671
3672 2019-05-27  Tom Tromey  <tom@tromey.com>
3673
3674         * NEWS: Fix typo.
3675
3676 2019-05-22  Tom Tromey  <tromey@adacore.com>
3677
3678         * target.c (target_follow_exec): Constify parameter.
3679         * target-delegates.c: Rebuild.
3680         * remote.c (remote_target::follow_exec): Constify parameter.
3681         * infrun.c (follow_exec): Constify parameter.
3682         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3683         (target_follow_exec): Likewise.
3684
3685 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3686
3687         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3688         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3689
3690 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3691
3692         * NEWS: Add debugredirect and testsuite sections.
3693
3694 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3695
3696         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3697         target descriptions using exclusively floating point register name
3698         aliases.
3699
3700 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3701
3702         PR gdb/18644:
3703         * f-lang.c (build_fortran_types): Handle the case where
3704         gdbarch_floatformat_for_type returns a nullptr.
3705
3706 2019-05-21  Tom de Vries  <tdevries@suse.de>
3707
3708         PR cli/24587
3709         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3710
3711 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3712
3713         PR gdb/18644:
3714         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3715         16-byte floats.
3716         * i386-tdep.c (i386_floatformat_for_type): Use
3717         floatformats_ia64_quad for the 16-byte floating point component
3718         within a fortran 32-byte complex number.
3719
3720 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3721
3722         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3723         delete default constructor.
3724         (find_partial_die): Update to return const struct.
3725         (partial_die_parent_scope): Move variable declaration into scope
3726         of its use and change its type to auto.
3727         (guess_partial_die_structure_name): Likewise.
3728         (partial_die_info::fixup): Likewise.
3729
3730 2019-05-17  Tom Tromey  <tromey@adacore.com>
3731
3732         * source.c (find_and_open_source): Remove cast.
3733
3734 2019-05-17  Tom Tromey  <tromey@adacore.com>
3735
3736         * annotate.c (annotate_source): Make "filename" const.
3737         * annotate.h (annotate_source): Use const.
3738
3739 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3740
3741         * disasm.c (set_disassembler_options): Send errors to stderr.
3742
3743 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3744
3745         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3746         (cli_interp_base::set_logging): Check debug_redirect.
3747         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3748         * cli/cli-logging.c (debug_redirect): Add static variable.
3749         (pop_output_files): Add default param.
3750         (handle_redirections): Print debug setting.
3751         (show_logging_command): Likewise.
3752         (_initialize_cli_logging): Add debugredirect command.
3753         * interps.c (current_interp_set_logging): Add debug_redirect
3754         parameter.
3755         * interps.h (set_logging): Add debug_redirect parameter.
3756         (current_interp_set_logging): Likewise.
3757         * mi/mi-common.h: Likewise.
3758         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3759
3760 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3761             Tom Tromey  <tromey@adacore.com>
3762
3763         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3764         directly.
3765         * cli/cli-interp.h (make_logging_output): Remove declaration.
3766         * cli/cli-logging.c (make_logging_output): Remove function.
3767         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3768         directly.
3769         * ui-file.c (tee_file::tee_file): Remove bools.
3770         (tee_file::~tee_file): Remove deletes.
3771         * ui-file.h (tee_file): Remove bools.
3772
3773 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3774
3775         * mi/mi-cmds.h (mi_cmd_complete): New function.
3776         * mi/mi-main.c (mi_cmd_complete): Likewise.
3777         * mi/mi-cmds.c: Define new MI command -complete.
3778         * NEWS: Mention new -complete command.
3779
3780 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3781
3782         * completer.h (complete): New function.
3783         * completer.c (complete): Likewise.
3784         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3785         function defined in completer.h.
3786
3787 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3788
3789         * MAINTAINERS (Write After Approval): Add myself.
3790
3791 2019-05-17  Tom de Vries  <tdevries@suse.de>
3792
3793         PR gdb/24094
3794         * dwarf2read.c (struct cu_partial_die_info): New struct.
3795         (find_partial_die): Return cu_partial_die_info.
3796         (partial_die_parent_scope, guess_partial_die_structure_name)
3797         (partial_die_info::fixup): Handle new return type of find_partial_die.
3798
3799 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3800
3801         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3802         "std::string", simplifying the algorithm.
3803
3804 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3805
3806         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3807         (stap_static_probe_ops::get_probes): Likewise.
3808
3809 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3810
3811         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3812         '-')" and "else if".
3813         (stap_parse_single_operand): Join checks for
3814         "gdbarch_stap_parse_special_token_p" and
3815         "gdbarch_stap_parse_special_token" in the same "if" statement.
3816         Invert check when verifying for operation on register
3817         displacement.
3818
3819 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3820
3821         * stap-probe.c (stap_get_opcode): Update comment.
3822         (stap_get_expected_argument_type): Likewise.
3823         (handle_stap_probe): Likewise.
3824
3825 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3826
3827         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3828         return type to 'bool'.  Adjust comment.  Use 'bool' when
3829         appropriate.
3830         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3831         * stap-probe.c (stap_parse_argument_1): Likewise.
3832         (stap_is_operator): Likewise.
3833         (stap_is_generic_prefix): Likewise.
3834         (stap_is_register_prefix): Likewise.
3835         (stap_is_register_indirection_prefix): Likewise.
3836         (stap_is_integer_prefix): Likewise.
3837         (stap_generic_check_suffix): Likewise.
3838         (stap_check_integer_suffix): Likewise.
3839         (stap_check_register_suffix): Likewise.
3840         (stap_check_register_indirection_suffix): Likewise.
3841         (stap_parse_register_operand): Likewise.
3842         (stap_parse_single_operand): Likewise.
3843         (stap_parse_argument_1): Likewise.
3844         (stap_probe::get_argument_count): Likewise.
3845         (stap_is_operator): Likewise.
3846
3847 2019-05-16  Tom Tromey  <tromey@adacore.com>
3848
3849         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3850         keyword to foreach.
3851
3852 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3853
3854         * linux-thread-db.c (try_thread_db_load_1): Change return type
3855         to bool.
3856         (try_thread_db_load): Likewise.
3857         (try_thread_db_load_from_pdir_1): Likewise.
3858         (try_thread_db_load_from_pdir): Likewise.
3859         (try_thread_db_load_from_sdir): Likewise.
3860         (try_thread_db_load_from_dir): Likewise.
3861         (thread_db_load_search): Likewise.
3862         (has_libpthread): Likewise.
3863         (thread_db_load): Likewise.
3864
3865 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3866
3867         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3868         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3869         NULL, and complain/return if that's the case.
3870
3871 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3872
3873         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3874         (advance, posn, abstract_read_memory): New functions.
3875         [struct mem_read_abstraction]: New struct.
3876         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3877
3878 2019-05-14  Tom Tromey  <tromey@adacore.com>
3879
3880         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3881         value is not lval_memory.
3882
3883 2019-05-14  Tom Tromey  <tromey@adacore.com>
3884
3885         * solib.c (info_sharedlibrary_command): Style the file name.
3886
3887 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3888
3889         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3890         (aarch64_vnv_type): Likewise.
3891         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3892         * common/tdesc.c: Likewise.
3893         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3894         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3895         * features/aarch64-fpu.xml: Add ieee half view.
3896         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3897         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3898         * gdbtypes.h (struct builtin_type): Likewise.
3899         (struct objfile_type): Likewise.
3900
3901 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3902
3903         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3904         typo.
3905         * location.h (string_to_event_location): Likewise.
3906
3907 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3908
3909         GDB 8.3 released.
3910
3911 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3912
3913         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3914         New variable declaration.
3915         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3916         New variable.
3917         (print_one_breakpoint): Use ui_out::test_flags and new global
3918         variable to compute use_fixed_output.
3919         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3920         Remove.
3921         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3922         (mi_multi_location_breakpoint_output_fixed): Remove.
3923         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3924         new variable.
3925         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3926         fix_multi_location_breakpoint_output flag if version >= 3.
3927         * ui-out.h (enum ui_out_flag)
3928         <fix_multi_location_breakpoint_output>: New enumerator.
3929
3930 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3931
3932         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3933
3934 2019-05-10  Tom Tromey  <tromey@adacore.com>
3935
3936         * ada-lang.c (catch_ada_completer): New function.
3937         (_initialize_ada_language): Use it.
3938
3939 2019-05-10  Tom Tromey  <tromey@adacore.com>
3940
3941         * thread.c (print_thread_info): Make "requested_threads" const.
3942         * gdbthread.h (print_thread_info): Make "requested_threads"
3943         const.
3944         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3945         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3946
3947 2019-05-08  Tom Tromey  <tom@tromey.com>
3948
3949         * gdbtypes.c (objfile_type_data): Change type.
3950         (objfile_type, _initialize_gdbtypes): Update.
3951
3952 2019-05-08  Tom Tromey  <tom@tromey.com>
3953
3954         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3955         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3956         (_initialize_dwarf2_frame): Update.
3957
3958 2019-05-08  Tom Tromey  <tom@tromey.com>
3959
3960         * objc-lang.c (objc_objfile_data): Change type.
3961         (find_methods): Update.
3962         (_initialize_objc_lang): Remove.
3963
3964 2019-05-08  Tom Tromey  <tom@tromey.com>
3965
3966         * stabsread.c (rs6000_builtin_type_data): Change type.
3967         (rs6000_builtin_type, _initialize_stabsread): Update.
3968
3969 2019-05-08  Tom Tromey  <tom@tromey.com>
3970
3971         * mips-tdep.c (mips_pdr_data): Remove.
3972         (_initialize_mips_tdep): Update.
3973
3974 2019-05-08  Tom Tromey  <tom@tromey.com>
3975
3976         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3977         (hppa_init_objfile_priv_data, read_unwind_info)
3978         (find_unwind_entry, _initialize_hppa_tdep): Update.
3979
3980 2019-05-08  Tom Tromey  <tom@tromey.com>
3981
3982         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3983         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3984         on obstack.
3985         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3986
3987 2019-05-08  Tom Tromey  <tom@tromey.com>
3988
3989         * mdebugread.c (basic_type_data): Change type.
3990         (basic_type, _initialize_mdebugread): Update.
3991
3992 2019-05-08  Tom Tromey  <tom@tromey.com>
3993
3994         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3995
3996 2019-05-08  Tom Tromey  <tom@tromey.com>
3997
3998         * nto-tdep.c (nto_inferior_data_reg): Change type.
3999         (nto_inferior_data): Update.
4000         (nto_inferior_data_cleanup, nto_new_inferior_data)
4001         (_initialize_nto_tdep): Remove.
4002         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4003
4004 2019-05-08  Tom Tromey  <tom@tromey.com>
4005
4006         * ada-lang.c (struct ada_inferior_data): Add initializers.
4007         (ada_inferior_data): Change type.
4008         (ada_inferior_data_cleanup): Remove.
4009         (get_ada_inferior_data, ada_inferior_exit)
4010         (struct ada_pspace_data): Add initializers, destructor.
4011         (ada_pspace_data_handle): Change type.
4012         (get_ada_pspace_data): Update.
4013         (ada_pspace_data_cleanup): Remove.
4014
4015 2019-05-08  Tom Tromey  <tom@tromey.com>
4016
4017         * coffread.c (struct coff_symfile_info): Add initializers.
4018         (coff_objfile_data_key): Move lower.  Change type.
4019         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4020         Update.
4021         (coff_free_info): Remove.
4022
4023 2019-05-08  Tom Tromey  <tom@tromey.com>
4024
4025         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4026         (fbsd_pspace_data_handle): Move lower.  Change type.
4027         (get_fbsd_pspace_data): Update.
4028         (fbsd_pspace_data_cleanup): Remove.
4029         (_initialize_fbsd_tdep): Update.
4030
4031 2019-05-08  Tom Tromey  <tom@tromey.com>
4032
4033         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4034         (get_ada_tasks_pspace_data): Update.
4035         (ada_tasks_pspace_data_cleanup): Remove.
4036         (_initialize_tasks): Update.
4037         (ada_tasks_inferior_data_handle): Change type.
4038         (get_ada_tasks_inferior_data): Update.
4039         (ada_tasks_inferior_data_cleanup): Remove.
4040         (struct ada_tasks_pspace_data): Add initializers.
4041
4042 2019-05-08  Tom Tromey  <tom@tromey.com>
4043
4044         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4045         * symfile-debug.c (debug_sym_get_probes): Change type.
4046         * stap-probe.c (handle_stap_probe):
4047         (stap_static_probe_ops::get_probes): Change type.
4048         * probe.h (class static_probe_ops) <get_probes>: Change type.
4049         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4050         (parse_probes_in_pspace): Update.
4051         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4052         Update.
4053         (any_static_probe_ops::get_probes): Change type.
4054         * elfread.c (elfread_data): New typedef.
4055         (probe_key): Change type.
4056         (elf_get_probes): Likewise.  Update.
4057         (probe_key_free): Remove.
4058         (_initialize_elfread): Update.
4059         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4060         Change type.
4061         (dtrace_process_dof_probe, dtrace_process_dof)
4062         (dtrace_static_probe_ops::get_probe): Change type.
4063
4064 2019-05-08  Tom Tromey  <tom@tromey.com>
4065
4066         * xcoffread.c (struct xcoff_symfile_info): Rename from
4067         coff_symfile_info.  Add initializers.
4068         (xcoff_objfile_data_key): Move lower.  Change type.
4069         (XCOFF_DATA): Rewrite.
4070         (xcoff_free_info): Remove.
4071         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4072         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4073         (xcoff_initial_scan): Update.
4074
4075 2019-05-08  Tom Tromey  <tom@tromey.com>
4076
4077         * solib-svr4.c (struct svr4_info): Add initializers and
4078         destructor.
4079         <probes_table>: Now an htab_up.
4080         (solib_svr4_pspace_data): Change type.
4081         (free_probes_table): Simplify.
4082         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4083         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4084         (probes_table_remove_objfile_probes, register_solib_event_probe)
4085         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4086         (_initialize_svr4_solib): Update.
4087
4088 2019-05-08  Tom Tromey  <tom@tromey.com>
4089
4090         * remote.c (remote_pspace_data): Change type.
4091         (remote_pspace_data_cleanup): Remove.
4092         (get_remote_exec_file, set_pspace_remote_exec_file)
4093         (_initialize_remote): Update.
4094
4095 2019-05-08  Tom Tromey  <tom@tromey.com>
4096
4097         * breakpoint.c (breakpoint_objfile_key): Change type.
4098         (get_breakpoint_objfile_data): Update.
4099         (free_breakpoint_objfile_data): Remove.
4100         (_initialize_breakpoint): Update.
4101
4102 2019-05-08  Tom Tromey  <tom@tromey.com>
4103
4104         * linux-tdep.c (struct linux_info): Add initializers.
4105         (linux_inferior_data): Move.  Change type.
4106         (invalidate_linux_cache_inf): Update.
4107         (linux_inferior_data_cleanup): Remove.
4108         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4109
4110 2019-05-08  Tom Tromey  <tom@tromey.com>
4111
4112         * auxv.c (auxv_inferior_data): Move.  Change type.
4113         (auxv_inferior_data_cleanup): Remove.
4114         (invalidate_auxv_cache_inf): Rewrite.
4115         (get_auxv_inferior_data, _initialize_auxv): Update.
4116
4117 2019-05-08  Tom Tromey  <tom@tromey.com>
4118
4119         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4120         (symfile_debug_objfile_data_key): Change type.
4121         (symfile_debug_installed, debug_qf_has_symbols)
4122         (debug_qf_find_last_source_symtab)
4123         (debug_qf_forget_cached_source_info)
4124         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4125         (debug_qf_print_stats, debug_qf_dump)
4126         (debug_qf_expand_symtabs_for_function)
4127         (debug_qf_expand_all_symtabs)
4128         (debug_qf_expand_symtabs_with_fullname)
4129         (debug_qf_map_matching_symbols)
4130         (debug_qf_expand_symtabs_matching)
4131         (debug_qf_find_pc_sect_compunit_symtab)
4132         (debug_qf_map_symbol_filenames)
4133         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4134         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4135         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4136         (debug_sym_read_linetable, debug_sym_relocate): Update.
4137         (symfile_debug_free_objfile): Remove.
4138         (install_symfile_debug_logging, _initialize_symfile_debug):
4139         Update.
4140
4141 2019-05-08  Tom Tromey  <tom@tromey.com>
4142
4143         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4144         allocate_on_obstack.
4145         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4146         (get_dwarf2_per_objfile): Update.
4147         (set_dwarf2_per_objfile): Remove.
4148         (dwarf2_has_info, dwarf2_get_section_info): Update.
4149         (dwarf2_free_objfile): Remove.
4150         (_initialize_dwarf2_read): Update.
4151
4152 2019-05-08  Tom Tromey  <tom@tromey.com>
4153
4154         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4155         initializers.
4156         <unsupported_script_warning_printed,
4157         script_not_found_warning_printed>: Now bool.
4158         (auto_load_pspace_data): Change type.
4159         (~auto_load_pspace_info): Rename from
4160         auto_load_pspace_data_cleanup.
4161         (get_auto_load_pspace_data, init_loaded_scripts_info)
4162         (clear_section_scripts, maybe_print_unsupported_script_warning)
4163         (maybe_print_script_not_found_warning, _initialize_auto_load):
4164         Update.
4165
4166 2019-05-08  Tom Tromey  <tom@tromey.com>
4167
4168         * objfiles.c (objfile_pspace_info): Add destructor and
4169         initializers.
4170         (objfiles_pspace_data): Change type.
4171         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4172         (get_objfile_pspace_data): Update.
4173         (objfiles_bfd_data): Change type.
4174         (get_objfile_bfd_data): Update.
4175         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4176
4177 2019-05-08  Tom Tromey  <tom@tromey.com>
4178
4179         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4180         Change type.
4181         (get_catch_syscall_inferior_data): Update.
4182         (catch_syscall_inferior_data_cleanup): Remove.
4183         (_initialize_break_catch_syscall): Update.
4184
4185 2019-05-08  Tom Tromey  <tom@tromey.com>
4186
4187         * inflow.c (struct terminal_info): Add destructor and
4188         initializers.
4189         (inflow_inferior_data): Change type.
4190         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4191         (get_inflow_inferior_data, inflow_inferior_exit)
4192         (swap_terminal_info, _initialize_inflow): Update.
4193
4194 2019-05-08  Tom Tromey  <tom@tromey.com>
4195
4196         * target-dcache.c (target_dcache_cleanup): Remove.
4197         (target_dcache_aspace_key): Change type.
4198         (target_dcache_init_p, target_dcache_invalidate)
4199         (target_dcache_get, target_dcache_get_or_init)
4200         (_initialize_target_dcache): Update.
4201         * dcache.h (struct dcache_deleter): New.
4202
4203 2019-05-08  Tom Tromey  <tom@tromey.com>
4204
4205         * symtab.c (struct symbol_cache): Add destructor and
4206         initializers.
4207         (symbol_cache_key): Move.  Change type.
4208         (make_symbol_cache, free_symbol_cache): Remove.
4209         (get_symbol_cache): Update.
4210         (symbol_cache_cleanup): Remove.
4211         (ALL_PSPACES, symbol_cache_flush)
4212         (maintenance_print_symbol_cache)
4213         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4214         Update.
4215
4216 2019-05-08  Tom Tromey  <tom@tromey.com>
4217
4218         * symtab.c (struct main_info): Add destructor and initializers.
4219         (main_progspace_key): Move.  Change type.
4220         (get_main_info): Update.
4221         (main_info_cleanup): Remove.
4222         (_initialize_symtab): Update.
4223
4224 2019-05-08  Tom Tromey  <tom@tromey.com>
4225
4226         * registry.h (DECLARE_REGISTRY): Define the _key class.
4227
4228 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * NEWS: Merge two 'New commands' sections.
4231
4232 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4233
4234         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4235         parameter and use Ada language definition instead.
4236         (ada_val_print_ptr): Remove unused language parameter.
4237         (ada_val_print_num): Remove language parameter and use Ada language
4238         definition instead.
4239         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4240         parameter.
4241         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4242         parameter and use Ada language definition instead.
4243         (ada_val_print_1): Update all ada_val_print_xxx calls.
4244         Remove language parameter.
4245         (ada_val_print): Update ada_val_print_1 call.
4246
4247 2019-05-08  Tom Tromey  <tromey@adacore.com>
4248
4249         * remote.c (remote_hw_watchpoint_limit)
4250         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4251         Now static.
4252
4253 2019-05-08  Tom Tromey  <tromey@adacore.com>
4254
4255         * maint.c (_initialize_maint_cmds): Move initialization code to
4256         remote.c.
4257         (watchdog, show_watchdog): Move to remote.c.
4258         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4259         "watchdog" static.
4260         (_initialize_remote): Move initialization code from maint.c.
4261         * defs.h (watchdog): Don't declare.
4262
4263 2019-05-08  Tom Tromey  <tromey@adacore.com>
4264
4265         * tui/tui-interp.c: Include main.h.
4266         * interps.c: Include main.h.
4267         * main.h (interpreter_p): Declare.
4268         * defs.h (interpreter_p): Don't declare.
4269
4270 2019-05-08  Tom Tromey  <tromey@adacore.com>
4271
4272         * dwarf2loc.c: Include dwarf2read.h.
4273         * defs.h (read_unsigned_leb128): Don't declare.
4274         * dwarf2read.h (read_unsigned_leb128): Declare.
4275
4276 2019-05-08  Tom Tromey  <tromey@adacore.com>
4277
4278         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4279         method.
4280
4281 2019-05-08  Tom Tromey  <tromey@adacore.com>
4282
4283         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4284         when no wrap column is set.
4285
4286 2019-05-08  Tom Tromey  <tromey@adacore.com>
4287
4288         * c-lang.c (c_get_string): Handle non-C-style arrays.
4289
4290 2019-05-08  Tom Tromey  <tromey@adacore.com>
4291
4292         * typeprint.c (print_offset_data::update): Print the bit offset,
4293         not the number of bits remaining.
4294
4295 2019-05-08  Tom Tromey  <tromey@adacore.com>
4296
4297         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4298         padding at end of comment.
4299
4300 2019-05-08  Tom Tromey  <tromey@adacore.com>
4301
4302         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4303         Compare main types.
4304
4305 2019-05-06  Tom Tromey  <tom@tromey.com>
4306
4307         * common/scoped_mmap.c: Include common-defs.h.
4308         * common/scoped_mmap.h: Don't include config.h.
4309
4310 2019-05-04  Tom Tromey  <tom@tromey.com>
4311
4312         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4313         (struct aarch64_call_info): Add initializers.
4314         <si>: Now a std::vector.
4315         (pass_on_stack, aarch64_push_dummy_call): Update.
4316
4317 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4318             Tom Tromey  <tom@tromey.com>
4319
4320         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4321         (ppc_threads): Now a std::vector.  Now static.
4322         (hwdebug_find_thread_points_by_tid)
4323         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4324         Update.
4325
4326 2019-05-04  Tom Tromey  <tom@tromey.com>
4327
4328         * arc-tdep.c (arc_tdesc_init): Return bool.
4329
4330 2019-05-04  Tom Tromey  <tom@tromey.com>
4331
4332         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4333         Use gdb_assert_not_reached.
4334
4335 2019-05-04  Tom Tromey  <tom@tromey.com>
4336
4337         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4338         "false".
4339
4340 2019-05-04  Tom Tromey  <tom@tromey.com>
4341
4342         * arc-tdep.c (arc_tdesc_init): Use bool.
4343
4344 2019-05-04  Tom Tromey  <tom@tromey.com>
4345
4346         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4347
4348 2019-05-04  Tom Tromey  <tom@tromey.com>
4349
4350         * cli/cli-cmds.c (valid_command_p): Return bool.
4351
4352 2019-05-04  Tom Tromey  <tom@tromey.com>
4353
4354         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4355         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4356
4357 2019-05-04  Raul Tambre  <raul@tambre.ee>
4358
4359         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4360         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4361         operator for comparison.
4362
4363 2019-05-04  Tom Tromey  <tom@tromey.com>
4364
4365         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4366         (lookup_partial_symbol, print_partial_symbols)
4367         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4368         (psymbol_compare): Update.
4369         (add_psymbol_to_bcache): Clear the entire psymbol.
4370         (maintenance_check_psymtabs): Update.
4371         * psympriv.h (struct partial_symbol): Don't derive from
4372         general_symbol_info.
4373         <obj_section, unrelocated_address, address,
4374         set_unrelocated_address>: Update.
4375         <ginfo>: New member.
4376         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4377         (debug_names::write_psymbols): Update.
4378
4379 2019-05-04  Tom de Vries  <tdevries@suse.de>
4380
4381         * contrib/cc-with-tweaks.sh: Support -n arg.
4382
4383 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4384
4385         * corelow.c (core_target::detach): Ensure frame cache and
4386         register caches are cleared.
4387         inferior.c (exit_inferior_1): Likewise.
4388
4389 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4390             Tom Tromey  <tom@tromey.com>
4391
4392         * dictionary.c (collate_pending_symbols_by_language): Remove
4393         "struct" from foreach.
4394         * symtab.c (lookup_global_symbol_from_objfile)
4395         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4396         foreach.
4397         * ser-tcp.c (net_open): Remove "struct" from foreach.
4398         * objfiles.c (objfile_relocate, objfile_rebase)
4399         (objfile_has_symbols): Remove "struct" from foreach.
4400         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4401         from foreach.
4402         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4403         foreach.
4404         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4405         "struct" from foreach.
4406         * ada-lang.c (create_excep_cond_exprs)
4407         (ada_exception_catchpoint_cond_string): Remove "struct" from
4408         foreach.
4409
4410 2019-05-03  Tom Tromey  <tromey@adacore.com>
4411
4412         * ada-exp.y (convert_char_literal): Check suffix of each
4413         enumerator.
4414
4415 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4416
4417         PR ada/21406:
4418         * ada-exp.y (yywrap): Don't define.
4419         * ada-lex.l (%option): Add noyywrap
4420         (yywrap): Remove.
4421
4422 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4423
4424         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4425         _WIN32_WINNT to the XP level, unless already defined to a higher
4426         level.
4427
4428         * unittests/parse-connection-spec-selftests.c:
4429         * ser-tcp.c:
4430         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4431         override.
4432
4433         * symfile.c (find_separate_debug_file): Remove colon from the
4434         drive spec of DOS/Windows file names of the target, so that the
4435         file name produced from DEBUGDIR and the target's directory will
4436         be valid on DOS/Windows systems.
4437
4438 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4439
4440         * rust-lang.c (val_print_struct): Handle printing structures
4441         containing strings.
4442
4443 2019-05-02  Tom Tromey  <tromey@adacore.com>
4444
4445         * valarith.c (_initialize_valarith): Remove.
4446
4447 2019-05-01  Tom Tromey  <tromey@adacore.com>
4448
4449         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4450         bitfields.
4451
4452 2019-05-01  Tom Tromey  <tromey@adacore.com>
4453
4454         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4455         for big-endian copies.
4456
4457 2019-04-30  Ali Tamur  <tamur@google.com>
4458         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4459         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4460         (read_3_bytes): New function.
4461
4462 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4463
4464         * windows-nat.c (main_thread_id): Delete.
4465         (handle_output_debug_string): Replace main_thread_id by
4466         current_event.dwThreadId.
4467         (fake_create_process): Likewise.
4468         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4469         Do not set main_thread_id.
4470         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4471         current_event.dwThreadId.
4472         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4473
4474 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4475
4476         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4477         Use current_event.dwThreadId instead of main_thread_id.
4478
4479 2019-04-30  Tom Tromey  <tromey@adacore.com>
4480
4481         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4482         (create_excep_cond_exprs): Iterate over program spaces.
4483         (ada_exception_catchpoint_cond_string): Examine all minimal
4484         symbols for exception types.
4485
4486 2019-04-30  Tom Tromey  <tromey@adacore.com>
4487
4488         PR c++/24470:
4489         * dwarf2read.c (process_structure_scope): Handle case where type
4490         has template parameters but no symbol was created.
4491
4492 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4493             Chris January  <chris.january@arm.com>
4494
4495         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4496         qualifier.
4497         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4498
4499 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4500
4501         * f-typeprint.c (f_print_type): Update rules for printing
4502         whitespace.
4503         (f_type_print_varspec_suffix): Likewise.
4504
4505 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4506             Chris January  <chris.january@arm.com>
4507
4508         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4509         function arguments.
4510
4511 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4512
4513         * f-lang.c (build_fortran_types): Change name of void type to
4514         lower case.
4515         * f-typeprint.c (f_type_print_base): Print the name of the void
4516         type, rather than a fixed string.
4517         * f-valprint.c (f_decorations): Use lower case void string.
4518
4519 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4520             Chris January  <chris.january@arm.com>
4521
4522         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4523         types for Fortran.
4524
4525 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4526             Chris January  <chris.january@arm.com>
4527             David Lecomber  <david.lecomber@arm.com>
4528
4529         * f-exp.y (BINOP_INTRINSIC): New token.
4530         (exp): New parser rule handling BINOP_INTRINSIC.
4531         (f77_keywords): Add new builtin procedures.
4532         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4533         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4534         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4535         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4536         (print_unop_subexp_f): New function.
4537         (print_binop_subexp_f): New function.
4538         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4539         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4540         (dump_subexp_body_f): Likewise.
4541         (operator_check_f): Likewise.
4542         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4543         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4544
4545 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4548         UNOP_KIND.
4549         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4550         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4551         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4552         (operator_length_f): New fuction.
4553         (print_subexp_f): New function.
4554         (op_name_f): New function.
4555         (dump_subexp_body_f): New function.
4556         (operator_check_f): New function.
4557         (exp_descriptor_f): Replace standard expression handling functions
4558         with new functions.
4559         * gdb/fortran-operator.def: New file.
4560         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4561         * gdb/std-operator.def: Remove UNOP_KIND.
4562
4563 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4564
4565         * std-operator.def: Remove unbalanced, stray double quote
4566         character.
4567
4568 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4569             Chris January  <chris.january@arm.com>
4570             Daniel Everett  <daniel.everett@arm.com>
4571             Nick Forrington  <nick.forrington@arm.com>
4572             Richard Bunt  <richard.bunt@arm.com>
4573
4574         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4575         of depth when printing anonymous structs or unions.
4576         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4577         Don't print either the top-level value, or the children if the
4578         max-depth is exceeded.
4579         (ppscm_print_children): When printing the key of a map, allow one
4580         extra level of depth.
4581         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4582         print either the top-level value, or the children if the max-depth
4583         is exceeded.
4584         (print_children): When printing the key of a map, allow one extra
4585         level of depth.
4586         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4587         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4588         (user_print_options): Initialise max_depth field.
4589         (val_print_scalar_or_string_type_p): New function.
4590         (val_print): Check to see if the max depth has been reached.
4591         (val_print_check_max_depth): Define new function.
4592         (show_print_max_depth): New function.
4593         (_initialize_valprint): Add 'print max-depth' option.
4594         * valprint.h (struct value_print_options) <max_depth>: New field.
4595         (val_print_check_max_depth): Declare new function.
4596         * NEWS: Document new feature.
4597
4598 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * ada-lang.c (ada_language_defn): Initialise new field.
4601         * c-lang.c (c_is_string_type_p): New function.
4602         (c_language_defn): Initialise new field.
4603         (cplus_language_defn): Initialise new field.
4604         (asm_language_defn): Initialise new field.
4605         (minimal_language_defn): Initialise new field.
4606         * c-lang.h (c_is_string_type_p): Declare new function.
4607         * d-lang.c (d_language_defn): Initialise new field.
4608         * f-lang.c (f_is_string_type_p): New function.
4609         (f_language_defn): Initialise new field.
4610         * go-lang.c (go_is_string_type_p): New function.
4611         (go_language_defn): Initialise new field.
4612         * language.c (default_is_string_type_p): New function.
4613         (unknown_language_defn): Initialise new field.
4614         (auto_language_defn): Initialise new field.
4615         * language.h (struct language_defn) <la_is_string_type_p>: New
4616         member variable.
4617         (default_is_string_type_p): Declare new function.
4618         * m2-lang.c (m2_language_defn): Initialise new field.
4619         * objc-lang.c (objc_language_defn): Initialise new field.
4620         * opencl-lang.c (opencl_language_defn): Initialise new field.
4621         * p-lang.c (pascal_is_string_type_p): New function.
4622         (pascal_language_defn): Initialise new field.
4623         * rust-lang.c (rust_is_string_type_p): New function.
4624         (rust_language_defn): Initialise new field.
4625
4626 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4627
4628         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4629         New field.
4630         * ada-lang.c (ada_language_defn): Initialise new field.
4631         * c-lang.c (c_language_defn): Likewise.
4632         (cplus_language_defn): Likewise.
4633         (asm_language_defn): Likewise.
4634         (minimal_language_defn): Likewise.
4635         * d-lang.c (d_language_defn): Likewise.
4636         * f-lang.c (f_language_defn): Likewise.
4637         * go-lang.c (go_language_defn): Likewise.
4638         * language.c (unknown_language_defn): Likewise.
4639         (auto_language_defn): Likewise.
4640         * m2-lang.c (m2_language_defn): Likewise.
4641         * objc-lang.c (objc_language_defn): Likewise.
4642         * opencl-lang.c (opencl_language_defn): Likewise.
4643         * p-lang.c (pascal_language_defn): Likewise.
4644         * rust-lang.c (rust_language_defn): Likewise.
4645
4646 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4647
4648         * ada-lang.c (ada_is_character_type): Change return type to bool.
4649         (ada_is_string_type): Likewise.
4650         * ada-lang.h (ada_is_character_type): Update declaration
4651         (ada_is_string_type): Likewise.
4652
4653 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4654
4655         Support style in 'frame|thread apply'
4656
4657         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4658         * record.c (record_start, record_stop): Update callers of
4659         execute_command_to_string with false.
4660         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4661         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4662         methods.
4663         (class string_file): New constructor with term_out parameter.
4664         Override methods term_out and can_emit_style_escape.  New member
4665         term_out.
4666         (class stdio_file): Override can_emit_style_escape.
4667         (class tee_file): Override term_out and can_emit_style_escape.
4668         * utils.h (can_emit_style_escape): Remove.
4669         * utils.c (can_emit_style_escape): Likewise.
4670         Update all callers of can_emit_style_escape (SOMESTREAM) to
4671         SOMESTREAM->can_emit_style_escape.
4672         * source-cache.c (source_cache::get_source_lines): Likewise.
4673         * stack.c (frame_apply_command_count): Call execute_command_to_string
4674         passing the term_out characteristic of the current gdb_stdout.
4675         * thread.c (thr_try_catch_cmd): Likewise.
4676         * top.c (execute_command_to_string): pass term_out parameter
4677         to construct the string_file for the command output.
4678         * ui-file.c (term_cli_styling): New function (most code moved
4679         from utils.c can_emit_style_escape).
4680         (string_file::string_file, string_file::can_emit_style_escape,
4681         stdio_file::can_emit_style_escape, tee_file::term_out,
4682         tee_file::can_emit_style_escape): New functions.
4683
4684 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4685
4686         * NEWS: Mention the new set|show may-call-functions.
4687         * infcall.c (may_call_functions_p): New variable.
4688         (show_may_call_functions_p): New function.
4689         (call_function_by_hand_dummy): Throws an error if not
4690         may-call-functions.
4691         (_initialize_infcall): Call add_setshow_boolean_cmd for
4692         may-call-functions.
4693
4694 2019-04-25  Keith Seitz  <keiths@redhat.com>
4695
4696         PR c++/24367
4697         * cp-support.c (inspect_type): Don't attempt substitutions
4698         of symbol with the same name.
4699
4700 2019-04-25  Tom Tromey  <tromey@adacore.com>
4701
4702         PR gdb/24475:
4703         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4704         static.
4705
4706 2019-04-25  Tom Tromey  <tromey@adacore.com>
4707
4708         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4709         rvalue reference.
4710         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4711         (gdb_xml_parser::parse): Use std::move.
4712         * python/python-internal.h (gdbpy_convert_exception): Take a const
4713         reference.
4714         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4715         std::move.
4716         * python/py-utils.c (gdbpy_convert_exception): Take a const
4717         reference.
4718         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4719         Use std::move.
4720         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4721         Use std::move.
4722         * mi/mi-main.c (mi_print_exception): Take a const reference.
4723         * main.c (handle_command_errors): Take a const reference.
4724         * linespec.c (parse_linespec): Use std::move.
4725         * infcall.c (run_inferior_call): Use std::move.
4726         (call_function_by_hand_dummy): Use std::move.
4727         * exec.c (try_open_exec_file): Use std::move.
4728         * exceptions.h (exception_print, exception_fprintf)
4729         (exception_print_same): Update.
4730         * exceptions.c (print_exception, exception_print)
4731         (exception_fprintf, exception_print_same): Change parameters to
4732         const reference.
4733         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4734         * common/new-op.c: Use std::move.
4735         * common/common-exceptions.h (struct gdb_exception): Add move
4736         constructor.
4737         (struct gdb_exception_error, struct gdb_exception_quit, struct
4738         gdb_quit_bad_alloc): Change constructor to move constructor.
4739         (throw_exception): Change parameter to rvalue reference.
4740         * common/common-exceptions.c (throw_exception): Take rvalue
4741         reference.
4742         * cli/cli-interp.c (safe_execute_command): Use std::move.
4743         * breakpoint.c (insert_bp_location, location_to_sals): Use
4744         std::move.
4745
4746 2019-04-25  Tom Tromey  <tromey@adacore.com>
4747
4748         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4749         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4750         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4751         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4752         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4753         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4754         guile/scm-value.c: Use unpack.
4755         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4756         gdbscm_gdb_exception.
4757         (gdbscm_throw_gdb_exception): Likewise.
4758         (struct gdbscm_gdb_exception): New.
4759         (unpack): New function.
4760         (gdbscm_wrap): Use unpack.
4761
4762 2019-04-25  Tom Tromey  <tromey@adacore.com>
4763
4764         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4765         (gdb_rl_callback_handler): Use std::move.
4766         * common/common-exceptions.h (struct gdb_exception): Add move
4767         assignment operator.
4768         (throw_exception_sjlj): Change "exception" to const reference.
4769         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4770         (throw_exception_sjlj): Change "exception" to const reference.
4771
4772 2019-04-25  Tom Tromey  <tromey@adacore.com>
4773
4774         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4775         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4776         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4777         Update.
4778         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4779         Update.
4780         * mi/mi-interp.c (mi_interp::exec): Update.
4781         * linespec.c (parse_linespec): Update.
4782         * infcall.c (run_inferior_call): Update.
4783         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4784         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4785         (gdbscm_lookup_global_symbol): Update.
4786         * guile/scm-param.c (gdbscm_parameter_value): Update.
4787         * guile/scm-frame.c (gdbscm_frame_read_register)
4788         (gdbscm_frame_read_var): Update.
4789         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4790         * exec.c (try_open_exec_file): Update.
4791         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4792         (gdb_rl_callback_handler): Update.
4793         * common/common-exceptions.h (exception_none): Don't declare.
4794         * common/common-exceptions.c (exception_none): Don't define.
4795         (struct catcher) <exception>: Update.
4796         * cli/cli-interp.c (safe_execute_command): Update.
4797         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4798
4799 2019-04-25  Ali Tamur  <tamur@google.com>
4800
4801         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4802         (read_attribute_value): Likewise.
4803         (dwarf2_read_addr_index): Update comment.
4804         (read_str_index): Add DW_FORM_strx.
4805         (dwarf2_string_attr): Likewise.
4806         (dwarf2_const_value_attr): Likewise.
4807         (dump_die_shallow): Likewise.
4808         (dwarf2_fetch_constant_bytes): Likewise.
4809         (skip_form_bytes): Likewise.
4810         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4811
4812 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4813
4814         PR corefiles/11608
4815         PR corefiles/18187
4816         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4817         OFFSET.  Verify if current mapping contains an ELF header.
4818         (linux_find_memory_regions_full): Adjust call to
4819         dump_mapping_p.
4820
4821 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4822             Kang Li <kanglictf@gmail.com>
4823
4824         PR gdb/21600
4825
4826         * dwarf2-frame.c (read_initial_length): Be consistent about using
4827         unsigned representation of length.
4828         (decode_frame_entry_1): Likewise.  Check for wraparound of
4829         end pointer as well as buffer overflow.
4830
4831 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4832
4833         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4834         "vq".
4835
4836 2019-04-24  Tom Tromey  <tromey@adacore.com>
4837
4838         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4839
4840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4841
4842         * s12z-tdep.c (s12z_unwind_pc): Delete.
4843         (s12z_unwind_sp): Delete.
4844         (s12z_gdbarch_init): Don't register deleted functions with
4845         gdbarch.
4846
4847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4848
4849         * rl78-tdep.c (rl78_unwind_sp): Delete.
4850         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4851
4852 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4853
4854         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4855         (xstormy16_unwind_pc): Delete.
4856         (xstormy16_dummy_id): Delete.
4857         (xstormy16_gdbarch_init): Don't register deleted functions with
4858         gdbarch.
4859
4860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         * vax-tdep.c (vax_unwind_pc): Delete.
4863         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4864
4865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4866
4867         * v850-tdep.c (v850_unwind_sp): Delete.
4868         (v850_unwind_pc): Delete.
4869         (v850_dummy_id): Delete.
4870         (v850_gdbarch_init): Don't register deleted functions with
4871         gdbarch.
4872
4873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4874
4875         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4876         (tilegx_unwind_pc): Delete.
4877         (tilegx_unwind_dummy_id): Delete.
4878         (tilegx_gdbarch_init): Don't register deleted functions with
4879         gdbarch.
4880
4881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4882
4883         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4884         (tic6x_dummy_id): Delete.
4885         (tic6x_gdbarch_init): Don't register deleted functions with
4886         gdbarch.
4887
4888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4889
4890         * sparc-tdep.c (sparc_unwind_pc): Delete.
4891         (sparc32_gdbarch_init): Don't register deleted function with
4892         gdbarch.
4893
4894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4895
4896         * sh-tdep.c (sh_unwind_sp): Delete.
4897         (sh_unwind_pc): Delete.
4898         (sh_dummy_id): Delete.
4899         (sh_gdbarch_init): Don't register deleted functions with
4900         gdbarch.
4901
4902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4903
4904         * score-tdep.c (score_unwind_sp): Delete.
4905         (score_unwind_pc): Delete.
4906         (score_dummy_id): Delete.
4907         (score_gdbarch_init): Don't register deleted functions with
4908         gdbarch.
4909
4910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * rx-tdep.c (rx_unwind_pc): Delete.
4913         (rx_unwind_sp): Delete.
4914         (rx_dummy_id): Delete.
4915         (rx_gdbarch_init): Don't register deleted functions with
4916         gdbarch.  Update comment.
4917
4918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4921         (rs6000_dummy_id): Delete.
4922         (rs6000_gdbarch_init): Don't register deleted functions with
4923         gdbarch.
4924
4925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4926
4927         * or1k-tdep.c (or1k_dummy_id): Delete.
4928         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4929
4930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4931
4932         * nios2-tdep.c (nios2_dummy_id): Delete.
4933         (nios2_unwind_sp): Delete.
4934         (nios2_gdbarch_init): Don't register deleted functions with
4935         gdbarch.
4936
4937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4938
4939         * nds32-tdep.c (nds32_dummy_id): Delete.
4940         (nds32_unwind_pc): Delete.
4941         (nds32_unwind_sp): Delete.
4942         (nds32_gdbarch_init): Don't register deleted functions with
4943         gdbarch.
4944
4945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4946
4947         * msp430-tdep.c (msp430_unwind_pc): Delete.
4948         (msp430_unwind_sp): Delete.
4949         (msp430_dummy_id): Delete.
4950         (msp430_gdbarch_init): Don't register deleted functions with
4951         gdbarch.
4952
4953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4954
4955         * moxie-tdep.c (moxie_unwind_sp): Delete.
4956         (moxie_unwind_pc): Delete.
4957         (moxie_dummy_id): Delete.
4958         (moxie_gdbarch_init): Don't register deleted functions with
4959         gdbarch.
4960
4961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4962
4963         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4964         (mn10300_unwind_pc): Delete.
4965         (mn10300_unwind_sp): Delete.
4966         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4967         mn10300_unwind_sp.
4968         (mn10300_frame_unwind_init): Don't register deleted functions with
4969         gdbarch.
4970
4971 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4972
4973         * mep-tdep.c (mep_unwind_pc): Delete.
4974         (mep_unwind_sp): Delete.
4975         (mep_dummy_id): Delete.
4976         (mep_gdbarch_init): Don't register deleted functions with
4977         gdbarch.
4978
4979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4980
4981         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4982         (m68hc11_unwind_sp): Delete.
4983         (m68hc11_gdbarch_init): Don't register deleted functions with
4984         gdbarch.
4985
4986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4987
4988         * m32r-tdep.c (m32r_unwind_sp): Delete.
4989         (m32r_unwind_pc): Delete.
4990         (m32r_dummy_id): Delete.
4991         (m32r_gdbarch_init): Don't register deleted functions with
4992         gdbarch.
4993
4994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * m32c-tdep.c (m32c_unwind_pc): Delete.
4997         (m32c_unwind_sp): Delete.
4998         (m32c_dummy_id): Delete.
4999         (m32c_gdbarch_init): Don't register deleted functions with
5000         gdbarch.
5001
5002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5003
5004         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5005         (lm32_unwind_pc): Delete.
5006         (lm32_dummy_id): Delete.
5007         (lm32_gdbarch_init): Don't register deleted functions with
5008         gdbarch.
5009
5010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5011
5012         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5013         (iq2000_unwind_pc): Delete.
5014         (iq2000_dummy_id): Delete.
5015         (iq2000_gdbarch_init): Don't register deleted functions with
5016         gdbarch.
5017
5018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5019
5020         * nds32-tdep.c (nds32_type_align): Delete.
5021         (nds32_push_dummy_call): Use type_align instead.
5022
5023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5024
5025         * arm-tdep.c (arm_type_align): Only handle vector override case.
5026         (arm_push_dummy_call): Use type_align.
5027         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5028
5029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5030
5031         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5032         case.
5033         (pass_on_stack): Use type_align.
5034         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5035         function.
5036
5037 2019-04-23  Tom Tromey  <tromey@adacore.com>
5038
5039         * dwarf2read.c (line_header::file_name_at): Remove unused
5040         overload.
5041
5042 2019-04-23  Tom de Vries  <tdevries@suse.de>
5043
5044         PR gdb/24438
5045         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5046         invocation.
5047
5048
5049 2019-03-27  Ali Tamur  <tamur@google.com>
5050
5051         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5052         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5053         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5054         (dwarf_expr_context::get_addr_index): Likewise
5055         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5056         (symbol_needs_eval_context::get_addr_index): Likewise
5057         (disassemble_dwarf_expression): Add DW_OP_addrx
5058         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5059         (read_cutu_die_from_dwo): Update comment
5060         (skip_one_die): Add DW_FORM_addrx
5061         (read_attribute_value): Likewise
5062         (var_decode_location): Add DW_OP_addrx
5063         (dwarf2_const_value_attr): Add DW_FORM_addrx
5064         (dump_die_shallow): Likewise
5065         (dwarf2_fetch_constant_bytes): Likewise
5066         (decode_locdesc): Add DW_OP_addrx
5067         (skip_form_bytes): Add DW_FORM_addrx
5068
5069 2019-04-22  Ali Tamur  <tamur@google.com>
5070
5071         * MAINTAINERS (Write After Approval): Add self.
5072
5073 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5074
5075         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5076         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5077         (open_symbol_file_object): Likewise.
5078         (svr4_default_sos): Add info parameter.
5079         (svr4_read_so_list): Likewise.
5080         (svr4_current_sos_direct): Adjust functions calls to pass down
5081         info.
5082         (svr4_current_sos_1): Add info parameter.
5083         (svr4_current_sos): Call get_svr4_info, pass info down to
5084         svr4_current_sos_1.
5085         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5086         get_svr4_info.
5087         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5088         get_svr4_info.
5089         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5090         to get_svr4_info.
5091         (probes_table_remove_objfile_probes): Likewise.
5092         (register_solib_event_probe): Add info parameter.
5093         (solist_update_incremental): Pass info parameter down to
5094         svr4_read_so_list.
5095         (disable_probes_interface): Add info parameter.
5096         (svr4_handle_solib_event): Pass current_program_space to
5097         get_svr4_info.  Adjust disable_probes_interface cleanup.
5098         (svr4_create_probe_breakpoints): Add info parameter, pass it
5099         down to register_solib_event_probe.
5100         (svr4_create_solib_event_breakpoints): Add info parameter,
5101         pass it down to svr4_create_probe_breakpoints.
5102         (enable_break): Pass info down to
5103         svr4_create_solib_event_breakpoints.
5104         (svr4_solib_create_inferior_hook): Pass current_program_space to
5105         get_svr4_info.
5106         (svr4_clear_solib): Likewise.
5107
5108 2019-04-22  Pedro Alves  <palves@redhat.com>
5109
5110         * solib-svr4.c (svr4_free_objfile_observer): New.
5111         (probe_and_action::objfile): New field.
5112         (probes_table_htab_remove_objfile_probes)
5113         (probes_table_remove_objfile_probes): New functions.
5114         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5115         in the new probe_and_action.  Don't store the probe in 'lookup'.
5116         (svr4_create_probe_breakpoints): Pass objfile to
5117         register_solib_event_probe.
5118         (_initialize_svr4_solib): Register a free_objfile observer.
5119
5120 2019-04-19  Tom Tromey  <tom@tromey.com>
5121
5122         * common/queue.h: Remove.
5123
5124 2019-04-19  Tom Tromey  <tom@tromey.com>
5125
5126         * event-loop.c: Don't include "common/queue.h".
5127
5128 2019-04-19  Tom Tromey  <tom@tromey.com>
5129
5130         * remote.c (remote_target): Use delete.
5131         * remote-notif.h: Include <list>, not "common/queue.h".
5132         (notif_client_p): Remove typedef.
5133         (remote_notif_state): Add constructor, destructor, initializer.
5134         <notif_queue>: Now a std::list.
5135         (remote_notif_state_xfree): Don't declare.
5136         * remote-notif.c (remote_notif_process, handle_notification)
5137         (remote_notif_state_allocate): Update.
5138         (~remote_notif_state): Rename from remote_notif_state_xfree.
5139
5140 2019-04-19  Tom Tromey  <tom@tromey.com>
5141
5142         * symfile.c (reread_symbols): Update.
5143         * objfiles.c (objfile_register_static_link)
5144         (objfile_lookup_static_link): Update
5145         (~objfile) Don't delete static_links.
5146         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5147
5148 2019-04-19  Tom Tromey  <tom@tromey.com>
5149
5150         * type-stack.h (struct type_stack) <insert>: Constify string.
5151         * type-stack.c (type_stack::insert): Constify string.
5152         * gdbtypes.h (lookup_template_type): Update.
5153         (address_space_name_to_int): Update.
5154         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5155         const.
5156         (lookup_template_type): Make name const.
5157         * c-exp.y: Update rules.
5158         (lex_one_token, classify_name, classify_inner_name)
5159         (c_print_token): Update.
5160         * p-exp.y: Update rules.
5161         (yylex): Update.
5162         * f-exp.y: Update rules.
5163         (yylex): Update.
5164         * d-exp.y: Update rules.
5165         (lex_one_token, classify_name, classify_inner_name): Update.
5166         * parse.c (write_dollar_variable, copy_name): Return std::string.
5167         * parser-defs.h (copy_name): Change return type.
5168         * m2-exp.y: Update rules.
5169         (yylex): Update.
5170         * go-exp.y (lex_one_token): Update.
5171         Update rules.
5172         (classify_unsafe_function, classify_packaged_name)
5173         (classify_name, yylex): Update.
5174
5175 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5176
5177         * configure.ac: add --enable-source-highlight switch.
5178         * configure: Regenerate.
5179         * top.c (print_gdb_version): plumb --enable-source-highlight
5180         status to "show configuration".
5181
5182 2019-04-19  Tom Tromey  <tromey@adacore.com>
5183
5184         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5185         Check ADA_TYPE_P.
5186         (empty_record, ada_template_to_fixed_record_type_1)
5187         (template_to_static_fixed_type)
5188         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5189         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5190         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5191         macros.
5192
5193 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5194
5195         PR symtab/24423:
5196         * source.c (print_source_lines_base): Advance "iter" when a
5197         control character is seen.
5198
5199 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5200
5201         * inferior.h (struct infcall_suspend_state_deleter):
5202         Catch exception in destructor to avoid crash.
5203
5204 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5205
5206         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5207         close to the add_com "shell".
5208
5209 2019-04-18  Tom Tromey  <tromey@adacore.com>
5210
5211         * process-stratum-target.h (class process_stratum_target)
5212         <stratum>: Add "final".
5213
5214 2019-04-17  Tom Tromey  <tromey@adacore.com>
5215
5216         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5217         against nullptr before use.
5218
5219 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5220
5221         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5222
5223 2019-04-17  Jim Wilson  <jimw@sifive.com>
5224             Andrew Burgess  <andrew.burgess@embecosm.com>
5225
5226         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5227         code read might fail, assume 4-byte breakpoint in that case.
5228
5229 2019-04-15  Leszek Swirski  <leszeks@google.com>
5230
5231         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5232         rather than a hand-rolled POD check when checking for forced MEMORY
5233         classification.
5234
5235 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5236
5237         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5238         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5239         function.
5240         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5241         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5242         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5243         declaration.
5244
5245 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5246
5247         * aarch64-linux-nat.c
5248         (aarch64_linux_nat_target::thread_architecture): Add override.
5249         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5250         each VQ.
5251
5252 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5253
5254         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5255
5256 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5257
5258         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5259         target types of size 96-bits, add some additional comments, and
5260         check that the builtin type we found was the correct size.
5261
5262 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5263
5264         * utils.c (prompt_for_continue): Don't restore the styling at the
5265         end, as applied_style has the wrong value.  This fixes styling in
5266         long lists of file names that are interrupted by the "Continue?"
5267         prompt.
5268
5269 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5270
5271         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5272         * c-lang.c (c_language_defn): Likewise.
5273         (cplus_language_defn): Likewise.
5274         (asm_language_defn): Likewise.
5275         (minimal_language_defn): Likewise.
5276         * d-lang.c (d_language_defn): Likewise.
5277         * f-lang.c (f_language_defn): Likewise.
5278         * go-lang.c (go_language_defn): Likewise.
5279         * language.c (unknown_language_defn): Likewise.
5280         (auto_language_defn): Likewise.
5281         * language.h (struct language_defn): Remove la_magic field.
5282         (LANG_MAGIC): Delete.
5283         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5284         * objc-lang.c (objc_language_defn): Likewise.
5285         * opencl-lang.c (opencl_language_defn): Likewise.
5286         * p-lang.c (pascal_language_defn): Likewise.
5287         * rust-lang.c (rust_language_defn): Likewise.
5288
5289 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5290
5291         * riscv-tdep.c (riscv_type_align): New function.
5292         (riscv_type_alignment): Delete.
5293         (riscv_arg_location): Use 'type_align'.
5294         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5295
5296 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5297
5298         * gdbtypes.c (type_align): A struct with no non-static fields also
5299         has alignment of 1.
5300
5301 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5302
5303         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5304         component to 0.
5305         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5306         member.
5307         (riscv_struct_info::analyse): New implementation using new
5308         analyse_inner member function.
5309         (riscv_struct_info::field_offset): New member function.
5310         (riscv_struct_info::m_offsets): New member variable.
5311         (riscv_struct_info::analyse_inner): New private member function,
5312         takes the old implementation of riscv_struct_info::analyse but
5313         extended to track field offsets.
5314         (riscv_call_arg_struct): Update the struct folding special cases
5315         to handle cases where empty C++ structs, which are non-zero
5316         length, are found.
5317         (riscv_arg_location): Initialise the length of each location, a
5318         non-zero length now indicates the location is in use.
5319         (riscv_push_dummy_call): Allow for the first location having a
5320         non-zero offset when setting up arguments.
5321         (riscv_return_value): Likewise, but for return values.
5322
5323 2019-04-11  Tom Tromey  <tromey@adacore.com>
5324
5325         * utils.c (internal_vproblem): Make "msg" const.
5326
5327 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5328
5329         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5330         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5331         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5332         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5333
5334 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5335
5336         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5337         function.
5338         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5339         of amd64_collect_native_gregset.
5340         (amd64_linux_nat_target::store_registers): Likewise.
5341
5342 2019-04-10  Tom Tromey  <tom@tromey.com>
5343
5344         * symtab.c (lookup_global_symbol_from_objfile)
5345         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5346         * objfiles.h (class separate_debug_iterator): New.
5347         (class separate_debug_range): New.
5348         (struct objfile) <separate_debug_objfiles>: New method.
5349         (objfile_separate_debug_iterate): Don't declare.
5350         * objfiles.c (separate_debug_iterator::operator++): Rename from
5351         objfile_separate_debug_iterate.
5352         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5353         iterator.
5354         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5355         iterator.
5356
5357 2019-04-10  Tom Tromey  <tom@tromey.com>
5358
5359         * symfile.c (reread_symbols): Remove old comment.
5360         * objfiles.c (free_all_objfiles): Fix a typo.
5361
5362 2019-04-10  Tom Tromey  <tom@tromey.com>
5363
5364         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5365         * minsyms.c (lookup_minimal_symbol): Use foreach.
5366         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5367         (lookup_minimal_symbol_solib_trampoline): Likewise.
5368         * symfile.c (reread_symbols): Use foreach.
5369
5370 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5371             Tom Tromey  <tromey@adacore.com>
5372
5373         PR rust/24414:
5374         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5375         (rust_lex_int_test): Change "value" to be LONGEST.
5376         (rust_lex_tests): Add test for long integer literal.
5377
5378 2019-04-09  Tom Tromey  <tromey@adacore.com>
5379
5380         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5381         to bool.
5382         (extended_remote_target::attach): Update.
5383         (remote_target::remote_notice_new_inferior): Update.
5384         (remote_target::add_current_inferior_and_thread): Update.
5385         * inferior.c (exit_inferior_1): Use "false".
5386         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5387
5388 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5389
5390         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5391         the "start" command.
5392
5393 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5394
5395         * python/py-inferior.c (infpy_thread_from_thread_handle):
5396         Adjust comments to reflect renaming of thread_from_thread_handle
5397         to thread_from_handle.  Adjust keywords.  Fix type error message.
5398         (inferior_object_methods): Add thread_from_handle.  Retain
5399         thread_from_thread_handle, but mark it as deprecated.
5400
5401 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5402
5403         * gdbthread.h (find_thread_by_handle): Revise declaration.
5404         * thread.c (find_thread_by_handle): Likewise.  Adjust
5405         implementation too.
5406         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5407         support for buffer objects as handles.
5408
5409 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5410
5411         * python/py-infthread.c (thpy_thread_handle): New function.
5412         (thread_object_methods): Register thpy_thread_handle.
5413
5414 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5415
5416         * gdbthread.h (thread_to_thread_handle): Declare.
5417         * thread.c (gdbtypes.h): Include.
5418         (thread_to_thread_handle): New function.
5419
5420         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5421         (target_thread_info_to_thread_handle): Declare.
5422         * target.c (target_thread_info_to_thread_handle): New function.
5423         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5424         * target-delegates.c: Regenerate.
5425
5426         * linux-thread-db.c (class thread_db_target): Add method
5427         thread_info_to_thread_handle.
5428         (thread_db_target::thread_info_to_thread_handle): Define.
5429         * remote.c (class remote_target): Add new method
5430         thread_info_to_thread_handle.
5431         (remote_target::thread_info_to_thread_handle): Define.
5432
5433 2019-04-08  Pedro Alves  <palves@redhat.com>
5434
5435         * common/common-exceptions.c (throw_exception): Don't create
5436         named object to throw; throw directly.
5437         (throw_it): Likewise.  Don't initialize gdb_exception::message
5438         here, with new; pass FMT and AP to the ctor instead.
5439         * common/common-exceptions.h: Include <string>.
5440         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5441         const char *, va_list)): New ctor.  Use std::make_shared.
5442         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5443         errors)): Delete.
5444         (gdb_exception_error::gdb_exception_error(enum errors, const char
5445         *, va_list)): New.
5446         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5447         Add assertion.
5448         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5449         errors)): Delete.
5450         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5451         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5452         Add assertion.
5453
5454 2019-04-08  Tom Tromey  <tom@tromey.com>
5455
5456         * valops.c (value_rtti_indirect_type): Replace throw_exception
5457         with throw.
5458         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5459         with throw.
5460         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5461         throw.
5462         * target.c (target_translate_tls_address): Replace throw_exception
5463         with throw.
5464         * stack.c (frame_apply_command_count): Replace throw_exception
5465         with throw.
5466         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5467         throw.
5468         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5469         with throw.
5470         * rs6000-tdep.c (rs6000_frame_cache)
5471         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5472         * remote.c: Replace throw_exception with throw.
5473         * record-full.c (record_full_message, record_full_wait_1)
5474         (record_full_restore): Replace throw_exception with throw.
5475         * record-btrace.c:
5476         (get_thread_current_frame_id, record_btrace_start_replaying)
5477         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5478         (cmd_record_btrace_start): Replace throw_exception with throw.
5479         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5480         throw.
5481         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5482         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5483         * linespec.c:
5484         (find_linespec_symbols): Replace throw_exception with throw.
5485         * infrun.c (displaced_step_prepare, resume): Replace
5486         throw_exception with throw.
5487         * infcmd.c (post_create_inferior): Replace throw_exception with
5488         throw.
5489         * inf-loop.c (inferior_event_handler): Replace throw_exception
5490         with throw.
5491         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5492         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5493         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5494         (get_prev_frame_always, get_frame_pc_if_available)
5495         (get_frame_address_in_block_if_available, get_frame_language):
5496         Replace throw_exception with throw.
5497         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5498         throw_exception with throw.
5499         * eval.c (fetch_subexp_value, evaluate_var_value)
5500         (evaluate_funcall, evaluate_subexp_standard): Replace
5501         throw_exception with throw.
5502         * dwarf2loc.c (call_site_find_chain)
5503         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5504         Replace throw_exception with throw.
5505         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5506         with throw.
5507         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5508         throw.
5509         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5510         * completer.c (complete_line_internal): Replace throw_exception
5511         with throw.
5512         * compile/compile-object-run.c (compile_object_run): Replace
5513         throw_exception with throw.
5514         * cli/cli-script.c (process_next_line): Replace throw_exception
5515         with throw.
5516         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5517         (btrace_enable, btrace_maint_update_pt_packets): Replace
5518         throw_exception with throw.
5519         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5520         throw_exception with throw.
5521         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5522         throw_exception with throw.
5523         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5524         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5525         * aarch64-tdep.c (aarch64_make_prologue_cache)
5526         (aarch64_make_stub_cache): Replace throw_exception with throw.
5527
5528 2019-04-08  Tom Tromey  <tom@tromey.com>
5529
5530         * common/common-exceptions.c (throw_exception): Rename from
5531         throw_exception_cxx.  Remove old copy.  Make argument const.
5532         (throw_it): Create and throw exception objects directly.
5533         * common/common-exceptions.h (throw_exception): Make argument
5534         const.
5535         (struct gdb_exception_error): Add constructor.
5536         (struct gdb_exception_quit): Add constructor.
5537
5538 2019-04-08  Tom Tromey  <tom@tromey.com>
5539
5540         * common/common-exceptions.h (exception_rethrow): Don't declare.
5541         (TRY_SJLJ): Update comment.
5542         (TRY, CATCH, END_CATCH): Remove.
5543         * common/common-exceptions.c (exception_rethrow): Remove.
5544
5545 2019-04-08  Tom Tromey  <tom@tromey.com>
5546
5547         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5548         Remove.
5549         (gdb_exception_error): Rename from
5550         gdb_exception_RETURN_MASK_ERROR.
5551         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5552         (gdb_quit_bad_alloc): Update.
5553         * aarch64-tdep.c: Update.
5554         * ada-lang.c: Update.
5555         * ada-typeprint.c: Update.
5556         * ada-valprint.c: Update.
5557         * amd64-tdep.c: Update.
5558         * arch-utils.c: Update.
5559         * break-catch-throw.c: Update.
5560         * breakpoint.c: Update.
5561         * btrace.c: Update.
5562         * c-varobj.c: Update.
5563         * cli/cli-cmds.c: Update.
5564         * cli/cli-interp.c: Update.
5565         * cli/cli-script.c: Update.
5566         * common/common-exceptions.c: Update.
5567         * common/new-op.c: Update.
5568         * common/selftest.c: Update.
5569         * compile/compile-c-symbols.c: Update.
5570         * compile/compile-cplus-symbols.c: Update.
5571         * compile/compile-object-load.c: Update.
5572         * compile/compile-object-run.c: Update.
5573         * completer.c: Update.
5574         * corelow.c: Update.
5575         * cp-abi.c: Update.
5576         * cp-support.c: Update.
5577         * cp-valprint.c: Update.
5578         * darwin-nat.c: Update.
5579         * disasm-selftests.c: Update.
5580         * dtrace-probe.c: Update.
5581         * dwarf-index-cache.c: Update.
5582         * dwarf-index-write.c: Update.
5583         * dwarf2-frame-tailcall.c: Update.
5584         * dwarf2-frame.c: Update.
5585         * dwarf2loc.c: Update.
5586         * dwarf2read.c: Update.
5587         * eval.c: Update.
5588         * event-loop.c: Update.
5589         * event-top.c: Update.
5590         * exec.c: Update.
5591         * f-valprint.c: Update.
5592         * fbsd-tdep.c: Update.
5593         * frame-unwind.c: Update.
5594         * frame.c: Update.
5595         * gdbtypes.c: Update.
5596         * gnu-v3-abi.c: Update.
5597         * guile/guile-internal.h: Update.
5598         * guile/scm-block.c: Update.
5599         * guile/scm-breakpoint.c: Update.
5600         * guile/scm-cmd.c: Update.
5601         * guile/scm-disasm.c: Update.
5602         * guile/scm-frame.c: Update.
5603         * guile/scm-lazy-string.c: Update.
5604         * guile/scm-math.c: Update.
5605         * guile/scm-param.c: Update.
5606         * guile/scm-ports.c: Update.
5607         * guile/scm-pretty-print.c: Update.
5608         * guile/scm-symbol.c: Update.
5609         * guile/scm-symtab.c: Update.
5610         * guile/scm-type.c: Update.
5611         * guile/scm-value.c: Update.
5612         * i386-linux-tdep.c: Update.
5613         * i386-tdep.c: Update.
5614         * inf-loop.c: Update.
5615         * infcall.c: Update.
5616         * infcmd.c: Update.
5617         * infrun.c: Update.
5618         * jit.c: Update.
5619         * language.c: Update.
5620         * linespec.c: Update.
5621         * linux-fork.c: Update.
5622         * linux-nat.c: Update.
5623         * linux-tdep.c: Update.
5624         * linux-thread-db.c: Update.
5625         * main.c: Update.
5626         * mi/mi-cmd-break.c: Update.
5627         * mi/mi-cmd-stack.c: Update.
5628         * mi/mi-interp.c: Update.
5629         * mi/mi-main.c: Update.
5630         * objc-lang.c: Update.
5631         * p-valprint.c: Update.
5632         * parse.c: Update.
5633         * ppc-linux-tdep.c: Update.
5634         * printcmd.c: Update.
5635         * python/py-arch.c: Update.
5636         * python/py-breakpoint.c: Update.
5637         * python/py-cmd.c: Update.
5638         * python/py-finishbreakpoint.c: Update.
5639         * python/py-frame.c: Update.
5640         * python/py-framefilter.c: Update.
5641         * python/py-gdb-readline.c: Update.
5642         * python/py-inferior.c: Update.
5643         * python/py-infthread.c: Update.
5644         * python/py-lazy-string.c: Update.
5645         * python/py-linetable.c: Update.
5646         * python/py-objfile.c: Update.
5647         * python/py-param.c: Update.
5648         * python/py-prettyprint.c: Update.
5649         * python/py-progspace.c: Update.
5650         * python/py-record-btrace.c: Update.
5651         * python/py-record.c: Update.
5652         * python/py-symbol.c: Update.
5653         * python/py-type.c: Update.
5654         * python/py-unwind.c: Update.
5655         * python/py-utils.c: Update.
5656         * python/py-value.c: Update.
5657         * python/python.c: Update.
5658         * record-btrace.c: Update.
5659         * record-full.c: Update.
5660         * remote-fileio.c: Update.
5661         * remote.c: Update.
5662         * riscv-tdep.c: Update.
5663         * rs6000-aix-tdep.c: Update.
5664         * rs6000-tdep.c: Update.
5665         * rust-exp.y: Update.
5666         * rust-lang.c: Update.
5667         * s390-tdep.c: Update.
5668         * selftest-arch.c: Update.
5669         * solib-dsbt.c: Update.
5670         * solib-frv.c: Update.
5671         * solib-spu.c: Update.
5672         * solib-svr4.c: Update.
5673         * solib.c: Update.
5674         * sparc64-linux-tdep.c: Update.
5675         * stack.c: Update.
5676         * symfile-mem.c: Update.
5677         * symmisc.c: Update.
5678         * target.c: Update.
5679         * thread.c: Update.
5680         * top.c: Update.
5681         * tracefile-tfile.c: Update.
5682         * tui/tui.c: Update.
5683         * typeprint.c: Update.
5684         * unittests/cli-utils-selftests.c: Update.
5685         * unittests/parse-connection-spec-selftests.c: Update.
5686         * valops.c: Update.
5687         * valprint.c: Update.
5688         * value.c: Update.
5689         * varobj.c: Update.
5690         * windows-nat.c: Update.
5691         * x86-linux-nat.c: Update.
5692         * xml-support.c: Update.
5693
5694 2019-04-08  Tom Tromey  <tom@tromey.com>
5695
5696         * xml-support.c: Use C++ exception handling.
5697         * x86-linux-nat.c: Use C++ exception handling.
5698         * windows-nat.c: Use C++ exception handling.
5699         * varobj.c: Use C++ exception handling.
5700         * value.c: Use C++ exception handling.
5701         * valprint.c: Use C++ exception handling.
5702         * valops.c: Use C++ exception handling.
5703         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5704         handling.
5705         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5706         * typeprint.c: Use C++ exception handling.
5707         * tui/tui.c: Use C++ exception handling.
5708         * tracefile-tfile.c: Use C++ exception handling.
5709         * top.c: Use C++ exception handling.
5710         * thread.c: Use C++ exception handling.
5711         * target.c: Use C++ exception handling.
5712         * symmisc.c: Use C++ exception handling.
5713         * symfile-mem.c: Use C++ exception handling.
5714         * stack.c: Use C++ exception handling.
5715         * sparc64-linux-tdep.c: Use C++ exception handling.
5716         * solib.c: Use C++ exception handling.
5717         * solib-svr4.c: Use C++ exception handling.
5718         * solib-spu.c: Use C++ exception handling.
5719         * solib-frv.c: Use C++ exception handling.
5720         * solib-dsbt.c: Use C++ exception handling.
5721         * selftest-arch.c: Use C++ exception handling.
5722         * s390-tdep.c: Use C++ exception handling.
5723         * rust-lang.c: Use C++ exception handling.
5724         * rust-exp.y: Use C++ exception handling.
5725         * rs6000-tdep.c: Use C++ exception handling.
5726         * rs6000-aix-tdep.c: Use C++ exception handling.
5727         * riscv-tdep.c: Use C++ exception handling.
5728         * remote.c: Use C++ exception handling.
5729         * remote-fileio.c: Use C++ exception handling.
5730         * record-full.c: Use C++ exception handling.
5731         * record-btrace.c: Use C++ exception handling.
5732         * python/python.c: Use C++ exception handling.
5733         * python/py-value.c: Use C++ exception handling.
5734         * python/py-utils.c: Use C++ exception handling.
5735         * python/py-unwind.c: Use C++ exception handling.
5736         * python/py-type.c: Use C++ exception handling.
5737         * python/py-symbol.c: Use C++ exception handling.
5738         * python/py-record.c: Use C++ exception handling.
5739         * python/py-record-btrace.c: Use C++ exception handling.
5740         * python/py-progspace.c: Use C++ exception handling.
5741         * python/py-prettyprint.c: Use C++ exception handling.
5742         * python/py-param.c: Use C++ exception handling.
5743         * python/py-objfile.c: Use C++ exception handling.
5744         * python/py-linetable.c: Use C++ exception handling.
5745         * python/py-lazy-string.c: Use C++ exception handling.
5746         * python/py-infthread.c: Use C++ exception handling.
5747         * python/py-inferior.c: Use C++ exception handling.
5748         * python/py-gdb-readline.c: Use C++ exception handling.
5749         * python/py-framefilter.c: Use C++ exception handling.
5750         * python/py-frame.c: Use C++ exception handling.
5751         * python/py-finishbreakpoint.c: Use C++ exception handling.
5752         * python/py-cmd.c: Use C++ exception handling.
5753         * python/py-breakpoint.c: Use C++ exception handling.
5754         * python/py-arch.c: Use C++ exception handling.
5755         * printcmd.c: Use C++ exception handling.
5756         * ppc-linux-tdep.c: Use C++ exception handling.
5757         * parse.c: Use C++ exception handling.
5758         * p-valprint.c: Use C++ exception handling.
5759         * objc-lang.c: Use C++ exception handling.
5760         * mi/mi-main.c: Use C++ exception handling.
5761         * mi/mi-interp.c: Use C++ exception handling.
5762         * mi/mi-cmd-stack.c: Use C++ exception handling.
5763         * mi/mi-cmd-break.c: Use C++ exception handling.
5764         * main.c: Use C++ exception handling.
5765         * linux-thread-db.c: Use C++ exception handling.
5766         * linux-tdep.c: Use C++ exception handling.
5767         * linux-nat.c: Use C++ exception handling.
5768         * linux-fork.c: Use C++ exception handling.
5769         * linespec.c: Use C++ exception handling.
5770         * language.c: Use C++ exception handling.
5771         * jit.c: Use C++ exception handling.
5772         * infrun.c: Use C++ exception handling.
5773         * infcmd.c: Use C++ exception handling.
5774         * infcall.c: Use C++ exception handling.
5775         * inf-loop.c: Use C++ exception handling.
5776         * i386-tdep.c: Use C++ exception handling.
5777         * i386-linux-tdep.c: Use C++ exception handling.
5778         * guile/scm-value.c: Use C++ exception handling.
5779         * guile/scm-type.c: Use C++ exception handling.
5780         * guile/scm-symtab.c: Use C++ exception handling.
5781         * guile/scm-symbol.c: Use C++ exception handling.
5782         * guile/scm-pretty-print.c: Use C++ exception handling.
5783         * guile/scm-ports.c: Use C++ exception handling.
5784         * guile/scm-param.c: Use C++ exception handling.
5785         * guile/scm-math.c: Use C++ exception handling.
5786         * guile/scm-lazy-string.c: Use C++ exception handling.
5787         * guile/scm-frame.c: Use C++ exception handling.
5788         * guile/scm-disasm.c: Use C++ exception handling.
5789         * guile/scm-cmd.c: Use C++ exception handling.
5790         * guile/scm-breakpoint.c: Use C++ exception handling.
5791         * guile/scm-block.c: Use C++ exception handling.
5792         * guile/guile-internal.h: Use C++ exception handling.
5793         * gnu-v3-abi.c: Use C++ exception handling.
5794         * gdbtypes.c: Use C++ exception handling.
5795         * frame.c: Use C++ exception handling.
5796         * frame-unwind.c: Use C++ exception handling.
5797         * fbsd-tdep.c: Use C++ exception handling.
5798         * f-valprint.c: Use C++ exception handling.
5799         * exec.c: Use C++ exception handling.
5800         * event-top.c: Use C++ exception handling.
5801         * event-loop.c: Use C++ exception handling.
5802         * eval.c: Use C++ exception handling.
5803         * dwarf2read.c: Use C++ exception handling.
5804         * dwarf2loc.c: Use C++ exception handling.
5805         * dwarf2-frame.c: Use C++ exception handling.
5806         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5807         * dwarf-index-write.c: Use C++ exception handling.
5808         * dwarf-index-cache.c: Use C++ exception handling.
5809         * dtrace-probe.c: Use C++ exception handling.
5810         * disasm-selftests.c: Use C++ exception handling.
5811         * darwin-nat.c: Use C++ exception handling.
5812         * cp-valprint.c: Use C++ exception handling.
5813         * cp-support.c: Use C++ exception handling.
5814         * cp-abi.c: Use C++ exception handling.
5815         * corelow.c: Use C++ exception handling.
5816         * completer.c: Use C++ exception handling.
5817         * compile/compile-object-run.c: Use C++ exception handling.
5818         * compile/compile-object-load.c: Use C++ exception handling.
5819         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5820         * compile/compile-c-symbols.c: Use C++ exception handling.
5821         * common/selftest.c: Use C++ exception handling.
5822         * common/new-op.c: Use C++ exception handling.
5823         * cli/cli-script.c: Use C++ exception handling.
5824         * cli/cli-interp.c: Use C++ exception handling.
5825         * cli/cli-cmds.c: Use C++ exception handling.
5826         * c-varobj.c: Use C++ exception handling.
5827         * btrace.c: Use C++ exception handling.
5828         * breakpoint.c: Use C++ exception handling.
5829         * break-catch-throw.c: Use C++ exception handling.
5830         * arch-utils.c: Use C++ exception handling.
5831         * amd64-tdep.c: Use C++ exception handling.
5832         * ada-valprint.c: Use C++ exception handling.
5833         * ada-typeprint.c: Use C++ exception handling.
5834         * ada-lang.c: Use C++ exception handling.
5835         * aarch64-tdep.c: Use C++ exception handling.
5836
5837 2019-04-08  Tom Tromey  <tom@tromey.com>
5838
5839         * xml-support.c (gdb_xml_parser::parse): Update.
5840         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5841         * value.c (show_convenience): Update.
5842         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5843         (test_parse_flags_qcs): Update.
5844         * thread.c (thr_try_catch_cmd): Update.
5845         * target.c (target_translate_tls_address): Update.
5846         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5847         (info_frame_command_core, frame_apply_command_count): Update.
5848         * rust-exp.y (rust_lex_exception_test): Update.
5849         * riscv-tdep.c (riscv_print_one_register_info): Update.
5850         * remote.c (remote_target::enable_btrace): Update.
5851         * record-btrace.c (record_btrace_enable_warn): Update.
5852         * python/py-utils.c (gdbpy_convert_exception): Update.
5853         * printcmd.c (do_one_display, print_variable_and_value): Update.
5854         * mi/mi-main.c (mi_print_exception): Update.
5855         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5856         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5857         * linux-nat.c (linux_nat_target::attach): Update.
5858         * linux-fork.c (class scoped_switch_fork_info): Update.
5859         * infrun.c (displaced_step_prepare): Update.
5860         * infcall.c (call_function_by_hand_dummy): Update.
5861         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5862         * gnu-v3-abi.c (print_one_vtable): Update.
5863         * frame.c (get_prev_frame_always): Update.
5864         * f-valprint.c (info_common_command_for_block): Update.
5865         * exec.c (try_open_exec_file): Update.
5866         * exceptions.c (print_exception, exception_print)
5867         (exception_fprintf, exception_print_same): Update.
5868         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5869         * dwarf-index-cache.c (index_cache::store)
5870         (index_cache::lookup_gdb_index): Update.
5871         * darwin-nat.c (maybe_cache_shell): Update.
5872         * cp-valprint.c (cp_print_value_fields): Update.
5873         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5874         (gcc_cplus_symbol_address): Update.
5875         * compile/compile-c-symbols.c (gcc_convert_symbol)
5876         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5877         * common/selftest.c: Update.
5878         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5879         a std::string.
5880         (exception_try_scope_entry, exception_try_scope_exit): Don't
5881         declare.
5882         (struct exception_try_scope): Remove.
5883         (TRY): Don't use exception_try_scope.
5884         (struct gdb_exception): Add constructor, operator=.
5885         <what>: New method.
5886         (struct gdb_exception_RETURN_MASK_ALL)
5887         (struct gdb_exception_RETURN_MASK_ERROR)
5888         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5889         (struct gdb_quit_bad_alloc): Update.
5890         * common/common-exceptions.c (exception_none): Change
5891         initializer.
5892         (struct catcher) <state, exception>: Initialize inline.
5893         <prev>: Remove member.
5894         (current_catcher): Remove.
5895         (catchers): New global.
5896         (exceptions_state_mc_init): Simplify.
5897         (catcher_pop): Remove.
5898         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5899         (try_scope_depth, exception_try_scope_entry)
5900         (exception_try_scope_exit): Remove.
5901         (throw_exception_sjlj): Update.
5902         (exception_messages, exception_messages_size): Remove.
5903         (throw_it): Simplify.
5904         (gdb_exception_sliced_copy): Remove.
5905         (throw_exception_cxx): Update.
5906         * cli/cli-script.c (script_from_file): Update.
5907         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5908         Update.
5909         * ada-valprint.c (ada_val_print): Update.
5910         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5911         (create_excep_cond_exprs): Update.
5912
5913 2019-04-08  Tom Tromey  <tom@tromey.com>
5914
5915         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5916         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5917         (TRY, CATCH, END_CATCH): Remove some definitions.
5918         * common/common-exceptions.c: Don't use GDB_XCPT.
5919         (catcher_list_size): Remove.
5920         (throw_exception, throw_it): Simplify.
5921
5922 2019-04-05  Tom Tromey  <tom@tromey.com>
5923
5924         Revert the header-sorting patch.
5925         * ft32-tdep.c: Revert.
5926         * frv-tdep.c: Revert.
5927         * frv-linux-tdep.c: Revert.
5928         * frame.c: Revert.
5929         * frame-unwind.c: Revert.
5930         * frame-base.c: Revert.
5931         * fork-child.c: Revert.
5932         * findvar.c: Revert.
5933         * findcmd.c: Revert.
5934         * filesystem.c: Revert.
5935         * filename-seen-cache.h: Revert.
5936         * filename-seen-cache.c: Revert.
5937         * fbsd-tdep.c: Revert.
5938         * fbsd-nat.h: Revert.
5939         * fbsd-nat.c: Revert.
5940         * f-valprint.c: Revert.
5941         * f-typeprint.c: Revert.
5942         * f-lang.c: Revert.
5943         * extension.h: Revert.
5944         * extension.c: Revert.
5945         * extension-priv.h: Revert.
5946         * expprint.c: Revert.
5947         * exec.h: Revert.
5948         * exec.c: Revert.
5949         * exceptions.c: Revert.
5950         * event-top.c: Revert.
5951         * event-loop.c: Revert.
5952         * eval.c: Revert.
5953         * elfread.c: Revert.
5954         * dwarf2read.h: Revert.
5955         * dwarf2read.c: Revert.
5956         * dwarf2loc.c: Revert.
5957         * dwarf2expr.h: Revert.
5958         * dwarf2expr.c: Revert.
5959         * dwarf2-frame.c: Revert.
5960         * dwarf2-frame-tailcall.c: Revert.
5961         * dwarf-index-write.h: Revert.
5962         * dwarf-index-write.c: Revert.
5963         * dwarf-index-common.c: Revert.
5964         * dwarf-index-cache.h: Revert.
5965         * dwarf-index-cache.c: Revert.
5966         * dummy-frame.c: Revert.
5967         * dtrace-probe.c: Revert.
5968         * disasm.h: Revert.
5969         * disasm.c: Revert.
5970         * disasm-selftests.c: Revert.
5971         * dictionary.c: Revert.
5972         * dicos-tdep.c: Revert.
5973         * demangle.c: Revert.
5974         * dcache.h: Revert.
5975         * dcache.c: Revert.
5976         * darwin-nat.h: Revert.
5977         * darwin-nat.c: Revert.
5978         * darwin-nat-info.c: Revert.
5979         * d-valprint.c: Revert.
5980         * d-namespace.c: Revert.
5981         * d-lang.c: Revert.
5982         * ctf.c: Revert.
5983         * csky-tdep.c: Revert.
5984         * csky-linux-tdep.c: Revert.
5985         * cris-tdep.c: Revert.
5986         * cris-linux-tdep.c: Revert.
5987         * cp-valprint.c: Revert.
5988         * cp-support.c: Revert.
5989         * cp-namespace.c: Revert.
5990         * cp-abi.c: Revert.
5991         * corelow.c: Revert.
5992         * corefile.c: Revert.
5993         * continuations.c: Revert.
5994         * completer.h: Revert.
5995         * completer.c: Revert.
5996         * complaints.c: Revert.
5997         * coffread.c: Revert.
5998         * coff-pe-read.c: Revert.
5999         * cli-out.h: Revert.
6000         * cli-out.c: Revert.
6001         * charset.c: Revert.
6002         * c-varobj.c: Revert.
6003         * c-valprint.c: Revert.
6004         * c-typeprint.c: Revert.
6005         * c-lang.c: Revert.
6006         * buildsym.c: Revert.
6007         * buildsym-legacy.c: Revert.
6008         * build-id.h: Revert.
6009         * build-id.c: Revert.
6010         * btrace.c: Revert.
6011         * bsd-uthread.c: Revert.
6012         * breakpoint.h: Revert.
6013         * breakpoint.c: Revert.
6014         * break-catch-throw.c: Revert.
6015         * break-catch-syscall.c: Revert.
6016         * break-catch-sig.c: Revert.
6017         * blockframe.c: Revert.
6018         * block.c: Revert.
6019         * bfin-tdep.c: Revert.
6020         * bfin-linux-tdep.c: Revert.
6021         * bfd-target.c: Revert.
6022         * bcache.c: Revert.
6023         * ax-general.c: Revert.
6024         * ax-gdb.h: Revert.
6025         * ax-gdb.c: Revert.
6026         * avr-tdep.c: Revert.
6027         * auxv.c: Revert.
6028         * auto-load.c: Revert.
6029         * arm-wince-tdep.c: Revert.
6030         * arm-tdep.c: Revert.
6031         * arm-symbian-tdep.c: Revert.
6032         * arm-pikeos-tdep.c: Revert.
6033         * arm-obsd-tdep.c: Revert.
6034         * arm-nbsd-tdep.c: Revert.
6035         * arm-nbsd-nat.c: Revert.
6036         * arm-linux-tdep.c: Revert.
6037         * arm-linux-nat.c: Revert.
6038         * arm-fbsd-tdep.c: Revert.
6039         * arm-fbsd-nat.c: Revert.
6040         * arm-bsd-tdep.c: Revert.
6041         * arch-utils.c: Revert.
6042         * arc-tdep.c: Revert.
6043         * arc-newlib-tdep.c: Revert.
6044         * annotate.h: Revert.
6045         * annotate.c: Revert.
6046         * amd64-windows-tdep.c: Revert.
6047         * amd64-windows-nat.c: Revert.
6048         * amd64-tdep.c: Revert.
6049         * amd64-sol2-tdep.c: Revert.
6050         * amd64-obsd-tdep.c: Revert.
6051         * amd64-obsd-nat.c: Revert.
6052         * amd64-nbsd-tdep.c: Revert.
6053         * amd64-nbsd-nat.c: Revert.
6054         * amd64-nat.c: Revert.
6055         * amd64-linux-tdep.c: Revert.
6056         * amd64-linux-nat.c: Revert.
6057         * amd64-fbsd-tdep.c: Revert.
6058         * amd64-fbsd-nat.c: Revert.
6059         * amd64-dicos-tdep.c: Revert.
6060         * amd64-darwin-tdep.c: Revert.
6061         * amd64-bsd-nat.c: Revert.
6062         * alpha-tdep.c: Revert.
6063         * alpha-obsd-tdep.c: Revert.
6064         * alpha-nbsd-tdep.c: Revert.
6065         * alpha-mdebug-tdep.c: Revert.
6066         * alpha-linux-tdep.c: Revert.
6067         * alpha-linux-nat.c: Revert.
6068         * alpha-bsd-tdep.c: Revert.
6069         * alpha-bsd-nat.c: Revert.
6070         * aix-thread.c: Revert.
6071         * agent.c: Revert.
6072         * addrmap.c: Revert.
6073         * ada-varobj.c: Revert.
6074         * ada-valprint.c: Revert.
6075         * ada-typeprint.c: Revert.
6076         * ada-tasks.c: Revert.
6077         * ada-lang.c: Revert.
6078         * aarch64-tdep.c: Revert.
6079         * aarch64-ravenscar-thread.c: Revert.
6080         * aarch64-newlib-tdep.c: Revert.
6081         * aarch64-linux-tdep.c: Revert.
6082         * aarch64-linux-nat.c: Revert.
6083         * aarch64-fbsd-tdep.c: Revert.
6084         * aarch64-fbsd-nat.c: Revert.
6085         * aarch32-linux-nat.c: Revert.
6086
6087 2019-04-05  Tom Tromey  <tom@tromey.com>
6088
6089         * ft32-tdep.c: Sort headers.
6090         * frv-tdep.c: Sort headers.
6091         * frv-linux-tdep.c: Sort headers.
6092         * frame.c: Sort headers.
6093         * frame-unwind.c: Sort headers.
6094         * frame-base.c: Sort headers.
6095         * fork-child.c: Sort headers.
6096         * findvar.c: Sort headers.
6097         * findcmd.c: Sort headers.
6098         * filesystem.c: Sort headers.
6099         * filename-seen-cache.h: Sort headers.
6100         * filename-seen-cache.c: Sort headers.
6101         * fbsd-tdep.c: Sort headers.
6102         * fbsd-nat.h: Sort headers.
6103         * fbsd-nat.c: Sort headers.
6104         * f-valprint.c: Sort headers.
6105         * f-typeprint.c: Sort headers.
6106         * f-lang.c: Sort headers.
6107         * extension.h: Sort headers.
6108         * extension.c: Sort headers.
6109         * extension-priv.h: Sort headers.
6110         * expprint.c: Sort headers.
6111         * exec.h: Sort headers.
6112         * exec.c: Sort headers.
6113         * exceptions.c: Sort headers.
6114         * event-top.c: Sort headers.
6115         * event-loop.c: Sort headers.
6116         * eval.c: Sort headers.
6117         * elfread.c: Sort headers.
6118         * dwarf2read.h: Sort headers.
6119         * dwarf2read.c: Sort headers.
6120         * dwarf2loc.c: Sort headers.
6121         * dwarf2expr.h: Sort headers.
6122         * dwarf2expr.c: Sort headers.
6123         * dwarf2-frame.c: Sort headers.
6124         * dwarf2-frame-tailcall.c: Sort headers.
6125         * dwarf-index-write.h: Sort headers.
6126         * dwarf-index-write.c: Sort headers.
6127         * dwarf-index-common.c: Sort headers.
6128         * dwarf-index-cache.h: Sort headers.
6129         * dwarf-index-cache.c: Sort headers.
6130         * dummy-frame.c: Sort headers.
6131         * dtrace-probe.c: Sort headers.
6132         * disasm.h: Sort headers.
6133         * disasm.c: Sort headers.
6134         * disasm-selftests.c: Sort headers.
6135         * dictionary.c: Sort headers.
6136         * dicos-tdep.c: Sort headers.
6137         * demangle.c: Sort headers.
6138         * dcache.h: Sort headers.
6139         * dcache.c: Sort headers.
6140         * darwin-nat.h: Sort headers.
6141         * darwin-nat.c: Sort headers.
6142         * darwin-nat-info.c: Sort headers.
6143         * d-valprint.c: Sort headers.
6144         * d-namespace.c: Sort headers.
6145         * d-lang.c: Sort headers.
6146         * ctf.c: Sort headers.
6147         * csky-tdep.c: Sort headers.
6148         * csky-linux-tdep.c: Sort headers.
6149         * cris-tdep.c: Sort headers.
6150         * cris-linux-tdep.c: Sort headers.
6151         * cp-valprint.c: Sort headers.
6152         * cp-support.c: Sort headers.
6153         * cp-namespace.c: Sort headers.
6154         * cp-abi.c: Sort headers.
6155         * corelow.c: Sort headers.
6156         * corefile.c: Sort headers.
6157         * continuations.c: Sort headers.
6158         * completer.h: Sort headers.
6159         * completer.c: Sort headers.
6160         * complaints.c: Sort headers.
6161         * coffread.c: Sort headers.
6162         * coff-pe-read.c: Sort headers.
6163         * cli-out.h: Sort headers.
6164         * cli-out.c: Sort headers.
6165         * charset.c: Sort headers.
6166         * c-varobj.c: Sort headers.
6167         * c-valprint.c: Sort headers.
6168         * c-typeprint.c: Sort headers.
6169         * c-lang.c: Sort headers.
6170         * buildsym.c: Sort headers.
6171         * buildsym-legacy.c: Sort headers.
6172         * build-id.h: Sort headers.
6173         * build-id.c: Sort headers.
6174         * btrace.c: Sort headers.
6175         * bsd-uthread.c: Sort headers.
6176         * breakpoint.h: Sort headers.
6177         * breakpoint.c: Sort headers.
6178         * break-catch-throw.c: Sort headers.
6179         * break-catch-syscall.c: Sort headers.
6180         * break-catch-sig.c: Sort headers.
6181         * blockframe.c: Sort headers.
6182         * block.c: Sort headers.
6183         * bfin-tdep.c: Sort headers.
6184         * bfin-linux-tdep.c: Sort headers.
6185         * bfd-target.c: Sort headers.
6186         * bcache.c: Sort headers.
6187         * ax-general.c: Sort headers.
6188         * ax-gdb.h: Sort headers.
6189         * ax-gdb.c: Sort headers.
6190         * avr-tdep.c: Sort headers.
6191         * auxv.c: Sort headers.
6192         * auto-load.c: Sort headers.
6193         * arm-wince-tdep.c: Sort headers.
6194         * arm-tdep.c: Sort headers.
6195         * arm-symbian-tdep.c: Sort headers.
6196         * arm-pikeos-tdep.c: Sort headers.
6197         * arm-obsd-tdep.c: Sort headers.
6198         * arm-nbsd-tdep.c: Sort headers.
6199         * arm-nbsd-nat.c: Sort headers.
6200         * arm-linux-tdep.c: Sort headers.
6201         * arm-linux-nat.c: Sort headers.
6202         * arm-fbsd-tdep.c: Sort headers.
6203         * arm-fbsd-nat.c: Sort headers.
6204         * arm-bsd-tdep.c: Sort headers.
6205         * arch-utils.c: Sort headers.
6206         * arc-tdep.c: Sort headers.
6207         * arc-newlib-tdep.c: Sort headers.
6208         * annotate.h: Sort headers.
6209         * annotate.c: Sort headers.
6210         * amd64-windows-tdep.c: Sort headers.
6211         * amd64-windows-nat.c: Sort headers.
6212         * amd64-tdep.c: Sort headers.
6213         * amd64-sol2-tdep.c: Sort headers.
6214         * amd64-obsd-tdep.c: Sort headers.
6215         * amd64-obsd-nat.c: Sort headers.
6216         * amd64-nbsd-tdep.c: Sort headers.
6217         * amd64-nbsd-nat.c: Sort headers.
6218         * amd64-nat.c: Sort headers.
6219         * amd64-linux-tdep.c: Sort headers.
6220         * amd64-linux-nat.c: Sort headers.
6221         * amd64-fbsd-tdep.c: Sort headers.
6222         * amd64-fbsd-nat.c: Sort headers.
6223         * amd64-dicos-tdep.c: Sort headers.
6224         * amd64-darwin-tdep.c: Sort headers.
6225         * amd64-bsd-nat.c: Sort headers.
6226         * alpha-tdep.c: Sort headers.
6227         * alpha-obsd-tdep.c: Sort headers.
6228         * alpha-nbsd-tdep.c: Sort headers.
6229         * alpha-mdebug-tdep.c: Sort headers.
6230         * alpha-linux-tdep.c: Sort headers.
6231         * alpha-linux-nat.c: Sort headers.
6232         * alpha-bsd-tdep.c: Sort headers.
6233         * alpha-bsd-nat.c: Sort headers.
6234         * aix-thread.c: Sort headers.
6235         * agent.c: Sort headers.
6236         * addrmap.c: Sort headers.
6237         * ada-varobj.c: Sort headers.
6238         * ada-valprint.c: Sort headers.
6239         * ada-typeprint.c: Sort headers.
6240         * ada-tasks.c: Sort headers.
6241         * ada-lang.c: Sort headers.
6242         * aarch64-tdep.c: Sort headers.
6243         * aarch64-ravenscar-thread.c: Sort headers.
6244         * aarch64-newlib-tdep.c: Sort headers.
6245         * aarch64-linux-tdep.c: Sort headers.
6246         * aarch64-linux-nat.c: Sort headers.
6247         * aarch64-fbsd-tdep.c: Sort headers.
6248         * aarch64-fbsd-nat.c: Sort headers.
6249         * aarch32-linux-nat.c: Sort headers.
6250
6251 2019-04-04  Tom Tromey  <tom@tromey.com>
6252
6253         * varobj.c (varobj_create): Update.
6254         * rust-exp.y (struct rust_parser) <update_innermost_block,
6255         lookup_symbol>: New methods.
6256         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6257         Rename.
6258         (rust_parser::rust_lookup_type)
6259         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6260         * printcmd.c (display_command, do_one_display): Update.
6261         * parser-defs.h (struct parser_state) <parser_state>: Add
6262         "tracker" parameter.
6263         (block_tracker): New member.
6264         (class innermost_block_tracker) <innermost_block_tracker>: Add
6265         "types" parameter.
6266         <reset>: Remove method.
6267         (innermost_block): Don't declare.
6268         (null_post_parser): Update.
6269         * parse.c (innermost_block): Remove global.
6270         (write_dollar_variable): Update.
6271         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6272         Remove "tracker_types" parameter.
6273         (parse_expression): Add "tracker" parameter.
6274         (parse_expression_for_completion): Update.
6275         (null_post_parser): Add "tracker" parameter.
6276         * p-exp.y: Update rules.
6277         * m2-exp.y: Update rules.
6278         * language.h (struct language_defn) <la_post_parser>: Add
6279         "tracker" parameter.
6280         * go-exp.y: Update rules.
6281         * f-exp.y: Update rules.
6282         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6283         parameter.
6284         * d-exp.y: Update rules.
6285         * c-exp.y: Update rules.
6286         * breakpoint.c (set_breakpoint_condition): Create an
6287         innermost_block_tracker.
6288         (watch_command_1): Likewise.
6289         * ada-lang.c (resolve): Add "tracker" parameter.
6290         (resolve_subexp): Likewise.
6291         * ada-exp.y (write_var_from_sym): Update.
6292
6293 2019-04-04  Tom Tromey  <tom@tromey.com>
6294
6295         * type-stack.h: New file.
6296         * type-stack.c: New file.
6297         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6298         type-stack.h.
6299         (insert_into_type_stack, insert_type, push_type, push_type_int)
6300         (insert_type_address_space, pop_type, pop_type_int)
6301         (pop_typelist, pop_type_stack, append_type_stack)
6302         (push_type_stack, get_type_stack, push_typelist)
6303         (follow_type_instance_flags, follow_types): Don't declare.
6304         * parse.c (type_stack): Remove global.
6305         (parse_exp_in_context): Update.
6306         (insert_into_type_stack, insert_type, push_type, push_type_int)
6307         (insert_type_address_space, pop_type, pop_type_int)
6308         (pop_typelist, pop_type_stack, append_type_stack)
6309         (push_type_stack, get_type_stack, push_typelist)
6310         (follow_type_instance_flags, follow_types): Remove (moved to
6311         type-stack.c).
6312         * f-exp.y (type_stack): New global.
6313         Update rules.
6314         (push_kind_type, f_parse): Update.
6315         * d-exp.y (type_stack): New global.
6316         Update rules.
6317         (d_parse): Update.
6318         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6319         Update rules.
6320         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6321         (HFILES_NO_SRCDIR): Add type-stack.h.
6322
6323 2019-04-04  Tom Tromey  <tom@tromey.com>
6324
6325         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6326         (rust_parser::convert_ast_to_expression, rust_parse)
6327         (rust_lex_test_completion, rust_lex_tests): Update.
6328         * parser-defs.h (struct expr_completion_state): New.
6329         (struct parser_state) <parser_state>: Add completion parameter.
6330         <mark_struct_expression, mark_completion_tag>: New methods.
6331         <parse_completion, m_completion_state>: New members.
6332         (prefixify_expression, null_post_parser): Update.
6333         (mark_struct_expression, mark_completion_tag): Don't declare.
6334         * parse.c (parse_completion, expout_last_struct)
6335         (expout_tag_completion_type, expout_completion_name): Remove
6336         globals.
6337         (parser_state::mark_struct_expression)
6338         (parser_state::mark_completion_tag): Now methods.
6339         (prefixify_expression): Add last_struct parameter.
6340         (prefixify_subexp): Likewise.
6341         (parse_exp_1): Update.
6342         (parse_exp_in_context): Add cstate parameter.  Update.
6343         (parse_expression_for_completion): Create an
6344         expr_completion_state.
6345         (null_post_parser): Add "completion" parameter.
6346         * p-exp.y: Update rules.
6347         (yylex): Update.
6348         * language.h (struct language_defn) <la_post_parser>: Add
6349         "completing" parameter.
6350         * go-exp.y: Update rules.
6351         (lex_one_token): Update.
6352         * expression.h (parse_completion): Don't declare.
6353         * d-exp.y: Update rules.
6354         (lex_one_token): Update rules.
6355         * c-exp.y: Update rules.
6356         (lex_one_token): Update.
6357         * ada-lang.c (resolve): Add "parse_completion" parameter.
6358         (resolve_subexp): Likewise.
6359         (ada_resolve_function): Likewise.
6360
6361 2019-04-04  Tom Tromey  <tom@tromey.com>
6362
6363         * parser-defs.h (struct parser_state) <start_arglist,
6364         end_arglist>: New methods.
6365         <arglist_len, m_funcall_chain>: New members.
6366         (arglist_len, start_arglist, end_arglist): Don't declare.
6367         * parse.c (arglist_len, funcall_chain): Remove global.
6368         (start_arglist, end_arglist): Remove functions.
6369         (parse_exp_in_context): Update.
6370         * p-exp.y: Update rules.
6371         * m2-exp.y: Update rules.
6372         * go-exp.y: Update rules.
6373         * f-exp.y: Update rules.
6374         * d-exp.y: Update rules.
6375         * c-exp.y: Update rules.
6376
6377 2019-04-04  Tom Tromey  <tom@tromey.com>
6378
6379         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6380         lex_operator, push_back>: New methods.
6381         Update all rules.
6382         (rust_parser::lex_hex, lex_escape): Rename and update.
6383         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6384         (rust_parser::lex_operator): Rename and update.
6385         (rust_parser::lex_number, rustyylex, rustyyerror)
6386         (rust_lex_test_init, rust_lex_test_sequence)
6387         (rust_lex_test_push_back, rust_lex_tests): Update.
6388         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6389         parameter.
6390         <lexptr, prev_lexptr>: New members.
6391         (lexptr, prev_lexptr): Don't declare.
6392         * parse.c (lexptr, prev_lexptr): Remove globals.
6393         (parse_exp_in_context): Update.
6394         * p-exp.y (yylex, yyerror): Update.
6395         * m2-exp.y (parse_number, yylex, yyerror): Update.
6396         * go-exp.y (lex_one_token, yyerror): Update.
6397         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6398         * d-exp.y (lex_one_token, yyerror): Update.
6399         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6400         (lex_one_token, yyerror): Update.
6401         * ada-lex.l (YY_INPUT): Update.
6402         (rewind_to_char): Update.
6403         * ada-exp.y (yyerror): Update.
6404
6405 2019-04-04  Tom Tromey  <tom@tromey.com>
6406
6407         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6408         * parser-defs.h (struct parser_state) <parser_state>: Add new
6409         parameter.
6410         <comma_terminates>: New member.
6411         (comma_terminates): Don't declare global.
6412         * parse.c (comma_terminates): Remove global.
6413         (parse_exp_in_context): Update.
6414         * p-exp.y (yylex): Update.
6415         * m2-exp.y (yylex): Update.
6416         * go-exp.y (lex_one_token): Update.
6417         * f-exp.y (yylex): Update.
6418         * d-exp.y (lex_one_token): Update.
6419         * c-exp.y (lex_one_token): Update.
6420         * ada-lex.l: Update.
6421
6422 2019-04-04  Tom Tromey  <tom@tromey.com>
6423
6424         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6425         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6426         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6427         * parser-defs.h (paren_depth): Don't declare.
6428         * parse.c (paren_depth): Remove global.
6429         (parse_exp_in_context): Update.
6430         * p-exp.y (paren_depth): New global.
6431         (pascal_parse): Initialize it.
6432         * m2-exp.y (paren_depth): New global.
6433         (m2_parse): Initialize it.
6434         * go-exp.y (paren_depth): New global.
6435         (go_parse): Initialize it.
6436         * f-exp.y (paren_depth): New global.
6437         (f_parse): Initialize it.
6438         * d-exp.y (paren_depth): New global.
6439         (d_parse): Initialize it.
6440         * c-exp.y (paren_depth): New global.
6441         (c_parse): Initialize it.
6442         * ada-lex.l (paren_depth): New global.
6443         (lexer_init): Initialize it.
6444
6445 2019-04-04  Tom Tromey  <tom@tromey.com>
6446
6447         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6448         (rust_parser::convert_ast_to_type)
6449         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6450         * parser-defs.h (struct parser_state) <parser_state>: Add
6451         parameters.  Initialize new members.
6452         <expression_context_block, expression_context_pc>: New members.
6453         * parse.c (expression_context_block, expression_context_pc):
6454         Remove globals.
6455         (parse_exp_in_context): Update.
6456         * p-exp.y: Update all rules.
6457         (yylex): Update.
6458         * m2-exp.y: Update all rules.
6459         (yylex): Update.
6460         * go-exp.y (yylex): Update.
6461         * f-exp.y (yylex): Update.
6462         * d-exp.y: Update all rules.
6463         (yylex): Update.
6464         * c-exp.y: Update all rules.
6465         (lex_one_token, classify_name, yylex, c_parse): Update.
6466         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6467
6468 2019-04-04  Tom Tromey  <tom@tromey.com>
6469
6470         * gdbarch.h, gdbarch.c: Rebuild.
6471         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6472         * stap-probe.h:
6473         (struct stap_parse_info): Replace "parser_state" with
6474         "expr_builder".
6475         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6476         (parser_state): New class.
6477         * parse.c (expr_builder): Rename.
6478         (expr_builder::release): Rename.
6479         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6480         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6481         (write_exp_elt_longcst, write_exp_elt_floatcst)
6482         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6483         (write_exp_string_vector, write_exp_bitstring)
6484         (write_exp_msymbol, mark_struct_expression)
6485         (write_dollar_variable)
6486         (insert_type_address_space, increase_expout_size): Replace
6487         "parser_state" with "expr_builder".
6488         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6489         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6490         "parser_state" with "expr_builder".
6491
6492 2019-04-04  Tom Tromey  <tom@tromey.com>
6493
6494         * rust-exp.y: Replace "parse_language" with method call.
6495         * p-exp.y:
6496         (yylex): Replace "parse_language" with method call.
6497         * m2-exp.y:
6498         (yylex): Replace "parse_language" with method call.
6499         * go-exp.y (classify_name): Replace "parse_language" with method
6500         call.
6501         * f-exp.y (yylex): Replace "parse_language" with method call.
6502         * d-exp.y (lex_one_token): Replace "parse_language" with method
6503         call.
6504         * c-exp.y:
6505         (lex_one_token, classify_name, yylex): Replace "parse_language"
6506         with method call.
6507         * ada-exp.y (find_primitive_type, type_char)
6508         (type_system_address): Replace "parse_language" with method call.
6509
6510 2019-04-04  Tom Tromey  <tom@tromey.com>
6511
6512         * rust-exp.y: Replace "parse_gdbarch" with method call.
6513         * parse.c (write_dollar_variable, insert_type_address_space):
6514         Replace "parse_gdbarch" with method call.
6515         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6516         call.
6517         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6518         call.
6519         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6520         "parse_gdbarch" with method call.
6521         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6522         with method call.
6523         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6524         "parse_gdbarch" with method call.
6525         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6526         "parse_gdbarch" with method call.
6527         * c-exp.y (parse_type, parse_number, classify_name): Replace
6528         "parse_gdbarch" with method call.
6529         * ada-lex.l: Replace "parse_gdbarch" with method call.
6530         * ada-exp.y (parse_type, find_primitive_type, type_char)
6531         (type_system_address): Replace "parse_gdbarch" with method call.
6532
6533 2019-04-04  Tom Tromey  <tom@tromey.com>
6534
6535         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6536         * stap-probe.c (stap_parse_argument): Update.
6537         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6538         initial_size parameter.
6539         * rust-exp.y (rust_lex_tests): Update.
6540         * parse.c (parser_state): Update.
6541         (parse_exp_in_context): Update.
6542         * parser-defs.h (struct parser_state) <parser_state>: Remove
6543         "initial_size" parameter.
6544
6545 2019-04-04  Tom Tromey  <tom@tromey.com>
6546
6547         * parser-defs.h (increase_expout_size): Don't declare.
6548         * parse.c (increase_expout_size): Now static.
6549
6550 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6551
6552         * gnu-nat.c (gnu_nat_target::wait): Fix
6553         target_waitstatus_to_string call.
6554
6555 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6556
6557         * eval.c (evaluate_subexp_standard): Handle internal functions
6558         during Fortran function call handling.
6559
6560 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6561
6562         * NEWS: Mention new internal functions.
6563         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6564         (read_base_type): Use dwarf2_init_complex_target_type.
6565         * value.c (creal_internal_fn): New function.
6566         (cimag_internal_fn): New function.
6567         (_initialize_values): Register new internal functions.
6568
6569 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6570
6571         * infrun.c (stop_all_threads): If debug_infrun, always
6572         trace the wait status after wait_one, using
6573         target_waitstatus_to_string and target_pid_to_str.
6574         (handle_inferior_event): Replace various trace of
6575         wait status kind by a single trace.
6576         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6577         wait status kind image by target_waitstatus_to_string.
6578         * target/waitstatus.c (target_waitstatus_to_string): Fix
6579         obsolete comment.
6580
6581 2019-04-01  Tom Tromey  <tromey@adacore.com>
6582
6583         PR symtab/23331:
6584         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6585
6586 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6587             Pedro Alves  <palves@redhat.com>
6588
6589         * top.c (quit_force): Call 'finalize_values'.
6590         * value.c (finalize_values): New function.
6591         * value.h (finalize_values): Declare.
6592
6593 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6594
6595         * NEWS: Announce $_gdb_major and $_gdb_minor.
6596
6597         * top.c (init_gdb_version_vars): New function.
6598         (gdb_init): Call init_gdb_version_vars.
6599
6600 2019-03-29  Tom Tromey  <tromey@adacore.com>
6601
6602         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6603         help text.  Remove dead code.
6604
6605 2019-03-29  Keith Seitz  <keiths@redhat.com>
6606
6607         From Siddhesh Poyarekar:
6608         * f-lang.h (f77_get_upperbound): Return LONGEST.
6609         (f77_get_lowerbound): Likewise.
6610         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6611         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6612         print them.
6613         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6614         plongest to format print it.
6615         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6616         (f77_get_upperbound): Likewise.
6617         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6618         LOWER_BOUND to LONGEST.
6619         (f77_create_arrayprint_offset_tbl): Likewise.
6620
6621 2019-03-29  Keith Seitz  <keiths@redhat.com>
6622
6623         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6624         %s/pulongest for TYPE_LENGTH instead of %d in format
6625         strings.
6626         * ada-typerint.c (ada_print_type): Likewise.
6627         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6628         * compile/compile-c-support.c (generate_register_struct): Likewise.
6629         * gdbtypes.c (recursive_dump_type): Likewise.
6630         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6631         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6632         instead of %d in format strings.
6633         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6634         to std::min to ULONGEST.
6635         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6636         instead of %d in format strings.
6637         * tracepoint.c (info_scope_command): Likewise.
6638         * typeprint.c (print_offset_data::update)
6639         (print_offset_data::finish): Likewise.
6640         * xtensa-tdep.c (xtensa_store_return_value)
6641         (xtensa_push_dummy_call): Likewise.
6642
6643 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6644
6645         * windows-nat.c (display_selector): Fixed format specifications
6646         for 64-bit Cygwin.
6647
6648 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6649
6650         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6651
6652 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6653
6654         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6655         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6656         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6657         (nios2_linux_init_abi): Install it.
6658
6659 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6660
6661         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6662
6663 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6664
6665         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6666
6667 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6668             Tom Tromey  <tromey@adacore.com>
6669
6670         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6671
6672 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6673
6674         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6675         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6676         method to compute the bounds of range types. Also print "[evaluated]"
6677         if the bounds' values come from a dynamic evaluation.
6678
6679 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6680
6681         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6682         whitespace when pretty printing is on.
6683
6684 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6685
6686         * ppc-linux-nat.c: Add include.
6687
6688 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6689
6690         * NEWS: Mention AArch64 Pointer Authentication.
6691
6692 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6693
6694         * arm-linux-nat.c: Add include.
6695
6696 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6697
6698         * source-cache.c (source_cache::get_source_lines): Re-read
6699         fullname after calling open_source_file.
6700
6701 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6702
6703         * NEWS: Mention TLS support for FreeBSD.
6704
6705 2019-03-25  Tom Tromey  <tromey@adacore.com>
6706
6707         * minsyms.c (BUNCH_SIZE): Update comment.
6708         (~minimal_symbol_reader): Remove old comment.
6709         (compact_minimal_symbols): Update comment.
6710         (minimal_symbol_reader::install): Remove old comment.  Update
6711         other comments.
6712
6713 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6714
6715         * s390-linux-nat.c: Add include.
6716
6717 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6718
6719         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6720         Call linux_get_hwcap.
6721         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6722         Likewise.
6723         (aarch64_linux_get_hwcap): Remove function.
6724         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6725         declaration.
6726         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6727         linux_get_hwcap.
6728         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6729         * linux-tdep.c (linux_get_hwcap): Add function.
6730         (linux_get_hwcap2): Likewise.
6731         * linux-tdep.h (linux_get_hwcap): Add declaration.
6732         (linux_get_hwcap2): Likewise.
6733         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6734         (ppc_linux_get_hwcap2): Likewise.
6735         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6736         linux_get_hwcap.
6737         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6738         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6739         (ppc_linux_nat_target::read_description): Likewise.
6740         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6741         * s390-linux-nat.c: Likewise.
6742         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6743
6744 2019-03-24  Tom Tromey  <tom@tromey.com>
6745
6746         * ada-lang.c (standard_lookup): Simplify initialization.
6747         (ada_lookup_symbol_nonlocal): Simplify return.
6748         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6749         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6750         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6751         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6752         initialization.
6753         * solib.c (solib_global_lookup): Simplify.
6754         * symtab.c (null_block_symbol): Remove.
6755         (symbol_cache_lookup): Simplify returns.
6756         (lookup_language_this): Simplify returns.
6757         (lookup_symbol_aux): Simplify return.
6758         (lookup_local_symbol): Simplify returns.
6759         (lookup_global_symbol_from_objfile): Simplify return.
6760         (lookup_symbol_in_objfile_symtabs)
6761         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6762         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6763         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6764         * cp-namespace.c (cp_lookup_bare_symbol)
6765         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6766         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6767         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6768         (cp_lookup_symbol_via_imports): Simplify initialization.
6769         (find_symbol_in_baseclass): Likewise.
6770         * symtab.h (null_block_symbol): Remove.
6771         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6772         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6773         (d_lookup_symbol_module): Likewise.
6774         (find_symbol_in_baseclass): Simplify initialization.
6775
6776 2019-03-24  Tom Tromey  <tom@tromey.com>
6777
6778         * expression.h: Don't include symtab.h.
6779         (struct block): Forward declare.
6780
6781 2019-03-24  Tom Tromey  <tom@tromey.com>
6782
6783         * c-exp.y (typebase): Remove casts.
6784         * gdbtypes.c (lookup_unsigned_typename, )
6785         (lookup_signed_typename): Remove cast.
6786         * eval.c (parse_to_comma_and_eval): Remove cast.
6787         * parse.c (write_dollar_variable): Remove cast.
6788         * block.h (struct block) <superblock>: Now const.
6789         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6790         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6791         (map_block): Make "block" const.
6792         * symfile.h (struct quick_symbol_functions)
6793         <map_matching_symbols>: Constify block argument to "callback".
6794         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6795         const.
6796         (find_pc_sect_compunit_symtab): Make "b" const.
6797         (find_symbol_at_address): Likewise.
6798         (search_symbols): Likewise.
6799         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6800         (dw2_debug_names_lookup_symbol): Likewise.
6801         (dw2_map_matching_symbols): Update.
6802         * p-valprint.c (pascal_val_print): Remove "block".
6803         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6804         (aux_add_nonlocal_symbols): Make "block" const.
6805         (resolve_subexp): Remove cast.
6806         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6807         const.
6808         (iterate_over_file_blocks): Likewise.
6809         * f-exp.y (%union) <bval>: Remove.
6810         * coffread.c (patch_opaque_types): Make "b" const.
6811         * spu-tdep.c (spu_catch_start): Make "block" const.
6812         * c-valprint.c (print_unpacked_pointer): Remove "block".
6813         * symmisc.c (dump_symtab_1): Make "b" const.
6814         (block_depth): Make "block" const.
6815         * d-exp.y (%union) <bval>: Remove.
6816         * cp-support.h (cp_lookup_rtti_type): Update.
6817         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6818         * psymtab.c (psym_lookup_symbol): Make "block" const.
6819         (maintenance_check_psymtabs): Make "b" const.
6820         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6821         (enumerate_locals, enumerate_args): Update.
6822         * python/py-symtab.c (stpy_global_block): Make "block" const.
6823         (stpy_static_block): Likewise.
6824         * inline-frame.c (block_starting_point_at): Make "new_block"
6825         const.
6826         * block.c (find_block_in_blockvector): Make return type const.
6827         (blockvector_for_pc_sect): Make "b" const.
6828         (find_block_in_blockvector): Make "b" const.
6829
6830 2019-03-23  Tom Tromey  <tom@tromey.com>
6831
6832         * varobj.c (varobj_create): Update.
6833         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6834         * printcmd.c (display_command, do_one_display): Don't reset
6835         innermost_block.
6836         * parser-defs.h (enum innermost_block_tracker_type): Move to
6837         expression.h.
6838         (innermost_block): Update comment.
6839         * parse.c (parse_exp_1): Add tracker_types parameter.
6840         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6841         tracker_types parameter.  Reset innermost_block.
6842         (parse_exp_in_context): Remove.
6843         (parse_expression_for_completion): Update.
6844         * objfiles.c (~objfile): Don't reset expression_context_block or
6845         innermost_block.
6846         * expression.h (enum innermost_block_tracker_type): Move from
6847         parser-defs.h.
6848         (parse_exp_1): Add tracker_types parameter.
6849         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6850         reset innermost_block.
6851
6852 2019-03-23  Tom Tromey  <tom@tromey.com>
6853
6854         * objfiles.h: Include bcache.h.
6855
6856 2019-03-23  Tom Tromey  <tom@tromey.com>
6857
6858         * linespec.c (get_current_search_block): Use
6859         scoped_restore_current_language.
6860         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6861
6862 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6863             Jiong Wang  <jiong.wang@arm.com>
6864
6865         * aarch64-linux-tdep.c
6866         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6867         section.
6868         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6869
6870 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6871             Jiong Wang  <jiong.wang@arm.com>
6872
6873         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6874         instructions.
6875         (aarch64_analyze_prologue_test): Add PACIASP test.
6876         (aarch64_prologue_prev_register): Unmask PC value.
6877
6878 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6879             Jiong Wang  <jiong.wang@arm.com>
6880
6881         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6882         (aarch64_dwarf2_prev_register): Unmask PC value.
6883         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6884         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6885         DW_CFA_AARCH64_negate_ra_state.
6886         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6887
6888 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6889             Jiong Wang  <jiong.wang@arm.com>
6890
6891         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6892         registers.
6893         (aarch64_pseudo_register_name): Likewise.
6894         (aarch64_pseudo_register_type): Likewise.
6895         (aarch64_pseudo_register_reggroup_p): Likewise.
6896         (aarch64_gdbarch_init): Add pauth registers.
6897         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6898         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6899         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6900         (struct gdbarch_tdep): Add regnum for ra_state.
6901
6902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6903             Jiong Wang  <jiong.wang@arm.com>
6904
6905         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6906
6907 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6908             Jiong Wang  <jiong.wang@arm.com>
6909
6910         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6911         function.
6912         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6913         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6914         (aarch64_gdbarch_init): Add puth registers.
6915         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6916         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6917         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6918
6919 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6920             Jiong Wang  <jiong.wang@arm.com>
6921
6922         * aarch64-linux-nat.c
6923         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6924         * aarch64-linux-tdep.c
6925         (aarch64_linux_core_read_description): Likewise.
6926         (aarch64_linux_get_hwcap): New function.
6927         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6928         (aarch64_linux_get_hwcap): New declaration.
6929
6930 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6931             Jiong Wang  <jiong.wang@arm.com>
6932
6933         * aarch64-linux-nat.c
6934         (aarch64_linux_nat_target::read_description): Add pauth param.
6935         * aarch64-linux-tdep.c
6936         (aarch64_linux_core_read_description): Likewise.
6937         * aarch64-tdep.c (struct target_desc): Add in pauth.
6938         (aarch64_read_description): Add pauth param.
6939         (aarch64_gdbarch_init): Likewise.
6940         * aarch64-tdep.h (aarch64_read_description): Likewise.
6941         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6942         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6943         * features/Makefile: Add new files.
6944         * features/aarch64-pauth.c: New file.
6945         * features/aarch64-pauth.xml: New file.
6946
6947 2019-03-20  Tom Tromey  <tromey@adacore.com>
6948
6949         * infrun.c (handle_inferior_event): Rename from
6950         handle_inferior_event_1.  Create a scoped_value_mark.
6951         (handle_inferior_event): Remove.
6952
6953 2019-03-19  Tom Tromey  <tromey@adacore.com>
6954
6955         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6956         * infrun.h (print_stop_event): Add "displays" parameter.
6957         * infrun.c (print_stop_event): Add "displays" parameter.
6958
6959 2019-03-19  Pedro Alves  <palves@redhat.com>
6960
6961         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6962         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6963         to -1.  Fix TABs vs spaces.
6964         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6965         * tui/tui-out.h (tui_ui_out) Add intro comments.
6966         <m_line, m_start_of_line>: In-class initialize, and add describing
6967         comment.
6968
6969 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6970
6971         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6972         variable names.
6973         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6974
6975 2019-03-18  Pedro Alves  <palves@redhat.com>
6976             Eli Zaretskii <eliz@gnu.org>
6977
6978         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6979         m_line and m_start_of_line.
6980
6981 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6982
6983         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6984         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6985         it returns a newline.  This fixes a regression in TU mode, whereby
6986         the next line is output on the same screen line as the user input.
6987
6988 2019-03-18  Tom Tromey  <tromey@adacore.com>
6989
6990         * minsyms.c (minimal_symbol_reader::install): Remove call to
6991         obstack_blank.
6992
6993 2019-03-18  Pedro Alves  <palves@redhat.com>
6994
6995         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6996         New globals.
6997         (apply_style): New, factored out from ...
6998         (apply_ansi_escape): ... this.  Handle reverse video mode.
6999         (tui_set_reverse_mode): New function.
7000         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7001         * tui/tui-winsource.c (tui_show_source_line): Use
7002         tui_set_reverse_mode instead of setting A_STANDOUT.
7003         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7004         New setter methods.
7005
7006 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7007
7008         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7009         Handle tabs.
7010
7011 2019-03-18  Tom Tromey  <tromey@adacore.com>
7012
7013         * ada-lang.c (empty_array): Add "high" parameter.
7014         (ada_evaluate_subexp): Update.
7015
7016 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7017
7018         * unittests/string_view-selftests.c: Define
7019         _initialize_string_view_selftests unconditionally.
7020
7021 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7022
7023         PR gdb/24350
7024         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7025
7026 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7027
7028         PR gdb/24351
7029         * windows-nat.c (display_selector): Fix format specifiers.
7030
7031 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7032
7033         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7034         tui_refill_source_window instead of tui_refresh_win, to update the
7035         current execution line.  This fixes redisplay of the current line
7036         when stepping through the code with "next" or "step".
7037
7038 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7039
7040         * source-cache.c (source_cache::get_source_lines): Call
7041         find_source_lines to initialize s->nlines.  This fixes vertical
7042         scrolling of TUI source window when the DOWN arrow is pressed.
7043
7044 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7045
7046         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7047         linux-thread-db.c (_initialize_thread_db): Likewise.
7048
7049 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7050
7051         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7052         wclrtoeol in tui_show_source_line".  This reverts changes made in
7053         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7054
7055 2019-03-15  Tom Tromey  <tom@tromey.com>
7056
7057         * symtab.h (struct minimal_symbol): Derive from
7058         general_symbol_info.
7059         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7060         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7061         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7062         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7063         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7064         (MSYMBOL_SEARCH_NAME): Update.
7065         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7066         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7067         * minsyms.c (minimal_symbol_reader::record_full): Update.
7068
7069 2019-03-15  Tom Tromey  <tom@tromey.com>
7070
7071         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7072
7073 2019-03-15  Tom Tromey  <tom@tromey.com>
7074
7075         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7076         unique_xmalloc_ptr.
7077         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7078         Update.
7079         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7080         (build_minimal_symbol_hash_tables)
7081         (minimal_symbol_reader::install): Update.
7082
7083 2019-03-15  Tom Tromey  <tom@tromey.com>
7084
7085         * symtab.c (create_demangled_names_hash): Update.
7086         (symbol_set_names): Update.
7087         * objfiles.h (struct objfile_per_bfd_storage)
7088         <demangled_names_hash>: Now an htab_up.
7089         * objfiles.c (objfile_per_bfd_storage): Simplify.
7090
7091 2019-03-15  Tom Tromey  <tom@tromey.com>
7092
7093         * objfiles.h (struct objfile_per_bfd_storage): Declare
7094         destructor.
7095         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7096         New.
7097         (get_objfile_bfd_data): Use new.  Don't initialize
7098         language_of_main.
7099         (free_objfile_per_bfd_storage): Remove.
7100         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7101
7102 2019-03-15  Tom Tromey  <tom@tromey.com>
7103
7104         * symfile.c (reread_symbols): Update.
7105         * objfiles.c (objfile::objfile): Update.
7106         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7107         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7108         comment.
7109         (minimal_symbol_reader::install): Update.
7110         (terminate_minimal_symbol_table): Remove.
7111         * jit.c (jit_object_close_impl): Update.
7112
7113 2019-03-15  Tom Tromey  <tom@tromey.com>
7114
7115         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7116         initializations.
7117
7118 2019-03-15  Tom Tromey  <tom@tromey.com>
7119
7120         * objfiles.h (struct objfile_per_bfd_storage)
7121         <demangled_hash_languages>: Now a bitset.
7122         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7123         (lookup_minimal_symbol): Update.
7124
7125 2019-03-15  Tom Tromey  <tom@tromey.com>
7126
7127         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7128         Don't return the symbol.
7129         * coffread.c (record_minimal_symbol): Use record_full.
7130
7131 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7132
7133         The MS-Windows port of ncurses fails to switch to a color pair if
7134         one or both of the colors are the implicit default colors.  This
7135         change records the default colors when TUI is initialized, and
7136         then specifies them explicitly when a color pair uses the default
7137         colors.  This allows color styling in TUI mode on MS-Windows.
7138
7139         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7140         ncurses_norm_attr.
7141         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7142         colors in ncurses_norm_attr.
7143         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7144         "none", replace it with the default color recorded in
7145         ncurses_norm_attr.
7146
7147 2019-03-14  Tom Tromey  <tromey@adacore.com>
7148
7149         * source-cache.h (class source_cache) <get_source_lines>: Return
7150         std::string.
7151         * source-cache.c (source_cache::extract_lines): Handle case where
7152         first_pos==npos.  Return std::string.
7153         (source_cache::get_source_lines): Update.
7154
7155 2019-03-14  Tom Tromey  <tromey@adacore.com>
7156
7157         * NEWS: Add item for "style sources" commands.
7158         * source-cache.c (source_cache::get_source_lines): Check
7159         source_styling.
7160         * cli/cli-style.c (source_styling): New global.
7161         (_initialize_cli_style): Add "style sources" commands.
7162         (show_style_sources): New function.
7163         * cli/cli-style.h (source_styling): Declare.
7164
7165 2019-03-14  Pedro Alves  <palves@redhat.com>
7166             Tom Tromey  <tromey@adacore.com>
7167
7168         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7169         * tui/tui-winsource.c (tui_refill_source_window): New function,
7170         from...
7171         (tui_horizontal_source_scroll): ... here.  Move some logic.
7172         * cli/cli-style.c (set_style_enabled): Notify new observable.
7173         * tui/tui-hooks.c (tui_redisplay_source): New function.
7174         (tui_attach_detach_observers): Attach or detach
7175         tui_redisplay_source.
7176         * observable.h (source_styling_changed): New observable.
7177         * observable.c: Define source_styling_changed observable.
7178
7179 2019-03-13  Tom Tromey  <tromey@adacore.com>
7180
7181         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7182         (i386_gnu_nat_target::store_registers): Update.
7183         * target-debug.h (target_debug_print_std_string): New macro.
7184         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7185         * windows-tdep.c (display_one_tib): Update.
7186         * tui/tui-stack.c (tui_make_status_line): Update.
7187         * top.c (print_inferior_quit_action): Update.
7188         * thread.c (thr_try_catch_cmd): Update.
7189         (add_thread_with_info): Update.
7190         (thread_target_id_str): Update.
7191         (thr_try_catch_cmd): Update.
7192         (thread_command): Update.
7193         (thread_find_command): Update.
7194         * record-btrace.c (record_btrace_target::info_record)
7195         (record_btrace_resume_thread, record_btrace_target::resume)
7196         (record_btrace_cancel_resume, record_btrace_step_thread)
7197         (record_btrace_target::wait, record_btrace_target::wait)
7198         (record_btrace_target::wait, record_btrace_target::stop): Update.
7199         * progspace.c (print_program_space): Update.
7200         * process-stratum-target.c
7201         (process_stratum_target::thread_address_space): Update.
7202         * linux-fork.c (linux_fork_mourn_inferior)
7203         (detach_checkpoint_command, info_checkpoints_command)
7204         (linux_fork_context): Update.
7205         (linux_fork_detach): Update.
7206         (class scoped_switch_fork_info): Update.
7207         (delete_checkpoint_command): Update.
7208         * infrun.c (follow_fork_inferior): Update.
7209         (follow_fork_inferior): Update.
7210         (proceed_after_vfork_done): Update.
7211         (handle_vfork_child_exec_or_exit): Update.
7212         (follow_exec): Update.
7213         (displaced_step_prepare_throw): Update.
7214         (displaced_step_restore): Update.
7215         (start_step_over): Update.
7216         (resume_1): Update.
7217         (clear_proceed_status_thread): Update.
7218         (proceed): Update.
7219         (print_target_wait_results): Update.
7220         (do_target_wait): Update.
7221         (context_switch): Update.
7222         (stop_all_threads): Update.
7223         (restart_threads): Update.
7224         (finish_step_over): Update.
7225         (handle_signal_stop): Update.
7226         (switch_back_to_stepped_thread): Update.
7227         (keep_going_pass_signal): Update.
7228         (print_exited_reason): Update.
7229         (normal_stop): Update.
7230         * inferior.c (inferior_pid_to_str): Change return type.
7231         (print_selected_inferior): Update.
7232         (add_inferior): Update.
7233         (detach_inferior): Update.
7234         * dummy-frame.c (fprint_dummy_frames): Update.
7235         * dcache.c (dcache_info_1): Update.
7236         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7237         (btrace_fetch, btrace_clear): Update.
7238         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7239         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7240         type.
7241         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7242         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7243         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7244         * gdbarch.c, gdbarch.h: Rebuild.
7245         * gdbarch.sh (core_pid_to_str): Change return type.
7246         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7247         return type.
7248         (windows_nat_target::pid_to_str): Change return type.
7249         (windows_delete_thread): Update.
7250         (windows_nat_target::attach): Update.
7251         (windows_nat_target::files_info): Update.
7252         * target-delegates.c: Rebuild.
7253         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7254         return type.
7255         (sol_thread_target::pid_to_str): Change return type.
7256         * remote.c (class remote_target) <pid_to_str>: Change return
7257         type.
7258         (remote_target::pid_to_str): Change return type.
7259         (extended_remote_target::attach, remote_target::remote_stop_ns)
7260         (remote_target::remote_notif_remove_queued_reply)
7261         (remote_target::push_stop_reply, remote_target::disable_btrace):
7262         Update.
7263         (extended_remote_target::attach): Update.
7264         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7265         type.
7266         (gdbsim_target::pid_to_str): Change return type.
7267         * ravenscar-thread.c (struct ravenscar_thread_target)
7268         <pid_to_str>: Change return type.
7269         (ravenscar_thread_target::pid_to_str): Change return type.
7270         * procfs.c (class procfs_target) <pid_to_str>: Change return
7271         type.
7272         (procfs_target::pid_to_str): Change return type.
7273         (procfs_target::attach): Update.
7274         (procfs_target::detach): Update.
7275         (procfs_target::fetch_registers): Update.
7276         (procfs_target::store_registers): Update.
7277         (procfs_target::wait): Update.
7278         (procfs_target::files_info): Update.
7279         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7280         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7281         return type.
7282         (nto_procfs_target::pid_to_str): Change return type.
7283         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7284         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7285         return type.
7286         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7287         (exit_lwp): Update.
7288         (attach_proc_task_lwp_callback, get_detach_signal)
7289         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7290         (linux_nat_target::resume, wait_lwp, stop_callback)
7291         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7292         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7293         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7294         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7295         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7296         type.
7297         (inf_ptrace_target::attach): Update.
7298         (inf_ptrace_target::files_info): Update.
7299         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7300         type.
7301         (go32_nat_target::pid_to_str): Change return type.
7302         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7303         (gnu_nat_target::wait): Update.
7304         (gnu_nat_target::wait): Update.
7305         (gnu_nat_target::resume): Update.
7306         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7307         (fbsd_nat_target::wait): Update.
7308         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7309         type.
7310         (darwin_nat_target::attach): Update.
7311         * corelow.c (class core_target) <pid_to_str>: Change return type.
7312         (core_target::pid_to_str): Change return type.
7313         * target.c (normal_pid_to_str): Change return type.
7314         (default_pid_to_str): Likewise.
7315         (target_pid_to_str): Change return type.
7316         (target_translate_tls_address): Update.
7317         (target_announce_detach): Update.
7318         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7319         return type.
7320         (bsd_uthread_target::pid_to_str): Change return type.
7321         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7322         type.
7323         (bsd_kvm_target::pid_to_str): Change return type.
7324         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7325         return type.
7326         (aix_thread_target::pid_to_str): Change return type.
7327         * target.h (struct target_ops) <pid_to_str>: Change return type.
7328         (target_pid_to_str, normal_pid_to_str): Likewise.
7329         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7330         type.
7331         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7332         type.
7333         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7334         return type.
7335         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7336         type.
7337         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7338         type.
7339         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7340         return type.
7341
7342 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7343
7344         * NEWS: Mention that the new default MI version is 3.  Mention
7345         changes to the output of commands and events that deal with
7346         multi-location breakpoints.
7347         * breakpoint.c: Include "mi/mi-out.h".
7348         (print_one_breakpoint): Change output syntax if using MI version
7349         >= 3.
7350         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7351         New.
7352         (mi_multi_location_breakpoint_output_fixed): New.
7353         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7354         (mi_cmd_fix_multi_location_breakpoint_output): New.
7355         (mi_multi_location_breakpoint_output_fixed): New.
7356         * mi/mi-cmds.c (mi_cmds): Register command
7357         -fix-multi-location-breakpoint-output.
7358         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7359         interpreter "mi".
7360
7361 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7362
7363         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7364         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7365         instantiate mi_ui_out based on interpreter name.
7366         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7367         * mi/mi-main.c (mi_load_progress): Likewise.
7368
7369 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7370
7371         * NEWS: Combine separate "New targets" sections for 8.3.
7372
7373 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7374
7375         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7376         (ppcfbsd_init_abi): Install gdbarch
7377         "fetch_tls_load_module_address" and "get_thread_local_address"
7378         methods.
7379
7380 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7381
7382         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7383         (riscv_fbsd_init_abi): Install gdbarch
7384         "fetch_tls_load_module_address" and "get_thread_local_address"
7385         methods.
7386
7387 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7388
7389         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7390         (i386fbsd_init_abi): Install gdbarch
7391         "fetch_tls_load_module_address" and "get_thread_local_address"
7392         methods.
7393
7394 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7395
7396         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7397         (amd64fbsd_init_abi): Install gdbarch
7398         "fetch_tls_load_module_address" and "get_thread_local_address"
7399         methods.
7400
7401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7402
7403         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7404         (struct fbsd_pspace_data): New type.
7405         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7406         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7407         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7408         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7409         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7410
7411 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7412
7413         * gdbtypes.c (lookup_struct_elt): New function.
7414         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7415         * gdbtypes.h (struct struct_elt): New type.
7416         (lookup_struct_elt): New prototype.
7417
7418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7419
7420         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7421         remove disabled code block.
7422
7423 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7424
7425         * gdbarch.sh (get_thread_local_address): New method.
7426         * gdbarch.h, gdbarch.c: Regenerate.
7427         * target.c (target_translate_tls_address): Use
7428         gdbarch_get_thread_local_address if present instead of
7429         target::get_thread_local_address.
7430
7431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7432
7433         * target.h (target::get_thread_local_address): Update comment.
7434
7435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7436
7437         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7438         objfile->separate_debug_objfile_backlink if not NULL.
7439
7440 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7441
7442         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7443         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7444         (amd64bsd_store_inferior_registers): Likewise.
7445         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7446         Enable segment base registers.
7447         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7448         PT_GETFSBASE and PT_GETGSBASE.
7449         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7450         PT_SETGSBASE.
7451         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7452         segment base registers.
7453         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7454
7455 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7456
7457         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7458         Update calls to i386_target_description to add 'segments'
7459         parameter.
7460         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7461         add segment base registers.
7462         * arch/i386.c (i386_create_target_description): Add 'segments'
7463         parameter to enable segment base registers.
7464         * arch/i386.h (i386_create_target_description): Likewise.
7465         * features/i386/32bit-segments.xml: New file.
7466         * features/i386/32bit-segments.c: Generate.
7467         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7468         call to i386_target_description to add 'segments' parameter.
7469         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7470         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7471         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7472         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7473         if feature is present.
7474         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7475         Add 'segments' parameter to call to i386_target_description.
7476         (i386_target_description): Add 'segments' parameter to enable
7477         segment base registers.
7478         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7479         to call to i386_target_description.
7480         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7481         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7482         Define I386_NUM_REGS.
7483         (i386_target_description): Add 'segments' parameter to enable
7484         segment base registers.
7485
7486 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7487
7488         PR/24325
7489         * source-cache.c: #undef open and close, to avoid unresolved
7490         externals during linking.
7491
7492 2019-03-12  Tom Tromey  <tromey@adacore.com>
7493
7494         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7495         const.  Add initializers.
7496         (_initialize_remote): Don't initialize ptid globals.
7497
7498 2019-03-12  Pedro Alves  <palves@redhat.com>
7499
7500         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7501
7502 2019-03-12  Pedro Alves  <palves@redhat.com>
7503
7504         * cp-name-parser.y (main): Remove unused 'len' variable.
7505
7506 2019-03-12  Tom Tromey  <tromey@adacore.com>
7507
7508         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7509         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7510
7511 2019-03-12  Tom Tromey  <tromey@adacore.com>
7512
7513         * linux-nat.c (iterate_over_lwps): Update.
7514         (stop_callback): Remove parameter.
7515         (stop_wait_callback, detach_callback, resume_set_callback)
7516         (select_singlestep_lwp_callback, set_ignore_sigint)
7517         (status_callback, resumed_callback, resume_clear_callback)
7518         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7519         data parameter.
7520         (linux_nat_target::detach, linux_nat_target::resume)
7521         (linux_stop_and_wait_all_lwps, select_event_lwp)
7522         (linux_nat_filter_event, linux_nat_wait_1)
7523         (linux_nat_target::kill, linux_nat_target::stop)
7524         (linux_nat_target::stop): Update.
7525         (linux_nat_resume_callback): Change type.
7526         (resume_stopped_resumed_lwps, count_events_callback)
7527         (select_event_lwp_callback): Likewise.
7528         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7529         * arm-linux-nat.c (struct update_registers_data): Remove.
7530         (update_registers_callback): Change type.
7531         (arm_linux_insert_hw_breakpoint1): Update.
7532         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7533         parameter.
7534         (x86_linux_dr_set_addr): Update.
7535         (x86_linux_dr_set_control): Update.
7536         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7537         (iterate_over_lwps): Use gdb::function_view.
7538         * nat/aarch64-linux-hw-point.c (struct
7539         aarch64_dr_update_callback_param): Remove.
7540         (debug_reg_change_callback): Change type.
7541         (aarch64_notify_debug_reg_change): Update.
7542         * s390-linux-nat.c (s390_refresh_per_info): Update.
7543
7544 2019-03-11  Tom Tromey  <tromey@adacore.com>
7545
7546         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7547         redundant assignment to "this_cu".
7548
7549 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7550
7551         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7552
7553 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7554
7555         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7556         from...
7557         (rank_one_type): ... this.
7558
7559 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7560
7561         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7562         from...
7563         (rank_one_type): ... this.
7564
7565 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7566
7567         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7568         from...
7569         (rank_one_type): ... this.
7570
7571 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7572
7573         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7574         from...
7575         (rank_one_type): ... this.
7576
7577 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7578
7579         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7580         from...
7581         (rank_one_type): ... this.
7582
7583 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7584
7585         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7586         from...
7587         (rank_one_type): ... this.
7588
7589 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7590
7591         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7592         from...
7593         (rank_one_type): ... this.
7594
7595 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7596
7597         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7598         from...
7599         (rank_one_type): ... this.
7600
7601 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7602
7603         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7604         from...
7605         (rank_one_type): ... this.
7606
7607 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7608
7609         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7610         from...
7611         (rank_one_type): ... this.
7612
7613 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7614
7615         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7616         from...
7617         (rank_one_type): ... this.
7618
7619 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7620
7621         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7622         from...
7623         (rank_one_type): ... this.
7624
7625 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7626
7627         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7628         inferior-events' shows the example events.
7629
7630 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7631
7632         Support styling on native MS-Windows console
7633
7634         PR/24315
7635         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7636         on MS-Windows if $TERM is not defined.
7637
7638         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7639
7640         * posix-hdep.c (gdb_console_fputs):
7641         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7642         functions.
7643         * ui-file.h (gdb_console_fputs): Add prototype.
7644
7645         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7646         back to fputs only if the former returns zero.
7647
7648 2019-03-07  Tom Tromey  <tom@tromey.com>
7649
7650         * symmisc.c (print_symbol_bcache_statistics): Update.
7651         (print_objfile_statistics): Update.
7652         * symfile.c (allocate_symtab): Update.
7653         * stabsread.c: Don't include bcache.h.
7654         * psymtab.h (struct psymbol_bcache): Don't declare.
7655         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7656         (psymbol_bcache_init, psymbol_bcache_free)
7657         (psymbol_bcache_get_bcache): Don't declare.
7658         * psymtab.c (struct psymbol_bcache): Remove.
7659         (psymtab_storage::psymtab_storage): Update.
7660         (psymtab_storage::~psymtab_storage): Update.
7661         (psymbol_bcache_init, psymbol_bcache_free)
7662         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7663         (add_psymbol_to_bcache): Update.
7664         (allocate_psymtab): Update.
7665         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7666         macro_cache>: No longer pointers.
7667         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7668         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7669         * macrotab.c (macro_bcache): Update.
7670         * macroexp.c: Don't include bcache.h.
7671         * gdbtypes.c (check_types_worklist): Update.
7672         (types_deeply_equal): Remove TRY/CATCH.  Update.
7673         * elfread.c (elf_symtab_read): Update.
7674         * dwarf2read.c: Don't include bcache.h.
7675         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7676         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7677         (print_bcache_statistics, bcache_memory_used): Don't declare.
7678         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7679         methods.  Rename all data members.
7680         * bcache.c (struct bcache): Move to bcache.h.
7681         (bcache::expand_hash_table): Rename from expand_hash_table.
7682         (bcache): Remove.
7683         (bcache::insert): Rename from bcache_full.
7684         (bcache::compare): Rename from bcache_compare.
7685         (bcache_xmalloc): Remove.
7686         (bcache::~bcache): Rename from bcache_xfree.
7687         (bcache::print_statistics): Rename from print_bcache_statistics.
7688         (bcache::memory_used): Rename from bcache_memory_used.
7689
7690 2019-03-07  Pedro Alves  <palves@redhat.com>
7691
7692         * infrun.c (normal_stop): Also check for
7693         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7694
7695 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7696
7697         * f-lang.c (value_from_host_double): Moved to...
7698         * value.c (value_from_host_double): ...here.
7699         * value.h (value_from_host_double): Declare.
7700         * guile/scm-math.c (vlscm_convert_typed_number): Use
7701         value_from_host_double.
7702         (vlscm_convert_number): Likewise.
7703         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7704         * python/py-value.c (convert_value_from_python): Likewise.
7705
7706 2019-03-06  Tom Tromey  <tom@tromey.com>
7707
7708         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7709
7710 2019-03-06  Tom Tromey  <tom@tromey.com>
7711
7712         * utils.h (free_current_contents): Don't declare.
7713         * utils.c (free_current_contents): Remove.
7714
7715 2019-03-06  Tom Tromey  <tom@tromey.com>
7716
7717         * top.c (quit_force): Update.
7718         * main.c (captured_command_loop): Update.
7719         * common/new-op.c (operator new): Update.
7720         * common/common-exceptions.c (struct catcher)
7721         <save_cleanup_chain>: Remove member.
7722         (exceptions_state_mc_init): Update.
7723         (exception_try_scope_entry): Return nullptr.
7724         (exception_try_scope_exit, exception_rethrow)
7725         (throw_exception_sjlj, throw_exception_cxx): Update.
7726         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7727         (all_cleanups, do_cleanups, discard_cleanups)
7728         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7729         (restore_cleanups, restore_final_cleanups): Don't declare.
7730         (do_final_cleanups): Remove parameter.
7731         * common/cleanups.c (cleanup_chain, make_cleanup)
7732         (make_cleanup_dtor, all_cleanups, do_cleanups)
7733         (discard_my_cleanups, discard_cleanups)
7734         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7735         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7736         (null_cleanup): Remove.
7737         (do_final_cleanups): Remove parameter.
7738
7739 2019-03-06  Tom Tromey  <tom@tromey.com>
7740
7741         * remote.c (remote_target::remote_parse_stop_reply): Use
7742         unique_xmalloc_ptr.
7743
7744 2019-03-06  Tom Tromey  <tom@tromey.com>
7745
7746         * stabsread.c (struct stabs_field_info): Rename from field_info.
7747         <list, fnlist>: Add initializers.
7748         <obstack>: New member.
7749         (read_member_functions, read_struct_fields, read_baseclasses):
7750         Allocate on obstack.  Don't use cleanups.
7751         (read_one_struct_field, read_member_functions, read_struct_fields)
7752         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7753         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7754         (read_struct_type): Update.
7755
7756 2019-03-06  Tom Tromey  <tom@tromey.com>
7757
7758         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7759         * common/filestuff.h (make_cleanup_close): Don't declare.
7760         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7761         Remove.
7762
7763 2019-03-06  Tom Tromey  <tom@tromey.com>
7764
7765         * solib-aix.c: Use make_scope_exit.
7766
7767 2019-03-06  Tom Tromey  <tom@tromey.com>
7768
7769         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7770         Use make_scope_exit.
7771
7772 2019-03-06  Tom Tromey  <tom@tromey.com>
7773
7774         * solib-svr4.c (disable_probes_interface): Remove parameter.
7775         (svr4_handle_solib_event): Use make_scope_exit.
7776
7777 2019-03-06  Tom Tromey  <tom@tromey.com>
7778
7779         * remote.c (struct stop_reply_deleter): Remove.
7780         (stop_reply_up): Update.
7781         (struct stop_reply): Derive from notif_event.  Don't typedef.
7782         <regcache>: Now a std::vector.
7783         (stop_reply_xfree): Remove.
7784         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7785         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7786         (remote_target::discard_pending_stop_replies): Use delete.
7787         (remote_target::remote_parse_stop_reply): Update.
7788         (remote_target::process_stop_reply): Update.
7789         * remote-notif.h (struct notif_event): Add virtual destructor.
7790         Remove "dtr" member.
7791         (struct notif_client) <alloc_event>: Return a unique_ptr.
7792         (notif_event_xfree): Don't declare.
7793         (notif_event_up): New typedef.
7794         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7795         (notif_event_xfree, do_notif_event_xfree): Remove.
7796         (remote_notif_state_xfree): Update.
7797
7798 2019-03-06  Tom Tromey  <tom@tromey.com>
7799
7800         * infrun.c (displaced_step_clear_cleanup): Now a
7801         forward_scope_exit type.
7802         (displaced_step_prepare_throw): Update.
7803         (displaced_step_fixup): Update.
7804
7805 2019-03-06  Tom Tromey  <tom@tromey.com>
7806
7807         * inferior.h (class inferior): Update comment.
7808         * gdbthread.h (class thread_info): Update comment.
7809
7810 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7811             Tom Tromey  <tom@tromey.com>
7812
7813         * stabsread.h (struct stab_section_list): Remove.
7814         (coffstab_build_psymtabs): Update.
7815         * dbxread.c (symbuf_sections): Now a std::vector.
7816         (sect_idx): New global.
7817         (fill_symbuf): Update.
7818         (coffstab_build_psymtabs): Change type of stabsects parameter.
7819         Update.
7820         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7821         std::vector.
7822         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7823         (coff_locate_sections): Update.
7824         (coff_symfile_read): Remove cleanups.  Update.
7825         (init_stringtab): Add storage parameter.
7826         (free_stringtab, free_stringtab_cleanup): Remove.
7827         (init_lineno): Add storage parameter.
7828         (free_linetab, free_linetab_cleanup): Remove.
7829
7830 2019-03-06  Pedro Alves  <palves@redhat.com>
7831
7832         * linux-fork.c (fork_info::clobber_regs): Delete.
7833         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7834         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7835         comment.  Adjust.
7836         (scoped_switch_fork_info::scoped_switch_fork_info)
7837         (checkpoint_command, linux_fork_context): Adjust
7838         fork_save_infrun_state calls.
7839
7840 2019-03-06  Pedro Alves  <palves@redhat.com>
7841
7842         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7843         (inf_has_multiple_threads): Return 'bool' and rewrite using
7844         inferior_info::threads().
7845
7846 2019-03-06  Pedro Alves  <palves@redhat.com>
7847
7848         * linux-fork.c: Include <list>.
7849         (fork_list): Now a std::list instance.
7850         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7851         (forks_exist_p, find_last_fork): Adjust.
7852         (new_fork): Delete.
7853         (one_fork_p): New.
7854         (add_fork): Adjust.
7855         (free_fork): Delete, folded into fork_info::~fork_info().
7856         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7857         Adjust.
7858         (init_fork_list): Delete.
7859         (linux_fork_killall, linux_fork_mourn_inferior)
7860         (linux_fork_detach, info_checkpoints_command): Adjust.
7861         (_initialize_linux_fork): No longer call init_fork_list.
7862
7863 2019-03-06  Pedro Alves  <palves@redhat.com>
7864
7865         * linux-fork.c (new_fork): New, split out of ...
7866         (add_fork): ... this.  Return void.  Move "first fork" special
7867         case from here, to ...
7868         (checkpoint_command): ... here.
7869         * linux-linux.h (add_fork): Return void.
7870
7871 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7872
7873         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7874
7875 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7876             Chris January  <chris.january@arm.com>
7877             David Lecomber  <david.lecomber@arm.com>
7878
7879         * f-exp.y: New token, UNOP_INTRINSIC.
7880         (exp): New pattern using UNOP_INTRINSIC token.
7881         (f77_keywords): Add 'abs' keyword.
7882         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7883         (value_from_host_double): New function.
7884         (evaluate_subexp_f): Support UNOP_ABS.
7885
7886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7887
7888         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7889         types.
7890
7891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7892
7893         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7894         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7895         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7896
7897 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7898
7899         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7900
7901 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7902             Chris January  <chris.january@arm.com>
7903
7904         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7905         * f-exp.y: Define 'KIND' token.
7906         (exp): New pattern for KIND expressions.
7907         (ptype): Handle types with a kind extension.
7908         (direct_abs_decl): Extend to spot kind extensions.
7909         (f77_keywords): Add 'kind' to the list.
7910         (push_kind_type): New function.
7911         (convert_to_kind_type): New function.
7912         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7913         * parse.c (operator_length_standard): Likewise.
7914         * parser-defs.h (enum type_pieces): Add tp_kind.
7915         * std-operator.def: Add UNOP_KIND.
7916
7917 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7918
7919         * f-exp.y (f_parse): Set yydebug.
7920
7921 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7922
7923         * f-lang.c (evaluate_subexp_f): New function.
7924         (exp_descriptor_f): New global.
7925         (f_language_defn): Use exp_descriptor_f instead of
7926         exp_descriptor_standard.
7927
7928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7929
7930         * f-exp.y (struct token): Add comments.
7931         (dot_ops): Remove uppercase versions and the end marker.
7932         (f77_keywords): Likewise.
7933         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7934         entries in the dot_ops array are case insensitive, and use
7935         strncasecmp to compare strings.  Also some whitespace cleanup in
7936         this area.  Similar for the f77_keywords array, except entries in
7937         this list might be case sensitive.
7938
7939 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7940
7941         * f-exp.y (struct f77_boolean_val): Add comments.
7942         (boolean_values): Remove uppercase versions, and end marker.
7943         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7944         and use strncasecmp to achieve case insensitivity.  Additionally,
7945         perform whitespace cleanup around this code.
7946
7947 2019-03-06  Tom Tromey  <tromey@adacore.com>
7948
7949         * remote-sim.c (gdbsim_target_open): Use result of
7950         gdb_argv::release.
7951
7952 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7953         Dirk Schubert  <dirk.schubert@arm.com>
7954         Chris January  <chris.january@arm.com>
7955
7956         * eval.c (evaluate_subexp_standard): Call Fortran argument
7957         wrapping logic.
7958         * f-lang.c (struct value): A value which can be passed into a
7959         Fortran function call.
7960         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7961         where appropriate.
7962         (struct type): Value ready for a Fortran function call.
7963         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7964         is needed.
7965         * f-lang.h (fortran_argument_convert): Declaration.
7966         (fortran_preserve_arg_pointer): Declaration.
7967         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7968
7969 2019-03-05  Tom Tromey  <tromey@adacore.com>
7970
7971         * python/py-prettyprint.c (print_string_repr): Remove #if.
7972         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7973
7974 2019-03-05  Tom Tromey  <tromey@adacore.com>
7975
7976         * target.c (the_dummy_target): Move later.  Change type to
7977         "dummy_target".
7978         (initialize_targets): Don't initialize the_dummy_target.
7979
7980 2019-03-05  Tom Tromey  <tromey@adacore.com>
7981
7982         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7983         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7984
7985 2019-03-05  Tom Tromey  <tromey@adacore.com>
7986
7987         * windows-nat.c (windows_nat_target::attach)
7988         (windows_nat_target::detach): Don't call gdb_flush.
7989         * valprint.c (generic_val_print, val_print, val_print_string):
7990         Don't call gdb_flush.
7991         * utils.c (defaulted_query): Don't call gdb_flush.
7992         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7993         * target.c (target_announce_detach): Don't call gdb_flush.
7994         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7995         * remote.c (extended_remote_target::attach): Don't call
7996         gdb_flush.
7997         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7998         * printcmd.c (do_examine): Don't call gdb_flush.
7999         (info_display_command): Don't call gdb_flush.
8000         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8001         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8002         * memattr.c (info_mem_command): Don't call gdb_flush.
8003         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8004         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8005         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8006         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8007         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8008         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8009         (gnu_nat_target::detach): Don't call gdb_flush.
8010         * f-valprint.c (f_val_print): Don't call gdb_flush.
8011         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8012         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8013         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8014         gdb_flush.
8015         * c-valprint.c (c_val_print): Don't call gdb_flush.
8016         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8017
8018 2019-03-05  Tom Tromey  <tromey@adacore.com>
8019
8020         * varobj.c (update_dynamic_varobj_children): Update.
8021         (install_default_visualizer): Use reset, not release.
8022         * value.c (set_internalvar): Update.
8023         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8024         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8025         ATTRIBUTE_UNUSED_RESULT.
8026
8027 2019-03-05  Tom Tromey  <tromey@adacore.com>
8028
8029         * remote.c (class scoped_remote_fd) <release>: Add
8030         ATTRIBUTE_UNUSED_RESULT.
8031
8032 2019-03-05  Tom Tromey  <tromey@adacore.com>
8033
8034         * macroexp.c (struct macro_buffer) <release>: Add
8035         ATTRIBUTE_UNUSED_RESULT.
8036
8037 2019-03-05  Tom Tromey  <tromey@adacore.com>
8038
8039         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8040         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8041         ATTRIBUTE_UNUSED_RESULT.
8042
8043 2019-03-05  Tom Tromey  <tromey@adacore.com>
8044
8045         * common/scoped_fd.h (class scoped_fd) <release>: Add
8046         ATTRIBUTE_UNUSED_RESULT.
8047
8048 2019-03-05  Tom Tromey  <tromey@adacore.com>
8049
8050         * parser-defs.h (struct parser_state) <release>: Add
8051         ATTRIBUTE_UNUSED_RESULT.
8052
8053 2019-03-05  Tom Tromey  <tromey@adacore.com>
8054
8055         * utils.h (class gdb_argv) <release>: Add
8056         ATTRIBUTE_UNUSED_RESULT.
8057         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8058
8059 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8060
8061         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8062         for-loop range, to avoid compiler warnings.
8063
8064         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8065         avoid compiler warnings about unused variables.
8066
8067         * NEWS: Mention end of support for native debugging on MS-Windows
8068         before XP.
8069
8070         PR gdb/24292
8071         * common/netstuff.c:
8072         * gdbserver/gdbreplay.c
8073         * gdbserver/remote-utils.c:
8074         * ser-tcp.c:
8075         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8076         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8077         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8078         'getaddrinfo' and 'freeaddrinfo' were not available before
8079         Windows XP, and mingw.org's MinGW headers by default define
8080         _WIN32_WINNT to 0x500.
8081
8082 2019-03-01  Gary Benson <gbenson@redhat.com>
8083
8084         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8085
8086 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8087             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8088
8089         PR gdb/8527
8090         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8091         set_sigint_trap, clear_sigint_trap.
8092
8093 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8094
8095         * target.c (target_detach): Clear the regcache and the
8096         frame cache.
8097
8098 2019-02-27  Pedro Alves  <palves@redhat.com>
8099
8100         * utils.c (set_screen_size): When we cap the height/width sizes,
8101         tweak the corresponding command variable to show "unlimited":
8102
8103 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8104             Pedro Alves  <palves@redhat.com>
8105
8106         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8107         before calling rl_set_screen_size.
8108
8109 2019-02-27  Tom Tromey  <tromey@adacore.com>
8110
8111         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8112         define.
8113         * python/py-value.c: Remove Python 2.4 workaround.
8114         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8115         workaround.
8116         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8117         Python 2.4 workaround.
8118         * python/python-internal.h: Remove Python 2.4 comment.
8119         (Py_ssize_t): Don't define.
8120         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8121         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8122         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8123         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8124         * python/python.c (do_start_initialization): Remove Python 2.4
8125         workaround.
8126         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8127         (print_children): Remove Python 2.4 workaround.
8128         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8129         workaround.
8130         (CHARBUFFERPROC_NAME): Remove.
8131         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8132         Python 2.4 workaround.
8133
8134 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8135
8136         * NEWS: Note minimum Python version.
8137
8138 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8139
8140         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8141         code from these functions.  Remove corresponding ifdefs.  Use
8142         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8143         Remove gotos and target of gotos.
8144         (infpy_search_memory): Likewise.
8145
8146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8147
8148         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8149         (hppa_gdbarch_init): Don't register deleted functions with
8150         gdbarch.
8151
8152 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8153
8154         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8155         (h8300_unwind_sp): Delete.
8156         (h8300_dummy_id): Delete.
8157         (h8300_gdbarch_init): Don't register deleted functions with
8158         gdbarch.
8159
8160 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8161
8162         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8163         (ft32_unwind_pc): Delete.
8164         (ft32_unwind_sp): Delete.
8165         (ft32_gdbarch_init): Don't register deleted functions with
8166         gdbarch.
8167
8168 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8169
8170         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8171         (frv_unwind_pc): Delete.
8172         (frv_unwind_sp): Delete.
8173         (frv_gdbarch_init): Don't register deleted functions with
8174         gdbarch.
8175
8176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8177
8178         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8179         (riscv_unwind_pc): Delete.
8180         (riscv_unwind_sp): Delete.
8181         (riscv_gdbarch_init): Don't register deleted functions with
8182         gdbarch.
8183
8184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8185
8186         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8187         (csky_unwind_pc): Delete.
8188         (csky_unwind_sp): Delete.
8189         (csky_gdbarch_init): Don't register deleted functions with
8190         gdbarch.
8191
8192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8193
8194         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8195         (cris_unwind_pc): Delete.
8196         (cris_unwind_sp): Delete.
8197         (cris_gdbarch_init): Don't register deleted functions with
8198         gdbarch.
8199
8200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8201
8202         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8203         (bfin_unwind_pc): Delete.
8204         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8205
8206 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8207
8208         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8209         (arm_unwind_pc): Delete.
8210         (arm_unwind_sp): Delete.
8211         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8212
8213 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8214
8215         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8216         (arc_unwind_pc): Delete.
8217         (arc_unwind_sp): Delete.
8218         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8219
8220 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8221
8222         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8223         (alpha_unwind_pc): Delete.
8224         (alpha_gdbarch_init): Don't register deleted functions with
8225         gdbarch.
8226
8227 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8228
8229         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8230         (aarch64_unwind_pc): Delete.
8231         (aarch64_unwind_sp): Delete.
8232         (aarch64_gdbarch_init): Don't register deleted functions with
8233         gdbarch.
8234
8235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8236
8237         * gdbtypes.c (type_align): Don't consider static members when
8238         computing structure alignment.
8239
8240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8241
8242         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8243         return 0 for other types.
8244         * arch-utils.c (default_type_align): Always return 0.
8245         * gdbarch.h: Regenerate.
8246         * gdbarch.sh (type_align): Extend comment.
8247         * gdbtypes.c (type_align): Add additional comments, always call
8248         gdbarch_type_align before applying the default rules.
8249         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8250         generic code will then apply a suitable default.
8251         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8252         types, return 0 for other types.
8253
8254 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8255
8256         * NEWS: Create a new section for the next release branch.
8257         Rename the section of the current branch, now that it has
8258         been cut.
8259
8260 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8261
8262         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8263         * version.in: Bump version to 8.3.50.DATE-git.
8264
8265 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8266
8267         * aix-thread.c (ptid_cmp): Remove unused variable.
8268         (get_signaled_thread): Likewise.
8269         (store_regs_user_thread): Likewise.
8270         (store_regs_kernel_thread): Likewise.
8271         (fetch_regs_kernel_thread): Remove shadowed variable.
8272
8273 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8274
8275         * features/riscv/32bit-cpu.xml: Add register numbers.
8276         * features/riscv/32bit-fpu.c: Regenerate.
8277         * features/riscv/32bit-fpu.xml: Add register numbers.
8278         * features/riscv/64bit-cpu.xml: Add register numbers.
8279         * features/riscv/64bit-fpu.c: Regenerate.
8280         * features/riscv/64bit-fpu.xml: Add register numbers.
8281
8282 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8283
8284         * NEWS: Mention two argument form of gdb.Value constructor.
8285         * python/py-value.c (convert_buffer_and_type_to_value): New
8286         function.
8287         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8288         Add support for handling an optional second argument.  Call
8289         convert_buffer_and_type_to_value as appropriate.
8290         * python/python-internal.h (Py_buffer_deleter): New struct.
8291         (Py_buffer_up): New typedef.
8292
8293 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8294
8295         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8296         instead of releasing ownership.
8297
8298 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8299
8300         * dwarf2read.c (open_and_init_dwp_file): Call
8301         elf_numsections instead of bfd_count_sections to initialize
8302         dwp_file->num_sections.
8303
8304 2019-02-25  Tom Tromey  <tromey@adacore.com>
8305
8306         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8307
8308 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8309
8310         * gcore.in: Add '--readnever' option when invoking GDB.
8311
8312 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8313
8314         * MAINTAINERS: Update my email address.
8315
8316 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8317
8318         * build-id.c (build_id_to_debug_bfd_1): New function.
8319         (build_id_to_debug_bfd): Look for separate debug file in
8320         sysroot.
8321
8322 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8323
8324         * gdbarch.sh: Update the copyright year range that is placed into
8325         generated files.
8326
8327 2019-02-22  Keith Seitz  <keiths@redhat.com>
8328
8329         PR symtab/23853
8330         * linespec.c (create_sals_line_offset): Search for the default
8331         symtab's filename instead of its fullname.
8332
8333 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8334
8335         * NEWS: Update style defaults.
8336
8337 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8338
8339         * main.c (captured_main_1): Disable styling in batch mode.
8340
8341 2019-02-20  Tom Tromey  <tom@tromey.com>
8342
8343         * symtab.c (symtab_symbol_info): Fix typos.
8344
8345 2019-02-20  Tom Tromey  <tromey@adacore.com>
8346
8347         * findcmd.c (_initialize_mem_search): Use upper case for
8348         metasyntactic variables.
8349
8350 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8351
8352         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8353         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8354
8355 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8356
8357         * top.h (source_file_name): Change to std::string.
8358         * top.c (source_file_name): Likewise.
8359         (command_line_input): Adjust.
8360         * cli/cli-script.c (script_from_file): Adjust.
8361
8362 2019-02-19  Tom Tromey  <tromey@adacore.com>
8363
8364         * ravenscar-thread.c
8365         (ravenscar_thread_target::update_thread_list): Don't call
8366         ada_build_task_list.
8367         * ada-lang.h (ada_build_task_list): Don't declare.
8368         * ada-tasks.c (struct ada_tasks_inferior_data)
8369         <task_list_valid_p>: Now bool.
8370         (read_known_tasks, ada_task_list_changed)
8371         (ada_tasks_invalidate_inferior_data): Update.
8372         (read_known_tasks_array): Return bool.
8373         (read_known_tasks_list): Likewise.
8374         (read_known_tasks): Return void.
8375         (ada_build_task_list): Now static.
8376
8377 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8378
8379         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8380         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8381
8382 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8383
8384         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8385         variant for ada_tasks_pspace_data_handle and
8386         ada_tasks_inferior_data_handle.
8387         (ada_tasks_pspace_data_cleanup): New function.
8388         (ada_tasks_inferior_data_cleanup): New function.
8389
8390 2019-02-17  Tom Tromey  <tom@tromey.com>
8391
8392         * macrotab.h (macro_source_fullname): Return a std::string.
8393         * macrotab.c (macro_include, check_for_redefinition)
8394         (macro_undef, macro_lookup_definition, foreach_macro)
8395         (foreach_macro_in_scope): Update.
8396         (macro_source_fullname): Return a std::string.
8397         * macrocmd.c (show_pp_source_pos): Update.
8398
8399 2019-02-17  Tom Tromey  <tom@tromey.com>
8400
8401         * macrocmd.c (show_pp_source_pos): Style the file names.
8402
8403 2019-02-17  Tom Tromey  <tom@tromey.com>
8404
8405         PR tui/24197:
8406         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8407
8408 2019-02-17  Tom Tromey  <tom@tromey.com>
8409
8410         * ada-lang.c (user_select_syms): Use filtered printing.
8411         * utils.c (wrap_style): New global.
8412         (desired_style): Remove.
8413         (emit_style_escape): Add stream parameter.
8414         (set_output_style, reset_terminal_style, prompt_for_continue):
8415         Update.
8416         (flush_wrap_buffer): Only flush gdb_stdout.
8417         (wrap_here): Set wrap_style.
8418         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8419         treat escape sequences as a character.  Change when wrap buffer is
8420         flushed.
8421         (fputs_styled): Do not set the output style when the default is
8422         requested.
8423         * ui-style.h (struct ui_file_style) <is_default>: New method.
8424         * source.c (print_source_lines_base): Emit escape sequences in one
8425         piece.
8426
8427 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8428
8429         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8430         integers and enumeration types.
8431
8432 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8433
8434         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8435         instead of lookup_symbol_in_language
8436         (do_exact_match): New function.
8437         (ada_get_symbol_name_matcher): Return do_exact_match when
8438         doing a verbatim match.
8439
8440 2019-02-15  Tom Tromey  <tromey@adacore.com>
8441
8442         * ravenscar-thread.c (ravenscar_thread_target::resume)
8443         (ravenscar_thread_target::wait): Special case wildcard requests.
8444
8445 2019-02-15  Tom Tromey  <tromey@adacore.com>
8446
8447         * ravenscar-thread.c (base_ptid): Remove.
8448         (struct ravenscar_thread_target) <close>: New method.
8449         <m_base_ptid>: New member.
8450         <update_inferior_ptid, active_task, task_is_currently_active,
8451         runtime_initialized>: Declare methods.
8452         <ravenscar_thread_target>: Add constructor.
8453         (ravenscar_thread_target::task_is_currently_active)
8454         (ravenscar_thread_target::update_inferior_ptid)
8455         (ravenscar_runtime_initialized): Rename.  Now methods.
8456         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8457         (ravenscar_thread_target::update_thread_list): Update.
8458         (ravenscar_thread_target::active_task): Now method.
8459         (ravenscar_thread_target::store_registers)
8460         (ravenscar_thread_target::prepare_to_store)
8461         (ravenscar_thread_target::prepare_to_store)
8462         (ravenscar_thread_target::mourn_inferior): Update.
8463         (ravenscar_inferior_created): Use "new" to create target.
8464         (ravenscar_thread_target::get_ada_task_ptid): Update.
8465         (_initialize_ravenscar): Don't initialize base_ptid.
8466         (ravenscar_ops): Remove global.
8467
8468 2019-02-15  Tom Tromey  <tromey@adacore.com>
8469
8470         * target.h (push_target): Declare new overload.
8471         * target.c (push_target): New overload, taking an rvalue reference.
8472         * remote.c (remote_target::open_1): Use push_target overload.
8473         * corelow.c (core_target_open): Use push_target overload.
8474
8475 2019-02-15  Tom Tromey  <tromey@adacore.com>
8476
8477         * ravenscar-thread.c (is_ravenscar_task)
8478         (ravenscar_task_is_currently_active): Return bool.
8479         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8480         (_initialize_ravenscar): Remove "(void)".
8481         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8482         Return bool.
8483
8484 2019-02-15  Tom Tromey  <tromey@adacore.com>
8485
8486         * ravenscar-thread.c (ravenscar_runtime_initializer)
8487         (has_ravenscar_runtime, get_running_thread_id)
8488         (ravenscar_thread_target::resume): Fix indentation.
8489
8490 2019-02-15  Tom Tromey  <tromey@adacore.com>
8491
8492         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8493         from ravenscar_arch_ops.
8494         (sparc_ravenscar_ops::fetch_registers)
8495         (sparc_ravenscar_ops::store_registers): Now methods.
8496         (sparc_ravenscar_prepare_to_store): Remove.
8497         (sparc_ravenscar_ops): Redefine.
8498         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8499         methods and destructor.  Remove members.
8500         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8501         (ravenscar_thread_target::store_registers)
8502         (ravenscar_thread_target::prepare_to_store): Update.
8503         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8504         Remove.
8505         (struct ppc_ravenscar_powerpc_ops): Derive from
8506         ravenscar_arch_ops.
8507         (ppc_ravenscar_powerpc_ops::fetch_registers)
8508         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8509         (ppc_ravenscar_powerpc_ops): Redefine.
8510         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8511         (ppc_ravenscar_e500_ops::fetch_registers)
8512         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8513         (ppc_ravenscar_e500_ops): Redefine.
8514         * aarch64-ravenscar-thread.c
8515         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8516         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8517         (aarch64_ravenscar_fetch_registers)
8518         (aarch64_ravenscar_store_registers): Now methods.
8519         (aarch64_ravenscar_ops): Redefine.
8520
8521 2019-02-15  Tom Tromey  <tromey@adacore.com>
8522
8523         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8524         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8525         (ravenscar_thread_target::stopped_by_watchpoint)
8526         (ravenscar_thread_target::stopped_data_address)
8527         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8528
8529 2019-02-15  Tom Tromey  <tromey@adacore.com>
8530
8531         * ravenscar-thread.c: Fix some typos.
8532
8533 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8534             Tom Tromey  <tromey@adacore.com>
8535
8536         * ada-lang.c (ada_exception_sal): Change addr_string to a
8537         std::string.
8538         (create_ada_exception_catchpoint): Update.
8539
8540 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8541             Tom Tromey  <tromey@adacore.com>
8542
8543         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8544         (bp_location_ops): Remove.
8545         (base_breakpoint_allocate_location): Update.
8546         (free_bp_location): Update.
8547         * ada-lang.c (class ada_catchpoint_location)
8548         <ada_catchpoint_location>: Remove ops parameter.
8549         (ada_catchpoint_location_dtor): Remove.
8550         (ada_catchpoint_location_ops): Remove.
8551         (allocate_location_exception): Update.
8552         * breakpoint.h (struct bp_location_ops): Remove.
8553         (class bp_location) <bp_location>: Remove bp_location_ops
8554         parameter.
8555         <~bp_location>: Add destructor.
8556         <ops>: Remove.
8557
8558 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8559             Pedro Alves  <palves@redhat.com>
8560
8561         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8562         'PATH_MAX'.
8563
8564 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8565             Samuel Thibault  <samuel.thibault@gnu.org>
8566             Thomas Schwinge  <thomas@codesourcery.com>
8567
8568         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8569         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8570
8571 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8572
8573         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8574         (check_empty): Use "const char *".
8575
8576         * gnu-nat.c (gnu_nat_target::detach): Instead of
8577         'detach_inferior (pid)' call
8578         'detach_inferior (find_inferior_pid (pid))'.
8579
8580         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8581         'nat/fork-inferior.o'.
8582         * gnu-nat.c: #include "nat/fork-inferior.h".
8583
8584         * gnu-nat.c (gnu_nat_target::detach): Instead of
8585         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8586         * gnu-nat.h: #include "inf-child.h".
8587         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8588         'i386_gnu_nat_target::fetch_registers'.
8589         (gnu_store_registers): Rename/move to
8590         'i386_gnu_nat_target::store_registers'.
8591
8592         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8593         * gnu-nat.h (mach_thread_info): New function.
8594         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8595
8596         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8597
8598 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8599
8600         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8601
8602 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8603
8604         * windows-nat.c (windows_add_thread): Add new parameter
8605         "main_thread_p" with default value set to false.  Update
8606         function documentation as well as all callers.
8607         (windows_delete_thread): Likewise.
8608         (fake_create_process): Update call to windows_add_thread.
8609         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8610         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8611         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8612         call to windows_delete_thread.
8613
8614 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8615
8616         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8617
8618 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8619
8620         * symfile.c (find_separate_debug_file): Use canonical path of
8621         sysroot with child_path instead of gdb_sysroot if it is valid.
8622
8623 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8624
8625         * symfile.c (find_separate_debug_file): Use child_path to
8626         determine if an object file is under a sysroot.
8627
8628 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8629
8630         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8631         unittests/child-path-selftests.c.
8632         * common/pathstuff.c (child_path): New function.
8633         * common/pathstuff.h (child_path): New prototype.
8634         * unittests/child-path-selftests.c: New file.
8635
8636 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8637
8638         * symfile.c (find_separate_debug_file): Look for separate debug
8639         files in debug directories under the sysroot.
8640
8641 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8642
8643         * symtab.h (struct minimal_symbol data_p): New const method.
8644         (struct minimal_symbol text_p): Likewise.
8645         * symtab.c (output_source_filename): Use file name style
8646         to print file name.
8647         (print_symbol_info): Likewise.
8648         (print_msymbol_info): Use address style to print addresses.
8649         Use function name style to print executable text symbols.
8650         (expand_symtab_containing_pc): Use data_p.
8651         (find_pc_sect_compunit_symtab): Likewise.
8652
8653 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8654
8655         * breakpoint.c (describe_other_breakpoints): Use address style
8656         to print addresses.
8657         (say_where): Likewise.
8658
8659 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8660
8661         * ada-typeprint.c (print_func_type): Print function name
8662         style to print function name.
8663         * c-typeprint.c (c_print_type_1): Likewise.
8664
8665 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8666
8667         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8668         for execve.
8669
8670 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8671
8672         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8673         type_stack.
8674
8675 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8676
8677         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8678         TYPE_CODE_REF types.
8679
8680 2019-02-08  Jim Wilson  <jimw@sifive.com>
8681
8682         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8683         (riscv_linux_fregset): New.
8684         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8685
8686 2019-02-07  Tom Tromey  <tom@tromey.com>
8687
8688         * thread.c (thread_cancel_execution_command): Update.
8689         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8690         methods.
8691         (struct thread_fsm_ops): Remove.
8692         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8693         (thread_fsm_should_stop, thread_fsm_return_value)
8694         (thread_fsm_set_finished, thread_fsm_finished_p)
8695         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8696         Don't declare.
8697         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8698         * infrun.c (clear_proceed_status_thread)
8699         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8700         (print_stop_event): Update.
8701         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8702         Add constructor.
8703         (step_command_fsm_ops): Remove.
8704         (new_step_command_fsm): Remove.
8705         (step_1): Update.
8706         (step_command_fsm::should_stop): Rename from
8707         step_command_fsm_should_stop.
8708         (step_command_fsm::clean_up): Rename from
8709         step_command_fsm_clean_up.
8710         (step_command_fsm::do_async_reply_reason): Rename from
8711         step_command_fsm_async_reply_reason.
8712         (struct until_next_fsm): Inherit from thread_fsm.  Add
8713         constructor.
8714         (until_next_fsm_ops): Remove.
8715         (new_until_next_fsm): Remove.
8716         (until_next_fsm::should_stop): Rename from
8717         until_next_fsm_should_stop.
8718         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8719         (until_next_fsm::do_async_reply_reason): Rename from
8720         until_next_fsm_async_reply_reason.
8721         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8722         constructor.  Change type of breakpoint.
8723         (finish_command_fsm_ops): Remove.
8724         (new_finish_command_fsm): Remove.
8725         (finish_command_fsm::should_stop): Rename from
8726         finish_command_fsm_should_stop.
8727         (finish_command_fsm::clean_up): Rename from
8728         finish_command_fsm_clean_up.
8729         (finish_command_fsm::return_value): Rename from
8730         finish_command_fsm_return_value.
8731         (finish_command_fsm::do_async_reply_reason): Rename from
8732         finish_command_fsm_async_reply_reason.
8733         (finish_command): Update.
8734         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8735         Add constructor.
8736         (call_thread_fsm_ops): Remove.
8737         (call_thread_fsm::call_thread_fsm): Rename from
8738         new_call_thread_fsm.
8739         (call_thread_fsm::should_stop): Rename from
8740         call_thread_fsm_should_stop.
8741         (call_thread_fsm::should_notify_stop): Rename from
8742         call_thread_fsm_should_notify_stop.
8743         (run_inferior_call, call_function_by_hand_dummy): Update.
8744         * cli/cli-interp.c (should_print_stop_to_console): Update.
8745         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8746         Add constructor.  Change type of location_breakpoint,
8747         caller_breakpoint.
8748         (until_break_fsm_ops): Remove.
8749         (new_until_break_fsm): Remove.
8750         (until_break_fsm::should_stop): Rename from
8751         until_break_fsm_should_stop.
8752         (until_break_fsm::clean_up): Rename from
8753         until_break_fsm_clean_up.
8754         (until_break_fsm::do_async_reply_reason): Rename from
8755         until_break_fsm_async_reply_reason.
8756         (until_break_command): Update.
8757         * thread-fsm.c: Remove.
8758         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8759
8760 2019-02-07  Tom Tromey  <tom@tromey.com>
8761
8762         * yy-remap.h: Add include guard.
8763         * xtensa-tdep.h: Add include guard.
8764         * xcoffread.h: Rename include guard.
8765         * varobj-iter.h: Add include guard.
8766         * tui/tui.h: Rename include guard.
8767         * tui/tui-winsource.h: Rename include guard.
8768         * tui/tui-wingeneral.h: Rename include guard.
8769         * tui/tui-windata.h: Rename include guard.
8770         * tui/tui-win.h: Rename include guard.
8771         * tui/tui-stack.h: Rename include guard.
8772         * tui/tui-source.h: Rename include guard.
8773         * tui/tui-regs.h: Rename include guard.
8774         * tui/tui-out.h: Rename include guard.
8775         * tui/tui-layout.h: Rename include guard.
8776         * tui/tui-io.h: Rename include guard.
8777         * tui/tui-hooks.h: Rename include guard.
8778         * tui/tui-file.h: Rename include guard.
8779         * tui/tui-disasm.h: Rename include guard.
8780         * tui/tui-data.h: Rename include guard.
8781         * tui/tui-command.h: Rename include guard.
8782         * tic6x-tdep.h: Add include guard.
8783         * target/waitstatus.h: Rename include guard.
8784         * target/wait.h: Rename include guard.
8785         * target/target.h: Rename include guard.
8786         * target/resume.h: Rename include guard.
8787         * target-float.h: Rename include guard.
8788         * stabsread.h: Add include guard.
8789         * rs6000-tdep.h: Add include guard.
8790         * riscv-fbsd-tdep.h: Add include guard.
8791         * regformats/regdef.h: Rename include guard.
8792         * record.h: Rename include guard.
8793         * python/python.h: Rename include guard.
8794         * python/python-internal.h: Rename include guard.
8795         * python/py-stopevent.h: Rename include guard.
8796         * python/py-ref.h: Rename include guard.
8797         * python/py-record.h: Rename include guard.
8798         * python/py-record-full.h: Rename include guard.
8799         * python/py-record-btrace.h: Rename include guard.
8800         * python/py-instruction.h: Rename include guard.
8801         * python/py-events.h: Rename include guard.
8802         * python/py-event.h: Rename include guard.
8803         * procfs.h: Add include guard.
8804         * proc-utils.h: Add include guard.
8805         * p-lang.h: Add include guard.
8806         * or1k-tdep.h: Rename include guard.
8807         * observable.h: Rename include guard.
8808         * nto-tdep.h: Rename include guard.
8809         * nat/x86-linux.h: Rename include guard.
8810         * nat/x86-linux-dregs.h: Rename include guard.
8811         * nat/x86-gcc-cpuid.h: Add include guard.
8812         * nat/x86-dregs.h: Rename include guard.
8813         * nat/x86-cpuid.h: Rename include guard.
8814         * nat/ppc-linux.h: Rename include guard.
8815         * nat/mips-linux-watch.h: Rename include guard.
8816         * nat/linux-waitpid.h: Rename include guard.
8817         * nat/linux-ptrace.h: Rename include guard.
8818         * nat/linux-procfs.h: Rename include guard.
8819         * nat/linux-osdata.h: Rename include guard.
8820         * nat/linux-nat.h: Rename include guard.
8821         * nat/linux-namespaces.h: Rename include guard.
8822         * nat/linux-btrace.h: Rename include guard.
8823         * nat/glibc_thread_db.h: Rename include guard.
8824         * nat/gdb_thread_db.h: Rename include guard.
8825         * nat/gdb_ptrace.h: Rename include guard.
8826         * nat/fork-inferior.h: Rename include guard.
8827         * nat/amd64-linux-siginfo.h: Rename include guard.
8828         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8829         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8830         * nat/aarch64-linux.h: Rename include guard.
8831         * nat/aarch64-linux-hw-point.h: Rename include guard.
8832         * mn10300-tdep.h: Add include guard.
8833         * mips-linux-tdep.h: Add include guard.
8834         * mi/mi-parse.h: Rename include guard.
8835         * mi/mi-out.h: Rename include guard.
8836         * mi/mi-main.h: Rename include guard.
8837         * mi/mi-interp.h: Rename include guard.
8838         * mi/mi-getopt.h: Rename include guard.
8839         * mi/mi-console.h: Rename include guard.
8840         * mi/mi-common.h: Rename include guard.
8841         * mi/mi-cmds.h: Rename include guard.
8842         * mi/mi-cmd-break.h: Rename include guard.
8843         * m2-lang.h: Add include guard.
8844         * location.h: Rename include guard.
8845         * linux-record.h: Rename include guard.
8846         * linux-nat.h: Add include guard.
8847         * linux-fork.h: Add include guard.
8848         * i386-darwin-tdep.h: Rename include guard.
8849         * hppa-linux-offsets.h: Add include guard.
8850         * guile/guile.h: Rename include guard.
8851         * guile/guile-internal.h: Rename include guard.
8852         * gnu-nat.h: Rename include guard.
8853         * gdb-stabs.h: Rename include guard.
8854         * frv-tdep.h: Add include guard.
8855         * f-lang.h: Add include guard.
8856         * event-loop.h: Add include guard.
8857         * darwin-nat.h: Rename include guard.
8858         * cp-abi.h: Rename include guard.
8859         * config/sparc/nm-sol2.h: Rename include guard.
8860         * config/nm-nto.h: Rename include guard.
8861         * config/nm-linux.h: Add include guard.
8862         * config/i386/nm-i386gnu.h: Rename include guard.
8863         * config/djgpp/nl_types.h: Rename include guard.
8864         * config/djgpp/langinfo.h: Rename include guard.
8865         * compile/gcc-cp-plugin.h: Add include guard.
8866         * compile/gcc-c-plugin.h: Add include guard.
8867         * compile/compile.h: Rename include guard.
8868         * compile/compile-object-run.h: Rename include guard.
8869         * compile/compile-object-load.h: Rename include guard.
8870         * compile/compile-internal.h: Rename include guard.
8871         * compile/compile-cplus.h: Rename include guard.
8872         * compile/compile-c.h: Rename include guard.
8873         * common/xml-utils.h: Rename include guard.
8874         * common/x86-xstate.h: Rename include guard.
8875         * common/version.h: Rename include guard.
8876         * common/vec.h: Rename include guard.
8877         * common/tdesc.h: Rename include guard.
8878         * common/selftest.h: Rename include guard.
8879         * common/scoped_restore.h: Rename include guard.
8880         * common/scoped_mmap.h: Rename include guard.
8881         * common/scoped_fd.h: Rename include guard.
8882         * common/safe-iterator.h: Rename include guard.
8883         * common/run-time-clock.h: Rename include guard.
8884         * common/refcounted-object.h: Rename include guard.
8885         * common/queue.h: Rename include guard.
8886         * common/ptid.h: Rename include guard.
8887         * common/print-utils.h: Rename include guard.
8888         * common/preprocessor.h: Rename include guard.
8889         * common/pathstuff.h: Rename include guard.
8890         * common/observable.h: Rename include guard.
8891         * common/netstuff.h: Rename include guard.
8892         * common/job-control.h: Rename include guard.
8893         * common/host-defs.h: Rename include guard.
8894         * common/gdb_wait.h: Rename include guard.
8895         * common/gdb_vecs.h: Rename include guard.
8896         * common/gdb_unlinker.h: Rename include guard.
8897         * common/gdb_unique_ptr.h: Rename include guard.
8898         * common/gdb_tilde_expand.h: Rename include guard.
8899         * common/gdb_sys_time.h: Rename include guard.
8900         * common/gdb_string_view.h: Rename include guard.
8901         * common/gdb_splay_tree.h: Rename include guard.
8902         * common/gdb_setjmp.h: Rename include guard.
8903         * common/gdb_ref_ptr.h: Rename include guard.
8904         * common/gdb_optional.h: Rename include guard.
8905         * common/gdb_locale.h: Rename include guard.
8906         * common/gdb_assert.h: Rename include guard.
8907         * common/filtered-iterator.h: Rename include guard.
8908         * common/filestuff.h: Rename include guard.
8909         * common/fileio.h: Rename include guard.
8910         * common/environ.h: Rename include guard.
8911         * common/common-utils.h: Rename include guard.
8912         * common/common-types.h: Rename include guard.
8913         * common/common-regcache.h: Rename include guard.
8914         * common/common-inferior.h: Rename include guard.
8915         * common/common-gdbthread.h: Rename include guard.
8916         * common/common-exceptions.h: Rename include guard.
8917         * common/common-defs.h: Rename include guard.
8918         * common/common-debug.h: Rename include guard.
8919         * common/cleanups.h: Rename include guard.
8920         * common/buffer.h: Rename include guard.
8921         * common/btrace-common.h: Rename include guard.
8922         * common/break-common.h: Rename include guard.
8923         * cli/cli-utils.h: Rename include guard.
8924         * cli/cli-style.h: Rename include guard.
8925         * cli/cli-setshow.h: Rename include guard.
8926         * cli/cli-script.h: Rename include guard.
8927         * cli/cli-interp.h: Rename include guard.
8928         * cli/cli-decode.h: Rename include guard.
8929         * cli/cli-cmds.h: Rename include guard.
8930         * charset-list.h: Add include guard.
8931         * buildsym-legacy.h: Rename include guard.
8932         * bfin-tdep.h: Add include guard.
8933         * ax.h: Rename include guard.
8934         * arm-linux-tdep.h: Add include guard.
8935         * arm-fbsd-tdep.h: Add include guard.
8936         * arch/xtensa.h: Rename include guard.
8937         * arch/tic6x.h: Add include guard.
8938         * arch/i386.h: Add include guard.
8939         * arch/arm.h: Rename include guard.
8940         * arch/arm-linux.h: Rename include guard.
8941         * arch/arm-get-next-pcs.h: Rename include guard.
8942         * arch/amd64.h: Add include guard.
8943         * arch/aarch64-insn.h: Rename include guard.
8944         * arch-utils.h: Rename include guard.
8945         * annotate.h: Add include guard.
8946         * amd64-darwin-tdep.h: Rename include guard.
8947         * aarch64-linux-tdep.h: Add include guard.
8948         * aarch64-fbsd-tdep.h: Add include guard.
8949         * aarch32-linux-nat.h: Add include guard.
8950
8951 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8952
8953         * macrotab.c (macro_define_internal): New function that
8954         factorizes macro_define_object_internal and macro_define_function
8955         code.
8956         (macro_define_object_internal): Use macro_define_internal.
8957         (macro_define_function): Likewise.
8958
8959 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8960
8961         * macrocmd.c (extract_identifier): Return
8962         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8963         callers.
8964
8965 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8966
8967         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8968
8969 2019-02-05  Tom Tromey  <tom@tromey.com>
8970
8971         * target.c (target_stack::unpush): Move assertion earlier.
8972
8973 2019-01-30  Tom Tromey  <tom@tromey.com>
8974
8975         PR python/23615:
8976         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8977         (gdbpy_parse_and_eval): Likewise.
8978         * python/python-internal.h (gdbpy_allow_threads): New class.
8979
8980 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8981
8982         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8983         (aarch64_fbsd_fpregmap): Move earlier.
8984         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8985         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8986         instead of individual calls to trad_frame_set_reg_addr.
8987         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8988         earlier.
8989         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8990         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8991         instead of individual calls to trad_frame_set_reg_addr.
8992
8993 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8994
8995         * CONTRIBUTE: Replace contribution list with wiki link.
8996
8997 2019-01-25  Tom Tromey  <tom@tromey.com>
8998
8999         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9000
9001 2019-01-25  Tom Tromey  <tom@tromey.com>
9002
9003         * xtensa-linux-nat.c: Fix common/ includes.
9004         * xml-support.h: Fix common/ includes.
9005         * xml-support.c: Fix common/ includes.
9006         * x86-linux-nat.c: Fix common/ includes.
9007         * windows-nat.c: Fix common/ includes.
9008         * varobj.h: Fix common/ includes.
9009         * varobj.c: Fix common/ includes.
9010         * value.c: Fix common/ includes.
9011         * valops.c: Fix common/ includes.
9012         * utils.c: Fix common/ includes.
9013         * unittests/xml-utils-selftests.c: Fix common/ includes.
9014         * unittests/utils-selftests.c: Fix common/ includes.
9015         * unittests/unpack-selftests.c: Fix common/ includes.
9016         * unittests/tracepoint-selftests.c: Fix common/ includes.
9017         * unittests/style-selftests.c: Fix common/ includes.
9018         * unittests/string_view-selftests.c: Fix common/ includes.
9019         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9020         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9021         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9022         * unittests/rsp-low-selftests.c: Fix common/ includes.
9023         * unittests/parse-connection-spec-selftests.c: Fix common/
9024         includes.
9025         * unittests/optional-selftests.c: Fix common/ includes.
9026         * unittests/offset-type-selftests.c: Fix common/ includes.
9027         * unittests/observable-selftests.c: Fix common/ includes.
9028         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9029         * unittests/memrange-selftests.c: Fix common/ includes.
9030         * unittests/memory-map-selftests.c: Fix common/ includes.
9031         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9032         * unittests/function-view-selftests.c: Fix common/ includes.
9033         * unittests/environ-selftests.c: Fix common/ includes.
9034         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9035         * unittests/common-utils-selftests.c: Fix common/ includes.
9036         * unittests/cli-utils-selftests.c: Fix common/ includes.
9037         * unittests/array-view-selftests.c: Fix common/ includes.
9038         * ui-file.c: Fix common/ includes.
9039         * tui/tui-io.c: Fix common/ includes.
9040         * tracepoint.h: Fix common/ includes.
9041         * tracepoint.c: Fix common/ includes.
9042         * tracefile-tfile.c: Fix common/ includes.
9043         * top.h: Fix common/ includes.
9044         * top.c: Fix common/ includes.
9045         * thread.c: Fix common/ includes.
9046         * target/waitstatus.h: Fix common/ includes.
9047         * target/waitstatus.c: Fix common/ includes.
9048         * target.h: Fix common/ includes.
9049         * target.c: Fix common/ includes.
9050         * target-memory.c: Fix common/ includes.
9051         * target-descriptions.c: Fix common/ includes.
9052         * symtab.h: Fix common/ includes.
9053         * symfile.c: Fix common/ includes.
9054         * stap-probe.c: Fix common/ includes.
9055         * spu-linux-nat.c: Fix common/ includes.
9056         * sparc-nat.c: Fix common/ includes.
9057         * source.c: Fix common/ includes.
9058         * solib.c: Fix common/ includes.
9059         * solib-target.c: Fix common/ includes.
9060         * ser-unix.c: Fix common/ includes.
9061         * ser-tcp.c: Fix common/ includes.
9062         * ser-pipe.c: Fix common/ includes.
9063         * ser-base.c: Fix common/ includes.
9064         * selftest-arch.c: Fix common/ includes.
9065         * s12z-tdep.c: Fix common/ includes.
9066         * rust-exp.y: Fix common/ includes.
9067         * rs6000-aix-tdep.c: Fix common/ includes.
9068         * riscv-tdep.c: Fix common/ includes.
9069         * remote.c: Fix common/ includes.
9070         * remote-notif.h: Fix common/ includes.
9071         * remote-fileio.h: Fix common/ includes.
9072         * remote-fileio.c: Fix common/ includes.
9073         * regcache.h: Fix common/ includes.
9074         * regcache.c: Fix common/ includes.
9075         * record-btrace.c: Fix common/ includes.
9076         * python/python.c: Fix common/ includes.
9077         * python/py-type.c: Fix common/ includes.
9078         * python/py-inferior.c: Fix common/ includes.
9079         * progspace.h: Fix common/ includes.
9080         * producer.c: Fix common/ includes.
9081         * procfs.c: Fix common/ includes.
9082         * proc-api.c: Fix common/ includes.
9083         * printcmd.c: Fix common/ includes.
9084         * ppc-linux-nat.c: Fix common/ includes.
9085         * parser-defs.h: Fix common/ includes.
9086         * osdata.c: Fix common/ includes.
9087         * obsd-nat.c: Fix common/ includes.
9088         * nat/x86-linux.c: Fix common/ includes.
9089         * nat/x86-linux-dregs.c: Fix common/ includes.
9090         * nat/x86-dregs.h: Fix common/ includes.
9091         * nat/x86-dregs.c: Fix common/ includes.
9092         * nat/ppc-linux.c: Fix common/ includes.
9093         * nat/mips-linux-watch.h: Fix common/ includes.
9094         * nat/mips-linux-watch.c: Fix common/ includes.
9095         * nat/linux-waitpid.c: Fix common/ includes.
9096         * nat/linux-ptrace.h: Fix common/ includes.
9097         * nat/linux-ptrace.c: Fix common/ includes.
9098         * nat/linux-procfs.c: Fix common/ includes.
9099         * nat/linux-personality.c: Fix common/ includes.
9100         * nat/linux-osdata.c: Fix common/ includes.
9101         * nat/linux-namespaces.c: Fix common/ includes.
9102         * nat/linux-btrace.h: Fix common/ includes.
9103         * nat/linux-btrace.c: Fix common/ includes.
9104         * nat/fork-inferior.c: Fix common/ includes.
9105         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9106         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9107         * nat/aarch64-linux.c: Fix common/ includes.
9108         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9109         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9110         * namespace.h: Fix common/ includes.
9111         * mips-linux-tdep.c: Fix common/ includes.
9112         * minsyms.c: Fix common/ includes.
9113         * mi/mi-parse.h: Fix common/ includes.
9114         * mi/mi-main.c: Fix common/ includes.
9115         * mi/mi-cmd-env.c: Fix common/ includes.
9116         * memrange.h: Fix common/ includes.
9117         * memattr.c: Fix common/ includes.
9118         * maint.h: Fix common/ includes.
9119         * maint.c: Fix common/ includes.
9120         * main.c: Fix common/ includes.
9121         * machoread.c: Fix common/ includes.
9122         * location.c: Fix common/ includes.
9123         * linux-thread-db.c: Fix common/ includes.
9124         * linux-nat.c: Fix common/ includes.
9125         * linux-fork.c: Fix common/ includes.
9126         * inline-frame.c: Fix common/ includes.
9127         * infrun.c: Fix common/ includes.
9128         * inflow.c: Fix common/ includes.
9129         * inferior.h: Fix common/ includes.
9130         * inferior.c: Fix common/ includes.
9131         * infcmd.c: Fix common/ includes.
9132         * inf-ptrace.c: Fix common/ includes.
9133         * inf-child.c: Fix common/ includes.
9134         * ia64-linux-nat.c: Fix common/ includes.
9135         * i387-tdep.c: Fix common/ includes.
9136         * i386-tdep.c: Fix common/ includes.
9137         * i386-linux-tdep.c: Fix common/ includes.
9138         * i386-linux-nat.c: Fix common/ includes.
9139         * i386-go32-tdep.c: Fix common/ includes.
9140         * i386-fbsd-tdep.c: Fix common/ includes.
9141         * i386-fbsd-nat.c: Fix common/ includes.
9142         * guile/scm-type.c: Fix common/ includes.
9143         * guile/guile.c: Fix common/ includes.
9144         * go32-nat.c: Fix common/ includes.
9145         * gnu-nat.c: Fix common/ includes.
9146         * gdbthread.h: Fix common/ includes.
9147         * gdbarch-selftests.c: Fix common/ includes.
9148         * gdb_usleep.c: Fix common/ includes.
9149         * gdb_select.h: Fix common/ includes.
9150         * gdb_bfd.c: Fix common/ includes.
9151         * gcore.c: Fix common/ includes.
9152         * fork-child.c: Fix common/ includes.
9153         * findvar.c: Fix common/ includes.
9154         * fbsd-nat.c: Fix common/ includes.
9155         * event-top.c: Fix common/ includes.
9156         * event-loop.c: Fix common/ includes.
9157         * dwarf2read.c: Fix common/ includes.
9158         * dwarf2loc.c: Fix common/ includes.
9159         * dwarf2-frame.c: Fix common/ includes.
9160         * dwarf-index-cache.c: Fix common/ includes.
9161         * dtrace-probe.c: Fix common/ includes.
9162         * disasm-selftests.c: Fix common/ includes.
9163         * defs.h: Fix common/ includes.
9164         * csky-tdep.c: Fix common/ includes.
9165         * cp-valprint.c: Fix common/ includes.
9166         * cp-support.h: Fix common/ includes.
9167         * cp-support.c: Fix common/ includes.
9168         * corelow.c: Fix common/ includes.
9169         * completer.h: Fix common/ includes.
9170         * completer.c: Fix common/ includes.
9171         * compile/compile.c: Fix common/ includes.
9172         * compile/compile-loc2c.c: Fix common/ includes.
9173         * compile/compile-cplus-types.c: Fix common/ includes.
9174         * compile/compile-cplus-symbols.c: Fix common/ includes.
9175         * command.h: Fix common/ includes.
9176         * cli/cli-dump.c: Fix common/ includes.
9177         * cli/cli-cmds.c: Fix common/ includes.
9178         * charset.c: Fix common/ includes.
9179         * build-id.c: Fix common/ includes.
9180         * btrace.h: Fix common/ includes.
9181         * btrace.c: Fix common/ includes.
9182         * breakpoint.h: Fix common/ includes.
9183         * breakpoint.c: Fix common/ includes.
9184         * ax.h:
9185         (enum agent_op): Fix common/ includes.
9186         * ax-general.c (struct aop_map): Fix common/ includes.
9187         * ax-gdb.c: Fix common/ includes.
9188         * auxv.c: Fix common/ includes.
9189         * auto-load.c: Fix common/ includes.
9190         * arm-tdep.c: Fix common/ includes.
9191         * arch/riscv.c: Fix common/ includes.
9192         * arch/ppc-linux-common.c: Fix common/ includes.
9193         * arch/i386.c: Fix common/ includes.
9194         * arch/arm.c: Fix common/ includes.
9195         * arch/arm-linux.c: Fix common/ includes.
9196         * arch/arm-get-next-pcs.c: Fix common/ includes.
9197         * arch/amd64.c: Fix common/ includes.
9198         * arch/aarch64.c: Fix common/ includes.
9199         * arch/aarch64-insn.c: Fix common/ includes.
9200         * arch-utils.c: Fix common/ includes.
9201         * amd64-windows-tdep.c: Fix common/ includes.
9202         * amd64-tdep.c: Fix common/ includes.
9203         * amd64-sol2-tdep.c: Fix common/ includes.
9204         * amd64-obsd-tdep.c: Fix common/ includes.
9205         * amd64-nbsd-tdep.c: Fix common/ includes.
9206         * amd64-linux-tdep.c: Fix common/ includes.
9207         * amd64-linux-nat.c: Fix common/ includes.
9208         * amd64-fbsd-tdep.c: Fix common/ includes.
9209         * amd64-fbsd-nat.c: Fix common/ includes.
9210         * amd64-dicos-tdep.c: Fix common/ includes.
9211         * amd64-darwin-tdep.c: Fix common/ includes.
9212         * agent.c: Fix common/ includes.
9213         * ada-lang.h: Fix common/ includes.
9214         * ada-lang.c: Fix common/ includes.
9215         * aarch64-tdep.c: Fix common/ includes.
9216
9217 2019-01-25  Tom Tromey  <tom@tromey.com>
9218
9219         * common/create-version.sh: Use common/version.h.
9220
9221 2019-01-24  Pedro Alves  <palves@redhat.com>
9222
9223         * infrun.c (signal_stop, signal_print, signal_program)
9224         (signal_catch, signal_pass): Now arrays instead of pointers.
9225         (update_signals_program_target, do_target_resume)
9226         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9227         * linux-nat.c (linux_nat_target::pass_signals)
9228         (linux_nat_target::create_inferior, linux_nat_target::attach):
9229         Adjust.
9230         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9231         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9232         * procfs.c (procfs_target::pass_signals): Adjust.
9233         * record-full.c (record_full_target::resume): Adjust.
9234         * remote.c (remote_target::pass_signals)
9235         (remote_target::program_signals): Adjust.
9236         * target-debug.h (target_debug_print_signals): Now takes a
9237         gdb::array_view as parameter.  Adjust.
9238         * target.h (target_ops) <pass_signals, program_signals>: Replace
9239         pointer and length parameters with gdb::array_view.
9240         (target_pass_signals, target_program_signals): Likewise.
9241         * target-delegates.c: Regenerate.
9242
9243 2019-01-24  Pedro Alves  <palves@redhat.com>
9244
9245         * common/forward-scope-exit.h
9246         (forward_scope_exit::forward_scope_exit): Pass arguments to
9247         m_bind_function directly, instead of creating a std::bind and
9248         copying that.
9249
9250 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9251
9252         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9253         for static members.
9254         (pass_in_v_vfp_candidate): Likewise.
9255
9256 2019-01-23  Tom Tromey  <tom@tromey.com>
9257             Pedro Alves  <palves@redhat.com>
9258
9259         * regcache.c (class regcache_invalidator): Remove.
9260         (regcache::raw_write): Use make_scope_exit.
9261
9262 2019-01-23  Tom Tromey  <tom@tromey.com>
9263
9264         * ui-out.h (class ui_out_emit_type): Update comment.
9265
9266 2019-01-23  Tom Tromey  <tom@tromey.com>
9267
9268         * infrun.c (fetch_inferior_event): Update comment.
9269
9270 2019-01-23  Tom Tromey  <tom@tromey.com>
9271             Pedro Alves  <palves@redhat.com>
9272
9273         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9274         parameter.
9275         (fetch_inferior_event): Use SCOPE_EXIT.
9276
9277
9278 2019-01-23  Tom Tromey  <tom@tromey.com>
9279             Pedro Alves  <palves@redhat.com>
9280
9281         * infrun.c (disable_thread_events): Delete.
9282         (stop_all_threads): Use SCOPE_EXIT.
9283
9284 2019-01-23  Tom Tromey  <tom@tromey.com>
9285             Pedro Alves  <palves@redhat.com>
9286
9287         * symfile.c: Include forward-scope-exit.h.
9288         (clear_symtab_users_cleanup): Replace forward declaration with
9289         a FORWARD_SCOPE_EXIT.
9290         (syms_from_objfile_1): Use the forward_scope_exit and
9291         gdb::optional instead of cleanup_function.
9292         (reread_symbols): Use the forward_scope_exit instead of
9293         cleanup_function.
9294         (clear_symtab_users_cleanup): Remove function.
9295
9296 2019-01-23  Tom Tromey  <tom@tromey.com>
9297             Pedro Alves  <palves@redhat.com>
9298
9299         * linux-nat.c: Include scope-exit.h.
9300         (cleanup_target_stop): Remove.
9301         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9302         SCOPE_EXIT.
9303
9304 2019-01-23  Tom Tromey  <tom@tromey.com>
9305             Pedro Alves  <palves@redhat.com>
9306
9307         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9308         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9309
9310 2019-01-23  Tom Tromey  <tom@tromey.com>
9311             Andrew Burgess  <andrew.burgess@embecosm.com>
9312             Pedro Alves  <palves@redhat.com>
9313
9314         * infrun.c (fetch_inferior_event): Use scope_exit.
9315         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9316         * top.c (execute_command): Use scope_exit.
9317         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9318         * utils.c (do_bpstat_clear_actions_cleanup)
9319         (make_bpstat_clear_actions_cleanup): Remove.
9320
9321 2019-01-23  Tom Tromey  <tom@tromey.com>
9322             Pedro Alves  <palves@redhat.com>
9323
9324         * infrun.c: Include "common/scope-exit.h"
9325         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9326         (wait_for_inferior): Use SCOPE_EXIT.
9327         (fetch_inferior_event): Use scope_exit.
9328
9329 2019-01-23  Tom Tromey  <tom@tromey.com>
9330             Pedro Alves  <palves@redhat.com>
9331
9332         * breakpoint.c (create_breakpoint): Remove cleanup.
9333
9334 2019-01-23  Tom Tromey  <tom@tromey.com>
9335             Andrew Burgess  <andrew.burgess@embecosm.com>
9336             Pedro Alves  <palves@redhat.com>
9337
9338 2019-01-23  Pedro Alves  <palves@redhat.com>
9339
9340         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9341
9342 2019-01-23  Pedro Alves  <palves@redhat.com>
9343             Andrew Burgess  <andrew.burgess@embecosm.com>
9344
9345         * gdbthread.h: Include "common/forward-scope-exit.h".
9346         (scoped_finish_thread_state): Redefine custom class in terms of
9347         forward_scope_exit.
9348
9349 2019-01-23  Pedro Alves  <palves@redhat.com>
9350             Andrew Burgess  <andrew.burgess@embecosm.com>
9351
9352         * common/forward-scope-exit.h: New file.
9353
9354 2019-01-23  Pedro Alves  <palves@redhat.com>
9355             Andrew Burgess  <andrew.burgess@embecosm.com>
9356             Tom Tromey  <tom@tromey.com>
9357
9358         * common/scope-exit.h: New file.
9359
9360 2019-01-23  Pedro Alves  <palves@redhat.com>
9361
9362         * common/preprocessor.h (ESC): Rename to ...
9363         (ESC_PARENS): ... this.
9364         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9365         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9366
9367 2019-01-23  Tom Tromey  <tom@tromey.com>
9368
9369         * language.h (class scoped_switch_to_sym_language_if_auto):
9370         Initialize m_lang in both cases.
9371
9372 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9373
9374         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9375         with XCNEW.
9376
9377 2019-01-22  Tom Tromey  <tom@tromey.com>
9378
9379         * corelow.c: Do not include sys/file.h.
9380
9381 2019-01-22  Tom Tromey  <tom@tromey.com>
9382
9383         * tui/tui-wingeneral.h: Include gdb_curses.h.
9384
9385 2019-01-22  Tom Tromey  <tom@tromey.com>
9386
9387         * source-cache.h (class source_cache) <get_source_lines,
9388         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9389
9390 2019-01-22  Tom Tromey  <tom@tromey.com>
9391
9392         * remote-fileio.h (struct remote_target): Declare.
9393
9394 2019-01-22  Tom Tromey  <tom@tromey.com>
9395
9396         * python/py-arch.c: Do not include py-ref.h.
9397         * python/py-bpevent.c: Do not include py-ref.h.
9398         * python/py-cmd.c: Do not include py-ref.h.
9399         * python/py-continueevent.c: Do not include py-ref.h.
9400         * python/py-event.h: Do not include py-ref.h.
9401         * python/py-evtregistry.c: Do not include py-ref.h.
9402         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9403         * python/py-frame.c: Do not include py-ref.h.
9404         * python/py-framefilter.c: Do not include py-ref.h.
9405         * python/py-function.c: Do not include py-ref.h.
9406         * python/py-infevents.c: Do not include py-ref.h.
9407         * python/py-linetable.c: Do not include py-ref.h.
9408         * python/py-objfile.c: Do not include py-ref.h.
9409         * python/py-param.c: Do not include py-ref.h.
9410         * python/py-prettyprint.c: Do not include py-ref.h.
9411         * python/py-progspace.c: Do not include py-ref.h.
9412         * python/py-symbol.c: Do not include py-ref.h.
9413         * python/py-symtab.c: Do not include py-ref.h.
9414         * python/py-type.c: Do not include py-ref.h.
9415         * python/py-unwind.c: Do not include py-ref.h.
9416         * python/py-utils.c: Do not include py-ref.h.
9417         * python/py-value.c: Do not include py-ref.h.
9418         * python/py-varobj.c: Do not include py-ref.h.
9419         * python/py-xmethods.c: Do not include py-ref.h.
9420         * python/python.c: Do not include py-ref.h.
9421         * varobj.c: Do not include py-ref.h.
9422
9423 2019-01-22  Tom Tromey  <tom@tromey.com>
9424
9425         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9426         keyword for bcache.
9427
9428 2019-01-22  Tom Tromey  <tom@tromey.com>
9429
9430         * compile/compile-cplus-types.c: Remove a comment by #include.
9431
9432 2019-01-22  Tom Tromey  <tom@tromey.com>
9433
9434         * compile/gcc-c-plugin.h: Include compile-internal.h.
9435
9436 2019-01-22  Tom Tromey  <tom@tromey.com>
9437
9438         * stabsread.c (EXTERN): Do not define.
9439         (symnum, next_symbol_text_func, processing_gcc_compilation)
9440         (within_function, global_sym_chain, global_stabs)
9441         (previous_stab_code, this_object_header_files)
9442         (n_this_object_header_files)
9443         (n_allocated_this_object_header_files): Define.
9444         * stabsread.h (EXTERN): Never define.  Use "extern".
9445
9446 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9447
9448         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9449         history_value.
9450
9451 2019-01-21  Tom Tromey  <tom@tromey.com>
9452
9453         * ui-out.c: Fix includes.
9454         * tui/tui-source.c: Fix includes.
9455         * target.c: Fix includes.
9456         * remote.c: Fix includes.
9457         * regcache.c: Fix includes.
9458         * python/py-block.c: Fix includes.
9459         * printcmd.c: Fix includes.
9460         * or1k-tdep.c: Fix includes.
9461         * mi/mi-main.c: Fix includes.
9462         * m32r-tdep.c: Fix includes.
9463         * csky-tdep.c: Fix includes.
9464         * compile/compile-cplus-types.c: Fix includes.
9465         * cli/cli-interp.c: Fix includes.
9466
9467 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9468
9469         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9470         for padding.
9471
9472 2019-01-16  Tom Tromey  <tom@tromey.com>
9473
9474         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9475         earlier.
9476         (struct objfile) <msymbols_range>: Move from top level.
9477         <msymbols>: New method.
9478         (class objfile_msymbols): Remove.
9479         * symtab.c (default_collect_symbol_completion_matches_break_on):
9480         Update.
9481         * symmisc.c (dump_msymbols): Update.
9482         * stabsread.c (scan_file_globals): Update.
9483         * objc-lang.c (info_selectors_command, info_classes_command)
9484         (find_methods): Update.
9485         * minsyms.c (find_solib_trampoline_target): Update.
9486         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9487         * coffread.c (coff_symfile_read): Update.
9488         * ada-lang.c (ada_lookup_simple_minsym)
9489         (ada_collect_symbol_completion_matches): Update.
9490
9491 2019-01-16  Tom Tromey  <tom@tromey.com>
9492
9493         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9494         type.  Remove no-argument constructor.
9495         <iterator::operator++>: Simplify.
9496         <begin>: Update.
9497         <end>: Use minimal_symbol_count.
9498
9499 2019-01-16  Tom Tromey  <tom@tromey.com>
9500
9501         * objfiles.h (struct objfile) <psymtabs>: New method.
9502         (class objfile_psymtabs): Remove.
9503         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9504         typedef.
9505         <range>: New method.
9506         (require_partial_symbols): Change return type.
9507         * psymtab.c (require_partial_symbols)
9508         (psym_expand_symtabs_matching): Update.
9509         * mdebugread.c (parse_partial_symbols): Update.
9510         * dbxread.c (dbx_end_psymtab): Update.
9511
9512 2019-01-15  Tom Tromey  <tom@tromey.com>
9513
9514         * symtab.c (lookup_objfile_from_block)
9515         (lookup_symbol_in_objfile_symtabs)
9516         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9517         (find_line_symtab, info_sources_command)
9518         (default_collect_symbol_completion_matches_break_on)
9519         (make_source_files_completion_list): Update.
9520         * symmisc.c (print_objfile_statistics, dump_objfile)
9521         (maintenance_print_symbols, maintenance_info_symtabs)
9522         (maintenance_check_symtabs, maintenance_info_line_tables):
9523         Update.
9524         * source.c (select_source_symtab)
9525         (forget_cached_source_info_for_objfile): Update.
9526         * objfiles.h (class objfile_compunits): Remove.
9527         (struct objfile) <compunits_range>: New typedef.
9528         (compunits): New method.
9529         * objfiles.c (objfile_relocate1): Update.
9530         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9531         * maint.c (count_symtabs_and_blocks): Update.
9532         * linespec.c (iterate_over_all_matching_symtabs): Update.
9533         * cp-support.c (add_symbol_overload_list_qualified): Update.
9534         * coffread.c (coff_symtab_read): Update.
9535         * ada-lang.c (add_nonlocal_symbols)
9536         (ada_collect_symbol_completion_matches)
9537         (ada_add_global_exceptions): Update.
9538
9539 2019-01-15  Tom Tromey  <tom@tromey.com>
9540
9541         * progspace.h (program_space) <objfiles_safe_range>: New
9542         typedef.
9543         <objfiles_safe>: New method.
9544         * objfiles.h (class all_objfiles_safe): Remove.
9545         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9546         * jit.c (jit_inferior_exit_hook): Update.
9547
9548 2019-01-17  Tom Tromey  <tom@tromey.com>
9549
9550         * progspace.h (program_space) <objfiles_range>: New typedef.
9551         <objfiles>: New method.
9552         <objfiles_head>: Rename from objfiles.
9553         (object_files): Update.
9554         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9555         * guile/scm-pretty-print.c
9556         (ppscm_find_pretty_printer_from_objfiles): Update.
9557         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9558         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9559         Update.
9560         * python/py-progspace.c (pspy_get_objfiles): Update.
9561         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9562         Update.
9563         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9564         (objfpy_lookup_objfile_by_build_id): Update.
9565         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9566         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9567         Update.
9568         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9569         (expand_symtab_containing_pc, lookup_objfile_from_block)
9570         (lookup_static_symbol, basic_lookup_transparent_type)
9571         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9572         (find_line_symtab, info_sources_command)
9573         (default_collect_symbol_completion_matches_break_on)
9574         (make_source_files_completion_list, find_main_name): Update.
9575         * symmisc.c (print_symbol_bcache_statistics)
9576         (print_objfile_statistics, maintenance_print_symbols)
9577         (maintenance_print_msymbols, maintenance_print_objfiles)
9578         (maintenance_info_symtabs, maintenance_check_symtabs)
9579         (maintenance_expand_symtabs, maintenance_info_line_tables):
9580         Update.
9581         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9582         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9583         (map_overlay_command, unmap_overlay_command)
9584         (simple_overlay_update, expand_symtabs_matching)
9585         (map_symbol_filenames): Update.
9586         * symfile-debug.c (set_debug_symfile): Update.
9587         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9588         Update.
9589         * source.c (select_source_symtab, forget_cached_source_info):
9590         Update.
9591         * solib.c (solib_read_symbols): Update.
9592         * solib-spu.c (append_ocl_sos): Update.
9593         * psymtab.c (maintenance_print_psymbols)
9594         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9595         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9596         * printcmd.c (info_symbol_command): Update.
9597         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9598         Update.
9599         * objfiles.h (class all_objfiles): Remove.
9600         * objfiles.c (have_partial_symbols, have_full_symbols)
9601         (have_minimal_symbols, qsort_cmp, update_section_map)
9602         (shared_objfile_contains_address_p)
9603         (default_iterate_over_objfiles_in_search_order): Update.
9604         * objc-lang.c (info_selectors_command, info_classes_command)
9605         (find_methods): Update.
9606         * minsyms.c (find_solib_trampoline_target): Update.
9607         * maint.c (maintenance_info_sections)
9608         (maintenance_translate_address, count_symtabs_and_blocks):
9609         Update.
9610         * main.c (captured_main_1): Update.
9611         * linux-thread-db.c (try_thread_db_load_from_pdir)
9612         (has_libpthread): Update.
9613         * linespec.c (iterate_over_all_matching_symtabs)
9614         (search_minsyms_for_name): Update.
9615         * jit.c (jit_find_objf_with_entry_addr): Update.
9616         * hppa-tdep.c (find_unwind_entry)
9617         (hppa_lookup_stub_minimal_symbol): Update.
9618         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9619         Update.
9620         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9621         (elf_gnu_ifunc_resolve_by_got): Update.
9622         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9623         * dwarf-index-write.c (save_gdb_index_command): Update.
9624         * cp-support.c (add_symbol_overload_list_qualified): Update.
9625         * breakpoint.c (create_overlay_event_breakpoint)
9626         (create_longjmp_master_breakpoint)
9627         (create_std_terminate_master_breakpoint)
9628         (create_exception_master_breakpoint): Update.
9629         * blockframe.c (find_pc_partial_function): Update.
9630         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9631         (ada_collect_symbol_completion_matches)
9632         (ada_add_global_exceptions): Update.
9633
9634 2019-01-17  Tom Tromey  <tom@tromey.com>
9635
9636         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9637         declare VEC.
9638         (solib_target_parse_libraries): Change return type.
9639         (library_list_start_segment, library_list_start_section)
9640         (library_list_end_library, library_list_start_library); Update.
9641         (solib_target_free_library_list): Remove.
9642         (solib_target_parse_libraries): Remove cleanup.  Change return
9643         type.
9644         (solib_target_current_sos): Update.
9645
9646 2019-01-17  Tom Tromey  <tromey@bapiya>
9647
9648         * valprint.c: Replace "the the" with "the".
9649         * symtab.c: Replace "the the" with "the".
9650         * solib.c: Replace "the the" with "the".
9651         * solib-dsbt.c: Replace "the the" with "the".
9652         * linespec.c: Replace "the the" with "the".
9653         * dwarf2loc.h: Replace "the the" with "the".
9654         * amd64-windows-tdep.c: Replace "the the" with "the".
9655         * aarch64-tdep.c: Replace "the the" with "the".
9656
9657 2019-01-16  Keith Seitz  <keiths@redhat.com>
9658
9659         PR gdb/23773
9660         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9661         <builder>: Rename to ..
9662         <m_builder>: ... this and make private.
9663         (dwarf2_cu::get_builder): New method.  Change all users of
9664         `builder' to use this method.
9665         (dwarf2_start_symtab): Move to ...
9666         (dwarf2_cu::start_symtab): ... here.  Update all callers
9667         (setup_type_unit_groups): Move to ...
9668         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9669         callers.
9670         (dwarf2_cu::reset_builder): New method.
9671         (process_full_compunit, process_full_type_unit): Use
9672         dwarf2_cu::reset_builder.
9673         (follow_die_offset): Record the ancestor CU if it is different
9674         from the followed DIE's CU.
9675         (follow_die_sig_1): Likewise.
9676
9677 2019-01-15  Tom Tromey  <tom@tromey.com>
9678
9679         * remote.c (class remote_state) <buf>: Now a char_vector.
9680         <buf_size>: Remove.
9681         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9682         parameter.
9683         (remote_target::getpkt_or_notif_sane_1)
9684         (remote_target::getpkt_sane)
9685         (remote_target::getpkt_or_notif_sane): Likewise.
9686         (class remote_target) <putpkt>: New overload.
9687         (remote_target::read_frame): Change type of "buf_p".  Remove
9688         sizeof_p parameter.
9689         (packet_ok): New overload.
9690         (packet_check_result): New overload.
9691         Update all uses.
9692
9693 2019-01-14  Tom Tromey  <tom@tromey.com>
9694
9695         * remote-notif.c (handle_notification, remote_notif_ack)
9696         (remote_notif_parse): Make "buf" const.
9697         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9698         const.
9699         (remote_notif_parse, remote_notif_ack, handle_notification):
9700         Likewise.
9701         * remote.c (remote_notif_stop_parse): Make "buf" const.
9702         (remote_target::remote_parse_stop_reply): Make "buf" const.
9703         (remote_notif_stop_ack): Make "buf" const.
9704
9705 2019-01-14  Tom Tromey  <tom@tromey.com>
9706
9707         * remote.c (remote_console_output): Make parameter const.
9708
9709 2019-01-14  Tom Tromey  <tom@tromey.com>
9710
9711         * target-debug.h (target_debug_print_signals): Constify.
9712         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9713         * procfs.c (procfs_target::pass_signals): Update.
9714         * linux-nat.c (linux_nat_target::pass_signals): Update.
9715         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9716         * target-delegates.c: Rebuild.
9717         * remote.c (remote_target::program_signals): Update.
9718         (remote_target::pass_signals): Update.
9719         * target.c (target_pass_signals): Constify argument.
9720         (target_program_signals): Likewise.
9721         * target.h (struct target_ops) <pass_signals, program_signals>:
9722         Constify argument.
9723         (target_pass_signals, target_program_signals): Constify argument.
9724
9725 2019-01-14  Tom Tromey  <tom@tromey.com>
9726
9727         PR tui/28819:
9728         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9729
9730 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9731
9732         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9733         field.
9734         * rs6000-tdep.c: Include reggroups.h.
9735         (IS_V_ALIAS_PSEUDOREG): Define.
9736         (rs6000_register_name): Return names for the "vX" aliases.
9737         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9738         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9739         aliases.  Call default_register_reggroup_p for all other
9740         pseudo-registers.
9741         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9742         New functions.
9743         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9744         Handle "vX" aliases.
9745         (v_alias_pseudo_register_collect): New function.
9746         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9747         (rs6000_gdbarch_init): Initialize "vX" aliases as
9748         pseudo-registers.  Restore registration of
9749         rs6000_pseudo_register_reggroup_p with
9750         set_tdesc_pseudo_register_reggroup_p.
9751
9752 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9753
9754         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9755         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9756         set_gdbarch_num_pseudo_regs.
9757
9758 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9759
9760         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9761         Remove arg prefixname, add do_set and do_show.
9762         Add member functions set_list and show_list.
9763         * cli/cli-style.c (class cli_style_option): Update accordingly.
9764         (style_set_list): Move to file scope.
9765         (style_show_list): Likewise.
9766         (set_style): Call help_list.
9767         (show_style): Call cmd_show_list.
9768         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9769         Update to use the new macro.
9770
9771 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9772
9773         * ada-lang.c (_initialize_ada_language): Expand the help text
9774         for the "catch exception" command.
9775
9776 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9777
9778         * symtab.c (matching_obj_sections): Initialize obj,
9779         declare it closer to its usage.
9780
9781 2019-01-10  Tom Tromey  <tom@tromey.com>
9782
9783         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9784         (basic_inf_threads_range): Remove.
9785         (inf_threads_range, inf_non_exited_threads_range)
9786         (safe_inf_threads_range): Use next_adapter.
9787
9788 2019-01-10  Keith Seitz  <keiths@redhat.com>
9789
9790         PR gdb/23712
9791         PR symtab/23010
9792         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9793         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9794
9795 2019-01-10  Keith Seitz  <keiths@redhat.com>
9796
9797         PR gdb/23712
9798         PR symtab/23010
9799         * dictionary.c (pending_to_vector): Remove.
9800         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9801         Remove _1 suffix, replacing functions of the same name.  Update
9802         all callers.
9803         (dict_create_hashed, dict_create_hashed_expandable)
9804         (dict_create_linear, dict_create_linear_expandable, dict_free)
9805         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9806         Make functions static.
9807
9808 2019-01-10  Keith Seitz  <keiths@redhat.com>
9809
9810         PR gdb/23712
9811         PR symtab/23010
9812         * dictionary.h (struct dictionary): Replace declaration with
9813         multidictionary.
9814         (dict_create_hashed, dict_create_hashed_expandable)
9815         (dict_create_linear, dict_create_linear_expandable)
9816         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9817         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9818         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9819         taking multidictionary argument.
9820         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9821         * block.h (struct block) <dict>: Change to multidictionary
9822         and rename `multidict'.
9823         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9824         symmisc.c: Update all dictionary references to multidictionary.
9825
9826 2019-01-10  Keith Seitz  <keiths@redhat.com>
9827
9828         PR gdb/23712
9829         PR symtab/23010
9830         * dictionary.c: Include unordered_map.
9831         (pending_to_vector): New function.
9832         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9833         Rewrite the non-"_1" functions to take vector instead
9834         of linked list.
9835         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9836         "new" _1 versions of the same name.
9837         (multidictionary): Define.
9838         (std::hash<enum language): New definition.
9839         (collate_pending_symbols_by_language, mdict_create_hashed)
9840         (mdict_create_hashed_expandable, mdict_create_linear)
9841         (mdict_create_linear_expandable, mdict_free)
9842         (find_language_dictionary, create_new_language_dictionary)
9843         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9844         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9845         (mdict_size, mdict_empty): New functions.
9846         * dictionary.h (mdict_iterator): Define.
9847
9848 2019-01-10  Pedro Alves  <palves@redhat.com>
9849
9850         * breakpoint.c (read_uploaded_action)
9851         (create_tracepoint_from_upload): Adjust to use
9852         gdb::unique_xmalloc_ptr.
9853         * ctf.c (ctf_write_uploaded_tp):
9854         (SET_ARRAY_FIELD): Use emplace_back.
9855         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9856         * tracefile-tfile.c (tfile_write_uploaded_tp):
9857         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9858         gdb::unique_xmalloc_ptr.
9859         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9860         at_string, cond_string, cmd_strings>: Replace char pointers
9861         with gdb::unique_xmalloc_ptr.
9862
9863 2019-01-10  Pedro Alves  <palves@redhat.com>
9864
9865         * solib-target.c (library_list_start_library): Don't xstrdup name.
9866
9867 2019-01-10  Pedro Alves  <palves@redhat.com>
9868
9869         * mdebugread.c (parse_partial_symbols): Use
9870         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9871
9872 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9873
9874         * linux-fork.c (scoped_switch_fork_info)
9875         <~scoped_switch_fork_info>: Fix incorrect variable name.
9876
9877 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9878
9879         * linux-fork.c (scoped_switch_fork_info)
9880         <scoped_switch_fork_info>: Make explicit.
9881         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9882
9883 2019-01-10  Tom Tromey  <tom@tromey.com>
9884
9885         * objfiles.h (objfile::reset_psymtabs): Update.
9886         * objfiles.c (objfile::objfile): Update.
9887         * psymtab.h (psymtab_storage::obstack): Update.
9888         (psymtab_storage::m_obstack): Use gdb::optional.
9889         (class psymtab_storage): Update comment.  Remove objfile
9890         parameter.
9891         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9892
9893 2019-01-10  Tom Tromey  <tom@tromey.com>
9894
9895         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9896         <free_psymtabs>: Now private.
9897         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9898         (allocate_psymtab): Use new method.
9899
9900 2019-01-10  Tom Tromey  <tom@tromey.com>
9901
9902         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9903         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9904         * mdebugread.c (parse_partial_symbols): Use
9905         allocate_dependencies.
9906         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9907         allocate_dependencies.
9908         (process_psymtab_comp_unit_reader)
9909         (build_type_psymtab_dependencies): Likewise.
9910         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9911
9912 2019-01-10  Tom Tromey  <tom@tromey.com>
9913
9914         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9915         PSYMBOL_SET_LANGUAGE.
9916         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9917
9918 2019-01-10  Tom Tromey  <tom@tromey.com>
9919
9920         * psymtab.h (psymtab_storage::obstack): New method.
9921         <m_obstack>: Rename from obstack; now private.
9922         * psymtab.c (psymtab_storage): Update.
9923         * dwarf2read.c (create_addrmap_from_index)
9924         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9925         Update.
9926
9927 2019-01-10  Tom Tromey  <tom@tromey.com>
9928
9929         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9930         * objfiles.h (objfile::reset_psymtabs): New method.
9931
9932 2019-01-10  Tom Tromey  <tom@tromey.com>
9933
9934         * symmisc.c (print_symbol_bcache_statistics): Update.
9935         (print_objfile_statistics): Update.
9936         * symfile.c (reread_symbols): Update.
9937         * psymtab.h (class psymtab_storage): New.
9938         * psymtab.c (psymtab_storage): New constructor.
9939         (~psymtab_storage): New destructor.
9940         (require_partial_symbols): Update.
9941         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9942         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9943         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9944         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9945         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9946         (start_psymtab_common, end_psymtab_common)
9947         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9948         (allocate_psymtab): Update.
9949         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9950         Update.
9951         (dump_psymtab_addrmap, maintenance_print_psymbols)
9952         (maintenance_check_psymtabs): Update.
9953         (class objfile_psymtabs): Move to objfiles.h.
9954         * psympriv.h (discard_psymtab): Now inline.
9955         (psymtab_discarder::psymtab_discarder): Update.
9956         (psymtab_discarder::~psymtab_discarder): Update.
9957         (ALL_OBJFILE_PSYMTABS): Rewrite.
9958         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9959         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9960         Remove fields.
9961         <partial_symtabs>: New field.
9962         (class objfile_psymtabs): Move from psymtab.h.  Update.
9963         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9964         psymbol_cache.
9965         (objfile::~objfile): Don't destroy psymbol_cache.
9966         * mdebugread.c (parse_partial_symbols): Update.
9967         * dwarf2read.c (create_addrmap_from_index)
9968         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9969         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9970         (add_partial_subprogram, dwarf2_ranges_read): Update.
9971         * dwarf-index-write.c (write_address_map)
9972         (write_one_signatured_type, recursively_write_psymbols)
9973         (class debug_names, class debug_names, write_psymtabs_to_index):
9974         Update.
9975
9976 2019-01-10  Tom Tromey  <tom@tromey.com>
9977
9978         * symtab.h (SYMBOL_SET_NAMES): Update.
9979         (symbol_set_names): Update.
9980         (MSYMBOL_SET_NAMES): Update.
9981         * symtab.c (symbol_set_names): Change argument to be an
9982         objfile_per_bfd_storage.
9983         * psymtab.c (add_psymbol_to_bcache): Update.
9984         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9985
9986 2019-01-10  Tom Tromey  <tom@tromey.com>
9987
9988         * symtab.c (create_demangled_names_hash): Change argument to be an
9989         objfile_per_bfd_storage.
9990         (symbol_set_names): Update.
9991
9992 2019-01-10  Tom Tromey  <tom@tromey.com>
9993
9994         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9995         init_psymbol_list.
9996         * psymtab.c (init_psymbol_list): Do nothing if already called.
9997         * psympriv.h (init_psymbol_list): Add comment.
9998         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9999         init_psymbol_list.
10000         * dbxread.c (dbx_symfile_read): Unconditionally call
10001         init_psymbol_list.
10002
10003 2019-01-10  Tom Tromey  <tom@tromey.com>
10004
10005         * xcoffread.c (scan_xcoff_symtab): Update.
10006         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10007         "where".
10008         * mdebugread.c (parse_partial_symbols)
10009         (handle_psymbol_enumerators): Update.
10010         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10011         * dbxread.c (read_dbx_symtab): Update.
10012         * psympriv.h (psymbol_placement): New enum.
10013         (add_psymbol_to_list): Update.
10014
10015 2019-01-10  Tom Tromey  <tom@tromey.com>
10016
10017         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10018         static_psymbols parameters.
10019         (scan_xcoff_symtab): Update.
10020         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10021         static_psymbols parameters.
10022         * psympriv.h (start_psymtab_common): Update.
10023         * mdebugread.c (parse_partial_symbols): Update.
10024         * dwarf2read.c (create_partial_symtab): Update.
10025         * dbxread.c (read_dbx_symtab): Update.
10026         (start_psymtab): Remove global_psymbols and static_psymbols
10027         parameters.
10028
10029 2019-01-10  Tom Tromey  <tom@tromey.com>
10030
10031         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10032         * psymtab.c (allocate_psymtab): Add comment.
10033         * psympriv.h (allocate_psymtab): Add comment.
10034         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10035         initializations.
10036         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10037
10038 2019-01-10  Tom Tromey  <tom@tromey.com>
10039
10040         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10041         Don't declare.
10042         * mipsread.c: Include mdebugread.h.
10043         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10044         Declare.
10045         * elfread.c: Include mdebugread.h.
10046
10047 2019-01-09  Tom Tromey  <tom@tromey.com>
10048
10049         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10050         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10051         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10052         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10053         (psym_lookup_symbol, psym_find_last_source_symtab)
10054         (psym_forget_cached_source_info, psym_print_stats)
10055         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10056         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10057         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10058         (psym_find_compunit_symtab_by_address)
10059         (maintenance_print_psymbols, maintenance_info_psymtabs)
10060         (maintenance_check_psymtabs): Use ranged for.
10061         * psymtab.h (class objfile_psymtabs): New.
10062         (require_partial_symbols): Return objfile_psymtabs.
10063         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10064
10065 2019-01-09  Tom Tromey  <tom@tromey.com>
10066
10067         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10068         (find_pc_mapped_section, list_overlays_command)
10069         (map_overlay_command, unmap_overlay_command)
10070         (simple_overlay_update): Use all_objfiles.
10071         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10072         * printcmd.c (info_symbol_command): Use all_objfiles.
10073         * objfiles.h (ALL_OBJSECTIONS): Remove.
10074         * maint.c (maintenance_translate_address): Use all_objfiles.
10075         * gcore.c (gcore_create_callback): Use all_objfiles.
10076         (objfile_find_memory_regions): Likewise.
10077
10078 2019-01-09  Tom Tromey  <tom@tromey.com>
10079
10080         * symtab.c (find_line_symtab, info_sources_command)
10081         (make_source_files_completion_list): Use objfile_compunits.
10082         * source.c (select_source_symtab): Use objfile_compunits.
10083         * objfiles.h (struct objfile): Update comment.
10084         (ALL_OBJFILES): Remove.
10085         (ALL_FILETABS): Remove.
10086         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10087         objfile_compunits.
10088
10089 2019-01-09  Tom Tromey  <tom@tromey.com>
10090
10091         * symmisc.c (print_objfile_statistics, dump_objfile)
10092         (maintenance_print_symbols): Use compunit_filetabs.
10093         * source.c (forget_cached_source_info_for_objfile): Use
10094         compunit_filetabs.
10095         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10096         (ALL_FILETABS): Use compunit_filetabs.
10097         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10098         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10099
10100 2019-01-09  Tom Tromey  <tom@tromey.com>
10101
10102         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10103         (compunit_filetabs): New.
10104         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10105         compunit_filetabs.
10106         (info_sources_command, make_source_files_completion_list): Remove
10107         declaration.
10108         * symmisc.c (print_objfile_statistics, dump_objfile)
10109         (maintenance_print_symbols): Remove declaration.
10110         (maintenance_info_symtabs): Use compunit_filetabs.
10111         (maintenance_info_line_tables): Likewise.
10112         * source.c (select_source_symtab): Change local variable name.
10113         (forget_cached_source_info_for_objfile): Remove declaration.
10114         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10115         * objfiles.c (objfile_relocate1): Remove declaration.
10116         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10117         declaration.
10118         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10119         * coffread.c (coff_symtab_read): Remove declaration.
10120         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10121         compunit_filetabs.
10122
10123 2019-01-09  Tom Tromey  <tom@tromey.com>
10124
10125         * symtab.c (lookup_objfile_from_block)
10126         (find_pc_sect_compunit_symtab, search_symbols)
10127         (default_collect_symbol_completion_matches_break_on): Use
10128         objfile_compunits.
10129         * objfiles.h (ALL_COMPUNITS): Remove.
10130         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10131         * cp-support.c (add_symbol_overload_list_qualified): Use
10132         objfile_compunits.
10133         * ada-lang.c (ada_collect_symbol_completion_matches)
10134         (ada_add_global_exceptions): Use objfile_compunits.
10135
10136 2019-01-09  Tom Tromey  <tom@tromey.com>
10137
10138         * source.c (select_source_symtab)
10139         (forget_cached_source_info_for_objfile): Remove declaration.
10140         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10141         declaration.
10142         * maint.c (count_symtabs_and_blocks): Remove declaration.
10143         * cp-support.c (add_symbol_overload_list_qualified): Remove
10144         declaration.
10145         * coffread.c (coff_symtab_read): Remove declaration.
10146         * symtab.c (lookup_symbol_in_objfile_symtabs)
10147         (basic_lookup_transparent_type_1): Use objfile_compunits.
10148         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10149         (info_sources_command, search_symbols)
10150         (default_collect_symbol_completion_matches_break_on)
10151         (make_source_files_completion_list): Remove declaration.
10152         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10153         (ada_collect_symbol_completion_matches)
10154         (ada_add_global_exceptions): Remove declaration.
10155         * linespec.c (iterate_over_all_matching_symtabs): Use
10156         objfile_compunits.
10157         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10158         (class objfile_compunits): New.
10159         (ALL_COMPUNITS): Use objfile_compunits.
10160         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10161         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10162         objfile_compunits.
10163         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10164
10165 2019-01-09  Tom Tromey  <tom@tromey.com>
10166
10167         * symtab.c (search_symbols)
10168         (default_collect_symbol_completion_matches_break_on): Use
10169         objfile_msymbols.
10170         * ada-lang.c (ada_lookup_simple_minsym)
10171         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10172         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10173         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10174         objfile_msymbols.
10175         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10176         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10177         * objc-lang.c (find_methods): Use objfile_msymbols.
10178         (info_selectors_command, info_classes_command): Likewise.
10179         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10180         * objfiles.h (class objfile_msymbols): New.
10181         (ALL_OBJFILE_MSYMBOLS): Remove.
10182         (ALL_MSYMBOLS): Remove.
10183
10184 2019-01-09  Tom Tromey  <tom@tromey.com>
10185
10186         * common/next-iterator.h (next_adapter): Add Iterator template
10187         parameter.
10188         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10189         (class all_objfiles_safe): New.
10190         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10191         * objfiles.c (put_objfile_before): Update comment.
10192         (add_separate_debug_objfile): Likewise.
10193         (free_all_objfiles): Use all_objfiles_safe.
10194         (objfile_purge_solibs): Likewise.
10195
10196 2019-01-09  Tom Tromey  <tom@tromey.com>
10197
10198         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10199         (expand_symtab_containing_pc, lookup_static_symbol)
10200         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10201         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10202         all_objfiles.
10203         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10204         * breakpoint.c (create_overlay_event_breakpoint)
10205         (create_longjmp_master_breakpoint)
10206         (create_std_terminate_master_breakpoint)
10207         (create_exception_master_breakpoint): Use all_objfiles.
10208         * linux-thread-db.c (try_thread_db_load_from_pdir)
10209         (has_libpthread): Use all_objfiles.
10210         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10211         * linespec.c (iterate_over_all_matching_symtabs)
10212         (search_minsyms_for_name): Use all_objfiles.
10213         * maint.c (maintenance_info_sections): Use all_objfiles.
10214         * main.c (captured_main_1): Use all_objfiles.
10215         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10216         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10217         * guile/scm-pretty-print.c
10218         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10219         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10220         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10221         (maintenance_print_msymbols): Use all_objfiles.
10222         * source.c (select_source_symtab): Use all_objfiles.
10223         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10224         * symfile.c (remove_symbol_file_command)
10225         (expand_symtabs_matching, map_symbol_filenames): Use
10226         all_objfiles.
10227         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10228         all_objfiles.
10229         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10230         * objc-lang.c (find_methods): Use all_objfiles.
10231         * objfiles.c (have_partial_symbols, have_full_symbols)
10232         (have_minimal_symbols, qsort_cmp)
10233         (default_iterate_over_objfiles_in_search_order): Use
10234         all_objfiles.
10235         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10236         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10237         (maintenance_check_psymtabs): Use all_objfiles.
10238         (ALL_PSYMTABS): Remove.
10239         * compile/compile-object-run.c (do_module_cleanup): Use
10240         all_objfiles.
10241         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10242         * cp-support.c (add_symbol_overload_list_qualified): Use
10243         all_objfiles.
10244         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10245         Use all_objfiles.
10246         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10247         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10248         all_objfiles.
10249         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10250         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10251         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10252         Uses all_objfiles.
10253         * solib.c (solib_read_symbols): Use all_objfiles
10254
10255 2019-01-09  Tom Tromey  <tom@tromey.com>
10256
10257         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10258         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10259         all_objfiles.
10260         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10261         * symmisc.c (print_symbol_bcache_statistics)
10262         (print_objfile_statistics, maintenance_print_objfiles)
10263         (maintenance_info_symtabs, maintenance_check_symtabs)
10264         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10265         all_objfiles.
10266         * source.c (forget_cached_source_info): Use all_objfiles.
10267         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10268         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10269         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10270         * objfiles.c (update_section_map): Use all_objfiles.
10271         (shared_objfile_contains_address_p): Likewise.
10272         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10273         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10274
10275 2019-01-09  Tom Tromey  <tom@tromey.com>
10276
10277         * common/next-iterator.h: New file.
10278         * objfiles.h (class all_objfiles): New.
10279         (struct objfile_iterator): New.
10280
10281 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10282
10283         * NEWS: Move the description of the changed "frame", "select-frame",
10284          and "info frame" commands to the Changed commands section.
10285
10286 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10287
10288         * gdbtypes.c (check_stub_method_group): Remove handling of old
10289         mangling schemes.
10290         * linespec.c (find_methods): Likewise.
10291         * stabsread.c (read_member_functions): Likewise.
10292         * valops.c (search_struct_method): Likewise.
10293         (value_struct_elt_for_reference): Likewise.
10294         * NEWS: Mention this change.
10295
10296 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10297
10298         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10299         print_source_lines.
10300         * source.c (print_source_lines_base): Update line number check.
10301         (print_source_lines): New function.
10302         (source_lines_range::source_lines_range): New function.
10303         * source.h (class source_lines_range): New class.
10304         (print_source_lines): New declaration.
10305
10306 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10307
10308         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10309
10310 2019-01-08  Tom Tromey  <tom@tromey.com>
10311             Simon Marchi  <simon.marchi@ericsson.com>
10312
10313         PR gdb/24060
10314         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10315         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10316         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10317         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10318         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10319         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10320
10321 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10322
10323         * source.c (select_source_symtab): Move header comment to
10324         declaration in source.h.
10325         (forget_cached_source_info_for_objfile): Likewise.
10326         (forget_cached_source_info): Likewise.
10327         (identify_source_line): Likewise.
10328         * source.h (identify_source_line): Move declaration from symtab.h
10329         and add comment from source.c
10330         (print_source_lines): Likewise.
10331         (forget_cached_source_info_for_objfile): Likewise.
10332         (forget_cached_source_info): Likewise.
10333         (select_source_symtab): Likewise.
10334         (enum print_source_lines_flag): Move definition from symtab.h.
10335         * symtab.h (identify_source_line): Move declaration to source.h.
10336         (print_source_lines): Likewise.
10337         (forget_cached_source_info_for_objfile): Likewise.
10338         (forget_cached_source_info): Likewise.
10339         (select_source_symtab): Likewise.
10340         (enum print_source_lines_flag): Move definition to source.h.
10341         * tui/tui-hooks.c: Add 'source.h' include.
10342
10343 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10344
10345         * source.c (print_source_lines_base): Handle requests to print
10346         reverse line number sequences, and guard against empty lines
10347         string.
10348
10349 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10350
10351         * source.c (print_source_lines_base): Fix skip of '\r' if next
10352         character is '\n'.
10353
10354 2019-01-06  Tom Tromey  <tom@tromey.com>
10355
10356         * c-exp.y (struct c_parse_state) <macro_original_text,
10357         expansion_obstack>: New member.
10358         (macro_original_text, expansion_obstack): Remove globals.
10359         (scan_macro_expansion, scanning_macro_expansion)
10360         (finished_macro_expansion): Update.
10361         (scan_macro_cleanup): Remove.
10362         (yylex, c_parse): Update.
10363
10364 2019-01-06  Tom Tromey  <tom@tromey.com>
10365
10366         * c-exp.y (struct c_parse_state) <strings>: New member.
10367         (operator_stoken): Update.
10368
10369 2019-01-06  Tom Tromey  <tom@tromey.com>
10370
10371         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10372         (union type_stack_elt) <typelist_val>: Now a pointer to
10373         std::vector.
10374         (type_stack_cleanup): Don't declare.
10375         (push_typelist): Update.
10376         * parse.c (pop_typelist): Return a std::vector.
10377         (push_typelist): Take a std::vector.
10378         (follow_types): Update.  Do not free args.
10379         (type_stack_cleanup): Remove.
10380         * c-exp.y (struct c_parse_state): New.
10381         (cpstate): New global.
10382         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10383         (nonempty_typelist): Update.
10384         (func_mod): Create a new vector.
10385         (c_parse): Create a c_parse_state.
10386         (check_parameter_typelist): Do not delete params.
10387         (function_method): Update.  Do not delete type_list.
10388
10389 2019-01-06  Tom Tromey  <tom@tromey.com>
10390
10391         PR gdb/28155:
10392         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10393         check_typedef.
10394         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10395         (print_return_value): Likewise.
10396
10397 2019-01-05  Tom Tromey  <tom@tromey.com>
10398
10399         * contrib/cleanup_check.py: Remove.
10400         * contrib/gcc-with-excheck: Remove.
10401         * contrib/exsummary.py: Remove.
10402         * contrib/excheck.py: Remove.
10403
10404 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10405
10406         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10407         NULL. Initialize tpprev to NULL instead of assigning it
10408         to NULL on the next statement.
10409         * windows-nat.c (windows_delete_thread): Remove check for
10410         main_thread_id before printing thread exit notifications.
10411         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10412         Remove thread ID check against main_thread_id.
10413         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10414         windows_delete_thread.
10415         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10416
10417 2019-01-04  Tom Tromey  <tom@tromey.com>
10418
10419         * compile/compile.c (_initialize_compile): Use upper case for
10420         metasyntactic variables.
10421         * symmisc.c (_initialize_symmisc): Use upper case for
10422         metasyntactic variables.
10423         * psymtab.c (_initialize_psymtab): Use upper case for
10424         metasyntactic variables.
10425         * demangle.c (demangle_command): Use upper case for metasyntactic
10426         variables.
10427         (_initialize_demangler): Likewise.
10428         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10429         variables.
10430
10431 2019-01-03  Tom Tromey  <tom@tromey.com>
10432
10433         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10434
10435 2019-01-03  Tom Tromey  <tom@tromey.com>
10436
10437         * python/py-symtab.c (salpy_str): Update.
10438         (struct salpy_sal_object) <symtab>: Now a PyObject.
10439         (salpy_dealloc): Update.
10440         (del_objfile_sal): Use gdbpy_ref.
10441
10442 2019-01-03  Tom Tromey  <tom@tromey.com>
10443
10444         * python/py-type.c (convert_field): Use new_reference.  Return
10445         gdbpy_ref.
10446         (make_fielditem): Return gdbpy_ref.
10447         (typy_fields): Update.
10448         (typy_getitem): Update.
10449         (field_name): Return gdbpy_ref.  Use new_reference.
10450         (typy_iterator_iternext): Update.
10451
10452 2019-01-03  Tom Tromey  <tom@tromey.com>
10453
10454         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10455
10456 2019-01-03  Tom Tromey  <tom@tromey.com>
10457
10458         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10459         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10460         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10461         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10462         (pspy_set_type_printers): Likewise.
10463         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10464         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10465         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10466         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10467         (objfpy_set_type_printers): Likewise.
10468
10469 2019-01-03  Tom Tromey  <tom@tromey.com>
10470
10471         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10472         (gdbpy_print_stack): Use gdbpy_err_fetch.
10473         * python/python-internal.h (class gdbpy_err_fetch): New class.
10474         (class gdbpy_enter) <m_error_type, m_error_value,
10475         m_error_traceback>: Remove.
10476         <m_error>: New member.
10477         (gdbpy_exception_to_string): Don't declare.
10478         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10479         * python/py-value.c (convert_value_from_python): Use
10480         gdbpy_err_fetch.
10481         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10482         gdbpy_exception_to_string.
10483         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10484         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10485         gdbpy_err_fetch.
10486
10487 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10488
10489         * linux-nat.c (delete_lwp_cleanup): Delete.
10490         (struct lwp_deleter): New struct.
10491         (lwp_info_up): New typedef.
10492         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10493         lwp_info_up.
10494
10495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10496
10497         * linux-fork.c (class scoped_switch_fork_info): New class.
10498         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10499
10500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10501
10502         * valops.c (find_overload_match): Remove use of null_cleanup, and
10503         calls to do_cleanups.
10504
10505 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10506
10507         * compile/compile-cplus-types.c
10508         (compile_cplus_instance::decl_name): Handle changes to
10509         cp_func_name.
10510         * cp-support.c (cp_func_name): Update header comment, update
10511         return type.
10512         * cp-support.h (cp_func_name): Update return type in declaration.
10513         * valops.c (find_overload_match): Move temp_func local to top
10514         level of function and change its type.  Use temp_func to hold and
10515         delete temporary string obtained from cp_func_name.
10516
10517 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10518
10519         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10520         gdb::char_vector, remove cleanup, and update uses of `msg`.
10521
10522 2019-01-03  Jim Wilson  <jimw@sifive.com>
10523
10524         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10525
10526 2019-01-02  Tom Tromey  <tom@tromey.com>
10527
10528         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10529         (tdesc_parse_xml): Remove cleanups.
10530         * target-descriptions.h (make_cleanup_free_target_description):
10531         Don't declare.
10532         (target_desc_deleter): New struct.
10533         (target_desc_up): New typedef.
10534         * target-descriptions.c (target_desc_deleter::operator()): Rename
10535         from free_target_description.
10536         (make_cleanup_free_target_description): Remove.
10537
10538 2019-01-02  Tom Tromey  <tom@tromey.com>
10539
10540         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10541         constructor, destructor.
10542         (linespec_parser): Remove typedef.
10543         (~linespec_parser): Rename from linespec_parser_delete.
10544         (linespec_lex_to_end, linespec_complete_label)
10545         (linespec_complete): Update.
10546         (decode_line_full): Remove cleanups.
10547         (decode_line_1): Update.
10548
10549 2019-01-02  Tom Tromey  <tom@tromey.com>
10550
10551         * python/python-internal.h (inferior_to_inferior_object): Change
10552         return type.
10553         * python/py-exitedevent.c (create_exited_event_object): Update.
10554         * python/py-inferior.c (inferior_to_inferior_object): Return
10555         gdbpy_ref.
10556         (python_new_inferior, python_inferior_deleted)
10557         (thread_to_thread_object, delete_thread_object)
10558         (build_inferior_list, gdbpy_selected_inferior): Update.
10559         * python/py-infthread.c (create_thread_object): Update.  Also fail
10560         if inferior_to_inferior_object fails.
10561
10562 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10563
10564         * inferior.h (class inferior) <displaced_step_state>: New field.
10565         * infrun.h (struct displaced_step_state): Move here from
10566         infrun.c.  Initialize fields, add constructor.
10567         <inf>: Remove field.
10568         <reset>: New method.
10569         * infrun.c (struct displaced_step_inferior_state): Move to
10570         infrun.h.
10571         (displaced_step_inferior_states): Remove.
10572         (get_displaced_stepping_state): Adust.
10573         (displaced_step_in_progress_any_inferior): Adjust.
10574         (displaced_step_in_progress_thread): Adjust.
10575         (displaced_step_in_progress): Adjust.
10576         (add_displaced_stepping_state): Remove.
10577         (get_displaced_step_closure_by_addr): Adjust.
10578         (remove_displaced_stepping_state): Remove.
10579         (infrun_inferior_exit): Call displaced_step_state.reset.
10580         (use_displaced_stepping): Don't check for NULL.
10581         (displaced_step_prepare_throw): Call
10582         get_displaced_stepping_state.
10583         (displaced_step_fixup): Don't check for NULL.
10584         (prepare_for_detach): Don't check for NULL.
10585
10586 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10587
10588         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10589          in case of call that did not complete.
10590
10591 2019-01-02  Andrey Utkin  <autkin@undo.io>
10592
10593         * symfile.c (find_separate_debug_file): Fix search of debug files for
10594         remote debuggee.
10595
10596 2019-01-02  Tom Tromey  <tom@tromey.com>
10597
10598         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10599         indentation.
10600         * python/py-frame.c (frapy_older): Remove cast.
10601         (frapy_newer): Likewise.
10602         * python/py-breakpoint.c (local_setattro): Remove cast.
10603         * python/py-arch.c (archpy_name): Remove local variable.
10604         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10605
10606 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10607
10608         * unittests/basic_string_view/element_access/char/empty.cc:
10609         Fix year range in copyright header.
10610
10611 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10612
10613         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10614         Delete.
10615         <operator==>: Update with for removed field.
10616         <hash>: Likewise.
10617         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10618         <isa_features>: ...this.
10619         <abi_features>: New field.
10620         (riscv_isa_flen): Update comment.
10621         (riscv_abi_xlen): New declaration.
10622         (riscv_abi_flen): New declaration.
10623         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10624         isa_features.
10625         (riscv_abi_xlen): New function.
10626         (riscv_isa_flen): Update to get answer from isa_features.
10627         (riscv_abi_flen): New function.
10628         (riscv_has_fp_abi): Update to get answer from abi_features.
10629         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10630         xlen and flen.
10631         (riscv_call_info) <xlen, flen>: Update comment.
10632         (riscv_call_arg_struct): Remove invalid assertions
10633         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10634         is removed.
10635         (riscv_gdbarch_init): Gather isa features and abi features
10636         separately, ensure both match on the gdbarch when reusing an old
10637         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10638         a target with 64-bit float hardware.
10639
10640 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10641
10642         * source.c (search_command_helper): Stop reverse search
10643         when line 1 has been searched.
10644
10645 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10646
10647         * record-full.c (record_full_base_target::close): Rewrite
10648         record_full_core_buf_list free logic.
10649
10650 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10651
10652         * break-catch-syscall.c (print_one_catch_syscall): xfree
10653         the last text.
10654
10655 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10656
10657         * top.c (print_gdb_version): Update Copyright year in version
10658         message.
10659
10660 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10661
10662         Update copyright year range in all GDB files.
10663
10664 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10665
10666         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10667
10668 For older changes see ChangeLog-2018.
10669 \f
10670 Local Variables:
10671 mode: change-log
10672 left-margin: 8
10673 fill-column: 74
10674 version-control: never
10675 coding: utf-8
10676 End:
10677