gdb/ChangeLog

   1 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * symtab.c (lookup_global_symbol): Search global block.
   4
   5 2019-10-02  Tom Tromey  <tromey@adacore.com>
   6
   7         * coffread.c (process_coff_symbol): Update.
   8         * dwarf2read.c (var_decode_location, new_symbol): Update.
   9         * mdebugread.c (parse_symbol): Update.
  10         * objfiles.c (relocate_one_symbol): Update.
  11         * stabsread.c (define_symbol, fix_common_block)
  12         (scan_file_globals): Update.
  13         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
  14         (SET_SYMBOL_VALUE_ADDRESS): New macro.
  15         * xcoffread.c (process_xcoff_symbol): Update.
  16
  17 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
  18
  19         * MAINTAINERS: Update my email address.
  20
  21 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  22
  23         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
  24         std::vector.
  25         (build_type_psymtabs_reader): Update for std::vector.
  26         (build_type_psymtab_dependencies): Likewise.
  27         * dwarf2read.h: Remove use of DEF_VEC_P.
  28         (typedef sig_type_ptr): Delete.
  29
  30 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  31
  32         * btrace.c (btrace_maint_clear): Update to handle change from VEC
  33         to std::vector.
  34         (btrace_maint_decode_pt): Likewise, and move allocation of the
  35         vector outside of the loop.
  36         (btrace_maint_update_packets): Update to handle change from VEC to
  37         std::vector.
  38         (btrace_maint_print_packets): Likewise.
  39         (maint_info_btrace_cmd): Likewise.
  40         * btrace.h: Remove use of DEF_VEC_O.
  41         (typedef btrace_pt_packet_s): Delete.
  42         (struct btrace_maint_info) <packets>: Change fromm VEC to
  43         std::vector.
  44         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
  45
  46 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  47
  48         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
  49         make accesses into the vector constant references.
  50         (btrace_add_pc): Update for std::vector.
  51         (btrace_stitch_bts): Likewise.
  52         (parse_xml_btrace_block): Likewise.
  53         (btrace_maint_update_packets): Likewise.
  54         (btrace_maint_print_packets): Likewise.
  55         (maint_info_btrace_cmd): Likewise.
  56         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
  57         std::vector.
  58         (btrace_data::empty): Likewise.
  59         (btrace_data_append): Likewise.
  60         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
  61         (typedef btrace_block_s): Delete.
  62         (struct btrace_block): Add constructor.
  63         (struct btrace_data_bts) <blocks>: Change to std::vector.
  64         * nat/linux-btrace.c (perf_event_read_bts): Update for
  65         std::vector.
  66         (linux_read_bts): Likewise.
  67
  68 2019-10-01  Tom Tromey  <tom@tromey.com>
  69
  70         * cli/cli-logging.c (show_logging_filename): Use styled_string.
  71
  72 2019-10-01  Tom Tromey  <tom@tromey.com>
  73
  74         * stack.c (print_frame, info_frame_command_core): Use
  75         styled_string.
  76         * linux-thread-db.c (try_thread_db_load_1)
  77         (try_thread_db_load_from_pdir_1): Use styled_string.
  78         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
  79         (auto_load_section_scripts, info_auto_load_local_gdbinit)
  80         (maybe_print_unsupported_script_warning)
  81         (maybe_print_script_not_found_warning): Use styled_string.
  82         * ada-lang.c (user_select_syms): Use styled_string.
  83
  84 2019-10-01  Tom Tromey  <tom@tromey.com>
  85
  86         * p-lang.c (pascal_printstr): Use metadata style.
  87         * value.c (show_convenience): Use metadata style.
  88         * valprint.c (valprint_check_validity, val_print_optimized_out)
  89         (val_print_not_saved, val_print_unavailable)
  90         (val_print_invalid_address, generic_val_print, val_print)
  91         (value_check_printable, val_print_array_elements): Use metadata
  92         style.
  93         * ui-out.h (class ui_out) <field_fmt>: New overload.
  94         <do_field_fmt>: Add style parameter.
  95         * ui-out.c (ui_out::field_fmt): New overload.
  96         * typeprint.c (type_print_unknown_return_type)
  97         (val_print_not_allocated, val_print_not_associated): Use metadata
  98         style.
  99         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 100         parameter.
 101         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 102         * tracepoint.c (tvariables_info_1): Use metadata style.
 103         * stack.c (print_frame_arg, print_frame_info, print_frame)
 104         (info_frame_command_core): Use metadata style.
 105         * skip.c (info_skip_command): Use metadata style.
 106         * rust-lang.c (rust_print_enum): Use metadata style.
 107         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 108         metadata style.
 109         * python/py-framefilter.c (py_print_single_arg): Use metadata
 110         style.
 111         * printcmd.c (do_one_display, print_variable_and_value): Use
 112         metadata style.
 113         * p-valprint.c (pascal_val_print)
 114         (pascal_object_print_value_fields): Use metadata style.
 115         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 116         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 117         parameter.
 118         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 119         * m2-valprint.c (m2_print_long_set): Use metadata style.
 120         * m2-typeprint.c (m2_print_type): Use metadata style.
 121         * infcmd.c (print_return_value_1): Use metadata style.
 122         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 123         * f-valprint.c (info_common_command_for_block): Use metadata
 124         style.
 125         * f-typeprint.c (f_type_print_base): Use metadata style.
 126         * expprint.c (print_subexp_standard): Use metadata style.
 127         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 128         * cli/cli-style.h (class cli_style_option): Add constructor.
 129         (metadata_style): Declare.
 130         * cli/cli-style.c (metadata_style): New global.
 131         (_initialize_cli_style): Register metadata style.
 132         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 133         parameter.
 134         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 135         * c-typeprint.c (c_type_print_base_struct_union)
 136         (c_type_print_base_1): Use metadata style.
 137         * breakpoint.c (watchpoint_value_print)
 138         (print_one_breakpoint_location): Use metadata style.
 139         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 140         style.
 141         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 142         style.
 143         * ada-valprint.c (val_print_packed_array_elements, printstr)
 144         (print_field_values, ada_val_print_ref, ada_val_print): Use
 145         metadata style.
 146         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 147         style.
 148         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 149         style.
 150         * ada-lang.c (user_select_syms): Use metadata style.
 151
 152 2019-10-01  Tom Tromey  <tom@tromey.com>
 153
 154         * cli/cli-cmds.c (pwd_command): Style output.
 155
 156 2019-10-01  Pedro Alves  <palves@redhat.com>
 157             Tom Tromey  <tom@tromey.com>
 158
 159         * symtab.c (print_symbol_info): Use %ps.
 160         (print_msymbol_info): Use %ps.
 161         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 162         * printcmd.c (print_variable_and_value): Use %ps.
 163         * macrocmd.c (show_pp_source_pos): Use %ps.
 164         * infrun.c (print_exited_reason): Use ui_out::message.
 165         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 166         (describe_other_breakpoints): Use ui_out::message and new
 167         formats.
 168         (say_where): Use new formats.
 169         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 170         and new formats.
 171
 172 2019-10-01  Pedro Alves  <palves@redhat.com>
 173             Tom Tromey  <tom@tromey.com>
 174
 175         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 176         (test_gdb_formats): New function.
 177         (run_tests): Call it.
 178         (test_format_specifier): Update.
 179         * utils.h (fputs_filtered): Update comment.
 180         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 181         (fputs_styled_unfiltered): Declare.
 182         * utils.c (fputs_styled_unfiltered): New function.
 183         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 184         (vfprintf_filtered): Update.
 185         (vfprintf_unfiltered, vprintf_filtered): Update.
 186         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 187         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 188         disallow_ui_out_field>: New constants.
 189         (enum class field_kind): New.
 190         (struct base_field_s, struct signed_field_s): New.
 191         (signed_field): New function.
 192         (struct string_field_s): New.
 193         (string_field): New function.
 194         (struct styled_string_s): New.
 195         (styled_string): New function.
 196         (class ui_out) <message>: Add comment.
 197         <vmessage, call_do_message>: New methods.
 198         <do_message>: Add style parameter.
 199         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 200         methods.
 201         (ui_out::message): Rewrite.
 202         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 203         parameter.
 204         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 205         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 206         gdb_extensions parameter.
 207         (class format_piece): Add parameter to constructor.
 208         (n_int_args): New field.
 209         * gdbsupport/format.c (format_pieces::format_pieces): Add
 210         gdb_extensions parameter.  Handle '*'.
 211         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 212         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 213         vfprintf_styled_no_gdbfmt.
 214         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 215         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 216         unfiltered output.
 217         * ui-style.h (struct ui_file_style) <ptr>: New method.
 218
 219 2019-10-01  Tom Tromey  <tom@tromey.com>
 220
 221         * unittests/format_pieces-selftests.c: Update.  Add final format.
 222         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 223         empty literal pieces.
 224
 225 2019-10-01  Tom Tromey  <tom@tromey.com>
 226
 227         * ui-out.h (enum class ui_out_style_kind): Remove.
 228         (class ui_out) <field_string, field_stsream, do_field_string>:
 229         Change type of "style".
 230         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 231         (ui_out::field_string): Update.
 232         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 233         of "style".
 234         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 235         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 236         * stack.c (print_frame_arg, print_frame_info, print_frame):
 237         Update.
 238         * source.c (print_source_lines_base): Update.
 239         * solib.c (info_sharedlibrary_command): Update.
 240         * skip.c (info_skip_command): Update.
 241         * record-btrace.c (btrace_call_history_src_line)
 242         (btrace_call_history): Update.
 243         * python/py-framefilter.c (py_print_frame): Update.
 244         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 245         "style".
 246         * mi/mi-out.c (mi_ui_out::do_table_header)
 247         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 248         (mi_ui_out::do_field_string): Update.
 249         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 250         Update.
 251         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 252         "style".
 253         * cli-out.c (cli_ui_out::do_table_header)
 254         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 255         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 256         (cli_ui_out::do_field_fmt): Update.
 257         * breakpoint.c (print_breakpoint_location): Update.
 258         (update_static_tracepoint): Update.
 259
 260 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 261
 262         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 263         conversion of gdb_datadir.
 264         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 265         remove not needed c_str ().
 266
 267 2019-09-30  Ali Tamur <tamur@google.com>
 268
 269         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 270         (dwarf2_string_attr): Likewise.
 271
 272 2019-09-30  Ali Tamur <tamur@google.com>
 273
 274         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 275         (process_full_type_unit): Likewise.
 276         (dump_die_shallow): Likewise.
 277         (cu_debug_loc_section): Likewise.
 278
 279 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 280
 281         * minsyms.c (compare_minimal_symbols): Rename to...
 282         (minimal_symbol_is_less_than): ...this, and adjust to STL
 283         conventions (return bool, take arguments as references)
 284         (minimal_symbol_reader::install): Call std::sort instead
 285         of qsort.
 286
 287 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 288
 289         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 290         hash and why.
 291         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 292         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 293
 294 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 295
 296         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 297         * psympriv.h (add_psymbol_to_list): Move comment here and update
 298         it.
 299
 300 2019-09-29  Tom de Vries  <tdevries@suse.de>
 301
 302         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 303         Use $tmpdir/$(basename "$output_file").dwz instead of
 304         "${output_file}.dwz".
 305
 306 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 307
 308         PR gdb/25045
 309         * hppa-linux-nat.c: Include gdbarch.h.
 310
 311 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 312
 313         * blockframe.c (find_pc_partial_function): Change return type to bool.
 314         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 315         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 316         (stub_gnu_ifunc_resolve_name): Likewise.
 317         * symtab.c (compare_filenames_for_search): Likewise.
 318         (compare_glob_filenames_for_search): Likewise.
 319         (matching_obj_sections): Likewise.
 320         (symbol_matches_domain): Likewise.
 321         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 322         (find_line_pc): Change return type to bool.
 323         (find_line_pc_range): Likewise.
 324         (producer_is_realview): Likewise.
 325         * symtab.h (symbol_matches_domain): Likewise.
 326         (find_pc_partial_function): Likewise.
 327         (find_pc_line_pc_range): Likewise.
 328         (in_gnu_ifunc_stub): Likewise.
 329         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 330         (find_line_pc): Likewise.
 331         (find_line_pc_range): Likewise.
 332         (matching_obj_sections): Likewise.
 333         (find_line_symtab): Change out parameter to bool.
 334         (producer_is_realview): Change return type to bool.
 335         (compare_filenames_for_search): Likewise.
 336         (compare_glob_filenames_for_search): Likewise.
 337
 338 2019-09-26  Tom Tromey  <tom@tromey.com>
 339
 340         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 341         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 342         * gdb_usleep.h: Remove.
 343         * gdb_usleep.c: Remove.
 344         * utils.c: Don't include gdb_usleep.h.
 345
 346 2019-09-26  Tom Tromey  <tromey@adacore.com>
 347
 348         * python/py-type.c (type_to_type_object): Call check_typedef
 349         for stub types.
 350
 351 2019-09-26  Tom Tromey  <tom@tromey.com>
 352
 353         * utils.h (initialize_utils): Don't declare.
 354         * top.c (gdb_init): Don't call initialize_utils.
 355         * utils.c (initialize_utils): Remove.  Move contents...
 356         (_initialize_utils): ... here.
 357
 358 2019-09-25  Tom Tromey  <tom@tromey.com>
 359
 360         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 361         * utils.h (make_hex_string): Don't declare.
 362         * utils.c (make_hex_string): Remove.
 363
 364 2019-09-24  Tom de Vries  <tdevries@suse.de>
 365
 366         PR gdb/23815
 367         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 368         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 369
 370 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 371
 372         * NEWS: Mention new simulator port for PRU.
 373
 374 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 375
 376         * ada-exp.y (write_object_remaining): Update.
 377         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 378         and eliminate the static buffer.
 379         (ada_decode_symbol): Update.
 380         (ada_la_decode): Update.
 381         (ada_sniff_from_mangled_name): Update.
 382         (is_valid_name_for_wild_match): Update.
 383         (ada_lookup_name_info::matches): Update and simplify.
 384         (name_matches_regex): Update.
 385         (ada_add_global_exceptions): Update.
 386         * ada-lang.h (ada_decode): Update signature.
 387         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 388         * dwarf-index-write.c (debug_names::insert): Update.
 389
 390 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 391
 392         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 393         formatting.
 394
 395 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 396
 397         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 398         Change "nonzero" to "true" in documentation.
 399
 400 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 401
 402         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 403         (_initialize_darwin_solib): Don't set
 404         darwin_so_ops.lookup_lib_global_symbol.
 405         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 406         set_gdbarch_iterate_over_objfiles_in_search_order.
 407         (elf_lookup_lib_symbol): Rename to...
 408         (svr4_iterate_over_objfiles_in_search_order): this, and update
 409         to iterate semantics.
 410         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 411         * solib.c (solib_global_lookup): Remove.
 412         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 413         (solib_global_lookup): Remove.
 414         * symtab.c (lookup_global_or_static_symbol): Remove call to
 415         solib_global_lookup.
 416
 417 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 418
 419         * NEWS: Move entries about default MI version now being
 420         version 3, and about the GDB/MI fix for multi-location
 421         breakpoints to the "since GDB 8.3" section.
 422
 423 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 424
 425         GDB 8.3.1 released.
 426
 427 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 428
 429         * NEWS: Mention that Cell/B.E. debugging support was removed.
 430         * MAINTAINERS: Remove spu target.
 431
 432         * config/djgpp/fnchange.lst: Remove entries for removed files.
 433
 434         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 435         spu-multiarch.o, and spu-tdep.o.
 436         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 437         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 438         spu-multiarch.c, and spu-tdep.c.
 439         * spu-linux-nat.c: Remove file.
 440         * spu-multiarch.c: Remove file.
 441         * spu-tdep.c: Remove file.
 442         * spu-tdep.h: Remove file.
 443         * solib-spu.c: Remove file.
 444         * solib-spu.h: Remove file.
 445
 446         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 447         * configure.nat (spu-linux): Remove.
 448         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 449         solib-multiarch.o from gdb_target_obs.
 450         (spu*-*-*): Remove.
 451
 452         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 453         feature flag.
 454         (ppc_linux_no_features): Update.
 455         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 456         Cell/B.E. support.
 457         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 458         (tdesc_powerpc_cell64l): Likewise.
 459         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 460         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 461         Cell/B.E. support.
 462         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 463         Do not include "features/rs6000/powerpc-cell32l.c" or
 464         "features/rs6000/powerpc-cell64l.c".
 465         (ppc_linux_spu_section): Remove.
 466         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 467         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 468         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 469         (ppc_linux_spe_context_lookup): Remove.
 470         (ppc_linux_spe_context_inferior_created): Remove.
 471         (ppc_linux_spe_context_solib_loaded): Remove.
 472         (ppc_linux_spe_context_solib_unloaded): Remove.
 473         (ppc_linux_spe_context): Remove.
 474         (struct ppu2spu_cache): Remove.
 475         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 476         (struct ppu2spu_data): Remove.
 477         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 478         ppu2spu_unwind): Remove.
 479         (ppc_linux_init_abi): Remove Cell/B.E. support.
 480         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 481
 482         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 483         (rs6000/powerpc-cell64l-expedite): Likewise
 484         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 485         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 486         rs6000/powerpc-cell64l.xml.
 487         * features/rs6000/powerpc-cell32l.xml: Remove.
 488         * features/rs6000/powerpc-cell64l.xml: Likewise.
 489         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 490         * features/rs6000/powerpc-cell64l.c: Likewise.
 491         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 492         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 493         * regformats/reg-spu.dat: Remove.
 494
 495         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 496         * corelow.c (struct spuid_list): Remove.
 497         (add_to_spuid_list): Remove.
 498         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 499         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 500         (remote_protocol_features): Remove associated entries.
 501         (_initialize_remote): No longer initialize them.
 502         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 503         * linux-nat.c (SPUFS_MAGIC): Remove.
 504         (linux_proc_xfer_spu): Remove.
 505         (spu_enumerate_spu_ids): Remove.
 506         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 507         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 508         (linux_make_corefile_notes): No longer call it.
 509
 510         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 511         (cooked_write_test): Likewise.
 512
 513 2019-09-20  Tom Tromey  <tom@tromey.com>
 514
 515         * NEWS: Mention case-sensitivity of TUI commands.
 516         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 517         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 518         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 519
 520 2019-09-20  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-source.c (tui_source_window::set_contents): Use
 523         make_unique_xstrdup.
 524         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 525         make_unique_xstrdup.
 526
 527 2019-09-20  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-data.c: Remove separator comments.
 530         * tui/tui-layout.c: Remove separator comments.
 531         * tui/tui-win.c: Remove separator comments.
 532         * tui/tui-wingeneral.c: Remove separator comments.
 533
 534 2019-09-20  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui.h (strcat_to_buf): Don't declare.
 537         * tui/tui.c (strcat_to_buf): Remove.
 538
 539 2019-09-20  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 542         from "fullname".
 543         * tui/tui-source.c (tui_source_window::set_contents)
 544         (tui_source_window::location_matches_p)
 545         (tui_source_window::maybe_update): Update.
 546
 547 2019-09-20  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 550         Update.
 551         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 552         prefix.
 553         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 554         (tui_data_window::line_from_reg_element_no)
 555         (tui_data_window::first_reg_element_no_inline)
 556         (tui_data_window::show_registers)
 557         (tui_data_window::show_register_group)
 558         (tui_data_window::display_registers_from)
 559         (tui_data_window::display_registers_from_line)
 560         (tui_data_window::first_data_item_displayed)
 561         (tui_data_window::delete_data_content_windows)
 562         (tui_data_window::erase_data_content)
 563         (tui_data_window::do_scroll_vertical)
 564         (tui_data_window::refresh_window)
 565         (tui_data_window::check_register_values): Update.
 566
 567 2019-09-20  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 570         (struct tui_locator_window) <full_name, proc_name>: Now
 571         std::string.
 572         * tui/tui-stack.c (tui_locator_window::make_status_line)
 573         (tui_locator_window::set_locator_fullname)
 574         (tui_locator_window::set_locator_info): Update.
 575         * tui/tui-source.c (tui_source_window::set_contents)
 576         (tui_source_window::showing_source_p): Update.
 577
 578 2019-09-20  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 581         Don't call tui_locator_win_info_ptr.
 582
 583 2019-09-20  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 586
 587 2019-09-20  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 590         height for locator.
 591         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 592         * tui/tui-layout.c (show_source_disasm_command, show_data)
 593         (show_source_or_disasm_and_command): Use 1 as height for locator.
 594
 595 2019-09-20  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui.c (tui_enable): Update.
 598         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 599         Update.
 600         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 601         Update.
 602         * tui/tui-data.c (win_resized): Now bool.
 603         (tui_win_resized): Return bool.
 604         (tui_set_win_resized_to): Accept a bool.
 605
 606 2019-09-20  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 609         Change type of "refresh_values_only".
 610         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 611         type of "refresh_values_only".
 612
 613 2019-09-20  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 616         std::string.
 617         (tui_disassemble): Add "pos" parameter.
 618         (tui_disasm_window::set_contents): Simplify.
 619
 620 2019-09-20  Tom Tromey  <tom@tromey.com>
 621
 622         * tui/tui-winsource.h (struct tui_source_window_base)
 623         <show_source_content>: Now private.
 624         * tui/tui-winsource.c
 625         (tui_source_window_base::show_source_content): Don't handle empty
 626         content case.
 627
 628 2019-09-20  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-layout.c (show_source_disasm_command)
 631         (show_source_or_disasm_and_command): Don't call
 632         show_source_content.
 633
 634 2019-09-20  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 637         Declare.
 638         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 639         from tui_make_status_line.
 640         (tui_locator_window::rerender): Update.
 641
 642 2019-09-20  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 645         (tui_locator_window::rerender): Update.
 646
 647 2019-09-20  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-winsource.h (struct tui_source_window_base)
 650         <~tui_source_window_base>: Don't declare.
 651         <fullname>: Remove.
 652         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 653         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 654         member.
 655         * tui/tui-source.c (tui_source_window::set_contents): Update.
 656         (tui_source_window::location_matches_p)
 657         (tui_source_window::maybe_update): Update.
 658
 659 2019-09-20  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-winsource.h (~tui_source_element): Remove.
 662         (tui_source_element): Update.
 663         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 664         * tui/tui-winsource.c (tui_show_source_line): Update.
 665         * tui/tui-source.c (tui_source_window::set_contents): Update.
 666         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 667
 668 2019-09-20  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 671         declare.
 672         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 673         tui_clear_source_windows_detail.
 674         * tui/tui-winsource.h (struct tui_source_window_base)
 675         <clear_detail>: Don't declare.
 676         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 677         Remove.
 678         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 679
 680 2019-09-20  Tom Tromey  <tromey@adacore.com>
 681
 682         PR ada/24919:
 683         * block.c (contained_in): Fix final return value.
 684
 685 2019-09-20  Alan Modra  <amodra@gmail.com>
 686
 687         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 688         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 689         (read_indirect_string_from_dwz): Use bfd accessor.
 690         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 691         * machoread.c (macho_symfile_read_all_oso): Likewise.
 692         * solib.c (solib_bfd_open): Likewise.
 693
 694 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 695
 696         * eval.c: Move declaration of overload_resolution to...
 697         * value.h: ...here.
 698
 699 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 700
 701         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 702         * arm-linux-tdep.c: Likewise.
 703         * arm-nbsd-nat.c: Likewise.
 704         * arm-tdep.h: Declare arm_apcs_32.
 705         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 706
 707 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 708
 709         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 710         * dwarf2read.h: Declare dwarf_always_disassemble.
 711
 712 2019-09-19  Tom de Vries  <tdevries@suse.de>
 713
 714         PR gdb/25009
 715         * source-cache.c (source_cache::ensure): Catch exception thrown during
 716         construction of the highlighter.
 717
 718 2019-09-18  Alan Modra  <amodra@gmail.com>
 719
 720         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 721         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 722         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 723         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 724         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 725         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 726         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 727         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 728         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 729         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 730         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 731         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 732         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 733         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 734         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 735         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 736         * mi/mi-interp.c: Update throughout for bfd section macro and
 737         function changes.
 738         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 739         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 740
 741 2019-09-18  Tom Tromey  <tom@tromey.com>
 742
 743         * NEWS: Add entry.
 744         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 745         call rl_initialize.
 746         (tui_enable): Do not call rl_initialize.
 747
 748 2019-09-18  Christian Groessler  <chris@groessler.org>
 749
 750         * alpha-linux-nat.c: Include gdbarch.h.
 751
 752 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 753
 754         * ui-file.c: Include cli/cli-style.h.
 755         (term_cli_styling): Remove cli_styling declaration.
 756
 757 2019-09-18  Alan Modra  <amodra@gmail.com>
 758
 759         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 760         to bfd_asymbol_section.
 761
 762 2019-09-18  Alan Modra  <amodra@gmail.com>
 763
 764         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 765         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 766         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 767
 768 2019-09-18  Alan Modra  <amodra@gmail.com>
 769
 770         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 771         * spu-linux-nat.c (spu_bfd_open): Likewise.
 772
 773 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 774
 775         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 776         to bool to match definition in dwarf2read.c.
 777
 778 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 779
 780         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 781         (print_signatures): Likewise.
 782         (trust_pad_over_xvs): Likewise.
 783         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 784         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 785         * arm-linux-nat.c (arm_apcs_32): Likewise.
 786         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 787         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 788         * arm-tdep.c (arm_debug): Likewise.
 789         (arm_apcs_32): Likewise.
 790         * auto-load.c (debug_auto_load): Likewise.
 791         (auto_load_gdb_scripts): Likewise.
 792         (global_auto_load): Likewise.
 793         (auto_load_local_gdbinit): Likewise.
 794         (auto_load_local_gdbinit_loaded): Likewise.
 795         * auto-load.h (global_auto_load): Likewise.
 796         (auto_load_local_gdbinit): Likewise.
 797         (auto_load_local_gdbinit_loaded): Likewise.
 798         * breakpoint.c (disconnected_dprintf): Likewise.
 799         (breakpoint_proceeded): Likewise.
 800         (automatic_hardware_breakpoints): Likewise.
 801         (always_inserted_mode): Likewise.
 802         (target_exact_watchpoints): Likewise.
 803         (_initialize_breakpoint): Update.
 804         * breakpoint.h (target_exact_watchpoints): Change to bool.
 805         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 806         * cli/cli-cmds.c (trace_commands): Likewise.
 807         * cli/cli-cmds.h (trace_commands): Likewise.
 808         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 809         to bool*.
 810         * cli/cli-logging.c (logging_overwrite): Change to bool.
 811         (logging_redirect): Likewise.
 812         (debug_redirect): Likewise.
 813         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 814         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 815         to bool.
 816         <boolean_option_def>: Update.
 817         (struct flag_option_def): Change default type of Context to bool
 818         from int.
 819         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 820         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 821         (get_setshow_command_value_string): Likewise.
 822         * cli/cli-style.c (cli_styling): Change to bool.
 823         (source_styling): Likewise.
 824         * cli/cli-style.h (source_styling): Likewise.
 825         (cli_styling): Likewise.
 826         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 827         to bool.
 828         * command.h (var_types): Update comment.
 829         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 830         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 831         bool.
 832         (debug_compile_cplus_scopes): Likewise.
 833         * compile/compile-internal.h (compile_debug): Likewise.
 834         * compile/compile.c (compile_debug): Likewise.
 835         (struct compile_options) <raw>: Likewise.
 836         * cp-support.c (catch_demangler_crashes): Likewise.
 837         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 838         (usr_cmd_cris_dwarf2_cfi): Likewise.
 839         * csky-tdep.c (csky_debug): Likewise.
 840         * darwin-nat.c (enable_mach_exceptions): Likewise.
 841         * dcache.c (dcache_enabled_p): Likewise.
 842         * defs.h (info_verbose): Likewise.
 843         * demangle.c (demangle): Likewise.
 844         (asm_demangle): Likewise.
 845         * dwarf-index-cache.c (debug_index_cache): Likewise.
 846         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 847         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 848         * dwarf2read.c (check_physname): Likewise.
 849         (use_deprecated_index_sections): Likewise.
 850         (dwarf_always_disassemble): Likewise.
 851         * eval.c (overload_resolution): Likewise.
 852         * event-top.c (set_editing_cmd_var): Likewise.
 853         (exec_done_display_p): Likewise.
 854         * event-top.h (set_editing_cmd_var): Likewise.
 855         (exec_done_display_p): Likewise.
 856         * exec.c (write_files): Likewise.
 857         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 858         (debug_fbsd_nat): Likewise.
 859         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 860         Likewise.
 861         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 862         <backtrace_past_entry> Likewise.
 863         * gdb-demangle.h (demangle): Likewise.
 864         (asm_demangle): Likewise.
 865         * gdb_bfd.c (bfd_sharing): Likewise.
 866         * gdbcore.h (write_files): Likewise.
 867         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 868         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 869         * gdbthread.h (print_thread_events): Likewise.
 870         * gdbtypes.c (opaque_type_resolution): Likewise.
 871         (strict_type_checking): Likewise.
 872         * gnu-nat.c (gnu_debug_flag): Likewise.
 873         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 874         * guile/scm-param.c (pascm_variable): Add boolval.
 875         (add_setshow_generic): Update.
 876         (pascm_param_value): Update.
 877         (pascm_set_param_value_x): Update.
 878         * hppa-tdep.c (hppa_debug): Change to bool..
 879         * infcall.c (may_call_functions_p): Likewise.
 880         (coerce_float_to_double_p): Likewise.
 881         (unwind_on_signal_p): Likewise.
 882         (unwind_on_terminating_exception_p): Likewise.
 883         * infcmd.c (startup_with_shell): Likewise.
 884         * inferior.c (print_inferior_events): Likewise.
 885         * inferior.h (startup_with_shell): Likewise.
 886         (print_inferior_events): Likewise.
 887         * infrun.c (step_stop_if_no_debug): Likewise.
 888         (detach_fork): Likewise.
 889         (debug_displaced): Likewise.
 890         (disable_randomization): Likewise.
 891         (non_stop): Likewise.
 892         (non_stop_1): Likewise.
 893         (observer_mode): Likewise.
 894         (observer_mode_1): Likewise.
 895         (set_observer_mode): Update.
 896         (sched_multi): Change to bool.
 897         * infrun.h (debug_displaced): Likewise.
 898         (sched_multi): Likewise.
 899         (step_stop_if_no_debug): Likewise.
 900         (non_stop): Likewise.
 901         (disable_randomization): Likewise.
 902         * linux-tdep.c (use_coredump_filter): Likewise.
 903         (dump_excluded_mappings): Likewise.
 904         * linux-thread-db.c (auto_load_thread_db): Likewise.
 905         (check_thread_db_on_load): Likewise.
 906         * main.c (captured_main_1): Update.
 907         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 908         xx2_opt, boolean_opt>: Change to bool.
 909         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 910         * maint.c (maintenance_profile_p): Likewise.
 911         (per_command_time): Likewise.
 912         (per_command_space): Likewise.
 913         (per_command_symtab): Likewise.
 914         * memattr.c (inaccessible_by_default): Likewise.
 915         * mi/mi-main.c (mi_async): Likewise.
 916         (mi_async_1): Likewise.
 917         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 918         * nat/fork-inferior.h (startup_with_shell): Likewise.
 919         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 920         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 921         * nios2-tdep.c (nios2_debug): Likewise.
 922         * or1k-tdep.c (or1k_debug): Likewise.
 923         * parse.c (parser_debug): Likewise.
 924         * parser-defs.h (parser_debug): Likewise.
 925         * printcmd.c (print_symbol_filename): Likewise.
 926         * proc-api.c (procfs_trace): Likewise.
 927         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 928         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 929         (set_parameter_value): Update.
 930         (add_setshow_generic): Update.
 931         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 932         to bool*.
 933         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 934         int*.
 935         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 936         * record-btrace.c (record_btrace_target::store_registers): Update.
 937         * record-full.c (record_full_memory_query): Change to bool.
 938         (record_full_stop_at_limit): Likewise.
 939         * record-full.h (record_full_memory_query): Likewise.
 940         * remote-notif.c (notif_debug): Likewise.
 941         * remote-notif.h (notif_debug): Likewise.
 942         * remote.c (use_range_stepping): Likewise.
 943         (interrupt_on_connect): Likewise.
 944         (remote_break): Likewise.
 945         * ser-tcp.c (tcp_auto_retry): Likewise.
 946         * ser-unix.c (serial_hwflow): Likewise.
 947         * skip.c (debug_skip): Likewise.
 948         * solib-aix.c (solib_aix_debug): Likewise.
 949         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 950         (spu_auto_flush_cache_p): Likewise.
 951         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 952         Likewise.
 953         (struct info_print_options) <quiet>: Likewise.
 954         * symfile-debug.c (debug_symfile): Likewise.
 955         * symfile.c (auto_solib_add): Likewise.
 956         (separate_debug_file_debug): Likewise.
 957         * symfile.h (auto_solib_add): Likewise.
 958         (separate_debug_file_debug): Likewise.
 959         * symtab.c (basenames_may_differ): Likewise.
 960         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 961         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 962         (struct info_types_options) <quiet>: Likewise.
 963         * symtab.h (demangle): Likewise.
 964         (basenames_may_differ): Likewise.
 965         * target-dcache.c (stack_cache_enabled_1): Likewise.
 966         (code_cache_enabled_1): Likewise.
 967         * target.c (trust_readonly): Likewise.
 968         (may_write_registers): Likewise.
 969         (may_write_memory): Likewise.
 970         (may_insert_breakpoints): Likewise.
 971         (may_insert_tracepoints): Likewise.
 972         (may_insert_fast_tracepoints): Likewise.
 973         (may_stop): Likewise.
 974         (auto_connect_native_target): Likewise.
 975         (target_stop_and_wait): Update.
 976         (target_async_permitted): Change to bool.
 977         (target_async_permitted_1): Likewise.
 978         (may_write_registers_1): Likewise.
 979         (may_write_memory_1): Likewise.
 980         (may_insert_breakpoints_1): Likewise.
 981         (may_insert_tracepoints_1): Likewise.
 982         (may_insert_fast_tracepoints_1): Likewise.
 983         (may_stop_1): Likewise.
 984         * target.h (target_async_permitted): Likewise.
 985         (may_write_registers): Likewise.
 986         (may_write_memory): Likewise.
 987         (may_insert_breakpoints): Likewise.
 988         (may_insert_tracepoints): Likewise.
 989         (may_insert_fast_tracepoints): Likewise.
 990         (may_stop): Likewise.
 991         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 992         (make_thread_apply_all_options_def_group): Change argument from int*
 993         to bool*.
 994         (thread_apply_all_command): Update.
 995         (print_thread_events): Change to bool.
 996         * top.c (confirm): Likewise.
 997         (command_editing_p): Likewise.
 998         (history_expansion_p): Likewise.
 999         (write_history_p): Likewise.
1000         (info_verbose): Likewise.
1001         * top.h (confirm): Likewise.
1002         (history_expansion_p): Likewise.
1003         * tracepoint.c (disconnected_tracing): Likewise.
1004         (circular_trace_buffer): Likewise.
1005         * typeprint.c (print_methods): Likewise.
1006         (print_typedefs): Likewise.
1007         * utils.c (debug_timestamp): Likewise.
1008         (sevenbit_strings): Likewise.
1009         (pagination_enabled): Likewise.
1010         * utils.h (sevenbit_strings): Likewise.
1011         (pagination_enabled): Likewise.
1012         * valops.c (overload_resolution): Likewise.
1013         * valprint.h (struct value_print_options) <prettyformat_arrays,
1014         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1015         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1016         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1017         Likewise.
1018         * windows-nat.c (new_console): Likewise.
1019         (cygwin_exceptions): Likewise.
1020         (new_group): Likewise.
1021         (debug_exec): Likewise.
1022         (debug_events): Likewise.
1023         (debug_memory): Likewise.
1024         (debug_exceptions): Likewise.
1025         (useshell): Likewise.
1026         * windows-tdep.c (maint_display_all_tib): Likewise.
1027         * xml-support.c (debug_xml): Likewise.
1028
1029 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1030
1031         * source.c (prepare_path_for_appending): New function.
1032         (openp): Make use of new function.
1033         (find_and_open_source): Search for the compilation directory and
1034         source file as a relative path beneath the directory search path.
1035
1036 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1037
1038         * source-cache.c (source_cache::get_line_charpos): Catch
1039         exceptions and return false, this matches the behaviour documented
1040         in the header file.
1041
1042 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1043
1044         * ada-tasks.c (info_task): Remove quoting of the task's name.
1045
1046 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1047
1048         * symfile.c (auto_solib_add): Replace comment with a reference
1049         to the header file.
1050
1051 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1052
1053         * NEWS: Mention that gdb can now be compiled with Python 3
1054         on Windows.
1055
1056 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * maint.c (maint_print_section_data::maint_print_section_data):
1059         Force use of 'float log10 (float)' by casting the argument to
1060         float.
1061
1062 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * maint.c: Add 'cmath' include.
1065         (struct maint_print_section_data): New structure.
1066         (print_section_index): New function.
1067         (print_bfd_section_info): Add header comment, small whitespace
1068         cleanup, and update to call new print_section_index function.
1069         (print_objfile_section_info): Likewise.
1070         (maint_obj_section_from_bfd_section): New function.
1071         (print_bfd_section_info_maybe_relocated): New function.
1072         (maintenance_info_sections): Add header comment, always use
1073         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1074
1075 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1076
1077         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1078         inner scope, add check that the objfile has psymtabs before
1079         checking psymtabs_addrmap.
1080         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1081
1082 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1083
1084         * NEWS: Announce that Ada task names are now shown at more places,
1085         and between quotes (except in info task output).
1086         * gdb/ada-tasks.c (task_to_str): New function.
1087         (display_current_task_id): Call task_to_str.
1088         (task_command_1): Likewise.
1089         (print_ada_task_info): In non-mi mode, Properly align headers and data
1090         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1091
1092 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1093
1094         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1095         prstatus.pr_lwp.pr_info instead of making it up.
1096
1097 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1098
1099         * auto-load.c (auto_load_expand_dir_vars): Update.
1100         * defs.h (gdb_datadir): Change to std::string.
1101         (python_libdir): Likewise.
1102         (relocate_gdb_directory): Change return type to std::string.
1103         * guile/guile.c (gdbscm_data_directory): Update.
1104         (initialize_scheme_side): Update.
1105         * jit.c (jit_reader_dir): Change to std::string.
1106         (jit_reader_load_command): Update.
1107         * main.c (gdb_datadir): Change to std::string.
1108         (python_libdir): Likewise.
1109         (set_gdb_data_directory): Update.
1110         (relocate_path): Change to return std::string.
1111         (relocate_gdb_directory): Change to return std::string.
1112         (relocate_gdbinit_path_maybe_in_datadir): Update.
1113         (captured_main_1): Update.
1114         * python/python.c (do_start_initialization): Update.
1115         * top.c (show_gdb_datadir): Update.
1116         * xml-syscall.c (xml_init_syscalls_info): Update.
1117         (init_syscalls_info): Update.
1118
1119 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1120
1121         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1122         out of get_init_files.
1123         (get_init_files): Update.
1124
1125 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1126
1127         * main.c (get_init_files): Change to use std::string.
1128         (captured_main_1): Update.
1129         (print_gdb_help): Update.
1130
1131 2019-09-11  Ali Tamur  <tamur@google.com>
1132
1133         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1134         implementation.
1135
1136 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1137
1138         * dbxread.c (read_dbx_symtab): Update.
1139         * dwarf2read.c (load_partial_dies): Update.
1140         * mdebugread.c (parse_partial_symbols): Update.
1141         (handle_psymbol_enumerators): Update.
1142         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1143         * psymtab.c (add_psymbol_to_bcache): Likewise.
1144         (add_psymbol_to_list): Likewise.
1145         * symtab.c (symbol_set_names): Likewise.
1146         * symtab.h (symbol_set_names): Likewise.
1147         * xcoffread.c (scan_xcoff_symtab): Update.
1148
1149 2019-09-11  Tom Tromey  <tom@tromey.com>
1150
1151         * symfile-mem.c (symbol_file_add_from_memory): Use
1152         bfd_set_filename.
1153         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1154         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1155
1156 2019-09-10  Tom Tromey  <tromey@adacore.com>
1157
1158         * dwarf-index-write.c (write_psymbols): Extend error message.
1159         (debug_names::insert): Add Ada code.
1160         (debug_names::write_psymbols): Remove Ada check.
1161         (debug_names) <m_string_obstack>: New member.
1162         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1163         (gdb_index_symbol_name_matcher::matches): Remove.
1164         (mapped_index_base::find_name_components_bounds): Add "lang"
1165         parameter.
1166         (mapped_index_base::build_name_components): Also split names
1167         according to Ada syntax.
1168         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1169         type of "match_callback".
1170         (check_match, check_find_bounds_finds)
1171         (dw2_expand_symtabs_matching): Update.
1172         (dw2_debug_names_iterator): Add new constructor.
1173         (dw2_debug_names_map_matching_symbols): New function.
1174         (dw2_debug_names_expand_symtabs_matching): Update.
1175         (dwarf2_debug_names_functions): Use
1176         dw2_debug_names_map_matching_symbols.
1177
1178 2019-09-10  Tom Tromey  <tromey@adacore.com>
1179
1180         * dwarf2read.c (dw2_get_file_names_reader): Add the
1181         CU's file name to the results.
1182
1183 2019-09-10  Tom Tromey  <tromey@adacore.com>
1184
1185         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1186         map_matching_symbols.  Update.
1187         * dwarf2read.c (dw2_map_matching_symbols): Update.
1188         * psymtab.c (match_partial_symbol): Change type; update.
1189         (psym_map_matching_symbols): Likewise.
1190         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1191         type; update.
1192         * symfile.h (struct quick_symbol_functions)
1193         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1194         Remove "match".
1195
1196 2019-09-10  Tom Tromey  <tromey@adacore.com>
1197
1198         * psymtab.c (map_block): Remove.
1199         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1200         * symtab.c (iterate_over_symbols_terminated): New function.
1201         * symtab.c (iterate_over_symbols_terminated): Declare.
1202
1203 2019-09-10  Tom Tromey  <tromey@adacore.com>
1204
1205         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1206         * language.h (struct language_defn) <la_iterate_over_symbols>:
1207         Return bool.
1208         * symtab.c (iterate_over_symbols): Return bool.
1209         * symtab.h (iterate_over_symbols): Return bool.
1210
1211 2019-09-10  Tom Tromey  <tromey@adacore.com>
1212
1213         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1214         (add_nonlocal_symbols): Update.
1215         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1216         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1217         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1218         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1219         Change type of "callback".  Remove "data".
1220
1221
1222 2019-09-09  Ali Tamur  <tamur@google.com>
1223
1224         * dwarf2read.c (comp_unit_head): Update comment.
1225         (dwarf2_dwo_name): New function declaration.
1226         (dwarf_unit_type_name): New function declaration.
1227         (read_comp_unit_head): Add support for new compilation units,
1228         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1229         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1230         (currently named as "signature") in their header. Also clarify error
1231         messages.
1232         (lookup_dwo_id): New function. Returns the dwo id of the given
1233         compile unit.
1234         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1235         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1236         functions.
1237         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1238         (dwarf2_dwo_name): Get the dwo name if present.
1239         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1240         purposes.
1241
1242 2019-09-09  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1245
1246 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1247
1248         * python/python.c (do_start_initialization): Make progname_copy static,
1249         to avoid a leak report.
1250
1251 2019-09-08  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1254
1255 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1256
1257         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1258         Change type to gdb::optional<block_enum>.
1259         (dw2_symtab_iter_init): Change block_index parameter type
1260         to gdb::optional<block_enum>.
1261         (dw2_lookup_symbol): Change block_index parameter
1262         type to block_enum.c
1263         (dw2_debug_names_lookup_symbol): Likewise.
1264         * psymtab.c (psym_lookup_symbol): Likewise.
1265         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1266         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1267         Likewise.
1268
1269 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1270
1271         * defs.h (relocate_gdb_directory): Change int to bool in
1272         signature and rename flag to relocatable.
1273         * main.c (relocate_path): Likewise.
1274         (relocate_gdb_directory): Likewise.
1275
1276 2019-09-06  Alan Modra  <amodra@gmail.com>
1277
1278         * coffread.c (coff_symfile_read): Constify filename variable.
1279         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1280         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1281         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1282         * solib.c (reload_shared_libraries_1): Likewise.
1283         * symfile.c (reread_symbols): Likewise.
1284         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1285         * solib-darwin.c (darwin_bfd_open): Likewise.
1286         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1287
1288 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1291         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1292
1293 2019-09-03  Tom Tromey  <tromey@adacore.com>
1294
1295         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1296         types.
1297         (has_negatives): Unbias a range type bound.
1298         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1299         * gdbtypes.c (operator==): Handle new field.
1300         (create_range_type): Add "bias" parameter.
1301         (create_static_range_type, resolve_dynamic_range): Update.
1302         * gdbtypes.h (struct range_bounds) <bias>: New member.
1303         (create_range_type): Add bias parameter.
1304         * printcmd.c (print_scalar_formatted): Unbias range types.
1305         * value.c (unpack_long): Unbias range types.
1306         (pack_long): Bias range types.
1307
1308 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1309
1310         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1311         probe arguments.
1312
1313 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1314
1315         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1316         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1317         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1318         (compile_probe_arg): Likewise.
1319         * probe.h (get_argument_count): Likewise.
1320         * solib-svr4.c (solib_event_probe_action): Likewise.
1321         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1322
1323 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1324
1325         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1326         code to here...
1327         (svr4_create_solib_event_breakpoints): ...from here.
1328
1329 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1330
1331         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1332         suffix from warning message.
1333
1334 2019-08-30  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-winsource.h (struct tui_source_window_base)
1337         <refresh_all>: Don't declare.
1338         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1339         Remove.
1340         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1341         tui_show_locator_content.
1342         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1343         declare.
1344         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1345         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1346         declare.
1347
1348 2019-08-30  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1351
1352 2019-08-30  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1355         Remove unnecessary forward declarations.
1356
1357 2019-08-30  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1360         rerender.
1361         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1362         tui_show_locator_content.
1363
1364 2019-08-30  Tom Tromey  <tom@tromey.com>
1365
1366         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1367         (tui_locator_window::rerender): Rewrite using body of previous
1368         tui_show_locator_content.
1369
1370 2019-08-30  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1373         set_locator_fullname>: New methods.
1374         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1375         Rename from tui_set_locator_fullname.
1376         (tui_locator_window::set_locator_info): Rename from
1377         tui_set_locator_info.  Return bool.
1378         (tui_update_locator_fullname, tui_show_frame_info): Update.
1379
1380 2019-08-30  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1383
1384 2019-08-30  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1387         call touchwin.
1388
1389 2019-08-30  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-wingeneral.c (box_win): Assume win_info and
1392         win_info->handle cannot be NULL.
1393
1394 2019-08-30  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1397         refresh_window>: Declare.
1398         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1399         resize.
1400         (tui_data_item_window::rerender): Rename from
1401         tui_display_register.
1402         (tui_data_item_window::refresh_window): New method.
1403         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1404         no-op.
1405
1406 2019-08-30  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1409         regs_column_count, current_group>: Move later.  Now private.
1410         <get_current_group>: New method.
1411         * tui/tui-regs.c (tui_reg_command): Update.
1412         * tui/tui-layout.c (tui_set_layout): Update.
1413
1414 2019-08-30  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1417         (tui_data_window::rerender): Don't call
1418         check_and_display_highlight_if_needed.
1419         (tui_data_window::refresh_all): Remove call to
1420         erase_data_content.
1421
1422 2019-08-30  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1425         (tui_data_window::display_registers_from)
1426         (tui_data_window::display_reg_element_at_line)
1427         (tui_data_window::display_registers_from_line): Remove checks of
1428         "empty".
1429
1430 2019-08-30  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1433         Don't declare.
1434         * tui/tui-regs.c (tui_data_window::show_registers): Call
1435         rerender.
1436         (tui_data_window::rerender): Rename from display_all_data.
1437         (tui_data_window::rerender): Remove old implementation.
1438
1439 2019-08-30  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1442         text.
1443         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1444
1445 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1446             Sergio Durigan Junior  <sergiodj@redhat.com>
1447
1448         PR win32/24284
1449         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1450
1451 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1454         when searching for types.
1455
1456 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1457
1458         * f-lang.c (f_language_defn): Use f_print_typedef.
1459         * f-lang.h (f_print_typedef): Declare.
1460         * f-typeprint.c (f_print_typedef): Define.
1461
1462 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1463
1464         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1465
1466 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1467
1468         * cli/cli-utils.c (info_print_options_defs): Delete.
1469         (make_info_print_options_def_group): Delete.
1470         (extract_info_print_options): Delete.
1471         (info_print_command_completer): Delete.
1472         (info_print_args_help): Add extra parameter, and optionally
1473         include text about -n flag.
1474         * cli/cli-utils.h (struct info_print_options): Delete.
1475         (extract_info_print_options): Delete declaration.
1476         (info_print_command_completer): Delete declaration.
1477         (info_print_args_help): Add extra parameter, extend header
1478         comment.
1479         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1480         search_symbols.
1481         * stack.c (struct info_print_options): New type.
1482         (info_print_options_defs): New file scoped variable.
1483         (make_info_print_options_def_group): New static function.
1484         (info_print_command_completer): New static function.
1485         (info_locals_command): Update to use new local functions.
1486         (info_args_command): Likewise.
1487         (_initialize_stack): Add extra parameter to calls to
1488         info_print_args_help.
1489         * symtab.c (search_symbols): Add extra parameter, use this to
1490         possibly excluse non-debug symbols.
1491         (symtab_symbol_info): Add extra parameter, which is passed on to
1492         search_symbols.
1493         (struct info_print_options): New type.
1494         (info_print_options_defs): New file scoped variable.
1495         (make_info_print_options_def_group): New static function.
1496         (info_print_command_completer): New static function.
1497         (info_variables_command): Update to use local functions, and pass
1498         extra parameter through to symtab_symbol_info.
1499         (info_functions_command): Likewise.
1500         (info_types_command): Pass additional argument through to
1501         symtab_symbol_info.
1502         (rbreak_command): Pass extra argument to search_symbols.
1503         (_initialize_symtab): Add extra arguments for calls to
1504         info_print_args_help, and update help text for 'info variables',
1505         'whereis', and 'info functions' commands.
1506         * symtab.h (search_symbols): Add extra argument to declaration.
1507         * NEWS: Mention new flags.
1508
1509 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1510
1511         * symtab.c (lookup_static_symbol): Call the new function (and move
1512         it down to be next to lookup_global_symbol).
1513         (struct global_sym_lookup_data): Add block_enum member and rename to...
1514         (struct global_or_static_sym_lookup_data): ...this.
1515         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1516         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1517         (lookup_symbol_global_or_static_iterator_cb): ...this.
1518         (lookup_global_or_static_symbol): New function.
1519         (lookup_global_symbol): Call new function.
1520
1521 2019-08-26  Tom de Vries  <tdevries@suse.de>
1522
1523         PR c++/24852
1524         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1525         when pc_probe.prob == NULL.
1526
1527 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1528
1529         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1530         variable symbol_linkage to symbol_linkage_.
1531
1532 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1533
1534         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1535         represent whether the symbol is static, dynamic, or we don't
1536         know.
1537
1538 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1539
1540         * gdb/rx-tdep.c (rx_register_names): New.
1541         (rx_register_name): Delete.
1542         (rx_psw_type): Delete.
1543         (rx_fpsw_type): Delete.
1544         (rx_register_type): Delete.
1545         (rx_gdbarch_init): Convert target-descriptions.
1546         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1547         * gdb/features/Makefile: Add rx.xml.
1548         * gdb/features/rx.xml: New.
1549         * gdb/features/rx.c: Generated.
1550         * gdb/NEWS: Mention target description support.
1551
1552 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1553
1554         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1555         *slot_ptr.
1556
1557 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1558
1559         * configure.ac: Don't check for 'dlfcn.h' (moved to
1560         gdbsupport/common.m4).
1561         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1562         'gdbsupport/'.
1563         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1564         * compile/compile-c-support.c: Include
1565         'gdbsupport/gdb-dlfcn.h'.
1566         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1567         * gdb-dlfcn.c: Move to...
1568         * gdbsupport/gdb-dlfcn.c: ... here.
1569         * gdb-dlfcn.h: Move to...
1570         * gdbsupport/gdb-dlfcn.h: ... here.
1571
1572 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1573
1574         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1575         the offset field signed.
1576
1577 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1578
1579         * python/lib/gdb/__init__.py (_execute_file): New function.
1580         * python/python.c (python_run_simple_file): Call gdb._execute_file
1581         on Windows.
1582
1583 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1584
1585         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1586         all uses as this was never set to anything but a zero value.
1587
1588 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1589
1590         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1591
1592 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1593
1594         * tui/tui-data.h (tui_gen_win_info): Add an =default
1595         move constructor, required by some GCC versions.
1596
1597 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1598
1599         * go32-nat.c (go32_sysinfo): Add hygon_p.
1600
1601 2019-08-20  Tom Tromey  <tom@tromey.com>
1602
1603         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1604         line_from_reg_element_no, first_reg_element_no_inline,
1605         display_all_data, delete_data_content_windows,
1606         erase_data_content>: Now private.
1607
1608 2019-08-20  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1611         (tui_unhighlight_win, tui_highlight_win)
1612         (tui_win_info::make_window): Update.
1613         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1614
1615 2019-08-20  Tom Tromey  <tom@tromey.com>
1616
1617         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1618         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1619         (MAX_PID_WIDTH): Move to tui-stack.c.
1620         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1621         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1622         (MAX_PID_WIDTH): Move from tui-data.h.
1623
1624 2019-08-20  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1627         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1628         (box_win): Update.
1629         (tui_gen_win_info::make_window): Rename from tui_make_window.
1630         (tui_win_info::make_window): New method.
1631         (tui_gen_win_info::make_visible): Update.
1632         * tui/tui-source.c (tui_source_window::set_contents): Update.
1633         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1634         (tui_data_window::display_registers_from): Update.
1635         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1636         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1637         Declare.
1638         <can_box>: Remove.
1639         <title>: Remove.
1640         (struct tui_win_info) <make_window>: Declare.
1641         <can_box>: Now virtual.
1642         <title>: New member.
1643         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1644         * tui/tui-command.c (tui_cmd_window::resize): Update.
1645
1646 2019-08-20  Tom Tromey  <tom@tromey.com>
1647
1648         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1649         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1650         (tui_data_window::check_register_values): Update.
1651
1652 2019-08-20  Tom Tromey  <tom@tromey.com>
1653
1654         * tui/tui-regs.h (struct tui_data_window): Use
1655         DISABLE_COPY_AND_ASSIGN.
1656         <regs_content>: Change type, removing unique_ptr.
1657         <tui_data_window>: Add move constructor.
1658         * tui/tui-regs.c (tui_data_window::show_registers)
1659         (tui_data_window::show_register_group)
1660         (tui_data_window::display_registers_from)
1661         (tui_data_window::display_registers_from)
1662         (tui_data_window::first_data_item_displayed)
1663         (tui_data_window::delete_data_content_windows)
1664         (tui_data_window::rerender, tui_data_window::refresh_window)
1665         (tui_data_window::check_register_values): Update.
1666
1667 2019-08-20  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1670         show_register_group>: Declare.
1671         (tui_show_register_group): Don't declare.
1672         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1673         tui_show_registers.
1674         (tui_data_window::show_register_group): Rename from
1675         tui_show_register_group.
1676         (tui_data_window::check_register_values, tui_reg_command):
1677         Update.
1678         * tui/tui-layout.c (tui_set_layout): Update.
1679
1680 2019-08-20  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1683         Declare.
1684         (tui_check_register_values): Don't declare.
1685         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1686         from tui_check_register_values.
1687         * tui/tui-hooks.c (tui_register_changed): Update.
1688
1689 2019-08-20  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-regs.c (tui_reg_layout): Move later.
1692         (tui_show_registers): Don't enable TUI mode or change layout.
1693
1694 2019-08-20  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-regs.h (struct tui_data_item_window)
1697         <~tui_data_item_window>: Remove.
1698         <content>: Now a unique_xmalloc_ptr.
1699         * tui/tui-regs.c (tui_register_format): Return a
1700         unique_xmalloc_ptr.
1701         (tui_get_register): Update.
1702         (~tui_data_item_window): Remove.
1703         (tui_data_window::display_registers_from, tui_display_register):
1704         Update.
1705         * tui/tui-io.h (tui_expand_tabs): Update.
1706         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1707         Remove "col" parameter.
1708
1709 2019-08-20  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1712         field.
1713         * tui/tui-regs.c (~tui_data_item_window): Update.
1714
1715 2019-08-20  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1718         earlier.
1719
1720 2019-08-20  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1723
1724 2019-08-20  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-source.h (struct tui_source_window): Update.
1727         * tui/tui-regs.c (tui_show_registers): Update.
1728         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1729         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1730         (NO_REGS_STRING): Remove defines.
1731
1732 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1733
1734         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1735         unnecessary thread walk if remote doesn't support the packet.
1736
1737 2019-08-19  Tom Tromey  <tromey@adacore.com>
1738
1739         * python/py-value.c (value_has_field): Fix indentation.
1740
1741 2019-08-19  Tom Tromey  <tromey@adacore.com>
1742
1743         * printcmd.c (do_one_display, info_display_command): Update.
1744         * block.h (contained_in): Return bool.  Add allow_nested
1745         parameter.
1746         * block.c (contained_in): Return bool.  Add allow_nested
1747         parameter.
1748
1749 2019-08-19  Tom Tromey  <tom@tromey.com>
1750
1751         * configure: Rebuild.
1752         * configure.ac: Disallow the combination of -static-libstdc++ and
1753         source highlight.
1754         * source-cache.c (get_language_name): Handle rust.
1755         (source_cache::get_source_lines): Ignore highlighting exceptions.
1756
1757 2019-08-16  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1760         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1761         (struct tui_source_window_base) <make_visible, refresh_window,
1762         resize>: Remove methods.
1763         <execution_info>: Remove field.
1764         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1765         (tui_show_source_line, tui_source_window_base)
1766         (~tui_source_window_base): Update.
1767         (tui_source_window_base::resize)
1768         (tui_source_window_base::make_visible)
1769         (tui_source_window_base::refresh_window): Remove.
1770         (tui_source_window_base::update_exec_info): Update.
1771         * tui/tui-source.c (tui_source_window::set_contents): Update.
1772         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1773
1774 2019-08-16  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1777         deprecated_query_hook.
1778
1779 2019-08-16  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1782         (tui_update_source_windows_with_line): Update.
1783         * tui/tui-source.h (struct tui_source_window)
1784         <show_symtab_source>: Declare.
1785         (tui_show_symtab_source): Don't declare.
1786         * tui/tui-source.c (tui_show_symtab_source): Rename from
1787         tui_show_symtab_source.
1788
1789 2019-08-16  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-winsource.h (struct tui_source_window_base)
1792         <set_contents>: Declare.
1793         * tui/tui-winsource.c
1794         (tui_source_window_base::update_source_window_as_is): Update.
1795         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1796         Declare.
1797         (tui_set_source_content): Don't declare.
1798         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1799         tui_set_source_content.
1800         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1801         Declare.
1802         (tui_set_disassem_content): Don't declare.
1803         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1804         tui_set_disassem_content.
1805
1806 2019-08-16  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-winsource.h (struct tui_source_window_base)
1809         <update_breakpoint_info>: Declare.
1810         (tui_update_breakpoint_info): Don't declare.
1811         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1812         (tui_update_all_breakpoint_info): Update.
1813         (tui_source_window_base::update_breakpoint_info): Rename from
1814         tui_update_breakpoint_info.
1815         (tui_source_window_base::update_exec_info): Update.
1816
1817 2019-08-16  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-winsource.h (struct tui_source_window_base)
1820         <update_source_window>: Declare.
1821         (tui_update_source_window): Don't declare.
1822         * tui/tui-winsource.c
1823         (tui_source_window_base::update_source_window): Rename from
1824         tui_update_source_window.
1825         (tui_source_window_base::rerender): Update.
1826         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1827         * tui/tui-disasm.c (tui_show_disassem)
1828         (tui_show_disassem_and_update_source)
1829         (tui_disasm_window::maybe_update): Update.
1830
1831 2019-08-16  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-winsource.h (struct tui_source_window_base)
1834         <update_source_window_as_is>: Declare.
1835         (tui_update_source_window_as_is): Don't declare.
1836         * tui/tui-winsource.c (tui_update_source_window): Update
1837         (tui_source_window_base::update_source_window_as_is): Rename from
1838         tui_update_source_window_as_is.
1839         (tui_source_window_base::refill): Update.
1840         * tui/tui-source.c (tui_show_symtab_source): Update.
1841         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1842         Update.
1843
1844 2019-08-16  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-winsource.h (tui_update_source_window)
1847         (tui_update_source_window_as_is): Remove "noerror" parameter.
1848         * tui/tui-winsource.c (tui_update_source_window)
1849         (tui_update_source_window_as_is): Remove "noerror" parameter.
1850         (tui_update_source_windows_with_addr)
1851         (tui_update_source_windows_with_line)
1852         (tui_source_window_base::rerender)
1853         (tui_source_window_base::refill): Update.
1854         * tui/tui-source.h (tui_set_source_content)
1855         (tui_show_symtab_source): Remove "noerror" parameter.
1856         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1857         parameter.
1858         (tui_show_symtab_source): Likewise.
1859         (tui_source_window::maybe_update): Update.
1860         * tui/tui-disasm.c (tui_show_disassem)
1861         (tui_show_disassem_and_update_source)
1862         (tui_disasm_window::do_scroll_vertical)
1863         (tui_disasm_window::maybe_update): Update.
1864
1865 2019-08-16  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui.c (tui_is_window_visible): Update.
1868         * tui/tui-wingeneral.c (tui_make_window)
1869         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1870         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1871         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1872         (tui_set_win_height_command, parse_scrolling_args): Update.
1873         * tui/tui-source.c (tui_source_window::style_changed): Update.
1874         * tui/tui-regs.c (tui_show_registers)
1875         (tui_data_window::first_data_item_displayed)
1876         (tui_data_window::delete_data_content_windows)
1877         (tui_check_register_values, tui_reg_command): Update.
1878         * tui/tui-disasm.c (tui_show_disassem): Update.
1879         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1880         method.
1881         <is_visible>: Remove field.
1882         * tui/tui-data.c (tui_next_win, tui_prev_win)
1883         (tui_delete_invisible_windows): Update.
1884
1885 2019-08-16  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-winsource.h (struct tui_source_window_base)
1888         <m_has_locator>: Remove.
1889         * tui/tui-layout.c (show_source_disasm_command, show_data)
1890         (show_source_or_disasm_and_command): Update.
1891
1892 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1893
1894         * NEWS (Other MI changes): New subsection.
1895         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1896         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1897         * arch-utils.c (default_get_pc_address_flags): New function.
1898         * arch-utils.h (default_get_pc_address_flags): New declaration.
1899         * gdbarch.sh: Add get_pc_address_flags.
1900         * gdbarch.c: Regenerate.
1901         * gdbarch.h: Likewise.
1902         * stack.c (print_pc): New function.
1903         (print_frame_info) (print_frame): Call print_pc.
1904
1905 2019-08-16  Tom de Vries  <tdevries@suse.de>
1906
1907         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1908         print_objfile_section_info.
1909
1910 2019-08-15  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1913         calling update_cmdwin_start_line.
1914         * tui/tui-winsource.h (struct tui_source_window_base)
1915         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1916         <rerender>: Declare.
1917         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1918         Call rerender.
1919         (tui_source_window_base::set_new_height): Remove.
1920         (tui_source_window_base::rerender): Rename from
1921         do_make_visible_with_new_height.
1922         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1923         resize method.
1924         (tui_win_info::make_invisible_and_set_new_height)
1925         (tui_win_info::make_visible_with_new_height): Remove.
1926         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1927         Declare.
1928         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1929         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1930         do_make_visible_with_new_height>: Don't declare.
1931         <rerender>: Declare.
1932         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1933         set_new_height.
1934         (tui_data_window::do_make_visible_with_new_height): Remove.
1935         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1936         call tui_show_locator_content.
1937         (tui_gen_win_info::resize): Call rerender.
1938         (show_source_or_disasm_and_command): Don't call
1939         tui_show_locator_content.
1940         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1941         method.
1942         (struct tui_win_info) <rerender>: Declare.
1943         <set_new_height, make_invisible_and_set_new_height,
1944         make_visible_with_new_height>: Don't declare.
1945         * tui/tui-data.c (tui_win_list::rerender): New method.
1946         * tui/tui-command.h (struct tui_cmd_window)
1947         <do_make_visible_with_new_height>: Don't declare.
1948         * tui/tui-command.c
1949         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1950
1951 2019-08-15  Tom Tromey  <tromey@adacore.com>
1952
1953         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1954         * ada-lang.c (ada_enum_name): Likewise.
1955
1956 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1957
1958         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1959         leading underscore.
1960         (GdbOutputErrorFile): Likewise.
1961         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1962         accordingly.
1963         (execute_unwinders): Rename to have a leading underscore.
1964         (auto_load_packages): Likewise.
1965         (global scope): Adjust call to auto_load_packages accordingly.
1966         (GdbSetPythonDirectory): Likewise.
1967         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1968         instead of execute_unwinders.
1969
1970 2019-08-15  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1973         (show_data): Don't change window visibility.
1974         (tui_gen_win_info::resize): Remove special case for command
1975         window.  Use wresize, when available.
1976         (show_source_or_disasm_and_command): Don't change window
1977         visibility.
1978         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1979         <make_visible>: New method.
1980         * tui/tui-command.c (tui_cmd_window::resize): New method.
1981
1982 2019-08-15  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1985         (struct tui_source_windows): New.
1986         * tui/tui-winsource.c (tui_display_main): Update.
1987         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1988         (new_height_ok, parse_scrolling_args): Update.
1989         * tui/tui-layout.c (show_layout, show_data): Update.
1990         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1991         (tui_add_to_source_windows): Don't declare.
1992         * tui/tui-data.c (source_windows, tui_source_windows)
1993         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1994
1995 2019-08-15  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1998         Rename from reset.
1999         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2000         * tui/tui-layout.c (show_source_disasm_command, show_data):
2001         Update.
2002         (tui_gen_win_info::resize): Rename.
2003         (show_source_or_disasm_and_command): Update.
2004         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2005         reset.
2006
2007 2019-08-15  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2010         * tui/tui-interp.c (tui_interp::init): Don't call
2011         tui_initialize_static_data.
2012         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2013
2014 2019-08-15  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2017         examine tui_win_list.
2018
2019 2019-08-15  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2022         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2023         tui_clear_source_content.
2024         (tui_clear_source_content): Remove.
2025         (tui_source_window_base::do_erase_source_content): Hoist call to
2026         content.clear().
2027         * tui/tui-stack.c (tui_show_frame_info): Don't call
2028         tui_clear_source_content.
2029
2030 2019-08-15  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-winsource.h (struct tui_source_window_base)
2033         <do_erase_source_content>: New method.
2034         <erase_source_content>: New method.
2035         (tui_erase_source_content): Don't declare.
2036         * tui/tui-winsource.c (tui_clear_source_content): Update.
2037         (tui_source_window_base::do_erase_source_content): Rename from
2038         tui_erase_source_content.
2039         (tui_source_window_base::show_source_content): Update.
2040         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2041         * tui/tui-source.h (struct tui_source_window)
2042         <erase_source_content>: New method.
2043         * tui/tui-disasm.h (struct tui_disasm_window)
2044         <erase_source_content>: New method.
2045
2046 2019-08-15  Tom Tromey  <tom@tromey.com>
2047
2048         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2049         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2050         constructor.
2051         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2052         * tui/tui-source.c (tui_set_source_content): Update.
2053         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2054
2055 2019-08-15  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2058         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2059         tui-source.c.
2060         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2061         Declare.
2062         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2063         method.
2064         (tui_source_window::maybe_update): Update.
2065
2066 2019-08-15  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2069         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2070         tui-disasm.c.
2071         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2072         Declare.
2073         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2074         method.
2075         (tui_disasm_window::maybe_update): Update.
2076
2077 2019-08-15  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-winsource.h (struct tui_source_window_base)
2080         <maybe_update>: Declare.
2081         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2082         method.
2083         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2084         Declare.
2085         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2086         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2087         Declare.
2088         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2089
2090 2019-08-15  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2093
2094 2019-08-15  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-wingeneral.c: Include tui-stack.h.
2097         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2098         (struct tui_locator_window): Move from tui-data.h.
2099         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2100         (tui_initialize_static_data): Move from tui-data.c.
2101         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2102         (struct tui_locator_window): Move to tui-stack.c.
2103         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2104         (tui_initialize_static_data): Move to tui-stack.c.
2105
2106 2019-08-15  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-layout.c (show_source_disasm_command)
2109         (show_source_or_disasm_and_command): Use make_visible method, not
2110         tui_make_window.
2111         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2112         Remove.
2113
2114 2019-08-15  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-wingeneral.h (tui_make_window): Update.
2117         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2118         parameter.
2119         (tui_gen_win_info::make_visible): Update.
2120         * tui/tui-regs.c (tui_data_window::display_registers_from):
2121         Update.
2122         * tui/tui-layout.c (show_source_disasm_command)
2123         (show_source_or_disasm_and_command): Update.
2124         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2125         (enum tui_box): Remove.
2126         (struct tui_win_info) <can_box>: New method.
2127         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2128         method.
2129
2130 2019-08-15  Tom de Vries  <tdevries@suse.de>
2131
2132         * linux-nat-trad.c: Include gdbarch.h.
2133
2134 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2135
2136         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2137         register sizes.
2138
2139 2019-08-14  Tom Tromey  <tromey@adacore.com>
2140
2141         * darwin-nat.c: Include gdbarch.h.
2142         * darwin-nat-info.c: Include gdbarch.h.
2143
2144 2019-08-13  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2147         Remove.
2148         * tui/tui-data.c (tui_initialize_static_data): Update.
2149
2150 2019-08-13  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-winsource.h (struct tui_exec_info_window)
2153         <~tui_exec_info_window, maybe_allocate_content, get_content,
2154         m_content>: Remove.
2155         (struct tui_source_window_base) <set_exec_info_content,
2156         show_exec_info_content>: Don't declare.
2157         * tui/tui-winsource.c
2158         (tui_exec_info_window::maybe_allocate_content): Remove.
2159         (tui_source_window_base::update_exec_info): Rename from
2160         set_exec_info_content.
2161         (tui_source_window_base::show_exec_info_content)
2162         (tui_source_window_base::update_exec_info): Remove.
2163
2164 2019-08-13  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2167         declare.
2168         * tui/tui-winsource.c (tui_update_source_window_as_is)
2169         (tui_update_source_windows_with_addr, tui_erase_source_content):
2170         Update.
2171         (tui_clear_exec_info_content): Remove.
2172
2173 2019-08-13  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2176         declare.
2177         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2178         call tui_erase_exec_info_content.
2179         (tui_clear_exec_info_content): Rename from
2180         tui_erase_exec_info_content.
2181         (tui_clear_exec_info_content): Delete.
2182
2183 2019-08-13  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-winsource.h (struct tui_source_window_base)
2186         <show_exec_info_content>: Declare.
2187         (tui_show_exec_info_content): Don't declare.
2188         * tui/tui-winsource.c
2189         (tui_source_window_base::show_exec_info_content): Rename from
2190         tui_show_exec_info_content.
2191         (tui_source_window_base::update_exec_info): Update.
2192
2193 2019-08-13  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2196         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2197         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2198         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2199         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2200         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2201         ... here.
2202
2203 2019-08-13  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-winsource.h (struct tui_source_window_base)
2206         <update_exec_info>: Declare.
2207         (tui_update_exec_info): Don't declare.
2208         * tui/tui-winsource.c (tui_update_source_window_as_is)
2209         (tui_source_window_base::refresh_all)
2210         (tui_update_all_breakpoint_info): Update.
2211         (tui_source_window_base::update_exec_info): Rename from
2212         tui_update_exec_info.
2213         * tui/tui-stack.c (tui_show_frame_info): Update.
2214
2215 2019-08-13  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-winsource.h (struct tui_source_window_base)
2218         <set_exec_info_content>: Declare.
2219         (tui_set_exec_info_content): Don't declare.
2220         * tui/tui-winsource.c
2221         (tui_source_window_base::set_exec_info_content): Rename from
2222         tui_set_exec_info_content.
2223         (tui_update_exec_info): Update.
2224
2225 2019-08-13  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-winsource.h (struct tui_source_window_base)
2228         <show_source_content>: Declare.
2229         (tui_show_source_content): Don't declare.
2230         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2231         (tui_source_window_base::show_source_content): Rename from
2232         tui_show_source_content.
2233         (tui_source_window_base::refresh_all): Update.
2234         * tui/tui-layout.c (show_source_disasm_command)
2235         (show_source_or_disasm_and_command): Update.
2236
2237 2019-08-13  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-winsource.c (tui_erase_source_content)
2240         (tui_show_source_content, tui_source_window_base::refresh_all):
2241         Update.
2242         * tui/tui-wingeneral.h
2243         (tui_check_and_display_highlight_if_needed): Don't declare.
2244         * tui/tui-wingeneral.c
2245         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2246         check_and_display_highlight_if_needed.
2247         * tui/tui-win.c (tui_rehighlight_all)
2248         (tui_win_info::make_visible_with_new_height): Update.
2249         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2250         (tui_data_window::erase_data_content)
2251         (tui_data_window::display_all_data): Update.
2252         * tui/tui-data.h (struct tui_win_info)
2253         <check_and_display_highlight_if_needed>: Declare.
2254
2255 2019-08-13  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-win.c (tui_resize_all): Call
2258         tui_delete_invisible_windows.
2259         * tui/tui-layout.c (show_layout): Call
2260         tui_delete_invisible_windows.
2261         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2262         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2263
2264 2019-08-13  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2267         tui_add_win_to_layout.
2268
2269 2019-08-13  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2272         * tui/tui-layout.c (tui_default_win_height): Now static.
2273
2274 2019-08-13  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2277         single switch.
2278         (show_source_disasm_command, show_source_or_disasm_and_command):
2279         Don't check current layout.
2280
2281 2019-08-13  Tom Tromey  <tom@tromey.com>
2282
2283         * tui/tui-wingeneral.c (make_all_visible): Remove.
2284         (tui_make_all_invisible): Simplify.
2285         * tui/tui-layout.c (tui_make_all_invisible): Move from
2286         tui-wingeneral.c; simplify.
2287         (show_layout): Hoist call to tui_make_all_invisible.
2288         (show_data): Don't call tui_make_all_invisible.
2289
2290 2019-08-13  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2293         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2294
2295 2019-08-13  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2298         tui-data.c.
2299         (show_source_disasm_command, show_data)
2300         (show_source_or_disasm_and_command): Don't use
2301         tui_set_current_layout_to.
2302         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2303         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2304         tui-layout.c.
2305         (tui_set_current_layout_to): Remove.
2306
2307 2019-08-13  Tom Tromey  <tom@tromey.com>
2308
2309         * tui/tui-layout.c (tui_set_layout): Update.
2310         * tui/tui-data.h (struct tui_layout_def): Remove.
2311         (tui_layout_def): Don't declare.
2312         * tui/tui-data.c (layout_def): Remove.
2313         (tui_layout_def): Remove.
2314
2315 2019-08-13  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-winsource.h (struct tui_source_window_base)
2318         <clear_detail>: No longer "override".
2319         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2320         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2321         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2322         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2323         Remove.
2324         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2325
2326 2019-08-13  Tom Tromey  <tromey@adacore.com>
2327
2328         * tracepoint.c: Don't include readline.h or history.h.
2329
2330 2019-08-12  Tom Tromey  <tom@tromey.com>
2331
2332         * configure: Rebuild.
2333         * configure.ac: Check for readline 7.
2334         * NEWS: Mention readline 7 requirement.
2335         * README: Update.
2336
2337 2019-08-12  Tom Tromey  <tom@tromey.com>
2338
2339         * mingw-hdep.c (gdb_select): Remove readline hack.
2340
2341 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2342
2343         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2344         when the function fails.
2345
2346 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2347
2348         * s390-tdep.c (s390_type_align): New function.
2349         (s390_gdbarch_init): Set it as type_align gdbarch method.
2350
2351 2019-08-09  Tom de Vries  <tdevries@suse.de>
2352
2353         PR gdb/24591
2354         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2355         pc_low with relocation offset.
2356
2357 2019-08-07  Tom Tromey  <tromey@adacore.com>
2358
2359         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2360         (print_frame_args): Update.
2361         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2362         Update.
2363         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2364         * frame.h (struct frame_arg): Add initializers.
2365         <error>: Now a unique_xmalloc_ptr.
2366
2367 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2368
2369         * NEWS: Expand the Pointer Authentication entry.
2370         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2371         (aarch64_frame_unmask_lr): ... to this.
2372         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2373         Call aarch64_frame_unmask_lr.
2374         * frame.c (struct frame_info): Add "masked" variable.
2375         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2376         (fprint_frame): Check for masked pc.
2377         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2378         declarations.
2379         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2380         * stack.c (print_frame): Check for masked pc.
2381
2382 2019-08-06  Tom Tromey  <tom@tromey.com>
2383
2384         * stabsread.c (patch_block_stabs, read_one_struct_field)
2385         (read_enum_type): Use obstack_strndup.
2386         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2387         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2388         * dwarf2read.c (guess_full_die_structure_name)
2389         (anonymous_struct_prefix): Use obstack_strndup.
2390         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2391         * c-exp.y (yylex): Use obstack_strndup.
2392         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2393         (write_var_or_type): Use obstack_strndup.
2394
2395 2019-08-06  Tom Tromey  <tom@tromey.com>
2396
2397         * symfile.c (reread_symbols): Use obstack_strdup.
2398         * stabsread.c (read_type): Use obstack_strdup.
2399         * gdb_obstack.h (obstack_strdup): New overload.
2400         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2401         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2402         (dwarf2_canonicalize_name): Use obstack_strdup.
2403         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2404         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2405         Use obstack_strdup.
2406
2407 2019-08-06  Tom Tromey  <tom@tromey.com>
2408
2409         * gdb_obstack.h (obstack_strdup): Define.
2410         * gdb_obstack.c (obstack_strdup): Don't define.
2411
2412 2019-08-06  Tom Tromey  <tom@tromey.com>
2413
2414         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2415         obstack_strdup.
2416         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2417         obstack_strdup.
2418         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2419         * stabsread.c (common_block_start): Use obstack_strdup.
2420         * objfiles.c (set_objfile_main_name, objfile): Use
2421         obstack_strdup.
2422         * namespace.c (add_using_directive): Use obstack_strdup.
2423         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2424         * jit.c (finalize_symtab): Use obstack_strdup.
2425         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2426         (guess_partial_die_structure_name, partial_die_info::fixup)
2427         (dwarf2_name): Use obstack_strdup.
2428         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2429         obstack_strdup.
2430         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2431         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2432         obstack_strdup.
2433         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2434
2435 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2436
2437         * unittests/help-doc-selftests.c: New file.
2438         * Makefile.in: Add the new file.
2439
2440 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2441
2442         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2443         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2444         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2445         the trailing '.' is not output, and the first character is uppercased.
2446         (print_help_for_command): Update call to print_doc_line.
2447         (print_doc_of_command): Likewise.
2448         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2449         * cli/cli-option.c (append_indented_doc): Do not append newline.
2450         (build_help_option): Append newline after first appended_indented_doc
2451         only if a second call is done.
2452         (build_help): Append 2 new lines before each option, except the first
2453         one.
2454         * compile/compile.c (_initialize_compile): Add new lines after
2455         %OPTIONS%, when not at the end of the help.
2456         Change help doc or code
2457         producing the help doc to respect the invariants.
2458         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2459         Also removed the new line after 'Options:', as all other commands
2460         do not put an empty line between 'Options:' and the first option.
2461         * printcmd.c (_initialize_printcmd): Likewise.
2462         * stack.c (_initialize_stack): Likewise.
2463         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2464         incorrectly telling COMMAND is optional.
2465         * ada-lang.c (_initialize_ada_language): Change help doc or code
2466         producing the help doc to respect the invariants.
2467         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2468         * breakpoint.c (_initialize_breakpoint): Likewise.
2469         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2470         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2471         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2472         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2473         _initialize_cli_style): Likewise.
2474         * corelow.c (core_target_info): Likewise.
2475         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2476         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2477         * filesystem.c (_initialize_filesystem): Likewise.
2478         * frame.c (_initialize_frame): Likewise.
2479         * gnu-nat.c (add_task_commands): Likewise.
2480         * infcall.c (_initialize_infcall): Likewise.
2481         * infcmd.c (_initialize_infcmd): Likewise.
2482         * interps.c (_initialize_interpreter): Likewise.
2483         * language.c (_initialize_language): Likewise.
2484         * linux-fork.c (_initialize_linux_fork): Likewise.
2485         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2486         * maint.c (_initialize_maint_cmds): Likewise.
2487         * memattr.c (_initialize_mem): Likewise.
2488         * printcmd.c (_initialize_printcmd): Likewise.
2489         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2490         _RegEx): Likewise.
2491         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2492         * record-btrace.c (_initialize_record_btrace): Likewise.
2493         * record-full.c (_initialize_record_full): Likewise.
2494         * record.c (_initialize_record): Likewise.
2495         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2496         * regcache.c (_initialize_regcache): Likewise.
2497         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2498         _initialize_remote): Likewise.
2499         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2500         * serial.c (_initialize_serial): Likewise.
2501         * skip.c (_initialize_step_skip): Likewise.
2502         * source.c (_initialize_source): Likewise.
2503         * stack.c (_initialize_stack): Likewise.
2504         * symfile.c (_initialize_symfile): Likewise.
2505         * symtab.c (_initialize_symtab): Likewise.
2506         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2507         * top.c (init_main): Likewise.
2508         * tracefile-tfile.c (tfile_target_info): Likewise.
2509         * tracepoint.c (_initialize_tracepoint): Likewise.
2510         * tui/tui-win.c (_initialize_tui_win): Likewise.
2511         * utils.c (add_internal_problem_command): Likewise.
2512         * valprint.c (value_print_option_defs): Likewise.
2513
2514 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2515
2516         PR build/24886
2517         * configure.ac: Drop enable-libmcheck support.
2518         * configure, config.in: Rebuild.
2519         * libmcheck.m4: Remove.
2520         * acinclude.m4: Don't include it.
2521         * Makefile.in: Don't distribute it.
2522         * top.c (print_gdb_configuration): Don't mention it.
2523
2524 2019-08-06  Tom Tromey  <tom@tromey.com>
2525
2526         * utils.c (set_output_style): Sometimes pass stream to
2527         emit_style_escape.
2528         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2529         * record-btrace.c (btrace_insn_history): Update.
2530         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2531         method.
2532         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2533         Update initializers.
2534         <m_uiout>: New field.
2535         <m_di>: Move lower.
2536         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2537         Remove "uiout" parameter.
2538         (dump_insns): Update.
2539         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2540         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2541
2542 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2543
2544         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2545         (error_in_psymtab_expansion): Likewise.
2546         (lookup_symbol_via_quick_fns): Likewise.
2547         (basic_lookup_transparent_type_quick): Likewise.
2548         (basic_lookup_transparent_type_1): Likewise.
2549
2550 2019-08-06  Tom Tromey  <tromey@adacore.com>
2551
2552         * source.c (last_source_error): Now bool.
2553         (print_source_lines_base): Make "noprint" bool.  Only open
2554         source file when last_source_visited changes.
2555
2556 2019-08-06  Tom Tromey  <tromey@adacore.com>
2557
2558         * annotate.c (annotate_source_line): Use g_source_cache.
2559         * source-cache.c (source_cache::get_plain_source_lines): Change
2560         parameters.  Populate m_offset_cache.
2561         (source_cache::ensure): New method.
2562         (source_cache::get_line_charpos): New method.
2563         (extract_lines): Move lower.  Change parameters.
2564         (source_cache::get_source_lines): Move lower.
2565         * source-cache.h (class source_cache): Update comment.
2566         <get_line_charpos>: New method.
2567         <get_source_lines>: Update comment.
2568         <clear>: Clear m_offset_cache.
2569         <get_plain_source_lines>: Change parameters.
2570         <ensure>: New method
2571         <m_offset_cache>: New member.
2572         * source.c (forget_cached_source_info_for_objfile): Update.
2573         (info_source_command): Use g_source_cache.
2574         (find_source_lines, open_source_file_with_line_charpos): Remove.
2575         (print_source_lines_base, search_command_helper): Use g_source_cache.
2576         * source.h (open_source_file_with_line_charpos): Don't declare.
2577         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2578         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2579         Use g_source_cache.
2580
2581 2019-08-06  Tom Tromey  <tromey@adacore.com>
2582
2583         * source-cache.c (source_cache::get_plain_source_lines):
2584         Remove "first_line" and "last_line" parameters.
2585         (source_cache::get_source_lines): Cache plain text.
2586         * source-cache.h (class source_cache)
2587         <get_plain_source_lines>: Update.
2588
2589 2019-08-06  Tom Tromey  <tromey@adacore.com>
2590
2591         * source-cache.c (extract_lines): No longer a method.
2592         Changed type of parameter.  Include final newline.
2593         (selftests::extract_lines_test): New function.
2594         (_initialize_source_cache): Likewise.
2595         * source-cache.h (class source_cache)
2596         <extract_lines>: Don't declare.
2597
2598 2019-08-06  Tom Tromey  <tromey@adacore.com>
2599
2600         * breakpoint.c (init_breakpoint_sal): Update.
2601         (breakpoint): Update.
2602         * breakpoint.h (struct breakpoint) <filter>: Now a
2603         unique_xmalloc_ptr.
2604
2605 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2606
2607         * NEWS: Mention dictionary access on blocks.
2608         * python/py-block.c (blpy_getitem): New function.
2609         (block_object_as_mapping): New struct.
2610         (block_object_type): Use new struct for tp_as_mapping field.
2611
2612 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2613
2614         * objfiles.h (objfile): Add a comment describing partial symbols.
2615
2616 2019-08-05  Tom Tromey  <tromey@adacore.com>
2617
2618         * compile/compile.c (_initialize_compile): Use _(), not N_().
2619         * thread.c (_initialize_thread): Use _(), not N_().
2620         * stack.c (_initialize_stack): Use _(), not N_().
2621         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2622
2623 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2624
2625         * dwarf2read.c (struct dw2_symtab_iterator):
2626         <want_specific_block>: Remove.
2627         <block_index>: Change type to gdb::optional.
2628         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2629         change type of BLOCK_INDEX parameter to gdb::optional.
2630         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2631         (dw2_lookup_symbol): Don't pass argument for
2632         WANT_SPECIFIC_BLOCK.
2633         (dw2_expand_symtabs_for_function): Don't pass argument for
2634         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2635         (class dw2_debug_names_iterator)
2636         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2637         parameter, change BLOCK_INDEX type to gdb::optional.
2638         <m_want_specific_block>: Remove.
2639         <m_block_index>: Change type to gdb::optional.
2640         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2641         gdb::optional.  Re-write in function of gdb::optional.
2642         (dw2_debug_names_lookup_symbol): Don't pass argument for
2643         WANT_SPECIFIC_BLOCK.
2644         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2645         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2646         BLOCK_INDEX.
2647
2648 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2649
2650         * NEWS: Mention changes to "info sources" command.
2651
2652 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2653
2654         * symtab.c (filename_partial_match_opts): New struct type.
2655         (struct output_source_filename_data): New members
2656         regexp, c_regexp, partial_match.
2657         (output_source_filename): Use new members to decide to print file.
2658         (info_sources_option_defs): New variable.
2659         (make_info_sources_options_def_group, print_info_sources_header,
2660         info_sources_command_completer):
2661         New functions.
2662         (info_sources_command): Read new optional arguments.
2663         (_initialize_symtab): Update info sources help.
2664
2665 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2666
2667         * ada-lang.c (exception_support_info_v0): Renamed from...
2668         (default_exception_support_info): ... this.  Create new
2669         definition for v1.
2670         (ada_has_this_exception_support): Look up catch_handlers_sym.
2671         (ada_exception_support_info_sniffer): Try v0 after default.
2672
2673 2019-08-01  Tom Tromey  <tromey@adacore.com>
2674
2675         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2676         gdbarch.h.
2677
2678 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2679
2680         * s12z-tdep.c: Fix include path for s12z-opc.h.
2681
2682 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2683
2684         * NEWS: Require GNU make 3.82.
2685
2686 2019-07-16  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2689         declare.
2690
2691 2019-07-30  Tom Tromey  <tromey@adacore.com>
2692
2693         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2694
2695 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2696
2697         * printcmd.c (print_address_symbolic): Print negative offsets.
2698         (build_address_symbolic): Force signed arithmetic when computing
2699         offset.
2700
2701 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2702
2703         PR/24474: Add a function to lookup static variables.
2704         * NEWS: Mention this new function.
2705         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2706         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2707         * python/python.c (python_GdbMethods): Add new function.
2708
2709 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2710
2711         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2712         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2713         (objfpy_lookup_static_symbol): New function.
2714         (objfile_object_methods): Add new functions.
2715
2716 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2717
2718         * NEWS: Mention 'set|show print frame-info'.  Mention new
2719         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2720         backtrace argument.  Mention that python frame filtering code
2721         is now consistent with what 'backtrace' command prints.
2722
2723 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2724
2725         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2726         comments.
2727         (print_frame_info_auto, print_frame_info_source_line,
2728         print_frame_info_location, print_frame_info_source_and_location,
2729         print_frame_info_location_and_address, print_frame_info_short_location):
2730         New declarations.
2731         (struct frame_print_options): New member print_frame_info.
2732         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2733         * stack.h (get_user_print_what_frame_info): New declaration.
2734         (frame_show_address): New declaration.
2735         * stack.c (print_frame_arguments_choices): New value 'presence'.
2736         (print_frame_info_auto, print_frame_info_source_line,
2737         print_frame_info_location, print_frame_info_source_and_location,
2738         print_frame_info_location_and_address, print_frame_info_short_location,
2739         print_frame_info_choices, print_frame_info_print_what): New definitions.
2740         (print_frame_args): Only print dots for args if print frame-arguments
2741         is 'presence'.
2742         (frame_print_option_defs): New element for "frame-info".
2743         (get_user_print_what_frame_info): New function.
2744         (frame_show_address): Make non static.  Move comment to stack.h.
2745         (print_frame_info_to_print_what): New function.
2746         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2747         to decide what to print.
2748         (backtrace_command_1): Handle the new print_frame_arguments_presence
2749         value.
2750         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2751         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2752         (py_print_frame): In non-mi mode, use LOCATION as default for
2753         print_what, similarly to frame information printed directly by
2754         backtrace command. Handle frame-info user option in non MI mode.
2755
2756 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2757
2758         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2759         Add case for debugging 32-bit target on 64-bit host.  Revise
2760         comment.
2761
2762 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2763
2764         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2765         instead of find_function_entry_range_from_pc.
2766
2767 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2768
2769         * stack.c (find_frame_funname): Remove code which preferred
2770         minsym over symtab sym in "certain pathological cases".
2771
2772         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2773         parameter.  Change type of "do_demangle" to bool.
2774         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2775         Pass suitable "prefer_sym_over_minsym" flag to
2776         build_address_symbolic().  Don't output "+" for negative offsets.
2777         * printcmd.c (print_address_symbolic): Update invocation of
2778         build_address_symbolic to include a "prefer_sym_over_minsym"
2779         flag.
2780         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2781         Restrict cases in which use of minimal symbol is preferred to that
2782         of a found symbol.  Update comments.
2783
2784         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2785         for entry pc when entry pc is out of range for that FDE.
2786
2787 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2788
2789         PR gdb/24839:
2790         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2791         type.
2792
2793 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2794
2795         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2796         this function's Python signature.
2797
2798
2799 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2800
2801         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2802         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2803         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2804         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2805         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2806
2807
2808 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2809
2810         * h8300-tdep.c (h8300_register_name_common): New.
2811         h8300_register_name): Use h8300_register_name_common.
2812         (h8300s_register_name): Likewise.
2813         (h8300sx_register_name): Likewise.
2814         (h8300h_register_nam): New.
2815         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2816
2817
2818 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2819
2820         * arm-tdep.c (arm_skip_cmse_entry): New function.
2821         (arm_is_sgstubs_section): New function.
2822         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2823
2824 2019-07-22  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2827         Don't self-assign.
2828
2829 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2830
2831         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2832         type_print.
2833
2834 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2835
2836         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2837         so that GDB doesn't match any msymbols when searching in the
2838         TYPES_DOMAIN.
2839         (print_symbol_info): Print using typedef_print or type_print based
2840         on the type of the symbol.  Add updated FIXME comment moved from...
2841         (_initialize_symtab): ... move and update FIXME comment to above.
2842
2843 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2844
2845         * NEWS: Mention adding -q option to "info types".
2846         * symtab.c (struct info_types_options): New struct.
2847         (info_types_options_defs): New variable.
2848         (make_info_types_options_def_group): New function.
2849         (info_types_command): Use gdb::option framework to parse options.
2850         (info_types_command_completer): New function.
2851         (_initialize_symtab): Extend the help text on "info types" and
2852         register command completer.
2853
2854 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2855
2856         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2857         (lookup_symbol_in_objfile): Change int to block_enum and add a
2858         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2859
2860 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2861
2862         * MAINTAINERS (Write After Approval): Add self.
2863
2864 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2865
2866         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2867         instruction to the dummy code region.
2868
2869 2019-07-19  Tom Tromey  <tromey@adacore.com>
2870
2871         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2872         (ARGSUSED, PARAMS, __func__): Remove rules.
2873
2874 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2875
2876         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2877         * features/arm/arm-with-iwmmxt.c: Remove.
2878         * features/arm/arm-with-iwmmxt.xml: Remove.
2879         * features/arm/arm-with-m-fpa-layout.c: Remove.
2880         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2881         * features/arm/arm-with-m-vfp-d16.c: Remove.
2882         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2883         * features/arm/arm-with-m.c: Remove.
2884         * features/arm/arm-with-m.xml: Remove.
2885         * features/arm/arm-with-neon.c: Remove.
2886         * features/arm/arm-with-neon.xml: Remove.
2887         * features/arm/arm-with-vfpv2.c: Remove.
2888         * features/arm/arm-with-vfpv2.xml: Remove.
2889         * features/arm/arm-with-vfpv3.c: Remove.
2890         * features/arm/arm-with-vfpv3.xml: Remove.
2891
2892 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2893
2894         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2895
2896 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2897
2898         * arch/aarch32.c (aarch32_create_target_description): Create
2899         target descriptions using features.
2900         * arch/arm.c (arm_create_target_description)
2901         (arm_create_mprofile_target_description): Likewise.
2902         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2903
2904 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2905
2906         * Makefile.in: Add new files.
2907         * aarch32-tdep.c: New file.
2908         * aarch32-tdep.h: New file.
2909         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2910         Call aarch32_read_description.
2911         * arch/aarch32.c: New file.
2912         * arch/aarch32.h: New file.
2913         * arch/arm.c (arm_create_target_description)
2914         (arm_create_mprofile_target_description): New function.
2915         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2916         (arm_create_target_description)
2917         (arm_create_mprofile_target_description): New declaration.
2918         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2919         read_description functions.
2920         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2921         Likewise.
2922         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2923         * arm-tdep.c (tdesc_arm_list): New variable.
2924         (arm_register_g_packet_guesses): Call create description functions.
2925         (arm_read_description) (arm_read_mprofile_description): New
2926         function.
2927         * arm-tdep.h (arm_read_description)
2928         (arm_read_mprofile_description): Add declaration.
2929         * configure.tgt: Add new files.
2930
2931 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2932
2933         * top.c (new_ui_command): Open specified terminal just once.
2934
2935 2019-07-18  Tom Tromey  <tromey@adacore.com>
2936
2937         * symtab.c (main_name): Constify return type.
2938         * symfile.c (set_initial_language): Update.
2939         * symtab.h (main_name): Constify return type.
2940
2941 2019-07-17  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-winsource.c (tui_update_source_window)
2944         (tui_update_source_window_as_is)
2945         (tui_update_source_windows_with_line): Remove return.
2946         * tui/tui-disasm.c (tui_show_disassem)
2947         (tui_show_disassem_and_update_source): Remove return.
2948         * tui/tui.c (tui_reset): Remove return.
2949         * tui/tui-wingeneral.c
2950         (tui_check_and_display_highlight_if_needed): Remove return.
2951
2952 2019-07-17  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2955
2956 2019-07-17  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-winsource.h (struct tui_exec_info_window)
2959         (struct tui_source_window_base): Move from tui-data.h.
2960         * tui/tui-winsource.c: Move many method definitions from
2961         elsewhere.  Remove "structuring" comments.
2962         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2963         (tui_source_window_base::refresh_window): Move to
2964         tui-winsource.c.
2965         * tui/tui-win.c (tui_source_window_base::refresh_all)
2966         (tui_source_window_base::update_tab_width)
2967         (tui_source_window_base::set_new_height)
2968         (tui_source_window_base::do_make_visible_with_new_height): Move to
2969         tui-winsource.c.
2970         * tui/tui-source.h: Update.
2971         * tui/tui-source.c (tui_source_window_base::reset): Move to
2972         tui-winsource.c.
2973         * tui/tui-disasm.h: Update.
2974         * tui/tui-data.h (struct tui_exec_info_window): Move to
2975         tui-winsource.h.
2976         (struct tui_source_window_base): Likewise.
2977         * tui/tui-data.c (tui_source_window_base::clear_detail)
2978         (tui_source_window_base, ~tui_source_window_base): Move to
2979         tui-winsource.c.
2980
2981 2019-07-17  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui-win.c (tui_resize_all)
2984         (tui_source_window_base::update_tab_width)
2985         (tui_adjust_win_heights): Update.
2986         (tui_win_info::make_invisible_and_set_new_height): Rename from
2987         make_invisible_and_set_new_height.
2988         * tui/tui-data.h (struct tui_win_info)
2989         <make_invisible_and_set_new_height>: New method.
2990
2991 2019-07-17  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui.c: Update.
2994         * tui/tui-source.h (struct tui_source_window): Move from
2995         tui-data.h.
2996         * tui/tui-layout.c: Update.
2997         * tui/tui-disasm.c: Update.
2998         * tui/tui-data.h (struct tui_source_window): Move to
2999         tui-source.h.
3000
3001 2019-07-17  Tom Tromey  <tom@tromey.com>
3002
3003         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3004         tui-data.h.
3005         * tui/tui-data.h (struct tui_disasm_window): Move to
3006         tui-disasm.h.
3007
3008 2019-07-17  Tom Tromey  <tom@tromey.com>
3009
3010         * tui/tui-regs.h (struct tui_data_item_window): Move from
3011         tui-data.h.
3012         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3013         * tui/tui-data.h (struct tui_data_item_window): Move to
3014         tui-regs.h.
3015         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3016
3017 2019-07-17  Tom Tromey  <tom@tromey.com>
3018
3019         * tui/tui.c: Update.
3020         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3021         (tui_cmd_window::max_height): Move to tui-command.c.
3022         * tui/tui-layout.c: Update.
3023         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3024         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3025         tui-command.c.
3026         * tui/tui-command.h (struct tui_cmd_window): Move from
3027         tui-data.h.
3028         * tui/tui-command.c: Remove "structuring" comments.
3029         (tui_cmd_window::clear_detail)
3030         (tui_cmd_window::do_make_visible_with_new_height)
3031         (tui_cmd_window::max_height): Move from elsewhere.
3032
3033 2019-07-17  Tom Tromey  <tom@tromey.com>
3034
3035         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3036         Now static.
3037         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3038         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3039
3040 2019-07-17  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui.c: Update.
3043         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3044         tui-regs.c.
3045         * tui/tui-windata.h: Remove file.
3046         * tui/tui-windata.c: Remove file.
3047         * tui/tui-win.c (tui_data_window::set_new_height)
3048         (tui_data_window::do_make_visible_with_new_height): Move to
3049         tui-regs.c.
3050         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3051         * tui/tui-regs.c: Remove "structuring" comments.
3052         (tui_data_window::first_data_item_displayed)
3053         (tui_data_window::delete_data_content_windows)
3054         (tui_data_window::erase_data_content)
3055         (tui_data_window::display_all_data)
3056         (tui_data_window::refresh_all)
3057         (tui_data_window::do_scroll_vertical)
3058         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3059         (tui_data_window::do_make_visible_with_new_height)
3060         (tui_data_window::refresh_window): Move from elsewhere.
3061         (_initialize_tui_regs): Move to end of file.
3062         * tui/tui-layout.c: Update.
3063         * tui/tui-hooks.c: Update.
3064         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3065         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3066         tui-regs.c.
3067         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3068
3069 2019-07-17  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3072         seen.
3073
3074 2019-07-17  Tom Tromey  <tom@tromey.com>
3075
3076         * tui/tui-win.c (tui_source_window_base::set_new_height)
3077         (tui_source_window_base::do_make_visible_with_new_height): Use
3078         m_has_locator field directly.
3079         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3080         method.
3081         (struct tui_source_window_base) <has_locator>: Likewise.
3082
3083 2019-07-17  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3086         Don't declare.
3087         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3088         Remove.
3089         * tui/tui-win.c (tui_source_window_base::set_new_height)
3090         (tui_source_window_base::set_new_height)
3091         (make_invisible_and_set_new_height)
3092         (tui_source_window_base::do_make_visible_with_new_height)
3093         (tui_source_window_base::do_make_visible_with_new_height):
3094         Update.
3095         * tui/tui-layout.c (show_source_disasm_command, show_data)
3096         (show_source_or_disasm_and_command): Update.
3097         * tui/tui-layout.c (show_layout): Update.
3098
3099 2019-07-17  Tom Tromey  <tom@tromey.com>
3100
3101         * tui/tui-layout.c (make_data_window): Remove.
3102         (show_data): Unify creation and re-initialization cases.
3103
3104 2019-07-17  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-layout.c (make_source_window, make_disasm_window):
3107         Remove.
3108         (show_data): Unify creation and re-initialization cases.
3109
3110 2019-07-17  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-layout.c (make_command_window): Remove.
3113         (show_source_disasm_command, show_source_or_disasm_and_command):
3114         Unify creation and re-initialization cases.
3115
3116 2019-07-17  Tom Tromey  <tom@tromey.com>
3117
3118         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3119         creation and re-initialization cases.
3120
3121 2019-07-17  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-regs.c (tui_get_register): Return void.
3124
3125 2019-07-17  Tom Tromey  <tom@tromey.com>
3126
3127         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3128         Simplify.
3129
3130 2019-07-17  Tom Tromey  <tom@tromey.com>
3131
3132         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3133         resetting.
3134
3135 2019-07-17  Tom Tromey  <tom@tromey.com>
3136
3137         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3138         * tui/tui-regs.c (tui_reg_layout): New function.
3139         (tui_show_registers, tui_reg_command): Use it.
3140         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3141         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3142         parameters.
3143         (tui_layout_command): Remove.
3144
3145 2019-07-17  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-layout.h (tui/tui-layout): Return void.
3148         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3149
3150 2019-07-17  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-layout.c (show_source_disasm_command, show_data):
3153         Update.
3154         (reset_locator): Remove.
3155         (show_source_or_disasm_and_command): Update.
3156
3157 2019-07-17  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-source.c (tui_source_window_base::reset): Remove
3160         win_type parameter.
3161         * tui/tui-layout.c (make_command_window, make_source_window)
3162         (make_disasm_window, make_data_window)
3163         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3164         (reset_locator, show_source_or_disasm_and_command): Update.
3165         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3166         win_type parameter.
3167         (struct tui_source_window_base) <reset>: Likewise.
3168
3169 2019-07-17  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-layout.c (show_source_disasm_command): Use
3172         reset_locator.
3173         (reset_locator): New function.
3174         (init_and_make_win): Remove.
3175         (show_source_or_disasm_and_command): Use reset_locator.
3176
3177 2019-07-17  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3180         condition.
3181         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3182         Remove condition.
3183         * tui/tui-source.c (tui_source_window_base::reset): New method.
3184         * tui/tui-layout.c (make_command_window): Don't call
3185         init_and_make_win.
3186         (make_source_window, make_disasm_window): Don't call
3187         make_source_or_disasm_window.
3188         (make_data_window): Don't call init_and_make_win.  Change calling
3189         convention.
3190         (show_source_disasm_command, show_data): Simplify.
3191         (make_source_or_disasm_window): Remove.
3192         (show_source_or_disasm_and_command): Simplify.
3193         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3194         (struct tui_source_window_base) <reset>: Likewise.
3195         <execution_info>: Remove initializer.
3196         * tui/tui-data.c (tui_source_window_base): Initialize
3197         execution_info.
3198
3199 2019-07-17  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3202         variable.
3203
3204 2019-07-17  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui.c (tui_rl_other_window): Update.
3207         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3208         superclass method first.  Always iterate over regs_content.
3209         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3210         method.
3211         * tui/tui-win.c (tui_set_focus_command): Update.
3212
3213 2019-07-17  Tom Tromey  <tom@tromey.com>
3214
3215         * tui/tui-win.c (tui_set_focus_command): Rename from
3216         tui_set_focus.  Call tui_enable.
3217         (tui_set_focus_command): Remove.
3218
3219 2019-07-17  Tom Tromey  <tom@tromey.com>
3220
3221         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3222         refresh_window.
3223         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3224         touchwin.
3225         (tui_data_window::refresh_window): Call refresh_window on data
3226         items.  Always call superclass refresh_window.
3227         (tui_win_info::refresh): Remove.
3228         (tui_source_window_base::refresh_window): Update.
3229         (tui_refresh_all): Update.
3230         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3231         refresh_window.
3232         (show_source_or_disasm_and_command): Likewise.
3233         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3234         (struct tui_source_window_base) <refresh>: Likewise.
3235
3236 2019-07-17  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-winsource.c (tui_clear_source_content)
3239         (tui_show_source_content): Update.
3240         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3241         whether content is empty.
3242         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3243         Remove.
3244
3245 2019-07-17  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3248         window's contents.
3249         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3250         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3251
3252 2019-07-17  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3255         (struct tui_data_item_window): Update.
3256
3257 2019-07-17  Tom Tromey  <tom@tromey.com>
3258
3259         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3260         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3261         defines.
3262
3263 2019-07-17  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-winsource.h (tui_erase_source_content)
3266         (tui_clear_source_content): Remove "display_prompt" parameter.
3267         * tui/tui-winsource.c (tui_update_source_window_as_is)
3268         (tui_update_source_windows_with_addr): Update.
3269         (tui_clear_source_content): Remove "display_prompt" parameter.
3270         (tui_erase_source_content): Likewise.  Simplify.
3271         (tui_show_source_content): Update.
3272         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3273         * tui/tui-stack.c (tui_show_frame_info): Update.
3274         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3275         Remove defines.
3276
3277 2019-07-17  Tom Tromey  <tom@tromey.com>
3278
3279         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3280         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3281         parameter.
3282         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3283         parameter.
3284
3285 2019-07-17  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-winsource.c (tui_clear_source_content)
3288         (tui_show_source_content, tui_show_exec_info_content)
3289         (tui_clear_exec_info_content): Update.
3290         * tui/tui-stack.c (tui_show_locator_content): Update.
3291         (tui_show_frame_info): Update.
3292         * tui/tui-source.h (tui_source_window): Don't declare.
3293         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3294         from tui_source_is_displayed.
3295         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3296         Remove field.
3297         (struct tui_source_window_base) <content_in_use>: New field.  Now
3298         bool.
3299         (struct tui_source_window) <showing_source_p>: New method.
3300         (TUI_SRC_WIN): Change cast.
3301         * tui/tui-data.c (tui_initialize_static_data): Update.
3302
3303 2019-07-17  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3306         location_matches_p.
3307         * tui/tui-source.c (tui_source_window::location_matches_p): New
3308         method.
3309         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3310         method.
3311         * tui/tui-data.h (struct tui_source_window_base)
3312         <location_matches_p>: New method.
3313         (struct tui_source_window, struct tui_disasm_window)
3314         <location_matches_p>: Likewise.
3315
3316 2019-07-17  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-win.c (tui_set_win_height_command): Rename from
3319         tui_set_win_height.
3320         (tui_set_win_height_command): Remove.
3321
3322 2019-07-17  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-source.c (tui_source_window): New constructor.  Add
3325         observer.
3326         (~tui_source_window): New destructor.
3327         (tui_source_window::style_changed): New method.
3328         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3329         (tui_attach_detach_observers): Update.
3330         * tui/tui-data.h (struct tui_source_window): Make constructor not
3331         inline.  Add destructor.
3332         (struct tui_source_window) <style_changed>: New method.
3333         <m_observable>: New member.
3334
3335 2019-07-17  Tom Tromey  <tom@tromey.com>
3336
3337         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3338         * tui/tui-win.c (tui_resize_all): Fix typo.
3339
3340 2019-07-17  Tom Tromey  <tom@tromey.com>
3341
3342         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3343         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3344         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3345         * tui/tui-win.c (window_name_completer): Use foreach.
3346         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3347         (update_tab_width): Likewise.
3348         * tui/tui-layout.c (show_layout): Update.
3349         * tui/tui-data.h (class tui_window_iterator): New.
3350         (struct all_tui_windows): New.
3351         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3352
3353 2019-07-17  Tom Tromey  <tom@tromey.com>
3354
3355         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3356         parameter.  Don't reference globals.
3357         (tui_reg_command): Update.
3358
3359 2019-07-17  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui-regs.c (tui_show_registers): Simplify.
3362
3363 2019-07-17  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-regs.c (tui_show_registers): Update.
3366         (tui_show_register_group): Add win_info parameter.
3367
3368 2019-07-17  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3371         Rename from tui_display_reg_element_at_line.
3372         (tui_data_window::display_registers_from_line): Update.
3373         * tui/tui-data.h (struct tui_data_window)
3374         <display_reg_element_at_line>: New method.
3375
3376 2019-07-17  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-regs.h (tui_display_registers_from)
3379         (tui_display_registers_from_line): Don't declare.
3380         * tui/tui-windata.c (tui_data_window::display_all_data)
3381         (tui_data_window::refresh_all)
3382         (tui_data_window::do_scroll_vertical): Update.
3383         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3384         from tui_display_registers_from.
3385         (tui_display_reg_element_at_line): Update.
3386         (tui_data_window::display_registers_from_line): Rename from
3387         tui_display_registers_from_line.
3388         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3389         display_registers_from_line>: New methods.
3390
3391 2019-07-17  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3394         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3395         from tui_erase_data_content.
3396         (tui_data_window::display_all_data)
3397         (tui_data_window::refresh_all)
3398         (tui_data_window::do_scroll_vertical): Update.
3399         * tui/tui-regs.c (tui_show_registers): Update.
3400         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3401         New method.
3402
3403 2019-07-17  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3406         declare.
3407         * tui/tui-windata.c
3408         (tui_data_window::delete_data_content_windows): Rename from
3409         tui_delete_data_content_windows.
3410         (tui_data_window::display_all_data)
3411         (tui_data_window::do_scroll_vertical): Update.
3412         * tui/tui-data.h (struct tui_data_window)
3413         <delete_data_content_windows>: New method.
3414
3415 2019-07-17  Tom Tromey  <tom@tromey.com>
3416
3417         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3418         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3419
3420 2019-07-17  Tom Tromey  <tom@tromey.com>
3421
3422         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3423         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3424         from tui_display_all_data.
3425         * tui/tui-win.c
3426         (tui_data_window::do_make_visible_with_new_height): Update.
3427         * tui/tui-regs.c (tui_show_registers): Update.
3428         * tui/tui-layout.c (tui_set_layout): Update.
3429         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3430         method.
3431
3432 2019-07-17  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3435         * tui/tui-windata.c (tui_display_data_from): Remove.
3436         (tui_data_window::refresh_all): Update.
3437
3438 2019-07-17  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3441         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3442         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3443         tui_display_registers_from_line.
3444         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3445         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3446         "force_display" parameter.
3447
3448 2019-07-17  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3451         declare.
3452         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3453         Rename from tui_first_reg_element_no_inline.
3454         (tui_display_reg_element_at_line)
3455         (tui_display_registers_from_line): Update.
3456         * tui/tui-data.h (struct tui_data_window)
3457         <first_reg_element_no_inline>: New method.
3458
3459 2019-07-17  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-windata.c (tui_display_data_from)
3462         (tui_data_window::do_scroll_vertical): Update.
3463         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3464         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3465         Rename from tui_line_from_reg_element_no.
3466         (tui_display_registers_from_line): Update.
3467         * tui/tui-data.h (struct tui_data_window)
3468         <line_from_reg_element_no>: New method.
3469
3470 2019-07-17  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3473         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3474         tui_last_regs_line_no.
3475         (tui_display_reg_element_at_line)
3476         (tui_display_registers_from_line): Update.
3477         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3478         method.
3479
3480 2019-07-17  Tom Tromey  <tom@tromey.com>
3481
3482         PR tui/24722:
3483         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3484         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3485         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3486         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3487         (tui_update_breakpoint_info): Likewise.
3488         * tui/tui-hooks.c (tui_event_create_breakpoint)
3489         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3490         Update.
3491
3492 2019-07-17  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3495
3496 2019-07-17  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-winsource.c (tui_update_source_window_as_is)
3499         (tui_update_source_windows_with_addr): Update.
3500         * tui/tui-source.h (tui_set_source_content)
3501         (tui_show_symtab_source): Add "win_info" parameter.
3502         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3503         parameter.
3504         (tui_show_symtab_source): Likewise.
3505
3506 2019-07-17  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-wingeneral.c
3509         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3510
3511 2019-07-17  Tom Tromey  <tom@tromey.com>
3512
3513         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3514         (struct tui_cmd_window) <can_scroll>: New method.
3515         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3516         method.
3517
3518 2019-07-17  Tom Tromey  <tromey@adacore.com>
3519
3520         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3521         do_field_signed>: Rename.  Change type of "value".
3522         * ui-out.c (ui_out::field_signed): Rename from field_int.
3523         Change type of "value".
3524         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3525         type of "value".
3526         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3527         do_field_int.  Change type of "value".
3528         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3529         do_field_int.  Change type of "value".
3530         * tracepoint.c (trace_status_mi, tfind_1)
3531         (print_one_static_tracepoint_marker): Update.
3532         * thread.c (print_thread_info_1, print_selected_thread_frame):
3533         Update.
3534         * stack.c (print_frame, print_frame_info): Update.
3535         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3536         Update.
3537         * source.c (print_source_lines_base): Update.
3538         * skip.c (info_skip_command): Update.
3539         * record-btrace.c (btrace_ui_out_decode_error)
3540         (btrace_call_history_src_line): Update.
3541         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3542         Update.
3543         * progspace.c (print_program_space): Update.
3544         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3545         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3546         do_field_int.  Change type of "value".
3547         * mi/mi-out.c (mi_ui_out::do_table_begin)
3548         (mi_ui_out::do_table_header): Update.
3549         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3550         type of "value".
3551         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3552         (mi_cmd_data_list_changed_registers, output_register)
3553         (mi_cmd_data_read_memory, mi_load_progress)
3554         (mi_cmd_trace_frame_collected): Update.
3555         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3556         Update.
3557         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3558         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3559         (mi_cmd_var_list_children, varobj_update_one): Update.
3560         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3561         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3562         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3563         * inferior.c (print_inferior): Update.
3564         * gdb_bfd.c (print_one_bfd): Update.
3565         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3566         Update.
3567         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3568         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3569         do_field_int.  Change type of "value".
3570         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3571         do_field_int.  Change type of "value".
3572         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3573         (print_one_breakpoint_location, print_it_catch_fork)
3574         (print_one_catch_fork, print_it_catch_vfork)
3575         (print_one_catch_vfork, print_it_catch_solib)
3576         (print_it_catch_exec, print_it_ranged_breakpoint)
3577         (print_mention_watchpoint, print_mention_masked_watchpoint)
3578         (bkpt_print_it, update_static_tracepoint): Update.
3579         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3580         * break-catch-syscall.c (print_it_catch_syscall): Update.
3581         * ada-tasks.c (print_ada_task_info): Update.
3582         * ada-lang.c (print_it_exception, print_mention_exception):
3583         Update.
3584
3585 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3586
3587         PR breakpoints/24541
3588         * gdbarch.c: Regenerate.
3589         * gdbarch.h: Regenerate.
3590         * gdbarch.sh: Adjust return type and parameter types for
3591         'stap_adjust_register'.
3592         (i386_stap_adjust_register): Adjust signature and return new
3593         register name.
3594         * stap-probe.c (stap_parse_register_operand): Adjust use of
3595         'gdbarch_stap_adjust_register'.
3596
3597 2019-07-17  Tom Tromey  <tromey@adacore.com>
3598
3599         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3600         declare VEC.
3601         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3602         std::vector.
3603         (struct s390_process_info): Add initializers.
3604         (s390_add_process): Use new.
3605         (s390_linux_nat_target::low_forget_process): Use delete.
3606         (s390_linux_nat_target::low_new_fork)
3607         (s390_linux_nat_target::stopped_by_watchpoint)
3608         (s390_linux_nat_target::low_prepare_to_resume)
3609         (s390_linux_nat_target::insert_watchpoint)
3610         (s390_linux_nat_target::insert_hw_breakpoint)
3611         (s390_linux_nat_target::remove_watchpoint)
3612         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3613
3614 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3615
3616         * aarch64-fbsd-nat.c: Include regcache.h.
3617         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3618         argument.
3619         (aarch64_fbsd_nat_target::fetch_registers)
3620         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3621         variable.
3622         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3623
3624 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3625
3626         * fbsd-nat.c: Include gdbarch.h.
3627
3628 2019-07-15  Tom Tromey  <tromey@adacore.com>
3629
3630         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3631
3632 2019-07-15  Tom Tromey  <tromey@adacore.com>
3633
3634         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3635         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3636         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3637         * cli-out.c (cli_ui_out::do_field_int): New method.
3638         * ui-out.c (ui_out::field_unsigned): New method.
3639         * symfile.c (generic_load): Use field_unsigned.
3640         (print_transfer_performance): Likewise.
3641         * record-btrace.c (ui_out_field_uint): Remove.
3642         (btrace_call_history_insn_range, btrace_call_history): Use
3643         field_unsigned.
3644         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3645         field_unsigned.
3646         * ui-out.h (class ui_out) <field_unsigned>: New method.
3647         <do_field_unsigned>: Likewise.
3648
3649 2019-07-15  Tom Tromey  <tromey@adacore.com>
3650
3651         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3652         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3653         * target.c (flash_erase_command): Use field_string.
3654         * infrun.c (print_signal_received_reason): Use field_string.
3655         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3656         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3657         field_string.
3658         * ada-tasks.c (print_ada_task_info): Use field_string.
3659
3660 2019-07-15  Tom Tromey  <tromey@adacore.com>
3661
3662         * target.c (flash_erase_command): Use field_core_addr.
3663         * symfile.c (generic_load): Use field_core_addr.
3664         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3665         Use field_core_addr.
3666         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3667         field_core_addr.
3668
3669 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3670
3671         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3672         value if its desired type is smaller than a CORE_ADDR and signed.
3673
3674 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3677         of changes to field names, and use new is_reference field to
3678         decide if a property is a reference or not.
3679         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3680         field.
3681         (struct dwarf2_property_baton): Update header comment, rename
3682         'referenced_type' to 'property_type' and update comments.
3683         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3684         default property type, store in property baton, update to take
3685         accound of renamed field.
3686         (read_func_scope): Update call to attr_to_dynamic_prop.
3687         (read_array_type): Likewise.
3688         (dwarf2_per_cu_addr_sized_int_type): New function.
3689         (read_subrange_index_type): Move type finding code to
3690         dwarf2_per_cu_addr_sized_int_type.
3691         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3692         (dwarf2_per_cu_addr_type): New function.
3693         (set_die_type): Update calls to attr_to_dynamic_prop.
3694
3695 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3696
3697         * dwarf2read.c (read_subrange_index_type): New function.
3698         (read_subrange_type): Move code into new function and call it.
3699         * gdbtypes.c (create_range_type): Add some asserts.
3700
3701 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3702
3703         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3704         update return statements.
3705         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3706         declaration, and update comment to match.
3707         * gdbtypes.c (resolve_dynamic_array): Update call to
3708         dwarf2_evaluate_property to match new return type.
3709
3710 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3711
3712         * valarith.c (value_subscripted_rvalue): Change lowerbound
3713         parameter type from int to LONGEST.
3714         * value.h (value_subscripted_rvalue): Likewise in declaration.
3715
3716 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * cli/cli-utils.c (info_print_command_completer): New function.
3719         * cli/cli-utils.h: Add 'completer.h' include, and forward
3720         declaration for 'struct cmd_list_element'.
3721         (info_print_command_completer): Declare.
3722         * stack.c (_initialize_stack): Add completer for 'info locals' and
3723         'info args'.
3724         * symtab.c (_initialize_symtab): Add completer for 'info
3725         variables' and 'info functions'.
3726         * NEWS: Mention completion for additional info commands.
3727
3728 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3729
3730         * cli/cli-utils.c (extract_info_print_args): Delete.
3731         (extract_arg_maybe_quoted): Delete.
3732         (info_print_options_defs): New variable.
3733         (make_info_print_options_def_group): New function.
3734         (extract_info_print_options): Define new function.
3735         * cli/cli-utils.h (extract_info_print_args): Delete.
3736         (struct info_print_options): New structure.
3737         (extract_info_print_options): Declare new function.
3738         * stack.c (info_locals_command): Update to use new
3739         extract_info_print_options, also add a header comment.
3740         (info_args_command): Likewise.
3741         * symtab.c (info_variables_command): Likewise.
3742         (info_functions_command): Likewise.
3743
3744 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3745
3746         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3747         to extract string arguments.
3748         * common/common-utils.c (extract_string_maybe_quoted): New function.
3749         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3750
3751 2019-07-11  Tom Tromey  <tromey@adacore.com>
3752
3753         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3754         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3755         * top.h (gdbinit): Don't declare.
3756         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3757         into...
3758         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3759         * top.c (gdb_init): Don't call init_cli_cmds.
3760         (gdbinit): Remove.
3761         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3762
3763 2019-07-11  Tom Tromey  <tromey@adacore.com>
3764
3765         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3766         after it has been moved.
3767
3768 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3769
3770         * valops.c (value_must_coerce_to_target): Change return type to
3771         bool.
3772         * value.h (value_must_coerce_to_target): Likewise.
3773
3774 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3775
3776         * breakpoint.c (is_hardware_watchpoint): Remove
3777         forward-declaration.
3778         (is_masked_watchpoint): Change return type to bool.
3779         (is_tracepoint): Likewise.
3780         (is_breakpoint): Likewise.
3781         (is_hardware_watchpoint): Likewise.
3782         (is_watchpoint): Likewise.
3783         (is_no_memory_software_watchpoint): Likewise.
3784         (is_catchpoint): Likewise.
3785         (breakpoint_1): Make FILTER parameter's return type bool.
3786         is_masked_watchpoint): Change return type to bool.
3787         (save_breakpoints): Make FILTER parameter's return type bool.
3788         * breakpoint.h (is_breakpoint): Change return type to bool.
3789         (is_watchpoint): Likewise.
3790         (is_catchpoint): Likewise.
3791         (is_tracepoint): Likewise.
3792
3793 2019-07-10  Tom Tromey  <tom@tromey.com>
3794
3795         * defs.h: Don't include gdbarch.h.
3796         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3797         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3798         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3799         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3800         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3801         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3802         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3803         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3804         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3805         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3806         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3807         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3808         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3809         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3810         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3811         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3812         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3813         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3814         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3815         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3816         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3817         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3818         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3819         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3820         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3821         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3822         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3823
3824 2019-07-10  Tom Tromey  <tromey@adacore.com>
3825
3826         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3827         * breakpoint.c (init_ada_exception_breakpoint): Register as
3828         bp_catchpoint.
3829         (print_one_breakpoint_location, print_one_breakpoint): Use
3830         is_ada_exception_catchpoint.
3831         * ada-lang.c (class ada_catchpoint_location): Pass
3832         bp_loc_software_breakpoint to bp_location constructor.
3833         (is_ada_exception_catchpoint): New function.
3834
3835 2019-07-10  Tom Tromey  <tromey@adacore.com>
3836
3837         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3838         VEC.
3839         (struct arm_exidx_entry): New method operator<.
3840         (struct arm_exidx_data) <section_maps>: Change type.
3841         (arm_exidx_data_free): Remove.
3842         (arm_exidx_data_key): Change type.  Move lower.
3843         (arm_exidx_new_objfile): Update.
3844         (arm_compare_exidx_entries): Remove.
3845         (arm_find_exidx_entry, _initialize_arm_tdep)
3846
3847 2019-07-10  Tom Tromey  <tromey@adacore.com>
3848
3849         * solib-spu.c (ocl_program_data_key): Change type.
3850         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3851         Update.
3852
3853 2019-07-10  Tom Tromey  <tromey@adacore.com>
3854
3855         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3856         (struct solib_aix_inferior_data) <library_list>: Change type.
3857         (solib_aix_inferior_data_handle): Change type.
3858         (get_solib_aix_inferior_data): Update.
3859         (solib_aix_free_library_list): Remove.
3860         (library_list_start_library): Update.
3861         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3862         return type.
3863         (solib_aix_get_library_list)
3864         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3865         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3866
3867 2019-07-10  Tom Tromey  <tromey@adacore.com>
3868
3869         * solib-dsbt.c (struct dsbt_info): Add initializers.
3870         (solib_dsbt_pspace_data): Change type.
3871         (dsbt_pspace_data_cleanup): Remove.
3872         (get_dsbt_info, _initialize_dsbt_solib): Update.
3873
3874 2019-07-10  Tom Tromey  <tromey@adacore.com>
3875
3876         * spu-tdep.c (spu_overlay_data): Change type.
3877         (spu_get_overlay_table, spu_overlay_new_objfile)
3878         (_initialize_spu_tdep): Update.
3879
3880 2019-07-10  Tom Tromey  <tromey@adacore.com>
3881
3882         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3883         destructor.
3884         (dbx_objfile_data_key): Change type and declare later.
3885         (DBX_SYMFILE_INFO): Rewrite.
3886         * dbxread.c (dbx_objfile_data_key): Change type.
3887         (dbx_symfile_init): Update.
3888         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3889         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3890         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3891
3892 2019-07-10  Tom Tromey  <tromey@adacore.com>
3893
3894         * jit.c (jit_program_space_key): Change type.  Move lower.
3895         (get_jit_program_space_data): Update.
3896         (jit_program_space_data_cleanup): Remove.
3897         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3898         Update.
3899         (struct jit_program_space_data): Add initializers.
3900
3901 2019-07-10  Tom Tromey  <tromey@adacore.com>
3902
3903         * solib-darwin.c (struct darwin_info): Add initializers.
3904         (solib_darwin_pspace_data): Change type.
3905         (darwin_pspace_data_cleanup): Remove.
3906         (get_darwin_info, _initialize_darwin_solib): Update.
3907
3908 2019-07-10  Tom Tromey  <tromey@adacore.com>
3909
3910         * remote-sim.c (struct sim_inferior_data): Add initializers,
3911         constructor, and destructor.
3912         (sim_inferior_data_key): Change type.  Move lower.
3913         (check_for_duplicate_sim_descriptor): Update.
3914         (get_sim_inferior_data): Use new.  Update.
3915         (~sim_inferior_data_cleanup): Rename from
3916         sim_inferior_data_cleanup.  Simplify.
3917         (gdbsim_close_inferior, simulator_command)
3918         (sim_command_completer, _initialize_remote_sim): Update.
3919         (next_pid, INITIAL_PID): Move earlier.
3920
3921 2019-07-10  Tom Tromey  <tromey@adacore.com>
3922
3923         * python/python-internal.h (create_thread_object): Return
3924         gdbpy_ref.
3925         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3926         * python/py-inferior.c (struct threadlist_entry): Add
3927         constructor.
3928         <thread_obj>: Now a gdbpy_ref.
3929         (thread_to_thread_object): Update.
3930         (add_thread_object): Use new.
3931         (delete_thread_object): Use delete.
3932         (infpy_threads): Update.
3933         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3934         GIL.
3935
3936 2019-07-10  Tom Tromey  <tromey@adacore.com>
3937
3938         * valops.c (value_cast): Specialize error message for Ada.
3939
3940 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3941
3942         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3943
3944 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3945
3946         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3947         bpstat_should_step): Return bool, adjust comments.
3948         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3949         bpstat_should_step): Likewise.
3950
3951 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3952
3953         * features/Makefile: Use feature target descriptions for Arm.
3954         * features/arm/arm-core.c: Generate new file.
3955         * features/arm/arm-fpa.c: Likewise.
3956         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3957         * features/arm/arm-m-profile.c: Likewise.
3958         * features/arm/arm-vfpv2.c: Likewise.
3959         * features/arm/arm-vfpv3.c: Likewise.
3960         * features/arm/xscale-iwmmxt.c: Likewise.
3961         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3962
3963 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3964
3965         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3966         ptrace earlier.
3967
3968 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3969
3970         * features/aarch64-pauth.c: Regenerate.
3971
3972 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3973
3974         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3975         bool.
3976         (bpstat_what): Use false instead of 0.
3977
3978 2019-07-09  Pedro Alves  <palves@redhat.com>
3979
3980         * break-catch-throw.c (is_exception_catchpoint): New.
3981         * breakpoint.c (print_one_breakpoint_location): New parameter
3982         'raw_loc'.  Handle it.  Use
3983         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3984         looking at the breakpoint's type.
3985         (print_one_breakpoint): If handling "maint info breakpoints", also
3986         print locations of exception catchpoints.
3987         * breakpoint.h (is_exception_catchpoint): Declare.
3988
3989 2019-07-09  Pedro Alves  <palves@redhat.com>
3990
3991         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3992         "addr" field.
3993         (allocate_location_exception_catchpoint): New.
3994         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3995         (initialize_throw_catchpoint_ops): Install
3996         allocate_location_exception_catchpoint as allocate_location
3997         method.
3998         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3999         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4000         bp_loc_other.
4001         (breakpoint_address_is_meaningful): Delete.
4002         (bl_address_is_meaningful): New.
4003         (breakpoint_locations_match): Adjust comment.
4004         (bp_location_from_bp_type): New, factored out of...
4005         (bp_location::bp_location(breakpoint *)): ... this.
4006         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4007         factored out of...
4008         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4009         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4010         breakpoint_address_is_meaningful.
4011         (bp_locations_compare): Adjust comment.
4012         (update_global_location_list): Use bl_address_is_meaningful
4013         instead of breakpoint_address_is_meaningful.
4014         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4015         explicit.
4016         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4017         * python/py-breakpoint.c (bppy_get_location): No longer check
4018         whether location is null.
4019
4020 2019-07-09  Pedro Alves  <palves@redhat.com>
4021
4022         PR c++/15468
4023         * breakpoint.c (print_one_breakpoint_location): Remove
4024         single-location assert.
4025
4026 2019-07-09  Tom Tromey  <tom@tromey.com>
4027
4028         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4029         * configure: Rebuild.
4030         * configure.ac: Change common to gdbsupport.
4031         * gdbsupport: Rename from common.
4032         * acinclude.m4: Change common to gdbsupport.
4033         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4034         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4035         gdbsupport.
4036         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4037         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4038         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4039         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4040         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4041         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4042         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4043         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4044         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4045         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4046         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4047         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4048         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4049         coff-pe-read.c, command.h, compile/compile-c-support.c,
4050         compile/compile-c.h, compile/compile-cplus-symbols.c,
4051         compile/compile-cplus-types.c, compile/compile-cplus.h,
4052         compile/compile-loc2c.c, compile/compile.c, completer.c,
4053         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4054         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4055         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4056         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4057         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4058         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4059         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4060         features/aarch64-core.c, features/aarch64-fpu.c,
4061         features/aarch64-pauth.c, features/aarch64-sve.c,
4062         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4063         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4064         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4065         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4066         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4067         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4068         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4069         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4070         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4071         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4072         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4073         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4074         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4075         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4076         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4077         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4078         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4079         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4080         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4081         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4082         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4083         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4084         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4085         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4086         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4087         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4088         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4089         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4090         minsyms.c, mips-linux-tdep.c, namespace.h,
4091         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4092         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4093         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4094         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4095         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4096         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4097         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4098         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4099         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4100         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4101         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4102         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4103         procfs.c, producer.c, progspace.h, psymtab.h,
4104         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4105         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4106         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4107         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4108         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4109         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4110         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4111         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4112         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4113         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4114         target-memory.c, target.c, target.h, target/waitstatus.c,
4115         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4116         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4117         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4118         unittests/array-view-selftests.c,
4119         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4120         unittests/common-utils-selftests.c,
4121         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4122         unittests/format_pieces-selftests.c,
4123         unittests/function-view-selftests.c,
4124         unittests/lookup_name_info-selftests.c,
4125         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4126         unittests/mkdir-recursive-selftests.c,
4127         unittests/observable-selftests.c,
4128         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4129         unittests/parse-connection-spec-selftests.c,
4130         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4131         unittests/scoped_fd-selftests.c,
4132         unittests/scoped_mmap-selftests.c,
4133         unittests/scoped_restore-selftests.c,
4134         unittests/string_view-selftests.c, unittests/style-selftests.c,
4135         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4136         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4137         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4138         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4139         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4140         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4141
4142 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4143
4144         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4145         bool value.
4146         (decode_digits_ordinary): Set explicit_line field in sal.
4147         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4148         symtab_and_line that was set on an explicit line number in
4149         assembler code.  Do always update the recorded symtab and line if
4150         we do skip the prologue.
4151
4152 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4153
4154         * breakpoint.c (set_breakpoint_location_function): Remove
4155         explicit_loc parameter.
4156         (momentary_breakpoint_from_master): Update call to
4157         set_breakpoint_location_function.
4158         (add_location_to_breakpoint): Likewise.
4159
4160 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4161
4162         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4163         required features based on default bfd type when no specific bfd
4164         is present.
4165
4166 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4167
4168         * NEWS: Mention that GDB printf and eval commands can now print
4169         C-style and Ada-style convenience var strings without
4170         calling the inferior.
4171         * printcmd.c (printf_c_string): Locally print GDB internal var
4172         instead of transiting via the inferior.
4173         (printf_wide_c_string): Likewise.
4174
4175 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4176
4177         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4178
4179 2019-07-04  Tom Tromey  <tom@tromey.com>
4180
4181         PR tui/24724:
4182         * tui/tui-winsource.c (tui_clear_source_content): Update.
4183         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4184         (tui_update_breakpoint_info): Update.
4185         (tui_set_exec_info_content): Update.
4186         * tui/tui-source.c (tui_set_source_content_nil): Update.
4187         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4188         has_break.
4189         * tui/tui-data.h (enum tui_bp_flag): New.
4190         (tui_bp_flags): New enum flags type.
4191         (struct tui_source_element) <break_mode>: Change type.  Rename
4192         from has_break.
4193         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4194         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4195         constants.
4196         * tui/tui-winsource.h: Fix comment.
4197
4198 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4199
4200         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4201         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4202         (store_fpregs_to_thread)
4203         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4204         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4205         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4206         (IWMMXT_REGS_SIZE): Add define.
4207         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4208         (fetch_vfp_regs, store_vfp_regs)
4209         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4210         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4211
4212 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4213
4214         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4215         defines.
4216         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4217         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4218         (ARM_INT_REGISTER_SIZE): ...to this.
4219         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4220         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4221         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4222         (arm_linux_collect_gregset, supply_nwfpe_register)
4223         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4224         defines.
4225         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4226         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4227         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4228         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4229         (arm_return_in_memory, arm_store_return_value)
4230         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4231         (arm_record_ld_st_multiple): Likewise.
4232         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4233         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4234
4235 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4236
4237         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4238         AARCH64_DISPLACED_MODIFIED_INSNS.
4239         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4240         (aarch64_displaced_step_copy_insn): Likewise.
4241         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4242         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4243         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4244         ARM_DISPLACED_MODIFIED_INSNS.
4245         * arm-tdep.c (arm_gdbarch_init): Likewise.
4246         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4247         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4248         (struct arm_displaced_step_closure): Use
4249         ARM_DISPLACED_MODIFIED_INSNS.
4250
4251 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4252
4253         * features/Makefile: Remove unused xml files.
4254         * features/aarch64.xml: Remove.
4255         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4256         * features/i386/amd64-avx-avx512.xml: Remove.
4257         * features/i386/amd64-avx-linux.xml: Remove.
4258         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4259         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4260         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4261         * features/i386/amd64-avx-mpx.xml: Remove.
4262         * features/i386/amd64-avx.xml: Remove.
4263         * features/i386/amd64-linux.xml: Remove.
4264         * features/i386/amd64-mpx-linux.xml: Remove.
4265         * features/i386/amd64-mpx.xml: Remove.
4266         * features/i386/amd64.xml: Remove.
4267         * features/i386/i386-avx-avx512-linux.xml: Remove.
4268         * features/i386/i386-avx-avx512.xml: Remove.
4269         * features/i386/i386-avx-linux.xml: Remove.
4270         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4271         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4272         * features/i386/i386-avx-mpx-linux.xml: Remove.
4273         * features/i386/i386-avx-mpx.xml: Remove.
4274         * features/i386/i386-avx.xml: Remove.
4275         * features/i386/i386-linux.xml: Remove.
4276         * features/i386/i386-mmx-linux.xml: Remove.
4277         * features/i386/i386-mmx.xml: Remove.
4278         * features/i386/i386-mpx-linux.xml: Remove.
4279         * features/i386/i386-mpx.xml: Remove.
4280         * features/i386/i386.xml: Remove.
4281         * features/i386/x32-avx-avx512-linux.xml: Remove.
4282         * features/i386/x32-avx-linux.xml: Remove.
4283         * features/i386/x32-linux.xml: Remove.
4284
4285 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4286
4287         * regformats/aarch64.dat: Remove.
4288         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4289         * regformats/i386/amd64-avx-linux.dat: Remove.
4290         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4291         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4292         * regformats/i386/amd64-linux.dat: Remove.
4293         * regformats/i386/amd64-mpx-linux.dat: Remove.
4294         * regformats/i386/amd64.dat: Remove.
4295         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4296         * regformats/i386/i386-avx-linux.dat: Remove.
4297         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4298         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4299         * regformats/i386/i386-linux.dat: Remove.
4300         * regformats/i386/i386-mmx-linux.dat: Remove.
4301         * regformats/i386/i386-mpx-linux.dat: Remove.
4302         * regformats/i386/i386.dat: Remove.
4303         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4304         * regformats/i386/x32-avx-linux.dat: Remove.
4305         * regformats/i386/x32-linux.dat: Remove.
4306
4307 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4308
4309         * aarch64-tdep.c: Remove xml self tests.
4310         * amd64-linux-tdep.c: Likewise.
4311         * amd64-tdep.c: Likewise.
4312         * i386-linux-tdep.c: Likewise.
4313         * i386-tdep.c: Likewise.
4314
4315 2019-07-03  Pedro Alves  <palves@redhat.com>
4316
4317         PR cli/24732
4318         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4319         (pipe_cmd_option_defs): New.
4320         (make_pipe_cmd_options_def_group): New.
4321         (pipe_command): Use gdb::option::process_options.
4322         (pipe_command_completer): New function.
4323         (_initialize_cli_cmds): Install completer for "pipe" command.
4324
4325 2019-07-03  Pedro Alves  <palves@redhat.com>
4326
4327         * cli/cli-option.c (union option_value) <string>: New field.
4328         (struct option_def_and_value): Add ctor, move ctor, dtor and
4329         use DISABLE_COPY_AND_ASSIGN.
4330         (option_def_and_value::clear_value): New.
4331         (parse_option, save_option_value_in_ctx, get_val_type_str)
4332         (add_setshow_cmds_for_options): Handle var_string.
4333         * cli-option.h (union option_def::var_address) <string>: New
4334         field.
4335         (struct string_option_def): New.
4336         * maint-test-options.c (struct test_options_opts): Add default
4337         ctor and use DISABLE_COPY_AND_ASSIGN.
4338         <string_opt>: New field.
4339         (test_options_opts::~test_options_opts): New.
4340         (test_options_opts::dump): Also dump "-string".
4341         (test_options_option_defs): Install "string.
4342
4343 2019-07-03  Pedro Alves  <palves@redhat.com>
4344
4345         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4346         option_value with a null enumeration.
4347         (complete_options): Save the option values in the context.
4348         (save_option_value_in_ctx): New, factored out from ...
4349         (process_options): ... here.
4350         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4351         of the function.
4352         * maint-test-options.c (test_options_opts::dump): New, factored
4353         out from ...
4354         (maintenance_test_options_command_mode): ... here.
4355         (maintenance_test_options_command_completion_result): Delete.
4356         (maintenance_test_options_command_completion_text): Update
4357         comment.
4358         (maintenance_show_test_options_completion_result): Change
4359         prototype.  Just print
4360         maintenance_test_options_command_completion_text.
4361         (save_completion_result): New.
4362         (maintenance_test_options_completer_mode): Pass options context to
4363         complete_options, and then save a dump.
4364         (_initialize_maint_test_options): Use add_cmd to install "maint
4365         show test-options-completion-result".
4366
4367 2019-07-03  Pedro Alves  <palves@redhat.com>
4368
4369         * NEWS (New commands): Mention "with" and "maint with".
4370         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4371         (with_command, with_command_completer): New.
4372         (pipe_command): Adjust to new repeat_previous
4373         interface.
4374         (_initialize_cli_cmds): Install the "with" command and its "w"
4375         alias.
4376         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4377         declarations.
4378         * cli/cli-setshow.c (parse_cli_var_uinteger)
4379         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4380         argument strings for all var_types.
4381         (get_setshow_command_value_string): New, factored out from ...
4382         (do_show_command): ... this.
4383         * cli/cli-setshow.h: Include <string>.
4384         (get_setshow_command_value_string): Declare.
4385         * command.h (repeat_previous): Now returns const char *.  Adjust
4386         comment.
4387         * maint.c: Include "cli/cli-cmds.h".
4388         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4389         (_initialize_maint_cmds): Register the "maintenance with" command.
4390         * top.c (repeat_previous): Move bits from pipe_command here:
4391         Return the saved command line, if any; error out if there's no
4392         command to relaunch.
4393
4394 2019-07-03  Pedro Alves  <palves@redhat.com>
4395
4396         * NEWS (New commands): Mention "maint set/show test-settings"
4397         instead of "maint test-settings".
4398         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4399         (maintenance_test_settings_set_list): Rename to ...
4400         (maintenance_set_test_settings_list): ... this.
4401         (maintenance_test_settings_show_list): Rename to  ...
4402         (maintenance_show_test_settings_list): ... this.
4403         (maintenance_test_settings_cmd): Delete.
4404         (maintenance_test_settings_set_cmd): ...
4405         (maintenance_set_test_settings_cmd): ... this.
4406         (maintenance_test_settings_show_cmd): ...
4407         (maintenance_show_test_settings_cmd): ... this.
4408         (maintenance_test_settings_show_value_cmd):
4409         (maintenance_show_test_settings_value_cmd): ... this.
4410         (_initialize_maint_test_settings): No longer install the "maint
4411         test-settings" prefix command.  Rename "maint test-settings set"
4412         to "maint set test-settings", and "maint test-settings show" to
4413         "maint show test-settings".  Adjust all subcommands.
4414
4415 2019-07-03  Pedro Alves  <palves@redhat.com>
4416
4417         * maint-test-settings.c: Fix file's intro comment.  Replace all
4418         references to "test-options" with references to "test-settings",
4419         in comments.
4420
4421 2019-07-03  Pedro Alves  <palves@redhat.com>
4422
4423         * maint-test-settings.c (maintenance_test_settings_xxx)
4424         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4425         New.
4426         (maintenance_test_settings_enums): Use them.
4427         (maintenance_test_settings_enum): Default to
4428         maintenance_test_settings_xxx.
4429         (_initialize_maint_test_settings): Initialize
4430         MAINTENANCE_TEST_SETTINGS_FILENAME.
4431
4432 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4433
4434         * breakpoint.h (remove_breakpoints_inf): Change return type to
4435         void, move function documentation here.
4436         * breakpoint.c (remove_breakpoints_inf): Change return type to
4437         void, move function documentation to header.
4438
4439 2019-07-02  Pedro Alves  <palves@redhat.com>
4440
4441         * NEWS (Completion improvements): Mention "info threads".
4442         * thread.c (struct info_threads_opts, info_threads_option_defs)
4443         (make_info_threads_options_def_group): New.
4444         (info_threads_command): Use gdb::option::process_options.
4445         (info_threads_command_completer): New.
4446         (_initialize_thread): Use gdb::option::build_help to build the
4447         help text for "info threads".
4448
4449 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4450
4451         * defs.h (generic_load): Move from here...
4452         * symfile.h (generic_load): ... to here.  Rename name parameter
4453         to args.
4454         * symfile.c (generic_load): Add comment.
4455
4456 2019-07-01  Tom Tromey  <tromey@adacore.com>
4457
4458         * dwarf2read.c
4459         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4460         declaration of without_params.  Fix formatting.
4461
4462 2019-07-01  Tom Tromey  <tromey@adacore.com>
4463
4464         * ada-exp.y (find_primitive_type): Update.
4465         * ada-lang.h (ada_lookup_symbol): Update.
4466         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4467         parameter.
4468         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4469
4470 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4471
4472         PR breakpoints/24541
4473         * gdbarch.c: Regenerate.
4474         * gdbarch.h: Regenerate.
4475         * gdbarch.sh: Add 'stap_adjust_register'.
4476         * i386-tdep.c: Include '<unordered_set>'.
4477         (i386_stap_adjust_register): New function.
4478         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4479         * stap-probe.c (stap_parse_register_operand): Call
4480         'gdbarch_stap_adjust_register'.
4481
4482 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4483
4484         PR python/24742
4485         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4486         * python/python.c (do_start_initialization): Use 'xmalloc'
4487         instead of 'PyMem_Malloc'.
4488
4489 2019-06-28  Tom Tromey  <tromey@adacore.com>
4490
4491         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4492         for Ada.
4493
4494 2019-06-27  Tom Tromey  <tromey@adacore.com>
4495
4496         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4497         objfile_key.
4498         (arm_find_mapping_symbol, arm_record_special_symbol)
4499         (_initialize_arm_tdep): Update.
4500         (arm_objfile_data_free): Remove.
4501
4502 2019-06-27  Tom Tromey  <tromey@adacore.com>
4503
4504         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4505         to cp_print_static_field.
4506
4507 2019-06-26  Tom Tromey  <tromey@adacore.com>
4508
4509         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4510         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4511         declare.
4512
4513 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4514
4515         * features/aarch64-core.c (create_feature_aarch64_core):
4516         Regenerate.
4517         * features/aarch64-core.xml: Add cpsr flags.
4518
4519 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4520
4521         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4522         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4523
4524 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4525
4526         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4527         field.
4528         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4529         use.
4530         (arm_record_special_symbol): Don't insert new symbol in sorted
4531         position, push it at the end.
4532
4533 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4534
4535         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4536         (arm_mapping_symbol_s): Remove.
4537         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4538         (arm_mapping_symbol_vec): New typedef.
4539         (struct arm_per_objfile): Add constructor.
4540         <section_maps>: Change type to
4541         std::unique_ptr<arm_mapping_symbol_vec[]>.
4542         (arm_compare_mapping_symbols): Remove.
4543         (arm_find_mapping_symbol): Adjust to section_maps type change.
4544         (arm_objfile_data_free): Call delete on arm_per_objfile.
4545         (arm_record_special_symbol): Adjust to section_maps type change.
4546         Allocate arm_per_objfile with new.
4547
4548 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4549
4550         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4551         with the command prefix.
4552
4553 2019-06-25  Tom Tromey  <tom@tromey.com>
4554
4555         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4556         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4557
4558 2019-06-25  Tom Tromey  <tom@tromey.com>
4559
4560         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4561         type.
4562         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4563         protected.
4564
4565 2019-06-25  Tom Tromey  <tom@tromey.com>
4566
4567         * tui/tui-winsource.c
4568         (tui_source_window_base::set_is_exec_point_at): Add check against
4569         LOA_ADDRESS.
4570
4571 2019-06-25  Tom Tromey  <tom@tromey.com>
4572
4573         * tui/tui-source.c (tui_set_source_content): Don't check before
4574         xfree.
4575         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4576
4577 2019-06-25  Tom Tromey  <tom@tromey.com>
4578
4579         * tui/tui-winsource.h (tui_update_source_window_as_is)
4580         (tui_alloc_source_buffer, tui_line_is_displayed)
4581         (tui_addr_is_displayed): Change type of win_info.
4582         * tui/tui-winsource.c (tui_update_source_window_as_is)
4583         (tui_clear_source_content, tui_show_source_line)
4584         (tui_show_source_content, tui_source_window_base::refill)
4585         (tui_source_window_base::set_is_exec_point_at)
4586         (tui_source_window_base::set_is_exec_point_at)
4587         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4588         (tui_alloc_source_buffer, tui_line_is_displayed)
4589         (tui_addr_is_displayed): Change type of win_info.  Update.
4590         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4591         (tui_source_window_base::do_make_visible_with_new_height):
4592         Update.
4593         * tui/tui-source.c (tui_set_source_content)
4594         (tui_set_source_content_nil)
4595         (tui_source_window::do_scroll_vertical): Update.
4596         * tui/tui-layout.c (show_layout): Update.
4597         * tui/tui-disasm.c (tui_set_disassem_content)
4598         (tui_disasm_window::do_scroll_vertical): Update.
4599         * tui/tui-data.h (tui_win_content): Remove.
4600         (struct tui_gen_win_info) <content, content_size>: Remove.
4601         (struct tui_source_element): Add initializers and destructor.
4602         (union tui_which_element, struct tui_win_element): Remove.
4603         (struct tui_source_window_base) <content>: New field.
4604         (struct tui_data_window): Remove destructor.
4605         (tui_alloc_content, tui_free_win_content)
4606         (tui_free_all_source_wins_content): Don't declare.
4607         * tui/tui-data.c (tui_initialize_static_data): Update.
4608         (init_content_element, tui_alloc_content): Remove.
4609         (~tui_gen_win_info): Update.
4610         (~tui_data_window, tui_free_all_source_wins_content)
4611         (tui_free_win_content, free_content, free_content_elements):
4612         Remove.
4613
4614 2019-06-25  Tom Tromey  <tom@tromey.com>
4615
4616         * tui/tui-winsource.h (tui_clear_source_content)
4617         (tui_erase_source_content, tui_show_source_content): Change type
4618         of win_info.
4619         * tui/tui-winsource.c (tui_clear_source_content)
4620         (tui_erase_source_content, tui_show_source_content): Change type
4621         of win_info.
4622         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4623         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4624         win_info.
4625         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4626         win_info.
4627         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4628
4629 2019-06-25  Tom Tromey  <tom@tromey.com>
4630
4631         * tui/tui-winsource.c (tui_clear_source_content)
4632         (tui_source_window_base::set_is_exec_point_at): Update.
4633         * tui/tui-source.c (tui_set_source_content_nil): Update.
4634         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4635         a bool.
4636         * tui/tui-data.c (init_content_element): Update.
4637
4638 2019-06-25  Tom Tromey  <tom@tromey.com>
4639
4640         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4641         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4642         * tui/tui-layout.c (init_and_make_win): Update.
4643         * tui/tui.h (enum tui_win_type): Update.
4644         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4645         tui_win_is_auxillary.
4646         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4647         tui_win_is_auxillary.
4648
4649 2019-06-25  Tom Tromey  <tom@tromey.com>
4650
4651         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4652         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4653         (tui_delete_data_content_windows, tui_display_all_data)
4654         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4655         Update.
4656         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4657         * tui/tui-regs.c (tui_last_regs_line_no)
4658         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4659         (tui_show_registers): Update.
4660         (tui_show_register_group): Return void.  Update.
4661         (tui_display_registers_from, tui_display_reg_element_at_line)
4662         (tui_display_registers_from_line, tui_check_register_values):
4663         Update.
4664         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4665         member.
4666         (struct tui_data_window) <regs_content>: Now a std::vector.
4667         <regs_content_count>: Remove.
4668         (tui_add_content_elements, tui_free_data_content): Don't declare.
4669         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4670         (init_content_element): Remove DATA_WIN case.  Add assert.
4671         (tui_add_content_elements): Remove.
4672         (tui_data_window): Update.
4673         (tui_free_data_content): Remove.
4674         (free_content_elements): Remove DATA_WIN case.
4675
4676 2019-06-25  Tom Tromey  <tom@tromey.com>
4677
4678         * tui/tui-data.c (tui_data_item_window): Update.
4679         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4680         * tui/tui-windata.c (tui_display_all_data)
4681         (tui_display_data_from_line): Update.
4682         (tui_check_data_values): Remove.
4683         * tui/tui-regs.c (tui_show_register_group)
4684         (tui_display_reg_element_at_line): Update.
4685         * tui/tui-hooks.c (tui_register_changed)
4686         (tui_refresh_frame_and_register_information): Call
4687         tui_check_register_values.
4688         * tui/tui-data.h (struct tui_data_window) <data_content,
4689         data_content_count, data_type>: Remove.
4690         (enum tui_data_type): Remove.
4691
4692         * tui/tui-data.c (tui_data_window::clear_detail)
4693         (~tui_data_window): Update.
4694
4695 2019-06-25  Tom Tromey  <tom@tromey.com>
4696
4697         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4698         declare.
4699         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4700         Rename from tui_first_data_item_displayed.  Update.
4701         (tui_data_window::refresh_all)
4702         (tui_data_window::do_scroll_vertical): Update.
4703         * tui/tui-data.h (struct tui_data_window)
4704         <first_data_item_displayed>: Declare new method.
4705
4706 2019-06-25  Tom Tromey  <tom@tromey.com>
4707
4708         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4709         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4710         contents...
4711         (tui_initialize_static_data): ...here.
4712
4713 2019-06-25  Tom Tromey  <tom@tromey.com>
4714
4715         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4716         (tui_display_registers_from, tui_check_register_values): Update.
4717         (tui_display_register): Remove win_info parameter; update.
4718         (tui_get_register): Change type of parameters.
4719         * tui/tui-data.h (struct tui_data_element): Remove.
4720         (union tui_which_element) <data>: Remove.
4721         <data_window>: Change type.
4722         (struct tui_data_item_window): New.
4723         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4724         case.  Add assert.
4725         (~tui_data_item_window): New destructor.
4726         (free_content_elements): Remove DATA_ITEM_WIN case.
4727
4728 2019-06-25  Tom Tromey  <tom@tromey.com>
4729
4730         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4731         Remove.
4732
4733 2019-06-25  Tom Tromey  <tom@tromey.com>
4734
4735         * tui/tui-data.h (struct tui_command_element): Remove.
4736         (union tui_which_element) <command>: Remove.
4737         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4738         assert.
4739         (free_content_elements): Remove CMD_WIN case.
4740
4741 2019-06-25  Tom Tromey  <tom@tromey.com>
4742
4743         * tui/tui-layout.c (tui_set_layout): Update.
4744         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4745         * tui/tui-data.c (layout_def): Update.
4746
4747 2019-06-25  Tom Tromey  <tom@tromey.com>
4748
4749         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4750         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4751         (tui_source_window_base::set_new_height): Update.
4752         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4753         Update.
4754         (tui_set_locator_fullname, tui_set_locator_info)
4755         (tui_show_frame_info): Update.
4756         * tui/tui-source.c (tui_set_source_content)
4757         (tui_source_is_displayed): Update.
4758         * tui/tui-layout.c (show_source_disasm_command, show_data)
4759         (show_source_or_disasm_and_command): Update.
4760         * tui/tui-disasm.c (tui_set_disassem_content)
4761         (tui_get_begin_asm_address): Update.
4762         * tui/tui-data.h (struct tui_locator_element): Remove.
4763         (union tui_which_element) <locator>: Remove.
4764         (struct tui_locator_window): New.
4765         (tui_locator_win_info_ptr): Change return type.
4766         * tui/tui-data.c (_locator): Change type.
4767         (tui_locator_win_info_ptr): Change return type.
4768         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4769         (tui_alloc_content): Add assert.
4770
4771 2019-06-25  Tom Tromey  <tom@tromey.com>
4772
4773         * tui/tui-winsource.c
4774         (tui_exec_info_window::maybe_allocate_content): New method.
4775         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4776         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4777         (make_source_or_disasm_window): Add cast.
4778         * tui/tui-data.h (union tui_which_element) <simple_string>:
4779         Remove.
4780         (struct tui_source_info): New.
4781         (struct tui_source_window_base) <execution_info>: Change type.
4782         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4783         case, and add assert.
4784         (tui_alloc_content): Add assert.
4785
4786 2019-06-25  Tom Tromey  <tom@tromey.com>
4787
4788         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4789         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4790         * tui/tui-data.c (tui_alloc_win_info): Remove.
4791
4792 2019-06-25  Tom Tromey  <tom@tromey.com>
4793
4794         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4795         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4796         can_highlight.
4797
4798 2019-06-25  Tom Tromey  <tom@tromey.com>
4799
4800         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4801         make_visible_with_new_height method.
4802         (tui_win_info::make_visible_with_new_height): New method.
4803         (tui_source_window_base::do_make_visible_with_new_height)
4804         (tui_data_window::do_make_visible_with_new_height)
4805         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4806         (make_visible_with_new_height): Remove.
4807         (tui_resize_all, tui_adjust_win_heights): Use
4808         make_visible_with_new_height method.
4809         * tui/tui-data.h (struct tui_win_info)
4810         <do_make_visible_with_new_height, make_visible_with_new_height>:
4811         New methods.
4812         (struct tui_source_window_base, struct tui_data_window)
4813         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4814         methods.
4815
4816 2019-06-25  Tom Tromey  <tom@tromey.com>
4817
4818         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4819         method.
4820         (update_tab_width): Call update_tab_width method.
4821         * tui/tui-data.h (struct tui_win_info)
4822         (struct tui_source_window_base) <update_tab_width>: New methods.
4823
4824 2019-06-25  Tom Tromey  <tom@tromey.com>
4825
4826         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4827         parameter.
4828         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4829         parameter.
4830         (tui_gen_win_info::make_visible): Update.
4831         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4832         parameter.
4833         * tui/tui-data.h (enum tui_box): New enum.
4834         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4835
4836 2019-06-25  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4839         init_and_make_win for EXEC_INFO_WIN.
4840         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4841         longer inline.
4842         (struct tui_win_info) <~tui_win_info>: Inline.
4843         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4844         Don't declare.
4845         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4846         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4847         Remove.
4848         (tui_initialize_static_data): Update.
4849         (~tui_gen_win_info): Handle more cleanup here.
4850         (~tui_source_window_base): Delete "execution_info".
4851         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4852
4853 2019-06-25  Tom Tromey  <tom@tromey.com>
4854
4855         * tui/tui-layout.c (make_command_window): Don't set
4856         can_highlight.
4857         (show_source_disasm_command): Call the reset method.
4858         (show_data): Don't set can_highlight.  Call the reset method.
4859         (tui_gen_win_info::reset): Rename from init_gen_win_info
4860         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4861         (show_source_or_disasm_and_command): Call the reset method.
4862         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4863         (struct tui_cmd_window): Set can_highlight.
4864
4865 2019-06-25  Tom Tromey  <tom@tromey.com>
4866
4867         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4868         from make_visible.
4869         (tui_make_visible, tui_make_invisible): Rewrite.
4870         (tui_win_info::make_visible): Remove.
4871         (tui_source_window_base::make_visible): Update.
4872         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4873         method.  Moved from...
4874         (struct tui_win_info) <make_visible>: ...here.
4875
4876 2019-06-25  Tom Tromey  <tom@tromey.com>
4877
4878         * tui/tui-winsource.c
4879         (tui_source_window_base::do_scroll_horizontal): Remove direction
4880         parameter.
4881         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4882         direction parameter.
4883         * tui/tui-win.c (tui_win_info::forward_scroll)
4884         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4885         (tui_win_info::right_scroll): Update.
4886         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4887         direction parameter.
4888         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4889         direction parameter.
4890         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4891         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4892         Remove direction parameter.
4893         (struct tui_source_window_base, struct tui_source_window)
4894         (struct tui_disasm_window, struct tui_data_window)
4895         (struct tui_cmd_window): Update.
4896
4897 2019-06-25  Tom Tromey  <tom@tromey.com>
4898
4899         * tui/tui-winsource.h (tui_set_exec_info_content)
4900         (tui_show_exec_info_content, tui_erase_exec_info_content)
4901         (tui_clear_exec_info_content, tui_update_exec_info): Change
4902         argument to tui_source_window_base.
4903         * tui/tui-winsource.c (tui_set_exec_info_content)
4904         (tui_show_exec_info_content, tui_erase_exec_info_content)
4905         (tui_clear_exec_info_content, tui_update_exec_info): Change
4906         argument to tui_source_window_base.
4907
4908 2019-06-25  Tom Tromey  <tom@tromey.com>
4909
4910         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4911         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4912
4913 2019-06-25  Tom Tromey  <tom@tromey.com>
4914
4915         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4916         check.
4917
4918 2019-06-25  Tom Tromey  <tom@tromey.com>
4919
4920         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4921         type to void.
4922         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4923         type to void.
4924         * tui/tui-source.c (tui_set_source_content): Update.
4925         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4926
4927 2019-06-25  Tom Tromey  <tom@tromey.com>
4928
4929         * tui/tui-win.c (window_name_completer, tui_set_focus)
4930         (tui_all_windows_info): Use name method.
4931         * tui/tui-data.h (struct tui_gen_win_info)
4932         (struct tui_source_window, struct tui_disasm_window)
4933         (struct tui_data_window, struct tui_cmd_window) <name>: New
4934         method.
4935         (tui_win_name): Don't declare.
4936         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4937         (tui_win_name): Remove.
4938
4939 2019-06-25  Tom Tromey  <tom@tromey.com>
4940
4941         * tui/tui-winsource.h (tui_update_source_window)
4942         (tui_update_source_window_as_is): Change parameter type.
4943         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4944         to be a tui_source_window_base.
4945         (tui_update_source_window_as_is): Likewise.
4946         * tui/tui-win.c (make_visible_with_new_height): Update.
4947
4948 2019-06-25  Tom Tromey  <tom@tromey.com>
4949
4950         * tui/tui-winsource.c (tui_erase_source_content)
4951         (tui_show_source_content, tui_show_exec_info_content)
4952         (tui_erase_exec_info_content): Use refresh_window method.
4953         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4954         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4955         from tui_refresh_win.
4956         (tui_data_window::refresh_window): New method.
4957         (tui_win_info::refresh, tui_source_window_base::refresh)
4958         (tui_refresh_all): Use refresh_window method.
4959         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4960         method.
4961         * tui/tui-regs.c (tui_display_register): Call refresh_window
4962         method.
4963         * tui/tui-layout.c (show_source_disasm_command)
4964         (show_source_or_disasm_and_command): Call refresh_window method.
4965         * tui/tui-data.h (struct tui_gen_win_info)
4966         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4967         New method.
4968
4969 2019-06-25  Tom Tromey  <tom@tromey.com>
4970
4971         * tui/tui.c (tui_rl_other_window, tui_enable)
4972         (tui_is_window_visible, tui_get_command_dimension): Update.
4973         * tui/tui-winsource.c (tui_update_source_window_as_is)
4974         (tui_clear_source_content, tui_erase_source_content)
4975         (tui_show_source_line, tui_source_window_base::refill)
4976         (tui_source_window_base::do_scroll_horizontal)
4977         (tui_source_window_base::set_is_exec_point_at)
4978         (tui_update_breakpoint_info, tui_set_exec_info_content)
4979         (tui_alloc_source_buffer, tui_line_is_displayed)
4980         (tui_addr_is_displayed): Update.
4981         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4982         (tui_check_and_display_highlight_if_needed)
4983         (tui_win_info::make_visible, tui_win_info::refresh)
4984         (tui_refresh_all): Update.
4985         * tui/tui-windata.c (tui_first_data_item_displayed)
4986         (tui_delete_data_content_windows, tui_erase_data_content)
4987         (tui_display_all_data, tui_data_window::refresh_all)
4988         (tui_check_data_values): Update.
4989         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4990         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4991         (tui_win_info::backward_scroll, tui_refresh_all_win)
4992         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4993         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4994         (tui_source_window_base::set_new_height)
4995         (tui_data_window::set_new_height)
4996         (make_invisible_and_set_new_height)
4997         (make_visible_with_new_height, new_height_ok)
4998         (parse_scrolling_args): Update.
4999         * tui/tui-stack.c (tui_show_frame_info): Update.
5000         * tui/tui-source.c (tui_set_source_content)
5001         (tui_set_source_content_nil, tui_source_is_displayed)
5002         (tui_source_window::do_scroll_vertical): Update.
5003         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5004         (tui_display_registers_from, tui_display_reg_element_at_line)
5005         (tui_check_register_values, tui_reg_command): Update.
5006         * tui/tui-layout.c (tui_default_win_height)
5007         (show_source_disasm_command, show_data, init_and_make_win)
5008         (show_source_or_disasm_and_command): Update.
5009         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5010         (tui_redisplay_readline, tui_mld_flush)
5011         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5012         (tui_getc): Update.
5013         * tui/tui-disasm.c (tui_set_disassem_content)
5014         (tui_disasm_window::do_scroll_vertical): Update.
5015         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5016         Now virtual.
5017         (struct tui_win_info): Derive from tui_gen_win_info.
5018         <~tui_win_info>: Mark as override.
5019         <generic>: Remove member.
5020         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5021         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5022         (~tui_data_window, ~tui_win_info)
5023         (tui_free_all_source_wins_content): Update.
5024         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5025
5026 2019-06-25  Tom Tromey  <tom@tromey.com>
5027
5028         * tui/tui-layout.c (init_and_make_win): Use new.
5029         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5030         destructor, initializers.
5031         (tui_alloc_generic_win_info): Don't declare.
5032         * tui/tui-data.c (_locator): Add argument to constructor.
5033         (source_win, disasm_win): New globals.
5034         (exec_info): Remove.
5035         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5036         Update.
5037         (tui_alloc_generic_win_info): Remove.
5038         (init_content_element): Use new.
5039         (tui_win_info::tui_win_info): Update.
5040         (free_content_elements) <case DATA_WIN>: Use delete.
5041
5042 2019-06-25  Tom Tromey  <tom@tromey.com>
5043
5044         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5045         * tui/tui-windata.c (tui_first_data_item_displayed)
5046         (tui_delete_data_content_windows): Update.
5047         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5048         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5049         (tui_display_registers_from, tui_check_register_values): Update.
5050         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5051         pointer.
5052         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5053         window.
5054         (tui_free_data_content): Update.
5055         (free_content_elements) <case DATA_WIN>: Free the window.
5056
5057 2019-06-25  Tom Tromey  <tom@tromey.com>
5058
5059         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5060         Update.
5061         * tui/tui-layout.c (make_command_window)
5062         (show_source_disasm_command, show_data, init_and_make_win)
5063         (show_source_or_disasm_and_command): Update.
5064         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5065         method.
5066         <can_highight, is_highlighted>: Now bool.
5067         (tui_set_win_highlight): Don't declare.
5068         * tui/tui-data.c (tui_set_win_highlight): Remove.
5069
5070 2019-06-25  Tom Tromey  <tom@tromey.com>
5071
5072         * tui/tui-wingeneral.c (make_visible): Remove check of window
5073         type.
5074
5075 2019-06-25  Tom Tromey  <tom@tromey.com>
5076
5077         * tui/tui-win.c (tui_win_info::max_height)
5078         (tui_cmd_window::max_height): New methods.
5079         (new_height_ok): Call max_height.
5080         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5081         <max_height>: New method.
5082
5083 2019-06-25  Tom Tromey  <tom@tromey.com>
5084
5085         * tui/tui-win.c (tui_source_window_base::set_new_height)
5086         (tui_data_window::set_new_height): New methods.
5087         (make_invisible_and_set_new_height): Call set_new_height method.
5088         * tui/tui-data.h (struct tui_win_info)
5089         (struct tui_source_window_base, struct tui_data_window)
5090         <set_new_height>: New method.
5091
5092 2019-06-25  Tom Tromey  <tom@tromey.com>
5093
5094         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5095         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5096         tui_refresh_data_win.
5097         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5098         method.
5099         (tui_refresh_all_win): Call the refresh_all method.
5100         (tui_set_focus): Likewise.
5101         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5102         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5103         Likewise.
5104
5105 2019-06-25  Tom Tromey  <tom@tromey.com>
5106
5107         * tui/tui-winsource.h (tui_refill_source_window)
5108         (tui_set_is_exec_point_at): Don't declare.
5109         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5110         (tui_source_window_base::refill): Rename from
5111         tui_refill_source_window.
5112         (tui_source_window_base::do_scroll_horizontal): Update.
5113         (tui_source_window_base::set_is_exec_point_at): Rename from
5114         tui_set_is_exec_point_at.
5115         (tui_update_all_breakpoint_info): Update.
5116         * tui/tui-stack.c (tui_show_frame_info): Update.
5117         * tui/tui-layout.c (show_data): Add cast.
5118         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5119         * tui/tui-data.h (struct tui_source_window_base) <refill,
5120         set_is_exec_point_at>: New methods.
5121         (tui_source_windows, tui_add_to_source_windows): Update types.
5122         (tui_add_to_source_windows): Remove redundant declaration.
5123         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5124         (tui_source_windows): Change return type.
5125         (tui_clear_source_windows_detail): Update.
5126         (tui_add_to_source_windows): Change type of parameter.
5127         (tui_free_all_source_wins_content): Update.
5128
5129 2019-06-25  Tom Tromey  <tom@tromey.com>
5130
5131         * tui/tui-wingeneral.c (tui_win_info::refresh)
5132         (tui_source_window_base::refresh): New methods.
5133         (tui_refresh_all): Call the refresh method.
5134         * tui/tui-data.h (struct tui_win_info)
5135         (struct tui_source_window_base) <refresh>: New method.
5136
5137 2019-06-25  Tom Tromey  <tom@tromey.com>
5138
5139         * tui/tui.h (tui_is_window_visible): Return bool.
5140         * tui/tui.c (tui_is_window_visible): Return bool.
5141         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5142         (tui_make_visible, tui_make_invisible)
5143         (tui_win_info::make_visible)
5144         (tui_source_window_base::make_visible, make_all_visible)
5145         (tui_make_all_visible, tui_make_all_invisible): Update.
5146         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5147         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5148         bool.
5149         (struct tui_win_info, struct tui_source_window_base)
5150         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5151         * tui/tui-data.c (tui_init_generic_part): Update.
5152
5153 2019-06-25  Tom Tromey  <tom@tromey.com>
5154
5155         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5156         (tui_source_window_base::make_visible): New methods.
5157         (make_all_visible): Make method call.
5158         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5159         (struct tui_source_window_base, struct tui_cmd_window): Override
5160         make_visible.
5161         (tui_win_is_source_type): Don't declare.
5162         * tui/tui-data.c (tui_win_is_source_type): Remove.
5163
5164 2019-06-25  Tom Tromey  <tom@tromey.com>
5165
5166         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5167         NULL check.
5168
5169 2019-06-25  Tom Tromey  <tom@tromey.com>
5170
5171         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5172         Inline constructor.  Add initializers for members.
5173         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5174         constructors; now inline in class.
5175
5176 2019-06-25  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-regs.c (tui_show_registers): Update.
5179         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5180         bool.
5181         * tui/tui-data.c (tui_data_window::clear_detail)
5182         (tui_data_window): Update.
5183
5184 2019-06-25  Tom Tromey  <tom@tromey.com>
5185
5186         * tui/tui-windata.c (tui_display_all_data)
5187         (tui_display_data_from_line, tui_display_data_from)
5188         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5189         Update.
5190         * tui/tui-regs.c (tui_last_regs_line_no)
5191         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5192         (tui_show_registers, tui_show_register_group)
5193         (tui_display_registers_from, tui_display_reg_element_at_line)
5194         (tui_display_registers_from_line, tui_check_register_values)
5195         (tui_reg_next, tui_reg_prev): Update.
5196         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5197         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5198         tui_data_window.
5199         (struct tui_win_info) <detail>: Remove.  Add new fields from
5200         tui_data_info.
5201         (TUI_DATA_WIN): Add cast.
5202         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5203         (~tui_data_window): Simplify.
5204
5205 2019-06-25  Tom Tromey  <tom@tromey.com>
5206
5207         * tui/tui-layout.c (show_source_disasm_command)
5208         (show_source_or_disasm_and_command): Update.
5209         * tui/tui-io.c (update_cmdwin_start_line)
5210         (tui_redisplay_readline): Update.
5211         * tui/tui-data.h (struct tui_command_info): Remove.
5212         (struct tui_win_info) <detail>: Remove command_info member.
5213         (struct tui_data_window) <start_line>: New member, from
5214         tui_command_info.
5215         (TUI_CMD_WIN): Add casts.
5216
5217 2019-06-25  Tom Tromey  <tom@tromey.com>
5218
5219         * tui/tui-winsource.c (tui_update_source_window)
5220         (tui_refill_source_window)
5221         (tui_source_window_base::do_scroll_horizontal)
5222         (tui_update_breakpoint_info, tui_set_exec_info_content)
5223         (tui_show_exec_info_content, tui_erase_exec_info_content)
5224         (tui_clear_exec_info_content): Update.
5225         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5226         Update.
5227         * tui/tui-win.c (make_invisible_and_set_new_height)
5228         (make_visible_with_new_height): Update.
5229         * tui/tui-source.c (tui_set_source_content)
5230         (tui_show_symtab_source): Update.
5231         * tui/tui-layout.c (extract_display_start_addr)
5232         (show_source_disasm_command, show_data)
5233         (make_source_or_disasm_window)
5234         (show_source_or_disasm_and_command): Update.
5235         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5236         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5237         "gdbarch".
5238         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5239         to tui_source_window_base.
5240         (struct tui_win_info) <detail>: Remove source_info member.
5241         (struct tui_source_window_base) <has_locator>: Inline.
5242         Move contents from tui_source_info; rename has_locator member to
5243         m_has_locator.
5244         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5245         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5246         header file.
5247         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5248         Simplify.
5249         (tui_free_all_source_wins_content): Cast to
5250         tui_source_window_base.
5251
5252 2019-06-25  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui-win.c (make_invisible_and_set_new_height)
5255         (make_visible_with_new_height): Call has_locator method.
5256         * tui/tui-layout.c (show_source_disasm_command, show_data)
5257         (show_source_or_disasm_and_command): Update for bool change.
5258         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5259         (tui_win_info) <has_locator>: New method.
5260         (struct tui_source_window_base) <has_locator>: New method.
5261         (tui_win_has_locator): Don't declare.
5262         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5263         from tui_win_has_locator.
5264         (tui_source_window_base): Use false, not FALSE.
5265
5266 2019-06-25  Tom Tromey  <tom@tromey.com>
5267
5268         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5269         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5270         clear_detail method directly.
5271         (tui_clear_win_detail): Remove.
5272
5273 2019-06-25  Tom Tromey  <tom@tromey.com>
5274
5275         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5276         "this", not TUI_DISASM_WIN.
5277
5278 2019-06-25  Tom Tromey  <tom@tromey.com>
5279
5280         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5281         declare.
5282         * tui/tui-winsource.c
5283         (tui_source_window_base::do_scroll_horizontal): Rename from
5284         tui_horizontal_source_scroll.
5285         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5286         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5287         from tui_vertical_data_scroll.
5288         * tui/tui-win.h (tui_scroll): Don't declare.
5289         * tui/tui-win.c (tui_win_info::forward_scroll)
5290         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5291         (tui_win_info::right_scroll): Rename and update.
5292         (tui_scroll_forward_command, tui_scroll_backward_command)
5293         (tui_scroll_left_command, tui_scroll_right_command): Update.
5294         (tui_scroll): Remove.
5295         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5296         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5297         from tui_vertical_source_scroll.
5298         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5299         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5300         from tui_vertical_disassem_scroll.
5301         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5302         do_scroll_horizontal>: New methods.
5303         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5304         Likewise.
5305         (struct tui_source_window_base): Add do_scroll_horizontal.
5306         (struct tui_source_window, struct tui_disasm_window): Add
5307         do_scroll_vertical.
5308         (struct tui_data_window, struct tui_cmd_window): Add
5309         do_scroll_horizontal and do_scroll_vertical.
5310         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5311
5312 2019-06-25  Tom Tromey  <tom@tromey.com>
5313
5314         * tui/tui-data.h (struct tui_source_window_base): New struct.
5315         (struct tui_source_window): Derive from tui_source_window_base.
5316         (struct tui_disasm_window): New struct.
5317         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5318         from tui_source_window::clear_detail.
5319         (tui_source_window_base): Rename from tui_source_window.
5320         (~tui_source_window_base): Rename from ~tui_source_window.
5321         (tui_alloc_win_info): Create a tui_disasm_window.
5322
5323 2019-06-25  Tom Tromey  <tom@tromey.com>
5324
5325         * tui/tui-data.h (struct tui_source_window)
5326         (struct tui_data_window): Declare destructors.
5327         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5328         destructors.
5329         (tui_win_info): Simplify.
5330
5331 2019-06-25  Tom Tromey  <tom@tromey.com>
5332
5333         * tui/tui-winsource.c (tui_display_main)
5334         (tui_update_source_windows_with_addr)
5335         (tui_update_all_breakpoint_info): Update.
5336         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5337         (new_height_ok, parse_scrolling_args): Update.
5338         * tui/tui-stack.c (tui_show_frame_info): Update.
5339         * tui/tui-data.h (struct tui_list): Remove.
5340         (tui_source_windows): Return a reference to a std::vector.
5341         * tui/tui-data.c (source_windows): Now a std::vector.
5342         (tui_source_windows): Change return type.
5343         (tui_clear_source_windows): Rewrite.
5344         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5345         (tui_free_all_source_wins_content): Rewrite.
5346
5347 2019-06-25  Tom Tromey  <tom@tromey.com>
5348
5349         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5350         (struct tui_data_window, struct tui_cmd_window): Declare
5351         clear_detail method.
5352         * tui/tui-data.c (tui_source_window::clear_detail)
5353         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5354         methods.
5355         (tui_clear_win_detail): Simplify.
5356
5357 2019-06-25  Tom Tromey  <tom@tromey.com>
5358
5359         * tui/tui-layout.c (make_source_window, make_disasm_window)
5360         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5361         Return the new window.
5362         (show_source_disasm_command, show_data)
5363         (show_source_or_disasm_and_command): Update.
5364
5365 2019-06-25  Tom Tromey  <tom@tromey.com>
5366
5367         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5368         parameter.  Return the new window.
5369         (show_source_disasm_command): Update and remove NULL check.
5370         (show_source_or_disasm_and_command): Update.
5371
5372 2019-06-25  Tom Tromey  <tom@tromey.com>
5373
5374         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5375
5376 2019-06-25  Tom Tromey  <tom@tromey.com>
5377
5378         * tui/tui-data.h (struct tui_win_info): Make constructor
5379         protected.  Make destructor virtual.  Add initializers.
5380         (tui_source_window, tui_data_window, tui_cmd_window): New
5381         classes.
5382         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5383         constructor.  Add "type" parameter.
5384         (tui_source_window, tui_data_window, tui_cmd_window): New
5385         constructors.
5386         (tui_alloc_win_info): Instantiate the appropriate subclass.
5387
5388 2019-06-25  Tom Tromey  <tom@tromey.com>
5389
5390         * tui/tui-win.c (tui_resize_all): Use delete.
5391         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5392         destructor.
5393         (tui_free_window): Don't declare.
5394         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5395         Update.
5396
5397 2019-06-25  Tom Tromey  <tom@tromey.com>
5398
5399         * tui/tui-data.h (struct tui_win_info): Add constructor.
5400         * tui/tui-data.c (tui_alloc_win_info): Use new.
5401         (tui_free_window): Use delete.
5402
5403 2019-06-22  Tom Tromey  <tom@tromey.com>
5404
5405         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5406         declare.
5407         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5408
5409 2019-06-22  Tom Tromey  <tom@tromey.com>
5410
5411         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5412         declare.
5413         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5414
5415 2019-06-22  Tom de Vries  <tdevries@suse.de>
5416
5417         * dwarf2read.c (create_addrmap_from_aranges)
5418         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5419         instead of '%zu'.
5420
5421 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5422
5423         * dwarf2read.h (dwarf2_section_info_def): Remove.
5424         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5425         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5426         std::vector<dwarf2_section_info>.
5427         (struct dwo_file) <~dwo_file>: Remove.
5428         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5429         types field.
5430         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5431         (dwarf2_read_debug_names): Likewise.
5432         (create_debug_types_hash_table): Change parameter type to
5433         array_view, adjust code accordingly.
5434         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5435         (partial_die_info::fixup): Likewise.
5436         (determine_prefix): Likewise.
5437         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5438
5439 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5440
5441         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5442         gdb_bfd_ref_ptr.
5443         <~dwo_file>: Remove call to gdb_bfd_unref.
5444         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5445         gdb_bfd_ref_ptr::get.
5446
5447 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5448
5449         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5450         type to htab_up.
5451         * dwarf2read.c (struct dwo_file): Initialize fields.
5452         <~dwo_file>: New.
5453         (free_dwo_file): Remove, move content to ~dwo_file.
5454         (struct dwo_file_deleter): Remove.
5455         (dwo_file_up>: Remove custom deleter.
5456         (free_dwo_files): Remove.
5457         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5458         dwo_files.
5459         (process_skeletonless_type_units): Call unique_ptr::get.
5460         (allocate_dwo_file_hash_table): Add deleter to created hash
5461         table.  Change return type to htab_up.
5462         (lookup_dwo_file_slot): Don't memset dwo_file, call
5463         unique_ptr::get.
5464         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5465         (create_dwo_unit_in_dwp_v2): Likewise.
5466         (open_and_init_dwo_file): Likewise.
5467         (free_dwo_file_from_slot): Remove.
5468
5469 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5470
5471         * dwarf2read.h (struct dwarf2_section_info) <readin,
5472         is_virtual>: Change type to bool.
5473         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5474         true instead of 1.
5475
5476 2019-06-19  Tom Tromey  <tom@tromey.com>
5477
5478         * tui/tui-data.h (tui_init_content_element): Don't declare.
5479
5480 2019-06-19  Tom Tromey  <tom@tromey.com>
5481
5482         * tui/tui-data.h (tui_init_win_info): Don't declare.
5483
5484 2019-06-19  Tom de Vries  <tdevries@suse.de>
5485
5486         * dwarf2read.h (abstract_to_concrete): Change type to
5487         std::unordered_map<sect_offset, std::vector<sect_offset>,
5488         gdb::hash_enum<sect_offset>>.
5489
5490 2019-06-19  Tom Tromey  <tromey@adacore.com>
5491
5492         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5493         EVAL_AVOID_SIDE_EFFECTS specially.
5494
5495 2019-06-19  Tom Tromey  <tromey@adacore.com>
5496
5497         * source-cache.c (highlighter): New global.
5498         (source_cache::get_source_lines): Create a highlighter on demand.
5499
5500 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5501
5502         * defs.h (deprecated_interactive_hook): Delete declaration.
5503         * interps.c (clear_interpreter_hooks): Remove use of
5504         deprecated_interactive_hook.
5505         * top.c (deprecated_interactive_hook): Delete definition.
5506         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5507
5508 2019-06-18  Tom de Vries  <tdevries@suse.de>
5509
5510         PR gdb/24515
5511         * dwarf2read.h (abstract_to_concrete): Change type from
5512         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5513         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5514         * dwarf2read.c (read_variable): Update.
5515         (dwarf2_fetch_die_loc_sect_off): Update.
5516
5517 2019-06-17  Tom de Vries  <tdevries@suse.de>
5518
5519         PR gdb/24617
5520         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5521         accessing parent[parent_len - 1].
5522
5523 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5524
5525         PR gdb/24364
5526         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5527         call dtrace_process_dof with NULL dof.
5528
5529 2019-06-16  Tom de Vries  <tdevries@suse.de>
5530
5531         PR gdb/24445
5532         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5533
5534 2019-06-16  Tom Tromey  <tom@tromey.com>
5535
5536         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5537         (make_all_visible): Use address of member.
5538
5539 2019-06-16  Tom Tromey  <tom@tromey.com>
5540
5541         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5542         (tui_free_window, free_content, free_content_elements): Remove
5543         unnecessary cast.
5544         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5545         cast.
5546         * tui/tui-regs.c (tui_show_register_group)
5547         (tui_display_registers_from, tui_display_reg_element_at_line):
5548         Remove unnecessary cast.
5549
5550 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5551
5552         * linux-nat.c (normal_mask): Delete.
5553         (_initialize_linux_nat): Don't initialise normal_mask.
5554
5555 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5556
5557         PR gdb/24445
5558         * dwarf-index-write.h (write_psymtabs_to_index): Add
5559         dwz_basename parameter.
5560         * dwarf-index-write.c (write_gdbindex): Move file writing to
5561         write_gdbindex_1.  Change return type void.
5562         (assert_file_size): Move up, remove filename parameter.
5563         (write_gdbindex_1): New function.
5564         (write_debug_names): Change return type to void, call
5565         assert_file_size.
5566         (struct index_wip_file): New struct.
5567         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5568         file logic to index_wip_file.  Write index for dwz file if
5569         needed.
5570         (save_gdb_index_command): Pass basename of dwz file, if present.
5571         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5572         build-id of dwz file, if present.
5573         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5574         (dwarf2_get_dwz_file): Likewise.
5575         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5576         (dwarf2_get_dwz_file): Likewise.
5577
5578 2019-06-16  Tom Tromey  <tom@tromey.com>
5579
5580         * coffread.c (process_coff_symbol): Use xstrdup.
5581         * value.c (create_internalvar): Use xstrdup.
5582
5583 2019-06-16  Tom Tromey  <tom@tromey.com>
5584
5585         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5586         * breakpoint.c (stopin_command, stopat_command)
5587         (until_break_command, decode_location_default): Remove unnecessary
5588         cast.
5589         * utils.c (subset_compare): Remove unnecessary cast.
5590         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5591         cast.
5592         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5593         cast.
5594         * infcmd.c (path_command): Remove unnecessary cast.
5595         * coffread.c (decode_type): Remove unnecessary cast.
5596         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5597         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5598         * tui/tui-stack.c (tui_show_locator_content)
5599         (tui_show_frame_info): Remove unnecessary cast.
5600         * tui/tui-win.c (tui_scroll_forward_command)
5601         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5602         (parse_scrolling_args): Remove unnecessary cast.
5603         * tui/tui-data.c (init_win_info, tui_del_window)
5604         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5605         (free_content_elements): Remove unnecessary cast.
5606         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5607         unnecessary cast.
5608         * tui/tui-source.c (tui_set_source_content)
5609         (tui_vertical_source_scroll): Remove unnecessary cast.
5610         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5611         cast.
5612         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5613         * tui/tui-regs.c (tui_display_registers_from)
5614         (tui_display_register): Remove unnecessary cast.
5615         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5616         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5617         (make_visible): Remove unnecessary cast.
5618         * tui/tui-winsource.c (tui_erase_source_content)
5619         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5620         unnecessary cast.
5621         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5622         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5623         * stabsread.c (read_type, read_array_type, read_range_type):
5624         Remove unnecessary cast.
5625         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5626         (parse_symbol, parse_type, upgrade_type, parse_external)
5627         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5628         unnecessary cast.
5629         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5630
5631 2019-06-16  Tom Tromey  <tom@tromey.com>
5632
5633         * tui/tui-data.c (tui_alloc_generic_win_info)
5634         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5635         checks.
5636
5637 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5638             Andrew Burgess  <andrew.burgess@embecosm.com>
5639
5640         * f-typeprint.c (f_print_type): Don't return early for not
5641         associated or not allocated types.
5642         (f_type_print_varspec_suffix): Add print_rank parameter and print
5643         ranks of array types in case they dangling.
5644         (f_type_print_base): Add print_rank parameter.
5645
5646 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5647
5648         * NEWS: Mention new MI commands.
5649         * break-catch-throw.c (enum exception_event_kind): Move to
5650         breakpoint.h.
5651         (print_mention_exception_catchpoint): Output text as a single
5652         message.
5653         (catch_exception_command_1): Rename to...
5654         (catch_exception_event): ...this, make non-static, update header
5655         command, and change some parameter types.
5656         (catch_catch_command): Update for changes to
5657         catch_exception_command_1.
5658         (catch_throw_command): Likewise.
5659         (catch_rethrow_command): Likewise.
5660         * breakpoint.c (enum exception_event_kind): Delete.
5661         * breakpoint.h (enum exception_event_kind): Moved here from
5662         break-catch-throw.c.
5663         (catch_exception_event): Declare.
5664         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5665         (mi_cmd_catch_throw): New function.
5666         (mi_cmd_catch_rethrow): New function.
5667         (mi_cmd_catch_catch): New function.
5668         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5669         'catch-catch' entries.
5670         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5671         (mi_cmd_catch_rethrow): Declare.
5672         (mi_cmd_catch_catch): Declare.
5673
5674 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5675
5676         * annotate.c (annotate_source_line): Change return type to void,
5677         update implementation to match.
5678         * annotate.h (annotate_source_line): Change return type to void,
5679         update header comment.
5680         * stack.c (print_frame_info): Don't change what frame information
5681         is printed based on whether annotations are on or not.
5682
5683 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5684
5685         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5686         (annotate_source): Make static.
5687         (annotate_source_line): Moved from source.c and renamed from
5688         identify_source_line.  Update the return type.
5689         * annotate.h (annotate_source): Delete declaration.
5690         (annotate_source_line): Declaration moved from source.h, and
5691         renamed from identify_source_line.  Return type updated.
5692         * source.c (identify_source_line): Moved to annotate.c and renamed
5693         to annotate_source_line.
5694         (info_line_command): Remove check of annotation_level.
5695         * source.h (identify_source_line): Move declaration to annotate.h
5696         and rename to annotate_source_line.
5697         * stack.c: Add 'annotate.h' include.
5698         (print_frame_info): Remove check of annotation_level before
5699         calling annotate_source_line.
5700
5701 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5702
5703         * source-cache.c (source_cache::get_plain_source_lines): Use
5704         open_source_file_with_line_charpos instead of just
5705         open_source_file, remove call to find_source_lines.
5706         (source_cache::get_source_lines): Likewise.
5707         * source.c (find_source_lines): Make static.
5708         (get_filename_and_charpos): Renamed into...
5709         (open_source_file_with_line_charpos): ..this along with changes to
5710         return a scoped_fd, and some other minor clean ups.
5711         (identify_source_line): Use open_source_file_with_line_charpos.
5712         (search_command_helper): Use open_source_file_with_line_charpos
5713         instead of just open_source_file, remove call to
5714         find_source_lines.
5715         * source.h (open_source_file_with_line_charpos): Declare new
5716         function.
5717         (find_source_lines): Delete declaration.
5718
5719 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5720
5721         * source.c (get_filename_and_charpos): Remove fullname
5722         parameter.
5723         (identify_source_line): Update call to get_filename_and_charpos.
5724
5725 2019-06-14  Tom Tromey  <tromey@adacore.com>
5726
5727         PR gdb/24502:
5728         * ui-style.h (skip_ansi_escape): Update comment.
5729         * ui-file.h (class no_terminal_escape_file): New class.
5730         * ui-file.c (no_terminal_escape_file::write)
5731         (no_terminal_escape_file::puts): New methods.
5732         * cli/cli-logging.c (handle_redirections): Use
5733         no_terminal_escape_file.
5734
5735 2019-06-14  Tom Tromey  <tromey@adacore.com>
5736
5737         * NEWS: Move convenience variable news above Python news.
5738
5739 2019-06-14  Tom Tromey  <tom@tromey.com>
5740
5741         * gnulib: Move directory to top-level.
5742         * configure.ac: Don't configure gnulib.
5743         * configure: Rebuild.
5744         * common/common-defs.h: Use new path to gnulib.
5745         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5746         (GNULIB_H): Remove.
5747         (INCGNU): Look in new gnulib location.
5748         (HFILES_NO_SRCDIR): Remove gnulib files.
5749         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5750         (generated_files): Remove GNULIB_H.
5751         ($(LIBGNU), all-lib): Remove targets.
5752         (distclean): Don't mention GNULIB_BUILDDIR.
5753         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5754
5755 2019-06-14  Tom Tromey  <tromey@adacore.com>
5756
5757         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5758         Warn if symbol file does not provide any symbols.
5759
5760 2019-06-14  Tom Tromey  <tromey@adacore.com>
5761
5762         * source.c (find_and_open_source): Respect basenames_may_differ.
5763
5764 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5765
5766         * annotate.c (annotate_breakpoints_invalid): Make use of
5767         scoped_restore_terminal_state.
5768         (annotate_frames_invalid): Likewise.
5769
5770 2019-06-14  Tom Tromey  <tromey@adacore.com>
5771
5772         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5773         allow assignment to an internalvar.
5774
5775 2019-06-14  Tom Tromey  <tromey@adacore.com>
5776
5777         * ada-lex.l: Allow "_" in attribute names.
5778
5779 2019-06-14  Tom Tromey  <tromey@adacore.com>
5780
5781         PR gdb/24653:
5782         * regcache.c (registers_changed): Don't call alloca.
5783         * top.c (execute_command): Don't call alloca.
5784
5785 2019-06-13  Pedro Alves  <palves@redhat.com>
5786
5787         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5788         'expression'.  When parsing an expression, error out if there's
5789         junk after "unlimited".
5790         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5791         (do_set_command): Adjust calls to is_unlimited_literal.
5792
5793 2019-06-13  Pedro Alves  <palves@redhat.com>
5794
5795         * compile/compile.c (make_compile_options_def_group): Add braces
5796         around array_view initializer.
5797         * thread.c (make_thread_apply_all_options_def_group)
5798         (make_thread_apply_all_options_def_group): Likewise.
5799
5800 2019-06-13  Pedro Alves  <palves@redhat.com>
5801
5802         * NEWS (New commands): Mention "maint test-options
5803         require-delimiter", "maint test-options unknown-is-error", "maint
5804         test-options unknown-is-operand" and "maint show
5805         test-options-completion-result".
5806         (New command options, command completion): New section.
5807         (Completion improvements): New section.
5808         Mention that you can abbreviate "unlimited".
5809
5810 2019-06-13  Pedro Alves  <palves@redhat.com>
5811
5812         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5813         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5814         * unittests/cli-utils-selftests.c (test_parse_flags)
5815         (test_parse_flags_qcs): Delete.
5816         (test_cli_utils): Don't call deleted functions.
5817
5818 2019-06-13  Pedro Alves  <palves@redhat.com>
5819
5820         * thread.c: Include "cli/cli-option.h".
5821         (tp_array_compar_ascending): Global.
5822         (tp_array_compar): Delete function.
5823         (tp_array_compar_ascending, tp_array_compar_descending): New
5824         functions.
5825         (ascending_option_def, qcs_flag_option_def)
5826         (thr_qcs_flags_option_defs)
5827         (make_thread_apply_all_options_def_group)
5828         (make_thread_apply_options_def_group): New.
5829         (thread_apply_all_command): Use gdb::option::process_options.
5830         (thread_apply_command_completer)
5831         (thread_apply_all_command_completer): New.
5832         (thread_apply_command): Use gdb::option::process_options.
5833         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5834         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5835         to generate help text of "thread apply".  Adjust "taas"'s help.
5836         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5837         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5838
5839 2019-06-13  Pedro Alves  <palves@redhat.com>
5840
5841         * thread.c (thread_apply_command): Check for invalid TID with
5842         isdigit instead of !isalpha.
5843
5844 2019-06-13  Pedro Alves  <palves@redhat.com>
5845
5846         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5847         (validate_flags_qcs): New.
5848         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5849         (validate_flags_qcs): Declare.
5850         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5851         (make_frame_apply_options_def_group): New.
5852         (frame_apply_command_count): Process options with
5853         gdb::option::process_options.
5854         (frame_apply_completer): New.
5855         (frame_apply_level_completer, frame_apply_all_completer)
5856         (frame_apply_completer): New.
5857         (_initialize_stack): Update help of "frame apply", "frame apply
5858         level", "frame apply all" and "faas" to mention supported options
5859         and install command completers.
5860         * stack.h (frame_apply_all_completer): Declare.
5861         * thread.c: Include "stack.h".
5862         (tfaas_command): Add "--".
5863         (_initialize_thread): Update help "tfaas" to mention supported
5864         options and install command completer.
5865
5866 2019-06-13  Pedro Alves  <palves@redhat.com>
5867
5868         * completer.c (complete_nested_command_line): New.
5869         (gdb_completion_word_break_characters_throw): Add assertion.
5870         * completer.h (complete_nested_command_line): Declare.
5871
5872 2019-06-13  Pedro Alves  <palves@redhat.com>
5873
5874         * stack.c (parse_backtrace_qualifiers): New.
5875         (backtrace_command): Use it.
5876         (backtrace_command_completer): Complete on qualifiers.
5877
5878 2019-06-13  Pedro Alves  <palves@redhat.com>
5879
5880         * frame.c: Include "cli/cli-option.h.
5881         (user_set_backtrace_options): New.
5882         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5883         Delete.
5884         (get_prev_frame): Adjust.
5885         (boolean_option_def, uinteger_option_def)
5886         (set_backtrace_option_defs): New.
5887         (_initialize_frame): Adjust and use
5888         gdb::option::add_setshow_cmds_for_options to install "set
5889         backtrace past-main" and "set backtrace past-entry".
5890         * frame.h: Include "cli/cli-option.h".
5891         (struct frame_print_options): Forward declare.
5892         (print_frame_arguments_all, print_frame_arguments_scalars)
5893         (print_frame_arguments_none): Declare.
5894         (print_entry_values): Delete declaration.
5895         (struct frame_print_options, user_frame_print_options): New.
5896         (struct set_backtrace_options): New.
5897         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5898         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5899         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5900         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5901         (list_args_or_locals): Add frame_print_options parameter.
5902         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5903         * python/py-framefilter.c (enumerate_args): Pass down
5904         USER_FRAME_PRINT_OPTIONS.
5905         * stack.c: Include "cli/cli-option.h".
5906         (print_frame_arguments_all, print_frame_arguments_scalars)
5907         (print_frame_arguments_none): Declare.
5908         (print_raw_frame_arguments, print_entry_values): Delete.
5909         (user_frame_print_options): New.
5910         (boolean_option_def, enum_option_def, frame_print_option_defs):
5911         New.
5912         (struct backtrace_cmd_options): New.
5913         (bt_flag_option_def): New.
5914         (backtrace_command_option_defs): New.
5915         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5916         (print_frame_arg, read_frame_arg, print_frame_args)
5917         (print_frame_info, print_frame): Add frame_print_options parameter
5918         and use it.
5919         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5920         (backtrace_command_1): Add frame_print_options and
5921         backtrace_cmd_options parameters and use them.
5922         (make_backtrace_options_def_group): New.
5923         (backtrace_command): Process command options with
5924         gdb::option::process_options.
5925         (backtrace_command_completer): New.
5926         (_initialize_stack): Extend "backtrace"'s help to mention
5927         supported options.  Install completer for "backtrace".
5928         Install some settings commands with add_setshow_cmds_for_options.
5929
5930 2019-06-13  Pedro Alves  <palves@redhat.com>
5931
5932         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5933         and that "set/show print raw frame-arguments" are now deprecated.
5934
5935         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5936         command.
5937         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5938         * stack.c (_initialize_stack): Install "set/show print
5939         raw-frame-arguments", and deprecate "set/show print raw
5940         frame-arguments".
5941         * valprint.c (_initialize_valprint): Deprecate "set/show print
5942         raw".
5943
5944 2019-06-13  Pedro Alves  <palves@redhat.com>
5945
5946         * compile/compile.c (struct compile_options): New.
5947         (compile_flag_option_def, compile_command_option_defs)
5948         (make_compile_options_def_group): New.
5949         (compile_file_command): Handle options with
5950         gdb::option::process_options.
5951         (compile_file_command_completer): New function.
5952         (compile_code_command): Handle options with
5953         gdb::option::process_options.
5954         (compile_code_command_completer): New function.
5955         (_initialize_compiler): Install completers for "compile code" and
5956         "compile file".  Mention available options in "compile code" and
5957         "compile code"'s help.
5958         * completer.c (advance_to_completion_word): New, factored out from
5959         ...
5960         (advance_to_expression_complete_word_point): ... this.
5961         (advance_to_filename_complete_word_point): New.
5962         * completer.h (advance_to_filename_complete_word_point): New
5963         declaration.
5964
5965 2019-06-13  Pedro Alves  <palves@redhat.com>
5966
5967         * compile/compile.c: Include "cli/cli-option.h".
5968         (compile_print_value): Scope data pointer is now a
5969         value_print_options pointer; adjust.
5970         (compile_print_command): Process options.  Scope data pointer is
5971         now a value_print_options pointer; adjust.
5972         (_initialize_compile): Update "compile print"'s help to include
5973         supported options.  Install a completer for "compile print".
5974         * cp-valprint.c (show_vtblprint, show_objectprint)
5975         (show_static_field_print): Delete.
5976         (_initialize_cp_valprint): Don't install "set print
5977         static-members", "set print vtbl", "set print object" here.
5978         * printcmd.c: Include "cli/cli-option.h" and
5979         "common/gdb_optional.h".
5980         (print_command_parse_format): Rework to fill in a
5981         value_print_options instead of a format_data.
5982         (print_value): Change parameter type from format_data pointer to
5983         value_print_options reference.  Adjust.
5984         (print_command_1): Process options.  Adjust to pass down a
5985         value_print_options.
5986         (print_command_completer): New.
5987         (_initialize_printcmd): Install print_command_completer as
5988         handle_brkchars completer for the "print" command.  Update
5989         "print"'s help to include supported options.
5990         * valprint.c: Include "cli/cli-option.h".
5991         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5992         here from cp-valprint.c.
5993         (boolean_option_def, uinteger_option_def)
5994         (value_print_option_defs, make_value_print_options_def_group):
5995         New.  Use gdb::option::add_setshow_cmds_for_options to install
5996         "set print elements", "set print null-stop", "set print repeats",
5997         "set print pretty", "set print union", "set print array", "set
5998         print address", "set print symbol", "set print array-indexes".
5999         * valprint.h: Include <string> and "cli/cli-option.h".
6000         (make_value_print_options_def_group): Declare.
6001         (print_value): Change parameter type from format_data pointer to
6002         value_print_options reference.
6003         (print_command_completer): Declare.
6004
6005 2019-06-13  Pedro Alves  <palves@redhat.com>
6006
6007         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6008         (COMMON_SFILES): Add maint-test-settings.c.
6009         * cli/cli-decode.c (boolean_enums): New global, factored out from
6010         ...
6011         (add_setshow_boolean_cmd): ... here.
6012         * cli/cli-decode.h (boolean_enums): Declare.
6013         * cli/cli-option.c: New file.
6014         * cli/cli-option.h: New file.
6015         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6016         factored out from ...
6017         (parse_cli_boolean_value(const char *)): ... this.
6018         (is_unlimited_literal): Change parameter type to pointer to
6019         pointer.  Adjust and advance ARG pointer.
6020         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6021         (parse_cli_var_enum): New, factored out from ...
6022         (do_set_command): ... this.  Adjust.
6023         * cli/cli-setshow.h (parse_cli_boolean_value)
6024         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6025         (parse_cli_var_enum): Declare.
6026         * cli/cli-utils.c: Include "cli/cli-option.h".
6027         (get_ulongest): New.
6028         * cli/cli-utils.h (get_ulongest): Declare.
6029         (check_for_argument): New overloads.
6030         * maint-test-options.c: New file.
6031
6032 2019-06-13  Pedro Alves  <palves@redhat.com>
6033
6034         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6035         parse a range if "-" is at the end of the string.
6036
6037 2019-06-13  Pedro Alves  <palves@redhat.com>
6038
6039         * cli/cli-setshow.c (parse_auto_binary_operation)
6040         (parse_cli_boolean_value): Don't allow "o".
6041
6042 2019-06-13  Pedro Alves  <palves@redhat.com>
6043
6044         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6045         * NEWS: Mention maint test-settings KIND.
6046         * maint-test-settings.c: New file.
6047
6048 2019-06-13  Pedro Alves  <palves@redhat.com>
6049
6050         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6051         completer.
6052         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6053         "set" completers.
6054
6055 2019-06-13  Pedro Alves  <palves@redhat.com>
6056
6057         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6058         after item.
6059
6060 2019-06-13  Pedro Alves  <palves@redhat.com>
6061
6062         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6063
6064 2019-06-13  Pedro Alves <palves@redhat.com>
6065
6066         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6067         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6068         call.
6069         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6070         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6071         calls.
6072         (check_for_argument): Skip spaces after argument.
6073
6074 2019-06-13  Pedro Alves  <palves@redhat.com>
6075
6076         * thread.c (thread_apply_command): Adjust TID parsing.
6077         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6078         detected before end of string.
6079         (tid_is_in_list): Error out if LIST is invalid.
6080
6081 2019-06-13  Pedro Alves  <palves@redhat.com>
6082
6083         * completer.c (complete_line_internal_1): Rewind completion word
6084         point.
6085         (completion_tracker::advance_custom_word_point_by): Change
6086         parameter type to int.
6087         * completer.h (completion_tracker::advance_custom_word_point_by):
6088         Likewise.
6089
6090 2019-06-13  Pedro Alves  <palves@redhat.com>
6091
6092         * completer.c (advance_to_completion_word): Handle delimiters.
6093
6094 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6095
6096         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6097
6098 2019-06-11  Tom Tromey  <tom@tromey.com>
6099
6100         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6101         (xmalloc_failed): Move to alloc.c.
6102         * alloc.c: New file.
6103         * Makefile.in (COMMON_SFILES): Add alloc.c.
6104
6105 2019-06-11  Tom Tromey  <tom@tromey.com>
6106
6107         * nat/linux-waitpid.c: Don't include server.h.
6108         (linux_debug): Remove.
6109         (my_waitpid): Update.
6110
6111 2019-06-11  Tom Tromey  <tromey@adacore.com>
6112
6113         * infcall.c (_initialize_infcall): Remove trailing newline from
6114         help.
6115         * user-regs.c (_initialize_user_regs): Remove trailing newline
6116         from help.
6117         * typeprint.c (_initialize_typeprint): Remove trailing newline
6118         from help.
6119         * reverse.c (_initialize_reverse): Remove trailing newlines from
6120         help.
6121         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6122         from help.
6123         * language.c (add_set_language_command): Remove trailing newline
6124         from help.
6125         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6126         help.
6127         * disasm.c (_initialize_disasm): Remove trailing newline from
6128         help.
6129         * top.c (init_main): Remove trailing newline from help.
6130         * interps.c (_initialize_interpreter): Remove trailing newline
6131         from help.
6132         * btrace.c (_initialize_btrace): Remove trailing newlines from
6133         help.
6134         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6135         from help.
6136         * python/python.c (_initialize_python): Remove trailing newline
6137         from help.
6138         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6139         help.
6140         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6141         from help.  Reformat some text.
6142         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6143         from help.
6144         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6145         newline from help.
6146
6147 2019-06-11  Tom Tromey  <tromey@adacore.com>
6148
6149         * darwin-nat.c (darwin_decode_exception_message)
6150         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6151
6152 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6153
6154         * valops.c (value_slice): Check for not allocated or not
6155         associated values.
6156
6157 2019-06-10  Tom de Vries  <tdevries@suse.de>
6158
6159         PR gdb/24618
6160         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6161         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6162         invalid.
6163
6164 2019-06-10  Tom de Vries  <tdevries@suse.de>
6165
6166         PR gdb/24611
6167         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6168         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6169
6170 2019-06-10  Tom de Vries  <tdevries@suse.de>
6171
6172         PR symtab/24545
6173         * symtab.c (struct demangled_name_entry): Add language field.
6174         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6175         static minimal symbol".  Set and use language field.
6176
6177 2019-06-10  Tom Tromey  <tromey@adacore.com>
6178
6179         * ada-lang.c (_initialize_ada_language): Update help text.
6180
6181 2019-06-10  Tom Tromey  <tromey@adacore.com>
6182
6183         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6184         with a newline.
6185         * guile/guile.c (handle_boot_error): Don't end warning with a
6186         newline.
6187         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6188         warning with a newline.
6189         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6190         newline.
6191         (s12z_frame_cache): Likewise.
6192         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6193         a newline.
6194         * solib-svr4.c (disable_probes_interface): Don't end warning with
6195         a newline.
6196         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6197         newline.
6198         * python/python.c (do_finish_initialization): Don't end warning
6199         with a newline.
6200
6201 2019-06-10  Tom Tromey  <tom@tromey.com>
6202
6203         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6204         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6205         gdbpy_enter.
6206
6207 2019-06-10  Tom Tromey  <tromey@adacore.com>
6208
6209         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6210         data.
6211         (elf_new_init): Don't call stabsread_new_init.
6212         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6213         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6214         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6215
6216 2019-06-10  Tom de Vries  <tdevries@suse.de>
6217
6218         PR symtab/16264
6219         PR symtab/24517
6220         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6221
6222 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6223
6224         * source.c (find_and_open_source): Also rewrite relative file
6225         names.
6226
6227 2019-04-26  Amos Bird  <amosbird@gmail.com>
6228
6229         * annotate.c (annotate_thread_exited): Add "thread-exited"
6230         annotation.
6231
6232 2019-06-06  Tom Tromey  <tromey@adacore.com>
6233
6234         * maint.h (class scoped_command_stats): Use
6235         DISABLE_COPY_AND_ASSIGN.
6236         <print_time>: New method.
6237         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6238         print_time.
6239         (scoped_command_stats::print_time): New method.
6240
6241 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6242
6243         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6244         instructions of lengths 6 or 8 bytes.
6245
6246 2019-06-04  Pedro Alves  <palves@redhat.com>
6247
6248         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6249
6250         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6251         * breakpoint.c (condition_completer): Likewise.
6252         * cli/cli-dump.c (scan_expression): Likewise.
6253         * common/filestuff.c (mkdir_recursive): Likewise.
6254         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6255         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6256         (gdb_abspath): Likewise.
6257         * compile/compile-cplus-types.c
6258         (compile_cplus_instance::decl_name): Likewise.
6259         * completer.c (complete_explicit_location):
6260         (signal_completer, reg_or_group_completer_1): Likewise.
6261         * cp-support.c (cp_remove_params_if_any): Likewise.
6262         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6263         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6264         * infcmd.c (strip_bg_char): Likewise.
6265         * linespec.c (copy_token_string): Likewise.
6266         * mi/mi-main.c (output_cores): Likewise.
6267         * psymtab.c (psymtab_search_name):
6268         * symfile.c (test_set_ext_lang_command): Likewise.
6269         * target.c (target_fileio_read_stralloc): Likewise.
6270         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6271         * value.c (complete_internalvar): Likewise.
6272
6273 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6274
6275         Add objfile property to gdb.Type.
6276         * NEWS: Mention Python API addition.
6277         * python/py-type.c (typy_get_objfile): New method.
6278
6279 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6280
6281         * NEWS: Mention the new set|show style [title|highlight].
6282         Mention changes to "show style", "help" and "apropos".
6283
6284 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6285
6286         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6287         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6288         instead of print_help_for_command.
6289         (print_doc_of_command): New function.
6290         (help_list): Add 'apropos -v word' suggestion.
6291         (print_help_for_command): Style the command name using title style.
6292         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6293         (_initialize_cli_cmds): Describe -v in apropos_command help.
6294
6295 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6296
6297         * cli/cli-style.h (cli_style_option): Add name in constructor,
6298         add m_name class member, add constructor with intensity,
6299         add name class function.
6300         (cli_style_option::add_setshow_commands): Remove name argument.
6301         (highlight_style, title_style): New styles.
6302         * cli/cli-style.c (do_show): New function that shows a style
6303         characteristic styling the style name with itself.
6304         (set_style_name): New function.
6305         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6306         Update all callers according to the changes in cli/cli-style.h.
6307         * utils.h (fputs_highlighted): New function.
6308         * utils.c (fputs_highlighted): Likewise.
6309
6310 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6311
6312         * NEWS: Mention new pipe command and new convenience variables.
6313
6314 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6315
6316         * cli/cli-cmds.c (pipe_command): New function.
6317         (_initialize_cli_cmds): Call add_com for pipe_command.
6318         Define | as an alias for pipe.
6319         (exit_status_set_internal_vars): New function.
6320         (shell_escape): Call exit_status_set_internal_vars.
6321         cli/cli-decode.c (find_command_name_length): Recognize | as
6322         a single character command.
6323
6324 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6325
6326         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6327         top.c (execute_command_to_ui_file): New function, mostly a copy
6328         of execute_command_to_string.
6329         (execute_command_to_string): Implement by calling
6330         execute_command_to_ui_file.
6331
6332 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6333
6334         * top.h (saved_command_line): Remove declaration.
6335         * top.c (previous_saved_command_line, previous_repeat_arguments):
6336         New variables.
6337         (saved_command_line): Make static, define together with other
6338         'repeat variables'.
6339         (dont_repeat): Clear repeat_arguments.
6340         (repeat_previous, get_saved_command_line, save_command_line):
6341         New functions.
6342         (gdb_init): Initialize saved_command_line
6343         and previous_saved_command_line.
6344         * main.c (captured_main_1): Remove saved_command_line initialization.
6345         * event-top.c (handle_line_of_input): Update to use
6346         the new 'repeat' related functions instead of direct access to
6347         saved_command_line.
6348         * command.h (repeat_previous, get_saved_command_line,
6349         save_command_line): New declarations.
6350         (dont_repeat): Add comment.
6351
6352 2019-05-30  Tom Tromey  <tromey@adacore.com>
6353
6354         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6355         Fix comment.
6356         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6357
6358 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6359
6360         PR cli/24587
6361         * completer.c (complete): Initialize variable word.
6362
6363 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6364
6365         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6366         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6367         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6368         'body' is NULL to the outter 'if', protecting the '!is_define'
6369         situation as well.
6370
6371 2019-05-29  Tom Tromey  <tromey@adacore.com>
6372
6373         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6374         (dwarf_unknown): New function.
6375         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6376         (dwarf_type_encoding_name): Use dwarf_unknown.
6377
6378 2019-05-29  Tom Tromey  <tromey@adacore.com>
6379
6380         PR c++/20020:
6381         * cp-valprint.c (cp_print_value_fields): Call
6382         cp_print_static_field inside "try".
6383
6384 2019-05-29  Tom Tromey  <tromey@adacore.com>
6385
6386         * inflow.c (struct terminal_info): Add default operator=.
6387         * configure: Rebuild.
6388         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6389         -Wdeprecated-copy-dtor, -Wredundant-move.
6390
6391 2019-05-29  Tom Tromey  <tromey@adacore.com>
6392
6393         * NEWS: Add entry.
6394         * infcmd.c (print_return_value_1): Handle finish_print
6395         option.
6396         (show_print_finish): New function.
6397         (_initialize_infcmd): Add "set/show print finish" commands.
6398         * valprint.c (user_print_options): Initialize new member.
6399         * valprint.h (struct value_print_options) <finish_print>: New
6400         member.
6401
6402 2019-05-28  Tom Tromey  <tromey@adacore.com>
6403
6404         * ada-lang.c (ada_remove_Xbn_suffix)
6405         (find_old_style_renaming_symbol)
6406         (parse_old_style_renaming): Remove.
6407         (ada_find_renaming_symbol): Don't call
6408         find_old_style_renaming_symbol.
6409         (ada_is_renaming_symbol): Rename from
6410         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6411         bool.  Now static.
6412         (ada_read_var_value): Update and simplify.
6413         * ada-exp.y (write_var_or_type): Remove old code.
6414
6415 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6416
6417         * event-top.c: Remove include comment.
6418         * inflow.c (class scoped_ignore_sigttou): Move from here...
6419         * inflow.h (class scoped_ignore_sigttou): ...to here.
6420         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6421         * top.c:  Remove include comment.
6422
6423 2019-05-27  Tom Tromey  <tom@tromey.com>
6424
6425         * NEWS: Fix typo.
6426
6427 2019-05-22  Tom Tromey  <tromey@adacore.com>
6428
6429         * target.c (target_follow_exec): Constify parameter.
6430         * target-delegates.c: Rebuild.
6431         * remote.c (remote_target::follow_exec): Constify parameter.
6432         * infrun.c (follow_exec): Constify parameter.
6433         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6434         (target_follow_exec): Likewise.
6435
6436 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6437
6438         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6439         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6440
6441 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6442
6443         * NEWS: Add debugredirect and testsuite sections.
6444
6445 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6446
6447         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6448         target descriptions using exclusively floating point register name
6449         aliases.
6450
6451 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6452
6453         PR gdb/18644:
6454         * f-lang.c (build_fortran_types): Handle the case where
6455         gdbarch_floatformat_for_type returns a nullptr.
6456
6457 2019-05-21  Tom de Vries  <tdevries@suse.de>
6458
6459         PR cli/24587
6460         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6461
6462 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6463
6464         PR gdb/18644:
6465         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6466         16-byte floats.
6467         * i386-tdep.c (i386_floatformat_for_type): Use
6468         floatformats_ia64_quad for the 16-byte floating point component
6469         within a fortran 32-byte complex number.
6470
6471 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6472
6473         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6474         delete default constructor.
6475         (find_partial_die): Update to return const struct.
6476         (partial_die_parent_scope): Move variable declaration into scope
6477         of its use and change its type to auto.
6478         (guess_partial_die_structure_name): Likewise.
6479         (partial_die_info::fixup): Likewise.
6480
6481 2019-05-17  Tom Tromey  <tromey@adacore.com>
6482
6483         * source.c (find_and_open_source): Remove cast.
6484
6485 2019-05-17  Tom Tromey  <tromey@adacore.com>
6486
6487         * annotate.c (annotate_source): Make "filename" const.
6488         * annotate.h (annotate_source): Use const.
6489
6490 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6491
6492         * disasm.c (set_disassembler_options): Send errors to stderr.
6493
6494 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6495
6496         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6497         (cli_interp_base::set_logging): Check debug_redirect.
6498         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6499         * cli/cli-logging.c (debug_redirect): Add static variable.
6500         (pop_output_files): Add default param.
6501         (handle_redirections): Print debug setting.
6502         (show_logging_command): Likewise.
6503         (_initialize_cli_logging): Add debugredirect command.
6504         * interps.c (current_interp_set_logging): Add debug_redirect
6505         parameter.
6506         * interps.h (set_logging): Add debug_redirect parameter.
6507         (current_interp_set_logging): Likewise.
6508         * mi/mi-common.h: Likewise.
6509         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6510
6511 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6512             Tom Tromey  <tromey@adacore.com>
6513
6514         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6515         directly.
6516         * cli/cli-interp.h (make_logging_output): Remove declaration.
6517         * cli/cli-logging.c (make_logging_output): Remove function.
6518         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6519         directly.
6520         * ui-file.c (tee_file::tee_file): Remove bools.
6521         (tee_file::~tee_file): Remove deletes.
6522         * ui-file.h (tee_file): Remove bools.
6523
6524 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6525
6526         * mi/mi-cmds.h (mi_cmd_complete): New function.
6527         * mi/mi-main.c (mi_cmd_complete): Likewise.
6528         * mi/mi-cmds.c: Define new MI command -complete.
6529         * NEWS: Mention new -complete command.
6530
6531 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6532
6533         * completer.h (complete): New function.
6534         * completer.c (complete): Likewise.
6535         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6536         function defined in completer.h.
6537
6538 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6539
6540         * MAINTAINERS (Write After Approval): Add myself.
6541
6542 2019-05-17  Tom de Vries  <tdevries@suse.de>
6543
6544         PR gdb/24094
6545         * dwarf2read.c (struct cu_partial_die_info): New struct.
6546         (find_partial_die): Return cu_partial_die_info.
6547         (partial_die_parent_scope, guess_partial_die_structure_name)
6548         (partial_die_info::fixup): Handle new return type of find_partial_die.
6549
6550 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6551
6552         PR breakpoints/24541
6553         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6554         "std::string", simplifying the algorithm.
6555
6556 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6557
6558         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6559         (stap_static_probe_ops::get_probes): Likewise.
6560
6561 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6562
6563         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6564         '-')" and "else if".
6565         (stap_parse_single_operand): Join checks for
6566         "gdbarch_stap_parse_special_token_p" and
6567         "gdbarch_stap_parse_special_token" in the same "if" statement.
6568         Invert check when verifying for operation on register
6569         displacement.
6570
6571 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6572
6573         * stap-probe.c (stap_get_opcode): Update comment.
6574         (stap_get_expected_argument_type): Likewise.
6575         (handle_stap_probe): Likewise.
6576
6577 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6578
6579         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6580         return type to 'bool'.  Adjust comment.  Use 'bool' when
6581         appropriate.
6582         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6583         * stap-probe.c (stap_parse_argument_1): Likewise.
6584         (stap_is_operator): Likewise.
6585         (stap_is_generic_prefix): Likewise.
6586         (stap_is_register_prefix): Likewise.
6587         (stap_is_register_indirection_prefix): Likewise.
6588         (stap_is_integer_prefix): Likewise.
6589         (stap_generic_check_suffix): Likewise.
6590         (stap_check_integer_suffix): Likewise.
6591         (stap_check_register_suffix): Likewise.
6592         (stap_check_register_indirection_suffix): Likewise.
6593         (stap_parse_register_operand): Likewise.
6594         (stap_parse_single_operand): Likewise.
6595         (stap_parse_argument_1): Likewise.
6596         (stap_probe::get_argument_count): Likewise.
6597         (stap_is_operator): Likewise.
6598
6599 2019-05-16  Tom Tromey  <tromey@adacore.com>
6600
6601         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6602         keyword to foreach.
6603
6604 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6605
6606         * linux-thread-db.c (try_thread_db_load_1): Change return type
6607         to bool.
6608         (try_thread_db_load): Likewise.
6609         (try_thread_db_load_from_pdir_1): Likewise.
6610         (try_thread_db_load_from_pdir): Likewise.
6611         (try_thread_db_load_from_sdir): Likewise.
6612         (try_thread_db_load_from_dir): Likewise.
6613         (thread_db_load_search): Likewise.
6614         (has_libpthread): Likewise.
6615         (thread_db_load): Likewise.
6616
6617 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6618
6619         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6620         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6621         NULL, and complain/return if that's the case.
6622
6623 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6624
6625         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6626         (advance, posn, abstract_read_memory): New functions.
6627         [struct mem_read_abstraction]: New struct.
6628         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6629
6630 2019-05-14  Tom Tromey  <tromey@adacore.com>
6631
6632         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6633         value is not lval_memory.
6634
6635 2019-05-14  Tom Tromey  <tromey@adacore.com>
6636
6637         * solib.c (info_sharedlibrary_command): Style the file name.
6638
6639 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6640
6641         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6642         (aarch64_vnv_type): Likewise.
6643         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6644         * common/tdesc.c: Likewise.
6645         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6646         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6647         * features/aarch64-fpu.xml: Add ieee half view.
6648         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6649         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6650         * gdbtypes.h (struct builtin_type): Likewise.
6651         (struct objfile_type): Likewise.
6652
6653 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6654
6655         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6656         typo.
6657         * location.h (string_to_event_location): Likewise.
6658
6659 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6660
6661         GDB 8.3 released.
6662
6663 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6664
6665         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6666         New variable declaration.
6667         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6668         New variable.
6669         (print_one_breakpoint): Use ui_out::test_flags and new global
6670         variable to compute use_fixed_output.
6671         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6672         Remove.
6673         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6674         (mi_multi_location_breakpoint_output_fixed): Remove.
6675         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6676         new variable.
6677         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6678         fix_multi_location_breakpoint_output flag if version >= 3.
6679         * ui-out.h (enum ui_out_flag)
6680         <fix_multi_location_breakpoint_output>: New enumerator.
6681
6682 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6683
6684         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6685
6686 2019-05-10  Tom Tromey  <tromey@adacore.com>
6687
6688         * ada-lang.c (catch_ada_completer): New function.
6689         (_initialize_ada_language): Use it.
6690
6691 2019-05-10  Tom Tromey  <tromey@adacore.com>
6692
6693         * thread.c (print_thread_info): Make "requested_threads" const.
6694         * gdbthread.h (print_thread_info): Make "requested_threads"
6695         const.
6696         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6697         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6698
6699 2019-05-08  Tom Tromey  <tom@tromey.com>
6700
6701         * gdbtypes.c (objfile_type_data): Change type.
6702         (objfile_type, _initialize_gdbtypes): Update.
6703
6704 2019-05-08  Tom Tromey  <tom@tromey.com>
6705
6706         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6707         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6708         (_initialize_dwarf2_frame): Update.
6709
6710 2019-05-08  Tom Tromey  <tom@tromey.com>
6711
6712         * objc-lang.c (objc_objfile_data): Change type.
6713         (find_methods): Update.
6714         (_initialize_objc_lang): Remove.
6715
6716 2019-05-08  Tom Tromey  <tom@tromey.com>
6717
6718         * stabsread.c (rs6000_builtin_type_data): Change type.
6719         (rs6000_builtin_type, _initialize_stabsread): Update.
6720
6721 2019-05-08  Tom Tromey  <tom@tromey.com>
6722
6723         * mips-tdep.c (mips_pdr_data): Remove.
6724         (_initialize_mips_tdep): Update.
6725
6726 2019-05-08  Tom Tromey  <tom@tromey.com>
6727
6728         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6729         (hppa_init_objfile_priv_data, read_unwind_info)
6730         (find_unwind_entry, _initialize_hppa_tdep): Update.
6731
6732 2019-05-08  Tom Tromey  <tom@tromey.com>
6733
6734         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6735         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6736         on obstack.
6737         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6738
6739 2019-05-08  Tom Tromey  <tom@tromey.com>
6740
6741         * mdebugread.c (basic_type_data): Change type.
6742         (basic_type, _initialize_mdebugread): Update.
6743
6744 2019-05-08  Tom Tromey  <tom@tromey.com>
6745
6746         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6747
6748 2019-05-08  Tom Tromey  <tom@tromey.com>
6749
6750         * nto-tdep.c (nto_inferior_data_reg): Change type.
6751         (nto_inferior_data): Update.
6752         (nto_inferior_data_cleanup, nto_new_inferior_data)
6753         (_initialize_nto_tdep): Remove.
6754         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6755
6756 2019-05-08  Tom Tromey  <tom@tromey.com>
6757
6758         * ada-lang.c (struct ada_inferior_data): Add initializers.
6759         (ada_inferior_data): Change type.
6760         (ada_inferior_data_cleanup): Remove.
6761         (get_ada_inferior_data, ada_inferior_exit)
6762         (struct ada_pspace_data): Add initializers, destructor.
6763         (ada_pspace_data_handle): Change type.
6764         (get_ada_pspace_data): Update.
6765         (ada_pspace_data_cleanup): Remove.
6766
6767 2019-05-08  Tom Tromey  <tom@tromey.com>
6768
6769         * coffread.c (struct coff_symfile_info): Add initializers.
6770         (coff_objfile_data_key): Move lower.  Change type.
6771         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6772         Update.
6773         (coff_free_info): Remove.
6774
6775 2019-05-08  Tom Tromey  <tom@tromey.com>
6776
6777         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6778         (fbsd_pspace_data_handle): Move lower.  Change type.
6779         (get_fbsd_pspace_data): Update.
6780         (fbsd_pspace_data_cleanup): Remove.
6781         (_initialize_fbsd_tdep): Update.
6782
6783 2019-05-08  Tom Tromey  <tom@tromey.com>
6784
6785         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6786         (get_ada_tasks_pspace_data): Update.
6787         (ada_tasks_pspace_data_cleanup): Remove.
6788         (_initialize_tasks): Update.
6789         (ada_tasks_inferior_data_handle): Change type.
6790         (get_ada_tasks_inferior_data): Update.
6791         (ada_tasks_inferior_data_cleanup): Remove.
6792         (struct ada_tasks_pspace_data): Add initializers.
6793
6794 2019-05-08  Tom Tromey  <tom@tromey.com>
6795
6796         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6797         * symfile-debug.c (debug_sym_get_probes): Change type.
6798         * stap-probe.c (handle_stap_probe):
6799         (stap_static_probe_ops::get_probes): Change type.
6800         * probe.h (class static_probe_ops) <get_probes>: Change type.
6801         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6802         (parse_probes_in_pspace): Update.
6803         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6804         Update.
6805         (any_static_probe_ops::get_probes): Change type.
6806         * elfread.c (elfread_data): New typedef.
6807         (probe_key): Change type.
6808         (elf_get_probes): Likewise.  Update.
6809         (probe_key_free): Remove.
6810         (_initialize_elfread): Update.
6811         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6812         Change type.
6813         (dtrace_process_dof_probe, dtrace_process_dof)
6814         (dtrace_static_probe_ops::get_probe): Change type.
6815
6816 2019-05-08  Tom Tromey  <tom@tromey.com>
6817
6818         * xcoffread.c (struct xcoff_symfile_info): Rename from
6819         coff_symfile_info.  Add initializers.
6820         (xcoff_objfile_data_key): Move lower.  Change type.
6821         (XCOFF_DATA): Rewrite.
6822         (xcoff_free_info): Remove.
6823         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6824         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6825         (xcoff_initial_scan): Update.
6826
6827 2019-05-08  Tom Tromey  <tom@tromey.com>
6828
6829         * solib-svr4.c (struct svr4_info): Add initializers and
6830         destructor.
6831         <probes_table>: Now an htab_up.
6832         (solib_svr4_pspace_data): Change type.
6833         (free_probes_table): Simplify.
6834         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6835         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6836         (probes_table_remove_objfile_probes, register_solib_event_probe)
6837         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6838         (_initialize_svr4_solib): Update.
6839
6840 2019-05-08  Tom Tromey  <tom@tromey.com>
6841
6842         * remote.c (remote_pspace_data): Change type.
6843         (remote_pspace_data_cleanup): Remove.
6844         (get_remote_exec_file, set_pspace_remote_exec_file)
6845         (_initialize_remote): Update.
6846
6847 2019-05-08  Tom Tromey  <tom@tromey.com>
6848
6849         * breakpoint.c (breakpoint_objfile_key): Change type.
6850         (get_breakpoint_objfile_data): Update.
6851         (free_breakpoint_objfile_data): Remove.
6852         (_initialize_breakpoint): Update.
6853
6854 2019-05-08  Tom Tromey  <tom@tromey.com>
6855
6856         * linux-tdep.c (struct linux_info): Add initializers.
6857         (linux_inferior_data): Move.  Change type.
6858         (invalidate_linux_cache_inf): Update.
6859         (linux_inferior_data_cleanup): Remove.
6860         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6861
6862 2019-05-08  Tom Tromey  <tom@tromey.com>
6863
6864         * auxv.c (auxv_inferior_data): Move.  Change type.
6865         (auxv_inferior_data_cleanup): Remove.
6866         (invalidate_auxv_cache_inf): Rewrite.
6867         (get_auxv_inferior_data, _initialize_auxv): Update.
6868
6869 2019-05-08  Tom Tromey  <tom@tromey.com>
6870
6871         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6872         (symfile_debug_objfile_data_key): Change type.
6873         (symfile_debug_installed, debug_qf_has_symbols)
6874         (debug_qf_find_last_source_symtab)
6875         (debug_qf_forget_cached_source_info)
6876         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6877         (debug_qf_print_stats, debug_qf_dump)
6878         (debug_qf_expand_symtabs_for_function)
6879         (debug_qf_expand_all_symtabs)
6880         (debug_qf_expand_symtabs_with_fullname)
6881         (debug_qf_map_matching_symbols)
6882         (debug_qf_expand_symtabs_matching)
6883         (debug_qf_find_pc_sect_compunit_symtab)
6884         (debug_qf_map_symbol_filenames)
6885         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6886         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6887         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6888         (debug_sym_read_linetable, debug_sym_relocate): Update.
6889         (symfile_debug_free_objfile): Remove.
6890         (install_symfile_debug_logging, _initialize_symfile_debug):
6891         Update.
6892
6893 2019-05-08  Tom Tromey  <tom@tromey.com>
6894
6895         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6896         allocate_on_obstack.
6897         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6898         (get_dwarf2_per_objfile): Update.
6899         (set_dwarf2_per_objfile): Remove.
6900         (dwarf2_has_info, dwarf2_get_section_info): Update.
6901         (dwarf2_free_objfile): Remove.
6902         (_initialize_dwarf2_read): Update.
6903
6904 2019-05-08  Tom Tromey  <tom@tromey.com>
6905
6906         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6907         initializers.
6908         <unsupported_script_warning_printed,
6909         script_not_found_warning_printed>: Now bool.
6910         (auto_load_pspace_data): Change type.
6911         (~auto_load_pspace_info): Rename from
6912         auto_load_pspace_data_cleanup.
6913         (get_auto_load_pspace_data, init_loaded_scripts_info)
6914         (clear_section_scripts, maybe_print_unsupported_script_warning)
6915         (maybe_print_script_not_found_warning, _initialize_auto_load):
6916         Update.
6917
6918 2019-05-08  Tom Tromey  <tom@tromey.com>
6919
6920         * objfiles.c (objfile_pspace_info): Add destructor and
6921         initializers.
6922         (objfiles_pspace_data): Change type.
6923         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6924         (get_objfile_pspace_data): Update.
6925         (objfiles_bfd_data): Change type.
6926         (get_objfile_bfd_data): Update.
6927         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6928
6929 2019-05-08  Tom Tromey  <tom@tromey.com>
6930
6931         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6932         Change type.
6933         (get_catch_syscall_inferior_data): Update.
6934         (catch_syscall_inferior_data_cleanup): Remove.
6935         (_initialize_break_catch_syscall): Update.
6936
6937 2019-05-08  Tom Tromey  <tom@tromey.com>
6938
6939         * inflow.c (struct terminal_info): Add destructor and
6940         initializers.
6941         (inflow_inferior_data): Change type.
6942         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6943         (get_inflow_inferior_data, inflow_inferior_exit)
6944         (swap_terminal_info, _initialize_inflow): Update.
6945
6946 2019-05-08  Tom Tromey  <tom@tromey.com>
6947
6948         * target-dcache.c (target_dcache_cleanup): Remove.
6949         (target_dcache_aspace_key): Change type.
6950         (target_dcache_init_p, target_dcache_invalidate)
6951         (target_dcache_get, target_dcache_get_or_init)
6952         (_initialize_target_dcache): Update.
6953         * dcache.h (struct dcache_deleter): New.
6954
6955 2019-05-08  Tom Tromey  <tom@tromey.com>
6956
6957         * symtab.c (struct symbol_cache): Add destructor and
6958         initializers.
6959         (symbol_cache_key): Move.  Change type.
6960         (make_symbol_cache, free_symbol_cache): Remove.
6961         (get_symbol_cache): Update.
6962         (symbol_cache_cleanup): Remove.
6963         (ALL_PSPACES, symbol_cache_flush)
6964         (maintenance_print_symbol_cache)
6965         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6966         Update.
6967
6968 2019-05-08  Tom Tromey  <tom@tromey.com>
6969
6970         * symtab.c (struct main_info): Add destructor and initializers.
6971         (main_progspace_key): Move.  Change type.
6972         (get_main_info): Update.
6973         (main_info_cleanup): Remove.
6974         (_initialize_symtab): Update.
6975
6976 2019-05-08  Tom Tromey  <tom@tromey.com>
6977
6978         * registry.h (DECLARE_REGISTRY): Define the _key class.
6979
6980 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6981
6982         * NEWS: Merge two 'New commands' sections.
6983
6984 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6985
6986         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6987         parameter and use Ada language definition instead.
6988         (ada_val_print_ptr): Remove unused language parameter.
6989         (ada_val_print_num): Remove language parameter and use Ada language
6990         definition instead.
6991         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6992         parameter.
6993         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6994         parameter and use Ada language definition instead.
6995         (ada_val_print_1): Update all ada_val_print_xxx calls.
6996         Remove language parameter.
6997         (ada_val_print): Update ada_val_print_1 call.
6998
6999 2019-05-08  Tom Tromey  <tromey@adacore.com>
7000
7001         * remote.c (remote_hw_watchpoint_limit)
7002         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7003         Now static.
7004
7005 2019-05-08  Tom Tromey  <tromey@adacore.com>
7006
7007         * maint.c (_initialize_maint_cmds): Move initialization code to
7008         remote.c.
7009         (watchdog, show_watchdog): Move to remote.c.
7010         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7011         "watchdog" static.
7012         (_initialize_remote): Move initialization code from maint.c.
7013         * defs.h (watchdog): Don't declare.
7014
7015 2019-05-08  Tom Tromey  <tromey@adacore.com>
7016
7017         * tui/tui-interp.c: Include main.h.
7018         * interps.c: Include main.h.
7019         * main.h (interpreter_p): Declare.
7020         * defs.h (interpreter_p): Don't declare.
7021
7022 2019-05-08  Tom Tromey  <tromey@adacore.com>
7023
7024         * dwarf2loc.c: Include dwarf2read.h.
7025         * defs.h (read_unsigned_leb128): Don't declare.
7026         * dwarf2read.h (read_unsigned_leb128): Declare.
7027
7028 2019-05-08  Tom Tromey  <tromey@adacore.com>
7029
7030         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7031         method.
7032
7033 2019-05-08  Tom Tromey  <tromey@adacore.com>
7034
7035         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7036         when no wrap column is set.
7037
7038 2019-05-08  Tom Tromey  <tromey@adacore.com>
7039
7040         * c-lang.c (c_get_string): Handle non-C-style arrays.
7041
7042 2019-05-08  Tom Tromey  <tromey@adacore.com>
7043
7044         * typeprint.c (print_offset_data::update): Print the bit offset,
7045         not the number of bits remaining.
7046
7047 2019-05-08  Tom Tromey  <tromey@adacore.com>
7048
7049         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7050         padding at end of comment.
7051
7052 2019-05-08  Tom Tromey  <tromey@adacore.com>
7053
7054         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7055         Compare main types.
7056
7057 2019-05-06  Tom Tromey  <tom@tromey.com>
7058
7059         * common/scoped_mmap.c: Include common-defs.h.
7060         * common/scoped_mmap.h: Don't include config.h.
7061
7062 2019-05-04  Tom Tromey  <tom@tromey.com>
7063
7064         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7065         (struct aarch64_call_info): Add initializers.
7066         <si>: Now a std::vector.
7067         (pass_on_stack, aarch64_push_dummy_call): Update.
7068
7069 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7070             Tom Tromey  <tom@tromey.com>
7071
7072         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7073         (ppc_threads): Now a std::vector.  Now static.
7074         (hwdebug_find_thread_points_by_tid)
7075         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7076         Update.
7077
7078 2019-05-04  Tom Tromey  <tom@tromey.com>
7079
7080         * arc-tdep.c (arc_tdesc_init): Return bool.
7081
7082 2019-05-04  Tom Tromey  <tom@tromey.com>
7083
7084         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7085         Use gdb_assert_not_reached.
7086
7087 2019-05-04  Tom Tromey  <tom@tromey.com>
7088
7089         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7090         "false".
7091
7092 2019-05-04  Tom Tromey  <tom@tromey.com>
7093
7094         * arc-tdep.c (arc_tdesc_init): Use bool.
7095
7096 2019-05-04  Tom Tromey  <tom@tromey.com>
7097
7098         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7099
7100 2019-05-04  Tom Tromey  <tom@tromey.com>
7101
7102         * cli/cli-cmds.c (valid_command_p): Return bool.
7103
7104 2019-05-04  Tom Tromey  <tom@tromey.com>
7105
7106         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7107         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7108
7109 2019-05-04  Raul Tambre  <raul@tambre.ee>
7110
7111         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7112         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7113         operator for comparison.
7114
7115 2019-05-04  Tom Tromey  <tom@tromey.com>
7116
7117         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7118         (lookup_partial_symbol, print_partial_symbols)
7119         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7120         (psymbol_compare): Update.
7121         (add_psymbol_to_bcache): Clear the entire psymbol.
7122         (maintenance_check_psymtabs): Update.
7123         * psympriv.h (struct partial_symbol): Don't derive from
7124         general_symbol_info.
7125         <obj_section, unrelocated_address, address,
7126         set_unrelocated_address>: Update.
7127         <ginfo>: New member.
7128         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7129         (debug_names::write_psymbols): Update.
7130
7131 2019-05-04  Tom de Vries  <tdevries@suse.de>
7132
7133         * contrib/cc-with-tweaks.sh: Support -n arg.
7134
7135 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7136
7137         * corelow.c (core_target::detach): Ensure frame cache and
7138         register caches are cleared.
7139         inferior.c (exit_inferior_1): Likewise.
7140
7141 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7142             Tom Tromey  <tom@tromey.com>
7143
7144         * dictionary.c (collate_pending_symbols_by_language): Remove
7145         "struct" from foreach.
7146         * symtab.c (lookup_global_symbol_from_objfile)
7147         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7148         foreach.
7149         * ser-tcp.c (net_open): Remove "struct" from foreach.
7150         * objfiles.c (objfile_relocate, objfile_rebase)
7151         (objfile_has_symbols): Remove "struct" from foreach.
7152         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7153         from foreach.
7154         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7155         foreach.
7156         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7157         "struct" from foreach.
7158         * ada-lang.c (create_excep_cond_exprs)
7159         (ada_exception_catchpoint_cond_string): Remove "struct" from
7160         foreach.
7161
7162 2019-05-03  Tom Tromey  <tromey@adacore.com>
7163
7164         * ada-exp.y (convert_char_literal): Check suffix of each
7165         enumerator.
7166
7167 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7168
7169         PR ada/21406:
7170         * ada-exp.y (yywrap): Don't define.
7171         * ada-lex.l (%option): Add noyywrap
7172         (yywrap): Remove.
7173
7174 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7175
7176         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7177         _WIN32_WINNT to the XP level, unless already defined to a higher
7178         level.
7179
7180         * unittests/parse-connection-spec-selftests.c:
7181         * ser-tcp.c:
7182         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7183         override.
7184
7185         * symfile.c (find_separate_debug_file): Remove colon from the
7186         drive spec of DOS/Windows file names of the target, so that the
7187         file name produced from DEBUGDIR and the target's directory will
7188         be valid on DOS/Windows systems.
7189
7190 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7191
7192         * rust-lang.c (val_print_struct): Handle printing structures
7193         containing strings.
7194
7195 2019-05-02  Tom Tromey  <tromey@adacore.com>
7196
7197         * valarith.c (_initialize_valarith): Remove.
7198
7199 2019-05-01  Tom Tromey  <tromey@adacore.com>
7200
7201         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7202         bitfields.
7203
7204 2019-05-01  Tom Tromey  <tromey@adacore.com>
7205
7206         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7207         for big-endian copies.
7208
7209 2019-04-30  Ali Tamur  <tamur@google.com>
7210         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7211         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7212         (read_3_bytes): New function.
7213
7214 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7215
7216         * windows-nat.c (main_thread_id): Delete.
7217         (handle_output_debug_string): Replace main_thread_id by
7218         current_event.dwThreadId.
7219         (fake_create_process): Likewise.
7220         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7221         Do not set main_thread_id.
7222         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7223         current_event.dwThreadId.
7224         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7225
7226 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7227
7228         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7229         Use current_event.dwThreadId instead of main_thread_id.
7230
7231 2019-04-30  Tom Tromey  <tromey@adacore.com>
7232
7233         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7234         (create_excep_cond_exprs): Iterate over program spaces.
7235         (ada_exception_catchpoint_cond_string): Examine all minimal
7236         symbols for exception types.
7237
7238 2019-04-30  Tom Tromey  <tromey@adacore.com>
7239
7240         PR c++/24470:
7241         * dwarf2read.c (process_structure_scope): Handle case where type
7242         has template parameters but no symbol was created.
7243
7244 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7245             Chris January  <chris.january@arm.com>
7246
7247         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7248         qualifier.
7249         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7250
7251 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         * f-typeprint.c (f_print_type): Update rules for printing
7254         whitespace.
7255         (f_type_print_varspec_suffix): Likewise.
7256
7257 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7258             Chris January  <chris.january@arm.com>
7259
7260         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7261         function arguments.
7262
7263 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7264
7265         * f-lang.c (build_fortran_types): Change name of void type to
7266         lower case.
7267         * f-typeprint.c (f_type_print_base): Print the name of the void
7268         type, rather than a fixed string.
7269         * f-valprint.c (f_decorations): Use lower case void string.
7270
7271 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7272             Chris January  <chris.january@arm.com>
7273
7274         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7275         types for Fortran.
7276
7277 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7278             Chris January  <chris.january@arm.com>
7279             David Lecomber  <david.lecomber@arm.com>
7280
7281         * f-exp.y (BINOP_INTRINSIC): New token.
7282         (exp): New parser rule handling BINOP_INTRINSIC.
7283         (f77_keywords): Add new builtin procedures.
7284         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7285         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7286         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7287         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7288         (print_unop_subexp_f): New function.
7289         (print_binop_subexp_f): New function.
7290         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7291         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7292         (dump_subexp_body_f): Likewise.
7293         (operator_check_f): Likewise.
7294         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7295         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7296
7297 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7300         UNOP_KIND.
7301         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7302         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7303         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7304         (operator_length_f): New fuction.
7305         (print_subexp_f): New function.
7306         (op_name_f): New function.
7307         (dump_subexp_body_f): New function.
7308         (operator_check_f): New function.
7309         (exp_descriptor_f): Replace standard expression handling functions
7310         with new functions.
7311         * gdb/fortran-operator.def: New file.
7312         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7313         * gdb/std-operator.def: Remove UNOP_KIND.
7314
7315 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7316
7317         * std-operator.def: Remove unbalanced, stray double quote
7318         character.
7319
7320 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7321             Chris January  <chris.january@arm.com>
7322             Daniel Everett  <daniel.everett@arm.com>
7323             Nick Forrington  <nick.forrington@arm.com>
7324             Richard Bunt  <richard.bunt@arm.com>
7325
7326         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7327         of depth when printing anonymous structs or unions.
7328         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7329         Don't print either the top-level value, or the children if the
7330         max-depth is exceeded.
7331         (ppscm_print_children): When printing the key of a map, allow one
7332         extra level of depth.
7333         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7334         print either the top-level value, or the children if the max-depth
7335         is exceeded.
7336         (print_children): When printing the key of a map, allow one extra
7337         level of depth.
7338         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7339         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7340         (user_print_options): Initialise max_depth field.
7341         (val_print_scalar_or_string_type_p): New function.
7342         (val_print): Check to see if the max depth has been reached.
7343         (val_print_check_max_depth): Define new function.
7344         (show_print_max_depth): New function.
7345         (_initialize_valprint): Add 'print max-depth' option.
7346         * valprint.h (struct value_print_options) <max_depth>: New field.
7347         (val_print_check_max_depth): Declare new function.
7348         * NEWS: Document new feature.
7349
7350 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7351
7352         * ada-lang.c (ada_language_defn): Initialise new field.
7353         * c-lang.c (c_is_string_type_p): New function.
7354         (c_language_defn): Initialise new field.
7355         (cplus_language_defn): Initialise new field.
7356         (asm_language_defn): Initialise new field.
7357         (minimal_language_defn): Initialise new field.
7358         * c-lang.h (c_is_string_type_p): Declare new function.
7359         * d-lang.c (d_language_defn): Initialise new field.
7360         * f-lang.c (f_is_string_type_p): New function.
7361         (f_language_defn): Initialise new field.
7362         * go-lang.c (go_is_string_type_p): New function.
7363         (go_language_defn): Initialise new field.
7364         * language.c (default_is_string_type_p): New function.
7365         (unknown_language_defn): Initialise new field.
7366         (auto_language_defn): Initialise new field.
7367         * language.h (struct language_defn) <la_is_string_type_p>: New
7368         member variable.
7369         (default_is_string_type_p): Declare new function.
7370         * m2-lang.c (m2_language_defn): Initialise new field.
7371         * objc-lang.c (objc_language_defn): Initialise new field.
7372         * opencl-lang.c (opencl_language_defn): Initialise new field.
7373         * p-lang.c (pascal_is_string_type_p): New function.
7374         (pascal_language_defn): Initialise new field.
7375         * rust-lang.c (rust_is_string_type_p): New function.
7376         (rust_language_defn): Initialise new field.
7377
7378 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7379
7380         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7381         New field.
7382         * ada-lang.c (ada_language_defn): Initialise new field.
7383         * c-lang.c (c_language_defn): Likewise.
7384         (cplus_language_defn): Likewise.
7385         (asm_language_defn): Likewise.
7386         (minimal_language_defn): Likewise.
7387         * d-lang.c (d_language_defn): Likewise.
7388         * f-lang.c (f_language_defn): Likewise.
7389         * go-lang.c (go_language_defn): Likewise.
7390         * language.c (unknown_language_defn): Likewise.
7391         (auto_language_defn): Likewise.
7392         * m2-lang.c (m2_language_defn): Likewise.
7393         * objc-lang.c (objc_language_defn): Likewise.
7394         * opencl-lang.c (opencl_language_defn): Likewise.
7395         * p-lang.c (pascal_language_defn): Likewise.
7396         * rust-lang.c (rust_language_defn): Likewise.
7397
7398 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7399
7400         * ada-lang.c (ada_is_character_type): Change return type to bool.
7401         (ada_is_string_type): Likewise.
7402         * ada-lang.h (ada_is_character_type): Update declaration
7403         (ada_is_string_type): Likewise.
7404
7405 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7406
7407         Support style in 'frame|thread apply'
7408
7409         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7410         * record.c (record_start, record_stop): Update callers of
7411         execute_command_to_string with false.
7412         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7413         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7414         methods.
7415         (class string_file): New constructor with term_out parameter.
7416         Override methods term_out and can_emit_style_escape.  New member
7417         term_out.
7418         (class stdio_file): Override can_emit_style_escape.
7419         (class tee_file): Override term_out and can_emit_style_escape.
7420         * utils.h (can_emit_style_escape): Remove.
7421         * utils.c (can_emit_style_escape): Likewise.
7422         Update all callers of can_emit_style_escape (SOMESTREAM) to
7423         SOMESTREAM->can_emit_style_escape.
7424         * source-cache.c (source_cache::get_source_lines): Likewise.
7425         * stack.c (frame_apply_command_count): Call execute_command_to_string
7426         passing the term_out characteristic of the current gdb_stdout.
7427         * thread.c (thr_try_catch_cmd): Likewise.
7428         * top.c (execute_command_to_string): pass term_out parameter
7429         to construct the string_file for the command output.
7430         * ui-file.c (term_cli_styling): New function (most code moved
7431         from utils.c can_emit_style_escape).
7432         (string_file::string_file, string_file::can_emit_style_escape,
7433         stdio_file::can_emit_style_escape, tee_file::term_out,
7434         tee_file::can_emit_style_escape): New functions.
7435
7436 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7437
7438         * NEWS: Mention the new set|show may-call-functions.
7439         * infcall.c (may_call_functions_p): New variable.
7440         (show_may_call_functions_p): New function.
7441         (call_function_by_hand_dummy): Throws an error if not
7442         may-call-functions.
7443         (_initialize_infcall): Call add_setshow_boolean_cmd for
7444         may-call-functions.
7445
7446 2019-04-25  Keith Seitz  <keiths@redhat.com>
7447
7448         PR c++/24367
7449         * cp-support.c (inspect_type): Don't attempt substitutions
7450         of symbol with the same name.
7451
7452 2019-04-25  Tom Tromey  <tromey@adacore.com>
7453
7454         PR gdb/24475:
7455         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7456         static.
7457
7458 2019-04-25  Tom Tromey  <tromey@adacore.com>
7459
7460         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7461         rvalue reference.
7462         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7463         (gdb_xml_parser::parse): Use std::move.
7464         * python/python-internal.h (gdbpy_convert_exception): Take a const
7465         reference.
7466         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7467         std::move.
7468         * python/py-utils.c (gdbpy_convert_exception): Take a const
7469         reference.
7470         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7471         Use std::move.
7472         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7473         Use std::move.
7474         * mi/mi-main.c (mi_print_exception): Take a const reference.
7475         * main.c (handle_command_errors): Take a const reference.
7476         * linespec.c (parse_linespec): Use std::move.
7477         * infcall.c (run_inferior_call): Use std::move.
7478         (call_function_by_hand_dummy): Use std::move.
7479         * exec.c (try_open_exec_file): Use std::move.
7480         * exceptions.h (exception_print, exception_fprintf)
7481         (exception_print_same): Update.
7482         * exceptions.c (print_exception, exception_print)
7483         (exception_fprintf, exception_print_same): Change parameters to
7484         const reference.
7485         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7486         * common/new-op.c: Use std::move.
7487         * common/common-exceptions.h (struct gdb_exception): Add move
7488         constructor.
7489         (struct gdb_exception_error, struct gdb_exception_quit, struct
7490         gdb_quit_bad_alloc): Change constructor to move constructor.
7491         (throw_exception): Change parameter to rvalue reference.
7492         * common/common-exceptions.c (throw_exception): Take rvalue
7493         reference.
7494         * cli/cli-interp.c (safe_execute_command): Use std::move.
7495         * breakpoint.c (insert_bp_location, location_to_sals): Use
7496         std::move.
7497
7498 2019-04-25  Tom Tromey  <tromey@adacore.com>
7499
7500         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7501         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7502         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7503         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7504         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7505         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7506         guile/scm-value.c: Use unpack.
7507         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7508         gdbscm_gdb_exception.
7509         (gdbscm_throw_gdb_exception): Likewise.
7510         (struct gdbscm_gdb_exception): New.
7511         (unpack): New function.
7512         (gdbscm_wrap): Use unpack.
7513
7514 2019-04-25  Tom Tromey  <tromey@adacore.com>
7515
7516         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7517         (gdb_rl_callback_handler): Use std::move.
7518         * common/common-exceptions.h (struct gdb_exception): Add move
7519         assignment operator.
7520         (throw_exception_sjlj): Change "exception" to const reference.
7521         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7522         (throw_exception_sjlj): Change "exception" to const reference.
7523
7524 2019-04-25  Tom Tromey  <tromey@adacore.com>
7525
7526         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7527         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7528         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7529         Update.
7530         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7531         Update.
7532         * mi/mi-interp.c (mi_interp::exec): Update.
7533         * linespec.c (parse_linespec): Update.
7534         * infcall.c (run_inferior_call): Update.
7535         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7536         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7537         (gdbscm_lookup_global_symbol): Update.
7538         * guile/scm-param.c (gdbscm_parameter_value): Update.
7539         * guile/scm-frame.c (gdbscm_frame_read_register)
7540         (gdbscm_frame_read_var): Update.
7541         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7542         * exec.c (try_open_exec_file): Update.
7543         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7544         (gdb_rl_callback_handler): Update.
7545         * common/common-exceptions.h (exception_none): Don't declare.
7546         * common/common-exceptions.c (exception_none): Don't define.
7547         (struct catcher) <exception>: Update.
7548         * cli/cli-interp.c (safe_execute_command): Update.
7549         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7550
7551 2019-04-25  Ali Tamur  <tamur@google.com>
7552
7553         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7554         (read_attribute_value): Likewise.
7555         (dwarf2_read_addr_index): Update comment.
7556         (read_str_index): Add DW_FORM_strx.
7557         (dwarf2_string_attr): Likewise.
7558         (dwarf2_const_value_attr): Likewise.
7559         (dump_die_shallow): Likewise.
7560         (dwarf2_fetch_constant_bytes): Likewise.
7561         (skip_form_bytes): Likewise.
7562         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7563
7564 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7565
7566         PR corefiles/11608
7567         PR corefiles/18187
7568         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7569         OFFSET.  Verify if current mapping contains an ELF header.
7570         (linux_find_memory_regions_full): Adjust call to
7571         dump_mapping_p.
7572
7573 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7574             Kang Li <kanglictf@gmail.com>
7575
7576         PR gdb/21600
7577
7578         * dwarf2-frame.c (read_initial_length): Be consistent about using
7579         unsigned representation of length.
7580         (decode_frame_entry_1): Likewise.  Check for wraparound of
7581         end pointer as well as buffer overflow.
7582
7583 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7584
7585         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7586         "vq".
7587
7588 2019-04-24  Tom Tromey  <tromey@adacore.com>
7589
7590         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7591
7592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7593
7594         * s12z-tdep.c (s12z_unwind_pc): Delete.
7595         (s12z_unwind_sp): Delete.
7596         (s12z_gdbarch_init): Don't register deleted functions with
7597         gdbarch.
7598
7599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7600
7601         * rl78-tdep.c (rl78_unwind_sp): Delete.
7602         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7603
7604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7605
7606         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7607         (xstormy16_unwind_pc): Delete.
7608         (xstormy16_dummy_id): Delete.
7609         (xstormy16_gdbarch_init): Don't register deleted functions with
7610         gdbarch.
7611
7612 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7613
7614         * vax-tdep.c (vax_unwind_pc): Delete.
7615         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7616
7617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7618
7619         * v850-tdep.c (v850_unwind_sp): Delete.
7620         (v850_unwind_pc): Delete.
7621         (v850_dummy_id): Delete.
7622         (v850_gdbarch_init): Don't register deleted functions with
7623         gdbarch.
7624
7625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7626
7627         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7628         (tilegx_unwind_pc): Delete.
7629         (tilegx_unwind_dummy_id): Delete.
7630         (tilegx_gdbarch_init): Don't register deleted functions with
7631         gdbarch.
7632
7633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7634
7635         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7636         (tic6x_dummy_id): Delete.
7637         (tic6x_gdbarch_init): Don't register deleted functions with
7638         gdbarch.
7639
7640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7641
7642         * sparc-tdep.c (sparc_unwind_pc): Delete.
7643         (sparc32_gdbarch_init): Don't register deleted function with
7644         gdbarch.
7645
7646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7647
7648         * sh-tdep.c (sh_unwind_sp): Delete.
7649         (sh_unwind_pc): Delete.
7650         (sh_dummy_id): Delete.
7651         (sh_gdbarch_init): Don't register deleted functions with
7652         gdbarch.
7653
7654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7655
7656         * score-tdep.c (score_unwind_sp): Delete.
7657         (score_unwind_pc): Delete.
7658         (score_dummy_id): Delete.
7659         (score_gdbarch_init): Don't register deleted functions with
7660         gdbarch.
7661
7662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7663
7664         * rx-tdep.c (rx_unwind_pc): Delete.
7665         (rx_unwind_sp): Delete.
7666         (rx_dummy_id): Delete.
7667         (rx_gdbarch_init): Don't register deleted functions with
7668         gdbarch.  Update comment.
7669
7670 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7671
7672         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7673         (rs6000_dummy_id): Delete.
7674         (rs6000_gdbarch_init): Don't register deleted functions with
7675         gdbarch.
7676
7677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7678
7679         * or1k-tdep.c (or1k_dummy_id): Delete.
7680         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7681
7682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7683
7684         * nios2-tdep.c (nios2_dummy_id): Delete.
7685         (nios2_unwind_sp): Delete.
7686         (nios2_gdbarch_init): Don't register deleted functions with
7687         gdbarch.
7688
7689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7690
7691         * nds32-tdep.c (nds32_dummy_id): Delete.
7692         (nds32_unwind_pc): Delete.
7693         (nds32_unwind_sp): Delete.
7694         (nds32_gdbarch_init): Don't register deleted functions with
7695         gdbarch.
7696
7697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * msp430-tdep.c (msp430_unwind_pc): Delete.
7700         (msp430_unwind_sp): Delete.
7701         (msp430_dummy_id): Delete.
7702         (msp430_gdbarch_init): Don't register deleted functions with
7703         gdbarch.
7704
7705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7706
7707         * moxie-tdep.c (moxie_unwind_sp): Delete.
7708         (moxie_unwind_pc): Delete.
7709         (moxie_dummy_id): Delete.
7710         (moxie_gdbarch_init): Don't register deleted functions with
7711         gdbarch.
7712
7713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7716         (mn10300_unwind_pc): Delete.
7717         (mn10300_unwind_sp): Delete.
7718         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7719         mn10300_unwind_sp.
7720         (mn10300_frame_unwind_init): Don't register deleted functions with
7721         gdbarch.
7722
7723 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7724
7725         * mep-tdep.c (mep_unwind_pc): Delete.
7726         (mep_unwind_sp): Delete.
7727         (mep_dummy_id): Delete.
7728         (mep_gdbarch_init): Don't register deleted functions with
7729         gdbarch.
7730
7731 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7732
7733         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7734         (m68hc11_unwind_sp): Delete.
7735         (m68hc11_gdbarch_init): Don't register deleted functions with
7736         gdbarch.
7737
7738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7739
7740         * m32r-tdep.c (m32r_unwind_sp): Delete.
7741         (m32r_unwind_pc): Delete.
7742         (m32r_dummy_id): Delete.
7743         (m32r_gdbarch_init): Don't register deleted functions with
7744         gdbarch.
7745
7746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7747
7748         * m32c-tdep.c (m32c_unwind_pc): Delete.
7749         (m32c_unwind_sp): Delete.
7750         (m32c_dummy_id): Delete.
7751         (m32c_gdbarch_init): Don't register deleted functions with
7752         gdbarch.
7753
7754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7755
7756         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7757         (lm32_unwind_pc): Delete.
7758         (lm32_dummy_id): Delete.
7759         (lm32_gdbarch_init): Don't register deleted functions with
7760         gdbarch.
7761
7762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7763
7764         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7765         (iq2000_unwind_pc): Delete.
7766         (iq2000_dummy_id): Delete.
7767         (iq2000_gdbarch_init): Don't register deleted functions with
7768         gdbarch.
7769
7770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7771
7772         * nds32-tdep.c (nds32_type_align): Delete.
7773         (nds32_push_dummy_call): Use type_align instead.
7774
7775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * arm-tdep.c (arm_type_align): Only handle vector override case.
7778         (arm_push_dummy_call): Use type_align.
7779         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7780
7781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7782
7783         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7784         case.
7785         (pass_on_stack): Use type_align.
7786         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7787         function.
7788
7789 2019-04-23  Tom Tromey  <tromey@adacore.com>
7790
7791         * dwarf2read.c (line_header::file_name_at): Remove unused
7792         overload.
7793
7794 2019-04-23  Tom de Vries  <tdevries@suse.de>
7795
7796         PR gdb/24438
7797         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7798         invocation.
7799
7800
7801 2019-03-27  Ali Tamur  <tamur@google.com>
7802
7803         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7804         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7805         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7806         (dwarf_expr_context::get_addr_index): Likewise
7807         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7808         (symbol_needs_eval_context::get_addr_index): Likewise
7809         (disassemble_dwarf_expression): Add DW_OP_addrx
7810         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7811         (read_cutu_die_from_dwo): Update comment
7812         (skip_one_die): Add DW_FORM_addrx
7813         (read_attribute_value): Likewise
7814         (var_decode_location): Add DW_OP_addrx
7815         (dwarf2_const_value_attr): Add DW_FORM_addrx
7816         (dump_die_shallow): Likewise
7817         (dwarf2_fetch_constant_bytes): Likewise
7818         (decode_locdesc): Add DW_OP_addrx
7819         (skip_form_bytes): Add DW_FORM_addrx
7820
7821 2019-04-22  Ali Tamur  <tamur@google.com>
7822
7823         * MAINTAINERS (Write After Approval): Add self.
7824
7825 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7826
7827         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7828         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7829         (open_symbol_file_object): Likewise.
7830         (svr4_default_sos): Add info parameter.
7831         (svr4_read_so_list): Likewise.
7832         (svr4_current_sos_direct): Adjust functions calls to pass down
7833         info.
7834         (svr4_current_sos_1): Add info parameter.
7835         (svr4_current_sos): Call get_svr4_info, pass info down to
7836         svr4_current_sos_1.
7837         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7838         get_svr4_info.
7839         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7840         get_svr4_info.
7841         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7842         to get_svr4_info.
7843         (probes_table_remove_objfile_probes): Likewise.
7844         (register_solib_event_probe): Add info parameter.
7845         (solist_update_incremental): Pass info parameter down to
7846         svr4_read_so_list.
7847         (disable_probes_interface): Add info parameter.
7848         (svr4_handle_solib_event): Pass current_program_space to
7849         get_svr4_info.  Adjust disable_probes_interface cleanup.
7850         (svr4_create_probe_breakpoints): Add info parameter, pass it
7851         down to register_solib_event_probe.
7852         (svr4_create_solib_event_breakpoints): Add info parameter,
7853         pass it down to svr4_create_probe_breakpoints.
7854         (enable_break): Pass info down to
7855         svr4_create_solib_event_breakpoints.
7856         (svr4_solib_create_inferior_hook): Pass current_program_space to
7857         get_svr4_info.
7858         (svr4_clear_solib): Likewise.
7859
7860 2019-04-22  Pedro Alves  <palves@redhat.com>
7861
7862         * solib-svr4.c (svr4_free_objfile_observer): New.
7863         (probe_and_action::objfile): New field.
7864         (probes_table_htab_remove_objfile_probes)
7865         (probes_table_remove_objfile_probes): New functions.
7866         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7867         in the new probe_and_action.  Don't store the probe in 'lookup'.
7868         (svr4_create_probe_breakpoints): Pass objfile to
7869         register_solib_event_probe.
7870         (_initialize_svr4_solib): Register a free_objfile observer.
7871
7872 2019-04-19  Tom Tromey  <tom@tromey.com>
7873
7874         * common/queue.h: Remove.
7875
7876 2019-04-19  Tom Tromey  <tom@tromey.com>
7877
7878         * event-loop.c: Don't include "common/queue.h".
7879
7880 2019-04-19  Tom Tromey  <tom@tromey.com>
7881
7882         * remote.c (remote_target): Use delete.
7883         * remote-notif.h: Include <list>, not "common/queue.h".
7884         (notif_client_p): Remove typedef.
7885         (remote_notif_state): Add constructor, destructor, initializer.
7886         <notif_queue>: Now a std::list.
7887         (remote_notif_state_xfree): Don't declare.
7888         * remote-notif.c (remote_notif_process, handle_notification)
7889         (remote_notif_state_allocate): Update.
7890         (~remote_notif_state): Rename from remote_notif_state_xfree.
7891
7892 2019-04-19  Tom Tromey  <tom@tromey.com>
7893
7894         * symfile.c (reread_symbols): Update.
7895         * objfiles.c (objfile_register_static_link)
7896         (objfile_lookup_static_link): Update
7897         (~objfile) Don't delete static_links.
7898         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7899
7900 2019-04-19  Tom Tromey  <tom@tromey.com>
7901
7902         * type-stack.h (struct type_stack) <insert>: Constify string.
7903         * type-stack.c (type_stack::insert): Constify string.
7904         * gdbtypes.h (lookup_template_type): Update.
7905         (address_space_name_to_int): Update.
7906         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7907         const.
7908         (lookup_template_type): Make name const.
7909         * c-exp.y: Update rules.
7910         (lex_one_token, classify_name, classify_inner_name)
7911         (c_print_token): Update.
7912         * p-exp.y: Update rules.
7913         (yylex): Update.
7914         * f-exp.y: Update rules.
7915         (yylex): Update.
7916         * d-exp.y: Update rules.
7917         (lex_one_token, classify_name, classify_inner_name): Update.
7918         * parse.c (write_dollar_variable, copy_name): Return std::string.
7919         * parser-defs.h (copy_name): Change return type.
7920         * m2-exp.y: Update rules.
7921         (yylex): Update.
7922         * go-exp.y (lex_one_token): Update.
7923         Update rules.
7924         (classify_unsafe_function, classify_packaged_name)
7925         (classify_name, yylex): Update.
7926
7927 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7928
7929         * configure.ac: add --enable-source-highlight switch.
7930         * configure: Regenerate.
7931         * top.c (print_gdb_version): plumb --enable-source-highlight
7932         status to "show configuration".
7933
7934 2019-04-19  Tom Tromey  <tromey@adacore.com>
7935
7936         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7937         Check ADA_TYPE_P.
7938         (empty_record, ada_template_to_fixed_record_type_1)
7939         (template_to_static_fixed_type)
7940         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7941         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7942         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7943         macros.
7944
7945 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7946
7947         PR symtab/24423:
7948         * source.c (print_source_lines_base): Advance "iter" when a
7949         control character is seen.
7950
7951 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7952
7953         * inferior.h (struct infcall_suspend_state_deleter):
7954         Catch exception in destructor to avoid crash.
7955
7956 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7957
7958         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7959         close to the add_com "shell".
7960
7961 2019-04-18  Tom Tromey  <tromey@adacore.com>
7962
7963         * process-stratum-target.h (class process_stratum_target)
7964         <stratum>: Add "final".
7965
7966 2019-04-17  Tom Tromey  <tromey@adacore.com>
7967
7968         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7969         against nullptr before use.
7970
7971 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7972
7973         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7974
7975 2019-04-17  Jim Wilson  <jimw@sifive.com>
7976             Andrew Burgess  <andrew.burgess@embecosm.com>
7977
7978         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7979         code read might fail, assume 4-byte breakpoint in that case.
7980
7981 2019-04-15  Leszek Swirski  <leszeks@google.com>
7982
7983         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7984         rather than a hand-rolled POD check when checking for forced MEMORY
7985         classification.
7986
7987 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7988
7989         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7990         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7991         function.
7992         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7993         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7994         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7995         declaration.
7996
7997 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7998
7999         * aarch64-linux-nat.c
8000         (aarch64_linux_nat_target::thread_architecture): Add override.
8001         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8002         each VQ.
8003
8004 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8005
8006         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8007
8008 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8009
8010         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8011         target types of size 96-bits, add some additional comments, and
8012         check that the builtin type we found was the correct size.
8013
8014 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8015
8016         * utils.c (prompt_for_continue): Don't restore the styling at the
8017         end, as applied_style has the wrong value.  This fixes styling in
8018         long lists of file names that are interrupted by the "Continue?"
8019         prompt.
8020
8021 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8022
8023         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8024         * c-lang.c (c_language_defn): Likewise.
8025         (cplus_language_defn): Likewise.
8026         (asm_language_defn): Likewise.
8027         (minimal_language_defn): Likewise.
8028         * d-lang.c (d_language_defn): Likewise.
8029         * f-lang.c (f_language_defn): Likewise.
8030         * go-lang.c (go_language_defn): Likewise.
8031         * language.c (unknown_language_defn): Likewise.
8032         (auto_language_defn): Likewise.
8033         * language.h (struct language_defn): Remove la_magic field.
8034         (LANG_MAGIC): Delete.
8035         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8036         * objc-lang.c (objc_language_defn): Likewise.
8037         * opencl-lang.c (opencl_language_defn): Likewise.
8038         * p-lang.c (pascal_language_defn): Likewise.
8039         * rust-lang.c (rust_language_defn): Likewise.
8040
8041 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8042
8043         * riscv-tdep.c (riscv_type_align): New function.
8044         (riscv_type_alignment): Delete.
8045         (riscv_arg_location): Use 'type_align'.
8046         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8047
8048 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8049
8050         * gdbtypes.c (type_align): A struct with no non-static fields also
8051         has alignment of 1.
8052
8053 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8054
8055         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8056         component to 0.
8057         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8058         member.
8059         (riscv_struct_info::analyse): New implementation using new
8060         analyse_inner member function.
8061         (riscv_struct_info::field_offset): New member function.
8062         (riscv_struct_info::m_offsets): New member variable.
8063         (riscv_struct_info::analyse_inner): New private member function,
8064         takes the old implementation of riscv_struct_info::analyse but
8065         extended to track field offsets.
8066         (riscv_call_arg_struct): Update the struct folding special cases
8067         to handle cases where empty C++ structs, which are non-zero
8068         length, are found.
8069         (riscv_arg_location): Initialise the length of each location, a
8070         non-zero length now indicates the location is in use.
8071         (riscv_push_dummy_call): Allow for the first location having a
8072         non-zero offset when setting up arguments.
8073         (riscv_return_value): Likewise, but for return values.
8074
8075 2019-04-11  Tom Tromey  <tromey@adacore.com>
8076
8077         * utils.c (internal_vproblem): Make "msg" const.
8078
8079 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8080
8081         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8082         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8083         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8084         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8085
8086 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8087
8088         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8089         function.
8090         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8091         of amd64_collect_native_gregset.
8092         (amd64_linux_nat_target::store_registers): Likewise.
8093
8094 2019-04-10  Tom Tromey  <tom@tromey.com>
8095
8096         * symtab.c (lookup_global_symbol_from_objfile)
8097         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8098         * objfiles.h (class separate_debug_iterator): New.
8099         (class separate_debug_range): New.
8100         (struct objfile) <separate_debug_objfiles>: New method.
8101         (objfile_separate_debug_iterate): Don't declare.
8102         * objfiles.c (separate_debug_iterator::operator++): Rename from
8103         objfile_separate_debug_iterate.
8104         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8105         iterator.
8106         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8107         iterator.
8108
8109 2019-04-10  Tom Tromey  <tom@tromey.com>
8110
8111         * symfile.c (reread_symbols): Remove old comment.
8112         * objfiles.c (free_all_objfiles): Fix a typo.
8113
8114 2019-04-10  Tom Tromey  <tom@tromey.com>
8115
8116         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8117         * minsyms.c (lookup_minimal_symbol): Use foreach.
8118         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8119         (lookup_minimal_symbol_solib_trampoline): Likewise.
8120         * symfile.c (reread_symbols): Use foreach.
8121
8122 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8123             Tom Tromey  <tromey@adacore.com>
8124
8125         PR rust/24414:
8126         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8127         (rust_lex_int_test): Change "value" to be LONGEST.
8128         (rust_lex_tests): Add test for long integer literal.
8129
8130 2019-04-09  Tom Tromey  <tromey@adacore.com>
8131
8132         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8133         to bool.
8134         (extended_remote_target::attach): Update.
8135         (remote_target::remote_notice_new_inferior): Update.
8136         (remote_target::add_current_inferior_and_thread): Update.
8137         * inferior.c (exit_inferior_1): Use "false".
8138         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8139
8140 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8141
8142         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8143         the "start" command.
8144
8145 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8146
8147         * python/py-inferior.c (infpy_thread_from_thread_handle):
8148         Adjust comments to reflect renaming of thread_from_thread_handle
8149         to thread_from_handle.  Adjust keywords.  Fix type error message.
8150         (inferior_object_methods): Add thread_from_handle.  Retain
8151         thread_from_thread_handle, but mark it as deprecated.
8152
8153 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8154
8155         * gdbthread.h (find_thread_by_handle): Revise declaration.
8156         * thread.c (find_thread_by_handle): Likewise.  Adjust
8157         implementation too.
8158         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8159         support for buffer objects as handles.
8160
8161 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8162
8163         * python/py-infthread.c (thpy_thread_handle): New function.
8164         (thread_object_methods): Register thpy_thread_handle.
8165
8166 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8167
8168         * gdbthread.h (thread_to_thread_handle): Declare.
8169         * thread.c (gdbtypes.h): Include.
8170         (thread_to_thread_handle): New function.
8171
8172         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8173         (target_thread_info_to_thread_handle): Declare.
8174         * target.c (target_thread_info_to_thread_handle): New function.
8175         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8176         * target-delegates.c: Regenerate.
8177
8178         * linux-thread-db.c (class thread_db_target): Add method
8179         thread_info_to_thread_handle.
8180         (thread_db_target::thread_info_to_thread_handle): Define.
8181         * remote.c (class remote_target): Add new method
8182         thread_info_to_thread_handle.
8183         (remote_target::thread_info_to_thread_handle): Define.
8184
8185 2019-04-08  Pedro Alves  <palves@redhat.com>
8186
8187         * common/common-exceptions.c (throw_exception): Don't create
8188         named object to throw; throw directly.
8189         (throw_it): Likewise.  Don't initialize gdb_exception::message
8190         here, with new; pass FMT and AP to the ctor instead.
8191         * common/common-exceptions.h: Include <string>.
8192         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8193         const char *, va_list)): New ctor.  Use std::make_shared.
8194         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8195         errors)): Delete.
8196         (gdb_exception_error::gdb_exception_error(enum errors, const char
8197         *, va_list)): New.
8198         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8199         Add assertion.
8200         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8201         errors)): Delete.
8202         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8203         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8204         Add assertion.
8205
8206 2019-04-08  Tom Tromey  <tom@tromey.com>
8207
8208         * valops.c (value_rtti_indirect_type): Replace throw_exception
8209         with throw.
8210         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8211         with throw.
8212         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8213         throw.
8214         * target.c (target_translate_tls_address): Replace throw_exception
8215         with throw.
8216         * stack.c (frame_apply_command_count): Replace throw_exception
8217         with throw.
8218         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8219         throw.
8220         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8221         with throw.
8222         * rs6000-tdep.c (rs6000_frame_cache)
8223         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8224         * remote.c: Replace throw_exception with throw.
8225         * record-full.c (record_full_message, record_full_wait_1)
8226         (record_full_restore): Replace throw_exception with throw.
8227         * record-btrace.c:
8228         (get_thread_current_frame_id, record_btrace_start_replaying)
8229         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8230         (cmd_record_btrace_start): Replace throw_exception with throw.
8231         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8232         throw.
8233         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8234         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8235         * linespec.c:
8236         (find_linespec_symbols): Replace throw_exception with throw.
8237         * infrun.c (displaced_step_prepare, resume): Replace
8238         throw_exception with throw.
8239         * infcmd.c (post_create_inferior): Replace throw_exception with
8240         throw.
8241         * inf-loop.c (inferior_event_handler): Replace throw_exception
8242         with throw.
8243         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8244         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8245         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8246         (get_prev_frame_always, get_frame_pc_if_available)
8247         (get_frame_address_in_block_if_available, get_frame_language):
8248         Replace throw_exception with throw.
8249         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8250         throw_exception with throw.
8251         * eval.c (fetch_subexp_value, evaluate_var_value)
8252         (evaluate_funcall, evaluate_subexp_standard): Replace
8253         throw_exception with throw.
8254         * dwarf2loc.c (call_site_find_chain)
8255         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8256         Replace throw_exception with throw.
8257         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8258         with throw.
8259         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8260         throw.
8261         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8262         * completer.c (complete_line_internal): Replace throw_exception
8263         with throw.
8264         * compile/compile-object-run.c (compile_object_run): Replace
8265         throw_exception with throw.
8266         * cli/cli-script.c (process_next_line): Replace throw_exception
8267         with throw.
8268         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8269         (btrace_enable, btrace_maint_update_pt_packets): Replace
8270         throw_exception with throw.
8271         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8272         throw_exception with throw.
8273         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8274         throw_exception with throw.
8275         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8276         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8277         * aarch64-tdep.c (aarch64_make_prologue_cache)
8278         (aarch64_make_stub_cache): Replace throw_exception with throw.
8279
8280 2019-04-08  Tom Tromey  <tom@tromey.com>
8281
8282         * common/common-exceptions.c (throw_exception): Rename from
8283         throw_exception_cxx.  Remove old copy.  Make argument const.
8284         (throw_it): Create and throw exception objects directly.
8285         * common/common-exceptions.h (throw_exception): Make argument
8286         const.
8287         (struct gdb_exception_error): Add constructor.
8288         (struct gdb_exception_quit): Add constructor.
8289
8290 2019-04-08  Tom Tromey  <tom@tromey.com>
8291
8292         * common/common-exceptions.h (exception_rethrow): Don't declare.
8293         (TRY_SJLJ): Update comment.
8294         (TRY, CATCH, END_CATCH): Remove.
8295         * common/common-exceptions.c (exception_rethrow): Remove.
8296
8297 2019-04-08  Tom Tromey  <tom@tromey.com>
8298
8299         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8300         Remove.
8301         (gdb_exception_error): Rename from
8302         gdb_exception_RETURN_MASK_ERROR.
8303         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8304         (gdb_quit_bad_alloc): Update.
8305         * aarch64-tdep.c: Update.
8306         * ada-lang.c: Update.
8307         * ada-typeprint.c: Update.
8308         * ada-valprint.c: Update.
8309         * amd64-tdep.c: Update.
8310         * arch-utils.c: Update.
8311         * break-catch-throw.c: Update.
8312         * breakpoint.c: Update.
8313         * btrace.c: Update.
8314         * c-varobj.c: Update.
8315         * cli/cli-cmds.c: Update.
8316         * cli/cli-interp.c: Update.
8317         * cli/cli-script.c: Update.
8318         * common/common-exceptions.c: Update.
8319         * common/new-op.c: Update.
8320         * common/selftest.c: Update.
8321         * compile/compile-c-symbols.c: Update.
8322         * compile/compile-cplus-symbols.c: Update.
8323         * compile/compile-object-load.c: Update.
8324         * compile/compile-object-run.c: Update.
8325         * completer.c: Update.
8326         * corelow.c: Update.
8327         * cp-abi.c: Update.
8328         * cp-support.c: Update.
8329         * cp-valprint.c: Update.
8330         * darwin-nat.c: Update.
8331         * disasm-selftests.c: Update.
8332         * dtrace-probe.c: Update.
8333         * dwarf-index-cache.c: Update.
8334         * dwarf-index-write.c: Update.
8335         * dwarf2-frame-tailcall.c: Update.
8336         * dwarf2-frame.c: Update.
8337         * dwarf2loc.c: Update.
8338         * dwarf2read.c: Update.
8339         * eval.c: Update.
8340         * event-loop.c: Update.
8341         * event-top.c: Update.
8342         * exec.c: Update.
8343         * f-valprint.c: Update.
8344         * fbsd-tdep.c: Update.
8345         * frame-unwind.c: Update.
8346         * frame.c: Update.
8347         * gdbtypes.c: Update.
8348         * gnu-v3-abi.c: Update.
8349         * guile/guile-internal.h: Update.
8350         * guile/scm-block.c: Update.
8351         * guile/scm-breakpoint.c: Update.
8352         * guile/scm-cmd.c: Update.
8353         * guile/scm-disasm.c: Update.
8354         * guile/scm-frame.c: Update.
8355         * guile/scm-lazy-string.c: Update.
8356         * guile/scm-math.c: Update.
8357         * guile/scm-param.c: Update.
8358         * guile/scm-ports.c: Update.
8359         * guile/scm-pretty-print.c: Update.
8360         * guile/scm-symbol.c: Update.
8361         * guile/scm-symtab.c: Update.
8362         * guile/scm-type.c: Update.
8363         * guile/scm-value.c: Update.
8364         * i386-linux-tdep.c: Update.
8365         * i386-tdep.c: Update.
8366         * inf-loop.c: Update.
8367         * infcall.c: Update.
8368         * infcmd.c: Update.
8369         * infrun.c: Update.
8370         * jit.c: Update.
8371         * language.c: Update.
8372         * linespec.c: Update.
8373         * linux-fork.c: Update.
8374         * linux-nat.c: Update.
8375         * linux-tdep.c: Update.
8376         * linux-thread-db.c: Update.
8377         * main.c: Update.
8378         * mi/mi-cmd-break.c: Update.
8379         * mi/mi-cmd-stack.c: Update.
8380         * mi/mi-interp.c: Update.
8381         * mi/mi-main.c: Update.
8382         * objc-lang.c: Update.
8383         * p-valprint.c: Update.
8384         * parse.c: Update.
8385         * ppc-linux-tdep.c: Update.
8386         * printcmd.c: Update.
8387         * python/py-arch.c: Update.
8388         * python/py-breakpoint.c: Update.
8389         * python/py-cmd.c: Update.
8390         * python/py-finishbreakpoint.c: Update.
8391         * python/py-frame.c: Update.
8392         * python/py-framefilter.c: Update.
8393         * python/py-gdb-readline.c: Update.
8394         * python/py-inferior.c: Update.
8395         * python/py-infthread.c: Update.
8396         * python/py-lazy-string.c: Update.
8397         * python/py-linetable.c: Update.
8398         * python/py-objfile.c: Update.
8399         * python/py-param.c: Update.
8400         * python/py-prettyprint.c: Update.
8401         * python/py-progspace.c: Update.
8402         * python/py-record-btrace.c: Update.
8403         * python/py-record.c: Update.
8404         * python/py-symbol.c: Update.
8405         * python/py-type.c: Update.
8406         * python/py-unwind.c: Update.
8407         * python/py-utils.c: Update.
8408         * python/py-value.c: Update.
8409         * python/python.c: Update.
8410         * record-btrace.c: Update.
8411         * record-full.c: Update.
8412         * remote-fileio.c: Update.
8413         * remote.c: Update.
8414         * riscv-tdep.c: Update.
8415         * rs6000-aix-tdep.c: Update.
8416         * rs6000-tdep.c: Update.
8417         * rust-exp.y: Update.
8418         * rust-lang.c: Update.
8419         * s390-tdep.c: Update.
8420         * selftest-arch.c: Update.
8421         * solib-dsbt.c: Update.
8422         * solib-frv.c: Update.
8423         * solib-spu.c: Update.
8424         * solib-svr4.c: Update.
8425         * solib.c: Update.
8426         * sparc64-linux-tdep.c: Update.
8427         * stack.c: Update.
8428         * symfile-mem.c: Update.
8429         * symmisc.c: Update.
8430         * target.c: Update.
8431         * thread.c: Update.
8432         * top.c: Update.
8433         * tracefile-tfile.c: Update.
8434         * tui/tui.c: Update.
8435         * typeprint.c: Update.
8436         * unittests/cli-utils-selftests.c: Update.
8437         * unittests/parse-connection-spec-selftests.c: Update.
8438         * valops.c: Update.
8439         * valprint.c: Update.
8440         * value.c: Update.
8441         * varobj.c: Update.
8442         * windows-nat.c: Update.
8443         * x86-linux-nat.c: Update.
8444         * xml-support.c: Update.
8445
8446 2019-04-08  Tom Tromey  <tom@tromey.com>
8447
8448         * xml-support.c: Use C++ exception handling.
8449         * x86-linux-nat.c: Use C++ exception handling.
8450         * windows-nat.c: Use C++ exception handling.
8451         * varobj.c: Use C++ exception handling.
8452         * value.c: Use C++ exception handling.
8453         * valprint.c: Use C++ exception handling.
8454         * valops.c: Use C++ exception handling.
8455         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8456         handling.
8457         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8458         * typeprint.c: Use C++ exception handling.
8459         * tui/tui.c: Use C++ exception handling.
8460         * tracefile-tfile.c: Use C++ exception handling.
8461         * top.c: Use C++ exception handling.
8462         * thread.c: Use C++ exception handling.
8463         * target.c: Use C++ exception handling.
8464         * symmisc.c: Use C++ exception handling.
8465         * symfile-mem.c: Use C++ exception handling.
8466         * stack.c: Use C++ exception handling.
8467         * sparc64-linux-tdep.c: Use C++ exception handling.
8468         * solib.c: Use C++ exception handling.
8469         * solib-svr4.c: Use C++ exception handling.
8470         * solib-spu.c: Use C++ exception handling.
8471         * solib-frv.c: Use C++ exception handling.
8472         * solib-dsbt.c: Use C++ exception handling.
8473         * selftest-arch.c: Use C++ exception handling.
8474         * s390-tdep.c: Use C++ exception handling.
8475         * rust-lang.c: Use C++ exception handling.
8476         * rust-exp.y: Use C++ exception handling.
8477         * rs6000-tdep.c: Use C++ exception handling.
8478         * rs6000-aix-tdep.c: Use C++ exception handling.
8479         * riscv-tdep.c: Use C++ exception handling.
8480         * remote.c: Use C++ exception handling.
8481         * remote-fileio.c: Use C++ exception handling.
8482         * record-full.c: Use C++ exception handling.
8483         * record-btrace.c: Use C++ exception handling.
8484         * python/python.c: Use C++ exception handling.
8485         * python/py-value.c: Use C++ exception handling.
8486         * python/py-utils.c: Use C++ exception handling.
8487         * python/py-unwind.c: Use C++ exception handling.
8488         * python/py-type.c: Use C++ exception handling.
8489         * python/py-symbol.c: Use C++ exception handling.
8490         * python/py-record.c: Use C++ exception handling.
8491         * python/py-record-btrace.c: Use C++ exception handling.
8492         * python/py-progspace.c: Use C++ exception handling.
8493         * python/py-prettyprint.c: Use C++ exception handling.
8494         * python/py-param.c: Use C++ exception handling.
8495         * python/py-objfile.c: Use C++ exception handling.
8496         * python/py-linetable.c: Use C++ exception handling.
8497         * python/py-lazy-string.c: Use C++ exception handling.
8498         * python/py-infthread.c: Use C++ exception handling.
8499         * python/py-inferior.c: Use C++ exception handling.
8500         * python/py-gdb-readline.c: Use C++ exception handling.
8501         * python/py-framefilter.c: Use C++ exception handling.
8502         * python/py-frame.c: Use C++ exception handling.
8503         * python/py-finishbreakpoint.c: Use C++ exception handling.
8504         * python/py-cmd.c: Use C++ exception handling.
8505         * python/py-breakpoint.c: Use C++ exception handling.
8506         * python/py-arch.c: Use C++ exception handling.
8507         * printcmd.c: Use C++ exception handling.
8508         * ppc-linux-tdep.c: Use C++ exception handling.
8509         * parse.c: Use C++ exception handling.
8510         * p-valprint.c: Use C++ exception handling.
8511         * objc-lang.c: Use C++ exception handling.
8512         * mi/mi-main.c: Use C++ exception handling.
8513         * mi/mi-interp.c: Use C++ exception handling.
8514         * mi/mi-cmd-stack.c: Use C++ exception handling.
8515         * mi/mi-cmd-break.c: Use C++ exception handling.
8516         * main.c: Use C++ exception handling.
8517         * linux-thread-db.c: Use C++ exception handling.
8518         * linux-tdep.c: Use C++ exception handling.
8519         * linux-nat.c: Use C++ exception handling.
8520         * linux-fork.c: Use C++ exception handling.
8521         * linespec.c: Use C++ exception handling.
8522         * language.c: Use C++ exception handling.
8523         * jit.c: Use C++ exception handling.
8524         * infrun.c: Use C++ exception handling.
8525         * infcmd.c: Use C++ exception handling.
8526         * infcall.c: Use C++ exception handling.
8527         * inf-loop.c: Use C++ exception handling.
8528         * i386-tdep.c: Use C++ exception handling.
8529         * i386-linux-tdep.c: Use C++ exception handling.
8530         * guile/scm-value.c: Use C++ exception handling.
8531         * guile/scm-type.c: Use C++ exception handling.
8532         * guile/scm-symtab.c: Use C++ exception handling.
8533         * guile/scm-symbol.c: Use C++ exception handling.
8534         * guile/scm-pretty-print.c: Use C++ exception handling.
8535         * guile/scm-ports.c: Use C++ exception handling.
8536         * guile/scm-param.c: Use C++ exception handling.
8537         * guile/scm-math.c: Use C++ exception handling.
8538         * guile/scm-lazy-string.c: Use C++ exception handling.
8539         * guile/scm-frame.c: Use C++ exception handling.
8540         * guile/scm-disasm.c: Use C++ exception handling.
8541         * guile/scm-cmd.c: Use C++ exception handling.
8542         * guile/scm-breakpoint.c: Use C++ exception handling.
8543         * guile/scm-block.c: Use C++ exception handling.
8544         * guile/guile-internal.h: Use C++ exception handling.
8545         * gnu-v3-abi.c: Use C++ exception handling.
8546         * gdbtypes.c: Use C++ exception handling.
8547         * frame.c: Use C++ exception handling.
8548         * frame-unwind.c: Use C++ exception handling.
8549         * fbsd-tdep.c: Use C++ exception handling.
8550         * f-valprint.c: Use C++ exception handling.
8551         * exec.c: Use C++ exception handling.
8552         * event-top.c: Use C++ exception handling.
8553         * event-loop.c: Use C++ exception handling.
8554         * eval.c: Use C++ exception handling.
8555         * dwarf2read.c: Use C++ exception handling.
8556         * dwarf2loc.c: Use C++ exception handling.
8557         * dwarf2-frame.c: Use C++ exception handling.
8558         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8559         * dwarf-index-write.c: Use C++ exception handling.
8560         * dwarf-index-cache.c: Use C++ exception handling.
8561         * dtrace-probe.c: Use C++ exception handling.
8562         * disasm-selftests.c: Use C++ exception handling.
8563         * darwin-nat.c: Use C++ exception handling.
8564         * cp-valprint.c: Use C++ exception handling.
8565         * cp-support.c: Use C++ exception handling.
8566         * cp-abi.c: Use C++ exception handling.
8567         * corelow.c: Use C++ exception handling.
8568         * completer.c: Use C++ exception handling.
8569         * compile/compile-object-run.c: Use C++ exception handling.
8570         * compile/compile-object-load.c: Use C++ exception handling.
8571         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8572         * compile/compile-c-symbols.c: Use C++ exception handling.
8573         * common/selftest.c: Use C++ exception handling.
8574         * common/new-op.c: Use C++ exception handling.
8575         * cli/cli-script.c: Use C++ exception handling.
8576         * cli/cli-interp.c: Use C++ exception handling.
8577         * cli/cli-cmds.c: Use C++ exception handling.
8578         * c-varobj.c: Use C++ exception handling.
8579         * btrace.c: Use C++ exception handling.
8580         * breakpoint.c: Use C++ exception handling.
8581         * break-catch-throw.c: Use C++ exception handling.
8582         * arch-utils.c: Use C++ exception handling.
8583         * amd64-tdep.c: Use C++ exception handling.
8584         * ada-valprint.c: Use C++ exception handling.
8585         * ada-typeprint.c: Use C++ exception handling.
8586         * ada-lang.c: Use C++ exception handling.
8587         * aarch64-tdep.c: Use C++ exception handling.
8588
8589 2019-04-08  Tom Tromey  <tom@tromey.com>
8590
8591         * xml-support.c (gdb_xml_parser::parse): Update.
8592         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8593         * value.c (show_convenience): Update.
8594         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8595         (test_parse_flags_qcs): Update.
8596         * thread.c (thr_try_catch_cmd): Update.
8597         * target.c (target_translate_tls_address): Update.
8598         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8599         (info_frame_command_core, frame_apply_command_count): Update.
8600         * rust-exp.y (rust_lex_exception_test): Update.
8601         * riscv-tdep.c (riscv_print_one_register_info): Update.
8602         * remote.c (remote_target::enable_btrace): Update.
8603         * record-btrace.c (record_btrace_enable_warn): Update.
8604         * python/py-utils.c (gdbpy_convert_exception): Update.
8605         * printcmd.c (do_one_display, print_variable_and_value): Update.
8606         * mi/mi-main.c (mi_print_exception): Update.
8607         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8608         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8609         * linux-nat.c (linux_nat_target::attach): Update.
8610         * linux-fork.c (class scoped_switch_fork_info): Update.
8611         * infrun.c (displaced_step_prepare): Update.
8612         * infcall.c (call_function_by_hand_dummy): Update.
8613         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8614         * gnu-v3-abi.c (print_one_vtable): Update.
8615         * frame.c (get_prev_frame_always): Update.
8616         * f-valprint.c (info_common_command_for_block): Update.
8617         * exec.c (try_open_exec_file): Update.
8618         * exceptions.c (print_exception, exception_print)
8619         (exception_fprintf, exception_print_same): Update.
8620         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8621         * dwarf-index-cache.c (index_cache::store)
8622         (index_cache::lookup_gdb_index): Update.
8623         * darwin-nat.c (maybe_cache_shell): Update.
8624         * cp-valprint.c (cp_print_value_fields): Update.
8625         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8626         (gcc_cplus_symbol_address): Update.
8627         * compile/compile-c-symbols.c (gcc_convert_symbol)
8628         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8629         * common/selftest.c: Update.
8630         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8631         a std::string.
8632         (exception_try_scope_entry, exception_try_scope_exit): Don't
8633         declare.
8634         (struct exception_try_scope): Remove.
8635         (TRY): Don't use exception_try_scope.
8636         (struct gdb_exception): Add constructor, operator=.
8637         <what>: New method.
8638         (struct gdb_exception_RETURN_MASK_ALL)
8639         (struct gdb_exception_RETURN_MASK_ERROR)
8640         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8641         (struct gdb_quit_bad_alloc): Update.
8642         * common/common-exceptions.c (exception_none): Change
8643         initializer.
8644         (struct catcher) <state, exception>: Initialize inline.
8645         <prev>: Remove member.
8646         (current_catcher): Remove.
8647         (catchers): New global.
8648         (exceptions_state_mc_init): Simplify.
8649         (catcher_pop): Remove.
8650         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8651         (try_scope_depth, exception_try_scope_entry)
8652         (exception_try_scope_exit): Remove.
8653         (throw_exception_sjlj): Update.
8654         (exception_messages, exception_messages_size): Remove.
8655         (throw_it): Simplify.
8656         (gdb_exception_sliced_copy): Remove.
8657         (throw_exception_cxx): Update.
8658         * cli/cli-script.c (script_from_file): Update.
8659         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8660         Update.
8661         * ada-valprint.c (ada_val_print): Update.
8662         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8663         (create_excep_cond_exprs): Update.
8664
8665 2019-04-08  Tom Tromey  <tom@tromey.com>
8666
8667         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8668         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8669         (TRY, CATCH, END_CATCH): Remove some definitions.
8670         * common/common-exceptions.c: Don't use GDB_XCPT.
8671         (catcher_list_size): Remove.
8672         (throw_exception, throw_it): Simplify.
8673
8674 2019-04-05  Tom Tromey  <tom@tromey.com>
8675
8676         Revert the header-sorting patch.
8677         * ft32-tdep.c: Revert.
8678         * frv-tdep.c: Revert.
8679         * frv-linux-tdep.c: Revert.
8680         * frame.c: Revert.
8681         * frame-unwind.c: Revert.
8682         * frame-base.c: Revert.
8683         * fork-child.c: Revert.
8684         * findvar.c: Revert.
8685         * findcmd.c: Revert.
8686         * filesystem.c: Revert.
8687         * filename-seen-cache.h: Revert.
8688         * filename-seen-cache.c: Revert.
8689         * fbsd-tdep.c: Revert.
8690         * fbsd-nat.h: Revert.
8691         * fbsd-nat.c: Revert.
8692         * f-valprint.c: Revert.
8693         * f-typeprint.c: Revert.
8694         * f-lang.c: Revert.
8695         * extension.h: Revert.
8696         * extension.c: Revert.
8697         * extension-priv.h: Revert.
8698         * expprint.c: Revert.
8699         * exec.h: Revert.
8700         * exec.c: Revert.
8701         * exceptions.c: Revert.
8702         * event-top.c: Revert.
8703         * event-loop.c: Revert.
8704         * eval.c: Revert.
8705         * elfread.c: Revert.
8706         * dwarf2read.h: Revert.
8707         * dwarf2read.c: Revert.
8708         * dwarf2loc.c: Revert.
8709         * dwarf2expr.h: Revert.
8710         * dwarf2expr.c: Revert.
8711         * dwarf2-frame.c: Revert.
8712         * dwarf2-frame-tailcall.c: Revert.
8713         * dwarf-index-write.h: Revert.
8714         * dwarf-index-write.c: Revert.
8715         * dwarf-index-common.c: Revert.
8716         * dwarf-index-cache.h: Revert.
8717         * dwarf-index-cache.c: Revert.
8718         * dummy-frame.c: Revert.
8719         * dtrace-probe.c: Revert.
8720         * disasm.h: Revert.
8721         * disasm.c: Revert.
8722         * disasm-selftests.c: Revert.
8723         * dictionary.c: Revert.
8724         * dicos-tdep.c: Revert.
8725         * demangle.c: Revert.
8726         * dcache.h: Revert.
8727         * dcache.c: Revert.
8728         * darwin-nat.h: Revert.
8729         * darwin-nat.c: Revert.
8730         * darwin-nat-info.c: Revert.
8731         * d-valprint.c: Revert.
8732         * d-namespace.c: Revert.
8733         * d-lang.c: Revert.
8734         * ctf.c: Revert.
8735         * csky-tdep.c: Revert.
8736         * csky-linux-tdep.c: Revert.
8737         * cris-tdep.c: Revert.
8738         * cris-linux-tdep.c: Revert.
8739         * cp-valprint.c: Revert.
8740         * cp-support.c: Revert.
8741         * cp-namespace.c: Revert.
8742         * cp-abi.c: Revert.
8743         * corelow.c: Revert.
8744         * corefile.c: Revert.
8745         * continuations.c: Revert.
8746         * completer.h: Revert.
8747         * completer.c: Revert.
8748         * complaints.c: Revert.
8749         * coffread.c: Revert.
8750         * coff-pe-read.c: Revert.
8751         * cli-out.h: Revert.
8752         * cli-out.c: Revert.
8753         * charset.c: Revert.
8754         * c-varobj.c: Revert.
8755         * c-valprint.c: Revert.
8756         * c-typeprint.c: Revert.
8757         * c-lang.c: Revert.
8758         * buildsym.c: Revert.
8759         * buildsym-legacy.c: Revert.
8760         * build-id.h: Revert.
8761         * build-id.c: Revert.
8762         * btrace.c: Revert.
8763         * bsd-uthread.c: Revert.
8764         * breakpoint.h: Revert.
8765         * breakpoint.c: Revert.
8766         * break-catch-throw.c: Revert.
8767         * break-catch-syscall.c: Revert.
8768         * break-catch-sig.c: Revert.
8769         * blockframe.c: Revert.
8770         * block.c: Revert.
8771         * bfin-tdep.c: Revert.
8772         * bfin-linux-tdep.c: Revert.
8773         * bfd-target.c: Revert.
8774         * bcache.c: Revert.
8775         * ax-general.c: Revert.
8776         * ax-gdb.h: Revert.
8777         * ax-gdb.c: Revert.
8778         * avr-tdep.c: Revert.
8779         * auxv.c: Revert.
8780         * auto-load.c: Revert.
8781         * arm-wince-tdep.c: Revert.
8782         * arm-tdep.c: Revert.
8783         * arm-symbian-tdep.c: Revert.
8784         * arm-pikeos-tdep.c: Revert.
8785         * arm-obsd-tdep.c: Revert.
8786         * arm-nbsd-tdep.c: Revert.
8787         * arm-nbsd-nat.c: Revert.
8788         * arm-linux-tdep.c: Revert.
8789         * arm-linux-nat.c: Revert.
8790         * arm-fbsd-tdep.c: Revert.
8791         * arm-fbsd-nat.c: Revert.
8792         * arm-bsd-tdep.c: Revert.
8793         * arch-utils.c: Revert.
8794         * arc-tdep.c: Revert.
8795         * arc-newlib-tdep.c: Revert.
8796         * annotate.h: Revert.
8797         * annotate.c: Revert.
8798         * amd64-windows-tdep.c: Revert.
8799         * amd64-windows-nat.c: Revert.
8800         * amd64-tdep.c: Revert.
8801         * amd64-sol2-tdep.c: Revert.
8802         * amd64-obsd-tdep.c: Revert.
8803         * amd64-obsd-nat.c: Revert.
8804         * amd64-nbsd-tdep.c: Revert.
8805         * amd64-nbsd-nat.c: Revert.
8806         * amd64-nat.c: Revert.
8807         * amd64-linux-tdep.c: Revert.
8808         * amd64-linux-nat.c: Revert.
8809         * amd64-fbsd-tdep.c: Revert.
8810         * amd64-fbsd-nat.c: Revert.
8811         * amd64-dicos-tdep.c: Revert.
8812         * amd64-darwin-tdep.c: Revert.
8813         * amd64-bsd-nat.c: Revert.
8814         * alpha-tdep.c: Revert.
8815         * alpha-obsd-tdep.c: Revert.
8816         * alpha-nbsd-tdep.c: Revert.
8817         * alpha-mdebug-tdep.c: Revert.
8818         * alpha-linux-tdep.c: Revert.
8819         * alpha-linux-nat.c: Revert.
8820         * alpha-bsd-tdep.c: Revert.
8821         * alpha-bsd-nat.c: Revert.
8822         * aix-thread.c: Revert.
8823         * agent.c: Revert.
8824         * addrmap.c: Revert.
8825         * ada-varobj.c: Revert.
8826         * ada-valprint.c: Revert.
8827         * ada-typeprint.c: Revert.
8828         * ada-tasks.c: Revert.
8829         * ada-lang.c: Revert.
8830         * aarch64-tdep.c: Revert.
8831         * aarch64-ravenscar-thread.c: Revert.
8832         * aarch64-newlib-tdep.c: Revert.
8833         * aarch64-linux-tdep.c: Revert.
8834         * aarch64-linux-nat.c: Revert.
8835         * aarch64-fbsd-tdep.c: Revert.
8836         * aarch64-fbsd-nat.c: Revert.
8837         * aarch32-linux-nat.c: Revert.
8838
8839 2019-04-05  Tom Tromey  <tom@tromey.com>
8840
8841         * ft32-tdep.c: Sort headers.
8842         * frv-tdep.c: Sort headers.
8843         * frv-linux-tdep.c: Sort headers.
8844         * frame.c: Sort headers.
8845         * frame-unwind.c: Sort headers.
8846         * frame-base.c: Sort headers.
8847         * fork-child.c: Sort headers.
8848         * findvar.c: Sort headers.
8849         * findcmd.c: Sort headers.
8850         * filesystem.c: Sort headers.
8851         * filename-seen-cache.h: Sort headers.
8852         * filename-seen-cache.c: Sort headers.
8853         * fbsd-tdep.c: Sort headers.
8854         * fbsd-nat.h: Sort headers.
8855         * fbsd-nat.c: Sort headers.
8856         * f-valprint.c: Sort headers.
8857         * f-typeprint.c: Sort headers.
8858         * f-lang.c: Sort headers.
8859         * extension.h: Sort headers.
8860         * extension.c: Sort headers.
8861         * extension-priv.h: Sort headers.
8862         * expprint.c: Sort headers.
8863         * exec.h: Sort headers.
8864         * exec.c: Sort headers.
8865         * exceptions.c: Sort headers.
8866         * event-top.c: Sort headers.
8867         * event-loop.c: Sort headers.
8868         * eval.c: Sort headers.
8869         * elfread.c: Sort headers.
8870         * dwarf2read.h: Sort headers.
8871         * dwarf2read.c: Sort headers.
8872         * dwarf2loc.c: Sort headers.
8873         * dwarf2expr.h: Sort headers.
8874         * dwarf2expr.c: Sort headers.
8875         * dwarf2-frame.c: Sort headers.
8876         * dwarf2-frame-tailcall.c: Sort headers.
8877         * dwarf-index-write.h: Sort headers.
8878         * dwarf-index-write.c: Sort headers.
8879         * dwarf-index-common.c: Sort headers.
8880         * dwarf-index-cache.h: Sort headers.
8881         * dwarf-index-cache.c: Sort headers.
8882         * dummy-frame.c: Sort headers.
8883         * dtrace-probe.c: Sort headers.
8884         * disasm.h: Sort headers.
8885         * disasm.c: Sort headers.
8886         * disasm-selftests.c: Sort headers.
8887         * dictionary.c: Sort headers.
8888         * dicos-tdep.c: Sort headers.
8889         * demangle.c: Sort headers.
8890         * dcache.h: Sort headers.
8891         * dcache.c: Sort headers.
8892         * darwin-nat.h: Sort headers.
8893         * darwin-nat.c: Sort headers.
8894         * darwin-nat-info.c: Sort headers.
8895         * d-valprint.c: Sort headers.
8896         * d-namespace.c: Sort headers.
8897         * d-lang.c: Sort headers.
8898         * ctf.c: Sort headers.
8899         * csky-tdep.c: Sort headers.
8900         * csky-linux-tdep.c: Sort headers.
8901         * cris-tdep.c: Sort headers.
8902         * cris-linux-tdep.c: Sort headers.
8903         * cp-valprint.c: Sort headers.
8904         * cp-support.c: Sort headers.
8905         * cp-namespace.c: Sort headers.
8906         * cp-abi.c: Sort headers.
8907         * corelow.c: Sort headers.
8908         * corefile.c: Sort headers.
8909         * continuations.c: Sort headers.
8910         * completer.h: Sort headers.
8911         * completer.c: Sort headers.
8912         * complaints.c: Sort headers.
8913         * coffread.c: Sort headers.
8914         * coff-pe-read.c: Sort headers.
8915         * cli-out.h: Sort headers.
8916         * cli-out.c: Sort headers.
8917         * charset.c: Sort headers.
8918         * c-varobj.c: Sort headers.
8919         * c-valprint.c: Sort headers.
8920         * c-typeprint.c: Sort headers.
8921         * c-lang.c: Sort headers.
8922         * buildsym.c: Sort headers.
8923         * buildsym-legacy.c: Sort headers.
8924         * build-id.h: Sort headers.
8925         * build-id.c: Sort headers.
8926         * btrace.c: Sort headers.
8927         * bsd-uthread.c: Sort headers.
8928         * breakpoint.h: Sort headers.
8929         * breakpoint.c: Sort headers.
8930         * break-catch-throw.c: Sort headers.
8931         * break-catch-syscall.c: Sort headers.
8932         * break-catch-sig.c: Sort headers.
8933         * blockframe.c: Sort headers.
8934         * block.c: Sort headers.
8935         * bfin-tdep.c: Sort headers.
8936         * bfin-linux-tdep.c: Sort headers.
8937         * bfd-target.c: Sort headers.
8938         * bcache.c: Sort headers.
8939         * ax-general.c: Sort headers.
8940         * ax-gdb.h: Sort headers.
8941         * ax-gdb.c: Sort headers.
8942         * avr-tdep.c: Sort headers.
8943         * auxv.c: Sort headers.
8944         * auto-load.c: Sort headers.
8945         * arm-wince-tdep.c: Sort headers.
8946         * arm-tdep.c: Sort headers.
8947         * arm-symbian-tdep.c: Sort headers.
8948         * arm-pikeos-tdep.c: Sort headers.
8949         * arm-obsd-tdep.c: Sort headers.
8950         * arm-nbsd-tdep.c: Sort headers.
8951         * arm-nbsd-nat.c: Sort headers.
8952         * arm-linux-tdep.c: Sort headers.
8953         * arm-linux-nat.c: Sort headers.
8954         * arm-fbsd-tdep.c: Sort headers.
8955         * arm-fbsd-nat.c: Sort headers.
8956         * arm-bsd-tdep.c: Sort headers.
8957         * arch-utils.c: Sort headers.
8958         * arc-tdep.c: Sort headers.
8959         * arc-newlib-tdep.c: Sort headers.
8960         * annotate.h: Sort headers.
8961         * annotate.c: Sort headers.
8962         * amd64-windows-tdep.c: Sort headers.
8963         * amd64-windows-nat.c: Sort headers.
8964         * amd64-tdep.c: Sort headers.
8965         * amd64-sol2-tdep.c: Sort headers.
8966         * amd64-obsd-tdep.c: Sort headers.
8967         * amd64-obsd-nat.c: Sort headers.
8968         * amd64-nbsd-tdep.c: Sort headers.
8969         * amd64-nbsd-nat.c: Sort headers.
8970         * amd64-nat.c: Sort headers.
8971         * amd64-linux-tdep.c: Sort headers.
8972         * amd64-linux-nat.c: Sort headers.
8973         * amd64-fbsd-tdep.c: Sort headers.
8974         * amd64-fbsd-nat.c: Sort headers.
8975         * amd64-dicos-tdep.c: Sort headers.
8976         * amd64-darwin-tdep.c: Sort headers.
8977         * amd64-bsd-nat.c: Sort headers.
8978         * alpha-tdep.c: Sort headers.
8979         * alpha-obsd-tdep.c: Sort headers.
8980         * alpha-nbsd-tdep.c: Sort headers.
8981         * alpha-mdebug-tdep.c: Sort headers.
8982         * alpha-linux-tdep.c: Sort headers.
8983         * alpha-linux-nat.c: Sort headers.
8984         * alpha-bsd-tdep.c: Sort headers.
8985         * alpha-bsd-nat.c: Sort headers.
8986         * aix-thread.c: Sort headers.
8987         * agent.c: Sort headers.
8988         * addrmap.c: Sort headers.
8989         * ada-varobj.c: Sort headers.
8990         * ada-valprint.c: Sort headers.
8991         * ada-typeprint.c: Sort headers.
8992         * ada-tasks.c: Sort headers.
8993         * ada-lang.c: Sort headers.
8994         * aarch64-tdep.c: Sort headers.
8995         * aarch64-ravenscar-thread.c: Sort headers.
8996         * aarch64-newlib-tdep.c: Sort headers.
8997         * aarch64-linux-tdep.c: Sort headers.
8998         * aarch64-linux-nat.c: Sort headers.
8999         * aarch64-fbsd-tdep.c: Sort headers.
9000         * aarch64-fbsd-nat.c: Sort headers.
9001         * aarch32-linux-nat.c: Sort headers.
9002
9003 2019-04-04  Tom Tromey  <tom@tromey.com>
9004
9005         * varobj.c (varobj_create): Update.
9006         * rust-exp.y (struct rust_parser) <update_innermost_block,
9007         lookup_symbol>: New methods.
9008         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9009         Rename.
9010         (rust_parser::rust_lookup_type)
9011         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9012         * printcmd.c (display_command, do_one_display): Update.
9013         * parser-defs.h (struct parser_state) <parser_state>: Add
9014         "tracker" parameter.
9015         (block_tracker): New member.
9016         (class innermost_block_tracker) <innermost_block_tracker>: Add
9017         "types" parameter.
9018         <reset>: Remove method.
9019         (innermost_block): Don't declare.
9020         (null_post_parser): Update.
9021         * parse.c (innermost_block): Remove global.
9022         (write_dollar_variable): Update.
9023         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9024         Remove "tracker_types" parameter.
9025         (parse_expression): Add "tracker" parameter.
9026         (parse_expression_for_completion): Update.
9027         (null_post_parser): Add "tracker" parameter.
9028         * p-exp.y: Update rules.
9029         * m2-exp.y: Update rules.
9030         * language.h (struct language_defn) <la_post_parser>: Add
9031         "tracker" parameter.
9032         * go-exp.y: Update rules.
9033         * f-exp.y: Update rules.
9034         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9035         parameter.
9036         * d-exp.y: Update rules.
9037         * c-exp.y: Update rules.
9038         * breakpoint.c (set_breakpoint_condition): Create an
9039         innermost_block_tracker.
9040         (watch_command_1): Likewise.
9041         * ada-lang.c (resolve): Add "tracker" parameter.
9042         (resolve_subexp): Likewise.
9043         * ada-exp.y (write_var_from_sym): Update.
9044
9045 2019-04-04  Tom Tromey  <tom@tromey.com>
9046
9047         * type-stack.h: New file.
9048         * type-stack.c: New file.
9049         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9050         type-stack.h.
9051         (insert_into_type_stack, insert_type, push_type, push_type_int)
9052         (insert_type_address_space, pop_type, pop_type_int)
9053         (pop_typelist, pop_type_stack, append_type_stack)
9054         (push_type_stack, get_type_stack, push_typelist)
9055         (follow_type_instance_flags, follow_types): Don't declare.
9056         * parse.c (type_stack): Remove global.
9057         (parse_exp_in_context): Update.
9058         (insert_into_type_stack, insert_type, push_type, push_type_int)
9059         (insert_type_address_space, pop_type, pop_type_int)
9060         (pop_typelist, pop_type_stack, append_type_stack)
9061         (push_type_stack, get_type_stack, push_typelist)
9062         (follow_type_instance_flags, follow_types): Remove (moved to
9063         type-stack.c).
9064         * f-exp.y (type_stack): New global.
9065         Update rules.
9066         (push_kind_type, f_parse): Update.
9067         * d-exp.y (type_stack): New global.
9068         Update rules.
9069         (d_parse): Update.
9070         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9071         Update rules.
9072         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9073         (HFILES_NO_SRCDIR): Add type-stack.h.
9074
9075 2019-04-04  Tom Tromey  <tom@tromey.com>
9076
9077         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9078         (rust_parser::convert_ast_to_expression, rust_parse)
9079         (rust_lex_test_completion, rust_lex_tests): Update.
9080         * parser-defs.h (struct expr_completion_state): New.
9081         (struct parser_state) <parser_state>: Add completion parameter.
9082         <mark_struct_expression, mark_completion_tag>: New methods.
9083         <parse_completion, m_completion_state>: New members.
9084         (prefixify_expression, null_post_parser): Update.
9085         (mark_struct_expression, mark_completion_tag): Don't declare.
9086         * parse.c (parse_completion, expout_last_struct)
9087         (expout_tag_completion_type, expout_completion_name): Remove
9088         globals.
9089         (parser_state::mark_struct_expression)
9090         (parser_state::mark_completion_tag): Now methods.
9091         (prefixify_expression): Add last_struct parameter.
9092         (prefixify_subexp): Likewise.
9093         (parse_exp_1): Update.
9094         (parse_exp_in_context): Add cstate parameter.  Update.
9095         (parse_expression_for_completion): Create an
9096         expr_completion_state.
9097         (null_post_parser): Add "completion" parameter.
9098         * p-exp.y: Update rules.
9099         (yylex): Update.
9100         * language.h (struct language_defn) <la_post_parser>: Add
9101         "completing" parameter.
9102         * go-exp.y: Update rules.
9103         (lex_one_token): Update.
9104         * expression.h (parse_completion): Don't declare.
9105         * d-exp.y: Update rules.
9106         (lex_one_token): Update rules.
9107         * c-exp.y: Update rules.
9108         (lex_one_token): Update.
9109         * ada-lang.c (resolve): Add "parse_completion" parameter.
9110         (resolve_subexp): Likewise.
9111         (ada_resolve_function): Likewise.
9112
9113 2019-04-04  Tom Tromey  <tom@tromey.com>
9114
9115         * parser-defs.h (struct parser_state) <start_arglist,
9116         end_arglist>: New methods.
9117         <arglist_len, m_funcall_chain>: New members.
9118         (arglist_len, start_arglist, end_arglist): Don't declare.
9119         * parse.c (arglist_len, funcall_chain): Remove global.
9120         (start_arglist, end_arglist): Remove functions.
9121         (parse_exp_in_context): Update.
9122         * p-exp.y: Update rules.
9123         * m2-exp.y: Update rules.
9124         * go-exp.y: Update rules.
9125         * f-exp.y: Update rules.
9126         * d-exp.y: Update rules.
9127         * c-exp.y: Update rules.
9128
9129 2019-04-04  Tom Tromey  <tom@tromey.com>
9130
9131         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9132         lex_operator, push_back>: New methods.
9133         Update all rules.
9134         (rust_parser::lex_hex, lex_escape): Rename and update.
9135         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9136         (rust_parser::lex_operator): Rename and update.
9137         (rust_parser::lex_number, rustyylex, rustyyerror)
9138         (rust_lex_test_init, rust_lex_test_sequence)
9139         (rust_lex_test_push_back, rust_lex_tests): Update.
9140         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9141         parameter.
9142         <lexptr, prev_lexptr>: New members.
9143         (lexptr, prev_lexptr): Don't declare.
9144         * parse.c (lexptr, prev_lexptr): Remove globals.
9145         (parse_exp_in_context): Update.
9146         * p-exp.y (yylex, yyerror): Update.
9147         * m2-exp.y (parse_number, yylex, yyerror): Update.
9148         * go-exp.y (lex_one_token, yyerror): Update.
9149         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9150         * d-exp.y (lex_one_token, yyerror): Update.
9151         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9152         (lex_one_token, yyerror): Update.
9153         * ada-lex.l (YY_INPUT): Update.
9154         (rewind_to_char): Update.
9155         * ada-exp.y (yyerror): Update.
9156
9157 2019-04-04  Tom Tromey  <tom@tromey.com>
9158
9159         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9160         * parser-defs.h (struct parser_state) <parser_state>: Add new
9161         parameter.
9162         <comma_terminates>: New member.
9163         (comma_terminates): Don't declare global.
9164         * parse.c (comma_terminates): Remove global.
9165         (parse_exp_in_context): Update.
9166         * p-exp.y (yylex): Update.
9167         * m2-exp.y (yylex): Update.
9168         * go-exp.y (lex_one_token): Update.
9169         * f-exp.y (yylex): Update.
9170         * d-exp.y (lex_one_token): Update.
9171         * c-exp.y (lex_one_token): Update.
9172         * ada-lex.l: Update.
9173
9174 2019-04-04  Tom Tromey  <tom@tromey.com>
9175
9176         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9177         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9178         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9179         * parser-defs.h (paren_depth): Don't declare.
9180         * parse.c (paren_depth): Remove global.
9181         (parse_exp_in_context): Update.
9182         * p-exp.y (paren_depth): New global.
9183         (pascal_parse): Initialize it.
9184         * m2-exp.y (paren_depth): New global.
9185         (m2_parse): Initialize it.
9186         * go-exp.y (paren_depth): New global.
9187         (go_parse): Initialize it.
9188         * f-exp.y (paren_depth): New global.
9189         (f_parse): Initialize it.
9190         * d-exp.y (paren_depth): New global.
9191         (d_parse): Initialize it.
9192         * c-exp.y (paren_depth): New global.
9193         (c_parse): Initialize it.
9194         * ada-lex.l (paren_depth): New global.
9195         (lexer_init): Initialize it.
9196
9197 2019-04-04  Tom Tromey  <tom@tromey.com>
9198
9199         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9200         (rust_parser::convert_ast_to_type)
9201         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9202         * parser-defs.h (struct parser_state) <parser_state>: Add
9203         parameters.  Initialize new members.
9204         <expression_context_block, expression_context_pc>: New members.
9205         * parse.c (expression_context_block, expression_context_pc):
9206         Remove globals.
9207         (parse_exp_in_context): Update.
9208         * p-exp.y: Update all rules.
9209         (yylex): Update.
9210         * m2-exp.y: Update all rules.
9211         (yylex): Update.
9212         * go-exp.y (yylex): Update.
9213         * f-exp.y (yylex): Update.
9214         * d-exp.y: Update all rules.
9215         (yylex): Update.
9216         * c-exp.y: Update all rules.
9217         (lex_one_token, classify_name, yylex, c_parse): Update.
9218         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9219
9220 2019-04-04  Tom Tromey  <tom@tromey.com>
9221
9222         * gdbarch.h, gdbarch.c: Rebuild.
9223         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9224         * stap-probe.h:
9225         (struct stap_parse_info): Replace "parser_state" with
9226         "expr_builder".
9227         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9228         (parser_state): New class.
9229         * parse.c (expr_builder): Rename.
9230         (expr_builder::release): Rename.
9231         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9232         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9233         (write_exp_elt_longcst, write_exp_elt_floatcst)
9234         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9235         (write_exp_string_vector, write_exp_bitstring)
9236         (write_exp_msymbol, mark_struct_expression)
9237         (write_dollar_variable)
9238         (insert_type_address_space, increase_expout_size): Replace
9239         "parser_state" with "expr_builder".
9240         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9241         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9242         "parser_state" with "expr_builder".
9243
9244 2019-04-04  Tom Tromey  <tom@tromey.com>
9245
9246         * rust-exp.y: Replace "parse_language" with method call.
9247         * p-exp.y:
9248         (yylex): Replace "parse_language" with method call.
9249         * m2-exp.y:
9250         (yylex): Replace "parse_language" with method call.
9251         * go-exp.y (classify_name): Replace "parse_language" with method
9252         call.
9253         * f-exp.y (yylex): Replace "parse_language" with method call.
9254         * d-exp.y (lex_one_token): Replace "parse_language" with method
9255         call.
9256         * c-exp.y:
9257         (lex_one_token, classify_name, yylex): Replace "parse_language"
9258         with method call.
9259         * ada-exp.y (find_primitive_type, type_char)
9260         (type_system_address): Replace "parse_language" with method call.
9261
9262 2019-04-04  Tom Tromey  <tom@tromey.com>
9263
9264         * rust-exp.y: Replace "parse_gdbarch" with method call.
9265         * parse.c (write_dollar_variable, insert_type_address_space):
9266         Replace "parse_gdbarch" with method call.
9267         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9268         call.
9269         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9270         call.
9271         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9272         "parse_gdbarch" with method call.
9273         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9274         with method call.
9275         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9276         "parse_gdbarch" with method call.
9277         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9278         "parse_gdbarch" with method call.
9279         * c-exp.y (parse_type, parse_number, classify_name): Replace
9280         "parse_gdbarch" with method call.
9281         * ada-lex.l: Replace "parse_gdbarch" with method call.
9282         * ada-exp.y (parse_type, find_primitive_type, type_char)
9283         (type_system_address): Replace "parse_gdbarch" with method call.
9284
9285 2019-04-04  Tom Tromey  <tom@tromey.com>
9286
9287         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9288         * stap-probe.c (stap_parse_argument): Update.
9289         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9290         initial_size parameter.
9291         * rust-exp.y (rust_lex_tests): Update.
9292         * parse.c (parser_state): Update.
9293         (parse_exp_in_context): Update.
9294         * parser-defs.h (struct parser_state) <parser_state>: Remove
9295         "initial_size" parameter.
9296
9297 2019-04-04  Tom Tromey  <tom@tromey.com>
9298
9299         * parser-defs.h (increase_expout_size): Don't declare.
9300         * parse.c (increase_expout_size): Now static.
9301
9302 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9303
9304         * gnu-nat.c (gnu_nat_target::wait): Fix
9305         target_waitstatus_to_string call.
9306
9307 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9308
9309         * eval.c (evaluate_subexp_standard): Handle internal functions
9310         during Fortran function call handling.
9311
9312 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * NEWS: Mention new internal functions.
9315         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9316         (read_base_type): Use dwarf2_init_complex_target_type.
9317         * value.c (creal_internal_fn): New function.
9318         (cimag_internal_fn): New function.
9319         (_initialize_values): Register new internal functions.
9320
9321 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9322
9323         * infrun.c (stop_all_threads): If debug_infrun, always
9324         trace the wait status after wait_one, using
9325         target_waitstatus_to_string and target_pid_to_str.
9326         (handle_inferior_event): Replace various trace of
9327         wait status kind by a single trace.
9328         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9329         wait status kind image by target_waitstatus_to_string.
9330         * target/waitstatus.c (target_waitstatus_to_string): Fix
9331         obsolete comment.
9332
9333 2019-04-01  Tom Tromey  <tromey@adacore.com>
9334
9335         PR symtab/23331:
9336         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9337
9338 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9339             Pedro Alves  <palves@redhat.com>
9340
9341         * top.c (quit_force): Call 'finalize_values'.
9342         * value.c (finalize_values): New function.
9343         * value.h (finalize_values): Declare.
9344
9345 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9346
9347         * NEWS: Announce $_gdb_major and $_gdb_minor.
9348
9349         * top.c (init_gdb_version_vars): New function.
9350         (gdb_init): Call init_gdb_version_vars.
9351
9352 2019-03-29  Tom Tromey  <tromey@adacore.com>
9353
9354         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9355         help text.  Remove dead code.
9356
9357 2019-03-29  Keith Seitz  <keiths@redhat.com>
9358
9359         From Siddhesh Poyarekar:
9360         * f-lang.h (f77_get_upperbound): Return LONGEST.
9361         (f77_get_lowerbound): Likewise.
9362         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9363         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9364         print them.
9365         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9366         plongest to format print it.
9367         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9368         (f77_get_upperbound): Likewise.
9369         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9370         LOWER_BOUND to LONGEST.
9371         (f77_create_arrayprint_offset_tbl): Likewise.
9372
9373 2019-03-29  Keith Seitz  <keiths@redhat.com>
9374
9375         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9376         %s/pulongest for TYPE_LENGTH instead of %d in format
9377         strings.
9378         * ada-typerint.c (ada_print_type): Likewise.
9379         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9380         * compile/compile-c-support.c (generate_register_struct): Likewise.
9381         * gdbtypes.c (recursive_dump_type): Likewise.
9382         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9383         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9384         instead of %d in format strings.
9385         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9386         to std::min to ULONGEST.
9387         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9388         instead of %d in format strings.
9389         * tracepoint.c (info_scope_command): Likewise.
9390         * typeprint.c (print_offset_data::update)
9391         (print_offset_data::finish): Likewise.
9392         * xtensa-tdep.c (xtensa_store_return_value)
9393         (xtensa_push_dummy_call): Likewise.
9394
9395 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9396
9397         * windows-nat.c (display_selector): Fixed format specifications
9398         for 64-bit Cygwin.
9399
9400 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9401
9402         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9403
9404 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9405
9406         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9407         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9408         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9409         (nios2_linux_init_abi): Install it.
9410
9411 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9412
9413         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9414
9415 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9416
9417         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9418
9419 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9420             Tom Tromey  <tromey@adacore.com>
9421
9422         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9423
9424 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9425
9426         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9427         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9428         method to compute the bounds of range types. Also print "[evaluated]"
9429         if the bounds' values come from a dynamic evaluation.
9430
9431 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9432
9433         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9434         whitespace when pretty printing is on.
9435
9436 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9437
9438         * ppc-linux-nat.c: Add include.
9439
9440 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9441
9442         * NEWS: Mention AArch64 Pointer Authentication.
9443
9444 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9445
9446         * arm-linux-nat.c: Add include.
9447
9448 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9449
9450         * source-cache.c (source_cache::get_source_lines): Re-read
9451         fullname after calling open_source_file.
9452
9453 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9454
9455         * NEWS: Mention TLS support for FreeBSD.
9456
9457 2019-03-25  Tom Tromey  <tromey@adacore.com>
9458
9459         * minsyms.c (BUNCH_SIZE): Update comment.
9460         (~minimal_symbol_reader): Remove old comment.
9461         (compact_minimal_symbols): Update comment.
9462         (minimal_symbol_reader::install): Remove old comment.  Update
9463         other comments.
9464
9465 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9466
9467         * s390-linux-nat.c: Add include.
9468
9469 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9470
9471         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9472         Call linux_get_hwcap.
9473         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9474         Likewise.
9475         (aarch64_linux_get_hwcap): Remove function.
9476         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9477         declaration.
9478         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9479         linux_get_hwcap.
9480         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9481         * linux-tdep.c (linux_get_hwcap): Add function.
9482         (linux_get_hwcap2): Likewise.
9483         * linux-tdep.h (linux_get_hwcap): Add declaration.
9484         (linux_get_hwcap2): Likewise.
9485         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9486         (ppc_linux_get_hwcap2): Likewise.
9487         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9488         linux_get_hwcap.
9489         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9490         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9491         (ppc_linux_nat_target::read_description): Likewise.
9492         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9493         * s390-linux-nat.c: Likewise.
9494         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9495
9496 2019-03-24  Tom Tromey  <tom@tromey.com>
9497
9498         * ada-lang.c (standard_lookup): Simplify initialization.
9499         (ada_lookup_symbol_nonlocal): Simplify return.
9500         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9501         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9502         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9503         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9504         initialization.
9505         * solib.c (solib_global_lookup): Simplify.
9506         * symtab.c (null_block_symbol): Remove.
9507         (symbol_cache_lookup): Simplify returns.
9508         (lookup_language_this): Simplify returns.
9509         (lookup_symbol_aux): Simplify return.
9510         (lookup_local_symbol): Simplify returns.
9511         (lookup_global_symbol_from_objfile): Simplify return.
9512         (lookup_symbol_in_objfile_symtabs)
9513         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9514         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9515         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9516         * cp-namespace.c (cp_lookup_bare_symbol)
9517         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9518         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9519         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9520         (cp_lookup_symbol_via_imports): Simplify initialization.
9521         (find_symbol_in_baseclass): Likewise.
9522         * symtab.h (null_block_symbol): Remove.
9523         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9524         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9525         (d_lookup_symbol_module): Likewise.
9526         (find_symbol_in_baseclass): Simplify initialization.
9527
9528 2019-03-24  Tom Tromey  <tom@tromey.com>
9529
9530         * expression.h: Don't include symtab.h.
9531         (struct block): Forward declare.
9532
9533 2019-03-24  Tom Tromey  <tom@tromey.com>
9534
9535         * c-exp.y (typebase): Remove casts.
9536         * gdbtypes.c (lookup_unsigned_typename, )
9537         (lookup_signed_typename): Remove cast.
9538         * eval.c (parse_to_comma_and_eval): Remove cast.
9539         * parse.c (write_dollar_variable): Remove cast.
9540         * block.h (struct block) <superblock>: Now const.
9541         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9542         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9543         (map_block): Make "block" const.
9544         * symfile.h (struct quick_symbol_functions)
9545         <map_matching_symbols>: Constify block argument to "callback".
9546         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9547         const.
9548         (find_pc_sect_compunit_symtab): Make "b" const.
9549         (find_symbol_at_address): Likewise.
9550         (search_symbols): Likewise.
9551         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9552         (dw2_debug_names_lookup_symbol): Likewise.
9553         (dw2_map_matching_symbols): Update.
9554         * p-valprint.c (pascal_val_print): Remove "block".
9555         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9556         (aux_add_nonlocal_symbols): Make "block" const.
9557         (resolve_subexp): Remove cast.
9558         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9559         const.
9560         (iterate_over_file_blocks): Likewise.
9561         * f-exp.y (%union) <bval>: Remove.
9562         * coffread.c (patch_opaque_types): Make "b" const.
9563         * spu-tdep.c (spu_catch_start): Make "block" const.
9564         * c-valprint.c (print_unpacked_pointer): Remove "block".
9565         * symmisc.c (dump_symtab_1): Make "b" const.
9566         (block_depth): Make "block" const.
9567         * d-exp.y (%union) <bval>: Remove.
9568         * cp-support.h (cp_lookup_rtti_type): Update.
9569         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9570         * psymtab.c (psym_lookup_symbol): Make "block" const.
9571         (maintenance_check_psymtabs): Make "b" const.
9572         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9573         (enumerate_locals, enumerate_args): Update.
9574         * python/py-symtab.c (stpy_global_block): Make "block" const.
9575         (stpy_static_block): Likewise.
9576         * inline-frame.c (block_starting_point_at): Make "new_block"
9577         const.
9578         * block.c (find_block_in_blockvector): Make return type const.
9579         (blockvector_for_pc_sect): Make "b" const.
9580         (find_block_in_blockvector): Make "b" const.
9581
9582 2019-03-23  Tom Tromey  <tom@tromey.com>
9583
9584         * varobj.c (varobj_create): Update.
9585         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9586         * printcmd.c (display_command, do_one_display): Don't reset
9587         innermost_block.
9588         * parser-defs.h (enum innermost_block_tracker_type): Move to
9589         expression.h.
9590         (innermost_block): Update comment.
9591         * parse.c (parse_exp_1): Add tracker_types parameter.
9592         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9593         tracker_types parameter.  Reset innermost_block.
9594         (parse_exp_in_context): Remove.
9595         (parse_expression_for_completion): Update.
9596         * objfiles.c (~objfile): Don't reset expression_context_block or
9597         innermost_block.
9598         * expression.h (enum innermost_block_tracker_type): Move from
9599         parser-defs.h.
9600         (parse_exp_1): Add tracker_types parameter.
9601         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9602         reset innermost_block.
9603
9604 2019-03-23  Tom Tromey  <tom@tromey.com>
9605
9606         * objfiles.h: Include bcache.h.
9607
9608 2019-03-23  Tom Tromey  <tom@tromey.com>
9609
9610         * linespec.c (get_current_search_block): Use
9611         scoped_restore_current_language.
9612         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9613
9614 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9615             Jiong Wang  <jiong.wang@arm.com>
9616
9617         * aarch64-linux-tdep.c
9618         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9619         section.
9620         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9621
9622 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9623             Jiong Wang  <jiong.wang@arm.com>
9624
9625         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9626         instructions.
9627         (aarch64_analyze_prologue_test): Add PACIASP test.
9628         (aarch64_prologue_prev_register): Unmask PC value.
9629
9630 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9631             Jiong Wang  <jiong.wang@arm.com>
9632
9633         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9634         (aarch64_dwarf2_prev_register): Unmask PC value.
9635         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9636         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9637         DW_CFA_AARCH64_negate_ra_state.
9638         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9639
9640 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9641             Jiong Wang  <jiong.wang@arm.com>
9642
9643         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9644         registers.
9645         (aarch64_pseudo_register_name): Likewise.
9646         (aarch64_pseudo_register_type): Likewise.
9647         (aarch64_pseudo_register_reggroup_p): Likewise.
9648         (aarch64_gdbarch_init): Add pauth registers.
9649         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9650         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9651         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9652         (struct gdbarch_tdep): Add regnum for ra_state.
9653
9654 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9655             Jiong Wang  <jiong.wang@arm.com>
9656
9657         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9658
9659 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9660             Jiong Wang  <jiong.wang@arm.com>
9661
9662         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9663         function.
9664         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9665         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9666         (aarch64_gdbarch_init): Add puth registers.
9667         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9668         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9669         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9670
9671 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9672             Jiong Wang  <jiong.wang@arm.com>
9673
9674         * aarch64-linux-nat.c
9675         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9676         * aarch64-linux-tdep.c
9677         (aarch64_linux_core_read_description): Likewise.
9678         (aarch64_linux_get_hwcap): New function.
9679         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9680         (aarch64_linux_get_hwcap): New declaration.
9681
9682 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9683             Jiong Wang  <jiong.wang@arm.com>
9684
9685         * aarch64-linux-nat.c
9686         (aarch64_linux_nat_target::read_description): Add pauth param.
9687         * aarch64-linux-tdep.c
9688         (aarch64_linux_core_read_description): Likewise.
9689         * aarch64-tdep.c (struct target_desc): Add in pauth.
9690         (aarch64_read_description): Add pauth param.
9691         (aarch64_gdbarch_init): Likewise.
9692         * aarch64-tdep.h (aarch64_read_description): Likewise.
9693         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9694         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9695         * features/Makefile: Add new files.
9696         * features/aarch64-pauth.c: New file.
9697         * features/aarch64-pauth.xml: New file.
9698
9699 2019-03-20  Tom Tromey  <tromey@adacore.com>
9700
9701         * infrun.c (handle_inferior_event): Rename from
9702         handle_inferior_event_1.  Create a scoped_value_mark.
9703         (handle_inferior_event): Remove.
9704
9705 2019-03-19  Tom Tromey  <tromey@adacore.com>
9706
9707         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9708         * infrun.h (print_stop_event): Add "displays" parameter.
9709         * infrun.c (print_stop_event): Add "displays" parameter.
9710
9711 2019-03-19  Pedro Alves  <palves@redhat.com>
9712
9713         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9714         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9715         to -1.  Fix TABs vs spaces.
9716         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9717         * tui/tui-out.h (tui_ui_out) Add intro comments.
9718         <m_line, m_start_of_line>: In-class initialize, and add describing
9719         comment.
9720
9721 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9722
9723         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9724         variable names.
9725         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9726
9727 2019-03-18  Pedro Alves  <palves@redhat.com>
9728             Eli Zaretskii <eliz@gnu.org>
9729
9730         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9731         m_line and m_start_of_line.
9732
9733 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9734
9735         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9736         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9737         it returns a newline.  This fixes a regression in TU mode, whereby
9738         the next line is output on the same screen line as the user input.
9739
9740 2019-03-18  Tom Tromey  <tromey@adacore.com>
9741
9742         * minsyms.c (minimal_symbol_reader::install): Remove call to
9743         obstack_blank.
9744
9745 2019-03-18  Pedro Alves  <palves@redhat.com>
9746
9747         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9748         New globals.
9749         (apply_style): New, factored out from ...
9750         (apply_ansi_escape): ... this.  Handle reverse video mode.
9751         (tui_set_reverse_mode): New function.
9752         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9753         * tui/tui-winsource.c (tui_show_source_line): Use
9754         tui_set_reverse_mode instead of setting A_STANDOUT.
9755         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9756         New setter methods.
9757
9758 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9759
9760         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9761         Handle tabs.
9762
9763 2019-03-18  Tom Tromey  <tromey@adacore.com>
9764
9765         * ada-lang.c (empty_array): Add "high" parameter.
9766         (ada_evaluate_subexp): Update.
9767
9768 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9769
9770         * unittests/string_view-selftests.c: Define
9771         _initialize_string_view_selftests unconditionally.
9772
9773 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9774
9775         PR gdb/24350
9776         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9777
9778 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9779
9780         PR gdb/24351
9781         * windows-nat.c (display_selector): Fix format specifiers.
9782
9783 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9784
9785         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9786         tui_refill_source_window instead of tui_refresh_win, to update the
9787         current execution line.  This fixes redisplay of the current line
9788         when stepping through the code with "next" or "step".
9789
9790 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9791
9792         * source-cache.c (source_cache::get_source_lines): Call
9793         find_source_lines to initialize s->nlines.  This fixes vertical
9794         scrolling of TUI source window when the DOWN arrow is pressed.
9795
9796 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9797
9798         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9799         linux-thread-db.c (_initialize_thread_db): Likewise.
9800
9801 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9802
9803         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9804         wclrtoeol in tui_show_source_line".  This reverts changes made in
9805         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9806
9807 2019-03-15  Tom Tromey  <tom@tromey.com>
9808
9809         * symtab.h (struct minimal_symbol): Derive from
9810         general_symbol_info.
9811         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9812         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9813         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9814         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9815         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9816         (MSYMBOL_SEARCH_NAME): Update.
9817         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9818         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9819         * minsyms.c (minimal_symbol_reader::record_full): Update.
9820
9821 2019-03-15  Tom Tromey  <tom@tromey.com>
9822
9823         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9824
9825 2019-03-15  Tom Tromey  <tom@tromey.com>
9826
9827         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9828         unique_xmalloc_ptr.
9829         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9830         Update.
9831         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9832         (build_minimal_symbol_hash_tables)
9833         (minimal_symbol_reader::install): Update.
9834
9835 2019-03-15  Tom Tromey  <tom@tromey.com>
9836
9837         * symtab.c (create_demangled_names_hash): Update.
9838         (symbol_set_names): Update.
9839         * objfiles.h (struct objfile_per_bfd_storage)
9840         <demangled_names_hash>: Now an htab_up.
9841         * objfiles.c (objfile_per_bfd_storage): Simplify.
9842
9843 2019-03-15  Tom Tromey  <tom@tromey.com>
9844
9845         * objfiles.h (struct objfile_per_bfd_storage): Declare
9846         destructor.
9847         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9848         New.
9849         (get_objfile_bfd_data): Use new.  Don't initialize
9850         language_of_main.
9851         (free_objfile_per_bfd_storage): Remove.
9852         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9853
9854 2019-03-15  Tom Tromey  <tom@tromey.com>
9855
9856         * symfile.c (reread_symbols): Update.
9857         * objfiles.c (objfile::objfile): Update.
9858         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9859         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9860         comment.
9861         (minimal_symbol_reader::install): Update.
9862         (terminate_minimal_symbol_table): Remove.
9863         * jit.c (jit_object_close_impl): Update.
9864
9865 2019-03-15  Tom Tromey  <tom@tromey.com>
9866
9867         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9868         initializations.
9869
9870 2019-03-15  Tom Tromey  <tom@tromey.com>
9871
9872         * objfiles.h (struct objfile_per_bfd_storage)
9873         <demangled_hash_languages>: Now a bitset.
9874         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9875         (lookup_minimal_symbol): Update.
9876
9877 2019-03-15  Tom Tromey  <tom@tromey.com>
9878
9879         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9880         Don't return the symbol.
9881         * coffread.c (record_minimal_symbol): Use record_full.
9882
9883 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9884
9885         The MS-Windows port of ncurses fails to switch to a color pair if
9886         one or both of the colors are the implicit default colors.  This
9887         change records the default colors when TUI is initialized, and
9888         then specifies them explicitly when a color pair uses the default
9889         colors.  This allows color styling in TUI mode on MS-Windows.
9890
9891         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9892         ncurses_norm_attr.
9893         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9894         colors in ncurses_norm_attr.
9895         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9896         "none", replace it with the default color recorded in
9897         ncurses_norm_attr.
9898
9899 2019-03-14  Tom Tromey  <tromey@adacore.com>
9900
9901         * source-cache.h (class source_cache) <get_source_lines>: Return
9902         std::string.
9903         * source-cache.c (source_cache::extract_lines): Handle case where
9904         first_pos==npos.  Return std::string.
9905         (source_cache::get_source_lines): Update.
9906
9907 2019-03-14  Tom Tromey  <tromey@adacore.com>
9908
9909         * NEWS: Add item for "style sources" commands.
9910         * source-cache.c (source_cache::get_source_lines): Check
9911         source_styling.
9912         * cli/cli-style.c (source_styling): New global.
9913         (_initialize_cli_style): Add "style sources" commands.
9914         (show_style_sources): New function.
9915         * cli/cli-style.h (source_styling): Declare.
9916
9917 2019-03-14  Pedro Alves  <palves@redhat.com>
9918             Tom Tromey  <tromey@adacore.com>
9919
9920         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9921         * tui/tui-winsource.c (tui_refill_source_window): New function,
9922         from...
9923         (tui_horizontal_source_scroll): ... here.  Move some logic.
9924         * cli/cli-style.c (set_style_enabled): Notify new observable.
9925         * tui/tui-hooks.c (tui_redisplay_source): New function.
9926         (tui_attach_detach_observers): Attach or detach
9927         tui_redisplay_source.
9928         * observable.h (source_styling_changed): New observable.
9929         * observable.c: Define source_styling_changed observable.
9930
9931 2019-03-13  Tom Tromey  <tromey@adacore.com>
9932
9933         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9934         (i386_gnu_nat_target::store_registers): Update.
9935         * target-debug.h (target_debug_print_std_string): New macro.
9936         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9937         * windows-tdep.c (display_one_tib): Update.
9938         * tui/tui-stack.c (tui_make_status_line): Update.
9939         * top.c (print_inferior_quit_action): Update.
9940         * thread.c (thr_try_catch_cmd): Update.
9941         (add_thread_with_info): Update.
9942         (thread_target_id_str): Update.
9943         (thr_try_catch_cmd): Update.
9944         (thread_command): Update.
9945         (thread_find_command): Update.
9946         * record-btrace.c (record_btrace_target::info_record)
9947         (record_btrace_resume_thread, record_btrace_target::resume)
9948         (record_btrace_cancel_resume, record_btrace_step_thread)
9949         (record_btrace_target::wait, record_btrace_target::wait)
9950         (record_btrace_target::wait, record_btrace_target::stop): Update.
9951         * progspace.c (print_program_space): Update.
9952         * process-stratum-target.c
9953         (process_stratum_target::thread_address_space): Update.
9954         * linux-fork.c (linux_fork_mourn_inferior)
9955         (detach_checkpoint_command, info_checkpoints_command)
9956         (linux_fork_context): Update.
9957         (linux_fork_detach): Update.
9958         (class scoped_switch_fork_info): Update.
9959         (delete_checkpoint_command): Update.
9960         * infrun.c (follow_fork_inferior): Update.
9961         (follow_fork_inferior): Update.
9962         (proceed_after_vfork_done): Update.
9963         (handle_vfork_child_exec_or_exit): Update.
9964         (follow_exec): Update.
9965         (displaced_step_prepare_throw): Update.
9966         (displaced_step_restore): Update.
9967         (start_step_over): Update.
9968         (resume_1): Update.
9969         (clear_proceed_status_thread): Update.
9970         (proceed): Update.
9971         (print_target_wait_results): Update.
9972         (do_target_wait): Update.
9973         (context_switch): Update.
9974         (stop_all_threads): Update.
9975         (restart_threads): Update.
9976         (finish_step_over): Update.
9977         (handle_signal_stop): Update.
9978         (switch_back_to_stepped_thread): Update.
9979         (keep_going_pass_signal): Update.
9980         (print_exited_reason): Update.
9981         (normal_stop): Update.
9982         * inferior.c (inferior_pid_to_str): Change return type.
9983         (print_selected_inferior): Update.
9984         (add_inferior): Update.
9985         (detach_inferior): Update.
9986         * dummy-frame.c (fprint_dummy_frames): Update.
9987         * dcache.c (dcache_info_1): Update.
9988         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9989         (btrace_fetch, btrace_clear): Update.
9990         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9991         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9992         type.
9993         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9994         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9995         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9996         * gdbarch.c, gdbarch.h: Rebuild.
9997         * gdbarch.sh (core_pid_to_str): Change return type.
9998         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9999         return type.
10000         (windows_nat_target::pid_to_str): Change return type.
10001         (windows_delete_thread): Update.
10002         (windows_nat_target::attach): Update.
10003         (windows_nat_target::files_info): Update.
10004         * target-delegates.c: Rebuild.
10005         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10006         return type.
10007         (sol_thread_target::pid_to_str): Change return type.
10008         * remote.c (class remote_target) <pid_to_str>: Change return
10009         type.
10010         (remote_target::pid_to_str): Change return type.
10011         (extended_remote_target::attach, remote_target::remote_stop_ns)
10012         (remote_target::remote_notif_remove_queued_reply)
10013         (remote_target::push_stop_reply, remote_target::disable_btrace):
10014         Update.
10015         (extended_remote_target::attach): Update.
10016         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10017         type.
10018         (gdbsim_target::pid_to_str): Change return type.
10019         * ravenscar-thread.c (struct ravenscar_thread_target)
10020         <pid_to_str>: Change return type.
10021         (ravenscar_thread_target::pid_to_str): Change return type.
10022         * procfs.c (class procfs_target) <pid_to_str>: Change return
10023         type.
10024         (procfs_target::pid_to_str): Change return type.
10025         (procfs_target::attach): Update.
10026         (procfs_target::detach): Update.
10027         (procfs_target::fetch_registers): Update.
10028         (procfs_target::store_registers): Update.
10029         (procfs_target::wait): Update.
10030         (procfs_target::files_info): Update.
10031         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10032         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10033         return type.
10034         (nto_procfs_target::pid_to_str): Change return type.
10035         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10036         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10037         return type.
10038         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10039         (exit_lwp): Update.
10040         (attach_proc_task_lwp_callback, get_detach_signal)
10041         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10042         (linux_nat_target::resume, wait_lwp, stop_callback)
10043         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10044         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10045         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10046         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10047         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10048         type.
10049         (inf_ptrace_target::attach): Update.
10050         (inf_ptrace_target::files_info): Update.
10051         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10052         type.
10053         (go32_nat_target::pid_to_str): Change return type.
10054         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10055         (gnu_nat_target::wait): Update.
10056         (gnu_nat_target::wait): Update.
10057         (gnu_nat_target::resume): Update.
10058         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10059         (fbsd_nat_target::wait): Update.
10060         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10061         type.
10062         (darwin_nat_target::attach): Update.
10063         * corelow.c (class core_target) <pid_to_str>: Change return type.
10064         (core_target::pid_to_str): Change return type.
10065         * target.c (normal_pid_to_str): Change return type.
10066         (default_pid_to_str): Likewise.
10067         (target_pid_to_str): Change return type.
10068         (target_translate_tls_address): Update.
10069         (target_announce_detach): Update.
10070         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10071         return type.
10072         (bsd_uthread_target::pid_to_str): Change return type.
10073         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10074         type.
10075         (bsd_kvm_target::pid_to_str): Change return type.
10076         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10077         return type.
10078         (aix_thread_target::pid_to_str): Change return type.
10079         * target.h (struct target_ops) <pid_to_str>: Change return type.
10080         (target_pid_to_str, normal_pid_to_str): Likewise.
10081         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10082         type.
10083         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10084         type.
10085         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10086         return type.
10087         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10088         type.
10089         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10090         type.
10091         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10092         return type.
10093
10094 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10095
10096         * NEWS: Mention that the new default MI version is 3.  Mention
10097         changes to the output of commands and events that deal with
10098         multi-location breakpoints.
10099         * breakpoint.c: Include "mi/mi-out.h".
10100         (print_one_breakpoint): Change output syntax if using MI version
10101         >= 3.
10102         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10103         New.
10104         (mi_multi_location_breakpoint_output_fixed): New.
10105         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10106         (mi_cmd_fix_multi_location_breakpoint_output): New.
10107         (mi_multi_location_breakpoint_output_fixed): New.
10108         * mi/mi-cmds.c (mi_cmds): Register command
10109         -fix-multi-location-breakpoint-output.
10110         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10111         interpreter "mi".
10112
10113 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10114
10115         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10116         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10117         instantiate mi_ui_out based on interpreter name.
10118         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10119         * mi/mi-main.c (mi_load_progress): Likewise.
10120
10121 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10122
10123         * NEWS: Combine separate "New targets" sections for 8.3.
10124
10125 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10126
10127         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10128         (ppcfbsd_init_abi): Install gdbarch
10129         "fetch_tls_load_module_address" and "get_thread_local_address"
10130         methods.
10131
10132 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10133
10134         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10135         (riscv_fbsd_init_abi): Install gdbarch
10136         "fetch_tls_load_module_address" and "get_thread_local_address"
10137         methods.
10138
10139 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10140
10141         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10142         (i386fbsd_init_abi): Install gdbarch
10143         "fetch_tls_load_module_address" and "get_thread_local_address"
10144         methods.
10145
10146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10147
10148         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10149         (amd64fbsd_init_abi): Install gdbarch
10150         "fetch_tls_load_module_address" and "get_thread_local_address"
10151         methods.
10152
10153 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10154
10155         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10156         (struct fbsd_pspace_data): New type.
10157         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10158         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10159         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10160         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10161         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10162
10163 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10164
10165         * gdbtypes.c (lookup_struct_elt): New function.
10166         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10167         * gdbtypes.h (struct struct_elt): New type.
10168         (lookup_struct_elt): New prototype.
10169
10170 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10171
10172         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10173         remove disabled code block.
10174
10175 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10176
10177         * gdbarch.sh (get_thread_local_address): New method.
10178         * gdbarch.h, gdbarch.c: Regenerate.
10179         * target.c (target_translate_tls_address): Use
10180         gdbarch_get_thread_local_address if present instead of
10181         target::get_thread_local_address.
10182
10183 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10184
10185         * target.h (target::get_thread_local_address): Update comment.
10186
10187 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10188
10189         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10190         objfile->separate_debug_objfile_backlink if not NULL.
10191
10192 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10193
10194         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10195         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10196         (amd64bsd_store_inferior_registers): Likewise.
10197         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10198         Enable segment base registers.
10199         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10200         PT_GETFSBASE and PT_GETGSBASE.
10201         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10202         PT_SETGSBASE.
10203         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10204         segment base registers.
10205         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10206
10207 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10208
10209         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10210         Update calls to i386_target_description to add 'segments'
10211         parameter.
10212         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10213         add segment base registers.
10214         * arch/i386.c (i386_create_target_description): Add 'segments'
10215         parameter to enable segment base registers.
10216         * arch/i386.h (i386_create_target_description): Likewise.
10217         * features/i386/32bit-segments.xml: New file.
10218         * features/i386/32bit-segments.c: Generate.
10219         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10220         call to i386_target_description to add 'segments' parameter.
10221         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10222         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10223         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10224         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10225         if feature is present.
10226         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10227         Add 'segments' parameter to call to i386_target_description.
10228         (i386_target_description): Add 'segments' parameter to enable
10229         segment base registers.
10230         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10231         to call to i386_target_description.
10232         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10233         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10234         Define I386_NUM_REGS.
10235         (i386_target_description): Add 'segments' parameter to enable
10236         segment base registers.
10237
10238 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10239
10240         PR/24325
10241         * source-cache.c: #undef open and close, to avoid unresolved
10242         externals during linking.
10243
10244 2019-03-12  Tom Tromey  <tromey@adacore.com>
10245
10246         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10247         const.  Add initializers.
10248         (_initialize_remote): Don't initialize ptid globals.
10249
10250 2019-03-12  Pedro Alves  <palves@redhat.com>
10251
10252         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10253
10254 2019-03-12  Pedro Alves  <palves@redhat.com>
10255
10256         * cp-name-parser.y (main): Remove unused 'len' variable.
10257
10258 2019-03-12  Tom Tromey  <tromey@adacore.com>
10259
10260         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10261         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10262
10263 2019-03-12  Tom Tromey  <tromey@adacore.com>
10264
10265         * linux-nat.c (iterate_over_lwps): Update.
10266         (stop_callback): Remove parameter.
10267         (stop_wait_callback, detach_callback, resume_set_callback)
10268         (select_singlestep_lwp_callback, set_ignore_sigint)
10269         (status_callback, resumed_callback, resume_clear_callback)
10270         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10271         data parameter.
10272         (linux_nat_target::detach, linux_nat_target::resume)
10273         (linux_stop_and_wait_all_lwps, select_event_lwp)
10274         (linux_nat_filter_event, linux_nat_wait_1)
10275         (linux_nat_target::kill, linux_nat_target::stop)
10276         (linux_nat_target::stop): Update.
10277         (linux_nat_resume_callback): Change type.
10278         (resume_stopped_resumed_lwps, count_events_callback)
10279         (select_event_lwp_callback): Likewise.
10280         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10281         * arm-linux-nat.c (struct update_registers_data): Remove.
10282         (update_registers_callback): Change type.
10283         (arm_linux_insert_hw_breakpoint1): Update.
10284         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10285         parameter.
10286         (x86_linux_dr_set_addr): Update.
10287         (x86_linux_dr_set_control): Update.
10288         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10289         (iterate_over_lwps): Use gdb::function_view.
10290         * nat/aarch64-linux-hw-point.c (struct
10291         aarch64_dr_update_callback_param): Remove.
10292         (debug_reg_change_callback): Change type.
10293         (aarch64_notify_debug_reg_change): Update.
10294         * s390-linux-nat.c (s390_refresh_per_info): Update.
10295
10296 2019-03-11  Tom Tromey  <tromey@adacore.com>
10297
10298         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10299         redundant assignment to "this_cu".
10300
10301 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10302
10303         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10304
10305 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10306
10307         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10308         from...
10309         (rank_one_type): ... this.
10310
10311 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10312
10313         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10314         from...
10315         (rank_one_type): ... this.
10316
10317 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10318
10319         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10320         from...
10321         (rank_one_type): ... this.
10322
10323 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10324
10325         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10326         from...
10327         (rank_one_type): ... this.
10328
10329 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10330
10331         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10332         from...
10333         (rank_one_type): ... this.
10334
10335 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10336
10337         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10338         from...
10339         (rank_one_type): ... this.
10340
10341 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10342
10343         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10344         from...
10345         (rank_one_type): ... this.
10346
10347 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10348
10349         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10350         from...
10351         (rank_one_type): ... this.
10352
10353 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10354
10355         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10356         from...
10357         (rank_one_type): ... this.
10358
10359 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10360
10361         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10362         from...
10363         (rank_one_type): ... this.
10364
10365 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10366
10367         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10368         from...
10369         (rank_one_type): ... this.
10370
10371 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10372
10373         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10374         from...
10375         (rank_one_type): ... this.
10376
10377 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10378
10379         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10380         inferior-events' shows the example events.
10381
10382 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10383
10384         Support styling on native MS-Windows console
10385
10386         PR/24315
10387         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10388         on MS-Windows if $TERM is not defined.
10389
10390         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10391
10392         * posix-hdep.c (gdb_console_fputs):
10393         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10394         functions.
10395         * ui-file.h (gdb_console_fputs): Add prototype.
10396
10397         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10398         back to fputs only if the former returns zero.
10399
10400 2019-03-07  Tom Tromey  <tom@tromey.com>
10401
10402         * symmisc.c (print_symbol_bcache_statistics): Update.
10403         (print_objfile_statistics): Update.
10404         * symfile.c (allocate_symtab): Update.
10405         * stabsread.c: Don't include bcache.h.
10406         * psymtab.h (struct psymbol_bcache): Don't declare.
10407         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10408         (psymbol_bcache_init, psymbol_bcache_free)
10409         (psymbol_bcache_get_bcache): Don't declare.
10410         * psymtab.c (struct psymbol_bcache): Remove.
10411         (psymtab_storage::psymtab_storage): Update.
10412         (psymtab_storage::~psymtab_storage): Update.
10413         (psymbol_bcache_init, psymbol_bcache_free)
10414         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10415         (add_psymbol_to_bcache): Update.
10416         (allocate_psymtab): Update.
10417         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10418         macro_cache>: No longer pointers.
10419         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10420         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10421         * macrotab.c (macro_bcache): Update.
10422         * macroexp.c: Don't include bcache.h.
10423         * gdbtypes.c (check_types_worklist): Update.
10424         (types_deeply_equal): Remove TRY/CATCH.  Update.
10425         * elfread.c (elf_symtab_read): Update.
10426         * dwarf2read.c: Don't include bcache.h.
10427         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10428         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10429         (print_bcache_statistics, bcache_memory_used): Don't declare.
10430         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10431         methods.  Rename all data members.
10432         * bcache.c (struct bcache): Move to bcache.h.
10433         (bcache::expand_hash_table): Rename from expand_hash_table.
10434         (bcache): Remove.
10435         (bcache::insert): Rename from bcache_full.
10436         (bcache::compare): Rename from bcache_compare.
10437         (bcache_xmalloc): Remove.
10438         (bcache::~bcache): Rename from bcache_xfree.
10439         (bcache::print_statistics): Rename from print_bcache_statistics.
10440         (bcache::memory_used): Rename from bcache_memory_used.
10441
10442 2019-03-07  Pedro Alves  <palves@redhat.com>
10443
10444         * infrun.c (normal_stop): Also check for
10445         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10446
10447 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10448
10449         * f-lang.c (value_from_host_double): Moved to...
10450         * value.c (value_from_host_double): ...here.
10451         * value.h (value_from_host_double): Declare.
10452         * guile/scm-math.c (vlscm_convert_typed_number): Use
10453         value_from_host_double.
10454         (vlscm_convert_number): Likewise.
10455         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10456         * python/py-value.c (convert_value_from_python): Likewise.
10457
10458 2019-03-06  Tom Tromey  <tom@tromey.com>
10459
10460         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10461
10462 2019-03-06  Tom Tromey  <tom@tromey.com>
10463
10464         * utils.h (free_current_contents): Don't declare.
10465         * utils.c (free_current_contents): Remove.
10466
10467 2019-03-06  Tom Tromey  <tom@tromey.com>
10468
10469         * top.c (quit_force): Update.
10470         * main.c (captured_command_loop): Update.
10471         * common/new-op.c (operator new): Update.
10472         * common/common-exceptions.c (struct catcher)
10473         <save_cleanup_chain>: Remove member.
10474         (exceptions_state_mc_init): Update.
10475         (exception_try_scope_entry): Return nullptr.
10476         (exception_try_scope_exit, exception_rethrow)
10477         (throw_exception_sjlj, throw_exception_cxx): Update.
10478         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10479         (all_cleanups, do_cleanups, discard_cleanups)
10480         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10481         (restore_cleanups, restore_final_cleanups): Don't declare.
10482         (do_final_cleanups): Remove parameter.
10483         * common/cleanups.c (cleanup_chain, make_cleanup)
10484         (make_cleanup_dtor, all_cleanups, do_cleanups)
10485         (discard_my_cleanups, discard_cleanups)
10486         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10487         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10488         (null_cleanup): Remove.
10489         (do_final_cleanups): Remove parameter.
10490
10491 2019-03-06  Tom Tromey  <tom@tromey.com>
10492
10493         * remote.c (remote_target::remote_parse_stop_reply): Use
10494         unique_xmalloc_ptr.
10495
10496 2019-03-06  Tom Tromey  <tom@tromey.com>
10497
10498         * stabsread.c (struct stabs_field_info): Rename from field_info.
10499         <list, fnlist>: Add initializers.
10500         <obstack>: New member.
10501         (read_member_functions, read_struct_fields, read_baseclasses):
10502         Allocate on obstack.  Don't use cleanups.
10503         (read_one_struct_field, read_member_functions, read_struct_fields)
10504         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10505         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10506         (read_struct_type): Update.
10507
10508 2019-03-06  Tom Tromey  <tom@tromey.com>
10509
10510         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10511         * common/filestuff.h (make_cleanup_close): Don't declare.
10512         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10513         Remove.
10514
10515 2019-03-06  Tom Tromey  <tom@tromey.com>
10516
10517         * solib-aix.c: Use make_scope_exit.
10518
10519 2019-03-06  Tom Tromey  <tom@tromey.com>
10520
10521         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10522         Use make_scope_exit.
10523
10524 2019-03-06  Tom Tromey  <tom@tromey.com>
10525
10526         * solib-svr4.c (disable_probes_interface): Remove parameter.
10527         (svr4_handle_solib_event): Use make_scope_exit.
10528
10529 2019-03-06  Tom Tromey  <tom@tromey.com>
10530
10531         * remote.c (struct stop_reply_deleter): Remove.
10532         (stop_reply_up): Update.
10533         (struct stop_reply): Derive from notif_event.  Don't typedef.
10534         <regcache>: Now a std::vector.
10535         (stop_reply_xfree): Remove.
10536         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10537         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10538         (remote_target::discard_pending_stop_replies): Use delete.
10539         (remote_target::remote_parse_stop_reply): Update.
10540         (remote_target::process_stop_reply): Update.
10541         * remote-notif.h (struct notif_event): Add virtual destructor.
10542         Remove "dtr" member.
10543         (struct notif_client) <alloc_event>: Return a unique_ptr.
10544         (notif_event_xfree): Don't declare.
10545         (notif_event_up): New typedef.
10546         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10547         (notif_event_xfree, do_notif_event_xfree): Remove.
10548         (remote_notif_state_xfree): Update.
10549
10550 2019-03-06  Tom Tromey  <tom@tromey.com>
10551
10552         * infrun.c (displaced_step_clear_cleanup): Now a
10553         forward_scope_exit type.
10554         (displaced_step_prepare_throw): Update.
10555         (displaced_step_fixup): Update.
10556
10557 2019-03-06  Tom Tromey  <tom@tromey.com>
10558
10559         * inferior.h (class inferior): Update comment.
10560         * gdbthread.h (class thread_info): Update comment.
10561
10562 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10563             Tom Tromey  <tom@tromey.com>
10564
10565         * stabsread.h (struct stab_section_list): Remove.
10566         (coffstab_build_psymtabs): Update.
10567         * dbxread.c (symbuf_sections): Now a std::vector.
10568         (sect_idx): New global.
10569         (fill_symbuf): Update.
10570         (coffstab_build_psymtabs): Change type of stabsects parameter.
10571         Update.
10572         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10573         std::vector.
10574         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10575         (coff_locate_sections): Update.
10576         (coff_symfile_read): Remove cleanups.  Update.
10577         (init_stringtab): Add storage parameter.
10578         (free_stringtab, free_stringtab_cleanup): Remove.
10579         (init_lineno): Add storage parameter.
10580         (free_linetab, free_linetab_cleanup): Remove.
10581
10582 2019-03-06  Pedro Alves  <palves@redhat.com>
10583
10584         * linux-fork.c (fork_info::clobber_regs): Delete.
10585         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10586         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10587         comment.  Adjust.
10588         (scoped_switch_fork_info::scoped_switch_fork_info)
10589         (checkpoint_command, linux_fork_context): Adjust
10590         fork_save_infrun_state calls.
10591
10592 2019-03-06  Pedro Alves  <palves@redhat.com>
10593
10594         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10595         (inf_has_multiple_threads): Return 'bool' and rewrite using
10596         inferior_info::threads().
10597
10598 2019-03-06  Pedro Alves  <palves@redhat.com>
10599
10600         * linux-fork.c: Include <list>.
10601         (fork_list): Now a std::list instance.
10602         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10603         (forks_exist_p, find_last_fork): Adjust.
10604         (new_fork): Delete.
10605         (one_fork_p): New.
10606         (add_fork): Adjust.
10607         (free_fork): Delete, folded into fork_info::~fork_info().
10608         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10609         Adjust.
10610         (init_fork_list): Delete.
10611         (linux_fork_killall, linux_fork_mourn_inferior)
10612         (linux_fork_detach, info_checkpoints_command): Adjust.
10613         (_initialize_linux_fork): No longer call init_fork_list.
10614
10615 2019-03-06  Pedro Alves  <palves@redhat.com>
10616
10617         * linux-fork.c (new_fork): New, split out of ...
10618         (add_fork): ... this.  Return void.  Move "first fork" special
10619         case from here, to ...
10620         (checkpoint_command): ... here.
10621         * linux-linux.h (add_fork): Return void.
10622
10623 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10624
10625         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10626
10627 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10628             Chris January  <chris.january@arm.com>
10629             David Lecomber  <david.lecomber@arm.com>
10630
10631         * f-exp.y: New token, UNOP_INTRINSIC.
10632         (exp): New pattern using UNOP_INTRINSIC token.
10633         (f77_keywords): Add 'abs' keyword.
10634         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10635         (value_from_host_double): New function.
10636         (evaluate_subexp_f): Support UNOP_ABS.
10637
10638 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10639
10640         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10641         types.
10642
10643 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10644
10645         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10646         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10647         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10648
10649 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10650
10651         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10652
10653 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10654             Chris January  <chris.january@arm.com>
10655
10656         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10657         * f-exp.y: Define 'KIND' token.
10658         (exp): New pattern for KIND expressions.
10659         (ptype): Handle types with a kind extension.
10660         (direct_abs_decl): Extend to spot kind extensions.
10661         (f77_keywords): Add 'kind' to the list.
10662         (push_kind_type): New function.
10663         (convert_to_kind_type): New function.
10664         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10665         * parse.c (operator_length_standard): Likewise.
10666         * parser-defs.h (enum type_pieces): Add tp_kind.
10667         * std-operator.def: Add UNOP_KIND.
10668
10669 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10670
10671         * f-exp.y (f_parse): Set yydebug.
10672
10673 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10674
10675         * f-lang.c (evaluate_subexp_f): New function.
10676         (exp_descriptor_f): New global.
10677         (f_language_defn): Use exp_descriptor_f instead of
10678         exp_descriptor_standard.
10679
10680 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10681
10682         * f-exp.y (struct token): Add comments.
10683         (dot_ops): Remove uppercase versions and the end marker.
10684         (f77_keywords): Likewise.
10685         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10686         entries in the dot_ops array are case insensitive, and use
10687         strncasecmp to compare strings.  Also some whitespace cleanup in
10688         this area.  Similar for the f77_keywords array, except entries in
10689         this list might be case sensitive.
10690
10691 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10692
10693         * f-exp.y (struct f77_boolean_val): Add comments.
10694         (boolean_values): Remove uppercase versions, and end marker.
10695         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10696         and use strncasecmp to achieve case insensitivity.  Additionally,
10697         perform whitespace cleanup around this code.
10698
10699 2019-03-06  Tom Tromey  <tromey@adacore.com>
10700
10701         * remote-sim.c (gdbsim_target_open): Use result of
10702         gdb_argv::release.
10703
10704 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10705         Dirk Schubert  <dirk.schubert@arm.com>
10706         Chris January  <chris.january@arm.com>
10707
10708         * eval.c (evaluate_subexp_standard): Call Fortran argument
10709         wrapping logic.
10710         * f-lang.c (struct value): A value which can be passed into a
10711         Fortran function call.
10712         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10713         where appropriate.
10714         (struct type): Value ready for a Fortran function call.
10715         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10716         is needed.
10717         * f-lang.h (fortran_argument_convert): Declaration.
10718         (fortran_preserve_arg_pointer): Declaration.
10719         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10720
10721 2019-03-05  Tom Tromey  <tromey@adacore.com>
10722
10723         * python/py-prettyprint.c (print_string_repr): Remove #if.
10724         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10725
10726 2019-03-05  Tom Tromey  <tromey@adacore.com>
10727
10728         * target.c (the_dummy_target): Move later.  Change type to
10729         "dummy_target".
10730         (initialize_targets): Don't initialize the_dummy_target.
10731
10732 2019-03-05  Tom Tromey  <tromey@adacore.com>
10733
10734         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10735         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10736
10737 2019-03-05  Tom Tromey  <tromey@adacore.com>
10738
10739         * windows-nat.c (windows_nat_target::attach)
10740         (windows_nat_target::detach): Don't call gdb_flush.
10741         * valprint.c (generic_val_print, val_print, val_print_string):
10742         Don't call gdb_flush.
10743         * utils.c (defaulted_query): Don't call gdb_flush.
10744         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10745         * target.c (target_announce_detach): Don't call gdb_flush.
10746         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10747         * remote.c (extended_remote_target::attach): Don't call
10748         gdb_flush.
10749         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10750         * printcmd.c (do_examine): Don't call gdb_flush.
10751         (info_display_command): Don't call gdb_flush.
10752         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10753         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10754         * memattr.c (info_mem_command): Don't call gdb_flush.
10755         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10756         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10757         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10758         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10759         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10760         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10761         (gnu_nat_target::detach): Don't call gdb_flush.
10762         * f-valprint.c (f_val_print): Don't call gdb_flush.
10763         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10764         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10765         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10766         gdb_flush.
10767         * c-valprint.c (c_val_print): Don't call gdb_flush.
10768         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10769
10770 2019-03-05  Tom Tromey  <tromey@adacore.com>
10771
10772         * varobj.c (update_dynamic_varobj_children): Update.
10773         (install_default_visualizer): Use reset, not release.
10774         * value.c (set_internalvar): Update.
10775         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10776         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10777         ATTRIBUTE_UNUSED_RESULT.
10778
10779 2019-03-05  Tom Tromey  <tromey@adacore.com>
10780
10781         * remote.c (class scoped_remote_fd) <release>: Add
10782         ATTRIBUTE_UNUSED_RESULT.
10783
10784 2019-03-05  Tom Tromey  <tromey@adacore.com>
10785
10786         * macroexp.c (struct macro_buffer) <release>: Add
10787         ATTRIBUTE_UNUSED_RESULT.
10788
10789 2019-03-05  Tom Tromey  <tromey@adacore.com>
10790
10791         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10792         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10793         ATTRIBUTE_UNUSED_RESULT.
10794
10795 2019-03-05  Tom Tromey  <tromey@adacore.com>
10796
10797         * common/scoped_fd.h (class scoped_fd) <release>: Add
10798         ATTRIBUTE_UNUSED_RESULT.
10799
10800 2019-03-05  Tom Tromey  <tromey@adacore.com>
10801
10802         * parser-defs.h (struct parser_state) <release>: Add
10803         ATTRIBUTE_UNUSED_RESULT.
10804
10805 2019-03-05  Tom Tromey  <tromey@adacore.com>
10806
10807         * utils.h (class gdb_argv) <release>: Add
10808         ATTRIBUTE_UNUSED_RESULT.
10809         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10810
10811 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10812
10813         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10814         for-loop range, to avoid compiler warnings.
10815
10816         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10817         avoid compiler warnings about unused variables.
10818
10819         * NEWS: Mention end of support for native debugging on MS-Windows
10820         before XP.
10821
10822         PR gdb/24292
10823         * common/netstuff.c:
10824         * gdbserver/gdbreplay.c
10825         * gdbserver/remote-utils.c:
10826         * ser-tcp.c:
10827         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10828         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10829         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10830         'getaddrinfo' and 'freeaddrinfo' were not available before
10831         Windows XP, and mingw.org's MinGW headers by default define
10832         _WIN32_WINNT to 0x500.
10833
10834 2019-03-01  Gary Benson <gbenson@redhat.com>
10835
10836         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10837
10838 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10839             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10840
10841         PR gdb/8527
10842         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10843         set_sigint_trap, clear_sigint_trap.
10844
10845 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10846
10847         * target.c (target_detach): Clear the regcache and the
10848         frame cache.
10849
10850 2019-02-27  Pedro Alves  <palves@redhat.com>
10851
10852         * utils.c (set_screen_size): When we cap the height/width sizes,
10853         tweak the corresponding command variable to show "unlimited":
10854
10855 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10856             Pedro Alves  <palves@redhat.com>
10857
10858         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10859         before calling rl_set_screen_size.
10860
10861 2019-02-27  Tom Tromey  <tromey@adacore.com>
10862
10863         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10864         define.
10865         * python/py-value.c: Remove Python 2.4 workaround.
10866         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10867         workaround.
10868         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10869         Python 2.4 workaround.
10870         * python/python-internal.h: Remove Python 2.4 comment.
10871         (Py_ssize_t): Don't define.
10872         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10873         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10874         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10875         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10876         * python/python.c (do_start_initialization): Remove Python 2.4
10877         workaround.
10878         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10879         (print_children): Remove Python 2.4 workaround.
10880         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10881         workaround.
10882         (CHARBUFFERPROC_NAME): Remove.
10883         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10884         Python 2.4 workaround.
10885
10886 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10887
10888         * NEWS: Note minimum Python version.
10889
10890 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10891
10892         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10893         code from these functions.  Remove corresponding ifdefs.  Use
10894         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10895         Remove gotos and target of gotos.
10896         (infpy_search_memory): Likewise.
10897
10898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10899
10900         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10901         (hppa_gdbarch_init): Don't register deleted functions with
10902         gdbarch.
10903
10904 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10905
10906         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10907         (h8300_unwind_sp): Delete.
10908         (h8300_dummy_id): Delete.
10909         (h8300_gdbarch_init): Don't register deleted functions with
10910         gdbarch.
10911
10912 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10913
10914         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10915         (ft32_unwind_pc): Delete.
10916         (ft32_unwind_sp): Delete.
10917         (ft32_gdbarch_init): Don't register deleted functions with
10918         gdbarch.
10919
10920 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10921
10922         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10923         (frv_unwind_pc): Delete.
10924         (frv_unwind_sp): Delete.
10925         (frv_gdbarch_init): Don't register deleted functions with
10926         gdbarch.
10927
10928 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10929
10930         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10931         (riscv_unwind_pc): Delete.
10932         (riscv_unwind_sp): Delete.
10933         (riscv_gdbarch_init): Don't register deleted functions with
10934         gdbarch.
10935
10936 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10937
10938         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10939         (csky_unwind_pc): Delete.
10940         (csky_unwind_sp): Delete.
10941         (csky_gdbarch_init): Don't register deleted functions with
10942         gdbarch.
10943
10944 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10945
10946         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10947         (cris_unwind_pc): Delete.
10948         (cris_unwind_sp): Delete.
10949         (cris_gdbarch_init): Don't register deleted functions with
10950         gdbarch.
10951
10952 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10953
10954         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10955         (bfin_unwind_pc): Delete.
10956         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10957
10958 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10959
10960         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10961         (arm_unwind_pc): Delete.
10962         (arm_unwind_sp): Delete.
10963         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10964
10965 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10966
10967         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10968         (arc_unwind_pc): Delete.
10969         (arc_unwind_sp): Delete.
10970         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10971
10972 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10973
10974         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10975         (alpha_unwind_pc): Delete.
10976         (alpha_gdbarch_init): Don't register deleted functions with
10977         gdbarch.
10978
10979 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10980
10981         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10982         (aarch64_unwind_pc): Delete.
10983         (aarch64_unwind_sp): Delete.
10984         (aarch64_gdbarch_init): Don't register deleted functions with
10985         gdbarch.
10986
10987 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10988
10989         * gdbtypes.c (type_align): Don't consider static members when
10990         computing structure alignment.
10991
10992 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10993
10994         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10995         return 0 for other types.
10996         * arch-utils.c (default_type_align): Always return 0.
10997         * gdbarch.h: Regenerate.
10998         * gdbarch.sh (type_align): Extend comment.
10999         * gdbtypes.c (type_align): Add additional comments, always call
11000         gdbarch_type_align before applying the default rules.
11001         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11002         generic code will then apply a suitable default.
11003         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11004         types, return 0 for other types.
11005
11006 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11007
11008         * NEWS: Create a new section for the next release branch.
11009         Rename the section of the current branch, now that it has
11010         been cut.
11011
11012 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11013
11014         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11015         * version.in: Bump version to 8.3.50.DATE-git.
11016
11017 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11018
11019         * aix-thread.c (ptid_cmp): Remove unused variable.
11020         (get_signaled_thread): Likewise.
11021         (store_regs_user_thread): Likewise.
11022         (store_regs_kernel_thread): Likewise.
11023         (fetch_regs_kernel_thread): Remove shadowed variable.
11024
11025 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11026
11027         * features/riscv/32bit-cpu.xml: Add register numbers.
11028         * features/riscv/32bit-fpu.c: Regenerate.
11029         * features/riscv/32bit-fpu.xml: Add register numbers.
11030         * features/riscv/64bit-cpu.xml: Add register numbers.
11031         * features/riscv/64bit-fpu.c: Regenerate.
11032         * features/riscv/64bit-fpu.xml: Add register numbers.
11033
11034 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11035
11036         * NEWS: Mention two argument form of gdb.Value constructor.
11037         * python/py-value.c (convert_buffer_and_type_to_value): New
11038         function.
11039         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11040         Add support for handling an optional second argument.  Call
11041         convert_buffer_and_type_to_value as appropriate.
11042         * python/python-internal.h (Py_buffer_deleter): New struct.
11043         (Py_buffer_up): New typedef.
11044
11045 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11046
11047         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11048         instead of releasing ownership.
11049
11050 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11051
11052         * dwarf2read.c (open_and_init_dwp_file): Call
11053         elf_numsections instead of bfd_count_sections to initialize
11054         dwp_file->num_sections.
11055
11056 2019-02-25  Tom Tromey  <tromey@adacore.com>
11057
11058         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11059
11060 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11061
11062         * gcore.in: Add '--readnever' option when invoking GDB.
11063
11064 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11065
11066         * MAINTAINERS: Update my email address.
11067
11068 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11069
11070         * build-id.c (build_id_to_debug_bfd_1): New function.
11071         (build_id_to_debug_bfd): Look for separate debug file in
11072         sysroot.
11073
11074 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11075
11076         * gdbarch.sh: Update the copyright year range that is placed into
11077         generated files.
11078
11079 2019-02-22  Keith Seitz  <keiths@redhat.com>
11080
11081         PR symtab/23853
11082         * linespec.c (create_sals_line_offset): Search for the default
11083         symtab's filename instead of its fullname.
11084
11085 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11086
11087         * NEWS: Update style defaults.
11088
11089 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11090
11091         * main.c (captured_main_1): Disable styling in batch mode.
11092
11093 2019-02-20  Tom Tromey  <tom@tromey.com>
11094
11095         * symtab.c (symtab_symbol_info): Fix typos.
11096
11097 2019-02-20  Tom Tromey  <tromey@adacore.com>
11098
11099         * findcmd.c (_initialize_mem_search): Use upper case for
11100         metasyntactic variables.
11101
11102 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11103
11104         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11105         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11106
11107 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11108
11109         * top.h (source_file_name): Change to std::string.
11110         * top.c (source_file_name): Likewise.
11111         (command_line_input): Adjust.
11112         * cli/cli-script.c (script_from_file): Adjust.
11113
11114 2019-02-19  Tom Tromey  <tromey@adacore.com>
11115
11116         * ravenscar-thread.c
11117         (ravenscar_thread_target::update_thread_list): Don't call
11118         ada_build_task_list.
11119         * ada-lang.h (ada_build_task_list): Don't declare.
11120         * ada-tasks.c (struct ada_tasks_inferior_data)
11121         <task_list_valid_p>: Now bool.
11122         (read_known_tasks, ada_task_list_changed)
11123         (ada_tasks_invalidate_inferior_data): Update.
11124         (read_known_tasks_array): Return bool.
11125         (read_known_tasks_list): Likewise.
11126         (read_known_tasks): Return void.
11127         (ada_build_task_list): Now static.
11128
11129 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11130
11131         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11132         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11133
11134 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11135
11136         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11137         variant for ada_tasks_pspace_data_handle and
11138         ada_tasks_inferior_data_handle.
11139         (ada_tasks_pspace_data_cleanup): New function.
11140         (ada_tasks_inferior_data_cleanup): New function.
11141
11142 2019-02-17  Tom Tromey  <tom@tromey.com>
11143
11144         * macrotab.h (macro_source_fullname): Return a std::string.
11145         * macrotab.c (macro_include, check_for_redefinition)
11146         (macro_undef, macro_lookup_definition, foreach_macro)
11147         (foreach_macro_in_scope): Update.
11148         (macro_source_fullname): Return a std::string.
11149         * macrocmd.c (show_pp_source_pos): Update.
11150
11151 2019-02-17  Tom Tromey  <tom@tromey.com>
11152
11153         * macrocmd.c (show_pp_source_pos): Style the file names.
11154
11155 2019-02-17  Tom Tromey  <tom@tromey.com>
11156
11157         PR tui/24197:
11158         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11159
11160 2019-02-17  Tom Tromey  <tom@tromey.com>
11161
11162         * ada-lang.c (user_select_syms): Use filtered printing.
11163         * utils.c (wrap_style): New global.
11164         (desired_style): Remove.
11165         (emit_style_escape): Add stream parameter.
11166         (set_output_style, reset_terminal_style, prompt_for_continue):
11167         Update.
11168         (flush_wrap_buffer): Only flush gdb_stdout.
11169         (wrap_here): Set wrap_style.
11170         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11171         treat escape sequences as a character.  Change when wrap buffer is
11172         flushed.
11173         (fputs_styled): Do not set the output style when the default is
11174         requested.
11175         * ui-style.h (struct ui_file_style) <is_default>: New method.
11176         * source.c (print_source_lines_base): Emit escape sequences in one
11177         piece.
11178
11179 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11180
11181         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11182         integers and enumeration types.
11183
11184 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11185
11186         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11187         instead of lookup_symbol_in_language
11188         (do_exact_match): New function.
11189         (ada_get_symbol_name_matcher): Return do_exact_match when
11190         doing a verbatim match.
11191
11192 2019-02-15  Tom Tromey  <tromey@adacore.com>
11193
11194         * ravenscar-thread.c (ravenscar_thread_target::resume)
11195         (ravenscar_thread_target::wait): Special case wildcard requests.
11196
11197 2019-02-15  Tom Tromey  <tromey@adacore.com>
11198
11199         * ravenscar-thread.c (base_ptid): Remove.
11200         (struct ravenscar_thread_target) <close>: New method.
11201         <m_base_ptid>: New member.
11202         <update_inferior_ptid, active_task, task_is_currently_active,
11203         runtime_initialized>: Declare methods.
11204         <ravenscar_thread_target>: Add constructor.
11205         (ravenscar_thread_target::task_is_currently_active)
11206         (ravenscar_thread_target::update_inferior_ptid)
11207         (ravenscar_runtime_initialized): Rename.  Now methods.
11208         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11209         (ravenscar_thread_target::update_thread_list): Update.
11210         (ravenscar_thread_target::active_task): Now method.
11211         (ravenscar_thread_target::store_registers)
11212         (ravenscar_thread_target::prepare_to_store)
11213         (ravenscar_thread_target::prepare_to_store)
11214         (ravenscar_thread_target::mourn_inferior): Update.
11215         (ravenscar_inferior_created): Use "new" to create target.
11216         (ravenscar_thread_target::get_ada_task_ptid): Update.
11217         (_initialize_ravenscar): Don't initialize base_ptid.
11218         (ravenscar_ops): Remove global.
11219
11220 2019-02-15  Tom Tromey  <tromey@adacore.com>
11221
11222         * target.h (push_target): Declare new overload.
11223         * target.c (push_target): New overload, taking an rvalue reference.
11224         * remote.c (remote_target::open_1): Use push_target overload.
11225         * corelow.c (core_target_open): Use push_target overload.
11226
11227 2019-02-15  Tom Tromey  <tromey@adacore.com>
11228
11229         * ravenscar-thread.c (is_ravenscar_task)
11230         (ravenscar_task_is_currently_active): Return bool.
11231         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11232         (_initialize_ravenscar): Remove "(void)".
11233         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11234         Return bool.
11235
11236 2019-02-15  Tom Tromey  <tromey@adacore.com>
11237
11238         * ravenscar-thread.c (ravenscar_runtime_initializer)
11239         (has_ravenscar_runtime, get_running_thread_id)
11240         (ravenscar_thread_target::resume): Fix indentation.
11241
11242 2019-02-15  Tom Tromey  <tromey@adacore.com>
11243
11244         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11245         from ravenscar_arch_ops.
11246         (sparc_ravenscar_ops::fetch_registers)
11247         (sparc_ravenscar_ops::store_registers): Now methods.
11248         (sparc_ravenscar_prepare_to_store): Remove.
11249         (sparc_ravenscar_ops): Redefine.
11250         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11251         methods and destructor.  Remove members.
11252         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11253         (ravenscar_thread_target::store_registers)
11254         (ravenscar_thread_target::prepare_to_store): Update.
11255         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11256         Remove.
11257         (struct ppc_ravenscar_powerpc_ops): Derive from
11258         ravenscar_arch_ops.
11259         (ppc_ravenscar_powerpc_ops::fetch_registers)
11260         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11261         (ppc_ravenscar_powerpc_ops): Redefine.
11262         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11263         (ppc_ravenscar_e500_ops::fetch_registers)
11264         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11265         (ppc_ravenscar_e500_ops): Redefine.
11266         * aarch64-ravenscar-thread.c
11267         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11268         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11269         (aarch64_ravenscar_fetch_registers)
11270         (aarch64_ravenscar_store_registers): Now methods.
11271         (aarch64_ravenscar_ops): Redefine.
11272
11273 2019-02-15  Tom Tromey  <tromey@adacore.com>
11274
11275         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11276         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11277         (ravenscar_thread_target::stopped_by_watchpoint)
11278         (ravenscar_thread_target::stopped_data_address)
11279         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11280
11281 2019-02-15  Tom Tromey  <tromey@adacore.com>
11282
11283         * ravenscar-thread.c: Fix some typos.
11284
11285 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11286             Tom Tromey  <tromey@adacore.com>
11287
11288         * ada-lang.c (ada_exception_sal): Change addr_string to a
11289         std::string.
11290         (create_ada_exception_catchpoint): Update.
11291
11292 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11293             Tom Tromey  <tromey@adacore.com>
11294
11295         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11296         (bp_location_ops): Remove.
11297         (base_breakpoint_allocate_location): Update.
11298         (free_bp_location): Update.
11299         * ada-lang.c (class ada_catchpoint_location)
11300         <ada_catchpoint_location>: Remove ops parameter.
11301         (ada_catchpoint_location_dtor): Remove.
11302         (ada_catchpoint_location_ops): Remove.
11303         (allocate_location_exception): Update.
11304         * breakpoint.h (struct bp_location_ops): Remove.
11305         (class bp_location) <bp_location>: Remove bp_location_ops
11306         parameter.
11307         <~bp_location>: Add destructor.
11308         <ops>: Remove.
11309
11310 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11311             Pedro Alves  <palves@redhat.com>
11312
11313         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11314         'PATH_MAX'.
11315
11316 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11317             Samuel Thibault  <samuel.thibault@gnu.org>
11318             Thomas Schwinge  <thomas@codesourcery.com>
11319
11320         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11321         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11322
11323 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11324
11325         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11326         (check_empty): Use "const char *".
11327
11328         * gnu-nat.c (gnu_nat_target::detach): Instead of
11329         'detach_inferior (pid)' call
11330         'detach_inferior (find_inferior_pid (pid))'.
11331
11332         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11333         'nat/fork-inferior.o'.
11334         * gnu-nat.c: #include "nat/fork-inferior.h".
11335
11336         * gnu-nat.c (gnu_nat_target::detach): Instead of
11337         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11338         * gnu-nat.h: #include "inf-child.h".
11339         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11340         'i386_gnu_nat_target::fetch_registers'.
11341         (gnu_store_registers): Rename/move to
11342         'i386_gnu_nat_target::store_registers'.
11343
11344         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11345         * gnu-nat.h (mach_thread_info): New function.
11346         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11347
11348         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11349
11350 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11351
11352         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11353
11354 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11355
11356         * windows-nat.c (windows_add_thread): Add new parameter
11357         "main_thread_p" with default value set to false.  Update
11358         function documentation as well as all callers.
11359         (windows_delete_thread): Likewise.
11360         (fake_create_process): Update call to windows_add_thread.
11361         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11362         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11363         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11364         call to windows_delete_thread.
11365
11366 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11367
11368         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11369
11370 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11371
11372         * symfile.c (find_separate_debug_file): Use canonical path of
11373         sysroot with child_path instead of gdb_sysroot if it is valid.
11374
11375 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11376
11377         * symfile.c (find_separate_debug_file): Use child_path to
11378         determine if an object file is under a sysroot.
11379
11380 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11381
11382         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11383         unittests/child-path-selftests.c.
11384         * common/pathstuff.c (child_path): New function.
11385         * common/pathstuff.h (child_path): New prototype.
11386         * unittests/child-path-selftests.c: New file.
11387
11388 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11389
11390         * symfile.c (find_separate_debug_file): Look for separate debug
11391         files in debug directories under the sysroot.
11392
11393 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11394
11395         * symtab.h (struct minimal_symbol data_p): New const method.
11396         (struct minimal_symbol text_p): Likewise.
11397         * symtab.c (output_source_filename): Use file name style
11398         to print file name.
11399         (print_symbol_info): Likewise.
11400         (print_msymbol_info): Use address style to print addresses.
11401         Use function name style to print executable text symbols.
11402         (expand_symtab_containing_pc): Use data_p.
11403         (find_pc_sect_compunit_symtab): Likewise.
11404
11405 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11406
11407         * breakpoint.c (describe_other_breakpoints): Use address style
11408         to print addresses.
11409         (say_where): Likewise.
11410
11411 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11412
11413         * ada-typeprint.c (print_func_type): Print function name
11414         style to print function name.
11415         * c-typeprint.c (c_print_type_1): Likewise.
11416
11417 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11418
11419         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11420         for execve.
11421
11422 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11423
11424         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11425         type_stack.
11426
11427 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11428
11429         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11430         TYPE_CODE_REF types.
11431
11432 2019-02-08  Jim Wilson  <jimw@sifive.com>
11433
11434         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11435         (riscv_linux_fregset): New.
11436         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11437
11438 2019-02-07  Tom Tromey  <tom@tromey.com>
11439
11440         * thread.c (thread_cancel_execution_command): Update.
11441         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11442         methods.
11443         (struct thread_fsm_ops): Remove.
11444         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11445         (thread_fsm_should_stop, thread_fsm_return_value)
11446         (thread_fsm_set_finished, thread_fsm_finished_p)
11447         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11448         Don't declare.
11449         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11450         * infrun.c (clear_proceed_status_thread)
11451         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11452         (print_stop_event): Update.
11453         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11454         Add constructor.
11455         (step_command_fsm_ops): Remove.
11456         (new_step_command_fsm): Remove.
11457         (step_1): Update.
11458         (step_command_fsm::should_stop): Rename from
11459         step_command_fsm_should_stop.
11460         (step_command_fsm::clean_up): Rename from
11461         step_command_fsm_clean_up.
11462         (step_command_fsm::do_async_reply_reason): Rename from
11463         step_command_fsm_async_reply_reason.
11464         (struct until_next_fsm): Inherit from thread_fsm.  Add
11465         constructor.
11466         (until_next_fsm_ops): Remove.
11467         (new_until_next_fsm): Remove.
11468         (until_next_fsm::should_stop): Rename from
11469         until_next_fsm_should_stop.
11470         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11471         (until_next_fsm::do_async_reply_reason): Rename from
11472         until_next_fsm_async_reply_reason.
11473         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11474         constructor.  Change type of breakpoint.
11475         (finish_command_fsm_ops): Remove.
11476         (new_finish_command_fsm): Remove.
11477         (finish_command_fsm::should_stop): Rename from
11478         finish_command_fsm_should_stop.
11479         (finish_command_fsm::clean_up): Rename from
11480         finish_command_fsm_clean_up.
11481         (finish_command_fsm::return_value): Rename from
11482         finish_command_fsm_return_value.
11483         (finish_command_fsm::do_async_reply_reason): Rename from
11484         finish_command_fsm_async_reply_reason.
11485         (finish_command): Update.
11486         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11487         Add constructor.
11488         (call_thread_fsm_ops): Remove.
11489         (call_thread_fsm::call_thread_fsm): Rename from
11490         new_call_thread_fsm.
11491         (call_thread_fsm::should_stop): Rename from
11492         call_thread_fsm_should_stop.
11493         (call_thread_fsm::should_notify_stop): Rename from
11494         call_thread_fsm_should_notify_stop.
11495         (run_inferior_call, call_function_by_hand_dummy): Update.
11496         * cli/cli-interp.c (should_print_stop_to_console): Update.
11497         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11498         Add constructor.  Change type of location_breakpoint,
11499         caller_breakpoint.
11500         (until_break_fsm_ops): Remove.
11501         (new_until_break_fsm): Remove.
11502         (until_break_fsm::should_stop): Rename from
11503         until_break_fsm_should_stop.
11504         (until_break_fsm::clean_up): Rename from
11505         until_break_fsm_clean_up.
11506         (until_break_fsm::do_async_reply_reason): Rename from
11507         until_break_fsm_async_reply_reason.
11508         (until_break_command): Update.
11509         * thread-fsm.c: Remove.
11510         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11511
11512 2019-02-07  Tom Tromey  <tom@tromey.com>
11513
11514         * yy-remap.h: Add include guard.
11515         * xtensa-tdep.h: Add include guard.
11516         * xcoffread.h: Rename include guard.
11517         * varobj-iter.h: Add include guard.
11518         * tui/tui.h: Rename include guard.
11519         * tui/tui-winsource.h: Rename include guard.
11520         * tui/tui-wingeneral.h: Rename include guard.
11521         * tui/tui-windata.h: Rename include guard.
11522         * tui/tui-win.h: Rename include guard.
11523         * tui/tui-stack.h: Rename include guard.
11524         * tui/tui-source.h: Rename include guard.
11525         * tui/tui-regs.h: Rename include guard.
11526         * tui/tui-out.h: Rename include guard.
11527         * tui/tui-layout.h: Rename include guard.
11528         * tui/tui-io.h: Rename include guard.
11529         * tui/tui-hooks.h: Rename include guard.
11530         * tui/tui-file.h: Rename include guard.
11531         * tui/tui-disasm.h: Rename include guard.
11532         * tui/tui-data.h: Rename include guard.
11533         * tui/tui-command.h: Rename include guard.
11534         * tic6x-tdep.h: Add include guard.
11535         * target/waitstatus.h: Rename include guard.
11536         * target/wait.h: Rename include guard.
11537         * target/target.h: Rename include guard.
11538         * target/resume.h: Rename include guard.
11539         * target-float.h: Rename include guard.
11540         * stabsread.h: Add include guard.
11541         * rs6000-tdep.h: Add include guard.
11542         * riscv-fbsd-tdep.h: Add include guard.
11543         * regformats/regdef.h: Rename include guard.
11544         * record.h: Rename include guard.
11545         * python/python.h: Rename include guard.
11546         * python/python-internal.h: Rename include guard.
11547         * python/py-stopevent.h: Rename include guard.
11548         * python/py-ref.h: Rename include guard.
11549         * python/py-record.h: Rename include guard.
11550         * python/py-record-full.h: Rename include guard.
11551         * python/py-record-btrace.h: Rename include guard.
11552         * python/py-instruction.h: Rename include guard.
11553         * python/py-events.h: Rename include guard.
11554         * python/py-event.h: Rename include guard.
11555         * procfs.h: Add include guard.
11556         * proc-utils.h: Add include guard.
11557         * p-lang.h: Add include guard.
11558         * or1k-tdep.h: Rename include guard.
11559         * observable.h: Rename include guard.
11560         * nto-tdep.h: Rename include guard.
11561         * nat/x86-linux.h: Rename include guard.
11562         * nat/x86-linux-dregs.h: Rename include guard.
11563         * nat/x86-gcc-cpuid.h: Add include guard.
11564         * nat/x86-dregs.h: Rename include guard.
11565         * nat/x86-cpuid.h: Rename include guard.
11566         * nat/ppc-linux.h: Rename include guard.
11567         * nat/mips-linux-watch.h: Rename include guard.
11568         * nat/linux-waitpid.h: Rename include guard.
11569         * nat/linux-ptrace.h: Rename include guard.
11570         * nat/linux-procfs.h: Rename include guard.
11571         * nat/linux-osdata.h: Rename include guard.
11572         * nat/linux-nat.h: Rename include guard.
11573         * nat/linux-namespaces.h: Rename include guard.
11574         * nat/linux-btrace.h: Rename include guard.
11575         * nat/glibc_thread_db.h: Rename include guard.
11576         * nat/gdb_thread_db.h: Rename include guard.
11577         * nat/gdb_ptrace.h: Rename include guard.
11578         * nat/fork-inferior.h: Rename include guard.
11579         * nat/amd64-linux-siginfo.h: Rename include guard.
11580         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11581         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11582         * nat/aarch64-linux.h: Rename include guard.
11583         * nat/aarch64-linux-hw-point.h: Rename include guard.
11584         * mn10300-tdep.h: Add include guard.
11585         * mips-linux-tdep.h: Add include guard.
11586         * mi/mi-parse.h: Rename include guard.
11587         * mi/mi-out.h: Rename include guard.
11588         * mi/mi-main.h: Rename include guard.
11589         * mi/mi-interp.h: Rename include guard.
11590         * mi/mi-getopt.h: Rename include guard.
11591         * mi/mi-console.h: Rename include guard.
11592         * mi/mi-common.h: Rename include guard.
11593         * mi/mi-cmds.h: Rename include guard.
11594         * mi/mi-cmd-break.h: Rename include guard.
11595         * m2-lang.h: Add include guard.
11596         * location.h: Rename include guard.
11597         * linux-record.h: Rename include guard.
11598         * linux-nat.h: Add include guard.
11599         * linux-fork.h: Add include guard.
11600         * i386-darwin-tdep.h: Rename include guard.
11601         * hppa-linux-offsets.h: Add include guard.
11602         * guile/guile.h: Rename include guard.
11603         * guile/guile-internal.h: Rename include guard.
11604         * gnu-nat.h: Rename include guard.
11605         * gdb-stabs.h: Rename include guard.
11606         * frv-tdep.h: Add include guard.
11607         * f-lang.h: Add include guard.
11608         * event-loop.h: Add include guard.
11609         * darwin-nat.h: Rename include guard.
11610         * cp-abi.h: Rename include guard.
11611         * config/sparc/nm-sol2.h: Rename include guard.
11612         * config/nm-nto.h: Rename include guard.
11613         * config/nm-linux.h: Add include guard.
11614         * config/i386/nm-i386gnu.h: Rename include guard.
11615         * config/djgpp/nl_types.h: Rename include guard.
11616         * config/djgpp/langinfo.h: Rename include guard.
11617         * compile/gcc-cp-plugin.h: Add include guard.
11618         * compile/gcc-c-plugin.h: Add include guard.
11619         * compile/compile.h: Rename include guard.
11620         * compile/compile-object-run.h: Rename include guard.
11621         * compile/compile-object-load.h: Rename include guard.
11622         * compile/compile-internal.h: Rename include guard.
11623         * compile/compile-cplus.h: Rename include guard.
11624         * compile/compile-c.h: Rename include guard.
11625         * common/xml-utils.h: Rename include guard.
11626         * common/x86-xstate.h: Rename include guard.
11627         * common/version.h: Rename include guard.
11628         * common/vec.h: Rename include guard.
11629         * common/tdesc.h: Rename include guard.
11630         * common/selftest.h: Rename include guard.
11631         * common/scoped_restore.h: Rename include guard.
11632         * common/scoped_mmap.h: Rename include guard.
11633         * common/scoped_fd.h: Rename include guard.
11634         * common/safe-iterator.h: Rename include guard.
11635         * common/run-time-clock.h: Rename include guard.
11636         * common/refcounted-object.h: Rename include guard.
11637         * common/queue.h: Rename include guard.
11638         * common/ptid.h: Rename include guard.
11639         * common/print-utils.h: Rename include guard.
11640         * common/preprocessor.h: Rename include guard.
11641         * common/pathstuff.h: Rename include guard.
11642         * common/observable.h: Rename include guard.
11643         * common/netstuff.h: Rename include guard.
11644         * common/job-control.h: Rename include guard.
11645         * common/host-defs.h: Rename include guard.
11646         * common/gdb_wait.h: Rename include guard.
11647         * common/gdb_vecs.h: Rename include guard.
11648         * common/gdb_unlinker.h: Rename include guard.
11649         * common/gdb_unique_ptr.h: Rename include guard.
11650         * common/gdb_tilde_expand.h: Rename include guard.
11651         * common/gdb_sys_time.h: Rename include guard.
11652         * common/gdb_string_view.h: Rename include guard.
11653         * common/gdb_splay_tree.h: Rename include guard.
11654         * common/gdb_setjmp.h: Rename include guard.
11655         * common/gdb_ref_ptr.h: Rename include guard.
11656         * common/gdb_optional.h: Rename include guard.
11657         * common/gdb_locale.h: Rename include guard.
11658         * common/gdb_assert.h: Rename include guard.
11659         * common/filtered-iterator.h: Rename include guard.
11660         * common/filestuff.h: Rename include guard.
11661         * common/fileio.h: Rename include guard.
11662         * common/environ.h: Rename include guard.
11663         * common/common-utils.h: Rename include guard.
11664         * common/common-types.h: Rename include guard.
11665         * common/common-regcache.h: Rename include guard.
11666         * common/common-inferior.h: Rename include guard.
11667         * common/common-gdbthread.h: Rename include guard.
11668         * common/common-exceptions.h: Rename include guard.
11669         * common/common-defs.h: Rename include guard.
11670         * common/common-debug.h: Rename include guard.
11671         * common/cleanups.h: Rename include guard.
11672         * common/buffer.h: Rename include guard.
11673         * common/btrace-common.h: Rename include guard.
11674         * common/break-common.h: Rename include guard.
11675         * cli/cli-utils.h: Rename include guard.
11676         * cli/cli-style.h: Rename include guard.
11677         * cli/cli-setshow.h: Rename include guard.
11678         * cli/cli-script.h: Rename include guard.
11679         * cli/cli-interp.h: Rename include guard.
11680         * cli/cli-decode.h: Rename include guard.
11681         * cli/cli-cmds.h: Rename include guard.
11682         * charset-list.h: Add include guard.
11683         * buildsym-legacy.h: Rename include guard.
11684         * bfin-tdep.h: Add include guard.
11685         * ax.h: Rename include guard.
11686         * arm-linux-tdep.h: Add include guard.
11687         * arm-fbsd-tdep.h: Add include guard.
11688         * arch/xtensa.h: Rename include guard.
11689         * arch/tic6x.h: Add include guard.
11690         * arch/i386.h: Add include guard.
11691         * arch/arm.h: Rename include guard.
11692         * arch/arm-linux.h: Rename include guard.
11693         * arch/arm-get-next-pcs.h: Rename include guard.
11694         * arch/amd64.h: Add include guard.
11695         * arch/aarch64-insn.h: Rename include guard.
11696         * arch-utils.h: Rename include guard.
11697         * annotate.h: Add include guard.
11698         * amd64-darwin-tdep.h: Rename include guard.
11699         * aarch64-linux-tdep.h: Add include guard.
11700         * aarch64-fbsd-tdep.h: Add include guard.
11701         * aarch32-linux-nat.h: Add include guard.
11702
11703 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11704
11705         * macrotab.c (macro_define_internal): New function that
11706         factorizes macro_define_object_internal and macro_define_function
11707         code.
11708         (macro_define_object_internal): Use macro_define_internal.
11709         (macro_define_function): Likewise.
11710
11711 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11712
11713         * macrocmd.c (extract_identifier): Return
11714         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11715         callers.
11716
11717 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11718
11719         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11720
11721 2019-02-05  Tom Tromey  <tom@tromey.com>
11722
11723         * target.c (target_stack::unpush): Move assertion earlier.
11724
11725 2019-01-30  Tom Tromey  <tom@tromey.com>
11726
11727         PR python/23615:
11728         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11729         (gdbpy_parse_and_eval): Likewise.
11730         * python/python-internal.h (gdbpy_allow_threads): New class.
11731
11732 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11733
11734         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11735         (aarch64_fbsd_fpregmap): Move earlier.
11736         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11737         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11738         instead of individual calls to trad_frame_set_reg_addr.
11739         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11740         earlier.
11741         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11742         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11743         instead of individual calls to trad_frame_set_reg_addr.
11744
11745 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11746
11747         * CONTRIBUTE: Replace contribution list with wiki link.
11748
11749 2019-01-25  Tom Tromey  <tom@tromey.com>
11750
11751         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11752
11753 2019-01-25  Tom Tromey  <tom@tromey.com>
11754
11755         * xtensa-linux-nat.c: Fix common/ includes.
11756         * xml-support.h: Fix common/ includes.
11757         * xml-support.c: Fix common/ includes.
11758         * x86-linux-nat.c: Fix common/ includes.
11759         * windows-nat.c: Fix common/ includes.
11760         * varobj.h: Fix common/ includes.
11761         * varobj.c: Fix common/ includes.
11762         * value.c: Fix common/ includes.
11763         * valops.c: Fix common/ includes.
11764         * utils.c: Fix common/ includes.
11765         * unittests/xml-utils-selftests.c: Fix common/ includes.
11766         * unittests/utils-selftests.c: Fix common/ includes.
11767         * unittests/unpack-selftests.c: Fix common/ includes.
11768         * unittests/tracepoint-selftests.c: Fix common/ includes.
11769         * unittests/style-selftests.c: Fix common/ includes.
11770         * unittests/string_view-selftests.c: Fix common/ includes.
11771         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11772         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11773         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11774         * unittests/rsp-low-selftests.c: Fix common/ includes.
11775         * unittests/parse-connection-spec-selftests.c: Fix common/
11776         includes.
11777         * unittests/optional-selftests.c: Fix common/ includes.
11778         * unittests/offset-type-selftests.c: Fix common/ includes.
11779         * unittests/observable-selftests.c: Fix common/ includes.
11780         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11781         * unittests/memrange-selftests.c: Fix common/ includes.
11782         * unittests/memory-map-selftests.c: Fix common/ includes.
11783         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11784         * unittests/function-view-selftests.c: Fix common/ includes.
11785         * unittests/environ-selftests.c: Fix common/ includes.
11786         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11787         * unittests/common-utils-selftests.c: Fix common/ includes.
11788         * unittests/cli-utils-selftests.c: Fix common/ includes.
11789         * unittests/array-view-selftests.c: Fix common/ includes.
11790         * ui-file.c: Fix common/ includes.
11791         * tui/tui-io.c: Fix common/ includes.
11792         * tracepoint.h: Fix common/ includes.
11793         * tracepoint.c: Fix common/ includes.
11794         * tracefile-tfile.c: Fix common/ includes.
11795         * top.h: Fix common/ includes.
11796         * top.c: Fix common/ includes.
11797         * thread.c: Fix common/ includes.
11798         * target/waitstatus.h: Fix common/ includes.
11799         * target/waitstatus.c: Fix common/ includes.
11800         * target.h: Fix common/ includes.
11801         * target.c: Fix common/ includes.
11802         * target-memory.c: Fix common/ includes.
11803         * target-descriptions.c: Fix common/ includes.
11804         * symtab.h: Fix common/ includes.
11805         * symfile.c: Fix common/ includes.
11806         * stap-probe.c: Fix common/ includes.
11807         * spu-linux-nat.c: Fix common/ includes.
11808         * sparc-nat.c: Fix common/ includes.
11809         * source.c: Fix common/ includes.
11810         * solib.c: Fix common/ includes.
11811         * solib-target.c: Fix common/ includes.
11812         * ser-unix.c: Fix common/ includes.
11813         * ser-tcp.c: Fix common/ includes.
11814         * ser-pipe.c: Fix common/ includes.
11815         * ser-base.c: Fix common/ includes.
11816         * selftest-arch.c: Fix common/ includes.
11817         * s12z-tdep.c: Fix common/ includes.
11818         * rust-exp.y: Fix common/ includes.
11819         * rs6000-aix-tdep.c: Fix common/ includes.
11820         * riscv-tdep.c: Fix common/ includes.
11821         * remote.c: Fix common/ includes.
11822         * remote-notif.h: Fix common/ includes.
11823         * remote-fileio.h: Fix common/ includes.
11824         * remote-fileio.c: Fix common/ includes.
11825         * regcache.h: Fix common/ includes.
11826         * regcache.c: Fix common/ includes.
11827         * record-btrace.c: Fix common/ includes.
11828         * python/python.c: Fix common/ includes.
11829         * python/py-type.c: Fix common/ includes.
11830         * python/py-inferior.c: Fix common/ includes.
11831         * progspace.h: Fix common/ includes.
11832         * producer.c: Fix common/ includes.
11833         * procfs.c: Fix common/ includes.
11834         * proc-api.c: Fix common/ includes.
11835         * printcmd.c: Fix common/ includes.
11836         * ppc-linux-nat.c: Fix common/ includes.
11837         * parser-defs.h: Fix common/ includes.
11838         * osdata.c: Fix common/ includes.
11839         * obsd-nat.c: Fix common/ includes.
11840         * nat/x86-linux.c: Fix common/ includes.
11841         * nat/x86-linux-dregs.c: Fix common/ includes.
11842         * nat/x86-dregs.h: Fix common/ includes.
11843         * nat/x86-dregs.c: Fix common/ includes.
11844         * nat/ppc-linux.c: Fix common/ includes.
11845         * nat/mips-linux-watch.h: Fix common/ includes.
11846         * nat/mips-linux-watch.c: Fix common/ includes.
11847         * nat/linux-waitpid.c: Fix common/ includes.
11848         * nat/linux-ptrace.h: Fix common/ includes.
11849         * nat/linux-ptrace.c: Fix common/ includes.
11850         * nat/linux-procfs.c: Fix common/ includes.
11851         * nat/linux-personality.c: Fix common/ includes.
11852         * nat/linux-osdata.c: Fix common/ includes.
11853         * nat/linux-namespaces.c: Fix common/ includes.
11854         * nat/linux-btrace.h: Fix common/ includes.
11855         * nat/linux-btrace.c: Fix common/ includes.
11856         * nat/fork-inferior.c: Fix common/ includes.
11857         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11858         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11859         * nat/aarch64-linux.c: Fix common/ includes.
11860         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11861         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11862         * namespace.h: Fix common/ includes.
11863         * mips-linux-tdep.c: Fix common/ includes.
11864         * minsyms.c: Fix common/ includes.
11865         * mi/mi-parse.h: Fix common/ includes.
11866         * mi/mi-main.c: Fix common/ includes.
11867         * mi/mi-cmd-env.c: Fix common/ includes.
11868         * memrange.h: Fix common/ includes.
11869         * memattr.c: Fix common/ includes.
11870         * maint.h: Fix common/ includes.
11871         * maint.c: Fix common/ includes.
11872         * main.c: Fix common/ includes.
11873         * machoread.c: Fix common/ includes.
11874         * location.c: Fix common/ includes.
11875         * linux-thread-db.c: Fix common/ includes.
11876         * linux-nat.c: Fix common/ includes.
11877         * linux-fork.c: Fix common/ includes.
11878         * inline-frame.c: Fix common/ includes.
11879         * infrun.c: Fix common/ includes.
11880         * inflow.c: Fix common/ includes.
11881         * inferior.h: Fix common/ includes.
11882         * inferior.c: Fix common/ includes.
11883         * infcmd.c: Fix common/ includes.
11884         * inf-ptrace.c: Fix common/ includes.
11885         * inf-child.c: Fix common/ includes.
11886         * ia64-linux-nat.c: Fix common/ includes.
11887         * i387-tdep.c: Fix common/ includes.
11888         * i386-tdep.c: Fix common/ includes.
11889         * i386-linux-tdep.c: Fix common/ includes.
11890         * i386-linux-nat.c: Fix common/ includes.
11891         * i386-go32-tdep.c: Fix common/ includes.
11892         * i386-fbsd-tdep.c: Fix common/ includes.
11893         * i386-fbsd-nat.c: Fix common/ includes.
11894         * guile/scm-type.c: Fix common/ includes.
11895         * guile/guile.c: Fix common/ includes.
11896         * go32-nat.c: Fix common/ includes.
11897         * gnu-nat.c: Fix common/ includes.
11898         * gdbthread.h: Fix common/ includes.
11899         * gdbarch-selftests.c: Fix common/ includes.
11900         * gdb_usleep.c: Fix common/ includes.
11901         * gdb_select.h: Fix common/ includes.
11902         * gdb_bfd.c: Fix common/ includes.
11903         * gcore.c: Fix common/ includes.
11904         * fork-child.c: Fix common/ includes.
11905         * findvar.c: Fix common/ includes.
11906         * fbsd-nat.c: Fix common/ includes.
11907         * event-top.c: Fix common/ includes.
11908         * event-loop.c: Fix common/ includes.
11909         * dwarf2read.c: Fix common/ includes.
11910         * dwarf2loc.c: Fix common/ includes.
11911         * dwarf2-frame.c: Fix common/ includes.
11912         * dwarf-index-cache.c: Fix common/ includes.
11913         * dtrace-probe.c: Fix common/ includes.
11914         * disasm-selftests.c: Fix common/ includes.
11915         * defs.h: Fix common/ includes.
11916         * csky-tdep.c: Fix common/ includes.
11917         * cp-valprint.c: Fix common/ includes.
11918         * cp-support.h: Fix common/ includes.
11919         * cp-support.c: Fix common/ includes.
11920         * corelow.c: Fix common/ includes.
11921         * completer.h: Fix common/ includes.
11922         * completer.c: Fix common/ includes.
11923         * compile/compile.c: Fix common/ includes.
11924         * compile/compile-loc2c.c: Fix common/ includes.
11925         * compile/compile-cplus-types.c: Fix common/ includes.
11926         * compile/compile-cplus-symbols.c: Fix common/ includes.
11927         * command.h: Fix common/ includes.
11928         * cli/cli-dump.c: Fix common/ includes.
11929         * cli/cli-cmds.c: Fix common/ includes.
11930         * charset.c: Fix common/ includes.
11931         * build-id.c: Fix common/ includes.
11932         * btrace.h: Fix common/ includes.
11933         * btrace.c: Fix common/ includes.
11934         * breakpoint.h: Fix common/ includes.
11935         * breakpoint.c: Fix common/ includes.
11936         * ax.h:
11937         (enum agent_op): Fix common/ includes.
11938         * ax-general.c (struct aop_map): Fix common/ includes.
11939         * ax-gdb.c: Fix common/ includes.
11940         * auxv.c: Fix common/ includes.
11941         * auto-load.c: Fix common/ includes.
11942         * arm-tdep.c: Fix common/ includes.
11943         * arch/riscv.c: Fix common/ includes.
11944         * arch/ppc-linux-common.c: Fix common/ includes.
11945         * arch/i386.c: Fix common/ includes.
11946         * arch/arm.c: Fix common/ includes.
11947         * arch/arm-linux.c: Fix common/ includes.
11948         * arch/arm-get-next-pcs.c: Fix common/ includes.
11949         * arch/amd64.c: Fix common/ includes.
11950         * arch/aarch64.c: Fix common/ includes.
11951         * arch/aarch64-insn.c: Fix common/ includes.
11952         * arch-utils.c: Fix common/ includes.
11953         * amd64-windows-tdep.c: Fix common/ includes.
11954         * amd64-tdep.c: Fix common/ includes.
11955         * amd64-sol2-tdep.c: Fix common/ includes.
11956         * amd64-obsd-tdep.c: Fix common/ includes.
11957         * amd64-nbsd-tdep.c: Fix common/ includes.
11958         * amd64-linux-tdep.c: Fix common/ includes.
11959         * amd64-linux-nat.c: Fix common/ includes.
11960         * amd64-fbsd-tdep.c: Fix common/ includes.
11961         * amd64-fbsd-nat.c: Fix common/ includes.
11962         * amd64-dicos-tdep.c: Fix common/ includes.
11963         * amd64-darwin-tdep.c: Fix common/ includes.
11964         * agent.c: Fix common/ includes.
11965         * ada-lang.h: Fix common/ includes.
11966         * ada-lang.c: Fix common/ includes.
11967         * aarch64-tdep.c: Fix common/ includes.
11968
11969 2019-01-25  Tom Tromey  <tom@tromey.com>
11970
11971         * common/create-version.sh: Use common/version.h.
11972
11973 2019-01-24  Pedro Alves  <palves@redhat.com>
11974
11975         * infrun.c (signal_stop, signal_print, signal_program)
11976         (signal_catch, signal_pass): Now arrays instead of pointers.
11977         (update_signals_program_target, do_target_resume)
11978         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11979         * linux-nat.c (linux_nat_target::pass_signals)
11980         (linux_nat_target::create_inferior, linux_nat_target::attach):
11981         Adjust.
11982         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11983         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11984         * procfs.c (procfs_target::pass_signals): Adjust.
11985         * record-full.c (record_full_target::resume): Adjust.
11986         * remote.c (remote_target::pass_signals)
11987         (remote_target::program_signals): Adjust.
11988         * target-debug.h (target_debug_print_signals): Now takes a
11989         gdb::array_view as parameter.  Adjust.
11990         * target.h (target_ops) <pass_signals, program_signals>: Replace
11991         pointer and length parameters with gdb::array_view.
11992         (target_pass_signals, target_program_signals): Likewise.
11993         * target-delegates.c: Regenerate.
11994
11995 2019-01-24  Pedro Alves  <palves@redhat.com>
11996
11997         * common/forward-scope-exit.h
11998         (forward_scope_exit::forward_scope_exit): Pass arguments to
11999         m_bind_function directly, instead of creating a std::bind and
12000         copying that.
12001
12002 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12003
12004         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12005         for static members.
12006         (pass_in_v_vfp_candidate): Likewise.
12007
12008 2019-01-23  Tom Tromey  <tom@tromey.com>
12009             Pedro Alves  <palves@redhat.com>
12010
12011         * regcache.c (class regcache_invalidator): Remove.
12012         (regcache::raw_write): Use make_scope_exit.
12013
12014 2019-01-23  Tom Tromey  <tom@tromey.com>
12015
12016         * ui-out.h (class ui_out_emit_type): Update comment.
12017
12018 2019-01-23  Tom Tromey  <tom@tromey.com>
12019
12020         * infrun.c (fetch_inferior_event): Update comment.
12021
12022 2019-01-23  Tom Tromey  <tom@tromey.com>
12023             Pedro Alves  <palves@redhat.com>
12024
12025         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12026         parameter.
12027         (fetch_inferior_event): Use SCOPE_EXIT.
12028
12029
12030 2019-01-23  Tom Tromey  <tom@tromey.com>
12031             Pedro Alves  <palves@redhat.com>
12032
12033         * infrun.c (disable_thread_events): Delete.
12034         (stop_all_threads): Use SCOPE_EXIT.
12035
12036 2019-01-23  Tom Tromey  <tom@tromey.com>
12037             Pedro Alves  <palves@redhat.com>
12038
12039         * symfile.c: Include forward-scope-exit.h.
12040         (clear_symtab_users_cleanup): Replace forward declaration with
12041         a FORWARD_SCOPE_EXIT.
12042         (syms_from_objfile_1): Use the forward_scope_exit and
12043         gdb::optional instead of cleanup_function.
12044         (reread_symbols): Use the forward_scope_exit instead of
12045         cleanup_function.
12046         (clear_symtab_users_cleanup): Remove function.
12047
12048 2019-01-23  Tom Tromey  <tom@tromey.com>
12049             Pedro Alves  <palves@redhat.com>
12050
12051         * linux-nat.c: Include scope-exit.h.
12052         (cleanup_target_stop): Remove.
12053         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12054         SCOPE_EXIT.
12055
12056 2019-01-23  Tom Tromey  <tom@tromey.com>
12057             Pedro Alves  <palves@redhat.com>
12058
12059         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12060         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12061
12062 2019-01-23  Tom Tromey  <tom@tromey.com>
12063             Andrew Burgess  <andrew.burgess@embecosm.com>
12064             Pedro Alves  <palves@redhat.com>
12065
12066         * infrun.c (fetch_inferior_event): Use scope_exit.
12067         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12068         * top.c (execute_command): Use scope_exit.
12069         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12070         * utils.c (do_bpstat_clear_actions_cleanup)
12071         (make_bpstat_clear_actions_cleanup): Remove.
12072
12073 2019-01-23  Tom Tromey  <tom@tromey.com>
12074             Pedro Alves  <palves@redhat.com>
12075
12076         * infrun.c: Include "common/scope-exit.h"
12077         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12078         (wait_for_inferior): Use SCOPE_EXIT.
12079         (fetch_inferior_event): Use scope_exit.
12080
12081 2019-01-23  Tom Tromey  <tom@tromey.com>
12082             Pedro Alves  <palves@redhat.com>
12083
12084         * breakpoint.c (create_breakpoint): Remove cleanup.
12085
12086 2019-01-23  Tom Tromey  <tom@tromey.com>
12087             Andrew Burgess  <andrew.burgess@embecosm.com>
12088             Pedro Alves  <palves@redhat.com>
12089
12090 2019-01-23  Pedro Alves  <palves@redhat.com>
12091
12092         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12093
12094 2019-01-23  Pedro Alves  <palves@redhat.com>
12095             Andrew Burgess  <andrew.burgess@embecosm.com>
12096
12097         * gdbthread.h: Include "common/forward-scope-exit.h".
12098         (scoped_finish_thread_state): Redefine custom class in terms of
12099         forward_scope_exit.
12100
12101 2019-01-23  Pedro Alves  <palves@redhat.com>
12102             Andrew Burgess  <andrew.burgess@embecosm.com>
12103
12104         * common/forward-scope-exit.h: New file.
12105
12106 2019-01-23  Pedro Alves  <palves@redhat.com>
12107             Andrew Burgess  <andrew.burgess@embecosm.com>
12108             Tom Tromey  <tom@tromey.com>
12109
12110         * common/scope-exit.h: New file.
12111
12112 2019-01-23  Pedro Alves  <palves@redhat.com>
12113
12114         * common/preprocessor.h (ESC): Rename to ...
12115         (ESC_PARENS): ... this.
12116         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12117         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12118
12119 2019-01-23  Tom Tromey  <tom@tromey.com>
12120
12121         * language.h (class scoped_switch_to_sym_language_if_auto):
12122         Initialize m_lang in both cases.
12123
12124 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12125
12126         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12127         with XCNEW.
12128
12129 2019-01-22  Tom Tromey  <tom@tromey.com>
12130
12131         * corelow.c: Do not include sys/file.h.
12132
12133 2019-01-22  Tom Tromey  <tom@tromey.com>
12134
12135         * tui/tui-wingeneral.h: Include gdb_curses.h.
12136
12137 2019-01-22  Tom Tromey  <tom@tromey.com>
12138
12139         * source-cache.h (class source_cache) <get_source_lines,
12140         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12141
12142 2019-01-22  Tom Tromey  <tom@tromey.com>
12143
12144         * remote-fileio.h (struct remote_target): Declare.
12145
12146 2019-01-22  Tom Tromey  <tom@tromey.com>
12147
12148         * python/py-arch.c: Do not include py-ref.h.
12149         * python/py-bpevent.c: Do not include py-ref.h.
12150         * python/py-cmd.c: Do not include py-ref.h.
12151         * python/py-continueevent.c: Do not include py-ref.h.
12152         * python/py-event.h: Do not include py-ref.h.
12153         * python/py-evtregistry.c: Do not include py-ref.h.
12154         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12155         * python/py-frame.c: Do not include py-ref.h.
12156         * python/py-framefilter.c: Do not include py-ref.h.
12157         * python/py-function.c: Do not include py-ref.h.
12158         * python/py-infevents.c: Do not include py-ref.h.
12159         * python/py-linetable.c: Do not include py-ref.h.
12160         * python/py-objfile.c: Do not include py-ref.h.
12161         * python/py-param.c: Do not include py-ref.h.
12162         * python/py-prettyprint.c: Do not include py-ref.h.
12163         * python/py-progspace.c: Do not include py-ref.h.
12164         * python/py-symbol.c: Do not include py-ref.h.
12165         * python/py-symtab.c: Do not include py-ref.h.
12166         * python/py-type.c: Do not include py-ref.h.
12167         * python/py-unwind.c: Do not include py-ref.h.
12168         * python/py-utils.c: Do not include py-ref.h.
12169         * python/py-value.c: Do not include py-ref.h.
12170         * python/py-varobj.c: Do not include py-ref.h.
12171         * python/py-xmethods.c: Do not include py-ref.h.
12172         * python/python.c: Do not include py-ref.h.
12173         * varobj.c: Do not include py-ref.h.
12174
12175 2019-01-22  Tom Tromey  <tom@tromey.com>
12176
12177         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12178         keyword for bcache.
12179
12180 2019-01-22  Tom Tromey  <tom@tromey.com>
12181
12182         * compile/compile-cplus-types.c: Remove a comment by #include.
12183
12184 2019-01-22  Tom Tromey  <tom@tromey.com>
12185
12186         * compile/gcc-c-plugin.h: Include compile-internal.h.
12187
12188 2019-01-22  Tom Tromey  <tom@tromey.com>
12189
12190         * stabsread.c (EXTERN): Do not define.
12191         (symnum, next_symbol_text_func, processing_gcc_compilation)
12192         (within_function, global_sym_chain, global_stabs)
12193         (previous_stab_code, this_object_header_files)
12194         (n_this_object_header_files)
12195         (n_allocated_this_object_header_files): Define.
12196         * stabsread.h (EXTERN): Never define.  Use "extern".
12197
12198 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12199
12200         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12201         history_value.
12202
12203 2019-01-21  Tom Tromey  <tom@tromey.com>
12204
12205         * ui-out.c: Fix includes.
12206         * tui/tui-source.c: Fix includes.
12207         * target.c: Fix includes.
12208         * remote.c: Fix includes.
12209         * regcache.c: Fix includes.
12210         * python/py-block.c: Fix includes.
12211         * printcmd.c: Fix includes.
12212         * or1k-tdep.c: Fix includes.
12213         * mi/mi-main.c: Fix includes.
12214         * m32r-tdep.c: Fix includes.
12215         * csky-tdep.c: Fix includes.
12216         * compile/compile-cplus-types.c: Fix includes.
12217         * cli/cli-interp.c: Fix includes.
12218
12219 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12220
12221         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12222         for padding.
12223
12224 2019-01-16  Tom Tromey  <tom@tromey.com>
12225
12226         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12227         earlier.
12228         (struct objfile) <msymbols_range>: Move from top level.
12229         <msymbols>: New method.
12230         (class objfile_msymbols): Remove.
12231         * symtab.c (default_collect_symbol_completion_matches_break_on):
12232         Update.
12233         * symmisc.c (dump_msymbols): Update.
12234         * stabsread.c (scan_file_globals): Update.
12235         * objc-lang.c (info_selectors_command, info_classes_command)
12236         (find_methods): Update.
12237         * minsyms.c (find_solib_trampoline_target): Update.
12238         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12239         * coffread.c (coff_symfile_read): Update.
12240         * ada-lang.c (ada_lookup_simple_minsym)
12241         (ada_collect_symbol_completion_matches): Update.
12242
12243 2019-01-16  Tom Tromey  <tom@tromey.com>
12244
12245         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12246         type.  Remove no-argument constructor.
12247         <iterator::operator++>: Simplify.
12248         <begin>: Update.
12249         <end>: Use minimal_symbol_count.
12250
12251 2019-01-16  Tom Tromey  <tom@tromey.com>
12252
12253         * objfiles.h (struct objfile) <psymtabs>: New method.
12254         (class objfile_psymtabs): Remove.
12255         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12256         typedef.
12257         <range>: New method.
12258         (require_partial_symbols): Change return type.
12259         * psymtab.c (require_partial_symbols)
12260         (psym_expand_symtabs_matching): Update.
12261         * mdebugread.c (parse_partial_symbols): Update.
12262         * dbxread.c (dbx_end_psymtab): Update.
12263
12264 2019-01-15  Tom Tromey  <tom@tromey.com>
12265
12266         * symtab.c (lookup_objfile_from_block)
12267         (lookup_symbol_in_objfile_symtabs)
12268         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12269         (find_line_symtab, info_sources_command)
12270         (default_collect_symbol_completion_matches_break_on)
12271         (make_source_files_completion_list): Update.
12272         * symmisc.c (print_objfile_statistics, dump_objfile)
12273         (maintenance_print_symbols, maintenance_info_symtabs)
12274         (maintenance_check_symtabs, maintenance_info_line_tables):
12275         Update.
12276         * source.c (select_source_symtab)
12277         (forget_cached_source_info_for_objfile): Update.
12278         * objfiles.h (class objfile_compunits): Remove.
12279         (struct objfile) <compunits_range>: New typedef.
12280         (compunits): New method.
12281         * objfiles.c (objfile_relocate1): Update.
12282         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12283         * maint.c (count_symtabs_and_blocks): Update.
12284         * linespec.c (iterate_over_all_matching_symtabs): Update.
12285         * cp-support.c (add_symbol_overload_list_qualified): Update.
12286         * coffread.c (coff_symtab_read): Update.
12287         * ada-lang.c (add_nonlocal_symbols)
12288         (ada_collect_symbol_completion_matches)
12289         (ada_add_global_exceptions): Update.
12290
12291 2019-01-15  Tom Tromey  <tom@tromey.com>
12292
12293         * progspace.h (program_space) <objfiles_safe_range>: New
12294         typedef.
12295         <objfiles_safe>: New method.
12296         * objfiles.h (class all_objfiles_safe): Remove.
12297         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12298         * jit.c (jit_inferior_exit_hook): Update.
12299
12300 2019-01-17  Tom Tromey  <tom@tromey.com>
12301
12302         * progspace.h (program_space) <objfiles_range>: New typedef.
12303         <objfiles>: New method.
12304         <objfiles_head>: Rename from objfiles.
12305         (object_files): Update.
12306         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12307         * guile/scm-pretty-print.c
12308         (ppscm_find_pretty_printer_from_objfiles): Update.
12309         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12310         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12311         Update.
12312         * python/py-progspace.c (pspy_get_objfiles): Update.
12313         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12314         Update.
12315         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12316         (objfpy_lookup_objfile_by_build_id): Update.
12317         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12318         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12319         Update.
12320         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12321         (expand_symtab_containing_pc, lookup_objfile_from_block)
12322         (lookup_static_symbol, basic_lookup_transparent_type)
12323         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12324         (find_line_symtab, info_sources_command)
12325         (default_collect_symbol_completion_matches_break_on)
12326         (make_source_files_completion_list, find_main_name): Update.
12327         * symmisc.c (print_symbol_bcache_statistics)
12328         (print_objfile_statistics, maintenance_print_symbols)
12329         (maintenance_print_msymbols, maintenance_print_objfiles)
12330         (maintenance_info_symtabs, maintenance_check_symtabs)
12331         (maintenance_expand_symtabs, maintenance_info_line_tables):
12332         Update.
12333         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12334         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12335         (map_overlay_command, unmap_overlay_command)
12336         (simple_overlay_update, expand_symtabs_matching)
12337         (map_symbol_filenames): Update.
12338         * symfile-debug.c (set_debug_symfile): Update.
12339         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12340         Update.
12341         * source.c (select_source_symtab, forget_cached_source_info):
12342         Update.
12343         * solib.c (solib_read_symbols): Update.
12344         * solib-spu.c (append_ocl_sos): Update.
12345         * psymtab.c (maintenance_print_psymbols)
12346         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12347         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12348         * printcmd.c (info_symbol_command): Update.
12349         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12350         Update.
12351         * objfiles.h (class all_objfiles): Remove.
12352         * objfiles.c (have_partial_symbols, have_full_symbols)
12353         (have_minimal_symbols, qsort_cmp, update_section_map)
12354         (shared_objfile_contains_address_p)
12355         (default_iterate_over_objfiles_in_search_order): Update.
12356         * objc-lang.c (info_selectors_command, info_classes_command)
12357         (find_methods): Update.
12358         * minsyms.c (find_solib_trampoline_target): Update.
12359         * maint.c (maintenance_info_sections)
12360         (maintenance_translate_address, count_symtabs_and_blocks):
12361         Update.
12362         * main.c (captured_main_1): Update.
12363         * linux-thread-db.c (try_thread_db_load_from_pdir)
12364         (has_libpthread): Update.
12365         * linespec.c (iterate_over_all_matching_symtabs)
12366         (search_minsyms_for_name): Update.
12367         * jit.c (jit_find_objf_with_entry_addr): Update.
12368         * hppa-tdep.c (find_unwind_entry)
12369         (hppa_lookup_stub_minimal_symbol): Update.
12370         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12371         Update.
12372         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12373         (elf_gnu_ifunc_resolve_by_got): Update.
12374         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12375         * dwarf-index-write.c (save_gdb_index_command): Update.
12376         * cp-support.c (add_symbol_overload_list_qualified): Update.
12377         * breakpoint.c (create_overlay_event_breakpoint)
12378         (create_longjmp_master_breakpoint)
12379         (create_std_terminate_master_breakpoint)
12380         (create_exception_master_breakpoint): Update.
12381         * blockframe.c (find_pc_partial_function): Update.
12382         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12383         (ada_collect_symbol_completion_matches)
12384         (ada_add_global_exceptions): Update.
12385
12386 2019-01-17  Tom Tromey  <tom@tromey.com>
12387
12388         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12389         declare VEC.
12390         (solib_target_parse_libraries): Change return type.
12391         (library_list_start_segment, library_list_start_section)
12392         (library_list_end_library, library_list_start_library); Update.
12393         (solib_target_free_library_list): Remove.
12394         (solib_target_parse_libraries): Remove cleanup.  Change return
12395         type.
12396         (solib_target_current_sos): Update.
12397
12398 2019-01-17  Tom Tromey  <tromey@bapiya>
12399
12400         * valprint.c: Replace "the the" with "the".
12401         * symtab.c: Replace "the the" with "the".
12402         * solib.c: Replace "the the" with "the".
12403         * solib-dsbt.c: Replace "the the" with "the".
12404         * linespec.c: Replace "the the" with "the".
12405         * dwarf2loc.h: Replace "the the" with "the".
12406         * amd64-windows-tdep.c: Replace "the the" with "the".
12407         * aarch64-tdep.c: Replace "the the" with "the".
12408
12409 2019-01-16  Keith Seitz  <keiths@redhat.com>
12410
12411         PR gdb/23773
12412         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12413         <builder>: Rename to ..
12414         <m_builder>: ... this and make private.
12415         (dwarf2_cu::get_builder): New method.  Change all users of
12416         `builder' to use this method.
12417         (dwarf2_start_symtab): Move to ...
12418         (dwarf2_cu::start_symtab): ... here.  Update all callers
12419         (setup_type_unit_groups): Move to ...
12420         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12421         callers.
12422         (dwarf2_cu::reset_builder): New method.
12423         (process_full_compunit, process_full_type_unit): Use
12424         dwarf2_cu::reset_builder.
12425         (follow_die_offset): Record the ancestor CU if it is different
12426         from the followed DIE's CU.
12427         (follow_die_sig_1): Likewise.
12428
12429 2019-01-15  Tom Tromey  <tom@tromey.com>
12430
12431         * remote.c (class remote_state) <buf>: Now a char_vector.
12432         <buf_size>: Remove.
12433         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12434         parameter.
12435         (remote_target::getpkt_or_notif_sane_1)
12436         (remote_target::getpkt_sane)
12437         (remote_target::getpkt_or_notif_sane): Likewise.
12438         (class remote_target) <putpkt>: New overload.
12439         (remote_target::read_frame): Change type of "buf_p".  Remove
12440         sizeof_p parameter.
12441         (packet_ok): New overload.
12442         (packet_check_result): New overload.
12443         Update all uses.
12444
12445 2019-01-14  Tom Tromey  <tom@tromey.com>
12446
12447         * remote-notif.c (handle_notification, remote_notif_ack)
12448         (remote_notif_parse): Make "buf" const.
12449         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12450         const.
12451         (remote_notif_parse, remote_notif_ack, handle_notification):
12452         Likewise.
12453         * remote.c (remote_notif_stop_parse): Make "buf" const.
12454         (remote_target::remote_parse_stop_reply): Make "buf" const.
12455         (remote_notif_stop_ack): Make "buf" const.
12456
12457 2019-01-14  Tom Tromey  <tom@tromey.com>
12458
12459         * remote.c (remote_console_output): Make parameter const.
12460
12461 2019-01-14  Tom Tromey  <tom@tromey.com>
12462
12463         * target-debug.h (target_debug_print_signals): Constify.
12464         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12465         * procfs.c (procfs_target::pass_signals): Update.
12466         * linux-nat.c (linux_nat_target::pass_signals): Update.
12467         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12468         * target-delegates.c: Rebuild.
12469         * remote.c (remote_target::program_signals): Update.
12470         (remote_target::pass_signals): Update.
12471         * target.c (target_pass_signals): Constify argument.
12472         (target_program_signals): Likewise.
12473         * target.h (struct target_ops) <pass_signals, program_signals>:
12474         Constify argument.
12475         (target_pass_signals, target_program_signals): Constify argument.
12476
12477 2019-01-14  Tom Tromey  <tom@tromey.com>
12478
12479         PR tui/28819:
12480         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12481
12482 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12483
12484         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12485         field.
12486         * rs6000-tdep.c: Include reggroups.h.
12487         (IS_V_ALIAS_PSEUDOREG): Define.
12488         (rs6000_register_name): Return names for the "vX" aliases.
12489         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12490         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12491         aliases.  Call default_register_reggroup_p for all other
12492         pseudo-registers.
12493         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12494         New functions.
12495         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12496         Handle "vX" aliases.
12497         (v_alias_pseudo_register_collect): New function.
12498         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12499         (rs6000_gdbarch_init): Initialize "vX" aliases as
12500         pseudo-registers.  Restore registration of
12501         rs6000_pseudo_register_reggroup_p with
12502         set_tdesc_pseudo_register_reggroup_p.
12503
12504 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12505
12506         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12507         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12508         set_gdbarch_num_pseudo_regs.
12509
12510 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12511
12512         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12513         Remove arg prefixname, add do_set and do_show.
12514         Add member functions set_list and show_list.
12515         * cli/cli-style.c (class cli_style_option): Update accordingly.
12516         (style_set_list): Move to file scope.
12517         (style_show_list): Likewise.
12518         (set_style): Call help_list.
12519         (show_style): Call cmd_show_list.
12520         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12521         Update to use the new macro.
12522
12523 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12524
12525         * ada-lang.c (_initialize_ada_language): Expand the help text
12526         for the "catch exception" command.
12527
12528 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12529
12530         * symtab.c (matching_obj_sections): Initialize obj,
12531         declare it closer to its usage.
12532
12533 2019-01-10  Tom Tromey  <tom@tromey.com>
12534
12535         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12536         (basic_inf_threads_range): Remove.
12537         (inf_threads_range, inf_non_exited_threads_range)
12538         (safe_inf_threads_range): Use next_adapter.
12539
12540 2019-01-10  Keith Seitz  <keiths@redhat.com>
12541
12542         PR gdb/23712
12543         PR symtab/23010
12544         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12545         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12546
12547 2019-01-10  Keith Seitz  <keiths@redhat.com>
12548
12549         PR gdb/23712
12550         PR symtab/23010
12551         * dictionary.c (pending_to_vector): Remove.
12552         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12553         Remove _1 suffix, replacing functions of the same name.  Update
12554         all callers.
12555         (dict_create_hashed, dict_create_hashed_expandable)
12556         (dict_create_linear, dict_create_linear_expandable, dict_free)
12557         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12558         Make functions static.
12559
12560 2019-01-10  Keith Seitz  <keiths@redhat.com>
12561
12562         PR gdb/23712
12563         PR symtab/23010
12564         * dictionary.h (struct dictionary): Replace declaration with
12565         multidictionary.
12566         (dict_create_hashed, dict_create_hashed_expandable)
12567         (dict_create_linear, dict_create_linear_expandable)
12568         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12569         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12570         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12571         taking multidictionary argument.
12572         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12573         * block.h (struct block) <dict>: Change to multidictionary
12574         and rename `multidict'.
12575         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12576         symmisc.c: Update all dictionary references to multidictionary.
12577
12578 2019-01-10  Keith Seitz  <keiths@redhat.com>
12579
12580         PR gdb/23712
12581         PR symtab/23010
12582         * dictionary.c: Include unordered_map.
12583         (pending_to_vector): New function.
12584         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12585         Rewrite the non-"_1" functions to take vector instead
12586         of linked list.
12587         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12588         "new" _1 versions of the same name.
12589         (multidictionary): Define.
12590         (std::hash<enum language): New definition.
12591         (collate_pending_symbols_by_language, mdict_create_hashed)
12592         (mdict_create_hashed_expandable, mdict_create_linear)
12593         (mdict_create_linear_expandable, mdict_free)
12594         (find_language_dictionary, create_new_language_dictionary)
12595         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12596         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12597         (mdict_size, mdict_empty): New functions.
12598         * dictionary.h (mdict_iterator): Define.
12599
12600 2019-01-10  Pedro Alves  <palves@redhat.com>
12601
12602         * breakpoint.c (read_uploaded_action)
12603         (create_tracepoint_from_upload): Adjust to use
12604         gdb::unique_xmalloc_ptr.
12605         * ctf.c (ctf_write_uploaded_tp):
12606         (SET_ARRAY_FIELD): Use emplace_back.
12607         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12608         * tracefile-tfile.c (tfile_write_uploaded_tp):
12609         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12610         gdb::unique_xmalloc_ptr.
12611         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12612         at_string, cond_string, cmd_strings>: Replace char pointers
12613         with gdb::unique_xmalloc_ptr.
12614
12615 2019-01-10  Pedro Alves  <palves@redhat.com>
12616
12617         * solib-target.c (library_list_start_library): Don't xstrdup name.
12618
12619 2019-01-10  Pedro Alves  <palves@redhat.com>
12620
12621         * mdebugread.c (parse_partial_symbols): Use
12622         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12623
12624 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12625
12626         * linux-fork.c (scoped_switch_fork_info)
12627         <~scoped_switch_fork_info>: Fix incorrect variable name.
12628
12629 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12630
12631         * linux-fork.c (scoped_switch_fork_info)
12632         <scoped_switch_fork_info>: Make explicit.
12633         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12634
12635 2019-01-10  Tom Tromey  <tom@tromey.com>
12636
12637         * objfiles.h (objfile::reset_psymtabs): Update.
12638         * objfiles.c (objfile::objfile): Update.
12639         * psymtab.h (psymtab_storage::obstack): Update.
12640         (psymtab_storage::m_obstack): Use gdb::optional.
12641         (class psymtab_storage): Update comment.  Remove objfile
12642         parameter.
12643         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12644
12645 2019-01-10  Tom Tromey  <tom@tromey.com>
12646
12647         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12648         <free_psymtabs>: Now private.
12649         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12650         (allocate_psymtab): Use new method.
12651
12652 2019-01-10  Tom Tromey  <tom@tromey.com>
12653
12654         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12655         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12656         * mdebugread.c (parse_partial_symbols): Use
12657         allocate_dependencies.
12658         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12659         allocate_dependencies.
12660         (process_psymtab_comp_unit_reader)
12661         (build_type_psymtab_dependencies): Likewise.
12662         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12663
12664 2019-01-10  Tom Tromey  <tom@tromey.com>
12665
12666         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12667         PSYMBOL_SET_LANGUAGE.
12668         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12669
12670 2019-01-10  Tom Tromey  <tom@tromey.com>
12671
12672         * psymtab.h (psymtab_storage::obstack): New method.
12673         <m_obstack>: Rename from obstack; now private.
12674         * psymtab.c (psymtab_storage): Update.
12675         * dwarf2read.c (create_addrmap_from_index)
12676         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12677         Update.
12678
12679 2019-01-10  Tom Tromey  <tom@tromey.com>
12680
12681         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12682         * objfiles.h (objfile::reset_psymtabs): New method.
12683
12684 2019-01-10  Tom Tromey  <tom@tromey.com>
12685
12686         * symmisc.c (print_symbol_bcache_statistics): Update.
12687         (print_objfile_statistics): Update.
12688         * symfile.c (reread_symbols): Update.
12689         * psymtab.h (class psymtab_storage): New.
12690         * psymtab.c (psymtab_storage): New constructor.
12691         (~psymtab_storage): New destructor.
12692         (require_partial_symbols): Update.
12693         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12694         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12695         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12696         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12697         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12698         (start_psymtab_common, end_psymtab_common)
12699         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12700         (allocate_psymtab): Update.
12701         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12702         Update.
12703         (dump_psymtab_addrmap, maintenance_print_psymbols)
12704         (maintenance_check_psymtabs): Update.
12705         (class objfile_psymtabs): Move to objfiles.h.
12706         * psympriv.h (discard_psymtab): Now inline.
12707         (psymtab_discarder::psymtab_discarder): Update.
12708         (psymtab_discarder::~psymtab_discarder): Update.
12709         (ALL_OBJFILE_PSYMTABS): Rewrite.
12710         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12711         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12712         Remove fields.
12713         <partial_symtabs>: New field.
12714         (class objfile_psymtabs): Move from psymtab.h.  Update.
12715         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12716         psymbol_cache.
12717         (objfile::~objfile): Don't destroy psymbol_cache.
12718         * mdebugread.c (parse_partial_symbols): Update.
12719         * dwarf2read.c (create_addrmap_from_index)
12720         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12721         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12722         (add_partial_subprogram, dwarf2_ranges_read): Update.
12723         * dwarf-index-write.c (write_address_map)
12724         (write_one_signatured_type, recursively_write_psymbols)
12725         (class debug_names, class debug_names, write_psymtabs_to_index):
12726         Update.
12727
12728 2019-01-10  Tom Tromey  <tom@tromey.com>
12729
12730         * symtab.h (SYMBOL_SET_NAMES): Update.
12731         (symbol_set_names): Update.
12732         (MSYMBOL_SET_NAMES): Update.
12733         * symtab.c (symbol_set_names): Change argument to be an
12734         objfile_per_bfd_storage.
12735         * psymtab.c (add_psymbol_to_bcache): Update.
12736         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12737
12738 2019-01-10  Tom Tromey  <tom@tromey.com>
12739
12740         * symtab.c (create_demangled_names_hash): Change argument to be an
12741         objfile_per_bfd_storage.
12742         (symbol_set_names): Update.
12743
12744 2019-01-10  Tom Tromey  <tom@tromey.com>
12745
12746         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12747         init_psymbol_list.
12748         * psymtab.c (init_psymbol_list): Do nothing if already called.
12749         * psympriv.h (init_psymbol_list): Add comment.
12750         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12751         init_psymbol_list.
12752         * dbxread.c (dbx_symfile_read): Unconditionally call
12753         init_psymbol_list.
12754
12755 2019-01-10  Tom Tromey  <tom@tromey.com>
12756
12757         * xcoffread.c (scan_xcoff_symtab): Update.
12758         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12759         "where".
12760         * mdebugread.c (parse_partial_symbols)
12761         (handle_psymbol_enumerators): Update.
12762         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12763         * dbxread.c (read_dbx_symtab): Update.
12764         * psympriv.h (psymbol_placement): New enum.
12765         (add_psymbol_to_list): Update.
12766
12767 2019-01-10  Tom Tromey  <tom@tromey.com>
12768
12769         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12770         static_psymbols parameters.
12771         (scan_xcoff_symtab): Update.
12772         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12773         static_psymbols parameters.
12774         * psympriv.h (start_psymtab_common): Update.
12775         * mdebugread.c (parse_partial_symbols): Update.
12776         * dwarf2read.c (create_partial_symtab): Update.
12777         * dbxread.c (read_dbx_symtab): Update.
12778         (start_psymtab): Remove global_psymbols and static_psymbols
12779         parameters.
12780
12781 2019-01-10  Tom Tromey  <tom@tromey.com>
12782
12783         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12784         * psymtab.c (allocate_psymtab): Add comment.
12785         * psympriv.h (allocate_psymtab): Add comment.
12786         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12787         initializations.
12788         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12789
12790 2019-01-10  Tom Tromey  <tom@tromey.com>
12791
12792         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12793         Don't declare.
12794         * mipsread.c: Include mdebugread.h.
12795         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12796         Declare.
12797         * elfread.c: Include mdebugread.h.
12798
12799 2019-01-09  Tom Tromey  <tom@tromey.com>
12800
12801         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12802         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12803         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12804         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12805         (psym_lookup_symbol, psym_find_last_source_symtab)
12806         (psym_forget_cached_source_info, psym_print_stats)
12807         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12808         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12809         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12810         (psym_find_compunit_symtab_by_address)
12811         (maintenance_print_psymbols, maintenance_info_psymtabs)
12812         (maintenance_check_psymtabs): Use ranged for.
12813         * psymtab.h (class objfile_psymtabs): New.
12814         (require_partial_symbols): Return objfile_psymtabs.
12815         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12816
12817 2019-01-09  Tom Tromey  <tom@tromey.com>
12818
12819         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12820         (find_pc_mapped_section, list_overlays_command)
12821         (map_overlay_command, unmap_overlay_command)
12822         (simple_overlay_update): Use all_objfiles.
12823         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12824         * printcmd.c (info_symbol_command): Use all_objfiles.
12825         * objfiles.h (ALL_OBJSECTIONS): Remove.
12826         * maint.c (maintenance_translate_address): Use all_objfiles.
12827         * gcore.c (gcore_create_callback): Use all_objfiles.
12828         (objfile_find_memory_regions): Likewise.
12829
12830 2019-01-09  Tom Tromey  <tom@tromey.com>
12831
12832         * symtab.c (find_line_symtab, info_sources_command)
12833         (make_source_files_completion_list): Use objfile_compunits.
12834         * source.c (select_source_symtab): Use objfile_compunits.
12835         * objfiles.h (struct objfile): Update comment.
12836         (ALL_OBJFILES): Remove.
12837         (ALL_FILETABS): Remove.
12838         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12839         objfile_compunits.
12840
12841 2019-01-09  Tom Tromey  <tom@tromey.com>
12842
12843         * symmisc.c (print_objfile_statistics, dump_objfile)
12844         (maintenance_print_symbols): Use compunit_filetabs.
12845         * source.c (forget_cached_source_info_for_objfile): Use
12846         compunit_filetabs.
12847         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12848         (ALL_FILETABS): Use compunit_filetabs.
12849         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12850         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12851
12852 2019-01-09  Tom Tromey  <tom@tromey.com>
12853
12854         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12855         (compunit_filetabs): New.
12856         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12857         compunit_filetabs.
12858         (info_sources_command, make_source_files_completion_list): Remove
12859         declaration.
12860         * symmisc.c (print_objfile_statistics, dump_objfile)
12861         (maintenance_print_symbols): Remove declaration.
12862         (maintenance_info_symtabs): Use compunit_filetabs.
12863         (maintenance_info_line_tables): Likewise.
12864         * source.c (select_source_symtab): Change local variable name.
12865         (forget_cached_source_info_for_objfile): Remove declaration.
12866         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12867         * objfiles.c (objfile_relocate1): Remove declaration.
12868         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12869         declaration.
12870         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12871         * coffread.c (coff_symtab_read): Remove declaration.
12872         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12873         compunit_filetabs.
12874
12875 2019-01-09  Tom Tromey  <tom@tromey.com>
12876
12877         * symtab.c (lookup_objfile_from_block)
12878         (find_pc_sect_compunit_symtab, search_symbols)
12879         (default_collect_symbol_completion_matches_break_on): Use
12880         objfile_compunits.
12881         * objfiles.h (ALL_COMPUNITS): Remove.
12882         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12883         * cp-support.c (add_symbol_overload_list_qualified): Use
12884         objfile_compunits.
12885         * ada-lang.c (ada_collect_symbol_completion_matches)
12886         (ada_add_global_exceptions): Use objfile_compunits.
12887
12888 2019-01-09  Tom Tromey  <tom@tromey.com>
12889
12890         * source.c (select_source_symtab)
12891         (forget_cached_source_info_for_objfile): Remove declaration.
12892         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12893         declaration.
12894         * maint.c (count_symtabs_and_blocks): Remove declaration.
12895         * cp-support.c (add_symbol_overload_list_qualified): Remove
12896         declaration.
12897         * coffread.c (coff_symtab_read): Remove declaration.
12898         * symtab.c (lookup_symbol_in_objfile_symtabs)
12899         (basic_lookup_transparent_type_1): Use objfile_compunits.
12900         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12901         (info_sources_command, search_symbols)
12902         (default_collect_symbol_completion_matches_break_on)
12903         (make_source_files_completion_list): Remove declaration.
12904         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12905         (ada_collect_symbol_completion_matches)
12906         (ada_add_global_exceptions): Remove declaration.
12907         * linespec.c (iterate_over_all_matching_symtabs): Use
12908         objfile_compunits.
12909         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12910         (class objfile_compunits): New.
12911         (ALL_COMPUNITS): Use objfile_compunits.
12912         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12913         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12914         objfile_compunits.
12915         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12916
12917 2019-01-09  Tom Tromey  <tom@tromey.com>
12918
12919         * symtab.c (search_symbols)
12920         (default_collect_symbol_completion_matches_break_on): Use
12921         objfile_msymbols.
12922         * ada-lang.c (ada_lookup_simple_minsym)
12923         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12924         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12925         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12926         objfile_msymbols.
12927         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12928         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12929         * objc-lang.c (find_methods): Use objfile_msymbols.
12930         (info_selectors_command, info_classes_command): Likewise.
12931         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12932         * objfiles.h (class objfile_msymbols): New.
12933         (ALL_OBJFILE_MSYMBOLS): Remove.
12934         (ALL_MSYMBOLS): Remove.
12935
12936 2019-01-09  Tom Tromey  <tom@tromey.com>
12937
12938         * common/next-iterator.h (next_adapter): Add Iterator template
12939         parameter.
12940         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12941         (class all_objfiles_safe): New.
12942         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12943         * objfiles.c (put_objfile_before): Update comment.
12944         (add_separate_debug_objfile): Likewise.
12945         (free_all_objfiles): Use all_objfiles_safe.
12946         (objfile_purge_solibs): Likewise.
12947
12948 2019-01-09  Tom Tromey  <tom@tromey.com>
12949
12950         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12951         (expand_symtab_containing_pc, lookup_static_symbol)
12952         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12953         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12954         all_objfiles.
12955         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12956         * breakpoint.c (create_overlay_event_breakpoint)
12957         (create_longjmp_master_breakpoint)
12958         (create_std_terminate_master_breakpoint)
12959         (create_exception_master_breakpoint): Use all_objfiles.
12960         * linux-thread-db.c (try_thread_db_load_from_pdir)
12961         (has_libpthread): Use all_objfiles.
12962         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12963         * linespec.c (iterate_over_all_matching_symtabs)
12964         (search_minsyms_for_name): Use all_objfiles.
12965         * maint.c (maintenance_info_sections): Use all_objfiles.
12966         * main.c (captured_main_1): Use all_objfiles.
12967         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12968         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12969         * guile/scm-pretty-print.c
12970         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12971         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12972         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12973         (maintenance_print_msymbols): Use all_objfiles.
12974         * source.c (select_source_symtab): Use all_objfiles.
12975         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12976         * symfile.c (remove_symbol_file_command)
12977         (expand_symtabs_matching, map_symbol_filenames): Use
12978         all_objfiles.
12979         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12980         all_objfiles.
12981         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12982         * objc-lang.c (find_methods): Use all_objfiles.
12983         * objfiles.c (have_partial_symbols, have_full_symbols)
12984         (have_minimal_symbols, qsort_cmp)
12985         (default_iterate_over_objfiles_in_search_order): Use
12986         all_objfiles.
12987         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12988         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12989         (maintenance_check_psymtabs): Use all_objfiles.
12990         (ALL_PSYMTABS): Remove.
12991         * compile/compile-object-run.c (do_module_cleanup): Use
12992         all_objfiles.
12993         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12994         * cp-support.c (add_symbol_overload_list_qualified): Use
12995         all_objfiles.
12996         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12997         Use all_objfiles.
12998         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12999         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13000         all_objfiles.
13001         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13002         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13003         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13004         Uses all_objfiles.
13005         * solib.c (solib_read_symbols): Use all_objfiles
13006
13007 2019-01-09  Tom Tromey  <tom@tromey.com>
13008
13009         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13010         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13011         all_objfiles.
13012         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13013         * symmisc.c (print_symbol_bcache_statistics)
13014         (print_objfile_statistics, maintenance_print_objfiles)
13015         (maintenance_info_symtabs, maintenance_check_symtabs)
13016         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13017         all_objfiles.
13018         * source.c (forget_cached_source_info): Use all_objfiles.
13019         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13020         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13021         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13022         * objfiles.c (update_section_map): Use all_objfiles.
13023         (shared_objfile_contains_address_p): Likewise.
13024         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13025         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13026
13027 2019-01-09  Tom Tromey  <tom@tromey.com>
13028
13029         * common/next-iterator.h: New file.
13030         * objfiles.h (class all_objfiles): New.
13031         (struct objfile_iterator): New.
13032
13033 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13034
13035         * NEWS: Move the description of the changed "frame", "select-frame",
13036          and "info frame" commands to the Changed commands section.
13037
13038 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13039
13040         * gdbtypes.c (check_stub_method_group): Remove handling of old
13041         mangling schemes.
13042         * linespec.c (find_methods): Likewise.
13043         * stabsread.c (read_member_functions): Likewise.
13044         * valops.c (search_struct_method): Likewise.
13045         (value_struct_elt_for_reference): Likewise.
13046         * NEWS: Mention this change.
13047
13048 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13049
13050         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13051         print_source_lines.
13052         * source.c (print_source_lines_base): Update line number check.
13053         (print_source_lines): New function.
13054         (source_lines_range::source_lines_range): New function.
13055         * source.h (class source_lines_range): New class.
13056         (print_source_lines): New declaration.
13057
13058 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13059
13060         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13061
13062 2019-01-08  Tom Tromey  <tom@tromey.com>
13063             Simon Marchi  <simon.marchi@ericsson.com>
13064
13065         PR gdb/24060
13066         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13067         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13068         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13069         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13070         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13071         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13072
13073 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13074
13075         * source.c (select_source_symtab): Move header comment to
13076         declaration in source.h.
13077         (forget_cached_source_info_for_objfile): Likewise.
13078         (forget_cached_source_info): Likewise.
13079         (identify_source_line): Likewise.
13080         * source.h (identify_source_line): Move declaration from symtab.h
13081         and add comment from source.c
13082         (print_source_lines): Likewise.
13083         (forget_cached_source_info_for_objfile): Likewise.
13084         (forget_cached_source_info): Likewise.
13085         (select_source_symtab): Likewise.
13086         (enum print_source_lines_flag): Move definition from symtab.h.
13087         * symtab.h (identify_source_line): Move declaration to source.h.
13088         (print_source_lines): Likewise.
13089         (forget_cached_source_info_for_objfile): Likewise.
13090         (forget_cached_source_info): Likewise.
13091         (select_source_symtab): Likewise.
13092         (enum print_source_lines_flag): Move definition to source.h.
13093         * tui/tui-hooks.c: Add 'source.h' include.
13094
13095 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13096
13097         * source.c (print_source_lines_base): Handle requests to print
13098         reverse line number sequences, and guard against empty lines
13099         string.
13100
13101 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13102
13103         * source.c (print_source_lines_base): Fix skip of '\r' if next
13104         character is '\n'.
13105
13106 2019-01-06  Tom Tromey  <tom@tromey.com>
13107
13108         * c-exp.y (struct c_parse_state) <macro_original_text,
13109         expansion_obstack>: New member.
13110         (macro_original_text, expansion_obstack): Remove globals.
13111         (scan_macro_expansion, scanning_macro_expansion)
13112         (finished_macro_expansion): Update.
13113         (scan_macro_cleanup): Remove.
13114         (yylex, c_parse): Update.
13115
13116 2019-01-06  Tom Tromey  <tom@tromey.com>
13117
13118         * c-exp.y (struct c_parse_state) <strings>: New member.
13119         (operator_stoken): Update.
13120
13121 2019-01-06  Tom Tromey  <tom@tromey.com>
13122
13123         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13124         (union type_stack_elt) <typelist_val>: Now a pointer to
13125         std::vector.
13126         (type_stack_cleanup): Don't declare.
13127         (push_typelist): Update.
13128         * parse.c (pop_typelist): Return a std::vector.
13129         (push_typelist): Take a std::vector.
13130         (follow_types): Update.  Do not free args.
13131         (type_stack_cleanup): Remove.
13132         * c-exp.y (struct c_parse_state): New.
13133         (cpstate): New global.
13134         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13135         (nonempty_typelist): Update.
13136         (func_mod): Create a new vector.
13137         (c_parse): Create a c_parse_state.
13138         (check_parameter_typelist): Do not delete params.
13139         (function_method): Update.  Do not delete type_list.
13140
13141 2019-01-06  Tom Tromey  <tom@tromey.com>
13142
13143         PR gdb/28155:
13144         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13145         check_typedef.
13146         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13147         (print_return_value): Likewise.
13148
13149 2019-01-05  Tom Tromey  <tom@tromey.com>
13150
13151         * contrib/cleanup_check.py: Remove.
13152         * contrib/gcc-with-excheck: Remove.
13153         * contrib/exsummary.py: Remove.
13154         * contrib/excheck.py: Remove.
13155
13156 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13157
13158         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13159         NULL. Initialize tpprev to NULL instead of assigning it
13160         to NULL on the next statement.
13161         * windows-nat.c (windows_delete_thread): Remove check for
13162         main_thread_id before printing thread exit notifications.
13163         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13164         Remove thread ID check against main_thread_id.
13165         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13166         windows_delete_thread.
13167         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13168
13169 2019-01-04  Tom Tromey  <tom@tromey.com>
13170
13171         * compile/compile.c (_initialize_compile): Use upper case for
13172         metasyntactic variables.
13173         * symmisc.c (_initialize_symmisc): Use upper case for
13174         metasyntactic variables.
13175         * psymtab.c (_initialize_psymtab): Use upper case for
13176         metasyntactic variables.
13177         * demangle.c (demangle_command): Use upper case for metasyntactic
13178         variables.
13179         (_initialize_demangler): Likewise.
13180         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13181         variables.
13182
13183 2019-01-03  Tom Tromey  <tom@tromey.com>
13184
13185         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13186
13187 2019-01-03  Tom Tromey  <tom@tromey.com>
13188
13189         * python/py-symtab.c (salpy_str): Update.
13190         (struct salpy_sal_object) <symtab>: Now a PyObject.
13191         (salpy_dealloc): Update.
13192         (del_objfile_sal): Use gdbpy_ref.
13193
13194 2019-01-03  Tom Tromey  <tom@tromey.com>
13195
13196         * python/py-type.c (convert_field): Use new_reference.  Return
13197         gdbpy_ref.
13198         (make_fielditem): Return gdbpy_ref.
13199         (typy_fields): Update.
13200         (typy_getitem): Update.
13201         (field_name): Return gdbpy_ref.  Use new_reference.
13202         (typy_iterator_iternext): Update.
13203
13204 2019-01-03  Tom Tromey  <tom@tromey.com>
13205
13206         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13207
13208 2019-01-03  Tom Tromey  <tom@tromey.com>
13209
13210         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13211         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13212         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13213         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13214         (pspy_set_type_printers): Likewise.
13215         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13216         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13217         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13218         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13219         (objfpy_set_type_printers): Likewise.
13220
13221 2019-01-03  Tom Tromey  <tom@tromey.com>
13222
13223         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13224         (gdbpy_print_stack): Use gdbpy_err_fetch.
13225         * python/python-internal.h (class gdbpy_err_fetch): New class.
13226         (class gdbpy_enter) <m_error_type, m_error_value,
13227         m_error_traceback>: Remove.
13228         <m_error>: New member.
13229         (gdbpy_exception_to_string): Don't declare.
13230         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13231         * python/py-value.c (convert_value_from_python): Use
13232         gdbpy_err_fetch.
13233         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13234         gdbpy_exception_to_string.
13235         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13236         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13237         gdbpy_err_fetch.
13238
13239 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13240
13241         * linux-nat.c (delete_lwp_cleanup): Delete.
13242         (struct lwp_deleter): New struct.
13243         (lwp_info_up): New typedef.
13244         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13245         lwp_info_up.
13246
13247 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13248
13249         * linux-fork.c (class scoped_switch_fork_info): New class.
13250         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13251
13252 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13253
13254         * valops.c (find_overload_match): Remove use of null_cleanup, and
13255         calls to do_cleanups.
13256
13257 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13258
13259         * compile/compile-cplus-types.c
13260         (compile_cplus_instance::decl_name): Handle changes to
13261         cp_func_name.
13262         * cp-support.c (cp_func_name): Update header comment, update
13263         return type.
13264         * cp-support.h (cp_func_name): Update return type in declaration.
13265         * valops.c (find_overload_match): Move temp_func local to top
13266         level of function and change its type.  Use temp_func to hold and
13267         delete temporary string obtained from cp_func_name.
13268
13269 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13270
13271         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13272         gdb::char_vector, remove cleanup, and update uses of `msg`.
13273
13274 2019-01-03  Jim Wilson  <jimw@sifive.com>
13275
13276         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13277
13278 2019-01-02  Tom Tromey  <tom@tromey.com>
13279
13280         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13281         (tdesc_parse_xml): Remove cleanups.
13282         * target-descriptions.h (make_cleanup_free_target_description):
13283         Don't declare.
13284         (target_desc_deleter): New struct.
13285         (target_desc_up): New typedef.
13286         * target-descriptions.c (target_desc_deleter::operator()): Rename
13287         from free_target_description.
13288         (make_cleanup_free_target_description): Remove.
13289
13290 2019-01-02  Tom Tromey  <tom@tromey.com>
13291
13292         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13293         constructor, destructor.
13294         (linespec_parser): Remove typedef.
13295         (~linespec_parser): Rename from linespec_parser_delete.
13296         (linespec_lex_to_end, linespec_complete_label)
13297         (linespec_complete): Update.
13298         (decode_line_full): Remove cleanups.
13299         (decode_line_1): Update.
13300
13301 2019-01-02  Tom Tromey  <tom@tromey.com>
13302
13303         * python/python-internal.h (inferior_to_inferior_object): Change
13304         return type.
13305         * python/py-exitedevent.c (create_exited_event_object): Update.
13306         * python/py-inferior.c (inferior_to_inferior_object): Return
13307         gdbpy_ref.
13308         (python_new_inferior, python_inferior_deleted)
13309         (thread_to_thread_object, delete_thread_object)
13310         (build_inferior_list, gdbpy_selected_inferior): Update.
13311         * python/py-infthread.c (create_thread_object): Update.  Also fail
13312         if inferior_to_inferior_object fails.
13313
13314 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13315
13316         * inferior.h (class inferior) <displaced_step_state>: New field.
13317         * infrun.h (struct displaced_step_state): Move here from
13318         infrun.c.  Initialize fields, add constructor.
13319         <inf>: Remove field.
13320         <reset>: New method.
13321         * infrun.c (struct displaced_step_inferior_state): Move to
13322         infrun.h.
13323         (displaced_step_inferior_states): Remove.
13324         (get_displaced_stepping_state): Adust.
13325         (displaced_step_in_progress_any_inferior): Adjust.
13326         (displaced_step_in_progress_thread): Adjust.
13327         (displaced_step_in_progress): Adjust.
13328         (add_displaced_stepping_state): Remove.
13329         (get_displaced_step_closure_by_addr): Adjust.
13330         (remove_displaced_stepping_state): Remove.
13331         (infrun_inferior_exit): Call displaced_step_state.reset.
13332         (use_displaced_stepping): Don't check for NULL.
13333         (displaced_step_prepare_throw): Call
13334         get_displaced_stepping_state.
13335         (displaced_step_fixup): Don't check for NULL.
13336         (prepare_for_detach): Don't check for NULL.
13337
13338 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13339
13340         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13341          in case of call that did not complete.
13342
13343 2019-01-02  Andrey Utkin  <autkin@undo.io>
13344
13345         * symfile.c (find_separate_debug_file): Fix search of debug files for
13346         remote debuggee.
13347
13348 2019-01-02  Tom Tromey  <tom@tromey.com>
13349
13350         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13351         indentation.
13352         * python/py-frame.c (frapy_older): Remove cast.
13353         (frapy_newer): Likewise.
13354         * python/py-breakpoint.c (local_setattro): Remove cast.
13355         * python/py-arch.c (archpy_name): Remove local variable.
13356         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13357
13358 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13359
13360         * unittests/basic_string_view/element_access/char/empty.cc:
13361         Fix year range in copyright header.
13362
13363 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13364
13365         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13366         Delete.
13367         <operator==>: Update with for removed field.
13368         <hash>: Likewise.
13369         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13370         <isa_features>: ...this.
13371         <abi_features>: New field.
13372         (riscv_isa_flen): Update comment.
13373         (riscv_abi_xlen): New declaration.
13374         (riscv_abi_flen): New declaration.
13375         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13376         isa_features.
13377         (riscv_abi_xlen): New function.
13378         (riscv_isa_flen): Update to get answer from isa_features.
13379         (riscv_abi_flen): New function.
13380         (riscv_has_fp_abi): Update to get answer from abi_features.
13381         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13382         xlen and flen.
13383         (riscv_call_info) <xlen, flen>: Update comment.
13384         (riscv_call_arg_struct): Remove invalid assertions
13385         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13386         is removed.
13387         (riscv_gdbarch_init): Gather isa features and abi features
13388         separately, ensure both match on the gdbarch when reusing an old
13389         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13390         a target with 64-bit float hardware.
13391
13392 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13393
13394         * source.c (search_command_helper): Stop reverse search
13395         when line 1 has been searched.
13396
13397 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13398
13399         * record-full.c (record_full_base_target::close): Rewrite
13400         record_full_core_buf_list free logic.
13401
13402 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13403
13404         * break-catch-syscall.c (print_one_catch_syscall): xfree
13405         the last text.
13406
13407 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13408
13409         * top.c (print_gdb_version): Update Copyright year in version
13410         message.
13411
13412 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13413
13414         Update copyright year range in all GDB files.
13415
13416 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13417
13418         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13419
13420 For older changes see ChangeLog-2018.
13421 \f
13422 Local Variables:
13423 mode: change-log
13424 left-margin: 8
13425 fill-column: 74
13426 version-control: never
13427 coding: utf-8
13428 End:
13429