gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (struct tui_win_info): Make constructor
   4         protected.  Make destructor virtual.  Add initializers.
   5         (tui_source_window, tui_data_window, tui_cmd_window): New
   6         classes.
   7         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
   8         constructor.  Add "type" parameter.
   9         (tui_source_window, tui_data_window, tui_cmd_window): New
  10         constructors.
  11         (tui_alloc_win_info): Instantiate the appropriate subclass.
  12
  13 2019-06-25  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-win.c (tui_resize_all): Use delete.
  16         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
  17         destructor.
  18         (tui_free_window): Don't declare.
  19         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
  20         Update.
  21
  22 2019-06-25  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-data.h (struct tui_win_info): Add constructor.
  25         * tui/tui-data.c (tui_alloc_win_info): Use new.
  26         (tui_free_window): Use delete.
  27
  28 2019-06-22  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
  31         declare.
  32         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
  33
  34 2019-06-22  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
  37         declare.
  38         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
  39
  40 2019-06-22  Tom de Vries  <tdevries@suse.de>
  41
  42         * dwarf2read.c (create_addrmap_from_aranges)
  43         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
  44         instead of '%zu'.
  45
  46 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
  47
  48         * dwarf2read.h (dwarf2_section_info_def): Remove.
  49         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
  50         * dwarf2read.c (struct dwo_sections) <types>: Change type to
  51         std::vector<dwarf2_section_info>.
  52         (struct dwo_file) <~dwo_file>: Remove.
  53         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
  54         types field.
  55         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
  56         (dwarf2_read_debug_names): Likewise.
  57         (create_debug_types_hash_table): Change parameter type to
  58         array_view, adjust code accordingly.
  59         (dwarf2_locate_dwo_sections): Adjust to std::vector.
  60         (partial_die_info::fixup): Likewise.
  61         (determine_prefix): Likewise.
  62         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
  63
  64 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  65
  66         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
  67         gdb_bfd_ref_ptr.
  68         <~dwo_file>: Remove call to gdb_bfd_unref.
  69         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
  70         gdb_bfd_ref_ptr::get.
  71
  72 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  73
  74         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
  75         type to htab_up.
  76         * dwarf2read.c (struct dwo_file): Initialize fields.
  77         <~dwo_file>: New.
  78         (free_dwo_file): Remove, move content to ~dwo_file.
  79         (struct dwo_file_deleter): Remove.
  80         (dwo_file_up>: Remove custom deleter.
  81         (free_dwo_files): Remove.
  82         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
  83         dwo_files.
  84         (process_skeletonless_type_units): Call unique_ptr::get.
  85         (allocate_dwo_file_hash_table): Add deleter to created hash
  86         table.  Change return type to htab_up.
  87         (lookup_dwo_file_slot): Don't memset dwo_file, call
  88         unique_ptr::get.
  89         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
  90         (create_dwo_unit_in_dwp_v2): Likewise.
  91         (open_and_init_dwo_file): Likewise.
  92         (free_dwo_file_from_slot): Remove.
  93
  94 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  95
  96         * dwarf2read.h (struct dwarf2_section_info) <readin,
  97         is_virtual>: Change type to bool.
  98         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
  99         true instead of 1.
 100
 101 2019-06-19  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-data.h (tui_init_content_element): Don't declare.
 104
 105 2019-06-19  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-data.h (tui_init_win_info): Don't declare.
 108
 109 2019-06-19  Tom de Vries  <tdevries@suse.de>
 110
 111         * dwarf2read.h (abstract_to_concrete): Change type to
 112         std::unordered_map<sect_offset, std::vector<sect_offset>,
 113         gdb::hash_enum<sect_offset>>.
 114
 115 2019-06-19  Tom Tromey  <tromey@adacore.com>
 116
 117         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 118         EVAL_AVOID_SIDE_EFFECTS specially.
 119
 120 2019-06-19  Tom Tromey  <tromey@adacore.com>
 121
 122         * source-cache.c (highlighter): New global.
 123         (source_cache::get_source_lines): Create a highlighter on demand.
 124
 125 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 126
 127         * defs.h (deprecated_interactive_hook): Delete declaration.
 128         * interps.c (clear_interpreter_hooks): Remove use of
 129         deprecated_interactive_hook.
 130         * top.c (deprecated_interactive_hook): Delete definition.
 131         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 132
 133 2019-06-18  Tom de Vries  <tdevries@suse.de>
 134
 135         PR gdb/24515
 136         * dwarf2read.h (abstract_to_concrete): Change type from
 137         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 138         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 139         * dwarf2read.c (read_variable): Update.
 140         (dwarf2_fetch_die_loc_sect_off): Update.
 141
 142 2019-06-17  Tom de Vries  <tdevries@suse.de>
 143
 144         PR gdb/24617
 145         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 146         accessing parent[parent_len - 1].
 147
 148 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 149
 150         PR gdb/24364
 151         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 152         call dtrace_process_dof with NULL dof.
 153
 154 2019-06-16  Tom de Vries  <tdevries@suse.de>
 155
 156         PR gdb/24445
 157         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 158
 159 2019-06-16  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 162         (make_all_visible): Use address of member.
 163
 164 2019-06-16  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 167         (tui_free_window, free_content, free_content_elements): Remove
 168         unnecessary cast.
 169         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 170         cast.
 171         * tui/tui-regs.c (tui_show_register_group)
 172         (tui_display_registers_from, tui_display_reg_element_at_line):
 173         Remove unnecessary cast.
 174
 175 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 176
 177         * linux-nat.c (normal_mask): Delete.
 178         (_initialize_linux_nat): Don't initialise normal_mask.
 179
 180 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 181
 182         PR gdb/24445
 183         * dwarf-index-write.h (write_psymtabs_to_index): Add
 184         dwz_basename parameter.
 185         * dwarf-index-write.c (write_gdbindex): Move file writing to
 186         write_gdbindex_1.  Change return type void.
 187         (assert_file_size): Move up, remove filename parameter.
 188         (write_gdbindex_1): New function.
 189         (write_debug_names): Change return type to void, call
 190         assert_file_size.
 191         (struct index_wip_file): New struct.
 192         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 193         file logic to index_wip_file.  Write index for dwz file if
 194         needed.
 195         (save_gdb_index_command): Pass basename of dwz file, if present.
 196         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 197         build-id of dwz file, if present.
 198         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 199         (dwarf2_get_dwz_file): Likewise.
 200         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 201         (dwarf2_get_dwz_file): Likewise.
 202
 203 2019-06-16  Tom Tromey  <tom@tromey.com>
 204
 205         * coffread.c (process_coff_symbol): Use xstrdup.
 206         * value.c (create_internalvar): Use xstrdup.
 207
 208 2019-06-16  Tom Tromey  <tom@tromey.com>
 209
 210         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 211         * breakpoint.c (stopin_command, stopat_command)
 212         (until_break_command, decode_location_default): Remove unnecessary
 213         cast.
 214         * utils.c (subset_compare): Remove unnecessary cast.
 215         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 216         cast.
 217         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 218         cast.
 219         * infcmd.c (path_command): Remove unnecessary cast.
 220         * coffread.c (decode_type): Remove unnecessary cast.
 221         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 222         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 223         * tui/tui-stack.c (tui_show_locator_content)
 224         (tui_show_frame_info): Remove unnecessary cast.
 225         * tui/tui-win.c (tui_scroll_forward_command)
 226         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 227         (parse_scrolling_args): Remove unnecessary cast.
 228         * tui/tui-data.c (init_win_info, tui_del_window)
 229         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 230         (free_content_elements): Remove unnecessary cast.
 231         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 232         unnecessary cast.
 233         * tui/tui-source.c (tui_set_source_content)
 234         (tui_vertical_source_scroll): Remove unnecessary cast.
 235         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 236         cast.
 237         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 238         * tui/tui-regs.c (tui_display_registers_from)
 239         (tui_display_register): Remove unnecessary cast.
 240         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 241         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 242         (make_visible): Remove unnecessary cast.
 243         * tui/tui-winsource.c (tui_erase_source_content)
 244         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 245         unnecessary cast.
 246         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 247         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 248         * stabsread.c (read_type, read_array_type, read_range_type):
 249         Remove unnecessary cast.
 250         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 251         (parse_symbol, parse_type, upgrade_type, parse_external)
 252         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 253         unnecessary cast.
 254         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 255
 256 2019-06-16  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-data.c (tui_alloc_generic_win_info)
 259         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 260         checks.
 261
 262 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 263             Andrew Burgess  <andrew.burgess@embecosm.com>
 264
 265         * f-typeprint.c (f_print_type): Don't return early for not
 266         associated or not allocated types.
 267         (f_type_print_varspec_suffix): Add print_rank parameter and print
 268         ranks of array types in case they dangling.
 269         (f_type_print_base): Add print_rank parameter.
 270
 271 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 272
 273         * NEWS: Mention new MI commands.
 274         * break-catch-throw.c (enum exception_event_kind): Move to
 275         breakpoint.h.
 276         (print_mention_exception_catchpoint): Output text as a single
 277         message.
 278         (catch_exception_command_1): Rename to...
 279         (catch_exception_event): ...this, make non-static, update header
 280         command, and change some parameter types.
 281         (catch_catch_command): Update for changes to
 282         catch_exception_command_1.
 283         (catch_throw_command): Likewise.
 284         (catch_rethrow_command): Likewise.
 285         * breakpoint.c (enum exception_event_kind): Delete.
 286         * breakpoint.h (enum exception_event_kind): Moved here from
 287         break-catch-throw.c.
 288         (catch_exception_event): Declare.
 289         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 290         (mi_cmd_catch_throw): New function.
 291         (mi_cmd_catch_rethrow): New function.
 292         (mi_cmd_catch_catch): New function.
 293         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 294         'catch-catch' entries.
 295         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 296         (mi_cmd_catch_rethrow): Declare.
 297         (mi_cmd_catch_catch): Declare.
 298
 299 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 300
 301         * annotate.c (annotate_source_line): Change return type to void,
 302         update implementation to match.
 303         * annotate.h (annotate_source_line): Change return type to void,
 304         update header comment.
 305         * stack.c (print_frame_info): Don't change what frame information
 306         is printed based on whether annotations are on or not.
 307
 308 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 309
 310         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 311         (annotate_source): Make static.
 312         (annotate_source_line): Moved from source.c and renamed from
 313         identify_source_line.  Update the return type.
 314         * annotate.h (annotate_source): Delete declaration.
 315         (annotate_source_line): Declaration moved from source.h, and
 316         renamed from identify_source_line.  Return type updated.
 317         * source.c (identify_source_line): Moved to annotate.c and renamed
 318         to annotate_source_line.
 319         (info_line_command): Remove check of annotation_level.
 320         * source.h (identify_source_line): Move declaration to annotate.h
 321         and rename to annotate_source_line.
 322         * stack.c: Add 'annotate.h' include.
 323         (print_frame_info): Remove check of annotation_level before
 324         calling annotate_source_line.
 325
 326 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 327
 328         * source-cache.c (source_cache::get_plain_source_lines): Use
 329         open_source_file_with_line_charpos instead of just
 330         open_source_file, remove call to find_source_lines.
 331         (source_cache::get_source_lines): Likewise.
 332         * source.c (find_source_lines): Make static.
 333         (get_filename_and_charpos): Renamed into...
 334         (open_source_file_with_line_charpos): ..this along with changes to
 335         return a scoped_fd, and some other minor clean ups.
 336         (identify_source_line): Use open_source_file_with_line_charpos.
 337         (search_command_helper): Use open_source_file_with_line_charpos
 338         instead of just open_source_file, remove call to
 339         find_source_lines.
 340         * source.h (open_source_file_with_line_charpos): Declare new
 341         function.
 342         (find_source_lines): Delete declaration.
 343
 344 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 345
 346         * source.c (get_filename_and_charpos): Remove fullname
 347         parameter.
 348         (identify_source_line): Update call to get_filename_and_charpos.
 349
 350 2019-06-14  Tom Tromey  <tromey@adacore.com>
 351
 352         PR gdb/24502:
 353         * ui-style.h (skip_ansi_escape): Update comment.
 354         * ui-file.h (class no_terminal_escape_file): New class.
 355         * ui-file.c (no_terminal_escape_file::write)
 356         (no_terminal_escape_file::puts): New methods.
 357         * cli/cli-logging.c (handle_redirections): Use
 358         no_terminal_escape_file.
 359
 360 2019-06-14  Tom Tromey  <tromey@adacore.com>
 361
 362         * NEWS: Move convenience variable news above Python news.
 363
 364 2019-06-14  Tom Tromey  <tom@tromey.com>
 365
 366         * gnulib: Move directory to top-level.
 367         * configure.ac: Don't configure gnulib.
 368         * configure: Rebuild.
 369         * common/common-defs.h: Use new path to gnulib.
 370         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 371         (GNULIB_H): Remove.
 372         (INCGNU): Look in new gnulib location.
 373         (HFILES_NO_SRCDIR): Remove gnulib files.
 374         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 375         (generated_files): Remove GNULIB_H.
 376         ($(LIBGNU), all-lib): Remove targets.
 377         (distclean): Don't mention GNULIB_BUILDDIR.
 378         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 379
 380 2019-06-14  Tom Tromey  <tromey@adacore.com>
 381
 382         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 383         Warn if symbol file does not provide any symbols.
 384
 385 2019-06-14  Tom Tromey  <tromey@adacore.com>
 386
 387         * source.c (find_and_open_source): Respect basenames_may_differ.
 388
 389 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 390
 391         * annotate.c (annotate_breakpoints_invalid): Make use of
 392         scoped_restore_terminal_state.
 393         (annotate_frames_invalid): Likewise.
 394
 395 2019-06-14  Tom Tromey  <tromey@adacore.com>
 396
 397         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 398         allow assignment to an internalvar.
 399
 400 2019-06-14  Tom Tromey  <tromey@adacore.com>
 401
 402         * ada-lex.l: Allow "_" in attribute names.
 403
 404 2019-06-14  Tom Tromey  <tromey@adacore.com>
 405
 406         PR gdb/24653:
 407         * regcache.c (registers_changed): Don't call alloca.
 408         * top.c (execute_command): Don't call alloca.
 409
 410 2019-06-13  Pedro Alves  <palves@redhat.com>
 411
 412         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 413         'expression'.  When parsing an expression, error out if there's
 414         junk after "unlimited".
 415         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 416         (do_set_command): Adjust calls to is_unlimited_literal.
 417
 418 2019-06-13  Pedro Alves  <palves@redhat.com>
 419
 420         * compile/compile.c (make_compile_options_def_group): Add braces
 421         around array_view initializer.
 422         * thread.c (make_thread_apply_all_options_def_group)
 423         (make_thread_apply_all_options_def_group): Likewise.
 424
 425 2019-06-13  Pedro Alves  <palves@redhat.com>
 426
 427         * NEWS (New commands): Mention "maint test-options
 428         require-delimiter", "maint test-options unknown-is-error", "maint
 429         test-options unknown-is-operand" and "maint show
 430         test-options-completion-result".
 431         (New command options, command completion): New section.
 432         (Completion improvements): New section.
 433         Mention that you can abbreviate "unlimited".
 434
 435 2019-06-13  Pedro Alves  <palves@redhat.com>
 436
 437         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 438         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 439         * unittests/cli-utils-selftests.c (test_parse_flags)
 440         (test_parse_flags_qcs): Delete.
 441         (test_cli_utils): Don't call deleted functions.
 442
 443 2019-06-13  Pedro Alves  <palves@redhat.com>
 444
 445         * thread.c: Include "cli/cli-option.h".
 446         (tp_array_compar_ascending): Global.
 447         (tp_array_compar): Delete function.
 448         (tp_array_compar_ascending, tp_array_compar_descending): New
 449         functions.
 450         (ascending_option_def, qcs_flag_option_def)
 451         (thr_qcs_flags_option_defs)
 452         (make_thread_apply_all_options_def_group)
 453         (make_thread_apply_options_def_group): New.
 454         (thread_apply_all_command): Use gdb::option::process_options.
 455         (thread_apply_command_completer)
 456         (thread_apply_all_command_completer): New.
 457         (thread_apply_command): Use gdb::option::process_options.
 458         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 459         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 460         to generate help text of "thread apply".  Adjust "taas"'s help.
 461         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 462         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 463
 464 2019-06-13  Pedro Alves  <palves@redhat.com>
 465
 466         * thread.c (thread_apply_command): Check for invalid TID with
 467         isdigit instead of !isalpha.
 468
 469 2019-06-13  Pedro Alves  <palves@redhat.com>
 470
 471         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 472         (validate_flags_qcs): New.
 473         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 474         (validate_flags_qcs): Declare.
 475         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 476         (make_frame_apply_options_def_group): New.
 477         (frame_apply_command_count): Process options with
 478         gdb::option::process_options.
 479         (frame_apply_completer): New.
 480         (frame_apply_level_completer, frame_apply_all_completer)
 481         (frame_apply_completer): New.
 482         (_initialize_stack): Update help of "frame apply", "frame apply
 483         level", "frame apply all" and "faas" to mention supported options
 484         and install command completers.
 485         * stack.h (frame_apply_all_completer): Declare.
 486         * thread.c: Include "stack.h".
 487         (tfaas_command): Add "--".
 488         (_initialize_thread): Update help "tfaas" to mention supported
 489         options and install command completer.
 490
 491 2019-06-13  Pedro Alves  <palves@redhat.com>
 492
 493         * completer.c (complete_nested_command_line): New.
 494         (gdb_completion_word_break_characters_throw): Add assertion.
 495         * completer.h (complete_nested_command_line): Declare.
 496
 497 2019-06-13  Pedro Alves  <palves@redhat.com>
 498
 499         * stack.c (parse_backtrace_qualifiers): New.
 500         (backtrace_command): Use it.
 501         (backtrace_command_completer): Complete on qualifiers.
 502
 503 2019-06-13  Pedro Alves  <palves@redhat.com>
 504
 505         * frame.c: Include "cli/cli-option.h.
 506         (user_set_backtrace_options): New.
 507         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 508         Delete.
 509         (get_prev_frame): Adjust.
 510         (boolean_option_def, uinteger_option_def)
 511         (set_backtrace_option_defs): New.
 512         (_initialize_frame): Adjust and use
 513         gdb::option::add_setshow_cmds_for_options to install "set
 514         backtrace past-main" and "set backtrace past-entry".
 515         * frame.h: Include "cli/cli-option.h".
 516         (struct frame_print_options): Forward declare.
 517         (print_frame_arguments_all, print_frame_arguments_scalars)
 518         (print_frame_arguments_none): Declare.
 519         (print_entry_values): Delete declaration.
 520         (struct frame_print_options, user_frame_print_options): New.
 521         (struct set_backtrace_options): New.
 522         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 523         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 524         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 525         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 526         (list_args_or_locals): Add frame_print_options parameter.
 527         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 528         * python/py-framefilter.c (enumerate_args): Pass down
 529         USER_FRAME_PRINT_OPTIONS.
 530         * stack.c: Include "cli/cli-option.h".
 531         (print_frame_arguments_all, print_frame_arguments_scalars)
 532         (print_frame_arguments_none): Declare.
 533         (print_raw_frame_arguments, print_entry_values): Delete.
 534         (user_frame_print_options): New.
 535         (boolean_option_def, enum_option_def, frame_print_option_defs):
 536         New.
 537         (struct backtrace_cmd_options): New.
 538         (bt_flag_option_def): New.
 539         (backtrace_command_option_defs): New.
 540         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 541         (print_frame_arg, read_frame_arg, print_frame_args)
 542         (print_frame_info, print_frame): Add frame_print_options parameter
 543         and use it.
 544         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 545         (backtrace_command_1): Add frame_print_options and
 546         backtrace_cmd_options parameters and use them.
 547         (make_backtrace_options_def_group): New.
 548         (backtrace_command): Process command options with
 549         gdb::option::process_options.
 550         (backtrace_command_completer): New.
 551         (_initialize_stack): Extend "backtrace"'s help to mention
 552         supported options.  Install completer for "backtrace".
 553         Install some settings commands with add_setshow_cmds_for_options.
 554
 555 2019-06-13  Pedro Alves  <palves@redhat.com>
 556
 557         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 558         and that "set/show print raw frame-arguments" are now deprecated.
 559
 560         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 561         command.
 562         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 563         * stack.c (_initialize_stack): Install "set/show print
 564         raw-frame-arguments", and deprecate "set/show print raw
 565         frame-arguments".
 566         * valprint.c (_initialize_valprint): Deprecate "set/show print
 567         raw".
 568
 569 2019-06-13  Pedro Alves  <palves@redhat.com>
 570
 571         * compile/compile.c (struct compile_options): New.
 572         (compile_flag_option_def, compile_command_option_defs)
 573         (make_compile_options_def_group): New.
 574         (compile_file_command): Handle options with
 575         gdb::option::process_options.
 576         (compile_file_command_completer): New function.
 577         (compile_code_command): Handle options with
 578         gdb::option::process_options.
 579         (compile_code_command_completer): New function.
 580         (_initialize_compiler): Install completers for "compile code" and
 581         "compile file".  Mention available options in "compile code" and
 582         "compile code"'s help.
 583         * completer.c (advance_to_completion_word): New, factored out from
 584         ...
 585         (advance_to_expression_complete_word_point): ... this.
 586         (advance_to_filename_complete_word_point): New.
 587         * completer.h (advance_to_filename_complete_word_point): New
 588         declaration.
 589
 590 2019-06-13  Pedro Alves  <palves@redhat.com>
 591
 592         * compile/compile.c: Include "cli/cli-option.h".
 593         (compile_print_value): Scope data pointer is now a
 594         value_print_options pointer; adjust.
 595         (compile_print_command): Process options.  Scope data pointer is
 596         now a value_print_options pointer; adjust.
 597         (_initialize_compile): Update "compile print"'s help to include
 598         supported options.  Install a completer for "compile print".
 599         * cp-valprint.c (show_vtblprint, show_objectprint)
 600         (show_static_field_print): Delete.
 601         (_initialize_cp_valprint): Don't install "set print
 602         static-members", "set print vtbl", "set print object" here.
 603         * printcmd.c: Include "cli/cli-option.h" and
 604         "common/gdb_optional.h".
 605         (print_command_parse_format): Rework to fill in a
 606         value_print_options instead of a format_data.
 607         (print_value): Change parameter type from format_data pointer to
 608         value_print_options reference.  Adjust.
 609         (print_command_1): Process options.  Adjust to pass down a
 610         value_print_options.
 611         (print_command_completer): New.
 612         (_initialize_printcmd): Install print_command_completer as
 613         handle_brkchars completer for the "print" command.  Update
 614         "print"'s help to include supported options.
 615         * valprint.c: Include "cli/cli-option.h".
 616         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 617         here from cp-valprint.c.
 618         (boolean_option_def, uinteger_option_def)
 619         (value_print_option_defs, make_value_print_options_def_group):
 620         New.  Use gdb::option::add_setshow_cmds_for_options to install
 621         "set print elements", "set print null-stop", "set print repeats",
 622         "set print pretty", "set print union", "set print array", "set
 623         print address", "set print symbol", "set print array-indexes".
 624         * valprint.h: Include <string> and "cli/cli-option.h".
 625         (make_value_print_options_def_group): Declare.
 626         (print_value): Change parameter type from format_data pointer to
 627         value_print_options reference.
 628         (print_command_completer): Declare.
 629
 630 2019-06-13  Pedro Alves  <palves@redhat.com>
 631
 632         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 633         (COMMON_SFILES): Add maint-test-settings.c.
 634         * cli/cli-decode.c (boolean_enums): New global, factored out from
 635         ...
 636         (add_setshow_boolean_cmd): ... here.
 637         * cli/cli-decode.h (boolean_enums): Declare.
 638         * cli/cli-option.c: New file.
 639         * cli/cli-option.h: New file.
 640         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 641         factored out from ...
 642         (parse_cli_boolean_value(const char *)): ... this.
 643         (is_unlimited_literal): Change parameter type to pointer to
 644         pointer.  Adjust and advance ARG pointer.
 645         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 646         (parse_cli_var_enum): New, factored out from ...
 647         (do_set_command): ... this.  Adjust.
 648         * cli/cli-setshow.h (parse_cli_boolean_value)
 649         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 650         (parse_cli_var_enum): Declare.
 651         * cli/cli-utils.c: Include "cli/cli-option.h".
 652         (get_ulongest): New.
 653         * cli/cli-utils.h (get_ulongest): Declare.
 654         (check_for_argument): New overloads.
 655         * maint-test-options.c: New file.
 656
 657 2019-06-13  Pedro Alves  <palves@redhat.com>
 658
 659         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 660         parse a range if "-" is at the end of the string.
 661
 662 2019-06-13  Pedro Alves  <palves@redhat.com>
 663
 664         * cli/cli-setshow.c (parse_auto_binary_operation)
 665         (parse_cli_boolean_value): Don't allow "o".
 666
 667 2019-06-13  Pedro Alves  <palves@redhat.com>
 668
 669         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 670         * NEWS: Mention maint test-settings KIND.
 671         * maint-test-settings.c: New file.
 672
 673 2019-06-13  Pedro Alves  <palves@redhat.com>
 674
 675         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 676         completer.
 677         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 678         "set" completers.
 679
 680 2019-06-13  Pedro Alves  <palves@redhat.com>
 681
 682         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 683         after item.
 684
 685 2019-06-13  Pedro Alves  <palves@redhat.com>
 686
 687         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 688
 689 2019-06-13  Pedro Alves <palves@redhat.com>
 690
 691         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 692         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 693         call.
 694         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 695         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 696         calls.
 697         (check_for_argument): Skip spaces after argument.
 698
 699 2019-06-13  Pedro Alves  <palves@redhat.com>
 700
 701         * thread.c (thread_apply_command): Adjust TID parsing.
 702         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 703         detected before end of string.
 704         (tid_is_in_list): Error out if LIST is invalid.
 705
 706 2019-06-13  Pedro Alves  <palves@redhat.com>
 707
 708         * completer.c (complete_line_internal_1): Rewind completion word
 709         point.
 710         (completion_tracker::advance_custom_word_point_by): Change
 711         parameter type to int.
 712         * completer.h (completion_tracker::advance_custom_word_point_by):
 713         Likewise.
 714
 715 2019-06-13  Pedro Alves  <palves@redhat.com>
 716
 717         * completer.c (advance_to_completion_word): Handle delimiters.
 718
 719 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 720
 721         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 722
 723 2019-06-11  Tom Tromey  <tom@tromey.com>
 724
 725         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 726         (xmalloc_failed): Move to alloc.c.
 727         * alloc.c: New file.
 728         * Makefile.in (COMMON_SFILES): Add alloc.c.
 729
 730 2019-06-11  Tom Tromey  <tom@tromey.com>
 731
 732         * nat/linux-waitpid.c: Don't include server.h.
 733         (linux_debug): Remove.
 734         (my_waitpid): Update.
 735
 736 2019-06-11  Tom Tromey  <tromey@adacore.com>
 737
 738         * infcall.c (_initialize_infcall): Remove trailing newline from
 739         help.
 740         * user-regs.c (_initialize_user_regs): Remove trailing newline
 741         from help.
 742         * typeprint.c (_initialize_typeprint): Remove trailing newline
 743         from help.
 744         * reverse.c (_initialize_reverse): Remove trailing newlines from
 745         help.
 746         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 747         from help.
 748         * language.c (add_set_language_command): Remove trailing newline
 749         from help.
 750         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 751         help.
 752         * disasm.c (_initialize_disasm): Remove trailing newline from
 753         help.
 754         * top.c (init_main): Remove trailing newline from help.
 755         * interps.c (_initialize_interpreter): Remove trailing newline
 756         from help.
 757         * btrace.c (_initialize_btrace): Remove trailing newlines from
 758         help.
 759         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 760         from help.
 761         * python/python.c (_initialize_python): Remove trailing newline
 762         from help.
 763         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 764         help.
 765         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 766         from help.  Reformat some text.
 767         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 768         from help.
 769         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 770         newline from help.
 771
 772 2019-06-11  Tom Tromey  <tromey@adacore.com>
 773
 774         * darwin-nat.c (darwin_decode_exception_message)
 775         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 776
 777 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 778
 779         * valops.c (value_slice): Check for not allocated or not
 780         associated values.
 781
 782 2019-06-10  Tom de Vries  <tdevries@suse.de>
 783
 784         PR gdb/24618
 785         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 786         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 787         invalid.
 788
 789 2019-06-10  Tom de Vries  <tdevries@suse.de>
 790
 791         PR gdb/24611
 792         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 793         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 794
 795 2019-06-10  Tom de Vries  <tdevries@suse.de>
 796
 797         PR symtab/24545
 798         * symtab.c (struct demangled_name_entry): Add language field.
 799         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 800         static minimal symbol".  Set and use language field.
 801
 802 2019-06-10  Tom Tromey  <tromey@adacore.com>
 803
 804         * ada-lang.c (_initialize_ada_language): Update help text.
 805
 806 2019-06-10  Tom Tromey  <tromey@adacore.com>
 807
 808         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 809         with a newline.
 810         * guile/guile.c (handle_boot_error): Don't end warning with a
 811         newline.
 812         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 813         warning with a newline.
 814         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 815         newline.
 816         (s12z_frame_cache): Likewise.
 817         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 818         a newline.
 819         * solib-svr4.c (disable_probes_interface): Don't end warning with
 820         a newline.
 821         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 822         newline.
 823         * python/python.c (do_finish_initialization): Don't end warning
 824         with a newline.
 825
 826 2019-06-10  Tom Tromey  <tom@tromey.com>
 827
 828         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 829         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 830         gdbpy_enter.
 831
 832 2019-06-10  Tom Tromey  <tromey@adacore.com>
 833
 834         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 835         data.
 836         (elf_new_init): Don't call stabsread_new_init.
 837         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 838         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 839         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 840
 841 2019-06-10  Tom de Vries  <tdevries@suse.de>
 842
 843         PR symtab/16264
 844         PR symtab/24517
 845         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 846
 847 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 848
 849         * source.c (find_and_open_source): Also rewrite relative file
 850         names.
 851
 852 2019-04-26  Amos Bird  <amosbird@gmail.com>
 853
 854         * annotate.c (annotate_thread_exited): Add "thread-exited"
 855         annotation.
 856
 857 2019-06-06  Tom Tromey  <tromey@adacore.com>
 858
 859         * maint.h (class scoped_command_stats): Use
 860         DISABLE_COPY_AND_ASSIGN.
 861         <print_time>: New method.
 862         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 863         print_time.
 864         (scoped_command_stats::print_time): New method.
 865
 866 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 867
 868         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 869         instructions of lengths 6 or 8 bytes.
 870
 871 2019-06-04  Pedro Alves  <palves@redhat.com>
 872
 873         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 874
 875         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 876         * breakpoint.c (condition_completer): Likewise.
 877         * cli/cli-dump.c (scan_expression): Likewise.
 878         * common/filestuff.c (mkdir_recursive): Likewise.
 879         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 880         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 881         (gdb_abspath): Likewise.
 882         * compile/compile-cplus-types.c
 883         (compile_cplus_instance::decl_name): Likewise.
 884         * completer.c (complete_explicit_location):
 885         (signal_completer, reg_or_group_completer_1): Likewise.
 886         * cp-support.c (cp_remove_params_if_any): Likewise.
 887         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 888         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 889         * infcmd.c (strip_bg_char): Likewise.
 890         * linespec.c (copy_token_string): Likewise.
 891         * mi/mi-main.c (output_cores): Likewise.
 892         * psymtab.c (psymtab_search_name):
 893         * symfile.c (test_set_ext_lang_command): Likewise.
 894         * target.c (target_fileio_read_stralloc): Likewise.
 895         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 896         * value.c (complete_internalvar): Likewise.
 897
 898 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 899
 900         Add objfile property to gdb.Type.
 901         * NEWS: Mention Python API addition.
 902         * python/py-type.c (typy_get_objfile): New method.
 903
 904 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 905
 906         * NEWS: Mention the new set|show style [title|highlight].
 907         Mention changes to "show style", "help" and "apropos".
 908
 909 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 910
 911         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 912         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 913         instead of print_help_for_command.
 914         (print_doc_of_command): New function.
 915         (help_list): Add 'apropos -v word' suggestion.
 916         (print_help_for_command): Style the command name using title style.
 917         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 918         (_initialize_cli_cmds): Describe -v in apropos_command help.
 919
 920 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 921
 922         * cli/cli-style.h (cli_style_option): Add name in constructor,
 923         add m_name class member, add constructor with intensity,
 924         add name class function.
 925         (cli_style_option::add_setshow_commands): Remove name argument.
 926         (highlight_style, title_style): New styles.
 927         * cli/cli-style.c (do_show): New function that shows a style
 928         characteristic styling the style name with itself.
 929         (set_style_name): New function.
 930         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 931         Update all callers according to the changes in cli/cli-style.h.
 932         * utils.h (fputs_highlighted): New function.
 933         * utils.c (fputs_highlighted): Likewise.
 934
 935 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 936
 937         * NEWS: Mention new pipe command and new convenience variables.
 938
 939 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 940
 941         * cli/cli-cmds.c (pipe_command): New function.
 942         (_initialize_cli_cmds): Call add_com for pipe_command.
 943         Define | as an alias for pipe.
 944         (exit_status_set_internal_vars): New function.
 945         (shell_escape): Call exit_status_set_internal_vars.
 946         cli/cli-decode.c (find_command_name_length): Recognize | as
 947         a single character command.
 948
 949 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 950
 951         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 952         top.c (execute_command_to_ui_file): New function, mostly a copy
 953         of execute_command_to_string.
 954         (execute_command_to_string): Implement by calling
 955         execute_command_to_ui_file.
 956
 957 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 958
 959         * top.h (saved_command_line): Remove declaration.
 960         * top.c (previous_saved_command_line, previous_repeat_arguments):
 961         New variables.
 962         (saved_command_line): Make static, define together with other
 963         'repeat variables'.
 964         (dont_repeat): Clear repeat_arguments.
 965         (repeat_previous, get_saved_command_line, save_command_line):
 966         New functions.
 967         (gdb_init): Initialize saved_command_line
 968         and previous_saved_command_line.
 969         * main.c (captured_main_1): Remove saved_command_line initialization.
 970         * event-top.c (handle_line_of_input): Update to use
 971         the new 'repeat' related functions instead of direct access to
 972         saved_command_line.
 973         * command.h (repeat_previous, get_saved_command_line,
 974         save_command_line): New declarations.
 975         (dont_repeat): Add comment.
 976
 977 2019-05-30  Tom Tromey  <tromey@adacore.com>
 978
 979         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 980         Fix comment.
 981         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 982
 983 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 984
 985         PR cli/24587
 986         * completer.c (complete): Initialize variable word.
 987
 988 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 989
 990         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 991         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 992         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 993         'body' is NULL to the outter 'if', protecting the '!is_define'
 994         situation as well.
 995
 996 2019-05-29  Tom Tromey  <tromey@adacore.com>
 997
 998         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 999         (dwarf_unknown): New function.
1000         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1001         (dwarf_type_encoding_name): Use dwarf_unknown.
1002
1003 2019-05-29  Tom Tromey  <tromey@adacore.com>
1004
1005         PR c++/20020:
1006         * cp-valprint.c (cp_print_value_fields): Call
1007         cp_print_static_field inside "try".
1008
1009 2019-05-29  Tom Tromey  <tromey@adacore.com>
1010
1011         * inflow.c (struct terminal_info): Add default operator=.
1012         * configure: Rebuild.
1013         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1014         -Wdeprecated-copy-dtor, -Wredundant-move.
1015
1016 2019-05-29  Tom Tromey  <tromey@adacore.com>
1017
1018         * NEWS: Add entry.
1019         * infcmd.c (print_return_value_1): Handle finish_print
1020         option.
1021         (show_print_finish): New function.
1022         (_initialize_infcmd): Add "set/show print finish" commands.
1023         * valprint.c (user_print_options): Initialize new member.
1024         * valprint.h (struct value_print_options) <finish_print>: New
1025         member.
1026
1027 2019-05-28  Tom Tromey  <tromey@adacore.com>
1028
1029         * ada-lang.c (ada_remove_Xbn_suffix)
1030         (find_old_style_renaming_symbol)
1031         (parse_old_style_renaming): Remove.
1032         (ada_find_renaming_symbol): Don't call
1033         find_old_style_renaming_symbol.
1034         (ada_is_renaming_symbol): Rename from
1035         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1036         bool.  Now static.
1037         (ada_read_var_value): Update and simplify.
1038         * ada-exp.y (write_var_or_type): Remove old code.
1039
1040 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1041
1042         * event-top.c: Remove include comment.
1043         * inflow.c (class scoped_ignore_sigttou): Move from here...
1044         * inflow.h (class scoped_ignore_sigttou): ...to here.
1045         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1046         * top.c:  Remove include comment.
1047
1048 2019-05-27  Tom Tromey  <tom@tromey.com>
1049
1050         * NEWS: Fix typo.
1051
1052 2019-05-22  Tom Tromey  <tromey@adacore.com>
1053
1054         * target.c (target_follow_exec): Constify parameter.
1055         * target-delegates.c: Rebuild.
1056         * remote.c (remote_target::follow_exec): Constify parameter.
1057         * infrun.c (follow_exec): Constify parameter.
1058         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1059         (target_follow_exec): Likewise.
1060
1061 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1062
1063         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1064         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1065
1066 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1067
1068         * NEWS: Add debugredirect and testsuite sections.
1069
1070 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1071
1072         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1073         target descriptions using exclusively floating point register name
1074         aliases.
1075
1076 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1077
1078         PR gdb/18644:
1079         * f-lang.c (build_fortran_types): Handle the case where
1080         gdbarch_floatformat_for_type returns a nullptr.
1081
1082 2019-05-21  Tom de Vries  <tdevries@suse.de>
1083
1084         PR cli/24587
1085         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1086
1087 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1088
1089         PR gdb/18644:
1090         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1091         16-byte floats.
1092         * i386-tdep.c (i386_floatformat_for_type): Use
1093         floatformats_ia64_quad for the 16-byte floating point component
1094         within a fortran 32-byte complex number.
1095
1096 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1099         delete default constructor.
1100         (find_partial_die): Update to return const struct.
1101         (partial_die_parent_scope): Move variable declaration into scope
1102         of its use and change its type to auto.
1103         (guess_partial_die_structure_name): Likewise.
1104         (partial_die_info::fixup): Likewise.
1105
1106 2019-05-17  Tom Tromey  <tromey@adacore.com>
1107
1108         * source.c (find_and_open_source): Remove cast.
1109
1110 2019-05-17  Tom Tromey  <tromey@adacore.com>
1111
1112         * annotate.c (annotate_source): Make "filename" const.
1113         * annotate.h (annotate_source): Use const.
1114
1115 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1116
1117         * disasm.c (set_disassembler_options): Send errors to stderr.
1118
1119 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1120
1121         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1122         (cli_interp_base::set_logging): Check debug_redirect.
1123         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1124         * cli/cli-logging.c (debug_redirect): Add static variable.
1125         (pop_output_files): Add default param.
1126         (handle_redirections): Print debug setting.
1127         (show_logging_command): Likewise.
1128         (_initialize_cli_logging): Add debugredirect command.
1129         * interps.c (current_interp_set_logging): Add debug_redirect
1130         parameter.
1131         * interps.h (set_logging): Add debug_redirect parameter.
1132         (current_interp_set_logging): Likewise.
1133         * mi/mi-common.h: Likewise.
1134         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1135
1136 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1137             Tom Tromey  <tromey@adacore.com>
1138
1139         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1140         directly.
1141         * cli/cli-interp.h (make_logging_output): Remove declaration.
1142         * cli/cli-logging.c (make_logging_output): Remove function.
1143         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1144         directly.
1145         * ui-file.c (tee_file::tee_file): Remove bools.
1146         (tee_file::~tee_file): Remove deletes.
1147         * ui-file.h (tee_file): Remove bools.
1148
1149 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1150
1151         * mi/mi-cmds.h (mi_cmd_complete): New function.
1152         * mi/mi-main.c (mi_cmd_complete): Likewise.
1153         * mi/mi-cmds.c: Define new MI command -complete.
1154         * NEWS: Mention new -complete command.
1155
1156 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1157
1158         * completer.h (complete): New function.
1159         * completer.c (complete): Likewise.
1160         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1161         function defined in completer.h.
1162
1163 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1164
1165         * MAINTAINERS (Write After Approval): Add myself.
1166
1167 2019-05-17  Tom de Vries  <tdevries@suse.de>
1168
1169         PR gdb/24094
1170         * dwarf2read.c (struct cu_partial_die_info): New struct.
1171         (find_partial_die): Return cu_partial_die_info.
1172         (partial_die_parent_scope, guess_partial_die_structure_name)
1173         (partial_die_info::fixup): Handle new return type of find_partial_die.
1174
1175 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1176
1177         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1178         "std::string", simplifying the algorithm.
1179
1180 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1181
1182         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1183         (stap_static_probe_ops::get_probes): Likewise.
1184
1185 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1186
1187         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1188         '-')" and "else if".
1189         (stap_parse_single_operand): Join checks for
1190         "gdbarch_stap_parse_special_token_p" and
1191         "gdbarch_stap_parse_special_token" in the same "if" statement.
1192         Invert check when verifying for operation on register
1193         displacement.
1194
1195 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1196
1197         * stap-probe.c (stap_get_opcode): Update comment.
1198         (stap_get_expected_argument_type): Likewise.
1199         (handle_stap_probe): Likewise.
1200
1201 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1202
1203         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1204         return type to 'bool'.  Adjust comment.  Use 'bool' when
1205         appropriate.
1206         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1207         * stap-probe.c (stap_parse_argument_1): Likewise.
1208         (stap_is_operator): Likewise.
1209         (stap_is_generic_prefix): Likewise.
1210         (stap_is_register_prefix): Likewise.
1211         (stap_is_register_indirection_prefix): Likewise.
1212         (stap_is_integer_prefix): Likewise.
1213         (stap_generic_check_suffix): Likewise.
1214         (stap_check_integer_suffix): Likewise.
1215         (stap_check_register_suffix): Likewise.
1216         (stap_check_register_indirection_suffix): Likewise.
1217         (stap_parse_register_operand): Likewise.
1218         (stap_parse_single_operand): Likewise.
1219         (stap_parse_argument_1): Likewise.
1220         (stap_probe::get_argument_count): Likewise.
1221         (stap_is_operator): Likewise.
1222
1223 2019-05-16  Tom Tromey  <tromey@adacore.com>
1224
1225         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1226         keyword to foreach.
1227
1228 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1229
1230         * linux-thread-db.c (try_thread_db_load_1): Change return type
1231         to bool.
1232         (try_thread_db_load): Likewise.
1233         (try_thread_db_load_from_pdir_1): Likewise.
1234         (try_thread_db_load_from_pdir): Likewise.
1235         (try_thread_db_load_from_sdir): Likewise.
1236         (try_thread_db_load_from_dir): Likewise.
1237         (thread_db_load_search): Likewise.
1238         (has_libpthread): Likewise.
1239         (thread_db_load): Likewise.
1240
1241 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1242
1243         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1244         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1245         NULL, and complain/return if that's the case.
1246
1247 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1248
1249         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1250         (advance, posn, abstract_read_memory): New functions.
1251         [struct mem_read_abstraction]: New struct.
1252         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1253
1254 2019-05-14  Tom Tromey  <tromey@adacore.com>
1255
1256         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1257         value is not lval_memory.
1258
1259 2019-05-14  Tom Tromey  <tromey@adacore.com>
1260
1261         * solib.c (info_sharedlibrary_command): Style the file name.
1262
1263 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1264
1265         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1266         (aarch64_vnv_type): Likewise.
1267         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1268         * common/tdesc.c: Likewise.
1269         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1270         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1271         * features/aarch64-fpu.xml: Add ieee half view.
1272         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1273         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1274         * gdbtypes.h (struct builtin_type): Likewise.
1275         (struct objfile_type): Likewise.
1276
1277 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1278
1279         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1280         typo.
1281         * location.h (string_to_event_location): Likewise.
1282
1283 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1284
1285         GDB 8.3 released.
1286
1287 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1288
1289         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1290         New variable declaration.
1291         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1292         New variable.
1293         (print_one_breakpoint): Use ui_out::test_flags and new global
1294         variable to compute use_fixed_output.
1295         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1296         Remove.
1297         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1298         (mi_multi_location_breakpoint_output_fixed): Remove.
1299         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1300         new variable.
1301         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1302         fix_multi_location_breakpoint_output flag if version >= 3.
1303         * ui-out.h (enum ui_out_flag)
1304         <fix_multi_location_breakpoint_output>: New enumerator.
1305
1306 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1307
1308         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1309
1310 2019-05-10  Tom Tromey  <tromey@adacore.com>
1311
1312         * ada-lang.c (catch_ada_completer): New function.
1313         (_initialize_ada_language): Use it.
1314
1315 2019-05-10  Tom Tromey  <tromey@adacore.com>
1316
1317         * thread.c (print_thread_info): Make "requested_threads" const.
1318         * gdbthread.h (print_thread_info): Make "requested_threads"
1319         const.
1320         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1321         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1322
1323 2019-05-08  Tom Tromey  <tom@tromey.com>
1324
1325         * gdbtypes.c (objfile_type_data): Change type.
1326         (objfile_type, _initialize_gdbtypes): Update.
1327
1328 2019-05-08  Tom Tromey  <tom@tromey.com>
1329
1330         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1331         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1332         (_initialize_dwarf2_frame): Update.
1333
1334 2019-05-08  Tom Tromey  <tom@tromey.com>
1335
1336         * objc-lang.c (objc_objfile_data): Change type.
1337         (find_methods): Update.
1338         (_initialize_objc_lang): Remove.
1339
1340 2019-05-08  Tom Tromey  <tom@tromey.com>
1341
1342         * stabsread.c (rs6000_builtin_type_data): Change type.
1343         (rs6000_builtin_type, _initialize_stabsread): Update.
1344
1345 2019-05-08  Tom Tromey  <tom@tromey.com>
1346
1347         * mips-tdep.c (mips_pdr_data): Remove.
1348         (_initialize_mips_tdep): Update.
1349
1350 2019-05-08  Tom Tromey  <tom@tromey.com>
1351
1352         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1353         (hppa_init_objfile_priv_data, read_unwind_info)
1354         (find_unwind_entry, _initialize_hppa_tdep): Update.
1355
1356 2019-05-08  Tom Tromey  <tom@tromey.com>
1357
1358         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1359         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1360         on obstack.
1361         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1362
1363 2019-05-08  Tom Tromey  <tom@tromey.com>
1364
1365         * mdebugread.c (basic_type_data): Change type.
1366         (basic_type, _initialize_mdebugread): Update.
1367
1368 2019-05-08  Tom Tromey  <tom@tromey.com>
1369
1370         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1371
1372 2019-05-08  Tom Tromey  <tom@tromey.com>
1373
1374         * nto-tdep.c (nto_inferior_data_reg): Change type.
1375         (nto_inferior_data): Update.
1376         (nto_inferior_data_cleanup, nto_new_inferior_data)
1377         (_initialize_nto_tdep): Remove.
1378         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1379
1380 2019-05-08  Tom Tromey  <tom@tromey.com>
1381
1382         * ada-lang.c (struct ada_inferior_data): Add initializers.
1383         (ada_inferior_data): Change type.
1384         (ada_inferior_data_cleanup): Remove.
1385         (get_ada_inferior_data, ada_inferior_exit)
1386         (struct ada_pspace_data): Add initializers, destructor.
1387         (ada_pspace_data_handle): Change type.
1388         (get_ada_pspace_data): Update.
1389         (ada_pspace_data_cleanup): Remove.
1390
1391 2019-05-08  Tom Tromey  <tom@tromey.com>
1392
1393         * coffread.c (struct coff_symfile_info): Add initializers.
1394         (coff_objfile_data_key): Move lower.  Change type.
1395         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1396         Update.
1397         (coff_free_info): Remove.
1398
1399 2019-05-08  Tom Tromey  <tom@tromey.com>
1400
1401         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1402         (fbsd_pspace_data_handle): Move lower.  Change type.
1403         (get_fbsd_pspace_data): Update.
1404         (fbsd_pspace_data_cleanup): Remove.
1405         (_initialize_fbsd_tdep): Update.
1406
1407 2019-05-08  Tom Tromey  <tom@tromey.com>
1408
1409         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1410         (get_ada_tasks_pspace_data): Update.
1411         (ada_tasks_pspace_data_cleanup): Remove.
1412         (_initialize_tasks): Update.
1413         (ada_tasks_inferior_data_handle): Change type.
1414         (get_ada_tasks_inferior_data): Update.
1415         (ada_tasks_inferior_data_cleanup): Remove.
1416         (struct ada_tasks_pspace_data): Add initializers.
1417
1418 2019-05-08  Tom Tromey  <tom@tromey.com>
1419
1420         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1421         * symfile-debug.c (debug_sym_get_probes): Change type.
1422         * stap-probe.c (handle_stap_probe):
1423         (stap_static_probe_ops::get_probes): Change type.
1424         * probe.h (class static_probe_ops) <get_probes>: Change type.
1425         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1426         (parse_probes_in_pspace): Update.
1427         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1428         Update.
1429         (any_static_probe_ops::get_probes): Change type.
1430         * elfread.c (elfread_data): New typedef.
1431         (probe_key): Change type.
1432         (elf_get_probes): Likewise.  Update.
1433         (probe_key_free): Remove.
1434         (_initialize_elfread): Update.
1435         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1436         Change type.
1437         (dtrace_process_dof_probe, dtrace_process_dof)
1438         (dtrace_static_probe_ops::get_probe): Change type.
1439
1440 2019-05-08  Tom Tromey  <tom@tromey.com>
1441
1442         * xcoffread.c (struct xcoff_symfile_info): Rename from
1443         coff_symfile_info.  Add initializers.
1444         (xcoff_objfile_data_key): Move lower.  Change type.
1445         (XCOFF_DATA): Rewrite.
1446         (xcoff_free_info): Remove.
1447         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1448         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1449         (xcoff_initial_scan): Update.
1450
1451 2019-05-08  Tom Tromey  <tom@tromey.com>
1452
1453         * solib-svr4.c (struct svr4_info): Add initializers and
1454         destructor.
1455         <probes_table>: Now an htab_up.
1456         (solib_svr4_pspace_data): Change type.
1457         (free_probes_table): Simplify.
1458         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1459         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1460         (probes_table_remove_objfile_probes, register_solib_event_probe)
1461         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1462         (_initialize_svr4_solib): Update.
1463
1464 2019-05-08  Tom Tromey  <tom@tromey.com>
1465
1466         * remote.c (remote_pspace_data): Change type.
1467         (remote_pspace_data_cleanup): Remove.
1468         (get_remote_exec_file, set_pspace_remote_exec_file)
1469         (_initialize_remote): Update.
1470
1471 2019-05-08  Tom Tromey  <tom@tromey.com>
1472
1473         * breakpoint.c (breakpoint_objfile_key): Change type.
1474         (get_breakpoint_objfile_data): Update.
1475         (free_breakpoint_objfile_data): Remove.
1476         (_initialize_breakpoint): Update.
1477
1478 2019-05-08  Tom Tromey  <tom@tromey.com>
1479
1480         * linux-tdep.c (struct linux_info): Add initializers.
1481         (linux_inferior_data): Move.  Change type.
1482         (invalidate_linux_cache_inf): Update.
1483         (linux_inferior_data_cleanup): Remove.
1484         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1485
1486 2019-05-08  Tom Tromey  <tom@tromey.com>
1487
1488         * auxv.c (auxv_inferior_data): Move.  Change type.
1489         (auxv_inferior_data_cleanup): Remove.
1490         (invalidate_auxv_cache_inf): Rewrite.
1491         (get_auxv_inferior_data, _initialize_auxv): Update.
1492
1493 2019-05-08  Tom Tromey  <tom@tromey.com>
1494
1495         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1496         (symfile_debug_objfile_data_key): Change type.
1497         (symfile_debug_installed, debug_qf_has_symbols)
1498         (debug_qf_find_last_source_symtab)
1499         (debug_qf_forget_cached_source_info)
1500         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1501         (debug_qf_print_stats, debug_qf_dump)
1502         (debug_qf_expand_symtabs_for_function)
1503         (debug_qf_expand_all_symtabs)
1504         (debug_qf_expand_symtabs_with_fullname)
1505         (debug_qf_map_matching_symbols)
1506         (debug_qf_expand_symtabs_matching)
1507         (debug_qf_find_pc_sect_compunit_symtab)
1508         (debug_qf_map_symbol_filenames)
1509         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1510         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1511         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1512         (debug_sym_read_linetable, debug_sym_relocate): Update.
1513         (symfile_debug_free_objfile): Remove.
1514         (install_symfile_debug_logging, _initialize_symfile_debug):
1515         Update.
1516
1517 2019-05-08  Tom Tromey  <tom@tromey.com>
1518
1519         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1520         allocate_on_obstack.
1521         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1522         (get_dwarf2_per_objfile): Update.
1523         (set_dwarf2_per_objfile): Remove.
1524         (dwarf2_has_info, dwarf2_get_section_info): Update.
1525         (dwarf2_free_objfile): Remove.
1526         (_initialize_dwarf2_read): Update.
1527
1528 2019-05-08  Tom Tromey  <tom@tromey.com>
1529
1530         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1531         initializers.
1532         <unsupported_script_warning_printed,
1533         script_not_found_warning_printed>: Now bool.
1534         (auto_load_pspace_data): Change type.
1535         (~auto_load_pspace_info): Rename from
1536         auto_load_pspace_data_cleanup.
1537         (get_auto_load_pspace_data, init_loaded_scripts_info)
1538         (clear_section_scripts, maybe_print_unsupported_script_warning)
1539         (maybe_print_script_not_found_warning, _initialize_auto_load):
1540         Update.
1541
1542 2019-05-08  Tom Tromey  <tom@tromey.com>
1543
1544         * objfiles.c (objfile_pspace_info): Add destructor and
1545         initializers.
1546         (objfiles_pspace_data): Change type.
1547         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1548         (get_objfile_pspace_data): Update.
1549         (objfiles_bfd_data): Change type.
1550         (get_objfile_bfd_data): Update.
1551         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1552
1553 2019-05-08  Tom Tromey  <tom@tromey.com>
1554
1555         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1556         Change type.
1557         (get_catch_syscall_inferior_data): Update.
1558         (catch_syscall_inferior_data_cleanup): Remove.
1559         (_initialize_break_catch_syscall): Update.
1560
1561 2019-05-08  Tom Tromey  <tom@tromey.com>
1562
1563         * inflow.c (struct terminal_info): Add destructor and
1564         initializers.
1565         (inflow_inferior_data): Change type.
1566         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1567         (get_inflow_inferior_data, inflow_inferior_exit)
1568         (swap_terminal_info, _initialize_inflow): Update.
1569
1570 2019-05-08  Tom Tromey  <tom@tromey.com>
1571
1572         * target-dcache.c (target_dcache_cleanup): Remove.
1573         (target_dcache_aspace_key): Change type.
1574         (target_dcache_init_p, target_dcache_invalidate)
1575         (target_dcache_get, target_dcache_get_or_init)
1576         (_initialize_target_dcache): Update.
1577         * dcache.h (struct dcache_deleter): New.
1578
1579 2019-05-08  Tom Tromey  <tom@tromey.com>
1580
1581         * symtab.c (struct symbol_cache): Add destructor and
1582         initializers.
1583         (symbol_cache_key): Move.  Change type.
1584         (make_symbol_cache, free_symbol_cache): Remove.
1585         (get_symbol_cache): Update.
1586         (symbol_cache_cleanup): Remove.
1587         (ALL_PSPACES, symbol_cache_flush)
1588         (maintenance_print_symbol_cache)
1589         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1590         Update.
1591
1592 2019-05-08  Tom Tromey  <tom@tromey.com>
1593
1594         * symtab.c (struct main_info): Add destructor and initializers.
1595         (main_progspace_key): Move.  Change type.
1596         (get_main_info): Update.
1597         (main_info_cleanup): Remove.
1598         (_initialize_symtab): Update.
1599
1600 2019-05-08  Tom Tromey  <tom@tromey.com>
1601
1602         * registry.h (DECLARE_REGISTRY): Define the _key class.
1603
1604 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1605
1606         * NEWS: Merge two 'New commands' sections.
1607
1608 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1609
1610         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1611         parameter and use Ada language definition instead.
1612         (ada_val_print_ptr): Remove unused language parameter.
1613         (ada_val_print_num): Remove language parameter and use Ada language
1614         definition instead.
1615         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1616         parameter.
1617         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1618         parameter and use Ada language definition instead.
1619         (ada_val_print_1): Update all ada_val_print_xxx calls.
1620         Remove language parameter.
1621         (ada_val_print): Update ada_val_print_1 call.
1622
1623 2019-05-08  Tom Tromey  <tromey@adacore.com>
1624
1625         * remote.c (remote_hw_watchpoint_limit)
1626         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1627         Now static.
1628
1629 2019-05-08  Tom Tromey  <tromey@adacore.com>
1630
1631         * maint.c (_initialize_maint_cmds): Move initialization code to
1632         remote.c.
1633         (watchdog, show_watchdog): Move to remote.c.
1634         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1635         "watchdog" static.
1636         (_initialize_remote): Move initialization code from maint.c.
1637         * defs.h (watchdog): Don't declare.
1638
1639 2019-05-08  Tom Tromey  <tromey@adacore.com>
1640
1641         * tui/tui-interp.c: Include main.h.
1642         * interps.c: Include main.h.
1643         * main.h (interpreter_p): Declare.
1644         * defs.h (interpreter_p): Don't declare.
1645
1646 2019-05-08  Tom Tromey  <tromey@adacore.com>
1647
1648         * dwarf2loc.c: Include dwarf2read.h.
1649         * defs.h (read_unsigned_leb128): Don't declare.
1650         * dwarf2read.h (read_unsigned_leb128): Declare.
1651
1652 2019-05-08  Tom Tromey  <tromey@adacore.com>
1653
1654         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1655         method.
1656
1657 2019-05-08  Tom Tromey  <tromey@adacore.com>
1658
1659         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1660         when no wrap column is set.
1661
1662 2019-05-08  Tom Tromey  <tromey@adacore.com>
1663
1664         * c-lang.c (c_get_string): Handle non-C-style arrays.
1665
1666 2019-05-08  Tom Tromey  <tromey@adacore.com>
1667
1668         * typeprint.c (print_offset_data::update): Print the bit offset,
1669         not the number of bits remaining.
1670
1671 2019-05-08  Tom Tromey  <tromey@adacore.com>
1672
1673         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1674         padding at end of comment.
1675
1676 2019-05-08  Tom Tromey  <tromey@adacore.com>
1677
1678         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1679         Compare main types.
1680
1681 2019-05-06  Tom Tromey  <tom@tromey.com>
1682
1683         * common/scoped_mmap.c: Include common-defs.h.
1684         * common/scoped_mmap.h: Don't include config.h.
1685
1686 2019-05-04  Tom Tromey  <tom@tromey.com>
1687
1688         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1689         (struct aarch64_call_info): Add initializers.
1690         <si>: Now a std::vector.
1691         (pass_on_stack, aarch64_push_dummy_call): Update.
1692
1693 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1694             Tom Tromey  <tom@tromey.com>
1695
1696         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1697         (ppc_threads): Now a std::vector.  Now static.
1698         (hwdebug_find_thread_points_by_tid)
1699         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1700         Update.
1701
1702 2019-05-04  Tom Tromey  <tom@tromey.com>
1703
1704         * arc-tdep.c (arc_tdesc_init): Return bool.
1705
1706 2019-05-04  Tom Tromey  <tom@tromey.com>
1707
1708         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1709         Use gdb_assert_not_reached.
1710
1711 2019-05-04  Tom Tromey  <tom@tromey.com>
1712
1713         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1714         "false".
1715
1716 2019-05-04  Tom Tromey  <tom@tromey.com>
1717
1718         * arc-tdep.c (arc_tdesc_init): Use bool.
1719
1720 2019-05-04  Tom Tromey  <tom@tromey.com>
1721
1722         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1723
1724 2019-05-04  Tom Tromey  <tom@tromey.com>
1725
1726         * cli/cli-cmds.c (valid_command_p): Return bool.
1727
1728 2019-05-04  Tom Tromey  <tom@tromey.com>
1729
1730         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1731         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1732
1733 2019-05-04  Raul Tambre  <raul@tambre.ee>
1734
1735         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1736         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1737         operator for comparison.
1738
1739 2019-05-04  Tom Tromey  <tom@tromey.com>
1740
1741         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1742         (lookup_partial_symbol, print_partial_symbols)
1743         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1744         (psymbol_compare): Update.
1745         (add_psymbol_to_bcache): Clear the entire psymbol.
1746         (maintenance_check_psymtabs): Update.
1747         * psympriv.h (struct partial_symbol): Don't derive from
1748         general_symbol_info.
1749         <obj_section, unrelocated_address, address,
1750         set_unrelocated_address>: Update.
1751         <ginfo>: New member.
1752         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1753         (debug_names::write_psymbols): Update.
1754
1755 2019-05-04  Tom de Vries  <tdevries@suse.de>
1756
1757         * contrib/cc-with-tweaks.sh: Support -n arg.
1758
1759 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1760
1761         * corelow.c (core_target::detach): Ensure frame cache and
1762         register caches are cleared.
1763         inferior.c (exit_inferior_1): Likewise.
1764
1765 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1766             Tom Tromey  <tom@tromey.com>
1767
1768         * dictionary.c (collate_pending_symbols_by_language): Remove
1769         "struct" from foreach.
1770         * symtab.c (lookup_global_symbol_from_objfile)
1771         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1772         foreach.
1773         * ser-tcp.c (net_open): Remove "struct" from foreach.
1774         * objfiles.c (objfile_relocate, objfile_rebase)
1775         (objfile_has_symbols): Remove "struct" from foreach.
1776         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1777         from foreach.
1778         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1779         foreach.
1780         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1781         "struct" from foreach.
1782         * ada-lang.c (create_excep_cond_exprs)
1783         (ada_exception_catchpoint_cond_string): Remove "struct" from
1784         foreach.
1785
1786 2019-05-03  Tom Tromey  <tromey@adacore.com>
1787
1788         * ada-exp.y (convert_char_literal): Check suffix of each
1789         enumerator.
1790
1791 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1792
1793         PR ada/21406:
1794         * ada-exp.y (yywrap): Don't define.
1795         * ada-lex.l (%option): Add noyywrap
1796         (yywrap): Remove.
1797
1798 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1799
1800         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1801         _WIN32_WINNT to the XP level, unless already defined to a higher
1802         level.
1803
1804         * unittests/parse-connection-spec-selftests.c:
1805         * ser-tcp.c:
1806         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1807         override.
1808
1809         * symfile.c (find_separate_debug_file): Remove colon from the
1810         drive spec of DOS/Windows file names of the target, so that the
1811         file name produced from DEBUGDIR and the target's directory will
1812         be valid on DOS/Windows systems.
1813
1814 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1815
1816         * rust-lang.c (val_print_struct): Handle printing structures
1817         containing strings.
1818
1819 2019-05-02  Tom Tromey  <tromey@adacore.com>
1820
1821         * valarith.c (_initialize_valarith): Remove.
1822
1823 2019-05-01  Tom Tromey  <tromey@adacore.com>
1824
1825         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1826         bitfields.
1827
1828 2019-05-01  Tom Tromey  <tromey@adacore.com>
1829
1830         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1831         for big-endian copies.
1832
1833 2019-04-30  Ali Tamur  <tamur@google.com>
1834         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1835         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1836         (read_3_bytes): New function.
1837
1838 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1839
1840         * windows-nat.c (main_thread_id): Delete.
1841         (handle_output_debug_string): Replace main_thread_id by
1842         current_event.dwThreadId.
1843         (fake_create_process): Likewise.
1844         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1845         Do not set main_thread_id.
1846         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1847         current_event.dwThreadId.
1848         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1849
1850 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1851
1852         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1853         Use current_event.dwThreadId instead of main_thread_id.
1854
1855 2019-04-30  Tom Tromey  <tromey@adacore.com>
1856
1857         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1858         (create_excep_cond_exprs): Iterate over program spaces.
1859         (ada_exception_catchpoint_cond_string): Examine all minimal
1860         symbols for exception types.
1861
1862 2019-04-30  Tom Tromey  <tromey@adacore.com>
1863
1864         PR c++/24470:
1865         * dwarf2read.c (process_structure_scope): Handle case where type
1866         has template parameters but no symbol was created.
1867
1868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1869             Chris January  <chris.january@arm.com>
1870
1871         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1872         qualifier.
1873         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1874
1875 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1876
1877         * f-typeprint.c (f_print_type): Update rules for printing
1878         whitespace.
1879         (f_type_print_varspec_suffix): Likewise.
1880
1881 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1882             Chris January  <chris.january@arm.com>
1883
1884         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1885         function arguments.
1886
1887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1888
1889         * f-lang.c (build_fortran_types): Change name of void type to
1890         lower case.
1891         * f-typeprint.c (f_type_print_base): Print the name of the void
1892         type, rather than a fixed string.
1893         * f-valprint.c (f_decorations): Use lower case void string.
1894
1895 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1896             Chris January  <chris.january@arm.com>
1897
1898         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1899         types for Fortran.
1900
1901 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1902             Chris January  <chris.january@arm.com>
1903             David Lecomber  <david.lecomber@arm.com>
1904
1905         * f-exp.y (BINOP_INTRINSIC): New token.
1906         (exp): New parser rule handling BINOP_INTRINSIC.
1907         (f77_keywords): Add new builtin procedures.
1908         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1909         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1910         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1911         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1912         (print_unop_subexp_f): New function.
1913         (print_binop_subexp_f): New function.
1914         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1915         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1916         (dump_subexp_body_f): Likewise.
1917         (operator_check_f): Likewise.
1918         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1919         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1920
1921 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1922
1923         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1924         UNOP_KIND.
1925         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1926         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1927         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1928         (operator_length_f): New fuction.
1929         (print_subexp_f): New function.
1930         (op_name_f): New function.
1931         (dump_subexp_body_f): New function.
1932         (operator_check_f): New function.
1933         (exp_descriptor_f): Replace standard expression handling functions
1934         with new functions.
1935         * gdb/fortran-operator.def: New file.
1936         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1937         * gdb/std-operator.def: Remove UNOP_KIND.
1938
1939 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         * std-operator.def: Remove unbalanced, stray double quote
1942         character.
1943
1944 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1945             Chris January  <chris.january@arm.com>
1946             Daniel Everett  <daniel.everett@arm.com>
1947             Nick Forrington  <nick.forrington@arm.com>
1948             Richard Bunt  <richard.bunt@arm.com>
1949
1950         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1951         of depth when printing anonymous structs or unions.
1952         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1953         Don't print either the top-level value, or the children if the
1954         max-depth is exceeded.
1955         (ppscm_print_children): When printing the key of a map, allow one
1956         extra level of depth.
1957         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1958         print either the top-level value, or the children if the max-depth
1959         is exceeded.
1960         (print_children): When printing the key of a map, allow one extra
1961         level of depth.
1962         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1963         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1964         (user_print_options): Initialise max_depth field.
1965         (val_print_scalar_or_string_type_p): New function.
1966         (val_print): Check to see if the max depth has been reached.
1967         (val_print_check_max_depth): Define new function.
1968         (show_print_max_depth): New function.
1969         (_initialize_valprint): Add 'print max-depth' option.
1970         * valprint.h (struct value_print_options) <max_depth>: New field.
1971         (val_print_check_max_depth): Declare new function.
1972         * NEWS: Document new feature.
1973
1974 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         * ada-lang.c (ada_language_defn): Initialise new field.
1977         * c-lang.c (c_is_string_type_p): New function.
1978         (c_language_defn): Initialise new field.
1979         (cplus_language_defn): Initialise new field.
1980         (asm_language_defn): Initialise new field.
1981         (minimal_language_defn): Initialise new field.
1982         * c-lang.h (c_is_string_type_p): Declare new function.
1983         * d-lang.c (d_language_defn): Initialise new field.
1984         * f-lang.c (f_is_string_type_p): New function.
1985         (f_language_defn): Initialise new field.
1986         * go-lang.c (go_is_string_type_p): New function.
1987         (go_language_defn): Initialise new field.
1988         * language.c (default_is_string_type_p): New function.
1989         (unknown_language_defn): Initialise new field.
1990         (auto_language_defn): Initialise new field.
1991         * language.h (struct language_defn) <la_is_string_type_p>: New
1992         member variable.
1993         (default_is_string_type_p): Declare new function.
1994         * m2-lang.c (m2_language_defn): Initialise new field.
1995         * objc-lang.c (objc_language_defn): Initialise new field.
1996         * opencl-lang.c (opencl_language_defn): Initialise new field.
1997         * p-lang.c (pascal_is_string_type_p): New function.
1998         (pascal_language_defn): Initialise new field.
1999         * rust-lang.c (rust_is_string_type_p): New function.
2000         (rust_language_defn): Initialise new field.
2001
2002 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2003
2004         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2005         New field.
2006         * ada-lang.c (ada_language_defn): Initialise new field.
2007         * c-lang.c (c_language_defn): Likewise.
2008         (cplus_language_defn): Likewise.
2009         (asm_language_defn): Likewise.
2010         (minimal_language_defn): Likewise.
2011         * d-lang.c (d_language_defn): Likewise.
2012         * f-lang.c (f_language_defn): Likewise.
2013         * go-lang.c (go_language_defn): Likewise.
2014         * language.c (unknown_language_defn): Likewise.
2015         (auto_language_defn): Likewise.
2016         * m2-lang.c (m2_language_defn): Likewise.
2017         * objc-lang.c (objc_language_defn): Likewise.
2018         * opencl-lang.c (opencl_language_defn): Likewise.
2019         * p-lang.c (pascal_language_defn): Likewise.
2020         * rust-lang.c (rust_language_defn): Likewise.
2021
2022 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2023
2024         * ada-lang.c (ada_is_character_type): Change return type to bool.
2025         (ada_is_string_type): Likewise.
2026         * ada-lang.h (ada_is_character_type): Update declaration
2027         (ada_is_string_type): Likewise.
2028
2029 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2030
2031         Support style in 'frame|thread apply'
2032
2033         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2034         * record.c (record_start, record_stop): Update callers of
2035         execute_command_to_string with false.
2036         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2037         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2038         methods.
2039         (class string_file): New constructor with term_out parameter.
2040         Override methods term_out and can_emit_style_escape.  New member
2041         term_out.
2042         (class stdio_file): Override can_emit_style_escape.
2043         (class tee_file): Override term_out and can_emit_style_escape.
2044         * utils.h (can_emit_style_escape): Remove.
2045         * utils.c (can_emit_style_escape): Likewise.
2046         Update all callers of can_emit_style_escape (SOMESTREAM) to
2047         SOMESTREAM->can_emit_style_escape.
2048         * source-cache.c (source_cache::get_source_lines): Likewise.
2049         * stack.c (frame_apply_command_count): Call execute_command_to_string
2050         passing the term_out characteristic of the current gdb_stdout.
2051         * thread.c (thr_try_catch_cmd): Likewise.
2052         * top.c (execute_command_to_string): pass term_out parameter
2053         to construct the string_file for the command output.
2054         * ui-file.c (term_cli_styling): New function (most code moved
2055         from utils.c can_emit_style_escape).
2056         (string_file::string_file, string_file::can_emit_style_escape,
2057         stdio_file::can_emit_style_escape, tee_file::term_out,
2058         tee_file::can_emit_style_escape): New functions.
2059
2060 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2061
2062         * NEWS: Mention the new set|show may-call-functions.
2063         * infcall.c (may_call_functions_p): New variable.
2064         (show_may_call_functions_p): New function.
2065         (call_function_by_hand_dummy): Throws an error if not
2066         may-call-functions.
2067         (_initialize_infcall): Call add_setshow_boolean_cmd for
2068         may-call-functions.
2069
2070 2019-04-25  Keith Seitz  <keiths@redhat.com>
2071
2072         PR c++/24367
2073         * cp-support.c (inspect_type): Don't attempt substitutions
2074         of symbol with the same name.
2075
2076 2019-04-25  Tom Tromey  <tromey@adacore.com>
2077
2078         PR gdb/24475:
2079         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2080         static.
2081
2082 2019-04-25  Tom Tromey  <tromey@adacore.com>
2083
2084         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2085         rvalue reference.
2086         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2087         (gdb_xml_parser::parse): Use std::move.
2088         * python/python-internal.h (gdbpy_convert_exception): Take a const
2089         reference.
2090         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2091         std::move.
2092         * python/py-utils.c (gdbpy_convert_exception): Take a const
2093         reference.
2094         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2095         Use std::move.
2096         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2097         Use std::move.
2098         * mi/mi-main.c (mi_print_exception): Take a const reference.
2099         * main.c (handle_command_errors): Take a const reference.
2100         * linespec.c (parse_linespec): Use std::move.
2101         * infcall.c (run_inferior_call): Use std::move.
2102         (call_function_by_hand_dummy): Use std::move.
2103         * exec.c (try_open_exec_file): Use std::move.
2104         * exceptions.h (exception_print, exception_fprintf)
2105         (exception_print_same): Update.
2106         * exceptions.c (print_exception, exception_print)
2107         (exception_fprintf, exception_print_same): Change parameters to
2108         const reference.
2109         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2110         * common/new-op.c: Use std::move.
2111         * common/common-exceptions.h (struct gdb_exception): Add move
2112         constructor.
2113         (struct gdb_exception_error, struct gdb_exception_quit, struct
2114         gdb_quit_bad_alloc): Change constructor to move constructor.
2115         (throw_exception): Change parameter to rvalue reference.
2116         * common/common-exceptions.c (throw_exception): Take rvalue
2117         reference.
2118         * cli/cli-interp.c (safe_execute_command): Use std::move.
2119         * breakpoint.c (insert_bp_location, location_to_sals): Use
2120         std::move.
2121
2122 2019-04-25  Tom Tromey  <tromey@adacore.com>
2123
2124         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2125         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2126         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2127         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2128         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2129         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2130         guile/scm-value.c: Use unpack.
2131         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2132         gdbscm_gdb_exception.
2133         (gdbscm_throw_gdb_exception): Likewise.
2134         (struct gdbscm_gdb_exception): New.
2135         (unpack): New function.
2136         (gdbscm_wrap): Use unpack.
2137
2138 2019-04-25  Tom Tromey  <tromey@adacore.com>
2139
2140         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2141         (gdb_rl_callback_handler): Use std::move.
2142         * common/common-exceptions.h (struct gdb_exception): Add move
2143         assignment operator.
2144         (throw_exception_sjlj): Change "exception" to const reference.
2145         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2146         (throw_exception_sjlj): Change "exception" to const reference.
2147
2148 2019-04-25  Tom Tromey  <tromey@adacore.com>
2149
2150         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2151         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2152         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2153         Update.
2154         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2155         Update.
2156         * mi/mi-interp.c (mi_interp::exec): Update.
2157         * linespec.c (parse_linespec): Update.
2158         * infcall.c (run_inferior_call): Update.
2159         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2160         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2161         (gdbscm_lookup_global_symbol): Update.
2162         * guile/scm-param.c (gdbscm_parameter_value): Update.
2163         * guile/scm-frame.c (gdbscm_frame_read_register)
2164         (gdbscm_frame_read_var): Update.
2165         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2166         * exec.c (try_open_exec_file): Update.
2167         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2168         (gdb_rl_callback_handler): Update.
2169         * common/common-exceptions.h (exception_none): Don't declare.
2170         * common/common-exceptions.c (exception_none): Don't define.
2171         (struct catcher) <exception>: Update.
2172         * cli/cli-interp.c (safe_execute_command): Update.
2173         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2174
2175 2019-04-25  Ali Tamur  <tamur@google.com>
2176
2177         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2178         (read_attribute_value): Likewise.
2179         (dwarf2_read_addr_index): Update comment.
2180         (read_str_index): Add DW_FORM_strx.
2181         (dwarf2_string_attr): Likewise.
2182         (dwarf2_const_value_attr): Likewise.
2183         (dump_die_shallow): Likewise.
2184         (dwarf2_fetch_constant_bytes): Likewise.
2185         (skip_form_bytes): Likewise.
2186         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2187
2188 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2189
2190         PR corefiles/11608
2191         PR corefiles/18187
2192         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2193         OFFSET.  Verify if current mapping contains an ELF header.
2194         (linux_find_memory_regions_full): Adjust call to
2195         dump_mapping_p.
2196
2197 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2198             Kang Li <kanglictf@gmail.com>
2199
2200         PR gdb/21600
2201
2202         * dwarf2-frame.c (read_initial_length): Be consistent about using
2203         unsigned representation of length.
2204         (decode_frame_entry_1): Likewise.  Check for wraparound of
2205         end pointer as well as buffer overflow.
2206
2207 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2208
2209         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2210         "vq".
2211
2212 2019-04-24  Tom Tromey  <tromey@adacore.com>
2213
2214         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2215
2216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2217
2218         * s12z-tdep.c (s12z_unwind_pc): Delete.
2219         (s12z_unwind_sp): Delete.
2220         (s12z_gdbarch_init): Don't register deleted functions with
2221         gdbarch.
2222
2223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * rl78-tdep.c (rl78_unwind_sp): Delete.
2226         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2227
2228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2229
2230         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2231         (xstormy16_unwind_pc): Delete.
2232         (xstormy16_dummy_id): Delete.
2233         (xstormy16_gdbarch_init): Don't register deleted functions with
2234         gdbarch.
2235
2236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * vax-tdep.c (vax_unwind_pc): Delete.
2239         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2240
2241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * v850-tdep.c (v850_unwind_sp): Delete.
2244         (v850_unwind_pc): Delete.
2245         (v850_dummy_id): Delete.
2246         (v850_gdbarch_init): Don't register deleted functions with
2247         gdbarch.
2248
2249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2250
2251         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2252         (tilegx_unwind_pc): Delete.
2253         (tilegx_unwind_dummy_id): Delete.
2254         (tilegx_gdbarch_init): Don't register deleted functions with
2255         gdbarch.
2256
2257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2258
2259         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2260         (tic6x_dummy_id): Delete.
2261         (tic6x_gdbarch_init): Don't register deleted functions with
2262         gdbarch.
2263
2264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2265
2266         * sparc-tdep.c (sparc_unwind_pc): Delete.
2267         (sparc32_gdbarch_init): Don't register deleted function with
2268         gdbarch.
2269
2270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2271
2272         * sh-tdep.c (sh_unwind_sp): Delete.
2273         (sh_unwind_pc): Delete.
2274         (sh_dummy_id): Delete.
2275         (sh_gdbarch_init): Don't register deleted functions with
2276         gdbarch.
2277
2278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         * score-tdep.c (score_unwind_sp): Delete.
2281         (score_unwind_pc): Delete.
2282         (score_dummy_id): Delete.
2283         (score_gdbarch_init): Don't register deleted functions with
2284         gdbarch.
2285
2286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * rx-tdep.c (rx_unwind_pc): Delete.
2289         (rx_unwind_sp): Delete.
2290         (rx_dummy_id): Delete.
2291         (rx_gdbarch_init): Don't register deleted functions with
2292         gdbarch.  Update comment.
2293
2294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2297         (rs6000_dummy_id): Delete.
2298         (rs6000_gdbarch_init): Don't register deleted functions with
2299         gdbarch.
2300
2301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2302
2303         * or1k-tdep.c (or1k_dummy_id): Delete.
2304         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2305
2306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * nios2-tdep.c (nios2_dummy_id): Delete.
2309         (nios2_unwind_sp): Delete.
2310         (nios2_gdbarch_init): Don't register deleted functions with
2311         gdbarch.
2312
2313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * nds32-tdep.c (nds32_dummy_id): Delete.
2316         (nds32_unwind_pc): Delete.
2317         (nds32_unwind_sp): Delete.
2318         (nds32_gdbarch_init): Don't register deleted functions with
2319         gdbarch.
2320
2321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2322
2323         * msp430-tdep.c (msp430_unwind_pc): Delete.
2324         (msp430_unwind_sp): Delete.
2325         (msp430_dummy_id): Delete.
2326         (msp430_gdbarch_init): Don't register deleted functions with
2327         gdbarch.
2328
2329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2330
2331         * moxie-tdep.c (moxie_unwind_sp): Delete.
2332         (moxie_unwind_pc): Delete.
2333         (moxie_dummy_id): Delete.
2334         (moxie_gdbarch_init): Don't register deleted functions with
2335         gdbarch.
2336
2337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2338
2339         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2340         (mn10300_unwind_pc): Delete.
2341         (mn10300_unwind_sp): Delete.
2342         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2343         mn10300_unwind_sp.
2344         (mn10300_frame_unwind_init): Don't register deleted functions with
2345         gdbarch.
2346
2347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * mep-tdep.c (mep_unwind_pc): Delete.
2350         (mep_unwind_sp): Delete.
2351         (mep_dummy_id): Delete.
2352         (mep_gdbarch_init): Don't register deleted functions with
2353         gdbarch.
2354
2355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2356
2357         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2358         (m68hc11_unwind_sp): Delete.
2359         (m68hc11_gdbarch_init): Don't register deleted functions with
2360         gdbarch.
2361
2362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * m32r-tdep.c (m32r_unwind_sp): Delete.
2365         (m32r_unwind_pc): Delete.
2366         (m32r_dummy_id): Delete.
2367         (m32r_gdbarch_init): Don't register deleted functions with
2368         gdbarch.
2369
2370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2371
2372         * m32c-tdep.c (m32c_unwind_pc): Delete.
2373         (m32c_unwind_sp): Delete.
2374         (m32c_dummy_id): Delete.
2375         (m32c_gdbarch_init): Don't register deleted functions with
2376         gdbarch.
2377
2378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2379
2380         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2381         (lm32_unwind_pc): Delete.
2382         (lm32_dummy_id): Delete.
2383         (lm32_gdbarch_init): Don't register deleted functions with
2384         gdbarch.
2385
2386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2387
2388         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2389         (iq2000_unwind_pc): Delete.
2390         (iq2000_dummy_id): Delete.
2391         (iq2000_gdbarch_init): Don't register deleted functions with
2392         gdbarch.
2393
2394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * nds32-tdep.c (nds32_type_align): Delete.
2397         (nds32_push_dummy_call): Use type_align instead.
2398
2399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2400
2401         * arm-tdep.c (arm_type_align): Only handle vector override case.
2402         (arm_push_dummy_call): Use type_align.
2403         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2404
2405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2406
2407         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2408         case.
2409         (pass_on_stack): Use type_align.
2410         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2411         function.
2412
2413 2019-04-23  Tom Tromey  <tromey@adacore.com>
2414
2415         * dwarf2read.c (line_header::file_name_at): Remove unused
2416         overload.
2417
2418 2019-04-23  Tom de Vries  <tdevries@suse.de>
2419
2420         PR gdb/24438
2421         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2422         invocation.
2423
2424
2425 2019-03-27  Ali Tamur  <tamur@google.com>
2426
2427         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2428         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2429         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2430         (dwarf_expr_context::get_addr_index): Likewise
2431         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2432         (symbol_needs_eval_context::get_addr_index): Likewise
2433         (disassemble_dwarf_expression): Add DW_OP_addrx
2434         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2435         (read_cutu_die_from_dwo): Update comment
2436         (skip_one_die): Add DW_FORM_addrx
2437         (read_attribute_value): Likewise
2438         (var_decode_location): Add DW_OP_addrx
2439         (dwarf2_const_value_attr): Add DW_FORM_addrx
2440         (dump_die_shallow): Likewise
2441         (dwarf2_fetch_constant_bytes): Likewise
2442         (decode_locdesc): Add DW_OP_addrx
2443         (skip_form_bytes): Add DW_FORM_addrx
2444
2445 2019-04-22  Ali Tamur  <tamur@google.com>
2446
2447         * MAINTAINERS (Write After Approval): Add self.
2448
2449 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2450
2451         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2452         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2453         (open_symbol_file_object): Likewise.
2454         (svr4_default_sos): Add info parameter.
2455         (svr4_read_so_list): Likewise.
2456         (svr4_current_sos_direct): Adjust functions calls to pass down
2457         info.
2458         (svr4_current_sos_1): Add info parameter.
2459         (svr4_current_sos): Call get_svr4_info, pass info down to
2460         svr4_current_sos_1.
2461         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2462         get_svr4_info.
2463         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2464         get_svr4_info.
2465         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2466         to get_svr4_info.
2467         (probes_table_remove_objfile_probes): Likewise.
2468         (register_solib_event_probe): Add info parameter.
2469         (solist_update_incremental): Pass info parameter down to
2470         svr4_read_so_list.
2471         (disable_probes_interface): Add info parameter.
2472         (svr4_handle_solib_event): Pass current_program_space to
2473         get_svr4_info.  Adjust disable_probes_interface cleanup.
2474         (svr4_create_probe_breakpoints): Add info parameter, pass it
2475         down to register_solib_event_probe.
2476         (svr4_create_solib_event_breakpoints): Add info parameter,
2477         pass it down to svr4_create_probe_breakpoints.
2478         (enable_break): Pass info down to
2479         svr4_create_solib_event_breakpoints.
2480         (svr4_solib_create_inferior_hook): Pass current_program_space to
2481         get_svr4_info.
2482         (svr4_clear_solib): Likewise.
2483
2484 2019-04-22  Pedro Alves  <palves@redhat.com>
2485
2486         * solib-svr4.c (svr4_free_objfile_observer): New.
2487         (probe_and_action::objfile): New field.
2488         (probes_table_htab_remove_objfile_probes)
2489         (probes_table_remove_objfile_probes): New functions.
2490         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2491         in the new probe_and_action.  Don't store the probe in 'lookup'.
2492         (svr4_create_probe_breakpoints): Pass objfile to
2493         register_solib_event_probe.
2494         (_initialize_svr4_solib): Register a free_objfile observer.
2495
2496 2019-04-19  Tom Tromey  <tom@tromey.com>
2497
2498         * common/queue.h: Remove.
2499
2500 2019-04-19  Tom Tromey  <tom@tromey.com>
2501
2502         * event-loop.c: Don't include "common/queue.h".
2503
2504 2019-04-19  Tom Tromey  <tom@tromey.com>
2505
2506         * remote.c (remote_target): Use delete.
2507         * remote-notif.h: Include <list>, not "common/queue.h".
2508         (notif_client_p): Remove typedef.
2509         (remote_notif_state): Add constructor, destructor, initializer.
2510         <notif_queue>: Now a std::list.
2511         (remote_notif_state_xfree): Don't declare.
2512         * remote-notif.c (remote_notif_process, handle_notification)
2513         (remote_notif_state_allocate): Update.
2514         (~remote_notif_state): Rename from remote_notif_state_xfree.
2515
2516 2019-04-19  Tom Tromey  <tom@tromey.com>
2517
2518         * symfile.c (reread_symbols): Update.
2519         * objfiles.c (objfile_register_static_link)
2520         (objfile_lookup_static_link): Update
2521         (~objfile) Don't delete static_links.
2522         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2523
2524 2019-04-19  Tom Tromey  <tom@tromey.com>
2525
2526         * type-stack.h (struct type_stack) <insert>: Constify string.
2527         * type-stack.c (type_stack::insert): Constify string.
2528         * gdbtypes.h (lookup_template_type): Update.
2529         (address_space_name_to_int): Update.
2530         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2531         const.
2532         (lookup_template_type): Make name const.
2533         * c-exp.y: Update rules.
2534         (lex_one_token, classify_name, classify_inner_name)
2535         (c_print_token): Update.
2536         * p-exp.y: Update rules.
2537         (yylex): Update.
2538         * f-exp.y: Update rules.
2539         (yylex): Update.
2540         * d-exp.y: Update rules.
2541         (lex_one_token, classify_name, classify_inner_name): Update.
2542         * parse.c (write_dollar_variable, copy_name): Return std::string.
2543         * parser-defs.h (copy_name): Change return type.
2544         * m2-exp.y: Update rules.
2545         (yylex): Update.
2546         * go-exp.y (lex_one_token): Update.
2547         Update rules.
2548         (classify_unsafe_function, classify_packaged_name)
2549         (classify_name, yylex): Update.
2550
2551 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2552
2553         * configure.ac: add --enable-source-highlight switch.
2554         * configure: Regenerate.
2555         * top.c (print_gdb_version): plumb --enable-source-highlight
2556         status to "show configuration".
2557
2558 2019-04-19  Tom Tromey  <tromey@adacore.com>
2559
2560         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2561         Check ADA_TYPE_P.
2562         (empty_record, ada_template_to_fixed_record_type_1)
2563         (template_to_static_fixed_type)
2564         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2565         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2566         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2567         macros.
2568
2569 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2570
2571         PR symtab/24423:
2572         * source.c (print_source_lines_base): Advance "iter" when a
2573         control character is seen.
2574
2575 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2576
2577         * inferior.h (struct infcall_suspend_state_deleter):
2578         Catch exception in destructor to avoid crash.
2579
2580 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2581
2582         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2583         close to the add_com "shell".
2584
2585 2019-04-18  Tom Tromey  <tromey@adacore.com>
2586
2587         * process-stratum-target.h (class process_stratum_target)
2588         <stratum>: Add "final".
2589
2590 2019-04-17  Tom Tromey  <tromey@adacore.com>
2591
2592         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2593         against nullptr before use.
2594
2595 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2596
2597         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2598
2599 2019-04-17  Jim Wilson  <jimw@sifive.com>
2600             Andrew Burgess  <andrew.burgess@embecosm.com>
2601
2602         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2603         code read might fail, assume 4-byte breakpoint in that case.
2604
2605 2019-04-15  Leszek Swirski  <leszeks@google.com>
2606
2607         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2608         rather than a hand-rolled POD check when checking for forced MEMORY
2609         classification.
2610
2611 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2612
2613         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2614         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2615         function.
2616         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2617         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2618         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2619         declaration.
2620
2621 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2622
2623         * aarch64-linux-nat.c
2624         (aarch64_linux_nat_target::thread_architecture): Add override.
2625         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2626         each VQ.
2627
2628 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2629
2630         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2631
2632 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2633
2634         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2635         target types of size 96-bits, add some additional comments, and
2636         check that the builtin type we found was the correct size.
2637
2638 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2639
2640         * utils.c (prompt_for_continue): Don't restore the styling at the
2641         end, as applied_style has the wrong value.  This fixes styling in
2642         long lists of file names that are interrupted by the "Continue?"
2643         prompt.
2644
2645 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2646
2647         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2648         * c-lang.c (c_language_defn): Likewise.
2649         (cplus_language_defn): Likewise.
2650         (asm_language_defn): Likewise.
2651         (minimal_language_defn): Likewise.
2652         * d-lang.c (d_language_defn): Likewise.
2653         * f-lang.c (f_language_defn): Likewise.
2654         * go-lang.c (go_language_defn): Likewise.
2655         * language.c (unknown_language_defn): Likewise.
2656         (auto_language_defn): Likewise.
2657         * language.h (struct language_defn): Remove la_magic field.
2658         (LANG_MAGIC): Delete.
2659         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2660         * objc-lang.c (objc_language_defn): Likewise.
2661         * opencl-lang.c (opencl_language_defn): Likewise.
2662         * p-lang.c (pascal_language_defn): Likewise.
2663         * rust-lang.c (rust_language_defn): Likewise.
2664
2665 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * riscv-tdep.c (riscv_type_align): New function.
2668         (riscv_type_alignment): Delete.
2669         (riscv_arg_location): Use 'type_align'.
2670         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2671
2672 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2673
2674         * gdbtypes.c (type_align): A struct with no non-static fields also
2675         has alignment of 1.
2676
2677 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2680         component to 0.
2681         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2682         member.
2683         (riscv_struct_info::analyse): New implementation using new
2684         analyse_inner member function.
2685         (riscv_struct_info::field_offset): New member function.
2686         (riscv_struct_info::m_offsets): New member variable.
2687         (riscv_struct_info::analyse_inner): New private member function,
2688         takes the old implementation of riscv_struct_info::analyse but
2689         extended to track field offsets.
2690         (riscv_call_arg_struct): Update the struct folding special cases
2691         to handle cases where empty C++ structs, which are non-zero
2692         length, are found.
2693         (riscv_arg_location): Initialise the length of each location, a
2694         non-zero length now indicates the location is in use.
2695         (riscv_push_dummy_call): Allow for the first location having a
2696         non-zero offset when setting up arguments.
2697         (riscv_return_value): Likewise, but for return values.
2698
2699 2019-04-11  Tom Tromey  <tromey@adacore.com>
2700
2701         * utils.c (internal_vproblem): Make "msg" const.
2702
2703 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2704
2705         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2706         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2707         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2708         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2709
2710 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2711
2712         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2713         function.
2714         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2715         of amd64_collect_native_gregset.
2716         (amd64_linux_nat_target::store_registers): Likewise.
2717
2718 2019-04-10  Tom Tromey  <tom@tromey.com>
2719
2720         * symtab.c (lookup_global_symbol_from_objfile)
2721         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2722         * objfiles.h (class separate_debug_iterator): New.
2723         (class separate_debug_range): New.
2724         (struct objfile) <separate_debug_objfiles>: New method.
2725         (objfile_separate_debug_iterate): Don't declare.
2726         * objfiles.c (separate_debug_iterator::operator++): Rename from
2727         objfile_separate_debug_iterate.
2728         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2729         iterator.
2730         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2731         iterator.
2732
2733 2019-04-10  Tom Tromey  <tom@tromey.com>
2734
2735         * symfile.c (reread_symbols): Remove old comment.
2736         * objfiles.c (free_all_objfiles): Fix a typo.
2737
2738 2019-04-10  Tom Tromey  <tom@tromey.com>
2739
2740         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2741         * minsyms.c (lookup_minimal_symbol): Use foreach.
2742         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2743         (lookup_minimal_symbol_solib_trampoline): Likewise.
2744         * symfile.c (reread_symbols): Use foreach.
2745
2746 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2747             Tom Tromey  <tromey@adacore.com>
2748
2749         PR rust/24414:
2750         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2751         (rust_lex_int_test): Change "value" to be LONGEST.
2752         (rust_lex_tests): Add test for long integer literal.
2753
2754 2019-04-09  Tom Tromey  <tromey@adacore.com>
2755
2756         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2757         to bool.
2758         (extended_remote_target::attach): Update.
2759         (remote_target::remote_notice_new_inferior): Update.
2760         (remote_target::add_current_inferior_and_thread): Update.
2761         * inferior.c (exit_inferior_1): Use "false".
2762         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2763
2764 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2765
2766         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2767         the "start" command.
2768
2769 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2770
2771         * python/py-inferior.c (infpy_thread_from_thread_handle):
2772         Adjust comments to reflect renaming of thread_from_thread_handle
2773         to thread_from_handle.  Adjust keywords.  Fix type error message.
2774         (inferior_object_methods): Add thread_from_handle.  Retain
2775         thread_from_thread_handle, but mark it as deprecated.
2776
2777 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2778
2779         * gdbthread.h (find_thread_by_handle): Revise declaration.
2780         * thread.c (find_thread_by_handle): Likewise.  Adjust
2781         implementation too.
2782         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2783         support for buffer objects as handles.
2784
2785 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2786
2787         * python/py-infthread.c (thpy_thread_handle): New function.
2788         (thread_object_methods): Register thpy_thread_handle.
2789
2790 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2791
2792         * gdbthread.h (thread_to_thread_handle): Declare.
2793         * thread.c (gdbtypes.h): Include.
2794         (thread_to_thread_handle): New function.
2795
2796         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2797         (target_thread_info_to_thread_handle): Declare.
2798         * target.c (target_thread_info_to_thread_handle): New function.
2799         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2800         * target-delegates.c: Regenerate.
2801
2802         * linux-thread-db.c (class thread_db_target): Add method
2803         thread_info_to_thread_handle.
2804         (thread_db_target::thread_info_to_thread_handle): Define.
2805         * remote.c (class remote_target): Add new method
2806         thread_info_to_thread_handle.
2807         (remote_target::thread_info_to_thread_handle): Define.
2808
2809 2019-04-08  Pedro Alves  <palves@redhat.com>
2810
2811         * common/common-exceptions.c (throw_exception): Don't create
2812         named object to throw; throw directly.
2813         (throw_it): Likewise.  Don't initialize gdb_exception::message
2814         here, with new; pass FMT and AP to the ctor instead.
2815         * common/common-exceptions.h: Include <string>.
2816         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2817         const char *, va_list)): New ctor.  Use std::make_shared.
2818         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2819         errors)): Delete.
2820         (gdb_exception_error::gdb_exception_error(enum errors, const char
2821         *, va_list)): New.
2822         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2823         Add assertion.
2824         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2825         errors)): Delete.
2826         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2827         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2828         Add assertion.
2829
2830 2019-04-08  Tom Tromey  <tom@tromey.com>
2831
2832         * valops.c (value_rtti_indirect_type): Replace throw_exception
2833         with throw.
2834         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2835         with throw.
2836         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2837         throw.
2838         * target.c (target_translate_tls_address): Replace throw_exception
2839         with throw.
2840         * stack.c (frame_apply_command_count): Replace throw_exception
2841         with throw.
2842         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2843         throw.
2844         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2845         with throw.
2846         * rs6000-tdep.c (rs6000_frame_cache)
2847         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2848         * remote.c: Replace throw_exception with throw.
2849         * record-full.c (record_full_message, record_full_wait_1)
2850         (record_full_restore): Replace throw_exception with throw.
2851         * record-btrace.c:
2852         (get_thread_current_frame_id, record_btrace_start_replaying)
2853         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2854         (cmd_record_btrace_start): Replace throw_exception with throw.
2855         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2856         throw.
2857         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2858         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2859         * linespec.c:
2860         (find_linespec_symbols): Replace throw_exception with throw.
2861         * infrun.c (displaced_step_prepare, resume): Replace
2862         throw_exception with throw.
2863         * infcmd.c (post_create_inferior): Replace throw_exception with
2864         throw.
2865         * inf-loop.c (inferior_event_handler): Replace throw_exception
2866         with throw.
2867         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2868         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2869         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2870         (get_prev_frame_always, get_frame_pc_if_available)
2871         (get_frame_address_in_block_if_available, get_frame_language):
2872         Replace throw_exception with throw.
2873         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2874         throw_exception with throw.
2875         * eval.c (fetch_subexp_value, evaluate_var_value)
2876         (evaluate_funcall, evaluate_subexp_standard): Replace
2877         throw_exception with throw.
2878         * dwarf2loc.c (call_site_find_chain)
2879         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2880         Replace throw_exception with throw.
2881         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2882         with throw.
2883         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2884         throw.
2885         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2886         * completer.c (complete_line_internal): Replace throw_exception
2887         with throw.
2888         * compile/compile-object-run.c (compile_object_run): Replace
2889         throw_exception with throw.
2890         * cli/cli-script.c (process_next_line): Replace throw_exception
2891         with throw.
2892         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2893         (btrace_enable, btrace_maint_update_pt_packets): Replace
2894         throw_exception with throw.
2895         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2896         throw_exception with throw.
2897         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2898         throw_exception with throw.
2899         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2900         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2901         * aarch64-tdep.c (aarch64_make_prologue_cache)
2902         (aarch64_make_stub_cache): Replace throw_exception with throw.
2903
2904 2019-04-08  Tom Tromey  <tom@tromey.com>
2905
2906         * common/common-exceptions.c (throw_exception): Rename from
2907         throw_exception_cxx.  Remove old copy.  Make argument const.
2908         (throw_it): Create and throw exception objects directly.
2909         * common/common-exceptions.h (throw_exception): Make argument
2910         const.
2911         (struct gdb_exception_error): Add constructor.
2912         (struct gdb_exception_quit): Add constructor.
2913
2914 2019-04-08  Tom Tromey  <tom@tromey.com>
2915
2916         * common/common-exceptions.h (exception_rethrow): Don't declare.
2917         (TRY_SJLJ): Update comment.
2918         (TRY, CATCH, END_CATCH): Remove.
2919         * common/common-exceptions.c (exception_rethrow): Remove.
2920
2921 2019-04-08  Tom Tromey  <tom@tromey.com>
2922
2923         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2924         Remove.
2925         (gdb_exception_error): Rename from
2926         gdb_exception_RETURN_MASK_ERROR.
2927         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2928         (gdb_quit_bad_alloc): Update.
2929         * aarch64-tdep.c: Update.
2930         * ada-lang.c: Update.
2931         * ada-typeprint.c: Update.
2932         * ada-valprint.c: Update.
2933         * amd64-tdep.c: Update.
2934         * arch-utils.c: Update.
2935         * break-catch-throw.c: Update.
2936         * breakpoint.c: Update.
2937         * btrace.c: Update.
2938         * c-varobj.c: Update.
2939         * cli/cli-cmds.c: Update.
2940         * cli/cli-interp.c: Update.
2941         * cli/cli-script.c: Update.
2942         * common/common-exceptions.c: Update.
2943         * common/new-op.c: Update.
2944         * common/selftest.c: Update.
2945         * compile/compile-c-symbols.c: Update.
2946         * compile/compile-cplus-symbols.c: Update.
2947         * compile/compile-object-load.c: Update.
2948         * compile/compile-object-run.c: Update.
2949         * completer.c: Update.
2950         * corelow.c: Update.
2951         * cp-abi.c: Update.
2952         * cp-support.c: Update.
2953         * cp-valprint.c: Update.
2954         * darwin-nat.c: Update.
2955         * disasm-selftests.c: Update.
2956         * dtrace-probe.c: Update.
2957         * dwarf-index-cache.c: Update.
2958         * dwarf-index-write.c: Update.
2959         * dwarf2-frame-tailcall.c: Update.
2960         * dwarf2-frame.c: Update.
2961         * dwarf2loc.c: Update.
2962         * dwarf2read.c: Update.
2963         * eval.c: Update.
2964         * event-loop.c: Update.
2965         * event-top.c: Update.
2966         * exec.c: Update.
2967         * f-valprint.c: Update.
2968         * fbsd-tdep.c: Update.
2969         * frame-unwind.c: Update.
2970         * frame.c: Update.
2971         * gdbtypes.c: Update.
2972         * gnu-v3-abi.c: Update.
2973         * guile/guile-internal.h: Update.
2974         * guile/scm-block.c: Update.
2975         * guile/scm-breakpoint.c: Update.
2976         * guile/scm-cmd.c: Update.
2977         * guile/scm-disasm.c: Update.
2978         * guile/scm-frame.c: Update.
2979         * guile/scm-lazy-string.c: Update.
2980         * guile/scm-math.c: Update.
2981         * guile/scm-param.c: Update.
2982         * guile/scm-ports.c: Update.
2983         * guile/scm-pretty-print.c: Update.
2984         * guile/scm-symbol.c: Update.
2985         * guile/scm-symtab.c: Update.
2986         * guile/scm-type.c: Update.
2987         * guile/scm-value.c: Update.
2988         * i386-linux-tdep.c: Update.
2989         * i386-tdep.c: Update.
2990         * inf-loop.c: Update.
2991         * infcall.c: Update.
2992         * infcmd.c: Update.
2993         * infrun.c: Update.
2994         * jit.c: Update.
2995         * language.c: Update.
2996         * linespec.c: Update.
2997         * linux-fork.c: Update.
2998         * linux-nat.c: Update.
2999         * linux-tdep.c: Update.
3000         * linux-thread-db.c: Update.
3001         * main.c: Update.
3002         * mi/mi-cmd-break.c: Update.
3003         * mi/mi-cmd-stack.c: Update.
3004         * mi/mi-interp.c: Update.
3005         * mi/mi-main.c: Update.
3006         * objc-lang.c: Update.
3007         * p-valprint.c: Update.
3008         * parse.c: Update.
3009         * ppc-linux-tdep.c: Update.
3010         * printcmd.c: Update.
3011         * python/py-arch.c: Update.
3012         * python/py-breakpoint.c: Update.
3013         * python/py-cmd.c: Update.
3014         * python/py-finishbreakpoint.c: Update.
3015         * python/py-frame.c: Update.
3016         * python/py-framefilter.c: Update.
3017         * python/py-gdb-readline.c: Update.
3018         * python/py-inferior.c: Update.
3019         * python/py-infthread.c: Update.
3020         * python/py-lazy-string.c: Update.
3021         * python/py-linetable.c: Update.
3022         * python/py-objfile.c: Update.
3023         * python/py-param.c: Update.
3024         * python/py-prettyprint.c: Update.
3025         * python/py-progspace.c: Update.
3026         * python/py-record-btrace.c: Update.
3027         * python/py-record.c: Update.
3028         * python/py-symbol.c: Update.
3029         * python/py-type.c: Update.
3030         * python/py-unwind.c: Update.
3031         * python/py-utils.c: Update.
3032         * python/py-value.c: Update.
3033         * python/python.c: Update.
3034         * record-btrace.c: Update.
3035         * record-full.c: Update.
3036         * remote-fileio.c: Update.
3037         * remote.c: Update.
3038         * riscv-tdep.c: Update.
3039         * rs6000-aix-tdep.c: Update.
3040         * rs6000-tdep.c: Update.
3041         * rust-exp.y: Update.
3042         * rust-lang.c: Update.
3043         * s390-tdep.c: Update.
3044         * selftest-arch.c: Update.
3045         * solib-dsbt.c: Update.
3046         * solib-frv.c: Update.
3047         * solib-spu.c: Update.
3048         * solib-svr4.c: Update.
3049         * solib.c: Update.
3050         * sparc64-linux-tdep.c: Update.
3051         * stack.c: Update.
3052         * symfile-mem.c: Update.
3053         * symmisc.c: Update.
3054         * target.c: Update.
3055         * thread.c: Update.
3056         * top.c: Update.
3057         * tracefile-tfile.c: Update.
3058         * tui/tui.c: Update.
3059         * typeprint.c: Update.
3060         * unittests/cli-utils-selftests.c: Update.
3061         * unittests/parse-connection-spec-selftests.c: Update.
3062         * valops.c: Update.
3063         * valprint.c: Update.
3064         * value.c: Update.
3065         * varobj.c: Update.
3066         * windows-nat.c: Update.
3067         * x86-linux-nat.c: Update.
3068         * xml-support.c: Update.
3069
3070 2019-04-08  Tom Tromey  <tom@tromey.com>
3071
3072         * xml-support.c: Use C++ exception handling.
3073         * x86-linux-nat.c: Use C++ exception handling.
3074         * windows-nat.c: Use C++ exception handling.
3075         * varobj.c: Use C++ exception handling.
3076         * value.c: Use C++ exception handling.
3077         * valprint.c: Use C++ exception handling.
3078         * valops.c: Use C++ exception handling.
3079         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3080         handling.
3081         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3082         * typeprint.c: Use C++ exception handling.
3083         * tui/tui.c: Use C++ exception handling.
3084         * tracefile-tfile.c: Use C++ exception handling.
3085         * top.c: Use C++ exception handling.
3086         * thread.c: Use C++ exception handling.
3087         * target.c: Use C++ exception handling.
3088         * symmisc.c: Use C++ exception handling.
3089         * symfile-mem.c: Use C++ exception handling.
3090         * stack.c: Use C++ exception handling.
3091         * sparc64-linux-tdep.c: Use C++ exception handling.
3092         * solib.c: Use C++ exception handling.
3093         * solib-svr4.c: Use C++ exception handling.
3094         * solib-spu.c: Use C++ exception handling.
3095         * solib-frv.c: Use C++ exception handling.
3096         * solib-dsbt.c: Use C++ exception handling.
3097         * selftest-arch.c: Use C++ exception handling.
3098         * s390-tdep.c: Use C++ exception handling.
3099         * rust-lang.c: Use C++ exception handling.
3100         * rust-exp.y: Use C++ exception handling.
3101         * rs6000-tdep.c: Use C++ exception handling.
3102         * rs6000-aix-tdep.c: Use C++ exception handling.
3103         * riscv-tdep.c: Use C++ exception handling.
3104         * remote.c: Use C++ exception handling.
3105         * remote-fileio.c: Use C++ exception handling.
3106         * record-full.c: Use C++ exception handling.
3107         * record-btrace.c: Use C++ exception handling.
3108         * python/python.c: Use C++ exception handling.
3109         * python/py-value.c: Use C++ exception handling.
3110         * python/py-utils.c: Use C++ exception handling.
3111         * python/py-unwind.c: Use C++ exception handling.
3112         * python/py-type.c: Use C++ exception handling.
3113         * python/py-symbol.c: Use C++ exception handling.
3114         * python/py-record.c: Use C++ exception handling.
3115         * python/py-record-btrace.c: Use C++ exception handling.
3116         * python/py-progspace.c: Use C++ exception handling.
3117         * python/py-prettyprint.c: Use C++ exception handling.
3118         * python/py-param.c: Use C++ exception handling.
3119         * python/py-objfile.c: Use C++ exception handling.
3120         * python/py-linetable.c: Use C++ exception handling.
3121         * python/py-lazy-string.c: Use C++ exception handling.
3122         * python/py-infthread.c: Use C++ exception handling.
3123         * python/py-inferior.c: Use C++ exception handling.
3124         * python/py-gdb-readline.c: Use C++ exception handling.
3125         * python/py-framefilter.c: Use C++ exception handling.
3126         * python/py-frame.c: Use C++ exception handling.
3127         * python/py-finishbreakpoint.c: Use C++ exception handling.
3128         * python/py-cmd.c: Use C++ exception handling.
3129         * python/py-breakpoint.c: Use C++ exception handling.
3130         * python/py-arch.c: Use C++ exception handling.
3131         * printcmd.c: Use C++ exception handling.
3132         * ppc-linux-tdep.c: Use C++ exception handling.
3133         * parse.c: Use C++ exception handling.
3134         * p-valprint.c: Use C++ exception handling.
3135         * objc-lang.c: Use C++ exception handling.
3136         * mi/mi-main.c: Use C++ exception handling.
3137         * mi/mi-interp.c: Use C++ exception handling.
3138         * mi/mi-cmd-stack.c: Use C++ exception handling.
3139         * mi/mi-cmd-break.c: Use C++ exception handling.
3140         * main.c: Use C++ exception handling.
3141         * linux-thread-db.c: Use C++ exception handling.
3142         * linux-tdep.c: Use C++ exception handling.
3143         * linux-nat.c: Use C++ exception handling.
3144         * linux-fork.c: Use C++ exception handling.
3145         * linespec.c: Use C++ exception handling.
3146         * language.c: Use C++ exception handling.
3147         * jit.c: Use C++ exception handling.
3148         * infrun.c: Use C++ exception handling.
3149         * infcmd.c: Use C++ exception handling.
3150         * infcall.c: Use C++ exception handling.
3151         * inf-loop.c: Use C++ exception handling.
3152         * i386-tdep.c: Use C++ exception handling.
3153         * i386-linux-tdep.c: Use C++ exception handling.
3154         * guile/scm-value.c: Use C++ exception handling.
3155         * guile/scm-type.c: Use C++ exception handling.
3156         * guile/scm-symtab.c: Use C++ exception handling.
3157         * guile/scm-symbol.c: Use C++ exception handling.
3158         * guile/scm-pretty-print.c: Use C++ exception handling.
3159         * guile/scm-ports.c: Use C++ exception handling.
3160         * guile/scm-param.c: Use C++ exception handling.
3161         * guile/scm-math.c: Use C++ exception handling.
3162         * guile/scm-lazy-string.c: Use C++ exception handling.
3163         * guile/scm-frame.c: Use C++ exception handling.
3164         * guile/scm-disasm.c: Use C++ exception handling.
3165         * guile/scm-cmd.c: Use C++ exception handling.
3166         * guile/scm-breakpoint.c: Use C++ exception handling.
3167         * guile/scm-block.c: Use C++ exception handling.
3168         * guile/guile-internal.h: Use C++ exception handling.
3169         * gnu-v3-abi.c: Use C++ exception handling.
3170         * gdbtypes.c: Use C++ exception handling.
3171         * frame.c: Use C++ exception handling.
3172         * frame-unwind.c: Use C++ exception handling.
3173         * fbsd-tdep.c: Use C++ exception handling.
3174         * f-valprint.c: Use C++ exception handling.
3175         * exec.c: Use C++ exception handling.
3176         * event-top.c: Use C++ exception handling.
3177         * event-loop.c: Use C++ exception handling.
3178         * eval.c: Use C++ exception handling.
3179         * dwarf2read.c: Use C++ exception handling.
3180         * dwarf2loc.c: Use C++ exception handling.
3181         * dwarf2-frame.c: Use C++ exception handling.
3182         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3183         * dwarf-index-write.c: Use C++ exception handling.
3184         * dwarf-index-cache.c: Use C++ exception handling.
3185         * dtrace-probe.c: Use C++ exception handling.
3186         * disasm-selftests.c: Use C++ exception handling.
3187         * darwin-nat.c: Use C++ exception handling.
3188         * cp-valprint.c: Use C++ exception handling.
3189         * cp-support.c: Use C++ exception handling.
3190         * cp-abi.c: Use C++ exception handling.
3191         * corelow.c: Use C++ exception handling.
3192         * completer.c: Use C++ exception handling.
3193         * compile/compile-object-run.c: Use C++ exception handling.
3194         * compile/compile-object-load.c: Use C++ exception handling.
3195         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3196         * compile/compile-c-symbols.c: Use C++ exception handling.
3197         * common/selftest.c: Use C++ exception handling.
3198         * common/new-op.c: Use C++ exception handling.
3199         * cli/cli-script.c: Use C++ exception handling.
3200         * cli/cli-interp.c: Use C++ exception handling.
3201         * cli/cli-cmds.c: Use C++ exception handling.
3202         * c-varobj.c: Use C++ exception handling.
3203         * btrace.c: Use C++ exception handling.
3204         * breakpoint.c: Use C++ exception handling.
3205         * break-catch-throw.c: Use C++ exception handling.
3206         * arch-utils.c: Use C++ exception handling.
3207         * amd64-tdep.c: Use C++ exception handling.
3208         * ada-valprint.c: Use C++ exception handling.
3209         * ada-typeprint.c: Use C++ exception handling.
3210         * ada-lang.c: Use C++ exception handling.
3211         * aarch64-tdep.c: Use C++ exception handling.
3212
3213 2019-04-08  Tom Tromey  <tom@tromey.com>
3214
3215         * xml-support.c (gdb_xml_parser::parse): Update.
3216         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3217         * value.c (show_convenience): Update.
3218         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3219         (test_parse_flags_qcs): Update.
3220         * thread.c (thr_try_catch_cmd): Update.
3221         * target.c (target_translate_tls_address): Update.
3222         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3223         (info_frame_command_core, frame_apply_command_count): Update.
3224         * rust-exp.y (rust_lex_exception_test): Update.
3225         * riscv-tdep.c (riscv_print_one_register_info): Update.
3226         * remote.c (remote_target::enable_btrace): Update.
3227         * record-btrace.c (record_btrace_enable_warn): Update.
3228         * python/py-utils.c (gdbpy_convert_exception): Update.
3229         * printcmd.c (do_one_display, print_variable_and_value): Update.
3230         * mi/mi-main.c (mi_print_exception): Update.
3231         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3232         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3233         * linux-nat.c (linux_nat_target::attach): Update.
3234         * linux-fork.c (class scoped_switch_fork_info): Update.
3235         * infrun.c (displaced_step_prepare): Update.
3236         * infcall.c (call_function_by_hand_dummy): Update.
3237         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3238         * gnu-v3-abi.c (print_one_vtable): Update.
3239         * frame.c (get_prev_frame_always): Update.
3240         * f-valprint.c (info_common_command_for_block): Update.
3241         * exec.c (try_open_exec_file): Update.
3242         * exceptions.c (print_exception, exception_print)
3243         (exception_fprintf, exception_print_same): Update.
3244         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3245         * dwarf-index-cache.c (index_cache::store)
3246         (index_cache::lookup_gdb_index): Update.
3247         * darwin-nat.c (maybe_cache_shell): Update.
3248         * cp-valprint.c (cp_print_value_fields): Update.
3249         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3250         (gcc_cplus_symbol_address): Update.
3251         * compile/compile-c-symbols.c (gcc_convert_symbol)
3252         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3253         * common/selftest.c: Update.
3254         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3255         a std::string.
3256         (exception_try_scope_entry, exception_try_scope_exit): Don't
3257         declare.
3258         (struct exception_try_scope): Remove.
3259         (TRY): Don't use exception_try_scope.
3260         (struct gdb_exception): Add constructor, operator=.
3261         <what>: New method.
3262         (struct gdb_exception_RETURN_MASK_ALL)
3263         (struct gdb_exception_RETURN_MASK_ERROR)
3264         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3265         (struct gdb_quit_bad_alloc): Update.
3266         * common/common-exceptions.c (exception_none): Change
3267         initializer.
3268         (struct catcher) <state, exception>: Initialize inline.
3269         <prev>: Remove member.
3270         (current_catcher): Remove.
3271         (catchers): New global.
3272         (exceptions_state_mc_init): Simplify.
3273         (catcher_pop): Remove.
3274         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3275         (try_scope_depth, exception_try_scope_entry)
3276         (exception_try_scope_exit): Remove.
3277         (throw_exception_sjlj): Update.
3278         (exception_messages, exception_messages_size): Remove.
3279         (throw_it): Simplify.
3280         (gdb_exception_sliced_copy): Remove.
3281         (throw_exception_cxx): Update.
3282         * cli/cli-script.c (script_from_file): Update.
3283         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3284         Update.
3285         * ada-valprint.c (ada_val_print): Update.
3286         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3287         (create_excep_cond_exprs): Update.
3288
3289 2019-04-08  Tom Tromey  <tom@tromey.com>
3290
3291         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3292         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3293         (TRY, CATCH, END_CATCH): Remove some definitions.
3294         * common/common-exceptions.c: Don't use GDB_XCPT.
3295         (catcher_list_size): Remove.
3296         (throw_exception, throw_it): Simplify.
3297
3298 2019-04-05  Tom Tromey  <tom@tromey.com>
3299
3300         Revert the header-sorting patch.
3301         * ft32-tdep.c: Revert.
3302         * frv-tdep.c: Revert.
3303         * frv-linux-tdep.c: Revert.
3304         * frame.c: Revert.
3305         * frame-unwind.c: Revert.
3306         * frame-base.c: Revert.
3307         * fork-child.c: Revert.
3308         * findvar.c: Revert.
3309         * findcmd.c: Revert.
3310         * filesystem.c: Revert.
3311         * filename-seen-cache.h: Revert.
3312         * filename-seen-cache.c: Revert.
3313         * fbsd-tdep.c: Revert.
3314         * fbsd-nat.h: Revert.
3315         * fbsd-nat.c: Revert.
3316         * f-valprint.c: Revert.
3317         * f-typeprint.c: Revert.
3318         * f-lang.c: Revert.
3319         * extension.h: Revert.
3320         * extension.c: Revert.
3321         * extension-priv.h: Revert.
3322         * expprint.c: Revert.
3323         * exec.h: Revert.
3324         * exec.c: Revert.
3325         * exceptions.c: Revert.
3326         * event-top.c: Revert.
3327         * event-loop.c: Revert.
3328         * eval.c: Revert.
3329         * elfread.c: Revert.
3330         * dwarf2read.h: Revert.
3331         * dwarf2read.c: Revert.
3332         * dwarf2loc.c: Revert.
3333         * dwarf2expr.h: Revert.
3334         * dwarf2expr.c: Revert.
3335         * dwarf2-frame.c: Revert.
3336         * dwarf2-frame-tailcall.c: Revert.
3337         * dwarf-index-write.h: Revert.
3338         * dwarf-index-write.c: Revert.
3339         * dwarf-index-common.c: Revert.
3340         * dwarf-index-cache.h: Revert.
3341         * dwarf-index-cache.c: Revert.
3342         * dummy-frame.c: Revert.
3343         * dtrace-probe.c: Revert.
3344         * disasm.h: Revert.
3345         * disasm.c: Revert.
3346         * disasm-selftests.c: Revert.
3347         * dictionary.c: Revert.
3348         * dicos-tdep.c: Revert.
3349         * demangle.c: Revert.
3350         * dcache.h: Revert.
3351         * dcache.c: Revert.
3352         * darwin-nat.h: Revert.
3353         * darwin-nat.c: Revert.
3354         * darwin-nat-info.c: Revert.
3355         * d-valprint.c: Revert.
3356         * d-namespace.c: Revert.
3357         * d-lang.c: Revert.
3358         * ctf.c: Revert.
3359         * csky-tdep.c: Revert.
3360         * csky-linux-tdep.c: Revert.
3361         * cris-tdep.c: Revert.
3362         * cris-linux-tdep.c: Revert.
3363         * cp-valprint.c: Revert.
3364         * cp-support.c: Revert.
3365         * cp-namespace.c: Revert.
3366         * cp-abi.c: Revert.
3367         * corelow.c: Revert.
3368         * corefile.c: Revert.
3369         * continuations.c: Revert.
3370         * completer.h: Revert.
3371         * completer.c: Revert.
3372         * complaints.c: Revert.
3373         * coffread.c: Revert.
3374         * coff-pe-read.c: Revert.
3375         * cli-out.h: Revert.
3376         * cli-out.c: Revert.
3377         * charset.c: Revert.
3378         * c-varobj.c: Revert.
3379         * c-valprint.c: Revert.
3380         * c-typeprint.c: Revert.
3381         * c-lang.c: Revert.
3382         * buildsym.c: Revert.
3383         * buildsym-legacy.c: Revert.
3384         * build-id.h: Revert.
3385         * build-id.c: Revert.
3386         * btrace.c: Revert.
3387         * bsd-uthread.c: Revert.
3388         * breakpoint.h: Revert.
3389         * breakpoint.c: Revert.
3390         * break-catch-throw.c: Revert.
3391         * break-catch-syscall.c: Revert.
3392         * break-catch-sig.c: Revert.
3393         * blockframe.c: Revert.
3394         * block.c: Revert.
3395         * bfin-tdep.c: Revert.
3396         * bfin-linux-tdep.c: Revert.
3397         * bfd-target.c: Revert.
3398         * bcache.c: Revert.
3399         * ax-general.c: Revert.
3400         * ax-gdb.h: Revert.
3401         * ax-gdb.c: Revert.
3402         * avr-tdep.c: Revert.
3403         * auxv.c: Revert.
3404         * auto-load.c: Revert.
3405         * arm-wince-tdep.c: Revert.
3406         * arm-tdep.c: Revert.
3407         * arm-symbian-tdep.c: Revert.
3408         * arm-pikeos-tdep.c: Revert.
3409         * arm-obsd-tdep.c: Revert.
3410         * arm-nbsd-tdep.c: Revert.
3411         * arm-nbsd-nat.c: Revert.
3412         * arm-linux-tdep.c: Revert.
3413         * arm-linux-nat.c: Revert.
3414         * arm-fbsd-tdep.c: Revert.
3415         * arm-fbsd-nat.c: Revert.
3416         * arm-bsd-tdep.c: Revert.
3417         * arch-utils.c: Revert.
3418         * arc-tdep.c: Revert.
3419         * arc-newlib-tdep.c: Revert.
3420         * annotate.h: Revert.
3421         * annotate.c: Revert.
3422         * amd64-windows-tdep.c: Revert.
3423         * amd64-windows-nat.c: Revert.
3424         * amd64-tdep.c: Revert.
3425         * amd64-sol2-tdep.c: Revert.
3426         * amd64-obsd-tdep.c: Revert.
3427         * amd64-obsd-nat.c: Revert.
3428         * amd64-nbsd-tdep.c: Revert.
3429         * amd64-nbsd-nat.c: Revert.
3430         * amd64-nat.c: Revert.
3431         * amd64-linux-tdep.c: Revert.
3432         * amd64-linux-nat.c: Revert.
3433         * amd64-fbsd-tdep.c: Revert.
3434         * amd64-fbsd-nat.c: Revert.
3435         * amd64-dicos-tdep.c: Revert.
3436         * amd64-darwin-tdep.c: Revert.
3437         * amd64-bsd-nat.c: Revert.
3438         * alpha-tdep.c: Revert.
3439         * alpha-obsd-tdep.c: Revert.
3440         * alpha-nbsd-tdep.c: Revert.
3441         * alpha-mdebug-tdep.c: Revert.
3442         * alpha-linux-tdep.c: Revert.
3443         * alpha-linux-nat.c: Revert.
3444         * alpha-bsd-tdep.c: Revert.
3445         * alpha-bsd-nat.c: Revert.
3446         * aix-thread.c: Revert.
3447         * agent.c: Revert.
3448         * addrmap.c: Revert.
3449         * ada-varobj.c: Revert.
3450         * ada-valprint.c: Revert.
3451         * ada-typeprint.c: Revert.
3452         * ada-tasks.c: Revert.
3453         * ada-lang.c: Revert.
3454         * aarch64-tdep.c: Revert.
3455         * aarch64-ravenscar-thread.c: Revert.
3456         * aarch64-newlib-tdep.c: Revert.
3457         * aarch64-linux-tdep.c: Revert.
3458         * aarch64-linux-nat.c: Revert.
3459         * aarch64-fbsd-tdep.c: Revert.
3460         * aarch64-fbsd-nat.c: Revert.
3461         * aarch32-linux-nat.c: Revert.
3462
3463 2019-04-05  Tom Tromey  <tom@tromey.com>
3464
3465         * ft32-tdep.c: Sort headers.
3466         * frv-tdep.c: Sort headers.
3467         * frv-linux-tdep.c: Sort headers.
3468         * frame.c: Sort headers.
3469         * frame-unwind.c: Sort headers.
3470         * frame-base.c: Sort headers.
3471         * fork-child.c: Sort headers.
3472         * findvar.c: Sort headers.
3473         * findcmd.c: Sort headers.
3474         * filesystem.c: Sort headers.
3475         * filename-seen-cache.h: Sort headers.
3476         * filename-seen-cache.c: Sort headers.
3477         * fbsd-tdep.c: Sort headers.
3478         * fbsd-nat.h: Sort headers.
3479         * fbsd-nat.c: Sort headers.
3480         * f-valprint.c: Sort headers.
3481         * f-typeprint.c: Sort headers.
3482         * f-lang.c: Sort headers.
3483         * extension.h: Sort headers.
3484         * extension.c: Sort headers.
3485         * extension-priv.h: Sort headers.
3486         * expprint.c: Sort headers.
3487         * exec.h: Sort headers.
3488         * exec.c: Sort headers.
3489         * exceptions.c: Sort headers.
3490         * event-top.c: Sort headers.
3491         * event-loop.c: Sort headers.
3492         * eval.c: Sort headers.
3493         * elfread.c: Sort headers.
3494         * dwarf2read.h: Sort headers.
3495         * dwarf2read.c: Sort headers.
3496         * dwarf2loc.c: Sort headers.
3497         * dwarf2expr.h: Sort headers.
3498         * dwarf2expr.c: Sort headers.
3499         * dwarf2-frame.c: Sort headers.
3500         * dwarf2-frame-tailcall.c: Sort headers.
3501         * dwarf-index-write.h: Sort headers.
3502         * dwarf-index-write.c: Sort headers.
3503         * dwarf-index-common.c: Sort headers.
3504         * dwarf-index-cache.h: Sort headers.
3505         * dwarf-index-cache.c: Sort headers.
3506         * dummy-frame.c: Sort headers.
3507         * dtrace-probe.c: Sort headers.
3508         * disasm.h: Sort headers.
3509         * disasm.c: Sort headers.
3510         * disasm-selftests.c: Sort headers.
3511         * dictionary.c: Sort headers.
3512         * dicos-tdep.c: Sort headers.
3513         * demangle.c: Sort headers.
3514         * dcache.h: Sort headers.
3515         * dcache.c: Sort headers.
3516         * darwin-nat.h: Sort headers.
3517         * darwin-nat.c: Sort headers.
3518         * darwin-nat-info.c: Sort headers.
3519         * d-valprint.c: Sort headers.
3520         * d-namespace.c: Sort headers.
3521         * d-lang.c: Sort headers.
3522         * ctf.c: Sort headers.
3523         * csky-tdep.c: Sort headers.
3524         * csky-linux-tdep.c: Sort headers.
3525         * cris-tdep.c: Sort headers.
3526         * cris-linux-tdep.c: Sort headers.
3527         * cp-valprint.c: Sort headers.
3528         * cp-support.c: Sort headers.
3529         * cp-namespace.c: Sort headers.
3530         * cp-abi.c: Sort headers.
3531         * corelow.c: Sort headers.
3532         * corefile.c: Sort headers.
3533         * continuations.c: Sort headers.
3534         * completer.h: Sort headers.
3535         * completer.c: Sort headers.
3536         * complaints.c: Sort headers.
3537         * coffread.c: Sort headers.
3538         * coff-pe-read.c: Sort headers.
3539         * cli-out.h: Sort headers.
3540         * cli-out.c: Sort headers.
3541         * charset.c: Sort headers.
3542         * c-varobj.c: Sort headers.
3543         * c-valprint.c: Sort headers.
3544         * c-typeprint.c: Sort headers.
3545         * c-lang.c: Sort headers.
3546         * buildsym.c: Sort headers.
3547         * buildsym-legacy.c: Sort headers.
3548         * build-id.h: Sort headers.
3549         * build-id.c: Sort headers.
3550         * btrace.c: Sort headers.
3551         * bsd-uthread.c: Sort headers.
3552         * breakpoint.h: Sort headers.
3553         * breakpoint.c: Sort headers.
3554         * break-catch-throw.c: Sort headers.
3555         * break-catch-syscall.c: Sort headers.
3556         * break-catch-sig.c: Sort headers.
3557         * blockframe.c: Sort headers.
3558         * block.c: Sort headers.
3559         * bfin-tdep.c: Sort headers.
3560         * bfin-linux-tdep.c: Sort headers.
3561         * bfd-target.c: Sort headers.
3562         * bcache.c: Sort headers.
3563         * ax-general.c: Sort headers.
3564         * ax-gdb.h: Sort headers.
3565         * ax-gdb.c: Sort headers.
3566         * avr-tdep.c: Sort headers.
3567         * auxv.c: Sort headers.
3568         * auto-load.c: Sort headers.
3569         * arm-wince-tdep.c: Sort headers.
3570         * arm-tdep.c: Sort headers.
3571         * arm-symbian-tdep.c: Sort headers.
3572         * arm-pikeos-tdep.c: Sort headers.
3573         * arm-obsd-tdep.c: Sort headers.
3574         * arm-nbsd-tdep.c: Sort headers.
3575         * arm-nbsd-nat.c: Sort headers.
3576         * arm-linux-tdep.c: Sort headers.
3577         * arm-linux-nat.c: Sort headers.
3578         * arm-fbsd-tdep.c: Sort headers.
3579         * arm-fbsd-nat.c: Sort headers.
3580         * arm-bsd-tdep.c: Sort headers.
3581         * arch-utils.c: Sort headers.
3582         * arc-tdep.c: Sort headers.
3583         * arc-newlib-tdep.c: Sort headers.
3584         * annotate.h: Sort headers.
3585         * annotate.c: Sort headers.
3586         * amd64-windows-tdep.c: Sort headers.
3587         * amd64-windows-nat.c: Sort headers.
3588         * amd64-tdep.c: Sort headers.
3589         * amd64-sol2-tdep.c: Sort headers.
3590         * amd64-obsd-tdep.c: Sort headers.
3591         * amd64-obsd-nat.c: Sort headers.
3592         * amd64-nbsd-tdep.c: Sort headers.
3593         * amd64-nbsd-nat.c: Sort headers.
3594         * amd64-nat.c: Sort headers.
3595         * amd64-linux-tdep.c: Sort headers.
3596         * amd64-linux-nat.c: Sort headers.
3597         * amd64-fbsd-tdep.c: Sort headers.
3598         * amd64-fbsd-nat.c: Sort headers.
3599         * amd64-dicos-tdep.c: Sort headers.
3600         * amd64-darwin-tdep.c: Sort headers.
3601         * amd64-bsd-nat.c: Sort headers.
3602         * alpha-tdep.c: Sort headers.
3603         * alpha-obsd-tdep.c: Sort headers.
3604         * alpha-nbsd-tdep.c: Sort headers.
3605         * alpha-mdebug-tdep.c: Sort headers.
3606         * alpha-linux-tdep.c: Sort headers.
3607         * alpha-linux-nat.c: Sort headers.
3608         * alpha-bsd-tdep.c: Sort headers.
3609         * alpha-bsd-nat.c: Sort headers.
3610         * aix-thread.c: Sort headers.
3611         * agent.c: Sort headers.
3612         * addrmap.c: Sort headers.
3613         * ada-varobj.c: Sort headers.
3614         * ada-valprint.c: Sort headers.
3615         * ada-typeprint.c: Sort headers.
3616         * ada-tasks.c: Sort headers.
3617         * ada-lang.c: Sort headers.
3618         * aarch64-tdep.c: Sort headers.
3619         * aarch64-ravenscar-thread.c: Sort headers.
3620         * aarch64-newlib-tdep.c: Sort headers.
3621         * aarch64-linux-tdep.c: Sort headers.
3622         * aarch64-linux-nat.c: Sort headers.
3623         * aarch64-fbsd-tdep.c: Sort headers.
3624         * aarch64-fbsd-nat.c: Sort headers.
3625         * aarch32-linux-nat.c: Sort headers.
3626
3627 2019-04-04  Tom Tromey  <tom@tromey.com>
3628
3629         * varobj.c (varobj_create): Update.
3630         * rust-exp.y (struct rust_parser) <update_innermost_block,
3631         lookup_symbol>: New methods.
3632         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3633         Rename.
3634         (rust_parser::rust_lookup_type)
3635         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3636         * printcmd.c (display_command, do_one_display): Update.
3637         * parser-defs.h (struct parser_state) <parser_state>: Add
3638         "tracker" parameter.
3639         (block_tracker): New member.
3640         (class innermost_block_tracker) <innermost_block_tracker>: Add
3641         "types" parameter.
3642         <reset>: Remove method.
3643         (innermost_block): Don't declare.
3644         (null_post_parser): Update.
3645         * parse.c (innermost_block): Remove global.
3646         (write_dollar_variable): Update.
3647         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3648         Remove "tracker_types" parameter.
3649         (parse_expression): Add "tracker" parameter.
3650         (parse_expression_for_completion): Update.
3651         (null_post_parser): Add "tracker" parameter.
3652         * p-exp.y: Update rules.
3653         * m2-exp.y: Update rules.
3654         * language.h (struct language_defn) <la_post_parser>: Add
3655         "tracker" parameter.
3656         * go-exp.y: Update rules.
3657         * f-exp.y: Update rules.
3658         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3659         parameter.
3660         * d-exp.y: Update rules.
3661         * c-exp.y: Update rules.
3662         * breakpoint.c (set_breakpoint_condition): Create an
3663         innermost_block_tracker.
3664         (watch_command_1): Likewise.
3665         * ada-lang.c (resolve): Add "tracker" parameter.
3666         (resolve_subexp): Likewise.
3667         * ada-exp.y (write_var_from_sym): Update.
3668
3669 2019-04-04  Tom Tromey  <tom@tromey.com>
3670
3671         * type-stack.h: New file.
3672         * type-stack.c: New file.
3673         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3674         type-stack.h.
3675         (insert_into_type_stack, insert_type, push_type, push_type_int)
3676         (insert_type_address_space, pop_type, pop_type_int)
3677         (pop_typelist, pop_type_stack, append_type_stack)
3678         (push_type_stack, get_type_stack, push_typelist)
3679         (follow_type_instance_flags, follow_types): Don't declare.
3680         * parse.c (type_stack): Remove global.
3681         (parse_exp_in_context): Update.
3682         (insert_into_type_stack, insert_type, push_type, push_type_int)
3683         (insert_type_address_space, pop_type, pop_type_int)
3684         (pop_typelist, pop_type_stack, append_type_stack)
3685         (push_type_stack, get_type_stack, push_typelist)
3686         (follow_type_instance_flags, follow_types): Remove (moved to
3687         type-stack.c).
3688         * f-exp.y (type_stack): New global.
3689         Update rules.
3690         (push_kind_type, f_parse): Update.
3691         * d-exp.y (type_stack): New global.
3692         Update rules.
3693         (d_parse): Update.
3694         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3695         Update rules.
3696         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3697         (HFILES_NO_SRCDIR): Add type-stack.h.
3698
3699 2019-04-04  Tom Tromey  <tom@tromey.com>
3700
3701         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3702         (rust_parser::convert_ast_to_expression, rust_parse)
3703         (rust_lex_test_completion, rust_lex_tests): Update.
3704         * parser-defs.h (struct expr_completion_state): New.
3705         (struct parser_state) <parser_state>: Add completion parameter.
3706         <mark_struct_expression, mark_completion_tag>: New methods.
3707         <parse_completion, m_completion_state>: New members.
3708         (prefixify_expression, null_post_parser): Update.
3709         (mark_struct_expression, mark_completion_tag): Don't declare.
3710         * parse.c (parse_completion, expout_last_struct)
3711         (expout_tag_completion_type, expout_completion_name): Remove
3712         globals.
3713         (parser_state::mark_struct_expression)
3714         (parser_state::mark_completion_tag): Now methods.
3715         (prefixify_expression): Add last_struct parameter.
3716         (prefixify_subexp): Likewise.
3717         (parse_exp_1): Update.
3718         (parse_exp_in_context): Add cstate parameter.  Update.
3719         (parse_expression_for_completion): Create an
3720         expr_completion_state.
3721         (null_post_parser): Add "completion" parameter.
3722         * p-exp.y: Update rules.
3723         (yylex): Update.
3724         * language.h (struct language_defn) <la_post_parser>: Add
3725         "completing" parameter.
3726         * go-exp.y: Update rules.
3727         (lex_one_token): Update.
3728         * expression.h (parse_completion): Don't declare.
3729         * d-exp.y: Update rules.
3730         (lex_one_token): Update rules.
3731         * c-exp.y: Update rules.
3732         (lex_one_token): Update.
3733         * ada-lang.c (resolve): Add "parse_completion" parameter.
3734         (resolve_subexp): Likewise.
3735         (ada_resolve_function): Likewise.
3736
3737 2019-04-04  Tom Tromey  <tom@tromey.com>
3738
3739         * parser-defs.h (struct parser_state) <start_arglist,
3740         end_arglist>: New methods.
3741         <arglist_len, m_funcall_chain>: New members.
3742         (arglist_len, start_arglist, end_arglist): Don't declare.
3743         * parse.c (arglist_len, funcall_chain): Remove global.
3744         (start_arglist, end_arglist): Remove functions.
3745         (parse_exp_in_context): Update.
3746         * p-exp.y: Update rules.
3747         * m2-exp.y: Update rules.
3748         * go-exp.y: Update rules.
3749         * f-exp.y: Update rules.
3750         * d-exp.y: Update rules.
3751         * c-exp.y: Update rules.
3752
3753 2019-04-04  Tom Tromey  <tom@tromey.com>
3754
3755         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3756         lex_operator, push_back>: New methods.
3757         Update all rules.
3758         (rust_parser::lex_hex, lex_escape): Rename and update.
3759         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3760         (rust_parser::lex_operator): Rename and update.
3761         (rust_parser::lex_number, rustyylex, rustyyerror)
3762         (rust_lex_test_init, rust_lex_test_sequence)
3763         (rust_lex_test_push_back, rust_lex_tests): Update.
3764         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3765         parameter.
3766         <lexptr, prev_lexptr>: New members.
3767         (lexptr, prev_lexptr): Don't declare.
3768         * parse.c (lexptr, prev_lexptr): Remove globals.
3769         (parse_exp_in_context): Update.
3770         * p-exp.y (yylex, yyerror): Update.
3771         * m2-exp.y (parse_number, yylex, yyerror): Update.
3772         * go-exp.y (lex_one_token, yyerror): Update.
3773         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3774         * d-exp.y (lex_one_token, yyerror): Update.
3775         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3776         (lex_one_token, yyerror): Update.
3777         * ada-lex.l (YY_INPUT): Update.
3778         (rewind_to_char): Update.
3779         * ada-exp.y (yyerror): Update.
3780
3781 2019-04-04  Tom Tromey  <tom@tromey.com>
3782
3783         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3784         * parser-defs.h (struct parser_state) <parser_state>: Add new
3785         parameter.
3786         <comma_terminates>: New member.
3787         (comma_terminates): Don't declare global.
3788         * parse.c (comma_terminates): Remove global.
3789         (parse_exp_in_context): Update.
3790         * p-exp.y (yylex): Update.
3791         * m2-exp.y (yylex): Update.
3792         * go-exp.y (lex_one_token): Update.
3793         * f-exp.y (yylex): Update.
3794         * d-exp.y (lex_one_token): Update.
3795         * c-exp.y (lex_one_token): Update.
3796         * ada-lex.l: Update.
3797
3798 2019-04-04  Tom Tromey  <tom@tromey.com>
3799
3800         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3801         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3802         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3803         * parser-defs.h (paren_depth): Don't declare.
3804         * parse.c (paren_depth): Remove global.
3805         (parse_exp_in_context): Update.
3806         * p-exp.y (paren_depth): New global.
3807         (pascal_parse): Initialize it.
3808         * m2-exp.y (paren_depth): New global.
3809         (m2_parse): Initialize it.
3810         * go-exp.y (paren_depth): New global.
3811         (go_parse): Initialize it.
3812         * f-exp.y (paren_depth): New global.
3813         (f_parse): Initialize it.
3814         * d-exp.y (paren_depth): New global.
3815         (d_parse): Initialize it.
3816         * c-exp.y (paren_depth): New global.
3817         (c_parse): Initialize it.
3818         * ada-lex.l (paren_depth): New global.
3819         (lexer_init): Initialize it.
3820
3821 2019-04-04  Tom Tromey  <tom@tromey.com>
3822
3823         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3824         (rust_parser::convert_ast_to_type)
3825         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3826         * parser-defs.h (struct parser_state) <parser_state>: Add
3827         parameters.  Initialize new members.
3828         <expression_context_block, expression_context_pc>: New members.
3829         * parse.c (expression_context_block, expression_context_pc):
3830         Remove globals.
3831         (parse_exp_in_context): Update.
3832         * p-exp.y: Update all rules.
3833         (yylex): Update.
3834         * m2-exp.y: Update all rules.
3835         (yylex): Update.
3836         * go-exp.y (yylex): Update.
3837         * f-exp.y (yylex): Update.
3838         * d-exp.y: Update all rules.
3839         (yylex): Update.
3840         * c-exp.y: Update all rules.
3841         (lex_one_token, classify_name, yylex, c_parse): Update.
3842         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3843
3844 2019-04-04  Tom Tromey  <tom@tromey.com>
3845
3846         * gdbarch.h, gdbarch.c: Rebuild.
3847         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3848         * stap-probe.h:
3849         (struct stap_parse_info): Replace "parser_state" with
3850         "expr_builder".
3851         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3852         (parser_state): New class.
3853         * parse.c (expr_builder): Rename.
3854         (expr_builder::release): Rename.
3855         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3856         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3857         (write_exp_elt_longcst, write_exp_elt_floatcst)
3858         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3859         (write_exp_string_vector, write_exp_bitstring)
3860         (write_exp_msymbol, mark_struct_expression)
3861         (write_dollar_variable)
3862         (insert_type_address_space, increase_expout_size): Replace
3863         "parser_state" with "expr_builder".
3864         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3865         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3866         "parser_state" with "expr_builder".
3867
3868 2019-04-04  Tom Tromey  <tom@tromey.com>
3869
3870         * rust-exp.y: Replace "parse_language" with method call.
3871         * p-exp.y:
3872         (yylex): Replace "parse_language" with method call.
3873         * m2-exp.y:
3874         (yylex): Replace "parse_language" with method call.
3875         * go-exp.y (classify_name): Replace "parse_language" with method
3876         call.
3877         * f-exp.y (yylex): Replace "parse_language" with method call.
3878         * d-exp.y (lex_one_token): Replace "parse_language" with method
3879         call.
3880         * c-exp.y:
3881         (lex_one_token, classify_name, yylex): Replace "parse_language"
3882         with method call.
3883         * ada-exp.y (find_primitive_type, type_char)
3884         (type_system_address): Replace "parse_language" with method call.
3885
3886 2019-04-04  Tom Tromey  <tom@tromey.com>
3887
3888         * rust-exp.y: Replace "parse_gdbarch" with method call.
3889         * parse.c (write_dollar_variable, insert_type_address_space):
3890         Replace "parse_gdbarch" with method call.
3891         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3892         call.
3893         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3894         call.
3895         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3896         "parse_gdbarch" with method call.
3897         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3898         with method call.
3899         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3900         "parse_gdbarch" with method call.
3901         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3902         "parse_gdbarch" with method call.
3903         * c-exp.y (parse_type, parse_number, classify_name): Replace
3904         "parse_gdbarch" with method call.
3905         * ada-lex.l: Replace "parse_gdbarch" with method call.
3906         * ada-exp.y (parse_type, find_primitive_type, type_char)
3907         (type_system_address): Replace "parse_gdbarch" with method call.
3908
3909 2019-04-04  Tom Tromey  <tom@tromey.com>
3910
3911         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3912         * stap-probe.c (stap_parse_argument): Update.
3913         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3914         initial_size parameter.
3915         * rust-exp.y (rust_lex_tests): Update.
3916         * parse.c (parser_state): Update.
3917         (parse_exp_in_context): Update.
3918         * parser-defs.h (struct parser_state) <parser_state>: Remove
3919         "initial_size" parameter.
3920
3921 2019-04-04  Tom Tromey  <tom@tromey.com>
3922
3923         * parser-defs.h (increase_expout_size): Don't declare.
3924         * parse.c (increase_expout_size): Now static.
3925
3926 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3927
3928         * gnu-nat.c (gnu_nat_target::wait): Fix
3929         target_waitstatus_to_string call.
3930
3931 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * eval.c (evaluate_subexp_standard): Handle internal functions
3934         during Fortran function call handling.
3935
3936 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3937
3938         * NEWS: Mention new internal functions.
3939         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3940         (read_base_type): Use dwarf2_init_complex_target_type.
3941         * value.c (creal_internal_fn): New function.
3942         (cimag_internal_fn): New function.
3943         (_initialize_values): Register new internal functions.
3944
3945 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3946
3947         * infrun.c (stop_all_threads): If debug_infrun, always
3948         trace the wait status after wait_one, using
3949         target_waitstatus_to_string and target_pid_to_str.
3950         (handle_inferior_event): Replace various trace of
3951         wait status kind by a single trace.
3952         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3953         wait status kind image by target_waitstatus_to_string.
3954         * target/waitstatus.c (target_waitstatus_to_string): Fix
3955         obsolete comment.
3956
3957 2019-04-01  Tom Tromey  <tromey@adacore.com>
3958
3959         PR symtab/23331:
3960         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3961
3962 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3963             Pedro Alves  <palves@redhat.com>
3964
3965         * top.c (quit_force): Call 'finalize_values'.
3966         * value.c (finalize_values): New function.
3967         * value.h (finalize_values): Declare.
3968
3969 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3970
3971         * NEWS: Announce $_gdb_major and $_gdb_minor.
3972
3973         * top.c (init_gdb_version_vars): New function.
3974         (gdb_init): Call init_gdb_version_vars.
3975
3976 2019-03-29  Tom Tromey  <tromey@adacore.com>
3977
3978         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3979         help text.  Remove dead code.
3980
3981 2019-03-29  Keith Seitz  <keiths@redhat.com>
3982
3983         From Siddhesh Poyarekar:
3984         * f-lang.h (f77_get_upperbound): Return LONGEST.
3985         (f77_get_lowerbound): Likewise.
3986         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3987         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3988         print them.
3989         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3990         plongest to format print it.
3991         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3992         (f77_get_upperbound): Likewise.
3993         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3994         LOWER_BOUND to LONGEST.
3995         (f77_create_arrayprint_offset_tbl): Likewise.
3996
3997 2019-03-29  Keith Seitz  <keiths@redhat.com>
3998
3999         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4000         %s/pulongest for TYPE_LENGTH instead of %d in format
4001         strings.
4002         * ada-typerint.c (ada_print_type): Likewise.
4003         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4004         * compile/compile-c-support.c (generate_register_struct): Likewise.
4005         * gdbtypes.c (recursive_dump_type): Likewise.
4006         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4007         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4008         instead of %d in format strings.
4009         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4010         to std::min to ULONGEST.
4011         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4012         instead of %d in format strings.
4013         * tracepoint.c (info_scope_command): Likewise.
4014         * typeprint.c (print_offset_data::update)
4015         (print_offset_data::finish): Likewise.
4016         * xtensa-tdep.c (xtensa_store_return_value)
4017         (xtensa_push_dummy_call): Likewise.
4018
4019 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4020
4021         * windows-nat.c (display_selector): Fixed format specifications
4022         for 64-bit Cygwin.
4023
4024 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4025
4026         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4027
4028 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4029
4030         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4031         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4032         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4033         (nios2_linux_init_abi): Install it.
4034
4035 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4036
4037         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4038
4039 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4040
4041         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4042
4043 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4044             Tom Tromey  <tromey@adacore.com>
4045
4046         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4047
4048 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4049
4050         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4051         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4052         method to compute the bounds of range types. Also print "[evaluated]"
4053         if the bounds' values come from a dynamic evaluation.
4054
4055 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4056
4057         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4058         whitespace when pretty printing is on.
4059
4060 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4061
4062         * ppc-linux-nat.c: Add include.
4063
4064 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4065
4066         * NEWS: Mention AArch64 Pointer Authentication.
4067
4068 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4069
4070         * arm-linux-nat.c: Add include.
4071
4072 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4073
4074         * source-cache.c (source_cache::get_source_lines): Re-read
4075         fullname after calling open_source_file.
4076
4077 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4078
4079         * NEWS: Mention TLS support for FreeBSD.
4080
4081 2019-03-25  Tom Tromey  <tromey@adacore.com>
4082
4083         * minsyms.c (BUNCH_SIZE): Update comment.
4084         (~minimal_symbol_reader): Remove old comment.
4085         (compact_minimal_symbols): Update comment.
4086         (minimal_symbol_reader::install): Remove old comment.  Update
4087         other comments.
4088
4089 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4090
4091         * s390-linux-nat.c: Add include.
4092
4093 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4094
4095         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4096         Call linux_get_hwcap.
4097         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4098         Likewise.
4099         (aarch64_linux_get_hwcap): Remove function.
4100         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4101         declaration.
4102         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4103         linux_get_hwcap.
4104         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4105         * linux-tdep.c (linux_get_hwcap): Add function.
4106         (linux_get_hwcap2): Likewise.
4107         * linux-tdep.h (linux_get_hwcap): Add declaration.
4108         (linux_get_hwcap2): Likewise.
4109         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4110         (ppc_linux_get_hwcap2): Likewise.
4111         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4112         linux_get_hwcap.
4113         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4114         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4115         (ppc_linux_nat_target::read_description): Likewise.
4116         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4117         * s390-linux-nat.c: Likewise.
4118         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4119
4120 2019-03-24  Tom Tromey  <tom@tromey.com>
4121
4122         * ada-lang.c (standard_lookup): Simplify initialization.
4123         (ada_lookup_symbol_nonlocal): Simplify return.
4124         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4125         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4126         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4127         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4128         initialization.
4129         * solib.c (solib_global_lookup): Simplify.
4130         * symtab.c (null_block_symbol): Remove.
4131         (symbol_cache_lookup): Simplify returns.
4132         (lookup_language_this): Simplify returns.
4133         (lookup_symbol_aux): Simplify return.
4134         (lookup_local_symbol): Simplify returns.
4135         (lookup_global_symbol_from_objfile): Simplify return.
4136         (lookup_symbol_in_objfile_symtabs)
4137         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4138         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4139         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4140         * cp-namespace.c (cp_lookup_bare_symbol)
4141         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4142         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4143         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4144         (cp_lookup_symbol_via_imports): Simplify initialization.
4145         (find_symbol_in_baseclass): Likewise.
4146         * symtab.h (null_block_symbol): Remove.
4147         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4148         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4149         (d_lookup_symbol_module): Likewise.
4150         (find_symbol_in_baseclass): Simplify initialization.
4151
4152 2019-03-24  Tom Tromey  <tom@tromey.com>
4153
4154         * expression.h: Don't include symtab.h.
4155         (struct block): Forward declare.
4156
4157 2019-03-24  Tom Tromey  <tom@tromey.com>
4158
4159         * c-exp.y (typebase): Remove casts.
4160         * gdbtypes.c (lookup_unsigned_typename, )
4161         (lookup_signed_typename): Remove cast.
4162         * eval.c (parse_to_comma_and_eval): Remove cast.
4163         * parse.c (write_dollar_variable): Remove cast.
4164         * block.h (struct block) <superblock>: Now const.
4165         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4166         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4167         (map_block): Make "block" const.
4168         * symfile.h (struct quick_symbol_functions)
4169         <map_matching_symbols>: Constify block argument to "callback".
4170         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4171         const.
4172         (find_pc_sect_compunit_symtab): Make "b" const.
4173         (find_symbol_at_address): Likewise.
4174         (search_symbols): Likewise.
4175         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4176         (dw2_debug_names_lookup_symbol): Likewise.
4177         (dw2_map_matching_symbols): Update.
4178         * p-valprint.c (pascal_val_print): Remove "block".
4179         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4180         (aux_add_nonlocal_symbols): Make "block" const.
4181         (resolve_subexp): Remove cast.
4182         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4183         const.
4184         (iterate_over_file_blocks): Likewise.
4185         * f-exp.y (%union) <bval>: Remove.
4186         * coffread.c (patch_opaque_types): Make "b" const.
4187         * spu-tdep.c (spu_catch_start): Make "block" const.
4188         * c-valprint.c (print_unpacked_pointer): Remove "block".
4189         * symmisc.c (dump_symtab_1): Make "b" const.
4190         (block_depth): Make "block" const.
4191         * d-exp.y (%union) <bval>: Remove.
4192         * cp-support.h (cp_lookup_rtti_type): Update.
4193         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4194         * psymtab.c (psym_lookup_symbol): Make "block" const.
4195         (maintenance_check_psymtabs): Make "b" const.
4196         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4197         (enumerate_locals, enumerate_args): Update.
4198         * python/py-symtab.c (stpy_global_block): Make "block" const.
4199         (stpy_static_block): Likewise.
4200         * inline-frame.c (block_starting_point_at): Make "new_block"
4201         const.
4202         * block.c (find_block_in_blockvector): Make return type const.
4203         (blockvector_for_pc_sect): Make "b" const.
4204         (find_block_in_blockvector): Make "b" const.
4205
4206 2019-03-23  Tom Tromey  <tom@tromey.com>
4207
4208         * varobj.c (varobj_create): Update.
4209         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4210         * printcmd.c (display_command, do_one_display): Don't reset
4211         innermost_block.
4212         * parser-defs.h (enum innermost_block_tracker_type): Move to
4213         expression.h.
4214         (innermost_block): Update comment.
4215         * parse.c (parse_exp_1): Add tracker_types parameter.
4216         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4217         tracker_types parameter.  Reset innermost_block.
4218         (parse_exp_in_context): Remove.
4219         (parse_expression_for_completion): Update.
4220         * objfiles.c (~objfile): Don't reset expression_context_block or
4221         innermost_block.
4222         * expression.h (enum innermost_block_tracker_type): Move from
4223         parser-defs.h.
4224         (parse_exp_1): Add tracker_types parameter.
4225         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4226         reset innermost_block.
4227
4228 2019-03-23  Tom Tromey  <tom@tromey.com>
4229
4230         * objfiles.h: Include bcache.h.
4231
4232 2019-03-23  Tom Tromey  <tom@tromey.com>
4233
4234         * linespec.c (get_current_search_block): Use
4235         scoped_restore_current_language.
4236         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4237
4238 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4239             Jiong Wang  <jiong.wang@arm.com>
4240
4241         * aarch64-linux-tdep.c
4242         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4243         section.
4244         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4245
4246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4247             Jiong Wang  <jiong.wang@arm.com>
4248
4249         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4250         instructions.
4251         (aarch64_analyze_prologue_test): Add PACIASP test.
4252         (aarch64_prologue_prev_register): Unmask PC value.
4253
4254 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4255             Jiong Wang  <jiong.wang@arm.com>
4256
4257         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4258         (aarch64_dwarf2_prev_register): Unmask PC value.
4259         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4260         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4261         DW_CFA_AARCH64_negate_ra_state.
4262         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4263
4264 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4265             Jiong Wang  <jiong.wang@arm.com>
4266
4267         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4268         registers.
4269         (aarch64_pseudo_register_name): Likewise.
4270         (aarch64_pseudo_register_type): Likewise.
4271         (aarch64_pseudo_register_reggroup_p): Likewise.
4272         (aarch64_gdbarch_init): Add pauth registers.
4273         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4274         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4275         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4276         (struct gdbarch_tdep): Add regnum for ra_state.
4277
4278 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4279             Jiong Wang  <jiong.wang@arm.com>
4280
4281         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4282
4283 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4284             Jiong Wang  <jiong.wang@arm.com>
4285
4286         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4287         function.
4288         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4289         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4290         (aarch64_gdbarch_init): Add puth registers.
4291         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4292         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4293         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4294
4295 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4296             Jiong Wang  <jiong.wang@arm.com>
4297
4298         * aarch64-linux-nat.c
4299         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4300         * aarch64-linux-tdep.c
4301         (aarch64_linux_core_read_description): Likewise.
4302         (aarch64_linux_get_hwcap): New function.
4303         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4304         (aarch64_linux_get_hwcap): New declaration.
4305
4306 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4307             Jiong Wang  <jiong.wang@arm.com>
4308
4309         * aarch64-linux-nat.c
4310         (aarch64_linux_nat_target::read_description): Add pauth param.
4311         * aarch64-linux-tdep.c
4312         (aarch64_linux_core_read_description): Likewise.
4313         * aarch64-tdep.c (struct target_desc): Add in pauth.
4314         (aarch64_read_description): Add pauth param.
4315         (aarch64_gdbarch_init): Likewise.
4316         * aarch64-tdep.h (aarch64_read_description): Likewise.
4317         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4318         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4319         * features/Makefile: Add new files.
4320         * features/aarch64-pauth.c: New file.
4321         * features/aarch64-pauth.xml: New file.
4322
4323 2019-03-20  Tom Tromey  <tromey@adacore.com>
4324
4325         * infrun.c (handle_inferior_event): Rename from
4326         handle_inferior_event_1.  Create a scoped_value_mark.
4327         (handle_inferior_event): Remove.
4328
4329 2019-03-19  Tom Tromey  <tromey@adacore.com>
4330
4331         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4332         * infrun.h (print_stop_event): Add "displays" parameter.
4333         * infrun.c (print_stop_event): Add "displays" parameter.
4334
4335 2019-03-19  Pedro Alves  <palves@redhat.com>
4336
4337         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4338         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4339         to -1.  Fix TABs vs spaces.
4340         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4341         * tui/tui-out.h (tui_ui_out) Add intro comments.
4342         <m_line, m_start_of_line>: In-class initialize, and add describing
4343         comment.
4344
4345 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4346
4347         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4348         variable names.
4349         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4350
4351 2019-03-18  Pedro Alves  <palves@redhat.com>
4352             Eli Zaretskii <eliz@gnu.org>
4353
4354         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4355         m_line and m_start_of_line.
4356
4357 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4358
4359         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4360         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4361         it returns a newline.  This fixes a regression in TU mode, whereby
4362         the next line is output on the same screen line as the user input.
4363
4364 2019-03-18  Tom Tromey  <tromey@adacore.com>
4365
4366         * minsyms.c (minimal_symbol_reader::install): Remove call to
4367         obstack_blank.
4368
4369 2019-03-18  Pedro Alves  <palves@redhat.com>
4370
4371         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4372         New globals.
4373         (apply_style): New, factored out from ...
4374         (apply_ansi_escape): ... this.  Handle reverse video mode.
4375         (tui_set_reverse_mode): New function.
4376         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4377         * tui/tui-winsource.c (tui_show_source_line): Use
4378         tui_set_reverse_mode instead of setting A_STANDOUT.
4379         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4380         New setter methods.
4381
4382 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4383
4384         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4385         Handle tabs.
4386
4387 2019-03-18  Tom Tromey  <tromey@adacore.com>
4388
4389         * ada-lang.c (empty_array): Add "high" parameter.
4390         (ada_evaluate_subexp): Update.
4391
4392 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4393
4394         * unittests/string_view-selftests.c: Define
4395         _initialize_string_view_selftests unconditionally.
4396
4397 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4398
4399         PR gdb/24350
4400         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4401
4402 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4403
4404         PR gdb/24351
4405         * windows-nat.c (display_selector): Fix format specifiers.
4406
4407 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4408
4409         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4410         tui_refill_source_window instead of tui_refresh_win, to update the
4411         current execution line.  This fixes redisplay of the current line
4412         when stepping through the code with "next" or "step".
4413
4414 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4415
4416         * source-cache.c (source_cache::get_source_lines): Call
4417         find_source_lines to initialize s->nlines.  This fixes vertical
4418         scrolling of TUI source window when the DOWN arrow is pressed.
4419
4420 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4421
4422         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4423         linux-thread-db.c (_initialize_thread_db): Likewise.
4424
4425 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4426
4427         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4428         wclrtoeol in tui_show_source_line".  This reverts changes made in
4429         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4430
4431 2019-03-15  Tom Tromey  <tom@tromey.com>
4432
4433         * symtab.h (struct minimal_symbol): Derive from
4434         general_symbol_info.
4435         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4436         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4437         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4438         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4439         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4440         (MSYMBOL_SEARCH_NAME): Update.
4441         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4442         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4443         * minsyms.c (minimal_symbol_reader::record_full): Update.
4444
4445 2019-03-15  Tom Tromey  <tom@tromey.com>
4446
4447         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4448
4449 2019-03-15  Tom Tromey  <tom@tromey.com>
4450
4451         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4452         unique_xmalloc_ptr.
4453         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4454         Update.
4455         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4456         (build_minimal_symbol_hash_tables)
4457         (minimal_symbol_reader::install): Update.
4458
4459 2019-03-15  Tom Tromey  <tom@tromey.com>
4460
4461         * symtab.c (create_demangled_names_hash): Update.
4462         (symbol_set_names): Update.
4463         * objfiles.h (struct objfile_per_bfd_storage)
4464         <demangled_names_hash>: Now an htab_up.
4465         * objfiles.c (objfile_per_bfd_storage): Simplify.
4466
4467 2019-03-15  Tom Tromey  <tom@tromey.com>
4468
4469         * objfiles.h (struct objfile_per_bfd_storage): Declare
4470         destructor.
4471         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4472         New.
4473         (get_objfile_bfd_data): Use new.  Don't initialize
4474         language_of_main.
4475         (free_objfile_per_bfd_storage): Remove.
4476         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4477
4478 2019-03-15  Tom Tromey  <tom@tromey.com>
4479
4480         * symfile.c (reread_symbols): Update.
4481         * objfiles.c (objfile::objfile): Update.
4482         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4483         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4484         comment.
4485         (minimal_symbol_reader::install): Update.
4486         (terminate_minimal_symbol_table): Remove.
4487         * jit.c (jit_object_close_impl): Update.
4488
4489 2019-03-15  Tom Tromey  <tom@tromey.com>
4490
4491         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4492         initializations.
4493
4494 2019-03-15  Tom Tromey  <tom@tromey.com>
4495
4496         * objfiles.h (struct objfile_per_bfd_storage)
4497         <demangled_hash_languages>: Now a bitset.
4498         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4499         (lookup_minimal_symbol): Update.
4500
4501 2019-03-15  Tom Tromey  <tom@tromey.com>
4502
4503         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4504         Don't return the symbol.
4505         * coffread.c (record_minimal_symbol): Use record_full.
4506
4507 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4508
4509         The MS-Windows port of ncurses fails to switch to a color pair if
4510         one or both of the colors are the implicit default colors.  This
4511         change records the default colors when TUI is initialized, and
4512         then specifies them explicitly when a color pair uses the default
4513         colors.  This allows color styling in TUI mode on MS-Windows.
4514
4515         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4516         ncurses_norm_attr.
4517         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4518         colors in ncurses_norm_attr.
4519         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4520         "none", replace it with the default color recorded in
4521         ncurses_norm_attr.
4522
4523 2019-03-14  Tom Tromey  <tromey@adacore.com>
4524
4525         * source-cache.h (class source_cache) <get_source_lines>: Return
4526         std::string.
4527         * source-cache.c (source_cache::extract_lines): Handle case where
4528         first_pos==npos.  Return std::string.
4529         (source_cache::get_source_lines): Update.
4530
4531 2019-03-14  Tom Tromey  <tromey@adacore.com>
4532
4533         * NEWS: Add item for "style sources" commands.
4534         * source-cache.c (source_cache::get_source_lines): Check
4535         source_styling.
4536         * cli/cli-style.c (source_styling): New global.
4537         (_initialize_cli_style): Add "style sources" commands.
4538         (show_style_sources): New function.
4539         * cli/cli-style.h (source_styling): Declare.
4540
4541 2019-03-14  Pedro Alves  <palves@redhat.com>
4542             Tom Tromey  <tromey@adacore.com>
4543
4544         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4545         * tui/tui-winsource.c (tui_refill_source_window): New function,
4546         from...
4547         (tui_horizontal_source_scroll): ... here.  Move some logic.
4548         * cli/cli-style.c (set_style_enabled): Notify new observable.
4549         * tui/tui-hooks.c (tui_redisplay_source): New function.
4550         (tui_attach_detach_observers): Attach or detach
4551         tui_redisplay_source.
4552         * observable.h (source_styling_changed): New observable.
4553         * observable.c: Define source_styling_changed observable.
4554
4555 2019-03-13  Tom Tromey  <tromey@adacore.com>
4556
4557         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4558         (i386_gnu_nat_target::store_registers): Update.
4559         * target-debug.h (target_debug_print_std_string): New macro.
4560         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4561         * windows-tdep.c (display_one_tib): Update.
4562         * tui/tui-stack.c (tui_make_status_line): Update.
4563         * top.c (print_inferior_quit_action): Update.
4564         * thread.c (thr_try_catch_cmd): Update.
4565         (add_thread_with_info): Update.
4566         (thread_target_id_str): Update.
4567         (thr_try_catch_cmd): Update.
4568         (thread_command): Update.
4569         (thread_find_command): Update.
4570         * record-btrace.c (record_btrace_target::info_record)
4571         (record_btrace_resume_thread, record_btrace_target::resume)
4572         (record_btrace_cancel_resume, record_btrace_step_thread)
4573         (record_btrace_target::wait, record_btrace_target::wait)
4574         (record_btrace_target::wait, record_btrace_target::stop): Update.
4575         * progspace.c (print_program_space): Update.
4576         * process-stratum-target.c
4577         (process_stratum_target::thread_address_space): Update.
4578         * linux-fork.c (linux_fork_mourn_inferior)
4579         (detach_checkpoint_command, info_checkpoints_command)
4580         (linux_fork_context): Update.
4581         (linux_fork_detach): Update.
4582         (class scoped_switch_fork_info): Update.
4583         (delete_checkpoint_command): Update.
4584         * infrun.c (follow_fork_inferior): Update.
4585         (follow_fork_inferior): Update.
4586         (proceed_after_vfork_done): Update.
4587         (handle_vfork_child_exec_or_exit): Update.
4588         (follow_exec): Update.
4589         (displaced_step_prepare_throw): Update.
4590         (displaced_step_restore): Update.
4591         (start_step_over): Update.
4592         (resume_1): Update.
4593         (clear_proceed_status_thread): Update.
4594         (proceed): Update.
4595         (print_target_wait_results): Update.
4596         (do_target_wait): Update.
4597         (context_switch): Update.
4598         (stop_all_threads): Update.
4599         (restart_threads): Update.
4600         (finish_step_over): Update.
4601         (handle_signal_stop): Update.
4602         (switch_back_to_stepped_thread): Update.
4603         (keep_going_pass_signal): Update.
4604         (print_exited_reason): Update.
4605         (normal_stop): Update.
4606         * inferior.c (inferior_pid_to_str): Change return type.
4607         (print_selected_inferior): Update.
4608         (add_inferior): Update.
4609         (detach_inferior): Update.
4610         * dummy-frame.c (fprint_dummy_frames): Update.
4611         * dcache.c (dcache_info_1): Update.
4612         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4613         (btrace_fetch, btrace_clear): Update.
4614         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4615         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4616         type.
4617         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4618         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4619         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4620         * gdbarch.c, gdbarch.h: Rebuild.
4621         * gdbarch.sh (core_pid_to_str): Change return type.
4622         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4623         return type.
4624         (windows_nat_target::pid_to_str): Change return type.
4625         (windows_delete_thread): Update.
4626         (windows_nat_target::attach): Update.
4627         (windows_nat_target::files_info): Update.
4628         * target-delegates.c: Rebuild.
4629         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4630         return type.
4631         (sol_thread_target::pid_to_str): Change return type.
4632         * remote.c (class remote_target) <pid_to_str>: Change return
4633         type.
4634         (remote_target::pid_to_str): Change return type.
4635         (extended_remote_target::attach, remote_target::remote_stop_ns)
4636         (remote_target::remote_notif_remove_queued_reply)
4637         (remote_target::push_stop_reply, remote_target::disable_btrace):
4638         Update.
4639         (extended_remote_target::attach): Update.
4640         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4641         type.
4642         (gdbsim_target::pid_to_str): Change return type.
4643         * ravenscar-thread.c (struct ravenscar_thread_target)
4644         <pid_to_str>: Change return type.
4645         (ravenscar_thread_target::pid_to_str): Change return type.
4646         * procfs.c (class procfs_target) <pid_to_str>: Change return
4647         type.
4648         (procfs_target::pid_to_str): Change return type.
4649         (procfs_target::attach): Update.
4650         (procfs_target::detach): Update.
4651         (procfs_target::fetch_registers): Update.
4652         (procfs_target::store_registers): Update.
4653         (procfs_target::wait): Update.
4654         (procfs_target::files_info): Update.
4655         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4656         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4657         return type.
4658         (nto_procfs_target::pid_to_str): Change return type.
4659         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4660         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4661         return type.
4662         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4663         (exit_lwp): Update.
4664         (attach_proc_task_lwp_callback, get_detach_signal)
4665         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4666         (linux_nat_target::resume, wait_lwp, stop_callback)
4667         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4668         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4669         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4670         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4671         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4672         type.
4673         (inf_ptrace_target::attach): Update.
4674         (inf_ptrace_target::files_info): Update.
4675         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4676         type.
4677         (go32_nat_target::pid_to_str): Change return type.
4678         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4679         (gnu_nat_target::wait): Update.
4680         (gnu_nat_target::wait): Update.
4681         (gnu_nat_target::resume): Update.
4682         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4683         (fbsd_nat_target::wait): Update.
4684         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4685         type.
4686         (darwin_nat_target::attach): Update.
4687         * corelow.c (class core_target) <pid_to_str>: Change return type.
4688         (core_target::pid_to_str): Change return type.
4689         * target.c (normal_pid_to_str): Change return type.
4690         (default_pid_to_str): Likewise.
4691         (target_pid_to_str): Change return type.
4692         (target_translate_tls_address): Update.
4693         (target_announce_detach): Update.
4694         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4695         return type.
4696         (bsd_uthread_target::pid_to_str): Change return type.
4697         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4698         type.
4699         (bsd_kvm_target::pid_to_str): Change return type.
4700         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4701         return type.
4702         (aix_thread_target::pid_to_str): Change return type.
4703         * target.h (struct target_ops) <pid_to_str>: Change return type.
4704         (target_pid_to_str, normal_pid_to_str): Likewise.
4705         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4706         type.
4707         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4708         type.
4709         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4710         return type.
4711         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4712         type.
4713         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4714         type.
4715         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4716         return type.
4717
4718 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4719
4720         * NEWS: Mention that the new default MI version is 3.  Mention
4721         changes to the output of commands and events that deal with
4722         multi-location breakpoints.
4723         * breakpoint.c: Include "mi/mi-out.h".
4724         (print_one_breakpoint): Change output syntax if using MI version
4725         >= 3.
4726         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4727         New.
4728         (mi_multi_location_breakpoint_output_fixed): New.
4729         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4730         (mi_cmd_fix_multi_location_breakpoint_output): New.
4731         (mi_multi_location_breakpoint_output_fixed): New.
4732         * mi/mi-cmds.c (mi_cmds): Register command
4733         -fix-multi-location-breakpoint-output.
4734         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4735         interpreter "mi".
4736
4737 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4738
4739         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4740         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4741         instantiate mi_ui_out based on interpreter name.
4742         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4743         * mi/mi-main.c (mi_load_progress): Likewise.
4744
4745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4746
4747         * NEWS: Combine separate "New targets" sections for 8.3.
4748
4749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4750
4751         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4752         (ppcfbsd_init_abi): Install gdbarch
4753         "fetch_tls_load_module_address" and "get_thread_local_address"
4754         methods.
4755
4756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4757
4758         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4759         (riscv_fbsd_init_abi): Install gdbarch
4760         "fetch_tls_load_module_address" and "get_thread_local_address"
4761         methods.
4762
4763 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4764
4765         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4766         (i386fbsd_init_abi): Install gdbarch
4767         "fetch_tls_load_module_address" and "get_thread_local_address"
4768         methods.
4769
4770 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4771
4772         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4773         (amd64fbsd_init_abi): Install gdbarch
4774         "fetch_tls_load_module_address" and "get_thread_local_address"
4775         methods.
4776
4777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4778
4779         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4780         (struct fbsd_pspace_data): New type.
4781         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4782         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4783         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4784         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4785         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4786
4787 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4788
4789         * gdbtypes.c (lookup_struct_elt): New function.
4790         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4791         * gdbtypes.h (struct struct_elt): New type.
4792         (lookup_struct_elt): New prototype.
4793
4794 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4795
4796         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4797         remove disabled code block.
4798
4799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4800
4801         * gdbarch.sh (get_thread_local_address): New method.
4802         * gdbarch.h, gdbarch.c: Regenerate.
4803         * target.c (target_translate_tls_address): Use
4804         gdbarch_get_thread_local_address if present instead of
4805         target::get_thread_local_address.
4806
4807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4808
4809         * target.h (target::get_thread_local_address): Update comment.
4810
4811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4812
4813         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4814         objfile->separate_debug_objfile_backlink if not NULL.
4815
4816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4817
4818         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4819         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4820         (amd64bsd_store_inferior_registers): Likewise.
4821         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4822         Enable segment base registers.
4823         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4824         PT_GETFSBASE and PT_GETGSBASE.
4825         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4826         PT_SETGSBASE.
4827         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4828         segment base registers.
4829         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4830
4831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4832
4833         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4834         Update calls to i386_target_description to add 'segments'
4835         parameter.
4836         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4837         add segment base registers.
4838         * arch/i386.c (i386_create_target_description): Add 'segments'
4839         parameter to enable segment base registers.
4840         * arch/i386.h (i386_create_target_description): Likewise.
4841         * features/i386/32bit-segments.xml: New file.
4842         * features/i386/32bit-segments.c: Generate.
4843         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4844         call to i386_target_description to add 'segments' parameter.
4845         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4846         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4847         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4848         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4849         if feature is present.
4850         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4851         Add 'segments' parameter to call to i386_target_description.
4852         (i386_target_description): Add 'segments' parameter to enable
4853         segment base registers.
4854         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4855         to call to i386_target_description.
4856         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4857         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4858         Define I386_NUM_REGS.
4859         (i386_target_description): Add 'segments' parameter to enable
4860         segment base registers.
4861
4862 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4863
4864         PR/24325
4865         * source-cache.c: #undef open and close, to avoid unresolved
4866         externals during linking.
4867
4868 2019-03-12  Tom Tromey  <tromey@adacore.com>
4869
4870         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4871         const.  Add initializers.
4872         (_initialize_remote): Don't initialize ptid globals.
4873
4874 2019-03-12  Pedro Alves  <palves@redhat.com>
4875
4876         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4877
4878 2019-03-12  Pedro Alves  <palves@redhat.com>
4879
4880         * cp-name-parser.y (main): Remove unused 'len' variable.
4881
4882 2019-03-12  Tom Tromey  <tromey@adacore.com>
4883
4884         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4885         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4886
4887 2019-03-12  Tom Tromey  <tromey@adacore.com>
4888
4889         * linux-nat.c (iterate_over_lwps): Update.
4890         (stop_callback): Remove parameter.
4891         (stop_wait_callback, detach_callback, resume_set_callback)
4892         (select_singlestep_lwp_callback, set_ignore_sigint)
4893         (status_callback, resumed_callback, resume_clear_callback)
4894         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4895         data parameter.
4896         (linux_nat_target::detach, linux_nat_target::resume)
4897         (linux_stop_and_wait_all_lwps, select_event_lwp)
4898         (linux_nat_filter_event, linux_nat_wait_1)
4899         (linux_nat_target::kill, linux_nat_target::stop)
4900         (linux_nat_target::stop): Update.
4901         (linux_nat_resume_callback): Change type.
4902         (resume_stopped_resumed_lwps, count_events_callback)
4903         (select_event_lwp_callback): Likewise.
4904         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4905         * arm-linux-nat.c (struct update_registers_data): Remove.
4906         (update_registers_callback): Change type.
4907         (arm_linux_insert_hw_breakpoint1): Update.
4908         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4909         parameter.
4910         (x86_linux_dr_set_addr): Update.
4911         (x86_linux_dr_set_control): Update.
4912         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4913         (iterate_over_lwps): Use gdb::function_view.
4914         * nat/aarch64-linux-hw-point.c (struct
4915         aarch64_dr_update_callback_param): Remove.
4916         (debug_reg_change_callback): Change type.
4917         (aarch64_notify_debug_reg_change): Update.
4918         * s390-linux-nat.c (s390_refresh_per_info): Update.
4919
4920 2019-03-11  Tom Tromey  <tromey@adacore.com>
4921
4922         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4923         redundant assignment to "this_cu".
4924
4925 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4926
4927         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4928
4929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4930
4931         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4932         from...
4933         (rank_one_type): ... this.
4934
4935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4936
4937         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4938         from...
4939         (rank_one_type): ... this.
4940
4941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4942
4943         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4944         from...
4945         (rank_one_type): ... this.
4946
4947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4948
4949         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4950         from...
4951         (rank_one_type): ... this.
4952
4953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4954
4955         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4956         from...
4957         (rank_one_type): ... this.
4958
4959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4960
4961         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4962         from...
4963         (rank_one_type): ... this.
4964
4965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4966
4967         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4968         from...
4969         (rank_one_type): ... this.
4970
4971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4972
4973         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4974         from...
4975         (rank_one_type): ... this.
4976
4977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4978
4979         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4980         from...
4981         (rank_one_type): ... this.
4982
4983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4984
4985         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4986         from...
4987         (rank_one_type): ... this.
4988
4989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4990
4991         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4992         from...
4993         (rank_one_type): ... this.
4994
4995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4996
4997         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4998         from...
4999         (rank_one_type): ... this.
5000
5001 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5002
5003         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5004         inferior-events' shows the example events.
5005
5006 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5007
5008         Support styling on native MS-Windows console
5009
5010         PR/24315
5011         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5012         on MS-Windows if $TERM is not defined.
5013
5014         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5015
5016         * posix-hdep.c (gdb_console_fputs):
5017         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5018         functions.
5019         * ui-file.h (gdb_console_fputs): Add prototype.
5020
5021         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5022         back to fputs only if the former returns zero.
5023
5024 2019-03-07  Tom Tromey  <tom@tromey.com>
5025
5026         * symmisc.c (print_symbol_bcache_statistics): Update.
5027         (print_objfile_statistics): Update.
5028         * symfile.c (allocate_symtab): Update.
5029         * stabsread.c: Don't include bcache.h.
5030         * psymtab.h (struct psymbol_bcache): Don't declare.
5031         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5032         (psymbol_bcache_init, psymbol_bcache_free)
5033         (psymbol_bcache_get_bcache): Don't declare.
5034         * psymtab.c (struct psymbol_bcache): Remove.
5035         (psymtab_storage::psymtab_storage): Update.
5036         (psymtab_storage::~psymtab_storage): Update.
5037         (psymbol_bcache_init, psymbol_bcache_free)
5038         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5039         (add_psymbol_to_bcache): Update.
5040         (allocate_psymtab): Update.
5041         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5042         macro_cache>: No longer pointers.
5043         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5044         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5045         * macrotab.c (macro_bcache): Update.
5046         * macroexp.c: Don't include bcache.h.
5047         * gdbtypes.c (check_types_worklist): Update.
5048         (types_deeply_equal): Remove TRY/CATCH.  Update.
5049         * elfread.c (elf_symtab_read): Update.
5050         * dwarf2read.c: Don't include bcache.h.
5051         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5052         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5053         (print_bcache_statistics, bcache_memory_used): Don't declare.
5054         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5055         methods.  Rename all data members.
5056         * bcache.c (struct bcache): Move to bcache.h.
5057         (bcache::expand_hash_table): Rename from expand_hash_table.
5058         (bcache): Remove.
5059         (bcache::insert): Rename from bcache_full.
5060         (bcache::compare): Rename from bcache_compare.
5061         (bcache_xmalloc): Remove.
5062         (bcache::~bcache): Rename from bcache_xfree.
5063         (bcache::print_statistics): Rename from print_bcache_statistics.
5064         (bcache::memory_used): Rename from bcache_memory_used.
5065
5066 2019-03-07  Pedro Alves  <palves@redhat.com>
5067
5068         * infrun.c (normal_stop): Also check for
5069         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5070
5071 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5072
5073         * f-lang.c (value_from_host_double): Moved to...
5074         * value.c (value_from_host_double): ...here.
5075         * value.h (value_from_host_double): Declare.
5076         * guile/scm-math.c (vlscm_convert_typed_number): Use
5077         value_from_host_double.
5078         (vlscm_convert_number): Likewise.
5079         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5080         * python/py-value.c (convert_value_from_python): Likewise.
5081
5082 2019-03-06  Tom Tromey  <tom@tromey.com>
5083
5084         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5085
5086 2019-03-06  Tom Tromey  <tom@tromey.com>
5087
5088         * utils.h (free_current_contents): Don't declare.
5089         * utils.c (free_current_contents): Remove.
5090
5091 2019-03-06  Tom Tromey  <tom@tromey.com>
5092
5093         * top.c (quit_force): Update.
5094         * main.c (captured_command_loop): Update.
5095         * common/new-op.c (operator new): Update.
5096         * common/common-exceptions.c (struct catcher)
5097         <save_cleanup_chain>: Remove member.
5098         (exceptions_state_mc_init): Update.
5099         (exception_try_scope_entry): Return nullptr.
5100         (exception_try_scope_exit, exception_rethrow)
5101         (throw_exception_sjlj, throw_exception_cxx): Update.
5102         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5103         (all_cleanups, do_cleanups, discard_cleanups)
5104         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5105         (restore_cleanups, restore_final_cleanups): Don't declare.
5106         (do_final_cleanups): Remove parameter.
5107         * common/cleanups.c (cleanup_chain, make_cleanup)
5108         (make_cleanup_dtor, all_cleanups, do_cleanups)
5109         (discard_my_cleanups, discard_cleanups)
5110         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5111         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5112         (null_cleanup): Remove.
5113         (do_final_cleanups): Remove parameter.
5114
5115 2019-03-06  Tom Tromey  <tom@tromey.com>
5116
5117         * remote.c (remote_target::remote_parse_stop_reply): Use
5118         unique_xmalloc_ptr.
5119
5120 2019-03-06  Tom Tromey  <tom@tromey.com>
5121
5122         * stabsread.c (struct stabs_field_info): Rename from field_info.
5123         <list, fnlist>: Add initializers.
5124         <obstack>: New member.
5125         (read_member_functions, read_struct_fields, read_baseclasses):
5126         Allocate on obstack.  Don't use cleanups.
5127         (read_one_struct_field, read_member_functions, read_struct_fields)
5128         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5129         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5130         (read_struct_type): Update.
5131
5132 2019-03-06  Tom Tromey  <tom@tromey.com>
5133
5134         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5135         * common/filestuff.h (make_cleanup_close): Don't declare.
5136         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5137         Remove.
5138
5139 2019-03-06  Tom Tromey  <tom@tromey.com>
5140
5141         * solib-aix.c: Use make_scope_exit.
5142
5143 2019-03-06  Tom Tromey  <tom@tromey.com>
5144
5145         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5146         Use make_scope_exit.
5147
5148 2019-03-06  Tom Tromey  <tom@tromey.com>
5149
5150         * solib-svr4.c (disable_probes_interface): Remove parameter.
5151         (svr4_handle_solib_event): Use make_scope_exit.
5152
5153 2019-03-06  Tom Tromey  <tom@tromey.com>
5154
5155         * remote.c (struct stop_reply_deleter): Remove.
5156         (stop_reply_up): Update.
5157         (struct stop_reply): Derive from notif_event.  Don't typedef.
5158         <regcache>: Now a std::vector.
5159         (stop_reply_xfree): Remove.
5160         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5161         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5162         (remote_target::discard_pending_stop_replies): Use delete.
5163         (remote_target::remote_parse_stop_reply): Update.
5164         (remote_target::process_stop_reply): Update.
5165         * remote-notif.h (struct notif_event): Add virtual destructor.
5166         Remove "dtr" member.
5167         (struct notif_client) <alloc_event>: Return a unique_ptr.
5168         (notif_event_xfree): Don't declare.
5169         (notif_event_up): New typedef.
5170         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5171         (notif_event_xfree, do_notif_event_xfree): Remove.
5172         (remote_notif_state_xfree): Update.
5173
5174 2019-03-06  Tom Tromey  <tom@tromey.com>
5175
5176         * infrun.c (displaced_step_clear_cleanup): Now a
5177         forward_scope_exit type.
5178         (displaced_step_prepare_throw): Update.
5179         (displaced_step_fixup): Update.
5180
5181 2019-03-06  Tom Tromey  <tom@tromey.com>
5182
5183         * inferior.h (class inferior): Update comment.
5184         * gdbthread.h (class thread_info): Update comment.
5185
5186 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5187             Tom Tromey  <tom@tromey.com>
5188
5189         * stabsread.h (struct stab_section_list): Remove.
5190         (coffstab_build_psymtabs): Update.
5191         * dbxread.c (symbuf_sections): Now a std::vector.
5192         (sect_idx): New global.
5193         (fill_symbuf): Update.
5194         (coffstab_build_psymtabs): Change type of stabsects parameter.
5195         Update.
5196         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5197         std::vector.
5198         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5199         (coff_locate_sections): Update.
5200         (coff_symfile_read): Remove cleanups.  Update.
5201         (init_stringtab): Add storage parameter.
5202         (free_stringtab, free_stringtab_cleanup): Remove.
5203         (init_lineno): Add storage parameter.
5204         (free_linetab, free_linetab_cleanup): Remove.
5205
5206 2019-03-06  Pedro Alves  <palves@redhat.com>
5207
5208         * linux-fork.c (fork_info::clobber_regs): Delete.
5209         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5210         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5211         comment.  Adjust.
5212         (scoped_switch_fork_info::scoped_switch_fork_info)
5213         (checkpoint_command, linux_fork_context): Adjust
5214         fork_save_infrun_state calls.
5215
5216 2019-03-06  Pedro Alves  <palves@redhat.com>
5217
5218         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5219         (inf_has_multiple_threads): Return 'bool' and rewrite using
5220         inferior_info::threads().
5221
5222 2019-03-06  Pedro Alves  <palves@redhat.com>
5223
5224         * linux-fork.c: Include <list>.
5225         (fork_list): Now a std::list instance.
5226         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5227         (forks_exist_p, find_last_fork): Adjust.
5228         (new_fork): Delete.
5229         (one_fork_p): New.
5230         (add_fork): Adjust.
5231         (free_fork): Delete, folded into fork_info::~fork_info().
5232         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5233         Adjust.
5234         (init_fork_list): Delete.
5235         (linux_fork_killall, linux_fork_mourn_inferior)
5236         (linux_fork_detach, info_checkpoints_command): Adjust.
5237         (_initialize_linux_fork): No longer call init_fork_list.
5238
5239 2019-03-06  Pedro Alves  <palves@redhat.com>
5240
5241         * linux-fork.c (new_fork): New, split out of ...
5242         (add_fork): ... this.  Return void.  Move "first fork" special
5243         case from here, to ...
5244         (checkpoint_command): ... here.
5245         * linux-linux.h (add_fork): Return void.
5246
5247 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5248
5249         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5250
5251 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5252             Chris January  <chris.january@arm.com>
5253             David Lecomber  <david.lecomber@arm.com>
5254
5255         * f-exp.y: New token, UNOP_INTRINSIC.
5256         (exp): New pattern using UNOP_INTRINSIC token.
5257         (f77_keywords): Add 'abs' keyword.
5258         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5259         (value_from_host_double): New function.
5260         (evaluate_subexp_f): Support UNOP_ABS.
5261
5262 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5263
5264         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5265         types.
5266
5267 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5268
5269         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5270         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5271         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5272
5273 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5274
5275         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5276
5277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5278             Chris January  <chris.january@arm.com>
5279
5280         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5281         * f-exp.y: Define 'KIND' token.
5282         (exp): New pattern for KIND expressions.
5283         (ptype): Handle types with a kind extension.
5284         (direct_abs_decl): Extend to spot kind extensions.
5285         (f77_keywords): Add 'kind' to the list.
5286         (push_kind_type): New function.
5287         (convert_to_kind_type): New function.
5288         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5289         * parse.c (operator_length_standard): Likewise.
5290         * parser-defs.h (enum type_pieces): Add tp_kind.
5291         * std-operator.def: Add UNOP_KIND.
5292
5293 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5294
5295         * f-exp.y (f_parse): Set yydebug.
5296
5297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5298
5299         * f-lang.c (evaluate_subexp_f): New function.
5300         (exp_descriptor_f): New global.
5301         (f_language_defn): Use exp_descriptor_f instead of
5302         exp_descriptor_standard.
5303
5304 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5305
5306         * f-exp.y (struct token): Add comments.
5307         (dot_ops): Remove uppercase versions and the end marker.
5308         (f77_keywords): Likewise.
5309         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5310         entries in the dot_ops array are case insensitive, and use
5311         strncasecmp to compare strings.  Also some whitespace cleanup in
5312         this area.  Similar for the f77_keywords array, except entries in
5313         this list might be case sensitive.
5314
5315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5316
5317         * f-exp.y (struct f77_boolean_val): Add comments.
5318         (boolean_values): Remove uppercase versions, and end marker.
5319         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5320         and use strncasecmp to achieve case insensitivity.  Additionally,
5321         perform whitespace cleanup around this code.
5322
5323 2019-03-06  Tom Tromey  <tromey@adacore.com>
5324
5325         * remote-sim.c (gdbsim_target_open): Use result of
5326         gdb_argv::release.
5327
5328 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5329         Dirk Schubert  <dirk.schubert@arm.com>
5330         Chris January  <chris.january@arm.com>
5331
5332         * eval.c (evaluate_subexp_standard): Call Fortran argument
5333         wrapping logic.
5334         * f-lang.c (struct value): A value which can be passed into a
5335         Fortran function call.
5336         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5337         where appropriate.
5338         (struct type): Value ready for a Fortran function call.
5339         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5340         is needed.
5341         * f-lang.h (fortran_argument_convert): Declaration.
5342         (fortran_preserve_arg_pointer): Declaration.
5343         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5344
5345 2019-03-05  Tom Tromey  <tromey@adacore.com>
5346
5347         * python/py-prettyprint.c (print_string_repr): Remove #if.
5348         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5349
5350 2019-03-05  Tom Tromey  <tromey@adacore.com>
5351
5352         * target.c (the_dummy_target): Move later.  Change type to
5353         "dummy_target".
5354         (initialize_targets): Don't initialize the_dummy_target.
5355
5356 2019-03-05  Tom Tromey  <tromey@adacore.com>
5357
5358         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5359         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5360
5361 2019-03-05  Tom Tromey  <tromey@adacore.com>
5362
5363         * windows-nat.c (windows_nat_target::attach)
5364         (windows_nat_target::detach): Don't call gdb_flush.
5365         * valprint.c (generic_val_print, val_print, val_print_string):
5366         Don't call gdb_flush.
5367         * utils.c (defaulted_query): Don't call gdb_flush.
5368         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5369         * target.c (target_announce_detach): Don't call gdb_flush.
5370         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5371         * remote.c (extended_remote_target::attach): Don't call
5372         gdb_flush.
5373         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5374         * printcmd.c (do_examine): Don't call gdb_flush.
5375         (info_display_command): Don't call gdb_flush.
5376         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5377         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5378         * memattr.c (info_mem_command): Don't call gdb_flush.
5379         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5380         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5381         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5382         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5383         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5384         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5385         (gnu_nat_target::detach): Don't call gdb_flush.
5386         * f-valprint.c (f_val_print): Don't call gdb_flush.
5387         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5388         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5389         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5390         gdb_flush.
5391         * c-valprint.c (c_val_print): Don't call gdb_flush.
5392         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5393
5394 2019-03-05  Tom Tromey  <tromey@adacore.com>
5395
5396         * varobj.c (update_dynamic_varobj_children): Update.
5397         (install_default_visualizer): Use reset, not release.
5398         * value.c (set_internalvar): Update.
5399         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5400         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5401         ATTRIBUTE_UNUSED_RESULT.
5402
5403 2019-03-05  Tom Tromey  <tromey@adacore.com>
5404
5405         * remote.c (class scoped_remote_fd) <release>: Add
5406         ATTRIBUTE_UNUSED_RESULT.
5407
5408 2019-03-05  Tom Tromey  <tromey@adacore.com>
5409
5410         * macroexp.c (struct macro_buffer) <release>: Add
5411         ATTRIBUTE_UNUSED_RESULT.
5412
5413 2019-03-05  Tom Tromey  <tromey@adacore.com>
5414
5415         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5416         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5417         ATTRIBUTE_UNUSED_RESULT.
5418
5419 2019-03-05  Tom Tromey  <tromey@adacore.com>
5420
5421         * common/scoped_fd.h (class scoped_fd) <release>: Add
5422         ATTRIBUTE_UNUSED_RESULT.
5423
5424 2019-03-05  Tom Tromey  <tromey@adacore.com>
5425
5426         * parser-defs.h (struct parser_state) <release>: Add
5427         ATTRIBUTE_UNUSED_RESULT.
5428
5429 2019-03-05  Tom Tromey  <tromey@adacore.com>
5430
5431         * utils.h (class gdb_argv) <release>: Add
5432         ATTRIBUTE_UNUSED_RESULT.
5433         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5434
5435 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5436
5437         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5438         for-loop range, to avoid compiler warnings.
5439
5440         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5441         avoid compiler warnings about unused variables.
5442
5443         * NEWS: Mention end of support for native debugging on MS-Windows
5444         before XP.
5445
5446         PR gdb/24292
5447         * common/netstuff.c:
5448         * gdbserver/gdbreplay.c
5449         * gdbserver/remote-utils.c:
5450         * ser-tcp.c:
5451         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5452         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5453         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5454         'getaddrinfo' and 'freeaddrinfo' were not available before
5455         Windows XP, and mingw.org's MinGW headers by default define
5456         _WIN32_WINNT to 0x500.
5457
5458 2019-03-01  Gary Benson <gbenson@redhat.com>
5459
5460         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5461
5462 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5463             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5464
5465         PR gdb/8527
5466         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5467         set_sigint_trap, clear_sigint_trap.
5468
5469 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5470
5471         * target.c (target_detach): Clear the regcache and the
5472         frame cache.
5473
5474 2019-02-27  Pedro Alves  <palves@redhat.com>
5475
5476         * utils.c (set_screen_size): When we cap the height/width sizes,
5477         tweak the corresponding command variable to show "unlimited":
5478
5479 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5480             Pedro Alves  <palves@redhat.com>
5481
5482         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5483         before calling rl_set_screen_size.
5484
5485 2019-02-27  Tom Tromey  <tromey@adacore.com>
5486
5487         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5488         define.
5489         * python/py-value.c: Remove Python 2.4 workaround.
5490         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5491         workaround.
5492         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5493         Python 2.4 workaround.
5494         * python/python-internal.h: Remove Python 2.4 comment.
5495         (Py_ssize_t): Don't define.
5496         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5497         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5498         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5499         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5500         * python/python.c (do_start_initialization): Remove Python 2.4
5501         workaround.
5502         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5503         (print_children): Remove Python 2.4 workaround.
5504         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5505         workaround.
5506         (CHARBUFFERPROC_NAME): Remove.
5507         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5508         Python 2.4 workaround.
5509
5510 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5511
5512         * NEWS: Note minimum Python version.
5513
5514 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5515
5516         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5517         code from these functions.  Remove corresponding ifdefs.  Use
5518         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5519         Remove gotos and target of gotos.
5520         (infpy_search_memory): Likewise.
5521
5522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5523
5524         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5525         (hppa_gdbarch_init): Don't register deleted functions with
5526         gdbarch.
5527
5528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5529
5530         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5531         (h8300_unwind_sp): Delete.
5532         (h8300_dummy_id): Delete.
5533         (h8300_gdbarch_init): Don't register deleted functions with
5534         gdbarch.
5535
5536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5537
5538         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5539         (ft32_unwind_pc): Delete.
5540         (ft32_unwind_sp): Delete.
5541         (ft32_gdbarch_init): Don't register deleted functions with
5542         gdbarch.
5543
5544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5545
5546         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5547         (frv_unwind_pc): Delete.
5548         (frv_unwind_sp): Delete.
5549         (frv_gdbarch_init): Don't register deleted functions with
5550         gdbarch.
5551
5552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5553
5554         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5555         (riscv_unwind_pc): Delete.
5556         (riscv_unwind_sp): Delete.
5557         (riscv_gdbarch_init): Don't register deleted functions with
5558         gdbarch.
5559
5560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5561
5562         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5563         (csky_unwind_pc): Delete.
5564         (csky_unwind_sp): Delete.
5565         (csky_gdbarch_init): Don't register deleted functions with
5566         gdbarch.
5567
5568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5571         (cris_unwind_pc): Delete.
5572         (cris_unwind_sp): Delete.
5573         (cris_gdbarch_init): Don't register deleted functions with
5574         gdbarch.
5575
5576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5577
5578         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5579         (bfin_unwind_pc): Delete.
5580         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5581
5582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5583
5584         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5585         (arm_unwind_pc): Delete.
5586         (arm_unwind_sp): Delete.
5587         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5588
5589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5590
5591         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5592         (arc_unwind_pc): Delete.
5593         (arc_unwind_sp): Delete.
5594         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5595
5596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5597
5598         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5599         (alpha_unwind_pc): Delete.
5600         (alpha_gdbarch_init): Don't register deleted functions with
5601         gdbarch.
5602
5603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5604
5605         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5606         (aarch64_unwind_pc): Delete.
5607         (aarch64_unwind_sp): Delete.
5608         (aarch64_gdbarch_init): Don't register deleted functions with
5609         gdbarch.
5610
5611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5612
5613         * gdbtypes.c (type_align): Don't consider static members when
5614         computing structure alignment.
5615
5616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5617
5618         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5619         return 0 for other types.
5620         * arch-utils.c (default_type_align): Always return 0.
5621         * gdbarch.h: Regenerate.
5622         * gdbarch.sh (type_align): Extend comment.
5623         * gdbtypes.c (type_align): Add additional comments, always call
5624         gdbarch_type_align before applying the default rules.
5625         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5626         generic code will then apply a suitable default.
5627         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5628         types, return 0 for other types.
5629
5630 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5631
5632         * NEWS: Create a new section for the next release branch.
5633         Rename the section of the current branch, now that it has
5634         been cut.
5635
5636 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5637
5638         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5639         * version.in: Bump version to 8.3.50.DATE-git.
5640
5641 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5642
5643         * aix-thread.c (ptid_cmp): Remove unused variable.
5644         (get_signaled_thread): Likewise.
5645         (store_regs_user_thread): Likewise.
5646         (store_regs_kernel_thread): Likewise.
5647         (fetch_regs_kernel_thread): Remove shadowed variable.
5648
5649 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5650
5651         * features/riscv/32bit-cpu.xml: Add register numbers.
5652         * features/riscv/32bit-fpu.c: Regenerate.
5653         * features/riscv/32bit-fpu.xml: Add register numbers.
5654         * features/riscv/64bit-cpu.xml: Add register numbers.
5655         * features/riscv/64bit-fpu.c: Regenerate.
5656         * features/riscv/64bit-fpu.xml: Add register numbers.
5657
5658 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5659
5660         * NEWS: Mention two argument form of gdb.Value constructor.
5661         * python/py-value.c (convert_buffer_and_type_to_value): New
5662         function.
5663         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5664         Add support for handling an optional second argument.  Call
5665         convert_buffer_and_type_to_value as appropriate.
5666         * python/python-internal.h (Py_buffer_deleter): New struct.
5667         (Py_buffer_up): New typedef.
5668
5669 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5670
5671         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5672         instead of releasing ownership.
5673
5674 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5675
5676         * dwarf2read.c (open_and_init_dwp_file): Call
5677         elf_numsections instead of bfd_count_sections to initialize
5678         dwp_file->num_sections.
5679
5680 2019-02-25  Tom Tromey  <tromey@adacore.com>
5681
5682         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5683
5684 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5685
5686         * gcore.in: Add '--readnever' option when invoking GDB.
5687
5688 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5689
5690         * MAINTAINERS: Update my email address.
5691
5692 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5693
5694         * build-id.c (build_id_to_debug_bfd_1): New function.
5695         (build_id_to_debug_bfd): Look for separate debug file in
5696         sysroot.
5697
5698 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5699
5700         * gdbarch.sh: Update the copyright year range that is placed into
5701         generated files.
5702
5703 2019-02-22  Keith Seitz  <keiths@redhat.com>
5704
5705         PR symtab/23853
5706         * linespec.c (create_sals_line_offset): Search for the default
5707         symtab's filename instead of its fullname.
5708
5709 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5710
5711         * NEWS: Update style defaults.
5712
5713 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5714
5715         * main.c (captured_main_1): Disable styling in batch mode.
5716
5717 2019-02-20  Tom Tromey  <tom@tromey.com>
5718
5719         * symtab.c (symtab_symbol_info): Fix typos.
5720
5721 2019-02-20  Tom Tromey  <tromey@adacore.com>
5722
5723         * findcmd.c (_initialize_mem_search): Use upper case for
5724         metasyntactic variables.
5725
5726 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5727
5728         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5729         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5730
5731 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5732
5733         * top.h (source_file_name): Change to std::string.
5734         * top.c (source_file_name): Likewise.
5735         (command_line_input): Adjust.
5736         * cli/cli-script.c (script_from_file): Adjust.
5737
5738 2019-02-19  Tom Tromey  <tromey@adacore.com>
5739
5740         * ravenscar-thread.c
5741         (ravenscar_thread_target::update_thread_list): Don't call
5742         ada_build_task_list.
5743         * ada-lang.h (ada_build_task_list): Don't declare.
5744         * ada-tasks.c (struct ada_tasks_inferior_data)
5745         <task_list_valid_p>: Now bool.
5746         (read_known_tasks, ada_task_list_changed)
5747         (ada_tasks_invalidate_inferior_data): Update.
5748         (read_known_tasks_array): Return bool.
5749         (read_known_tasks_list): Likewise.
5750         (read_known_tasks): Return void.
5751         (ada_build_task_list): Now static.
5752
5753 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5754
5755         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5756         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5757
5758 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5759
5760         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5761         variant for ada_tasks_pspace_data_handle and
5762         ada_tasks_inferior_data_handle.
5763         (ada_tasks_pspace_data_cleanup): New function.
5764         (ada_tasks_inferior_data_cleanup): New function.
5765
5766 2019-02-17  Tom Tromey  <tom@tromey.com>
5767
5768         * macrotab.h (macro_source_fullname): Return a std::string.
5769         * macrotab.c (macro_include, check_for_redefinition)
5770         (macro_undef, macro_lookup_definition, foreach_macro)
5771         (foreach_macro_in_scope): Update.
5772         (macro_source_fullname): Return a std::string.
5773         * macrocmd.c (show_pp_source_pos): Update.
5774
5775 2019-02-17  Tom Tromey  <tom@tromey.com>
5776
5777         * macrocmd.c (show_pp_source_pos): Style the file names.
5778
5779 2019-02-17  Tom Tromey  <tom@tromey.com>
5780
5781         PR tui/24197:
5782         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5783
5784 2019-02-17  Tom Tromey  <tom@tromey.com>
5785
5786         * ada-lang.c (user_select_syms): Use filtered printing.
5787         * utils.c (wrap_style): New global.
5788         (desired_style): Remove.
5789         (emit_style_escape): Add stream parameter.
5790         (set_output_style, reset_terminal_style, prompt_for_continue):
5791         Update.
5792         (flush_wrap_buffer): Only flush gdb_stdout.
5793         (wrap_here): Set wrap_style.
5794         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5795         treat escape sequences as a character.  Change when wrap buffer is
5796         flushed.
5797         (fputs_styled): Do not set the output style when the default is
5798         requested.
5799         * ui-style.h (struct ui_file_style) <is_default>: New method.
5800         * source.c (print_source_lines_base): Emit escape sequences in one
5801         piece.
5802
5803 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5804
5805         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5806         integers and enumeration types.
5807
5808 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5809
5810         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5811         instead of lookup_symbol_in_language
5812         (do_exact_match): New function.
5813         (ada_get_symbol_name_matcher): Return do_exact_match when
5814         doing a verbatim match.
5815
5816 2019-02-15  Tom Tromey  <tromey@adacore.com>
5817
5818         * ravenscar-thread.c (ravenscar_thread_target::resume)
5819         (ravenscar_thread_target::wait): Special case wildcard requests.
5820
5821 2019-02-15  Tom Tromey  <tromey@adacore.com>
5822
5823         * ravenscar-thread.c (base_ptid): Remove.
5824         (struct ravenscar_thread_target) <close>: New method.
5825         <m_base_ptid>: New member.
5826         <update_inferior_ptid, active_task, task_is_currently_active,
5827         runtime_initialized>: Declare methods.
5828         <ravenscar_thread_target>: Add constructor.
5829         (ravenscar_thread_target::task_is_currently_active)
5830         (ravenscar_thread_target::update_inferior_ptid)
5831         (ravenscar_runtime_initialized): Rename.  Now methods.
5832         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5833         (ravenscar_thread_target::update_thread_list): Update.
5834         (ravenscar_thread_target::active_task): Now method.
5835         (ravenscar_thread_target::store_registers)
5836         (ravenscar_thread_target::prepare_to_store)
5837         (ravenscar_thread_target::prepare_to_store)
5838         (ravenscar_thread_target::mourn_inferior): Update.
5839         (ravenscar_inferior_created): Use "new" to create target.
5840         (ravenscar_thread_target::get_ada_task_ptid): Update.
5841         (_initialize_ravenscar): Don't initialize base_ptid.
5842         (ravenscar_ops): Remove global.
5843
5844 2019-02-15  Tom Tromey  <tromey@adacore.com>
5845
5846         * target.h (push_target): Declare new overload.
5847         * target.c (push_target): New overload, taking an rvalue reference.
5848         * remote.c (remote_target::open_1): Use push_target overload.
5849         * corelow.c (core_target_open): Use push_target overload.
5850
5851 2019-02-15  Tom Tromey  <tromey@adacore.com>
5852
5853         * ravenscar-thread.c (is_ravenscar_task)
5854         (ravenscar_task_is_currently_active): Return bool.
5855         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5856         (_initialize_ravenscar): Remove "(void)".
5857         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5858         Return bool.
5859
5860 2019-02-15  Tom Tromey  <tromey@adacore.com>
5861
5862         * ravenscar-thread.c (ravenscar_runtime_initializer)
5863         (has_ravenscar_runtime, get_running_thread_id)
5864         (ravenscar_thread_target::resume): Fix indentation.
5865
5866 2019-02-15  Tom Tromey  <tromey@adacore.com>
5867
5868         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5869         from ravenscar_arch_ops.
5870         (sparc_ravenscar_ops::fetch_registers)
5871         (sparc_ravenscar_ops::store_registers): Now methods.
5872         (sparc_ravenscar_prepare_to_store): Remove.
5873         (sparc_ravenscar_ops): Redefine.
5874         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5875         methods and destructor.  Remove members.
5876         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5877         (ravenscar_thread_target::store_registers)
5878         (ravenscar_thread_target::prepare_to_store): Update.
5879         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5880         Remove.
5881         (struct ppc_ravenscar_powerpc_ops): Derive from
5882         ravenscar_arch_ops.
5883         (ppc_ravenscar_powerpc_ops::fetch_registers)
5884         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5885         (ppc_ravenscar_powerpc_ops): Redefine.
5886         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5887         (ppc_ravenscar_e500_ops::fetch_registers)
5888         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5889         (ppc_ravenscar_e500_ops): Redefine.
5890         * aarch64-ravenscar-thread.c
5891         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5892         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5893         (aarch64_ravenscar_fetch_registers)
5894         (aarch64_ravenscar_store_registers): Now methods.
5895         (aarch64_ravenscar_ops): Redefine.
5896
5897 2019-02-15  Tom Tromey  <tromey@adacore.com>
5898
5899         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5900         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5901         (ravenscar_thread_target::stopped_by_watchpoint)
5902         (ravenscar_thread_target::stopped_data_address)
5903         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5904
5905 2019-02-15  Tom Tromey  <tromey@adacore.com>
5906
5907         * ravenscar-thread.c: Fix some typos.
5908
5909 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5910             Tom Tromey  <tromey@adacore.com>
5911
5912         * ada-lang.c (ada_exception_sal): Change addr_string to a
5913         std::string.
5914         (create_ada_exception_catchpoint): Update.
5915
5916 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5917             Tom Tromey  <tromey@adacore.com>
5918
5919         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5920         (bp_location_ops): Remove.
5921         (base_breakpoint_allocate_location): Update.
5922         (free_bp_location): Update.
5923         * ada-lang.c (class ada_catchpoint_location)
5924         <ada_catchpoint_location>: Remove ops parameter.
5925         (ada_catchpoint_location_dtor): Remove.
5926         (ada_catchpoint_location_ops): Remove.
5927         (allocate_location_exception): Update.
5928         * breakpoint.h (struct bp_location_ops): Remove.
5929         (class bp_location) <bp_location>: Remove bp_location_ops
5930         parameter.
5931         <~bp_location>: Add destructor.
5932         <ops>: Remove.
5933
5934 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5935             Pedro Alves  <palves@redhat.com>
5936
5937         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5938         'PATH_MAX'.
5939
5940 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5941             Samuel Thibault  <samuel.thibault@gnu.org>
5942             Thomas Schwinge  <thomas@codesourcery.com>
5943
5944         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5945         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5946
5947 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5948
5949         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5950         (check_empty): Use "const char *".
5951
5952         * gnu-nat.c (gnu_nat_target::detach): Instead of
5953         'detach_inferior (pid)' call
5954         'detach_inferior (find_inferior_pid (pid))'.
5955
5956         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5957         'nat/fork-inferior.o'.
5958         * gnu-nat.c: #include "nat/fork-inferior.h".
5959
5960         * gnu-nat.c (gnu_nat_target::detach): Instead of
5961         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5962         * gnu-nat.h: #include "inf-child.h".
5963         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5964         'i386_gnu_nat_target::fetch_registers'.
5965         (gnu_store_registers): Rename/move to
5966         'i386_gnu_nat_target::store_registers'.
5967
5968         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5969         * gnu-nat.h (mach_thread_info): New function.
5970         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5971
5972         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5973
5974 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5975
5976         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5977
5978 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5979
5980         * windows-nat.c (windows_add_thread): Add new parameter
5981         "main_thread_p" with default value set to false.  Update
5982         function documentation as well as all callers.
5983         (windows_delete_thread): Likewise.
5984         (fake_create_process): Update call to windows_add_thread.
5985         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5986         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5987         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5988         call to windows_delete_thread.
5989
5990 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5991
5992         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5993
5994 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5995
5996         * symfile.c (find_separate_debug_file): Use canonical path of
5997         sysroot with child_path instead of gdb_sysroot if it is valid.
5998
5999 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6000
6001         * symfile.c (find_separate_debug_file): Use child_path to
6002         determine if an object file is under a sysroot.
6003
6004 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6005
6006         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6007         unittests/child-path-selftests.c.
6008         * common/pathstuff.c (child_path): New function.
6009         * common/pathstuff.h (child_path): New prototype.
6010         * unittests/child-path-selftests.c: New file.
6011
6012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6013
6014         * symfile.c (find_separate_debug_file): Look for separate debug
6015         files in debug directories under the sysroot.
6016
6017 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6018
6019         * symtab.h (struct minimal_symbol data_p): New const method.
6020         (struct minimal_symbol text_p): Likewise.
6021         * symtab.c (output_source_filename): Use file name style
6022         to print file name.
6023         (print_symbol_info): Likewise.
6024         (print_msymbol_info): Use address style to print addresses.
6025         Use function name style to print executable text symbols.
6026         (expand_symtab_containing_pc): Use data_p.
6027         (find_pc_sect_compunit_symtab): Likewise.
6028
6029 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6030
6031         * breakpoint.c (describe_other_breakpoints): Use address style
6032         to print addresses.
6033         (say_where): Likewise.
6034
6035 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6036
6037         * ada-typeprint.c (print_func_type): Print function name
6038         style to print function name.
6039         * c-typeprint.c (c_print_type_1): Likewise.
6040
6041 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6042
6043         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6044         for execve.
6045
6046 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6047
6048         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6049         type_stack.
6050
6051 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6052
6053         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6054         TYPE_CODE_REF types.
6055
6056 2019-02-08  Jim Wilson  <jimw@sifive.com>
6057
6058         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6059         (riscv_linux_fregset): New.
6060         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6061
6062 2019-02-07  Tom Tromey  <tom@tromey.com>
6063
6064         * thread.c (thread_cancel_execution_command): Update.
6065         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6066         methods.
6067         (struct thread_fsm_ops): Remove.
6068         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6069         (thread_fsm_should_stop, thread_fsm_return_value)
6070         (thread_fsm_set_finished, thread_fsm_finished_p)
6071         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6072         Don't declare.
6073         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6074         * infrun.c (clear_proceed_status_thread)
6075         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6076         (print_stop_event): Update.
6077         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6078         Add constructor.
6079         (step_command_fsm_ops): Remove.
6080         (new_step_command_fsm): Remove.
6081         (step_1): Update.
6082         (step_command_fsm::should_stop): Rename from
6083         step_command_fsm_should_stop.
6084         (step_command_fsm::clean_up): Rename from
6085         step_command_fsm_clean_up.
6086         (step_command_fsm::do_async_reply_reason): Rename from
6087         step_command_fsm_async_reply_reason.
6088         (struct until_next_fsm): Inherit from thread_fsm.  Add
6089         constructor.
6090         (until_next_fsm_ops): Remove.
6091         (new_until_next_fsm): Remove.
6092         (until_next_fsm::should_stop): Rename from
6093         until_next_fsm_should_stop.
6094         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6095         (until_next_fsm::do_async_reply_reason): Rename from
6096         until_next_fsm_async_reply_reason.
6097         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6098         constructor.  Change type of breakpoint.
6099         (finish_command_fsm_ops): Remove.
6100         (new_finish_command_fsm): Remove.
6101         (finish_command_fsm::should_stop): Rename from
6102         finish_command_fsm_should_stop.
6103         (finish_command_fsm::clean_up): Rename from
6104         finish_command_fsm_clean_up.
6105         (finish_command_fsm::return_value): Rename from
6106         finish_command_fsm_return_value.
6107         (finish_command_fsm::do_async_reply_reason): Rename from
6108         finish_command_fsm_async_reply_reason.
6109         (finish_command): Update.
6110         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6111         Add constructor.
6112         (call_thread_fsm_ops): Remove.
6113         (call_thread_fsm::call_thread_fsm): Rename from
6114         new_call_thread_fsm.
6115         (call_thread_fsm::should_stop): Rename from
6116         call_thread_fsm_should_stop.
6117         (call_thread_fsm::should_notify_stop): Rename from
6118         call_thread_fsm_should_notify_stop.
6119         (run_inferior_call, call_function_by_hand_dummy): Update.
6120         * cli/cli-interp.c (should_print_stop_to_console): Update.
6121         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6122         Add constructor.  Change type of location_breakpoint,
6123         caller_breakpoint.
6124         (until_break_fsm_ops): Remove.
6125         (new_until_break_fsm): Remove.
6126         (until_break_fsm::should_stop): Rename from
6127         until_break_fsm_should_stop.
6128         (until_break_fsm::clean_up): Rename from
6129         until_break_fsm_clean_up.
6130         (until_break_fsm::do_async_reply_reason): Rename from
6131         until_break_fsm_async_reply_reason.
6132         (until_break_command): Update.
6133         * thread-fsm.c: Remove.
6134         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6135
6136 2019-02-07  Tom Tromey  <tom@tromey.com>
6137
6138         * yy-remap.h: Add include guard.
6139         * xtensa-tdep.h: Add include guard.
6140         * xcoffread.h: Rename include guard.
6141         * varobj-iter.h: Add include guard.
6142         * tui/tui.h: Rename include guard.
6143         * tui/tui-winsource.h: Rename include guard.
6144         * tui/tui-wingeneral.h: Rename include guard.
6145         * tui/tui-windata.h: Rename include guard.
6146         * tui/tui-win.h: Rename include guard.
6147         * tui/tui-stack.h: Rename include guard.
6148         * tui/tui-source.h: Rename include guard.
6149         * tui/tui-regs.h: Rename include guard.
6150         * tui/tui-out.h: Rename include guard.
6151         * tui/tui-layout.h: Rename include guard.
6152         * tui/tui-io.h: Rename include guard.
6153         * tui/tui-hooks.h: Rename include guard.
6154         * tui/tui-file.h: Rename include guard.
6155         * tui/tui-disasm.h: Rename include guard.
6156         * tui/tui-data.h: Rename include guard.
6157         * tui/tui-command.h: Rename include guard.
6158         * tic6x-tdep.h: Add include guard.
6159         * target/waitstatus.h: Rename include guard.
6160         * target/wait.h: Rename include guard.
6161         * target/target.h: Rename include guard.
6162         * target/resume.h: Rename include guard.
6163         * target-float.h: Rename include guard.
6164         * stabsread.h: Add include guard.
6165         * rs6000-tdep.h: Add include guard.
6166         * riscv-fbsd-tdep.h: Add include guard.
6167         * regformats/regdef.h: Rename include guard.
6168         * record.h: Rename include guard.
6169         * python/python.h: Rename include guard.
6170         * python/python-internal.h: Rename include guard.
6171         * python/py-stopevent.h: Rename include guard.
6172         * python/py-ref.h: Rename include guard.
6173         * python/py-record.h: Rename include guard.
6174         * python/py-record-full.h: Rename include guard.
6175         * python/py-record-btrace.h: Rename include guard.
6176         * python/py-instruction.h: Rename include guard.
6177         * python/py-events.h: Rename include guard.
6178         * python/py-event.h: Rename include guard.
6179         * procfs.h: Add include guard.
6180         * proc-utils.h: Add include guard.
6181         * p-lang.h: Add include guard.
6182         * or1k-tdep.h: Rename include guard.
6183         * observable.h: Rename include guard.
6184         * nto-tdep.h: Rename include guard.
6185         * nat/x86-linux.h: Rename include guard.
6186         * nat/x86-linux-dregs.h: Rename include guard.
6187         * nat/x86-gcc-cpuid.h: Add include guard.
6188         * nat/x86-dregs.h: Rename include guard.
6189         * nat/x86-cpuid.h: Rename include guard.
6190         * nat/ppc-linux.h: Rename include guard.
6191         * nat/mips-linux-watch.h: Rename include guard.
6192         * nat/linux-waitpid.h: Rename include guard.
6193         * nat/linux-ptrace.h: Rename include guard.
6194         * nat/linux-procfs.h: Rename include guard.
6195         * nat/linux-osdata.h: Rename include guard.
6196         * nat/linux-nat.h: Rename include guard.
6197         * nat/linux-namespaces.h: Rename include guard.
6198         * nat/linux-btrace.h: Rename include guard.
6199         * nat/glibc_thread_db.h: Rename include guard.
6200         * nat/gdb_thread_db.h: Rename include guard.
6201         * nat/gdb_ptrace.h: Rename include guard.
6202         * nat/fork-inferior.h: Rename include guard.
6203         * nat/amd64-linux-siginfo.h: Rename include guard.
6204         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6205         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6206         * nat/aarch64-linux.h: Rename include guard.
6207         * nat/aarch64-linux-hw-point.h: Rename include guard.
6208         * mn10300-tdep.h: Add include guard.
6209         * mips-linux-tdep.h: Add include guard.
6210         * mi/mi-parse.h: Rename include guard.
6211         * mi/mi-out.h: Rename include guard.
6212         * mi/mi-main.h: Rename include guard.
6213         * mi/mi-interp.h: Rename include guard.
6214         * mi/mi-getopt.h: Rename include guard.
6215         * mi/mi-console.h: Rename include guard.
6216         * mi/mi-common.h: Rename include guard.
6217         * mi/mi-cmds.h: Rename include guard.
6218         * mi/mi-cmd-break.h: Rename include guard.
6219         * m2-lang.h: Add include guard.
6220         * location.h: Rename include guard.
6221         * linux-record.h: Rename include guard.
6222         * linux-nat.h: Add include guard.
6223         * linux-fork.h: Add include guard.
6224         * i386-darwin-tdep.h: Rename include guard.
6225         * hppa-linux-offsets.h: Add include guard.
6226         * guile/guile.h: Rename include guard.
6227         * guile/guile-internal.h: Rename include guard.
6228         * gnu-nat.h: Rename include guard.
6229         * gdb-stabs.h: Rename include guard.
6230         * frv-tdep.h: Add include guard.
6231         * f-lang.h: Add include guard.
6232         * event-loop.h: Add include guard.
6233         * darwin-nat.h: Rename include guard.
6234         * cp-abi.h: Rename include guard.
6235         * config/sparc/nm-sol2.h: Rename include guard.
6236         * config/nm-nto.h: Rename include guard.
6237         * config/nm-linux.h: Add include guard.
6238         * config/i386/nm-i386gnu.h: Rename include guard.
6239         * config/djgpp/nl_types.h: Rename include guard.
6240         * config/djgpp/langinfo.h: Rename include guard.
6241         * compile/gcc-cp-plugin.h: Add include guard.
6242         * compile/gcc-c-plugin.h: Add include guard.
6243         * compile/compile.h: Rename include guard.
6244         * compile/compile-object-run.h: Rename include guard.
6245         * compile/compile-object-load.h: Rename include guard.
6246         * compile/compile-internal.h: Rename include guard.
6247         * compile/compile-cplus.h: Rename include guard.
6248         * compile/compile-c.h: Rename include guard.
6249         * common/xml-utils.h: Rename include guard.
6250         * common/x86-xstate.h: Rename include guard.
6251         * common/version.h: Rename include guard.
6252         * common/vec.h: Rename include guard.
6253         * common/tdesc.h: Rename include guard.
6254         * common/selftest.h: Rename include guard.
6255         * common/scoped_restore.h: Rename include guard.
6256         * common/scoped_mmap.h: Rename include guard.
6257         * common/scoped_fd.h: Rename include guard.
6258         * common/safe-iterator.h: Rename include guard.
6259         * common/run-time-clock.h: Rename include guard.
6260         * common/refcounted-object.h: Rename include guard.
6261         * common/queue.h: Rename include guard.
6262         * common/ptid.h: Rename include guard.
6263         * common/print-utils.h: Rename include guard.
6264         * common/preprocessor.h: Rename include guard.
6265         * common/pathstuff.h: Rename include guard.
6266         * common/observable.h: Rename include guard.
6267         * common/netstuff.h: Rename include guard.
6268         * common/job-control.h: Rename include guard.
6269         * common/host-defs.h: Rename include guard.
6270         * common/gdb_wait.h: Rename include guard.
6271         * common/gdb_vecs.h: Rename include guard.
6272         * common/gdb_unlinker.h: Rename include guard.
6273         * common/gdb_unique_ptr.h: Rename include guard.
6274         * common/gdb_tilde_expand.h: Rename include guard.
6275         * common/gdb_sys_time.h: Rename include guard.
6276         * common/gdb_string_view.h: Rename include guard.
6277         * common/gdb_splay_tree.h: Rename include guard.
6278         * common/gdb_setjmp.h: Rename include guard.
6279         * common/gdb_ref_ptr.h: Rename include guard.
6280         * common/gdb_optional.h: Rename include guard.
6281         * common/gdb_locale.h: Rename include guard.
6282         * common/gdb_assert.h: Rename include guard.
6283         * common/filtered-iterator.h: Rename include guard.
6284         * common/filestuff.h: Rename include guard.
6285         * common/fileio.h: Rename include guard.
6286         * common/environ.h: Rename include guard.
6287         * common/common-utils.h: Rename include guard.
6288         * common/common-types.h: Rename include guard.
6289         * common/common-regcache.h: Rename include guard.
6290         * common/common-inferior.h: Rename include guard.
6291         * common/common-gdbthread.h: Rename include guard.
6292         * common/common-exceptions.h: Rename include guard.
6293         * common/common-defs.h: Rename include guard.
6294         * common/common-debug.h: Rename include guard.
6295         * common/cleanups.h: Rename include guard.
6296         * common/buffer.h: Rename include guard.
6297         * common/btrace-common.h: Rename include guard.
6298         * common/break-common.h: Rename include guard.
6299         * cli/cli-utils.h: Rename include guard.
6300         * cli/cli-style.h: Rename include guard.
6301         * cli/cli-setshow.h: Rename include guard.
6302         * cli/cli-script.h: Rename include guard.
6303         * cli/cli-interp.h: Rename include guard.
6304         * cli/cli-decode.h: Rename include guard.
6305         * cli/cli-cmds.h: Rename include guard.
6306         * charset-list.h: Add include guard.
6307         * buildsym-legacy.h: Rename include guard.
6308         * bfin-tdep.h: Add include guard.
6309         * ax.h: Rename include guard.
6310         * arm-linux-tdep.h: Add include guard.
6311         * arm-fbsd-tdep.h: Add include guard.
6312         * arch/xtensa.h: Rename include guard.
6313         * arch/tic6x.h: Add include guard.
6314         * arch/i386.h: Add include guard.
6315         * arch/arm.h: Rename include guard.
6316         * arch/arm-linux.h: Rename include guard.
6317         * arch/arm-get-next-pcs.h: Rename include guard.
6318         * arch/amd64.h: Add include guard.
6319         * arch/aarch64-insn.h: Rename include guard.
6320         * arch-utils.h: Rename include guard.
6321         * annotate.h: Add include guard.
6322         * amd64-darwin-tdep.h: Rename include guard.
6323         * aarch64-linux-tdep.h: Add include guard.
6324         * aarch64-fbsd-tdep.h: Add include guard.
6325         * aarch32-linux-nat.h: Add include guard.
6326
6327 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6328
6329         * macrotab.c (macro_define_internal): New function that
6330         factorizes macro_define_object_internal and macro_define_function
6331         code.
6332         (macro_define_object_internal): Use macro_define_internal.
6333         (macro_define_function): Likewise.
6334
6335 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6336
6337         * macrocmd.c (extract_identifier): Return
6338         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6339         callers.
6340
6341 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6342
6343         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6344
6345 2019-02-05  Tom Tromey  <tom@tromey.com>
6346
6347         * target.c (target_stack::unpush): Move assertion earlier.
6348
6349 2019-01-30  Tom Tromey  <tom@tromey.com>
6350
6351         PR python/23615:
6352         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6353         (gdbpy_parse_and_eval): Likewise.
6354         * python/python-internal.h (gdbpy_allow_threads): New class.
6355
6356 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6357
6358         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6359         (aarch64_fbsd_fpregmap): Move earlier.
6360         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6361         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6362         instead of individual calls to trad_frame_set_reg_addr.
6363         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6364         earlier.
6365         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6366         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6367         instead of individual calls to trad_frame_set_reg_addr.
6368
6369 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6370
6371         * CONTRIBUTE: Replace contribution list with wiki link.
6372
6373 2019-01-25  Tom Tromey  <tom@tromey.com>
6374
6375         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6376
6377 2019-01-25  Tom Tromey  <tom@tromey.com>
6378
6379         * xtensa-linux-nat.c: Fix common/ includes.
6380         * xml-support.h: Fix common/ includes.
6381         * xml-support.c: Fix common/ includes.
6382         * x86-linux-nat.c: Fix common/ includes.
6383         * windows-nat.c: Fix common/ includes.
6384         * varobj.h: Fix common/ includes.
6385         * varobj.c: Fix common/ includes.
6386         * value.c: Fix common/ includes.
6387         * valops.c: Fix common/ includes.
6388         * utils.c: Fix common/ includes.
6389         * unittests/xml-utils-selftests.c: Fix common/ includes.
6390         * unittests/utils-selftests.c: Fix common/ includes.
6391         * unittests/unpack-selftests.c: Fix common/ includes.
6392         * unittests/tracepoint-selftests.c: Fix common/ includes.
6393         * unittests/style-selftests.c: Fix common/ includes.
6394         * unittests/string_view-selftests.c: Fix common/ includes.
6395         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6396         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6397         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6398         * unittests/rsp-low-selftests.c: Fix common/ includes.
6399         * unittests/parse-connection-spec-selftests.c: Fix common/
6400         includes.
6401         * unittests/optional-selftests.c: Fix common/ includes.
6402         * unittests/offset-type-selftests.c: Fix common/ includes.
6403         * unittests/observable-selftests.c: Fix common/ includes.
6404         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6405         * unittests/memrange-selftests.c: Fix common/ includes.
6406         * unittests/memory-map-selftests.c: Fix common/ includes.
6407         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6408         * unittests/function-view-selftests.c: Fix common/ includes.
6409         * unittests/environ-selftests.c: Fix common/ includes.
6410         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6411         * unittests/common-utils-selftests.c: Fix common/ includes.
6412         * unittests/cli-utils-selftests.c: Fix common/ includes.
6413         * unittests/array-view-selftests.c: Fix common/ includes.
6414         * ui-file.c: Fix common/ includes.
6415         * tui/tui-io.c: Fix common/ includes.
6416         * tracepoint.h: Fix common/ includes.
6417         * tracepoint.c: Fix common/ includes.
6418         * tracefile-tfile.c: Fix common/ includes.
6419         * top.h: Fix common/ includes.
6420         * top.c: Fix common/ includes.
6421         * thread.c: Fix common/ includes.
6422         * target/waitstatus.h: Fix common/ includes.
6423         * target/waitstatus.c: Fix common/ includes.
6424         * target.h: Fix common/ includes.
6425         * target.c: Fix common/ includes.
6426         * target-memory.c: Fix common/ includes.
6427         * target-descriptions.c: Fix common/ includes.
6428         * symtab.h: Fix common/ includes.
6429         * symfile.c: Fix common/ includes.
6430         * stap-probe.c: Fix common/ includes.
6431         * spu-linux-nat.c: Fix common/ includes.
6432         * sparc-nat.c: Fix common/ includes.
6433         * source.c: Fix common/ includes.
6434         * solib.c: Fix common/ includes.
6435         * solib-target.c: Fix common/ includes.
6436         * ser-unix.c: Fix common/ includes.
6437         * ser-tcp.c: Fix common/ includes.
6438         * ser-pipe.c: Fix common/ includes.
6439         * ser-base.c: Fix common/ includes.
6440         * selftest-arch.c: Fix common/ includes.
6441         * s12z-tdep.c: Fix common/ includes.
6442         * rust-exp.y: Fix common/ includes.
6443         * rs6000-aix-tdep.c: Fix common/ includes.
6444         * riscv-tdep.c: Fix common/ includes.
6445         * remote.c: Fix common/ includes.
6446         * remote-notif.h: Fix common/ includes.
6447         * remote-fileio.h: Fix common/ includes.
6448         * remote-fileio.c: Fix common/ includes.
6449         * regcache.h: Fix common/ includes.
6450         * regcache.c: Fix common/ includes.
6451         * record-btrace.c: Fix common/ includes.
6452         * python/python.c: Fix common/ includes.
6453         * python/py-type.c: Fix common/ includes.
6454         * python/py-inferior.c: Fix common/ includes.
6455         * progspace.h: Fix common/ includes.
6456         * producer.c: Fix common/ includes.
6457         * procfs.c: Fix common/ includes.
6458         * proc-api.c: Fix common/ includes.
6459         * printcmd.c: Fix common/ includes.
6460         * ppc-linux-nat.c: Fix common/ includes.
6461         * parser-defs.h: Fix common/ includes.
6462         * osdata.c: Fix common/ includes.
6463         * obsd-nat.c: Fix common/ includes.
6464         * nat/x86-linux.c: Fix common/ includes.
6465         * nat/x86-linux-dregs.c: Fix common/ includes.
6466         * nat/x86-dregs.h: Fix common/ includes.
6467         * nat/x86-dregs.c: Fix common/ includes.
6468         * nat/ppc-linux.c: Fix common/ includes.
6469         * nat/mips-linux-watch.h: Fix common/ includes.
6470         * nat/mips-linux-watch.c: Fix common/ includes.
6471         * nat/linux-waitpid.c: Fix common/ includes.
6472         * nat/linux-ptrace.h: Fix common/ includes.
6473         * nat/linux-ptrace.c: Fix common/ includes.
6474         * nat/linux-procfs.c: Fix common/ includes.
6475         * nat/linux-personality.c: Fix common/ includes.
6476         * nat/linux-osdata.c: Fix common/ includes.
6477         * nat/linux-namespaces.c: Fix common/ includes.
6478         * nat/linux-btrace.h: Fix common/ includes.
6479         * nat/linux-btrace.c: Fix common/ includes.
6480         * nat/fork-inferior.c: Fix common/ includes.
6481         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6482         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6483         * nat/aarch64-linux.c: Fix common/ includes.
6484         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6485         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6486         * namespace.h: Fix common/ includes.
6487         * mips-linux-tdep.c: Fix common/ includes.
6488         * minsyms.c: Fix common/ includes.
6489         * mi/mi-parse.h: Fix common/ includes.
6490         * mi/mi-main.c: Fix common/ includes.
6491         * mi/mi-cmd-env.c: Fix common/ includes.
6492         * memrange.h: Fix common/ includes.
6493         * memattr.c: Fix common/ includes.
6494         * maint.h: Fix common/ includes.
6495         * maint.c: Fix common/ includes.
6496         * main.c: Fix common/ includes.
6497         * machoread.c: Fix common/ includes.
6498         * location.c: Fix common/ includes.
6499         * linux-thread-db.c: Fix common/ includes.
6500         * linux-nat.c: Fix common/ includes.
6501         * linux-fork.c: Fix common/ includes.
6502         * inline-frame.c: Fix common/ includes.
6503         * infrun.c: Fix common/ includes.
6504         * inflow.c: Fix common/ includes.
6505         * inferior.h: Fix common/ includes.
6506         * inferior.c: Fix common/ includes.
6507         * infcmd.c: Fix common/ includes.
6508         * inf-ptrace.c: Fix common/ includes.
6509         * inf-child.c: Fix common/ includes.
6510         * ia64-linux-nat.c: Fix common/ includes.
6511         * i387-tdep.c: Fix common/ includes.
6512         * i386-tdep.c: Fix common/ includes.
6513         * i386-linux-tdep.c: Fix common/ includes.
6514         * i386-linux-nat.c: Fix common/ includes.
6515         * i386-go32-tdep.c: Fix common/ includes.
6516         * i386-fbsd-tdep.c: Fix common/ includes.
6517         * i386-fbsd-nat.c: Fix common/ includes.
6518         * guile/scm-type.c: Fix common/ includes.
6519         * guile/guile.c: Fix common/ includes.
6520         * go32-nat.c: Fix common/ includes.
6521         * gnu-nat.c: Fix common/ includes.
6522         * gdbthread.h: Fix common/ includes.
6523         * gdbarch-selftests.c: Fix common/ includes.
6524         * gdb_usleep.c: Fix common/ includes.
6525         * gdb_select.h: Fix common/ includes.
6526         * gdb_bfd.c: Fix common/ includes.
6527         * gcore.c: Fix common/ includes.
6528         * fork-child.c: Fix common/ includes.
6529         * findvar.c: Fix common/ includes.
6530         * fbsd-nat.c: Fix common/ includes.
6531         * event-top.c: Fix common/ includes.
6532         * event-loop.c: Fix common/ includes.
6533         * dwarf2read.c: Fix common/ includes.
6534         * dwarf2loc.c: Fix common/ includes.
6535         * dwarf2-frame.c: Fix common/ includes.
6536         * dwarf-index-cache.c: Fix common/ includes.
6537         * dtrace-probe.c: Fix common/ includes.
6538         * disasm-selftests.c: Fix common/ includes.
6539         * defs.h: Fix common/ includes.
6540         * csky-tdep.c: Fix common/ includes.
6541         * cp-valprint.c: Fix common/ includes.
6542         * cp-support.h: Fix common/ includes.
6543         * cp-support.c: Fix common/ includes.
6544         * corelow.c: Fix common/ includes.
6545         * completer.h: Fix common/ includes.
6546         * completer.c: Fix common/ includes.
6547         * compile/compile.c: Fix common/ includes.
6548         * compile/compile-loc2c.c: Fix common/ includes.
6549         * compile/compile-cplus-types.c: Fix common/ includes.
6550         * compile/compile-cplus-symbols.c: Fix common/ includes.
6551         * command.h: Fix common/ includes.
6552         * cli/cli-dump.c: Fix common/ includes.
6553         * cli/cli-cmds.c: Fix common/ includes.
6554         * charset.c: Fix common/ includes.
6555         * build-id.c: Fix common/ includes.
6556         * btrace.h: Fix common/ includes.
6557         * btrace.c: Fix common/ includes.
6558         * breakpoint.h: Fix common/ includes.
6559         * breakpoint.c: Fix common/ includes.
6560         * ax.h:
6561         (enum agent_op): Fix common/ includes.
6562         * ax-general.c (struct aop_map): Fix common/ includes.
6563         * ax-gdb.c: Fix common/ includes.
6564         * auxv.c: Fix common/ includes.
6565         * auto-load.c: Fix common/ includes.
6566         * arm-tdep.c: Fix common/ includes.
6567         * arch/riscv.c: Fix common/ includes.
6568         * arch/ppc-linux-common.c: Fix common/ includes.
6569         * arch/i386.c: Fix common/ includes.
6570         * arch/arm.c: Fix common/ includes.
6571         * arch/arm-linux.c: Fix common/ includes.
6572         * arch/arm-get-next-pcs.c: Fix common/ includes.
6573         * arch/amd64.c: Fix common/ includes.
6574         * arch/aarch64.c: Fix common/ includes.
6575         * arch/aarch64-insn.c: Fix common/ includes.
6576         * arch-utils.c: Fix common/ includes.
6577         * amd64-windows-tdep.c: Fix common/ includes.
6578         * amd64-tdep.c: Fix common/ includes.
6579         * amd64-sol2-tdep.c: Fix common/ includes.
6580         * amd64-obsd-tdep.c: Fix common/ includes.
6581         * amd64-nbsd-tdep.c: Fix common/ includes.
6582         * amd64-linux-tdep.c: Fix common/ includes.
6583         * amd64-linux-nat.c: Fix common/ includes.
6584         * amd64-fbsd-tdep.c: Fix common/ includes.
6585         * amd64-fbsd-nat.c: Fix common/ includes.
6586         * amd64-dicos-tdep.c: Fix common/ includes.
6587         * amd64-darwin-tdep.c: Fix common/ includes.
6588         * agent.c: Fix common/ includes.
6589         * ada-lang.h: Fix common/ includes.
6590         * ada-lang.c: Fix common/ includes.
6591         * aarch64-tdep.c: Fix common/ includes.
6592
6593 2019-01-25  Tom Tromey  <tom@tromey.com>
6594
6595         * common/create-version.sh: Use common/version.h.
6596
6597 2019-01-24  Pedro Alves  <palves@redhat.com>
6598
6599         * infrun.c (signal_stop, signal_print, signal_program)
6600         (signal_catch, signal_pass): Now arrays instead of pointers.
6601         (update_signals_program_target, do_target_resume)
6602         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6603         * linux-nat.c (linux_nat_target::pass_signals)
6604         (linux_nat_target::create_inferior, linux_nat_target::attach):
6605         Adjust.
6606         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6607         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6608         * procfs.c (procfs_target::pass_signals): Adjust.
6609         * record-full.c (record_full_target::resume): Adjust.
6610         * remote.c (remote_target::pass_signals)
6611         (remote_target::program_signals): Adjust.
6612         * target-debug.h (target_debug_print_signals): Now takes a
6613         gdb::array_view as parameter.  Adjust.
6614         * target.h (target_ops) <pass_signals, program_signals>: Replace
6615         pointer and length parameters with gdb::array_view.
6616         (target_pass_signals, target_program_signals): Likewise.
6617         * target-delegates.c: Regenerate.
6618
6619 2019-01-24  Pedro Alves  <palves@redhat.com>
6620
6621         * common/forward-scope-exit.h
6622         (forward_scope_exit::forward_scope_exit): Pass arguments to
6623         m_bind_function directly, instead of creating a std::bind and
6624         copying that.
6625
6626 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6627
6628         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6629         for static members.
6630         (pass_in_v_vfp_candidate): Likewise.
6631
6632 2019-01-23  Tom Tromey  <tom@tromey.com>
6633             Pedro Alves  <palves@redhat.com>
6634
6635         * regcache.c (class regcache_invalidator): Remove.
6636         (regcache::raw_write): Use make_scope_exit.
6637
6638 2019-01-23  Tom Tromey  <tom@tromey.com>
6639
6640         * ui-out.h (class ui_out_emit_type): Update comment.
6641
6642 2019-01-23  Tom Tromey  <tom@tromey.com>
6643
6644         * infrun.c (fetch_inferior_event): Update comment.
6645
6646 2019-01-23  Tom Tromey  <tom@tromey.com>
6647             Pedro Alves  <palves@redhat.com>
6648
6649         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6650         parameter.
6651         (fetch_inferior_event): Use SCOPE_EXIT.
6652
6653
6654 2019-01-23  Tom Tromey  <tom@tromey.com>
6655             Pedro Alves  <palves@redhat.com>
6656
6657         * infrun.c (disable_thread_events): Delete.
6658         (stop_all_threads): Use SCOPE_EXIT.
6659
6660 2019-01-23  Tom Tromey  <tom@tromey.com>
6661             Pedro Alves  <palves@redhat.com>
6662
6663         * symfile.c: Include forward-scope-exit.h.
6664         (clear_symtab_users_cleanup): Replace forward declaration with
6665         a FORWARD_SCOPE_EXIT.
6666         (syms_from_objfile_1): Use the forward_scope_exit and
6667         gdb::optional instead of cleanup_function.
6668         (reread_symbols): Use the forward_scope_exit instead of
6669         cleanup_function.
6670         (clear_symtab_users_cleanup): Remove function.
6671
6672 2019-01-23  Tom Tromey  <tom@tromey.com>
6673             Pedro Alves  <palves@redhat.com>
6674
6675         * linux-nat.c: Include scope-exit.h.
6676         (cleanup_target_stop): Remove.
6677         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6678         SCOPE_EXIT.
6679
6680 2019-01-23  Tom Tromey  <tom@tromey.com>
6681             Pedro Alves  <palves@redhat.com>
6682
6683         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6684         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6685
6686 2019-01-23  Tom Tromey  <tom@tromey.com>
6687             Andrew Burgess  <andrew.burgess@embecosm.com>
6688             Pedro Alves  <palves@redhat.com>
6689
6690         * infrun.c (fetch_inferior_event): Use scope_exit.
6691         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6692         * top.c (execute_command): Use scope_exit.
6693         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6694         * utils.c (do_bpstat_clear_actions_cleanup)
6695         (make_bpstat_clear_actions_cleanup): Remove.
6696
6697 2019-01-23  Tom Tromey  <tom@tromey.com>
6698             Pedro Alves  <palves@redhat.com>
6699
6700         * infrun.c: Include "common/scope-exit.h"
6701         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6702         (wait_for_inferior): Use SCOPE_EXIT.
6703         (fetch_inferior_event): Use scope_exit.
6704
6705 2019-01-23  Tom Tromey  <tom@tromey.com>
6706             Pedro Alves  <palves@redhat.com>
6707
6708         * breakpoint.c (create_breakpoint): Remove cleanup.
6709
6710 2019-01-23  Tom Tromey  <tom@tromey.com>
6711             Andrew Burgess  <andrew.burgess@embecosm.com>
6712             Pedro Alves  <palves@redhat.com>
6713
6714 2019-01-23  Pedro Alves  <palves@redhat.com>
6715
6716         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6717
6718 2019-01-23  Pedro Alves  <palves@redhat.com>
6719             Andrew Burgess  <andrew.burgess@embecosm.com>
6720
6721         * gdbthread.h: Include "common/forward-scope-exit.h".
6722         (scoped_finish_thread_state): Redefine custom class in terms of
6723         forward_scope_exit.
6724
6725 2019-01-23  Pedro Alves  <palves@redhat.com>
6726             Andrew Burgess  <andrew.burgess@embecosm.com>
6727
6728         * common/forward-scope-exit.h: New file.
6729
6730 2019-01-23  Pedro Alves  <palves@redhat.com>
6731             Andrew Burgess  <andrew.burgess@embecosm.com>
6732             Tom Tromey  <tom@tromey.com>
6733
6734         * common/scope-exit.h: New file.
6735
6736 2019-01-23  Pedro Alves  <palves@redhat.com>
6737
6738         * common/preprocessor.h (ESC): Rename to ...
6739         (ESC_PARENS): ... this.
6740         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6741         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6742
6743 2019-01-23  Tom Tromey  <tom@tromey.com>
6744
6745         * language.h (class scoped_switch_to_sym_language_if_auto):
6746         Initialize m_lang in both cases.
6747
6748 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6749
6750         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6751         with XCNEW.
6752
6753 2019-01-22  Tom Tromey  <tom@tromey.com>
6754
6755         * corelow.c: Do not include sys/file.h.
6756
6757 2019-01-22  Tom Tromey  <tom@tromey.com>
6758
6759         * tui/tui-wingeneral.h: Include gdb_curses.h.
6760
6761 2019-01-22  Tom Tromey  <tom@tromey.com>
6762
6763         * source-cache.h (class source_cache) <get_source_lines,
6764         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6765
6766 2019-01-22  Tom Tromey  <tom@tromey.com>
6767
6768         * remote-fileio.h (struct remote_target): Declare.
6769
6770 2019-01-22  Tom Tromey  <tom@tromey.com>
6771
6772         * python/py-arch.c: Do not include py-ref.h.
6773         * python/py-bpevent.c: Do not include py-ref.h.
6774         * python/py-cmd.c: Do not include py-ref.h.
6775         * python/py-continueevent.c: Do not include py-ref.h.
6776         * python/py-event.h: Do not include py-ref.h.
6777         * python/py-evtregistry.c: Do not include py-ref.h.
6778         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6779         * python/py-frame.c: Do not include py-ref.h.
6780         * python/py-framefilter.c: Do not include py-ref.h.
6781         * python/py-function.c: Do not include py-ref.h.
6782         * python/py-infevents.c: Do not include py-ref.h.
6783         * python/py-linetable.c: Do not include py-ref.h.
6784         * python/py-objfile.c: Do not include py-ref.h.
6785         * python/py-param.c: Do not include py-ref.h.
6786         * python/py-prettyprint.c: Do not include py-ref.h.
6787         * python/py-progspace.c: Do not include py-ref.h.
6788         * python/py-symbol.c: Do not include py-ref.h.
6789         * python/py-symtab.c: Do not include py-ref.h.
6790         * python/py-type.c: Do not include py-ref.h.
6791         * python/py-unwind.c: Do not include py-ref.h.
6792         * python/py-utils.c: Do not include py-ref.h.
6793         * python/py-value.c: Do not include py-ref.h.
6794         * python/py-varobj.c: Do not include py-ref.h.
6795         * python/py-xmethods.c: Do not include py-ref.h.
6796         * python/python.c: Do not include py-ref.h.
6797         * varobj.c: Do not include py-ref.h.
6798
6799 2019-01-22  Tom Tromey  <tom@tromey.com>
6800
6801         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6802         keyword for bcache.
6803
6804 2019-01-22  Tom Tromey  <tom@tromey.com>
6805
6806         * compile/compile-cplus-types.c: Remove a comment by #include.
6807
6808 2019-01-22  Tom Tromey  <tom@tromey.com>
6809
6810         * compile/gcc-c-plugin.h: Include compile-internal.h.
6811
6812 2019-01-22  Tom Tromey  <tom@tromey.com>
6813
6814         * stabsread.c (EXTERN): Do not define.
6815         (symnum, next_symbol_text_func, processing_gcc_compilation)
6816         (within_function, global_sym_chain, global_stabs)
6817         (previous_stab_code, this_object_header_files)
6818         (n_this_object_header_files)
6819         (n_allocated_this_object_header_files): Define.
6820         * stabsread.h (EXTERN): Never define.  Use "extern".
6821
6822 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6823
6824         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6825         history_value.
6826
6827 2019-01-21  Tom Tromey  <tom@tromey.com>
6828
6829         * ui-out.c: Fix includes.
6830         * tui/tui-source.c: Fix includes.
6831         * target.c: Fix includes.
6832         * remote.c: Fix includes.
6833         * regcache.c: Fix includes.
6834         * python/py-block.c: Fix includes.
6835         * printcmd.c: Fix includes.
6836         * or1k-tdep.c: Fix includes.
6837         * mi/mi-main.c: Fix includes.
6838         * m32r-tdep.c: Fix includes.
6839         * csky-tdep.c: Fix includes.
6840         * compile/compile-cplus-types.c: Fix includes.
6841         * cli/cli-interp.c: Fix includes.
6842
6843 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6844
6845         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6846         for padding.
6847
6848 2019-01-16  Tom Tromey  <tom@tromey.com>
6849
6850         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6851         earlier.
6852         (struct objfile) <msymbols_range>: Move from top level.
6853         <msymbols>: New method.
6854         (class objfile_msymbols): Remove.
6855         * symtab.c (default_collect_symbol_completion_matches_break_on):
6856         Update.
6857         * symmisc.c (dump_msymbols): Update.
6858         * stabsread.c (scan_file_globals): Update.
6859         * objc-lang.c (info_selectors_command, info_classes_command)
6860         (find_methods): Update.
6861         * minsyms.c (find_solib_trampoline_target): Update.
6862         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6863         * coffread.c (coff_symfile_read): Update.
6864         * ada-lang.c (ada_lookup_simple_minsym)
6865         (ada_collect_symbol_completion_matches): Update.
6866
6867 2019-01-16  Tom Tromey  <tom@tromey.com>
6868
6869         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6870         type.  Remove no-argument constructor.
6871         <iterator::operator++>: Simplify.
6872         <begin>: Update.
6873         <end>: Use minimal_symbol_count.
6874
6875 2019-01-16  Tom Tromey  <tom@tromey.com>
6876
6877         * objfiles.h (struct objfile) <psymtabs>: New method.
6878         (class objfile_psymtabs): Remove.
6879         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6880         typedef.
6881         <range>: New method.
6882         (require_partial_symbols): Change return type.
6883         * psymtab.c (require_partial_symbols)
6884         (psym_expand_symtabs_matching): Update.
6885         * mdebugread.c (parse_partial_symbols): Update.
6886         * dbxread.c (dbx_end_psymtab): Update.
6887
6888 2019-01-15  Tom Tromey  <tom@tromey.com>
6889
6890         * symtab.c (lookup_objfile_from_block)
6891         (lookup_symbol_in_objfile_symtabs)
6892         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6893         (find_line_symtab, info_sources_command)
6894         (default_collect_symbol_completion_matches_break_on)
6895         (make_source_files_completion_list): Update.
6896         * symmisc.c (print_objfile_statistics, dump_objfile)
6897         (maintenance_print_symbols, maintenance_info_symtabs)
6898         (maintenance_check_symtabs, maintenance_info_line_tables):
6899         Update.
6900         * source.c (select_source_symtab)
6901         (forget_cached_source_info_for_objfile): Update.
6902         * objfiles.h (class objfile_compunits): Remove.
6903         (struct objfile) <compunits_range>: New typedef.
6904         (compunits): New method.
6905         * objfiles.c (objfile_relocate1): Update.
6906         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6907         * maint.c (count_symtabs_and_blocks): Update.
6908         * linespec.c (iterate_over_all_matching_symtabs): Update.
6909         * cp-support.c (add_symbol_overload_list_qualified): Update.
6910         * coffread.c (coff_symtab_read): Update.
6911         * ada-lang.c (add_nonlocal_symbols)
6912         (ada_collect_symbol_completion_matches)
6913         (ada_add_global_exceptions): Update.
6914
6915 2019-01-15  Tom Tromey  <tom@tromey.com>
6916
6917         * progspace.h (program_space) <objfiles_safe_range>: New
6918         typedef.
6919         <objfiles_safe>: New method.
6920         * objfiles.h (class all_objfiles_safe): Remove.
6921         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6922         * jit.c (jit_inferior_exit_hook): Update.
6923
6924 2019-01-17  Tom Tromey  <tom@tromey.com>
6925
6926         * progspace.h (program_space) <objfiles_range>: New typedef.
6927         <objfiles>: New method.
6928         <objfiles_head>: Rename from objfiles.
6929         (object_files): Update.
6930         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6931         * guile/scm-pretty-print.c
6932         (ppscm_find_pretty_printer_from_objfiles): Update.
6933         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6934         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6935         Update.
6936         * python/py-progspace.c (pspy_get_objfiles): Update.
6937         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6938         Update.
6939         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6940         (objfpy_lookup_objfile_by_build_id): Update.
6941         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6942         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6943         Update.
6944         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6945         (expand_symtab_containing_pc, lookup_objfile_from_block)
6946         (lookup_static_symbol, basic_lookup_transparent_type)
6947         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6948         (find_line_symtab, info_sources_command)
6949         (default_collect_symbol_completion_matches_break_on)
6950         (make_source_files_completion_list, find_main_name): Update.
6951         * symmisc.c (print_symbol_bcache_statistics)
6952         (print_objfile_statistics, maintenance_print_symbols)
6953         (maintenance_print_msymbols, maintenance_print_objfiles)
6954         (maintenance_info_symtabs, maintenance_check_symtabs)
6955         (maintenance_expand_symtabs, maintenance_info_line_tables):
6956         Update.
6957         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6958         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6959         (map_overlay_command, unmap_overlay_command)
6960         (simple_overlay_update, expand_symtabs_matching)
6961         (map_symbol_filenames): Update.
6962         * symfile-debug.c (set_debug_symfile): Update.
6963         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6964         Update.
6965         * source.c (select_source_symtab, forget_cached_source_info):
6966         Update.
6967         * solib.c (solib_read_symbols): Update.
6968         * solib-spu.c (append_ocl_sos): Update.
6969         * psymtab.c (maintenance_print_psymbols)
6970         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6971         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6972         * printcmd.c (info_symbol_command): Update.
6973         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6974         Update.
6975         * objfiles.h (class all_objfiles): Remove.
6976         * objfiles.c (have_partial_symbols, have_full_symbols)
6977         (have_minimal_symbols, qsort_cmp, update_section_map)
6978         (shared_objfile_contains_address_p)
6979         (default_iterate_over_objfiles_in_search_order): Update.
6980         * objc-lang.c (info_selectors_command, info_classes_command)
6981         (find_methods): Update.
6982         * minsyms.c (find_solib_trampoline_target): Update.
6983         * maint.c (maintenance_info_sections)
6984         (maintenance_translate_address, count_symtabs_and_blocks):
6985         Update.
6986         * main.c (captured_main_1): Update.
6987         * linux-thread-db.c (try_thread_db_load_from_pdir)
6988         (has_libpthread): Update.
6989         * linespec.c (iterate_over_all_matching_symtabs)
6990         (search_minsyms_for_name): Update.
6991         * jit.c (jit_find_objf_with_entry_addr): Update.
6992         * hppa-tdep.c (find_unwind_entry)
6993         (hppa_lookup_stub_minimal_symbol): Update.
6994         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6995         Update.
6996         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6997         (elf_gnu_ifunc_resolve_by_got): Update.
6998         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6999         * dwarf-index-write.c (save_gdb_index_command): Update.
7000         * cp-support.c (add_symbol_overload_list_qualified): Update.
7001         * breakpoint.c (create_overlay_event_breakpoint)
7002         (create_longjmp_master_breakpoint)
7003         (create_std_terminate_master_breakpoint)
7004         (create_exception_master_breakpoint): Update.
7005         * blockframe.c (find_pc_partial_function): Update.
7006         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7007         (ada_collect_symbol_completion_matches)
7008         (ada_add_global_exceptions): Update.
7009
7010 2019-01-17  Tom Tromey  <tom@tromey.com>
7011
7012         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7013         declare VEC.
7014         (solib_target_parse_libraries): Change return type.
7015         (library_list_start_segment, library_list_start_section)
7016         (library_list_end_library, library_list_start_library); Update.
7017         (solib_target_free_library_list): Remove.
7018         (solib_target_parse_libraries): Remove cleanup.  Change return
7019         type.
7020         (solib_target_current_sos): Update.
7021
7022 2019-01-17  Tom Tromey  <tromey@bapiya>
7023
7024         * valprint.c: Replace "the the" with "the".
7025         * symtab.c: Replace "the the" with "the".
7026         * solib.c: Replace "the the" with "the".
7027         * solib-dsbt.c: Replace "the the" with "the".
7028         * linespec.c: Replace "the the" with "the".
7029         * dwarf2loc.h: Replace "the the" with "the".
7030         * amd64-windows-tdep.c: Replace "the the" with "the".
7031         * aarch64-tdep.c: Replace "the the" with "the".
7032
7033 2019-01-16  Keith Seitz  <keiths@redhat.com>
7034
7035         PR gdb/23773
7036         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7037         <builder>: Rename to ..
7038         <m_builder>: ... this and make private.
7039         (dwarf2_cu::get_builder): New method.  Change all users of
7040         `builder' to use this method.
7041         (dwarf2_start_symtab): Move to ...
7042         (dwarf2_cu::start_symtab): ... here.  Update all callers
7043         (setup_type_unit_groups): Move to ...
7044         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7045         callers.
7046         (dwarf2_cu::reset_builder): New method.
7047         (process_full_compunit, process_full_type_unit): Use
7048         dwarf2_cu::reset_builder.
7049         (follow_die_offset): Record the ancestor CU if it is different
7050         from the followed DIE's CU.
7051         (follow_die_sig_1): Likewise.
7052
7053 2019-01-15  Tom Tromey  <tom@tromey.com>
7054
7055         * remote.c (class remote_state) <buf>: Now a char_vector.
7056         <buf_size>: Remove.
7057         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7058         parameter.
7059         (remote_target::getpkt_or_notif_sane_1)
7060         (remote_target::getpkt_sane)
7061         (remote_target::getpkt_or_notif_sane): Likewise.
7062         (class remote_target) <putpkt>: New overload.
7063         (remote_target::read_frame): Change type of "buf_p".  Remove
7064         sizeof_p parameter.
7065         (packet_ok): New overload.
7066         (packet_check_result): New overload.
7067         Update all uses.
7068
7069 2019-01-14  Tom Tromey  <tom@tromey.com>
7070
7071         * remote-notif.c (handle_notification, remote_notif_ack)
7072         (remote_notif_parse): Make "buf" const.
7073         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7074         const.
7075         (remote_notif_parse, remote_notif_ack, handle_notification):
7076         Likewise.
7077         * remote.c (remote_notif_stop_parse): Make "buf" const.
7078         (remote_target::remote_parse_stop_reply): Make "buf" const.
7079         (remote_notif_stop_ack): Make "buf" const.
7080
7081 2019-01-14  Tom Tromey  <tom@tromey.com>
7082
7083         * remote.c (remote_console_output): Make parameter const.
7084
7085 2019-01-14  Tom Tromey  <tom@tromey.com>
7086
7087         * target-debug.h (target_debug_print_signals): Constify.
7088         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7089         * procfs.c (procfs_target::pass_signals): Update.
7090         * linux-nat.c (linux_nat_target::pass_signals): Update.
7091         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7092         * target-delegates.c: Rebuild.
7093         * remote.c (remote_target::program_signals): Update.
7094         (remote_target::pass_signals): Update.
7095         * target.c (target_pass_signals): Constify argument.
7096         (target_program_signals): Likewise.
7097         * target.h (struct target_ops) <pass_signals, program_signals>:
7098         Constify argument.
7099         (target_pass_signals, target_program_signals): Constify argument.
7100
7101 2019-01-14  Tom Tromey  <tom@tromey.com>
7102
7103         PR tui/28819:
7104         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7105
7106 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7107
7108         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7109         field.
7110         * rs6000-tdep.c: Include reggroups.h.
7111         (IS_V_ALIAS_PSEUDOREG): Define.
7112         (rs6000_register_name): Return names for the "vX" aliases.
7113         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7114         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7115         aliases.  Call default_register_reggroup_p for all other
7116         pseudo-registers.
7117         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7118         New functions.
7119         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7120         Handle "vX" aliases.
7121         (v_alias_pseudo_register_collect): New function.
7122         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7123         (rs6000_gdbarch_init): Initialize "vX" aliases as
7124         pseudo-registers.  Restore registration of
7125         rs6000_pseudo_register_reggroup_p with
7126         set_tdesc_pseudo_register_reggroup_p.
7127
7128 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7129
7130         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7131         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7132         set_gdbarch_num_pseudo_regs.
7133
7134 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7135
7136         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7137         Remove arg prefixname, add do_set and do_show.
7138         Add member functions set_list and show_list.
7139         * cli/cli-style.c (class cli_style_option): Update accordingly.
7140         (style_set_list): Move to file scope.
7141         (style_show_list): Likewise.
7142         (set_style): Call help_list.
7143         (show_style): Call cmd_show_list.
7144         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7145         Update to use the new macro.
7146
7147 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7148
7149         * ada-lang.c (_initialize_ada_language): Expand the help text
7150         for the "catch exception" command.
7151
7152 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7153
7154         * symtab.c (matching_obj_sections): Initialize obj,
7155         declare it closer to its usage.
7156
7157 2019-01-10  Tom Tromey  <tom@tromey.com>
7158
7159         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7160         (basic_inf_threads_range): Remove.
7161         (inf_threads_range, inf_non_exited_threads_range)
7162         (safe_inf_threads_range): Use next_adapter.
7163
7164 2019-01-10  Keith Seitz  <keiths@redhat.com>
7165
7166         PR gdb/23712
7167         PR symtab/23010
7168         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7169         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7170
7171 2019-01-10  Keith Seitz  <keiths@redhat.com>
7172
7173         PR gdb/23712
7174         PR symtab/23010
7175         * dictionary.c (pending_to_vector): Remove.
7176         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7177         Remove _1 suffix, replacing functions of the same name.  Update
7178         all callers.
7179         (dict_create_hashed, dict_create_hashed_expandable)
7180         (dict_create_linear, dict_create_linear_expandable, dict_free)
7181         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7182         Make functions static.
7183
7184 2019-01-10  Keith Seitz  <keiths@redhat.com>
7185
7186         PR gdb/23712
7187         PR symtab/23010
7188         * dictionary.h (struct dictionary): Replace declaration with
7189         multidictionary.
7190         (dict_create_hashed, dict_create_hashed_expandable)
7191         (dict_create_linear, dict_create_linear_expandable)
7192         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7193         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7194         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7195         taking multidictionary argument.
7196         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7197         * block.h (struct block) <dict>: Change to multidictionary
7198         and rename `multidict'.
7199         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7200         symmisc.c: Update all dictionary references to multidictionary.
7201
7202 2019-01-10  Keith Seitz  <keiths@redhat.com>
7203
7204         PR gdb/23712
7205         PR symtab/23010
7206         * dictionary.c: Include unordered_map.
7207         (pending_to_vector): New function.
7208         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7209         Rewrite the non-"_1" functions to take vector instead
7210         of linked list.
7211         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7212         "new" _1 versions of the same name.
7213         (multidictionary): Define.
7214         (std::hash<enum language): New definition.
7215         (collate_pending_symbols_by_language, mdict_create_hashed)
7216         (mdict_create_hashed_expandable, mdict_create_linear)
7217         (mdict_create_linear_expandable, mdict_free)
7218         (find_language_dictionary, create_new_language_dictionary)
7219         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7220         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7221         (mdict_size, mdict_empty): New functions.
7222         * dictionary.h (mdict_iterator): Define.
7223
7224 2019-01-10  Pedro Alves  <palves@redhat.com>
7225
7226         * breakpoint.c (read_uploaded_action)
7227         (create_tracepoint_from_upload): Adjust to use
7228         gdb::unique_xmalloc_ptr.
7229         * ctf.c (ctf_write_uploaded_tp):
7230         (SET_ARRAY_FIELD): Use emplace_back.
7231         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7232         * tracefile-tfile.c (tfile_write_uploaded_tp):
7233         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7234         gdb::unique_xmalloc_ptr.
7235         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7236         at_string, cond_string, cmd_strings>: Replace char pointers
7237         with gdb::unique_xmalloc_ptr.
7238
7239 2019-01-10  Pedro Alves  <palves@redhat.com>
7240
7241         * solib-target.c (library_list_start_library): Don't xstrdup name.
7242
7243 2019-01-10  Pedro Alves  <palves@redhat.com>
7244
7245         * mdebugread.c (parse_partial_symbols): Use
7246         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7247
7248 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7249
7250         * linux-fork.c (scoped_switch_fork_info)
7251         <~scoped_switch_fork_info>: Fix incorrect variable name.
7252
7253 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7254
7255         * linux-fork.c (scoped_switch_fork_info)
7256         <scoped_switch_fork_info>: Make explicit.
7257         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7258
7259 2019-01-10  Tom Tromey  <tom@tromey.com>
7260
7261         * objfiles.h (objfile::reset_psymtabs): Update.
7262         * objfiles.c (objfile::objfile): Update.
7263         * psymtab.h (psymtab_storage::obstack): Update.
7264         (psymtab_storage::m_obstack): Use gdb::optional.
7265         (class psymtab_storage): Update comment.  Remove objfile
7266         parameter.
7267         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7268
7269 2019-01-10  Tom Tromey  <tom@tromey.com>
7270
7271         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7272         <free_psymtabs>: Now private.
7273         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7274         (allocate_psymtab): Use new method.
7275
7276 2019-01-10  Tom Tromey  <tom@tromey.com>
7277
7278         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7279         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7280         * mdebugread.c (parse_partial_symbols): Use
7281         allocate_dependencies.
7282         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7283         allocate_dependencies.
7284         (process_psymtab_comp_unit_reader)
7285         (build_type_psymtab_dependencies): Likewise.
7286         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7287
7288 2019-01-10  Tom Tromey  <tom@tromey.com>
7289
7290         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7291         PSYMBOL_SET_LANGUAGE.
7292         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7293
7294 2019-01-10  Tom Tromey  <tom@tromey.com>
7295
7296         * psymtab.h (psymtab_storage::obstack): New method.
7297         <m_obstack>: Rename from obstack; now private.
7298         * psymtab.c (psymtab_storage): Update.
7299         * dwarf2read.c (create_addrmap_from_index)
7300         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7301         Update.
7302
7303 2019-01-10  Tom Tromey  <tom@tromey.com>
7304
7305         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7306         * objfiles.h (objfile::reset_psymtabs): New method.
7307
7308 2019-01-10  Tom Tromey  <tom@tromey.com>
7309
7310         * symmisc.c (print_symbol_bcache_statistics): Update.
7311         (print_objfile_statistics): Update.
7312         * symfile.c (reread_symbols): Update.
7313         * psymtab.h (class psymtab_storage): New.
7314         * psymtab.c (psymtab_storage): New constructor.
7315         (~psymtab_storage): New destructor.
7316         (require_partial_symbols): Update.
7317         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7318         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7319         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7320         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7321         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7322         (start_psymtab_common, end_psymtab_common)
7323         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7324         (allocate_psymtab): Update.
7325         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7326         Update.
7327         (dump_psymtab_addrmap, maintenance_print_psymbols)
7328         (maintenance_check_psymtabs): Update.
7329         (class objfile_psymtabs): Move to objfiles.h.
7330         * psympriv.h (discard_psymtab): Now inline.
7331         (psymtab_discarder::psymtab_discarder): Update.
7332         (psymtab_discarder::~psymtab_discarder): Update.
7333         (ALL_OBJFILE_PSYMTABS): Rewrite.
7334         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7335         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7336         Remove fields.
7337         <partial_symtabs>: New field.
7338         (class objfile_psymtabs): Move from psymtab.h.  Update.
7339         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7340         psymbol_cache.
7341         (objfile::~objfile): Don't destroy psymbol_cache.
7342         * mdebugread.c (parse_partial_symbols): Update.
7343         * dwarf2read.c (create_addrmap_from_index)
7344         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7345         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7346         (add_partial_subprogram, dwarf2_ranges_read): Update.
7347         * dwarf-index-write.c (write_address_map)
7348         (write_one_signatured_type, recursively_write_psymbols)
7349         (class debug_names, class debug_names, write_psymtabs_to_index):
7350         Update.
7351
7352 2019-01-10  Tom Tromey  <tom@tromey.com>
7353
7354         * symtab.h (SYMBOL_SET_NAMES): Update.
7355         (symbol_set_names): Update.
7356         (MSYMBOL_SET_NAMES): Update.
7357         * symtab.c (symbol_set_names): Change argument to be an
7358         objfile_per_bfd_storage.
7359         * psymtab.c (add_psymbol_to_bcache): Update.
7360         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7361
7362 2019-01-10  Tom Tromey  <tom@tromey.com>
7363
7364         * symtab.c (create_demangled_names_hash): Change argument to be an
7365         objfile_per_bfd_storage.
7366         (symbol_set_names): Update.
7367
7368 2019-01-10  Tom Tromey  <tom@tromey.com>
7369
7370         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7371         init_psymbol_list.
7372         * psymtab.c (init_psymbol_list): Do nothing if already called.
7373         * psympriv.h (init_psymbol_list): Add comment.
7374         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7375         init_psymbol_list.
7376         * dbxread.c (dbx_symfile_read): Unconditionally call
7377         init_psymbol_list.
7378
7379 2019-01-10  Tom Tromey  <tom@tromey.com>
7380
7381         * xcoffread.c (scan_xcoff_symtab): Update.
7382         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7383         "where".
7384         * mdebugread.c (parse_partial_symbols)
7385         (handle_psymbol_enumerators): Update.
7386         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7387         * dbxread.c (read_dbx_symtab): Update.
7388         * psympriv.h (psymbol_placement): New enum.
7389         (add_psymbol_to_list): Update.
7390
7391 2019-01-10  Tom Tromey  <tom@tromey.com>
7392
7393         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7394         static_psymbols parameters.
7395         (scan_xcoff_symtab): Update.
7396         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7397         static_psymbols parameters.
7398         * psympriv.h (start_psymtab_common): Update.
7399         * mdebugread.c (parse_partial_symbols): Update.
7400         * dwarf2read.c (create_partial_symtab): Update.
7401         * dbxread.c (read_dbx_symtab): Update.
7402         (start_psymtab): Remove global_psymbols and static_psymbols
7403         parameters.
7404
7405 2019-01-10  Tom Tromey  <tom@tromey.com>
7406
7407         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7408         * psymtab.c (allocate_psymtab): Add comment.
7409         * psympriv.h (allocate_psymtab): Add comment.
7410         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7411         initializations.
7412         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7413
7414 2019-01-10  Tom Tromey  <tom@tromey.com>
7415
7416         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7417         Don't declare.
7418         * mipsread.c: Include mdebugread.h.
7419         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7420         Declare.
7421         * elfread.c: Include mdebugread.h.
7422
7423 2019-01-09  Tom Tromey  <tom@tromey.com>
7424
7425         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7426         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7427         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7428         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7429         (psym_lookup_symbol, psym_find_last_source_symtab)
7430         (psym_forget_cached_source_info, psym_print_stats)
7431         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7432         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7433         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7434         (psym_find_compunit_symtab_by_address)
7435         (maintenance_print_psymbols, maintenance_info_psymtabs)
7436         (maintenance_check_psymtabs): Use ranged for.
7437         * psymtab.h (class objfile_psymtabs): New.
7438         (require_partial_symbols): Return objfile_psymtabs.
7439         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7440
7441 2019-01-09  Tom Tromey  <tom@tromey.com>
7442
7443         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7444         (find_pc_mapped_section, list_overlays_command)
7445         (map_overlay_command, unmap_overlay_command)
7446         (simple_overlay_update): Use all_objfiles.
7447         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7448         * printcmd.c (info_symbol_command): Use all_objfiles.
7449         * objfiles.h (ALL_OBJSECTIONS): Remove.
7450         * maint.c (maintenance_translate_address): Use all_objfiles.
7451         * gcore.c (gcore_create_callback): Use all_objfiles.
7452         (objfile_find_memory_regions): Likewise.
7453
7454 2019-01-09  Tom Tromey  <tom@tromey.com>
7455
7456         * symtab.c (find_line_symtab, info_sources_command)
7457         (make_source_files_completion_list): Use objfile_compunits.
7458         * source.c (select_source_symtab): Use objfile_compunits.
7459         * objfiles.h (struct objfile): Update comment.
7460         (ALL_OBJFILES): Remove.
7461         (ALL_FILETABS): Remove.
7462         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7463         objfile_compunits.
7464
7465 2019-01-09  Tom Tromey  <tom@tromey.com>
7466
7467         * symmisc.c (print_objfile_statistics, dump_objfile)
7468         (maintenance_print_symbols): Use compunit_filetabs.
7469         * source.c (forget_cached_source_info_for_objfile): Use
7470         compunit_filetabs.
7471         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7472         (ALL_FILETABS): Use compunit_filetabs.
7473         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7474         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7475
7476 2019-01-09  Tom Tromey  <tom@tromey.com>
7477
7478         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7479         (compunit_filetabs): New.
7480         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7481         compunit_filetabs.
7482         (info_sources_command, make_source_files_completion_list): Remove
7483         declaration.
7484         * symmisc.c (print_objfile_statistics, dump_objfile)
7485         (maintenance_print_symbols): Remove declaration.
7486         (maintenance_info_symtabs): Use compunit_filetabs.
7487         (maintenance_info_line_tables): Likewise.
7488         * source.c (select_source_symtab): Change local variable name.
7489         (forget_cached_source_info_for_objfile): Remove declaration.
7490         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7491         * objfiles.c (objfile_relocate1): Remove declaration.
7492         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7493         declaration.
7494         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7495         * coffread.c (coff_symtab_read): Remove declaration.
7496         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7497         compunit_filetabs.
7498
7499 2019-01-09  Tom Tromey  <tom@tromey.com>
7500
7501         * symtab.c (lookup_objfile_from_block)
7502         (find_pc_sect_compunit_symtab, search_symbols)
7503         (default_collect_symbol_completion_matches_break_on): Use
7504         objfile_compunits.
7505         * objfiles.h (ALL_COMPUNITS): Remove.
7506         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7507         * cp-support.c (add_symbol_overload_list_qualified): Use
7508         objfile_compunits.
7509         * ada-lang.c (ada_collect_symbol_completion_matches)
7510         (ada_add_global_exceptions): Use objfile_compunits.
7511
7512 2019-01-09  Tom Tromey  <tom@tromey.com>
7513
7514         * source.c (select_source_symtab)
7515         (forget_cached_source_info_for_objfile): Remove declaration.
7516         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7517         declaration.
7518         * maint.c (count_symtabs_and_blocks): Remove declaration.
7519         * cp-support.c (add_symbol_overload_list_qualified): Remove
7520         declaration.
7521         * coffread.c (coff_symtab_read): Remove declaration.
7522         * symtab.c (lookup_symbol_in_objfile_symtabs)
7523         (basic_lookup_transparent_type_1): Use objfile_compunits.
7524         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7525         (info_sources_command, search_symbols)
7526         (default_collect_symbol_completion_matches_break_on)
7527         (make_source_files_completion_list): Remove declaration.
7528         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7529         (ada_collect_symbol_completion_matches)
7530         (ada_add_global_exceptions): Remove declaration.
7531         * linespec.c (iterate_over_all_matching_symtabs): Use
7532         objfile_compunits.
7533         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7534         (class objfile_compunits): New.
7535         (ALL_COMPUNITS): Use objfile_compunits.
7536         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7537         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7538         objfile_compunits.
7539         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7540
7541 2019-01-09  Tom Tromey  <tom@tromey.com>
7542
7543         * symtab.c (search_symbols)
7544         (default_collect_symbol_completion_matches_break_on): Use
7545         objfile_msymbols.
7546         * ada-lang.c (ada_lookup_simple_minsym)
7547         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7548         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7549         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7550         objfile_msymbols.
7551         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7552         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7553         * objc-lang.c (find_methods): Use objfile_msymbols.
7554         (info_selectors_command, info_classes_command): Likewise.
7555         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7556         * objfiles.h (class objfile_msymbols): New.
7557         (ALL_OBJFILE_MSYMBOLS): Remove.
7558         (ALL_MSYMBOLS): Remove.
7559
7560 2019-01-09  Tom Tromey  <tom@tromey.com>
7561
7562         * common/next-iterator.h (next_adapter): Add Iterator template
7563         parameter.
7564         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7565         (class all_objfiles_safe): New.
7566         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7567         * objfiles.c (put_objfile_before): Update comment.
7568         (add_separate_debug_objfile): Likewise.
7569         (free_all_objfiles): Use all_objfiles_safe.
7570         (objfile_purge_solibs): Likewise.
7571
7572 2019-01-09  Tom Tromey  <tom@tromey.com>
7573
7574         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7575         (expand_symtab_containing_pc, lookup_static_symbol)
7576         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7577         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7578         all_objfiles.
7579         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7580         * breakpoint.c (create_overlay_event_breakpoint)
7581         (create_longjmp_master_breakpoint)
7582         (create_std_terminate_master_breakpoint)
7583         (create_exception_master_breakpoint): Use all_objfiles.
7584         * linux-thread-db.c (try_thread_db_load_from_pdir)
7585         (has_libpthread): Use all_objfiles.
7586         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7587         * linespec.c (iterate_over_all_matching_symtabs)
7588         (search_minsyms_for_name): Use all_objfiles.
7589         * maint.c (maintenance_info_sections): Use all_objfiles.
7590         * main.c (captured_main_1): Use all_objfiles.
7591         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7592         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7593         * guile/scm-pretty-print.c
7594         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7595         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7596         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7597         (maintenance_print_msymbols): Use all_objfiles.
7598         * source.c (select_source_symtab): Use all_objfiles.
7599         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7600         * symfile.c (remove_symbol_file_command)
7601         (expand_symtabs_matching, map_symbol_filenames): Use
7602         all_objfiles.
7603         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7604         all_objfiles.
7605         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7606         * objc-lang.c (find_methods): Use all_objfiles.
7607         * objfiles.c (have_partial_symbols, have_full_symbols)
7608         (have_minimal_symbols, qsort_cmp)
7609         (default_iterate_over_objfiles_in_search_order): Use
7610         all_objfiles.
7611         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7612         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7613         (maintenance_check_psymtabs): Use all_objfiles.
7614         (ALL_PSYMTABS): Remove.
7615         * compile/compile-object-run.c (do_module_cleanup): Use
7616         all_objfiles.
7617         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7618         * cp-support.c (add_symbol_overload_list_qualified): Use
7619         all_objfiles.
7620         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7621         Use all_objfiles.
7622         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7623         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7624         all_objfiles.
7625         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7626         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7627         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7628         Uses all_objfiles.
7629         * solib.c (solib_read_symbols): Use all_objfiles
7630
7631 2019-01-09  Tom Tromey  <tom@tromey.com>
7632
7633         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7634         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7635         all_objfiles.
7636         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7637         * symmisc.c (print_symbol_bcache_statistics)
7638         (print_objfile_statistics, maintenance_print_objfiles)
7639         (maintenance_info_symtabs, maintenance_check_symtabs)
7640         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7641         all_objfiles.
7642         * source.c (forget_cached_source_info): Use all_objfiles.
7643         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7644         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7645         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7646         * objfiles.c (update_section_map): Use all_objfiles.
7647         (shared_objfile_contains_address_p): Likewise.
7648         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7649         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7650
7651 2019-01-09  Tom Tromey  <tom@tromey.com>
7652
7653         * common/next-iterator.h: New file.
7654         * objfiles.h (class all_objfiles): New.
7655         (struct objfile_iterator): New.
7656
7657 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7658
7659         * NEWS: Move the description of the changed "frame", "select-frame",
7660          and "info frame" commands to the Changed commands section.
7661
7662 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7663
7664         * gdbtypes.c (check_stub_method_group): Remove handling of old
7665         mangling schemes.
7666         * linespec.c (find_methods): Likewise.
7667         * stabsread.c (read_member_functions): Likewise.
7668         * valops.c (search_struct_method): Likewise.
7669         (value_struct_elt_for_reference): Likewise.
7670         * NEWS: Mention this change.
7671
7672 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7673
7674         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7675         print_source_lines.
7676         * source.c (print_source_lines_base): Update line number check.
7677         (print_source_lines): New function.
7678         (source_lines_range::source_lines_range): New function.
7679         * source.h (class source_lines_range): New class.
7680         (print_source_lines): New declaration.
7681
7682 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7683
7684         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7685
7686 2019-01-08  Tom Tromey  <tom@tromey.com>
7687             Simon Marchi  <simon.marchi@ericsson.com>
7688
7689         PR gdb/24060
7690         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7691         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7692         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7693         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7694         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7695         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7696
7697 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * source.c (select_source_symtab): Move header comment to
7700         declaration in source.h.
7701         (forget_cached_source_info_for_objfile): Likewise.
7702         (forget_cached_source_info): Likewise.
7703         (identify_source_line): Likewise.
7704         * source.h (identify_source_line): Move declaration from symtab.h
7705         and add comment from source.c
7706         (print_source_lines): Likewise.
7707         (forget_cached_source_info_for_objfile): Likewise.
7708         (forget_cached_source_info): Likewise.
7709         (select_source_symtab): Likewise.
7710         (enum print_source_lines_flag): Move definition from symtab.h.
7711         * symtab.h (identify_source_line): Move declaration to source.h.
7712         (print_source_lines): Likewise.
7713         (forget_cached_source_info_for_objfile): Likewise.
7714         (forget_cached_source_info): Likewise.
7715         (select_source_symtab): Likewise.
7716         (enum print_source_lines_flag): Move definition to source.h.
7717         * tui/tui-hooks.c: Add 'source.h' include.
7718
7719 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7720
7721         * source.c (print_source_lines_base): Handle requests to print
7722         reverse line number sequences, and guard against empty lines
7723         string.
7724
7725 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7726
7727         * source.c (print_source_lines_base): Fix skip of '\r' if next
7728         character is '\n'.
7729
7730 2019-01-06  Tom Tromey  <tom@tromey.com>
7731
7732         * c-exp.y (struct c_parse_state) <macro_original_text,
7733         expansion_obstack>: New member.
7734         (macro_original_text, expansion_obstack): Remove globals.
7735         (scan_macro_expansion, scanning_macro_expansion)
7736         (finished_macro_expansion): Update.
7737         (scan_macro_cleanup): Remove.
7738         (yylex, c_parse): Update.
7739
7740 2019-01-06  Tom Tromey  <tom@tromey.com>
7741
7742         * c-exp.y (struct c_parse_state) <strings>: New member.
7743         (operator_stoken): Update.
7744
7745 2019-01-06  Tom Tromey  <tom@tromey.com>
7746
7747         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7748         (union type_stack_elt) <typelist_val>: Now a pointer to
7749         std::vector.
7750         (type_stack_cleanup): Don't declare.
7751         (push_typelist): Update.
7752         * parse.c (pop_typelist): Return a std::vector.
7753         (push_typelist): Take a std::vector.
7754         (follow_types): Update.  Do not free args.
7755         (type_stack_cleanup): Remove.
7756         * c-exp.y (struct c_parse_state): New.
7757         (cpstate): New global.
7758         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7759         (nonempty_typelist): Update.
7760         (func_mod): Create a new vector.
7761         (c_parse): Create a c_parse_state.
7762         (check_parameter_typelist): Do not delete params.
7763         (function_method): Update.  Do not delete type_list.
7764
7765 2019-01-06  Tom Tromey  <tom@tromey.com>
7766
7767         PR gdb/28155:
7768         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7769         check_typedef.
7770         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7771         (print_return_value): Likewise.
7772
7773 2019-01-05  Tom Tromey  <tom@tromey.com>
7774
7775         * contrib/cleanup_check.py: Remove.
7776         * contrib/gcc-with-excheck: Remove.
7777         * contrib/exsummary.py: Remove.
7778         * contrib/excheck.py: Remove.
7779
7780 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7781
7782         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7783         NULL. Initialize tpprev to NULL instead of assigning it
7784         to NULL on the next statement.
7785         * windows-nat.c (windows_delete_thread): Remove check for
7786         main_thread_id before printing thread exit notifications.
7787         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7788         Remove thread ID check against main_thread_id.
7789         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7790         windows_delete_thread.
7791         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7792
7793 2019-01-04  Tom Tromey  <tom@tromey.com>
7794
7795         * compile/compile.c (_initialize_compile): Use upper case for
7796         metasyntactic variables.
7797         * symmisc.c (_initialize_symmisc): Use upper case for
7798         metasyntactic variables.
7799         * psymtab.c (_initialize_psymtab): Use upper case for
7800         metasyntactic variables.
7801         * demangle.c (demangle_command): Use upper case for metasyntactic
7802         variables.
7803         (_initialize_demangler): Likewise.
7804         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7805         variables.
7806
7807 2019-01-03  Tom Tromey  <tom@tromey.com>
7808
7809         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7810
7811 2019-01-03  Tom Tromey  <tom@tromey.com>
7812
7813         * python/py-symtab.c (salpy_str): Update.
7814         (struct salpy_sal_object) <symtab>: Now a PyObject.
7815         (salpy_dealloc): Update.
7816         (del_objfile_sal): Use gdbpy_ref.
7817
7818 2019-01-03  Tom Tromey  <tom@tromey.com>
7819
7820         * python/py-type.c (convert_field): Use new_reference.  Return
7821         gdbpy_ref.
7822         (make_fielditem): Return gdbpy_ref.
7823         (typy_fields): Update.
7824         (typy_getitem): Update.
7825         (field_name): Return gdbpy_ref.  Use new_reference.
7826         (typy_iterator_iternext): Update.
7827
7828 2019-01-03  Tom Tromey  <tom@tromey.com>
7829
7830         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7831
7832 2019-01-03  Tom Tromey  <tom@tromey.com>
7833
7834         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7835         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7836         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7837         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7838         (pspy_set_type_printers): Likewise.
7839         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7840         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7841         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7842         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7843         (objfpy_set_type_printers): Likewise.
7844
7845 2019-01-03  Tom Tromey  <tom@tromey.com>
7846
7847         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7848         (gdbpy_print_stack): Use gdbpy_err_fetch.
7849         * python/python-internal.h (class gdbpy_err_fetch): New class.
7850         (class gdbpy_enter) <m_error_type, m_error_value,
7851         m_error_traceback>: Remove.
7852         <m_error>: New member.
7853         (gdbpy_exception_to_string): Don't declare.
7854         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7855         * python/py-value.c (convert_value_from_python): Use
7856         gdbpy_err_fetch.
7857         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7858         gdbpy_exception_to_string.
7859         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7860         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7861         gdbpy_err_fetch.
7862
7863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7864
7865         * linux-nat.c (delete_lwp_cleanup): Delete.
7866         (struct lwp_deleter): New struct.
7867         (lwp_info_up): New typedef.
7868         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7869         lwp_info_up.
7870
7871 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7872
7873         * linux-fork.c (class scoped_switch_fork_info): New class.
7874         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7875
7876 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7877
7878         * valops.c (find_overload_match): Remove use of null_cleanup, and
7879         calls to do_cleanups.
7880
7881 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7882
7883         * compile/compile-cplus-types.c
7884         (compile_cplus_instance::decl_name): Handle changes to
7885         cp_func_name.
7886         * cp-support.c (cp_func_name): Update header comment, update
7887         return type.
7888         * cp-support.h (cp_func_name): Update return type in declaration.
7889         * valops.c (find_overload_match): Move temp_func local to top
7890         level of function and change its type.  Use temp_func to hold and
7891         delete temporary string obtained from cp_func_name.
7892
7893 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7894
7895         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7896         gdb::char_vector, remove cleanup, and update uses of `msg`.
7897
7898 2019-01-03  Jim Wilson  <jimw@sifive.com>
7899
7900         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7901
7902 2019-01-02  Tom Tromey  <tom@tromey.com>
7903
7904         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7905         (tdesc_parse_xml): Remove cleanups.
7906         * target-descriptions.h (make_cleanup_free_target_description):
7907         Don't declare.
7908         (target_desc_deleter): New struct.
7909         (target_desc_up): New typedef.
7910         * target-descriptions.c (target_desc_deleter::operator()): Rename
7911         from free_target_description.
7912         (make_cleanup_free_target_description): Remove.
7913
7914 2019-01-02  Tom Tromey  <tom@tromey.com>
7915
7916         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7917         constructor, destructor.
7918         (linespec_parser): Remove typedef.
7919         (~linespec_parser): Rename from linespec_parser_delete.
7920         (linespec_lex_to_end, linespec_complete_label)
7921         (linespec_complete): Update.
7922         (decode_line_full): Remove cleanups.
7923         (decode_line_1): Update.
7924
7925 2019-01-02  Tom Tromey  <tom@tromey.com>
7926
7927         * python/python-internal.h (inferior_to_inferior_object): Change
7928         return type.
7929         * python/py-exitedevent.c (create_exited_event_object): Update.
7930         * python/py-inferior.c (inferior_to_inferior_object): Return
7931         gdbpy_ref.
7932         (python_new_inferior, python_inferior_deleted)
7933         (thread_to_thread_object, delete_thread_object)
7934         (build_inferior_list, gdbpy_selected_inferior): Update.
7935         * python/py-infthread.c (create_thread_object): Update.  Also fail
7936         if inferior_to_inferior_object fails.
7937
7938 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7939
7940         * inferior.h (class inferior) <displaced_step_state>: New field.
7941         * infrun.h (struct displaced_step_state): Move here from
7942         infrun.c.  Initialize fields, add constructor.
7943         <inf>: Remove field.
7944         <reset>: New method.
7945         * infrun.c (struct displaced_step_inferior_state): Move to
7946         infrun.h.
7947         (displaced_step_inferior_states): Remove.
7948         (get_displaced_stepping_state): Adust.
7949         (displaced_step_in_progress_any_inferior): Adjust.
7950         (displaced_step_in_progress_thread): Adjust.
7951         (displaced_step_in_progress): Adjust.
7952         (add_displaced_stepping_state): Remove.
7953         (get_displaced_step_closure_by_addr): Adjust.
7954         (remove_displaced_stepping_state): Remove.
7955         (infrun_inferior_exit): Call displaced_step_state.reset.
7956         (use_displaced_stepping): Don't check for NULL.
7957         (displaced_step_prepare_throw): Call
7958         get_displaced_stepping_state.
7959         (displaced_step_fixup): Don't check for NULL.
7960         (prepare_for_detach): Don't check for NULL.
7961
7962 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7963
7964         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7965          in case of call that did not complete.
7966
7967 2019-01-02  Andrey Utkin  <autkin@undo.io>
7968
7969         * symfile.c (find_separate_debug_file): Fix search of debug files for
7970         remote debuggee.
7971
7972 2019-01-02  Tom Tromey  <tom@tromey.com>
7973
7974         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7975         indentation.
7976         * python/py-frame.c (frapy_older): Remove cast.
7977         (frapy_newer): Likewise.
7978         * python/py-breakpoint.c (local_setattro): Remove cast.
7979         * python/py-arch.c (archpy_name): Remove local variable.
7980         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7981
7982 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7983
7984         * unittests/basic_string_view/element_access/char/empty.cc:
7985         Fix year range in copyright header.
7986
7987 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7988
7989         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7990         Delete.
7991         <operator==>: Update with for removed field.
7992         <hash>: Likewise.
7993         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7994         <isa_features>: ...this.
7995         <abi_features>: New field.
7996         (riscv_isa_flen): Update comment.
7997         (riscv_abi_xlen): New declaration.
7998         (riscv_abi_flen): New declaration.
7999         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8000         isa_features.
8001         (riscv_abi_xlen): New function.
8002         (riscv_isa_flen): Update to get answer from isa_features.
8003         (riscv_abi_flen): New function.
8004         (riscv_has_fp_abi): Update to get answer from abi_features.
8005         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8006         xlen and flen.
8007         (riscv_call_info) <xlen, flen>: Update comment.
8008         (riscv_call_arg_struct): Remove invalid assertions
8009         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8010         is removed.
8011         (riscv_gdbarch_init): Gather isa features and abi features
8012         separately, ensure both match on the gdbarch when reusing an old
8013         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8014         a target with 64-bit float hardware.
8015
8016 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8017
8018         * source.c (search_command_helper): Stop reverse search
8019         when line 1 has been searched.
8020
8021 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8022
8023         * record-full.c (record_full_base_target::close): Rewrite
8024         record_full_core_buf_list free logic.
8025
8026 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8027
8028         * break-catch-syscall.c (print_one_catch_syscall): xfree
8029         the last text.
8030
8031 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8032
8033         * top.c (print_gdb_version): Update Copyright year in version
8034         message.
8035
8036 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8037
8038         Update copyright year range in all GDB files.
8039
8040 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8041
8042         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8043
8044 For older changes see ChangeLog-2018.
8045 \f
8046 Local Variables:
8047 mode: change-log
8048 left-margin: 8
8049 fill-column: 74
8050 version-control: never
8051 coding: utf-8
8052 End:
8053