gdb/ChangeLog

   1 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * python/python.c (do_start_initialization): Make progname_copy static,
   4         to avoid a leak report.
   5
   6 2019-09-08  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
   9
  10 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
  11
  12         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
  13         Change type to gdb::optional<block_enum>.
  14         (dw2_symtab_iter_init): Change block_index parameter type
  15         to gdb::optional<block_enum>.
  16         (dw2_lookup_symbol): Change block_index parameter
  17         type to block_enum.c
  18         (dw2_debug_names_lookup_symbol): Likewise.
  19         * psymtab.c (psym_lookup_symbol): Likewise.
  20         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
  21         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
  22         Likewise.
  23
  24 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
  25
  26         * defs.h (relocate_gdb_directory): Change int to bool in
  27         signature and rename flag to relocatable.
  28         * main.c (relocate_path): Likewise.
  29         (relocate_gdb_directory): Likewise.
  30
  31 2019-09-06  Alan Modra  <amodra@gmail.com>
  32
  33         * coffread.c (coff_symfile_read): Constify filename variable.
  34         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
  35         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
  36         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
  37         * solib.c (reload_shared_libraries_1): Likewise.
  38         * symfile.c (reread_symbols): Likewise.
  39         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
  40         * solib-darwin.c (darwin_bfd_open): Likewise.
  41         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
  42
  43 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  44
  45         * psymtab.c (print_partial_symbols): Handle missing domain_enum
  46         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
  47
  48 2019-09-03  Tom Tromey  <tromey@adacore.com>
  49
  50         * ada-valprint.c (ada_val_print_num): Don't recurse for range
  51         types.
  52         (has_negatives): Unbias a range type bound.
  53         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
  54         * gdbtypes.c (operator==): Handle new field.
  55         (create_range_type): Add "bias" parameter.
  56         (create_static_range_type, resolve_dynamic_range): Update.
  57         * gdbtypes.h (struct range_bounds) <bias>: New member.
  58         (create_range_type): Add bias parameter.
  59         * printcmd.c (print_scalar_formatted): Unbias range types.
  60         * value.c (unpack_long): Unbias range types.
  61         (pack_long): Bias range types.
  62
  63 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  64
  65         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
  66         probe arguments.
  67
  68 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  69
  70         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
  71         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
  72         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
  73         (compile_probe_arg): Likewise.
  74         * probe.h (get_argument_count): Likewise.
  75         * solib-svr4.c (solib_event_probe_action): Likewise.
  76         * stap-probe.c (stap_probe::get_argument_count): Likewise.
  77
  78 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
  79
  80         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
  81         code to here...
  82         (svr4_create_solib_event_breakpoints): ...from here.
  83
  84 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
  85
  86         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
  87         suffix from warning message.
  88
  89 2019-08-30  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-winsource.h (struct tui_source_window_base)
  92         <refresh_all>: Don't declare.
  93         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
  94         Remove.
  95         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
  96         tui_show_locator_content.
  97         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
  98         declare.
  99         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 100         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 101         declare.
 102
 103 2019-08-30  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 106
 107 2019-08-30  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 110         Remove unnecessary forward declarations.
 111
 112 2019-08-30  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 115         rerender.
 116         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 117         tui_show_locator_content.
 118
 119 2019-08-30  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 122         (tui_locator_window::rerender): Rewrite using body of previous
 123         tui_show_locator_content.
 124
 125 2019-08-30  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 128         set_locator_fullname>: New methods.
 129         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 130         Rename from tui_set_locator_fullname.
 131         (tui_locator_window::set_locator_info): Rename from
 132         tui_set_locator_info.  Return bool.
 133         (tui_update_locator_fullname, tui_show_frame_info): Update.
 134
 135 2019-08-30  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 138
 139 2019-08-30  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 142         call touchwin.
 143
 144 2019-08-30  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-wingeneral.c (box_win): Assume win_info and
 147         win_info->handle cannot be NULL.
 148
 149 2019-08-30  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 152         refresh_window>: Declare.
 153         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 154         resize.
 155         (tui_data_item_window::rerender): Rename from
 156         tui_display_register.
 157         (tui_data_item_window::refresh_window): New method.
 158         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 159         no-op.
 160
 161 2019-08-30  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 164         regs_column_count, current_group>: Move later.  Now private.
 165         <get_current_group>: New method.
 166         * tui/tui-regs.c (tui_reg_command): Update.
 167         * tui/tui-layout.c (tui_set_layout): Update.
 168
 169 2019-08-30  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 172         (tui_data_window::rerender): Don't call
 173         check_and_display_highlight_if_needed.
 174         (tui_data_window::refresh_all): Remove call to
 175         erase_data_content.
 176
 177 2019-08-30  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 180         (tui_data_window::display_registers_from)
 181         (tui_data_window::display_reg_element_at_line)
 182         (tui_data_window::display_registers_from_line): Remove checks of
 183         "empty".
 184
 185 2019-08-30  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 188         Don't declare.
 189         * tui/tui-regs.c (tui_data_window::show_registers): Call
 190         rerender.
 191         (tui_data_window::rerender): Rename from display_all_data.
 192         (tui_data_window::rerender): Remove old implementation.
 193
 194 2019-08-30  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 197         text.
 198         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 199
 200 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 201             Sergio Durigan Junior  <sergiodj@redhat.com>
 202
 203         PR win32/24284
 204         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 205
 206 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 209         when searching for types.
 210
 211 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 212
 213         * f-lang.c (f_language_defn): Use f_print_typedef.
 214         * f-lang.h (f_print_typedef): Declare.
 215         * f-typeprint.c (f_print_typedef): Define.
 216
 217 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 218
 219         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 220
 221 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 222
 223         * cli/cli-utils.c (info_print_options_defs): Delete.
 224         (make_info_print_options_def_group): Delete.
 225         (extract_info_print_options): Delete.
 226         (info_print_command_completer): Delete.
 227         (info_print_args_help): Add extra parameter, and optionally
 228         include text about -n flag.
 229         * cli/cli-utils.h (struct info_print_options): Delete.
 230         (extract_info_print_options): Delete declaration.
 231         (info_print_command_completer): Delete declaration.
 232         (info_print_args_help): Add extra parameter, extend header
 233         comment.
 234         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 235         search_symbols.
 236         * stack.c (struct info_print_options): New type.
 237         (info_print_options_defs): New file scoped variable.
 238         (make_info_print_options_def_group): New static function.
 239         (info_print_command_completer): New static function.
 240         (info_locals_command): Update to use new local functions.
 241         (info_args_command): Likewise.
 242         (_initialize_stack): Add extra parameter to calls to
 243         info_print_args_help.
 244         * symtab.c (search_symbols): Add extra parameter, use this to
 245         possibly excluse non-debug symbols.
 246         (symtab_symbol_info): Add extra parameter, which is passed on to
 247         search_symbols.
 248         (struct info_print_options): New type.
 249         (info_print_options_defs): New file scoped variable.
 250         (make_info_print_options_def_group): New static function.
 251         (info_print_command_completer): New static function.
 252         (info_variables_command): Update to use local functions, and pass
 253         extra parameter through to symtab_symbol_info.
 254         (info_functions_command): Likewise.
 255         (info_types_command): Pass additional argument through to
 256         symtab_symbol_info.
 257         (rbreak_command): Pass extra argument to search_symbols.
 258         (_initialize_symtab): Add extra arguments for calls to
 259         info_print_args_help, and update help text for 'info variables',
 260         'whereis', and 'info functions' commands.
 261         * symtab.h (search_symbols): Add extra argument to declaration.
 262         * NEWS: Mention new flags.
 263
 264 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 265
 266         * symtab.c (lookup_static_symbol): Call the new function (and move
 267         it down to be next to lookup_global_symbol).
 268         (struct global_sym_lookup_data): Add block_enum member and rename to...
 269         (struct global_or_static_sym_lookup_data): ...this.
 270         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 271         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 272         (lookup_symbol_global_or_static_iterator_cb): ...this.
 273         (lookup_global_or_static_symbol): New function.
 274         (lookup_global_symbol): Call new function.
 275
 276 2019-08-26  Tom de Vries  <tdevries@suse.de>
 277
 278         PR c++/24852
 279         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 280         when pc_probe.prob == NULL.
 281
 282 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 283
 284         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 285         variable symbol_linkage to symbol_linkage_.
 286
 287 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 288
 289         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 290         represent whether the symbol is static, dynamic, or we don't
 291         know.
 292
 293 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 294
 295         * gdb/rx-tdep.c (rx_register_names): New.
 296         (rx_register_name): Delete.
 297         (rx_psw_type): Delete.
 298         (rx_fpsw_type): Delete.
 299         (rx_register_type): Delete.
 300         (rx_gdbarch_init): Convert target-descriptions.
 301         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 302         * gdb/features/Makefile: Add rx.xml.
 303         * gdb/features/rx.xml: New.
 304         * gdb/features/rx.c: Generated.
 305         * gdb/NEWS: Mention target description support.
 306
 307 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 308
 309         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 310         *slot_ptr.
 311
 312 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 313
 314         * configure.ac: Don't check for 'dlfcn.h' (moved to
 315         gdbsupport/common.m4).
 316         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 317         'gdbsupport/'.
 318         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 319         * compile/compile-c-support.c: Include
 320         'gdbsupport/gdb-dlfcn.h'.
 321         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 322         * gdb-dlfcn.c: Move to...
 323         * gdbsupport/gdb-dlfcn.c: ... here.
 324         * gdb-dlfcn.h: Move to...
 325         * gdbsupport/gdb-dlfcn.h: ... here.
 326
 327 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 328
 329         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 330         the offset field signed.
 331
 332 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 333
 334         * python/lib/gdb/__init__.py (_execute_file): New function.
 335         * python/python.c (python_run_simple_file): Call gdb._execute_file
 336         on Windows.
 337
 338 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 339
 340         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 341         all uses as this was never set to anything but a zero value.
 342
 343 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 344
 345         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 346
 347 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 348
 349         * tui/tui-data.h (tui_gen_win_info): Add an =default
 350         move constructor, required by some GCC versions.
 351
 352 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 353
 354         * go32-nat.c (go32_sysinfo): Add hygon_p.
 355
 356 2019-08-20  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 359         line_from_reg_element_no, first_reg_element_no_inline,
 360         display_all_data, delete_data_content_windows,
 361         erase_data_content>: Now private.
 362
 363 2019-08-20  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 366         (tui_unhighlight_win, tui_highlight_win)
 367         (tui_win_info::make_window): Update.
 368         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 369
 370 2019-08-20  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 373         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 374         (MAX_PID_WIDTH): Move to tui-stack.c.
 375         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 376         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 377         (MAX_PID_WIDTH): Move from tui-data.h.
 378
 379 2019-08-20  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 382         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 383         (box_win): Update.
 384         (tui_gen_win_info::make_window): Rename from tui_make_window.
 385         (tui_win_info::make_window): New method.
 386         (tui_gen_win_info::make_visible): Update.
 387         * tui/tui-source.c (tui_source_window::set_contents): Update.
 388         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 389         (tui_data_window::display_registers_from): Update.
 390         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 391         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 392         Declare.
 393         <can_box>: Remove.
 394         <title>: Remove.
 395         (struct tui_win_info) <make_window>: Declare.
 396         <can_box>: Now virtual.
 397         <title>: New member.
 398         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 399         * tui/tui-command.c (tui_cmd_window::resize): Update.
 400
 401 2019-08-20  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 404         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 405         (tui_data_window::check_register_values): Update.
 406
 407 2019-08-20  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-regs.h (struct tui_data_window): Use
 410         DISABLE_COPY_AND_ASSIGN.
 411         <regs_content>: Change type, removing unique_ptr.
 412         <tui_data_window>: Add move constructor.
 413         * tui/tui-regs.c (tui_data_window::show_registers)
 414         (tui_data_window::show_register_group)
 415         (tui_data_window::display_registers_from)
 416         (tui_data_window::display_registers_from)
 417         (tui_data_window::first_data_item_displayed)
 418         (tui_data_window::delete_data_content_windows)
 419         (tui_data_window::rerender, tui_data_window::refresh_window)
 420         (tui_data_window::check_register_values): Update.
 421
 422 2019-08-20  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 425         show_register_group>: Declare.
 426         (tui_show_register_group): Don't declare.
 427         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 428         tui_show_registers.
 429         (tui_data_window::show_register_group): Rename from
 430         tui_show_register_group.
 431         (tui_data_window::check_register_values, tui_reg_command):
 432         Update.
 433         * tui/tui-layout.c (tui_set_layout): Update.
 434
 435 2019-08-20  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 438         Declare.
 439         (tui_check_register_values): Don't declare.
 440         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 441         from tui_check_register_values.
 442         * tui/tui-hooks.c (tui_register_changed): Update.
 443
 444 2019-08-20  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-regs.c (tui_reg_layout): Move later.
 447         (tui_show_registers): Don't enable TUI mode or change layout.
 448
 449 2019-08-20  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-regs.h (struct tui_data_item_window)
 452         <~tui_data_item_window>: Remove.
 453         <content>: Now a unique_xmalloc_ptr.
 454         * tui/tui-regs.c (tui_register_format): Return a
 455         unique_xmalloc_ptr.
 456         (tui_get_register): Update.
 457         (~tui_data_item_window): Remove.
 458         (tui_data_window::display_registers_from, tui_display_register):
 459         Update.
 460         * tui/tui-io.h (tui_expand_tabs): Update.
 461         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 462         Remove "col" parameter.
 463
 464 2019-08-20  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 467         field.
 468         * tui/tui-regs.c (~tui_data_item_window): Update.
 469
 470 2019-08-20  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 473         earlier.
 474
 475 2019-08-20  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 478
 479 2019-08-20  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-source.h (struct tui_source_window): Update.
 482         * tui/tui-regs.c (tui_show_registers): Update.
 483         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 484         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 485         (NO_REGS_STRING): Remove defines.
 486
 487 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 488
 489         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 490         unnecessary thread walk if remote doesn't support the packet.
 491
 492 2019-08-19  Tom Tromey  <tromey@adacore.com>
 493
 494         * python/py-value.c (value_has_field): Fix indentation.
 495
 496 2019-08-19  Tom Tromey  <tromey@adacore.com>
 497
 498         * printcmd.c (do_one_display, info_display_command): Update.
 499         * block.h (contained_in): Return bool.  Add allow_nested
 500         parameter.
 501         * block.c (contained_in): Return bool.  Add allow_nested
 502         parameter.
 503
 504 2019-08-19  Tom Tromey  <tom@tromey.com>
 505
 506         * configure: Rebuild.
 507         * configure.ac: Disallow the combination of -static-libstdc++ and
 508         source highlight.
 509         * source-cache.c (get_language_name): Handle rust.
 510         (source_cache::get_source_lines): Ignore highlighting exceptions.
 511
 512 2019-08-16  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 515         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 516         (struct tui_source_window_base) <make_visible, refresh_window,
 517         resize>: Remove methods.
 518         <execution_info>: Remove field.
 519         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 520         (tui_show_source_line, tui_source_window_base)
 521         (~tui_source_window_base): Update.
 522         (tui_source_window_base::resize)
 523         (tui_source_window_base::make_visible)
 524         (tui_source_window_base::refresh_window): Remove.
 525         (tui_source_window_base::update_exec_info): Update.
 526         * tui/tui-source.c (tui_source_window::set_contents): Update.
 527         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 528
 529 2019-08-16  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 532         deprecated_query_hook.
 533
 534 2019-08-16  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 537         (tui_update_source_windows_with_line): Update.
 538         * tui/tui-source.h (struct tui_source_window)
 539         <show_symtab_source>: Declare.
 540         (tui_show_symtab_source): Don't declare.
 541         * tui/tui-source.c (tui_show_symtab_source): Rename from
 542         tui_show_symtab_source.
 543
 544 2019-08-16  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-winsource.h (struct tui_source_window_base)
 547         <set_contents>: Declare.
 548         * tui/tui-winsource.c
 549         (tui_source_window_base::update_source_window_as_is): Update.
 550         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 551         Declare.
 552         (tui_set_source_content): Don't declare.
 553         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 554         tui_set_source_content.
 555         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 556         Declare.
 557         (tui_set_disassem_content): Don't declare.
 558         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 559         tui_set_disassem_content.
 560
 561 2019-08-16  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-winsource.h (struct tui_source_window_base)
 564         <update_breakpoint_info>: Declare.
 565         (tui_update_breakpoint_info): Don't declare.
 566         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 567         (tui_update_all_breakpoint_info): Update.
 568         (tui_source_window_base::update_breakpoint_info): Rename from
 569         tui_update_breakpoint_info.
 570         (tui_source_window_base::update_exec_info): Update.
 571
 572 2019-08-16  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-winsource.h (struct tui_source_window_base)
 575         <update_source_window>: Declare.
 576         (tui_update_source_window): Don't declare.
 577         * tui/tui-winsource.c
 578         (tui_source_window_base::update_source_window): Rename from
 579         tui_update_source_window.
 580         (tui_source_window_base::rerender): Update.
 581         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 582         * tui/tui-disasm.c (tui_show_disassem)
 583         (tui_show_disassem_and_update_source)
 584         (tui_disasm_window::maybe_update): Update.
 585
 586 2019-08-16  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-winsource.h (struct tui_source_window_base)
 589         <update_source_window_as_is>: Declare.
 590         (tui_update_source_window_as_is): Don't declare.
 591         * tui/tui-winsource.c (tui_update_source_window): Update
 592         (tui_source_window_base::update_source_window_as_is): Rename from
 593         tui_update_source_window_as_is.
 594         (tui_source_window_base::refill): Update.
 595         * tui/tui-source.c (tui_show_symtab_source): Update.
 596         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 597         Update.
 598
 599 2019-08-16  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-winsource.h (tui_update_source_window)
 602         (tui_update_source_window_as_is): Remove "noerror" parameter.
 603         * tui/tui-winsource.c (tui_update_source_window)
 604         (tui_update_source_window_as_is): Remove "noerror" parameter.
 605         (tui_update_source_windows_with_addr)
 606         (tui_update_source_windows_with_line)
 607         (tui_source_window_base::rerender)
 608         (tui_source_window_base::refill): Update.
 609         * tui/tui-source.h (tui_set_source_content)
 610         (tui_show_symtab_source): Remove "noerror" parameter.
 611         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 612         parameter.
 613         (tui_show_symtab_source): Likewise.
 614         (tui_source_window::maybe_update): Update.
 615         * tui/tui-disasm.c (tui_show_disassem)
 616         (tui_show_disassem_and_update_source)
 617         (tui_disasm_window::do_scroll_vertical)
 618         (tui_disasm_window::maybe_update): Update.
 619
 620 2019-08-16  Tom Tromey  <tom@tromey.com>
 621
 622         * tui/tui.c (tui_is_window_visible): Update.
 623         * tui/tui-wingeneral.c (tui_make_window)
 624         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 625         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 626         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 627         (tui_set_win_height_command, parse_scrolling_args): Update.
 628         * tui/tui-source.c (tui_source_window::style_changed): Update.
 629         * tui/tui-regs.c (tui_show_registers)
 630         (tui_data_window::first_data_item_displayed)
 631         (tui_data_window::delete_data_content_windows)
 632         (tui_check_register_values, tui_reg_command): Update.
 633         * tui/tui-disasm.c (tui_show_disassem): Update.
 634         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 635         method.
 636         <is_visible>: Remove field.
 637         * tui/tui-data.c (tui_next_win, tui_prev_win)
 638         (tui_delete_invisible_windows): Update.
 639
 640 2019-08-16  Tom Tromey  <tom@tromey.com>
 641
 642         * tui/tui-winsource.h (struct tui_source_window_base)
 643         <m_has_locator>: Remove.
 644         * tui/tui-layout.c (show_source_disasm_command, show_data)
 645         (show_source_or_disasm_and_command): Update.
 646
 647 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 648
 649         * NEWS (Other MI changes): New subsection.
 650         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 651         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 652         * arch-utils.c (default_get_pc_address_flags): New function.
 653         * arch-utils.h (default_get_pc_address_flags): New declaration.
 654         * gdbarch.sh: Add get_pc_address_flags.
 655         * gdbarch.c: Regenerate.
 656         * gdbarch.h: Likewise.
 657         * stack.c (print_pc): New function.
 658         (print_frame_info) (print_frame): Call print_pc.
 659
 660 2019-08-16  Tom de Vries  <tdevries@suse.de>
 661
 662         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 663         print_objfile_section_info.
 664
 665 2019-08-15  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 668         calling update_cmdwin_start_line.
 669         * tui/tui-winsource.h (struct tui_source_window_base)
 670         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 671         <rerender>: Declare.
 672         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 673         Call rerender.
 674         (tui_source_window_base::set_new_height): Remove.
 675         (tui_source_window_base::rerender): Rename from
 676         do_make_visible_with_new_height.
 677         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 678         resize method.
 679         (tui_win_info::make_invisible_and_set_new_height)
 680         (tui_win_info::make_visible_with_new_height): Remove.
 681         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 682         Declare.
 683         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 684         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 685         do_make_visible_with_new_height>: Don't declare.
 686         <rerender>: Declare.
 687         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 688         set_new_height.
 689         (tui_data_window::do_make_visible_with_new_height): Remove.
 690         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 691         call tui_show_locator_content.
 692         (tui_gen_win_info::resize): Call rerender.
 693         (show_source_or_disasm_and_command): Don't call
 694         tui_show_locator_content.
 695         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 696         method.
 697         (struct tui_win_info) <rerender>: Declare.
 698         <set_new_height, make_invisible_and_set_new_height,
 699         make_visible_with_new_height>: Don't declare.
 700         * tui/tui-data.c (tui_win_list::rerender): New method.
 701         * tui/tui-command.h (struct tui_cmd_window)
 702         <do_make_visible_with_new_height>: Don't declare.
 703         * tui/tui-command.c
 704         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 705
 706 2019-08-15  Tom Tromey  <tromey@adacore.com>
 707
 708         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 709         * ada-lang.c (ada_enum_name): Likewise.
 710
 711 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 712
 713         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 714         leading underscore.
 715         (GdbOutputErrorFile): Likewise.
 716         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 717         accordingly.
 718         (execute_unwinders): Rename to have a leading underscore.
 719         (auto_load_packages): Likewise.
 720         (global scope): Adjust call to auto_load_packages accordingly.
 721         (GdbSetPythonDirectory): Likewise.
 722         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 723         instead of execute_unwinders.
 724
 725 2019-08-15  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 728         (show_data): Don't change window visibility.
 729         (tui_gen_win_info::resize): Remove special case for command
 730         window.  Use wresize, when available.
 731         (show_source_or_disasm_and_command): Don't change window
 732         visibility.
 733         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 734         <make_visible>: New method.
 735         * tui/tui-command.c (tui_cmd_window::resize): New method.
 736
 737 2019-08-15  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 740         (struct tui_source_windows): New.
 741         * tui/tui-winsource.c (tui_display_main): Update.
 742         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 743         (new_height_ok, parse_scrolling_args): Update.
 744         * tui/tui-layout.c (show_layout, show_data): Update.
 745         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 746         (tui_add_to_source_windows): Don't declare.
 747         * tui/tui-data.c (source_windows, tui_source_windows)
 748         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 749
 750 2019-08-15  Tom Tromey  <tom@tromey.com>
 751
 752         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 753         Rename from reset.
 754         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 755         * tui/tui-layout.c (show_source_disasm_command, show_data):
 756         Update.
 757         (tui_gen_win_info::resize): Rename.
 758         (show_source_or_disasm_and_command): Update.
 759         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 760         reset.
 761
 762 2019-08-15  Tom Tromey  <tom@tromey.com>
 763
 764         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 765         * tui/tui-interp.c (tui_interp::init): Don't call
 766         tui_initialize_static_data.
 767         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 768
 769 2019-08-15  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 772         examine tui_win_list.
 773
 774 2019-08-15  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 777         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 778         tui_clear_source_content.
 779         (tui_clear_source_content): Remove.
 780         (tui_source_window_base::do_erase_source_content): Hoist call to
 781         content.clear().
 782         * tui/tui-stack.c (tui_show_frame_info): Don't call
 783         tui_clear_source_content.
 784
 785 2019-08-15  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-winsource.h (struct tui_source_window_base)
 788         <do_erase_source_content>: New method.
 789         <erase_source_content>: New method.
 790         (tui_erase_source_content): Don't declare.
 791         * tui/tui-winsource.c (tui_clear_source_content): Update.
 792         (tui_source_window_base::do_erase_source_content): Rename from
 793         tui_erase_source_content.
 794         (tui_source_window_base::show_source_content): Update.
 795         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 796         * tui/tui-source.h (struct tui_source_window)
 797         <erase_source_content>: New method.
 798         * tui/tui-disasm.h (struct tui_disasm_window)
 799         <erase_source_content>: New method.
 800
 801 2019-08-15  Tom Tromey  <tom@tromey.com>
 802
 803         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 804         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 805         constructor.
 806         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 807         * tui/tui-source.c (tui_set_source_content): Update.
 808         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 809
 810 2019-08-15  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 813         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 814         tui-source.c.
 815         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 816         Declare.
 817         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 818         method.
 819         (tui_source_window::maybe_update): Update.
 820
 821 2019-08-15  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 824         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 825         tui-disasm.c.
 826         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 827         Declare.
 828         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 829         method.
 830         (tui_disasm_window::maybe_update): Update.
 831
 832 2019-08-15  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-winsource.h (struct tui_source_window_base)
 835         <maybe_update>: Declare.
 836         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 837         method.
 838         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 839         Declare.
 840         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 841         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 842         Declare.
 843         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 844
 845 2019-08-15  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 848
 849 2019-08-15  Tom Tromey  <tom@tromey.com>
 850
 851         * tui/tui-wingeneral.c: Include tui-stack.h.
 852         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 853         (struct tui_locator_window): Move from tui-data.h.
 854         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 855         (tui_initialize_static_data): Move from tui-data.c.
 856         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 857         (struct tui_locator_window): Move to tui-stack.c.
 858         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 859         (tui_initialize_static_data): Move to tui-stack.c.
 860
 861 2019-08-15  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-layout.c (show_source_disasm_command)
 864         (show_source_or_disasm_and_command): Use make_visible method, not
 865         tui_make_window.
 866         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 867         Remove.
 868
 869 2019-08-15  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-wingeneral.h (tui_make_window): Update.
 872         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 873         parameter.
 874         (tui_gen_win_info::make_visible): Update.
 875         * tui/tui-regs.c (tui_data_window::display_registers_from):
 876         Update.
 877         * tui/tui-layout.c (show_source_disasm_command)
 878         (show_source_or_disasm_and_command): Update.
 879         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 880         (enum tui_box): Remove.
 881         (struct tui_win_info) <can_box>: New method.
 882         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 883         method.
 884
 885 2019-08-15  Tom de Vries  <tdevries@suse.de>
 886
 887         * linux-nat-trad.c: Include gdbarch.h.
 888
 889 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 890
 891         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 892         register sizes.
 893
 894 2019-08-14  Tom Tromey  <tromey@adacore.com>
 895
 896         * darwin-nat.c: Include gdbarch.h.
 897         * darwin-nat-info.c: Include gdbarch.h.
 898
 899 2019-08-13  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 902         Remove.
 903         * tui/tui-data.c (tui_initialize_static_data): Update.
 904
 905 2019-08-13  Tom Tromey  <tom@tromey.com>
 906
 907         * tui/tui-winsource.h (struct tui_exec_info_window)
 908         <~tui_exec_info_window, maybe_allocate_content, get_content,
 909         m_content>: Remove.
 910         (struct tui_source_window_base) <set_exec_info_content,
 911         show_exec_info_content>: Don't declare.
 912         * tui/tui-winsource.c
 913         (tui_exec_info_window::maybe_allocate_content): Remove.
 914         (tui_source_window_base::update_exec_info): Rename from
 915         set_exec_info_content.
 916         (tui_source_window_base::show_exec_info_content)
 917         (tui_source_window_base::update_exec_info): Remove.
 918
 919 2019-08-13  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 922         declare.
 923         * tui/tui-winsource.c (tui_update_source_window_as_is)
 924         (tui_update_source_windows_with_addr, tui_erase_source_content):
 925         Update.
 926         (tui_clear_exec_info_content): Remove.
 927
 928 2019-08-13  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 931         declare.
 932         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 933         call tui_erase_exec_info_content.
 934         (tui_clear_exec_info_content): Rename from
 935         tui_erase_exec_info_content.
 936         (tui_clear_exec_info_content): Delete.
 937
 938 2019-08-13  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-winsource.h (struct tui_source_window_base)
 941         <show_exec_info_content>: Declare.
 942         (tui_show_exec_info_content): Don't declare.
 943         * tui/tui-winsource.c
 944         (tui_source_window_base::show_exec_info_content): Rename from
 945         tui_show_exec_info_content.
 946         (tui_source_window_base::update_exec_info): Update.
 947
 948 2019-08-13  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 951         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 952         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 953         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 954         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 955         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 956         ... here.
 957
 958 2019-08-13  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-winsource.h (struct tui_source_window_base)
 961         <update_exec_info>: Declare.
 962         (tui_update_exec_info): Don't declare.
 963         * tui/tui-winsource.c (tui_update_source_window_as_is)
 964         (tui_source_window_base::refresh_all)
 965         (tui_update_all_breakpoint_info): Update.
 966         (tui_source_window_base::update_exec_info): Rename from
 967         tui_update_exec_info.
 968         * tui/tui-stack.c (tui_show_frame_info): Update.
 969
 970 2019-08-13  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-winsource.h (struct tui_source_window_base)
 973         <set_exec_info_content>: Declare.
 974         (tui_set_exec_info_content): Don't declare.
 975         * tui/tui-winsource.c
 976         (tui_source_window_base::set_exec_info_content): Rename from
 977         tui_set_exec_info_content.
 978         (tui_update_exec_info): Update.
 979
 980 2019-08-13  Tom Tromey  <tom@tromey.com>
 981
 982         * tui/tui-winsource.h (struct tui_source_window_base)
 983         <show_source_content>: Declare.
 984         (tui_show_source_content): Don't declare.
 985         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 986         (tui_source_window_base::show_source_content): Rename from
 987         tui_show_source_content.
 988         (tui_source_window_base::refresh_all): Update.
 989         * tui/tui-layout.c (show_source_disasm_command)
 990         (show_source_or_disasm_and_command): Update.
 991
 992 2019-08-13  Tom Tromey  <tom@tromey.com>
 993
 994         * tui/tui-winsource.c (tui_erase_source_content)
 995         (tui_show_source_content, tui_source_window_base::refresh_all):
 996         Update.
 997         * tui/tui-wingeneral.h
 998         (tui_check_and_display_highlight_if_needed): Don't declare.
 999         * tui/tui-wingeneral.c
1000         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1001         check_and_display_highlight_if_needed.
1002         * tui/tui-win.c (tui_rehighlight_all)
1003         (tui_win_info::make_visible_with_new_height): Update.
1004         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1005         (tui_data_window::erase_data_content)
1006         (tui_data_window::display_all_data): Update.
1007         * tui/tui-data.h (struct tui_win_info)
1008         <check_and_display_highlight_if_needed>: Declare.
1009
1010 2019-08-13  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-win.c (tui_resize_all): Call
1013         tui_delete_invisible_windows.
1014         * tui/tui-layout.c (show_layout): Call
1015         tui_delete_invisible_windows.
1016         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1017         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1018
1019 2019-08-13  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1022         tui_add_win_to_layout.
1023
1024 2019-08-13  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1027         * tui/tui-layout.c (tui_default_win_height): Now static.
1028
1029 2019-08-13  Tom Tromey  <tom@tromey.com>
1030
1031         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1032         single switch.
1033         (show_source_disasm_command, show_source_or_disasm_and_command):
1034         Don't check current layout.
1035
1036 2019-08-13  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-wingeneral.c (make_all_visible): Remove.
1039         (tui_make_all_invisible): Simplify.
1040         * tui/tui-layout.c (tui_make_all_invisible): Move from
1041         tui-wingeneral.c; simplify.
1042         (show_layout): Hoist call to tui_make_all_invisible.
1043         (show_data): Don't call tui_make_all_invisible.
1044
1045 2019-08-13  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1048         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1049
1050 2019-08-13  Tom Tromey  <tom@tromey.com>
1051
1052         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1053         tui-data.c.
1054         (show_source_disasm_command, show_data)
1055         (show_source_or_disasm_and_command): Don't use
1056         tui_set_current_layout_to.
1057         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1058         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1059         tui-layout.c.
1060         (tui_set_current_layout_to): Remove.
1061
1062 2019-08-13  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-layout.c (tui_set_layout): Update.
1065         * tui/tui-data.h (struct tui_layout_def): Remove.
1066         (tui_layout_def): Don't declare.
1067         * tui/tui-data.c (layout_def): Remove.
1068         (tui_layout_def): Remove.
1069
1070 2019-08-13  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-winsource.h (struct tui_source_window_base)
1073         <clear_detail>: No longer "override".
1074         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1075         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1076         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1077         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1078         Remove.
1079         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1080
1081 2019-08-13  Tom Tromey  <tromey@adacore.com>
1082
1083         * tracepoint.c: Don't include readline.h or history.h.
1084
1085 2019-08-12  Tom Tromey  <tom@tromey.com>
1086
1087         * configure: Rebuild.
1088         * configure.ac: Check for readline 7.
1089         * NEWS: Mention readline 7 requirement.
1090         * README: Update.
1091
1092 2019-08-12  Tom Tromey  <tom@tromey.com>
1093
1094         * mingw-hdep.c (gdb_select): Remove readline hack.
1095
1096 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1097
1098         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1099         when the function fails.
1100
1101 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1102
1103         * s390-tdep.c (s390_type_align): New function.
1104         (s390_gdbarch_init): Set it as type_align gdbarch method.
1105
1106 2019-08-09  Tom de Vries  <tdevries@suse.de>
1107
1108         PR gdb/24591
1109         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1110         pc_low with relocation offset.
1111
1112 2019-08-07  Tom Tromey  <tromey@adacore.com>
1113
1114         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1115         (print_frame_args): Update.
1116         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1117         Update.
1118         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1119         * frame.h (struct frame_arg): Add initializers.
1120         <error>: Now a unique_xmalloc_ptr.
1121
1122 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1123
1124         * NEWS: Expand the Pointer Authentication entry.
1125         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1126         (aarch64_frame_unmask_lr): ... to this.
1127         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1128         Call aarch64_frame_unmask_lr.
1129         * frame.c (struct frame_info): Add "masked" variable.
1130         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1131         (fprint_frame): Check for masked pc.
1132         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1133         declarations.
1134         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1135         * stack.c (print_frame): Check for masked pc.
1136
1137 2019-08-06  Tom Tromey  <tom@tromey.com>
1138
1139         * stabsread.c (patch_block_stabs, read_one_struct_field)
1140         (read_enum_type): Use obstack_strndup.
1141         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1142         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1143         * dwarf2read.c (guess_full_die_structure_name)
1144         (anonymous_struct_prefix): Use obstack_strndup.
1145         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1146         * c-exp.y (yylex): Use obstack_strndup.
1147         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1148         (write_var_or_type): Use obstack_strndup.
1149
1150 2019-08-06  Tom Tromey  <tom@tromey.com>
1151
1152         * symfile.c (reread_symbols): Use obstack_strdup.
1153         * stabsread.c (read_type): Use obstack_strdup.
1154         * gdb_obstack.h (obstack_strdup): New overload.
1155         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1156         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1157         (dwarf2_canonicalize_name): Use obstack_strdup.
1158         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1159         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1160         Use obstack_strdup.
1161
1162 2019-08-06  Tom Tromey  <tom@tromey.com>
1163
1164         * gdb_obstack.h (obstack_strdup): Define.
1165         * gdb_obstack.c (obstack_strdup): Don't define.
1166
1167 2019-08-06  Tom Tromey  <tom@tromey.com>
1168
1169         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1170         obstack_strdup.
1171         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1172         obstack_strdup.
1173         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1174         * stabsread.c (common_block_start): Use obstack_strdup.
1175         * objfiles.c (set_objfile_main_name, objfile): Use
1176         obstack_strdup.
1177         * namespace.c (add_using_directive): Use obstack_strdup.
1178         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1179         * jit.c (finalize_symtab): Use obstack_strdup.
1180         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1181         (guess_partial_die_structure_name, partial_die_info::fixup)
1182         (dwarf2_name): Use obstack_strdup.
1183         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1184         obstack_strdup.
1185         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1186         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1187         obstack_strdup.
1188         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1189
1190 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1191
1192         * unittests/help-doc-selftests.c: New file.
1193         * Makefile.in: Add the new file.
1194
1195 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1196
1197         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1198         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1199         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1200         the trailing '.' is not output, and the first character is uppercased.
1201         (print_help_for_command): Update call to print_doc_line.
1202         (print_doc_of_command): Likewise.
1203         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1204         * cli/cli-option.c (append_indented_doc): Do not append newline.
1205         (build_help_option): Append newline after first appended_indented_doc
1206         only if a second call is done.
1207         (build_help): Append 2 new lines before each option, except the first
1208         one.
1209         * compile/compile.c (_initialize_compile): Add new lines after
1210         %OPTIONS%, when not at the end of the help.
1211         Change help doc or code
1212         producing the help doc to respect the invariants.
1213         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1214         Also removed the new line after 'Options:', as all other commands
1215         do not put an empty line between 'Options:' and the first option.
1216         * printcmd.c (_initialize_printcmd): Likewise.
1217         * stack.c (_initialize_stack): Likewise.
1218         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1219         incorrectly telling COMMAND is optional.
1220         * ada-lang.c (_initialize_ada_language): Change help doc or code
1221         producing the help doc to respect the invariants.
1222         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1223         * breakpoint.c (_initialize_breakpoint): Likewise.
1224         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1225         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1226         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1227         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1228         _initialize_cli_style): Likewise.
1229         * corelow.c (core_target_info): Likewise.
1230         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1231         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1232         * filesystem.c (_initialize_filesystem): Likewise.
1233         * frame.c (_initialize_frame): Likewise.
1234         * gnu-nat.c (add_task_commands): Likewise.
1235         * infcall.c (_initialize_infcall): Likewise.
1236         * infcmd.c (_initialize_infcmd): Likewise.
1237         * interps.c (_initialize_interpreter): Likewise.
1238         * language.c (_initialize_language): Likewise.
1239         * linux-fork.c (_initialize_linux_fork): Likewise.
1240         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1241         * maint.c (_initialize_maint_cmds): Likewise.
1242         * memattr.c (_initialize_mem): Likewise.
1243         * printcmd.c (_initialize_printcmd): Likewise.
1244         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1245         _RegEx): Likewise.
1246         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1247         * record-btrace.c (_initialize_record_btrace): Likewise.
1248         * record-full.c (_initialize_record_full): Likewise.
1249         * record.c (_initialize_record): Likewise.
1250         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1251         * regcache.c (_initialize_regcache): Likewise.
1252         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1253         _initialize_remote): Likewise.
1254         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1255         * serial.c (_initialize_serial): Likewise.
1256         * skip.c (_initialize_step_skip): Likewise.
1257         * source.c (_initialize_source): Likewise.
1258         * stack.c (_initialize_stack): Likewise.
1259         * symfile.c (_initialize_symfile): Likewise.
1260         * symtab.c (_initialize_symtab): Likewise.
1261         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1262         * top.c (init_main): Likewise.
1263         * tracefile-tfile.c (tfile_target_info): Likewise.
1264         * tracepoint.c (_initialize_tracepoint): Likewise.
1265         * tui/tui-win.c (_initialize_tui_win): Likewise.
1266         * utils.c (add_internal_problem_command): Likewise.
1267         * valprint.c (value_print_option_defs): Likewise.
1268
1269 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1270
1271         PR build/24886
1272         * configure.ac: Drop enable-libmcheck support.
1273         * configure, config.in: Rebuild.
1274         * libmcheck.m4: Remove.
1275         * acinclude.m4: Don't include it.
1276         * Makefile.in: Don't distribute it.
1277         * top.c (print_gdb_configuration): Don't mention it.
1278
1279 2019-08-06  Tom Tromey  <tom@tromey.com>
1280
1281         * utils.c (set_output_style): Sometimes pass stream to
1282         emit_style_escape.
1283         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1284         * record-btrace.c (btrace_insn_history): Update.
1285         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1286         method.
1287         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1288         Update initializers.
1289         <m_uiout>: New field.
1290         <m_di>: Move lower.
1291         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1292         Remove "uiout" parameter.
1293         (dump_insns): Update.
1294         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1295         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1296
1297 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1298
1299         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1300         (error_in_psymtab_expansion): Likewise.
1301         (lookup_symbol_via_quick_fns): Likewise.
1302         (basic_lookup_transparent_type_quick): Likewise.
1303         (basic_lookup_transparent_type_1): Likewise.
1304
1305 2019-08-06  Tom Tromey  <tromey@adacore.com>
1306
1307         * source.c (last_source_error): Now bool.
1308         (print_source_lines_base): Make "noprint" bool.  Only open
1309         source file when last_source_visited changes.
1310
1311 2019-08-06  Tom Tromey  <tromey@adacore.com>
1312
1313         * annotate.c (annotate_source_line): Use g_source_cache.
1314         * source-cache.c (source_cache::get_plain_source_lines): Change
1315         parameters.  Populate m_offset_cache.
1316         (source_cache::ensure): New method.
1317         (source_cache::get_line_charpos): New method.
1318         (extract_lines): Move lower.  Change parameters.
1319         (source_cache::get_source_lines): Move lower.
1320         * source-cache.h (class source_cache): Update comment.
1321         <get_line_charpos>: New method.
1322         <get_source_lines>: Update comment.
1323         <clear>: Clear m_offset_cache.
1324         <get_plain_source_lines>: Change parameters.
1325         <ensure>: New method
1326         <m_offset_cache>: New member.
1327         * source.c (forget_cached_source_info_for_objfile): Update.
1328         (info_source_command): Use g_source_cache.
1329         (find_source_lines, open_source_file_with_line_charpos): Remove.
1330         (print_source_lines_base, search_command_helper): Use g_source_cache.
1331         * source.h (open_source_file_with_line_charpos): Don't declare.
1332         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1333         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1334         Use g_source_cache.
1335
1336 2019-08-06  Tom Tromey  <tromey@adacore.com>
1337
1338         * source-cache.c (source_cache::get_plain_source_lines):
1339         Remove "first_line" and "last_line" parameters.
1340         (source_cache::get_source_lines): Cache plain text.
1341         * source-cache.h (class source_cache)
1342         <get_plain_source_lines>: Update.
1343
1344 2019-08-06  Tom Tromey  <tromey@adacore.com>
1345
1346         * source-cache.c (extract_lines): No longer a method.
1347         Changed type of parameter.  Include final newline.
1348         (selftests::extract_lines_test): New function.
1349         (_initialize_source_cache): Likewise.
1350         * source-cache.h (class source_cache)
1351         <extract_lines>: Don't declare.
1352
1353 2019-08-06  Tom Tromey  <tromey@adacore.com>
1354
1355         * breakpoint.c (init_breakpoint_sal): Update.
1356         (breakpoint): Update.
1357         * breakpoint.h (struct breakpoint) <filter>: Now a
1358         unique_xmalloc_ptr.
1359
1360 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1361
1362         * NEWS: Mention dictionary access on blocks.
1363         * python/py-block.c (blpy_getitem): New function.
1364         (block_object_as_mapping): New struct.
1365         (block_object_type): Use new struct for tp_as_mapping field.
1366
1367 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1368
1369         * objfiles.h (objfile): Add a comment describing partial symbols.
1370
1371 2019-08-05  Tom Tromey  <tromey@adacore.com>
1372
1373         * compile/compile.c (_initialize_compile): Use _(), not N_().
1374         * thread.c (_initialize_thread): Use _(), not N_().
1375         * stack.c (_initialize_stack): Use _(), not N_().
1376         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1377
1378 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1379
1380         * dwarf2read.c (struct dw2_symtab_iterator):
1381         <want_specific_block>: Remove.
1382         <block_index>: Change type to gdb::optional.
1383         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1384         change type of BLOCK_INDEX parameter to gdb::optional.
1385         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1386         (dw2_lookup_symbol): Don't pass argument for
1387         WANT_SPECIFIC_BLOCK.
1388         (dw2_expand_symtabs_for_function): Don't pass argument for
1389         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1390         (class dw2_debug_names_iterator)
1391         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1392         parameter, change BLOCK_INDEX type to gdb::optional.
1393         <m_want_specific_block>: Remove.
1394         <m_block_index>: Change type to gdb::optional.
1395         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1396         gdb::optional.  Re-write in function of gdb::optional.
1397         (dw2_debug_names_lookup_symbol): Don't pass argument for
1398         WANT_SPECIFIC_BLOCK.
1399         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1400         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1401         BLOCK_INDEX.
1402
1403 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1404
1405         * NEWS: Mention changes to "info sources" command.
1406
1407 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1408
1409         * symtab.c (filename_partial_match_opts): New struct type.
1410         (struct output_source_filename_data): New members
1411         regexp, c_regexp, partial_match.
1412         (output_source_filename): Use new members to decide to print file.
1413         (info_sources_option_defs): New variable.
1414         (make_info_sources_options_def_group, print_info_sources_header,
1415         info_sources_command_completer):
1416         New functions.
1417         (info_sources_command): Read new optional arguments.
1418         (_initialize_symtab): Update info sources help.
1419
1420 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1421
1422         * ada-lang.c (exception_support_info_v0): Renamed from...
1423         (default_exception_support_info): ... this.  Create new
1424         definition for v1.
1425         (ada_has_this_exception_support): Look up catch_handlers_sym.
1426         (ada_exception_support_info_sniffer): Try v0 after default.
1427
1428 2019-08-01  Tom Tromey  <tromey@adacore.com>
1429
1430         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1431         gdbarch.h.
1432
1433 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1434
1435         * s12z-tdep.c: Fix include path for s12z-opc.h.
1436
1437 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1438
1439         * NEWS: Require GNU make 3.82.
1440
1441 2019-07-16  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1444         declare.
1445
1446 2019-07-30  Tom Tromey  <tromey@adacore.com>
1447
1448         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1449
1450 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1451
1452         * printcmd.c (print_address_symbolic): Print negative offsets.
1453         (build_address_symbolic): Force signed arithmetic when computing
1454         offset.
1455
1456 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1457
1458         PR/24474: Add a function to lookup static variables.
1459         * NEWS: Mention this new function.
1460         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1461         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1462         * python/python.c (python_GdbMethods): Add new function.
1463
1464 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1465
1466         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1467         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1468         (objfpy_lookup_static_symbol): New function.
1469         (objfile_object_methods): Add new functions.
1470
1471 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1472
1473         * NEWS: Mention 'set|show print frame-info'.  Mention new
1474         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1475         backtrace argument.  Mention that python frame filtering code
1476         is now consistent with what 'backtrace' command prints.
1477
1478 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1479
1480         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1481         comments.
1482         (print_frame_info_auto, print_frame_info_source_line,
1483         print_frame_info_location, print_frame_info_source_and_location,
1484         print_frame_info_location_and_address, print_frame_info_short_location):
1485         New declarations.
1486         (struct frame_print_options): New member print_frame_info.
1487         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1488         * stack.h (get_user_print_what_frame_info): New declaration.
1489         (frame_show_address): New declaration.
1490         * stack.c (print_frame_arguments_choices): New value 'presence'.
1491         (print_frame_info_auto, print_frame_info_source_line,
1492         print_frame_info_location, print_frame_info_source_and_location,
1493         print_frame_info_location_and_address, print_frame_info_short_location,
1494         print_frame_info_choices, print_frame_info_print_what): New definitions.
1495         (print_frame_args): Only print dots for args if print frame-arguments
1496         is 'presence'.
1497         (frame_print_option_defs): New element for "frame-info".
1498         (get_user_print_what_frame_info): New function.
1499         (frame_show_address): Make non static.  Move comment to stack.h.
1500         (print_frame_info_to_print_what): New function.
1501         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1502         to decide what to print.
1503         (backtrace_command_1): Handle the new print_frame_arguments_presence
1504         value.
1505         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1506         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1507         (py_print_frame): In non-mi mode, use LOCATION as default for
1508         print_what, similarly to frame information printed directly by
1509         backtrace command. Handle frame-info user option in non MI mode.
1510
1511 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1512
1513         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1514         Add case for debugging 32-bit target on 64-bit host.  Revise
1515         comment.
1516
1517 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1518
1519         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1520         instead of find_function_entry_range_from_pc.
1521
1522 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1523
1524         * stack.c (find_frame_funname): Remove code which preferred
1525         minsym over symtab sym in "certain pathological cases".
1526
1527         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1528         parameter.  Change type of "do_demangle" to bool.
1529         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1530         Pass suitable "prefer_sym_over_minsym" flag to
1531         build_address_symbolic().  Don't output "+" for negative offsets.
1532         * printcmd.c (print_address_symbolic): Update invocation of
1533         build_address_symbolic to include a "prefer_sym_over_minsym"
1534         flag.
1535         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1536         Restrict cases in which use of minimal symbol is preferred to that
1537         of a found symbol.  Update comments.
1538
1539         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1540         for entry pc when entry pc is out of range for that FDE.
1541
1542 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1543
1544         PR gdb/24839:
1545         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1546         type.
1547
1548 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1549
1550         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1551         this function's Python signature.
1552
1553
1554 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1555
1556         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1557         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1558         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1559         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1560         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1561
1562
1563 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1564
1565         * h8300-tdep.c (h8300_register_name_common): New.
1566         h8300_register_name): Use h8300_register_name_common.
1567         (h8300s_register_name): Likewise.
1568         (h8300sx_register_name): Likewise.
1569         (h8300h_register_nam): New.
1570         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1571
1572
1573 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1574
1575         * arm-tdep.c (arm_skip_cmse_entry): New function.
1576         (arm_is_sgstubs_section): New function.
1577         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1578
1579 2019-07-22  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1582         Don't self-assign.
1583
1584 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1587         type_print.
1588
1589 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1590
1591         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1592         so that GDB doesn't match any msymbols when searching in the
1593         TYPES_DOMAIN.
1594         (print_symbol_info): Print using typedef_print or type_print based
1595         on the type of the symbol.  Add updated FIXME comment moved from...
1596         (_initialize_symtab): ... move and update FIXME comment to above.
1597
1598 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1599
1600         * NEWS: Mention adding -q option to "info types".
1601         * symtab.c (struct info_types_options): New struct.
1602         (info_types_options_defs): New variable.
1603         (make_info_types_options_def_group): New function.
1604         (info_types_command): Use gdb::option framework to parse options.
1605         (info_types_command_completer): New function.
1606         (_initialize_symtab): Extend the help text on "info types" and
1607         register command completer.
1608
1609 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1610
1611         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1612         (lookup_symbol_in_objfile): Change int to block_enum and add a
1613         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1614
1615 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1616
1617         * MAINTAINERS (Write After Approval): Add self.
1618
1619 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1620
1621         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1622         instruction to the dummy code region.
1623
1624 2019-07-19  Tom Tromey  <tromey@adacore.com>
1625
1626         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1627         (ARGSUSED, PARAMS, __func__): Remove rules.
1628
1629 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1630
1631         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1632         * features/arm/arm-with-iwmmxt.c: Remove.
1633         * features/arm/arm-with-iwmmxt.xml: Remove.
1634         * features/arm/arm-with-m-fpa-layout.c: Remove.
1635         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1636         * features/arm/arm-with-m-vfp-d16.c: Remove.
1637         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1638         * features/arm/arm-with-m.c: Remove.
1639         * features/arm/arm-with-m.xml: Remove.
1640         * features/arm/arm-with-neon.c: Remove.
1641         * features/arm/arm-with-neon.xml: Remove.
1642         * features/arm/arm-with-vfpv2.c: Remove.
1643         * features/arm/arm-with-vfpv2.xml: Remove.
1644         * features/arm/arm-with-vfpv3.c: Remove.
1645         * features/arm/arm-with-vfpv3.xml: Remove.
1646
1647 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1648
1649         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1650
1651 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1652
1653         * arch/aarch32.c (aarch32_create_target_description): Create
1654         target descriptions using features.
1655         * arch/arm.c (arm_create_target_description)
1656         (arm_create_mprofile_target_description): Likewise.
1657         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1658
1659 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1660
1661         * Makefile.in: Add new files.
1662         * aarch32-tdep.c: New file.
1663         * aarch32-tdep.h: New file.
1664         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1665         Call aarch32_read_description.
1666         * arch/aarch32.c: New file.
1667         * arch/aarch32.h: New file.
1668         * arch/arm.c (arm_create_target_description)
1669         (arm_create_mprofile_target_description): New function.
1670         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1671         (arm_create_target_description)
1672         (arm_create_mprofile_target_description): New declaration.
1673         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1674         read_description functions.
1675         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1676         Likewise.
1677         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1678         * arm-tdep.c (tdesc_arm_list): New variable.
1679         (arm_register_g_packet_guesses): Call create description functions.
1680         (arm_read_description) (arm_read_mprofile_description): New
1681         function.
1682         * arm-tdep.h (arm_read_description)
1683         (arm_read_mprofile_description): Add declaration.
1684         * configure.tgt: Add new files.
1685
1686 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1687
1688         * top.c (new_ui_command): Open specified terminal just once.
1689
1690 2019-07-18  Tom Tromey  <tromey@adacore.com>
1691
1692         * symtab.c (main_name): Constify return type.
1693         * symfile.c (set_initial_language): Update.
1694         * symtab.h (main_name): Constify return type.
1695
1696 2019-07-17  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-winsource.c (tui_update_source_window)
1699         (tui_update_source_window_as_is)
1700         (tui_update_source_windows_with_line): Remove return.
1701         * tui/tui-disasm.c (tui_show_disassem)
1702         (tui_show_disassem_and_update_source): Remove return.
1703         * tui/tui.c (tui_reset): Remove return.
1704         * tui/tui-wingeneral.c
1705         (tui_check_and_display_highlight_if_needed): Remove return.
1706
1707 2019-07-17  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1710
1711 2019-07-17  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-winsource.h (struct tui_exec_info_window)
1714         (struct tui_source_window_base): Move from tui-data.h.
1715         * tui/tui-winsource.c: Move many method definitions from
1716         elsewhere.  Remove "structuring" comments.
1717         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1718         (tui_source_window_base::refresh_window): Move to
1719         tui-winsource.c.
1720         * tui/tui-win.c (tui_source_window_base::refresh_all)
1721         (tui_source_window_base::update_tab_width)
1722         (tui_source_window_base::set_new_height)
1723         (tui_source_window_base::do_make_visible_with_new_height): Move to
1724         tui-winsource.c.
1725         * tui/tui-source.h: Update.
1726         * tui/tui-source.c (tui_source_window_base::reset): Move to
1727         tui-winsource.c.
1728         * tui/tui-disasm.h: Update.
1729         * tui/tui-data.h (struct tui_exec_info_window): Move to
1730         tui-winsource.h.
1731         (struct tui_source_window_base): Likewise.
1732         * tui/tui-data.c (tui_source_window_base::clear_detail)
1733         (tui_source_window_base, ~tui_source_window_base): Move to
1734         tui-winsource.c.
1735
1736 2019-07-17  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-win.c (tui_resize_all)
1739         (tui_source_window_base::update_tab_width)
1740         (tui_adjust_win_heights): Update.
1741         (tui_win_info::make_invisible_and_set_new_height): Rename from
1742         make_invisible_and_set_new_height.
1743         * tui/tui-data.h (struct tui_win_info)
1744         <make_invisible_and_set_new_height>: New method.
1745
1746 2019-07-17  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui.c: Update.
1749         * tui/tui-source.h (struct tui_source_window): Move from
1750         tui-data.h.
1751         * tui/tui-layout.c: Update.
1752         * tui/tui-disasm.c: Update.
1753         * tui/tui-data.h (struct tui_source_window): Move to
1754         tui-source.h.
1755
1756 2019-07-17  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1759         tui-data.h.
1760         * tui/tui-data.h (struct tui_disasm_window): Move to
1761         tui-disasm.h.
1762
1763 2019-07-17  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-regs.h (struct tui_data_item_window): Move from
1766         tui-data.h.
1767         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1768         * tui/tui-data.h (struct tui_data_item_window): Move to
1769         tui-regs.h.
1770         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1771
1772 2019-07-17  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui.c: Update.
1775         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1776         (tui_cmd_window::max_height): Move to tui-command.c.
1777         * tui/tui-layout.c: Update.
1778         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1779         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1780         tui-command.c.
1781         * tui/tui-command.h (struct tui_cmd_window): Move from
1782         tui-data.h.
1783         * tui/tui-command.c: Remove "structuring" comments.
1784         (tui_cmd_window::clear_detail)
1785         (tui_cmd_window::do_make_visible_with_new_height)
1786         (tui_cmd_window::max_height): Move from elsewhere.
1787
1788 2019-07-17  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1791         Now static.
1792         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1793         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1794
1795 2019-07-17  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui.c: Update.
1798         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1799         tui-regs.c.
1800         * tui/tui-windata.h: Remove file.
1801         * tui/tui-windata.c: Remove file.
1802         * tui/tui-win.c (tui_data_window::set_new_height)
1803         (tui_data_window::do_make_visible_with_new_height): Move to
1804         tui-regs.c.
1805         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1806         * tui/tui-regs.c: Remove "structuring" comments.
1807         (tui_data_window::first_data_item_displayed)
1808         (tui_data_window::delete_data_content_windows)
1809         (tui_data_window::erase_data_content)
1810         (tui_data_window::display_all_data)
1811         (tui_data_window::refresh_all)
1812         (tui_data_window::do_scroll_vertical)
1813         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1814         (tui_data_window::do_make_visible_with_new_height)
1815         (tui_data_window::refresh_window): Move from elsewhere.
1816         (_initialize_tui_regs): Move to end of file.
1817         * tui/tui-layout.c: Update.
1818         * tui/tui-hooks.c: Update.
1819         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1820         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1821         tui-regs.c.
1822         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1823
1824 2019-07-17  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1827         seen.
1828
1829 2019-07-17  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-win.c (tui_source_window_base::set_new_height)
1832         (tui_source_window_base::do_make_visible_with_new_height): Use
1833         m_has_locator field directly.
1834         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1835         method.
1836         (struct tui_source_window_base) <has_locator>: Likewise.
1837
1838 2019-07-17  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1841         Don't declare.
1842         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1843         Remove.
1844         * tui/tui-win.c (tui_source_window_base::set_new_height)
1845         (tui_source_window_base::set_new_height)
1846         (make_invisible_and_set_new_height)
1847         (tui_source_window_base::do_make_visible_with_new_height)
1848         (tui_source_window_base::do_make_visible_with_new_height):
1849         Update.
1850         * tui/tui-layout.c (show_source_disasm_command, show_data)
1851         (show_source_or_disasm_and_command): Update.
1852         * tui/tui-layout.c (show_layout): Update.
1853
1854 2019-07-17  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-layout.c (make_data_window): Remove.
1857         (show_data): Unify creation and re-initialization cases.
1858
1859 2019-07-17  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-layout.c (make_source_window, make_disasm_window):
1862         Remove.
1863         (show_data): Unify creation and re-initialization cases.
1864
1865 2019-07-17  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-layout.c (make_command_window): Remove.
1868         (show_source_disasm_command, show_source_or_disasm_and_command):
1869         Unify creation and re-initialization cases.
1870
1871 2019-07-17  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1874         creation and re-initialization cases.
1875
1876 2019-07-17  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-regs.c (tui_get_register): Return void.
1879
1880 2019-07-17  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1883         Simplify.
1884
1885 2019-07-17  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1888         resetting.
1889
1890 2019-07-17  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1893         * tui/tui-regs.c (tui_reg_layout): New function.
1894         (tui_show_registers, tui_reg_command): Use it.
1895         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1896         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1897         parameters.
1898         (tui_layout_command): Remove.
1899
1900 2019-07-17  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-layout.h (tui/tui-layout): Return void.
1903         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1904
1905 2019-07-17  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-layout.c (show_source_disasm_command, show_data):
1908         Update.
1909         (reset_locator): Remove.
1910         (show_source_or_disasm_and_command): Update.
1911
1912 2019-07-17  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-source.c (tui_source_window_base::reset): Remove
1915         win_type parameter.
1916         * tui/tui-layout.c (make_command_window, make_source_window)
1917         (make_disasm_window, make_data_window)
1918         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1919         (reset_locator, show_source_or_disasm_and_command): Update.
1920         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1921         win_type parameter.
1922         (struct tui_source_window_base) <reset>: Likewise.
1923
1924 2019-07-17  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-layout.c (show_source_disasm_command): Use
1927         reset_locator.
1928         (reset_locator): New function.
1929         (init_and_make_win): Remove.
1930         (show_source_or_disasm_and_command): Use reset_locator.
1931
1932 2019-07-17  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1935         condition.
1936         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1937         Remove condition.
1938         * tui/tui-source.c (tui_source_window_base::reset): New method.
1939         * tui/tui-layout.c (make_command_window): Don't call
1940         init_and_make_win.
1941         (make_source_window, make_disasm_window): Don't call
1942         make_source_or_disasm_window.
1943         (make_data_window): Don't call init_and_make_win.  Change calling
1944         convention.
1945         (show_source_disasm_command, show_data): Simplify.
1946         (make_source_or_disasm_window): Remove.
1947         (show_source_or_disasm_and_command): Simplify.
1948         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1949         (struct tui_source_window_base) <reset>: Likewise.
1950         <execution_info>: Remove initializer.
1951         * tui/tui-data.c (tui_source_window_base): Initialize
1952         execution_info.
1953
1954 2019-07-17  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1957         variable.
1958
1959 2019-07-17  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui.c (tui_rl_other_window): Update.
1962         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1963         superclass method first.  Always iterate over regs_content.
1964         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1965         method.
1966         * tui/tui-win.c (tui_set_focus_command): Update.
1967
1968 2019-07-17  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-win.c (tui_set_focus_command): Rename from
1971         tui_set_focus.  Call tui_enable.
1972         (tui_set_focus_command): Remove.
1973
1974 2019-07-17  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1977         refresh_window.
1978         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1979         touchwin.
1980         (tui_data_window::refresh_window): Call refresh_window on data
1981         items.  Always call superclass refresh_window.
1982         (tui_win_info::refresh): Remove.
1983         (tui_source_window_base::refresh_window): Update.
1984         (tui_refresh_all): Update.
1985         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1986         refresh_window.
1987         (show_source_or_disasm_and_command): Likewise.
1988         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1989         (struct tui_source_window_base) <refresh>: Likewise.
1990
1991 2019-07-17  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-winsource.c (tui_clear_source_content)
1994         (tui_show_source_content): Update.
1995         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1996         whether content is empty.
1997         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1998         Remove.
1999
2000 2019-07-17  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2003         window's contents.
2004         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2005         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2006
2007 2019-07-17  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2010         (struct tui_data_item_window): Update.
2011
2012 2019-07-17  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2015         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2016         defines.
2017
2018 2019-07-17  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-winsource.h (tui_erase_source_content)
2021         (tui_clear_source_content): Remove "display_prompt" parameter.
2022         * tui/tui-winsource.c (tui_update_source_window_as_is)
2023         (tui_update_source_windows_with_addr): Update.
2024         (tui_clear_source_content): Remove "display_prompt" parameter.
2025         (tui_erase_source_content): Likewise.  Simplify.
2026         (tui_show_source_content): Update.
2027         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2028         * tui/tui-stack.c (tui_show_frame_info): Update.
2029         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2030         Remove defines.
2031
2032 2019-07-17  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2035         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2036         parameter.
2037         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2038         parameter.
2039
2040 2019-07-17  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-winsource.c (tui_clear_source_content)
2043         (tui_show_source_content, tui_show_exec_info_content)
2044         (tui_clear_exec_info_content): Update.
2045         * tui/tui-stack.c (tui_show_locator_content): Update.
2046         (tui_show_frame_info): Update.
2047         * tui/tui-source.h (tui_source_window): Don't declare.
2048         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2049         from tui_source_is_displayed.
2050         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2051         Remove field.
2052         (struct tui_source_window_base) <content_in_use>: New field.  Now
2053         bool.
2054         (struct tui_source_window) <showing_source_p>: New method.
2055         (TUI_SRC_WIN): Change cast.
2056         * tui/tui-data.c (tui_initialize_static_data): Update.
2057
2058 2019-07-17  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2061         location_matches_p.
2062         * tui/tui-source.c (tui_source_window::location_matches_p): New
2063         method.
2064         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2065         method.
2066         * tui/tui-data.h (struct tui_source_window_base)
2067         <location_matches_p>: New method.
2068         (struct tui_source_window, struct tui_disasm_window)
2069         <location_matches_p>: Likewise.
2070
2071 2019-07-17  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-win.c (tui_set_win_height_command): Rename from
2074         tui_set_win_height.
2075         (tui_set_win_height_command): Remove.
2076
2077 2019-07-17  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-source.c (tui_source_window): New constructor.  Add
2080         observer.
2081         (~tui_source_window): New destructor.
2082         (tui_source_window::style_changed): New method.
2083         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2084         (tui_attach_detach_observers): Update.
2085         * tui/tui-data.h (struct tui_source_window): Make constructor not
2086         inline.  Add destructor.
2087         (struct tui_source_window) <style_changed>: New method.
2088         <m_observable>: New member.
2089
2090 2019-07-17  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2093         * tui/tui-win.c (tui_resize_all): Fix typo.
2094
2095 2019-07-17  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2098         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2099         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2100         * tui/tui-win.c (window_name_completer): Use foreach.
2101         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2102         (update_tab_width): Likewise.
2103         * tui/tui-layout.c (show_layout): Update.
2104         * tui/tui-data.h (class tui_window_iterator): New.
2105         (struct all_tui_windows): New.
2106         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2107
2108 2019-07-17  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2111         parameter.  Don't reference globals.
2112         (tui_reg_command): Update.
2113
2114 2019-07-17  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-regs.c (tui_show_registers): Simplify.
2117
2118 2019-07-17  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-regs.c (tui_show_registers): Update.
2121         (tui_show_register_group): Add win_info parameter.
2122
2123 2019-07-17  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2126         Rename from tui_display_reg_element_at_line.
2127         (tui_data_window::display_registers_from_line): Update.
2128         * tui/tui-data.h (struct tui_data_window)
2129         <display_reg_element_at_line>: New method.
2130
2131 2019-07-17  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui-regs.h (tui_display_registers_from)
2134         (tui_display_registers_from_line): Don't declare.
2135         * tui/tui-windata.c (tui_data_window::display_all_data)
2136         (tui_data_window::refresh_all)
2137         (tui_data_window::do_scroll_vertical): Update.
2138         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2139         from tui_display_registers_from.
2140         (tui_display_reg_element_at_line): Update.
2141         (tui_data_window::display_registers_from_line): Rename from
2142         tui_display_registers_from_line.
2143         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2144         display_registers_from_line>: New methods.
2145
2146 2019-07-17  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2149         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2150         from tui_erase_data_content.
2151         (tui_data_window::display_all_data)
2152         (tui_data_window::refresh_all)
2153         (tui_data_window::do_scroll_vertical): Update.
2154         * tui/tui-regs.c (tui_show_registers): Update.
2155         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2156         New method.
2157
2158 2019-07-17  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2161         declare.
2162         * tui/tui-windata.c
2163         (tui_data_window::delete_data_content_windows): Rename from
2164         tui_delete_data_content_windows.
2165         (tui_data_window::display_all_data)
2166         (tui_data_window::do_scroll_vertical): Update.
2167         * tui/tui-data.h (struct tui_data_window)
2168         <delete_data_content_windows>: New method.
2169
2170 2019-07-17  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2173         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2174
2175 2019-07-17  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2178         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2179         from tui_display_all_data.
2180         * tui/tui-win.c
2181         (tui_data_window::do_make_visible_with_new_height): Update.
2182         * tui/tui-regs.c (tui_show_registers): Update.
2183         * tui/tui-layout.c (tui_set_layout): Update.
2184         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2185         method.
2186
2187 2019-07-17  Tom Tromey  <tom@tromey.com>
2188
2189         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2190         * tui/tui-windata.c (tui_display_data_from): Remove.
2191         (tui_data_window::refresh_all): Update.
2192
2193 2019-07-17  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2196         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2197         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2198         tui_display_registers_from_line.
2199         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2200         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2201         "force_display" parameter.
2202
2203 2019-07-17  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2206         declare.
2207         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2208         Rename from tui_first_reg_element_no_inline.
2209         (tui_display_reg_element_at_line)
2210         (tui_display_registers_from_line): Update.
2211         * tui/tui-data.h (struct tui_data_window)
2212         <first_reg_element_no_inline>: New method.
2213
2214 2019-07-17  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-windata.c (tui_display_data_from)
2217         (tui_data_window::do_scroll_vertical): Update.
2218         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2219         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2220         Rename from tui_line_from_reg_element_no.
2221         (tui_display_registers_from_line): Update.
2222         * tui/tui-data.h (struct tui_data_window)
2223         <line_from_reg_element_no>: New method.
2224
2225 2019-07-17  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2228         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2229         tui_last_regs_line_no.
2230         (tui_display_reg_element_at_line)
2231         (tui_display_registers_from_line): Update.
2232         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2233         method.
2234
2235 2019-07-17  Tom Tromey  <tom@tromey.com>
2236
2237         PR tui/24722:
2238         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2239         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2240         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2241         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2242         (tui_update_breakpoint_info): Likewise.
2243         * tui/tui-hooks.c (tui_event_create_breakpoint)
2244         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2245         Update.
2246
2247 2019-07-17  Tom Tromey  <tom@tromey.com>
2248
2249         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2250
2251 2019-07-17  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-winsource.c (tui_update_source_window_as_is)
2254         (tui_update_source_windows_with_addr): Update.
2255         * tui/tui-source.h (tui_set_source_content)
2256         (tui_show_symtab_source): Add "win_info" parameter.
2257         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2258         parameter.
2259         (tui_show_symtab_source): Likewise.
2260
2261 2019-07-17  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-wingeneral.c
2264         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2265
2266 2019-07-17  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2269         (struct tui_cmd_window) <can_scroll>: New method.
2270         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2271         method.
2272
2273 2019-07-17  Tom Tromey  <tromey@adacore.com>
2274
2275         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2276         do_field_signed>: Rename.  Change type of "value".
2277         * ui-out.c (ui_out::field_signed): Rename from field_int.
2278         Change type of "value".
2279         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2280         type of "value".
2281         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2282         do_field_int.  Change type of "value".
2283         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2284         do_field_int.  Change type of "value".
2285         * tracepoint.c (trace_status_mi, tfind_1)
2286         (print_one_static_tracepoint_marker): Update.
2287         * thread.c (print_thread_info_1, print_selected_thread_frame):
2288         Update.
2289         * stack.c (print_frame, print_frame_info): Update.
2290         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2291         Update.
2292         * source.c (print_source_lines_base): Update.
2293         * skip.c (info_skip_command): Update.
2294         * record-btrace.c (btrace_ui_out_decode_error)
2295         (btrace_call_history_src_line): Update.
2296         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2297         Update.
2298         * progspace.c (print_program_space): Update.
2299         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2300         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2301         do_field_int.  Change type of "value".
2302         * mi/mi-out.c (mi_ui_out::do_table_begin)
2303         (mi_ui_out::do_table_header): Update.
2304         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2305         type of "value".
2306         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2307         (mi_cmd_data_list_changed_registers, output_register)
2308         (mi_cmd_data_read_memory, mi_load_progress)
2309         (mi_cmd_trace_frame_collected): Update.
2310         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2311         Update.
2312         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2313         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2314         (mi_cmd_var_list_children, varobj_update_one): Update.
2315         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2316         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2317         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2318         * inferior.c (print_inferior): Update.
2319         * gdb_bfd.c (print_one_bfd): Update.
2320         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2321         Update.
2322         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2323         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2324         do_field_int.  Change type of "value".
2325         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2326         do_field_int.  Change type of "value".
2327         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2328         (print_one_breakpoint_location, print_it_catch_fork)
2329         (print_one_catch_fork, print_it_catch_vfork)
2330         (print_one_catch_vfork, print_it_catch_solib)
2331         (print_it_catch_exec, print_it_ranged_breakpoint)
2332         (print_mention_watchpoint, print_mention_masked_watchpoint)
2333         (bkpt_print_it, update_static_tracepoint): Update.
2334         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2335         * break-catch-syscall.c (print_it_catch_syscall): Update.
2336         * ada-tasks.c (print_ada_task_info): Update.
2337         * ada-lang.c (print_it_exception, print_mention_exception):
2338         Update.
2339
2340 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2341
2342         PR breakpoints/24541
2343         * gdbarch.c: Regenerate.
2344         * gdbarch.h: Regenerate.
2345         * gdbarch.sh: Adjust return type and parameter types for
2346         'stap_adjust_register'.
2347         (i386_stap_adjust_register): Adjust signature and return new
2348         register name.
2349         * stap-probe.c (stap_parse_register_operand): Adjust use of
2350         'gdbarch_stap_adjust_register'.
2351
2352 2019-07-17  Tom Tromey  <tromey@adacore.com>
2353
2354         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2355         declare VEC.
2356         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2357         std::vector.
2358         (struct s390_process_info): Add initializers.
2359         (s390_add_process): Use new.
2360         (s390_linux_nat_target::low_forget_process): Use delete.
2361         (s390_linux_nat_target::low_new_fork)
2362         (s390_linux_nat_target::stopped_by_watchpoint)
2363         (s390_linux_nat_target::low_prepare_to_resume)
2364         (s390_linux_nat_target::insert_watchpoint)
2365         (s390_linux_nat_target::insert_hw_breakpoint)
2366         (s390_linux_nat_target::remove_watchpoint)
2367         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2368
2369 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2370
2371         * aarch64-fbsd-nat.c: Include regcache.h.
2372         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2373         argument.
2374         (aarch64_fbsd_nat_target::fetch_registers)
2375         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2376         variable.
2377         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2378
2379 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2380
2381         * fbsd-nat.c: Include gdbarch.h.
2382
2383 2019-07-15  Tom Tromey  <tromey@adacore.com>
2384
2385         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2386
2387 2019-07-15  Tom Tromey  <tromey@adacore.com>
2388
2389         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2390         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2391         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2392         * cli-out.c (cli_ui_out::do_field_int): New method.
2393         * ui-out.c (ui_out::field_unsigned): New method.
2394         * symfile.c (generic_load): Use field_unsigned.
2395         (print_transfer_performance): Likewise.
2396         * record-btrace.c (ui_out_field_uint): Remove.
2397         (btrace_call_history_insn_range, btrace_call_history): Use
2398         field_unsigned.
2399         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2400         field_unsigned.
2401         * ui-out.h (class ui_out) <field_unsigned>: New method.
2402         <do_field_unsigned>: Likewise.
2403
2404 2019-07-15  Tom Tromey  <tromey@adacore.com>
2405
2406         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2407         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2408         * target.c (flash_erase_command): Use field_string.
2409         * infrun.c (print_signal_received_reason): Use field_string.
2410         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2411         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2412         field_string.
2413         * ada-tasks.c (print_ada_task_info): Use field_string.
2414
2415 2019-07-15  Tom Tromey  <tromey@adacore.com>
2416
2417         * target.c (flash_erase_command): Use field_core_addr.
2418         * symfile.c (generic_load): Use field_core_addr.
2419         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2420         Use field_core_addr.
2421         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2422         field_core_addr.
2423
2424 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2425
2426         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2427         value if its desired type is smaller than a CORE_ADDR and signed.
2428
2429 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2430
2431         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2432         of changes to field names, and use new is_reference field to
2433         decide if a property is a reference or not.
2434         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2435         field.
2436         (struct dwarf2_property_baton): Update header comment, rename
2437         'referenced_type' to 'property_type' and update comments.
2438         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2439         default property type, store in property baton, update to take
2440         accound of renamed field.
2441         (read_func_scope): Update call to attr_to_dynamic_prop.
2442         (read_array_type): Likewise.
2443         (dwarf2_per_cu_addr_sized_int_type): New function.
2444         (read_subrange_index_type): Move type finding code to
2445         dwarf2_per_cu_addr_sized_int_type.
2446         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2447         (dwarf2_per_cu_addr_type): New function.
2448         (set_die_type): Update calls to attr_to_dynamic_prop.
2449
2450 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         * dwarf2read.c (read_subrange_index_type): New function.
2453         (read_subrange_type): Move code into new function and call it.
2454         * gdbtypes.c (create_range_type): Add some asserts.
2455
2456 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2457
2458         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2459         update return statements.
2460         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2461         declaration, and update comment to match.
2462         * gdbtypes.c (resolve_dynamic_array): Update call to
2463         dwarf2_evaluate_property to match new return type.
2464
2465 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * valarith.c (value_subscripted_rvalue): Change lowerbound
2468         parameter type from int to LONGEST.
2469         * value.h (value_subscripted_rvalue): Likewise in declaration.
2470
2471 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2472
2473         * cli/cli-utils.c (info_print_command_completer): New function.
2474         * cli/cli-utils.h: Add 'completer.h' include, and forward
2475         declaration for 'struct cmd_list_element'.
2476         (info_print_command_completer): Declare.
2477         * stack.c (_initialize_stack): Add completer for 'info locals' and
2478         'info args'.
2479         * symtab.c (_initialize_symtab): Add completer for 'info
2480         variables' and 'info functions'.
2481         * NEWS: Mention completion for additional info commands.
2482
2483 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2484
2485         * cli/cli-utils.c (extract_info_print_args): Delete.
2486         (extract_arg_maybe_quoted): Delete.
2487         (info_print_options_defs): New variable.
2488         (make_info_print_options_def_group): New function.
2489         (extract_info_print_options): Define new function.
2490         * cli/cli-utils.h (extract_info_print_args): Delete.
2491         (struct info_print_options): New structure.
2492         (extract_info_print_options): Declare new function.
2493         * stack.c (info_locals_command): Update to use new
2494         extract_info_print_options, also add a header comment.
2495         (info_args_command): Likewise.
2496         * symtab.c (info_variables_command): Likewise.
2497         (info_functions_command): Likewise.
2498
2499 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2500
2501         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2502         to extract string arguments.
2503         * common/common-utils.c (extract_string_maybe_quoted): New function.
2504         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2505
2506 2019-07-11  Tom Tromey  <tromey@adacore.com>
2507
2508         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2509         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2510         * top.h (gdbinit): Don't declare.
2511         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2512         into...
2513         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2514         * top.c (gdb_init): Don't call init_cli_cmds.
2515         (gdbinit): Remove.
2516         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2517
2518 2019-07-11  Tom Tromey  <tromey@adacore.com>
2519
2520         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2521         after it has been moved.
2522
2523 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2524
2525         * valops.c (value_must_coerce_to_target): Change return type to
2526         bool.
2527         * value.h (value_must_coerce_to_target): Likewise.
2528
2529 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2530
2531         * breakpoint.c (is_hardware_watchpoint): Remove
2532         forward-declaration.
2533         (is_masked_watchpoint): Change return type to bool.
2534         (is_tracepoint): Likewise.
2535         (is_breakpoint): Likewise.
2536         (is_hardware_watchpoint): Likewise.
2537         (is_watchpoint): Likewise.
2538         (is_no_memory_software_watchpoint): Likewise.
2539         (is_catchpoint): Likewise.
2540         (breakpoint_1): Make FILTER parameter's return type bool.
2541         is_masked_watchpoint): Change return type to bool.
2542         (save_breakpoints): Make FILTER parameter's return type bool.
2543         * breakpoint.h (is_breakpoint): Change return type to bool.
2544         (is_watchpoint): Likewise.
2545         (is_catchpoint): Likewise.
2546         (is_tracepoint): Likewise.
2547
2548 2019-07-10  Tom Tromey  <tom@tromey.com>
2549
2550         * defs.h: Don't include gdbarch.h.
2551         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2552         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2553         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2554         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2555         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2556         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2557         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2558         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2559         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2560         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2561         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2562         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2563         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2564         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2565         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2566         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2567         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2568         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2569         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2570         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2571         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2572         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2573         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2574         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2575         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2576         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2577         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2578
2579 2019-07-10  Tom Tromey  <tromey@adacore.com>
2580
2581         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2582         * breakpoint.c (init_ada_exception_breakpoint): Register as
2583         bp_catchpoint.
2584         (print_one_breakpoint_location, print_one_breakpoint): Use
2585         is_ada_exception_catchpoint.
2586         * ada-lang.c (class ada_catchpoint_location): Pass
2587         bp_loc_software_breakpoint to bp_location constructor.
2588         (is_ada_exception_catchpoint): New function.
2589
2590 2019-07-10  Tom Tromey  <tromey@adacore.com>
2591
2592         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2593         VEC.
2594         (struct arm_exidx_entry): New method operator<.
2595         (struct arm_exidx_data) <section_maps>: Change type.
2596         (arm_exidx_data_free): Remove.
2597         (arm_exidx_data_key): Change type.  Move lower.
2598         (arm_exidx_new_objfile): Update.
2599         (arm_compare_exidx_entries): Remove.
2600         (arm_find_exidx_entry, _initialize_arm_tdep)
2601
2602 2019-07-10  Tom Tromey  <tromey@adacore.com>
2603
2604         * solib-spu.c (ocl_program_data_key): Change type.
2605         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2606         Update.
2607
2608 2019-07-10  Tom Tromey  <tromey@adacore.com>
2609
2610         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2611         (struct solib_aix_inferior_data) <library_list>: Change type.
2612         (solib_aix_inferior_data_handle): Change type.
2613         (get_solib_aix_inferior_data): Update.
2614         (solib_aix_free_library_list): Remove.
2615         (library_list_start_library): Update.
2616         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2617         return type.
2618         (solib_aix_get_library_list)
2619         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2620         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2621
2622 2019-07-10  Tom Tromey  <tromey@adacore.com>
2623
2624         * solib-dsbt.c (struct dsbt_info): Add initializers.
2625         (solib_dsbt_pspace_data): Change type.
2626         (dsbt_pspace_data_cleanup): Remove.
2627         (get_dsbt_info, _initialize_dsbt_solib): Update.
2628
2629 2019-07-10  Tom Tromey  <tromey@adacore.com>
2630
2631         * spu-tdep.c (spu_overlay_data): Change type.
2632         (spu_get_overlay_table, spu_overlay_new_objfile)
2633         (_initialize_spu_tdep): Update.
2634
2635 2019-07-10  Tom Tromey  <tromey@adacore.com>
2636
2637         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2638         destructor.
2639         (dbx_objfile_data_key): Change type and declare later.
2640         (DBX_SYMFILE_INFO): Rewrite.
2641         * dbxread.c (dbx_objfile_data_key): Change type.
2642         (dbx_symfile_init): Update.
2643         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2644         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2645         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2646
2647 2019-07-10  Tom Tromey  <tromey@adacore.com>
2648
2649         * jit.c (jit_program_space_key): Change type.  Move lower.
2650         (get_jit_program_space_data): Update.
2651         (jit_program_space_data_cleanup): Remove.
2652         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2653         Update.
2654         (struct jit_program_space_data): Add initializers.
2655
2656 2019-07-10  Tom Tromey  <tromey@adacore.com>
2657
2658         * solib-darwin.c (struct darwin_info): Add initializers.
2659         (solib_darwin_pspace_data): Change type.
2660         (darwin_pspace_data_cleanup): Remove.
2661         (get_darwin_info, _initialize_darwin_solib): Update.
2662
2663 2019-07-10  Tom Tromey  <tromey@adacore.com>
2664
2665         * remote-sim.c (struct sim_inferior_data): Add initializers,
2666         constructor, and destructor.
2667         (sim_inferior_data_key): Change type.  Move lower.
2668         (check_for_duplicate_sim_descriptor): Update.
2669         (get_sim_inferior_data): Use new.  Update.
2670         (~sim_inferior_data_cleanup): Rename from
2671         sim_inferior_data_cleanup.  Simplify.
2672         (gdbsim_close_inferior, simulator_command)
2673         (sim_command_completer, _initialize_remote_sim): Update.
2674         (next_pid, INITIAL_PID): Move earlier.
2675
2676 2019-07-10  Tom Tromey  <tromey@adacore.com>
2677
2678         * python/python-internal.h (create_thread_object): Return
2679         gdbpy_ref.
2680         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2681         * python/py-inferior.c (struct threadlist_entry): Add
2682         constructor.
2683         <thread_obj>: Now a gdbpy_ref.
2684         (thread_to_thread_object): Update.
2685         (add_thread_object): Use new.
2686         (delete_thread_object): Use delete.
2687         (infpy_threads): Update.
2688         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2689         GIL.
2690
2691 2019-07-10  Tom Tromey  <tromey@adacore.com>
2692
2693         * valops.c (value_cast): Specialize error message for Ada.
2694
2695 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2696
2697         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2698
2699 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2700
2701         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2702         bpstat_should_step): Return bool, adjust comments.
2703         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2704         bpstat_should_step): Likewise.
2705
2706 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2707
2708         * features/Makefile: Use feature target descriptions for Arm.
2709         * features/arm/arm-core.c: Generate new file.
2710         * features/arm/arm-fpa.c: Likewise.
2711         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2712         * features/arm/arm-m-profile.c: Likewise.
2713         * features/arm/arm-vfpv2.c: Likewise.
2714         * features/arm/arm-vfpv3.c: Likewise.
2715         * features/arm/xscale-iwmmxt.c: Likewise.
2716         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2717
2718 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2719
2720         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2721         ptrace earlier.
2722
2723 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2724
2725         * features/aarch64-pauth.c: Regenerate.
2726
2727 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2728
2729         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2730         bool.
2731         (bpstat_what): Use false instead of 0.
2732
2733 2019-07-09  Pedro Alves  <palves@redhat.com>
2734
2735         * break-catch-throw.c (is_exception_catchpoint): New.
2736         * breakpoint.c (print_one_breakpoint_location): New parameter
2737         'raw_loc'.  Handle it.  Use
2738         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2739         looking at the breakpoint's type.
2740         (print_one_breakpoint): If handling "maint info breakpoints", also
2741         print locations of exception catchpoints.
2742         * breakpoint.h (is_exception_catchpoint): Declare.
2743
2744 2019-07-09  Pedro Alves  <palves@redhat.com>
2745
2746         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2747         "addr" field.
2748         (allocate_location_exception_catchpoint): New.
2749         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2750         (initialize_throw_catchpoint_ops): Install
2751         allocate_location_exception_catchpoint as allocate_location
2752         method.
2753         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2754         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2755         bp_loc_other.
2756         (breakpoint_address_is_meaningful): Delete.
2757         (bl_address_is_meaningful): New.
2758         (breakpoint_locations_match): Adjust comment.
2759         (bp_location_from_bp_type): New, factored out of...
2760         (bp_location::bp_location(breakpoint *)): ... this.
2761         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2762         factored out of...
2763         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2764         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2765         breakpoint_address_is_meaningful.
2766         (bp_locations_compare): Adjust comment.
2767         (update_global_location_list): Use bl_address_is_meaningful
2768         instead of breakpoint_address_is_meaningful.
2769         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2770         explicit.
2771         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2772         * python/py-breakpoint.c (bppy_get_location): No longer check
2773         whether location is null.
2774
2775 2019-07-09  Pedro Alves  <palves@redhat.com>
2776
2777         PR c++/15468
2778         * breakpoint.c (print_one_breakpoint_location): Remove
2779         single-location assert.
2780
2781 2019-07-09  Tom Tromey  <tom@tromey.com>
2782
2783         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2784         * configure: Rebuild.
2785         * configure.ac: Change common to gdbsupport.
2786         * gdbsupport: Rename from common.
2787         * acinclude.m4: Change common to gdbsupport.
2788         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2789         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2790         gdbsupport.
2791         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2792         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2793         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2794         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2795         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2796         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2797         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2798         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2799         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2800         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2801         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2802         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2803         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2804         coff-pe-read.c, command.h, compile/compile-c-support.c,
2805         compile/compile-c.h, compile/compile-cplus-symbols.c,
2806         compile/compile-cplus-types.c, compile/compile-cplus.h,
2807         compile/compile-loc2c.c, compile/compile.c, completer.c,
2808         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2809         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2810         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2811         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2812         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2813         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2814         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2815         features/aarch64-core.c, features/aarch64-fpu.c,
2816         features/aarch64-pauth.c, features/aarch64-sve.c,
2817         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2818         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2819         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2820         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2821         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2822         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2823         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2824         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2825         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2826         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2827         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2828         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2829         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2830         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2831         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2832         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2833         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2834         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2835         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2836         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2837         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2838         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2839         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2840         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2841         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2842         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2843         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2844         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2845         minsyms.c, mips-linux-tdep.c, namespace.h,
2846         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2847         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2848         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2849         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2850         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2851         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2852         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2853         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2854         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2855         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2856         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2857         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2858         procfs.c, producer.c, progspace.h, psymtab.h,
2859         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2860         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2861         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2862         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2863         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2864         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2865         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2866         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2867         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2868         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2869         target-memory.c, target.c, target.h, target/waitstatus.c,
2870         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2871         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2872         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2873         unittests/array-view-selftests.c,
2874         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2875         unittests/common-utils-selftests.c,
2876         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2877         unittests/format_pieces-selftests.c,
2878         unittests/function-view-selftests.c,
2879         unittests/lookup_name_info-selftests.c,
2880         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2881         unittests/mkdir-recursive-selftests.c,
2882         unittests/observable-selftests.c,
2883         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2884         unittests/parse-connection-spec-selftests.c,
2885         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2886         unittests/scoped_fd-selftests.c,
2887         unittests/scoped_mmap-selftests.c,
2888         unittests/scoped_restore-selftests.c,
2889         unittests/string_view-selftests.c, unittests/style-selftests.c,
2890         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2891         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2892         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2893         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2894         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2895         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2896
2897 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2898
2899         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2900         bool value.
2901         (decode_digits_ordinary): Set explicit_line field in sal.
2902         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2903         symtab_and_line that was set on an explicit line number in
2904         assembler code.  Do always update the recorded symtab and line if
2905         we do skip the prologue.
2906
2907 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2908
2909         * breakpoint.c (set_breakpoint_location_function): Remove
2910         explicit_loc parameter.
2911         (momentary_breakpoint_from_master): Update call to
2912         set_breakpoint_location_function.
2913         (add_location_to_breakpoint): Likewise.
2914
2915 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2916
2917         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2918         required features based on default bfd type when no specific bfd
2919         is present.
2920
2921 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2922
2923         * NEWS: Mention that GDB printf and eval commands can now print
2924         C-style and Ada-style convenience var strings without
2925         calling the inferior.
2926         * printcmd.c (printf_c_string): Locally print GDB internal var
2927         instead of transiting via the inferior.
2928         (printf_wide_c_string): Likewise.
2929
2930 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2931
2932         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2933
2934 2019-07-04  Tom Tromey  <tom@tromey.com>
2935
2936         PR tui/24724:
2937         * tui/tui-winsource.c (tui_clear_source_content): Update.
2938         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2939         (tui_update_breakpoint_info): Update.
2940         (tui_set_exec_info_content): Update.
2941         * tui/tui-source.c (tui_set_source_content_nil): Update.
2942         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2943         has_break.
2944         * tui/tui-data.h (enum tui_bp_flag): New.
2945         (tui_bp_flags): New enum flags type.
2946         (struct tui_source_element) <break_mode>: Change type.  Rename
2947         from has_break.
2948         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2949         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2950         constants.
2951         * tui/tui-winsource.h: Fix comment.
2952
2953 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2954
2955         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2956         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2957         (store_fpregs_to_thread)
2958         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2959         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2960         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2961         (IWMMXT_REGS_SIZE): Add define.
2962         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2963         (fetch_vfp_regs, store_vfp_regs)
2964         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2965         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2966
2967 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2968
2969         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2970         defines.
2971         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2972         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2973         (ARM_INT_REGISTER_SIZE): ...to this.
2974         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2975         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2976         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2977         (arm_linux_collect_gregset, supply_nwfpe_register)
2978         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2979         defines.
2980         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2981         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2982         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2983         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2984         (arm_return_in_memory, arm_store_return_value)
2985         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2986         (arm_record_ld_st_multiple): Likewise.
2987         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2988         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2989
2990 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2991
2992         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2993         AARCH64_DISPLACED_MODIFIED_INSNS.
2994         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2995         (aarch64_displaced_step_copy_insn): Likewise.
2996         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2997         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2998         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2999         ARM_DISPLACED_MODIFIED_INSNS.
3000         * arm-tdep.c (arm_gdbarch_init): Likewise.
3001         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3002         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3003         (struct arm_displaced_step_closure): Use
3004         ARM_DISPLACED_MODIFIED_INSNS.
3005
3006 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3007
3008         * features/Makefile: Remove unused xml files.
3009         * features/aarch64.xml: Remove.
3010         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3011         * features/i386/amd64-avx-avx512.xml: Remove.
3012         * features/i386/amd64-avx-linux.xml: Remove.
3013         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3014         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3015         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3016         * features/i386/amd64-avx-mpx.xml: Remove.
3017         * features/i386/amd64-avx.xml: Remove.
3018         * features/i386/amd64-linux.xml: Remove.
3019         * features/i386/amd64-mpx-linux.xml: Remove.
3020         * features/i386/amd64-mpx.xml: Remove.
3021         * features/i386/amd64.xml: Remove.
3022         * features/i386/i386-avx-avx512-linux.xml: Remove.
3023         * features/i386/i386-avx-avx512.xml: Remove.
3024         * features/i386/i386-avx-linux.xml: Remove.
3025         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3026         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3027         * features/i386/i386-avx-mpx-linux.xml: Remove.
3028         * features/i386/i386-avx-mpx.xml: Remove.
3029         * features/i386/i386-avx.xml: Remove.
3030         * features/i386/i386-linux.xml: Remove.
3031         * features/i386/i386-mmx-linux.xml: Remove.
3032         * features/i386/i386-mmx.xml: Remove.
3033         * features/i386/i386-mpx-linux.xml: Remove.
3034         * features/i386/i386-mpx.xml: Remove.
3035         * features/i386/i386.xml: Remove.
3036         * features/i386/x32-avx-avx512-linux.xml: Remove.
3037         * features/i386/x32-avx-linux.xml: Remove.
3038         * features/i386/x32-linux.xml: Remove.
3039
3040 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3041
3042         * regformats/aarch64.dat: Remove.
3043         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3044         * regformats/i386/amd64-avx-linux.dat: Remove.
3045         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3046         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3047         * regformats/i386/amd64-linux.dat: Remove.
3048         * regformats/i386/amd64-mpx-linux.dat: Remove.
3049         * regformats/i386/amd64.dat: Remove.
3050         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3051         * regformats/i386/i386-avx-linux.dat: Remove.
3052         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3053         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3054         * regformats/i386/i386-linux.dat: Remove.
3055         * regformats/i386/i386-mmx-linux.dat: Remove.
3056         * regformats/i386/i386-mpx-linux.dat: Remove.
3057         * regformats/i386/i386.dat: Remove.
3058         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3059         * regformats/i386/x32-avx-linux.dat: Remove.
3060         * regformats/i386/x32-linux.dat: Remove.
3061
3062 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3063
3064         * aarch64-tdep.c: Remove xml self tests.
3065         * amd64-linux-tdep.c: Likewise.
3066         * amd64-tdep.c: Likewise.
3067         * i386-linux-tdep.c: Likewise.
3068         * i386-tdep.c: Likewise.
3069
3070 2019-07-03  Pedro Alves  <palves@redhat.com>
3071
3072         PR cli/24732
3073         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3074         (pipe_cmd_option_defs): New.
3075         (make_pipe_cmd_options_def_group): New.
3076         (pipe_command): Use gdb::option::process_options.
3077         (pipe_command_completer): New function.
3078         (_initialize_cli_cmds): Install completer for "pipe" command.
3079
3080 2019-07-03  Pedro Alves  <palves@redhat.com>
3081
3082         * cli/cli-option.c (union option_value) <string>: New field.
3083         (struct option_def_and_value): Add ctor, move ctor, dtor and
3084         use DISABLE_COPY_AND_ASSIGN.
3085         (option_def_and_value::clear_value): New.
3086         (parse_option, save_option_value_in_ctx, get_val_type_str)
3087         (add_setshow_cmds_for_options): Handle var_string.
3088         * cli-option.h (union option_def::var_address) <string>: New
3089         field.
3090         (struct string_option_def): New.
3091         * maint-test-options.c (struct test_options_opts): Add default
3092         ctor and use DISABLE_COPY_AND_ASSIGN.
3093         <string_opt>: New field.
3094         (test_options_opts::~test_options_opts): New.
3095         (test_options_opts::dump): Also dump "-string".
3096         (test_options_option_defs): Install "string.
3097
3098 2019-07-03  Pedro Alves  <palves@redhat.com>
3099
3100         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3101         option_value with a null enumeration.
3102         (complete_options): Save the option values in the context.
3103         (save_option_value_in_ctx): New, factored out from ...
3104         (process_options): ... here.
3105         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3106         of the function.
3107         * maint-test-options.c (test_options_opts::dump): New, factored
3108         out from ...
3109         (maintenance_test_options_command_mode): ... here.
3110         (maintenance_test_options_command_completion_result): Delete.
3111         (maintenance_test_options_command_completion_text): Update
3112         comment.
3113         (maintenance_show_test_options_completion_result): Change
3114         prototype.  Just print
3115         maintenance_test_options_command_completion_text.
3116         (save_completion_result): New.
3117         (maintenance_test_options_completer_mode): Pass options context to
3118         complete_options, and then save a dump.
3119         (_initialize_maint_test_options): Use add_cmd to install "maint
3120         show test-options-completion-result".
3121
3122 2019-07-03  Pedro Alves  <palves@redhat.com>
3123
3124         * NEWS (New commands): Mention "with" and "maint with".
3125         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3126         (with_command, with_command_completer): New.
3127         (pipe_command): Adjust to new repeat_previous
3128         interface.
3129         (_initialize_cli_cmds): Install the "with" command and its "w"
3130         alias.
3131         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3132         declarations.
3133         * cli/cli-setshow.c (parse_cli_var_uinteger)
3134         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3135         argument strings for all var_types.
3136         (get_setshow_command_value_string): New, factored out from ...
3137         (do_show_command): ... this.
3138         * cli/cli-setshow.h: Include <string>.
3139         (get_setshow_command_value_string): Declare.
3140         * command.h (repeat_previous): Now returns const char *.  Adjust
3141         comment.
3142         * maint.c: Include "cli/cli-cmds.h".
3143         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3144         (_initialize_maint_cmds): Register the "maintenance with" command.
3145         * top.c (repeat_previous): Move bits from pipe_command here:
3146         Return the saved command line, if any; error out if there's no
3147         command to relaunch.
3148
3149 2019-07-03  Pedro Alves  <palves@redhat.com>
3150
3151         * NEWS (New commands): Mention "maint set/show test-settings"
3152         instead of "maint test-settings".
3153         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3154         (maintenance_test_settings_set_list): Rename to ...
3155         (maintenance_set_test_settings_list): ... this.
3156         (maintenance_test_settings_show_list): Rename to  ...
3157         (maintenance_show_test_settings_list): ... this.
3158         (maintenance_test_settings_cmd): Delete.
3159         (maintenance_test_settings_set_cmd): ...
3160         (maintenance_set_test_settings_cmd): ... this.
3161         (maintenance_test_settings_show_cmd): ...
3162         (maintenance_show_test_settings_cmd): ... this.
3163         (maintenance_test_settings_show_value_cmd):
3164         (maintenance_show_test_settings_value_cmd): ... this.
3165         (_initialize_maint_test_settings): No longer install the "maint
3166         test-settings" prefix command.  Rename "maint test-settings set"
3167         to "maint set test-settings", and "maint test-settings show" to
3168         "maint show test-settings".  Adjust all subcommands.
3169
3170 2019-07-03  Pedro Alves  <palves@redhat.com>
3171
3172         * maint-test-settings.c: Fix file's intro comment.  Replace all
3173         references to "test-options" with references to "test-settings",
3174         in comments.
3175
3176 2019-07-03  Pedro Alves  <palves@redhat.com>
3177
3178         * maint-test-settings.c (maintenance_test_settings_xxx)
3179         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3180         New.
3181         (maintenance_test_settings_enums): Use them.
3182         (maintenance_test_settings_enum): Default to
3183         maintenance_test_settings_xxx.
3184         (_initialize_maint_test_settings): Initialize
3185         MAINTENANCE_TEST_SETTINGS_FILENAME.
3186
3187 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3188
3189         * breakpoint.h (remove_breakpoints_inf): Change return type to
3190         void, move function documentation here.
3191         * breakpoint.c (remove_breakpoints_inf): Change return type to
3192         void, move function documentation to header.
3193
3194 2019-07-02  Pedro Alves  <palves@redhat.com>
3195
3196         * NEWS (Completion improvements): Mention "info threads".
3197         * thread.c (struct info_threads_opts, info_threads_option_defs)
3198         (make_info_threads_options_def_group): New.
3199         (info_threads_command): Use gdb::option::process_options.
3200         (info_threads_command_completer): New.
3201         (_initialize_thread): Use gdb::option::build_help to build the
3202         help text for "info threads".
3203
3204 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3205
3206         * defs.h (generic_load): Move from here...
3207         * symfile.h (generic_load): ... to here.  Rename name parameter
3208         to args.
3209         * symfile.c (generic_load): Add comment.
3210
3211 2019-07-01  Tom Tromey  <tromey@adacore.com>
3212
3213         * dwarf2read.c
3214         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3215         declaration of without_params.  Fix formatting.
3216
3217 2019-07-01  Tom Tromey  <tromey@adacore.com>
3218
3219         * ada-exp.y (find_primitive_type): Update.
3220         * ada-lang.h (ada_lookup_symbol): Update.
3221         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3222         parameter.
3223         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3224
3225 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3226
3227         PR breakpoints/24541
3228         * gdbarch.c: Regenerate.
3229         * gdbarch.h: Regenerate.
3230         * gdbarch.sh: Add 'stap_adjust_register'.
3231         * i386-tdep.c: Include '<unordered_set>'.
3232         (i386_stap_adjust_register): New function.
3233         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3234         * stap-probe.c (stap_parse_register_operand): Call
3235         'gdbarch_stap_adjust_register'.
3236
3237 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3238
3239         PR python/24742
3240         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3241         * python/python.c (do_start_initialization): Use 'xmalloc'
3242         instead of 'PyMem_Malloc'.
3243
3244 2019-06-28  Tom Tromey  <tromey@adacore.com>
3245
3246         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3247         for Ada.
3248
3249 2019-06-27  Tom Tromey  <tromey@adacore.com>
3250
3251         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3252         objfile_key.
3253         (arm_find_mapping_symbol, arm_record_special_symbol)
3254         (_initialize_arm_tdep): Update.
3255         (arm_objfile_data_free): Remove.
3256
3257 2019-06-27  Tom Tromey  <tromey@adacore.com>
3258
3259         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3260         to cp_print_static_field.
3261
3262 2019-06-26  Tom Tromey  <tromey@adacore.com>
3263
3264         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3265         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3266         declare.
3267
3268 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3269
3270         * features/aarch64-core.c (create_feature_aarch64_core):
3271         Regenerate.
3272         * features/aarch64-core.xml: Add cpsr flags.
3273
3274 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3275
3276         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3277         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3278
3279 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3280
3281         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3282         field.
3283         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3284         use.
3285         (arm_record_special_symbol): Don't insert new symbol in sorted
3286         position, push it at the end.
3287
3288 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3289
3290         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3291         (arm_mapping_symbol_s): Remove.
3292         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3293         (arm_mapping_symbol_vec): New typedef.
3294         (struct arm_per_objfile): Add constructor.
3295         <section_maps>: Change type to
3296         std::unique_ptr<arm_mapping_symbol_vec[]>.
3297         (arm_compare_mapping_symbols): Remove.
3298         (arm_find_mapping_symbol): Adjust to section_maps type change.
3299         (arm_objfile_data_free): Call delete on arm_per_objfile.
3300         (arm_record_special_symbol): Adjust to section_maps type change.
3301         Allocate arm_per_objfile with new.
3302
3303 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3304
3305         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3306         with the command prefix.
3307
3308 2019-06-25  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3311         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3312
3313 2019-06-25  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3316         type.
3317         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3318         protected.
3319
3320 2019-06-25  Tom Tromey  <tom@tromey.com>
3321
3322         * tui/tui-winsource.c
3323         (tui_source_window_base::set_is_exec_point_at): Add check against
3324         LOA_ADDRESS.
3325
3326 2019-06-25  Tom Tromey  <tom@tromey.com>
3327
3328         * tui/tui-source.c (tui_set_source_content): Don't check before
3329         xfree.
3330         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3331
3332 2019-06-25  Tom Tromey  <tom@tromey.com>
3333
3334         * tui/tui-winsource.h (tui_update_source_window_as_is)
3335         (tui_alloc_source_buffer, tui_line_is_displayed)
3336         (tui_addr_is_displayed): Change type of win_info.
3337         * tui/tui-winsource.c (tui_update_source_window_as_is)
3338         (tui_clear_source_content, tui_show_source_line)
3339         (tui_show_source_content, tui_source_window_base::refill)
3340         (tui_source_window_base::set_is_exec_point_at)
3341         (tui_source_window_base::set_is_exec_point_at)
3342         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3343         (tui_alloc_source_buffer, tui_line_is_displayed)
3344         (tui_addr_is_displayed): Change type of win_info.  Update.
3345         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3346         (tui_source_window_base::do_make_visible_with_new_height):
3347         Update.
3348         * tui/tui-source.c (tui_set_source_content)
3349         (tui_set_source_content_nil)
3350         (tui_source_window::do_scroll_vertical): Update.
3351         * tui/tui-layout.c (show_layout): Update.
3352         * tui/tui-disasm.c (tui_set_disassem_content)
3353         (tui_disasm_window::do_scroll_vertical): Update.
3354         * tui/tui-data.h (tui_win_content): Remove.
3355         (struct tui_gen_win_info) <content, content_size>: Remove.
3356         (struct tui_source_element): Add initializers and destructor.
3357         (union tui_which_element, struct tui_win_element): Remove.
3358         (struct tui_source_window_base) <content>: New field.
3359         (struct tui_data_window): Remove destructor.
3360         (tui_alloc_content, tui_free_win_content)
3361         (tui_free_all_source_wins_content): Don't declare.
3362         * tui/tui-data.c (tui_initialize_static_data): Update.
3363         (init_content_element, tui_alloc_content): Remove.
3364         (~tui_gen_win_info): Update.
3365         (~tui_data_window, tui_free_all_source_wins_content)
3366         (tui_free_win_content, free_content, free_content_elements):
3367         Remove.
3368
3369 2019-06-25  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-winsource.h (tui_clear_source_content)
3372         (tui_erase_source_content, tui_show_source_content): Change type
3373         of win_info.
3374         * tui/tui-winsource.c (tui_clear_source_content)
3375         (tui_erase_source_content, tui_show_source_content): Change type
3376         of win_info.
3377         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3378         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3379         win_info.
3380         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3381         win_info.
3382         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3383
3384 2019-06-25  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-winsource.c (tui_clear_source_content)
3387         (tui_source_window_base::set_is_exec_point_at): Update.
3388         * tui/tui-source.c (tui_set_source_content_nil): Update.
3389         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3390         a bool.
3391         * tui/tui-data.c (init_content_element): Update.
3392
3393 2019-06-25  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3396         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3397         * tui/tui-layout.c (init_and_make_win): Update.
3398         * tui/tui.h (enum tui_win_type): Update.
3399         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3400         tui_win_is_auxillary.
3401         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3402         tui_win_is_auxillary.
3403
3404 2019-06-25  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3407         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3408         (tui_delete_data_content_windows, tui_display_all_data)
3409         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3410         Update.
3411         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3412         * tui/tui-regs.c (tui_last_regs_line_no)
3413         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3414         (tui_show_registers): Update.
3415         (tui_show_register_group): Return void.  Update.
3416         (tui_display_registers_from, tui_display_reg_element_at_line)
3417         (tui_display_registers_from_line, tui_check_register_values):
3418         Update.
3419         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3420         member.
3421         (struct tui_data_window) <regs_content>: Now a std::vector.
3422         <regs_content_count>: Remove.
3423         (tui_add_content_elements, tui_free_data_content): Don't declare.
3424         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3425         (init_content_element): Remove DATA_WIN case.  Add assert.
3426         (tui_add_content_elements): Remove.
3427         (tui_data_window): Update.
3428         (tui_free_data_content): Remove.
3429         (free_content_elements): Remove DATA_WIN case.
3430
3431 2019-06-25  Tom Tromey  <tom@tromey.com>
3432
3433         * tui/tui-data.c (tui_data_item_window): Update.
3434         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3435         * tui/tui-windata.c (tui_display_all_data)
3436         (tui_display_data_from_line): Update.
3437         (tui_check_data_values): Remove.
3438         * tui/tui-regs.c (tui_show_register_group)
3439         (tui_display_reg_element_at_line): Update.
3440         * tui/tui-hooks.c (tui_register_changed)
3441         (tui_refresh_frame_and_register_information): Call
3442         tui_check_register_values.
3443         * tui/tui-data.h (struct tui_data_window) <data_content,
3444         data_content_count, data_type>: Remove.
3445         (enum tui_data_type): Remove.
3446
3447         * tui/tui-data.c (tui_data_window::clear_detail)
3448         (~tui_data_window): Update.
3449
3450 2019-06-25  Tom Tromey  <tom@tromey.com>
3451
3452         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3453         declare.
3454         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3455         Rename from tui_first_data_item_displayed.  Update.
3456         (tui_data_window::refresh_all)
3457         (tui_data_window::do_scroll_vertical): Update.
3458         * tui/tui-data.h (struct tui_data_window)
3459         <first_data_item_displayed>: Declare new method.
3460
3461 2019-06-25  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3464         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3465         contents...
3466         (tui_initialize_static_data): ...here.
3467
3468 2019-06-25  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3471         (tui_display_registers_from, tui_check_register_values): Update.
3472         (tui_display_register): Remove win_info parameter; update.
3473         (tui_get_register): Change type of parameters.
3474         * tui/tui-data.h (struct tui_data_element): Remove.
3475         (union tui_which_element) <data>: Remove.
3476         <data_window>: Change type.
3477         (struct tui_data_item_window): New.
3478         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3479         case.  Add assert.
3480         (~tui_data_item_window): New destructor.
3481         (free_content_elements): Remove DATA_ITEM_WIN case.
3482
3483 2019-06-25  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3486         Remove.
3487
3488 2019-06-25  Tom Tromey  <tom@tromey.com>
3489
3490         * tui/tui-data.h (struct tui_command_element): Remove.
3491         (union tui_which_element) <command>: Remove.
3492         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3493         assert.
3494         (free_content_elements): Remove CMD_WIN case.
3495
3496 2019-06-25  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-layout.c (tui_set_layout): Update.
3499         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3500         * tui/tui-data.c (layout_def): Update.
3501
3502 2019-06-25  Tom Tromey  <tom@tromey.com>
3503
3504         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3505         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3506         (tui_source_window_base::set_new_height): Update.
3507         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3508         Update.
3509         (tui_set_locator_fullname, tui_set_locator_info)
3510         (tui_show_frame_info): Update.
3511         * tui/tui-source.c (tui_set_source_content)
3512         (tui_source_is_displayed): Update.
3513         * tui/tui-layout.c (show_source_disasm_command, show_data)
3514         (show_source_or_disasm_and_command): Update.
3515         * tui/tui-disasm.c (tui_set_disassem_content)
3516         (tui_get_begin_asm_address): Update.
3517         * tui/tui-data.h (struct tui_locator_element): Remove.
3518         (union tui_which_element) <locator>: Remove.
3519         (struct tui_locator_window): New.
3520         (tui_locator_win_info_ptr): Change return type.
3521         * tui/tui-data.c (_locator): Change type.
3522         (tui_locator_win_info_ptr): Change return type.
3523         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3524         (tui_alloc_content): Add assert.
3525
3526 2019-06-25  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-winsource.c
3529         (tui_exec_info_window::maybe_allocate_content): New method.
3530         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3531         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3532         (make_source_or_disasm_window): Add cast.
3533         * tui/tui-data.h (union tui_which_element) <simple_string>:
3534         Remove.
3535         (struct tui_source_info): New.
3536         (struct tui_source_window_base) <execution_info>: Change type.
3537         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3538         case, and add assert.
3539         (tui_alloc_content): Add assert.
3540
3541 2019-06-25  Tom Tromey  <tom@tromey.com>
3542
3543         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3544         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3545         * tui/tui-data.c (tui_alloc_win_info): Remove.
3546
3547 2019-06-25  Tom Tromey  <tom@tromey.com>
3548
3549         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3550         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3551         can_highlight.
3552
3553 2019-06-25  Tom Tromey  <tom@tromey.com>
3554
3555         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3556         make_visible_with_new_height method.
3557         (tui_win_info::make_visible_with_new_height): New method.
3558         (tui_source_window_base::do_make_visible_with_new_height)
3559         (tui_data_window::do_make_visible_with_new_height)
3560         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3561         (make_visible_with_new_height): Remove.
3562         (tui_resize_all, tui_adjust_win_heights): Use
3563         make_visible_with_new_height method.
3564         * tui/tui-data.h (struct tui_win_info)
3565         <do_make_visible_with_new_height, make_visible_with_new_height>:
3566         New methods.
3567         (struct tui_source_window_base, struct tui_data_window)
3568         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3569         methods.
3570
3571 2019-06-25  Tom Tromey  <tom@tromey.com>
3572
3573         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3574         method.
3575         (update_tab_width): Call update_tab_width method.
3576         * tui/tui-data.h (struct tui_win_info)
3577         (struct tui_source_window_base) <update_tab_width>: New methods.
3578
3579 2019-06-25  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3582         parameter.
3583         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3584         parameter.
3585         (tui_gen_win_info::make_visible): Update.
3586         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3587         parameter.
3588         * tui/tui-data.h (enum tui_box): New enum.
3589         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3590
3591 2019-06-25  Tom Tromey  <tom@tromey.com>
3592
3593         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3594         init_and_make_win for EXEC_INFO_WIN.
3595         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3596         longer inline.
3597         (struct tui_win_info) <~tui_win_info>: Inline.
3598         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3599         Don't declare.
3600         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3601         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3602         Remove.
3603         (tui_initialize_static_data): Update.
3604         (~tui_gen_win_info): Handle more cleanup here.
3605         (~tui_source_window_base): Delete "execution_info".
3606         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3607
3608 2019-06-25  Tom Tromey  <tom@tromey.com>
3609
3610         * tui/tui-layout.c (make_command_window): Don't set
3611         can_highlight.
3612         (show_source_disasm_command): Call the reset method.
3613         (show_data): Don't set can_highlight.  Call the reset method.
3614         (tui_gen_win_info::reset): Rename from init_gen_win_info
3615         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3616         (show_source_or_disasm_and_command): Call the reset method.
3617         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3618         (struct tui_cmd_window): Set can_highlight.
3619
3620 2019-06-25  Tom Tromey  <tom@tromey.com>
3621
3622         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3623         from make_visible.
3624         (tui_make_visible, tui_make_invisible): Rewrite.
3625         (tui_win_info::make_visible): Remove.
3626         (tui_source_window_base::make_visible): Update.
3627         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3628         method.  Moved from...
3629         (struct tui_win_info) <make_visible>: ...here.
3630
3631 2019-06-25  Tom Tromey  <tom@tromey.com>
3632
3633         * tui/tui-winsource.c
3634         (tui_source_window_base::do_scroll_horizontal): Remove direction
3635         parameter.
3636         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3637         direction parameter.
3638         * tui/tui-win.c (tui_win_info::forward_scroll)
3639         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3640         (tui_win_info::right_scroll): Update.
3641         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3642         direction parameter.
3643         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3644         direction parameter.
3645         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3646         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3647         Remove direction parameter.
3648         (struct tui_source_window_base, struct tui_source_window)
3649         (struct tui_disasm_window, struct tui_data_window)
3650         (struct tui_cmd_window): Update.
3651
3652 2019-06-25  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-winsource.h (tui_set_exec_info_content)
3655         (tui_show_exec_info_content, tui_erase_exec_info_content)
3656         (tui_clear_exec_info_content, tui_update_exec_info): Change
3657         argument to tui_source_window_base.
3658         * tui/tui-winsource.c (tui_set_exec_info_content)
3659         (tui_show_exec_info_content, tui_erase_exec_info_content)
3660         (tui_clear_exec_info_content, tui_update_exec_info): Change
3661         argument to tui_source_window_base.
3662
3663 2019-06-25  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3666         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3667
3668 2019-06-25  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3671         check.
3672
3673 2019-06-25  Tom Tromey  <tom@tromey.com>
3674
3675         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3676         type to void.
3677         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3678         type to void.
3679         * tui/tui-source.c (tui_set_source_content): Update.
3680         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3681
3682 2019-06-25  Tom Tromey  <tom@tromey.com>
3683
3684         * tui/tui-win.c (window_name_completer, tui_set_focus)
3685         (tui_all_windows_info): Use name method.
3686         * tui/tui-data.h (struct tui_gen_win_info)
3687         (struct tui_source_window, struct tui_disasm_window)
3688         (struct tui_data_window, struct tui_cmd_window) <name>: New
3689         method.
3690         (tui_win_name): Don't declare.
3691         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3692         (tui_win_name): Remove.
3693
3694 2019-06-25  Tom Tromey  <tom@tromey.com>
3695
3696         * tui/tui-winsource.h (tui_update_source_window)
3697         (tui_update_source_window_as_is): Change parameter type.
3698         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3699         to be a tui_source_window_base.
3700         (tui_update_source_window_as_is): Likewise.
3701         * tui/tui-win.c (make_visible_with_new_height): Update.
3702
3703 2019-06-25  Tom Tromey  <tom@tromey.com>
3704
3705         * tui/tui-winsource.c (tui_erase_source_content)
3706         (tui_show_source_content, tui_show_exec_info_content)
3707         (tui_erase_exec_info_content): Use refresh_window method.
3708         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3709         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3710         from tui_refresh_win.
3711         (tui_data_window::refresh_window): New method.
3712         (tui_win_info::refresh, tui_source_window_base::refresh)
3713         (tui_refresh_all): Use refresh_window method.
3714         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3715         method.
3716         * tui/tui-regs.c (tui_display_register): Call refresh_window
3717         method.
3718         * tui/tui-layout.c (show_source_disasm_command)
3719         (show_source_or_disasm_and_command): Call refresh_window method.
3720         * tui/tui-data.h (struct tui_gen_win_info)
3721         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3722         New method.
3723
3724 2019-06-25  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui.c (tui_rl_other_window, tui_enable)
3727         (tui_is_window_visible, tui_get_command_dimension): Update.
3728         * tui/tui-winsource.c (tui_update_source_window_as_is)
3729         (tui_clear_source_content, tui_erase_source_content)
3730         (tui_show_source_line, tui_source_window_base::refill)
3731         (tui_source_window_base::do_scroll_horizontal)
3732         (tui_source_window_base::set_is_exec_point_at)
3733         (tui_update_breakpoint_info, tui_set_exec_info_content)
3734         (tui_alloc_source_buffer, tui_line_is_displayed)
3735         (tui_addr_is_displayed): Update.
3736         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3737         (tui_check_and_display_highlight_if_needed)
3738         (tui_win_info::make_visible, tui_win_info::refresh)
3739         (tui_refresh_all): Update.
3740         * tui/tui-windata.c (tui_first_data_item_displayed)
3741         (tui_delete_data_content_windows, tui_erase_data_content)
3742         (tui_display_all_data, tui_data_window::refresh_all)
3743         (tui_check_data_values): Update.
3744         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3745         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3746         (tui_win_info::backward_scroll, tui_refresh_all_win)
3747         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3748         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3749         (tui_source_window_base::set_new_height)
3750         (tui_data_window::set_new_height)
3751         (make_invisible_and_set_new_height)
3752         (make_visible_with_new_height, new_height_ok)
3753         (parse_scrolling_args): Update.
3754         * tui/tui-stack.c (tui_show_frame_info): Update.
3755         * tui/tui-source.c (tui_set_source_content)
3756         (tui_set_source_content_nil, tui_source_is_displayed)
3757         (tui_source_window::do_scroll_vertical): Update.
3758         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3759         (tui_display_registers_from, tui_display_reg_element_at_line)
3760         (tui_check_register_values, tui_reg_command): Update.
3761         * tui/tui-layout.c (tui_default_win_height)
3762         (show_source_disasm_command, show_data, init_and_make_win)
3763         (show_source_or_disasm_and_command): Update.
3764         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3765         (tui_redisplay_readline, tui_mld_flush)
3766         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3767         (tui_getc): Update.
3768         * tui/tui-disasm.c (tui_set_disassem_content)
3769         (tui_disasm_window::do_scroll_vertical): Update.
3770         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3771         Now virtual.
3772         (struct tui_win_info): Derive from tui_gen_win_info.
3773         <~tui_win_info>: Mark as override.
3774         <generic>: Remove member.
3775         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3776         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3777         (~tui_data_window, ~tui_win_info)
3778         (tui_free_all_source_wins_content): Update.
3779         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3780
3781 2019-06-25  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-layout.c (init_and_make_win): Use new.
3784         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3785         destructor, initializers.
3786         (tui_alloc_generic_win_info): Don't declare.
3787         * tui/tui-data.c (_locator): Add argument to constructor.
3788         (source_win, disasm_win): New globals.
3789         (exec_info): Remove.
3790         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3791         Update.
3792         (tui_alloc_generic_win_info): Remove.
3793         (init_content_element): Use new.
3794         (tui_win_info::tui_win_info): Update.
3795         (free_content_elements) <case DATA_WIN>: Use delete.
3796
3797 2019-06-25  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3800         * tui/tui-windata.c (tui_first_data_item_displayed)
3801         (tui_delete_data_content_windows): Update.
3802         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3803         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3804         (tui_display_registers_from, tui_check_register_values): Update.
3805         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3806         pointer.
3807         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3808         window.
3809         (tui_free_data_content): Update.
3810         (free_content_elements) <case DATA_WIN>: Free the window.
3811
3812 2019-06-25  Tom Tromey  <tom@tromey.com>
3813
3814         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3815         Update.
3816         * tui/tui-layout.c (make_command_window)
3817         (show_source_disasm_command, show_data, init_and_make_win)
3818         (show_source_or_disasm_and_command): Update.
3819         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3820         method.
3821         <can_highight, is_highlighted>: Now bool.
3822         (tui_set_win_highlight): Don't declare.
3823         * tui/tui-data.c (tui_set_win_highlight): Remove.
3824
3825 2019-06-25  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-wingeneral.c (make_visible): Remove check of window
3828         type.
3829
3830 2019-06-25  Tom Tromey  <tom@tromey.com>
3831
3832         * tui/tui-win.c (tui_win_info::max_height)
3833         (tui_cmd_window::max_height): New methods.
3834         (new_height_ok): Call max_height.
3835         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3836         <max_height>: New method.
3837
3838 2019-06-25  Tom Tromey  <tom@tromey.com>
3839
3840         * tui/tui-win.c (tui_source_window_base::set_new_height)
3841         (tui_data_window::set_new_height): New methods.
3842         (make_invisible_and_set_new_height): Call set_new_height method.
3843         * tui/tui-data.h (struct tui_win_info)
3844         (struct tui_source_window_base, struct tui_data_window)
3845         <set_new_height>: New method.
3846
3847 2019-06-25  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3850         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3851         tui_refresh_data_win.
3852         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3853         method.
3854         (tui_refresh_all_win): Call the refresh_all method.
3855         (tui_set_focus): Likewise.
3856         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3857         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3858         Likewise.
3859
3860 2019-06-25  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-winsource.h (tui_refill_source_window)
3863         (tui_set_is_exec_point_at): Don't declare.
3864         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3865         (tui_source_window_base::refill): Rename from
3866         tui_refill_source_window.
3867         (tui_source_window_base::do_scroll_horizontal): Update.
3868         (tui_source_window_base::set_is_exec_point_at): Rename from
3869         tui_set_is_exec_point_at.
3870         (tui_update_all_breakpoint_info): Update.
3871         * tui/tui-stack.c (tui_show_frame_info): Update.
3872         * tui/tui-layout.c (show_data): Add cast.
3873         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3874         * tui/tui-data.h (struct tui_source_window_base) <refill,
3875         set_is_exec_point_at>: New methods.
3876         (tui_source_windows, tui_add_to_source_windows): Update types.
3877         (tui_add_to_source_windows): Remove redundant declaration.
3878         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3879         (tui_source_windows): Change return type.
3880         (tui_clear_source_windows_detail): Update.
3881         (tui_add_to_source_windows): Change type of parameter.
3882         (tui_free_all_source_wins_content): Update.
3883
3884 2019-06-25  Tom Tromey  <tom@tromey.com>
3885
3886         * tui/tui-wingeneral.c (tui_win_info::refresh)
3887         (tui_source_window_base::refresh): New methods.
3888         (tui_refresh_all): Call the refresh method.
3889         * tui/tui-data.h (struct tui_win_info)
3890         (struct tui_source_window_base) <refresh>: New method.
3891
3892 2019-06-25  Tom Tromey  <tom@tromey.com>
3893
3894         * tui/tui.h (tui_is_window_visible): Return bool.
3895         * tui/tui.c (tui_is_window_visible): Return bool.
3896         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3897         (tui_make_visible, tui_make_invisible)
3898         (tui_win_info::make_visible)
3899         (tui_source_window_base::make_visible, make_all_visible)
3900         (tui_make_all_visible, tui_make_all_invisible): Update.
3901         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3902         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3903         bool.
3904         (struct tui_win_info, struct tui_source_window_base)
3905         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3906         * tui/tui-data.c (tui_init_generic_part): Update.
3907
3908 2019-06-25  Tom Tromey  <tom@tromey.com>
3909
3910         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3911         (tui_source_window_base::make_visible): New methods.
3912         (make_all_visible): Make method call.
3913         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3914         (struct tui_source_window_base, struct tui_cmd_window): Override
3915         make_visible.
3916         (tui_win_is_source_type): Don't declare.
3917         * tui/tui-data.c (tui_win_is_source_type): Remove.
3918
3919 2019-06-25  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3922         NULL check.
3923
3924 2019-06-25  Tom Tromey  <tom@tromey.com>
3925
3926         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3927         Inline constructor.  Add initializers for members.
3928         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3929         constructors; now inline in class.
3930
3931 2019-06-25  Tom Tromey  <tom@tromey.com>
3932
3933         * tui/tui-regs.c (tui_show_registers): Update.
3934         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3935         bool.
3936         * tui/tui-data.c (tui_data_window::clear_detail)
3937         (tui_data_window): Update.
3938
3939 2019-06-25  Tom Tromey  <tom@tromey.com>
3940
3941         * tui/tui-windata.c (tui_display_all_data)
3942         (tui_display_data_from_line, tui_display_data_from)
3943         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3944         Update.
3945         * tui/tui-regs.c (tui_last_regs_line_no)
3946         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3947         (tui_show_registers, tui_show_register_group)
3948         (tui_display_registers_from, tui_display_reg_element_at_line)
3949         (tui_display_registers_from_line, tui_check_register_values)
3950         (tui_reg_next, tui_reg_prev): Update.
3951         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3952         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3953         tui_data_window.
3954         (struct tui_win_info) <detail>: Remove.  Add new fields from
3955         tui_data_info.
3956         (TUI_DATA_WIN): Add cast.
3957         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3958         (~tui_data_window): Simplify.
3959
3960 2019-06-25  Tom Tromey  <tom@tromey.com>
3961
3962         * tui/tui-layout.c (show_source_disasm_command)
3963         (show_source_or_disasm_and_command): Update.
3964         * tui/tui-io.c (update_cmdwin_start_line)
3965         (tui_redisplay_readline): Update.
3966         * tui/tui-data.h (struct tui_command_info): Remove.
3967         (struct tui_win_info) <detail>: Remove command_info member.
3968         (struct tui_data_window) <start_line>: New member, from
3969         tui_command_info.
3970         (TUI_CMD_WIN): Add casts.
3971
3972 2019-06-25  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-winsource.c (tui_update_source_window)
3975         (tui_refill_source_window)
3976         (tui_source_window_base::do_scroll_horizontal)
3977         (tui_update_breakpoint_info, tui_set_exec_info_content)
3978         (tui_show_exec_info_content, tui_erase_exec_info_content)
3979         (tui_clear_exec_info_content): Update.
3980         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3981         Update.
3982         * tui/tui-win.c (make_invisible_and_set_new_height)
3983         (make_visible_with_new_height): Update.
3984         * tui/tui-source.c (tui_set_source_content)
3985         (tui_show_symtab_source): Update.
3986         * tui/tui-layout.c (extract_display_start_addr)
3987         (show_source_disasm_command, show_data)
3988         (make_source_or_disasm_window)
3989         (show_source_or_disasm_and_command): Update.
3990         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3991         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3992         "gdbarch".
3993         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3994         to tui_source_window_base.
3995         (struct tui_win_info) <detail>: Remove source_info member.
3996         (struct tui_source_window_base) <has_locator>: Inline.
3997         Move contents from tui_source_info; rename has_locator member to
3998         m_has_locator.
3999         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4000         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4001         header file.
4002         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4003         Simplify.
4004         (tui_free_all_source_wins_content): Cast to
4005         tui_source_window_base.
4006
4007 2019-06-25  Tom Tromey  <tom@tromey.com>
4008
4009         * tui/tui-win.c (make_invisible_and_set_new_height)
4010         (make_visible_with_new_height): Call has_locator method.
4011         * tui/tui-layout.c (show_source_disasm_command, show_data)
4012         (show_source_or_disasm_and_command): Update for bool change.
4013         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4014         (tui_win_info) <has_locator>: New method.
4015         (struct tui_source_window_base) <has_locator>: New method.
4016         (tui_win_has_locator): Don't declare.
4017         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4018         from tui_win_has_locator.
4019         (tui_source_window_base): Use false, not FALSE.
4020
4021 2019-06-25  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4024         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4025         clear_detail method directly.
4026         (tui_clear_win_detail): Remove.
4027
4028 2019-06-25  Tom Tromey  <tom@tromey.com>
4029
4030         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4031         "this", not TUI_DISASM_WIN.
4032
4033 2019-06-25  Tom Tromey  <tom@tromey.com>
4034
4035         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4036         declare.
4037         * tui/tui-winsource.c
4038         (tui_source_window_base::do_scroll_horizontal): Rename from
4039         tui_horizontal_source_scroll.
4040         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4041         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4042         from tui_vertical_data_scroll.
4043         * tui/tui-win.h (tui_scroll): Don't declare.
4044         * tui/tui-win.c (tui_win_info::forward_scroll)
4045         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4046         (tui_win_info::right_scroll): Rename and update.
4047         (tui_scroll_forward_command, tui_scroll_backward_command)
4048         (tui_scroll_left_command, tui_scroll_right_command): Update.
4049         (tui_scroll): Remove.
4050         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4051         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4052         from tui_vertical_source_scroll.
4053         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4054         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4055         from tui_vertical_disassem_scroll.
4056         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4057         do_scroll_horizontal>: New methods.
4058         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4059         Likewise.
4060         (struct tui_source_window_base): Add do_scroll_horizontal.
4061         (struct tui_source_window, struct tui_disasm_window): Add
4062         do_scroll_vertical.
4063         (struct tui_data_window, struct tui_cmd_window): Add
4064         do_scroll_horizontal and do_scroll_vertical.
4065         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4066
4067 2019-06-25  Tom Tromey  <tom@tromey.com>
4068
4069         * tui/tui-data.h (struct tui_source_window_base): New struct.
4070         (struct tui_source_window): Derive from tui_source_window_base.
4071         (struct tui_disasm_window): New struct.
4072         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4073         from tui_source_window::clear_detail.
4074         (tui_source_window_base): Rename from tui_source_window.
4075         (~tui_source_window_base): Rename from ~tui_source_window.
4076         (tui_alloc_win_info): Create a tui_disasm_window.
4077
4078 2019-06-25  Tom Tromey  <tom@tromey.com>
4079
4080         * tui/tui-data.h (struct tui_source_window)
4081         (struct tui_data_window): Declare destructors.
4082         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4083         destructors.
4084         (tui_win_info): Simplify.
4085
4086 2019-06-25  Tom Tromey  <tom@tromey.com>
4087
4088         * tui/tui-winsource.c (tui_display_main)
4089         (tui_update_source_windows_with_addr)
4090         (tui_update_all_breakpoint_info): Update.
4091         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4092         (new_height_ok, parse_scrolling_args): Update.
4093         * tui/tui-stack.c (tui_show_frame_info): Update.
4094         * tui/tui-data.h (struct tui_list): Remove.
4095         (tui_source_windows): Return a reference to a std::vector.
4096         * tui/tui-data.c (source_windows): Now a std::vector.
4097         (tui_source_windows): Change return type.
4098         (tui_clear_source_windows): Rewrite.
4099         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4100         (tui_free_all_source_wins_content): Rewrite.
4101
4102 2019-06-25  Tom Tromey  <tom@tromey.com>
4103
4104         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4105         (struct tui_data_window, struct tui_cmd_window): Declare
4106         clear_detail method.
4107         * tui/tui-data.c (tui_source_window::clear_detail)
4108         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4109         methods.
4110         (tui_clear_win_detail): Simplify.
4111
4112 2019-06-25  Tom Tromey  <tom@tromey.com>
4113
4114         * tui/tui-layout.c (make_source_window, make_disasm_window)
4115         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4116         Return the new window.
4117         (show_source_disasm_command, show_data)
4118         (show_source_or_disasm_and_command): Update.
4119
4120 2019-06-25  Tom Tromey  <tom@tromey.com>
4121
4122         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4123         parameter.  Return the new window.
4124         (show_source_disasm_command): Update and remove NULL check.
4125         (show_source_or_disasm_and_command): Update.
4126
4127 2019-06-25  Tom Tromey  <tom@tromey.com>
4128
4129         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4130
4131 2019-06-25  Tom Tromey  <tom@tromey.com>
4132
4133         * tui/tui-data.h (struct tui_win_info): Make constructor
4134         protected.  Make destructor virtual.  Add initializers.
4135         (tui_source_window, tui_data_window, tui_cmd_window): New
4136         classes.
4137         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4138         constructor.  Add "type" parameter.
4139         (tui_source_window, tui_data_window, tui_cmd_window): New
4140         constructors.
4141         (tui_alloc_win_info): Instantiate the appropriate subclass.
4142
4143 2019-06-25  Tom Tromey  <tom@tromey.com>
4144
4145         * tui/tui-win.c (tui_resize_all): Use delete.
4146         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4147         destructor.
4148         (tui_free_window): Don't declare.
4149         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4150         Update.
4151
4152 2019-06-25  Tom Tromey  <tom@tromey.com>
4153
4154         * tui/tui-data.h (struct tui_win_info): Add constructor.
4155         * tui/tui-data.c (tui_alloc_win_info): Use new.
4156         (tui_free_window): Use delete.
4157
4158 2019-06-22  Tom Tromey  <tom@tromey.com>
4159
4160         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4161         declare.
4162         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4163
4164 2019-06-22  Tom Tromey  <tom@tromey.com>
4165
4166         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4167         declare.
4168         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4169
4170 2019-06-22  Tom de Vries  <tdevries@suse.de>
4171
4172         * dwarf2read.c (create_addrmap_from_aranges)
4173         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4174         instead of '%zu'.
4175
4176 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4177
4178         * dwarf2read.h (dwarf2_section_info_def): Remove.
4179         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4180         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4181         std::vector<dwarf2_section_info>.
4182         (struct dwo_file) <~dwo_file>: Remove.
4183         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4184         types field.
4185         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4186         (dwarf2_read_debug_names): Likewise.
4187         (create_debug_types_hash_table): Change parameter type to
4188         array_view, adjust code accordingly.
4189         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4190         (partial_die_info::fixup): Likewise.
4191         (determine_prefix): Likewise.
4192         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4193
4194 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4195
4196         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4197         gdb_bfd_ref_ptr.
4198         <~dwo_file>: Remove call to gdb_bfd_unref.
4199         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4200         gdb_bfd_ref_ptr::get.
4201
4202 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4203
4204         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4205         type to htab_up.
4206         * dwarf2read.c (struct dwo_file): Initialize fields.
4207         <~dwo_file>: New.
4208         (free_dwo_file): Remove, move content to ~dwo_file.
4209         (struct dwo_file_deleter): Remove.
4210         (dwo_file_up>: Remove custom deleter.
4211         (free_dwo_files): Remove.
4212         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4213         dwo_files.
4214         (process_skeletonless_type_units): Call unique_ptr::get.
4215         (allocate_dwo_file_hash_table): Add deleter to created hash
4216         table.  Change return type to htab_up.
4217         (lookup_dwo_file_slot): Don't memset dwo_file, call
4218         unique_ptr::get.
4219         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4220         (create_dwo_unit_in_dwp_v2): Likewise.
4221         (open_and_init_dwo_file): Likewise.
4222         (free_dwo_file_from_slot): Remove.
4223
4224 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4225
4226         * dwarf2read.h (struct dwarf2_section_info) <readin,
4227         is_virtual>: Change type to bool.
4228         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4229         true instead of 1.
4230
4231 2019-06-19  Tom Tromey  <tom@tromey.com>
4232
4233         * tui/tui-data.h (tui_init_content_element): Don't declare.
4234
4235 2019-06-19  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-data.h (tui_init_win_info): Don't declare.
4238
4239 2019-06-19  Tom de Vries  <tdevries@suse.de>
4240
4241         * dwarf2read.h (abstract_to_concrete): Change type to
4242         std::unordered_map<sect_offset, std::vector<sect_offset>,
4243         gdb::hash_enum<sect_offset>>.
4244
4245 2019-06-19  Tom Tromey  <tromey@adacore.com>
4246
4247         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4248         EVAL_AVOID_SIDE_EFFECTS specially.
4249
4250 2019-06-19  Tom Tromey  <tromey@adacore.com>
4251
4252         * source-cache.c (highlighter): New global.
4253         (source_cache::get_source_lines): Create a highlighter on demand.
4254
4255 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * defs.h (deprecated_interactive_hook): Delete declaration.
4258         * interps.c (clear_interpreter_hooks): Remove use of
4259         deprecated_interactive_hook.
4260         * top.c (deprecated_interactive_hook): Delete definition.
4261         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4262
4263 2019-06-18  Tom de Vries  <tdevries@suse.de>
4264
4265         PR gdb/24515
4266         * dwarf2read.h (abstract_to_concrete): Change type from
4267         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4268         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4269         * dwarf2read.c (read_variable): Update.
4270         (dwarf2_fetch_die_loc_sect_off): Update.
4271
4272 2019-06-17  Tom de Vries  <tdevries@suse.de>
4273
4274         PR gdb/24617
4275         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4276         accessing parent[parent_len - 1].
4277
4278 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4279
4280         PR gdb/24364
4281         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4282         call dtrace_process_dof with NULL dof.
4283
4284 2019-06-16  Tom de Vries  <tdevries@suse.de>
4285
4286         PR gdb/24445
4287         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4288
4289 2019-06-16  Tom Tromey  <tom@tromey.com>
4290
4291         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4292         (make_all_visible): Use address of member.
4293
4294 2019-06-16  Tom Tromey  <tom@tromey.com>
4295
4296         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4297         (tui_free_window, free_content, free_content_elements): Remove
4298         unnecessary cast.
4299         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4300         cast.
4301         * tui/tui-regs.c (tui_show_register_group)
4302         (tui_display_registers_from, tui_display_reg_element_at_line):
4303         Remove unnecessary cast.
4304
4305 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4306
4307         * linux-nat.c (normal_mask): Delete.
4308         (_initialize_linux_nat): Don't initialise normal_mask.
4309
4310 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4311
4312         PR gdb/24445
4313         * dwarf-index-write.h (write_psymtabs_to_index): Add
4314         dwz_basename parameter.
4315         * dwarf-index-write.c (write_gdbindex): Move file writing to
4316         write_gdbindex_1.  Change return type void.
4317         (assert_file_size): Move up, remove filename parameter.
4318         (write_gdbindex_1): New function.
4319         (write_debug_names): Change return type to void, call
4320         assert_file_size.
4321         (struct index_wip_file): New struct.
4322         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4323         file logic to index_wip_file.  Write index for dwz file if
4324         needed.
4325         (save_gdb_index_command): Pass basename of dwz file, if present.
4326         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4327         build-id of dwz file, if present.
4328         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4329         (dwarf2_get_dwz_file): Likewise.
4330         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4331         (dwarf2_get_dwz_file): Likewise.
4332
4333 2019-06-16  Tom Tromey  <tom@tromey.com>
4334
4335         * coffread.c (process_coff_symbol): Use xstrdup.
4336         * value.c (create_internalvar): Use xstrdup.
4337
4338 2019-06-16  Tom Tromey  <tom@tromey.com>
4339
4340         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4341         * breakpoint.c (stopin_command, stopat_command)
4342         (until_break_command, decode_location_default): Remove unnecessary
4343         cast.
4344         * utils.c (subset_compare): Remove unnecessary cast.
4345         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4346         cast.
4347         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4348         cast.
4349         * infcmd.c (path_command): Remove unnecessary cast.
4350         * coffread.c (decode_type): Remove unnecessary cast.
4351         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4352         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4353         * tui/tui-stack.c (tui_show_locator_content)
4354         (tui_show_frame_info): Remove unnecessary cast.
4355         * tui/tui-win.c (tui_scroll_forward_command)
4356         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4357         (parse_scrolling_args): Remove unnecessary cast.
4358         * tui/tui-data.c (init_win_info, tui_del_window)
4359         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4360         (free_content_elements): Remove unnecessary cast.
4361         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4362         unnecessary cast.
4363         * tui/tui-source.c (tui_set_source_content)
4364         (tui_vertical_source_scroll): Remove unnecessary cast.
4365         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4366         cast.
4367         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4368         * tui/tui-regs.c (tui_display_registers_from)
4369         (tui_display_register): Remove unnecessary cast.
4370         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4371         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4372         (make_visible): Remove unnecessary cast.
4373         * tui/tui-winsource.c (tui_erase_source_content)
4374         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4375         unnecessary cast.
4376         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4377         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4378         * stabsread.c (read_type, read_array_type, read_range_type):
4379         Remove unnecessary cast.
4380         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4381         (parse_symbol, parse_type, upgrade_type, parse_external)
4382         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4383         unnecessary cast.
4384         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4385
4386 2019-06-16  Tom Tromey  <tom@tromey.com>
4387
4388         * tui/tui-data.c (tui_alloc_generic_win_info)
4389         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4390         checks.
4391
4392 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4393             Andrew Burgess  <andrew.burgess@embecosm.com>
4394
4395         * f-typeprint.c (f_print_type): Don't return early for not
4396         associated or not allocated types.
4397         (f_type_print_varspec_suffix): Add print_rank parameter and print
4398         ranks of array types in case they dangling.
4399         (f_type_print_base): Add print_rank parameter.
4400
4401 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4402
4403         * NEWS: Mention new MI commands.
4404         * break-catch-throw.c (enum exception_event_kind): Move to
4405         breakpoint.h.
4406         (print_mention_exception_catchpoint): Output text as a single
4407         message.
4408         (catch_exception_command_1): Rename to...
4409         (catch_exception_event): ...this, make non-static, update header
4410         command, and change some parameter types.
4411         (catch_catch_command): Update for changes to
4412         catch_exception_command_1.
4413         (catch_throw_command): Likewise.
4414         (catch_rethrow_command): Likewise.
4415         * breakpoint.c (enum exception_event_kind): Delete.
4416         * breakpoint.h (enum exception_event_kind): Moved here from
4417         break-catch-throw.c.
4418         (catch_exception_event): Declare.
4419         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4420         (mi_cmd_catch_throw): New function.
4421         (mi_cmd_catch_rethrow): New function.
4422         (mi_cmd_catch_catch): New function.
4423         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4424         'catch-catch' entries.
4425         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4426         (mi_cmd_catch_rethrow): Declare.
4427         (mi_cmd_catch_catch): Declare.
4428
4429 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4430
4431         * annotate.c (annotate_source_line): Change return type to void,
4432         update implementation to match.
4433         * annotate.h (annotate_source_line): Change return type to void,
4434         update header comment.
4435         * stack.c (print_frame_info): Don't change what frame information
4436         is printed based on whether annotations are on or not.
4437
4438 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4439
4440         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4441         (annotate_source): Make static.
4442         (annotate_source_line): Moved from source.c and renamed from
4443         identify_source_line.  Update the return type.
4444         * annotate.h (annotate_source): Delete declaration.
4445         (annotate_source_line): Declaration moved from source.h, and
4446         renamed from identify_source_line.  Return type updated.
4447         * source.c (identify_source_line): Moved to annotate.c and renamed
4448         to annotate_source_line.
4449         (info_line_command): Remove check of annotation_level.
4450         * source.h (identify_source_line): Move declaration to annotate.h
4451         and rename to annotate_source_line.
4452         * stack.c: Add 'annotate.h' include.
4453         (print_frame_info): Remove check of annotation_level before
4454         calling annotate_source_line.
4455
4456 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         * source-cache.c (source_cache::get_plain_source_lines): Use
4459         open_source_file_with_line_charpos instead of just
4460         open_source_file, remove call to find_source_lines.
4461         (source_cache::get_source_lines): Likewise.
4462         * source.c (find_source_lines): Make static.
4463         (get_filename_and_charpos): Renamed into...
4464         (open_source_file_with_line_charpos): ..this along with changes to
4465         return a scoped_fd, and some other minor clean ups.
4466         (identify_source_line): Use open_source_file_with_line_charpos.
4467         (search_command_helper): Use open_source_file_with_line_charpos
4468         instead of just open_source_file, remove call to
4469         find_source_lines.
4470         * source.h (open_source_file_with_line_charpos): Declare new
4471         function.
4472         (find_source_lines): Delete declaration.
4473
4474 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4475
4476         * source.c (get_filename_and_charpos): Remove fullname
4477         parameter.
4478         (identify_source_line): Update call to get_filename_and_charpos.
4479
4480 2019-06-14  Tom Tromey  <tromey@adacore.com>
4481
4482         PR gdb/24502:
4483         * ui-style.h (skip_ansi_escape): Update comment.
4484         * ui-file.h (class no_terminal_escape_file): New class.
4485         * ui-file.c (no_terminal_escape_file::write)
4486         (no_terminal_escape_file::puts): New methods.
4487         * cli/cli-logging.c (handle_redirections): Use
4488         no_terminal_escape_file.
4489
4490 2019-06-14  Tom Tromey  <tromey@adacore.com>
4491
4492         * NEWS: Move convenience variable news above Python news.
4493
4494 2019-06-14  Tom Tromey  <tom@tromey.com>
4495
4496         * gnulib: Move directory to top-level.
4497         * configure.ac: Don't configure gnulib.
4498         * configure: Rebuild.
4499         * common/common-defs.h: Use new path to gnulib.
4500         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4501         (GNULIB_H): Remove.
4502         (INCGNU): Look in new gnulib location.
4503         (HFILES_NO_SRCDIR): Remove gnulib files.
4504         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4505         (generated_files): Remove GNULIB_H.
4506         ($(LIBGNU), all-lib): Remove targets.
4507         (distclean): Don't mention GNULIB_BUILDDIR.
4508         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4509
4510 2019-06-14  Tom Tromey  <tromey@adacore.com>
4511
4512         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4513         Warn if symbol file does not provide any symbols.
4514
4515 2019-06-14  Tom Tromey  <tromey@adacore.com>
4516
4517         * source.c (find_and_open_source): Respect basenames_may_differ.
4518
4519 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4520
4521         * annotate.c (annotate_breakpoints_invalid): Make use of
4522         scoped_restore_terminal_state.
4523         (annotate_frames_invalid): Likewise.
4524
4525 2019-06-14  Tom Tromey  <tromey@adacore.com>
4526
4527         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4528         allow assignment to an internalvar.
4529
4530 2019-06-14  Tom Tromey  <tromey@adacore.com>
4531
4532         * ada-lex.l: Allow "_" in attribute names.
4533
4534 2019-06-14  Tom Tromey  <tromey@adacore.com>
4535
4536         PR gdb/24653:
4537         * regcache.c (registers_changed): Don't call alloca.
4538         * top.c (execute_command): Don't call alloca.
4539
4540 2019-06-13  Pedro Alves  <palves@redhat.com>
4541
4542         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4543         'expression'.  When parsing an expression, error out if there's
4544         junk after "unlimited".
4545         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4546         (do_set_command): Adjust calls to is_unlimited_literal.
4547
4548 2019-06-13  Pedro Alves  <palves@redhat.com>
4549
4550         * compile/compile.c (make_compile_options_def_group): Add braces
4551         around array_view initializer.
4552         * thread.c (make_thread_apply_all_options_def_group)
4553         (make_thread_apply_all_options_def_group): Likewise.
4554
4555 2019-06-13  Pedro Alves  <palves@redhat.com>
4556
4557         * NEWS (New commands): Mention "maint test-options
4558         require-delimiter", "maint test-options unknown-is-error", "maint
4559         test-options unknown-is-operand" and "maint show
4560         test-options-completion-result".
4561         (New command options, command completion): New section.
4562         (Completion improvements): New section.
4563         Mention that you can abbreviate "unlimited".
4564
4565 2019-06-13  Pedro Alves  <palves@redhat.com>
4566
4567         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4568         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4569         * unittests/cli-utils-selftests.c (test_parse_flags)
4570         (test_parse_flags_qcs): Delete.
4571         (test_cli_utils): Don't call deleted functions.
4572
4573 2019-06-13  Pedro Alves  <palves@redhat.com>
4574
4575         * thread.c: Include "cli/cli-option.h".
4576         (tp_array_compar_ascending): Global.
4577         (tp_array_compar): Delete function.
4578         (tp_array_compar_ascending, tp_array_compar_descending): New
4579         functions.
4580         (ascending_option_def, qcs_flag_option_def)
4581         (thr_qcs_flags_option_defs)
4582         (make_thread_apply_all_options_def_group)
4583         (make_thread_apply_options_def_group): New.
4584         (thread_apply_all_command): Use gdb::option::process_options.
4585         (thread_apply_command_completer)
4586         (thread_apply_all_command_completer): New.
4587         (thread_apply_command): Use gdb::option::process_options.
4588         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4589         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4590         to generate help text of "thread apply".  Adjust "taas"'s help.
4591         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4592         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4593
4594 2019-06-13  Pedro Alves  <palves@redhat.com>
4595
4596         * thread.c (thread_apply_command): Check for invalid TID with
4597         isdigit instead of !isalpha.
4598
4599 2019-06-13  Pedro Alves  <palves@redhat.com>
4600
4601         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4602         (validate_flags_qcs): New.
4603         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4604         (validate_flags_qcs): Declare.
4605         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4606         (make_frame_apply_options_def_group): New.
4607         (frame_apply_command_count): Process options with
4608         gdb::option::process_options.
4609         (frame_apply_completer): New.
4610         (frame_apply_level_completer, frame_apply_all_completer)
4611         (frame_apply_completer): New.
4612         (_initialize_stack): Update help of "frame apply", "frame apply
4613         level", "frame apply all" and "faas" to mention supported options
4614         and install command completers.
4615         * stack.h (frame_apply_all_completer): Declare.
4616         * thread.c: Include "stack.h".
4617         (tfaas_command): Add "--".
4618         (_initialize_thread): Update help "tfaas" to mention supported
4619         options and install command completer.
4620
4621 2019-06-13  Pedro Alves  <palves@redhat.com>
4622
4623         * completer.c (complete_nested_command_line): New.
4624         (gdb_completion_word_break_characters_throw): Add assertion.
4625         * completer.h (complete_nested_command_line): Declare.
4626
4627 2019-06-13  Pedro Alves  <palves@redhat.com>
4628
4629         * stack.c (parse_backtrace_qualifiers): New.
4630         (backtrace_command): Use it.
4631         (backtrace_command_completer): Complete on qualifiers.
4632
4633 2019-06-13  Pedro Alves  <palves@redhat.com>
4634
4635         * frame.c: Include "cli/cli-option.h.
4636         (user_set_backtrace_options): New.
4637         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4638         Delete.
4639         (get_prev_frame): Adjust.
4640         (boolean_option_def, uinteger_option_def)
4641         (set_backtrace_option_defs): New.
4642         (_initialize_frame): Adjust and use
4643         gdb::option::add_setshow_cmds_for_options to install "set
4644         backtrace past-main" and "set backtrace past-entry".
4645         * frame.h: Include "cli/cli-option.h".
4646         (struct frame_print_options): Forward declare.
4647         (print_frame_arguments_all, print_frame_arguments_scalars)
4648         (print_frame_arguments_none): Declare.
4649         (print_entry_values): Delete declaration.
4650         (struct frame_print_options, user_frame_print_options): New.
4651         (struct set_backtrace_options): New.
4652         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4653         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4654         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4655         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4656         (list_args_or_locals): Add frame_print_options parameter.
4657         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4658         * python/py-framefilter.c (enumerate_args): Pass down
4659         USER_FRAME_PRINT_OPTIONS.
4660         * stack.c: Include "cli/cli-option.h".
4661         (print_frame_arguments_all, print_frame_arguments_scalars)
4662         (print_frame_arguments_none): Declare.
4663         (print_raw_frame_arguments, print_entry_values): Delete.
4664         (user_frame_print_options): New.
4665         (boolean_option_def, enum_option_def, frame_print_option_defs):
4666         New.
4667         (struct backtrace_cmd_options): New.
4668         (bt_flag_option_def): New.
4669         (backtrace_command_option_defs): New.
4670         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4671         (print_frame_arg, read_frame_arg, print_frame_args)
4672         (print_frame_info, print_frame): Add frame_print_options parameter
4673         and use it.
4674         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4675         (backtrace_command_1): Add frame_print_options and
4676         backtrace_cmd_options parameters and use them.
4677         (make_backtrace_options_def_group): New.
4678         (backtrace_command): Process command options with
4679         gdb::option::process_options.
4680         (backtrace_command_completer): New.
4681         (_initialize_stack): Extend "backtrace"'s help to mention
4682         supported options.  Install completer for "backtrace".
4683         Install some settings commands with add_setshow_cmds_for_options.
4684
4685 2019-06-13  Pedro Alves  <palves@redhat.com>
4686
4687         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4688         and that "set/show print raw frame-arguments" are now deprecated.
4689
4690         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4691         command.
4692         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4693         * stack.c (_initialize_stack): Install "set/show print
4694         raw-frame-arguments", and deprecate "set/show print raw
4695         frame-arguments".
4696         * valprint.c (_initialize_valprint): Deprecate "set/show print
4697         raw".
4698
4699 2019-06-13  Pedro Alves  <palves@redhat.com>
4700
4701         * compile/compile.c (struct compile_options): New.
4702         (compile_flag_option_def, compile_command_option_defs)
4703         (make_compile_options_def_group): New.
4704         (compile_file_command): Handle options with
4705         gdb::option::process_options.
4706         (compile_file_command_completer): New function.
4707         (compile_code_command): Handle options with
4708         gdb::option::process_options.
4709         (compile_code_command_completer): New function.
4710         (_initialize_compiler): Install completers for "compile code" and
4711         "compile file".  Mention available options in "compile code" and
4712         "compile code"'s help.
4713         * completer.c (advance_to_completion_word): New, factored out from
4714         ...
4715         (advance_to_expression_complete_word_point): ... this.
4716         (advance_to_filename_complete_word_point): New.
4717         * completer.h (advance_to_filename_complete_word_point): New
4718         declaration.
4719
4720 2019-06-13  Pedro Alves  <palves@redhat.com>
4721
4722         * compile/compile.c: Include "cli/cli-option.h".
4723         (compile_print_value): Scope data pointer is now a
4724         value_print_options pointer; adjust.
4725         (compile_print_command): Process options.  Scope data pointer is
4726         now a value_print_options pointer; adjust.
4727         (_initialize_compile): Update "compile print"'s help to include
4728         supported options.  Install a completer for "compile print".
4729         * cp-valprint.c (show_vtblprint, show_objectprint)
4730         (show_static_field_print): Delete.
4731         (_initialize_cp_valprint): Don't install "set print
4732         static-members", "set print vtbl", "set print object" here.
4733         * printcmd.c: Include "cli/cli-option.h" and
4734         "common/gdb_optional.h".
4735         (print_command_parse_format): Rework to fill in a
4736         value_print_options instead of a format_data.
4737         (print_value): Change parameter type from format_data pointer to
4738         value_print_options reference.  Adjust.
4739         (print_command_1): Process options.  Adjust to pass down a
4740         value_print_options.
4741         (print_command_completer): New.
4742         (_initialize_printcmd): Install print_command_completer as
4743         handle_brkchars completer for the "print" command.  Update
4744         "print"'s help to include supported options.
4745         * valprint.c: Include "cli/cli-option.h".
4746         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4747         here from cp-valprint.c.
4748         (boolean_option_def, uinteger_option_def)
4749         (value_print_option_defs, make_value_print_options_def_group):
4750         New.  Use gdb::option::add_setshow_cmds_for_options to install
4751         "set print elements", "set print null-stop", "set print repeats",
4752         "set print pretty", "set print union", "set print array", "set
4753         print address", "set print symbol", "set print array-indexes".
4754         * valprint.h: Include <string> and "cli/cli-option.h".
4755         (make_value_print_options_def_group): Declare.
4756         (print_value): Change parameter type from format_data pointer to
4757         value_print_options reference.
4758         (print_command_completer): Declare.
4759
4760 2019-06-13  Pedro Alves  <palves@redhat.com>
4761
4762         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4763         (COMMON_SFILES): Add maint-test-settings.c.
4764         * cli/cli-decode.c (boolean_enums): New global, factored out from
4765         ...
4766         (add_setshow_boolean_cmd): ... here.
4767         * cli/cli-decode.h (boolean_enums): Declare.
4768         * cli/cli-option.c: New file.
4769         * cli/cli-option.h: New file.
4770         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4771         factored out from ...
4772         (parse_cli_boolean_value(const char *)): ... this.
4773         (is_unlimited_literal): Change parameter type to pointer to
4774         pointer.  Adjust and advance ARG pointer.
4775         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4776         (parse_cli_var_enum): New, factored out from ...
4777         (do_set_command): ... this.  Adjust.
4778         * cli/cli-setshow.h (parse_cli_boolean_value)
4779         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4780         (parse_cli_var_enum): Declare.
4781         * cli/cli-utils.c: Include "cli/cli-option.h".
4782         (get_ulongest): New.
4783         * cli/cli-utils.h (get_ulongest): Declare.
4784         (check_for_argument): New overloads.
4785         * maint-test-options.c: New file.
4786
4787 2019-06-13  Pedro Alves  <palves@redhat.com>
4788
4789         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4790         parse a range if "-" is at the end of the string.
4791
4792 2019-06-13  Pedro Alves  <palves@redhat.com>
4793
4794         * cli/cli-setshow.c (parse_auto_binary_operation)
4795         (parse_cli_boolean_value): Don't allow "o".
4796
4797 2019-06-13  Pedro Alves  <palves@redhat.com>
4798
4799         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4800         * NEWS: Mention maint test-settings KIND.
4801         * maint-test-settings.c: New file.
4802
4803 2019-06-13  Pedro Alves  <palves@redhat.com>
4804
4805         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4806         completer.
4807         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4808         "set" completers.
4809
4810 2019-06-13  Pedro Alves  <palves@redhat.com>
4811
4812         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4813         after item.
4814
4815 2019-06-13  Pedro Alves  <palves@redhat.com>
4816
4817         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4818
4819 2019-06-13  Pedro Alves <palves@redhat.com>
4820
4821         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4822         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4823         call.
4824         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4825         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4826         calls.
4827         (check_for_argument): Skip spaces after argument.
4828
4829 2019-06-13  Pedro Alves  <palves@redhat.com>
4830
4831         * thread.c (thread_apply_command): Adjust TID parsing.
4832         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4833         detected before end of string.
4834         (tid_is_in_list): Error out if LIST is invalid.
4835
4836 2019-06-13  Pedro Alves  <palves@redhat.com>
4837
4838         * completer.c (complete_line_internal_1): Rewind completion word
4839         point.
4840         (completion_tracker::advance_custom_word_point_by): Change
4841         parameter type to int.
4842         * completer.h (completion_tracker::advance_custom_word_point_by):
4843         Likewise.
4844
4845 2019-06-13  Pedro Alves  <palves@redhat.com>
4846
4847         * completer.c (advance_to_completion_word): Handle delimiters.
4848
4849 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4850
4851         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4852
4853 2019-06-11  Tom Tromey  <tom@tromey.com>
4854
4855         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4856         (xmalloc_failed): Move to alloc.c.
4857         * alloc.c: New file.
4858         * Makefile.in (COMMON_SFILES): Add alloc.c.
4859
4860 2019-06-11  Tom Tromey  <tom@tromey.com>
4861
4862         * nat/linux-waitpid.c: Don't include server.h.
4863         (linux_debug): Remove.
4864         (my_waitpid): Update.
4865
4866 2019-06-11  Tom Tromey  <tromey@adacore.com>
4867
4868         * infcall.c (_initialize_infcall): Remove trailing newline from
4869         help.
4870         * user-regs.c (_initialize_user_regs): Remove trailing newline
4871         from help.
4872         * typeprint.c (_initialize_typeprint): Remove trailing newline
4873         from help.
4874         * reverse.c (_initialize_reverse): Remove trailing newlines from
4875         help.
4876         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4877         from help.
4878         * language.c (add_set_language_command): Remove trailing newline
4879         from help.
4880         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4881         help.
4882         * disasm.c (_initialize_disasm): Remove trailing newline from
4883         help.
4884         * top.c (init_main): Remove trailing newline from help.
4885         * interps.c (_initialize_interpreter): Remove trailing newline
4886         from help.
4887         * btrace.c (_initialize_btrace): Remove trailing newlines from
4888         help.
4889         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4890         from help.
4891         * python/python.c (_initialize_python): Remove trailing newline
4892         from help.
4893         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4894         help.
4895         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4896         from help.  Reformat some text.
4897         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4898         from help.
4899         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4900         newline from help.
4901
4902 2019-06-11  Tom Tromey  <tromey@adacore.com>
4903
4904         * darwin-nat.c (darwin_decode_exception_message)
4905         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4906
4907 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * valops.c (value_slice): Check for not allocated or not
4910         associated values.
4911
4912 2019-06-10  Tom de Vries  <tdevries@suse.de>
4913
4914         PR gdb/24618
4915         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4916         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4917         invalid.
4918
4919 2019-06-10  Tom de Vries  <tdevries@suse.de>
4920
4921         PR gdb/24611
4922         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4923         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4924
4925 2019-06-10  Tom de Vries  <tdevries@suse.de>
4926
4927         PR symtab/24545
4928         * symtab.c (struct demangled_name_entry): Add language field.
4929         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4930         static minimal symbol".  Set and use language field.
4931
4932 2019-06-10  Tom Tromey  <tromey@adacore.com>
4933
4934         * ada-lang.c (_initialize_ada_language): Update help text.
4935
4936 2019-06-10  Tom Tromey  <tromey@adacore.com>
4937
4938         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4939         with a newline.
4940         * guile/guile.c (handle_boot_error): Don't end warning with a
4941         newline.
4942         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4943         warning with a newline.
4944         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4945         newline.
4946         (s12z_frame_cache): Likewise.
4947         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4948         a newline.
4949         * solib-svr4.c (disable_probes_interface): Don't end warning with
4950         a newline.
4951         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4952         newline.
4953         * python/python.c (do_finish_initialization): Don't end warning
4954         with a newline.
4955
4956 2019-06-10  Tom Tromey  <tom@tromey.com>
4957
4958         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4959         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4960         gdbpy_enter.
4961
4962 2019-06-10  Tom Tromey  <tromey@adacore.com>
4963
4964         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4965         data.
4966         (elf_new_init): Don't call stabsread_new_init.
4967         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4968         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4969         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4970
4971 2019-06-10  Tom de Vries  <tdevries@suse.de>
4972
4973         PR symtab/16264
4974         PR symtab/24517
4975         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4976
4977 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4978
4979         * source.c (find_and_open_source): Also rewrite relative file
4980         names.
4981
4982 2019-04-26  Amos Bird  <amosbird@gmail.com>
4983
4984         * annotate.c (annotate_thread_exited): Add "thread-exited"
4985         annotation.
4986
4987 2019-06-06  Tom Tromey  <tromey@adacore.com>
4988
4989         * maint.h (class scoped_command_stats): Use
4990         DISABLE_COPY_AND_ASSIGN.
4991         <print_time>: New method.
4992         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4993         print_time.
4994         (scoped_command_stats::print_time): New method.
4995
4996 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4997
4998         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4999         instructions of lengths 6 or 8 bytes.
5000
5001 2019-06-04  Pedro Alves  <palves@redhat.com>
5002
5003         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5004
5005         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5006         * breakpoint.c (condition_completer): Likewise.
5007         * cli/cli-dump.c (scan_expression): Likewise.
5008         * common/filestuff.c (mkdir_recursive): Likewise.
5009         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5010         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5011         (gdb_abspath): Likewise.
5012         * compile/compile-cplus-types.c
5013         (compile_cplus_instance::decl_name): Likewise.
5014         * completer.c (complete_explicit_location):
5015         (signal_completer, reg_or_group_completer_1): Likewise.
5016         * cp-support.c (cp_remove_params_if_any): Likewise.
5017         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5018         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5019         * infcmd.c (strip_bg_char): Likewise.
5020         * linespec.c (copy_token_string): Likewise.
5021         * mi/mi-main.c (output_cores): Likewise.
5022         * psymtab.c (psymtab_search_name):
5023         * symfile.c (test_set_ext_lang_command): Likewise.
5024         * target.c (target_fileio_read_stralloc): Likewise.
5025         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5026         * value.c (complete_internalvar): Likewise.
5027
5028 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5029
5030         Add objfile property to gdb.Type.
5031         * NEWS: Mention Python API addition.
5032         * python/py-type.c (typy_get_objfile): New method.
5033
5034 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5035
5036         * NEWS: Mention the new set|show style [title|highlight].
5037         Mention changes to "show style", "help" and "apropos".
5038
5039 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5040
5041         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5042         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5043         instead of print_help_for_command.
5044         (print_doc_of_command): New function.
5045         (help_list): Add 'apropos -v word' suggestion.
5046         (print_help_for_command): Style the command name using title style.
5047         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5048         (_initialize_cli_cmds): Describe -v in apropos_command help.
5049
5050 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5051
5052         * cli/cli-style.h (cli_style_option): Add name in constructor,
5053         add m_name class member, add constructor with intensity,
5054         add name class function.
5055         (cli_style_option::add_setshow_commands): Remove name argument.
5056         (highlight_style, title_style): New styles.
5057         * cli/cli-style.c (do_show): New function that shows a style
5058         characteristic styling the style name with itself.
5059         (set_style_name): New function.
5060         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5061         Update all callers according to the changes in cli/cli-style.h.
5062         * utils.h (fputs_highlighted): New function.
5063         * utils.c (fputs_highlighted): Likewise.
5064
5065 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5066
5067         * NEWS: Mention new pipe command and new convenience variables.
5068
5069 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5070
5071         * cli/cli-cmds.c (pipe_command): New function.
5072         (_initialize_cli_cmds): Call add_com for pipe_command.
5073         Define | as an alias for pipe.
5074         (exit_status_set_internal_vars): New function.
5075         (shell_escape): Call exit_status_set_internal_vars.
5076         cli/cli-decode.c (find_command_name_length): Recognize | as
5077         a single character command.
5078
5079 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5080
5081         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5082         top.c (execute_command_to_ui_file): New function, mostly a copy
5083         of execute_command_to_string.
5084         (execute_command_to_string): Implement by calling
5085         execute_command_to_ui_file.
5086
5087 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5088
5089         * top.h (saved_command_line): Remove declaration.
5090         * top.c (previous_saved_command_line, previous_repeat_arguments):
5091         New variables.
5092         (saved_command_line): Make static, define together with other
5093         'repeat variables'.
5094         (dont_repeat): Clear repeat_arguments.
5095         (repeat_previous, get_saved_command_line, save_command_line):
5096         New functions.
5097         (gdb_init): Initialize saved_command_line
5098         and previous_saved_command_line.
5099         * main.c (captured_main_1): Remove saved_command_line initialization.
5100         * event-top.c (handle_line_of_input): Update to use
5101         the new 'repeat' related functions instead of direct access to
5102         saved_command_line.
5103         * command.h (repeat_previous, get_saved_command_line,
5104         save_command_line): New declarations.
5105         (dont_repeat): Add comment.
5106
5107 2019-05-30  Tom Tromey  <tromey@adacore.com>
5108
5109         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5110         Fix comment.
5111         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5112
5113 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5114
5115         PR cli/24587
5116         * completer.c (complete): Initialize variable word.
5117
5118 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5119
5120         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5121         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5122         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5123         'body' is NULL to the outter 'if', protecting the '!is_define'
5124         situation as well.
5125
5126 2019-05-29  Tom Tromey  <tromey@adacore.com>
5127
5128         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5129         (dwarf_unknown): New function.
5130         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5131         (dwarf_type_encoding_name): Use dwarf_unknown.
5132
5133 2019-05-29  Tom Tromey  <tromey@adacore.com>
5134
5135         PR c++/20020:
5136         * cp-valprint.c (cp_print_value_fields): Call
5137         cp_print_static_field inside "try".
5138
5139 2019-05-29  Tom Tromey  <tromey@adacore.com>
5140
5141         * inflow.c (struct terminal_info): Add default operator=.
5142         * configure: Rebuild.
5143         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5144         -Wdeprecated-copy-dtor, -Wredundant-move.
5145
5146 2019-05-29  Tom Tromey  <tromey@adacore.com>
5147
5148         * NEWS: Add entry.
5149         * infcmd.c (print_return_value_1): Handle finish_print
5150         option.
5151         (show_print_finish): New function.
5152         (_initialize_infcmd): Add "set/show print finish" commands.
5153         * valprint.c (user_print_options): Initialize new member.
5154         * valprint.h (struct value_print_options) <finish_print>: New
5155         member.
5156
5157 2019-05-28  Tom Tromey  <tromey@adacore.com>
5158
5159         * ada-lang.c (ada_remove_Xbn_suffix)
5160         (find_old_style_renaming_symbol)
5161         (parse_old_style_renaming): Remove.
5162         (ada_find_renaming_symbol): Don't call
5163         find_old_style_renaming_symbol.
5164         (ada_is_renaming_symbol): Rename from
5165         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5166         bool.  Now static.
5167         (ada_read_var_value): Update and simplify.
5168         * ada-exp.y (write_var_or_type): Remove old code.
5169
5170 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5171
5172         * event-top.c: Remove include comment.
5173         * inflow.c (class scoped_ignore_sigttou): Move from here...
5174         * inflow.h (class scoped_ignore_sigttou): ...to here.
5175         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5176         * top.c:  Remove include comment.
5177
5178 2019-05-27  Tom Tromey  <tom@tromey.com>
5179
5180         * NEWS: Fix typo.
5181
5182 2019-05-22  Tom Tromey  <tromey@adacore.com>
5183
5184         * target.c (target_follow_exec): Constify parameter.
5185         * target-delegates.c: Rebuild.
5186         * remote.c (remote_target::follow_exec): Constify parameter.
5187         * infrun.c (follow_exec): Constify parameter.
5188         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5189         (target_follow_exec): Likewise.
5190
5191 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5192
5193         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5194         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5195
5196 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5197
5198         * NEWS: Add debugredirect and testsuite sections.
5199
5200 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5201
5202         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5203         target descriptions using exclusively floating point register name
5204         aliases.
5205
5206 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5207
5208         PR gdb/18644:
5209         * f-lang.c (build_fortran_types): Handle the case where
5210         gdbarch_floatformat_for_type returns a nullptr.
5211
5212 2019-05-21  Tom de Vries  <tdevries@suse.de>
5213
5214         PR cli/24587
5215         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5216
5217 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         PR gdb/18644:
5220         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5221         16-byte floats.
5222         * i386-tdep.c (i386_floatformat_for_type): Use
5223         floatformats_ia64_quad for the 16-byte floating point component
5224         within a fortran 32-byte complex number.
5225
5226 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5227
5228         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5229         delete default constructor.
5230         (find_partial_die): Update to return const struct.
5231         (partial_die_parent_scope): Move variable declaration into scope
5232         of its use and change its type to auto.
5233         (guess_partial_die_structure_name): Likewise.
5234         (partial_die_info::fixup): Likewise.
5235
5236 2019-05-17  Tom Tromey  <tromey@adacore.com>
5237
5238         * source.c (find_and_open_source): Remove cast.
5239
5240 2019-05-17  Tom Tromey  <tromey@adacore.com>
5241
5242         * annotate.c (annotate_source): Make "filename" const.
5243         * annotate.h (annotate_source): Use const.
5244
5245 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5246
5247         * disasm.c (set_disassembler_options): Send errors to stderr.
5248
5249 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5250
5251         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5252         (cli_interp_base::set_logging): Check debug_redirect.
5253         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5254         * cli/cli-logging.c (debug_redirect): Add static variable.
5255         (pop_output_files): Add default param.
5256         (handle_redirections): Print debug setting.
5257         (show_logging_command): Likewise.
5258         (_initialize_cli_logging): Add debugredirect command.
5259         * interps.c (current_interp_set_logging): Add debug_redirect
5260         parameter.
5261         * interps.h (set_logging): Add debug_redirect parameter.
5262         (current_interp_set_logging): Likewise.
5263         * mi/mi-common.h: Likewise.
5264         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5265
5266 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5267             Tom Tromey  <tromey@adacore.com>
5268
5269         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5270         directly.
5271         * cli/cli-interp.h (make_logging_output): Remove declaration.
5272         * cli/cli-logging.c (make_logging_output): Remove function.
5273         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5274         directly.
5275         * ui-file.c (tee_file::tee_file): Remove bools.
5276         (tee_file::~tee_file): Remove deletes.
5277         * ui-file.h (tee_file): Remove bools.
5278
5279 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5280
5281         * mi/mi-cmds.h (mi_cmd_complete): New function.
5282         * mi/mi-main.c (mi_cmd_complete): Likewise.
5283         * mi/mi-cmds.c: Define new MI command -complete.
5284         * NEWS: Mention new -complete command.
5285
5286 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5287
5288         * completer.h (complete): New function.
5289         * completer.c (complete): Likewise.
5290         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5291         function defined in completer.h.
5292
5293 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5294
5295         * MAINTAINERS (Write After Approval): Add myself.
5296
5297 2019-05-17  Tom de Vries  <tdevries@suse.de>
5298
5299         PR gdb/24094
5300         * dwarf2read.c (struct cu_partial_die_info): New struct.
5301         (find_partial_die): Return cu_partial_die_info.
5302         (partial_die_parent_scope, guess_partial_die_structure_name)
5303         (partial_die_info::fixup): Handle new return type of find_partial_die.
5304
5305 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5306
5307         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5308         "std::string", simplifying the algorithm.
5309
5310 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5311
5312         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5313         (stap_static_probe_ops::get_probes): Likewise.
5314
5315 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5316
5317         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5318         '-')" and "else if".
5319         (stap_parse_single_operand): Join checks for
5320         "gdbarch_stap_parse_special_token_p" and
5321         "gdbarch_stap_parse_special_token" in the same "if" statement.
5322         Invert check when verifying for operation on register
5323         displacement.
5324
5325 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5326
5327         * stap-probe.c (stap_get_opcode): Update comment.
5328         (stap_get_expected_argument_type): Likewise.
5329         (handle_stap_probe): Likewise.
5330
5331 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5332
5333         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5334         return type to 'bool'.  Adjust comment.  Use 'bool' when
5335         appropriate.
5336         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5337         * stap-probe.c (stap_parse_argument_1): Likewise.
5338         (stap_is_operator): Likewise.
5339         (stap_is_generic_prefix): Likewise.
5340         (stap_is_register_prefix): Likewise.
5341         (stap_is_register_indirection_prefix): Likewise.
5342         (stap_is_integer_prefix): Likewise.
5343         (stap_generic_check_suffix): Likewise.
5344         (stap_check_integer_suffix): Likewise.
5345         (stap_check_register_suffix): Likewise.
5346         (stap_check_register_indirection_suffix): Likewise.
5347         (stap_parse_register_operand): Likewise.
5348         (stap_parse_single_operand): Likewise.
5349         (stap_parse_argument_1): Likewise.
5350         (stap_probe::get_argument_count): Likewise.
5351         (stap_is_operator): Likewise.
5352
5353 2019-05-16  Tom Tromey  <tromey@adacore.com>
5354
5355         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5356         keyword to foreach.
5357
5358 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5359
5360         * linux-thread-db.c (try_thread_db_load_1): Change return type
5361         to bool.
5362         (try_thread_db_load): Likewise.
5363         (try_thread_db_load_from_pdir_1): Likewise.
5364         (try_thread_db_load_from_pdir): Likewise.
5365         (try_thread_db_load_from_sdir): Likewise.
5366         (try_thread_db_load_from_dir): Likewise.
5367         (thread_db_load_search): Likewise.
5368         (has_libpthread): Likewise.
5369         (thread_db_load): Likewise.
5370
5371 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5372
5373         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5374         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5375         NULL, and complain/return if that's the case.
5376
5377 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5378
5379         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5380         (advance, posn, abstract_read_memory): New functions.
5381         [struct mem_read_abstraction]: New struct.
5382         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5383
5384 2019-05-14  Tom Tromey  <tromey@adacore.com>
5385
5386         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5387         value is not lval_memory.
5388
5389 2019-05-14  Tom Tromey  <tromey@adacore.com>
5390
5391         * solib.c (info_sharedlibrary_command): Style the file name.
5392
5393 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5394
5395         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5396         (aarch64_vnv_type): Likewise.
5397         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5398         * common/tdesc.c: Likewise.
5399         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5400         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5401         * features/aarch64-fpu.xml: Add ieee half view.
5402         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5403         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5404         * gdbtypes.h (struct builtin_type): Likewise.
5405         (struct objfile_type): Likewise.
5406
5407 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5408
5409         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5410         typo.
5411         * location.h (string_to_event_location): Likewise.
5412
5413 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5414
5415         GDB 8.3 released.
5416
5417 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5418
5419         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5420         New variable declaration.
5421         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5422         New variable.
5423         (print_one_breakpoint): Use ui_out::test_flags and new global
5424         variable to compute use_fixed_output.
5425         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5426         Remove.
5427         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5428         (mi_multi_location_breakpoint_output_fixed): Remove.
5429         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5430         new variable.
5431         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5432         fix_multi_location_breakpoint_output flag if version >= 3.
5433         * ui-out.h (enum ui_out_flag)
5434         <fix_multi_location_breakpoint_output>: New enumerator.
5435
5436 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5437
5438         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5439
5440 2019-05-10  Tom Tromey  <tromey@adacore.com>
5441
5442         * ada-lang.c (catch_ada_completer): New function.
5443         (_initialize_ada_language): Use it.
5444
5445 2019-05-10  Tom Tromey  <tromey@adacore.com>
5446
5447         * thread.c (print_thread_info): Make "requested_threads" const.
5448         * gdbthread.h (print_thread_info): Make "requested_threads"
5449         const.
5450         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5451         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5452
5453 2019-05-08  Tom Tromey  <tom@tromey.com>
5454
5455         * gdbtypes.c (objfile_type_data): Change type.
5456         (objfile_type, _initialize_gdbtypes): Update.
5457
5458 2019-05-08  Tom Tromey  <tom@tromey.com>
5459
5460         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5461         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5462         (_initialize_dwarf2_frame): Update.
5463
5464 2019-05-08  Tom Tromey  <tom@tromey.com>
5465
5466         * objc-lang.c (objc_objfile_data): Change type.
5467         (find_methods): Update.
5468         (_initialize_objc_lang): Remove.
5469
5470 2019-05-08  Tom Tromey  <tom@tromey.com>
5471
5472         * stabsread.c (rs6000_builtin_type_data): Change type.
5473         (rs6000_builtin_type, _initialize_stabsread): Update.
5474
5475 2019-05-08  Tom Tromey  <tom@tromey.com>
5476
5477         * mips-tdep.c (mips_pdr_data): Remove.
5478         (_initialize_mips_tdep): Update.
5479
5480 2019-05-08  Tom Tromey  <tom@tromey.com>
5481
5482         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5483         (hppa_init_objfile_priv_data, read_unwind_info)
5484         (find_unwind_entry, _initialize_hppa_tdep): Update.
5485
5486 2019-05-08  Tom Tromey  <tom@tromey.com>
5487
5488         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5489         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5490         on obstack.
5491         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5492
5493 2019-05-08  Tom Tromey  <tom@tromey.com>
5494
5495         * mdebugread.c (basic_type_data): Change type.
5496         (basic_type, _initialize_mdebugread): Update.
5497
5498 2019-05-08  Tom Tromey  <tom@tromey.com>
5499
5500         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5501
5502 2019-05-08  Tom Tromey  <tom@tromey.com>
5503
5504         * nto-tdep.c (nto_inferior_data_reg): Change type.
5505         (nto_inferior_data): Update.
5506         (nto_inferior_data_cleanup, nto_new_inferior_data)
5507         (_initialize_nto_tdep): Remove.
5508         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5509
5510 2019-05-08  Tom Tromey  <tom@tromey.com>
5511
5512         * ada-lang.c (struct ada_inferior_data): Add initializers.
5513         (ada_inferior_data): Change type.
5514         (ada_inferior_data_cleanup): Remove.
5515         (get_ada_inferior_data, ada_inferior_exit)
5516         (struct ada_pspace_data): Add initializers, destructor.
5517         (ada_pspace_data_handle): Change type.
5518         (get_ada_pspace_data): Update.
5519         (ada_pspace_data_cleanup): Remove.
5520
5521 2019-05-08  Tom Tromey  <tom@tromey.com>
5522
5523         * coffread.c (struct coff_symfile_info): Add initializers.
5524         (coff_objfile_data_key): Move lower.  Change type.
5525         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5526         Update.
5527         (coff_free_info): Remove.
5528
5529 2019-05-08  Tom Tromey  <tom@tromey.com>
5530
5531         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5532         (fbsd_pspace_data_handle): Move lower.  Change type.
5533         (get_fbsd_pspace_data): Update.
5534         (fbsd_pspace_data_cleanup): Remove.
5535         (_initialize_fbsd_tdep): Update.
5536
5537 2019-05-08  Tom Tromey  <tom@tromey.com>
5538
5539         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5540         (get_ada_tasks_pspace_data): Update.
5541         (ada_tasks_pspace_data_cleanup): Remove.
5542         (_initialize_tasks): Update.
5543         (ada_tasks_inferior_data_handle): Change type.
5544         (get_ada_tasks_inferior_data): Update.
5545         (ada_tasks_inferior_data_cleanup): Remove.
5546         (struct ada_tasks_pspace_data): Add initializers.
5547
5548 2019-05-08  Tom Tromey  <tom@tromey.com>
5549
5550         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5551         * symfile-debug.c (debug_sym_get_probes): Change type.
5552         * stap-probe.c (handle_stap_probe):
5553         (stap_static_probe_ops::get_probes): Change type.
5554         * probe.h (class static_probe_ops) <get_probes>: Change type.
5555         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5556         (parse_probes_in_pspace): Update.
5557         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5558         Update.
5559         (any_static_probe_ops::get_probes): Change type.
5560         * elfread.c (elfread_data): New typedef.
5561         (probe_key): Change type.
5562         (elf_get_probes): Likewise.  Update.
5563         (probe_key_free): Remove.
5564         (_initialize_elfread): Update.
5565         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5566         Change type.
5567         (dtrace_process_dof_probe, dtrace_process_dof)
5568         (dtrace_static_probe_ops::get_probe): Change type.
5569
5570 2019-05-08  Tom Tromey  <tom@tromey.com>
5571
5572         * xcoffread.c (struct xcoff_symfile_info): Rename from
5573         coff_symfile_info.  Add initializers.
5574         (xcoff_objfile_data_key): Move lower.  Change type.
5575         (XCOFF_DATA): Rewrite.
5576         (xcoff_free_info): Remove.
5577         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5578         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5579         (xcoff_initial_scan): Update.
5580
5581 2019-05-08  Tom Tromey  <tom@tromey.com>
5582
5583         * solib-svr4.c (struct svr4_info): Add initializers and
5584         destructor.
5585         <probes_table>: Now an htab_up.
5586         (solib_svr4_pspace_data): Change type.
5587         (free_probes_table): Simplify.
5588         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5589         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5590         (probes_table_remove_objfile_probes, register_solib_event_probe)
5591         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5592         (_initialize_svr4_solib): Update.
5593
5594 2019-05-08  Tom Tromey  <tom@tromey.com>
5595
5596         * remote.c (remote_pspace_data): Change type.
5597         (remote_pspace_data_cleanup): Remove.
5598         (get_remote_exec_file, set_pspace_remote_exec_file)
5599         (_initialize_remote): Update.
5600
5601 2019-05-08  Tom Tromey  <tom@tromey.com>
5602
5603         * breakpoint.c (breakpoint_objfile_key): Change type.
5604         (get_breakpoint_objfile_data): Update.
5605         (free_breakpoint_objfile_data): Remove.
5606         (_initialize_breakpoint): Update.
5607
5608 2019-05-08  Tom Tromey  <tom@tromey.com>
5609
5610         * linux-tdep.c (struct linux_info): Add initializers.
5611         (linux_inferior_data): Move.  Change type.
5612         (invalidate_linux_cache_inf): Update.
5613         (linux_inferior_data_cleanup): Remove.
5614         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5615
5616 2019-05-08  Tom Tromey  <tom@tromey.com>
5617
5618         * auxv.c (auxv_inferior_data): Move.  Change type.
5619         (auxv_inferior_data_cleanup): Remove.
5620         (invalidate_auxv_cache_inf): Rewrite.
5621         (get_auxv_inferior_data, _initialize_auxv): Update.
5622
5623 2019-05-08  Tom Tromey  <tom@tromey.com>
5624
5625         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5626         (symfile_debug_objfile_data_key): Change type.
5627         (symfile_debug_installed, debug_qf_has_symbols)
5628         (debug_qf_find_last_source_symtab)
5629         (debug_qf_forget_cached_source_info)
5630         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5631         (debug_qf_print_stats, debug_qf_dump)
5632         (debug_qf_expand_symtabs_for_function)
5633         (debug_qf_expand_all_symtabs)
5634         (debug_qf_expand_symtabs_with_fullname)
5635         (debug_qf_map_matching_symbols)
5636         (debug_qf_expand_symtabs_matching)
5637         (debug_qf_find_pc_sect_compunit_symtab)
5638         (debug_qf_map_symbol_filenames)
5639         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5640         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5641         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5642         (debug_sym_read_linetable, debug_sym_relocate): Update.
5643         (symfile_debug_free_objfile): Remove.
5644         (install_symfile_debug_logging, _initialize_symfile_debug):
5645         Update.
5646
5647 2019-05-08  Tom Tromey  <tom@tromey.com>
5648
5649         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5650         allocate_on_obstack.
5651         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5652         (get_dwarf2_per_objfile): Update.
5653         (set_dwarf2_per_objfile): Remove.
5654         (dwarf2_has_info, dwarf2_get_section_info): Update.
5655         (dwarf2_free_objfile): Remove.
5656         (_initialize_dwarf2_read): Update.
5657
5658 2019-05-08  Tom Tromey  <tom@tromey.com>
5659
5660         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5661         initializers.
5662         <unsupported_script_warning_printed,
5663         script_not_found_warning_printed>: Now bool.
5664         (auto_load_pspace_data): Change type.
5665         (~auto_load_pspace_info): Rename from
5666         auto_load_pspace_data_cleanup.
5667         (get_auto_load_pspace_data, init_loaded_scripts_info)
5668         (clear_section_scripts, maybe_print_unsupported_script_warning)
5669         (maybe_print_script_not_found_warning, _initialize_auto_load):
5670         Update.
5671
5672 2019-05-08  Tom Tromey  <tom@tromey.com>
5673
5674         * objfiles.c (objfile_pspace_info): Add destructor and
5675         initializers.
5676         (objfiles_pspace_data): Change type.
5677         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5678         (get_objfile_pspace_data): Update.
5679         (objfiles_bfd_data): Change type.
5680         (get_objfile_bfd_data): Update.
5681         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5682
5683 2019-05-08  Tom Tromey  <tom@tromey.com>
5684
5685         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5686         Change type.
5687         (get_catch_syscall_inferior_data): Update.
5688         (catch_syscall_inferior_data_cleanup): Remove.
5689         (_initialize_break_catch_syscall): Update.
5690
5691 2019-05-08  Tom Tromey  <tom@tromey.com>
5692
5693         * inflow.c (struct terminal_info): Add destructor and
5694         initializers.
5695         (inflow_inferior_data): Change type.
5696         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5697         (get_inflow_inferior_data, inflow_inferior_exit)
5698         (swap_terminal_info, _initialize_inflow): Update.
5699
5700 2019-05-08  Tom Tromey  <tom@tromey.com>
5701
5702         * target-dcache.c (target_dcache_cleanup): Remove.
5703         (target_dcache_aspace_key): Change type.
5704         (target_dcache_init_p, target_dcache_invalidate)
5705         (target_dcache_get, target_dcache_get_or_init)
5706         (_initialize_target_dcache): Update.
5707         * dcache.h (struct dcache_deleter): New.
5708
5709 2019-05-08  Tom Tromey  <tom@tromey.com>
5710
5711         * symtab.c (struct symbol_cache): Add destructor and
5712         initializers.
5713         (symbol_cache_key): Move.  Change type.
5714         (make_symbol_cache, free_symbol_cache): Remove.
5715         (get_symbol_cache): Update.
5716         (symbol_cache_cleanup): Remove.
5717         (ALL_PSPACES, symbol_cache_flush)
5718         (maintenance_print_symbol_cache)
5719         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5720         Update.
5721
5722 2019-05-08  Tom Tromey  <tom@tromey.com>
5723
5724         * symtab.c (struct main_info): Add destructor and initializers.
5725         (main_progspace_key): Move.  Change type.
5726         (get_main_info): Update.
5727         (main_info_cleanup): Remove.
5728         (_initialize_symtab): Update.
5729
5730 2019-05-08  Tom Tromey  <tom@tromey.com>
5731
5732         * registry.h (DECLARE_REGISTRY): Define the _key class.
5733
5734 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5735
5736         * NEWS: Merge two 'New commands' sections.
5737
5738 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5739
5740         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5741         parameter and use Ada language definition instead.
5742         (ada_val_print_ptr): Remove unused language parameter.
5743         (ada_val_print_num): Remove language parameter and use Ada language
5744         definition instead.
5745         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5746         parameter.
5747         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5748         parameter and use Ada language definition instead.
5749         (ada_val_print_1): Update all ada_val_print_xxx calls.
5750         Remove language parameter.
5751         (ada_val_print): Update ada_val_print_1 call.
5752
5753 2019-05-08  Tom Tromey  <tromey@adacore.com>
5754
5755         * remote.c (remote_hw_watchpoint_limit)
5756         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5757         Now static.
5758
5759 2019-05-08  Tom Tromey  <tromey@adacore.com>
5760
5761         * maint.c (_initialize_maint_cmds): Move initialization code to
5762         remote.c.
5763         (watchdog, show_watchdog): Move to remote.c.
5764         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5765         "watchdog" static.
5766         (_initialize_remote): Move initialization code from maint.c.
5767         * defs.h (watchdog): Don't declare.
5768
5769 2019-05-08  Tom Tromey  <tromey@adacore.com>
5770
5771         * tui/tui-interp.c: Include main.h.
5772         * interps.c: Include main.h.
5773         * main.h (interpreter_p): Declare.
5774         * defs.h (interpreter_p): Don't declare.
5775
5776 2019-05-08  Tom Tromey  <tromey@adacore.com>
5777
5778         * dwarf2loc.c: Include dwarf2read.h.
5779         * defs.h (read_unsigned_leb128): Don't declare.
5780         * dwarf2read.h (read_unsigned_leb128): Declare.
5781
5782 2019-05-08  Tom Tromey  <tromey@adacore.com>
5783
5784         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5785         method.
5786
5787 2019-05-08  Tom Tromey  <tromey@adacore.com>
5788
5789         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5790         when no wrap column is set.
5791
5792 2019-05-08  Tom Tromey  <tromey@adacore.com>
5793
5794         * c-lang.c (c_get_string): Handle non-C-style arrays.
5795
5796 2019-05-08  Tom Tromey  <tromey@adacore.com>
5797
5798         * typeprint.c (print_offset_data::update): Print the bit offset,
5799         not the number of bits remaining.
5800
5801 2019-05-08  Tom Tromey  <tromey@adacore.com>
5802
5803         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5804         padding at end of comment.
5805
5806 2019-05-08  Tom Tromey  <tromey@adacore.com>
5807
5808         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5809         Compare main types.
5810
5811 2019-05-06  Tom Tromey  <tom@tromey.com>
5812
5813         * common/scoped_mmap.c: Include common-defs.h.
5814         * common/scoped_mmap.h: Don't include config.h.
5815
5816 2019-05-04  Tom Tromey  <tom@tromey.com>
5817
5818         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5819         (struct aarch64_call_info): Add initializers.
5820         <si>: Now a std::vector.
5821         (pass_on_stack, aarch64_push_dummy_call): Update.
5822
5823 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5824             Tom Tromey  <tom@tromey.com>
5825
5826         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5827         (ppc_threads): Now a std::vector.  Now static.
5828         (hwdebug_find_thread_points_by_tid)
5829         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5830         Update.
5831
5832 2019-05-04  Tom Tromey  <tom@tromey.com>
5833
5834         * arc-tdep.c (arc_tdesc_init): Return bool.
5835
5836 2019-05-04  Tom Tromey  <tom@tromey.com>
5837
5838         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5839         Use gdb_assert_not_reached.
5840
5841 2019-05-04  Tom Tromey  <tom@tromey.com>
5842
5843         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5844         "false".
5845
5846 2019-05-04  Tom Tromey  <tom@tromey.com>
5847
5848         * arc-tdep.c (arc_tdesc_init): Use bool.
5849
5850 2019-05-04  Tom Tromey  <tom@tromey.com>
5851
5852         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5853
5854 2019-05-04  Tom Tromey  <tom@tromey.com>
5855
5856         * cli/cli-cmds.c (valid_command_p): Return bool.
5857
5858 2019-05-04  Tom Tromey  <tom@tromey.com>
5859
5860         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5861         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5862
5863 2019-05-04  Raul Tambre  <raul@tambre.ee>
5864
5865         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5866         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5867         operator for comparison.
5868
5869 2019-05-04  Tom Tromey  <tom@tromey.com>
5870
5871         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5872         (lookup_partial_symbol, print_partial_symbols)
5873         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5874         (psymbol_compare): Update.
5875         (add_psymbol_to_bcache): Clear the entire psymbol.
5876         (maintenance_check_psymtabs): Update.
5877         * psympriv.h (struct partial_symbol): Don't derive from
5878         general_symbol_info.
5879         <obj_section, unrelocated_address, address,
5880         set_unrelocated_address>: Update.
5881         <ginfo>: New member.
5882         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5883         (debug_names::write_psymbols): Update.
5884
5885 2019-05-04  Tom de Vries  <tdevries@suse.de>
5886
5887         * contrib/cc-with-tweaks.sh: Support -n arg.
5888
5889 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5890
5891         * corelow.c (core_target::detach): Ensure frame cache and
5892         register caches are cleared.
5893         inferior.c (exit_inferior_1): Likewise.
5894
5895 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5896             Tom Tromey  <tom@tromey.com>
5897
5898         * dictionary.c (collate_pending_symbols_by_language): Remove
5899         "struct" from foreach.
5900         * symtab.c (lookup_global_symbol_from_objfile)
5901         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5902         foreach.
5903         * ser-tcp.c (net_open): Remove "struct" from foreach.
5904         * objfiles.c (objfile_relocate, objfile_rebase)
5905         (objfile_has_symbols): Remove "struct" from foreach.
5906         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5907         from foreach.
5908         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5909         foreach.
5910         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5911         "struct" from foreach.
5912         * ada-lang.c (create_excep_cond_exprs)
5913         (ada_exception_catchpoint_cond_string): Remove "struct" from
5914         foreach.
5915
5916 2019-05-03  Tom Tromey  <tromey@adacore.com>
5917
5918         * ada-exp.y (convert_char_literal): Check suffix of each
5919         enumerator.
5920
5921 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5922
5923         PR ada/21406:
5924         * ada-exp.y (yywrap): Don't define.
5925         * ada-lex.l (%option): Add noyywrap
5926         (yywrap): Remove.
5927
5928 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5929
5930         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5931         _WIN32_WINNT to the XP level, unless already defined to a higher
5932         level.
5933
5934         * unittests/parse-connection-spec-selftests.c:
5935         * ser-tcp.c:
5936         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5937         override.
5938
5939         * symfile.c (find_separate_debug_file): Remove colon from the
5940         drive spec of DOS/Windows file names of the target, so that the
5941         file name produced from DEBUGDIR and the target's directory will
5942         be valid on DOS/Windows systems.
5943
5944 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5945
5946         * rust-lang.c (val_print_struct): Handle printing structures
5947         containing strings.
5948
5949 2019-05-02  Tom Tromey  <tromey@adacore.com>
5950
5951         * valarith.c (_initialize_valarith): Remove.
5952
5953 2019-05-01  Tom Tromey  <tromey@adacore.com>
5954
5955         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5956         bitfields.
5957
5958 2019-05-01  Tom Tromey  <tromey@adacore.com>
5959
5960         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5961         for big-endian copies.
5962
5963 2019-04-30  Ali Tamur  <tamur@google.com>
5964         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5965         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5966         (read_3_bytes): New function.
5967
5968 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5969
5970         * windows-nat.c (main_thread_id): Delete.
5971         (handle_output_debug_string): Replace main_thread_id by
5972         current_event.dwThreadId.
5973         (fake_create_process): Likewise.
5974         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5975         Do not set main_thread_id.
5976         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5977         current_event.dwThreadId.
5978         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5979
5980 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5981
5982         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5983         Use current_event.dwThreadId instead of main_thread_id.
5984
5985 2019-04-30  Tom Tromey  <tromey@adacore.com>
5986
5987         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5988         (create_excep_cond_exprs): Iterate over program spaces.
5989         (ada_exception_catchpoint_cond_string): Examine all minimal
5990         symbols for exception types.
5991
5992 2019-04-30  Tom Tromey  <tromey@adacore.com>
5993
5994         PR c++/24470:
5995         * dwarf2read.c (process_structure_scope): Handle case where type
5996         has template parameters but no symbol was created.
5997
5998 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5999             Chris January  <chris.january@arm.com>
6000
6001         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6002         qualifier.
6003         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6004
6005 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6006
6007         * f-typeprint.c (f_print_type): Update rules for printing
6008         whitespace.
6009         (f_type_print_varspec_suffix): Likewise.
6010
6011 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6012             Chris January  <chris.january@arm.com>
6013
6014         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6015         function arguments.
6016
6017 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6018
6019         * f-lang.c (build_fortran_types): Change name of void type to
6020         lower case.
6021         * f-typeprint.c (f_type_print_base): Print the name of the void
6022         type, rather than a fixed string.
6023         * f-valprint.c (f_decorations): Use lower case void string.
6024
6025 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6026             Chris January  <chris.january@arm.com>
6027
6028         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6029         types for Fortran.
6030
6031 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6032             Chris January  <chris.january@arm.com>
6033             David Lecomber  <david.lecomber@arm.com>
6034
6035         * f-exp.y (BINOP_INTRINSIC): New token.
6036         (exp): New parser rule handling BINOP_INTRINSIC.
6037         (f77_keywords): Add new builtin procedures.
6038         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6039         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6040         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6041         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6042         (print_unop_subexp_f): New function.
6043         (print_binop_subexp_f): New function.
6044         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6045         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6046         (dump_subexp_body_f): Likewise.
6047         (operator_check_f): Likewise.
6048         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6049         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6050
6051 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6052
6053         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6054         UNOP_KIND.
6055         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6056         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6057         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6058         (operator_length_f): New fuction.
6059         (print_subexp_f): New function.
6060         (op_name_f): New function.
6061         (dump_subexp_body_f): New function.
6062         (operator_check_f): New function.
6063         (exp_descriptor_f): Replace standard expression handling functions
6064         with new functions.
6065         * gdb/fortran-operator.def: New file.
6066         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6067         * gdb/std-operator.def: Remove UNOP_KIND.
6068
6069 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6070
6071         * std-operator.def: Remove unbalanced, stray double quote
6072         character.
6073
6074 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6075             Chris January  <chris.january@arm.com>
6076             Daniel Everett  <daniel.everett@arm.com>
6077             Nick Forrington  <nick.forrington@arm.com>
6078             Richard Bunt  <richard.bunt@arm.com>
6079
6080         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6081         of depth when printing anonymous structs or unions.
6082         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6083         Don't print either the top-level value, or the children if the
6084         max-depth is exceeded.
6085         (ppscm_print_children): When printing the key of a map, allow one
6086         extra level of depth.
6087         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6088         print either the top-level value, or the children if the max-depth
6089         is exceeded.
6090         (print_children): When printing the key of a map, allow one extra
6091         level of depth.
6092         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6093         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6094         (user_print_options): Initialise max_depth field.
6095         (val_print_scalar_or_string_type_p): New function.
6096         (val_print): Check to see if the max depth has been reached.
6097         (val_print_check_max_depth): Define new function.
6098         (show_print_max_depth): New function.
6099         (_initialize_valprint): Add 'print max-depth' option.
6100         * valprint.h (struct value_print_options) <max_depth>: New field.
6101         (val_print_check_max_depth): Declare new function.
6102         * NEWS: Document new feature.
6103
6104 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6105
6106         * ada-lang.c (ada_language_defn): Initialise new field.
6107         * c-lang.c (c_is_string_type_p): New function.
6108         (c_language_defn): Initialise new field.
6109         (cplus_language_defn): Initialise new field.
6110         (asm_language_defn): Initialise new field.
6111         (minimal_language_defn): Initialise new field.
6112         * c-lang.h (c_is_string_type_p): Declare new function.
6113         * d-lang.c (d_language_defn): Initialise new field.
6114         * f-lang.c (f_is_string_type_p): New function.
6115         (f_language_defn): Initialise new field.
6116         * go-lang.c (go_is_string_type_p): New function.
6117         (go_language_defn): Initialise new field.
6118         * language.c (default_is_string_type_p): New function.
6119         (unknown_language_defn): Initialise new field.
6120         (auto_language_defn): Initialise new field.
6121         * language.h (struct language_defn) <la_is_string_type_p>: New
6122         member variable.
6123         (default_is_string_type_p): Declare new function.
6124         * m2-lang.c (m2_language_defn): Initialise new field.
6125         * objc-lang.c (objc_language_defn): Initialise new field.
6126         * opencl-lang.c (opencl_language_defn): Initialise new field.
6127         * p-lang.c (pascal_is_string_type_p): New function.
6128         (pascal_language_defn): Initialise new field.
6129         * rust-lang.c (rust_is_string_type_p): New function.
6130         (rust_language_defn): Initialise new field.
6131
6132 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6133
6134         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6135         New field.
6136         * ada-lang.c (ada_language_defn): Initialise new field.
6137         * c-lang.c (c_language_defn): Likewise.
6138         (cplus_language_defn): Likewise.
6139         (asm_language_defn): Likewise.
6140         (minimal_language_defn): Likewise.
6141         * d-lang.c (d_language_defn): Likewise.
6142         * f-lang.c (f_language_defn): Likewise.
6143         * go-lang.c (go_language_defn): Likewise.
6144         * language.c (unknown_language_defn): Likewise.
6145         (auto_language_defn): Likewise.
6146         * m2-lang.c (m2_language_defn): Likewise.
6147         * objc-lang.c (objc_language_defn): Likewise.
6148         * opencl-lang.c (opencl_language_defn): Likewise.
6149         * p-lang.c (pascal_language_defn): Likewise.
6150         * rust-lang.c (rust_language_defn): Likewise.
6151
6152 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6153
6154         * ada-lang.c (ada_is_character_type): Change return type to bool.
6155         (ada_is_string_type): Likewise.
6156         * ada-lang.h (ada_is_character_type): Update declaration
6157         (ada_is_string_type): Likewise.
6158
6159 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6160
6161         Support style in 'frame|thread apply'
6162
6163         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6164         * record.c (record_start, record_stop): Update callers of
6165         execute_command_to_string with false.
6166         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6167         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6168         methods.
6169         (class string_file): New constructor with term_out parameter.
6170         Override methods term_out and can_emit_style_escape.  New member
6171         term_out.
6172         (class stdio_file): Override can_emit_style_escape.
6173         (class tee_file): Override term_out and can_emit_style_escape.
6174         * utils.h (can_emit_style_escape): Remove.
6175         * utils.c (can_emit_style_escape): Likewise.
6176         Update all callers of can_emit_style_escape (SOMESTREAM) to
6177         SOMESTREAM->can_emit_style_escape.
6178         * source-cache.c (source_cache::get_source_lines): Likewise.
6179         * stack.c (frame_apply_command_count): Call execute_command_to_string
6180         passing the term_out characteristic of the current gdb_stdout.
6181         * thread.c (thr_try_catch_cmd): Likewise.
6182         * top.c (execute_command_to_string): pass term_out parameter
6183         to construct the string_file for the command output.
6184         * ui-file.c (term_cli_styling): New function (most code moved
6185         from utils.c can_emit_style_escape).
6186         (string_file::string_file, string_file::can_emit_style_escape,
6187         stdio_file::can_emit_style_escape, tee_file::term_out,
6188         tee_file::can_emit_style_escape): New functions.
6189
6190 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6191
6192         * NEWS: Mention the new set|show may-call-functions.
6193         * infcall.c (may_call_functions_p): New variable.
6194         (show_may_call_functions_p): New function.
6195         (call_function_by_hand_dummy): Throws an error if not
6196         may-call-functions.
6197         (_initialize_infcall): Call add_setshow_boolean_cmd for
6198         may-call-functions.
6199
6200 2019-04-25  Keith Seitz  <keiths@redhat.com>
6201
6202         PR c++/24367
6203         * cp-support.c (inspect_type): Don't attempt substitutions
6204         of symbol with the same name.
6205
6206 2019-04-25  Tom Tromey  <tromey@adacore.com>
6207
6208         PR gdb/24475:
6209         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6210         static.
6211
6212 2019-04-25  Tom Tromey  <tromey@adacore.com>
6213
6214         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6215         rvalue reference.
6216         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6217         (gdb_xml_parser::parse): Use std::move.
6218         * python/python-internal.h (gdbpy_convert_exception): Take a const
6219         reference.
6220         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6221         std::move.
6222         * python/py-utils.c (gdbpy_convert_exception): Take a const
6223         reference.
6224         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6225         Use std::move.
6226         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6227         Use std::move.
6228         * mi/mi-main.c (mi_print_exception): Take a const reference.
6229         * main.c (handle_command_errors): Take a const reference.
6230         * linespec.c (parse_linespec): Use std::move.
6231         * infcall.c (run_inferior_call): Use std::move.
6232         (call_function_by_hand_dummy): Use std::move.
6233         * exec.c (try_open_exec_file): Use std::move.
6234         * exceptions.h (exception_print, exception_fprintf)
6235         (exception_print_same): Update.
6236         * exceptions.c (print_exception, exception_print)
6237         (exception_fprintf, exception_print_same): Change parameters to
6238         const reference.
6239         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6240         * common/new-op.c: Use std::move.
6241         * common/common-exceptions.h (struct gdb_exception): Add move
6242         constructor.
6243         (struct gdb_exception_error, struct gdb_exception_quit, struct
6244         gdb_quit_bad_alloc): Change constructor to move constructor.
6245         (throw_exception): Change parameter to rvalue reference.
6246         * common/common-exceptions.c (throw_exception): Take rvalue
6247         reference.
6248         * cli/cli-interp.c (safe_execute_command): Use std::move.
6249         * breakpoint.c (insert_bp_location, location_to_sals): Use
6250         std::move.
6251
6252 2019-04-25  Tom Tromey  <tromey@adacore.com>
6253
6254         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6255         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6256         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6257         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6258         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6259         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6260         guile/scm-value.c: Use unpack.
6261         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6262         gdbscm_gdb_exception.
6263         (gdbscm_throw_gdb_exception): Likewise.
6264         (struct gdbscm_gdb_exception): New.
6265         (unpack): New function.
6266         (gdbscm_wrap): Use unpack.
6267
6268 2019-04-25  Tom Tromey  <tromey@adacore.com>
6269
6270         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6271         (gdb_rl_callback_handler): Use std::move.
6272         * common/common-exceptions.h (struct gdb_exception): Add move
6273         assignment operator.
6274         (throw_exception_sjlj): Change "exception" to const reference.
6275         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6276         (throw_exception_sjlj): Change "exception" to const reference.
6277
6278 2019-04-25  Tom Tromey  <tromey@adacore.com>
6279
6280         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6281         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6282         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6283         Update.
6284         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6285         Update.
6286         * mi/mi-interp.c (mi_interp::exec): Update.
6287         * linespec.c (parse_linespec): Update.
6288         * infcall.c (run_inferior_call): Update.
6289         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6290         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6291         (gdbscm_lookup_global_symbol): Update.
6292         * guile/scm-param.c (gdbscm_parameter_value): Update.
6293         * guile/scm-frame.c (gdbscm_frame_read_register)
6294         (gdbscm_frame_read_var): Update.
6295         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6296         * exec.c (try_open_exec_file): Update.
6297         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6298         (gdb_rl_callback_handler): Update.
6299         * common/common-exceptions.h (exception_none): Don't declare.
6300         * common/common-exceptions.c (exception_none): Don't define.
6301         (struct catcher) <exception>: Update.
6302         * cli/cli-interp.c (safe_execute_command): Update.
6303         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6304
6305 2019-04-25  Ali Tamur  <tamur@google.com>
6306
6307         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6308         (read_attribute_value): Likewise.
6309         (dwarf2_read_addr_index): Update comment.
6310         (read_str_index): Add DW_FORM_strx.
6311         (dwarf2_string_attr): Likewise.
6312         (dwarf2_const_value_attr): Likewise.
6313         (dump_die_shallow): Likewise.
6314         (dwarf2_fetch_constant_bytes): Likewise.
6315         (skip_form_bytes): Likewise.
6316         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6317
6318 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6319
6320         PR corefiles/11608
6321         PR corefiles/18187
6322         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6323         OFFSET.  Verify if current mapping contains an ELF header.
6324         (linux_find_memory_regions_full): Adjust call to
6325         dump_mapping_p.
6326
6327 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6328             Kang Li <kanglictf@gmail.com>
6329
6330         PR gdb/21600
6331
6332         * dwarf2-frame.c (read_initial_length): Be consistent about using
6333         unsigned representation of length.
6334         (decode_frame_entry_1): Likewise.  Check for wraparound of
6335         end pointer as well as buffer overflow.
6336
6337 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6338
6339         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6340         "vq".
6341
6342 2019-04-24  Tom Tromey  <tromey@adacore.com>
6343
6344         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6345
6346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6347
6348         * s12z-tdep.c (s12z_unwind_pc): Delete.
6349         (s12z_unwind_sp): Delete.
6350         (s12z_gdbarch_init): Don't register deleted functions with
6351         gdbarch.
6352
6353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6354
6355         * rl78-tdep.c (rl78_unwind_sp): Delete.
6356         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6357
6358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6361         (xstormy16_unwind_pc): Delete.
6362         (xstormy16_dummy_id): Delete.
6363         (xstormy16_gdbarch_init): Don't register deleted functions with
6364         gdbarch.
6365
6366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6367
6368         * vax-tdep.c (vax_unwind_pc): Delete.
6369         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6370
6371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6372
6373         * v850-tdep.c (v850_unwind_sp): Delete.
6374         (v850_unwind_pc): Delete.
6375         (v850_dummy_id): Delete.
6376         (v850_gdbarch_init): Don't register deleted functions with
6377         gdbarch.
6378
6379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6380
6381         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6382         (tilegx_unwind_pc): Delete.
6383         (tilegx_unwind_dummy_id): Delete.
6384         (tilegx_gdbarch_init): Don't register deleted functions with
6385         gdbarch.
6386
6387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6388
6389         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6390         (tic6x_dummy_id): Delete.
6391         (tic6x_gdbarch_init): Don't register deleted functions with
6392         gdbarch.
6393
6394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6395
6396         * sparc-tdep.c (sparc_unwind_pc): Delete.
6397         (sparc32_gdbarch_init): Don't register deleted function with
6398         gdbarch.
6399
6400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6401
6402         * sh-tdep.c (sh_unwind_sp): Delete.
6403         (sh_unwind_pc): Delete.
6404         (sh_dummy_id): Delete.
6405         (sh_gdbarch_init): Don't register deleted functions with
6406         gdbarch.
6407
6408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6409
6410         * score-tdep.c (score_unwind_sp): Delete.
6411         (score_unwind_pc): Delete.
6412         (score_dummy_id): Delete.
6413         (score_gdbarch_init): Don't register deleted functions with
6414         gdbarch.
6415
6416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6417
6418         * rx-tdep.c (rx_unwind_pc): Delete.
6419         (rx_unwind_sp): Delete.
6420         (rx_dummy_id): Delete.
6421         (rx_gdbarch_init): Don't register deleted functions with
6422         gdbarch.  Update comment.
6423
6424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6425
6426         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6427         (rs6000_dummy_id): Delete.
6428         (rs6000_gdbarch_init): Don't register deleted functions with
6429         gdbarch.
6430
6431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6432
6433         * or1k-tdep.c (or1k_dummy_id): Delete.
6434         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6435
6436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6437
6438         * nios2-tdep.c (nios2_dummy_id): Delete.
6439         (nios2_unwind_sp): Delete.
6440         (nios2_gdbarch_init): Don't register deleted functions with
6441         gdbarch.
6442
6443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6444
6445         * nds32-tdep.c (nds32_dummy_id): Delete.
6446         (nds32_unwind_pc): Delete.
6447         (nds32_unwind_sp): Delete.
6448         (nds32_gdbarch_init): Don't register deleted functions with
6449         gdbarch.
6450
6451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6452
6453         * msp430-tdep.c (msp430_unwind_pc): Delete.
6454         (msp430_unwind_sp): Delete.
6455         (msp430_dummy_id): Delete.
6456         (msp430_gdbarch_init): Don't register deleted functions with
6457         gdbarch.
6458
6459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6460
6461         * moxie-tdep.c (moxie_unwind_sp): Delete.
6462         (moxie_unwind_pc): Delete.
6463         (moxie_dummy_id): Delete.
6464         (moxie_gdbarch_init): Don't register deleted functions with
6465         gdbarch.
6466
6467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6470         (mn10300_unwind_pc): Delete.
6471         (mn10300_unwind_sp): Delete.
6472         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6473         mn10300_unwind_sp.
6474         (mn10300_frame_unwind_init): Don't register deleted functions with
6475         gdbarch.
6476
6477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6478
6479         * mep-tdep.c (mep_unwind_pc): Delete.
6480         (mep_unwind_sp): Delete.
6481         (mep_dummy_id): Delete.
6482         (mep_gdbarch_init): Don't register deleted functions with
6483         gdbarch.
6484
6485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6486
6487         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6488         (m68hc11_unwind_sp): Delete.
6489         (m68hc11_gdbarch_init): Don't register deleted functions with
6490         gdbarch.
6491
6492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6493
6494         * m32r-tdep.c (m32r_unwind_sp): Delete.
6495         (m32r_unwind_pc): Delete.
6496         (m32r_dummy_id): Delete.
6497         (m32r_gdbarch_init): Don't register deleted functions with
6498         gdbarch.
6499
6500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6501
6502         * m32c-tdep.c (m32c_unwind_pc): Delete.
6503         (m32c_unwind_sp): Delete.
6504         (m32c_dummy_id): Delete.
6505         (m32c_gdbarch_init): Don't register deleted functions with
6506         gdbarch.
6507
6508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6509
6510         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6511         (lm32_unwind_pc): Delete.
6512         (lm32_dummy_id): Delete.
6513         (lm32_gdbarch_init): Don't register deleted functions with
6514         gdbarch.
6515
6516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6517
6518         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6519         (iq2000_unwind_pc): Delete.
6520         (iq2000_dummy_id): Delete.
6521         (iq2000_gdbarch_init): Don't register deleted functions with
6522         gdbarch.
6523
6524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6525
6526         * nds32-tdep.c (nds32_type_align): Delete.
6527         (nds32_push_dummy_call): Use type_align instead.
6528
6529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6530
6531         * arm-tdep.c (arm_type_align): Only handle vector override case.
6532         (arm_push_dummy_call): Use type_align.
6533         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6534
6535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6536
6537         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6538         case.
6539         (pass_on_stack): Use type_align.
6540         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6541         function.
6542
6543 2019-04-23  Tom Tromey  <tromey@adacore.com>
6544
6545         * dwarf2read.c (line_header::file_name_at): Remove unused
6546         overload.
6547
6548 2019-04-23  Tom de Vries  <tdevries@suse.de>
6549
6550         PR gdb/24438
6551         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6552         invocation.
6553
6554
6555 2019-03-27  Ali Tamur  <tamur@google.com>
6556
6557         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6558         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6559         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6560         (dwarf_expr_context::get_addr_index): Likewise
6561         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6562         (symbol_needs_eval_context::get_addr_index): Likewise
6563         (disassemble_dwarf_expression): Add DW_OP_addrx
6564         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6565         (read_cutu_die_from_dwo): Update comment
6566         (skip_one_die): Add DW_FORM_addrx
6567         (read_attribute_value): Likewise
6568         (var_decode_location): Add DW_OP_addrx
6569         (dwarf2_const_value_attr): Add DW_FORM_addrx
6570         (dump_die_shallow): Likewise
6571         (dwarf2_fetch_constant_bytes): Likewise
6572         (decode_locdesc): Add DW_OP_addrx
6573         (skip_form_bytes): Add DW_FORM_addrx
6574
6575 2019-04-22  Ali Tamur  <tamur@google.com>
6576
6577         * MAINTAINERS (Write After Approval): Add self.
6578
6579 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6580
6581         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6582         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6583         (open_symbol_file_object): Likewise.
6584         (svr4_default_sos): Add info parameter.
6585         (svr4_read_so_list): Likewise.
6586         (svr4_current_sos_direct): Adjust functions calls to pass down
6587         info.
6588         (svr4_current_sos_1): Add info parameter.
6589         (svr4_current_sos): Call get_svr4_info, pass info down to
6590         svr4_current_sos_1.
6591         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6592         get_svr4_info.
6593         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6594         get_svr4_info.
6595         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6596         to get_svr4_info.
6597         (probes_table_remove_objfile_probes): Likewise.
6598         (register_solib_event_probe): Add info parameter.
6599         (solist_update_incremental): Pass info parameter down to
6600         svr4_read_so_list.
6601         (disable_probes_interface): Add info parameter.
6602         (svr4_handle_solib_event): Pass current_program_space to
6603         get_svr4_info.  Adjust disable_probes_interface cleanup.
6604         (svr4_create_probe_breakpoints): Add info parameter, pass it
6605         down to register_solib_event_probe.
6606         (svr4_create_solib_event_breakpoints): Add info parameter,
6607         pass it down to svr4_create_probe_breakpoints.
6608         (enable_break): Pass info down to
6609         svr4_create_solib_event_breakpoints.
6610         (svr4_solib_create_inferior_hook): Pass current_program_space to
6611         get_svr4_info.
6612         (svr4_clear_solib): Likewise.
6613
6614 2019-04-22  Pedro Alves  <palves@redhat.com>
6615
6616         * solib-svr4.c (svr4_free_objfile_observer): New.
6617         (probe_and_action::objfile): New field.
6618         (probes_table_htab_remove_objfile_probes)
6619         (probes_table_remove_objfile_probes): New functions.
6620         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6621         in the new probe_and_action.  Don't store the probe in 'lookup'.
6622         (svr4_create_probe_breakpoints): Pass objfile to
6623         register_solib_event_probe.
6624         (_initialize_svr4_solib): Register a free_objfile observer.
6625
6626 2019-04-19  Tom Tromey  <tom@tromey.com>
6627
6628         * common/queue.h: Remove.
6629
6630 2019-04-19  Tom Tromey  <tom@tromey.com>
6631
6632         * event-loop.c: Don't include "common/queue.h".
6633
6634 2019-04-19  Tom Tromey  <tom@tromey.com>
6635
6636         * remote.c (remote_target): Use delete.
6637         * remote-notif.h: Include <list>, not "common/queue.h".
6638         (notif_client_p): Remove typedef.
6639         (remote_notif_state): Add constructor, destructor, initializer.
6640         <notif_queue>: Now a std::list.
6641         (remote_notif_state_xfree): Don't declare.
6642         * remote-notif.c (remote_notif_process, handle_notification)
6643         (remote_notif_state_allocate): Update.
6644         (~remote_notif_state): Rename from remote_notif_state_xfree.
6645
6646 2019-04-19  Tom Tromey  <tom@tromey.com>
6647
6648         * symfile.c (reread_symbols): Update.
6649         * objfiles.c (objfile_register_static_link)
6650         (objfile_lookup_static_link): Update
6651         (~objfile) Don't delete static_links.
6652         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6653
6654 2019-04-19  Tom Tromey  <tom@tromey.com>
6655
6656         * type-stack.h (struct type_stack) <insert>: Constify string.
6657         * type-stack.c (type_stack::insert): Constify string.
6658         * gdbtypes.h (lookup_template_type): Update.
6659         (address_space_name_to_int): Update.
6660         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6661         const.
6662         (lookup_template_type): Make name const.
6663         * c-exp.y: Update rules.
6664         (lex_one_token, classify_name, classify_inner_name)
6665         (c_print_token): Update.
6666         * p-exp.y: Update rules.
6667         (yylex): Update.
6668         * f-exp.y: Update rules.
6669         (yylex): Update.
6670         * d-exp.y: Update rules.
6671         (lex_one_token, classify_name, classify_inner_name): Update.
6672         * parse.c (write_dollar_variable, copy_name): Return std::string.
6673         * parser-defs.h (copy_name): Change return type.
6674         * m2-exp.y: Update rules.
6675         (yylex): Update.
6676         * go-exp.y (lex_one_token): Update.
6677         Update rules.
6678         (classify_unsafe_function, classify_packaged_name)
6679         (classify_name, yylex): Update.
6680
6681 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6682
6683         * configure.ac: add --enable-source-highlight switch.
6684         * configure: Regenerate.
6685         * top.c (print_gdb_version): plumb --enable-source-highlight
6686         status to "show configuration".
6687
6688 2019-04-19  Tom Tromey  <tromey@adacore.com>
6689
6690         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6691         Check ADA_TYPE_P.
6692         (empty_record, ada_template_to_fixed_record_type_1)
6693         (template_to_static_fixed_type)
6694         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6695         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6696         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6697         macros.
6698
6699 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6700
6701         PR symtab/24423:
6702         * source.c (print_source_lines_base): Advance "iter" when a
6703         control character is seen.
6704
6705 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6706
6707         * inferior.h (struct infcall_suspend_state_deleter):
6708         Catch exception in destructor to avoid crash.
6709
6710 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6711
6712         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6713         close to the add_com "shell".
6714
6715 2019-04-18  Tom Tromey  <tromey@adacore.com>
6716
6717         * process-stratum-target.h (class process_stratum_target)
6718         <stratum>: Add "final".
6719
6720 2019-04-17  Tom Tromey  <tromey@adacore.com>
6721
6722         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6723         against nullptr before use.
6724
6725 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6726
6727         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6728
6729 2019-04-17  Jim Wilson  <jimw@sifive.com>
6730             Andrew Burgess  <andrew.burgess@embecosm.com>
6731
6732         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6733         code read might fail, assume 4-byte breakpoint in that case.
6734
6735 2019-04-15  Leszek Swirski  <leszeks@google.com>
6736
6737         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6738         rather than a hand-rolled POD check when checking for forced MEMORY
6739         classification.
6740
6741 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6742
6743         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6744         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6745         function.
6746         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6747         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6748         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6749         declaration.
6750
6751 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6752
6753         * aarch64-linux-nat.c
6754         (aarch64_linux_nat_target::thread_architecture): Add override.
6755         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6756         each VQ.
6757
6758 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6759
6760         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6761
6762 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6763
6764         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6765         target types of size 96-bits, add some additional comments, and
6766         check that the builtin type we found was the correct size.
6767
6768 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6769
6770         * utils.c (prompt_for_continue): Don't restore the styling at the
6771         end, as applied_style has the wrong value.  This fixes styling in
6772         long lists of file names that are interrupted by the "Continue?"
6773         prompt.
6774
6775 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6776
6777         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6778         * c-lang.c (c_language_defn): Likewise.
6779         (cplus_language_defn): Likewise.
6780         (asm_language_defn): Likewise.
6781         (minimal_language_defn): Likewise.
6782         * d-lang.c (d_language_defn): Likewise.
6783         * f-lang.c (f_language_defn): Likewise.
6784         * go-lang.c (go_language_defn): Likewise.
6785         * language.c (unknown_language_defn): Likewise.
6786         (auto_language_defn): Likewise.
6787         * language.h (struct language_defn): Remove la_magic field.
6788         (LANG_MAGIC): Delete.
6789         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6790         * objc-lang.c (objc_language_defn): Likewise.
6791         * opencl-lang.c (opencl_language_defn): Likewise.
6792         * p-lang.c (pascal_language_defn): Likewise.
6793         * rust-lang.c (rust_language_defn): Likewise.
6794
6795 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6796
6797         * riscv-tdep.c (riscv_type_align): New function.
6798         (riscv_type_alignment): Delete.
6799         (riscv_arg_location): Use 'type_align'.
6800         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6801
6802 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6803
6804         * gdbtypes.c (type_align): A struct with no non-static fields also
6805         has alignment of 1.
6806
6807 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6808
6809         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6810         component to 0.
6811         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6812         member.
6813         (riscv_struct_info::analyse): New implementation using new
6814         analyse_inner member function.
6815         (riscv_struct_info::field_offset): New member function.
6816         (riscv_struct_info::m_offsets): New member variable.
6817         (riscv_struct_info::analyse_inner): New private member function,
6818         takes the old implementation of riscv_struct_info::analyse but
6819         extended to track field offsets.
6820         (riscv_call_arg_struct): Update the struct folding special cases
6821         to handle cases where empty C++ structs, which are non-zero
6822         length, are found.
6823         (riscv_arg_location): Initialise the length of each location, a
6824         non-zero length now indicates the location is in use.
6825         (riscv_push_dummy_call): Allow for the first location having a
6826         non-zero offset when setting up arguments.
6827         (riscv_return_value): Likewise, but for return values.
6828
6829 2019-04-11  Tom Tromey  <tromey@adacore.com>
6830
6831         * utils.c (internal_vproblem): Make "msg" const.
6832
6833 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6834
6835         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6836         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6837         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6838         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6839
6840 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6841
6842         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6843         function.
6844         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6845         of amd64_collect_native_gregset.
6846         (amd64_linux_nat_target::store_registers): Likewise.
6847
6848 2019-04-10  Tom Tromey  <tom@tromey.com>
6849
6850         * symtab.c (lookup_global_symbol_from_objfile)
6851         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6852         * objfiles.h (class separate_debug_iterator): New.
6853         (class separate_debug_range): New.
6854         (struct objfile) <separate_debug_objfiles>: New method.
6855         (objfile_separate_debug_iterate): Don't declare.
6856         * objfiles.c (separate_debug_iterator::operator++): Rename from
6857         objfile_separate_debug_iterate.
6858         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6859         iterator.
6860         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6861         iterator.
6862
6863 2019-04-10  Tom Tromey  <tom@tromey.com>
6864
6865         * symfile.c (reread_symbols): Remove old comment.
6866         * objfiles.c (free_all_objfiles): Fix a typo.
6867
6868 2019-04-10  Tom Tromey  <tom@tromey.com>
6869
6870         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6871         * minsyms.c (lookup_minimal_symbol): Use foreach.
6872         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6873         (lookup_minimal_symbol_solib_trampoline): Likewise.
6874         * symfile.c (reread_symbols): Use foreach.
6875
6876 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6877             Tom Tromey  <tromey@adacore.com>
6878
6879         PR rust/24414:
6880         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6881         (rust_lex_int_test): Change "value" to be LONGEST.
6882         (rust_lex_tests): Add test for long integer literal.
6883
6884 2019-04-09  Tom Tromey  <tromey@adacore.com>
6885
6886         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6887         to bool.
6888         (extended_remote_target::attach): Update.
6889         (remote_target::remote_notice_new_inferior): Update.
6890         (remote_target::add_current_inferior_and_thread): Update.
6891         * inferior.c (exit_inferior_1): Use "false".
6892         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6893
6894 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6895
6896         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6897         the "start" command.
6898
6899 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6900
6901         * python/py-inferior.c (infpy_thread_from_thread_handle):
6902         Adjust comments to reflect renaming of thread_from_thread_handle
6903         to thread_from_handle.  Adjust keywords.  Fix type error message.
6904         (inferior_object_methods): Add thread_from_handle.  Retain
6905         thread_from_thread_handle, but mark it as deprecated.
6906
6907 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6908
6909         * gdbthread.h (find_thread_by_handle): Revise declaration.
6910         * thread.c (find_thread_by_handle): Likewise.  Adjust
6911         implementation too.
6912         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6913         support for buffer objects as handles.
6914
6915 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6916
6917         * python/py-infthread.c (thpy_thread_handle): New function.
6918         (thread_object_methods): Register thpy_thread_handle.
6919
6920 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6921
6922         * gdbthread.h (thread_to_thread_handle): Declare.
6923         * thread.c (gdbtypes.h): Include.
6924         (thread_to_thread_handle): New function.
6925
6926         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6927         (target_thread_info_to_thread_handle): Declare.
6928         * target.c (target_thread_info_to_thread_handle): New function.
6929         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6930         * target-delegates.c: Regenerate.
6931
6932         * linux-thread-db.c (class thread_db_target): Add method
6933         thread_info_to_thread_handle.
6934         (thread_db_target::thread_info_to_thread_handle): Define.
6935         * remote.c (class remote_target): Add new method
6936         thread_info_to_thread_handle.
6937         (remote_target::thread_info_to_thread_handle): Define.
6938
6939 2019-04-08  Pedro Alves  <palves@redhat.com>
6940
6941         * common/common-exceptions.c (throw_exception): Don't create
6942         named object to throw; throw directly.
6943         (throw_it): Likewise.  Don't initialize gdb_exception::message
6944         here, with new; pass FMT and AP to the ctor instead.
6945         * common/common-exceptions.h: Include <string>.
6946         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6947         const char *, va_list)): New ctor.  Use std::make_shared.
6948         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6949         errors)): Delete.
6950         (gdb_exception_error::gdb_exception_error(enum errors, const char
6951         *, va_list)): New.
6952         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6953         Add assertion.
6954         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6955         errors)): Delete.
6956         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6957         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6958         Add assertion.
6959
6960 2019-04-08  Tom Tromey  <tom@tromey.com>
6961
6962         * valops.c (value_rtti_indirect_type): Replace throw_exception
6963         with throw.
6964         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6965         with throw.
6966         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6967         throw.
6968         * target.c (target_translate_tls_address): Replace throw_exception
6969         with throw.
6970         * stack.c (frame_apply_command_count): Replace throw_exception
6971         with throw.
6972         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6973         throw.
6974         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6975         with throw.
6976         * rs6000-tdep.c (rs6000_frame_cache)
6977         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6978         * remote.c: Replace throw_exception with throw.
6979         * record-full.c (record_full_message, record_full_wait_1)
6980         (record_full_restore): Replace throw_exception with throw.
6981         * record-btrace.c:
6982         (get_thread_current_frame_id, record_btrace_start_replaying)
6983         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6984         (cmd_record_btrace_start): Replace throw_exception with throw.
6985         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6986         throw.
6987         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6988         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6989         * linespec.c:
6990         (find_linespec_symbols): Replace throw_exception with throw.
6991         * infrun.c (displaced_step_prepare, resume): Replace
6992         throw_exception with throw.
6993         * infcmd.c (post_create_inferior): Replace throw_exception with
6994         throw.
6995         * inf-loop.c (inferior_event_handler): Replace throw_exception
6996         with throw.
6997         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6998         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6999         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7000         (get_prev_frame_always, get_frame_pc_if_available)
7001         (get_frame_address_in_block_if_available, get_frame_language):
7002         Replace throw_exception with throw.
7003         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7004         throw_exception with throw.
7005         * eval.c (fetch_subexp_value, evaluate_var_value)
7006         (evaluate_funcall, evaluate_subexp_standard): Replace
7007         throw_exception with throw.
7008         * dwarf2loc.c (call_site_find_chain)
7009         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7010         Replace throw_exception with throw.
7011         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7012         with throw.
7013         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7014         throw.
7015         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7016         * completer.c (complete_line_internal): Replace throw_exception
7017         with throw.
7018         * compile/compile-object-run.c (compile_object_run): Replace
7019         throw_exception with throw.
7020         * cli/cli-script.c (process_next_line): Replace throw_exception
7021         with throw.
7022         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7023         (btrace_enable, btrace_maint_update_pt_packets): Replace
7024         throw_exception with throw.
7025         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7026         throw_exception with throw.
7027         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7028         throw_exception with throw.
7029         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7030         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7031         * aarch64-tdep.c (aarch64_make_prologue_cache)
7032         (aarch64_make_stub_cache): Replace throw_exception with throw.
7033
7034 2019-04-08  Tom Tromey  <tom@tromey.com>
7035
7036         * common/common-exceptions.c (throw_exception): Rename from
7037         throw_exception_cxx.  Remove old copy.  Make argument const.
7038         (throw_it): Create and throw exception objects directly.
7039         * common/common-exceptions.h (throw_exception): Make argument
7040         const.
7041         (struct gdb_exception_error): Add constructor.
7042         (struct gdb_exception_quit): Add constructor.
7043
7044 2019-04-08  Tom Tromey  <tom@tromey.com>
7045
7046         * common/common-exceptions.h (exception_rethrow): Don't declare.
7047         (TRY_SJLJ): Update comment.
7048         (TRY, CATCH, END_CATCH): Remove.
7049         * common/common-exceptions.c (exception_rethrow): Remove.
7050
7051 2019-04-08  Tom Tromey  <tom@tromey.com>
7052
7053         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7054         Remove.
7055         (gdb_exception_error): Rename from
7056         gdb_exception_RETURN_MASK_ERROR.
7057         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7058         (gdb_quit_bad_alloc): Update.
7059         * aarch64-tdep.c: Update.
7060         * ada-lang.c: Update.
7061         * ada-typeprint.c: Update.
7062         * ada-valprint.c: Update.
7063         * amd64-tdep.c: Update.
7064         * arch-utils.c: Update.
7065         * break-catch-throw.c: Update.
7066         * breakpoint.c: Update.
7067         * btrace.c: Update.
7068         * c-varobj.c: Update.
7069         * cli/cli-cmds.c: Update.
7070         * cli/cli-interp.c: Update.
7071         * cli/cli-script.c: Update.
7072         * common/common-exceptions.c: Update.
7073         * common/new-op.c: Update.
7074         * common/selftest.c: Update.
7075         * compile/compile-c-symbols.c: Update.
7076         * compile/compile-cplus-symbols.c: Update.
7077         * compile/compile-object-load.c: Update.
7078         * compile/compile-object-run.c: Update.
7079         * completer.c: Update.
7080         * corelow.c: Update.
7081         * cp-abi.c: Update.
7082         * cp-support.c: Update.
7083         * cp-valprint.c: Update.
7084         * darwin-nat.c: Update.
7085         * disasm-selftests.c: Update.
7086         * dtrace-probe.c: Update.
7087         * dwarf-index-cache.c: Update.
7088         * dwarf-index-write.c: Update.
7089         * dwarf2-frame-tailcall.c: Update.
7090         * dwarf2-frame.c: Update.
7091         * dwarf2loc.c: Update.
7092         * dwarf2read.c: Update.
7093         * eval.c: Update.
7094         * event-loop.c: Update.
7095         * event-top.c: Update.
7096         * exec.c: Update.
7097         * f-valprint.c: Update.
7098         * fbsd-tdep.c: Update.
7099         * frame-unwind.c: Update.
7100         * frame.c: Update.
7101         * gdbtypes.c: Update.
7102         * gnu-v3-abi.c: Update.
7103         * guile/guile-internal.h: Update.
7104         * guile/scm-block.c: Update.
7105         * guile/scm-breakpoint.c: Update.
7106         * guile/scm-cmd.c: Update.
7107         * guile/scm-disasm.c: Update.
7108         * guile/scm-frame.c: Update.
7109         * guile/scm-lazy-string.c: Update.
7110         * guile/scm-math.c: Update.
7111         * guile/scm-param.c: Update.
7112         * guile/scm-ports.c: Update.
7113         * guile/scm-pretty-print.c: Update.
7114         * guile/scm-symbol.c: Update.
7115         * guile/scm-symtab.c: Update.
7116         * guile/scm-type.c: Update.
7117         * guile/scm-value.c: Update.
7118         * i386-linux-tdep.c: Update.
7119         * i386-tdep.c: Update.
7120         * inf-loop.c: Update.
7121         * infcall.c: Update.
7122         * infcmd.c: Update.
7123         * infrun.c: Update.
7124         * jit.c: Update.
7125         * language.c: Update.
7126         * linespec.c: Update.
7127         * linux-fork.c: Update.
7128         * linux-nat.c: Update.
7129         * linux-tdep.c: Update.
7130         * linux-thread-db.c: Update.
7131         * main.c: Update.
7132         * mi/mi-cmd-break.c: Update.
7133         * mi/mi-cmd-stack.c: Update.
7134         * mi/mi-interp.c: Update.
7135         * mi/mi-main.c: Update.
7136         * objc-lang.c: Update.
7137         * p-valprint.c: Update.
7138         * parse.c: Update.
7139         * ppc-linux-tdep.c: Update.
7140         * printcmd.c: Update.
7141         * python/py-arch.c: Update.
7142         * python/py-breakpoint.c: Update.
7143         * python/py-cmd.c: Update.
7144         * python/py-finishbreakpoint.c: Update.
7145         * python/py-frame.c: Update.
7146         * python/py-framefilter.c: Update.
7147         * python/py-gdb-readline.c: Update.
7148         * python/py-inferior.c: Update.
7149         * python/py-infthread.c: Update.
7150         * python/py-lazy-string.c: Update.
7151         * python/py-linetable.c: Update.
7152         * python/py-objfile.c: Update.
7153         * python/py-param.c: Update.
7154         * python/py-prettyprint.c: Update.
7155         * python/py-progspace.c: Update.
7156         * python/py-record-btrace.c: Update.
7157         * python/py-record.c: Update.
7158         * python/py-symbol.c: Update.
7159         * python/py-type.c: Update.
7160         * python/py-unwind.c: Update.
7161         * python/py-utils.c: Update.
7162         * python/py-value.c: Update.
7163         * python/python.c: Update.
7164         * record-btrace.c: Update.
7165         * record-full.c: Update.
7166         * remote-fileio.c: Update.
7167         * remote.c: Update.
7168         * riscv-tdep.c: Update.
7169         * rs6000-aix-tdep.c: Update.
7170         * rs6000-tdep.c: Update.
7171         * rust-exp.y: Update.
7172         * rust-lang.c: Update.
7173         * s390-tdep.c: Update.
7174         * selftest-arch.c: Update.
7175         * solib-dsbt.c: Update.
7176         * solib-frv.c: Update.
7177         * solib-spu.c: Update.
7178         * solib-svr4.c: Update.
7179         * solib.c: Update.
7180         * sparc64-linux-tdep.c: Update.
7181         * stack.c: Update.
7182         * symfile-mem.c: Update.
7183         * symmisc.c: Update.
7184         * target.c: Update.
7185         * thread.c: Update.
7186         * top.c: Update.
7187         * tracefile-tfile.c: Update.
7188         * tui/tui.c: Update.
7189         * typeprint.c: Update.
7190         * unittests/cli-utils-selftests.c: Update.
7191         * unittests/parse-connection-spec-selftests.c: Update.
7192         * valops.c: Update.
7193         * valprint.c: Update.
7194         * value.c: Update.
7195         * varobj.c: Update.
7196         * windows-nat.c: Update.
7197         * x86-linux-nat.c: Update.
7198         * xml-support.c: Update.
7199
7200 2019-04-08  Tom Tromey  <tom@tromey.com>
7201
7202         * xml-support.c: Use C++ exception handling.
7203         * x86-linux-nat.c: Use C++ exception handling.
7204         * windows-nat.c: Use C++ exception handling.
7205         * varobj.c: Use C++ exception handling.
7206         * value.c: Use C++ exception handling.
7207         * valprint.c: Use C++ exception handling.
7208         * valops.c: Use C++ exception handling.
7209         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7210         handling.
7211         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7212         * typeprint.c: Use C++ exception handling.
7213         * tui/tui.c: Use C++ exception handling.
7214         * tracefile-tfile.c: Use C++ exception handling.
7215         * top.c: Use C++ exception handling.
7216         * thread.c: Use C++ exception handling.
7217         * target.c: Use C++ exception handling.
7218         * symmisc.c: Use C++ exception handling.
7219         * symfile-mem.c: Use C++ exception handling.
7220         * stack.c: Use C++ exception handling.
7221         * sparc64-linux-tdep.c: Use C++ exception handling.
7222         * solib.c: Use C++ exception handling.
7223         * solib-svr4.c: Use C++ exception handling.
7224         * solib-spu.c: Use C++ exception handling.
7225         * solib-frv.c: Use C++ exception handling.
7226         * solib-dsbt.c: Use C++ exception handling.
7227         * selftest-arch.c: Use C++ exception handling.
7228         * s390-tdep.c: Use C++ exception handling.
7229         * rust-lang.c: Use C++ exception handling.
7230         * rust-exp.y: Use C++ exception handling.
7231         * rs6000-tdep.c: Use C++ exception handling.
7232         * rs6000-aix-tdep.c: Use C++ exception handling.
7233         * riscv-tdep.c: Use C++ exception handling.
7234         * remote.c: Use C++ exception handling.
7235         * remote-fileio.c: Use C++ exception handling.
7236         * record-full.c: Use C++ exception handling.
7237         * record-btrace.c: Use C++ exception handling.
7238         * python/python.c: Use C++ exception handling.
7239         * python/py-value.c: Use C++ exception handling.
7240         * python/py-utils.c: Use C++ exception handling.
7241         * python/py-unwind.c: Use C++ exception handling.
7242         * python/py-type.c: Use C++ exception handling.
7243         * python/py-symbol.c: Use C++ exception handling.
7244         * python/py-record.c: Use C++ exception handling.
7245         * python/py-record-btrace.c: Use C++ exception handling.
7246         * python/py-progspace.c: Use C++ exception handling.
7247         * python/py-prettyprint.c: Use C++ exception handling.
7248         * python/py-param.c: Use C++ exception handling.
7249         * python/py-objfile.c: Use C++ exception handling.
7250         * python/py-linetable.c: Use C++ exception handling.
7251         * python/py-lazy-string.c: Use C++ exception handling.
7252         * python/py-infthread.c: Use C++ exception handling.
7253         * python/py-inferior.c: Use C++ exception handling.
7254         * python/py-gdb-readline.c: Use C++ exception handling.
7255         * python/py-framefilter.c: Use C++ exception handling.
7256         * python/py-frame.c: Use C++ exception handling.
7257         * python/py-finishbreakpoint.c: Use C++ exception handling.
7258         * python/py-cmd.c: Use C++ exception handling.
7259         * python/py-breakpoint.c: Use C++ exception handling.
7260         * python/py-arch.c: Use C++ exception handling.
7261         * printcmd.c: Use C++ exception handling.
7262         * ppc-linux-tdep.c: Use C++ exception handling.
7263         * parse.c: Use C++ exception handling.
7264         * p-valprint.c: Use C++ exception handling.
7265         * objc-lang.c: Use C++ exception handling.
7266         * mi/mi-main.c: Use C++ exception handling.
7267         * mi/mi-interp.c: Use C++ exception handling.
7268         * mi/mi-cmd-stack.c: Use C++ exception handling.
7269         * mi/mi-cmd-break.c: Use C++ exception handling.
7270         * main.c: Use C++ exception handling.
7271         * linux-thread-db.c: Use C++ exception handling.
7272         * linux-tdep.c: Use C++ exception handling.
7273         * linux-nat.c: Use C++ exception handling.
7274         * linux-fork.c: Use C++ exception handling.
7275         * linespec.c: Use C++ exception handling.
7276         * language.c: Use C++ exception handling.
7277         * jit.c: Use C++ exception handling.
7278         * infrun.c: Use C++ exception handling.
7279         * infcmd.c: Use C++ exception handling.
7280         * infcall.c: Use C++ exception handling.
7281         * inf-loop.c: Use C++ exception handling.
7282         * i386-tdep.c: Use C++ exception handling.
7283         * i386-linux-tdep.c: Use C++ exception handling.
7284         * guile/scm-value.c: Use C++ exception handling.
7285         * guile/scm-type.c: Use C++ exception handling.
7286         * guile/scm-symtab.c: Use C++ exception handling.
7287         * guile/scm-symbol.c: Use C++ exception handling.
7288         * guile/scm-pretty-print.c: Use C++ exception handling.
7289         * guile/scm-ports.c: Use C++ exception handling.
7290         * guile/scm-param.c: Use C++ exception handling.
7291         * guile/scm-math.c: Use C++ exception handling.
7292         * guile/scm-lazy-string.c: Use C++ exception handling.
7293         * guile/scm-frame.c: Use C++ exception handling.
7294         * guile/scm-disasm.c: Use C++ exception handling.
7295         * guile/scm-cmd.c: Use C++ exception handling.
7296         * guile/scm-breakpoint.c: Use C++ exception handling.
7297         * guile/scm-block.c: Use C++ exception handling.
7298         * guile/guile-internal.h: Use C++ exception handling.
7299         * gnu-v3-abi.c: Use C++ exception handling.
7300         * gdbtypes.c: Use C++ exception handling.
7301         * frame.c: Use C++ exception handling.
7302         * frame-unwind.c: Use C++ exception handling.
7303         * fbsd-tdep.c: Use C++ exception handling.
7304         * f-valprint.c: Use C++ exception handling.
7305         * exec.c: Use C++ exception handling.
7306         * event-top.c: Use C++ exception handling.
7307         * event-loop.c: Use C++ exception handling.
7308         * eval.c: Use C++ exception handling.
7309         * dwarf2read.c: Use C++ exception handling.
7310         * dwarf2loc.c: Use C++ exception handling.
7311         * dwarf2-frame.c: Use C++ exception handling.
7312         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7313         * dwarf-index-write.c: Use C++ exception handling.
7314         * dwarf-index-cache.c: Use C++ exception handling.
7315         * dtrace-probe.c: Use C++ exception handling.
7316         * disasm-selftests.c: Use C++ exception handling.
7317         * darwin-nat.c: Use C++ exception handling.
7318         * cp-valprint.c: Use C++ exception handling.
7319         * cp-support.c: Use C++ exception handling.
7320         * cp-abi.c: Use C++ exception handling.
7321         * corelow.c: Use C++ exception handling.
7322         * completer.c: Use C++ exception handling.
7323         * compile/compile-object-run.c: Use C++ exception handling.
7324         * compile/compile-object-load.c: Use C++ exception handling.
7325         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7326         * compile/compile-c-symbols.c: Use C++ exception handling.
7327         * common/selftest.c: Use C++ exception handling.
7328         * common/new-op.c: Use C++ exception handling.
7329         * cli/cli-script.c: Use C++ exception handling.
7330         * cli/cli-interp.c: Use C++ exception handling.
7331         * cli/cli-cmds.c: Use C++ exception handling.
7332         * c-varobj.c: Use C++ exception handling.
7333         * btrace.c: Use C++ exception handling.
7334         * breakpoint.c: Use C++ exception handling.
7335         * break-catch-throw.c: Use C++ exception handling.
7336         * arch-utils.c: Use C++ exception handling.
7337         * amd64-tdep.c: Use C++ exception handling.
7338         * ada-valprint.c: Use C++ exception handling.
7339         * ada-typeprint.c: Use C++ exception handling.
7340         * ada-lang.c: Use C++ exception handling.
7341         * aarch64-tdep.c: Use C++ exception handling.
7342
7343 2019-04-08  Tom Tromey  <tom@tromey.com>
7344
7345         * xml-support.c (gdb_xml_parser::parse): Update.
7346         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7347         * value.c (show_convenience): Update.
7348         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7349         (test_parse_flags_qcs): Update.
7350         * thread.c (thr_try_catch_cmd): Update.
7351         * target.c (target_translate_tls_address): Update.
7352         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7353         (info_frame_command_core, frame_apply_command_count): Update.
7354         * rust-exp.y (rust_lex_exception_test): Update.
7355         * riscv-tdep.c (riscv_print_one_register_info): Update.
7356         * remote.c (remote_target::enable_btrace): Update.
7357         * record-btrace.c (record_btrace_enable_warn): Update.
7358         * python/py-utils.c (gdbpy_convert_exception): Update.
7359         * printcmd.c (do_one_display, print_variable_and_value): Update.
7360         * mi/mi-main.c (mi_print_exception): Update.
7361         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7362         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7363         * linux-nat.c (linux_nat_target::attach): Update.
7364         * linux-fork.c (class scoped_switch_fork_info): Update.
7365         * infrun.c (displaced_step_prepare): Update.
7366         * infcall.c (call_function_by_hand_dummy): Update.
7367         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7368         * gnu-v3-abi.c (print_one_vtable): Update.
7369         * frame.c (get_prev_frame_always): Update.
7370         * f-valprint.c (info_common_command_for_block): Update.
7371         * exec.c (try_open_exec_file): Update.
7372         * exceptions.c (print_exception, exception_print)
7373         (exception_fprintf, exception_print_same): Update.
7374         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7375         * dwarf-index-cache.c (index_cache::store)
7376         (index_cache::lookup_gdb_index): Update.
7377         * darwin-nat.c (maybe_cache_shell): Update.
7378         * cp-valprint.c (cp_print_value_fields): Update.
7379         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7380         (gcc_cplus_symbol_address): Update.
7381         * compile/compile-c-symbols.c (gcc_convert_symbol)
7382         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7383         * common/selftest.c: Update.
7384         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7385         a std::string.
7386         (exception_try_scope_entry, exception_try_scope_exit): Don't
7387         declare.
7388         (struct exception_try_scope): Remove.
7389         (TRY): Don't use exception_try_scope.
7390         (struct gdb_exception): Add constructor, operator=.
7391         <what>: New method.
7392         (struct gdb_exception_RETURN_MASK_ALL)
7393         (struct gdb_exception_RETURN_MASK_ERROR)
7394         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7395         (struct gdb_quit_bad_alloc): Update.
7396         * common/common-exceptions.c (exception_none): Change
7397         initializer.
7398         (struct catcher) <state, exception>: Initialize inline.
7399         <prev>: Remove member.
7400         (current_catcher): Remove.
7401         (catchers): New global.
7402         (exceptions_state_mc_init): Simplify.
7403         (catcher_pop): Remove.
7404         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7405         (try_scope_depth, exception_try_scope_entry)
7406         (exception_try_scope_exit): Remove.
7407         (throw_exception_sjlj): Update.
7408         (exception_messages, exception_messages_size): Remove.
7409         (throw_it): Simplify.
7410         (gdb_exception_sliced_copy): Remove.
7411         (throw_exception_cxx): Update.
7412         * cli/cli-script.c (script_from_file): Update.
7413         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7414         Update.
7415         * ada-valprint.c (ada_val_print): Update.
7416         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7417         (create_excep_cond_exprs): Update.
7418
7419 2019-04-08  Tom Tromey  <tom@tromey.com>
7420
7421         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7422         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7423         (TRY, CATCH, END_CATCH): Remove some definitions.
7424         * common/common-exceptions.c: Don't use GDB_XCPT.
7425         (catcher_list_size): Remove.
7426         (throw_exception, throw_it): Simplify.
7427
7428 2019-04-05  Tom Tromey  <tom@tromey.com>
7429
7430         Revert the header-sorting patch.
7431         * ft32-tdep.c: Revert.
7432         * frv-tdep.c: Revert.
7433         * frv-linux-tdep.c: Revert.
7434         * frame.c: Revert.
7435         * frame-unwind.c: Revert.
7436         * frame-base.c: Revert.
7437         * fork-child.c: Revert.
7438         * findvar.c: Revert.
7439         * findcmd.c: Revert.
7440         * filesystem.c: Revert.
7441         * filename-seen-cache.h: Revert.
7442         * filename-seen-cache.c: Revert.
7443         * fbsd-tdep.c: Revert.
7444         * fbsd-nat.h: Revert.
7445         * fbsd-nat.c: Revert.
7446         * f-valprint.c: Revert.
7447         * f-typeprint.c: Revert.
7448         * f-lang.c: Revert.
7449         * extension.h: Revert.
7450         * extension.c: Revert.
7451         * extension-priv.h: Revert.
7452         * expprint.c: Revert.
7453         * exec.h: Revert.
7454         * exec.c: Revert.
7455         * exceptions.c: Revert.
7456         * event-top.c: Revert.
7457         * event-loop.c: Revert.
7458         * eval.c: Revert.
7459         * elfread.c: Revert.
7460         * dwarf2read.h: Revert.
7461         * dwarf2read.c: Revert.
7462         * dwarf2loc.c: Revert.
7463         * dwarf2expr.h: Revert.
7464         * dwarf2expr.c: Revert.
7465         * dwarf2-frame.c: Revert.
7466         * dwarf2-frame-tailcall.c: Revert.
7467         * dwarf-index-write.h: Revert.
7468         * dwarf-index-write.c: Revert.
7469         * dwarf-index-common.c: Revert.
7470         * dwarf-index-cache.h: Revert.
7471         * dwarf-index-cache.c: Revert.
7472         * dummy-frame.c: Revert.
7473         * dtrace-probe.c: Revert.
7474         * disasm.h: Revert.
7475         * disasm.c: Revert.
7476         * disasm-selftests.c: Revert.
7477         * dictionary.c: Revert.
7478         * dicos-tdep.c: Revert.
7479         * demangle.c: Revert.
7480         * dcache.h: Revert.
7481         * dcache.c: Revert.
7482         * darwin-nat.h: Revert.
7483         * darwin-nat.c: Revert.
7484         * darwin-nat-info.c: Revert.
7485         * d-valprint.c: Revert.
7486         * d-namespace.c: Revert.
7487         * d-lang.c: Revert.
7488         * ctf.c: Revert.
7489         * csky-tdep.c: Revert.
7490         * csky-linux-tdep.c: Revert.
7491         * cris-tdep.c: Revert.
7492         * cris-linux-tdep.c: Revert.
7493         * cp-valprint.c: Revert.
7494         * cp-support.c: Revert.
7495         * cp-namespace.c: Revert.
7496         * cp-abi.c: Revert.
7497         * corelow.c: Revert.
7498         * corefile.c: Revert.
7499         * continuations.c: Revert.
7500         * completer.h: Revert.
7501         * completer.c: Revert.
7502         * complaints.c: Revert.
7503         * coffread.c: Revert.
7504         * coff-pe-read.c: Revert.
7505         * cli-out.h: Revert.
7506         * cli-out.c: Revert.
7507         * charset.c: Revert.
7508         * c-varobj.c: Revert.
7509         * c-valprint.c: Revert.
7510         * c-typeprint.c: Revert.
7511         * c-lang.c: Revert.
7512         * buildsym.c: Revert.
7513         * buildsym-legacy.c: Revert.
7514         * build-id.h: Revert.
7515         * build-id.c: Revert.
7516         * btrace.c: Revert.
7517         * bsd-uthread.c: Revert.
7518         * breakpoint.h: Revert.
7519         * breakpoint.c: Revert.
7520         * break-catch-throw.c: Revert.
7521         * break-catch-syscall.c: Revert.
7522         * break-catch-sig.c: Revert.
7523         * blockframe.c: Revert.
7524         * block.c: Revert.
7525         * bfin-tdep.c: Revert.
7526         * bfin-linux-tdep.c: Revert.
7527         * bfd-target.c: Revert.
7528         * bcache.c: Revert.
7529         * ax-general.c: Revert.
7530         * ax-gdb.h: Revert.
7531         * ax-gdb.c: Revert.
7532         * avr-tdep.c: Revert.
7533         * auxv.c: Revert.
7534         * auto-load.c: Revert.
7535         * arm-wince-tdep.c: Revert.
7536         * arm-tdep.c: Revert.
7537         * arm-symbian-tdep.c: Revert.
7538         * arm-pikeos-tdep.c: Revert.
7539         * arm-obsd-tdep.c: Revert.
7540         * arm-nbsd-tdep.c: Revert.
7541         * arm-nbsd-nat.c: Revert.
7542         * arm-linux-tdep.c: Revert.
7543         * arm-linux-nat.c: Revert.
7544         * arm-fbsd-tdep.c: Revert.
7545         * arm-fbsd-nat.c: Revert.
7546         * arm-bsd-tdep.c: Revert.
7547         * arch-utils.c: Revert.
7548         * arc-tdep.c: Revert.
7549         * arc-newlib-tdep.c: Revert.
7550         * annotate.h: Revert.
7551         * annotate.c: Revert.
7552         * amd64-windows-tdep.c: Revert.
7553         * amd64-windows-nat.c: Revert.
7554         * amd64-tdep.c: Revert.
7555         * amd64-sol2-tdep.c: Revert.
7556         * amd64-obsd-tdep.c: Revert.
7557         * amd64-obsd-nat.c: Revert.
7558         * amd64-nbsd-tdep.c: Revert.
7559         * amd64-nbsd-nat.c: Revert.
7560         * amd64-nat.c: Revert.
7561         * amd64-linux-tdep.c: Revert.
7562         * amd64-linux-nat.c: Revert.
7563         * amd64-fbsd-tdep.c: Revert.
7564         * amd64-fbsd-nat.c: Revert.
7565         * amd64-dicos-tdep.c: Revert.
7566         * amd64-darwin-tdep.c: Revert.
7567         * amd64-bsd-nat.c: Revert.
7568         * alpha-tdep.c: Revert.
7569         * alpha-obsd-tdep.c: Revert.
7570         * alpha-nbsd-tdep.c: Revert.
7571         * alpha-mdebug-tdep.c: Revert.
7572         * alpha-linux-tdep.c: Revert.
7573         * alpha-linux-nat.c: Revert.
7574         * alpha-bsd-tdep.c: Revert.
7575         * alpha-bsd-nat.c: Revert.
7576         * aix-thread.c: Revert.
7577         * agent.c: Revert.
7578         * addrmap.c: Revert.
7579         * ada-varobj.c: Revert.
7580         * ada-valprint.c: Revert.
7581         * ada-typeprint.c: Revert.
7582         * ada-tasks.c: Revert.
7583         * ada-lang.c: Revert.
7584         * aarch64-tdep.c: Revert.
7585         * aarch64-ravenscar-thread.c: Revert.
7586         * aarch64-newlib-tdep.c: Revert.
7587         * aarch64-linux-tdep.c: Revert.
7588         * aarch64-linux-nat.c: Revert.
7589         * aarch64-fbsd-tdep.c: Revert.
7590         * aarch64-fbsd-nat.c: Revert.
7591         * aarch32-linux-nat.c: Revert.
7592
7593 2019-04-05  Tom Tromey  <tom@tromey.com>
7594
7595         * ft32-tdep.c: Sort headers.
7596         * frv-tdep.c: Sort headers.
7597         * frv-linux-tdep.c: Sort headers.
7598         * frame.c: Sort headers.
7599         * frame-unwind.c: Sort headers.
7600         * frame-base.c: Sort headers.
7601         * fork-child.c: Sort headers.
7602         * findvar.c: Sort headers.
7603         * findcmd.c: Sort headers.
7604         * filesystem.c: Sort headers.
7605         * filename-seen-cache.h: Sort headers.
7606         * filename-seen-cache.c: Sort headers.
7607         * fbsd-tdep.c: Sort headers.
7608         * fbsd-nat.h: Sort headers.
7609         * fbsd-nat.c: Sort headers.
7610         * f-valprint.c: Sort headers.
7611         * f-typeprint.c: Sort headers.
7612         * f-lang.c: Sort headers.
7613         * extension.h: Sort headers.
7614         * extension.c: Sort headers.
7615         * extension-priv.h: Sort headers.
7616         * expprint.c: Sort headers.
7617         * exec.h: Sort headers.
7618         * exec.c: Sort headers.
7619         * exceptions.c: Sort headers.
7620         * event-top.c: Sort headers.
7621         * event-loop.c: Sort headers.
7622         * eval.c: Sort headers.
7623         * elfread.c: Sort headers.
7624         * dwarf2read.h: Sort headers.
7625         * dwarf2read.c: Sort headers.
7626         * dwarf2loc.c: Sort headers.
7627         * dwarf2expr.h: Sort headers.
7628         * dwarf2expr.c: Sort headers.
7629         * dwarf2-frame.c: Sort headers.
7630         * dwarf2-frame-tailcall.c: Sort headers.
7631         * dwarf-index-write.h: Sort headers.
7632         * dwarf-index-write.c: Sort headers.
7633         * dwarf-index-common.c: Sort headers.
7634         * dwarf-index-cache.h: Sort headers.
7635         * dwarf-index-cache.c: Sort headers.
7636         * dummy-frame.c: Sort headers.
7637         * dtrace-probe.c: Sort headers.
7638         * disasm.h: Sort headers.
7639         * disasm.c: Sort headers.
7640         * disasm-selftests.c: Sort headers.
7641         * dictionary.c: Sort headers.
7642         * dicos-tdep.c: Sort headers.
7643         * demangle.c: Sort headers.
7644         * dcache.h: Sort headers.
7645         * dcache.c: Sort headers.
7646         * darwin-nat.h: Sort headers.
7647         * darwin-nat.c: Sort headers.
7648         * darwin-nat-info.c: Sort headers.
7649         * d-valprint.c: Sort headers.
7650         * d-namespace.c: Sort headers.
7651         * d-lang.c: Sort headers.
7652         * ctf.c: Sort headers.
7653         * csky-tdep.c: Sort headers.
7654         * csky-linux-tdep.c: Sort headers.
7655         * cris-tdep.c: Sort headers.
7656         * cris-linux-tdep.c: Sort headers.
7657         * cp-valprint.c: Sort headers.
7658         * cp-support.c: Sort headers.
7659         * cp-namespace.c: Sort headers.
7660         * cp-abi.c: Sort headers.
7661         * corelow.c: Sort headers.
7662         * corefile.c: Sort headers.
7663         * continuations.c: Sort headers.
7664         * completer.h: Sort headers.
7665         * completer.c: Sort headers.
7666         * complaints.c: Sort headers.
7667         * coffread.c: Sort headers.
7668         * coff-pe-read.c: Sort headers.
7669         * cli-out.h: Sort headers.
7670         * cli-out.c: Sort headers.
7671         * charset.c: Sort headers.
7672         * c-varobj.c: Sort headers.
7673         * c-valprint.c: Sort headers.
7674         * c-typeprint.c: Sort headers.
7675         * c-lang.c: Sort headers.
7676         * buildsym.c: Sort headers.
7677         * buildsym-legacy.c: Sort headers.
7678         * build-id.h: Sort headers.
7679         * build-id.c: Sort headers.
7680         * btrace.c: Sort headers.
7681         * bsd-uthread.c: Sort headers.
7682         * breakpoint.h: Sort headers.
7683         * breakpoint.c: Sort headers.
7684         * break-catch-throw.c: Sort headers.
7685         * break-catch-syscall.c: Sort headers.
7686         * break-catch-sig.c: Sort headers.
7687         * blockframe.c: Sort headers.
7688         * block.c: Sort headers.
7689         * bfin-tdep.c: Sort headers.
7690         * bfin-linux-tdep.c: Sort headers.
7691         * bfd-target.c: Sort headers.
7692         * bcache.c: Sort headers.
7693         * ax-general.c: Sort headers.
7694         * ax-gdb.h: Sort headers.
7695         * ax-gdb.c: Sort headers.
7696         * avr-tdep.c: Sort headers.
7697         * auxv.c: Sort headers.
7698         * auto-load.c: Sort headers.
7699         * arm-wince-tdep.c: Sort headers.
7700         * arm-tdep.c: Sort headers.
7701         * arm-symbian-tdep.c: Sort headers.
7702         * arm-pikeos-tdep.c: Sort headers.
7703         * arm-obsd-tdep.c: Sort headers.
7704         * arm-nbsd-tdep.c: Sort headers.
7705         * arm-nbsd-nat.c: Sort headers.
7706         * arm-linux-tdep.c: Sort headers.
7707         * arm-linux-nat.c: Sort headers.
7708         * arm-fbsd-tdep.c: Sort headers.
7709         * arm-fbsd-nat.c: Sort headers.
7710         * arm-bsd-tdep.c: Sort headers.
7711         * arch-utils.c: Sort headers.
7712         * arc-tdep.c: Sort headers.
7713         * arc-newlib-tdep.c: Sort headers.
7714         * annotate.h: Sort headers.
7715         * annotate.c: Sort headers.
7716         * amd64-windows-tdep.c: Sort headers.
7717         * amd64-windows-nat.c: Sort headers.
7718         * amd64-tdep.c: Sort headers.
7719         * amd64-sol2-tdep.c: Sort headers.
7720         * amd64-obsd-tdep.c: Sort headers.
7721         * amd64-obsd-nat.c: Sort headers.
7722         * amd64-nbsd-tdep.c: Sort headers.
7723         * amd64-nbsd-nat.c: Sort headers.
7724         * amd64-nat.c: Sort headers.
7725         * amd64-linux-tdep.c: Sort headers.
7726         * amd64-linux-nat.c: Sort headers.
7727         * amd64-fbsd-tdep.c: Sort headers.
7728         * amd64-fbsd-nat.c: Sort headers.
7729         * amd64-dicos-tdep.c: Sort headers.
7730         * amd64-darwin-tdep.c: Sort headers.
7731         * amd64-bsd-nat.c: Sort headers.
7732         * alpha-tdep.c: Sort headers.
7733         * alpha-obsd-tdep.c: Sort headers.
7734         * alpha-nbsd-tdep.c: Sort headers.
7735         * alpha-mdebug-tdep.c: Sort headers.
7736         * alpha-linux-tdep.c: Sort headers.
7737         * alpha-linux-nat.c: Sort headers.
7738         * alpha-bsd-tdep.c: Sort headers.
7739         * alpha-bsd-nat.c: Sort headers.
7740         * aix-thread.c: Sort headers.
7741         * agent.c: Sort headers.
7742         * addrmap.c: Sort headers.
7743         * ada-varobj.c: Sort headers.
7744         * ada-valprint.c: Sort headers.
7745         * ada-typeprint.c: Sort headers.
7746         * ada-tasks.c: Sort headers.
7747         * ada-lang.c: Sort headers.
7748         * aarch64-tdep.c: Sort headers.
7749         * aarch64-ravenscar-thread.c: Sort headers.
7750         * aarch64-newlib-tdep.c: Sort headers.
7751         * aarch64-linux-tdep.c: Sort headers.
7752         * aarch64-linux-nat.c: Sort headers.
7753         * aarch64-fbsd-tdep.c: Sort headers.
7754         * aarch64-fbsd-nat.c: Sort headers.
7755         * aarch32-linux-nat.c: Sort headers.
7756
7757 2019-04-04  Tom Tromey  <tom@tromey.com>
7758
7759         * varobj.c (varobj_create): Update.
7760         * rust-exp.y (struct rust_parser) <update_innermost_block,
7761         lookup_symbol>: New methods.
7762         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7763         Rename.
7764         (rust_parser::rust_lookup_type)
7765         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7766         * printcmd.c (display_command, do_one_display): Update.
7767         * parser-defs.h (struct parser_state) <parser_state>: Add
7768         "tracker" parameter.
7769         (block_tracker): New member.
7770         (class innermost_block_tracker) <innermost_block_tracker>: Add
7771         "types" parameter.
7772         <reset>: Remove method.
7773         (innermost_block): Don't declare.
7774         (null_post_parser): Update.
7775         * parse.c (innermost_block): Remove global.
7776         (write_dollar_variable): Update.
7777         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7778         Remove "tracker_types" parameter.
7779         (parse_expression): Add "tracker" parameter.
7780         (parse_expression_for_completion): Update.
7781         (null_post_parser): Add "tracker" parameter.
7782         * p-exp.y: Update rules.
7783         * m2-exp.y: Update rules.
7784         * language.h (struct language_defn) <la_post_parser>: Add
7785         "tracker" parameter.
7786         * go-exp.y: Update rules.
7787         * f-exp.y: Update rules.
7788         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7789         parameter.
7790         * d-exp.y: Update rules.
7791         * c-exp.y: Update rules.
7792         * breakpoint.c (set_breakpoint_condition): Create an
7793         innermost_block_tracker.
7794         (watch_command_1): Likewise.
7795         * ada-lang.c (resolve): Add "tracker" parameter.
7796         (resolve_subexp): Likewise.
7797         * ada-exp.y (write_var_from_sym): Update.
7798
7799 2019-04-04  Tom Tromey  <tom@tromey.com>
7800
7801         * type-stack.h: New file.
7802         * type-stack.c: New file.
7803         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7804         type-stack.h.
7805         (insert_into_type_stack, insert_type, push_type, push_type_int)
7806         (insert_type_address_space, pop_type, pop_type_int)
7807         (pop_typelist, pop_type_stack, append_type_stack)
7808         (push_type_stack, get_type_stack, push_typelist)
7809         (follow_type_instance_flags, follow_types): Don't declare.
7810         * parse.c (type_stack): Remove global.
7811         (parse_exp_in_context): Update.
7812         (insert_into_type_stack, insert_type, push_type, push_type_int)
7813         (insert_type_address_space, pop_type, pop_type_int)
7814         (pop_typelist, pop_type_stack, append_type_stack)
7815         (push_type_stack, get_type_stack, push_typelist)
7816         (follow_type_instance_flags, follow_types): Remove (moved to
7817         type-stack.c).
7818         * f-exp.y (type_stack): New global.
7819         Update rules.
7820         (push_kind_type, f_parse): Update.
7821         * d-exp.y (type_stack): New global.
7822         Update rules.
7823         (d_parse): Update.
7824         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7825         Update rules.
7826         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7827         (HFILES_NO_SRCDIR): Add type-stack.h.
7828
7829 2019-04-04  Tom Tromey  <tom@tromey.com>
7830
7831         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7832         (rust_parser::convert_ast_to_expression, rust_parse)
7833         (rust_lex_test_completion, rust_lex_tests): Update.
7834         * parser-defs.h (struct expr_completion_state): New.
7835         (struct parser_state) <parser_state>: Add completion parameter.
7836         <mark_struct_expression, mark_completion_tag>: New methods.
7837         <parse_completion, m_completion_state>: New members.
7838         (prefixify_expression, null_post_parser): Update.
7839         (mark_struct_expression, mark_completion_tag): Don't declare.
7840         * parse.c (parse_completion, expout_last_struct)
7841         (expout_tag_completion_type, expout_completion_name): Remove
7842         globals.
7843         (parser_state::mark_struct_expression)
7844         (parser_state::mark_completion_tag): Now methods.
7845         (prefixify_expression): Add last_struct parameter.
7846         (prefixify_subexp): Likewise.
7847         (parse_exp_1): Update.
7848         (parse_exp_in_context): Add cstate parameter.  Update.
7849         (parse_expression_for_completion): Create an
7850         expr_completion_state.
7851         (null_post_parser): Add "completion" parameter.
7852         * p-exp.y: Update rules.
7853         (yylex): Update.
7854         * language.h (struct language_defn) <la_post_parser>: Add
7855         "completing" parameter.
7856         * go-exp.y: Update rules.
7857         (lex_one_token): Update.
7858         * expression.h (parse_completion): Don't declare.
7859         * d-exp.y: Update rules.
7860         (lex_one_token): Update rules.
7861         * c-exp.y: Update rules.
7862         (lex_one_token): Update.
7863         * ada-lang.c (resolve): Add "parse_completion" parameter.
7864         (resolve_subexp): Likewise.
7865         (ada_resolve_function): Likewise.
7866
7867 2019-04-04  Tom Tromey  <tom@tromey.com>
7868
7869         * parser-defs.h (struct parser_state) <start_arglist,
7870         end_arglist>: New methods.
7871         <arglist_len, m_funcall_chain>: New members.
7872         (arglist_len, start_arglist, end_arglist): Don't declare.
7873         * parse.c (arglist_len, funcall_chain): Remove global.
7874         (start_arglist, end_arglist): Remove functions.
7875         (parse_exp_in_context): Update.
7876         * p-exp.y: Update rules.
7877         * m2-exp.y: Update rules.
7878         * go-exp.y: Update rules.
7879         * f-exp.y: Update rules.
7880         * d-exp.y: Update rules.
7881         * c-exp.y: Update rules.
7882
7883 2019-04-04  Tom Tromey  <tom@tromey.com>
7884
7885         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7886         lex_operator, push_back>: New methods.
7887         Update all rules.
7888         (rust_parser::lex_hex, lex_escape): Rename and update.
7889         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7890         (rust_parser::lex_operator): Rename and update.
7891         (rust_parser::lex_number, rustyylex, rustyyerror)
7892         (rust_lex_test_init, rust_lex_test_sequence)
7893         (rust_lex_test_push_back, rust_lex_tests): Update.
7894         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7895         parameter.
7896         <lexptr, prev_lexptr>: New members.
7897         (lexptr, prev_lexptr): Don't declare.
7898         * parse.c (lexptr, prev_lexptr): Remove globals.
7899         (parse_exp_in_context): Update.
7900         * p-exp.y (yylex, yyerror): Update.
7901         * m2-exp.y (parse_number, yylex, yyerror): Update.
7902         * go-exp.y (lex_one_token, yyerror): Update.
7903         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7904         * d-exp.y (lex_one_token, yyerror): Update.
7905         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7906         (lex_one_token, yyerror): Update.
7907         * ada-lex.l (YY_INPUT): Update.
7908         (rewind_to_char): Update.
7909         * ada-exp.y (yyerror): Update.
7910
7911 2019-04-04  Tom Tromey  <tom@tromey.com>
7912
7913         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7914         * parser-defs.h (struct parser_state) <parser_state>: Add new
7915         parameter.
7916         <comma_terminates>: New member.
7917         (comma_terminates): Don't declare global.
7918         * parse.c (comma_terminates): Remove global.
7919         (parse_exp_in_context): Update.
7920         * p-exp.y (yylex): Update.
7921         * m2-exp.y (yylex): Update.
7922         * go-exp.y (lex_one_token): Update.
7923         * f-exp.y (yylex): Update.
7924         * d-exp.y (lex_one_token): Update.
7925         * c-exp.y (lex_one_token): Update.
7926         * ada-lex.l: Update.
7927
7928 2019-04-04  Tom Tromey  <tom@tromey.com>
7929
7930         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7931         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7932         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7933         * parser-defs.h (paren_depth): Don't declare.
7934         * parse.c (paren_depth): Remove global.
7935         (parse_exp_in_context): Update.
7936         * p-exp.y (paren_depth): New global.
7937         (pascal_parse): Initialize it.
7938         * m2-exp.y (paren_depth): New global.
7939         (m2_parse): Initialize it.
7940         * go-exp.y (paren_depth): New global.
7941         (go_parse): Initialize it.
7942         * f-exp.y (paren_depth): New global.
7943         (f_parse): Initialize it.
7944         * d-exp.y (paren_depth): New global.
7945         (d_parse): Initialize it.
7946         * c-exp.y (paren_depth): New global.
7947         (c_parse): Initialize it.
7948         * ada-lex.l (paren_depth): New global.
7949         (lexer_init): Initialize it.
7950
7951 2019-04-04  Tom Tromey  <tom@tromey.com>
7952
7953         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7954         (rust_parser::convert_ast_to_type)
7955         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7956         * parser-defs.h (struct parser_state) <parser_state>: Add
7957         parameters.  Initialize new members.
7958         <expression_context_block, expression_context_pc>: New members.
7959         * parse.c (expression_context_block, expression_context_pc):
7960         Remove globals.
7961         (parse_exp_in_context): Update.
7962         * p-exp.y: Update all rules.
7963         (yylex): Update.
7964         * m2-exp.y: Update all rules.
7965         (yylex): Update.
7966         * go-exp.y (yylex): Update.
7967         * f-exp.y (yylex): Update.
7968         * d-exp.y: Update all rules.
7969         (yylex): Update.
7970         * c-exp.y: Update all rules.
7971         (lex_one_token, classify_name, yylex, c_parse): Update.
7972         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7973
7974 2019-04-04  Tom Tromey  <tom@tromey.com>
7975
7976         * gdbarch.h, gdbarch.c: Rebuild.
7977         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7978         * stap-probe.h:
7979         (struct stap_parse_info): Replace "parser_state" with
7980         "expr_builder".
7981         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7982         (parser_state): New class.
7983         * parse.c (expr_builder): Rename.
7984         (expr_builder::release): Rename.
7985         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7986         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7987         (write_exp_elt_longcst, write_exp_elt_floatcst)
7988         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7989         (write_exp_string_vector, write_exp_bitstring)
7990         (write_exp_msymbol, mark_struct_expression)
7991         (write_dollar_variable)
7992         (insert_type_address_space, increase_expout_size): Replace
7993         "parser_state" with "expr_builder".
7994         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7995         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7996         "parser_state" with "expr_builder".
7997
7998 2019-04-04  Tom Tromey  <tom@tromey.com>
7999
8000         * rust-exp.y: Replace "parse_language" with method call.
8001         * p-exp.y:
8002         (yylex): Replace "parse_language" with method call.
8003         * m2-exp.y:
8004         (yylex): Replace "parse_language" with method call.
8005         * go-exp.y (classify_name): Replace "parse_language" with method
8006         call.
8007         * f-exp.y (yylex): Replace "parse_language" with method call.
8008         * d-exp.y (lex_one_token): Replace "parse_language" with method
8009         call.
8010         * c-exp.y:
8011         (lex_one_token, classify_name, yylex): Replace "parse_language"
8012         with method call.
8013         * ada-exp.y (find_primitive_type, type_char)
8014         (type_system_address): Replace "parse_language" with method call.
8015
8016 2019-04-04  Tom Tromey  <tom@tromey.com>
8017
8018         * rust-exp.y: Replace "parse_gdbarch" with method call.
8019         * parse.c (write_dollar_variable, insert_type_address_space):
8020         Replace "parse_gdbarch" with method call.
8021         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8022         call.
8023         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8024         call.
8025         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8026         "parse_gdbarch" with method call.
8027         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8028         with method call.
8029         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8030         "parse_gdbarch" with method call.
8031         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8032         "parse_gdbarch" with method call.
8033         * c-exp.y (parse_type, parse_number, classify_name): Replace
8034         "parse_gdbarch" with method call.
8035         * ada-lex.l: Replace "parse_gdbarch" with method call.
8036         * ada-exp.y (parse_type, find_primitive_type, type_char)
8037         (type_system_address): Replace "parse_gdbarch" with method call.
8038
8039 2019-04-04  Tom Tromey  <tom@tromey.com>
8040
8041         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8042         * stap-probe.c (stap_parse_argument): Update.
8043         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8044         initial_size parameter.
8045         * rust-exp.y (rust_lex_tests): Update.
8046         * parse.c (parser_state): Update.
8047         (parse_exp_in_context): Update.
8048         * parser-defs.h (struct parser_state) <parser_state>: Remove
8049         "initial_size" parameter.
8050
8051 2019-04-04  Tom Tromey  <tom@tromey.com>
8052
8053         * parser-defs.h (increase_expout_size): Don't declare.
8054         * parse.c (increase_expout_size): Now static.
8055
8056 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8057
8058         * gnu-nat.c (gnu_nat_target::wait): Fix
8059         target_waitstatus_to_string call.
8060
8061 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8062
8063         * eval.c (evaluate_subexp_standard): Handle internal functions
8064         during Fortran function call handling.
8065
8066 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8067
8068         * NEWS: Mention new internal functions.
8069         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8070         (read_base_type): Use dwarf2_init_complex_target_type.
8071         * value.c (creal_internal_fn): New function.
8072         (cimag_internal_fn): New function.
8073         (_initialize_values): Register new internal functions.
8074
8075 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8076
8077         * infrun.c (stop_all_threads): If debug_infrun, always
8078         trace the wait status after wait_one, using
8079         target_waitstatus_to_string and target_pid_to_str.
8080         (handle_inferior_event): Replace various trace of
8081         wait status kind by a single trace.
8082         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8083         wait status kind image by target_waitstatus_to_string.
8084         * target/waitstatus.c (target_waitstatus_to_string): Fix
8085         obsolete comment.
8086
8087 2019-04-01  Tom Tromey  <tromey@adacore.com>
8088
8089         PR symtab/23331:
8090         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8091
8092 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8093             Pedro Alves  <palves@redhat.com>
8094
8095         * top.c (quit_force): Call 'finalize_values'.
8096         * value.c (finalize_values): New function.
8097         * value.h (finalize_values): Declare.
8098
8099 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8100
8101         * NEWS: Announce $_gdb_major and $_gdb_minor.
8102
8103         * top.c (init_gdb_version_vars): New function.
8104         (gdb_init): Call init_gdb_version_vars.
8105
8106 2019-03-29  Tom Tromey  <tromey@adacore.com>
8107
8108         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8109         help text.  Remove dead code.
8110
8111 2019-03-29  Keith Seitz  <keiths@redhat.com>
8112
8113         From Siddhesh Poyarekar:
8114         * f-lang.h (f77_get_upperbound): Return LONGEST.
8115         (f77_get_lowerbound): Likewise.
8116         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8117         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8118         print them.
8119         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8120         plongest to format print it.
8121         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8122         (f77_get_upperbound): Likewise.
8123         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8124         LOWER_BOUND to LONGEST.
8125         (f77_create_arrayprint_offset_tbl): Likewise.
8126
8127 2019-03-29  Keith Seitz  <keiths@redhat.com>
8128
8129         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8130         %s/pulongest for TYPE_LENGTH instead of %d in format
8131         strings.
8132         * ada-typerint.c (ada_print_type): Likewise.
8133         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8134         * compile/compile-c-support.c (generate_register_struct): Likewise.
8135         * gdbtypes.c (recursive_dump_type): Likewise.
8136         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8137         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8138         instead of %d in format strings.
8139         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8140         to std::min to ULONGEST.
8141         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8142         instead of %d in format strings.
8143         * tracepoint.c (info_scope_command): Likewise.
8144         * typeprint.c (print_offset_data::update)
8145         (print_offset_data::finish): Likewise.
8146         * xtensa-tdep.c (xtensa_store_return_value)
8147         (xtensa_push_dummy_call): Likewise.
8148
8149 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8150
8151         * windows-nat.c (display_selector): Fixed format specifications
8152         for 64-bit Cygwin.
8153
8154 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8155
8156         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8157
8158 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8159
8160         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8161         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8162         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8163         (nios2_linux_init_abi): Install it.
8164
8165 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8166
8167         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8168
8169 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8170
8171         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8172
8173 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8174             Tom Tromey  <tromey@adacore.com>
8175
8176         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8177
8178 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8179
8180         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8181         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8182         method to compute the bounds of range types. Also print "[evaluated]"
8183         if the bounds' values come from a dynamic evaluation.
8184
8185 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8186
8187         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8188         whitespace when pretty printing is on.
8189
8190 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8191
8192         * ppc-linux-nat.c: Add include.
8193
8194 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8195
8196         * NEWS: Mention AArch64 Pointer Authentication.
8197
8198 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8199
8200         * arm-linux-nat.c: Add include.
8201
8202 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8203
8204         * source-cache.c (source_cache::get_source_lines): Re-read
8205         fullname after calling open_source_file.
8206
8207 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8208
8209         * NEWS: Mention TLS support for FreeBSD.
8210
8211 2019-03-25  Tom Tromey  <tromey@adacore.com>
8212
8213         * minsyms.c (BUNCH_SIZE): Update comment.
8214         (~minimal_symbol_reader): Remove old comment.
8215         (compact_minimal_symbols): Update comment.
8216         (minimal_symbol_reader::install): Remove old comment.  Update
8217         other comments.
8218
8219 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8220
8221         * s390-linux-nat.c: Add include.
8222
8223 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8224
8225         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8226         Call linux_get_hwcap.
8227         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8228         Likewise.
8229         (aarch64_linux_get_hwcap): Remove function.
8230         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8231         declaration.
8232         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8233         linux_get_hwcap.
8234         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8235         * linux-tdep.c (linux_get_hwcap): Add function.
8236         (linux_get_hwcap2): Likewise.
8237         * linux-tdep.h (linux_get_hwcap): Add declaration.
8238         (linux_get_hwcap2): Likewise.
8239         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8240         (ppc_linux_get_hwcap2): Likewise.
8241         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8242         linux_get_hwcap.
8243         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8244         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8245         (ppc_linux_nat_target::read_description): Likewise.
8246         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8247         * s390-linux-nat.c: Likewise.
8248         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8249
8250 2019-03-24  Tom Tromey  <tom@tromey.com>
8251
8252         * ada-lang.c (standard_lookup): Simplify initialization.
8253         (ada_lookup_symbol_nonlocal): Simplify return.
8254         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8255         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8256         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8257         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8258         initialization.
8259         * solib.c (solib_global_lookup): Simplify.
8260         * symtab.c (null_block_symbol): Remove.
8261         (symbol_cache_lookup): Simplify returns.
8262         (lookup_language_this): Simplify returns.
8263         (lookup_symbol_aux): Simplify return.
8264         (lookup_local_symbol): Simplify returns.
8265         (lookup_global_symbol_from_objfile): Simplify return.
8266         (lookup_symbol_in_objfile_symtabs)
8267         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8268         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8269         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8270         * cp-namespace.c (cp_lookup_bare_symbol)
8271         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8272         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8273         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8274         (cp_lookup_symbol_via_imports): Simplify initialization.
8275         (find_symbol_in_baseclass): Likewise.
8276         * symtab.h (null_block_symbol): Remove.
8277         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8278         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8279         (d_lookup_symbol_module): Likewise.
8280         (find_symbol_in_baseclass): Simplify initialization.
8281
8282 2019-03-24  Tom Tromey  <tom@tromey.com>
8283
8284         * expression.h: Don't include symtab.h.
8285         (struct block): Forward declare.
8286
8287 2019-03-24  Tom Tromey  <tom@tromey.com>
8288
8289         * c-exp.y (typebase): Remove casts.
8290         * gdbtypes.c (lookup_unsigned_typename, )
8291         (lookup_signed_typename): Remove cast.
8292         * eval.c (parse_to_comma_and_eval): Remove cast.
8293         * parse.c (write_dollar_variable): Remove cast.
8294         * block.h (struct block) <superblock>: Now const.
8295         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8296         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8297         (map_block): Make "block" const.
8298         * symfile.h (struct quick_symbol_functions)
8299         <map_matching_symbols>: Constify block argument to "callback".
8300         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8301         const.
8302         (find_pc_sect_compunit_symtab): Make "b" const.
8303         (find_symbol_at_address): Likewise.
8304         (search_symbols): Likewise.
8305         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8306         (dw2_debug_names_lookup_symbol): Likewise.
8307         (dw2_map_matching_symbols): Update.
8308         * p-valprint.c (pascal_val_print): Remove "block".
8309         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8310         (aux_add_nonlocal_symbols): Make "block" const.
8311         (resolve_subexp): Remove cast.
8312         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8313         const.
8314         (iterate_over_file_blocks): Likewise.
8315         * f-exp.y (%union) <bval>: Remove.
8316         * coffread.c (patch_opaque_types): Make "b" const.
8317         * spu-tdep.c (spu_catch_start): Make "block" const.
8318         * c-valprint.c (print_unpacked_pointer): Remove "block".
8319         * symmisc.c (dump_symtab_1): Make "b" const.
8320         (block_depth): Make "block" const.
8321         * d-exp.y (%union) <bval>: Remove.
8322         * cp-support.h (cp_lookup_rtti_type): Update.
8323         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8324         * psymtab.c (psym_lookup_symbol): Make "block" const.
8325         (maintenance_check_psymtabs): Make "b" const.
8326         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8327         (enumerate_locals, enumerate_args): Update.
8328         * python/py-symtab.c (stpy_global_block): Make "block" const.
8329         (stpy_static_block): Likewise.
8330         * inline-frame.c (block_starting_point_at): Make "new_block"
8331         const.
8332         * block.c (find_block_in_blockvector): Make return type const.
8333         (blockvector_for_pc_sect): Make "b" const.
8334         (find_block_in_blockvector): Make "b" const.
8335
8336 2019-03-23  Tom Tromey  <tom@tromey.com>
8337
8338         * varobj.c (varobj_create): Update.
8339         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8340         * printcmd.c (display_command, do_one_display): Don't reset
8341         innermost_block.
8342         * parser-defs.h (enum innermost_block_tracker_type): Move to
8343         expression.h.
8344         (innermost_block): Update comment.
8345         * parse.c (parse_exp_1): Add tracker_types parameter.
8346         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8347         tracker_types parameter.  Reset innermost_block.
8348         (parse_exp_in_context): Remove.
8349         (parse_expression_for_completion): Update.
8350         * objfiles.c (~objfile): Don't reset expression_context_block or
8351         innermost_block.
8352         * expression.h (enum innermost_block_tracker_type): Move from
8353         parser-defs.h.
8354         (parse_exp_1): Add tracker_types parameter.
8355         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8356         reset innermost_block.
8357
8358 2019-03-23  Tom Tromey  <tom@tromey.com>
8359
8360         * objfiles.h: Include bcache.h.
8361
8362 2019-03-23  Tom Tromey  <tom@tromey.com>
8363
8364         * linespec.c (get_current_search_block): Use
8365         scoped_restore_current_language.
8366         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8367
8368 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8369             Jiong Wang  <jiong.wang@arm.com>
8370
8371         * aarch64-linux-tdep.c
8372         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8373         section.
8374         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8375
8376 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8377             Jiong Wang  <jiong.wang@arm.com>
8378
8379         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8380         instructions.
8381         (aarch64_analyze_prologue_test): Add PACIASP test.
8382         (aarch64_prologue_prev_register): Unmask PC value.
8383
8384 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8385             Jiong Wang  <jiong.wang@arm.com>
8386
8387         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8388         (aarch64_dwarf2_prev_register): Unmask PC value.
8389         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8390         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8391         DW_CFA_AARCH64_negate_ra_state.
8392         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8393
8394 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8395             Jiong Wang  <jiong.wang@arm.com>
8396
8397         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8398         registers.
8399         (aarch64_pseudo_register_name): Likewise.
8400         (aarch64_pseudo_register_type): Likewise.
8401         (aarch64_pseudo_register_reggroup_p): Likewise.
8402         (aarch64_gdbarch_init): Add pauth registers.
8403         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8404         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8405         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8406         (struct gdbarch_tdep): Add regnum for ra_state.
8407
8408 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8409             Jiong Wang  <jiong.wang@arm.com>
8410
8411         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8412
8413 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8414             Jiong Wang  <jiong.wang@arm.com>
8415
8416         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8417         function.
8418         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8419         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8420         (aarch64_gdbarch_init): Add puth registers.
8421         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8422         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8423         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8424
8425 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8426             Jiong Wang  <jiong.wang@arm.com>
8427
8428         * aarch64-linux-nat.c
8429         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8430         * aarch64-linux-tdep.c
8431         (aarch64_linux_core_read_description): Likewise.
8432         (aarch64_linux_get_hwcap): New function.
8433         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8434         (aarch64_linux_get_hwcap): New declaration.
8435
8436 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8437             Jiong Wang  <jiong.wang@arm.com>
8438
8439         * aarch64-linux-nat.c
8440         (aarch64_linux_nat_target::read_description): Add pauth param.
8441         * aarch64-linux-tdep.c
8442         (aarch64_linux_core_read_description): Likewise.
8443         * aarch64-tdep.c (struct target_desc): Add in pauth.
8444         (aarch64_read_description): Add pauth param.
8445         (aarch64_gdbarch_init): Likewise.
8446         * aarch64-tdep.h (aarch64_read_description): Likewise.
8447         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8448         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8449         * features/Makefile: Add new files.
8450         * features/aarch64-pauth.c: New file.
8451         * features/aarch64-pauth.xml: New file.
8452
8453 2019-03-20  Tom Tromey  <tromey@adacore.com>
8454
8455         * infrun.c (handle_inferior_event): Rename from
8456         handle_inferior_event_1.  Create a scoped_value_mark.
8457         (handle_inferior_event): Remove.
8458
8459 2019-03-19  Tom Tromey  <tromey@adacore.com>
8460
8461         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8462         * infrun.h (print_stop_event): Add "displays" parameter.
8463         * infrun.c (print_stop_event): Add "displays" parameter.
8464
8465 2019-03-19  Pedro Alves  <palves@redhat.com>
8466
8467         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8468         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8469         to -1.  Fix TABs vs spaces.
8470         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8471         * tui/tui-out.h (tui_ui_out) Add intro comments.
8472         <m_line, m_start_of_line>: In-class initialize, and add describing
8473         comment.
8474
8475 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8476
8477         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8478         variable names.
8479         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8480
8481 2019-03-18  Pedro Alves  <palves@redhat.com>
8482             Eli Zaretskii <eliz@gnu.org>
8483
8484         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8485         m_line and m_start_of_line.
8486
8487 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8488
8489         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8490         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8491         it returns a newline.  This fixes a regression in TU mode, whereby
8492         the next line is output on the same screen line as the user input.
8493
8494 2019-03-18  Tom Tromey  <tromey@adacore.com>
8495
8496         * minsyms.c (minimal_symbol_reader::install): Remove call to
8497         obstack_blank.
8498
8499 2019-03-18  Pedro Alves  <palves@redhat.com>
8500
8501         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8502         New globals.
8503         (apply_style): New, factored out from ...
8504         (apply_ansi_escape): ... this.  Handle reverse video mode.
8505         (tui_set_reverse_mode): New function.
8506         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8507         * tui/tui-winsource.c (tui_show_source_line): Use
8508         tui_set_reverse_mode instead of setting A_STANDOUT.
8509         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8510         New setter methods.
8511
8512 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8513
8514         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8515         Handle tabs.
8516
8517 2019-03-18  Tom Tromey  <tromey@adacore.com>
8518
8519         * ada-lang.c (empty_array): Add "high" parameter.
8520         (ada_evaluate_subexp): Update.
8521
8522 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8523
8524         * unittests/string_view-selftests.c: Define
8525         _initialize_string_view_selftests unconditionally.
8526
8527 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8528
8529         PR gdb/24350
8530         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8531
8532 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8533
8534         PR gdb/24351
8535         * windows-nat.c (display_selector): Fix format specifiers.
8536
8537 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8538
8539         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8540         tui_refill_source_window instead of tui_refresh_win, to update the
8541         current execution line.  This fixes redisplay of the current line
8542         when stepping through the code with "next" or "step".
8543
8544 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8545
8546         * source-cache.c (source_cache::get_source_lines): Call
8547         find_source_lines to initialize s->nlines.  This fixes vertical
8548         scrolling of TUI source window when the DOWN arrow is pressed.
8549
8550 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8551
8552         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8553         linux-thread-db.c (_initialize_thread_db): Likewise.
8554
8555 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8556
8557         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8558         wclrtoeol in tui_show_source_line".  This reverts changes made in
8559         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8560
8561 2019-03-15  Tom Tromey  <tom@tromey.com>
8562
8563         * symtab.h (struct minimal_symbol): Derive from
8564         general_symbol_info.
8565         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8566         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8567         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8568         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8569         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8570         (MSYMBOL_SEARCH_NAME): Update.
8571         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8572         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8573         * minsyms.c (minimal_symbol_reader::record_full): Update.
8574
8575 2019-03-15  Tom Tromey  <tom@tromey.com>
8576
8577         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8578
8579 2019-03-15  Tom Tromey  <tom@tromey.com>
8580
8581         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8582         unique_xmalloc_ptr.
8583         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8584         Update.
8585         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8586         (build_minimal_symbol_hash_tables)
8587         (minimal_symbol_reader::install): Update.
8588
8589 2019-03-15  Tom Tromey  <tom@tromey.com>
8590
8591         * symtab.c (create_demangled_names_hash): Update.
8592         (symbol_set_names): Update.
8593         * objfiles.h (struct objfile_per_bfd_storage)
8594         <demangled_names_hash>: Now an htab_up.
8595         * objfiles.c (objfile_per_bfd_storage): Simplify.
8596
8597 2019-03-15  Tom Tromey  <tom@tromey.com>
8598
8599         * objfiles.h (struct objfile_per_bfd_storage): Declare
8600         destructor.
8601         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8602         New.
8603         (get_objfile_bfd_data): Use new.  Don't initialize
8604         language_of_main.
8605         (free_objfile_per_bfd_storage): Remove.
8606         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8607
8608 2019-03-15  Tom Tromey  <tom@tromey.com>
8609
8610         * symfile.c (reread_symbols): Update.
8611         * objfiles.c (objfile::objfile): Update.
8612         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8613         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8614         comment.
8615         (minimal_symbol_reader::install): Update.
8616         (terminate_minimal_symbol_table): Remove.
8617         * jit.c (jit_object_close_impl): Update.
8618
8619 2019-03-15  Tom Tromey  <tom@tromey.com>
8620
8621         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8622         initializations.
8623
8624 2019-03-15  Tom Tromey  <tom@tromey.com>
8625
8626         * objfiles.h (struct objfile_per_bfd_storage)
8627         <demangled_hash_languages>: Now a bitset.
8628         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8629         (lookup_minimal_symbol): Update.
8630
8631 2019-03-15  Tom Tromey  <tom@tromey.com>
8632
8633         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8634         Don't return the symbol.
8635         * coffread.c (record_minimal_symbol): Use record_full.
8636
8637 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8638
8639         The MS-Windows port of ncurses fails to switch to a color pair if
8640         one or both of the colors are the implicit default colors.  This
8641         change records the default colors when TUI is initialized, and
8642         then specifies them explicitly when a color pair uses the default
8643         colors.  This allows color styling in TUI mode on MS-Windows.
8644
8645         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8646         ncurses_norm_attr.
8647         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8648         colors in ncurses_norm_attr.
8649         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8650         "none", replace it with the default color recorded in
8651         ncurses_norm_attr.
8652
8653 2019-03-14  Tom Tromey  <tromey@adacore.com>
8654
8655         * source-cache.h (class source_cache) <get_source_lines>: Return
8656         std::string.
8657         * source-cache.c (source_cache::extract_lines): Handle case where
8658         first_pos==npos.  Return std::string.
8659         (source_cache::get_source_lines): Update.
8660
8661 2019-03-14  Tom Tromey  <tromey@adacore.com>
8662
8663         * NEWS: Add item for "style sources" commands.
8664         * source-cache.c (source_cache::get_source_lines): Check
8665         source_styling.
8666         * cli/cli-style.c (source_styling): New global.
8667         (_initialize_cli_style): Add "style sources" commands.
8668         (show_style_sources): New function.
8669         * cli/cli-style.h (source_styling): Declare.
8670
8671 2019-03-14  Pedro Alves  <palves@redhat.com>
8672             Tom Tromey  <tromey@adacore.com>
8673
8674         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8675         * tui/tui-winsource.c (tui_refill_source_window): New function,
8676         from...
8677         (tui_horizontal_source_scroll): ... here.  Move some logic.
8678         * cli/cli-style.c (set_style_enabled): Notify new observable.
8679         * tui/tui-hooks.c (tui_redisplay_source): New function.
8680         (tui_attach_detach_observers): Attach or detach
8681         tui_redisplay_source.
8682         * observable.h (source_styling_changed): New observable.
8683         * observable.c: Define source_styling_changed observable.
8684
8685 2019-03-13  Tom Tromey  <tromey@adacore.com>
8686
8687         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8688         (i386_gnu_nat_target::store_registers): Update.
8689         * target-debug.h (target_debug_print_std_string): New macro.
8690         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8691         * windows-tdep.c (display_one_tib): Update.
8692         * tui/tui-stack.c (tui_make_status_line): Update.
8693         * top.c (print_inferior_quit_action): Update.
8694         * thread.c (thr_try_catch_cmd): Update.
8695         (add_thread_with_info): Update.
8696         (thread_target_id_str): Update.
8697         (thr_try_catch_cmd): Update.
8698         (thread_command): Update.
8699         (thread_find_command): Update.
8700         * record-btrace.c (record_btrace_target::info_record)
8701         (record_btrace_resume_thread, record_btrace_target::resume)
8702         (record_btrace_cancel_resume, record_btrace_step_thread)
8703         (record_btrace_target::wait, record_btrace_target::wait)
8704         (record_btrace_target::wait, record_btrace_target::stop): Update.
8705         * progspace.c (print_program_space): Update.
8706         * process-stratum-target.c
8707         (process_stratum_target::thread_address_space): Update.
8708         * linux-fork.c (linux_fork_mourn_inferior)
8709         (detach_checkpoint_command, info_checkpoints_command)
8710         (linux_fork_context): Update.
8711         (linux_fork_detach): Update.
8712         (class scoped_switch_fork_info): Update.
8713         (delete_checkpoint_command): Update.
8714         * infrun.c (follow_fork_inferior): Update.
8715         (follow_fork_inferior): Update.
8716         (proceed_after_vfork_done): Update.
8717         (handle_vfork_child_exec_or_exit): Update.
8718         (follow_exec): Update.
8719         (displaced_step_prepare_throw): Update.
8720         (displaced_step_restore): Update.
8721         (start_step_over): Update.
8722         (resume_1): Update.
8723         (clear_proceed_status_thread): Update.
8724         (proceed): Update.
8725         (print_target_wait_results): Update.
8726         (do_target_wait): Update.
8727         (context_switch): Update.
8728         (stop_all_threads): Update.
8729         (restart_threads): Update.
8730         (finish_step_over): Update.
8731         (handle_signal_stop): Update.
8732         (switch_back_to_stepped_thread): Update.
8733         (keep_going_pass_signal): Update.
8734         (print_exited_reason): Update.
8735         (normal_stop): Update.
8736         * inferior.c (inferior_pid_to_str): Change return type.
8737         (print_selected_inferior): Update.
8738         (add_inferior): Update.
8739         (detach_inferior): Update.
8740         * dummy-frame.c (fprint_dummy_frames): Update.
8741         * dcache.c (dcache_info_1): Update.
8742         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8743         (btrace_fetch, btrace_clear): Update.
8744         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8745         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8746         type.
8747         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8748         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8749         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8750         * gdbarch.c, gdbarch.h: Rebuild.
8751         * gdbarch.sh (core_pid_to_str): Change return type.
8752         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8753         return type.
8754         (windows_nat_target::pid_to_str): Change return type.
8755         (windows_delete_thread): Update.
8756         (windows_nat_target::attach): Update.
8757         (windows_nat_target::files_info): Update.
8758         * target-delegates.c: Rebuild.
8759         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8760         return type.
8761         (sol_thread_target::pid_to_str): Change return type.
8762         * remote.c (class remote_target) <pid_to_str>: Change return
8763         type.
8764         (remote_target::pid_to_str): Change return type.
8765         (extended_remote_target::attach, remote_target::remote_stop_ns)
8766         (remote_target::remote_notif_remove_queued_reply)
8767         (remote_target::push_stop_reply, remote_target::disable_btrace):
8768         Update.
8769         (extended_remote_target::attach): Update.
8770         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8771         type.
8772         (gdbsim_target::pid_to_str): Change return type.
8773         * ravenscar-thread.c (struct ravenscar_thread_target)
8774         <pid_to_str>: Change return type.
8775         (ravenscar_thread_target::pid_to_str): Change return type.
8776         * procfs.c (class procfs_target) <pid_to_str>: Change return
8777         type.
8778         (procfs_target::pid_to_str): Change return type.
8779         (procfs_target::attach): Update.
8780         (procfs_target::detach): Update.
8781         (procfs_target::fetch_registers): Update.
8782         (procfs_target::store_registers): Update.
8783         (procfs_target::wait): Update.
8784         (procfs_target::files_info): Update.
8785         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8786         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8787         return type.
8788         (nto_procfs_target::pid_to_str): Change return type.
8789         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8790         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8791         return type.
8792         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8793         (exit_lwp): Update.
8794         (attach_proc_task_lwp_callback, get_detach_signal)
8795         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8796         (linux_nat_target::resume, wait_lwp, stop_callback)
8797         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8798         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8799         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8800         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8801         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8802         type.
8803         (inf_ptrace_target::attach): Update.
8804         (inf_ptrace_target::files_info): Update.
8805         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8806         type.
8807         (go32_nat_target::pid_to_str): Change return type.
8808         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8809         (gnu_nat_target::wait): Update.
8810         (gnu_nat_target::wait): Update.
8811         (gnu_nat_target::resume): Update.
8812         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8813         (fbsd_nat_target::wait): Update.
8814         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8815         type.
8816         (darwin_nat_target::attach): Update.
8817         * corelow.c (class core_target) <pid_to_str>: Change return type.
8818         (core_target::pid_to_str): Change return type.
8819         * target.c (normal_pid_to_str): Change return type.
8820         (default_pid_to_str): Likewise.
8821         (target_pid_to_str): Change return type.
8822         (target_translate_tls_address): Update.
8823         (target_announce_detach): Update.
8824         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8825         return type.
8826         (bsd_uthread_target::pid_to_str): Change return type.
8827         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8828         type.
8829         (bsd_kvm_target::pid_to_str): Change return type.
8830         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8831         return type.
8832         (aix_thread_target::pid_to_str): Change return type.
8833         * target.h (struct target_ops) <pid_to_str>: Change return type.
8834         (target_pid_to_str, normal_pid_to_str): Likewise.
8835         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8836         type.
8837         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8838         type.
8839         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8840         return type.
8841         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8842         type.
8843         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8844         type.
8845         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8846         return type.
8847
8848 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8849
8850         * NEWS: Mention that the new default MI version is 3.  Mention
8851         changes to the output of commands and events that deal with
8852         multi-location breakpoints.
8853         * breakpoint.c: Include "mi/mi-out.h".
8854         (print_one_breakpoint): Change output syntax if using MI version
8855         >= 3.
8856         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8857         New.
8858         (mi_multi_location_breakpoint_output_fixed): New.
8859         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8860         (mi_cmd_fix_multi_location_breakpoint_output): New.
8861         (mi_multi_location_breakpoint_output_fixed): New.
8862         * mi/mi-cmds.c (mi_cmds): Register command
8863         -fix-multi-location-breakpoint-output.
8864         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8865         interpreter "mi".
8866
8867 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8868
8869         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8870         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8871         instantiate mi_ui_out based on interpreter name.
8872         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8873         * mi/mi-main.c (mi_load_progress): Likewise.
8874
8875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8876
8877         * NEWS: Combine separate "New targets" sections for 8.3.
8878
8879 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8880
8881         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8882         (ppcfbsd_init_abi): Install gdbarch
8883         "fetch_tls_load_module_address" and "get_thread_local_address"
8884         methods.
8885
8886 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8887
8888         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8889         (riscv_fbsd_init_abi): Install gdbarch
8890         "fetch_tls_load_module_address" and "get_thread_local_address"
8891         methods.
8892
8893 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8894
8895         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8896         (i386fbsd_init_abi): Install gdbarch
8897         "fetch_tls_load_module_address" and "get_thread_local_address"
8898         methods.
8899
8900 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8901
8902         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8903         (amd64fbsd_init_abi): Install gdbarch
8904         "fetch_tls_load_module_address" and "get_thread_local_address"
8905         methods.
8906
8907 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8908
8909         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8910         (struct fbsd_pspace_data): New type.
8911         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8912         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8913         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8914         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8915         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8916
8917 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8918
8919         * gdbtypes.c (lookup_struct_elt): New function.
8920         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8921         * gdbtypes.h (struct struct_elt): New type.
8922         (lookup_struct_elt): New prototype.
8923
8924 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8925
8926         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8927         remove disabled code block.
8928
8929 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8930
8931         * gdbarch.sh (get_thread_local_address): New method.
8932         * gdbarch.h, gdbarch.c: Regenerate.
8933         * target.c (target_translate_tls_address): Use
8934         gdbarch_get_thread_local_address if present instead of
8935         target::get_thread_local_address.
8936
8937 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8938
8939         * target.h (target::get_thread_local_address): Update comment.
8940
8941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8942
8943         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8944         objfile->separate_debug_objfile_backlink if not NULL.
8945
8946 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8947
8948         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8949         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8950         (amd64bsd_store_inferior_registers): Likewise.
8951         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8952         Enable segment base registers.
8953         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8954         PT_GETFSBASE and PT_GETGSBASE.
8955         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8956         PT_SETGSBASE.
8957         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8958         segment base registers.
8959         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8960
8961 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8962
8963         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8964         Update calls to i386_target_description to add 'segments'
8965         parameter.
8966         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8967         add segment base registers.
8968         * arch/i386.c (i386_create_target_description): Add 'segments'
8969         parameter to enable segment base registers.
8970         * arch/i386.h (i386_create_target_description): Likewise.
8971         * features/i386/32bit-segments.xml: New file.
8972         * features/i386/32bit-segments.c: Generate.
8973         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8974         call to i386_target_description to add 'segments' parameter.
8975         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8976         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8977         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8978         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8979         if feature is present.
8980         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8981         Add 'segments' parameter to call to i386_target_description.
8982         (i386_target_description): Add 'segments' parameter to enable
8983         segment base registers.
8984         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8985         to call to i386_target_description.
8986         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8987         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8988         Define I386_NUM_REGS.
8989         (i386_target_description): Add 'segments' parameter to enable
8990         segment base registers.
8991
8992 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8993
8994         PR/24325
8995         * source-cache.c: #undef open and close, to avoid unresolved
8996         externals during linking.
8997
8998 2019-03-12  Tom Tromey  <tromey@adacore.com>
8999
9000         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9001         const.  Add initializers.
9002         (_initialize_remote): Don't initialize ptid globals.
9003
9004 2019-03-12  Pedro Alves  <palves@redhat.com>
9005
9006         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9007
9008 2019-03-12  Pedro Alves  <palves@redhat.com>
9009
9010         * cp-name-parser.y (main): Remove unused 'len' variable.
9011
9012 2019-03-12  Tom Tromey  <tromey@adacore.com>
9013
9014         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9015         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9016
9017 2019-03-12  Tom Tromey  <tromey@adacore.com>
9018
9019         * linux-nat.c (iterate_over_lwps): Update.
9020         (stop_callback): Remove parameter.
9021         (stop_wait_callback, detach_callback, resume_set_callback)
9022         (select_singlestep_lwp_callback, set_ignore_sigint)
9023         (status_callback, resumed_callback, resume_clear_callback)
9024         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9025         data parameter.
9026         (linux_nat_target::detach, linux_nat_target::resume)
9027         (linux_stop_and_wait_all_lwps, select_event_lwp)
9028         (linux_nat_filter_event, linux_nat_wait_1)
9029         (linux_nat_target::kill, linux_nat_target::stop)
9030         (linux_nat_target::stop): Update.
9031         (linux_nat_resume_callback): Change type.
9032         (resume_stopped_resumed_lwps, count_events_callback)
9033         (select_event_lwp_callback): Likewise.
9034         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9035         * arm-linux-nat.c (struct update_registers_data): Remove.
9036         (update_registers_callback): Change type.
9037         (arm_linux_insert_hw_breakpoint1): Update.
9038         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9039         parameter.
9040         (x86_linux_dr_set_addr): Update.
9041         (x86_linux_dr_set_control): Update.
9042         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9043         (iterate_over_lwps): Use gdb::function_view.
9044         * nat/aarch64-linux-hw-point.c (struct
9045         aarch64_dr_update_callback_param): Remove.
9046         (debug_reg_change_callback): Change type.
9047         (aarch64_notify_debug_reg_change): Update.
9048         * s390-linux-nat.c (s390_refresh_per_info): Update.
9049
9050 2019-03-11  Tom Tromey  <tromey@adacore.com>
9051
9052         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9053         redundant assignment to "this_cu".
9054
9055 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9056
9057         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9058
9059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9060
9061         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9062         from...
9063         (rank_one_type): ... this.
9064
9065 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9066
9067         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9068         from...
9069         (rank_one_type): ... this.
9070
9071 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9072
9073         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9074         from...
9075         (rank_one_type): ... this.
9076
9077 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9078
9079         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9080         from...
9081         (rank_one_type): ... this.
9082
9083 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9084
9085         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9086         from...
9087         (rank_one_type): ... this.
9088
9089 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9090
9091         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9092         from...
9093         (rank_one_type): ... this.
9094
9095 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9096
9097         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9098         from...
9099         (rank_one_type): ... this.
9100
9101 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9102
9103         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9104         from...
9105         (rank_one_type): ... this.
9106
9107 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9108
9109         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9110         from...
9111         (rank_one_type): ... this.
9112
9113 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9114
9115         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9116         from...
9117         (rank_one_type): ... this.
9118
9119 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9120
9121         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9122         from...
9123         (rank_one_type): ... this.
9124
9125 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9126
9127         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9128         from...
9129         (rank_one_type): ... this.
9130
9131 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9132
9133         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9134         inferior-events' shows the example events.
9135
9136 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9137
9138         Support styling on native MS-Windows console
9139
9140         PR/24315
9141         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9142         on MS-Windows if $TERM is not defined.
9143
9144         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9145
9146         * posix-hdep.c (gdb_console_fputs):
9147         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9148         functions.
9149         * ui-file.h (gdb_console_fputs): Add prototype.
9150
9151         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9152         back to fputs only if the former returns zero.
9153
9154 2019-03-07  Tom Tromey  <tom@tromey.com>
9155
9156         * symmisc.c (print_symbol_bcache_statistics): Update.
9157         (print_objfile_statistics): Update.
9158         * symfile.c (allocate_symtab): Update.
9159         * stabsread.c: Don't include bcache.h.
9160         * psymtab.h (struct psymbol_bcache): Don't declare.
9161         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9162         (psymbol_bcache_init, psymbol_bcache_free)
9163         (psymbol_bcache_get_bcache): Don't declare.
9164         * psymtab.c (struct psymbol_bcache): Remove.
9165         (psymtab_storage::psymtab_storage): Update.
9166         (psymtab_storage::~psymtab_storage): Update.
9167         (psymbol_bcache_init, psymbol_bcache_free)
9168         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9169         (add_psymbol_to_bcache): Update.
9170         (allocate_psymtab): Update.
9171         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9172         macro_cache>: No longer pointers.
9173         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9174         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9175         * macrotab.c (macro_bcache): Update.
9176         * macroexp.c: Don't include bcache.h.
9177         * gdbtypes.c (check_types_worklist): Update.
9178         (types_deeply_equal): Remove TRY/CATCH.  Update.
9179         * elfread.c (elf_symtab_read): Update.
9180         * dwarf2read.c: Don't include bcache.h.
9181         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9182         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9183         (print_bcache_statistics, bcache_memory_used): Don't declare.
9184         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9185         methods.  Rename all data members.
9186         * bcache.c (struct bcache): Move to bcache.h.
9187         (bcache::expand_hash_table): Rename from expand_hash_table.
9188         (bcache): Remove.
9189         (bcache::insert): Rename from bcache_full.
9190         (bcache::compare): Rename from bcache_compare.
9191         (bcache_xmalloc): Remove.
9192         (bcache::~bcache): Rename from bcache_xfree.
9193         (bcache::print_statistics): Rename from print_bcache_statistics.
9194         (bcache::memory_used): Rename from bcache_memory_used.
9195
9196 2019-03-07  Pedro Alves  <palves@redhat.com>
9197
9198         * infrun.c (normal_stop): Also check for
9199         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9200
9201 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9202
9203         * f-lang.c (value_from_host_double): Moved to...
9204         * value.c (value_from_host_double): ...here.
9205         * value.h (value_from_host_double): Declare.
9206         * guile/scm-math.c (vlscm_convert_typed_number): Use
9207         value_from_host_double.
9208         (vlscm_convert_number): Likewise.
9209         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9210         * python/py-value.c (convert_value_from_python): Likewise.
9211
9212 2019-03-06  Tom Tromey  <tom@tromey.com>
9213
9214         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9215
9216 2019-03-06  Tom Tromey  <tom@tromey.com>
9217
9218         * utils.h (free_current_contents): Don't declare.
9219         * utils.c (free_current_contents): Remove.
9220
9221 2019-03-06  Tom Tromey  <tom@tromey.com>
9222
9223         * top.c (quit_force): Update.
9224         * main.c (captured_command_loop): Update.
9225         * common/new-op.c (operator new): Update.
9226         * common/common-exceptions.c (struct catcher)
9227         <save_cleanup_chain>: Remove member.
9228         (exceptions_state_mc_init): Update.
9229         (exception_try_scope_entry): Return nullptr.
9230         (exception_try_scope_exit, exception_rethrow)
9231         (throw_exception_sjlj, throw_exception_cxx): Update.
9232         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9233         (all_cleanups, do_cleanups, discard_cleanups)
9234         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9235         (restore_cleanups, restore_final_cleanups): Don't declare.
9236         (do_final_cleanups): Remove parameter.
9237         * common/cleanups.c (cleanup_chain, make_cleanup)
9238         (make_cleanup_dtor, all_cleanups, do_cleanups)
9239         (discard_my_cleanups, discard_cleanups)
9240         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9241         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9242         (null_cleanup): Remove.
9243         (do_final_cleanups): Remove parameter.
9244
9245 2019-03-06  Tom Tromey  <tom@tromey.com>
9246
9247         * remote.c (remote_target::remote_parse_stop_reply): Use
9248         unique_xmalloc_ptr.
9249
9250 2019-03-06  Tom Tromey  <tom@tromey.com>
9251
9252         * stabsread.c (struct stabs_field_info): Rename from field_info.
9253         <list, fnlist>: Add initializers.
9254         <obstack>: New member.
9255         (read_member_functions, read_struct_fields, read_baseclasses):
9256         Allocate on obstack.  Don't use cleanups.
9257         (read_one_struct_field, read_member_functions, read_struct_fields)
9258         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9259         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9260         (read_struct_type): Update.
9261
9262 2019-03-06  Tom Tromey  <tom@tromey.com>
9263
9264         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9265         * common/filestuff.h (make_cleanup_close): Don't declare.
9266         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9267         Remove.
9268
9269 2019-03-06  Tom Tromey  <tom@tromey.com>
9270
9271         * solib-aix.c: Use make_scope_exit.
9272
9273 2019-03-06  Tom Tromey  <tom@tromey.com>
9274
9275         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9276         Use make_scope_exit.
9277
9278 2019-03-06  Tom Tromey  <tom@tromey.com>
9279
9280         * solib-svr4.c (disable_probes_interface): Remove parameter.
9281         (svr4_handle_solib_event): Use make_scope_exit.
9282
9283 2019-03-06  Tom Tromey  <tom@tromey.com>
9284
9285         * remote.c (struct stop_reply_deleter): Remove.
9286         (stop_reply_up): Update.
9287         (struct stop_reply): Derive from notif_event.  Don't typedef.
9288         <regcache>: Now a std::vector.
9289         (stop_reply_xfree): Remove.
9290         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9291         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9292         (remote_target::discard_pending_stop_replies): Use delete.
9293         (remote_target::remote_parse_stop_reply): Update.
9294         (remote_target::process_stop_reply): Update.
9295         * remote-notif.h (struct notif_event): Add virtual destructor.
9296         Remove "dtr" member.
9297         (struct notif_client) <alloc_event>: Return a unique_ptr.
9298         (notif_event_xfree): Don't declare.
9299         (notif_event_up): New typedef.
9300         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9301         (notif_event_xfree, do_notif_event_xfree): Remove.
9302         (remote_notif_state_xfree): Update.
9303
9304 2019-03-06  Tom Tromey  <tom@tromey.com>
9305
9306         * infrun.c (displaced_step_clear_cleanup): Now a
9307         forward_scope_exit type.
9308         (displaced_step_prepare_throw): Update.
9309         (displaced_step_fixup): Update.
9310
9311 2019-03-06  Tom Tromey  <tom@tromey.com>
9312
9313         * inferior.h (class inferior): Update comment.
9314         * gdbthread.h (class thread_info): Update comment.
9315
9316 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9317             Tom Tromey  <tom@tromey.com>
9318
9319         * stabsread.h (struct stab_section_list): Remove.
9320         (coffstab_build_psymtabs): Update.
9321         * dbxread.c (symbuf_sections): Now a std::vector.
9322         (sect_idx): New global.
9323         (fill_symbuf): Update.
9324         (coffstab_build_psymtabs): Change type of stabsects parameter.
9325         Update.
9326         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9327         std::vector.
9328         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9329         (coff_locate_sections): Update.
9330         (coff_symfile_read): Remove cleanups.  Update.
9331         (init_stringtab): Add storage parameter.
9332         (free_stringtab, free_stringtab_cleanup): Remove.
9333         (init_lineno): Add storage parameter.
9334         (free_linetab, free_linetab_cleanup): Remove.
9335
9336 2019-03-06  Pedro Alves  <palves@redhat.com>
9337
9338         * linux-fork.c (fork_info::clobber_regs): Delete.
9339         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9340         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9341         comment.  Adjust.
9342         (scoped_switch_fork_info::scoped_switch_fork_info)
9343         (checkpoint_command, linux_fork_context): Adjust
9344         fork_save_infrun_state calls.
9345
9346 2019-03-06  Pedro Alves  <palves@redhat.com>
9347
9348         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9349         (inf_has_multiple_threads): Return 'bool' and rewrite using
9350         inferior_info::threads().
9351
9352 2019-03-06  Pedro Alves  <palves@redhat.com>
9353
9354         * linux-fork.c: Include <list>.
9355         (fork_list): Now a std::list instance.
9356         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9357         (forks_exist_p, find_last_fork): Adjust.
9358         (new_fork): Delete.
9359         (one_fork_p): New.
9360         (add_fork): Adjust.
9361         (free_fork): Delete, folded into fork_info::~fork_info().
9362         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9363         Adjust.
9364         (init_fork_list): Delete.
9365         (linux_fork_killall, linux_fork_mourn_inferior)
9366         (linux_fork_detach, info_checkpoints_command): Adjust.
9367         (_initialize_linux_fork): No longer call init_fork_list.
9368
9369 2019-03-06  Pedro Alves  <palves@redhat.com>
9370
9371         * linux-fork.c (new_fork): New, split out of ...
9372         (add_fork): ... this.  Return void.  Move "first fork" special
9373         case from here, to ...
9374         (checkpoint_command): ... here.
9375         * linux-linux.h (add_fork): Return void.
9376
9377 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9378
9379         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9380
9381 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9382             Chris January  <chris.january@arm.com>
9383             David Lecomber  <david.lecomber@arm.com>
9384
9385         * f-exp.y: New token, UNOP_INTRINSIC.
9386         (exp): New pattern using UNOP_INTRINSIC token.
9387         (f77_keywords): Add 'abs' keyword.
9388         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9389         (value_from_host_double): New function.
9390         (evaluate_subexp_f): Support UNOP_ABS.
9391
9392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9393
9394         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9395         types.
9396
9397 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9398
9399         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9400         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9401         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9402
9403 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9404
9405         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9406
9407 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9408             Chris January  <chris.january@arm.com>
9409
9410         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9411         * f-exp.y: Define 'KIND' token.
9412         (exp): New pattern for KIND expressions.
9413         (ptype): Handle types with a kind extension.
9414         (direct_abs_decl): Extend to spot kind extensions.
9415         (f77_keywords): Add 'kind' to the list.
9416         (push_kind_type): New function.
9417         (convert_to_kind_type): New function.
9418         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9419         * parse.c (operator_length_standard): Likewise.
9420         * parser-defs.h (enum type_pieces): Add tp_kind.
9421         * std-operator.def: Add UNOP_KIND.
9422
9423 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9424
9425         * f-exp.y (f_parse): Set yydebug.
9426
9427 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * f-lang.c (evaluate_subexp_f): New function.
9430         (exp_descriptor_f): New global.
9431         (f_language_defn): Use exp_descriptor_f instead of
9432         exp_descriptor_standard.
9433
9434 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9435
9436         * f-exp.y (struct token): Add comments.
9437         (dot_ops): Remove uppercase versions and the end marker.
9438         (f77_keywords): Likewise.
9439         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9440         entries in the dot_ops array are case insensitive, and use
9441         strncasecmp to compare strings.  Also some whitespace cleanup in
9442         this area.  Similar for the f77_keywords array, except entries in
9443         this list might be case sensitive.
9444
9445 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9446
9447         * f-exp.y (struct f77_boolean_val): Add comments.
9448         (boolean_values): Remove uppercase versions, and end marker.
9449         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9450         and use strncasecmp to achieve case insensitivity.  Additionally,
9451         perform whitespace cleanup around this code.
9452
9453 2019-03-06  Tom Tromey  <tromey@adacore.com>
9454
9455         * remote-sim.c (gdbsim_target_open): Use result of
9456         gdb_argv::release.
9457
9458 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9459         Dirk Schubert  <dirk.schubert@arm.com>
9460         Chris January  <chris.january@arm.com>
9461
9462         * eval.c (evaluate_subexp_standard): Call Fortran argument
9463         wrapping logic.
9464         * f-lang.c (struct value): A value which can be passed into a
9465         Fortran function call.
9466         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9467         where appropriate.
9468         (struct type): Value ready for a Fortran function call.
9469         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9470         is needed.
9471         * f-lang.h (fortran_argument_convert): Declaration.
9472         (fortran_preserve_arg_pointer): Declaration.
9473         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9474
9475 2019-03-05  Tom Tromey  <tromey@adacore.com>
9476
9477         * python/py-prettyprint.c (print_string_repr): Remove #if.
9478         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9479
9480 2019-03-05  Tom Tromey  <tromey@adacore.com>
9481
9482         * target.c (the_dummy_target): Move later.  Change type to
9483         "dummy_target".
9484         (initialize_targets): Don't initialize the_dummy_target.
9485
9486 2019-03-05  Tom Tromey  <tromey@adacore.com>
9487
9488         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9489         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9490
9491 2019-03-05  Tom Tromey  <tromey@adacore.com>
9492
9493         * windows-nat.c (windows_nat_target::attach)
9494         (windows_nat_target::detach): Don't call gdb_flush.
9495         * valprint.c (generic_val_print, val_print, val_print_string):
9496         Don't call gdb_flush.
9497         * utils.c (defaulted_query): Don't call gdb_flush.
9498         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9499         * target.c (target_announce_detach): Don't call gdb_flush.
9500         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9501         * remote.c (extended_remote_target::attach): Don't call
9502         gdb_flush.
9503         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9504         * printcmd.c (do_examine): Don't call gdb_flush.
9505         (info_display_command): Don't call gdb_flush.
9506         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9507         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9508         * memattr.c (info_mem_command): Don't call gdb_flush.
9509         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9510         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9511         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9512         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9513         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9514         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9515         (gnu_nat_target::detach): Don't call gdb_flush.
9516         * f-valprint.c (f_val_print): Don't call gdb_flush.
9517         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9518         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9519         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9520         gdb_flush.
9521         * c-valprint.c (c_val_print): Don't call gdb_flush.
9522         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9523
9524 2019-03-05  Tom Tromey  <tromey@adacore.com>
9525
9526         * varobj.c (update_dynamic_varobj_children): Update.
9527         (install_default_visualizer): Use reset, not release.
9528         * value.c (set_internalvar): Update.
9529         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9530         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9531         ATTRIBUTE_UNUSED_RESULT.
9532
9533 2019-03-05  Tom Tromey  <tromey@adacore.com>
9534
9535         * remote.c (class scoped_remote_fd) <release>: Add
9536         ATTRIBUTE_UNUSED_RESULT.
9537
9538 2019-03-05  Tom Tromey  <tromey@adacore.com>
9539
9540         * macroexp.c (struct macro_buffer) <release>: Add
9541         ATTRIBUTE_UNUSED_RESULT.
9542
9543 2019-03-05  Tom Tromey  <tromey@adacore.com>
9544
9545         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9546         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9547         ATTRIBUTE_UNUSED_RESULT.
9548
9549 2019-03-05  Tom Tromey  <tromey@adacore.com>
9550
9551         * common/scoped_fd.h (class scoped_fd) <release>: Add
9552         ATTRIBUTE_UNUSED_RESULT.
9553
9554 2019-03-05  Tom Tromey  <tromey@adacore.com>
9555
9556         * parser-defs.h (struct parser_state) <release>: Add
9557         ATTRIBUTE_UNUSED_RESULT.
9558
9559 2019-03-05  Tom Tromey  <tromey@adacore.com>
9560
9561         * utils.h (class gdb_argv) <release>: Add
9562         ATTRIBUTE_UNUSED_RESULT.
9563         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9564
9565 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9566
9567         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9568         for-loop range, to avoid compiler warnings.
9569
9570         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9571         avoid compiler warnings about unused variables.
9572
9573         * NEWS: Mention end of support for native debugging on MS-Windows
9574         before XP.
9575
9576         PR gdb/24292
9577         * common/netstuff.c:
9578         * gdbserver/gdbreplay.c
9579         * gdbserver/remote-utils.c:
9580         * ser-tcp.c:
9581         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9582         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9583         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9584         'getaddrinfo' and 'freeaddrinfo' were not available before
9585         Windows XP, and mingw.org's MinGW headers by default define
9586         _WIN32_WINNT to 0x500.
9587
9588 2019-03-01  Gary Benson <gbenson@redhat.com>
9589
9590         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9591
9592 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9593             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9594
9595         PR gdb/8527
9596         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9597         set_sigint_trap, clear_sigint_trap.
9598
9599 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9600
9601         * target.c (target_detach): Clear the regcache and the
9602         frame cache.
9603
9604 2019-02-27  Pedro Alves  <palves@redhat.com>
9605
9606         * utils.c (set_screen_size): When we cap the height/width sizes,
9607         tweak the corresponding command variable to show "unlimited":
9608
9609 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9610             Pedro Alves  <palves@redhat.com>
9611
9612         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9613         before calling rl_set_screen_size.
9614
9615 2019-02-27  Tom Tromey  <tromey@adacore.com>
9616
9617         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9618         define.
9619         * python/py-value.c: Remove Python 2.4 workaround.
9620         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9621         workaround.
9622         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9623         Python 2.4 workaround.
9624         * python/python-internal.h: Remove Python 2.4 comment.
9625         (Py_ssize_t): Don't define.
9626         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9627         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9628         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9629         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9630         * python/python.c (do_start_initialization): Remove Python 2.4
9631         workaround.
9632         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9633         (print_children): Remove Python 2.4 workaround.
9634         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9635         workaround.
9636         (CHARBUFFERPROC_NAME): Remove.
9637         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9638         Python 2.4 workaround.
9639
9640 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9641
9642         * NEWS: Note minimum Python version.
9643
9644 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9645
9646         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9647         code from these functions.  Remove corresponding ifdefs.  Use
9648         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9649         Remove gotos and target of gotos.
9650         (infpy_search_memory): Likewise.
9651
9652 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9653
9654         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9655         (hppa_gdbarch_init): Don't register deleted functions with
9656         gdbarch.
9657
9658 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9659
9660         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9661         (h8300_unwind_sp): Delete.
9662         (h8300_dummy_id): Delete.
9663         (h8300_gdbarch_init): Don't register deleted functions with
9664         gdbarch.
9665
9666 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9667
9668         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9669         (ft32_unwind_pc): Delete.
9670         (ft32_unwind_sp): Delete.
9671         (ft32_gdbarch_init): Don't register deleted functions with
9672         gdbarch.
9673
9674 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9675
9676         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9677         (frv_unwind_pc): Delete.
9678         (frv_unwind_sp): Delete.
9679         (frv_gdbarch_init): Don't register deleted functions with
9680         gdbarch.
9681
9682 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9683
9684         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9685         (riscv_unwind_pc): Delete.
9686         (riscv_unwind_sp): Delete.
9687         (riscv_gdbarch_init): Don't register deleted functions with
9688         gdbarch.
9689
9690 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9691
9692         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9693         (csky_unwind_pc): Delete.
9694         (csky_unwind_sp): Delete.
9695         (csky_gdbarch_init): Don't register deleted functions with
9696         gdbarch.
9697
9698 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9699
9700         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9701         (cris_unwind_pc): Delete.
9702         (cris_unwind_sp): Delete.
9703         (cris_gdbarch_init): Don't register deleted functions with
9704         gdbarch.
9705
9706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9707
9708         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9709         (bfin_unwind_pc): Delete.
9710         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9711
9712 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9713
9714         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9715         (arm_unwind_pc): Delete.
9716         (arm_unwind_sp): Delete.
9717         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9718
9719 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9720
9721         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9722         (arc_unwind_pc): Delete.
9723         (arc_unwind_sp): Delete.
9724         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9725
9726 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9727
9728         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9729         (alpha_unwind_pc): Delete.
9730         (alpha_gdbarch_init): Don't register deleted functions with
9731         gdbarch.
9732
9733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9734
9735         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9736         (aarch64_unwind_pc): Delete.
9737         (aarch64_unwind_sp): Delete.
9738         (aarch64_gdbarch_init): Don't register deleted functions with
9739         gdbarch.
9740
9741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9742
9743         * gdbtypes.c (type_align): Don't consider static members when
9744         computing structure alignment.
9745
9746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9747
9748         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9749         return 0 for other types.
9750         * arch-utils.c (default_type_align): Always return 0.
9751         * gdbarch.h: Regenerate.
9752         * gdbarch.sh (type_align): Extend comment.
9753         * gdbtypes.c (type_align): Add additional comments, always call
9754         gdbarch_type_align before applying the default rules.
9755         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9756         generic code will then apply a suitable default.
9757         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9758         types, return 0 for other types.
9759
9760 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9761
9762         * NEWS: Create a new section for the next release branch.
9763         Rename the section of the current branch, now that it has
9764         been cut.
9765
9766 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9767
9768         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9769         * version.in: Bump version to 8.3.50.DATE-git.
9770
9771 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9772
9773         * aix-thread.c (ptid_cmp): Remove unused variable.
9774         (get_signaled_thread): Likewise.
9775         (store_regs_user_thread): Likewise.
9776         (store_regs_kernel_thread): Likewise.
9777         (fetch_regs_kernel_thread): Remove shadowed variable.
9778
9779 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9780
9781         * features/riscv/32bit-cpu.xml: Add register numbers.
9782         * features/riscv/32bit-fpu.c: Regenerate.
9783         * features/riscv/32bit-fpu.xml: Add register numbers.
9784         * features/riscv/64bit-cpu.xml: Add register numbers.
9785         * features/riscv/64bit-fpu.c: Regenerate.
9786         * features/riscv/64bit-fpu.xml: Add register numbers.
9787
9788 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9789
9790         * NEWS: Mention two argument form of gdb.Value constructor.
9791         * python/py-value.c (convert_buffer_and_type_to_value): New
9792         function.
9793         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9794         Add support for handling an optional second argument.  Call
9795         convert_buffer_and_type_to_value as appropriate.
9796         * python/python-internal.h (Py_buffer_deleter): New struct.
9797         (Py_buffer_up): New typedef.
9798
9799 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9800
9801         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9802         instead of releasing ownership.
9803
9804 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9805
9806         * dwarf2read.c (open_and_init_dwp_file): Call
9807         elf_numsections instead of bfd_count_sections to initialize
9808         dwp_file->num_sections.
9809
9810 2019-02-25  Tom Tromey  <tromey@adacore.com>
9811
9812         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9813
9814 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9815
9816         * gcore.in: Add '--readnever' option when invoking GDB.
9817
9818 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9819
9820         * MAINTAINERS: Update my email address.
9821
9822 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9823
9824         * build-id.c (build_id_to_debug_bfd_1): New function.
9825         (build_id_to_debug_bfd): Look for separate debug file in
9826         sysroot.
9827
9828 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9829
9830         * gdbarch.sh: Update the copyright year range that is placed into
9831         generated files.
9832
9833 2019-02-22  Keith Seitz  <keiths@redhat.com>
9834
9835         PR symtab/23853
9836         * linespec.c (create_sals_line_offset): Search for the default
9837         symtab's filename instead of its fullname.
9838
9839 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9840
9841         * NEWS: Update style defaults.
9842
9843 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9844
9845         * main.c (captured_main_1): Disable styling in batch mode.
9846
9847 2019-02-20  Tom Tromey  <tom@tromey.com>
9848
9849         * symtab.c (symtab_symbol_info): Fix typos.
9850
9851 2019-02-20  Tom Tromey  <tromey@adacore.com>
9852
9853         * findcmd.c (_initialize_mem_search): Use upper case for
9854         metasyntactic variables.
9855
9856 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9857
9858         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9859         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9860
9861 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9862
9863         * top.h (source_file_name): Change to std::string.
9864         * top.c (source_file_name): Likewise.
9865         (command_line_input): Adjust.
9866         * cli/cli-script.c (script_from_file): Adjust.
9867
9868 2019-02-19  Tom Tromey  <tromey@adacore.com>
9869
9870         * ravenscar-thread.c
9871         (ravenscar_thread_target::update_thread_list): Don't call
9872         ada_build_task_list.
9873         * ada-lang.h (ada_build_task_list): Don't declare.
9874         * ada-tasks.c (struct ada_tasks_inferior_data)
9875         <task_list_valid_p>: Now bool.
9876         (read_known_tasks, ada_task_list_changed)
9877         (ada_tasks_invalidate_inferior_data): Update.
9878         (read_known_tasks_array): Return bool.
9879         (read_known_tasks_list): Likewise.
9880         (read_known_tasks): Return void.
9881         (ada_build_task_list): Now static.
9882
9883 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9884
9885         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9886         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9887
9888 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9889
9890         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9891         variant for ada_tasks_pspace_data_handle and
9892         ada_tasks_inferior_data_handle.
9893         (ada_tasks_pspace_data_cleanup): New function.
9894         (ada_tasks_inferior_data_cleanup): New function.
9895
9896 2019-02-17  Tom Tromey  <tom@tromey.com>
9897
9898         * macrotab.h (macro_source_fullname): Return a std::string.
9899         * macrotab.c (macro_include, check_for_redefinition)
9900         (macro_undef, macro_lookup_definition, foreach_macro)
9901         (foreach_macro_in_scope): Update.
9902         (macro_source_fullname): Return a std::string.
9903         * macrocmd.c (show_pp_source_pos): Update.
9904
9905 2019-02-17  Tom Tromey  <tom@tromey.com>
9906
9907         * macrocmd.c (show_pp_source_pos): Style the file names.
9908
9909 2019-02-17  Tom Tromey  <tom@tromey.com>
9910
9911         PR tui/24197:
9912         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9913
9914 2019-02-17  Tom Tromey  <tom@tromey.com>
9915
9916         * ada-lang.c (user_select_syms): Use filtered printing.
9917         * utils.c (wrap_style): New global.
9918         (desired_style): Remove.
9919         (emit_style_escape): Add stream parameter.
9920         (set_output_style, reset_terminal_style, prompt_for_continue):
9921         Update.
9922         (flush_wrap_buffer): Only flush gdb_stdout.
9923         (wrap_here): Set wrap_style.
9924         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9925         treat escape sequences as a character.  Change when wrap buffer is
9926         flushed.
9927         (fputs_styled): Do not set the output style when the default is
9928         requested.
9929         * ui-style.h (struct ui_file_style) <is_default>: New method.
9930         * source.c (print_source_lines_base): Emit escape sequences in one
9931         piece.
9932
9933 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9934
9935         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9936         integers and enumeration types.
9937
9938 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9939
9940         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9941         instead of lookup_symbol_in_language
9942         (do_exact_match): New function.
9943         (ada_get_symbol_name_matcher): Return do_exact_match when
9944         doing a verbatim match.
9945
9946 2019-02-15  Tom Tromey  <tromey@adacore.com>
9947
9948         * ravenscar-thread.c (ravenscar_thread_target::resume)
9949         (ravenscar_thread_target::wait): Special case wildcard requests.
9950
9951 2019-02-15  Tom Tromey  <tromey@adacore.com>
9952
9953         * ravenscar-thread.c (base_ptid): Remove.
9954         (struct ravenscar_thread_target) <close>: New method.
9955         <m_base_ptid>: New member.
9956         <update_inferior_ptid, active_task, task_is_currently_active,
9957         runtime_initialized>: Declare methods.
9958         <ravenscar_thread_target>: Add constructor.
9959         (ravenscar_thread_target::task_is_currently_active)
9960         (ravenscar_thread_target::update_inferior_ptid)
9961         (ravenscar_runtime_initialized): Rename.  Now methods.
9962         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9963         (ravenscar_thread_target::update_thread_list): Update.
9964         (ravenscar_thread_target::active_task): Now method.
9965         (ravenscar_thread_target::store_registers)
9966         (ravenscar_thread_target::prepare_to_store)
9967         (ravenscar_thread_target::prepare_to_store)
9968         (ravenscar_thread_target::mourn_inferior): Update.
9969         (ravenscar_inferior_created): Use "new" to create target.
9970         (ravenscar_thread_target::get_ada_task_ptid): Update.
9971         (_initialize_ravenscar): Don't initialize base_ptid.
9972         (ravenscar_ops): Remove global.
9973
9974 2019-02-15  Tom Tromey  <tromey@adacore.com>
9975
9976         * target.h (push_target): Declare new overload.
9977         * target.c (push_target): New overload, taking an rvalue reference.
9978         * remote.c (remote_target::open_1): Use push_target overload.
9979         * corelow.c (core_target_open): Use push_target overload.
9980
9981 2019-02-15  Tom Tromey  <tromey@adacore.com>
9982
9983         * ravenscar-thread.c (is_ravenscar_task)
9984         (ravenscar_task_is_currently_active): Return bool.
9985         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9986         (_initialize_ravenscar): Remove "(void)".
9987         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9988         Return bool.
9989
9990 2019-02-15  Tom Tromey  <tromey@adacore.com>
9991
9992         * ravenscar-thread.c (ravenscar_runtime_initializer)
9993         (has_ravenscar_runtime, get_running_thread_id)
9994         (ravenscar_thread_target::resume): Fix indentation.
9995
9996 2019-02-15  Tom Tromey  <tromey@adacore.com>
9997
9998         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9999         from ravenscar_arch_ops.
10000         (sparc_ravenscar_ops::fetch_registers)
10001         (sparc_ravenscar_ops::store_registers): Now methods.
10002         (sparc_ravenscar_prepare_to_store): Remove.
10003         (sparc_ravenscar_ops): Redefine.
10004         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10005         methods and destructor.  Remove members.
10006         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10007         (ravenscar_thread_target::store_registers)
10008         (ravenscar_thread_target::prepare_to_store): Update.
10009         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10010         Remove.
10011         (struct ppc_ravenscar_powerpc_ops): Derive from
10012         ravenscar_arch_ops.
10013         (ppc_ravenscar_powerpc_ops::fetch_registers)
10014         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10015         (ppc_ravenscar_powerpc_ops): Redefine.
10016         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10017         (ppc_ravenscar_e500_ops::fetch_registers)
10018         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10019         (ppc_ravenscar_e500_ops): Redefine.
10020         * aarch64-ravenscar-thread.c
10021         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10022         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10023         (aarch64_ravenscar_fetch_registers)
10024         (aarch64_ravenscar_store_registers): Now methods.
10025         (aarch64_ravenscar_ops): Redefine.
10026
10027 2019-02-15  Tom Tromey  <tromey@adacore.com>
10028
10029         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10030         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10031         (ravenscar_thread_target::stopped_by_watchpoint)
10032         (ravenscar_thread_target::stopped_data_address)
10033         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10034
10035 2019-02-15  Tom Tromey  <tromey@adacore.com>
10036
10037         * ravenscar-thread.c: Fix some typos.
10038
10039 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10040             Tom Tromey  <tromey@adacore.com>
10041
10042         * ada-lang.c (ada_exception_sal): Change addr_string to a
10043         std::string.
10044         (create_ada_exception_catchpoint): Update.
10045
10046 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10047             Tom Tromey  <tromey@adacore.com>
10048
10049         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10050         (bp_location_ops): Remove.
10051         (base_breakpoint_allocate_location): Update.
10052         (free_bp_location): Update.
10053         * ada-lang.c (class ada_catchpoint_location)
10054         <ada_catchpoint_location>: Remove ops parameter.
10055         (ada_catchpoint_location_dtor): Remove.
10056         (ada_catchpoint_location_ops): Remove.
10057         (allocate_location_exception): Update.
10058         * breakpoint.h (struct bp_location_ops): Remove.
10059         (class bp_location) <bp_location>: Remove bp_location_ops
10060         parameter.
10061         <~bp_location>: Add destructor.
10062         <ops>: Remove.
10063
10064 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10065             Pedro Alves  <palves@redhat.com>
10066
10067         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10068         'PATH_MAX'.
10069
10070 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10071             Samuel Thibault  <samuel.thibault@gnu.org>
10072             Thomas Schwinge  <thomas@codesourcery.com>
10073
10074         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10075         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10076
10077 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10078
10079         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10080         (check_empty): Use "const char *".
10081
10082         * gnu-nat.c (gnu_nat_target::detach): Instead of
10083         'detach_inferior (pid)' call
10084         'detach_inferior (find_inferior_pid (pid))'.
10085
10086         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10087         'nat/fork-inferior.o'.
10088         * gnu-nat.c: #include "nat/fork-inferior.h".
10089
10090         * gnu-nat.c (gnu_nat_target::detach): Instead of
10091         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10092         * gnu-nat.h: #include "inf-child.h".
10093         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10094         'i386_gnu_nat_target::fetch_registers'.
10095         (gnu_store_registers): Rename/move to
10096         'i386_gnu_nat_target::store_registers'.
10097
10098         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10099         * gnu-nat.h (mach_thread_info): New function.
10100         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10101
10102         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10103
10104 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10105
10106         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10107
10108 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10109
10110         * windows-nat.c (windows_add_thread): Add new parameter
10111         "main_thread_p" with default value set to false.  Update
10112         function documentation as well as all callers.
10113         (windows_delete_thread): Likewise.
10114         (fake_create_process): Update call to windows_add_thread.
10115         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10116         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10117         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10118         call to windows_delete_thread.
10119
10120 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10121
10122         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10123
10124 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10125
10126         * symfile.c (find_separate_debug_file): Use canonical path of
10127         sysroot with child_path instead of gdb_sysroot if it is valid.
10128
10129 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10130
10131         * symfile.c (find_separate_debug_file): Use child_path to
10132         determine if an object file is under a sysroot.
10133
10134 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10135
10136         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10137         unittests/child-path-selftests.c.
10138         * common/pathstuff.c (child_path): New function.
10139         * common/pathstuff.h (child_path): New prototype.
10140         * unittests/child-path-selftests.c: New file.
10141
10142 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10143
10144         * symfile.c (find_separate_debug_file): Look for separate debug
10145         files in debug directories under the sysroot.
10146
10147 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10148
10149         * symtab.h (struct minimal_symbol data_p): New const method.
10150         (struct minimal_symbol text_p): Likewise.
10151         * symtab.c (output_source_filename): Use file name style
10152         to print file name.
10153         (print_symbol_info): Likewise.
10154         (print_msymbol_info): Use address style to print addresses.
10155         Use function name style to print executable text symbols.
10156         (expand_symtab_containing_pc): Use data_p.
10157         (find_pc_sect_compunit_symtab): Likewise.
10158
10159 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10160
10161         * breakpoint.c (describe_other_breakpoints): Use address style
10162         to print addresses.
10163         (say_where): Likewise.
10164
10165 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10166
10167         * ada-typeprint.c (print_func_type): Print function name
10168         style to print function name.
10169         * c-typeprint.c (c_print_type_1): Likewise.
10170
10171 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10172
10173         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10174         for execve.
10175
10176 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10177
10178         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10179         type_stack.
10180
10181 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10182
10183         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10184         TYPE_CODE_REF types.
10185
10186 2019-02-08  Jim Wilson  <jimw@sifive.com>
10187
10188         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10189         (riscv_linux_fregset): New.
10190         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10191
10192 2019-02-07  Tom Tromey  <tom@tromey.com>
10193
10194         * thread.c (thread_cancel_execution_command): Update.
10195         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10196         methods.
10197         (struct thread_fsm_ops): Remove.
10198         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10199         (thread_fsm_should_stop, thread_fsm_return_value)
10200         (thread_fsm_set_finished, thread_fsm_finished_p)
10201         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10202         Don't declare.
10203         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10204         * infrun.c (clear_proceed_status_thread)
10205         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10206         (print_stop_event): Update.
10207         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10208         Add constructor.
10209         (step_command_fsm_ops): Remove.
10210         (new_step_command_fsm): Remove.
10211         (step_1): Update.
10212         (step_command_fsm::should_stop): Rename from
10213         step_command_fsm_should_stop.
10214         (step_command_fsm::clean_up): Rename from
10215         step_command_fsm_clean_up.
10216         (step_command_fsm::do_async_reply_reason): Rename from
10217         step_command_fsm_async_reply_reason.
10218         (struct until_next_fsm): Inherit from thread_fsm.  Add
10219         constructor.
10220         (until_next_fsm_ops): Remove.
10221         (new_until_next_fsm): Remove.
10222         (until_next_fsm::should_stop): Rename from
10223         until_next_fsm_should_stop.
10224         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10225         (until_next_fsm::do_async_reply_reason): Rename from
10226         until_next_fsm_async_reply_reason.
10227         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10228         constructor.  Change type of breakpoint.
10229         (finish_command_fsm_ops): Remove.
10230         (new_finish_command_fsm): Remove.
10231         (finish_command_fsm::should_stop): Rename from
10232         finish_command_fsm_should_stop.
10233         (finish_command_fsm::clean_up): Rename from
10234         finish_command_fsm_clean_up.
10235         (finish_command_fsm::return_value): Rename from
10236         finish_command_fsm_return_value.
10237         (finish_command_fsm::do_async_reply_reason): Rename from
10238         finish_command_fsm_async_reply_reason.
10239         (finish_command): Update.
10240         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10241         Add constructor.
10242         (call_thread_fsm_ops): Remove.
10243         (call_thread_fsm::call_thread_fsm): Rename from
10244         new_call_thread_fsm.
10245         (call_thread_fsm::should_stop): Rename from
10246         call_thread_fsm_should_stop.
10247         (call_thread_fsm::should_notify_stop): Rename from
10248         call_thread_fsm_should_notify_stop.
10249         (run_inferior_call, call_function_by_hand_dummy): Update.
10250         * cli/cli-interp.c (should_print_stop_to_console): Update.
10251         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10252         Add constructor.  Change type of location_breakpoint,
10253         caller_breakpoint.
10254         (until_break_fsm_ops): Remove.
10255         (new_until_break_fsm): Remove.
10256         (until_break_fsm::should_stop): Rename from
10257         until_break_fsm_should_stop.
10258         (until_break_fsm::clean_up): Rename from
10259         until_break_fsm_clean_up.
10260         (until_break_fsm::do_async_reply_reason): Rename from
10261         until_break_fsm_async_reply_reason.
10262         (until_break_command): Update.
10263         * thread-fsm.c: Remove.
10264         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10265
10266 2019-02-07  Tom Tromey  <tom@tromey.com>
10267
10268         * yy-remap.h: Add include guard.
10269         * xtensa-tdep.h: Add include guard.
10270         * xcoffread.h: Rename include guard.
10271         * varobj-iter.h: Add include guard.
10272         * tui/tui.h: Rename include guard.
10273         * tui/tui-winsource.h: Rename include guard.
10274         * tui/tui-wingeneral.h: Rename include guard.
10275         * tui/tui-windata.h: Rename include guard.
10276         * tui/tui-win.h: Rename include guard.
10277         * tui/tui-stack.h: Rename include guard.
10278         * tui/tui-source.h: Rename include guard.
10279         * tui/tui-regs.h: Rename include guard.
10280         * tui/tui-out.h: Rename include guard.
10281         * tui/tui-layout.h: Rename include guard.
10282         * tui/tui-io.h: Rename include guard.
10283         * tui/tui-hooks.h: Rename include guard.
10284         * tui/tui-file.h: Rename include guard.
10285         * tui/tui-disasm.h: Rename include guard.
10286         * tui/tui-data.h: Rename include guard.
10287         * tui/tui-command.h: Rename include guard.
10288         * tic6x-tdep.h: Add include guard.
10289         * target/waitstatus.h: Rename include guard.
10290         * target/wait.h: Rename include guard.
10291         * target/target.h: Rename include guard.
10292         * target/resume.h: Rename include guard.
10293         * target-float.h: Rename include guard.
10294         * stabsread.h: Add include guard.
10295         * rs6000-tdep.h: Add include guard.
10296         * riscv-fbsd-tdep.h: Add include guard.
10297         * regformats/regdef.h: Rename include guard.
10298         * record.h: Rename include guard.
10299         * python/python.h: Rename include guard.
10300         * python/python-internal.h: Rename include guard.
10301         * python/py-stopevent.h: Rename include guard.
10302         * python/py-ref.h: Rename include guard.
10303         * python/py-record.h: Rename include guard.
10304         * python/py-record-full.h: Rename include guard.
10305         * python/py-record-btrace.h: Rename include guard.
10306         * python/py-instruction.h: Rename include guard.
10307         * python/py-events.h: Rename include guard.
10308         * python/py-event.h: Rename include guard.
10309         * procfs.h: Add include guard.
10310         * proc-utils.h: Add include guard.
10311         * p-lang.h: Add include guard.
10312         * or1k-tdep.h: Rename include guard.
10313         * observable.h: Rename include guard.
10314         * nto-tdep.h: Rename include guard.
10315         * nat/x86-linux.h: Rename include guard.
10316         * nat/x86-linux-dregs.h: Rename include guard.
10317         * nat/x86-gcc-cpuid.h: Add include guard.
10318         * nat/x86-dregs.h: Rename include guard.
10319         * nat/x86-cpuid.h: Rename include guard.
10320         * nat/ppc-linux.h: Rename include guard.
10321         * nat/mips-linux-watch.h: Rename include guard.
10322         * nat/linux-waitpid.h: Rename include guard.
10323         * nat/linux-ptrace.h: Rename include guard.
10324         * nat/linux-procfs.h: Rename include guard.
10325         * nat/linux-osdata.h: Rename include guard.
10326         * nat/linux-nat.h: Rename include guard.
10327         * nat/linux-namespaces.h: Rename include guard.
10328         * nat/linux-btrace.h: Rename include guard.
10329         * nat/glibc_thread_db.h: Rename include guard.
10330         * nat/gdb_thread_db.h: Rename include guard.
10331         * nat/gdb_ptrace.h: Rename include guard.
10332         * nat/fork-inferior.h: Rename include guard.
10333         * nat/amd64-linux-siginfo.h: Rename include guard.
10334         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10335         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10336         * nat/aarch64-linux.h: Rename include guard.
10337         * nat/aarch64-linux-hw-point.h: Rename include guard.
10338         * mn10300-tdep.h: Add include guard.
10339         * mips-linux-tdep.h: Add include guard.
10340         * mi/mi-parse.h: Rename include guard.
10341         * mi/mi-out.h: Rename include guard.
10342         * mi/mi-main.h: Rename include guard.
10343         * mi/mi-interp.h: Rename include guard.
10344         * mi/mi-getopt.h: Rename include guard.
10345         * mi/mi-console.h: Rename include guard.
10346         * mi/mi-common.h: Rename include guard.
10347         * mi/mi-cmds.h: Rename include guard.
10348         * mi/mi-cmd-break.h: Rename include guard.
10349         * m2-lang.h: Add include guard.
10350         * location.h: Rename include guard.
10351         * linux-record.h: Rename include guard.
10352         * linux-nat.h: Add include guard.
10353         * linux-fork.h: Add include guard.
10354         * i386-darwin-tdep.h: Rename include guard.
10355         * hppa-linux-offsets.h: Add include guard.
10356         * guile/guile.h: Rename include guard.
10357         * guile/guile-internal.h: Rename include guard.
10358         * gnu-nat.h: Rename include guard.
10359         * gdb-stabs.h: Rename include guard.
10360         * frv-tdep.h: Add include guard.
10361         * f-lang.h: Add include guard.
10362         * event-loop.h: Add include guard.
10363         * darwin-nat.h: Rename include guard.
10364         * cp-abi.h: Rename include guard.
10365         * config/sparc/nm-sol2.h: Rename include guard.
10366         * config/nm-nto.h: Rename include guard.
10367         * config/nm-linux.h: Add include guard.
10368         * config/i386/nm-i386gnu.h: Rename include guard.
10369         * config/djgpp/nl_types.h: Rename include guard.
10370         * config/djgpp/langinfo.h: Rename include guard.
10371         * compile/gcc-cp-plugin.h: Add include guard.
10372         * compile/gcc-c-plugin.h: Add include guard.
10373         * compile/compile.h: Rename include guard.
10374         * compile/compile-object-run.h: Rename include guard.
10375         * compile/compile-object-load.h: Rename include guard.
10376         * compile/compile-internal.h: Rename include guard.
10377         * compile/compile-cplus.h: Rename include guard.
10378         * compile/compile-c.h: Rename include guard.
10379         * common/xml-utils.h: Rename include guard.
10380         * common/x86-xstate.h: Rename include guard.
10381         * common/version.h: Rename include guard.
10382         * common/vec.h: Rename include guard.
10383         * common/tdesc.h: Rename include guard.
10384         * common/selftest.h: Rename include guard.
10385         * common/scoped_restore.h: Rename include guard.
10386         * common/scoped_mmap.h: Rename include guard.
10387         * common/scoped_fd.h: Rename include guard.
10388         * common/safe-iterator.h: Rename include guard.
10389         * common/run-time-clock.h: Rename include guard.
10390         * common/refcounted-object.h: Rename include guard.
10391         * common/queue.h: Rename include guard.
10392         * common/ptid.h: Rename include guard.
10393         * common/print-utils.h: Rename include guard.
10394         * common/preprocessor.h: Rename include guard.
10395         * common/pathstuff.h: Rename include guard.
10396         * common/observable.h: Rename include guard.
10397         * common/netstuff.h: Rename include guard.
10398         * common/job-control.h: Rename include guard.
10399         * common/host-defs.h: Rename include guard.
10400         * common/gdb_wait.h: Rename include guard.
10401         * common/gdb_vecs.h: Rename include guard.
10402         * common/gdb_unlinker.h: Rename include guard.
10403         * common/gdb_unique_ptr.h: Rename include guard.
10404         * common/gdb_tilde_expand.h: Rename include guard.
10405         * common/gdb_sys_time.h: Rename include guard.
10406         * common/gdb_string_view.h: Rename include guard.
10407         * common/gdb_splay_tree.h: Rename include guard.
10408         * common/gdb_setjmp.h: Rename include guard.
10409         * common/gdb_ref_ptr.h: Rename include guard.
10410         * common/gdb_optional.h: Rename include guard.
10411         * common/gdb_locale.h: Rename include guard.
10412         * common/gdb_assert.h: Rename include guard.
10413         * common/filtered-iterator.h: Rename include guard.
10414         * common/filestuff.h: Rename include guard.
10415         * common/fileio.h: Rename include guard.
10416         * common/environ.h: Rename include guard.
10417         * common/common-utils.h: Rename include guard.
10418         * common/common-types.h: Rename include guard.
10419         * common/common-regcache.h: Rename include guard.
10420         * common/common-inferior.h: Rename include guard.
10421         * common/common-gdbthread.h: Rename include guard.
10422         * common/common-exceptions.h: Rename include guard.
10423         * common/common-defs.h: Rename include guard.
10424         * common/common-debug.h: Rename include guard.
10425         * common/cleanups.h: Rename include guard.
10426         * common/buffer.h: Rename include guard.
10427         * common/btrace-common.h: Rename include guard.
10428         * common/break-common.h: Rename include guard.
10429         * cli/cli-utils.h: Rename include guard.
10430         * cli/cli-style.h: Rename include guard.
10431         * cli/cli-setshow.h: Rename include guard.
10432         * cli/cli-script.h: Rename include guard.
10433         * cli/cli-interp.h: Rename include guard.
10434         * cli/cli-decode.h: Rename include guard.
10435         * cli/cli-cmds.h: Rename include guard.
10436         * charset-list.h: Add include guard.
10437         * buildsym-legacy.h: Rename include guard.
10438         * bfin-tdep.h: Add include guard.
10439         * ax.h: Rename include guard.
10440         * arm-linux-tdep.h: Add include guard.
10441         * arm-fbsd-tdep.h: Add include guard.
10442         * arch/xtensa.h: Rename include guard.
10443         * arch/tic6x.h: Add include guard.
10444         * arch/i386.h: Add include guard.
10445         * arch/arm.h: Rename include guard.
10446         * arch/arm-linux.h: Rename include guard.
10447         * arch/arm-get-next-pcs.h: Rename include guard.
10448         * arch/amd64.h: Add include guard.
10449         * arch/aarch64-insn.h: Rename include guard.
10450         * arch-utils.h: Rename include guard.
10451         * annotate.h: Add include guard.
10452         * amd64-darwin-tdep.h: Rename include guard.
10453         * aarch64-linux-tdep.h: Add include guard.
10454         * aarch64-fbsd-tdep.h: Add include guard.
10455         * aarch32-linux-nat.h: Add include guard.
10456
10457 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10458
10459         * macrotab.c (macro_define_internal): New function that
10460         factorizes macro_define_object_internal and macro_define_function
10461         code.
10462         (macro_define_object_internal): Use macro_define_internal.
10463         (macro_define_function): Likewise.
10464
10465 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10466
10467         * macrocmd.c (extract_identifier): Return
10468         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10469         callers.
10470
10471 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10472
10473         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10474
10475 2019-02-05  Tom Tromey  <tom@tromey.com>
10476
10477         * target.c (target_stack::unpush): Move assertion earlier.
10478
10479 2019-01-30  Tom Tromey  <tom@tromey.com>
10480
10481         PR python/23615:
10482         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10483         (gdbpy_parse_and_eval): Likewise.
10484         * python/python-internal.h (gdbpy_allow_threads): New class.
10485
10486 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10487
10488         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10489         (aarch64_fbsd_fpregmap): Move earlier.
10490         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10491         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10492         instead of individual calls to trad_frame_set_reg_addr.
10493         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10494         earlier.
10495         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10496         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10497         instead of individual calls to trad_frame_set_reg_addr.
10498
10499 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10500
10501         * CONTRIBUTE: Replace contribution list with wiki link.
10502
10503 2019-01-25  Tom Tromey  <tom@tromey.com>
10504
10505         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10506
10507 2019-01-25  Tom Tromey  <tom@tromey.com>
10508
10509         * xtensa-linux-nat.c: Fix common/ includes.
10510         * xml-support.h: Fix common/ includes.
10511         * xml-support.c: Fix common/ includes.
10512         * x86-linux-nat.c: Fix common/ includes.
10513         * windows-nat.c: Fix common/ includes.
10514         * varobj.h: Fix common/ includes.
10515         * varobj.c: Fix common/ includes.
10516         * value.c: Fix common/ includes.
10517         * valops.c: Fix common/ includes.
10518         * utils.c: Fix common/ includes.
10519         * unittests/xml-utils-selftests.c: Fix common/ includes.
10520         * unittests/utils-selftests.c: Fix common/ includes.
10521         * unittests/unpack-selftests.c: Fix common/ includes.
10522         * unittests/tracepoint-selftests.c: Fix common/ includes.
10523         * unittests/style-selftests.c: Fix common/ includes.
10524         * unittests/string_view-selftests.c: Fix common/ includes.
10525         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10526         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10527         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10528         * unittests/rsp-low-selftests.c: Fix common/ includes.
10529         * unittests/parse-connection-spec-selftests.c: Fix common/
10530         includes.
10531         * unittests/optional-selftests.c: Fix common/ includes.
10532         * unittests/offset-type-selftests.c: Fix common/ includes.
10533         * unittests/observable-selftests.c: Fix common/ includes.
10534         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10535         * unittests/memrange-selftests.c: Fix common/ includes.
10536         * unittests/memory-map-selftests.c: Fix common/ includes.
10537         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10538         * unittests/function-view-selftests.c: Fix common/ includes.
10539         * unittests/environ-selftests.c: Fix common/ includes.
10540         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10541         * unittests/common-utils-selftests.c: Fix common/ includes.
10542         * unittests/cli-utils-selftests.c: Fix common/ includes.
10543         * unittests/array-view-selftests.c: Fix common/ includes.
10544         * ui-file.c: Fix common/ includes.
10545         * tui/tui-io.c: Fix common/ includes.
10546         * tracepoint.h: Fix common/ includes.
10547         * tracepoint.c: Fix common/ includes.
10548         * tracefile-tfile.c: Fix common/ includes.
10549         * top.h: Fix common/ includes.
10550         * top.c: Fix common/ includes.
10551         * thread.c: Fix common/ includes.
10552         * target/waitstatus.h: Fix common/ includes.
10553         * target/waitstatus.c: Fix common/ includes.
10554         * target.h: Fix common/ includes.
10555         * target.c: Fix common/ includes.
10556         * target-memory.c: Fix common/ includes.
10557         * target-descriptions.c: Fix common/ includes.
10558         * symtab.h: Fix common/ includes.
10559         * symfile.c: Fix common/ includes.
10560         * stap-probe.c: Fix common/ includes.
10561         * spu-linux-nat.c: Fix common/ includes.
10562         * sparc-nat.c: Fix common/ includes.
10563         * source.c: Fix common/ includes.
10564         * solib.c: Fix common/ includes.
10565         * solib-target.c: Fix common/ includes.
10566         * ser-unix.c: Fix common/ includes.
10567         * ser-tcp.c: Fix common/ includes.
10568         * ser-pipe.c: Fix common/ includes.
10569         * ser-base.c: Fix common/ includes.
10570         * selftest-arch.c: Fix common/ includes.
10571         * s12z-tdep.c: Fix common/ includes.
10572         * rust-exp.y: Fix common/ includes.
10573         * rs6000-aix-tdep.c: Fix common/ includes.
10574         * riscv-tdep.c: Fix common/ includes.
10575         * remote.c: Fix common/ includes.
10576         * remote-notif.h: Fix common/ includes.
10577         * remote-fileio.h: Fix common/ includes.
10578         * remote-fileio.c: Fix common/ includes.
10579         * regcache.h: Fix common/ includes.
10580         * regcache.c: Fix common/ includes.
10581         * record-btrace.c: Fix common/ includes.
10582         * python/python.c: Fix common/ includes.
10583         * python/py-type.c: Fix common/ includes.
10584         * python/py-inferior.c: Fix common/ includes.
10585         * progspace.h: Fix common/ includes.
10586         * producer.c: Fix common/ includes.
10587         * procfs.c: Fix common/ includes.
10588         * proc-api.c: Fix common/ includes.
10589         * printcmd.c: Fix common/ includes.
10590         * ppc-linux-nat.c: Fix common/ includes.
10591         * parser-defs.h: Fix common/ includes.
10592         * osdata.c: Fix common/ includes.
10593         * obsd-nat.c: Fix common/ includes.
10594         * nat/x86-linux.c: Fix common/ includes.
10595         * nat/x86-linux-dregs.c: Fix common/ includes.
10596         * nat/x86-dregs.h: Fix common/ includes.
10597         * nat/x86-dregs.c: Fix common/ includes.
10598         * nat/ppc-linux.c: Fix common/ includes.
10599         * nat/mips-linux-watch.h: Fix common/ includes.
10600         * nat/mips-linux-watch.c: Fix common/ includes.
10601         * nat/linux-waitpid.c: Fix common/ includes.
10602         * nat/linux-ptrace.h: Fix common/ includes.
10603         * nat/linux-ptrace.c: Fix common/ includes.
10604         * nat/linux-procfs.c: Fix common/ includes.
10605         * nat/linux-personality.c: Fix common/ includes.
10606         * nat/linux-osdata.c: Fix common/ includes.
10607         * nat/linux-namespaces.c: Fix common/ includes.
10608         * nat/linux-btrace.h: Fix common/ includes.
10609         * nat/linux-btrace.c: Fix common/ includes.
10610         * nat/fork-inferior.c: Fix common/ includes.
10611         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10612         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10613         * nat/aarch64-linux.c: Fix common/ includes.
10614         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10615         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10616         * namespace.h: Fix common/ includes.
10617         * mips-linux-tdep.c: Fix common/ includes.
10618         * minsyms.c: Fix common/ includes.
10619         * mi/mi-parse.h: Fix common/ includes.
10620         * mi/mi-main.c: Fix common/ includes.
10621         * mi/mi-cmd-env.c: Fix common/ includes.
10622         * memrange.h: Fix common/ includes.
10623         * memattr.c: Fix common/ includes.
10624         * maint.h: Fix common/ includes.
10625         * maint.c: Fix common/ includes.
10626         * main.c: Fix common/ includes.
10627         * machoread.c: Fix common/ includes.
10628         * location.c: Fix common/ includes.
10629         * linux-thread-db.c: Fix common/ includes.
10630         * linux-nat.c: Fix common/ includes.
10631         * linux-fork.c: Fix common/ includes.
10632         * inline-frame.c: Fix common/ includes.
10633         * infrun.c: Fix common/ includes.
10634         * inflow.c: Fix common/ includes.
10635         * inferior.h: Fix common/ includes.
10636         * inferior.c: Fix common/ includes.
10637         * infcmd.c: Fix common/ includes.
10638         * inf-ptrace.c: Fix common/ includes.
10639         * inf-child.c: Fix common/ includes.
10640         * ia64-linux-nat.c: Fix common/ includes.
10641         * i387-tdep.c: Fix common/ includes.
10642         * i386-tdep.c: Fix common/ includes.
10643         * i386-linux-tdep.c: Fix common/ includes.
10644         * i386-linux-nat.c: Fix common/ includes.
10645         * i386-go32-tdep.c: Fix common/ includes.
10646         * i386-fbsd-tdep.c: Fix common/ includes.
10647         * i386-fbsd-nat.c: Fix common/ includes.
10648         * guile/scm-type.c: Fix common/ includes.
10649         * guile/guile.c: Fix common/ includes.
10650         * go32-nat.c: Fix common/ includes.
10651         * gnu-nat.c: Fix common/ includes.
10652         * gdbthread.h: Fix common/ includes.
10653         * gdbarch-selftests.c: Fix common/ includes.
10654         * gdb_usleep.c: Fix common/ includes.
10655         * gdb_select.h: Fix common/ includes.
10656         * gdb_bfd.c: Fix common/ includes.
10657         * gcore.c: Fix common/ includes.
10658         * fork-child.c: Fix common/ includes.
10659         * findvar.c: Fix common/ includes.
10660         * fbsd-nat.c: Fix common/ includes.
10661         * event-top.c: Fix common/ includes.
10662         * event-loop.c: Fix common/ includes.
10663         * dwarf2read.c: Fix common/ includes.
10664         * dwarf2loc.c: Fix common/ includes.
10665         * dwarf2-frame.c: Fix common/ includes.
10666         * dwarf-index-cache.c: Fix common/ includes.
10667         * dtrace-probe.c: Fix common/ includes.
10668         * disasm-selftests.c: Fix common/ includes.
10669         * defs.h: Fix common/ includes.
10670         * csky-tdep.c: Fix common/ includes.
10671         * cp-valprint.c: Fix common/ includes.
10672         * cp-support.h: Fix common/ includes.
10673         * cp-support.c: Fix common/ includes.
10674         * corelow.c: Fix common/ includes.
10675         * completer.h: Fix common/ includes.
10676         * completer.c: Fix common/ includes.
10677         * compile/compile.c: Fix common/ includes.
10678         * compile/compile-loc2c.c: Fix common/ includes.
10679         * compile/compile-cplus-types.c: Fix common/ includes.
10680         * compile/compile-cplus-symbols.c: Fix common/ includes.
10681         * command.h: Fix common/ includes.
10682         * cli/cli-dump.c: Fix common/ includes.
10683         * cli/cli-cmds.c: Fix common/ includes.
10684         * charset.c: Fix common/ includes.
10685         * build-id.c: Fix common/ includes.
10686         * btrace.h: Fix common/ includes.
10687         * btrace.c: Fix common/ includes.
10688         * breakpoint.h: Fix common/ includes.
10689         * breakpoint.c: Fix common/ includes.
10690         * ax.h:
10691         (enum agent_op): Fix common/ includes.
10692         * ax-general.c (struct aop_map): Fix common/ includes.
10693         * ax-gdb.c: Fix common/ includes.
10694         * auxv.c: Fix common/ includes.
10695         * auto-load.c: Fix common/ includes.
10696         * arm-tdep.c: Fix common/ includes.
10697         * arch/riscv.c: Fix common/ includes.
10698         * arch/ppc-linux-common.c: Fix common/ includes.
10699         * arch/i386.c: Fix common/ includes.
10700         * arch/arm.c: Fix common/ includes.
10701         * arch/arm-linux.c: Fix common/ includes.
10702         * arch/arm-get-next-pcs.c: Fix common/ includes.
10703         * arch/amd64.c: Fix common/ includes.
10704         * arch/aarch64.c: Fix common/ includes.
10705         * arch/aarch64-insn.c: Fix common/ includes.
10706         * arch-utils.c: Fix common/ includes.
10707         * amd64-windows-tdep.c: Fix common/ includes.
10708         * amd64-tdep.c: Fix common/ includes.
10709         * amd64-sol2-tdep.c: Fix common/ includes.
10710         * amd64-obsd-tdep.c: Fix common/ includes.
10711         * amd64-nbsd-tdep.c: Fix common/ includes.
10712         * amd64-linux-tdep.c: Fix common/ includes.
10713         * amd64-linux-nat.c: Fix common/ includes.
10714         * amd64-fbsd-tdep.c: Fix common/ includes.
10715         * amd64-fbsd-nat.c: Fix common/ includes.
10716         * amd64-dicos-tdep.c: Fix common/ includes.
10717         * amd64-darwin-tdep.c: Fix common/ includes.
10718         * agent.c: Fix common/ includes.
10719         * ada-lang.h: Fix common/ includes.
10720         * ada-lang.c: Fix common/ includes.
10721         * aarch64-tdep.c: Fix common/ includes.
10722
10723 2019-01-25  Tom Tromey  <tom@tromey.com>
10724
10725         * common/create-version.sh: Use common/version.h.
10726
10727 2019-01-24  Pedro Alves  <palves@redhat.com>
10728
10729         * infrun.c (signal_stop, signal_print, signal_program)
10730         (signal_catch, signal_pass): Now arrays instead of pointers.
10731         (update_signals_program_target, do_target_resume)
10732         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10733         * linux-nat.c (linux_nat_target::pass_signals)
10734         (linux_nat_target::create_inferior, linux_nat_target::attach):
10735         Adjust.
10736         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10737         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10738         * procfs.c (procfs_target::pass_signals): Adjust.
10739         * record-full.c (record_full_target::resume): Adjust.
10740         * remote.c (remote_target::pass_signals)
10741         (remote_target::program_signals): Adjust.
10742         * target-debug.h (target_debug_print_signals): Now takes a
10743         gdb::array_view as parameter.  Adjust.
10744         * target.h (target_ops) <pass_signals, program_signals>: Replace
10745         pointer and length parameters with gdb::array_view.
10746         (target_pass_signals, target_program_signals): Likewise.
10747         * target-delegates.c: Regenerate.
10748
10749 2019-01-24  Pedro Alves  <palves@redhat.com>
10750
10751         * common/forward-scope-exit.h
10752         (forward_scope_exit::forward_scope_exit): Pass arguments to
10753         m_bind_function directly, instead of creating a std::bind and
10754         copying that.
10755
10756 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10757
10758         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10759         for static members.
10760         (pass_in_v_vfp_candidate): Likewise.
10761
10762 2019-01-23  Tom Tromey  <tom@tromey.com>
10763             Pedro Alves  <palves@redhat.com>
10764
10765         * regcache.c (class regcache_invalidator): Remove.
10766         (regcache::raw_write): Use make_scope_exit.
10767
10768 2019-01-23  Tom Tromey  <tom@tromey.com>
10769
10770         * ui-out.h (class ui_out_emit_type): Update comment.
10771
10772 2019-01-23  Tom Tromey  <tom@tromey.com>
10773
10774         * infrun.c (fetch_inferior_event): Update comment.
10775
10776 2019-01-23  Tom Tromey  <tom@tromey.com>
10777             Pedro Alves  <palves@redhat.com>
10778
10779         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10780         parameter.
10781         (fetch_inferior_event): Use SCOPE_EXIT.
10782
10783
10784 2019-01-23  Tom Tromey  <tom@tromey.com>
10785             Pedro Alves  <palves@redhat.com>
10786
10787         * infrun.c (disable_thread_events): Delete.
10788         (stop_all_threads): Use SCOPE_EXIT.
10789
10790 2019-01-23  Tom Tromey  <tom@tromey.com>
10791             Pedro Alves  <palves@redhat.com>
10792
10793         * symfile.c: Include forward-scope-exit.h.
10794         (clear_symtab_users_cleanup): Replace forward declaration with
10795         a FORWARD_SCOPE_EXIT.
10796         (syms_from_objfile_1): Use the forward_scope_exit and
10797         gdb::optional instead of cleanup_function.
10798         (reread_symbols): Use the forward_scope_exit instead of
10799         cleanup_function.
10800         (clear_symtab_users_cleanup): Remove function.
10801
10802 2019-01-23  Tom Tromey  <tom@tromey.com>
10803             Pedro Alves  <palves@redhat.com>
10804
10805         * linux-nat.c: Include scope-exit.h.
10806         (cleanup_target_stop): Remove.
10807         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10808         SCOPE_EXIT.
10809
10810 2019-01-23  Tom Tromey  <tom@tromey.com>
10811             Pedro Alves  <palves@redhat.com>
10812
10813         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10814         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10815
10816 2019-01-23  Tom Tromey  <tom@tromey.com>
10817             Andrew Burgess  <andrew.burgess@embecosm.com>
10818             Pedro Alves  <palves@redhat.com>
10819
10820         * infrun.c (fetch_inferior_event): Use scope_exit.
10821         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10822         * top.c (execute_command): Use scope_exit.
10823         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10824         * utils.c (do_bpstat_clear_actions_cleanup)
10825         (make_bpstat_clear_actions_cleanup): Remove.
10826
10827 2019-01-23  Tom Tromey  <tom@tromey.com>
10828             Pedro Alves  <palves@redhat.com>
10829
10830         * infrun.c: Include "common/scope-exit.h"
10831         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10832         (wait_for_inferior): Use SCOPE_EXIT.
10833         (fetch_inferior_event): Use scope_exit.
10834
10835 2019-01-23  Tom Tromey  <tom@tromey.com>
10836             Pedro Alves  <palves@redhat.com>
10837
10838         * breakpoint.c (create_breakpoint): Remove cleanup.
10839
10840 2019-01-23  Tom Tromey  <tom@tromey.com>
10841             Andrew Burgess  <andrew.burgess@embecosm.com>
10842             Pedro Alves  <palves@redhat.com>
10843
10844 2019-01-23  Pedro Alves  <palves@redhat.com>
10845
10846         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10847
10848 2019-01-23  Pedro Alves  <palves@redhat.com>
10849             Andrew Burgess  <andrew.burgess@embecosm.com>
10850
10851         * gdbthread.h: Include "common/forward-scope-exit.h".
10852         (scoped_finish_thread_state): Redefine custom class in terms of
10853         forward_scope_exit.
10854
10855 2019-01-23  Pedro Alves  <palves@redhat.com>
10856             Andrew Burgess  <andrew.burgess@embecosm.com>
10857
10858         * common/forward-scope-exit.h: New file.
10859
10860 2019-01-23  Pedro Alves  <palves@redhat.com>
10861             Andrew Burgess  <andrew.burgess@embecosm.com>
10862             Tom Tromey  <tom@tromey.com>
10863
10864         * common/scope-exit.h: New file.
10865
10866 2019-01-23  Pedro Alves  <palves@redhat.com>
10867
10868         * common/preprocessor.h (ESC): Rename to ...
10869         (ESC_PARENS): ... this.
10870         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10871         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10872
10873 2019-01-23  Tom Tromey  <tom@tromey.com>
10874
10875         * language.h (class scoped_switch_to_sym_language_if_auto):
10876         Initialize m_lang in both cases.
10877
10878 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10879
10880         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10881         with XCNEW.
10882
10883 2019-01-22  Tom Tromey  <tom@tromey.com>
10884
10885         * corelow.c: Do not include sys/file.h.
10886
10887 2019-01-22  Tom Tromey  <tom@tromey.com>
10888
10889         * tui/tui-wingeneral.h: Include gdb_curses.h.
10890
10891 2019-01-22  Tom Tromey  <tom@tromey.com>
10892
10893         * source-cache.h (class source_cache) <get_source_lines,
10894         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10895
10896 2019-01-22  Tom Tromey  <tom@tromey.com>
10897
10898         * remote-fileio.h (struct remote_target): Declare.
10899
10900 2019-01-22  Tom Tromey  <tom@tromey.com>
10901
10902         * python/py-arch.c: Do not include py-ref.h.
10903         * python/py-bpevent.c: Do not include py-ref.h.
10904         * python/py-cmd.c: Do not include py-ref.h.
10905         * python/py-continueevent.c: Do not include py-ref.h.
10906         * python/py-event.h: Do not include py-ref.h.
10907         * python/py-evtregistry.c: Do not include py-ref.h.
10908         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10909         * python/py-frame.c: Do not include py-ref.h.
10910         * python/py-framefilter.c: Do not include py-ref.h.
10911         * python/py-function.c: Do not include py-ref.h.
10912         * python/py-infevents.c: Do not include py-ref.h.
10913         * python/py-linetable.c: Do not include py-ref.h.
10914         * python/py-objfile.c: Do not include py-ref.h.
10915         * python/py-param.c: Do not include py-ref.h.
10916         * python/py-prettyprint.c: Do not include py-ref.h.
10917         * python/py-progspace.c: Do not include py-ref.h.
10918         * python/py-symbol.c: Do not include py-ref.h.
10919         * python/py-symtab.c: Do not include py-ref.h.
10920         * python/py-type.c: Do not include py-ref.h.
10921         * python/py-unwind.c: Do not include py-ref.h.
10922         * python/py-utils.c: Do not include py-ref.h.
10923         * python/py-value.c: Do not include py-ref.h.
10924         * python/py-varobj.c: Do not include py-ref.h.
10925         * python/py-xmethods.c: Do not include py-ref.h.
10926         * python/python.c: Do not include py-ref.h.
10927         * varobj.c: Do not include py-ref.h.
10928
10929 2019-01-22  Tom Tromey  <tom@tromey.com>
10930
10931         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10932         keyword for bcache.
10933
10934 2019-01-22  Tom Tromey  <tom@tromey.com>
10935
10936         * compile/compile-cplus-types.c: Remove a comment by #include.
10937
10938 2019-01-22  Tom Tromey  <tom@tromey.com>
10939
10940         * compile/gcc-c-plugin.h: Include compile-internal.h.
10941
10942 2019-01-22  Tom Tromey  <tom@tromey.com>
10943
10944         * stabsread.c (EXTERN): Do not define.
10945         (symnum, next_symbol_text_func, processing_gcc_compilation)
10946         (within_function, global_sym_chain, global_stabs)
10947         (previous_stab_code, this_object_header_files)
10948         (n_this_object_header_files)
10949         (n_allocated_this_object_header_files): Define.
10950         * stabsread.h (EXTERN): Never define.  Use "extern".
10951
10952 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10953
10954         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10955         history_value.
10956
10957 2019-01-21  Tom Tromey  <tom@tromey.com>
10958
10959         * ui-out.c: Fix includes.
10960         * tui/tui-source.c: Fix includes.
10961         * target.c: Fix includes.
10962         * remote.c: Fix includes.
10963         * regcache.c: Fix includes.
10964         * python/py-block.c: Fix includes.
10965         * printcmd.c: Fix includes.
10966         * or1k-tdep.c: Fix includes.
10967         * mi/mi-main.c: Fix includes.
10968         * m32r-tdep.c: Fix includes.
10969         * csky-tdep.c: Fix includes.
10970         * compile/compile-cplus-types.c: Fix includes.
10971         * cli/cli-interp.c: Fix includes.
10972
10973 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10974
10975         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10976         for padding.
10977
10978 2019-01-16  Tom Tromey  <tom@tromey.com>
10979
10980         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10981         earlier.
10982         (struct objfile) <msymbols_range>: Move from top level.
10983         <msymbols>: New method.
10984         (class objfile_msymbols): Remove.
10985         * symtab.c (default_collect_symbol_completion_matches_break_on):
10986         Update.
10987         * symmisc.c (dump_msymbols): Update.
10988         * stabsread.c (scan_file_globals): Update.
10989         * objc-lang.c (info_selectors_command, info_classes_command)
10990         (find_methods): Update.
10991         * minsyms.c (find_solib_trampoline_target): Update.
10992         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10993         * coffread.c (coff_symfile_read): Update.
10994         * ada-lang.c (ada_lookup_simple_minsym)
10995         (ada_collect_symbol_completion_matches): Update.
10996
10997 2019-01-16  Tom Tromey  <tom@tromey.com>
10998
10999         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11000         type.  Remove no-argument constructor.
11001         <iterator::operator++>: Simplify.
11002         <begin>: Update.
11003         <end>: Use minimal_symbol_count.
11004
11005 2019-01-16  Tom Tromey  <tom@tromey.com>
11006
11007         * objfiles.h (struct objfile) <psymtabs>: New method.
11008         (class objfile_psymtabs): Remove.
11009         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11010         typedef.
11011         <range>: New method.
11012         (require_partial_symbols): Change return type.
11013         * psymtab.c (require_partial_symbols)
11014         (psym_expand_symtabs_matching): Update.
11015         * mdebugread.c (parse_partial_symbols): Update.
11016         * dbxread.c (dbx_end_psymtab): Update.
11017
11018 2019-01-15  Tom Tromey  <tom@tromey.com>
11019
11020         * symtab.c (lookup_objfile_from_block)
11021         (lookup_symbol_in_objfile_symtabs)
11022         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11023         (find_line_symtab, info_sources_command)
11024         (default_collect_symbol_completion_matches_break_on)
11025         (make_source_files_completion_list): Update.
11026         * symmisc.c (print_objfile_statistics, dump_objfile)
11027         (maintenance_print_symbols, maintenance_info_symtabs)
11028         (maintenance_check_symtabs, maintenance_info_line_tables):
11029         Update.
11030         * source.c (select_source_symtab)
11031         (forget_cached_source_info_for_objfile): Update.
11032         * objfiles.h (class objfile_compunits): Remove.
11033         (struct objfile) <compunits_range>: New typedef.
11034         (compunits): New method.
11035         * objfiles.c (objfile_relocate1): Update.
11036         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11037         * maint.c (count_symtabs_and_blocks): Update.
11038         * linespec.c (iterate_over_all_matching_symtabs): Update.
11039         * cp-support.c (add_symbol_overload_list_qualified): Update.
11040         * coffread.c (coff_symtab_read): Update.
11041         * ada-lang.c (add_nonlocal_symbols)
11042         (ada_collect_symbol_completion_matches)
11043         (ada_add_global_exceptions): Update.
11044
11045 2019-01-15  Tom Tromey  <tom@tromey.com>
11046
11047         * progspace.h (program_space) <objfiles_safe_range>: New
11048         typedef.
11049         <objfiles_safe>: New method.
11050         * objfiles.h (class all_objfiles_safe): Remove.
11051         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11052         * jit.c (jit_inferior_exit_hook): Update.
11053
11054 2019-01-17  Tom Tromey  <tom@tromey.com>
11055
11056         * progspace.h (program_space) <objfiles_range>: New typedef.
11057         <objfiles>: New method.
11058         <objfiles_head>: Rename from objfiles.
11059         (object_files): Update.
11060         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11061         * guile/scm-pretty-print.c
11062         (ppscm_find_pretty_printer_from_objfiles): Update.
11063         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11064         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11065         Update.
11066         * python/py-progspace.c (pspy_get_objfiles): Update.
11067         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11068         Update.
11069         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11070         (objfpy_lookup_objfile_by_build_id): Update.
11071         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11072         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11073         Update.
11074         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11075         (expand_symtab_containing_pc, lookup_objfile_from_block)
11076         (lookup_static_symbol, basic_lookup_transparent_type)
11077         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11078         (find_line_symtab, info_sources_command)
11079         (default_collect_symbol_completion_matches_break_on)
11080         (make_source_files_completion_list, find_main_name): Update.
11081         * symmisc.c (print_symbol_bcache_statistics)
11082         (print_objfile_statistics, maintenance_print_symbols)
11083         (maintenance_print_msymbols, maintenance_print_objfiles)
11084         (maintenance_info_symtabs, maintenance_check_symtabs)
11085         (maintenance_expand_symtabs, maintenance_info_line_tables):
11086         Update.
11087         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11088         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11089         (map_overlay_command, unmap_overlay_command)
11090         (simple_overlay_update, expand_symtabs_matching)
11091         (map_symbol_filenames): Update.
11092         * symfile-debug.c (set_debug_symfile): Update.
11093         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11094         Update.
11095         * source.c (select_source_symtab, forget_cached_source_info):
11096         Update.
11097         * solib.c (solib_read_symbols): Update.
11098         * solib-spu.c (append_ocl_sos): Update.
11099         * psymtab.c (maintenance_print_psymbols)
11100         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11101         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11102         * printcmd.c (info_symbol_command): Update.
11103         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11104         Update.
11105         * objfiles.h (class all_objfiles): Remove.
11106         * objfiles.c (have_partial_symbols, have_full_symbols)
11107         (have_minimal_symbols, qsort_cmp, update_section_map)
11108         (shared_objfile_contains_address_p)
11109         (default_iterate_over_objfiles_in_search_order): Update.
11110         * objc-lang.c (info_selectors_command, info_classes_command)
11111         (find_methods): Update.
11112         * minsyms.c (find_solib_trampoline_target): Update.
11113         * maint.c (maintenance_info_sections)
11114         (maintenance_translate_address, count_symtabs_and_blocks):
11115         Update.
11116         * main.c (captured_main_1): Update.
11117         * linux-thread-db.c (try_thread_db_load_from_pdir)
11118         (has_libpthread): Update.
11119         * linespec.c (iterate_over_all_matching_symtabs)
11120         (search_minsyms_for_name): Update.
11121         * jit.c (jit_find_objf_with_entry_addr): Update.
11122         * hppa-tdep.c (find_unwind_entry)
11123         (hppa_lookup_stub_minimal_symbol): Update.
11124         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11125         Update.
11126         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11127         (elf_gnu_ifunc_resolve_by_got): Update.
11128         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11129         * dwarf-index-write.c (save_gdb_index_command): Update.
11130         * cp-support.c (add_symbol_overload_list_qualified): Update.
11131         * breakpoint.c (create_overlay_event_breakpoint)
11132         (create_longjmp_master_breakpoint)
11133         (create_std_terminate_master_breakpoint)
11134         (create_exception_master_breakpoint): Update.
11135         * blockframe.c (find_pc_partial_function): Update.
11136         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11137         (ada_collect_symbol_completion_matches)
11138         (ada_add_global_exceptions): Update.
11139
11140 2019-01-17  Tom Tromey  <tom@tromey.com>
11141
11142         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11143         declare VEC.
11144         (solib_target_parse_libraries): Change return type.
11145         (library_list_start_segment, library_list_start_section)
11146         (library_list_end_library, library_list_start_library); Update.
11147         (solib_target_free_library_list): Remove.
11148         (solib_target_parse_libraries): Remove cleanup.  Change return
11149         type.
11150         (solib_target_current_sos): Update.
11151
11152 2019-01-17  Tom Tromey  <tromey@bapiya>
11153
11154         * valprint.c: Replace "the the" with "the".
11155         * symtab.c: Replace "the the" with "the".
11156         * solib.c: Replace "the the" with "the".
11157         * solib-dsbt.c: Replace "the the" with "the".
11158         * linespec.c: Replace "the the" with "the".
11159         * dwarf2loc.h: Replace "the the" with "the".
11160         * amd64-windows-tdep.c: Replace "the the" with "the".
11161         * aarch64-tdep.c: Replace "the the" with "the".
11162
11163 2019-01-16  Keith Seitz  <keiths@redhat.com>
11164
11165         PR gdb/23773
11166         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11167         <builder>: Rename to ..
11168         <m_builder>: ... this and make private.
11169         (dwarf2_cu::get_builder): New method.  Change all users of
11170         `builder' to use this method.
11171         (dwarf2_start_symtab): Move to ...
11172         (dwarf2_cu::start_symtab): ... here.  Update all callers
11173         (setup_type_unit_groups): Move to ...
11174         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11175         callers.
11176         (dwarf2_cu::reset_builder): New method.
11177         (process_full_compunit, process_full_type_unit): Use
11178         dwarf2_cu::reset_builder.
11179         (follow_die_offset): Record the ancestor CU if it is different
11180         from the followed DIE's CU.
11181         (follow_die_sig_1): Likewise.
11182
11183 2019-01-15  Tom Tromey  <tom@tromey.com>
11184
11185         * remote.c (class remote_state) <buf>: Now a char_vector.
11186         <buf_size>: Remove.
11187         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11188         parameter.
11189         (remote_target::getpkt_or_notif_sane_1)
11190         (remote_target::getpkt_sane)
11191         (remote_target::getpkt_or_notif_sane): Likewise.
11192         (class remote_target) <putpkt>: New overload.
11193         (remote_target::read_frame): Change type of "buf_p".  Remove
11194         sizeof_p parameter.
11195         (packet_ok): New overload.
11196         (packet_check_result): New overload.
11197         Update all uses.
11198
11199 2019-01-14  Tom Tromey  <tom@tromey.com>
11200
11201         * remote-notif.c (handle_notification, remote_notif_ack)
11202         (remote_notif_parse): Make "buf" const.
11203         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11204         const.
11205         (remote_notif_parse, remote_notif_ack, handle_notification):
11206         Likewise.
11207         * remote.c (remote_notif_stop_parse): Make "buf" const.
11208         (remote_target::remote_parse_stop_reply): Make "buf" const.
11209         (remote_notif_stop_ack): Make "buf" const.
11210
11211 2019-01-14  Tom Tromey  <tom@tromey.com>
11212
11213         * remote.c (remote_console_output): Make parameter const.
11214
11215 2019-01-14  Tom Tromey  <tom@tromey.com>
11216
11217         * target-debug.h (target_debug_print_signals): Constify.
11218         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11219         * procfs.c (procfs_target::pass_signals): Update.
11220         * linux-nat.c (linux_nat_target::pass_signals): Update.
11221         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11222         * target-delegates.c: Rebuild.
11223         * remote.c (remote_target::program_signals): Update.
11224         (remote_target::pass_signals): Update.
11225         * target.c (target_pass_signals): Constify argument.
11226         (target_program_signals): Likewise.
11227         * target.h (struct target_ops) <pass_signals, program_signals>:
11228         Constify argument.
11229         (target_pass_signals, target_program_signals): Constify argument.
11230
11231 2019-01-14  Tom Tromey  <tom@tromey.com>
11232
11233         PR tui/28819:
11234         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11235
11236 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11237
11238         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11239         field.
11240         * rs6000-tdep.c: Include reggroups.h.
11241         (IS_V_ALIAS_PSEUDOREG): Define.
11242         (rs6000_register_name): Return names for the "vX" aliases.
11243         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11244         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11245         aliases.  Call default_register_reggroup_p for all other
11246         pseudo-registers.
11247         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11248         New functions.
11249         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11250         Handle "vX" aliases.
11251         (v_alias_pseudo_register_collect): New function.
11252         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11253         (rs6000_gdbarch_init): Initialize "vX" aliases as
11254         pseudo-registers.  Restore registration of
11255         rs6000_pseudo_register_reggroup_p with
11256         set_tdesc_pseudo_register_reggroup_p.
11257
11258 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11259
11260         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11261         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11262         set_gdbarch_num_pseudo_regs.
11263
11264 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11265
11266         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11267         Remove arg prefixname, add do_set and do_show.
11268         Add member functions set_list and show_list.
11269         * cli/cli-style.c (class cli_style_option): Update accordingly.
11270         (style_set_list): Move to file scope.
11271         (style_show_list): Likewise.
11272         (set_style): Call help_list.
11273         (show_style): Call cmd_show_list.
11274         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11275         Update to use the new macro.
11276
11277 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11278
11279         * ada-lang.c (_initialize_ada_language): Expand the help text
11280         for the "catch exception" command.
11281
11282 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11283
11284         * symtab.c (matching_obj_sections): Initialize obj,
11285         declare it closer to its usage.
11286
11287 2019-01-10  Tom Tromey  <tom@tromey.com>
11288
11289         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11290         (basic_inf_threads_range): Remove.
11291         (inf_threads_range, inf_non_exited_threads_range)
11292         (safe_inf_threads_range): Use next_adapter.
11293
11294 2019-01-10  Keith Seitz  <keiths@redhat.com>
11295
11296         PR gdb/23712
11297         PR symtab/23010
11298         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11299         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11300
11301 2019-01-10  Keith Seitz  <keiths@redhat.com>
11302
11303         PR gdb/23712
11304         PR symtab/23010
11305         * dictionary.c (pending_to_vector): Remove.
11306         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11307         Remove _1 suffix, replacing functions of the same name.  Update
11308         all callers.
11309         (dict_create_hashed, dict_create_hashed_expandable)
11310         (dict_create_linear, dict_create_linear_expandable, dict_free)
11311         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11312         Make functions static.
11313
11314 2019-01-10  Keith Seitz  <keiths@redhat.com>
11315
11316         PR gdb/23712
11317         PR symtab/23010
11318         * dictionary.h (struct dictionary): Replace declaration with
11319         multidictionary.
11320         (dict_create_hashed, dict_create_hashed_expandable)
11321         (dict_create_linear, dict_create_linear_expandable)
11322         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11323         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11324         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11325         taking multidictionary argument.
11326         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11327         * block.h (struct block) <dict>: Change to multidictionary
11328         and rename `multidict'.
11329         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11330         symmisc.c: Update all dictionary references to multidictionary.
11331
11332 2019-01-10  Keith Seitz  <keiths@redhat.com>
11333
11334         PR gdb/23712
11335         PR symtab/23010
11336         * dictionary.c: Include unordered_map.
11337         (pending_to_vector): New function.
11338         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11339         Rewrite the non-"_1" functions to take vector instead
11340         of linked list.
11341         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11342         "new" _1 versions of the same name.
11343         (multidictionary): Define.
11344         (std::hash<enum language): New definition.
11345         (collate_pending_symbols_by_language, mdict_create_hashed)
11346         (mdict_create_hashed_expandable, mdict_create_linear)
11347         (mdict_create_linear_expandable, mdict_free)
11348         (find_language_dictionary, create_new_language_dictionary)
11349         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11350         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11351         (mdict_size, mdict_empty): New functions.
11352         * dictionary.h (mdict_iterator): Define.
11353
11354 2019-01-10  Pedro Alves  <palves@redhat.com>
11355
11356         * breakpoint.c (read_uploaded_action)
11357         (create_tracepoint_from_upload): Adjust to use
11358         gdb::unique_xmalloc_ptr.
11359         * ctf.c (ctf_write_uploaded_tp):
11360         (SET_ARRAY_FIELD): Use emplace_back.
11361         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11362         * tracefile-tfile.c (tfile_write_uploaded_tp):
11363         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11364         gdb::unique_xmalloc_ptr.
11365         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11366         at_string, cond_string, cmd_strings>: Replace char pointers
11367         with gdb::unique_xmalloc_ptr.
11368
11369 2019-01-10  Pedro Alves  <palves@redhat.com>
11370
11371         * solib-target.c (library_list_start_library): Don't xstrdup name.
11372
11373 2019-01-10  Pedro Alves  <palves@redhat.com>
11374
11375         * mdebugread.c (parse_partial_symbols): Use
11376         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11377
11378 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11379
11380         * linux-fork.c (scoped_switch_fork_info)
11381         <~scoped_switch_fork_info>: Fix incorrect variable name.
11382
11383 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11384
11385         * linux-fork.c (scoped_switch_fork_info)
11386         <scoped_switch_fork_info>: Make explicit.
11387         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11388
11389 2019-01-10  Tom Tromey  <tom@tromey.com>
11390
11391         * objfiles.h (objfile::reset_psymtabs): Update.
11392         * objfiles.c (objfile::objfile): Update.
11393         * psymtab.h (psymtab_storage::obstack): Update.
11394         (psymtab_storage::m_obstack): Use gdb::optional.
11395         (class psymtab_storage): Update comment.  Remove objfile
11396         parameter.
11397         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11398
11399 2019-01-10  Tom Tromey  <tom@tromey.com>
11400
11401         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11402         <free_psymtabs>: Now private.
11403         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11404         (allocate_psymtab): Use new method.
11405
11406 2019-01-10  Tom Tromey  <tom@tromey.com>
11407
11408         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11409         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11410         * mdebugread.c (parse_partial_symbols): Use
11411         allocate_dependencies.
11412         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11413         allocate_dependencies.
11414         (process_psymtab_comp_unit_reader)
11415         (build_type_psymtab_dependencies): Likewise.
11416         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11417
11418 2019-01-10  Tom Tromey  <tom@tromey.com>
11419
11420         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11421         PSYMBOL_SET_LANGUAGE.
11422         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11423
11424 2019-01-10  Tom Tromey  <tom@tromey.com>
11425
11426         * psymtab.h (psymtab_storage::obstack): New method.
11427         <m_obstack>: Rename from obstack; now private.
11428         * psymtab.c (psymtab_storage): Update.
11429         * dwarf2read.c (create_addrmap_from_index)
11430         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11431         Update.
11432
11433 2019-01-10  Tom Tromey  <tom@tromey.com>
11434
11435         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11436         * objfiles.h (objfile::reset_psymtabs): New method.
11437
11438 2019-01-10  Tom Tromey  <tom@tromey.com>
11439
11440         * symmisc.c (print_symbol_bcache_statistics): Update.
11441         (print_objfile_statistics): Update.
11442         * symfile.c (reread_symbols): Update.
11443         * psymtab.h (class psymtab_storage): New.
11444         * psymtab.c (psymtab_storage): New constructor.
11445         (~psymtab_storage): New destructor.
11446         (require_partial_symbols): Update.
11447         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11448         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11449         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11450         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11451         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11452         (start_psymtab_common, end_psymtab_common)
11453         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11454         (allocate_psymtab): Update.
11455         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11456         Update.
11457         (dump_psymtab_addrmap, maintenance_print_psymbols)
11458         (maintenance_check_psymtabs): Update.
11459         (class objfile_psymtabs): Move to objfiles.h.
11460         * psympriv.h (discard_psymtab): Now inline.
11461         (psymtab_discarder::psymtab_discarder): Update.
11462         (psymtab_discarder::~psymtab_discarder): Update.
11463         (ALL_OBJFILE_PSYMTABS): Rewrite.
11464         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11465         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11466         Remove fields.
11467         <partial_symtabs>: New field.
11468         (class objfile_psymtabs): Move from psymtab.h.  Update.
11469         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11470         psymbol_cache.
11471         (objfile::~objfile): Don't destroy psymbol_cache.
11472         * mdebugread.c (parse_partial_symbols): Update.
11473         * dwarf2read.c (create_addrmap_from_index)
11474         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11475         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11476         (add_partial_subprogram, dwarf2_ranges_read): Update.
11477         * dwarf-index-write.c (write_address_map)
11478         (write_one_signatured_type, recursively_write_psymbols)
11479         (class debug_names, class debug_names, write_psymtabs_to_index):
11480         Update.
11481
11482 2019-01-10  Tom Tromey  <tom@tromey.com>
11483
11484         * symtab.h (SYMBOL_SET_NAMES): Update.
11485         (symbol_set_names): Update.
11486         (MSYMBOL_SET_NAMES): Update.
11487         * symtab.c (symbol_set_names): Change argument to be an
11488         objfile_per_bfd_storage.
11489         * psymtab.c (add_psymbol_to_bcache): Update.
11490         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11491
11492 2019-01-10  Tom Tromey  <tom@tromey.com>
11493
11494         * symtab.c (create_demangled_names_hash): Change argument to be an
11495         objfile_per_bfd_storage.
11496         (symbol_set_names): Update.
11497
11498 2019-01-10  Tom Tromey  <tom@tromey.com>
11499
11500         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11501         init_psymbol_list.
11502         * psymtab.c (init_psymbol_list): Do nothing if already called.
11503         * psympriv.h (init_psymbol_list): Add comment.
11504         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11505         init_psymbol_list.
11506         * dbxread.c (dbx_symfile_read): Unconditionally call
11507         init_psymbol_list.
11508
11509 2019-01-10  Tom Tromey  <tom@tromey.com>
11510
11511         * xcoffread.c (scan_xcoff_symtab): Update.
11512         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11513         "where".
11514         * mdebugread.c (parse_partial_symbols)
11515         (handle_psymbol_enumerators): Update.
11516         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11517         * dbxread.c (read_dbx_symtab): Update.
11518         * psympriv.h (psymbol_placement): New enum.
11519         (add_psymbol_to_list): Update.
11520
11521 2019-01-10  Tom Tromey  <tom@tromey.com>
11522
11523         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11524         static_psymbols parameters.
11525         (scan_xcoff_symtab): Update.
11526         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11527         static_psymbols parameters.
11528         * psympriv.h (start_psymtab_common): Update.
11529         * mdebugread.c (parse_partial_symbols): Update.
11530         * dwarf2read.c (create_partial_symtab): Update.
11531         * dbxread.c (read_dbx_symtab): Update.
11532         (start_psymtab): Remove global_psymbols and static_psymbols
11533         parameters.
11534
11535 2019-01-10  Tom Tromey  <tom@tromey.com>
11536
11537         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11538         * psymtab.c (allocate_psymtab): Add comment.
11539         * psympriv.h (allocate_psymtab): Add comment.
11540         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11541         initializations.
11542         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11543
11544 2019-01-10  Tom Tromey  <tom@tromey.com>
11545
11546         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11547         Don't declare.
11548         * mipsread.c: Include mdebugread.h.
11549         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11550         Declare.
11551         * elfread.c: Include mdebugread.h.
11552
11553 2019-01-09  Tom Tromey  <tom@tromey.com>
11554
11555         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11556         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11557         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11558         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11559         (psym_lookup_symbol, psym_find_last_source_symtab)
11560         (psym_forget_cached_source_info, psym_print_stats)
11561         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11562         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11563         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11564         (psym_find_compunit_symtab_by_address)
11565         (maintenance_print_psymbols, maintenance_info_psymtabs)
11566         (maintenance_check_psymtabs): Use ranged for.
11567         * psymtab.h (class objfile_psymtabs): New.
11568         (require_partial_symbols): Return objfile_psymtabs.
11569         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11570
11571 2019-01-09  Tom Tromey  <tom@tromey.com>
11572
11573         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11574         (find_pc_mapped_section, list_overlays_command)
11575         (map_overlay_command, unmap_overlay_command)
11576         (simple_overlay_update): Use all_objfiles.
11577         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11578         * printcmd.c (info_symbol_command): Use all_objfiles.
11579         * objfiles.h (ALL_OBJSECTIONS): Remove.
11580         * maint.c (maintenance_translate_address): Use all_objfiles.
11581         * gcore.c (gcore_create_callback): Use all_objfiles.
11582         (objfile_find_memory_regions): Likewise.
11583
11584 2019-01-09  Tom Tromey  <tom@tromey.com>
11585
11586         * symtab.c (find_line_symtab, info_sources_command)
11587         (make_source_files_completion_list): Use objfile_compunits.
11588         * source.c (select_source_symtab): Use objfile_compunits.
11589         * objfiles.h (struct objfile): Update comment.
11590         (ALL_OBJFILES): Remove.
11591         (ALL_FILETABS): Remove.
11592         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11593         objfile_compunits.
11594
11595 2019-01-09  Tom Tromey  <tom@tromey.com>
11596
11597         * symmisc.c (print_objfile_statistics, dump_objfile)
11598         (maintenance_print_symbols): Use compunit_filetabs.
11599         * source.c (forget_cached_source_info_for_objfile): Use
11600         compunit_filetabs.
11601         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11602         (ALL_FILETABS): Use compunit_filetabs.
11603         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11604         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11605
11606 2019-01-09  Tom Tromey  <tom@tromey.com>
11607
11608         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11609         (compunit_filetabs): New.
11610         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11611         compunit_filetabs.
11612         (info_sources_command, make_source_files_completion_list): Remove
11613         declaration.
11614         * symmisc.c (print_objfile_statistics, dump_objfile)
11615         (maintenance_print_symbols): Remove declaration.
11616         (maintenance_info_symtabs): Use compunit_filetabs.
11617         (maintenance_info_line_tables): Likewise.
11618         * source.c (select_source_symtab): Change local variable name.
11619         (forget_cached_source_info_for_objfile): Remove declaration.
11620         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11621         * objfiles.c (objfile_relocate1): Remove declaration.
11622         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11623         declaration.
11624         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11625         * coffread.c (coff_symtab_read): Remove declaration.
11626         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11627         compunit_filetabs.
11628
11629 2019-01-09  Tom Tromey  <tom@tromey.com>
11630
11631         * symtab.c (lookup_objfile_from_block)
11632         (find_pc_sect_compunit_symtab, search_symbols)
11633         (default_collect_symbol_completion_matches_break_on): Use
11634         objfile_compunits.
11635         * objfiles.h (ALL_COMPUNITS): Remove.
11636         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11637         * cp-support.c (add_symbol_overload_list_qualified): Use
11638         objfile_compunits.
11639         * ada-lang.c (ada_collect_symbol_completion_matches)
11640         (ada_add_global_exceptions): Use objfile_compunits.
11641
11642 2019-01-09  Tom Tromey  <tom@tromey.com>
11643
11644         * source.c (select_source_symtab)
11645         (forget_cached_source_info_for_objfile): Remove declaration.
11646         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11647         declaration.
11648         * maint.c (count_symtabs_and_blocks): Remove declaration.
11649         * cp-support.c (add_symbol_overload_list_qualified): Remove
11650         declaration.
11651         * coffread.c (coff_symtab_read): Remove declaration.
11652         * symtab.c (lookup_symbol_in_objfile_symtabs)
11653         (basic_lookup_transparent_type_1): Use objfile_compunits.
11654         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11655         (info_sources_command, search_symbols)
11656         (default_collect_symbol_completion_matches_break_on)
11657         (make_source_files_completion_list): Remove declaration.
11658         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11659         (ada_collect_symbol_completion_matches)
11660         (ada_add_global_exceptions): Remove declaration.
11661         * linespec.c (iterate_over_all_matching_symtabs): Use
11662         objfile_compunits.
11663         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11664         (class objfile_compunits): New.
11665         (ALL_COMPUNITS): Use objfile_compunits.
11666         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11667         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11668         objfile_compunits.
11669         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11670
11671 2019-01-09  Tom Tromey  <tom@tromey.com>
11672
11673         * symtab.c (search_symbols)
11674         (default_collect_symbol_completion_matches_break_on): Use
11675         objfile_msymbols.
11676         * ada-lang.c (ada_lookup_simple_minsym)
11677         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11678         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11679         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11680         objfile_msymbols.
11681         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11682         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11683         * objc-lang.c (find_methods): Use objfile_msymbols.
11684         (info_selectors_command, info_classes_command): Likewise.
11685         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11686         * objfiles.h (class objfile_msymbols): New.
11687         (ALL_OBJFILE_MSYMBOLS): Remove.
11688         (ALL_MSYMBOLS): Remove.
11689
11690 2019-01-09  Tom Tromey  <tom@tromey.com>
11691
11692         * common/next-iterator.h (next_adapter): Add Iterator template
11693         parameter.
11694         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11695         (class all_objfiles_safe): New.
11696         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11697         * objfiles.c (put_objfile_before): Update comment.
11698         (add_separate_debug_objfile): Likewise.
11699         (free_all_objfiles): Use all_objfiles_safe.
11700         (objfile_purge_solibs): Likewise.
11701
11702 2019-01-09  Tom Tromey  <tom@tromey.com>
11703
11704         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11705         (expand_symtab_containing_pc, lookup_static_symbol)
11706         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11707         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11708         all_objfiles.
11709         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11710         * breakpoint.c (create_overlay_event_breakpoint)
11711         (create_longjmp_master_breakpoint)
11712         (create_std_terminate_master_breakpoint)
11713         (create_exception_master_breakpoint): Use all_objfiles.
11714         * linux-thread-db.c (try_thread_db_load_from_pdir)
11715         (has_libpthread): Use all_objfiles.
11716         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11717         * linespec.c (iterate_over_all_matching_symtabs)
11718         (search_minsyms_for_name): Use all_objfiles.
11719         * maint.c (maintenance_info_sections): Use all_objfiles.
11720         * main.c (captured_main_1): Use all_objfiles.
11721         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11722         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11723         * guile/scm-pretty-print.c
11724         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11725         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11726         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11727         (maintenance_print_msymbols): Use all_objfiles.
11728         * source.c (select_source_symtab): Use all_objfiles.
11729         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11730         * symfile.c (remove_symbol_file_command)
11731         (expand_symtabs_matching, map_symbol_filenames): Use
11732         all_objfiles.
11733         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11734         all_objfiles.
11735         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11736         * objc-lang.c (find_methods): Use all_objfiles.
11737         * objfiles.c (have_partial_symbols, have_full_symbols)
11738         (have_minimal_symbols, qsort_cmp)
11739         (default_iterate_over_objfiles_in_search_order): Use
11740         all_objfiles.
11741         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11742         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11743         (maintenance_check_psymtabs): Use all_objfiles.
11744         (ALL_PSYMTABS): Remove.
11745         * compile/compile-object-run.c (do_module_cleanup): Use
11746         all_objfiles.
11747         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11748         * cp-support.c (add_symbol_overload_list_qualified): Use
11749         all_objfiles.
11750         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11751         Use all_objfiles.
11752         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11753         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11754         all_objfiles.
11755         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11756         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11757         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11758         Uses all_objfiles.
11759         * solib.c (solib_read_symbols): Use all_objfiles
11760
11761 2019-01-09  Tom Tromey  <tom@tromey.com>
11762
11763         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11764         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11765         all_objfiles.
11766         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11767         * symmisc.c (print_symbol_bcache_statistics)
11768         (print_objfile_statistics, maintenance_print_objfiles)
11769         (maintenance_info_symtabs, maintenance_check_symtabs)
11770         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11771         all_objfiles.
11772         * source.c (forget_cached_source_info): Use all_objfiles.
11773         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11774         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11775         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11776         * objfiles.c (update_section_map): Use all_objfiles.
11777         (shared_objfile_contains_address_p): Likewise.
11778         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11779         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11780
11781 2019-01-09  Tom Tromey  <tom@tromey.com>
11782
11783         * common/next-iterator.h: New file.
11784         * objfiles.h (class all_objfiles): New.
11785         (struct objfile_iterator): New.
11786
11787 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11788
11789         * NEWS: Move the description of the changed "frame", "select-frame",
11790          and "info frame" commands to the Changed commands section.
11791
11792 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11793
11794         * gdbtypes.c (check_stub_method_group): Remove handling of old
11795         mangling schemes.
11796         * linespec.c (find_methods): Likewise.
11797         * stabsread.c (read_member_functions): Likewise.
11798         * valops.c (search_struct_method): Likewise.
11799         (value_struct_elt_for_reference): Likewise.
11800         * NEWS: Mention this change.
11801
11802 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11803
11804         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11805         print_source_lines.
11806         * source.c (print_source_lines_base): Update line number check.
11807         (print_source_lines): New function.
11808         (source_lines_range::source_lines_range): New function.
11809         * source.h (class source_lines_range): New class.
11810         (print_source_lines): New declaration.
11811
11812 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11813
11814         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11815
11816 2019-01-08  Tom Tromey  <tom@tromey.com>
11817             Simon Marchi  <simon.marchi@ericsson.com>
11818
11819         PR gdb/24060
11820         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11821         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11822         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11823         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11824         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11825         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11826
11827 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11828
11829         * source.c (select_source_symtab): Move header comment to
11830         declaration in source.h.
11831         (forget_cached_source_info_for_objfile): Likewise.
11832         (forget_cached_source_info): Likewise.
11833         (identify_source_line): Likewise.
11834         * source.h (identify_source_line): Move declaration from symtab.h
11835         and add comment from source.c
11836         (print_source_lines): Likewise.
11837         (forget_cached_source_info_for_objfile): Likewise.
11838         (forget_cached_source_info): Likewise.
11839         (select_source_symtab): Likewise.
11840         (enum print_source_lines_flag): Move definition from symtab.h.
11841         * symtab.h (identify_source_line): Move declaration to source.h.
11842         (print_source_lines): Likewise.
11843         (forget_cached_source_info_for_objfile): Likewise.
11844         (forget_cached_source_info): Likewise.
11845         (select_source_symtab): Likewise.
11846         (enum print_source_lines_flag): Move definition to source.h.
11847         * tui/tui-hooks.c: Add 'source.h' include.
11848
11849 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11850
11851         * source.c (print_source_lines_base): Handle requests to print
11852         reverse line number sequences, and guard against empty lines
11853         string.
11854
11855 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11856
11857         * source.c (print_source_lines_base): Fix skip of '\r' if next
11858         character is '\n'.
11859
11860 2019-01-06  Tom Tromey  <tom@tromey.com>
11861
11862         * c-exp.y (struct c_parse_state) <macro_original_text,
11863         expansion_obstack>: New member.
11864         (macro_original_text, expansion_obstack): Remove globals.
11865         (scan_macro_expansion, scanning_macro_expansion)
11866         (finished_macro_expansion): Update.
11867         (scan_macro_cleanup): Remove.
11868         (yylex, c_parse): Update.
11869
11870 2019-01-06  Tom Tromey  <tom@tromey.com>
11871
11872         * c-exp.y (struct c_parse_state) <strings>: New member.
11873         (operator_stoken): Update.
11874
11875 2019-01-06  Tom Tromey  <tom@tromey.com>
11876
11877         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11878         (union type_stack_elt) <typelist_val>: Now a pointer to
11879         std::vector.
11880         (type_stack_cleanup): Don't declare.
11881         (push_typelist): Update.
11882         * parse.c (pop_typelist): Return a std::vector.
11883         (push_typelist): Take a std::vector.
11884         (follow_types): Update.  Do not free args.
11885         (type_stack_cleanup): Remove.
11886         * c-exp.y (struct c_parse_state): New.
11887         (cpstate): New global.
11888         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11889         (nonempty_typelist): Update.
11890         (func_mod): Create a new vector.
11891         (c_parse): Create a c_parse_state.
11892         (check_parameter_typelist): Do not delete params.
11893         (function_method): Update.  Do not delete type_list.
11894
11895 2019-01-06  Tom Tromey  <tom@tromey.com>
11896
11897         PR gdb/28155:
11898         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11899         check_typedef.
11900         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11901         (print_return_value): Likewise.
11902
11903 2019-01-05  Tom Tromey  <tom@tromey.com>
11904
11905         * contrib/cleanup_check.py: Remove.
11906         * contrib/gcc-with-excheck: Remove.
11907         * contrib/exsummary.py: Remove.
11908         * contrib/excheck.py: Remove.
11909
11910 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11911
11912         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11913         NULL. Initialize tpprev to NULL instead of assigning it
11914         to NULL on the next statement.
11915         * windows-nat.c (windows_delete_thread): Remove check for
11916         main_thread_id before printing thread exit notifications.
11917         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11918         Remove thread ID check against main_thread_id.
11919         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11920         windows_delete_thread.
11921         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11922
11923 2019-01-04  Tom Tromey  <tom@tromey.com>
11924
11925         * compile/compile.c (_initialize_compile): Use upper case for
11926         metasyntactic variables.
11927         * symmisc.c (_initialize_symmisc): Use upper case for
11928         metasyntactic variables.
11929         * psymtab.c (_initialize_psymtab): Use upper case for
11930         metasyntactic variables.
11931         * demangle.c (demangle_command): Use upper case for metasyntactic
11932         variables.
11933         (_initialize_demangler): Likewise.
11934         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11935         variables.
11936
11937 2019-01-03  Tom Tromey  <tom@tromey.com>
11938
11939         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11940
11941 2019-01-03  Tom Tromey  <tom@tromey.com>
11942
11943         * python/py-symtab.c (salpy_str): Update.
11944         (struct salpy_sal_object) <symtab>: Now a PyObject.
11945         (salpy_dealloc): Update.
11946         (del_objfile_sal): Use gdbpy_ref.
11947
11948 2019-01-03  Tom Tromey  <tom@tromey.com>
11949
11950         * python/py-type.c (convert_field): Use new_reference.  Return
11951         gdbpy_ref.
11952         (make_fielditem): Return gdbpy_ref.
11953         (typy_fields): Update.
11954         (typy_getitem): Update.
11955         (field_name): Return gdbpy_ref.  Use new_reference.
11956         (typy_iterator_iternext): Update.
11957
11958 2019-01-03  Tom Tromey  <tom@tromey.com>
11959
11960         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11961
11962 2019-01-03  Tom Tromey  <tom@tromey.com>
11963
11964         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11965         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11966         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11967         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11968         (pspy_set_type_printers): Likewise.
11969         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11970         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11971         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11972         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11973         (objfpy_set_type_printers): Likewise.
11974
11975 2019-01-03  Tom Tromey  <tom@tromey.com>
11976
11977         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11978         (gdbpy_print_stack): Use gdbpy_err_fetch.
11979         * python/python-internal.h (class gdbpy_err_fetch): New class.
11980         (class gdbpy_enter) <m_error_type, m_error_value,
11981         m_error_traceback>: Remove.
11982         <m_error>: New member.
11983         (gdbpy_exception_to_string): Don't declare.
11984         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11985         * python/py-value.c (convert_value_from_python): Use
11986         gdbpy_err_fetch.
11987         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11988         gdbpy_exception_to_string.
11989         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11990         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11991         gdbpy_err_fetch.
11992
11993 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11994
11995         * linux-nat.c (delete_lwp_cleanup): Delete.
11996         (struct lwp_deleter): New struct.
11997         (lwp_info_up): New typedef.
11998         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11999         lwp_info_up.
12000
12001 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12002
12003         * linux-fork.c (class scoped_switch_fork_info): New class.
12004         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12005
12006 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12007
12008         * valops.c (find_overload_match): Remove use of null_cleanup, and
12009         calls to do_cleanups.
12010
12011 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12012
12013         * compile/compile-cplus-types.c
12014         (compile_cplus_instance::decl_name): Handle changes to
12015         cp_func_name.
12016         * cp-support.c (cp_func_name): Update header comment, update
12017         return type.
12018         * cp-support.h (cp_func_name): Update return type in declaration.
12019         * valops.c (find_overload_match): Move temp_func local to top
12020         level of function and change its type.  Use temp_func to hold and
12021         delete temporary string obtained from cp_func_name.
12022
12023 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12024
12025         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12026         gdb::char_vector, remove cleanup, and update uses of `msg`.
12027
12028 2019-01-03  Jim Wilson  <jimw@sifive.com>
12029
12030         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12031
12032 2019-01-02  Tom Tromey  <tom@tromey.com>
12033
12034         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12035         (tdesc_parse_xml): Remove cleanups.
12036         * target-descriptions.h (make_cleanup_free_target_description):
12037         Don't declare.
12038         (target_desc_deleter): New struct.
12039         (target_desc_up): New typedef.
12040         * target-descriptions.c (target_desc_deleter::operator()): Rename
12041         from free_target_description.
12042         (make_cleanup_free_target_description): Remove.
12043
12044 2019-01-02  Tom Tromey  <tom@tromey.com>
12045
12046         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12047         constructor, destructor.
12048         (linespec_parser): Remove typedef.
12049         (~linespec_parser): Rename from linespec_parser_delete.
12050         (linespec_lex_to_end, linespec_complete_label)
12051         (linespec_complete): Update.
12052         (decode_line_full): Remove cleanups.
12053         (decode_line_1): Update.
12054
12055 2019-01-02  Tom Tromey  <tom@tromey.com>
12056
12057         * python/python-internal.h (inferior_to_inferior_object): Change
12058         return type.
12059         * python/py-exitedevent.c (create_exited_event_object): Update.
12060         * python/py-inferior.c (inferior_to_inferior_object): Return
12061         gdbpy_ref.
12062         (python_new_inferior, python_inferior_deleted)
12063         (thread_to_thread_object, delete_thread_object)
12064         (build_inferior_list, gdbpy_selected_inferior): Update.
12065         * python/py-infthread.c (create_thread_object): Update.  Also fail
12066         if inferior_to_inferior_object fails.
12067
12068 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12069
12070         * inferior.h (class inferior) <displaced_step_state>: New field.
12071         * infrun.h (struct displaced_step_state): Move here from
12072         infrun.c.  Initialize fields, add constructor.
12073         <inf>: Remove field.
12074         <reset>: New method.
12075         * infrun.c (struct displaced_step_inferior_state): Move to
12076         infrun.h.
12077         (displaced_step_inferior_states): Remove.
12078         (get_displaced_stepping_state): Adust.
12079         (displaced_step_in_progress_any_inferior): Adjust.
12080         (displaced_step_in_progress_thread): Adjust.
12081         (displaced_step_in_progress): Adjust.
12082         (add_displaced_stepping_state): Remove.
12083         (get_displaced_step_closure_by_addr): Adjust.
12084         (remove_displaced_stepping_state): Remove.
12085         (infrun_inferior_exit): Call displaced_step_state.reset.
12086         (use_displaced_stepping): Don't check for NULL.
12087         (displaced_step_prepare_throw): Call
12088         get_displaced_stepping_state.
12089         (displaced_step_fixup): Don't check for NULL.
12090         (prepare_for_detach): Don't check for NULL.
12091
12092 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12093
12094         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12095          in case of call that did not complete.
12096
12097 2019-01-02  Andrey Utkin  <autkin@undo.io>
12098
12099         * symfile.c (find_separate_debug_file): Fix search of debug files for
12100         remote debuggee.
12101
12102 2019-01-02  Tom Tromey  <tom@tromey.com>
12103
12104         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12105         indentation.
12106         * python/py-frame.c (frapy_older): Remove cast.
12107         (frapy_newer): Likewise.
12108         * python/py-breakpoint.c (local_setattro): Remove cast.
12109         * python/py-arch.c (archpy_name): Remove local variable.
12110         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12111
12112 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12113
12114         * unittests/basic_string_view/element_access/char/empty.cc:
12115         Fix year range in copyright header.
12116
12117 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12118
12119         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12120         Delete.
12121         <operator==>: Update with for removed field.
12122         <hash>: Likewise.
12123         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12124         <isa_features>: ...this.
12125         <abi_features>: New field.
12126         (riscv_isa_flen): Update comment.
12127         (riscv_abi_xlen): New declaration.
12128         (riscv_abi_flen): New declaration.
12129         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12130         isa_features.
12131         (riscv_abi_xlen): New function.
12132         (riscv_isa_flen): Update to get answer from isa_features.
12133         (riscv_abi_flen): New function.
12134         (riscv_has_fp_abi): Update to get answer from abi_features.
12135         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12136         xlen and flen.
12137         (riscv_call_info) <xlen, flen>: Update comment.
12138         (riscv_call_arg_struct): Remove invalid assertions
12139         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12140         is removed.
12141         (riscv_gdbarch_init): Gather isa features and abi features
12142         separately, ensure both match on the gdbarch when reusing an old
12143         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12144         a target with 64-bit float hardware.
12145
12146 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12147
12148         * source.c (search_command_helper): Stop reverse search
12149         when line 1 has been searched.
12150
12151 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12152
12153         * record-full.c (record_full_base_target::close): Rewrite
12154         record_full_core_buf_list free logic.
12155
12156 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12157
12158         * break-catch-syscall.c (print_one_catch_syscall): xfree
12159         the last text.
12160
12161 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12162
12163         * top.c (print_gdb_version): Update Copyright year in version
12164         message.
12165
12166 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12167
12168         Update copyright year range in all GDB files.
12169
12170 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12171
12172         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12173
12174 For older changes see ChangeLog-2018.
12175 \f
12176 Local Variables:
12177 mode: change-log
12178 left-margin: 8
12179 fill-column: 74
12180 version-control: never
12181 coding: utf-8
12182 End:
12183