gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tromey@adacore.com>
   2
   3         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
   4         method.
   5
   6 2019-05-08  Tom Tromey  <tromey@adacore.com>
   7
   8         * utils.c (fputs_maybe_filtered): Reset style after paging, even
   9         when no wrap column is set.
  10
  11 2019-05-08  Tom Tromey  <tromey@adacore.com>
  12
  13         * c-lang.c (c_get_string): Handle non-C-style arrays.
  14
  15 2019-05-08  Tom Tromey  <tromey@adacore.com>
  16
  17         * typeprint.c (print_offset_data::update): Print the bit offset,
  18         not the number of bits remaining.
  19
  20 2019-05-08  Tom Tromey  <tromey@adacore.com>
  21
  22         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
  23         padding at end of comment.
  24
  25 2019-05-08  Tom Tromey  <tromey@adacore.com>
  26
  27         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
  28         Compare main types.
  29
  30 2019-05-06  Tom Tromey  <tom@tromey.com>
  31
  32         * common/scoped_mmap.c: Include common-defs.h.
  33         * common/scoped_mmap.h: Don't include config.h.
  34
  35 2019-05-04  Tom Tromey  <tom@tromey.com>
  36
  37         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
  38         (struct aarch64_call_info): Add initializers.
  39         <si>: Now a std::vector.
  40         (pass_on_stack, aarch64_push_dummy_call): Update.
  41
  42 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
  43             Tom Tromey  <tom@tromey.com>
  44
  45         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
  46         (ppc_threads): Now a std::vector.  Now static.
  47         (hwdebug_find_thread_points_by_tid)
  48         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
  49         Update.
  50
  51 2019-05-04  Tom Tromey  <tom@tromey.com>
  52
  53         * arc-tdep.c (arc_tdesc_init): Return bool.
  54
  55 2019-05-04  Tom Tromey  <tom@tromey.com>
  56
  57         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
  58         Use gdb_assert_not_reached.
  59
  60 2019-05-04  Tom Tromey  <tom@tromey.com>
  61
  62         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
  63         "false".
  64
  65 2019-05-04  Tom Tromey  <tom@tromey.com>
  66
  67         * arc-tdep.c (arc_tdesc_init): Use bool.
  68
  69 2019-05-04  Tom Tromey  <tom@tromey.com>
  70
  71         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  72
  73 2019-05-04  Tom Tromey  <tom@tromey.com>
  74
  75         * cli/cli-cmds.c (valid_command_p): Return bool.
  76
  77 2019-05-04  Tom Tromey  <tom@tromey.com>
  78
  79         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  80         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  81
  82 2019-05-04  Raul Tambre  <raul@tambre.ee>
  83
  84         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  85         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  86         operator for comparison.
  87
  88 2019-05-04  Tom Tromey  <tom@tromey.com>
  89
  90         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  91         (lookup_partial_symbol, print_partial_symbols)
  92         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  93         (psymbol_compare): Update.
  94         (add_psymbol_to_bcache): Clear the entire psymbol.
  95         (maintenance_check_psymtabs): Update.
  96         * psympriv.h (struct partial_symbol): Don't derive from
  97         general_symbol_info.
  98         <obj_section, unrelocated_address, address,
  99         set_unrelocated_address>: Update.
 100         <ginfo>: New member.
 101         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 102         (debug_names::write_psymbols): Update.
 103
 104 2019-05-04  Tom de Vries  <tdevries@suse.de>
 105
 106         * contrib/cc-with-tweaks.sh: Support -n arg.
 107
 108 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 109
 110         * corelow.c (core_target::detach): Ensure frame cache and
 111         register caches are cleared.
 112         inferior.c (exit_inferior_1): Likewise.
 113
 114 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 115             Tom Tromey  <tom@tromey.com>
 116
 117         * dictionary.c (collate_pending_symbols_by_language): Remove
 118         "struct" from foreach.
 119         * symtab.c (lookup_global_symbol_from_objfile)
 120         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 121         foreach.
 122         * ser-tcp.c (net_open): Remove "struct" from foreach.
 123         * objfiles.c (objfile_relocate, objfile_rebase)
 124         (objfile_has_symbols): Remove "struct" from foreach.
 125         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 126         from foreach.
 127         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 128         foreach.
 129         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 130         "struct" from foreach.
 131         * ada-lang.c (create_excep_cond_exprs)
 132         (ada_exception_catchpoint_cond_string): Remove "struct" from
 133         foreach.
 134
 135 2019-05-03  Tom Tromey  <tromey@adacore.com>
 136
 137         * ada-exp.y (convert_char_literal): Check suffix of each
 138         enumerator.
 139
 140 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 141
 142         PR ada/21406:
 143         * ada-exp.y (yywrap): Don't define.
 144         * ada-lex.l (%option): Add noyywrap
 145         (yywrap): Remove.
 146
 147 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 148
 149         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 150         _WIN32_WINNT to the XP level, unless already defined to a higher
 151         level.
 152
 153         * unittests/parse-connection-spec-selftests.c:
 154         * ser-tcp.c:
 155         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 156         override.
 157
 158         * symfile.c (find_separate_debug_file): Remove colon from the
 159         drive spec of DOS/Windows file names of the target, so that the
 160         file name produced from DEBUGDIR and the target's directory will
 161         be valid on DOS/Windows systems.
 162
 163 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 164
 165         * rust-lang.c (val_print_struct): Handle printing structures
 166         containing strings.
 167
 168 2019-05-02  Tom Tromey  <tromey@adacore.com>
 169
 170         * valarith.c (_initialize_valarith): Remove.
 171
 172 2019-05-01  Tom Tromey  <tromey@adacore.com>
 173
 174         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 175         bitfields.
 176
 177 2019-05-01  Tom Tromey  <tromey@adacore.com>
 178
 179         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 180         for big-endian copies.
 181
 182 2019-04-30  Ali Tamur  <tamur@google.com>
 183         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 184         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 185         (read_3_bytes): New function.
 186
 187 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 188
 189         * windows-nat.c (main_thread_id): Delete.
 190         (handle_output_debug_string): Replace main_thread_id by
 191         current_event.dwThreadId.
 192         (fake_create_process): Likewise.
 193         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 194         Do not set main_thread_id.
 195         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 196         current_event.dwThreadId.
 197         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 198
 199 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 200
 201         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 202         Use current_event.dwThreadId instead of main_thread_id.
 203
 204 2019-04-30  Tom Tromey  <tromey@adacore.com>
 205
 206         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 207         (create_excep_cond_exprs): Iterate over program spaces.
 208         (ada_exception_catchpoint_cond_string): Examine all minimal
 209         symbols for exception types.
 210
 211 2019-04-30  Tom Tromey  <tromey@adacore.com>
 212
 213         PR c++/24470:
 214         * dwarf2read.c (process_structure_scope): Handle case where type
 215         has template parameters but no symbol was created.
 216
 217 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 218             Chris January  <chris.january@arm.com>
 219
 220         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 221         qualifier.
 222         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 223
 224 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 225
 226         * f-typeprint.c (f_print_type): Update rules for printing
 227         whitespace.
 228         (f_type_print_varspec_suffix): Likewise.
 229
 230 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 231             Chris January  <chris.january@arm.com>
 232
 233         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 234         function arguments.
 235
 236 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * f-lang.c (build_fortran_types): Change name of void type to
 239         lower case.
 240         * f-typeprint.c (f_type_print_base): Print the name of the void
 241         type, rather than a fixed string.
 242         * f-valprint.c (f_decorations): Use lower case void string.
 243
 244 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 245             Chris January  <chris.january@arm.com>
 246
 247         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 248         types for Fortran.
 249
 250 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 251             Chris January  <chris.january@arm.com>
 252             David Lecomber  <david.lecomber@arm.com>
 253
 254         * f-exp.y (BINOP_INTRINSIC): New token.
 255         (exp): New parser rule handling BINOP_INTRINSIC.
 256         (f77_keywords): Add new builtin procedures.
 257         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 258         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 259         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 260         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 261         (print_unop_subexp_f): New function.
 262         (print_binop_subexp_f): New function.
 263         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 264         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 265         (dump_subexp_body_f): Likewise.
 266         (operator_check_f): Likewise.
 267         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 268         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 269
 270 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 271
 272         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 273         UNOP_KIND.
 274         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 275         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 276         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 277         (operator_length_f): New fuction.
 278         (print_subexp_f): New function.
 279         (op_name_f): New function.
 280         (dump_subexp_body_f): New function.
 281         (operator_check_f): New function.
 282         (exp_descriptor_f): Replace standard expression handling functions
 283         with new functions.
 284         * gdb/fortran-operator.def: New file.
 285         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 286         * gdb/std-operator.def: Remove UNOP_KIND.
 287
 288 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 289
 290         * std-operator.def: Remove unbalanced, stray double quote
 291         character.
 292
 293 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 294             Chris January  <chris.january@arm.com>
 295             Daniel Everett  <daniel.everett@arm.com>
 296             Nick Forrington  <nick.forrington@arm.com>
 297             Richard Bunt  <richard.bunt@arm.com>
 298
 299         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 300         of depth when printing anonymous structs or unions.
 301         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 302         Don't print either the top-level value, or the children if the
 303         max-depth is exceeded.
 304         (ppscm_print_children): When printing the key of a map, allow one
 305         extra level of depth.
 306         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 307         print either the top-level value, or the children if the max-depth
 308         is exceeded.
 309         (print_children): When printing the key of a map, allow one extra
 310         level of depth.
 311         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 312         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 313         (user_print_options): Initialise max_depth field.
 314         (val_print_scalar_or_string_type_p): New function.
 315         (val_print): Check to see if the max depth has been reached.
 316         (val_print_check_max_depth): Define new function.
 317         (show_print_max_depth): New function.
 318         (_initialize_valprint): Add 'print max-depth' option.
 319         * valprint.h (struct value_print_options) <max_depth>: New field.
 320         (val_print_check_max_depth): Declare new function.
 321         * NEWS: Document new feature.
 322
 323 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 324
 325         * ada-lang.c (ada_language_defn): Initialise new field.
 326         * c-lang.c (c_is_string_type_p): New function.
 327         (c_language_defn): Initialise new field.
 328         (cplus_language_defn): Initialise new field.
 329         (asm_language_defn): Initialise new field.
 330         (minimal_language_defn): Initialise new field.
 331         * c-lang.h (c_is_string_type_p): Declare new function.
 332         * d-lang.c (d_language_defn): Initialise new field.
 333         * f-lang.c (f_is_string_type_p): New function.
 334         (f_language_defn): Initialise new field.
 335         * go-lang.c (go_is_string_type_p): New function.
 336         (go_language_defn): Initialise new field.
 337         * language.c (default_is_string_type_p): New function.
 338         (unknown_language_defn): Initialise new field.
 339         (auto_language_defn): Initialise new field.
 340         * language.h (struct language_defn) <la_is_string_type_p>: New
 341         member variable.
 342         (default_is_string_type_p): Declare new function.
 343         * m2-lang.c (m2_language_defn): Initialise new field.
 344         * objc-lang.c (objc_language_defn): Initialise new field.
 345         * opencl-lang.c (opencl_language_defn): Initialise new field.
 346         * p-lang.c (pascal_is_string_type_p): New function.
 347         (pascal_language_defn): Initialise new field.
 348         * rust-lang.c (rust_is_string_type_p): New function.
 349         (rust_language_defn): Initialise new field.
 350
 351 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 352
 353         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 354         New field.
 355         * ada-lang.c (ada_language_defn): Initialise new field.
 356         * c-lang.c (c_language_defn): Likewise.
 357         (cplus_language_defn): Likewise.
 358         (asm_language_defn): Likewise.
 359         (minimal_language_defn): Likewise.
 360         * d-lang.c (d_language_defn): Likewise.
 361         * f-lang.c (f_language_defn): Likewise.
 362         * go-lang.c (go_language_defn): Likewise.
 363         * language.c (unknown_language_defn): Likewise.
 364         (auto_language_defn): Likewise.
 365         * m2-lang.c (m2_language_defn): Likewise.
 366         * objc-lang.c (objc_language_defn): Likewise.
 367         * opencl-lang.c (opencl_language_defn): Likewise.
 368         * p-lang.c (pascal_language_defn): Likewise.
 369         * rust-lang.c (rust_language_defn): Likewise.
 370
 371 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 372
 373         * ada-lang.c (ada_is_character_type): Change return type to bool.
 374         (ada_is_string_type): Likewise.
 375         * ada-lang.h (ada_is_character_type): Update declaration
 376         (ada_is_string_type): Likewise.
 377
 378 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 379
 380         Support style in 'frame|thread apply'
 381
 382         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 383         * record.c (record_start, record_stop): Update callers of
 384         execute_command_to_string with false.
 385         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 386         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 387         methods.
 388         (class string_file): New constructor with term_out parameter.
 389         Override methods term_out and can_emit_style_escape.  New member
 390         term_out.
 391         (class stdio_file): Override can_emit_style_escape.
 392         (class tee_file): Override term_out and can_emit_style_escape.
 393         * utils.h (can_emit_style_escape): Remove.
 394         * utils.c (can_emit_style_escape): Likewise.
 395         Update all callers of can_emit_style_escape (SOMESTREAM) to
 396         SOMESTREAM->can_emit_style_escape.
 397         * source-cache.c (source_cache::get_source_lines): Likewise.
 398         * stack.c (frame_apply_command_count): Call execute_command_to_string
 399         passing the term_out characteristic of the current gdb_stdout.
 400         * thread.c (thr_try_catch_cmd): Likewise.
 401         * top.c (execute_command_to_string): pass term_out parameter
 402         to construct the string_file for the command output.
 403         * ui-file.c (term_cli_styling): New function (most code moved
 404         from utils.c can_emit_style_escape).
 405         (string_file::string_file, string_file::can_emit_style_escape,
 406         stdio_file::can_emit_style_escape, tee_file::term_out,
 407         tee_file::can_emit_style_escape): New functions.
 408
 409 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 410
 411         * NEWS: Mention the new set|show may-call-functions.
 412         * infcall.c (may_call_functions_p): New variable.
 413         (show_may_call_functions_p): New function.
 414         (call_function_by_hand_dummy): Throws an error if not
 415         may-call-functions.
 416         (_initialize_infcall): Call add_setshow_boolean_cmd for
 417         may-call-functions.
 418
 419 2019-04-25  Keith Seitz  <keiths@redhat.com>
 420
 421         PR c++/24367
 422         * cp-support.c (inspect_type): Don't attempt substitutions
 423         of symbol with the same name.
 424
 425 2019-04-25  Tom Tromey  <tromey@adacore.com>
 426
 427         PR gdb/24475:
 428         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 429         static.
 430
 431 2019-04-25  Tom Tromey  <tromey@adacore.com>
 432
 433         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 434         rvalue reference.
 435         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 436         (gdb_xml_parser::parse): Use std::move.
 437         * python/python-internal.h (gdbpy_convert_exception): Take a const
 438         reference.
 439         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 440         std::move.
 441         * python/py-utils.c (gdbpy_convert_exception): Take a const
 442         reference.
 443         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 444         Use std::move.
 445         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 446         Use std::move.
 447         * mi/mi-main.c (mi_print_exception): Take a const reference.
 448         * main.c (handle_command_errors): Take a const reference.
 449         * linespec.c (parse_linespec): Use std::move.
 450         * infcall.c (run_inferior_call): Use std::move.
 451         (call_function_by_hand_dummy): Use std::move.
 452         * exec.c (try_open_exec_file): Use std::move.
 453         * exceptions.h (exception_print, exception_fprintf)
 454         (exception_print_same): Update.
 455         * exceptions.c (print_exception, exception_print)
 456         (exception_fprintf, exception_print_same): Change parameters to
 457         const reference.
 458         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 459         * common/new-op.c: Use std::move.
 460         * common/common-exceptions.h (struct gdb_exception): Add move
 461         constructor.
 462         (struct gdb_exception_error, struct gdb_exception_quit, struct
 463         gdb_quit_bad_alloc): Change constructor to move constructor.
 464         (throw_exception): Change parameter to rvalue reference.
 465         * common/common-exceptions.c (throw_exception): Take rvalue
 466         reference.
 467         * cli/cli-interp.c (safe_execute_command): Use std::move.
 468         * breakpoint.c (insert_bp_location, location_to_sals): Use
 469         std::move.
 470
 471 2019-04-25  Tom Tromey  <tromey@adacore.com>
 472
 473         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 474         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 475         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 476         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 477         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 478         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 479         guile/scm-value.c: Use unpack.
 480         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 481         gdbscm_gdb_exception.
 482         (gdbscm_throw_gdb_exception): Likewise.
 483         (struct gdbscm_gdb_exception): New.
 484         (unpack): New function.
 485         (gdbscm_wrap): Use unpack.
 486
 487 2019-04-25  Tom Tromey  <tromey@adacore.com>
 488
 489         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 490         (gdb_rl_callback_handler): Use std::move.
 491         * common/common-exceptions.h (struct gdb_exception): Add move
 492         assignment operator.
 493         (throw_exception_sjlj): Change "exception" to const reference.
 494         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 495         (throw_exception_sjlj): Change "exception" to const reference.
 496
 497 2019-04-25  Tom Tromey  <tromey@adacore.com>
 498
 499         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 500         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 501         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 502         Update.
 503         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 504         Update.
 505         * mi/mi-interp.c (mi_interp::exec): Update.
 506         * linespec.c (parse_linespec): Update.
 507         * infcall.c (run_inferior_call): Update.
 508         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 509         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 510         (gdbscm_lookup_global_symbol): Update.
 511         * guile/scm-param.c (gdbscm_parameter_value): Update.
 512         * guile/scm-frame.c (gdbscm_frame_read_register)
 513         (gdbscm_frame_read_var): Update.
 514         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 515         * exec.c (try_open_exec_file): Update.
 516         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 517         (gdb_rl_callback_handler): Update.
 518         * common/common-exceptions.h (exception_none): Don't declare.
 519         * common/common-exceptions.c (exception_none): Don't define.
 520         (struct catcher) <exception>: Update.
 521         * cli/cli-interp.c (safe_execute_command): Update.
 522         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 523
 524 2019-04-25  Ali Tamur  <tamur@google.com>
 525
 526         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 527         (read_attribute_value): Likewise.
 528         (dwarf2_read_addr_index): Update comment.
 529         (read_str_index): Add DW_FORM_strx.
 530         (dwarf2_string_attr): Likewise.
 531         (dwarf2_const_value_attr): Likewise.
 532         (dump_die_shallow): Likewise.
 533         (dwarf2_fetch_constant_bytes): Likewise.
 534         (skip_form_bytes): Likewise.
 535         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 536
 537 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 538
 539         PR corefiles/11608
 540         PR corefiles/18187
 541         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 542         OFFSET.  Verify if current mapping contains an ELF header.
 543         (linux_find_memory_regions_full): Adjust call to
 544         dump_mapping_p.
 545
 546 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 547             Kang Li <kanglictf@gmail.com>
 548
 549         PR gdb/21600
 550
 551         * dwarf2-frame.c (read_initial_length): Be consistent about using
 552         unsigned representation of length.
 553         (decode_frame_entry_1): Likewise.  Check for wraparound of
 554         end pointer as well as buffer overflow.
 555
 556 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 557
 558         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 559         "vq".
 560
 561 2019-04-24  Tom Tromey  <tromey@adacore.com>
 562
 563         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 564
 565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * s12z-tdep.c (s12z_unwind_pc): Delete.
 568         (s12z_unwind_sp): Delete.
 569         (s12z_gdbarch_init): Don't register deleted functions with
 570         gdbarch.
 571
 572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * rl78-tdep.c (rl78_unwind_sp): Delete.
 575         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 576
 577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 578
 579         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 580         (xstormy16_unwind_pc): Delete.
 581         (xstormy16_dummy_id): Delete.
 582         (xstormy16_gdbarch_init): Don't register deleted functions with
 583         gdbarch.
 584
 585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 586
 587         * vax-tdep.c (vax_unwind_pc): Delete.
 588         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 589
 590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 591
 592         * v850-tdep.c (v850_unwind_sp): Delete.
 593         (v850_unwind_pc): Delete.
 594         (v850_dummy_id): Delete.
 595         (v850_gdbarch_init): Don't register deleted functions with
 596         gdbarch.
 597
 598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 599
 600         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 601         (tilegx_unwind_pc): Delete.
 602         (tilegx_unwind_dummy_id): Delete.
 603         (tilegx_gdbarch_init): Don't register deleted functions with
 604         gdbarch.
 605
 606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 607
 608         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 609         (tic6x_dummy_id): Delete.
 610         (tic6x_gdbarch_init): Don't register deleted functions with
 611         gdbarch.
 612
 613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 614
 615         * sparc-tdep.c (sparc_unwind_pc): Delete.
 616         (sparc32_gdbarch_init): Don't register deleted function with
 617         gdbarch.
 618
 619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 620
 621         * sh-tdep.c (sh_unwind_sp): Delete.
 622         (sh_unwind_pc): Delete.
 623         (sh_dummy_id): Delete.
 624         (sh_gdbarch_init): Don't register deleted functions with
 625         gdbarch.
 626
 627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 628
 629         * score-tdep.c (score_unwind_sp): Delete.
 630         (score_unwind_pc): Delete.
 631         (score_dummy_id): Delete.
 632         (score_gdbarch_init): Don't register deleted functions with
 633         gdbarch.
 634
 635 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 636
 637         * rx-tdep.c (rx_unwind_pc): Delete.
 638         (rx_unwind_sp): Delete.
 639         (rx_dummy_id): Delete.
 640         (rx_gdbarch_init): Don't register deleted functions with
 641         gdbarch.  Update comment.
 642
 643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 644
 645         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 646         (rs6000_dummy_id): Delete.
 647         (rs6000_gdbarch_init): Don't register deleted functions with
 648         gdbarch.
 649
 650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 651
 652         * or1k-tdep.c (or1k_dummy_id): Delete.
 653         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 654
 655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 656
 657         * nios2-tdep.c (nios2_dummy_id): Delete.
 658         (nios2_unwind_sp): Delete.
 659         (nios2_gdbarch_init): Don't register deleted functions with
 660         gdbarch.
 661
 662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * nds32-tdep.c (nds32_dummy_id): Delete.
 665         (nds32_unwind_pc): Delete.
 666         (nds32_unwind_sp): Delete.
 667         (nds32_gdbarch_init): Don't register deleted functions with
 668         gdbarch.
 669
 670 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 671
 672         * msp430-tdep.c (msp430_unwind_pc): Delete.
 673         (msp430_unwind_sp): Delete.
 674         (msp430_dummy_id): Delete.
 675         (msp430_gdbarch_init): Don't register deleted functions with
 676         gdbarch.
 677
 678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 679
 680         * moxie-tdep.c (moxie_unwind_sp): Delete.
 681         (moxie_unwind_pc): Delete.
 682         (moxie_dummy_id): Delete.
 683         (moxie_gdbarch_init): Don't register deleted functions with
 684         gdbarch.
 685
 686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 687
 688         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 689         (mn10300_unwind_pc): Delete.
 690         (mn10300_unwind_sp): Delete.
 691         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 692         mn10300_unwind_sp.
 693         (mn10300_frame_unwind_init): Don't register deleted functions with
 694         gdbarch.
 695
 696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 697
 698         * mep-tdep.c (mep_unwind_pc): Delete.
 699         (mep_unwind_sp): Delete.
 700         (mep_dummy_id): Delete.
 701         (mep_gdbarch_init): Don't register deleted functions with
 702         gdbarch.
 703
 704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 705
 706         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 707         (m68hc11_unwind_sp): Delete.
 708         (m68hc11_gdbarch_init): Don't register deleted functions with
 709         gdbarch.
 710
 711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 712
 713         * m32r-tdep.c (m32r_unwind_sp): Delete.
 714         (m32r_unwind_pc): Delete.
 715         (m32r_dummy_id): Delete.
 716         (m32r_gdbarch_init): Don't register deleted functions with
 717         gdbarch.
 718
 719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * m32c-tdep.c (m32c_unwind_pc): Delete.
 722         (m32c_unwind_sp): Delete.
 723         (m32c_dummy_id): Delete.
 724         (m32c_gdbarch_init): Don't register deleted functions with
 725         gdbarch.
 726
 727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 728
 729         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 730         (lm32_unwind_pc): Delete.
 731         (lm32_dummy_id): Delete.
 732         (lm32_gdbarch_init): Don't register deleted functions with
 733         gdbarch.
 734
 735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 736
 737         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 738         (iq2000_unwind_pc): Delete.
 739         (iq2000_dummy_id): Delete.
 740         (iq2000_gdbarch_init): Don't register deleted functions with
 741         gdbarch.
 742
 743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         * nds32-tdep.c (nds32_type_align): Delete.
 746         (nds32_push_dummy_call): Use type_align instead.
 747
 748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 749
 750         * arm-tdep.c (arm_type_align): Only handle vector override case.
 751         (arm_push_dummy_call): Use type_align.
 752         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 753
 754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 755
 756         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 757         case.
 758         (pass_on_stack): Use type_align.
 759         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 760         function.
 761
 762 2019-04-23  Tom Tromey  <tromey@adacore.com>
 763
 764         * dwarf2read.c (line_header::file_name_at): Remove unused
 765         overload.
 766
 767 2019-04-23  Tom de Vries  <tdevries@suse.de>
 768
 769         PR gdb/24438
 770         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 771         invocation.
 772
 773
 774 2019-03-27  Ali Tamur  <tamur@google.com>
 775
 776         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 777         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 778         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 779         (dwarf_expr_context::get_addr_index): Likewise
 780         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 781         (symbol_needs_eval_context::get_addr_index): Likewise
 782         (disassemble_dwarf_expression): Add DW_OP_addrx
 783         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 784         (read_cutu_die_from_dwo): Update comment
 785         (skip_one_die): Add DW_FORM_addrx
 786         (read_attribute_value): Likewise
 787         (var_decode_location): Add DW_OP_addrx
 788         (dwarf2_const_value_attr): Add DW_FORM_addrx
 789         (dump_die_shallow): Likewise
 790         (dwarf2_fetch_constant_bytes): Likewise
 791         (decode_locdesc): Add DW_OP_addrx
 792         (skip_form_bytes): Add DW_FORM_addrx
 793
 794 2019-04-22  Ali Tamur  <tamur@google.com>
 795
 796         * MAINTAINERS (Write After Approval): Add self.
 797
 798 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 799
 800         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 801         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 802         (open_symbol_file_object): Likewise.
 803         (svr4_default_sos): Add info parameter.
 804         (svr4_read_so_list): Likewise.
 805         (svr4_current_sos_direct): Adjust functions calls to pass down
 806         info.
 807         (svr4_current_sos_1): Add info parameter.
 808         (svr4_current_sos): Call get_svr4_info, pass info down to
 809         svr4_current_sos_1.
 810         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 811         get_svr4_info.
 812         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 813         get_svr4_info.
 814         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 815         to get_svr4_info.
 816         (probes_table_remove_objfile_probes): Likewise.
 817         (register_solib_event_probe): Add info parameter.
 818         (solist_update_incremental): Pass info parameter down to
 819         svr4_read_so_list.
 820         (disable_probes_interface): Add info parameter.
 821         (svr4_handle_solib_event): Pass current_program_space to
 822         get_svr4_info.  Adjust disable_probes_interface cleanup.
 823         (svr4_create_probe_breakpoints): Add info parameter, pass it
 824         down to register_solib_event_probe.
 825         (svr4_create_solib_event_breakpoints): Add info parameter,
 826         pass it down to svr4_create_probe_breakpoints.
 827         (enable_break): Pass info down to
 828         svr4_create_solib_event_breakpoints.
 829         (svr4_solib_create_inferior_hook): Pass current_program_space to
 830         get_svr4_info.
 831         (svr4_clear_solib): Likewise.
 832
 833 2019-04-22  Pedro Alves  <palves@redhat.com>
 834
 835         * solib-svr4.c (svr4_free_objfile_observer): New.
 836         (probe_and_action::objfile): New field.
 837         (probes_table_htab_remove_objfile_probes)
 838         (probes_table_remove_objfile_probes): New functions.
 839         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 840         in the new probe_and_action.  Don't store the probe in 'lookup'.
 841         (svr4_create_probe_breakpoints): Pass objfile to
 842         register_solib_event_probe.
 843         (_initialize_svr4_solib): Register a free_objfile observer.
 844
 845 2019-04-19  Tom Tromey  <tom@tromey.com>
 846
 847         * common/queue.h: Remove.
 848
 849 2019-04-19  Tom Tromey  <tom@tromey.com>
 850
 851         * event-loop.c: Don't include "common/queue.h".
 852
 853 2019-04-19  Tom Tromey  <tom@tromey.com>
 854
 855         * remote.c (remote_target): Use delete.
 856         * remote-notif.h: Include <list>, not "common/queue.h".
 857         (notif_client_p): Remove typedef.
 858         (remote_notif_state): Add constructor, destructor, initializer.
 859         <notif_queue>: Now a std::list.
 860         (remote_notif_state_xfree): Don't declare.
 861         * remote-notif.c (remote_notif_process, handle_notification)
 862         (remote_notif_state_allocate): Update.
 863         (~remote_notif_state): Rename from remote_notif_state_xfree.
 864
 865 2019-04-19  Tom Tromey  <tom@tromey.com>
 866
 867         * symfile.c (reread_symbols): Update.
 868         * objfiles.c (objfile_register_static_link)
 869         (objfile_lookup_static_link): Update
 870         (~objfile) Don't delete static_links.
 871         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 872
 873 2019-04-19  Tom Tromey  <tom@tromey.com>
 874
 875         * type-stack.h (struct type_stack) <insert>: Constify string.
 876         * type-stack.c (type_stack::insert): Constify string.
 877         * gdbtypes.h (lookup_template_type): Update.
 878         (address_space_name_to_int): Update.
 879         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 880         const.
 881         (lookup_template_type): Make name const.
 882         * c-exp.y: Update rules.
 883         (lex_one_token, classify_name, classify_inner_name)
 884         (c_print_token): Update.
 885         * p-exp.y: Update rules.
 886         (yylex): Update.
 887         * f-exp.y: Update rules.
 888         (yylex): Update.
 889         * d-exp.y: Update rules.
 890         (lex_one_token, classify_name, classify_inner_name): Update.
 891         * parse.c (write_dollar_variable, copy_name): Return std::string.
 892         * parser-defs.h (copy_name): Change return type.
 893         * m2-exp.y: Update rules.
 894         (yylex): Update.
 895         * go-exp.y (lex_one_token): Update.
 896         Update rules.
 897         (classify_unsafe_function, classify_packaged_name)
 898         (classify_name, yylex): Update.
 899
 900 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 901
 902         * configure.ac: add --enable-source-highlight switch.
 903         * configure: Regenerate.
 904         * top.c (print_gdb_version): plumb --enable-source-highlight
 905         status to "show configuration".
 906
 907 2019-04-19  Tom Tromey  <tromey@adacore.com>
 908
 909         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 910         Check ADA_TYPE_P.
 911         (empty_record, ada_template_to_fixed_record_type_1)
 912         (template_to_static_fixed_type)
 913         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 914         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 915         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 916         macros.
 917
 918 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 919
 920         PR symtab/24423:
 921         * source.c (print_source_lines_base): Advance "iter" when a
 922         control character is seen.
 923
 924 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 925
 926         * inferior.h (struct infcall_suspend_state_deleter):
 927         Catch exception in destructor to avoid crash.
 928
 929 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 930
 931         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 932         close to the add_com "shell".
 933
 934 2019-04-18  Tom Tromey  <tromey@adacore.com>
 935
 936         * process-stratum-target.h (class process_stratum_target)
 937         <stratum>: Add "final".
 938
 939 2019-04-17  Tom Tromey  <tromey@adacore.com>
 940
 941         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 942         against nullptr before use.
 943
 944 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 945
 946         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 947
 948 2019-04-17  Jim Wilson  <jimw@sifive.com>
 949             Andrew Burgess  <andrew.burgess@embecosm.com>
 950
 951         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 952         code read might fail, assume 4-byte breakpoint in that case.
 953
 954 2019-04-15  Leszek Swirski  <leszeks@google.com>
 955
 956         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 957         rather than a hand-rolled POD check when checking for forced MEMORY
 958         classification.
 959
 960 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 961
 962         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 963         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 964         function.
 965         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 966         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 967         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 968         declaration.
 969
 970 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 971
 972         * aarch64-linux-nat.c
 973         (aarch64_linux_nat_target::thread_architecture): Add override.
 974         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 975         each VQ.
 976
 977 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 978
 979         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 980
 981 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 982
 983         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 984         target types of size 96-bits, add some additional comments, and
 985         check that the builtin type we found was the correct size.
 986
 987 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 988
 989         * utils.c (prompt_for_continue): Don't restore the styling at the
 990         end, as applied_style has the wrong value.  This fixes styling in
 991         long lists of file names that are interrupted by the "Continue?"
 992         prompt.
 993
 994 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 995
 996         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 997         * c-lang.c (c_language_defn): Likewise.
 998         (cplus_language_defn): Likewise.
 999         (asm_language_defn): Likewise.
1000         (minimal_language_defn): Likewise.
1001         * d-lang.c (d_language_defn): Likewise.
1002         * f-lang.c (f_language_defn): Likewise.
1003         * go-lang.c (go_language_defn): Likewise.
1004         * language.c (unknown_language_defn): Likewise.
1005         (auto_language_defn): Likewise.
1006         * language.h (struct language_defn): Remove la_magic field.
1007         (LANG_MAGIC): Delete.
1008         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1009         * objc-lang.c (objc_language_defn): Likewise.
1010         * opencl-lang.c (opencl_language_defn): Likewise.
1011         * p-lang.c (pascal_language_defn): Likewise.
1012         * rust-lang.c (rust_language_defn): Likewise.
1013
1014 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * riscv-tdep.c (riscv_type_align): New function.
1017         (riscv_type_alignment): Delete.
1018         (riscv_arg_location): Use 'type_align'.
1019         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1020
1021 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1022
1023         * gdbtypes.c (type_align): A struct with no non-static fields also
1024         has alignment of 1.
1025
1026 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1027
1028         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1029         component to 0.
1030         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1031         member.
1032         (riscv_struct_info::analyse): New implementation using new
1033         analyse_inner member function.
1034         (riscv_struct_info::field_offset): New member function.
1035         (riscv_struct_info::m_offsets): New member variable.
1036         (riscv_struct_info::analyse_inner): New private member function,
1037         takes the old implementation of riscv_struct_info::analyse but
1038         extended to track field offsets.
1039         (riscv_call_arg_struct): Update the struct folding special cases
1040         to handle cases where empty C++ structs, which are non-zero
1041         length, are found.
1042         (riscv_arg_location): Initialise the length of each location, a
1043         non-zero length now indicates the location is in use.
1044         (riscv_push_dummy_call): Allow for the first location having a
1045         non-zero offset when setting up arguments.
1046         (riscv_return_value): Likewise, but for return values.
1047
1048 2019-04-11  Tom Tromey  <tromey@adacore.com>
1049
1050         * utils.c (internal_vproblem): Make "msg" const.
1051
1052 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1053
1054         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1055         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1056         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1057         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1058
1059 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1060
1061         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1062         function.
1063         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1064         of amd64_collect_native_gregset.
1065         (amd64_linux_nat_target::store_registers): Likewise.
1066
1067 2019-04-10  Tom Tromey  <tom@tromey.com>
1068
1069         * symtab.c (lookup_global_symbol_from_objfile)
1070         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1071         * objfiles.h (class separate_debug_iterator): New.
1072         (class separate_debug_range): New.
1073         (struct objfile) <separate_debug_objfiles>: New method.
1074         (objfile_separate_debug_iterate): Don't declare.
1075         * objfiles.c (separate_debug_iterator::operator++): Rename from
1076         objfile_separate_debug_iterate.
1077         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1078         iterator.
1079         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1080         iterator.
1081
1082 2019-04-10  Tom Tromey  <tom@tromey.com>
1083
1084         * symfile.c (reread_symbols): Remove old comment.
1085         * objfiles.c (free_all_objfiles): Fix a typo.
1086
1087 2019-04-10  Tom Tromey  <tom@tromey.com>
1088
1089         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1090         * minsyms.c (lookup_minimal_symbol): Use foreach.
1091         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1092         (lookup_minimal_symbol_solib_trampoline): Likewise.
1093         * symfile.c (reread_symbols): Use foreach.
1094
1095 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1096             Tom Tromey  <tromey@adacore.com>
1097
1098         PR rust/24414:
1099         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1100         (rust_lex_int_test): Change "value" to be LONGEST.
1101         (rust_lex_tests): Add test for long integer literal.
1102
1103 2019-04-09  Tom Tromey  <tromey@adacore.com>
1104
1105         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1106         to bool.
1107         (extended_remote_target::attach): Update.
1108         (remote_target::remote_notice_new_inferior): Update.
1109         (remote_target::add_current_inferior_and_thread): Update.
1110         * inferior.c (exit_inferior_1): Use "false".
1111         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1112
1113 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1114
1115         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1116         the "start" command.
1117
1118 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1119
1120         * python/py-inferior.c (infpy_thread_from_thread_handle):
1121         Adjust comments to reflect renaming of thread_from_thread_handle
1122         to thread_from_handle.  Adjust keywords.  Fix type error message.
1123         (inferior_object_methods): Add thread_from_handle.  Retain
1124         thread_from_thread_handle, but mark it as deprecated.
1125
1126 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1127
1128         * gdbthread.h (find_thread_by_handle): Revise declaration.
1129         * thread.c (find_thread_by_handle): Likewise.  Adjust
1130         implementation too.
1131         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1132         support for buffer objects as handles.
1133
1134 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1135
1136         * python/py-infthread.c (thpy_thread_handle): New function.
1137         (thread_object_methods): Register thpy_thread_handle.
1138
1139 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1140
1141         * gdbthread.h (thread_to_thread_handle): Declare.
1142         * thread.c (gdbtypes.h): Include.
1143         (thread_to_thread_handle): New function.
1144
1145         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1146         (target_thread_info_to_thread_handle): Declare.
1147         * target.c (target_thread_info_to_thread_handle): New function.
1148         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1149         * target-delegates.c: Regenerate.
1150
1151         * linux-thread-db.c (class thread_db_target): Add method
1152         thread_info_to_thread_handle.
1153         (thread_db_target::thread_info_to_thread_handle): Define.
1154         * remote.c (class remote_target): Add new method
1155         thread_info_to_thread_handle.
1156         (remote_target::thread_info_to_thread_handle): Define.
1157
1158 2019-04-08  Pedro Alves  <palves@redhat.com>
1159
1160         * common/common-exceptions.c (throw_exception): Don't create
1161         named object to throw; throw directly.
1162         (throw_it): Likewise.  Don't initialize gdb_exception::message
1163         here, with new; pass FMT and AP to the ctor instead.
1164         * common/common-exceptions.h: Include <string>.
1165         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1166         const char *, va_list)): New ctor.  Use std::make_shared.
1167         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1168         errors)): Delete.
1169         (gdb_exception_error::gdb_exception_error(enum errors, const char
1170         *, va_list)): New.
1171         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1172         Add assertion.
1173         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1174         errors)): Delete.
1175         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1176         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1177         Add assertion.
1178
1179 2019-04-08  Tom Tromey  <tom@tromey.com>
1180
1181         * valops.c (value_rtti_indirect_type): Replace throw_exception
1182         with throw.
1183         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1184         with throw.
1185         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1186         throw.
1187         * target.c (target_translate_tls_address): Replace throw_exception
1188         with throw.
1189         * stack.c (frame_apply_command_count): Replace throw_exception
1190         with throw.
1191         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1192         throw.
1193         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1194         with throw.
1195         * rs6000-tdep.c (rs6000_frame_cache)
1196         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1197         * remote.c: Replace throw_exception with throw.
1198         * record-full.c (record_full_message, record_full_wait_1)
1199         (record_full_restore): Replace throw_exception with throw.
1200         * record-btrace.c:
1201         (get_thread_current_frame_id, record_btrace_start_replaying)
1202         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1203         (cmd_record_btrace_start): Replace throw_exception with throw.
1204         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1205         throw.
1206         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1207         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1208         * linespec.c:
1209         (find_linespec_symbols): Replace throw_exception with throw.
1210         * infrun.c (displaced_step_prepare, resume): Replace
1211         throw_exception with throw.
1212         * infcmd.c (post_create_inferior): Replace throw_exception with
1213         throw.
1214         * inf-loop.c (inferior_event_handler): Replace throw_exception
1215         with throw.
1216         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1217         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1218         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1219         (get_prev_frame_always, get_frame_pc_if_available)
1220         (get_frame_address_in_block_if_available, get_frame_language):
1221         Replace throw_exception with throw.
1222         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1223         throw_exception with throw.
1224         * eval.c (fetch_subexp_value, evaluate_var_value)
1225         (evaluate_funcall, evaluate_subexp_standard): Replace
1226         throw_exception with throw.
1227         * dwarf2loc.c (call_site_find_chain)
1228         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1229         Replace throw_exception with throw.
1230         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1231         with throw.
1232         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1233         throw.
1234         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1235         * completer.c (complete_line_internal): Replace throw_exception
1236         with throw.
1237         * compile/compile-object-run.c (compile_object_run): Replace
1238         throw_exception with throw.
1239         * cli/cli-script.c (process_next_line): Replace throw_exception
1240         with throw.
1241         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1242         (btrace_enable, btrace_maint_update_pt_packets): Replace
1243         throw_exception with throw.
1244         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1245         throw_exception with throw.
1246         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1247         throw_exception with throw.
1248         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1249         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1250         * aarch64-tdep.c (aarch64_make_prologue_cache)
1251         (aarch64_make_stub_cache): Replace throw_exception with throw.
1252
1253 2019-04-08  Tom Tromey  <tom@tromey.com>
1254
1255         * common/common-exceptions.c (throw_exception): Rename from
1256         throw_exception_cxx.  Remove old copy.  Make argument const.
1257         (throw_it): Create and throw exception objects directly.
1258         * common/common-exceptions.h (throw_exception): Make argument
1259         const.
1260         (struct gdb_exception_error): Add constructor.
1261         (struct gdb_exception_quit): Add constructor.
1262
1263 2019-04-08  Tom Tromey  <tom@tromey.com>
1264
1265         * common/common-exceptions.h (exception_rethrow): Don't declare.
1266         (TRY_SJLJ): Update comment.
1267         (TRY, CATCH, END_CATCH): Remove.
1268         * common/common-exceptions.c (exception_rethrow): Remove.
1269
1270 2019-04-08  Tom Tromey  <tom@tromey.com>
1271
1272         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1273         Remove.
1274         (gdb_exception_error): Rename from
1275         gdb_exception_RETURN_MASK_ERROR.
1276         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1277         (gdb_quit_bad_alloc): Update.
1278         * aarch64-tdep.c: Update.
1279         * ada-lang.c: Update.
1280         * ada-typeprint.c: Update.
1281         * ada-valprint.c: Update.
1282         * amd64-tdep.c: Update.
1283         * arch-utils.c: Update.
1284         * break-catch-throw.c: Update.
1285         * breakpoint.c: Update.
1286         * btrace.c: Update.
1287         * c-varobj.c: Update.
1288         * cli/cli-cmds.c: Update.
1289         * cli/cli-interp.c: Update.
1290         * cli/cli-script.c: Update.
1291         * common/common-exceptions.c: Update.
1292         * common/new-op.c: Update.
1293         * common/selftest.c: Update.
1294         * compile/compile-c-symbols.c: Update.
1295         * compile/compile-cplus-symbols.c: Update.
1296         * compile/compile-object-load.c: Update.
1297         * compile/compile-object-run.c: Update.
1298         * completer.c: Update.
1299         * corelow.c: Update.
1300         * cp-abi.c: Update.
1301         * cp-support.c: Update.
1302         * cp-valprint.c: Update.
1303         * darwin-nat.c: Update.
1304         * disasm-selftests.c: Update.
1305         * dtrace-probe.c: Update.
1306         * dwarf-index-cache.c: Update.
1307         * dwarf-index-write.c: Update.
1308         * dwarf2-frame-tailcall.c: Update.
1309         * dwarf2-frame.c: Update.
1310         * dwarf2loc.c: Update.
1311         * dwarf2read.c: Update.
1312         * eval.c: Update.
1313         * event-loop.c: Update.
1314         * event-top.c: Update.
1315         * exec.c: Update.
1316         * f-valprint.c: Update.
1317         * fbsd-tdep.c: Update.
1318         * frame-unwind.c: Update.
1319         * frame.c: Update.
1320         * gdbtypes.c: Update.
1321         * gnu-v3-abi.c: Update.
1322         * guile/guile-internal.h: Update.
1323         * guile/scm-block.c: Update.
1324         * guile/scm-breakpoint.c: Update.
1325         * guile/scm-cmd.c: Update.
1326         * guile/scm-disasm.c: Update.
1327         * guile/scm-frame.c: Update.
1328         * guile/scm-lazy-string.c: Update.
1329         * guile/scm-math.c: Update.
1330         * guile/scm-param.c: Update.
1331         * guile/scm-ports.c: Update.
1332         * guile/scm-pretty-print.c: Update.
1333         * guile/scm-symbol.c: Update.
1334         * guile/scm-symtab.c: Update.
1335         * guile/scm-type.c: Update.
1336         * guile/scm-value.c: Update.
1337         * i386-linux-tdep.c: Update.
1338         * i386-tdep.c: Update.
1339         * inf-loop.c: Update.
1340         * infcall.c: Update.
1341         * infcmd.c: Update.
1342         * infrun.c: Update.
1343         * jit.c: Update.
1344         * language.c: Update.
1345         * linespec.c: Update.
1346         * linux-fork.c: Update.
1347         * linux-nat.c: Update.
1348         * linux-tdep.c: Update.
1349         * linux-thread-db.c: Update.
1350         * main.c: Update.
1351         * mi/mi-cmd-break.c: Update.
1352         * mi/mi-cmd-stack.c: Update.
1353         * mi/mi-interp.c: Update.
1354         * mi/mi-main.c: Update.
1355         * objc-lang.c: Update.
1356         * p-valprint.c: Update.
1357         * parse.c: Update.
1358         * ppc-linux-tdep.c: Update.
1359         * printcmd.c: Update.
1360         * python/py-arch.c: Update.
1361         * python/py-breakpoint.c: Update.
1362         * python/py-cmd.c: Update.
1363         * python/py-finishbreakpoint.c: Update.
1364         * python/py-frame.c: Update.
1365         * python/py-framefilter.c: Update.
1366         * python/py-gdb-readline.c: Update.
1367         * python/py-inferior.c: Update.
1368         * python/py-infthread.c: Update.
1369         * python/py-lazy-string.c: Update.
1370         * python/py-linetable.c: Update.
1371         * python/py-objfile.c: Update.
1372         * python/py-param.c: Update.
1373         * python/py-prettyprint.c: Update.
1374         * python/py-progspace.c: Update.
1375         * python/py-record-btrace.c: Update.
1376         * python/py-record.c: Update.
1377         * python/py-symbol.c: Update.
1378         * python/py-type.c: Update.
1379         * python/py-unwind.c: Update.
1380         * python/py-utils.c: Update.
1381         * python/py-value.c: Update.
1382         * python/python.c: Update.
1383         * record-btrace.c: Update.
1384         * record-full.c: Update.
1385         * remote-fileio.c: Update.
1386         * remote.c: Update.
1387         * riscv-tdep.c: Update.
1388         * rs6000-aix-tdep.c: Update.
1389         * rs6000-tdep.c: Update.
1390         * rust-exp.y: Update.
1391         * rust-lang.c: Update.
1392         * s390-tdep.c: Update.
1393         * selftest-arch.c: Update.
1394         * solib-dsbt.c: Update.
1395         * solib-frv.c: Update.
1396         * solib-spu.c: Update.
1397         * solib-svr4.c: Update.
1398         * solib.c: Update.
1399         * sparc64-linux-tdep.c: Update.
1400         * stack.c: Update.
1401         * symfile-mem.c: Update.
1402         * symmisc.c: Update.
1403         * target.c: Update.
1404         * thread.c: Update.
1405         * top.c: Update.
1406         * tracefile-tfile.c: Update.
1407         * tui/tui.c: Update.
1408         * typeprint.c: Update.
1409         * unittests/cli-utils-selftests.c: Update.
1410         * unittests/parse-connection-spec-selftests.c: Update.
1411         * valops.c: Update.
1412         * valprint.c: Update.
1413         * value.c: Update.
1414         * varobj.c: Update.
1415         * windows-nat.c: Update.
1416         * x86-linux-nat.c: Update.
1417         * xml-support.c: Update.
1418
1419 2019-04-08  Tom Tromey  <tom@tromey.com>
1420
1421         * xml-support.c: Use C++ exception handling.
1422         * x86-linux-nat.c: Use C++ exception handling.
1423         * windows-nat.c: Use C++ exception handling.
1424         * varobj.c: Use C++ exception handling.
1425         * value.c: Use C++ exception handling.
1426         * valprint.c: Use C++ exception handling.
1427         * valops.c: Use C++ exception handling.
1428         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1429         handling.
1430         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1431         * typeprint.c: Use C++ exception handling.
1432         * tui/tui.c: Use C++ exception handling.
1433         * tracefile-tfile.c: Use C++ exception handling.
1434         * top.c: Use C++ exception handling.
1435         * thread.c: Use C++ exception handling.
1436         * target.c: Use C++ exception handling.
1437         * symmisc.c: Use C++ exception handling.
1438         * symfile-mem.c: Use C++ exception handling.
1439         * stack.c: Use C++ exception handling.
1440         * sparc64-linux-tdep.c: Use C++ exception handling.
1441         * solib.c: Use C++ exception handling.
1442         * solib-svr4.c: Use C++ exception handling.
1443         * solib-spu.c: Use C++ exception handling.
1444         * solib-frv.c: Use C++ exception handling.
1445         * solib-dsbt.c: Use C++ exception handling.
1446         * selftest-arch.c: Use C++ exception handling.
1447         * s390-tdep.c: Use C++ exception handling.
1448         * rust-lang.c: Use C++ exception handling.
1449         * rust-exp.y: Use C++ exception handling.
1450         * rs6000-tdep.c: Use C++ exception handling.
1451         * rs6000-aix-tdep.c: Use C++ exception handling.
1452         * riscv-tdep.c: Use C++ exception handling.
1453         * remote.c: Use C++ exception handling.
1454         * remote-fileio.c: Use C++ exception handling.
1455         * record-full.c: Use C++ exception handling.
1456         * record-btrace.c: Use C++ exception handling.
1457         * python/python.c: Use C++ exception handling.
1458         * python/py-value.c: Use C++ exception handling.
1459         * python/py-utils.c: Use C++ exception handling.
1460         * python/py-unwind.c: Use C++ exception handling.
1461         * python/py-type.c: Use C++ exception handling.
1462         * python/py-symbol.c: Use C++ exception handling.
1463         * python/py-record.c: Use C++ exception handling.
1464         * python/py-record-btrace.c: Use C++ exception handling.
1465         * python/py-progspace.c: Use C++ exception handling.
1466         * python/py-prettyprint.c: Use C++ exception handling.
1467         * python/py-param.c: Use C++ exception handling.
1468         * python/py-objfile.c: Use C++ exception handling.
1469         * python/py-linetable.c: Use C++ exception handling.
1470         * python/py-lazy-string.c: Use C++ exception handling.
1471         * python/py-infthread.c: Use C++ exception handling.
1472         * python/py-inferior.c: Use C++ exception handling.
1473         * python/py-gdb-readline.c: Use C++ exception handling.
1474         * python/py-framefilter.c: Use C++ exception handling.
1475         * python/py-frame.c: Use C++ exception handling.
1476         * python/py-finishbreakpoint.c: Use C++ exception handling.
1477         * python/py-cmd.c: Use C++ exception handling.
1478         * python/py-breakpoint.c: Use C++ exception handling.
1479         * python/py-arch.c: Use C++ exception handling.
1480         * printcmd.c: Use C++ exception handling.
1481         * ppc-linux-tdep.c: Use C++ exception handling.
1482         * parse.c: Use C++ exception handling.
1483         * p-valprint.c: Use C++ exception handling.
1484         * objc-lang.c: Use C++ exception handling.
1485         * mi/mi-main.c: Use C++ exception handling.
1486         * mi/mi-interp.c: Use C++ exception handling.
1487         * mi/mi-cmd-stack.c: Use C++ exception handling.
1488         * mi/mi-cmd-break.c: Use C++ exception handling.
1489         * main.c: Use C++ exception handling.
1490         * linux-thread-db.c: Use C++ exception handling.
1491         * linux-tdep.c: Use C++ exception handling.
1492         * linux-nat.c: Use C++ exception handling.
1493         * linux-fork.c: Use C++ exception handling.
1494         * linespec.c: Use C++ exception handling.
1495         * language.c: Use C++ exception handling.
1496         * jit.c: Use C++ exception handling.
1497         * infrun.c: Use C++ exception handling.
1498         * infcmd.c: Use C++ exception handling.
1499         * infcall.c: Use C++ exception handling.
1500         * inf-loop.c: Use C++ exception handling.
1501         * i386-tdep.c: Use C++ exception handling.
1502         * i386-linux-tdep.c: Use C++ exception handling.
1503         * guile/scm-value.c: Use C++ exception handling.
1504         * guile/scm-type.c: Use C++ exception handling.
1505         * guile/scm-symtab.c: Use C++ exception handling.
1506         * guile/scm-symbol.c: Use C++ exception handling.
1507         * guile/scm-pretty-print.c: Use C++ exception handling.
1508         * guile/scm-ports.c: Use C++ exception handling.
1509         * guile/scm-param.c: Use C++ exception handling.
1510         * guile/scm-math.c: Use C++ exception handling.
1511         * guile/scm-lazy-string.c: Use C++ exception handling.
1512         * guile/scm-frame.c: Use C++ exception handling.
1513         * guile/scm-disasm.c: Use C++ exception handling.
1514         * guile/scm-cmd.c: Use C++ exception handling.
1515         * guile/scm-breakpoint.c: Use C++ exception handling.
1516         * guile/scm-block.c: Use C++ exception handling.
1517         * guile/guile-internal.h: Use C++ exception handling.
1518         * gnu-v3-abi.c: Use C++ exception handling.
1519         * gdbtypes.c: Use C++ exception handling.
1520         * frame.c: Use C++ exception handling.
1521         * frame-unwind.c: Use C++ exception handling.
1522         * fbsd-tdep.c: Use C++ exception handling.
1523         * f-valprint.c: Use C++ exception handling.
1524         * exec.c: Use C++ exception handling.
1525         * event-top.c: Use C++ exception handling.
1526         * event-loop.c: Use C++ exception handling.
1527         * eval.c: Use C++ exception handling.
1528         * dwarf2read.c: Use C++ exception handling.
1529         * dwarf2loc.c: Use C++ exception handling.
1530         * dwarf2-frame.c: Use C++ exception handling.
1531         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1532         * dwarf-index-write.c: Use C++ exception handling.
1533         * dwarf-index-cache.c: Use C++ exception handling.
1534         * dtrace-probe.c: Use C++ exception handling.
1535         * disasm-selftests.c: Use C++ exception handling.
1536         * darwin-nat.c: Use C++ exception handling.
1537         * cp-valprint.c: Use C++ exception handling.
1538         * cp-support.c: Use C++ exception handling.
1539         * cp-abi.c: Use C++ exception handling.
1540         * corelow.c: Use C++ exception handling.
1541         * completer.c: Use C++ exception handling.
1542         * compile/compile-object-run.c: Use C++ exception handling.
1543         * compile/compile-object-load.c: Use C++ exception handling.
1544         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1545         * compile/compile-c-symbols.c: Use C++ exception handling.
1546         * common/selftest.c: Use C++ exception handling.
1547         * common/new-op.c: Use C++ exception handling.
1548         * cli/cli-script.c: Use C++ exception handling.
1549         * cli/cli-interp.c: Use C++ exception handling.
1550         * cli/cli-cmds.c: Use C++ exception handling.
1551         * c-varobj.c: Use C++ exception handling.
1552         * btrace.c: Use C++ exception handling.
1553         * breakpoint.c: Use C++ exception handling.
1554         * break-catch-throw.c: Use C++ exception handling.
1555         * arch-utils.c: Use C++ exception handling.
1556         * amd64-tdep.c: Use C++ exception handling.
1557         * ada-valprint.c: Use C++ exception handling.
1558         * ada-typeprint.c: Use C++ exception handling.
1559         * ada-lang.c: Use C++ exception handling.
1560         * aarch64-tdep.c: Use C++ exception handling.
1561
1562 2019-04-08  Tom Tromey  <tom@tromey.com>
1563
1564         * xml-support.c (gdb_xml_parser::parse): Update.
1565         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1566         * value.c (show_convenience): Update.
1567         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1568         (test_parse_flags_qcs): Update.
1569         * thread.c (thr_try_catch_cmd): Update.
1570         * target.c (target_translate_tls_address): Update.
1571         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1572         (info_frame_command_core, frame_apply_command_count): Update.
1573         * rust-exp.y (rust_lex_exception_test): Update.
1574         * riscv-tdep.c (riscv_print_one_register_info): Update.
1575         * remote.c (remote_target::enable_btrace): Update.
1576         * record-btrace.c (record_btrace_enable_warn): Update.
1577         * python/py-utils.c (gdbpy_convert_exception): Update.
1578         * printcmd.c (do_one_display, print_variable_and_value): Update.
1579         * mi/mi-main.c (mi_print_exception): Update.
1580         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1581         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1582         * linux-nat.c (linux_nat_target::attach): Update.
1583         * linux-fork.c (class scoped_switch_fork_info): Update.
1584         * infrun.c (displaced_step_prepare): Update.
1585         * infcall.c (call_function_by_hand_dummy): Update.
1586         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1587         * gnu-v3-abi.c (print_one_vtable): Update.
1588         * frame.c (get_prev_frame_always): Update.
1589         * f-valprint.c (info_common_command_for_block): Update.
1590         * exec.c (try_open_exec_file): Update.
1591         * exceptions.c (print_exception, exception_print)
1592         (exception_fprintf, exception_print_same): Update.
1593         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1594         * dwarf-index-cache.c (index_cache::store)
1595         (index_cache::lookup_gdb_index): Update.
1596         * darwin-nat.c (maybe_cache_shell): Update.
1597         * cp-valprint.c (cp_print_value_fields): Update.
1598         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1599         (gcc_cplus_symbol_address): Update.
1600         * compile/compile-c-symbols.c (gcc_convert_symbol)
1601         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1602         * common/selftest.c: Update.
1603         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1604         a std::string.
1605         (exception_try_scope_entry, exception_try_scope_exit): Don't
1606         declare.
1607         (struct exception_try_scope): Remove.
1608         (TRY): Don't use exception_try_scope.
1609         (struct gdb_exception): Add constructor, operator=.
1610         <what>: New method.
1611         (struct gdb_exception_RETURN_MASK_ALL)
1612         (struct gdb_exception_RETURN_MASK_ERROR)
1613         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1614         (struct gdb_quit_bad_alloc): Update.
1615         * common/common-exceptions.c (exception_none): Change
1616         initializer.
1617         (struct catcher) <state, exception>: Initialize inline.
1618         <prev>: Remove member.
1619         (current_catcher): Remove.
1620         (catchers): New global.
1621         (exceptions_state_mc_init): Simplify.
1622         (catcher_pop): Remove.
1623         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1624         (try_scope_depth, exception_try_scope_entry)
1625         (exception_try_scope_exit): Remove.
1626         (throw_exception_sjlj): Update.
1627         (exception_messages, exception_messages_size): Remove.
1628         (throw_it): Simplify.
1629         (gdb_exception_sliced_copy): Remove.
1630         (throw_exception_cxx): Update.
1631         * cli/cli-script.c (script_from_file): Update.
1632         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1633         Update.
1634         * ada-valprint.c (ada_val_print): Update.
1635         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1636         (create_excep_cond_exprs): Update.
1637
1638 2019-04-08  Tom Tromey  <tom@tromey.com>
1639
1640         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1641         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1642         (TRY, CATCH, END_CATCH): Remove some definitions.
1643         * common/common-exceptions.c: Don't use GDB_XCPT.
1644         (catcher_list_size): Remove.
1645         (throw_exception, throw_it): Simplify.
1646
1647 2019-04-05  Tom Tromey  <tom@tromey.com>
1648
1649         Revert the header-sorting patch.
1650         * ft32-tdep.c: Revert.
1651         * frv-tdep.c: Revert.
1652         * frv-linux-tdep.c: Revert.
1653         * frame.c: Revert.
1654         * frame-unwind.c: Revert.
1655         * frame-base.c: Revert.
1656         * fork-child.c: Revert.
1657         * findvar.c: Revert.
1658         * findcmd.c: Revert.
1659         * filesystem.c: Revert.
1660         * filename-seen-cache.h: Revert.
1661         * filename-seen-cache.c: Revert.
1662         * fbsd-tdep.c: Revert.
1663         * fbsd-nat.h: Revert.
1664         * fbsd-nat.c: Revert.
1665         * f-valprint.c: Revert.
1666         * f-typeprint.c: Revert.
1667         * f-lang.c: Revert.
1668         * extension.h: Revert.
1669         * extension.c: Revert.
1670         * extension-priv.h: Revert.
1671         * expprint.c: Revert.
1672         * exec.h: Revert.
1673         * exec.c: Revert.
1674         * exceptions.c: Revert.
1675         * event-top.c: Revert.
1676         * event-loop.c: Revert.
1677         * eval.c: Revert.
1678         * elfread.c: Revert.
1679         * dwarf2read.h: Revert.
1680         * dwarf2read.c: Revert.
1681         * dwarf2loc.c: Revert.
1682         * dwarf2expr.h: Revert.
1683         * dwarf2expr.c: Revert.
1684         * dwarf2-frame.c: Revert.
1685         * dwarf2-frame-tailcall.c: Revert.
1686         * dwarf-index-write.h: Revert.
1687         * dwarf-index-write.c: Revert.
1688         * dwarf-index-common.c: Revert.
1689         * dwarf-index-cache.h: Revert.
1690         * dwarf-index-cache.c: Revert.
1691         * dummy-frame.c: Revert.
1692         * dtrace-probe.c: Revert.
1693         * disasm.h: Revert.
1694         * disasm.c: Revert.
1695         * disasm-selftests.c: Revert.
1696         * dictionary.c: Revert.
1697         * dicos-tdep.c: Revert.
1698         * demangle.c: Revert.
1699         * dcache.h: Revert.
1700         * dcache.c: Revert.
1701         * darwin-nat.h: Revert.
1702         * darwin-nat.c: Revert.
1703         * darwin-nat-info.c: Revert.
1704         * d-valprint.c: Revert.
1705         * d-namespace.c: Revert.
1706         * d-lang.c: Revert.
1707         * ctf.c: Revert.
1708         * csky-tdep.c: Revert.
1709         * csky-linux-tdep.c: Revert.
1710         * cris-tdep.c: Revert.
1711         * cris-linux-tdep.c: Revert.
1712         * cp-valprint.c: Revert.
1713         * cp-support.c: Revert.
1714         * cp-namespace.c: Revert.
1715         * cp-abi.c: Revert.
1716         * corelow.c: Revert.
1717         * corefile.c: Revert.
1718         * continuations.c: Revert.
1719         * completer.h: Revert.
1720         * completer.c: Revert.
1721         * complaints.c: Revert.
1722         * coffread.c: Revert.
1723         * coff-pe-read.c: Revert.
1724         * cli-out.h: Revert.
1725         * cli-out.c: Revert.
1726         * charset.c: Revert.
1727         * c-varobj.c: Revert.
1728         * c-valprint.c: Revert.
1729         * c-typeprint.c: Revert.
1730         * c-lang.c: Revert.
1731         * buildsym.c: Revert.
1732         * buildsym-legacy.c: Revert.
1733         * build-id.h: Revert.
1734         * build-id.c: Revert.
1735         * btrace.c: Revert.
1736         * bsd-uthread.c: Revert.
1737         * breakpoint.h: Revert.
1738         * breakpoint.c: Revert.
1739         * break-catch-throw.c: Revert.
1740         * break-catch-syscall.c: Revert.
1741         * break-catch-sig.c: Revert.
1742         * blockframe.c: Revert.
1743         * block.c: Revert.
1744         * bfin-tdep.c: Revert.
1745         * bfin-linux-tdep.c: Revert.
1746         * bfd-target.c: Revert.
1747         * bcache.c: Revert.
1748         * ax-general.c: Revert.
1749         * ax-gdb.h: Revert.
1750         * ax-gdb.c: Revert.
1751         * avr-tdep.c: Revert.
1752         * auxv.c: Revert.
1753         * auto-load.c: Revert.
1754         * arm-wince-tdep.c: Revert.
1755         * arm-tdep.c: Revert.
1756         * arm-symbian-tdep.c: Revert.
1757         * arm-pikeos-tdep.c: Revert.
1758         * arm-obsd-tdep.c: Revert.
1759         * arm-nbsd-tdep.c: Revert.
1760         * arm-nbsd-nat.c: Revert.
1761         * arm-linux-tdep.c: Revert.
1762         * arm-linux-nat.c: Revert.
1763         * arm-fbsd-tdep.c: Revert.
1764         * arm-fbsd-nat.c: Revert.
1765         * arm-bsd-tdep.c: Revert.
1766         * arch-utils.c: Revert.
1767         * arc-tdep.c: Revert.
1768         * arc-newlib-tdep.c: Revert.
1769         * annotate.h: Revert.
1770         * annotate.c: Revert.
1771         * amd64-windows-tdep.c: Revert.
1772         * amd64-windows-nat.c: Revert.
1773         * amd64-tdep.c: Revert.
1774         * amd64-sol2-tdep.c: Revert.
1775         * amd64-obsd-tdep.c: Revert.
1776         * amd64-obsd-nat.c: Revert.
1777         * amd64-nbsd-tdep.c: Revert.
1778         * amd64-nbsd-nat.c: Revert.
1779         * amd64-nat.c: Revert.
1780         * amd64-linux-tdep.c: Revert.
1781         * amd64-linux-nat.c: Revert.
1782         * amd64-fbsd-tdep.c: Revert.
1783         * amd64-fbsd-nat.c: Revert.
1784         * amd64-dicos-tdep.c: Revert.
1785         * amd64-darwin-tdep.c: Revert.
1786         * amd64-bsd-nat.c: Revert.
1787         * alpha-tdep.c: Revert.
1788         * alpha-obsd-tdep.c: Revert.
1789         * alpha-nbsd-tdep.c: Revert.
1790         * alpha-mdebug-tdep.c: Revert.
1791         * alpha-linux-tdep.c: Revert.
1792         * alpha-linux-nat.c: Revert.
1793         * alpha-bsd-tdep.c: Revert.
1794         * alpha-bsd-nat.c: Revert.
1795         * aix-thread.c: Revert.
1796         * agent.c: Revert.
1797         * addrmap.c: Revert.
1798         * ada-varobj.c: Revert.
1799         * ada-valprint.c: Revert.
1800         * ada-typeprint.c: Revert.
1801         * ada-tasks.c: Revert.
1802         * ada-lang.c: Revert.
1803         * aarch64-tdep.c: Revert.
1804         * aarch64-ravenscar-thread.c: Revert.
1805         * aarch64-newlib-tdep.c: Revert.
1806         * aarch64-linux-tdep.c: Revert.
1807         * aarch64-linux-nat.c: Revert.
1808         * aarch64-fbsd-tdep.c: Revert.
1809         * aarch64-fbsd-nat.c: Revert.
1810         * aarch32-linux-nat.c: Revert.
1811
1812 2019-04-05  Tom Tromey  <tom@tromey.com>
1813
1814         * ft32-tdep.c: Sort headers.
1815         * frv-tdep.c: Sort headers.
1816         * frv-linux-tdep.c: Sort headers.
1817         * frame.c: Sort headers.
1818         * frame-unwind.c: Sort headers.
1819         * frame-base.c: Sort headers.
1820         * fork-child.c: Sort headers.
1821         * findvar.c: Sort headers.
1822         * findcmd.c: Sort headers.
1823         * filesystem.c: Sort headers.
1824         * filename-seen-cache.h: Sort headers.
1825         * filename-seen-cache.c: Sort headers.
1826         * fbsd-tdep.c: Sort headers.
1827         * fbsd-nat.h: Sort headers.
1828         * fbsd-nat.c: Sort headers.
1829         * f-valprint.c: Sort headers.
1830         * f-typeprint.c: Sort headers.
1831         * f-lang.c: Sort headers.
1832         * extension.h: Sort headers.
1833         * extension.c: Sort headers.
1834         * extension-priv.h: Sort headers.
1835         * expprint.c: Sort headers.
1836         * exec.h: Sort headers.
1837         * exec.c: Sort headers.
1838         * exceptions.c: Sort headers.
1839         * event-top.c: Sort headers.
1840         * event-loop.c: Sort headers.
1841         * eval.c: Sort headers.
1842         * elfread.c: Sort headers.
1843         * dwarf2read.h: Sort headers.
1844         * dwarf2read.c: Sort headers.
1845         * dwarf2loc.c: Sort headers.
1846         * dwarf2expr.h: Sort headers.
1847         * dwarf2expr.c: Sort headers.
1848         * dwarf2-frame.c: Sort headers.
1849         * dwarf2-frame-tailcall.c: Sort headers.
1850         * dwarf-index-write.h: Sort headers.
1851         * dwarf-index-write.c: Sort headers.
1852         * dwarf-index-common.c: Sort headers.
1853         * dwarf-index-cache.h: Sort headers.
1854         * dwarf-index-cache.c: Sort headers.
1855         * dummy-frame.c: Sort headers.
1856         * dtrace-probe.c: Sort headers.
1857         * disasm.h: Sort headers.
1858         * disasm.c: Sort headers.
1859         * disasm-selftests.c: Sort headers.
1860         * dictionary.c: Sort headers.
1861         * dicos-tdep.c: Sort headers.
1862         * demangle.c: Sort headers.
1863         * dcache.h: Sort headers.
1864         * dcache.c: Sort headers.
1865         * darwin-nat.h: Sort headers.
1866         * darwin-nat.c: Sort headers.
1867         * darwin-nat-info.c: Sort headers.
1868         * d-valprint.c: Sort headers.
1869         * d-namespace.c: Sort headers.
1870         * d-lang.c: Sort headers.
1871         * ctf.c: Sort headers.
1872         * csky-tdep.c: Sort headers.
1873         * csky-linux-tdep.c: Sort headers.
1874         * cris-tdep.c: Sort headers.
1875         * cris-linux-tdep.c: Sort headers.
1876         * cp-valprint.c: Sort headers.
1877         * cp-support.c: Sort headers.
1878         * cp-namespace.c: Sort headers.
1879         * cp-abi.c: Sort headers.
1880         * corelow.c: Sort headers.
1881         * corefile.c: Sort headers.
1882         * continuations.c: Sort headers.
1883         * completer.h: Sort headers.
1884         * completer.c: Sort headers.
1885         * complaints.c: Sort headers.
1886         * coffread.c: Sort headers.
1887         * coff-pe-read.c: Sort headers.
1888         * cli-out.h: Sort headers.
1889         * cli-out.c: Sort headers.
1890         * charset.c: Sort headers.
1891         * c-varobj.c: Sort headers.
1892         * c-valprint.c: Sort headers.
1893         * c-typeprint.c: Sort headers.
1894         * c-lang.c: Sort headers.
1895         * buildsym.c: Sort headers.
1896         * buildsym-legacy.c: Sort headers.
1897         * build-id.h: Sort headers.
1898         * build-id.c: Sort headers.
1899         * btrace.c: Sort headers.
1900         * bsd-uthread.c: Sort headers.
1901         * breakpoint.h: Sort headers.
1902         * breakpoint.c: Sort headers.
1903         * break-catch-throw.c: Sort headers.
1904         * break-catch-syscall.c: Sort headers.
1905         * break-catch-sig.c: Sort headers.
1906         * blockframe.c: Sort headers.
1907         * block.c: Sort headers.
1908         * bfin-tdep.c: Sort headers.
1909         * bfin-linux-tdep.c: Sort headers.
1910         * bfd-target.c: Sort headers.
1911         * bcache.c: Sort headers.
1912         * ax-general.c: Sort headers.
1913         * ax-gdb.h: Sort headers.
1914         * ax-gdb.c: Sort headers.
1915         * avr-tdep.c: Sort headers.
1916         * auxv.c: Sort headers.
1917         * auto-load.c: Sort headers.
1918         * arm-wince-tdep.c: Sort headers.
1919         * arm-tdep.c: Sort headers.
1920         * arm-symbian-tdep.c: Sort headers.
1921         * arm-pikeos-tdep.c: Sort headers.
1922         * arm-obsd-tdep.c: Sort headers.
1923         * arm-nbsd-tdep.c: Sort headers.
1924         * arm-nbsd-nat.c: Sort headers.
1925         * arm-linux-tdep.c: Sort headers.
1926         * arm-linux-nat.c: Sort headers.
1927         * arm-fbsd-tdep.c: Sort headers.
1928         * arm-fbsd-nat.c: Sort headers.
1929         * arm-bsd-tdep.c: Sort headers.
1930         * arch-utils.c: Sort headers.
1931         * arc-tdep.c: Sort headers.
1932         * arc-newlib-tdep.c: Sort headers.
1933         * annotate.h: Sort headers.
1934         * annotate.c: Sort headers.
1935         * amd64-windows-tdep.c: Sort headers.
1936         * amd64-windows-nat.c: Sort headers.
1937         * amd64-tdep.c: Sort headers.
1938         * amd64-sol2-tdep.c: Sort headers.
1939         * amd64-obsd-tdep.c: Sort headers.
1940         * amd64-obsd-nat.c: Sort headers.
1941         * amd64-nbsd-tdep.c: Sort headers.
1942         * amd64-nbsd-nat.c: Sort headers.
1943         * amd64-nat.c: Sort headers.
1944         * amd64-linux-tdep.c: Sort headers.
1945         * amd64-linux-nat.c: Sort headers.
1946         * amd64-fbsd-tdep.c: Sort headers.
1947         * amd64-fbsd-nat.c: Sort headers.
1948         * amd64-dicos-tdep.c: Sort headers.
1949         * amd64-darwin-tdep.c: Sort headers.
1950         * amd64-bsd-nat.c: Sort headers.
1951         * alpha-tdep.c: Sort headers.
1952         * alpha-obsd-tdep.c: Sort headers.
1953         * alpha-nbsd-tdep.c: Sort headers.
1954         * alpha-mdebug-tdep.c: Sort headers.
1955         * alpha-linux-tdep.c: Sort headers.
1956         * alpha-linux-nat.c: Sort headers.
1957         * alpha-bsd-tdep.c: Sort headers.
1958         * alpha-bsd-nat.c: Sort headers.
1959         * aix-thread.c: Sort headers.
1960         * agent.c: Sort headers.
1961         * addrmap.c: Sort headers.
1962         * ada-varobj.c: Sort headers.
1963         * ada-valprint.c: Sort headers.
1964         * ada-typeprint.c: Sort headers.
1965         * ada-tasks.c: Sort headers.
1966         * ada-lang.c: Sort headers.
1967         * aarch64-tdep.c: Sort headers.
1968         * aarch64-ravenscar-thread.c: Sort headers.
1969         * aarch64-newlib-tdep.c: Sort headers.
1970         * aarch64-linux-tdep.c: Sort headers.
1971         * aarch64-linux-nat.c: Sort headers.
1972         * aarch64-fbsd-tdep.c: Sort headers.
1973         * aarch64-fbsd-nat.c: Sort headers.
1974         * aarch32-linux-nat.c: Sort headers.
1975
1976 2019-04-04  Tom Tromey  <tom@tromey.com>
1977
1978         * varobj.c (varobj_create): Update.
1979         * rust-exp.y (struct rust_parser) <update_innermost_block,
1980         lookup_symbol>: New methods.
1981         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1982         Rename.
1983         (rust_parser::rust_lookup_type)
1984         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1985         * printcmd.c (display_command, do_one_display): Update.
1986         * parser-defs.h (struct parser_state) <parser_state>: Add
1987         "tracker" parameter.
1988         (block_tracker): New member.
1989         (class innermost_block_tracker) <innermost_block_tracker>: Add
1990         "types" parameter.
1991         <reset>: Remove method.
1992         (innermost_block): Don't declare.
1993         (null_post_parser): Update.
1994         * parse.c (innermost_block): Remove global.
1995         (write_dollar_variable): Update.
1996         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1997         Remove "tracker_types" parameter.
1998         (parse_expression): Add "tracker" parameter.
1999         (parse_expression_for_completion): Update.
2000         (null_post_parser): Add "tracker" parameter.
2001         * p-exp.y: Update rules.
2002         * m2-exp.y: Update rules.
2003         * language.h (struct language_defn) <la_post_parser>: Add
2004         "tracker" parameter.
2005         * go-exp.y: Update rules.
2006         * f-exp.y: Update rules.
2007         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2008         parameter.
2009         * d-exp.y: Update rules.
2010         * c-exp.y: Update rules.
2011         * breakpoint.c (set_breakpoint_condition): Create an
2012         innermost_block_tracker.
2013         (watch_command_1): Likewise.
2014         * ada-lang.c (resolve): Add "tracker" parameter.
2015         (resolve_subexp): Likewise.
2016         * ada-exp.y (write_var_from_sym): Update.
2017
2018 2019-04-04  Tom Tromey  <tom@tromey.com>
2019
2020         * type-stack.h: New file.
2021         * type-stack.c: New file.
2022         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2023         type-stack.h.
2024         (insert_into_type_stack, insert_type, push_type, push_type_int)
2025         (insert_type_address_space, pop_type, pop_type_int)
2026         (pop_typelist, pop_type_stack, append_type_stack)
2027         (push_type_stack, get_type_stack, push_typelist)
2028         (follow_type_instance_flags, follow_types): Don't declare.
2029         * parse.c (type_stack): Remove global.
2030         (parse_exp_in_context): Update.
2031         (insert_into_type_stack, insert_type, push_type, push_type_int)
2032         (insert_type_address_space, pop_type, pop_type_int)
2033         (pop_typelist, pop_type_stack, append_type_stack)
2034         (push_type_stack, get_type_stack, push_typelist)
2035         (follow_type_instance_flags, follow_types): Remove (moved to
2036         type-stack.c).
2037         * f-exp.y (type_stack): New global.
2038         Update rules.
2039         (push_kind_type, f_parse): Update.
2040         * d-exp.y (type_stack): New global.
2041         Update rules.
2042         (d_parse): Update.
2043         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2044         Update rules.
2045         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2046         (HFILES_NO_SRCDIR): Add type-stack.h.
2047
2048 2019-04-04  Tom Tromey  <tom@tromey.com>
2049
2050         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2051         (rust_parser::convert_ast_to_expression, rust_parse)
2052         (rust_lex_test_completion, rust_lex_tests): Update.
2053         * parser-defs.h (struct expr_completion_state): New.
2054         (struct parser_state) <parser_state>: Add completion parameter.
2055         <mark_struct_expression, mark_completion_tag>: New methods.
2056         <parse_completion, m_completion_state>: New members.
2057         (prefixify_expression, null_post_parser): Update.
2058         (mark_struct_expression, mark_completion_tag): Don't declare.
2059         * parse.c (parse_completion, expout_last_struct)
2060         (expout_tag_completion_type, expout_completion_name): Remove
2061         globals.
2062         (parser_state::mark_struct_expression)
2063         (parser_state::mark_completion_tag): Now methods.
2064         (prefixify_expression): Add last_struct parameter.
2065         (prefixify_subexp): Likewise.
2066         (parse_exp_1): Update.
2067         (parse_exp_in_context): Add cstate parameter.  Update.
2068         (parse_expression_for_completion): Create an
2069         expr_completion_state.
2070         (null_post_parser): Add "completion" parameter.
2071         * p-exp.y: Update rules.
2072         (yylex): Update.
2073         * language.h (struct language_defn) <la_post_parser>: Add
2074         "completing" parameter.
2075         * go-exp.y: Update rules.
2076         (lex_one_token): Update.
2077         * expression.h (parse_completion): Don't declare.
2078         * d-exp.y: Update rules.
2079         (lex_one_token): Update rules.
2080         * c-exp.y: Update rules.
2081         (lex_one_token): Update.
2082         * ada-lang.c (resolve): Add "parse_completion" parameter.
2083         (resolve_subexp): Likewise.
2084         (ada_resolve_function): Likewise.
2085
2086 2019-04-04  Tom Tromey  <tom@tromey.com>
2087
2088         * parser-defs.h (struct parser_state) <start_arglist,
2089         end_arglist>: New methods.
2090         <arglist_len, m_funcall_chain>: New members.
2091         (arglist_len, start_arglist, end_arglist): Don't declare.
2092         * parse.c (arglist_len, funcall_chain): Remove global.
2093         (start_arglist, end_arglist): Remove functions.
2094         (parse_exp_in_context): Update.
2095         * p-exp.y: Update rules.
2096         * m2-exp.y: Update rules.
2097         * go-exp.y: Update rules.
2098         * f-exp.y: Update rules.
2099         * d-exp.y: Update rules.
2100         * c-exp.y: Update rules.
2101
2102 2019-04-04  Tom Tromey  <tom@tromey.com>
2103
2104         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2105         lex_operator, push_back>: New methods.
2106         Update all rules.
2107         (rust_parser::lex_hex, lex_escape): Rename and update.
2108         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2109         (rust_parser::lex_operator): Rename and update.
2110         (rust_parser::lex_number, rustyylex, rustyyerror)
2111         (rust_lex_test_init, rust_lex_test_sequence)
2112         (rust_lex_test_push_back, rust_lex_tests): Update.
2113         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2114         parameter.
2115         <lexptr, prev_lexptr>: New members.
2116         (lexptr, prev_lexptr): Don't declare.
2117         * parse.c (lexptr, prev_lexptr): Remove globals.
2118         (parse_exp_in_context): Update.
2119         * p-exp.y (yylex, yyerror): Update.
2120         * m2-exp.y (parse_number, yylex, yyerror): Update.
2121         * go-exp.y (lex_one_token, yyerror): Update.
2122         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2123         * d-exp.y (lex_one_token, yyerror): Update.
2124         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2125         (lex_one_token, yyerror): Update.
2126         * ada-lex.l (YY_INPUT): Update.
2127         (rewind_to_char): Update.
2128         * ada-exp.y (yyerror): Update.
2129
2130 2019-04-04  Tom Tromey  <tom@tromey.com>
2131
2132         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2133         * parser-defs.h (struct parser_state) <parser_state>: Add new
2134         parameter.
2135         <comma_terminates>: New member.
2136         (comma_terminates): Don't declare global.
2137         * parse.c (comma_terminates): Remove global.
2138         (parse_exp_in_context): Update.
2139         * p-exp.y (yylex): Update.
2140         * m2-exp.y (yylex): Update.
2141         * go-exp.y (lex_one_token): Update.
2142         * f-exp.y (yylex): Update.
2143         * d-exp.y (lex_one_token): Update.
2144         * c-exp.y (lex_one_token): Update.
2145         * ada-lex.l: Update.
2146
2147 2019-04-04  Tom Tromey  <tom@tromey.com>
2148
2149         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2150         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2151         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2152         * parser-defs.h (paren_depth): Don't declare.
2153         * parse.c (paren_depth): Remove global.
2154         (parse_exp_in_context): Update.
2155         * p-exp.y (paren_depth): New global.
2156         (pascal_parse): Initialize it.
2157         * m2-exp.y (paren_depth): New global.
2158         (m2_parse): Initialize it.
2159         * go-exp.y (paren_depth): New global.
2160         (go_parse): Initialize it.
2161         * f-exp.y (paren_depth): New global.
2162         (f_parse): Initialize it.
2163         * d-exp.y (paren_depth): New global.
2164         (d_parse): Initialize it.
2165         * c-exp.y (paren_depth): New global.
2166         (c_parse): Initialize it.
2167         * ada-lex.l (paren_depth): New global.
2168         (lexer_init): Initialize it.
2169
2170 2019-04-04  Tom Tromey  <tom@tromey.com>
2171
2172         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2173         (rust_parser::convert_ast_to_type)
2174         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2175         * parser-defs.h (struct parser_state) <parser_state>: Add
2176         parameters.  Initialize new members.
2177         <expression_context_block, expression_context_pc>: New members.
2178         * parse.c (expression_context_block, expression_context_pc):
2179         Remove globals.
2180         (parse_exp_in_context): Update.
2181         * p-exp.y: Update all rules.
2182         (yylex): Update.
2183         * m2-exp.y: Update all rules.
2184         (yylex): Update.
2185         * go-exp.y (yylex): Update.
2186         * f-exp.y (yylex): Update.
2187         * d-exp.y: Update all rules.
2188         (yylex): Update.
2189         * c-exp.y: Update all rules.
2190         (lex_one_token, classify_name, yylex, c_parse): Update.
2191         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2192
2193 2019-04-04  Tom Tromey  <tom@tromey.com>
2194
2195         * gdbarch.h, gdbarch.c: Rebuild.
2196         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2197         * stap-probe.h:
2198         (struct stap_parse_info): Replace "parser_state" with
2199         "expr_builder".
2200         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2201         (parser_state): New class.
2202         * parse.c (expr_builder): Rename.
2203         (expr_builder::release): Rename.
2204         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2205         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2206         (write_exp_elt_longcst, write_exp_elt_floatcst)
2207         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2208         (write_exp_string_vector, write_exp_bitstring)
2209         (write_exp_msymbol, mark_struct_expression)
2210         (write_dollar_variable)
2211         (insert_type_address_space, increase_expout_size): Replace
2212         "parser_state" with "expr_builder".
2213         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2214         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2215         "parser_state" with "expr_builder".
2216
2217 2019-04-04  Tom Tromey  <tom@tromey.com>
2218
2219         * rust-exp.y: Replace "parse_language" with method call.
2220         * p-exp.y:
2221         (yylex): Replace "parse_language" with method call.
2222         * m2-exp.y:
2223         (yylex): Replace "parse_language" with method call.
2224         * go-exp.y (classify_name): Replace "parse_language" with method
2225         call.
2226         * f-exp.y (yylex): Replace "parse_language" with method call.
2227         * d-exp.y (lex_one_token): Replace "parse_language" with method
2228         call.
2229         * c-exp.y:
2230         (lex_one_token, classify_name, yylex): Replace "parse_language"
2231         with method call.
2232         * ada-exp.y (find_primitive_type, type_char)
2233         (type_system_address): Replace "parse_language" with method call.
2234
2235 2019-04-04  Tom Tromey  <tom@tromey.com>
2236
2237         * rust-exp.y: Replace "parse_gdbarch" with method call.
2238         * parse.c (write_dollar_variable, insert_type_address_space):
2239         Replace "parse_gdbarch" with method call.
2240         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2241         call.
2242         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2243         call.
2244         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2245         "parse_gdbarch" with method call.
2246         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2247         with method call.
2248         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2249         "parse_gdbarch" with method call.
2250         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2251         "parse_gdbarch" with method call.
2252         * c-exp.y (parse_type, parse_number, classify_name): Replace
2253         "parse_gdbarch" with method call.
2254         * ada-lex.l: Replace "parse_gdbarch" with method call.
2255         * ada-exp.y (parse_type, find_primitive_type, type_char)
2256         (type_system_address): Replace "parse_gdbarch" with method call.
2257
2258 2019-04-04  Tom Tromey  <tom@tromey.com>
2259
2260         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2261         * stap-probe.c (stap_parse_argument): Update.
2262         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2263         initial_size parameter.
2264         * rust-exp.y (rust_lex_tests): Update.
2265         * parse.c (parser_state): Update.
2266         (parse_exp_in_context): Update.
2267         * parser-defs.h (struct parser_state) <parser_state>: Remove
2268         "initial_size" parameter.
2269
2270 2019-04-04  Tom Tromey  <tom@tromey.com>
2271
2272         * parser-defs.h (increase_expout_size): Don't declare.
2273         * parse.c (increase_expout_size): Now static.
2274
2275 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2276
2277         * gnu-nat.c (gnu_nat_target::wait): Fix
2278         target_waitstatus_to_string call.
2279
2280 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * eval.c (evaluate_subexp_standard): Handle internal functions
2283         during Fortran function call handling.
2284
2285 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * NEWS: Mention new internal functions.
2288         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2289         (read_base_type): Use dwarf2_init_complex_target_type.
2290         * value.c (creal_internal_fn): New function.
2291         (cimag_internal_fn): New function.
2292         (_initialize_values): Register new internal functions.
2293
2294 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2295
2296         * infrun.c (stop_all_threads): If debug_infrun, always
2297         trace the wait status after wait_one, using
2298         target_waitstatus_to_string and target_pid_to_str.
2299         (handle_inferior_event): Replace various trace of
2300         wait status kind by a single trace.
2301         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2302         wait status kind image by target_waitstatus_to_string.
2303         * target/waitstatus.c (target_waitstatus_to_string): Fix
2304         obsolete comment.
2305
2306 2019-04-01  Tom Tromey  <tromey@adacore.com>
2307
2308         PR symtab/23331:
2309         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2310
2311 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2312             Pedro Alves  <palves@redhat.com>
2313
2314         * top.c (quit_force): Call 'finalize_values'.
2315         * value.c (finalize_values): New function.
2316         * value.h (finalize_values): Declare.
2317
2318 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2319
2320         * NEWS: Announce $_gdb_major and $_gdb_minor.
2321
2322         * top.c (init_gdb_version_vars): New function.
2323         (gdb_init): Call init_gdb_version_vars.
2324
2325 2019-03-29  Tom Tromey  <tromey@adacore.com>
2326
2327         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2328         help text.  Remove dead code.
2329
2330 2019-03-29  Keith Seitz  <keiths@redhat.com>
2331
2332         From Siddhesh Poyarekar:
2333         * f-lang.h (f77_get_upperbound): Return LONGEST.
2334         (f77_get_lowerbound): Likewise.
2335         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2336         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2337         print them.
2338         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2339         plongest to format print it.
2340         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2341         (f77_get_upperbound): Likewise.
2342         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2343         LOWER_BOUND to LONGEST.
2344         (f77_create_arrayprint_offset_tbl): Likewise.
2345
2346 2019-03-29  Keith Seitz  <keiths@redhat.com>
2347
2348         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2349         %s/pulongest for TYPE_LENGTH instead of %d in format
2350         strings.
2351         * ada-typerint.c (ada_print_type): Likewise.
2352         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2353         * compile/compile-c-support.c (generate_register_struct): Likewise.
2354         * gdbtypes.c (recursive_dump_type): Likewise.
2355         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2356         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2357         instead of %d in format strings.
2358         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2359         to std::min to ULONGEST.
2360         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2361         instead of %d in format strings.
2362         * tracepoint.c (info_scope_command): Likewise.
2363         * typeprint.c (print_offset_data::update)
2364         (print_offset_data::finish): Likewise.
2365         * xtensa-tdep.c (xtensa_store_return_value)
2366         (xtensa_push_dummy_call): Likewise.
2367
2368 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2369
2370         * windows-nat.c (display_selector): Fixed format specifications
2371         for 64-bit Cygwin.
2372
2373 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2374
2375         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2376
2377 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2378
2379         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2380         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2381         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2382         (nios2_linux_init_abi): Install it.
2383
2384 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2385
2386         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2387
2388 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2389
2390         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2391
2392 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2393             Tom Tromey  <tromey@adacore.com>
2394
2395         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2396
2397 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2398
2399         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2400         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2401         method to compute the bounds of range types. Also print "[evaluated]"
2402         if the bounds' values come from a dynamic evaluation.
2403
2404 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2405
2406         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2407         whitespace when pretty printing is on.
2408
2409 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2410
2411         * ppc-linux-nat.c: Add include.
2412
2413 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2414
2415         * NEWS: Mention AArch64 Pointer Authentication.
2416
2417 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2418
2419         * arm-linux-nat.c: Add include.
2420
2421 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2422
2423         * source-cache.c (source_cache::get_source_lines): Re-read
2424         fullname after calling open_source_file.
2425
2426 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2427
2428         * NEWS: Mention TLS support for FreeBSD.
2429
2430 2019-03-25  Tom Tromey  <tromey@adacore.com>
2431
2432         * minsyms.c (BUNCH_SIZE): Update comment.
2433         (~minimal_symbol_reader): Remove old comment.
2434         (compact_minimal_symbols): Update comment.
2435         (minimal_symbol_reader::install): Remove old comment.  Update
2436         other comments.
2437
2438 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2439
2440         * s390-linux-nat.c: Add include.
2441
2442 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2443
2444         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2445         Call linux_get_hwcap.
2446         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2447         Likewise.
2448         (aarch64_linux_get_hwcap): Remove function.
2449         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2450         declaration.
2451         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2452         linux_get_hwcap.
2453         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2454         * linux-tdep.c (linux_get_hwcap): Add function.
2455         (linux_get_hwcap2): Likewise.
2456         * linux-tdep.h (linux_get_hwcap): Add declaration.
2457         (linux_get_hwcap2): Likewise.
2458         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2459         (ppc_linux_get_hwcap2): Likewise.
2460         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2461         linux_get_hwcap.
2462         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2463         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2464         (ppc_linux_nat_target::read_description): Likewise.
2465         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2466         * s390-linux-nat.c: Likewise.
2467         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2468
2469 2019-03-24  Tom Tromey  <tom@tromey.com>
2470
2471         * ada-lang.c (standard_lookup): Simplify initialization.
2472         (ada_lookup_symbol_nonlocal): Simplify return.
2473         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2474         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2475         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2476         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2477         initialization.
2478         * solib.c (solib_global_lookup): Simplify.
2479         * symtab.c (null_block_symbol): Remove.
2480         (symbol_cache_lookup): Simplify returns.
2481         (lookup_language_this): Simplify returns.
2482         (lookup_symbol_aux): Simplify return.
2483         (lookup_local_symbol): Simplify returns.
2484         (lookup_global_symbol_from_objfile): Simplify return.
2485         (lookup_symbol_in_objfile_symtabs)
2486         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2487         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2488         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2489         * cp-namespace.c (cp_lookup_bare_symbol)
2490         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2491         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2492         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2493         (cp_lookup_symbol_via_imports): Simplify initialization.
2494         (find_symbol_in_baseclass): Likewise.
2495         * symtab.h (null_block_symbol): Remove.
2496         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2497         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2498         (d_lookup_symbol_module): Likewise.
2499         (find_symbol_in_baseclass): Simplify initialization.
2500
2501 2019-03-24  Tom Tromey  <tom@tromey.com>
2502
2503         * expression.h: Don't include symtab.h.
2504         (struct block): Forward declare.
2505
2506 2019-03-24  Tom Tromey  <tom@tromey.com>
2507
2508         * c-exp.y (typebase): Remove casts.
2509         * gdbtypes.c (lookup_unsigned_typename, )
2510         (lookup_signed_typename): Remove cast.
2511         * eval.c (parse_to_comma_and_eval): Remove cast.
2512         * parse.c (write_dollar_variable): Remove cast.
2513         * block.h (struct block) <superblock>: Now const.
2514         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2515         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2516         (map_block): Make "block" const.
2517         * symfile.h (struct quick_symbol_functions)
2518         <map_matching_symbols>: Constify block argument to "callback".
2519         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2520         const.
2521         (find_pc_sect_compunit_symtab): Make "b" const.
2522         (find_symbol_at_address): Likewise.
2523         (search_symbols): Likewise.
2524         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2525         (dw2_debug_names_lookup_symbol): Likewise.
2526         (dw2_map_matching_symbols): Update.
2527         * p-valprint.c (pascal_val_print): Remove "block".
2528         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2529         (aux_add_nonlocal_symbols): Make "block" const.
2530         (resolve_subexp): Remove cast.
2531         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2532         const.
2533         (iterate_over_file_blocks): Likewise.
2534         * f-exp.y (%union) <bval>: Remove.
2535         * coffread.c (patch_opaque_types): Make "b" const.
2536         * spu-tdep.c (spu_catch_start): Make "block" const.
2537         * c-valprint.c (print_unpacked_pointer): Remove "block".
2538         * symmisc.c (dump_symtab_1): Make "b" const.
2539         (block_depth): Make "block" const.
2540         * d-exp.y (%union) <bval>: Remove.
2541         * cp-support.h (cp_lookup_rtti_type): Update.
2542         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2543         * psymtab.c (psym_lookup_symbol): Make "block" const.
2544         (maintenance_check_psymtabs): Make "b" const.
2545         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2546         (enumerate_locals, enumerate_args): Update.
2547         * python/py-symtab.c (stpy_global_block): Make "block" const.
2548         (stpy_static_block): Likewise.
2549         * inline-frame.c (block_starting_point_at): Make "new_block"
2550         const.
2551         * block.c (find_block_in_blockvector): Make return type const.
2552         (blockvector_for_pc_sect): Make "b" const.
2553         (find_block_in_blockvector): Make "b" const.
2554
2555 2019-03-23  Tom Tromey  <tom@tromey.com>
2556
2557         * varobj.c (varobj_create): Update.
2558         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2559         * printcmd.c (display_command, do_one_display): Don't reset
2560         innermost_block.
2561         * parser-defs.h (enum innermost_block_tracker_type): Move to
2562         expression.h.
2563         (innermost_block): Update comment.
2564         * parse.c (parse_exp_1): Add tracker_types parameter.
2565         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2566         tracker_types parameter.  Reset innermost_block.
2567         (parse_exp_in_context): Remove.
2568         (parse_expression_for_completion): Update.
2569         * objfiles.c (~objfile): Don't reset expression_context_block or
2570         innermost_block.
2571         * expression.h (enum innermost_block_tracker_type): Move from
2572         parser-defs.h.
2573         (parse_exp_1): Add tracker_types parameter.
2574         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2575         reset innermost_block.
2576
2577 2019-03-23  Tom Tromey  <tom@tromey.com>
2578
2579         * objfiles.h: Include bcache.h.
2580
2581 2019-03-23  Tom Tromey  <tom@tromey.com>
2582
2583         * linespec.c (get_current_search_block): Use
2584         scoped_restore_current_language.
2585         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2586
2587 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2588             Jiong Wang  <jiong.wang@arm.com>
2589
2590         * aarch64-linux-tdep.c
2591         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2592         section.
2593         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2594
2595 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2596             Jiong Wang  <jiong.wang@arm.com>
2597
2598         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2599         instructions.
2600         (aarch64_analyze_prologue_test): Add PACIASP test.
2601         (aarch64_prologue_prev_register): Unmask PC value.
2602
2603 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2604             Jiong Wang  <jiong.wang@arm.com>
2605
2606         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2607         (aarch64_dwarf2_prev_register): Unmask PC value.
2608         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2609         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2610         DW_CFA_AARCH64_negate_ra_state.
2611         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2612
2613 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2614             Jiong Wang  <jiong.wang@arm.com>
2615
2616         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2617         registers.
2618         (aarch64_pseudo_register_name): Likewise.
2619         (aarch64_pseudo_register_type): Likewise.
2620         (aarch64_pseudo_register_reggroup_p): Likewise.
2621         (aarch64_gdbarch_init): Add pauth registers.
2622         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2623         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2624         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2625         (struct gdbarch_tdep): Add regnum for ra_state.
2626
2627 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2628             Jiong Wang  <jiong.wang@arm.com>
2629
2630         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2631
2632 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2633             Jiong Wang  <jiong.wang@arm.com>
2634
2635         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2636         function.
2637         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2638         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2639         (aarch64_gdbarch_init): Add puth registers.
2640         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2641         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2642         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2643
2644 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2645             Jiong Wang  <jiong.wang@arm.com>
2646
2647         * aarch64-linux-nat.c
2648         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2649         * aarch64-linux-tdep.c
2650         (aarch64_linux_core_read_description): Likewise.
2651         (aarch64_linux_get_hwcap): New function.
2652         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2653         (aarch64_linux_get_hwcap): New declaration.
2654
2655 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2656             Jiong Wang  <jiong.wang@arm.com>
2657
2658         * aarch64-linux-nat.c
2659         (aarch64_linux_nat_target::read_description): Add pauth param.
2660         * aarch64-linux-tdep.c
2661         (aarch64_linux_core_read_description): Likewise.
2662         * aarch64-tdep.c (struct target_desc): Add in pauth.
2663         (aarch64_read_description): Add pauth param.
2664         (aarch64_gdbarch_init): Likewise.
2665         * aarch64-tdep.h (aarch64_read_description): Likewise.
2666         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2667         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2668         * features/Makefile: Add new files.
2669         * features/aarch64-pauth.c: New file.
2670         * features/aarch64-pauth.xml: New file.
2671
2672 2019-03-20  Tom Tromey  <tromey@adacore.com>
2673
2674         * infrun.c (handle_inferior_event): Rename from
2675         handle_inferior_event_1.  Create a scoped_value_mark.
2676         (handle_inferior_event): Remove.
2677
2678 2019-03-19  Tom Tromey  <tromey@adacore.com>
2679
2680         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2681         * infrun.h (print_stop_event): Add "displays" parameter.
2682         * infrun.c (print_stop_event): Add "displays" parameter.
2683
2684 2019-03-19  Pedro Alves  <palves@redhat.com>
2685
2686         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2687         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2688         to -1.  Fix TABs vs spaces.
2689         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2690         * tui/tui-out.h (tui_ui_out) Add intro comments.
2691         <m_line, m_start_of_line>: In-class initialize, and add describing
2692         comment.
2693
2694 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2695
2696         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2697         variable names.
2698         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2699
2700 2019-03-18  Pedro Alves  <palves@redhat.com>
2701             Eli Zaretskii <eliz@gnu.org>
2702
2703         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2704         m_line and m_start_of_line.
2705
2706 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2707
2708         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2709         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2710         it returns a newline.  This fixes a regression in TU mode, whereby
2711         the next line is output on the same screen line as the user input.
2712
2713 2019-03-18  Tom Tromey  <tromey@adacore.com>
2714
2715         * minsyms.c (minimal_symbol_reader::install): Remove call to
2716         obstack_blank.
2717
2718 2019-03-18  Pedro Alves  <palves@redhat.com>
2719
2720         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2721         New globals.
2722         (apply_style): New, factored out from ...
2723         (apply_ansi_escape): ... this.  Handle reverse video mode.
2724         (tui_set_reverse_mode): New function.
2725         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2726         * tui/tui-winsource.c (tui_show_source_line): Use
2727         tui_set_reverse_mode instead of setting A_STANDOUT.
2728         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2729         New setter methods.
2730
2731 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2732
2733         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2734         Handle tabs.
2735
2736 2019-03-18  Tom Tromey  <tromey@adacore.com>
2737
2738         * ada-lang.c (empty_array): Add "high" parameter.
2739         (ada_evaluate_subexp): Update.
2740
2741 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2742
2743         * unittests/string_view-selftests.c: Define
2744         _initialize_string_view_selftests unconditionally.
2745
2746 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2747
2748         PR gdb/24350
2749         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2750
2751 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2752
2753         PR gdb/24351
2754         * windows-nat.c (display_selector): Fix format specifiers.
2755
2756 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2757
2758         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2759         tui_refill_source_window instead of tui_refresh_win, to update the
2760         current execution line.  This fixes redisplay of the current line
2761         when stepping through the code with "next" or "step".
2762
2763 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2764
2765         * source-cache.c (source_cache::get_source_lines): Call
2766         find_source_lines to initialize s->nlines.  This fixes vertical
2767         scrolling of TUI source window when the DOWN arrow is pressed.
2768
2769 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2770
2771         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2772         linux-thread-db.c (_initialize_thread_db): Likewise.
2773
2774 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2775
2776         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2777         wclrtoeol in tui_show_source_line".  This reverts changes made in
2778         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2779
2780 2019-03-15  Tom Tromey  <tom@tromey.com>
2781
2782         * symtab.h (struct minimal_symbol): Derive from
2783         general_symbol_info.
2784         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2785         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2786         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2787         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2788         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2789         (MSYMBOL_SEARCH_NAME): Update.
2790         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2791         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2792         * minsyms.c (minimal_symbol_reader::record_full): Update.
2793
2794 2019-03-15  Tom Tromey  <tom@tromey.com>
2795
2796         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2797
2798 2019-03-15  Tom Tromey  <tom@tromey.com>
2799
2800         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2801         unique_xmalloc_ptr.
2802         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2803         Update.
2804         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2805         (build_minimal_symbol_hash_tables)
2806         (minimal_symbol_reader::install): Update.
2807
2808 2019-03-15  Tom Tromey  <tom@tromey.com>
2809
2810         * symtab.c (create_demangled_names_hash): Update.
2811         (symbol_set_names): Update.
2812         * objfiles.h (struct objfile_per_bfd_storage)
2813         <demangled_names_hash>: Now an htab_up.
2814         * objfiles.c (objfile_per_bfd_storage): Simplify.
2815
2816 2019-03-15  Tom Tromey  <tom@tromey.com>
2817
2818         * objfiles.h (struct objfile_per_bfd_storage): Declare
2819         destructor.
2820         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2821         New.
2822         (get_objfile_bfd_data): Use new.  Don't initialize
2823         language_of_main.
2824         (free_objfile_per_bfd_storage): Remove.
2825         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2826
2827 2019-03-15  Tom Tromey  <tom@tromey.com>
2828
2829         * symfile.c (reread_symbols): Update.
2830         * objfiles.c (objfile::objfile): Update.
2831         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2832         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2833         comment.
2834         (minimal_symbol_reader::install): Update.
2835         (terminate_minimal_symbol_table): Remove.
2836         * jit.c (jit_object_close_impl): Update.
2837
2838 2019-03-15  Tom Tromey  <tom@tromey.com>
2839
2840         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2841         initializations.
2842
2843 2019-03-15  Tom Tromey  <tom@tromey.com>
2844
2845         * objfiles.h (struct objfile_per_bfd_storage)
2846         <demangled_hash_languages>: Now a bitset.
2847         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2848         (lookup_minimal_symbol): Update.
2849
2850 2019-03-15  Tom Tromey  <tom@tromey.com>
2851
2852         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2853         Don't return the symbol.
2854         * coffread.c (record_minimal_symbol): Use record_full.
2855
2856 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2857
2858         The MS-Windows port of ncurses fails to switch to a color pair if
2859         one or both of the colors are the implicit default colors.  This
2860         change records the default colors when TUI is initialized, and
2861         then specifies them explicitly when a color pair uses the default
2862         colors.  This allows color styling in TUI mode on MS-Windows.
2863
2864         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2865         ncurses_norm_attr.
2866         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2867         colors in ncurses_norm_attr.
2868         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2869         "none", replace it with the default color recorded in
2870         ncurses_norm_attr.
2871
2872 2019-03-14  Tom Tromey  <tromey@adacore.com>
2873
2874         * source-cache.h (class source_cache) <get_source_lines>: Return
2875         std::string.
2876         * source-cache.c (source_cache::extract_lines): Handle case where
2877         first_pos==npos.  Return std::string.
2878         (source_cache::get_source_lines): Update.
2879
2880 2019-03-14  Tom Tromey  <tromey@adacore.com>
2881
2882         * NEWS: Add item for "style sources" commands.
2883         * source-cache.c (source_cache::get_source_lines): Check
2884         source_styling.
2885         * cli/cli-style.c (source_styling): New global.
2886         (_initialize_cli_style): Add "style sources" commands.
2887         (show_style_sources): New function.
2888         * cli/cli-style.h (source_styling): Declare.
2889
2890 2019-03-14  Pedro Alves  <palves@redhat.com>
2891             Tom Tromey  <tromey@adacore.com>
2892
2893         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2894         * tui/tui-winsource.c (tui_refill_source_window): New function,
2895         from...
2896         (tui_horizontal_source_scroll): ... here.  Move some logic.
2897         * cli/cli-style.c (set_style_enabled): Notify new observable.
2898         * tui/tui-hooks.c (tui_redisplay_source): New function.
2899         (tui_attach_detach_observers): Attach or detach
2900         tui_redisplay_source.
2901         * observable.h (source_styling_changed): New observable.
2902         * observable.c: Define source_styling_changed observable.
2903
2904 2019-03-13  Tom Tromey  <tromey@adacore.com>
2905
2906         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2907         (i386_gnu_nat_target::store_registers): Update.
2908         * target-debug.h (target_debug_print_std_string): New macro.
2909         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2910         * windows-tdep.c (display_one_tib): Update.
2911         * tui/tui-stack.c (tui_make_status_line): Update.
2912         * top.c (print_inferior_quit_action): Update.
2913         * thread.c (thr_try_catch_cmd): Update.
2914         (add_thread_with_info): Update.
2915         (thread_target_id_str): Update.
2916         (thr_try_catch_cmd): Update.
2917         (thread_command): Update.
2918         (thread_find_command): Update.
2919         * record-btrace.c (record_btrace_target::info_record)
2920         (record_btrace_resume_thread, record_btrace_target::resume)
2921         (record_btrace_cancel_resume, record_btrace_step_thread)
2922         (record_btrace_target::wait, record_btrace_target::wait)
2923         (record_btrace_target::wait, record_btrace_target::stop): Update.
2924         * progspace.c (print_program_space): Update.
2925         * process-stratum-target.c
2926         (process_stratum_target::thread_address_space): Update.
2927         * linux-fork.c (linux_fork_mourn_inferior)
2928         (detach_checkpoint_command, info_checkpoints_command)
2929         (linux_fork_context): Update.
2930         (linux_fork_detach): Update.
2931         (class scoped_switch_fork_info): Update.
2932         (delete_checkpoint_command): Update.
2933         * infrun.c (follow_fork_inferior): Update.
2934         (follow_fork_inferior): Update.
2935         (proceed_after_vfork_done): Update.
2936         (handle_vfork_child_exec_or_exit): Update.
2937         (follow_exec): Update.
2938         (displaced_step_prepare_throw): Update.
2939         (displaced_step_restore): Update.
2940         (start_step_over): Update.
2941         (resume_1): Update.
2942         (clear_proceed_status_thread): Update.
2943         (proceed): Update.
2944         (print_target_wait_results): Update.
2945         (do_target_wait): Update.
2946         (context_switch): Update.
2947         (stop_all_threads): Update.
2948         (restart_threads): Update.
2949         (finish_step_over): Update.
2950         (handle_signal_stop): Update.
2951         (switch_back_to_stepped_thread): Update.
2952         (keep_going_pass_signal): Update.
2953         (print_exited_reason): Update.
2954         (normal_stop): Update.
2955         * inferior.c (inferior_pid_to_str): Change return type.
2956         (print_selected_inferior): Update.
2957         (add_inferior): Update.
2958         (detach_inferior): Update.
2959         * dummy-frame.c (fprint_dummy_frames): Update.
2960         * dcache.c (dcache_info_1): Update.
2961         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2962         (btrace_fetch, btrace_clear): Update.
2963         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2964         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2965         type.
2966         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2967         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2968         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2969         * gdbarch.c, gdbarch.h: Rebuild.
2970         * gdbarch.sh (core_pid_to_str): Change return type.
2971         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2972         return type.
2973         (windows_nat_target::pid_to_str): Change return type.
2974         (windows_delete_thread): Update.
2975         (windows_nat_target::attach): Update.
2976         (windows_nat_target::files_info): Update.
2977         * target-delegates.c: Rebuild.
2978         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2979         return type.
2980         (sol_thread_target::pid_to_str): Change return type.
2981         * remote.c (class remote_target) <pid_to_str>: Change return
2982         type.
2983         (remote_target::pid_to_str): Change return type.
2984         (extended_remote_target::attach, remote_target::remote_stop_ns)
2985         (remote_target::remote_notif_remove_queued_reply)
2986         (remote_target::push_stop_reply, remote_target::disable_btrace):
2987         Update.
2988         (extended_remote_target::attach): Update.
2989         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2990         type.
2991         (gdbsim_target::pid_to_str): Change return type.
2992         * ravenscar-thread.c (struct ravenscar_thread_target)
2993         <pid_to_str>: Change return type.
2994         (ravenscar_thread_target::pid_to_str): Change return type.
2995         * procfs.c (class procfs_target) <pid_to_str>: Change return
2996         type.
2997         (procfs_target::pid_to_str): Change return type.
2998         (procfs_target::attach): Update.
2999         (procfs_target::detach): Update.
3000         (procfs_target::fetch_registers): Update.
3001         (procfs_target::store_registers): Update.
3002         (procfs_target::wait): Update.
3003         (procfs_target::files_info): Update.
3004         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3005         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3006         return type.
3007         (nto_procfs_target::pid_to_str): Change return type.
3008         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3009         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3010         return type.
3011         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3012         (exit_lwp): Update.
3013         (attach_proc_task_lwp_callback, get_detach_signal)
3014         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3015         (linux_nat_target::resume, wait_lwp, stop_callback)
3016         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3017         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3018         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3019         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3020         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3021         type.
3022         (inf_ptrace_target::attach): Update.
3023         (inf_ptrace_target::files_info): Update.
3024         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3025         type.
3026         (go32_nat_target::pid_to_str): Change return type.
3027         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3028         (gnu_nat_target::wait): Update.
3029         (gnu_nat_target::wait): Update.
3030         (gnu_nat_target::resume): Update.
3031         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3032         (fbsd_nat_target::wait): Update.
3033         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3034         type.
3035         (darwin_nat_target::attach): Update.
3036         * corelow.c (class core_target) <pid_to_str>: Change return type.
3037         (core_target::pid_to_str): Change return type.
3038         * target.c (normal_pid_to_str): Change return type.
3039         (default_pid_to_str): Likewise.
3040         (target_pid_to_str): Change return type.
3041         (target_translate_tls_address): Update.
3042         (target_announce_detach): Update.
3043         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3044         return type.
3045         (bsd_uthread_target::pid_to_str): Change return type.
3046         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3047         type.
3048         (bsd_kvm_target::pid_to_str): Change return type.
3049         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3050         return type.
3051         (aix_thread_target::pid_to_str): Change return type.
3052         * target.h (struct target_ops) <pid_to_str>: Change return type.
3053         (target_pid_to_str, normal_pid_to_str): Likewise.
3054         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3055         type.
3056         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3057         type.
3058         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3059         return type.
3060         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3061         type.
3062         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3063         type.
3064         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3065         return type.
3066
3067 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3068
3069         * NEWS: Mention that the new default MI version is 3.  Mention
3070         changes to the output of commands and events that deal with
3071         multi-location breakpoints.
3072         * breakpoint.c: Include "mi/mi-out.h".
3073         (print_one_breakpoint): Change output syntax if using MI version
3074         >= 3.
3075         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3076         New.
3077         (mi_multi_location_breakpoint_output_fixed): New.
3078         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3079         (mi_cmd_fix_multi_location_breakpoint_output): New.
3080         (mi_multi_location_breakpoint_output_fixed): New.
3081         * mi/mi-cmds.c (mi_cmds): Register command
3082         -fix-multi-location-breakpoint-output.
3083         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3084         interpreter "mi".
3085
3086 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3087
3088         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3089         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3090         instantiate mi_ui_out based on interpreter name.
3091         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3092         * mi/mi-main.c (mi_load_progress): Likewise.
3093
3094 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3095
3096         * NEWS: Combine separate "New targets" sections for 8.3.
3097
3098 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3099
3100         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3101         (ppcfbsd_init_abi): Install gdbarch
3102         "fetch_tls_load_module_address" and "get_thread_local_address"
3103         methods.
3104
3105 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3106
3107         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3108         (riscv_fbsd_init_abi): Install gdbarch
3109         "fetch_tls_load_module_address" and "get_thread_local_address"
3110         methods.
3111
3112 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3113
3114         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3115         (i386fbsd_init_abi): Install gdbarch
3116         "fetch_tls_load_module_address" and "get_thread_local_address"
3117         methods.
3118
3119 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3120
3121         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3122         (amd64fbsd_init_abi): Install gdbarch
3123         "fetch_tls_load_module_address" and "get_thread_local_address"
3124         methods.
3125
3126 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3127
3128         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3129         (struct fbsd_pspace_data): New type.
3130         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3131         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3132         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3133         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3134         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3135
3136 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3137
3138         * gdbtypes.c (lookup_struct_elt): New function.
3139         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3140         * gdbtypes.h (struct struct_elt): New type.
3141         (lookup_struct_elt): New prototype.
3142
3143 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3144
3145         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3146         remove disabled code block.
3147
3148 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3149
3150         * gdbarch.sh (get_thread_local_address): New method.
3151         * gdbarch.h, gdbarch.c: Regenerate.
3152         * target.c (target_translate_tls_address): Use
3153         gdbarch_get_thread_local_address if present instead of
3154         target::get_thread_local_address.
3155
3156 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3157
3158         * target.h (target::get_thread_local_address): Update comment.
3159
3160 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3161
3162         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3163         objfile->separate_debug_objfile_backlink if not NULL.
3164
3165 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3166
3167         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3168         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3169         (amd64bsd_store_inferior_registers): Likewise.
3170         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3171         Enable segment base registers.
3172         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3173         PT_GETFSBASE and PT_GETGSBASE.
3174         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3175         PT_SETGSBASE.
3176         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3177         segment base registers.
3178         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3179
3180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3181
3182         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3183         Update calls to i386_target_description to add 'segments'
3184         parameter.
3185         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3186         add segment base registers.
3187         * arch/i386.c (i386_create_target_description): Add 'segments'
3188         parameter to enable segment base registers.
3189         * arch/i386.h (i386_create_target_description): Likewise.
3190         * features/i386/32bit-segments.xml: New file.
3191         * features/i386/32bit-segments.c: Generate.
3192         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3193         call to i386_target_description to add 'segments' parameter.
3194         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3195         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3196         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3197         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3198         if feature is present.
3199         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3200         Add 'segments' parameter to call to i386_target_description.
3201         (i386_target_description): Add 'segments' parameter to enable
3202         segment base registers.
3203         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3204         to call to i386_target_description.
3205         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3206         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3207         Define I386_NUM_REGS.
3208         (i386_target_description): Add 'segments' parameter to enable
3209         segment base registers.
3210
3211 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3212
3213         PR/24325
3214         * source-cache.c: #undef open and close, to avoid unresolved
3215         externals during linking.
3216
3217 2019-03-12  Tom Tromey  <tromey@adacore.com>
3218
3219         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3220         const.  Add initializers.
3221         (_initialize_remote): Don't initialize ptid globals.
3222
3223 2019-03-12  Pedro Alves  <palves@redhat.com>
3224
3225         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3226
3227 2019-03-12  Pedro Alves  <palves@redhat.com>
3228
3229         * cp-name-parser.y (main): Remove unused 'len' variable.
3230
3231 2019-03-12  Tom Tromey  <tromey@adacore.com>
3232
3233         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3234         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3235
3236 2019-03-12  Tom Tromey  <tromey@adacore.com>
3237
3238         * linux-nat.c (iterate_over_lwps): Update.
3239         (stop_callback): Remove parameter.
3240         (stop_wait_callback, detach_callback, resume_set_callback)
3241         (select_singlestep_lwp_callback, set_ignore_sigint)
3242         (status_callback, resumed_callback, resume_clear_callback)
3243         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3244         data parameter.
3245         (linux_nat_target::detach, linux_nat_target::resume)
3246         (linux_stop_and_wait_all_lwps, select_event_lwp)
3247         (linux_nat_filter_event, linux_nat_wait_1)
3248         (linux_nat_target::kill, linux_nat_target::stop)
3249         (linux_nat_target::stop): Update.
3250         (linux_nat_resume_callback): Change type.
3251         (resume_stopped_resumed_lwps, count_events_callback)
3252         (select_event_lwp_callback): Likewise.
3253         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3254         * arm-linux-nat.c (struct update_registers_data): Remove.
3255         (update_registers_callback): Change type.
3256         (arm_linux_insert_hw_breakpoint1): Update.
3257         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3258         parameter.
3259         (x86_linux_dr_set_addr): Update.
3260         (x86_linux_dr_set_control): Update.
3261         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3262         (iterate_over_lwps): Use gdb::function_view.
3263         * nat/aarch64-linux-hw-point.c (struct
3264         aarch64_dr_update_callback_param): Remove.
3265         (debug_reg_change_callback): Change type.
3266         (aarch64_notify_debug_reg_change): Update.
3267         * s390-linux-nat.c (s390_refresh_per_info): Update.
3268
3269 2019-03-11  Tom Tromey  <tromey@adacore.com>
3270
3271         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3272         redundant assignment to "this_cu".
3273
3274 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3275
3276         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3277
3278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3279
3280         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3281         from...
3282         (rank_one_type): ... this.
3283
3284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3285
3286         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3287         from...
3288         (rank_one_type): ... this.
3289
3290 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3291
3292         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3293         from...
3294         (rank_one_type): ... this.
3295
3296 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3297
3298         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3299         from...
3300         (rank_one_type): ... this.
3301
3302 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3303
3304         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3305         from...
3306         (rank_one_type): ... this.
3307
3308 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3309
3310         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3311         from...
3312         (rank_one_type): ... this.
3313
3314 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3315
3316         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3317         from...
3318         (rank_one_type): ... this.
3319
3320 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3321
3322         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3323         from...
3324         (rank_one_type): ... this.
3325
3326 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3327
3328         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3329         from...
3330         (rank_one_type): ... this.
3331
3332 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3333
3334         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3335         from...
3336         (rank_one_type): ... this.
3337
3338 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3339
3340         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3341         from...
3342         (rank_one_type): ... this.
3343
3344 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3345
3346         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3347         from...
3348         (rank_one_type): ... this.
3349
3350 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3351
3352         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3353         inferior-events' shows the example events.
3354
3355 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3356
3357         Support styling on native MS-Windows console
3358
3359         PR/24315
3360         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3361         on MS-Windows if $TERM is not defined.
3362
3363         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3364
3365         * posix-hdep.c (gdb_console_fputs):
3366         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3367         functions.
3368         * ui-file.h (gdb_console_fputs): Add prototype.
3369
3370         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3371         back to fputs only if the former returns zero.
3372
3373 2019-03-07  Tom Tromey  <tom@tromey.com>
3374
3375         * symmisc.c (print_symbol_bcache_statistics): Update.
3376         (print_objfile_statistics): Update.
3377         * symfile.c (allocate_symtab): Update.
3378         * stabsread.c: Don't include bcache.h.
3379         * psymtab.h (struct psymbol_bcache): Don't declare.
3380         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3381         (psymbol_bcache_init, psymbol_bcache_free)
3382         (psymbol_bcache_get_bcache): Don't declare.
3383         * psymtab.c (struct psymbol_bcache): Remove.
3384         (psymtab_storage::psymtab_storage): Update.
3385         (psymtab_storage::~psymtab_storage): Update.
3386         (psymbol_bcache_init, psymbol_bcache_free)
3387         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3388         (add_psymbol_to_bcache): Update.
3389         (allocate_psymtab): Update.
3390         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3391         macro_cache>: No longer pointers.
3392         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3393         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3394         * macrotab.c (macro_bcache): Update.
3395         * macroexp.c: Don't include bcache.h.
3396         * gdbtypes.c (check_types_worklist): Update.
3397         (types_deeply_equal): Remove TRY/CATCH.  Update.
3398         * elfread.c (elf_symtab_read): Update.
3399         * dwarf2read.c: Don't include bcache.h.
3400         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3401         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3402         (print_bcache_statistics, bcache_memory_used): Don't declare.
3403         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3404         methods.  Rename all data members.
3405         * bcache.c (struct bcache): Move to bcache.h.
3406         (bcache::expand_hash_table): Rename from expand_hash_table.
3407         (bcache): Remove.
3408         (bcache::insert): Rename from bcache_full.
3409         (bcache::compare): Rename from bcache_compare.
3410         (bcache_xmalloc): Remove.
3411         (bcache::~bcache): Rename from bcache_xfree.
3412         (bcache::print_statistics): Rename from print_bcache_statistics.
3413         (bcache::memory_used): Rename from bcache_memory_used.
3414
3415 2019-03-07  Pedro Alves  <palves@redhat.com>
3416
3417         * infrun.c (normal_stop): Also check for
3418         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3419
3420 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3421
3422         * f-lang.c (value_from_host_double): Moved to...
3423         * value.c (value_from_host_double): ...here.
3424         * value.h (value_from_host_double): Declare.
3425         * guile/scm-math.c (vlscm_convert_typed_number): Use
3426         value_from_host_double.
3427         (vlscm_convert_number): Likewise.
3428         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3429         * python/py-value.c (convert_value_from_python): Likewise.
3430
3431 2019-03-06  Tom Tromey  <tom@tromey.com>
3432
3433         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3434
3435 2019-03-06  Tom Tromey  <tom@tromey.com>
3436
3437         * utils.h (free_current_contents): Don't declare.
3438         * utils.c (free_current_contents): Remove.
3439
3440 2019-03-06  Tom Tromey  <tom@tromey.com>
3441
3442         * top.c (quit_force): Update.
3443         * main.c (captured_command_loop): Update.
3444         * common/new-op.c (operator new): Update.
3445         * common/common-exceptions.c (struct catcher)
3446         <save_cleanup_chain>: Remove member.
3447         (exceptions_state_mc_init): Update.
3448         (exception_try_scope_entry): Return nullptr.
3449         (exception_try_scope_exit, exception_rethrow)
3450         (throw_exception_sjlj, throw_exception_cxx): Update.
3451         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3452         (all_cleanups, do_cleanups, discard_cleanups)
3453         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3454         (restore_cleanups, restore_final_cleanups): Don't declare.
3455         (do_final_cleanups): Remove parameter.
3456         * common/cleanups.c (cleanup_chain, make_cleanup)
3457         (make_cleanup_dtor, all_cleanups, do_cleanups)
3458         (discard_my_cleanups, discard_cleanups)
3459         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3460         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3461         (null_cleanup): Remove.
3462         (do_final_cleanups): Remove parameter.
3463
3464 2019-03-06  Tom Tromey  <tom@tromey.com>
3465
3466         * remote.c (remote_target::remote_parse_stop_reply): Use
3467         unique_xmalloc_ptr.
3468
3469 2019-03-06  Tom Tromey  <tom@tromey.com>
3470
3471         * stabsread.c (struct stabs_field_info): Rename from field_info.
3472         <list, fnlist>: Add initializers.
3473         <obstack>: New member.
3474         (read_member_functions, read_struct_fields, read_baseclasses):
3475         Allocate on obstack.  Don't use cleanups.
3476         (read_one_struct_field, read_member_functions, read_struct_fields)
3477         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3478         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3479         (read_struct_type): Update.
3480
3481 2019-03-06  Tom Tromey  <tom@tromey.com>
3482
3483         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3484         * common/filestuff.h (make_cleanup_close): Don't declare.
3485         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3486         Remove.
3487
3488 2019-03-06  Tom Tromey  <tom@tromey.com>
3489
3490         * solib-aix.c: Use make_scope_exit.
3491
3492 2019-03-06  Tom Tromey  <tom@tromey.com>
3493
3494         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3495         Use make_scope_exit.
3496
3497 2019-03-06  Tom Tromey  <tom@tromey.com>
3498
3499         * solib-svr4.c (disable_probes_interface): Remove parameter.
3500         (svr4_handle_solib_event): Use make_scope_exit.
3501
3502 2019-03-06  Tom Tromey  <tom@tromey.com>
3503
3504         * remote.c (struct stop_reply_deleter): Remove.
3505         (stop_reply_up): Update.
3506         (struct stop_reply): Derive from notif_event.  Don't typedef.
3507         <regcache>: Now a std::vector.
3508         (stop_reply_xfree): Remove.
3509         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3510         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3511         (remote_target::discard_pending_stop_replies): Use delete.
3512         (remote_target::remote_parse_stop_reply): Update.
3513         (remote_target::process_stop_reply): Update.
3514         * remote-notif.h (struct notif_event): Add virtual destructor.
3515         Remove "dtr" member.
3516         (struct notif_client) <alloc_event>: Return a unique_ptr.
3517         (notif_event_xfree): Don't declare.
3518         (notif_event_up): New typedef.
3519         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3520         (notif_event_xfree, do_notif_event_xfree): Remove.
3521         (remote_notif_state_xfree): Update.
3522
3523 2019-03-06  Tom Tromey  <tom@tromey.com>
3524
3525         * infrun.c (displaced_step_clear_cleanup): Now a
3526         forward_scope_exit type.
3527         (displaced_step_prepare_throw): Update.
3528         (displaced_step_fixup): Update.
3529
3530 2019-03-06  Tom Tromey  <tom@tromey.com>
3531
3532         * inferior.h (class inferior): Update comment.
3533         * gdbthread.h (class thread_info): Update comment.
3534
3535 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3536             Tom Tromey  <tom@tromey.com>
3537
3538         * stabsread.h (struct stab_section_list): Remove.
3539         (coffstab_build_psymtabs): Update.
3540         * dbxread.c (symbuf_sections): Now a std::vector.
3541         (sect_idx): New global.
3542         (fill_symbuf): Update.
3543         (coffstab_build_psymtabs): Change type of stabsects parameter.
3544         Update.
3545         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3546         std::vector.
3547         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3548         (coff_locate_sections): Update.
3549         (coff_symfile_read): Remove cleanups.  Update.
3550         (init_stringtab): Add storage parameter.
3551         (free_stringtab, free_stringtab_cleanup): Remove.
3552         (init_lineno): Add storage parameter.
3553         (free_linetab, free_linetab_cleanup): Remove.
3554
3555 2019-03-06  Pedro Alves  <palves@redhat.com>
3556
3557         * linux-fork.c (fork_info::clobber_regs): Delete.
3558         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3559         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3560         comment.  Adjust.
3561         (scoped_switch_fork_info::scoped_switch_fork_info)
3562         (checkpoint_command, linux_fork_context): Adjust
3563         fork_save_infrun_state calls.
3564
3565 2019-03-06  Pedro Alves  <palves@redhat.com>
3566
3567         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3568         (inf_has_multiple_threads): Return 'bool' and rewrite using
3569         inferior_info::threads().
3570
3571 2019-03-06  Pedro Alves  <palves@redhat.com>
3572
3573         * linux-fork.c: Include <list>.
3574         (fork_list): Now a std::list instance.
3575         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3576         (forks_exist_p, find_last_fork): Adjust.
3577         (new_fork): Delete.
3578         (one_fork_p): New.
3579         (add_fork): Adjust.
3580         (free_fork): Delete, folded into fork_info::~fork_info().
3581         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3582         Adjust.
3583         (init_fork_list): Delete.
3584         (linux_fork_killall, linux_fork_mourn_inferior)
3585         (linux_fork_detach, info_checkpoints_command): Adjust.
3586         (_initialize_linux_fork): No longer call init_fork_list.
3587
3588 2019-03-06  Pedro Alves  <palves@redhat.com>
3589
3590         * linux-fork.c (new_fork): New, split out of ...
3591         (add_fork): ... this.  Return void.  Move "first fork" special
3592         case from here, to ...
3593         (checkpoint_command): ... here.
3594         * linux-linux.h (add_fork): Return void.
3595
3596 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3599
3600 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3601             Chris January  <chris.january@arm.com>
3602             David Lecomber  <david.lecomber@arm.com>
3603
3604         * f-exp.y: New token, UNOP_INTRINSIC.
3605         (exp): New pattern using UNOP_INTRINSIC token.
3606         (f77_keywords): Add 'abs' keyword.
3607         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3608         (value_from_host_double): New function.
3609         (evaluate_subexp_f): Support UNOP_ABS.
3610
3611 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3612
3613         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3614         types.
3615
3616 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3617
3618         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3619         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3620         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3621
3622 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3623
3624         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3625
3626 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3627             Chris January  <chris.january@arm.com>
3628
3629         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3630         * f-exp.y: Define 'KIND' token.
3631         (exp): New pattern for KIND expressions.
3632         (ptype): Handle types with a kind extension.
3633         (direct_abs_decl): Extend to spot kind extensions.
3634         (f77_keywords): Add 'kind' to the list.
3635         (push_kind_type): New function.
3636         (convert_to_kind_type): New function.
3637         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3638         * parse.c (operator_length_standard): Likewise.
3639         * parser-defs.h (enum type_pieces): Add tp_kind.
3640         * std-operator.def: Add UNOP_KIND.
3641
3642 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3643
3644         * f-exp.y (f_parse): Set yydebug.
3645
3646 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3647
3648         * f-lang.c (evaluate_subexp_f): New function.
3649         (exp_descriptor_f): New global.
3650         (f_language_defn): Use exp_descriptor_f instead of
3651         exp_descriptor_standard.
3652
3653 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3654
3655         * f-exp.y (struct token): Add comments.
3656         (dot_ops): Remove uppercase versions and the end marker.
3657         (f77_keywords): Likewise.
3658         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3659         entries in the dot_ops array are case insensitive, and use
3660         strncasecmp to compare strings.  Also some whitespace cleanup in
3661         this area.  Similar for the f77_keywords array, except entries in
3662         this list might be case sensitive.
3663
3664 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3665
3666         * f-exp.y (struct f77_boolean_val): Add comments.
3667         (boolean_values): Remove uppercase versions, and end marker.
3668         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3669         and use strncasecmp to achieve case insensitivity.  Additionally,
3670         perform whitespace cleanup around this code.
3671
3672 2019-03-06  Tom Tromey  <tromey@adacore.com>
3673
3674         * remote-sim.c (gdbsim_target_open): Use result of
3675         gdb_argv::release.
3676
3677 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3678         Dirk Schubert  <dirk.schubert@arm.com>
3679         Chris January  <chris.january@arm.com>
3680
3681         * eval.c (evaluate_subexp_standard): Call Fortran argument
3682         wrapping logic.
3683         * f-lang.c (struct value): A value which can be passed into a
3684         Fortran function call.
3685         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3686         where appropriate.
3687         (struct type): Value ready for a Fortran function call.
3688         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3689         is needed.
3690         * f-lang.h (fortran_argument_convert): Declaration.
3691         (fortran_preserve_arg_pointer): Declaration.
3692         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3693
3694 2019-03-05  Tom Tromey  <tromey@adacore.com>
3695
3696         * python/py-prettyprint.c (print_string_repr): Remove #if.
3697         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3698
3699 2019-03-05  Tom Tromey  <tromey@adacore.com>
3700
3701         * target.c (the_dummy_target): Move later.  Change type to
3702         "dummy_target".
3703         (initialize_targets): Don't initialize the_dummy_target.
3704
3705 2019-03-05  Tom Tromey  <tromey@adacore.com>
3706
3707         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3708         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3709
3710 2019-03-05  Tom Tromey  <tromey@adacore.com>
3711
3712         * windows-nat.c (windows_nat_target::attach)
3713         (windows_nat_target::detach): Don't call gdb_flush.
3714         * valprint.c (generic_val_print, val_print, val_print_string):
3715         Don't call gdb_flush.
3716         * utils.c (defaulted_query): Don't call gdb_flush.
3717         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3718         * target.c (target_announce_detach): Don't call gdb_flush.
3719         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3720         * remote.c (extended_remote_target::attach): Don't call
3721         gdb_flush.
3722         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3723         * printcmd.c (do_examine): Don't call gdb_flush.
3724         (info_display_command): Don't call gdb_flush.
3725         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3726         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3727         * memattr.c (info_mem_command): Don't call gdb_flush.
3728         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3729         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3730         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3731         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3732         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3733         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3734         (gnu_nat_target::detach): Don't call gdb_flush.
3735         * f-valprint.c (f_val_print): Don't call gdb_flush.
3736         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3737         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3738         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3739         gdb_flush.
3740         * c-valprint.c (c_val_print): Don't call gdb_flush.
3741         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3742
3743 2019-03-05  Tom Tromey  <tromey@adacore.com>
3744
3745         * varobj.c (update_dynamic_varobj_children): Update.
3746         (install_default_visualizer): Use reset, not release.
3747         * value.c (set_internalvar): Update.
3748         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3749         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3750         ATTRIBUTE_UNUSED_RESULT.
3751
3752 2019-03-05  Tom Tromey  <tromey@adacore.com>
3753
3754         * remote.c (class scoped_remote_fd) <release>: Add
3755         ATTRIBUTE_UNUSED_RESULT.
3756
3757 2019-03-05  Tom Tromey  <tromey@adacore.com>
3758
3759         * macroexp.c (struct macro_buffer) <release>: Add
3760         ATTRIBUTE_UNUSED_RESULT.
3761
3762 2019-03-05  Tom Tromey  <tromey@adacore.com>
3763
3764         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3765         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3766         ATTRIBUTE_UNUSED_RESULT.
3767
3768 2019-03-05  Tom Tromey  <tromey@adacore.com>
3769
3770         * common/scoped_fd.h (class scoped_fd) <release>: Add
3771         ATTRIBUTE_UNUSED_RESULT.
3772
3773 2019-03-05  Tom Tromey  <tromey@adacore.com>
3774
3775         * parser-defs.h (struct parser_state) <release>: Add
3776         ATTRIBUTE_UNUSED_RESULT.
3777
3778 2019-03-05  Tom Tromey  <tromey@adacore.com>
3779
3780         * utils.h (class gdb_argv) <release>: Add
3781         ATTRIBUTE_UNUSED_RESULT.
3782         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3783
3784 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3785
3786         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3787         for-loop range, to avoid compiler warnings.
3788
3789         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3790         avoid compiler warnings about unused variables.
3791
3792         * NEWS: Mention end of support for native debugging on MS-Windows
3793         before XP.
3794
3795         PR gdb/24292
3796         * common/netstuff.c:
3797         * gdbserver/gdbreplay.c
3798         * gdbserver/remote-utils.c:
3799         * ser-tcp.c:
3800         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3801         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3802         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3803         'getaddrinfo' and 'freeaddrinfo' were not available before
3804         Windows XP, and mingw.org's MinGW headers by default define
3805         _WIN32_WINNT to 0x500.
3806
3807 2019-03-01  Gary Benson <gbenson@redhat.com>
3808
3809         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3810
3811 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3812             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3813
3814         PR gdb/8527
3815         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3816         set_sigint_trap, clear_sigint_trap.
3817
3818 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3819
3820         * target.c (target_detach): Clear the regcache and the
3821         frame cache.
3822
3823 2019-02-27  Pedro Alves  <palves@redhat.com>
3824
3825         * utils.c (set_screen_size): When we cap the height/width sizes,
3826         tweak the corresponding command variable to show "unlimited":
3827
3828 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3829             Pedro Alves  <palves@redhat.com>
3830
3831         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3832         before calling rl_set_screen_size.
3833
3834 2019-02-27  Tom Tromey  <tromey@adacore.com>
3835
3836         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3837         define.
3838         * python/py-value.c: Remove Python 2.4 workaround.
3839         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3840         workaround.
3841         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3842         Python 2.4 workaround.
3843         * python/python-internal.h: Remove Python 2.4 comment.
3844         (Py_ssize_t): Don't define.
3845         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3846         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3847         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3848         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3849         * python/python.c (do_start_initialization): Remove Python 2.4
3850         workaround.
3851         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3852         (print_children): Remove Python 2.4 workaround.
3853         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3854         workaround.
3855         (CHARBUFFERPROC_NAME): Remove.
3856         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3857         Python 2.4 workaround.
3858
3859 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3860
3861         * NEWS: Note minimum Python version.
3862
3863 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3864
3865         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3866         code from these functions.  Remove corresponding ifdefs.  Use
3867         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3868         Remove gotos and target of gotos.
3869         (infpy_search_memory): Likewise.
3870
3871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3872
3873         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3874         (hppa_gdbarch_init): Don't register deleted functions with
3875         gdbarch.
3876
3877 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3880         (h8300_unwind_sp): Delete.
3881         (h8300_dummy_id): Delete.
3882         (h8300_gdbarch_init): Don't register deleted functions with
3883         gdbarch.
3884
3885 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3886
3887         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3888         (ft32_unwind_pc): Delete.
3889         (ft32_unwind_sp): Delete.
3890         (ft32_gdbarch_init): Don't register deleted functions with
3891         gdbarch.
3892
3893 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3894
3895         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3896         (frv_unwind_pc): Delete.
3897         (frv_unwind_sp): Delete.
3898         (frv_gdbarch_init): Don't register deleted functions with
3899         gdbarch.
3900
3901 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3904         (riscv_unwind_pc): Delete.
3905         (riscv_unwind_sp): Delete.
3906         (riscv_gdbarch_init): Don't register deleted functions with
3907         gdbarch.
3908
3909 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3910
3911         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3912         (csky_unwind_pc): Delete.
3913         (csky_unwind_sp): Delete.
3914         (csky_gdbarch_init): Don't register deleted functions with
3915         gdbarch.
3916
3917 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3918
3919         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3920         (cris_unwind_pc): Delete.
3921         (cris_unwind_sp): Delete.
3922         (cris_gdbarch_init): Don't register deleted functions with
3923         gdbarch.
3924
3925 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3926
3927         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3928         (bfin_unwind_pc): Delete.
3929         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3930
3931 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3934         (arm_unwind_pc): Delete.
3935         (arm_unwind_sp): Delete.
3936         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3937
3938 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3941         (arc_unwind_pc): Delete.
3942         (arc_unwind_sp): Delete.
3943         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3944
3945 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3948         (alpha_unwind_pc): Delete.
3949         (alpha_gdbarch_init): Don't register deleted functions with
3950         gdbarch.
3951
3952 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3953
3954         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3955         (aarch64_unwind_pc): Delete.
3956         (aarch64_unwind_sp): Delete.
3957         (aarch64_gdbarch_init): Don't register deleted functions with
3958         gdbarch.
3959
3960 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * gdbtypes.c (type_align): Don't consider static members when
3963         computing structure alignment.
3964
3965 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3966
3967         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3968         return 0 for other types.
3969         * arch-utils.c (default_type_align): Always return 0.
3970         * gdbarch.h: Regenerate.
3971         * gdbarch.sh (type_align): Extend comment.
3972         * gdbtypes.c (type_align): Add additional comments, always call
3973         gdbarch_type_align before applying the default rules.
3974         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3975         generic code will then apply a suitable default.
3976         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3977         types, return 0 for other types.
3978
3979 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3980
3981         * NEWS: Create a new section for the next release branch.
3982         Rename the section of the current branch, now that it has
3983         been cut.
3984
3985 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3986
3987         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3988         * version.in: Bump version to 8.3.50.DATE-git.
3989
3990 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3991
3992         * aix-thread.c (ptid_cmp): Remove unused variable.
3993         (get_signaled_thread): Likewise.
3994         (store_regs_user_thread): Likewise.
3995         (store_regs_kernel_thread): Likewise.
3996         (fetch_regs_kernel_thread): Remove shadowed variable.
3997
3998 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3999
4000         * features/riscv/32bit-cpu.xml: Add register numbers.
4001         * features/riscv/32bit-fpu.c: Regenerate.
4002         * features/riscv/32bit-fpu.xml: Add register numbers.
4003         * features/riscv/64bit-cpu.xml: Add register numbers.
4004         * features/riscv/64bit-fpu.c: Regenerate.
4005         * features/riscv/64bit-fpu.xml: Add register numbers.
4006
4007 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4008
4009         * NEWS: Mention two argument form of gdb.Value constructor.
4010         * python/py-value.c (convert_buffer_and_type_to_value): New
4011         function.
4012         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4013         Add support for handling an optional second argument.  Call
4014         convert_buffer_and_type_to_value as appropriate.
4015         * python/python-internal.h (Py_buffer_deleter): New struct.
4016         (Py_buffer_up): New typedef.
4017
4018 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4019
4020         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4021         instead of releasing ownership.
4022
4023 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4024
4025         * dwarf2read.c (open_and_init_dwp_file): Call
4026         elf_numsections instead of bfd_count_sections to initialize
4027         dwp_file->num_sections.
4028
4029 2019-02-25  Tom Tromey  <tromey@adacore.com>
4030
4031         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4032
4033 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4034
4035         * gcore.in: Add '--readnever' option when invoking GDB.
4036
4037 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4038
4039         * MAINTAINERS: Update my email address.
4040
4041 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4042
4043         * build-id.c (build_id_to_debug_bfd_1): New function.
4044         (build_id_to_debug_bfd): Look for separate debug file in
4045         sysroot.
4046
4047 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4048
4049         * gdbarch.sh: Update the copyright year range that is placed into
4050         generated files.
4051
4052 2019-02-22  Keith Seitz  <keiths@redhat.com>
4053
4054         PR symtab/23853
4055         * linespec.c (create_sals_line_offset): Search for the default
4056         symtab's filename instead of its fullname.
4057
4058 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4059
4060         * NEWS: Update style defaults.
4061
4062 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4063
4064         * main.c (captured_main_1): Disable styling in batch mode.
4065
4066 2019-02-20  Tom Tromey  <tom@tromey.com>
4067
4068         * symtab.c (symtab_symbol_info): Fix typos.
4069
4070 2019-02-20  Tom Tromey  <tromey@adacore.com>
4071
4072         * findcmd.c (_initialize_mem_search): Use upper case for
4073         metasyntactic variables.
4074
4075 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4076
4077         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4078         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4079
4080 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4081
4082         * top.h (source_file_name): Change to std::string.
4083         * top.c (source_file_name): Likewise.
4084         (command_line_input): Adjust.
4085         * cli/cli-script.c (script_from_file): Adjust.
4086
4087 2019-02-19  Tom Tromey  <tromey@adacore.com>
4088
4089         * ravenscar-thread.c
4090         (ravenscar_thread_target::update_thread_list): Don't call
4091         ada_build_task_list.
4092         * ada-lang.h (ada_build_task_list): Don't declare.
4093         * ada-tasks.c (struct ada_tasks_inferior_data)
4094         <task_list_valid_p>: Now bool.
4095         (read_known_tasks, ada_task_list_changed)
4096         (ada_tasks_invalidate_inferior_data): Update.
4097         (read_known_tasks_array): Return bool.
4098         (read_known_tasks_list): Likewise.
4099         (read_known_tasks): Return void.
4100         (ada_build_task_list): Now static.
4101
4102 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4103
4104         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4105         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4106
4107 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4108
4109         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4110         variant for ada_tasks_pspace_data_handle and
4111         ada_tasks_inferior_data_handle.
4112         (ada_tasks_pspace_data_cleanup): New function.
4113         (ada_tasks_inferior_data_cleanup): New function.
4114
4115 2019-02-17  Tom Tromey  <tom@tromey.com>
4116
4117         * macrotab.h (macro_source_fullname): Return a std::string.
4118         * macrotab.c (macro_include, check_for_redefinition)
4119         (macro_undef, macro_lookup_definition, foreach_macro)
4120         (foreach_macro_in_scope): Update.
4121         (macro_source_fullname): Return a std::string.
4122         * macrocmd.c (show_pp_source_pos): Update.
4123
4124 2019-02-17  Tom Tromey  <tom@tromey.com>
4125
4126         * macrocmd.c (show_pp_source_pos): Style the file names.
4127
4128 2019-02-17  Tom Tromey  <tom@tromey.com>
4129
4130         PR tui/24197:
4131         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4132
4133 2019-02-17  Tom Tromey  <tom@tromey.com>
4134
4135         * ada-lang.c (user_select_syms): Use filtered printing.
4136         * utils.c (wrap_style): New global.
4137         (desired_style): Remove.
4138         (emit_style_escape): Add stream parameter.
4139         (set_output_style, reset_terminal_style, prompt_for_continue):
4140         Update.
4141         (flush_wrap_buffer): Only flush gdb_stdout.
4142         (wrap_here): Set wrap_style.
4143         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4144         treat escape sequences as a character.  Change when wrap buffer is
4145         flushed.
4146         (fputs_styled): Do not set the output style when the default is
4147         requested.
4148         * ui-style.h (struct ui_file_style) <is_default>: New method.
4149         * source.c (print_source_lines_base): Emit escape sequences in one
4150         piece.
4151
4152 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4153
4154         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4155         integers and enumeration types.
4156
4157 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4158
4159         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4160         instead of lookup_symbol_in_language
4161         (do_exact_match): New function.
4162         (ada_get_symbol_name_matcher): Return do_exact_match when
4163         doing a verbatim match.
4164
4165 2019-02-15  Tom Tromey  <tromey@adacore.com>
4166
4167         * ravenscar-thread.c (ravenscar_thread_target::resume)
4168         (ravenscar_thread_target::wait): Special case wildcard requests.
4169
4170 2019-02-15  Tom Tromey  <tromey@adacore.com>
4171
4172         * ravenscar-thread.c (base_ptid): Remove.
4173         (struct ravenscar_thread_target) <close>: New method.
4174         <m_base_ptid>: New member.
4175         <update_inferior_ptid, active_task, task_is_currently_active,
4176         runtime_initialized>: Declare methods.
4177         <ravenscar_thread_target>: Add constructor.
4178         (ravenscar_thread_target::task_is_currently_active)
4179         (ravenscar_thread_target::update_inferior_ptid)
4180         (ravenscar_runtime_initialized): Rename.  Now methods.
4181         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4182         (ravenscar_thread_target::update_thread_list): Update.
4183         (ravenscar_thread_target::active_task): Now method.
4184         (ravenscar_thread_target::store_registers)
4185         (ravenscar_thread_target::prepare_to_store)
4186         (ravenscar_thread_target::prepare_to_store)
4187         (ravenscar_thread_target::mourn_inferior): Update.
4188         (ravenscar_inferior_created): Use "new" to create target.
4189         (ravenscar_thread_target::get_ada_task_ptid): Update.
4190         (_initialize_ravenscar): Don't initialize base_ptid.
4191         (ravenscar_ops): Remove global.
4192
4193 2019-02-15  Tom Tromey  <tromey@adacore.com>
4194
4195         * target.h (push_target): Declare new overload.
4196         * target.c (push_target): New overload, taking an rvalue reference.
4197         * remote.c (remote_target::open_1): Use push_target overload.
4198         * corelow.c (core_target_open): Use push_target overload.
4199
4200 2019-02-15  Tom Tromey  <tromey@adacore.com>
4201
4202         * ravenscar-thread.c (is_ravenscar_task)
4203         (ravenscar_task_is_currently_active): Return bool.
4204         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4205         (_initialize_ravenscar): Remove "(void)".
4206         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4207         Return bool.
4208
4209 2019-02-15  Tom Tromey  <tromey@adacore.com>
4210
4211         * ravenscar-thread.c (ravenscar_runtime_initializer)
4212         (has_ravenscar_runtime, get_running_thread_id)
4213         (ravenscar_thread_target::resume): Fix indentation.
4214
4215 2019-02-15  Tom Tromey  <tromey@adacore.com>
4216
4217         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4218         from ravenscar_arch_ops.
4219         (sparc_ravenscar_ops::fetch_registers)
4220         (sparc_ravenscar_ops::store_registers): Now methods.
4221         (sparc_ravenscar_prepare_to_store): Remove.
4222         (sparc_ravenscar_ops): Redefine.
4223         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4224         methods and destructor.  Remove members.
4225         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4226         (ravenscar_thread_target::store_registers)
4227         (ravenscar_thread_target::prepare_to_store): Update.
4228         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4229         Remove.
4230         (struct ppc_ravenscar_powerpc_ops): Derive from
4231         ravenscar_arch_ops.
4232         (ppc_ravenscar_powerpc_ops::fetch_registers)
4233         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4234         (ppc_ravenscar_powerpc_ops): Redefine.
4235         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4236         (ppc_ravenscar_e500_ops::fetch_registers)
4237         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4238         (ppc_ravenscar_e500_ops): Redefine.
4239         * aarch64-ravenscar-thread.c
4240         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4241         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4242         (aarch64_ravenscar_fetch_registers)
4243         (aarch64_ravenscar_store_registers): Now methods.
4244         (aarch64_ravenscar_ops): Redefine.
4245
4246 2019-02-15  Tom Tromey  <tromey@adacore.com>
4247
4248         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4249         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4250         (ravenscar_thread_target::stopped_by_watchpoint)
4251         (ravenscar_thread_target::stopped_data_address)
4252         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4253
4254 2019-02-15  Tom Tromey  <tromey@adacore.com>
4255
4256         * ravenscar-thread.c: Fix some typos.
4257
4258 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4259             Tom Tromey  <tromey@adacore.com>
4260
4261         * ada-lang.c (ada_exception_sal): Change addr_string to a
4262         std::string.
4263         (create_ada_exception_catchpoint): Update.
4264
4265 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4266             Tom Tromey  <tromey@adacore.com>
4267
4268         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4269         (bp_location_ops): Remove.
4270         (base_breakpoint_allocate_location): Update.
4271         (free_bp_location): Update.
4272         * ada-lang.c (class ada_catchpoint_location)
4273         <ada_catchpoint_location>: Remove ops parameter.
4274         (ada_catchpoint_location_dtor): Remove.
4275         (ada_catchpoint_location_ops): Remove.
4276         (allocate_location_exception): Update.
4277         * breakpoint.h (struct bp_location_ops): Remove.
4278         (class bp_location) <bp_location>: Remove bp_location_ops
4279         parameter.
4280         <~bp_location>: Add destructor.
4281         <ops>: Remove.
4282
4283 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4284             Pedro Alves  <palves@redhat.com>
4285
4286         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4287         'PATH_MAX'.
4288
4289 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4290             Samuel Thibault  <samuel.thibault@gnu.org>
4291             Thomas Schwinge  <thomas@codesourcery.com>
4292
4293         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4294         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4295
4296 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4297
4298         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4299         (check_empty): Use "const char *".
4300
4301         * gnu-nat.c (gnu_nat_target::detach): Instead of
4302         'detach_inferior (pid)' call
4303         'detach_inferior (find_inferior_pid (pid))'.
4304
4305         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4306         'nat/fork-inferior.o'.
4307         * gnu-nat.c: #include "nat/fork-inferior.h".
4308
4309         * gnu-nat.c (gnu_nat_target::detach): Instead of
4310         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4311         * gnu-nat.h: #include "inf-child.h".
4312         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4313         'i386_gnu_nat_target::fetch_registers'.
4314         (gnu_store_registers): Rename/move to
4315         'i386_gnu_nat_target::store_registers'.
4316
4317         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4318         * gnu-nat.h (mach_thread_info): New function.
4319         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4320
4321         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4322
4323 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4324
4325         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4326
4327 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4328
4329         * windows-nat.c (windows_add_thread): Add new parameter
4330         "main_thread_p" with default value set to false.  Update
4331         function documentation as well as all callers.
4332         (windows_delete_thread): Likewise.
4333         (fake_create_process): Update call to windows_add_thread.
4334         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4335         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4336         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4337         call to windows_delete_thread.
4338
4339 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4340
4341         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4342
4343 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4344
4345         * symfile.c (find_separate_debug_file): Use canonical path of
4346         sysroot with child_path instead of gdb_sysroot if it is valid.
4347
4348 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4349
4350         * symfile.c (find_separate_debug_file): Use child_path to
4351         determine if an object file is under a sysroot.
4352
4353 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4354
4355         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4356         unittests/child-path-selftests.c.
4357         * common/pathstuff.c (child_path): New function.
4358         * common/pathstuff.h (child_path): New prototype.
4359         * unittests/child-path-selftests.c: New file.
4360
4361 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4362
4363         * symfile.c (find_separate_debug_file): Look for separate debug
4364         files in debug directories under the sysroot.
4365
4366 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4367
4368         * symtab.h (struct minimal_symbol data_p): New const method.
4369         (struct minimal_symbol text_p): Likewise.
4370         * symtab.c (output_source_filename): Use file name style
4371         to print file name.
4372         (print_symbol_info): Likewise.
4373         (print_msymbol_info): Use address style to print addresses.
4374         Use function name style to print executable text symbols.
4375         (expand_symtab_containing_pc): Use data_p.
4376         (find_pc_sect_compunit_symtab): Likewise.
4377
4378 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4379
4380         * breakpoint.c (describe_other_breakpoints): Use address style
4381         to print addresses.
4382         (say_where): Likewise.
4383
4384 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4385
4386         * ada-typeprint.c (print_func_type): Print function name
4387         style to print function name.
4388         * c-typeprint.c (c_print_type_1): Likewise.
4389
4390 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4391
4392         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4393         for execve.
4394
4395 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4396
4397         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4398         type_stack.
4399
4400 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4401
4402         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4403         TYPE_CODE_REF types.
4404
4405 2019-02-08  Jim Wilson  <jimw@sifive.com>
4406
4407         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4408         (riscv_linux_fregset): New.
4409         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4410
4411 2019-02-07  Tom Tromey  <tom@tromey.com>
4412
4413         * thread.c (thread_cancel_execution_command): Update.
4414         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4415         methods.
4416         (struct thread_fsm_ops): Remove.
4417         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4418         (thread_fsm_should_stop, thread_fsm_return_value)
4419         (thread_fsm_set_finished, thread_fsm_finished_p)
4420         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4421         Don't declare.
4422         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4423         * infrun.c (clear_proceed_status_thread)
4424         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4425         (print_stop_event): Update.
4426         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4427         Add constructor.
4428         (step_command_fsm_ops): Remove.
4429         (new_step_command_fsm): Remove.
4430         (step_1): Update.
4431         (step_command_fsm::should_stop): Rename from
4432         step_command_fsm_should_stop.
4433         (step_command_fsm::clean_up): Rename from
4434         step_command_fsm_clean_up.
4435         (step_command_fsm::do_async_reply_reason): Rename from
4436         step_command_fsm_async_reply_reason.
4437         (struct until_next_fsm): Inherit from thread_fsm.  Add
4438         constructor.
4439         (until_next_fsm_ops): Remove.
4440         (new_until_next_fsm): Remove.
4441         (until_next_fsm::should_stop): Rename from
4442         until_next_fsm_should_stop.
4443         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4444         (until_next_fsm::do_async_reply_reason): Rename from
4445         until_next_fsm_async_reply_reason.
4446         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4447         constructor.  Change type of breakpoint.
4448         (finish_command_fsm_ops): Remove.
4449         (new_finish_command_fsm): Remove.
4450         (finish_command_fsm::should_stop): Rename from
4451         finish_command_fsm_should_stop.
4452         (finish_command_fsm::clean_up): Rename from
4453         finish_command_fsm_clean_up.
4454         (finish_command_fsm::return_value): Rename from
4455         finish_command_fsm_return_value.
4456         (finish_command_fsm::do_async_reply_reason): Rename from
4457         finish_command_fsm_async_reply_reason.
4458         (finish_command): Update.
4459         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4460         Add constructor.
4461         (call_thread_fsm_ops): Remove.
4462         (call_thread_fsm::call_thread_fsm): Rename from
4463         new_call_thread_fsm.
4464         (call_thread_fsm::should_stop): Rename from
4465         call_thread_fsm_should_stop.
4466         (call_thread_fsm::should_notify_stop): Rename from
4467         call_thread_fsm_should_notify_stop.
4468         (run_inferior_call, call_function_by_hand_dummy): Update.
4469         * cli/cli-interp.c (should_print_stop_to_console): Update.
4470         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4471         Add constructor.  Change type of location_breakpoint,
4472         caller_breakpoint.
4473         (until_break_fsm_ops): Remove.
4474         (new_until_break_fsm): Remove.
4475         (until_break_fsm::should_stop): Rename from
4476         until_break_fsm_should_stop.
4477         (until_break_fsm::clean_up): Rename from
4478         until_break_fsm_clean_up.
4479         (until_break_fsm::do_async_reply_reason): Rename from
4480         until_break_fsm_async_reply_reason.
4481         (until_break_command): Update.
4482         * thread-fsm.c: Remove.
4483         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4484
4485 2019-02-07  Tom Tromey  <tom@tromey.com>
4486
4487         * yy-remap.h: Add include guard.
4488         * xtensa-tdep.h: Add include guard.
4489         * xcoffread.h: Rename include guard.
4490         * varobj-iter.h: Add include guard.
4491         * tui/tui.h: Rename include guard.
4492         * tui/tui-winsource.h: Rename include guard.
4493         * tui/tui-wingeneral.h: Rename include guard.
4494         * tui/tui-windata.h: Rename include guard.
4495         * tui/tui-win.h: Rename include guard.
4496         * tui/tui-stack.h: Rename include guard.
4497         * tui/tui-source.h: Rename include guard.
4498         * tui/tui-regs.h: Rename include guard.
4499         * tui/tui-out.h: Rename include guard.
4500         * tui/tui-layout.h: Rename include guard.
4501         * tui/tui-io.h: Rename include guard.
4502         * tui/tui-hooks.h: Rename include guard.
4503         * tui/tui-file.h: Rename include guard.
4504         * tui/tui-disasm.h: Rename include guard.
4505         * tui/tui-data.h: Rename include guard.
4506         * tui/tui-command.h: Rename include guard.
4507         * tic6x-tdep.h: Add include guard.
4508         * target/waitstatus.h: Rename include guard.
4509         * target/wait.h: Rename include guard.
4510         * target/target.h: Rename include guard.
4511         * target/resume.h: Rename include guard.
4512         * target-float.h: Rename include guard.
4513         * stabsread.h: Add include guard.
4514         * rs6000-tdep.h: Add include guard.
4515         * riscv-fbsd-tdep.h: Add include guard.
4516         * regformats/regdef.h: Rename include guard.
4517         * record.h: Rename include guard.
4518         * python/python.h: Rename include guard.
4519         * python/python-internal.h: Rename include guard.
4520         * python/py-stopevent.h: Rename include guard.
4521         * python/py-ref.h: Rename include guard.
4522         * python/py-record.h: Rename include guard.
4523         * python/py-record-full.h: Rename include guard.
4524         * python/py-record-btrace.h: Rename include guard.
4525         * python/py-instruction.h: Rename include guard.
4526         * python/py-events.h: Rename include guard.
4527         * python/py-event.h: Rename include guard.
4528         * procfs.h: Add include guard.
4529         * proc-utils.h: Add include guard.
4530         * p-lang.h: Add include guard.
4531         * or1k-tdep.h: Rename include guard.
4532         * observable.h: Rename include guard.
4533         * nto-tdep.h: Rename include guard.
4534         * nat/x86-linux.h: Rename include guard.
4535         * nat/x86-linux-dregs.h: Rename include guard.
4536         * nat/x86-gcc-cpuid.h: Add include guard.
4537         * nat/x86-dregs.h: Rename include guard.
4538         * nat/x86-cpuid.h: Rename include guard.
4539         * nat/ppc-linux.h: Rename include guard.
4540         * nat/mips-linux-watch.h: Rename include guard.
4541         * nat/linux-waitpid.h: Rename include guard.
4542         * nat/linux-ptrace.h: Rename include guard.
4543         * nat/linux-procfs.h: Rename include guard.
4544         * nat/linux-osdata.h: Rename include guard.
4545         * nat/linux-nat.h: Rename include guard.
4546         * nat/linux-namespaces.h: Rename include guard.
4547         * nat/linux-btrace.h: Rename include guard.
4548         * nat/glibc_thread_db.h: Rename include guard.
4549         * nat/gdb_thread_db.h: Rename include guard.
4550         * nat/gdb_ptrace.h: Rename include guard.
4551         * nat/fork-inferior.h: Rename include guard.
4552         * nat/amd64-linux-siginfo.h: Rename include guard.
4553         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4554         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4555         * nat/aarch64-linux.h: Rename include guard.
4556         * nat/aarch64-linux-hw-point.h: Rename include guard.
4557         * mn10300-tdep.h: Add include guard.
4558         * mips-linux-tdep.h: Add include guard.
4559         * mi/mi-parse.h: Rename include guard.
4560         * mi/mi-out.h: Rename include guard.
4561         * mi/mi-main.h: Rename include guard.
4562         * mi/mi-interp.h: Rename include guard.
4563         * mi/mi-getopt.h: Rename include guard.
4564         * mi/mi-console.h: Rename include guard.
4565         * mi/mi-common.h: Rename include guard.
4566         * mi/mi-cmds.h: Rename include guard.
4567         * mi/mi-cmd-break.h: Rename include guard.
4568         * m2-lang.h: Add include guard.
4569         * location.h: Rename include guard.
4570         * linux-record.h: Rename include guard.
4571         * linux-nat.h: Add include guard.
4572         * linux-fork.h: Add include guard.
4573         * i386-darwin-tdep.h: Rename include guard.
4574         * hppa-linux-offsets.h: Add include guard.
4575         * guile/guile.h: Rename include guard.
4576         * guile/guile-internal.h: Rename include guard.
4577         * gnu-nat.h: Rename include guard.
4578         * gdb-stabs.h: Rename include guard.
4579         * frv-tdep.h: Add include guard.
4580         * f-lang.h: Add include guard.
4581         * event-loop.h: Add include guard.
4582         * darwin-nat.h: Rename include guard.
4583         * cp-abi.h: Rename include guard.
4584         * config/sparc/nm-sol2.h: Rename include guard.
4585         * config/nm-nto.h: Rename include guard.
4586         * config/nm-linux.h: Add include guard.
4587         * config/i386/nm-i386gnu.h: Rename include guard.
4588         * config/djgpp/nl_types.h: Rename include guard.
4589         * config/djgpp/langinfo.h: Rename include guard.
4590         * compile/gcc-cp-plugin.h: Add include guard.
4591         * compile/gcc-c-plugin.h: Add include guard.
4592         * compile/compile.h: Rename include guard.
4593         * compile/compile-object-run.h: Rename include guard.
4594         * compile/compile-object-load.h: Rename include guard.
4595         * compile/compile-internal.h: Rename include guard.
4596         * compile/compile-cplus.h: Rename include guard.
4597         * compile/compile-c.h: Rename include guard.
4598         * common/xml-utils.h: Rename include guard.
4599         * common/x86-xstate.h: Rename include guard.
4600         * common/version.h: Rename include guard.
4601         * common/vec.h: Rename include guard.
4602         * common/tdesc.h: Rename include guard.
4603         * common/selftest.h: Rename include guard.
4604         * common/scoped_restore.h: Rename include guard.
4605         * common/scoped_mmap.h: Rename include guard.
4606         * common/scoped_fd.h: Rename include guard.
4607         * common/safe-iterator.h: Rename include guard.
4608         * common/run-time-clock.h: Rename include guard.
4609         * common/refcounted-object.h: Rename include guard.
4610         * common/queue.h: Rename include guard.
4611         * common/ptid.h: Rename include guard.
4612         * common/print-utils.h: Rename include guard.
4613         * common/preprocessor.h: Rename include guard.
4614         * common/pathstuff.h: Rename include guard.
4615         * common/observable.h: Rename include guard.
4616         * common/netstuff.h: Rename include guard.
4617         * common/job-control.h: Rename include guard.
4618         * common/host-defs.h: Rename include guard.
4619         * common/gdb_wait.h: Rename include guard.
4620         * common/gdb_vecs.h: Rename include guard.
4621         * common/gdb_unlinker.h: Rename include guard.
4622         * common/gdb_unique_ptr.h: Rename include guard.
4623         * common/gdb_tilde_expand.h: Rename include guard.
4624         * common/gdb_sys_time.h: Rename include guard.
4625         * common/gdb_string_view.h: Rename include guard.
4626         * common/gdb_splay_tree.h: Rename include guard.
4627         * common/gdb_setjmp.h: Rename include guard.
4628         * common/gdb_ref_ptr.h: Rename include guard.
4629         * common/gdb_optional.h: Rename include guard.
4630         * common/gdb_locale.h: Rename include guard.
4631         * common/gdb_assert.h: Rename include guard.
4632         * common/filtered-iterator.h: Rename include guard.
4633         * common/filestuff.h: Rename include guard.
4634         * common/fileio.h: Rename include guard.
4635         * common/environ.h: Rename include guard.
4636         * common/common-utils.h: Rename include guard.
4637         * common/common-types.h: Rename include guard.
4638         * common/common-regcache.h: Rename include guard.
4639         * common/common-inferior.h: Rename include guard.
4640         * common/common-gdbthread.h: Rename include guard.
4641         * common/common-exceptions.h: Rename include guard.
4642         * common/common-defs.h: Rename include guard.
4643         * common/common-debug.h: Rename include guard.
4644         * common/cleanups.h: Rename include guard.
4645         * common/buffer.h: Rename include guard.
4646         * common/btrace-common.h: Rename include guard.
4647         * common/break-common.h: Rename include guard.
4648         * cli/cli-utils.h: Rename include guard.
4649         * cli/cli-style.h: Rename include guard.
4650         * cli/cli-setshow.h: Rename include guard.
4651         * cli/cli-script.h: Rename include guard.
4652         * cli/cli-interp.h: Rename include guard.
4653         * cli/cli-decode.h: Rename include guard.
4654         * cli/cli-cmds.h: Rename include guard.
4655         * charset-list.h: Add include guard.
4656         * buildsym-legacy.h: Rename include guard.
4657         * bfin-tdep.h: Add include guard.
4658         * ax.h: Rename include guard.
4659         * arm-linux-tdep.h: Add include guard.
4660         * arm-fbsd-tdep.h: Add include guard.
4661         * arch/xtensa.h: Rename include guard.
4662         * arch/tic6x.h: Add include guard.
4663         * arch/i386.h: Add include guard.
4664         * arch/arm.h: Rename include guard.
4665         * arch/arm-linux.h: Rename include guard.
4666         * arch/arm-get-next-pcs.h: Rename include guard.
4667         * arch/amd64.h: Add include guard.
4668         * arch/aarch64-insn.h: Rename include guard.
4669         * arch-utils.h: Rename include guard.
4670         * annotate.h: Add include guard.
4671         * amd64-darwin-tdep.h: Rename include guard.
4672         * aarch64-linux-tdep.h: Add include guard.
4673         * aarch64-fbsd-tdep.h: Add include guard.
4674         * aarch32-linux-nat.h: Add include guard.
4675
4676 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4677
4678         * macrotab.c (macro_define_internal): New function that
4679         factorizes macro_define_object_internal and macro_define_function
4680         code.
4681         (macro_define_object_internal): Use macro_define_internal.
4682         (macro_define_function): Likewise.
4683
4684 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4685
4686         * macrocmd.c (extract_identifier): Return
4687         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4688         callers.
4689
4690 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4691
4692         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4693
4694 2019-02-05  Tom Tromey  <tom@tromey.com>
4695
4696         * target.c (target_stack::unpush): Move assertion earlier.
4697
4698 2019-01-30  Tom Tromey  <tom@tromey.com>
4699
4700         PR python/23615:
4701         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4702         (gdbpy_parse_and_eval): Likewise.
4703         * python/python-internal.h (gdbpy_allow_threads): New class.
4704
4705 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4706
4707         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4708         (aarch64_fbsd_fpregmap): Move earlier.
4709         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4710         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4711         instead of individual calls to trad_frame_set_reg_addr.
4712         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4713         earlier.
4714         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4715         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4716         instead of individual calls to trad_frame_set_reg_addr.
4717
4718 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4719
4720         * CONTRIBUTE: Replace contribution list with wiki link.
4721
4722 2019-01-25  Tom Tromey  <tom@tromey.com>
4723
4724         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4725
4726 2019-01-25  Tom Tromey  <tom@tromey.com>
4727
4728         * xtensa-linux-nat.c: Fix common/ includes.
4729         * xml-support.h: Fix common/ includes.
4730         * xml-support.c: Fix common/ includes.
4731         * x86-linux-nat.c: Fix common/ includes.
4732         * windows-nat.c: Fix common/ includes.
4733         * varobj.h: Fix common/ includes.
4734         * varobj.c: Fix common/ includes.
4735         * value.c: Fix common/ includes.
4736         * valops.c: Fix common/ includes.
4737         * utils.c: Fix common/ includes.
4738         * unittests/xml-utils-selftests.c: Fix common/ includes.
4739         * unittests/utils-selftests.c: Fix common/ includes.
4740         * unittests/unpack-selftests.c: Fix common/ includes.
4741         * unittests/tracepoint-selftests.c: Fix common/ includes.
4742         * unittests/style-selftests.c: Fix common/ includes.
4743         * unittests/string_view-selftests.c: Fix common/ includes.
4744         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4745         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4746         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4747         * unittests/rsp-low-selftests.c: Fix common/ includes.
4748         * unittests/parse-connection-spec-selftests.c: Fix common/
4749         includes.
4750         * unittests/optional-selftests.c: Fix common/ includes.
4751         * unittests/offset-type-selftests.c: Fix common/ includes.
4752         * unittests/observable-selftests.c: Fix common/ includes.
4753         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4754         * unittests/memrange-selftests.c: Fix common/ includes.
4755         * unittests/memory-map-selftests.c: Fix common/ includes.
4756         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4757         * unittests/function-view-selftests.c: Fix common/ includes.
4758         * unittests/environ-selftests.c: Fix common/ includes.
4759         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4760         * unittests/common-utils-selftests.c: Fix common/ includes.
4761         * unittests/cli-utils-selftests.c: Fix common/ includes.
4762         * unittests/array-view-selftests.c: Fix common/ includes.
4763         * ui-file.c: Fix common/ includes.
4764         * tui/tui-io.c: Fix common/ includes.
4765         * tracepoint.h: Fix common/ includes.
4766         * tracepoint.c: Fix common/ includes.
4767         * tracefile-tfile.c: Fix common/ includes.
4768         * top.h: Fix common/ includes.
4769         * top.c: Fix common/ includes.
4770         * thread.c: Fix common/ includes.
4771         * target/waitstatus.h: Fix common/ includes.
4772         * target/waitstatus.c: Fix common/ includes.
4773         * target.h: Fix common/ includes.
4774         * target.c: Fix common/ includes.
4775         * target-memory.c: Fix common/ includes.
4776         * target-descriptions.c: Fix common/ includes.
4777         * symtab.h: Fix common/ includes.
4778         * symfile.c: Fix common/ includes.
4779         * stap-probe.c: Fix common/ includes.
4780         * spu-linux-nat.c: Fix common/ includes.
4781         * sparc-nat.c: Fix common/ includes.
4782         * source.c: Fix common/ includes.
4783         * solib.c: Fix common/ includes.
4784         * solib-target.c: Fix common/ includes.
4785         * ser-unix.c: Fix common/ includes.
4786         * ser-tcp.c: Fix common/ includes.
4787         * ser-pipe.c: Fix common/ includes.
4788         * ser-base.c: Fix common/ includes.
4789         * selftest-arch.c: Fix common/ includes.
4790         * s12z-tdep.c: Fix common/ includes.
4791         * rust-exp.y: Fix common/ includes.
4792         * rs6000-aix-tdep.c: Fix common/ includes.
4793         * riscv-tdep.c: Fix common/ includes.
4794         * remote.c: Fix common/ includes.
4795         * remote-notif.h: Fix common/ includes.
4796         * remote-fileio.h: Fix common/ includes.
4797         * remote-fileio.c: Fix common/ includes.
4798         * regcache.h: Fix common/ includes.
4799         * regcache.c: Fix common/ includes.
4800         * record-btrace.c: Fix common/ includes.
4801         * python/python.c: Fix common/ includes.
4802         * python/py-type.c: Fix common/ includes.
4803         * python/py-inferior.c: Fix common/ includes.
4804         * progspace.h: Fix common/ includes.
4805         * producer.c: Fix common/ includes.
4806         * procfs.c: Fix common/ includes.
4807         * proc-api.c: Fix common/ includes.
4808         * printcmd.c: Fix common/ includes.
4809         * ppc-linux-nat.c: Fix common/ includes.
4810         * parser-defs.h: Fix common/ includes.
4811         * osdata.c: Fix common/ includes.
4812         * obsd-nat.c: Fix common/ includes.
4813         * nat/x86-linux.c: Fix common/ includes.
4814         * nat/x86-linux-dregs.c: Fix common/ includes.
4815         * nat/x86-dregs.h: Fix common/ includes.
4816         * nat/x86-dregs.c: Fix common/ includes.
4817         * nat/ppc-linux.c: Fix common/ includes.
4818         * nat/mips-linux-watch.h: Fix common/ includes.
4819         * nat/mips-linux-watch.c: Fix common/ includes.
4820         * nat/linux-waitpid.c: Fix common/ includes.
4821         * nat/linux-ptrace.h: Fix common/ includes.
4822         * nat/linux-ptrace.c: Fix common/ includes.
4823         * nat/linux-procfs.c: Fix common/ includes.
4824         * nat/linux-personality.c: Fix common/ includes.
4825         * nat/linux-osdata.c: Fix common/ includes.
4826         * nat/linux-namespaces.c: Fix common/ includes.
4827         * nat/linux-btrace.h: Fix common/ includes.
4828         * nat/linux-btrace.c: Fix common/ includes.
4829         * nat/fork-inferior.c: Fix common/ includes.
4830         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4831         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4832         * nat/aarch64-linux.c: Fix common/ includes.
4833         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4834         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4835         * namespace.h: Fix common/ includes.
4836         * mips-linux-tdep.c: Fix common/ includes.
4837         * minsyms.c: Fix common/ includes.
4838         * mi/mi-parse.h: Fix common/ includes.
4839         * mi/mi-main.c: Fix common/ includes.
4840         * mi/mi-cmd-env.c: Fix common/ includes.
4841         * memrange.h: Fix common/ includes.
4842         * memattr.c: Fix common/ includes.
4843         * maint.h: Fix common/ includes.
4844         * maint.c: Fix common/ includes.
4845         * main.c: Fix common/ includes.
4846         * machoread.c: Fix common/ includes.
4847         * location.c: Fix common/ includes.
4848         * linux-thread-db.c: Fix common/ includes.
4849         * linux-nat.c: Fix common/ includes.
4850         * linux-fork.c: Fix common/ includes.
4851         * inline-frame.c: Fix common/ includes.
4852         * infrun.c: Fix common/ includes.
4853         * inflow.c: Fix common/ includes.
4854         * inferior.h: Fix common/ includes.
4855         * inferior.c: Fix common/ includes.
4856         * infcmd.c: Fix common/ includes.
4857         * inf-ptrace.c: Fix common/ includes.
4858         * inf-child.c: Fix common/ includes.
4859         * ia64-linux-nat.c: Fix common/ includes.
4860         * i387-tdep.c: Fix common/ includes.
4861         * i386-tdep.c: Fix common/ includes.
4862         * i386-linux-tdep.c: Fix common/ includes.
4863         * i386-linux-nat.c: Fix common/ includes.
4864         * i386-go32-tdep.c: Fix common/ includes.
4865         * i386-fbsd-tdep.c: Fix common/ includes.
4866         * i386-fbsd-nat.c: Fix common/ includes.
4867         * guile/scm-type.c: Fix common/ includes.
4868         * guile/guile.c: Fix common/ includes.
4869         * go32-nat.c: Fix common/ includes.
4870         * gnu-nat.c: Fix common/ includes.
4871         * gdbthread.h: Fix common/ includes.
4872         * gdbarch-selftests.c: Fix common/ includes.
4873         * gdb_usleep.c: Fix common/ includes.
4874         * gdb_select.h: Fix common/ includes.
4875         * gdb_bfd.c: Fix common/ includes.
4876         * gcore.c: Fix common/ includes.
4877         * fork-child.c: Fix common/ includes.
4878         * findvar.c: Fix common/ includes.
4879         * fbsd-nat.c: Fix common/ includes.
4880         * event-top.c: Fix common/ includes.
4881         * event-loop.c: Fix common/ includes.
4882         * dwarf2read.c: Fix common/ includes.
4883         * dwarf2loc.c: Fix common/ includes.
4884         * dwarf2-frame.c: Fix common/ includes.
4885         * dwarf-index-cache.c: Fix common/ includes.
4886         * dtrace-probe.c: Fix common/ includes.
4887         * disasm-selftests.c: Fix common/ includes.
4888         * defs.h: Fix common/ includes.
4889         * csky-tdep.c: Fix common/ includes.
4890         * cp-valprint.c: Fix common/ includes.
4891         * cp-support.h: Fix common/ includes.
4892         * cp-support.c: Fix common/ includes.
4893         * corelow.c: Fix common/ includes.
4894         * completer.h: Fix common/ includes.
4895         * completer.c: Fix common/ includes.
4896         * compile/compile.c: Fix common/ includes.
4897         * compile/compile-loc2c.c: Fix common/ includes.
4898         * compile/compile-cplus-types.c: Fix common/ includes.
4899         * compile/compile-cplus-symbols.c: Fix common/ includes.
4900         * command.h: Fix common/ includes.
4901         * cli/cli-dump.c: Fix common/ includes.
4902         * cli/cli-cmds.c: Fix common/ includes.
4903         * charset.c: Fix common/ includes.
4904         * build-id.c: Fix common/ includes.
4905         * btrace.h: Fix common/ includes.
4906         * btrace.c: Fix common/ includes.
4907         * breakpoint.h: Fix common/ includes.
4908         * breakpoint.c: Fix common/ includes.
4909         * ax.h:
4910         (enum agent_op): Fix common/ includes.
4911         * ax-general.c (struct aop_map): Fix common/ includes.
4912         * ax-gdb.c: Fix common/ includes.
4913         * auxv.c: Fix common/ includes.
4914         * auto-load.c: Fix common/ includes.
4915         * arm-tdep.c: Fix common/ includes.
4916         * arch/riscv.c: Fix common/ includes.
4917         * arch/ppc-linux-common.c: Fix common/ includes.
4918         * arch/i386.c: Fix common/ includes.
4919         * arch/arm.c: Fix common/ includes.
4920         * arch/arm-linux.c: Fix common/ includes.
4921         * arch/arm-get-next-pcs.c: Fix common/ includes.
4922         * arch/amd64.c: Fix common/ includes.
4923         * arch/aarch64.c: Fix common/ includes.
4924         * arch/aarch64-insn.c: Fix common/ includes.
4925         * arch-utils.c: Fix common/ includes.
4926         * amd64-windows-tdep.c: Fix common/ includes.
4927         * amd64-tdep.c: Fix common/ includes.
4928         * amd64-sol2-tdep.c: Fix common/ includes.
4929         * amd64-obsd-tdep.c: Fix common/ includes.
4930         * amd64-nbsd-tdep.c: Fix common/ includes.
4931         * amd64-linux-tdep.c: Fix common/ includes.
4932         * amd64-linux-nat.c: Fix common/ includes.
4933         * amd64-fbsd-tdep.c: Fix common/ includes.
4934         * amd64-fbsd-nat.c: Fix common/ includes.
4935         * amd64-dicos-tdep.c: Fix common/ includes.
4936         * amd64-darwin-tdep.c: Fix common/ includes.
4937         * agent.c: Fix common/ includes.
4938         * ada-lang.h: Fix common/ includes.
4939         * ada-lang.c: Fix common/ includes.
4940         * aarch64-tdep.c: Fix common/ includes.
4941
4942 2019-01-25  Tom Tromey  <tom@tromey.com>
4943
4944         * common/create-version.sh: Use common/version.h.
4945
4946 2019-01-24  Pedro Alves  <palves@redhat.com>
4947
4948         * infrun.c (signal_stop, signal_print, signal_program)
4949         (signal_catch, signal_pass): Now arrays instead of pointers.
4950         (update_signals_program_target, do_target_resume)
4951         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4952         * linux-nat.c (linux_nat_target::pass_signals)
4953         (linux_nat_target::create_inferior, linux_nat_target::attach):
4954         Adjust.
4955         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4956         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4957         * procfs.c (procfs_target::pass_signals): Adjust.
4958         * record-full.c (record_full_target::resume): Adjust.
4959         * remote.c (remote_target::pass_signals)
4960         (remote_target::program_signals): Adjust.
4961         * target-debug.h (target_debug_print_signals): Now takes a
4962         gdb::array_view as parameter.  Adjust.
4963         * target.h (target_ops) <pass_signals, program_signals>: Replace
4964         pointer and length parameters with gdb::array_view.
4965         (target_pass_signals, target_program_signals): Likewise.
4966         * target-delegates.c: Regenerate.
4967
4968 2019-01-24  Pedro Alves  <palves@redhat.com>
4969
4970         * common/forward-scope-exit.h
4971         (forward_scope_exit::forward_scope_exit): Pass arguments to
4972         m_bind_function directly, instead of creating a std::bind and
4973         copying that.
4974
4975 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4976
4977         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4978         for static members.
4979         (pass_in_v_vfp_candidate): Likewise.
4980
4981 2019-01-23  Tom Tromey  <tom@tromey.com>
4982             Pedro Alves  <palves@redhat.com>
4983
4984         * regcache.c (class regcache_invalidator): Remove.
4985         (regcache::raw_write): Use make_scope_exit.
4986
4987 2019-01-23  Tom Tromey  <tom@tromey.com>
4988
4989         * ui-out.h (class ui_out_emit_type): Update comment.
4990
4991 2019-01-23  Tom Tromey  <tom@tromey.com>
4992
4993         * infrun.c (fetch_inferior_event): Update comment.
4994
4995 2019-01-23  Tom Tromey  <tom@tromey.com>
4996             Pedro Alves  <palves@redhat.com>
4997
4998         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4999         parameter.
5000         (fetch_inferior_event): Use SCOPE_EXIT.
5001
5002
5003 2019-01-23  Tom Tromey  <tom@tromey.com>
5004             Pedro Alves  <palves@redhat.com>
5005
5006         * infrun.c (disable_thread_events): Delete.
5007         (stop_all_threads): Use SCOPE_EXIT.
5008
5009 2019-01-23  Tom Tromey  <tom@tromey.com>
5010             Pedro Alves  <palves@redhat.com>
5011
5012         * symfile.c: Include forward-scope-exit.h.
5013         (clear_symtab_users_cleanup): Replace forward declaration with
5014         a FORWARD_SCOPE_EXIT.
5015         (syms_from_objfile_1): Use the forward_scope_exit and
5016         gdb::optional instead of cleanup_function.
5017         (reread_symbols): Use the forward_scope_exit instead of
5018         cleanup_function.
5019         (clear_symtab_users_cleanup): Remove function.
5020
5021 2019-01-23  Tom Tromey  <tom@tromey.com>
5022             Pedro Alves  <palves@redhat.com>
5023
5024         * linux-nat.c: Include scope-exit.h.
5025         (cleanup_target_stop): Remove.
5026         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5027         SCOPE_EXIT.
5028
5029 2019-01-23  Tom Tromey  <tom@tromey.com>
5030             Pedro Alves  <palves@redhat.com>
5031
5032         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5033         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5034
5035 2019-01-23  Tom Tromey  <tom@tromey.com>
5036             Andrew Burgess  <andrew.burgess@embecosm.com>
5037             Pedro Alves  <palves@redhat.com>
5038
5039         * infrun.c (fetch_inferior_event): Use scope_exit.
5040         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5041         * top.c (execute_command): Use scope_exit.
5042         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5043         * utils.c (do_bpstat_clear_actions_cleanup)
5044         (make_bpstat_clear_actions_cleanup): Remove.
5045
5046 2019-01-23  Tom Tromey  <tom@tromey.com>
5047             Pedro Alves  <palves@redhat.com>
5048
5049         * infrun.c: Include "common/scope-exit.h"
5050         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5051         (wait_for_inferior): Use SCOPE_EXIT.
5052         (fetch_inferior_event): Use scope_exit.
5053
5054 2019-01-23  Tom Tromey  <tom@tromey.com>
5055             Pedro Alves  <palves@redhat.com>
5056
5057         * breakpoint.c (create_breakpoint): Remove cleanup.
5058
5059 2019-01-23  Tom Tromey  <tom@tromey.com>
5060             Andrew Burgess  <andrew.burgess@embecosm.com>
5061             Pedro Alves  <palves@redhat.com>
5062
5063 2019-01-23  Pedro Alves  <palves@redhat.com>
5064
5065         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5066
5067 2019-01-23  Pedro Alves  <palves@redhat.com>
5068             Andrew Burgess  <andrew.burgess@embecosm.com>
5069
5070         * gdbthread.h: Include "common/forward-scope-exit.h".
5071         (scoped_finish_thread_state): Redefine custom class in terms of
5072         forward_scope_exit.
5073
5074 2019-01-23  Pedro Alves  <palves@redhat.com>
5075             Andrew Burgess  <andrew.burgess@embecosm.com>
5076
5077         * common/forward-scope-exit.h: New file.
5078
5079 2019-01-23  Pedro Alves  <palves@redhat.com>
5080             Andrew Burgess  <andrew.burgess@embecosm.com>
5081             Tom Tromey  <tom@tromey.com>
5082
5083         * common/scope-exit.h: New file.
5084
5085 2019-01-23  Pedro Alves  <palves@redhat.com>
5086
5087         * common/preprocessor.h (ESC): Rename to ...
5088         (ESC_PARENS): ... this.
5089         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5090         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5091
5092 2019-01-23  Tom Tromey  <tom@tromey.com>
5093
5094         * language.h (class scoped_switch_to_sym_language_if_auto):
5095         Initialize m_lang in both cases.
5096
5097 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5098
5099         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5100         with XCNEW.
5101
5102 2019-01-22  Tom Tromey  <tom@tromey.com>
5103
5104         * corelow.c: Do not include sys/file.h.
5105
5106 2019-01-22  Tom Tromey  <tom@tromey.com>
5107
5108         * tui/tui-wingeneral.h: Include gdb_curses.h.
5109
5110 2019-01-22  Tom Tromey  <tom@tromey.com>
5111
5112         * source-cache.h (class source_cache) <get_source_lines,
5113         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5114
5115 2019-01-22  Tom Tromey  <tom@tromey.com>
5116
5117         * remote-fileio.h (struct remote_target): Declare.
5118
5119 2019-01-22  Tom Tromey  <tom@tromey.com>
5120
5121         * python/py-arch.c: Do not include py-ref.h.
5122         * python/py-bpevent.c: Do not include py-ref.h.
5123         * python/py-cmd.c: Do not include py-ref.h.
5124         * python/py-continueevent.c: Do not include py-ref.h.
5125         * python/py-event.h: Do not include py-ref.h.
5126         * python/py-evtregistry.c: Do not include py-ref.h.
5127         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5128         * python/py-frame.c: Do not include py-ref.h.
5129         * python/py-framefilter.c: Do not include py-ref.h.
5130         * python/py-function.c: Do not include py-ref.h.
5131         * python/py-infevents.c: Do not include py-ref.h.
5132         * python/py-linetable.c: Do not include py-ref.h.
5133         * python/py-objfile.c: Do not include py-ref.h.
5134         * python/py-param.c: Do not include py-ref.h.
5135         * python/py-prettyprint.c: Do not include py-ref.h.
5136         * python/py-progspace.c: Do not include py-ref.h.
5137         * python/py-symbol.c: Do not include py-ref.h.
5138         * python/py-symtab.c: Do not include py-ref.h.
5139         * python/py-type.c: Do not include py-ref.h.
5140         * python/py-unwind.c: Do not include py-ref.h.
5141         * python/py-utils.c: Do not include py-ref.h.
5142         * python/py-value.c: Do not include py-ref.h.
5143         * python/py-varobj.c: Do not include py-ref.h.
5144         * python/py-xmethods.c: Do not include py-ref.h.
5145         * python/python.c: Do not include py-ref.h.
5146         * varobj.c: Do not include py-ref.h.
5147
5148 2019-01-22  Tom Tromey  <tom@tromey.com>
5149
5150         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5151         keyword for bcache.
5152
5153 2019-01-22  Tom Tromey  <tom@tromey.com>
5154
5155         * compile/compile-cplus-types.c: Remove a comment by #include.
5156
5157 2019-01-22  Tom Tromey  <tom@tromey.com>
5158
5159         * compile/gcc-c-plugin.h: Include compile-internal.h.
5160
5161 2019-01-22  Tom Tromey  <tom@tromey.com>
5162
5163         * stabsread.c (EXTERN): Do not define.
5164         (symnum, next_symbol_text_func, processing_gcc_compilation)
5165         (within_function, global_sym_chain, global_stabs)
5166         (previous_stab_code, this_object_header_files)
5167         (n_this_object_header_files)
5168         (n_allocated_this_object_header_files): Define.
5169         * stabsread.h (EXTERN): Never define.  Use "extern".
5170
5171 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5172
5173         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5174         history_value.
5175
5176 2019-01-21  Tom Tromey  <tom@tromey.com>
5177
5178         * ui-out.c: Fix includes.
5179         * tui/tui-source.c: Fix includes.
5180         * target.c: Fix includes.
5181         * remote.c: Fix includes.
5182         * regcache.c: Fix includes.
5183         * python/py-block.c: Fix includes.
5184         * printcmd.c: Fix includes.
5185         * or1k-tdep.c: Fix includes.
5186         * mi/mi-main.c: Fix includes.
5187         * m32r-tdep.c: Fix includes.
5188         * csky-tdep.c: Fix includes.
5189         * compile/compile-cplus-types.c: Fix includes.
5190         * cli/cli-interp.c: Fix includes.
5191
5192 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5193
5194         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5195         for padding.
5196
5197 2019-01-16  Tom Tromey  <tom@tromey.com>
5198
5199         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5200         earlier.
5201         (struct objfile) <msymbols_range>: Move from top level.
5202         <msymbols>: New method.
5203         (class objfile_msymbols): Remove.
5204         * symtab.c (default_collect_symbol_completion_matches_break_on):
5205         Update.
5206         * symmisc.c (dump_msymbols): Update.
5207         * stabsread.c (scan_file_globals): Update.
5208         * objc-lang.c (info_selectors_command, info_classes_command)
5209         (find_methods): Update.
5210         * minsyms.c (find_solib_trampoline_target): Update.
5211         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5212         * coffread.c (coff_symfile_read): Update.
5213         * ada-lang.c (ada_lookup_simple_minsym)
5214         (ada_collect_symbol_completion_matches): Update.
5215
5216 2019-01-16  Tom Tromey  <tom@tromey.com>
5217
5218         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5219         type.  Remove no-argument constructor.
5220         <iterator::operator++>: Simplify.
5221         <begin>: Update.
5222         <end>: Use minimal_symbol_count.
5223
5224 2019-01-16  Tom Tromey  <tom@tromey.com>
5225
5226         * objfiles.h (struct objfile) <psymtabs>: New method.
5227         (class objfile_psymtabs): Remove.
5228         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5229         typedef.
5230         <range>: New method.
5231         (require_partial_symbols): Change return type.
5232         * psymtab.c (require_partial_symbols)
5233         (psym_expand_symtabs_matching): Update.
5234         * mdebugread.c (parse_partial_symbols): Update.
5235         * dbxread.c (dbx_end_psymtab): Update.
5236
5237 2019-01-15  Tom Tromey  <tom@tromey.com>
5238
5239         * symtab.c (lookup_objfile_from_block)
5240         (lookup_symbol_in_objfile_symtabs)
5241         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5242         (find_line_symtab, info_sources_command)
5243         (default_collect_symbol_completion_matches_break_on)
5244         (make_source_files_completion_list): Update.
5245         * symmisc.c (print_objfile_statistics, dump_objfile)
5246         (maintenance_print_symbols, maintenance_info_symtabs)
5247         (maintenance_check_symtabs, maintenance_info_line_tables):
5248         Update.
5249         * source.c (select_source_symtab)
5250         (forget_cached_source_info_for_objfile): Update.
5251         * objfiles.h (class objfile_compunits): Remove.
5252         (struct objfile) <compunits_range>: New typedef.
5253         (compunits): New method.
5254         * objfiles.c (objfile_relocate1): Update.
5255         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5256         * maint.c (count_symtabs_and_blocks): Update.
5257         * linespec.c (iterate_over_all_matching_symtabs): Update.
5258         * cp-support.c (add_symbol_overload_list_qualified): Update.
5259         * coffread.c (coff_symtab_read): Update.
5260         * ada-lang.c (add_nonlocal_symbols)
5261         (ada_collect_symbol_completion_matches)
5262         (ada_add_global_exceptions): Update.
5263
5264 2019-01-15  Tom Tromey  <tom@tromey.com>
5265
5266         * progspace.h (program_space) <objfiles_safe_range>: New
5267         typedef.
5268         <objfiles_safe>: New method.
5269         * objfiles.h (class all_objfiles_safe): Remove.
5270         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5271         * jit.c (jit_inferior_exit_hook): Update.
5272
5273 2019-01-17  Tom Tromey  <tom@tromey.com>
5274
5275         * progspace.h (program_space) <objfiles_range>: New typedef.
5276         <objfiles>: New method.
5277         <objfiles_head>: Rename from objfiles.
5278         (object_files): Update.
5279         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5280         * guile/scm-pretty-print.c
5281         (ppscm_find_pretty_printer_from_objfiles): Update.
5282         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5283         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5284         Update.
5285         * python/py-progspace.c (pspy_get_objfiles): Update.
5286         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5287         Update.
5288         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5289         (objfpy_lookup_objfile_by_build_id): Update.
5290         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5291         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5292         Update.
5293         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5294         (expand_symtab_containing_pc, lookup_objfile_from_block)
5295         (lookup_static_symbol, basic_lookup_transparent_type)
5296         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5297         (find_line_symtab, info_sources_command)
5298         (default_collect_symbol_completion_matches_break_on)
5299         (make_source_files_completion_list, find_main_name): Update.
5300         * symmisc.c (print_symbol_bcache_statistics)
5301         (print_objfile_statistics, maintenance_print_symbols)
5302         (maintenance_print_msymbols, maintenance_print_objfiles)
5303         (maintenance_info_symtabs, maintenance_check_symtabs)
5304         (maintenance_expand_symtabs, maintenance_info_line_tables):
5305         Update.
5306         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5307         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5308         (map_overlay_command, unmap_overlay_command)
5309         (simple_overlay_update, expand_symtabs_matching)
5310         (map_symbol_filenames): Update.
5311         * symfile-debug.c (set_debug_symfile): Update.
5312         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5313         Update.
5314         * source.c (select_source_symtab, forget_cached_source_info):
5315         Update.
5316         * solib.c (solib_read_symbols): Update.
5317         * solib-spu.c (append_ocl_sos): Update.
5318         * psymtab.c (maintenance_print_psymbols)
5319         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5320         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5321         * printcmd.c (info_symbol_command): Update.
5322         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5323         Update.
5324         * objfiles.h (class all_objfiles): Remove.
5325         * objfiles.c (have_partial_symbols, have_full_symbols)
5326         (have_minimal_symbols, qsort_cmp, update_section_map)
5327         (shared_objfile_contains_address_p)
5328         (default_iterate_over_objfiles_in_search_order): Update.
5329         * objc-lang.c (info_selectors_command, info_classes_command)
5330         (find_methods): Update.
5331         * minsyms.c (find_solib_trampoline_target): Update.
5332         * maint.c (maintenance_info_sections)
5333         (maintenance_translate_address, count_symtabs_and_blocks):
5334         Update.
5335         * main.c (captured_main_1): Update.
5336         * linux-thread-db.c (try_thread_db_load_from_pdir)
5337         (has_libpthread): Update.
5338         * linespec.c (iterate_over_all_matching_symtabs)
5339         (search_minsyms_for_name): Update.
5340         * jit.c (jit_find_objf_with_entry_addr): Update.
5341         * hppa-tdep.c (find_unwind_entry)
5342         (hppa_lookup_stub_minimal_symbol): Update.
5343         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5344         Update.
5345         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5346         (elf_gnu_ifunc_resolve_by_got): Update.
5347         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5348         * dwarf-index-write.c (save_gdb_index_command): Update.
5349         * cp-support.c (add_symbol_overload_list_qualified): Update.
5350         * breakpoint.c (create_overlay_event_breakpoint)
5351         (create_longjmp_master_breakpoint)
5352         (create_std_terminate_master_breakpoint)
5353         (create_exception_master_breakpoint): Update.
5354         * blockframe.c (find_pc_partial_function): Update.
5355         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5356         (ada_collect_symbol_completion_matches)
5357         (ada_add_global_exceptions): Update.
5358
5359 2019-01-17  Tom Tromey  <tom@tromey.com>
5360
5361         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5362         declare VEC.
5363         (solib_target_parse_libraries): Change return type.
5364         (library_list_start_segment, library_list_start_section)
5365         (library_list_end_library, library_list_start_library); Update.
5366         (solib_target_free_library_list): Remove.
5367         (solib_target_parse_libraries): Remove cleanup.  Change return
5368         type.
5369         (solib_target_current_sos): Update.
5370
5371 2019-01-17  Tom Tromey  <tromey@bapiya>
5372
5373         * valprint.c: Replace "the the" with "the".
5374         * symtab.c: Replace "the the" with "the".
5375         * solib.c: Replace "the the" with "the".
5376         * solib-dsbt.c: Replace "the the" with "the".
5377         * linespec.c: Replace "the the" with "the".
5378         * dwarf2loc.h: Replace "the the" with "the".
5379         * amd64-windows-tdep.c: Replace "the the" with "the".
5380         * aarch64-tdep.c: Replace "the the" with "the".
5381
5382 2019-01-16  Keith Seitz  <keiths@redhat.com>
5383
5384         PR gdb/23773
5385         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5386         <builder>: Rename to ..
5387         <m_builder>: ... this and make private.
5388         (dwarf2_cu::get_builder): New method.  Change all users of
5389         `builder' to use this method.
5390         (dwarf2_start_symtab): Move to ...
5391         (dwarf2_cu::start_symtab): ... here.  Update all callers
5392         (setup_type_unit_groups): Move to ...
5393         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5394         callers.
5395         (dwarf2_cu::reset_builder): New method.
5396         (process_full_compunit, process_full_type_unit): Use
5397         dwarf2_cu::reset_builder.
5398         (follow_die_offset): Record the ancestor CU if it is different
5399         from the followed DIE's CU.
5400         (follow_die_sig_1): Likewise.
5401
5402 2019-01-15  Tom Tromey  <tom@tromey.com>
5403
5404         * remote.c (class remote_state) <buf>: Now a char_vector.
5405         <buf_size>: Remove.
5406         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5407         parameter.
5408         (remote_target::getpkt_or_notif_sane_1)
5409         (remote_target::getpkt_sane)
5410         (remote_target::getpkt_or_notif_sane): Likewise.
5411         (class remote_target) <putpkt>: New overload.
5412         (remote_target::read_frame): Change type of "buf_p".  Remove
5413         sizeof_p parameter.
5414         (packet_ok): New overload.
5415         (packet_check_result): New overload.
5416         Update all uses.
5417
5418 2019-01-14  Tom Tromey  <tom@tromey.com>
5419
5420         * remote-notif.c (handle_notification, remote_notif_ack)
5421         (remote_notif_parse): Make "buf" const.
5422         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5423         const.
5424         (remote_notif_parse, remote_notif_ack, handle_notification):
5425         Likewise.
5426         * remote.c (remote_notif_stop_parse): Make "buf" const.
5427         (remote_target::remote_parse_stop_reply): Make "buf" const.
5428         (remote_notif_stop_ack): Make "buf" const.
5429
5430 2019-01-14  Tom Tromey  <tom@tromey.com>
5431
5432         * remote.c (remote_console_output): Make parameter const.
5433
5434 2019-01-14  Tom Tromey  <tom@tromey.com>
5435
5436         * target-debug.h (target_debug_print_signals): Constify.
5437         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5438         * procfs.c (procfs_target::pass_signals): Update.
5439         * linux-nat.c (linux_nat_target::pass_signals): Update.
5440         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5441         * target-delegates.c: Rebuild.
5442         * remote.c (remote_target::program_signals): Update.
5443         (remote_target::pass_signals): Update.
5444         * target.c (target_pass_signals): Constify argument.
5445         (target_program_signals): Likewise.
5446         * target.h (struct target_ops) <pass_signals, program_signals>:
5447         Constify argument.
5448         (target_pass_signals, target_program_signals): Constify argument.
5449
5450 2019-01-14  Tom Tromey  <tom@tromey.com>
5451
5452         PR tui/28819:
5453         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5454
5455 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5456
5457         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5458         field.
5459         * rs6000-tdep.c: Include reggroups.h.
5460         (IS_V_ALIAS_PSEUDOREG): Define.
5461         (rs6000_register_name): Return names for the "vX" aliases.
5462         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5463         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5464         aliases.  Call default_register_reggroup_p for all other
5465         pseudo-registers.
5466         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5467         New functions.
5468         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5469         Handle "vX" aliases.
5470         (v_alias_pseudo_register_collect): New function.
5471         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5472         (rs6000_gdbarch_init): Initialize "vX" aliases as
5473         pseudo-registers.  Restore registration of
5474         rs6000_pseudo_register_reggroup_p with
5475         set_tdesc_pseudo_register_reggroup_p.
5476
5477 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5478
5479         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5480         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5481         set_gdbarch_num_pseudo_regs.
5482
5483 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5484
5485         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5486         Remove arg prefixname, add do_set and do_show.
5487         Add member functions set_list and show_list.
5488         * cli/cli-style.c (class cli_style_option): Update accordingly.
5489         (style_set_list): Move to file scope.
5490         (style_show_list): Likewise.
5491         (set_style): Call help_list.
5492         (show_style): Call cmd_show_list.
5493         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5494         Update to use the new macro.
5495
5496 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5497
5498         * ada-lang.c (_initialize_ada_language): Expand the help text
5499         for the "catch exception" command.
5500
5501 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5502
5503         * symtab.c (matching_obj_sections): Initialize obj,
5504         declare it closer to its usage.
5505
5506 2019-01-10  Tom Tromey  <tom@tromey.com>
5507
5508         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5509         (basic_inf_threads_range): Remove.
5510         (inf_threads_range, inf_non_exited_threads_range)
5511         (safe_inf_threads_range): Use next_adapter.
5512
5513 2019-01-10  Keith Seitz  <keiths@redhat.com>
5514
5515         PR gdb/23712
5516         PR symtab/23010
5517         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5518         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5519
5520 2019-01-10  Keith Seitz  <keiths@redhat.com>
5521
5522         PR gdb/23712
5523         PR symtab/23010
5524         * dictionary.c (pending_to_vector): Remove.
5525         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5526         Remove _1 suffix, replacing functions of the same name.  Update
5527         all callers.
5528         (dict_create_hashed, dict_create_hashed_expandable)
5529         (dict_create_linear, dict_create_linear_expandable, dict_free)
5530         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5531         Make functions static.
5532
5533 2019-01-10  Keith Seitz  <keiths@redhat.com>
5534
5535         PR gdb/23712
5536         PR symtab/23010
5537         * dictionary.h (struct dictionary): Replace declaration with
5538         multidictionary.
5539         (dict_create_hashed, dict_create_hashed_expandable)
5540         (dict_create_linear, dict_create_linear_expandable)
5541         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5542         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5543         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5544         taking multidictionary argument.
5545         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5546         * block.h (struct block) <dict>: Change to multidictionary
5547         and rename `multidict'.
5548         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5549         symmisc.c: Update all dictionary references to multidictionary.
5550
5551 2019-01-10  Keith Seitz  <keiths@redhat.com>
5552
5553         PR gdb/23712
5554         PR symtab/23010
5555         * dictionary.c: Include unordered_map.
5556         (pending_to_vector): New function.
5557         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5558         Rewrite the non-"_1" functions to take vector instead
5559         of linked list.
5560         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5561         "new" _1 versions of the same name.
5562         (multidictionary): Define.
5563         (std::hash<enum language): New definition.
5564         (collate_pending_symbols_by_language, mdict_create_hashed)
5565         (mdict_create_hashed_expandable, mdict_create_linear)
5566         (mdict_create_linear_expandable, mdict_free)
5567         (find_language_dictionary, create_new_language_dictionary)
5568         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5569         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5570         (mdict_size, mdict_empty): New functions.
5571         * dictionary.h (mdict_iterator): Define.
5572
5573 2019-01-10  Pedro Alves  <palves@redhat.com>
5574
5575         * breakpoint.c (read_uploaded_action)
5576         (create_tracepoint_from_upload): Adjust to use
5577         gdb::unique_xmalloc_ptr.
5578         * ctf.c (ctf_write_uploaded_tp):
5579         (SET_ARRAY_FIELD): Use emplace_back.
5580         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5581         * tracefile-tfile.c (tfile_write_uploaded_tp):
5582         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5583         gdb::unique_xmalloc_ptr.
5584         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5585         at_string, cond_string, cmd_strings>: Replace char pointers
5586         with gdb::unique_xmalloc_ptr.
5587
5588 2019-01-10  Pedro Alves  <palves@redhat.com>
5589
5590         * solib-target.c (library_list_start_library): Don't xstrdup name.
5591
5592 2019-01-10  Pedro Alves  <palves@redhat.com>
5593
5594         * mdebugread.c (parse_partial_symbols): Use
5595         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5596
5597 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5598
5599         * linux-fork.c (scoped_switch_fork_info)
5600         <~scoped_switch_fork_info>: Fix incorrect variable name.
5601
5602 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5603
5604         * linux-fork.c (scoped_switch_fork_info)
5605         <scoped_switch_fork_info>: Make explicit.
5606         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5607
5608 2019-01-10  Tom Tromey  <tom@tromey.com>
5609
5610         * objfiles.h (objfile::reset_psymtabs): Update.
5611         * objfiles.c (objfile::objfile): Update.
5612         * psymtab.h (psymtab_storage::obstack): Update.
5613         (psymtab_storage::m_obstack): Use gdb::optional.
5614         (class psymtab_storage): Update comment.  Remove objfile
5615         parameter.
5616         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5617
5618 2019-01-10  Tom Tromey  <tom@tromey.com>
5619
5620         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5621         <free_psymtabs>: Now private.
5622         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5623         (allocate_psymtab): Use new method.
5624
5625 2019-01-10  Tom Tromey  <tom@tromey.com>
5626
5627         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5628         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5629         * mdebugread.c (parse_partial_symbols): Use
5630         allocate_dependencies.
5631         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5632         allocate_dependencies.
5633         (process_psymtab_comp_unit_reader)
5634         (build_type_psymtab_dependencies): Likewise.
5635         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5636
5637 2019-01-10  Tom Tromey  <tom@tromey.com>
5638
5639         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5640         PSYMBOL_SET_LANGUAGE.
5641         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5642
5643 2019-01-10  Tom Tromey  <tom@tromey.com>
5644
5645         * psymtab.h (psymtab_storage::obstack): New method.
5646         <m_obstack>: Rename from obstack; now private.
5647         * psymtab.c (psymtab_storage): Update.
5648         * dwarf2read.c (create_addrmap_from_index)
5649         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5650         Update.
5651
5652 2019-01-10  Tom Tromey  <tom@tromey.com>
5653
5654         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5655         * objfiles.h (objfile::reset_psymtabs): New method.
5656
5657 2019-01-10  Tom Tromey  <tom@tromey.com>
5658
5659         * symmisc.c (print_symbol_bcache_statistics): Update.
5660         (print_objfile_statistics): Update.
5661         * symfile.c (reread_symbols): Update.
5662         * psymtab.h (class psymtab_storage): New.
5663         * psymtab.c (psymtab_storage): New constructor.
5664         (~psymtab_storage): New destructor.
5665         (require_partial_symbols): Update.
5666         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5667         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5668         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5669         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5670         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5671         (start_psymtab_common, end_psymtab_common)
5672         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5673         (allocate_psymtab): Update.
5674         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5675         Update.
5676         (dump_psymtab_addrmap, maintenance_print_psymbols)
5677         (maintenance_check_psymtabs): Update.
5678         (class objfile_psymtabs): Move to objfiles.h.
5679         * psympriv.h (discard_psymtab): Now inline.
5680         (psymtab_discarder::psymtab_discarder): Update.
5681         (psymtab_discarder::~psymtab_discarder): Update.
5682         (ALL_OBJFILE_PSYMTABS): Rewrite.
5683         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5684         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5685         Remove fields.
5686         <partial_symtabs>: New field.
5687         (class objfile_psymtabs): Move from psymtab.h.  Update.
5688         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5689         psymbol_cache.
5690         (objfile::~objfile): Don't destroy psymbol_cache.
5691         * mdebugread.c (parse_partial_symbols): Update.
5692         * dwarf2read.c (create_addrmap_from_index)
5693         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5694         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5695         (add_partial_subprogram, dwarf2_ranges_read): Update.
5696         * dwarf-index-write.c (write_address_map)
5697         (write_one_signatured_type, recursively_write_psymbols)
5698         (class debug_names, class debug_names, write_psymtabs_to_index):
5699         Update.
5700
5701 2019-01-10  Tom Tromey  <tom@tromey.com>
5702
5703         * symtab.h (SYMBOL_SET_NAMES): Update.
5704         (symbol_set_names): Update.
5705         (MSYMBOL_SET_NAMES): Update.
5706         * symtab.c (symbol_set_names): Change argument to be an
5707         objfile_per_bfd_storage.
5708         * psymtab.c (add_psymbol_to_bcache): Update.
5709         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5710
5711 2019-01-10  Tom Tromey  <tom@tromey.com>
5712
5713         * symtab.c (create_demangled_names_hash): Change argument to be an
5714         objfile_per_bfd_storage.
5715         (symbol_set_names): Update.
5716
5717 2019-01-10  Tom Tromey  <tom@tromey.com>
5718
5719         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5720         init_psymbol_list.
5721         * psymtab.c (init_psymbol_list): Do nothing if already called.
5722         * psympriv.h (init_psymbol_list): Add comment.
5723         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5724         init_psymbol_list.
5725         * dbxread.c (dbx_symfile_read): Unconditionally call
5726         init_psymbol_list.
5727
5728 2019-01-10  Tom Tromey  <tom@tromey.com>
5729
5730         * xcoffread.c (scan_xcoff_symtab): Update.
5731         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5732         "where".
5733         * mdebugread.c (parse_partial_symbols)
5734         (handle_psymbol_enumerators): Update.
5735         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5736         * dbxread.c (read_dbx_symtab): Update.
5737         * psympriv.h (psymbol_placement): New enum.
5738         (add_psymbol_to_list): Update.
5739
5740 2019-01-10  Tom Tromey  <tom@tromey.com>
5741
5742         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5743         static_psymbols parameters.
5744         (scan_xcoff_symtab): Update.
5745         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5746         static_psymbols parameters.
5747         * psympriv.h (start_psymtab_common): Update.
5748         * mdebugread.c (parse_partial_symbols): Update.
5749         * dwarf2read.c (create_partial_symtab): Update.
5750         * dbxread.c (read_dbx_symtab): Update.
5751         (start_psymtab): Remove global_psymbols and static_psymbols
5752         parameters.
5753
5754 2019-01-10  Tom Tromey  <tom@tromey.com>
5755
5756         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5757         * psymtab.c (allocate_psymtab): Add comment.
5758         * psympriv.h (allocate_psymtab): Add comment.
5759         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5760         initializations.
5761         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5762
5763 2019-01-10  Tom Tromey  <tom@tromey.com>
5764
5765         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5766         Don't declare.
5767         * mipsread.c: Include mdebugread.h.
5768         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5769         Declare.
5770         * elfread.c: Include mdebugread.h.
5771
5772 2019-01-09  Tom Tromey  <tom@tromey.com>
5773
5774         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5775         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5776         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5777         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5778         (psym_lookup_symbol, psym_find_last_source_symtab)
5779         (psym_forget_cached_source_info, psym_print_stats)
5780         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5781         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5782         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5783         (psym_find_compunit_symtab_by_address)
5784         (maintenance_print_psymbols, maintenance_info_psymtabs)
5785         (maintenance_check_psymtabs): Use ranged for.
5786         * psymtab.h (class objfile_psymtabs): New.
5787         (require_partial_symbols): Return objfile_psymtabs.
5788         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5789
5790 2019-01-09  Tom Tromey  <tom@tromey.com>
5791
5792         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5793         (find_pc_mapped_section, list_overlays_command)
5794         (map_overlay_command, unmap_overlay_command)
5795         (simple_overlay_update): Use all_objfiles.
5796         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5797         * printcmd.c (info_symbol_command): Use all_objfiles.
5798         * objfiles.h (ALL_OBJSECTIONS): Remove.
5799         * maint.c (maintenance_translate_address): Use all_objfiles.
5800         * gcore.c (gcore_create_callback): Use all_objfiles.
5801         (objfile_find_memory_regions): Likewise.
5802
5803 2019-01-09  Tom Tromey  <tom@tromey.com>
5804
5805         * symtab.c (find_line_symtab, info_sources_command)
5806         (make_source_files_completion_list): Use objfile_compunits.
5807         * source.c (select_source_symtab): Use objfile_compunits.
5808         * objfiles.h (struct objfile): Update comment.
5809         (ALL_OBJFILES): Remove.
5810         (ALL_FILETABS): Remove.
5811         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5812         objfile_compunits.
5813
5814 2019-01-09  Tom Tromey  <tom@tromey.com>
5815
5816         * symmisc.c (print_objfile_statistics, dump_objfile)
5817         (maintenance_print_symbols): Use compunit_filetabs.
5818         * source.c (forget_cached_source_info_for_objfile): Use
5819         compunit_filetabs.
5820         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5821         (ALL_FILETABS): Use compunit_filetabs.
5822         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5823         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5824
5825 2019-01-09  Tom Tromey  <tom@tromey.com>
5826
5827         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5828         (compunit_filetabs): New.
5829         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5830         compunit_filetabs.
5831         (info_sources_command, make_source_files_completion_list): Remove
5832         declaration.
5833         * symmisc.c (print_objfile_statistics, dump_objfile)
5834         (maintenance_print_symbols): Remove declaration.
5835         (maintenance_info_symtabs): Use compunit_filetabs.
5836         (maintenance_info_line_tables): Likewise.
5837         * source.c (select_source_symtab): Change local variable name.
5838         (forget_cached_source_info_for_objfile): Remove declaration.
5839         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5840         * objfiles.c (objfile_relocate1): Remove declaration.
5841         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5842         declaration.
5843         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5844         * coffread.c (coff_symtab_read): Remove declaration.
5845         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5846         compunit_filetabs.
5847
5848 2019-01-09  Tom Tromey  <tom@tromey.com>
5849
5850         * symtab.c (lookup_objfile_from_block)
5851         (find_pc_sect_compunit_symtab, search_symbols)
5852         (default_collect_symbol_completion_matches_break_on): Use
5853         objfile_compunits.
5854         * objfiles.h (ALL_COMPUNITS): Remove.
5855         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5856         * cp-support.c (add_symbol_overload_list_qualified): Use
5857         objfile_compunits.
5858         * ada-lang.c (ada_collect_symbol_completion_matches)
5859         (ada_add_global_exceptions): Use objfile_compunits.
5860
5861 2019-01-09  Tom Tromey  <tom@tromey.com>
5862
5863         * source.c (select_source_symtab)
5864         (forget_cached_source_info_for_objfile): Remove declaration.
5865         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5866         declaration.
5867         * maint.c (count_symtabs_and_blocks): Remove declaration.
5868         * cp-support.c (add_symbol_overload_list_qualified): Remove
5869         declaration.
5870         * coffread.c (coff_symtab_read): Remove declaration.
5871         * symtab.c (lookup_symbol_in_objfile_symtabs)
5872         (basic_lookup_transparent_type_1): Use objfile_compunits.
5873         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5874         (info_sources_command, search_symbols)
5875         (default_collect_symbol_completion_matches_break_on)
5876         (make_source_files_completion_list): Remove declaration.
5877         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5878         (ada_collect_symbol_completion_matches)
5879         (ada_add_global_exceptions): Remove declaration.
5880         * linespec.c (iterate_over_all_matching_symtabs): Use
5881         objfile_compunits.
5882         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5883         (class objfile_compunits): New.
5884         (ALL_COMPUNITS): Use objfile_compunits.
5885         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5886         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5887         objfile_compunits.
5888         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5889
5890 2019-01-09  Tom Tromey  <tom@tromey.com>
5891
5892         * symtab.c (search_symbols)
5893         (default_collect_symbol_completion_matches_break_on): Use
5894         objfile_msymbols.
5895         * ada-lang.c (ada_lookup_simple_minsym)
5896         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5897         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5898         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5899         objfile_msymbols.
5900         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5901         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5902         * objc-lang.c (find_methods): Use objfile_msymbols.
5903         (info_selectors_command, info_classes_command): Likewise.
5904         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5905         * objfiles.h (class objfile_msymbols): New.
5906         (ALL_OBJFILE_MSYMBOLS): Remove.
5907         (ALL_MSYMBOLS): Remove.
5908
5909 2019-01-09  Tom Tromey  <tom@tromey.com>
5910
5911         * common/next-iterator.h (next_adapter): Add Iterator template
5912         parameter.
5913         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5914         (class all_objfiles_safe): New.
5915         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5916         * objfiles.c (put_objfile_before): Update comment.
5917         (add_separate_debug_objfile): Likewise.
5918         (free_all_objfiles): Use all_objfiles_safe.
5919         (objfile_purge_solibs): Likewise.
5920
5921 2019-01-09  Tom Tromey  <tom@tromey.com>
5922
5923         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5924         (expand_symtab_containing_pc, lookup_static_symbol)
5925         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5926         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5927         all_objfiles.
5928         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5929         * breakpoint.c (create_overlay_event_breakpoint)
5930         (create_longjmp_master_breakpoint)
5931         (create_std_terminate_master_breakpoint)
5932         (create_exception_master_breakpoint): Use all_objfiles.
5933         * linux-thread-db.c (try_thread_db_load_from_pdir)
5934         (has_libpthread): Use all_objfiles.
5935         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5936         * linespec.c (iterate_over_all_matching_symtabs)
5937         (search_minsyms_for_name): Use all_objfiles.
5938         * maint.c (maintenance_info_sections): Use all_objfiles.
5939         * main.c (captured_main_1): Use all_objfiles.
5940         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5941         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5942         * guile/scm-pretty-print.c
5943         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5944         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5945         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5946         (maintenance_print_msymbols): Use all_objfiles.
5947         * source.c (select_source_symtab): Use all_objfiles.
5948         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5949         * symfile.c (remove_symbol_file_command)
5950         (expand_symtabs_matching, map_symbol_filenames): Use
5951         all_objfiles.
5952         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5953         all_objfiles.
5954         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5955         * objc-lang.c (find_methods): Use all_objfiles.
5956         * objfiles.c (have_partial_symbols, have_full_symbols)
5957         (have_minimal_symbols, qsort_cmp)
5958         (default_iterate_over_objfiles_in_search_order): Use
5959         all_objfiles.
5960         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5961         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5962         (maintenance_check_psymtabs): Use all_objfiles.
5963         (ALL_PSYMTABS): Remove.
5964         * compile/compile-object-run.c (do_module_cleanup): Use
5965         all_objfiles.
5966         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5967         * cp-support.c (add_symbol_overload_list_qualified): Use
5968         all_objfiles.
5969         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5970         Use all_objfiles.
5971         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5972         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5973         all_objfiles.
5974         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5975         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5976         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5977         Uses all_objfiles.
5978         * solib.c (solib_read_symbols): Use all_objfiles
5979
5980 2019-01-09  Tom Tromey  <tom@tromey.com>
5981
5982         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5983         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5984         all_objfiles.
5985         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5986         * symmisc.c (print_symbol_bcache_statistics)
5987         (print_objfile_statistics, maintenance_print_objfiles)
5988         (maintenance_info_symtabs, maintenance_check_symtabs)
5989         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5990         all_objfiles.
5991         * source.c (forget_cached_source_info): Use all_objfiles.
5992         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5993         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5994         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5995         * objfiles.c (update_section_map): Use all_objfiles.
5996         (shared_objfile_contains_address_p): Likewise.
5997         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5998         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5999
6000 2019-01-09  Tom Tromey  <tom@tromey.com>
6001
6002         * common/next-iterator.h: New file.
6003         * objfiles.h (class all_objfiles): New.
6004         (struct objfile_iterator): New.
6005
6006 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6007
6008         * NEWS: Move the description of the changed "frame", "select-frame",
6009          and "info frame" commands to the Changed commands section.
6010
6011 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6012
6013         * gdbtypes.c (check_stub_method_group): Remove handling of old
6014         mangling schemes.
6015         * linespec.c (find_methods): Likewise.
6016         * stabsread.c (read_member_functions): Likewise.
6017         * valops.c (search_struct_method): Likewise.
6018         (value_struct_elt_for_reference): Likewise.
6019         * NEWS: Mention this change.
6020
6021 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6022
6023         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6024         print_source_lines.
6025         * source.c (print_source_lines_base): Update line number check.
6026         (print_source_lines): New function.
6027         (source_lines_range::source_lines_range): New function.
6028         * source.h (class source_lines_range): New class.
6029         (print_source_lines): New declaration.
6030
6031 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6032
6033         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6034
6035 2019-01-08  Tom Tromey  <tom@tromey.com>
6036             Simon Marchi  <simon.marchi@ericsson.com>
6037
6038         PR gdb/24060
6039         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6040         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6041         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6042         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6043         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6044         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6045
6046 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6047
6048         * source.c (select_source_symtab): Move header comment to
6049         declaration in source.h.
6050         (forget_cached_source_info_for_objfile): Likewise.
6051         (forget_cached_source_info): Likewise.
6052         (identify_source_line): Likewise.
6053         * source.h (identify_source_line): Move declaration from symtab.h
6054         and add comment from source.c
6055         (print_source_lines): Likewise.
6056         (forget_cached_source_info_for_objfile): Likewise.
6057         (forget_cached_source_info): Likewise.
6058         (select_source_symtab): Likewise.
6059         (enum print_source_lines_flag): Move definition from symtab.h.
6060         * symtab.h (identify_source_line): Move declaration to source.h.
6061         (print_source_lines): Likewise.
6062         (forget_cached_source_info_for_objfile): Likewise.
6063         (forget_cached_source_info): Likewise.
6064         (select_source_symtab): Likewise.
6065         (enum print_source_lines_flag): Move definition to source.h.
6066         * tui/tui-hooks.c: Add 'source.h' include.
6067
6068 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6069
6070         * source.c (print_source_lines_base): Handle requests to print
6071         reverse line number sequences, and guard against empty lines
6072         string.
6073
6074 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6075
6076         * source.c (print_source_lines_base): Fix skip of '\r' if next
6077         character is '\n'.
6078
6079 2019-01-06  Tom Tromey  <tom@tromey.com>
6080
6081         * c-exp.y (struct c_parse_state) <macro_original_text,
6082         expansion_obstack>: New member.
6083         (macro_original_text, expansion_obstack): Remove globals.
6084         (scan_macro_expansion, scanning_macro_expansion)
6085         (finished_macro_expansion): Update.
6086         (scan_macro_cleanup): Remove.
6087         (yylex, c_parse): Update.
6088
6089 2019-01-06  Tom Tromey  <tom@tromey.com>
6090
6091         * c-exp.y (struct c_parse_state) <strings>: New member.
6092         (operator_stoken): Update.
6093
6094 2019-01-06  Tom Tromey  <tom@tromey.com>
6095
6096         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6097         (union type_stack_elt) <typelist_val>: Now a pointer to
6098         std::vector.
6099         (type_stack_cleanup): Don't declare.
6100         (push_typelist): Update.
6101         * parse.c (pop_typelist): Return a std::vector.
6102         (push_typelist): Take a std::vector.
6103         (follow_types): Update.  Do not free args.
6104         (type_stack_cleanup): Remove.
6105         * c-exp.y (struct c_parse_state): New.
6106         (cpstate): New global.
6107         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6108         (nonempty_typelist): Update.
6109         (func_mod): Create a new vector.
6110         (c_parse): Create a c_parse_state.
6111         (check_parameter_typelist): Do not delete params.
6112         (function_method): Update.  Do not delete type_list.
6113
6114 2019-01-06  Tom Tromey  <tom@tromey.com>
6115
6116         PR gdb/28155:
6117         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6118         check_typedef.
6119         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6120         (print_return_value): Likewise.
6121
6122 2019-01-05  Tom Tromey  <tom@tromey.com>
6123
6124         * contrib/cleanup_check.py: Remove.
6125         * contrib/gcc-with-excheck: Remove.
6126         * contrib/exsummary.py: Remove.
6127         * contrib/excheck.py: Remove.
6128
6129 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6130
6131         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6132         NULL. Initialize tpprev to NULL instead of assigning it
6133         to NULL on the next statement.
6134         * windows-nat.c (windows_delete_thread): Remove check for
6135         main_thread_id before printing thread exit notifications.
6136         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6137         Remove thread ID check against main_thread_id.
6138         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6139         windows_delete_thread.
6140         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6141
6142 2019-01-04  Tom Tromey  <tom@tromey.com>
6143
6144         * compile/compile.c (_initialize_compile): Use upper case for
6145         metasyntactic variables.
6146         * symmisc.c (_initialize_symmisc): Use upper case for
6147         metasyntactic variables.
6148         * psymtab.c (_initialize_psymtab): Use upper case for
6149         metasyntactic variables.
6150         * demangle.c (demangle_command): Use upper case for metasyntactic
6151         variables.
6152         (_initialize_demangler): Likewise.
6153         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6154         variables.
6155
6156 2019-01-03  Tom Tromey  <tom@tromey.com>
6157
6158         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6159
6160 2019-01-03  Tom Tromey  <tom@tromey.com>
6161
6162         * python/py-symtab.c (salpy_str): Update.
6163         (struct salpy_sal_object) <symtab>: Now a PyObject.
6164         (salpy_dealloc): Update.
6165         (del_objfile_sal): Use gdbpy_ref.
6166
6167 2019-01-03  Tom Tromey  <tom@tromey.com>
6168
6169         * python/py-type.c (convert_field): Use new_reference.  Return
6170         gdbpy_ref.
6171         (make_fielditem): Return gdbpy_ref.
6172         (typy_fields): Update.
6173         (typy_getitem): Update.
6174         (field_name): Return gdbpy_ref.  Use new_reference.
6175         (typy_iterator_iternext): Update.
6176
6177 2019-01-03  Tom Tromey  <tom@tromey.com>
6178
6179         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6180
6181 2019-01-03  Tom Tromey  <tom@tromey.com>
6182
6183         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6184         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6185         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6186         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6187         (pspy_set_type_printers): Likewise.
6188         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6189         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6190         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6191         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6192         (objfpy_set_type_printers): Likewise.
6193
6194 2019-01-03  Tom Tromey  <tom@tromey.com>
6195
6196         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6197         (gdbpy_print_stack): Use gdbpy_err_fetch.
6198         * python/python-internal.h (class gdbpy_err_fetch): New class.
6199         (class gdbpy_enter) <m_error_type, m_error_value,
6200         m_error_traceback>: Remove.
6201         <m_error>: New member.
6202         (gdbpy_exception_to_string): Don't declare.
6203         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6204         * python/py-value.c (convert_value_from_python): Use
6205         gdbpy_err_fetch.
6206         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6207         gdbpy_exception_to_string.
6208         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6209         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6210         gdbpy_err_fetch.
6211
6212 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6213
6214         * linux-nat.c (delete_lwp_cleanup): Delete.
6215         (struct lwp_deleter): New struct.
6216         (lwp_info_up): New typedef.
6217         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6218         lwp_info_up.
6219
6220 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6221
6222         * linux-fork.c (class scoped_switch_fork_info): New class.
6223         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6224
6225 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6226
6227         * valops.c (find_overload_match): Remove use of null_cleanup, and
6228         calls to do_cleanups.
6229
6230 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6231
6232         * compile/compile-cplus-types.c
6233         (compile_cplus_instance::decl_name): Handle changes to
6234         cp_func_name.
6235         * cp-support.c (cp_func_name): Update header comment, update
6236         return type.
6237         * cp-support.h (cp_func_name): Update return type in declaration.
6238         * valops.c (find_overload_match): Move temp_func local to top
6239         level of function and change its type.  Use temp_func to hold and
6240         delete temporary string obtained from cp_func_name.
6241
6242 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6243
6244         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6245         gdb::char_vector, remove cleanup, and update uses of `msg`.
6246
6247 2019-01-03  Jim Wilson  <jimw@sifive.com>
6248
6249         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6250
6251 2019-01-02  Tom Tromey  <tom@tromey.com>
6252
6253         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6254         (tdesc_parse_xml): Remove cleanups.
6255         * target-descriptions.h (make_cleanup_free_target_description):
6256         Don't declare.
6257         (target_desc_deleter): New struct.
6258         (target_desc_up): New typedef.
6259         * target-descriptions.c (target_desc_deleter::operator()): Rename
6260         from free_target_description.
6261         (make_cleanup_free_target_description): Remove.
6262
6263 2019-01-02  Tom Tromey  <tom@tromey.com>
6264
6265         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6266         constructor, destructor.
6267         (linespec_parser): Remove typedef.
6268         (~linespec_parser): Rename from linespec_parser_delete.
6269         (linespec_lex_to_end, linespec_complete_label)
6270         (linespec_complete): Update.
6271         (decode_line_full): Remove cleanups.
6272         (decode_line_1): Update.
6273
6274 2019-01-02  Tom Tromey  <tom@tromey.com>
6275
6276         * python/python-internal.h (inferior_to_inferior_object): Change
6277         return type.
6278         * python/py-exitedevent.c (create_exited_event_object): Update.
6279         * python/py-inferior.c (inferior_to_inferior_object): Return
6280         gdbpy_ref.
6281         (python_new_inferior, python_inferior_deleted)
6282         (thread_to_thread_object, delete_thread_object)
6283         (build_inferior_list, gdbpy_selected_inferior): Update.
6284         * python/py-infthread.c (create_thread_object): Update.  Also fail
6285         if inferior_to_inferior_object fails.
6286
6287 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6288
6289         * inferior.h (class inferior) <displaced_step_state>: New field.
6290         * infrun.h (struct displaced_step_state): Move here from
6291         infrun.c.  Initialize fields, add constructor.
6292         <inf>: Remove field.
6293         <reset>: New method.
6294         * infrun.c (struct displaced_step_inferior_state): Move to
6295         infrun.h.
6296         (displaced_step_inferior_states): Remove.
6297         (get_displaced_stepping_state): Adust.
6298         (displaced_step_in_progress_any_inferior): Adjust.
6299         (displaced_step_in_progress_thread): Adjust.
6300         (displaced_step_in_progress): Adjust.
6301         (add_displaced_stepping_state): Remove.
6302         (get_displaced_step_closure_by_addr): Adjust.
6303         (remove_displaced_stepping_state): Remove.
6304         (infrun_inferior_exit): Call displaced_step_state.reset.
6305         (use_displaced_stepping): Don't check for NULL.
6306         (displaced_step_prepare_throw): Call
6307         get_displaced_stepping_state.
6308         (displaced_step_fixup): Don't check for NULL.
6309         (prepare_for_detach): Don't check for NULL.
6310
6311 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6312
6313         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6314          in case of call that did not complete.
6315
6316 2019-01-02  Andrey Utkin  <autkin@undo.io>
6317
6318         * symfile.c (find_separate_debug_file): Fix search of debug files for
6319         remote debuggee.
6320
6321 2019-01-02  Tom Tromey  <tom@tromey.com>
6322
6323         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6324         indentation.
6325         * python/py-frame.c (frapy_older): Remove cast.
6326         (frapy_newer): Likewise.
6327         * python/py-breakpoint.c (local_setattro): Remove cast.
6328         * python/py-arch.c (archpy_name): Remove local variable.
6329         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6330
6331 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6332
6333         * unittests/basic_string_view/element_access/char/empty.cc:
6334         Fix year range in copyright header.
6335
6336 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6337
6338         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6339         Delete.
6340         <operator==>: Update with for removed field.
6341         <hash>: Likewise.
6342         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6343         <isa_features>: ...this.
6344         <abi_features>: New field.
6345         (riscv_isa_flen): Update comment.
6346         (riscv_abi_xlen): New declaration.
6347         (riscv_abi_flen): New declaration.
6348         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6349         isa_features.
6350         (riscv_abi_xlen): New function.
6351         (riscv_isa_flen): Update to get answer from isa_features.
6352         (riscv_abi_flen): New function.
6353         (riscv_has_fp_abi): Update to get answer from abi_features.
6354         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6355         xlen and flen.
6356         (riscv_call_info) <xlen, flen>: Update comment.
6357         (riscv_call_arg_struct): Remove invalid assertions
6358         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6359         is removed.
6360         (riscv_gdbarch_init): Gather isa features and abi features
6361         separately, ensure both match on the gdbarch when reusing an old
6362         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6363         a target with 64-bit float hardware.
6364
6365 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6366
6367         * source.c (search_command_helper): Stop reverse search
6368         when line 1 has been searched.
6369
6370 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6371
6372         * record-full.c (record_full_base_target::close): Rewrite
6373         record_full_core_buf_list free logic.
6374
6375 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6376
6377         * break-catch-syscall.c (print_one_catch_syscall): xfree
6378         the last text.
6379
6380 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6381
6382         * top.c (print_gdb_version): Update Copyright year in version
6383         message.
6384
6385 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6386
6387         Update copyright year range in all GDB files.
6388
6389 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6390
6391         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6392
6393 For older changes see ChangeLog-2018.
6394 \f
6395 Local Variables:
6396 mode: change-log
6397 left-margin: 8
6398 fill-column: 74
6399 version-control: never
6400 coding: utf-8
6401 End:
6402