gdb/ChangeLog

   1 2019-09-11  Ali Tamur  <tamur@google.com>
   2
   3         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
   4         implementation.
   5
   6 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
   7
   8         * dbxread.c (read_dbx_symtab): Update.
   9         * dwarf2read.c (load_partial_dies): Update.
  10         * mdebugread.c (parse_partial_symbols): Update.
  11         (handle_psymbol_enumerators): Update.
  12         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
  13         * psymtab.c (add_psymbol_to_bcache): Likewise.
  14         (add_psymbol_to_list): Likewise.
  15         * symtab.c (symbol_set_names): Likewise.
  16         * symtab.h (symbol_set_names): Likewise.
  17         * xcoffread.c (scan_xcoff_symtab): Update.
  18
  19 2019-09-11  Tom Tromey  <tom@tromey.com>
  20
  21         * symfile-mem.c (symbol_file_add_from_memory): Use
  22         bfd_set_filename.
  23         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
  24         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
  25
  26 2019-09-10  Tom Tromey  <tromey@adacore.com>
  27
  28         * dwarf-index-write.c (write_psymbols): Extend error message.
  29         (debug_names::insert): Add Ada code.
  30         (debug_names::write_psymbols): Remove Ada check.
  31         (debug_names) <m_string_obstack>: New member.
  32         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
  33         (gdb_index_symbol_name_matcher::matches): Remove.
  34         (mapped_index_base::find_name_components_bounds): Add "lang"
  35         parameter.
  36         (mapped_index_base::build_name_components): Also split names
  37         according to Ada syntax.
  38         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
  39         type of "match_callback".
  40         (check_match, check_find_bounds_finds)
  41         (dw2_expand_symtabs_matching): Update.
  42         (dw2_debug_names_iterator): Add new constructor.
  43         (dw2_debug_names_map_matching_symbols): New function.
  44         (dw2_debug_names_expand_symtabs_matching): Update.
  45         (dwarf2_debug_names_functions): Use
  46         dw2_debug_names_map_matching_symbols.
  47
  48 2019-09-10  Tom Tromey  <tromey@adacore.com>
  49
  50         * dwarf2read.c (dw2_get_file_names_reader): Add the
  51         CU's file name to the results.
  52
  53 2019-09-10  Tom Tromey  <tromey@adacore.com>
  54
  55         * ada-lang.c (add_nonlocal_symbols): Combine calls to
  56         map_matching_symbols.  Update.
  57         * dwarf2read.c (dw2_map_matching_symbols): Update.
  58         * psymtab.c (match_partial_symbol): Change type; update.
  59         (psym_map_matching_symbols): Likewise.
  60         * symfile-debug.c (debug_qf_map_matching_symbols): Change
  61         type; update.
  62         * symfile.h (struct quick_symbol_functions)
  63         <map_matching_symbols>: Change "name" to be a lookup_name_info.
  64         Remove "match".
  65
  66 2019-09-10  Tom Tromey  <tromey@adacore.com>
  67
  68         * psymtab.c (map_block): Remove.
  69         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
  70         * symtab.c (iterate_over_symbols_terminated): New function.
  71         * symtab.c (iterate_over_symbols_terminated): Declare.
  72
  73 2019-09-10  Tom Tromey  <tromey@adacore.com>
  74
  75         * ada-lang.c (ada_iterate_over_symbols): Return bool.
  76         * language.h (struct language_defn) <la_iterate_over_symbols>:
  77         Return bool.
  78         * symtab.c (iterate_over_symbols): Return bool.
  79         * symtab.h (iterate_over_symbols): Return bool.
  80
  81 2019-09-10  Tom Tromey  <tromey@adacore.com>
  82
  83         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
  84         (add_nonlocal_symbols): Update.
  85         * dwarf2read.c (dw2_map_matching_symbols): Change type.
  86         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
  87         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
  88         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
  89         Change type of "callback".  Remove "data".
  90
  91
  92 2019-09-09  Ali Tamur  <tamur@google.com>
  93
  94         * dwarf2read.c (comp_unit_head): Update comment.
  95         (dwarf2_dwo_name): New function declaration.
  96         (dwarf_unit_type_name): New function declaration.
  97         (read_comp_unit_head): Add support for new compilation units,
  98         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
  99         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 100         (currently named as "signature") in their header. Also clarify error
 101         messages.
 102         (lookup_dwo_id): New function. Returns the dwo id of the given
 103         compile unit.
 104         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 105         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 106         functions.
 107         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 108         (dwarf2_dwo_name): Get the dwo name if present.
 109         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 110         purposes.
 111
 112 2019-09-09  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 115
 116 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 117
 118         * python/python.c (do_start_initialization): Make progname_copy static,
 119         to avoid a leak report.
 120
 121 2019-09-08  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 124
 125 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 126
 127         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 128         Change type to gdb::optional<block_enum>.
 129         (dw2_symtab_iter_init): Change block_index parameter type
 130         to gdb::optional<block_enum>.
 131         (dw2_lookup_symbol): Change block_index parameter
 132         type to block_enum.c
 133         (dw2_debug_names_lookup_symbol): Likewise.
 134         * psymtab.c (psym_lookup_symbol): Likewise.
 135         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 136         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 137         Likewise.
 138
 139 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 140
 141         * defs.h (relocate_gdb_directory): Change int to bool in
 142         signature and rename flag to relocatable.
 143         * main.c (relocate_path): Likewise.
 144         (relocate_gdb_directory): Likewise.
 145
 146 2019-09-06  Alan Modra  <amodra@gmail.com>
 147
 148         * coffread.c (coff_symfile_read): Constify filename variable.
 149         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 150         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 151         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 152         * solib.c (reload_shared_libraries_1): Likewise.
 153         * symfile.c (reread_symbols): Likewise.
 154         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 155         * solib-darwin.c (darwin_bfd_open): Likewise.
 156         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 157
 158 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 159
 160         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 161         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 162
 163 2019-09-03  Tom Tromey  <tromey@adacore.com>
 164
 165         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 166         types.
 167         (has_negatives): Unbias a range type bound.
 168         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 169         * gdbtypes.c (operator==): Handle new field.
 170         (create_range_type): Add "bias" parameter.
 171         (create_static_range_type, resolve_dynamic_range): Update.
 172         * gdbtypes.h (struct range_bounds) <bias>: New member.
 173         (create_range_type): Add bias parameter.
 174         * printcmd.c (print_scalar_formatted): Unbias range types.
 175         * value.c (unpack_long): Unbias range types.
 176         (pack_long): Bias range types.
 177
 178 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 179
 180         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 181         probe arguments.
 182
 183 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 184
 185         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 186         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 187         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 188         (compile_probe_arg): Likewise.
 189         * probe.h (get_argument_count): Likewise.
 190         * solib-svr4.c (solib_event_probe_action): Likewise.
 191         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 192
 193 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 194
 195         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 196         code to here...
 197         (svr4_create_solib_event_breakpoints): ...from here.
 198
 199 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 200
 201         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 202         suffix from warning message.
 203
 204 2019-08-30  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-winsource.h (struct tui_source_window_base)
 207         <refresh_all>: Don't declare.
 208         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 209         Remove.
 210         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 211         tui_show_locator_content.
 212         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 213         declare.
 214         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 215         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 216         declare.
 217
 218 2019-08-30  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 221
 222 2019-08-30  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 225         Remove unnecessary forward declarations.
 226
 227 2019-08-30  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 230         rerender.
 231         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 232         tui_show_locator_content.
 233
 234 2019-08-30  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 237         (tui_locator_window::rerender): Rewrite using body of previous
 238         tui_show_locator_content.
 239
 240 2019-08-30  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 243         set_locator_fullname>: New methods.
 244         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 245         Rename from tui_set_locator_fullname.
 246         (tui_locator_window::set_locator_info): Rename from
 247         tui_set_locator_info.  Return bool.
 248         (tui_update_locator_fullname, tui_show_frame_info): Update.
 249
 250 2019-08-30  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 253
 254 2019-08-30  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 257         call touchwin.
 258
 259 2019-08-30  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-wingeneral.c (box_win): Assume win_info and
 262         win_info->handle cannot be NULL.
 263
 264 2019-08-30  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 267         refresh_window>: Declare.
 268         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 269         resize.
 270         (tui_data_item_window::rerender): Rename from
 271         tui_display_register.
 272         (tui_data_item_window::refresh_window): New method.
 273         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 274         no-op.
 275
 276 2019-08-30  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 279         regs_column_count, current_group>: Move later.  Now private.
 280         <get_current_group>: New method.
 281         * tui/tui-regs.c (tui_reg_command): Update.
 282         * tui/tui-layout.c (tui_set_layout): Update.
 283
 284 2019-08-30  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 287         (tui_data_window::rerender): Don't call
 288         check_and_display_highlight_if_needed.
 289         (tui_data_window::refresh_all): Remove call to
 290         erase_data_content.
 291
 292 2019-08-30  Tom Tromey  <tom@tromey.com>
 293
 294         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 295         (tui_data_window::display_registers_from)
 296         (tui_data_window::display_reg_element_at_line)
 297         (tui_data_window::display_registers_from_line): Remove checks of
 298         "empty".
 299
 300 2019-08-30  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 303         Don't declare.
 304         * tui/tui-regs.c (tui_data_window::show_registers): Call
 305         rerender.
 306         (tui_data_window::rerender): Rename from display_all_data.
 307         (tui_data_window::rerender): Remove old implementation.
 308
 309 2019-08-30  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 312         text.
 313         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 314
 315 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 316             Sergio Durigan Junior  <sergiodj@redhat.com>
 317
 318         PR win32/24284
 319         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 320
 321 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 322
 323         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 324         when searching for types.
 325
 326 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 327
 328         * f-lang.c (f_language_defn): Use f_print_typedef.
 329         * f-lang.h (f_print_typedef): Declare.
 330         * f-typeprint.c (f_print_typedef): Define.
 331
 332 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 333
 334         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 335
 336 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 337
 338         * cli/cli-utils.c (info_print_options_defs): Delete.
 339         (make_info_print_options_def_group): Delete.
 340         (extract_info_print_options): Delete.
 341         (info_print_command_completer): Delete.
 342         (info_print_args_help): Add extra parameter, and optionally
 343         include text about -n flag.
 344         * cli/cli-utils.h (struct info_print_options): Delete.
 345         (extract_info_print_options): Delete declaration.
 346         (info_print_command_completer): Delete declaration.
 347         (info_print_args_help): Add extra parameter, extend header
 348         comment.
 349         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 350         search_symbols.
 351         * stack.c (struct info_print_options): New type.
 352         (info_print_options_defs): New file scoped variable.
 353         (make_info_print_options_def_group): New static function.
 354         (info_print_command_completer): New static function.
 355         (info_locals_command): Update to use new local functions.
 356         (info_args_command): Likewise.
 357         (_initialize_stack): Add extra parameter to calls to
 358         info_print_args_help.
 359         * symtab.c (search_symbols): Add extra parameter, use this to
 360         possibly excluse non-debug symbols.
 361         (symtab_symbol_info): Add extra parameter, which is passed on to
 362         search_symbols.
 363         (struct info_print_options): New type.
 364         (info_print_options_defs): New file scoped variable.
 365         (make_info_print_options_def_group): New static function.
 366         (info_print_command_completer): New static function.
 367         (info_variables_command): Update to use local functions, and pass
 368         extra parameter through to symtab_symbol_info.
 369         (info_functions_command): Likewise.
 370         (info_types_command): Pass additional argument through to
 371         symtab_symbol_info.
 372         (rbreak_command): Pass extra argument to search_symbols.
 373         (_initialize_symtab): Add extra arguments for calls to
 374         info_print_args_help, and update help text for 'info variables',
 375         'whereis', and 'info functions' commands.
 376         * symtab.h (search_symbols): Add extra argument to declaration.
 377         * NEWS: Mention new flags.
 378
 379 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 380
 381         * symtab.c (lookup_static_symbol): Call the new function (and move
 382         it down to be next to lookup_global_symbol).
 383         (struct global_sym_lookup_data): Add block_enum member and rename to...
 384         (struct global_or_static_sym_lookup_data): ...this.
 385         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 386         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 387         (lookup_symbol_global_or_static_iterator_cb): ...this.
 388         (lookup_global_or_static_symbol): New function.
 389         (lookup_global_symbol): Call new function.
 390
 391 2019-08-26  Tom de Vries  <tdevries@suse.de>
 392
 393         PR c++/24852
 394         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 395         when pc_probe.prob == NULL.
 396
 397 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 398
 399         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 400         variable symbol_linkage to symbol_linkage_.
 401
 402 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 403
 404         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 405         represent whether the symbol is static, dynamic, or we don't
 406         know.
 407
 408 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 409
 410         * gdb/rx-tdep.c (rx_register_names): New.
 411         (rx_register_name): Delete.
 412         (rx_psw_type): Delete.
 413         (rx_fpsw_type): Delete.
 414         (rx_register_type): Delete.
 415         (rx_gdbarch_init): Convert target-descriptions.
 416         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 417         * gdb/features/Makefile: Add rx.xml.
 418         * gdb/features/rx.xml: New.
 419         * gdb/features/rx.c: Generated.
 420         * gdb/NEWS: Mention target description support.
 421
 422 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 423
 424         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 425         *slot_ptr.
 426
 427 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 428
 429         * configure.ac: Don't check for 'dlfcn.h' (moved to
 430         gdbsupport/common.m4).
 431         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 432         'gdbsupport/'.
 433         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 434         * compile/compile-c-support.c: Include
 435         'gdbsupport/gdb-dlfcn.h'.
 436         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 437         * gdb-dlfcn.c: Move to...
 438         * gdbsupport/gdb-dlfcn.c: ... here.
 439         * gdb-dlfcn.h: Move to...
 440         * gdbsupport/gdb-dlfcn.h: ... here.
 441
 442 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 443
 444         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 445         the offset field signed.
 446
 447 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 448
 449         * python/lib/gdb/__init__.py (_execute_file): New function.
 450         * python/python.c (python_run_simple_file): Call gdb._execute_file
 451         on Windows.
 452
 453 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 454
 455         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 456         all uses as this was never set to anything but a zero value.
 457
 458 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 459
 460         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 461
 462 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 463
 464         * tui/tui-data.h (tui_gen_win_info): Add an =default
 465         move constructor, required by some GCC versions.
 466
 467 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 468
 469         * go32-nat.c (go32_sysinfo): Add hygon_p.
 470
 471 2019-08-20  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 474         line_from_reg_element_no, first_reg_element_no_inline,
 475         display_all_data, delete_data_content_windows,
 476         erase_data_content>: Now private.
 477
 478 2019-08-20  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 481         (tui_unhighlight_win, tui_highlight_win)
 482         (tui_win_info::make_window): Update.
 483         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 484
 485 2019-08-20  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 488         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 489         (MAX_PID_WIDTH): Move to tui-stack.c.
 490         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 491         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 492         (MAX_PID_WIDTH): Move from tui-data.h.
 493
 494 2019-08-20  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 497         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 498         (box_win): Update.
 499         (tui_gen_win_info::make_window): Rename from tui_make_window.
 500         (tui_win_info::make_window): New method.
 501         (tui_gen_win_info::make_visible): Update.
 502         * tui/tui-source.c (tui_source_window::set_contents): Update.
 503         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 504         (tui_data_window::display_registers_from): Update.
 505         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 506         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 507         Declare.
 508         <can_box>: Remove.
 509         <title>: Remove.
 510         (struct tui_win_info) <make_window>: Declare.
 511         <can_box>: Now virtual.
 512         <title>: New member.
 513         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 514         * tui/tui-command.c (tui_cmd_window::resize): Update.
 515
 516 2019-08-20  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 519         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 520         (tui_data_window::check_register_values): Update.
 521
 522 2019-08-20  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-regs.h (struct tui_data_window): Use
 525         DISABLE_COPY_AND_ASSIGN.
 526         <regs_content>: Change type, removing unique_ptr.
 527         <tui_data_window>: Add move constructor.
 528         * tui/tui-regs.c (tui_data_window::show_registers)
 529         (tui_data_window::show_register_group)
 530         (tui_data_window::display_registers_from)
 531         (tui_data_window::display_registers_from)
 532         (tui_data_window::first_data_item_displayed)
 533         (tui_data_window::delete_data_content_windows)
 534         (tui_data_window::rerender, tui_data_window::refresh_window)
 535         (tui_data_window::check_register_values): Update.
 536
 537 2019-08-20  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 540         show_register_group>: Declare.
 541         (tui_show_register_group): Don't declare.
 542         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 543         tui_show_registers.
 544         (tui_data_window::show_register_group): Rename from
 545         tui_show_register_group.
 546         (tui_data_window::check_register_values, tui_reg_command):
 547         Update.
 548         * tui/tui-layout.c (tui_set_layout): Update.
 549
 550 2019-08-20  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 553         Declare.
 554         (tui_check_register_values): Don't declare.
 555         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 556         from tui_check_register_values.
 557         * tui/tui-hooks.c (tui_register_changed): Update.
 558
 559 2019-08-20  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-regs.c (tui_reg_layout): Move later.
 562         (tui_show_registers): Don't enable TUI mode or change layout.
 563
 564 2019-08-20  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-regs.h (struct tui_data_item_window)
 567         <~tui_data_item_window>: Remove.
 568         <content>: Now a unique_xmalloc_ptr.
 569         * tui/tui-regs.c (tui_register_format): Return a
 570         unique_xmalloc_ptr.
 571         (tui_get_register): Update.
 572         (~tui_data_item_window): Remove.
 573         (tui_data_window::display_registers_from, tui_display_register):
 574         Update.
 575         * tui/tui-io.h (tui_expand_tabs): Update.
 576         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 577         Remove "col" parameter.
 578
 579 2019-08-20  Tom Tromey  <tom@tromey.com>
 580
 581         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 582         field.
 583         * tui/tui-regs.c (~tui_data_item_window): Update.
 584
 585 2019-08-20  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 588         earlier.
 589
 590 2019-08-20  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 593
 594 2019-08-20  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-source.h (struct tui_source_window): Update.
 597         * tui/tui-regs.c (tui_show_registers): Update.
 598         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 599         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 600         (NO_REGS_STRING): Remove defines.
 601
 602 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 603
 604         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 605         unnecessary thread walk if remote doesn't support the packet.
 606
 607 2019-08-19  Tom Tromey  <tromey@adacore.com>
 608
 609         * python/py-value.c (value_has_field): Fix indentation.
 610
 611 2019-08-19  Tom Tromey  <tromey@adacore.com>
 612
 613         * printcmd.c (do_one_display, info_display_command): Update.
 614         * block.h (contained_in): Return bool.  Add allow_nested
 615         parameter.
 616         * block.c (contained_in): Return bool.  Add allow_nested
 617         parameter.
 618
 619 2019-08-19  Tom Tromey  <tom@tromey.com>
 620
 621         * configure: Rebuild.
 622         * configure.ac: Disallow the combination of -static-libstdc++ and
 623         source highlight.
 624         * source-cache.c (get_language_name): Handle rust.
 625         (source_cache::get_source_lines): Ignore highlighting exceptions.
 626
 627 2019-08-16  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 630         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 631         (struct tui_source_window_base) <make_visible, refresh_window,
 632         resize>: Remove methods.
 633         <execution_info>: Remove field.
 634         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 635         (tui_show_source_line, tui_source_window_base)
 636         (~tui_source_window_base): Update.
 637         (tui_source_window_base::resize)
 638         (tui_source_window_base::make_visible)
 639         (tui_source_window_base::refresh_window): Remove.
 640         (tui_source_window_base::update_exec_info): Update.
 641         * tui/tui-source.c (tui_source_window::set_contents): Update.
 642         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 643
 644 2019-08-16  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 647         deprecated_query_hook.
 648
 649 2019-08-16  Tom Tromey  <tom@tromey.com>
 650
 651         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 652         (tui_update_source_windows_with_line): Update.
 653         * tui/tui-source.h (struct tui_source_window)
 654         <show_symtab_source>: Declare.
 655         (tui_show_symtab_source): Don't declare.
 656         * tui/tui-source.c (tui_show_symtab_source): Rename from
 657         tui_show_symtab_source.
 658
 659 2019-08-16  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-winsource.h (struct tui_source_window_base)
 662         <set_contents>: Declare.
 663         * tui/tui-winsource.c
 664         (tui_source_window_base::update_source_window_as_is): Update.
 665         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 666         Declare.
 667         (tui_set_source_content): Don't declare.
 668         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 669         tui_set_source_content.
 670         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 671         Declare.
 672         (tui_set_disassem_content): Don't declare.
 673         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 674         tui_set_disassem_content.
 675
 676 2019-08-16  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-winsource.h (struct tui_source_window_base)
 679         <update_breakpoint_info>: Declare.
 680         (tui_update_breakpoint_info): Don't declare.
 681         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 682         (tui_update_all_breakpoint_info): Update.
 683         (tui_source_window_base::update_breakpoint_info): Rename from
 684         tui_update_breakpoint_info.
 685         (tui_source_window_base::update_exec_info): Update.
 686
 687 2019-08-16  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-winsource.h (struct tui_source_window_base)
 690         <update_source_window>: Declare.
 691         (tui_update_source_window): Don't declare.
 692         * tui/tui-winsource.c
 693         (tui_source_window_base::update_source_window): Rename from
 694         tui_update_source_window.
 695         (tui_source_window_base::rerender): Update.
 696         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 697         * tui/tui-disasm.c (tui_show_disassem)
 698         (tui_show_disassem_and_update_source)
 699         (tui_disasm_window::maybe_update): Update.
 700
 701 2019-08-16  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-winsource.h (struct tui_source_window_base)
 704         <update_source_window_as_is>: Declare.
 705         (tui_update_source_window_as_is): Don't declare.
 706         * tui/tui-winsource.c (tui_update_source_window): Update
 707         (tui_source_window_base::update_source_window_as_is): Rename from
 708         tui_update_source_window_as_is.
 709         (tui_source_window_base::refill): Update.
 710         * tui/tui-source.c (tui_show_symtab_source): Update.
 711         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 712         Update.
 713
 714 2019-08-16  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-winsource.h (tui_update_source_window)
 717         (tui_update_source_window_as_is): Remove "noerror" parameter.
 718         * tui/tui-winsource.c (tui_update_source_window)
 719         (tui_update_source_window_as_is): Remove "noerror" parameter.
 720         (tui_update_source_windows_with_addr)
 721         (tui_update_source_windows_with_line)
 722         (tui_source_window_base::rerender)
 723         (tui_source_window_base::refill): Update.
 724         * tui/tui-source.h (tui_set_source_content)
 725         (tui_show_symtab_source): Remove "noerror" parameter.
 726         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 727         parameter.
 728         (tui_show_symtab_source): Likewise.
 729         (tui_source_window::maybe_update): Update.
 730         * tui/tui-disasm.c (tui_show_disassem)
 731         (tui_show_disassem_and_update_source)
 732         (tui_disasm_window::do_scroll_vertical)
 733         (tui_disasm_window::maybe_update): Update.
 734
 735 2019-08-16  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui.c (tui_is_window_visible): Update.
 738         * tui/tui-wingeneral.c (tui_make_window)
 739         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 740         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 741         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 742         (tui_set_win_height_command, parse_scrolling_args): Update.
 743         * tui/tui-source.c (tui_source_window::style_changed): Update.
 744         * tui/tui-regs.c (tui_show_registers)
 745         (tui_data_window::first_data_item_displayed)
 746         (tui_data_window::delete_data_content_windows)
 747         (tui_check_register_values, tui_reg_command): Update.
 748         * tui/tui-disasm.c (tui_show_disassem): Update.
 749         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 750         method.
 751         <is_visible>: Remove field.
 752         * tui/tui-data.c (tui_next_win, tui_prev_win)
 753         (tui_delete_invisible_windows): Update.
 754
 755 2019-08-16  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-winsource.h (struct tui_source_window_base)
 758         <m_has_locator>: Remove.
 759         * tui/tui-layout.c (show_source_disasm_command, show_data)
 760         (show_source_or_disasm_and_command): Update.
 761
 762 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 763
 764         * NEWS (Other MI changes): New subsection.
 765         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 766         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 767         * arch-utils.c (default_get_pc_address_flags): New function.
 768         * arch-utils.h (default_get_pc_address_flags): New declaration.
 769         * gdbarch.sh: Add get_pc_address_flags.
 770         * gdbarch.c: Regenerate.
 771         * gdbarch.h: Likewise.
 772         * stack.c (print_pc): New function.
 773         (print_frame_info) (print_frame): Call print_pc.
 774
 775 2019-08-16  Tom de Vries  <tdevries@suse.de>
 776
 777         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 778         print_objfile_section_info.
 779
 780 2019-08-15  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 783         calling update_cmdwin_start_line.
 784         * tui/tui-winsource.h (struct tui_source_window_base)
 785         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 786         <rerender>: Declare.
 787         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 788         Call rerender.
 789         (tui_source_window_base::set_new_height): Remove.
 790         (tui_source_window_base::rerender): Rename from
 791         do_make_visible_with_new_height.
 792         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 793         resize method.
 794         (tui_win_info::make_invisible_and_set_new_height)
 795         (tui_win_info::make_visible_with_new_height): Remove.
 796         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 797         Declare.
 798         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 799         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 800         do_make_visible_with_new_height>: Don't declare.
 801         <rerender>: Declare.
 802         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 803         set_new_height.
 804         (tui_data_window::do_make_visible_with_new_height): Remove.
 805         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 806         call tui_show_locator_content.
 807         (tui_gen_win_info::resize): Call rerender.
 808         (show_source_or_disasm_and_command): Don't call
 809         tui_show_locator_content.
 810         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 811         method.
 812         (struct tui_win_info) <rerender>: Declare.
 813         <set_new_height, make_invisible_and_set_new_height,
 814         make_visible_with_new_height>: Don't declare.
 815         * tui/tui-data.c (tui_win_list::rerender): New method.
 816         * tui/tui-command.h (struct tui_cmd_window)
 817         <do_make_visible_with_new_height>: Don't declare.
 818         * tui/tui-command.c
 819         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 820
 821 2019-08-15  Tom Tromey  <tromey@adacore.com>
 822
 823         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 824         * ada-lang.c (ada_enum_name): Likewise.
 825
 826 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 827
 828         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 829         leading underscore.
 830         (GdbOutputErrorFile): Likewise.
 831         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 832         accordingly.
 833         (execute_unwinders): Rename to have a leading underscore.
 834         (auto_load_packages): Likewise.
 835         (global scope): Adjust call to auto_load_packages accordingly.
 836         (GdbSetPythonDirectory): Likewise.
 837         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 838         instead of execute_unwinders.
 839
 840 2019-08-15  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 843         (show_data): Don't change window visibility.
 844         (tui_gen_win_info::resize): Remove special case for command
 845         window.  Use wresize, when available.
 846         (show_source_or_disasm_and_command): Don't change window
 847         visibility.
 848         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 849         <make_visible>: New method.
 850         * tui/tui-command.c (tui_cmd_window::resize): New method.
 851
 852 2019-08-15  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 855         (struct tui_source_windows): New.
 856         * tui/tui-winsource.c (tui_display_main): Update.
 857         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 858         (new_height_ok, parse_scrolling_args): Update.
 859         * tui/tui-layout.c (show_layout, show_data): Update.
 860         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 861         (tui_add_to_source_windows): Don't declare.
 862         * tui/tui-data.c (source_windows, tui_source_windows)
 863         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 864
 865 2019-08-15  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 868         Rename from reset.
 869         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 870         * tui/tui-layout.c (show_source_disasm_command, show_data):
 871         Update.
 872         (tui_gen_win_info::resize): Rename.
 873         (show_source_or_disasm_and_command): Update.
 874         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 875         reset.
 876
 877 2019-08-15  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 880         * tui/tui-interp.c (tui_interp::init): Don't call
 881         tui_initialize_static_data.
 882         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 883
 884 2019-08-15  Tom Tromey  <tom@tromey.com>
 885
 886         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 887         examine tui_win_list.
 888
 889 2019-08-15  Tom Tromey  <tom@tromey.com>
 890
 891         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 892         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 893         tui_clear_source_content.
 894         (tui_clear_source_content): Remove.
 895         (tui_source_window_base::do_erase_source_content): Hoist call to
 896         content.clear().
 897         * tui/tui-stack.c (tui_show_frame_info): Don't call
 898         tui_clear_source_content.
 899
 900 2019-08-15  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-winsource.h (struct tui_source_window_base)
 903         <do_erase_source_content>: New method.
 904         <erase_source_content>: New method.
 905         (tui_erase_source_content): Don't declare.
 906         * tui/tui-winsource.c (tui_clear_source_content): Update.
 907         (tui_source_window_base::do_erase_source_content): Rename from
 908         tui_erase_source_content.
 909         (tui_source_window_base::show_source_content): Update.
 910         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 911         * tui/tui-source.h (struct tui_source_window)
 912         <erase_source_content>: New method.
 913         * tui/tui-disasm.h (struct tui_disasm_window)
 914         <erase_source_content>: New method.
 915
 916 2019-08-15  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 919         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 920         constructor.
 921         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 922         * tui/tui-source.c (tui_set_source_content): Update.
 923         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 924
 925 2019-08-15  Tom Tromey  <tom@tromey.com>
 926
 927         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 928         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 929         tui-source.c.
 930         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 931         Declare.
 932         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 933         method.
 934         (tui_source_window::maybe_update): Update.
 935
 936 2019-08-15  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 939         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 940         tui-disasm.c.
 941         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 942         Declare.
 943         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 944         method.
 945         (tui_disasm_window::maybe_update): Update.
 946
 947 2019-08-15  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui-winsource.h (struct tui_source_window_base)
 950         <maybe_update>: Declare.
 951         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 952         method.
 953         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 954         Declare.
 955         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 956         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 957         Declare.
 958         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 959
 960 2019-08-15  Tom Tromey  <tom@tromey.com>
 961
 962         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 963
 964 2019-08-15  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-wingeneral.c: Include tui-stack.h.
 967         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 968         (struct tui_locator_window): Move from tui-data.h.
 969         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 970         (tui_initialize_static_data): Move from tui-data.c.
 971         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 972         (struct tui_locator_window): Move to tui-stack.c.
 973         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 974         (tui_initialize_static_data): Move to tui-stack.c.
 975
 976 2019-08-15  Tom Tromey  <tom@tromey.com>
 977
 978         * tui/tui-layout.c (show_source_disasm_command)
 979         (show_source_or_disasm_and_command): Use make_visible method, not
 980         tui_make_window.
 981         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 982         Remove.
 983
 984 2019-08-15  Tom Tromey  <tom@tromey.com>
 985
 986         * tui/tui-wingeneral.h (tui_make_window): Update.
 987         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 988         parameter.
 989         (tui_gen_win_info::make_visible): Update.
 990         * tui/tui-regs.c (tui_data_window::display_registers_from):
 991         Update.
 992         * tui/tui-layout.c (show_source_disasm_command)
 993         (show_source_or_disasm_and_command): Update.
 994         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 995         (enum tui_box): Remove.
 996         (struct tui_win_info) <can_box>: New method.
 997         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 998         method.
 999
1000 2019-08-15  Tom de Vries  <tdevries@suse.de>
1001
1002         * linux-nat-trad.c: Include gdbarch.h.
1003
1004 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1005
1006         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1007         register sizes.
1008
1009 2019-08-14  Tom Tromey  <tromey@adacore.com>
1010
1011         * darwin-nat.c: Include gdbarch.h.
1012         * darwin-nat-info.c: Include gdbarch.h.
1013
1014 2019-08-13  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1017         Remove.
1018         * tui/tui-data.c (tui_initialize_static_data): Update.
1019
1020 2019-08-13  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-winsource.h (struct tui_exec_info_window)
1023         <~tui_exec_info_window, maybe_allocate_content, get_content,
1024         m_content>: Remove.
1025         (struct tui_source_window_base) <set_exec_info_content,
1026         show_exec_info_content>: Don't declare.
1027         * tui/tui-winsource.c
1028         (tui_exec_info_window::maybe_allocate_content): Remove.
1029         (tui_source_window_base::update_exec_info): Rename from
1030         set_exec_info_content.
1031         (tui_source_window_base::show_exec_info_content)
1032         (tui_source_window_base::update_exec_info): Remove.
1033
1034 2019-08-13  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1037         declare.
1038         * tui/tui-winsource.c (tui_update_source_window_as_is)
1039         (tui_update_source_windows_with_addr, tui_erase_source_content):
1040         Update.
1041         (tui_clear_exec_info_content): Remove.
1042
1043 2019-08-13  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1046         declare.
1047         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1048         call tui_erase_exec_info_content.
1049         (tui_clear_exec_info_content): Rename from
1050         tui_erase_exec_info_content.
1051         (tui_clear_exec_info_content): Delete.
1052
1053 2019-08-13  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-winsource.h (struct tui_source_window_base)
1056         <show_exec_info_content>: Declare.
1057         (tui_show_exec_info_content): Don't declare.
1058         * tui/tui-winsource.c
1059         (tui_source_window_base::show_exec_info_content): Rename from
1060         tui_show_exec_info_content.
1061         (tui_source_window_base::update_exec_info): Update.
1062
1063 2019-08-13  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1066         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1067         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1068         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1069         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1070         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1071         ... here.
1072
1073 2019-08-13  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-winsource.h (struct tui_source_window_base)
1076         <update_exec_info>: Declare.
1077         (tui_update_exec_info): Don't declare.
1078         * tui/tui-winsource.c (tui_update_source_window_as_is)
1079         (tui_source_window_base::refresh_all)
1080         (tui_update_all_breakpoint_info): Update.
1081         (tui_source_window_base::update_exec_info): Rename from
1082         tui_update_exec_info.
1083         * tui/tui-stack.c (tui_show_frame_info): Update.
1084
1085 2019-08-13  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-winsource.h (struct tui_source_window_base)
1088         <set_exec_info_content>: Declare.
1089         (tui_set_exec_info_content): Don't declare.
1090         * tui/tui-winsource.c
1091         (tui_source_window_base::set_exec_info_content): Rename from
1092         tui_set_exec_info_content.
1093         (tui_update_exec_info): Update.
1094
1095 2019-08-13  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-winsource.h (struct tui_source_window_base)
1098         <show_source_content>: Declare.
1099         (tui_show_source_content): Don't declare.
1100         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1101         (tui_source_window_base::show_source_content): Rename from
1102         tui_show_source_content.
1103         (tui_source_window_base::refresh_all): Update.
1104         * tui/tui-layout.c (show_source_disasm_command)
1105         (show_source_or_disasm_and_command): Update.
1106
1107 2019-08-13  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui-winsource.c (tui_erase_source_content)
1110         (tui_show_source_content, tui_source_window_base::refresh_all):
1111         Update.
1112         * tui/tui-wingeneral.h
1113         (tui_check_and_display_highlight_if_needed): Don't declare.
1114         * tui/tui-wingeneral.c
1115         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1116         check_and_display_highlight_if_needed.
1117         * tui/tui-win.c (tui_rehighlight_all)
1118         (tui_win_info::make_visible_with_new_height): Update.
1119         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1120         (tui_data_window::erase_data_content)
1121         (tui_data_window::display_all_data): Update.
1122         * tui/tui-data.h (struct tui_win_info)
1123         <check_and_display_highlight_if_needed>: Declare.
1124
1125 2019-08-13  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-win.c (tui_resize_all): Call
1128         tui_delete_invisible_windows.
1129         * tui/tui-layout.c (show_layout): Call
1130         tui_delete_invisible_windows.
1131         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1132         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1133
1134 2019-08-13  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1137         tui_add_win_to_layout.
1138
1139 2019-08-13  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1142         * tui/tui-layout.c (tui_default_win_height): Now static.
1143
1144 2019-08-13  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1147         single switch.
1148         (show_source_disasm_command, show_source_or_disasm_and_command):
1149         Don't check current layout.
1150
1151 2019-08-13  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-wingeneral.c (make_all_visible): Remove.
1154         (tui_make_all_invisible): Simplify.
1155         * tui/tui-layout.c (tui_make_all_invisible): Move from
1156         tui-wingeneral.c; simplify.
1157         (show_layout): Hoist call to tui_make_all_invisible.
1158         (show_data): Don't call tui_make_all_invisible.
1159
1160 2019-08-13  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1163         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1164
1165 2019-08-13  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1168         tui-data.c.
1169         (show_source_disasm_command, show_data)
1170         (show_source_or_disasm_and_command): Don't use
1171         tui_set_current_layout_to.
1172         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1173         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1174         tui-layout.c.
1175         (tui_set_current_layout_to): Remove.
1176
1177 2019-08-13  Tom Tromey  <tom@tromey.com>
1178
1179         * tui/tui-layout.c (tui_set_layout): Update.
1180         * tui/tui-data.h (struct tui_layout_def): Remove.
1181         (tui_layout_def): Don't declare.
1182         * tui/tui-data.c (layout_def): Remove.
1183         (tui_layout_def): Remove.
1184
1185 2019-08-13  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-winsource.h (struct tui_source_window_base)
1188         <clear_detail>: No longer "override".
1189         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1190         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1191         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1192         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1193         Remove.
1194         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1195
1196 2019-08-13  Tom Tromey  <tromey@adacore.com>
1197
1198         * tracepoint.c: Don't include readline.h or history.h.
1199
1200 2019-08-12  Tom Tromey  <tom@tromey.com>
1201
1202         * configure: Rebuild.
1203         * configure.ac: Check for readline 7.
1204         * NEWS: Mention readline 7 requirement.
1205         * README: Update.
1206
1207 2019-08-12  Tom Tromey  <tom@tromey.com>
1208
1209         * mingw-hdep.c (gdb_select): Remove readline hack.
1210
1211 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1212
1213         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1214         when the function fails.
1215
1216 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1217
1218         * s390-tdep.c (s390_type_align): New function.
1219         (s390_gdbarch_init): Set it as type_align gdbarch method.
1220
1221 2019-08-09  Tom de Vries  <tdevries@suse.de>
1222
1223         PR gdb/24591
1224         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1225         pc_low with relocation offset.
1226
1227 2019-08-07  Tom Tromey  <tromey@adacore.com>
1228
1229         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1230         (print_frame_args): Update.
1231         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1232         Update.
1233         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1234         * frame.h (struct frame_arg): Add initializers.
1235         <error>: Now a unique_xmalloc_ptr.
1236
1237 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1238
1239         * NEWS: Expand the Pointer Authentication entry.
1240         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1241         (aarch64_frame_unmask_lr): ... to this.
1242         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1243         Call aarch64_frame_unmask_lr.
1244         * frame.c (struct frame_info): Add "masked" variable.
1245         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1246         (fprint_frame): Check for masked pc.
1247         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1248         declarations.
1249         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1250         * stack.c (print_frame): Check for masked pc.
1251
1252 2019-08-06  Tom Tromey  <tom@tromey.com>
1253
1254         * stabsread.c (patch_block_stabs, read_one_struct_field)
1255         (read_enum_type): Use obstack_strndup.
1256         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1257         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1258         * dwarf2read.c (guess_full_die_structure_name)
1259         (anonymous_struct_prefix): Use obstack_strndup.
1260         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1261         * c-exp.y (yylex): Use obstack_strndup.
1262         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1263         (write_var_or_type): Use obstack_strndup.
1264
1265 2019-08-06  Tom Tromey  <tom@tromey.com>
1266
1267         * symfile.c (reread_symbols): Use obstack_strdup.
1268         * stabsread.c (read_type): Use obstack_strdup.
1269         * gdb_obstack.h (obstack_strdup): New overload.
1270         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1271         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1272         (dwarf2_canonicalize_name): Use obstack_strdup.
1273         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1274         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1275         Use obstack_strdup.
1276
1277 2019-08-06  Tom Tromey  <tom@tromey.com>
1278
1279         * gdb_obstack.h (obstack_strdup): Define.
1280         * gdb_obstack.c (obstack_strdup): Don't define.
1281
1282 2019-08-06  Tom Tromey  <tom@tromey.com>
1283
1284         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1285         obstack_strdup.
1286         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1287         obstack_strdup.
1288         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1289         * stabsread.c (common_block_start): Use obstack_strdup.
1290         * objfiles.c (set_objfile_main_name, objfile): Use
1291         obstack_strdup.
1292         * namespace.c (add_using_directive): Use obstack_strdup.
1293         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1294         * jit.c (finalize_symtab): Use obstack_strdup.
1295         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1296         (guess_partial_die_structure_name, partial_die_info::fixup)
1297         (dwarf2_name): Use obstack_strdup.
1298         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1299         obstack_strdup.
1300         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1301         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1302         obstack_strdup.
1303         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1304
1305 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1306
1307         * unittests/help-doc-selftests.c: New file.
1308         * Makefile.in: Add the new file.
1309
1310 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1311
1312         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1313         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1314         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1315         the trailing '.' is not output, and the first character is uppercased.
1316         (print_help_for_command): Update call to print_doc_line.
1317         (print_doc_of_command): Likewise.
1318         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1319         * cli/cli-option.c (append_indented_doc): Do not append newline.
1320         (build_help_option): Append newline after first appended_indented_doc
1321         only if a second call is done.
1322         (build_help): Append 2 new lines before each option, except the first
1323         one.
1324         * compile/compile.c (_initialize_compile): Add new lines after
1325         %OPTIONS%, when not at the end of the help.
1326         Change help doc or code
1327         producing the help doc to respect the invariants.
1328         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1329         Also removed the new line after 'Options:', as all other commands
1330         do not put an empty line between 'Options:' and the first option.
1331         * printcmd.c (_initialize_printcmd): Likewise.
1332         * stack.c (_initialize_stack): Likewise.
1333         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1334         incorrectly telling COMMAND is optional.
1335         * ada-lang.c (_initialize_ada_language): Change help doc or code
1336         producing the help doc to respect the invariants.
1337         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1338         * breakpoint.c (_initialize_breakpoint): Likewise.
1339         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1340         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1341         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1342         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1343         _initialize_cli_style): Likewise.
1344         * corelow.c (core_target_info): Likewise.
1345         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1346         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1347         * filesystem.c (_initialize_filesystem): Likewise.
1348         * frame.c (_initialize_frame): Likewise.
1349         * gnu-nat.c (add_task_commands): Likewise.
1350         * infcall.c (_initialize_infcall): Likewise.
1351         * infcmd.c (_initialize_infcmd): Likewise.
1352         * interps.c (_initialize_interpreter): Likewise.
1353         * language.c (_initialize_language): Likewise.
1354         * linux-fork.c (_initialize_linux_fork): Likewise.
1355         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1356         * maint.c (_initialize_maint_cmds): Likewise.
1357         * memattr.c (_initialize_mem): Likewise.
1358         * printcmd.c (_initialize_printcmd): Likewise.
1359         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1360         _RegEx): Likewise.
1361         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1362         * record-btrace.c (_initialize_record_btrace): Likewise.
1363         * record-full.c (_initialize_record_full): Likewise.
1364         * record.c (_initialize_record): Likewise.
1365         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1366         * regcache.c (_initialize_regcache): Likewise.
1367         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1368         _initialize_remote): Likewise.
1369         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1370         * serial.c (_initialize_serial): Likewise.
1371         * skip.c (_initialize_step_skip): Likewise.
1372         * source.c (_initialize_source): Likewise.
1373         * stack.c (_initialize_stack): Likewise.
1374         * symfile.c (_initialize_symfile): Likewise.
1375         * symtab.c (_initialize_symtab): Likewise.
1376         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1377         * top.c (init_main): Likewise.
1378         * tracefile-tfile.c (tfile_target_info): Likewise.
1379         * tracepoint.c (_initialize_tracepoint): Likewise.
1380         * tui/tui-win.c (_initialize_tui_win): Likewise.
1381         * utils.c (add_internal_problem_command): Likewise.
1382         * valprint.c (value_print_option_defs): Likewise.
1383
1384 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1385
1386         PR build/24886
1387         * configure.ac: Drop enable-libmcheck support.
1388         * configure, config.in: Rebuild.
1389         * libmcheck.m4: Remove.
1390         * acinclude.m4: Don't include it.
1391         * Makefile.in: Don't distribute it.
1392         * top.c (print_gdb_configuration): Don't mention it.
1393
1394 2019-08-06  Tom Tromey  <tom@tromey.com>
1395
1396         * utils.c (set_output_style): Sometimes pass stream to
1397         emit_style_escape.
1398         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1399         * record-btrace.c (btrace_insn_history): Update.
1400         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1401         method.
1402         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1403         Update initializers.
1404         <m_uiout>: New field.
1405         <m_di>: Move lower.
1406         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1407         Remove "uiout" parameter.
1408         (dump_insns): Update.
1409         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1410         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1411
1412 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1413
1414         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1415         (error_in_psymtab_expansion): Likewise.
1416         (lookup_symbol_via_quick_fns): Likewise.
1417         (basic_lookup_transparent_type_quick): Likewise.
1418         (basic_lookup_transparent_type_1): Likewise.
1419
1420 2019-08-06  Tom Tromey  <tromey@adacore.com>
1421
1422         * source.c (last_source_error): Now bool.
1423         (print_source_lines_base): Make "noprint" bool.  Only open
1424         source file when last_source_visited changes.
1425
1426 2019-08-06  Tom Tromey  <tromey@adacore.com>
1427
1428         * annotate.c (annotate_source_line): Use g_source_cache.
1429         * source-cache.c (source_cache::get_plain_source_lines): Change
1430         parameters.  Populate m_offset_cache.
1431         (source_cache::ensure): New method.
1432         (source_cache::get_line_charpos): New method.
1433         (extract_lines): Move lower.  Change parameters.
1434         (source_cache::get_source_lines): Move lower.
1435         * source-cache.h (class source_cache): Update comment.
1436         <get_line_charpos>: New method.
1437         <get_source_lines>: Update comment.
1438         <clear>: Clear m_offset_cache.
1439         <get_plain_source_lines>: Change parameters.
1440         <ensure>: New method
1441         <m_offset_cache>: New member.
1442         * source.c (forget_cached_source_info_for_objfile): Update.
1443         (info_source_command): Use g_source_cache.
1444         (find_source_lines, open_source_file_with_line_charpos): Remove.
1445         (print_source_lines_base, search_command_helper): Use g_source_cache.
1446         * source.h (open_source_file_with_line_charpos): Don't declare.
1447         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1448         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1449         Use g_source_cache.
1450
1451 2019-08-06  Tom Tromey  <tromey@adacore.com>
1452
1453         * source-cache.c (source_cache::get_plain_source_lines):
1454         Remove "first_line" and "last_line" parameters.
1455         (source_cache::get_source_lines): Cache plain text.
1456         * source-cache.h (class source_cache)
1457         <get_plain_source_lines>: Update.
1458
1459 2019-08-06  Tom Tromey  <tromey@adacore.com>
1460
1461         * source-cache.c (extract_lines): No longer a method.
1462         Changed type of parameter.  Include final newline.
1463         (selftests::extract_lines_test): New function.
1464         (_initialize_source_cache): Likewise.
1465         * source-cache.h (class source_cache)
1466         <extract_lines>: Don't declare.
1467
1468 2019-08-06  Tom Tromey  <tromey@adacore.com>
1469
1470         * breakpoint.c (init_breakpoint_sal): Update.
1471         (breakpoint): Update.
1472         * breakpoint.h (struct breakpoint) <filter>: Now a
1473         unique_xmalloc_ptr.
1474
1475 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1476
1477         * NEWS: Mention dictionary access on blocks.
1478         * python/py-block.c (blpy_getitem): New function.
1479         (block_object_as_mapping): New struct.
1480         (block_object_type): Use new struct for tp_as_mapping field.
1481
1482 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1483
1484         * objfiles.h (objfile): Add a comment describing partial symbols.
1485
1486 2019-08-05  Tom Tromey  <tromey@adacore.com>
1487
1488         * compile/compile.c (_initialize_compile): Use _(), not N_().
1489         * thread.c (_initialize_thread): Use _(), not N_().
1490         * stack.c (_initialize_stack): Use _(), not N_().
1491         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1492
1493 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1494
1495         * dwarf2read.c (struct dw2_symtab_iterator):
1496         <want_specific_block>: Remove.
1497         <block_index>: Change type to gdb::optional.
1498         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1499         change type of BLOCK_INDEX parameter to gdb::optional.
1500         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1501         (dw2_lookup_symbol): Don't pass argument for
1502         WANT_SPECIFIC_BLOCK.
1503         (dw2_expand_symtabs_for_function): Don't pass argument for
1504         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1505         (class dw2_debug_names_iterator)
1506         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1507         parameter, change BLOCK_INDEX type to gdb::optional.
1508         <m_want_specific_block>: Remove.
1509         <m_block_index>: Change type to gdb::optional.
1510         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1511         gdb::optional.  Re-write in function of gdb::optional.
1512         (dw2_debug_names_lookup_symbol): Don't pass argument for
1513         WANT_SPECIFIC_BLOCK.
1514         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1515         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1516         BLOCK_INDEX.
1517
1518 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1519
1520         * NEWS: Mention changes to "info sources" command.
1521
1522 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1523
1524         * symtab.c (filename_partial_match_opts): New struct type.
1525         (struct output_source_filename_data): New members
1526         regexp, c_regexp, partial_match.
1527         (output_source_filename): Use new members to decide to print file.
1528         (info_sources_option_defs): New variable.
1529         (make_info_sources_options_def_group, print_info_sources_header,
1530         info_sources_command_completer):
1531         New functions.
1532         (info_sources_command): Read new optional arguments.
1533         (_initialize_symtab): Update info sources help.
1534
1535 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1536
1537         * ada-lang.c (exception_support_info_v0): Renamed from...
1538         (default_exception_support_info): ... this.  Create new
1539         definition for v1.
1540         (ada_has_this_exception_support): Look up catch_handlers_sym.
1541         (ada_exception_support_info_sniffer): Try v0 after default.
1542
1543 2019-08-01  Tom Tromey  <tromey@adacore.com>
1544
1545         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1546         gdbarch.h.
1547
1548 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1549
1550         * s12z-tdep.c: Fix include path for s12z-opc.h.
1551
1552 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1553
1554         * NEWS: Require GNU make 3.82.
1555
1556 2019-07-16  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1559         declare.
1560
1561 2019-07-30  Tom Tromey  <tromey@adacore.com>
1562
1563         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1564
1565 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1566
1567         * printcmd.c (print_address_symbolic): Print negative offsets.
1568         (build_address_symbolic): Force signed arithmetic when computing
1569         offset.
1570
1571 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1572
1573         PR/24474: Add a function to lookup static variables.
1574         * NEWS: Mention this new function.
1575         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1576         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1577         * python/python.c (python_GdbMethods): Add new function.
1578
1579 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1580
1581         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1582         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1583         (objfpy_lookup_static_symbol): New function.
1584         (objfile_object_methods): Add new functions.
1585
1586 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1587
1588         * NEWS: Mention 'set|show print frame-info'.  Mention new
1589         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1590         backtrace argument.  Mention that python frame filtering code
1591         is now consistent with what 'backtrace' command prints.
1592
1593 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1594
1595         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1596         comments.
1597         (print_frame_info_auto, print_frame_info_source_line,
1598         print_frame_info_location, print_frame_info_source_and_location,
1599         print_frame_info_location_and_address, print_frame_info_short_location):
1600         New declarations.
1601         (struct frame_print_options): New member print_frame_info.
1602         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1603         * stack.h (get_user_print_what_frame_info): New declaration.
1604         (frame_show_address): New declaration.
1605         * stack.c (print_frame_arguments_choices): New value 'presence'.
1606         (print_frame_info_auto, print_frame_info_source_line,
1607         print_frame_info_location, print_frame_info_source_and_location,
1608         print_frame_info_location_and_address, print_frame_info_short_location,
1609         print_frame_info_choices, print_frame_info_print_what): New definitions.
1610         (print_frame_args): Only print dots for args if print frame-arguments
1611         is 'presence'.
1612         (frame_print_option_defs): New element for "frame-info".
1613         (get_user_print_what_frame_info): New function.
1614         (frame_show_address): Make non static.  Move comment to stack.h.
1615         (print_frame_info_to_print_what): New function.
1616         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1617         to decide what to print.
1618         (backtrace_command_1): Handle the new print_frame_arguments_presence
1619         value.
1620         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1621         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1622         (py_print_frame): In non-mi mode, use LOCATION as default for
1623         print_what, similarly to frame information printed directly by
1624         backtrace command. Handle frame-info user option in non MI mode.
1625
1626 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1627
1628         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1629         Add case for debugging 32-bit target on 64-bit host.  Revise
1630         comment.
1631
1632 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1633
1634         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1635         instead of find_function_entry_range_from_pc.
1636
1637 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1638
1639         * stack.c (find_frame_funname): Remove code which preferred
1640         minsym over symtab sym in "certain pathological cases".
1641
1642         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1643         parameter.  Change type of "do_demangle" to bool.
1644         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1645         Pass suitable "prefer_sym_over_minsym" flag to
1646         build_address_symbolic().  Don't output "+" for negative offsets.
1647         * printcmd.c (print_address_symbolic): Update invocation of
1648         build_address_symbolic to include a "prefer_sym_over_minsym"
1649         flag.
1650         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1651         Restrict cases in which use of minimal symbol is preferred to that
1652         of a found symbol.  Update comments.
1653
1654         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1655         for entry pc when entry pc is out of range for that FDE.
1656
1657 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1658
1659         PR gdb/24839:
1660         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1661         type.
1662
1663 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1664
1665         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1666         this function's Python signature.
1667
1668
1669 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1670
1671         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1672         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1673         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1674         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1675         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1676
1677
1678 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1679
1680         * h8300-tdep.c (h8300_register_name_common): New.
1681         h8300_register_name): Use h8300_register_name_common.
1682         (h8300s_register_name): Likewise.
1683         (h8300sx_register_name): Likewise.
1684         (h8300h_register_nam): New.
1685         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1686
1687
1688 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1689
1690         * arm-tdep.c (arm_skip_cmse_entry): New function.
1691         (arm_is_sgstubs_section): New function.
1692         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1693
1694 2019-07-22  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1697         Don't self-assign.
1698
1699 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1700
1701         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1702         type_print.
1703
1704 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1705
1706         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1707         so that GDB doesn't match any msymbols when searching in the
1708         TYPES_DOMAIN.
1709         (print_symbol_info): Print using typedef_print or type_print based
1710         on the type of the symbol.  Add updated FIXME comment moved from...
1711         (_initialize_symtab): ... move and update FIXME comment to above.
1712
1713 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1714
1715         * NEWS: Mention adding -q option to "info types".
1716         * symtab.c (struct info_types_options): New struct.
1717         (info_types_options_defs): New variable.
1718         (make_info_types_options_def_group): New function.
1719         (info_types_command): Use gdb::option framework to parse options.
1720         (info_types_command_completer): New function.
1721         (_initialize_symtab): Extend the help text on "info types" and
1722         register command completer.
1723
1724 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1725
1726         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1727         (lookup_symbol_in_objfile): Change int to block_enum and add a
1728         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1729
1730 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1731
1732         * MAINTAINERS (Write After Approval): Add self.
1733
1734 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1735
1736         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1737         instruction to the dummy code region.
1738
1739 2019-07-19  Tom Tromey  <tromey@adacore.com>
1740
1741         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1742         (ARGSUSED, PARAMS, __func__): Remove rules.
1743
1744 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1745
1746         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1747         * features/arm/arm-with-iwmmxt.c: Remove.
1748         * features/arm/arm-with-iwmmxt.xml: Remove.
1749         * features/arm/arm-with-m-fpa-layout.c: Remove.
1750         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1751         * features/arm/arm-with-m-vfp-d16.c: Remove.
1752         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1753         * features/arm/arm-with-m.c: Remove.
1754         * features/arm/arm-with-m.xml: Remove.
1755         * features/arm/arm-with-neon.c: Remove.
1756         * features/arm/arm-with-neon.xml: Remove.
1757         * features/arm/arm-with-vfpv2.c: Remove.
1758         * features/arm/arm-with-vfpv2.xml: Remove.
1759         * features/arm/arm-with-vfpv3.c: Remove.
1760         * features/arm/arm-with-vfpv3.xml: Remove.
1761
1762 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1763
1764         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1765
1766 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1767
1768         * arch/aarch32.c (aarch32_create_target_description): Create
1769         target descriptions using features.
1770         * arch/arm.c (arm_create_target_description)
1771         (arm_create_mprofile_target_description): Likewise.
1772         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1773
1774 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1775
1776         * Makefile.in: Add new files.
1777         * aarch32-tdep.c: New file.
1778         * aarch32-tdep.h: New file.
1779         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1780         Call aarch32_read_description.
1781         * arch/aarch32.c: New file.
1782         * arch/aarch32.h: New file.
1783         * arch/arm.c (arm_create_target_description)
1784         (arm_create_mprofile_target_description): New function.
1785         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1786         (arm_create_target_description)
1787         (arm_create_mprofile_target_description): New declaration.
1788         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1789         read_description functions.
1790         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1791         Likewise.
1792         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1793         * arm-tdep.c (tdesc_arm_list): New variable.
1794         (arm_register_g_packet_guesses): Call create description functions.
1795         (arm_read_description) (arm_read_mprofile_description): New
1796         function.
1797         * arm-tdep.h (arm_read_description)
1798         (arm_read_mprofile_description): Add declaration.
1799         * configure.tgt: Add new files.
1800
1801 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1802
1803         * top.c (new_ui_command): Open specified terminal just once.
1804
1805 2019-07-18  Tom Tromey  <tromey@adacore.com>
1806
1807         * symtab.c (main_name): Constify return type.
1808         * symfile.c (set_initial_language): Update.
1809         * symtab.h (main_name): Constify return type.
1810
1811 2019-07-17  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui-winsource.c (tui_update_source_window)
1814         (tui_update_source_window_as_is)
1815         (tui_update_source_windows_with_line): Remove return.
1816         * tui/tui-disasm.c (tui_show_disassem)
1817         (tui_show_disassem_and_update_source): Remove return.
1818         * tui/tui.c (tui_reset): Remove return.
1819         * tui/tui-wingeneral.c
1820         (tui_check_and_display_highlight_if_needed): Remove return.
1821
1822 2019-07-17  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1825
1826 2019-07-17  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-winsource.h (struct tui_exec_info_window)
1829         (struct tui_source_window_base): Move from tui-data.h.
1830         * tui/tui-winsource.c: Move many method definitions from
1831         elsewhere.  Remove "structuring" comments.
1832         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1833         (tui_source_window_base::refresh_window): Move to
1834         tui-winsource.c.
1835         * tui/tui-win.c (tui_source_window_base::refresh_all)
1836         (tui_source_window_base::update_tab_width)
1837         (tui_source_window_base::set_new_height)
1838         (tui_source_window_base::do_make_visible_with_new_height): Move to
1839         tui-winsource.c.
1840         * tui/tui-source.h: Update.
1841         * tui/tui-source.c (tui_source_window_base::reset): Move to
1842         tui-winsource.c.
1843         * tui/tui-disasm.h: Update.
1844         * tui/tui-data.h (struct tui_exec_info_window): Move to
1845         tui-winsource.h.
1846         (struct tui_source_window_base): Likewise.
1847         * tui/tui-data.c (tui_source_window_base::clear_detail)
1848         (tui_source_window_base, ~tui_source_window_base): Move to
1849         tui-winsource.c.
1850
1851 2019-07-17  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-win.c (tui_resize_all)
1854         (tui_source_window_base::update_tab_width)
1855         (tui_adjust_win_heights): Update.
1856         (tui_win_info::make_invisible_and_set_new_height): Rename from
1857         make_invisible_and_set_new_height.
1858         * tui/tui-data.h (struct tui_win_info)
1859         <make_invisible_and_set_new_height>: New method.
1860
1861 2019-07-17  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui.c: Update.
1864         * tui/tui-source.h (struct tui_source_window): Move from
1865         tui-data.h.
1866         * tui/tui-layout.c: Update.
1867         * tui/tui-disasm.c: Update.
1868         * tui/tui-data.h (struct tui_source_window): Move to
1869         tui-source.h.
1870
1871 2019-07-17  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1874         tui-data.h.
1875         * tui/tui-data.h (struct tui_disasm_window): Move to
1876         tui-disasm.h.
1877
1878 2019-07-17  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-regs.h (struct tui_data_item_window): Move from
1881         tui-data.h.
1882         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1883         * tui/tui-data.h (struct tui_data_item_window): Move to
1884         tui-regs.h.
1885         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1886
1887 2019-07-17  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui.c: Update.
1890         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1891         (tui_cmd_window::max_height): Move to tui-command.c.
1892         * tui/tui-layout.c: Update.
1893         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1894         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1895         tui-command.c.
1896         * tui/tui-command.h (struct tui_cmd_window): Move from
1897         tui-data.h.
1898         * tui/tui-command.c: Remove "structuring" comments.
1899         (tui_cmd_window::clear_detail)
1900         (tui_cmd_window::do_make_visible_with_new_height)
1901         (tui_cmd_window::max_height): Move from elsewhere.
1902
1903 2019-07-17  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1906         Now static.
1907         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1908         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1909
1910 2019-07-17  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui.c: Update.
1913         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1914         tui-regs.c.
1915         * tui/tui-windata.h: Remove file.
1916         * tui/tui-windata.c: Remove file.
1917         * tui/tui-win.c (tui_data_window::set_new_height)
1918         (tui_data_window::do_make_visible_with_new_height): Move to
1919         tui-regs.c.
1920         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1921         * tui/tui-regs.c: Remove "structuring" comments.
1922         (tui_data_window::first_data_item_displayed)
1923         (tui_data_window::delete_data_content_windows)
1924         (tui_data_window::erase_data_content)
1925         (tui_data_window::display_all_data)
1926         (tui_data_window::refresh_all)
1927         (tui_data_window::do_scroll_vertical)
1928         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1929         (tui_data_window::do_make_visible_with_new_height)
1930         (tui_data_window::refresh_window): Move from elsewhere.
1931         (_initialize_tui_regs): Move to end of file.
1932         * tui/tui-layout.c: Update.
1933         * tui/tui-hooks.c: Update.
1934         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1935         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1936         tui-regs.c.
1937         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1938
1939 2019-07-17  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1942         seen.
1943
1944 2019-07-17  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-win.c (tui_source_window_base::set_new_height)
1947         (tui_source_window_base::do_make_visible_with_new_height): Use
1948         m_has_locator field directly.
1949         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1950         method.
1951         (struct tui_source_window_base) <has_locator>: Likewise.
1952
1953 2019-07-17  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1956         Don't declare.
1957         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1958         Remove.
1959         * tui/tui-win.c (tui_source_window_base::set_new_height)
1960         (tui_source_window_base::set_new_height)
1961         (make_invisible_and_set_new_height)
1962         (tui_source_window_base::do_make_visible_with_new_height)
1963         (tui_source_window_base::do_make_visible_with_new_height):
1964         Update.
1965         * tui/tui-layout.c (show_source_disasm_command, show_data)
1966         (show_source_or_disasm_and_command): Update.
1967         * tui/tui-layout.c (show_layout): Update.
1968
1969 2019-07-17  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-layout.c (make_data_window): Remove.
1972         (show_data): Unify creation and re-initialization cases.
1973
1974 2019-07-17  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-layout.c (make_source_window, make_disasm_window):
1977         Remove.
1978         (show_data): Unify creation and re-initialization cases.
1979
1980 2019-07-17  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-layout.c (make_command_window): Remove.
1983         (show_source_disasm_command, show_source_or_disasm_and_command):
1984         Unify creation and re-initialization cases.
1985
1986 2019-07-17  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1989         creation and re-initialization cases.
1990
1991 2019-07-17  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-regs.c (tui_get_register): Return void.
1994
1995 2019-07-17  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1998         Simplify.
1999
2000 2019-07-17  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2003         resetting.
2004
2005 2019-07-17  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2008         * tui/tui-regs.c (tui_reg_layout): New function.
2009         (tui_show_registers, tui_reg_command): Use it.
2010         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2011         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2012         parameters.
2013         (tui_layout_command): Remove.
2014
2015 2019-07-17  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-layout.h (tui/tui-layout): Return void.
2018         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2019
2020 2019-07-17  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-layout.c (show_source_disasm_command, show_data):
2023         Update.
2024         (reset_locator): Remove.
2025         (show_source_or_disasm_and_command): Update.
2026
2027 2019-07-17  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-source.c (tui_source_window_base::reset): Remove
2030         win_type parameter.
2031         * tui/tui-layout.c (make_command_window, make_source_window)
2032         (make_disasm_window, make_data_window)
2033         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2034         (reset_locator, show_source_or_disasm_and_command): Update.
2035         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2036         win_type parameter.
2037         (struct tui_source_window_base) <reset>: Likewise.
2038
2039 2019-07-17  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui-layout.c (show_source_disasm_command): Use
2042         reset_locator.
2043         (reset_locator): New function.
2044         (init_and_make_win): Remove.
2045         (show_source_or_disasm_and_command): Use reset_locator.
2046
2047 2019-07-17  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2050         condition.
2051         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2052         Remove condition.
2053         * tui/tui-source.c (tui_source_window_base::reset): New method.
2054         * tui/tui-layout.c (make_command_window): Don't call
2055         init_and_make_win.
2056         (make_source_window, make_disasm_window): Don't call
2057         make_source_or_disasm_window.
2058         (make_data_window): Don't call init_and_make_win.  Change calling
2059         convention.
2060         (show_source_disasm_command, show_data): Simplify.
2061         (make_source_or_disasm_window): Remove.
2062         (show_source_or_disasm_and_command): Simplify.
2063         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2064         (struct tui_source_window_base) <reset>: Likewise.
2065         <execution_info>: Remove initializer.
2066         * tui/tui-data.c (tui_source_window_base): Initialize
2067         execution_info.
2068
2069 2019-07-17  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2072         variable.
2073
2074 2019-07-17  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui.c (tui_rl_other_window): Update.
2077         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2078         superclass method first.  Always iterate over regs_content.
2079         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2080         method.
2081         * tui/tui-win.c (tui_set_focus_command): Update.
2082
2083 2019-07-17  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-win.c (tui_set_focus_command): Rename from
2086         tui_set_focus.  Call tui_enable.
2087         (tui_set_focus_command): Remove.
2088
2089 2019-07-17  Tom Tromey  <tom@tromey.com>
2090
2091         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2092         refresh_window.
2093         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2094         touchwin.
2095         (tui_data_window::refresh_window): Call refresh_window on data
2096         items.  Always call superclass refresh_window.
2097         (tui_win_info::refresh): Remove.
2098         (tui_source_window_base::refresh_window): Update.
2099         (tui_refresh_all): Update.
2100         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2101         refresh_window.
2102         (show_source_or_disasm_and_command): Likewise.
2103         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2104         (struct tui_source_window_base) <refresh>: Likewise.
2105
2106 2019-07-17  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-winsource.c (tui_clear_source_content)
2109         (tui_show_source_content): Update.
2110         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2111         whether content is empty.
2112         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2113         Remove.
2114
2115 2019-07-17  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2118         window's contents.
2119         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2120         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2121
2122 2019-07-17  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2125         (struct tui_data_item_window): Update.
2126
2127 2019-07-17  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2130         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2131         defines.
2132
2133 2019-07-17  Tom Tromey  <tom@tromey.com>
2134
2135         * tui/tui-winsource.h (tui_erase_source_content)
2136         (tui_clear_source_content): Remove "display_prompt" parameter.
2137         * tui/tui-winsource.c (tui_update_source_window_as_is)
2138         (tui_update_source_windows_with_addr): Update.
2139         (tui_clear_source_content): Remove "display_prompt" parameter.
2140         (tui_erase_source_content): Likewise.  Simplify.
2141         (tui_show_source_content): Update.
2142         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2143         * tui/tui-stack.c (tui_show_frame_info): Update.
2144         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2145         Remove defines.
2146
2147 2019-07-17  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2150         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2151         parameter.
2152         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2153         parameter.
2154
2155 2019-07-17  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-winsource.c (tui_clear_source_content)
2158         (tui_show_source_content, tui_show_exec_info_content)
2159         (tui_clear_exec_info_content): Update.
2160         * tui/tui-stack.c (tui_show_locator_content): Update.
2161         (tui_show_frame_info): Update.
2162         * tui/tui-source.h (tui_source_window): Don't declare.
2163         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2164         from tui_source_is_displayed.
2165         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2166         Remove field.
2167         (struct tui_source_window_base) <content_in_use>: New field.  Now
2168         bool.
2169         (struct tui_source_window) <showing_source_p>: New method.
2170         (TUI_SRC_WIN): Change cast.
2171         * tui/tui-data.c (tui_initialize_static_data): Update.
2172
2173 2019-07-17  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2176         location_matches_p.
2177         * tui/tui-source.c (tui_source_window::location_matches_p): New
2178         method.
2179         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2180         method.
2181         * tui/tui-data.h (struct tui_source_window_base)
2182         <location_matches_p>: New method.
2183         (struct tui_source_window, struct tui_disasm_window)
2184         <location_matches_p>: Likewise.
2185
2186 2019-07-17  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-win.c (tui_set_win_height_command): Rename from
2189         tui_set_win_height.
2190         (tui_set_win_height_command): Remove.
2191
2192 2019-07-17  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-source.c (tui_source_window): New constructor.  Add
2195         observer.
2196         (~tui_source_window): New destructor.
2197         (tui_source_window::style_changed): New method.
2198         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2199         (tui_attach_detach_observers): Update.
2200         * tui/tui-data.h (struct tui_source_window): Make constructor not
2201         inline.  Add destructor.
2202         (struct tui_source_window) <style_changed>: New method.
2203         <m_observable>: New member.
2204
2205 2019-07-17  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2208         * tui/tui-win.c (tui_resize_all): Fix typo.
2209
2210 2019-07-17  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2213         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2214         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2215         * tui/tui-win.c (window_name_completer): Use foreach.
2216         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2217         (update_tab_width): Likewise.
2218         * tui/tui-layout.c (show_layout): Update.
2219         * tui/tui-data.h (class tui_window_iterator): New.
2220         (struct all_tui_windows): New.
2221         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2222
2223 2019-07-17  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2226         parameter.  Don't reference globals.
2227         (tui_reg_command): Update.
2228
2229 2019-07-17  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-regs.c (tui_show_registers): Simplify.
2232
2233 2019-07-17  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-regs.c (tui_show_registers): Update.
2236         (tui_show_register_group): Add win_info parameter.
2237
2238 2019-07-17  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2241         Rename from tui_display_reg_element_at_line.
2242         (tui_data_window::display_registers_from_line): Update.
2243         * tui/tui-data.h (struct tui_data_window)
2244         <display_reg_element_at_line>: New method.
2245
2246 2019-07-17  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-regs.h (tui_display_registers_from)
2249         (tui_display_registers_from_line): Don't declare.
2250         * tui/tui-windata.c (tui_data_window::display_all_data)
2251         (tui_data_window::refresh_all)
2252         (tui_data_window::do_scroll_vertical): Update.
2253         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2254         from tui_display_registers_from.
2255         (tui_display_reg_element_at_line): Update.
2256         (tui_data_window::display_registers_from_line): Rename from
2257         tui_display_registers_from_line.
2258         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2259         display_registers_from_line>: New methods.
2260
2261 2019-07-17  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2264         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2265         from tui_erase_data_content.
2266         (tui_data_window::display_all_data)
2267         (tui_data_window::refresh_all)
2268         (tui_data_window::do_scroll_vertical): Update.
2269         * tui/tui-regs.c (tui_show_registers): Update.
2270         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2271         New method.
2272
2273 2019-07-17  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2276         declare.
2277         * tui/tui-windata.c
2278         (tui_data_window::delete_data_content_windows): Rename from
2279         tui_delete_data_content_windows.
2280         (tui_data_window::display_all_data)
2281         (tui_data_window::do_scroll_vertical): Update.
2282         * tui/tui-data.h (struct tui_data_window)
2283         <delete_data_content_windows>: New method.
2284
2285 2019-07-17  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2288         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2289
2290 2019-07-17  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2293         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2294         from tui_display_all_data.
2295         * tui/tui-win.c
2296         (tui_data_window::do_make_visible_with_new_height): Update.
2297         * tui/tui-regs.c (tui_show_registers): Update.
2298         * tui/tui-layout.c (tui_set_layout): Update.
2299         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2300         method.
2301
2302 2019-07-17  Tom Tromey  <tom@tromey.com>
2303
2304         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2305         * tui/tui-windata.c (tui_display_data_from): Remove.
2306         (tui_data_window::refresh_all): Update.
2307
2308 2019-07-17  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2311         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2312         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2313         tui_display_registers_from_line.
2314         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2315         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2316         "force_display" parameter.
2317
2318 2019-07-17  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2321         declare.
2322         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2323         Rename from tui_first_reg_element_no_inline.
2324         (tui_display_reg_element_at_line)
2325         (tui_display_registers_from_line): Update.
2326         * tui/tui-data.h (struct tui_data_window)
2327         <first_reg_element_no_inline>: New method.
2328
2329 2019-07-17  Tom Tromey  <tom@tromey.com>
2330
2331         * tui/tui-windata.c (tui_display_data_from)
2332         (tui_data_window::do_scroll_vertical): Update.
2333         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2334         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2335         Rename from tui_line_from_reg_element_no.
2336         (tui_display_registers_from_line): Update.
2337         * tui/tui-data.h (struct tui_data_window)
2338         <line_from_reg_element_no>: New method.
2339
2340 2019-07-17  Tom Tromey  <tom@tromey.com>
2341
2342         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2343         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2344         tui_last_regs_line_no.
2345         (tui_display_reg_element_at_line)
2346         (tui_display_registers_from_line): Update.
2347         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2348         method.
2349
2350 2019-07-17  Tom Tromey  <tom@tromey.com>
2351
2352         PR tui/24722:
2353         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2354         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2355         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2356         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2357         (tui_update_breakpoint_info): Likewise.
2358         * tui/tui-hooks.c (tui_event_create_breakpoint)
2359         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2360         Update.
2361
2362 2019-07-17  Tom Tromey  <tom@tromey.com>
2363
2364         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2365
2366 2019-07-17  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-winsource.c (tui_update_source_window_as_is)
2369         (tui_update_source_windows_with_addr): Update.
2370         * tui/tui-source.h (tui_set_source_content)
2371         (tui_show_symtab_source): Add "win_info" parameter.
2372         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2373         parameter.
2374         (tui_show_symtab_source): Likewise.
2375
2376 2019-07-17  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-wingeneral.c
2379         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2380
2381 2019-07-17  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2384         (struct tui_cmd_window) <can_scroll>: New method.
2385         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2386         method.
2387
2388 2019-07-17  Tom Tromey  <tromey@adacore.com>
2389
2390         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2391         do_field_signed>: Rename.  Change type of "value".
2392         * ui-out.c (ui_out::field_signed): Rename from field_int.
2393         Change type of "value".
2394         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2395         type of "value".
2396         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2397         do_field_int.  Change type of "value".
2398         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2399         do_field_int.  Change type of "value".
2400         * tracepoint.c (trace_status_mi, tfind_1)
2401         (print_one_static_tracepoint_marker): Update.
2402         * thread.c (print_thread_info_1, print_selected_thread_frame):
2403         Update.
2404         * stack.c (print_frame, print_frame_info): Update.
2405         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2406         Update.
2407         * source.c (print_source_lines_base): Update.
2408         * skip.c (info_skip_command): Update.
2409         * record-btrace.c (btrace_ui_out_decode_error)
2410         (btrace_call_history_src_line): Update.
2411         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2412         Update.
2413         * progspace.c (print_program_space): Update.
2414         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2415         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2416         do_field_int.  Change type of "value".
2417         * mi/mi-out.c (mi_ui_out::do_table_begin)
2418         (mi_ui_out::do_table_header): Update.
2419         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2420         type of "value".
2421         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2422         (mi_cmd_data_list_changed_registers, output_register)
2423         (mi_cmd_data_read_memory, mi_load_progress)
2424         (mi_cmd_trace_frame_collected): Update.
2425         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2426         Update.
2427         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2428         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2429         (mi_cmd_var_list_children, varobj_update_one): Update.
2430         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2431         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2432         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2433         * inferior.c (print_inferior): Update.
2434         * gdb_bfd.c (print_one_bfd): Update.
2435         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2436         Update.
2437         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2438         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2439         do_field_int.  Change type of "value".
2440         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2441         do_field_int.  Change type of "value".
2442         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2443         (print_one_breakpoint_location, print_it_catch_fork)
2444         (print_one_catch_fork, print_it_catch_vfork)
2445         (print_one_catch_vfork, print_it_catch_solib)
2446         (print_it_catch_exec, print_it_ranged_breakpoint)
2447         (print_mention_watchpoint, print_mention_masked_watchpoint)
2448         (bkpt_print_it, update_static_tracepoint): Update.
2449         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2450         * break-catch-syscall.c (print_it_catch_syscall): Update.
2451         * ada-tasks.c (print_ada_task_info): Update.
2452         * ada-lang.c (print_it_exception, print_mention_exception):
2453         Update.
2454
2455 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2456
2457         PR breakpoints/24541
2458         * gdbarch.c: Regenerate.
2459         * gdbarch.h: Regenerate.
2460         * gdbarch.sh: Adjust return type and parameter types for
2461         'stap_adjust_register'.
2462         (i386_stap_adjust_register): Adjust signature and return new
2463         register name.
2464         * stap-probe.c (stap_parse_register_operand): Adjust use of
2465         'gdbarch_stap_adjust_register'.
2466
2467 2019-07-17  Tom Tromey  <tromey@adacore.com>
2468
2469         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2470         declare VEC.
2471         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2472         std::vector.
2473         (struct s390_process_info): Add initializers.
2474         (s390_add_process): Use new.
2475         (s390_linux_nat_target::low_forget_process): Use delete.
2476         (s390_linux_nat_target::low_new_fork)
2477         (s390_linux_nat_target::stopped_by_watchpoint)
2478         (s390_linux_nat_target::low_prepare_to_resume)
2479         (s390_linux_nat_target::insert_watchpoint)
2480         (s390_linux_nat_target::insert_hw_breakpoint)
2481         (s390_linux_nat_target::remove_watchpoint)
2482         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2483
2484 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2485
2486         * aarch64-fbsd-nat.c: Include regcache.h.
2487         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2488         argument.
2489         (aarch64_fbsd_nat_target::fetch_registers)
2490         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2491         variable.
2492         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2493
2494 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2495
2496         * fbsd-nat.c: Include gdbarch.h.
2497
2498 2019-07-15  Tom Tromey  <tromey@adacore.com>
2499
2500         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2501
2502 2019-07-15  Tom Tromey  <tromey@adacore.com>
2503
2504         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2505         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2506         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2507         * cli-out.c (cli_ui_out::do_field_int): New method.
2508         * ui-out.c (ui_out::field_unsigned): New method.
2509         * symfile.c (generic_load): Use field_unsigned.
2510         (print_transfer_performance): Likewise.
2511         * record-btrace.c (ui_out_field_uint): Remove.
2512         (btrace_call_history_insn_range, btrace_call_history): Use
2513         field_unsigned.
2514         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2515         field_unsigned.
2516         * ui-out.h (class ui_out) <field_unsigned>: New method.
2517         <do_field_unsigned>: Likewise.
2518
2519 2019-07-15  Tom Tromey  <tromey@adacore.com>
2520
2521         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2522         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2523         * target.c (flash_erase_command): Use field_string.
2524         * infrun.c (print_signal_received_reason): Use field_string.
2525         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2526         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2527         field_string.
2528         * ada-tasks.c (print_ada_task_info): Use field_string.
2529
2530 2019-07-15  Tom Tromey  <tromey@adacore.com>
2531
2532         * target.c (flash_erase_command): Use field_core_addr.
2533         * symfile.c (generic_load): Use field_core_addr.
2534         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2535         Use field_core_addr.
2536         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2537         field_core_addr.
2538
2539 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2540
2541         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2542         value if its desired type is smaller than a CORE_ADDR and signed.
2543
2544 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2545
2546         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2547         of changes to field names, and use new is_reference field to
2548         decide if a property is a reference or not.
2549         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2550         field.
2551         (struct dwarf2_property_baton): Update header comment, rename
2552         'referenced_type' to 'property_type' and update comments.
2553         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2554         default property type, store in property baton, update to take
2555         accound of renamed field.
2556         (read_func_scope): Update call to attr_to_dynamic_prop.
2557         (read_array_type): Likewise.
2558         (dwarf2_per_cu_addr_sized_int_type): New function.
2559         (read_subrange_index_type): Move type finding code to
2560         dwarf2_per_cu_addr_sized_int_type.
2561         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2562         (dwarf2_per_cu_addr_type): New function.
2563         (set_die_type): Update calls to attr_to_dynamic_prop.
2564
2565 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * dwarf2read.c (read_subrange_index_type): New function.
2568         (read_subrange_type): Move code into new function and call it.
2569         * gdbtypes.c (create_range_type): Add some asserts.
2570
2571 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2572
2573         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2574         update return statements.
2575         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2576         declaration, and update comment to match.
2577         * gdbtypes.c (resolve_dynamic_array): Update call to
2578         dwarf2_evaluate_property to match new return type.
2579
2580 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2581
2582         * valarith.c (value_subscripted_rvalue): Change lowerbound
2583         parameter type from int to LONGEST.
2584         * value.h (value_subscripted_rvalue): Likewise in declaration.
2585
2586 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2587
2588         * cli/cli-utils.c (info_print_command_completer): New function.
2589         * cli/cli-utils.h: Add 'completer.h' include, and forward
2590         declaration for 'struct cmd_list_element'.
2591         (info_print_command_completer): Declare.
2592         * stack.c (_initialize_stack): Add completer for 'info locals' and
2593         'info args'.
2594         * symtab.c (_initialize_symtab): Add completer for 'info
2595         variables' and 'info functions'.
2596         * NEWS: Mention completion for additional info commands.
2597
2598 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2599
2600         * cli/cli-utils.c (extract_info_print_args): Delete.
2601         (extract_arg_maybe_quoted): Delete.
2602         (info_print_options_defs): New variable.
2603         (make_info_print_options_def_group): New function.
2604         (extract_info_print_options): Define new function.
2605         * cli/cli-utils.h (extract_info_print_args): Delete.
2606         (struct info_print_options): New structure.
2607         (extract_info_print_options): Declare new function.
2608         * stack.c (info_locals_command): Update to use new
2609         extract_info_print_options, also add a header comment.
2610         (info_args_command): Likewise.
2611         * symtab.c (info_variables_command): Likewise.
2612         (info_functions_command): Likewise.
2613
2614 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2615
2616         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2617         to extract string arguments.
2618         * common/common-utils.c (extract_string_maybe_quoted): New function.
2619         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2620
2621 2019-07-11  Tom Tromey  <tromey@adacore.com>
2622
2623         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2624         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2625         * top.h (gdbinit): Don't declare.
2626         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2627         into...
2628         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2629         * top.c (gdb_init): Don't call init_cli_cmds.
2630         (gdbinit): Remove.
2631         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2632
2633 2019-07-11  Tom Tromey  <tromey@adacore.com>
2634
2635         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2636         after it has been moved.
2637
2638 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2639
2640         * valops.c (value_must_coerce_to_target): Change return type to
2641         bool.
2642         * value.h (value_must_coerce_to_target): Likewise.
2643
2644 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2645
2646         * breakpoint.c (is_hardware_watchpoint): Remove
2647         forward-declaration.
2648         (is_masked_watchpoint): Change return type to bool.
2649         (is_tracepoint): Likewise.
2650         (is_breakpoint): Likewise.
2651         (is_hardware_watchpoint): Likewise.
2652         (is_watchpoint): Likewise.
2653         (is_no_memory_software_watchpoint): Likewise.
2654         (is_catchpoint): Likewise.
2655         (breakpoint_1): Make FILTER parameter's return type bool.
2656         is_masked_watchpoint): Change return type to bool.
2657         (save_breakpoints): Make FILTER parameter's return type bool.
2658         * breakpoint.h (is_breakpoint): Change return type to bool.
2659         (is_watchpoint): Likewise.
2660         (is_catchpoint): Likewise.
2661         (is_tracepoint): Likewise.
2662
2663 2019-07-10  Tom Tromey  <tom@tromey.com>
2664
2665         * defs.h: Don't include gdbarch.h.
2666         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2667         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2668         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2669         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2670         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2671         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2672         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2673         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2674         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2675         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2676         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2677         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2678         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2679         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2680         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2681         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2682         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2683         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2684         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2685         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2686         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2687         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2688         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2689         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2690         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2691         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2692         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2693
2694 2019-07-10  Tom Tromey  <tromey@adacore.com>
2695
2696         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2697         * breakpoint.c (init_ada_exception_breakpoint): Register as
2698         bp_catchpoint.
2699         (print_one_breakpoint_location, print_one_breakpoint): Use
2700         is_ada_exception_catchpoint.
2701         * ada-lang.c (class ada_catchpoint_location): Pass
2702         bp_loc_software_breakpoint to bp_location constructor.
2703         (is_ada_exception_catchpoint): New function.
2704
2705 2019-07-10  Tom Tromey  <tromey@adacore.com>
2706
2707         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2708         VEC.
2709         (struct arm_exidx_entry): New method operator<.
2710         (struct arm_exidx_data) <section_maps>: Change type.
2711         (arm_exidx_data_free): Remove.
2712         (arm_exidx_data_key): Change type.  Move lower.
2713         (arm_exidx_new_objfile): Update.
2714         (arm_compare_exidx_entries): Remove.
2715         (arm_find_exidx_entry, _initialize_arm_tdep)
2716
2717 2019-07-10  Tom Tromey  <tromey@adacore.com>
2718
2719         * solib-spu.c (ocl_program_data_key): Change type.
2720         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2721         Update.
2722
2723 2019-07-10  Tom Tromey  <tromey@adacore.com>
2724
2725         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2726         (struct solib_aix_inferior_data) <library_list>: Change type.
2727         (solib_aix_inferior_data_handle): Change type.
2728         (get_solib_aix_inferior_data): Update.
2729         (solib_aix_free_library_list): Remove.
2730         (library_list_start_library): Update.
2731         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2732         return type.
2733         (solib_aix_get_library_list)
2734         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2735         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2736
2737 2019-07-10  Tom Tromey  <tromey@adacore.com>
2738
2739         * solib-dsbt.c (struct dsbt_info): Add initializers.
2740         (solib_dsbt_pspace_data): Change type.
2741         (dsbt_pspace_data_cleanup): Remove.
2742         (get_dsbt_info, _initialize_dsbt_solib): Update.
2743
2744 2019-07-10  Tom Tromey  <tromey@adacore.com>
2745
2746         * spu-tdep.c (spu_overlay_data): Change type.
2747         (spu_get_overlay_table, spu_overlay_new_objfile)
2748         (_initialize_spu_tdep): Update.
2749
2750 2019-07-10  Tom Tromey  <tromey@adacore.com>
2751
2752         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2753         destructor.
2754         (dbx_objfile_data_key): Change type and declare later.
2755         (DBX_SYMFILE_INFO): Rewrite.
2756         * dbxread.c (dbx_objfile_data_key): Change type.
2757         (dbx_symfile_init): Update.
2758         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2759         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2760         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2761
2762 2019-07-10  Tom Tromey  <tromey@adacore.com>
2763
2764         * jit.c (jit_program_space_key): Change type.  Move lower.
2765         (get_jit_program_space_data): Update.
2766         (jit_program_space_data_cleanup): Remove.
2767         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2768         Update.
2769         (struct jit_program_space_data): Add initializers.
2770
2771 2019-07-10  Tom Tromey  <tromey@adacore.com>
2772
2773         * solib-darwin.c (struct darwin_info): Add initializers.
2774         (solib_darwin_pspace_data): Change type.
2775         (darwin_pspace_data_cleanup): Remove.
2776         (get_darwin_info, _initialize_darwin_solib): Update.
2777
2778 2019-07-10  Tom Tromey  <tromey@adacore.com>
2779
2780         * remote-sim.c (struct sim_inferior_data): Add initializers,
2781         constructor, and destructor.
2782         (sim_inferior_data_key): Change type.  Move lower.
2783         (check_for_duplicate_sim_descriptor): Update.
2784         (get_sim_inferior_data): Use new.  Update.
2785         (~sim_inferior_data_cleanup): Rename from
2786         sim_inferior_data_cleanup.  Simplify.
2787         (gdbsim_close_inferior, simulator_command)
2788         (sim_command_completer, _initialize_remote_sim): Update.
2789         (next_pid, INITIAL_PID): Move earlier.
2790
2791 2019-07-10  Tom Tromey  <tromey@adacore.com>
2792
2793         * python/python-internal.h (create_thread_object): Return
2794         gdbpy_ref.
2795         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2796         * python/py-inferior.c (struct threadlist_entry): Add
2797         constructor.
2798         <thread_obj>: Now a gdbpy_ref.
2799         (thread_to_thread_object): Update.
2800         (add_thread_object): Use new.
2801         (delete_thread_object): Use delete.
2802         (infpy_threads): Update.
2803         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2804         GIL.
2805
2806 2019-07-10  Tom Tromey  <tromey@adacore.com>
2807
2808         * valops.c (value_cast): Specialize error message for Ada.
2809
2810 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2811
2812         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2813
2814 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2815
2816         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2817         bpstat_should_step): Return bool, adjust comments.
2818         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2819         bpstat_should_step): Likewise.
2820
2821 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2822
2823         * features/Makefile: Use feature target descriptions for Arm.
2824         * features/arm/arm-core.c: Generate new file.
2825         * features/arm/arm-fpa.c: Likewise.
2826         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2827         * features/arm/arm-m-profile.c: Likewise.
2828         * features/arm/arm-vfpv2.c: Likewise.
2829         * features/arm/arm-vfpv3.c: Likewise.
2830         * features/arm/xscale-iwmmxt.c: Likewise.
2831         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2832
2833 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2834
2835         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2836         ptrace earlier.
2837
2838 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2839
2840         * features/aarch64-pauth.c: Regenerate.
2841
2842 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2843
2844         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2845         bool.
2846         (bpstat_what): Use false instead of 0.
2847
2848 2019-07-09  Pedro Alves  <palves@redhat.com>
2849
2850         * break-catch-throw.c (is_exception_catchpoint): New.
2851         * breakpoint.c (print_one_breakpoint_location): New parameter
2852         'raw_loc'.  Handle it.  Use
2853         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2854         looking at the breakpoint's type.
2855         (print_one_breakpoint): If handling "maint info breakpoints", also
2856         print locations of exception catchpoints.
2857         * breakpoint.h (is_exception_catchpoint): Declare.
2858
2859 2019-07-09  Pedro Alves  <palves@redhat.com>
2860
2861         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2862         "addr" field.
2863         (allocate_location_exception_catchpoint): New.
2864         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2865         (initialize_throw_catchpoint_ops): Install
2866         allocate_location_exception_catchpoint as allocate_location
2867         method.
2868         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2869         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2870         bp_loc_other.
2871         (breakpoint_address_is_meaningful): Delete.
2872         (bl_address_is_meaningful): New.
2873         (breakpoint_locations_match): Adjust comment.
2874         (bp_location_from_bp_type): New, factored out of...
2875         (bp_location::bp_location(breakpoint *)): ... this.
2876         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2877         factored out of...
2878         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2879         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2880         breakpoint_address_is_meaningful.
2881         (bp_locations_compare): Adjust comment.
2882         (update_global_location_list): Use bl_address_is_meaningful
2883         instead of breakpoint_address_is_meaningful.
2884         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2885         explicit.
2886         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2887         * python/py-breakpoint.c (bppy_get_location): No longer check
2888         whether location is null.
2889
2890 2019-07-09  Pedro Alves  <palves@redhat.com>
2891
2892         PR c++/15468
2893         * breakpoint.c (print_one_breakpoint_location): Remove
2894         single-location assert.
2895
2896 2019-07-09  Tom Tromey  <tom@tromey.com>
2897
2898         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2899         * configure: Rebuild.
2900         * configure.ac: Change common to gdbsupport.
2901         * gdbsupport: Rename from common.
2902         * acinclude.m4: Change common to gdbsupport.
2903         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2904         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2905         gdbsupport.
2906         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2907         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2908         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2909         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2910         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2911         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2912         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2913         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2914         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2915         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2916         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2917         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2918         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2919         coff-pe-read.c, command.h, compile/compile-c-support.c,
2920         compile/compile-c.h, compile/compile-cplus-symbols.c,
2921         compile/compile-cplus-types.c, compile/compile-cplus.h,
2922         compile/compile-loc2c.c, compile/compile.c, completer.c,
2923         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2924         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2925         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2926         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2927         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2928         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2929         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2930         features/aarch64-core.c, features/aarch64-fpu.c,
2931         features/aarch64-pauth.c, features/aarch64-sve.c,
2932         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2933         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2934         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2935         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2936         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2937         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2938         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2939         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2940         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2941         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2942         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2943         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2944         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2945         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2946         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2947         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2948         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2949         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2950         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2951         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2952         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2953         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2954         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2955         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2956         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2957         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2958         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2959         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2960         minsyms.c, mips-linux-tdep.c, namespace.h,
2961         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2962         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2963         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2964         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2965         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2966         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2967         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2968         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2969         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2970         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2971         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2972         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2973         procfs.c, producer.c, progspace.h, psymtab.h,
2974         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2975         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2976         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2977         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2978         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2979         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2980         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2981         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2982         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2983         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2984         target-memory.c, target.c, target.h, target/waitstatus.c,
2985         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2986         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2987         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2988         unittests/array-view-selftests.c,
2989         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2990         unittests/common-utils-selftests.c,
2991         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2992         unittests/format_pieces-selftests.c,
2993         unittests/function-view-selftests.c,
2994         unittests/lookup_name_info-selftests.c,
2995         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2996         unittests/mkdir-recursive-selftests.c,
2997         unittests/observable-selftests.c,
2998         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2999         unittests/parse-connection-spec-selftests.c,
3000         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3001         unittests/scoped_fd-selftests.c,
3002         unittests/scoped_mmap-selftests.c,
3003         unittests/scoped_restore-selftests.c,
3004         unittests/string_view-selftests.c, unittests/style-selftests.c,
3005         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3006         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3007         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3008         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3009         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3010         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3011
3012 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3015         bool value.
3016         (decode_digits_ordinary): Set explicit_line field in sal.
3017         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3018         symtab_and_line that was set on an explicit line number in
3019         assembler code.  Do always update the recorded symtab and line if
3020         we do skip the prologue.
3021
3022 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3023
3024         * breakpoint.c (set_breakpoint_location_function): Remove
3025         explicit_loc parameter.
3026         (momentary_breakpoint_from_master): Update call to
3027         set_breakpoint_location_function.
3028         (add_location_to_breakpoint): Likewise.
3029
3030 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3031
3032         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3033         required features based on default bfd type when no specific bfd
3034         is present.
3035
3036 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3037
3038         * NEWS: Mention that GDB printf and eval commands can now print
3039         C-style and Ada-style convenience var strings without
3040         calling the inferior.
3041         * printcmd.c (printf_c_string): Locally print GDB internal var
3042         instead of transiting via the inferior.
3043         (printf_wide_c_string): Likewise.
3044
3045 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3046
3047         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3048
3049 2019-07-04  Tom Tromey  <tom@tromey.com>
3050
3051         PR tui/24724:
3052         * tui/tui-winsource.c (tui_clear_source_content): Update.
3053         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3054         (tui_update_breakpoint_info): Update.
3055         (tui_set_exec_info_content): Update.
3056         * tui/tui-source.c (tui_set_source_content_nil): Update.
3057         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3058         has_break.
3059         * tui/tui-data.h (enum tui_bp_flag): New.
3060         (tui_bp_flags): New enum flags type.
3061         (struct tui_source_element) <break_mode>: Change type.  Rename
3062         from has_break.
3063         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3064         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3065         constants.
3066         * tui/tui-winsource.h: Fix comment.
3067
3068 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3069
3070         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3071         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3072         (store_fpregs_to_thread)
3073         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3074         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3075         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3076         (IWMMXT_REGS_SIZE): Add define.
3077         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3078         (fetch_vfp_regs, store_vfp_regs)
3079         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3080         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3081
3082 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3083
3084         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3085         defines.
3086         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3087         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3088         (ARM_INT_REGISTER_SIZE): ...to this.
3089         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3090         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3091         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3092         (arm_linux_collect_gregset, supply_nwfpe_register)
3093         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3094         defines.
3095         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3096         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3097         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3098         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3099         (arm_return_in_memory, arm_store_return_value)
3100         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3101         (arm_record_ld_st_multiple): Likewise.
3102         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3103         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3104
3105 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3106
3107         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3108         AARCH64_DISPLACED_MODIFIED_INSNS.
3109         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3110         (aarch64_displaced_step_copy_insn): Likewise.
3111         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3112         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3113         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3114         ARM_DISPLACED_MODIFIED_INSNS.
3115         * arm-tdep.c (arm_gdbarch_init): Likewise.
3116         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3117         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3118         (struct arm_displaced_step_closure): Use
3119         ARM_DISPLACED_MODIFIED_INSNS.
3120
3121 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3122
3123         * features/Makefile: Remove unused xml files.
3124         * features/aarch64.xml: Remove.
3125         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3126         * features/i386/amd64-avx-avx512.xml: Remove.
3127         * features/i386/amd64-avx-linux.xml: Remove.
3128         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3129         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3130         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3131         * features/i386/amd64-avx-mpx.xml: Remove.
3132         * features/i386/amd64-avx.xml: Remove.
3133         * features/i386/amd64-linux.xml: Remove.
3134         * features/i386/amd64-mpx-linux.xml: Remove.
3135         * features/i386/amd64-mpx.xml: Remove.
3136         * features/i386/amd64.xml: Remove.
3137         * features/i386/i386-avx-avx512-linux.xml: Remove.
3138         * features/i386/i386-avx-avx512.xml: Remove.
3139         * features/i386/i386-avx-linux.xml: Remove.
3140         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3141         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3142         * features/i386/i386-avx-mpx-linux.xml: Remove.
3143         * features/i386/i386-avx-mpx.xml: Remove.
3144         * features/i386/i386-avx.xml: Remove.
3145         * features/i386/i386-linux.xml: Remove.
3146         * features/i386/i386-mmx-linux.xml: Remove.
3147         * features/i386/i386-mmx.xml: Remove.
3148         * features/i386/i386-mpx-linux.xml: Remove.
3149         * features/i386/i386-mpx.xml: Remove.
3150         * features/i386/i386.xml: Remove.
3151         * features/i386/x32-avx-avx512-linux.xml: Remove.
3152         * features/i386/x32-avx-linux.xml: Remove.
3153         * features/i386/x32-linux.xml: Remove.
3154
3155 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3156
3157         * regformats/aarch64.dat: Remove.
3158         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3159         * regformats/i386/amd64-avx-linux.dat: Remove.
3160         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3161         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3162         * regformats/i386/amd64-linux.dat: Remove.
3163         * regformats/i386/amd64-mpx-linux.dat: Remove.
3164         * regformats/i386/amd64.dat: Remove.
3165         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3166         * regformats/i386/i386-avx-linux.dat: Remove.
3167         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3168         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3169         * regformats/i386/i386-linux.dat: Remove.
3170         * regformats/i386/i386-mmx-linux.dat: Remove.
3171         * regformats/i386/i386-mpx-linux.dat: Remove.
3172         * regformats/i386/i386.dat: Remove.
3173         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3174         * regformats/i386/x32-avx-linux.dat: Remove.
3175         * regformats/i386/x32-linux.dat: Remove.
3176
3177 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3178
3179         * aarch64-tdep.c: Remove xml self tests.
3180         * amd64-linux-tdep.c: Likewise.
3181         * amd64-tdep.c: Likewise.
3182         * i386-linux-tdep.c: Likewise.
3183         * i386-tdep.c: Likewise.
3184
3185 2019-07-03  Pedro Alves  <palves@redhat.com>
3186
3187         PR cli/24732
3188         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3189         (pipe_cmd_option_defs): New.
3190         (make_pipe_cmd_options_def_group): New.
3191         (pipe_command): Use gdb::option::process_options.
3192         (pipe_command_completer): New function.
3193         (_initialize_cli_cmds): Install completer for "pipe" command.
3194
3195 2019-07-03  Pedro Alves  <palves@redhat.com>
3196
3197         * cli/cli-option.c (union option_value) <string>: New field.
3198         (struct option_def_and_value): Add ctor, move ctor, dtor and
3199         use DISABLE_COPY_AND_ASSIGN.
3200         (option_def_and_value::clear_value): New.
3201         (parse_option, save_option_value_in_ctx, get_val_type_str)
3202         (add_setshow_cmds_for_options): Handle var_string.
3203         * cli-option.h (union option_def::var_address) <string>: New
3204         field.
3205         (struct string_option_def): New.
3206         * maint-test-options.c (struct test_options_opts): Add default
3207         ctor and use DISABLE_COPY_AND_ASSIGN.
3208         <string_opt>: New field.
3209         (test_options_opts::~test_options_opts): New.
3210         (test_options_opts::dump): Also dump "-string".
3211         (test_options_option_defs): Install "string.
3212
3213 2019-07-03  Pedro Alves  <palves@redhat.com>
3214
3215         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3216         option_value with a null enumeration.
3217         (complete_options): Save the option values in the context.
3218         (save_option_value_in_ctx): New, factored out from ...
3219         (process_options): ... here.
3220         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3221         of the function.
3222         * maint-test-options.c (test_options_opts::dump): New, factored
3223         out from ...
3224         (maintenance_test_options_command_mode): ... here.
3225         (maintenance_test_options_command_completion_result): Delete.
3226         (maintenance_test_options_command_completion_text): Update
3227         comment.
3228         (maintenance_show_test_options_completion_result): Change
3229         prototype.  Just print
3230         maintenance_test_options_command_completion_text.
3231         (save_completion_result): New.
3232         (maintenance_test_options_completer_mode): Pass options context to
3233         complete_options, and then save a dump.
3234         (_initialize_maint_test_options): Use add_cmd to install "maint
3235         show test-options-completion-result".
3236
3237 2019-07-03  Pedro Alves  <palves@redhat.com>
3238
3239         * NEWS (New commands): Mention "with" and "maint with".
3240         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3241         (with_command, with_command_completer): New.
3242         (pipe_command): Adjust to new repeat_previous
3243         interface.
3244         (_initialize_cli_cmds): Install the "with" command and its "w"
3245         alias.
3246         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3247         declarations.
3248         * cli/cli-setshow.c (parse_cli_var_uinteger)
3249         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3250         argument strings for all var_types.
3251         (get_setshow_command_value_string): New, factored out from ...
3252         (do_show_command): ... this.
3253         * cli/cli-setshow.h: Include <string>.
3254         (get_setshow_command_value_string): Declare.
3255         * command.h (repeat_previous): Now returns const char *.  Adjust
3256         comment.
3257         * maint.c: Include "cli/cli-cmds.h".
3258         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3259         (_initialize_maint_cmds): Register the "maintenance with" command.
3260         * top.c (repeat_previous): Move bits from pipe_command here:
3261         Return the saved command line, if any; error out if there's no
3262         command to relaunch.
3263
3264 2019-07-03  Pedro Alves  <palves@redhat.com>
3265
3266         * NEWS (New commands): Mention "maint set/show test-settings"
3267         instead of "maint test-settings".
3268         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3269         (maintenance_test_settings_set_list): Rename to ...
3270         (maintenance_set_test_settings_list): ... this.
3271         (maintenance_test_settings_show_list): Rename to  ...
3272         (maintenance_show_test_settings_list): ... this.
3273         (maintenance_test_settings_cmd): Delete.
3274         (maintenance_test_settings_set_cmd): ...
3275         (maintenance_set_test_settings_cmd): ... this.
3276         (maintenance_test_settings_show_cmd): ...
3277         (maintenance_show_test_settings_cmd): ... this.
3278         (maintenance_test_settings_show_value_cmd):
3279         (maintenance_show_test_settings_value_cmd): ... this.
3280         (_initialize_maint_test_settings): No longer install the "maint
3281         test-settings" prefix command.  Rename "maint test-settings set"
3282         to "maint set test-settings", and "maint test-settings show" to
3283         "maint show test-settings".  Adjust all subcommands.
3284
3285 2019-07-03  Pedro Alves  <palves@redhat.com>
3286
3287         * maint-test-settings.c: Fix file's intro comment.  Replace all
3288         references to "test-options" with references to "test-settings",
3289         in comments.
3290
3291 2019-07-03  Pedro Alves  <palves@redhat.com>
3292
3293         * maint-test-settings.c (maintenance_test_settings_xxx)
3294         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3295         New.
3296         (maintenance_test_settings_enums): Use them.
3297         (maintenance_test_settings_enum): Default to
3298         maintenance_test_settings_xxx.
3299         (_initialize_maint_test_settings): Initialize
3300         MAINTENANCE_TEST_SETTINGS_FILENAME.
3301
3302 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3303
3304         * breakpoint.h (remove_breakpoints_inf): Change return type to
3305         void, move function documentation here.
3306         * breakpoint.c (remove_breakpoints_inf): Change return type to
3307         void, move function documentation to header.
3308
3309 2019-07-02  Pedro Alves  <palves@redhat.com>
3310
3311         * NEWS (Completion improvements): Mention "info threads".
3312         * thread.c (struct info_threads_opts, info_threads_option_defs)
3313         (make_info_threads_options_def_group): New.
3314         (info_threads_command): Use gdb::option::process_options.
3315         (info_threads_command_completer): New.
3316         (_initialize_thread): Use gdb::option::build_help to build the
3317         help text for "info threads".
3318
3319 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3320
3321         * defs.h (generic_load): Move from here...
3322         * symfile.h (generic_load): ... to here.  Rename name parameter
3323         to args.
3324         * symfile.c (generic_load): Add comment.
3325
3326 2019-07-01  Tom Tromey  <tromey@adacore.com>
3327
3328         * dwarf2read.c
3329         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3330         declaration of without_params.  Fix formatting.
3331
3332 2019-07-01  Tom Tromey  <tromey@adacore.com>
3333
3334         * ada-exp.y (find_primitive_type): Update.
3335         * ada-lang.h (ada_lookup_symbol): Update.
3336         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3337         parameter.
3338         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3339
3340 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3341
3342         PR breakpoints/24541
3343         * gdbarch.c: Regenerate.
3344         * gdbarch.h: Regenerate.
3345         * gdbarch.sh: Add 'stap_adjust_register'.
3346         * i386-tdep.c: Include '<unordered_set>'.
3347         (i386_stap_adjust_register): New function.
3348         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3349         * stap-probe.c (stap_parse_register_operand): Call
3350         'gdbarch_stap_adjust_register'.
3351
3352 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3353
3354         PR python/24742
3355         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3356         * python/python.c (do_start_initialization): Use 'xmalloc'
3357         instead of 'PyMem_Malloc'.
3358
3359 2019-06-28  Tom Tromey  <tromey@adacore.com>
3360
3361         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3362         for Ada.
3363
3364 2019-06-27  Tom Tromey  <tromey@adacore.com>
3365
3366         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3367         objfile_key.
3368         (arm_find_mapping_symbol, arm_record_special_symbol)
3369         (_initialize_arm_tdep): Update.
3370         (arm_objfile_data_free): Remove.
3371
3372 2019-06-27  Tom Tromey  <tromey@adacore.com>
3373
3374         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3375         to cp_print_static_field.
3376
3377 2019-06-26  Tom Tromey  <tromey@adacore.com>
3378
3379         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3380         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3381         declare.
3382
3383 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3384
3385         * features/aarch64-core.c (create_feature_aarch64_core):
3386         Regenerate.
3387         * features/aarch64-core.xml: Add cpsr flags.
3388
3389 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3390
3391         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3392         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3393
3394 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3395
3396         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3397         field.
3398         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3399         use.
3400         (arm_record_special_symbol): Don't insert new symbol in sorted
3401         position, push it at the end.
3402
3403 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3404
3405         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3406         (arm_mapping_symbol_s): Remove.
3407         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3408         (arm_mapping_symbol_vec): New typedef.
3409         (struct arm_per_objfile): Add constructor.
3410         <section_maps>: Change type to
3411         std::unique_ptr<arm_mapping_symbol_vec[]>.
3412         (arm_compare_mapping_symbols): Remove.
3413         (arm_find_mapping_symbol): Adjust to section_maps type change.
3414         (arm_objfile_data_free): Call delete on arm_per_objfile.
3415         (arm_record_special_symbol): Adjust to section_maps type change.
3416         Allocate arm_per_objfile with new.
3417
3418 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3419
3420         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3421         with the command prefix.
3422
3423 2019-06-25  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3426         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3427
3428 2019-06-25  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3431         type.
3432         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3433         protected.
3434
3435 2019-06-25  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui-winsource.c
3438         (tui_source_window_base::set_is_exec_point_at): Add check against
3439         LOA_ADDRESS.
3440
3441 2019-06-25  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-source.c (tui_set_source_content): Don't check before
3444         xfree.
3445         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-winsource.h (tui_update_source_window_as_is)
3450         (tui_alloc_source_buffer, tui_line_is_displayed)
3451         (tui_addr_is_displayed): Change type of win_info.
3452         * tui/tui-winsource.c (tui_update_source_window_as_is)
3453         (tui_clear_source_content, tui_show_source_line)
3454         (tui_show_source_content, tui_source_window_base::refill)
3455         (tui_source_window_base::set_is_exec_point_at)
3456         (tui_source_window_base::set_is_exec_point_at)
3457         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3458         (tui_alloc_source_buffer, tui_line_is_displayed)
3459         (tui_addr_is_displayed): Change type of win_info.  Update.
3460         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3461         (tui_source_window_base::do_make_visible_with_new_height):
3462         Update.
3463         * tui/tui-source.c (tui_set_source_content)
3464         (tui_set_source_content_nil)
3465         (tui_source_window::do_scroll_vertical): Update.
3466         * tui/tui-layout.c (show_layout): Update.
3467         * tui/tui-disasm.c (tui_set_disassem_content)
3468         (tui_disasm_window::do_scroll_vertical): Update.
3469         * tui/tui-data.h (tui_win_content): Remove.
3470         (struct tui_gen_win_info) <content, content_size>: Remove.
3471         (struct tui_source_element): Add initializers and destructor.
3472         (union tui_which_element, struct tui_win_element): Remove.
3473         (struct tui_source_window_base) <content>: New field.
3474         (struct tui_data_window): Remove destructor.
3475         (tui_alloc_content, tui_free_win_content)
3476         (tui_free_all_source_wins_content): Don't declare.
3477         * tui/tui-data.c (tui_initialize_static_data): Update.
3478         (init_content_element, tui_alloc_content): Remove.
3479         (~tui_gen_win_info): Update.
3480         (~tui_data_window, tui_free_all_source_wins_content)
3481         (tui_free_win_content, free_content, free_content_elements):
3482         Remove.
3483
3484 2019-06-25  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-winsource.h (tui_clear_source_content)
3487         (tui_erase_source_content, tui_show_source_content): Change type
3488         of win_info.
3489         * tui/tui-winsource.c (tui_clear_source_content)
3490         (tui_erase_source_content, tui_show_source_content): Change type
3491         of win_info.
3492         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3493         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3494         win_info.
3495         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3496         win_info.
3497         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3498
3499 2019-06-25  Tom Tromey  <tom@tromey.com>
3500
3501         * tui/tui-winsource.c (tui_clear_source_content)
3502         (tui_source_window_base::set_is_exec_point_at): Update.
3503         * tui/tui-source.c (tui_set_source_content_nil): Update.
3504         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3505         a bool.
3506         * tui/tui-data.c (init_content_element): Update.
3507
3508 2019-06-25  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3511         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3512         * tui/tui-layout.c (init_and_make_win): Update.
3513         * tui/tui.h (enum tui_win_type): Update.
3514         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3515         tui_win_is_auxillary.
3516         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3517         tui_win_is_auxillary.
3518
3519 2019-06-25  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3522         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3523         (tui_delete_data_content_windows, tui_display_all_data)
3524         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3525         Update.
3526         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3527         * tui/tui-regs.c (tui_last_regs_line_no)
3528         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3529         (tui_show_registers): Update.
3530         (tui_show_register_group): Return void.  Update.
3531         (tui_display_registers_from, tui_display_reg_element_at_line)
3532         (tui_display_registers_from_line, tui_check_register_values):
3533         Update.
3534         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3535         member.
3536         (struct tui_data_window) <regs_content>: Now a std::vector.
3537         <regs_content_count>: Remove.
3538         (tui_add_content_elements, tui_free_data_content): Don't declare.
3539         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3540         (init_content_element): Remove DATA_WIN case.  Add assert.
3541         (tui_add_content_elements): Remove.
3542         (tui_data_window): Update.
3543         (tui_free_data_content): Remove.
3544         (free_content_elements): Remove DATA_WIN case.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-data.c (tui_data_item_window): Update.
3549         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3550         * tui/tui-windata.c (tui_display_all_data)
3551         (tui_display_data_from_line): Update.
3552         (tui_check_data_values): Remove.
3553         * tui/tui-regs.c (tui_show_register_group)
3554         (tui_display_reg_element_at_line): Update.
3555         * tui/tui-hooks.c (tui_register_changed)
3556         (tui_refresh_frame_and_register_information): Call
3557         tui_check_register_values.
3558         * tui/tui-data.h (struct tui_data_window) <data_content,
3559         data_content_count, data_type>: Remove.
3560         (enum tui_data_type): Remove.
3561
3562         * tui/tui-data.c (tui_data_window::clear_detail)
3563         (~tui_data_window): Update.
3564
3565 2019-06-25  Tom Tromey  <tom@tromey.com>
3566
3567         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3568         declare.
3569         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3570         Rename from tui_first_data_item_displayed.  Update.
3571         (tui_data_window::refresh_all)
3572         (tui_data_window::do_scroll_vertical): Update.
3573         * tui/tui-data.h (struct tui_data_window)
3574         <first_data_item_displayed>: Declare new method.
3575
3576 2019-06-25  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3579         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3580         contents...
3581         (tui_initialize_static_data): ...here.
3582
3583 2019-06-25  Tom Tromey  <tom@tromey.com>
3584
3585         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3586         (tui_display_registers_from, tui_check_register_values): Update.
3587         (tui_display_register): Remove win_info parameter; update.
3588         (tui_get_register): Change type of parameters.
3589         * tui/tui-data.h (struct tui_data_element): Remove.
3590         (union tui_which_element) <data>: Remove.
3591         <data_window>: Change type.
3592         (struct tui_data_item_window): New.
3593         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3594         case.  Add assert.
3595         (~tui_data_item_window): New destructor.
3596         (free_content_elements): Remove DATA_ITEM_WIN case.
3597
3598 2019-06-25  Tom Tromey  <tom@tromey.com>
3599
3600         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3601         Remove.
3602
3603 2019-06-25  Tom Tromey  <tom@tromey.com>
3604
3605         * tui/tui-data.h (struct tui_command_element): Remove.
3606         (union tui_which_element) <command>: Remove.
3607         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3608         assert.
3609         (free_content_elements): Remove CMD_WIN case.
3610
3611 2019-06-25  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-layout.c (tui_set_layout): Update.
3614         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3615         * tui/tui-data.c (layout_def): Update.
3616
3617 2019-06-25  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3620         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3621         (tui_source_window_base::set_new_height): Update.
3622         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3623         Update.
3624         (tui_set_locator_fullname, tui_set_locator_info)
3625         (tui_show_frame_info): Update.
3626         * tui/tui-source.c (tui_set_source_content)
3627         (tui_source_is_displayed): Update.
3628         * tui/tui-layout.c (show_source_disasm_command, show_data)
3629         (show_source_or_disasm_and_command): Update.
3630         * tui/tui-disasm.c (tui_set_disassem_content)
3631         (tui_get_begin_asm_address): Update.
3632         * tui/tui-data.h (struct tui_locator_element): Remove.
3633         (union tui_which_element) <locator>: Remove.
3634         (struct tui_locator_window): New.
3635         (tui_locator_win_info_ptr): Change return type.
3636         * tui/tui-data.c (_locator): Change type.
3637         (tui_locator_win_info_ptr): Change return type.
3638         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3639         (tui_alloc_content): Add assert.
3640
3641 2019-06-25  Tom Tromey  <tom@tromey.com>
3642
3643         * tui/tui-winsource.c
3644         (tui_exec_info_window::maybe_allocate_content): New method.
3645         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3646         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3647         (make_source_or_disasm_window): Add cast.
3648         * tui/tui-data.h (union tui_which_element) <simple_string>:
3649         Remove.
3650         (struct tui_source_info): New.
3651         (struct tui_source_window_base) <execution_info>: Change type.
3652         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3653         case, and add assert.
3654         (tui_alloc_content): Add assert.
3655
3656 2019-06-25  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3659         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3660         * tui/tui-data.c (tui_alloc_win_info): Remove.
3661
3662 2019-06-25  Tom Tromey  <tom@tromey.com>
3663
3664         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3665         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3666         can_highlight.
3667
3668 2019-06-25  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3671         make_visible_with_new_height method.
3672         (tui_win_info::make_visible_with_new_height): New method.
3673         (tui_source_window_base::do_make_visible_with_new_height)
3674         (tui_data_window::do_make_visible_with_new_height)
3675         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3676         (make_visible_with_new_height): Remove.
3677         (tui_resize_all, tui_adjust_win_heights): Use
3678         make_visible_with_new_height method.
3679         * tui/tui-data.h (struct tui_win_info)
3680         <do_make_visible_with_new_height, make_visible_with_new_height>:
3681         New methods.
3682         (struct tui_source_window_base, struct tui_data_window)
3683         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3684         methods.
3685
3686 2019-06-25  Tom Tromey  <tom@tromey.com>
3687
3688         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3689         method.
3690         (update_tab_width): Call update_tab_width method.
3691         * tui/tui-data.h (struct tui_win_info)
3692         (struct tui_source_window_base) <update_tab_width>: New methods.
3693
3694 2019-06-25  Tom Tromey  <tom@tromey.com>
3695
3696         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3697         parameter.
3698         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3699         parameter.
3700         (tui_gen_win_info::make_visible): Update.
3701         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3702         parameter.
3703         * tui/tui-data.h (enum tui_box): New enum.
3704         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3705
3706 2019-06-25  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3709         init_and_make_win for EXEC_INFO_WIN.
3710         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3711         longer inline.
3712         (struct tui_win_info) <~tui_win_info>: Inline.
3713         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3714         Don't declare.
3715         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3716         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3717         Remove.
3718         (tui_initialize_static_data): Update.
3719         (~tui_gen_win_info): Handle more cleanup here.
3720         (~tui_source_window_base): Delete "execution_info".
3721         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3722
3723 2019-06-25  Tom Tromey  <tom@tromey.com>
3724
3725         * tui/tui-layout.c (make_command_window): Don't set
3726         can_highlight.
3727         (show_source_disasm_command): Call the reset method.
3728         (show_data): Don't set can_highlight.  Call the reset method.
3729         (tui_gen_win_info::reset): Rename from init_gen_win_info
3730         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3731         (show_source_or_disasm_and_command): Call the reset method.
3732         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3733         (struct tui_cmd_window): Set can_highlight.
3734
3735 2019-06-25  Tom Tromey  <tom@tromey.com>
3736
3737         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3738         from make_visible.
3739         (tui_make_visible, tui_make_invisible): Rewrite.
3740         (tui_win_info::make_visible): Remove.
3741         (tui_source_window_base::make_visible): Update.
3742         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3743         method.  Moved from...
3744         (struct tui_win_info) <make_visible>: ...here.
3745
3746 2019-06-25  Tom Tromey  <tom@tromey.com>
3747
3748         * tui/tui-winsource.c
3749         (tui_source_window_base::do_scroll_horizontal): Remove direction
3750         parameter.
3751         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3752         direction parameter.
3753         * tui/tui-win.c (tui_win_info::forward_scroll)
3754         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3755         (tui_win_info::right_scroll): Update.
3756         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3757         direction parameter.
3758         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3759         direction parameter.
3760         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3761         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3762         Remove direction parameter.
3763         (struct tui_source_window_base, struct tui_source_window)
3764         (struct tui_disasm_window, struct tui_data_window)
3765         (struct tui_cmd_window): Update.
3766
3767 2019-06-25  Tom Tromey  <tom@tromey.com>
3768
3769         * tui/tui-winsource.h (tui_set_exec_info_content)
3770         (tui_show_exec_info_content, tui_erase_exec_info_content)
3771         (tui_clear_exec_info_content, tui_update_exec_info): Change
3772         argument to tui_source_window_base.
3773         * tui/tui-winsource.c (tui_set_exec_info_content)
3774         (tui_show_exec_info_content, tui_erase_exec_info_content)
3775         (tui_clear_exec_info_content, tui_update_exec_info): Change
3776         argument to tui_source_window_base.
3777
3778 2019-06-25  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3781         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3782
3783 2019-06-25  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3786         check.
3787
3788 2019-06-25  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3791         type to void.
3792         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3793         type to void.
3794         * tui/tui-source.c (tui_set_source_content): Update.
3795         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3796
3797 2019-06-25  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-win.c (window_name_completer, tui_set_focus)
3800         (tui_all_windows_info): Use name method.
3801         * tui/tui-data.h (struct tui_gen_win_info)
3802         (struct tui_source_window, struct tui_disasm_window)
3803         (struct tui_data_window, struct tui_cmd_window) <name>: New
3804         method.
3805         (tui_win_name): Don't declare.
3806         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3807         (tui_win_name): Remove.
3808
3809 2019-06-25  Tom Tromey  <tom@tromey.com>
3810
3811         * tui/tui-winsource.h (tui_update_source_window)
3812         (tui_update_source_window_as_is): Change parameter type.
3813         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3814         to be a tui_source_window_base.
3815         (tui_update_source_window_as_is): Likewise.
3816         * tui/tui-win.c (make_visible_with_new_height): Update.
3817
3818 2019-06-25  Tom Tromey  <tom@tromey.com>
3819
3820         * tui/tui-winsource.c (tui_erase_source_content)
3821         (tui_show_source_content, tui_show_exec_info_content)
3822         (tui_erase_exec_info_content): Use refresh_window method.
3823         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3824         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3825         from tui_refresh_win.
3826         (tui_data_window::refresh_window): New method.
3827         (tui_win_info::refresh, tui_source_window_base::refresh)
3828         (tui_refresh_all): Use refresh_window method.
3829         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3830         method.
3831         * tui/tui-regs.c (tui_display_register): Call refresh_window
3832         method.
3833         * tui/tui-layout.c (show_source_disasm_command)
3834         (show_source_or_disasm_and_command): Call refresh_window method.
3835         * tui/tui-data.h (struct tui_gen_win_info)
3836         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3837         New method.
3838
3839 2019-06-25  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui.c (tui_rl_other_window, tui_enable)
3842         (tui_is_window_visible, tui_get_command_dimension): Update.
3843         * tui/tui-winsource.c (tui_update_source_window_as_is)
3844         (tui_clear_source_content, tui_erase_source_content)
3845         (tui_show_source_line, tui_source_window_base::refill)
3846         (tui_source_window_base::do_scroll_horizontal)
3847         (tui_source_window_base::set_is_exec_point_at)
3848         (tui_update_breakpoint_info, tui_set_exec_info_content)
3849         (tui_alloc_source_buffer, tui_line_is_displayed)
3850         (tui_addr_is_displayed): Update.
3851         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3852         (tui_check_and_display_highlight_if_needed)
3853         (tui_win_info::make_visible, tui_win_info::refresh)
3854         (tui_refresh_all): Update.
3855         * tui/tui-windata.c (tui_first_data_item_displayed)
3856         (tui_delete_data_content_windows, tui_erase_data_content)
3857         (tui_display_all_data, tui_data_window::refresh_all)
3858         (tui_check_data_values): Update.
3859         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3860         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3861         (tui_win_info::backward_scroll, tui_refresh_all_win)
3862         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3863         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3864         (tui_source_window_base::set_new_height)
3865         (tui_data_window::set_new_height)
3866         (make_invisible_and_set_new_height)
3867         (make_visible_with_new_height, new_height_ok)
3868         (parse_scrolling_args): Update.
3869         * tui/tui-stack.c (tui_show_frame_info): Update.
3870         * tui/tui-source.c (tui_set_source_content)
3871         (tui_set_source_content_nil, tui_source_is_displayed)
3872         (tui_source_window::do_scroll_vertical): Update.
3873         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3874         (tui_display_registers_from, tui_display_reg_element_at_line)
3875         (tui_check_register_values, tui_reg_command): Update.
3876         * tui/tui-layout.c (tui_default_win_height)
3877         (show_source_disasm_command, show_data, init_and_make_win)
3878         (show_source_or_disasm_and_command): Update.
3879         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3880         (tui_redisplay_readline, tui_mld_flush)
3881         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3882         (tui_getc): Update.
3883         * tui/tui-disasm.c (tui_set_disassem_content)
3884         (tui_disasm_window::do_scroll_vertical): Update.
3885         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3886         Now virtual.
3887         (struct tui_win_info): Derive from tui_gen_win_info.
3888         <~tui_win_info>: Mark as override.
3889         <generic>: Remove member.
3890         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3891         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3892         (~tui_data_window, ~tui_win_info)
3893         (tui_free_all_source_wins_content): Update.
3894         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3895
3896 2019-06-25  Tom Tromey  <tom@tromey.com>
3897
3898         * tui/tui-layout.c (init_and_make_win): Use new.
3899         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3900         destructor, initializers.
3901         (tui_alloc_generic_win_info): Don't declare.
3902         * tui/tui-data.c (_locator): Add argument to constructor.
3903         (source_win, disasm_win): New globals.
3904         (exec_info): Remove.
3905         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3906         Update.
3907         (tui_alloc_generic_win_info): Remove.
3908         (init_content_element): Use new.
3909         (tui_win_info::tui_win_info): Update.
3910         (free_content_elements) <case DATA_WIN>: Use delete.
3911
3912 2019-06-25  Tom Tromey  <tom@tromey.com>
3913
3914         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3915         * tui/tui-windata.c (tui_first_data_item_displayed)
3916         (tui_delete_data_content_windows): Update.
3917         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3918         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3919         (tui_display_registers_from, tui_check_register_values): Update.
3920         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3921         pointer.
3922         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3923         window.
3924         (tui_free_data_content): Update.
3925         (free_content_elements) <case DATA_WIN>: Free the window.
3926
3927 2019-06-25  Tom Tromey  <tom@tromey.com>
3928
3929         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3930         Update.
3931         * tui/tui-layout.c (make_command_window)
3932         (show_source_disasm_command, show_data, init_and_make_win)
3933         (show_source_or_disasm_and_command): Update.
3934         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3935         method.
3936         <can_highight, is_highlighted>: Now bool.
3937         (tui_set_win_highlight): Don't declare.
3938         * tui/tui-data.c (tui_set_win_highlight): Remove.
3939
3940 2019-06-25  Tom Tromey  <tom@tromey.com>
3941
3942         * tui/tui-wingeneral.c (make_visible): Remove check of window
3943         type.
3944
3945 2019-06-25  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-win.c (tui_win_info::max_height)
3948         (tui_cmd_window::max_height): New methods.
3949         (new_height_ok): Call max_height.
3950         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3951         <max_height>: New method.
3952
3953 2019-06-25  Tom Tromey  <tom@tromey.com>
3954
3955         * tui/tui-win.c (tui_source_window_base::set_new_height)
3956         (tui_data_window::set_new_height): New methods.
3957         (make_invisible_and_set_new_height): Call set_new_height method.
3958         * tui/tui-data.h (struct tui_win_info)
3959         (struct tui_source_window_base, struct tui_data_window)
3960         <set_new_height>: New method.
3961
3962 2019-06-25  Tom Tromey  <tom@tromey.com>
3963
3964         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3965         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3966         tui_refresh_data_win.
3967         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3968         method.
3969         (tui_refresh_all_win): Call the refresh_all method.
3970         (tui_set_focus): Likewise.
3971         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3972         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3973         Likewise.
3974
3975 2019-06-25  Tom Tromey  <tom@tromey.com>
3976
3977         * tui/tui-winsource.h (tui_refill_source_window)
3978         (tui_set_is_exec_point_at): Don't declare.
3979         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3980         (tui_source_window_base::refill): Rename from
3981         tui_refill_source_window.
3982         (tui_source_window_base::do_scroll_horizontal): Update.
3983         (tui_source_window_base::set_is_exec_point_at): Rename from
3984         tui_set_is_exec_point_at.
3985         (tui_update_all_breakpoint_info): Update.
3986         * tui/tui-stack.c (tui_show_frame_info): Update.
3987         * tui/tui-layout.c (show_data): Add cast.
3988         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3989         * tui/tui-data.h (struct tui_source_window_base) <refill,
3990         set_is_exec_point_at>: New methods.
3991         (tui_source_windows, tui_add_to_source_windows): Update types.
3992         (tui_add_to_source_windows): Remove redundant declaration.
3993         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3994         (tui_source_windows): Change return type.
3995         (tui_clear_source_windows_detail): Update.
3996         (tui_add_to_source_windows): Change type of parameter.
3997         (tui_free_all_source_wins_content): Update.
3998
3999 2019-06-25  Tom Tromey  <tom@tromey.com>
4000
4001         * tui/tui-wingeneral.c (tui_win_info::refresh)
4002         (tui_source_window_base::refresh): New methods.
4003         (tui_refresh_all): Call the refresh method.
4004         * tui/tui-data.h (struct tui_win_info)
4005         (struct tui_source_window_base) <refresh>: New method.
4006
4007 2019-06-25  Tom Tromey  <tom@tromey.com>
4008
4009         * tui/tui.h (tui_is_window_visible): Return bool.
4010         * tui/tui.c (tui_is_window_visible): Return bool.
4011         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4012         (tui_make_visible, tui_make_invisible)
4013         (tui_win_info::make_visible)
4014         (tui_source_window_base::make_visible, make_all_visible)
4015         (tui_make_all_visible, tui_make_all_invisible): Update.
4016         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4017         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4018         bool.
4019         (struct tui_win_info, struct tui_source_window_base)
4020         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4021         * tui/tui-data.c (tui_init_generic_part): Update.
4022
4023 2019-06-25  Tom Tromey  <tom@tromey.com>
4024
4025         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4026         (tui_source_window_base::make_visible): New methods.
4027         (make_all_visible): Make method call.
4028         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4029         (struct tui_source_window_base, struct tui_cmd_window): Override
4030         make_visible.
4031         (tui_win_is_source_type): Don't declare.
4032         * tui/tui-data.c (tui_win_is_source_type): Remove.
4033
4034 2019-06-25  Tom Tromey  <tom@tromey.com>
4035
4036         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4037         NULL check.
4038
4039 2019-06-25  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4042         Inline constructor.  Add initializers for members.
4043         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4044         constructors; now inline in class.
4045
4046 2019-06-25  Tom Tromey  <tom@tromey.com>
4047
4048         * tui/tui-regs.c (tui_show_registers): Update.
4049         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4050         bool.
4051         * tui/tui-data.c (tui_data_window::clear_detail)
4052         (tui_data_window): Update.
4053
4054 2019-06-25  Tom Tromey  <tom@tromey.com>
4055
4056         * tui/tui-windata.c (tui_display_all_data)
4057         (tui_display_data_from_line, tui_display_data_from)
4058         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4059         Update.
4060         * tui/tui-regs.c (tui_last_regs_line_no)
4061         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4062         (tui_show_registers, tui_show_register_group)
4063         (tui_display_registers_from, tui_display_reg_element_at_line)
4064         (tui_display_registers_from_line, tui_check_register_values)
4065         (tui_reg_next, tui_reg_prev): Update.
4066         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4067         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4068         tui_data_window.
4069         (struct tui_win_info) <detail>: Remove.  Add new fields from
4070         tui_data_info.
4071         (TUI_DATA_WIN): Add cast.
4072         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4073         (~tui_data_window): Simplify.
4074
4075 2019-06-25  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-layout.c (show_source_disasm_command)
4078         (show_source_or_disasm_and_command): Update.
4079         * tui/tui-io.c (update_cmdwin_start_line)
4080         (tui_redisplay_readline): Update.
4081         * tui/tui-data.h (struct tui_command_info): Remove.
4082         (struct tui_win_info) <detail>: Remove command_info member.
4083         (struct tui_data_window) <start_line>: New member, from
4084         tui_command_info.
4085         (TUI_CMD_WIN): Add casts.
4086
4087 2019-06-25  Tom Tromey  <tom@tromey.com>
4088
4089         * tui/tui-winsource.c (tui_update_source_window)
4090         (tui_refill_source_window)
4091         (tui_source_window_base::do_scroll_horizontal)
4092         (tui_update_breakpoint_info, tui_set_exec_info_content)
4093         (tui_show_exec_info_content, tui_erase_exec_info_content)
4094         (tui_clear_exec_info_content): Update.
4095         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4096         Update.
4097         * tui/tui-win.c (make_invisible_and_set_new_height)
4098         (make_visible_with_new_height): Update.
4099         * tui/tui-source.c (tui_set_source_content)
4100         (tui_show_symtab_source): Update.
4101         * tui/tui-layout.c (extract_display_start_addr)
4102         (show_source_disasm_command, show_data)
4103         (make_source_or_disasm_window)
4104         (show_source_or_disasm_and_command): Update.
4105         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4106         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4107         "gdbarch".
4108         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4109         to tui_source_window_base.
4110         (struct tui_win_info) <detail>: Remove source_info member.
4111         (struct tui_source_window_base) <has_locator>: Inline.
4112         Move contents from tui_source_info; rename has_locator member to
4113         m_has_locator.
4114         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4115         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4116         header file.
4117         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4118         Simplify.
4119         (tui_free_all_source_wins_content): Cast to
4120         tui_source_window_base.
4121
4122 2019-06-25  Tom Tromey  <tom@tromey.com>
4123
4124         * tui/tui-win.c (make_invisible_and_set_new_height)
4125         (make_visible_with_new_height): Call has_locator method.
4126         * tui/tui-layout.c (show_source_disasm_command, show_data)
4127         (show_source_or_disasm_and_command): Update for bool change.
4128         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4129         (tui_win_info) <has_locator>: New method.
4130         (struct tui_source_window_base) <has_locator>: New method.
4131         (tui_win_has_locator): Don't declare.
4132         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4133         from tui_win_has_locator.
4134         (tui_source_window_base): Use false, not FALSE.
4135
4136 2019-06-25  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4139         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4140         clear_detail method directly.
4141         (tui_clear_win_detail): Remove.
4142
4143 2019-06-25  Tom Tromey  <tom@tromey.com>
4144
4145         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4146         "this", not TUI_DISASM_WIN.
4147
4148 2019-06-25  Tom Tromey  <tom@tromey.com>
4149
4150         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4151         declare.
4152         * tui/tui-winsource.c
4153         (tui_source_window_base::do_scroll_horizontal): Rename from
4154         tui_horizontal_source_scroll.
4155         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4156         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4157         from tui_vertical_data_scroll.
4158         * tui/tui-win.h (tui_scroll): Don't declare.
4159         * tui/tui-win.c (tui_win_info::forward_scroll)
4160         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4161         (tui_win_info::right_scroll): Rename and update.
4162         (tui_scroll_forward_command, tui_scroll_backward_command)
4163         (tui_scroll_left_command, tui_scroll_right_command): Update.
4164         (tui_scroll): Remove.
4165         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4166         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4167         from tui_vertical_source_scroll.
4168         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4169         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4170         from tui_vertical_disassem_scroll.
4171         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4172         do_scroll_horizontal>: New methods.
4173         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4174         Likewise.
4175         (struct tui_source_window_base): Add do_scroll_horizontal.
4176         (struct tui_source_window, struct tui_disasm_window): Add
4177         do_scroll_vertical.
4178         (struct tui_data_window, struct tui_cmd_window): Add
4179         do_scroll_horizontal and do_scroll_vertical.
4180         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4181
4182 2019-06-25  Tom Tromey  <tom@tromey.com>
4183
4184         * tui/tui-data.h (struct tui_source_window_base): New struct.
4185         (struct tui_source_window): Derive from tui_source_window_base.
4186         (struct tui_disasm_window): New struct.
4187         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4188         from tui_source_window::clear_detail.
4189         (tui_source_window_base): Rename from tui_source_window.
4190         (~tui_source_window_base): Rename from ~tui_source_window.
4191         (tui_alloc_win_info): Create a tui_disasm_window.
4192
4193 2019-06-25  Tom Tromey  <tom@tromey.com>
4194
4195         * tui/tui-data.h (struct tui_source_window)
4196         (struct tui_data_window): Declare destructors.
4197         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4198         destructors.
4199         (tui_win_info): Simplify.
4200
4201 2019-06-25  Tom Tromey  <tom@tromey.com>
4202
4203         * tui/tui-winsource.c (tui_display_main)
4204         (tui_update_source_windows_with_addr)
4205         (tui_update_all_breakpoint_info): Update.
4206         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4207         (new_height_ok, parse_scrolling_args): Update.
4208         * tui/tui-stack.c (tui_show_frame_info): Update.
4209         * tui/tui-data.h (struct tui_list): Remove.
4210         (tui_source_windows): Return a reference to a std::vector.
4211         * tui/tui-data.c (source_windows): Now a std::vector.
4212         (tui_source_windows): Change return type.
4213         (tui_clear_source_windows): Rewrite.
4214         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4215         (tui_free_all_source_wins_content): Rewrite.
4216
4217 2019-06-25  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4220         (struct tui_data_window, struct tui_cmd_window): Declare
4221         clear_detail method.
4222         * tui/tui-data.c (tui_source_window::clear_detail)
4223         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4224         methods.
4225         (tui_clear_win_detail): Simplify.
4226
4227 2019-06-25  Tom Tromey  <tom@tromey.com>
4228
4229         * tui/tui-layout.c (make_source_window, make_disasm_window)
4230         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4231         Return the new window.
4232         (show_source_disasm_command, show_data)
4233         (show_source_or_disasm_and_command): Update.
4234
4235 2019-06-25  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4238         parameter.  Return the new window.
4239         (show_source_disasm_command): Update and remove NULL check.
4240         (show_source_or_disasm_and_command): Update.
4241
4242 2019-06-25  Tom Tromey  <tom@tromey.com>
4243
4244         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4245
4246 2019-06-25  Tom Tromey  <tom@tromey.com>
4247
4248         * tui/tui-data.h (struct tui_win_info): Make constructor
4249         protected.  Make destructor virtual.  Add initializers.
4250         (tui_source_window, tui_data_window, tui_cmd_window): New
4251         classes.
4252         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4253         constructor.  Add "type" parameter.
4254         (tui_source_window, tui_data_window, tui_cmd_window): New
4255         constructors.
4256         (tui_alloc_win_info): Instantiate the appropriate subclass.
4257
4258 2019-06-25  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui-win.c (tui_resize_all): Use delete.
4261         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4262         destructor.
4263         (tui_free_window): Don't declare.
4264         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4265         Update.
4266
4267 2019-06-25  Tom Tromey  <tom@tromey.com>
4268
4269         * tui/tui-data.h (struct tui_win_info): Add constructor.
4270         * tui/tui-data.c (tui_alloc_win_info): Use new.
4271         (tui_free_window): Use delete.
4272
4273 2019-06-22  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4276         declare.
4277         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4278
4279 2019-06-22  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4282         declare.
4283         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4284
4285 2019-06-22  Tom de Vries  <tdevries@suse.de>
4286
4287         * dwarf2read.c (create_addrmap_from_aranges)
4288         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4289         instead of '%zu'.
4290
4291 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4292
4293         * dwarf2read.h (dwarf2_section_info_def): Remove.
4294         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4295         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4296         std::vector<dwarf2_section_info>.
4297         (struct dwo_file) <~dwo_file>: Remove.
4298         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4299         types field.
4300         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4301         (dwarf2_read_debug_names): Likewise.
4302         (create_debug_types_hash_table): Change parameter type to
4303         array_view, adjust code accordingly.
4304         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4305         (partial_die_info::fixup): Likewise.
4306         (determine_prefix): Likewise.
4307         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4308
4309 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4310
4311         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4312         gdb_bfd_ref_ptr.
4313         <~dwo_file>: Remove call to gdb_bfd_unref.
4314         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4315         gdb_bfd_ref_ptr::get.
4316
4317 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4318
4319         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4320         type to htab_up.
4321         * dwarf2read.c (struct dwo_file): Initialize fields.
4322         <~dwo_file>: New.
4323         (free_dwo_file): Remove, move content to ~dwo_file.
4324         (struct dwo_file_deleter): Remove.
4325         (dwo_file_up>: Remove custom deleter.
4326         (free_dwo_files): Remove.
4327         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4328         dwo_files.
4329         (process_skeletonless_type_units): Call unique_ptr::get.
4330         (allocate_dwo_file_hash_table): Add deleter to created hash
4331         table.  Change return type to htab_up.
4332         (lookup_dwo_file_slot): Don't memset dwo_file, call
4333         unique_ptr::get.
4334         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4335         (create_dwo_unit_in_dwp_v2): Likewise.
4336         (open_and_init_dwo_file): Likewise.
4337         (free_dwo_file_from_slot): Remove.
4338
4339 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4340
4341         * dwarf2read.h (struct dwarf2_section_info) <readin,
4342         is_virtual>: Change type to bool.
4343         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4344         true instead of 1.
4345
4346 2019-06-19  Tom Tromey  <tom@tromey.com>
4347
4348         * tui/tui-data.h (tui_init_content_element): Don't declare.
4349
4350 2019-06-19  Tom Tromey  <tom@tromey.com>
4351
4352         * tui/tui-data.h (tui_init_win_info): Don't declare.
4353
4354 2019-06-19  Tom de Vries  <tdevries@suse.de>
4355
4356         * dwarf2read.h (abstract_to_concrete): Change type to
4357         std::unordered_map<sect_offset, std::vector<sect_offset>,
4358         gdb::hash_enum<sect_offset>>.
4359
4360 2019-06-19  Tom Tromey  <tromey@adacore.com>
4361
4362         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4363         EVAL_AVOID_SIDE_EFFECTS specially.
4364
4365 2019-06-19  Tom Tromey  <tromey@adacore.com>
4366
4367         * source-cache.c (highlighter): New global.
4368         (source_cache::get_source_lines): Create a highlighter on demand.
4369
4370 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4371
4372         * defs.h (deprecated_interactive_hook): Delete declaration.
4373         * interps.c (clear_interpreter_hooks): Remove use of
4374         deprecated_interactive_hook.
4375         * top.c (deprecated_interactive_hook): Delete definition.
4376         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4377
4378 2019-06-18  Tom de Vries  <tdevries@suse.de>
4379
4380         PR gdb/24515
4381         * dwarf2read.h (abstract_to_concrete): Change type from
4382         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4383         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4384         * dwarf2read.c (read_variable): Update.
4385         (dwarf2_fetch_die_loc_sect_off): Update.
4386
4387 2019-06-17  Tom de Vries  <tdevries@suse.de>
4388
4389         PR gdb/24617
4390         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4391         accessing parent[parent_len - 1].
4392
4393 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4394
4395         PR gdb/24364
4396         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4397         call dtrace_process_dof with NULL dof.
4398
4399 2019-06-16  Tom de Vries  <tdevries@suse.de>
4400
4401         PR gdb/24445
4402         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4403
4404 2019-06-16  Tom Tromey  <tom@tromey.com>
4405
4406         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4407         (make_all_visible): Use address of member.
4408
4409 2019-06-16  Tom Tromey  <tom@tromey.com>
4410
4411         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4412         (tui_free_window, free_content, free_content_elements): Remove
4413         unnecessary cast.
4414         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4415         cast.
4416         * tui/tui-regs.c (tui_show_register_group)
4417         (tui_display_registers_from, tui_display_reg_element_at_line):
4418         Remove unnecessary cast.
4419
4420 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * linux-nat.c (normal_mask): Delete.
4423         (_initialize_linux_nat): Don't initialise normal_mask.
4424
4425 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4426
4427         PR gdb/24445
4428         * dwarf-index-write.h (write_psymtabs_to_index): Add
4429         dwz_basename parameter.
4430         * dwarf-index-write.c (write_gdbindex): Move file writing to
4431         write_gdbindex_1.  Change return type void.
4432         (assert_file_size): Move up, remove filename parameter.
4433         (write_gdbindex_1): New function.
4434         (write_debug_names): Change return type to void, call
4435         assert_file_size.
4436         (struct index_wip_file): New struct.
4437         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4438         file logic to index_wip_file.  Write index for dwz file if
4439         needed.
4440         (save_gdb_index_command): Pass basename of dwz file, if present.
4441         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4442         build-id of dwz file, if present.
4443         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4444         (dwarf2_get_dwz_file): Likewise.
4445         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4446         (dwarf2_get_dwz_file): Likewise.
4447
4448 2019-06-16  Tom Tromey  <tom@tromey.com>
4449
4450         * coffread.c (process_coff_symbol): Use xstrdup.
4451         * value.c (create_internalvar): Use xstrdup.
4452
4453 2019-06-16  Tom Tromey  <tom@tromey.com>
4454
4455         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4456         * breakpoint.c (stopin_command, stopat_command)
4457         (until_break_command, decode_location_default): Remove unnecessary
4458         cast.
4459         * utils.c (subset_compare): Remove unnecessary cast.
4460         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4461         cast.
4462         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4463         cast.
4464         * infcmd.c (path_command): Remove unnecessary cast.
4465         * coffread.c (decode_type): Remove unnecessary cast.
4466         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4467         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4468         * tui/tui-stack.c (tui_show_locator_content)
4469         (tui_show_frame_info): Remove unnecessary cast.
4470         * tui/tui-win.c (tui_scroll_forward_command)
4471         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4472         (parse_scrolling_args): Remove unnecessary cast.
4473         * tui/tui-data.c (init_win_info, tui_del_window)
4474         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4475         (free_content_elements): Remove unnecessary cast.
4476         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4477         unnecessary cast.
4478         * tui/tui-source.c (tui_set_source_content)
4479         (tui_vertical_source_scroll): Remove unnecessary cast.
4480         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4481         cast.
4482         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4483         * tui/tui-regs.c (tui_display_registers_from)
4484         (tui_display_register): Remove unnecessary cast.
4485         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4486         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4487         (make_visible): Remove unnecessary cast.
4488         * tui/tui-winsource.c (tui_erase_source_content)
4489         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4490         unnecessary cast.
4491         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4492         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4493         * stabsread.c (read_type, read_array_type, read_range_type):
4494         Remove unnecessary cast.
4495         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4496         (parse_symbol, parse_type, upgrade_type, parse_external)
4497         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4498         unnecessary cast.
4499         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4500
4501 2019-06-16  Tom Tromey  <tom@tromey.com>
4502
4503         * tui/tui-data.c (tui_alloc_generic_win_info)
4504         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4505         checks.
4506
4507 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4508             Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * f-typeprint.c (f_print_type): Don't return early for not
4511         associated or not allocated types.
4512         (f_type_print_varspec_suffix): Add print_rank parameter and print
4513         ranks of array types in case they dangling.
4514         (f_type_print_base): Add print_rank parameter.
4515
4516 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * NEWS: Mention new MI commands.
4519         * break-catch-throw.c (enum exception_event_kind): Move to
4520         breakpoint.h.
4521         (print_mention_exception_catchpoint): Output text as a single
4522         message.
4523         (catch_exception_command_1): Rename to...
4524         (catch_exception_event): ...this, make non-static, update header
4525         command, and change some parameter types.
4526         (catch_catch_command): Update for changes to
4527         catch_exception_command_1.
4528         (catch_throw_command): Likewise.
4529         (catch_rethrow_command): Likewise.
4530         * breakpoint.c (enum exception_event_kind): Delete.
4531         * breakpoint.h (enum exception_event_kind): Moved here from
4532         break-catch-throw.c.
4533         (catch_exception_event): Declare.
4534         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4535         (mi_cmd_catch_throw): New function.
4536         (mi_cmd_catch_rethrow): New function.
4537         (mi_cmd_catch_catch): New function.
4538         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4539         'catch-catch' entries.
4540         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4541         (mi_cmd_catch_rethrow): Declare.
4542         (mi_cmd_catch_catch): Declare.
4543
4544 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * annotate.c (annotate_source_line): Change return type to void,
4547         update implementation to match.
4548         * annotate.h (annotate_source_line): Change return type to void,
4549         update header comment.
4550         * stack.c (print_frame_info): Don't change what frame information
4551         is printed based on whether annotations are on or not.
4552
4553 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4554
4555         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4556         (annotate_source): Make static.
4557         (annotate_source_line): Moved from source.c and renamed from
4558         identify_source_line.  Update the return type.
4559         * annotate.h (annotate_source): Delete declaration.
4560         (annotate_source_line): Declaration moved from source.h, and
4561         renamed from identify_source_line.  Return type updated.
4562         * source.c (identify_source_line): Moved to annotate.c and renamed
4563         to annotate_source_line.
4564         (info_line_command): Remove check of annotation_level.
4565         * source.h (identify_source_line): Move declaration to annotate.h
4566         and rename to annotate_source_line.
4567         * stack.c: Add 'annotate.h' include.
4568         (print_frame_info): Remove check of annotation_level before
4569         calling annotate_source_line.
4570
4571 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * source-cache.c (source_cache::get_plain_source_lines): Use
4574         open_source_file_with_line_charpos instead of just
4575         open_source_file, remove call to find_source_lines.
4576         (source_cache::get_source_lines): Likewise.
4577         * source.c (find_source_lines): Make static.
4578         (get_filename_and_charpos): Renamed into...
4579         (open_source_file_with_line_charpos): ..this along with changes to
4580         return a scoped_fd, and some other minor clean ups.
4581         (identify_source_line): Use open_source_file_with_line_charpos.
4582         (search_command_helper): Use open_source_file_with_line_charpos
4583         instead of just open_source_file, remove call to
4584         find_source_lines.
4585         * source.h (open_source_file_with_line_charpos): Declare new
4586         function.
4587         (find_source_lines): Delete declaration.
4588
4589 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4590
4591         * source.c (get_filename_and_charpos): Remove fullname
4592         parameter.
4593         (identify_source_line): Update call to get_filename_and_charpos.
4594
4595 2019-06-14  Tom Tromey  <tromey@adacore.com>
4596
4597         PR gdb/24502:
4598         * ui-style.h (skip_ansi_escape): Update comment.
4599         * ui-file.h (class no_terminal_escape_file): New class.
4600         * ui-file.c (no_terminal_escape_file::write)
4601         (no_terminal_escape_file::puts): New methods.
4602         * cli/cli-logging.c (handle_redirections): Use
4603         no_terminal_escape_file.
4604
4605 2019-06-14  Tom Tromey  <tromey@adacore.com>
4606
4607         * NEWS: Move convenience variable news above Python news.
4608
4609 2019-06-14  Tom Tromey  <tom@tromey.com>
4610
4611         * gnulib: Move directory to top-level.
4612         * configure.ac: Don't configure gnulib.
4613         * configure: Rebuild.
4614         * common/common-defs.h: Use new path to gnulib.
4615         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4616         (GNULIB_H): Remove.
4617         (INCGNU): Look in new gnulib location.
4618         (HFILES_NO_SRCDIR): Remove gnulib files.
4619         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4620         (generated_files): Remove GNULIB_H.
4621         ($(LIBGNU), all-lib): Remove targets.
4622         (distclean): Don't mention GNULIB_BUILDDIR.
4623         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4624
4625 2019-06-14  Tom Tromey  <tromey@adacore.com>
4626
4627         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4628         Warn if symbol file does not provide any symbols.
4629
4630 2019-06-14  Tom Tromey  <tromey@adacore.com>
4631
4632         * source.c (find_and_open_source): Respect basenames_may_differ.
4633
4634 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * annotate.c (annotate_breakpoints_invalid): Make use of
4637         scoped_restore_terminal_state.
4638         (annotate_frames_invalid): Likewise.
4639
4640 2019-06-14  Tom Tromey  <tromey@adacore.com>
4641
4642         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4643         allow assignment to an internalvar.
4644
4645 2019-06-14  Tom Tromey  <tromey@adacore.com>
4646
4647         * ada-lex.l: Allow "_" in attribute names.
4648
4649 2019-06-14  Tom Tromey  <tromey@adacore.com>
4650
4651         PR gdb/24653:
4652         * regcache.c (registers_changed): Don't call alloca.
4653         * top.c (execute_command): Don't call alloca.
4654
4655 2019-06-13  Pedro Alves  <palves@redhat.com>
4656
4657         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4658         'expression'.  When parsing an expression, error out if there's
4659         junk after "unlimited".
4660         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4661         (do_set_command): Adjust calls to is_unlimited_literal.
4662
4663 2019-06-13  Pedro Alves  <palves@redhat.com>
4664
4665         * compile/compile.c (make_compile_options_def_group): Add braces
4666         around array_view initializer.
4667         * thread.c (make_thread_apply_all_options_def_group)
4668         (make_thread_apply_all_options_def_group): Likewise.
4669
4670 2019-06-13  Pedro Alves  <palves@redhat.com>
4671
4672         * NEWS (New commands): Mention "maint test-options
4673         require-delimiter", "maint test-options unknown-is-error", "maint
4674         test-options unknown-is-operand" and "maint show
4675         test-options-completion-result".
4676         (New command options, command completion): New section.
4677         (Completion improvements): New section.
4678         Mention that you can abbreviate "unlimited".
4679
4680 2019-06-13  Pedro Alves  <palves@redhat.com>
4681
4682         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4683         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4684         * unittests/cli-utils-selftests.c (test_parse_flags)
4685         (test_parse_flags_qcs): Delete.
4686         (test_cli_utils): Don't call deleted functions.
4687
4688 2019-06-13  Pedro Alves  <palves@redhat.com>
4689
4690         * thread.c: Include "cli/cli-option.h".
4691         (tp_array_compar_ascending): Global.
4692         (tp_array_compar): Delete function.
4693         (tp_array_compar_ascending, tp_array_compar_descending): New
4694         functions.
4695         (ascending_option_def, qcs_flag_option_def)
4696         (thr_qcs_flags_option_defs)
4697         (make_thread_apply_all_options_def_group)
4698         (make_thread_apply_options_def_group): New.
4699         (thread_apply_all_command): Use gdb::option::process_options.
4700         (thread_apply_command_completer)
4701         (thread_apply_all_command_completer): New.
4702         (thread_apply_command): Use gdb::option::process_options.
4703         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4704         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4705         to generate help text of "thread apply".  Adjust "taas"'s help.
4706         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4707         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4708
4709 2019-06-13  Pedro Alves  <palves@redhat.com>
4710
4711         * thread.c (thread_apply_command): Check for invalid TID with
4712         isdigit instead of !isalpha.
4713
4714 2019-06-13  Pedro Alves  <palves@redhat.com>
4715
4716         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4717         (validate_flags_qcs): New.
4718         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4719         (validate_flags_qcs): Declare.
4720         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4721         (make_frame_apply_options_def_group): New.
4722         (frame_apply_command_count): Process options with
4723         gdb::option::process_options.
4724         (frame_apply_completer): New.
4725         (frame_apply_level_completer, frame_apply_all_completer)
4726         (frame_apply_completer): New.
4727         (_initialize_stack): Update help of "frame apply", "frame apply
4728         level", "frame apply all" and "faas" to mention supported options
4729         and install command completers.
4730         * stack.h (frame_apply_all_completer): Declare.
4731         * thread.c: Include "stack.h".
4732         (tfaas_command): Add "--".
4733         (_initialize_thread): Update help "tfaas" to mention supported
4734         options and install command completer.
4735
4736 2019-06-13  Pedro Alves  <palves@redhat.com>
4737
4738         * completer.c (complete_nested_command_line): New.
4739         (gdb_completion_word_break_characters_throw): Add assertion.
4740         * completer.h (complete_nested_command_line): Declare.
4741
4742 2019-06-13  Pedro Alves  <palves@redhat.com>
4743
4744         * stack.c (parse_backtrace_qualifiers): New.
4745         (backtrace_command): Use it.
4746         (backtrace_command_completer): Complete on qualifiers.
4747
4748 2019-06-13  Pedro Alves  <palves@redhat.com>
4749
4750         * frame.c: Include "cli/cli-option.h.
4751         (user_set_backtrace_options): New.
4752         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4753         Delete.
4754         (get_prev_frame): Adjust.
4755         (boolean_option_def, uinteger_option_def)
4756         (set_backtrace_option_defs): New.
4757         (_initialize_frame): Adjust and use
4758         gdb::option::add_setshow_cmds_for_options to install "set
4759         backtrace past-main" and "set backtrace past-entry".
4760         * frame.h: Include "cli/cli-option.h".
4761         (struct frame_print_options): Forward declare.
4762         (print_frame_arguments_all, print_frame_arguments_scalars)
4763         (print_frame_arguments_none): Declare.
4764         (print_entry_values): Delete declaration.
4765         (struct frame_print_options, user_frame_print_options): New.
4766         (struct set_backtrace_options): New.
4767         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4768         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4769         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4770         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4771         (list_args_or_locals): Add frame_print_options parameter.
4772         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4773         * python/py-framefilter.c (enumerate_args): Pass down
4774         USER_FRAME_PRINT_OPTIONS.
4775         * stack.c: Include "cli/cli-option.h".
4776         (print_frame_arguments_all, print_frame_arguments_scalars)
4777         (print_frame_arguments_none): Declare.
4778         (print_raw_frame_arguments, print_entry_values): Delete.
4779         (user_frame_print_options): New.
4780         (boolean_option_def, enum_option_def, frame_print_option_defs):
4781         New.
4782         (struct backtrace_cmd_options): New.
4783         (bt_flag_option_def): New.
4784         (backtrace_command_option_defs): New.
4785         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4786         (print_frame_arg, read_frame_arg, print_frame_args)
4787         (print_frame_info, print_frame): Add frame_print_options parameter
4788         and use it.
4789         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4790         (backtrace_command_1): Add frame_print_options and
4791         backtrace_cmd_options parameters and use them.
4792         (make_backtrace_options_def_group): New.
4793         (backtrace_command): Process command options with
4794         gdb::option::process_options.
4795         (backtrace_command_completer): New.
4796         (_initialize_stack): Extend "backtrace"'s help to mention
4797         supported options.  Install completer for "backtrace".
4798         Install some settings commands with add_setshow_cmds_for_options.
4799
4800 2019-06-13  Pedro Alves  <palves@redhat.com>
4801
4802         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4803         and that "set/show print raw frame-arguments" are now deprecated.
4804
4805         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4806         command.
4807         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4808         * stack.c (_initialize_stack): Install "set/show print
4809         raw-frame-arguments", and deprecate "set/show print raw
4810         frame-arguments".
4811         * valprint.c (_initialize_valprint): Deprecate "set/show print
4812         raw".
4813
4814 2019-06-13  Pedro Alves  <palves@redhat.com>
4815
4816         * compile/compile.c (struct compile_options): New.
4817         (compile_flag_option_def, compile_command_option_defs)
4818         (make_compile_options_def_group): New.
4819         (compile_file_command): Handle options with
4820         gdb::option::process_options.
4821         (compile_file_command_completer): New function.
4822         (compile_code_command): Handle options with
4823         gdb::option::process_options.
4824         (compile_code_command_completer): New function.
4825         (_initialize_compiler): Install completers for "compile code" and
4826         "compile file".  Mention available options in "compile code" and
4827         "compile code"'s help.
4828         * completer.c (advance_to_completion_word): New, factored out from
4829         ...
4830         (advance_to_expression_complete_word_point): ... this.
4831         (advance_to_filename_complete_word_point): New.
4832         * completer.h (advance_to_filename_complete_word_point): New
4833         declaration.
4834
4835 2019-06-13  Pedro Alves  <palves@redhat.com>
4836
4837         * compile/compile.c: Include "cli/cli-option.h".
4838         (compile_print_value): Scope data pointer is now a
4839         value_print_options pointer; adjust.
4840         (compile_print_command): Process options.  Scope data pointer is
4841         now a value_print_options pointer; adjust.
4842         (_initialize_compile): Update "compile print"'s help to include
4843         supported options.  Install a completer for "compile print".
4844         * cp-valprint.c (show_vtblprint, show_objectprint)
4845         (show_static_field_print): Delete.
4846         (_initialize_cp_valprint): Don't install "set print
4847         static-members", "set print vtbl", "set print object" here.
4848         * printcmd.c: Include "cli/cli-option.h" and
4849         "common/gdb_optional.h".
4850         (print_command_parse_format): Rework to fill in a
4851         value_print_options instead of a format_data.
4852         (print_value): Change parameter type from format_data pointer to
4853         value_print_options reference.  Adjust.
4854         (print_command_1): Process options.  Adjust to pass down a
4855         value_print_options.
4856         (print_command_completer): New.
4857         (_initialize_printcmd): Install print_command_completer as
4858         handle_brkchars completer for the "print" command.  Update
4859         "print"'s help to include supported options.
4860         * valprint.c: Include "cli/cli-option.h".
4861         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4862         here from cp-valprint.c.
4863         (boolean_option_def, uinteger_option_def)
4864         (value_print_option_defs, make_value_print_options_def_group):
4865         New.  Use gdb::option::add_setshow_cmds_for_options to install
4866         "set print elements", "set print null-stop", "set print repeats",
4867         "set print pretty", "set print union", "set print array", "set
4868         print address", "set print symbol", "set print array-indexes".
4869         * valprint.h: Include <string> and "cli/cli-option.h".
4870         (make_value_print_options_def_group): Declare.
4871         (print_value): Change parameter type from format_data pointer to
4872         value_print_options reference.
4873         (print_command_completer): Declare.
4874
4875 2019-06-13  Pedro Alves  <palves@redhat.com>
4876
4877         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4878         (COMMON_SFILES): Add maint-test-settings.c.
4879         * cli/cli-decode.c (boolean_enums): New global, factored out from
4880         ...
4881         (add_setshow_boolean_cmd): ... here.
4882         * cli/cli-decode.h (boolean_enums): Declare.
4883         * cli/cli-option.c: New file.
4884         * cli/cli-option.h: New file.
4885         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4886         factored out from ...
4887         (parse_cli_boolean_value(const char *)): ... this.
4888         (is_unlimited_literal): Change parameter type to pointer to
4889         pointer.  Adjust and advance ARG pointer.
4890         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4891         (parse_cli_var_enum): New, factored out from ...
4892         (do_set_command): ... this.  Adjust.
4893         * cli/cli-setshow.h (parse_cli_boolean_value)
4894         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4895         (parse_cli_var_enum): Declare.
4896         * cli/cli-utils.c: Include "cli/cli-option.h".
4897         (get_ulongest): New.
4898         * cli/cli-utils.h (get_ulongest): Declare.
4899         (check_for_argument): New overloads.
4900         * maint-test-options.c: New file.
4901
4902 2019-06-13  Pedro Alves  <palves@redhat.com>
4903
4904         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4905         parse a range if "-" is at the end of the string.
4906
4907 2019-06-13  Pedro Alves  <palves@redhat.com>
4908
4909         * cli/cli-setshow.c (parse_auto_binary_operation)
4910         (parse_cli_boolean_value): Don't allow "o".
4911
4912 2019-06-13  Pedro Alves  <palves@redhat.com>
4913
4914         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4915         * NEWS: Mention maint test-settings KIND.
4916         * maint-test-settings.c: New file.
4917
4918 2019-06-13  Pedro Alves  <palves@redhat.com>
4919
4920         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4921         completer.
4922         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4923         "set" completers.
4924
4925 2019-06-13  Pedro Alves  <palves@redhat.com>
4926
4927         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4928         after item.
4929
4930 2019-06-13  Pedro Alves  <palves@redhat.com>
4931
4932         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4933
4934 2019-06-13  Pedro Alves <palves@redhat.com>
4935
4936         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4937         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4938         call.
4939         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4940         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4941         calls.
4942         (check_for_argument): Skip spaces after argument.
4943
4944 2019-06-13  Pedro Alves  <palves@redhat.com>
4945
4946         * thread.c (thread_apply_command): Adjust TID parsing.
4947         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4948         detected before end of string.
4949         (tid_is_in_list): Error out if LIST is invalid.
4950
4951 2019-06-13  Pedro Alves  <palves@redhat.com>
4952
4953         * completer.c (complete_line_internal_1): Rewind completion word
4954         point.
4955         (completion_tracker::advance_custom_word_point_by): Change
4956         parameter type to int.
4957         * completer.h (completion_tracker::advance_custom_word_point_by):
4958         Likewise.
4959
4960 2019-06-13  Pedro Alves  <palves@redhat.com>
4961
4962         * completer.c (advance_to_completion_word): Handle delimiters.
4963
4964 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4965
4966         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4967
4968 2019-06-11  Tom Tromey  <tom@tromey.com>
4969
4970         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4971         (xmalloc_failed): Move to alloc.c.
4972         * alloc.c: New file.
4973         * Makefile.in (COMMON_SFILES): Add alloc.c.
4974
4975 2019-06-11  Tom Tromey  <tom@tromey.com>
4976
4977         * nat/linux-waitpid.c: Don't include server.h.
4978         (linux_debug): Remove.
4979         (my_waitpid): Update.
4980
4981 2019-06-11  Tom Tromey  <tromey@adacore.com>
4982
4983         * infcall.c (_initialize_infcall): Remove trailing newline from
4984         help.
4985         * user-regs.c (_initialize_user_regs): Remove trailing newline
4986         from help.
4987         * typeprint.c (_initialize_typeprint): Remove trailing newline
4988         from help.
4989         * reverse.c (_initialize_reverse): Remove trailing newlines from
4990         help.
4991         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4992         from help.
4993         * language.c (add_set_language_command): Remove trailing newline
4994         from help.
4995         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4996         help.
4997         * disasm.c (_initialize_disasm): Remove trailing newline from
4998         help.
4999         * top.c (init_main): Remove trailing newline from help.
5000         * interps.c (_initialize_interpreter): Remove trailing newline
5001         from help.
5002         * btrace.c (_initialize_btrace): Remove trailing newlines from
5003         help.
5004         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5005         from help.
5006         * python/python.c (_initialize_python): Remove trailing newline
5007         from help.
5008         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5009         help.
5010         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5011         from help.  Reformat some text.
5012         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5013         from help.
5014         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5015         newline from help.
5016
5017 2019-06-11  Tom Tromey  <tromey@adacore.com>
5018
5019         * darwin-nat.c (darwin_decode_exception_message)
5020         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5021
5022 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5023
5024         * valops.c (value_slice): Check for not allocated or not
5025         associated values.
5026
5027 2019-06-10  Tom de Vries  <tdevries@suse.de>
5028
5029         PR gdb/24618
5030         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5031         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5032         invalid.
5033
5034 2019-06-10  Tom de Vries  <tdevries@suse.de>
5035
5036         PR gdb/24611
5037         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5038         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5039
5040 2019-06-10  Tom de Vries  <tdevries@suse.de>
5041
5042         PR symtab/24545
5043         * symtab.c (struct demangled_name_entry): Add language field.
5044         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5045         static minimal symbol".  Set and use language field.
5046
5047 2019-06-10  Tom Tromey  <tromey@adacore.com>
5048
5049         * ada-lang.c (_initialize_ada_language): Update help text.
5050
5051 2019-06-10  Tom Tromey  <tromey@adacore.com>
5052
5053         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5054         with a newline.
5055         * guile/guile.c (handle_boot_error): Don't end warning with a
5056         newline.
5057         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5058         warning with a newline.
5059         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5060         newline.
5061         (s12z_frame_cache): Likewise.
5062         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5063         a newline.
5064         * solib-svr4.c (disable_probes_interface): Don't end warning with
5065         a newline.
5066         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5067         newline.
5068         * python/python.c (do_finish_initialization): Don't end warning
5069         with a newline.
5070
5071 2019-06-10  Tom Tromey  <tom@tromey.com>
5072
5073         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5074         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5075         gdbpy_enter.
5076
5077 2019-06-10  Tom Tromey  <tromey@adacore.com>
5078
5079         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5080         data.
5081         (elf_new_init): Don't call stabsread_new_init.
5082         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5083         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5084         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5085
5086 2019-06-10  Tom de Vries  <tdevries@suse.de>
5087
5088         PR symtab/16264
5089         PR symtab/24517
5090         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5091
5092 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5093
5094         * source.c (find_and_open_source): Also rewrite relative file
5095         names.
5096
5097 2019-04-26  Amos Bird  <amosbird@gmail.com>
5098
5099         * annotate.c (annotate_thread_exited): Add "thread-exited"
5100         annotation.
5101
5102 2019-06-06  Tom Tromey  <tromey@adacore.com>
5103
5104         * maint.h (class scoped_command_stats): Use
5105         DISABLE_COPY_AND_ASSIGN.
5106         <print_time>: New method.
5107         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5108         print_time.
5109         (scoped_command_stats::print_time): New method.
5110
5111 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5112
5113         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5114         instructions of lengths 6 or 8 bytes.
5115
5116 2019-06-04  Pedro Alves  <palves@redhat.com>
5117
5118         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5119
5120         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5121         * breakpoint.c (condition_completer): Likewise.
5122         * cli/cli-dump.c (scan_expression): Likewise.
5123         * common/filestuff.c (mkdir_recursive): Likewise.
5124         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5125         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5126         (gdb_abspath): Likewise.
5127         * compile/compile-cplus-types.c
5128         (compile_cplus_instance::decl_name): Likewise.
5129         * completer.c (complete_explicit_location):
5130         (signal_completer, reg_or_group_completer_1): Likewise.
5131         * cp-support.c (cp_remove_params_if_any): Likewise.
5132         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5133         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5134         * infcmd.c (strip_bg_char): Likewise.
5135         * linespec.c (copy_token_string): Likewise.
5136         * mi/mi-main.c (output_cores): Likewise.
5137         * psymtab.c (psymtab_search_name):
5138         * symfile.c (test_set_ext_lang_command): Likewise.
5139         * target.c (target_fileio_read_stralloc): Likewise.
5140         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5141         * value.c (complete_internalvar): Likewise.
5142
5143 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5144
5145         Add objfile property to gdb.Type.
5146         * NEWS: Mention Python API addition.
5147         * python/py-type.c (typy_get_objfile): New method.
5148
5149 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5150
5151         * NEWS: Mention the new set|show style [title|highlight].
5152         Mention changes to "show style", "help" and "apropos".
5153
5154 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5155
5156         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5157         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5158         instead of print_help_for_command.
5159         (print_doc_of_command): New function.
5160         (help_list): Add 'apropos -v word' suggestion.
5161         (print_help_for_command): Style the command name using title style.
5162         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5163         (_initialize_cli_cmds): Describe -v in apropos_command help.
5164
5165 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5166
5167         * cli/cli-style.h (cli_style_option): Add name in constructor,
5168         add m_name class member, add constructor with intensity,
5169         add name class function.
5170         (cli_style_option::add_setshow_commands): Remove name argument.
5171         (highlight_style, title_style): New styles.
5172         * cli/cli-style.c (do_show): New function that shows a style
5173         characteristic styling the style name with itself.
5174         (set_style_name): New function.
5175         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5176         Update all callers according to the changes in cli/cli-style.h.
5177         * utils.h (fputs_highlighted): New function.
5178         * utils.c (fputs_highlighted): Likewise.
5179
5180 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5181
5182         * NEWS: Mention new pipe command and new convenience variables.
5183
5184 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5185
5186         * cli/cli-cmds.c (pipe_command): New function.
5187         (_initialize_cli_cmds): Call add_com for pipe_command.
5188         Define | as an alias for pipe.
5189         (exit_status_set_internal_vars): New function.
5190         (shell_escape): Call exit_status_set_internal_vars.
5191         cli/cli-decode.c (find_command_name_length): Recognize | as
5192         a single character command.
5193
5194 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5195
5196         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5197         top.c (execute_command_to_ui_file): New function, mostly a copy
5198         of execute_command_to_string.
5199         (execute_command_to_string): Implement by calling
5200         execute_command_to_ui_file.
5201
5202 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5203
5204         * top.h (saved_command_line): Remove declaration.
5205         * top.c (previous_saved_command_line, previous_repeat_arguments):
5206         New variables.
5207         (saved_command_line): Make static, define together with other
5208         'repeat variables'.
5209         (dont_repeat): Clear repeat_arguments.
5210         (repeat_previous, get_saved_command_line, save_command_line):
5211         New functions.
5212         (gdb_init): Initialize saved_command_line
5213         and previous_saved_command_line.
5214         * main.c (captured_main_1): Remove saved_command_line initialization.
5215         * event-top.c (handle_line_of_input): Update to use
5216         the new 'repeat' related functions instead of direct access to
5217         saved_command_line.
5218         * command.h (repeat_previous, get_saved_command_line,
5219         save_command_line): New declarations.
5220         (dont_repeat): Add comment.
5221
5222 2019-05-30  Tom Tromey  <tromey@adacore.com>
5223
5224         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5225         Fix comment.
5226         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5227
5228 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5229
5230         PR cli/24587
5231         * completer.c (complete): Initialize variable word.
5232
5233 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5234
5235         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5236         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5237         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5238         'body' is NULL to the outter 'if', protecting the '!is_define'
5239         situation as well.
5240
5241 2019-05-29  Tom Tromey  <tromey@adacore.com>
5242
5243         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5244         (dwarf_unknown): New function.
5245         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5246         (dwarf_type_encoding_name): Use dwarf_unknown.
5247
5248 2019-05-29  Tom Tromey  <tromey@adacore.com>
5249
5250         PR c++/20020:
5251         * cp-valprint.c (cp_print_value_fields): Call
5252         cp_print_static_field inside "try".
5253
5254 2019-05-29  Tom Tromey  <tromey@adacore.com>
5255
5256         * inflow.c (struct terminal_info): Add default operator=.
5257         * configure: Rebuild.
5258         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5259         -Wdeprecated-copy-dtor, -Wredundant-move.
5260
5261 2019-05-29  Tom Tromey  <tromey@adacore.com>
5262
5263         * NEWS: Add entry.
5264         * infcmd.c (print_return_value_1): Handle finish_print
5265         option.
5266         (show_print_finish): New function.
5267         (_initialize_infcmd): Add "set/show print finish" commands.
5268         * valprint.c (user_print_options): Initialize new member.
5269         * valprint.h (struct value_print_options) <finish_print>: New
5270         member.
5271
5272 2019-05-28  Tom Tromey  <tromey@adacore.com>
5273
5274         * ada-lang.c (ada_remove_Xbn_suffix)
5275         (find_old_style_renaming_symbol)
5276         (parse_old_style_renaming): Remove.
5277         (ada_find_renaming_symbol): Don't call
5278         find_old_style_renaming_symbol.
5279         (ada_is_renaming_symbol): Rename from
5280         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5281         bool.  Now static.
5282         (ada_read_var_value): Update and simplify.
5283         * ada-exp.y (write_var_or_type): Remove old code.
5284
5285 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5286
5287         * event-top.c: Remove include comment.
5288         * inflow.c (class scoped_ignore_sigttou): Move from here...
5289         * inflow.h (class scoped_ignore_sigttou): ...to here.
5290         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5291         * top.c:  Remove include comment.
5292
5293 2019-05-27  Tom Tromey  <tom@tromey.com>
5294
5295         * NEWS: Fix typo.
5296
5297 2019-05-22  Tom Tromey  <tromey@adacore.com>
5298
5299         * target.c (target_follow_exec): Constify parameter.
5300         * target-delegates.c: Rebuild.
5301         * remote.c (remote_target::follow_exec): Constify parameter.
5302         * infrun.c (follow_exec): Constify parameter.
5303         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5304         (target_follow_exec): Likewise.
5305
5306 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5307
5308         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5309         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5310
5311 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5312
5313         * NEWS: Add debugredirect and testsuite sections.
5314
5315 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5316
5317         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5318         target descriptions using exclusively floating point register name
5319         aliases.
5320
5321 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5322
5323         PR gdb/18644:
5324         * f-lang.c (build_fortran_types): Handle the case where
5325         gdbarch_floatformat_for_type returns a nullptr.
5326
5327 2019-05-21  Tom de Vries  <tdevries@suse.de>
5328
5329         PR cli/24587
5330         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5331
5332 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5333
5334         PR gdb/18644:
5335         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5336         16-byte floats.
5337         * i386-tdep.c (i386_floatformat_for_type): Use
5338         floatformats_ia64_quad for the 16-byte floating point component
5339         within a fortran 32-byte complex number.
5340
5341 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5342
5343         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5344         delete default constructor.
5345         (find_partial_die): Update to return const struct.
5346         (partial_die_parent_scope): Move variable declaration into scope
5347         of its use and change its type to auto.
5348         (guess_partial_die_structure_name): Likewise.
5349         (partial_die_info::fixup): Likewise.
5350
5351 2019-05-17  Tom Tromey  <tromey@adacore.com>
5352
5353         * source.c (find_and_open_source): Remove cast.
5354
5355 2019-05-17  Tom Tromey  <tromey@adacore.com>
5356
5357         * annotate.c (annotate_source): Make "filename" const.
5358         * annotate.h (annotate_source): Use const.
5359
5360 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5361
5362         * disasm.c (set_disassembler_options): Send errors to stderr.
5363
5364 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5365
5366         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5367         (cli_interp_base::set_logging): Check debug_redirect.
5368         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5369         * cli/cli-logging.c (debug_redirect): Add static variable.
5370         (pop_output_files): Add default param.
5371         (handle_redirections): Print debug setting.
5372         (show_logging_command): Likewise.
5373         (_initialize_cli_logging): Add debugredirect command.
5374         * interps.c (current_interp_set_logging): Add debug_redirect
5375         parameter.
5376         * interps.h (set_logging): Add debug_redirect parameter.
5377         (current_interp_set_logging): Likewise.
5378         * mi/mi-common.h: Likewise.
5379         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5380
5381 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5382             Tom Tromey  <tromey@adacore.com>
5383
5384         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5385         directly.
5386         * cli/cli-interp.h (make_logging_output): Remove declaration.
5387         * cli/cli-logging.c (make_logging_output): Remove function.
5388         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5389         directly.
5390         * ui-file.c (tee_file::tee_file): Remove bools.
5391         (tee_file::~tee_file): Remove deletes.
5392         * ui-file.h (tee_file): Remove bools.
5393
5394 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5395
5396         * mi/mi-cmds.h (mi_cmd_complete): New function.
5397         * mi/mi-main.c (mi_cmd_complete): Likewise.
5398         * mi/mi-cmds.c: Define new MI command -complete.
5399         * NEWS: Mention new -complete command.
5400
5401 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5402
5403         * completer.h (complete): New function.
5404         * completer.c (complete): Likewise.
5405         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5406         function defined in completer.h.
5407
5408 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5409
5410         * MAINTAINERS (Write After Approval): Add myself.
5411
5412 2019-05-17  Tom de Vries  <tdevries@suse.de>
5413
5414         PR gdb/24094
5415         * dwarf2read.c (struct cu_partial_die_info): New struct.
5416         (find_partial_die): Return cu_partial_die_info.
5417         (partial_die_parent_scope, guess_partial_die_structure_name)
5418         (partial_die_info::fixup): Handle new return type of find_partial_die.
5419
5420 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5421
5422         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5423         "std::string", simplifying the algorithm.
5424
5425 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5426
5427         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5428         (stap_static_probe_ops::get_probes): Likewise.
5429
5430 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5431
5432         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5433         '-')" and "else if".
5434         (stap_parse_single_operand): Join checks for
5435         "gdbarch_stap_parse_special_token_p" and
5436         "gdbarch_stap_parse_special_token" in the same "if" statement.
5437         Invert check when verifying for operation on register
5438         displacement.
5439
5440 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5441
5442         * stap-probe.c (stap_get_opcode): Update comment.
5443         (stap_get_expected_argument_type): Likewise.
5444         (handle_stap_probe): Likewise.
5445
5446 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5447
5448         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5449         return type to 'bool'.  Adjust comment.  Use 'bool' when
5450         appropriate.
5451         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5452         * stap-probe.c (stap_parse_argument_1): Likewise.
5453         (stap_is_operator): Likewise.
5454         (stap_is_generic_prefix): Likewise.
5455         (stap_is_register_prefix): Likewise.
5456         (stap_is_register_indirection_prefix): Likewise.
5457         (stap_is_integer_prefix): Likewise.
5458         (stap_generic_check_suffix): Likewise.
5459         (stap_check_integer_suffix): Likewise.
5460         (stap_check_register_suffix): Likewise.
5461         (stap_check_register_indirection_suffix): Likewise.
5462         (stap_parse_register_operand): Likewise.
5463         (stap_parse_single_operand): Likewise.
5464         (stap_parse_argument_1): Likewise.
5465         (stap_probe::get_argument_count): Likewise.
5466         (stap_is_operator): Likewise.
5467
5468 2019-05-16  Tom Tromey  <tromey@adacore.com>
5469
5470         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5471         keyword to foreach.
5472
5473 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5474
5475         * linux-thread-db.c (try_thread_db_load_1): Change return type
5476         to bool.
5477         (try_thread_db_load): Likewise.
5478         (try_thread_db_load_from_pdir_1): Likewise.
5479         (try_thread_db_load_from_pdir): Likewise.
5480         (try_thread_db_load_from_sdir): Likewise.
5481         (try_thread_db_load_from_dir): Likewise.
5482         (thread_db_load_search): Likewise.
5483         (has_libpthread): Likewise.
5484         (thread_db_load): Likewise.
5485
5486 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5487
5488         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5489         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5490         NULL, and complain/return if that's the case.
5491
5492 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5493
5494         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5495         (advance, posn, abstract_read_memory): New functions.
5496         [struct mem_read_abstraction]: New struct.
5497         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5498
5499 2019-05-14  Tom Tromey  <tromey@adacore.com>
5500
5501         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5502         value is not lval_memory.
5503
5504 2019-05-14  Tom Tromey  <tromey@adacore.com>
5505
5506         * solib.c (info_sharedlibrary_command): Style the file name.
5507
5508 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5509
5510         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5511         (aarch64_vnv_type): Likewise.
5512         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5513         * common/tdesc.c: Likewise.
5514         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5515         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5516         * features/aarch64-fpu.xml: Add ieee half view.
5517         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5518         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5519         * gdbtypes.h (struct builtin_type): Likewise.
5520         (struct objfile_type): Likewise.
5521
5522 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5523
5524         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5525         typo.
5526         * location.h (string_to_event_location): Likewise.
5527
5528 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5529
5530         GDB 8.3 released.
5531
5532 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5533
5534         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5535         New variable declaration.
5536         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5537         New variable.
5538         (print_one_breakpoint): Use ui_out::test_flags and new global
5539         variable to compute use_fixed_output.
5540         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5541         Remove.
5542         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5543         (mi_multi_location_breakpoint_output_fixed): Remove.
5544         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5545         new variable.
5546         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5547         fix_multi_location_breakpoint_output flag if version >= 3.
5548         * ui-out.h (enum ui_out_flag)
5549         <fix_multi_location_breakpoint_output>: New enumerator.
5550
5551 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5552
5553         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5554
5555 2019-05-10  Tom Tromey  <tromey@adacore.com>
5556
5557         * ada-lang.c (catch_ada_completer): New function.
5558         (_initialize_ada_language): Use it.
5559
5560 2019-05-10  Tom Tromey  <tromey@adacore.com>
5561
5562         * thread.c (print_thread_info): Make "requested_threads" const.
5563         * gdbthread.h (print_thread_info): Make "requested_threads"
5564         const.
5565         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5566         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5567
5568 2019-05-08  Tom Tromey  <tom@tromey.com>
5569
5570         * gdbtypes.c (objfile_type_data): Change type.
5571         (objfile_type, _initialize_gdbtypes): Update.
5572
5573 2019-05-08  Tom Tromey  <tom@tromey.com>
5574
5575         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5576         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5577         (_initialize_dwarf2_frame): Update.
5578
5579 2019-05-08  Tom Tromey  <tom@tromey.com>
5580
5581         * objc-lang.c (objc_objfile_data): Change type.
5582         (find_methods): Update.
5583         (_initialize_objc_lang): Remove.
5584
5585 2019-05-08  Tom Tromey  <tom@tromey.com>
5586
5587         * stabsread.c (rs6000_builtin_type_data): Change type.
5588         (rs6000_builtin_type, _initialize_stabsread): Update.
5589
5590 2019-05-08  Tom Tromey  <tom@tromey.com>
5591
5592         * mips-tdep.c (mips_pdr_data): Remove.
5593         (_initialize_mips_tdep): Update.
5594
5595 2019-05-08  Tom Tromey  <tom@tromey.com>
5596
5597         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5598         (hppa_init_objfile_priv_data, read_unwind_info)
5599         (find_unwind_entry, _initialize_hppa_tdep): Update.
5600
5601 2019-05-08  Tom Tromey  <tom@tromey.com>
5602
5603         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5604         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5605         on obstack.
5606         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5607
5608 2019-05-08  Tom Tromey  <tom@tromey.com>
5609
5610         * mdebugread.c (basic_type_data): Change type.
5611         (basic_type, _initialize_mdebugread): Update.
5612
5613 2019-05-08  Tom Tromey  <tom@tromey.com>
5614
5615         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5616
5617 2019-05-08  Tom Tromey  <tom@tromey.com>
5618
5619         * nto-tdep.c (nto_inferior_data_reg): Change type.
5620         (nto_inferior_data): Update.
5621         (nto_inferior_data_cleanup, nto_new_inferior_data)
5622         (_initialize_nto_tdep): Remove.
5623         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5624
5625 2019-05-08  Tom Tromey  <tom@tromey.com>
5626
5627         * ada-lang.c (struct ada_inferior_data): Add initializers.
5628         (ada_inferior_data): Change type.
5629         (ada_inferior_data_cleanup): Remove.
5630         (get_ada_inferior_data, ada_inferior_exit)
5631         (struct ada_pspace_data): Add initializers, destructor.
5632         (ada_pspace_data_handle): Change type.
5633         (get_ada_pspace_data): Update.
5634         (ada_pspace_data_cleanup): Remove.
5635
5636 2019-05-08  Tom Tromey  <tom@tromey.com>
5637
5638         * coffread.c (struct coff_symfile_info): Add initializers.
5639         (coff_objfile_data_key): Move lower.  Change type.
5640         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5641         Update.
5642         (coff_free_info): Remove.
5643
5644 2019-05-08  Tom Tromey  <tom@tromey.com>
5645
5646         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5647         (fbsd_pspace_data_handle): Move lower.  Change type.
5648         (get_fbsd_pspace_data): Update.
5649         (fbsd_pspace_data_cleanup): Remove.
5650         (_initialize_fbsd_tdep): Update.
5651
5652 2019-05-08  Tom Tromey  <tom@tromey.com>
5653
5654         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5655         (get_ada_tasks_pspace_data): Update.
5656         (ada_tasks_pspace_data_cleanup): Remove.
5657         (_initialize_tasks): Update.
5658         (ada_tasks_inferior_data_handle): Change type.
5659         (get_ada_tasks_inferior_data): Update.
5660         (ada_tasks_inferior_data_cleanup): Remove.
5661         (struct ada_tasks_pspace_data): Add initializers.
5662
5663 2019-05-08  Tom Tromey  <tom@tromey.com>
5664
5665         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5666         * symfile-debug.c (debug_sym_get_probes): Change type.
5667         * stap-probe.c (handle_stap_probe):
5668         (stap_static_probe_ops::get_probes): Change type.
5669         * probe.h (class static_probe_ops) <get_probes>: Change type.
5670         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5671         (parse_probes_in_pspace): Update.
5672         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5673         Update.
5674         (any_static_probe_ops::get_probes): Change type.
5675         * elfread.c (elfread_data): New typedef.
5676         (probe_key): Change type.
5677         (elf_get_probes): Likewise.  Update.
5678         (probe_key_free): Remove.
5679         (_initialize_elfread): Update.
5680         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5681         Change type.
5682         (dtrace_process_dof_probe, dtrace_process_dof)
5683         (dtrace_static_probe_ops::get_probe): Change type.
5684
5685 2019-05-08  Tom Tromey  <tom@tromey.com>
5686
5687         * xcoffread.c (struct xcoff_symfile_info): Rename from
5688         coff_symfile_info.  Add initializers.
5689         (xcoff_objfile_data_key): Move lower.  Change type.
5690         (XCOFF_DATA): Rewrite.
5691         (xcoff_free_info): Remove.
5692         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5693         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5694         (xcoff_initial_scan): Update.
5695
5696 2019-05-08  Tom Tromey  <tom@tromey.com>
5697
5698         * solib-svr4.c (struct svr4_info): Add initializers and
5699         destructor.
5700         <probes_table>: Now an htab_up.
5701         (solib_svr4_pspace_data): Change type.
5702         (free_probes_table): Simplify.
5703         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5704         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5705         (probes_table_remove_objfile_probes, register_solib_event_probe)
5706         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5707         (_initialize_svr4_solib): Update.
5708
5709 2019-05-08  Tom Tromey  <tom@tromey.com>
5710
5711         * remote.c (remote_pspace_data): Change type.
5712         (remote_pspace_data_cleanup): Remove.
5713         (get_remote_exec_file, set_pspace_remote_exec_file)
5714         (_initialize_remote): Update.
5715
5716 2019-05-08  Tom Tromey  <tom@tromey.com>
5717
5718         * breakpoint.c (breakpoint_objfile_key): Change type.
5719         (get_breakpoint_objfile_data): Update.
5720         (free_breakpoint_objfile_data): Remove.
5721         (_initialize_breakpoint): Update.
5722
5723 2019-05-08  Tom Tromey  <tom@tromey.com>
5724
5725         * linux-tdep.c (struct linux_info): Add initializers.
5726         (linux_inferior_data): Move.  Change type.
5727         (invalidate_linux_cache_inf): Update.
5728         (linux_inferior_data_cleanup): Remove.
5729         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5730
5731 2019-05-08  Tom Tromey  <tom@tromey.com>
5732
5733         * auxv.c (auxv_inferior_data): Move.  Change type.
5734         (auxv_inferior_data_cleanup): Remove.
5735         (invalidate_auxv_cache_inf): Rewrite.
5736         (get_auxv_inferior_data, _initialize_auxv): Update.
5737
5738 2019-05-08  Tom Tromey  <tom@tromey.com>
5739
5740         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5741         (symfile_debug_objfile_data_key): Change type.
5742         (symfile_debug_installed, debug_qf_has_symbols)
5743         (debug_qf_find_last_source_symtab)
5744         (debug_qf_forget_cached_source_info)
5745         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5746         (debug_qf_print_stats, debug_qf_dump)
5747         (debug_qf_expand_symtabs_for_function)
5748         (debug_qf_expand_all_symtabs)
5749         (debug_qf_expand_symtabs_with_fullname)
5750         (debug_qf_map_matching_symbols)
5751         (debug_qf_expand_symtabs_matching)
5752         (debug_qf_find_pc_sect_compunit_symtab)
5753         (debug_qf_map_symbol_filenames)
5754         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5755         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5756         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5757         (debug_sym_read_linetable, debug_sym_relocate): Update.
5758         (symfile_debug_free_objfile): Remove.
5759         (install_symfile_debug_logging, _initialize_symfile_debug):
5760         Update.
5761
5762 2019-05-08  Tom Tromey  <tom@tromey.com>
5763
5764         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5765         allocate_on_obstack.
5766         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5767         (get_dwarf2_per_objfile): Update.
5768         (set_dwarf2_per_objfile): Remove.
5769         (dwarf2_has_info, dwarf2_get_section_info): Update.
5770         (dwarf2_free_objfile): Remove.
5771         (_initialize_dwarf2_read): Update.
5772
5773 2019-05-08  Tom Tromey  <tom@tromey.com>
5774
5775         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5776         initializers.
5777         <unsupported_script_warning_printed,
5778         script_not_found_warning_printed>: Now bool.
5779         (auto_load_pspace_data): Change type.
5780         (~auto_load_pspace_info): Rename from
5781         auto_load_pspace_data_cleanup.
5782         (get_auto_load_pspace_data, init_loaded_scripts_info)
5783         (clear_section_scripts, maybe_print_unsupported_script_warning)
5784         (maybe_print_script_not_found_warning, _initialize_auto_load):
5785         Update.
5786
5787 2019-05-08  Tom Tromey  <tom@tromey.com>
5788
5789         * objfiles.c (objfile_pspace_info): Add destructor and
5790         initializers.
5791         (objfiles_pspace_data): Change type.
5792         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5793         (get_objfile_pspace_data): Update.
5794         (objfiles_bfd_data): Change type.
5795         (get_objfile_bfd_data): Update.
5796         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5797
5798 2019-05-08  Tom Tromey  <tom@tromey.com>
5799
5800         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5801         Change type.
5802         (get_catch_syscall_inferior_data): Update.
5803         (catch_syscall_inferior_data_cleanup): Remove.
5804         (_initialize_break_catch_syscall): Update.
5805
5806 2019-05-08  Tom Tromey  <tom@tromey.com>
5807
5808         * inflow.c (struct terminal_info): Add destructor and
5809         initializers.
5810         (inflow_inferior_data): Change type.
5811         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5812         (get_inflow_inferior_data, inflow_inferior_exit)
5813         (swap_terminal_info, _initialize_inflow): Update.
5814
5815 2019-05-08  Tom Tromey  <tom@tromey.com>
5816
5817         * target-dcache.c (target_dcache_cleanup): Remove.
5818         (target_dcache_aspace_key): Change type.
5819         (target_dcache_init_p, target_dcache_invalidate)
5820         (target_dcache_get, target_dcache_get_or_init)
5821         (_initialize_target_dcache): Update.
5822         * dcache.h (struct dcache_deleter): New.
5823
5824 2019-05-08  Tom Tromey  <tom@tromey.com>
5825
5826         * symtab.c (struct symbol_cache): Add destructor and
5827         initializers.
5828         (symbol_cache_key): Move.  Change type.
5829         (make_symbol_cache, free_symbol_cache): Remove.
5830         (get_symbol_cache): Update.
5831         (symbol_cache_cleanup): Remove.
5832         (ALL_PSPACES, symbol_cache_flush)
5833         (maintenance_print_symbol_cache)
5834         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5835         Update.
5836
5837 2019-05-08  Tom Tromey  <tom@tromey.com>
5838
5839         * symtab.c (struct main_info): Add destructor and initializers.
5840         (main_progspace_key): Move.  Change type.
5841         (get_main_info): Update.
5842         (main_info_cleanup): Remove.
5843         (_initialize_symtab): Update.
5844
5845 2019-05-08  Tom Tromey  <tom@tromey.com>
5846
5847         * registry.h (DECLARE_REGISTRY): Define the _key class.
5848
5849 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5850
5851         * NEWS: Merge two 'New commands' sections.
5852
5853 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5854
5855         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5856         parameter and use Ada language definition instead.
5857         (ada_val_print_ptr): Remove unused language parameter.
5858         (ada_val_print_num): Remove language parameter and use Ada language
5859         definition instead.
5860         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5861         parameter.
5862         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5863         parameter and use Ada language definition instead.
5864         (ada_val_print_1): Update all ada_val_print_xxx calls.
5865         Remove language parameter.
5866         (ada_val_print): Update ada_val_print_1 call.
5867
5868 2019-05-08  Tom Tromey  <tromey@adacore.com>
5869
5870         * remote.c (remote_hw_watchpoint_limit)
5871         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5872         Now static.
5873
5874 2019-05-08  Tom Tromey  <tromey@adacore.com>
5875
5876         * maint.c (_initialize_maint_cmds): Move initialization code to
5877         remote.c.
5878         (watchdog, show_watchdog): Move to remote.c.
5879         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5880         "watchdog" static.
5881         (_initialize_remote): Move initialization code from maint.c.
5882         * defs.h (watchdog): Don't declare.
5883
5884 2019-05-08  Tom Tromey  <tromey@adacore.com>
5885
5886         * tui/tui-interp.c: Include main.h.
5887         * interps.c: Include main.h.
5888         * main.h (interpreter_p): Declare.
5889         * defs.h (interpreter_p): Don't declare.
5890
5891 2019-05-08  Tom Tromey  <tromey@adacore.com>
5892
5893         * dwarf2loc.c: Include dwarf2read.h.
5894         * defs.h (read_unsigned_leb128): Don't declare.
5895         * dwarf2read.h (read_unsigned_leb128): Declare.
5896
5897 2019-05-08  Tom Tromey  <tromey@adacore.com>
5898
5899         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5900         method.
5901
5902 2019-05-08  Tom Tromey  <tromey@adacore.com>
5903
5904         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5905         when no wrap column is set.
5906
5907 2019-05-08  Tom Tromey  <tromey@adacore.com>
5908
5909         * c-lang.c (c_get_string): Handle non-C-style arrays.
5910
5911 2019-05-08  Tom Tromey  <tromey@adacore.com>
5912
5913         * typeprint.c (print_offset_data::update): Print the bit offset,
5914         not the number of bits remaining.
5915
5916 2019-05-08  Tom Tromey  <tromey@adacore.com>
5917
5918         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5919         padding at end of comment.
5920
5921 2019-05-08  Tom Tromey  <tromey@adacore.com>
5922
5923         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5924         Compare main types.
5925
5926 2019-05-06  Tom Tromey  <tom@tromey.com>
5927
5928         * common/scoped_mmap.c: Include common-defs.h.
5929         * common/scoped_mmap.h: Don't include config.h.
5930
5931 2019-05-04  Tom Tromey  <tom@tromey.com>
5932
5933         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5934         (struct aarch64_call_info): Add initializers.
5935         <si>: Now a std::vector.
5936         (pass_on_stack, aarch64_push_dummy_call): Update.
5937
5938 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5939             Tom Tromey  <tom@tromey.com>
5940
5941         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5942         (ppc_threads): Now a std::vector.  Now static.
5943         (hwdebug_find_thread_points_by_tid)
5944         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5945         Update.
5946
5947 2019-05-04  Tom Tromey  <tom@tromey.com>
5948
5949         * arc-tdep.c (arc_tdesc_init): Return bool.
5950
5951 2019-05-04  Tom Tromey  <tom@tromey.com>
5952
5953         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5954         Use gdb_assert_not_reached.
5955
5956 2019-05-04  Tom Tromey  <tom@tromey.com>
5957
5958         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5959         "false".
5960
5961 2019-05-04  Tom Tromey  <tom@tromey.com>
5962
5963         * arc-tdep.c (arc_tdesc_init): Use bool.
5964
5965 2019-05-04  Tom Tromey  <tom@tromey.com>
5966
5967         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5968
5969 2019-05-04  Tom Tromey  <tom@tromey.com>
5970
5971         * cli/cli-cmds.c (valid_command_p): Return bool.
5972
5973 2019-05-04  Tom Tromey  <tom@tromey.com>
5974
5975         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5976         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5977
5978 2019-05-04  Raul Tambre  <raul@tambre.ee>
5979
5980         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5981         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5982         operator for comparison.
5983
5984 2019-05-04  Tom Tromey  <tom@tromey.com>
5985
5986         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5987         (lookup_partial_symbol, print_partial_symbols)
5988         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5989         (psymbol_compare): Update.
5990         (add_psymbol_to_bcache): Clear the entire psymbol.
5991         (maintenance_check_psymtabs): Update.
5992         * psympriv.h (struct partial_symbol): Don't derive from
5993         general_symbol_info.
5994         <obj_section, unrelocated_address, address,
5995         set_unrelocated_address>: Update.
5996         <ginfo>: New member.
5997         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5998         (debug_names::write_psymbols): Update.
5999
6000 2019-05-04  Tom de Vries  <tdevries@suse.de>
6001
6002         * contrib/cc-with-tweaks.sh: Support -n arg.
6003
6004 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6005
6006         * corelow.c (core_target::detach): Ensure frame cache and
6007         register caches are cleared.
6008         inferior.c (exit_inferior_1): Likewise.
6009
6010 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6011             Tom Tromey  <tom@tromey.com>
6012
6013         * dictionary.c (collate_pending_symbols_by_language): Remove
6014         "struct" from foreach.
6015         * symtab.c (lookup_global_symbol_from_objfile)
6016         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6017         foreach.
6018         * ser-tcp.c (net_open): Remove "struct" from foreach.
6019         * objfiles.c (objfile_relocate, objfile_rebase)
6020         (objfile_has_symbols): Remove "struct" from foreach.
6021         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6022         from foreach.
6023         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6024         foreach.
6025         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6026         "struct" from foreach.
6027         * ada-lang.c (create_excep_cond_exprs)
6028         (ada_exception_catchpoint_cond_string): Remove "struct" from
6029         foreach.
6030
6031 2019-05-03  Tom Tromey  <tromey@adacore.com>
6032
6033         * ada-exp.y (convert_char_literal): Check suffix of each
6034         enumerator.
6035
6036 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6037
6038         PR ada/21406:
6039         * ada-exp.y (yywrap): Don't define.
6040         * ada-lex.l (%option): Add noyywrap
6041         (yywrap): Remove.
6042
6043 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6044
6045         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6046         _WIN32_WINNT to the XP level, unless already defined to a higher
6047         level.
6048
6049         * unittests/parse-connection-spec-selftests.c:
6050         * ser-tcp.c:
6051         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6052         override.
6053
6054         * symfile.c (find_separate_debug_file): Remove colon from the
6055         drive spec of DOS/Windows file names of the target, so that the
6056         file name produced from DEBUGDIR and the target's directory will
6057         be valid on DOS/Windows systems.
6058
6059 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6060
6061         * rust-lang.c (val_print_struct): Handle printing structures
6062         containing strings.
6063
6064 2019-05-02  Tom Tromey  <tromey@adacore.com>
6065
6066         * valarith.c (_initialize_valarith): Remove.
6067
6068 2019-05-01  Tom Tromey  <tromey@adacore.com>
6069
6070         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6071         bitfields.
6072
6073 2019-05-01  Tom Tromey  <tromey@adacore.com>
6074
6075         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6076         for big-endian copies.
6077
6078 2019-04-30  Ali Tamur  <tamur@google.com>
6079         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6080         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6081         (read_3_bytes): New function.
6082
6083 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6084
6085         * windows-nat.c (main_thread_id): Delete.
6086         (handle_output_debug_string): Replace main_thread_id by
6087         current_event.dwThreadId.
6088         (fake_create_process): Likewise.
6089         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6090         Do not set main_thread_id.
6091         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6092         current_event.dwThreadId.
6093         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6094
6095 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6096
6097         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6098         Use current_event.dwThreadId instead of main_thread_id.
6099
6100 2019-04-30  Tom Tromey  <tromey@adacore.com>
6101
6102         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6103         (create_excep_cond_exprs): Iterate over program spaces.
6104         (ada_exception_catchpoint_cond_string): Examine all minimal
6105         symbols for exception types.
6106
6107 2019-04-30  Tom Tromey  <tromey@adacore.com>
6108
6109         PR c++/24470:
6110         * dwarf2read.c (process_structure_scope): Handle case where type
6111         has template parameters but no symbol was created.
6112
6113 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6114             Chris January  <chris.january@arm.com>
6115
6116         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6117         qualifier.
6118         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6119
6120 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6121
6122         * f-typeprint.c (f_print_type): Update rules for printing
6123         whitespace.
6124         (f_type_print_varspec_suffix): Likewise.
6125
6126 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6127             Chris January  <chris.january@arm.com>
6128
6129         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6130         function arguments.
6131
6132 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6133
6134         * f-lang.c (build_fortran_types): Change name of void type to
6135         lower case.
6136         * f-typeprint.c (f_type_print_base): Print the name of the void
6137         type, rather than a fixed string.
6138         * f-valprint.c (f_decorations): Use lower case void string.
6139
6140 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6141             Chris January  <chris.january@arm.com>
6142
6143         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6144         types for Fortran.
6145
6146 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6147             Chris January  <chris.january@arm.com>
6148             David Lecomber  <david.lecomber@arm.com>
6149
6150         * f-exp.y (BINOP_INTRINSIC): New token.
6151         (exp): New parser rule handling BINOP_INTRINSIC.
6152         (f77_keywords): Add new builtin procedures.
6153         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6154         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6155         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6156         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6157         (print_unop_subexp_f): New function.
6158         (print_binop_subexp_f): New function.
6159         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6160         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6161         (dump_subexp_body_f): Likewise.
6162         (operator_check_f): Likewise.
6163         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6164         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6165
6166 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6167
6168         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6169         UNOP_KIND.
6170         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6171         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6172         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6173         (operator_length_f): New fuction.
6174         (print_subexp_f): New function.
6175         (op_name_f): New function.
6176         (dump_subexp_body_f): New function.
6177         (operator_check_f): New function.
6178         (exp_descriptor_f): Replace standard expression handling functions
6179         with new functions.
6180         * gdb/fortran-operator.def: New file.
6181         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6182         * gdb/std-operator.def: Remove UNOP_KIND.
6183
6184 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6185
6186         * std-operator.def: Remove unbalanced, stray double quote
6187         character.
6188
6189 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6190             Chris January  <chris.january@arm.com>
6191             Daniel Everett  <daniel.everett@arm.com>
6192             Nick Forrington  <nick.forrington@arm.com>
6193             Richard Bunt  <richard.bunt@arm.com>
6194
6195         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6196         of depth when printing anonymous structs or unions.
6197         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6198         Don't print either the top-level value, or the children if the
6199         max-depth is exceeded.
6200         (ppscm_print_children): When printing the key of a map, allow one
6201         extra level of depth.
6202         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6203         print either the top-level value, or the children if the max-depth
6204         is exceeded.
6205         (print_children): When printing the key of a map, allow one extra
6206         level of depth.
6207         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6208         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6209         (user_print_options): Initialise max_depth field.
6210         (val_print_scalar_or_string_type_p): New function.
6211         (val_print): Check to see if the max depth has been reached.
6212         (val_print_check_max_depth): Define new function.
6213         (show_print_max_depth): New function.
6214         (_initialize_valprint): Add 'print max-depth' option.
6215         * valprint.h (struct value_print_options) <max_depth>: New field.
6216         (val_print_check_max_depth): Declare new function.
6217         * NEWS: Document new feature.
6218
6219 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6220
6221         * ada-lang.c (ada_language_defn): Initialise new field.
6222         * c-lang.c (c_is_string_type_p): New function.
6223         (c_language_defn): Initialise new field.
6224         (cplus_language_defn): Initialise new field.
6225         (asm_language_defn): Initialise new field.
6226         (minimal_language_defn): Initialise new field.
6227         * c-lang.h (c_is_string_type_p): Declare new function.
6228         * d-lang.c (d_language_defn): Initialise new field.
6229         * f-lang.c (f_is_string_type_p): New function.
6230         (f_language_defn): Initialise new field.
6231         * go-lang.c (go_is_string_type_p): New function.
6232         (go_language_defn): Initialise new field.
6233         * language.c (default_is_string_type_p): New function.
6234         (unknown_language_defn): Initialise new field.
6235         (auto_language_defn): Initialise new field.
6236         * language.h (struct language_defn) <la_is_string_type_p>: New
6237         member variable.
6238         (default_is_string_type_p): Declare new function.
6239         * m2-lang.c (m2_language_defn): Initialise new field.
6240         * objc-lang.c (objc_language_defn): Initialise new field.
6241         * opencl-lang.c (opencl_language_defn): Initialise new field.
6242         * p-lang.c (pascal_is_string_type_p): New function.
6243         (pascal_language_defn): Initialise new field.
6244         * rust-lang.c (rust_is_string_type_p): New function.
6245         (rust_language_defn): Initialise new field.
6246
6247 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6248
6249         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6250         New field.
6251         * ada-lang.c (ada_language_defn): Initialise new field.
6252         * c-lang.c (c_language_defn): Likewise.
6253         (cplus_language_defn): Likewise.
6254         (asm_language_defn): Likewise.
6255         (minimal_language_defn): Likewise.
6256         * d-lang.c (d_language_defn): Likewise.
6257         * f-lang.c (f_language_defn): Likewise.
6258         * go-lang.c (go_language_defn): Likewise.
6259         * language.c (unknown_language_defn): Likewise.
6260         (auto_language_defn): Likewise.
6261         * m2-lang.c (m2_language_defn): Likewise.
6262         * objc-lang.c (objc_language_defn): Likewise.
6263         * opencl-lang.c (opencl_language_defn): Likewise.
6264         * p-lang.c (pascal_language_defn): Likewise.
6265         * rust-lang.c (rust_language_defn): Likewise.
6266
6267 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6268
6269         * ada-lang.c (ada_is_character_type): Change return type to bool.
6270         (ada_is_string_type): Likewise.
6271         * ada-lang.h (ada_is_character_type): Update declaration
6272         (ada_is_string_type): Likewise.
6273
6274 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6275
6276         Support style in 'frame|thread apply'
6277
6278         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6279         * record.c (record_start, record_stop): Update callers of
6280         execute_command_to_string with false.
6281         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6282         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6283         methods.
6284         (class string_file): New constructor with term_out parameter.
6285         Override methods term_out and can_emit_style_escape.  New member
6286         term_out.
6287         (class stdio_file): Override can_emit_style_escape.
6288         (class tee_file): Override term_out and can_emit_style_escape.
6289         * utils.h (can_emit_style_escape): Remove.
6290         * utils.c (can_emit_style_escape): Likewise.
6291         Update all callers of can_emit_style_escape (SOMESTREAM) to
6292         SOMESTREAM->can_emit_style_escape.
6293         * source-cache.c (source_cache::get_source_lines): Likewise.
6294         * stack.c (frame_apply_command_count): Call execute_command_to_string
6295         passing the term_out characteristic of the current gdb_stdout.
6296         * thread.c (thr_try_catch_cmd): Likewise.
6297         * top.c (execute_command_to_string): pass term_out parameter
6298         to construct the string_file for the command output.
6299         * ui-file.c (term_cli_styling): New function (most code moved
6300         from utils.c can_emit_style_escape).
6301         (string_file::string_file, string_file::can_emit_style_escape,
6302         stdio_file::can_emit_style_escape, tee_file::term_out,
6303         tee_file::can_emit_style_escape): New functions.
6304
6305 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6306
6307         * NEWS: Mention the new set|show may-call-functions.
6308         * infcall.c (may_call_functions_p): New variable.
6309         (show_may_call_functions_p): New function.
6310         (call_function_by_hand_dummy): Throws an error if not
6311         may-call-functions.
6312         (_initialize_infcall): Call add_setshow_boolean_cmd for
6313         may-call-functions.
6314
6315 2019-04-25  Keith Seitz  <keiths@redhat.com>
6316
6317         PR c++/24367
6318         * cp-support.c (inspect_type): Don't attempt substitutions
6319         of symbol with the same name.
6320
6321 2019-04-25  Tom Tromey  <tromey@adacore.com>
6322
6323         PR gdb/24475:
6324         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6325         static.
6326
6327 2019-04-25  Tom Tromey  <tromey@adacore.com>
6328
6329         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6330         rvalue reference.
6331         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6332         (gdb_xml_parser::parse): Use std::move.
6333         * python/python-internal.h (gdbpy_convert_exception): Take a const
6334         reference.
6335         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6336         std::move.
6337         * python/py-utils.c (gdbpy_convert_exception): Take a const
6338         reference.
6339         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6340         Use std::move.
6341         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6342         Use std::move.
6343         * mi/mi-main.c (mi_print_exception): Take a const reference.
6344         * main.c (handle_command_errors): Take a const reference.
6345         * linespec.c (parse_linespec): Use std::move.
6346         * infcall.c (run_inferior_call): Use std::move.
6347         (call_function_by_hand_dummy): Use std::move.
6348         * exec.c (try_open_exec_file): Use std::move.
6349         * exceptions.h (exception_print, exception_fprintf)
6350         (exception_print_same): Update.
6351         * exceptions.c (print_exception, exception_print)
6352         (exception_fprintf, exception_print_same): Change parameters to
6353         const reference.
6354         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6355         * common/new-op.c: Use std::move.
6356         * common/common-exceptions.h (struct gdb_exception): Add move
6357         constructor.
6358         (struct gdb_exception_error, struct gdb_exception_quit, struct
6359         gdb_quit_bad_alloc): Change constructor to move constructor.
6360         (throw_exception): Change parameter to rvalue reference.
6361         * common/common-exceptions.c (throw_exception): Take rvalue
6362         reference.
6363         * cli/cli-interp.c (safe_execute_command): Use std::move.
6364         * breakpoint.c (insert_bp_location, location_to_sals): Use
6365         std::move.
6366
6367 2019-04-25  Tom Tromey  <tromey@adacore.com>
6368
6369         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6370         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6371         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6372         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6373         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6374         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6375         guile/scm-value.c: Use unpack.
6376         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6377         gdbscm_gdb_exception.
6378         (gdbscm_throw_gdb_exception): Likewise.
6379         (struct gdbscm_gdb_exception): New.
6380         (unpack): New function.
6381         (gdbscm_wrap): Use unpack.
6382
6383 2019-04-25  Tom Tromey  <tromey@adacore.com>
6384
6385         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6386         (gdb_rl_callback_handler): Use std::move.
6387         * common/common-exceptions.h (struct gdb_exception): Add move
6388         assignment operator.
6389         (throw_exception_sjlj): Change "exception" to const reference.
6390         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6391         (throw_exception_sjlj): Change "exception" to const reference.
6392
6393 2019-04-25  Tom Tromey  <tromey@adacore.com>
6394
6395         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6396         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6397         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6398         Update.
6399         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6400         Update.
6401         * mi/mi-interp.c (mi_interp::exec): Update.
6402         * linespec.c (parse_linespec): Update.
6403         * infcall.c (run_inferior_call): Update.
6404         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6405         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6406         (gdbscm_lookup_global_symbol): Update.
6407         * guile/scm-param.c (gdbscm_parameter_value): Update.
6408         * guile/scm-frame.c (gdbscm_frame_read_register)
6409         (gdbscm_frame_read_var): Update.
6410         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6411         * exec.c (try_open_exec_file): Update.
6412         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6413         (gdb_rl_callback_handler): Update.
6414         * common/common-exceptions.h (exception_none): Don't declare.
6415         * common/common-exceptions.c (exception_none): Don't define.
6416         (struct catcher) <exception>: Update.
6417         * cli/cli-interp.c (safe_execute_command): Update.
6418         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6419
6420 2019-04-25  Ali Tamur  <tamur@google.com>
6421
6422         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6423         (read_attribute_value): Likewise.
6424         (dwarf2_read_addr_index): Update comment.
6425         (read_str_index): Add DW_FORM_strx.
6426         (dwarf2_string_attr): Likewise.
6427         (dwarf2_const_value_attr): Likewise.
6428         (dump_die_shallow): Likewise.
6429         (dwarf2_fetch_constant_bytes): Likewise.
6430         (skip_form_bytes): Likewise.
6431         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6432
6433 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6434
6435         PR corefiles/11608
6436         PR corefiles/18187
6437         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6438         OFFSET.  Verify if current mapping contains an ELF header.
6439         (linux_find_memory_regions_full): Adjust call to
6440         dump_mapping_p.
6441
6442 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6443             Kang Li <kanglictf@gmail.com>
6444
6445         PR gdb/21600
6446
6447         * dwarf2-frame.c (read_initial_length): Be consistent about using
6448         unsigned representation of length.
6449         (decode_frame_entry_1): Likewise.  Check for wraparound of
6450         end pointer as well as buffer overflow.
6451
6452 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6453
6454         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6455         "vq".
6456
6457 2019-04-24  Tom Tromey  <tromey@adacore.com>
6458
6459         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6460
6461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6462
6463         * s12z-tdep.c (s12z_unwind_pc): Delete.
6464         (s12z_unwind_sp): Delete.
6465         (s12z_gdbarch_init): Don't register deleted functions with
6466         gdbarch.
6467
6468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6469
6470         * rl78-tdep.c (rl78_unwind_sp): Delete.
6471         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6472
6473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6474
6475         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6476         (xstormy16_unwind_pc): Delete.
6477         (xstormy16_dummy_id): Delete.
6478         (xstormy16_gdbarch_init): Don't register deleted functions with
6479         gdbarch.
6480
6481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6482
6483         * vax-tdep.c (vax_unwind_pc): Delete.
6484         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6485
6486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6487
6488         * v850-tdep.c (v850_unwind_sp): Delete.
6489         (v850_unwind_pc): Delete.
6490         (v850_dummy_id): Delete.
6491         (v850_gdbarch_init): Don't register deleted functions with
6492         gdbarch.
6493
6494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6495
6496         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6497         (tilegx_unwind_pc): Delete.
6498         (tilegx_unwind_dummy_id): Delete.
6499         (tilegx_gdbarch_init): Don't register deleted functions with
6500         gdbarch.
6501
6502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6503
6504         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6505         (tic6x_dummy_id): Delete.
6506         (tic6x_gdbarch_init): Don't register deleted functions with
6507         gdbarch.
6508
6509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6510
6511         * sparc-tdep.c (sparc_unwind_pc): Delete.
6512         (sparc32_gdbarch_init): Don't register deleted function with
6513         gdbarch.
6514
6515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6516
6517         * sh-tdep.c (sh_unwind_sp): Delete.
6518         (sh_unwind_pc): Delete.
6519         (sh_dummy_id): Delete.
6520         (sh_gdbarch_init): Don't register deleted functions with
6521         gdbarch.
6522
6523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6524
6525         * score-tdep.c (score_unwind_sp): Delete.
6526         (score_unwind_pc): Delete.
6527         (score_dummy_id): Delete.
6528         (score_gdbarch_init): Don't register deleted functions with
6529         gdbarch.
6530
6531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6532
6533         * rx-tdep.c (rx_unwind_pc): Delete.
6534         (rx_unwind_sp): Delete.
6535         (rx_dummy_id): Delete.
6536         (rx_gdbarch_init): Don't register deleted functions with
6537         gdbarch.  Update comment.
6538
6539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6540
6541         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6542         (rs6000_dummy_id): Delete.
6543         (rs6000_gdbarch_init): Don't register deleted functions with
6544         gdbarch.
6545
6546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6547
6548         * or1k-tdep.c (or1k_dummy_id): Delete.
6549         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6550
6551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6552
6553         * nios2-tdep.c (nios2_dummy_id): Delete.
6554         (nios2_unwind_sp): Delete.
6555         (nios2_gdbarch_init): Don't register deleted functions with
6556         gdbarch.
6557
6558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6559
6560         * nds32-tdep.c (nds32_dummy_id): Delete.
6561         (nds32_unwind_pc): Delete.
6562         (nds32_unwind_sp): Delete.
6563         (nds32_gdbarch_init): Don't register deleted functions with
6564         gdbarch.
6565
6566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6567
6568         * msp430-tdep.c (msp430_unwind_pc): Delete.
6569         (msp430_unwind_sp): Delete.
6570         (msp430_dummy_id): Delete.
6571         (msp430_gdbarch_init): Don't register deleted functions with
6572         gdbarch.
6573
6574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6575
6576         * moxie-tdep.c (moxie_unwind_sp): Delete.
6577         (moxie_unwind_pc): Delete.
6578         (moxie_dummy_id): Delete.
6579         (moxie_gdbarch_init): Don't register deleted functions with
6580         gdbarch.
6581
6582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6583
6584         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6585         (mn10300_unwind_pc): Delete.
6586         (mn10300_unwind_sp): Delete.
6587         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6588         mn10300_unwind_sp.
6589         (mn10300_frame_unwind_init): Don't register deleted functions with
6590         gdbarch.
6591
6592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6593
6594         * mep-tdep.c (mep_unwind_pc): Delete.
6595         (mep_unwind_sp): Delete.
6596         (mep_dummy_id): Delete.
6597         (mep_gdbarch_init): Don't register deleted functions with
6598         gdbarch.
6599
6600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6601
6602         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6603         (m68hc11_unwind_sp): Delete.
6604         (m68hc11_gdbarch_init): Don't register deleted functions with
6605         gdbarch.
6606
6607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6608
6609         * m32r-tdep.c (m32r_unwind_sp): Delete.
6610         (m32r_unwind_pc): Delete.
6611         (m32r_dummy_id): Delete.
6612         (m32r_gdbarch_init): Don't register deleted functions with
6613         gdbarch.
6614
6615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6616
6617         * m32c-tdep.c (m32c_unwind_pc): Delete.
6618         (m32c_unwind_sp): Delete.
6619         (m32c_dummy_id): Delete.
6620         (m32c_gdbarch_init): Don't register deleted functions with
6621         gdbarch.
6622
6623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6624
6625         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6626         (lm32_unwind_pc): Delete.
6627         (lm32_dummy_id): Delete.
6628         (lm32_gdbarch_init): Don't register deleted functions with
6629         gdbarch.
6630
6631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6632
6633         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6634         (iq2000_unwind_pc): Delete.
6635         (iq2000_dummy_id): Delete.
6636         (iq2000_gdbarch_init): Don't register deleted functions with
6637         gdbarch.
6638
6639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6640
6641         * nds32-tdep.c (nds32_type_align): Delete.
6642         (nds32_push_dummy_call): Use type_align instead.
6643
6644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6645
6646         * arm-tdep.c (arm_type_align): Only handle vector override case.
6647         (arm_push_dummy_call): Use type_align.
6648         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6649
6650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6651
6652         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6653         case.
6654         (pass_on_stack): Use type_align.
6655         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6656         function.
6657
6658 2019-04-23  Tom Tromey  <tromey@adacore.com>
6659
6660         * dwarf2read.c (line_header::file_name_at): Remove unused
6661         overload.
6662
6663 2019-04-23  Tom de Vries  <tdevries@suse.de>
6664
6665         PR gdb/24438
6666         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6667         invocation.
6668
6669
6670 2019-03-27  Ali Tamur  <tamur@google.com>
6671
6672         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6673         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6674         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6675         (dwarf_expr_context::get_addr_index): Likewise
6676         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6677         (symbol_needs_eval_context::get_addr_index): Likewise
6678         (disassemble_dwarf_expression): Add DW_OP_addrx
6679         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6680         (read_cutu_die_from_dwo): Update comment
6681         (skip_one_die): Add DW_FORM_addrx
6682         (read_attribute_value): Likewise
6683         (var_decode_location): Add DW_OP_addrx
6684         (dwarf2_const_value_attr): Add DW_FORM_addrx
6685         (dump_die_shallow): Likewise
6686         (dwarf2_fetch_constant_bytes): Likewise
6687         (decode_locdesc): Add DW_OP_addrx
6688         (skip_form_bytes): Add DW_FORM_addrx
6689
6690 2019-04-22  Ali Tamur  <tamur@google.com>
6691
6692         * MAINTAINERS (Write After Approval): Add self.
6693
6694 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6695
6696         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6697         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6698         (open_symbol_file_object): Likewise.
6699         (svr4_default_sos): Add info parameter.
6700         (svr4_read_so_list): Likewise.
6701         (svr4_current_sos_direct): Adjust functions calls to pass down
6702         info.
6703         (svr4_current_sos_1): Add info parameter.
6704         (svr4_current_sos): Call get_svr4_info, pass info down to
6705         svr4_current_sos_1.
6706         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6707         get_svr4_info.
6708         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6709         get_svr4_info.
6710         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6711         to get_svr4_info.
6712         (probes_table_remove_objfile_probes): Likewise.
6713         (register_solib_event_probe): Add info parameter.
6714         (solist_update_incremental): Pass info parameter down to
6715         svr4_read_so_list.
6716         (disable_probes_interface): Add info parameter.
6717         (svr4_handle_solib_event): Pass current_program_space to
6718         get_svr4_info.  Adjust disable_probes_interface cleanup.
6719         (svr4_create_probe_breakpoints): Add info parameter, pass it
6720         down to register_solib_event_probe.
6721         (svr4_create_solib_event_breakpoints): Add info parameter,
6722         pass it down to svr4_create_probe_breakpoints.
6723         (enable_break): Pass info down to
6724         svr4_create_solib_event_breakpoints.
6725         (svr4_solib_create_inferior_hook): Pass current_program_space to
6726         get_svr4_info.
6727         (svr4_clear_solib): Likewise.
6728
6729 2019-04-22  Pedro Alves  <palves@redhat.com>
6730
6731         * solib-svr4.c (svr4_free_objfile_observer): New.
6732         (probe_and_action::objfile): New field.
6733         (probes_table_htab_remove_objfile_probes)
6734         (probes_table_remove_objfile_probes): New functions.
6735         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6736         in the new probe_and_action.  Don't store the probe in 'lookup'.
6737         (svr4_create_probe_breakpoints): Pass objfile to
6738         register_solib_event_probe.
6739         (_initialize_svr4_solib): Register a free_objfile observer.
6740
6741 2019-04-19  Tom Tromey  <tom@tromey.com>
6742
6743         * common/queue.h: Remove.
6744
6745 2019-04-19  Tom Tromey  <tom@tromey.com>
6746
6747         * event-loop.c: Don't include "common/queue.h".
6748
6749 2019-04-19  Tom Tromey  <tom@tromey.com>
6750
6751         * remote.c (remote_target): Use delete.
6752         * remote-notif.h: Include <list>, not "common/queue.h".
6753         (notif_client_p): Remove typedef.
6754         (remote_notif_state): Add constructor, destructor, initializer.
6755         <notif_queue>: Now a std::list.
6756         (remote_notif_state_xfree): Don't declare.
6757         * remote-notif.c (remote_notif_process, handle_notification)
6758         (remote_notif_state_allocate): Update.
6759         (~remote_notif_state): Rename from remote_notif_state_xfree.
6760
6761 2019-04-19  Tom Tromey  <tom@tromey.com>
6762
6763         * symfile.c (reread_symbols): Update.
6764         * objfiles.c (objfile_register_static_link)
6765         (objfile_lookup_static_link): Update
6766         (~objfile) Don't delete static_links.
6767         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6768
6769 2019-04-19  Tom Tromey  <tom@tromey.com>
6770
6771         * type-stack.h (struct type_stack) <insert>: Constify string.
6772         * type-stack.c (type_stack::insert): Constify string.
6773         * gdbtypes.h (lookup_template_type): Update.
6774         (address_space_name_to_int): Update.
6775         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6776         const.
6777         (lookup_template_type): Make name const.
6778         * c-exp.y: Update rules.
6779         (lex_one_token, classify_name, classify_inner_name)
6780         (c_print_token): Update.
6781         * p-exp.y: Update rules.
6782         (yylex): Update.
6783         * f-exp.y: Update rules.
6784         (yylex): Update.
6785         * d-exp.y: Update rules.
6786         (lex_one_token, classify_name, classify_inner_name): Update.
6787         * parse.c (write_dollar_variable, copy_name): Return std::string.
6788         * parser-defs.h (copy_name): Change return type.
6789         * m2-exp.y: Update rules.
6790         (yylex): Update.
6791         * go-exp.y (lex_one_token): Update.
6792         Update rules.
6793         (classify_unsafe_function, classify_packaged_name)
6794         (classify_name, yylex): Update.
6795
6796 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6797
6798         * configure.ac: add --enable-source-highlight switch.
6799         * configure: Regenerate.
6800         * top.c (print_gdb_version): plumb --enable-source-highlight
6801         status to "show configuration".
6802
6803 2019-04-19  Tom Tromey  <tromey@adacore.com>
6804
6805         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6806         Check ADA_TYPE_P.
6807         (empty_record, ada_template_to_fixed_record_type_1)
6808         (template_to_static_fixed_type)
6809         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6810         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6811         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6812         macros.
6813
6814 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6815
6816         PR symtab/24423:
6817         * source.c (print_source_lines_base): Advance "iter" when a
6818         control character is seen.
6819
6820 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6821
6822         * inferior.h (struct infcall_suspend_state_deleter):
6823         Catch exception in destructor to avoid crash.
6824
6825 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6826
6827         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6828         close to the add_com "shell".
6829
6830 2019-04-18  Tom Tromey  <tromey@adacore.com>
6831
6832         * process-stratum-target.h (class process_stratum_target)
6833         <stratum>: Add "final".
6834
6835 2019-04-17  Tom Tromey  <tromey@adacore.com>
6836
6837         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6838         against nullptr before use.
6839
6840 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6841
6842         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6843
6844 2019-04-17  Jim Wilson  <jimw@sifive.com>
6845             Andrew Burgess  <andrew.burgess@embecosm.com>
6846
6847         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6848         code read might fail, assume 4-byte breakpoint in that case.
6849
6850 2019-04-15  Leszek Swirski  <leszeks@google.com>
6851
6852         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6853         rather than a hand-rolled POD check when checking for forced MEMORY
6854         classification.
6855
6856 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6857
6858         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6859         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6860         function.
6861         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6862         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6863         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6864         declaration.
6865
6866 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6867
6868         * aarch64-linux-nat.c
6869         (aarch64_linux_nat_target::thread_architecture): Add override.
6870         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6871         each VQ.
6872
6873 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6874
6875         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6876
6877 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6878
6879         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6880         target types of size 96-bits, add some additional comments, and
6881         check that the builtin type we found was the correct size.
6882
6883 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6884
6885         * utils.c (prompt_for_continue): Don't restore the styling at the
6886         end, as applied_style has the wrong value.  This fixes styling in
6887         long lists of file names that are interrupted by the "Continue?"
6888         prompt.
6889
6890 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6891
6892         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6893         * c-lang.c (c_language_defn): Likewise.
6894         (cplus_language_defn): Likewise.
6895         (asm_language_defn): Likewise.
6896         (minimal_language_defn): Likewise.
6897         * d-lang.c (d_language_defn): Likewise.
6898         * f-lang.c (f_language_defn): Likewise.
6899         * go-lang.c (go_language_defn): Likewise.
6900         * language.c (unknown_language_defn): Likewise.
6901         (auto_language_defn): Likewise.
6902         * language.h (struct language_defn): Remove la_magic field.
6903         (LANG_MAGIC): Delete.
6904         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6905         * objc-lang.c (objc_language_defn): Likewise.
6906         * opencl-lang.c (opencl_language_defn): Likewise.
6907         * p-lang.c (pascal_language_defn): Likewise.
6908         * rust-lang.c (rust_language_defn): Likewise.
6909
6910 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6911
6912         * riscv-tdep.c (riscv_type_align): New function.
6913         (riscv_type_alignment): Delete.
6914         (riscv_arg_location): Use 'type_align'.
6915         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6916
6917 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6918
6919         * gdbtypes.c (type_align): A struct with no non-static fields also
6920         has alignment of 1.
6921
6922 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6923
6924         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6925         component to 0.
6926         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6927         member.
6928         (riscv_struct_info::analyse): New implementation using new
6929         analyse_inner member function.
6930         (riscv_struct_info::field_offset): New member function.
6931         (riscv_struct_info::m_offsets): New member variable.
6932         (riscv_struct_info::analyse_inner): New private member function,
6933         takes the old implementation of riscv_struct_info::analyse but
6934         extended to track field offsets.
6935         (riscv_call_arg_struct): Update the struct folding special cases
6936         to handle cases where empty C++ structs, which are non-zero
6937         length, are found.
6938         (riscv_arg_location): Initialise the length of each location, a
6939         non-zero length now indicates the location is in use.
6940         (riscv_push_dummy_call): Allow for the first location having a
6941         non-zero offset when setting up arguments.
6942         (riscv_return_value): Likewise, but for return values.
6943
6944 2019-04-11  Tom Tromey  <tromey@adacore.com>
6945
6946         * utils.c (internal_vproblem): Make "msg" const.
6947
6948 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6949
6950         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6951         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6952         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6953         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6954
6955 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6956
6957         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6958         function.
6959         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6960         of amd64_collect_native_gregset.
6961         (amd64_linux_nat_target::store_registers): Likewise.
6962
6963 2019-04-10  Tom Tromey  <tom@tromey.com>
6964
6965         * symtab.c (lookup_global_symbol_from_objfile)
6966         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6967         * objfiles.h (class separate_debug_iterator): New.
6968         (class separate_debug_range): New.
6969         (struct objfile) <separate_debug_objfiles>: New method.
6970         (objfile_separate_debug_iterate): Don't declare.
6971         * objfiles.c (separate_debug_iterator::operator++): Rename from
6972         objfile_separate_debug_iterate.
6973         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6974         iterator.
6975         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6976         iterator.
6977
6978 2019-04-10  Tom Tromey  <tom@tromey.com>
6979
6980         * symfile.c (reread_symbols): Remove old comment.
6981         * objfiles.c (free_all_objfiles): Fix a typo.
6982
6983 2019-04-10  Tom Tromey  <tom@tromey.com>
6984
6985         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6986         * minsyms.c (lookup_minimal_symbol): Use foreach.
6987         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6988         (lookup_minimal_symbol_solib_trampoline): Likewise.
6989         * symfile.c (reread_symbols): Use foreach.
6990
6991 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6992             Tom Tromey  <tromey@adacore.com>
6993
6994         PR rust/24414:
6995         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6996         (rust_lex_int_test): Change "value" to be LONGEST.
6997         (rust_lex_tests): Add test for long integer literal.
6998
6999 2019-04-09  Tom Tromey  <tromey@adacore.com>
7000
7001         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7002         to bool.
7003         (extended_remote_target::attach): Update.
7004         (remote_target::remote_notice_new_inferior): Update.
7005         (remote_target::add_current_inferior_and_thread): Update.
7006         * inferior.c (exit_inferior_1): Use "false".
7007         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7008
7009 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7010
7011         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7012         the "start" command.
7013
7014 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7015
7016         * python/py-inferior.c (infpy_thread_from_thread_handle):
7017         Adjust comments to reflect renaming of thread_from_thread_handle
7018         to thread_from_handle.  Adjust keywords.  Fix type error message.
7019         (inferior_object_methods): Add thread_from_handle.  Retain
7020         thread_from_thread_handle, but mark it as deprecated.
7021
7022 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7023
7024         * gdbthread.h (find_thread_by_handle): Revise declaration.
7025         * thread.c (find_thread_by_handle): Likewise.  Adjust
7026         implementation too.
7027         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7028         support for buffer objects as handles.
7029
7030 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7031
7032         * python/py-infthread.c (thpy_thread_handle): New function.
7033         (thread_object_methods): Register thpy_thread_handle.
7034
7035 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7036
7037         * gdbthread.h (thread_to_thread_handle): Declare.
7038         * thread.c (gdbtypes.h): Include.
7039         (thread_to_thread_handle): New function.
7040
7041         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7042         (target_thread_info_to_thread_handle): Declare.
7043         * target.c (target_thread_info_to_thread_handle): New function.
7044         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7045         * target-delegates.c: Regenerate.
7046
7047         * linux-thread-db.c (class thread_db_target): Add method
7048         thread_info_to_thread_handle.
7049         (thread_db_target::thread_info_to_thread_handle): Define.
7050         * remote.c (class remote_target): Add new method
7051         thread_info_to_thread_handle.
7052         (remote_target::thread_info_to_thread_handle): Define.
7053
7054 2019-04-08  Pedro Alves  <palves@redhat.com>
7055
7056         * common/common-exceptions.c (throw_exception): Don't create
7057         named object to throw; throw directly.
7058         (throw_it): Likewise.  Don't initialize gdb_exception::message
7059         here, with new; pass FMT and AP to the ctor instead.
7060         * common/common-exceptions.h: Include <string>.
7061         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7062         const char *, va_list)): New ctor.  Use std::make_shared.
7063         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7064         errors)): Delete.
7065         (gdb_exception_error::gdb_exception_error(enum errors, const char
7066         *, va_list)): New.
7067         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7068         Add assertion.
7069         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7070         errors)): Delete.
7071         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7072         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7073         Add assertion.
7074
7075 2019-04-08  Tom Tromey  <tom@tromey.com>
7076
7077         * valops.c (value_rtti_indirect_type): Replace throw_exception
7078         with throw.
7079         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7080         with throw.
7081         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7082         throw.
7083         * target.c (target_translate_tls_address): Replace throw_exception
7084         with throw.
7085         * stack.c (frame_apply_command_count): Replace throw_exception
7086         with throw.
7087         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7088         throw.
7089         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7090         with throw.
7091         * rs6000-tdep.c (rs6000_frame_cache)
7092         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7093         * remote.c: Replace throw_exception with throw.
7094         * record-full.c (record_full_message, record_full_wait_1)
7095         (record_full_restore): Replace throw_exception with throw.
7096         * record-btrace.c:
7097         (get_thread_current_frame_id, record_btrace_start_replaying)
7098         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7099         (cmd_record_btrace_start): Replace throw_exception with throw.
7100         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7101         throw.
7102         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7103         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7104         * linespec.c:
7105         (find_linespec_symbols): Replace throw_exception with throw.
7106         * infrun.c (displaced_step_prepare, resume): Replace
7107         throw_exception with throw.
7108         * infcmd.c (post_create_inferior): Replace throw_exception with
7109         throw.
7110         * inf-loop.c (inferior_event_handler): Replace throw_exception
7111         with throw.
7112         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7113         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7114         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7115         (get_prev_frame_always, get_frame_pc_if_available)
7116         (get_frame_address_in_block_if_available, get_frame_language):
7117         Replace throw_exception with throw.
7118         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7119         throw_exception with throw.
7120         * eval.c (fetch_subexp_value, evaluate_var_value)
7121         (evaluate_funcall, evaluate_subexp_standard): Replace
7122         throw_exception with throw.
7123         * dwarf2loc.c (call_site_find_chain)
7124         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7125         Replace throw_exception with throw.
7126         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7127         with throw.
7128         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7129         throw.
7130         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7131         * completer.c (complete_line_internal): Replace throw_exception
7132         with throw.
7133         * compile/compile-object-run.c (compile_object_run): Replace
7134         throw_exception with throw.
7135         * cli/cli-script.c (process_next_line): Replace throw_exception
7136         with throw.
7137         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7138         (btrace_enable, btrace_maint_update_pt_packets): Replace
7139         throw_exception with throw.
7140         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7141         throw_exception with throw.
7142         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7143         throw_exception with throw.
7144         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7145         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7146         * aarch64-tdep.c (aarch64_make_prologue_cache)
7147         (aarch64_make_stub_cache): Replace throw_exception with throw.
7148
7149 2019-04-08  Tom Tromey  <tom@tromey.com>
7150
7151         * common/common-exceptions.c (throw_exception): Rename from
7152         throw_exception_cxx.  Remove old copy.  Make argument const.
7153         (throw_it): Create and throw exception objects directly.
7154         * common/common-exceptions.h (throw_exception): Make argument
7155         const.
7156         (struct gdb_exception_error): Add constructor.
7157         (struct gdb_exception_quit): Add constructor.
7158
7159 2019-04-08  Tom Tromey  <tom@tromey.com>
7160
7161         * common/common-exceptions.h (exception_rethrow): Don't declare.
7162         (TRY_SJLJ): Update comment.
7163         (TRY, CATCH, END_CATCH): Remove.
7164         * common/common-exceptions.c (exception_rethrow): Remove.
7165
7166 2019-04-08  Tom Tromey  <tom@tromey.com>
7167
7168         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7169         Remove.
7170         (gdb_exception_error): Rename from
7171         gdb_exception_RETURN_MASK_ERROR.
7172         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7173         (gdb_quit_bad_alloc): Update.
7174         * aarch64-tdep.c: Update.
7175         * ada-lang.c: Update.
7176         * ada-typeprint.c: Update.
7177         * ada-valprint.c: Update.
7178         * amd64-tdep.c: Update.
7179         * arch-utils.c: Update.
7180         * break-catch-throw.c: Update.
7181         * breakpoint.c: Update.
7182         * btrace.c: Update.
7183         * c-varobj.c: Update.
7184         * cli/cli-cmds.c: Update.
7185         * cli/cli-interp.c: Update.
7186         * cli/cli-script.c: Update.
7187         * common/common-exceptions.c: Update.
7188         * common/new-op.c: Update.
7189         * common/selftest.c: Update.
7190         * compile/compile-c-symbols.c: Update.
7191         * compile/compile-cplus-symbols.c: Update.
7192         * compile/compile-object-load.c: Update.
7193         * compile/compile-object-run.c: Update.
7194         * completer.c: Update.
7195         * corelow.c: Update.
7196         * cp-abi.c: Update.
7197         * cp-support.c: Update.
7198         * cp-valprint.c: Update.
7199         * darwin-nat.c: Update.
7200         * disasm-selftests.c: Update.
7201         * dtrace-probe.c: Update.
7202         * dwarf-index-cache.c: Update.
7203         * dwarf-index-write.c: Update.
7204         * dwarf2-frame-tailcall.c: Update.
7205         * dwarf2-frame.c: Update.
7206         * dwarf2loc.c: Update.
7207         * dwarf2read.c: Update.
7208         * eval.c: Update.
7209         * event-loop.c: Update.
7210         * event-top.c: Update.
7211         * exec.c: Update.
7212         * f-valprint.c: Update.
7213         * fbsd-tdep.c: Update.
7214         * frame-unwind.c: Update.
7215         * frame.c: Update.
7216         * gdbtypes.c: Update.
7217         * gnu-v3-abi.c: Update.
7218         * guile/guile-internal.h: Update.
7219         * guile/scm-block.c: Update.
7220         * guile/scm-breakpoint.c: Update.
7221         * guile/scm-cmd.c: Update.
7222         * guile/scm-disasm.c: Update.
7223         * guile/scm-frame.c: Update.
7224         * guile/scm-lazy-string.c: Update.
7225         * guile/scm-math.c: Update.
7226         * guile/scm-param.c: Update.
7227         * guile/scm-ports.c: Update.
7228         * guile/scm-pretty-print.c: Update.
7229         * guile/scm-symbol.c: Update.
7230         * guile/scm-symtab.c: Update.
7231         * guile/scm-type.c: Update.
7232         * guile/scm-value.c: Update.
7233         * i386-linux-tdep.c: Update.
7234         * i386-tdep.c: Update.
7235         * inf-loop.c: Update.
7236         * infcall.c: Update.
7237         * infcmd.c: Update.
7238         * infrun.c: Update.
7239         * jit.c: Update.
7240         * language.c: Update.
7241         * linespec.c: Update.
7242         * linux-fork.c: Update.
7243         * linux-nat.c: Update.
7244         * linux-tdep.c: Update.
7245         * linux-thread-db.c: Update.
7246         * main.c: Update.
7247         * mi/mi-cmd-break.c: Update.
7248         * mi/mi-cmd-stack.c: Update.
7249         * mi/mi-interp.c: Update.
7250         * mi/mi-main.c: Update.
7251         * objc-lang.c: Update.
7252         * p-valprint.c: Update.
7253         * parse.c: Update.
7254         * ppc-linux-tdep.c: Update.
7255         * printcmd.c: Update.
7256         * python/py-arch.c: Update.
7257         * python/py-breakpoint.c: Update.
7258         * python/py-cmd.c: Update.
7259         * python/py-finishbreakpoint.c: Update.
7260         * python/py-frame.c: Update.
7261         * python/py-framefilter.c: Update.
7262         * python/py-gdb-readline.c: Update.
7263         * python/py-inferior.c: Update.
7264         * python/py-infthread.c: Update.
7265         * python/py-lazy-string.c: Update.
7266         * python/py-linetable.c: Update.
7267         * python/py-objfile.c: Update.
7268         * python/py-param.c: Update.
7269         * python/py-prettyprint.c: Update.
7270         * python/py-progspace.c: Update.
7271         * python/py-record-btrace.c: Update.
7272         * python/py-record.c: Update.
7273         * python/py-symbol.c: Update.
7274         * python/py-type.c: Update.
7275         * python/py-unwind.c: Update.
7276         * python/py-utils.c: Update.
7277         * python/py-value.c: Update.
7278         * python/python.c: Update.
7279         * record-btrace.c: Update.
7280         * record-full.c: Update.
7281         * remote-fileio.c: Update.
7282         * remote.c: Update.
7283         * riscv-tdep.c: Update.
7284         * rs6000-aix-tdep.c: Update.
7285         * rs6000-tdep.c: Update.
7286         * rust-exp.y: Update.
7287         * rust-lang.c: Update.
7288         * s390-tdep.c: Update.
7289         * selftest-arch.c: Update.
7290         * solib-dsbt.c: Update.
7291         * solib-frv.c: Update.
7292         * solib-spu.c: Update.
7293         * solib-svr4.c: Update.
7294         * solib.c: Update.
7295         * sparc64-linux-tdep.c: Update.
7296         * stack.c: Update.
7297         * symfile-mem.c: Update.
7298         * symmisc.c: Update.
7299         * target.c: Update.
7300         * thread.c: Update.
7301         * top.c: Update.
7302         * tracefile-tfile.c: Update.
7303         * tui/tui.c: Update.
7304         * typeprint.c: Update.
7305         * unittests/cli-utils-selftests.c: Update.
7306         * unittests/parse-connection-spec-selftests.c: Update.
7307         * valops.c: Update.
7308         * valprint.c: Update.
7309         * value.c: Update.
7310         * varobj.c: Update.
7311         * windows-nat.c: Update.
7312         * x86-linux-nat.c: Update.
7313         * xml-support.c: Update.
7314
7315 2019-04-08  Tom Tromey  <tom@tromey.com>
7316
7317         * xml-support.c: Use C++ exception handling.
7318         * x86-linux-nat.c: Use C++ exception handling.
7319         * windows-nat.c: Use C++ exception handling.
7320         * varobj.c: Use C++ exception handling.
7321         * value.c: Use C++ exception handling.
7322         * valprint.c: Use C++ exception handling.
7323         * valops.c: Use C++ exception handling.
7324         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7325         handling.
7326         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7327         * typeprint.c: Use C++ exception handling.
7328         * tui/tui.c: Use C++ exception handling.
7329         * tracefile-tfile.c: Use C++ exception handling.
7330         * top.c: Use C++ exception handling.
7331         * thread.c: Use C++ exception handling.
7332         * target.c: Use C++ exception handling.
7333         * symmisc.c: Use C++ exception handling.
7334         * symfile-mem.c: Use C++ exception handling.
7335         * stack.c: Use C++ exception handling.
7336         * sparc64-linux-tdep.c: Use C++ exception handling.
7337         * solib.c: Use C++ exception handling.
7338         * solib-svr4.c: Use C++ exception handling.
7339         * solib-spu.c: Use C++ exception handling.
7340         * solib-frv.c: Use C++ exception handling.
7341         * solib-dsbt.c: Use C++ exception handling.
7342         * selftest-arch.c: Use C++ exception handling.
7343         * s390-tdep.c: Use C++ exception handling.
7344         * rust-lang.c: Use C++ exception handling.
7345         * rust-exp.y: Use C++ exception handling.
7346         * rs6000-tdep.c: Use C++ exception handling.
7347         * rs6000-aix-tdep.c: Use C++ exception handling.
7348         * riscv-tdep.c: Use C++ exception handling.
7349         * remote.c: Use C++ exception handling.
7350         * remote-fileio.c: Use C++ exception handling.
7351         * record-full.c: Use C++ exception handling.
7352         * record-btrace.c: Use C++ exception handling.
7353         * python/python.c: Use C++ exception handling.
7354         * python/py-value.c: Use C++ exception handling.
7355         * python/py-utils.c: Use C++ exception handling.
7356         * python/py-unwind.c: Use C++ exception handling.
7357         * python/py-type.c: Use C++ exception handling.
7358         * python/py-symbol.c: Use C++ exception handling.
7359         * python/py-record.c: Use C++ exception handling.
7360         * python/py-record-btrace.c: Use C++ exception handling.
7361         * python/py-progspace.c: Use C++ exception handling.
7362         * python/py-prettyprint.c: Use C++ exception handling.
7363         * python/py-param.c: Use C++ exception handling.
7364         * python/py-objfile.c: Use C++ exception handling.
7365         * python/py-linetable.c: Use C++ exception handling.
7366         * python/py-lazy-string.c: Use C++ exception handling.
7367         * python/py-infthread.c: Use C++ exception handling.
7368         * python/py-inferior.c: Use C++ exception handling.
7369         * python/py-gdb-readline.c: Use C++ exception handling.
7370         * python/py-framefilter.c: Use C++ exception handling.
7371         * python/py-frame.c: Use C++ exception handling.
7372         * python/py-finishbreakpoint.c: Use C++ exception handling.
7373         * python/py-cmd.c: Use C++ exception handling.
7374         * python/py-breakpoint.c: Use C++ exception handling.
7375         * python/py-arch.c: Use C++ exception handling.
7376         * printcmd.c: Use C++ exception handling.
7377         * ppc-linux-tdep.c: Use C++ exception handling.
7378         * parse.c: Use C++ exception handling.
7379         * p-valprint.c: Use C++ exception handling.
7380         * objc-lang.c: Use C++ exception handling.
7381         * mi/mi-main.c: Use C++ exception handling.
7382         * mi/mi-interp.c: Use C++ exception handling.
7383         * mi/mi-cmd-stack.c: Use C++ exception handling.
7384         * mi/mi-cmd-break.c: Use C++ exception handling.
7385         * main.c: Use C++ exception handling.
7386         * linux-thread-db.c: Use C++ exception handling.
7387         * linux-tdep.c: Use C++ exception handling.
7388         * linux-nat.c: Use C++ exception handling.
7389         * linux-fork.c: Use C++ exception handling.
7390         * linespec.c: Use C++ exception handling.
7391         * language.c: Use C++ exception handling.
7392         * jit.c: Use C++ exception handling.
7393         * infrun.c: Use C++ exception handling.
7394         * infcmd.c: Use C++ exception handling.
7395         * infcall.c: Use C++ exception handling.
7396         * inf-loop.c: Use C++ exception handling.
7397         * i386-tdep.c: Use C++ exception handling.
7398         * i386-linux-tdep.c: Use C++ exception handling.
7399         * guile/scm-value.c: Use C++ exception handling.
7400         * guile/scm-type.c: Use C++ exception handling.
7401         * guile/scm-symtab.c: Use C++ exception handling.
7402         * guile/scm-symbol.c: Use C++ exception handling.
7403         * guile/scm-pretty-print.c: Use C++ exception handling.
7404         * guile/scm-ports.c: Use C++ exception handling.
7405         * guile/scm-param.c: Use C++ exception handling.
7406         * guile/scm-math.c: Use C++ exception handling.
7407         * guile/scm-lazy-string.c: Use C++ exception handling.
7408         * guile/scm-frame.c: Use C++ exception handling.
7409         * guile/scm-disasm.c: Use C++ exception handling.
7410         * guile/scm-cmd.c: Use C++ exception handling.
7411         * guile/scm-breakpoint.c: Use C++ exception handling.
7412         * guile/scm-block.c: Use C++ exception handling.
7413         * guile/guile-internal.h: Use C++ exception handling.
7414         * gnu-v3-abi.c: Use C++ exception handling.
7415         * gdbtypes.c: Use C++ exception handling.
7416         * frame.c: Use C++ exception handling.
7417         * frame-unwind.c: Use C++ exception handling.
7418         * fbsd-tdep.c: Use C++ exception handling.
7419         * f-valprint.c: Use C++ exception handling.
7420         * exec.c: Use C++ exception handling.
7421         * event-top.c: Use C++ exception handling.
7422         * event-loop.c: Use C++ exception handling.
7423         * eval.c: Use C++ exception handling.
7424         * dwarf2read.c: Use C++ exception handling.
7425         * dwarf2loc.c: Use C++ exception handling.
7426         * dwarf2-frame.c: Use C++ exception handling.
7427         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7428         * dwarf-index-write.c: Use C++ exception handling.
7429         * dwarf-index-cache.c: Use C++ exception handling.
7430         * dtrace-probe.c: Use C++ exception handling.
7431         * disasm-selftests.c: Use C++ exception handling.
7432         * darwin-nat.c: Use C++ exception handling.
7433         * cp-valprint.c: Use C++ exception handling.
7434         * cp-support.c: Use C++ exception handling.
7435         * cp-abi.c: Use C++ exception handling.
7436         * corelow.c: Use C++ exception handling.
7437         * completer.c: Use C++ exception handling.
7438         * compile/compile-object-run.c: Use C++ exception handling.
7439         * compile/compile-object-load.c: Use C++ exception handling.
7440         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7441         * compile/compile-c-symbols.c: Use C++ exception handling.
7442         * common/selftest.c: Use C++ exception handling.
7443         * common/new-op.c: Use C++ exception handling.
7444         * cli/cli-script.c: Use C++ exception handling.
7445         * cli/cli-interp.c: Use C++ exception handling.
7446         * cli/cli-cmds.c: Use C++ exception handling.
7447         * c-varobj.c: Use C++ exception handling.
7448         * btrace.c: Use C++ exception handling.
7449         * breakpoint.c: Use C++ exception handling.
7450         * break-catch-throw.c: Use C++ exception handling.
7451         * arch-utils.c: Use C++ exception handling.
7452         * amd64-tdep.c: Use C++ exception handling.
7453         * ada-valprint.c: Use C++ exception handling.
7454         * ada-typeprint.c: Use C++ exception handling.
7455         * ada-lang.c: Use C++ exception handling.
7456         * aarch64-tdep.c: Use C++ exception handling.
7457
7458 2019-04-08  Tom Tromey  <tom@tromey.com>
7459
7460         * xml-support.c (gdb_xml_parser::parse): Update.
7461         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7462         * value.c (show_convenience): Update.
7463         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7464         (test_parse_flags_qcs): Update.
7465         * thread.c (thr_try_catch_cmd): Update.
7466         * target.c (target_translate_tls_address): Update.
7467         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7468         (info_frame_command_core, frame_apply_command_count): Update.
7469         * rust-exp.y (rust_lex_exception_test): Update.
7470         * riscv-tdep.c (riscv_print_one_register_info): Update.
7471         * remote.c (remote_target::enable_btrace): Update.
7472         * record-btrace.c (record_btrace_enable_warn): Update.
7473         * python/py-utils.c (gdbpy_convert_exception): Update.
7474         * printcmd.c (do_one_display, print_variable_and_value): Update.
7475         * mi/mi-main.c (mi_print_exception): Update.
7476         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7477         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7478         * linux-nat.c (linux_nat_target::attach): Update.
7479         * linux-fork.c (class scoped_switch_fork_info): Update.
7480         * infrun.c (displaced_step_prepare): Update.
7481         * infcall.c (call_function_by_hand_dummy): Update.
7482         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7483         * gnu-v3-abi.c (print_one_vtable): Update.
7484         * frame.c (get_prev_frame_always): Update.
7485         * f-valprint.c (info_common_command_for_block): Update.
7486         * exec.c (try_open_exec_file): Update.
7487         * exceptions.c (print_exception, exception_print)
7488         (exception_fprintf, exception_print_same): Update.
7489         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7490         * dwarf-index-cache.c (index_cache::store)
7491         (index_cache::lookup_gdb_index): Update.
7492         * darwin-nat.c (maybe_cache_shell): Update.
7493         * cp-valprint.c (cp_print_value_fields): Update.
7494         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7495         (gcc_cplus_symbol_address): Update.
7496         * compile/compile-c-symbols.c (gcc_convert_symbol)
7497         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7498         * common/selftest.c: Update.
7499         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7500         a std::string.
7501         (exception_try_scope_entry, exception_try_scope_exit): Don't
7502         declare.
7503         (struct exception_try_scope): Remove.
7504         (TRY): Don't use exception_try_scope.
7505         (struct gdb_exception): Add constructor, operator=.
7506         <what>: New method.
7507         (struct gdb_exception_RETURN_MASK_ALL)
7508         (struct gdb_exception_RETURN_MASK_ERROR)
7509         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7510         (struct gdb_quit_bad_alloc): Update.
7511         * common/common-exceptions.c (exception_none): Change
7512         initializer.
7513         (struct catcher) <state, exception>: Initialize inline.
7514         <prev>: Remove member.
7515         (current_catcher): Remove.
7516         (catchers): New global.
7517         (exceptions_state_mc_init): Simplify.
7518         (catcher_pop): Remove.
7519         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7520         (try_scope_depth, exception_try_scope_entry)
7521         (exception_try_scope_exit): Remove.
7522         (throw_exception_sjlj): Update.
7523         (exception_messages, exception_messages_size): Remove.
7524         (throw_it): Simplify.
7525         (gdb_exception_sliced_copy): Remove.
7526         (throw_exception_cxx): Update.
7527         * cli/cli-script.c (script_from_file): Update.
7528         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7529         Update.
7530         * ada-valprint.c (ada_val_print): Update.
7531         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7532         (create_excep_cond_exprs): Update.
7533
7534 2019-04-08  Tom Tromey  <tom@tromey.com>
7535
7536         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7537         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7538         (TRY, CATCH, END_CATCH): Remove some definitions.
7539         * common/common-exceptions.c: Don't use GDB_XCPT.
7540         (catcher_list_size): Remove.
7541         (throw_exception, throw_it): Simplify.
7542
7543 2019-04-05  Tom Tromey  <tom@tromey.com>
7544
7545         Revert the header-sorting patch.
7546         * ft32-tdep.c: Revert.
7547         * frv-tdep.c: Revert.
7548         * frv-linux-tdep.c: Revert.
7549         * frame.c: Revert.
7550         * frame-unwind.c: Revert.
7551         * frame-base.c: Revert.
7552         * fork-child.c: Revert.
7553         * findvar.c: Revert.
7554         * findcmd.c: Revert.
7555         * filesystem.c: Revert.
7556         * filename-seen-cache.h: Revert.
7557         * filename-seen-cache.c: Revert.
7558         * fbsd-tdep.c: Revert.
7559         * fbsd-nat.h: Revert.
7560         * fbsd-nat.c: Revert.
7561         * f-valprint.c: Revert.
7562         * f-typeprint.c: Revert.
7563         * f-lang.c: Revert.
7564         * extension.h: Revert.
7565         * extension.c: Revert.
7566         * extension-priv.h: Revert.
7567         * expprint.c: Revert.
7568         * exec.h: Revert.
7569         * exec.c: Revert.
7570         * exceptions.c: Revert.
7571         * event-top.c: Revert.
7572         * event-loop.c: Revert.
7573         * eval.c: Revert.
7574         * elfread.c: Revert.
7575         * dwarf2read.h: Revert.
7576         * dwarf2read.c: Revert.
7577         * dwarf2loc.c: Revert.
7578         * dwarf2expr.h: Revert.
7579         * dwarf2expr.c: Revert.
7580         * dwarf2-frame.c: Revert.
7581         * dwarf2-frame-tailcall.c: Revert.
7582         * dwarf-index-write.h: Revert.
7583         * dwarf-index-write.c: Revert.
7584         * dwarf-index-common.c: Revert.
7585         * dwarf-index-cache.h: Revert.
7586         * dwarf-index-cache.c: Revert.
7587         * dummy-frame.c: Revert.
7588         * dtrace-probe.c: Revert.
7589         * disasm.h: Revert.
7590         * disasm.c: Revert.
7591         * disasm-selftests.c: Revert.
7592         * dictionary.c: Revert.
7593         * dicos-tdep.c: Revert.
7594         * demangle.c: Revert.
7595         * dcache.h: Revert.
7596         * dcache.c: Revert.
7597         * darwin-nat.h: Revert.
7598         * darwin-nat.c: Revert.
7599         * darwin-nat-info.c: Revert.
7600         * d-valprint.c: Revert.
7601         * d-namespace.c: Revert.
7602         * d-lang.c: Revert.
7603         * ctf.c: Revert.
7604         * csky-tdep.c: Revert.
7605         * csky-linux-tdep.c: Revert.
7606         * cris-tdep.c: Revert.
7607         * cris-linux-tdep.c: Revert.
7608         * cp-valprint.c: Revert.
7609         * cp-support.c: Revert.
7610         * cp-namespace.c: Revert.
7611         * cp-abi.c: Revert.
7612         * corelow.c: Revert.
7613         * corefile.c: Revert.
7614         * continuations.c: Revert.
7615         * completer.h: Revert.
7616         * completer.c: Revert.
7617         * complaints.c: Revert.
7618         * coffread.c: Revert.
7619         * coff-pe-read.c: Revert.
7620         * cli-out.h: Revert.
7621         * cli-out.c: Revert.
7622         * charset.c: Revert.
7623         * c-varobj.c: Revert.
7624         * c-valprint.c: Revert.
7625         * c-typeprint.c: Revert.
7626         * c-lang.c: Revert.
7627         * buildsym.c: Revert.
7628         * buildsym-legacy.c: Revert.
7629         * build-id.h: Revert.
7630         * build-id.c: Revert.
7631         * btrace.c: Revert.
7632         * bsd-uthread.c: Revert.
7633         * breakpoint.h: Revert.
7634         * breakpoint.c: Revert.
7635         * break-catch-throw.c: Revert.
7636         * break-catch-syscall.c: Revert.
7637         * break-catch-sig.c: Revert.
7638         * blockframe.c: Revert.
7639         * block.c: Revert.
7640         * bfin-tdep.c: Revert.
7641         * bfin-linux-tdep.c: Revert.
7642         * bfd-target.c: Revert.
7643         * bcache.c: Revert.
7644         * ax-general.c: Revert.
7645         * ax-gdb.h: Revert.
7646         * ax-gdb.c: Revert.
7647         * avr-tdep.c: Revert.
7648         * auxv.c: Revert.
7649         * auto-load.c: Revert.
7650         * arm-wince-tdep.c: Revert.
7651         * arm-tdep.c: Revert.
7652         * arm-symbian-tdep.c: Revert.
7653         * arm-pikeos-tdep.c: Revert.
7654         * arm-obsd-tdep.c: Revert.
7655         * arm-nbsd-tdep.c: Revert.
7656         * arm-nbsd-nat.c: Revert.
7657         * arm-linux-tdep.c: Revert.
7658         * arm-linux-nat.c: Revert.
7659         * arm-fbsd-tdep.c: Revert.
7660         * arm-fbsd-nat.c: Revert.
7661         * arm-bsd-tdep.c: Revert.
7662         * arch-utils.c: Revert.
7663         * arc-tdep.c: Revert.
7664         * arc-newlib-tdep.c: Revert.
7665         * annotate.h: Revert.
7666         * annotate.c: Revert.
7667         * amd64-windows-tdep.c: Revert.
7668         * amd64-windows-nat.c: Revert.
7669         * amd64-tdep.c: Revert.
7670         * amd64-sol2-tdep.c: Revert.
7671         * amd64-obsd-tdep.c: Revert.
7672         * amd64-obsd-nat.c: Revert.
7673         * amd64-nbsd-tdep.c: Revert.
7674         * amd64-nbsd-nat.c: Revert.
7675         * amd64-nat.c: Revert.
7676         * amd64-linux-tdep.c: Revert.
7677         * amd64-linux-nat.c: Revert.
7678         * amd64-fbsd-tdep.c: Revert.
7679         * amd64-fbsd-nat.c: Revert.
7680         * amd64-dicos-tdep.c: Revert.
7681         * amd64-darwin-tdep.c: Revert.
7682         * amd64-bsd-nat.c: Revert.
7683         * alpha-tdep.c: Revert.
7684         * alpha-obsd-tdep.c: Revert.
7685         * alpha-nbsd-tdep.c: Revert.
7686         * alpha-mdebug-tdep.c: Revert.
7687         * alpha-linux-tdep.c: Revert.
7688         * alpha-linux-nat.c: Revert.
7689         * alpha-bsd-tdep.c: Revert.
7690         * alpha-bsd-nat.c: Revert.
7691         * aix-thread.c: Revert.
7692         * agent.c: Revert.
7693         * addrmap.c: Revert.
7694         * ada-varobj.c: Revert.
7695         * ada-valprint.c: Revert.
7696         * ada-typeprint.c: Revert.
7697         * ada-tasks.c: Revert.
7698         * ada-lang.c: Revert.
7699         * aarch64-tdep.c: Revert.
7700         * aarch64-ravenscar-thread.c: Revert.
7701         * aarch64-newlib-tdep.c: Revert.
7702         * aarch64-linux-tdep.c: Revert.
7703         * aarch64-linux-nat.c: Revert.
7704         * aarch64-fbsd-tdep.c: Revert.
7705         * aarch64-fbsd-nat.c: Revert.
7706         * aarch32-linux-nat.c: Revert.
7707
7708 2019-04-05  Tom Tromey  <tom@tromey.com>
7709
7710         * ft32-tdep.c: Sort headers.
7711         * frv-tdep.c: Sort headers.
7712         * frv-linux-tdep.c: Sort headers.
7713         * frame.c: Sort headers.
7714         * frame-unwind.c: Sort headers.
7715         * frame-base.c: Sort headers.
7716         * fork-child.c: Sort headers.
7717         * findvar.c: Sort headers.
7718         * findcmd.c: Sort headers.
7719         * filesystem.c: Sort headers.
7720         * filename-seen-cache.h: Sort headers.
7721         * filename-seen-cache.c: Sort headers.
7722         * fbsd-tdep.c: Sort headers.
7723         * fbsd-nat.h: Sort headers.
7724         * fbsd-nat.c: Sort headers.
7725         * f-valprint.c: Sort headers.
7726         * f-typeprint.c: Sort headers.
7727         * f-lang.c: Sort headers.
7728         * extension.h: Sort headers.
7729         * extension.c: Sort headers.
7730         * extension-priv.h: Sort headers.
7731         * expprint.c: Sort headers.
7732         * exec.h: Sort headers.
7733         * exec.c: Sort headers.
7734         * exceptions.c: Sort headers.
7735         * event-top.c: Sort headers.
7736         * event-loop.c: Sort headers.
7737         * eval.c: Sort headers.
7738         * elfread.c: Sort headers.
7739         * dwarf2read.h: Sort headers.
7740         * dwarf2read.c: Sort headers.
7741         * dwarf2loc.c: Sort headers.
7742         * dwarf2expr.h: Sort headers.
7743         * dwarf2expr.c: Sort headers.
7744         * dwarf2-frame.c: Sort headers.
7745         * dwarf2-frame-tailcall.c: Sort headers.
7746         * dwarf-index-write.h: Sort headers.
7747         * dwarf-index-write.c: Sort headers.
7748         * dwarf-index-common.c: Sort headers.
7749         * dwarf-index-cache.h: Sort headers.
7750         * dwarf-index-cache.c: Sort headers.
7751         * dummy-frame.c: Sort headers.
7752         * dtrace-probe.c: Sort headers.
7753         * disasm.h: Sort headers.
7754         * disasm.c: Sort headers.
7755         * disasm-selftests.c: Sort headers.
7756         * dictionary.c: Sort headers.
7757         * dicos-tdep.c: Sort headers.
7758         * demangle.c: Sort headers.
7759         * dcache.h: Sort headers.
7760         * dcache.c: Sort headers.
7761         * darwin-nat.h: Sort headers.
7762         * darwin-nat.c: Sort headers.
7763         * darwin-nat-info.c: Sort headers.
7764         * d-valprint.c: Sort headers.
7765         * d-namespace.c: Sort headers.
7766         * d-lang.c: Sort headers.
7767         * ctf.c: Sort headers.
7768         * csky-tdep.c: Sort headers.
7769         * csky-linux-tdep.c: Sort headers.
7770         * cris-tdep.c: Sort headers.
7771         * cris-linux-tdep.c: Sort headers.
7772         * cp-valprint.c: Sort headers.
7773         * cp-support.c: Sort headers.
7774         * cp-namespace.c: Sort headers.
7775         * cp-abi.c: Sort headers.
7776         * corelow.c: Sort headers.
7777         * corefile.c: Sort headers.
7778         * continuations.c: Sort headers.
7779         * completer.h: Sort headers.
7780         * completer.c: Sort headers.
7781         * complaints.c: Sort headers.
7782         * coffread.c: Sort headers.
7783         * coff-pe-read.c: Sort headers.
7784         * cli-out.h: Sort headers.
7785         * cli-out.c: Sort headers.
7786         * charset.c: Sort headers.
7787         * c-varobj.c: Sort headers.
7788         * c-valprint.c: Sort headers.
7789         * c-typeprint.c: Sort headers.
7790         * c-lang.c: Sort headers.
7791         * buildsym.c: Sort headers.
7792         * buildsym-legacy.c: Sort headers.
7793         * build-id.h: Sort headers.
7794         * build-id.c: Sort headers.
7795         * btrace.c: Sort headers.
7796         * bsd-uthread.c: Sort headers.
7797         * breakpoint.h: Sort headers.
7798         * breakpoint.c: Sort headers.
7799         * break-catch-throw.c: Sort headers.
7800         * break-catch-syscall.c: Sort headers.
7801         * break-catch-sig.c: Sort headers.
7802         * blockframe.c: Sort headers.
7803         * block.c: Sort headers.
7804         * bfin-tdep.c: Sort headers.
7805         * bfin-linux-tdep.c: Sort headers.
7806         * bfd-target.c: Sort headers.
7807         * bcache.c: Sort headers.
7808         * ax-general.c: Sort headers.
7809         * ax-gdb.h: Sort headers.
7810         * ax-gdb.c: Sort headers.
7811         * avr-tdep.c: Sort headers.
7812         * auxv.c: Sort headers.
7813         * auto-load.c: Sort headers.
7814         * arm-wince-tdep.c: Sort headers.
7815         * arm-tdep.c: Sort headers.
7816         * arm-symbian-tdep.c: Sort headers.
7817         * arm-pikeos-tdep.c: Sort headers.
7818         * arm-obsd-tdep.c: Sort headers.
7819         * arm-nbsd-tdep.c: Sort headers.
7820         * arm-nbsd-nat.c: Sort headers.
7821         * arm-linux-tdep.c: Sort headers.
7822         * arm-linux-nat.c: Sort headers.
7823         * arm-fbsd-tdep.c: Sort headers.
7824         * arm-fbsd-nat.c: Sort headers.
7825         * arm-bsd-tdep.c: Sort headers.
7826         * arch-utils.c: Sort headers.
7827         * arc-tdep.c: Sort headers.
7828         * arc-newlib-tdep.c: Sort headers.
7829         * annotate.h: Sort headers.
7830         * annotate.c: Sort headers.
7831         * amd64-windows-tdep.c: Sort headers.
7832         * amd64-windows-nat.c: Sort headers.
7833         * amd64-tdep.c: Sort headers.
7834         * amd64-sol2-tdep.c: Sort headers.
7835         * amd64-obsd-tdep.c: Sort headers.
7836         * amd64-obsd-nat.c: Sort headers.
7837         * amd64-nbsd-tdep.c: Sort headers.
7838         * amd64-nbsd-nat.c: Sort headers.
7839         * amd64-nat.c: Sort headers.
7840         * amd64-linux-tdep.c: Sort headers.
7841         * amd64-linux-nat.c: Sort headers.
7842         * amd64-fbsd-tdep.c: Sort headers.
7843         * amd64-fbsd-nat.c: Sort headers.
7844         * amd64-dicos-tdep.c: Sort headers.
7845         * amd64-darwin-tdep.c: Sort headers.
7846         * amd64-bsd-nat.c: Sort headers.
7847         * alpha-tdep.c: Sort headers.
7848         * alpha-obsd-tdep.c: Sort headers.
7849         * alpha-nbsd-tdep.c: Sort headers.
7850         * alpha-mdebug-tdep.c: Sort headers.
7851         * alpha-linux-tdep.c: Sort headers.
7852         * alpha-linux-nat.c: Sort headers.
7853         * alpha-bsd-tdep.c: Sort headers.
7854         * alpha-bsd-nat.c: Sort headers.
7855         * aix-thread.c: Sort headers.
7856         * agent.c: Sort headers.
7857         * addrmap.c: Sort headers.
7858         * ada-varobj.c: Sort headers.
7859         * ada-valprint.c: Sort headers.
7860         * ada-typeprint.c: Sort headers.
7861         * ada-tasks.c: Sort headers.
7862         * ada-lang.c: Sort headers.
7863         * aarch64-tdep.c: Sort headers.
7864         * aarch64-ravenscar-thread.c: Sort headers.
7865         * aarch64-newlib-tdep.c: Sort headers.
7866         * aarch64-linux-tdep.c: Sort headers.
7867         * aarch64-linux-nat.c: Sort headers.
7868         * aarch64-fbsd-tdep.c: Sort headers.
7869         * aarch64-fbsd-nat.c: Sort headers.
7870         * aarch32-linux-nat.c: Sort headers.
7871
7872 2019-04-04  Tom Tromey  <tom@tromey.com>
7873
7874         * varobj.c (varobj_create): Update.
7875         * rust-exp.y (struct rust_parser) <update_innermost_block,
7876         lookup_symbol>: New methods.
7877         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7878         Rename.
7879         (rust_parser::rust_lookup_type)
7880         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7881         * printcmd.c (display_command, do_one_display): Update.
7882         * parser-defs.h (struct parser_state) <parser_state>: Add
7883         "tracker" parameter.
7884         (block_tracker): New member.
7885         (class innermost_block_tracker) <innermost_block_tracker>: Add
7886         "types" parameter.
7887         <reset>: Remove method.
7888         (innermost_block): Don't declare.
7889         (null_post_parser): Update.
7890         * parse.c (innermost_block): Remove global.
7891         (write_dollar_variable): Update.
7892         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7893         Remove "tracker_types" parameter.
7894         (parse_expression): Add "tracker" parameter.
7895         (parse_expression_for_completion): Update.
7896         (null_post_parser): Add "tracker" parameter.
7897         * p-exp.y: Update rules.
7898         * m2-exp.y: Update rules.
7899         * language.h (struct language_defn) <la_post_parser>: Add
7900         "tracker" parameter.
7901         * go-exp.y: Update rules.
7902         * f-exp.y: Update rules.
7903         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7904         parameter.
7905         * d-exp.y: Update rules.
7906         * c-exp.y: Update rules.
7907         * breakpoint.c (set_breakpoint_condition): Create an
7908         innermost_block_tracker.
7909         (watch_command_1): Likewise.
7910         * ada-lang.c (resolve): Add "tracker" parameter.
7911         (resolve_subexp): Likewise.
7912         * ada-exp.y (write_var_from_sym): Update.
7913
7914 2019-04-04  Tom Tromey  <tom@tromey.com>
7915
7916         * type-stack.h: New file.
7917         * type-stack.c: New file.
7918         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7919         type-stack.h.
7920         (insert_into_type_stack, insert_type, push_type, push_type_int)
7921         (insert_type_address_space, pop_type, pop_type_int)
7922         (pop_typelist, pop_type_stack, append_type_stack)
7923         (push_type_stack, get_type_stack, push_typelist)
7924         (follow_type_instance_flags, follow_types): Don't declare.
7925         * parse.c (type_stack): Remove global.
7926         (parse_exp_in_context): Update.
7927         (insert_into_type_stack, insert_type, push_type, push_type_int)
7928         (insert_type_address_space, pop_type, pop_type_int)
7929         (pop_typelist, pop_type_stack, append_type_stack)
7930         (push_type_stack, get_type_stack, push_typelist)
7931         (follow_type_instance_flags, follow_types): Remove (moved to
7932         type-stack.c).
7933         * f-exp.y (type_stack): New global.
7934         Update rules.
7935         (push_kind_type, f_parse): Update.
7936         * d-exp.y (type_stack): New global.
7937         Update rules.
7938         (d_parse): Update.
7939         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7940         Update rules.
7941         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7942         (HFILES_NO_SRCDIR): Add type-stack.h.
7943
7944 2019-04-04  Tom Tromey  <tom@tromey.com>
7945
7946         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7947         (rust_parser::convert_ast_to_expression, rust_parse)
7948         (rust_lex_test_completion, rust_lex_tests): Update.
7949         * parser-defs.h (struct expr_completion_state): New.
7950         (struct parser_state) <parser_state>: Add completion parameter.
7951         <mark_struct_expression, mark_completion_tag>: New methods.
7952         <parse_completion, m_completion_state>: New members.
7953         (prefixify_expression, null_post_parser): Update.
7954         (mark_struct_expression, mark_completion_tag): Don't declare.
7955         * parse.c (parse_completion, expout_last_struct)
7956         (expout_tag_completion_type, expout_completion_name): Remove
7957         globals.
7958         (parser_state::mark_struct_expression)
7959         (parser_state::mark_completion_tag): Now methods.
7960         (prefixify_expression): Add last_struct parameter.
7961         (prefixify_subexp): Likewise.
7962         (parse_exp_1): Update.
7963         (parse_exp_in_context): Add cstate parameter.  Update.
7964         (parse_expression_for_completion): Create an
7965         expr_completion_state.
7966         (null_post_parser): Add "completion" parameter.
7967         * p-exp.y: Update rules.
7968         (yylex): Update.
7969         * language.h (struct language_defn) <la_post_parser>: Add
7970         "completing" parameter.
7971         * go-exp.y: Update rules.
7972         (lex_one_token): Update.
7973         * expression.h (parse_completion): Don't declare.
7974         * d-exp.y: Update rules.
7975         (lex_one_token): Update rules.
7976         * c-exp.y: Update rules.
7977         (lex_one_token): Update.
7978         * ada-lang.c (resolve): Add "parse_completion" parameter.
7979         (resolve_subexp): Likewise.
7980         (ada_resolve_function): Likewise.
7981
7982 2019-04-04  Tom Tromey  <tom@tromey.com>
7983
7984         * parser-defs.h (struct parser_state) <start_arglist,
7985         end_arglist>: New methods.
7986         <arglist_len, m_funcall_chain>: New members.
7987         (arglist_len, start_arglist, end_arglist): Don't declare.
7988         * parse.c (arglist_len, funcall_chain): Remove global.
7989         (start_arglist, end_arglist): Remove functions.
7990         (parse_exp_in_context): Update.
7991         * p-exp.y: Update rules.
7992         * m2-exp.y: Update rules.
7993         * go-exp.y: Update rules.
7994         * f-exp.y: Update rules.
7995         * d-exp.y: Update rules.
7996         * c-exp.y: Update rules.
7997
7998 2019-04-04  Tom Tromey  <tom@tromey.com>
7999
8000         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8001         lex_operator, push_back>: New methods.
8002         Update all rules.
8003         (rust_parser::lex_hex, lex_escape): Rename and update.
8004         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8005         (rust_parser::lex_operator): Rename and update.
8006         (rust_parser::lex_number, rustyylex, rustyyerror)
8007         (rust_lex_test_init, rust_lex_test_sequence)
8008         (rust_lex_test_push_back, rust_lex_tests): Update.
8009         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8010         parameter.
8011         <lexptr, prev_lexptr>: New members.
8012         (lexptr, prev_lexptr): Don't declare.
8013         * parse.c (lexptr, prev_lexptr): Remove globals.
8014         (parse_exp_in_context): Update.
8015         * p-exp.y (yylex, yyerror): Update.
8016         * m2-exp.y (parse_number, yylex, yyerror): Update.
8017         * go-exp.y (lex_one_token, yyerror): Update.
8018         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8019         * d-exp.y (lex_one_token, yyerror): Update.
8020         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8021         (lex_one_token, yyerror): Update.
8022         * ada-lex.l (YY_INPUT): Update.
8023         (rewind_to_char): Update.
8024         * ada-exp.y (yyerror): Update.
8025
8026 2019-04-04  Tom Tromey  <tom@tromey.com>
8027
8028         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8029         * parser-defs.h (struct parser_state) <parser_state>: Add new
8030         parameter.
8031         <comma_terminates>: New member.
8032         (comma_terminates): Don't declare global.
8033         * parse.c (comma_terminates): Remove global.
8034         (parse_exp_in_context): Update.
8035         * p-exp.y (yylex): Update.
8036         * m2-exp.y (yylex): Update.
8037         * go-exp.y (lex_one_token): Update.
8038         * f-exp.y (yylex): Update.
8039         * d-exp.y (lex_one_token): Update.
8040         * c-exp.y (lex_one_token): Update.
8041         * ada-lex.l: Update.
8042
8043 2019-04-04  Tom Tromey  <tom@tromey.com>
8044
8045         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8046         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8047         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8048         * parser-defs.h (paren_depth): Don't declare.
8049         * parse.c (paren_depth): Remove global.
8050         (parse_exp_in_context): Update.
8051         * p-exp.y (paren_depth): New global.
8052         (pascal_parse): Initialize it.
8053         * m2-exp.y (paren_depth): New global.
8054         (m2_parse): Initialize it.
8055         * go-exp.y (paren_depth): New global.
8056         (go_parse): Initialize it.
8057         * f-exp.y (paren_depth): New global.
8058         (f_parse): Initialize it.
8059         * d-exp.y (paren_depth): New global.
8060         (d_parse): Initialize it.
8061         * c-exp.y (paren_depth): New global.
8062         (c_parse): Initialize it.
8063         * ada-lex.l (paren_depth): New global.
8064         (lexer_init): Initialize it.
8065
8066 2019-04-04  Tom Tromey  <tom@tromey.com>
8067
8068         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8069         (rust_parser::convert_ast_to_type)
8070         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8071         * parser-defs.h (struct parser_state) <parser_state>: Add
8072         parameters.  Initialize new members.
8073         <expression_context_block, expression_context_pc>: New members.
8074         * parse.c (expression_context_block, expression_context_pc):
8075         Remove globals.
8076         (parse_exp_in_context): Update.
8077         * p-exp.y: Update all rules.
8078         (yylex): Update.
8079         * m2-exp.y: Update all rules.
8080         (yylex): Update.
8081         * go-exp.y (yylex): Update.
8082         * f-exp.y (yylex): Update.
8083         * d-exp.y: Update all rules.
8084         (yylex): Update.
8085         * c-exp.y: Update all rules.
8086         (lex_one_token, classify_name, yylex, c_parse): Update.
8087         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8088
8089 2019-04-04  Tom Tromey  <tom@tromey.com>
8090
8091         * gdbarch.h, gdbarch.c: Rebuild.
8092         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8093         * stap-probe.h:
8094         (struct stap_parse_info): Replace "parser_state" with
8095         "expr_builder".
8096         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8097         (parser_state): New class.
8098         * parse.c (expr_builder): Rename.
8099         (expr_builder::release): Rename.
8100         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8101         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8102         (write_exp_elt_longcst, write_exp_elt_floatcst)
8103         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8104         (write_exp_string_vector, write_exp_bitstring)
8105         (write_exp_msymbol, mark_struct_expression)
8106         (write_dollar_variable)
8107         (insert_type_address_space, increase_expout_size): Replace
8108         "parser_state" with "expr_builder".
8109         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8110         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8111         "parser_state" with "expr_builder".
8112
8113 2019-04-04  Tom Tromey  <tom@tromey.com>
8114
8115         * rust-exp.y: Replace "parse_language" with method call.
8116         * p-exp.y:
8117         (yylex): Replace "parse_language" with method call.
8118         * m2-exp.y:
8119         (yylex): Replace "parse_language" with method call.
8120         * go-exp.y (classify_name): Replace "parse_language" with method
8121         call.
8122         * f-exp.y (yylex): Replace "parse_language" with method call.
8123         * d-exp.y (lex_one_token): Replace "parse_language" with method
8124         call.
8125         * c-exp.y:
8126         (lex_one_token, classify_name, yylex): Replace "parse_language"
8127         with method call.
8128         * ada-exp.y (find_primitive_type, type_char)
8129         (type_system_address): Replace "parse_language" with method call.
8130
8131 2019-04-04  Tom Tromey  <tom@tromey.com>
8132
8133         * rust-exp.y: Replace "parse_gdbarch" with method call.
8134         * parse.c (write_dollar_variable, insert_type_address_space):
8135         Replace "parse_gdbarch" with method call.
8136         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8137         call.
8138         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8139         call.
8140         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8141         "parse_gdbarch" with method call.
8142         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8143         with method call.
8144         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8145         "parse_gdbarch" with method call.
8146         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8147         "parse_gdbarch" with method call.
8148         * c-exp.y (parse_type, parse_number, classify_name): Replace
8149         "parse_gdbarch" with method call.
8150         * ada-lex.l: Replace "parse_gdbarch" with method call.
8151         * ada-exp.y (parse_type, find_primitive_type, type_char)
8152         (type_system_address): Replace "parse_gdbarch" with method call.
8153
8154 2019-04-04  Tom Tromey  <tom@tromey.com>
8155
8156         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8157         * stap-probe.c (stap_parse_argument): Update.
8158         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8159         initial_size parameter.
8160         * rust-exp.y (rust_lex_tests): Update.
8161         * parse.c (parser_state): Update.
8162         (parse_exp_in_context): Update.
8163         * parser-defs.h (struct parser_state) <parser_state>: Remove
8164         "initial_size" parameter.
8165
8166 2019-04-04  Tom Tromey  <tom@tromey.com>
8167
8168         * parser-defs.h (increase_expout_size): Don't declare.
8169         * parse.c (increase_expout_size): Now static.
8170
8171 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8172
8173         * gnu-nat.c (gnu_nat_target::wait): Fix
8174         target_waitstatus_to_string call.
8175
8176 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8177
8178         * eval.c (evaluate_subexp_standard): Handle internal functions
8179         during Fortran function call handling.
8180
8181 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8182
8183         * NEWS: Mention new internal functions.
8184         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8185         (read_base_type): Use dwarf2_init_complex_target_type.
8186         * value.c (creal_internal_fn): New function.
8187         (cimag_internal_fn): New function.
8188         (_initialize_values): Register new internal functions.
8189
8190 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8191
8192         * infrun.c (stop_all_threads): If debug_infrun, always
8193         trace the wait status after wait_one, using
8194         target_waitstatus_to_string and target_pid_to_str.
8195         (handle_inferior_event): Replace various trace of
8196         wait status kind by a single trace.
8197         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8198         wait status kind image by target_waitstatus_to_string.
8199         * target/waitstatus.c (target_waitstatus_to_string): Fix
8200         obsolete comment.
8201
8202 2019-04-01  Tom Tromey  <tromey@adacore.com>
8203
8204         PR symtab/23331:
8205         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8206
8207 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8208             Pedro Alves  <palves@redhat.com>
8209
8210         * top.c (quit_force): Call 'finalize_values'.
8211         * value.c (finalize_values): New function.
8212         * value.h (finalize_values): Declare.
8213
8214 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8215
8216         * NEWS: Announce $_gdb_major and $_gdb_minor.
8217
8218         * top.c (init_gdb_version_vars): New function.
8219         (gdb_init): Call init_gdb_version_vars.
8220
8221 2019-03-29  Tom Tromey  <tromey@adacore.com>
8222
8223         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8224         help text.  Remove dead code.
8225
8226 2019-03-29  Keith Seitz  <keiths@redhat.com>
8227
8228         From Siddhesh Poyarekar:
8229         * f-lang.h (f77_get_upperbound): Return LONGEST.
8230         (f77_get_lowerbound): Likewise.
8231         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8232         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8233         print them.
8234         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8235         plongest to format print it.
8236         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8237         (f77_get_upperbound): Likewise.
8238         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8239         LOWER_BOUND to LONGEST.
8240         (f77_create_arrayprint_offset_tbl): Likewise.
8241
8242 2019-03-29  Keith Seitz  <keiths@redhat.com>
8243
8244         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8245         %s/pulongest for TYPE_LENGTH instead of %d in format
8246         strings.
8247         * ada-typerint.c (ada_print_type): Likewise.
8248         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8249         * compile/compile-c-support.c (generate_register_struct): Likewise.
8250         * gdbtypes.c (recursive_dump_type): Likewise.
8251         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8252         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8253         instead of %d in format strings.
8254         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8255         to std::min to ULONGEST.
8256         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8257         instead of %d in format strings.
8258         * tracepoint.c (info_scope_command): Likewise.
8259         * typeprint.c (print_offset_data::update)
8260         (print_offset_data::finish): Likewise.
8261         * xtensa-tdep.c (xtensa_store_return_value)
8262         (xtensa_push_dummy_call): Likewise.
8263
8264 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8265
8266         * windows-nat.c (display_selector): Fixed format specifications
8267         for 64-bit Cygwin.
8268
8269 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8270
8271         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8272
8273 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8274
8275         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8276         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8277         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8278         (nios2_linux_init_abi): Install it.
8279
8280 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8281
8282         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8283
8284 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8285
8286         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8287
8288 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8289             Tom Tromey  <tromey@adacore.com>
8290
8291         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8292
8293 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8294
8295         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8296         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8297         method to compute the bounds of range types. Also print "[evaluated]"
8298         if the bounds' values come from a dynamic evaluation.
8299
8300 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8303         whitespace when pretty printing is on.
8304
8305 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8306
8307         * ppc-linux-nat.c: Add include.
8308
8309 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8310
8311         * NEWS: Mention AArch64 Pointer Authentication.
8312
8313 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8314
8315         * arm-linux-nat.c: Add include.
8316
8317 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8318
8319         * source-cache.c (source_cache::get_source_lines): Re-read
8320         fullname after calling open_source_file.
8321
8322 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8323
8324         * NEWS: Mention TLS support for FreeBSD.
8325
8326 2019-03-25  Tom Tromey  <tromey@adacore.com>
8327
8328         * minsyms.c (BUNCH_SIZE): Update comment.
8329         (~minimal_symbol_reader): Remove old comment.
8330         (compact_minimal_symbols): Update comment.
8331         (minimal_symbol_reader::install): Remove old comment.  Update
8332         other comments.
8333
8334 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8335
8336         * s390-linux-nat.c: Add include.
8337
8338 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8339
8340         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8341         Call linux_get_hwcap.
8342         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8343         Likewise.
8344         (aarch64_linux_get_hwcap): Remove function.
8345         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8346         declaration.
8347         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8348         linux_get_hwcap.
8349         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8350         * linux-tdep.c (linux_get_hwcap): Add function.
8351         (linux_get_hwcap2): Likewise.
8352         * linux-tdep.h (linux_get_hwcap): Add declaration.
8353         (linux_get_hwcap2): Likewise.
8354         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8355         (ppc_linux_get_hwcap2): Likewise.
8356         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8357         linux_get_hwcap.
8358         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8359         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8360         (ppc_linux_nat_target::read_description): Likewise.
8361         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8362         * s390-linux-nat.c: Likewise.
8363         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8364
8365 2019-03-24  Tom Tromey  <tom@tromey.com>
8366
8367         * ada-lang.c (standard_lookup): Simplify initialization.
8368         (ada_lookup_symbol_nonlocal): Simplify return.
8369         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8370         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8371         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8372         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8373         initialization.
8374         * solib.c (solib_global_lookup): Simplify.
8375         * symtab.c (null_block_symbol): Remove.
8376         (symbol_cache_lookup): Simplify returns.
8377         (lookup_language_this): Simplify returns.
8378         (lookup_symbol_aux): Simplify return.
8379         (lookup_local_symbol): Simplify returns.
8380         (lookup_global_symbol_from_objfile): Simplify return.
8381         (lookup_symbol_in_objfile_symtabs)
8382         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8383         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8384         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8385         * cp-namespace.c (cp_lookup_bare_symbol)
8386         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8387         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8388         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8389         (cp_lookup_symbol_via_imports): Simplify initialization.
8390         (find_symbol_in_baseclass): Likewise.
8391         * symtab.h (null_block_symbol): Remove.
8392         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8393         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8394         (d_lookup_symbol_module): Likewise.
8395         (find_symbol_in_baseclass): Simplify initialization.
8396
8397 2019-03-24  Tom Tromey  <tom@tromey.com>
8398
8399         * expression.h: Don't include symtab.h.
8400         (struct block): Forward declare.
8401
8402 2019-03-24  Tom Tromey  <tom@tromey.com>
8403
8404         * c-exp.y (typebase): Remove casts.
8405         * gdbtypes.c (lookup_unsigned_typename, )
8406         (lookup_signed_typename): Remove cast.
8407         * eval.c (parse_to_comma_and_eval): Remove cast.
8408         * parse.c (write_dollar_variable): Remove cast.
8409         * block.h (struct block) <superblock>: Now const.
8410         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8411         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8412         (map_block): Make "block" const.
8413         * symfile.h (struct quick_symbol_functions)
8414         <map_matching_symbols>: Constify block argument to "callback".
8415         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8416         const.
8417         (find_pc_sect_compunit_symtab): Make "b" const.
8418         (find_symbol_at_address): Likewise.
8419         (search_symbols): Likewise.
8420         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8421         (dw2_debug_names_lookup_symbol): Likewise.
8422         (dw2_map_matching_symbols): Update.
8423         * p-valprint.c (pascal_val_print): Remove "block".
8424         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8425         (aux_add_nonlocal_symbols): Make "block" const.
8426         (resolve_subexp): Remove cast.
8427         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8428         const.
8429         (iterate_over_file_blocks): Likewise.
8430         * f-exp.y (%union) <bval>: Remove.
8431         * coffread.c (patch_opaque_types): Make "b" const.
8432         * spu-tdep.c (spu_catch_start): Make "block" const.
8433         * c-valprint.c (print_unpacked_pointer): Remove "block".
8434         * symmisc.c (dump_symtab_1): Make "b" const.
8435         (block_depth): Make "block" const.
8436         * d-exp.y (%union) <bval>: Remove.
8437         * cp-support.h (cp_lookup_rtti_type): Update.
8438         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8439         * psymtab.c (psym_lookup_symbol): Make "block" const.
8440         (maintenance_check_psymtabs): Make "b" const.
8441         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8442         (enumerate_locals, enumerate_args): Update.
8443         * python/py-symtab.c (stpy_global_block): Make "block" const.
8444         (stpy_static_block): Likewise.
8445         * inline-frame.c (block_starting_point_at): Make "new_block"
8446         const.
8447         * block.c (find_block_in_blockvector): Make return type const.
8448         (blockvector_for_pc_sect): Make "b" const.
8449         (find_block_in_blockvector): Make "b" const.
8450
8451 2019-03-23  Tom Tromey  <tom@tromey.com>
8452
8453         * varobj.c (varobj_create): Update.
8454         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8455         * printcmd.c (display_command, do_one_display): Don't reset
8456         innermost_block.
8457         * parser-defs.h (enum innermost_block_tracker_type): Move to
8458         expression.h.
8459         (innermost_block): Update comment.
8460         * parse.c (parse_exp_1): Add tracker_types parameter.
8461         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8462         tracker_types parameter.  Reset innermost_block.
8463         (parse_exp_in_context): Remove.
8464         (parse_expression_for_completion): Update.
8465         * objfiles.c (~objfile): Don't reset expression_context_block or
8466         innermost_block.
8467         * expression.h (enum innermost_block_tracker_type): Move from
8468         parser-defs.h.
8469         (parse_exp_1): Add tracker_types parameter.
8470         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8471         reset innermost_block.
8472
8473 2019-03-23  Tom Tromey  <tom@tromey.com>
8474
8475         * objfiles.h: Include bcache.h.
8476
8477 2019-03-23  Tom Tromey  <tom@tromey.com>
8478
8479         * linespec.c (get_current_search_block): Use
8480         scoped_restore_current_language.
8481         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8482
8483 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8484             Jiong Wang  <jiong.wang@arm.com>
8485
8486         * aarch64-linux-tdep.c
8487         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8488         section.
8489         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8490
8491 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8492             Jiong Wang  <jiong.wang@arm.com>
8493
8494         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8495         instructions.
8496         (aarch64_analyze_prologue_test): Add PACIASP test.
8497         (aarch64_prologue_prev_register): Unmask PC value.
8498
8499 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8500             Jiong Wang  <jiong.wang@arm.com>
8501
8502         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8503         (aarch64_dwarf2_prev_register): Unmask PC value.
8504         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8505         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8506         DW_CFA_AARCH64_negate_ra_state.
8507         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8508
8509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8510             Jiong Wang  <jiong.wang@arm.com>
8511
8512         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8513         registers.
8514         (aarch64_pseudo_register_name): Likewise.
8515         (aarch64_pseudo_register_type): Likewise.
8516         (aarch64_pseudo_register_reggroup_p): Likewise.
8517         (aarch64_gdbarch_init): Add pauth registers.
8518         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8519         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8520         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8521         (struct gdbarch_tdep): Add regnum for ra_state.
8522
8523 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8524             Jiong Wang  <jiong.wang@arm.com>
8525
8526         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8527
8528 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8529             Jiong Wang  <jiong.wang@arm.com>
8530
8531         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8532         function.
8533         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8534         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8535         (aarch64_gdbarch_init): Add puth registers.
8536         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8537         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8538         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8539
8540 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8541             Jiong Wang  <jiong.wang@arm.com>
8542
8543         * aarch64-linux-nat.c
8544         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8545         * aarch64-linux-tdep.c
8546         (aarch64_linux_core_read_description): Likewise.
8547         (aarch64_linux_get_hwcap): New function.
8548         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8549         (aarch64_linux_get_hwcap): New declaration.
8550
8551 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8552             Jiong Wang  <jiong.wang@arm.com>
8553
8554         * aarch64-linux-nat.c
8555         (aarch64_linux_nat_target::read_description): Add pauth param.
8556         * aarch64-linux-tdep.c
8557         (aarch64_linux_core_read_description): Likewise.
8558         * aarch64-tdep.c (struct target_desc): Add in pauth.
8559         (aarch64_read_description): Add pauth param.
8560         (aarch64_gdbarch_init): Likewise.
8561         * aarch64-tdep.h (aarch64_read_description): Likewise.
8562         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8563         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8564         * features/Makefile: Add new files.
8565         * features/aarch64-pauth.c: New file.
8566         * features/aarch64-pauth.xml: New file.
8567
8568 2019-03-20  Tom Tromey  <tromey@adacore.com>
8569
8570         * infrun.c (handle_inferior_event): Rename from
8571         handle_inferior_event_1.  Create a scoped_value_mark.
8572         (handle_inferior_event): Remove.
8573
8574 2019-03-19  Tom Tromey  <tromey@adacore.com>
8575
8576         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8577         * infrun.h (print_stop_event): Add "displays" parameter.
8578         * infrun.c (print_stop_event): Add "displays" parameter.
8579
8580 2019-03-19  Pedro Alves  <palves@redhat.com>
8581
8582         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8583         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8584         to -1.  Fix TABs vs spaces.
8585         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8586         * tui/tui-out.h (tui_ui_out) Add intro comments.
8587         <m_line, m_start_of_line>: In-class initialize, and add describing
8588         comment.
8589
8590 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8591
8592         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8593         variable names.
8594         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8595
8596 2019-03-18  Pedro Alves  <palves@redhat.com>
8597             Eli Zaretskii <eliz@gnu.org>
8598
8599         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8600         m_line and m_start_of_line.
8601
8602 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8603
8604         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8605         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8606         it returns a newline.  This fixes a regression in TU mode, whereby
8607         the next line is output on the same screen line as the user input.
8608
8609 2019-03-18  Tom Tromey  <tromey@adacore.com>
8610
8611         * minsyms.c (minimal_symbol_reader::install): Remove call to
8612         obstack_blank.
8613
8614 2019-03-18  Pedro Alves  <palves@redhat.com>
8615
8616         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8617         New globals.
8618         (apply_style): New, factored out from ...
8619         (apply_ansi_escape): ... this.  Handle reverse video mode.
8620         (tui_set_reverse_mode): New function.
8621         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8622         * tui/tui-winsource.c (tui_show_source_line): Use
8623         tui_set_reverse_mode instead of setting A_STANDOUT.
8624         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8625         New setter methods.
8626
8627 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8628
8629         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8630         Handle tabs.
8631
8632 2019-03-18  Tom Tromey  <tromey@adacore.com>
8633
8634         * ada-lang.c (empty_array): Add "high" parameter.
8635         (ada_evaluate_subexp): Update.
8636
8637 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8638
8639         * unittests/string_view-selftests.c: Define
8640         _initialize_string_view_selftests unconditionally.
8641
8642 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8643
8644         PR gdb/24350
8645         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8646
8647 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8648
8649         PR gdb/24351
8650         * windows-nat.c (display_selector): Fix format specifiers.
8651
8652 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8653
8654         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8655         tui_refill_source_window instead of tui_refresh_win, to update the
8656         current execution line.  This fixes redisplay of the current line
8657         when stepping through the code with "next" or "step".
8658
8659 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8660
8661         * source-cache.c (source_cache::get_source_lines): Call
8662         find_source_lines to initialize s->nlines.  This fixes vertical
8663         scrolling of TUI source window when the DOWN arrow is pressed.
8664
8665 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8666
8667         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8668         linux-thread-db.c (_initialize_thread_db): Likewise.
8669
8670 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8671
8672         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8673         wclrtoeol in tui_show_source_line".  This reverts changes made in
8674         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8675
8676 2019-03-15  Tom Tromey  <tom@tromey.com>
8677
8678         * symtab.h (struct minimal_symbol): Derive from
8679         general_symbol_info.
8680         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8681         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8682         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8683         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8684         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8685         (MSYMBOL_SEARCH_NAME): Update.
8686         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8687         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8688         * minsyms.c (minimal_symbol_reader::record_full): Update.
8689
8690 2019-03-15  Tom Tromey  <tom@tromey.com>
8691
8692         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8693
8694 2019-03-15  Tom Tromey  <tom@tromey.com>
8695
8696         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8697         unique_xmalloc_ptr.
8698         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8699         Update.
8700         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8701         (build_minimal_symbol_hash_tables)
8702         (minimal_symbol_reader::install): Update.
8703
8704 2019-03-15  Tom Tromey  <tom@tromey.com>
8705
8706         * symtab.c (create_demangled_names_hash): Update.
8707         (symbol_set_names): Update.
8708         * objfiles.h (struct objfile_per_bfd_storage)
8709         <demangled_names_hash>: Now an htab_up.
8710         * objfiles.c (objfile_per_bfd_storage): Simplify.
8711
8712 2019-03-15  Tom Tromey  <tom@tromey.com>
8713
8714         * objfiles.h (struct objfile_per_bfd_storage): Declare
8715         destructor.
8716         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8717         New.
8718         (get_objfile_bfd_data): Use new.  Don't initialize
8719         language_of_main.
8720         (free_objfile_per_bfd_storage): Remove.
8721         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8722
8723 2019-03-15  Tom Tromey  <tom@tromey.com>
8724
8725         * symfile.c (reread_symbols): Update.
8726         * objfiles.c (objfile::objfile): Update.
8727         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8728         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8729         comment.
8730         (minimal_symbol_reader::install): Update.
8731         (terminate_minimal_symbol_table): Remove.
8732         * jit.c (jit_object_close_impl): Update.
8733
8734 2019-03-15  Tom Tromey  <tom@tromey.com>
8735
8736         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8737         initializations.
8738
8739 2019-03-15  Tom Tromey  <tom@tromey.com>
8740
8741         * objfiles.h (struct objfile_per_bfd_storage)
8742         <demangled_hash_languages>: Now a bitset.
8743         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8744         (lookup_minimal_symbol): Update.
8745
8746 2019-03-15  Tom Tromey  <tom@tromey.com>
8747
8748         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8749         Don't return the symbol.
8750         * coffread.c (record_minimal_symbol): Use record_full.
8751
8752 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8753
8754         The MS-Windows port of ncurses fails to switch to a color pair if
8755         one or both of the colors are the implicit default colors.  This
8756         change records the default colors when TUI is initialized, and
8757         then specifies them explicitly when a color pair uses the default
8758         colors.  This allows color styling in TUI mode on MS-Windows.
8759
8760         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8761         ncurses_norm_attr.
8762         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8763         colors in ncurses_norm_attr.
8764         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8765         "none", replace it with the default color recorded in
8766         ncurses_norm_attr.
8767
8768 2019-03-14  Tom Tromey  <tromey@adacore.com>
8769
8770         * source-cache.h (class source_cache) <get_source_lines>: Return
8771         std::string.
8772         * source-cache.c (source_cache::extract_lines): Handle case where
8773         first_pos==npos.  Return std::string.
8774         (source_cache::get_source_lines): Update.
8775
8776 2019-03-14  Tom Tromey  <tromey@adacore.com>
8777
8778         * NEWS: Add item for "style sources" commands.
8779         * source-cache.c (source_cache::get_source_lines): Check
8780         source_styling.
8781         * cli/cli-style.c (source_styling): New global.
8782         (_initialize_cli_style): Add "style sources" commands.
8783         (show_style_sources): New function.
8784         * cli/cli-style.h (source_styling): Declare.
8785
8786 2019-03-14  Pedro Alves  <palves@redhat.com>
8787             Tom Tromey  <tromey@adacore.com>
8788
8789         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8790         * tui/tui-winsource.c (tui_refill_source_window): New function,
8791         from...
8792         (tui_horizontal_source_scroll): ... here.  Move some logic.
8793         * cli/cli-style.c (set_style_enabled): Notify new observable.
8794         * tui/tui-hooks.c (tui_redisplay_source): New function.
8795         (tui_attach_detach_observers): Attach or detach
8796         tui_redisplay_source.
8797         * observable.h (source_styling_changed): New observable.
8798         * observable.c: Define source_styling_changed observable.
8799
8800 2019-03-13  Tom Tromey  <tromey@adacore.com>
8801
8802         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8803         (i386_gnu_nat_target::store_registers): Update.
8804         * target-debug.h (target_debug_print_std_string): New macro.
8805         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8806         * windows-tdep.c (display_one_tib): Update.
8807         * tui/tui-stack.c (tui_make_status_line): Update.
8808         * top.c (print_inferior_quit_action): Update.
8809         * thread.c (thr_try_catch_cmd): Update.
8810         (add_thread_with_info): Update.
8811         (thread_target_id_str): Update.
8812         (thr_try_catch_cmd): Update.
8813         (thread_command): Update.
8814         (thread_find_command): Update.
8815         * record-btrace.c (record_btrace_target::info_record)
8816         (record_btrace_resume_thread, record_btrace_target::resume)
8817         (record_btrace_cancel_resume, record_btrace_step_thread)
8818         (record_btrace_target::wait, record_btrace_target::wait)
8819         (record_btrace_target::wait, record_btrace_target::stop): Update.
8820         * progspace.c (print_program_space): Update.
8821         * process-stratum-target.c
8822         (process_stratum_target::thread_address_space): Update.
8823         * linux-fork.c (linux_fork_mourn_inferior)
8824         (detach_checkpoint_command, info_checkpoints_command)
8825         (linux_fork_context): Update.
8826         (linux_fork_detach): Update.
8827         (class scoped_switch_fork_info): Update.
8828         (delete_checkpoint_command): Update.
8829         * infrun.c (follow_fork_inferior): Update.
8830         (follow_fork_inferior): Update.
8831         (proceed_after_vfork_done): Update.
8832         (handle_vfork_child_exec_or_exit): Update.
8833         (follow_exec): Update.
8834         (displaced_step_prepare_throw): Update.
8835         (displaced_step_restore): Update.
8836         (start_step_over): Update.
8837         (resume_1): Update.
8838         (clear_proceed_status_thread): Update.
8839         (proceed): Update.
8840         (print_target_wait_results): Update.
8841         (do_target_wait): Update.
8842         (context_switch): Update.
8843         (stop_all_threads): Update.
8844         (restart_threads): Update.
8845         (finish_step_over): Update.
8846         (handle_signal_stop): Update.
8847         (switch_back_to_stepped_thread): Update.
8848         (keep_going_pass_signal): Update.
8849         (print_exited_reason): Update.
8850         (normal_stop): Update.
8851         * inferior.c (inferior_pid_to_str): Change return type.
8852         (print_selected_inferior): Update.
8853         (add_inferior): Update.
8854         (detach_inferior): Update.
8855         * dummy-frame.c (fprint_dummy_frames): Update.
8856         * dcache.c (dcache_info_1): Update.
8857         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8858         (btrace_fetch, btrace_clear): Update.
8859         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8860         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8861         type.
8862         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8863         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8864         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8865         * gdbarch.c, gdbarch.h: Rebuild.
8866         * gdbarch.sh (core_pid_to_str): Change return type.
8867         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8868         return type.
8869         (windows_nat_target::pid_to_str): Change return type.
8870         (windows_delete_thread): Update.
8871         (windows_nat_target::attach): Update.
8872         (windows_nat_target::files_info): Update.
8873         * target-delegates.c: Rebuild.
8874         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8875         return type.
8876         (sol_thread_target::pid_to_str): Change return type.
8877         * remote.c (class remote_target) <pid_to_str>: Change return
8878         type.
8879         (remote_target::pid_to_str): Change return type.
8880         (extended_remote_target::attach, remote_target::remote_stop_ns)
8881         (remote_target::remote_notif_remove_queued_reply)
8882         (remote_target::push_stop_reply, remote_target::disable_btrace):
8883         Update.
8884         (extended_remote_target::attach): Update.
8885         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8886         type.
8887         (gdbsim_target::pid_to_str): Change return type.
8888         * ravenscar-thread.c (struct ravenscar_thread_target)
8889         <pid_to_str>: Change return type.
8890         (ravenscar_thread_target::pid_to_str): Change return type.
8891         * procfs.c (class procfs_target) <pid_to_str>: Change return
8892         type.
8893         (procfs_target::pid_to_str): Change return type.
8894         (procfs_target::attach): Update.
8895         (procfs_target::detach): Update.
8896         (procfs_target::fetch_registers): Update.
8897         (procfs_target::store_registers): Update.
8898         (procfs_target::wait): Update.
8899         (procfs_target::files_info): Update.
8900         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8901         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8902         return type.
8903         (nto_procfs_target::pid_to_str): Change return type.
8904         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8905         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8906         return type.
8907         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8908         (exit_lwp): Update.
8909         (attach_proc_task_lwp_callback, get_detach_signal)
8910         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8911         (linux_nat_target::resume, wait_lwp, stop_callback)
8912         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8913         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8914         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8915         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8916         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8917         type.
8918         (inf_ptrace_target::attach): Update.
8919         (inf_ptrace_target::files_info): Update.
8920         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8921         type.
8922         (go32_nat_target::pid_to_str): Change return type.
8923         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8924         (gnu_nat_target::wait): Update.
8925         (gnu_nat_target::wait): Update.
8926         (gnu_nat_target::resume): Update.
8927         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8928         (fbsd_nat_target::wait): Update.
8929         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8930         type.
8931         (darwin_nat_target::attach): Update.
8932         * corelow.c (class core_target) <pid_to_str>: Change return type.
8933         (core_target::pid_to_str): Change return type.
8934         * target.c (normal_pid_to_str): Change return type.
8935         (default_pid_to_str): Likewise.
8936         (target_pid_to_str): Change return type.
8937         (target_translate_tls_address): Update.
8938         (target_announce_detach): Update.
8939         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8940         return type.
8941         (bsd_uthread_target::pid_to_str): Change return type.
8942         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8943         type.
8944         (bsd_kvm_target::pid_to_str): Change return type.
8945         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8946         return type.
8947         (aix_thread_target::pid_to_str): Change return type.
8948         * target.h (struct target_ops) <pid_to_str>: Change return type.
8949         (target_pid_to_str, normal_pid_to_str): Likewise.
8950         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8951         type.
8952         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8953         type.
8954         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8955         return type.
8956         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8957         type.
8958         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8959         type.
8960         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8961         return type.
8962
8963 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8964
8965         * NEWS: Mention that the new default MI version is 3.  Mention
8966         changes to the output of commands and events that deal with
8967         multi-location breakpoints.
8968         * breakpoint.c: Include "mi/mi-out.h".
8969         (print_one_breakpoint): Change output syntax if using MI version
8970         >= 3.
8971         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8972         New.
8973         (mi_multi_location_breakpoint_output_fixed): New.
8974         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8975         (mi_cmd_fix_multi_location_breakpoint_output): New.
8976         (mi_multi_location_breakpoint_output_fixed): New.
8977         * mi/mi-cmds.c (mi_cmds): Register command
8978         -fix-multi-location-breakpoint-output.
8979         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8980         interpreter "mi".
8981
8982 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8983
8984         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8985         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8986         instantiate mi_ui_out based on interpreter name.
8987         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8988         * mi/mi-main.c (mi_load_progress): Likewise.
8989
8990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8991
8992         * NEWS: Combine separate "New targets" sections for 8.3.
8993
8994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8995
8996         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8997         (ppcfbsd_init_abi): Install gdbarch
8998         "fetch_tls_load_module_address" and "get_thread_local_address"
8999         methods.
9000
9001 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9002
9003         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9004         (riscv_fbsd_init_abi): Install gdbarch
9005         "fetch_tls_load_module_address" and "get_thread_local_address"
9006         methods.
9007
9008 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9009
9010         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9011         (i386fbsd_init_abi): Install gdbarch
9012         "fetch_tls_load_module_address" and "get_thread_local_address"
9013         methods.
9014
9015 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9016
9017         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9018         (amd64fbsd_init_abi): Install gdbarch
9019         "fetch_tls_load_module_address" and "get_thread_local_address"
9020         methods.
9021
9022 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9023
9024         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9025         (struct fbsd_pspace_data): New type.
9026         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9027         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9028         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9029         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9030         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9031
9032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9033
9034         * gdbtypes.c (lookup_struct_elt): New function.
9035         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9036         * gdbtypes.h (struct struct_elt): New type.
9037         (lookup_struct_elt): New prototype.
9038
9039 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9040
9041         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9042         remove disabled code block.
9043
9044 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9045
9046         * gdbarch.sh (get_thread_local_address): New method.
9047         * gdbarch.h, gdbarch.c: Regenerate.
9048         * target.c (target_translate_tls_address): Use
9049         gdbarch_get_thread_local_address if present instead of
9050         target::get_thread_local_address.
9051
9052 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9053
9054         * target.h (target::get_thread_local_address): Update comment.
9055
9056 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9057
9058         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9059         objfile->separate_debug_objfile_backlink if not NULL.
9060
9061 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9062
9063         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9064         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9065         (amd64bsd_store_inferior_registers): Likewise.
9066         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9067         Enable segment base registers.
9068         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9069         PT_GETFSBASE and PT_GETGSBASE.
9070         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9071         PT_SETGSBASE.
9072         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9073         segment base registers.
9074         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9075
9076 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9077
9078         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9079         Update calls to i386_target_description to add 'segments'
9080         parameter.
9081         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9082         add segment base registers.
9083         * arch/i386.c (i386_create_target_description): Add 'segments'
9084         parameter to enable segment base registers.
9085         * arch/i386.h (i386_create_target_description): Likewise.
9086         * features/i386/32bit-segments.xml: New file.
9087         * features/i386/32bit-segments.c: Generate.
9088         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9089         call to i386_target_description to add 'segments' parameter.
9090         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9091         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9092         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9093         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9094         if feature is present.
9095         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9096         Add 'segments' parameter to call to i386_target_description.
9097         (i386_target_description): Add 'segments' parameter to enable
9098         segment base registers.
9099         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9100         to call to i386_target_description.
9101         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9102         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9103         Define I386_NUM_REGS.
9104         (i386_target_description): Add 'segments' parameter to enable
9105         segment base registers.
9106
9107 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9108
9109         PR/24325
9110         * source-cache.c: #undef open and close, to avoid unresolved
9111         externals during linking.
9112
9113 2019-03-12  Tom Tromey  <tromey@adacore.com>
9114
9115         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9116         const.  Add initializers.
9117         (_initialize_remote): Don't initialize ptid globals.
9118
9119 2019-03-12  Pedro Alves  <palves@redhat.com>
9120
9121         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9122
9123 2019-03-12  Pedro Alves  <palves@redhat.com>
9124
9125         * cp-name-parser.y (main): Remove unused 'len' variable.
9126
9127 2019-03-12  Tom Tromey  <tromey@adacore.com>
9128
9129         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9130         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9131
9132 2019-03-12  Tom Tromey  <tromey@adacore.com>
9133
9134         * linux-nat.c (iterate_over_lwps): Update.
9135         (stop_callback): Remove parameter.
9136         (stop_wait_callback, detach_callback, resume_set_callback)
9137         (select_singlestep_lwp_callback, set_ignore_sigint)
9138         (status_callback, resumed_callback, resume_clear_callback)
9139         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9140         data parameter.
9141         (linux_nat_target::detach, linux_nat_target::resume)
9142         (linux_stop_and_wait_all_lwps, select_event_lwp)
9143         (linux_nat_filter_event, linux_nat_wait_1)
9144         (linux_nat_target::kill, linux_nat_target::stop)
9145         (linux_nat_target::stop): Update.
9146         (linux_nat_resume_callback): Change type.
9147         (resume_stopped_resumed_lwps, count_events_callback)
9148         (select_event_lwp_callback): Likewise.
9149         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9150         * arm-linux-nat.c (struct update_registers_data): Remove.
9151         (update_registers_callback): Change type.
9152         (arm_linux_insert_hw_breakpoint1): Update.
9153         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9154         parameter.
9155         (x86_linux_dr_set_addr): Update.
9156         (x86_linux_dr_set_control): Update.
9157         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9158         (iterate_over_lwps): Use gdb::function_view.
9159         * nat/aarch64-linux-hw-point.c (struct
9160         aarch64_dr_update_callback_param): Remove.
9161         (debug_reg_change_callback): Change type.
9162         (aarch64_notify_debug_reg_change): Update.
9163         * s390-linux-nat.c (s390_refresh_per_info): Update.
9164
9165 2019-03-11  Tom Tromey  <tromey@adacore.com>
9166
9167         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9168         redundant assignment to "this_cu".
9169
9170 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9171
9172         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9173
9174 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9175
9176         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9177         from...
9178         (rank_one_type): ... this.
9179
9180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9181
9182         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9183         from...
9184         (rank_one_type): ... this.
9185
9186 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9187
9188         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9189         from...
9190         (rank_one_type): ... this.
9191
9192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9193
9194         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9195         from...
9196         (rank_one_type): ... this.
9197
9198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9199
9200         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9201         from...
9202         (rank_one_type): ... this.
9203
9204 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9205
9206         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9207         from...
9208         (rank_one_type): ... this.
9209
9210 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9211
9212         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9213         from...
9214         (rank_one_type): ... this.
9215
9216 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9217
9218         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9219         from...
9220         (rank_one_type): ... this.
9221
9222 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9223
9224         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9225         from...
9226         (rank_one_type): ... this.
9227
9228 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9229
9230         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9231         from...
9232         (rank_one_type): ... this.
9233
9234 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9235
9236         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9237         from...
9238         (rank_one_type): ... this.
9239
9240 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9241
9242         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9243         from...
9244         (rank_one_type): ... this.
9245
9246 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9247
9248         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9249         inferior-events' shows the example events.
9250
9251 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9252
9253         Support styling on native MS-Windows console
9254
9255         PR/24315
9256         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9257         on MS-Windows if $TERM is not defined.
9258
9259         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9260
9261         * posix-hdep.c (gdb_console_fputs):
9262         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9263         functions.
9264         * ui-file.h (gdb_console_fputs): Add prototype.
9265
9266         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9267         back to fputs only if the former returns zero.
9268
9269 2019-03-07  Tom Tromey  <tom@tromey.com>
9270
9271         * symmisc.c (print_symbol_bcache_statistics): Update.
9272         (print_objfile_statistics): Update.
9273         * symfile.c (allocate_symtab): Update.
9274         * stabsread.c: Don't include bcache.h.
9275         * psymtab.h (struct psymbol_bcache): Don't declare.
9276         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9277         (psymbol_bcache_init, psymbol_bcache_free)
9278         (psymbol_bcache_get_bcache): Don't declare.
9279         * psymtab.c (struct psymbol_bcache): Remove.
9280         (psymtab_storage::psymtab_storage): Update.
9281         (psymtab_storage::~psymtab_storage): Update.
9282         (psymbol_bcache_init, psymbol_bcache_free)
9283         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9284         (add_psymbol_to_bcache): Update.
9285         (allocate_psymtab): Update.
9286         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9287         macro_cache>: No longer pointers.
9288         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9289         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9290         * macrotab.c (macro_bcache): Update.
9291         * macroexp.c: Don't include bcache.h.
9292         * gdbtypes.c (check_types_worklist): Update.
9293         (types_deeply_equal): Remove TRY/CATCH.  Update.
9294         * elfread.c (elf_symtab_read): Update.
9295         * dwarf2read.c: Don't include bcache.h.
9296         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9297         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9298         (print_bcache_statistics, bcache_memory_used): Don't declare.
9299         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9300         methods.  Rename all data members.
9301         * bcache.c (struct bcache): Move to bcache.h.
9302         (bcache::expand_hash_table): Rename from expand_hash_table.
9303         (bcache): Remove.
9304         (bcache::insert): Rename from bcache_full.
9305         (bcache::compare): Rename from bcache_compare.
9306         (bcache_xmalloc): Remove.
9307         (bcache::~bcache): Rename from bcache_xfree.
9308         (bcache::print_statistics): Rename from print_bcache_statistics.
9309         (bcache::memory_used): Rename from bcache_memory_used.
9310
9311 2019-03-07  Pedro Alves  <palves@redhat.com>
9312
9313         * infrun.c (normal_stop): Also check for
9314         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9315
9316 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9317
9318         * f-lang.c (value_from_host_double): Moved to...
9319         * value.c (value_from_host_double): ...here.
9320         * value.h (value_from_host_double): Declare.
9321         * guile/scm-math.c (vlscm_convert_typed_number): Use
9322         value_from_host_double.
9323         (vlscm_convert_number): Likewise.
9324         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9325         * python/py-value.c (convert_value_from_python): Likewise.
9326
9327 2019-03-06  Tom Tromey  <tom@tromey.com>
9328
9329         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9330
9331 2019-03-06  Tom Tromey  <tom@tromey.com>
9332
9333         * utils.h (free_current_contents): Don't declare.
9334         * utils.c (free_current_contents): Remove.
9335
9336 2019-03-06  Tom Tromey  <tom@tromey.com>
9337
9338         * top.c (quit_force): Update.
9339         * main.c (captured_command_loop): Update.
9340         * common/new-op.c (operator new): Update.
9341         * common/common-exceptions.c (struct catcher)
9342         <save_cleanup_chain>: Remove member.
9343         (exceptions_state_mc_init): Update.
9344         (exception_try_scope_entry): Return nullptr.
9345         (exception_try_scope_exit, exception_rethrow)
9346         (throw_exception_sjlj, throw_exception_cxx): Update.
9347         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9348         (all_cleanups, do_cleanups, discard_cleanups)
9349         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9350         (restore_cleanups, restore_final_cleanups): Don't declare.
9351         (do_final_cleanups): Remove parameter.
9352         * common/cleanups.c (cleanup_chain, make_cleanup)
9353         (make_cleanup_dtor, all_cleanups, do_cleanups)
9354         (discard_my_cleanups, discard_cleanups)
9355         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9356         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9357         (null_cleanup): Remove.
9358         (do_final_cleanups): Remove parameter.
9359
9360 2019-03-06  Tom Tromey  <tom@tromey.com>
9361
9362         * remote.c (remote_target::remote_parse_stop_reply): Use
9363         unique_xmalloc_ptr.
9364
9365 2019-03-06  Tom Tromey  <tom@tromey.com>
9366
9367         * stabsread.c (struct stabs_field_info): Rename from field_info.
9368         <list, fnlist>: Add initializers.
9369         <obstack>: New member.
9370         (read_member_functions, read_struct_fields, read_baseclasses):
9371         Allocate on obstack.  Don't use cleanups.
9372         (read_one_struct_field, read_member_functions, read_struct_fields)
9373         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9374         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9375         (read_struct_type): Update.
9376
9377 2019-03-06  Tom Tromey  <tom@tromey.com>
9378
9379         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9380         * common/filestuff.h (make_cleanup_close): Don't declare.
9381         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9382         Remove.
9383
9384 2019-03-06  Tom Tromey  <tom@tromey.com>
9385
9386         * solib-aix.c: Use make_scope_exit.
9387
9388 2019-03-06  Tom Tromey  <tom@tromey.com>
9389
9390         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9391         Use make_scope_exit.
9392
9393 2019-03-06  Tom Tromey  <tom@tromey.com>
9394
9395         * solib-svr4.c (disable_probes_interface): Remove parameter.
9396         (svr4_handle_solib_event): Use make_scope_exit.
9397
9398 2019-03-06  Tom Tromey  <tom@tromey.com>
9399
9400         * remote.c (struct stop_reply_deleter): Remove.
9401         (stop_reply_up): Update.
9402         (struct stop_reply): Derive from notif_event.  Don't typedef.
9403         <regcache>: Now a std::vector.
9404         (stop_reply_xfree): Remove.
9405         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9406         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9407         (remote_target::discard_pending_stop_replies): Use delete.
9408         (remote_target::remote_parse_stop_reply): Update.
9409         (remote_target::process_stop_reply): Update.
9410         * remote-notif.h (struct notif_event): Add virtual destructor.
9411         Remove "dtr" member.
9412         (struct notif_client) <alloc_event>: Return a unique_ptr.
9413         (notif_event_xfree): Don't declare.
9414         (notif_event_up): New typedef.
9415         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9416         (notif_event_xfree, do_notif_event_xfree): Remove.
9417         (remote_notif_state_xfree): Update.
9418
9419 2019-03-06  Tom Tromey  <tom@tromey.com>
9420
9421         * infrun.c (displaced_step_clear_cleanup): Now a
9422         forward_scope_exit type.
9423         (displaced_step_prepare_throw): Update.
9424         (displaced_step_fixup): Update.
9425
9426 2019-03-06  Tom Tromey  <tom@tromey.com>
9427
9428         * inferior.h (class inferior): Update comment.
9429         * gdbthread.h (class thread_info): Update comment.
9430
9431 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9432             Tom Tromey  <tom@tromey.com>
9433
9434         * stabsread.h (struct stab_section_list): Remove.
9435         (coffstab_build_psymtabs): Update.
9436         * dbxread.c (symbuf_sections): Now a std::vector.
9437         (sect_idx): New global.
9438         (fill_symbuf): Update.
9439         (coffstab_build_psymtabs): Change type of stabsects parameter.
9440         Update.
9441         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9442         std::vector.
9443         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9444         (coff_locate_sections): Update.
9445         (coff_symfile_read): Remove cleanups.  Update.
9446         (init_stringtab): Add storage parameter.
9447         (free_stringtab, free_stringtab_cleanup): Remove.
9448         (init_lineno): Add storage parameter.
9449         (free_linetab, free_linetab_cleanup): Remove.
9450
9451 2019-03-06  Pedro Alves  <palves@redhat.com>
9452
9453         * linux-fork.c (fork_info::clobber_regs): Delete.
9454         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9455         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9456         comment.  Adjust.
9457         (scoped_switch_fork_info::scoped_switch_fork_info)
9458         (checkpoint_command, linux_fork_context): Adjust
9459         fork_save_infrun_state calls.
9460
9461 2019-03-06  Pedro Alves  <palves@redhat.com>
9462
9463         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9464         (inf_has_multiple_threads): Return 'bool' and rewrite using
9465         inferior_info::threads().
9466
9467 2019-03-06  Pedro Alves  <palves@redhat.com>
9468
9469         * linux-fork.c: Include <list>.
9470         (fork_list): Now a std::list instance.
9471         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9472         (forks_exist_p, find_last_fork): Adjust.
9473         (new_fork): Delete.
9474         (one_fork_p): New.
9475         (add_fork): Adjust.
9476         (free_fork): Delete, folded into fork_info::~fork_info().
9477         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9478         Adjust.
9479         (init_fork_list): Delete.
9480         (linux_fork_killall, linux_fork_mourn_inferior)
9481         (linux_fork_detach, info_checkpoints_command): Adjust.
9482         (_initialize_linux_fork): No longer call init_fork_list.
9483
9484 2019-03-06  Pedro Alves  <palves@redhat.com>
9485
9486         * linux-fork.c (new_fork): New, split out of ...
9487         (add_fork): ... this.  Return void.  Move "first fork" special
9488         case from here, to ...
9489         (checkpoint_command): ... here.
9490         * linux-linux.h (add_fork): Return void.
9491
9492 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9493
9494         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9495
9496 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9497             Chris January  <chris.january@arm.com>
9498             David Lecomber  <david.lecomber@arm.com>
9499
9500         * f-exp.y: New token, UNOP_INTRINSIC.
9501         (exp): New pattern using UNOP_INTRINSIC token.
9502         (f77_keywords): Add 'abs' keyword.
9503         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9504         (value_from_host_double): New function.
9505         (evaluate_subexp_f): Support UNOP_ABS.
9506
9507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9508
9509         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9510         types.
9511
9512 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9513
9514         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9515         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9516         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9517
9518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9519
9520         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9521
9522 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9523             Chris January  <chris.january@arm.com>
9524
9525         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9526         * f-exp.y: Define 'KIND' token.
9527         (exp): New pattern for KIND expressions.
9528         (ptype): Handle types with a kind extension.
9529         (direct_abs_decl): Extend to spot kind extensions.
9530         (f77_keywords): Add 'kind' to the list.
9531         (push_kind_type): New function.
9532         (convert_to_kind_type): New function.
9533         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9534         * parse.c (operator_length_standard): Likewise.
9535         * parser-defs.h (enum type_pieces): Add tp_kind.
9536         * std-operator.def: Add UNOP_KIND.
9537
9538 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9539
9540         * f-exp.y (f_parse): Set yydebug.
9541
9542 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9543
9544         * f-lang.c (evaluate_subexp_f): New function.
9545         (exp_descriptor_f): New global.
9546         (f_language_defn): Use exp_descriptor_f instead of
9547         exp_descriptor_standard.
9548
9549 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9550
9551         * f-exp.y (struct token): Add comments.
9552         (dot_ops): Remove uppercase versions and the end marker.
9553         (f77_keywords): Likewise.
9554         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9555         entries in the dot_ops array are case insensitive, and use
9556         strncasecmp to compare strings.  Also some whitespace cleanup in
9557         this area.  Similar for the f77_keywords array, except entries in
9558         this list might be case sensitive.
9559
9560 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9561
9562         * f-exp.y (struct f77_boolean_val): Add comments.
9563         (boolean_values): Remove uppercase versions, and end marker.
9564         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9565         and use strncasecmp to achieve case insensitivity.  Additionally,
9566         perform whitespace cleanup around this code.
9567
9568 2019-03-06  Tom Tromey  <tromey@adacore.com>
9569
9570         * remote-sim.c (gdbsim_target_open): Use result of
9571         gdb_argv::release.
9572
9573 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9574         Dirk Schubert  <dirk.schubert@arm.com>
9575         Chris January  <chris.january@arm.com>
9576
9577         * eval.c (evaluate_subexp_standard): Call Fortran argument
9578         wrapping logic.
9579         * f-lang.c (struct value): A value which can be passed into a
9580         Fortran function call.
9581         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9582         where appropriate.
9583         (struct type): Value ready for a Fortran function call.
9584         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9585         is needed.
9586         * f-lang.h (fortran_argument_convert): Declaration.
9587         (fortran_preserve_arg_pointer): Declaration.
9588         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9589
9590 2019-03-05  Tom Tromey  <tromey@adacore.com>
9591
9592         * python/py-prettyprint.c (print_string_repr): Remove #if.
9593         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9594
9595 2019-03-05  Tom Tromey  <tromey@adacore.com>
9596
9597         * target.c (the_dummy_target): Move later.  Change type to
9598         "dummy_target".
9599         (initialize_targets): Don't initialize the_dummy_target.
9600
9601 2019-03-05  Tom Tromey  <tromey@adacore.com>
9602
9603         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9604         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9605
9606 2019-03-05  Tom Tromey  <tromey@adacore.com>
9607
9608         * windows-nat.c (windows_nat_target::attach)
9609         (windows_nat_target::detach): Don't call gdb_flush.
9610         * valprint.c (generic_val_print, val_print, val_print_string):
9611         Don't call gdb_flush.
9612         * utils.c (defaulted_query): Don't call gdb_flush.
9613         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9614         * target.c (target_announce_detach): Don't call gdb_flush.
9615         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9616         * remote.c (extended_remote_target::attach): Don't call
9617         gdb_flush.
9618         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9619         * printcmd.c (do_examine): Don't call gdb_flush.
9620         (info_display_command): Don't call gdb_flush.
9621         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9622         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9623         * memattr.c (info_mem_command): Don't call gdb_flush.
9624         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9625         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9626         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9627         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9628         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9629         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9630         (gnu_nat_target::detach): Don't call gdb_flush.
9631         * f-valprint.c (f_val_print): Don't call gdb_flush.
9632         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9633         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9634         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9635         gdb_flush.
9636         * c-valprint.c (c_val_print): Don't call gdb_flush.
9637         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9638
9639 2019-03-05  Tom Tromey  <tromey@adacore.com>
9640
9641         * varobj.c (update_dynamic_varobj_children): Update.
9642         (install_default_visualizer): Use reset, not release.
9643         * value.c (set_internalvar): Update.
9644         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9645         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9646         ATTRIBUTE_UNUSED_RESULT.
9647
9648 2019-03-05  Tom Tromey  <tromey@adacore.com>
9649
9650         * remote.c (class scoped_remote_fd) <release>: Add
9651         ATTRIBUTE_UNUSED_RESULT.
9652
9653 2019-03-05  Tom Tromey  <tromey@adacore.com>
9654
9655         * macroexp.c (struct macro_buffer) <release>: Add
9656         ATTRIBUTE_UNUSED_RESULT.
9657
9658 2019-03-05  Tom Tromey  <tromey@adacore.com>
9659
9660         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9661         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9662         ATTRIBUTE_UNUSED_RESULT.
9663
9664 2019-03-05  Tom Tromey  <tromey@adacore.com>
9665
9666         * common/scoped_fd.h (class scoped_fd) <release>: Add
9667         ATTRIBUTE_UNUSED_RESULT.
9668
9669 2019-03-05  Tom Tromey  <tromey@adacore.com>
9670
9671         * parser-defs.h (struct parser_state) <release>: Add
9672         ATTRIBUTE_UNUSED_RESULT.
9673
9674 2019-03-05  Tom Tromey  <tromey@adacore.com>
9675
9676         * utils.h (class gdb_argv) <release>: Add
9677         ATTRIBUTE_UNUSED_RESULT.
9678         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9679
9680 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9681
9682         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9683         for-loop range, to avoid compiler warnings.
9684
9685         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9686         avoid compiler warnings about unused variables.
9687
9688         * NEWS: Mention end of support for native debugging on MS-Windows
9689         before XP.
9690
9691         PR gdb/24292
9692         * common/netstuff.c:
9693         * gdbserver/gdbreplay.c
9694         * gdbserver/remote-utils.c:
9695         * ser-tcp.c:
9696         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9697         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9698         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9699         'getaddrinfo' and 'freeaddrinfo' were not available before
9700         Windows XP, and mingw.org's MinGW headers by default define
9701         _WIN32_WINNT to 0x500.
9702
9703 2019-03-01  Gary Benson <gbenson@redhat.com>
9704
9705         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9706
9707 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9708             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9709
9710         PR gdb/8527
9711         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9712         set_sigint_trap, clear_sigint_trap.
9713
9714 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9715
9716         * target.c (target_detach): Clear the regcache and the
9717         frame cache.
9718
9719 2019-02-27  Pedro Alves  <palves@redhat.com>
9720
9721         * utils.c (set_screen_size): When we cap the height/width sizes,
9722         tweak the corresponding command variable to show "unlimited":
9723
9724 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9725             Pedro Alves  <palves@redhat.com>
9726
9727         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9728         before calling rl_set_screen_size.
9729
9730 2019-02-27  Tom Tromey  <tromey@adacore.com>
9731
9732         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9733         define.
9734         * python/py-value.c: Remove Python 2.4 workaround.
9735         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9736         workaround.
9737         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9738         Python 2.4 workaround.
9739         * python/python-internal.h: Remove Python 2.4 comment.
9740         (Py_ssize_t): Don't define.
9741         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9742         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9743         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9744         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9745         * python/python.c (do_start_initialization): Remove Python 2.4
9746         workaround.
9747         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9748         (print_children): Remove Python 2.4 workaround.
9749         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9750         workaround.
9751         (CHARBUFFERPROC_NAME): Remove.
9752         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9753         Python 2.4 workaround.
9754
9755 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9756
9757         * NEWS: Note minimum Python version.
9758
9759 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9760
9761         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9762         code from these functions.  Remove corresponding ifdefs.  Use
9763         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9764         Remove gotos and target of gotos.
9765         (infpy_search_memory): Likewise.
9766
9767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9768
9769         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9770         (hppa_gdbarch_init): Don't register deleted functions with
9771         gdbarch.
9772
9773 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9774
9775         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9776         (h8300_unwind_sp): Delete.
9777         (h8300_dummy_id): Delete.
9778         (h8300_gdbarch_init): Don't register deleted functions with
9779         gdbarch.
9780
9781 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9782
9783         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9784         (ft32_unwind_pc): Delete.
9785         (ft32_unwind_sp): Delete.
9786         (ft32_gdbarch_init): Don't register deleted functions with
9787         gdbarch.
9788
9789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9790
9791         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9792         (frv_unwind_pc): Delete.
9793         (frv_unwind_sp): Delete.
9794         (frv_gdbarch_init): Don't register deleted functions with
9795         gdbarch.
9796
9797 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9798
9799         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9800         (riscv_unwind_pc): Delete.
9801         (riscv_unwind_sp): Delete.
9802         (riscv_gdbarch_init): Don't register deleted functions with
9803         gdbarch.
9804
9805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9806
9807         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9808         (csky_unwind_pc): Delete.
9809         (csky_unwind_sp): Delete.
9810         (csky_gdbarch_init): Don't register deleted functions with
9811         gdbarch.
9812
9813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9814
9815         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9816         (cris_unwind_pc): Delete.
9817         (cris_unwind_sp): Delete.
9818         (cris_gdbarch_init): Don't register deleted functions with
9819         gdbarch.
9820
9821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9822
9823         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9824         (bfin_unwind_pc): Delete.
9825         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9826
9827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9828
9829         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9830         (arm_unwind_pc): Delete.
9831         (arm_unwind_sp): Delete.
9832         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9833
9834 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9835
9836         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9837         (arc_unwind_pc): Delete.
9838         (arc_unwind_sp): Delete.
9839         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9840
9841 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9842
9843         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9844         (alpha_unwind_pc): Delete.
9845         (alpha_gdbarch_init): Don't register deleted functions with
9846         gdbarch.
9847
9848 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9849
9850         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9851         (aarch64_unwind_pc): Delete.
9852         (aarch64_unwind_sp): Delete.
9853         (aarch64_gdbarch_init): Don't register deleted functions with
9854         gdbarch.
9855
9856 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9857
9858         * gdbtypes.c (type_align): Don't consider static members when
9859         computing structure alignment.
9860
9861 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9862
9863         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9864         return 0 for other types.
9865         * arch-utils.c (default_type_align): Always return 0.
9866         * gdbarch.h: Regenerate.
9867         * gdbarch.sh (type_align): Extend comment.
9868         * gdbtypes.c (type_align): Add additional comments, always call
9869         gdbarch_type_align before applying the default rules.
9870         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9871         generic code will then apply a suitable default.
9872         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9873         types, return 0 for other types.
9874
9875 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9876
9877         * NEWS: Create a new section for the next release branch.
9878         Rename the section of the current branch, now that it has
9879         been cut.
9880
9881 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9882
9883         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9884         * version.in: Bump version to 8.3.50.DATE-git.
9885
9886 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9887
9888         * aix-thread.c (ptid_cmp): Remove unused variable.
9889         (get_signaled_thread): Likewise.
9890         (store_regs_user_thread): Likewise.
9891         (store_regs_kernel_thread): Likewise.
9892         (fetch_regs_kernel_thread): Remove shadowed variable.
9893
9894 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9895
9896         * features/riscv/32bit-cpu.xml: Add register numbers.
9897         * features/riscv/32bit-fpu.c: Regenerate.
9898         * features/riscv/32bit-fpu.xml: Add register numbers.
9899         * features/riscv/64bit-cpu.xml: Add register numbers.
9900         * features/riscv/64bit-fpu.c: Regenerate.
9901         * features/riscv/64bit-fpu.xml: Add register numbers.
9902
9903 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9904
9905         * NEWS: Mention two argument form of gdb.Value constructor.
9906         * python/py-value.c (convert_buffer_and_type_to_value): New
9907         function.
9908         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9909         Add support for handling an optional second argument.  Call
9910         convert_buffer_and_type_to_value as appropriate.
9911         * python/python-internal.h (Py_buffer_deleter): New struct.
9912         (Py_buffer_up): New typedef.
9913
9914 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9915
9916         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9917         instead of releasing ownership.
9918
9919 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9920
9921         * dwarf2read.c (open_and_init_dwp_file): Call
9922         elf_numsections instead of bfd_count_sections to initialize
9923         dwp_file->num_sections.
9924
9925 2019-02-25  Tom Tromey  <tromey@adacore.com>
9926
9927         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9928
9929 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9930
9931         * gcore.in: Add '--readnever' option when invoking GDB.
9932
9933 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9934
9935         * MAINTAINERS: Update my email address.
9936
9937 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9938
9939         * build-id.c (build_id_to_debug_bfd_1): New function.
9940         (build_id_to_debug_bfd): Look for separate debug file in
9941         sysroot.
9942
9943 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9944
9945         * gdbarch.sh: Update the copyright year range that is placed into
9946         generated files.
9947
9948 2019-02-22  Keith Seitz  <keiths@redhat.com>
9949
9950         PR symtab/23853
9951         * linespec.c (create_sals_line_offset): Search for the default
9952         symtab's filename instead of its fullname.
9953
9954 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9955
9956         * NEWS: Update style defaults.
9957
9958 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9959
9960         * main.c (captured_main_1): Disable styling in batch mode.
9961
9962 2019-02-20  Tom Tromey  <tom@tromey.com>
9963
9964         * symtab.c (symtab_symbol_info): Fix typos.
9965
9966 2019-02-20  Tom Tromey  <tromey@adacore.com>
9967
9968         * findcmd.c (_initialize_mem_search): Use upper case for
9969         metasyntactic variables.
9970
9971 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9972
9973         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9974         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9975
9976 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9977
9978         * top.h (source_file_name): Change to std::string.
9979         * top.c (source_file_name): Likewise.
9980         (command_line_input): Adjust.
9981         * cli/cli-script.c (script_from_file): Adjust.
9982
9983 2019-02-19  Tom Tromey  <tromey@adacore.com>
9984
9985         * ravenscar-thread.c
9986         (ravenscar_thread_target::update_thread_list): Don't call
9987         ada_build_task_list.
9988         * ada-lang.h (ada_build_task_list): Don't declare.
9989         * ada-tasks.c (struct ada_tasks_inferior_data)
9990         <task_list_valid_p>: Now bool.
9991         (read_known_tasks, ada_task_list_changed)
9992         (ada_tasks_invalidate_inferior_data): Update.
9993         (read_known_tasks_array): Return bool.
9994         (read_known_tasks_list): Likewise.
9995         (read_known_tasks): Return void.
9996         (ada_build_task_list): Now static.
9997
9998 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9999
10000         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10001         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10002
10003 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10004
10005         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10006         variant for ada_tasks_pspace_data_handle and
10007         ada_tasks_inferior_data_handle.
10008         (ada_tasks_pspace_data_cleanup): New function.
10009         (ada_tasks_inferior_data_cleanup): New function.
10010
10011 2019-02-17  Tom Tromey  <tom@tromey.com>
10012
10013         * macrotab.h (macro_source_fullname): Return a std::string.
10014         * macrotab.c (macro_include, check_for_redefinition)
10015         (macro_undef, macro_lookup_definition, foreach_macro)
10016         (foreach_macro_in_scope): Update.
10017         (macro_source_fullname): Return a std::string.
10018         * macrocmd.c (show_pp_source_pos): Update.
10019
10020 2019-02-17  Tom Tromey  <tom@tromey.com>
10021
10022         * macrocmd.c (show_pp_source_pos): Style the file names.
10023
10024 2019-02-17  Tom Tromey  <tom@tromey.com>
10025
10026         PR tui/24197:
10027         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10028
10029 2019-02-17  Tom Tromey  <tom@tromey.com>
10030
10031         * ada-lang.c (user_select_syms): Use filtered printing.
10032         * utils.c (wrap_style): New global.
10033         (desired_style): Remove.
10034         (emit_style_escape): Add stream parameter.
10035         (set_output_style, reset_terminal_style, prompt_for_continue):
10036         Update.
10037         (flush_wrap_buffer): Only flush gdb_stdout.
10038         (wrap_here): Set wrap_style.
10039         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10040         treat escape sequences as a character.  Change when wrap buffer is
10041         flushed.
10042         (fputs_styled): Do not set the output style when the default is
10043         requested.
10044         * ui-style.h (struct ui_file_style) <is_default>: New method.
10045         * source.c (print_source_lines_base): Emit escape sequences in one
10046         piece.
10047
10048 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10049
10050         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10051         integers and enumeration types.
10052
10053 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10054
10055         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10056         instead of lookup_symbol_in_language
10057         (do_exact_match): New function.
10058         (ada_get_symbol_name_matcher): Return do_exact_match when
10059         doing a verbatim match.
10060
10061 2019-02-15  Tom Tromey  <tromey@adacore.com>
10062
10063         * ravenscar-thread.c (ravenscar_thread_target::resume)
10064         (ravenscar_thread_target::wait): Special case wildcard requests.
10065
10066 2019-02-15  Tom Tromey  <tromey@adacore.com>
10067
10068         * ravenscar-thread.c (base_ptid): Remove.
10069         (struct ravenscar_thread_target) <close>: New method.
10070         <m_base_ptid>: New member.
10071         <update_inferior_ptid, active_task, task_is_currently_active,
10072         runtime_initialized>: Declare methods.
10073         <ravenscar_thread_target>: Add constructor.
10074         (ravenscar_thread_target::task_is_currently_active)
10075         (ravenscar_thread_target::update_inferior_ptid)
10076         (ravenscar_runtime_initialized): Rename.  Now methods.
10077         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10078         (ravenscar_thread_target::update_thread_list): Update.
10079         (ravenscar_thread_target::active_task): Now method.
10080         (ravenscar_thread_target::store_registers)
10081         (ravenscar_thread_target::prepare_to_store)
10082         (ravenscar_thread_target::prepare_to_store)
10083         (ravenscar_thread_target::mourn_inferior): Update.
10084         (ravenscar_inferior_created): Use "new" to create target.
10085         (ravenscar_thread_target::get_ada_task_ptid): Update.
10086         (_initialize_ravenscar): Don't initialize base_ptid.
10087         (ravenscar_ops): Remove global.
10088
10089 2019-02-15  Tom Tromey  <tromey@adacore.com>
10090
10091         * target.h (push_target): Declare new overload.
10092         * target.c (push_target): New overload, taking an rvalue reference.
10093         * remote.c (remote_target::open_1): Use push_target overload.
10094         * corelow.c (core_target_open): Use push_target overload.
10095
10096 2019-02-15  Tom Tromey  <tromey@adacore.com>
10097
10098         * ravenscar-thread.c (is_ravenscar_task)
10099         (ravenscar_task_is_currently_active): Return bool.
10100         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10101         (_initialize_ravenscar): Remove "(void)".
10102         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10103         Return bool.
10104
10105 2019-02-15  Tom Tromey  <tromey@adacore.com>
10106
10107         * ravenscar-thread.c (ravenscar_runtime_initializer)
10108         (has_ravenscar_runtime, get_running_thread_id)
10109         (ravenscar_thread_target::resume): Fix indentation.
10110
10111 2019-02-15  Tom Tromey  <tromey@adacore.com>
10112
10113         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10114         from ravenscar_arch_ops.
10115         (sparc_ravenscar_ops::fetch_registers)
10116         (sparc_ravenscar_ops::store_registers): Now methods.
10117         (sparc_ravenscar_prepare_to_store): Remove.
10118         (sparc_ravenscar_ops): Redefine.
10119         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10120         methods and destructor.  Remove members.
10121         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10122         (ravenscar_thread_target::store_registers)
10123         (ravenscar_thread_target::prepare_to_store): Update.
10124         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10125         Remove.
10126         (struct ppc_ravenscar_powerpc_ops): Derive from
10127         ravenscar_arch_ops.
10128         (ppc_ravenscar_powerpc_ops::fetch_registers)
10129         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10130         (ppc_ravenscar_powerpc_ops): Redefine.
10131         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10132         (ppc_ravenscar_e500_ops::fetch_registers)
10133         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10134         (ppc_ravenscar_e500_ops): Redefine.
10135         * aarch64-ravenscar-thread.c
10136         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10137         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10138         (aarch64_ravenscar_fetch_registers)
10139         (aarch64_ravenscar_store_registers): Now methods.
10140         (aarch64_ravenscar_ops): Redefine.
10141
10142 2019-02-15  Tom Tromey  <tromey@adacore.com>
10143
10144         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10145         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10146         (ravenscar_thread_target::stopped_by_watchpoint)
10147         (ravenscar_thread_target::stopped_data_address)
10148         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10149
10150 2019-02-15  Tom Tromey  <tromey@adacore.com>
10151
10152         * ravenscar-thread.c: Fix some typos.
10153
10154 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10155             Tom Tromey  <tromey@adacore.com>
10156
10157         * ada-lang.c (ada_exception_sal): Change addr_string to a
10158         std::string.
10159         (create_ada_exception_catchpoint): Update.
10160
10161 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10162             Tom Tromey  <tromey@adacore.com>
10163
10164         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10165         (bp_location_ops): Remove.
10166         (base_breakpoint_allocate_location): Update.
10167         (free_bp_location): Update.
10168         * ada-lang.c (class ada_catchpoint_location)
10169         <ada_catchpoint_location>: Remove ops parameter.
10170         (ada_catchpoint_location_dtor): Remove.
10171         (ada_catchpoint_location_ops): Remove.
10172         (allocate_location_exception): Update.
10173         * breakpoint.h (struct bp_location_ops): Remove.
10174         (class bp_location) <bp_location>: Remove bp_location_ops
10175         parameter.
10176         <~bp_location>: Add destructor.
10177         <ops>: Remove.
10178
10179 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10180             Pedro Alves  <palves@redhat.com>
10181
10182         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10183         'PATH_MAX'.
10184
10185 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10186             Samuel Thibault  <samuel.thibault@gnu.org>
10187             Thomas Schwinge  <thomas@codesourcery.com>
10188
10189         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10190         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10191
10192 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10193
10194         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10195         (check_empty): Use "const char *".
10196
10197         * gnu-nat.c (gnu_nat_target::detach): Instead of
10198         'detach_inferior (pid)' call
10199         'detach_inferior (find_inferior_pid (pid))'.
10200
10201         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10202         'nat/fork-inferior.o'.
10203         * gnu-nat.c: #include "nat/fork-inferior.h".
10204
10205         * gnu-nat.c (gnu_nat_target::detach): Instead of
10206         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10207         * gnu-nat.h: #include "inf-child.h".
10208         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10209         'i386_gnu_nat_target::fetch_registers'.
10210         (gnu_store_registers): Rename/move to
10211         'i386_gnu_nat_target::store_registers'.
10212
10213         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10214         * gnu-nat.h (mach_thread_info): New function.
10215         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10216
10217         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10218
10219 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10220
10221         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10222
10223 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10224
10225         * windows-nat.c (windows_add_thread): Add new parameter
10226         "main_thread_p" with default value set to false.  Update
10227         function documentation as well as all callers.
10228         (windows_delete_thread): Likewise.
10229         (fake_create_process): Update call to windows_add_thread.
10230         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10231         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10232         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10233         call to windows_delete_thread.
10234
10235 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10236
10237         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10238
10239 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10240
10241         * symfile.c (find_separate_debug_file): Use canonical path of
10242         sysroot with child_path instead of gdb_sysroot if it is valid.
10243
10244 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10245
10246         * symfile.c (find_separate_debug_file): Use child_path to
10247         determine if an object file is under a sysroot.
10248
10249 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10250
10251         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10252         unittests/child-path-selftests.c.
10253         * common/pathstuff.c (child_path): New function.
10254         * common/pathstuff.h (child_path): New prototype.
10255         * unittests/child-path-selftests.c: New file.
10256
10257 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10258
10259         * symfile.c (find_separate_debug_file): Look for separate debug
10260         files in debug directories under the sysroot.
10261
10262 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10263
10264         * symtab.h (struct minimal_symbol data_p): New const method.
10265         (struct minimal_symbol text_p): Likewise.
10266         * symtab.c (output_source_filename): Use file name style
10267         to print file name.
10268         (print_symbol_info): Likewise.
10269         (print_msymbol_info): Use address style to print addresses.
10270         Use function name style to print executable text symbols.
10271         (expand_symtab_containing_pc): Use data_p.
10272         (find_pc_sect_compunit_symtab): Likewise.
10273
10274 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10275
10276         * breakpoint.c (describe_other_breakpoints): Use address style
10277         to print addresses.
10278         (say_where): Likewise.
10279
10280 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10281
10282         * ada-typeprint.c (print_func_type): Print function name
10283         style to print function name.
10284         * c-typeprint.c (c_print_type_1): Likewise.
10285
10286 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10287
10288         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10289         for execve.
10290
10291 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10292
10293         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10294         type_stack.
10295
10296 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10297
10298         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10299         TYPE_CODE_REF types.
10300
10301 2019-02-08  Jim Wilson  <jimw@sifive.com>
10302
10303         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10304         (riscv_linux_fregset): New.
10305         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10306
10307 2019-02-07  Tom Tromey  <tom@tromey.com>
10308
10309         * thread.c (thread_cancel_execution_command): Update.
10310         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10311         methods.
10312         (struct thread_fsm_ops): Remove.
10313         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10314         (thread_fsm_should_stop, thread_fsm_return_value)
10315         (thread_fsm_set_finished, thread_fsm_finished_p)
10316         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10317         Don't declare.
10318         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10319         * infrun.c (clear_proceed_status_thread)
10320         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10321         (print_stop_event): Update.
10322         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10323         Add constructor.
10324         (step_command_fsm_ops): Remove.
10325         (new_step_command_fsm): Remove.
10326         (step_1): Update.
10327         (step_command_fsm::should_stop): Rename from
10328         step_command_fsm_should_stop.
10329         (step_command_fsm::clean_up): Rename from
10330         step_command_fsm_clean_up.
10331         (step_command_fsm::do_async_reply_reason): Rename from
10332         step_command_fsm_async_reply_reason.
10333         (struct until_next_fsm): Inherit from thread_fsm.  Add
10334         constructor.
10335         (until_next_fsm_ops): Remove.
10336         (new_until_next_fsm): Remove.
10337         (until_next_fsm::should_stop): Rename from
10338         until_next_fsm_should_stop.
10339         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10340         (until_next_fsm::do_async_reply_reason): Rename from
10341         until_next_fsm_async_reply_reason.
10342         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10343         constructor.  Change type of breakpoint.
10344         (finish_command_fsm_ops): Remove.
10345         (new_finish_command_fsm): Remove.
10346         (finish_command_fsm::should_stop): Rename from
10347         finish_command_fsm_should_stop.
10348         (finish_command_fsm::clean_up): Rename from
10349         finish_command_fsm_clean_up.
10350         (finish_command_fsm::return_value): Rename from
10351         finish_command_fsm_return_value.
10352         (finish_command_fsm::do_async_reply_reason): Rename from
10353         finish_command_fsm_async_reply_reason.
10354         (finish_command): Update.
10355         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10356         Add constructor.
10357         (call_thread_fsm_ops): Remove.
10358         (call_thread_fsm::call_thread_fsm): Rename from
10359         new_call_thread_fsm.
10360         (call_thread_fsm::should_stop): Rename from
10361         call_thread_fsm_should_stop.
10362         (call_thread_fsm::should_notify_stop): Rename from
10363         call_thread_fsm_should_notify_stop.
10364         (run_inferior_call, call_function_by_hand_dummy): Update.
10365         * cli/cli-interp.c (should_print_stop_to_console): Update.
10366         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10367         Add constructor.  Change type of location_breakpoint,
10368         caller_breakpoint.
10369         (until_break_fsm_ops): Remove.
10370         (new_until_break_fsm): Remove.
10371         (until_break_fsm::should_stop): Rename from
10372         until_break_fsm_should_stop.
10373         (until_break_fsm::clean_up): Rename from
10374         until_break_fsm_clean_up.
10375         (until_break_fsm::do_async_reply_reason): Rename from
10376         until_break_fsm_async_reply_reason.
10377         (until_break_command): Update.
10378         * thread-fsm.c: Remove.
10379         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10380
10381 2019-02-07  Tom Tromey  <tom@tromey.com>
10382
10383         * yy-remap.h: Add include guard.
10384         * xtensa-tdep.h: Add include guard.
10385         * xcoffread.h: Rename include guard.
10386         * varobj-iter.h: Add include guard.
10387         * tui/tui.h: Rename include guard.
10388         * tui/tui-winsource.h: Rename include guard.
10389         * tui/tui-wingeneral.h: Rename include guard.
10390         * tui/tui-windata.h: Rename include guard.
10391         * tui/tui-win.h: Rename include guard.
10392         * tui/tui-stack.h: Rename include guard.
10393         * tui/tui-source.h: Rename include guard.
10394         * tui/tui-regs.h: Rename include guard.
10395         * tui/tui-out.h: Rename include guard.
10396         * tui/tui-layout.h: Rename include guard.
10397         * tui/tui-io.h: Rename include guard.
10398         * tui/tui-hooks.h: Rename include guard.
10399         * tui/tui-file.h: Rename include guard.
10400         * tui/tui-disasm.h: Rename include guard.
10401         * tui/tui-data.h: Rename include guard.
10402         * tui/tui-command.h: Rename include guard.
10403         * tic6x-tdep.h: Add include guard.
10404         * target/waitstatus.h: Rename include guard.
10405         * target/wait.h: Rename include guard.
10406         * target/target.h: Rename include guard.
10407         * target/resume.h: Rename include guard.
10408         * target-float.h: Rename include guard.
10409         * stabsread.h: Add include guard.
10410         * rs6000-tdep.h: Add include guard.
10411         * riscv-fbsd-tdep.h: Add include guard.
10412         * regformats/regdef.h: Rename include guard.
10413         * record.h: Rename include guard.
10414         * python/python.h: Rename include guard.
10415         * python/python-internal.h: Rename include guard.
10416         * python/py-stopevent.h: Rename include guard.
10417         * python/py-ref.h: Rename include guard.
10418         * python/py-record.h: Rename include guard.
10419         * python/py-record-full.h: Rename include guard.
10420         * python/py-record-btrace.h: Rename include guard.
10421         * python/py-instruction.h: Rename include guard.
10422         * python/py-events.h: Rename include guard.
10423         * python/py-event.h: Rename include guard.
10424         * procfs.h: Add include guard.
10425         * proc-utils.h: Add include guard.
10426         * p-lang.h: Add include guard.
10427         * or1k-tdep.h: Rename include guard.
10428         * observable.h: Rename include guard.
10429         * nto-tdep.h: Rename include guard.
10430         * nat/x86-linux.h: Rename include guard.
10431         * nat/x86-linux-dregs.h: Rename include guard.
10432         * nat/x86-gcc-cpuid.h: Add include guard.
10433         * nat/x86-dregs.h: Rename include guard.
10434         * nat/x86-cpuid.h: Rename include guard.
10435         * nat/ppc-linux.h: Rename include guard.
10436         * nat/mips-linux-watch.h: Rename include guard.
10437         * nat/linux-waitpid.h: Rename include guard.
10438         * nat/linux-ptrace.h: Rename include guard.
10439         * nat/linux-procfs.h: Rename include guard.
10440         * nat/linux-osdata.h: Rename include guard.
10441         * nat/linux-nat.h: Rename include guard.
10442         * nat/linux-namespaces.h: Rename include guard.
10443         * nat/linux-btrace.h: Rename include guard.
10444         * nat/glibc_thread_db.h: Rename include guard.
10445         * nat/gdb_thread_db.h: Rename include guard.
10446         * nat/gdb_ptrace.h: Rename include guard.
10447         * nat/fork-inferior.h: Rename include guard.
10448         * nat/amd64-linux-siginfo.h: Rename include guard.
10449         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10450         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10451         * nat/aarch64-linux.h: Rename include guard.
10452         * nat/aarch64-linux-hw-point.h: Rename include guard.
10453         * mn10300-tdep.h: Add include guard.
10454         * mips-linux-tdep.h: Add include guard.
10455         * mi/mi-parse.h: Rename include guard.
10456         * mi/mi-out.h: Rename include guard.
10457         * mi/mi-main.h: Rename include guard.
10458         * mi/mi-interp.h: Rename include guard.
10459         * mi/mi-getopt.h: Rename include guard.
10460         * mi/mi-console.h: Rename include guard.
10461         * mi/mi-common.h: Rename include guard.
10462         * mi/mi-cmds.h: Rename include guard.
10463         * mi/mi-cmd-break.h: Rename include guard.
10464         * m2-lang.h: Add include guard.
10465         * location.h: Rename include guard.
10466         * linux-record.h: Rename include guard.
10467         * linux-nat.h: Add include guard.
10468         * linux-fork.h: Add include guard.
10469         * i386-darwin-tdep.h: Rename include guard.
10470         * hppa-linux-offsets.h: Add include guard.
10471         * guile/guile.h: Rename include guard.
10472         * guile/guile-internal.h: Rename include guard.
10473         * gnu-nat.h: Rename include guard.
10474         * gdb-stabs.h: Rename include guard.
10475         * frv-tdep.h: Add include guard.
10476         * f-lang.h: Add include guard.
10477         * event-loop.h: Add include guard.
10478         * darwin-nat.h: Rename include guard.
10479         * cp-abi.h: Rename include guard.
10480         * config/sparc/nm-sol2.h: Rename include guard.
10481         * config/nm-nto.h: Rename include guard.
10482         * config/nm-linux.h: Add include guard.
10483         * config/i386/nm-i386gnu.h: Rename include guard.
10484         * config/djgpp/nl_types.h: Rename include guard.
10485         * config/djgpp/langinfo.h: Rename include guard.
10486         * compile/gcc-cp-plugin.h: Add include guard.
10487         * compile/gcc-c-plugin.h: Add include guard.
10488         * compile/compile.h: Rename include guard.
10489         * compile/compile-object-run.h: Rename include guard.
10490         * compile/compile-object-load.h: Rename include guard.
10491         * compile/compile-internal.h: Rename include guard.
10492         * compile/compile-cplus.h: Rename include guard.
10493         * compile/compile-c.h: Rename include guard.
10494         * common/xml-utils.h: Rename include guard.
10495         * common/x86-xstate.h: Rename include guard.
10496         * common/version.h: Rename include guard.
10497         * common/vec.h: Rename include guard.
10498         * common/tdesc.h: Rename include guard.
10499         * common/selftest.h: Rename include guard.
10500         * common/scoped_restore.h: Rename include guard.
10501         * common/scoped_mmap.h: Rename include guard.
10502         * common/scoped_fd.h: Rename include guard.
10503         * common/safe-iterator.h: Rename include guard.
10504         * common/run-time-clock.h: Rename include guard.
10505         * common/refcounted-object.h: Rename include guard.
10506         * common/queue.h: Rename include guard.
10507         * common/ptid.h: Rename include guard.
10508         * common/print-utils.h: Rename include guard.
10509         * common/preprocessor.h: Rename include guard.
10510         * common/pathstuff.h: Rename include guard.
10511         * common/observable.h: Rename include guard.
10512         * common/netstuff.h: Rename include guard.
10513         * common/job-control.h: Rename include guard.
10514         * common/host-defs.h: Rename include guard.
10515         * common/gdb_wait.h: Rename include guard.
10516         * common/gdb_vecs.h: Rename include guard.
10517         * common/gdb_unlinker.h: Rename include guard.
10518         * common/gdb_unique_ptr.h: Rename include guard.
10519         * common/gdb_tilde_expand.h: Rename include guard.
10520         * common/gdb_sys_time.h: Rename include guard.
10521         * common/gdb_string_view.h: Rename include guard.
10522         * common/gdb_splay_tree.h: Rename include guard.
10523         * common/gdb_setjmp.h: Rename include guard.
10524         * common/gdb_ref_ptr.h: Rename include guard.
10525         * common/gdb_optional.h: Rename include guard.
10526         * common/gdb_locale.h: Rename include guard.
10527         * common/gdb_assert.h: Rename include guard.
10528         * common/filtered-iterator.h: Rename include guard.
10529         * common/filestuff.h: Rename include guard.
10530         * common/fileio.h: Rename include guard.
10531         * common/environ.h: Rename include guard.
10532         * common/common-utils.h: Rename include guard.
10533         * common/common-types.h: Rename include guard.
10534         * common/common-regcache.h: Rename include guard.
10535         * common/common-inferior.h: Rename include guard.
10536         * common/common-gdbthread.h: Rename include guard.
10537         * common/common-exceptions.h: Rename include guard.
10538         * common/common-defs.h: Rename include guard.
10539         * common/common-debug.h: Rename include guard.
10540         * common/cleanups.h: Rename include guard.
10541         * common/buffer.h: Rename include guard.
10542         * common/btrace-common.h: Rename include guard.
10543         * common/break-common.h: Rename include guard.
10544         * cli/cli-utils.h: Rename include guard.
10545         * cli/cli-style.h: Rename include guard.
10546         * cli/cli-setshow.h: Rename include guard.
10547         * cli/cli-script.h: Rename include guard.
10548         * cli/cli-interp.h: Rename include guard.
10549         * cli/cli-decode.h: Rename include guard.
10550         * cli/cli-cmds.h: Rename include guard.
10551         * charset-list.h: Add include guard.
10552         * buildsym-legacy.h: Rename include guard.
10553         * bfin-tdep.h: Add include guard.
10554         * ax.h: Rename include guard.
10555         * arm-linux-tdep.h: Add include guard.
10556         * arm-fbsd-tdep.h: Add include guard.
10557         * arch/xtensa.h: Rename include guard.
10558         * arch/tic6x.h: Add include guard.
10559         * arch/i386.h: Add include guard.
10560         * arch/arm.h: Rename include guard.
10561         * arch/arm-linux.h: Rename include guard.
10562         * arch/arm-get-next-pcs.h: Rename include guard.
10563         * arch/amd64.h: Add include guard.
10564         * arch/aarch64-insn.h: Rename include guard.
10565         * arch-utils.h: Rename include guard.
10566         * annotate.h: Add include guard.
10567         * amd64-darwin-tdep.h: Rename include guard.
10568         * aarch64-linux-tdep.h: Add include guard.
10569         * aarch64-fbsd-tdep.h: Add include guard.
10570         * aarch32-linux-nat.h: Add include guard.
10571
10572 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10573
10574         * macrotab.c (macro_define_internal): New function that
10575         factorizes macro_define_object_internal and macro_define_function
10576         code.
10577         (macro_define_object_internal): Use macro_define_internal.
10578         (macro_define_function): Likewise.
10579
10580 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10581
10582         * macrocmd.c (extract_identifier): Return
10583         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10584         callers.
10585
10586 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10587
10588         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10589
10590 2019-02-05  Tom Tromey  <tom@tromey.com>
10591
10592         * target.c (target_stack::unpush): Move assertion earlier.
10593
10594 2019-01-30  Tom Tromey  <tom@tromey.com>
10595
10596         PR python/23615:
10597         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10598         (gdbpy_parse_and_eval): Likewise.
10599         * python/python-internal.h (gdbpy_allow_threads): New class.
10600
10601 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10602
10603         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10604         (aarch64_fbsd_fpregmap): Move earlier.
10605         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10606         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10607         instead of individual calls to trad_frame_set_reg_addr.
10608         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10609         earlier.
10610         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10611         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10612         instead of individual calls to trad_frame_set_reg_addr.
10613
10614 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10615
10616         * CONTRIBUTE: Replace contribution list with wiki link.
10617
10618 2019-01-25  Tom Tromey  <tom@tromey.com>
10619
10620         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10621
10622 2019-01-25  Tom Tromey  <tom@tromey.com>
10623
10624         * xtensa-linux-nat.c: Fix common/ includes.
10625         * xml-support.h: Fix common/ includes.
10626         * xml-support.c: Fix common/ includes.
10627         * x86-linux-nat.c: Fix common/ includes.
10628         * windows-nat.c: Fix common/ includes.
10629         * varobj.h: Fix common/ includes.
10630         * varobj.c: Fix common/ includes.
10631         * value.c: Fix common/ includes.
10632         * valops.c: Fix common/ includes.
10633         * utils.c: Fix common/ includes.
10634         * unittests/xml-utils-selftests.c: Fix common/ includes.
10635         * unittests/utils-selftests.c: Fix common/ includes.
10636         * unittests/unpack-selftests.c: Fix common/ includes.
10637         * unittests/tracepoint-selftests.c: Fix common/ includes.
10638         * unittests/style-selftests.c: Fix common/ includes.
10639         * unittests/string_view-selftests.c: Fix common/ includes.
10640         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10641         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10642         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10643         * unittests/rsp-low-selftests.c: Fix common/ includes.
10644         * unittests/parse-connection-spec-selftests.c: Fix common/
10645         includes.
10646         * unittests/optional-selftests.c: Fix common/ includes.
10647         * unittests/offset-type-selftests.c: Fix common/ includes.
10648         * unittests/observable-selftests.c: Fix common/ includes.
10649         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10650         * unittests/memrange-selftests.c: Fix common/ includes.
10651         * unittests/memory-map-selftests.c: Fix common/ includes.
10652         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10653         * unittests/function-view-selftests.c: Fix common/ includes.
10654         * unittests/environ-selftests.c: Fix common/ includes.
10655         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10656         * unittests/common-utils-selftests.c: Fix common/ includes.
10657         * unittests/cli-utils-selftests.c: Fix common/ includes.
10658         * unittests/array-view-selftests.c: Fix common/ includes.
10659         * ui-file.c: Fix common/ includes.
10660         * tui/tui-io.c: Fix common/ includes.
10661         * tracepoint.h: Fix common/ includes.
10662         * tracepoint.c: Fix common/ includes.
10663         * tracefile-tfile.c: Fix common/ includes.
10664         * top.h: Fix common/ includes.
10665         * top.c: Fix common/ includes.
10666         * thread.c: Fix common/ includes.
10667         * target/waitstatus.h: Fix common/ includes.
10668         * target/waitstatus.c: Fix common/ includes.
10669         * target.h: Fix common/ includes.
10670         * target.c: Fix common/ includes.
10671         * target-memory.c: Fix common/ includes.
10672         * target-descriptions.c: Fix common/ includes.
10673         * symtab.h: Fix common/ includes.
10674         * symfile.c: Fix common/ includes.
10675         * stap-probe.c: Fix common/ includes.
10676         * spu-linux-nat.c: Fix common/ includes.
10677         * sparc-nat.c: Fix common/ includes.
10678         * source.c: Fix common/ includes.
10679         * solib.c: Fix common/ includes.
10680         * solib-target.c: Fix common/ includes.
10681         * ser-unix.c: Fix common/ includes.
10682         * ser-tcp.c: Fix common/ includes.
10683         * ser-pipe.c: Fix common/ includes.
10684         * ser-base.c: Fix common/ includes.
10685         * selftest-arch.c: Fix common/ includes.
10686         * s12z-tdep.c: Fix common/ includes.
10687         * rust-exp.y: Fix common/ includes.
10688         * rs6000-aix-tdep.c: Fix common/ includes.
10689         * riscv-tdep.c: Fix common/ includes.
10690         * remote.c: Fix common/ includes.
10691         * remote-notif.h: Fix common/ includes.
10692         * remote-fileio.h: Fix common/ includes.
10693         * remote-fileio.c: Fix common/ includes.
10694         * regcache.h: Fix common/ includes.
10695         * regcache.c: Fix common/ includes.
10696         * record-btrace.c: Fix common/ includes.
10697         * python/python.c: Fix common/ includes.
10698         * python/py-type.c: Fix common/ includes.
10699         * python/py-inferior.c: Fix common/ includes.
10700         * progspace.h: Fix common/ includes.
10701         * producer.c: Fix common/ includes.
10702         * procfs.c: Fix common/ includes.
10703         * proc-api.c: Fix common/ includes.
10704         * printcmd.c: Fix common/ includes.
10705         * ppc-linux-nat.c: Fix common/ includes.
10706         * parser-defs.h: Fix common/ includes.
10707         * osdata.c: Fix common/ includes.
10708         * obsd-nat.c: Fix common/ includes.
10709         * nat/x86-linux.c: Fix common/ includes.
10710         * nat/x86-linux-dregs.c: Fix common/ includes.
10711         * nat/x86-dregs.h: Fix common/ includes.
10712         * nat/x86-dregs.c: Fix common/ includes.
10713         * nat/ppc-linux.c: Fix common/ includes.
10714         * nat/mips-linux-watch.h: Fix common/ includes.
10715         * nat/mips-linux-watch.c: Fix common/ includes.
10716         * nat/linux-waitpid.c: Fix common/ includes.
10717         * nat/linux-ptrace.h: Fix common/ includes.
10718         * nat/linux-ptrace.c: Fix common/ includes.
10719         * nat/linux-procfs.c: Fix common/ includes.
10720         * nat/linux-personality.c: Fix common/ includes.
10721         * nat/linux-osdata.c: Fix common/ includes.
10722         * nat/linux-namespaces.c: Fix common/ includes.
10723         * nat/linux-btrace.h: Fix common/ includes.
10724         * nat/linux-btrace.c: Fix common/ includes.
10725         * nat/fork-inferior.c: Fix common/ includes.
10726         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10727         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10728         * nat/aarch64-linux.c: Fix common/ includes.
10729         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10730         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10731         * namespace.h: Fix common/ includes.
10732         * mips-linux-tdep.c: Fix common/ includes.
10733         * minsyms.c: Fix common/ includes.
10734         * mi/mi-parse.h: Fix common/ includes.
10735         * mi/mi-main.c: Fix common/ includes.
10736         * mi/mi-cmd-env.c: Fix common/ includes.
10737         * memrange.h: Fix common/ includes.
10738         * memattr.c: Fix common/ includes.
10739         * maint.h: Fix common/ includes.
10740         * maint.c: Fix common/ includes.
10741         * main.c: Fix common/ includes.
10742         * machoread.c: Fix common/ includes.
10743         * location.c: Fix common/ includes.
10744         * linux-thread-db.c: Fix common/ includes.
10745         * linux-nat.c: Fix common/ includes.
10746         * linux-fork.c: Fix common/ includes.
10747         * inline-frame.c: Fix common/ includes.
10748         * infrun.c: Fix common/ includes.
10749         * inflow.c: Fix common/ includes.
10750         * inferior.h: Fix common/ includes.
10751         * inferior.c: Fix common/ includes.
10752         * infcmd.c: Fix common/ includes.
10753         * inf-ptrace.c: Fix common/ includes.
10754         * inf-child.c: Fix common/ includes.
10755         * ia64-linux-nat.c: Fix common/ includes.
10756         * i387-tdep.c: Fix common/ includes.
10757         * i386-tdep.c: Fix common/ includes.
10758         * i386-linux-tdep.c: Fix common/ includes.
10759         * i386-linux-nat.c: Fix common/ includes.
10760         * i386-go32-tdep.c: Fix common/ includes.
10761         * i386-fbsd-tdep.c: Fix common/ includes.
10762         * i386-fbsd-nat.c: Fix common/ includes.
10763         * guile/scm-type.c: Fix common/ includes.
10764         * guile/guile.c: Fix common/ includes.
10765         * go32-nat.c: Fix common/ includes.
10766         * gnu-nat.c: Fix common/ includes.
10767         * gdbthread.h: Fix common/ includes.
10768         * gdbarch-selftests.c: Fix common/ includes.
10769         * gdb_usleep.c: Fix common/ includes.
10770         * gdb_select.h: Fix common/ includes.
10771         * gdb_bfd.c: Fix common/ includes.
10772         * gcore.c: Fix common/ includes.
10773         * fork-child.c: Fix common/ includes.
10774         * findvar.c: Fix common/ includes.
10775         * fbsd-nat.c: Fix common/ includes.
10776         * event-top.c: Fix common/ includes.
10777         * event-loop.c: Fix common/ includes.
10778         * dwarf2read.c: Fix common/ includes.
10779         * dwarf2loc.c: Fix common/ includes.
10780         * dwarf2-frame.c: Fix common/ includes.
10781         * dwarf-index-cache.c: Fix common/ includes.
10782         * dtrace-probe.c: Fix common/ includes.
10783         * disasm-selftests.c: Fix common/ includes.
10784         * defs.h: Fix common/ includes.
10785         * csky-tdep.c: Fix common/ includes.
10786         * cp-valprint.c: Fix common/ includes.
10787         * cp-support.h: Fix common/ includes.
10788         * cp-support.c: Fix common/ includes.
10789         * corelow.c: Fix common/ includes.
10790         * completer.h: Fix common/ includes.
10791         * completer.c: Fix common/ includes.
10792         * compile/compile.c: Fix common/ includes.
10793         * compile/compile-loc2c.c: Fix common/ includes.
10794         * compile/compile-cplus-types.c: Fix common/ includes.
10795         * compile/compile-cplus-symbols.c: Fix common/ includes.
10796         * command.h: Fix common/ includes.
10797         * cli/cli-dump.c: Fix common/ includes.
10798         * cli/cli-cmds.c: Fix common/ includes.
10799         * charset.c: Fix common/ includes.
10800         * build-id.c: Fix common/ includes.
10801         * btrace.h: Fix common/ includes.
10802         * btrace.c: Fix common/ includes.
10803         * breakpoint.h: Fix common/ includes.
10804         * breakpoint.c: Fix common/ includes.
10805         * ax.h:
10806         (enum agent_op): Fix common/ includes.
10807         * ax-general.c (struct aop_map): Fix common/ includes.
10808         * ax-gdb.c: Fix common/ includes.
10809         * auxv.c: Fix common/ includes.
10810         * auto-load.c: Fix common/ includes.
10811         * arm-tdep.c: Fix common/ includes.
10812         * arch/riscv.c: Fix common/ includes.
10813         * arch/ppc-linux-common.c: Fix common/ includes.
10814         * arch/i386.c: Fix common/ includes.
10815         * arch/arm.c: Fix common/ includes.
10816         * arch/arm-linux.c: Fix common/ includes.
10817         * arch/arm-get-next-pcs.c: Fix common/ includes.
10818         * arch/amd64.c: Fix common/ includes.
10819         * arch/aarch64.c: Fix common/ includes.
10820         * arch/aarch64-insn.c: Fix common/ includes.
10821         * arch-utils.c: Fix common/ includes.
10822         * amd64-windows-tdep.c: Fix common/ includes.
10823         * amd64-tdep.c: Fix common/ includes.
10824         * amd64-sol2-tdep.c: Fix common/ includes.
10825         * amd64-obsd-tdep.c: Fix common/ includes.
10826         * amd64-nbsd-tdep.c: Fix common/ includes.
10827         * amd64-linux-tdep.c: Fix common/ includes.
10828         * amd64-linux-nat.c: Fix common/ includes.
10829         * amd64-fbsd-tdep.c: Fix common/ includes.
10830         * amd64-fbsd-nat.c: Fix common/ includes.
10831         * amd64-dicos-tdep.c: Fix common/ includes.
10832         * amd64-darwin-tdep.c: Fix common/ includes.
10833         * agent.c: Fix common/ includes.
10834         * ada-lang.h: Fix common/ includes.
10835         * ada-lang.c: Fix common/ includes.
10836         * aarch64-tdep.c: Fix common/ includes.
10837
10838 2019-01-25  Tom Tromey  <tom@tromey.com>
10839
10840         * common/create-version.sh: Use common/version.h.
10841
10842 2019-01-24  Pedro Alves  <palves@redhat.com>
10843
10844         * infrun.c (signal_stop, signal_print, signal_program)
10845         (signal_catch, signal_pass): Now arrays instead of pointers.
10846         (update_signals_program_target, do_target_resume)
10847         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10848         * linux-nat.c (linux_nat_target::pass_signals)
10849         (linux_nat_target::create_inferior, linux_nat_target::attach):
10850         Adjust.
10851         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10852         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10853         * procfs.c (procfs_target::pass_signals): Adjust.
10854         * record-full.c (record_full_target::resume): Adjust.
10855         * remote.c (remote_target::pass_signals)
10856         (remote_target::program_signals): Adjust.
10857         * target-debug.h (target_debug_print_signals): Now takes a
10858         gdb::array_view as parameter.  Adjust.
10859         * target.h (target_ops) <pass_signals, program_signals>: Replace
10860         pointer and length parameters with gdb::array_view.
10861         (target_pass_signals, target_program_signals): Likewise.
10862         * target-delegates.c: Regenerate.
10863
10864 2019-01-24  Pedro Alves  <palves@redhat.com>
10865
10866         * common/forward-scope-exit.h
10867         (forward_scope_exit::forward_scope_exit): Pass arguments to
10868         m_bind_function directly, instead of creating a std::bind and
10869         copying that.
10870
10871 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10872
10873         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10874         for static members.
10875         (pass_in_v_vfp_candidate): Likewise.
10876
10877 2019-01-23  Tom Tromey  <tom@tromey.com>
10878             Pedro Alves  <palves@redhat.com>
10879
10880         * regcache.c (class regcache_invalidator): Remove.
10881         (regcache::raw_write): Use make_scope_exit.
10882
10883 2019-01-23  Tom Tromey  <tom@tromey.com>
10884
10885         * ui-out.h (class ui_out_emit_type): Update comment.
10886
10887 2019-01-23  Tom Tromey  <tom@tromey.com>
10888
10889         * infrun.c (fetch_inferior_event): Update comment.
10890
10891 2019-01-23  Tom Tromey  <tom@tromey.com>
10892             Pedro Alves  <palves@redhat.com>
10893
10894         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10895         parameter.
10896         (fetch_inferior_event): Use SCOPE_EXIT.
10897
10898
10899 2019-01-23  Tom Tromey  <tom@tromey.com>
10900             Pedro Alves  <palves@redhat.com>
10901
10902         * infrun.c (disable_thread_events): Delete.
10903         (stop_all_threads): Use SCOPE_EXIT.
10904
10905 2019-01-23  Tom Tromey  <tom@tromey.com>
10906             Pedro Alves  <palves@redhat.com>
10907
10908         * symfile.c: Include forward-scope-exit.h.
10909         (clear_symtab_users_cleanup): Replace forward declaration with
10910         a FORWARD_SCOPE_EXIT.
10911         (syms_from_objfile_1): Use the forward_scope_exit and
10912         gdb::optional instead of cleanup_function.
10913         (reread_symbols): Use the forward_scope_exit instead of
10914         cleanup_function.
10915         (clear_symtab_users_cleanup): Remove function.
10916
10917 2019-01-23  Tom Tromey  <tom@tromey.com>
10918             Pedro Alves  <palves@redhat.com>
10919
10920         * linux-nat.c: Include scope-exit.h.
10921         (cleanup_target_stop): Remove.
10922         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10923         SCOPE_EXIT.
10924
10925 2019-01-23  Tom Tromey  <tom@tromey.com>
10926             Pedro Alves  <palves@redhat.com>
10927
10928         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10929         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10930
10931 2019-01-23  Tom Tromey  <tom@tromey.com>
10932             Andrew Burgess  <andrew.burgess@embecosm.com>
10933             Pedro Alves  <palves@redhat.com>
10934
10935         * infrun.c (fetch_inferior_event): Use scope_exit.
10936         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10937         * top.c (execute_command): Use scope_exit.
10938         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10939         * utils.c (do_bpstat_clear_actions_cleanup)
10940         (make_bpstat_clear_actions_cleanup): Remove.
10941
10942 2019-01-23  Tom Tromey  <tom@tromey.com>
10943             Pedro Alves  <palves@redhat.com>
10944
10945         * infrun.c: Include "common/scope-exit.h"
10946         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10947         (wait_for_inferior): Use SCOPE_EXIT.
10948         (fetch_inferior_event): Use scope_exit.
10949
10950 2019-01-23  Tom Tromey  <tom@tromey.com>
10951             Pedro Alves  <palves@redhat.com>
10952
10953         * breakpoint.c (create_breakpoint): Remove cleanup.
10954
10955 2019-01-23  Tom Tromey  <tom@tromey.com>
10956             Andrew Burgess  <andrew.burgess@embecosm.com>
10957             Pedro Alves  <palves@redhat.com>
10958
10959 2019-01-23  Pedro Alves  <palves@redhat.com>
10960
10961         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10962
10963 2019-01-23  Pedro Alves  <palves@redhat.com>
10964             Andrew Burgess  <andrew.burgess@embecosm.com>
10965
10966         * gdbthread.h: Include "common/forward-scope-exit.h".
10967         (scoped_finish_thread_state): Redefine custom class in terms of
10968         forward_scope_exit.
10969
10970 2019-01-23  Pedro Alves  <palves@redhat.com>
10971             Andrew Burgess  <andrew.burgess@embecosm.com>
10972
10973         * common/forward-scope-exit.h: New file.
10974
10975 2019-01-23  Pedro Alves  <palves@redhat.com>
10976             Andrew Burgess  <andrew.burgess@embecosm.com>
10977             Tom Tromey  <tom@tromey.com>
10978
10979         * common/scope-exit.h: New file.
10980
10981 2019-01-23  Pedro Alves  <palves@redhat.com>
10982
10983         * common/preprocessor.h (ESC): Rename to ...
10984         (ESC_PARENS): ... this.
10985         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10986         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10987
10988 2019-01-23  Tom Tromey  <tom@tromey.com>
10989
10990         * language.h (class scoped_switch_to_sym_language_if_auto):
10991         Initialize m_lang in both cases.
10992
10993 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10994
10995         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10996         with XCNEW.
10997
10998 2019-01-22  Tom Tromey  <tom@tromey.com>
10999
11000         * corelow.c: Do not include sys/file.h.
11001
11002 2019-01-22  Tom Tromey  <tom@tromey.com>
11003
11004         * tui/tui-wingeneral.h: Include gdb_curses.h.
11005
11006 2019-01-22  Tom Tromey  <tom@tromey.com>
11007
11008         * source-cache.h (class source_cache) <get_source_lines,
11009         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11010
11011 2019-01-22  Tom Tromey  <tom@tromey.com>
11012
11013         * remote-fileio.h (struct remote_target): Declare.
11014
11015 2019-01-22  Tom Tromey  <tom@tromey.com>
11016
11017         * python/py-arch.c: Do not include py-ref.h.
11018         * python/py-bpevent.c: Do not include py-ref.h.
11019         * python/py-cmd.c: Do not include py-ref.h.
11020         * python/py-continueevent.c: Do not include py-ref.h.
11021         * python/py-event.h: Do not include py-ref.h.
11022         * python/py-evtregistry.c: Do not include py-ref.h.
11023         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11024         * python/py-frame.c: Do not include py-ref.h.
11025         * python/py-framefilter.c: Do not include py-ref.h.
11026         * python/py-function.c: Do not include py-ref.h.
11027         * python/py-infevents.c: Do not include py-ref.h.
11028         * python/py-linetable.c: Do not include py-ref.h.
11029         * python/py-objfile.c: Do not include py-ref.h.
11030         * python/py-param.c: Do not include py-ref.h.
11031         * python/py-prettyprint.c: Do not include py-ref.h.
11032         * python/py-progspace.c: Do not include py-ref.h.
11033         * python/py-symbol.c: Do not include py-ref.h.
11034         * python/py-symtab.c: Do not include py-ref.h.
11035         * python/py-type.c: Do not include py-ref.h.
11036         * python/py-unwind.c: Do not include py-ref.h.
11037         * python/py-utils.c: Do not include py-ref.h.
11038         * python/py-value.c: Do not include py-ref.h.
11039         * python/py-varobj.c: Do not include py-ref.h.
11040         * python/py-xmethods.c: Do not include py-ref.h.
11041         * python/python.c: Do not include py-ref.h.
11042         * varobj.c: Do not include py-ref.h.
11043
11044 2019-01-22  Tom Tromey  <tom@tromey.com>
11045
11046         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11047         keyword for bcache.
11048
11049 2019-01-22  Tom Tromey  <tom@tromey.com>
11050
11051         * compile/compile-cplus-types.c: Remove a comment by #include.
11052
11053 2019-01-22  Tom Tromey  <tom@tromey.com>
11054
11055         * compile/gcc-c-plugin.h: Include compile-internal.h.
11056
11057 2019-01-22  Tom Tromey  <tom@tromey.com>
11058
11059         * stabsread.c (EXTERN): Do not define.
11060         (symnum, next_symbol_text_func, processing_gcc_compilation)
11061         (within_function, global_sym_chain, global_stabs)
11062         (previous_stab_code, this_object_header_files)
11063         (n_this_object_header_files)
11064         (n_allocated_this_object_header_files): Define.
11065         * stabsread.h (EXTERN): Never define.  Use "extern".
11066
11067 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11068
11069         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11070         history_value.
11071
11072 2019-01-21  Tom Tromey  <tom@tromey.com>
11073
11074         * ui-out.c: Fix includes.
11075         * tui/tui-source.c: Fix includes.
11076         * target.c: Fix includes.
11077         * remote.c: Fix includes.
11078         * regcache.c: Fix includes.
11079         * python/py-block.c: Fix includes.
11080         * printcmd.c: Fix includes.
11081         * or1k-tdep.c: Fix includes.
11082         * mi/mi-main.c: Fix includes.
11083         * m32r-tdep.c: Fix includes.
11084         * csky-tdep.c: Fix includes.
11085         * compile/compile-cplus-types.c: Fix includes.
11086         * cli/cli-interp.c: Fix includes.
11087
11088 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11089
11090         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11091         for padding.
11092
11093 2019-01-16  Tom Tromey  <tom@tromey.com>
11094
11095         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11096         earlier.
11097         (struct objfile) <msymbols_range>: Move from top level.
11098         <msymbols>: New method.
11099         (class objfile_msymbols): Remove.
11100         * symtab.c (default_collect_symbol_completion_matches_break_on):
11101         Update.
11102         * symmisc.c (dump_msymbols): Update.
11103         * stabsread.c (scan_file_globals): Update.
11104         * objc-lang.c (info_selectors_command, info_classes_command)
11105         (find_methods): Update.
11106         * minsyms.c (find_solib_trampoline_target): Update.
11107         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11108         * coffread.c (coff_symfile_read): Update.
11109         * ada-lang.c (ada_lookup_simple_minsym)
11110         (ada_collect_symbol_completion_matches): Update.
11111
11112 2019-01-16  Tom Tromey  <tom@tromey.com>
11113
11114         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11115         type.  Remove no-argument constructor.
11116         <iterator::operator++>: Simplify.
11117         <begin>: Update.
11118         <end>: Use minimal_symbol_count.
11119
11120 2019-01-16  Tom Tromey  <tom@tromey.com>
11121
11122         * objfiles.h (struct objfile) <psymtabs>: New method.
11123         (class objfile_psymtabs): Remove.
11124         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11125         typedef.
11126         <range>: New method.
11127         (require_partial_symbols): Change return type.
11128         * psymtab.c (require_partial_symbols)
11129         (psym_expand_symtabs_matching): Update.
11130         * mdebugread.c (parse_partial_symbols): Update.
11131         * dbxread.c (dbx_end_psymtab): Update.
11132
11133 2019-01-15  Tom Tromey  <tom@tromey.com>
11134
11135         * symtab.c (lookup_objfile_from_block)
11136         (lookup_symbol_in_objfile_symtabs)
11137         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11138         (find_line_symtab, info_sources_command)
11139         (default_collect_symbol_completion_matches_break_on)
11140         (make_source_files_completion_list): Update.
11141         * symmisc.c (print_objfile_statistics, dump_objfile)
11142         (maintenance_print_symbols, maintenance_info_symtabs)
11143         (maintenance_check_symtabs, maintenance_info_line_tables):
11144         Update.
11145         * source.c (select_source_symtab)
11146         (forget_cached_source_info_for_objfile): Update.
11147         * objfiles.h (class objfile_compunits): Remove.
11148         (struct objfile) <compunits_range>: New typedef.
11149         (compunits): New method.
11150         * objfiles.c (objfile_relocate1): Update.
11151         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11152         * maint.c (count_symtabs_and_blocks): Update.
11153         * linespec.c (iterate_over_all_matching_symtabs): Update.
11154         * cp-support.c (add_symbol_overload_list_qualified): Update.
11155         * coffread.c (coff_symtab_read): Update.
11156         * ada-lang.c (add_nonlocal_symbols)
11157         (ada_collect_symbol_completion_matches)
11158         (ada_add_global_exceptions): Update.
11159
11160 2019-01-15  Tom Tromey  <tom@tromey.com>
11161
11162         * progspace.h (program_space) <objfiles_safe_range>: New
11163         typedef.
11164         <objfiles_safe>: New method.
11165         * objfiles.h (class all_objfiles_safe): Remove.
11166         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11167         * jit.c (jit_inferior_exit_hook): Update.
11168
11169 2019-01-17  Tom Tromey  <tom@tromey.com>
11170
11171         * progspace.h (program_space) <objfiles_range>: New typedef.
11172         <objfiles>: New method.
11173         <objfiles_head>: Rename from objfiles.
11174         (object_files): Update.
11175         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11176         * guile/scm-pretty-print.c
11177         (ppscm_find_pretty_printer_from_objfiles): Update.
11178         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11179         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11180         Update.
11181         * python/py-progspace.c (pspy_get_objfiles): Update.
11182         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11183         Update.
11184         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11185         (objfpy_lookup_objfile_by_build_id): Update.
11186         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11187         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11188         Update.
11189         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11190         (expand_symtab_containing_pc, lookup_objfile_from_block)
11191         (lookup_static_symbol, basic_lookup_transparent_type)
11192         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11193         (find_line_symtab, info_sources_command)
11194         (default_collect_symbol_completion_matches_break_on)
11195         (make_source_files_completion_list, find_main_name): Update.
11196         * symmisc.c (print_symbol_bcache_statistics)
11197         (print_objfile_statistics, maintenance_print_symbols)
11198         (maintenance_print_msymbols, maintenance_print_objfiles)
11199         (maintenance_info_symtabs, maintenance_check_symtabs)
11200         (maintenance_expand_symtabs, maintenance_info_line_tables):
11201         Update.
11202         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11203         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11204         (map_overlay_command, unmap_overlay_command)
11205         (simple_overlay_update, expand_symtabs_matching)
11206         (map_symbol_filenames): Update.
11207         * symfile-debug.c (set_debug_symfile): Update.
11208         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11209         Update.
11210         * source.c (select_source_symtab, forget_cached_source_info):
11211         Update.
11212         * solib.c (solib_read_symbols): Update.
11213         * solib-spu.c (append_ocl_sos): Update.
11214         * psymtab.c (maintenance_print_psymbols)
11215         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11216         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11217         * printcmd.c (info_symbol_command): Update.
11218         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11219         Update.
11220         * objfiles.h (class all_objfiles): Remove.
11221         * objfiles.c (have_partial_symbols, have_full_symbols)
11222         (have_minimal_symbols, qsort_cmp, update_section_map)
11223         (shared_objfile_contains_address_p)
11224         (default_iterate_over_objfiles_in_search_order): Update.
11225         * objc-lang.c (info_selectors_command, info_classes_command)
11226         (find_methods): Update.
11227         * minsyms.c (find_solib_trampoline_target): Update.
11228         * maint.c (maintenance_info_sections)
11229         (maintenance_translate_address, count_symtabs_and_blocks):
11230         Update.
11231         * main.c (captured_main_1): Update.
11232         * linux-thread-db.c (try_thread_db_load_from_pdir)
11233         (has_libpthread): Update.
11234         * linespec.c (iterate_over_all_matching_symtabs)
11235         (search_minsyms_for_name): Update.
11236         * jit.c (jit_find_objf_with_entry_addr): Update.
11237         * hppa-tdep.c (find_unwind_entry)
11238         (hppa_lookup_stub_minimal_symbol): Update.
11239         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11240         Update.
11241         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11242         (elf_gnu_ifunc_resolve_by_got): Update.
11243         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11244         * dwarf-index-write.c (save_gdb_index_command): Update.
11245         * cp-support.c (add_symbol_overload_list_qualified): Update.
11246         * breakpoint.c (create_overlay_event_breakpoint)
11247         (create_longjmp_master_breakpoint)
11248         (create_std_terminate_master_breakpoint)
11249         (create_exception_master_breakpoint): Update.
11250         * blockframe.c (find_pc_partial_function): Update.
11251         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11252         (ada_collect_symbol_completion_matches)
11253         (ada_add_global_exceptions): Update.
11254
11255 2019-01-17  Tom Tromey  <tom@tromey.com>
11256
11257         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11258         declare VEC.
11259         (solib_target_parse_libraries): Change return type.
11260         (library_list_start_segment, library_list_start_section)
11261         (library_list_end_library, library_list_start_library); Update.
11262         (solib_target_free_library_list): Remove.
11263         (solib_target_parse_libraries): Remove cleanup.  Change return
11264         type.
11265         (solib_target_current_sos): Update.
11266
11267 2019-01-17  Tom Tromey  <tromey@bapiya>
11268
11269         * valprint.c: Replace "the the" with "the".
11270         * symtab.c: Replace "the the" with "the".
11271         * solib.c: Replace "the the" with "the".
11272         * solib-dsbt.c: Replace "the the" with "the".
11273         * linespec.c: Replace "the the" with "the".
11274         * dwarf2loc.h: Replace "the the" with "the".
11275         * amd64-windows-tdep.c: Replace "the the" with "the".
11276         * aarch64-tdep.c: Replace "the the" with "the".
11277
11278 2019-01-16  Keith Seitz  <keiths@redhat.com>
11279
11280         PR gdb/23773
11281         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11282         <builder>: Rename to ..
11283         <m_builder>: ... this and make private.
11284         (dwarf2_cu::get_builder): New method.  Change all users of
11285         `builder' to use this method.
11286         (dwarf2_start_symtab): Move to ...
11287         (dwarf2_cu::start_symtab): ... here.  Update all callers
11288         (setup_type_unit_groups): Move to ...
11289         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11290         callers.
11291         (dwarf2_cu::reset_builder): New method.
11292         (process_full_compunit, process_full_type_unit): Use
11293         dwarf2_cu::reset_builder.
11294         (follow_die_offset): Record the ancestor CU if it is different
11295         from the followed DIE's CU.
11296         (follow_die_sig_1): Likewise.
11297
11298 2019-01-15  Tom Tromey  <tom@tromey.com>
11299
11300         * remote.c (class remote_state) <buf>: Now a char_vector.
11301         <buf_size>: Remove.
11302         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11303         parameter.
11304         (remote_target::getpkt_or_notif_sane_1)
11305         (remote_target::getpkt_sane)
11306         (remote_target::getpkt_or_notif_sane): Likewise.
11307         (class remote_target) <putpkt>: New overload.
11308         (remote_target::read_frame): Change type of "buf_p".  Remove
11309         sizeof_p parameter.
11310         (packet_ok): New overload.
11311         (packet_check_result): New overload.
11312         Update all uses.
11313
11314 2019-01-14  Tom Tromey  <tom@tromey.com>
11315
11316         * remote-notif.c (handle_notification, remote_notif_ack)
11317         (remote_notif_parse): Make "buf" const.
11318         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11319         const.
11320         (remote_notif_parse, remote_notif_ack, handle_notification):
11321         Likewise.
11322         * remote.c (remote_notif_stop_parse): Make "buf" const.
11323         (remote_target::remote_parse_stop_reply): Make "buf" const.
11324         (remote_notif_stop_ack): Make "buf" const.
11325
11326 2019-01-14  Tom Tromey  <tom@tromey.com>
11327
11328         * remote.c (remote_console_output): Make parameter const.
11329
11330 2019-01-14  Tom Tromey  <tom@tromey.com>
11331
11332         * target-debug.h (target_debug_print_signals): Constify.
11333         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11334         * procfs.c (procfs_target::pass_signals): Update.
11335         * linux-nat.c (linux_nat_target::pass_signals): Update.
11336         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11337         * target-delegates.c: Rebuild.
11338         * remote.c (remote_target::program_signals): Update.
11339         (remote_target::pass_signals): Update.
11340         * target.c (target_pass_signals): Constify argument.
11341         (target_program_signals): Likewise.
11342         * target.h (struct target_ops) <pass_signals, program_signals>:
11343         Constify argument.
11344         (target_pass_signals, target_program_signals): Constify argument.
11345
11346 2019-01-14  Tom Tromey  <tom@tromey.com>
11347
11348         PR tui/28819:
11349         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11350
11351 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11352
11353         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11354         field.
11355         * rs6000-tdep.c: Include reggroups.h.
11356         (IS_V_ALIAS_PSEUDOREG): Define.
11357         (rs6000_register_name): Return names for the "vX" aliases.
11358         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11359         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11360         aliases.  Call default_register_reggroup_p for all other
11361         pseudo-registers.
11362         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11363         New functions.
11364         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11365         Handle "vX" aliases.
11366         (v_alias_pseudo_register_collect): New function.
11367         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11368         (rs6000_gdbarch_init): Initialize "vX" aliases as
11369         pseudo-registers.  Restore registration of
11370         rs6000_pseudo_register_reggroup_p with
11371         set_tdesc_pseudo_register_reggroup_p.
11372
11373 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11374
11375         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11376         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11377         set_gdbarch_num_pseudo_regs.
11378
11379 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11380
11381         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11382         Remove arg prefixname, add do_set and do_show.
11383         Add member functions set_list and show_list.
11384         * cli/cli-style.c (class cli_style_option): Update accordingly.
11385         (style_set_list): Move to file scope.
11386         (style_show_list): Likewise.
11387         (set_style): Call help_list.
11388         (show_style): Call cmd_show_list.
11389         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11390         Update to use the new macro.
11391
11392 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11393
11394         * ada-lang.c (_initialize_ada_language): Expand the help text
11395         for the "catch exception" command.
11396
11397 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11398
11399         * symtab.c (matching_obj_sections): Initialize obj,
11400         declare it closer to its usage.
11401
11402 2019-01-10  Tom Tromey  <tom@tromey.com>
11403
11404         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11405         (basic_inf_threads_range): Remove.
11406         (inf_threads_range, inf_non_exited_threads_range)
11407         (safe_inf_threads_range): Use next_adapter.
11408
11409 2019-01-10  Keith Seitz  <keiths@redhat.com>
11410
11411         PR gdb/23712
11412         PR symtab/23010
11413         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11414         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11415
11416 2019-01-10  Keith Seitz  <keiths@redhat.com>
11417
11418         PR gdb/23712
11419         PR symtab/23010
11420         * dictionary.c (pending_to_vector): Remove.
11421         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11422         Remove _1 suffix, replacing functions of the same name.  Update
11423         all callers.
11424         (dict_create_hashed, dict_create_hashed_expandable)
11425         (dict_create_linear, dict_create_linear_expandable, dict_free)
11426         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11427         Make functions static.
11428
11429 2019-01-10  Keith Seitz  <keiths@redhat.com>
11430
11431         PR gdb/23712
11432         PR symtab/23010
11433         * dictionary.h (struct dictionary): Replace declaration with
11434         multidictionary.
11435         (dict_create_hashed, dict_create_hashed_expandable)
11436         (dict_create_linear, dict_create_linear_expandable)
11437         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11438         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11439         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11440         taking multidictionary argument.
11441         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11442         * block.h (struct block) <dict>: Change to multidictionary
11443         and rename `multidict'.
11444         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11445         symmisc.c: Update all dictionary references to multidictionary.
11446
11447 2019-01-10  Keith Seitz  <keiths@redhat.com>
11448
11449         PR gdb/23712
11450         PR symtab/23010
11451         * dictionary.c: Include unordered_map.
11452         (pending_to_vector): New function.
11453         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11454         Rewrite the non-"_1" functions to take vector instead
11455         of linked list.
11456         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11457         "new" _1 versions of the same name.
11458         (multidictionary): Define.
11459         (std::hash<enum language): New definition.
11460         (collate_pending_symbols_by_language, mdict_create_hashed)
11461         (mdict_create_hashed_expandable, mdict_create_linear)
11462         (mdict_create_linear_expandable, mdict_free)
11463         (find_language_dictionary, create_new_language_dictionary)
11464         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11465         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11466         (mdict_size, mdict_empty): New functions.
11467         * dictionary.h (mdict_iterator): Define.
11468
11469 2019-01-10  Pedro Alves  <palves@redhat.com>
11470
11471         * breakpoint.c (read_uploaded_action)
11472         (create_tracepoint_from_upload): Adjust to use
11473         gdb::unique_xmalloc_ptr.
11474         * ctf.c (ctf_write_uploaded_tp):
11475         (SET_ARRAY_FIELD): Use emplace_back.
11476         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11477         * tracefile-tfile.c (tfile_write_uploaded_tp):
11478         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11479         gdb::unique_xmalloc_ptr.
11480         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11481         at_string, cond_string, cmd_strings>: Replace char pointers
11482         with gdb::unique_xmalloc_ptr.
11483
11484 2019-01-10  Pedro Alves  <palves@redhat.com>
11485
11486         * solib-target.c (library_list_start_library): Don't xstrdup name.
11487
11488 2019-01-10  Pedro Alves  <palves@redhat.com>
11489
11490         * mdebugread.c (parse_partial_symbols): Use
11491         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11492
11493 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11494
11495         * linux-fork.c (scoped_switch_fork_info)
11496         <~scoped_switch_fork_info>: Fix incorrect variable name.
11497
11498 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11499
11500         * linux-fork.c (scoped_switch_fork_info)
11501         <scoped_switch_fork_info>: Make explicit.
11502         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11503
11504 2019-01-10  Tom Tromey  <tom@tromey.com>
11505
11506         * objfiles.h (objfile::reset_psymtabs): Update.
11507         * objfiles.c (objfile::objfile): Update.
11508         * psymtab.h (psymtab_storage::obstack): Update.
11509         (psymtab_storage::m_obstack): Use gdb::optional.
11510         (class psymtab_storage): Update comment.  Remove objfile
11511         parameter.
11512         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11513
11514 2019-01-10  Tom Tromey  <tom@tromey.com>
11515
11516         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11517         <free_psymtabs>: Now private.
11518         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11519         (allocate_psymtab): Use new method.
11520
11521 2019-01-10  Tom Tromey  <tom@tromey.com>
11522
11523         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11524         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11525         * mdebugread.c (parse_partial_symbols): Use
11526         allocate_dependencies.
11527         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11528         allocate_dependencies.
11529         (process_psymtab_comp_unit_reader)
11530         (build_type_psymtab_dependencies): Likewise.
11531         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11532
11533 2019-01-10  Tom Tromey  <tom@tromey.com>
11534
11535         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11536         PSYMBOL_SET_LANGUAGE.
11537         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11538
11539 2019-01-10  Tom Tromey  <tom@tromey.com>
11540
11541         * psymtab.h (psymtab_storage::obstack): New method.
11542         <m_obstack>: Rename from obstack; now private.
11543         * psymtab.c (psymtab_storage): Update.
11544         * dwarf2read.c (create_addrmap_from_index)
11545         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11546         Update.
11547
11548 2019-01-10  Tom Tromey  <tom@tromey.com>
11549
11550         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11551         * objfiles.h (objfile::reset_psymtabs): New method.
11552
11553 2019-01-10  Tom Tromey  <tom@tromey.com>
11554
11555         * symmisc.c (print_symbol_bcache_statistics): Update.
11556         (print_objfile_statistics): Update.
11557         * symfile.c (reread_symbols): Update.
11558         * psymtab.h (class psymtab_storage): New.
11559         * psymtab.c (psymtab_storage): New constructor.
11560         (~psymtab_storage): New destructor.
11561         (require_partial_symbols): Update.
11562         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11563         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11564         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11565         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11566         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11567         (start_psymtab_common, end_psymtab_common)
11568         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11569         (allocate_psymtab): Update.
11570         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11571         Update.
11572         (dump_psymtab_addrmap, maintenance_print_psymbols)
11573         (maintenance_check_psymtabs): Update.
11574         (class objfile_psymtabs): Move to objfiles.h.
11575         * psympriv.h (discard_psymtab): Now inline.
11576         (psymtab_discarder::psymtab_discarder): Update.
11577         (psymtab_discarder::~psymtab_discarder): Update.
11578         (ALL_OBJFILE_PSYMTABS): Rewrite.
11579         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11580         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11581         Remove fields.
11582         <partial_symtabs>: New field.
11583         (class objfile_psymtabs): Move from psymtab.h.  Update.
11584         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11585         psymbol_cache.
11586         (objfile::~objfile): Don't destroy psymbol_cache.
11587         * mdebugread.c (parse_partial_symbols): Update.
11588         * dwarf2read.c (create_addrmap_from_index)
11589         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11590         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11591         (add_partial_subprogram, dwarf2_ranges_read): Update.
11592         * dwarf-index-write.c (write_address_map)
11593         (write_one_signatured_type, recursively_write_psymbols)
11594         (class debug_names, class debug_names, write_psymtabs_to_index):
11595         Update.
11596
11597 2019-01-10  Tom Tromey  <tom@tromey.com>
11598
11599         * symtab.h (SYMBOL_SET_NAMES): Update.
11600         (symbol_set_names): Update.
11601         (MSYMBOL_SET_NAMES): Update.
11602         * symtab.c (symbol_set_names): Change argument to be an
11603         objfile_per_bfd_storage.
11604         * psymtab.c (add_psymbol_to_bcache): Update.
11605         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11606
11607 2019-01-10  Tom Tromey  <tom@tromey.com>
11608
11609         * symtab.c (create_demangled_names_hash): Change argument to be an
11610         objfile_per_bfd_storage.
11611         (symbol_set_names): Update.
11612
11613 2019-01-10  Tom Tromey  <tom@tromey.com>
11614
11615         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11616         init_psymbol_list.
11617         * psymtab.c (init_psymbol_list): Do nothing if already called.
11618         * psympriv.h (init_psymbol_list): Add comment.
11619         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11620         init_psymbol_list.
11621         * dbxread.c (dbx_symfile_read): Unconditionally call
11622         init_psymbol_list.
11623
11624 2019-01-10  Tom Tromey  <tom@tromey.com>
11625
11626         * xcoffread.c (scan_xcoff_symtab): Update.
11627         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11628         "where".
11629         * mdebugread.c (parse_partial_symbols)
11630         (handle_psymbol_enumerators): Update.
11631         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11632         * dbxread.c (read_dbx_symtab): Update.
11633         * psympriv.h (psymbol_placement): New enum.
11634         (add_psymbol_to_list): Update.
11635
11636 2019-01-10  Tom Tromey  <tom@tromey.com>
11637
11638         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11639         static_psymbols parameters.
11640         (scan_xcoff_symtab): Update.
11641         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11642         static_psymbols parameters.
11643         * psympriv.h (start_psymtab_common): Update.
11644         * mdebugread.c (parse_partial_symbols): Update.
11645         * dwarf2read.c (create_partial_symtab): Update.
11646         * dbxread.c (read_dbx_symtab): Update.
11647         (start_psymtab): Remove global_psymbols and static_psymbols
11648         parameters.
11649
11650 2019-01-10  Tom Tromey  <tom@tromey.com>
11651
11652         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11653         * psymtab.c (allocate_psymtab): Add comment.
11654         * psympriv.h (allocate_psymtab): Add comment.
11655         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11656         initializations.
11657         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11658
11659 2019-01-10  Tom Tromey  <tom@tromey.com>
11660
11661         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11662         Don't declare.
11663         * mipsread.c: Include mdebugread.h.
11664         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11665         Declare.
11666         * elfread.c: Include mdebugread.h.
11667
11668 2019-01-09  Tom Tromey  <tom@tromey.com>
11669
11670         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11671         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11672         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11673         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11674         (psym_lookup_symbol, psym_find_last_source_symtab)
11675         (psym_forget_cached_source_info, psym_print_stats)
11676         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11677         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11678         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11679         (psym_find_compunit_symtab_by_address)
11680         (maintenance_print_psymbols, maintenance_info_psymtabs)
11681         (maintenance_check_psymtabs): Use ranged for.
11682         * psymtab.h (class objfile_psymtabs): New.
11683         (require_partial_symbols): Return objfile_psymtabs.
11684         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11685
11686 2019-01-09  Tom Tromey  <tom@tromey.com>
11687
11688         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11689         (find_pc_mapped_section, list_overlays_command)
11690         (map_overlay_command, unmap_overlay_command)
11691         (simple_overlay_update): Use all_objfiles.
11692         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11693         * printcmd.c (info_symbol_command): Use all_objfiles.
11694         * objfiles.h (ALL_OBJSECTIONS): Remove.
11695         * maint.c (maintenance_translate_address): Use all_objfiles.
11696         * gcore.c (gcore_create_callback): Use all_objfiles.
11697         (objfile_find_memory_regions): Likewise.
11698
11699 2019-01-09  Tom Tromey  <tom@tromey.com>
11700
11701         * symtab.c (find_line_symtab, info_sources_command)
11702         (make_source_files_completion_list): Use objfile_compunits.
11703         * source.c (select_source_symtab): Use objfile_compunits.
11704         * objfiles.h (struct objfile): Update comment.
11705         (ALL_OBJFILES): Remove.
11706         (ALL_FILETABS): Remove.
11707         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11708         objfile_compunits.
11709
11710 2019-01-09  Tom Tromey  <tom@tromey.com>
11711
11712         * symmisc.c (print_objfile_statistics, dump_objfile)
11713         (maintenance_print_symbols): Use compunit_filetabs.
11714         * source.c (forget_cached_source_info_for_objfile): Use
11715         compunit_filetabs.
11716         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11717         (ALL_FILETABS): Use compunit_filetabs.
11718         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11719         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11720
11721 2019-01-09  Tom Tromey  <tom@tromey.com>
11722
11723         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11724         (compunit_filetabs): New.
11725         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11726         compunit_filetabs.
11727         (info_sources_command, make_source_files_completion_list): Remove
11728         declaration.
11729         * symmisc.c (print_objfile_statistics, dump_objfile)
11730         (maintenance_print_symbols): Remove declaration.
11731         (maintenance_info_symtabs): Use compunit_filetabs.
11732         (maintenance_info_line_tables): Likewise.
11733         * source.c (select_source_symtab): Change local variable name.
11734         (forget_cached_source_info_for_objfile): Remove declaration.
11735         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11736         * objfiles.c (objfile_relocate1): Remove declaration.
11737         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11738         declaration.
11739         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11740         * coffread.c (coff_symtab_read): Remove declaration.
11741         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11742         compunit_filetabs.
11743
11744 2019-01-09  Tom Tromey  <tom@tromey.com>
11745
11746         * symtab.c (lookup_objfile_from_block)
11747         (find_pc_sect_compunit_symtab, search_symbols)
11748         (default_collect_symbol_completion_matches_break_on): Use
11749         objfile_compunits.
11750         * objfiles.h (ALL_COMPUNITS): Remove.
11751         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11752         * cp-support.c (add_symbol_overload_list_qualified): Use
11753         objfile_compunits.
11754         * ada-lang.c (ada_collect_symbol_completion_matches)
11755         (ada_add_global_exceptions): Use objfile_compunits.
11756
11757 2019-01-09  Tom Tromey  <tom@tromey.com>
11758
11759         * source.c (select_source_symtab)
11760         (forget_cached_source_info_for_objfile): Remove declaration.
11761         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11762         declaration.
11763         * maint.c (count_symtabs_and_blocks): Remove declaration.
11764         * cp-support.c (add_symbol_overload_list_qualified): Remove
11765         declaration.
11766         * coffread.c (coff_symtab_read): Remove declaration.
11767         * symtab.c (lookup_symbol_in_objfile_symtabs)
11768         (basic_lookup_transparent_type_1): Use objfile_compunits.
11769         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11770         (info_sources_command, search_symbols)
11771         (default_collect_symbol_completion_matches_break_on)
11772         (make_source_files_completion_list): Remove declaration.
11773         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11774         (ada_collect_symbol_completion_matches)
11775         (ada_add_global_exceptions): Remove declaration.
11776         * linespec.c (iterate_over_all_matching_symtabs): Use
11777         objfile_compunits.
11778         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11779         (class objfile_compunits): New.
11780         (ALL_COMPUNITS): Use objfile_compunits.
11781         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11782         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11783         objfile_compunits.
11784         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11785
11786 2019-01-09  Tom Tromey  <tom@tromey.com>
11787
11788         * symtab.c (search_symbols)
11789         (default_collect_symbol_completion_matches_break_on): Use
11790         objfile_msymbols.
11791         * ada-lang.c (ada_lookup_simple_minsym)
11792         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11793         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11794         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11795         objfile_msymbols.
11796         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11797         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11798         * objc-lang.c (find_methods): Use objfile_msymbols.
11799         (info_selectors_command, info_classes_command): Likewise.
11800         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11801         * objfiles.h (class objfile_msymbols): New.
11802         (ALL_OBJFILE_MSYMBOLS): Remove.
11803         (ALL_MSYMBOLS): Remove.
11804
11805 2019-01-09  Tom Tromey  <tom@tromey.com>
11806
11807         * common/next-iterator.h (next_adapter): Add Iterator template
11808         parameter.
11809         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11810         (class all_objfiles_safe): New.
11811         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11812         * objfiles.c (put_objfile_before): Update comment.
11813         (add_separate_debug_objfile): Likewise.
11814         (free_all_objfiles): Use all_objfiles_safe.
11815         (objfile_purge_solibs): Likewise.
11816
11817 2019-01-09  Tom Tromey  <tom@tromey.com>
11818
11819         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11820         (expand_symtab_containing_pc, lookup_static_symbol)
11821         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11822         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11823         all_objfiles.
11824         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11825         * breakpoint.c (create_overlay_event_breakpoint)
11826         (create_longjmp_master_breakpoint)
11827         (create_std_terminate_master_breakpoint)
11828         (create_exception_master_breakpoint): Use all_objfiles.
11829         * linux-thread-db.c (try_thread_db_load_from_pdir)
11830         (has_libpthread): Use all_objfiles.
11831         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11832         * linespec.c (iterate_over_all_matching_symtabs)
11833         (search_minsyms_for_name): Use all_objfiles.
11834         * maint.c (maintenance_info_sections): Use all_objfiles.
11835         * main.c (captured_main_1): Use all_objfiles.
11836         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11837         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11838         * guile/scm-pretty-print.c
11839         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11840         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11841         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11842         (maintenance_print_msymbols): Use all_objfiles.
11843         * source.c (select_source_symtab): Use all_objfiles.
11844         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11845         * symfile.c (remove_symbol_file_command)
11846         (expand_symtabs_matching, map_symbol_filenames): Use
11847         all_objfiles.
11848         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11849         all_objfiles.
11850         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11851         * objc-lang.c (find_methods): Use all_objfiles.
11852         * objfiles.c (have_partial_symbols, have_full_symbols)
11853         (have_minimal_symbols, qsort_cmp)
11854         (default_iterate_over_objfiles_in_search_order): Use
11855         all_objfiles.
11856         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11857         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11858         (maintenance_check_psymtabs): Use all_objfiles.
11859         (ALL_PSYMTABS): Remove.
11860         * compile/compile-object-run.c (do_module_cleanup): Use
11861         all_objfiles.
11862         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11863         * cp-support.c (add_symbol_overload_list_qualified): Use
11864         all_objfiles.
11865         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11866         Use all_objfiles.
11867         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11868         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11869         all_objfiles.
11870         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11871         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11872         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11873         Uses all_objfiles.
11874         * solib.c (solib_read_symbols): Use all_objfiles
11875
11876 2019-01-09  Tom Tromey  <tom@tromey.com>
11877
11878         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11879         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11880         all_objfiles.
11881         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11882         * symmisc.c (print_symbol_bcache_statistics)
11883         (print_objfile_statistics, maintenance_print_objfiles)
11884         (maintenance_info_symtabs, maintenance_check_symtabs)
11885         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11886         all_objfiles.
11887         * source.c (forget_cached_source_info): Use all_objfiles.
11888         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11889         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11890         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11891         * objfiles.c (update_section_map): Use all_objfiles.
11892         (shared_objfile_contains_address_p): Likewise.
11893         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11894         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11895
11896 2019-01-09  Tom Tromey  <tom@tromey.com>
11897
11898         * common/next-iterator.h: New file.
11899         * objfiles.h (class all_objfiles): New.
11900         (struct objfile_iterator): New.
11901
11902 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11903
11904         * NEWS: Move the description of the changed "frame", "select-frame",
11905          and "info frame" commands to the Changed commands section.
11906
11907 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11908
11909         * gdbtypes.c (check_stub_method_group): Remove handling of old
11910         mangling schemes.
11911         * linespec.c (find_methods): Likewise.
11912         * stabsread.c (read_member_functions): Likewise.
11913         * valops.c (search_struct_method): Likewise.
11914         (value_struct_elt_for_reference): Likewise.
11915         * NEWS: Mention this change.
11916
11917 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11918
11919         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11920         print_source_lines.
11921         * source.c (print_source_lines_base): Update line number check.
11922         (print_source_lines): New function.
11923         (source_lines_range::source_lines_range): New function.
11924         * source.h (class source_lines_range): New class.
11925         (print_source_lines): New declaration.
11926
11927 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11928
11929         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11930
11931 2019-01-08  Tom Tromey  <tom@tromey.com>
11932             Simon Marchi  <simon.marchi@ericsson.com>
11933
11934         PR gdb/24060
11935         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11936         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11937         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11938         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11939         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11940         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11941
11942 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11943
11944         * source.c (select_source_symtab): Move header comment to
11945         declaration in source.h.
11946         (forget_cached_source_info_for_objfile): Likewise.
11947         (forget_cached_source_info): Likewise.
11948         (identify_source_line): Likewise.
11949         * source.h (identify_source_line): Move declaration from symtab.h
11950         and add comment from source.c
11951         (print_source_lines): Likewise.
11952         (forget_cached_source_info_for_objfile): Likewise.
11953         (forget_cached_source_info): Likewise.
11954         (select_source_symtab): Likewise.
11955         (enum print_source_lines_flag): Move definition from symtab.h.
11956         * symtab.h (identify_source_line): Move declaration to source.h.
11957         (print_source_lines): Likewise.
11958         (forget_cached_source_info_for_objfile): Likewise.
11959         (forget_cached_source_info): Likewise.
11960         (select_source_symtab): Likewise.
11961         (enum print_source_lines_flag): Move definition to source.h.
11962         * tui/tui-hooks.c: Add 'source.h' include.
11963
11964 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11965
11966         * source.c (print_source_lines_base): Handle requests to print
11967         reverse line number sequences, and guard against empty lines
11968         string.
11969
11970 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11971
11972         * source.c (print_source_lines_base): Fix skip of '\r' if next
11973         character is '\n'.
11974
11975 2019-01-06  Tom Tromey  <tom@tromey.com>
11976
11977         * c-exp.y (struct c_parse_state) <macro_original_text,
11978         expansion_obstack>: New member.
11979         (macro_original_text, expansion_obstack): Remove globals.
11980         (scan_macro_expansion, scanning_macro_expansion)
11981         (finished_macro_expansion): Update.
11982         (scan_macro_cleanup): Remove.
11983         (yylex, c_parse): Update.
11984
11985 2019-01-06  Tom Tromey  <tom@tromey.com>
11986
11987         * c-exp.y (struct c_parse_state) <strings>: New member.
11988         (operator_stoken): Update.
11989
11990 2019-01-06  Tom Tromey  <tom@tromey.com>
11991
11992         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11993         (union type_stack_elt) <typelist_val>: Now a pointer to
11994         std::vector.
11995         (type_stack_cleanup): Don't declare.
11996         (push_typelist): Update.
11997         * parse.c (pop_typelist): Return a std::vector.
11998         (push_typelist): Take a std::vector.
11999         (follow_types): Update.  Do not free args.
12000         (type_stack_cleanup): Remove.
12001         * c-exp.y (struct c_parse_state): New.
12002         (cpstate): New global.
12003         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12004         (nonempty_typelist): Update.
12005         (func_mod): Create a new vector.
12006         (c_parse): Create a c_parse_state.
12007         (check_parameter_typelist): Do not delete params.
12008         (function_method): Update.  Do not delete type_list.
12009
12010 2019-01-06  Tom Tromey  <tom@tromey.com>
12011
12012         PR gdb/28155:
12013         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12014         check_typedef.
12015         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12016         (print_return_value): Likewise.
12017
12018 2019-01-05  Tom Tromey  <tom@tromey.com>
12019
12020         * contrib/cleanup_check.py: Remove.
12021         * contrib/gcc-with-excheck: Remove.
12022         * contrib/exsummary.py: Remove.
12023         * contrib/excheck.py: Remove.
12024
12025 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12026
12027         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12028         NULL. Initialize tpprev to NULL instead of assigning it
12029         to NULL on the next statement.
12030         * windows-nat.c (windows_delete_thread): Remove check for
12031         main_thread_id before printing thread exit notifications.
12032         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12033         Remove thread ID check against main_thread_id.
12034         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12035         windows_delete_thread.
12036         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12037
12038 2019-01-04  Tom Tromey  <tom@tromey.com>
12039
12040         * compile/compile.c (_initialize_compile): Use upper case for
12041         metasyntactic variables.
12042         * symmisc.c (_initialize_symmisc): Use upper case for
12043         metasyntactic variables.
12044         * psymtab.c (_initialize_psymtab): Use upper case for
12045         metasyntactic variables.
12046         * demangle.c (demangle_command): Use upper case for metasyntactic
12047         variables.
12048         (_initialize_demangler): Likewise.
12049         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12050         variables.
12051
12052 2019-01-03  Tom Tromey  <tom@tromey.com>
12053
12054         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12055
12056 2019-01-03  Tom Tromey  <tom@tromey.com>
12057
12058         * python/py-symtab.c (salpy_str): Update.
12059         (struct salpy_sal_object) <symtab>: Now a PyObject.
12060         (salpy_dealloc): Update.
12061         (del_objfile_sal): Use gdbpy_ref.
12062
12063 2019-01-03  Tom Tromey  <tom@tromey.com>
12064
12065         * python/py-type.c (convert_field): Use new_reference.  Return
12066         gdbpy_ref.
12067         (make_fielditem): Return gdbpy_ref.
12068         (typy_fields): Update.
12069         (typy_getitem): Update.
12070         (field_name): Return gdbpy_ref.  Use new_reference.
12071         (typy_iterator_iternext): Update.
12072
12073 2019-01-03  Tom Tromey  <tom@tromey.com>
12074
12075         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12076
12077 2019-01-03  Tom Tromey  <tom@tromey.com>
12078
12079         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12080         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12081         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12082         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12083         (pspy_set_type_printers): Likewise.
12084         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12085         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12086         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12087         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12088         (objfpy_set_type_printers): Likewise.
12089
12090 2019-01-03  Tom Tromey  <tom@tromey.com>
12091
12092         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12093         (gdbpy_print_stack): Use gdbpy_err_fetch.
12094         * python/python-internal.h (class gdbpy_err_fetch): New class.
12095         (class gdbpy_enter) <m_error_type, m_error_value,
12096         m_error_traceback>: Remove.
12097         <m_error>: New member.
12098         (gdbpy_exception_to_string): Don't declare.
12099         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12100         * python/py-value.c (convert_value_from_python): Use
12101         gdbpy_err_fetch.
12102         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12103         gdbpy_exception_to_string.
12104         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12105         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12106         gdbpy_err_fetch.
12107
12108 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12109
12110         * linux-nat.c (delete_lwp_cleanup): Delete.
12111         (struct lwp_deleter): New struct.
12112         (lwp_info_up): New typedef.
12113         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12114         lwp_info_up.
12115
12116 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12117
12118         * linux-fork.c (class scoped_switch_fork_info): New class.
12119         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12120
12121 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12122
12123         * valops.c (find_overload_match): Remove use of null_cleanup, and
12124         calls to do_cleanups.
12125
12126 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12127
12128         * compile/compile-cplus-types.c
12129         (compile_cplus_instance::decl_name): Handle changes to
12130         cp_func_name.
12131         * cp-support.c (cp_func_name): Update header comment, update
12132         return type.
12133         * cp-support.h (cp_func_name): Update return type in declaration.
12134         * valops.c (find_overload_match): Move temp_func local to top
12135         level of function and change its type.  Use temp_func to hold and
12136         delete temporary string obtained from cp_func_name.
12137
12138 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12139
12140         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12141         gdb::char_vector, remove cleanup, and update uses of `msg`.
12142
12143 2019-01-03  Jim Wilson  <jimw@sifive.com>
12144
12145         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12146
12147 2019-01-02  Tom Tromey  <tom@tromey.com>
12148
12149         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12150         (tdesc_parse_xml): Remove cleanups.
12151         * target-descriptions.h (make_cleanup_free_target_description):
12152         Don't declare.
12153         (target_desc_deleter): New struct.
12154         (target_desc_up): New typedef.
12155         * target-descriptions.c (target_desc_deleter::operator()): Rename
12156         from free_target_description.
12157         (make_cleanup_free_target_description): Remove.
12158
12159 2019-01-02  Tom Tromey  <tom@tromey.com>
12160
12161         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12162         constructor, destructor.
12163         (linespec_parser): Remove typedef.
12164         (~linespec_parser): Rename from linespec_parser_delete.
12165         (linespec_lex_to_end, linespec_complete_label)
12166         (linespec_complete): Update.
12167         (decode_line_full): Remove cleanups.
12168         (decode_line_1): Update.
12169
12170 2019-01-02  Tom Tromey  <tom@tromey.com>
12171
12172         * python/python-internal.h (inferior_to_inferior_object): Change
12173         return type.
12174         * python/py-exitedevent.c (create_exited_event_object): Update.
12175         * python/py-inferior.c (inferior_to_inferior_object): Return
12176         gdbpy_ref.
12177         (python_new_inferior, python_inferior_deleted)
12178         (thread_to_thread_object, delete_thread_object)
12179         (build_inferior_list, gdbpy_selected_inferior): Update.
12180         * python/py-infthread.c (create_thread_object): Update.  Also fail
12181         if inferior_to_inferior_object fails.
12182
12183 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12184
12185         * inferior.h (class inferior) <displaced_step_state>: New field.
12186         * infrun.h (struct displaced_step_state): Move here from
12187         infrun.c.  Initialize fields, add constructor.
12188         <inf>: Remove field.
12189         <reset>: New method.
12190         * infrun.c (struct displaced_step_inferior_state): Move to
12191         infrun.h.
12192         (displaced_step_inferior_states): Remove.
12193         (get_displaced_stepping_state): Adust.
12194         (displaced_step_in_progress_any_inferior): Adjust.
12195         (displaced_step_in_progress_thread): Adjust.
12196         (displaced_step_in_progress): Adjust.
12197         (add_displaced_stepping_state): Remove.
12198         (get_displaced_step_closure_by_addr): Adjust.
12199         (remove_displaced_stepping_state): Remove.
12200         (infrun_inferior_exit): Call displaced_step_state.reset.
12201         (use_displaced_stepping): Don't check for NULL.
12202         (displaced_step_prepare_throw): Call
12203         get_displaced_stepping_state.
12204         (displaced_step_fixup): Don't check for NULL.
12205         (prepare_for_detach): Don't check for NULL.
12206
12207 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12208
12209         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12210          in case of call that did not complete.
12211
12212 2019-01-02  Andrey Utkin  <autkin@undo.io>
12213
12214         * symfile.c (find_separate_debug_file): Fix search of debug files for
12215         remote debuggee.
12216
12217 2019-01-02  Tom Tromey  <tom@tromey.com>
12218
12219         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12220         indentation.
12221         * python/py-frame.c (frapy_older): Remove cast.
12222         (frapy_newer): Likewise.
12223         * python/py-breakpoint.c (local_setattro): Remove cast.
12224         * python/py-arch.c (archpy_name): Remove local variable.
12225         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12226
12227 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12228
12229         * unittests/basic_string_view/element_access/char/empty.cc:
12230         Fix year range in copyright header.
12231
12232 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12233
12234         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12235         Delete.
12236         <operator==>: Update with for removed field.
12237         <hash>: Likewise.
12238         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12239         <isa_features>: ...this.
12240         <abi_features>: New field.
12241         (riscv_isa_flen): Update comment.
12242         (riscv_abi_xlen): New declaration.
12243         (riscv_abi_flen): New declaration.
12244         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12245         isa_features.
12246         (riscv_abi_xlen): New function.
12247         (riscv_isa_flen): Update to get answer from isa_features.
12248         (riscv_abi_flen): New function.
12249         (riscv_has_fp_abi): Update to get answer from abi_features.
12250         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12251         xlen and flen.
12252         (riscv_call_info) <xlen, flen>: Update comment.
12253         (riscv_call_arg_struct): Remove invalid assertions
12254         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12255         is removed.
12256         (riscv_gdbarch_init): Gather isa features and abi features
12257         separately, ensure both match on the gdbarch when reusing an old
12258         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12259         a target with 64-bit float hardware.
12260
12261 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12262
12263         * source.c (search_command_helper): Stop reverse search
12264         when line 1 has been searched.
12265
12266 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12267
12268         * record-full.c (record_full_base_target::close): Rewrite
12269         record_full_core_buf_list free logic.
12270
12271 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12272
12273         * break-catch-syscall.c (print_one_catch_syscall): xfree
12274         the last text.
12275
12276 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12277
12278         * top.c (print_gdb_version): Update Copyright year in version
12279         message.
12280
12281 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12282
12283         Update copyright year range in all GDB files.
12284
12285 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12286
12287         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12288
12289 For older changes see ChangeLog-2018.
12290 \f
12291 Local Variables:
12292 mode: change-log
12293 left-margin: 8
12294 fill-column: 74
12295 version-control: never
12296 coding: utf-8
12297 End:
12298