gdb/ChangeLog

   1 2019-11-08  Tom Tromey  <tromey@adacore.com>
   2
   3         * top.c (read_command_file): Update.
   4         (command_line_input): Make return type const.
   5         * python/py-gdb-readline.c: Update.
   6         * linespec.c (decode_line_2): Update.
   7         * defs.h (command_line_input): Make return type const.
   8         * cli/cli-script.c (read_next_line): Make return type const.
   9         * ada-lang.c (get_selections): Update.
  10
  11 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
  12
  13         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
  14         * mi/mi-main.c (output_cores): Likewise.
  15         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
  16         (linux_xfer_osdata_modules): Likewise.
  17         * remote.c (register_remote_support_xml): Likewise.
  18         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
  19         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
  20
  21 2019-11-06  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-interp.c: Don't include readline.h.
  24         * tui/tui-hooks.c: Don't include readline.h.
  25         * symmisc.c: Include tilde.h, not readline.h.
  26         * symfile.c: Include tilde.h, not readline.h.
  27         * source.c: Include tilde.h, not readline.h.
  28         * solib.c: Include tilde.h, not readline.h.
  29         * psymtab.c: Include tilde.h, not readline.h.
  30         * exec.c: Include tilde.h, not readline.h.
  31         * corelow.c: Include tilde.h, not readline.h.
  32         * cli/cli-dump.c: Include tilde.h, not readline.h.
  33         * cli/cli-cmds.c: Don't include readline.h.
  34
  35 2019-11-05  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
  38         (tui_disassemble): Set addr_size.
  39         (tui_disasm_window::set_contents): Use addr_size.
  40
  41 2019-11-05  Tom Tromey  <tom@tromey.com>
  42
  43         * rust-lang.c (rust_language_defn): Update.
  44         * python/py-value.c (valpy_string): Call c_get_string.
  45         * p-lang.c (pascal_language_defn): Update.
  46         * opencl-lang.c (opencl_language_defn): Update.
  47         * objc-lang.c (objc_language_defn): Update.
  48         * m2-lang.c (m2_language_defn): Update.
  49         * language.c (unknown_language_defn, auto_language_defn): Update.
  50         (default_get_string): Remove.
  51         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
  52         * go-lang.c (go_language_defn): Update.
  53         * f-lang.c (f_language_defn): Update.
  54         * d-lang.c (d_language_defn): Update.
  55         * c-lang.c (c_language_defn, cplus_language_defn)
  56         (asm_language_defn, minimal_language_defn): Update.
  57         * ada-lang.c (ada_language_defn): Update.
  58         * language.h (struct language_defn) <la_get_string>: Remove.
  59         (LA_GET_STRING): Remove.
  60         (default_get_string): Don't declare.
  61
  62 2019-11-05  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-source.h (struct tui_source_window): Inline
  65         constructor.  Remove destructor.
  66         <style_changed, m_observable>: Move to superclass.
  67         * tui/tui-winsource.h (tui_copy_source_line): Declare.
  68         (struct tui_source_window_base): Move private members to end.
  69         <style_changed, m_observable>: Move from tui_source_window.
  70         * tui/tui-winsource.c (tui_copy_source_line): Move from
  71         tui-source.c.  Rename from copy_source_line.  Add special handling
  72         for negative line number.
  73         (tui_source_window_base::style_changed): Move from
  74         tui_source_window.
  75         (tui_source_window_base): Register observer.
  76         (~tui_source_window_base): New.
  77         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
  78         rename.
  79         (tui_source_window::set_contents): Use tui_copy_source_line.
  80         (tui_source_window::tui_source_window): Move to tui-source.h.
  81         (tui_source_window::~tui_source_window): Remove.
  82         (tui_source_window::style_changed): Move to superclass.
  83         * tui/tui-disasm.c (tui_disassemble): Create string file with
  84         styling, when possible.  Add "addr_size" parameter.
  85         (tui_disasm_window::set_contents): Use tui_copy_source_line.
  86         Don't compute maximum size.
  87         (len_without_escapes): New function
  88
  89 2019-11-05  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
  92         std::string.
  93         * tui/tui-winsource.c (tui_show_source_line): Update.
  94         * tui/tui-source.c (tui_source_window::set_contents): Update.
  95         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  96
  97 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
  98
  99         * symtab.h (gdb_static_assert): Put && operator at the beginning
 100         of the line instead of the end.
 101
 102 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 103
 104         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 105         and sizeof (symbol).
 106         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 107
 108 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 109
 110         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 111         * configure.host: Mark *-*-solaris2.10* obsolete.
 112         * configure.tgt: Mark Solaris < 11 obsolete.
 113         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 114         Update target triplet.
 115
 116 2019-11-01  Tom Tromey  <tromey@adacore.com>
 117
 118         * utils.c (print_sys_errmsg): Simplify.
 119
 120 2019-11-01  Tom Tromey  <tromey@adacore.com>
 121
 122         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 123
 124 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 125
 126         * configure: Regenerate.
 127         * configure.ac: Remove check for strerror_r.
 128         * gdbsupport/common.m4: Check for strerror_r.
 129
 130 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 131
 132         PR gdb/25124
 133
 134         * arm-tdep.c (arm_per_objfile): Rename to ...
 135         (arm_per_bfd): ... this.
 136         (arm_objfile_data_key): Rename to ...
 137         (arm_bfd_data_key): ... this.
 138         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 139         data.
 140         (arm_record_special_symbol): Likewise.
 141
 142 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 143
 144         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 145         end.
 146         * c-typeprint.c (c_print_typedef): Likewise.
 147         * f-typeprint.c (f_print_typedef): Likewise.
 148         * m2-typeprint.c (m2_print_typedef): Likewise.
 149         * p-typeprint.c (pascal_print_typedef): Likewise.
 150         * rust-lang.c (rust_print_typedef): Likewise.
 151         * symtab.c (print_symbol_info): Print a newline after calling
 152         typedef_print.
 153
 154 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 155
 156         * symtab.c (info_module_cmdlist): New variable.
 157         (info_module_command): New function.
 158         (search_module_symbols): New function.
 159         (info_module_subcommand): New function.
 160         (struct info_modules_var_func_options): New struct.
 161         (info_modules_var_func_options_defs): New variable.
 162         (make_info_modules_var_func_options_def_group): New function.
 163         (info_module_functions_command): New function.
 164         (info_module_variables_command): New function.
 165         (info_module_var_func_command_completer): New function.
 166         (_initialize_symtab): Register new 'info module functions' and
 167         'info module variables' commands.
 168         * symtab.h (typedef symbol_search_in_module): New typedef.
 169         (search_module_symbols): Declare new function.
 170         * NEWS: Mention new commands.
 171
 172 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 173
 174         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 175         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 176         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 177         MODULES_DOMAIN.
 178         (scan_partial_symbols): Only create partial module symbols for non
 179         declarations.
 180         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 181         and MODULES_DOMAIN.
 182         * symtab.c (search_domain_name): Likewise.
 183         (search_symbols): Likewise.
 184         (print_symbol_info): Likewise.
 185         (symtab_symbol_info): Likewise.
 186         (info_modules_command): New function.
 187         (_initialize_symtab): Register 'info modules' command.
 188         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 189         * NEWS: Mention new 'info modules' command.
 190
 191 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 192
 193         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 194         and $_gdb_maint_setting_str.
 195
 196 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 197
 198         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 199         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 200         (str_value_from_setting, gdb_setting_str_internal_fn)
 201         (gdb_maint_setting_str_internal_fn): New functions.
 202         (_initialize_cli_cmds): Define the new convenience functions.
 203         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 204         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 205
 206 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 207
 208         * agent.c (set_can_use_agent): When the setting is turned on,
 209         look up agent symbols if we don't have them yet.
 210         (agent_new_objfile): Don't look up agent symbols when the agent
 211         setting is off.
 212
 213 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 214
 215         * config.in: Regenerate.
 216
 217 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 218
 219         * configure: Regenerate.
 220         * configure.ac: Check for strerror_r.
 221         * gdbsupport/common-utils.h (safe_strerror): Change return value
 222         to const char * and document that this function is now threadsafe.
 223         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 224         thread_local and call strerror_r, if available.
 225         * utils.c (perror_string): Update.
 226         (print_sys_errmsg): Update.
 227
 228 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 229
 230         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 231         objfile_key.
 232         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 233         objfile to fetch per-bfd data.
 234         (arm_find_exidx_entry): Likewise.
 235
 236 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 237
 238         * gdbsupport/agent.c (debug_agent): Change type to bool.
 239         (use_agent): Likewise.
 240         (all_agent_symbols_look_up): Likewise.
 241         (agent_loaded_p): Change return value to bool.
 242         (agent_look_up_symbols): Update.
 243         (agent_capability_check): Change return value to bool.
 244         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 245         (debug_agent): Change type to bool.
 246         (use_agent): Likewise.
 247         (agent_capability_check): Change return value to bool.
 248
 249 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 250
 251         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 252         (build_minimal_symbol_hash_tables): Code to clear the table moved
 253         to clear_minimal_symbol_hash_tables.
 254         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 255         when needed.
 256
 257 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 258
 259         * infcmd.c: Remove includes.
 260         * infrun.c: Remove includes.
 261
 262 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 263
 264         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 265         (grow_vect): Remove declaration.
 266         (ada_type_of_array): Remove declaration.
 267         (ada_update_initial_language): Remove declaration.
 268         (ada_fold_name): Remove declaration.
 269         (ada_fill_in_ada_prototype): Remove declaration.
 270         (user_select_syms): Remove declaration.
 271         (get_selections): Remove declaration.
 272         (ada_tag_type): Remove declaration.
 273         (ada_value_tag): Remove declaration.
 274         (ada_is_others_clause): Remove declaration.
 275         (ada_in_variant): Remove declaration.
 276         (ada_value_struct_elt): Remove declaration.
 277         (ada_attribute_name): Remove declaration.
 278         (ada_system_address_type): Remove declaration.
 279         * ada-lang.c (ada_watch_location_expression): Make static.
 280         (GROW_VECT): Move here from ada-lang.h.
 281         (grow_vect): Make static.
 282         (ada_update_initial_language): Make static.
 283         (ada_fold_name): Make static.
 284         (ada_type_of_array): Make static.
 285         (encoded_ordered_before): Move up.
 286         (sort_choices): Move up.
 287         (print_signatures): Move up.
 288         (ada_print_symbol_signature): Move up.
 289         (get_selections): Move up and make static.
 290         (user_select_syms): Move up and make static.
 291         (ada_value_struct_elt): Move up and make static.
 292         (ada_tag_type): Make static.
 293         (ada_value_tag): Make static.
 294         (ada_is_others_clause): Make static.
 295         (ada_in_variant): Make static.
 296         (ada_attribute_name): Make static.
 297
 298 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 299
 300         * ada-lang.c: Remove includes.
 301         * ada-typeprint.c: Remove includes.
 302         * ada-valprint.c: Remove includes.
 303
 304 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 305
 306         * addrmap.c: Add static assertions of type size, moved from
 307         _initialize_addrmap.
 308         (_initialize_addrmap): Remove.
 309
 310 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 311
 312         * coffread.c (record_minimal_symbol): Update.
 313         (process_coff_symbol): Update.
 314         * dbxread.c (read_dbx_symtab): Update.
 315         * dwarf2read.c (add_partial_symbol): Update.
 316         (fixup_go_packaging): Update.
 317         (load_partial_dies): Update.
 318         (new_symbol): Update.
 319         * elfread.c (record_minimal_symbol): Change signature to use
 320         gdb::string_view instead of name+len.
 321         (elf_symtab_read): Update.
 322         (elf_rel_plt_read): Update.
 323         * mdebugread.c (parse_partial_symbols): Update.
 324         (handle_psymbol_enumerators): Update.
 325         (new_symbol): Update.
 326         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 327         to use gdb::string_view instead of name+len.
 328         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 329         * psympriv.h (add_psymbol_to_list): Likewise.
 330         * psymtab.c (add_psymbol_to_bcache): Likewise.
 331         (add_psymbol_to_list): Likewise.
 332         * stabsread.c (define_symbol): Update.
 333         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 334         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 335         (symbol_set_names): Likewise.
 336         * xcoffread.c (scan_xcoff_symtab): Update.
 337
 338 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 339
 340         * symtab.h (symbol_set_names): Document that copy_name must be
 341         set to true for non-nullterminated strings.
 342         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 343         linkage_name if the entry was not found and we need to demangle.
 344
 345 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 346
 347         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 348         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 349         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 350         * gdbsupport/gdb_binary_search.h: New file.
 351
 352 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 353
 354         * NEWS: Mention new --with-system-gdbinit-dir option.
 355         * config.in: Regenerate.
 356         * configure: Regenerate.
 357         * configure.ac: Add new option --with-system-gdbinit-dir.
 358         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 359         for a ".gdb" suffix.
 360         * main.c (get_init_files): Change system_gdbinit argument to
 361         a vector and return the files in SYSTEM_GDBINIT_DIR in
 362         addition to SYSTEM_GDBINIT.
 363         (captured_main_1): Update.
 364         (print_gdb_help): Update.
 365         * top.c (print_gdb_configuration): Also print the value of
 366         SYSTEM_GDBINIT_DIR.
 367
 368 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 369
 370         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 371         that takes gdb::string_view arguments.
 372
 373 2019-10-26  Tom de Vries  <tdevries@suse.de>
 374
 375         * aarch64-linux-tdep.c: Fix typos in comments.
 376         * aarch64-tdep.c: Same.
 377         * ada-lang.c: Same.
 378         * amd64-nat.c: Same.
 379         * arc-tdep.c: Same.
 380         * arch/aarch64-insn.c: Same.
 381         * block.c: Same.
 382         * breakpoint.h: Same.
 383         * btrace.h: Same.
 384         * c-varobj.c: Same.
 385         * cli/cli-decode.c: Same.
 386         * cli/cli-script.c: Same.
 387         * cli/cli-utils.h: Same.
 388         * coff-pe-read.c: Same.
 389         * coffread.c: Same.
 390         * compile/compile-cplus-symbols.c: Same.
 391         * compile/compile-object-run.c: Same.
 392         * completer.c: Same.
 393         * corelow.c: Same.
 394         * cp-support.c: Same.
 395         * demangle.c: Same.
 396         * dwarf-index-write.c: Same.
 397         * dwarf2-frame.c: Same.
 398         * dwarf2-frame.h: Same.
 399         * eval.c: Same.
 400         * frame-base.h: Same.
 401         * frame.h: Same.
 402         * gdbcmd.h: Same.
 403         * gdbtypes.h: Same.
 404         * gnu-nat.c: Same.
 405         * guile/scm-objfile.c: Same.
 406         * i386-tdep.c: Same.
 407         * i386-tdep.h: Same.
 408         * infcall.c: Same.
 409         * infcall.h: Same.
 410         * linux-nat.c: Same.
 411         * m68k-tdep.c: Same.
 412         * macroexp.c: Same.
 413         * memattr.c: Same.
 414         * mi/mi-cmd-disas.c: Same.
 415         * mi/mi-getopt.h: Same.
 416         * mi/mi-main.c: Same.
 417         * minsyms.c: Same.
 418         * nat/aarch64-sve-linux-sigcontext.h: Same.
 419         * objfiles.h: Same.
 420         * ppc-linux-nat.c: Same.
 421         * ppc-linux-tdep.c: Same.
 422         * ppc-tdep.h: Same.
 423         * progspace.h: Same.
 424         * prologue-value.h: Same.
 425         * python/py-evtregistry.c: Same.
 426         * python/py-instruction.h: Same.
 427         * record-btrace.c: Same.
 428         * record-full.c: Same.
 429         * remote.c: Same.
 430         * rs6000-tdep.c: Same.
 431         * ser-tcp.c: Same.
 432         * sol-thread.c: Same.
 433         * sparc-sol2-tdep.c: Same.
 434         * sparc64-tdep.c: Same.
 435         * stabsread.c: Same.
 436         * symfile.c: Same.
 437         * symtab.h: Same.
 438         * target.c: Same.
 439         * tracepoint.c: Same.
 440         * tui/tui-data.h: Same.
 441         * tui/tui-io.c: Same.
 442         * tui/tui-win.c: Same.
 443         * tui/tui.c: Same.
 444         * unittests/rsp-low-selftests.c: Same.
 445         * user-regs.h: Same.
 446         * utils.c: Same.
 447         * utils.h: Same.
 448         * valarith.c: Same.
 449         * valops.c: Same.
 450         * valprint.c: Same.
 451         * valprint.h: Same.
 452         * value.c: Same.
 453         * value.h: Same.
 454         * varobj.c: Same.
 455         * x86-nat.h: Same.
 456         * xtensa-tdep.c: Same.
 457
 458 2019-10-25  Ali Tamur <tamur@google.com>
 459
 460         * charset.c (find_charset_names): Reflect API change.
 461
 462 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 463
 464         * symtab.c (struct demangled_name_entry): Change demangled name
 465         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 466         part of the struct anymore.
 467         (symbol_set_names): No longer obstack allocate + copy the demangled
 468         name, just store the allocated name from bfd.
 469
 470 2019-10-25  Tom Tromey  <tromey@adacore.com>
 471
 472         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 473         (bsearch_cie_cmp, add_cie): Remove.
 474         (find_cie): Reimplement.
 475         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 476         (dwarf2_build_frame_info): Update.
 477
 478 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 479
 480         PR gdb/25126
 481         * symfile.c (reread_symbols): Call forget_cached_source_info to
 482         clear the stale source cache.
 483
 484 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 485
 486         * configure: Regenerate.
 487         * configure.ac: Remove code that sets python_has_threads.
 488
 489 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 490
 491         * config.in: Regenerate.
 492         * configure: Regenerate.
 493         * configure.ac: Remove the code that uses sed to get the python
 494         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 495
 496 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 497
 498         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 499         error paths.
 500
 501 2019-10-23  Tom Tromey  <tom@tromey.com>
 502
 503         * arc-tdep.c: Remove ".." from include.
 504         * frv-tdep.c: Remove ".." from include.
 505         * lm32-tdep.c: Remove ".." from include.
 506         * microblaze-tdep.c: Remove ".." from include.
 507         * or1k-tdep.h: Remove ".." from include.
 508         * s12z-tdep.c: Remove ".." from include.
 509         * Makefile.in (OPCODES_CFLAGS): Add comment.
 510         (TOP_CFLAGS): New variable.
 511         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 512
 513 2019-10-23  Tom Tromey  <tom@tromey.com>
 514
 515         * Makefile.in (READLINE_DIR): Update.
 516
 517 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 518
 519         * infcall.c (call_function_by_hand_dummy): Fix the function
 520         comment.  And extract out a code section into...
 521         (reserve_stack_space): ...this new function.
 522
 523 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 524
 525         * infcall.c (value_arg_coerce): Remove an unused parameter.
 526         (call_function_by_hand_dummy): Update the call to
 527         'value_arg_coerce'.
 528
 529 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 530
 531         * infcall.c (call_function_by_hand_dummy): Refactor.
 532
 533 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 534
 535         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 536
 537 2019-10-23  Tom Tromey  <tom@tromey.com>
 538
 539         * configure: Rebuild.
 540         * configure.ac: Don't check for sigprocmask.
 541         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 542
 543 2019-10-23  Tom Tromey  <tom@tromey.com>
 544
 545         * configure: Rebuild.
 546         * acinclude.m4: Use m4_include, not sinclude.
 547
 548 2019-10-23  Tom de Vries  <tdevries@suse.de>
 549
 550         PR breakpoints/24687
 551         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 552
 553 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 554
 555         * symtab.c (struct demangled_name_entry) <language>: Change from
 556         bitfield to regular variable.
 557
 558 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 559
 560         * symtab.c (struct demangled_name_entry): Add a constructor.
 561         (free_demangled_name_entry): New function to call the destructor
 562         for demangled_name_entry.
 563         (create_demangled_names_hash): Pass free_demangled_name_entry to
 564         htab_create_alloc.
 565         (symbol_set_names): Call placement new for demangled_name_entry.
 566         * utils.c: No longer include xxhash.h here, now that fast_hash
 567         is inlined in the header.
 568         * utils.h: Instead, include it here.
 569
 570 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 571
 572         * Makefile.in: Link with libxxhash.
 573         * config.in: Regenerate.
 574         * configure: Regenerate.
 575         * configure.ac: Search for libxxhash.
 576         * utils.c (fast_hash): Use xxhash if present.
 577
 578 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 579
 580         * utils.h (fast_hash): New function.
 581         * symtab.c (hash_demangled_name_entry): Call new function
 582         fast_hash.
 583
 584 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 585
 586         * symtab.c (struct demangled_name_entry): Change type of mangled
 587         to gdb::string_view. Also adds a constructor that takes the
 588         mangled name.
 589         (hash_demangled_name_entry): Update.
 590         (eq_demangled_name_entry): Update.
 591         (free_demangled_name_entry): New function to call the destructor
 592         now that this is not a POD anymore.
 593         (create_demangled_names_hash): Pass free_demangled_name_entry to
 594         htab_create_alloc.
 595         (symbol_set_names): Update.
 596
 597 2019-10-21  Ali Tamur  <tamu@google.com>
 598
 599         * dwarf2read.c (dir_index): Change type.
 600         (file_name_index): Likewise.
 601         (line_header::include_dir_at): Change comment and implementation on
 602         whether it is DWARF 5.
 603         (line_header::is_valid_file_index): New function.
 604         (line_header::file_name_at): Change comment and implementation on
 605         whether it is DWARF 5.
 606         (line_header::file_names): Change to private field renamed as
 607         m_file_names and introduce a new accessor method.
 608         (line_header::file_names_size): New method.
 609         (line_header::include_dirs): Change to private field and rename as
 610         m_include_dirs.
 611         (dw2_get_file_names_reader): Define local var at a smaller scope and
 612         reflect API change.
 613         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 614         (process_structure_scope): Likewise.
 615         (line_header::add_include_dir): Change message and reflect renaming.
 616         (line_header::add_file_name): Likewise.
 617         (read_formatted_entries): Handle DW_FORM_data16.
 618         (dwarf_decode_line_header): Fix line header length calculation.
 619         (psymtab_include_file_name): Change comment and API.
 620         (lnp_state_machine::m_file): Update comment and reflect type change.
 621         (lnp_state_machine::record_line): Reflect type change.
 622         (dwarf_decode_lines): Reflect API change.
 623         (file_file_name): Likewise.
 624         (file_full_name): Likewise.
 625
 626 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 627
 628         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 629
 630 2019-10-21  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 633
 634 2019-10-21  Tom Tromey  <tom@tromey.com>
 635
 636         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 637         NM_H.   Use AC_CONFIG_LINKS.
 638         * configure: Rebuild.
 639         * Makefile.in (NM_H): New variable.
 640         (generated_files): Add NM_H.  Remove gcore.
 641         (nm.h, stamp-nmh): New targets.
 642
 643 2019-10-20  Tom Tromey  <tom@tromey.com>
 644
 645         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 646         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 647         obsolete comment.
 648         (put_objfile_before): Now static.
 649
 650 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 651
 652         * gdbsupport/common-utils.h (startswith): Change return type to
 653         bool.
 654
 655 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 656
 657         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 658         * breakpoint.c (bp_locations_compare): Rename to...
 659         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 660         (update_global_location_list): Use std::sort instead of qsort.
 661         * buildsym.c (compare_line_numbers): Rename to...
 662         (lte_is_less_than): ...this, and change to std::sort semantics.
 663         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 664         instead of qsort.
 665         * disasm.c (compare_lines): Rename to...
 666         (line_is_less_than): ...this, and change to std::sort semantics.
 667         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 668         of qsort.
 669         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 670         (fde_is_less_than): ...this, and change to std::sort semantics.
 671         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 672         * mdebugread.c (compare_blocks):
 673         (block_is_less_than): ...this, and change to std::sort semantics.
 674         (sort_blocks): Call std::sort instead of qsort.
 675         * objfiles.c (qsort_cmp): Rename to...
 676         (sort_cmp): ...this, and change to std::sort semantics.
 677         (update_section_map): Call std::sort instead of qsort.
 678         * remote.c (compare_pnums): Remove.
 679         (map_regcache_remote_table): Call std::sort instead of qsort.
 680         * utils.c (compare_positive_ints): Remove.
 681         * utils.h (compare_positive_ints): Remove.
 682         * xcoffread.c (compare_lte): Remove.
 683         (arrange_linetable): Call std::sort instead of qsort.
 684
 685 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 686
 687         * symfile.c (init_entry_point_info): Fix typo.
 688         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 689
 690 2019-10-18  Tom de Vries  <tdevries@suse.de>
 691
 692         * aarch64-tdep.c: Fix typos in comments.
 693         * ada-lang.c: Same.
 694         * ada-tasks.c: Same.
 695         * alpha-tdep.c: Same.
 696         * alpha-tdep.h: Same.
 697         * amd64-nat.c: Same.
 698         * amd64-windows-tdep.c: Same.
 699         * arc-tdep.c: Same.
 700         * arc-tdep.h: Same.
 701         * arch-utils.c: Same.
 702         * arm-nbsd-tdep.c: Same.
 703         * arm-tdep.c: Same.
 704         * ax-gdb.c: Same.
 705         * blockframe.c: Same.
 706         * btrace.c: Same.
 707         * c-varobj.c: Same.
 708         * coff-pe-read.c: Same.
 709         * coffread.c: Same.
 710         * cris-tdep.c: Same.
 711         * darwin-nat.c: Same.
 712         * dbxread.c: Same.
 713         * dcache.c: Same.
 714         * disasm.c: Same.
 715         * dtrace-probe.c: Same.
 716         * dwarf-index-write.c: Same.
 717         * dwarf2-frame-tailcall.c: Same.
 718         * dwarf2-frame.c: Same.
 719         * dwarf2read.c: Same.
 720         * eval.c: Same.
 721         * exceptions.c: Same.
 722         * fbsd-tdep.c: Same.
 723         * findvar.c: Same.
 724         * frame.c: Same.
 725         * frv-tdep.c: Same.
 726         * gnu-v3-abi.c: Same.
 727         * go32-nat.c: Same.
 728         * h8300-tdep.c: Same.
 729         * hppa-tdep.c: Same.
 730         * i386-linux-tdep.c: Same.
 731         * i386-tdep.c: Same.
 732         * ia64-libunwind-tdep.c: Same.
 733         * ia64-tdep.c: Same.
 734         * infcmd.c: Same.
 735         * infrun.c: Same.
 736         * linespec.c: Same.
 737         * linux-nat.c: Same.
 738         * linux-thread-db.c: Same.
 739         * machoread.c: Same.
 740         * mdebugread.c: Same.
 741         * mep-tdep.c: Same.
 742         * mn10300-tdep.c: Same.
 743         * namespace.c: Same.
 744         * objfiles.c: Same.
 745         * opencl-lang.c: Same.
 746         * or1k-tdep.c: Same.
 747         * osabi.c: Same.
 748         * ppc-linux-nat.c: Same.
 749         * ppc-linux-tdep.c: Same.
 750         * ppc-sysv-tdep.c: Same.
 751         * printcmd.c: Same.
 752         * procfs.c: Same.
 753         * record-btrace.c: Same.
 754         * record-full.c: Same.
 755         * remote-fileio.c: Same.
 756         * remote.c: Same.
 757         * rs6000-tdep.c: Same.
 758         * s12z-tdep.c: Same.
 759         * score-tdep.c: Same.
 760         * ser-base.c: Same.
 761         * ser-go32.c: Same.
 762         * skip.c: Same.
 763         * sol-thread.c: Same.
 764         * solib-svr4.c: Same.
 765         * solib.c: Same.
 766         * source.c: Same.
 767         * sparc-nat.c: Same.
 768         * sparc-sol2-tdep.c: Same.
 769         * sparc-tdep.c: Same.
 770         * sparc64-tdep.c: Same.
 771         * stabsread.c: Same.
 772         * stack.c: Same.
 773         * symfile.c: Same.
 774         * symtab.c: Same.
 775         * target-descriptions.c: Same.
 776         * target-float.c: Same.
 777         * thread.c: Same.
 778         * utils.c: Same.
 779         * valops.c: Same.
 780         * valprint.c: Same.
 781         * value.c: Same.
 782         * varobj.c: Same.
 783         * windows-nat.c: Same.
 784         * xcoffread.c: Same.
 785         * xstormy16-tdep.c: Same.
 786         * xtensa-tdep.c: Same.
 787
 788 2019-10-17  Tom Tromey  <tromey@adacore.com>
 789
 790         * configure: Rebuild.
 791         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 792         in AC_CONFIG_FILES invocation.
 793         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 794         new-style config.status invocation.
 795
 796 2019-10-17  Tom de Vries  <tdevries@suse.de>
 797
 798         * arm-nbsd-nat.c: Fix typos in comments.
 799         * arm-tdep.c: Same.
 800         * darwin-nat-info.c: Same.
 801         * dwarf2read.c: Same.
 802         * elfread.c: Same.
 803         * event-top.c: Same.
 804         * findvar.c: Same.
 805         * gdbtypes.c: Same.
 806         * hppa-tdep.c: Same.
 807         * i386-tdep.c: Same.
 808         * jit.c: Same.
 809         * main.c: Same.
 810         * mdebugread.c: Same.
 811         * moxie-tdep.c: Same.
 812         * nto-procfs.c: Same.
 813         * osabi.c: Same.
 814         * ppc-linux-tdep.c: Same.
 815         * remote.c: Same.
 816         * riscv-tdep.c: Same.
 817         * s390-tdep.c: Same.
 818         * sh-tdep.c: Same.
 819         * sparc-linux-tdep.c: Same.
 820         * sparc-nat.c: Same.
 821         * stack.c: Same.
 822         * target-descriptions.c: Same.
 823         * top.c: Same.
 824         * varobj.c: Same.
 825
 826 2019-10-16  Tom Tromey  <tom@tromey.com>
 827
 828         * objfiles.h (struct objfile) <original_name>: Now const.
 829
 830 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 831
 832         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 833         pass on to sigsetjmp's second argument.
 834         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 835
 836 2019-10-16  Keith Seitz  <keiths@redhat.com>
 837
 838         PR gdb/23567
 839         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 840         sections whose size is greater than the file size.
 841
 842 2019-10-16  Jim Wilson  <jimw@sifive.com>
 843
 844         * riscv-tdep.c (riscv_gcc_target_options): New.
 845         (riscv_gnu_triplet_regexp): New.
 846         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 847         set_gdbarch_gnu_triplet_regexp.
 848
 849 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 850
 851         * Makefile.in: Add xml-builtin.h.
 852         * features/feature_to_c.sh: Add an include for xml-builtin.h
 853         to ensure that the compiler checks that the types match.
 854         * xml-builtin.h: New file.
 855         * xml-support.c (fetch_xml_builtin): Add missing const.
 856         * xml-support.h: Remove declaration of xml_builtins.
 857
 858 2019-10-16  Tom de Vries  <tdevries@suse.de>
 859
 860         PR tdep/25096
 861         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 862         (amd64_classify_aggregate): ... here.
 863         (amd64_classify_aggregate_field): Handled fiels of nested structs
 864         recursively.
 865
 866 2019-10-16  Tom de Vries  <tdevries@suse.de>
 867
 868         PR tdep/24104
 869         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 870         that handles 'theclass'.
 871
 872 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         * linespec.c (decode_digits_ordinary): Update comment.
 875         * make-target-delegates: No longer need to handle VEC case.
 876         * memrange.c (normalize_mem_ranges): Update comment.
 877         * namespace.c (add_using_directive): Update comment.
 878         * objc-lang.c (uniquify_strings): Update comment.
 879         * ppc-linux-nat.c (struct thread_points): Update comment.
 880         * probe.h (find_probes_in_objfile): Update comment.
 881         * target.h (enum flash_preserve_mode): Update comment.
 882         * varobj.c (varobj_restrict_range): Update comment.
 883         * varobj.h (varobj_list_children): Update comment.
 884
 885 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * Makefile.in: Remove references to vec.h and vec.c.
 888         * aarch64-tdep.c: No longer include vec.h.
 889         * ada-lang.c: Likewise.
 890         * ada-lang.h: Likewise.
 891         * arm-tdep.c: Likewise.
 892         * ax.h: Likewise.
 893         * breakpoint.h: Likewise.
 894         * charset.c: Likewise.
 895         * cp-support.h: Likewise.
 896         * dtrace-probe.c: Likewise.
 897         * dwarf2read.c: Likewise.
 898         * extension.h: Likewise.
 899         * gdb_bfd.c: Likewise.
 900         * gdbsupport/gdb_vecs.h: Likewise.
 901         * gdbsupport/vec.c: Remove.
 902         * gdbsupport/vec.h: Remove.
 903         * gdbthread.h: Likewise.
 904         * guile/scm-type.c: Likewise.
 905         * inline-frame.c: Likewise.
 906         * machoread.c: Likewise.
 907         * memattr.c: Likewise.
 908         * memrange.h: Likewise.
 909         * namespace.h: Likewise.
 910         * nat/linux-btrace.h: Likewise.
 911         * osdata.c: Likewise.
 912         * parser-defs.h: Likewise.
 913         * progspace.h: Likewise.
 914         * python/py-type.c: Likewise.
 915         * record-btrace.c: Likewise.
 916         * rust-exp.y: Likewise.
 917         * solib-target.c: Likewise.
 918         * stap-probe.c: Likewise.
 919         * target-descriptions.c: Likewise.
 920         * target-memory.c: Likewise.
 921         * target.h: Likewise.
 922         * varobj.c: Likewise.
 923         * varobj.h: Likewise.
 924         * xml-support.h: Likewise.
 925
 926 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 927
 928         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 929         Update for new std::vector based implementation.
 930         (process_psymtab_comp_unit_reader): Likewise.
 931         (scan_partial_symbols): Likewise.
 932         (recursively_compute_inclusions): Likewise.
 933         (compute_compunit_symtab_includes): Likewise.
 934         (process_imported_unit_die): Likewise.
 935         (queue_and_load_dwo_tu): Likewise.
 936         (follow_die_sig_1): Likewise.
 937         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 938         (typedef dwarf2_per_cu_ptr): Remove.
 939         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 940         function.
 941         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 942         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 943         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 944         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 945         std::vector.
 946
 947 2019-10-15  Tom Tromey  <tromey@adacore.com>
 948
 949         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 950         TID.
 951
 952 2019-10-15  Tom Tromey  <tromey@adacore.com>
 953
 954         * windows-nat.c (windows_nat_target::fetch_registers)
 955         (windows_nat_target::store_registers): Rename "pid" to "tid".
 956
 957 2019-10-15  Tom Tromey  <tromey@adacore.com>
 958
 959         * gdbarch.h, gdbarch.c: Rebuild.
 960         * gdbarch.sh (gcc_target_options): Change return type to
 961         std::string.
 962         * compile/compile.c (get_args): Update.
 963         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 964         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 965         std::string.
 966         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 967         std::string.
 968         * arch-utils.c (default_gcc_target_options): Return std::string.
 969         * arch-utils.h (default_gcc_target_options): Return std::string.
 970         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 971
 972 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 973
 974         * breakpoint.c (breakpoint_chain): Make static.
 975         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 976         of accessing breakpoint_chain.
 977
 978 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 979
 980         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 981         to a gdb::function_view and return value to bool.
 982         * breakpoint.h (iterate_over_breakpoints): Likewise.
 983         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 984         (pop_dummy_frame): Update.
 985         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 986         (gdbscm_breakpoints): Update.
 987         * python/py-breakpoint.c (build_bp_list): Update.
 988         (gdbpy_breakpoints): Update.
 989         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 990         Update.
 991         (bpfinishpy_handle_stop): Update.
 992         (bpfinishpy_handle_exit): Update.
 993         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 994         (svr4_update_solib_event_breakpoints): Update.
 995
 996 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 997
 998         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 999         when unwrapping single-field structs.
1000
1001 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1002
1003         * dwarf2read.c: Remove includes.
1004
1005 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1006
1007         * ui-out.c (ui_out::call_do_message): Silence
1008         -Wformat-nonliteral warning.
1009
1010 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1011
1012         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1013         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1014         include: readline/tilde.h.
1015
1016 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1017
1018         * remote.c (remote_target::get_trace_status): Remove declaration of
1019         trace_regblock_size.
1020
1021 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1022
1023         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1024         (show_user): Remove declaration of cmdlist.
1025         * cli/cli-cmds.h (max_user_call_depth): Declare.
1026         * cli/cli-script.c (execute_user_command): Remove declaration
1027         of max_user_call_depth.
1028
1029 2019-10-11  Jim Wilson  <jimw@sifive.com>
1030
1031         * gdbsupport/print-utils.h (pulongest): Fix comment.
1032         (plongest): Likewise.
1033         (phex): Add missing comment, mention leading zeros.
1034         (phex_nz): Add mention of no leading zeros to comment.
1035
1036         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1037         plongest instead of unsigned long long cast.
1038
1039 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1040
1041         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1042         for external_editor_command and gdbtk_test.
1043
1044 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1045
1046         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1047         * varobj.c (varobjdebug): Move comment to...
1048         * varobj.h (varobjdebug): ...here, and declare.
1049
1050 2019-10-09  Tom Tromey  <tom@tromey.com>
1051
1052         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1053         erase_data_content.
1054
1055 2019-10-09  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1058         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1059         * tui/tui-command.c (tui_cmd_window::resize)
1060         (tui_refresh_cmd_win): Update.
1061         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1062         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1063         * tui/tui-data.c (~tui_gen_win_info): Remove.
1064         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1065         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1066         (tui_redisplay_readline, tui_mld_flush)
1067         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1068         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1069         (tui_data_window::erase_data_content)
1070         (tui_data_item_window::rerender)
1071         (tui_data_item_window::refresh_window): Update.
1072         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1073         (box_win, tui_gen_win_info::make_window)
1074         (tui_gen_win_info::make_visible): Update.
1075         (tui_delete_win): Remove.
1076         * tui/tui-winsource.c
1077         (tui_source_window_base::do_erase_source_content): Update.
1078         (tui_show_source_line, tui_source_window_base::update_tab_width)
1079         (tui_source_window_base::update_exec_info): Update.
1080         * tui/tui-data.h (struct curses_deleter): New.
1081         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1082         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1083
1084 2019-10-09  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1087
1088 2019-10-09  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1091         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1092
1093 2019-10-09  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1096         window height directly.
1097         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1098         declare.
1099         * tui/tui-layout.c (tui_default_win_height): Remove.
1100         (tui_default_win_viewport_height): Remove.
1101
1102 2019-10-09  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui.h: Remove comments.
1105
1106 2019-10-09  Tom de Vries  <tdevries@suse.de>
1107
1108         * python/lib/gdb/printer/bound_registers.py: Use
1109         '^builtin_type_bound128' as regexp argument for
1110         add_builtin_pretty_printer.
1111
1112 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1113
1114         * guile/guile.c (guile_extension_script_ops): Remove forward
1115         declaration and mark as static.
1116         (guile_script_ops): Likewise.
1117         (extension_language_guile): Move further down in the file so
1118         it can reference the definitions for guile_{extension_,}script_ops.
1119
1120 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1121
1122         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1123         except SORTL, DFLTCC, and KDSA.
1124
1125 2019-10-08  Tom Tromey  <tromey@adacore.com>
1126
1127         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1128         (struct safe_symbol_file_add_args): Remove.
1129
1130 2019-10-08  Tom Tromey  <tromey@adacore.com>
1131
1132         * windows-nat.c: Don't include buildsym-legacy.h.
1133
1134 2019-10-08  Tom Tromey  <tromey@adacore.com>
1135
1136         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1137
1138 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1139
1140         * gdbtypes.c (overload_debug): Move comment to header.
1141         * gdbtypes.h (overload_debug): Declare.
1142         * valops.c: Remove declaration of overload_debug, instead
1143         include gdbtypes.h.
1144
1145 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1146
1147         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1148         through _().
1149         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1150         move comment...
1151         * language.h (lang_frame_mismatch_warn): ... here. Also add
1152         declaration.
1153         * top.c (lang_frame_mismatch_warn): Remove declaration.
1154         (check_frame_language_change): Pass lang_frame_mismatch_warn
1155         through _().
1156
1157 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1158
1159         * c-lang.h (vtbl_ptr_name): Declare.
1160         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1161         it from the header.
1162         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1163
1164 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1165
1166         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1167         gdb_static_assert.
1168
1169 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1170
1171         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1172         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1173         * ctfread.c: New file.
1174         * ctfread.h: New file.
1175         * elfread.c: Include ctfread.h.
1176         (struct elfinfo text_p): New member ctfsect.
1177         (elf_locate_sections): Mark CTF section.
1178         (elf_symfile_read): Call elfctf_build_psymtabs.
1179         * Makefile.in (LIBCTF): Add.
1180         (CLIBS): Use it.
1181         (CDEPS): Likewise.
1182         (DIST): Add ctfread.c.
1183
1184 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * ctfread.c (struct nextfield): Renamed to ...
1187         (struct ctf_nextfield): ... this.
1188         (struct field_info): Renamed to ...
1189         (strut ctf_field_info): ... this.
1190         (attach_fields_to_type): Update for renamed structures.
1191         (ctf_add_member_cb): Likewise.
1192         (ctf_add_enum_member_cb): Likewise.
1193         (process_struct_members): Likewise.
1194         (process_enum_type): Likewise.
1195
1196 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1197
1198         * tracectf.h: Rename, was ctf.h.
1199         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1200         * tracefile.c: Likewise.
1201         * tracepoint.c: Remove unused include ctf.h.
1202         * mi/mi-main.c: Likewise.
1203         * Makefile.in Replace ctf.c with tracectf.c.
1204
1205 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1206
1207         * version.in: Change version number to "9.0.50.DATE-git".
1208
1209 2019-10-03  Tom Tromey  <tom@tromey.com>
1210
1211         PR rust/24976:
1212         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1213
1214 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1215
1216         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1217         cp_search_name_hash.
1218         * NEWS: Add entry about nested function support.
1219
1220 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1221             Andrew Burgess  <andrew.burgess@embecosm.com>
1222
1223         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1224         for nested static variables when searchin VAR_DOMAIN.
1225         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1226         global scope, update comment.
1227         (add_partial_subprogram): Call add_partial_subprogram recursively
1228         for nested subroutines when processinng Fortran.
1229         (load_partial_dies): Process the child entities of a subprogram
1230         when processing Fortran.
1231         (partial_die_parent_scope): Handle building scope
1232         for Fortran nested functions.
1233         (process_die): Record that nested functions have a scope.
1234         (new_symbol): Always record Fortran subprograms on the global
1235         symbol list.
1236         (determine_prefix): How to build the prefix for Fortran
1237         subprograms.
1238
1239 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1242         have just sent the thread a SIGSTOP and are waiting for it to
1243         arrive.
1244
1245 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1246
1247         * btrace.c (btrace_add_pc): Remove whitespace before the template
1248         parameter in 'std::vector <...>'.
1249         (parse_xml_btrace_block): Likewise.
1250         (btrace_maint_decode_pt): Likewise.
1251         (btrace_maint_update_packets): Likewise.
1252         (btrace_maint_print_packets): Likewise.
1253         * btrace.h (struct btrace_maint_info): Likewise.
1254         * dwarf2read.c (struct type_unit_group): Likewise.
1255         (build_type_psymtabs_reader): Likewise.
1256         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1257         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1258         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1259
1260 2019-10-03  Tom de Vries  <tdevries@suse.de>
1261
1262         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1263         the first line of the help text for set/show style metadata.
1264
1265 2019-10-02  Tom Tromey  <tromey@adacore.com>
1266
1267         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1268         * gdbsupport/common-inferior.c: New file.
1269         * infcmd.c (startup_with_shell): Don't define.
1270         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1271         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1272         * inferior.h (startup_with_shell): Don't declare.
1273
1274 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1275
1276         * gdbsupport/gdb_assert.h: Include errors.h.
1277         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1278
1279 2019-10-02  Tom Tromey  <tromey@adacore.com>
1280
1281         * NEWS: Add $_ada_exception entry.
1282         * ada-lang.c (struct ada_catchpoint): Add constructor.
1283         <m_kind>: New member.
1284         (allocate_location_exception, re_set_exception): Remove
1285         "ex" parameter.
1286         (should_stop_exception): Compute $_ada_exception.
1287         (check_status_exception, print_it_exception)
1288         (print_one_exception, print_mention_exception): Remove
1289         "ex" parameter.
1290         (allocate_location_catch_exception, re_set_catch_exception)
1291         (check_status_exception, print_it_catch_exception)
1292         (print_one_catch_exception, print_mention_catch_exception)
1293         (print_recreate_catch_exception)
1294         (allocate_location_catch_exception_unhandled)
1295         (re_set_catch_exception_unhandled)
1296         (check_status_exception, print_it_catch_exception_unhandled)
1297         (print_one_catch_exception_unhandled)
1298         (print_mention_catch_exception_unhandled)
1299         (print_recreate_catch_exception_unhandled)
1300         (allocate_location_catch_assert, re_set_catch_assert)
1301         (check_status_assert, print_it_catch_assert)
1302         (print_one_catch_assert, print_mention_catch_assert)
1303         (print_recreate_catch_assert)
1304         (allocate_location_catch_handlers, re_set_catch_handlers)
1305         (check_status_handlers, print_it_catch_handlers)
1306         (print_one_catch_handlers, print_mention_catch_handlers)
1307         (print_recreate_catch_handlers): Remove.
1308         (create_ada_exception_catchpoint): Update.
1309         (initialize_ada_catchpoint_ops): Update.
1310
1311 2019-10-02  Tom Tromey  <tromey@adacore.com>
1312
1313         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1314         (create_excep_cond_exprs): Simplify exception string computation.
1315         (ada_exception_catchpoint_cond_string): Likewise.
1316
1317 2019-10-02  Tom Tromey  <tromey@adacore.com>
1318
1319         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1320         * ada-lang.c (lesseq_defined_than): Handle
1321         LOC_STATIC.
1322         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1323         parameter.
1324         (dwarf2_has_info): Likewise.
1325         (new_symbol): Set maybe_copied on symbol when
1326         appropriate.
1327         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1328         parameter.
1329         <can_copy>: New member.
1330         * elfread.c (record_minimal_symbol): Set maybe_copied
1331         on symbol when appropriate.
1332         (elf_symfile_read): Update call to dwarf2_has_info.
1333         * minsyms.c (lookup_minimal_symbol_linkage): New
1334         function.
1335         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1336         * symtab.c (get_symbol_address, get_msymbol_address):
1337         New functions.
1338         * symtab.h (get_symbol_address, get_msymbol_address):
1339         Declare.
1340         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1341         maybe_copied.
1342         (struct symbol, struct minimal_symbol) <maybe_copied>:
1343         New member.
1344
1345 2019-10-02  Tom Tromey  <tromey@adacore.com>
1346
1347         * source.c (struct current_source_location): New.
1348         (current_source_key): New global.
1349         (current_source_symtab, current_source_line)
1350         (current_source_pspace): Remove.
1351         (get_source_location): New function.
1352         (get_current_source_symtab_and_line)
1353         (set_default_source_symtab_and_line)
1354         (set_current_source_symtab_and_line)
1355         (clear_current_source_symtab_and_line, select_source_symtab)
1356         (info_source_command, print_source_lines_base)
1357         (info_line_command, search_command_helper, _initialize_source):
1358         Update.
1359
1360 2019-10-02  Tom Tromey  <tromey@adacore.com>
1361
1362         * source.c (select_source_symtab): Don't call
1363         decode_line_with_current_source.
1364
1365 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1366
1367         * symtab.c (lookup_global_symbol): Search global block.
1368
1369 2019-10-02  Tom Tromey  <tromey@adacore.com>
1370
1371         * coffread.c (process_coff_symbol): Update.
1372         * dwarf2read.c (var_decode_location, new_symbol): Update.
1373         * mdebugread.c (parse_symbol): Update.
1374         * objfiles.c (relocate_one_symbol): Update.
1375         * stabsread.c (define_symbol, fix_common_block)
1376         (scan_file_globals): Update.
1377         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1378         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1379         * xcoffread.c (process_xcoff_symbol): Update.
1380
1381 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1382
1383         * MAINTAINERS: Update my email address.
1384
1385 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1388         std::vector.
1389         (build_type_psymtabs_reader): Update for std::vector.
1390         (build_type_psymtab_dependencies): Likewise.
1391         * dwarf2read.h: Remove use of DEF_VEC_P.
1392         (typedef sig_type_ptr): Delete.
1393
1394 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1395
1396         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1397         to std::vector.
1398         (btrace_maint_decode_pt): Likewise, and move allocation of the
1399         vector outside of the loop.
1400         (btrace_maint_update_packets): Update to handle change from VEC to
1401         std::vector.
1402         (btrace_maint_print_packets): Likewise.
1403         (maint_info_btrace_cmd): Likewise.
1404         * btrace.h: Remove use of DEF_VEC_O.
1405         (typedef btrace_pt_packet_s): Delete.
1406         (struct btrace_maint_info) <packets>: Change fromm VEC to
1407         std::vector.
1408         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1409
1410 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1411
1412         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1413         make accesses into the vector constant references.
1414         (btrace_add_pc): Update for std::vector.
1415         (btrace_stitch_bts): Likewise.
1416         (parse_xml_btrace_block): Likewise.
1417         (btrace_maint_update_packets): Likewise.
1418         (btrace_maint_print_packets): Likewise.
1419         (maint_info_btrace_cmd): Likewise.
1420         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1421         std::vector.
1422         (btrace_data::empty): Likewise.
1423         (btrace_data_append): Likewise.
1424         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1425         (typedef btrace_block_s): Delete.
1426         (struct btrace_block): Add constructor.
1427         (struct btrace_data_bts) <blocks>: Change to std::vector.
1428         * nat/linux-btrace.c (perf_event_read_bts): Update for
1429         std::vector.
1430         (linux_read_bts): Likewise.
1431
1432 2019-10-01  Tom Tromey  <tom@tromey.com>
1433
1434         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1435
1436 2019-10-01  Tom Tromey  <tom@tromey.com>
1437
1438         * stack.c (print_frame, info_frame_command_core): Use
1439         styled_string.
1440         * linux-thread-db.c (try_thread_db_load_1)
1441         (try_thread_db_load_from_pdir_1): Use styled_string.
1442         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1443         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1444         (maybe_print_unsupported_script_warning)
1445         (maybe_print_script_not_found_warning): Use styled_string.
1446         * ada-lang.c (user_select_syms): Use styled_string.
1447
1448 2019-10-01  Tom Tromey  <tom@tromey.com>
1449
1450         * p-lang.c (pascal_printstr): Use metadata style.
1451         * value.c (show_convenience): Use metadata style.
1452         * valprint.c (valprint_check_validity, val_print_optimized_out)
1453         (val_print_not_saved, val_print_unavailable)
1454         (val_print_invalid_address, generic_val_print, val_print)
1455         (value_check_printable, val_print_array_elements): Use metadata
1456         style.
1457         * ui-out.h (class ui_out) <field_fmt>: New overload.
1458         <do_field_fmt>: Add style parameter.
1459         * ui-out.c (ui_out::field_fmt): New overload.
1460         * typeprint.c (type_print_unknown_return_type)
1461         (val_print_not_allocated, val_print_not_associated): Use metadata
1462         style.
1463         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1464         parameter.
1465         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1466         * tracepoint.c (tvariables_info_1): Use metadata style.
1467         * stack.c (print_frame_arg, print_frame_info, print_frame)
1468         (info_frame_command_core): Use metadata style.
1469         * skip.c (info_skip_command): Use metadata style.
1470         * rust-lang.c (rust_print_enum): Use metadata style.
1471         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1472         metadata style.
1473         * python/py-framefilter.c (py_print_single_arg): Use metadata
1474         style.
1475         * printcmd.c (do_one_display, print_variable_and_value): Use
1476         metadata style.
1477         * p-valprint.c (pascal_val_print)
1478         (pascal_object_print_value_fields): Use metadata style.
1479         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1480         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1481         parameter.
1482         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1483         * m2-valprint.c (m2_print_long_set): Use metadata style.
1484         * m2-typeprint.c (m2_print_type): Use metadata style.
1485         * infcmd.c (print_return_value_1): Use metadata style.
1486         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1487         * f-valprint.c (info_common_command_for_block): Use metadata
1488         style.
1489         * f-typeprint.c (f_type_print_base): Use metadata style.
1490         * expprint.c (print_subexp_standard): Use metadata style.
1491         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1492         * cli/cli-style.h (class cli_style_option): Add constructor.
1493         (metadata_style): Declare.
1494         * cli/cli-style.c (metadata_style): New global.
1495         (_initialize_cli_style): Register metadata style.
1496         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1497         parameter.
1498         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1499         * c-typeprint.c (c_type_print_base_struct_union)
1500         (c_type_print_base_1): Use metadata style.
1501         * breakpoint.c (watchpoint_value_print)
1502         (print_one_breakpoint_location): Use metadata style.
1503         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1504         style.
1505         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1506         style.
1507         * ada-valprint.c (val_print_packed_array_elements, printstr)
1508         (print_field_values, ada_val_print_ref, ada_val_print): Use
1509         metadata style.
1510         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1511         style.
1512         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1513         style.
1514         * ada-lang.c (user_select_syms): Use metadata style.
1515
1516 2019-10-01  Tom Tromey  <tom@tromey.com>
1517
1518         * cli/cli-cmds.c (pwd_command): Style output.
1519
1520 2019-10-01  Pedro Alves  <palves@redhat.com>
1521             Tom Tromey  <tom@tromey.com>
1522
1523         * symtab.c (print_symbol_info): Use %ps.
1524         (print_msymbol_info): Use %ps.
1525         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1526         * printcmd.c (print_variable_and_value): Use %ps.
1527         * macrocmd.c (show_pp_source_pos): Use %ps.
1528         * infrun.c (print_exited_reason): Use ui_out::message.
1529         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1530         (describe_other_breakpoints): Use ui_out::message and new
1531         formats.
1532         (say_where): Use new formats.
1533         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1534         and new formats.
1535
1536 2019-10-01  Pedro Alves  <palves@redhat.com>
1537             Tom Tromey  <tom@tromey.com>
1538
1539         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1540         (test_gdb_formats): New function.
1541         (run_tests): Call it.
1542         (test_format_specifier): Update.
1543         * utils.h (fputs_filtered): Update comment.
1544         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1545         (fputs_styled_unfiltered): Declare.
1546         * utils.c (fputs_styled_unfiltered): New function.
1547         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1548         (vfprintf_filtered): Update.
1549         (vfprintf_unfiltered, vprintf_filtered): Update.
1550         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1551         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1552         disallow_ui_out_field>: New constants.
1553         (enum class field_kind): New.
1554         (struct base_field_s, struct signed_field_s): New.
1555         (signed_field): New function.
1556         (struct string_field_s): New.
1557         (string_field): New function.
1558         (struct styled_string_s): New.
1559         (styled_string): New function.
1560         (class ui_out) <message>: Add comment.
1561         <vmessage, call_do_message>: New methods.
1562         <do_message>: Add style parameter.
1563         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1564         methods.
1565         (ui_out::message): Rewrite.
1566         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1567         parameter.
1568         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1569         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1570         gdb_extensions parameter.
1571         (class format_piece): Add parameter to constructor.
1572         (n_int_args): New field.
1573         * gdbsupport/format.c (format_pieces::format_pieces): Add
1574         gdb_extensions parameter.  Handle '*'.
1575         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1576         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1577         vfprintf_styled_no_gdbfmt.
1578         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1579         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1580         unfiltered output.
1581         * ui-style.h (struct ui_file_style) <ptr>: New method.
1582
1583 2019-10-01  Tom Tromey  <tom@tromey.com>
1584
1585         * unittests/format_pieces-selftests.c: Update.  Add final format.
1586         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1587         empty literal pieces.
1588
1589 2019-10-01  Tom Tromey  <tom@tromey.com>
1590
1591         * ui-out.h (enum class ui_out_style_kind): Remove.
1592         (class ui_out) <field_string, field_stsream, do_field_string>:
1593         Change type of "style".
1594         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1595         (ui_out::field_string): Update.
1596         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1597         of "style".
1598         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1599         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1600         * stack.c (print_frame_arg, print_frame_info, print_frame):
1601         Update.
1602         * source.c (print_source_lines_base): Update.
1603         * solib.c (info_sharedlibrary_command): Update.
1604         * skip.c (info_skip_command): Update.
1605         * record-btrace.c (btrace_call_history_src_line)
1606         (btrace_call_history): Update.
1607         * python/py-framefilter.c (py_print_frame): Update.
1608         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1609         "style".
1610         * mi/mi-out.c (mi_ui_out::do_table_header)
1611         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1612         (mi_ui_out::do_field_string): Update.
1613         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1614         Update.
1615         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1616         "style".
1617         * cli-out.c (cli_ui_out::do_table_header)
1618         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1619         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1620         (cli_ui_out::do_field_fmt): Update.
1621         * breakpoint.c (print_breakpoint_location): Update.
1622         (update_static_tracepoint): Update.
1623
1624 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1625
1626         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1627         conversion of gdb_datadir.
1628         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1629         remove not needed c_str ().
1630
1631 2019-09-30  Ali Tamur <tamur@google.com>
1632
1633         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1634         (dwarf2_string_attr): Likewise.
1635
1636 2019-09-30  Ali Tamur <tamur@google.com>
1637
1638         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1639         (process_full_type_unit): Likewise.
1640         (dump_die_shallow): Likewise.
1641         (cu_debug_loc_section): Likewise.
1642
1643 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1644
1645         * minsyms.c (compare_minimal_symbols): Rename to...
1646         (minimal_symbol_is_less_than): ...this, and adjust to STL
1647         conventions (return bool, take arguments as references)
1648         (minimal_symbol_reader::install): Call std::sort instead
1649         of qsort.
1650
1651 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1652
1653         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1654         hash and why.
1655         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1656         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1657
1658 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1659
1660         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1661         * psympriv.h (add_psymbol_to_list): Move comment here and update
1662         it.
1663
1664 2019-09-29  Tom de Vries  <tdevries@suse.de>
1665
1666         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1667         Use $tmpdir/$(basename "$output_file").dwz instead of
1668         "${output_file}.dwz".
1669
1670 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1671
1672         PR gdb/25045
1673         * hppa-linux-nat.c: Include gdbarch.h.
1674
1675 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1676
1677         * blockframe.c (find_pc_partial_function): Change return type to bool.
1678         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1679         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1680         (stub_gnu_ifunc_resolve_name): Likewise.
1681         * symtab.c (compare_filenames_for_search): Likewise.
1682         (compare_glob_filenames_for_search): Likewise.
1683         (matching_obj_sections): Likewise.
1684         (symbol_matches_domain): Likewise.
1685         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1686         (find_line_pc): Change return type to bool.
1687         (find_line_pc_range): Likewise.
1688         (producer_is_realview): Likewise.
1689         * symtab.h (symbol_matches_domain): Likewise.
1690         (find_pc_partial_function): Likewise.
1691         (find_pc_line_pc_range): Likewise.
1692         (in_gnu_ifunc_stub): Likewise.
1693         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1694         (find_line_pc): Likewise.
1695         (find_line_pc_range): Likewise.
1696         (matching_obj_sections): Likewise.
1697         (find_line_symtab): Change out parameter to bool.
1698         (producer_is_realview): Change return type to bool.
1699         (compare_filenames_for_search): Likewise.
1700         (compare_glob_filenames_for_search): Likewise.
1701
1702 2019-09-26  Tom Tromey  <tom@tromey.com>
1703
1704         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1705         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1706         * gdb_usleep.h: Remove.
1707         * gdb_usleep.c: Remove.
1708         * utils.c: Don't include gdb_usleep.h.
1709
1710 2019-09-26  Tom Tromey  <tromey@adacore.com>
1711
1712         * python/py-type.c (type_to_type_object): Call check_typedef
1713         for stub types.
1714
1715 2019-09-26  Tom Tromey  <tom@tromey.com>
1716
1717         * utils.h (initialize_utils): Don't declare.
1718         * top.c (gdb_init): Don't call initialize_utils.
1719         * utils.c (initialize_utils): Remove.  Move contents...
1720         (_initialize_utils): ... here.
1721
1722 2019-09-25  Tom Tromey  <tom@tromey.com>
1723
1724         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1725         * utils.h (make_hex_string): Don't declare.
1726         * utils.c (make_hex_string): Remove.
1727
1728 2019-09-24  Tom de Vries  <tdevries@suse.de>
1729
1730         PR gdb/23815
1731         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1732         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1733
1734 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1735
1736         * NEWS: Mention new simulator port for PRU.
1737
1738 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1739
1740         * ada-exp.y (write_object_remaining): Update.
1741         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1742         and eliminate the static buffer.
1743         (ada_decode_symbol): Update.
1744         (ada_la_decode): Update.
1745         (ada_sniff_from_mangled_name): Update.
1746         (is_valid_name_for_wild_match): Update.
1747         (ada_lookup_name_info::matches): Update and simplify.
1748         (name_matches_regex): Update.
1749         (ada_add_global_exceptions): Update.
1750         * ada-lang.h (ada_decode): Update signature.
1751         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1752         * dwarf-index-write.c (debug_names::insert): Update.
1753
1754 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1755
1756         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1757         formatting.
1758
1759 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1760
1761         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1762         Change "nonzero" to "true" in documentation.
1763
1764 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1765
1766         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1767         (_initialize_darwin_solib): Don't set
1768         darwin_so_ops.lookup_lib_global_symbol.
1769         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1770         set_gdbarch_iterate_over_objfiles_in_search_order.
1771         (elf_lookup_lib_symbol): Rename to...
1772         (svr4_iterate_over_objfiles_in_search_order): this, and update
1773         to iterate semantics.
1774         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1775         * solib.c (solib_global_lookup): Remove.
1776         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1777         (solib_global_lookup): Remove.
1778         * symtab.c (lookup_global_or_static_symbol): Remove call to
1779         solib_global_lookup.
1780
1781 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1782
1783         * NEWS: Move entries about default MI version now being
1784         version 3, and about the GDB/MI fix for multi-location
1785         breakpoints to the "since GDB 8.3" section.
1786
1787 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1788
1789         GDB 8.3.1 released.
1790
1791 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1792
1793         * NEWS: Mention that Cell/B.E. debugging support was removed.
1794         * MAINTAINERS: Remove spu target.
1795
1796         * config/djgpp/fnchange.lst: Remove entries for removed files.
1797
1798         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1799         spu-multiarch.o, and spu-tdep.o.
1800         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1801         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1802         spu-multiarch.c, and spu-tdep.c.
1803         * spu-linux-nat.c: Remove file.
1804         * spu-multiarch.c: Remove file.
1805         * spu-tdep.c: Remove file.
1806         * spu-tdep.h: Remove file.
1807         * solib-spu.c: Remove file.
1808         * solib-spu.h: Remove file.
1809
1810         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1811         * configure.nat (spu-linux): Remove.
1812         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1813         solib-multiarch.o from gdb_target_obs.
1814         (spu*-*-*): Remove.
1815
1816         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1817         feature flag.
1818         (ppc_linux_no_features): Update.
1819         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1820         Cell/B.E. support.
1821         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1822         (tdesc_powerpc_cell64l): Likewise.
1823         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1824         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1825         Cell/B.E. support.
1826         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1827         Do not include "features/rs6000/powerpc-cell32l.c" or
1828         "features/rs6000/powerpc-cell64l.c".
1829         (ppc_linux_spu_section): Remove.
1830         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1831         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1832         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1833         (ppc_linux_spe_context_lookup): Remove.
1834         (ppc_linux_spe_context_inferior_created): Remove.
1835         (ppc_linux_spe_context_solib_loaded): Remove.
1836         (ppc_linux_spe_context_solib_unloaded): Remove.
1837         (ppc_linux_spe_context): Remove.
1838         (struct ppu2spu_cache): Remove.
1839         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1840         (struct ppu2spu_data): Remove.
1841         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1842         ppu2spu_unwind): Remove.
1843         (ppc_linux_init_abi): Remove Cell/B.E. support.
1844         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1845
1846         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1847         (rs6000/powerpc-cell64l-expedite): Likewise
1848         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1849         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1850         rs6000/powerpc-cell64l.xml.
1851         * features/rs6000/powerpc-cell32l.xml: Remove.
1852         * features/rs6000/powerpc-cell64l.xml: Likewise.
1853         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1854         * features/rs6000/powerpc-cell64l.c: Likewise.
1855         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1856         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1857         * regformats/reg-spu.dat: Remove.
1858
1859         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1860         * corelow.c (struct spuid_list): Remove.
1861         (add_to_spuid_list): Remove.
1862         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1863         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1864         (remote_protocol_features): Remove associated entries.
1865         (_initialize_remote): No longer initialize them.
1866         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1867         * linux-nat.c (SPUFS_MAGIC): Remove.
1868         (linux_proc_xfer_spu): Remove.
1869         (spu_enumerate_spu_ids): Remove.
1870         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1871         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1872         (linux_make_corefile_notes): No longer call it.
1873
1874         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1875         (cooked_write_test): Likewise.
1876
1877 2019-09-20  Tom Tromey  <tom@tromey.com>
1878
1879         * NEWS: Mention case-sensitivity of TUI commands.
1880         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1881         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1882         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1883
1884 2019-09-20  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-source.c (tui_source_window::set_contents): Use
1887         make_unique_xstrdup.
1888         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1889         make_unique_xstrdup.
1890
1891 2019-09-20  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-data.c: Remove separator comments.
1894         * tui/tui-layout.c: Remove separator comments.
1895         * tui/tui-win.c: Remove separator comments.
1896         * tui/tui-wingeneral.c: Remove separator comments.
1897
1898 2019-09-20  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui.h (strcat_to_buf): Don't declare.
1901         * tui/tui.c (strcat_to_buf): Remove.
1902
1903 2019-09-20  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1906         from "fullname".
1907         * tui/tui-source.c (tui_source_window::set_contents)
1908         (tui_source_window::location_matches_p)
1909         (tui_source_window::maybe_update): Update.
1910
1911 2019-09-20  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1914         Update.
1915         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1916         prefix.
1917         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1918         (tui_data_window::line_from_reg_element_no)
1919         (tui_data_window::first_reg_element_no_inline)
1920         (tui_data_window::show_registers)
1921         (tui_data_window::show_register_group)
1922         (tui_data_window::display_registers_from)
1923         (tui_data_window::display_registers_from_line)
1924         (tui_data_window::first_data_item_displayed)
1925         (tui_data_window::delete_data_content_windows)
1926         (tui_data_window::erase_data_content)
1927         (tui_data_window::do_scroll_vertical)
1928         (tui_data_window::refresh_window)
1929         (tui_data_window::check_register_values): Update.
1930
1931 2019-09-20  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1934         (struct tui_locator_window) <full_name, proc_name>: Now
1935         std::string.
1936         * tui/tui-stack.c (tui_locator_window::make_status_line)
1937         (tui_locator_window::set_locator_fullname)
1938         (tui_locator_window::set_locator_info): Update.
1939         * tui/tui-source.c (tui_source_window::set_contents)
1940         (tui_source_window::showing_source_p): Update.
1941
1942 2019-09-20  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1945         Don't call tui_locator_win_info_ptr.
1946
1947 2019-09-20  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1950
1951 2019-09-20  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1954         height for locator.
1955         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1956         * tui/tui-layout.c (show_source_disasm_command, show_data)
1957         (show_source_or_disasm_and_command): Use 1 as height for locator.
1958
1959 2019-09-20  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui.c (tui_enable): Update.
1962         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1963         Update.
1964         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1965         Update.
1966         * tui/tui-data.c (win_resized): Now bool.
1967         (tui_win_resized): Return bool.
1968         (tui_set_win_resized_to): Accept a bool.
1969
1970 2019-09-20  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1973         Change type of "refresh_values_only".
1974         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1975         type of "refresh_values_only".
1976
1977 2019-09-20  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1980         std::string.
1981         (tui_disassemble): Add "pos" parameter.
1982         (tui_disasm_window::set_contents): Simplify.
1983
1984 2019-09-20  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-winsource.h (struct tui_source_window_base)
1987         <show_source_content>: Now private.
1988         * tui/tui-winsource.c
1989         (tui_source_window_base::show_source_content): Don't handle empty
1990         content case.
1991
1992 2019-09-20  Tom Tromey  <tom@tromey.com>
1993
1994         * tui/tui-layout.c (show_source_disasm_command)
1995         (show_source_or_disasm_and_command): Don't call
1996         show_source_content.
1997
1998 2019-09-20  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2001         Declare.
2002         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2003         from tui_make_status_line.
2004         (tui_locator_window::rerender): Update.
2005
2006 2019-09-20  Tom Tromey  <tom@tromey.com>
2007
2008         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2009         (tui_locator_window::rerender): Update.
2010
2011 2019-09-20  Tom Tromey  <tom@tromey.com>
2012
2013         * tui/tui-winsource.h (struct tui_source_window_base)
2014         <~tui_source_window_base>: Don't declare.
2015         <fullname>: Remove.
2016         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2017         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2018         member.
2019         * tui/tui-source.c (tui_source_window::set_contents): Update.
2020         (tui_source_window::location_matches_p)
2021         (tui_source_window::maybe_update): Update.
2022
2023 2019-09-20  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-winsource.h (~tui_source_element): Remove.
2026         (tui_source_element): Update.
2027         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2028         * tui/tui-winsource.c (tui_show_source_line): Update.
2029         * tui/tui-source.c (tui_source_window::set_contents): Update.
2030         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2031
2032 2019-09-20  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2035         declare.
2036         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2037         tui_clear_source_windows_detail.
2038         * tui/tui-winsource.h (struct tui_source_window_base)
2039         <clear_detail>: Don't declare.
2040         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2041         Remove.
2042         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2043
2044 2019-09-20  Tom Tromey  <tromey@adacore.com>
2045
2046         PR ada/24919:
2047         * block.c (contained_in): Fix final return value.
2048
2049 2019-09-20  Alan Modra  <amodra@gmail.com>
2050
2051         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2052         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2053         (read_indirect_string_from_dwz): Use bfd accessor.
2054         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2055         * machoread.c (macho_symfile_read_all_oso): Likewise.
2056         * solib.c (solib_bfd_open): Likewise.
2057
2058 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2059
2060         * eval.c: Move declaration of overload_resolution to...
2061         * value.h: ...here.
2062
2063 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2064
2065         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2066         * arm-linux-tdep.c: Likewise.
2067         * arm-nbsd-nat.c: Likewise.
2068         * arm-tdep.h: Declare arm_apcs_32.
2069         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2070
2071 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2072
2073         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2074         * dwarf2read.h: Declare dwarf_always_disassemble.
2075
2076 2019-09-19  Tom de Vries  <tdevries@suse.de>
2077
2078         PR gdb/25009
2079         * source-cache.c (source_cache::ensure): Catch exception thrown during
2080         construction of the highlighter.
2081
2082 2019-09-18  Alan Modra  <amodra@gmail.com>
2083
2084         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2085         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2086         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2087         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2088         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2089         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2090         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2091         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2092         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2093         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2094         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2095         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2096         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2097         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2098         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2099         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2100         * mi/mi-interp.c: Update throughout for bfd section macro and
2101         function changes.
2102         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2103         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2104
2105 2019-09-18  Tom Tromey  <tom@tromey.com>
2106
2107         * NEWS: Add entry.
2108         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2109         call rl_initialize.
2110         (tui_enable): Do not call rl_initialize.
2111
2112 2019-09-18  Christian Groessler  <chris@groessler.org>
2113
2114         * alpha-linux-nat.c: Include gdbarch.h.
2115
2116 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2117
2118         * ui-file.c: Include cli/cli-style.h.
2119         (term_cli_styling): Remove cli_styling declaration.
2120
2121 2019-09-18  Alan Modra  <amodra@gmail.com>
2122
2123         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2124         to bfd_asymbol_section.
2125
2126 2019-09-18  Alan Modra  <amodra@gmail.com>
2127
2128         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2129         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2130         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2131
2132 2019-09-18  Alan Modra  <amodra@gmail.com>
2133
2134         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2135         * spu-linux-nat.c (spu_bfd_open): Likewise.
2136
2137 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2138
2139         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2140         to bool to match definition in dwarf2read.c.
2141
2142 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2143
2144         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2145         (print_signatures): Likewise.
2146         (trust_pad_over_xvs): Likewise.
2147         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2148         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2149         * arm-linux-nat.c (arm_apcs_32): Likewise.
2150         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2151         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2152         * arm-tdep.c (arm_debug): Likewise.
2153         (arm_apcs_32): Likewise.
2154         * auto-load.c (debug_auto_load): Likewise.
2155         (auto_load_gdb_scripts): Likewise.
2156         (global_auto_load): Likewise.
2157         (auto_load_local_gdbinit): Likewise.
2158         (auto_load_local_gdbinit_loaded): Likewise.
2159         * auto-load.h (global_auto_load): Likewise.
2160         (auto_load_local_gdbinit): Likewise.
2161         (auto_load_local_gdbinit_loaded): Likewise.
2162         * breakpoint.c (disconnected_dprintf): Likewise.
2163         (breakpoint_proceeded): Likewise.
2164         (automatic_hardware_breakpoints): Likewise.
2165         (always_inserted_mode): Likewise.
2166         (target_exact_watchpoints): Likewise.
2167         (_initialize_breakpoint): Update.
2168         * breakpoint.h (target_exact_watchpoints): Change to bool.
2169         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2170         * cli/cli-cmds.c (trace_commands): Likewise.
2171         * cli/cli-cmds.h (trace_commands): Likewise.
2172         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2173         to bool*.
2174         * cli/cli-logging.c (logging_overwrite): Change to bool.
2175         (logging_redirect): Likewise.
2176         (debug_redirect): Likewise.
2177         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2178         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2179         to bool.
2180         <boolean_option_def>: Update.
2181         (struct flag_option_def): Change default type of Context to bool
2182         from int.
2183         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2184         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2185         (get_setshow_command_value_string): Likewise.
2186         * cli/cli-style.c (cli_styling): Change to bool.
2187         (source_styling): Likewise.
2188         * cli/cli-style.h (source_styling): Likewise.
2189         (cli_styling): Likewise.
2190         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2191         to bool.
2192         * command.h (var_types): Update comment.
2193         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2194         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2195         bool.
2196         (debug_compile_cplus_scopes): Likewise.
2197         * compile/compile-internal.h (compile_debug): Likewise.
2198         * compile/compile.c (compile_debug): Likewise.
2199         (struct compile_options) <raw>: Likewise.
2200         * cp-support.c (catch_demangler_crashes): Likewise.
2201         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2202         (usr_cmd_cris_dwarf2_cfi): Likewise.
2203         * csky-tdep.c (csky_debug): Likewise.
2204         * darwin-nat.c (enable_mach_exceptions): Likewise.
2205         * dcache.c (dcache_enabled_p): Likewise.
2206         * defs.h (info_verbose): Likewise.
2207         * demangle.c (demangle): Likewise.
2208         (asm_demangle): Likewise.
2209         * dwarf-index-cache.c (debug_index_cache): Likewise.
2210         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2211         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2212         * dwarf2read.c (check_physname): Likewise.
2213         (use_deprecated_index_sections): Likewise.
2214         (dwarf_always_disassemble): Likewise.
2215         * eval.c (overload_resolution): Likewise.
2216         * event-top.c (set_editing_cmd_var): Likewise.
2217         (exec_done_display_p): Likewise.
2218         * event-top.h (set_editing_cmd_var): Likewise.
2219         (exec_done_display_p): Likewise.
2220         * exec.c (write_files): Likewise.
2221         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2222         (debug_fbsd_nat): Likewise.
2223         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2224         Likewise.
2225         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2226         <backtrace_past_entry> Likewise.
2227         * gdb-demangle.h (demangle): Likewise.
2228         (asm_demangle): Likewise.
2229         * gdb_bfd.c (bfd_sharing): Likewise.
2230         * gdbcore.h (write_files): Likewise.
2231         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2232         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2233         * gdbthread.h (print_thread_events): Likewise.
2234         * gdbtypes.c (opaque_type_resolution): Likewise.
2235         (strict_type_checking): Likewise.
2236         * gnu-nat.c (gnu_debug_flag): Likewise.
2237         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2238         * guile/scm-param.c (pascm_variable): Add boolval.
2239         (add_setshow_generic): Update.
2240         (pascm_param_value): Update.
2241         (pascm_set_param_value_x): Update.
2242         * hppa-tdep.c (hppa_debug): Change to bool..
2243         * infcall.c (may_call_functions_p): Likewise.
2244         (coerce_float_to_double_p): Likewise.
2245         (unwind_on_signal_p): Likewise.
2246         (unwind_on_terminating_exception_p): Likewise.
2247         * infcmd.c (startup_with_shell): Likewise.
2248         * inferior.c (print_inferior_events): Likewise.
2249         * inferior.h (startup_with_shell): Likewise.
2250         (print_inferior_events): Likewise.
2251         * infrun.c (step_stop_if_no_debug): Likewise.
2252         (detach_fork): Likewise.
2253         (debug_displaced): Likewise.
2254         (disable_randomization): Likewise.
2255         (non_stop): Likewise.
2256         (non_stop_1): Likewise.
2257         (observer_mode): Likewise.
2258         (observer_mode_1): Likewise.
2259         (set_observer_mode): Update.
2260         (sched_multi): Change to bool.
2261         * infrun.h (debug_displaced): Likewise.
2262         (sched_multi): Likewise.
2263         (step_stop_if_no_debug): Likewise.
2264         (non_stop): Likewise.
2265         (disable_randomization): Likewise.
2266         * linux-tdep.c (use_coredump_filter): Likewise.
2267         (dump_excluded_mappings): Likewise.
2268         * linux-thread-db.c (auto_load_thread_db): Likewise.
2269         (check_thread_db_on_load): Likewise.
2270         * main.c (captured_main_1): Update.
2271         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2272         xx2_opt, boolean_opt>: Change to bool.
2273         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2274         * maint.c (maintenance_profile_p): Likewise.
2275         (per_command_time): Likewise.
2276         (per_command_space): Likewise.
2277         (per_command_symtab): Likewise.
2278         * memattr.c (inaccessible_by_default): Likewise.
2279         * mi/mi-main.c (mi_async): Likewise.
2280         (mi_async_1): Likewise.
2281         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2282         * nat/fork-inferior.h (startup_with_shell): Likewise.
2283         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2284         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2285         * nios2-tdep.c (nios2_debug): Likewise.
2286         * or1k-tdep.c (or1k_debug): Likewise.
2287         * parse.c (parser_debug): Likewise.
2288         * parser-defs.h (parser_debug): Likewise.
2289         * printcmd.c (print_symbol_filename): Likewise.
2290         * proc-api.c (procfs_trace): Likewise.
2291         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2292         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2293         (set_parameter_value): Update.
2294         (add_setshow_generic): Update.
2295         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2296         to bool*.
2297         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2298         int*.
2299         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2300         * record-btrace.c (record_btrace_target::store_registers): Update.
2301         * record-full.c (record_full_memory_query): Change to bool.
2302         (record_full_stop_at_limit): Likewise.
2303         * record-full.h (record_full_memory_query): Likewise.
2304         * remote-notif.c (notif_debug): Likewise.
2305         * remote-notif.h (notif_debug): Likewise.
2306         * remote.c (use_range_stepping): Likewise.
2307         (interrupt_on_connect): Likewise.
2308         (remote_break): Likewise.
2309         * ser-tcp.c (tcp_auto_retry): Likewise.
2310         * ser-unix.c (serial_hwflow): Likewise.
2311         * skip.c (debug_skip): Likewise.
2312         * solib-aix.c (solib_aix_debug): Likewise.
2313         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2314         (spu_auto_flush_cache_p): Likewise.
2315         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2316         Likewise.
2317         (struct info_print_options) <quiet>: Likewise.
2318         * symfile-debug.c (debug_symfile): Likewise.
2319         * symfile.c (auto_solib_add): Likewise.
2320         (separate_debug_file_debug): Likewise.
2321         * symfile.h (auto_solib_add): Likewise.
2322         (separate_debug_file_debug): Likewise.
2323         * symtab.c (basenames_may_differ): Likewise.
2324         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2325         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2326         (struct info_types_options) <quiet>: Likewise.
2327         * symtab.h (demangle): Likewise.
2328         (basenames_may_differ): Likewise.
2329         * target-dcache.c (stack_cache_enabled_1): Likewise.
2330         (code_cache_enabled_1): Likewise.
2331         * target.c (trust_readonly): Likewise.
2332         (may_write_registers): Likewise.
2333         (may_write_memory): Likewise.
2334         (may_insert_breakpoints): Likewise.
2335         (may_insert_tracepoints): Likewise.
2336         (may_insert_fast_tracepoints): Likewise.
2337         (may_stop): Likewise.
2338         (auto_connect_native_target): Likewise.
2339         (target_stop_and_wait): Update.
2340         (target_async_permitted): Change to bool.
2341         (target_async_permitted_1): Likewise.
2342         (may_write_registers_1): Likewise.
2343         (may_write_memory_1): Likewise.
2344         (may_insert_breakpoints_1): Likewise.
2345         (may_insert_tracepoints_1): Likewise.
2346         (may_insert_fast_tracepoints_1): Likewise.
2347         (may_stop_1): Likewise.
2348         * target.h (target_async_permitted): Likewise.
2349         (may_write_registers): Likewise.
2350         (may_write_memory): Likewise.
2351         (may_insert_breakpoints): Likewise.
2352         (may_insert_tracepoints): Likewise.
2353         (may_insert_fast_tracepoints): Likewise.
2354         (may_stop): Likewise.
2355         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2356         (make_thread_apply_all_options_def_group): Change argument from int*
2357         to bool*.
2358         (thread_apply_all_command): Update.
2359         (print_thread_events): Change to bool.
2360         * top.c (confirm): Likewise.
2361         (command_editing_p): Likewise.
2362         (history_expansion_p): Likewise.
2363         (write_history_p): Likewise.
2364         (info_verbose): Likewise.
2365         * top.h (confirm): Likewise.
2366         (history_expansion_p): Likewise.
2367         * tracepoint.c (disconnected_tracing): Likewise.
2368         (circular_trace_buffer): Likewise.
2369         * typeprint.c (print_methods): Likewise.
2370         (print_typedefs): Likewise.
2371         * utils.c (debug_timestamp): Likewise.
2372         (sevenbit_strings): Likewise.
2373         (pagination_enabled): Likewise.
2374         * utils.h (sevenbit_strings): Likewise.
2375         (pagination_enabled): Likewise.
2376         * valops.c (overload_resolution): Likewise.
2377         * valprint.h (struct value_print_options) <prettyformat_arrays,
2378         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2379         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2380         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2381         Likewise.
2382         * windows-nat.c (new_console): Likewise.
2383         (cygwin_exceptions): Likewise.
2384         (new_group): Likewise.
2385         (debug_exec): Likewise.
2386         (debug_events): Likewise.
2387         (debug_memory): Likewise.
2388         (debug_exceptions): Likewise.
2389         (useshell): Likewise.
2390         * windows-tdep.c (maint_display_all_tib): Likewise.
2391         * xml-support.c (debug_xml): Likewise.
2392
2393 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2394
2395         * source.c (prepare_path_for_appending): New function.
2396         (openp): Make use of new function.
2397         (find_and_open_source): Search for the compilation directory and
2398         source file as a relative path beneath the directory search path.
2399
2400 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2401
2402         * source-cache.c (source_cache::get_line_charpos): Catch
2403         exceptions and return false, this matches the behaviour documented
2404         in the header file.
2405
2406 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2407
2408         * ada-tasks.c (info_task): Remove quoting of the task's name.
2409
2410 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2411
2412         * symfile.c (auto_solib_add): Replace comment with a reference
2413         to the header file.
2414
2415 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2416
2417         * NEWS: Mention that gdb can now be compiled with Python 3
2418         on Windows.
2419
2420 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2421
2422         * maint.c (maint_print_section_data::maint_print_section_data):
2423         Force use of 'float log10 (float)' by casting the argument to
2424         float.
2425
2426 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2427
2428         * maint.c: Add 'cmath' include.
2429         (struct maint_print_section_data): New structure.
2430         (print_section_index): New function.
2431         (print_bfd_section_info): Add header comment, small whitespace
2432         cleanup, and update to call new print_section_index function.
2433         (print_objfile_section_info): Likewise.
2434         (maint_obj_section_from_bfd_section): New function.
2435         (print_bfd_section_info_maybe_relocated): New function.
2436         (maintenance_info_sections): Add header comment, always use
2437         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2438
2439 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2440
2441         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2442         inner scope, add check that the objfile has psymtabs before
2443         checking psymtabs_addrmap.
2444         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2445
2446 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2447
2448         * NEWS: Announce that Ada task names are now shown at more places,
2449         and between quotes (except in info task output).
2450         * gdb/ada-tasks.c (task_to_str): New function.
2451         (display_current_task_id): Call task_to_str.
2452         (task_command_1): Likewise.
2453         (print_ada_task_info): In non-mi mode, Properly align headers and data
2454         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2455
2456 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2457
2458         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2459         prstatus.pr_lwp.pr_info instead of making it up.
2460
2461 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2462
2463         * auto-load.c (auto_load_expand_dir_vars): Update.
2464         * defs.h (gdb_datadir): Change to std::string.
2465         (python_libdir): Likewise.
2466         (relocate_gdb_directory): Change return type to std::string.
2467         * guile/guile.c (gdbscm_data_directory): Update.
2468         (initialize_scheme_side): Update.
2469         * jit.c (jit_reader_dir): Change to std::string.
2470         (jit_reader_load_command): Update.
2471         * main.c (gdb_datadir): Change to std::string.
2472         (python_libdir): Likewise.
2473         (set_gdb_data_directory): Update.
2474         (relocate_path): Change to return std::string.
2475         (relocate_gdb_directory): Change to return std::string.
2476         (relocate_gdbinit_path_maybe_in_datadir): Update.
2477         (captured_main_1): Update.
2478         * python/python.c (do_start_initialization): Update.
2479         * top.c (show_gdb_datadir): Update.
2480         * xml-syscall.c (xml_init_syscalls_info): Update.
2481         (init_syscalls_info): Update.
2482
2483 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2484
2485         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2486         out of get_init_files.
2487         (get_init_files): Update.
2488
2489 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2490
2491         * main.c (get_init_files): Change to use std::string.
2492         (captured_main_1): Update.
2493         (print_gdb_help): Update.
2494
2495 2019-09-11  Ali Tamur  <tamur@google.com>
2496
2497         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2498         implementation.
2499
2500 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2501
2502         * dbxread.c (read_dbx_symtab): Update.
2503         * dwarf2read.c (load_partial_dies): Update.
2504         * mdebugread.c (parse_partial_symbols): Update.
2505         (handle_psymbol_enumerators): Update.
2506         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2507         * psymtab.c (add_psymbol_to_bcache): Likewise.
2508         (add_psymbol_to_list): Likewise.
2509         * symtab.c (symbol_set_names): Likewise.
2510         * symtab.h (symbol_set_names): Likewise.
2511         * xcoffread.c (scan_xcoff_symtab): Update.
2512
2513 2019-09-11  Tom Tromey  <tom@tromey.com>
2514
2515         * symfile-mem.c (symbol_file_add_from_memory): Use
2516         bfd_set_filename.
2517         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2518         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2519
2520 2019-09-10  Tom Tromey  <tromey@adacore.com>
2521
2522         * dwarf-index-write.c (write_psymbols): Extend error message.
2523         (debug_names::insert): Add Ada code.
2524         (debug_names::write_psymbols): Remove Ada check.
2525         (debug_names) <m_string_obstack>: New member.
2526         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2527         (gdb_index_symbol_name_matcher::matches): Remove.
2528         (mapped_index_base::find_name_components_bounds): Add "lang"
2529         parameter.
2530         (mapped_index_base::build_name_components): Also split names
2531         according to Ada syntax.
2532         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2533         type of "match_callback".
2534         (check_match, check_find_bounds_finds)
2535         (dw2_expand_symtabs_matching): Update.
2536         (dw2_debug_names_iterator): Add new constructor.
2537         (dw2_debug_names_map_matching_symbols): New function.
2538         (dw2_debug_names_expand_symtabs_matching): Update.
2539         (dwarf2_debug_names_functions): Use
2540         dw2_debug_names_map_matching_symbols.
2541
2542 2019-09-10  Tom Tromey  <tromey@adacore.com>
2543
2544         * dwarf2read.c (dw2_get_file_names_reader): Add the
2545         CU's file name to the results.
2546
2547 2019-09-10  Tom Tromey  <tromey@adacore.com>
2548
2549         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2550         map_matching_symbols.  Update.
2551         * dwarf2read.c (dw2_map_matching_symbols): Update.
2552         * psymtab.c (match_partial_symbol): Change type; update.
2553         (psym_map_matching_symbols): Likewise.
2554         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2555         type; update.
2556         * symfile.h (struct quick_symbol_functions)
2557         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2558         Remove "match".
2559
2560 2019-09-10  Tom Tromey  <tromey@adacore.com>
2561
2562         * psymtab.c (map_block): Remove.
2563         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2564         * symtab.c (iterate_over_symbols_terminated): New function.
2565         * symtab.c (iterate_over_symbols_terminated): Declare.
2566
2567 2019-09-10  Tom Tromey  <tromey@adacore.com>
2568
2569         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2570         * language.h (struct language_defn) <la_iterate_over_symbols>:
2571         Return bool.
2572         * symtab.c (iterate_over_symbols): Return bool.
2573         * symtab.h (iterate_over_symbols): Return bool.
2574
2575 2019-09-10  Tom Tromey  <tromey@adacore.com>
2576
2577         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2578         (add_nonlocal_symbols): Update.
2579         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2580         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2581         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2582         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2583         Change type of "callback".  Remove "data".
2584
2585
2586 2019-09-09  Ali Tamur  <tamur@google.com>
2587
2588         * dwarf2read.c (comp_unit_head): Update comment.
2589         (dwarf2_dwo_name): New function declaration.
2590         (dwarf_unit_type_name): New function declaration.
2591         (read_comp_unit_head): Add support for new compilation units,
2592         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2593         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2594         (currently named as "signature") in their header. Also clarify error
2595         messages.
2596         (lookup_dwo_id): New function. Returns the dwo id of the given
2597         compile unit.
2598         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2599         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2600         functions.
2601         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2602         (dwarf2_dwo_name): Get the dwo name if present.
2603         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2604         purposes.
2605
2606 2019-09-09  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2609
2610 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2611
2612         * python/python.c (do_start_initialization): Make progname_copy static,
2613         to avoid a leak report.
2614
2615 2019-09-08  Tom Tromey  <tom@tromey.com>
2616
2617         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2618
2619 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2620
2621         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2622         Change type to gdb::optional<block_enum>.
2623         (dw2_symtab_iter_init): Change block_index parameter type
2624         to gdb::optional<block_enum>.
2625         (dw2_lookup_symbol): Change block_index parameter
2626         type to block_enum.c
2627         (dw2_debug_names_lookup_symbol): Likewise.
2628         * psymtab.c (psym_lookup_symbol): Likewise.
2629         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2630         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2631         Likewise.
2632
2633 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2634
2635         * defs.h (relocate_gdb_directory): Change int to bool in
2636         signature and rename flag to relocatable.
2637         * main.c (relocate_path): Likewise.
2638         (relocate_gdb_directory): Likewise.
2639
2640 2019-09-06  Alan Modra  <amodra@gmail.com>
2641
2642         * coffread.c (coff_symfile_read): Constify filename variable.
2643         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2644         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2645         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2646         * solib.c (reload_shared_libraries_1): Likewise.
2647         * symfile.c (reread_symbols): Likewise.
2648         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2649         * solib-darwin.c (darwin_bfd_open): Likewise.
2650         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2651
2652 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2653
2654         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2655         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2656
2657 2019-09-03  Tom Tromey  <tromey@adacore.com>
2658
2659         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2660         types.
2661         (has_negatives): Unbias a range type bound.
2662         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2663         * gdbtypes.c (operator==): Handle new field.
2664         (create_range_type): Add "bias" parameter.
2665         (create_static_range_type, resolve_dynamic_range): Update.
2666         * gdbtypes.h (struct range_bounds) <bias>: New member.
2667         (create_range_type): Add bias parameter.
2668         * printcmd.c (print_scalar_formatted): Unbias range types.
2669         * value.c (unpack_long): Unbias range types.
2670         (pack_long): Bias range types.
2671
2672 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2673
2674         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2675         probe arguments.
2676
2677 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2678
2679         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2680         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2681         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2682         (compile_probe_arg): Likewise.
2683         * probe.h (get_argument_count): Likewise.
2684         * solib-svr4.c (solib_event_probe_action): Likewise.
2685         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2686
2687 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2688
2689         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2690         code to here...
2691         (svr4_create_solib_event_breakpoints): ...from here.
2692
2693 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2694
2695         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2696         suffix from warning message.
2697
2698 2019-08-30  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui-winsource.h (struct tui_source_window_base)
2701         <refresh_all>: Don't declare.
2702         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2703         Remove.
2704         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2705         tui_show_locator_content.
2706         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2707         declare.
2708         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2709         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2710         declare.
2711
2712 2019-08-30  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2715
2716 2019-08-30  Tom Tromey  <tom@tromey.com>
2717
2718         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2719         Remove unnecessary forward declarations.
2720
2721 2019-08-30  Tom Tromey  <tom@tromey.com>
2722
2723         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2724         rerender.
2725         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2726         tui_show_locator_content.
2727
2728 2019-08-30  Tom Tromey  <tom@tromey.com>
2729
2730         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2731         (tui_locator_window::rerender): Rewrite using body of previous
2732         tui_show_locator_content.
2733
2734 2019-08-30  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2737         set_locator_fullname>: New methods.
2738         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2739         Rename from tui_set_locator_fullname.
2740         (tui_locator_window::set_locator_info): Rename from
2741         tui_set_locator_info.  Return bool.
2742         (tui_update_locator_fullname, tui_show_frame_info): Update.
2743
2744 2019-08-30  Tom Tromey  <tom@tromey.com>
2745
2746         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2747
2748 2019-08-30  Tom Tromey  <tom@tromey.com>
2749
2750         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2751         call touchwin.
2752
2753 2019-08-30  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-wingeneral.c (box_win): Assume win_info and
2756         win_info->handle cannot be NULL.
2757
2758 2019-08-30  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2761         refresh_window>: Declare.
2762         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2763         resize.
2764         (tui_data_item_window::rerender): Rename from
2765         tui_display_register.
2766         (tui_data_item_window::refresh_window): New method.
2767         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2768         no-op.
2769
2770 2019-08-30  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2773         regs_column_count, current_group>: Move later.  Now private.
2774         <get_current_group>: New method.
2775         * tui/tui-regs.c (tui_reg_command): Update.
2776         * tui/tui-layout.c (tui_set_layout): Update.
2777
2778 2019-08-30  Tom Tromey  <tom@tromey.com>
2779
2780         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2781         (tui_data_window::rerender): Don't call
2782         check_and_display_highlight_if_needed.
2783         (tui_data_window::refresh_all): Remove call to
2784         erase_data_content.
2785
2786 2019-08-30  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2789         (tui_data_window::display_registers_from)
2790         (tui_data_window::display_reg_element_at_line)
2791         (tui_data_window::display_registers_from_line): Remove checks of
2792         "empty".
2793
2794 2019-08-30  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2797         Don't declare.
2798         * tui/tui-regs.c (tui_data_window::show_registers): Call
2799         rerender.
2800         (tui_data_window::rerender): Rename from display_all_data.
2801         (tui_data_window::rerender): Remove old implementation.
2802
2803 2019-08-30  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2806         text.
2807         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2808
2809 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2810             Sergio Durigan Junior  <sergiodj@redhat.com>
2811
2812         PR win32/24284
2813         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2814
2815 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2818         when searching for types.
2819
2820 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         * f-lang.c (f_language_defn): Use f_print_typedef.
2823         * f-lang.h (f_print_typedef): Declare.
2824         * f-typeprint.c (f_print_typedef): Define.
2825
2826 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2827
2828         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2829
2830 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2831
2832         * cli/cli-utils.c (info_print_options_defs): Delete.
2833         (make_info_print_options_def_group): Delete.
2834         (extract_info_print_options): Delete.
2835         (info_print_command_completer): Delete.
2836         (info_print_args_help): Add extra parameter, and optionally
2837         include text about -n flag.
2838         * cli/cli-utils.h (struct info_print_options): Delete.
2839         (extract_info_print_options): Delete declaration.
2840         (info_print_command_completer): Delete declaration.
2841         (info_print_args_help): Add extra parameter, extend header
2842         comment.
2843         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2844         search_symbols.
2845         * stack.c (struct info_print_options): New type.
2846         (info_print_options_defs): New file scoped variable.
2847         (make_info_print_options_def_group): New static function.
2848         (info_print_command_completer): New static function.
2849         (info_locals_command): Update to use new local functions.
2850         (info_args_command): Likewise.
2851         (_initialize_stack): Add extra parameter to calls to
2852         info_print_args_help.
2853         * symtab.c (search_symbols): Add extra parameter, use this to
2854         possibly excluse non-debug symbols.
2855         (symtab_symbol_info): Add extra parameter, which is passed on to
2856         search_symbols.
2857         (struct info_print_options): New type.
2858         (info_print_options_defs): New file scoped variable.
2859         (make_info_print_options_def_group): New static function.
2860         (info_print_command_completer): New static function.
2861         (info_variables_command): Update to use local functions, and pass
2862         extra parameter through to symtab_symbol_info.
2863         (info_functions_command): Likewise.
2864         (info_types_command): Pass additional argument through to
2865         symtab_symbol_info.
2866         (rbreak_command): Pass extra argument to search_symbols.
2867         (_initialize_symtab): Add extra arguments for calls to
2868         info_print_args_help, and update help text for 'info variables',
2869         'whereis', and 'info functions' commands.
2870         * symtab.h (search_symbols): Add extra argument to declaration.
2871         * NEWS: Mention new flags.
2872
2873 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2874
2875         * symtab.c (lookup_static_symbol): Call the new function (and move
2876         it down to be next to lookup_global_symbol).
2877         (struct global_sym_lookup_data): Add block_enum member and rename to...
2878         (struct global_or_static_sym_lookup_data): ...this.
2879         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2880         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2881         (lookup_symbol_global_or_static_iterator_cb): ...this.
2882         (lookup_global_or_static_symbol): New function.
2883         (lookup_global_symbol): Call new function.
2884
2885 2019-08-26  Tom de Vries  <tdevries@suse.de>
2886
2887         PR c++/24852
2888         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2889         when pc_probe.prob == NULL.
2890
2891 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2892
2893         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2894         variable symbol_linkage to symbol_linkage_.
2895
2896 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2897
2898         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2899         represent whether the symbol is static, dynamic, or we don't
2900         know.
2901
2902 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2903
2904         * gdb/rx-tdep.c (rx_register_names): New.
2905         (rx_register_name): Delete.
2906         (rx_psw_type): Delete.
2907         (rx_fpsw_type): Delete.
2908         (rx_register_type): Delete.
2909         (rx_gdbarch_init): Convert target-descriptions.
2910         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2911         * gdb/features/Makefile: Add rx.xml.
2912         * gdb/features/rx.xml: New.
2913         * gdb/features/rx.c: Generated.
2914         * gdb/NEWS: Mention target description support.
2915
2916 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2917
2918         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2919         *slot_ptr.
2920
2921 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2922
2923         * configure.ac: Don't check for 'dlfcn.h' (moved to
2924         gdbsupport/common.m4).
2925         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2926         'gdbsupport/'.
2927         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2928         * compile/compile-c-support.c: Include
2929         'gdbsupport/gdb-dlfcn.h'.
2930         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2931         * gdb-dlfcn.c: Move to...
2932         * gdbsupport/gdb-dlfcn.c: ... here.
2933         * gdb-dlfcn.h: Move to...
2934         * gdbsupport/gdb-dlfcn.h: ... here.
2935
2936 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2937
2938         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2939         the offset field signed.
2940
2941 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2942
2943         * python/lib/gdb/__init__.py (_execute_file): New function.
2944         * python/python.c (python_run_simple_file): Call gdb._execute_file
2945         on Windows.
2946
2947 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2948
2949         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2950         all uses as this was never set to anything but a zero value.
2951
2952 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2953
2954         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2955
2956 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2957
2958         * tui/tui-data.h (tui_gen_win_info): Add an =default
2959         move constructor, required by some GCC versions.
2960
2961 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2962
2963         * go32-nat.c (go32_sysinfo): Add hygon_p.
2964
2965 2019-08-20  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2968         line_from_reg_element_no, first_reg_element_no_inline,
2969         display_all_data, delete_data_content_windows,
2970         erase_data_content>: Now private.
2971
2972 2019-08-20  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2975         (tui_unhighlight_win, tui_highlight_win)
2976         (tui_win_info::make_window): Update.
2977         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2978
2979 2019-08-20  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2982         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2983         (MAX_PID_WIDTH): Move to tui-stack.c.
2984         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2985         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2986         (MAX_PID_WIDTH): Move from tui-data.h.
2987
2988 2019-08-20  Tom Tromey  <tom@tromey.com>
2989
2990         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2991         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2992         (box_win): Update.
2993         (tui_gen_win_info::make_window): Rename from tui_make_window.
2994         (tui_win_info::make_window): New method.
2995         (tui_gen_win_info::make_visible): Update.
2996         * tui/tui-source.c (tui_source_window::set_contents): Update.
2997         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2998         (tui_data_window::display_registers_from): Update.
2999         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3000         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3001         Declare.
3002         <can_box>: Remove.
3003         <title>: Remove.
3004         (struct tui_win_info) <make_window>: Declare.
3005         <can_box>: Now virtual.
3006         <title>: New member.
3007         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3008         * tui/tui-command.c (tui_cmd_window::resize): Update.
3009
3010 2019-08-20  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3013         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3014         (tui_data_window::check_register_values): Update.
3015
3016 2019-08-20  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-regs.h (struct tui_data_window): Use
3019         DISABLE_COPY_AND_ASSIGN.
3020         <regs_content>: Change type, removing unique_ptr.
3021         <tui_data_window>: Add move constructor.
3022         * tui/tui-regs.c (tui_data_window::show_registers)
3023         (tui_data_window::show_register_group)
3024         (tui_data_window::display_registers_from)
3025         (tui_data_window::display_registers_from)
3026         (tui_data_window::first_data_item_displayed)
3027         (tui_data_window::delete_data_content_windows)
3028         (tui_data_window::rerender, tui_data_window::refresh_window)
3029         (tui_data_window::check_register_values): Update.
3030
3031 2019-08-20  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3034         show_register_group>: Declare.
3035         (tui_show_register_group): Don't declare.
3036         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3037         tui_show_registers.
3038         (tui_data_window::show_register_group): Rename from
3039         tui_show_register_group.
3040         (tui_data_window::check_register_values, tui_reg_command):
3041         Update.
3042         * tui/tui-layout.c (tui_set_layout): Update.
3043
3044 2019-08-20  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3047         Declare.
3048         (tui_check_register_values): Don't declare.
3049         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3050         from tui_check_register_values.
3051         * tui/tui-hooks.c (tui_register_changed): Update.
3052
3053 2019-08-20  Tom Tromey  <tom@tromey.com>
3054
3055         * tui/tui-regs.c (tui_reg_layout): Move later.
3056         (tui_show_registers): Don't enable TUI mode or change layout.
3057
3058 2019-08-20  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-regs.h (struct tui_data_item_window)
3061         <~tui_data_item_window>: Remove.
3062         <content>: Now a unique_xmalloc_ptr.
3063         * tui/tui-regs.c (tui_register_format): Return a
3064         unique_xmalloc_ptr.
3065         (tui_get_register): Update.
3066         (~tui_data_item_window): Remove.
3067         (tui_data_window::display_registers_from, tui_display_register):
3068         Update.
3069         * tui/tui-io.h (tui_expand_tabs): Update.
3070         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3071         Remove "col" parameter.
3072
3073 2019-08-20  Tom Tromey  <tom@tromey.com>
3074
3075         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3076         field.
3077         * tui/tui-regs.c (~tui_data_item_window): Update.
3078
3079 2019-08-20  Tom Tromey  <tom@tromey.com>
3080
3081         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3082         earlier.
3083
3084 2019-08-20  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3087
3088 2019-08-20  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-source.h (struct tui_source_window): Update.
3091         * tui/tui-regs.c (tui_show_registers): Update.
3092         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3093         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3094         (NO_REGS_STRING): Remove defines.
3095
3096 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3097
3098         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3099         unnecessary thread walk if remote doesn't support the packet.
3100
3101 2019-08-19  Tom Tromey  <tromey@adacore.com>
3102
3103         * python/py-value.c (value_has_field): Fix indentation.
3104
3105 2019-08-19  Tom Tromey  <tromey@adacore.com>
3106
3107         * printcmd.c (do_one_display, info_display_command): Update.
3108         * block.h (contained_in): Return bool.  Add allow_nested
3109         parameter.
3110         * block.c (contained_in): Return bool.  Add allow_nested
3111         parameter.
3112
3113 2019-08-19  Tom Tromey  <tom@tromey.com>
3114
3115         * configure: Rebuild.
3116         * configure.ac: Disallow the combination of -static-libstdc++ and
3117         source highlight.
3118         * source-cache.c (get_language_name): Handle rust.
3119         (source_cache::get_source_lines): Ignore highlighting exceptions.
3120
3121 2019-08-16  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3124         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3125         (struct tui_source_window_base) <make_visible, refresh_window,
3126         resize>: Remove methods.
3127         <execution_info>: Remove field.
3128         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3129         (tui_show_source_line, tui_source_window_base)
3130         (~tui_source_window_base): Update.
3131         (tui_source_window_base::resize)
3132         (tui_source_window_base::make_visible)
3133         (tui_source_window_base::refresh_window): Remove.
3134         (tui_source_window_base::update_exec_info): Update.
3135         * tui/tui-source.c (tui_source_window::set_contents): Update.
3136         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3137
3138 2019-08-16  Tom Tromey  <tom@tromey.com>
3139
3140         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3141         deprecated_query_hook.
3142
3143 2019-08-16  Tom Tromey  <tom@tromey.com>
3144
3145         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3146         (tui_update_source_windows_with_line): Update.
3147         * tui/tui-source.h (struct tui_source_window)
3148         <show_symtab_source>: Declare.
3149         (tui_show_symtab_source): Don't declare.
3150         * tui/tui-source.c (tui_show_symtab_source): Rename from
3151         tui_show_symtab_source.
3152
3153 2019-08-16  Tom Tromey  <tom@tromey.com>
3154
3155         * tui/tui-winsource.h (struct tui_source_window_base)
3156         <set_contents>: Declare.
3157         * tui/tui-winsource.c
3158         (tui_source_window_base::update_source_window_as_is): Update.
3159         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3160         Declare.
3161         (tui_set_source_content): Don't declare.
3162         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3163         tui_set_source_content.
3164         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3165         Declare.
3166         (tui_set_disassem_content): Don't declare.
3167         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3168         tui_set_disassem_content.
3169
3170 2019-08-16  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-winsource.h (struct tui_source_window_base)
3173         <update_breakpoint_info>: Declare.
3174         (tui_update_breakpoint_info): Don't declare.
3175         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3176         (tui_update_all_breakpoint_info): Update.
3177         (tui_source_window_base::update_breakpoint_info): Rename from
3178         tui_update_breakpoint_info.
3179         (tui_source_window_base::update_exec_info): Update.
3180
3181 2019-08-16  Tom Tromey  <tom@tromey.com>
3182
3183         * tui/tui-winsource.h (struct tui_source_window_base)
3184         <update_source_window>: Declare.
3185         (tui_update_source_window): Don't declare.
3186         * tui/tui-winsource.c
3187         (tui_source_window_base::update_source_window): Rename from
3188         tui_update_source_window.
3189         (tui_source_window_base::rerender): Update.
3190         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3191         * tui/tui-disasm.c (tui_show_disassem)
3192         (tui_show_disassem_and_update_source)
3193         (tui_disasm_window::maybe_update): Update.
3194
3195 2019-08-16  Tom Tromey  <tom@tromey.com>
3196
3197         * tui/tui-winsource.h (struct tui_source_window_base)
3198         <update_source_window_as_is>: Declare.
3199         (tui_update_source_window_as_is): Don't declare.
3200         * tui/tui-winsource.c (tui_update_source_window): Update
3201         (tui_source_window_base::update_source_window_as_is): Rename from
3202         tui_update_source_window_as_is.
3203         (tui_source_window_base::refill): Update.
3204         * tui/tui-source.c (tui_show_symtab_source): Update.
3205         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3206         Update.
3207
3208 2019-08-16  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-winsource.h (tui_update_source_window)
3211         (tui_update_source_window_as_is): Remove "noerror" parameter.
3212         * tui/tui-winsource.c (tui_update_source_window)
3213         (tui_update_source_window_as_is): Remove "noerror" parameter.
3214         (tui_update_source_windows_with_addr)
3215         (tui_update_source_windows_with_line)
3216         (tui_source_window_base::rerender)
3217         (tui_source_window_base::refill): Update.
3218         * tui/tui-source.h (tui_set_source_content)
3219         (tui_show_symtab_source): Remove "noerror" parameter.
3220         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3221         parameter.
3222         (tui_show_symtab_source): Likewise.
3223         (tui_source_window::maybe_update): Update.
3224         * tui/tui-disasm.c (tui_show_disassem)
3225         (tui_show_disassem_and_update_source)
3226         (tui_disasm_window::do_scroll_vertical)
3227         (tui_disasm_window::maybe_update): Update.
3228
3229 2019-08-16  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui.c (tui_is_window_visible): Update.
3232         * tui/tui-wingeneral.c (tui_make_window)
3233         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3234         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3235         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3236         (tui_set_win_height_command, parse_scrolling_args): Update.
3237         * tui/tui-source.c (tui_source_window::style_changed): Update.
3238         * tui/tui-regs.c (tui_show_registers)
3239         (tui_data_window::first_data_item_displayed)
3240         (tui_data_window::delete_data_content_windows)
3241         (tui_check_register_values, tui_reg_command): Update.
3242         * tui/tui-disasm.c (tui_show_disassem): Update.
3243         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3244         method.
3245         <is_visible>: Remove field.
3246         * tui/tui-data.c (tui_next_win, tui_prev_win)
3247         (tui_delete_invisible_windows): Update.
3248
3249 2019-08-16  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui-winsource.h (struct tui_source_window_base)
3252         <m_has_locator>: Remove.
3253         * tui/tui-layout.c (show_source_disasm_command, show_data)
3254         (show_source_or_disasm_and_command): Update.
3255
3256 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3257
3258         * NEWS (Other MI changes): New subsection.
3259         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3260         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3261         * arch-utils.c (default_get_pc_address_flags): New function.
3262         * arch-utils.h (default_get_pc_address_flags): New declaration.
3263         * gdbarch.sh: Add get_pc_address_flags.
3264         * gdbarch.c: Regenerate.
3265         * gdbarch.h: Likewise.
3266         * stack.c (print_pc): New function.
3267         (print_frame_info) (print_frame): Call print_pc.
3268
3269 2019-08-16  Tom de Vries  <tdevries@suse.de>
3270
3271         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3272         print_objfile_section_info.
3273
3274 2019-08-15  Tom Tromey  <tom@tromey.com>
3275
3276         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3277         calling update_cmdwin_start_line.
3278         * tui/tui-winsource.h (struct tui_source_window_base)
3279         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3280         <rerender>: Declare.
3281         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3282         Call rerender.
3283         (tui_source_window_base::set_new_height): Remove.
3284         (tui_source_window_base::rerender): Rename from
3285         do_make_visible_with_new_height.
3286         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3287         resize method.
3288         (tui_win_info::make_invisible_and_set_new_height)
3289         (tui_win_info::make_visible_with_new_height): Remove.
3290         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3291         Declare.
3292         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3293         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3294         do_make_visible_with_new_height>: Don't declare.
3295         <rerender>: Declare.
3296         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3297         set_new_height.
3298         (tui_data_window::do_make_visible_with_new_height): Remove.
3299         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3300         call tui_show_locator_content.
3301         (tui_gen_win_info::resize): Call rerender.
3302         (show_source_or_disasm_and_command): Don't call
3303         tui_show_locator_content.
3304         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3305         method.
3306         (struct tui_win_info) <rerender>: Declare.
3307         <set_new_height, make_invisible_and_set_new_height,
3308         make_visible_with_new_height>: Don't declare.
3309         * tui/tui-data.c (tui_win_list::rerender): New method.
3310         * tui/tui-command.h (struct tui_cmd_window)
3311         <do_make_visible_with_new_height>: Don't declare.
3312         * tui/tui-command.c
3313         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3314
3315 2019-08-15  Tom Tromey  <tromey@adacore.com>
3316
3317         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3318         * ada-lang.c (ada_enum_name): Likewise.
3319
3320 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3321
3322         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3323         leading underscore.
3324         (GdbOutputErrorFile): Likewise.
3325         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3326         accordingly.
3327         (execute_unwinders): Rename to have a leading underscore.
3328         (auto_load_packages): Likewise.
3329         (global scope): Adjust call to auto_load_packages accordingly.
3330         (GdbSetPythonDirectory): Likewise.
3331         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3332         instead of execute_unwinders.
3333
3334 2019-08-15  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3337         (show_data): Don't change window visibility.
3338         (tui_gen_win_info::resize): Remove special case for command
3339         window.  Use wresize, when available.
3340         (show_source_or_disasm_and_command): Don't change window
3341         visibility.
3342         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3343         <make_visible>: New method.
3344         * tui/tui-command.c (tui_cmd_window::resize): New method.
3345
3346 2019-08-15  Tom Tromey  <tom@tromey.com>
3347
3348         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3349         (struct tui_source_windows): New.
3350         * tui/tui-winsource.c (tui_display_main): Update.
3351         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3352         (new_height_ok, parse_scrolling_args): Update.
3353         * tui/tui-layout.c (show_layout, show_data): Update.
3354         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3355         (tui_add_to_source_windows): Don't declare.
3356         * tui/tui-data.c (source_windows, tui_source_windows)
3357         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3358
3359 2019-08-15  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3362         Rename from reset.
3363         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3364         * tui/tui-layout.c (show_source_disasm_command, show_data):
3365         Update.
3366         (tui_gen_win_info::resize): Rename.
3367         (show_source_or_disasm_and_command): Update.
3368         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3369         reset.
3370
3371 2019-08-15  Tom Tromey  <tom@tromey.com>
3372
3373         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3374         * tui/tui-interp.c (tui_interp::init): Don't call
3375         tui_initialize_static_data.
3376         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3377
3378 2019-08-15  Tom Tromey  <tom@tromey.com>
3379
3380         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3381         examine tui_win_list.
3382
3383 2019-08-15  Tom Tromey  <tom@tromey.com>
3384
3385         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3386         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3387         tui_clear_source_content.
3388         (tui_clear_source_content): Remove.
3389         (tui_source_window_base::do_erase_source_content): Hoist call to
3390         content.clear().
3391         * tui/tui-stack.c (tui_show_frame_info): Don't call
3392         tui_clear_source_content.
3393
3394 2019-08-15  Tom Tromey  <tom@tromey.com>
3395
3396         * tui/tui-winsource.h (struct tui_source_window_base)
3397         <do_erase_source_content>: New method.
3398         <erase_source_content>: New method.
3399         (tui_erase_source_content): Don't declare.
3400         * tui/tui-winsource.c (tui_clear_source_content): Update.
3401         (tui_source_window_base::do_erase_source_content): Rename from
3402         tui_erase_source_content.
3403         (tui_source_window_base::show_source_content): Update.
3404         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3405         * tui/tui-source.h (struct tui_source_window)
3406         <erase_source_content>: New method.
3407         * tui/tui-disasm.h (struct tui_disasm_window)
3408         <erase_source_content>: New method.
3409
3410 2019-08-15  Tom Tromey  <tom@tromey.com>
3411
3412         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3413         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3414         constructor.
3415         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3416         * tui/tui-source.c (tui_set_source_content): Update.
3417         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3418
3419 2019-08-15  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3422         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3423         tui-source.c.
3424         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3425         Declare.
3426         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3427         method.
3428         (tui_source_window::maybe_update): Update.
3429
3430 2019-08-15  Tom Tromey  <tom@tromey.com>
3431
3432         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3433         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3434         tui-disasm.c.
3435         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3436         Declare.
3437         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3438         method.
3439         (tui_disasm_window::maybe_update): Update.
3440
3441 2019-08-15  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-winsource.h (struct tui_source_window_base)
3444         <maybe_update>: Declare.
3445         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3446         method.
3447         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3448         Declare.
3449         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3450         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3451         Declare.
3452         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3453
3454 2019-08-15  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3457
3458 2019-08-15  Tom Tromey  <tom@tromey.com>
3459
3460         * tui/tui-wingeneral.c: Include tui-stack.h.
3461         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3462         (struct tui_locator_window): Move from tui-data.h.
3463         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3464         (tui_initialize_static_data): Move from tui-data.c.
3465         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3466         (struct tui_locator_window): Move to tui-stack.c.
3467         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3468         (tui_initialize_static_data): Move to tui-stack.c.
3469
3470 2019-08-15  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-layout.c (show_source_disasm_command)
3473         (show_source_or_disasm_and_command): Use make_visible method, not
3474         tui_make_window.
3475         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3476         Remove.
3477
3478 2019-08-15  Tom Tromey  <tom@tromey.com>
3479
3480         * tui/tui-wingeneral.h (tui_make_window): Update.
3481         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3482         parameter.
3483         (tui_gen_win_info::make_visible): Update.
3484         * tui/tui-regs.c (tui_data_window::display_registers_from):
3485         Update.
3486         * tui/tui-layout.c (show_source_disasm_command)
3487         (show_source_or_disasm_and_command): Update.
3488         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3489         (enum tui_box): Remove.
3490         (struct tui_win_info) <can_box>: New method.
3491         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3492         method.
3493
3494 2019-08-15  Tom de Vries  <tdevries@suse.de>
3495
3496         * linux-nat-trad.c: Include gdbarch.h.
3497
3498 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3499
3500         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3501         register sizes.
3502
3503 2019-08-14  Tom Tromey  <tromey@adacore.com>
3504
3505         * darwin-nat.c: Include gdbarch.h.
3506         * darwin-nat-info.c: Include gdbarch.h.
3507
3508 2019-08-13  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3511         Remove.
3512         * tui/tui-data.c (tui_initialize_static_data): Update.
3513
3514 2019-08-13  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-winsource.h (struct tui_exec_info_window)
3517         <~tui_exec_info_window, maybe_allocate_content, get_content,
3518         m_content>: Remove.
3519         (struct tui_source_window_base) <set_exec_info_content,
3520         show_exec_info_content>: Don't declare.
3521         * tui/tui-winsource.c
3522         (tui_exec_info_window::maybe_allocate_content): Remove.
3523         (tui_source_window_base::update_exec_info): Rename from
3524         set_exec_info_content.
3525         (tui_source_window_base::show_exec_info_content)
3526         (tui_source_window_base::update_exec_info): Remove.
3527
3528 2019-08-13  Tom Tromey  <tom@tromey.com>
3529
3530         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3531         declare.
3532         * tui/tui-winsource.c (tui_update_source_window_as_is)
3533         (tui_update_source_windows_with_addr, tui_erase_source_content):
3534         Update.
3535         (tui_clear_exec_info_content): Remove.
3536
3537 2019-08-13  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3540         declare.
3541         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3542         call tui_erase_exec_info_content.
3543         (tui_clear_exec_info_content): Rename from
3544         tui_erase_exec_info_content.
3545         (tui_clear_exec_info_content): Delete.
3546
3547 2019-08-13  Tom Tromey  <tom@tromey.com>
3548
3549         * tui/tui-winsource.h (struct tui_source_window_base)
3550         <show_exec_info_content>: Declare.
3551         (tui_show_exec_info_content): Don't declare.
3552         * tui/tui-winsource.c
3553         (tui_source_window_base::show_exec_info_content): Rename from
3554         tui_show_exec_info_content.
3555         (tui_source_window_base::update_exec_info): Update.
3556
3557 2019-08-13  Tom Tromey  <tom@tromey.com>
3558
3559         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3560         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3561         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3562         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3563         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3564         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3565         ... here.
3566
3567 2019-08-13  Tom Tromey  <tom@tromey.com>
3568
3569         * tui/tui-winsource.h (struct tui_source_window_base)
3570         <update_exec_info>: Declare.
3571         (tui_update_exec_info): Don't declare.
3572         * tui/tui-winsource.c (tui_update_source_window_as_is)
3573         (tui_source_window_base::refresh_all)
3574         (tui_update_all_breakpoint_info): Update.
3575         (tui_source_window_base::update_exec_info): Rename from
3576         tui_update_exec_info.
3577         * tui/tui-stack.c (tui_show_frame_info): Update.
3578
3579 2019-08-13  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-winsource.h (struct tui_source_window_base)
3582         <set_exec_info_content>: Declare.
3583         (tui_set_exec_info_content): Don't declare.
3584         * tui/tui-winsource.c
3585         (tui_source_window_base::set_exec_info_content): Rename from
3586         tui_set_exec_info_content.
3587         (tui_update_exec_info): Update.
3588
3589 2019-08-13  Tom Tromey  <tom@tromey.com>
3590
3591         * tui/tui-winsource.h (struct tui_source_window_base)
3592         <show_source_content>: Declare.
3593         (tui_show_source_content): Don't declare.
3594         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3595         (tui_source_window_base::show_source_content): Rename from
3596         tui_show_source_content.
3597         (tui_source_window_base::refresh_all): Update.
3598         * tui/tui-layout.c (show_source_disasm_command)
3599         (show_source_or_disasm_and_command): Update.
3600
3601 2019-08-13  Tom Tromey  <tom@tromey.com>
3602
3603         * tui/tui-winsource.c (tui_erase_source_content)
3604         (tui_show_source_content, tui_source_window_base::refresh_all):
3605         Update.
3606         * tui/tui-wingeneral.h
3607         (tui_check_and_display_highlight_if_needed): Don't declare.
3608         * tui/tui-wingeneral.c
3609         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3610         check_and_display_highlight_if_needed.
3611         * tui/tui-win.c (tui_rehighlight_all)
3612         (tui_win_info::make_visible_with_new_height): Update.
3613         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3614         (tui_data_window::erase_data_content)
3615         (tui_data_window::display_all_data): Update.
3616         * tui/tui-data.h (struct tui_win_info)
3617         <check_and_display_highlight_if_needed>: Declare.
3618
3619 2019-08-13  Tom Tromey  <tom@tromey.com>
3620
3621         * tui/tui-win.c (tui_resize_all): Call
3622         tui_delete_invisible_windows.
3623         * tui/tui-layout.c (show_layout): Call
3624         tui_delete_invisible_windows.
3625         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3626         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3627
3628 2019-08-13  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3631         tui_add_win_to_layout.
3632
3633 2019-08-13  Tom Tromey  <tom@tromey.com>
3634
3635         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3636         * tui/tui-layout.c (tui_default_win_height): Now static.
3637
3638 2019-08-13  Tom Tromey  <tom@tromey.com>
3639
3640         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3641         single switch.
3642         (show_source_disasm_command, show_source_or_disasm_and_command):
3643         Don't check current layout.
3644
3645 2019-08-13  Tom Tromey  <tom@tromey.com>
3646
3647         * tui/tui-wingeneral.c (make_all_visible): Remove.
3648         (tui_make_all_invisible): Simplify.
3649         * tui/tui-layout.c (tui_make_all_invisible): Move from
3650         tui-wingeneral.c; simplify.
3651         (show_layout): Hoist call to tui_make_all_invisible.
3652         (show_data): Don't call tui_make_all_invisible.
3653
3654 2019-08-13  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3657         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3658
3659 2019-08-13  Tom Tromey  <tom@tromey.com>
3660
3661         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3662         tui-data.c.
3663         (show_source_disasm_command, show_data)
3664         (show_source_or_disasm_and_command): Don't use
3665         tui_set_current_layout_to.
3666         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3667         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3668         tui-layout.c.
3669         (tui_set_current_layout_to): Remove.
3670
3671 2019-08-13  Tom Tromey  <tom@tromey.com>
3672
3673         * tui/tui-layout.c (tui_set_layout): Update.
3674         * tui/tui-data.h (struct tui_layout_def): Remove.
3675         (tui_layout_def): Don't declare.
3676         * tui/tui-data.c (layout_def): Remove.
3677         (tui_layout_def): Remove.
3678
3679 2019-08-13  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-winsource.h (struct tui_source_window_base)
3682         <clear_detail>: No longer "override".
3683         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3684         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3685         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3686         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3687         Remove.
3688         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3689
3690 2019-08-13  Tom Tromey  <tromey@adacore.com>
3691
3692         * tracepoint.c: Don't include readline.h or history.h.
3693
3694 2019-08-12  Tom Tromey  <tom@tromey.com>
3695
3696         * configure: Rebuild.
3697         * configure.ac: Check for readline 7.
3698         * NEWS: Mention readline 7 requirement.
3699         * README: Update.
3700
3701 2019-08-12  Tom Tromey  <tom@tromey.com>
3702
3703         * mingw-hdep.c (gdb_select): Remove readline hack.
3704
3705 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3706
3707         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3708         when the function fails.
3709
3710 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3711
3712         * s390-tdep.c (s390_type_align): New function.
3713         (s390_gdbarch_init): Set it as type_align gdbarch method.
3714
3715 2019-08-09  Tom de Vries  <tdevries@suse.de>
3716
3717         PR gdb/24591
3718         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3719         pc_low with relocation offset.
3720
3721 2019-08-07  Tom Tromey  <tromey@adacore.com>
3722
3723         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3724         (print_frame_args): Update.
3725         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3726         Update.
3727         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3728         * frame.h (struct frame_arg): Add initializers.
3729         <error>: Now a unique_xmalloc_ptr.
3730
3731 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3732
3733         * NEWS: Expand the Pointer Authentication entry.
3734         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3735         (aarch64_frame_unmask_lr): ... to this.
3736         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3737         Call aarch64_frame_unmask_lr.
3738         * frame.c (struct frame_info): Add "masked" variable.
3739         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3740         (fprint_frame): Check for masked pc.
3741         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3742         declarations.
3743         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3744         * stack.c (print_frame): Check for masked pc.
3745
3746 2019-08-06  Tom Tromey  <tom@tromey.com>
3747
3748         * stabsread.c (patch_block_stabs, read_one_struct_field)
3749         (read_enum_type): Use obstack_strndup.
3750         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3751         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3752         * dwarf2read.c (guess_full_die_structure_name)
3753         (anonymous_struct_prefix): Use obstack_strndup.
3754         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3755         * c-exp.y (yylex): Use obstack_strndup.
3756         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3757         (write_var_or_type): Use obstack_strndup.
3758
3759 2019-08-06  Tom Tromey  <tom@tromey.com>
3760
3761         * symfile.c (reread_symbols): Use obstack_strdup.
3762         * stabsread.c (read_type): Use obstack_strdup.
3763         * gdb_obstack.h (obstack_strdup): New overload.
3764         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3765         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3766         (dwarf2_canonicalize_name): Use obstack_strdup.
3767         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3768         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3769         Use obstack_strdup.
3770
3771 2019-08-06  Tom Tromey  <tom@tromey.com>
3772
3773         * gdb_obstack.h (obstack_strdup): Define.
3774         * gdb_obstack.c (obstack_strdup): Don't define.
3775
3776 2019-08-06  Tom Tromey  <tom@tromey.com>
3777
3778         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3779         obstack_strdup.
3780         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3781         obstack_strdup.
3782         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3783         * stabsread.c (common_block_start): Use obstack_strdup.
3784         * objfiles.c (set_objfile_main_name, objfile): Use
3785         obstack_strdup.
3786         * namespace.c (add_using_directive): Use obstack_strdup.
3787         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3788         * jit.c (finalize_symtab): Use obstack_strdup.
3789         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3790         (guess_partial_die_structure_name, partial_die_info::fixup)
3791         (dwarf2_name): Use obstack_strdup.
3792         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3793         obstack_strdup.
3794         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3795         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3796         obstack_strdup.
3797         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3798
3799 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3800
3801         * unittests/help-doc-selftests.c: New file.
3802         * Makefile.in: Add the new file.
3803
3804 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3805
3806         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3807         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3808         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3809         the trailing '.' is not output, and the first character is uppercased.
3810         (print_help_for_command): Update call to print_doc_line.
3811         (print_doc_of_command): Likewise.
3812         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3813         * cli/cli-option.c (append_indented_doc): Do not append newline.
3814         (build_help_option): Append newline after first appended_indented_doc
3815         only if a second call is done.
3816         (build_help): Append 2 new lines before each option, except the first
3817         one.
3818         * compile/compile.c (_initialize_compile): Add new lines after
3819         %OPTIONS%, when not at the end of the help.
3820         Change help doc or code
3821         producing the help doc to respect the invariants.
3822         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3823         Also removed the new line after 'Options:', as all other commands
3824         do not put an empty line between 'Options:' and the first option.
3825         * printcmd.c (_initialize_printcmd): Likewise.
3826         * stack.c (_initialize_stack): Likewise.
3827         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3828         incorrectly telling COMMAND is optional.
3829         * ada-lang.c (_initialize_ada_language): Change help doc or code
3830         producing the help doc to respect the invariants.
3831         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3832         * breakpoint.c (_initialize_breakpoint): Likewise.
3833         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3834         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3835         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3836         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3837         _initialize_cli_style): Likewise.
3838         * corelow.c (core_target_info): Likewise.
3839         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3840         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3841         * filesystem.c (_initialize_filesystem): Likewise.
3842         * frame.c (_initialize_frame): Likewise.
3843         * gnu-nat.c (add_task_commands): Likewise.
3844         * infcall.c (_initialize_infcall): Likewise.
3845         * infcmd.c (_initialize_infcmd): Likewise.
3846         * interps.c (_initialize_interpreter): Likewise.
3847         * language.c (_initialize_language): Likewise.
3848         * linux-fork.c (_initialize_linux_fork): Likewise.
3849         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3850         * maint.c (_initialize_maint_cmds): Likewise.
3851         * memattr.c (_initialize_mem): Likewise.
3852         * printcmd.c (_initialize_printcmd): Likewise.
3853         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3854         _RegEx): Likewise.
3855         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3856         * record-btrace.c (_initialize_record_btrace): Likewise.
3857         * record-full.c (_initialize_record_full): Likewise.
3858         * record.c (_initialize_record): Likewise.
3859         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3860         * regcache.c (_initialize_regcache): Likewise.
3861         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3862         _initialize_remote): Likewise.
3863         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3864         * serial.c (_initialize_serial): Likewise.
3865         * skip.c (_initialize_step_skip): Likewise.
3866         * source.c (_initialize_source): Likewise.
3867         * stack.c (_initialize_stack): Likewise.
3868         * symfile.c (_initialize_symfile): Likewise.
3869         * symtab.c (_initialize_symtab): Likewise.
3870         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3871         * top.c (init_main): Likewise.
3872         * tracefile-tfile.c (tfile_target_info): Likewise.
3873         * tracepoint.c (_initialize_tracepoint): Likewise.
3874         * tui/tui-win.c (_initialize_tui_win): Likewise.
3875         * utils.c (add_internal_problem_command): Likewise.
3876         * valprint.c (value_print_option_defs): Likewise.
3877
3878 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3879
3880         PR build/24886
3881         * configure.ac: Drop enable-libmcheck support.
3882         * configure, config.in: Rebuild.
3883         * libmcheck.m4: Remove.
3884         * acinclude.m4: Don't include it.
3885         * Makefile.in: Don't distribute it.
3886         * top.c (print_gdb_configuration): Don't mention it.
3887
3888 2019-08-06  Tom Tromey  <tom@tromey.com>
3889
3890         * utils.c (set_output_style): Sometimes pass stream to
3891         emit_style_escape.
3892         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3893         * record-btrace.c (btrace_insn_history): Update.
3894         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3895         method.
3896         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3897         Update initializers.
3898         <m_uiout>: New field.
3899         <m_di>: Move lower.
3900         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3901         Remove "uiout" parameter.
3902         (dump_insns): Update.
3903         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3904         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3905
3906 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3907
3908         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3909         (error_in_psymtab_expansion): Likewise.
3910         (lookup_symbol_via_quick_fns): Likewise.
3911         (basic_lookup_transparent_type_quick): Likewise.
3912         (basic_lookup_transparent_type_1): Likewise.
3913
3914 2019-08-06  Tom Tromey  <tromey@adacore.com>
3915
3916         * source.c (last_source_error): Now bool.
3917         (print_source_lines_base): Make "noprint" bool.  Only open
3918         source file when last_source_visited changes.
3919
3920 2019-08-06  Tom Tromey  <tromey@adacore.com>
3921
3922         * annotate.c (annotate_source_line): Use g_source_cache.
3923         * source-cache.c (source_cache::get_plain_source_lines): Change
3924         parameters.  Populate m_offset_cache.
3925         (source_cache::ensure): New method.
3926         (source_cache::get_line_charpos): New method.
3927         (extract_lines): Move lower.  Change parameters.
3928         (source_cache::get_source_lines): Move lower.
3929         * source-cache.h (class source_cache): Update comment.
3930         <get_line_charpos>: New method.
3931         <get_source_lines>: Update comment.
3932         <clear>: Clear m_offset_cache.
3933         <get_plain_source_lines>: Change parameters.
3934         <ensure>: New method
3935         <m_offset_cache>: New member.
3936         * source.c (forget_cached_source_info_for_objfile): Update.
3937         (info_source_command): Use g_source_cache.
3938         (find_source_lines, open_source_file_with_line_charpos): Remove.
3939         (print_source_lines_base, search_command_helper): Use g_source_cache.
3940         * source.h (open_source_file_with_line_charpos): Don't declare.
3941         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3942         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3943         Use g_source_cache.
3944
3945 2019-08-06  Tom Tromey  <tromey@adacore.com>
3946
3947         * source-cache.c (source_cache::get_plain_source_lines):
3948         Remove "first_line" and "last_line" parameters.
3949         (source_cache::get_source_lines): Cache plain text.
3950         * source-cache.h (class source_cache)
3951         <get_plain_source_lines>: Update.
3952
3953 2019-08-06  Tom Tromey  <tromey@adacore.com>
3954
3955         * source-cache.c (extract_lines): No longer a method.
3956         Changed type of parameter.  Include final newline.
3957         (selftests::extract_lines_test): New function.
3958         (_initialize_source_cache): Likewise.
3959         * source-cache.h (class source_cache)
3960         <extract_lines>: Don't declare.
3961
3962 2019-08-06  Tom Tromey  <tromey@adacore.com>
3963
3964         * breakpoint.c (init_breakpoint_sal): Update.
3965         (breakpoint): Update.
3966         * breakpoint.h (struct breakpoint) <filter>: Now a
3967         unique_xmalloc_ptr.
3968
3969 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3970
3971         * NEWS: Mention dictionary access on blocks.
3972         * python/py-block.c (blpy_getitem): New function.
3973         (block_object_as_mapping): New struct.
3974         (block_object_type): Use new struct for tp_as_mapping field.
3975
3976 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3977
3978         * objfiles.h (objfile): Add a comment describing partial symbols.
3979
3980 2019-08-05  Tom Tromey  <tromey@adacore.com>
3981
3982         * compile/compile.c (_initialize_compile): Use _(), not N_().
3983         * thread.c (_initialize_thread): Use _(), not N_().
3984         * stack.c (_initialize_stack): Use _(), not N_().
3985         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3986
3987 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3988
3989         * dwarf2read.c (struct dw2_symtab_iterator):
3990         <want_specific_block>: Remove.
3991         <block_index>: Change type to gdb::optional.
3992         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3993         change type of BLOCK_INDEX parameter to gdb::optional.
3994         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3995         (dw2_lookup_symbol): Don't pass argument for
3996         WANT_SPECIFIC_BLOCK.
3997         (dw2_expand_symtabs_for_function): Don't pass argument for
3998         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3999         (class dw2_debug_names_iterator)
4000         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4001         parameter, change BLOCK_INDEX type to gdb::optional.
4002         <m_want_specific_block>: Remove.
4003         <m_block_index>: Change type to gdb::optional.
4004         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4005         gdb::optional.  Re-write in function of gdb::optional.
4006         (dw2_debug_names_lookup_symbol): Don't pass argument for
4007         WANT_SPECIFIC_BLOCK.
4008         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4009         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4010         BLOCK_INDEX.
4011
4012 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4013
4014         * NEWS: Mention changes to "info sources" command.
4015
4016 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4017
4018         * symtab.c (filename_partial_match_opts): New struct type.
4019         (struct output_source_filename_data): New members
4020         regexp, c_regexp, partial_match.
4021         (output_source_filename): Use new members to decide to print file.
4022         (info_sources_option_defs): New variable.
4023         (make_info_sources_options_def_group, print_info_sources_header,
4024         info_sources_command_completer):
4025         New functions.
4026         (info_sources_command): Read new optional arguments.
4027         (_initialize_symtab): Update info sources help.
4028
4029 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4030
4031         * ada-lang.c (exception_support_info_v0): Renamed from...
4032         (default_exception_support_info): ... this.  Create new
4033         definition for v1.
4034         (ada_has_this_exception_support): Look up catch_handlers_sym.
4035         (ada_exception_support_info_sniffer): Try v0 after default.
4036
4037 2019-08-01  Tom Tromey  <tromey@adacore.com>
4038
4039         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4040         gdbarch.h.
4041
4042 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4043
4044         * s12z-tdep.c: Fix include path for s12z-opc.h.
4045
4046 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4047
4048         * NEWS: Require GNU make 3.82.
4049
4050 2019-07-16  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4053         declare.
4054
4055 2019-07-30  Tom Tromey  <tromey@adacore.com>
4056
4057         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4058
4059 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4060
4061         * printcmd.c (print_address_symbolic): Print negative offsets.
4062         (build_address_symbolic): Force signed arithmetic when computing
4063         offset.
4064
4065 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4066
4067         PR/24474: Add a function to lookup static variables.
4068         * NEWS: Mention this new function.
4069         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4070         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4071         * python/python.c (python_GdbMethods): Add new function.
4072
4073 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4074
4075         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4076         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4077         (objfpy_lookup_static_symbol): New function.
4078         (objfile_object_methods): Add new functions.
4079
4080 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4081
4082         * NEWS: Mention 'set|show print frame-info'.  Mention new
4083         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4084         backtrace argument.  Mention that python frame filtering code
4085         is now consistent with what 'backtrace' command prints.
4086
4087 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4088
4089         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4090         comments.
4091         (print_frame_info_auto, print_frame_info_source_line,
4092         print_frame_info_location, print_frame_info_source_and_location,
4093         print_frame_info_location_and_address, print_frame_info_short_location):
4094         New declarations.
4095         (struct frame_print_options): New member print_frame_info.
4096         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4097         * stack.h (get_user_print_what_frame_info): New declaration.
4098         (frame_show_address): New declaration.
4099         * stack.c (print_frame_arguments_choices): New value 'presence'.
4100         (print_frame_info_auto, print_frame_info_source_line,
4101         print_frame_info_location, print_frame_info_source_and_location,
4102         print_frame_info_location_and_address, print_frame_info_short_location,
4103         print_frame_info_choices, print_frame_info_print_what): New definitions.
4104         (print_frame_args): Only print dots for args if print frame-arguments
4105         is 'presence'.
4106         (frame_print_option_defs): New element for "frame-info".
4107         (get_user_print_what_frame_info): New function.
4108         (frame_show_address): Make non static.  Move comment to stack.h.
4109         (print_frame_info_to_print_what): New function.
4110         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4111         to decide what to print.
4112         (backtrace_command_1): Handle the new print_frame_arguments_presence
4113         value.
4114         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4115         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4116         (py_print_frame): In non-mi mode, use LOCATION as default for
4117         print_what, similarly to frame information printed directly by
4118         backtrace command. Handle frame-info user option in non MI mode.
4119
4120 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4121
4122         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4123         Add case for debugging 32-bit target on 64-bit host.  Revise
4124         comment.
4125
4126 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4127
4128         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4129         instead of find_function_entry_range_from_pc.
4130
4131 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4132
4133         * stack.c (find_frame_funname): Remove code which preferred
4134         minsym over symtab sym in "certain pathological cases".
4135
4136         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4137         parameter.  Change type of "do_demangle" to bool.
4138         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4139         Pass suitable "prefer_sym_over_minsym" flag to
4140         build_address_symbolic().  Don't output "+" for negative offsets.
4141         * printcmd.c (print_address_symbolic): Update invocation of
4142         build_address_symbolic to include a "prefer_sym_over_minsym"
4143         flag.
4144         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4145         Restrict cases in which use of minimal symbol is preferred to that
4146         of a found symbol.  Update comments.
4147
4148         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4149         for entry pc when entry pc is out of range for that FDE.
4150
4151 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4152
4153         PR gdb/24839:
4154         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4155         type.
4156
4157 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4158
4159         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4160         this function's Python signature.
4161
4162
4163 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4164
4165         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4166         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4167         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4168         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4169         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4170
4171
4172 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4173
4174         * h8300-tdep.c (h8300_register_name_common): New.
4175         h8300_register_name): Use h8300_register_name_common.
4176         (h8300s_register_name): Likewise.
4177         (h8300sx_register_name): Likewise.
4178         (h8300h_register_nam): New.
4179         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4180
4181
4182 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4183
4184         * arm-tdep.c (arm_skip_cmse_entry): New function.
4185         (arm_is_sgstubs_section): New function.
4186         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4187
4188 2019-07-22  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4191         Don't self-assign.
4192
4193 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4196         type_print.
4197
4198 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4201         so that GDB doesn't match any msymbols when searching in the
4202         TYPES_DOMAIN.
4203         (print_symbol_info): Print using typedef_print or type_print based
4204         on the type of the symbol.  Add updated FIXME comment moved from...
4205         (_initialize_symtab): ... move and update FIXME comment to above.
4206
4207 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4208
4209         * NEWS: Mention adding -q option to "info types".
4210         * symtab.c (struct info_types_options): New struct.
4211         (info_types_options_defs): New variable.
4212         (make_info_types_options_def_group): New function.
4213         (info_types_command): Use gdb::option framework to parse options.
4214         (info_types_command_completer): New function.
4215         (_initialize_symtab): Extend the help text on "info types" and
4216         register command completer.
4217
4218 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4219
4220         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4221         (lookup_symbol_in_objfile): Change int to block_enum and add a
4222         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4223
4224 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4225
4226         * MAINTAINERS (Write After Approval): Add self.
4227
4228 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4231         instruction to the dummy code region.
4232
4233 2019-07-19  Tom Tromey  <tromey@adacore.com>
4234
4235         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4236         (ARGSUSED, PARAMS, __func__): Remove rules.
4237
4238 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4239
4240         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4241         * features/arm/arm-with-iwmmxt.c: Remove.
4242         * features/arm/arm-with-iwmmxt.xml: Remove.
4243         * features/arm/arm-with-m-fpa-layout.c: Remove.
4244         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4245         * features/arm/arm-with-m-vfp-d16.c: Remove.
4246         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4247         * features/arm/arm-with-m.c: Remove.
4248         * features/arm/arm-with-m.xml: Remove.
4249         * features/arm/arm-with-neon.c: Remove.
4250         * features/arm/arm-with-neon.xml: Remove.
4251         * features/arm/arm-with-vfpv2.c: Remove.
4252         * features/arm/arm-with-vfpv2.xml: Remove.
4253         * features/arm/arm-with-vfpv3.c: Remove.
4254         * features/arm/arm-with-vfpv3.xml: Remove.
4255
4256 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4257
4258         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4259
4260 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4261
4262         * arch/aarch32.c (aarch32_create_target_description): Create
4263         target descriptions using features.
4264         * arch/arm.c (arm_create_target_description)
4265         (arm_create_mprofile_target_description): Likewise.
4266         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4267
4268 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4269
4270         * Makefile.in: Add new files.
4271         * aarch32-tdep.c: New file.
4272         * aarch32-tdep.h: New file.
4273         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4274         Call aarch32_read_description.
4275         * arch/aarch32.c: New file.
4276         * arch/aarch32.h: New file.
4277         * arch/arm.c (arm_create_target_description)
4278         (arm_create_mprofile_target_description): New function.
4279         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4280         (arm_create_target_description)
4281         (arm_create_mprofile_target_description): New declaration.
4282         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4283         read_description functions.
4284         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4285         Likewise.
4286         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4287         * arm-tdep.c (tdesc_arm_list): New variable.
4288         (arm_register_g_packet_guesses): Call create description functions.
4289         (arm_read_description) (arm_read_mprofile_description): New
4290         function.
4291         * arm-tdep.h (arm_read_description)
4292         (arm_read_mprofile_description): Add declaration.
4293         * configure.tgt: Add new files.
4294
4295 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4296
4297         * top.c (new_ui_command): Open specified terminal just once.
4298
4299 2019-07-18  Tom Tromey  <tromey@adacore.com>
4300
4301         * symtab.c (main_name): Constify return type.
4302         * symfile.c (set_initial_language): Update.
4303         * symtab.h (main_name): Constify return type.
4304
4305 2019-07-17  Tom Tromey  <tom@tromey.com>
4306
4307         * tui/tui-winsource.c (tui_update_source_window)
4308         (tui_update_source_window_as_is)
4309         (tui_update_source_windows_with_line): Remove return.
4310         * tui/tui-disasm.c (tui_show_disassem)
4311         (tui_show_disassem_and_update_source): Remove return.
4312         * tui/tui.c (tui_reset): Remove return.
4313         * tui/tui-wingeneral.c
4314         (tui_check_and_display_highlight_if_needed): Remove return.
4315
4316 2019-07-17  Tom Tromey  <tom@tromey.com>
4317
4318         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4319
4320 2019-07-17  Tom Tromey  <tom@tromey.com>
4321
4322         * tui/tui-winsource.h (struct tui_exec_info_window)
4323         (struct tui_source_window_base): Move from tui-data.h.
4324         * tui/tui-winsource.c: Move many method definitions from
4325         elsewhere.  Remove "structuring" comments.
4326         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4327         (tui_source_window_base::refresh_window): Move to
4328         tui-winsource.c.
4329         * tui/tui-win.c (tui_source_window_base::refresh_all)
4330         (tui_source_window_base::update_tab_width)
4331         (tui_source_window_base::set_new_height)
4332         (tui_source_window_base::do_make_visible_with_new_height): Move to
4333         tui-winsource.c.
4334         * tui/tui-source.h: Update.
4335         * tui/tui-source.c (tui_source_window_base::reset): Move to
4336         tui-winsource.c.
4337         * tui/tui-disasm.h: Update.
4338         * tui/tui-data.h (struct tui_exec_info_window): Move to
4339         tui-winsource.h.
4340         (struct tui_source_window_base): Likewise.
4341         * tui/tui-data.c (tui_source_window_base::clear_detail)
4342         (tui_source_window_base, ~tui_source_window_base): Move to
4343         tui-winsource.c.
4344
4345 2019-07-17  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-win.c (tui_resize_all)
4348         (tui_source_window_base::update_tab_width)
4349         (tui_adjust_win_heights): Update.
4350         (tui_win_info::make_invisible_and_set_new_height): Rename from
4351         make_invisible_and_set_new_height.
4352         * tui/tui-data.h (struct tui_win_info)
4353         <make_invisible_and_set_new_height>: New method.
4354
4355 2019-07-17  Tom Tromey  <tom@tromey.com>
4356
4357         * tui/tui.c: Update.
4358         * tui/tui-source.h (struct tui_source_window): Move from
4359         tui-data.h.
4360         * tui/tui-layout.c: Update.
4361         * tui/tui-disasm.c: Update.
4362         * tui/tui-data.h (struct tui_source_window): Move to
4363         tui-source.h.
4364
4365 2019-07-17  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4368         tui-data.h.
4369         * tui/tui-data.h (struct tui_disasm_window): Move to
4370         tui-disasm.h.
4371
4372 2019-07-17  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui-regs.h (struct tui_data_item_window): Move from
4375         tui-data.h.
4376         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4377         * tui/tui-data.h (struct tui_data_item_window): Move to
4378         tui-regs.h.
4379         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4380
4381 2019-07-17  Tom Tromey  <tom@tromey.com>
4382
4383         * tui/tui.c: Update.
4384         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4385         (tui_cmd_window::max_height): Move to tui-command.c.
4386         * tui/tui-layout.c: Update.
4387         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4388         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4389         tui-command.c.
4390         * tui/tui-command.h (struct tui_cmd_window): Move from
4391         tui-data.h.
4392         * tui/tui-command.c: Remove "structuring" comments.
4393         (tui_cmd_window::clear_detail)
4394         (tui_cmd_window::do_make_visible_with_new_height)
4395         (tui_cmd_window::max_height): Move from elsewhere.
4396
4397 2019-07-17  Tom Tromey  <tom@tromey.com>
4398
4399         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4400         Now static.
4401         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4402         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4403
4404 2019-07-17  Tom Tromey  <tom@tromey.com>
4405
4406         * tui/tui.c: Update.
4407         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4408         tui-regs.c.
4409         * tui/tui-windata.h: Remove file.
4410         * tui/tui-windata.c: Remove file.
4411         * tui/tui-win.c (tui_data_window::set_new_height)
4412         (tui_data_window::do_make_visible_with_new_height): Move to
4413         tui-regs.c.
4414         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4415         * tui/tui-regs.c: Remove "structuring" comments.
4416         (tui_data_window::first_data_item_displayed)
4417         (tui_data_window::delete_data_content_windows)
4418         (tui_data_window::erase_data_content)
4419         (tui_data_window::display_all_data)
4420         (tui_data_window::refresh_all)
4421         (tui_data_window::do_scroll_vertical)
4422         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4423         (tui_data_window::do_make_visible_with_new_height)
4424         (tui_data_window::refresh_window): Move from elsewhere.
4425         (_initialize_tui_regs): Move to end of file.
4426         * tui/tui-layout.c: Update.
4427         * tui/tui-hooks.c: Update.
4428         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4429         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4430         tui-regs.c.
4431         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4432
4433 2019-07-17  Tom Tromey  <tom@tromey.com>
4434
4435         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4436         seen.
4437
4438 2019-07-17  Tom Tromey  <tom@tromey.com>
4439
4440         * tui/tui-win.c (tui_source_window_base::set_new_height)
4441         (tui_source_window_base::do_make_visible_with_new_height): Use
4442         m_has_locator field directly.
4443         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4444         method.
4445         (struct tui_source_window_base) <has_locator>: Likewise.
4446
4447 2019-07-17  Tom Tromey  <tom@tromey.com>
4448
4449         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4450         Don't declare.
4451         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4452         Remove.
4453         * tui/tui-win.c (tui_source_window_base::set_new_height)
4454         (tui_source_window_base::set_new_height)
4455         (make_invisible_and_set_new_height)
4456         (tui_source_window_base::do_make_visible_with_new_height)
4457         (tui_source_window_base::do_make_visible_with_new_height):
4458         Update.
4459         * tui/tui-layout.c (show_source_disasm_command, show_data)
4460         (show_source_or_disasm_and_command): Update.
4461         * tui/tui-layout.c (show_layout): Update.
4462
4463 2019-07-17  Tom Tromey  <tom@tromey.com>
4464
4465         * tui/tui-layout.c (make_data_window): Remove.
4466         (show_data): Unify creation and re-initialization cases.
4467
4468 2019-07-17  Tom Tromey  <tom@tromey.com>
4469
4470         * tui/tui-layout.c (make_source_window, make_disasm_window):
4471         Remove.
4472         (show_data): Unify creation and re-initialization cases.
4473
4474 2019-07-17  Tom Tromey  <tom@tromey.com>
4475
4476         * tui/tui-layout.c (make_command_window): Remove.
4477         (show_source_disasm_command, show_source_or_disasm_and_command):
4478         Unify creation and re-initialization cases.
4479
4480 2019-07-17  Tom Tromey  <tom@tromey.com>
4481
4482         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4483         creation and re-initialization cases.
4484
4485 2019-07-17  Tom Tromey  <tom@tromey.com>
4486
4487         * tui/tui-regs.c (tui_get_register): Return void.
4488
4489 2019-07-17  Tom Tromey  <tom@tromey.com>
4490
4491         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4492         Simplify.
4493
4494 2019-07-17  Tom Tromey  <tom@tromey.com>
4495
4496         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4497         resetting.
4498
4499 2019-07-17  Tom Tromey  <tom@tromey.com>
4500
4501         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4502         * tui/tui-regs.c (tui_reg_layout): New function.
4503         (tui_show_registers, tui_reg_command): Use it.
4504         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4505         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4506         parameters.
4507         (tui_layout_command): Remove.
4508
4509 2019-07-17  Tom Tromey  <tom@tromey.com>
4510
4511         * tui/tui-layout.h (tui/tui-layout): Return void.
4512         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4513
4514 2019-07-17  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-layout.c (show_source_disasm_command, show_data):
4517         Update.
4518         (reset_locator): Remove.
4519         (show_source_or_disasm_and_command): Update.
4520
4521 2019-07-17  Tom Tromey  <tom@tromey.com>
4522
4523         * tui/tui-source.c (tui_source_window_base::reset): Remove
4524         win_type parameter.
4525         * tui/tui-layout.c (make_command_window, make_source_window)
4526         (make_disasm_window, make_data_window)
4527         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4528         (reset_locator, show_source_or_disasm_and_command): Update.
4529         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4530         win_type parameter.
4531         (struct tui_source_window_base) <reset>: Likewise.
4532
4533 2019-07-17  Tom Tromey  <tom@tromey.com>
4534
4535         * tui/tui-layout.c (show_source_disasm_command): Use
4536         reset_locator.
4537         (reset_locator): New function.
4538         (init_and_make_win): Remove.
4539         (show_source_or_disasm_and_command): Use reset_locator.
4540
4541 2019-07-17  Tom Tromey  <tom@tromey.com>
4542
4543         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4544         condition.
4545         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4546         Remove condition.
4547         * tui/tui-source.c (tui_source_window_base::reset): New method.
4548         * tui/tui-layout.c (make_command_window): Don't call
4549         init_and_make_win.
4550         (make_source_window, make_disasm_window): Don't call
4551         make_source_or_disasm_window.
4552         (make_data_window): Don't call init_and_make_win.  Change calling
4553         convention.
4554         (show_source_disasm_command, show_data): Simplify.
4555         (make_source_or_disasm_window): Remove.
4556         (show_source_or_disasm_and_command): Simplify.
4557         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4558         (struct tui_source_window_base) <reset>: Likewise.
4559         <execution_info>: Remove initializer.
4560         * tui/tui-data.c (tui_source_window_base): Initialize
4561         execution_info.
4562
4563 2019-07-17  Tom Tromey  <tom@tromey.com>
4564
4565         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4566         variable.
4567
4568 2019-07-17  Tom Tromey  <tom@tromey.com>
4569
4570         * tui/tui.c (tui_rl_other_window): Update.
4571         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4572         superclass method first.  Always iterate over regs_content.
4573         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4574         method.
4575         * tui/tui-win.c (tui_set_focus_command): Update.
4576
4577 2019-07-17  Tom Tromey  <tom@tromey.com>
4578
4579         * tui/tui-win.c (tui_set_focus_command): Rename from
4580         tui_set_focus.  Call tui_enable.
4581         (tui_set_focus_command): Remove.
4582
4583 2019-07-17  Tom Tromey  <tom@tromey.com>
4584
4585         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4586         refresh_window.
4587         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4588         touchwin.
4589         (tui_data_window::refresh_window): Call refresh_window on data
4590         items.  Always call superclass refresh_window.
4591         (tui_win_info::refresh): Remove.
4592         (tui_source_window_base::refresh_window): Update.
4593         (tui_refresh_all): Update.
4594         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4595         refresh_window.
4596         (show_source_or_disasm_and_command): Likewise.
4597         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4598         (struct tui_source_window_base) <refresh>: Likewise.
4599
4600 2019-07-17  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-winsource.c (tui_clear_source_content)
4603         (tui_show_source_content): Update.
4604         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4605         whether content is empty.
4606         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4607         Remove.
4608
4609 2019-07-17  Tom Tromey  <tom@tromey.com>
4610
4611         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4612         window's contents.
4613         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4614         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4615
4616 2019-07-17  Tom Tromey  <tom@tromey.com>
4617
4618         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4619         (struct tui_data_item_window): Update.
4620
4621 2019-07-17  Tom Tromey  <tom@tromey.com>
4622
4623         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4624         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4625         defines.
4626
4627 2019-07-17  Tom Tromey  <tom@tromey.com>
4628
4629         * tui/tui-winsource.h (tui_erase_source_content)
4630         (tui_clear_source_content): Remove "display_prompt" parameter.
4631         * tui/tui-winsource.c (tui_update_source_window_as_is)
4632         (tui_update_source_windows_with_addr): Update.
4633         (tui_clear_source_content): Remove "display_prompt" parameter.
4634         (tui_erase_source_content): Likewise.  Simplify.
4635         (tui_show_source_content): Update.
4636         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4637         * tui/tui-stack.c (tui_show_frame_info): Update.
4638         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4639         Remove defines.
4640
4641 2019-07-17  Tom Tromey  <tom@tromey.com>
4642
4643         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4644         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4645         parameter.
4646         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4647         parameter.
4648
4649 2019-07-17  Tom Tromey  <tom@tromey.com>
4650
4651         * tui/tui-winsource.c (tui_clear_source_content)
4652         (tui_show_source_content, tui_show_exec_info_content)
4653         (tui_clear_exec_info_content): Update.
4654         * tui/tui-stack.c (tui_show_locator_content): Update.
4655         (tui_show_frame_info): Update.
4656         * tui/tui-source.h (tui_source_window): Don't declare.
4657         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4658         from tui_source_is_displayed.
4659         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4660         Remove field.
4661         (struct tui_source_window_base) <content_in_use>: New field.  Now
4662         bool.
4663         (struct tui_source_window) <showing_source_p>: New method.
4664         (TUI_SRC_WIN): Change cast.
4665         * tui/tui-data.c (tui_initialize_static_data): Update.
4666
4667 2019-07-17  Tom Tromey  <tom@tromey.com>
4668
4669         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4670         location_matches_p.
4671         * tui/tui-source.c (tui_source_window::location_matches_p): New
4672         method.
4673         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4674         method.
4675         * tui/tui-data.h (struct tui_source_window_base)
4676         <location_matches_p>: New method.
4677         (struct tui_source_window, struct tui_disasm_window)
4678         <location_matches_p>: Likewise.
4679
4680 2019-07-17  Tom Tromey  <tom@tromey.com>
4681
4682         * tui/tui-win.c (tui_set_win_height_command): Rename from
4683         tui_set_win_height.
4684         (tui_set_win_height_command): Remove.
4685
4686 2019-07-17  Tom Tromey  <tom@tromey.com>
4687
4688         * tui/tui-source.c (tui_source_window): New constructor.  Add
4689         observer.
4690         (~tui_source_window): New destructor.
4691         (tui_source_window::style_changed): New method.
4692         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4693         (tui_attach_detach_observers): Update.
4694         * tui/tui-data.h (struct tui_source_window): Make constructor not
4695         inline.  Add destructor.
4696         (struct tui_source_window) <style_changed>: New method.
4697         <m_observable>: New member.
4698
4699 2019-07-17  Tom Tromey  <tom@tromey.com>
4700
4701         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4702         * tui/tui-win.c (tui_resize_all): Fix typo.
4703
4704 2019-07-17  Tom Tromey  <tom@tromey.com>
4705
4706         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4707         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4708         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4709         * tui/tui-win.c (window_name_completer): Use foreach.
4710         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4711         (update_tab_width): Likewise.
4712         * tui/tui-layout.c (show_layout): Update.
4713         * tui/tui-data.h (class tui_window_iterator): New.
4714         (struct all_tui_windows): New.
4715         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4716
4717 2019-07-17  Tom Tromey  <tom@tromey.com>
4718
4719         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4720         parameter.  Don't reference globals.
4721         (tui_reg_command): Update.
4722
4723 2019-07-17  Tom Tromey  <tom@tromey.com>
4724
4725         * tui/tui-regs.c (tui_show_registers): Simplify.
4726
4727 2019-07-17  Tom Tromey  <tom@tromey.com>
4728
4729         * tui/tui-regs.c (tui_show_registers): Update.
4730         (tui_show_register_group): Add win_info parameter.
4731
4732 2019-07-17  Tom Tromey  <tom@tromey.com>
4733
4734         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4735         Rename from tui_display_reg_element_at_line.
4736         (tui_data_window::display_registers_from_line): Update.
4737         * tui/tui-data.h (struct tui_data_window)
4738         <display_reg_element_at_line>: New method.
4739
4740 2019-07-17  Tom Tromey  <tom@tromey.com>
4741
4742         * tui/tui-regs.h (tui_display_registers_from)
4743         (tui_display_registers_from_line): Don't declare.
4744         * tui/tui-windata.c (tui_data_window::display_all_data)
4745         (tui_data_window::refresh_all)
4746         (tui_data_window::do_scroll_vertical): Update.
4747         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4748         from tui_display_registers_from.
4749         (tui_display_reg_element_at_line): Update.
4750         (tui_data_window::display_registers_from_line): Rename from
4751         tui_display_registers_from_line.
4752         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4753         display_registers_from_line>: New methods.
4754
4755 2019-07-17  Tom Tromey  <tom@tromey.com>
4756
4757         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4758         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4759         from tui_erase_data_content.
4760         (tui_data_window::display_all_data)
4761         (tui_data_window::refresh_all)
4762         (tui_data_window::do_scroll_vertical): Update.
4763         * tui/tui-regs.c (tui_show_registers): Update.
4764         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4765         New method.
4766
4767 2019-07-17  Tom Tromey  <tom@tromey.com>
4768
4769         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4770         declare.
4771         * tui/tui-windata.c
4772         (tui_data_window::delete_data_content_windows): Rename from
4773         tui_delete_data_content_windows.
4774         (tui_data_window::display_all_data)
4775         (tui_data_window::do_scroll_vertical): Update.
4776         * tui/tui-data.h (struct tui_data_window)
4777         <delete_data_content_windows>: New method.
4778
4779 2019-07-17  Tom Tromey  <tom@tromey.com>
4780
4781         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4782         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4783
4784 2019-07-17  Tom Tromey  <tom@tromey.com>
4785
4786         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4787         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4788         from tui_display_all_data.
4789         * tui/tui-win.c
4790         (tui_data_window::do_make_visible_with_new_height): Update.
4791         * tui/tui-regs.c (tui_show_registers): Update.
4792         * tui/tui-layout.c (tui_set_layout): Update.
4793         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4794         method.
4795
4796 2019-07-17  Tom Tromey  <tom@tromey.com>
4797
4798         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4799         * tui/tui-windata.c (tui_display_data_from): Remove.
4800         (tui_data_window::refresh_all): Update.
4801
4802 2019-07-17  Tom Tromey  <tom@tromey.com>
4803
4804         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4805         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4806         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4807         tui_display_registers_from_line.
4808         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4809         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4810         "force_display" parameter.
4811
4812 2019-07-17  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4815         declare.
4816         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4817         Rename from tui_first_reg_element_no_inline.
4818         (tui_display_reg_element_at_line)
4819         (tui_display_registers_from_line): Update.
4820         * tui/tui-data.h (struct tui_data_window)
4821         <first_reg_element_no_inline>: New method.
4822
4823 2019-07-17  Tom Tromey  <tom@tromey.com>
4824
4825         * tui/tui-windata.c (tui_display_data_from)
4826         (tui_data_window::do_scroll_vertical): Update.
4827         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4828         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4829         Rename from tui_line_from_reg_element_no.
4830         (tui_display_registers_from_line): Update.
4831         * tui/tui-data.h (struct tui_data_window)
4832         <line_from_reg_element_no>: New method.
4833
4834 2019-07-17  Tom Tromey  <tom@tromey.com>
4835
4836         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4837         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4838         tui_last_regs_line_no.
4839         (tui_display_reg_element_at_line)
4840         (tui_display_registers_from_line): Update.
4841         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4842         method.
4843
4844 2019-07-17  Tom Tromey  <tom@tromey.com>
4845
4846         PR tui/24722:
4847         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4848         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4849         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4850         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4851         (tui_update_breakpoint_info): Likewise.
4852         * tui/tui-hooks.c (tui_event_create_breakpoint)
4853         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4854         Update.
4855
4856 2019-07-17  Tom Tromey  <tom@tromey.com>
4857
4858         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4859
4860 2019-07-17  Tom Tromey  <tom@tromey.com>
4861
4862         * tui/tui-winsource.c (tui_update_source_window_as_is)
4863         (tui_update_source_windows_with_addr): Update.
4864         * tui/tui-source.h (tui_set_source_content)
4865         (tui_show_symtab_source): Add "win_info" parameter.
4866         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4867         parameter.
4868         (tui_show_symtab_source): Likewise.
4869
4870 2019-07-17  Tom Tromey  <tom@tromey.com>
4871
4872         * tui/tui-wingeneral.c
4873         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4874
4875 2019-07-17  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4878         (struct tui_cmd_window) <can_scroll>: New method.
4879         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4880         method.
4881
4882 2019-07-17  Tom Tromey  <tromey@adacore.com>
4883
4884         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4885         do_field_signed>: Rename.  Change type of "value".
4886         * ui-out.c (ui_out::field_signed): Rename from field_int.
4887         Change type of "value".
4888         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4889         type of "value".
4890         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4891         do_field_int.  Change type of "value".
4892         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4893         do_field_int.  Change type of "value".
4894         * tracepoint.c (trace_status_mi, tfind_1)
4895         (print_one_static_tracepoint_marker): Update.
4896         * thread.c (print_thread_info_1, print_selected_thread_frame):
4897         Update.
4898         * stack.c (print_frame, print_frame_info): Update.
4899         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4900         Update.
4901         * source.c (print_source_lines_base): Update.
4902         * skip.c (info_skip_command): Update.
4903         * record-btrace.c (btrace_ui_out_decode_error)
4904         (btrace_call_history_src_line): Update.
4905         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4906         Update.
4907         * progspace.c (print_program_space): Update.
4908         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4909         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4910         do_field_int.  Change type of "value".
4911         * mi/mi-out.c (mi_ui_out::do_table_begin)
4912         (mi_ui_out::do_table_header): Update.
4913         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4914         type of "value".
4915         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4916         (mi_cmd_data_list_changed_registers, output_register)
4917         (mi_cmd_data_read_memory, mi_load_progress)
4918         (mi_cmd_trace_frame_collected): Update.
4919         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4920         Update.
4921         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4922         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4923         (mi_cmd_var_list_children, varobj_update_one): Update.
4924         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4925         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4926         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4927         * inferior.c (print_inferior): Update.
4928         * gdb_bfd.c (print_one_bfd): Update.
4929         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4930         Update.
4931         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4932         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4933         do_field_int.  Change type of "value".
4934         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4935         do_field_int.  Change type of "value".
4936         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4937         (print_one_breakpoint_location, print_it_catch_fork)
4938         (print_one_catch_fork, print_it_catch_vfork)
4939         (print_one_catch_vfork, print_it_catch_solib)
4940         (print_it_catch_exec, print_it_ranged_breakpoint)
4941         (print_mention_watchpoint, print_mention_masked_watchpoint)
4942         (bkpt_print_it, update_static_tracepoint): Update.
4943         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4944         * break-catch-syscall.c (print_it_catch_syscall): Update.
4945         * ada-tasks.c (print_ada_task_info): Update.
4946         * ada-lang.c (print_it_exception, print_mention_exception):
4947         Update.
4948
4949 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4950
4951         PR breakpoints/24541
4952         * gdbarch.c: Regenerate.
4953         * gdbarch.h: Regenerate.
4954         * gdbarch.sh: Adjust return type and parameter types for
4955         'stap_adjust_register'.
4956         (i386_stap_adjust_register): Adjust signature and return new
4957         register name.
4958         * stap-probe.c (stap_parse_register_operand): Adjust use of
4959         'gdbarch_stap_adjust_register'.
4960
4961 2019-07-17  Tom Tromey  <tromey@adacore.com>
4962
4963         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4964         declare VEC.
4965         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4966         std::vector.
4967         (struct s390_process_info): Add initializers.
4968         (s390_add_process): Use new.
4969         (s390_linux_nat_target::low_forget_process): Use delete.
4970         (s390_linux_nat_target::low_new_fork)
4971         (s390_linux_nat_target::stopped_by_watchpoint)
4972         (s390_linux_nat_target::low_prepare_to_resume)
4973         (s390_linux_nat_target::insert_watchpoint)
4974         (s390_linux_nat_target::insert_hw_breakpoint)
4975         (s390_linux_nat_target::remove_watchpoint)
4976         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4977
4978 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4979
4980         * aarch64-fbsd-nat.c: Include regcache.h.
4981         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4982         argument.
4983         (aarch64_fbsd_nat_target::fetch_registers)
4984         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4985         variable.
4986         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4987
4988 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4989
4990         * fbsd-nat.c: Include gdbarch.h.
4991
4992 2019-07-15  Tom Tromey  <tromey@adacore.com>
4993
4994         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4995
4996 2019-07-15  Tom Tromey  <tromey@adacore.com>
4997
4998         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4999         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5000         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5001         * cli-out.c (cli_ui_out::do_field_int): New method.
5002         * ui-out.c (ui_out::field_unsigned): New method.
5003         * symfile.c (generic_load): Use field_unsigned.
5004         (print_transfer_performance): Likewise.
5005         * record-btrace.c (ui_out_field_uint): Remove.
5006         (btrace_call_history_insn_range, btrace_call_history): Use
5007         field_unsigned.
5008         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5009         field_unsigned.
5010         * ui-out.h (class ui_out) <field_unsigned>: New method.
5011         <do_field_unsigned>: Likewise.
5012
5013 2019-07-15  Tom Tromey  <tromey@adacore.com>
5014
5015         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5016         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5017         * target.c (flash_erase_command): Use field_string.
5018         * infrun.c (print_signal_received_reason): Use field_string.
5019         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5020         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5021         field_string.
5022         * ada-tasks.c (print_ada_task_info): Use field_string.
5023
5024 2019-07-15  Tom Tromey  <tromey@adacore.com>
5025
5026         * target.c (flash_erase_command): Use field_core_addr.
5027         * symfile.c (generic_load): Use field_core_addr.
5028         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5029         Use field_core_addr.
5030         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5031         field_core_addr.
5032
5033 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5034
5035         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5036         value if its desired type is smaller than a CORE_ADDR and signed.
5037
5038 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5039
5040         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5041         of changes to field names, and use new is_reference field to
5042         decide if a property is a reference or not.
5043         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5044         field.
5045         (struct dwarf2_property_baton): Update header comment, rename
5046         'referenced_type' to 'property_type' and update comments.
5047         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5048         default property type, store in property baton, update to take
5049         accound of renamed field.
5050         (read_func_scope): Update call to attr_to_dynamic_prop.
5051         (read_array_type): Likewise.
5052         (dwarf2_per_cu_addr_sized_int_type): New function.
5053         (read_subrange_index_type): Move type finding code to
5054         dwarf2_per_cu_addr_sized_int_type.
5055         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5056         (dwarf2_per_cu_addr_type): New function.
5057         (set_die_type): Update calls to attr_to_dynamic_prop.
5058
5059 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5060
5061         * dwarf2read.c (read_subrange_index_type): New function.
5062         (read_subrange_type): Move code into new function and call it.
5063         * gdbtypes.c (create_range_type): Add some asserts.
5064
5065 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5068         update return statements.
5069         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5070         declaration, and update comment to match.
5071         * gdbtypes.c (resolve_dynamic_array): Update call to
5072         dwarf2_evaluate_property to match new return type.
5073
5074 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5075
5076         * valarith.c (value_subscripted_rvalue): Change lowerbound
5077         parameter type from int to LONGEST.
5078         * value.h (value_subscripted_rvalue): Likewise in declaration.
5079
5080 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5081
5082         * cli/cli-utils.c (info_print_command_completer): New function.
5083         * cli/cli-utils.h: Add 'completer.h' include, and forward
5084         declaration for 'struct cmd_list_element'.
5085         (info_print_command_completer): Declare.
5086         * stack.c (_initialize_stack): Add completer for 'info locals' and
5087         'info args'.
5088         * symtab.c (_initialize_symtab): Add completer for 'info
5089         variables' and 'info functions'.
5090         * NEWS: Mention completion for additional info commands.
5091
5092 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5093
5094         * cli/cli-utils.c (extract_info_print_args): Delete.
5095         (extract_arg_maybe_quoted): Delete.
5096         (info_print_options_defs): New variable.
5097         (make_info_print_options_def_group): New function.
5098         (extract_info_print_options): Define new function.
5099         * cli/cli-utils.h (extract_info_print_args): Delete.
5100         (struct info_print_options): New structure.
5101         (extract_info_print_options): Declare new function.
5102         * stack.c (info_locals_command): Update to use new
5103         extract_info_print_options, also add a header comment.
5104         (info_args_command): Likewise.
5105         * symtab.c (info_variables_command): Likewise.
5106         (info_functions_command): Likewise.
5107
5108 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5111         to extract string arguments.
5112         * common/common-utils.c (extract_string_maybe_quoted): New function.
5113         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5114
5115 2019-07-11  Tom Tromey  <tromey@adacore.com>
5116
5117         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5118         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5119         * top.h (gdbinit): Don't declare.
5120         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5121         into...
5122         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5123         * top.c (gdb_init): Don't call init_cli_cmds.
5124         (gdbinit): Remove.
5125         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5126
5127 2019-07-11  Tom Tromey  <tromey@adacore.com>
5128
5129         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5130         after it has been moved.
5131
5132 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5133
5134         * valops.c (value_must_coerce_to_target): Change return type to
5135         bool.
5136         * value.h (value_must_coerce_to_target): Likewise.
5137
5138 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5139
5140         * breakpoint.c (is_hardware_watchpoint): Remove
5141         forward-declaration.
5142         (is_masked_watchpoint): Change return type to bool.
5143         (is_tracepoint): Likewise.
5144         (is_breakpoint): Likewise.
5145         (is_hardware_watchpoint): Likewise.
5146         (is_watchpoint): Likewise.
5147         (is_no_memory_software_watchpoint): Likewise.
5148         (is_catchpoint): Likewise.
5149         (breakpoint_1): Make FILTER parameter's return type bool.
5150         is_masked_watchpoint): Change return type to bool.
5151         (save_breakpoints): Make FILTER parameter's return type bool.
5152         * breakpoint.h (is_breakpoint): Change return type to bool.
5153         (is_watchpoint): Likewise.
5154         (is_catchpoint): Likewise.
5155         (is_tracepoint): Likewise.
5156
5157 2019-07-10  Tom Tromey  <tom@tromey.com>
5158
5159         * defs.h: Don't include gdbarch.h.
5160         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5161         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5162         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5163         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5164         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5165         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5166         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5167         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5168         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5169         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5170         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5171         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5172         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5173         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5174         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5175         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5176         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5177         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5178         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5179         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5180         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5181         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5182         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5183         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5184         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5185         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5186         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5187
5188 2019-07-10  Tom Tromey  <tromey@adacore.com>
5189
5190         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5191         * breakpoint.c (init_ada_exception_breakpoint): Register as
5192         bp_catchpoint.
5193         (print_one_breakpoint_location, print_one_breakpoint): Use
5194         is_ada_exception_catchpoint.
5195         * ada-lang.c (class ada_catchpoint_location): Pass
5196         bp_loc_software_breakpoint to bp_location constructor.
5197         (is_ada_exception_catchpoint): New function.
5198
5199 2019-07-10  Tom Tromey  <tromey@adacore.com>
5200
5201         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5202         VEC.
5203         (struct arm_exidx_entry): New method operator<.
5204         (struct arm_exidx_data) <section_maps>: Change type.
5205         (arm_exidx_data_free): Remove.
5206         (arm_exidx_data_key): Change type.  Move lower.
5207         (arm_exidx_new_objfile): Update.
5208         (arm_compare_exidx_entries): Remove.
5209         (arm_find_exidx_entry, _initialize_arm_tdep)
5210
5211 2019-07-10  Tom Tromey  <tromey@adacore.com>
5212
5213         * solib-spu.c (ocl_program_data_key): Change type.
5214         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5215         Update.
5216
5217 2019-07-10  Tom Tromey  <tromey@adacore.com>
5218
5219         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5220         (struct solib_aix_inferior_data) <library_list>: Change type.
5221         (solib_aix_inferior_data_handle): Change type.
5222         (get_solib_aix_inferior_data): Update.
5223         (solib_aix_free_library_list): Remove.
5224         (library_list_start_library): Update.
5225         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5226         return type.
5227         (solib_aix_get_library_list)
5228         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5229         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5230
5231 2019-07-10  Tom Tromey  <tromey@adacore.com>
5232
5233         * solib-dsbt.c (struct dsbt_info): Add initializers.
5234         (solib_dsbt_pspace_data): Change type.
5235         (dsbt_pspace_data_cleanup): Remove.
5236         (get_dsbt_info, _initialize_dsbt_solib): Update.
5237
5238 2019-07-10  Tom Tromey  <tromey@adacore.com>
5239
5240         * spu-tdep.c (spu_overlay_data): Change type.
5241         (spu_get_overlay_table, spu_overlay_new_objfile)
5242         (_initialize_spu_tdep): Update.
5243
5244 2019-07-10  Tom Tromey  <tromey@adacore.com>
5245
5246         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5247         destructor.
5248         (dbx_objfile_data_key): Change type and declare later.
5249         (DBX_SYMFILE_INFO): Rewrite.
5250         * dbxread.c (dbx_objfile_data_key): Change type.
5251         (dbx_symfile_init): Update.
5252         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5253         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5254         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5255
5256 2019-07-10  Tom Tromey  <tromey@adacore.com>
5257
5258         * jit.c (jit_program_space_key): Change type.  Move lower.
5259         (get_jit_program_space_data): Update.
5260         (jit_program_space_data_cleanup): Remove.
5261         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5262         Update.
5263         (struct jit_program_space_data): Add initializers.
5264
5265 2019-07-10  Tom Tromey  <tromey@adacore.com>
5266
5267         * solib-darwin.c (struct darwin_info): Add initializers.
5268         (solib_darwin_pspace_data): Change type.
5269         (darwin_pspace_data_cleanup): Remove.
5270         (get_darwin_info, _initialize_darwin_solib): Update.
5271
5272 2019-07-10  Tom Tromey  <tromey@adacore.com>
5273
5274         * remote-sim.c (struct sim_inferior_data): Add initializers,
5275         constructor, and destructor.
5276         (sim_inferior_data_key): Change type.  Move lower.
5277         (check_for_duplicate_sim_descriptor): Update.
5278         (get_sim_inferior_data): Use new.  Update.
5279         (~sim_inferior_data_cleanup): Rename from
5280         sim_inferior_data_cleanup.  Simplify.
5281         (gdbsim_close_inferior, simulator_command)
5282         (sim_command_completer, _initialize_remote_sim): Update.
5283         (next_pid, INITIAL_PID): Move earlier.
5284
5285 2019-07-10  Tom Tromey  <tromey@adacore.com>
5286
5287         * python/python-internal.h (create_thread_object): Return
5288         gdbpy_ref.
5289         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5290         * python/py-inferior.c (struct threadlist_entry): Add
5291         constructor.
5292         <thread_obj>: Now a gdbpy_ref.
5293         (thread_to_thread_object): Update.
5294         (add_thread_object): Use new.
5295         (delete_thread_object): Use delete.
5296         (infpy_threads): Update.
5297         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5298         GIL.
5299
5300 2019-07-10  Tom Tromey  <tromey@adacore.com>
5301
5302         * valops.c (value_cast): Specialize error message for Ada.
5303
5304 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5305
5306         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5307
5308 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5309
5310         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5311         bpstat_should_step): Return bool, adjust comments.
5312         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5313         bpstat_should_step): Likewise.
5314
5315 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5316
5317         * features/Makefile: Use feature target descriptions for Arm.
5318         * features/arm/arm-core.c: Generate new file.
5319         * features/arm/arm-fpa.c: Likewise.
5320         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5321         * features/arm/arm-m-profile.c: Likewise.
5322         * features/arm/arm-vfpv2.c: Likewise.
5323         * features/arm/arm-vfpv3.c: Likewise.
5324         * features/arm/xscale-iwmmxt.c: Likewise.
5325         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5326
5327 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5328
5329         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5330         ptrace earlier.
5331
5332 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5333
5334         * features/aarch64-pauth.c: Regenerate.
5335
5336 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5337
5338         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5339         bool.
5340         (bpstat_what): Use false instead of 0.
5341
5342 2019-07-09  Pedro Alves  <palves@redhat.com>
5343
5344         * break-catch-throw.c (is_exception_catchpoint): New.
5345         * breakpoint.c (print_one_breakpoint_location): New parameter
5346         'raw_loc'.  Handle it.  Use
5347         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5348         looking at the breakpoint's type.
5349         (print_one_breakpoint): If handling "maint info breakpoints", also
5350         print locations of exception catchpoints.
5351         * breakpoint.h (is_exception_catchpoint): Declare.
5352
5353 2019-07-09  Pedro Alves  <palves@redhat.com>
5354
5355         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5356         "addr" field.
5357         (allocate_location_exception_catchpoint): New.
5358         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5359         (initialize_throw_catchpoint_ops): Install
5360         allocate_location_exception_catchpoint as allocate_location
5361         method.
5362         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5363         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5364         bp_loc_other.
5365         (breakpoint_address_is_meaningful): Delete.
5366         (bl_address_is_meaningful): New.
5367         (breakpoint_locations_match): Adjust comment.
5368         (bp_location_from_bp_type): New, factored out of...
5369         (bp_location::bp_location(breakpoint *)): ... this.
5370         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5371         factored out of...
5372         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5373         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5374         breakpoint_address_is_meaningful.
5375         (bp_locations_compare): Adjust comment.
5376         (update_global_location_list): Use bl_address_is_meaningful
5377         instead of breakpoint_address_is_meaningful.
5378         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5379         explicit.
5380         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5381         * python/py-breakpoint.c (bppy_get_location): No longer check
5382         whether location is null.
5383
5384 2019-07-09  Pedro Alves  <palves@redhat.com>
5385
5386         PR c++/15468
5387         * breakpoint.c (print_one_breakpoint_location): Remove
5388         single-location assert.
5389
5390 2019-07-09  Tom Tromey  <tom@tromey.com>
5391
5392         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5393         * configure: Rebuild.
5394         * configure.ac: Change common to gdbsupport.
5395         * gdbsupport: Rename from common.
5396         * acinclude.m4: Change common to gdbsupport.
5397         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5398         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5399         gdbsupport.
5400         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5401         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5402         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5403         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5404         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5405         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5406         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5407         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5408         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5409         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5410         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5411         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5412         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5413         coff-pe-read.c, command.h, compile/compile-c-support.c,
5414         compile/compile-c.h, compile/compile-cplus-symbols.c,
5415         compile/compile-cplus-types.c, compile/compile-cplus.h,
5416         compile/compile-loc2c.c, compile/compile.c, completer.c,
5417         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5418         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5419         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5420         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5421         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5422         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5423         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5424         features/aarch64-core.c, features/aarch64-fpu.c,
5425         features/aarch64-pauth.c, features/aarch64-sve.c,
5426         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5427         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5428         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5429         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5430         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5431         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5432         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5433         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5434         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5435         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5436         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5437         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5438         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5439         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5440         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5441         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5442         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5443         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5444         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5445         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5446         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5447         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5448         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5449         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5450         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5451         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5452         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5453         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5454         minsyms.c, mips-linux-tdep.c, namespace.h,
5455         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5456         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5457         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5458         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5459         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5460         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5461         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5462         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5463         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5464         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5465         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5466         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5467         procfs.c, producer.c, progspace.h, psymtab.h,
5468         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5469         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5470         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5471         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5472         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5473         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5474         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5475         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5476         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5477         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5478         target-memory.c, target.c, target.h, target/waitstatus.c,
5479         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5480         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5481         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5482         unittests/array-view-selftests.c,
5483         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5484         unittests/common-utils-selftests.c,
5485         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5486         unittests/format_pieces-selftests.c,
5487         unittests/function-view-selftests.c,
5488         unittests/lookup_name_info-selftests.c,
5489         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5490         unittests/mkdir-recursive-selftests.c,
5491         unittests/observable-selftests.c,
5492         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5493         unittests/parse-connection-spec-selftests.c,
5494         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5495         unittests/scoped_fd-selftests.c,
5496         unittests/scoped_mmap-selftests.c,
5497         unittests/scoped_restore-selftests.c,
5498         unittests/string_view-selftests.c, unittests/style-selftests.c,
5499         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5500         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5501         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5502         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5503         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5504         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5505
5506 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5507
5508         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5509         bool value.
5510         (decode_digits_ordinary): Set explicit_line field in sal.
5511         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5512         symtab_and_line that was set on an explicit line number in
5513         assembler code.  Do always update the recorded symtab and line if
5514         we do skip the prologue.
5515
5516 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5517
5518         * breakpoint.c (set_breakpoint_location_function): Remove
5519         explicit_loc parameter.
5520         (momentary_breakpoint_from_master): Update call to
5521         set_breakpoint_location_function.
5522         (add_location_to_breakpoint): Likewise.
5523
5524 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5525
5526         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5527         required features based on default bfd type when no specific bfd
5528         is present.
5529
5530 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5531
5532         * NEWS: Mention that GDB printf and eval commands can now print
5533         C-style and Ada-style convenience var strings without
5534         calling the inferior.
5535         * printcmd.c (printf_c_string): Locally print GDB internal var
5536         instead of transiting via the inferior.
5537         (printf_wide_c_string): Likewise.
5538
5539 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5540
5541         PR breakpoints/25011
5542         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5543
5544 2019-07-04  Tom Tromey  <tom@tromey.com>
5545
5546         PR tui/24724:
5547         * tui/tui-winsource.c (tui_clear_source_content): Update.
5548         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5549         (tui_update_breakpoint_info): Update.
5550         (tui_set_exec_info_content): Update.
5551         * tui/tui-source.c (tui_set_source_content_nil): Update.
5552         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5553         has_break.
5554         * tui/tui-data.h (enum tui_bp_flag): New.
5555         (tui_bp_flags): New enum flags type.
5556         (struct tui_source_element) <break_mode>: Change type.  Rename
5557         from has_break.
5558         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5559         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5560         constants.
5561         * tui/tui-winsource.h: Fix comment.
5562
5563 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5564
5565         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5566         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5567         (store_fpregs_to_thread)
5568         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5569         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5570         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5571         (IWMMXT_REGS_SIZE): Add define.
5572         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5573         (fetch_vfp_regs, store_vfp_regs)
5574         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5575         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5576
5577 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5578
5579         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5580         defines.
5581         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5582         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5583         (ARM_INT_REGISTER_SIZE): ...to this.
5584         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5585         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5586         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5587         (arm_linux_collect_gregset, supply_nwfpe_register)
5588         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5589         defines.
5590         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5591         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5592         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5593         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5594         (arm_return_in_memory, arm_store_return_value)
5595         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5596         (arm_record_ld_st_multiple): Likewise.
5597         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5598         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5599
5600 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5601
5602         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5603         AARCH64_DISPLACED_MODIFIED_INSNS.
5604         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5605         (aarch64_displaced_step_copy_insn): Likewise.
5606         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5607         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5608         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5609         ARM_DISPLACED_MODIFIED_INSNS.
5610         * arm-tdep.c (arm_gdbarch_init): Likewise.
5611         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5612         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5613         (struct arm_displaced_step_closure): Use
5614         ARM_DISPLACED_MODIFIED_INSNS.
5615
5616 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5617
5618         * features/Makefile: Remove unused xml files.
5619         * features/aarch64.xml: Remove.
5620         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5621         * features/i386/amd64-avx-avx512.xml: Remove.
5622         * features/i386/amd64-avx-linux.xml: Remove.
5623         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5624         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5625         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5626         * features/i386/amd64-avx-mpx.xml: Remove.
5627         * features/i386/amd64-avx.xml: Remove.
5628         * features/i386/amd64-linux.xml: Remove.
5629         * features/i386/amd64-mpx-linux.xml: Remove.
5630         * features/i386/amd64-mpx.xml: Remove.
5631         * features/i386/amd64.xml: Remove.
5632         * features/i386/i386-avx-avx512-linux.xml: Remove.
5633         * features/i386/i386-avx-avx512.xml: Remove.
5634         * features/i386/i386-avx-linux.xml: Remove.
5635         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5636         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5637         * features/i386/i386-avx-mpx-linux.xml: Remove.
5638         * features/i386/i386-avx-mpx.xml: Remove.
5639         * features/i386/i386-avx.xml: Remove.
5640         * features/i386/i386-linux.xml: Remove.
5641         * features/i386/i386-mmx-linux.xml: Remove.
5642         * features/i386/i386-mmx.xml: Remove.
5643         * features/i386/i386-mpx-linux.xml: Remove.
5644         * features/i386/i386-mpx.xml: Remove.
5645         * features/i386/i386.xml: Remove.
5646         * features/i386/x32-avx-avx512-linux.xml: Remove.
5647         * features/i386/x32-avx-linux.xml: Remove.
5648         * features/i386/x32-linux.xml: Remove.
5649
5650 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5651
5652         * regformats/aarch64.dat: Remove.
5653         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5654         * regformats/i386/amd64-avx-linux.dat: Remove.
5655         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5656         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5657         * regformats/i386/amd64-linux.dat: Remove.
5658         * regformats/i386/amd64-mpx-linux.dat: Remove.
5659         * regformats/i386/amd64.dat: Remove.
5660         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5661         * regformats/i386/i386-avx-linux.dat: Remove.
5662         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5663         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5664         * regformats/i386/i386-linux.dat: Remove.
5665         * regformats/i386/i386-mmx-linux.dat: Remove.
5666         * regformats/i386/i386-mpx-linux.dat: Remove.
5667         * regformats/i386/i386.dat: Remove.
5668         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5669         * regformats/i386/x32-avx-linux.dat: Remove.
5670         * regformats/i386/x32-linux.dat: Remove.
5671
5672 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5673
5674         * aarch64-tdep.c: Remove xml self tests.
5675         * amd64-linux-tdep.c: Likewise.
5676         * amd64-tdep.c: Likewise.
5677         * i386-linux-tdep.c: Likewise.
5678         * i386-tdep.c: Likewise.
5679
5680 2019-07-03  Pedro Alves  <palves@redhat.com>
5681
5682         PR cli/24732
5683         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5684         (pipe_cmd_option_defs): New.
5685         (make_pipe_cmd_options_def_group): New.
5686         (pipe_command): Use gdb::option::process_options.
5687         (pipe_command_completer): New function.
5688         (_initialize_cli_cmds): Install completer for "pipe" command.
5689
5690 2019-07-03  Pedro Alves  <palves@redhat.com>
5691
5692         * cli/cli-option.c (union option_value) <string>: New field.
5693         (struct option_def_and_value): Add ctor, move ctor, dtor and
5694         use DISABLE_COPY_AND_ASSIGN.
5695         (option_def_and_value::clear_value): New.
5696         (parse_option, save_option_value_in_ctx, get_val_type_str)
5697         (add_setshow_cmds_for_options): Handle var_string.
5698         * cli-option.h (union option_def::var_address) <string>: New
5699         field.
5700         (struct string_option_def): New.
5701         * maint-test-options.c (struct test_options_opts): Add default
5702         ctor and use DISABLE_COPY_AND_ASSIGN.
5703         <string_opt>: New field.
5704         (test_options_opts::~test_options_opts): New.
5705         (test_options_opts::dump): Also dump "-string".
5706         (test_options_option_defs): Install "string.
5707
5708 2019-07-03  Pedro Alves  <palves@redhat.com>
5709
5710         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5711         option_value with a null enumeration.
5712         (complete_options): Save the option values in the context.
5713         (save_option_value_in_ctx): New, factored out from ...
5714         (process_options): ... here.
5715         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5716         of the function.
5717         * maint-test-options.c (test_options_opts::dump): New, factored
5718         out from ...
5719         (maintenance_test_options_command_mode): ... here.
5720         (maintenance_test_options_command_completion_result): Delete.
5721         (maintenance_test_options_command_completion_text): Update
5722         comment.
5723         (maintenance_show_test_options_completion_result): Change
5724         prototype.  Just print
5725         maintenance_test_options_command_completion_text.
5726         (save_completion_result): New.
5727         (maintenance_test_options_completer_mode): Pass options context to
5728         complete_options, and then save a dump.
5729         (_initialize_maint_test_options): Use add_cmd to install "maint
5730         show test-options-completion-result".
5731
5732 2019-07-03  Pedro Alves  <palves@redhat.com>
5733
5734         * NEWS (New commands): Mention "with" and "maint with".
5735         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5736         (with_command, with_command_completer): New.
5737         (pipe_command): Adjust to new repeat_previous
5738         interface.
5739         (_initialize_cli_cmds): Install the "with" command and its "w"
5740         alias.
5741         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5742         declarations.
5743         * cli/cli-setshow.c (parse_cli_var_uinteger)
5744         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5745         argument strings for all var_types.
5746         (get_setshow_command_value_string): New, factored out from ...
5747         (do_show_command): ... this.
5748         * cli/cli-setshow.h: Include <string>.
5749         (get_setshow_command_value_string): Declare.
5750         * command.h (repeat_previous): Now returns const char *.  Adjust
5751         comment.
5752         * maint.c: Include "cli/cli-cmds.h".
5753         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5754         (_initialize_maint_cmds): Register the "maintenance with" command.
5755         * top.c (repeat_previous): Move bits from pipe_command here:
5756         Return the saved command line, if any; error out if there's no
5757         command to relaunch.
5758
5759 2019-07-03  Pedro Alves  <palves@redhat.com>
5760
5761         * NEWS (New commands): Mention "maint set/show test-settings"
5762         instead of "maint test-settings".
5763         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5764         (maintenance_test_settings_set_list): Rename to ...
5765         (maintenance_set_test_settings_list): ... this.
5766         (maintenance_test_settings_show_list): Rename to  ...
5767         (maintenance_show_test_settings_list): ... this.
5768         (maintenance_test_settings_cmd): Delete.
5769         (maintenance_test_settings_set_cmd): ...
5770         (maintenance_set_test_settings_cmd): ... this.
5771         (maintenance_test_settings_show_cmd): ...
5772         (maintenance_show_test_settings_cmd): ... this.
5773         (maintenance_test_settings_show_value_cmd):
5774         (maintenance_show_test_settings_value_cmd): ... this.
5775         (_initialize_maint_test_settings): No longer install the "maint
5776         test-settings" prefix command.  Rename "maint test-settings set"
5777         to "maint set test-settings", and "maint test-settings show" to
5778         "maint show test-settings".  Adjust all subcommands.
5779
5780 2019-07-03  Pedro Alves  <palves@redhat.com>
5781
5782         * maint-test-settings.c: Fix file's intro comment.  Replace all
5783         references to "test-options" with references to "test-settings",
5784         in comments.
5785
5786 2019-07-03  Pedro Alves  <palves@redhat.com>
5787
5788         * maint-test-settings.c (maintenance_test_settings_xxx)
5789         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5790         New.
5791         (maintenance_test_settings_enums): Use them.
5792         (maintenance_test_settings_enum): Default to
5793         maintenance_test_settings_xxx.
5794         (_initialize_maint_test_settings): Initialize
5795         MAINTENANCE_TEST_SETTINGS_FILENAME.
5796
5797 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5798
5799         * breakpoint.h (remove_breakpoints_inf): Change return type to
5800         void, move function documentation here.
5801         * breakpoint.c (remove_breakpoints_inf): Change return type to
5802         void, move function documentation to header.
5803
5804 2019-07-02  Pedro Alves  <palves@redhat.com>
5805
5806         * NEWS (Completion improvements): Mention "info threads".
5807         * thread.c (struct info_threads_opts, info_threads_option_defs)
5808         (make_info_threads_options_def_group): New.
5809         (info_threads_command): Use gdb::option::process_options.
5810         (info_threads_command_completer): New.
5811         (_initialize_thread): Use gdb::option::build_help to build the
5812         help text for "info threads".
5813
5814 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5815
5816         * defs.h (generic_load): Move from here...
5817         * symfile.h (generic_load): ... to here.  Rename name parameter
5818         to args.
5819         * symfile.c (generic_load): Add comment.
5820
5821 2019-07-01  Tom Tromey  <tromey@adacore.com>
5822
5823         * dwarf2read.c
5824         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5825         declaration of without_params.  Fix formatting.
5826
5827 2019-07-01  Tom Tromey  <tromey@adacore.com>
5828
5829         * ada-exp.y (find_primitive_type): Update.
5830         * ada-lang.h (ada_lookup_symbol): Update.
5831         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5832         parameter.
5833         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5834
5835 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5836
5837         PR breakpoints/24541
5838         * gdbarch.c: Regenerate.
5839         * gdbarch.h: Regenerate.
5840         * gdbarch.sh: Add 'stap_adjust_register'.
5841         * i386-tdep.c: Include '<unordered_set>'.
5842         (i386_stap_adjust_register): New function.
5843         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5844         * stap-probe.c (stap_parse_register_operand): Call
5845         'gdbarch_stap_adjust_register'.
5846
5847 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5848
5849         PR python/24742
5850         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5851         * python/python.c (do_start_initialization): Use 'xmalloc'
5852         instead of 'PyMem_Malloc'.
5853
5854 2019-06-28  Tom Tromey  <tromey@adacore.com>
5855
5856         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5857         for Ada.
5858
5859 2019-06-27  Tom Tromey  <tromey@adacore.com>
5860
5861         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5862         objfile_key.
5863         (arm_find_mapping_symbol, arm_record_special_symbol)
5864         (_initialize_arm_tdep): Update.
5865         (arm_objfile_data_free): Remove.
5866
5867 2019-06-27  Tom Tromey  <tromey@adacore.com>
5868
5869         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5870         to cp_print_static_field.
5871
5872 2019-06-26  Tom Tromey  <tromey@adacore.com>
5873
5874         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5875         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5876         declare.
5877
5878 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5879
5880         * features/aarch64-core.c (create_feature_aarch64_core):
5881         Regenerate.
5882         * features/aarch64-core.xml: Add cpsr flags.
5883
5884 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5885
5886         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5887         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5888
5889 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5890
5891         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5892         field.
5893         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5894         use.
5895         (arm_record_special_symbol): Don't insert new symbol in sorted
5896         position, push it at the end.
5897
5898 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5899
5900         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5901         (arm_mapping_symbol_s): Remove.
5902         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5903         (arm_mapping_symbol_vec): New typedef.
5904         (struct arm_per_objfile): Add constructor.
5905         <section_maps>: Change type to
5906         std::unique_ptr<arm_mapping_symbol_vec[]>.
5907         (arm_compare_mapping_symbols): Remove.
5908         (arm_find_mapping_symbol): Adjust to section_maps type change.
5909         (arm_objfile_data_free): Call delete on arm_per_objfile.
5910         (arm_record_special_symbol): Adjust to section_maps type change.
5911         Allocate arm_per_objfile with new.
5912
5913 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5914
5915         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5916         with the command prefix.
5917
5918 2019-06-25  Tom Tromey  <tom@tromey.com>
5919
5920         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5921         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5922
5923 2019-06-25  Tom Tromey  <tom@tromey.com>
5924
5925         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5926         type.
5927         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5928         protected.
5929
5930 2019-06-25  Tom Tromey  <tom@tromey.com>
5931
5932         * tui/tui-winsource.c
5933         (tui_source_window_base::set_is_exec_point_at): Add check against
5934         LOA_ADDRESS.
5935
5936 2019-06-25  Tom Tromey  <tom@tromey.com>
5937
5938         * tui/tui-source.c (tui_set_source_content): Don't check before
5939         xfree.
5940         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5941
5942 2019-06-25  Tom Tromey  <tom@tromey.com>
5943
5944         * tui/tui-winsource.h (tui_update_source_window_as_is)
5945         (tui_alloc_source_buffer, tui_line_is_displayed)
5946         (tui_addr_is_displayed): Change type of win_info.
5947         * tui/tui-winsource.c (tui_update_source_window_as_is)
5948         (tui_clear_source_content, tui_show_source_line)
5949         (tui_show_source_content, tui_source_window_base::refill)
5950         (tui_source_window_base::set_is_exec_point_at)
5951         (tui_source_window_base::set_is_exec_point_at)
5952         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5953         (tui_alloc_source_buffer, tui_line_is_displayed)
5954         (tui_addr_is_displayed): Change type of win_info.  Update.
5955         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5956         (tui_source_window_base::do_make_visible_with_new_height):
5957         Update.
5958         * tui/tui-source.c (tui_set_source_content)
5959         (tui_set_source_content_nil)
5960         (tui_source_window::do_scroll_vertical): Update.
5961         * tui/tui-layout.c (show_layout): Update.
5962         * tui/tui-disasm.c (tui_set_disassem_content)
5963         (tui_disasm_window::do_scroll_vertical): Update.
5964         * tui/tui-data.h (tui_win_content): Remove.
5965         (struct tui_gen_win_info) <content, content_size>: Remove.
5966         (struct tui_source_element): Add initializers and destructor.
5967         (union tui_which_element, struct tui_win_element): Remove.
5968         (struct tui_source_window_base) <content>: New field.
5969         (struct tui_data_window): Remove destructor.
5970         (tui_alloc_content, tui_free_win_content)
5971         (tui_free_all_source_wins_content): Don't declare.
5972         * tui/tui-data.c (tui_initialize_static_data): Update.
5973         (init_content_element, tui_alloc_content): Remove.
5974         (~tui_gen_win_info): Update.
5975         (~tui_data_window, tui_free_all_source_wins_content)
5976         (tui_free_win_content, free_content, free_content_elements):
5977         Remove.
5978
5979 2019-06-25  Tom Tromey  <tom@tromey.com>
5980
5981         * tui/tui-winsource.h (tui_clear_source_content)
5982         (tui_erase_source_content, tui_show_source_content): Change type
5983         of win_info.
5984         * tui/tui-winsource.c (tui_clear_source_content)
5985         (tui_erase_source_content, tui_show_source_content): Change type
5986         of win_info.
5987         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5988         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5989         win_info.
5990         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5991         win_info.
5992         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5993
5994 2019-06-25  Tom Tromey  <tom@tromey.com>
5995
5996         * tui/tui-winsource.c (tui_clear_source_content)
5997         (tui_source_window_base::set_is_exec_point_at): Update.
5998         * tui/tui-source.c (tui_set_source_content_nil): Update.
5999         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6000         a bool.
6001         * tui/tui-data.c (init_content_element): Update.
6002
6003 2019-06-25  Tom Tromey  <tom@tromey.com>
6004
6005         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6006         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6007         * tui/tui-layout.c (init_and_make_win): Update.
6008         * tui/tui.h (enum tui_win_type): Update.
6009         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6010         tui_win_is_auxillary.
6011         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6012         tui_win_is_auxillary.
6013
6014 2019-06-25  Tom Tromey  <tom@tromey.com>
6015
6016         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6017         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6018         (tui_delete_data_content_windows, tui_display_all_data)
6019         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6020         Update.
6021         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6022         * tui/tui-regs.c (tui_last_regs_line_no)
6023         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6024         (tui_show_registers): Update.
6025         (tui_show_register_group): Return void.  Update.
6026         (tui_display_registers_from, tui_display_reg_element_at_line)
6027         (tui_display_registers_from_line, tui_check_register_values):
6028         Update.
6029         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6030         member.
6031         (struct tui_data_window) <regs_content>: Now a std::vector.
6032         <regs_content_count>: Remove.
6033         (tui_add_content_elements, tui_free_data_content): Don't declare.
6034         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6035         (init_content_element): Remove DATA_WIN case.  Add assert.
6036         (tui_add_content_elements): Remove.
6037         (tui_data_window): Update.
6038         (tui_free_data_content): Remove.
6039         (free_content_elements): Remove DATA_WIN case.
6040
6041 2019-06-25  Tom Tromey  <tom@tromey.com>
6042
6043         * tui/tui-data.c (tui_data_item_window): Update.
6044         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6045         * tui/tui-windata.c (tui_display_all_data)
6046         (tui_display_data_from_line): Update.
6047         (tui_check_data_values): Remove.
6048         * tui/tui-regs.c (tui_show_register_group)
6049         (tui_display_reg_element_at_line): Update.
6050         * tui/tui-hooks.c (tui_register_changed)
6051         (tui_refresh_frame_and_register_information): Call
6052         tui_check_register_values.
6053         * tui/tui-data.h (struct tui_data_window) <data_content,
6054         data_content_count, data_type>: Remove.
6055         (enum tui_data_type): Remove.
6056
6057         * tui/tui-data.c (tui_data_window::clear_detail)
6058         (~tui_data_window): Update.
6059
6060 2019-06-25  Tom Tromey  <tom@tromey.com>
6061
6062         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6063         declare.
6064         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6065         Rename from tui_first_data_item_displayed.  Update.
6066         (tui_data_window::refresh_all)
6067         (tui_data_window::do_scroll_vertical): Update.
6068         * tui/tui-data.h (struct tui_data_window)
6069         <first_data_item_displayed>: Declare new method.
6070
6071 2019-06-25  Tom Tromey  <tom@tromey.com>
6072
6073         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6074         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6075         contents...
6076         (tui_initialize_static_data): ...here.
6077
6078 2019-06-25  Tom Tromey  <tom@tromey.com>
6079
6080         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6081         (tui_display_registers_from, tui_check_register_values): Update.
6082         (tui_display_register): Remove win_info parameter; update.
6083         (tui_get_register): Change type of parameters.
6084         * tui/tui-data.h (struct tui_data_element): Remove.
6085         (union tui_which_element) <data>: Remove.
6086         <data_window>: Change type.
6087         (struct tui_data_item_window): New.
6088         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6089         case.  Add assert.
6090         (~tui_data_item_window): New destructor.
6091         (free_content_elements): Remove DATA_ITEM_WIN case.
6092
6093 2019-06-25  Tom Tromey  <tom@tromey.com>
6094
6095         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6096         Remove.
6097
6098 2019-06-25  Tom Tromey  <tom@tromey.com>
6099
6100         * tui/tui-data.h (struct tui_command_element): Remove.
6101         (union tui_which_element) <command>: Remove.
6102         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6103         assert.
6104         (free_content_elements): Remove CMD_WIN case.
6105
6106 2019-06-25  Tom Tromey  <tom@tromey.com>
6107
6108         * tui/tui-layout.c (tui_set_layout): Update.
6109         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6110         * tui/tui-data.c (layout_def): Update.
6111
6112 2019-06-25  Tom Tromey  <tom@tromey.com>
6113
6114         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6115         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6116         (tui_source_window_base::set_new_height): Update.
6117         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6118         Update.
6119         (tui_set_locator_fullname, tui_set_locator_info)
6120         (tui_show_frame_info): Update.
6121         * tui/tui-source.c (tui_set_source_content)
6122         (tui_source_is_displayed): Update.
6123         * tui/tui-layout.c (show_source_disasm_command, show_data)
6124         (show_source_or_disasm_and_command): Update.
6125         * tui/tui-disasm.c (tui_set_disassem_content)
6126         (tui_get_begin_asm_address): Update.
6127         * tui/tui-data.h (struct tui_locator_element): Remove.
6128         (union tui_which_element) <locator>: Remove.
6129         (struct tui_locator_window): New.
6130         (tui_locator_win_info_ptr): Change return type.
6131         * tui/tui-data.c (_locator): Change type.
6132         (tui_locator_win_info_ptr): Change return type.
6133         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6134         (tui_alloc_content): Add assert.
6135
6136 2019-06-25  Tom Tromey  <tom@tromey.com>
6137
6138         * tui/tui-winsource.c
6139         (tui_exec_info_window::maybe_allocate_content): New method.
6140         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6141         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6142         (make_source_or_disasm_window): Add cast.
6143         * tui/tui-data.h (union tui_which_element) <simple_string>:
6144         Remove.
6145         (struct tui_source_info): New.
6146         (struct tui_source_window_base) <execution_info>: Change type.
6147         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6148         case, and add assert.
6149         (tui_alloc_content): Add assert.
6150
6151 2019-06-25  Tom Tromey  <tom@tromey.com>
6152
6153         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6154         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6155         * tui/tui-data.c (tui_alloc_win_info): Remove.
6156
6157 2019-06-25  Tom Tromey  <tom@tromey.com>
6158
6159         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6160         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6161         can_highlight.
6162
6163 2019-06-25  Tom Tromey  <tom@tromey.com>
6164
6165         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6166         make_visible_with_new_height method.
6167         (tui_win_info::make_visible_with_new_height): New method.
6168         (tui_source_window_base::do_make_visible_with_new_height)
6169         (tui_data_window::do_make_visible_with_new_height)
6170         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6171         (make_visible_with_new_height): Remove.
6172         (tui_resize_all, tui_adjust_win_heights): Use
6173         make_visible_with_new_height method.
6174         * tui/tui-data.h (struct tui_win_info)
6175         <do_make_visible_with_new_height, make_visible_with_new_height>:
6176         New methods.
6177         (struct tui_source_window_base, struct tui_data_window)
6178         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6179         methods.
6180
6181 2019-06-25  Tom Tromey  <tom@tromey.com>
6182
6183         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6184         method.
6185         (update_tab_width): Call update_tab_width method.
6186         * tui/tui-data.h (struct tui_win_info)
6187         (struct tui_source_window_base) <update_tab_width>: New methods.
6188
6189 2019-06-25  Tom Tromey  <tom@tromey.com>
6190
6191         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6192         parameter.
6193         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6194         parameter.
6195         (tui_gen_win_info::make_visible): Update.
6196         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6197         parameter.
6198         * tui/tui-data.h (enum tui_box): New enum.
6199         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6200
6201 2019-06-25  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6204         init_and_make_win for EXEC_INFO_WIN.
6205         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6206         longer inline.
6207         (struct tui_win_info) <~tui_win_info>: Inline.
6208         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6209         Don't declare.
6210         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6211         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6212         Remove.
6213         (tui_initialize_static_data): Update.
6214         (~tui_gen_win_info): Handle more cleanup here.
6215         (~tui_source_window_base): Delete "execution_info".
6216         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6217
6218 2019-06-25  Tom Tromey  <tom@tromey.com>
6219
6220         * tui/tui-layout.c (make_command_window): Don't set
6221         can_highlight.
6222         (show_source_disasm_command): Call the reset method.
6223         (show_data): Don't set can_highlight.  Call the reset method.
6224         (tui_gen_win_info::reset): Rename from init_gen_win_info
6225         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6226         (show_source_or_disasm_and_command): Call the reset method.
6227         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6228         (struct tui_cmd_window): Set can_highlight.
6229
6230 2019-06-25  Tom Tromey  <tom@tromey.com>
6231
6232         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6233         from make_visible.
6234         (tui_make_visible, tui_make_invisible): Rewrite.
6235         (tui_win_info::make_visible): Remove.
6236         (tui_source_window_base::make_visible): Update.
6237         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6238         method.  Moved from...
6239         (struct tui_win_info) <make_visible>: ...here.
6240
6241 2019-06-25  Tom Tromey  <tom@tromey.com>
6242
6243         * tui/tui-winsource.c
6244         (tui_source_window_base::do_scroll_horizontal): Remove direction
6245         parameter.
6246         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6247         direction parameter.
6248         * tui/tui-win.c (tui_win_info::forward_scroll)
6249         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6250         (tui_win_info::right_scroll): Update.
6251         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6252         direction parameter.
6253         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6254         direction parameter.
6255         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6256         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6257         Remove direction parameter.
6258         (struct tui_source_window_base, struct tui_source_window)
6259         (struct tui_disasm_window, struct tui_data_window)
6260         (struct tui_cmd_window): Update.
6261
6262 2019-06-25  Tom Tromey  <tom@tromey.com>
6263
6264         * tui/tui-winsource.h (tui_set_exec_info_content)
6265         (tui_show_exec_info_content, tui_erase_exec_info_content)
6266         (tui_clear_exec_info_content, tui_update_exec_info): Change
6267         argument to tui_source_window_base.
6268         * tui/tui-winsource.c (tui_set_exec_info_content)
6269         (tui_show_exec_info_content, tui_erase_exec_info_content)
6270         (tui_clear_exec_info_content, tui_update_exec_info): Change
6271         argument to tui_source_window_base.
6272
6273 2019-06-25  Tom Tromey  <tom@tromey.com>
6274
6275         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6276         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6277
6278 2019-06-25  Tom Tromey  <tom@tromey.com>
6279
6280         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6281         check.
6282
6283 2019-06-25  Tom Tromey  <tom@tromey.com>
6284
6285         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6286         type to void.
6287         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6288         type to void.
6289         * tui/tui-source.c (tui_set_source_content): Update.
6290         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6291
6292 2019-06-25  Tom Tromey  <tom@tromey.com>
6293
6294         * tui/tui-win.c (window_name_completer, tui_set_focus)
6295         (tui_all_windows_info): Use name method.
6296         * tui/tui-data.h (struct tui_gen_win_info)
6297         (struct tui_source_window, struct tui_disasm_window)
6298         (struct tui_data_window, struct tui_cmd_window) <name>: New
6299         method.
6300         (tui_win_name): Don't declare.
6301         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6302         (tui_win_name): Remove.
6303
6304 2019-06-25  Tom Tromey  <tom@tromey.com>
6305
6306         * tui/tui-winsource.h (tui_update_source_window)
6307         (tui_update_source_window_as_is): Change parameter type.
6308         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6309         to be a tui_source_window_base.
6310         (tui_update_source_window_as_is): Likewise.
6311         * tui/tui-win.c (make_visible_with_new_height): Update.
6312
6313 2019-06-25  Tom Tromey  <tom@tromey.com>
6314
6315         * tui/tui-winsource.c (tui_erase_source_content)
6316         (tui_show_source_content, tui_show_exec_info_content)
6317         (tui_erase_exec_info_content): Use refresh_window method.
6318         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6319         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6320         from tui_refresh_win.
6321         (tui_data_window::refresh_window): New method.
6322         (tui_win_info::refresh, tui_source_window_base::refresh)
6323         (tui_refresh_all): Use refresh_window method.
6324         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6325         method.
6326         * tui/tui-regs.c (tui_display_register): Call refresh_window
6327         method.
6328         * tui/tui-layout.c (show_source_disasm_command)
6329         (show_source_or_disasm_and_command): Call refresh_window method.
6330         * tui/tui-data.h (struct tui_gen_win_info)
6331         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6332         New method.
6333
6334 2019-06-25  Tom Tromey  <tom@tromey.com>
6335
6336         * tui/tui.c (tui_rl_other_window, tui_enable)
6337         (tui_is_window_visible, tui_get_command_dimension): Update.
6338         * tui/tui-winsource.c (tui_update_source_window_as_is)
6339         (tui_clear_source_content, tui_erase_source_content)
6340         (tui_show_source_line, tui_source_window_base::refill)
6341         (tui_source_window_base::do_scroll_horizontal)
6342         (tui_source_window_base::set_is_exec_point_at)
6343         (tui_update_breakpoint_info, tui_set_exec_info_content)
6344         (tui_alloc_source_buffer, tui_line_is_displayed)
6345         (tui_addr_is_displayed): Update.
6346         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6347         (tui_check_and_display_highlight_if_needed)
6348         (tui_win_info::make_visible, tui_win_info::refresh)
6349         (tui_refresh_all): Update.
6350         * tui/tui-windata.c (tui_first_data_item_displayed)
6351         (tui_delete_data_content_windows, tui_erase_data_content)
6352         (tui_display_all_data, tui_data_window::refresh_all)
6353         (tui_check_data_values): Update.
6354         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6355         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6356         (tui_win_info::backward_scroll, tui_refresh_all_win)
6357         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6358         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6359         (tui_source_window_base::set_new_height)
6360         (tui_data_window::set_new_height)
6361         (make_invisible_and_set_new_height)
6362         (make_visible_with_new_height, new_height_ok)
6363         (parse_scrolling_args): Update.
6364         * tui/tui-stack.c (tui_show_frame_info): Update.
6365         * tui/tui-source.c (tui_set_source_content)
6366         (tui_set_source_content_nil, tui_source_is_displayed)
6367         (tui_source_window::do_scroll_vertical): Update.
6368         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6369         (tui_display_registers_from, tui_display_reg_element_at_line)
6370         (tui_check_register_values, tui_reg_command): Update.
6371         * tui/tui-layout.c (tui_default_win_height)
6372         (show_source_disasm_command, show_data, init_and_make_win)
6373         (show_source_or_disasm_and_command): Update.
6374         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6375         (tui_redisplay_readline, tui_mld_flush)
6376         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6377         (tui_getc): Update.
6378         * tui/tui-disasm.c (tui_set_disassem_content)
6379         (tui_disasm_window::do_scroll_vertical): Update.
6380         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6381         Now virtual.
6382         (struct tui_win_info): Derive from tui_gen_win_info.
6383         <~tui_win_info>: Mark as override.
6384         <generic>: Remove member.
6385         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6386         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6387         (~tui_data_window, ~tui_win_info)
6388         (tui_free_all_source_wins_content): Update.
6389         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6390
6391 2019-06-25  Tom Tromey  <tom@tromey.com>
6392
6393         * tui/tui-layout.c (init_and_make_win): Use new.
6394         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6395         destructor, initializers.
6396         (tui_alloc_generic_win_info): Don't declare.
6397         * tui/tui-data.c (_locator): Add argument to constructor.
6398         (source_win, disasm_win): New globals.
6399         (exec_info): Remove.
6400         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6401         Update.
6402         (tui_alloc_generic_win_info): Remove.
6403         (init_content_element): Use new.
6404         (tui_win_info::tui_win_info): Update.
6405         (free_content_elements) <case DATA_WIN>: Use delete.
6406
6407 2019-06-25  Tom Tromey  <tom@tromey.com>
6408
6409         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6410         * tui/tui-windata.c (tui_first_data_item_displayed)
6411         (tui_delete_data_content_windows): Update.
6412         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6413         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6414         (tui_display_registers_from, tui_check_register_values): Update.
6415         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6416         pointer.
6417         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6418         window.
6419         (tui_free_data_content): Update.
6420         (free_content_elements) <case DATA_WIN>: Free the window.
6421
6422 2019-06-25  Tom Tromey  <tom@tromey.com>
6423
6424         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6425         Update.
6426         * tui/tui-layout.c (make_command_window)
6427         (show_source_disasm_command, show_data, init_and_make_win)
6428         (show_source_or_disasm_and_command): Update.
6429         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6430         method.
6431         <can_highight, is_highlighted>: Now bool.
6432         (tui_set_win_highlight): Don't declare.
6433         * tui/tui-data.c (tui_set_win_highlight): Remove.
6434
6435 2019-06-25  Tom Tromey  <tom@tromey.com>
6436
6437         * tui/tui-wingeneral.c (make_visible): Remove check of window
6438         type.
6439
6440 2019-06-25  Tom Tromey  <tom@tromey.com>
6441
6442         * tui/tui-win.c (tui_win_info::max_height)
6443         (tui_cmd_window::max_height): New methods.
6444         (new_height_ok): Call max_height.
6445         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6446         <max_height>: New method.
6447
6448 2019-06-25  Tom Tromey  <tom@tromey.com>
6449
6450         * tui/tui-win.c (tui_source_window_base::set_new_height)
6451         (tui_data_window::set_new_height): New methods.
6452         (make_invisible_and_set_new_height): Call set_new_height method.
6453         * tui/tui-data.h (struct tui_win_info)
6454         (struct tui_source_window_base, struct tui_data_window)
6455         <set_new_height>: New method.
6456
6457 2019-06-25  Tom Tromey  <tom@tromey.com>
6458
6459         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6460         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6461         tui_refresh_data_win.
6462         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6463         method.
6464         (tui_refresh_all_win): Call the refresh_all method.
6465         (tui_set_focus): Likewise.
6466         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6467         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6468         Likewise.
6469
6470 2019-06-25  Tom Tromey  <tom@tromey.com>
6471
6472         * tui/tui-winsource.h (tui_refill_source_window)
6473         (tui_set_is_exec_point_at): Don't declare.
6474         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6475         (tui_source_window_base::refill): Rename from
6476         tui_refill_source_window.
6477         (tui_source_window_base::do_scroll_horizontal): Update.
6478         (tui_source_window_base::set_is_exec_point_at): Rename from
6479         tui_set_is_exec_point_at.
6480         (tui_update_all_breakpoint_info): Update.
6481         * tui/tui-stack.c (tui_show_frame_info): Update.
6482         * tui/tui-layout.c (show_data): Add cast.
6483         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6484         * tui/tui-data.h (struct tui_source_window_base) <refill,
6485         set_is_exec_point_at>: New methods.
6486         (tui_source_windows, tui_add_to_source_windows): Update types.
6487         (tui_add_to_source_windows): Remove redundant declaration.
6488         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6489         (tui_source_windows): Change return type.
6490         (tui_clear_source_windows_detail): Update.
6491         (tui_add_to_source_windows): Change type of parameter.
6492         (tui_free_all_source_wins_content): Update.
6493
6494 2019-06-25  Tom Tromey  <tom@tromey.com>
6495
6496         * tui/tui-wingeneral.c (tui_win_info::refresh)
6497         (tui_source_window_base::refresh): New methods.
6498         (tui_refresh_all): Call the refresh method.
6499         * tui/tui-data.h (struct tui_win_info)
6500         (struct tui_source_window_base) <refresh>: New method.
6501
6502 2019-06-25  Tom Tromey  <tom@tromey.com>
6503
6504         * tui/tui.h (tui_is_window_visible): Return bool.
6505         * tui/tui.c (tui_is_window_visible): Return bool.
6506         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6507         (tui_make_visible, tui_make_invisible)
6508         (tui_win_info::make_visible)
6509         (tui_source_window_base::make_visible, make_all_visible)
6510         (tui_make_all_visible, tui_make_all_invisible): Update.
6511         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6512         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6513         bool.
6514         (struct tui_win_info, struct tui_source_window_base)
6515         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6516         * tui/tui-data.c (tui_init_generic_part): Update.
6517
6518 2019-06-25  Tom Tromey  <tom@tromey.com>
6519
6520         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6521         (tui_source_window_base::make_visible): New methods.
6522         (make_all_visible): Make method call.
6523         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6524         (struct tui_source_window_base, struct tui_cmd_window): Override
6525         make_visible.
6526         (tui_win_is_source_type): Don't declare.
6527         * tui/tui-data.c (tui_win_is_source_type): Remove.
6528
6529 2019-06-25  Tom Tromey  <tom@tromey.com>
6530
6531         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6532         NULL check.
6533
6534 2019-06-25  Tom Tromey  <tom@tromey.com>
6535
6536         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6537         Inline constructor.  Add initializers for members.
6538         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6539         constructors; now inline in class.
6540
6541 2019-06-25  Tom Tromey  <tom@tromey.com>
6542
6543         * tui/tui-regs.c (tui_show_registers): Update.
6544         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6545         bool.
6546         * tui/tui-data.c (tui_data_window::clear_detail)
6547         (tui_data_window): Update.
6548
6549 2019-06-25  Tom Tromey  <tom@tromey.com>
6550
6551         * tui/tui-windata.c (tui_display_all_data)
6552         (tui_display_data_from_line, tui_display_data_from)
6553         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6554         Update.
6555         * tui/tui-regs.c (tui_last_regs_line_no)
6556         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6557         (tui_show_registers, tui_show_register_group)
6558         (tui_display_registers_from, tui_display_reg_element_at_line)
6559         (tui_display_registers_from_line, tui_check_register_values)
6560         (tui_reg_next, tui_reg_prev): Update.
6561         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6562         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6563         tui_data_window.
6564         (struct tui_win_info) <detail>: Remove.  Add new fields from
6565         tui_data_info.
6566         (TUI_DATA_WIN): Add cast.
6567         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6568         (~tui_data_window): Simplify.
6569
6570 2019-06-25  Tom Tromey  <tom@tromey.com>
6571
6572         * tui/tui-layout.c (show_source_disasm_command)
6573         (show_source_or_disasm_and_command): Update.
6574         * tui/tui-io.c (update_cmdwin_start_line)
6575         (tui_redisplay_readline): Update.
6576         * tui/tui-data.h (struct tui_command_info): Remove.
6577         (struct tui_win_info) <detail>: Remove command_info member.
6578         (struct tui_data_window) <start_line>: New member, from
6579         tui_command_info.
6580         (TUI_CMD_WIN): Add casts.
6581
6582 2019-06-25  Tom Tromey  <tom@tromey.com>
6583
6584         * tui/tui-winsource.c (tui_update_source_window)
6585         (tui_refill_source_window)
6586         (tui_source_window_base::do_scroll_horizontal)
6587         (tui_update_breakpoint_info, tui_set_exec_info_content)
6588         (tui_show_exec_info_content, tui_erase_exec_info_content)
6589         (tui_clear_exec_info_content): Update.
6590         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6591         Update.
6592         * tui/tui-win.c (make_invisible_and_set_new_height)
6593         (make_visible_with_new_height): Update.
6594         * tui/tui-source.c (tui_set_source_content)
6595         (tui_show_symtab_source): Update.
6596         * tui/tui-layout.c (extract_display_start_addr)
6597         (show_source_disasm_command, show_data)
6598         (make_source_or_disasm_window)
6599         (show_source_or_disasm_and_command): Update.
6600         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6601         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6602         "gdbarch".
6603         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6604         to tui_source_window_base.
6605         (struct tui_win_info) <detail>: Remove source_info member.
6606         (struct tui_source_window_base) <has_locator>: Inline.
6607         Move contents from tui_source_info; rename has_locator member to
6608         m_has_locator.
6609         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6610         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6611         header file.
6612         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6613         Simplify.
6614         (tui_free_all_source_wins_content): Cast to
6615         tui_source_window_base.
6616
6617 2019-06-25  Tom Tromey  <tom@tromey.com>
6618
6619         * tui/tui-win.c (make_invisible_and_set_new_height)
6620         (make_visible_with_new_height): Call has_locator method.
6621         * tui/tui-layout.c (show_source_disasm_command, show_data)
6622         (show_source_or_disasm_and_command): Update for bool change.
6623         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6624         (tui_win_info) <has_locator>: New method.
6625         (struct tui_source_window_base) <has_locator>: New method.
6626         (tui_win_has_locator): Don't declare.
6627         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6628         from tui_win_has_locator.
6629         (tui_source_window_base): Use false, not FALSE.
6630
6631 2019-06-25  Tom Tromey  <tom@tromey.com>
6632
6633         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6634         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6635         clear_detail method directly.
6636         (tui_clear_win_detail): Remove.
6637
6638 2019-06-25  Tom Tromey  <tom@tromey.com>
6639
6640         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6641         "this", not TUI_DISASM_WIN.
6642
6643 2019-06-25  Tom Tromey  <tom@tromey.com>
6644
6645         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6646         declare.
6647         * tui/tui-winsource.c
6648         (tui_source_window_base::do_scroll_horizontal): Rename from
6649         tui_horizontal_source_scroll.
6650         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6651         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6652         from tui_vertical_data_scroll.
6653         * tui/tui-win.h (tui_scroll): Don't declare.
6654         * tui/tui-win.c (tui_win_info::forward_scroll)
6655         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6656         (tui_win_info::right_scroll): Rename and update.
6657         (tui_scroll_forward_command, tui_scroll_backward_command)
6658         (tui_scroll_left_command, tui_scroll_right_command): Update.
6659         (tui_scroll): Remove.
6660         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6661         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6662         from tui_vertical_source_scroll.
6663         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6664         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6665         from tui_vertical_disassem_scroll.
6666         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6667         do_scroll_horizontal>: New methods.
6668         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6669         Likewise.
6670         (struct tui_source_window_base): Add do_scroll_horizontal.
6671         (struct tui_source_window, struct tui_disasm_window): Add
6672         do_scroll_vertical.
6673         (struct tui_data_window, struct tui_cmd_window): Add
6674         do_scroll_horizontal and do_scroll_vertical.
6675         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6676
6677 2019-06-25  Tom Tromey  <tom@tromey.com>
6678
6679         * tui/tui-data.h (struct tui_source_window_base): New struct.
6680         (struct tui_source_window): Derive from tui_source_window_base.
6681         (struct tui_disasm_window): New struct.
6682         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6683         from tui_source_window::clear_detail.
6684         (tui_source_window_base): Rename from tui_source_window.
6685         (~tui_source_window_base): Rename from ~tui_source_window.
6686         (tui_alloc_win_info): Create a tui_disasm_window.
6687
6688 2019-06-25  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui-data.h (struct tui_source_window)
6691         (struct tui_data_window): Declare destructors.
6692         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6693         destructors.
6694         (tui_win_info): Simplify.
6695
6696 2019-06-25  Tom Tromey  <tom@tromey.com>
6697
6698         * tui/tui-winsource.c (tui_display_main)
6699         (tui_update_source_windows_with_addr)
6700         (tui_update_all_breakpoint_info): Update.
6701         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6702         (new_height_ok, parse_scrolling_args): Update.
6703         * tui/tui-stack.c (tui_show_frame_info): Update.
6704         * tui/tui-data.h (struct tui_list): Remove.
6705         (tui_source_windows): Return a reference to a std::vector.
6706         * tui/tui-data.c (source_windows): Now a std::vector.
6707         (tui_source_windows): Change return type.
6708         (tui_clear_source_windows): Rewrite.
6709         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6710         (tui_free_all_source_wins_content): Rewrite.
6711
6712 2019-06-25  Tom Tromey  <tom@tromey.com>
6713
6714         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6715         (struct tui_data_window, struct tui_cmd_window): Declare
6716         clear_detail method.
6717         * tui/tui-data.c (tui_source_window::clear_detail)
6718         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6719         methods.
6720         (tui_clear_win_detail): Simplify.
6721
6722 2019-06-25  Tom Tromey  <tom@tromey.com>
6723
6724         * tui/tui-layout.c (make_source_window, make_disasm_window)
6725         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6726         Return the new window.
6727         (show_source_disasm_command, show_data)
6728         (show_source_or_disasm_and_command): Update.
6729
6730 2019-06-25  Tom Tromey  <tom@tromey.com>
6731
6732         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6733         parameter.  Return the new window.
6734         (show_source_disasm_command): Update and remove NULL check.
6735         (show_source_or_disasm_and_command): Update.
6736
6737 2019-06-25  Tom Tromey  <tom@tromey.com>
6738
6739         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6740
6741 2019-06-25  Tom Tromey  <tom@tromey.com>
6742
6743         * tui/tui-data.h (struct tui_win_info): Make constructor
6744         protected.  Make destructor virtual.  Add initializers.
6745         (tui_source_window, tui_data_window, tui_cmd_window): New
6746         classes.
6747         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6748         constructor.  Add "type" parameter.
6749         (tui_source_window, tui_data_window, tui_cmd_window): New
6750         constructors.
6751         (tui_alloc_win_info): Instantiate the appropriate subclass.
6752
6753 2019-06-25  Tom Tromey  <tom@tromey.com>
6754
6755         * tui/tui-win.c (tui_resize_all): Use delete.
6756         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6757         destructor.
6758         (tui_free_window): Don't declare.
6759         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6760         Update.
6761
6762 2019-06-25  Tom Tromey  <tom@tromey.com>
6763
6764         * tui/tui-data.h (struct tui_win_info): Add constructor.
6765         * tui/tui-data.c (tui_alloc_win_info): Use new.
6766         (tui_free_window): Use delete.
6767
6768 2019-06-22  Tom Tromey  <tom@tromey.com>
6769
6770         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6771         declare.
6772         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6773
6774 2019-06-22  Tom Tromey  <tom@tromey.com>
6775
6776         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6777         declare.
6778         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6779
6780 2019-06-22  Tom de Vries  <tdevries@suse.de>
6781
6782         * dwarf2read.c (create_addrmap_from_aranges)
6783         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6784         instead of '%zu'.
6785
6786 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6787
6788         * dwarf2read.h (dwarf2_section_info_def): Remove.
6789         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6790         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6791         std::vector<dwarf2_section_info>.
6792         (struct dwo_file) <~dwo_file>: Remove.
6793         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6794         types field.
6795         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6796         (dwarf2_read_debug_names): Likewise.
6797         (create_debug_types_hash_table): Change parameter type to
6798         array_view, adjust code accordingly.
6799         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6800         (partial_die_info::fixup): Likewise.
6801         (determine_prefix): Likewise.
6802         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6803
6804 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6805
6806         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6807         gdb_bfd_ref_ptr.
6808         <~dwo_file>: Remove call to gdb_bfd_unref.
6809         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6810         gdb_bfd_ref_ptr::get.
6811
6812 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6813
6814         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6815         type to htab_up.
6816         * dwarf2read.c (struct dwo_file): Initialize fields.
6817         <~dwo_file>: New.
6818         (free_dwo_file): Remove, move content to ~dwo_file.
6819         (struct dwo_file_deleter): Remove.
6820         (dwo_file_up>: Remove custom deleter.
6821         (free_dwo_files): Remove.
6822         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6823         dwo_files.
6824         (process_skeletonless_type_units): Call unique_ptr::get.
6825         (allocate_dwo_file_hash_table): Add deleter to created hash
6826         table.  Change return type to htab_up.
6827         (lookup_dwo_file_slot): Don't memset dwo_file, call
6828         unique_ptr::get.
6829         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6830         (create_dwo_unit_in_dwp_v2): Likewise.
6831         (open_and_init_dwo_file): Likewise.
6832         (free_dwo_file_from_slot): Remove.
6833
6834 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6835
6836         * dwarf2read.h (struct dwarf2_section_info) <readin,
6837         is_virtual>: Change type to bool.
6838         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6839         true instead of 1.
6840
6841 2019-06-19  Tom Tromey  <tom@tromey.com>
6842
6843         * tui/tui-data.h (tui_init_content_element): Don't declare.
6844
6845 2019-06-19  Tom Tromey  <tom@tromey.com>
6846
6847         * tui/tui-data.h (tui_init_win_info): Don't declare.
6848
6849 2019-06-19  Tom de Vries  <tdevries@suse.de>
6850
6851         * dwarf2read.h (abstract_to_concrete): Change type to
6852         std::unordered_map<sect_offset, std::vector<sect_offset>,
6853         gdb::hash_enum<sect_offset>>.
6854
6855 2019-06-19  Tom Tromey  <tromey@adacore.com>
6856
6857         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6858         EVAL_AVOID_SIDE_EFFECTS specially.
6859
6860 2019-06-19  Tom Tromey  <tromey@adacore.com>
6861
6862         * source-cache.c (highlighter): New global.
6863         (source_cache::get_source_lines): Create a highlighter on demand.
6864
6865 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6866
6867         * defs.h (deprecated_interactive_hook): Delete declaration.
6868         * interps.c (clear_interpreter_hooks): Remove use of
6869         deprecated_interactive_hook.
6870         * top.c (deprecated_interactive_hook): Delete definition.
6871         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6872
6873 2019-06-18  Tom de Vries  <tdevries@suse.de>
6874
6875         PR gdb/24515
6876         * dwarf2read.h (abstract_to_concrete): Change type from
6877         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6878         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6879         * dwarf2read.c (read_variable): Update.
6880         (dwarf2_fetch_die_loc_sect_off): Update.
6881
6882 2019-06-17  Tom de Vries  <tdevries@suse.de>
6883
6884         PR gdb/24617
6885         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6886         accessing parent[parent_len - 1].
6887
6888 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6889
6890         PR gdb/24364
6891         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6892         call dtrace_process_dof with NULL dof.
6893
6894 2019-06-16  Tom de Vries  <tdevries@suse.de>
6895
6896         PR gdb/24445
6897         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6898
6899 2019-06-16  Tom Tromey  <tom@tromey.com>
6900
6901         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6902         (make_all_visible): Use address of member.
6903
6904 2019-06-16  Tom Tromey  <tom@tromey.com>
6905
6906         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6907         (tui_free_window, free_content, free_content_elements): Remove
6908         unnecessary cast.
6909         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6910         cast.
6911         * tui/tui-regs.c (tui_show_register_group)
6912         (tui_display_registers_from, tui_display_reg_element_at_line):
6913         Remove unnecessary cast.
6914
6915 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6916
6917         * linux-nat.c (normal_mask): Delete.
6918         (_initialize_linux_nat): Don't initialise normal_mask.
6919
6920 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6921
6922         PR gdb/24445
6923         * dwarf-index-write.h (write_psymtabs_to_index): Add
6924         dwz_basename parameter.
6925         * dwarf-index-write.c (write_gdbindex): Move file writing to
6926         write_gdbindex_1.  Change return type void.
6927         (assert_file_size): Move up, remove filename parameter.
6928         (write_gdbindex_1): New function.
6929         (write_debug_names): Change return type to void, call
6930         assert_file_size.
6931         (struct index_wip_file): New struct.
6932         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6933         file logic to index_wip_file.  Write index for dwz file if
6934         needed.
6935         (save_gdb_index_command): Pass basename of dwz file, if present.
6936         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6937         build-id of dwz file, if present.
6938         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6939         (dwarf2_get_dwz_file): Likewise.
6940         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6941         (dwarf2_get_dwz_file): Likewise.
6942
6943 2019-06-16  Tom Tromey  <tom@tromey.com>
6944
6945         * coffread.c (process_coff_symbol): Use xstrdup.
6946         * value.c (create_internalvar): Use xstrdup.
6947
6948 2019-06-16  Tom Tromey  <tom@tromey.com>
6949
6950         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6951         * breakpoint.c (stopin_command, stopat_command)
6952         (until_break_command, decode_location_default): Remove unnecessary
6953         cast.
6954         * utils.c (subset_compare): Remove unnecessary cast.
6955         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6956         cast.
6957         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6958         cast.
6959         * infcmd.c (path_command): Remove unnecessary cast.
6960         * coffread.c (decode_type): Remove unnecessary cast.
6961         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6962         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6963         * tui/tui-stack.c (tui_show_locator_content)
6964         (tui_show_frame_info): Remove unnecessary cast.
6965         * tui/tui-win.c (tui_scroll_forward_command)
6966         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6967         (parse_scrolling_args): Remove unnecessary cast.
6968         * tui/tui-data.c (init_win_info, tui_del_window)
6969         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6970         (free_content_elements): Remove unnecessary cast.
6971         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6972         unnecessary cast.
6973         * tui/tui-source.c (tui_set_source_content)
6974         (tui_vertical_source_scroll): Remove unnecessary cast.
6975         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6976         cast.
6977         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6978         * tui/tui-regs.c (tui_display_registers_from)
6979         (tui_display_register): Remove unnecessary cast.
6980         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6981         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6982         (make_visible): Remove unnecessary cast.
6983         * tui/tui-winsource.c (tui_erase_source_content)
6984         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6985         unnecessary cast.
6986         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6987         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6988         * stabsread.c (read_type, read_array_type, read_range_type):
6989         Remove unnecessary cast.
6990         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6991         (parse_symbol, parse_type, upgrade_type, parse_external)
6992         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6993         unnecessary cast.
6994         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6995
6996 2019-06-16  Tom Tromey  <tom@tromey.com>
6997
6998         * tui/tui-data.c (tui_alloc_generic_win_info)
6999         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7000         checks.
7001
7002 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7003             Andrew Burgess  <andrew.burgess@embecosm.com>
7004
7005         * f-typeprint.c (f_print_type): Don't return early for not
7006         associated or not allocated types.
7007         (f_type_print_varspec_suffix): Add print_rank parameter and print
7008         ranks of array types in case they dangling.
7009         (f_type_print_base): Add print_rank parameter.
7010
7011 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7012
7013         * NEWS: Mention new MI commands.
7014         * break-catch-throw.c (enum exception_event_kind): Move to
7015         breakpoint.h.
7016         (print_mention_exception_catchpoint): Output text as a single
7017         message.
7018         (catch_exception_command_1): Rename to...
7019         (catch_exception_event): ...this, make non-static, update header
7020         command, and change some parameter types.
7021         (catch_catch_command): Update for changes to
7022         catch_exception_command_1.
7023         (catch_throw_command): Likewise.
7024         (catch_rethrow_command): Likewise.
7025         * breakpoint.c (enum exception_event_kind): Delete.
7026         * breakpoint.h (enum exception_event_kind): Moved here from
7027         break-catch-throw.c.
7028         (catch_exception_event): Declare.
7029         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7030         (mi_cmd_catch_throw): New function.
7031         (mi_cmd_catch_rethrow): New function.
7032         (mi_cmd_catch_catch): New function.
7033         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7034         'catch-catch' entries.
7035         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7036         (mi_cmd_catch_rethrow): Declare.
7037         (mi_cmd_catch_catch): Declare.
7038
7039 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7040
7041         * annotate.c (annotate_source_line): Change return type to void,
7042         update implementation to match.
7043         * annotate.h (annotate_source_line): Change return type to void,
7044         update header comment.
7045         * stack.c (print_frame_info): Don't change what frame information
7046         is printed based on whether annotations are on or not.
7047
7048 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7049
7050         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7051         (annotate_source): Make static.
7052         (annotate_source_line): Moved from source.c and renamed from
7053         identify_source_line.  Update the return type.
7054         * annotate.h (annotate_source): Delete declaration.
7055         (annotate_source_line): Declaration moved from source.h, and
7056         renamed from identify_source_line.  Return type updated.
7057         * source.c (identify_source_line): Moved to annotate.c and renamed
7058         to annotate_source_line.
7059         (info_line_command): Remove check of annotation_level.
7060         * source.h (identify_source_line): Move declaration to annotate.h
7061         and rename to annotate_source_line.
7062         * stack.c: Add 'annotate.h' include.
7063         (print_frame_info): Remove check of annotation_level before
7064         calling annotate_source_line.
7065
7066 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7067
7068         * source-cache.c (source_cache::get_plain_source_lines): Use
7069         open_source_file_with_line_charpos instead of just
7070         open_source_file, remove call to find_source_lines.
7071         (source_cache::get_source_lines): Likewise.
7072         * source.c (find_source_lines): Make static.
7073         (get_filename_and_charpos): Renamed into...
7074         (open_source_file_with_line_charpos): ..this along with changes to
7075         return a scoped_fd, and some other minor clean ups.
7076         (identify_source_line): Use open_source_file_with_line_charpos.
7077         (search_command_helper): Use open_source_file_with_line_charpos
7078         instead of just open_source_file, remove call to
7079         find_source_lines.
7080         * source.h (open_source_file_with_line_charpos): Declare new
7081         function.
7082         (find_source_lines): Delete declaration.
7083
7084 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7085
7086         * source.c (get_filename_and_charpos): Remove fullname
7087         parameter.
7088         (identify_source_line): Update call to get_filename_and_charpos.
7089
7090 2019-06-14  Tom Tromey  <tromey@adacore.com>
7091
7092         PR gdb/24502:
7093         * ui-style.h (skip_ansi_escape): Update comment.
7094         * ui-file.h (class no_terminal_escape_file): New class.
7095         * ui-file.c (no_terminal_escape_file::write)
7096         (no_terminal_escape_file::puts): New methods.
7097         * cli/cli-logging.c (handle_redirections): Use
7098         no_terminal_escape_file.
7099
7100 2019-06-14  Tom Tromey  <tromey@adacore.com>
7101
7102         * NEWS: Move convenience variable news above Python news.
7103
7104 2019-06-14  Tom Tromey  <tom@tromey.com>
7105
7106         * gnulib: Move directory to top-level.
7107         * configure.ac: Don't configure gnulib.
7108         * configure: Rebuild.
7109         * common/common-defs.h: Use new path to gnulib.
7110         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7111         (GNULIB_H): Remove.
7112         (INCGNU): Look in new gnulib location.
7113         (HFILES_NO_SRCDIR): Remove gnulib files.
7114         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7115         (generated_files): Remove GNULIB_H.
7116         ($(LIBGNU), all-lib): Remove targets.
7117         (distclean): Don't mention GNULIB_BUILDDIR.
7118         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7119
7120 2019-06-14  Tom Tromey  <tromey@adacore.com>
7121
7122         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7123         Warn if symbol file does not provide any symbols.
7124
7125 2019-06-14  Tom Tromey  <tromey@adacore.com>
7126
7127         * source.c (find_and_open_source): Respect basenames_may_differ.
7128
7129 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7130
7131         * annotate.c (annotate_breakpoints_invalid): Make use of
7132         scoped_restore_terminal_state.
7133         (annotate_frames_invalid): Likewise.
7134
7135 2019-06-14  Tom Tromey  <tromey@adacore.com>
7136
7137         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7138         allow assignment to an internalvar.
7139
7140 2019-06-14  Tom Tromey  <tromey@adacore.com>
7141
7142         * ada-lex.l: Allow "_" in attribute names.
7143
7144 2019-06-14  Tom Tromey  <tromey@adacore.com>
7145
7146         PR gdb/24653:
7147         * regcache.c (registers_changed): Don't call alloca.
7148         * top.c (execute_command): Don't call alloca.
7149
7150 2019-06-13  Pedro Alves  <palves@redhat.com>
7151
7152         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7153         'expression'.  When parsing an expression, error out if there's
7154         junk after "unlimited".
7155         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7156         (do_set_command): Adjust calls to is_unlimited_literal.
7157
7158 2019-06-13  Pedro Alves  <palves@redhat.com>
7159
7160         * compile/compile.c (make_compile_options_def_group): Add braces
7161         around array_view initializer.
7162         * thread.c (make_thread_apply_all_options_def_group)
7163         (make_thread_apply_all_options_def_group): Likewise.
7164
7165 2019-06-13  Pedro Alves  <palves@redhat.com>
7166
7167         * NEWS (New commands): Mention "maint test-options
7168         require-delimiter", "maint test-options unknown-is-error", "maint
7169         test-options unknown-is-operand" and "maint show
7170         test-options-completion-result".
7171         (New command options, command completion): New section.
7172         (Completion improvements): New section.
7173         Mention that you can abbreviate "unlimited".
7174
7175 2019-06-13  Pedro Alves  <palves@redhat.com>
7176
7177         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7178         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7179         * unittests/cli-utils-selftests.c (test_parse_flags)
7180         (test_parse_flags_qcs): Delete.
7181         (test_cli_utils): Don't call deleted functions.
7182
7183 2019-06-13  Pedro Alves  <palves@redhat.com>
7184
7185         * thread.c: Include "cli/cli-option.h".
7186         (tp_array_compar_ascending): Global.
7187         (tp_array_compar): Delete function.
7188         (tp_array_compar_ascending, tp_array_compar_descending): New
7189         functions.
7190         (ascending_option_def, qcs_flag_option_def)
7191         (thr_qcs_flags_option_defs)
7192         (make_thread_apply_all_options_def_group)
7193         (make_thread_apply_options_def_group): New.
7194         (thread_apply_all_command): Use gdb::option::process_options.
7195         (thread_apply_command_completer)
7196         (thread_apply_all_command_completer): New.
7197         (thread_apply_command): Use gdb::option::process_options.
7198         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7199         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7200         to generate help text of "thread apply".  Adjust "taas"'s help.
7201         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7202         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7203
7204 2019-06-13  Pedro Alves  <palves@redhat.com>
7205
7206         * thread.c (thread_apply_command): Check for invalid TID with
7207         isdigit instead of !isalpha.
7208
7209 2019-06-13  Pedro Alves  <palves@redhat.com>
7210
7211         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7212         (validate_flags_qcs): New.
7213         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7214         (validate_flags_qcs): Declare.
7215         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7216         (make_frame_apply_options_def_group): New.
7217         (frame_apply_command_count): Process options with
7218         gdb::option::process_options.
7219         (frame_apply_completer): New.
7220         (frame_apply_level_completer, frame_apply_all_completer)
7221         (frame_apply_completer): New.
7222         (_initialize_stack): Update help of "frame apply", "frame apply
7223         level", "frame apply all" and "faas" to mention supported options
7224         and install command completers.
7225         * stack.h (frame_apply_all_completer): Declare.
7226         * thread.c: Include "stack.h".
7227         (tfaas_command): Add "--".
7228         (_initialize_thread): Update help "tfaas" to mention supported
7229         options and install command completer.
7230
7231 2019-06-13  Pedro Alves  <palves@redhat.com>
7232
7233         * completer.c (complete_nested_command_line): New.
7234         (gdb_completion_word_break_characters_throw): Add assertion.
7235         * completer.h (complete_nested_command_line): Declare.
7236
7237 2019-06-13  Pedro Alves  <palves@redhat.com>
7238
7239         * stack.c (parse_backtrace_qualifiers): New.
7240         (backtrace_command): Use it.
7241         (backtrace_command_completer): Complete on qualifiers.
7242
7243 2019-06-13  Pedro Alves  <palves@redhat.com>
7244
7245         * frame.c: Include "cli/cli-option.h.
7246         (user_set_backtrace_options): New.
7247         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7248         Delete.
7249         (get_prev_frame): Adjust.
7250         (boolean_option_def, uinteger_option_def)
7251         (set_backtrace_option_defs): New.
7252         (_initialize_frame): Adjust and use
7253         gdb::option::add_setshow_cmds_for_options to install "set
7254         backtrace past-main" and "set backtrace past-entry".
7255         * frame.h: Include "cli/cli-option.h".
7256         (struct frame_print_options): Forward declare.
7257         (print_frame_arguments_all, print_frame_arguments_scalars)
7258         (print_frame_arguments_none): Declare.
7259         (print_entry_values): Delete declaration.
7260         (struct frame_print_options, user_frame_print_options): New.
7261         (struct set_backtrace_options): New.
7262         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7263         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7264         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7265         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7266         (list_args_or_locals): Add frame_print_options parameter.
7267         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7268         * python/py-framefilter.c (enumerate_args): Pass down
7269         USER_FRAME_PRINT_OPTIONS.
7270         * stack.c: Include "cli/cli-option.h".
7271         (print_frame_arguments_all, print_frame_arguments_scalars)
7272         (print_frame_arguments_none): Declare.
7273         (print_raw_frame_arguments, print_entry_values): Delete.
7274         (user_frame_print_options): New.
7275         (boolean_option_def, enum_option_def, frame_print_option_defs):
7276         New.
7277         (struct backtrace_cmd_options): New.
7278         (bt_flag_option_def): New.
7279         (backtrace_command_option_defs): New.
7280         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7281         (print_frame_arg, read_frame_arg, print_frame_args)
7282         (print_frame_info, print_frame): Add frame_print_options parameter
7283         and use it.
7284         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7285         (backtrace_command_1): Add frame_print_options and
7286         backtrace_cmd_options parameters and use them.
7287         (make_backtrace_options_def_group): New.
7288         (backtrace_command): Process command options with
7289         gdb::option::process_options.
7290         (backtrace_command_completer): New.
7291         (_initialize_stack): Extend "backtrace"'s help to mention
7292         supported options.  Install completer for "backtrace".
7293         Install some settings commands with add_setshow_cmds_for_options.
7294
7295 2019-06-13  Pedro Alves  <palves@redhat.com>
7296
7297         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7298         and that "set/show print raw frame-arguments" are now deprecated.
7299
7300         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7301         command.
7302         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7303         * stack.c (_initialize_stack): Install "set/show print
7304         raw-frame-arguments", and deprecate "set/show print raw
7305         frame-arguments".
7306         * valprint.c (_initialize_valprint): Deprecate "set/show print
7307         raw".
7308
7309 2019-06-13  Pedro Alves  <palves@redhat.com>
7310
7311         * compile/compile.c (struct compile_options): New.
7312         (compile_flag_option_def, compile_command_option_defs)
7313         (make_compile_options_def_group): New.
7314         (compile_file_command): Handle options with
7315         gdb::option::process_options.
7316         (compile_file_command_completer): New function.
7317         (compile_code_command): Handle options with
7318         gdb::option::process_options.
7319         (compile_code_command_completer): New function.
7320         (_initialize_compiler): Install completers for "compile code" and
7321         "compile file".  Mention available options in "compile code" and
7322         "compile code"'s help.
7323         * completer.c (advance_to_completion_word): New, factored out from
7324         ...
7325         (advance_to_expression_complete_word_point): ... this.
7326         (advance_to_filename_complete_word_point): New.
7327         * completer.h (advance_to_filename_complete_word_point): New
7328         declaration.
7329
7330 2019-06-13  Pedro Alves  <palves@redhat.com>
7331
7332         * compile/compile.c: Include "cli/cli-option.h".
7333         (compile_print_value): Scope data pointer is now a
7334         value_print_options pointer; adjust.
7335         (compile_print_command): Process options.  Scope data pointer is
7336         now a value_print_options pointer; adjust.
7337         (_initialize_compile): Update "compile print"'s help to include
7338         supported options.  Install a completer for "compile print".
7339         * cp-valprint.c (show_vtblprint, show_objectprint)
7340         (show_static_field_print): Delete.
7341         (_initialize_cp_valprint): Don't install "set print
7342         static-members", "set print vtbl", "set print object" here.
7343         * printcmd.c: Include "cli/cli-option.h" and
7344         "common/gdb_optional.h".
7345         (print_command_parse_format): Rework to fill in a
7346         value_print_options instead of a format_data.
7347         (print_value): Change parameter type from format_data pointer to
7348         value_print_options reference.  Adjust.
7349         (print_command_1): Process options.  Adjust to pass down a
7350         value_print_options.
7351         (print_command_completer): New.
7352         (_initialize_printcmd): Install print_command_completer as
7353         handle_brkchars completer for the "print" command.  Update
7354         "print"'s help to include supported options.
7355         * valprint.c: Include "cli/cli-option.h".
7356         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7357         here from cp-valprint.c.
7358         (boolean_option_def, uinteger_option_def)
7359         (value_print_option_defs, make_value_print_options_def_group):
7360         New.  Use gdb::option::add_setshow_cmds_for_options to install
7361         "set print elements", "set print null-stop", "set print repeats",
7362         "set print pretty", "set print union", "set print array", "set
7363         print address", "set print symbol", "set print array-indexes".
7364         * valprint.h: Include <string> and "cli/cli-option.h".
7365         (make_value_print_options_def_group): Declare.
7366         (print_value): Change parameter type from format_data pointer to
7367         value_print_options reference.
7368         (print_command_completer): Declare.
7369
7370 2019-06-13  Pedro Alves  <palves@redhat.com>
7371
7372         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7373         (COMMON_SFILES): Add maint-test-settings.c.
7374         * cli/cli-decode.c (boolean_enums): New global, factored out from
7375         ...
7376         (add_setshow_boolean_cmd): ... here.
7377         * cli/cli-decode.h (boolean_enums): Declare.
7378         * cli/cli-option.c: New file.
7379         * cli/cli-option.h: New file.
7380         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7381         factored out from ...
7382         (parse_cli_boolean_value(const char *)): ... this.
7383         (is_unlimited_literal): Change parameter type to pointer to
7384         pointer.  Adjust and advance ARG pointer.
7385         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7386         (parse_cli_var_enum): New, factored out from ...
7387         (do_set_command): ... this.  Adjust.
7388         * cli/cli-setshow.h (parse_cli_boolean_value)
7389         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7390         (parse_cli_var_enum): Declare.
7391         * cli/cli-utils.c: Include "cli/cli-option.h".
7392         (get_ulongest): New.
7393         * cli/cli-utils.h (get_ulongest): Declare.
7394         (check_for_argument): New overloads.
7395         * maint-test-options.c: New file.
7396
7397 2019-06-13  Pedro Alves  <palves@redhat.com>
7398
7399         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7400         parse a range if "-" is at the end of the string.
7401
7402 2019-06-13  Pedro Alves  <palves@redhat.com>
7403
7404         * cli/cli-setshow.c (parse_auto_binary_operation)
7405         (parse_cli_boolean_value): Don't allow "o".
7406
7407 2019-06-13  Pedro Alves  <palves@redhat.com>
7408
7409         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7410         * NEWS: Mention maint test-settings KIND.
7411         * maint-test-settings.c: New file.
7412
7413 2019-06-13  Pedro Alves  <palves@redhat.com>
7414
7415         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7416         completer.
7417         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7418         "set" completers.
7419
7420 2019-06-13  Pedro Alves  <palves@redhat.com>
7421
7422         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7423         after item.
7424
7425 2019-06-13  Pedro Alves  <palves@redhat.com>
7426
7427         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7428
7429 2019-06-13  Pedro Alves <palves@redhat.com>
7430
7431         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7432         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7433         call.
7434         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7435         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7436         calls.
7437         (check_for_argument): Skip spaces after argument.
7438
7439 2019-06-13  Pedro Alves  <palves@redhat.com>
7440
7441         * thread.c (thread_apply_command): Adjust TID parsing.
7442         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7443         detected before end of string.
7444         (tid_is_in_list): Error out if LIST is invalid.
7445
7446 2019-06-13  Pedro Alves  <palves@redhat.com>
7447
7448         * completer.c (complete_line_internal_1): Rewind completion word
7449         point.
7450         (completion_tracker::advance_custom_word_point_by): Change
7451         parameter type to int.
7452         * completer.h (completion_tracker::advance_custom_word_point_by):
7453         Likewise.
7454
7455 2019-06-13  Pedro Alves  <palves@redhat.com>
7456
7457         * completer.c (advance_to_completion_word): Handle delimiters.
7458
7459 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7460
7461         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7462
7463 2019-06-11  Tom Tromey  <tom@tromey.com>
7464
7465         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7466         (xmalloc_failed): Move to alloc.c.
7467         * alloc.c: New file.
7468         * Makefile.in (COMMON_SFILES): Add alloc.c.
7469
7470 2019-06-11  Tom Tromey  <tom@tromey.com>
7471
7472         * nat/linux-waitpid.c: Don't include server.h.
7473         (linux_debug): Remove.
7474         (my_waitpid): Update.
7475
7476 2019-06-11  Tom Tromey  <tromey@adacore.com>
7477
7478         * infcall.c (_initialize_infcall): Remove trailing newline from
7479         help.
7480         * user-regs.c (_initialize_user_regs): Remove trailing newline
7481         from help.
7482         * typeprint.c (_initialize_typeprint): Remove trailing newline
7483         from help.
7484         * reverse.c (_initialize_reverse): Remove trailing newlines from
7485         help.
7486         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7487         from help.
7488         * language.c (add_set_language_command): Remove trailing newline
7489         from help.
7490         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7491         help.
7492         * disasm.c (_initialize_disasm): Remove trailing newline from
7493         help.
7494         * top.c (init_main): Remove trailing newline from help.
7495         * interps.c (_initialize_interpreter): Remove trailing newline
7496         from help.
7497         * btrace.c (_initialize_btrace): Remove trailing newlines from
7498         help.
7499         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7500         from help.
7501         * python/python.c (_initialize_python): Remove trailing newline
7502         from help.
7503         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7504         help.
7505         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7506         from help.  Reformat some text.
7507         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7508         from help.
7509         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7510         newline from help.
7511
7512 2019-06-11  Tom Tromey  <tromey@adacore.com>
7513
7514         * darwin-nat.c (darwin_decode_exception_message)
7515         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7516
7517 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7518
7519         * valops.c (value_slice): Check for not allocated or not
7520         associated values.
7521
7522 2019-06-10  Tom de Vries  <tdevries@suse.de>
7523
7524         PR gdb/24618
7525         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7526         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7527         invalid.
7528
7529 2019-06-10  Tom de Vries  <tdevries@suse.de>
7530
7531         PR gdb/24611
7532         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7533         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7534
7535 2019-06-10  Tom de Vries  <tdevries@suse.de>
7536
7537         PR symtab/24545
7538         * symtab.c (struct demangled_name_entry): Add language field.
7539         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7540         static minimal symbol".  Set and use language field.
7541
7542 2019-06-10  Tom Tromey  <tromey@adacore.com>
7543
7544         * ada-lang.c (_initialize_ada_language): Update help text.
7545
7546 2019-06-10  Tom Tromey  <tromey@adacore.com>
7547
7548         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7549         with a newline.
7550         * guile/guile.c (handle_boot_error): Don't end warning with a
7551         newline.
7552         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7553         warning with a newline.
7554         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7555         newline.
7556         (s12z_frame_cache): Likewise.
7557         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7558         a newline.
7559         * solib-svr4.c (disable_probes_interface): Don't end warning with
7560         a newline.
7561         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7562         newline.
7563         * python/python.c (do_finish_initialization): Don't end warning
7564         with a newline.
7565
7566 2019-06-10  Tom Tromey  <tom@tromey.com>
7567
7568         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7569         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7570         gdbpy_enter.
7571
7572 2019-06-10  Tom Tromey  <tromey@adacore.com>
7573
7574         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7575         data.
7576         (elf_new_init): Don't call stabsread_new_init.
7577         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7578         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7579         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7580
7581 2019-06-10  Tom de Vries  <tdevries@suse.de>
7582
7583         PR symtab/16264
7584         PR symtab/24517
7585         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7586
7587 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7588
7589         * source.c (find_and_open_source): Also rewrite relative file
7590         names.
7591
7592 2019-04-26  Amos Bird  <amosbird@gmail.com>
7593
7594         * annotate.c (annotate_thread_exited): Add "thread-exited"
7595         annotation.
7596
7597 2019-06-06  Tom Tromey  <tromey@adacore.com>
7598
7599         * maint.h (class scoped_command_stats): Use
7600         DISABLE_COPY_AND_ASSIGN.
7601         <print_time>: New method.
7602         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7603         print_time.
7604         (scoped_command_stats::print_time): New method.
7605
7606 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7607
7608         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7609         instructions of lengths 6 or 8 bytes.
7610
7611 2019-06-04  Pedro Alves  <palves@redhat.com>
7612
7613         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7614
7615         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7616         * breakpoint.c (condition_completer): Likewise.
7617         * cli/cli-dump.c (scan_expression): Likewise.
7618         * common/filestuff.c (mkdir_recursive): Likewise.
7619         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7620         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7621         (gdb_abspath): Likewise.
7622         * compile/compile-cplus-types.c
7623         (compile_cplus_instance::decl_name): Likewise.
7624         * completer.c (complete_explicit_location):
7625         (signal_completer, reg_or_group_completer_1): Likewise.
7626         * cp-support.c (cp_remove_params_if_any): Likewise.
7627         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7628         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7629         * infcmd.c (strip_bg_char): Likewise.
7630         * linespec.c (copy_token_string): Likewise.
7631         * mi/mi-main.c (output_cores): Likewise.
7632         * psymtab.c (psymtab_search_name):
7633         * symfile.c (test_set_ext_lang_command): Likewise.
7634         * target.c (target_fileio_read_stralloc): Likewise.
7635         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7636         * value.c (complete_internalvar): Likewise.
7637
7638 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7639
7640         Add objfile property to gdb.Type.
7641         * NEWS: Mention Python API addition.
7642         * python/py-type.c (typy_get_objfile): New method.
7643
7644 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7645
7646         * NEWS: Mention the new set|show style [title|highlight].
7647         Mention changes to "show style", "help" and "apropos".
7648
7649 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7650
7651         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7652         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7653         instead of print_help_for_command.
7654         (print_doc_of_command): New function.
7655         (help_list): Add 'apropos -v word' suggestion.
7656         (print_help_for_command): Style the command name using title style.
7657         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7658         (_initialize_cli_cmds): Describe -v in apropos_command help.
7659
7660 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7661
7662         * cli/cli-style.h (cli_style_option): Add name in constructor,
7663         add m_name class member, add constructor with intensity,
7664         add name class function.
7665         (cli_style_option::add_setshow_commands): Remove name argument.
7666         (highlight_style, title_style): New styles.
7667         * cli/cli-style.c (do_show): New function that shows a style
7668         characteristic styling the style name with itself.
7669         (set_style_name): New function.
7670         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7671         Update all callers according to the changes in cli/cli-style.h.
7672         * utils.h (fputs_highlighted): New function.
7673         * utils.c (fputs_highlighted): Likewise.
7674
7675 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7676
7677         * NEWS: Mention new pipe command and new convenience variables.
7678
7679 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7680
7681         * cli/cli-cmds.c (pipe_command): New function.
7682         (_initialize_cli_cmds): Call add_com for pipe_command.
7683         Define | as an alias for pipe.
7684         (exit_status_set_internal_vars): New function.
7685         (shell_escape): Call exit_status_set_internal_vars.
7686         cli/cli-decode.c (find_command_name_length): Recognize | as
7687         a single character command.
7688
7689 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7690
7691         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7692         top.c (execute_command_to_ui_file): New function, mostly a copy
7693         of execute_command_to_string.
7694         (execute_command_to_string): Implement by calling
7695         execute_command_to_ui_file.
7696
7697 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7698
7699         * top.h (saved_command_line): Remove declaration.
7700         * top.c (previous_saved_command_line, previous_repeat_arguments):
7701         New variables.
7702         (saved_command_line): Make static, define together with other
7703         'repeat variables'.
7704         (dont_repeat): Clear repeat_arguments.
7705         (repeat_previous, get_saved_command_line, save_command_line):
7706         New functions.
7707         (gdb_init): Initialize saved_command_line
7708         and previous_saved_command_line.
7709         * main.c (captured_main_1): Remove saved_command_line initialization.
7710         * event-top.c (handle_line_of_input): Update to use
7711         the new 'repeat' related functions instead of direct access to
7712         saved_command_line.
7713         * command.h (repeat_previous, get_saved_command_line,
7714         save_command_line): New declarations.
7715         (dont_repeat): Add comment.
7716
7717 2019-05-30  Tom Tromey  <tromey@adacore.com>
7718
7719         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7720         Fix comment.
7721         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7722
7723 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7724
7725         PR cli/24587
7726         * completer.c (complete): Initialize variable word.
7727
7728 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7729
7730         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7731         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7732         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7733         'body' is NULL to the outter 'if', protecting the '!is_define'
7734         situation as well.
7735
7736 2019-05-29  Tom Tromey  <tromey@adacore.com>
7737
7738         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7739         (dwarf_unknown): New function.
7740         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7741         (dwarf_type_encoding_name): Use dwarf_unknown.
7742
7743 2019-05-29  Tom Tromey  <tromey@adacore.com>
7744
7745         PR c++/20020:
7746         * cp-valprint.c (cp_print_value_fields): Call
7747         cp_print_static_field inside "try".
7748
7749 2019-05-29  Tom Tromey  <tromey@adacore.com>
7750
7751         * inflow.c (struct terminal_info): Add default operator=.
7752         * configure: Rebuild.
7753         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7754         -Wdeprecated-copy-dtor, -Wredundant-move.
7755
7756 2019-05-29  Tom Tromey  <tromey@adacore.com>
7757
7758         * NEWS: Add entry.
7759         * infcmd.c (print_return_value_1): Handle finish_print
7760         option.
7761         (show_print_finish): New function.
7762         (_initialize_infcmd): Add "set/show print finish" commands.
7763         * valprint.c (user_print_options): Initialize new member.
7764         * valprint.h (struct value_print_options) <finish_print>: New
7765         member.
7766
7767 2019-05-28  Tom Tromey  <tromey@adacore.com>
7768
7769         * ada-lang.c (ada_remove_Xbn_suffix)
7770         (find_old_style_renaming_symbol)
7771         (parse_old_style_renaming): Remove.
7772         (ada_find_renaming_symbol): Don't call
7773         find_old_style_renaming_symbol.
7774         (ada_is_renaming_symbol): Rename from
7775         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7776         bool.  Now static.
7777         (ada_read_var_value): Update and simplify.
7778         * ada-exp.y (write_var_or_type): Remove old code.
7779
7780 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7781
7782         PR gdb/25010
7783         * event-top.c: Remove include comment.
7784         * inflow.c (class scoped_ignore_sigttou): Move from here...
7785         * inflow.h (class scoped_ignore_sigttou): ...to here.
7786         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7787         * top.c:  Remove include comment.
7788
7789 2019-05-27  Tom Tromey  <tom@tromey.com>
7790
7791         * NEWS: Fix typo.
7792
7793 2019-05-22  Tom Tromey  <tromey@adacore.com>
7794
7795         * target.c (target_follow_exec): Constify parameter.
7796         * target-delegates.c: Rebuild.
7797         * remote.c (remote_target::follow_exec): Constify parameter.
7798         * infrun.c (follow_exec): Constify parameter.
7799         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7800         (target_follow_exec): Likewise.
7801
7802 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7803
7804         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7805         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7806
7807 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7808
7809         * NEWS: Add debugredirect and testsuite sections.
7810
7811 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7812
7813         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7814         target descriptions using exclusively floating point register name
7815         aliases.
7816
7817 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7818
7819         PR gdb/18644:
7820         * f-lang.c (build_fortran_types): Handle the case where
7821         gdbarch_floatformat_for_type returns a nullptr.
7822
7823 2019-05-21  Tom de Vries  <tdevries@suse.de>
7824
7825         PR cli/24587
7826         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7827
7828 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7829
7830         PR gdb/18644:
7831         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7832         16-byte floats.
7833         * i386-tdep.c (i386_floatformat_for_type): Use
7834         floatformats_ia64_quad for the 16-byte floating point component
7835         within a fortran 32-byte complex number.
7836
7837 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7840         delete default constructor.
7841         (find_partial_die): Update to return const struct.
7842         (partial_die_parent_scope): Move variable declaration into scope
7843         of its use and change its type to auto.
7844         (guess_partial_die_structure_name): Likewise.
7845         (partial_die_info::fixup): Likewise.
7846
7847 2019-05-17  Tom Tromey  <tromey@adacore.com>
7848
7849         * source.c (find_and_open_source): Remove cast.
7850
7851 2019-05-17  Tom Tromey  <tromey@adacore.com>
7852
7853         * annotate.c (annotate_source): Make "filename" const.
7854         * annotate.h (annotate_source): Use const.
7855
7856 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7857
7858         * disasm.c (set_disassembler_options): Send errors to stderr.
7859
7860 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7861
7862         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7863         (cli_interp_base::set_logging): Check debug_redirect.
7864         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7865         * cli/cli-logging.c (debug_redirect): Add static variable.
7866         (pop_output_files): Add default param.
7867         (handle_redirections): Print debug setting.
7868         (show_logging_command): Likewise.
7869         (_initialize_cli_logging): Add debugredirect command.
7870         * interps.c (current_interp_set_logging): Add debug_redirect
7871         parameter.
7872         * interps.h (set_logging): Add debug_redirect parameter.
7873         (current_interp_set_logging): Likewise.
7874         * mi/mi-common.h: Likewise.
7875         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7876
7877 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7878             Tom Tromey  <tromey@adacore.com>
7879
7880         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7881         directly.
7882         * cli/cli-interp.h (make_logging_output): Remove declaration.
7883         * cli/cli-logging.c (make_logging_output): Remove function.
7884         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7885         directly.
7886         * ui-file.c (tee_file::tee_file): Remove bools.
7887         (tee_file::~tee_file): Remove deletes.
7888         * ui-file.h (tee_file): Remove bools.
7889
7890 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7891
7892         * mi/mi-cmds.h (mi_cmd_complete): New function.
7893         * mi/mi-main.c (mi_cmd_complete): Likewise.
7894         * mi/mi-cmds.c: Define new MI command -complete.
7895         * NEWS: Mention new -complete command.
7896
7897 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7898
7899         * completer.h (complete): New function.
7900         * completer.c (complete): Likewise.
7901         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7902         function defined in completer.h.
7903
7904 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7905
7906         * MAINTAINERS (Write After Approval): Add myself.
7907
7908 2019-05-17  Tom de Vries  <tdevries@suse.de>
7909
7910         PR gdb/24094
7911         * dwarf2read.c (struct cu_partial_die_info): New struct.
7912         (find_partial_die): Return cu_partial_die_info.
7913         (partial_die_parent_scope, guess_partial_die_structure_name)
7914         (partial_die_info::fixup): Handle new return type of find_partial_die.
7915
7916 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7917
7918         PR breakpoints/24541
7919         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7920         "std::string", simplifying the algorithm.
7921
7922 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7923
7924         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7925         (stap_static_probe_ops::get_probes): Likewise.
7926
7927 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7928
7929         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7930         '-')" and "else if".
7931         (stap_parse_single_operand): Join checks for
7932         "gdbarch_stap_parse_special_token_p" and
7933         "gdbarch_stap_parse_special_token" in the same "if" statement.
7934         Invert check when verifying for operation on register
7935         displacement.
7936
7937 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7938
7939         * stap-probe.c (stap_get_opcode): Update comment.
7940         (stap_get_expected_argument_type): Likewise.
7941         (handle_stap_probe): Likewise.
7942
7943 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7944
7945         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7946         return type to 'bool'.  Adjust comment.  Use 'bool' when
7947         appropriate.
7948         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7949         * stap-probe.c (stap_parse_argument_1): Likewise.
7950         (stap_is_operator): Likewise.
7951         (stap_is_generic_prefix): Likewise.
7952         (stap_is_register_prefix): Likewise.
7953         (stap_is_register_indirection_prefix): Likewise.
7954         (stap_is_integer_prefix): Likewise.
7955         (stap_generic_check_suffix): Likewise.
7956         (stap_check_integer_suffix): Likewise.
7957         (stap_check_register_suffix): Likewise.
7958         (stap_check_register_indirection_suffix): Likewise.
7959         (stap_parse_register_operand): Likewise.
7960         (stap_parse_single_operand): Likewise.
7961         (stap_parse_argument_1): Likewise.
7962         (stap_probe::get_argument_count): Likewise.
7963         (stap_is_operator): Likewise.
7964
7965 2019-05-16  Tom Tromey  <tromey@adacore.com>
7966
7967         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7968         keyword to foreach.
7969
7970 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7971
7972         * linux-thread-db.c (try_thread_db_load_1): Change return type
7973         to bool.
7974         (try_thread_db_load): Likewise.
7975         (try_thread_db_load_from_pdir_1): Likewise.
7976         (try_thread_db_load_from_pdir): Likewise.
7977         (try_thread_db_load_from_sdir): Likewise.
7978         (try_thread_db_load_from_dir): Likewise.
7979         (thread_db_load_search): Likewise.
7980         (has_libpthread): Likewise.
7981         (thread_db_load): Likewise.
7982
7983 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7984
7985         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7986         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7987         NULL, and complain/return if that's the case.
7988
7989 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7990
7991         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7992         (advance, posn, abstract_read_memory): New functions.
7993         [struct mem_read_abstraction]: New struct.
7994         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7995
7996 2019-05-14  Tom Tromey  <tromey@adacore.com>
7997
7998         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7999         value is not lval_memory.
8000
8001 2019-05-14  Tom Tromey  <tromey@adacore.com>
8002
8003         * solib.c (info_sharedlibrary_command): Style the file name.
8004
8005 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8006
8007         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8008         (aarch64_vnv_type): Likewise.
8009         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8010         * common/tdesc.c: Likewise.
8011         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8012         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8013         * features/aarch64-fpu.xml: Add ieee half view.
8014         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8015         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8016         * gdbtypes.h (struct builtin_type): Likewise.
8017         (struct objfile_type): Likewise.
8018
8019 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8020
8021         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8022         typo.
8023         * location.h (string_to_event_location): Likewise.
8024
8025 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8026
8027         GDB 8.3 released.
8028
8029 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8030
8031         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8032         New variable declaration.
8033         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8034         New variable.
8035         (print_one_breakpoint): Use ui_out::test_flags and new global
8036         variable to compute use_fixed_output.
8037         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8038         Remove.
8039         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8040         (mi_multi_location_breakpoint_output_fixed): Remove.
8041         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8042         new variable.
8043         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8044         fix_multi_location_breakpoint_output flag if version >= 3.
8045         * ui-out.h (enum ui_out_flag)
8046         <fix_multi_location_breakpoint_output>: New enumerator.
8047
8048 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8049
8050         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8051
8052 2019-05-10  Tom Tromey  <tromey@adacore.com>
8053
8054         * ada-lang.c (catch_ada_completer): New function.
8055         (_initialize_ada_language): Use it.
8056
8057 2019-05-10  Tom Tromey  <tromey@adacore.com>
8058
8059         * thread.c (print_thread_info): Make "requested_threads" const.
8060         * gdbthread.h (print_thread_info): Make "requested_threads"
8061         const.
8062         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8063         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8064
8065 2019-05-08  Tom Tromey  <tom@tromey.com>
8066
8067         * gdbtypes.c (objfile_type_data): Change type.
8068         (objfile_type, _initialize_gdbtypes): Update.
8069
8070 2019-05-08  Tom Tromey  <tom@tromey.com>
8071
8072         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8073         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8074         (_initialize_dwarf2_frame): Update.
8075
8076 2019-05-08  Tom Tromey  <tom@tromey.com>
8077
8078         * objc-lang.c (objc_objfile_data): Change type.
8079         (find_methods): Update.
8080         (_initialize_objc_lang): Remove.
8081
8082 2019-05-08  Tom Tromey  <tom@tromey.com>
8083
8084         * stabsread.c (rs6000_builtin_type_data): Change type.
8085         (rs6000_builtin_type, _initialize_stabsread): Update.
8086
8087 2019-05-08  Tom Tromey  <tom@tromey.com>
8088
8089         * mips-tdep.c (mips_pdr_data): Remove.
8090         (_initialize_mips_tdep): Update.
8091
8092 2019-05-08  Tom Tromey  <tom@tromey.com>
8093
8094         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8095         (hppa_init_objfile_priv_data, read_unwind_info)
8096         (find_unwind_entry, _initialize_hppa_tdep): Update.
8097
8098 2019-05-08  Tom Tromey  <tom@tromey.com>
8099
8100         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8101         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8102         on obstack.
8103         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8104
8105 2019-05-08  Tom Tromey  <tom@tromey.com>
8106
8107         * mdebugread.c (basic_type_data): Change type.
8108         (basic_type, _initialize_mdebugread): Update.
8109
8110 2019-05-08  Tom Tromey  <tom@tromey.com>
8111
8112         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8113
8114 2019-05-08  Tom Tromey  <tom@tromey.com>
8115
8116         * nto-tdep.c (nto_inferior_data_reg): Change type.
8117         (nto_inferior_data): Update.
8118         (nto_inferior_data_cleanup, nto_new_inferior_data)
8119         (_initialize_nto_tdep): Remove.
8120         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8121
8122 2019-05-08  Tom Tromey  <tom@tromey.com>
8123
8124         * ada-lang.c (struct ada_inferior_data): Add initializers.
8125         (ada_inferior_data): Change type.
8126         (ada_inferior_data_cleanup): Remove.
8127         (get_ada_inferior_data, ada_inferior_exit)
8128         (struct ada_pspace_data): Add initializers, destructor.
8129         (ada_pspace_data_handle): Change type.
8130         (get_ada_pspace_data): Update.
8131         (ada_pspace_data_cleanup): Remove.
8132
8133 2019-05-08  Tom Tromey  <tom@tromey.com>
8134
8135         * coffread.c (struct coff_symfile_info): Add initializers.
8136         (coff_objfile_data_key): Move lower.  Change type.
8137         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8138         Update.
8139         (coff_free_info): Remove.
8140
8141 2019-05-08  Tom Tromey  <tom@tromey.com>
8142
8143         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8144         (fbsd_pspace_data_handle): Move lower.  Change type.
8145         (get_fbsd_pspace_data): Update.
8146         (fbsd_pspace_data_cleanup): Remove.
8147         (_initialize_fbsd_tdep): Update.
8148
8149 2019-05-08  Tom Tromey  <tom@tromey.com>
8150
8151         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8152         (get_ada_tasks_pspace_data): Update.
8153         (ada_tasks_pspace_data_cleanup): Remove.
8154         (_initialize_tasks): Update.
8155         (ada_tasks_inferior_data_handle): Change type.
8156         (get_ada_tasks_inferior_data): Update.
8157         (ada_tasks_inferior_data_cleanup): Remove.
8158         (struct ada_tasks_pspace_data): Add initializers.
8159
8160 2019-05-08  Tom Tromey  <tom@tromey.com>
8161
8162         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8163         * symfile-debug.c (debug_sym_get_probes): Change type.
8164         * stap-probe.c (handle_stap_probe):
8165         (stap_static_probe_ops::get_probes): Change type.
8166         * probe.h (class static_probe_ops) <get_probes>: Change type.
8167         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8168         (parse_probes_in_pspace): Update.
8169         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8170         Update.
8171         (any_static_probe_ops::get_probes): Change type.
8172         * elfread.c (elfread_data): New typedef.
8173         (probe_key): Change type.
8174         (elf_get_probes): Likewise.  Update.
8175         (probe_key_free): Remove.
8176         (_initialize_elfread): Update.
8177         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8178         Change type.
8179         (dtrace_process_dof_probe, dtrace_process_dof)
8180         (dtrace_static_probe_ops::get_probe): Change type.
8181
8182 2019-05-08  Tom Tromey  <tom@tromey.com>
8183
8184         * xcoffread.c (struct xcoff_symfile_info): Rename from
8185         coff_symfile_info.  Add initializers.
8186         (xcoff_objfile_data_key): Move lower.  Change type.
8187         (XCOFF_DATA): Rewrite.
8188         (xcoff_free_info): Remove.
8189         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8190         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8191         (xcoff_initial_scan): Update.
8192
8193 2019-05-08  Tom Tromey  <tom@tromey.com>
8194
8195         * solib-svr4.c (struct svr4_info): Add initializers and
8196         destructor.
8197         <probes_table>: Now an htab_up.
8198         (solib_svr4_pspace_data): Change type.
8199         (free_probes_table): Simplify.
8200         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8201         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8202         (probes_table_remove_objfile_probes, register_solib_event_probe)
8203         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8204         (_initialize_svr4_solib): Update.
8205
8206 2019-05-08  Tom Tromey  <tom@tromey.com>
8207
8208         * remote.c (remote_pspace_data): Change type.
8209         (remote_pspace_data_cleanup): Remove.
8210         (get_remote_exec_file, set_pspace_remote_exec_file)
8211         (_initialize_remote): Update.
8212
8213 2019-05-08  Tom Tromey  <tom@tromey.com>
8214
8215         * breakpoint.c (breakpoint_objfile_key): Change type.
8216         (get_breakpoint_objfile_data): Update.
8217         (free_breakpoint_objfile_data): Remove.
8218         (_initialize_breakpoint): Update.
8219
8220 2019-05-08  Tom Tromey  <tom@tromey.com>
8221
8222         * linux-tdep.c (struct linux_info): Add initializers.
8223         (linux_inferior_data): Move.  Change type.
8224         (invalidate_linux_cache_inf): Update.
8225         (linux_inferior_data_cleanup): Remove.
8226         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8227
8228 2019-05-08  Tom Tromey  <tom@tromey.com>
8229
8230         * auxv.c (auxv_inferior_data): Move.  Change type.
8231         (auxv_inferior_data_cleanup): Remove.
8232         (invalidate_auxv_cache_inf): Rewrite.
8233         (get_auxv_inferior_data, _initialize_auxv): Update.
8234
8235 2019-05-08  Tom Tromey  <tom@tromey.com>
8236
8237         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8238         (symfile_debug_objfile_data_key): Change type.
8239         (symfile_debug_installed, debug_qf_has_symbols)
8240         (debug_qf_find_last_source_symtab)
8241         (debug_qf_forget_cached_source_info)
8242         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8243         (debug_qf_print_stats, debug_qf_dump)
8244         (debug_qf_expand_symtabs_for_function)
8245         (debug_qf_expand_all_symtabs)
8246         (debug_qf_expand_symtabs_with_fullname)
8247         (debug_qf_map_matching_symbols)
8248         (debug_qf_expand_symtabs_matching)
8249         (debug_qf_find_pc_sect_compunit_symtab)
8250         (debug_qf_map_symbol_filenames)
8251         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8252         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8253         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8254         (debug_sym_read_linetable, debug_sym_relocate): Update.
8255         (symfile_debug_free_objfile): Remove.
8256         (install_symfile_debug_logging, _initialize_symfile_debug):
8257         Update.
8258
8259 2019-05-08  Tom Tromey  <tom@tromey.com>
8260
8261         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8262         allocate_on_obstack.
8263         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8264         (get_dwarf2_per_objfile): Update.
8265         (set_dwarf2_per_objfile): Remove.
8266         (dwarf2_has_info, dwarf2_get_section_info): Update.
8267         (dwarf2_free_objfile): Remove.
8268         (_initialize_dwarf2_read): Update.
8269
8270 2019-05-08  Tom Tromey  <tom@tromey.com>
8271
8272         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8273         initializers.
8274         <unsupported_script_warning_printed,
8275         script_not_found_warning_printed>: Now bool.
8276         (auto_load_pspace_data): Change type.
8277         (~auto_load_pspace_info): Rename from
8278         auto_load_pspace_data_cleanup.
8279         (get_auto_load_pspace_data, init_loaded_scripts_info)
8280         (clear_section_scripts, maybe_print_unsupported_script_warning)
8281         (maybe_print_script_not_found_warning, _initialize_auto_load):
8282         Update.
8283
8284 2019-05-08  Tom Tromey  <tom@tromey.com>
8285
8286         * objfiles.c (objfile_pspace_info): Add destructor and
8287         initializers.
8288         (objfiles_pspace_data): Change type.
8289         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8290         (get_objfile_pspace_data): Update.
8291         (objfiles_bfd_data): Change type.
8292         (get_objfile_bfd_data): Update.
8293         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8294
8295 2019-05-08  Tom Tromey  <tom@tromey.com>
8296
8297         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8298         Change type.
8299         (get_catch_syscall_inferior_data): Update.
8300         (catch_syscall_inferior_data_cleanup): Remove.
8301         (_initialize_break_catch_syscall): Update.
8302
8303 2019-05-08  Tom Tromey  <tom@tromey.com>
8304
8305         * inflow.c (struct terminal_info): Add destructor and
8306         initializers.
8307         (inflow_inferior_data): Change type.
8308         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8309         (get_inflow_inferior_data, inflow_inferior_exit)
8310         (swap_terminal_info, _initialize_inflow): Update.
8311
8312 2019-05-08  Tom Tromey  <tom@tromey.com>
8313
8314         * target-dcache.c (target_dcache_cleanup): Remove.
8315         (target_dcache_aspace_key): Change type.
8316         (target_dcache_init_p, target_dcache_invalidate)
8317         (target_dcache_get, target_dcache_get_or_init)
8318         (_initialize_target_dcache): Update.
8319         * dcache.h (struct dcache_deleter): New.
8320
8321 2019-05-08  Tom Tromey  <tom@tromey.com>
8322
8323         * symtab.c (struct symbol_cache): Add destructor and
8324         initializers.
8325         (symbol_cache_key): Move.  Change type.
8326         (make_symbol_cache, free_symbol_cache): Remove.
8327         (get_symbol_cache): Update.
8328         (symbol_cache_cleanup): Remove.
8329         (ALL_PSPACES, symbol_cache_flush)
8330         (maintenance_print_symbol_cache)
8331         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8332         Update.
8333
8334 2019-05-08  Tom Tromey  <tom@tromey.com>
8335
8336         * symtab.c (struct main_info): Add destructor and initializers.
8337         (main_progspace_key): Move.  Change type.
8338         (get_main_info): Update.
8339         (main_info_cleanup): Remove.
8340         (_initialize_symtab): Update.
8341
8342 2019-05-08  Tom Tromey  <tom@tromey.com>
8343
8344         * registry.h (DECLARE_REGISTRY): Define the _key class.
8345
8346 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8347
8348         * NEWS: Merge two 'New commands' sections.
8349
8350 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8351
8352         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8353         parameter and use Ada language definition instead.
8354         (ada_val_print_ptr): Remove unused language parameter.
8355         (ada_val_print_num): Remove language parameter and use Ada language
8356         definition instead.
8357         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8358         parameter.
8359         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8360         parameter and use Ada language definition instead.
8361         (ada_val_print_1): Update all ada_val_print_xxx calls.
8362         Remove language parameter.
8363         (ada_val_print): Update ada_val_print_1 call.
8364
8365 2019-05-08  Tom Tromey  <tromey@adacore.com>
8366
8367         * remote.c (remote_hw_watchpoint_limit)
8368         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8369         Now static.
8370
8371 2019-05-08  Tom Tromey  <tromey@adacore.com>
8372
8373         * maint.c (_initialize_maint_cmds): Move initialization code to
8374         remote.c.
8375         (watchdog, show_watchdog): Move to remote.c.
8376         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8377         "watchdog" static.
8378         (_initialize_remote): Move initialization code from maint.c.
8379         * defs.h (watchdog): Don't declare.
8380
8381 2019-05-08  Tom Tromey  <tromey@adacore.com>
8382
8383         * tui/tui-interp.c: Include main.h.
8384         * interps.c: Include main.h.
8385         * main.h (interpreter_p): Declare.
8386         * defs.h (interpreter_p): Don't declare.
8387
8388 2019-05-08  Tom Tromey  <tromey@adacore.com>
8389
8390         * dwarf2loc.c: Include dwarf2read.h.
8391         * defs.h (read_unsigned_leb128): Don't declare.
8392         * dwarf2read.h (read_unsigned_leb128): Declare.
8393
8394 2019-05-08  Tom Tromey  <tromey@adacore.com>
8395
8396         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8397         method.
8398
8399 2019-05-08  Tom Tromey  <tromey@adacore.com>
8400
8401         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8402         when no wrap column is set.
8403
8404 2019-05-08  Tom Tromey  <tromey@adacore.com>
8405
8406         * c-lang.c (c_get_string): Handle non-C-style arrays.
8407
8408 2019-05-08  Tom Tromey  <tromey@adacore.com>
8409
8410         * typeprint.c (print_offset_data::update): Print the bit offset,
8411         not the number of bits remaining.
8412
8413 2019-05-08  Tom Tromey  <tromey@adacore.com>
8414
8415         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8416         padding at end of comment.
8417
8418 2019-05-08  Tom Tromey  <tromey@adacore.com>
8419
8420         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8421         Compare main types.
8422
8423 2019-05-06  Tom Tromey  <tom@tromey.com>
8424
8425         * common/scoped_mmap.c: Include common-defs.h.
8426         * common/scoped_mmap.h: Don't include config.h.
8427
8428 2019-05-04  Tom Tromey  <tom@tromey.com>
8429
8430         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8431         (struct aarch64_call_info): Add initializers.
8432         <si>: Now a std::vector.
8433         (pass_on_stack, aarch64_push_dummy_call): Update.
8434
8435 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8436             Tom Tromey  <tom@tromey.com>
8437
8438         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8439         (ppc_threads): Now a std::vector.  Now static.
8440         (hwdebug_find_thread_points_by_tid)
8441         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8442         Update.
8443
8444 2019-05-04  Tom Tromey  <tom@tromey.com>
8445
8446         * arc-tdep.c (arc_tdesc_init): Return bool.
8447
8448 2019-05-04  Tom Tromey  <tom@tromey.com>
8449
8450         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8451         Use gdb_assert_not_reached.
8452
8453 2019-05-04  Tom Tromey  <tom@tromey.com>
8454
8455         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8456         "false".
8457
8458 2019-05-04  Tom Tromey  <tom@tromey.com>
8459
8460         * arc-tdep.c (arc_tdesc_init): Use bool.
8461
8462 2019-05-04  Tom Tromey  <tom@tromey.com>
8463
8464         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8465
8466 2019-05-04  Tom Tromey  <tom@tromey.com>
8467
8468         * cli/cli-cmds.c (valid_command_p): Return bool.
8469
8470 2019-05-04  Tom Tromey  <tom@tromey.com>
8471
8472         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8473         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8474
8475 2019-05-04  Raul Tambre  <raul@tambre.ee>
8476
8477         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8478         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8479         operator for comparison.
8480
8481 2019-05-04  Tom Tromey  <tom@tromey.com>
8482
8483         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8484         (lookup_partial_symbol, print_partial_symbols)
8485         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8486         (psymbol_compare): Update.
8487         (add_psymbol_to_bcache): Clear the entire psymbol.
8488         (maintenance_check_psymtabs): Update.
8489         * psympriv.h (struct partial_symbol): Don't derive from
8490         general_symbol_info.
8491         <obj_section, unrelocated_address, address,
8492         set_unrelocated_address>: Update.
8493         <ginfo>: New member.
8494         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8495         (debug_names::write_psymbols): Update.
8496
8497 2019-05-04  Tom de Vries  <tdevries@suse.de>
8498
8499         * contrib/cc-with-tweaks.sh: Support -n arg.
8500
8501 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8502
8503         * corelow.c (core_target::detach): Ensure frame cache and
8504         register caches are cleared.
8505         inferior.c (exit_inferior_1): Likewise.
8506
8507 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8508             Tom Tromey  <tom@tromey.com>
8509
8510         * dictionary.c (collate_pending_symbols_by_language): Remove
8511         "struct" from foreach.
8512         * symtab.c (lookup_global_symbol_from_objfile)
8513         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8514         foreach.
8515         * ser-tcp.c (net_open): Remove "struct" from foreach.
8516         * objfiles.c (objfile_relocate, objfile_rebase)
8517         (objfile_has_symbols): Remove "struct" from foreach.
8518         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8519         from foreach.
8520         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8521         foreach.
8522         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8523         "struct" from foreach.
8524         * ada-lang.c (create_excep_cond_exprs)
8525         (ada_exception_catchpoint_cond_string): Remove "struct" from
8526         foreach.
8527
8528 2019-05-03  Tom Tromey  <tromey@adacore.com>
8529
8530         * ada-exp.y (convert_char_literal): Check suffix of each
8531         enumerator.
8532
8533 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8534
8535         PR ada/21406:
8536         * ada-exp.y (yywrap): Don't define.
8537         * ada-lex.l (%option): Add noyywrap
8538         (yywrap): Remove.
8539
8540 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8541
8542         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8543         _WIN32_WINNT to the XP level, unless already defined to a higher
8544         level.
8545
8546         * unittests/parse-connection-spec-selftests.c:
8547         * ser-tcp.c:
8548         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8549         override.
8550
8551         * symfile.c (find_separate_debug_file): Remove colon from the
8552         drive spec of DOS/Windows file names of the target, so that the
8553         file name produced from DEBUGDIR and the target's directory will
8554         be valid on DOS/Windows systems.
8555
8556 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8557
8558         * rust-lang.c (val_print_struct): Handle printing structures
8559         containing strings.
8560
8561 2019-05-02  Tom Tromey  <tromey@adacore.com>
8562
8563         * valarith.c (_initialize_valarith): Remove.
8564
8565 2019-05-01  Tom Tromey  <tromey@adacore.com>
8566
8567         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8568         bitfields.
8569
8570 2019-05-01  Tom Tromey  <tromey@adacore.com>
8571
8572         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8573         for big-endian copies.
8574
8575 2019-04-30  Ali Tamur  <tamur@google.com>
8576         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8577         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8578         (read_3_bytes): New function.
8579
8580 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8581
8582         * windows-nat.c (main_thread_id): Delete.
8583         (handle_output_debug_string): Replace main_thread_id by
8584         current_event.dwThreadId.
8585         (fake_create_process): Likewise.
8586         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8587         Do not set main_thread_id.
8588         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8589         current_event.dwThreadId.
8590         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8591
8592 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8593
8594         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8595         Use current_event.dwThreadId instead of main_thread_id.
8596
8597 2019-04-30  Tom Tromey  <tromey@adacore.com>
8598
8599         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8600         (create_excep_cond_exprs): Iterate over program spaces.
8601         (ada_exception_catchpoint_cond_string): Examine all minimal
8602         symbols for exception types.
8603
8604 2019-04-30  Tom Tromey  <tromey@adacore.com>
8605
8606         PR c++/24470:
8607         * dwarf2read.c (process_structure_scope): Handle case where type
8608         has template parameters but no symbol was created.
8609
8610 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8611             Chris January  <chris.january@arm.com>
8612
8613         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8614         qualifier.
8615         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8616
8617 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8618
8619         * f-typeprint.c (f_print_type): Update rules for printing
8620         whitespace.
8621         (f_type_print_varspec_suffix): Likewise.
8622
8623 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8624             Chris January  <chris.january@arm.com>
8625
8626         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8627         function arguments.
8628
8629 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8630
8631         * f-lang.c (build_fortran_types): Change name of void type to
8632         lower case.
8633         * f-typeprint.c (f_type_print_base): Print the name of the void
8634         type, rather than a fixed string.
8635         * f-valprint.c (f_decorations): Use lower case void string.
8636
8637 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8638             Chris January  <chris.january@arm.com>
8639
8640         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8641         types for Fortran.
8642
8643 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8644             Chris January  <chris.january@arm.com>
8645             David Lecomber  <david.lecomber@arm.com>
8646
8647         * f-exp.y (BINOP_INTRINSIC): New token.
8648         (exp): New parser rule handling BINOP_INTRINSIC.
8649         (f77_keywords): Add new builtin procedures.
8650         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8651         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8652         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8653         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8654         (print_unop_subexp_f): New function.
8655         (print_binop_subexp_f): New function.
8656         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8657         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8658         (dump_subexp_body_f): Likewise.
8659         (operator_check_f): Likewise.
8660         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8661         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8662
8663 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8664
8665         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8666         UNOP_KIND.
8667         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8668         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8669         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8670         (operator_length_f): New fuction.
8671         (print_subexp_f): New function.
8672         (op_name_f): New function.
8673         (dump_subexp_body_f): New function.
8674         (operator_check_f): New function.
8675         (exp_descriptor_f): Replace standard expression handling functions
8676         with new functions.
8677         * gdb/fortran-operator.def: New file.
8678         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8679         * gdb/std-operator.def: Remove UNOP_KIND.
8680
8681 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8682
8683         * std-operator.def: Remove unbalanced, stray double quote
8684         character.
8685
8686 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8687             Chris January  <chris.january@arm.com>
8688             Daniel Everett  <daniel.everett@arm.com>
8689             Nick Forrington  <nick.forrington@arm.com>
8690             Richard Bunt  <richard.bunt@arm.com>
8691
8692         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8693         of depth when printing anonymous structs or unions.
8694         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8695         Don't print either the top-level value, or the children if the
8696         max-depth is exceeded.
8697         (ppscm_print_children): When printing the key of a map, allow one
8698         extra level of depth.
8699         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8700         print either the top-level value, or the children if the max-depth
8701         is exceeded.
8702         (print_children): When printing the key of a map, allow one extra
8703         level of depth.
8704         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8705         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8706         (user_print_options): Initialise max_depth field.
8707         (val_print_scalar_or_string_type_p): New function.
8708         (val_print): Check to see if the max depth has been reached.
8709         (val_print_check_max_depth): Define new function.
8710         (show_print_max_depth): New function.
8711         (_initialize_valprint): Add 'print max-depth' option.
8712         * valprint.h (struct value_print_options) <max_depth>: New field.
8713         (val_print_check_max_depth): Declare new function.
8714         * NEWS: Document new feature.
8715
8716 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8717
8718         * ada-lang.c (ada_language_defn): Initialise new field.
8719         * c-lang.c (c_is_string_type_p): New function.
8720         (c_language_defn): Initialise new field.
8721         (cplus_language_defn): Initialise new field.
8722         (asm_language_defn): Initialise new field.
8723         (minimal_language_defn): Initialise new field.
8724         * c-lang.h (c_is_string_type_p): Declare new function.
8725         * d-lang.c (d_language_defn): Initialise new field.
8726         * f-lang.c (f_is_string_type_p): New function.
8727         (f_language_defn): Initialise new field.
8728         * go-lang.c (go_is_string_type_p): New function.
8729         (go_language_defn): Initialise new field.
8730         * language.c (default_is_string_type_p): New function.
8731         (unknown_language_defn): Initialise new field.
8732         (auto_language_defn): Initialise new field.
8733         * language.h (struct language_defn) <la_is_string_type_p>: New
8734         member variable.
8735         (default_is_string_type_p): Declare new function.
8736         * m2-lang.c (m2_language_defn): Initialise new field.
8737         * objc-lang.c (objc_language_defn): Initialise new field.
8738         * opencl-lang.c (opencl_language_defn): Initialise new field.
8739         * p-lang.c (pascal_is_string_type_p): New function.
8740         (pascal_language_defn): Initialise new field.
8741         * rust-lang.c (rust_is_string_type_p): New function.
8742         (rust_language_defn): Initialise new field.
8743
8744 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8745
8746         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8747         New field.
8748         * ada-lang.c (ada_language_defn): Initialise new field.
8749         * c-lang.c (c_language_defn): Likewise.
8750         (cplus_language_defn): Likewise.
8751         (asm_language_defn): Likewise.
8752         (minimal_language_defn): Likewise.
8753         * d-lang.c (d_language_defn): Likewise.
8754         * f-lang.c (f_language_defn): Likewise.
8755         * go-lang.c (go_language_defn): Likewise.
8756         * language.c (unknown_language_defn): Likewise.
8757         (auto_language_defn): Likewise.
8758         * m2-lang.c (m2_language_defn): Likewise.
8759         * objc-lang.c (objc_language_defn): Likewise.
8760         * opencl-lang.c (opencl_language_defn): Likewise.
8761         * p-lang.c (pascal_language_defn): Likewise.
8762         * rust-lang.c (rust_language_defn): Likewise.
8763
8764 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8765
8766         * ada-lang.c (ada_is_character_type): Change return type to bool.
8767         (ada_is_string_type): Likewise.
8768         * ada-lang.h (ada_is_character_type): Update declaration
8769         (ada_is_string_type): Likewise.
8770
8771 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8772
8773         Support style in 'frame|thread apply'
8774
8775         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8776         * record.c (record_start, record_stop): Update callers of
8777         execute_command_to_string with false.
8778         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8779         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8780         methods.
8781         (class string_file): New constructor with term_out parameter.
8782         Override methods term_out and can_emit_style_escape.  New member
8783         term_out.
8784         (class stdio_file): Override can_emit_style_escape.
8785         (class tee_file): Override term_out and can_emit_style_escape.
8786         * utils.h (can_emit_style_escape): Remove.
8787         * utils.c (can_emit_style_escape): Likewise.
8788         Update all callers of can_emit_style_escape (SOMESTREAM) to
8789         SOMESTREAM->can_emit_style_escape.
8790         * source-cache.c (source_cache::get_source_lines): Likewise.
8791         * stack.c (frame_apply_command_count): Call execute_command_to_string
8792         passing the term_out characteristic of the current gdb_stdout.
8793         * thread.c (thr_try_catch_cmd): Likewise.
8794         * top.c (execute_command_to_string): pass term_out parameter
8795         to construct the string_file for the command output.
8796         * ui-file.c (term_cli_styling): New function (most code moved
8797         from utils.c can_emit_style_escape).
8798         (string_file::string_file, string_file::can_emit_style_escape,
8799         stdio_file::can_emit_style_escape, tee_file::term_out,
8800         tee_file::can_emit_style_escape): New functions.
8801
8802 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8803
8804         * NEWS: Mention the new set|show may-call-functions.
8805         * infcall.c (may_call_functions_p): New variable.
8806         (show_may_call_functions_p): New function.
8807         (call_function_by_hand_dummy): Throws an error if not
8808         may-call-functions.
8809         (_initialize_infcall): Call add_setshow_boolean_cmd for
8810         may-call-functions.
8811
8812 2019-04-25  Keith Seitz  <keiths@redhat.com>
8813
8814         PR c++/24367
8815         * cp-support.c (inspect_type): Don't attempt substitutions
8816         of symbol with the same name.
8817
8818 2019-04-25  Tom Tromey  <tromey@adacore.com>
8819
8820         PR gdb/24475:
8821         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8822         static.
8823
8824 2019-04-25  Tom Tromey  <tromey@adacore.com>
8825
8826         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8827         rvalue reference.
8828         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8829         (gdb_xml_parser::parse): Use std::move.
8830         * python/python-internal.h (gdbpy_convert_exception): Take a const
8831         reference.
8832         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8833         std::move.
8834         * python/py-utils.c (gdbpy_convert_exception): Take a const
8835         reference.
8836         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8837         Use std::move.
8838         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8839         Use std::move.
8840         * mi/mi-main.c (mi_print_exception): Take a const reference.
8841         * main.c (handle_command_errors): Take a const reference.
8842         * linespec.c (parse_linespec): Use std::move.
8843         * infcall.c (run_inferior_call): Use std::move.
8844         (call_function_by_hand_dummy): Use std::move.
8845         * exec.c (try_open_exec_file): Use std::move.
8846         * exceptions.h (exception_print, exception_fprintf)
8847         (exception_print_same): Update.
8848         * exceptions.c (print_exception, exception_print)
8849         (exception_fprintf, exception_print_same): Change parameters to
8850         const reference.
8851         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8852         * common/new-op.c: Use std::move.
8853         * common/common-exceptions.h (struct gdb_exception): Add move
8854         constructor.
8855         (struct gdb_exception_error, struct gdb_exception_quit, struct
8856         gdb_quit_bad_alloc): Change constructor to move constructor.
8857         (throw_exception): Change parameter to rvalue reference.
8858         * common/common-exceptions.c (throw_exception): Take rvalue
8859         reference.
8860         * cli/cli-interp.c (safe_execute_command): Use std::move.
8861         * breakpoint.c (insert_bp_location, location_to_sals): Use
8862         std::move.
8863
8864 2019-04-25  Tom Tromey  <tromey@adacore.com>
8865
8866         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8867         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8868         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8869         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8870         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8871         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8872         guile/scm-value.c: Use unpack.
8873         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8874         gdbscm_gdb_exception.
8875         (gdbscm_throw_gdb_exception): Likewise.
8876         (struct gdbscm_gdb_exception): New.
8877         (unpack): New function.
8878         (gdbscm_wrap): Use unpack.
8879
8880 2019-04-25  Tom Tromey  <tromey@adacore.com>
8881
8882         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8883         (gdb_rl_callback_handler): Use std::move.
8884         * common/common-exceptions.h (struct gdb_exception): Add move
8885         assignment operator.
8886         (throw_exception_sjlj): Change "exception" to const reference.
8887         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8888         (throw_exception_sjlj): Change "exception" to const reference.
8889
8890 2019-04-25  Tom Tromey  <tromey@adacore.com>
8891
8892         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8893         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8894         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8895         Update.
8896         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8897         Update.
8898         * mi/mi-interp.c (mi_interp::exec): Update.
8899         * linespec.c (parse_linespec): Update.
8900         * infcall.c (run_inferior_call): Update.
8901         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8902         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8903         (gdbscm_lookup_global_symbol): Update.
8904         * guile/scm-param.c (gdbscm_parameter_value): Update.
8905         * guile/scm-frame.c (gdbscm_frame_read_register)
8906         (gdbscm_frame_read_var): Update.
8907         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8908         * exec.c (try_open_exec_file): Update.
8909         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8910         (gdb_rl_callback_handler): Update.
8911         * common/common-exceptions.h (exception_none): Don't declare.
8912         * common/common-exceptions.c (exception_none): Don't define.
8913         (struct catcher) <exception>: Update.
8914         * cli/cli-interp.c (safe_execute_command): Update.
8915         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8916
8917 2019-04-25  Ali Tamur  <tamur@google.com>
8918
8919         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8920         (read_attribute_value): Likewise.
8921         (dwarf2_read_addr_index): Update comment.
8922         (read_str_index): Add DW_FORM_strx.
8923         (dwarf2_string_attr): Likewise.
8924         (dwarf2_const_value_attr): Likewise.
8925         (dump_die_shallow): Likewise.
8926         (dwarf2_fetch_constant_bytes): Likewise.
8927         (skip_form_bytes): Likewise.
8928         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8929
8930 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8931
8932         PR corefiles/11608
8933         PR corefiles/18187
8934         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8935         OFFSET.  Verify if current mapping contains an ELF header.
8936         (linux_find_memory_regions_full): Adjust call to
8937         dump_mapping_p.
8938
8939 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8940             Kang Li <kanglictf@gmail.com>
8941
8942         PR gdb/21600
8943
8944         * dwarf2-frame.c (read_initial_length): Be consistent about using
8945         unsigned representation of length.
8946         (decode_frame_entry_1): Likewise.  Check for wraparound of
8947         end pointer as well as buffer overflow.
8948
8949 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8950
8951         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8952         "vq".
8953
8954 2019-04-24  Tom Tromey  <tromey@adacore.com>
8955
8956         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8957
8958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8959
8960         * s12z-tdep.c (s12z_unwind_pc): Delete.
8961         (s12z_unwind_sp): Delete.
8962         (s12z_gdbarch_init): Don't register deleted functions with
8963         gdbarch.
8964
8965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8966
8967         * rl78-tdep.c (rl78_unwind_sp): Delete.
8968         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8969
8970 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8971
8972         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8973         (xstormy16_unwind_pc): Delete.
8974         (xstormy16_dummy_id): Delete.
8975         (xstormy16_gdbarch_init): Don't register deleted functions with
8976         gdbarch.
8977
8978 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8979
8980         * vax-tdep.c (vax_unwind_pc): Delete.
8981         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8982
8983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8984
8985         * v850-tdep.c (v850_unwind_sp): Delete.
8986         (v850_unwind_pc): Delete.
8987         (v850_dummy_id): Delete.
8988         (v850_gdbarch_init): Don't register deleted functions with
8989         gdbarch.
8990
8991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8992
8993         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8994         (tilegx_unwind_pc): Delete.
8995         (tilegx_unwind_dummy_id): Delete.
8996         (tilegx_gdbarch_init): Don't register deleted functions with
8997         gdbarch.
8998
8999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9000
9001         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9002         (tic6x_dummy_id): Delete.
9003         (tic6x_gdbarch_init): Don't register deleted functions with
9004         gdbarch.
9005
9006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9007
9008         * sparc-tdep.c (sparc_unwind_pc): Delete.
9009         (sparc32_gdbarch_init): Don't register deleted function with
9010         gdbarch.
9011
9012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9013
9014         * sh-tdep.c (sh_unwind_sp): Delete.
9015         (sh_unwind_pc): Delete.
9016         (sh_dummy_id): Delete.
9017         (sh_gdbarch_init): Don't register deleted functions with
9018         gdbarch.
9019
9020 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9021
9022         * score-tdep.c (score_unwind_sp): Delete.
9023         (score_unwind_pc): Delete.
9024         (score_dummy_id): Delete.
9025         (score_gdbarch_init): Don't register deleted functions with
9026         gdbarch.
9027
9028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9029
9030         * rx-tdep.c (rx_unwind_pc): Delete.
9031         (rx_unwind_sp): Delete.
9032         (rx_dummy_id): Delete.
9033         (rx_gdbarch_init): Don't register deleted functions with
9034         gdbarch.  Update comment.
9035
9036 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9037
9038         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9039         (rs6000_dummy_id): Delete.
9040         (rs6000_gdbarch_init): Don't register deleted functions with
9041         gdbarch.
9042
9043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9044
9045         * or1k-tdep.c (or1k_dummy_id): Delete.
9046         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9047
9048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9049
9050         * nios2-tdep.c (nios2_dummy_id): Delete.
9051         (nios2_unwind_sp): Delete.
9052         (nios2_gdbarch_init): Don't register deleted functions with
9053         gdbarch.
9054
9055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9056
9057         * nds32-tdep.c (nds32_dummy_id): Delete.
9058         (nds32_unwind_pc): Delete.
9059         (nds32_unwind_sp): Delete.
9060         (nds32_gdbarch_init): Don't register deleted functions with
9061         gdbarch.
9062
9063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9064
9065         * msp430-tdep.c (msp430_unwind_pc): Delete.
9066         (msp430_unwind_sp): Delete.
9067         (msp430_dummy_id): Delete.
9068         (msp430_gdbarch_init): Don't register deleted functions with
9069         gdbarch.
9070
9071 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9072
9073         * moxie-tdep.c (moxie_unwind_sp): Delete.
9074         (moxie_unwind_pc): Delete.
9075         (moxie_dummy_id): Delete.
9076         (moxie_gdbarch_init): Don't register deleted functions with
9077         gdbarch.
9078
9079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9080
9081         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9082         (mn10300_unwind_pc): Delete.
9083         (mn10300_unwind_sp): Delete.
9084         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9085         mn10300_unwind_sp.
9086         (mn10300_frame_unwind_init): Don't register deleted functions with
9087         gdbarch.
9088
9089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9090
9091         * mep-tdep.c (mep_unwind_pc): Delete.
9092         (mep_unwind_sp): Delete.
9093         (mep_dummy_id): Delete.
9094         (mep_gdbarch_init): Don't register deleted functions with
9095         gdbarch.
9096
9097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9098
9099         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9100         (m68hc11_unwind_sp): Delete.
9101         (m68hc11_gdbarch_init): Don't register deleted functions with
9102         gdbarch.
9103
9104 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9105
9106         * m32r-tdep.c (m32r_unwind_sp): Delete.
9107         (m32r_unwind_pc): Delete.
9108         (m32r_dummy_id): Delete.
9109         (m32r_gdbarch_init): Don't register deleted functions with
9110         gdbarch.
9111
9112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9113
9114         * m32c-tdep.c (m32c_unwind_pc): Delete.
9115         (m32c_unwind_sp): Delete.
9116         (m32c_dummy_id): Delete.
9117         (m32c_gdbarch_init): Don't register deleted functions with
9118         gdbarch.
9119
9120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9121
9122         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9123         (lm32_unwind_pc): Delete.
9124         (lm32_dummy_id): Delete.
9125         (lm32_gdbarch_init): Don't register deleted functions with
9126         gdbarch.
9127
9128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9129
9130         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9131         (iq2000_unwind_pc): Delete.
9132         (iq2000_dummy_id): Delete.
9133         (iq2000_gdbarch_init): Don't register deleted functions with
9134         gdbarch.
9135
9136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9137
9138         * nds32-tdep.c (nds32_type_align): Delete.
9139         (nds32_push_dummy_call): Use type_align instead.
9140
9141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9142
9143         * arm-tdep.c (arm_type_align): Only handle vector override case.
9144         (arm_push_dummy_call): Use type_align.
9145         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9146
9147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9148
9149         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9150         case.
9151         (pass_on_stack): Use type_align.
9152         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9153         function.
9154
9155 2019-04-23  Tom Tromey  <tromey@adacore.com>
9156
9157         * dwarf2read.c (line_header::file_name_at): Remove unused
9158         overload.
9159
9160 2019-04-23  Tom de Vries  <tdevries@suse.de>
9161
9162         PR gdb/24438
9163         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9164         invocation.
9165
9166
9167 2019-03-27  Ali Tamur  <tamur@google.com>
9168
9169         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9170         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9171         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9172         (dwarf_expr_context::get_addr_index): Likewise
9173         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9174         (symbol_needs_eval_context::get_addr_index): Likewise
9175         (disassemble_dwarf_expression): Add DW_OP_addrx
9176         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9177         (read_cutu_die_from_dwo): Update comment
9178         (skip_one_die): Add DW_FORM_addrx
9179         (read_attribute_value): Likewise
9180         (var_decode_location): Add DW_OP_addrx
9181         (dwarf2_const_value_attr): Add DW_FORM_addrx
9182         (dump_die_shallow): Likewise
9183         (dwarf2_fetch_constant_bytes): Likewise
9184         (decode_locdesc): Add DW_OP_addrx
9185         (skip_form_bytes): Add DW_FORM_addrx
9186
9187 2019-04-22  Ali Tamur  <tamur@google.com>
9188
9189         * MAINTAINERS (Write After Approval): Add self.
9190
9191 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9192
9193         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9194         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9195         (open_symbol_file_object): Likewise.
9196         (svr4_default_sos): Add info parameter.
9197         (svr4_read_so_list): Likewise.
9198         (svr4_current_sos_direct): Adjust functions calls to pass down
9199         info.
9200         (svr4_current_sos_1): Add info parameter.
9201         (svr4_current_sos): Call get_svr4_info, pass info down to
9202         svr4_current_sos_1.
9203         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9204         get_svr4_info.
9205         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9206         get_svr4_info.
9207         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9208         to get_svr4_info.
9209         (probes_table_remove_objfile_probes): Likewise.
9210         (register_solib_event_probe): Add info parameter.
9211         (solist_update_incremental): Pass info parameter down to
9212         svr4_read_so_list.
9213         (disable_probes_interface): Add info parameter.
9214         (svr4_handle_solib_event): Pass current_program_space to
9215         get_svr4_info.  Adjust disable_probes_interface cleanup.
9216         (svr4_create_probe_breakpoints): Add info parameter, pass it
9217         down to register_solib_event_probe.
9218         (svr4_create_solib_event_breakpoints): Add info parameter,
9219         pass it down to svr4_create_probe_breakpoints.
9220         (enable_break): Pass info down to
9221         svr4_create_solib_event_breakpoints.
9222         (svr4_solib_create_inferior_hook): Pass current_program_space to
9223         get_svr4_info.
9224         (svr4_clear_solib): Likewise.
9225
9226 2019-04-22  Pedro Alves  <palves@redhat.com>
9227
9228         * solib-svr4.c (svr4_free_objfile_observer): New.
9229         (probe_and_action::objfile): New field.
9230         (probes_table_htab_remove_objfile_probes)
9231         (probes_table_remove_objfile_probes): New functions.
9232         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9233         in the new probe_and_action.  Don't store the probe in 'lookup'.
9234         (svr4_create_probe_breakpoints): Pass objfile to
9235         register_solib_event_probe.
9236         (_initialize_svr4_solib): Register a free_objfile observer.
9237
9238 2019-04-19  Tom Tromey  <tom@tromey.com>
9239
9240         * common/queue.h: Remove.
9241
9242 2019-04-19  Tom Tromey  <tom@tromey.com>
9243
9244         * event-loop.c: Don't include "common/queue.h".
9245
9246 2019-04-19  Tom Tromey  <tom@tromey.com>
9247
9248         * remote.c (remote_target): Use delete.
9249         * remote-notif.h: Include <list>, not "common/queue.h".
9250         (notif_client_p): Remove typedef.
9251         (remote_notif_state): Add constructor, destructor, initializer.
9252         <notif_queue>: Now a std::list.
9253         (remote_notif_state_xfree): Don't declare.
9254         * remote-notif.c (remote_notif_process, handle_notification)
9255         (remote_notif_state_allocate): Update.
9256         (~remote_notif_state): Rename from remote_notif_state_xfree.
9257
9258 2019-04-19  Tom Tromey  <tom@tromey.com>
9259
9260         * symfile.c (reread_symbols): Update.
9261         * objfiles.c (objfile_register_static_link)
9262         (objfile_lookup_static_link): Update
9263         (~objfile) Don't delete static_links.
9264         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9265
9266 2019-04-19  Tom Tromey  <tom@tromey.com>
9267
9268         * type-stack.h (struct type_stack) <insert>: Constify string.
9269         * type-stack.c (type_stack::insert): Constify string.
9270         * gdbtypes.h (lookup_template_type): Update.
9271         (address_space_name_to_int): Update.
9272         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9273         const.
9274         (lookup_template_type): Make name const.
9275         * c-exp.y: Update rules.
9276         (lex_one_token, classify_name, classify_inner_name)
9277         (c_print_token): Update.
9278         * p-exp.y: Update rules.
9279         (yylex): Update.
9280         * f-exp.y: Update rules.
9281         (yylex): Update.
9282         * d-exp.y: Update rules.
9283         (lex_one_token, classify_name, classify_inner_name): Update.
9284         * parse.c (write_dollar_variable, copy_name): Return std::string.
9285         * parser-defs.h (copy_name): Change return type.
9286         * m2-exp.y: Update rules.
9287         (yylex): Update.
9288         * go-exp.y (lex_one_token): Update.
9289         Update rules.
9290         (classify_unsafe_function, classify_packaged_name)
9291         (classify_name, yylex): Update.
9292
9293 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9294
9295         * configure.ac: add --enable-source-highlight switch.
9296         * configure: Regenerate.
9297         * top.c (print_gdb_version): plumb --enable-source-highlight
9298         status to "show configuration".
9299
9300 2019-04-19  Tom Tromey  <tromey@adacore.com>
9301
9302         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9303         Check ADA_TYPE_P.
9304         (empty_record, ada_template_to_fixed_record_type_1)
9305         (template_to_static_fixed_type)
9306         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9307         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9308         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9309         macros.
9310
9311 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9312
9313         PR symtab/24423:
9314         * source.c (print_source_lines_base): Advance "iter" when a
9315         control character is seen.
9316
9317 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9318
9319         * inferior.h (struct infcall_suspend_state_deleter):
9320         Catch exception in destructor to avoid crash.
9321
9322 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9323
9324         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9325         close to the add_com "shell".
9326
9327 2019-04-18  Tom Tromey  <tromey@adacore.com>
9328
9329         * process-stratum-target.h (class process_stratum_target)
9330         <stratum>: Add "final".
9331
9332 2019-04-17  Tom Tromey  <tromey@adacore.com>
9333
9334         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9335         against nullptr before use.
9336
9337 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9338
9339         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9340
9341 2019-04-17  Jim Wilson  <jimw@sifive.com>
9342             Andrew Burgess  <andrew.burgess@embecosm.com>
9343
9344         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9345         code read might fail, assume 4-byte breakpoint in that case.
9346
9347 2019-04-15  Leszek Swirski  <leszeks@google.com>
9348
9349         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9350         rather than a hand-rolled POD check when checking for forced MEMORY
9351         classification.
9352
9353 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9354
9355         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9356         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9357         function.
9358         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9359         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9360         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9361         declaration.
9362
9363 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9364
9365         * aarch64-linux-nat.c
9366         (aarch64_linux_nat_target::thread_architecture): Add override.
9367         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9368         each VQ.
9369
9370 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9371
9372         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9373
9374 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9375
9376         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9377         target types of size 96-bits, add some additional comments, and
9378         check that the builtin type we found was the correct size.
9379
9380 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9381
9382         * utils.c (prompt_for_continue): Don't restore the styling at the
9383         end, as applied_style has the wrong value.  This fixes styling in
9384         long lists of file names that are interrupted by the "Continue?"
9385         prompt.
9386
9387 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9388
9389         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9390         * c-lang.c (c_language_defn): Likewise.
9391         (cplus_language_defn): Likewise.
9392         (asm_language_defn): Likewise.
9393         (minimal_language_defn): Likewise.
9394         * d-lang.c (d_language_defn): Likewise.
9395         * f-lang.c (f_language_defn): Likewise.
9396         * go-lang.c (go_language_defn): Likewise.
9397         * language.c (unknown_language_defn): Likewise.
9398         (auto_language_defn): Likewise.
9399         * language.h (struct language_defn): Remove la_magic field.
9400         (LANG_MAGIC): Delete.
9401         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9402         * objc-lang.c (objc_language_defn): Likewise.
9403         * opencl-lang.c (opencl_language_defn): Likewise.
9404         * p-lang.c (pascal_language_defn): Likewise.
9405         * rust-lang.c (rust_language_defn): Likewise.
9406
9407 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9408
9409         * riscv-tdep.c (riscv_type_align): New function.
9410         (riscv_type_alignment): Delete.
9411         (riscv_arg_location): Use 'type_align'.
9412         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9413
9414 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9415
9416         * gdbtypes.c (type_align): A struct with no non-static fields also
9417         has alignment of 1.
9418
9419 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9420
9421         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9422         component to 0.
9423         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9424         member.
9425         (riscv_struct_info::analyse): New implementation using new
9426         analyse_inner member function.
9427         (riscv_struct_info::field_offset): New member function.
9428         (riscv_struct_info::m_offsets): New member variable.
9429         (riscv_struct_info::analyse_inner): New private member function,
9430         takes the old implementation of riscv_struct_info::analyse but
9431         extended to track field offsets.
9432         (riscv_call_arg_struct): Update the struct folding special cases
9433         to handle cases where empty C++ structs, which are non-zero
9434         length, are found.
9435         (riscv_arg_location): Initialise the length of each location, a
9436         non-zero length now indicates the location is in use.
9437         (riscv_push_dummy_call): Allow for the first location having a
9438         non-zero offset when setting up arguments.
9439         (riscv_return_value): Likewise, but for return values.
9440
9441 2019-04-11  Tom Tromey  <tromey@adacore.com>
9442
9443         * utils.c (internal_vproblem): Make "msg" const.
9444
9445 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9446
9447         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9448         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9449         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9450         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9451
9452 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9453
9454         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9455         function.
9456         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9457         of amd64_collect_native_gregset.
9458         (amd64_linux_nat_target::store_registers): Likewise.
9459
9460 2019-04-10  Tom Tromey  <tom@tromey.com>
9461
9462         * symtab.c (lookup_global_symbol_from_objfile)
9463         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9464         * objfiles.h (class separate_debug_iterator): New.
9465         (class separate_debug_range): New.
9466         (struct objfile) <separate_debug_objfiles>: New method.
9467         (objfile_separate_debug_iterate): Don't declare.
9468         * objfiles.c (separate_debug_iterator::operator++): Rename from
9469         objfile_separate_debug_iterate.
9470         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9471         iterator.
9472         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9473         iterator.
9474
9475 2019-04-10  Tom Tromey  <tom@tromey.com>
9476
9477         * symfile.c (reread_symbols): Remove old comment.
9478         * objfiles.c (free_all_objfiles): Fix a typo.
9479
9480 2019-04-10  Tom Tromey  <tom@tromey.com>
9481
9482         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9483         * minsyms.c (lookup_minimal_symbol): Use foreach.
9484         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9485         (lookup_minimal_symbol_solib_trampoline): Likewise.
9486         * symfile.c (reread_symbols): Use foreach.
9487
9488 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9489             Tom Tromey  <tromey@adacore.com>
9490
9491         PR rust/24414:
9492         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9493         (rust_lex_int_test): Change "value" to be LONGEST.
9494         (rust_lex_tests): Add test for long integer literal.
9495
9496 2019-04-09  Tom Tromey  <tromey@adacore.com>
9497
9498         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9499         to bool.
9500         (extended_remote_target::attach): Update.
9501         (remote_target::remote_notice_new_inferior): Update.
9502         (remote_target::add_current_inferior_and_thread): Update.
9503         * inferior.c (exit_inferior_1): Use "false".
9504         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9505
9506 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9507
9508         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9509         the "start" command.
9510
9511 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9512
9513         * python/py-inferior.c (infpy_thread_from_thread_handle):
9514         Adjust comments to reflect renaming of thread_from_thread_handle
9515         to thread_from_handle.  Adjust keywords.  Fix type error message.
9516         (inferior_object_methods): Add thread_from_handle.  Retain
9517         thread_from_thread_handle, but mark it as deprecated.
9518
9519 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9520
9521         * gdbthread.h (find_thread_by_handle): Revise declaration.
9522         * thread.c (find_thread_by_handle): Likewise.  Adjust
9523         implementation too.
9524         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9525         support for buffer objects as handles.
9526
9527 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9528
9529         * python/py-infthread.c (thpy_thread_handle): New function.
9530         (thread_object_methods): Register thpy_thread_handle.
9531
9532 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9533
9534         * gdbthread.h (thread_to_thread_handle): Declare.
9535         * thread.c (gdbtypes.h): Include.
9536         (thread_to_thread_handle): New function.
9537
9538         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9539         (target_thread_info_to_thread_handle): Declare.
9540         * target.c (target_thread_info_to_thread_handle): New function.
9541         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9542         * target-delegates.c: Regenerate.
9543
9544         * linux-thread-db.c (class thread_db_target): Add method
9545         thread_info_to_thread_handle.
9546         (thread_db_target::thread_info_to_thread_handle): Define.
9547         * remote.c (class remote_target): Add new method
9548         thread_info_to_thread_handle.
9549         (remote_target::thread_info_to_thread_handle): Define.
9550
9551 2019-04-08  Pedro Alves  <palves@redhat.com>
9552
9553         * common/common-exceptions.c (throw_exception): Don't create
9554         named object to throw; throw directly.
9555         (throw_it): Likewise.  Don't initialize gdb_exception::message
9556         here, with new; pass FMT and AP to the ctor instead.
9557         * common/common-exceptions.h: Include <string>.
9558         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9559         const char *, va_list)): New ctor.  Use std::make_shared.
9560         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9561         errors)): Delete.
9562         (gdb_exception_error::gdb_exception_error(enum errors, const char
9563         *, va_list)): New.
9564         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9565         Add assertion.
9566         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9567         errors)): Delete.
9568         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9569         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9570         Add assertion.
9571
9572 2019-04-08  Tom Tromey  <tom@tromey.com>
9573
9574         * valops.c (value_rtti_indirect_type): Replace throw_exception
9575         with throw.
9576         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9577         with throw.
9578         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9579         throw.
9580         * target.c (target_translate_tls_address): Replace throw_exception
9581         with throw.
9582         * stack.c (frame_apply_command_count): Replace throw_exception
9583         with throw.
9584         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9585         throw.
9586         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9587         with throw.
9588         * rs6000-tdep.c (rs6000_frame_cache)
9589         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9590         * remote.c: Replace throw_exception with throw.
9591         * record-full.c (record_full_message, record_full_wait_1)
9592         (record_full_restore): Replace throw_exception with throw.
9593         * record-btrace.c:
9594         (get_thread_current_frame_id, record_btrace_start_replaying)
9595         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9596         (cmd_record_btrace_start): Replace throw_exception with throw.
9597         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9598         throw.
9599         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9600         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9601         * linespec.c:
9602         (find_linespec_symbols): Replace throw_exception with throw.
9603         * infrun.c (displaced_step_prepare, resume): Replace
9604         throw_exception with throw.
9605         * infcmd.c (post_create_inferior): Replace throw_exception with
9606         throw.
9607         * inf-loop.c (inferior_event_handler): Replace throw_exception
9608         with throw.
9609         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9610         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9611         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9612         (get_prev_frame_always, get_frame_pc_if_available)
9613         (get_frame_address_in_block_if_available, get_frame_language):
9614         Replace throw_exception with throw.
9615         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9616         throw_exception with throw.
9617         * eval.c (fetch_subexp_value, evaluate_var_value)
9618         (evaluate_funcall, evaluate_subexp_standard): Replace
9619         throw_exception with throw.
9620         * dwarf2loc.c (call_site_find_chain)
9621         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9622         Replace throw_exception with throw.
9623         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9624         with throw.
9625         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9626         throw.
9627         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9628         * completer.c (complete_line_internal): Replace throw_exception
9629         with throw.
9630         * compile/compile-object-run.c (compile_object_run): Replace
9631         throw_exception with throw.
9632         * cli/cli-script.c (process_next_line): Replace throw_exception
9633         with throw.
9634         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9635         (btrace_enable, btrace_maint_update_pt_packets): Replace
9636         throw_exception with throw.
9637         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9638         throw_exception with throw.
9639         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9640         throw_exception with throw.
9641         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9642         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9643         * aarch64-tdep.c (aarch64_make_prologue_cache)
9644         (aarch64_make_stub_cache): Replace throw_exception with throw.
9645
9646 2019-04-08  Tom Tromey  <tom@tromey.com>
9647
9648         * common/common-exceptions.c (throw_exception): Rename from
9649         throw_exception_cxx.  Remove old copy.  Make argument const.
9650         (throw_it): Create and throw exception objects directly.
9651         * common/common-exceptions.h (throw_exception): Make argument
9652         const.
9653         (struct gdb_exception_error): Add constructor.
9654         (struct gdb_exception_quit): Add constructor.
9655
9656 2019-04-08  Tom Tromey  <tom@tromey.com>
9657
9658         * common/common-exceptions.h (exception_rethrow): Don't declare.
9659         (TRY_SJLJ): Update comment.
9660         (TRY, CATCH, END_CATCH): Remove.
9661         * common/common-exceptions.c (exception_rethrow): Remove.
9662
9663 2019-04-08  Tom Tromey  <tom@tromey.com>
9664
9665         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9666         Remove.
9667         (gdb_exception_error): Rename from
9668         gdb_exception_RETURN_MASK_ERROR.
9669         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9670         (gdb_quit_bad_alloc): Update.
9671         * aarch64-tdep.c: Update.
9672         * ada-lang.c: Update.
9673         * ada-typeprint.c: Update.
9674         * ada-valprint.c: Update.
9675         * amd64-tdep.c: Update.
9676         * arch-utils.c: Update.
9677         * break-catch-throw.c: Update.
9678         * breakpoint.c: Update.
9679         * btrace.c: Update.
9680         * c-varobj.c: Update.
9681         * cli/cli-cmds.c: Update.
9682         * cli/cli-interp.c: Update.
9683         * cli/cli-script.c: Update.
9684         * common/common-exceptions.c: Update.
9685         * common/new-op.c: Update.
9686         * common/selftest.c: Update.
9687         * compile/compile-c-symbols.c: Update.
9688         * compile/compile-cplus-symbols.c: Update.
9689         * compile/compile-object-load.c: Update.
9690         * compile/compile-object-run.c: Update.
9691         * completer.c: Update.
9692         * corelow.c: Update.
9693         * cp-abi.c: Update.
9694         * cp-support.c: Update.
9695         * cp-valprint.c: Update.
9696         * darwin-nat.c: Update.
9697         * disasm-selftests.c: Update.
9698         * dtrace-probe.c: Update.
9699         * dwarf-index-cache.c: Update.
9700         * dwarf-index-write.c: Update.
9701         * dwarf2-frame-tailcall.c: Update.
9702         * dwarf2-frame.c: Update.
9703         * dwarf2loc.c: Update.
9704         * dwarf2read.c: Update.
9705         * eval.c: Update.
9706         * event-loop.c: Update.
9707         * event-top.c: Update.
9708         * exec.c: Update.
9709         * f-valprint.c: Update.
9710         * fbsd-tdep.c: Update.
9711         * frame-unwind.c: Update.
9712         * frame.c: Update.
9713         * gdbtypes.c: Update.
9714         * gnu-v3-abi.c: Update.
9715         * guile/guile-internal.h: Update.
9716         * guile/scm-block.c: Update.
9717         * guile/scm-breakpoint.c: Update.
9718         * guile/scm-cmd.c: Update.
9719         * guile/scm-disasm.c: Update.
9720         * guile/scm-frame.c: Update.
9721         * guile/scm-lazy-string.c: Update.
9722         * guile/scm-math.c: Update.
9723         * guile/scm-param.c: Update.
9724         * guile/scm-ports.c: Update.
9725         * guile/scm-pretty-print.c: Update.
9726         * guile/scm-symbol.c: Update.
9727         * guile/scm-symtab.c: Update.
9728         * guile/scm-type.c: Update.
9729         * guile/scm-value.c: Update.
9730         * i386-linux-tdep.c: Update.
9731         * i386-tdep.c: Update.
9732         * inf-loop.c: Update.
9733         * infcall.c: Update.
9734         * infcmd.c: Update.
9735         * infrun.c: Update.
9736         * jit.c: Update.
9737         * language.c: Update.
9738         * linespec.c: Update.
9739         * linux-fork.c: Update.
9740         * linux-nat.c: Update.
9741         * linux-tdep.c: Update.
9742         * linux-thread-db.c: Update.
9743         * main.c: Update.
9744         * mi/mi-cmd-break.c: Update.
9745         * mi/mi-cmd-stack.c: Update.
9746         * mi/mi-interp.c: Update.
9747         * mi/mi-main.c: Update.
9748         * objc-lang.c: Update.
9749         * p-valprint.c: Update.
9750         * parse.c: Update.
9751         * ppc-linux-tdep.c: Update.
9752         * printcmd.c: Update.
9753         * python/py-arch.c: Update.
9754         * python/py-breakpoint.c: Update.
9755         * python/py-cmd.c: Update.
9756         * python/py-finishbreakpoint.c: Update.
9757         * python/py-frame.c: Update.
9758         * python/py-framefilter.c: Update.
9759         * python/py-gdb-readline.c: Update.
9760         * python/py-inferior.c: Update.
9761         * python/py-infthread.c: Update.
9762         * python/py-lazy-string.c: Update.
9763         * python/py-linetable.c: Update.
9764         * python/py-objfile.c: Update.
9765         * python/py-param.c: Update.
9766         * python/py-prettyprint.c: Update.
9767         * python/py-progspace.c: Update.
9768         * python/py-record-btrace.c: Update.
9769         * python/py-record.c: Update.
9770         * python/py-symbol.c: Update.
9771         * python/py-type.c: Update.
9772         * python/py-unwind.c: Update.
9773         * python/py-utils.c: Update.
9774         * python/py-value.c: Update.
9775         * python/python.c: Update.
9776         * record-btrace.c: Update.
9777         * record-full.c: Update.
9778         * remote-fileio.c: Update.
9779         * remote.c: Update.
9780         * riscv-tdep.c: Update.
9781         * rs6000-aix-tdep.c: Update.
9782         * rs6000-tdep.c: Update.
9783         * rust-exp.y: Update.
9784         * rust-lang.c: Update.
9785         * s390-tdep.c: Update.
9786         * selftest-arch.c: Update.
9787         * solib-dsbt.c: Update.
9788         * solib-frv.c: Update.
9789         * solib-spu.c: Update.
9790         * solib-svr4.c: Update.
9791         * solib.c: Update.
9792         * sparc64-linux-tdep.c: Update.
9793         * stack.c: Update.
9794         * symfile-mem.c: Update.
9795         * symmisc.c: Update.
9796         * target.c: Update.
9797         * thread.c: Update.
9798         * top.c: Update.
9799         * tracefile-tfile.c: Update.
9800         * tui/tui.c: Update.
9801         * typeprint.c: Update.
9802         * unittests/cli-utils-selftests.c: Update.
9803         * unittests/parse-connection-spec-selftests.c: Update.
9804         * valops.c: Update.
9805         * valprint.c: Update.
9806         * value.c: Update.
9807         * varobj.c: Update.
9808         * windows-nat.c: Update.
9809         * x86-linux-nat.c: Update.
9810         * xml-support.c: Update.
9811
9812 2019-04-08  Tom Tromey  <tom@tromey.com>
9813
9814         * xml-support.c: Use C++ exception handling.
9815         * x86-linux-nat.c: Use C++ exception handling.
9816         * windows-nat.c: Use C++ exception handling.
9817         * varobj.c: Use C++ exception handling.
9818         * value.c: Use C++ exception handling.
9819         * valprint.c: Use C++ exception handling.
9820         * valops.c: Use C++ exception handling.
9821         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9822         handling.
9823         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9824         * typeprint.c: Use C++ exception handling.
9825         * tui/tui.c: Use C++ exception handling.
9826         * tracefile-tfile.c: Use C++ exception handling.
9827         * top.c: Use C++ exception handling.
9828         * thread.c: Use C++ exception handling.
9829         * target.c: Use C++ exception handling.
9830         * symmisc.c: Use C++ exception handling.
9831         * symfile-mem.c: Use C++ exception handling.
9832         * stack.c: Use C++ exception handling.
9833         * sparc64-linux-tdep.c: Use C++ exception handling.
9834         * solib.c: Use C++ exception handling.
9835         * solib-svr4.c: Use C++ exception handling.
9836         * solib-spu.c: Use C++ exception handling.
9837         * solib-frv.c: Use C++ exception handling.
9838         * solib-dsbt.c: Use C++ exception handling.
9839         * selftest-arch.c: Use C++ exception handling.
9840         * s390-tdep.c: Use C++ exception handling.
9841         * rust-lang.c: Use C++ exception handling.
9842         * rust-exp.y: Use C++ exception handling.
9843         * rs6000-tdep.c: Use C++ exception handling.
9844         * rs6000-aix-tdep.c: Use C++ exception handling.
9845         * riscv-tdep.c: Use C++ exception handling.
9846         * remote.c: Use C++ exception handling.
9847         * remote-fileio.c: Use C++ exception handling.
9848         * record-full.c: Use C++ exception handling.
9849         * record-btrace.c: Use C++ exception handling.
9850         * python/python.c: Use C++ exception handling.
9851         * python/py-value.c: Use C++ exception handling.
9852         * python/py-utils.c: Use C++ exception handling.
9853         * python/py-unwind.c: Use C++ exception handling.
9854         * python/py-type.c: Use C++ exception handling.
9855         * python/py-symbol.c: Use C++ exception handling.
9856         * python/py-record.c: Use C++ exception handling.
9857         * python/py-record-btrace.c: Use C++ exception handling.
9858         * python/py-progspace.c: Use C++ exception handling.
9859         * python/py-prettyprint.c: Use C++ exception handling.
9860         * python/py-param.c: Use C++ exception handling.
9861         * python/py-objfile.c: Use C++ exception handling.
9862         * python/py-linetable.c: Use C++ exception handling.
9863         * python/py-lazy-string.c: Use C++ exception handling.
9864         * python/py-infthread.c: Use C++ exception handling.
9865         * python/py-inferior.c: Use C++ exception handling.
9866         * python/py-gdb-readline.c: Use C++ exception handling.
9867         * python/py-framefilter.c: Use C++ exception handling.
9868         * python/py-frame.c: Use C++ exception handling.
9869         * python/py-finishbreakpoint.c: Use C++ exception handling.
9870         * python/py-cmd.c: Use C++ exception handling.
9871         * python/py-breakpoint.c: Use C++ exception handling.
9872         * python/py-arch.c: Use C++ exception handling.
9873         * printcmd.c: Use C++ exception handling.
9874         * ppc-linux-tdep.c: Use C++ exception handling.
9875         * parse.c: Use C++ exception handling.
9876         * p-valprint.c: Use C++ exception handling.
9877         * objc-lang.c: Use C++ exception handling.
9878         * mi/mi-main.c: Use C++ exception handling.
9879         * mi/mi-interp.c: Use C++ exception handling.
9880         * mi/mi-cmd-stack.c: Use C++ exception handling.
9881         * mi/mi-cmd-break.c: Use C++ exception handling.
9882         * main.c: Use C++ exception handling.
9883         * linux-thread-db.c: Use C++ exception handling.
9884         * linux-tdep.c: Use C++ exception handling.
9885         * linux-nat.c: Use C++ exception handling.
9886         * linux-fork.c: Use C++ exception handling.
9887         * linespec.c: Use C++ exception handling.
9888         * language.c: Use C++ exception handling.
9889         * jit.c: Use C++ exception handling.
9890         * infrun.c: Use C++ exception handling.
9891         * infcmd.c: Use C++ exception handling.
9892         * infcall.c: Use C++ exception handling.
9893         * inf-loop.c: Use C++ exception handling.
9894         * i386-tdep.c: Use C++ exception handling.
9895         * i386-linux-tdep.c: Use C++ exception handling.
9896         * guile/scm-value.c: Use C++ exception handling.
9897         * guile/scm-type.c: Use C++ exception handling.
9898         * guile/scm-symtab.c: Use C++ exception handling.
9899         * guile/scm-symbol.c: Use C++ exception handling.
9900         * guile/scm-pretty-print.c: Use C++ exception handling.
9901         * guile/scm-ports.c: Use C++ exception handling.
9902         * guile/scm-param.c: Use C++ exception handling.
9903         * guile/scm-math.c: Use C++ exception handling.
9904         * guile/scm-lazy-string.c: Use C++ exception handling.
9905         * guile/scm-frame.c: Use C++ exception handling.
9906         * guile/scm-disasm.c: Use C++ exception handling.
9907         * guile/scm-cmd.c: Use C++ exception handling.
9908         * guile/scm-breakpoint.c: Use C++ exception handling.
9909         * guile/scm-block.c: Use C++ exception handling.
9910         * guile/guile-internal.h: Use C++ exception handling.
9911         * gnu-v3-abi.c: Use C++ exception handling.
9912         * gdbtypes.c: Use C++ exception handling.
9913         * frame.c: Use C++ exception handling.
9914         * frame-unwind.c: Use C++ exception handling.
9915         * fbsd-tdep.c: Use C++ exception handling.
9916         * f-valprint.c: Use C++ exception handling.
9917         * exec.c: Use C++ exception handling.
9918         * event-top.c: Use C++ exception handling.
9919         * event-loop.c: Use C++ exception handling.
9920         * eval.c: Use C++ exception handling.
9921         * dwarf2read.c: Use C++ exception handling.
9922         * dwarf2loc.c: Use C++ exception handling.
9923         * dwarf2-frame.c: Use C++ exception handling.
9924         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9925         * dwarf-index-write.c: Use C++ exception handling.
9926         * dwarf-index-cache.c: Use C++ exception handling.
9927         * dtrace-probe.c: Use C++ exception handling.
9928         * disasm-selftests.c: Use C++ exception handling.
9929         * darwin-nat.c: Use C++ exception handling.
9930         * cp-valprint.c: Use C++ exception handling.
9931         * cp-support.c: Use C++ exception handling.
9932         * cp-abi.c: Use C++ exception handling.
9933         * corelow.c: Use C++ exception handling.
9934         * completer.c: Use C++ exception handling.
9935         * compile/compile-object-run.c: Use C++ exception handling.
9936         * compile/compile-object-load.c: Use C++ exception handling.
9937         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9938         * compile/compile-c-symbols.c: Use C++ exception handling.
9939         * common/selftest.c: Use C++ exception handling.
9940         * common/new-op.c: Use C++ exception handling.
9941         * cli/cli-script.c: Use C++ exception handling.
9942         * cli/cli-interp.c: Use C++ exception handling.
9943         * cli/cli-cmds.c: Use C++ exception handling.
9944         * c-varobj.c: Use C++ exception handling.
9945         * btrace.c: Use C++ exception handling.
9946         * breakpoint.c: Use C++ exception handling.
9947         * break-catch-throw.c: Use C++ exception handling.
9948         * arch-utils.c: Use C++ exception handling.
9949         * amd64-tdep.c: Use C++ exception handling.
9950         * ada-valprint.c: Use C++ exception handling.
9951         * ada-typeprint.c: Use C++ exception handling.
9952         * ada-lang.c: Use C++ exception handling.
9953         * aarch64-tdep.c: Use C++ exception handling.
9954
9955 2019-04-08  Tom Tromey  <tom@tromey.com>
9956
9957         * xml-support.c (gdb_xml_parser::parse): Update.
9958         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9959         * value.c (show_convenience): Update.
9960         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9961         (test_parse_flags_qcs): Update.
9962         * thread.c (thr_try_catch_cmd): Update.
9963         * target.c (target_translate_tls_address): Update.
9964         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9965         (info_frame_command_core, frame_apply_command_count): Update.
9966         * rust-exp.y (rust_lex_exception_test): Update.
9967         * riscv-tdep.c (riscv_print_one_register_info): Update.
9968         * remote.c (remote_target::enable_btrace): Update.
9969         * record-btrace.c (record_btrace_enable_warn): Update.
9970         * python/py-utils.c (gdbpy_convert_exception): Update.
9971         * printcmd.c (do_one_display, print_variable_and_value): Update.
9972         * mi/mi-main.c (mi_print_exception): Update.
9973         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9974         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9975         * linux-nat.c (linux_nat_target::attach): Update.
9976         * linux-fork.c (class scoped_switch_fork_info): Update.
9977         * infrun.c (displaced_step_prepare): Update.
9978         * infcall.c (call_function_by_hand_dummy): Update.
9979         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9980         * gnu-v3-abi.c (print_one_vtable): Update.
9981         * frame.c (get_prev_frame_always): Update.
9982         * f-valprint.c (info_common_command_for_block): Update.
9983         * exec.c (try_open_exec_file): Update.
9984         * exceptions.c (print_exception, exception_print)
9985         (exception_fprintf, exception_print_same): Update.
9986         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9987         * dwarf-index-cache.c (index_cache::store)
9988         (index_cache::lookup_gdb_index): Update.
9989         * darwin-nat.c (maybe_cache_shell): Update.
9990         * cp-valprint.c (cp_print_value_fields): Update.
9991         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9992         (gcc_cplus_symbol_address): Update.
9993         * compile/compile-c-symbols.c (gcc_convert_symbol)
9994         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9995         * common/selftest.c: Update.
9996         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9997         a std::string.
9998         (exception_try_scope_entry, exception_try_scope_exit): Don't
9999         declare.
10000         (struct exception_try_scope): Remove.
10001         (TRY): Don't use exception_try_scope.
10002         (struct gdb_exception): Add constructor, operator=.
10003         <what>: New method.
10004         (struct gdb_exception_RETURN_MASK_ALL)
10005         (struct gdb_exception_RETURN_MASK_ERROR)
10006         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10007         (struct gdb_quit_bad_alloc): Update.
10008         * common/common-exceptions.c (exception_none): Change
10009         initializer.
10010         (struct catcher) <state, exception>: Initialize inline.
10011         <prev>: Remove member.
10012         (current_catcher): Remove.
10013         (catchers): New global.
10014         (exceptions_state_mc_init): Simplify.
10015         (catcher_pop): Remove.
10016         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10017         (try_scope_depth, exception_try_scope_entry)
10018         (exception_try_scope_exit): Remove.
10019         (throw_exception_sjlj): Update.
10020         (exception_messages, exception_messages_size): Remove.
10021         (throw_it): Simplify.
10022         (gdb_exception_sliced_copy): Remove.
10023         (throw_exception_cxx): Update.
10024         * cli/cli-script.c (script_from_file): Update.
10025         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10026         Update.
10027         * ada-valprint.c (ada_val_print): Update.
10028         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10029         (create_excep_cond_exprs): Update.
10030
10031 2019-04-08  Tom Tromey  <tom@tromey.com>
10032
10033         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10034         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10035         (TRY, CATCH, END_CATCH): Remove some definitions.
10036         * common/common-exceptions.c: Don't use GDB_XCPT.
10037         (catcher_list_size): Remove.
10038         (throw_exception, throw_it): Simplify.
10039
10040 2019-04-05  Tom Tromey  <tom@tromey.com>
10041
10042         Revert the header-sorting patch.
10043         * ft32-tdep.c: Revert.
10044         * frv-tdep.c: Revert.
10045         * frv-linux-tdep.c: Revert.
10046         * frame.c: Revert.
10047         * frame-unwind.c: Revert.
10048         * frame-base.c: Revert.
10049         * fork-child.c: Revert.
10050         * findvar.c: Revert.
10051         * findcmd.c: Revert.
10052         * filesystem.c: Revert.
10053         * filename-seen-cache.h: Revert.
10054         * filename-seen-cache.c: Revert.
10055         * fbsd-tdep.c: Revert.
10056         * fbsd-nat.h: Revert.
10057         * fbsd-nat.c: Revert.
10058         * f-valprint.c: Revert.
10059         * f-typeprint.c: Revert.
10060         * f-lang.c: Revert.
10061         * extension.h: Revert.
10062         * extension.c: Revert.
10063         * extension-priv.h: Revert.
10064         * expprint.c: Revert.
10065         * exec.h: Revert.
10066         * exec.c: Revert.
10067         * exceptions.c: Revert.
10068         * event-top.c: Revert.
10069         * event-loop.c: Revert.
10070         * eval.c: Revert.
10071         * elfread.c: Revert.
10072         * dwarf2read.h: Revert.
10073         * dwarf2read.c: Revert.
10074         * dwarf2loc.c: Revert.
10075         * dwarf2expr.h: Revert.
10076         * dwarf2expr.c: Revert.
10077         * dwarf2-frame.c: Revert.
10078         * dwarf2-frame-tailcall.c: Revert.
10079         * dwarf-index-write.h: Revert.
10080         * dwarf-index-write.c: Revert.
10081         * dwarf-index-common.c: Revert.
10082         * dwarf-index-cache.h: Revert.
10083         * dwarf-index-cache.c: Revert.
10084         * dummy-frame.c: Revert.
10085         * dtrace-probe.c: Revert.
10086         * disasm.h: Revert.
10087         * disasm.c: Revert.
10088         * disasm-selftests.c: Revert.
10089         * dictionary.c: Revert.
10090         * dicos-tdep.c: Revert.
10091         * demangle.c: Revert.
10092         * dcache.h: Revert.
10093         * dcache.c: Revert.
10094         * darwin-nat.h: Revert.
10095         * darwin-nat.c: Revert.
10096         * darwin-nat-info.c: Revert.
10097         * d-valprint.c: Revert.
10098         * d-namespace.c: Revert.
10099         * d-lang.c: Revert.
10100         * ctf.c: Revert.
10101         * csky-tdep.c: Revert.
10102         * csky-linux-tdep.c: Revert.
10103         * cris-tdep.c: Revert.
10104         * cris-linux-tdep.c: Revert.
10105         * cp-valprint.c: Revert.
10106         * cp-support.c: Revert.
10107         * cp-namespace.c: Revert.
10108         * cp-abi.c: Revert.
10109         * corelow.c: Revert.
10110         * corefile.c: Revert.
10111         * continuations.c: Revert.
10112         * completer.h: Revert.
10113         * completer.c: Revert.
10114         * complaints.c: Revert.
10115         * coffread.c: Revert.
10116         * coff-pe-read.c: Revert.
10117         * cli-out.h: Revert.
10118         * cli-out.c: Revert.
10119         * charset.c: Revert.
10120         * c-varobj.c: Revert.
10121         * c-valprint.c: Revert.
10122         * c-typeprint.c: Revert.
10123         * c-lang.c: Revert.
10124         * buildsym.c: Revert.
10125         * buildsym-legacy.c: Revert.
10126         * build-id.h: Revert.
10127         * build-id.c: Revert.
10128         * btrace.c: Revert.
10129         * bsd-uthread.c: Revert.
10130         * breakpoint.h: Revert.
10131         * breakpoint.c: Revert.
10132         * break-catch-throw.c: Revert.
10133         * break-catch-syscall.c: Revert.
10134         * break-catch-sig.c: Revert.
10135         * blockframe.c: Revert.
10136         * block.c: Revert.
10137         * bfin-tdep.c: Revert.
10138         * bfin-linux-tdep.c: Revert.
10139         * bfd-target.c: Revert.
10140         * bcache.c: Revert.
10141         * ax-general.c: Revert.
10142         * ax-gdb.h: Revert.
10143         * ax-gdb.c: Revert.
10144         * avr-tdep.c: Revert.
10145         * auxv.c: Revert.
10146         * auto-load.c: Revert.
10147         * arm-wince-tdep.c: Revert.
10148         * arm-tdep.c: Revert.
10149         * arm-symbian-tdep.c: Revert.
10150         * arm-pikeos-tdep.c: Revert.
10151         * arm-obsd-tdep.c: Revert.
10152         * arm-nbsd-tdep.c: Revert.
10153         * arm-nbsd-nat.c: Revert.
10154         * arm-linux-tdep.c: Revert.
10155         * arm-linux-nat.c: Revert.
10156         * arm-fbsd-tdep.c: Revert.
10157         * arm-fbsd-nat.c: Revert.
10158         * arm-bsd-tdep.c: Revert.
10159         * arch-utils.c: Revert.
10160         * arc-tdep.c: Revert.
10161         * arc-newlib-tdep.c: Revert.
10162         * annotate.h: Revert.
10163         * annotate.c: Revert.
10164         * amd64-windows-tdep.c: Revert.
10165         * amd64-windows-nat.c: Revert.
10166         * amd64-tdep.c: Revert.
10167         * amd64-sol2-tdep.c: Revert.
10168         * amd64-obsd-tdep.c: Revert.
10169         * amd64-obsd-nat.c: Revert.
10170         * amd64-nbsd-tdep.c: Revert.
10171         * amd64-nbsd-nat.c: Revert.
10172         * amd64-nat.c: Revert.
10173         * amd64-linux-tdep.c: Revert.
10174         * amd64-linux-nat.c: Revert.
10175         * amd64-fbsd-tdep.c: Revert.
10176         * amd64-fbsd-nat.c: Revert.
10177         * amd64-dicos-tdep.c: Revert.
10178         * amd64-darwin-tdep.c: Revert.
10179         * amd64-bsd-nat.c: Revert.
10180         * alpha-tdep.c: Revert.
10181         * alpha-obsd-tdep.c: Revert.
10182         * alpha-nbsd-tdep.c: Revert.
10183         * alpha-mdebug-tdep.c: Revert.
10184         * alpha-linux-tdep.c: Revert.
10185         * alpha-linux-nat.c: Revert.
10186         * alpha-bsd-tdep.c: Revert.
10187         * alpha-bsd-nat.c: Revert.
10188         * aix-thread.c: Revert.
10189         * agent.c: Revert.
10190         * addrmap.c: Revert.
10191         * ada-varobj.c: Revert.
10192         * ada-valprint.c: Revert.
10193         * ada-typeprint.c: Revert.
10194         * ada-tasks.c: Revert.
10195         * ada-lang.c: Revert.
10196         * aarch64-tdep.c: Revert.
10197         * aarch64-ravenscar-thread.c: Revert.
10198         * aarch64-newlib-tdep.c: Revert.
10199         * aarch64-linux-tdep.c: Revert.
10200         * aarch64-linux-nat.c: Revert.
10201         * aarch64-fbsd-tdep.c: Revert.
10202         * aarch64-fbsd-nat.c: Revert.
10203         * aarch32-linux-nat.c: Revert.
10204
10205 2019-04-05  Tom Tromey  <tom@tromey.com>
10206
10207         * ft32-tdep.c: Sort headers.
10208         * frv-tdep.c: Sort headers.
10209         * frv-linux-tdep.c: Sort headers.
10210         * frame.c: Sort headers.
10211         * frame-unwind.c: Sort headers.
10212         * frame-base.c: Sort headers.
10213         * fork-child.c: Sort headers.
10214         * findvar.c: Sort headers.
10215         * findcmd.c: Sort headers.
10216         * filesystem.c: Sort headers.
10217         * filename-seen-cache.h: Sort headers.
10218         * filename-seen-cache.c: Sort headers.
10219         * fbsd-tdep.c: Sort headers.
10220         * fbsd-nat.h: Sort headers.
10221         * fbsd-nat.c: Sort headers.
10222         * f-valprint.c: Sort headers.
10223         * f-typeprint.c: Sort headers.
10224         * f-lang.c: Sort headers.
10225         * extension.h: Sort headers.
10226         * extension.c: Sort headers.
10227         * extension-priv.h: Sort headers.
10228         * expprint.c: Sort headers.
10229         * exec.h: Sort headers.
10230         * exec.c: Sort headers.
10231         * exceptions.c: Sort headers.
10232         * event-top.c: Sort headers.
10233         * event-loop.c: Sort headers.
10234         * eval.c: Sort headers.
10235         * elfread.c: Sort headers.
10236         * dwarf2read.h: Sort headers.
10237         * dwarf2read.c: Sort headers.
10238         * dwarf2loc.c: Sort headers.
10239         * dwarf2expr.h: Sort headers.
10240         * dwarf2expr.c: Sort headers.
10241         * dwarf2-frame.c: Sort headers.
10242         * dwarf2-frame-tailcall.c: Sort headers.
10243         * dwarf-index-write.h: Sort headers.
10244         * dwarf-index-write.c: Sort headers.
10245         * dwarf-index-common.c: Sort headers.
10246         * dwarf-index-cache.h: Sort headers.
10247         * dwarf-index-cache.c: Sort headers.
10248         * dummy-frame.c: Sort headers.
10249         * dtrace-probe.c: Sort headers.
10250         * disasm.h: Sort headers.
10251         * disasm.c: Sort headers.
10252         * disasm-selftests.c: Sort headers.
10253         * dictionary.c: Sort headers.
10254         * dicos-tdep.c: Sort headers.
10255         * demangle.c: Sort headers.
10256         * dcache.h: Sort headers.
10257         * dcache.c: Sort headers.
10258         * darwin-nat.h: Sort headers.
10259         * darwin-nat.c: Sort headers.
10260         * darwin-nat-info.c: Sort headers.
10261         * d-valprint.c: Sort headers.
10262         * d-namespace.c: Sort headers.
10263         * d-lang.c: Sort headers.
10264         * ctf.c: Sort headers.
10265         * csky-tdep.c: Sort headers.
10266         * csky-linux-tdep.c: Sort headers.
10267         * cris-tdep.c: Sort headers.
10268         * cris-linux-tdep.c: Sort headers.
10269         * cp-valprint.c: Sort headers.
10270         * cp-support.c: Sort headers.
10271         * cp-namespace.c: Sort headers.
10272         * cp-abi.c: Sort headers.
10273         * corelow.c: Sort headers.
10274         * corefile.c: Sort headers.
10275         * continuations.c: Sort headers.
10276         * completer.h: Sort headers.
10277         * completer.c: Sort headers.
10278         * complaints.c: Sort headers.
10279         * coffread.c: Sort headers.
10280         * coff-pe-read.c: Sort headers.
10281         * cli-out.h: Sort headers.
10282         * cli-out.c: Sort headers.
10283         * charset.c: Sort headers.
10284         * c-varobj.c: Sort headers.
10285         * c-valprint.c: Sort headers.
10286         * c-typeprint.c: Sort headers.
10287         * c-lang.c: Sort headers.
10288         * buildsym.c: Sort headers.
10289         * buildsym-legacy.c: Sort headers.
10290         * build-id.h: Sort headers.
10291         * build-id.c: Sort headers.
10292         * btrace.c: Sort headers.
10293         * bsd-uthread.c: Sort headers.
10294         * breakpoint.h: Sort headers.
10295         * breakpoint.c: Sort headers.
10296         * break-catch-throw.c: Sort headers.
10297         * break-catch-syscall.c: Sort headers.
10298         * break-catch-sig.c: Sort headers.
10299         * blockframe.c: Sort headers.
10300         * block.c: Sort headers.
10301         * bfin-tdep.c: Sort headers.
10302         * bfin-linux-tdep.c: Sort headers.
10303         * bfd-target.c: Sort headers.
10304         * bcache.c: Sort headers.
10305         * ax-general.c: Sort headers.
10306         * ax-gdb.h: Sort headers.
10307         * ax-gdb.c: Sort headers.
10308         * avr-tdep.c: Sort headers.
10309         * auxv.c: Sort headers.
10310         * auto-load.c: Sort headers.
10311         * arm-wince-tdep.c: Sort headers.
10312         * arm-tdep.c: Sort headers.
10313         * arm-symbian-tdep.c: Sort headers.
10314         * arm-pikeos-tdep.c: Sort headers.
10315         * arm-obsd-tdep.c: Sort headers.
10316         * arm-nbsd-tdep.c: Sort headers.
10317         * arm-nbsd-nat.c: Sort headers.
10318         * arm-linux-tdep.c: Sort headers.
10319         * arm-linux-nat.c: Sort headers.
10320         * arm-fbsd-tdep.c: Sort headers.
10321         * arm-fbsd-nat.c: Sort headers.
10322         * arm-bsd-tdep.c: Sort headers.
10323         * arch-utils.c: Sort headers.
10324         * arc-tdep.c: Sort headers.
10325         * arc-newlib-tdep.c: Sort headers.
10326         * annotate.h: Sort headers.
10327         * annotate.c: Sort headers.
10328         * amd64-windows-tdep.c: Sort headers.
10329         * amd64-windows-nat.c: Sort headers.
10330         * amd64-tdep.c: Sort headers.
10331         * amd64-sol2-tdep.c: Sort headers.
10332         * amd64-obsd-tdep.c: Sort headers.
10333         * amd64-obsd-nat.c: Sort headers.
10334         * amd64-nbsd-tdep.c: Sort headers.
10335         * amd64-nbsd-nat.c: Sort headers.
10336         * amd64-nat.c: Sort headers.
10337         * amd64-linux-tdep.c: Sort headers.
10338         * amd64-linux-nat.c: Sort headers.
10339         * amd64-fbsd-tdep.c: Sort headers.
10340         * amd64-fbsd-nat.c: Sort headers.
10341         * amd64-dicos-tdep.c: Sort headers.
10342         * amd64-darwin-tdep.c: Sort headers.
10343         * amd64-bsd-nat.c: Sort headers.
10344         * alpha-tdep.c: Sort headers.
10345         * alpha-obsd-tdep.c: Sort headers.
10346         * alpha-nbsd-tdep.c: Sort headers.
10347         * alpha-mdebug-tdep.c: Sort headers.
10348         * alpha-linux-tdep.c: Sort headers.
10349         * alpha-linux-nat.c: Sort headers.
10350         * alpha-bsd-tdep.c: Sort headers.
10351         * alpha-bsd-nat.c: Sort headers.
10352         * aix-thread.c: Sort headers.
10353         * agent.c: Sort headers.
10354         * addrmap.c: Sort headers.
10355         * ada-varobj.c: Sort headers.
10356         * ada-valprint.c: Sort headers.
10357         * ada-typeprint.c: Sort headers.
10358         * ada-tasks.c: Sort headers.
10359         * ada-lang.c: Sort headers.
10360         * aarch64-tdep.c: Sort headers.
10361         * aarch64-ravenscar-thread.c: Sort headers.
10362         * aarch64-newlib-tdep.c: Sort headers.
10363         * aarch64-linux-tdep.c: Sort headers.
10364         * aarch64-linux-nat.c: Sort headers.
10365         * aarch64-fbsd-tdep.c: Sort headers.
10366         * aarch64-fbsd-nat.c: Sort headers.
10367         * aarch32-linux-nat.c: Sort headers.
10368
10369 2019-04-04  Tom Tromey  <tom@tromey.com>
10370
10371         * varobj.c (varobj_create): Update.
10372         * rust-exp.y (struct rust_parser) <update_innermost_block,
10373         lookup_symbol>: New methods.
10374         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10375         Rename.
10376         (rust_parser::rust_lookup_type)
10377         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10378         * printcmd.c (display_command, do_one_display): Update.
10379         * parser-defs.h (struct parser_state) <parser_state>: Add
10380         "tracker" parameter.
10381         (block_tracker): New member.
10382         (class innermost_block_tracker) <innermost_block_tracker>: Add
10383         "types" parameter.
10384         <reset>: Remove method.
10385         (innermost_block): Don't declare.
10386         (null_post_parser): Update.
10387         * parse.c (innermost_block): Remove global.
10388         (write_dollar_variable): Update.
10389         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10390         Remove "tracker_types" parameter.
10391         (parse_expression): Add "tracker" parameter.
10392         (parse_expression_for_completion): Update.
10393         (null_post_parser): Add "tracker" parameter.
10394         * p-exp.y: Update rules.
10395         * m2-exp.y: Update rules.
10396         * language.h (struct language_defn) <la_post_parser>: Add
10397         "tracker" parameter.
10398         * go-exp.y: Update rules.
10399         * f-exp.y: Update rules.
10400         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10401         parameter.
10402         * d-exp.y: Update rules.
10403         * c-exp.y: Update rules.
10404         * breakpoint.c (set_breakpoint_condition): Create an
10405         innermost_block_tracker.
10406         (watch_command_1): Likewise.
10407         * ada-lang.c (resolve): Add "tracker" parameter.
10408         (resolve_subexp): Likewise.
10409         * ada-exp.y (write_var_from_sym): Update.
10410
10411 2019-04-04  Tom Tromey  <tom@tromey.com>
10412
10413         * type-stack.h: New file.
10414         * type-stack.c: New file.
10415         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10416         type-stack.h.
10417         (insert_into_type_stack, insert_type, push_type, push_type_int)
10418         (insert_type_address_space, pop_type, pop_type_int)
10419         (pop_typelist, pop_type_stack, append_type_stack)
10420         (push_type_stack, get_type_stack, push_typelist)
10421         (follow_type_instance_flags, follow_types): Don't declare.
10422         * parse.c (type_stack): Remove global.
10423         (parse_exp_in_context): Update.
10424         (insert_into_type_stack, insert_type, push_type, push_type_int)
10425         (insert_type_address_space, pop_type, pop_type_int)
10426         (pop_typelist, pop_type_stack, append_type_stack)
10427         (push_type_stack, get_type_stack, push_typelist)
10428         (follow_type_instance_flags, follow_types): Remove (moved to
10429         type-stack.c).
10430         * f-exp.y (type_stack): New global.
10431         Update rules.
10432         (push_kind_type, f_parse): Update.
10433         * d-exp.y (type_stack): New global.
10434         Update rules.
10435         (d_parse): Update.
10436         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10437         Update rules.
10438         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10439         (HFILES_NO_SRCDIR): Add type-stack.h.
10440
10441 2019-04-04  Tom Tromey  <tom@tromey.com>
10442
10443         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10444         (rust_parser::convert_ast_to_expression, rust_parse)
10445         (rust_lex_test_completion, rust_lex_tests): Update.
10446         * parser-defs.h (struct expr_completion_state): New.
10447         (struct parser_state) <parser_state>: Add completion parameter.
10448         <mark_struct_expression, mark_completion_tag>: New methods.
10449         <parse_completion, m_completion_state>: New members.
10450         (prefixify_expression, null_post_parser): Update.
10451         (mark_struct_expression, mark_completion_tag): Don't declare.
10452         * parse.c (parse_completion, expout_last_struct)
10453         (expout_tag_completion_type, expout_completion_name): Remove
10454         globals.
10455         (parser_state::mark_struct_expression)
10456         (parser_state::mark_completion_tag): Now methods.
10457         (prefixify_expression): Add last_struct parameter.
10458         (prefixify_subexp): Likewise.
10459         (parse_exp_1): Update.
10460         (parse_exp_in_context): Add cstate parameter.  Update.
10461         (parse_expression_for_completion): Create an
10462         expr_completion_state.
10463         (null_post_parser): Add "completion" parameter.
10464         * p-exp.y: Update rules.
10465         (yylex): Update.
10466         * language.h (struct language_defn) <la_post_parser>: Add
10467         "completing" parameter.
10468         * go-exp.y: Update rules.
10469         (lex_one_token): Update.
10470         * expression.h (parse_completion): Don't declare.
10471         * d-exp.y: Update rules.
10472         (lex_one_token): Update rules.
10473         * c-exp.y: Update rules.
10474         (lex_one_token): Update.
10475         * ada-lang.c (resolve): Add "parse_completion" parameter.
10476         (resolve_subexp): Likewise.
10477         (ada_resolve_function): Likewise.
10478
10479 2019-04-04  Tom Tromey  <tom@tromey.com>
10480
10481         * parser-defs.h (struct parser_state) <start_arglist,
10482         end_arglist>: New methods.
10483         <arglist_len, m_funcall_chain>: New members.
10484         (arglist_len, start_arglist, end_arglist): Don't declare.
10485         * parse.c (arglist_len, funcall_chain): Remove global.
10486         (start_arglist, end_arglist): Remove functions.
10487         (parse_exp_in_context): Update.
10488         * p-exp.y: Update rules.
10489         * m2-exp.y: Update rules.
10490         * go-exp.y: Update rules.
10491         * f-exp.y: Update rules.
10492         * d-exp.y: Update rules.
10493         * c-exp.y: Update rules.
10494
10495 2019-04-04  Tom Tromey  <tom@tromey.com>
10496
10497         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10498         lex_operator, push_back>: New methods.
10499         Update all rules.
10500         (rust_parser::lex_hex, lex_escape): Rename and update.
10501         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10502         (rust_parser::lex_operator): Rename and update.
10503         (rust_parser::lex_number, rustyylex, rustyyerror)
10504         (rust_lex_test_init, rust_lex_test_sequence)
10505         (rust_lex_test_push_back, rust_lex_tests): Update.
10506         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10507         parameter.
10508         <lexptr, prev_lexptr>: New members.
10509         (lexptr, prev_lexptr): Don't declare.
10510         * parse.c (lexptr, prev_lexptr): Remove globals.
10511         (parse_exp_in_context): Update.
10512         * p-exp.y (yylex, yyerror): Update.
10513         * m2-exp.y (parse_number, yylex, yyerror): Update.
10514         * go-exp.y (lex_one_token, yyerror): Update.
10515         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10516         * d-exp.y (lex_one_token, yyerror): Update.
10517         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10518         (lex_one_token, yyerror): Update.
10519         * ada-lex.l (YY_INPUT): Update.
10520         (rewind_to_char): Update.
10521         * ada-exp.y (yyerror): Update.
10522
10523 2019-04-04  Tom Tromey  <tom@tromey.com>
10524
10525         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10526         * parser-defs.h (struct parser_state) <parser_state>: Add new
10527         parameter.
10528         <comma_terminates>: New member.
10529         (comma_terminates): Don't declare global.
10530         * parse.c (comma_terminates): Remove global.
10531         (parse_exp_in_context): Update.
10532         * p-exp.y (yylex): Update.
10533         * m2-exp.y (yylex): Update.
10534         * go-exp.y (lex_one_token): Update.
10535         * f-exp.y (yylex): Update.
10536         * d-exp.y (lex_one_token): Update.
10537         * c-exp.y (lex_one_token): Update.
10538         * ada-lex.l: Update.
10539
10540 2019-04-04  Tom Tromey  <tom@tromey.com>
10541
10542         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10543         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10544         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10545         * parser-defs.h (paren_depth): Don't declare.
10546         * parse.c (paren_depth): Remove global.
10547         (parse_exp_in_context): Update.
10548         * p-exp.y (paren_depth): New global.
10549         (pascal_parse): Initialize it.
10550         * m2-exp.y (paren_depth): New global.
10551         (m2_parse): Initialize it.
10552         * go-exp.y (paren_depth): New global.
10553         (go_parse): Initialize it.
10554         * f-exp.y (paren_depth): New global.
10555         (f_parse): Initialize it.
10556         * d-exp.y (paren_depth): New global.
10557         (d_parse): Initialize it.
10558         * c-exp.y (paren_depth): New global.
10559         (c_parse): Initialize it.
10560         * ada-lex.l (paren_depth): New global.
10561         (lexer_init): Initialize it.
10562
10563 2019-04-04  Tom Tromey  <tom@tromey.com>
10564
10565         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10566         (rust_parser::convert_ast_to_type)
10567         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10568         * parser-defs.h (struct parser_state) <parser_state>: Add
10569         parameters.  Initialize new members.
10570         <expression_context_block, expression_context_pc>: New members.
10571         * parse.c (expression_context_block, expression_context_pc):
10572         Remove globals.
10573         (parse_exp_in_context): Update.
10574         * p-exp.y: Update all rules.
10575         (yylex): Update.
10576         * m2-exp.y: Update all rules.
10577         (yylex): Update.
10578         * go-exp.y (yylex): Update.
10579         * f-exp.y (yylex): Update.
10580         * d-exp.y: Update all rules.
10581         (yylex): Update.
10582         * c-exp.y: Update all rules.
10583         (lex_one_token, classify_name, yylex, c_parse): Update.
10584         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10585
10586 2019-04-04  Tom Tromey  <tom@tromey.com>
10587
10588         * gdbarch.h, gdbarch.c: Rebuild.
10589         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10590         * stap-probe.h:
10591         (struct stap_parse_info): Replace "parser_state" with
10592         "expr_builder".
10593         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10594         (parser_state): New class.
10595         * parse.c (expr_builder): Rename.
10596         (expr_builder::release): Rename.
10597         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10598         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10599         (write_exp_elt_longcst, write_exp_elt_floatcst)
10600         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10601         (write_exp_string_vector, write_exp_bitstring)
10602         (write_exp_msymbol, mark_struct_expression)
10603         (write_dollar_variable)
10604         (insert_type_address_space, increase_expout_size): Replace
10605         "parser_state" with "expr_builder".
10606         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10607         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10608         "parser_state" with "expr_builder".
10609
10610 2019-04-04  Tom Tromey  <tom@tromey.com>
10611
10612         * rust-exp.y: Replace "parse_language" with method call.
10613         * p-exp.y:
10614         (yylex): Replace "parse_language" with method call.
10615         * m2-exp.y:
10616         (yylex): Replace "parse_language" with method call.
10617         * go-exp.y (classify_name): Replace "parse_language" with method
10618         call.
10619         * f-exp.y (yylex): Replace "parse_language" with method call.
10620         * d-exp.y (lex_one_token): Replace "parse_language" with method
10621         call.
10622         * c-exp.y:
10623         (lex_one_token, classify_name, yylex): Replace "parse_language"
10624         with method call.
10625         * ada-exp.y (find_primitive_type, type_char)
10626         (type_system_address): Replace "parse_language" with method call.
10627
10628 2019-04-04  Tom Tromey  <tom@tromey.com>
10629
10630         * rust-exp.y: Replace "parse_gdbarch" with method call.
10631         * parse.c (write_dollar_variable, insert_type_address_space):
10632         Replace "parse_gdbarch" with method call.
10633         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10634         call.
10635         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10636         call.
10637         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10638         "parse_gdbarch" with method call.
10639         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10640         with method call.
10641         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10642         "parse_gdbarch" with method call.
10643         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10644         "parse_gdbarch" with method call.
10645         * c-exp.y (parse_type, parse_number, classify_name): Replace
10646         "parse_gdbarch" with method call.
10647         * ada-lex.l: Replace "parse_gdbarch" with method call.
10648         * ada-exp.y (parse_type, find_primitive_type, type_char)
10649         (type_system_address): Replace "parse_gdbarch" with method call.
10650
10651 2019-04-04  Tom Tromey  <tom@tromey.com>
10652
10653         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10654         * stap-probe.c (stap_parse_argument): Update.
10655         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10656         initial_size parameter.
10657         * rust-exp.y (rust_lex_tests): Update.
10658         * parse.c (parser_state): Update.
10659         (parse_exp_in_context): Update.
10660         * parser-defs.h (struct parser_state) <parser_state>: Remove
10661         "initial_size" parameter.
10662
10663 2019-04-04  Tom Tromey  <tom@tromey.com>
10664
10665         * parser-defs.h (increase_expout_size): Don't declare.
10666         * parse.c (increase_expout_size): Now static.
10667
10668 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10669
10670         * gnu-nat.c (gnu_nat_target::wait): Fix
10671         target_waitstatus_to_string call.
10672
10673 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10674
10675         * eval.c (evaluate_subexp_standard): Handle internal functions
10676         during Fortran function call handling.
10677
10678 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10679
10680         * NEWS: Mention new internal functions.
10681         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10682         (read_base_type): Use dwarf2_init_complex_target_type.
10683         * value.c (creal_internal_fn): New function.
10684         (cimag_internal_fn): New function.
10685         (_initialize_values): Register new internal functions.
10686
10687 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10688
10689         * infrun.c (stop_all_threads): If debug_infrun, always
10690         trace the wait status after wait_one, using
10691         target_waitstatus_to_string and target_pid_to_str.
10692         (handle_inferior_event): Replace various trace of
10693         wait status kind by a single trace.
10694         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10695         wait status kind image by target_waitstatus_to_string.
10696         * target/waitstatus.c (target_waitstatus_to_string): Fix
10697         obsolete comment.
10698
10699 2019-04-01  Tom Tromey  <tromey@adacore.com>
10700
10701         PR symtab/23331:
10702         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10703
10704 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10705             Pedro Alves  <palves@redhat.com>
10706
10707         * top.c (quit_force): Call 'finalize_values'.
10708         * value.c (finalize_values): New function.
10709         * value.h (finalize_values): Declare.
10710
10711 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10712
10713         * NEWS: Announce $_gdb_major and $_gdb_minor.
10714
10715         * top.c (init_gdb_version_vars): New function.
10716         (gdb_init): Call init_gdb_version_vars.
10717
10718 2019-03-29  Tom Tromey  <tromey@adacore.com>
10719
10720         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10721         help text.  Remove dead code.
10722
10723 2019-03-29  Keith Seitz  <keiths@redhat.com>
10724
10725         From Siddhesh Poyarekar:
10726         * f-lang.h (f77_get_upperbound): Return LONGEST.
10727         (f77_get_lowerbound): Likewise.
10728         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10729         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10730         print them.
10731         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10732         plongest to format print it.
10733         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10734         (f77_get_upperbound): Likewise.
10735         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10736         LOWER_BOUND to LONGEST.
10737         (f77_create_arrayprint_offset_tbl): Likewise.
10738
10739 2019-03-29  Keith Seitz  <keiths@redhat.com>
10740
10741         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10742         %s/pulongest for TYPE_LENGTH instead of %d in format
10743         strings.
10744         * ada-typerint.c (ada_print_type): Likewise.
10745         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10746         * compile/compile-c-support.c (generate_register_struct): Likewise.
10747         * gdbtypes.c (recursive_dump_type): Likewise.
10748         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10749         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10750         instead of %d in format strings.
10751         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10752         to std::min to ULONGEST.
10753         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10754         instead of %d in format strings.
10755         * tracepoint.c (info_scope_command): Likewise.
10756         * typeprint.c (print_offset_data::update)
10757         (print_offset_data::finish): Likewise.
10758         * xtensa-tdep.c (xtensa_store_return_value)
10759         (xtensa_push_dummy_call): Likewise.
10760
10761 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10762
10763         * windows-nat.c (display_selector): Fixed format specifications
10764         for 64-bit Cygwin.
10765
10766 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10767
10768         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10769
10770 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10771
10772         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10773         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10774         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10775         (nios2_linux_init_abi): Install it.
10776
10777 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10778
10779         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10780
10781 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10782
10783         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10784
10785 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10786             Tom Tromey  <tromey@adacore.com>
10787
10788         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10789
10790 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10791
10792         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10793         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10794         method to compute the bounds of range types. Also print "[evaluated]"
10795         if the bounds' values come from a dynamic evaluation.
10796
10797 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10798
10799         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10800         whitespace when pretty printing is on.
10801
10802 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10803
10804         * ppc-linux-nat.c: Add include.
10805
10806 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10807
10808         * NEWS: Mention AArch64 Pointer Authentication.
10809
10810 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10811
10812         * arm-linux-nat.c: Add include.
10813
10814 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10815
10816         * source-cache.c (source_cache::get_source_lines): Re-read
10817         fullname after calling open_source_file.
10818
10819 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10820
10821         * NEWS: Mention TLS support for FreeBSD.
10822
10823 2019-03-25  Tom Tromey  <tromey@adacore.com>
10824
10825         * minsyms.c (BUNCH_SIZE): Update comment.
10826         (~minimal_symbol_reader): Remove old comment.
10827         (compact_minimal_symbols): Update comment.
10828         (minimal_symbol_reader::install): Remove old comment.  Update
10829         other comments.
10830
10831 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10832
10833         * s390-linux-nat.c: Add include.
10834
10835 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10836
10837         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10838         Call linux_get_hwcap.
10839         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10840         Likewise.
10841         (aarch64_linux_get_hwcap): Remove function.
10842         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10843         declaration.
10844         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10845         linux_get_hwcap.
10846         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10847         * linux-tdep.c (linux_get_hwcap): Add function.
10848         (linux_get_hwcap2): Likewise.
10849         * linux-tdep.h (linux_get_hwcap): Add declaration.
10850         (linux_get_hwcap2): Likewise.
10851         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10852         (ppc_linux_get_hwcap2): Likewise.
10853         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10854         linux_get_hwcap.
10855         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10856         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10857         (ppc_linux_nat_target::read_description): Likewise.
10858         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10859         * s390-linux-nat.c: Likewise.
10860         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10861
10862 2019-03-24  Tom Tromey  <tom@tromey.com>
10863
10864         * ada-lang.c (standard_lookup): Simplify initialization.
10865         (ada_lookup_symbol_nonlocal): Simplify return.
10866         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10867         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10868         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10869         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10870         initialization.
10871         * solib.c (solib_global_lookup): Simplify.
10872         * symtab.c (null_block_symbol): Remove.
10873         (symbol_cache_lookup): Simplify returns.
10874         (lookup_language_this): Simplify returns.
10875         (lookup_symbol_aux): Simplify return.
10876         (lookup_local_symbol): Simplify returns.
10877         (lookup_global_symbol_from_objfile): Simplify return.
10878         (lookup_symbol_in_objfile_symtabs)
10879         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10880         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10881         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10882         * cp-namespace.c (cp_lookup_bare_symbol)
10883         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10884         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10885         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10886         (cp_lookup_symbol_via_imports): Simplify initialization.
10887         (find_symbol_in_baseclass): Likewise.
10888         * symtab.h (null_block_symbol): Remove.
10889         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10890         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10891         (d_lookup_symbol_module): Likewise.
10892         (find_symbol_in_baseclass): Simplify initialization.
10893
10894 2019-03-24  Tom Tromey  <tom@tromey.com>
10895
10896         * expression.h: Don't include symtab.h.
10897         (struct block): Forward declare.
10898
10899 2019-03-24  Tom Tromey  <tom@tromey.com>
10900
10901         * c-exp.y (typebase): Remove casts.
10902         * gdbtypes.c (lookup_unsigned_typename, )
10903         (lookup_signed_typename): Remove cast.
10904         * eval.c (parse_to_comma_and_eval): Remove cast.
10905         * parse.c (write_dollar_variable): Remove cast.
10906         * block.h (struct block) <superblock>: Now const.
10907         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10908         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10909         (map_block): Make "block" const.
10910         * symfile.h (struct quick_symbol_functions)
10911         <map_matching_symbols>: Constify block argument to "callback".
10912         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10913         const.
10914         (find_pc_sect_compunit_symtab): Make "b" const.
10915         (find_symbol_at_address): Likewise.
10916         (search_symbols): Likewise.
10917         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10918         (dw2_debug_names_lookup_symbol): Likewise.
10919         (dw2_map_matching_symbols): Update.
10920         * p-valprint.c (pascal_val_print): Remove "block".
10921         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10922         (aux_add_nonlocal_symbols): Make "block" const.
10923         (resolve_subexp): Remove cast.
10924         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10925         const.
10926         (iterate_over_file_blocks): Likewise.
10927         * f-exp.y (%union) <bval>: Remove.
10928         * coffread.c (patch_opaque_types): Make "b" const.
10929         * spu-tdep.c (spu_catch_start): Make "block" const.
10930         * c-valprint.c (print_unpacked_pointer): Remove "block".
10931         * symmisc.c (dump_symtab_1): Make "b" const.
10932         (block_depth): Make "block" const.
10933         * d-exp.y (%union) <bval>: Remove.
10934         * cp-support.h (cp_lookup_rtti_type): Update.
10935         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10936         * psymtab.c (psym_lookup_symbol): Make "block" const.
10937         (maintenance_check_psymtabs): Make "b" const.
10938         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10939         (enumerate_locals, enumerate_args): Update.
10940         * python/py-symtab.c (stpy_global_block): Make "block" const.
10941         (stpy_static_block): Likewise.
10942         * inline-frame.c (block_starting_point_at): Make "new_block"
10943         const.
10944         * block.c (find_block_in_blockvector): Make return type const.
10945         (blockvector_for_pc_sect): Make "b" const.
10946         (find_block_in_blockvector): Make "b" const.
10947
10948 2019-03-23  Tom Tromey  <tom@tromey.com>
10949
10950         * varobj.c (varobj_create): Update.
10951         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10952         * printcmd.c (display_command, do_one_display): Don't reset
10953         innermost_block.
10954         * parser-defs.h (enum innermost_block_tracker_type): Move to
10955         expression.h.
10956         (innermost_block): Update comment.
10957         * parse.c (parse_exp_1): Add tracker_types parameter.
10958         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10959         tracker_types parameter.  Reset innermost_block.
10960         (parse_exp_in_context): Remove.
10961         (parse_expression_for_completion): Update.
10962         * objfiles.c (~objfile): Don't reset expression_context_block or
10963         innermost_block.
10964         * expression.h (enum innermost_block_tracker_type): Move from
10965         parser-defs.h.
10966         (parse_exp_1): Add tracker_types parameter.
10967         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10968         reset innermost_block.
10969
10970 2019-03-23  Tom Tromey  <tom@tromey.com>
10971
10972         * objfiles.h: Include bcache.h.
10973
10974 2019-03-23  Tom Tromey  <tom@tromey.com>
10975
10976         * linespec.c (get_current_search_block): Use
10977         scoped_restore_current_language.
10978         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10979
10980 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10981             Jiong Wang  <jiong.wang@arm.com>
10982
10983         * aarch64-linux-tdep.c
10984         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10985         section.
10986         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10987
10988 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10989             Jiong Wang  <jiong.wang@arm.com>
10990
10991         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10992         instructions.
10993         (aarch64_analyze_prologue_test): Add PACIASP test.
10994         (aarch64_prologue_prev_register): Unmask PC value.
10995
10996 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10997             Jiong Wang  <jiong.wang@arm.com>
10998
10999         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11000         (aarch64_dwarf2_prev_register): Unmask PC value.
11001         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11002         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11003         DW_CFA_AARCH64_negate_ra_state.
11004         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11005
11006 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11007             Jiong Wang  <jiong.wang@arm.com>
11008
11009         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11010         registers.
11011         (aarch64_pseudo_register_name): Likewise.
11012         (aarch64_pseudo_register_type): Likewise.
11013         (aarch64_pseudo_register_reggroup_p): Likewise.
11014         (aarch64_gdbarch_init): Add pauth registers.
11015         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11016         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11017         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11018         (struct gdbarch_tdep): Add regnum for ra_state.
11019
11020 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11021             Jiong Wang  <jiong.wang@arm.com>
11022
11023         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11024
11025 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11026             Jiong Wang  <jiong.wang@arm.com>
11027
11028         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11029         function.
11030         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11031         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11032         (aarch64_gdbarch_init): Add puth registers.
11033         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11034         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11035         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11036
11037 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11038             Jiong Wang  <jiong.wang@arm.com>
11039
11040         * aarch64-linux-nat.c
11041         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11042         * aarch64-linux-tdep.c
11043         (aarch64_linux_core_read_description): Likewise.
11044         (aarch64_linux_get_hwcap): New function.
11045         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11046         (aarch64_linux_get_hwcap): New declaration.
11047
11048 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11049             Jiong Wang  <jiong.wang@arm.com>
11050
11051         * aarch64-linux-nat.c
11052         (aarch64_linux_nat_target::read_description): Add pauth param.
11053         * aarch64-linux-tdep.c
11054         (aarch64_linux_core_read_description): Likewise.
11055         * aarch64-tdep.c (struct target_desc): Add in pauth.
11056         (aarch64_read_description): Add pauth param.
11057         (aarch64_gdbarch_init): Likewise.
11058         * aarch64-tdep.h (aarch64_read_description): Likewise.
11059         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11060         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11061         * features/Makefile: Add new files.
11062         * features/aarch64-pauth.c: New file.
11063         * features/aarch64-pauth.xml: New file.
11064
11065 2019-03-20  Tom Tromey  <tromey@adacore.com>
11066
11067         * infrun.c (handle_inferior_event): Rename from
11068         handle_inferior_event_1.  Create a scoped_value_mark.
11069         (handle_inferior_event): Remove.
11070
11071 2019-03-19  Tom Tromey  <tromey@adacore.com>
11072
11073         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11074         * infrun.h (print_stop_event): Add "displays" parameter.
11075         * infrun.c (print_stop_event): Add "displays" parameter.
11076
11077 2019-03-19  Pedro Alves  <palves@redhat.com>
11078
11079         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11080         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11081         to -1.  Fix TABs vs spaces.
11082         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11083         * tui/tui-out.h (tui_ui_out) Add intro comments.
11084         <m_line, m_start_of_line>: In-class initialize, and add describing
11085         comment.
11086
11087 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11088
11089         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11090         variable names.
11091         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11092
11093 2019-03-18  Pedro Alves  <palves@redhat.com>
11094             Eli Zaretskii <eliz@gnu.org>
11095
11096         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11097         m_line and m_start_of_line.
11098
11099 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11100
11101         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11102         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11103         it returns a newline.  This fixes a regression in TU mode, whereby
11104         the next line is output on the same screen line as the user input.
11105
11106 2019-03-18  Tom Tromey  <tromey@adacore.com>
11107
11108         * minsyms.c (minimal_symbol_reader::install): Remove call to
11109         obstack_blank.
11110
11111 2019-03-18  Pedro Alves  <palves@redhat.com>
11112
11113         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11114         New globals.
11115         (apply_style): New, factored out from ...
11116         (apply_ansi_escape): ... this.  Handle reverse video mode.
11117         (tui_set_reverse_mode): New function.
11118         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11119         * tui/tui-winsource.c (tui_show_source_line): Use
11120         tui_set_reverse_mode instead of setting A_STANDOUT.
11121         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11122         New setter methods.
11123
11124 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11125
11126         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11127         Handle tabs.
11128
11129 2019-03-18  Tom Tromey  <tromey@adacore.com>
11130
11131         * ada-lang.c (empty_array): Add "high" parameter.
11132         (ada_evaluate_subexp): Update.
11133
11134 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11135
11136         * unittests/string_view-selftests.c: Define
11137         _initialize_string_view_selftests unconditionally.
11138
11139 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11140
11141         PR gdb/24350
11142         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11143
11144 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11145
11146         PR gdb/24351
11147         * windows-nat.c (display_selector): Fix format specifiers.
11148
11149 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11150
11151         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11152         tui_refill_source_window instead of tui_refresh_win, to update the
11153         current execution line.  This fixes redisplay of the current line
11154         when stepping through the code with "next" or "step".
11155
11156 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11157
11158         * source-cache.c (source_cache::get_source_lines): Call
11159         find_source_lines to initialize s->nlines.  This fixes vertical
11160         scrolling of TUI source window when the DOWN arrow is pressed.
11161
11162 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11163
11164         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11165         linux-thread-db.c (_initialize_thread_db): Likewise.
11166
11167 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11168
11169         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11170         wclrtoeol in tui_show_source_line".  This reverts changes made in
11171         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11172
11173 2019-03-15  Tom Tromey  <tom@tromey.com>
11174
11175         * symtab.h (struct minimal_symbol): Derive from
11176         general_symbol_info.
11177         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11178         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11179         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11180         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11181         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11182         (MSYMBOL_SEARCH_NAME): Update.
11183         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11184         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11185         * minsyms.c (minimal_symbol_reader::record_full): Update.
11186
11187 2019-03-15  Tom Tromey  <tom@tromey.com>
11188
11189         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11190
11191 2019-03-15  Tom Tromey  <tom@tromey.com>
11192
11193         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11194         unique_xmalloc_ptr.
11195         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11196         Update.
11197         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11198         (build_minimal_symbol_hash_tables)
11199         (minimal_symbol_reader::install): Update.
11200
11201 2019-03-15  Tom Tromey  <tom@tromey.com>
11202
11203         * symtab.c (create_demangled_names_hash): Update.
11204         (symbol_set_names): Update.
11205         * objfiles.h (struct objfile_per_bfd_storage)
11206         <demangled_names_hash>: Now an htab_up.
11207         * objfiles.c (objfile_per_bfd_storage): Simplify.
11208
11209 2019-03-15  Tom Tromey  <tom@tromey.com>
11210
11211         * objfiles.h (struct objfile_per_bfd_storage): Declare
11212         destructor.
11213         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11214         New.
11215         (get_objfile_bfd_data): Use new.  Don't initialize
11216         language_of_main.
11217         (free_objfile_per_bfd_storage): Remove.
11218         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11219
11220 2019-03-15  Tom Tromey  <tom@tromey.com>
11221
11222         * symfile.c (reread_symbols): Update.
11223         * objfiles.c (objfile::objfile): Update.
11224         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11225         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11226         comment.
11227         (minimal_symbol_reader::install): Update.
11228         (terminate_minimal_symbol_table): Remove.
11229         * jit.c (jit_object_close_impl): Update.
11230
11231 2019-03-15  Tom Tromey  <tom@tromey.com>
11232
11233         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11234         initializations.
11235
11236 2019-03-15  Tom Tromey  <tom@tromey.com>
11237
11238         * objfiles.h (struct objfile_per_bfd_storage)
11239         <demangled_hash_languages>: Now a bitset.
11240         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11241         (lookup_minimal_symbol): Update.
11242
11243 2019-03-15  Tom Tromey  <tom@tromey.com>
11244
11245         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11246         Don't return the symbol.
11247         * coffread.c (record_minimal_symbol): Use record_full.
11248
11249 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11250
11251         The MS-Windows port of ncurses fails to switch to a color pair if
11252         one or both of the colors are the implicit default colors.  This
11253         change records the default colors when TUI is initialized, and
11254         then specifies them explicitly when a color pair uses the default
11255         colors.  This allows color styling in TUI mode on MS-Windows.
11256
11257         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11258         ncurses_norm_attr.
11259         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11260         colors in ncurses_norm_attr.
11261         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11262         "none", replace it with the default color recorded in
11263         ncurses_norm_attr.
11264
11265 2019-03-14  Tom Tromey  <tromey@adacore.com>
11266
11267         * source-cache.h (class source_cache) <get_source_lines>: Return
11268         std::string.
11269         * source-cache.c (source_cache::extract_lines): Handle case where
11270         first_pos==npos.  Return std::string.
11271         (source_cache::get_source_lines): Update.
11272
11273 2019-03-14  Tom Tromey  <tromey@adacore.com>
11274
11275         * NEWS: Add item for "style sources" commands.
11276         * source-cache.c (source_cache::get_source_lines): Check
11277         source_styling.
11278         * cli/cli-style.c (source_styling): New global.
11279         (_initialize_cli_style): Add "style sources" commands.
11280         (show_style_sources): New function.
11281         * cli/cli-style.h (source_styling): Declare.
11282
11283 2019-03-14  Pedro Alves  <palves@redhat.com>
11284             Tom Tromey  <tromey@adacore.com>
11285
11286         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11287         * tui/tui-winsource.c (tui_refill_source_window): New function,
11288         from...
11289         (tui_horizontal_source_scroll): ... here.  Move some logic.
11290         * cli/cli-style.c (set_style_enabled): Notify new observable.
11291         * tui/tui-hooks.c (tui_redisplay_source): New function.
11292         (tui_attach_detach_observers): Attach or detach
11293         tui_redisplay_source.
11294         * observable.h (source_styling_changed): New observable.
11295         * observable.c: Define source_styling_changed observable.
11296
11297 2019-03-13  Tom Tromey  <tromey@adacore.com>
11298
11299         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11300         (i386_gnu_nat_target::store_registers): Update.
11301         * target-debug.h (target_debug_print_std_string): New macro.
11302         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11303         * windows-tdep.c (display_one_tib): Update.
11304         * tui/tui-stack.c (tui_make_status_line): Update.
11305         * top.c (print_inferior_quit_action): Update.
11306         * thread.c (thr_try_catch_cmd): Update.
11307         (add_thread_with_info): Update.
11308         (thread_target_id_str): Update.
11309         (thr_try_catch_cmd): Update.
11310         (thread_command): Update.
11311         (thread_find_command): Update.
11312         * record-btrace.c (record_btrace_target::info_record)
11313         (record_btrace_resume_thread, record_btrace_target::resume)
11314         (record_btrace_cancel_resume, record_btrace_step_thread)
11315         (record_btrace_target::wait, record_btrace_target::wait)
11316         (record_btrace_target::wait, record_btrace_target::stop): Update.
11317         * progspace.c (print_program_space): Update.
11318         * process-stratum-target.c
11319         (process_stratum_target::thread_address_space): Update.
11320         * linux-fork.c (linux_fork_mourn_inferior)
11321         (detach_checkpoint_command, info_checkpoints_command)
11322         (linux_fork_context): Update.
11323         (linux_fork_detach): Update.
11324         (class scoped_switch_fork_info): Update.
11325         (delete_checkpoint_command): Update.
11326         * infrun.c (follow_fork_inferior): Update.
11327         (follow_fork_inferior): Update.
11328         (proceed_after_vfork_done): Update.
11329         (handle_vfork_child_exec_or_exit): Update.
11330         (follow_exec): Update.
11331         (displaced_step_prepare_throw): Update.
11332         (displaced_step_restore): Update.
11333         (start_step_over): Update.
11334         (resume_1): Update.
11335         (clear_proceed_status_thread): Update.
11336         (proceed): Update.
11337         (print_target_wait_results): Update.
11338         (do_target_wait): Update.
11339         (context_switch): Update.
11340         (stop_all_threads): Update.
11341         (restart_threads): Update.
11342         (finish_step_over): Update.
11343         (handle_signal_stop): Update.
11344         (switch_back_to_stepped_thread): Update.
11345         (keep_going_pass_signal): Update.
11346         (print_exited_reason): Update.
11347         (normal_stop): Update.
11348         * inferior.c (inferior_pid_to_str): Change return type.
11349         (print_selected_inferior): Update.
11350         (add_inferior): Update.
11351         (detach_inferior): Update.
11352         * dummy-frame.c (fprint_dummy_frames): Update.
11353         * dcache.c (dcache_info_1): Update.
11354         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11355         (btrace_fetch, btrace_clear): Update.
11356         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11357         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11358         type.
11359         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11360         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11361         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11362         * gdbarch.c, gdbarch.h: Rebuild.
11363         * gdbarch.sh (core_pid_to_str): Change return type.
11364         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11365         return type.
11366         (windows_nat_target::pid_to_str): Change return type.
11367         (windows_delete_thread): Update.
11368         (windows_nat_target::attach): Update.
11369         (windows_nat_target::files_info): Update.
11370         * target-delegates.c: Rebuild.
11371         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11372         return type.
11373         (sol_thread_target::pid_to_str): Change return type.
11374         * remote.c (class remote_target) <pid_to_str>: Change return
11375         type.
11376         (remote_target::pid_to_str): Change return type.
11377         (extended_remote_target::attach, remote_target::remote_stop_ns)
11378         (remote_target::remote_notif_remove_queued_reply)
11379         (remote_target::push_stop_reply, remote_target::disable_btrace):
11380         Update.
11381         (extended_remote_target::attach): Update.
11382         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11383         type.
11384         (gdbsim_target::pid_to_str): Change return type.
11385         * ravenscar-thread.c (struct ravenscar_thread_target)
11386         <pid_to_str>: Change return type.
11387         (ravenscar_thread_target::pid_to_str): Change return type.
11388         * procfs.c (class procfs_target) <pid_to_str>: Change return
11389         type.
11390         (procfs_target::pid_to_str): Change return type.
11391         (procfs_target::attach): Update.
11392         (procfs_target::detach): Update.
11393         (procfs_target::fetch_registers): Update.
11394         (procfs_target::store_registers): Update.
11395         (procfs_target::wait): Update.
11396         (procfs_target::files_info): Update.
11397         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11398         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11399         return type.
11400         (nto_procfs_target::pid_to_str): Change return type.
11401         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11402         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11403         return type.
11404         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11405         (exit_lwp): Update.
11406         (attach_proc_task_lwp_callback, get_detach_signal)
11407         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11408         (linux_nat_target::resume, wait_lwp, stop_callback)
11409         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11410         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11411         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11412         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11413         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11414         type.
11415         (inf_ptrace_target::attach): Update.
11416         (inf_ptrace_target::files_info): Update.
11417         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11418         type.
11419         (go32_nat_target::pid_to_str): Change return type.
11420         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11421         (gnu_nat_target::wait): Update.
11422         (gnu_nat_target::wait): Update.
11423         (gnu_nat_target::resume): Update.
11424         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11425         (fbsd_nat_target::wait): Update.
11426         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11427         type.
11428         (darwin_nat_target::attach): Update.
11429         * corelow.c (class core_target) <pid_to_str>: Change return type.
11430         (core_target::pid_to_str): Change return type.
11431         * target.c (normal_pid_to_str): Change return type.
11432         (default_pid_to_str): Likewise.
11433         (target_pid_to_str): Change return type.
11434         (target_translate_tls_address): Update.
11435         (target_announce_detach): Update.
11436         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11437         return type.
11438         (bsd_uthread_target::pid_to_str): Change return type.
11439         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11440         type.
11441         (bsd_kvm_target::pid_to_str): Change return type.
11442         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11443         return type.
11444         (aix_thread_target::pid_to_str): Change return type.
11445         * target.h (struct target_ops) <pid_to_str>: Change return type.
11446         (target_pid_to_str, normal_pid_to_str): Likewise.
11447         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11448         type.
11449         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11450         type.
11451         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11452         return type.
11453         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11454         type.
11455         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11456         type.
11457         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11458         return type.
11459
11460 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11461
11462         * NEWS: Mention that the new default MI version is 3.  Mention
11463         changes to the output of commands and events that deal with
11464         multi-location breakpoints.
11465         * breakpoint.c: Include "mi/mi-out.h".
11466         (print_one_breakpoint): Change output syntax if using MI version
11467         >= 3.
11468         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11469         New.
11470         (mi_multi_location_breakpoint_output_fixed): New.
11471         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11472         (mi_cmd_fix_multi_location_breakpoint_output): New.
11473         (mi_multi_location_breakpoint_output_fixed): New.
11474         * mi/mi-cmds.c (mi_cmds): Register command
11475         -fix-multi-location-breakpoint-output.
11476         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11477         interpreter "mi".
11478
11479 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11480
11481         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11482         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11483         instantiate mi_ui_out based on interpreter name.
11484         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11485         * mi/mi-main.c (mi_load_progress): Likewise.
11486
11487 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11488
11489         * NEWS: Combine separate "New targets" sections for 8.3.
11490
11491 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11492
11493         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11494         (ppcfbsd_init_abi): Install gdbarch
11495         "fetch_tls_load_module_address" and "get_thread_local_address"
11496         methods.
11497
11498 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11499
11500         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11501         (riscv_fbsd_init_abi): Install gdbarch
11502         "fetch_tls_load_module_address" and "get_thread_local_address"
11503         methods.
11504
11505 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11506
11507         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11508         (i386fbsd_init_abi): Install gdbarch
11509         "fetch_tls_load_module_address" and "get_thread_local_address"
11510         methods.
11511
11512 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11513
11514         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11515         (amd64fbsd_init_abi): Install gdbarch
11516         "fetch_tls_load_module_address" and "get_thread_local_address"
11517         methods.
11518
11519 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11520
11521         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11522         (struct fbsd_pspace_data): New type.
11523         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11524         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11525         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11526         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11527         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11528
11529 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11530
11531         * gdbtypes.c (lookup_struct_elt): New function.
11532         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11533         * gdbtypes.h (struct struct_elt): New type.
11534         (lookup_struct_elt): New prototype.
11535
11536 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11537
11538         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11539         remove disabled code block.
11540
11541 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11542
11543         * gdbarch.sh (get_thread_local_address): New method.
11544         * gdbarch.h, gdbarch.c: Regenerate.
11545         * target.c (target_translate_tls_address): Use
11546         gdbarch_get_thread_local_address if present instead of
11547         target::get_thread_local_address.
11548
11549 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11550
11551         * target.h (target::get_thread_local_address): Update comment.
11552
11553 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11554
11555         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11556         objfile->separate_debug_objfile_backlink if not NULL.
11557
11558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11559
11560         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11561         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11562         (amd64bsd_store_inferior_registers): Likewise.
11563         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11564         Enable segment base registers.
11565         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11566         PT_GETFSBASE and PT_GETGSBASE.
11567         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11568         PT_SETGSBASE.
11569         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11570         segment base registers.
11571         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11572
11573 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11574
11575         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11576         Update calls to i386_target_description to add 'segments'
11577         parameter.
11578         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11579         add segment base registers.
11580         * arch/i386.c (i386_create_target_description): Add 'segments'
11581         parameter to enable segment base registers.
11582         * arch/i386.h (i386_create_target_description): Likewise.
11583         * features/i386/32bit-segments.xml: New file.
11584         * features/i386/32bit-segments.c: Generate.
11585         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11586         call to i386_target_description to add 'segments' parameter.
11587         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11588         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11589         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11590         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11591         if feature is present.
11592         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11593         Add 'segments' parameter to call to i386_target_description.
11594         (i386_target_description): Add 'segments' parameter to enable
11595         segment base registers.
11596         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11597         to call to i386_target_description.
11598         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11599         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11600         Define I386_NUM_REGS.
11601         (i386_target_description): Add 'segments' parameter to enable
11602         segment base registers.
11603
11604 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11605
11606         PR/24325
11607         * source-cache.c: #undef open and close, to avoid unresolved
11608         externals during linking.
11609
11610 2019-03-12  Tom Tromey  <tromey@adacore.com>
11611
11612         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11613         const.  Add initializers.
11614         (_initialize_remote): Don't initialize ptid globals.
11615
11616 2019-03-12  Pedro Alves  <palves@redhat.com>
11617
11618         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11619
11620 2019-03-12  Pedro Alves  <palves@redhat.com>
11621
11622         * cp-name-parser.y (main): Remove unused 'len' variable.
11623
11624 2019-03-12  Tom Tromey  <tromey@adacore.com>
11625
11626         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11627         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11628
11629 2019-03-12  Tom Tromey  <tromey@adacore.com>
11630
11631         * linux-nat.c (iterate_over_lwps): Update.
11632         (stop_callback): Remove parameter.
11633         (stop_wait_callback, detach_callback, resume_set_callback)
11634         (select_singlestep_lwp_callback, set_ignore_sigint)
11635         (status_callback, resumed_callback, resume_clear_callback)
11636         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11637         data parameter.
11638         (linux_nat_target::detach, linux_nat_target::resume)
11639         (linux_stop_and_wait_all_lwps, select_event_lwp)
11640         (linux_nat_filter_event, linux_nat_wait_1)
11641         (linux_nat_target::kill, linux_nat_target::stop)
11642         (linux_nat_target::stop): Update.
11643         (linux_nat_resume_callback): Change type.
11644         (resume_stopped_resumed_lwps, count_events_callback)
11645         (select_event_lwp_callback): Likewise.
11646         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11647         * arm-linux-nat.c (struct update_registers_data): Remove.
11648         (update_registers_callback): Change type.
11649         (arm_linux_insert_hw_breakpoint1): Update.
11650         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11651         parameter.
11652         (x86_linux_dr_set_addr): Update.
11653         (x86_linux_dr_set_control): Update.
11654         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11655         (iterate_over_lwps): Use gdb::function_view.
11656         * nat/aarch64-linux-hw-point.c (struct
11657         aarch64_dr_update_callback_param): Remove.
11658         (debug_reg_change_callback): Change type.
11659         (aarch64_notify_debug_reg_change): Update.
11660         * s390-linux-nat.c (s390_refresh_per_info): Update.
11661
11662 2019-03-11  Tom Tromey  <tromey@adacore.com>
11663
11664         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11665         redundant assignment to "this_cu".
11666
11667 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11668
11669         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11670
11671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11672
11673         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11674         from...
11675         (rank_one_type): ... this.
11676
11677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11678
11679         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11680         from...
11681         (rank_one_type): ... this.
11682
11683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11684
11685         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11686         from...
11687         (rank_one_type): ... this.
11688
11689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11690
11691         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11692         from...
11693         (rank_one_type): ... this.
11694
11695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11696
11697         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11698         from...
11699         (rank_one_type): ... this.
11700
11701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11702
11703         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11704         from...
11705         (rank_one_type): ... this.
11706
11707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11708
11709         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11710         from...
11711         (rank_one_type): ... this.
11712
11713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11714
11715         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11716         from...
11717         (rank_one_type): ... this.
11718
11719 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11720
11721         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11722         from...
11723         (rank_one_type): ... this.
11724
11725 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11726
11727         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11728         from...
11729         (rank_one_type): ... this.
11730
11731 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11732
11733         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11734         from...
11735         (rank_one_type): ... this.
11736
11737 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11738
11739         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11740         from...
11741         (rank_one_type): ... this.
11742
11743 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11744
11745         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11746         inferior-events' shows the example events.
11747
11748 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11749
11750         Support styling on native MS-Windows console
11751
11752         PR/24315
11753         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11754         on MS-Windows if $TERM is not defined.
11755
11756         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11757
11758         * posix-hdep.c (gdb_console_fputs):
11759         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11760         functions.
11761         * ui-file.h (gdb_console_fputs): Add prototype.
11762
11763         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11764         back to fputs only if the former returns zero.
11765
11766 2019-03-07  Tom Tromey  <tom@tromey.com>
11767
11768         * symmisc.c (print_symbol_bcache_statistics): Update.
11769         (print_objfile_statistics): Update.
11770         * symfile.c (allocate_symtab): Update.
11771         * stabsread.c: Don't include bcache.h.
11772         * psymtab.h (struct psymbol_bcache): Don't declare.
11773         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11774         (psymbol_bcache_init, psymbol_bcache_free)
11775         (psymbol_bcache_get_bcache): Don't declare.
11776         * psymtab.c (struct psymbol_bcache): Remove.
11777         (psymtab_storage::psymtab_storage): Update.
11778         (psymtab_storage::~psymtab_storage): Update.
11779         (psymbol_bcache_init, psymbol_bcache_free)
11780         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11781         (add_psymbol_to_bcache): Update.
11782         (allocate_psymtab): Update.
11783         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11784         macro_cache>: No longer pointers.
11785         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11786         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11787         * macrotab.c (macro_bcache): Update.
11788         * macroexp.c: Don't include bcache.h.
11789         * gdbtypes.c (check_types_worklist): Update.
11790         (types_deeply_equal): Remove TRY/CATCH.  Update.
11791         * elfread.c (elf_symtab_read): Update.
11792         * dwarf2read.c: Don't include bcache.h.
11793         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11794         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11795         (print_bcache_statistics, bcache_memory_used): Don't declare.
11796         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11797         methods.  Rename all data members.
11798         * bcache.c (struct bcache): Move to bcache.h.
11799         (bcache::expand_hash_table): Rename from expand_hash_table.
11800         (bcache): Remove.
11801         (bcache::insert): Rename from bcache_full.
11802         (bcache::compare): Rename from bcache_compare.
11803         (bcache_xmalloc): Remove.
11804         (bcache::~bcache): Rename from bcache_xfree.
11805         (bcache::print_statistics): Rename from print_bcache_statistics.
11806         (bcache::memory_used): Rename from bcache_memory_used.
11807
11808 2019-03-07  Pedro Alves  <palves@redhat.com>
11809
11810         * infrun.c (normal_stop): Also check for
11811         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11812
11813 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11814
11815         * f-lang.c (value_from_host_double): Moved to...
11816         * value.c (value_from_host_double): ...here.
11817         * value.h (value_from_host_double): Declare.
11818         * guile/scm-math.c (vlscm_convert_typed_number): Use
11819         value_from_host_double.
11820         (vlscm_convert_number): Likewise.
11821         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11822         * python/py-value.c (convert_value_from_python): Likewise.
11823
11824 2019-03-06  Tom Tromey  <tom@tromey.com>
11825
11826         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11827
11828 2019-03-06  Tom Tromey  <tom@tromey.com>
11829
11830         * utils.h (free_current_contents): Don't declare.
11831         * utils.c (free_current_contents): Remove.
11832
11833 2019-03-06  Tom Tromey  <tom@tromey.com>
11834
11835         * top.c (quit_force): Update.
11836         * main.c (captured_command_loop): Update.
11837         * common/new-op.c (operator new): Update.
11838         * common/common-exceptions.c (struct catcher)
11839         <save_cleanup_chain>: Remove member.
11840         (exceptions_state_mc_init): Update.
11841         (exception_try_scope_entry): Return nullptr.
11842         (exception_try_scope_exit, exception_rethrow)
11843         (throw_exception_sjlj, throw_exception_cxx): Update.
11844         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11845         (all_cleanups, do_cleanups, discard_cleanups)
11846         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11847         (restore_cleanups, restore_final_cleanups): Don't declare.
11848         (do_final_cleanups): Remove parameter.
11849         * common/cleanups.c (cleanup_chain, make_cleanup)
11850         (make_cleanup_dtor, all_cleanups, do_cleanups)
11851         (discard_my_cleanups, discard_cleanups)
11852         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11853         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11854         (null_cleanup): Remove.
11855         (do_final_cleanups): Remove parameter.
11856
11857 2019-03-06  Tom Tromey  <tom@tromey.com>
11858
11859         * remote.c (remote_target::remote_parse_stop_reply): Use
11860         unique_xmalloc_ptr.
11861
11862 2019-03-06  Tom Tromey  <tom@tromey.com>
11863
11864         * stabsread.c (struct stabs_field_info): Rename from field_info.
11865         <list, fnlist>: Add initializers.
11866         <obstack>: New member.
11867         (read_member_functions, read_struct_fields, read_baseclasses):
11868         Allocate on obstack.  Don't use cleanups.
11869         (read_one_struct_field, read_member_functions, read_struct_fields)
11870         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11871         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11872         (read_struct_type): Update.
11873
11874 2019-03-06  Tom Tromey  <tom@tromey.com>
11875
11876         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11877         * common/filestuff.h (make_cleanup_close): Don't declare.
11878         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11879         Remove.
11880
11881 2019-03-06  Tom Tromey  <tom@tromey.com>
11882
11883         * solib-aix.c: Use make_scope_exit.
11884
11885 2019-03-06  Tom Tromey  <tom@tromey.com>
11886
11887         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11888         Use make_scope_exit.
11889
11890 2019-03-06  Tom Tromey  <tom@tromey.com>
11891
11892         * solib-svr4.c (disable_probes_interface): Remove parameter.
11893         (svr4_handle_solib_event): Use make_scope_exit.
11894
11895 2019-03-06  Tom Tromey  <tom@tromey.com>
11896
11897         * remote.c (struct stop_reply_deleter): Remove.
11898         (stop_reply_up): Update.
11899         (struct stop_reply): Derive from notif_event.  Don't typedef.
11900         <regcache>: Now a std::vector.
11901         (stop_reply_xfree): Remove.
11902         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11903         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11904         (remote_target::discard_pending_stop_replies): Use delete.
11905         (remote_target::remote_parse_stop_reply): Update.
11906         (remote_target::process_stop_reply): Update.
11907         * remote-notif.h (struct notif_event): Add virtual destructor.
11908         Remove "dtr" member.
11909         (struct notif_client) <alloc_event>: Return a unique_ptr.
11910         (notif_event_xfree): Don't declare.
11911         (notif_event_up): New typedef.
11912         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11913         (notif_event_xfree, do_notif_event_xfree): Remove.
11914         (remote_notif_state_xfree): Update.
11915
11916 2019-03-06  Tom Tromey  <tom@tromey.com>
11917
11918         * infrun.c (displaced_step_clear_cleanup): Now a
11919         forward_scope_exit type.
11920         (displaced_step_prepare_throw): Update.
11921         (displaced_step_fixup): Update.
11922
11923 2019-03-06  Tom Tromey  <tom@tromey.com>
11924
11925         * inferior.h (class inferior): Update comment.
11926         * gdbthread.h (class thread_info): Update comment.
11927
11928 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11929             Tom Tromey  <tom@tromey.com>
11930
11931         * stabsread.h (struct stab_section_list): Remove.
11932         (coffstab_build_psymtabs): Update.
11933         * dbxread.c (symbuf_sections): Now a std::vector.
11934         (sect_idx): New global.
11935         (fill_symbuf): Update.
11936         (coffstab_build_psymtabs): Change type of stabsects parameter.
11937         Update.
11938         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11939         std::vector.
11940         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11941         (coff_locate_sections): Update.
11942         (coff_symfile_read): Remove cleanups.  Update.
11943         (init_stringtab): Add storage parameter.
11944         (free_stringtab, free_stringtab_cleanup): Remove.
11945         (init_lineno): Add storage parameter.
11946         (free_linetab, free_linetab_cleanup): Remove.
11947
11948 2019-03-06  Pedro Alves  <palves@redhat.com>
11949
11950         * linux-fork.c (fork_info::clobber_regs): Delete.
11951         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11952         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11953         comment.  Adjust.
11954         (scoped_switch_fork_info::scoped_switch_fork_info)
11955         (checkpoint_command, linux_fork_context): Adjust
11956         fork_save_infrun_state calls.
11957
11958 2019-03-06  Pedro Alves  <palves@redhat.com>
11959
11960         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11961         (inf_has_multiple_threads): Return 'bool' and rewrite using
11962         inferior_info::threads().
11963
11964 2019-03-06  Pedro Alves  <palves@redhat.com>
11965
11966         * linux-fork.c: Include <list>.
11967         (fork_list): Now a std::list instance.
11968         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11969         (forks_exist_p, find_last_fork): Adjust.
11970         (new_fork): Delete.
11971         (one_fork_p): New.
11972         (add_fork): Adjust.
11973         (free_fork): Delete, folded into fork_info::~fork_info().
11974         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11975         Adjust.
11976         (init_fork_list): Delete.
11977         (linux_fork_killall, linux_fork_mourn_inferior)
11978         (linux_fork_detach, info_checkpoints_command): Adjust.
11979         (_initialize_linux_fork): No longer call init_fork_list.
11980
11981 2019-03-06  Pedro Alves  <palves@redhat.com>
11982
11983         * linux-fork.c (new_fork): New, split out of ...
11984         (add_fork): ... this.  Return void.  Move "first fork" special
11985         case from here, to ...
11986         (checkpoint_command): ... here.
11987         * linux-linux.h (add_fork): Return void.
11988
11989 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11990
11991         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11992
11993 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11994             Chris January  <chris.january@arm.com>
11995             David Lecomber  <david.lecomber@arm.com>
11996
11997         * f-exp.y: New token, UNOP_INTRINSIC.
11998         (exp): New pattern using UNOP_INTRINSIC token.
11999         (f77_keywords): Add 'abs' keyword.
12000         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12001         (value_from_host_double): New function.
12002         (evaluate_subexp_f): Support UNOP_ABS.
12003
12004 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12005
12006         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12007         types.
12008
12009 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12010
12011         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12012         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12013         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12014
12015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12016
12017         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12018
12019 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12020             Chris January  <chris.january@arm.com>
12021
12022         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12023         * f-exp.y: Define 'KIND' token.
12024         (exp): New pattern for KIND expressions.
12025         (ptype): Handle types with a kind extension.
12026         (direct_abs_decl): Extend to spot kind extensions.
12027         (f77_keywords): Add 'kind' to the list.
12028         (push_kind_type): New function.
12029         (convert_to_kind_type): New function.
12030         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12031         * parse.c (operator_length_standard): Likewise.
12032         * parser-defs.h (enum type_pieces): Add tp_kind.
12033         * std-operator.def: Add UNOP_KIND.
12034
12035 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12036
12037         * f-exp.y (f_parse): Set yydebug.
12038
12039 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12040
12041         * f-lang.c (evaluate_subexp_f): New function.
12042         (exp_descriptor_f): New global.
12043         (f_language_defn): Use exp_descriptor_f instead of
12044         exp_descriptor_standard.
12045
12046 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12047
12048         * f-exp.y (struct token): Add comments.
12049         (dot_ops): Remove uppercase versions and the end marker.
12050         (f77_keywords): Likewise.
12051         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12052         entries in the dot_ops array are case insensitive, and use
12053         strncasecmp to compare strings.  Also some whitespace cleanup in
12054         this area.  Similar for the f77_keywords array, except entries in
12055         this list might be case sensitive.
12056
12057 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12058
12059         * f-exp.y (struct f77_boolean_val): Add comments.
12060         (boolean_values): Remove uppercase versions, and end marker.
12061         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12062         and use strncasecmp to achieve case insensitivity.  Additionally,
12063         perform whitespace cleanup around this code.
12064
12065 2019-03-06  Tom Tromey  <tromey@adacore.com>
12066
12067         * remote-sim.c (gdbsim_target_open): Use result of
12068         gdb_argv::release.
12069
12070 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12071         Dirk Schubert  <dirk.schubert@arm.com>
12072         Chris January  <chris.january@arm.com>
12073
12074         * eval.c (evaluate_subexp_standard): Call Fortran argument
12075         wrapping logic.
12076         * f-lang.c (struct value): A value which can be passed into a
12077         Fortran function call.
12078         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12079         where appropriate.
12080         (struct type): Value ready for a Fortran function call.
12081         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12082         is needed.
12083         * f-lang.h (fortran_argument_convert): Declaration.
12084         (fortran_preserve_arg_pointer): Declaration.
12085         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12086
12087 2019-03-05  Tom Tromey  <tromey@adacore.com>
12088
12089         * python/py-prettyprint.c (print_string_repr): Remove #if.
12090         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12091
12092 2019-03-05  Tom Tromey  <tromey@adacore.com>
12093
12094         * target.c (the_dummy_target): Move later.  Change type to
12095         "dummy_target".
12096         (initialize_targets): Don't initialize the_dummy_target.
12097
12098 2019-03-05  Tom Tromey  <tromey@adacore.com>
12099
12100         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12101         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12102
12103 2019-03-05  Tom Tromey  <tromey@adacore.com>
12104
12105         * windows-nat.c (windows_nat_target::attach)
12106         (windows_nat_target::detach): Don't call gdb_flush.
12107         * valprint.c (generic_val_print, val_print, val_print_string):
12108         Don't call gdb_flush.
12109         * utils.c (defaulted_query): Don't call gdb_flush.
12110         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12111         * target.c (target_announce_detach): Don't call gdb_flush.
12112         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12113         * remote.c (extended_remote_target::attach): Don't call
12114         gdb_flush.
12115         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12116         * printcmd.c (do_examine): Don't call gdb_flush.
12117         (info_display_command): Don't call gdb_flush.
12118         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12119         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12120         * memattr.c (info_mem_command): Don't call gdb_flush.
12121         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12122         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12123         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12124         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12125         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12126         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12127         (gnu_nat_target::detach): Don't call gdb_flush.
12128         * f-valprint.c (f_val_print): Don't call gdb_flush.
12129         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12130         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12131         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12132         gdb_flush.
12133         * c-valprint.c (c_val_print): Don't call gdb_flush.
12134         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12135
12136 2019-03-05  Tom Tromey  <tromey@adacore.com>
12137
12138         * varobj.c (update_dynamic_varobj_children): Update.
12139         (install_default_visualizer): Use reset, not release.
12140         * value.c (set_internalvar): Update.
12141         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12142         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12143         ATTRIBUTE_UNUSED_RESULT.
12144
12145 2019-03-05  Tom Tromey  <tromey@adacore.com>
12146
12147         * remote.c (class scoped_remote_fd) <release>: Add
12148         ATTRIBUTE_UNUSED_RESULT.
12149
12150 2019-03-05  Tom Tromey  <tromey@adacore.com>
12151
12152         * macroexp.c (struct macro_buffer) <release>: Add
12153         ATTRIBUTE_UNUSED_RESULT.
12154
12155 2019-03-05  Tom Tromey  <tromey@adacore.com>
12156
12157         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12158         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12159         ATTRIBUTE_UNUSED_RESULT.
12160
12161 2019-03-05  Tom Tromey  <tromey@adacore.com>
12162
12163         * common/scoped_fd.h (class scoped_fd) <release>: Add
12164         ATTRIBUTE_UNUSED_RESULT.
12165
12166 2019-03-05  Tom Tromey  <tromey@adacore.com>
12167
12168         * parser-defs.h (struct parser_state) <release>: Add
12169         ATTRIBUTE_UNUSED_RESULT.
12170
12171 2019-03-05  Tom Tromey  <tromey@adacore.com>
12172
12173         * utils.h (class gdb_argv) <release>: Add
12174         ATTRIBUTE_UNUSED_RESULT.
12175         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12176
12177 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12178
12179         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12180         for-loop range, to avoid compiler warnings.
12181
12182         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12183         avoid compiler warnings about unused variables.
12184
12185         * NEWS: Mention end of support for native debugging on MS-Windows
12186         before XP.
12187
12188         PR gdb/24292
12189         * common/netstuff.c:
12190         * gdbserver/gdbreplay.c
12191         * gdbserver/remote-utils.c:
12192         * ser-tcp.c:
12193         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12194         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12195         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12196         'getaddrinfo' and 'freeaddrinfo' were not available before
12197         Windows XP, and mingw.org's MinGW headers by default define
12198         _WIN32_WINNT to 0x500.
12199
12200 2019-03-01  Gary Benson <gbenson@redhat.com>
12201
12202         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12203
12204 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12205             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12206
12207         PR gdb/8527
12208         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12209         set_sigint_trap, clear_sigint_trap.
12210
12211 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12212
12213         * target.c (target_detach): Clear the regcache and the
12214         frame cache.
12215
12216 2019-02-27  Pedro Alves  <palves@redhat.com>
12217
12218         * utils.c (set_screen_size): When we cap the height/width sizes,
12219         tweak the corresponding command variable to show "unlimited":
12220
12221 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12222             Pedro Alves  <palves@redhat.com>
12223
12224         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12225         before calling rl_set_screen_size.
12226
12227 2019-02-27  Tom Tromey  <tromey@adacore.com>
12228
12229         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12230         define.
12231         * python/py-value.c: Remove Python 2.4 workaround.
12232         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12233         workaround.
12234         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12235         Python 2.4 workaround.
12236         * python/python-internal.h: Remove Python 2.4 comment.
12237         (Py_ssize_t): Don't define.
12238         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12239         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12240         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12241         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12242         * python/python.c (do_start_initialization): Remove Python 2.4
12243         workaround.
12244         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12245         (print_children): Remove Python 2.4 workaround.
12246         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12247         workaround.
12248         (CHARBUFFERPROC_NAME): Remove.
12249         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12250         Python 2.4 workaround.
12251
12252 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12253
12254         * NEWS: Note minimum Python version.
12255
12256 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12257
12258         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12259         code from these functions.  Remove corresponding ifdefs.  Use
12260         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12261         Remove gotos and target of gotos.
12262         (infpy_search_memory): Likewise.
12263
12264 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12265
12266         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12267         (hppa_gdbarch_init): Don't register deleted functions with
12268         gdbarch.
12269
12270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12271
12272         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12273         (h8300_unwind_sp): Delete.
12274         (h8300_dummy_id): Delete.
12275         (h8300_gdbarch_init): Don't register deleted functions with
12276         gdbarch.
12277
12278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12279
12280         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12281         (ft32_unwind_pc): Delete.
12282         (ft32_unwind_sp): Delete.
12283         (ft32_gdbarch_init): Don't register deleted functions with
12284         gdbarch.
12285
12286 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12287
12288         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12289         (frv_unwind_pc): Delete.
12290         (frv_unwind_sp): Delete.
12291         (frv_gdbarch_init): Don't register deleted functions with
12292         gdbarch.
12293
12294 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12295
12296         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12297         (riscv_unwind_pc): Delete.
12298         (riscv_unwind_sp): Delete.
12299         (riscv_gdbarch_init): Don't register deleted functions with
12300         gdbarch.
12301
12302 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12303
12304         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12305         (csky_unwind_pc): Delete.
12306         (csky_unwind_sp): Delete.
12307         (csky_gdbarch_init): Don't register deleted functions with
12308         gdbarch.
12309
12310 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12311
12312         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12313         (cris_unwind_pc): Delete.
12314         (cris_unwind_sp): Delete.
12315         (cris_gdbarch_init): Don't register deleted functions with
12316         gdbarch.
12317
12318 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12319
12320         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12321         (bfin_unwind_pc): Delete.
12322         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12323
12324 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12325
12326         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12327         (arm_unwind_pc): Delete.
12328         (arm_unwind_sp): Delete.
12329         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12330
12331 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12332
12333         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12334         (arc_unwind_pc): Delete.
12335         (arc_unwind_sp): Delete.
12336         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12337
12338 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12339
12340         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12341         (alpha_unwind_pc): Delete.
12342         (alpha_gdbarch_init): Don't register deleted functions with
12343         gdbarch.
12344
12345 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12346
12347         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12348         (aarch64_unwind_pc): Delete.
12349         (aarch64_unwind_sp): Delete.
12350         (aarch64_gdbarch_init): Don't register deleted functions with
12351         gdbarch.
12352
12353 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12354
12355         * gdbtypes.c (type_align): Don't consider static members when
12356         computing structure alignment.
12357
12358 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12359
12360         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12361         return 0 for other types.
12362         * arch-utils.c (default_type_align): Always return 0.
12363         * gdbarch.h: Regenerate.
12364         * gdbarch.sh (type_align): Extend comment.
12365         * gdbtypes.c (type_align): Add additional comments, always call
12366         gdbarch_type_align before applying the default rules.
12367         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12368         generic code will then apply a suitable default.
12369         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12370         types, return 0 for other types.
12371
12372 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12373
12374         * NEWS: Create a new section for the next release branch.
12375         Rename the section of the current branch, now that it has
12376         been cut.
12377
12378 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12379
12380         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12381         * version.in: Bump version to 8.3.50.DATE-git.
12382
12383 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12384
12385         * aix-thread.c (ptid_cmp): Remove unused variable.
12386         (get_signaled_thread): Likewise.
12387         (store_regs_user_thread): Likewise.
12388         (store_regs_kernel_thread): Likewise.
12389         (fetch_regs_kernel_thread): Remove shadowed variable.
12390
12391 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12392
12393         * features/riscv/32bit-cpu.xml: Add register numbers.
12394         * features/riscv/32bit-fpu.c: Regenerate.
12395         * features/riscv/32bit-fpu.xml: Add register numbers.
12396         * features/riscv/64bit-cpu.xml: Add register numbers.
12397         * features/riscv/64bit-fpu.c: Regenerate.
12398         * features/riscv/64bit-fpu.xml: Add register numbers.
12399
12400 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12401
12402         * NEWS: Mention two argument form of gdb.Value constructor.
12403         * python/py-value.c (convert_buffer_and_type_to_value): New
12404         function.
12405         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12406         Add support for handling an optional second argument.  Call
12407         convert_buffer_and_type_to_value as appropriate.
12408         * python/python-internal.h (Py_buffer_deleter): New struct.
12409         (Py_buffer_up): New typedef.
12410
12411 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12412
12413         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12414         instead of releasing ownership.
12415
12416 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12417
12418         * dwarf2read.c (open_and_init_dwp_file): Call
12419         elf_numsections instead of bfd_count_sections to initialize
12420         dwp_file->num_sections.
12421
12422 2019-02-25  Tom Tromey  <tromey@adacore.com>
12423
12424         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12425
12426 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12427
12428         * gcore.in: Add '--readnever' option when invoking GDB.
12429
12430 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12431
12432         * MAINTAINERS: Update my email address.
12433
12434 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12435
12436         * build-id.c (build_id_to_debug_bfd_1): New function.
12437         (build_id_to_debug_bfd): Look for separate debug file in
12438         sysroot.
12439
12440 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12441
12442         * gdbarch.sh: Update the copyright year range that is placed into
12443         generated files.
12444
12445 2019-02-22  Keith Seitz  <keiths@redhat.com>
12446
12447         PR symtab/23853
12448         * linespec.c (create_sals_line_offset): Search for the default
12449         symtab's filename instead of its fullname.
12450
12451 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12452
12453         * NEWS: Update style defaults.
12454
12455 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12456
12457         * main.c (captured_main_1): Disable styling in batch mode.
12458
12459 2019-02-20  Tom Tromey  <tom@tromey.com>
12460
12461         * symtab.c (symtab_symbol_info): Fix typos.
12462
12463 2019-02-20  Tom Tromey  <tromey@adacore.com>
12464
12465         * findcmd.c (_initialize_mem_search): Use upper case for
12466         metasyntactic variables.
12467
12468 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12469
12470         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12471         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12472
12473 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12474
12475         * top.h (source_file_name): Change to std::string.
12476         * top.c (source_file_name): Likewise.
12477         (command_line_input): Adjust.
12478         * cli/cli-script.c (script_from_file): Adjust.
12479
12480 2019-02-19  Tom Tromey  <tromey@adacore.com>
12481
12482         * ravenscar-thread.c
12483         (ravenscar_thread_target::update_thread_list): Don't call
12484         ada_build_task_list.
12485         * ada-lang.h (ada_build_task_list): Don't declare.
12486         * ada-tasks.c (struct ada_tasks_inferior_data)
12487         <task_list_valid_p>: Now bool.
12488         (read_known_tasks, ada_task_list_changed)
12489         (ada_tasks_invalidate_inferior_data): Update.
12490         (read_known_tasks_array): Return bool.
12491         (read_known_tasks_list): Likewise.
12492         (read_known_tasks): Return void.
12493         (ada_build_task_list): Now static.
12494
12495 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12496
12497         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12498         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12499
12500 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12501
12502         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12503         variant for ada_tasks_pspace_data_handle and
12504         ada_tasks_inferior_data_handle.
12505         (ada_tasks_pspace_data_cleanup): New function.
12506         (ada_tasks_inferior_data_cleanup): New function.
12507
12508 2019-02-17  Tom Tromey  <tom@tromey.com>
12509
12510         * macrotab.h (macro_source_fullname): Return a std::string.
12511         * macrotab.c (macro_include, check_for_redefinition)
12512         (macro_undef, macro_lookup_definition, foreach_macro)
12513         (foreach_macro_in_scope): Update.
12514         (macro_source_fullname): Return a std::string.
12515         * macrocmd.c (show_pp_source_pos): Update.
12516
12517 2019-02-17  Tom Tromey  <tom@tromey.com>
12518
12519         * macrocmd.c (show_pp_source_pos): Style the file names.
12520
12521 2019-02-17  Tom Tromey  <tom@tromey.com>
12522
12523         PR tui/24197:
12524         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12525
12526 2019-02-17  Tom Tromey  <tom@tromey.com>
12527
12528         * ada-lang.c (user_select_syms): Use filtered printing.
12529         * utils.c (wrap_style): New global.
12530         (desired_style): Remove.
12531         (emit_style_escape): Add stream parameter.
12532         (set_output_style, reset_terminal_style, prompt_for_continue):
12533         Update.
12534         (flush_wrap_buffer): Only flush gdb_stdout.
12535         (wrap_here): Set wrap_style.
12536         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12537         treat escape sequences as a character.  Change when wrap buffer is
12538         flushed.
12539         (fputs_styled): Do not set the output style when the default is
12540         requested.
12541         * ui-style.h (struct ui_file_style) <is_default>: New method.
12542         * source.c (print_source_lines_base): Emit escape sequences in one
12543         piece.
12544
12545 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12546
12547         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12548         integers and enumeration types.
12549
12550 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12551
12552         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12553         instead of lookup_symbol_in_language
12554         (do_exact_match): New function.
12555         (ada_get_symbol_name_matcher): Return do_exact_match when
12556         doing a verbatim match.
12557
12558 2019-02-15  Tom Tromey  <tromey@adacore.com>
12559
12560         * ravenscar-thread.c (ravenscar_thread_target::resume)
12561         (ravenscar_thread_target::wait): Special case wildcard requests.
12562
12563 2019-02-15  Tom Tromey  <tromey@adacore.com>
12564
12565         * ravenscar-thread.c (base_ptid): Remove.
12566         (struct ravenscar_thread_target) <close>: New method.
12567         <m_base_ptid>: New member.
12568         <update_inferior_ptid, active_task, task_is_currently_active,
12569         runtime_initialized>: Declare methods.
12570         <ravenscar_thread_target>: Add constructor.
12571         (ravenscar_thread_target::task_is_currently_active)
12572         (ravenscar_thread_target::update_inferior_ptid)
12573         (ravenscar_runtime_initialized): Rename.  Now methods.
12574         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12575         (ravenscar_thread_target::update_thread_list): Update.
12576         (ravenscar_thread_target::active_task): Now method.
12577         (ravenscar_thread_target::store_registers)
12578         (ravenscar_thread_target::prepare_to_store)
12579         (ravenscar_thread_target::prepare_to_store)
12580         (ravenscar_thread_target::mourn_inferior): Update.
12581         (ravenscar_inferior_created): Use "new" to create target.
12582         (ravenscar_thread_target::get_ada_task_ptid): Update.
12583         (_initialize_ravenscar): Don't initialize base_ptid.
12584         (ravenscar_ops): Remove global.
12585
12586 2019-02-15  Tom Tromey  <tromey@adacore.com>
12587
12588         * target.h (push_target): Declare new overload.
12589         * target.c (push_target): New overload, taking an rvalue reference.
12590         * remote.c (remote_target::open_1): Use push_target overload.
12591         * corelow.c (core_target_open): Use push_target overload.
12592
12593 2019-02-15  Tom Tromey  <tromey@adacore.com>
12594
12595         * ravenscar-thread.c (is_ravenscar_task)
12596         (ravenscar_task_is_currently_active): Return bool.
12597         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12598         (_initialize_ravenscar): Remove "(void)".
12599         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12600         Return bool.
12601
12602 2019-02-15  Tom Tromey  <tromey@adacore.com>
12603
12604         * ravenscar-thread.c (ravenscar_runtime_initializer)
12605         (has_ravenscar_runtime, get_running_thread_id)
12606         (ravenscar_thread_target::resume): Fix indentation.
12607
12608 2019-02-15  Tom Tromey  <tromey@adacore.com>
12609
12610         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12611         from ravenscar_arch_ops.
12612         (sparc_ravenscar_ops::fetch_registers)
12613         (sparc_ravenscar_ops::store_registers): Now methods.
12614         (sparc_ravenscar_prepare_to_store): Remove.
12615         (sparc_ravenscar_ops): Redefine.
12616         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12617         methods and destructor.  Remove members.
12618         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12619         (ravenscar_thread_target::store_registers)
12620         (ravenscar_thread_target::prepare_to_store): Update.
12621         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12622         Remove.
12623         (struct ppc_ravenscar_powerpc_ops): Derive from
12624         ravenscar_arch_ops.
12625         (ppc_ravenscar_powerpc_ops::fetch_registers)
12626         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12627         (ppc_ravenscar_powerpc_ops): Redefine.
12628         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12629         (ppc_ravenscar_e500_ops::fetch_registers)
12630         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12631         (ppc_ravenscar_e500_ops): Redefine.
12632         * aarch64-ravenscar-thread.c
12633         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12634         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12635         (aarch64_ravenscar_fetch_registers)
12636         (aarch64_ravenscar_store_registers): Now methods.
12637         (aarch64_ravenscar_ops): Redefine.
12638
12639 2019-02-15  Tom Tromey  <tromey@adacore.com>
12640
12641         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12642         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12643         (ravenscar_thread_target::stopped_by_watchpoint)
12644         (ravenscar_thread_target::stopped_data_address)
12645         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12646
12647 2019-02-15  Tom Tromey  <tromey@adacore.com>
12648
12649         * ravenscar-thread.c: Fix some typos.
12650
12651 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12652             Tom Tromey  <tromey@adacore.com>
12653
12654         * ada-lang.c (ada_exception_sal): Change addr_string to a
12655         std::string.
12656         (create_ada_exception_catchpoint): Update.
12657
12658 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12659             Tom Tromey  <tromey@adacore.com>
12660
12661         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12662         (bp_location_ops): Remove.
12663         (base_breakpoint_allocate_location): Update.
12664         (free_bp_location): Update.
12665         * ada-lang.c (class ada_catchpoint_location)
12666         <ada_catchpoint_location>: Remove ops parameter.
12667         (ada_catchpoint_location_dtor): Remove.
12668         (ada_catchpoint_location_ops): Remove.
12669         (allocate_location_exception): Update.
12670         * breakpoint.h (struct bp_location_ops): Remove.
12671         (class bp_location) <bp_location>: Remove bp_location_ops
12672         parameter.
12673         <~bp_location>: Add destructor.
12674         <ops>: Remove.
12675
12676 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12677             Pedro Alves  <palves@redhat.com>
12678
12679         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12680         'PATH_MAX'.
12681
12682 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12683             Samuel Thibault  <samuel.thibault@gnu.org>
12684             Thomas Schwinge  <thomas@codesourcery.com>
12685
12686         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12687         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12688
12689 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12690
12691         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12692         (check_empty): Use "const char *".
12693
12694         * gnu-nat.c (gnu_nat_target::detach): Instead of
12695         'detach_inferior (pid)' call
12696         'detach_inferior (find_inferior_pid (pid))'.
12697
12698         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12699         'nat/fork-inferior.o'.
12700         * gnu-nat.c: #include "nat/fork-inferior.h".
12701
12702         * gnu-nat.c (gnu_nat_target::detach): Instead of
12703         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12704         * gnu-nat.h: #include "inf-child.h".
12705         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12706         'i386_gnu_nat_target::fetch_registers'.
12707         (gnu_store_registers): Rename/move to
12708         'i386_gnu_nat_target::store_registers'.
12709
12710         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12711         * gnu-nat.h (mach_thread_info): New function.
12712         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12713
12714         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12715
12716 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12717
12718         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12719
12720 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12721
12722         * windows-nat.c (windows_add_thread): Add new parameter
12723         "main_thread_p" with default value set to false.  Update
12724         function documentation as well as all callers.
12725         (windows_delete_thread): Likewise.
12726         (fake_create_process): Update call to windows_add_thread.
12727         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12728         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12729         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12730         call to windows_delete_thread.
12731
12732 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12733
12734         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12735
12736 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12737
12738         * symfile.c (find_separate_debug_file): Use canonical path of
12739         sysroot with child_path instead of gdb_sysroot if it is valid.
12740
12741 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12742
12743         * symfile.c (find_separate_debug_file): Use child_path to
12744         determine if an object file is under a sysroot.
12745
12746 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12747
12748         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12749         unittests/child-path-selftests.c.
12750         * common/pathstuff.c (child_path): New function.
12751         * common/pathstuff.h (child_path): New prototype.
12752         * unittests/child-path-selftests.c: New file.
12753
12754 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12755
12756         * symfile.c (find_separate_debug_file): Look for separate debug
12757         files in debug directories under the sysroot.
12758
12759 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12760
12761         * symtab.h (struct minimal_symbol data_p): New const method.
12762         (struct minimal_symbol text_p): Likewise.
12763         * symtab.c (output_source_filename): Use file name style
12764         to print file name.
12765         (print_symbol_info): Likewise.
12766         (print_msymbol_info): Use address style to print addresses.
12767         Use function name style to print executable text symbols.
12768         (expand_symtab_containing_pc): Use data_p.
12769         (find_pc_sect_compunit_symtab): Likewise.
12770
12771 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12772
12773         * breakpoint.c (describe_other_breakpoints): Use address style
12774         to print addresses.
12775         (say_where): Likewise.
12776
12777 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12778
12779         * ada-typeprint.c (print_func_type): Print function name
12780         style to print function name.
12781         * c-typeprint.c (c_print_type_1): Likewise.
12782
12783 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12784
12785         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12786         for execve.
12787
12788 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12789
12790         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12791         type_stack.
12792
12793 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12794
12795         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12796         TYPE_CODE_REF types.
12797
12798 2019-02-08  Jim Wilson  <jimw@sifive.com>
12799
12800         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12801         (riscv_linux_fregset): New.
12802         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12803
12804 2019-02-07  Tom Tromey  <tom@tromey.com>
12805
12806         * thread.c (thread_cancel_execution_command): Update.
12807         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12808         methods.
12809         (struct thread_fsm_ops): Remove.
12810         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12811         (thread_fsm_should_stop, thread_fsm_return_value)
12812         (thread_fsm_set_finished, thread_fsm_finished_p)
12813         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12814         Don't declare.
12815         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12816         * infrun.c (clear_proceed_status_thread)
12817         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12818         (print_stop_event): Update.
12819         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12820         Add constructor.
12821         (step_command_fsm_ops): Remove.
12822         (new_step_command_fsm): Remove.
12823         (step_1): Update.
12824         (step_command_fsm::should_stop): Rename from
12825         step_command_fsm_should_stop.
12826         (step_command_fsm::clean_up): Rename from
12827         step_command_fsm_clean_up.
12828         (step_command_fsm::do_async_reply_reason): Rename from
12829         step_command_fsm_async_reply_reason.
12830         (struct until_next_fsm): Inherit from thread_fsm.  Add
12831         constructor.
12832         (until_next_fsm_ops): Remove.
12833         (new_until_next_fsm): Remove.
12834         (until_next_fsm::should_stop): Rename from
12835         until_next_fsm_should_stop.
12836         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12837         (until_next_fsm::do_async_reply_reason): Rename from
12838         until_next_fsm_async_reply_reason.
12839         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12840         constructor.  Change type of breakpoint.
12841         (finish_command_fsm_ops): Remove.
12842         (new_finish_command_fsm): Remove.
12843         (finish_command_fsm::should_stop): Rename from
12844         finish_command_fsm_should_stop.
12845         (finish_command_fsm::clean_up): Rename from
12846         finish_command_fsm_clean_up.
12847         (finish_command_fsm::return_value): Rename from
12848         finish_command_fsm_return_value.
12849         (finish_command_fsm::do_async_reply_reason): Rename from
12850         finish_command_fsm_async_reply_reason.
12851         (finish_command): Update.
12852         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12853         Add constructor.
12854         (call_thread_fsm_ops): Remove.
12855         (call_thread_fsm::call_thread_fsm): Rename from
12856         new_call_thread_fsm.
12857         (call_thread_fsm::should_stop): Rename from
12858         call_thread_fsm_should_stop.
12859         (call_thread_fsm::should_notify_stop): Rename from
12860         call_thread_fsm_should_notify_stop.
12861         (run_inferior_call, call_function_by_hand_dummy): Update.
12862         * cli/cli-interp.c (should_print_stop_to_console): Update.
12863         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12864         Add constructor.  Change type of location_breakpoint,
12865         caller_breakpoint.
12866         (until_break_fsm_ops): Remove.
12867         (new_until_break_fsm): Remove.
12868         (until_break_fsm::should_stop): Rename from
12869         until_break_fsm_should_stop.
12870         (until_break_fsm::clean_up): Rename from
12871         until_break_fsm_clean_up.
12872         (until_break_fsm::do_async_reply_reason): Rename from
12873         until_break_fsm_async_reply_reason.
12874         (until_break_command): Update.
12875         * thread-fsm.c: Remove.
12876         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12877
12878 2019-02-07  Tom Tromey  <tom@tromey.com>
12879
12880         * yy-remap.h: Add include guard.
12881         * xtensa-tdep.h: Add include guard.
12882         * xcoffread.h: Rename include guard.
12883         * varobj-iter.h: Add include guard.
12884         * tui/tui.h: Rename include guard.
12885         * tui/tui-winsource.h: Rename include guard.
12886         * tui/tui-wingeneral.h: Rename include guard.
12887         * tui/tui-windata.h: Rename include guard.
12888         * tui/tui-win.h: Rename include guard.
12889         * tui/tui-stack.h: Rename include guard.
12890         * tui/tui-source.h: Rename include guard.
12891         * tui/tui-regs.h: Rename include guard.
12892         * tui/tui-out.h: Rename include guard.
12893         * tui/tui-layout.h: Rename include guard.
12894         * tui/tui-io.h: Rename include guard.
12895         * tui/tui-hooks.h: Rename include guard.
12896         * tui/tui-file.h: Rename include guard.
12897         * tui/tui-disasm.h: Rename include guard.
12898         * tui/tui-data.h: Rename include guard.
12899         * tui/tui-command.h: Rename include guard.
12900         * tic6x-tdep.h: Add include guard.
12901         * target/waitstatus.h: Rename include guard.
12902         * target/wait.h: Rename include guard.
12903         * target/target.h: Rename include guard.
12904         * target/resume.h: Rename include guard.
12905         * target-float.h: Rename include guard.
12906         * stabsread.h: Add include guard.
12907         * rs6000-tdep.h: Add include guard.
12908         * riscv-fbsd-tdep.h: Add include guard.
12909         * regformats/regdef.h: Rename include guard.
12910         * record.h: Rename include guard.
12911         * python/python.h: Rename include guard.
12912         * python/python-internal.h: Rename include guard.
12913         * python/py-stopevent.h: Rename include guard.
12914         * python/py-ref.h: Rename include guard.
12915         * python/py-record.h: Rename include guard.
12916         * python/py-record-full.h: Rename include guard.
12917         * python/py-record-btrace.h: Rename include guard.
12918         * python/py-instruction.h: Rename include guard.
12919         * python/py-events.h: Rename include guard.
12920         * python/py-event.h: Rename include guard.
12921         * procfs.h: Add include guard.
12922         * proc-utils.h: Add include guard.
12923         * p-lang.h: Add include guard.
12924         * or1k-tdep.h: Rename include guard.
12925         * observable.h: Rename include guard.
12926         * nto-tdep.h: Rename include guard.
12927         * nat/x86-linux.h: Rename include guard.
12928         * nat/x86-linux-dregs.h: Rename include guard.
12929         * nat/x86-gcc-cpuid.h: Add include guard.
12930         * nat/x86-dregs.h: Rename include guard.
12931         * nat/x86-cpuid.h: Rename include guard.
12932         * nat/ppc-linux.h: Rename include guard.
12933         * nat/mips-linux-watch.h: Rename include guard.
12934         * nat/linux-waitpid.h: Rename include guard.
12935         * nat/linux-ptrace.h: Rename include guard.
12936         * nat/linux-procfs.h: Rename include guard.
12937         * nat/linux-osdata.h: Rename include guard.
12938         * nat/linux-nat.h: Rename include guard.
12939         * nat/linux-namespaces.h: Rename include guard.
12940         * nat/linux-btrace.h: Rename include guard.
12941         * nat/glibc_thread_db.h: Rename include guard.
12942         * nat/gdb_thread_db.h: Rename include guard.
12943         * nat/gdb_ptrace.h: Rename include guard.
12944         * nat/fork-inferior.h: Rename include guard.
12945         * nat/amd64-linux-siginfo.h: Rename include guard.
12946         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12947         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12948         * nat/aarch64-linux.h: Rename include guard.
12949         * nat/aarch64-linux-hw-point.h: Rename include guard.
12950         * mn10300-tdep.h: Add include guard.
12951         * mips-linux-tdep.h: Add include guard.
12952         * mi/mi-parse.h: Rename include guard.
12953         * mi/mi-out.h: Rename include guard.
12954         * mi/mi-main.h: Rename include guard.
12955         * mi/mi-interp.h: Rename include guard.
12956         * mi/mi-getopt.h: Rename include guard.
12957         * mi/mi-console.h: Rename include guard.
12958         * mi/mi-common.h: Rename include guard.
12959         * mi/mi-cmds.h: Rename include guard.
12960         * mi/mi-cmd-break.h: Rename include guard.
12961         * m2-lang.h: Add include guard.
12962         * location.h: Rename include guard.
12963         * linux-record.h: Rename include guard.
12964         * linux-nat.h: Add include guard.
12965         * linux-fork.h: Add include guard.
12966         * i386-darwin-tdep.h: Rename include guard.
12967         * hppa-linux-offsets.h: Add include guard.
12968         * guile/guile.h: Rename include guard.
12969         * guile/guile-internal.h: Rename include guard.
12970         * gnu-nat.h: Rename include guard.
12971         * gdb-stabs.h: Rename include guard.
12972         * frv-tdep.h: Add include guard.
12973         * f-lang.h: Add include guard.
12974         * event-loop.h: Add include guard.
12975         * darwin-nat.h: Rename include guard.
12976         * cp-abi.h: Rename include guard.
12977         * config/sparc/nm-sol2.h: Rename include guard.
12978         * config/nm-nto.h: Rename include guard.
12979         * config/nm-linux.h: Add include guard.
12980         * config/i386/nm-i386gnu.h: Rename include guard.
12981         * config/djgpp/nl_types.h: Rename include guard.
12982         * config/djgpp/langinfo.h: Rename include guard.
12983         * compile/gcc-cp-plugin.h: Add include guard.
12984         * compile/gcc-c-plugin.h: Add include guard.
12985         * compile/compile.h: Rename include guard.
12986         * compile/compile-object-run.h: Rename include guard.
12987         * compile/compile-object-load.h: Rename include guard.
12988         * compile/compile-internal.h: Rename include guard.
12989         * compile/compile-cplus.h: Rename include guard.
12990         * compile/compile-c.h: Rename include guard.
12991         * common/xml-utils.h: Rename include guard.
12992         * common/x86-xstate.h: Rename include guard.
12993         * common/version.h: Rename include guard.
12994         * common/vec.h: Rename include guard.
12995         * common/tdesc.h: Rename include guard.
12996         * common/selftest.h: Rename include guard.
12997         * common/scoped_restore.h: Rename include guard.
12998         * common/scoped_mmap.h: Rename include guard.
12999         * common/scoped_fd.h: Rename include guard.
13000         * common/safe-iterator.h: Rename include guard.
13001         * common/run-time-clock.h: Rename include guard.
13002         * common/refcounted-object.h: Rename include guard.
13003         * common/queue.h: Rename include guard.
13004         * common/ptid.h: Rename include guard.
13005         * common/print-utils.h: Rename include guard.
13006         * common/preprocessor.h: Rename include guard.
13007         * common/pathstuff.h: Rename include guard.
13008         * common/observable.h: Rename include guard.
13009         * common/netstuff.h: Rename include guard.
13010         * common/job-control.h: Rename include guard.
13011         * common/host-defs.h: Rename include guard.
13012         * common/gdb_wait.h: Rename include guard.
13013         * common/gdb_vecs.h: Rename include guard.
13014         * common/gdb_unlinker.h: Rename include guard.
13015         * common/gdb_unique_ptr.h: Rename include guard.
13016         * common/gdb_tilde_expand.h: Rename include guard.
13017         * common/gdb_sys_time.h: Rename include guard.
13018         * common/gdb_string_view.h: Rename include guard.
13019         * common/gdb_splay_tree.h: Rename include guard.
13020         * common/gdb_setjmp.h: Rename include guard.
13021         * common/gdb_ref_ptr.h: Rename include guard.
13022         * common/gdb_optional.h: Rename include guard.
13023         * common/gdb_locale.h: Rename include guard.
13024         * common/gdb_assert.h: Rename include guard.
13025         * common/filtered-iterator.h: Rename include guard.
13026         * common/filestuff.h: Rename include guard.
13027         * common/fileio.h: Rename include guard.
13028         * common/environ.h: Rename include guard.
13029         * common/common-utils.h: Rename include guard.
13030         * common/common-types.h: Rename include guard.
13031         * common/common-regcache.h: Rename include guard.
13032         * common/common-inferior.h: Rename include guard.
13033         * common/common-gdbthread.h: Rename include guard.
13034         * common/common-exceptions.h: Rename include guard.
13035         * common/common-defs.h: Rename include guard.
13036         * common/common-debug.h: Rename include guard.
13037         * common/cleanups.h: Rename include guard.
13038         * common/buffer.h: Rename include guard.
13039         * common/btrace-common.h: Rename include guard.
13040         * common/break-common.h: Rename include guard.
13041         * cli/cli-utils.h: Rename include guard.
13042         * cli/cli-style.h: Rename include guard.
13043         * cli/cli-setshow.h: Rename include guard.
13044         * cli/cli-script.h: Rename include guard.
13045         * cli/cli-interp.h: Rename include guard.
13046         * cli/cli-decode.h: Rename include guard.
13047         * cli/cli-cmds.h: Rename include guard.
13048         * charset-list.h: Add include guard.
13049         * buildsym-legacy.h: Rename include guard.
13050         * bfin-tdep.h: Add include guard.
13051         * ax.h: Rename include guard.
13052         * arm-linux-tdep.h: Add include guard.
13053         * arm-fbsd-tdep.h: Add include guard.
13054         * arch/xtensa.h: Rename include guard.
13055         * arch/tic6x.h: Add include guard.
13056         * arch/i386.h: Add include guard.
13057         * arch/arm.h: Rename include guard.
13058         * arch/arm-linux.h: Rename include guard.
13059         * arch/arm-get-next-pcs.h: Rename include guard.
13060         * arch/amd64.h: Add include guard.
13061         * arch/aarch64-insn.h: Rename include guard.
13062         * arch-utils.h: Rename include guard.
13063         * annotate.h: Add include guard.
13064         * amd64-darwin-tdep.h: Rename include guard.
13065         * aarch64-linux-tdep.h: Add include guard.
13066         * aarch64-fbsd-tdep.h: Add include guard.
13067         * aarch32-linux-nat.h: Add include guard.
13068
13069 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13070
13071         * macrotab.c (macro_define_internal): New function that
13072         factorizes macro_define_object_internal and macro_define_function
13073         code.
13074         (macro_define_object_internal): Use macro_define_internal.
13075         (macro_define_function): Likewise.
13076
13077 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13078
13079         * macrocmd.c (extract_identifier): Return
13080         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13081         callers.
13082
13083 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13084
13085         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13086
13087 2019-02-05  Tom Tromey  <tom@tromey.com>
13088
13089         * target.c (target_stack::unpush): Move assertion earlier.
13090
13091 2019-01-30  Tom Tromey  <tom@tromey.com>
13092
13093         PR python/23615:
13094         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13095         (gdbpy_parse_and_eval): Likewise.
13096         * python/python-internal.h (gdbpy_allow_threads): New class.
13097
13098 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13099
13100         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13101         (aarch64_fbsd_fpregmap): Move earlier.
13102         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13103         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13104         instead of individual calls to trad_frame_set_reg_addr.
13105         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13106         earlier.
13107         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13108         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13109         instead of individual calls to trad_frame_set_reg_addr.
13110
13111 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13112
13113         * CONTRIBUTE: Replace contribution list with wiki link.
13114
13115 2019-01-25  Tom Tromey  <tom@tromey.com>
13116
13117         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13118
13119 2019-01-25  Tom Tromey  <tom@tromey.com>
13120
13121         * xtensa-linux-nat.c: Fix common/ includes.
13122         * xml-support.h: Fix common/ includes.
13123         * xml-support.c: Fix common/ includes.
13124         * x86-linux-nat.c: Fix common/ includes.
13125         * windows-nat.c: Fix common/ includes.
13126         * varobj.h: Fix common/ includes.
13127         * varobj.c: Fix common/ includes.
13128         * value.c: Fix common/ includes.
13129         * valops.c: Fix common/ includes.
13130         * utils.c: Fix common/ includes.
13131         * unittests/xml-utils-selftests.c: Fix common/ includes.
13132         * unittests/utils-selftests.c: Fix common/ includes.
13133         * unittests/unpack-selftests.c: Fix common/ includes.
13134         * unittests/tracepoint-selftests.c: Fix common/ includes.
13135         * unittests/style-selftests.c: Fix common/ includes.
13136         * unittests/string_view-selftests.c: Fix common/ includes.
13137         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13138         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13139         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13140         * unittests/rsp-low-selftests.c: Fix common/ includes.
13141         * unittests/parse-connection-spec-selftests.c: Fix common/
13142         includes.
13143         * unittests/optional-selftests.c: Fix common/ includes.
13144         * unittests/offset-type-selftests.c: Fix common/ includes.
13145         * unittests/observable-selftests.c: Fix common/ includes.
13146         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13147         * unittests/memrange-selftests.c: Fix common/ includes.
13148         * unittests/memory-map-selftests.c: Fix common/ includes.
13149         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13150         * unittests/function-view-selftests.c: Fix common/ includes.
13151         * unittests/environ-selftests.c: Fix common/ includes.
13152         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13153         * unittests/common-utils-selftests.c: Fix common/ includes.
13154         * unittests/cli-utils-selftests.c: Fix common/ includes.
13155         * unittests/array-view-selftests.c: Fix common/ includes.
13156         * ui-file.c: Fix common/ includes.
13157         * tui/tui-io.c: Fix common/ includes.
13158         * tracepoint.h: Fix common/ includes.
13159         * tracepoint.c: Fix common/ includes.
13160         * tracefile-tfile.c: Fix common/ includes.
13161         * top.h: Fix common/ includes.
13162         * top.c: Fix common/ includes.
13163         * thread.c: Fix common/ includes.
13164         * target/waitstatus.h: Fix common/ includes.
13165         * target/waitstatus.c: Fix common/ includes.
13166         * target.h: Fix common/ includes.
13167         * target.c: Fix common/ includes.
13168         * target-memory.c: Fix common/ includes.
13169         * target-descriptions.c: Fix common/ includes.
13170         * symtab.h: Fix common/ includes.
13171         * symfile.c: Fix common/ includes.
13172         * stap-probe.c: Fix common/ includes.
13173         * spu-linux-nat.c: Fix common/ includes.
13174         * sparc-nat.c: Fix common/ includes.
13175         * source.c: Fix common/ includes.
13176         * solib.c: Fix common/ includes.
13177         * solib-target.c: Fix common/ includes.
13178         * ser-unix.c: Fix common/ includes.
13179         * ser-tcp.c: Fix common/ includes.
13180         * ser-pipe.c: Fix common/ includes.
13181         * ser-base.c: Fix common/ includes.
13182         * selftest-arch.c: Fix common/ includes.
13183         * s12z-tdep.c: Fix common/ includes.
13184         * rust-exp.y: Fix common/ includes.
13185         * rs6000-aix-tdep.c: Fix common/ includes.
13186         * riscv-tdep.c: Fix common/ includes.
13187         * remote.c: Fix common/ includes.
13188         * remote-notif.h: Fix common/ includes.
13189         * remote-fileio.h: Fix common/ includes.
13190         * remote-fileio.c: Fix common/ includes.
13191         * regcache.h: Fix common/ includes.
13192         * regcache.c: Fix common/ includes.
13193         * record-btrace.c: Fix common/ includes.
13194         * python/python.c: Fix common/ includes.
13195         * python/py-type.c: Fix common/ includes.
13196         * python/py-inferior.c: Fix common/ includes.
13197         * progspace.h: Fix common/ includes.
13198         * producer.c: Fix common/ includes.
13199         * procfs.c: Fix common/ includes.
13200         * proc-api.c: Fix common/ includes.
13201         * printcmd.c: Fix common/ includes.
13202         * ppc-linux-nat.c: Fix common/ includes.
13203         * parser-defs.h: Fix common/ includes.
13204         * osdata.c: Fix common/ includes.
13205         * obsd-nat.c: Fix common/ includes.
13206         * nat/x86-linux.c: Fix common/ includes.
13207         * nat/x86-linux-dregs.c: Fix common/ includes.
13208         * nat/x86-dregs.h: Fix common/ includes.
13209         * nat/x86-dregs.c: Fix common/ includes.
13210         * nat/ppc-linux.c: Fix common/ includes.
13211         * nat/mips-linux-watch.h: Fix common/ includes.
13212         * nat/mips-linux-watch.c: Fix common/ includes.
13213         * nat/linux-waitpid.c: Fix common/ includes.
13214         * nat/linux-ptrace.h: Fix common/ includes.
13215         * nat/linux-ptrace.c: Fix common/ includes.
13216         * nat/linux-procfs.c: Fix common/ includes.
13217         * nat/linux-personality.c: Fix common/ includes.
13218         * nat/linux-osdata.c: Fix common/ includes.
13219         * nat/linux-namespaces.c: Fix common/ includes.
13220         * nat/linux-btrace.h: Fix common/ includes.
13221         * nat/linux-btrace.c: Fix common/ includes.
13222         * nat/fork-inferior.c: Fix common/ includes.
13223         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13224         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13225         * nat/aarch64-linux.c: Fix common/ includes.
13226         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13227         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13228         * namespace.h: Fix common/ includes.
13229         * mips-linux-tdep.c: Fix common/ includes.
13230         * minsyms.c: Fix common/ includes.
13231         * mi/mi-parse.h: Fix common/ includes.
13232         * mi/mi-main.c: Fix common/ includes.
13233         * mi/mi-cmd-env.c: Fix common/ includes.
13234         * memrange.h: Fix common/ includes.
13235         * memattr.c: Fix common/ includes.
13236         * maint.h: Fix common/ includes.
13237         * maint.c: Fix common/ includes.
13238         * main.c: Fix common/ includes.
13239         * machoread.c: Fix common/ includes.
13240         * location.c: Fix common/ includes.
13241         * linux-thread-db.c: Fix common/ includes.
13242         * linux-nat.c: Fix common/ includes.
13243         * linux-fork.c: Fix common/ includes.
13244         * inline-frame.c: Fix common/ includes.
13245         * infrun.c: Fix common/ includes.
13246         * inflow.c: Fix common/ includes.
13247         * inferior.h: Fix common/ includes.
13248         * inferior.c: Fix common/ includes.
13249         * infcmd.c: Fix common/ includes.
13250         * inf-ptrace.c: Fix common/ includes.
13251         * inf-child.c: Fix common/ includes.
13252         * ia64-linux-nat.c: Fix common/ includes.
13253         * i387-tdep.c: Fix common/ includes.
13254         * i386-tdep.c: Fix common/ includes.
13255         * i386-linux-tdep.c: Fix common/ includes.
13256         * i386-linux-nat.c: Fix common/ includes.
13257         * i386-go32-tdep.c: Fix common/ includes.
13258         * i386-fbsd-tdep.c: Fix common/ includes.
13259         * i386-fbsd-nat.c: Fix common/ includes.
13260         * guile/scm-type.c: Fix common/ includes.
13261         * guile/guile.c: Fix common/ includes.
13262         * go32-nat.c: Fix common/ includes.
13263         * gnu-nat.c: Fix common/ includes.
13264         * gdbthread.h: Fix common/ includes.
13265         * gdbarch-selftests.c: Fix common/ includes.
13266         * gdb_usleep.c: Fix common/ includes.
13267         * gdb_select.h: Fix common/ includes.
13268         * gdb_bfd.c: Fix common/ includes.
13269         * gcore.c: Fix common/ includes.
13270         * fork-child.c: Fix common/ includes.
13271         * findvar.c: Fix common/ includes.
13272         * fbsd-nat.c: Fix common/ includes.
13273         * event-top.c: Fix common/ includes.
13274         * event-loop.c: Fix common/ includes.
13275         * dwarf2read.c: Fix common/ includes.
13276         * dwarf2loc.c: Fix common/ includes.
13277         * dwarf2-frame.c: Fix common/ includes.
13278         * dwarf-index-cache.c: Fix common/ includes.
13279         * dtrace-probe.c: Fix common/ includes.
13280         * disasm-selftests.c: Fix common/ includes.
13281         * defs.h: Fix common/ includes.
13282         * csky-tdep.c: Fix common/ includes.
13283         * cp-valprint.c: Fix common/ includes.
13284         * cp-support.h: Fix common/ includes.
13285         * cp-support.c: Fix common/ includes.
13286         * corelow.c: Fix common/ includes.
13287         * completer.h: Fix common/ includes.
13288         * completer.c: Fix common/ includes.
13289         * compile/compile.c: Fix common/ includes.
13290         * compile/compile-loc2c.c: Fix common/ includes.
13291         * compile/compile-cplus-types.c: Fix common/ includes.
13292         * compile/compile-cplus-symbols.c: Fix common/ includes.
13293         * command.h: Fix common/ includes.
13294         * cli/cli-dump.c: Fix common/ includes.
13295         * cli/cli-cmds.c: Fix common/ includes.
13296         * charset.c: Fix common/ includes.
13297         * build-id.c: Fix common/ includes.
13298         * btrace.h: Fix common/ includes.
13299         * btrace.c: Fix common/ includes.
13300         * breakpoint.h: Fix common/ includes.
13301         * breakpoint.c: Fix common/ includes.
13302         * ax.h:
13303         (enum agent_op): Fix common/ includes.
13304         * ax-general.c (struct aop_map): Fix common/ includes.
13305         * ax-gdb.c: Fix common/ includes.
13306         * auxv.c: Fix common/ includes.
13307         * auto-load.c: Fix common/ includes.
13308         * arm-tdep.c: Fix common/ includes.
13309         * arch/riscv.c: Fix common/ includes.
13310         * arch/ppc-linux-common.c: Fix common/ includes.
13311         * arch/i386.c: Fix common/ includes.
13312         * arch/arm.c: Fix common/ includes.
13313         * arch/arm-linux.c: Fix common/ includes.
13314         * arch/arm-get-next-pcs.c: Fix common/ includes.
13315         * arch/amd64.c: Fix common/ includes.
13316         * arch/aarch64.c: Fix common/ includes.
13317         * arch/aarch64-insn.c: Fix common/ includes.
13318         * arch-utils.c: Fix common/ includes.
13319         * amd64-windows-tdep.c: Fix common/ includes.
13320         * amd64-tdep.c: Fix common/ includes.
13321         * amd64-sol2-tdep.c: Fix common/ includes.
13322         * amd64-obsd-tdep.c: Fix common/ includes.
13323         * amd64-nbsd-tdep.c: Fix common/ includes.
13324         * amd64-linux-tdep.c: Fix common/ includes.
13325         * amd64-linux-nat.c: Fix common/ includes.
13326         * amd64-fbsd-tdep.c: Fix common/ includes.
13327         * amd64-fbsd-nat.c: Fix common/ includes.
13328         * amd64-dicos-tdep.c: Fix common/ includes.
13329         * amd64-darwin-tdep.c: Fix common/ includes.
13330         * agent.c: Fix common/ includes.
13331         * ada-lang.h: Fix common/ includes.
13332         * ada-lang.c: Fix common/ includes.
13333         * aarch64-tdep.c: Fix common/ includes.
13334
13335 2019-01-25  Tom Tromey  <tom@tromey.com>
13336
13337         * common/create-version.sh: Use common/version.h.
13338
13339 2019-01-24  Pedro Alves  <palves@redhat.com>
13340
13341         * infrun.c (signal_stop, signal_print, signal_program)
13342         (signal_catch, signal_pass): Now arrays instead of pointers.
13343         (update_signals_program_target, do_target_resume)
13344         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13345         * linux-nat.c (linux_nat_target::pass_signals)
13346         (linux_nat_target::create_inferior, linux_nat_target::attach):
13347         Adjust.
13348         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13349         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13350         * procfs.c (procfs_target::pass_signals): Adjust.
13351         * record-full.c (record_full_target::resume): Adjust.
13352         * remote.c (remote_target::pass_signals)
13353         (remote_target::program_signals): Adjust.
13354         * target-debug.h (target_debug_print_signals): Now takes a
13355         gdb::array_view as parameter.  Adjust.
13356         * target.h (target_ops) <pass_signals, program_signals>: Replace
13357         pointer and length parameters with gdb::array_view.
13358         (target_pass_signals, target_program_signals): Likewise.
13359         * target-delegates.c: Regenerate.
13360
13361 2019-01-24  Pedro Alves  <palves@redhat.com>
13362
13363         * common/forward-scope-exit.h
13364         (forward_scope_exit::forward_scope_exit): Pass arguments to
13365         m_bind_function directly, instead of creating a std::bind and
13366         copying that.
13367
13368 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13369
13370         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13371         for static members.
13372         (pass_in_v_vfp_candidate): Likewise.
13373
13374 2019-01-23  Tom Tromey  <tom@tromey.com>
13375             Pedro Alves  <palves@redhat.com>
13376
13377         * regcache.c (class regcache_invalidator): Remove.
13378         (regcache::raw_write): Use make_scope_exit.
13379
13380 2019-01-23  Tom Tromey  <tom@tromey.com>
13381
13382         * ui-out.h (class ui_out_emit_type): Update comment.
13383
13384 2019-01-23  Tom Tromey  <tom@tromey.com>
13385
13386         * infrun.c (fetch_inferior_event): Update comment.
13387
13388 2019-01-23  Tom Tromey  <tom@tromey.com>
13389             Pedro Alves  <palves@redhat.com>
13390
13391         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13392         parameter.
13393         (fetch_inferior_event): Use SCOPE_EXIT.
13394
13395
13396 2019-01-23  Tom Tromey  <tom@tromey.com>
13397             Pedro Alves  <palves@redhat.com>
13398
13399         * infrun.c (disable_thread_events): Delete.
13400         (stop_all_threads): Use SCOPE_EXIT.
13401
13402 2019-01-23  Tom Tromey  <tom@tromey.com>
13403             Pedro Alves  <palves@redhat.com>
13404
13405         * symfile.c: Include forward-scope-exit.h.
13406         (clear_symtab_users_cleanup): Replace forward declaration with
13407         a FORWARD_SCOPE_EXIT.
13408         (syms_from_objfile_1): Use the forward_scope_exit and
13409         gdb::optional instead of cleanup_function.
13410         (reread_symbols): Use the forward_scope_exit instead of
13411         cleanup_function.
13412         (clear_symtab_users_cleanup): Remove function.
13413
13414 2019-01-23  Tom Tromey  <tom@tromey.com>
13415             Pedro Alves  <palves@redhat.com>
13416
13417         * linux-nat.c: Include scope-exit.h.
13418         (cleanup_target_stop): Remove.
13419         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13420         SCOPE_EXIT.
13421
13422 2019-01-23  Tom Tromey  <tom@tromey.com>
13423             Pedro Alves  <palves@redhat.com>
13424
13425         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13426         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13427
13428 2019-01-23  Tom Tromey  <tom@tromey.com>
13429             Andrew Burgess  <andrew.burgess@embecosm.com>
13430             Pedro Alves  <palves@redhat.com>
13431
13432         * infrun.c (fetch_inferior_event): Use scope_exit.
13433         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13434         * top.c (execute_command): Use scope_exit.
13435         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13436         * utils.c (do_bpstat_clear_actions_cleanup)
13437         (make_bpstat_clear_actions_cleanup): Remove.
13438
13439 2019-01-23  Tom Tromey  <tom@tromey.com>
13440             Pedro Alves  <palves@redhat.com>
13441
13442         * infrun.c: Include "common/scope-exit.h"
13443         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13444         (wait_for_inferior): Use SCOPE_EXIT.
13445         (fetch_inferior_event): Use scope_exit.
13446
13447 2019-01-23  Tom Tromey  <tom@tromey.com>
13448             Pedro Alves  <palves@redhat.com>
13449
13450         * breakpoint.c (create_breakpoint): Remove cleanup.
13451
13452 2019-01-23  Tom Tromey  <tom@tromey.com>
13453             Andrew Burgess  <andrew.burgess@embecosm.com>
13454             Pedro Alves  <palves@redhat.com>
13455
13456 2019-01-23  Pedro Alves  <palves@redhat.com>
13457
13458         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13459
13460 2019-01-23  Pedro Alves  <palves@redhat.com>
13461             Andrew Burgess  <andrew.burgess@embecosm.com>
13462
13463         * gdbthread.h: Include "common/forward-scope-exit.h".
13464         (scoped_finish_thread_state): Redefine custom class in terms of
13465         forward_scope_exit.
13466
13467 2019-01-23  Pedro Alves  <palves@redhat.com>
13468             Andrew Burgess  <andrew.burgess@embecosm.com>
13469
13470         * common/forward-scope-exit.h: New file.
13471
13472 2019-01-23  Pedro Alves  <palves@redhat.com>
13473             Andrew Burgess  <andrew.burgess@embecosm.com>
13474             Tom Tromey  <tom@tromey.com>
13475
13476         * common/scope-exit.h: New file.
13477
13478 2019-01-23  Pedro Alves  <palves@redhat.com>
13479
13480         * common/preprocessor.h (ESC): Rename to ...
13481         (ESC_PARENS): ... this.
13482         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13483         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13484
13485 2019-01-23  Tom Tromey  <tom@tromey.com>
13486
13487         * language.h (class scoped_switch_to_sym_language_if_auto):
13488         Initialize m_lang in both cases.
13489
13490 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13491
13492         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13493         with XCNEW.
13494
13495 2019-01-22  Tom Tromey  <tom@tromey.com>
13496
13497         * corelow.c: Do not include sys/file.h.
13498
13499 2019-01-22  Tom Tromey  <tom@tromey.com>
13500
13501         * tui/tui-wingeneral.h: Include gdb_curses.h.
13502
13503 2019-01-22  Tom Tromey  <tom@tromey.com>
13504
13505         * source-cache.h (class source_cache) <get_source_lines,
13506         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13507
13508 2019-01-22  Tom Tromey  <tom@tromey.com>
13509
13510         * remote-fileio.h (struct remote_target): Declare.
13511
13512 2019-01-22  Tom Tromey  <tom@tromey.com>
13513
13514         * python/py-arch.c: Do not include py-ref.h.
13515         * python/py-bpevent.c: Do not include py-ref.h.
13516         * python/py-cmd.c: Do not include py-ref.h.
13517         * python/py-continueevent.c: Do not include py-ref.h.
13518         * python/py-event.h: Do not include py-ref.h.
13519         * python/py-evtregistry.c: Do not include py-ref.h.
13520         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13521         * python/py-frame.c: Do not include py-ref.h.
13522         * python/py-framefilter.c: Do not include py-ref.h.
13523         * python/py-function.c: Do not include py-ref.h.
13524         * python/py-infevents.c: Do not include py-ref.h.
13525         * python/py-linetable.c: Do not include py-ref.h.
13526         * python/py-objfile.c: Do not include py-ref.h.
13527         * python/py-param.c: Do not include py-ref.h.
13528         * python/py-prettyprint.c: Do not include py-ref.h.
13529         * python/py-progspace.c: Do not include py-ref.h.
13530         * python/py-symbol.c: Do not include py-ref.h.
13531         * python/py-symtab.c: Do not include py-ref.h.
13532         * python/py-type.c: Do not include py-ref.h.
13533         * python/py-unwind.c: Do not include py-ref.h.
13534         * python/py-utils.c: Do not include py-ref.h.
13535         * python/py-value.c: Do not include py-ref.h.
13536         * python/py-varobj.c: Do not include py-ref.h.
13537         * python/py-xmethods.c: Do not include py-ref.h.
13538         * python/python.c: Do not include py-ref.h.
13539         * varobj.c: Do not include py-ref.h.
13540
13541 2019-01-22  Tom Tromey  <tom@tromey.com>
13542
13543         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13544         keyword for bcache.
13545
13546 2019-01-22  Tom Tromey  <tom@tromey.com>
13547
13548         * compile/compile-cplus-types.c: Remove a comment by #include.
13549
13550 2019-01-22  Tom Tromey  <tom@tromey.com>
13551
13552         * compile/gcc-c-plugin.h: Include compile-internal.h.
13553
13554 2019-01-22  Tom Tromey  <tom@tromey.com>
13555
13556         * stabsread.c (EXTERN): Do not define.
13557         (symnum, next_symbol_text_func, processing_gcc_compilation)
13558         (within_function, global_sym_chain, global_stabs)
13559         (previous_stab_code, this_object_header_files)
13560         (n_this_object_header_files)
13561         (n_allocated_this_object_header_files): Define.
13562         * stabsread.h (EXTERN): Never define.  Use "extern".
13563
13564 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13565
13566         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13567         history_value.
13568
13569 2019-01-21  Tom Tromey  <tom@tromey.com>
13570
13571         * ui-out.c: Fix includes.
13572         * tui/tui-source.c: Fix includes.
13573         * target.c: Fix includes.
13574         * remote.c: Fix includes.
13575         * regcache.c: Fix includes.
13576         * python/py-block.c: Fix includes.
13577         * printcmd.c: Fix includes.
13578         * or1k-tdep.c: Fix includes.
13579         * mi/mi-main.c: Fix includes.
13580         * m32r-tdep.c: Fix includes.
13581         * csky-tdep.c: Fix includes.
13582         * compile/compile-cplus-types.c: Fix includes.
13583         * cli/cli-interp.c: Fix includes.
13584
13585 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13586
13587         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13588         for padding.
13589
13590 2019-01-16  Tom Tromey  <tom@tromey.com>
13591
13592         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13593         earlier.
13594         (struct objfile) <msymbols_range>: Move from top level.
13595         <msymbols>: New method.
13596         (class objfile_msymbols): Remove.
13597         * symtab.c (default_collect_symbol_completion_matches_break_on):
13598         Update.
13599         * symmisc.c (dump_msymbols): Update.
13600         * stabsread.c (scan_file_globals): Update.
13601         * objc-lang.c (info_selectors_command, info_classes_command)
13602         (find_methods): Update.
13603         * minsyms.c (find_solib_trampoline_target): Update.
13604         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13605         * coffread.c (coff_symfile_read): Update.
13606         * ada-lang.c (ada_lookup_simple_minsym)
13607         (ada_collect_symbol_completion_matches): Update.
13608
13609 2019-01-16  Tom Tromey  <tom@tromey.com>
13610
13611         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13612         type.  Remove no-argument constructor.
13613         <iterator::operator++>: Simplify.
13614         <begin>: Update.
13615         <end>: Use minimal_symbol_count.
13616
13617 2019-01-16  Tom Tromey  <tom@tromey.com>
13618
13619         * objfiles.h (struct objfile) <psymtabs>: New method.
13620         (class objfile_psymtabs): Remove.
13621         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13622         typedef.
13623         <range>: New method.
13624         (require_partial_symbols): Change return type.
13625         * psymtab.c (require_partial_symbols)
13626         (psym_expand_symtabs_matching): Update.
13627         * mdebugread.c (parse_partial_symbols): Update.
13628         * dbxread.c (dbx_end_psymtab): Update.
13629
13630 2019-01-15  Tom Tromey  <tom@tromey.com>
13631
13632         * symtab.c (lookup_objfile_from_block)
13633         (lookup_symbol_in_objfile_symtabs)
13634         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13635         (find_line_symtab, info_sources_command)
13636         (default_collect_symbol_completion_matches_break_on)
13637         (make_source_files_completion_list): Update.
13638         * symmisc.c (print_objfile_statistics, dump_objfile)
13639         (maintenance_print_symbols, maintenance_info_symtabs)
13640         (maintenance_check_symtabs, maintenance_info_line_tables):
13641         Update.
13642         * source.c (select_source_symtab)
13643         (forget_cached_source_info_for_objfile): Update.
13644         * objfiles.h (class objfile_compunits): Remove.
13645         (struct objfile) <compunits_range>: New typedef.
13646         (compunits): New method.
13647         * objfiles.c (objfile_relocate1): Update.
13648         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13649         * maint.c (count_symtabs_and_blocks): Update.
13650         * linespec.c (iterate_over_all_matching_symtabs): Update.
13651         * cp-support.c (add_symbol_overload_list_qualified): Update.
13652         * coffread.c (coff_symtab_read): Update.
13653         * ada-lang.c (add_nonlocal_symbols)
13654         (ada_collect_symbol_completion_matches)
13655         (ada_add_global_exceptions): Update.
13656
13657 2019-01-15  Tom Tromey  <tom@tromey.com>
13658
13659         * progspace.h (program_space) <objfiles_safe_range>: New
13660         typedef.
13661         <objfiles_safe>: New method.
13662         * objfiles.h (class all_objfiles_safe): Remove.
13663         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13664         * jit.c (jit_inferior_exit_hook): Update.
13665
13666 2019-01-17  Tom Tromey  <tom@tromey.com>
13667
13668         * progspace.h (program_space) <objfiles_range>: New typedef.
13669         <objfiles>: New method.
13670         <objfiles_head>: Rename from objfiles.
13671         (object_files): Update.
13672         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13673         * guile/scm-pretty-print.c
13674         (ppscm_find_pretty_printer_from_objfiles): Update.
13675         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13676         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13677         Update.
13678         * python/py-progspace.c (pspy_get_objfiles): Update.
13679         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13680         Update.
13681         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13682         (objfpy_lookup_objfile_by_build_id): Update.
13683         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13684         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13685         Update.
13686         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13687         (expand_symtab_containing_pc, lookup_objfile_from_block)
13688         (lookup_static_symbol, basic_lookup_transparent_type)
13689         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13690         (find_line_symtab, info_sources_command)
13691         (default_collect_symbol_completion_matches_break_on)
13692         (make_source_files_completion_list, find_main_name): Update.
13693         * symmisc.c (print_symbol_bcache_statistics)
13694         (print_objfile_statistics, maintenance_print_symbols)
13695         (maintenance_print_msymbols, maintenance_print_objfiles)
13696         (maintenance_info_symtabs, maintenance_check_symtabs)
13697         (maintenance_expand_symtabs, maintenance_info_line_tables):
13698         Update.
13699         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13700         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13701         (map_overlay_command, unmap_overlay_command)
13702         (simple_overlay_update, expand_symtabs_matching)
13703         (map_symbol_filenames): Update.
13704         * symfile-debug.c (set_debug_symfile): Update.
13705         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13706         Update.
13707         * source.c (select_source_symtab, forget_cached_source_info):
13708         Update.
13709         * solib.c (solib_read_symbols): Update.
13710         * solib-spu.c (append_ocl_sos): Update.
13711         * psymtab.c (maintenance_print_psymbols)
13712         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13713         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13714         * printcmd.c (info_symbol_command): Update.
13715         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13716         Update.
13717         * objfiles.h (class all_objfiles): Remove.
13718         * objfiles.c (have_partial_symbols, have_full_symbols)
13719         (have_minimal_symbols, qsort_cmp, update_section_map)
13720         (shared_objfile_contains_address_p)
13721         (default_iterate_over_objfiles_in_search_order): Update.
13722         * objc-lang.c (info_selectors_command, info_classes_command)
13723         (find_methods): Update.
13724         * minsyms.c (find_solib_trampoline_target): Update.
13725         * maint.c (maintenance_info_sections)
13726         (maintenance_translate_address, count_symtabs_and_blocks):
13727         Update.
13728         * main.c (captured_main_1): Update.
13729         * linux-thread-db.c (try_thread_db_load_from_pdir)
13730         (has_libpthread): Update.
13731         * linespec.c (iterate_over_all_matching_symtabs)
13732         (search_minsyms_for_name): Update.
13733         * jit.c (jit_find_objf_with_entry_addr): Update.
13734         * hppa-tdep.c (find_unwind_entry)
13735         (hppa_lookup_stub_minimal_symbol): Update.
13736         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13737         Update.
13738         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13739         (elf_gnu_ifunc_resolve_by_got): Update.
13740         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13741         * dwarf-index-write.c (save_gdb_index_command): Update.
13742         * cp-support.c (add_symbol_overload_list_qualified): Update.
13743         * breakpoint.c (create_overlay_event_breakpoint)
13744         (create_longjmp_master_breakpoint)
13745         (create_std_terminate_master_breakpoint)
13746         (create_exception_master_breakpoint): Update.
13747         * blockframe.c (find_pc_partial_function): Update.
13748         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13749         (ada_collect_symbol_completion_matches)
13750         (ada_add_global_exceptions): Update.
13751
13752 2019-01-17  Tom Tromey  <tom@tromey.com>
13753
13754         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13755         declare VEC.
13756         (solib_target_parse_libraries): Change return type.
13757         (library_list_start_segment, library_list_start_section)
13758         (library_list_end_library, library_list_start_library); Update.
13759         (solib_target_free_library_list): Remove.
13760         (solib_target_parse_libraries): Remove cleanup.  Change return
13761         type.
13762         (solib_target_current_sos): Update.
13763
13764 2019-01-17  Tom Tromey  <tromey@bapiya>
13765
13766         * valprint.c: Replace "the the" with "the".
13767         * symtab.c: Replace "the the" with "the".
13768         * solib.c: Replace "the the" with "the".
13769         * solib-dsbt.c: Replace "the the" with "the".
13770         * linespec.c: Replace "the the" with "the".
13771         * dwarf2loc.h: Replace "the the" with "the".
13772         * amd64-windows-tdep.c: Replace "the the" with "the".
13773         * aarch64-tdep.c: Replace "the the" with "the".
13774
13775 2019-01-16  Keith Seitz  <keiths@redhat.com>
13776
13777         PR gdb/23773
13778         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13779         <builder>: Rename to ..
13780         <m_builder>: ... this and make private.
13781         (dwarf2_cu::get_builder): New method.  Change all users of
13782         `builder' to use this method.
13783         (dwarf2_start_symtab): Move to ...
13784         (dwarf2_cu::start_symtab): ... here.  Update all callers
13785         (setup_type_unit_groups): Move to ...
13786         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13787         callers.
13788         (dwarf2_cu::reset_builder): New method.
13789         (process_full_compunit, process_full_type_unit): Use
13790         dwarf2_cu::reset_builder.
13791         (follow_die_offset): Record the ancestor CU if it is different
13792         from the followed DIE's CU.
13793         (follow_die_sig_1): Likewise.
13794
13795 2019-01-15  Tom Tromey  <tom@tromey.com>
13796
13797         * remote.c (class remote_state) <buf>: Now a char_vector.
13798         <buf_size>: Remove.
13799         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13800         parameter.
13801         (remote_target::getpkt_or_notif_sane_1)
13802         (remote_target::getpkt_sane)
13803         (remote_target::getpkt_or_notif_sane): Likewise.
13804         (class remote_target) <putpkt>: New overload.
13805         (remote_target::read_frame): Change type of "buf_p".  Remove
13806         sizeof_p parameter.
13807         (packet_ok): New overload.
13808         (packet_check_result): New overload.
13809         Update all uses.
13810
13811 2019-01-14  Tom Tromey  <tom@tromey.com>
13812
13813         * remote-notif.c (handle_notification, remote_notif_ack)
13814         (remote_notif_parse): Make "buf" const.
13815         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13816         const.
13817         (remote_notif_parse, remote_notif_ack, handle_notification):
13818         Likewise.
13819         * remote.c (remote_notif_stop_parse): Make "buf" const.
13820         (remote_target::remote_parse_stop_reply): Make "buf" const.
13821         (remote_notif_stop_ack): Make "buf" const.
13822
13823 2019-01-14  Tom Tromey  <tom@tromey.com>
13824
13825         * remote.c (remote_console_output): Make parameter const.
13826
13827 2019-01-14  Tom Tromey  <tom@tromey.com>
13828
13829         * target-debug.h (target_debug_print_signals): Constify.
13830         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13831         * procfs.c (procfs_target::pass_signals): Update.
13832         * linux-nat.c (linux_nat_target::pass_signals): Update.
13833         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13834         * target-delegates.c: Rebuild.
13835         * remote.c (remote_target::program_signals): Update.
13836         (remote_target::pass_signals): Update.
13837         * target.c (target_pass_signals): Constify argument.
13838         (target_program_signals): Likewise.
13839         * target.h (struct target_ops) <pass_signals, program_signals>:
13840         Constify argument.
13841         (target_pass_signals, target_program_signals): Constify argument.
13842
13843 2019-01-14  Tom Tromey  <tom@tromey.com>
13844
13845         PR tui/28819:
13846         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13847
13848 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13849
13850         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13851         field.
13852         * rs6000-tdep.c: Include reggroups.h.
13853         (IS_V_ALIAS_PSEUDOREG): Define.
13854         (rs6000_register_name): Return names for the "vX" aliases.
13855         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13856         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13857         aliases.  Call default_register_reggroup_p for all other
13858         pseudo-registers.
13859         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13860         New functions.
13861         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13862         Handle "vX" aliases.
13863         (v_alias_pseudo_register_collect): New function.
13864         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13865         (rs6000_gdbarch_init): Initialize "vX" aliases as
13866         pseudo-registers.  Restore registration of
13867         rs6000_pseudo_register_reggroup_p with
13868         set_tdesc_pseudo_register_reggroup_p.
13869
13870 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13871
13872         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13873         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13874         set_gdbarch_num_pseudo_regs.
13875
13876 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13877
13878         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13879         Remove arg prefixname, add do_set and do_show.
13880         Add member functions set_list and show_list.
13881         * cli/cli-style.c (class cli_style_option): Update accordingly.
13882         (style_set_list): Move to file scope.
13883         (style_show_list): Likewise.
13884         (set_style): Call help_list.
13885         (show_style): Call cmd_show_list.
13886         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13887         Update to use the new macro.
13888
13889 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13890
13891         * ada-lang.c (_initialize_ada_language): Expand the help text
13892         for the "catch exception" command.
13893
13894 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13895
13896         * symtab.c (matching_obj_sections): Initialize obj,
13897         declare it closer to its usage.
13898
13899 2019-01-10  Tom Tromey  <tom@tromey.com>
13900
13901         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13902         (basic_inf_threads_range): Remove.
13903         (inf_threads_range, inf_non_exited_threads_range)
13904         (safe_inf_threads_range): Use next_adapter.
13905
13906 2019-01-10  Keith Seitz  <keiths@redhat.com>
13907
13908         PR gdb/23712
13909         PR symtab/23010
13910         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13911         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13912
13913 2019-01-10  Keith Seitz  <keiths@redhat.com>
13914
13915         PR gdb/23712
13916         PR symtab/23010
13917         * dictionary.c (pending_to_vector): Remove.
13918         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13919         Remove _1 suffix, replacing functions of the same name.  Update
13920         all callers.
13921         (dict_create_hashed, dict_create_hashed_expandable)
13922         (dict_create_linear, dict_create_linear_expandable, dict_free)
13923         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13924         Make functions static.
13925
13926 2019-01-10  Keith Seitz  <keiths@redhat.com>
13927
13928         PR gdb/23712
13929         PR symtab/23010
13930         * dictionary.h (struct dictionary): Replace declaration with
13931         multidictionary.
13932         (dict_create_hashed, dict_create_hashed_expandable)
13933         (dict_create_linear, dict_create_linear_expandable)
13934         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13935         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13936         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13937         taking multidictionary argument.
13938         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13939         * block.h (struct block) <dict>: Change to multidictionary
13940         and rename `multidict'.
13941         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13942         symmisc.c: Update all dictionary references to multidictionary.
13943
13944 2019-01-10  Keith Seitz  <keiths@redhat.com>
13945
13946         PR gdb/23712
13947         PR symtab/23010
13948         * dictionary.c: Include unordered_map.
13949         (pending_to_vector): New function.
13950         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13951         Rewrite the non-"_1" functions to take vector instead
13952         of linked list.
13953         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13954         "new" _1 versions of the same name.
13955         (multidictionary): Define.
13956         (std::hash<enum language): New definition.
13957         (collate_pending_symbols_by_language, mdict_create_hashed)
13958         (mdict_create_hashed_expandable, mdict_create_linear)
13959         (mdict_create_linear_expandable, mdict_free)
13960         (find_language_dictionary, create_new_language_dictionary)
13961         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13962         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13963         (mdict_size, mdict_empty): New functions.
13964         * dictionary.h (mdict_iterator): Define.
13965
13966 2019-01-10  Pedro Alves  <palves@redhat.com>
13967
13968         * breakpoint.c (read_uploaded_action)
13969         (create_tracepoint_from_upload): Adjust to use
13970         gdb::unique_xmalloc_ptr.
13971         * ctf.c (ctf_write_uploaded_tp):
13972         (SET_ARRAY_FIELD): Use emplace_back.
13973         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13974         * tracefile-tfile.c (tfile_write_uploaded_tp):
13975         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13976         gdb::unique_xmalloc_ptr.
13977         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13978         at_string, cond_string, cmd_strings>: Replace char pointers
13979         with gdb::unique_xmalloc_ptr.
13980
13981 2019-01-10  Pedro Alves  <palves@redhat.com>
13982
13983         * solib-target.c (library_list_start_library): Don't xstrdup name.
13984
13985 2019-01-10  Pedro Alves  <palves@redhat.com>
13986
13987         * mdebugread.c (parse_partial_symbols): Use
13988         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13989
13990 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13991
13992         * linux-fork.c (scoped_switch_fork_info)
13993         <~scoped_switch_fork_info>: Fix incorrect variable name.
13994
13995 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13996
13997         * linux-fork.c (scoped_switch_fork_info)
13998         <scoped_switch_fork_info>: Make explicit.
13999         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14000
14001 2019-01-10  Tom Tromey  <tom@tromey.com>
14002
14003         * objfiles.h (objfile::reset_psymtabs): Update.
14004         * objfiles.c (objfile::objfile): Update.
14005         * psymtab.h (psymtab_storage::obstack): Update.
14006         (psymtab_storage::m_obstack): Use gdb::optional.
14007         (class psymtab_storage): Update comment.  Remove objfile
14008         parameter.
14009         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14010
14011 2019-01-10  Tom Tromey  <tom@tromey.com>
14012
14013         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14014         <free_psymtabs>: Now private.
14015         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14016         (allocate_psymtab): Use new method.
14017
14018 2019-01-10  Tom Tromey  <tom@tromey.com>
14019
14020         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14021         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14022         * mdebugread.c (parse_partial_symbols): Use
14023         allocate_dependencies.
14024         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14025         allocate_dependencies.
14026         (process_psymtab_comp_unit_reader)
14027         (build_type_psymtab_dependencies): Likewise.
14028         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14029
14030 2019-01-10  Tom Tromey  <tom@tromey.com>
14031
14032         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14033         PSYMBOL_SET_LANGUAGE.
14034         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14035
14036 2019-01-10  Tom Tromey  <tom@tromey.com>
14037
14038         * psymtab.h (psymtab_storage::obstack): New method.
14039         <m_obstack>: Rename from obstack; now private.
14040         * psymtab.c (psymtab_storage): Update.
14041         * dwarf2read.c (create_addrmap_from_index)
14042         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14043         Update.
14044
14045 2019-01-10  Tom Tromey  <tom@tromey.com>
14046
14047         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14048         * objfiles.h (objfile::reset_psymtabs): New method.
14049
14050 2019-01-10  Tom Tromey  <tom@tromey.com>
14051
14052         * symmisc.c (print_symbol_bcache_statistics): Update.
14053         (print_objfile_statistics): Update.
14054         * symfile.c (reread_symbols): Update.
14055         * psymtab.h (class psymtab_storage): New.
14056         * psymtab.c (psymtab_storage): New constructor.
14057         (~psymtab_storage): New destructor.
14058         (require_partial_symbols): Update.
14059         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14060         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14061         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14062         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14063         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14064         (start_psymtab_common, end_psymtab_common)
14065         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14066         (allocate_psymtab): Update.
14067         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14068         Update.
14069         (dump_psymtab_addrmap, maintenance_print_psymbols)
14070         (maintenance_check_psymtabs): Update.
14071         (class objfile_psymtabs): Move to objfiles.h.
14072         * psympriv.h (discard_psymtab): Now inline.
14073         (psymtab_discarder::psymtab_discarder): Update.
14074         (psymtab_discarder::~psymtab_discarder): Update.
14075         (ALL_OBJFILE_PSYMTABS): Rewrite.
14076         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14077         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14078         Remove fields.
14079         <partial_symtabs>: New field.
14080         (class objfile_psymtabs): Move from psymtab.h.  Update.
14081         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14082         psymbol_cache.
14083         (objfile::~objfile): Don't destroy psymbol_cache.
14084         * mdebugread.c (parse_partial_symbols): Update.
14085         * dwarf2read.c (create_addrmap_from_index)
14086         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14087         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14088         (add_partial_subprogram, dwarf2_ranges_read): Update.
14089         * dwarf-index-write.c (write_address_map)
14090         (write_one_signatured_type, recursively_write_psymbols)
14091         (class debug_names, class debug_names, write_psymtabs_to_index):
14092         Update.
14093
14094 2019-01-10  Tom Tromey  <tom@tromey.com>
14095
14096         * symtab.h (SYMBOL_SET_NAMES): Update.
14097         (symbol_set_names): Update.
14098         (MSYMBOL_SET_NAMES): Update.
14099         * symtab.c (symbol_set_names): Change argument to be an
14100         objfile_per_bfd_storage.
14101         * psymtab.c (add_psymbol_to_bcache): Update.
14102         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14103
14104 2019-01-10  Tom Tromey  <tom@tromey.com>
14105
14106         * symtab.c (create_demangled_names_hash): Change argument to be an
14107         objfile_per_bfd_storage.
14108         (symbol_set_names): Update.
14109
14110 2019-01-10  Tom Tromey  <tom@tromey.com>
14111
14112         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14113         init_psymbol_list.
14114         * psymtab.c (init_psymbol_list): Do nothing if already called.
14115         * psympriv.h (init_psymbol_list): Add comment.
14116         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14117         init_psymbol_list.
14118         * dbxread.c (dbx_symfile_read): Unconditionally call
14119         init_psymbol_list.
14120
14121 2019-01-10  Tom Tromey  <tom@tromey.com>
14122
14123         * xcoffread.c (scan_xcoff_symtab): Update.
14124         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14125         "where".
14126         * mdebugread.c (parse_partial_symbols)
14127         (handle_psymbol_enumerators): Update.
14128         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14129         * dbxread.c (read_dbx_symtab): Update.
14130         * psympriv.h (psymbol_placement): New enum.
14131         (add_psymbol_to_list): Update.
14132
14133 2019-01-10  Tom Tromey  <tom@tromey.com>
14134
14135         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14136         static_psymbols parameters.
14137         (scan_xcoff_symtab): Update.
14138         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14139         static_psymbols parameters.
14140         * psympriv.h (start_psymtab_common): Update.
14141         * mdebugread.c (parse_partial_symbols): Update.
14142         * dwarf2read.c (create_partial_symtab): Update.
14143         * dbxread.c (read_dbx_symtab): Update.
14144         (start_psymtab): Remove global_psymbols and static_psymbols
14145         parameters.
14146
14147 2019-01-10  Tom Tromey  <tom@tromey.com>
14148
14149         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14150         * psymtab.c (allocate_psymtab): Add comment.
14151         * psympriv.h (allocate_psymtab): Add comment.
14152         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14153         initializations.
14154         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14155
14156 2019-01-10  Tom Tromey  <tom@tromey.com>
14157
14158         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14159         Don't declare.
14160         * mipsread.c: Include mdebugread.h.
14161         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14162         Declare.
14163         * elfread.c: Include mdebugread.h.
14164
14165 2019-01-09  Tom Tromey  <tom@tromey.com>
14166
14167         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14168         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14169         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14170         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14171         (psym_lookup_symbol, psym_find_last_source_symtab)
14172         (psym_forget_cached_source_info, psym_print_stats)
14173         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14174         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14175         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14176         (psym_find_compunit_symtab_by_address)
14177         (maintenance_print_psymbols, maintenance_info_psymtabs)
14178         (maintenance_check_psymtabs): Use ranged for.
14179         * psymtab.h (class objfile_psymtabs): New.
14180         (require_partial_symbols): Return objfile_psymtabs.
14181         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14182
14183 2019-01-09  Tom Tromey  <tom@tromey.com>
14184
14185         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14186         (find_pc_mapped_section, list_overlays_command)
14187         (map_overlay_command, unmap_overlay_command)
14188         (simple_overlay_update): Use all_objfiles.
14189         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14190         * printcmd.c (info_symbol_command): Use all_objfiles.
14191         * objfiles.h (ALL_OBJSECTIONS): Remove.
14192         * maint.c (maintenance_translate_address): Use all_objfiles.
14193         * gcore.c (gcore_create_callback): Use all_objfiles.
14194         (objfile_find_memory_regions): Likewise.
14195
14196 2019-01-09  Tom Tromey  <tom@tromey.com>
14197
14198         * symtab.c (find_line_symtab, info_sources_command)
14199         (make_source_files_completion_list): Use objfile_compunits.
14200         * source.c (select_source_symtab): Use objfile_compunits.
14201         * objfiles.h (struct objfile): Update comment.
14202         (ALL_OBJFILES): Remove.
14203         (ALL_FILETABS): Remove.
14204         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14205         objfile_compunits.
14206
14207 2019-01-09  Tom Tromey  <tom@tromey.com>
14208
14209         * symmisc.c (print_objfile_statistics, dump_objfile)
14210         (maintenance_print_symbols): Use compunit_filetabs.
14211         * source.c (forget_cached_source_info_for_objfile): Use
14212         compunit_filetabs.
14213         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14214         (ALL_FILETABS): Use compunit_filetabs.
14215         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14216         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14217
14218 2019-01-09  Tom Tromey  <tom@tromey.com>
14219
14220         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14221         (compunit_filetabs): New.
14222         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14223         compunit_filetabs.
14224         (info_sources_command, make_source_files_completion_list): Remove
14225         declaration.
14226         * symmisc.c (print_objfile_statistics, dump_objfile)
14227         (maintenance_print_symbols): Remove declaration.
14228         (maintenance_info_symtabs): Use compunit_filetabs.
14229         (maintenance_info_line_tables): Likewise.
14230         * source.c (select_source_symtab): Change local variable name.
14231         (forget_cached_source_info_for_objfile): Remove declaration.
14232         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14233         * objfiles.c (objfile_relocate1): Remove declaration.
14234         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14235         declaration.
14236         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14237         * coffread.c (coff_symtab_read): Remove declaration.
14238         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14239         compunit_filetabs.
14240
14241 2019-01-09  Tom Tromey  <tom@tromey.com>
14242
14243         * symtab.c (lookup_objfile_from_block)
14244         (find_pc_sect_compunit_symtab, search_symbols)
14245         (default_collect_symbol_completion_matches_break_on): Use
14246         objfile_compunits.
14247         * objfiles.h (ALL_COMPUNITS): Remove.
14248         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14249         * cp-support.c (add_symbol_overload_list_qualified): Use
14250         objfile_compunits.
14251         * ada-lang.c (ada_collect_symbol_completion_matches)
14252         (ada_add_global_exceptions): Use objfile_compunits.
14253
14254 2019-01-09  Tom Tromey  <tom@tromey.com>
14255
14256         * source.c (select_source_symtab)
14257         (forget_cached_source_info_for_objfile): Remove declaration.
14258         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14259         declaration.
14260         * maint.c (count_symtabs_and_blocks): Remove declaration.
14261         * cp-support.c (add_symbol_overload_list_qualified): Remove
14262         declaration.
14263         * coffread.c (coff_symtab_read): Remove declaration.
14264         * symtab.c (lookup_symbol_in_objfile_symtabs)
14265         (basic_lookup_transparent_type_1): Use objfile_compunits.
14266         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14267         (info_sources_command, search_symbols)
14268         (default_collect_symbol_completion_matches_break_on)
14269         (make_source_files_completion_list): Remove declaration.
14270         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14271         (ada_collect_symbol_completion_matches)
14272         (ada_add_global_exceptions): Remove declaration.
14273         * linespec.c (iterate_over_all_matching_symtabs): Use
14274         objfile_compunits.
14275         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14276         (class objfile_compunits): New.
14277         (ALL_COMPUNITS): Use objfile_compunits.
14278         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14279         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14280         objfile_compunits.
14281         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14282
14283 2019-01-09  Tom Tromey  <tom@tromey.com>
14284
14285         * symtab.c (search_symbols)
14286         (default_collect_symbol_completion_matches_break_on): Use
14287         objfile_msymbols.
14288         * ada-lang.c (ada_lookup_simple_minsym)
14289         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14290         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14291         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14292         objfile_msymbols.
14293         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14294         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14295         * objc-lang.c (find_methods): Use objfile_msymbols.
14296         (info_selectors_command, info_classes_command): Likewise.
14297         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14298         * objfiles.h (class objfile_msymbols): New.
14299         (ALL_OBJFILE_MSYMBOLS): Remove.
14300         (ALL_MSYMBOLS): Remove.
14301
14302 2019-01-09  Tom Tromey  <tom@tromey.com>
14303
14304         * common/next-iterator.h (next_adapter): Add Iterator template
14305         parameter.
14306         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14307         (class all_objfiles_safe): New.
14308         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14309         * objfiles.c (put_objfile_before): Update comment.
14310         (add_separate_debug_objfile): Likewise.
14311         (free_all_objfiles): Use all_objfiles_safe.
14312         (objfile_purge_solibs): Likewise.
14313
14314 2019-01-09  Tom Tromey  <tom@tromey.com>
14315
14316         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14317         (expand_symtab_containing_pc, lookup_static_symbol)
14318         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14319         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14320         all_objfiles.
14321         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14322         * breakpoint.c (create_overlay_event_breakpoint)
14323         (create_longjmp_master_breakpoint)
14324         (create_std_terminate_master_breakpoint)
14325         (create_exception_master_breakpoint): Use all_objfiles.
14326         * linux-thread-db.c (try_thread_db_load_from_pdir)
14327         (has_libpthread): Use all_objfiles.
14328         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14329         * linespec.c (iterate_over_all_matching_symtabs)
14330         (search_minsyms_for_name): Use all_objfiles.
14331         * maint.c (maintenance_info_sections): Use all_objfiles.
14332         * main.c (captured_main_1): Use all_objfiles.
14333         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14334         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14335         * guile/scm-pretty-print.c
14336         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14337         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14338         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14339         (maintenance_print_msymbols): Use all_objfiles.
14340         * source.c (select_source_symtab): Use all_objfiles.
14341         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14342         * symfile.c (remove_symbol_file_command)
14343         (expand_symtabs_matching, map_symbol_filenames): Use
14344         all_objfiles.
14345         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14346         all_objfiles.
14347         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14348         * objc-lang.c (find_methods): Use all_objfiles.
14349         * objfiles.c (have_partial_symbols, have_full_symbols)
14350         (have_minimal_symbols, qsort_cmp)
14351         (default_iterate_over_objfiles_in_search_order): Use
14352         all_objfiles.
14353         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14354         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14355         (maintenance_check_psymtabs): Use all_objfiles.
14356         (ALL_PSYMTABS): Remove.
14357         * compile/compile-object-run.c (do_module_cleanup): Use
14358         all_objfiles.
14359         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14360         * cp-support.c (add_symbol_overload_list_qualified): Use
14361         all_objfiles.
14362         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14363         Use all_objfiles.
14364         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14365         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14366         all_objfiles.
14367         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14368         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14369         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14370         Uses all_objfiles.
14371         * solib.c (solib_read_symbols): Use all_objfiles
14372
14373 2019-01-09  Tom Tromey  <tom@tromey.com>
14374
14375         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14376         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14377         all_objfiles.
14378         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14379         * symmisc.c (print_symbol_bcache_statistics)
14380         (print_objfile_statistics, maintenance_print_objfiles)
14381         (maintenance_info_symtabs, maintenance_check_symtabs)
14382         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14383         all_objfiles.
14384         * source.c (forget_cached_source_info): Use all_objfiles.
14385         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14386         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14387         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14388         * objfiles.c (update_section_map): Use all_objfiles.
14389         (shared_objfile_contains_address_p): Likewise.
14390         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14391         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14392
14393 2019-01-09  Tom Tromey  <tom@tromey.com>
14394
14395         * common/next-iterator.h: New file.
14396         * objfiles.h (class all_objfiles): New.
14397         (struct objfile_iterator): New.
14398
14399 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14400
14401         * NEWS: Move the description of the changed "frame", "select-frame",
14402          and "info frame" commands to the Changed commands section.
14403
14404 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14405
14406         * gdbtypes.c (check_stub_method_group): Remove handling of old
14407         mangling schemes.
14408         * linespec.c (find_methods): Likewise.
14409         * stabsread.c (read_member_functions): Likewise.
14410         * valops.c (search_struct_method): Likewise.
14411         (value_struct_elt_for_reference): Likewise.
14412         * NEWS: Mention this change.
14413
14414 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14415
14416         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14417         print_source_lines.
14418         * source.c (print_source_lines_base): Update line number check.
14419         (print_source_lines): New function.
14420         (source_lines_range::source_lines_range): New function.
14421         * source.h (class source_lines_range): New class.
14422         (print_source_lines): New declaration.
14423
14424 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14425
14426         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14427
14428 2019-01-08  Tom Tromey  <tom@tromey.com>
14429             Simon Marchi  <simon.marchi@ericsson.com>
14430
14431         PR gdb/24060
14432         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14433         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14434         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14435         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14436         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14437         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14438
14439 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14440
14441         * source.c (select_source_symtab): Move header comment to
14442         declaration in source.h.
14443         (forget_cached_source_info_for_objfile): Likewise.
14444         (forget_cached_source_info): Likewise.
14445         (identify_source_line): Likewise.
14446         * source.h (identify_source_line): Move declaration from symtab.h
14447         and add comment from source.c
14448         (print_source_lines): Likewise.
14449         (forget_cached_source_info_for_objfile): Likewise.
14450         (forget_cached_source_info): Likewise.
14451         (select_source_symtab): Likewise.
14452         (enum print_source_lines_flag): Move definition from symtab.h.
14453         * symtab.h (identify_source_line): Move declaration to source.h.
14454         (print_source_lines): Likewise.
14455         (forget_cached_source_info_for_objfile): Likewise.
14456         (forget_cached_source_info): Likewise.
14457         (select_source_symtab): Likewise.
14458         (enum print_source_lines_flag): Move definition to source.h.
14459         * tui/tui-hooks.c: Add 'source.h' include.
14460
14461 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14462
14463         * source.c (print_source_lines_base): Handle requests to print
14464         reverse line number sequences, and guard against empty lines
14465         string.
14466
14467 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14468
14469         * source.c (print_source_lines_base): Fix skip of '\r' if next
14470         character is '\n'.
14471
14472 2019-01-06  Tom Tromey  <tom@tromey.com>
14473
14474         * c-exp.y (struct c_parse_state) <macro_original_text,
14475         expansion_obstack>: New member.
14476         (macro_original_text, expansion_obstack): Remove globals.
14477         (scan_macro_expansion, scanning_macro_expansion)
14478         (finished_macro_expansion): Update.
14479         (scan_macro_cleanup): Remove.
14480         (yylex, c_parse): Update.
14481
14482 2019-01-06  Tom Tromey  <tom@tromey.com>
14483
14484         * c-exp.y (struct c_parse_state) <strings>: New member.
14485         (operator_stoken): Update.
14486
14487 2019-01-06  Tom Tromey  <tom@tromey.com>
14488
14489         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14490         (union type_stack_elt) <typelist_val>: Now a pointer to
14491         std::vector.
14492         (type_stack_cleanup): Don't declare.
14493         (push_typelist): Update.
14494         * parse.c (pop_typelist): Return a std::vector.
14495         (push_typelist): Take a std::vector.
14496         (follow_types): Update.  Do not free args.
14497         (type_stack_cleanup): Remove.
14498         * c-exp.y (struct c_parse_state): New.
14499         (cpstate): New global.
14500         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14501         (nonempty_typelist): Update.
14502         (func_mod): Create a new vector.
14503         (c_parse): Create a c_parse_state.
14504         (check_parameter_typelist): Do not delete params.
14505         (function_method): Update.  Do not delete type_list.
14506
14507 2019-01-06  Tom Tromey  <tom@tromey.com>
14508
14509         PR gdb/28155:
14510         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14511         check_typedef.
14512         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14513         (print_return_value): Likewise.
14514
14515 2019-01-05  Tom Tromey  <tom@tromey.com>
14516
14517         * contrib/cleanup_check.py: Remove.
14518         * contrib/gcc-with-excheck: Remove.
14519         * contrib/exsummary.py: Remove.
14520         * contrib/excheck.py: Remove.
14521
14522 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14523
14524         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14525         NULL. Initialize tpprev to NULL instead of assigning it
14526         to NULL on the next statement.
14527         * windows-nat.c (windows_delete_thread): Remove check for
14528         main_thread_id before printing thread exit notifications.
14529         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14530         Remove thread ID check against main_thread_id.
14531         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14532         windows_delete_thread.
14533         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14534
14535 2019-01-04  Tom Tromey  <tom@tromey.com>
14536
14537         * compile/compile.c (_initialize_compile): Use upper case for
14538         metasyntactic variables.
14539         * symmisc.c (_initialize_symmisc): Use upper case for
14540         metasyntactic variables.
14541         * psymtab.c (_initialize_psymtab): Use upper case for
14542         metasyntactic variables.
14543         * demangle.c (demangle_command): Use upper case for metasyntactic
14544         variables.
14545         (_initialize_demangler): Likewise.
14546         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14547         variables.
14548
14549 2019-01-03  Tom Tromey  <tom@tromey.com>
14550
14551         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14552
14553 2019-01-03  Tom Tromey  <tom@tromey.com>
14554
14555         * python/py-symtab.c (salpy_str): Update.
14556         (struct salpy_sal_object) <symtab>: Now a PyObject.
14557         (salpy_dealloc): Update.
14558         (del_objfile_sal): Use gdbpy_ref.
14559
14560 2019-01-03  Tom Tromey  <tom@tromey.com>
14561
14562         * python/py-type.c (convert_field): Use new_reference.  Return
14563         gdbpy_ref.
14564         (make_fielditem): Return gdbpy_ref.
14565         (typy_fields): Update.
14566         (typy_getitem): Update.
14567         (field_name): Return gdbpy_ref.  Use new_reference.
14568         (typy_iterator_iternext): Update.
14569
14570 2019-01-03  Tom Tromey  <tom@tromey.com>
14571
14572         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14573
14574 2019-01-03  Tom Tromey  <tom@tromey.com>
14575
14576         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14577         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14578         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14579         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14580         (pspy_set_type_printers): Likewise.
14581         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14582         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14583         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14584         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14585         (objfpy_set_type_printers): Likewise.
14586
14587 2019-01-03  Tom Tromey  <tom@tromey.com>
14588
14589         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14590         (gdbpy_print_stack): Use gdbpy_err_fetch.
14591         * python/python-internal.h (class gdbpy_err_fetch): New class.
14592         (class gdbpy_enter) <m_error_type, m_error_value,
14593         m_error_traceback>: Remove.
14594         <m_error>: New member.
14595         (gdbpy_exception_to_string): Don't declare.
14596         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14597         * python/py-value.c (convert_value_from_python): Use
14598         gdbpy_err_fetch.
14599         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14600         gdbpy_exception_to_string.
14601         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14602         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14603         gdbpy_err_fetch.
14604
14605 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14606
14607         * linux-nat.c (delete_lwp_cleanup): Delete.
14608         (struct lwp_deleter): New struct.
14609         (lwp_info_up): New typedef.
14610         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14611         lwp_info_up.
14612
14613 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14614
14615         * linux-fork.c (class scoped_switch_fork_info): New class.
14616         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14617
14618 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14619
14620         * valops.c (find_overload_match): Remove use of null_cleanup, and
14621         calls to do_cleanups.
14622
14623 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14624
14625         * compile/compile-cplus-types.c
14626         (compile_cplus_instance::decl_name): Handle changes to
14627         cp_func_name.
14628         * cp-support.c (cp_func_name): Update header comment, update
14629         return type.
14630         * cp-support.h (cp_func_name): Update return type in declaration.
14631         * valops.c (find_overload_match): Move temp_func local to top
14632         level of function and change its type.  Use temp_func to hold and
14633         delete temporary string obtained from cp_func_name.
14634
14635 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14636
14637         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14638         gdb::char_vector, remove cleanup, and update uses of `msg`.
14639
14640 2019-01-03  Jim Wilson  <jimw@sifive.com>
14641
14642         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14643
14644 2019-01-02  Tom Tromey  <tom@tromey.com>
14645
14646         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14647         (tdesc_parse_xml): Remove cleanups.
14648         * target-descriptions.h (make_cleanup_free_target_description):
14649         Don't declare.
14650         (target_desc_deleter): New struct.
14651         (target_desc_up): New typedef.
14652         * target-descriptions.c (target_desc_deleter::operator()): Rename
14653         from free_target_description.
14654         (make_cleanup_free_target_description): Remove.
14655
14656 2019-01-02  Tom Tromey  <tom@tromey.com>
14657
14658         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14659         constructor, destructor.
14660         (linespec_parser): Remove typedef.
14661         (~linespec_parser): Rename from linespec_parser_delete.
14662         (linespec_lex_to_end, linespec_complete_label)
14663         (linespec_complete): Update.
14664         (decode_line_full): Remove cleanups.
14665         (decode_line_1): Update.
14666
14667 2019-01-02  Tom Tromey  <tom@tromey.com>
14668
14669         * python/python-internal.h (inferior_to_inferior_object): Change
14670         return type.
14671         * python/py-exitedevent.c (create_exited_event_object): Update.
14672         * python/py-inferior.c (inferior_to_inferior_object): Return
14673         gdbpy_ref.
14674         (python_new_inferior, python_inferior_deleted)
14675         (thread_to_thread_object, delete_thread_object)
14676         (build_inferior_list, gdbpy_selected_inferior): Update.
14677         * python/py-infthread.c (create_thread_object): Update.  Also fail
14678         if inferior_to_inferior_object fails.
14679
14680 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14681
14682         * inferior.h (class inferior) <displaced_step_state>: New field.
14683         * infrun.h (struct displaced_step_state): Move here from
14684         infrun.c.  Initialize fields, add constructor.
14685         <inf>: Remove field.
14686         <reset>: New method.
14687         * infrun.c (struct displaced_step_inferior_state): Move to
14688         infrun.h.
14689         (displaced_step_inferior_states): Remove.
14690         (get_displaced_stepping_state): Adust.
14691         (displaced_step_in_progress_any_inferior): Adjust.
14692         (displaced_step_in_progress_thread): Adjust.
14693         (displaced_step_in_progress): Adjust.
14694         (add_displaced_stepping_state): Remove.
14695         (get_displaced_step_closure_by_addr): Adjust.
14696         (remove_displaced_stepping_state): Remove.
14697         (infrun_inferior_exit): Call displaced_step_state.reset.
14698         (use_displaced_stepping): Don't check for NULL.
14699         (displaced_step_prepare_throw): Call
14700         get_displaced_stepping_state.
14701         (displaced_step_fixup): Don't check for NULL.
14702         (prepare_for_detach): Don't check for NULL.
14703
14704 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14705
14706         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14707          in case of call that did not complete.
14708
14709 2019-01-02  Andrey Utkin  <autkin@undo.io>
14710
14711         * symfile.c (find_separate_debug_file): Fix search of debug files for
14712         remote debuggee.
14713
14714 2019-01-02  Tom Tromey  <tom@tromey.com>
14715
14716         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14717         indentation.
14718         * python/py-frame.c (frapy_older): Remove cast.
14719         (frapy_newer): Likewise.
14720         * python/py-breakpoint.c (local_setattro): Remove cast.
14721         * python/py-arch.c (archpy_name): Remove local variable.
14722         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14723
14724 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14725
14726         * unittests/basic_string_view/element_access/char/empty.cc:
14727         Fix year range in copyright header.
14728
14729 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14730
14731         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14732         Delete.
14733         <operator==>: Update with for removed field.
14734         <hash>: Likewise.
14735         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14736         <isa_features>: ...this.
14737         <abi_features>: New field.
14738         (riscv_isa_flen): Update comment.
14739         (riscv_abi_xlen): New declaration.
14740         (riscv_abi_flen): New declaration.
14741         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14742         isa_features.
14743         (riscv_abi_xlen): New function.
14744         (riscv_isa_flen): Update to get answer from isa_features.
14745         (riscv_abi_flen): New function.
14746         (riscv_has_fp_abi): Update to get answer from abi_features.
14747         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14748         xlen and flen.
14749         (riscv_call_info) <xlen, flen>: Update comment.
14750         (riscv_call_arg_struct): Remove invalid assertions
14751         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14752         is removed.
14753         (riscv_gdbarch_init): Gather isa features and abi features
14754         separately, ensure both match on the gdbarch when reusing an old
14755         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14756         a target with 64-bit float hardware.
14757
14758 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14759
14760         * source.c (search_command_helper): Stop reverse search
14761         when line 1 has been searched.
14762
14763 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14764
14765         * record-full.c (record_full_base_target::close): Rewrite
14766         record_full_core_buf_list free logic.
14767
14768 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14769
14770         * break-catch-syscall.c (print_one_catch_syscall): xfree
14771         the last text.
14772
14773 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14774
14775         * top.c (print_gdb_version): Update Copyright year in version
14776         message.
14777
14778 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14779
14780         Update copyright year range in all GDB files.
14781
14782 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14783
14784         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14785
14786 For older changes see ChangeLog-2018.
14787 \f
14788 Local Variables:
14789 mode: change-log
14790 left-margin: 8
14791 fill-column: 74
14792 version-control: never
14793 coding: utf-8
14794 End:
14795