gdb/ChangeLog

   1 2020-03-13  Tom Tromey  <tom@tromey.com>
   2
   3         * infcmd.c (default_print_one_register_info): Use
   4         common_val_print.
   5
   6 2020-03-13  Tom Tromey  <tom@tromey.com>
   7
   8         * valprint.h (common_val_print_checked): Declare.
   9         * valprint.c (common_val_print_checked): New function.
  10         * stack.c (print_frame_arg): Use common_val_print_checked.
  11
  12 2020-03-13  Tom Tromey  <tom@tromey.com>
  13
  14         * valprint.c (do_val_print): New function, from val_print.
  15         (val_print): Use do_val_print.
  16         (common_val_print): Use do_val_print.
  17
  18 2020-03-13  Tom Tromey  <tom@tromey.com>
  19
  20         * valprint.c (value_print): Use scoped_value_mark.
  21
  22 2020-03-13  Tom de Vries  <tdevries@suse.de>
  23
  24         PR symtab/25646
  25         * psymtab.c (partial_symtab::partial_symtab): Don't set
  26         globals_offset and statics_offset.  Push element onto
  27         current_global_psymbols and current_static_psymbols stacks.
  28         (concat): New function.
  29         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
  30         element from current_global_psymbols and current_static_psymbols
  31         stacks.  Concat popped elements to global_psymbols and
  32         static_symbols.
  33         (add_psymbol_to_list): Use current_global_psymbols and
  34         current_static_psymbols stacks.
  35         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
  36         current_static_psymbols fields.
  37
  38 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
  39
  40         * corelow.c (sniff_core_bfd): Remove.
  41         (class core_target) <m_core_vec>: Remove.
  42         (core_target::core_target): Update.
  43         (core_file_fns): Remove.
  44         (deprecated_add_core_fns): Remove.
  45         (default_core_sniffer): Remove.
  46         (sniff_core_bfd): Remove.
  47         (default_check_format): Remove.
  48         (gdb_check_format): Remove.
  49         (core_target_open): Update.
  50         (core_target::get_core_register_section): Update.
  51         (get_core_registers_cb): Update.
  52         (core_target::fetch_registers): Update.
  53         * gdbcore.h (struct core_fns): Remove.
  54         (deprecated_add_core_fns): Remove.
  55         (default_core_sniffer): Remove.
  56         (default_check_format): Remove.
  57
  58 2020-03-12  Tom Tromey  <tom@tromey.com>
  59
  60         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
  61         CORE_ADDR.
  62         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
  63
  64 2020-03-12  Tom Tromey  <tom@tromey.com>
  65
  66         * remote.c (remote_target::download_tracepoint)
  67         (remote_target::enable_tracepoint)
  68         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
  69         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
  70         sprintf_vma.
  71
  72 2020-03-12  Tom Tromey  <tom@tromey.com>
  73
  74         * symfile-mem.c: Update CORE_ADDR size assert.
  75
  76 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
  77
  78         * selftest.m4: Move to gdbsupport/.
  79         * acinclude.m4: Update path to selftest.m4.
  80
  81 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
  82
  83         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
  84         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
  85         gdbarch-selfselftests.c and selftest-arch.c.
  86         (SUBDIR_UNITTESTS_OBS): Rename to...
  87         (SELFTESTS_OBS): ... this.
  88         (COMMON_SFILES): Remove disasm-selftests.c and
  89         gdbarch-selftests.c.
  90         * configure.ac: Don't add selftest-arch.{c,o} to
  91         CONFIG_{SRCS,OBS}.
  92         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
  93         preprocessor conditions.
  94
  95 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
  96
  97         * configure.ac: Don't source bfd/development.sh.
  98         * selftest.m4: Modify comment.
  99         * configure: Re-generate.
 100
 101 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 102
 103         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
 104         not "true" or "false".
 105         * configure: Re-generate.
 106
 107 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
 108
 109         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
 110         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
 111         renamed to arm_nbsd_supply_gregset.
 112         (fetch_register): Update to call arm_nbsd_supply_gregset.
 113         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
 114         (arm_netbsd_nat_target::fetch_registers): Update.
 115         (fetch_elfcore_registers): Removed.
 116         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
 117         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
 118         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
 119         not require NetBSD system headers.
 120         (arm_nbsd_regset): New struct.
 121         (arm_nbsd_iterate_over_regset_sections): New function.
 122         (arm_netbsd_init_abi_common): Updated to call
 123         set_gdbarch_iterate_over_regset_sections.
 124         * arm-nbsd-tdep.h: New file.
 125
 126 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
 127
 128         * symtab.c (find_pc_sect_line): Add check which prevents infinite
 129         recursion.
 130
 131 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
 132
 133         * configure: Re-generate.
 134
 135 2020-03-11  Tom Tromey  <tromey@adacore.com>
 136
 137         * ada-typeprint.c (print_choices): Fix comment.
 138
 139 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 140
 141         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
 142         previous item in the list, when the list has no items.
 143
 144 2020-03-11  Tom de Vries  <tdevries@suse.de>
 145
 146         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
 147         PROP_LOCLIST handling code.
 148
 149 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 150
 151         * buildsym-legacy.c (record_line): Pass extra parameter to
 152         record_line.
 153         * buildsym.c (buildsym_compunit::record_line): Take an extra
 154         parameter, reduce duplication in the line table, and record the
 155         is_stmt flag in the line table.
 156         * buildsym.h (buildsym_compunit::record_line): Add extra
 157         parameter.
 158         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
 159         non-statement lines.
 160         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
 161         this to the symtab builder.
 162         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
 163         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
 164         through to dwarf_record_line_1.
 165         * infrun.c (process_event_stop_test): When stepping, don't stop at
 166         a non-statement instruction, and only refresh the step info when
 167         we land in the middle of a line's range.  Also add an extra
 168         comment.
 169         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
 170         field.
 171         * record-btrace.c (btrace_find_line_range): Only record lines
 172         marked as is-statement.
 173         * stack.c (frame_show_address): Show the frame address if we are
 174         in a non-statement sal.
 175         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
 176         (maintenance_print_one_line_table): Print a header for the is_stmt
 177         column, and include is_stmt information in the output.
 178         * symtab.c (find_pc_sect_line): Find lines marked as statements in
 179         preference to non-statements.
 180         (find_pcs_for_symtab_line): Prefer is-statement entries.
 181         (find_line_common): Likewise.
 182         * symtab.h (struct linetable_entry): Add is_stmt field.
 183         (struct symtab_and_line): Likewise.
 184         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
 185         arranging the line table.
 186
 187 2020-03-07  Tom de Vries  <tdevries@suse.de>
 188
 189         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
 190         DIE.
 191
 192 2020-03-07  Tom Tromey  <tom@tromey.com>
 193
 194         * valops.c (value_literal_complex): Remove obsolete comment.
 195         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
 196         comment.
 197
 198 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
 199
 200         * infrun.h: Forward-declare thread_info.
 201         (set_step_info): Add thread_info parameter, add doc.
 202         * infrun.c (set_step_info): Add thread_info parameter, move doc
 203         to header.
 204         * infrun.c (process_event_stop_test): Pass thread to
 205         set_step_info call.
 206         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
 207         set_step_info.
 208         (prepare_one_step): Add thread_info parameter, pass it to
 209         set_step_frame and prepare_one_step (recursive) call.
 210         (step_1): Pass thread to prepare_one_step call.
 211         (step_command_fsm::should_stop): Pass thread to
 212         prepare_one_step.
 213         (until_next_fsm): Pass thread to set_step_frame call.
 214         (finish_command): Pass thread to set_step_info call.
 215
 216 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
 217
 218         * windows-tdep.c (windows_solib_create_inferior_hook):
 219         Check if inferior is running.
 220
 221 2020-03-06  Tom de Vries  <tdevries@suse.de>
 222
 223         * NEWS: Fix "the the".
 224         * ctfread.c: Same.
 225
 226 2020-03-06  Tom de Vries  <tdevries@suse.de>
 227
 228         * psymtab.c (psymtab_to_symtab): Don't print "done.".
 229
 230 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 231
 232         * .dir-locals.el: Add a comment referencing the other copies of
 233         this file.
 234
 235 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
 236
 237         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
 238         psargs.
 239
 240 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 241
 242         * .gitattributes: New file.
 243
 244 2020-03-04  Tom Tromey  <tom@tromey.com>
 245
 246         * symmisc.c (print_symbol_bcache_statistics)
 247         (print_objfile_statistics): Update.
 248         * symfile.c (allocate_symtab): Use intern.
 249         * psymtab.c (partial_symtab::partial_symtab): Use intern.
 250         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 251         macro_cache>: Remove.
 252         <string_cache>: New member.
 253         (struct objfile) <intern>: New methods.
 254         * elfread.c (elf_symtab_read): Use intern.
 255         * dwarf2/read.c (fixup_go_packaging): Intern package name.
 256         (dwarf2_compute_name, dwarf2_physname)
 257         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
 258         names.
 259         (guess_partial_die_structure_name): Update.
 260         (partial_die_info::fixup): Intern name.
 261         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
 262         name.
 263         (dwarf2_name): Intern name.  Update.
 264         * buildsym.c (buildsym_compunit::get_macro_table): Use
 265         string_cache.
 266
 267 2020-03-04  Tom Tromey  <tom@tromey.com>
 268
 269         * jit.c (bfd_open_from_target_memory): Make "target" const.
 270         * corefile.c (gnutarget): Now const.
 271         * gdbcore.h (gnutarget): Now const.
 272
 273 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
 274
 275         * NEWS: Mention support for WOW64 processes.
 276         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
 277         (amd64_windows_segment_register_p): Remove static.
 278         (_initialize_amd64_windows_nat): Update.
 279         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
 280         * i386-windows-nat.c (context_offset): Update.
 281         (i386_mappings): Rename and remove static.
 282         (i386_windows_segment_register_p): Remove static.
 283         (_initialize_i386_windows_nat): Update.
 284         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
 285         (STATUS_WX86_SINGLE_STEP): New macro.
 286         (EnumProcessModulesEx): New macro.
 287         (Wow64SuspendThread): New macro.
 288         (Wow64GetThreadContext): New macro.
 289         (Wow64SetThreadContext): New macro.
 290         (Wow64GetThreadSelectorEntry): New macro.
 291         (windows_set_context_register_offsets): Add static.
 292         (windows_set_segment_register_p): Likewise.
 293         (windows_add_thread): Adapt for WOW64 processes.
 294         (windows_fetch_one_register): Likewise.
 295         (windows_nat_target::fetch_registers): Likewise.
 296         (windows_store_one_register): Likewise.
 297         (display_selector): Likewise.
 298         (display_selectors): Likewise.
 299         (handle_exception): Likewise.
 300         (windows_continue): Likewise.
 301         (windows_nat_target::resume): Likewise.
 302         (windows_add_all_dlls): Likewise.
 303         (do_initial_windows_stuff): Likewise.
 304         (windows_nat_target::attach): Likewise.
 305         (windows_get_exec_module_filename): Likewise.
 306         (windows_nat_target::create_inferior): Likewise.
 307         (windows_xfer_siginfo): Likewise.
 308         (_initialize_loadable): Initialize Wow64SuspendThread,
 309         Wow64GetThreadContext, Wow64SetThreadContext,
 310         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
 311         * windows-nat.h (windows_set_context_register_offsets):
 312         Remove declaration.
 313         (windows_set_segment_register_p): Likewise.
 314         (i386_windows_segment_register_p): Add declaration.
 315         (amd64_windows_segment_register_p): Likewise.
 316
 317 2020-03-04  Luis Machado  <luis.machado@linaro.org>
 318
 319         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
 320         in "info registers" for AArch64/ARM.
 321
 322         The change caused "info registers" to not print GPR's.
 323
 324         gdb/ChangeLog:
 325
 326         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
 327
 328         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
 329         when reg->group is empty and reggroup is not.
 330
 331 2020-03-03  Tom Tromey  <tromey@adacore.com>
 332
 333         * dwarf2/frame.c (struct dwarf2_frame_cache)
 334         <checked_tailcall_bottom, entry_cfa_sp_offset,
 335         entry_cfa_sp_offset_p>: Remove members.
 336         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
 337         (dwarf2_frame_prev_register): Don't call
 338         dwarf2_tailcall_sniffer_first.
 339         (dwarf2_append_unwinders): Don't append tailcall unwinder.
 340         * frame-unwind.c (add_unwinder): New fuction.
 341         (frame_unwind_init): Use it.  Add tailcall unwinder.
 342
 343 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 344             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 345
 346         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
 347         value should be printed as true.
 348
 349 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
 350
 351         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
 352         (windows_init_abi): Set and use windows_so_ops.
 353
 354 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
 355
 356         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
 357         when verifying if dealing with a convenience variable.
 358
 359 2020-03-03  Luis Machado  <luis.machado@linaro.org>
 360
 361         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
 362
 363 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
 364
 365         * infrun.c (gdbarch_supports_displaced_stepping): New.
 366         (use_displaced_stepping): Break up conditions in smaller pieces.
 367         Use gdbarch_supports_displaced_stepping.
 368         (displaced_step_prepare_throw): Use
 369         gdbarch_supports_displaced_stepping.
 370
 371 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 372
 373         * NEWS: Mention new behaviour of the history filename.
 374         * top.c (write_history_p): Add comment.
 375         (show_write_history_p): Add header comment, give a different
 376         message when history writing is on, but the history filename is
 377         empty.
 378         (history_filename): Add comment.
 379         (history_filename_empty): New function.
 380         (show_history_filename): Add header comment, give a different
 381         message when the filename is empty.
 382         (init_history): Compare history_filename against nullptr, and only
 383         read history if the filename is not empty.
 384         (set_history_filename): Add header comment, and only make
 385         non-empty filenames absolute.
 386         (init_main): Make the filename argument to 'set history filename'
 387         optional.
 388
 389 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
 390
 391         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
 392         (arm_supply_vfpregset): ...this, and update to use VFP registers.
 393         (fetch_fp_register): Update.
 394         (fetch_fp_regs): Update.
 395         (store_fp_register): Update.
 396         (store_fp_regs): Update.
 397         (arm_netbsd_nat_target::read_description): New function.
 398         (fetch_elfcore_registers): Update.
 399
 400 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 401
 402         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
 403         general_thread if the stop reply is missing a thread-id.
 404         (remote_target::process_stop_reply): Use the first non-exited
 405         thread if the target didn't pass a thread-id.
 406         * infrun.c (do_target_wait): Move call to
 407         switch_to_inferior_no_thread to ....
 408         (do_target_wait_1): ... here.
 409
 410 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
 411
 412         * debuginfod-support.c: Include defs.h first.
 413
 414 2020-02-28  Tom de Vries  <tdevries@suse.de>
 415
 416         * symfile.c (set_initial_language): Use default language for lookup.
 417
 418 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
 419
 420         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
 421         reader variable, pass `this` to read_cutu_die_from_dwo.
 422
 423 2020-02-27  Aaron Merey  <amerey@redhat.com>
 424
 425         * source.c (open_source_file): Check for nullptr when computing
 426         srcpath.
 427
 428 2020-02-27  Tom Tromey  <tromey@adacore.com>
 429
 430         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
 431         member.
 432         (dwarf2_add_field): Don't update nfields.
 433         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
 434
 435 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
 438         abs.
 439
 440 2020-02-26  Tom Tromey  <tom@tromey.com>
 441
 442         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
 443         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
 444         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
 445         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
 446         per_cu_data.
 447
 448 2020-02-26  Tom Tromey  <tom@tromey.com>
 449
 450         * dwarf2/index-write.c (psym_index_map): Change type.
 451         (add_address_entry_worker, write_one_signatured_type)
 452         (recursively_count_psymbols, recursively_write_psymbols)
 453         (class debug_names, psyms_seen_size, write_gdbindex)
 454         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
 455
 456 2020-02-26  Aaron Merey  <amerey@redhat.com>
 457
 458         * Makefile.in: Handle optional debuginfod support.
 459         * NEWS: Update.
 460         * README: Add --with-debuginfod summary.
 461         * config.in: Regenerate.
 462         * configure: Regenerate.
 463         * configure.ac: Handle optional debuginfod support.
 464         * debuginfod-support.c: debuginfod helper functions.
 465         * debuginfod-support.h: Ditto.
 466         * doc/gdb.texinfo: Add --with-debuginfod to configure options
 467         summary.
 468         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
 469         when a dwz file cannot be found.
 470         * elfread.c (elf_symfile_read): Query debuginfod servers when a
 471         debuginfo file cannot be found.
 472         * source.c (open_source_file): Query debuginfod servers when a
 473         source file cannot be found.
 474         * top.c (print_gdb_configuration): Include
 475         --{with,without}-debuginfod in the output.
 476
 477 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
 478
 479         * thread.c (thr_try_catch_cmd): Print thread name.
 480
 481 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
 482
 483         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
 484         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 485         dwarf2_fetch_die_type_sect_off): Move to...
 486         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
 487         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 488         dwarf2_fetch_die_type_sect_off): ... here.
 489         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
 490         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 491         dwarf2_fetch_die_type_sect_off): Move doc to header file.
 492
 493 2020-02-26  Tom de Vries  <tdevries@suse.de>
 494
 495         PR gdb/25603
 496         * symfile.c (set_initial_language): Exit-early if
 497         language_mode == language_mode_manual.
 498
 499 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 500
 501         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
 502         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
 503         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
 504
 505 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 506
 507         * gdbtypes.c (create_array_type_with_stride): Handle negative
 508         array strides.
 509         * valarith.c (value_subscripted_rvalue): Likewise.
 510
 511 2020-02-25  Luis Machado  <luis.machado@linaro.org>
 512
 513         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
 514
 515 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 516
 517         * loc.h (dwarf2_get_die_type): Move to...
 518         * read.h (dwarf2_get_die_type): ... here.
 519         * read.c (dwarf2_get_die_type): Move doc to header.
 520
 521 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
 522
 523         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
 524         'gnulib/Makefile.in' to the list.
 525
 526 2020-02-24  Tom Tromey  <tom@tromey.com>
 527
 528         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
 529         Remove.
 530         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
 531         XOBNEWVEC.
 532
 533 2020-02-24  Tom Tromey  <tom@tromey.com>
 534
 535         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
 536         New method.
 537         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
 538         (dw2_do_instantiate_symtab, dw2_get_file_names)
 539         (build_type_psymtab_dependencies, load_full_type_unit): Update.
 540
 541 2020-02-24  Tom Tromey  <tom@tromey.com>
 542
 543         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
 544         make_scoped_restore.
 545         (dwarf2_psymtab::read_symtab): Don't clear
 546         reading_partial_symbols.
 547
 548 2020-02-24  Tom de Vries  <tdevries@suse.de>
 549
 550         PR gdb/25592
 551         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
 552
 553 2020-02-24  Tom de Vries  <tdevries@suse.de>
 554
 555         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
 556         commands layout next/prev/regs.
 557
 558 2020-02-22  Tom Tromey  <tom@tromey.com>
 559
 560         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
 561         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
 562
 563 2020-02-22  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
 566
 567 2020-02-22  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-win.c (_initialize_tui_win): Add usage text.
 570         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
 571         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
 572         * tui/tui.c (_initialize_tui): Add usage text.
 573
 574 2020-02-22  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-win.c (tui_set_focus_command)
 577         (tui_set_win_height_command): Use error_no_arg.
 578         (_initialize_tui_win): Update help text.
 579         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
 580
 581 2020-02-22  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
 584         * tui/tui-disasm.h (struct tui_disasm_window)
 585         <display_start_addr>: Declare.
 586         * tui/tui-source.h (struct tui_source_window)
 587         <display_start_addr>: Declare.
 588         * tui/tui-winsource.h (struct tui_source_window_base)
 589         <show_source_line, display_start_addr>: New methods.
 590         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
 591         Rename and move to protected section.
 592         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 593         (tui_source_window_base::do_erase_source_content): Update.
 594         (tui_source_window_base::show_source_line): Now a method.
 595         (tui_source_window_base::show_source_content)
 596         (tui_source_window_base::tui_source_window_base)
 597         (tui_source_window_base::rerender)
 598         (tui_source_window_base::refill)
 599         (tui_source_window_base::do_scroll_horizontal)
 600         (tui_source_window_base::set_is_exec_point_at)
 601         (tui_source_window_base::update_breakpoint_info)
 602         (tui_source_window_base::update_exec_info): Update.
 603         * tui/tui-source.c (tui_source_window::set_contents)
 604         (tui_source_window::showing_source_p)
 605         (tui_source_window::do_scroll_vertical)
 606         (tui_source_window::location_matches_p)
 607         (tui_source_window::line_is_displayed): Update.
 608         (tui_source_window::display_start_addr): New method.
 609         * tui/tui-disasm.c (tui_disasm_window::set_contents)
 610         (tui_disasm_window::do_scroll_vertical)
 611         (tui_disasm_window::location_matches_p): Update.
 612         (tui_disasm_window::display_start_addr): New method.
 613
 614 2020-02-22  Tom Tromey  <tom@tromey.com>
 615
 616         * NEWS: Add entry for gdb.register_window_type.
 617         * tui/tui-layout.h (window_factory): New typedef.
 618         (tui_register_window): Declare.
 619         * tui/tui-layout.c (saved_tui_windows): New global.
 620         (tui_apply_current_layout): Use it.
 621         (tui_register_window): New function.
 622         * python/python.c (do_start_initialization): Call
 623         gdbpy_initialize_tui.
 624         (python_GdbMethods): Add "register_window_type" function.
 625         * python/python-internal.h (gdbpy_register_tui_window)
 626         (gdbpy_initialize_tui): Declare.
 627         * python/py-tui.c: New file.
 628         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
 629
 630 2020-02-22  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
 633
 634 2020-02-22  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
 637         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
 638         * tui/tui-data.c (tui_set_win_with_focus): Remove.
 639         (tui_set_win_focus_to): Move from tui-win.c.
 640
 641 2020-02-22  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-layout.c (make_standard_window, get_locator_window): New
 644         functions.
 645         (known_window_types): New global.
 646         (tui_get_window_by_name): Reimplement.
 647         (initialize_known_windows): New function.
 648         (validate_window_name): Rewrite.
 649         (_initialize_tui_layout): Call initialize_known_windows.
 650
 651 2020-02-22  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
 654         Remove constants.
 655         * tui/tui-winsource.h (struct tui_source_window_base)
 656         <tui_source_window_base>: Remove parameter.
 657         * tui/tui-winsource.c
 658         (tui_source_window_base::tui_source_window_base): Remove
 659         parameter.
 660         (tui_source_window_base::refill): Update.
 661         * tui/tui-stack.h (struct tui_locator_window)
 662         <tui_locator_window>: Update.
 663         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
 664         Default the constructor.
 665         * tui/tui-regs.h (struct tui_data_item_window)
 666         <tui_data_item_window>: Default the constructor.
 667         (struct tui_data_window) <tui_data_window>: Likewise.
 668         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
 669         Default the constructor.
 670         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
 671         Default the constructor.
 672         <type>: Remove.
 673         (struct tui_win_info) <tui_win_info>: Default the constructor.
 674         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
 675         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 676         Default the constructor.
 677
 678 2020-02-22  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
 681         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
 682         * tui/tui-win.c (tui_resize_all): Don't call
 683         tui_delete_invisible_windows.
 684         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
 685         done.
 686         (tui_set_layout): Update.
 687         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
 688         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
 689         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
 690
 691 2020-02-22  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
 694         correctly.
 695
 696 2020-02-22  Tom Tromey  <tom@tromey.com>
 697
 698         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
 699
 700 2020-02-22  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-winsource.h (struct tui_source_window_iterator)
 703         <inner_iterator>: New etytypedef.
 704         <tui_source_window_iterator>: Take "end" parameter.
 705         <tui_source_window_iterator>: Take iterator.
 706         <operator*, advance>: Update.
 707         <m_iter>: Change type.
 708         <m_end>: New field.
 709         (struct tui_source_windows) <begin, end>: Update.
 710         * tui/tui-layout.c (tui_windows): New global.
 711         (tui_apply_current_layout): Clear tui_windows.
 712         (tui_layout_window::apply): Update tui_windows.
 713         * tui/tui-data.h (tui_windows): Declare.
 714         (all_tui_windows): Now inline function.
 715         (class tui_window_iterator, struct all_tui_windows): Remove.
 716
 717 2020-02-22  Tom Tromey  <tom@tromey.com>
 718
 719         PR tui/17850:
 720         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
 721         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
 722         "height" argument.
 723         (class tui_layout_window) <get_sizes>: Likewise.
 724         (class tui_layout_split) <tui_layout_split>: Add "vertical"
 725         argument.
 726         <get_sizes>: Add "height" argument.
 727         <m_vertical>: New field.
 728         * tui/tui-layout.c (tui_layout_split::clone): Update.
 729         (tui_layout_split::get_sizes): Add "height" argument.
 730         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
 731         (tui_new_layout_command): Parse "-horizontal".
 732         (_initialize_tui_layout): Update help string.
 733         (tui_layout_split::specification): Add "-horizontal" when needed.
 734         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
 735         argument.
 736         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
 737         New methods.
 738
 739 2020-02-22  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-layout.h (enum tui_adjust_result): New.
 742         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
 743         (class tui_layout_window) <adjust_size>: Return
 744         tui_adjust_result.  Rewrite.
 745         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
 746         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
 747
 748 2020-02-22  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
 751         parameter and return types.
 752         (class tui_layout_base) <specification>: Add "depth".
 753         (class tui_layout_window) <specification>: Add "depth".
 754         (class tui_layout_split) <specification>: Add "depth".
 755         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
 756         and return types.
 757         (tui_new_layout_command): Parse sub-layouts.
 758         (_initialize_tui_layout): Update help string.
 759         (tui_layout_window::specification): Add "depth".
 760         (add_layout_command): Update.
 761
 762 2020-02-22  Tom Tromey  <tom@tromey.com>
 763
 764         * NEWS: Add "tui new-layout" item.
 765         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
 766         Add new-layout command to help text.
 767         (validate_window_name): New function.
 768         (tui_new_layout_command): New function.
 769         (_initialize_tui_layout): Register "new-layout".
 770         (tui_layout_window::specification): New method.
 771         (tui_layout_window::specification): New method.
 772         * tui/tui-layout.h (class tui_layout_base) <specification>: New
 773         method.
 774         (class tui_layout_window) <specification>: New method.
 775         (class tui_layout_split) <specification>: New method.
 776
 777 2020-02-22  Tom Tromey  <tom@tromey.com>
 778
 779         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
 780         * tui/tui-win.c (window_name_completer): Update comment.
 781         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
 782         Declare method.
 783         (class tui_layout_window) <replace_window>: Likewise.
 784         (class tui_layout_split) <replace_window>: Likewise.
 785         (tui_set_layout): Don't declare.
 786         (tui_set_initial_layout): Declare function.
 787         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
 788         (asm_regs_layout): New globals.
 789         (tui_current_layout, show_layout): Remove.
 790         (tui_set_layout, tui_add_win_to_layout): Rewrite.
 791         (find_layout, tui_apply_layout): New function.
 792         (layout_completer): Remove.
 793         (tui_next_layout): Reimplement.
 794         (tui_next_layout_command): New function.
 795         (tui_set_initial_layout, tui_prev_layout_command): New functions.
 796         (tui_regs_layout): Reimplement.
 797         (tui_regs_layout_command): New function.
 798         (extract_display_start_addr): Rewrite.
 799         (next_layout, prev_layout): Remove.
 800         (tui_layout_window::replace_window): New method.
 801         (tui_layout_split::replace_window): New method.
 802         (destroy_layout): New function.
 803         (layout_list): New global.
 804         (add_layout_command): New function.
 805         (initialize_layouts): Update.
 806         (tui_layout_command): New function.
 807         (_initialize_tui_layout): Install "layout" commands.
 808         * tui/tui-data.h (enum tui_layout_type): Remove.
 809         (tui_current_layout): Don't declare.
 810
 811 2020-02-22  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-regs.c (tui_reg_layout): Remove.
 814         (tui_reg_command): Use tui_regs_layout.
 815         * tui/tui-layout.h (tui_reg_command): Declare.
 816         * tui/tui-layout.c (tui_reg_command): New function.
 817
 818 2020-02-22  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui.c (tui_rl_delete_other_windows): Call
 821         tui_remove_some_windows.
 822         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
 823         Declare method.
 824         (class tui_layout_window) <remove_windows>: New method.
 825         (class tui_layout_split) <remove_windows>: Declare.
 826         (tui_remove_some_windows): Declare.
 827         * tui/tui-layout.c (tui_remove_some_windows): New function.
 828         (tui_layout_split::remove_windows): New method.
 829
 830 2020-02-22  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
 833         * tui/tui-layout.h (tui_next_layout): Declare.
 834         * tui/tui-layout.c (tui_next_layout): New function.
 835
 836 2020-02-22  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
 839         correct coordinates.
 840
 841 2020-02-22  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
 844         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
 845         DATA_WIN case.
 846
 847 2020-02-22  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
 850         TUI_DISASM_WIN, not tui_win_list.
 851
 852 2020-02-22  Tom Tromey  <tom@tromey.com>
 853
 854         * valprint.c (generic_val_print_enum_1)
 855         (val_print_type_code_flags): Style member names.
 856         * rust-lang.c (val_print_struct, rust_print_enum)
 857         (rust_print_struct_def, rust_internal_print_type): Style member
 858         names.
 859         * p-valprint.c (pascal_object_print_value_fields): Style member
 860         names.  Only call fprintf_symbol_filtered for static members.
 861         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
 862         * f-valprint.c (f_val_print): Style member names.
 863         * f-typeprint.c (f_type_print_base): Style member names.
 864         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
 865         call fprintf_symbol_filtered for static members.
 866         (cp_print_class_member): Style member names.
 867         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
 868         member names.
 869         * ada-valprint.c (ada_print_scalar): Style enum names.
 870         (ada_val_print_enum): Likewise.
 871         * ada-typeprint.c (print_enum_type): Style enum names.
 872
 873 2020-02-21  Tom Tromey  <tom@tromey.com>
 874
 875         * psympriv.h (struct partial_symtab): Update comment.
 876
 877 2020-02-21  Tom Tromey  <tromey@adacore.com>
 878
 879         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
 880         type is CORE_ADDR.
 881
 882 2020-02-21  Tom de Vries  <tdevries@suse.de>
 883
 884         PR gdb/25534
 885         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
 886         if dependencies[i]->user != NULL.
 887
 888 2020-02-21  Ali Tamur  <tamur@google.com>
 889
 890         * dwarf2/read.c (dwarf2_name): Add null check.
 891
 892 2020-02-20  Tom Tromey  <tom@tromey.com>
 893
 894         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
 895         ">=", in binary search.
 896         (dwarf2_find_containing_comp_unit): New overload.
 897         (run_test): New self-test.
 898         (_initialize_dwarf2_read): Register new test.
 899
 900 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
 901
 902         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
 903         * riscv-tdep.h: Likewise.
 904         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
 905         rv32-only CSR.
 906         * features/riscv/64bit-csr.xml: Regenerated.
 907
 908 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
 909             Tom Tromey  <tom@tromey.com>
 910
 911         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
 912         of 'fputc_unfiltered'.
 913         (putchar_unfiltered): Call 'fputc_unfiltered'.
 914         (fputc_unfiltered): Call 'fputs_unfiltered'.
 915
 916 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * config.in: Regenerate.
 919         * configure: Regenerate.
 920         * configure.ac: Add --with-python-libdir option.
 921         * main.c: Use WITH_PYTHON_LIBDIR.
 922
 923 2020-02-19  Tom Tromey  <tom@tromey.com>
 924
 925         * symtab.c (general_symbol_info::compute_and_set_names): Use
 926         obstack_strndup.  Simplify call to symbol_set_demangled_name.
 927
 928 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
 929
 930         * dwarf2/read.c (allocate_signatured_type_table,
 931         allocate_dwo_unit_table, allocate_type_unit_groups_table,
 932         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
 933         Remove objfile parameter, update all callers.
 934
 935 2020-02-19  Doug Evans  <dje@google.com>
 936
 937         PR rust/25535
 938         * rust-lang.c (rust_print_enum): Apply embedded_offset to
 939         rust_enum_variant calculation.
 940
 941 2020-02-19  Tom Tromey  <tromey@adacore.com>
 942
 943         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
 944
 945 2020-02-19  Tom Tromey  <tromey@adacore.com>
 946
 947         * ada-lang.c (cache_symbol): Use obstack_strdup.
 948
 949 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 950
 951         * configure: Regenerate.
 952
 953 2020-02-19  Tom Tromey  <tromey@adacore.com>
 954
 955         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
 956         NULL check.
 957
 958 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
 959
 960         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
 961
 962 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
 965         if GDBSERVER is not defined.
 966         (riscv_tdesc_cache): Likewise, also store const target_desc.
 967         (STATIC_IN_GDB): Define.
 968         (riscv_create_target_description): Update declaration with
 969         STATIC_IN_GDB.
 970         (riscv_lookup_target_description): New function, only define if
 971         GDBSERVER is not defined.
 972         * arch/riscv.h (riscv_create_target_description): Declare only
 973         when GDBSERVER is defined.
 974         (riscv_lookup_target_description): New declaration when GDBSERVER
 975         is not defined.
 976         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
 977         (riscv_linux_read_features): ...this, and return
 978         riscv_gdbarch_features instead of target_desc.
 979         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
 980         (riscv_linux_read_description): Rename to...
 981         (riscv_linux_read_features): ...this.
 982         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
 983         Update to use riscv_gdbarch_features and
 984         riscv_lookup_target_description.
 985         * riscv-tdep.c (riscv_find_default_target_description): Use
 986         riscv_lookup_target_description instead of
 987         riscv_create_target_description.
 988
 989 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 990
 991         * valprint.c (generic_val_print_enum_1): When printing a flag
 992         enum with value 0 and there is no enumerator with value 0, print
 993         just "0" instead of "(unknown: 0x0)".
 994
 995 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 996
 997         * valprint.c (generic_val_print_enum_1): Print unknown part of
 998         flag enum in hex.
 999
1000 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1001
1002         * dwarf2/read.c (update_enumeration_type_from_children): Allow
1003         flag enums to contain duplicate enumerators.
1004         * valprint.c (generic_val_print_enum_1): Update comment.
1005
1006 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1007
1008         * dwarf2/read.c: Include "count-one-bits.h".
1009         (update_enumeration_type_from_children): If an enumerator has
1010         multiple bits set, don't treat the enumeration as a "flag enum".
1011         * valprint.c (generic_val_print_enum_1): Assert that enumerators
1012         of flag enums have 0 or 1 bit set.
1013
1014 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1015
1016         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
1017         conversion.
1018         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1019         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1020         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1021         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1022         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1023
1024 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1025
1026         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
1027
1028 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1029
1030         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
1031         displaced_step_closure_up.
1032         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1033         (struct displaced_step_closure_up):
1034         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1035         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1036         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
1037         Likewise.
1038         * gdbarch.sh (displaced_step_copy_insn): Likewise.
1039         * gdbarch.c, gdbarch.h: Re-generate.
1040         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
1041         displaced_step_closure_up.
1042         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1043         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1044         * infrun.h (displaced_step_closure_up): New type alias.
1045         (struct displaced_step_inferior_state) <step_closure>: Change
1046         type to displaced_step_closure_up.
1047         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
1048         displaced_step_closure_up.
1049         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1050
1051 2020-02-14  Tom Tromey  <tom@tromey.com>
1052
1053         * minidebug.c (gnu_debug_key): New global.
1054         (find_separate_debug_file_in_section): Use it.
1055
1056 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1057
1058         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
1059         std::unique_ptr.
1060         * gdbarch.c: Re-generate.
1061         * gdbarch.h: Re-generate.
1062         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
1063         change.
1064         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
1065         type to std::unique_ptr.
1066         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1067         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1068         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1069         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1070         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
1071         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1072         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1073         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1074         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1075
1076 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1077
1078         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
1079         std::unique_ptr.
1080         (displaced_step_clear): Rename to...
1081         (displaced_step_reset): ... this.  Just call displaced->reset ().
1082         (displaced_step_clear_cleanup): Rename to...
1083         (displaced_step_reset_cleanup): ... this.
1084         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
1085         (displaced_step_fixup): Likewise.
1086         (resume_1): Likewise.
1087         (handle_inferior_event): Restore child's memory before calling
1088         displaced_step_fixup on the parent.
1089         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
1090         to std::unique_ptr.
1091         <step_closure>: Change type to std::unique_ptr.
1092
1093 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1094
1095         * arm-tdep.c: Include count-one-bits.h.
1096         (cleanup_block_store_pc): Use count_one_bits.
1097         (cleanup_block_load_pc): Use count_one_bits.
1098         (arm_copy_block_xfer): Use count_one_bits.
1099         (thumb2_copy_block_xfer): Use count_one_bits.
1100         (thumb_copy_pop_pc_16bit): Use count_one_bits.
1101         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
1102         (thumb_get_next_pcs_raw): Use count_one_bits.
1103         (arm_get_next_pcs_raw): Use count_one_bits_l.
1104         * arch/arm.c (bitcount): Remove.
1105         * arch/arm.h (bitcount): Remove.
1106
1107 2020-02-14  Tom Tromey  <tromey@adacore.com>
1108
1109         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
1110         Update.
1111         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
1112         * dwarf2/loc.c (call_site_find_chain_1): Return
1113         unique_xmalloc_ptr.
1114         (call_site_find_chain): Likewise.
1115
1116 2020-02-14  Richard Biener  <rguenther@suse.de>
1117
1118         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
1119         on expression with division operators.
1120
1121 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1122
1123         * MAINTAINERS (Write After Approval): Adding myself.
1124
1125 2020-02-12  Tom Tromey  <tom@tromey.com>
1126
1127         * event-loop.c (event_data, gdb_event, event_handler_func):
1128         Remove.
1129
1130 2020-02-12  Tom Tromey  <tom@tromey.com>
1131
1132         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
1133         (dwarf2_frame_objfile_data): Add comment.
1134         (find_comp_unit, set_comp_unit): New functions.
1135         (dwarf2_frame_find_fde): Use find_comp_unit.
1136         (dwarf2_build_frame_info): Use set_comp_unit.
1137
1138 2020-02-12  Tom Tromey  <tom@tromey.com>
1139
1140         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
1141         (comp_unit): Don't initialize objfile.
1142         (execute_cfa_program): Add text_offset parameter.
1143         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
1144         (dwarf2_frame_cache): Update.
1145         (dwarf2_build_frame_info): Don't set "objfile" member.
1146
1147 2020-02-12  Tom Tromey  <tom@tromey.com>
1148
1149         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
1150         (decode_frame_entry): Likewise.
1151         (dwarf2_build_frame_info): Update.
1152
1153 2020-02-12  Tom Tromey  <tom@tromey.com>
1154
1155         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
1156         (decode_frame_entry_1): Use the comp_unit obstack.
1157
1158 2020-02-12  Tom Tromey  <tom@tromey.com>
1159
1160         * dwarf2/frame.c (struct comp_unit): Add initializers and
1161         constructor.
1162         (dwarf2_frame_objfile_data): Store a comp_unit.
1163         (dwarf2_frame_find_fde): Update.
1164         (dwarf2_build_frame_info): Use "new".
1165
1166 2020-02-12  Tom Tromey  <tom@tromey.com>
1167
1168         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
1169         (dwarf2_fde_table): Typedef for std::vector.
1170         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
1171         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
1172         (decode_frame_entry): Update.
1173         (dwarf2_build_frame_info): Use "new".
1174
1175 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
1176
1177         * arm-tdep.c (arm_gdbarch_init): Update.
1178         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
1179         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
1180         have_neon, is_m>: Change to bool.
1181
1182 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
1183
1184         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
1185
1186 2020-02-12  Tom Tromey  <tom@tromey.com>
1187
1188         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
1189
1190 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
1191
1192         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
1193         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
1194
1195 2020-02-11  Tom Tromey  <tom@tromey.com>
1196
1197         * psymtab.h: Update comment.
1198
1199 2020-02-11  Tom Tromey  <tom@tromey.com>
1200
1201         * gdb_obstack.h (struct auto_obstack): Use
1202         DISABLE_COPY_AND_ASSIGN.
1203
1204 2020-02-11  Tom Tromey  <tom@tromey.com>
1205
1206         * dwarf2/frame.h (struct objfile): Don't forward declare.
1207
1208 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1209
1210         * cris-tdep.c (cris_supply_gregset): Change signature to match
1211         what struct regset expects.
1212         (cris_regset): New struct.
1213         (fetch_core_registers): Remove.
1214         (cris_iterate_over_regset_sections): New function.
1215         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
1216         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
1217
1218 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1219
1220         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
1221         registers.
1222
1223 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1224
1225         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
1226
1227 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1228
1229         * configure: Re-generate.
1230
1231 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1232
1233         * configure: Re-generate.
1234
1235 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1236
1237         * acinclude: Update warning.m4 path.
1238         * warning.m4: Move to gdbsupport.
1239
1240 2020-02-11  Tom Tromey  <tromey@adacore.com>
1241
1242         * remote.c (remote_console_output): Update.
1243         * printcmd.c (printf_command): Update.
1244         * event-loop.c (gdb_wait_for_event): Update.
1245         * linux-nat.c (sigchld_handler): Update.
1246         * remote-sim.c (gdb_os_write_stdout): Update.
1247         (gdb_os_flush_stdout): Update.
1248         (gdb_os_flush_stderr): Update.
1249         (gdb_os_write_stderr): Update.
1250         * exceptions.c (print_exception): Update.
1251         * remote-fileio.c (remote_fileio_func_read): Update.
1252         (remote_fileio_func_write): Update.
1253         * tui/tui.c (tui_enable): Update.
1254         * tui/tui-interp.c (tui_interp::init): Update.
1255         * utils.c (init_page_info): Update.
1256         (putchar_unfiltered, fputc_unfiltered): Update.
1257         (gdb_flush): Update.
1258         (emit_style_escape): Update.
1259         (flush_wrap_buffer, fputs_maybe_filtered): Update.
1260         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
1261         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
1262         (stderr_file::write): Update.
1263         (stderr_file::puts): Update.
1264         * ui-file.h (ui_file_isatty, ui_file_write)
1265         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
1266         (ui_file_puts): Don't declare.
1267
1268 2020-02-10  Tom de Vries  <tdevries@suse.de>
1269
1270         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
1271         sentinel to char *.
1272
1273 2020-02-09  Tom de Vries  <tdevries@suse.de>
1274
1275         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
1276         filename if it matches "<artificial>".
1277
1278 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1279
1280         * windows-tdep.c (struct enum_value_name): New struct.
1281         (create_enum): New function.
1282         (windows_get_siginfo_type): Create and use enum types.
1283
1284 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1285
1286         * NEWS: Mention $_siginfo support for Windows.
1287         * windows-nat.c (handle_exception): Set siginfo_er.
1288         (windows_nat_target::mourn_inferior): Reset siginfo_er.
1289         (windows_xfer_siginfo): New function.
1290         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
1291         * windows-tdep.c (struct windows_gdbarch_data): New struct.
1292         (init_windows_gdbarch_data): New function.
1293         (get_windows_gdbarch_data): New function.
1294         (windows_get_siginfo_type): New function.
1295         (windows_init_abi): Register windows_get_siginfo_type.
1296         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
1297
1298 2020-02-08  Tom Tromey  <tom@tromey.com>
1299
1300         * dwarf2/read.c (class cutu_reader) <cutu_reader,
1301         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
1302         <keep>: Declare method.
1303         <m_keep>: Remove member.
1304         <~cutu_reader>: Remove.
1305         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1306         (cutu_reader::cutu_reader): Update.
1307         (cutu_reader::keep): Rename from ~cutu_reader.
1308         (process_psymtab_comp_unit, build_type_psymtabs_1)
1309         (process_skeletonless_type_unit, load_partial_comp_unit)
1310         (load_full_comp_unit, dwarf2_read_addr_index)
1311         (read_signatured_type): Update.
1312
1313 2020-02-08  Tom Tromey  <tom@tromey.com>
1314
1315         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
1316         "want_partial_unit" parameter.
1317         (process_psymtab_comp_unit): Change want_partial_unit to bool.
1318         Inline check for DW_TAG_partial_unit.
1319         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
1320
1321 2020-02-08  Tom Tromey  <tom@tromey.com>
1322
1323         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
1324         read.c.
1325         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
1326         read.c.
1327
1328 2020-02-08  Tom Tromey  <tom@tromey.com>
1329
1330         * dwarf2/read.c (read_address): Move to comp-unit.c.
1331         (dwarf2_rnglists_process, dwarf2_ranges_process)
1332         (read_attribute_value, dwarf_decode_lines_1)
1333         (var_decode_location, decode_locdesc): Update.
1334         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
1335         read.c.  Remove "cu" parameter.
1336         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
1337         method.
1338
1339 2020-02-08  Tom Tromey  <tom@tromey.com>
1340
1341         * dwarf2/read.c (read_attribute_value, read_indirect_string)
1342         (read_indirect_line_string): Update.
1343         * dwarf2/comp-unit.c (read_offset): Remove.
1344         (read_comp_unit_head): Update.
1345         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
1346         method.
1347         (read_offset): Don't declare.
1348
1349 2020-02-08  Tom Tromey  <tom@tromey.com>
1350
1351         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
1352         * dwarf2/read.c (struct comp_unit_head): Move to
1353         dwarf2/comp-unit.h.
1354         (enum class rcuh_kind): Move to comp-unit.h.
1355         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
1356         (read_comp_unit_head, error_check_comp_unit_head)
1357         (read_and_check_comp_unit_head): Move to comp-unit.c.
1358         (read_offset, dwarf_unit_type_name): Likewise.
1359         (create_debug_type_hash_table, read_cutu_die_from_dwo)
1360         (cutu_reader::cutu_reader, read_call_site_scope)
1361         (find_partial_die, follow_die_offset): Update.
1362         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
1363
1364 2020-02-08  Tom Tromey  <tom@tromey.com>
1365
1366         * dwarf2/read.c (read_offset_1): Move to leb.c.
1367         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
1368         (dwarf_decode_macro_bytes): Update.
1369         * dwarf2/leb.c (read_offset): Rename; move from read.c.
1370         * dwarf2/leb.h (read_offset): Declare.
1371
1372 2020-02-08  Tom Tromey  <tom@tromey.com>
1373
1374         * dwarf2/read.c (dwarf2_section_size): Remove.
1375         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
1376         Update.
1377         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
1378
1379 2020-02-08  Tom Tromey  <tom@tromey.com>
1380
1381         * dwarf2/read.c (read_initial_length): Move to leb.c.
1382         * dwarf2/leb.h (read_initial_length): Declare.
1383         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
1384         handle_nonstd parameter.
1385         * dwarf2/frame.c (read_initial_length): Remove.
1386         (decode_frame_entry_1): Update.
1387
1388 2020-02-08  Tom Tromey  <tom@tromey.com>
1389
1390         * dwarf2/loc.c (dwarf2_find_location_expression)
1391         (dwarf_evaluate_loc_desc::get_tls_address)
1392         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
1393         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
1394         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
1395         (dwarf2_compile_property_to_c)
1396         (dwarf2_loc_desc_get_symbol_read_needs)
1397         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
1398         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
1399         (loclist_describe_location, loclist_tracepoint_var_ref)
1400         (loclist_generate_c_location): Update.
1401         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1402         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
1403         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
1404         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
1405         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
1406         (dwarf2_per_cu_data::addr_size)
1407         (dwarf2_per_cu_data::ref_addr_size)
1408         (dwarf2_per_cu_data::text_offset)
1409         (dwarf2_per_cu_data::addr_type): Now methods.
1410         (per_cu_header_read_in): Make per_cu "const".
1411         (dwarf2_version): Remove.
1412         (dwarf2_per_cu_data::int_type): Now a method.
1413         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
1414         (set_die_type, read_array_type, read_subrange_index_type)
1415         (read_tag_string_type, read_subrange_type): Update.
1416         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
1417         offset_size, ref_addr_size, text_offset, addr_type, version,
1418         objfile, int_type, addr_sized_int_type>: Declare methods.
1419
1420 2020-02-08  Tom Tromey  <tom@tromey.com>
1421
1422         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
1423         Move earlier.
1424
1425 2020-02-08  Tom Tromey  <tom@tromey.com>
1426
1427         * dwarf2/read.h (dwarf_line_debug): Declare.
1428         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
1429         * dwarf2/read.c: Move line_header code to new files.
1430         (dwarf_line_debug): No longer static.
1431         * dwarf2/line-header.c: New file.
1432         * dwarf2/line-header.h: New file.
1433
1434 2020-02-08  Tom Tromey  <tom@tromey.com>
1435
1436         * dwarf2/read.c (struct line_header) <file_full_name,
1437         file_file_name>: Return unique_xmalloc_ptr.
1438         (line_header::file_file_name): Update.
1439         (line_header::file_full_name): Update.
1440         (dw2_get_file_names_reader): Update.
1441         (macro_start_file): Update.
1442
1443 2020-02-08  Tom Tromey  <tom@tromey.com>
1444
1445         * dwarf2/read.c (struct line_header) <file_full_name,
1446         file_file_name>: Declare methods.
1447         (dw2_get_file_names_reader): Update.
1448         (file_file_name): Now a method.
1449         (file_full_name): Likewise.
1450         (macro_start_file): Update.
1451
1452 2020-02-08  Tom Tromey  <tom@tromey.com>
1453
1454         * dwarf2/read.c (dwarf_always_disassemble)
1455         (show_dwarf_always_disassemble): Move to loc.c.
1456         (_initialize_dwarf2_read): Move "always-disassemble" registration
1457         to loc.c.
1458         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
1459         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
1460         static.
1461         (show_dwarf_always_disassemble): Move from read.c.
1462         (_initialize_dwarf2loc): Move always-disassemble from read.c.
1463
1464 2020-02-08  Tom Tromey  <tom@tromey.com>
1465
1466         * dwarf2/read.c (~dwarf2_per_objfile): Update.
1467         (create_quick_file_names_table): Return htab_up.
1468         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
1469         Update.
1470         * dwarf2/read.h (struct dwarf2_per_objfile)
1471         <quick_file_names_table>: Now htab_up.
1472
1473 2020-02-08  Tom Tromey  <tom@tromey.com>
1474
1475         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
1476
1477 2020-02-08  Tom Tromey  <tom@tromey.com>
1478
1479         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
1480         Rewrite.
1481         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
1482         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
1483         (abbrev_table::abbrev_table): No longer inline.
1484         (ABBREV_HASH_SIZE): Remove.
1485         (abbrev_table::m_abbrevs): Now an htab_up.
1486
1487 2020-02-08  Tom Tromey  <tom@tromey.com>
1488
1489         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
1490         (cutu_reader): Update.
1491         (build_type_psymtabs_1): Update.
1492         * dwarf2/abbrev.c (abbrev_table::read): Rename.
1493         (abbrev_table::alloc_abbrev): Update.
1494         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
1495         (abbrev_table::read): New static method, renamed from
1496         abbrev_table_read_table.
1497         (abbrev_table::alloc_abbrev)
1498         (abbrev_table::add_abbrev): Now private.
1499         (abbrev_table::abbrev_table): Now private.
1500         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
1501
1502 2020-02-08  Tom Tromey  <tom@tromey.com>
1503
1504         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
1505         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
1506         htab_up.
1507
1508 2020-02-08  Tom Tromey  <tom@tromey.com>
1509
1510         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
1511         htab_up.
1512         (lookup_dwo_unit_in_dwp): Update.
1513         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
1514         on obstack.
1515
1516 2020-02-08  Tom Tromey  <tom@tromey.com>
1517
1518         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
1519         obstack.
1520
1521 2020-02-08  Tom Tromey  <tom@tromey.com>
1522
1523         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
1524         line_header_hash.
1525         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
1526         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
1527         Change type to htab_up.
1528
1529 2020-02-08  Tom Tromey  <tom@tromey.com>
1530
1531         * dwarf2/read.c (allocate_type_unit_groups_table): Return
1532         htab_up.  Don't allocate on obstack.
1533         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
1534         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
1535         Change type to htab_up.
1536
1537 2020-02-08  Tom Tromey  <tom@tromey.com>
1538
1539         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
1540         Change type to htab_up.
1541         * dwarf2/read.c (create_signatured_type_table_from_index)
1542         (create_signatured_type_table_from_debug_names)
1543         (create_all_type_units, add_type_unit)
1544         (lookup_dwo_signatured_type, lookup_signatured_type)
1545         (process_skeletonless_type_unit): Update.
1546         (create_debug_type_hash_table, create_debug_types_hash_table):
1547         Change type of types_htab.
1548         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
1549         htab_up.  Don't allocate on obstack.
1550         (create_cus_hash_table): Change type of cus_htab parameter.
1551         (struct dwo_file) <cus, tus>: Now htab_up.
1552         (lookup_dwo_signatured_type, lookup_dwo_cutu)
1553         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
1554         (queue_and_load_all_dwo_tus): Update.
1555         * dwarf2/index-write.c (write_gdbindex): Update.
1556         (write_debug_names): Update.
1557
1558 2020-02-08  Tom Tromey  <tom@tromey.com>
1559
1560         * dwarf2/read.h (struct dwarf2_queue_item): Move from
1561         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
1562         destructor.
1563         (struct dwarf2_per_objfile) <queue>: New member.
1564         * dwarf2/read.c (struct dwarf2_queue_item): Move to
1565         dwarf2/read.h.
1566         (dwarf2_queue, dwarf2_queue_tail): Remove.
1567         (class dwarf2_queue_guard): Add parameter to constructor.  Use
1568         DISABLE_COPY_AND_ASSIGN.
1569         <m_per_objfile>: New member.
1570         <~dwarf2_queue_guard>: Rewrite.
1571         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
1572         Update.
1573         (~dwarf2_queue_item): New.
1574
1575 2020-02-08  Tom Tromey  <tom@tromey.com>
1576
1577         * dwarf2/read.c (struct die_info) <has_children>: New member.
1578         (dw2_get_file_names_reader): Remove has_children.
1579         (dw2_get_file_names): Update.
1580         (read_cutu_die_from_dwo): Remove has_children.
1581         (cutu_reader::init_tu_and_read_dwo_dies)
1582         (cutu_reader::cutu_reader): Update.
1583         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
1584         Remove has_children.
1585         (build_type_psymtabs_1, process_skeletonless_type_unit)
1586         (load_partial_comp_unit, load_full_comp_unit): Update.
1587         (create_dwo_cu_reader): Remove has_children.
1588         (create_cus_hash_table, read_die_and_children): Update.
1589         (read_full_die_1,read_full_die): Remove has_children.
1590         (read_signatured_type): Update.
1591         (class cutu_reader) <has_children>: Remove.
1592
1593 2020-02-08  Tom Tromey  <tom@tromey.com>
1594
1595         * dwarf2/expr.c: Rename from dwarf2expr.c.
1596         * dwarf2/expr.h: Rename from dwarf2expr.h.
1597         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
1598         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
1599         * dwarf2/frame.c: Rename from dwarf2-frame.c.
1600         * dwarf2/frame.h: Rename from dwarf2-frame.h.
1601         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
1602         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
1603         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
1604         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
1605         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
1606         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
1607         * dwarf2/loc.c: Rename from dwarf2loc.c.
1608         * dwarf2/loc.h: Rename from dwarf2loc.h.
1609         * dwarf2/read.c: Rename from dwarf2read.c.
1610         * dwarf2/read.h: Rename from dwarf2read.h.
1611         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
1612         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
1613         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
1614         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
1615         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
1616         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
1617         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
1618         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
1619         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
1620         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
1621         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
1622         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
1623         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
1624         Update.
1625         * Makefile.in (COMMON_SFILES): Update.
1626         (HFILES_NO_SRCDIR): Update.
1627
1628 2020-02-08  Tom Tromey  <tom@tromey.com>
1629
1630         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
1631         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
1632
1633 2020-02-08  Tom Tromey  <tom@tromey.com>
1634
1635         * dwarf2read.h (struct die_info): Don't declare.
1636
1637 2020-02-08  Tom Tromey  <tom@tromey.com>
1638
1639         * dwarf2read.h (die_info_ptr): Remove typedef.
1640
1641 2020-02-08  Tom Tromey  <tom@tromey.com>
1642
1643         * dwarf2read.c (read_call_site_scope)
1644         (handle_data_member_location, dwarf2_add_member_fn)
1645         (mark_common_block_symbol_computed, read_common_block)
1646         (attr_to_dynamic_prop, partial_die_info::read)
1647         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
1648         (dwarf2_symbol_mark_computed, set_die_type): Update.
1649         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
1650         method.
1651         (attr_form_is_block): Don't declare.
1652         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
1653
1654 2020-02-08  Tom Tromey  <tom@tromey.com>
1655
1656         * dwarf2read.c (dwarf2_find_base_address, )
1657         (read_call_site_scope, rust_containing_type)
1658         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
1659         (handle_data_member_location, dwarf2_add_member_fn)
1660         (get_alignment, read_structure_type, process_structure_scope)
1661         (mark_common_block_symbol_computed, read_common_block)
1662         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
1663         (partial_die_info::read, read_attribute_value, new_symbol)
1664         (lookup_die_type, dwarf2_get_ref_die_offset)
1665         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
1666         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
1667         (dwarf2_symbol_mark_computed): Update.
1668         * dwarf2/attribute.h (struct attribute) <value_as_address,
1669         form_is_section_offset, form_is_constant, form_is_ref>: Declare
1670         methods.
1671         (value_as_address, attr_form_is_section_offset)
1672         (attr_form_is_constant, attr_form_is_ref): Don't declare.
1673         * dwarf2/attribute.c (attribute::value_as_address)
1674         (attribute::form_is_section_offset, attribute::form_is_constant)
1675         (attribute::form_is_ref): Now methods.
1676
1677 2020-02-08  Tom Tromey  <tom@tromey.com>
1678
1679         * dwarf2read.c (struct attribute, DW_STRING)
1680         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
1681         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
1682         (attr_form_is_block, attr_form_is_section_offset)
1683         (attr_form_is_constant, attr_form_is_ref): Move.
1684         * dwarf2/attribute.h: New file.
1685         * dwarf2/attribute.c: New file, from dwarf2read.c.
1686         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
1687
1688 2020-02-08  Tom Tromey  <tom@tromey.com>
1689
1690         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
1691         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
1692         Move.
1693         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
1694         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
1695         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
1696         abbrev.c.
1697         * dwarf2/abbrev.h: New file.
1698         * dwarf2/abbrev.c: New file, from dwarf2read.c.
1699         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
1700
1701 2020-02-08  Tom Tromey  <tom@tromey.com>
1702
1703         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
1704         (dwarf2_section_size, dwarf2_get_section_info)
1705         (create_signatured_type_table_from_debug_names)
1706         (create_addrmap_from_aranges, read_debug_names_from_section)
1707         (get_gdb_index_contents_from_section, read_comp_unit_head)
1708         (error_check_comp_unit_head, read_abbrev_offset)
1709         (create_debug_type_hash_table, init_cu_die_reader)
1710         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
1711         (read_comp_units_from_section, create_cus_hash_table)
1712         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
1713         (create_dwp_v2_section, dwarf2_rnglists_process)
1714         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
1715         (abbrev_table_read_table, read_indirect_string_at_offset_from)
1716         (read_indirect_string_from_dwz, read_addr_index_1)
1717         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
1718         (dwarf_decode_macro_bytes, dwarf_decode_macros)
1719         (fill_in_loclist_baton): Update.
1720         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
1721         get_containing_section, get_bfd_owner, get_bfd_section,
1722         get_file_name, get_id, get_flags, empty, read>: Declare methods.
1723         (dwarf2_read_section, get_section_name, get_section_file_name)
1724         (get_containing_section, get_section_bfd_owner)
1725         (get_section_bfd_section, get_section_name, get_section_file_name)
1726         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
1727         declare.
1728         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
1729         (dwarf2_section_info::get_bfd_owner)
1730         (dwarf2_section_info::get_bfd_section)
1731         (dwarf2_section_info::get_name)
1732         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
1733         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
1734         (dwarf2_section_info::read): Now methods.
1735         * dwarf-index-write.c (class debug_names): Update.
1736
1737 2020-02-08  Tom Tromey  <tom@tromey.com>
1738
1739         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
1740         Move to dwarf2/section.h.
1741         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
1742         (get_section_bfd_section, get_section_name)
1743         (get_section_file_name, get_section_id, get_section_flags)
1744         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
1745         dwarf2/section.c.
1746         * dwarf2/section.h: New file.
1747         * dwarf2/section.c: New file, from dwarf2read.c.
1748         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
1749
1750 2020-02-08  Tom Tromey  <tom@tromey.com>
1751
1752         * dwarf2read.h (read_unsigned_leb128): Don't declare.
1753         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
1754         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
1755         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
1756         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
1757         * dwarf2/leb.h: New file, from dwarf2read.c.
1758         * dwarf2/leb.c: New file, from dwarf2read.c.
1759         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
1760         Remove.
1761         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
1762         (COMMON_SFILES): Add dwarf2/leb.c.
1763
1764 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
1765
1766         GDB 9.1 released.
1767
1768 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1769
1770         PR gdb/25190:
1771         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
1772         * gdb/remote.c (remote_console_output): Update.
1773         * gdb/ui-file.c (fputs_unfiltered): Rename to...
1774         (ui_file_puts): ...this.
1775         * gdb/ui-file.h (ui_file_puts): Add declaration.
1776         * gdb/utils.c (emit_style_escape): Update.
1777         (flush_wrap_buffer): Update.
1778         (fputs_maybe_filtered): Update.
1779         (fputs_unfiltered): Add function.
1780
1781 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1782
1783         * gdb/event-loop.c (gdb_wait_for_event): Update.
1784         * gdb/printcmd.c (printf_command): Update.
1785         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
1786         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
1787         (gdb_os_flush_stderr): Update.
1788         * gdb/remote.c (remote_console_output): Update.
1789         * gdb/ui-file.c (gdb_flush): Rename to...
1790         (ui_file_flush): ...this.
1791         (stderr_file::write): Update.
1792         (stderr_file::puts): Update.
1793         * gdb/ui-file.h (gdb_flush): Rename to...
1794         (ui_file_flush): ...this.
1795         * gdb/utils.c (gdb_flush): Add function.
1796         * gdb/utils.h (gdb_flush): Add declaration.
1797
1798 2020-02-07  Tom Tromey  <tromey@adacore.com>
1799
1800         PR breakpoints/24915:
1801         * source.c (find_and_open_source): Do not check basenames_may_differ.
1802
1803 2020-02-07  Tom Tromey  <tom@tromey.com>
1804
1805         * README: Update gdbserver documentation.
1806         * gdbserver: Move to top level.
1807         * configure.tgt (build_gdbserver): Remove.
1808         * configure.ac: Remove --enable-gdbserver.
1809         * configure: Rebuild.
1810         * Makefile.in (distclean): Don't mention gdbserver.
1811
1812 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1813
1814         * source-cache.c (source_cache::ensure): Surround
1815         get_plain_source_lines with a try/catch.
1816         (source_cache::get_line_charpos): Get rid of try/catch
1817         and only check for the return value of "ensure".
1818         * tui/tui-source.c (tui_source_window::set_contents):
1819         Simplify "nlines" calculation.
1820
1821 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1822
1823         * MAINTAINERS (Write After Approval): Add myself.
1824
1825 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1826
1827         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
1828         function call.
1829
1830 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1831
1832         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
1833
1834 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
1835
1836         * nat/riscv-linux-tdesc.h: New file.
1837         * nat/riscv-linux-tdesc.c: New file, taking code from...
1838         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1839         ... here.
1840         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
1841         NATDEPFILES.
1842
1843 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1844
1845         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
1846         we don't set the fake simulator ptid to the null_ptid.
1847
1848 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
1849
1850         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
1851         * gdbthread.h (class thread_info) <resumed>: Likewise.
1852         * infrun.c (resume_1): Likewise.
1853         (proceed): Likewise.
1854         (infrun_thread_stop_requested): Likewise.
1855         (stop_all_threads): Likewise.
1856         (handle_inferior_event): Likewise.
1857         (restart_threads): Likewise.
1858         (finish_step_over): Likewise.
1859         (keep_going_stepped_thread): Likewise.
1860         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
1861         (linux_handle_extended_wait): Likewise.
1862         * record-btrace.c (get_thread_current_frame_id): Likewise.
1863         * record-full.c (record_full_wait_1): Likewise.
1864         * remote.c (remote_target::process_initial_stop_replies): Likewise.
1865         * target.c (target_resume): Likewise.
1866         * thread.c (set_running_thread): Likewise.
1867
1868 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1869
1870         * f-valprint.c (f77_print_array_1): Changed datatype of index
1871         variable to LONGEST from int to enable it to contain bound
1872         values correctly.
1873
1874 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
1875
1876         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
1877         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
1878         offsets according to FLEN determined.
1879         (riscv_linux_nat_target::read_description): Determine FLEN
1880         dynamically.
1881         (riscv_linux_nat_target::fetch_registers): Size regset buffer
1882         according to FLEN determined.
1883         (riscv_linux_nat_target::store_registers): Likewise.
1884
1885 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
1886
1887         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
1888         when reg->group is empty and reggroup is not.
1889
1890 2020-01-31  Tom Tromey  <tromey@adacore.com>
1891
1892         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
1893         Call beneath target's mourn_inferior after unpushing.
1894
1895 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1896
1897         PR tui/9765
1898         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
1899         have enough lines to fill the screen, still return the lowest
1900         address we found.
1901
1902 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1903
1904         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
1905         '-', '<', and '>' commands.
1906
1907 2020-01-29  Pedro Alves  <palves@redhat.com>
1908             Sergio Durigan Junior  <sergiodj@redhat.com>
1909
1910         * infcmd.c (construct_inferior_arguments): Assert that
1911         'argc' is greater than 0.
1912
1913 2020-01-29  Luis Machado  <luis.machado@linaro.org>
1914
1915         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
1916         (BRK_INSN_MASK): Define to 0xd4200000.
1917         (aarch64_program_breakpoint_here_p): New function.
1918         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
1919         * arch-utils.c (default_program_breakpoint_here_p): Moved from
1920         breakpoint.c.
1921         * arch-utils.h (default_program_breakpoint_here_p): Moved from
1922         breakpoint.h
1923         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
1924         call gdbarch_program_breakpoint_here_p.
1925         (program_breakpoint_here): Moved to arch-utils.c, renamed to
1926         default_program_breakpoint_here_p, changed return type to bool and
1927         simplified.
1928         * breakpoint.h (program_breakpoint_here): Moved prototype to
1929         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
1930         return type to bool.
1931         * gdbarch.c: Regenerate.
1932         * gdbarch.h: Regenerate.
1933         * gdbarch.sh (program_breakpoint_here_p): New method.
1934         * infrun.c (handle_signal_stop): Call
1935         gdbarch_program_breakpoint_here_p.
1936
1937 2020-01-26  Tom Tromey  <tom@tromey.com>
1938
1939         * ctfread.c (struct ctf_fp_info): Reindent.
1940         (_initialize_ctfread): Remove.
1941
1942 2020-01-26  Tom Tromey  <tom@tromey.com>
1943
1944         * psymtab.c (partial_map_expand_apply)
1945         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
1946         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
1947         (psym_print_stats, psym_expand_symtabs_for_function)
1948         (psym_map_symbol_filenames, psym_map_matching_symbols)
1949         (psym_expand_symtabs_matching)
1950         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
1951         (maintenance_check_psymtabs): Use new methods.
1952         * psympriv.h (struct partial_symtab) <readin_p,
1953         get_compunit_symtab>: New methods.
1954         <readin, compunit_symtab>: Remove members.
1955         (struct standard_psymtab): New.
1956         (struct legacy_psymtab): Derive from standard_psymtab.
1957         * dwarf2read.h (struct dwarf2_psymtab): Derive from
1958         standard_psymtab.
1959         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
1960
1961 2020-01-26  Tom Tromey  <tom@tromey.com>
1962
1963         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
1964         read_dependencies.  Add assert.
1965         * psymtab.c (partial_symtab::read_dependencies): New method.
1966         * psympriv.h (struct partial_symtab) <read_dependencies>: New
1967         method.
1968         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
1969         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
1970         read_dependencies.
1971         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
1972         Add assert.
1973
1974 2020-01-26  Tom Tromey  <tom@tromey.com>
1975
1976         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
1977         Call expand_psymtab.
1978         (xcoff_read_symtab): Call expand_psymtab.
1979         (xcoff_start_psymtab, xcoff_end_psymtab): Set
1980         legacy_expand_psymtab.
1981         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
1982         method.
1983         (struct legacy_psymtab) <expand_psymtab>: Implement.
1984         <legacy_expand_psymtab>: New member.
1985         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
1986         (parse_partial_symbols): Set legacy_expand_psymtab.
1987         (psymtab_to_symtab_1): Change argument order.  Call
1988         expand_psymtab.
1989         (new_psymtab): Set legacy_expand_psymtab.
1990         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
1991         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
1992         expand_psymtab.
1993         (dwarf2_psymtab::expand_psymtab): Rename from
1994         psymtab_to_symtab_1.  Call expand_psymtab.
1995         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
1996         (dbx_end_psymtab): Likewise.
1997         (dbx_psymtab_to_symtab_1): Change argument order. Call
1998         expand_psymtab.
1999         (dbx_read_symtab): Call expand_psymtab.
2000         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
2001         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
2002         (ctf_psymtab::read_symtab): Call expand_psymtab.
2003
2004 2020-01-26  Tom Tromey  <tom@tromey.com>
2005
2006         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
2007         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
2008         messages.
2009         * mdebugread.c (mdebug_read_symtab): Remove prints.
2010         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
2011         assert.
2012         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
2013
2014 2020-01-26  Tom Tromey  <tom@tromey.com>
2015
2016         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
2017         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
2018         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
2019         legacy_symtab.
2020         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
2021         * psymtab.c (psymtab_to_symtab): Call method.
2022         (dump_psymtab): Update.
2023         * psympriv.h (struct partial_symtab): Add virtual destructor.
2024         <read_symtab>: New method.
2025         (struct legacy_symtab): New.
2026         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
2027         (struct pst_map) <pst>: Now a legacy_psymtab.
2028         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
2029         (new_psymtab): Use legacy_psymtab.
2030         * dwarf2read.h (struct dwarf2_psymtab): New.
2031         (struct dwarf2_per_cu_data) <psymtab>: Use it.
2032         * dwarf2read.c (dwarf2_create_include_psymtab)
2033         (dwarf2_build_include_psymtabs, create_type_unit_group)
2034         (create_partial_symtab, process_psymtab_comp_unit_reader)
2035         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
2036         (set_partial_user): Use dwarf2_psymtab.
2037         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
2038         (psymtab_to_symtab_1, process_full_comp_unit)
2039         (process_full_type_unit, dwarf2_ranges_read)
2040         (dwarf2_get_pc_bounds, psymtab_include_file_name)
2041         (dwarf_decode_lines): Use dwarf2_psymtab.
2042         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
2043         (add_address_entry_worker, write_one_signatured_type)
2044         (recursively_count_psymbols, recursively_write_psymbols)
2045         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
2046         (write_debug_names): Likewise.
2047         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
2048         <pst>: Now a legacy_psymtab.
2049         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
2050         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
2051         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
2052         * ctfread.c (struct ctf_psymtab): New.
2053         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
2054         ctf_psymtab.
2055         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
2056         (create_partial_symtab): Return a ctf_psymtab.
2057         (scan_partial_symbols): Update.
2058
2059 2020-01-26  Tom Tromey  <tom@tromey.com>
2060
2061         * xcoffread.c (xcoff_start_psymtab): Use new.
2062         * psymtab.c (partial_symtab::partial_symtab): New constructor,
2063         renamed from start_psymtab_common.
2064         * psympriv.h (struct partial_symtab): Add new constructor.
2065         (start_psymtab_common): Don't declare.
2066         * mdebugread.c (parse_partial_symbols): Use new.
2067         * dwarf2read.c (create_partial_symtab): Use new.
2068         * dbxread.c (start_psymtab): Use new.
2069         * ctfread.c (create_partial_symtab): Use new.
2070
2071 2020-01-26  Tom Tromey  <tom@tromey.com>
2072
2073         * xcoffread.c (xcoff_end_psymtab): Use new.
2074         * psymtab.c (start_psymtab_common): Use new.
2075         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
2076         Update.
2077         * psympriv.h (struct partial_symtab): Add parameters to
2078         constructor.  Don't inline.
2079         (allocate_psymtab): Don't declare.
2080         * mdebugread.c (new_psymtab): Use new.
2081         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
2082         * dbxread.c (dbx_end_psymtab): Use new.
2083
2084 2020-01-26  Tom Tromey  <tom@tromey.com>
2085
2086         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
2087         allocate_psymtab.  Update documentation.
2088         * psymtab.c (psymtab_storage::install_psymtab): Rename from
2089         allocate_psymtab.  Do not use new.
2090         (allocate_psymtab): Use new.  Update.
2091
2092 2020-01-26  Tom Tromey  <tom@tromey.com>
2093
2094         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2095         * psymtab.c (psym_print_stats): Update.
2096         * psympriv.h (struct partial_symtab) <readin,
2097         psymtabs_addrmap_supported, anonymous>: Now bool.
2098         * mdebugread.c (psymtab_to_symtab_1): Update.
2099         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
2100         (build_type_psymtabs_reader, psymtab_to_symtab_1)
2101         (process_full_comp_unit, process_full_type_unit): Update.
2102         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2103         * ctfread.c (psymtab_to_symtab): Update.
2104
2105 2020-01-26  Tom Tromey  <tom@tromey.com>
2106
2107         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
2108         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
2109         * psymtab.c (psymtab_storage): Delete psymtabs.
2110         (psymtab_storage::allocate_psymtab): Use new.
2111         (psymtab_storage::discard_psymtab): Use delete.
2112         * psympriv.h (struct partial_symtab): Add constructor and
2113         initializers.
2114
2115 2020-01-26  Tom Tromey  <tom@tromey.com>
2116
2117         * machoread.c: Do not include psympriv.h.
2118
2119 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2120
2121         * NEWS: Mention the new option and the set/show commands.
2122
2123 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2124
2125         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
2126         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
2127         (validate_exec_file): New variables, enums, functions.
2128         (exec_file_locate_attach, print_section_info): Style the filenames.
2129         (_initialize_exec): Install show_exec_file_mismatch_command and
2130          set_exec_file_mismatch_command.
2131         * gdbcore.h (validate_exec_file): Declare.
2132         * infcmd.c (attach_command): Call validate_exec_file.
2133         * remote.c ( remote_target::remote_add_inferior): Likewise.
2134
2135 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2136
2137         * frame.c (find_frame_sal): Move call to get_next_frame into more
2138         inner scope.
2139         * inline-frame.c (inilne_state) <inline_state>: Update argument
2140         types.
2141         (inilne_state) <skipped_symbol>: Rename to...
2142         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
2143         (skip_inline_frames): Build vector of skipped symbols and use this
2144         to reate the inline_state.
2145         (inline_skipped_symbol): Add a comment and some assertions, fetch
2146         skipped symbol from the list.
2147
2148 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2149
2150         * buildsym.c (lte_is_less_than): Delete.
2151         (buildsym_compunit::end_symtab_with_blockvector): Create local
2152         lambda function to sort line table entries, and use
2153         std::stable_sort instead of std::sort.
2154         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
2155         markers when looking for a previous line.
2156
2157 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2158
2159         * dwarf2read.c (lnp_state_machine::record_line): Include
2160         end_sequence parameter in debug print out.  Record the line if we
2161         are at an end_sequence marker even if it's not the start of a
2162         statement.
2163         * symmisc.c (maintenance_print_one_line_table): Print end of
2164         sequence markers with 'END' not '0'.
2165
2166 2020-01-24  Pedro Alves  <palves@redhat.com>
2167
2168         PR gdb/25410
2169         * thread.c (scoped_restore_current_thread::restore): Use
2170         switch_to_inferior_no_thread.
2171         * exec.c: Include "progspace-and-thread.h".
2172         (add_target_sections, remove_target_sections):
2173         scoped_restore_current_pspace_and_thread instead of
2174         scoped_restore_current_thread.
2175         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
2176         and aspace to the inferior before calling clone_program_space.
2177         Remove stale comment.
2178
2179 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2180
2181         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
2182         (arm_netbsd_nat_target::fetch_registers): ...this.
2183         (arm_nbsd_nat_target::store_registers): Rename to...
2184         (arm_netbsd_nat_target::store_registers): ...this.
2185
2186 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2187
2188         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2189         register_t.
2190
2191 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2192
2193         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
2194         Update comment.
2195         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
2196         Likewise.
2197         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
2198         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
2199         the correct replacement (iterate_over_regset_sections).
2200         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
2201         Update comment.
2202
2203 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
2204
2205         PR gdb/23718
2206         * gdb/python/python.c (execute_gdb_command): Call
2207         async_enable_stdin in catch block.
2208
2209 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
2212         SWITCH_THRU_ALL_UIS.
2213
2214 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2215
2216         PR tui/9765
2217         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
2218         comment, add extra parameter, and update to store previous symbol
2219         when appropriate.
2220         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
2221         add extra parameter.
2222         * tui/tui-disasm.c (tui_disassemble): Update header comment,
2223         remove unneeded parameter, add try/catch around gdb_print_insn,
2224         rewrite to add items to asm_lines vector.
2225         (tui_find_backward_disassembly_start_address): New function.
2226         (tui_find_disassembly_address): Updated throughout.
2227         (tui_disasm_window::set_contents): Update for changes to
2228         tui_disassemble.
2229         (tui_disasm_window::do_scroll_vertical): No need to adjust the
2230         number of lines to scroll.
2231
2232 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
2233
2234         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
2235         (SECT_OFF_DATA): Likewise.
2236         (SECT_OFF_RODATA): Likewise.
2237         (SECT_OFF_TEXT): Likewise.
2238         (SECT_OFF_BSS): Likewise.
2239         (struct objfile) <text_section_offset, data_section_offset>: New
2240         methods.
2241         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
2242         objfile::text_section_offset.
2243         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
2244         * coffread.c (coff_symtab_read): Likewise.
2245         (enter_linenos): Likewise.
2246         (process_coff_symbol): Likewise.
2247         * ctfread.c (get_objfile_text_range): Likewise.
2248         * dtrace-probe.c (dtrace_probe::get_relocated_address):
2249         Use objfile::data_section_offset.
2250         * dwarf2-frame.c (execute_cfa_program): Use
2251         objfile::text_section_offset.
2252         (dwarf2_frame_find_fde): Likewise.
2253         * dwarf2read.c (create_addrmap_from_index): Likewise.
2254         (create_addrmap_from_aranges): Likewise.
2255         (dw2_find_pc_sect_compunit_symtab): Likewise.
2256         (process_psymtab_comp_unit_reader): Likewise.
2257         (add_partial_symbol): Likewise.
2258         (add_partial_subprogram): Likewise.
2259         (process_full_comp_unit): Likewise.
2260         (read_file_scope): Likewise.
2261         (read_func_scope): Likewise.
2262         (read_lexical_block_scope): Likewise.
2263         (read_call_site_scope): Likewise.
2264         (dwarf2_rnglists_process): Likewise.
2265         (dwarf2_ranges_process): Likewise.
2266         (dwarf2_ranges_read): Likewise.
2267         (dwarf_decode_lines_1): Likewise.
2268         (new_symbol): Likewise.
2269         (dwarf2_fetch_die_loc_sect_off): Likewise.
2270         (dwarf2_per_cu_text_offset): Likewise.
2271         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
2272         * hppa-tdep.c (read_unwind_info): Likewise.
2273         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
2274         * psympriv.h (struct partial_symtab): Likewise.
2275         * psymtab.c (find_pc_sect_psymtab): Likewise.
2276         * solib-svr4.c (enable_break): Likewise.
2277         * stap-probe.c (relocate_address): Use
2278         objfile::data_section_offset.
2279         * xcoffread.c (enter_line_range): Use
2280         objfile::text_section_offset.
2281         (read_xcoff_symtab): Likewise.
2282
2283 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2284
2285         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
2286         declaration to narrower scopes.
2287
2288 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2289
2290         * darwin-nat.h (struct darwin_exception_msg, enum
2291         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
2292         Move up.
2293         (class darwin_nat_target) <wait_1, check_new_threads,
2294         decode_exception_message, decode_message, stop_inferior,
2295         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
2296         * darwin-nat.c (darwin_check_new_threads): Rename to...
2297         (darwin_nat_target::check_new_threads): ... this.
2298         (darwin_suspend_inferior_it): Remove.
2299         (darwin_decode_exception_message): Rename to...
2300         (darwin_nat_target::decode_exception_message): ... this.
2301         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
2302         (darwin_decode_message): Rename to...
2303         (darwin_nat_target::decode_message): ... this.
2304         (cancel_breakpoint): Rename to...
2305         (darwin_nat_target::cancel_breakpoint): ... this.
2306         (darwin_wait): Rename to...
2307         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
2308         instead of iterate_over_inferiors.
2309         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
2310         (darwin_stop_inferior): Rename to...
2311         (darwin_nat_target::stop_inferior): ... this.
2312         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
2313         (darwin_init_thread_list): Rename to...
2314         (darwin_nat_target::init_thread_list): ... this.
2315         (darwin_ptrace_him): Rename to...
2316         (darwin_nat_target::ptrace_him): ... this.
2317         (darwin_nat_target::create_inferior): Pass lambda function to
2318         fork_inferior.
2319         (darwin_nat_target::detach): Call stop_inferior instead of
2320         darwin_stop_inferior.
2321         * fork-inferior.h (fork_inferior): Change init_trace_fun
2322         parameter to gdb::function_view.
2323         * fork-inferior.c (fork_inferior): Likewise.
2324
2325 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
2326
2327         * i386-cygwin-tdep.c (core_process_module_section): Update.
2328         * windows-nat.c (struct lm_info_windows): Add text_offset.
2329         (windows_xfer_shared_libraries): Update.
2330         * windows-tdep.c (windows_xfer_shared_library):
2331         Add text_offset_cached argument.
2332         * windows-tdep.h (windows_xfer_shared_library): Update.
2333
2334 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2335
2336         * gdbarch.sh: Add declaration for _initialize_gdbarch.
2337
2338 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2339
2340         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
2341         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
2342         replace with range-based for.
2343         (gdbsim_interrupt_inferior): Remove.
2344         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
2345         with a range-based for.  Inline code from
2346         gdbsim_interrupt_inferior.
2347
2348 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2349
2350         * infrun.c (proceed): Fix indentation.
2351
2352 2020-01-21  Tom Tromey  <tromey@adacore.com>
2353
2354         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
2355         * python/python.c (python_extension_ops): Update.
2356         (gdbpy_colorize): New function.
2357         * python/lib/gdb/__init__.py (colorize): New function.
2358         * extension.h (ext_lang_colorize): Declare.
2359         * extension.c (ext_lang_colorize): New function.
2360         * extension-priv.h (struct extension_language_ops) <colorize>: New
2361         member.
2362         * cli/cli-style.c (_initialize_cli_style): Update help text.
2363
2364 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2365
2366         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
2367         <cond>: Change type to bool.
2368         (aarch64_displaced_step_b_cond): Update cond to use bool type.
2369         (aarch64_displaced_step_cb): Likewise.
2370         (aarch64_displaced_step_tb): Likewise.
2371
2372 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2373
2374         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
2375         output.
2376
2377 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2378
2379         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
2380         <pc_adjust>: Adjust the documentation.
2381         (aarch64_displaced_step_fixup): Check if PC really moved before
2382         adjusting it.
2383
2384 2020-01-19  Tom Tromey  <tom@tromey.com>
2385
2386         * disasm.c (~gdb_disassembler): New destructor.
2387         (gdb_buffered_insn_length): Call disassemble_free_target.
2388         * disasm.h (class gdb_disassembler): Declare destructor.  Use
2389         DISABLE_COPY_AND_ASSIGN.
2390
2391 2020-01-19  Tom Tromey  <tom@tromey.com>
2392
2393         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
2394         (die_reader_func_ftype): Remove.
2395         (cutu_reader): New class.
2396         (dw2_get_file_names_reader): Remove "data" parameter.
2397         (dw2_get_file_names): Use cutu_reader.
2398         (create_debug_type_hash_table): Update.
2399         (read_cutu_die_from_dwo): Update comment.
2400         (lookup_dwo_unit): Add dwo_name parameter.
2401         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
2402         die_reader_func_ftype and data parameters.
2403         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
2404         Remove die_reader_func_ftype and data parameters.
2405         (~cutu_reader): New; from init_cutu_and_read_dies.
2406         (cutu_reader::cutu_reader): Rename from
2407         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
2408         and data parameters.
2409         (init_cutu_and_read_dies_simple): Remove.
2410         (struct process_psymtab_comp_unit_data): Remove.
2411         (process_psymtab_comp_unit_reader): Remove data parameter; add
2412         want_partial_unit and pretend_language parameters.
2413         (process_psymtab_comp_unit): Use cutu_reader.
2414         (build_type_psymtabs_reader): Remove data parameter.
2415         (build_type_psymtabs_1): Use cutu_reader.
2416         (process_skeletonless_type_unit): Likewise.
2417         (load_partial_comp_unit_reader): Remove.
2418         (load_partial_comp_unit): Use cutu_reader.
2419         (load_full_comp_unit_reader): Remove.
2420         (load_full_comp_unit): Use cutu_reader.
2421         (struct create_dwo_cu_data): Remove.
2422         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
2423         dwo_unit parameters.
2424         (create_cus_hash_table): Use cutu_reader.
2425         (struct dwarf2_read_addr_index_data): Remove.
2426         (dwarf2_read_addr_index_reader): Remove.
2427         (dwarf2_read_addr_index): Use cutu_reader.
2428         (read_signatured_type_reader): Remove.
2429         (read_signatured_type): Use cutu_reader.
2430
2431 2020-01-19  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
2434         * tui/tui-wingeneral.h (class tui_suppress_output): New.
2435         (tui_wrefresh): Declare.
2436         * tui/tui-wingeneral.c (suppress_output): New global.
2437         (tui_suppress_output, ~tui_suppress_output): New constructor and
2438         destructor.
2439         (tui_wrefresh): New function.
2440         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
2441         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
2442         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
2443         method.
2444         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
2445         tui_wrefresh.
2446         (tui_data_window::no_refresh): New method.
2447         (tui_data_item_window::refresh_window): Call tui_wrefresh.
2448         (tui_reg_command): Use tui_suppress_output
2449         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
2450         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
2451         method.
2452         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
2453
2454 2020-01-19  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-winsource.c (tui_update_source_windows_with_line):
2457         Handle case where symtab is null.
2458
2459 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
2460
2461         * linux-fork.c (one_fork_p): Simplify.
2462
2463 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2464
2465         * top.c (struct qt_args): Remove.
2466         (kill_or_detach): Change return type to void, replace `void *`
2467         parameter with a proper one.
2468         (print_inferior_quit_action):  Likewise.
2469         (quit_confirm): Use range-based for loop to iterate over inferiors.
2470         (quit_force): Likewise.
2471
2472 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2473
2474         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
2475         `void *` parameter with proper parameters.
2476         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
2477         (print_one_inferior): Change return type to void, replace `void *`
2478         parameter with proper parameters.
2479         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
2480         inferiors.
2481         (get_other_inferior): Remove.
2482         (mi_cmd_remove_inferior): Use range-based loop to iterate over
2483         inferiors.
2484
2485 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2486
2487         * mi/mi-interp.c (report_initial_inferior): Remove.
2488         (mi_interp::init): Use range-based for to iterate over inferiors.
2489
2490 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2491
2492         * python/py-inferior.c (build_inferior_list): Remove.
2493         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
2494
2495 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
2496
2497         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
2498         (btrace_stitch_trace): Likewise.
2499         * charset.c (intermediate_encoding): Likewise (vaild).
2500         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
2501         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
2502         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
2503
2504 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
2505
2506         * windows-tdep.c (windows_get_tlb_type):
2507         Add rtl_user_process_parameters type.
2508
2509 2020-01-16  Pedro Alves  <palves@redhat.com>
2510             Norbert Lange  <nolange79@gmail.com>
2511
2512         PR build/24805
2513         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
2514         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
2515         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
2516         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
2517         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
2518         (ps_plog): Redeclare exported functions with default visibility.
2519
2520 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
2521
2522         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
2523         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
2524
2525 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
2526
2527         * infcmd.c (post_create_inferior): Use get_thread_regcache
2528         instead of get_current_regcache.
2529
2530 2020-01-14  Tom Tromey  <tom@tromey.com>
2531
2532         PR symtab/12535:
2533         * python/python.c (gdbpy_decode_line): Treat empty string the same
2534         as no argument.
2535
2536 2020-01-14  Tom Tromey  <tom@tromey.com>
2537
2538         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
2539
2540 2020-01-14  Tom Tromey  <tom@tromey.com>
2541
2542         * nat/linux-btrace.c: Don't include <config.h>.
2543         * nat/linux-ptrace.c: Don't include <config.h>.
2544         * nat/x86-linux-dregs.c: Don't include <config.h>.
2545
2546 2020-01-14  Tom Tromey  <tom@tromey.com>
2547
2548         * configure: Rebuild.
2549         * configure.ac: Move many checks to ../gdbsupport/common.m4.
2550
2551 2020-01-14  Tom Tromey  <tom@tromey.com>
2552
2553         * nat/x86-linux-dregs.c: Include configh.h.
2554         * nat/linux-ptrace.c: Include configh.h.
2555         * nat/linux-btrace.c: Include configh.h.
2556         * defs.h: Include config.h, bfd.h.
2557         * configure.ac: Don't source common.host.
2558         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
2559         * configure: Rebuild.
2560         * acinclude.m4: Update path.
2561         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
2562         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
2563         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
2564         (CLIBS): Add LIBSUPPORT.
2565         (CDEPS): Likewise.
2566         (COMMON_SFILES): Remove gdbsupport files.
2567         (HFILES_NO_SRCDIR): Likewise.
2568         (stamp-version): Update path to create-version.sh.
2569         (ALLDEPFILES): Remove gdbsupport files.
2570
2571 2020-01-14  Tom Tromey  <tom@tromey.com>
2572
2573         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
2574         USE_WIN32API when needed.
2575         * configure.ac (USE_WIN32API): Don't define.
2576         (WIN32LIBS): Use WIN32APILIBS.
2577         * configure: Rebuild.
2578
2579 2020-01-14  Tom Tromey  <tom@tromey.com>
2580
2581         * configure: Rebuild.
2582         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
2583
2584 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2585
2586         * skip.c (skip_function_command): Make skip w/o arguments use the
2587         name of the inlined function if pc is inside any inlined function.
2588
2589 2020-01-14  Luis Machado  <luis.machado@linaro.org>
2590
2591         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
2592         * infrun.c (resume_1): Likewise.
2593         (handle_inferior_event): Remove stale comment.
2594         * linux-nat.c (linux_nat_target::resume): Update comments.
2595         (save_stop_reason): Likewise.
2596         (linux_nat_filter_event): Likewise.
2597         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
2598
2599 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         * elfread.c (record_minimal_symbol): Set section index to 0 for
2602         non-allocatable sections.
2603
2604
2605 2020-01-13  Ali Tamur <tamur@google.com>
2606
2607         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
2608         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
2609         to gdb::optional.  Update comments.
2610         (dwo_file): Update comments.
2611         (read_attribute): Update API to take an additional out parameter,
2612         need_reprocess.  This is used to mark attributes that need other
2613         attributes (e.g. str_offsets_base) for correct computation which may not
2614         have been read yet.
2615         (read_attribute_reprocess): New function declaration.
2616         (read_addr_index): Likewise.
2617         (read_dwo_str_index): Likewise.
2618         (read_stub_str_index): Likewise.
2619         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
2620         (lookup_addr_base): New function definition.
2621         (lookup_ranges_base): Likewise.
2622         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
2623         lookup_ranges_base.
2624         (init_cutu_and_read_dies): Update comments.
2625         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
2626         unit.  This is used to inherit parent's str_offsets_base and addr_base.
2627         Update comments.
2628         (init_cutu_and_read_dies_simple): Reflect API changes.
2629         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
2630         (create_cus_hash_table): Change API to take parent compile unit.
2631         Reflect API changes.
2632         (open_and_init_dwo_file): Reflect API changes.
2633         (dwarf2_get_pc_bounds): Update comments.
2634         (dwarf2_record_block_ranges): Likewise.
2635         (read_full_die_1): Change implementation to reprocess attributes that
2636         need str_offsets_base and addr_base.
2637         (partial_die_info::read): Likewise.
2638         (read_attribute_reprocess): New function definition.
2639         (read_attribute_value): Change API to take an additional out parameter,
2640         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
2641         when a non-dwo compile unit has index based attributes.
2642         (read_attribute): Reflect API changes.
2643         (read_addr_index_1): Reflect API changes.  Update comments.
2644         (dwarf2_read_addr_index_data): Reflect API changes.
2645         (dwarf2_read_addr_index): Likewise.
2646         (read_str_index): Change API and implementation.  This becomes a helper
2647         to be used by the new string index related methods.  Update error
2648         message and comments.
2649         (read_dwo_str_index): New function definition.
2650         (read_stub_str_index): Likewise.
2651         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
2652         * symfile.h (dwarf2_debug_sections): Likewise.
2653         * xcoffread.c (dwarf2_debug_sections): Likewise.
2654
2655 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2656
2657         * gdbcore.h (struct core_fns) <core_read_registers>: Change
2658         core_reg_sect type to gdb_byte *.
2659         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
2660         * cris-tdep.c (fetch_core_registers): Likewise.
2661         * corelow.c (core_target::get_core_register_section): Change
2662         type of `contents` to gdb::byte_vector.
2663
2664 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2665
2666         * tui/tui-wingeneral.c (box_win): Position the title in the center
2667         of the border.
2668
2669 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2670
2671         * corelow.c (core_target::get_core_register_section): Use
2672           std::vector instead of alloca.
2673
2674 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2675
2676         * warning.m4: Add -Wmissing-declarations to build_warnings.
2677         * configure: Re-generate.
2678
2679 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2680
2681         * python/python.c (init__gdb_module): Add declaration.
2682
2683 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2684
2685         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
2686         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
2687         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
2688         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
2689         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
2690         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
2691         * ada-exp.y (_initialize_ada_exp): Add declaration.
2692         * ada-lang.c (_initialize_ada_language): Add declaration.
2693         * ada-tasks.c (_initialize_tasks): Add declaration.
2694         * agent.c (_initialize_agent): Add declaration.
2695         * aix-thread.c (_initialize_aix_thread): Add declaration.
2696         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
2697         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
2698         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
2699         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
2700         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
2701         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
2702         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
2703         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
2704         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
2705         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
2706         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
2707         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
2708         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
2709         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
2710         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
2711         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
2712         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
2713         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
2714         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
2715         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
2716         * annotate.c (_initialize_annotate): Add declaration.
2717         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
2718         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
2719         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
2720         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
2721         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
2722         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
2723         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
2724         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
2725         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
2726         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
2727         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
2728         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
2729         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
2730         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
2731         * auto-load.c (_initialize_auto_load): Add declaration.
2732         * auxv.c (_initialize_auxv): Add declaration.
2733         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
2734         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
2735         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
2736         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
2737         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
2738         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
2739         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
2740         * breakpoint.c (_initialize_breakpoint): Add declaration.
2741         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
2742         * btrace.c (_initialize_btrace): Add declaration.
2743         * charset.c (_initialize_charset): Add declaration.
2744         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
2745         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
2746         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
2747         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
2748         * cli/cli-script.c (_initialize_cli_script): Add declaration.
2749         * cli/cli-style.c (_initialize_cli_style): Add declaration.
2750         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
2751         * coffread.c (_initialize_coffread): Add declaration.
2752         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
2753         * compile/compile.c (_initialize_compile): Add declaration.
2754         * complaints.c (_initialize_complaints): Add declaration.
2755         * completer.c (_initialize_completer): Add declaration.
2756         * copying.c (_initialize_copying): Add declaration.
2757         * corefile.c (_initialize_core): Add declaration.
2758         * corelow.c (_initialize_corelow): Add declaration.
2759         * cp-abi.c (_initialize_cp_abi): Add declaration.
2760         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
2761         * cp-support.c (_initialize_cp_support): Add declaration.
2762         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
2763         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
2764         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
2765         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
2766         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
2767         * ctfread.c (_initialize_ctfread): Add declaration.
2768         * d-lang.c (_initialize_d_language): Add declaration.
2769         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
2770         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
2771         * dbxread.c (_initialize_dbxread): Add declaration.
2772         * dcache.c (_initialize_dcache): Add declaration.
2773         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
2774         * disasm.c (_initialize_disasm): Add declaration.
2775         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
2776         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
2777         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
2778         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
2779         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
2780         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
2781         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
2782         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
2783         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
2784         * elfread.c (_initialize_elfread): Add declaration.
2785         * exec.c (_initialize_exec): Add declaration.
2786         * extension.c (_initialize_extension): Add declaration.
2787         * f-lang.c (_initialize_f_language): Add declaration.
2788         * f-valprint.c (_initialize_f_valprint): Add declaration.
2789         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
2790         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
2791         * filesystem.c (_initialize_filesystem): Add declaration.
2792         * findcmd.c (_initialize_mem_search): Add declaration.
2793         * findvar.c (_initialize_findvar): Add declaration.
2794         * fork-child.c (_initialize_fork_child): Add declaration.
2795         * frame-base.c (_initialize_frame_base): Add declaration.
2796         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
2797         * frame.c (_initialize_frame): Add declaration.
2798         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
2799         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
2800         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
2801         * gcore.c (_initialize_gcore): Add declaration.
2802         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
2803         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
2804         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
2805         * gdbarch.c (_initialize_gdbarch): Add declaration.
2806         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
2807         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
2808         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
2809         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
2810         * go-lang.c (_initialize_go_language): Add declaration.
2811         * go32-nat.c (_initialize_go32_nat): Add declaration.
2812         * guile/guile.c (_initialize_guile): Add declaration.
2813         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
2814         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
2815         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
2816         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
2817         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
2818         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
2819         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
2820         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
2821         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
2822         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
2823         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
2824         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
2825         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
2826         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
2827         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
2828         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
2829         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
2830         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
2831         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
2832         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
2833         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
2834         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
2835         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
2836         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
2837         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
2838         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
2839         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
2840         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
2841         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
2842         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
2843         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
2844         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
2845         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
2846         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
2847         * infcall.c (_initialize_infcall): Add declaration.
2848         * infcmd.c (_initialize_infcmd): Add declaration.
2849         * inflow.c (_initialize_inflow): Add declaration.
2850         * infrun.c (_initialize_infrun): Add declaration.
2851         * interps.c (_initialize_interpreter): Add declaration.
2852         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
2853         * jit.c (_initialize_jit): Add declaration.
2854         * language.c (_initialize_language): Add declaration.
2855         * linux-fork.c (_initialize_linux_fork): Add declaration.
2856         * linux-nat.c (_initialize_linux_nat): Add declaration.
2857         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
2858         * linux-thread-db.c (_initialize_thread_db): Add declaration.
2859         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
2860         * m2-lang.c (_initialize_m2_language): Add declaration.
2861         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
2862         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
2863         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
2864         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
2865         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
2866         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
2867         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
2868         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
2869         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
2870         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
2871         * machoread.c (_initialize_machoread): Add declaration.
2872         * macrocmd.c (_initialize_macrocmd): Add declaration.
2873         * macroscope.c (_initialize_macroscope): Add declaration.
2874         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
2875         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
2876         * maint.c (_initialize_maint_cmds): Add declaration.
2877         * mdebugread.c (_initialize_mdebugread): Add declaration.
2878         * memattr.c (_initialize_mem): Add declaration.
2879         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
2880         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
2881         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
2882         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
2883         * mi/mi-main.c (_initialize_mi_main): Add declaration.
2884         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
2885         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
2886         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
2887         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
2888         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
2889         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
2890         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
2891         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
2892         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
2893         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
2894         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
2895         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
2896         * mipsread.c (_initialize_mipsread): Add declaration.
2897         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
2898         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
2899         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
2900         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
2901         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
2902         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
2903         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
2904         * nto-procfs.c (_initialize_procfs): Add declaration.
2905         * objc-lang.c (_initialize_objc_language): Add declaration.
2906         * observable.c (_initialize_observer): Add declaration.
2907         * opencl-lang.c (_initialize_opencl_language): Add declaration.
2908         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
2909         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
2910         * osabi.c (_initialize_gdb_osabi): Add declaration.
2911         * osdata.c (_initialize_osdata): Add declaration.
2912         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
2913         * parse.c (_initialize_parse): Add declaration.
2914         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
2915         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
2916         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
2917         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
2918         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
2919         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
2920         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
2921         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
2922         * printcmd.c (_initialize_printcmd): Add declaration.
2923         * probe.c (_initialize_probe): Add declaration.
2924         * proc-api.c (_initialize_proc_api): Add declaration.
2925         * proc-events.c (_initialize_proc_events): Add declaration.
2926         * proc-service.c (_initialize_proc_service): Add declaration.
2927         * procfs.c (_initialize_procfs): Add declaration.
2928         * producer.c (_initialize_producer): Add declaration.
2929         * psymtab.c (_initialize_psymtab): Add declaration.
2930         * python/python.c (_initialize_python): Add declaration.
2931         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
2932         * record-btrace.c (_initialize_record_btrace): Add declaration.
2933         * record-full.c (_initialize_record_full): Add declaration.
2934         * record.c (_initialize_record): Add declaration.
2935         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
2936         * regcache.c (_initialize_regcache): Add declaration.
2937         * reggroups.c (_initialize_reggroup): Add declaration.
2938         * remote-notif.c (_initialize_notif): Add declaration.
2939         * remote-sim.c (_initialize_remote_sim): Add declaration.
2940         * remote.c (_initialize_remote): Add declaration.
2941         * reverse.c (_initialize_reverse): Add declaration.
2942         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
2943         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
2944         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
2945         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
2946         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
2947         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
2948         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
2949         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
2950         Add declaration.
2951         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
2952         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
2953         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
2954         * rust-exp.y (_initialize_rust_exp): Add declaration.
2955         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
2956         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
2957         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
2958         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
2959         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
2960         * score-tdep.c (_initialize_score_tdep): Add declaration.
2961         * ser-go32.c (_initialize_ser_dos): Add declaration.
2962         * ser-mingw.c (_initialize_ser_windows): Add declaration.
2963         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
2964         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
2965         * ser-uds.c (_initialize_ser_socket): Add declaration.
2966         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
2967         * serial.c (_initialize_serial): Add declaration.
2968         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
2969         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
2970         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
2971         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
2972         * skip.c (_initialize_step_skip): Add declaration.
2973         * sol-thread.c (_initialize_sol_thread): Add declaration.
2974         * solib-aix.c (_initialize_solib_aix): Add declaration.
2975         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
2976         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
2977         * solib-frv.c (_initialize_frv_solib): Add declaration.
2978         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
2979         * solib-target.c (_initialize_solib_target): Add declaration.
2980         * solib.c (_initialize_solib): Add declaration.
2981         * source-cache.c (_initialize_source_cache): Add declaration.
2982         * source.c (_initialize_source): Add declaration.
2983         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
2984         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
2985         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
2986         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
2987         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
2988         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
2989         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
2990         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
2991         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
2992         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
2993         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
2994         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
2995         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
2996         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
2997         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
2998         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
2999         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
3000         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
3001         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
3002         * stabsread.c (_initialize_stabsread): Add declaration.
3003         * stack.c (_initialize_stack): Add declaration.
3004         * stap-probe.c (_initialize_stap_probe): Add declaration.
3005         * std-regs.c (_initialize_frame_reg): Add declaration.
3006         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
3007         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
3008         * symfile.c (_initialize_symfile): Add declaration.
3009         * symmisc.c (_initialize_symmisc): Add declaration.
3010         * symtab.c (_initialize_symtab): Add declaration.
3011         * target.c (_initialize_target): Add declaration.
3012         * target-connection.c (_initialize_target_connection): Add
3013         declaration.
3014         * target-dcache.c (_initialize_target_dcache): Add declaration.
3015         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
3016         * thread.c (_initialize_thread): Add declaration.
3017         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
3018         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
3019         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
3020         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
3021         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
3022         * tracectf.c (_initialize_ctf): Add declaration.
3023         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
3024         * tracefile.c (_initialize_tracefile): Add declaration.
3025         * tracepoint.c (_initialize_tracepoint): Add declaration.
3026         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
3027         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
3028         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
3029         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
3030         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
3031         * tui/tui-win.c (_initialize_tui_win): Add declaration.
3032         * tui/tui.c (_initialize_tui): Add declaration.
3033         * typeprint.c (_initialize_typeprint): Add declaration.
3034         * ui-style.c (_initialize_ui_style): Add declaration.
3035         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
3036         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
3037         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
3038         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
3039         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
3040         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
3041         * unittests/filtered_iterator-selftests.c
3042         (_initialize_filtered_iterator_selftests): Add declaration.
3043         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
3044         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
3045         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
3046         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
3047         * unittests/main-thread-selftests.c
3048         (_initialize_main_thread_selftests): Add declaration.
3049         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
3050         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
3051         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
3052         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
3053         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
3054         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
3055         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
3056         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
3057         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
3058         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
3059         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
3060         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
3061         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
3062         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
3063         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
3064         declaration.
3065         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
3066         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
3067         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
3068         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
3069         * user-regs.c (_initialize_user_regs): Add declaration.
3070         * utils.c (_initialize_utils): Add declaration.
3071         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
3072         * valops.c (_initialize_valops): Add declaration.
3073         * valprint.c (_initialize_valprint): Add declaration.
3074         * value.c (_initialize_values): Add declaration.
3075         * varobj.c (_initialize_varobj): Add declaration.
3076         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
3077         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
3078         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
3079         * windows-nat.c (_initialize_windows_nat): Add declaration.
3080         (_initialize_check_for_gdb_ini): Add declaration.
3081         (_initialize_loadable): Add declaration.
3082         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
3083         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
3084         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
3085         * xcoffread.c (_initialize_xcoffread): Add declaration.
3086         * xml-support.c (_initialize_xml_support): Add declaration.
3087         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
3088         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
3089         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
3090         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
3091
3092 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3093
3094         * regformats/regdat.sh: Generate declaration for init function.
3095
3096 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3097
3098         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
3099         up.
3100         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
3101         close_one_inferior>: New methods.
3102         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
3103         pass down target to find_inferior_pid.
3104         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
3105         Pass down target to find_inferior_ptid.
3106         (gdbsim_target::create_inferior): Pass down target to
3107         add_thread_silent.
3108         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
3109         target down to find_inferior_ptid and switch_to_thread.
3110         (gdbsim_target::close): Update to call close_one_inferior.
3111         (struct resume_data): Remove.
3112         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
3113         directly, rather than through a void pointer.
3114         (gdbsim_target::resume): Update to call resume_one_inferior.
3115
3116 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
3117
3118         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
3119
3120 2020-01-12  Pedro Alves  <palves@redhat.com>
3121
3122         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
3123         directly for the current inferior instead of
3124         discard_all_inferiors.
3125         (discard_all_inferiors): Delete.
3126
3127 2020-01-11  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui-wingeneral.c (box_win): Check cli_styling.
3130         * tui/tui-winsource.c (tui_source_window_base::refill): Use
3131         deprecated_safe_get_selected_frame.
3132
3133 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3134
3135         * inferior.c (print_inferior): Switch inferior before printing it.
3136
3137 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
3138             Pedro Alves  <palves@redhat.com>
3139
3140         * progspace-and-thread.c (switch_to_program_space_and_thread):
3141         Assert there's an inferior for PSPACE.  Use
3142         switch_to_inferior_no_thread to switch the inferior too.
3143         * progspace.c (program_space::~program_space): Call
3144         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
3145         (program_space::free_all_objfiles): Don't call clear_symtab_users
3146         here.
3147         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
3148
3149 2020-01-10  Pedro Alves  <palves@redhat.com>
3150
3151         * NEWS: Mention multi-target debugging, "info connections", and
3152         "add-inferior -no-connection".
3153
3154 2020-01-10  Pedro Alves  <palves@redhat.com>
3155
3156         * infrun.c: Include "target-connection.h".
3157         (check_multi_target_resumption): New.
3158         (proceed): Call it.
3159         * target-connection.c (make_target_connection_string): Make
3160         extern.
3161         * target-connection.h (make_target_connection_string): Declare.
3162
3163 2020-01-10  Pedro Alves  <palves@redhat.com>
3164
3165         * Makefile.in (COMMON_SFILES): Add target-connection.c.
3166         * inferior.c (uiout_field_connection): New function.
3167         (print_inferior): Add new "connection-id" column.
3168         (add_inferior_command): Show connection number/string of added
3169         inferior.
3170         * process-stratum-target.h
3171         (process_stratum_target::connection_string): New virtual method.
3172         (process_stratum_target::connection_number): New field.
3173         * remote.c (remote_target::connection_string): New override.
3174         * target-connection.c: New file.
3175         * target-connection.h: New file.
3176         * target.c (decref_target): Remove process_stratum targets from
3177         the connection list.
3178         (target_stack::push): Add process_stratum targets to the
3179         connection list.
3180
3181 2020-01-10  Pedro Alves  <palves@redhat.com>
3182
3183         Revert:
3184         2016-04-12  Pedro Alves  <palves@redhat.com>
3185         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
3186         Remove references to name.
3187         * serial.h (struct serial) <name>: Delete.
3188
3189 2020-01-10  Pedro Alves  <palves@redhat.com>
3190
3191         * gdbarch-selftests.c (register_to_value_test): Remove "target
3192         already pushed" check.
3193
3194 2020-01-10  Pedro Alves  <palves@redhat.com>
3195             John Baldwin  <jhb@FreeBSD.org>
3196
3197         * aarch64-linux-nat.c
3198         (aarch64_linux_nat_target::thread_architecture): Adjust.
3199         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
3200         (task_command_1): Likewise.
3201         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
3202         (aix_thread_target::wait, aix_thread_target::fetch_registers)
3203         (aix_thread_target::store_registers)
3204         (aix_thread_target::thread_alive): Adjust.
3205         * amd64-fbsd-tdep.c: Include "inferior.h".
3206         (amd64fbsd_get_thread_local_address): Pass down target.
3207         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
3208         thread's gdbarch instead of target_gdbarch.
3209         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
3210         get_last_target_status.
3211         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
3212         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
3213         inferiors.
3214         (update_inserted_breakpoint_locations): Skip if inferiors with no
3215         execution.
3216         (update_global_location_list): When handling moribund locations,
3217         find representative inferior for location's pspace, and use thread
3218         count of its process_stratum target.
3219         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
3220         * bsd-uthread.c (bsd_uthread_target::wait): Use
3221         as_process_stratum_target and adjust thread_change_ptid and
3222         add_thread calls.
3223         (bsd_uthread_target::update_thread_list): Use
3224         as_process_stratum_target and adjust find_thread_ptid,
3225         thread_change_ptid and add_thread calls.
3226         * btrace.c (maint_btrace_packet_history_cmd): Adjust
3227         find_thread_ptid call.
3228         * corelow.c (add_to_thread_list): Adjust add_thread call.
3229         (core_target_open): Adjust add_thread_silent and thread_count
3230         calls.
3231         (core_target::pid_to_str): Adjust find_inferior_ptid call.
3232         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
3233         * event-top.c (async_disconnect): Pop targets from all inferiors.
3234         * exec.c (add_target_sections): Push exec target on all inferiors
3235         sharing the program space.
3236         (remove_target_sections): Remove the exec target from all
3237         inferiors sharing the program space.
3238         (exec_on_vfork): New.
3239         * exec.h (exec_on_vfork): Declare.
3240         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
3241         Pass it down.
3242         (fbsd_nat_target::update_thread_list): Adjust.
3243         (fbsd_nat_target::resume): Adjust.
3244         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
3245         down.
3246         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
3247         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
3248         get_thread_arch_regcache call.
3249         * fork-child.c (gdb_startup_inferior): Pass target down to
3250         startup_inferior and set_executing.
3251         * gdbthread.h (struct process_stratum_target): Forward declare.
3252         (add_thread, add_thread_silent, add_thread_with_info)
3253         (in_thread_list): Add process_stratum_target parameter.
3254         (find_thread_ptid(inferior*, ptid_t)): New overload.
3255         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
3256         parameter.
3257         (all_threads()): Delete overload.
3258         (all_threads, all_non_exited_threads): Add process_stratum_target
3259         parameter.
3260         (all_threads_safe): Use brace initialization.
3261         (thread_count): Add process_stratum_target parameter.
3262         (set_resumed, set_running, set_stop_requested, set_executing)
3263         (threads_are_executing, finish_thread_state): Add
3264         process_stratum_target parameter.
3265         (switch_to_thread): Use is_current_thread.
3266         * i386-fbsd-tdep.c: Include "inferior.h".
3267         (i386fbsd_get_thread_local_address): Pass down target.
3268         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
3269         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
3270         have_inferiors check.
3271         * inf-ptrace.c (inf_ptrace_target::create_inferior)
3272         (inf_ptrace_target::attach): Adjust.
3273         * infcall.c (run_inferior_call): Adjust.
3274         * infcmd.c (run_command_1): Pass target to
3275         scoped_finish_thread_state.
3276         (proceed_thread_callback): Skip inferiors with no execution.
3277         (continue_command): Rename 'all_threads' local to avoid hiding
3278         'all_threads' function.  Adjust get_last_target_status call.
3279         (prepare_one_step): Adjust set_running call.
3280         (signal_command): Use user_visible_resume_target.  Compare thread
3281         pointers instead of inferior_ptid.
3282         (info_program_command): Adjust to pass down target.
3283         (attach_command): Mark target's 'thread_executing' flag.
3284         (stop_current_target_threads_ns): New, factored out from ...
3285         (interrupt_target_1): ... this.  Switch inferior before making
3286         target calls.
3287         * inferior-iter.h
3288         (struct all_inferiors_iterator, struct all_inferiors_range)
3289         (struct all_inferiors_safe_range)
3290         (struct all_non_exited_inferiors_range): Filter on
3291         process_stratum_target too.  Remove explicit.
3292         * inferior.c (inferior::inferior): Push dummy target on target
3293         stack.
3294         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
3295         Add process_stratum_target parameter, and pass it down.
3296         (have_live_inferiors): Adjust.
3297         (switch_to_inferior_and_push_target): New.
3298         (add_inferior_command, clone_inferior_command): Handle
3299         "-no-connection" parameter.  Use
3300         switch_to_inferior_and_push_target.
3301         (_initialize_inferior): Mention "-no-connection" option in
3302         the help of "add-inferior" and "clone-inferior" commands.
3303         * inferior.h: Include "process-stratum-target.h".
3304         (interrupt_target_1): Use bool.
3305         (struct inferior) <push_target, unpush_target, target_is_pushed,
3306         find_target_beneath, top_target, process_target, target_at,
3307         m_stack>: New.
3308         (discard_all_inferiors): Delete.
3309         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
3310         (all_inferiors, all_non_exited_inferiors): Add
3311         process_stratum_target parameter.
3312         * infrun.c: Include "gdb_select.h" and <unordered_map>.
3313         (target_last_proc_target): New global.
3314         (follow_fork_inferior): Push target on new inferior.  Pass target
3315         to add_thread_silent.  Call exec_on_vfork.  Handle target's
3316         reference count.
3317         (follow_fork): Adjust get_last_target_status call.  Also consider
3318         target.
3319         (follow_exec): Push target on new inferior.
3320         (struct execution_control_state) <target>: New field.
3321         (user_visible_resume_target): New.
3322         (do_target_resume): Call target_async.
3323         (resume_1): Set target's threads_executing flag.  Consider resume
3324         target.
3325         (commit_resume_all_targets): New.
3326         (proceed): Also consider resume target.  Skip threads of inferiors
3327         with no execution.  Commit resumtion in all targets.
3328         (start_remote): Pass current inferior to wait_for_inferior.
3329         (infrun_thread_stop_requested): Consider target as well.  Pass
3330         thread_info pointer to clear_inline_frame_state instead of ptid.
3331         (infrun_thread_thread_exit): Consider target as well.
3332         (random_pending_event_thread): New inferior parameter.  Use it.
3333         (do_target_wait): Rename to ...
3334         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
3335         down.
3336         (threads_are_resumed_pending_p, do_target_wait): New.
3337         (prepare_for_detach): Adjust calls.
3338         (wait_for_inferior): New inferior parameter.  Handle it.  Use
3339         do_target_wait_1 instead of do_target_wait.
3340         (fetch_inferior_event): Adjust.  Switch to representative
3341         inferior.  Pass target down.
3342         (set_last_target_status): Add process_stratum_target parameter.
3343         Save target in global.
3344         (get_last_target_status): Add process_stratum_target parameter and
3345         handle it.
3346         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
3347         (context_switch): Check inferior_ptid == null_ptid before calling
3348         inferior_thread().
3349         (get_inferior_stop_soon): Pass down target.
3350         (wait_one): Rename to ...
3351         (poll_one_curr_target): ... this.
3352         (struct wait_one_event): New.
3353         (wait_one): New.
3354         (stop_all_threads): Adjust.
3355         (handle_no_resumed, handle_inferior_event): Adjust to consider the
3356         event's target.
3357         (switch_back_to_stepped_thread): Also consider target.
3358         (print_stop_event): Update.
3359         (normal_stop): Update.  Also consider the resume target.
3360         * infrun.h (wait_for_inferior): Remove declaration.
3361         (user_visible_resume_target): New declaration.
3362         (get_last_target_status, set_last_target_status): New
3363         process_stratum_target parameter.
3364         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3365         process_stratum_target parameter, and use it.
3366         (clear_inline_frame_state (thread_info*)): New.
3367         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3368         process_stratum_target parameter.
3369         (clear_inline_frame_state (thread_info*)): Declare.
3370         * linux-fork.c (delete_checkpoint_command): Pass target down to
3371         find_thread_ptid.
3372         (checkpoint_command): Adjust.
3373         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
3374         instead of just tweaking inferior_ptid.
3375         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
3376         (exit_lwp): Pass target down to find_thread_ptid.
3377         (attach_proc_task_lwp_callback): Pass target down to
3378         add_thread/set_running/set_executing.
3379         (linux_nat_target::attach): Pass target down to
3380         thread_change_ptid.
3381         (get_detach_signal): Pass target down to find_thread_ptid.
3382         Consider last target status's target.
3383         (linux_resume_one_lwp_throw, resume_lwp)
3384         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
3385         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
3386         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
3387         (linux_nat_target::async_wait_fd): New.
3388         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
3389         target down.
3390         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
3391         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
3392         * linux-thread-db.c (struct thread_db_info::process_target): New
3393         field.
3394         (add_thread_db_info): Save target.
3395         (get_thread_db_info): New process_stratum_target parameter.  Also
3396         match target.
3397         (delete_thread_db_info): New process_stratum_target parameter.
3398         Also match target.
3399         (thread_from_lwp): Adjust to pass down target.
3400         (thread_db_notice_clone): Pass down target.
3401         (check_thread_db_callback): Pass down target.
3402         (try_thread_db_load_1): Always push the thread_db target.
3403         (try_thread_db_load, record_thread): Pass target down.
3404         (thread_db_target::detach): Pass target down.  Always unpush the
3405         thread_db target.
3406         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
3407         target down.  Always unpush the thread_db target.
3408         (find_new_threads_callback, thread_db_find_new_threads_2)
3409         (thread_db_target::update_thread_list): Pass target down.
3410         (thread_db_target::pid_to_str): Pass current inferior down.
3411         (thread_db_target::get_thread_local_address): Pass target down.
3412         (thread_db_target::resume, maintenance_check_libthread_db): Pass
3413         target down.
3414         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
3415         * procfs.c (procfs_target::procfs_init_inferior): Declare.
3416         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
3417         (procfs_init_inferior): Rename to ...
3418         (procfs_target::procfs_init_inferior): ... this and adjust.
3419         (procfs_target::create_inferior, procfs_notice_thread)
3420         (procfs_do_thread_registers): Adjust.
3421         * ppc-fbsd-tdep.c: Include "inferior.h".
3422         (ppcfbsd_get_thread_local_address): Pass down target.
3423         * proc-service.c (ps_xfer_memory): Switch current inferior and
3424         program space as well.
3425         (get_ps_regcache): Pass target down.
3426         * process-stratum-target.c
3427         (process_stratum_target::thread_address_space)
3428         (process_stratum_target::thread_architecture): Pass target down.
3429         * process-stratum-target.h
3430         (process_stratum_target::threads_executing): New field.
3431         (as_process_stratum_target): New.
3432         * ravenscar-thread.c
3433         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
3434         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
3435         down.
3436         * record-btrace.c (record_btrace_target::info_record): Adjust.
3437         (record_btrace_target::record_method)
3438         (record_btrace_target::record_is_replaying)
3439         (record_btrace_target::fetch_registers)
3440         (get_thread_current_frame_id, record_btrace_target::resume)
3441         (record_btrace_target::wait, record_btrace_target::stop): Pass
3442         target down.
3443         * record-full.c (record_full_wait_1): Switch to event thread.
3444         Pass target down.
3445         * regcache.c (regcache::regcache)
3446         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
3447         process_stratum_target parameter and handle it.
3448         (current_thread_target): New global.
3449         (get_thread_regcache): Add process_stratum_target parameter and
3450         handle it.  Switch inferior before calling target method.
3451         (get_thread_regcache): Pass target down.
3452         (get_thread_regcache_for_ptid): Pass target down.
3453         (registers_changed_ptid): Add process_stratum_target parameter and
3454         handle it.
3455         (registers_changed_thread, registers_changed): Pass target down.
3456         (test_get_thread_arch_aspace_regcache): New.
3457         (current_regcache_test): Define a couple local test_target_ops
3458         instances and use them for testing.
3459         (readwrite_regcache): Pass process_stratum_target parameter.
3460         (cooked_read_test, cooked_write_test): Pass mock_target down.
3461         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
3462         (get_thread_arch_aspace_regcache): Add process_stratum_target
3463         parameter.
3464         (regcache::target): New method.
3465         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
3466         (regcache::registers_changed_ptid): Add process_stratum_target
3467         parameter.
3468         (regcache::m_target): New field.
3469         (registers_changed_ptid): Add process_stratum_target parameter.
3470         * remote.c (remote_state::supports_vCont_probed): New field.
3471         (remote_target::async_wait_fd): New method.
3472         (remote_unpush_and_throw): Add remote_target parameter.
3473         (get_current_remote_target): Adjust.
3474         (remote_target::remote_add_inferior): Push target.
3475         (remote_target::remote_add_thread)
3476         (remote_target::remote_notice_new_inferior)
3477         (get_remote_thread_info): Pass target down.
3478         (remote_target::update_thread_list): Skip threads of inferiors
3479         bound to other targets.  (remote_target::close): Don't discard
3480         inferiors.  (remote_target::add_current_inferior_and_thread)
3481         (remote_target::process_initial_stop_replies)
3482         (remote_target::start_remote)
3483         (remote_target::remote_serial_quit_handler): Pass down target.
3484         (remote_target::remote_unpush_target): New remote_target
3485         parameter.  Unpush the target from all inferiors.
3486         (remote_target::remote_unpush_and_throw): New remote_target
3487         parameter.  Pass it down.
3488         (remote_target::open_1): Check whether the current inferior has
3489         execution instead of checking whether any inferior is live.  Pass
3490         target down.
3491         (remote_target::remote_detach_1): Pass down target.  Use
3492         remote_unpush_target.
3493         (extended_remote_target::attach): Pass down target.
3494         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
3495         (remote_target::append_resumption): Pass down target.
3496         (remote_target::append_pending_thread_resumptions)
3497         (remote_target::remote_resume_with_hc, remote_target::resume)
3498         (remote_target::commit_resume): Pass down target.
3499         (remote_target::remote_stop_ns): Check supports_vCont_probed.
3500         (remote_target::interrupt_query)
3501         (remote_target::remove_new_fork_children)
3502         (remote_target::check_pending_events_prevent_wildcard_vcont)
3503         (remote_target::remote_parse_stop_reply)
3504         (remote_target::process_stop_reply): Pass down target.
3505         (first_remote_resumed_thread): New remote_target parameter.  Pass
3506         it down.
3507         (remote_target::wait_as): Pass down target.
3508         (unpush_and_perror): New remote_target parameter.  Pass it down.
3509         (remote_target::readchar, remote_target::remote_serial_write)
3510         (remote_target::getpkt_or_notif_sane_1)
3511         (remote_target::kill_new_fork_children, remote_target::kill): Pass
3512         down target.
3513         (remote_target::mourn_inferior): Pass down target.  Use
3514         remote_unpush_target.
3515         (remote_target::core_of_thread)
3516         (remote_target::remote_btrace_maybe_reopen): Pass down target.
3517         (remote_target::pid_to_exec_file)
3518         (remote_target::thread_handle_to_thread_info): Pass down target.
3519         (remote_target::async_wait_fd): New.
3520         * riscv-fbsd-tdep.c: Include "inferior.h".
3521         (riscv_fbsd_get_thread_local_address): Pass down target.
3522         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
3523         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
3524         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
3525         Adjust.
3526         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
3527         * solib-svr4.c (enable_break): Pass down target.
3528         * spu-multiarch.c (parse_spufs_run): Pass down target.
3529         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
3530         * target-delegates.c: Regenerate.
3531         * target.c (g_target_stack): Delete.
3532         (current_top_target): Return the current inferior's top target.
3533         (target_has_execution_1): Refer to the passed-in inferior's top
3534         target.
3535         (target_supports_terminal_ours): Check whether the initial
3536         inferior was already created.
3537         (decref_target): New.
3538         (target_stack::push): Incref/decref the target.
3539         (push_target, push_target, unpush_target): Adjust.
3540         (target_stack::unpush): Defref target.
3541         (target_is_pushed): Return bool.  Adjust to refer to the current
3542         inferior's target stack.
3543         (dispose_inferior): Delete, and inline parts ...
3544         (target_preopen): ... here.  Only dispose of the current inferior.
3545         (target_detach): Hold strong target reference while detaching.
3546         Pass target down.
3547         (target_thread_name): Add assertion.
3548         (target_resume): Pass down target.
3549         (target_ops::beneath, find_target_at): Adjust to refer to the
3550         current inferior's target stack.
3551         (get_dummy_target): New.
3552         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
3553         has a thread running.
3554         (initialize_targets): Rename to ...
3555         (_initialize_target): ... this.
3556         * target.h: Include "gdbsupport/refcounted-object.h".
3557         (struct target_ops): Inherit refcounted_object.
3558         (target_ops::shortname, target_ops::longname): Make const.
3559         (target_ops::async_wait_fd): New method.
3560         (decref_target): Declare.
3561         (struct target_ops_ref_policy): New.
3562         (target_ops_ref): New typedef.
3563         (get_dummy_target): Declare function.
3564         (target_is_pushed): Return bool.
3565         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
3566         (all_matching_threads_iterator::all_matching_threads_iterator):
3567         Handle filter target.
3568         * thread-iter.h (struct all_matching_threads_iterator, struct
3569         all_matching_threads_range, class all_non_exited_threads_range):
3570         Filter by target too.  Remove explicit.
3571         * thread.c (threads_executing): Delete.
3572         (inferior_thread): Pass down current inferior.
3573         (clear_thread_inferior_resources): Pass down thread pointer
3574         instead of ptid_t.
3575         (add_thread_silent, add_thread_with_info, add_thread): Add
3576         process_stratum_target parameter.  Use it for thread and inferior
3577         searches.
3578         (is_current_thread): New.
3579         (thread_info::deletable): Use it.
3580         (find_thread_ptid, thread_count, in_thread_list)
3581         (thread_change_ptid, set_resumed, set_running): New
3582         process_stratum_target parameter.  Pass it down.
3583         (set_executing): New process_stratum_target parameter.  Pass it
3584         down.  Adjust reference to 'threads_executing'.
3585         (threads_are_executing): New process_stratum_target parameter.
3586         Adjust reference to 'threads_executing'.
3587         (set_stop_requested, finish_thread_state): New
3588         process_stratum_target parameter.  Pass it down.
3589         (switch_to_thread): Also match inferior.
3590         (switch_to_thread): New process_stratum_target parameter.  Pass it
3591         down.
3592         (update_threads_executing): Reimplement.
3593         * top.c (quit_force): Pop targets from all inferior.
3594         (gdb_init): Don't call initialize_targets.
3595         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
3596         Declare.
3597         (windows_add_thread, windows_delete_thread): Adjust.
3598         (get_windows_debug_event): Rename to ...
3599         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
3600         * tracefile-tfile.c (tfile_target_open): Pass down target.
3601         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
3602         Forward declare.
3603         (switch_to_thread): Add process_stratum_target parameter.
3604         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
3605         parameter.  Use it.
3606         (mi_on_resume): Pass target down.
3607         * nat/fork-inferior.c (startup_inferior): Add
3608         process_stratum_target parameter.  Pass it down.
3609         * nat/fork-inferior.h (startup_inferior): Add
3610         process_stratum_target parameter.
3611         * python/py-threadevent.c (py_get_event_thread): Pass target down.
3612
3613 2020-01-10  Pedro Alves  <palves@redhat.com>
3614
3615         * remote.c (remote_target::start_remote): Don't set inferior_ptid
3616         directly.  Instead find the first thread in the thread list and
3617         use switch_to_thread.
3618
3619 2020-01-10  Pedro Alves  <palves@redhat.com>
3620
3621         * remote.c (remote_target::remote_add_inferior): Don't bind a
3622         process to the current inferior if the current inferior is already
3623         bound to a process.
3624
3625 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3626             Pedro Alves  <palves@redhat.com>
3627
3628         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
3629         If no process is specified, return null_ptid instead of
3630         inferior_ptid.
3631         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
3632         TARGET_WAITKIND_SIGNALLED with no pid.
3633
3634 2020-01-10  Pedro Alves  <palves@redhat.com>
3635
3636         * remote.c (first_remote_resumed_thread): New.
3637         (remote_target::wait_as): Use it as default event_ptid instead of
3638         inferior_ptid.
3639
3640 2020-01-10  Pedro Alves  <palves@redhat.com>
3641
3642         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
3643
3644 2020-01-10  Pedro Alves  <palves@redhat.com>
3645
3646         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
3647         not -1.
3648
3649 2020-01-10  Pedro Alves  <palves@redhat.com>
3650
3651         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
3652         ptid to get_last_target_status.
3653         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
3654         ptid to get_last_target_status.
3655         * infcmd.c (continue_command): Don't pass a target_waitstatus to
3656         get_last_target_status.
3657         (info_program_command): Don't pass a target_waitstatus to
3658         get_last_target_status.
3659         * infrun.c (init_wait_for_inferior): Use
3660         nullify_last_target_wait_ptid.
3661         (get_last_target_status): Handle nullptr arguments.
3662         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
3663         (print_stop_event): Don't pass a ptid to get_last_target_status.
3664         (normal_stop): Don't pass a ptid to get_last_target_status.
3665         * infrun.h (get_last_target_status, set_last_target_status): Move
3666         comments here and update.
3667         (nullify_last_target_wait_ptid): Declare.
3668         * linux-fork.c (fork_load_infrun_state): Remove local extern
3669         declaration of nullify_last_target_wait_ptid.
3670         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
3671         to get_last_target_status.
3672
3673 2020-01-10  Pedro Alves  <palves@redhat.com>
3674
3675         * gdbthread.h (scoped_restore_current_thread)
3676         <dont_restore, restore, m_dont_restore>: Declare.
3677         * thread.c (thread_alive): Add assertion.  Return bool.
3678         (switch_to_thread_if_alive): New.
3679         (prune_threads): Switch inferior/thread.
3680         (print_thread_info_1): Switch thread before calling target methods.
3681         (scoped_restore_current_thread::restore): New, factored out from
3682         ...
3683         (scoped_restore_current_thread::~scoped_restore_current_thread):
3684         ... this.
3685         (scoped_restore_current_thread::scoped_restore_current_thread):
3686         Add assertion.
3687         (thread_apply_all_command, thread_select): Use
3688         switch_to_thread_if_alive.
3689         * infrun.c (proceed, restart_threads, handle_signal_stop)
3690         (switch_back_to_stepped_thread): Switch current thread before
3691         calling target methods.
3692
3693 2020-01-10  Pedro Alves <palves@redhat.com>
3694
3695         * inferior.c (switch_to_inferior_no_thread): New function,
3696         factored out from ...
3697         (inferior_command): ... here.
3698         * inferior.h (switch_to_inferior_no_thread): Declare.
3699         * mi/mi-main.c (run_one_inferior): Use
3700         switch_to_inferior_no_thread.
3701
3702 2020-01-10  Pedro Alves  <palves@redhat.com>
3703
3704         * infcmd.c (kill_command): Remove dead code.
3705
3706 2020-01-10  Pedro Alves  <palves@redhat.com>
3707
3708         * remote.c (remote_target::mourn_inferior): No longer check
3709         whether the target is running.
3710
3711 2020-01-10  Pedro Alves  <palves@redhat.com>
3712
3713         * corelow.c (core_target::has_execution): Change parameter type to
3714         inferior pointer.
3715         * inferior.c (number_of_live_inferiors): Use
3716         inferior::has_execution instead of target_has_execution_1.
3717         * inferior.h (inferior::has_execution): New.
3718         * linux-thread-db.c (thread_db_target::update_thread_list): Use
3719         inferior::has_execution instead of target_has_execution_1.
3720         * process-stratum-target.c
3721         (process_stratum_target::has_execution): Change parameter type to
3722         inferior pointer.  Check the inferior's PID instead of
3723         inferior_ptid.
3724         * process-stratum-target.h
3725         (process_stratum_target::has_execution): Change parameter type to
3726         inferior pointer.
3727         * record-full.c (record_full_core_target::has_execution): Change
3728         parameter type to inferior pointer.
3729         * target.c (target_has_execution_1): Change parameter type to
3730         inferior pointer.
3731         (target_has_execution_current): Adjust.
3732         * target.h (target_ops::has_execution): Change parameter type to
3733         inferior pointer.
3734         (target_has_execution_1): Change parameter type to inferior
3735         pointer.  Change return type to bool.
3736         * tracefile.h (tracefile_target::has_execution): Change parameter
3737         type to inferior pointer.
3738
3739 2020-01-10  Pedro Alves  <palves@redhat.com>
3740
3741         * exceptions.c (print_flush): Remove current_top_target() check.
3742
3743 2020-01-10  Pedro Alves  <palves@redhat.com>
3744
3745         * remote.c (show_remote_exec_file): Show the current inferior's
3746         exec-file instead of the command variable's value.
3747
3748 2020-01-10  Pedro Alves  <palves@redhat.com>
3749
3750         * record-full.c (record_full_resume_ptid): New global.
3751         (record_full_target::resume): Set it.
3752         (record_full_wait_1): Use record_full_resume_ptid instead of
3753         inferior_ptid.
3754
3755 2020-01-10  Pedro Alves  <palves@redhat.com>
3756
3757         * gdbthread.h (scoped_restore_current_thread)
3758         <dont_restore, restore, m_dont_restore>: Declare.
3759         * thread.c (thread_alive): Add assertion.  Return bool.
3760         (switch_to_thread_if_alive): New.
3761         (prune_threads): Switch inferior/thread.
3762         (print_thread_info_1): Switch thread before calling target methods.
3763         (scoped_restore_current_thread::restore): New, factored out from
3764         ...
3765         (scoped_restore_current_thread::~scoped_restore_current_thread):
3766         ... this.
3767         (scoped_restore_current_thread::scoped_restore_current_thread):
3768         Add assertion.
3769         (thread_apply_all_command, thread_select): Use
3770         switch_to_thread_if_alive.
3771
3772 2020-01-10  George Barrett  <bob@bob131.so>
3773
3774         * stap-probe.c (stap_modify_semaphore): Don't check for null
3775         semaphores.
3776         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
3777         for null semaphores.
3778
3779 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
3782         all source windows, and maintain horizontal scroll status while
3783         doing so.
3784
3785 2020-01-09  Tom Tromey  <tom@tromey.com>
3786
3787         PR tui/18932:
3788         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
3789         update_source_window, not print_source_lines.
3790
3791 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3792
3793         * tui/tui.c (tui_enable): Register tui hooks after calling
3794         tui_display_main.
3795
3796 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3797
3798         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
3799
3800 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
3801
3802         * thread.c (print_thread_info_1): Fix indentation.
3803
3804 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3805
3806         * symtab.c (general_symbol_info::compute_and_set_names): Move the
3807         unique_xmalloc_ptr outside the if to always free the demangled name.
3808
3809 2020-01-08  Tom Tromey  <tromey@adacore.com>
3810
3811         * xcoffread.c (enter_line_range, read_xcoff_symtab)
3812         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
3813         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
3814         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
3815         Remove.
3816         (section_offsets): New typedef.
3817         * symtab.c (fixup_section, get_msymbol_address): Update.
3818         * symmisc.c (dump_msymbols): Update.
3819         * symfile.h (relative_addr_info_to_section_offsets)
3820         (symfile_map_offsets_to_segments): Update.
3821         * symfile.c (build_section_addr_info_from_objfile)
3822         (init_objfile_sect_indices): Update.
3823         (struct place_section_arg): Change type of "offsets".
3824         (place_section): Update.
3825         (relative_addr_info_to_section_offsets): Change type of
3826         "section_offsets".  Remove "num_sections" parameter.
3827         (default_symfile_offsets, syms_from_objfile_1)
3828         (set_objfile_default_section_offset): Update.
3829         (reread_symbols): No need to preserve section offsets by hand.
3830         (symfile_map_offsets_to_segments): Change type of "offsets".
3831         * stap-probe.c (relocate_address): Update.
3832         * stabsread.h (process_one_symbol): Update.
3833         * solib-target.c (struct lm_info_target) <offsets>: Change type.
3834         (solib_target_relocate_section_addresses): Update.
3835         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
3836         Update.
3837         * solib-frv.c (frv_relocate_main_executable): Update.
3838         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
3839         * solib-aix.c (solib_aix_get_section_offsets): Change return
3840         type.
3841         (solib_aix_solib_create_inferior_hook): Update.
3842         * remote.c (remote_target::get_offsets): Update.
3843         * psymtab.c (find_pc_sect_psymtab): Update.
3844         * psympriv.h (struct partial_symbol) <address, text_low,
3845         text_high>: Update.
3846         * objfiles.h (obj_section_offset): Update.
3847         (struct objfile) <section_offsets>: Change type.
3848         <num_sections>: Remove.
3849         (objfile_relocate): Update.
3850         * objfiles.c (entry_point_address_query): Update
3851         (relocate_one_symbol): Change type of "section_offsets".
3852         (objfile_relocate1, objfile_relocate1): Change type of
3853         "new_offsets".
3854         (objfile_rebase1): Update.
3855         * mipsread.c (mipscoff_symfile_read): Update.
3856         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
3857         parameter.
3858         * mdebugread.c (parse_symbol): Change type of "section_offsets".
3859         (parse_external, psymtab_to_symtab_1): Update.
3860         * machoread.c (macho_symfile_offsets): Update.
3861         * ia64-tdep.c (ia64_find_unwind_table): Update.
3862         * hppa-tdep.c (read_unwind_info): Update.
3863         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
3864         * dwarf2read.c (create_addrmap_from_index)
3865         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3866         (process_psymtab_comp_unit_reader, add_partial_symbol)
3867         (add_partial_subprogram, process_full_comp_unit)
3868         (read_file_scope, read_func_scope, read_lexical_block_scope)
3869         (read_call_site_scope, dwarf2_rnglists_process)
3870         (dwarf2_ranges_process, dwarf2_ranges_read)
3871         (dwarf_decode_lines_1, var_decode_location, new_symbol)
3872         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
3873         Update.
3874         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
3875         Update.
3876         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
3877         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
3878         (process_one_symbol): Change type of "section_offsets".
3879         * ctfread.c (get_objfile_text_range): Update.
3880         * coffread.c (coff_symtab_read, enter_linenos)
3881         (process_coff_symbol): Update.
3882         * coff-pe-read.c (add_pe_forwarded_sym): Update.
3883         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
3884
3885 2020-01-08  Tom Tromey  <tromey@adacore.com>
3886
3887         * dwarf2read.c (parse_macro_definition): Use std::string.
3888         (parse_macro_definition): Likewise.
3889
3890 2020-01-08  Tom Tromey  <tromey@adacore.com>
3891
3892         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
3893         (ATTR_ALLOC_CHUNK): Remove.
3894
3895 2020-01-08  Tom Tromey  <tromey@adacore.com>
3896
3897         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
3898
3899 2020-01-08  Tom Tromey  <tromey@adacore.com>
3900
3901         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
3902         (dwarf2_compute_name, open_dwo_file): Likewise.
3903         (process_enumeration_scope): Use std::vector.
3904         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
3905         (partial_die_info::fixup, dwarf2_start_subfile)
3906         (guess_full_die_structure_name, dwarf2_name): Likewise.
3907         (determine_prefix): Update.
3908         (guess_full_die_structure_name): Make return type const.
3909         (partial_die_full_name): Return unique_xmalloc_ptr.
3910         (DW_FIELD_ALLOC_CHUNK): Remove.
3911
3912 2020-01-07  Tom Tromey  <tromey@adacore.com>
3913
3914         PR build/24937:
3915         * stap-probe.c (class stap_static_probe_ops): Add constructor.
3916
3917 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3918
3919         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
3920
3921 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3922
3923         * stack.c (print_frame_info): Move disassemble_next_line code
3924         inside source_print block.
3925
3926 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3927
3928         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
3929         gdb/signals.h, as we are now using native signal symbols.
3930
3931 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3932
3933         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
3934         overflow by an early check of content vs threshold.
3935         * tui/tui-source.c (tui_source_window::line_is_displayed):
3936         Likewise.
3937
3938 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3939
3940         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
3941
3942 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3943
3944         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
3945         export table if no section contains it's RVA.
3946
3947 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3948
3949         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
3950
3951 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
3952
3953         * source.c (print_source_lines_base): Set last_line_listed.
3954
3955 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3956
3957         * tui/tui-disasm.c: Remove trailing spaces.
3958
3959 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3960             Pedro Alves  <palves@redhat.com>
3961
3962         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
3963         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
3964         (windows_gdb_signal_to_target): New function, uses the above
3965         enumeration to convert GDB internal signal codes to equivalent
3966         Windows codes.
3967         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
3968         * windows-nat.c: Include "gdb_wait.h".
3969         (get_windows_debug_event): Extract the fatal exception from the
3970         exit status and convert to the equivalent Posix signal number.
3971         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
3972         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
3973         * gdbsupport/gdb_wait.c: New file, implements
3974         windows_status_to_termsig.
3975         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
3976         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
3977
3978 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3979
3980         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
3981         show_layout.
3982
3983 2020-01-05  Luis Machado  <luis.machado@linaro.org>
3984
3985         * aarch64-linux-nat.c
3986         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
3987         and bfd_mach_aarch64.
3988
3989 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3990
3991         * ui-file.c (stdio_file::can_emit_style_escape)
3992         (tee_file::can_emit_style_escape): Ensure style is used also on
3993         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
3994         to gdb_stdout.
3995         * main.c (set_gdb_data_directory): Use file style to output the
3996         warning that the given pathname is not a directory.
3997         * top.c (show_history_filename, gdb_safe_append_history)
3998         (show_gdb_datadir): Use file style.
3999
4000 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4001
4002         * solib-target.c (struct lm_info_target):
4003         Change offsets to be a unique_xmalloc_ptr.
4004         (solib_target_relocate_section_addresses): Update.
4005
4006 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4007
4008         * windows-nat.c (windows_clear_solib): Free so_list linked list.
4009
4010 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4011
4012         * MAINTAINERS (Write After Approval): Add myself.
4013
4014 2020-01-02  Luis Machado  <luis.machado@linaro.org>
4015
4016         * proc-service.c (get_ps_regcache): Remove reference to obsolete
4017         Cell BE architecture.
4018         * target.h (struct target_ops) <thread_architecture>: Likewise.
4019
4020 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4021
4022         * Makefile.in: Use INSTALL_PROGRAM_ENV.
4023
4024 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4025
4026         * MAINTAINERS (Write After Approval): Add myself.
4027
4028 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4029
4030         * gdbarch.sh: Update copyright year range of generated files.
4031
4032 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4033
4034         Update copyright year range in all GDB files.
4035
4036 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4037
4038         * copyright.py: Convert to Python 3.
4039
4040 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4041
4042         * copyright.py: Adapt after move of gnulib directory from gdb
4043         directory to toplevel directory.
4044
4045 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4046
4047         * copyright.py (main): Exit if run from the wrong directory.
4048
4049 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4050
4051         * top.c (print_gdb_version): Change copyright year to 2020.
4052
4053 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4054
4055         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
4056
4057 For older changes see ChangeLog-2019.
4058 \f
4059 Local Variables:
4060 mode: change-log
4061 left-margin: 8
4062 fill-column: 74
4063 version-control: never
4064 coding: utf-8
4065 End: