gdb/ChangeLog

   1 2019-05-29  Tom Tromey  <tromey@adacore.com>
   2
   3         * NEWS: Add entry.
   4         * infcmd.c (print_return_value_1): Handle finish_print
   5         option.
   6         (show_print_finish): New function.
   7         (_initialize_infcmd): Add "set/show print finish" commands.
   8         * valprint.c (user_print_options): Initialize new member.
   9         * valprint.h (struct value_print_options) <finish_print>: New
  10         member.
  11
  12 2019-05-28  Tom Tromey  <tromey@adacore.com>
  13
  14         * ada-lang.c (ada_remove_Xbn_suffix)
  15         (find_old_style_renaming_symbol)
  16         (parse_old_style_renaming): Remove.
  17         (ada_find_renaming_symbol): Don't call
  18         find_old_style_renaming_symbol.
  19         (ada_is_renaming_symbol): Rename from
  20         ada_find_renaming_symbol.  Remove "block" parameter.  Return
  21         bool.  Now static.
  22         (ada_read_var_value): Update and simplify.
  23         * ada-exp.y (write_var_or_type): Remove old code.
  24
  25 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
  26
  27         * event-top.c: Remove include comment.
  28         * inflow.c (class scoped_ignore_sigttou): Move from here...
  29         * inflow.h (class scoped_ignore_sigttou): ...to here.
  30         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
  31         * top.c:  Remove include comment.
  32
  33 2019-05-27  Tom Tromey  <tom@tromey.com>
  34
  35         * NEWS: Fix typo.
  36
  37 2019-05-22  Tom Tromey  <tromey@adacore.com>
  38
  39         * target.c (target_follow_exec): Constify parameter.
  40         * target-delegates.c: Rebuild.
  41         * remote.c (remote_target::follow_exec): Constify parameter.
  42         * infrun.c (follow_exec): Constify parameter.
  43         * target.h (struct target_ops) <follow_exec>: Constify parameter.
  44         (target_follow_exec): Likewise.
  45
  46 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  47
  48         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
  49         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
  50
  51 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  52
  53         * NEWS: Add debugredirect and testsuite sections.
  54
  55 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
  56
  57         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
  58         target descriptions using exclusively floating point register name
  59         aliases.
  60
  61 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  62
  63         PR gdb/18644:
  64         * f-lang.c (build_fortran_types): Handle the case where
  65         gdbarch_floatformat_for_type returns a nullptr.
  66
  67 2019-05-21  Tom de Vries  <tdevries@suse.de>
  68
  69         PR cli/24587
  70         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
  71
  72 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  73
  74         PR gdb/18644:
  75         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
  76         16-byte floats.
  77         * i386-tdep.c (i386_floatformat_for_type): Use
  78         floatformats_ia64_quad for the 16-byte floating point component
  79         within a fortran 32-byte complex number.
  80
  81 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  82
  83         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
  84         delete default constructor.
  85         (find_partial_die): Update to return const struct.
  86         (partial_die_parent_scope): Move variable declaration into scope
  87         of its use and change its type to auto.
  88         (guess_partial_die_structure_name): Likewise.
  89         (partial_die_info::fixup): Likewise.
  90
  91 2019-05-17  Tom Tromey  <tromey@adacore.com>
  92
  93         * source.c (find_and_open_source): Remove cast.
  94
  95 2019-05-17  Tom Tromey  <tromey@adacore.com>
  96
  97         * annotate.c (annotate_source): Make "filename" const.
  98         * annotate.h (annotate_source): Use const.
  99
 100 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 101
 102         * disasm.c (set_disassembler_options): Send errors to stderr.
 103
 104 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 105
 106         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 107         (cli_interp_base::set_logging): Check debug_redirect.
 108         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 109         * cli/cli-logging.c (debug_redirect): Add static variable.
 110         (pop_output_files): Add default param.
 111         (handle_redirections): Print debug setting.
 112         (show_logging_command): Likewise.
 113         (_initialize_cli_logging): Add debugredirect command.
 114         * interps.c (current_interp_set_logging): Add debug_redirect
 115         parameter.
 116         * interps.h (set_logging): Add debug_redirect parameter.
 117         (current_interp_set_logging): Likewise.
 118         * mi/mi-common.h: Likewise.
 119         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 120
 121 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 122             Tom Tromey  <tromey@adacore.com>
 123
 124         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 125         directly.
 126         * cli/cli-interp.h (make_logging_output): Remove declaration.
 127         * cli/cli-logging.c (make_logging_output): Remove function.
 128         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 129         directly.
 130         * ui-file.c (tee_file::tee_file): Remove bools.
 131         (tee_file::~tee_file): Remove deletes.
 132         * ui-file.h (tee_file): Remove bools.
 133
 134 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 135
 136         * mi/mi-cmds.h (mi_cmd_complete): New function.
 137         * mi/mi-main.c (mi_cmd_complete): Likewise.
 138         * mi/mi-cmds.c: Define new MI command -complete.
 139         * NEWS: Mention new -complete command.
 140
 141 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 142
 143         * completer.h (complete): New function.
 144         * completer.c (complete): Likewise.
 145         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 146         function defined in completer.h.
 147
 148 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 149
 150        * MAINTAINERS (Write After Approval): Add myself.
 151
 152 2019-05-17  Tom de Vries  <tdevries@suse.de>
 153
 154         PR gdb/24094
 155         * dwarf2read.c (struct cu_partial_die_info): New struct.
 156         (find_partial_die): Return cu_partial_die_info.
 157         (partial_die_parent_scope, guess_partial_die_structure_name)
 158         (partial_die_info::fixup): Handle new return type of find_partial_die.
 159
 160 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 161
 162         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 163         "std::string", simplifying the algorithm.
 164
 165 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 166
 167         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 168         (stap_static_probe_ops::get_probes): Likewise.
 169
 170 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 171
 172         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 173         '-')" and "else if".
 174         (stap_parse_single_operand): Join checks for
 175         "gdbarch_stap_parse_special_token_p" and
 176         "gdbarch_stap_parse_special_token" in the same "if" statement.
 177         Invert check when verifying for operation on register
 178         displacement.
 179
 180 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 181
 182         * stap-probe.c (stap_get_opcode): Update comment.
 183         (stap_get_expected_argument_type): Likewise.
 184         (handle_stap_probe): Likewise.
 185
 186 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 187
 188         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 189         return type to 'bool'.  Adjust comment.  Use 'bool' when
 190         appropriate.
 191         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 192         * stap-probe.c (stap_parse_argument_1): Likewise.
 193         (stap_is_operator): Likewise.
 194         (stap_is_generic_prefix): Likewise.
 195         (stap_is_register_prefix): Likewise.
 196         (stap_is_register_indirection_prefix): Likewise.
 197         (stap_is_integer_prefix): Likewise.
 198         (stap_generic_check_suffix): Likewise.
 199         (stap_check_integer_suffix): Likewise.
 200         (stap_check_register_suffix): Likewise.
 201         (stap_check_register_indirection_suffix): Likewise.
 202         (stap_parse_register_operand): Likewise.
 203         (stap_parse_single_operand): Likewise.
 204         (stap_parse_argument_1): Likewise.
 205         (stap_probe::get_argument_count): Likewise.
 206         (stap_is_operator): Likewise.
 207
 208 2019-05-16  Tom Tromey  <tromey@adacore.com>
 209
 210         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 211         keyword to foreach.
 212
 213 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 214
 215         * linux-thread-db.c (try_thread_db_load_1): Change return type
 216         to bool.
 217         (try_thread_db_load): Likewise.
 218         (try_thread_db_load_from_pdir_1): Likewise.
 219         (try_thread_db_load_from_pdir): Likewise.
 220         (try_thread_db_load_from_sdir): Likewise.
 221         (try_thread_db_load_from_dir): Likewise.
 222         (thread_db_load_search): Likewise.
 223         (has_libpthread): Likewise.
 224         (thread_db_load): Likewise.
 225
 226 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 227
 228         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 229         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 230         NULL, and complain/return if that's the case.
 231
 232 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 233
 234         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 235         (advance, posn, abstract_read_memory): New functions.
 236         [struct mem_read_abstraction]: New struct.
 237         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 238
 239 2019-05-14  Tom Tromey  <tromey@adacore.com>
 240
 241         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 242         value is not lval_memory.
 243
 244 2019-05-14  Tom Tromey  <tromey@adacore.com>
 245
 246         * solib.c (info_sharedlibrary_command): Style the file name.
 247
 248 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 249
 250         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 251         (aarch64_vnv_type): Likewise.
 252         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 253         * common/tdesc.c: Likewise.
 254         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 255         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 256         * features/aarch64-fpu.xml: Add ieee half view.
 257         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 258         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 259         * gdbtypes.h (struct builtin_type): Likewise.
 260         (struct objfile_type): Likewise.
 261
 262 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 263
 264         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 265         typo.
 266         * location.h (string_to_event_location): Likewise.
 267
 268 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 269
 270         GDB 8.3 released.
 271
 272 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 273
 274         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 275         New variable declaration.
 276         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 277         New variable.
 278         (print_one_breakpoint): Use ui_out::test_flags and new global
 279         variable to compute use_fixed_output.
 280         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 281         Remove.
 282         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 283         (mi_multi_location_breakpoint_output_fixed): Remove.
 284         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 285         new variable.
 286         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 287         fix_multi_location_breakpoint_output flag if version >= 3.
 288         * ui-out.h (enum ui_out_flag)
 289         <fix_multi_location_breakpoint_output>: New enumerator.
 290
 291 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 292
 293         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 294
 295 2019-05-10  Tom Tromey  <tromey@adacore.com>
 296
 297         * ada-lang.c (catch_ada_completer): New function.
 298         (_initialize_ada_language): Use it.
 299
 300 2019-05-10  Tom Tromey  <tromey@adacore.com>
 301
 302         * thread.c (print_thread_info): Make "requested_threads" const.
 303         * gdbthread.h (print_thread_info): Make "requested_threads"
 304         const.
 305         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 306         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 307
 308 2019-05-08  Tom Tromey  <tom@tromey.com>
 309
 310         * gdbtypes.c (objfile_type_data): Change type.
 311         (objfile_type, _initialize_gdbtypes): Update.
 312
 313 2019-05-08  Tom Tromey  <tom@tromey.com>
 314
 315         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 316         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 317         (_initialize_dwarf2_frame): Update.
 318
 319 2019-05-08  Tom Tromey  <tom@tromey.com>
 320
 321         * objc-lang.c (objc_objfile_data): Change type.
 322         (find_methods): Update.
 323         (_initialize_objc_lang): Remove.
 324
 325 2019-05-08  Tom Tromey  <tom@tromey.com>
 326
 327         * stabsread.c (rs6000_builtin_type_data): Change type.
 328         (rs6000_builtin_type, _initialize_stabsread): Update.
 329
 330 2019-05-08  Tom Tromey  <tom@tromey.com>
 331
 332         * mips-tdep.c (mips_pdr_data): Remove.
 333         (_initialize_mips_tdep): Update.
 334
 335 2019-05-08  Tom Tromey  <tom@tromey.com>
 336
 337         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 338         (hppa_init_objfile_priv_data, read_unwind_info)
 339         (find_unwind_entry, _initialize_hppa_tdep): Update.
 340
 341 2019-05-08  Tom Tromey  <tom@tromey.com>
 342
 343         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 344         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 345         on obstack.
 346         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 347
 348 2019-05-08  Tom Tromey  <tom@tromey.com>
 349
 350         * mdebugread.c (basic_type_data): Change type.
 351         (basic_type, _initialize_mdebugread): Update.
 352
 353 2019-05-08  Tom Tromey  <tom@tromey.com>
 354
 355         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 356
 357 2019-05-08  Tom Tromey  <tom@tromey.com>
 358
 359         * nto-tdep.c (nto_inferior_data_reg): Change type.
 360         (nto_inferior_data): Update.
 361         (nto_inferior_data_cleanup, nto_new_inferior_data)
 362         (_initialize_nto_tdep): Remove.
 363         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 364
 365 2019-05-08  Tom Tromey  <tom@tromey.com>
 366
 367         * ada-lang.c (struct ada_inferior_data): Add initializers.
 368         (ada_inferior_data): Change type.
 369         (ada_inferior_data_cleanup): Remove.
 370         (get_ada_inferior_data, ada_inferior_exit)
 371         (struct ada_pspace_data): Add initializers, destructor.
 372         (ada_pspace_data_handle): Change type.
 373         (get_ada_pspace_data): Update.
 374         (ada_pspace_data_cleanup): Remove.
 375
 376 2019-05-08  Tom Tromey  <tom@tromey.com>
 377
 378         * coffread.c (struct coff_symfile_info): Add initializers.
 379         (coff_objfile_data_key): Move lower.  Change type.
 380         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 381         Update.
 382         (coff_free_info): Remove.
 383
 384 2019-05-08  Tom Tromey  <tom@tromey.com>
 385
 386         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 387         (fbsd_pspace_data_handle): Move lower.  Change type.
 388         (get_fbsd_pspace_data): Update.
 389         (fbsd_pspace_data_cleanup): Remove.
 390         (_initialize_fbsd_tdep): Update.
 391
 392 2019-05-08  Tom Tromey  <tom@tromey.com>
 393
 394         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 395         (get_ada_tasks_pspace_data): Update.
 396         (ada_tasks_pspace_data_cleanup): Remove.
 397         (_initialize_tasks): Update.
 398         (ada_tasks_inferior_data_handle): Change type.
 399         (get_ada_tasks_inferior_data): Update.
 400         (ada_tasks_inferior_data_cleanup): Remove.
 401         (struct ada_tasks_pspace_data): Add initializers.
 402
 403 2019-05-08  Tom Tromey  <tom@tromey.com>
 404
 405         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 406         * symfile-debug.c (debug_sym_get_probes): Change type.
 407         * stap-probe.c (handle_stap_probe):
 408         (stap_static_probe_ops::get_probes): Change type.
 409         * probe.h (class static_probe_ops) <get_probes>: Change type.
 410         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 411         (parse_probes_in_pspace): Update.
 412         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 413         Update.
 414         (any_static_probe_ops::get_probes): Change type.
 415         * elfread.c (elfread_data): New typedef.
 416         (probe_key): Change type.
 417         (elf_get_probes): Likewise.  Update.
 418         (probe_key_free): Remove.
 419         (_initialize_elfread): Update.
 420         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 421         Change type.
 422         (dtrace_process_dof_probe, dtrace_process_dof)
 423         (dtrace_static_probe_ops::get_probe): Change type.
 424
 425 2019-05-08  Tom Tromey  <tom@tromey.com>
 426
 427         * xcoffread.c (struct xcoff_symfile_info): Rename from
 428         coff_symfile_info.  Add initializers.
 429         (xcoff_objfile_data_key): Move lower.  Change type.
 430         (XCOFF_DATA): Rewrite.
 431         (xcoff_free_info): Remove.
 432         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 433         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 434         (xcoff_initial_scan): Update.
 435
 436 2019-05-08  Tom Tromey  <tom@tromey.com>
 437
 438         * solib-svr4.c (struct svr4_info): Add initializers and
 439         destructor.
 440         <probes_table>: Now an htab_up.
 441         (solib_svr4_pspace_data): Change type.
 442         (free_probes_table): Simplify.
 443         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 444         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 445         (probes_table_remove_objfile_probes, register_solib_event_probe)
 446         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 447         (_initialize_svr4_solib): Update.
 448
 449 2019-05-08  Tom Tromey  <tom@tromey.com>
 450
 451         * remote.c (remote_pspace_data): Change type.
 452         (remote_pspace_data_cleanup): Remove.
 453         (get_remote_exec_file, set_pspace_remote_exec_file)
 454         (_initialize_remote): Update.
 455
 456 2019-05-08  Tom Tromey  <tom@tromey.com>
 457
 458         * breakpoint.c (breakpoint_objfile_key): Change type.
 459         (get_breakpoint_objfile_data): Update.
 460         (free_breakpoint_objfile_data): Remove.
 461         (_initialize_breakpoint): Update.
 462
 463 2019-05-08  Tom Tromey  <tom@tromey.com>
 464
 465         * linux-tdep.c (struct linux_info): Add initializers.
 466         (linux_inferior_data): Move.  Change type.
 467         (invalidate_linux_cache_inf): Update.
 468         (linux_inferior_data_cleanup): Remove.
 469         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 470
 471 2019-05-08  Tom Tromey  <tom@tromey.com>
 472
 473         * auxv.c (auxv_inferior_data): Move.  Change type.
 474         (auxv_inferior_data_cleanup): Remove.
 475         (invalidate_auxv_cache_inf): Rewrite.
 476         (get_auxv_inferior_data, _initialize_auxv): Update.
 477
 478 2019-05-08  Tom Tromey  <tom@tromey.com>
 479
 480         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 481         (symfile_debug_objfile_data_key): Change type.
 482         (symfile_debug_installed, debug_qf_has_symbols)
 483         (debug_qf_find_last_source_symtab)
 484         (debug_qf_forget_cached_source_info)
 485         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 486         (debug_qf_print_stats, debug_qf_dump)
 487         (debug_qf_expand_symtabs_for_function)
 488         (debug_qf_expand_all_symtabs)
 489         (debug_qf_expand_symtabs_with_fullname)
 490         (debug_qf_map_matching_symbols)
 491         (debug_qf_expand_symtabs_matching)
 492         (debug_qf_find_pc_sect_compunit_symtab)
 493         (debug_qf_map_symbol_filenames)
 494         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 495         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 496         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 497         (debug_sym_read_linetable, debug_sym_relocate): Update.
 498         (symfile_debug_free_objfile): Remove.
 499         (install_symfile_debug_logging, _initialize_symfile_debug):
 500         Update.
 501
 502 2019-05-08  Tom Tromey  <tom@tromey.com>
 503
 504         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 505         allocate_on_obstack.
 506         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 507         (get_dwarf2_per_objfile): Update.
 508         (set_dwarf2_per_objfile): Remove.
 509         (dwarf2_has_info, dwarf2_get_section_info): Update.
 510         (dwarf2_free_objfile): Remove.
 511         (_initialize_dwarf2_read): Update.
 512
 513 2019-05-08  Tom Tromey  <tom@tromey.com>
 514
 515         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 516         initializers.
 517         <unsupported_script_warning_printed,
 518         script_not_found_warning_printed>: Now bool.
 519         (auto_load_pspace_data): Change type.
 520         (~auto_load_pspace_info): Rename from
 521         auto_load_pspace_data_cleanup.
 522         (get_auto_load_pspace_data, init_loaded_scripts_info)
 523         (clear_section_scripts, maybe_print_unsupported_script_warning)
 524         (maybe_print_script_not_found_warning, _initialize_auto_load):
 525         Update.
 526
 527 2019-05-08  Tom Tromey  <tom@tromey.com>
 528
 529         * objfiles.c (objfile_pspace_info): Add destructor and
 530         initializers.
 531         (objfiles_pspace_data): Change type.
 532         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 533         (get_objfile_pspace_data): Update.
 534         (objfiles_bfd_data): Change type.
 535         (get_objfile_bfd_data): Update.
 536         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 537
 538 2019-05-08  Tom Tromey  <tom@tromey.com>
 539
 540         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 541         Change type.
 542         (get_catch_syscall_inferior_data): Update.
 543         (catch_syscall_inferior_data_cleanup): Remove.
 544         (_initialize_break_catch_syscall): Update.
 545
 546 2019-05-08  Tom Tromey  <tom@tromey.com>
 547
 548         * inflow.c (struct terminal_info): Add destructor and
 549         initializers.
 550         (inflow_inferior_data): Change type.
 551         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 552         (get_inflow_inferior_data, inflow_inferior_exit)
 553         (swap_terminal_info, _initialize_inflow): Update.
 554
 555 2019-05-08  Tom Tromey  <tom@tromey.com>
 556
 557         * target-dcache.c (target_dcache_cleanup): Remove.
 558         (target_dcache_aspace_key): Change type.
 559         (target_dcache_init_p, target_dcache_invalidate)
 560         (target_dcache_get, target_dcache_get_or_init)
 561         (_initialize_target_dcache): Update.
 562         * dcache.h (struct dcache_deleter): New.
 563
 564 2019-05-08  Tom Tromey  <tom@tromey.com>
 565
 566         * symtab.c (struct symbol_cache): Add destructor and
 567         initializers.
 568         (symbol_cache_key): Move.  Change type.
 569         (make_symbol_cache, free_symbol_cache): Remove.
 570         (get_symbol_cache): Update.
 571         (symbol_cache_cleanup): Remove.
 572         (ALL_PSPACES, symbol_cache_flush)
 573         (maintenance_print_symbol_cache)
 574         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 575         Update.
 576
 577 2019-05-08  Tom Tromey  <tom@tromey.com>
 578
 579         * symtab.c (struct main_info): Add destructor and initializers.
 580         (main_progspace_key): Move.  Change type.
 581         (get_main_info): Update.
 582         (main_info_cleanup): Remove.
 583         (_initialize_symtab): Update.
 584
 585 2019-05-08  Tom Tromey  <tom@tromey.com>
 586
 587         * registry.h (DECLARE_REGISTRY): Define the _key class.
 588
 589 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 590
 591         * NEWS: Merge two 'New commands' sections.
 592
 593 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 594
 595         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 596         parameter and use Ada language definition instead.
 597         (ada_val_print_ptr): Remove unused language parameter.
 598         (ada_val_print_num): Remove language parameter and use Ada language
 599         definition instead.
 600         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 601         parameter.
 602         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 603         parameter and use Ada language definition instead.
 604         (ada_val_print_1): Update all ada_val_print_xxx calls.
 605         Remove language parameter.
 606         (ada_val_print): Update ada_val_print_1 call.
 607
 608 2019-05-08  Tom Tromey  <tromey@adacore.com>
 609
 610         * remote.c (remote_hw_watchpoint_limit)
 611         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 612         Now static.
 613
 614 2019-05-08  Tom Tromey  <tromey@adacore.com>
 615
 616         * maint.c (_initialize_maint_cmds): Move initialization code to
 617         remote.c.
 618         (watchdog, show_watchdog): Move to remote.c.
 619         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 620         "watchdog" static.
 621         (_initialize_remote): Move initialization code from maint.c.
 622         * defs.h (watchdog): Don't declare.
 623
 624 2019-05-08  Tom Tromey  <tromey@adacore.com>
 625
 626         * tui/tui-interp.c: Include main.h.
 627         * interps.c: Include main.h.
 628         * main.h (interpreter_p): Declare.
 629         * defs.h (interpreter_p): Don't declare.
 630
 631 2019-05-08  Tom Tromey  <tromey@adacore.com>
 632
 633         * dwarf2loc.c: Include dwarf2read.h.
 634         * defs.h (read_unsigned_leb128): Don't declare.
 635         * dwarf2read.h (read_unsigned_leb128): Declare.
 636
 637 2019-05-08  Tom Tromey  <tromey@adacore.com>
 638
 639         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 640         method.
 641
 642 2019-05-08  Tom Tromey  <tromey@adacore.com>
 643
 644         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 645         when no wrap column is set.
 646
 647 2019-05-08  Tom Tromey  <tromey@adacore.com>
 648
 649         * c-lang.c (c_get_string): Handle non-C-style arrays.
 650
 651 2019-05-08  Tom Tromey  <tromey@adacore.com>
 652
 653         * typeprint.c (print_offset_data::update): Print the bit offset,
 654         not the number of bits remaining.
 655
 656 2019-05-08  Tom Tromey  <tromey@adacore.com>
 657
 658         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 659         padding at end of comment.
 660
 661 2019-05-08  Tom Tromey  <tromey@adacore.com>
 662
 663         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 664         Compare main types.
 665
 666 2019-05-06  Tom Tromey  <tom@tromey.com>
 667
 668         * common/scoped_mmap.c: Include common-defs.h.
 669         * common/scoped_mmap.h: Don't include config.h.
 670
 671 2019-05-04  Tom Tromey  <tom@tromey.com>
 672
 673         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 674         (struct aarch64_call_info): Add initializers.
 675         <si>: Now a std::vector.
 676         (pass_on_stack, aarch64_push_dummy_call): Update.
 677
 678 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 679             Tom Tromey  <tom@tromey.com>
 680
 681         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 682         (ppc_threads): Now a std::vector.  Now static.
 683         (hwdebug_find_thread_points_by_tid)
 684         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 685         Update.
 686
 687 2019-05-04  Tom Tromey  <tom@tromey.com>
 688
 689         * arc-tdep.c (arc_tdesc_init): Return bool.
 690
 691 2019-05-04  Tom Tromey  <tom@tromey.com>
 692
 693         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 694         Use gdb_assert_not_reached.
 695
 696 2019-05-04  Tom Tromey  <tom@tromey.com>
 697
 698         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 699         "false".
 700
 701 2019-05-04  Tom Tromey  <tom@tromey.com>
 702
 703         * arc-tdep.c (arc_tdesc_init): Use bool.
 704
 705 2019-05-04  Tom Tromey  <tom@tromey.com>
 706
 707         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 708
 709 2019-05-04  Tom Tromey  <tom@tromey.com>
 710
 711         * cli/cli-cmds.c (valid_command_p): Return bool.
 712
 713 2019-05-04  Tom Tromey  <tom@tromey.com>
 714
 715         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 716         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 717
 718 2019-05-04  Raul Tambre  <raul@tambre.ee>
 719
 720         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 721         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 722         operator for comparison.
 723
 724 2019-05-04  Tom Tromey  <tom@tromey.com>
 725
 726         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 727         (lookup_partial_symbol, print_partial_symbols)
 728         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 729         (psymbol_compare): Update.
 730         (add_psymbol_to_bcache): Clear the entire psymbol.
 731         (maintenance_check_psymtabs): Update.
 732         * psympriv.h (struct partial_symbol): Don't derive from
 733         general_symbol_info.
 734         <obj_section, unrelocated_address, address,
 735         set_unrelocated_address>: Update.
 736         <ginfo>: New member.
 737         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 738         (debug_names::write_psymbols): Update.
 739
 740 2019-05-04  Tom de Vries  <tdevries@suse.de>
 741
 742         * contrib/cc-with-tweaks.sh: Support -n arg.
 743
 744 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 745
 746         * corelow.c (core_target::detach): Ensure frame cache and
 747         register caches are cleared.
 748         inferior.c (exit_inferior_1): Likewise.
 749
 750 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 751             Tom Tromey  <tom@tromey.com>
 752
 753         * dictionary.c (collate_pending_symbols_by_language): Remove
 754         "struct" from foreach.
 755         * symtab.c (lookup_global_symbol_from_objfile)
 756         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 757         foreach.
 758         * ser-tcp.c (net_open): Remove "struct" from foreach.
 759         * objfiles.c (objfile_relocate, objfile_rebase)
 760         (objfile_has_symbols): Remove "struct" from foreach.
 761         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 762         from foreach.
 763         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 764         foreach.
 765         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 766         "struct" from foreach.
 767         * ada-lang.c (create_excep_cond_exprs)
 768         (ada_exception_catchpoint_cond_string): Remove "struct" from
 769         foreach.
 770
 771 2019-05-03  Tom Tromey  <tromey@adacore.com>
 772
 773         * ada-exp.y (convert_char_literal): Check suffix of each
 774         enumerator.
 775
 776 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 777
 778         PR ada/21406:
 779         * ada-exp.y (yywrap): Don't define.
 780         * ada-lex.l (%option): Add noyywrap
 781         (yywrap): Remove.
 782
 783 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 784
 785         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 786         _WIN32_WINNT to the XP level, unless already defined to a higher
 787         level.
 788
 789         * unittests/parse-connection-spec-selftests.c:
 790         * ser-tcp.c:
 791         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 792         override.
 793
 794         * symfile.c (find_separate_debug_file): Remove colon from the
 795         drive spec of DOS/Windows file names of the target, so that the
 796         file name produced from DEBUGDIR and the target's directory will
 797         be valid on DOS/Windows systems.
 798
 799 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 800
 801         * rust-lang.c (val_print_struct): Handle printing structures
 802         containing strings.
 803
 804 2019-05-02  Tom Tromey  <tromey@adacore.com>
 805
 806         * valarith.c (_initialize_valarith): Remove.
 807
 808 2019-05-01  Tom Tromey  <tromey@adacore.com>
 809
 810         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 811         bitfields.
 812
 813 2019-05-01  Tom Tromey  <tromey@adacore.com>
 814
 815         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 816         for big-endian copies.
 817
 818 2019-04-30  Ali Tamur  <tamur@google.com>
 819         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 820         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 821         (read_3_bytes): New function.
 822
 823 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 824
 825         * windows-nat.c (main_thread_id): Delete.
 826         (handle_output_debug_string): Replace main_thread_id by
 827         current_event.dwThreadId.
 828         (fake_create_process): Likewise.
 829         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 830         Do not set main_thread_id.
 831         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 832         current_event.dwThreadId.
 833         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 834
 835 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 836
 837         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 838         Use current_event.dwThreadId instead of main_thread_id.
 839
 840 2019-04-30  Tom Tromey  <tromey@adacore.com>
 841
 842         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 843         (create_excep_cond_exprs): Iterate over program spaces.
 844         (ada_exception_catchpoint_cond_string): Examine all minimal
 845         symbols for exception types.
 846
 847 2019-04-30  Tom Tromey  <tromey@adacore.com>
 848
 849         PR c++/24470:
 850         * dwarf2read.c (process_structure_scope): Handle case where type
 851         has template parameters but no symbol was created.
 852
 853 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 854             Chris January  <chris.january@arm.com>
 855
 856         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 857         qualifier.
 858         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 859
 860 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 861
 862         * f-typeprint.c (f_print_type): Update rules for printing
 863         whitespace.
 864         (f_type_print_varspec_suffix): Likewise.
 865
 866 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 867             Chris January  <chris.january@arm.com>
 868
 869         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 870         function arguments.
 871
 872 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         * f-lang.c (build_fortran_types): Change name of void type to
 875         lower case.
 876         * f-typeprint.c (f_type_print_base): Print the name of the void
 877         type, rather than a fixed string.
 878         * f-valprint.c (f_decorations): Use lower case void string.
 879
 880 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 881             Chris January  <chris.january@arm.com>
 882
 883         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 884         types for Fortran.
 885
 886 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 887             Chris January  <chris.january@arm.com>
 888             David Lecomber  <david.lecomber@arm.com>
 889
 890         * f-exp.y (BINOP_INTRINSIC): New token.
 891         (exp): New parser rule handling BINOP_INTRINSIC.
 892         (f77_keywords): Add new builtin procedures.
 893         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 894         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 895         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 896         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 897         (print_unop_subexp_f): New function.
 898         (print_binop_subexp_f): New function.
 899         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 900         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 901         (dump_subexp_body_f): Likewise.
 902         (operator_check_f): Likewise.
 903         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 904         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 905
 906 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 907
 908         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 909         UNOP_KIND.
 910         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 911         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 912         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 913         (operator_length_f): New fuction.
 914         (print_subexp_f): New function.
 915         (op_name_f): New function.
 916         (dump_subexp_body_f): New function.
 917         (operator_check_f): New function.
 918         (exp_descriptor_f): Replace standard expression handling functions
 919         with new functions.
 920         * gdb/fortran-operator.def: New file.
 921         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 922         * gdb/std-operator.def: Remove UNOP_KIND.
 923
 924 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * std-operator.def: Remove unbalanced, stray double quote
 927         character.
 928
 929 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 930             Chris January  <chris.january@arm.com>
 931             Daniel Everett  <daniel.everett@arm.com>
 932             Nick Forrington  <nick.forrington@arm.com>
 933             Richard Bunt  <richard.bunt@arm.com>
 934
 935         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 936         of depth when printing anonymous structs or unions.
 937         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 938         Don't print either the top-level value, or the children if the
 939         max-depth is exceeded.
 940         (ppscm_print_children): When printing the key of a map, allow one
 941         extra level of depth.
 942         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 943         print either the top-level value, or the children if the max-depth
 944         is exceeded.
 945         (print_children): When printing the key of a map, allow one extra
 946         level of depth.
 947         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 948         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 949         (user_print_options): Initialise max_depth field.
 950         (val_print_scalar_or_string_type_p): New function.
 951         (val_print): Check to see if the max depth has been reached.
 952         (val_print_check_max_depth): Define new function.
 953         (show_print_max_depth): New function.
 954         (_initialize_valprint): Add 'print max-depth' option.
 955         * valprint.h (struct value_print_options) <max_depth>: New field.
 956         (val_print_check_max_depth): Declare new function.
 957         * NEWS: Document new feature.
 958
 959 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 960
 961         * ada-lang.c (ada_language_defn): Initialise new field.
 962         * c-lang.c (c_is_string_type_p): New function.
 963         (c_language_defn): Initialise new field.
 964         (cplus_language_defn): Initialise new field.
 965         (asm_language_defn): Initialise new field.
 966         (minimal_language_defn): Initialise new field.
 967         * c-lang.h (c_is_string_type_p): Declare new function.
 968         * d-lang.c (d_language_defn): Initialise new field.
 969         * f-lang.c (f_is_string_type_p): New function.
 970         (f_language_defn): Initialise new field.
 971         * go-lang.c (go_is_string_type_p): New function.
 972         (go_language_defn): Initialise new field.
 973         * language.c (default_is_string_type_p): New function.
 974         (unknown_language_defn): Initialise new field.
 975         (auto_language_defn): Initialise new field.
 976         * language.h (struct language_defn) <la_is_string_type_p>: New
 977         member variable.
 978         (default_is_string_type_p): Declare new function.
 979         * m2-lang.c (m2_language_defn): Initialise new field.
 980         * objc-lang.c (objc_language_defn): Initialise new field.
 981         * opencl-lang.c (opencl_language_defn): Initialise new field.
 982         * p-lang.c (pascal_is_string_type_p): New function.
 983         (pascal_language_defn): Initialise new field.
 984         * rust-lang.c (rust_is_string_type_p): New function.
 985         (rust_language_defn): Initialise new field.
 986
 987 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 988
 989         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 990         New field.
 991         * ada-lang.c (ada_language_defn): Initialise new field.
 992         * c-lang.c (c_language_defn): Likewise.
 993         (cplus_language_defn): Likewise.
 994         (asm_language_defn): Likewise.
 995         (minimal_language_defn): Likewise.
 996         * d-lang.c (d_language_defn): Likewise.
 997         * f-lang.c (f_language_defn): Likewise.
 998         * go-lang.c (go_language_defn): Likewise.
 999         * language.c (unknown_language_defn): Likewise.
1000         (auto_language_defn): Likewise.
1001         * m2-lang.c (m2_language_defn): Likewise.
1002         * objc-lang.c (objc_language_defn): Likewise.
1003         * opencl-lang.c (opencl_language_defn): Likewise.
1004         * p-lang.c (pascal_language_defn): Likewise.
1005         * rust-lang.c (rust_language_defn): Likewise.
1006
1007 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * ada-lang.c (ada_is_character_type): Change return type to bool.
1010         (ada_is_string_type): Likewise.
1011         * ada-lang.h (ada_is_character_type): Update declaration
1012         (ada_is_string_type): Likewise.
1013
1014 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1015
1016         Support style in 'frame|thread apply'
1017
1018         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1019         * record.c (record_start, record_stop): Update callers of
1020         execute_command_to_string with false.
1021         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1022         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1023         methods.
1024         (class string_file): New constructor with term_out parameter.
1025         Override methods term_out and can_emit_style_escape.  New member
1026         term_out.
1027         (class stdio_file): Override can_emit_style_escape.
1028         (class tee_file): Override term_out and can_emit_style_escape.
1029         * utils.h (can_emit_style_escape): Remove.
1030         * utils.c (can_emit_style_escape): Likewise.
1031         Update all callers of can_emit_style_escape (SOMESTREAM) to
1032         SOMESTREAM->can_emit_style_escape.
1033         * source-cache.c (source_cache::get_source_lines): Likewise.
1034         * stack.c (frame_apply_command_count): Call execute_command_to_string
1035         passing the term_out characteristic of the current gdb_stdout.
1036         * thread.c (thr_try_catch_cmd): Likewise.
1037         * top.c (execute_command_to_string): pass term_out parameter
1038         to construct the string_file for the command output.
1039         * ui-file.c (term_cli_styling): New function (most code moved
1040         from utils.c can_emit_style_escape).
1041         (string_file::string_file, string_file::can_emit_style_escape,
1042         stdio_file::can_emit_style_escape, tee_file::term_out,
1043         tee_file::can_emit_style_escape): New functions.
1044
1045 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1046
1047         * NEWS: Mention the new set|show may-call-functions.
1048         * infcall.c (may_call_functions_p): New variable.
1049         (show_may_call_functions_p): New function.
1050         (call_function_by_hand_dummy): Throws an error if not
1051         may-call-functions.
1052         (_initialize_infcall): Call add_setshow_boolean_cmd for
1053         may-call-functions.
1054
1055 2019-04-25  Keith Seitz  <keiths@redhat.com>
1056
1057         PR c++/24367
1058         * cp-support.c (inspect_type): Don't attempt substitutions
1059         of symbol with the same name.
1060
1061 2019-04-25  Tom Tromey  <tromey@adacore.com>
1062
1063         PR gdb/24475:
1064         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1065         static.
1066
1067 2019-04-25  Tom Tromey  <tromey@adacore.com>
1068
1069         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1070         rvalue reference.
1071         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1072         (gdb_xml_parser::parse): Use std::move.
1073         * python/python-internal.h (gdbpy_convert_exception): Take a const
1074         reference.
1075         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1076         std::move.
1077         * python/py-utils.c (gdbpy_convert_exception): Take a const
1078         reference.
1079         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1080         Use std::move.
1081         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1082         Use std::move.
1083         * mi/mi-main.c (mi_print_exception): Take a const reference.
1084         * main.c (handle_command_errors): Take a const reference.
1085         * linespec.c (parse_linespec): Use std::move.
1086         * infcall.c (run_inferior_call): Use std::move.
1087         (call_function_by_hand_dummy): Use std::move.
1088         * exec.c (try_open_exec_file): Use std::move.
1089         * exceptions.h (exception_print, exception_fprintf)
1090         (exception_print_same): Update.
1091         * exceptions.c (print_exception, exception_print)
1092         (exception_fprintf, exception_print_same): Change parameters to
1093         const reference.
1094         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1095         * common/new-op.c: Use std::move.
1096         * common/common-exceptions.h (struct gdb_exception): Add move
1097         constructor.
1098         (struct gdb_exception_error, struct gdb_exception_quit, struct
1099         gdb_quit_bad_alloc): Change constructor to move constructor.
1100         (throw_exception): Change parameter to rvalue reference.
1101         * common/common-exceptions.c (throw_exception): Take rvalue
1102         reference.
1103         * cli/cli-interp.c (safe_execute_command): Use std::move.
1104         * breakpoint.c (insert_bp_location, location_to_sals): Use
1105         std::move.
1106
1107 2019-04-25  Tom Tromey  <tromey@adacore.com>
1108
1109         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1110         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1111         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1112         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1113         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1114         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1115         guile/scm-value.c: Use unpack.
1116         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1117         gdbscm_gdb_exception.
1118         (gdbscm_throw_gdb_exception): Likewise.
1119         (struct gdbscm_gdb_exception): New.
1120         (unpack): New function.
1121         (gdbscm_wrap): Use unpack.
1122
1123 2019-04-25  Tom Tromey  <tromey@adacore.com>
1124
1125         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1126         (gdb_rl_callback_handler): Use std::move.
1127         * common/common-exceptions.h (struct gdb_exception): Add move
1128         assignment operator.
1129         (throw_exception_sjlj): Change "exception" to const reference.
1130         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1131         (throw_exception_sjlj): Change "exception" to const reference.
1132
1133 2019-04-25  Tom Tromey  <tromey@adacore.com>
1134
1135         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1136         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1137         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1138         Update.
1139         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1140         Update.
1141         * mi/mi-interp.c (mi_interp::exec): Update.
1142         * linespec.c (parse_linespec): Update.
1143         * infcall.c (run_inferior_call): Update.
1144         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1145         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1146         (gdbscm_lookup_global_symbol): Update.
1147         * guile/scm-param.c (gdbscm_parameter_value): Update.
1148         * guile/scm-frame.c (gdbscm_frame_read_register)
1149         (gdbscm_frame_read_var): Update.
1150         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1151         * exec.c (try_open_exec_file): Update.
1152         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1153         (gdb_rl_callback_handler): Update.
1154         * common/common-exceptions.h (exception_none): Don't declare.
1155         * common/common-exceptions.c (exception_none): Don't define.
1156         (struct catcher) <exception>: Update.
1157         * cli/cli-interp.c (safe_execute_command): Update.
1158         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1159
1160 2019-04-25  Ali Tamur  <tamur@google.com>
1161
1162         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1163         (read_attribute_value): Likewise.
1164         (dwarf2_read_addr_index): Update comment.
1165         (read_str_index): Add DW_FORM_strx.
1166         (dwarf2_string_attr): Likewise.
1167         (dwarf2_const_value_attr): Likewise.
1168         (dump_die_shallow): Likewise.
1169         (dwarf2_fetch_constant_bytes): Likewise.
1170         (skip_form_bytes): Likewise.
1171         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1172
1173 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1174
1175         PR corefiles/11608
1176         PR corefiles/18187
1177         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1178         OFFSET.  Verify if current mapping contains an ELF header.
1179         (linux_find_memory_regions_full): Adjust call to
1180         dump_mapping_p.
1181
1182 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1183             Kang Li <kanglictf@gmail.com>
1184
1185         PR gdb/21600
1186
1187         * dwarf2-frame.c (read_initial_length): Be consistent about using
1188         unsigned representation of length.
1189         (decode_frame_entry_1): Likewise.  Check for wraparound of
1190         end pointer as well as buffer overflow.
1191
1192 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1193
1194         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1195         "vq".
1196
1197 2019-04-24  Tom Tromey  <tromey@adacore.com>
1198
1199         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1200
1201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         * s12z-tdep.c (s12z_unwind_pc): Delete.
1204         (s12z_unwind_sp): Delete.
1205         (s12z_gdbarch_init): Don't register deleted functions with
1206         gdbarch.
1207
1208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * rl78-tdep.c (rl78_unwind_sp): Delete.
1211         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1212
1213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1216         (xstormy16_unwind_pc): Delete.
1217         (xstormy16_dummy_id): Delete.
1218         (xstormy16_gdbarch_init): Don't register deleted functions with
1219         gdbarch.
1220
1221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1222
1223         * vax-tdep.c (vax_unwind_pc): Delete.
1224         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1225
1226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * v850-tdep.c (v850_unwind_sp): Delete.
1229         (v850_unwind_pc): Delete.
1230         (v850_dummy_id): Delete.
1231         (v850_gdbarch_init): Don't register deleted functions with
1232         gdbarch.
1233
1234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1237         (tilegx_unwind_pc): Delete.
1238         (tilegx_unwind_dummy_id): Delete.
1239         (tilegx_gdbarch_init): Don't register deleted functions with
1240         gdbarch.
1241
1242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1245         (tic6x_dummy_id): Delete.
1246         (tic6x_gdbarch_init): Don't register deleted functions with
1247         gdbarch.
1248
1249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1250
1251         * sparc-tdep.c (sparc_unwind_pc): Delete.
1252         (sparc32_gdbarch_init): Don't register deleted function with
1253         gdbarch.
1254
1255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * sh-tdep.c (sh_unwind_sp): Delete.
1258         (sh_unwind_pc): Delete.
1259         (sh_dummy_id): Delete.
1260         (sh_gdbarch_init): Don't register deleted functions with
1261         gdbarch.
1262
1263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1264
1265         * score-tdep.c (score_unwind_sp): Delete.
1266         (score_unwind_pc): Delete.
1267         (score_dummy_id): Delete.
1268         (score_gdbarch_init): Don't register deleted functions with
1269         gdbarch.
1270
1271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * rx-tdep.c (rx_unwind_pc): Delete.
1274         (rx_unwind_sp): Delete.
1275         (rx_dummy_id): Delete.
1276         (rx_gdbarch_init): Don't register deleted functions with
1277         gdbarch.  Update comment.
1278
1279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1280
1281         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1282         (rs6000_dummy_id): Delete.
1283         (rs6000_gdbarch_init): Don't register deleted functions with
1284         gdbarch.
1285
1286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * or1k-tdep.c (or1k_dummy_id): Delete.
1289         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1290
1291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1292
1293         * nios2-tdep.c (nios2_dummy_id): Delete.
1294         (nios2_unwind_sp): Delete.
1295         (nios2_gdbarch_init): Don't register deleted functions with
1296         gdbarch.
1297
1298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1299
1300         * nds32-tdep.c (nds32_dummy_id): Delete.
1301         (nds32_unwind_pc): Delete.
1302         (nds32_unwind_sp): Delete.
1303         (nds32_gdbarch_init): Don't register deleted functions with
1304         gdbarch.
1305
1306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1307
1308         * msp430-tdep.c (msp430_unwind_pc): Delete.
1309         (msp430_unwind_sp): Delete.
1310         (msp430_dummy_id): Delete.
1311         (msp430_gdbarch_init): Don't register deleted functions with
1312         gdbarch.
1313
1314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1315
1316         * moxie-tdep.c (moxie_unwind_sp): Delete.
1317         (moxie_unwind_pc): Delete.
1318         (moxie_dummy_id): Delete.
1319         (moxie_gdbarch_init): Don't register deleted functions with
1320         gdbarch.
1321
1322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1325         (mn10300_unwind_pc): Delete.
1326         (mn10300_unwind_sp): Delete.
1327         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1328         mn10300_unwind_sp.
1329         (mn10300_frame_unwind_init): Don't register deleted functions with
1330         gdbarch.
1331
1332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1333
1334         * mep-tdep.c (mep_unwind_pc): Delete.
1335         (mep_unwind_sp): Delete.
1336         (mep_dummy_id): Delete.
1337         (mep_gdbarch_init): Don't register deleted functions with
1338         gdbarch.
1339
1340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1341
1342         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1343         (m68hc11_unwind_sp): Delete.
1344         (m68hc11_gdbarch_init): Don't register deleted functions with
1345         gdbarch.
1346
1347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * m32r-tdep.c (m32r_unwind_sp): Delete.
1350         (m32r_unwind_pc): Delete.
1351         (m32r_dummy_id): Delete.
1352         (m32r_gdbarch_init): Don't register deleted functions with
1353         gdbarch.
1354
1355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1356
1357         * m32c-tdep.c (m32c_unwind_pc): Delete.
1358         (m32c_unwind_sp): Delete.
1359         (m32c_dummy_id): Delete.
1360         (m32c_gdbarch_init): Don't register deleted functions with
1361         gdbarch.
1362
1363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1366         (lm32_unwind_pc): Delete.
1367         (lm32_dummy_id): Delete.
1368         (lm32_gdbarch_init): Don't register deleted functions with
1369         gdbarch.
1370
1371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1374         (iq2000_unwind_pc): Delete.
1375         (iq2000_dummy_id): Delete.
1376         (iq2000_gdbarch_init): Don't register deleted functions with
1377         gdbarch.
1378
1379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1380
1381         * nds32-tdep.c (nds32_type_align): Delete.
1382         (nds32_push_dummy_call): Use type_align instead.
1383
1384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1385
1386         * arm-tdep.c (arm_type_align): Only handle vector override case.
1387         (arm_push_dummy_call): Use type_align.
1388         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1389
1390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1391
1392         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1393         case.
1394         (pass_on_stack): Use type_align.
1395         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1396         function.
1397
1398 2019-04-23  Tom Tromey  <tromey@adacore.com>
1399
1400         * dwarf2read.c (line_header::file_name_at): Remove unused
1401         overload.
1402
1403 2019-04-23  Tom de Vries  <tdevries@suse.de>
1404
1405         PR gdb/24438
1406         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1407         invocation.
1408
1409
1410 2019-03-27  Ali Tamur  <tamur@google.com>
1411
1412         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1413         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1414         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1415         (dwarf_expr_context::get_addr_index): Likewise
1416         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1417         (symbol_needs_eval_context::get_addr_index): Likewise
1418         (disassemble_dwarf_expression): Add DW_OP_addrx
1419         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1420         (read_cutu_die_from_dwo): Update comment
1421         (skip_one_die): Add DW_FORM_addrx
1422         (read_attribute_value): Likewise
1423         (var_decode_location): Add DW_OP_addrx
1424         (dwarf2_const_value_attr): Add DW_FORM_addrx
1425         (dump_die_shallow): Likewise
1426         (dwarf2_fetch_constant_bytes): Likewise
1427         (decode_locdesc): Add DW_OP_addrx
1428         (skip_form_bytes): Add DW_FORM_addrx
1429
1430 2019-04-22  Ali Tamur  <tamur@google.com>
1431
1432         * MAINTAINERS (Write After Approval): Add self.
1433
1434 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1435
1436         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1437         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1438         (open_symbol_file_object): Likewise.
1439         (svr4_default_sos): Add info parameter.
1440         (svr4_read_so_list): Likewise.
1441         (svr4_current_sos_direct): Adjust functions calls to pass down
1442         info.
1443         (svr4_current_sos_1): Add info parameter.
1444         (svr4_current_sos): Call get_svr4_info, pass info down to
1445         svr4_current_sos_1.
1446         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1447         get_svr4_info.
1448         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1449         get_svr4_info.
1450         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1451         to get_svr4_info.
1452         (probes_table_remove_objfile_probes): Likewise.
1453         (register_solib_event_probe): Add info parameter.
1454         (solist_update_incremental): Pass info parameter down to
1455         svr4_read_so_list.
1456         (disable_probes_interface): Add info parameter.
1457         (svr4_handle_solib_event): Pass current_program_space to
1458         get_svr4_info.  Adjust disable_probes_interface cleanup.
1459         (svr4_create_probe_breakpoints): Add info parameter, pass it
1460         down to register_solib_event_probe.
1461         (svr4_create_solib_event_breakpoints): Add info parameter,
1462         pass it down to svr4_create_probe_breakpoints.
1463         (enable_break): Pass info down to
1464         svr4_create_solib_event_breakpoints.
1465         (svr4_solib_create_inferior_hook): Pass current_program_space to
1466         get_svr4_info.
1467         (svr4_clear_solib): Likewise.
1468
1469 2019-04-22  Pedro Alves  <palves@redhat.com>
1470
1471         * solib-svr4.c (svr4_free_objfile_observer): New.
1472         (probe_and_action::objfile): New field.
1473         (probes_table_htab_remove_objfile_probes)
1474         (probes_table_remove_objfile_probes): New functions.
1475         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1476         in the new probe_and_action.  Don't store the probe in 'lookup'.
1477         (svr4_create_probe_breakpoints): Pass objfile to
1478         register_solib_event_probe.
1479         (_initialize_svr4_solib): Register a free_objfile observer.
1480
1481 2019-04-19  Tom Tromey  <tom@tromey.com>
1482
1483         * common/queue.h: Remove.
1484
1485 2019-04-19  Tom Tromey  <tom@tromey.com>
1486
1487         * event-loop.c: Don't include "common/queue.h".
1488
1489 2019-04-19  Tom Tromey  <tom@tromey.com>
1490
1491         * remote.c (remote_target): Use delete.
1492         * remote-notif.h: Include <list>, not "common/queue.h".
1493         (notif_client_p): Remove typedef.
1494         (remote_notif_state): Add constructor, destructor, initializer.
1495         <notif_queue>: Now a std::list.
1496         (remote_notif_state_xfree): Don't declare.
1497         * remote-notif.c (remote_notif_process, handle_notification)
1498         (remote_notif_state_allocate): Update.
1499         (~remote_notif_state): Rename from remote_notif_state_xfree.
1500
1501 2019-04-19  Tom Tromey  <tom@tromey.com>
1502
1503         * symfile.c (reread_symbols): Update.
1504         * objfiles.c (objfile_register_static_link)
1505         (objfile_lookup_static_link): Update
1506         (~objfile) Don't delete static_links.
1507         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1508
1509 2019-04-19  Tom Tromey  <tom@tromey.com>
1510
1511         * type-stack.h (struct type_stack) <insert>: Constify string.
1512         * type-stack.c (type_stack::insert): Constify string.
1513         * gdbtypes.h (lookup_template_type): Update.
1514         (address_space_name_to_int): Update.
1515         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1516         const.
1517         (lookup_template_type): Make name const.
1518         * c-exp.y: Update rules.
1519         (lex_one_token, classify_name, classify_inner_name)
1520         (c_print_token): Update.
1521         * p-exp.y: Update rules.
1522         (yylex): Update.
1523         * f-exp.y: Update rules.
1524         (yylex): Update.
1525         * d-exp.y: Update rules.
1526         (lex_one_token, classify_name, classify_inner_name): Update.
1527         * parse.c (write_dollar_variable, copy_name): Return std::string.
1528         * parser-defs.h (copy_name): Change return type.
1529         * m2-exp.y: Update rules.
1530         (yylex): Update.
1531         * go-exp.y (lex_one_token): Update.
1532         Update rules.
1533         (classify_unsafe_function, classify_packaged_name)
1534         (classify_name, yylex): Update.
1535
1536 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1537
1538         * configure.ac: add --enable-source-highlight switch.
1539         * configure: Regenerate.
1540         * top.c (print_gdb_version): plumb --enable-source-highlight
1541         status to "show configuration".
1542
1543 2019-04-19  Tom Tromey  <tromey@adacore.com>
1544
1545         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1546         Check ADA_TYPE_P.
1547         (empty_record, ada_template_to_fixed_record_type_1)
1548         (template_to_static_fixed_type)
1549         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1550         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1551         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1552         macros.
1553
1554 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1555
1556         PR symtab/24423:
1557         * source.c (print_source_lines_base): Advance "iter" when a
1558         control character is seen.
1559
1560 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1561
1562         * inferior.h (struct infcall_suspend_state_deleter):
1563         Catch exception in destructor to avoid crash.
1564
1565 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1566
1567         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1568         close to the add_com "shell".
1569
1570 2019-04-18  Tom Tromey  <tromey@adacore.com>
1571
1572         * process-stratum-target.h (class process_stratum_target)
1573         <stratum>: Add "final".
1574
1575 2019-04-17  Tom Tromey  <tromey@adacore.com>
1576
1577         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1578         against nullptr before use.
1579
1580 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1581
1582         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1583
1584 2019-04-17  Jim Wilson  <jimw@sifive.com>
1585             Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1588         code read might fail, assume 4-byte breakpoint in that case.
1589
1590 2019-04-15  Leszek Swirski  <leszeks@google.com>
1591
1592         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1593         rather than a hand-rolled POD check when checking for forced MEMORY
1594         classification.
1595
1596 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1597
1598         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1599         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1600         function.
1601         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1602         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1603         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1604         declaration.
1605
1606 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1607
1608         * aarch64-linux-nat.c
1609         (aarch64_linux_nat_target::thread_architecture): Add override.
1610         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1611         each VQ.
1612
1613 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1614
1615         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1616
1617 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1618
1619         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1620         target types of size 96-bits, add some additional comments, and
1621         check that the builtin type we found was the correct size.
1622
1623 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1624
1625         * utils.c (prompt_for_continue): Don't restore the styling at the
1626         end, as applied_style has the wrong value.  This fixes styling in
1627         long lists of file names that are interrupted by the "Continue?"
1628         prompt.
1629
1630 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1631
1632         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1633         * c-lang.c (c_language_defn): Likewise.
1634         (cplus_language_defn): Likewise.
1635         (asm_language_defn): Likewise.
1636         (minimal_language_defn): Likewise.
1637         * d-lang.c (d_language_defn): Likewise.
1638         * f-lang.c (f_language_defn): Likewise.
1639         * go-lang.c (go_language_defn): Likewise.
1640         * language.c (unknown_language_defn): Likewise.
1641         (auto_language_defn): Likewise.
1642         * language.h (struct language_defn): Remove la_magic field.
1643         (LANG_MAGIC): Delete.
1644         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1645         * objc-lang.c (objc_language_defn): Likewise.
1646         * opencl-lang.c (opencl_language_defn): Likewise.
1647         * p-lang.c (pascal_language_defn): Likewise.
1648         * rust-lang.c (rust_language_defn): Likewise.
1649
1650 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1651
1652         * riscv-tdep.c (riscv_type_align): New function.
1653         (riscv_type_alignment): Delete.
1654         (riscv_arg_location): Use 'type_align'.
1655         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1656
1657 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1658
1659         * gdbtypes.c (type_align): A struct with no non-static fields also
1660         has alignment of 1.
1661
1662 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1663
1664         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1665         component to 0.
1666         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1667         member.
1668         (riscv_struct_info::analyse): New implementation using new
1669         analyse_inner member function.
1670         (riscv_struct_info::field_offset): New member function.
1671         (riscv_struct_info::m_offsets): New member variable.
1672         (riscv_struct_info::analyse_inner): New private member function,
1673         takes the old implementation of riscv_struct_info::analyse but
1674         extended to track field offsets.
1675         (riscv_call_arg_struct): Update the struct folding special cases
1676         to handle cases where empty C++ structs, which are non-zero
1677         length, are found.
1678         (riscv_arg_location): Initialise the length of each location, a
1679         non-zero length now indicates the location is in use.
1680         (riscv_push_dummy_call): Allow for the first location having a
1681         non-zero offset when setting up arguments.
1682         (riscv_return_value): Likewise, but for return values.
1683
1684 2019-04-11  Tom Tromey  <tromey@adacore.com>
1685
1686         * utils.c (internal_vproblem): Make "msg" const.
1687
1688 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1689
1690         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1691         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1692         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1693         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1694
1695 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1696
1697         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1698         function.
1699         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1700         of amd64_collect_native_gregset.
1701         (amd64_linux_nat_target::store_registers): Likewise.
1702
1703 2019-04-10  Tom Tromey  <tom@tromey.com>
1704
1705         * symtab.c (lookup_global_symbol_from_objfile)
1706         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1707         * objfiles.h (class separate_debug_iterator): New.
1708         (class separate_debug_range): New.
1709         (struct objfile) <separate_debug_objfiles>: New method.
1710         (objfile_separate_debug_iterate): Don't declare.
1711         * objfiles.c (separate_debug_iterator::operator++): Rename from
1712         objfile_separate_debug_iterate.
1713         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1714         iterator.
1715         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1716         iterator.
1717
1718 2019-04-10  Tom Tromey  <tom@tromey.com>
1719
1720         * symfile.c (reread_symbols): Remove old comment.
1721         * objfiles.c (free_all_objfiles): Fix a typo.
1722
1723 2019-04-10  Tom Tromey  <tom@tromey.com>
1724
1725         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1726         * minsyms.c (lookup_minimal_symbol): Use foreach.
1727         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1728         (lookup_minimal_symbol_solib_trampoline): Likewise.
1729         * symfile.c (reread_symbols): Use foreach.
1730
1731 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1732             Tom Tromey  <tromey@adacore.com>
1733
1734         PR rust/24414:
1735         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1736         (rust_lex_int_test): Change "value" to be LONGEST.
1737         (rust_lex_tests): Add test for long integer literal.
1738
1739 2019-04-09  Tom Tromey  <tromey@adacore.com>
1740
1741         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1742         to bool.
1743         (extended_remote_target::attach): Update.
1744         (remote_target::remote_notice_new_inferior): Update.
1745         (remote_target::add_current_inferior_and_thread): Update.
1746         * inferior.c (exit_inferior_1): Use "false".
1747         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1748
1749 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1750
1751         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1752         the "start" command.
1753
1754 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1755
1756         * python/py-inferior.c (infpy_thread_from_thread_handle):
1757         Adjust comments to reflect renaming of thread_from_thread_handle
1758         to thread_from_handle.  Adjust keywords.  Fix type error message.
1759         (inferior_object_methods): Add thread_from_handle.  Retain
1760         thread_from_thread_handle, but mark it as deprecated.
1761
1762 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1763
1764         * gdbthread.h (find_thread_by_handle): Revise declaration.
1765         * thread.c (find_thread_by_handle): Likewise.  Adjust
1766         implementation too.
1767         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1768         support for buffer objects as handles.
1769
1770 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1771
1772         * python/py-infthread.c (thpy_thread_handle): New function.
1773         (thread_object_methods): Register thpy_thread_handle.
1774
1775 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1776
1777         * gdbthread.h (thread_to_thread_handle): Declare.
1778         * thread.c (gdbtypes.h): Include.
1779         (thread_to_thread_handle): New function.
1780
1781         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1782         (target_thread_info_to_thread_handle): Declare.
1783         * target.c (target_thread_info_to_thread_handle): New function.
1784         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1785         * target-delegates.c: Regenerate.
1786
1787         * linux-thread-db.c (class thread_db_target): Add method
1788         thread_info_to_thread_handle.
1789         (thread_db_target::thread_info_to_thread_handle): Define.
1790         * remote.c (class remote_target): Add new method
1791         thread_info_to_thread_handle.
1792         (remote_target::thread_info_to_thread_handle): Define.
1793
1794 2019-04-08  Pedro Alves  <palves@redhat.com>
1795
1796         * common/common-exceptions.c (throw_exception): Don't create
1797         named object to throw; throw directly.
1798         (throw_it): Likewise.  Don't initialize gdb_exception::message
1799         here, with new; pass FMT and AP to the ctor instead.
1800         * common/common-exceptions.h: Include <string>.
1801         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1802         const char *, va_list)): New ctor.  Use std::make_shared.
1803         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1804         errors)): Delete.
1805         (gdb_exception_error::gdb_exception_error(enum errors, const char
1806         *, va_list)): New.
1807         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1808         Add assertion.
1809         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1810         errors)): Delete.
1811         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1812         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1813         Add assertion.
1814
1815 2019-04-08  Tom Tromey  <tom@tromey.com>
1816
1817         * valops.c (value_rtti_indirect_type): Replace throw_exception
1818         with throw.
1819         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1820         with throw.
1821         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1822         throw.
1823         * target.c (target_translate_tls_address): Replace throw_exception
1824         with throw.
1825         * stack.c (frame_apply_command_count): Replace throw_exception
1826         with throw.
1827         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1828         throw.
1829         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1830         with throw.
1831         * rs6000-tdep.c (rs6000_frame_cache)
1832         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1833         * remote.c: Replace throw_exception with throw.
1834         * record-full.c (record_full_message, record_full_wait_1)
1835         (record_full_restore): Replace throw_exception with throw.
1836         * record-btrace.c:
1837         (get_thread_current_frame_id, record_btrace_start_replaying)
1838         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1839         (cmd_record_btrace_start): Replace throw_exception with throw.
1840         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1841         throw.
1842         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1843         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1844         * linespec.c:
1845         (find_linespec_symbols): Replace throw_exception with throw.
1846         * infrun.c (displaced_step_prepare, resume): Replace
1847         throw_exception with throw.
1848         * infcmd.c (post_create_inferior): Replace throw_exception with
1849         throw.
1850         * inf-loop.c (inferior_event_handler): Replace throw_exception
1851         with throw.
1852         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1853         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1854         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1855         (get_prev_frame_always, get_frame_pc_if_available)
1856         (get_frame_address_in_block_if_available, get_frame_language):
1857         Replace throw_exception with throw.
1858         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1859         throw_exception with throw.
1860         * eval.c (fetch_subexp_value, evaluate_var_value)
1861         (evaluate_funcall, evaluate_subexp_standard): Replace
1862         throw_exception with throw.
1863         * dwarf2loc.c (call_site_find_chain)
1864         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1865         Replace throw_exception with throw.
1866         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1867         with throw.
1868         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1869         throw.
1870         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1871         * completer.c (complete_line_internal): Replace throw_exception
1872         with throw.
1873         * compile/compile-object-run.c (compile_object_run): Replace
1874         throw_exception with throw.
1875         * cli/cli-script.c (process_next_line): Replace throw_exception
1876         with throw.
1877         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1878         (btrace_enable, btrace_maint_update_pt_packets): Replace
1879         throw_exception with throw.
1880         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1881         throw_exception with throw.
1882         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1883         throw_exception with throw.
1884         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1885         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1886         * aarch64-tdep.c (aarch64_make_prologue_cache)
1887         (aarch64_make_stub_cache): Replace throw_exception with throw.
1888
1889 2019-04-08  Tom Tromey  <tom@tromey.com>
1890
1891         * common/common-exceptions.c (throw_exception): Rename from
1892         throw_exception_cxx.  Remove old copy.  Make argument const.
1893         (throw_it): Create and throw exception objects directly.
1894         * common/common-exceptions.h (throw_exception): Make argument
1895         const.
1896         (struct gdb_exception_error): Add constructor.
1897         (struct gdb_exception_quit): Add constructor.
1898
1899 2019-04-08  Tom Tromey  <tom@tromey.com>
1900
1901         * common/common-exceptions.h (exception_rethrow): Don't declare.
1902         (TRY_SJLJ): Update comment.
1903         (TRY, CATCH, END_CATCH): Remove.
1904         * common/common-exceptions.c (exception_rethrow): Remove.
1905
1906 2019-04-08  Tom Tromey  <tom@tromey.com>
1907
1908         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1909         Remove.
1910         (gdb_exception_error): Rename from
1911         gdb_exception_RETURN_MASK_ERROR.
1912         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1913         (gdb_quit_bad_alloc): Update.
1914         * aarch64-tdep.c: Update.
1915         * ada-lang.c: Update.
1916         * ada-typeprint.c: Update.
1917         * ada-valprint.c: Update.
1918         * amd64-tdep.c: Update.
1919         * arch-utils.c: Update.
1920         * break-catch-throw.c: Update.
1921         * breakpoint.c: Update.
1922         * btrace.c: Update.
1923         * c-varobj.c: Update.
1924         * cli/cli-cmds.c: Update.
1925         * cli/cli-interp.c: Update.
1926         * cli/cli-script.c: Update.
1927         * common/common-exceptions.c: Update.
1928         * common/new-op.c: Update.
1929         * common/selftest.c: Update.
1930         * compile/compile-c-symbols.c: Update.
1931         * compile/compile-cplus-symbols.c: Update.
1932         * compile/compile-object-load.c: Update.
1933         * compile/compile-object-run.c: Update.
1934         * completer.c: Update.
1935         * corelow.c: Update.
1936         * cp-abi.c: Update.
1937         * cp-support.c: Update.
1938         * cp-valprint.c: Update.
1939         * darwin-nat.c: Update.
1940         * disasm-selftests.c: Update.
1941         * dtrace-probe.c: Update.
1942         * dwarf-index-cache.c: Update.
1943         * dwarf-index-write.c: Update.
1944         * dwarf2-frame-tailcall.c: Update.
1945         * dwarf2-frame.c: Update.
1946         * dwarf2loc.c: Update.
1947         * dwarf2read.c: Update.
1948         * eval.c: Update.
1949         * event-loop.c: Update.
1950         * event-top.c: Update.
1951         * exec.c: Update.
1952         * f-valprint.c: Update.
1953         * fbsd-tdep.c: Update.
1954         * frame-unwind.c: Update.
1955         * frame.c: Update.
1956         * gdbtypes.c: Update.
1957         * gnu-v3-abi.c: Update.
1958         * guile/guile-internal.h: Update.
1959         * guile/scm-block.c: Update.
1960         * guile/scm-breakpoint.c: Update.
1961         * guile/scm-cmd.c: Update.
1962         * guile/scm-disasm.c: Update.
1963         * guile/scm-frame.c: Update.
1964         * guile/scm-lazy-string.c: Update.
1965         * guile/scm-math.c: Update.
1966         * guile/scm-param.c: Update.
1967         * guile/scm-ports.c: Update.
1968         * guile/scm-pretty-print.c: Update.
1969         * guile/scm-symbol.c: Update.
1970         * guile/scm-symtab.c: Update.
1971         * guile/scm-type.c: Update.
1972         * guile/scm-value.c: Update.
1973         * i386-linux-tdep.c: Update.
1974         * i386-tdep.c: Update.
1975         * inf-loop.c: Update.
1976         * infcall.c: Update.
1977         * infcmd.c: Update.
1978         * infrun.c: Update.
1979         * jit.c: Update.
1980         * language.c: Update.
1981         * linespec.c: Update.
1982         * linux-fork.c: Update.
1983         * linux-nat.c: Update.
1984         * linux-tdep.c: Update.
1985         * linux-thread-db.c: Update.
1986         * main.c: Update.
1987         * mi/mi-cmd-break.c: Update.
1988         * mi/mi-cmd-stack.c: Update.
1989         * mi/mi-interp.c: Update.
1990         * mi/mi-main.c: Update.
1991         * objc-lang.c: Update.
1992         * p-valprint.c: Update.
1993         * parse.c: Update.
1994         * ppc-linux-tdep.c: Update.
1995         * printcmd.c: Update.
1996         * python/py-arch.c: Update.
1997         * python/py-breakpoint.c: Update.
1998         * python/py-cmd.c: Update.
1999         * python/py-finishbreakpoint.c: Update.
2000         * python/py-frame.c: Update.
2001         * python/py-framefilter.c: Update.
2002         * python/py-gdb-readline.c: Update.
2003         * python/py-inferior.c: Update.
2004         * python/py-infthread.c: Update.
2005         * python/py-lazy-string.c: Update.
2006         * python/py-linetable.c: Update.
2007         * python/py-objfile.c: Update.
2008         * python/py-param.c: Update.
2009         * python/py-prettyprint.c: Update.
2010         * python/py-progspace.c: Update.
2011         * python/py-record-btrace.c: Update.
2012         * python/py-record.c: Update.
2013         * python/py-symbol.c: Update.
2014         * python/py-type.c: Update.
2015         * python/py-unwind.c: Update.
2016         * python/py-utils.c: Update.
2017         * python/py-value.c: Update.
2018         * python/python.c: Update.
2019         * record-btrace.c: Update.
2020         * record-full.c: Update.
2021         * remote-fileio.c: Update.
2022         * remote.c: Update.
2023         * riscv-tdep.c: Update.
2024         * rs6000-aix-tdep.c: Update.
2025         * rs6000-tdep.c: Update.
2026         * rust-exp.y: Update.
2027         * rust-lang.c: Update.
2028         * s390-tdep.c: Update.
2029         * selftest-arch.c: Update.
2030         * solib-dsbt.c: Update.
2031         * solib-frv.c: Update.
2032         * solib-spu.c: Update.
2033         * solib-svr4.c: Update.
2034         * solib.c: Update.
2035         * sparc64-linux-tdep.c: Update.
2036         * stack.c: Update.
2037         * symfile-mem.c: Update.
2038         * symmisc.c: Update.
2039         * target.c: Update.
2040         * thread.c: Update.
2041         * top.c: Update.
2042         * tracefile-tfile.c: Update.
2043         * tui/tui.c: Update.
2044         * typeprint.c: Update.
2045         * unittests/cli-utils-selftests.c: Update.
2046         * unittests/parse-connection-spec-selftests.c: Update.
2047         * valops.c: Update.
2048         * valprint.c: Update.
2049         * value.c: Update.
2050         * varobj.c: Update.
2051         * windows-nat.c: Update.
2052         * x86-linux-nat.c: Update.
2053         * xml-support.c: Update.
2054
2055 2019-04-08  Tom Tromey  <tom@tromey.com>
2056
2057         * xml-support.c: Use C++ exception handling.
2058         * x86-linux-nat.c: Use C++ exception handling.
2059         * windows-nat.c: Use C++ exception handling.
2060         * varobj.c: Use C++ exception handling.
2061         * value.c: Use C++ exception handling.
2062         * valprint.c: Use C++ exception handling.
2063         * valops.c: Use C++ exception handling.
2064         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2065         handling.
2066         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2067         * typeprint.c: Use C++ exception handling.
2068         * tui/tui.c: Use C++ exception handling.
2069         * tracefile-tfile.c: Use C++ exception handling.
2070         * top.c: Use C++ exception handling.
2071         * thread.c: Use C++ exception handling.
2072         * target.c: Use C++ exception handling.
2073         * symmisc.c: Use C++ exception handling.
2074         * symfile-mem.c: Use C++ exception handling.
2075         * stack.c: Use C++ exception handling.
2076         * sparc64-linux-tdep.c: Use C++ exception handling.
2077         * solib.c: Use C++ exception handling.
2078         * solib-svr4.c: Use C++ exception handling.
2079         * solib-spu.c: Use C++ exception handling.
2080         * solib-frv.c: Use C++ exception handling.
2081         * solib-dsbt.c: Use C++ exception handling.
2082         * selftest-arch.c: Use C++ exception handling.
2083         * s390-tdep.c: Use C++ exception handling.
2084         * rust-lang.c: Use C++ exception handling.
2085         * rust-exp.y: Use C++ exception handling.
2086         * rs6000-tdep.c: Use C++ exception handling.
2087         * rs6000-aix-tdep.c: Use C++ exception handling.
2088         * riscv-tdep.c: Use C++ exception handling.
2089         * remote.c: Use C++ exception handling.
2090         * remote-fileio.c: Use C++ exception handling.
2091         * record-full.c: Use C++ exception handling.
2092         * record-btrace.c: Use C++ exception handling.
2093         * python/python.c: Use C++ exception handling.
2094         * python/py-value.c: Use C++ exception handling.
2095         * python/py-utils.c: Use C++ exception handling.
2096         * python/py-unwind.c: Use C++ exception handling.
2097         * python/py-type.c: Use C++ exception handling.
2098         * python/py-symbol.c: Use C++ exception handling.
2099         * python/py-record.c: Use C++ exception handling.
2100         * python/py-record-btrace.c: Use C++ exception handling.
2101         * python/py-progspace.c: Use C++ exception handling.
2102         * python/py-prettyprint.c: Use C++ exception handling.
2103         * python/py-param.c: Use C++ exception handling.
2104         * python/py-objfile.c: Use C++ exception handling.
2105         * python/py-linetable.c: Use C++ exception handling.
2106         * python/py-lazy-string.c: Use C++ exception handling.
2107         * python/py-infthread.c: Use C++ exception handling.
2108         * python/py-inferior.c: Use C++ exception handling.
2109         * python/py-gdb-readline.c: Use C++ exception handling.
2110         * python/py-framefilter.c: Use C++ exception handling.
2111         * python/py-frame.c: Use C++ exception handling.
2112         * python/py-finishbreakpoint.c: Use C++ exception handling.
2113         * python/py-cmd.c: Use C++ exception handling.
2114         * python/py-breakpoint.c: Use C++ exception handling.
2115         * python/py-arch.c: Use C++ exception handling.
2116         * printcmd.c: Use C++ exception handling.
2117         * ppc-linux-tdep.c: Use C++ exception handling.
2118         * parse.c: Use C++ exception handling.
2119         * p-valprint.c: Use C++ exception handling.
2120         * objc-lang.c: Use C++ exception handling.
2121         * mi/mi-main.c: Use C++ exception handling.
2122         * mi/mi-interp.c: Use C++ exception handling.
2123         * mi/mi-cmd-stack.c: Use C++ exception handling.
2124         * mi/mi-cmd-break.c: Use C++ exception handling.
2125         * main.c: Use C++ exception handling.
2126         * linux-thread-db.c: Use C++ exception handling.
2127         * linux-tdep.c: Use C++ exception handling.
2128         * linux-nat.c: Use C++ exception handling.
2129         * linux-fork.c: Use C++ exception handling.
2130         * linespec.c: Use C++ exception handling.
2131         * language.c: Use C++ exception handling.
2132         * jit.c: Use C++ exception handling.
2133         * infrun.c: Use C++ exception handling.
2134         * infcmd.c: Use C++ exception handling.
2135         * infcall.c: Use C++ exception handling.
2136         * inf-loop.c: Use C++ exception handling.
2137         * i386-tdep.c: Use C++ exception handling.
2138         * i386-linux-tdep.c: Use C++ exception handling.
2139         * guile/scm-value.c: Use C++ exception handling.
2140         * guile/scm-type.c: Use C++ exception handling.
2141         * guile/scm-symtab.c: Use C++ exception handling.
2142         * guile/scm-symbol.c: Use C++ exception handling.
2143         * guile/scm-pretty-print.c: Use C++ exception handling.
2144         * guile/scm-ports.c: Use C++ exception handling.
2145         * guile/scm-param.c: Use C++ exception handling.
2146         * guile/scm-math.c: Use C++ exception handling.
2147         * guile/scm-lazy-string.c: Use C++ exception handling.
2148         * guile/scm-frame.c: Use C++ exception handling.
2149         * guile/scm-disasm.c: Use C++ exception handling.
2150         * guile/scm-cmd.c: Use C++ exception handling.
2151         * guile/scm-breakpoint.c: Use C++ exception handling.
2152         * guile/scm-block.c: Use C++ exception handling.
2153         * guile/guile-internal.h: Use C++ exception handling.
2154         * gnu-v3-abi.c: Use C++ exception handling.
2155         * gdbtypes.c: Use C++ exception handling.
2156         * frame.c: Use C++ exception handling.
2157         * frame-unwind.c: Use C++ exception handling.
2158         * fbsd-tdep.c: Use C++ exception handling.
2159         * f-valprint.c: Use C++ exception handling.
2160         * exec.c: Use C++ exception handling.
2161         * event-top.c: Use C++ exception handling.
2162         * event-loop.c: Use C++ exception handling.
2163         * eval.c: Use C++ exception handling.
2164         * dwarf2read.c: Use C++ exception handling.
2165         * dwarf2loc.c: Use C++ exception handling.
2166         * dwarf2-frame.c: Use C++ exception handling.
2167         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2168         * dwarf-index-write.c: Use C++ exception handling.
2169         * dwarf-index-cache.c: Use C++ exception handling.
2170         * dtrace-probe.c: Use C++ exception handling.
2171         * disasm-selftests.c: Use C++ exception handling.
2172         * darwin-nat.c: Use C++ exception handling.
2173         * cp-valprint.c: Use C++ exception handling.
2174         * cp-support.c: Use C++ exception handling.
2175         * cp-abi.c: Use C++ exception handling.
2176         * corelow.c: Use C++ exception handling.
2177         * completer.c: Use C++ exception handling.
2178         * compile/compile-object-run.c: Use C++ exception handling.
2179         * compile/compile-object-load.c: Use C++ exception handling.
2180         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2181         * compile/compile-c-symbols.c: Use C++ exception handling.
2182         * common/selftest.c: Use C++ exception handling.
2183         * common/new-op.c: Use C++ exception handling.
2184         * cli/cli-script.c: Use C++ exception handling.
2185         * cli/cli-interp.c: Use C++ exception handling.
2186         * cli/cli-cmds.c: Use C++ exception handling.
2187         * c-varobj.c: Use C++ exception handling.
2188         * btrace.c: Use C++ exception handling.
2189         * breakpoint.c: Use C++ exception handling.
2190         * break-catch-throw.c: Use C++ exception handling.
2191         * arch-utils.c: Use C++ exception handling.
2192         * amd64-tdep.c: Use C++ exception handling.
2193         * ada-valprint.c: Use C++ exception handling.
2194         * ada-typeprint.c: Use C++ exception handling.
2195         * ada-lang.c: Use C++ exception handling.
2196         * aarch64-tdep.c: Use C++ exception handling.
2197
2198 2019-04-08  Tom Tromey  <tom@tromey.com>
2199
2200         * xml-support.c (gdb_xml_parser::parse): Update.
2201         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2202         * value.c (show_convenience): Update.
2203         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2204         (test_parse_flags_qcs): Update.
2205         * thread.c (thr_try_catch_cmd): Update.
2206         * target.c (target_translate_tls_address): Update.
2207         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2208         (info_frame_command_core, frame_apply_command_count): Update.
2209         * rust-exp.y (rust_lex_exception_test): Update.
2210         * riscv-tdep.c (riscv_print_one_register_info): Update.
2211         * remote.c (remote_target::enable_btrace): Update.
2212         * record-btrace.c (record_btrace_enable_warn): Update.
2213         * python/py-utils.c (gdbpy_convert_exception): Update.
2214         * printcmd.c (do_one_display, print_variable_and_value): Update.
2215         * mi/mi-main.c (mi_print_exception): Update.
2216         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2217         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2218         * linux-nat.c (linux_nat_target::attach): Update.
2219         * linux-fork.c (class scoped_switch_fork_info): Update.
2220         * infrun.c (displaced_step_prepare): Update.
2221         * infcall.c (call_function_by_hand_dummy): Update.
2222         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2223         * gnu-v3-abi.c (print_one_vtable): Update.
2224         * frame.c (get_prev_frame_always): Update.
2225         * f-valprint.c (info_common_command_for_block): Update.
2226         * exec.c (try_open_exec_file): Update.
2227         * exceptions.c (print_exception, exception_print)
2228         (exception_fprintf, exception_print_same): Update.
2229         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2230         * dwarf-index-cache.c (index_cache::store)
2231         (index_cache::lookup_gdb_index): Update.
2232         * darwin-nat.c (maybe_cache_shell): Update.
2233         * cp-valprint.c (cp_print_value_fields): Update.
2234         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2235         (gcc_cplus_symbol_address): Update.
2236         * compile/compile-c-symbols.c (gcc_convert_symbol)
2237         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2238         * common/selftest.c: Update.
2239         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2240         a std::string.
2241         (exception_try_scope_entry, exception_try_scope_exit): Don't
2242         declare.
2243         (struct exception_try_scope): Remove.
2244         (TRY): Don't use exception_try_scope.
2245         (struct gdb_exception): Add constructor, operator=.
2246         <what>: New method.
2247         (struct gdb_exception_RETURN_MASK_ALL)
2248         (struct gdb_exception_RETURN_MASK_ERROR)
2249         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2250         (struct gdb_quit_bad_alloc): Update.
2251         * common/common-exceptions.c (exception_none): Change
2252         initializer.
2253         (struct catcher) <state, exception>: Initialize inline.
2254         <prev>: Remove member.
2255         (current_catcher): Remove.
2256         (catchers): New global.
2257         (exceptions_state_mc_init): Simplify.
2258         (catcher_pop): Remove.
2259         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2260         (try_scope_depth, exception_try_scope_entry)
2261         (exception_try_scope_exit): Remove.
2262         (throw_exception_sjlj): Update.
2263         (exception_messages, exception_messages_size): Remove.
2264         (throw_it): Simplify.
2265         (gdb_exception_sliced_copy): Remove.
2266         (throw_exception_cxx): Update.
2267         * cli/cli-script.c (script_from_file): Update.
2268         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2269         Update.
2270         * ada-valprint.c (ada_val_print): Update.
2271         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2272         (create_excep_cond_exprs): Update.
2273
2274 2019-04-08  Tom Tromey  <tom@tromey.com>
2275
2276         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2277         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2278         (TRY, CATCH, END_CATCH): Remove some definitions.
2279         * common/common-exceptions.c: Don't use GDB_XCPT.
2280         (catcher_list_size): Remove.
2281         (throw_exception, throw_it): Simplify.
2282
2283 2019-04-05  Tom Tromey  <tom@tromey.com>
2284
2285         Revert the header-sorting patch.
2286         * ft32-tdep.c: Revert.
2287         * frv-tdep.c: Revert.
2288         * frv-linux-tdep.c: Revert.
2289         * frame.c: Revert.
2290         * frame-unwind.c: Revert.
2291         * frame-base.c: Revert.
2292         * fork-child.c: Revert.
2293         * findvar.c: Revert.
2294         * findcmd.c: Revert.
2295         * filesystem.c: Revert.
2296         * filename-seen-cache.h: Revert.
2297         * filename-seen-cache.c: Revert.
2298         * fbsd-tdep.c: Revert.
2299         * fbsd-nat.h: Revert.
2300         * fbsd-nat.c: Revert.
2301         * f-valprint.c: Revert.
2302         * f-typeprint.c: Revert.
2303         * f-lang.c: Revert.
2304         * extension.h: Revert.
2305         * extension.c: Revert.
2306         * extension-priv.h: Revert.
2307         * expprint.c: Revert.
2308         * exec.h: Revert.
2309         * exec.c: Revert.
2310         * exceptions.c: Revert.
2311         * event-top.c: Revert.
2312         * event-loop.c: Revert.
2313         * eval.c: Revert.
2314         * elfread.c: Revert.
2315         * dwarf2read.h: Revert.
2316         * dwarf2read.c: Revert.
2317         * dwarf2loc.c: Revert.
2318         * dwarf2expr.h: Revert.
2319         * dwarf2expr.c: Revert.
2320         * dwarf2-frame.c: Revert.
2321         * dwarf2-frame-tailcall.c: Revert.
2322         * dwarf-index-write.h: Revert.
2323         * dwarf-index-write.c: Revert.
2324         * dwarf-index-common.c: Revert.
2325         * dwarf-index-cache.h: Revert.
2326         * dwarf-index-cache.c: Revert.
2327         * dummy-frame.c: Revert.
2328         * dtrace-probe.c: Revert.
2329         * disasm.h: Revert.
2330         * disasm.c: Revert.
2331         * disasm-selftests.c: Revert.
2332         * dictionary.c: Revert.
2333         * dicos-tdep.c: Revert.
2334         * demangle.c: Revert.
2335         * dcache.h: Revert.
2336         * dcache.c: Revert.
2337         * darwin-nat.h: Revert.
2338         * darwin-nat.c: Revert.
2339         * darwin-nat-info.c: Revert.
2340         * d-valprint.c: Revert.
2341         * d-namespace.c: Revert.
2342         * d-lang.c: Revert.
2343         * ctf.c: Revert.
2344         * csky-tdep.c: Revert.
2345         * csky-linux-tdep.c: Revert.
2346         * cris-tdep.c: Revert.
2347         * cris-linux-tdep.c: Revert.
2348         * cp-valprint.c: Revert.
2349         * cp-support.c: Revert.
2350         * cp-namespace.c: Revert.
2351         * cp-abi.c: Revert.
2352         * corelow.c: Revert.
2353         * corefile.c: Revert.
2354         * continuations.c: Revert.
2355         * completer.h: Revert.
2356         * completer.c: Revert.
2357         * complaints.c: Revert.
2358         * coffread.c: Revert.
2359         * coff-pe-read.c: Revert.
2360         * cli-out.h: Revert.
2361         * cli-out.c: Revert.
2362         * charset.c: Revert.
2363         * c-varobj.c: Revert.
2364         * c-valprint.c: Revert.
2365         * c-typeprint.c: Revert.
2366         * c-lang.c: Revert.
2367         * buildsym.c: Revert.
2368         * buildsym-legacy.c: Revert.
2369         * build-id.h: Revert.
2370         * build-id.c: Revert.
2371         * btrace.c: Revert.
2372         * bsd-uthread.c: Revert.
2373         * breakpoint.h: Revert.
2374         * breakpoint.c: Revert.
2375         * break-catch-throw.c: Revert.
2376         * break-catch-syscall.c: Revert.
2377         * break-catch-sig.c: Revert.
2378         * blockframe.c: Revert.
2379         * block.c: Revert.
2380         * bfin-tdep.c: Revert.
2381         * bfin-linux-tdep.c: Revert.
2382         * bfd-target.c: Revert.
2383         * bcache.c: Revert.
2384         * ax-general.c: Revert.
2385         * ax-gdb.h: Revert.
2386         * ax-gdb.c: Revert.
2387         * avr-tdep.c: Revert.
2388         * auxv.c: Revert.
2389         * auto-load.c: Revert.
2390         * arm-wince-tdep.c: Revert.
2391         * arm-tdep.c: Revert.
2392         * arm-symbian-tdep.c: Revert.
2393         * arm-pikeos-tdep.c: Revert.
2394         * arm-obsd-tdep.c: Revert.
2395         * arm-nbsd-tdep.c: Revert.
2396         * arm-nbsd-nat.c: Revert.
2397         * arm-linux-tdep.c: Revert.
2398         * arm-linux-nat.c: Revert.
2399         * arm-fbsd-tdep.c: Revert.
2400         * arm-fbsd-nat.c: Revert.
2401         * arm-bsd-tdep.c: Revert.
2402         * arch-utils.c: Revert.
2403         * arc-tdep.c: Revert.
2404         * arc-newlib-tdep.c: Revert.
2405         * annotate.h: Revert.
2406         * annotate.c: Revert.
2407         * amd64-windows-tdep.c: Revert.
2408         * amd64-windows-nat.c: Revert.
2409         * amd64-tdep.c: Revert.
2410         * amd64-sol2-tdep.c: Revert.
2411         * amd64-obsd-tdep.c: Revert.
2412         * amd64-obsd-nat.c: Revert.
2413         * amd64-nbsd-tdep.c: Revert.
2414         * amd64-nbsd-nat.c: Revert.
2415         * amd64-nat.c: Revert.
2416         * amd64-linux-tdep.c: Revert.
2417         * amd64-linux-nat.c: Revert.
2418         * amd64-fbsd-tdep.c: Revert.
2419         * amd64-fbsd-nat.c: Revert.
2420         * amd64-dicos-tdep.c: Revert.
2421         * amd64-darwin-tdep.c: Revert.
2422         * amd64-bsd-nat.c: Revert.
2423         * alpha-tdep.c: Revert.
2424         * alpha-obsd-tdep.c: Revert.
2425         * alpha-nbsd-tdep.c: Revert.
2426         * alpha-mdebug-tdep.c: Revert.
2427         * alpha-linux-tdep.c: Revert.
2428         * alpha-linux-nat.c: Revert.
2429         * alpha-bsd-tdep.c: Revert.
2430         * alpha-bsd-nat.c: Revert.
2431         * aix-thread.c: Revert.
2432         * agent.c: Revert.
2433         * addrmap.c: Revert.
2434         * ada-varobj.c: Revert.
2435         * ada-valprint.c: Revert.
2436         * ada-typeprint.c: Revert.
2437         * ada-tasks.c: Revert.
2438         * ada-lang.c: Revert.
2439         * aarch64-tdep.c: Revert.
2440         * aarch64-ravenscar-thread.c: Revert.
2441         * aarch64-newlib-tdep.c: Revert.
2442         * aarch64-linux-tdep.c: Revert.
2443         * aarch64-linux-nat.c: Revert.
2444         * aarch64-fbsd-tdep.c: Revert.
2445         * aarch64-fbsd-nat.c: Revert.
2446         * aarch32-linux-nat.c: Revert.
2447
2448 2019-04-05  Tom Tromey  <tom@tromey.com>
2449
2450         * ft32-tdep.c: Sort headers.
2451         * frv-tdep.c: Sort headers.
2452         * frv-linux-tdep.c: Sort headers.
2453         * frame.c: Sort headers.
2454         * frame-unwind.c: Sort headers.
2455         * frame-base.c: Sort headers.
2456         * fork-child.c: Sort headers.
2457         * findvar.c: Sort headers.
2458         * findcmd.c: Sort headers.
2459         * filesystem.c: Sort headers.
2460         * filename-seen-cache.h: Sort headers.
2461         * filename-seen-cache.c: Sort headers.
2462         * fbsd-tdep.c: Sort headers.
2463         * fbsd-nat.h: Sort headers.
2464         * fbsd-nat.c: Sort headers.
2465         * f-valprint.c: Sort headers.
2466         * f-typeprint.c: Sort headers.
2467         * f-lang.c: Sort headers.
2468         * extension.h: Sort headers.
2469         * extension.c: Sort headers.
2470         * extension-priv.h: Sort headers.
2471         * expprint.c: Sort headers.
2472         * exec.h: Sort headers.
2473         * exec.c: Sort headers.
2474         * exceptions.c: Sort headers.
2475         * event-top.c: Sort headers.
2476         * event-loop.c: Sort headers.
2477         * eval.c: Sort headers.
2478         * elfread.c: Sort headers.
2479         * dwarf2read.h: Sort headers.
2480         * dwarf2read.c: Sort headers.
2481         * dwarf2loc.c: Sort headers.
2482         * dwarf2expr.h: Sort headers.
2483         * dwarf2expr.c: Sort headers.
2484         * dwarf2-frame.c: Sort headers.
2485         * dwarf2-frame-tailcall.c: Sort headers.
2486         * dwarf-index-write.h: Sort headers.
2487         * dwarf-index-write.c: Sort headers.
2488         * dwarf-index-common.c: Sort headers.
2489         * dwarf-index-cache.h: Sort headers.
2490         * dwarf-index-cache.c: Sort headers.
2491         * dummy-frame.c: Sort headers.
2492         * dtrace-probe.c: Sort headers.
2493         * disasm.h: Sort headers.
2494         * disasm.c: Sort headers.
2495         * disasm-selftests.c: Sort headers.
2496         * dictionary.c: Sort headers.
2497         * dicos-tdep.c: Sort headers.
2498         * demangle.c: Sort headers.
2499         * dcache.h: Sort headers.
2500         * dcache.c: Sort headers.
2501         * darwin-nat.h: Sort headers.
2502         * darwin-nat.c: Sort headers.
2503         * darwin-nat-info.c: Sort headers.
2504         * d-valprint.c: Sort headers.
2505         * d-namespace.c: Sort headers.
2506         * d-lang.c: Sort headers.
2507         * ctf.c: Sort headers.
2508         * csky-tdep.c: Sort headers.
2509         * csky-linux-tdep.c: Sort headers.
2510         * cris-tdep.c: Sort headers.
2511         * cris-linux-tdep.c: Sort headers.
2512         * cp-valprint.c: Sort headers.
2513         * cp-support.c: Sort headers.
2514         * cp-namespace.c: Sort headers.
2515         * cp-abi.c: Sort headers.
2516         * corelow.c: Sort headers.
2517         * corefile.c: Sort headers.
2518         * continuations.c: Sort headers.
2519         * completer.h: Sort headers.
2520         * completer.c: Sort headers.
2521         * complaints.c: Sort headers.
2522         * coffread.c: Sort headers.
2523         * coff-pe-read.c: Sort headers.
2524         * cli-out.h: Sort headers.
2525         * cli-out.c: Sort headers.
2526         * charset.c: Sort headers.
2527         * c-varobj.c: Sort headers.
2528         * c-valprint.c: Sort headers.
2529         * c-typeprint.c: Sort headers.
2530         * c-lang.c: Sort headers.
2531         * buildsym.c: Sort headers.
2532         * buildsym-legacy.c: Sort headers.
2533         * build-id.h: Sort headers.
2534         * build-id.c: Sort headers.
2535         * btrace.c: Sort headers.
2536         * bsd-uthread.c: Sort headers.
2537         * breakpoint.h: Sort headers.
2538         * breakpoint.c: Sort headers.
2539         * break-catch-throw.c: Sort headers.
2540         * break-catch-syscall.c: Sort headers.
2541         * break-catch-sig.c: Sort headers.
2542         * blockframe.c: Sort headers.
2543         * block.c: Sort headers.
2544         * bfin-tdep.c: Sort headers.
2545         * bfin-linux-tdep.c: Sort headers.
2546         * bfd-target.c: Sort headers.
2547         * bcache.c: Sort headers.
2548         * ax-general.c: Sort headers.
2549         * ax-gdb.h: Sort headers.
2550         * ax-gdb.c: Sort headers.
2551         * avr-tdep.c: Sort headers.
2552         * auxv.c: Sort headers.
2553         * auto-load.c: Sort headers.
2554         * arm-wince-tdep.c: Sort headers.
2555         * arm-tdep.c: Sort headers.
2556         * arm-symbian-tdep.c: Sort headers.
2557         * arm-pikeos-tdep.c: Sort headers.
2558         * arm-obsd-tdep.c: Sort headers.
2559         * arm-nbsd-tdep.c: Sort headers.
2560         * arm-nbsd-nat.c: Sort headers.
2561         * arm-linux-tdep.c: Sort headers.
2562         * arm-linux-nat.c: Sort headers.
2563         * arm-fbsd-tdep.c: Sort headers.
2564         * arm-fbsd-nat.c: Sort headers.
2565         * arm-bsd-tdep.c: Sort headers.
2566         * arch-utils.c: Sort headers.
2567         * arc-tdep.c: Sort headers.
2568         * arc-newlib-tdep.c: Sort headers.
2569         * annotate.h: Sort headers.
2570         * annotate.c: Sort headers.
2571         * amd64-windows-tdep.c: Sort headers.
2572         * amd64-windows-nat.c: Sort headers.
2573         * amd64-tdep.c: Sort headers.
2574         * amd64-sol2-tdep.c: Sort headers.
2575         * amd64-obsd-tdep.c: Sort headers.
2576         * amd64-obsd-nat.c: Sort headers.
2577         * amd64-nbsd-tdep.c: Sort headers.
2578         * amd64-nbsd-nat.c: Sort headers.
2579         * amd64-nat.c: Sort headers.
2580         * amd64-linux-tdep.c: Sort headers.
2581         * amd64-linux-nat.c: Sort headers.
2582         * amd64-fbsd-tdep.c: Sort headers.
2583         * amd64-fbsd-nat.c: Sort headers.
2584         * amd64-dicos-tdep.c: Sort headers.
2585         * amd64-darwin-tdep.c: Sort headers.
2586         * amd64-bsd-nat.c: Sort headers.
2587         * alpha-tdep.c: Sort headers.
2588         * alpha-obsd-tdep.c: Sort headers.
2589         * alpha-nbsd-tdep.c: Sort headers.
2590         * alpha-mdebug-tdep.c: Sort headers.
2591         * alpha-linux-tdep.c: Sort headers.
2592         * alpha-linux-nat.c: Sort headers.
2593         * alpha-bsd-tdep.c: Sort headers.
2594         * alpha-bsd-nat.c: Sort headers.
2595         * aix-thread.c: Sort headers.
2596         * agent.c: Sort headers.
2597         * addrmap.c: Sort headers.
2598         * ada-varobj.c: Sort headers.
2599         * ada-valprint.c: Sort headers.
2600         * ada-typeprint.c: Sort headers.
2601         * ada-tasks.c: Sort headers.
2602         * ada-lang.c: Sort headers.
2603         * aarch64-tdep.c: Sort headers.
2604         * aarch64-ravenscar-thread.c: Sort headers.
2605         * aarch64-newlib-tdep.c: Sort headers.
2606         * aarch64-linux-tdep.c: Sort headers.
2607         * aarch64-linux-nat.c: Sort headers.
2608         * aarch64-fbsd-tdep.c: Sort headers.
2609         * aarch64-fbsd-nat.c: Sort headers.
2610         * aarch32-linux-nat.c: Sort headers.
2611
2612 2019-04-04  Tom Tromey  <tom@tromey.com>
2613
2614         * varobj.c (varobj_create): Update.
2615         * rust-exp.y (struct rust_parser) <update_innermost_block,
2616         lookup_symbol>: New methods.
2617         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2618         Rename.
2619         (rust_parser::rust_lookup_type)
2620         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2621         * printcmd.c (display_command, do_one_display): Update.
2622         * parser-defs.h (struct parser_state) <parser_state>: Add
2623         "tracker" parameter.
2624         (block_tracker): New member.
2625         (class innermost_block_tracker) <innermost_block_tracker>: Add
2626         "types" parameter.
2627         <reset>: Remove method.
2628         (innermost_block): Don't declare.
2629         (null_post_parser): Update.
2630         * parse.c (innermost_block): Remove global.
2631         (write_dollar_variable): Update.
2632         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2633         Remove "tracker_types" parameter.
2634         (parse_expression): Add "tracker" parameter.
2635         (parse_expression_for_completion): Update.
2636         (null_post_parser): Add "tracker" parameter.
2637         * p-exp.y: Update rules.
2638         * m2-exp.y: Update rules.
2639         * language.h (struct language_defn) <la_post_parser>: Add
2640         "tracker" parameter.
2641         * go-exp.y: Update rules.
2642         * f-exp.y: Update rules.
2643         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2644         parameter.
2645         * d-exp.y: Update rules.
2646         * c-exp.y: Update rules.
2647         * breakpoint.c (set_breakpoint_condition): Create an
2648         innermost_block_tracker.
2649         (watch_command_1): Likewise.
2650         * ada-lang.c (resolve): Add "tracker" parameter.
2651         (resolve_subexp): Likewise.
2652         * ada-exp.y (write_var_from_sym): Update.
2653
2654 2019-04-04  Tom Tromey  <tom@tromey.com>
2655
2656         * type-stack.h: New file.
2657         * type-stack.c: New file.
2658         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2659         type-stack.h.
2660         (insert_into_type_stack, insert_type, push_type, push_type_int)
2661         (insert_type_address_space, pop_type, pop_type_int)
2662         (pop_typelist, pop_type_stack, append_type_stack)
2663         (push_type_stack, get_type_stack, push_typelist)
2664         (follow_type_instance_flags, follow_types): Don't declare.
2665         * parse.c (type_stack): Remove global.
2666         (parse_exp_in_context): Update.
2667         (insert_into_type_stack, insert_type, push_type, push_type_int)
2668         (insert_type_address_space, pop_type, pop_type_int)
2669         (pop_typelist, pop_type_stack, append_type_stack)
2670         (push_type_stack, get_type_stack, push_typelist)
2671         (follow_type_instance_flags, follow_types): Remove (moved to
2672         type-stack.c).
2673         * f-exp.y (type_stack): New global.
2674         Update rules.
2675         (push_kind_type, f_parse): Update.
2676         * d-exp.y (type_stack): New global.
2677         Update rules.
2678         (d_parse): Update.
2679         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2680         Update rules.
2681         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2682         (HFILES_NO_SRCDIR): Add type-stack.h.
2683
2684 2019-04-04  Tom Tromey  <tom@tromey.com>
2685
2686         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2687         (rust_parser::convert_ast_to_expression, rust_parse)
2688         (rust_lex_test_completion, rust_lex_tests): Update.
2689         * parser-defs.h (struct expr_completion_state): New.
2690         (struct parser_state) <parser_state>: Add completion parameter.
2691         <mark_struct_expression, mark_completion_tag>: New methods.
2692         <parse_completion, m_completion_state>: New members.
2693         (prefixify_expression, null_post_parser): Update.
2694         (mark_struct_expression, mark_completion_tag): Don't declare.
2695         * parse.c (parse_completion, expout_last_struct)
2696         (expout_tag_completion_type, expout_completion_name): Remove
2697         globals.
2698         (parser_state::mark_struct_expression)
2699         (parser_state::mark_completion_tag): Now methods.
2700         (prefixify_expression): Add last_struct parameter.
2701         (prefixify_subexp): Likewise.
2702         (parse_exp_1): Update.
2703         (parse_exp_in_context): Add cstate parameter.  Update.
2704         (parse_expression_for_completion): Create an
2705         expr_completion_state.
2706         (null_post_parser): Add "completion" parameter.
2707         * p-exp.y: Update rules.
2708         (yylex): Update.
2709         * language.h (struct language_defn) <la_post_parser>: Add
2710         "completing" parameter.
2711         * go-exp.y: Update rules.
2712         (lex_one_token): Update.
2713         * expression.h (parse_completion): Don't declare.
2714         * d-exp.y: Update rules.
2715         (lex_one_token): Update rules.
2716         * c-exp.y: Update rules.
2717         (lex_one_token): Update.
2718         * ada-lang.c (resolve): Add "parse_completion" parameter.
2719         (resolve_subexp): Likewise.
2720         (ada_resolve_function): Likewise.
2721
2722 2019-04-04  Tom Tromey  <tom@tromey.com>
2723
2724         * parser-defs.h (struct parser_state) <start_arglist,
2725         end_arglist>: New methods.
2726         <arglist_len, m_funcall_chain>: New members.
2727         (arglist_len, start_arglist, end_arglist): Don't declare.
2728         * parse.c (arglist_len, funcall_chain): Remove global.
2729         (start_arglist, end_arglist): Remove functions.
2730         (parse_exp_in_context): Update.
2731         * p-exp.y: Update rules.
2732         * m2-exp.y: Update rules.
2733         * go-exp.y: Update rules.
2734         * f-exp.y: Update rules.
2735         * d-exp.y: Update rules.
2736         * c-exp.y: Update rules.
2737
2738 2019-04-04  Tom Tromey  <tom@tromey.com>
2739
2740         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2741         lex_operator, push_back>: New methods.
2742         Update all rules.
2743         (rust_parser::lex_hex, lex_escape): Rename and update.
2744         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2745         (rust_parser::lex_operator): Rename and update.
2746         (rust_parser::lex_number, rustyylex, rustyyerror)
2747         (rust_lex_test_init, rust_lex_test_sequence)
2748         (rust_lex_test_push_back, rust_lex_tests): Update.
2749         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2750         parameter.
2751         <lexptr, prev_lexptr>: New members.
2752         (lexptr, prev_lexptr): Don't declare.
2753         * parse.c (lexptr, prev_lexptr): Remove globals.
2754         (parse_exp_in_context): Update.
2755         * p-exp.y (yylex, yyerror): Update.
2756         * m2-exp.y (parse_number, yylex, yyerror): Update.
2757         * go-exp.y (lex_one_token, yyerror): Update.
2758         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2759         * d-exp.y (lex_one_token, yyerror): Update.
2760         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2761         (lex_one_token, yyerror): Update.
2762         * ada-lex.l (YY_INPUT): Update.
2763         (rewind_to_char): Update.
2764         * ada-exp.y (yyerror): Update.
2765
2766 2019-04-04  Tom Tromey  <tom@tromey.com>
2767
2768         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2769         * parser-defs.h (struct parser_state) <parser_state>: Add new
2770         parameter.
2771         <comma_terminates>: New member.
2772         (comma_terminates): Don't declare global.
2773         * parse.c (comma_terminates): Remove global.
2774         (parse_exp_in_context): Update.
2775         * p-exp.y (yylex): Update.
2776         * m2-exp.y (yylex): Update.
2777         * go-exp.y (lex_one_token): Update.
2778         * f-exp.y (yylex): Update.
2779         * d-exp.y (lex_one_token): Update.
2780         * c-exp.y (lex_one_token): Update.
2781         * ada-lex.l: Update.
2782
2783 2019-04-04  Tom Tromey  <tom@tromey.com>
2784
2785         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2786         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2787         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2788         * parser-defs.h (paren_depth): Don't declare.
2789         * parse.c (paren_depth): Remove global.
2790         (parse_exp_in_context): Update.
2791         * p-exp.y (paren_depth): New global.
2792         (pascal_parse): Initialize it.
2793         * m2-exp.y (paren_depth): New global.
2794         (m2_parse): Initialize it.
2795         * go-exp.y (paren_depth): New global.
2796         (go_parse): Initialize it.
2797         * f-exp.y (paren_depth): New global.
2798         (f_parse): Initialize it.
2799         * d-exp.y (paren_depth): New global.
2800         (d_parse): Initialize it.
2801         * c-exp.y (paren_depth): New global.
2802         (c_parse): Initialize it.
2803         * ada-lex.l (paren_depth): New global.
2804         (lexer_init): Initialize it.
2805
2806 2019-04-04  Tom Tromey  <tom@tromey.com>
2807
2808         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2809         (rust_parser::convert_ast_to_type)
2810         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2811         * parser-defs.h (struct parser_state) <parser_state>: Add
2812         parameters.  Initialize new members.
2813         <expression_context_block, expression_context_pc>: New members.
2814         * parse.c (expression_context_block, expression_context_pc):
2815         Remove globals.
2816         (parse_exp_in_context): Update.
2817         * p-exp.y: Update all rules.
2818         (yylex): Update.
2819         * m2-exp.y: Update all rules.
2820         (yylex): Update.
2821         * go-exp.y (yylex): Update.
2822         * f-exp.y (yylex): Update.
2823         * d-exp.y: Update all rules.
2824         (yylex): Update.
2825         * c-exp.y: Update all rules.
2826         (lex_one_token, classify_name, yylex, c_parse): Update.
2827         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2828
2829 2019-04-04  Tom Tromey  <tom@tromey.com>
2830
2831         * gdbarch.h, gdbarch.c: Rebuild.
2832         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2833         * stap-probe.h:
2834         (struct stap_parse_info): Replace "parser_state" with
2835         "expr_builder".
2836         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2837         (parser_state): New class.
2838         * parse.c (expr_builder): Rename.
2839         (expr_builder::release): Rename.
2840         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2841         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2842         (write_exp_elt_longcst, write_exp_elt_floatcst)
2843         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2844         (write_exp_string_vector, write_exp_bitstring)
2845         (write_exp_msymbol, mark_struct_expression)
2846         (write_dollar_variable)
2847         (insert_type_address_space, increase_expout_size): Replace
2848         "parser_state" with "expr_builder".
2849         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2850         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2851         "parser_state" with "expr_builder".
2852
2853 2019-04-04  Tom Tromey  <tom@tromey.com>
2854
2855         * rust-exp.y: Replace "parse_language" with method call.
2856         * p-exp.y:
2857         (yylex): Replace "parse_language" with method call.
2858         * m2-exp.y:
2859         (yylex): Replace "parse_language" with method call.
2860         * go-exp.y (classify_name): Replace "parse_language" with method
2861         call.
2862         * f-exp.y (yylex): Replace "parse_language" with method call.
2863         * d-exp.y (lex_one_token): Replace "parse_language" with method
2864         call.
2865         * c-exp.y:
2866         (lex_one_token, classify_name, yylex): Replace "parse_language"
2867         with method call.
2868         * ada-exp.y (find_primitive_type, type_char)
2869         (type_system_address): Replace "parse_language" with method call.
2870
2871 2019-04-04  Tom Tromey  <tom@tromey.com>
2872
2873         * rust-exp.y: Replace "parse_gdbarch" with method call.
2874         * parse.c (write_dollar_variable, insert_type_address_space):
2875         Replace "parse_gdbarch" with method call.
2876         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2877         call.
2878         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2879         call.
2880         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2881         "parse_gdbarch" with method call.
2882         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2883         with method call.
2884         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2885         "parse_gdbarch" with method call.
2886         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2887         "parse_gdbarch" with method call.
2888         * c-exp.y (parse_type, parse_number, classify_name): Replace
2889         "parse_gdbarch" with method call.
2890         * ada-lex.l: Replace "parse_gdbarch" with method call.
2891         * ada-exp.y (parse_type, find_primitive_type, type_char)
2892         (type_system_address): Replace "parse_gdbarch" with method call.
2893
2894 2019-04-04  Tom Tromey  <tom@tromey.com>
2895
2896         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2897         * stap-probe.c (stap_parse_argument): Update.
2898         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2899         initial_size parameter.
2900         * rust-exp.y (rust_lex_tests): Update.
2901         * parse.c (parser_state): Update.
2902         (parse_exp_in_context): Update.
2903         * parser-defs.h (struct parser_state) <parser_state>: Remove
2904         "initial_size" parameter.
2905
2906 2019-04-04  Tom Tromey  <tom@tromey.com>
2907
2908         * parser-defs.h (increase_expout_size): Don't declare.
2909         * parse.c (increase_expout_size): Now static.
2910
2911 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2912
2913         * gnu-nat.c (gnu_nat_target::wait): Fix
2914         target_waitstatus_to_string call.
2915
2916 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2917
2918         * eval.c (evaluate_subexp_standard): Handle internal functions
2919         during Fortran function call handling.
2920
2921 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2922
2923         * NEWS: Mention new internal functions.
2924         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2925         (read_base_type): Use dwarf2_init_complex_target_type.
2926         * value.c (creal_internal_fn): New function.
2927         (cimag_internal_fn): New function.
2928         (_initialize_values): Register new internal functions.
2929
2930 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2931
2932         * infrun.c (stop_all_threads): If debug_infrun, always
2933         trace the wait status after wait_one, using
2934         target_waitstatus_to_string and target_pid_to_str.
2935         (handle_inferior_event): Replace various trace of
2936         wait status kind by a single trace.
2937         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2938         wait status kind image by target_waitstatus_to_string.
2939         * target/waitstatus.c (target_waitstatus_to_string): Fix
2940         obsolete comment.
2941
2942 2019-04-01  Tom Tromey  <tromey@adacore.com>
2943
2944         PR symtab/23331:
2945         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2946
2947 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2948             Pedro Alves  <palves@redhat.com>
2949
2950         * top.c (quit_force): Call 'finalize_values'.
2951         * value.c (finalize_values): New function.
2952         * value.h (finalize_values): Declare.
2953
2954 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2955
2956         * NEWS: Announce $_gdb_major and $_gdb_minor.
2957
2958         * top.c (init_gdb_version_vars): New function.
2959         (gdb_init): Call init_gdb_version_vars.
2960
2961 2019-03-29  Tom Tromey  <tromey@adacore.com>
2962
2963         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2964         help text.  Remove dead code.
2965
2966 2019-03-29  Keith Seitz  <keiths@redhat.com>
2967
2968         From Siddhesh Poyarekar:
2969         * f-lang.h (f77_get_upperbound): Return LONGEST.
2970         (f77_get_lowerbound): Likewise.
2971         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2972         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2973         print them.
2974         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2975         plongest to format print it.
2976         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2977         (f77_get_upperbound): Likewise.
2978         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2979         LOWER_BOUND to LONGEST.
2980         (f77_create_arrayprint_offset_tbl): Likewise.
2981
2982 2019-03-29  Keith Seitz  <keiths@redhat.com>
2983
2984         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2985         %s/pulongest for TYPE_LENGTH instead of %d in format
2986         strings.
2987         * ada-typerint.c (ada_print_type): Likewise.
2988         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2989         * compile/compile-c-support.c (generate_register_struct): Likewise.
2990         * gdbtypes.c (recursive_dump_type): Likewise.
2991         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2992         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2993         instead of %d in format strings.
2994         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2995         to std::min to ULONGEST.
2996         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2997         instead of %d in format strings.
2998         * tracepoint.c (info_scope_command): Likewise.
2999         * typeprint.c (print_offset_data::update)
3000         (print_offset_data::finish): Likewise.
3001         * xtensa-tdep.c (xtensa_store_return_value)
3002         (xtensa_push_dummy_call): Likewise.
3003
3004 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3005
3006         * windows-nat.c (display_selector): Fixed format specifications
3007         for 64-bit Cygwin.
3008
3009 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3010
3011         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3012
3013 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3014
3015         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3016         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3017         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3018         (nios2_linux_init_abi): Install it.
3019
3020 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3021
3022         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3023
3024 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3025
3026         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3027
3028 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3029             Tom Tromey  <tromey@adacore.com>
3030
3031         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3032
3033 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3034
3035         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3036         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3037         method to compute the bounds of range types. Also print "[evaluated]"
3038         if the bounds' values come from a dynamic evaluation.
3039
3040 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3041
3042         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3043         whitespace when pretty printing is on.
3044
3045 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3046
3047         * ppc-linux-nat.c: Add include.
3048
3049 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3050
3051         * NEWS: Mention AArch64 Pointer Authentication.
3052
3053 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3054
3055         * arm-linux-nat.c: Add include.
3056
3057 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3058
3059         * source-cache.c (source_cache::get_source_lines): Re-read
3060         fullname after calling open_source_file.
3061
3062 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3063
3064         * NEWS: Mention TLS support for FreeBSD.
3065
3066 2019-03-25  Tom Tromey  <tromey@adacore.com>
3067
3068         * minsyms.c (BUNCH_SIZE): Update comment.
3069         (~minimal_symbol_reader): Remove old comment.
3070         (compact_minimal_symbols): Update comment.
3071         (minimal_symbol_reader::install): Remove old comment.  Update
3072         other comments.
3073
3074 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3075
3076         * s390-linux-nat.c: Add include.
3077
3078 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3079
3080         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3081         Call linux_get_hwcap.
3082         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3083         Likewise.
3084         (aarch64_linux_get_hwcap): Remove function.
3085         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3086         declaration.
3087         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3088         linux_get_hwcap.
3089         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3090         * linux-tdep.c (linux_get_hwcap): Add function.
3091         (linux_get_hwcap2): Likewise.
3092         * linux-tdep.h (linux_get_hwcap): Add declaration.
3093         (linux_get_hwcap2): Likewise.
3094         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3095         (ppc_linux_get_hwcap2): Likewise.
3096         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3097         linux_get_hwcap.
3098         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3099         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3100         (ppc_linux_nat_target::read_description): Likewise.
3101         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3102         * s390-linux-nat.c: Likewise.
3103         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3104
3105 2019-03-24  Tom Tromey  <tom@tromey.com>
3106
3107         * ada-lang.c (standard_lookup): Simplify initialization.
3108         (ada_lookup_symbol_nonlocal): Simplify return.
3109         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3110         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3111         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3112         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3113         initialization.
3114         * solib.c (solib_global_lookup): Simplify.
3115         * symtab.c (null_block_symbol): Remove.
3116         (symbol_cache_lookup): Simplify returns.
3117         (lookup_language_this): Simplify returns.
3118         (lookup_symbol_aux): Simplify return.
3119         (lookup_local_symbol): Simplify returns.
3120         (lookup_global_symbol_from_objfile): Simplify return.
3121         (lookup_symbol_in_objfile_symtabs)
3122         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3123         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3124         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3125         * cp-namespace.c (cp_lookup_bare_symbol)
3126         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3127         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3128         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3129         (cp_lookup_symbol_via_imports): Simplify initialization.
3130         (find_symbol_in_baseclass): Likewise.
3131         * symtab.h (null_block_symbol): Remove.
3132         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3133         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3134         (d_lookup_symbol_module): Likewise.
3135         (find_symbol_in_baseclass): Simplify initialization.
3136
3137 2019-03-24  Tom Tromey  <tom@tromey.com>
3138
3139         * expression.h: Don't include symtab.h.
3140         (struct block): Forward declare.
3141
3142 2019-03-24  Tom Tromey  <tom@tromey.com>
3143
3144         * c-exp.y (typebase): Remove casts.
3145         * gdbtypes.c (lookup_unsigned_typename, )
3146         (lookup_signed_typename): Remove cast.
3147         * eval.c (parse_to_comma_and_eval): Remove cast.
3148         * parse.c (write_dollar_variable): Remove cast.
3149         * block.h (struct block) <superblock>: Now const.
3150         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3151         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3152         (map_block): Make "block" const.
3153         * symfile.h (struct quick_symbol_functions)
3154         <map_matching_symbols>: Constify block argument to "callback".
3155         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3156         const.
3157         (find_pc_sect_compunit_symtab): Make "b" const.
3158         (find_symbol_at_address): Likewise.
3159         (search_symbols): Likewise.
3160         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3161         (dw2_debug_names_lookup_symbol): Likewise.
3162         (dw2_map_matching_symbols): Update.
3163         * p-valprint.c (pascal_val_print): Remove "block".
3164         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3165         (aux_add_nonlocal_symbols): Make "block" const.
3166         (resolve_subexp): Remove cast.
3167         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3168         const.
3169         (iterate_over_file_blocks): Likewise.
3170         * f-exp.y (%union) <bval>: Remove.
3171         * coffread.c (patch_opaque_types): Make "b" const.
3172         * spu-tdep.c (spu_catch_start): Make "block" const.
3173         * c-valprint.c (print_unpacked_pointer): Remove "block".
3174         * symmisc.c (dump_symtab_1): Make "b" const.
3175         (block_depth): Make "block" const.
3176         * d-exp.y (%union) <bval>: Remove.
3177         * cp-support.h (cp_lookup_rtti_type): Update.
3178         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3179         * psymtab.c (psym_lookup_symbol): Make "block" const.
3180         (maintenance_check_psymtabs): Make "b" const.
3181         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3182         (enumerate_locals, enumerate_args): Update.
3183         * python/py-symtab.c (stpy_global_block): Make "block" const.
3184         (stpy_static_block): Likewise.
3185         * inline-frame.c (block_starting_point_at): Make "new_block"
3186         const.
3187         * block.c (find_block_in_blockvector): Make return type const.
3188         (blockvector_for_pc_sect): Make "b" const.
3189         (find_block_in_blockvector): Make "b" const.
3190
3191 2019-03-23  Tom Tromey  <tom@tromey.com>
3192
3193         * varobj.c (varobj_create): Update.
3194         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3195         * printcmd.c (display_command, do_one_display): Don't reset
3196         innermost_block.
3197         * parser-defs.h (enum innermost_block_tracker_type): Move to
3198         expression.h.
3199         (innermost_block): Update comment.
3200         * parse.c (parse_exp_1): Add tracker_types parameter.
3201         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3202         tracker_types parameter.  Reset innermost_block.
3203         (parse_exp_in_context): Remove.
3204         (parse_expression_for_completion): Update.
3205         * objfiles.c (~objfile): Don't reset expression_context_block or
3206         innermost_block.
3207         * expression.h (enum innermost_block_tracker_type): Move from
3208         parser-defs.h.
3209         (parse_exp_1): Add tracker_types parameter.
3210         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3211         reset innermost_block.
3212
3213 2019-03-23  Tom Tromey  <tom@tromey.com>
3214
3215         * objfiles.h: Include bcache.h.
3216
3217 2019-03-23  Tom Tromey  <tom@tromey.com>
3218
3219         * linespec.c (get_current_search_block): Use
3220         scoped_restore_current_language.
3221         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3222
3223 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3224             Jiong Wang  <jiong.wang@arm.com>
3225
3226         * aarch64-linux-tdep.c
3227         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3228         section.
3229         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3230
3231 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3232             Jiong Wang  <jiong.wang@arm.com>
3233
3234         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3235         instructions.
3236         (aarch64_analyze_prologue_test): Add PACIASP test.
3237         (aarch64_prologue_prev_register): Unmask PC value.
3238
3239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3240             Jiong Wang  <jiong.wang@arm.com>
3241
3242         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3243         (aarch64_dwarf2_prev_register): Unmask PC value.
3244         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3245         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3246         DW_CFA_AARCH64_negate_ra_state.
3247         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3248
3249 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3250             Jiong Wang  <jiong.wang@arm.com>
3251
3252         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3253         registers.
3254         (aarch64_pseudo_register_name): Likewise.
3255         (aarch64_pseudo_register_type): Likewise.
3256         (aarch64_pseudo_register_reggroup_p): Likewise.
3257         (aarch64_gdbarch_init): Add pauth registers.
3258         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3259         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3260         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3261         (struct gdbarch_tdep): Add regnum for ra_state.
3262
3263 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3264             Jiong Wang  <jiong.wang@arm.com>
3265
3266         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3267
3268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3269             Jiong Wang  <jiong.wang@arm.com>
3270
3271         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3272         function.
3273         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3274         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3275         (aarch64_gdbarch_init): Add puth registers.
3276         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3277         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3278         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3279
3280 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3281             Jiong Wang  <jiong.wang@arm.com>
3282
3283         * aarch64-linux-nat.c
3284         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3285         * aarch64-linux-tdep.c
3286         (aarch64_linux_core_read_description): Likewise.
3287         (aarch64_linux_get_hwcap): New function.
3288         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3289         (aarch64_linux_get_hwcap): New declaration.
3290
3291 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3292             Jiong Wang  <jiong.wang@arm.com>
3293
3294         * aarch64-linux-nat.c
3295         (aarch64_linux_nat_target::read_description): Add pauth param.
3296         * aarch64-linux-tdep.c
3297         (aarch64_linux_core_read_description): Likewise.
3298         * aarch64-tdep.c (struct target_desc): Add in pauth.
3299         (aarch64_read_description): Add pauth param.
3300         (aarch64_gdbarch_init): Likewise.
3301         * aarch64-tdep.h (aarch64_read_description): Likewise.
3302         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3303         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3304         * features/Makefile: Add new files.
3305         * features/aarch64-pauth.c: New file.
3306         * features/aarch64-pauth.xml: New file.
3307
3308 2019-03-20  Tom Tromey  <tromey@adacore.com>
3309
3310         * infrun.c (handle_inferior_event): Rename from
3311         handle_inferior_event_1.  Create a scoped_value_mark.
3312         (handle_inferior_event): Remove.
3313
3314 2019-03-19  Tom Tromey  <tromey@adacore.com>
3315
3316         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3317         * infrun.h (print_stop_event): Add "displays" parameter.
3318         * infrun.c (print_stop_event): Add "displays" parameter.
3319
3320 2019-03-19  Pedro Alves  <palves@redhat.com>
3321
3322         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3323         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3324         to -1.  Fix TABs vs spaces.
3325         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3326         * tui/tui-out.h (tui_ui_out) Add intro comments.
3327         <m_line, m_start_of_line>: In-class initialize, and add describing
3328         comment.
3329
3330 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3331
3332         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3333         variable names.
3334         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3335
3336 2019-03-18  Pedro Alves  <palves@redhat.com>
3337             Eli Zaretskii <eliz@gnu.org>
3338
3339         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3340         m_line and m_start_of_line.
3341
3342 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3343
3344         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3345         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3346         it returns a newline.  This fixes a regression in TU mode, whereby
3347         the next line is output on the same screen line as the user input.
3348
3349 2019-03-18  Tom Tromey  <tromey@adacore.com>
3350
3351         * minsyms.c (minimal_symbol_reader::install): Remove call to
3352         obstack_blank.
3353
3354 2019-03-18  Pedro Alves  <palves@redhat.com>
3355
3356         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3357         New globals.
3358         (apply_style): New, factored out from ...
3359         (apply_ansi_escape): ... this.  Handle reverse video mode.
3360         (tui_set_reverse_mode): New function.
3361         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3362         * tui/tui-winsource.c (tui_show_source_line): Use
3363         tui_set_reverse_mode instead of setting A_STANDOUT.
3364         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3365         New setter methods.
3366
3367 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3368
3369         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3370         Handle tabs.
3371
3372 2019-03-18  Tom Tromey  <tromey@adacore.com>
3373
3374         * ada-lang.c (empty_array): Add "high" parameter.
3375         (ada_evaluate_subexp): Update.
3376
3377 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3378
3379         * unittests/string_view-selftests.c: Define
3380         _initialize_string_view_selftests unconditionally.
3381
3382 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3383
3384         PR gdb/24350
3385         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3386
3387 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3388
3389         PR gdb/24351
3390         * windows-nat.c (display_selector): Fix format specifiers.
3391
3392 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3393
3394         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3395         tui_refill_source_window instead of tui_refresh_win, to update the
3396         current execution line.  This fixes redisplay of the current line
3397         when stepping through the code with "next" or "step".
3398
3399 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3400
3401         * source-cache.c (source_cache::get_source_lines): Call
3402         find_source_lines to initialize s->nlines.  This fixes vertical
3403         scrolling of TUI source window when the DOWN arrow is pressed.
3404
3405 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3406
3407         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3408         linux-thread-db.c (_initialize_thread_db): Likewise.
3409
3410 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3411
3412         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3413         wclrtoeol in tui_show_source_line".  This reverts changes made in
3414         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3415
3416 2019-03-15  Tom Tromey  <tom@tromey.com>
3417
3418         * symtab.h (struct minimal_symbol): Derive from
3419         general_symbol_info.
3420         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3421         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3422         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3423         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3424         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3425         (MSYMBOL_SEARCH_NAME): Update.
3426         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3427         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3428         * minsyms.c (minimal_symbol_reader::record_full): Update.
3429
3430 2019-03-15  Tom Tromey  <tom@tromey.com>
3431
3432         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3433
3434 2019-03-15  Tom Tromey  <tom@tromey.com>
3435
3436         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3437         unique_xmalloc_ptr.
3438         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3439         Update.
3440         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3441         (build_minimal_symbol_hash_tables)
3442         (minimal_symbol_reader::install): Update.
3443
3444 2019-03-15  Tom Tromey  <tom@tromey.com>
3445
3446         * symtab.c (create_demangled_names_hash): Update.
3447         (symbol_set_names): Update.
3448         * objfiles.h (struct objfile_per_bfd_storage)
3449         <demangled_names_hash>: Now an htab_up.
3450         * objfiles.c (objfile_per_bfd_storage): Simplify.
3451
3452 2019-03-15  Tom Tromey  <tom@tromey.com>
3453
3454         * objfiles.h (struct objfile_per_bfd_storage): Declare
3455         destructor.
3456         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3457         New.
3458         (get_objfile_bfd_data): Use new.  Don't initialize
3459         language_of_main.
3460         (free_objfile_per_bfd_storage): Remove.
3461         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3462
3463 2019-03-15  Tom Tromey  <tom@tromey.com>
3464
3465         * symfile.c (reread_symbols): Update.
3466         * objfiles.c (objfile::objfile): Update.
3467         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3468         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3469         comment.
3470         (minimal_symbol_reader::install): Update.
3471         (terminate_minimal_symbol_table): Remove.
3472         * jit.c (jit_object_close_impl): Update.
3473
3474 2019-03-15  Tom Tromey  <tom@tromey.com>
3475
3476         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3477         initializations.
3478
3479 2019-03-15  Tom Tromey  <tom@tromey.com>
3480
3481         * objfiles.h (struct objfile_per_bfd_storage)
3482         <demangled_hash_languages>: Now a bitset.
3483         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3484         (lookup_minimal_symbol): Update.
3485
3486 2019-03-15  Tom Tromey  <tom@tromey.com>
3487
3488         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3489         Don't return the symbol.
3490         * coffread.c (record_minimal_symbol): Use record_full.
3491
3492 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3493
3494         The MS-Windows port of ncurses fails to switch to a color pair if
3495         one or both of the colors are the implicit default colors.  This
3496         change records the default colors when TUI is initialized, and
3497         then specifies them explicitly when a color pair uses the default
3498         colors.  This allows color styling in TUI mode on MS-Windows.
3499
3500         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3501         ncurses_norm_attr.
3502         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3503         colors in ncurses_norm_attr.
3504         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3505         "none", replace it with the default color recorded in
3506         ncurses_norm_attr.
3507
3508 2019-03-14  Tom Tromey  <tromey@adacore.com>
3509
3510         * source-cache.h (class source_cache) <get_source_lines>: Return
3511         std::string.
3512         * source-cache.c (source_cache::extract_lines): Handle case where
3513         first_pos==npos.  Return std::string.
3514         (source_cache::get_source_lines): Update.
3515
3516 2019-03-14  Tom Tromey  <tromey@adacore.com>
3517
3518         * NEWS: Add item for "style sources" commands.
3519         * source-cache.c (source_cache::get_source_lines): Check
3520         source_styling.
3521         * cli/cli-style.c (source_styling): New global.
3522         (_initialize_cli_style): Add "style sources" commands.
3523         (show_style_sources): New function.
3524         * cli/cli-style.h (source_styling): Declare.
3525
3526 2019-03-14  Pedro Alves  <palves@redhat.com>
3527             Tom Tromey  <tromey@adacore.com>
3528
3529         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3530         * tui/tui-winsource.c (tui_refill_source_window): New function,
3531         from...
3532         (tui_horizontal_source_scroll): ... here.  Move some logic.
3533         * cli/cli-style.c (set_style_enabled): Notify new observable.
3534         * tui/tui-hooks.c (tui_redisplay_source): New function.
3535         (tui_attach_detach_observers): Attach or detach
3536         tui_redisplay_source.
3537         * observable.h (source_styling_changed): New observable.
3538         * observable.c: Define source_styling_changed observable.
3539
3540 2019-03-13  Tom Tromey  <tromey@adacore.com>
3541
3542         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3543         (i386_gnu_nat_target::store_registers): Update.
3544         * target-debug.h (target_debug_print_std_string): New macro.
3545         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3546         * windows-tdep.c (display_one_tib): Update.
3547         * tui/tui-stack.c (tui_make_status_line): Update.
3548         * top.c (print_inferior_quit_action): Update.
3549         * thread.c (thr_try_catch_cmd): Update.
3550         (add_thread_with_info): Update.
3551         (thread_target_id_str): Update.
3552         (thr_try_catch_cmd): Update.
3553         (thread_command): Update.
3554         (thread_find_command): Update.
3555         * record-btrace.c (record_btrace_target::info_record)
3556         (record_btrace_resume_thread, record_btrace_target::resume)
3557         (record_btrace_cancel_resume, record_btrace_step_thread)
3558         (record_btrace_target::wait, record_btrace_target::wait)
3559         (record_btrace_target::wait, record_btrace_target::stop): Update.
3560         * progspace.c (print_program_space): Update.
3561         * process-stratum-target.c
3562         (process_stratum_target::thread_address_space): Update.
3563         * linux-fork.c (linux_fork_mourn_inferior)
3564         (detach_checkpoint_command, info_checkpoints_command)
3565         (linux_fork_context): Update.
3566         (linux_fork_detach): Update.
3567         (class scoped_switch_fork_info): Update.
3568         (delete_checkpoint_command): Update.
3569         * infrun.c (follow_fork_inferior): Update.
3570         (follow_fork_inferior): Update.
3571         (proceed_after_vfork_done): Update.
3572         (handle_vfork_child_exec_or_exit): Update.
3573         (follow_exec): Update.
3574         (displaced_step_prepare_throw): Update.
3575         (displaced_step_restore): Update.
3576         (start_step_over): Update.
3577         (resume_1): Update.
3578         (clear_proceed_status_thread): Update.
3579         (proceed): Update.
3580         (print_target_wait_results): Update.
3581         (do_target_wait): Update.
3582         (context_switch): Update.
3583         (stop_all_threads): Update.
3584         (restart_threads): Update.
3585         (finish_step_over): Update.
3586         (handle_signal_stop): Update.
3587         (switch_back_to_stepped_thread): Update.
3588         (keep_going_pass_signal): Update.
3589         (print_exited_reason): Update.
3590         (normal_stop): Update.
3591         * inferior.c (inferior_pid_to_str): Change return type.
3592         (print_selected_inferior): Update.
3593         (add_inferior): Update.
3594         (detach_inferior): Update.
3595         * dummy-frame.c (fprint_dummy_frames): Update.
3596         * dcache.c (dcache_info_1): Update.
3597         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3598         (btrace_fetch, btrace_clear): Update.
3599         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3600         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3601         type.
3602         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3603         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3604         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3605         * gdbarch.c, gdbarch.h: Rebuild.
3606         * gdbarch.sh (core_pid_to_str): Change return type.
3607         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3608         return type.
3609         (windows_nat_target::pid_to_str): Change return type.
3610         (windows_delete_thread): Update.
3611         (windows_nat_target::attach): Update.
3612         (windows_nat_target::files_info): Update.
3613         * target-delegates.c: Rebuild.
3614         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3615         return type.
3616         (sol_thread_target::pid_to_str): Change return type.
3617         * remote.c (class remote_target) <pid_to_str>: Change return
3618         type.
3619         (remote_target::pid_to_str): Change return type.
3620         (extended_remote_target::attach, remote_target::remote_stop_ns)
3621         (remote_target::remote_notif_remove_queued_reply)
3622         (remote_target::push_stop_reply, remote_target::disable_btrace):
3623         Update.
3624         (extended_remote_target::attach): Update.
3625         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3626         type.
3627         (gdbsim_target::pid_to_str): Change return type.
3628         * ravenscar-thread.c (struct ravenscar_thread_target)
3629         <pid_to_str>: Change return type.
3630         (ravenscar_thread_target::pid_to_str): Change return type.
3631         * procfs.c (class procfs_target) <pid_to_str>: Change return
3632         type.
3633         (procfs_target::pid_to_str): Change return type.
3634         (procfs_target::attach): Update.
3635         (procfs_target::detach): Update.
3636         (procfs_target::fetch_registers): Update.
3637         (procfs_target::store_registers): Update.
3638         (procfs_target::wait): Update.
3639         (procfs_target::files_info): Update.
3640         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3641         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3642         return type.
3643         (nto_procfs_target::pid_to_str): Change return type.
3644         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3645         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3646         return type.
3647         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3648         (exit_lwp): Update.
3649         (attach_proc_task_lwp_callback, get_detach_signal)
3650         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3651         (linux_nat_target::resume, wait_lwp, stop_callback)
3652         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3653         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3654         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3655         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3656         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3657         type.
3658         (inf_ptrace_target::attach): Update.
3659         (inf_ptrace_target::files_info): Update.
3660         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3661         type.
3662         (go32_nat_target::pid_to_str): Change return type.
3663         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3664         (gnu_nat_target::wait): Update.
3665         (gnu_nat_target::wait): Update.
3666         (gnu_nat_target::resume): Update.
3667         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3668         (fbsd_nat_target::wait): Update.
3669         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3670         type.
3671         (darwin_nat_target::attach): Update.
3672         * corelow.c (class core_target) <pid_to_str>: Change return type.
3673         (core_target::pid_to_str): Change return type.
3674         * target.c (normal_pid_to_str): Change return type.
3675         (default_pid_to_str): Likewise.
3676         (target_pid_to_str): Change return type.
3677         (target_translate_tls_address): Update.
3678         (target_announce_detach): Update.
3679         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3680         return type.
3681         (bsd_uthread_target::pid_to_str): Change return type.
3682         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3683         type.
3684         (bsd_kvm_target::pid_to_str): Change return type.
3685         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3686         return type.
3687         (aix_thread_target::pid_to_str): Change return type.
3688         * target.h (struct target_ops) <pid_to_str>: Change return type.
3689         (target_pid_to_str, normal_pid_to_str): Likewise.
3690         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3691         type.
3692         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3693         type.
3694         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3695         return type.
3696         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3697         type.
3698         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3699         type.
3700         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3701         return type.
3702
3703 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3704
3705         * NEWS: Mention that the new default MI version is 3.  Mention
3706         changes to the output of commands and events that deal with
3707         multi-location breakpoints.
3708         * breakpoint.c: Include "mi/mi-out.h".
3709         (print_one_breakpoint): Change output syntax if using MI version
3710         >= 3.
3711         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3712         New.
3713         (mi_multi_location_breakpoint_output_fixed): New.
3714         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3715         (mi_cmd_fix_multi_location_breakpoint_output): New.
3716         (mi_multi_location_breakpoint_output_fixed): New.
3717         * mi/mi-cmds.c (mi_cmds): Register command
3718         -fix-multi-location-breakpoint-output.
3719         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3720         interpreter "mi".
3721
3722 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3723
3724         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3725         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3726         instantiate mi_ui_out based on interpreter name.
3727         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3728         * mi/mi-main.c (mi_load_progress): Likewise.
3729
3730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3731
3732         * NEWS: Combine separate "New targets" sections for 8.3.
3733
3734 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3735
3736         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3737         (ppcfbsd_init_abi): Install gdbarch
3738         "fetch_tls_load_module_address" and "get_thread_local_address"
3739         methods.
3740
3741 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3742
3743         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3744         (riscv_fbsd_init_abi): Install gdbarch
3745         "fetch_tls_load_module_address" and "get_thread_local_address"
3746         methods.
3747
3748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3749
3750         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3751         (i386fbsd_init_abi): Install gdbarch
3752         "fetch_tls_load_module_address" and "get_thread_local_address"
3753         methods.
3754
3755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3756
3757         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3758         (amd64fbsd_init_abi): Install gdbarch
3759         "fetch_tls_load_module_address" and "get_thread_local_address"
3760         methods.
3761
3762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3763
3764         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3765         (struct fbsd_pspace_data): New type.
3766         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3767         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3768         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3769         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3770         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3771
3772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3773
3774         * gdbtypes.c (lookup_struct_elt): New function.
3775         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3776         * gdbtypes.h (struct struct_elt): New type.
3777         (lookup_struct_elt): New prototype.
3778
3779 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3780
3781         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3782         remove disabled code block.
3783
3784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3785
3786         * gdbarch.sh (get_thread_local_address): New method.
3787         * gdbarch.h, gdbarch.c: Regenerate.
3788         * target.c (target_translate_tls_address): Use
3789         gdbarch_get_thread_local_address if present instead of
3790         target::get_thread_local_address.
3791
3792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3793
3794         * target.h (target::get_thread_local_address): Update comment.
3795
3796 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3797
3798         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3799         objfile->separate_debug_objfile_backlink if not NULL.
3800
3801 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3802
3803         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3804         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3805         (amd64bsd_store_inferior_registers): Likewise.
3806         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3807         Enable segment base registers.
3808         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3809         PT_GETFSBASE and PT_GETGSBASE.
3810         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3811         PT_SETGSBASE.
3812         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3813         segment base registers.
3814         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3815
3816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3817
3818         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3819         Update calls to i386_target_description to add 'segments'
3820         parameter.
3821         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3822         add segment base registers.
3823         * arch/i386.c (i386_create_target_description): Add 'segments'
3824         parameter to enable segment base registers.
3825         * arch/i386.h (i386_create_target_description): Likewise.
3826         * features/i386/32bit-segments.xml: New file.
3827         * features/i386/32bit-segments.c: Generate.
3828         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3829         call to i386_target_description to add 'segments' parameter.
3830         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3831         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3832         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3833         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3834         if feature is present.
3835         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3836         Add 'segments' parameter to call to i386_target_description.
3837         (i386_target_description): Add 'segments' parameter to enable
3838         segment base registers.
3839         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3840         to call to i386_target_description.
3841         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3842         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3843         Define I386_NUM_REGS.
3844         (i386_target_description): Add 'segments' parameter to enable
3845         segment base registers.
3846
3847 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3848
3849         PR/24325
3850         * source-cache.c: #undef open and close, to avoid unresolved
3851         externals during linking.
3852
3853 2019-03-12  Tom Tromey  <tromey@adacore.com>
3854
3855         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3856         const.  Add initializers.
3857         (_initialize_remote): Don't initialize ptid globals.
3858
3859 2019-03-12  Pedro Alves  <palves@redhat.com>
3860
3861         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3862
3863 2019-03-12  Pedro Alves  <palves@redhat.com>
3864
3865         * cp-name-parser.y (main): Remove unused 'len' variable.
3866
3867 2019-03-12  Tom Tromey  <tromey@adacore.com>
3868
3869         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3870         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3871
3872 2019-03-12  Tom Tromey  <tromey@adacore.com>
3873
3874         * linux-nat.c (iterate_over_lwps): Update.
3875         (stop_callback): Remove parameter.
3876         (stop_wait_callback, detach_callback, resume_set_callback)
3877         (select_singlestep_lwp_callback, set_ignore_sigint)
3878         (status_callback, resumed_callback, resume_clear_callback)
3879         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3880         data parameter.
3881         (linux_nat_target::detach, linux_nat_target::resume)
3882         (linux_stop_and_wait_all_lwps, select_event_lwp)
3883         (linux_nat_filter_event, linux_nat_wait_1)
3884         (linux_nat_target::kill, linux_nat_target::stop)
3885         (linux_nat_target::stop): Update.
3886         (linux_nat_resume_callback): Change type.
3887         (resume_stopped_resumed_lwps, count_events_callback)
3888         (select_event_lwp_callback): Likewise.
3889         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3890         * arm-linux-nat.c (struct update_registers_data): Remove.
3891         (update_registers_callback): Change type.
3892         (arm_linux_insert_hw_breakpoint1): Update.
3893         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3894         parameter.
3895         (x86_linux_dr_set_addr): Update.
3896         (x86_linux_dr_set_control): Update.
3897         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3898         (iterate_over_lwps): Use gdb::function_view.
3899         * nat/aarch64-linux-hw-point.c (struct
3900         aarch64_dr_update_callback_param): Remove.
3901         (debug_reg_change_callback): Change type.
3902         (aarch64_notify_debug_reg_change): Update.
3903         * s390-linux-nat.c (s390_refresh_per_info): Update.
3904
3905 2019-03-11  Tom Tromey  <tromey@adacore.com>
3906
3907         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3908         redundant assignment to "this_cu".
3909
3910 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3911
3912         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3913
3914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3915
3916         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3917         from...
3918         (rank_one_type): ... this.
3919
3920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3921
3922         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3923         from...
3924         (rank_one_type): ... this.
3925
3926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3927
3928         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3929         from...
3930         (rank_one_type): ... this.
3931
3932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3933
3934         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3935         from...
3936         (rank_one_type): ... this.
3937
3938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3939
3940         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3941         from...
3942         (rank_one_type): ... this.
3943
3944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3945
3946         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3947         from...
3948         (rank_one_type): ... this.
3949
3950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3951
3952         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3953         from...
3954         (rank_one_type): ... this.
3955
3956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3957
3958         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3959         from...
3960         (rank_one_type): ... this.
3961
3962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3963
3964         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3965         from...
3966         (rank_one_type): ... this.
3967
3968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3969
3970         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3971         from...
3972         (rank_one_type): ... this.
3973
3974 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3975
3976         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3977         from...
3978         (rank_one_type): ... this.
3979
3980 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3981
3982         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3983         from...
3984         (rank_one_type): ... this.
3985
3986 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3987
3988         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3989         inferior-events' shows the example events.
3990
3991 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3992
3993         Support styling on native MS-Windows console
3994
3995         PR/24315
3996         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3997         on MS-Windows if $TERM is not defined.
3998
3999         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4000
4001         * posix-hdep.c (gdb_console_fputs):
4002         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4003         functions.
4004         * ui-file.h (gdb_console_fputs): Add prototype.
4005
4006         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4007         back to fputs only if the former returns zero.
4008
4009 2019-03-07  Tom Tromey  <tom@tromey.com>
4010
4011         * symmisc.c (print_symbol_bcache_statistics): Update.
4012         (print_objfile_statistics): Update.
4013         * symfile.c (allocate_symtab): Update.
4014         * stabsread.c: Don't include bcache.h.
4015         * psymtab.h (struct psymbol_bcache): Don't declare.
4016         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4017         (psymbol_bcache_init, psymbol_bcache_free)
4018         (psymbol_bcache_get_bcache): Don't declare.
4019         * psymtab.c (struct psymbol_bcache): Remove.
4020         (psymtab_storage::psymtab_storage): Update.
4021         (psymtab_storage::~psymtab_storage): Update.
4022         (psymbol_bcache_init, psymbol_bcache_free)
4023         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4024         (add_psymbol_to_bcache): Update.
4025         (allocate_psymtab): Update.
4026         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4027         macro_cache>: No longer pointers.
4028         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4029         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4030         * macrotab.c (macro_bcache): Update.
4031         * macroexp.c: Don't include bcache.h.
4032         * gdbtypes.c (check_types_worklist): Update.
4033         (types_deeply_equal): Remove TRY/CATCH.  Update.
4034         * elfread.c (elf_symtab_read): Update.
4035         * dwarf2read.c: Don't include bcache.h.
4036         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4037         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4038         (print_bcache_statistics, bcache_memory_used): Don't declare.
4039         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4040         methods.  Rename all data members.
4041         * bcache.c (struct bcache): Move to bcache.h.
4042         (bcache::expand_hash_table): Rename from expand_hash_table.
4043         (bcache): Remove.
4044         (bcache::insert): Rename from bcache_full.
4045         (bcache::compare): Rename from bcache_compare.
4046         (bcache_xmalloc): Remove.
4047         (bcache::~bcache): Rename from bcache_xfree.
4048         (bcache::print_statistics): Rename from print_bcache_statistics.
4049         (bcache::memory_used): Rename from bcache_memory_used.
4050
4051 2019-03-07  Pedro Alves  <palves@redhat.com>
4052
4053         * infrun.c (normal_stop): Also check for
4054         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4055
4056 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4057
4058         * f-lang.c (value_from_host_double): Moved to...
4059         * value.c (value_from_host_double): ...here.
4060         * value.h (value_from_host_double): Declare.
4061         * guile/scm-math.c (vlscm_convert_typed_number): Use
4062         value_from_host_double.
4063         (vlscm_convert_number): Likewise.
4064         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4065         * python/py-value.c (convert_value_from_python): Likewise.
4066
4067 2019-03-06  Tom Tromey  <tom@tromey.com>
4068
4069         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4070
4071 2019-03-06  Tom Tromey  <tom@tromey.com>
4072
4073         * utils.h (free_current_contents): Don't declare.
4074         * utils.c (free_current_contents): Remove.
4075
4076 2019-03-06  Tom Tromey  <tom@tromey.com>
4077
4078         * top.c (quit_force): Update.
4079         * main.c (captured_command_loop): Update.
4080         * common/new-op.c (operator new): Update.
4081         * common/common-exceptions.c (struct catcher)
4082         <save_cleanup_chain>: Remove member.
4083         (exceptions_state_mc_init): Update.
4084         (exception_try_scope_entry): Return nullptr.
4085         (exception_try_scope_exit, exception_rethrow)
4086         (throw_exception_sjlj, throw_exception_cxx): Update.
4087         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4088         (all_cleanups, do_cleanups, discard_cleanups)
4089         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4090         (restore_cleanups, restore_final_cleanups): Don't declare.
4091         (do_final_cleanups): Remove parameter.
4092         * common/cleanups.c (cleanup_chain, make_cleanup)
4093         (make_cleanup_dtor, all_cleanups, do_cleanups)
4094         (discard_my_cleanups, discard_cleanups)
4095         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4096         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4097         (null_cleanup): Remove.
4098         (do_final_cleanups): Remove parameter.
4099
4100 2019-03-06  Tom Tromey  <tom@tromey.com>
4101
4102         * remote.c (remote_target::remote_parse_stop_reply): Use
4103         unique_xmalloc_ptr.
4104
4105 2019-03-06  Tom Tromey  <tom@tromey.com>
4106
4107         * stabsread.c (struct stabs_field_info): Rename from field_info.
4108         <list, fnlist>: Add initializers.
4109         <obstack>: New member.
4110         (read_member_functions, read_struct_fields, read_baseclasses):
4111         Allocate on obstack.  Don't use cleanups.
4112         (read_one_struct_field, read_member_functions, read_struct_fields)
4113         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4114         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4115         (read_struct_type): Update.
4116
4117 2019-03-06  Tom Tromey  <tom@tromey.com>
4118
4119         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4120         * common/filestuff.h (make_cleanup_close): Don't declare.
4121         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4122         Remove.
4123
4124 2019-03-06  Tom Tromey  <tom@tromey.com>
4125
4126         * solib-aix.c: Use make_scope_exit.
4127
4128 2019-03-06  Tom Tromey  <tom@tromey.com>
4129
4130         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4131         Use make_scope_exit.
4132
4133 2019-03-06  Tom Tromey  <tom@tromey.com>
4134
4135         * solib-svr4.c (disable_probes_interface): Remove parameter.
4136         (svr4_handle_solib_event): Use make_scope_exit.
4137
4138 2019-03-06  Tom Tromey  <tom@tromey.com>
4139
4140         * remote.c (struct stop_reply_deleter): Remove.
4141         (stop_reply_up): Update.
4142         (struct stop_reply): Derive from notif_event.  Don't typedef.
4143         <regcache>: Now a std::vector.
4144         (stop_reply_xfree): Remove.
4145         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4146         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4147         (remote_target::discard_pending_stop_replies): Use delete.
4148         (remote_target::remote_parse_stop_reply): Update.
4149         (remote_target::process_stop_reply): Update.
4150         * remote-notif.h (struct notif_event): Add virtual destructor.
4151         Remove "dtr" member.
4152         (struct notif_client) <alloc_event>: Return a unique_ptr.
4153         (notif_event_xfree): Don't declare.
4154         (notif_event_up): New typedef.
4155         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4156         (notif_event_xfree, do_notif_event_xfree): Remove.
4157         (remote_notif_state_xfree): Update.
4158
4159 2019-03-06  Tom Tromey  <tom@tromey.com>
4160
4161         * infrun.c (displaced_step_clear_cleanup): Now a
4162         forward_scope_exit type.
4163         (displaced_step_prepare_throw): Update.
4164         (displaced_step_fixup): Update.
4165
4166 2019-03-06  Tom Tromey  <tom@tromey.com>
4167
4168         * inferior.h (class inferior): Update comment.
4169         * gdbthread.h (class thread_info): Update comment.
4170
4171 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4172             Tom Tromey  <tom@tromey.com>
4173
4174         * stabsread.h (struct stab_section_list): Remove.
4175         (coffstab_build_psymtabs): Update.
4176         * dbxread.c (symbuf_sections): Now a std::vector.
4177         (sect_idx): New global.
4178         (fill_symbuf): Update.
4179         (coffstab_build_psymtabs): Change type of stabsects parameter.
4180         Update.
4181         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4182         std::vector.
4183         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4184         (coff_locate_sections): Update.
4185         (coff_symfile_read): Remove cleanups.  Update.
4186         (init_stringtab): Add storage parameter.
4187         (free_stringtab, free_stringtab_cleanup): Remove.
4188         (init_lineno): Add storage parameter.
4189         (free_linetab, free_linetab_cleanup): Remove.
4190
4191 2019-03-06  Pedro Alves  <palves@redhat.com>
4192
4193         * linux-fork.c (fork_info::clobber_regs): Delete.
4194         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4195         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4196         comment.  Adjust.
4197         (scoped_switch_fork_info::scoped_switch_fork_info)
4198         (checkpoint_command, linux_fork_context): Adjust
4199         fork_save_infrun_state calls.
4200
4201 2019-03-06  Pedro Alves  <palves@redhat.com>
4202
4203         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4204         (inf_has_multiple_threads): Return 'bool' and rewrite using
4205         inferior_info::threads().
4206
4207 2019-03-06  Pedro Alves  <palves@redhat.com>
4208
4209         * linux-fork.c: Include <list>.
4210         (fork_list): Now a std::list instance.
4211         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4212         (forks_exist_p, find_last_fork): Adjust.
4213         (new_fork): Delete.
4214         (one_fork_p): New.
4215         (add_fork): Adjust.
4216         (free_fork): Delete, folded into fork_info::~fork_info().
4217         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4218         Adjust.
4219         (init_fork_list): Delete.
4220         (linux_fork_killall, linux_fork_mourn_inferior)
4221         (linux_fork_detach, info_checkpoints_command): Adjust.
4222         (_initialize_linux_fork): No longer call init_fork_list.
4223
4224 2019-03-06  Pedro Alves  <palves@redhat.com>
4225
4226         * linux-fork.c (new_fork): New, split out of ...
4227         (add_fork): ... this.  Return void.  Move "first fork" special
4228         case from here, to ...
4229         (checkpoint_command): ... here.
4230         * linux-linux.h (add_fork): Return void.
4231
4232 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4233
4234         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4235
4236 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4237             Chris January  <chris.january@arm.com>
4238             David Lecomber  <david.lecomber@arm.com>
4239
4240         * f-exp.y: New token, UNOP_INTRINSIC.
4241         (exp): New pattern using UNOP_INTRINSIC token.
4242         (f77_keywords): Add 'abs' keyword.
4243         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4244         (value_from_host_double): New function.
4245         (evaluate_subexp_f): Support UNOP_ABS.
4246
4247 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4248
4249         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4250         types.
4251
4252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4253
4254         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4255         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4256         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4257
4258 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4259
4260         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4261
4262 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4263             Chris January  <chris.january@arm.com>
4264
4265         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4266         * f-exp.y: Define 'KIND' token.
4267         (exp): New pattern for KIND expressions.
4268         (ptype): Handle types with a kind extension.
4269         (direct_abs_decl): Extend to spot kind extensions.
4270         (f77_keywords): Add 'kind' to the list.
4271         (push_kind_type): New function.
4272         (convert_to_kind_type): New function.
4273         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4274         * parse.c (operator_length_standard): Likewise.
4275         * parser-defs.h (enum type_pieces): Add tp_kind.
4276         * std-operator.def: Add UNOP_KIND.
4277
4278 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4279
4280         * f-exp.y (f_parse): Set yydebug.
4281
4282 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * f-lang.c (evaluate_subexp_f): New function.
4285         (exp_descriptor_f): New global.
4286         (f_language_defn): Use exp_descriptor_f instead of
4287         exp_descriptor_standard.
4288
4289 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * f-exp.y (struct token): Add comments.
4292         (dot_ops): Remove uppercase versions and the end marker.
4293         (f77_keywords): Likewise.
4294         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4295         entries in the dot_ops array are case insensitive, and use
4296         strncasecmp to compare strings.  Also some whitespace cleanup in
4297         this area.  Similar for the f77_keywords array, except entries in
4298         this list might be case sensitive.
4299
4300 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4301
4302         * f-exp.y (struct f77_boolean_val): Add comments.
4303         (boolean_values): Remove uppercase versions, and end marker.
4304         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4305         and use strncasecmp to achieve case insensitivity.  Additionally,
4306         perform whitespace cleanup around this code.
4307
4308 2019-03-06  Tom Tromey  <tromey@adacore.com>
4309
4310         * remote-sim.c (gdbsim_target_open): Use result of
4311         gdb_argv::release.
4312
4313 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4314         Dirk Schubert  <dirk.schubert@arm.com>
4315         Chris January  <chris.january@arm.com>
4316
4317         * eval.c (evaluate_subexp_standard): Call Fortran argument
4318         wrapping logic.
4319         * f-lang.c (struct value): A value which can be passed into a
4320         Fortran function call.
4321         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4322         where appropriate.
4323         (struct type): Value ready for a Fortran function call.
4324         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4325         is needed.
4326         * f-lang.h (fortran_argument_convert): Declaration.
4327         (fortran_preserve_arg_pointer): Declaration.
4328         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4329
4330 2019-03-05  Tom Tromey  <tromey@adacore.com>
4331
4332         * python/py-prettyprint.c (print_string_repr): Remove #if.
4333         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4334
4335 2019-03-05  Tom Tromey  <tromey@adacore.com>
4336
4337         * target.c (the_dummy_target): Move later.  Change type to
4338         "dummy_target".
4339         (initialize_targets): Don't initialize the_dummy_target.
4340
4341 2019-03-05  Tom Tromey  <tromey@adacore.com>
4342
4343         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4344         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4345
4346 2019-03-05  Tom Tromey  <tromey@adacore.com>
4347
4348         * windows-nat.c (windows_nat_target::attach)
4349         (windows_nat_target::detach): Don't call gdb_flush.
4350         * valprint.c (generic_val_print, val_print, val_print_string):
4351         Don't call gdb_flush.
4352         * utils.c (defaulted_query): Don't call gdb_flush.
4353         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4354         * target.c (target_announce_detach): Don't call gdb_flush.
4355         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4356         * remote.c (extended_remote_target::attach): Don't call
4357         gdb_flush.
4358         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4359         * printcmd.c (do_examine): Don't call gdb_flush.
4360         (info_display_command): Don't call gdb_flush.
4361         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4362         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4363         * memattr.c (info_mem_command): Don't call gdb_flush.
4364         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4365         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4366         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4367         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4368         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4369         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4370         (gnu_nat_target::detach): Don't call gdb_flush.
4371         * f-valprint.c (f_val_print): Don't call gdb_flush.
4372         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4373         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4374         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4375         gdb_flush.
4376         * c-valprint.c (c_val_print): Don't call gdb_flush.
4377         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4378
4379 2019-03-05  Tom Tromey  <tromey@adacore.com>
4380
4381         * varobj.c (update_dynamic_varobj_children): Update.
4382         (install_default_visualizer): Use reset, not release.
4383         * value.c (set_internalvar): Update.
4384         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4385         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4386         ATTRIBUTE_UNUSED_RESULT.
4387
4388 2019-03-05  Tom Tromey  <tromey@adacore.com>
4389
4390         * remote.c (class scoped_remote_fd) <release>: Add
4391         ATTRIBUTE_UNUSED_RESULT.
4392
4393 2019-03-05  Tom Tromey  <tromey@adacore.com>
4394
4395         * macroexp.c (struct macro_buffer) <release>: Add
4396         ATTRIBUTE_UNUSED_RESULT.
4397
4398 2019-03-05  Tom Tromey  <tromey@adacore.com>
4399
4400         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4401         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4402         ATTRIBUTE_UNUSED_RESULT.
4403
4404 2019-03-05  Tom Tromey  <tromey@adacore.com>
4405
4406         * common/scoped_fd.h (class scoped_fd) <release>: Add
4407         ATTRIBUTE_UNUSED_RESULT.
4408
4409 2019-03-05  Tom Tromey  <tromey@adacore.com>
4410
4411         * parser-defs.h (struct parser_state) <release>: Add
4412         ATTRIBUTE_UNUSED_RESULT.
4413
4414 2019-03-05  Tom Tromey  <tromey@adacore.com>
4415
4416         * utils.h (class gdb_argv) <release>: Add
4417         ATTRIBUTE_UNUSED_RESULT.
4418         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4419
4420 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4421
4422         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4423         for-loop range, to avoid compiler warnings.
4424
4425         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4426         avoid compiler warnings about unused variables.
4427
4428         * NEWS: Mention end of support for native debugging on MS-Windows
4429         before XP.
4430
4431         PR gdb/24292
4432         * common/netstuff.c:
4433         * gdbserver/gdbreplay.c
4434         * gdbserver/remote-utils.c:
4435         * ser-tcp.c:
4436         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4437         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4438         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4439         'getaddrinfo' and 'freeaddrinfo' were not available before
4440         Windows XP, and mingw.org's MinGW headers by default define
4441         _WIN32_WINNT to 0x500.
4442
4443 2019-03-01  Gary Benson <gbenson@redhat.com>
4444
4445         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4446
4447 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4448             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4449
4450         PR gdb/8527
4451         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4452         set_sigint_trap, clear_sigint_trap.
4453
4454 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4455
4456         * target.c (target_detach): Clear the regcache and the
4457         frame cache.
4458
4459 2019-02-27  Pedro Alves  <palves@redhat.com>
4460
4461         * utils.c (set_screen_size): When we cap the height/width sizes,
4462         tweak the corresponding command variable to show "unlimited":
4463
4464 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4465             Pedro Alves  <palves@redhat.com>
4466
4467         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4468         before calling rl_set_screen_size.
4469
4470 2019-02-27  Tom Tromey  <tromey@adacore.com>
4471
4472         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4473         define.
4474         * python/py-value.c: Remove Python 2.4 workaround.
4475         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4476         workaround.
4477         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4478         Python 2.4 workaround.
4479         * python/python-internal.h: Remove Python 2.4 comment.
4480         (Py_ssize_t): Don't define.
4481         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4482         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4483         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4484         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4485         * python/python.c (do_start_initialization): Remove Python 2.4
4486         workaround.
4487         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4488         (print_children): Remove Python 2.4 workaround.
4489         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4490         workaround.
4491         (CHARBUFFERPROC_NAME): Remove.
4492         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4493         Python 2.4 workaround.
4494
4495 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4496
4497         * NEWS: Note minimum Python version.
4498
4499 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4500
4501         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4502         code from these functions.  Remove corresponding ifdefs.  Use
4503         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4504         Remove gotos and target of gotos.
4505         (infpy_search_memory): Likewise.
4506
4507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4510         (hppa_gdbarch_init): Don't register deleted functions with
4511         gdbarch.
4512
4513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4516         (h8300_unwind_sp): Delete.
4517         (h8300_dummy_id): Delete.
4518         (h8300_gdbarch_init): Don't register deleted functions with
4519         gdbarch.
4520
4521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4524         (ft32_unwind_pc): Delete.
4525         (ft32_unwind_sp): Delete.
4526         (ft32_gdbarch_init): Don't register deleted functions with
4527         gdbarch.
4528
4529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4532         (frv_unwind_pc): Delete.
4533         (frv_unwind_sp): Delete.
4534         (frv_gdbarch_init): Don't register deleted functions with
4535         gdbarch.
4536
4537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4538
4539         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4540         (riscv_unwind_pc): Delete.
4541         (riscv_unwind_sp): Delete.
4542         (riscv_gdbarch_init): Don't register deleted functions with
4543         gdbarch.
4544
4545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4548         (csky_unwind_pc): Delete.
4549         (csky_unwind_sp): Delete.
4550         (csky_gdbarch_init): Don't register deleted functions with
4551         gdbarch.
4552
4553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4554
4555         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4556         (cris_unwind_pc): Delete.
4557         (cris_unwind_sp): Delete.
4558         (cris_gdbarch_init): Don't register deleted functions with
4559         gdbarch.
4560
4561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4562
4563         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4564         (bfin_unwind_pc): Delete.
4565         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4566
4567 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4568
4569         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4570         (arm_unwind_pc): Delete.
4571         (arm_unwind_sp): Delete.
4572         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4573
4574 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4575
4576         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4577         (arc_unwind_pc): Delete.
4578         (arc_unwind_sp): Delete.
4579         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4580
4581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4582
4583         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4584         (alpha_unwind_pc): Delete.
4585         (alpha_gdbarch_init): Don't register deleted functions with
4586         gdbarch.
4587
4588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4591         (aarch64_unwind_pc): Delete.
4592         (aarch64_unwind_sp): Delete.
4593         (aarch64_gdbarch_init): Don't register deleted functions with
4594         gdbarch.
4595
4596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * gdbtypes.c (type_align): Don't consider static members when
4599         computing structure alignment.
4600
4601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4604         return 0 for other types.
4605         * arch-utils.c (default_type_align): Always return 0.
4606         * gdbarch.h: Regenerate.
4607         * gdbarch.sh (type_align): Extend comment.
4608         * gdbtypes.c (type_align): Add additional comments, always call
4609         gdbarch_type_align before applying the default rules.
4610         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4611         generic code will then apply a suitable default.
4612         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4613         types, return 0 for other types.
4614
4615 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4616
4617         * NEWS: Create a new section for the next release branch.
4618         Rename the section of the current branch, now that it has
4619         been cut.
4620
4621 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4622
4623         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4624         * version.in: Bump version to 8.3.50.DATE-git.
4625
4626 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4627
4628         * aix-thread.c (ptid_cmp): Remove unused variable.
4629         (get_signaled_thread): Likewise.
4630         (store_regs_user_thread): Likewise.
4631         (store_regs_kernel_thread): Likewise.
4632         (fetch_regs_kernel_thread): Remove shadowed variable.
4633
4634 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * features/riscv/32bit-cpu.xml: Add register numbers.
4637         * features/riscv/32bit-fpu.c: Regenerate.
4638         * features/riscv/32bit-fpu.xml: Add register numbers.
4639         * features/riscv/64bit-cpu.xml: Add register numbers.
4640         * features/riscv/64bit-fpu.c: Regenerate.
4641         * features/riscv/64bit-fpu.xml: Add register numbers.
4642
4643 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4644
4645         * NEWS: Mention two argument form of gdb.Value constructor.
4646         * python/py-value.c (convert_buffer_and_type_to_value): New
4647         function.
4648         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4649         Add support for handling an optional second argument.  Call
4650         convert_buffer_and_type_to_value as appropriate.
4651         * python/python-internal.h (Py_buffer_deleter): New struct.
4652         (Py_buffer_up): New typedef.
4653
4654 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4655
4656         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4657         instead of releasing ownership.
4658
4659 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4660
4661         * dwarf2read.c (open_and_init_dwp_file): Call
4662         elf_numsections instead of bfd_count_sections to initialize
4663         dwp_file->num_sections.
4664
4665 2019-02-25  Tom Tromey  <tromey@adacore.com>
4666
4667         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4668
4669 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4670
4671         * gcore.in: Add '--readnever' option when invoking GDB.
4672
4673 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4674
4675         * MAINTAINERS: Update my email address.
4676
4677 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4678
4679         * build-id.c (build_id_to_debug_bfd_1): New function.
4680         (build_id_to_debug_bfd): Look for separate debug file in
4681         sysroot.
4682
4683 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4684
4685         * gdbarch.sh: Update the copyright year range that is placed into
4686         generated files.
4687
4688 2019-02-22  Keith Seitz  <keiths@redhat.com>
4689
4690         PR symtab/23853
4691         * linespec.c (create_sals_line_offset): Search for the default
4692         symtab's filename instead of its fullname.
4693
4694 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4695
4696         * NEWS: Update style defaults.
4697
4698 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4699
4700         * main.c (captured_main_1): Disable styling in batch mode.
4701
4702 2019-02-20  Tom Tromey  <tom@tromey.com>
4703
4704         * symtab.c (symtab_symbol_info): Fix typos.
4705
4706 2019-02-20  Tom Tromey  <tromey@adacore.com>
4707
4708         * findcmd.c (_initialize_mem_search): Use upper case for
4709         metasyntactic variables.
4710
4711 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4712
4713         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4714         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4715
4716 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4717
4718         * top.h (source_file_name): Change to std::string.
4719         * top.c (source_file_name): Likewise.
4720         (command_line_input): Adjust.
4721         * cli/cli-script.c (script_from_file): Adjust.
4722
4723 2019-02-19  Tom Tromey  <tromey@adacore.com>
4724
4725         * ravenscar-thread.c
4726         (ravenscar_thread_target::update_thread_list): Don't call
4727         ada_build_task_list.
4728         * ada-lang.h (ada_build_task_list): Don't declare.
4729         * ada-tasks.c (struct ada_tasks_inferior_data)
4730         <task_list_valid_p>: Now bool.
4731         (read_known_tasks, ada_task_list_changed)
4732         (ada_tasks_invalidate_inferior_data): Update.
4733         (read_known_tasks_array): Return bool.
4734         (read_known_tasks_list): Likewise.
4735         (read_known_tasks): Return void.
4736         (ada_build_task_list): Now static.
4737
4738 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4739
4740         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4741         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4742
4743 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4744
4745         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4746         variant for ada_tasks_pspace_data_handle and
4747         ada_tasks_inferior_data_handle.
4748         (ada_tasks_pspace_data_cleanup): New function.
4749         (ada_tasks_inferior_data_cleanup): New function.
4750
4751 2019-02-17  Tom Tromey  <tom@tromey.com>
4752
4753         * macrotab.h (macro_source_fullname): Return a std::string.
4754         * macrotab.c (macro_include, check_for_redefinition)
4755         (macro_undef, macro_lookup_definition, foreach_macro)
4756         (foreach_macro_in_scope): Update.
4757         (macro_source_fullname): Return a std::string.
4758         * macrocmd.c (show_pp_source_pos): Update.
4759
4760 2019-02-17  Tom Tromey  <tom@tromey.com>
4761
4762         * macrocmd.c (show_pp_source_pos): Style the file names.
4763
4764 2019-02-17  Tom Tromey  <tom@tromey.com>
4765
4766         PR tui/24197:
4767         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4768
4769 2019-02-17  Tom Tromey  <tom@tromey.com>
4770
4771         * ada-lang.c (user_select_syms): Use filtered printing.
4772         * utils.c (wrap_style): New global.
4773         (desired_style): Remove.
4774         (emit_style_escape): Add stream parameter.
4775         (set_output_style, reset_terminal_style, prompt_for_continue):
4776         Update.
4777         (flush_wrap_buffer): Only flush gdb_stdout.
4778         (wrap_here): Set wrap_style.
4779         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4780         treat escape sequences as a character.  Change when wrap buffer is
4781         flushed.
4782         (fputs_styled): Do not set the output style when the default is
4783         requested.
4784         * ui-style.h (struct ui_file_style) <is_default>: New method.
4785         * source.c (print_source_lines_base): Emit escape sequences in one
4786         piece.
4787
4788 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4789
4790         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4791         integers and enumeration types.
4792
4793 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4794
4795         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4796         instead of lookup_symbol_in_language
4797         (do_exact_match): New function.
4798         (ada_get_symbol_name_matcher): Return do_exact_match when
4799         doing a verbatim match.
4800
4801 2019-02-15  Tom Tromey  <tromey@adacore.com>
4802
4803         * ravenscar-thread.c (ravenscar_thread_target::resume)
4804         (ravenscar_thread_target::wait): Special case wildcard requests.
4805
4806 2019-02-15  Tom Tromey  <tromey@adacore.com>
4807
4808         * ravenscar-thread.c (base_ptid): Remove.
4809         (struct ravenscar_thread_target) <close>: New method.
4810         <m_base_ptid>: New member.
4811         <update_inferior_ptid, active_task, task_is_currently_active,
4812         runtime_initialized>: Declare methods.
4813         <ravenscar_thread_target>: Add constructor.
4814         (ravenscar_thread_target::task_is_currently_active)
4815         (ravenscar_thread_target::update_inferior_ptid)
4816         (ravenscar_runtime_initialized): Rename.  Now methods.
4817         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4818         (ravenscar_thread_target::update_thread_list): Update.
4819         (ravenscar_thread_target::active_task): Now method.
4820         (ravenscar_thread_target::store_registers)
4821         (ravenscar_thread_target::prepare_to_store)
4822         (ravenscar_thread_target::prepare_to_store)
4823         (ravenscar_thread_target::mourn_inferior): Update.
4824         (ravenscar_inferior_created): Use "new" to create target.
4825         (ravenscar_thread_target::get_ada_task_ptid): Update.
4826         (_initialize_ravenscar): Don't initialize base_ptid.
4827         (ravenscar_ops): Remove global.
4828
4829 2019-02-15  Tom Tromey  <tromey@adacore.com>
4830
4831         * target.h (push_target): Declare new overload.
4832         * target.c (push_target): New overload, taking an rvalue reference.
4833         * remote.c (remote_target::open_1): Use push_target overload.
4834         * corelow.c (core_target_open): Use push_target overload.
4835
4836 2019-02-15  Tom Tromey  <tromey@adacore.com>
4837
4838         * ravenscar-thread.c (is_ravenscar_task)
4839         (ravenscar_task_is_currently_active): Return bool.
4840         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4841         (_initialize_ravenscar): Remove "(void)".
4842         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4843         Return bool.
4844
4845 2019-02-15  Tom Tromey  <tromey@adacore.com>
4846
4847         * ravenscar-thread.c (ravenscar_runtime_initializer)
4848         (has_ravenscar_runtime, get_running_thread_id)
4849         (ravenscar_thread_target::resume): Fix indentation.
4850
4851 2019-02-15  Tom Tromey  <tromey@adacore.com>
4852
4853         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4854         from ravenscar_arch_ops.
4855         (sparc_ravenscar_ops::fetch_registers)
4856         (sparc_ravenscar_ops::store_registers): Now methods.
4857         (sparc_ravenscar_prepare_to_store): Remove.
4858         (sparc_ravenscar_ops): Redefine.
4859         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4860         methods and destructor.  Remove members.
4861         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4862         (ravenscar_thread_target::store_registers)
4863         (ravenscar_thread_target::prepare_to_store): Update.
4864         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4865         Remove.
4866         (struct ppc_ravenscar_powerpc_ops): Derive from
4867         ravenscar_arch_ops.
4868         (ppc_ravenscar_powerpc_ops::fetch_registers)
4869         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4870         (ppc_ravenscar_powerpc_ops): Redefine.
4871         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4872         (ppc_ravenscar_e500_ops::fetch_registers)
4873         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4874         (ppc_ravenscar_e500_ops): Redefine.
4875         * aarch64-ravenscar-thread.c
4876         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4877         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4878         (aarch64_ravenscar_fetch_registers)
4879         (aarch64_ravenscar_store_registers): Now methods.
4880         (aarch64_ravenscar_ops): Redefine.
4881
4882 2019-02-15  Tom Tromey  <tromey@adacore.com>
4883
4884         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4885         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4886         (ravenscar_thread_target::stopped_by_watchpoint)
4887         (ravenscar_thread_target::stopped_data_address)
4888         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4889
4890 2019-02-15  Tom Tromey  <tromey@adacore.com>
4891
4892         * ravenscar-thread.c: Fix some typos.
4893
4894 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4895             Tom Tromey  <tromey@adacore.com>
4896
4897         * ada-lang.c (ada_exception_sal): Change addr_string to a
4898         std::string.
4899         (create_ada_exception_catchpoint): Update.
4900
4901 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4902             Tom Tromey  <tromey@adacore.com>
4903
4904         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4905         (bp_location_ops): Remove.
4906         (base_breakpoint_allocate_location): Update.
4907         (free_bp_location): Update.
4908         * ada-lang.c (class ada_catchpoint_location)
4909         <ada_catchpoint_location>: Remove ops parameter.
4910         (ada_catchpoint_location_dtor): Remove.
4911         (ada_catchpoint_location_ops): Remove.
4912         (allocate_location_exception): Update.
4913         * breakpoint.h (struct bp_location_ops): Remove.
4914         (class bp_location) <bp_location>: Remove bp_location_ops
4915         parameter.
4916         <~bp_location>: Add destructor.
4917         <ops>: Remove.
4918
4919 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4920             Pedro Alves  <palves@redhat.com>
4921
4922         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4923         'PATH_MAX'.
4924
4925 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4926             Samuel Thibault  <samuel.thibault@gnu.org>
4927             Thomas Schwinge  <thomas@codesourcery.com>
4928
4929         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4930         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4931
4932 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4933
4934         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4935         (check_empty): Use "const char *".
4936
4937         * gnu-nat.c (gnu_nat_target::detach): Instead of
4938         'detach_inferior (pid)' call
4939         'detach_inferior (find_inferior_pid (pid))'.
4940
4941         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4942         'nat/fork-inferior.o'.
4943         * gnu-nat.c: #include "nat/fork-inferior.h".
4944
4945         * gnu-nat.c (gnu_nat_target::detach): Instead of
4946         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4947         * gnu-nat.h: #include "inf-child.h".
4948         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4949         'i386_gnu_nat_target::fetch_registers'.
4950         (gnu_store_registers): Rename/move to
4951         'i386_gnu_nat_target::store_registers'.
4952
4953         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4954         * gnu-nat.h (mach_thread_info): New function.
4955         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4956
4957         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4958
4959 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4960
4961         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4962
4963 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4964
4965         * windows-nat.c (windows_add_thread): Add new parameter
4966         "main_thread_p" with default value set to false.  Update
4967         function documentation as well as all callers.
4968         (windows_delete_thread): Likewise.
4969         (fake_create_process): Update call to windows_add_thread.
4970         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4971         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4972         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4973         call to windows_delete_thread.
4974
4975 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4976
4977         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4978
4979 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4980
4981         * symfile.c (find_separate_debug_file): Use canonical path of
4982         sysroot with child_path instead of gdb_sysroot if it is valid.
4983
4984 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4985
4986         * symfile.c (find_separate_debug_file): Use child_path to
4987         determine if an object file is under a sysroot.
4988
4989 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4990
4991         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4992         unittests/child-path-selftests.c.
4993         * common/pathstuff.c (child_path): New function.
4994         * common/pathstuff.h (child_path): New prototype.
4995         * unittests/child-path-selftests.c: New file.
4996
4997 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4998
4999         * symfile.c (find_separate_debug_file): Look for separate debug
5000         files in debug directories under the sysroot.
5001
5002 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5003
5004         * symtab.h (struct minimal_symbol data_p): New const method.
5005         (struct minimal_symbol text_p): Likewise.
5006         * symtab.c (output_source_filename): Use file name style
5007         to print file name.
5008         (print_symbol_info): Likewise.
5009         (print_msymbol_info): Use address style to print addresses.
5010         Use function name style to print executable text symbols.
5011         (expand_symtab_containing_pc): Use data_p.
5012         (find_pc_sect_compunit_symtab): Likewise.
5013
5014 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5015
5016         * breakpoint.c (describe_other_breakpoints): Use address style
5017         to print addresses.
5018         (say_where): Likewise.
5019
5020 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5021
5022         * ada-typeprint.c (print_func_type): Print function name
5023         style to print function name.
5024         * c-typeprint.c (c_print_type_1): Likewise.
5025
5026 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5027
5028         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5029         for execve.
5030
5031 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5032
5033         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5034         type_stack.
5035
5036 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5037
5038         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5039         TYPE_CODE_REF types.
5040
5041 2019-02-08  Jim Wilson  <jimw@sifive.com>
5042
5043         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5044         (riscv_linux_fregset): New.
5045         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5046
5047 2019-02-07  Tom Tromey  <tom@tromey.com>
5048
5049         * thread.c (thread_cancel_execution_command): Update.
5050         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5051         methods.
5052         (struct thread_fsm_ops): Remove.
5053         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5054         (thread_fsm_should_stop, thread_fsm_return_value)
5055         (thread_fsm_set_finished, thread_fsm_finished_p)
5056         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5057         Don't declare.
5058         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5059         * infrun.c (clear_proceed_status_thread)
5060         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5061         (print_stop_event): Update.
5062         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5063         Add constructor.
5064         (step_command_fsm_ops): Remove.
5065         (new_step_command_fsm): Remove.
5066         (step_1): Update.
5067         (step_command_fsm::should_stop): Rename from
5068         step_command_fsm_should_stop.
5069         (step_command_fsm::clean_up): Rename from
5070         step_command_fsm_clean_up.
5071         (step_command_fsm::do_async_reply_reason): Rename from
5072         step_command_fsm_async_reply_reason.
5073         (struct until_next_fsm): Inherit from thread_fsm.  Add
5074         constructor.
5075         (until_next_fsm_ops): Remove.
5076         (new_until_next_fsm): Remove.
5077         (until_next_fsm::should_stop): Rename from
5078         until_next_fsm_should_stop.
5079         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5080         (until_next_fsm::do_async_reply_reason): Rename from
5081         until_next_fsm_async_reply_reason.
5082         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5083         constructor.  Change type of breakpoint.
5084         (finish_command_fsm_ops): Remove.
5085         (new_finish_command_fsm): Remove.
5086         (finish_command_fsm::should_stop): Rename from
5087         finish_command_fsm_should_stop.
5088         (finish_command_fsm::clean_up): Rename from
5089         finish_command_fsm_clean_up.
5090         (finish_command_fsm::return_value): Rename from
5091         finish_command_fsm_return_value.
5092         (finish_command_fsm::do_async_reply_reason): Rename from
5093         finish_command_fsm_async_reply_reason.
5094         (finish_command): Update.
5095         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5096         Add constructor.
5097         (call_thread_fsm_ops): Remove.
5098         (call_thread_fsm::call_thread_fsm): Rename from
5099         new_call_thread_fsm.
5100         (call_thread_fsm::should_stop): Rename from
5101         call_thread_fsm_should_stop.
5102         (call_thread_fsm::should_notify_stop): Rename from
5103         call_thread_fsm_should_notify_stop.
5104         (run_inferior_call, call_function_by_hand_dummy): Update.
5105         * cli/cli-interp.c (should_print_stop_to_console): Update.
5106         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5107         Add constructor.  Change type of location_breakpoint,
5108         caller_breakpoint.
5109         (until_break_fsm_ops): Remove.
5110         (new_until_break_fsm): Remove.
5111         (until_break_fsm::should_stop): Rename from
5112         until_break_fsm_should_stop.
5113         (until_break_fsm::clean_up): Rename from
5114         until_break_fsm_clean_up.
5115         (until_break_fsm::do_async_reply_reason): Rename from
5116         until_break_fsm_async_reply_reason.
5117         (until_break_command): Update.
5118         * thread-fsm.c: Remove.
5119         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5120
5121 2019-02-07  Tom Tromey  <tom@tromey.com>
5122
5123         * yy-remap.h: Add include guard.
5124         * xtensa-tdep.h: Add include guard.
5125         * xcoffread.h: Rename include guard.
5126         * varobj-iter.h: Add include guard.
5127         * tui/tui.h: Rename include guard.
5128         * tui/tui-winsource.h: Rename include guard.
5129         * tui/tui-wingeneral.h: Rename include guard.
5130         * tui/tui-windata.h: Rename include guard.
5131         * tui/tui-win.h: Rename include guard.
5132         * tui/tui-stack.h: Rename include guard.
5133         * tui/tui-source.h: Rename include guard.
5134         * tui/tui-regs.h: Rename include guard.
5135         * tui/tui-out.h: Rename include guard.
5136         * tui/tui-layout.h: Rename include guard.
5137         * tui/tui-io.h: Rename include guard.
5138         * tui/tui-hooks.h: Rename include guard.
5139         * tui/tui-file.h: Rename include guard.
5140         * tui/tui-disasm.h: Rename include guard.
5141         * tui/tui-data.h: Rename include guard.
5142         * tui/tui-command.h: Rename include guard.
5143         * tic6x-tdep.h: Add include guard.
5144         * target/waitstatus.h: Rename include guard.
5145         * target/wait.h: Rename include guard.
5146         * target/target.h: Rename include guard.
5147         * target/resume.h: Rename include guard.
5148         * target-float.h: Rename include guard.
5149         * stabsread.h: Add include guard.
5150         * rs6000-tdep.h: Add include guard.
5151         * riscv-fbsd-tdep.h: Add include guard.
5152         * regformats/regdef.h: Rename include guard.
5153         * record.h: Rename include guard.
5154         * python/python.h: Rename include guard.
5155         * python/python-internal.h: Rename include guard.
5156         * python/py-stopevent.h: Rename include guard.
5157         * python/py-ref.h: Rename include guard.
5158         * python/py-record.h: Rename include guard.
5159         * python/py-record-full.h: Rename include guard.
5160         * python/py-record-btrace.h: Rename include guard.
5161         * python/py-instruction.h: Rename include guard.
5162         * python/py-events.h: Rename include guard.
5163         * python/py-event.h: Rename include guard.
5164         * procfs.h: Add include guard.
5165         * proc-utils.h: Add include guard.
5166         * p-lang.h: Add include guard.
5167         * or1k-tdep.h: Rename include guard.
5168         * observable.h: Rename include guard.
5169         * nto-tdep.h: Rename include guard.
5170         * nat/x86-linux.h: Rename include guard.
5171         * nat/x86-linux-dregs.h: Rename include guard.
5172         * nat/x86-gcc-cpuid.h: Add include guard.
5173         * nat/x86-dregs.h: Rename include guard.
5174         * nat/x86-cpuid.h: Rename include guard.
5175         * nat/ppc-linux.h: Rename include guard.
5176         * nat/mips-linux-watch.h: Rename include guard.
5177         * nat/linux-waitpid.h: Rename include guard.
5178         * nat/linux-ptrace.h: Rename include guard.
5179         * nat/linux-procfs.h: Rename include guard.
5180         * nat/linux-osdata.h: Rename include guard.
5181         * nat/linux-nat.h: Rename include guard.
5182         * nat/linux-namespaces.h: Rename include guard.
5183         * nat/linux-btrace.h: Rename include guard.
5184         * nat/glibc_thread_db.h: Rename include guard.
5185         * nat/gdb_thread_db.h: Rename include guard.
5186         * nat/gdb_ptrace.h: Rename include guard.
5187         * nat/fork-inferior.h: Rename include guard.
5188         * nat/amd64-linux-siginfo.h: Rename include guard.
5189         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5190         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5191         * nat/aarch64-linux.h: Rename include guard.
5192         * nat/aarch64-linux-hw-point.h: Rename include guard.
5193         * mn10300-tdep.h: Add include guard.
5194         * mips-linux-tdep.h: Add include guard.
5195         * mi/mi-parse.h: Rename include guard.
5196         * mi/mi-out.h: Rename include guard.
5197         * mi/mi-main.h: Rename include guard.
5198         * mi/mi-interp.h: Rename include guard.
5199         * mi/mi-getopt.h: Rename include guard.
5200         * mi/mi-console.h: Rename include guard.
5201         * mi/mi-common.h: Rename include guard.
5202         * mi/mi-cmds.h: Rename include guard.
5203         * mi/mi-cmd-break.h: Rename include guard.
5204         * m2-lang.h: Add include guard.
5205         * location.h: Rename include guard.
5206         * linux-record.h: Rename include guard.
5207         * linux-nat.h: Add include guard.
5208         * linux-fork.h: Add include guard.
5209         * i386-darwin-tdep.h: Rename include guard.
5210         * hppa-linux-offsets.h: Add include guard.
5211         * guile/guile.h: Rename include guard.
5212         * guile/guile-internal.h: Rename include guard.
5213         * gnu-nat.h: Rename include guard.
5214         * gdb-stabs.h: Rename include guard.
5215         * frv-tdep.h: Add include guard.
5216         * f-lang.h: Add include guard.
5217         * event-loop.h: Add include guard.
5218         * darwin-nat.h: Rename include guard.
5219         * cp-abi.h: Rename include guard.
5220         * config/sparc/nm-sol2.h: Rename include guard.
5221         * config/nm-nto.h: Rename include guard.
5222         * config/nm-linux.h: Add include guard.
5223         * config/i386/nm-i386gnu.h: Rename include guard.
5224         * config/djgpp/nl_types.h: Rename include guard.
5225         * config/djgpp/langinfo.h: Rename include guard.
5226         * compile/gcc-cp-plugin.h: Add include guard.
5227         * compile/gcc-c-plugin.h: Add include guard.
5228         * compile/compile.h: Rename include guard.
5229         * compile/compile-object-run.h: Rename include guard.
5230         * compile/compile-object-load.h: Rename include guard.
5231         * compile/compile-internal.h: Rename include guard.
5232         * compile/compile-cplus.h: Rename include guard.
5233         * compile/compile-c.h: Rename include guard.
5234         * common/xml-utils.h: Rename include guard.
5235         * common/x86-xstate.h: Rename include guard.
5236         * common/version.h: Rename include guard.
5237         * common/vec.h: Rename include guard.
5238         * common/tdesc.h: Rename include guard.
5239         * common/selftest.h: Rename include guard.
5240         * common/scoped_restore.h: Rename include guard.
5241         * common/scoped_mmap.h: Rename include guard.
5242         * common/scoped_fd.h: Rename include guard.
5243         * common/safe-iterator.h: Rename include guard.
5244         * common/run-time-clock.h: Rename include guard.
5245         * common/refcounted-object.h: Rename include guard.
5246         * common/queue.h: Rename include guard.
5247         * common/ptid.h: Rename include guard.
5248         * common/print-utils.h: Rename include guard.
5249         * common/preprocessor.h: Rename include guard.
5250         * common/pathstuff.h: Rename include guard.
5251         * common/observable.h: Rename include guard.
5252         * common/netstuff.h: Rename include guard.
5253         * common/job-control.h: Rename include guard.
5254         * common/host-defs.h: Rename include guard.
5255         * common/gdb_wait.h: Rename include guard.
5256         * common/gdb_vecs.h: Rename include guard.
5257         * common/gdb_unlinker.h: Rename include guard.
5258         * common/gdb_unique_ptr.h: Rename include guard.
5259         * common/gdb_tilde_expand.h: Rename include guard.
5260         * common/gdb_sys_time.h: Rename include guard.
5261         * common/gdb_string_view.h: Rename include guard.
5262         * common/gdb_splay_tree.h: Rename include guard.
5263         * common/gdb_setjmp.h: Rename include guard.
5264         * common/gdb_ref_ptr.h: Rename include guard.
5265         * common/gdb_optional.h: Rename include guard.
5266         * common/gdb_locale.h: Rename include guard.
5267         * common/gdb_assert.h: Rename include guard.
5268         * common/filtered-iterator.h: Rename include guard.
5269         * common/filestuff.h: Rename include guard.
5270         * common/fileio.h: Rename include guard.
5271         * common/environ.h: Rename include guard.
5272         * common/common-utils.h: Rename include guard.
5273         * common/common-types.h: Rename include guard.
5274         * common/common-regcache.h: Rename include guard.
5275         * common/common-inferior.h: Rename include guard.
5276         * common/common-gdbthread.h: Rename include guard.
5277         * common/common-exceptions.h: Rename include guard.
5278         * common/common-defs.h: Rename include guard.
5279         * common/common-debug.h: Rename include guard.
5280         * common/cleanups.h: Rename include guard.
5281         * common/buffer.h: Rename include guard.
5282         * common/btrace-common.h: Rename include guard.
5283         * common/break-common.h: Rename include guard.
5284         * cli/cli-utils.h: Rename include guard.
5285         * cli/cli-style.h: Rename include guard.
5286         * cli/cli-setshow.h: Rename include guard.
5287         * cli/cli-script.h: Rename include guard.
5288         * cli/cli-interp.h: Rename include guard.
5289         * cli/cli-decode.h: Rename include guard.
5290         * cli/cli-cmds.h: Rename include guard.
5291         * charset-list.h: Add include guard.
5292         * buildsym-legacy.h: Rename include guard.
5293         * bfin-tdep.h: Add include guard.
5294         * ax.h: Rename include guard.
5295         * arm-linux-tdep.h: Add include guard.
5296         * arm-fbsd-tdep.h: Add include guard.
5297         * arch/xtensa.h: Rename include guard.
5298         * arch/tic6x.h: Add include guard.
5299         * arch/i386.h: Add include guard.
5300         * arch/arm.h: Rename include guard.
5301         * arch/arm-linux.h: Rename include guard.
5302         * arch/arm-get-next-pcs.h: Rename include guard.
5303         * arch/amd64.h: Add include guard.
5304         * arch/aarch64-insn.h: Rename include guard.
5305         * arch-utils.h: Rename include guard.
5306         * annotate.h: Add include guard.
5307         * amd64-darwin-tdep.h: Rename include guard.
5308         * aarch64-linux-tdep.h: Add include guard.
5309         * aarch64-fbsd-tdep.h: Add include guard.
5310         * aarch32-linux-nat.h: Add include guard.
5311
5312 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5313
5314         * macrotab.c (macro_define_internal): New function that
5315         factorizes macro_define_object_internal and macro_define_function
5316         code.
5317         (macro_define_object_internal): Use macro_define_internal.
5318         (macro_define_function): Likewise.
5319
5320 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5321
5322         * macrocmd.c (extract_identifier): Return
5323         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5324         callers.
5325
5326 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5327
5328         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5329
5330 2019-02-05  Tom Tromey  <tom@tromey.com>
5331
5332         * target.c (target_stack::unpush): Move assertion earlier.
5333
5334 2019-01-30  Tom Tromey  <tom@tromey.com>
5335
5336         PR python/23615:
5337         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5338         (gdbpy_parse_and_eval): Likewise.
5339         * python/python-internal.h (gdbpy_allow_threads): New class.
5340
5341 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5342
5343         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5344         (aarch64_fbsd_fpregmap): Move earlier.
5345         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5346         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5347         instead of individual calls to trad_frame_set_reg_addr.
5348         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5349         earlier.
5350         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5351         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5352         instead of individual calls to trad_frame_set_reg_addr.
5353
5354 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5355
5356         * CONTRIBUTE: Replace contribution list with wiki link.
5357
5358 2019-01-25  Tom Tromey  <tom@tromey.com>
5359
5360         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5361
5362 2019-01-25  Tom Tromey  <tom@tromey.com>
5363
5364         * xtensa-linux-nat.c: Fix common/ includes.
5365         * xml-support.h: Fix common/ includes.
5366         * xml-support.c: Fix common/ includes.
5367         * x86-linux-nat.c: Fix common/ includes.
5368         * windows-nat.c: Fix common/ includes.
5369         * varobj.h: Fix common/ includes.
5370         * varobj.c: Fix common/ includes.
5371         * value.c: Fix common/ includes.
5372         * valops.c: Fix common/ includes.
5373         * utils.c: Fix common/ includes.
5374         * unittests/xml-utils-selftests.c: Fix common/ includes.
5375         * unittests/utils-selftests.c: Fix common/ includes.
5376         * unittests/unpack-selftests.c: Fix common/ includes.
5377         * unittests/tracepoint-selftests.c: Fix common/ includes.
5378         * unittests/style-selftests.c: Fix common/ includes.
5379         * unittests/string_view-selftests.c: Fix common/ includes.
5380         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5381         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5382         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5383         * unittests/rsp-low-selftests.c: Fix common/ includes.
5384         * unittests/parse-connection-spec-selftests.c: Fix common/
5385         includes.
5386         * unittests/optional-selftests.c: Fix common/ includes.
5387         * unittests/offset-type-selftests.c: Fix common/ includes.
5388         * unittests/observable-selftests.c: Fix common/ includes.
5389         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5390         * unittests/memrange-selftests.c: Fix common/ includes.
5391         * unittests/memory-map-selftests.c: Fix common/ includes.
5392         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5393         * unittests/function-view-selftests.c: Fix common/ includes.
5394         * unittests/environ-selftests.c: Fix common/ includes.
5395         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5396         * unittests/common-utils-selftests.c: Fix common/ includes.
5397         * unittests/cli-utils-selftests.c: Fix common/ includes.
5398         * unittests/array-view-selftests.c: Fix common/ includes.
5399         * ui-file.c: Fix common/ includes.
5400         * tui/tui-io.c: Fix common/ includes.
5401         * tracepoint.h: Fix common/ includes.
5402         * tracepoint.c: Fix common/ includes.
5403         * tracefile-tfile.c: Fix common/ includes.
5404         * top.h: Fix common/ includes.
5405         * top.c: Fix common/ includes.
5406         * thread.c: Fix common/ includes.
5407         * target/waitstatus.h: Fix common/ includes.
5408         * target/waitstatus.c: Fix common/ includes.
5409         * target.h: Fix common/ includes.
5410         * target.c: Fix common/ includes.
5411         * target-memory.c: Fix common/ includes.
5412         * target-descriptions.c: Fix common/ includes.
5413         * symtab.h: Fix common/ includes.
5414         * symfile.c: Fix common/ includes.
5415         * stap-probe.c: Fix common/ includes.
5416         * spu-linux-nat.c: Fix common/ includes.
5417         * sparc-nat.c: Fix common/ includes.
5418         * source.c: Fix common/ includes.
5419         * solib.c: Fix common/ includes.
5420         * solib-target.c: Fix common/ includes.
5421         * ser-unix.c: Fix common/ includes.
5422         * ser-tcp.c: Fix common/ includes.
5423         * ser-pipe.c: Fix common/ includes.
5424         * ser-base.c: Fix common/ includes.
5425         * selftest-arch.c: Fix common/ includes.
5426         * s12z-tdep.c: Fix common/ includes.
5427         * rust-exp.y: Fix common/ includes.
5428         * rs6000-aix-tdep.c: Fix common/ includes.
5429         * riscv-tdep.c: Fix common/ includes.
5430         * remote.c: Fix common/ includes.
5431         * remote-notif.h: Fix common/ includes.
5432         * remote-fileio.h: Fix common/ includes.
5433         * remote-fileio.c: Fix common/ includes.
5434         * regcache.h: Fix common/ includes.
5435         * regcache.c: Fix common/ includes.
5436         * record-btrace.c: Fix common/ includes.
5437         * python/python.c: Fix common/ includes.
5438         * python/py-type.c: Fix common/ includes.
5439         * python/py-inferior.c: Fix common/ includes.
5440         * progspace.h: Fix common/ includes.
5441         * producer.c: Fix common/ includes.
5442         * procfs.c: Fix common/ includes.
5443         * proc-api.c: Fix common/ includes.
5444         * printcmd.c: Fix common/ includes.
5445         * ppc-linux-nat.c: Fix common/ includes.
5446         * parser-defs.h: Fix common/ includes.
5447         * osdata.c: Fix common/ includes.
5448         * obsd-nat.c: Fix common/ includes.
5449         * nat/x86-linux.c: Fix common/ includes.
5450         * nat/x86-linux-dregs.c: Fix common/ includes.
5451         * nat/x86-dregs.h: Fix common/ includes.
5452         * nat/x86-dregs.c: Fix common/ includes.
5453         * nat/ppc-linux.c: Fix common/ includes.
5454         * nat/mips-linux-watch.h: Fix common/ includes.
5455         * nat/mips-linux-watch.c: Fix common/ includes.
5456         * nat/linux-waitpid.c: Fix common/ includes.
5457         * nat/linux-ptrace.h: Fix common/ includes.
5458         * nat/linux-ptrace.c: Fix common/ includes.
5459         * nat/linux-procfs.c: Fix common/ includes.
5460         * nat/linux-personality.c: Fix common/ includes.
5461         * nat/linux-osdata.c: Fix common/ includes.
5462         * nat/linux-namespaces.c: Fix common/ includes.
5463         * nat/linux-btrace.h: Fix common/ includes.
5464         * nat/linux-btrace.c: Fix common/ includes.
5465         * nat/fork-inferior.c: Fix common/ includes.
5466         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5467         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5468         * nat/aarch64-linux.c: Fix common/ includes.
5469         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5470         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5471         * namespace.h: Fix common/ includes.
5472         * mips-linux-tdep.c: Fix common/ includes.
5473         * minsyms.c: Fix common/ includes.
5474         * mi/mi-parse.h: Fix common/ includes.
5475         * mi/mi-main.c: Fix common/ includes.
5476         * mi/mi-cmd-env.c: Fix common/ includes.
5477         * memrange.h: Fix common/ includes.
5478         * memattr.c: Fix common/ includes.
5479         * maint.h: Fix common/ includes.
5480         * maint.c: Fix common/ includes.
5481         * main.c: Fix common/ includes.
5482         * machoread.c: Fix common/ includes.
5483         * location.c: Fix common/ includes.
5484         * linux-thread-db.c: Fix common/ includes.
5485         * linux-nat.c: Fix common/ includes.
5486         * linux-fork.c: Fix common/ includes.
5487         * inline-frame.c: Fix common/ includes.
5488         * infrun.c: Fix common/ includes.
5489         * inflow.c: Fix common/ includes.
5490         * inferior.h: Fix common/ includes.
5491         * inferior.c: Fix common/ includes.
5492         * infcmd.c: Fix common/ includes.
5493         * inf-ptrace.c: Fix common/ includes.
5494         * inf-child.c: Fix common/ includes.
5495         * ia64-linux-nat.c: Fix common/ includes.
5496         * i387-tdep.c: Fix common/ includes.
5497         * i386-tdep.c: Fix common/ includes.
5498         * i386-linux-tdep.c: Fix common/ includes.
5499         * i386-linux-nat.c: Fix common/ includes.
5500         * i386-go32-tdep.c: Fix common/ includes.
5501         * i386-fbsd-tdep.c: Fix common/ includes.
5502         * i386-fbsd-nat.c: Fix common/ includes.
5503         * guile/scm-type.c: Fix common/ includes.
5504         * guile/guile.c: Fix common/ includes.
5505         * go32-nat.c: Fix common/ includes.
5506         * gnu-nat.c: Fix common/ includes.
5507         * gdbthread.h: Fix common/ includes.
5508         * gdbarch-selftests.c: Fix common/ includes.
5509         * gdb_usleep.c: Fix common/ includes.
5510         * gdb_select.h: Fix common/ includes.
5511         * gdb_bfd.c: Fix common/ includes.
5512         * gcore.c: Fix common/ includes.
5513         * fork-child.c: Fix common/ includes.
5514         * findvar.c: Fix common/ includes.
5515         * fbsd-nat.c: Fix common/ includes.
5516         * event-top.c: Fix common/ includes.
5517         * event-loop.c: Fix common/ includes.
5518         * dwarf2read.c: Fix common/ includes.
5519         * dwarf2loc.c: Fix common/ includes.
5520         * dwarf2-frame.c: Fix common/ includes.
5521         * dwarf-index-cache.c: Fix common/ includes.
5522         * dtrace-probe.c: Fix common/ includes.
5523         * disasm-selftests.c: Fix common/ includes.
5524         * defs.h: Fix common/ includes.
5525         * csky-tdep.c: Fix common/ includes.
5526         * cp-valprint.c: Fix common/ includes.
5527         * cp-support.h: Fix common/ includes.
5528         * cp-support.c: Fix common/ includes.
5529         * corelow.c: Fix common/ includes.
5530         * completer.h: Fix common/ includes.
5531         * completer.c: Fix common/ includes.
5532         * compile/compile.c: Fix common/ includes.
5533         * compile/compile-loc2c.c: Fix common/ includes.
5534         * compile/compile-cplus-types.c: Fix common/ includes.
5535         * compile/compile-cplus-symbols.c: Fix common/ includes.
5536         * command.h: Fix common/ includes.
5537         * cli/cli-dump.c: Fix common/ includes.
5538         * cli/cli-cmds.c: Fix common/ includes.
5539         * charset.c: Fix common/ includes.
5540         * build-id.c: Fix common/ includes.
5541         * btrace.h: Fix common/ includes.
5542         * btrace.c: Fix common/ includes.
5543         * breakpoint.h: Fix common/ includes.
5544         * breakpoint.c: Fix common/ includes.
5545         * ax.h:
5546         (enum agent_op): Fix common/ includes.
5547         * ax-general.c (struct aop_map): Fix common/ includes.
5548         * ax-gdb.c: Fix common/ includes.
5549         * auxv.c: Fix common/ includes.
5550         * auto-load.c: Fix common/ includes.
5551         * arm-tdep.c: Fix common/ includes.
5552         * arch/riscv.c: Fix common/ includes.
5553         * arch/ppc-linux-common.c: Fix common/ includes.
5554         * arch/i386.c: Fix common/ includes.
5555         * arch/arm.c: Fix common/ includes.
5556         * arch/arm-linux.c: Fix common/ includes.
5557         * arch/arm-get-next-pcs.c: Fix common/ includes.
5558         * arch/amd64.c: Fix common/ includes.
5559         * arch/aarch64.c: Fix common/ includes.
5560         * arch/aarch64-insn.c: Fix common/ includes.
5561         * arch-utils.c: Fix common/ includes.
5562         * amd64-windows-tdep.c: Fix common/ includes.
5563         * amd64-tdep.c: Fix common/ includes.
5564         * amd64-sol2-tdep.c: Fix common/ includes.
5565         * amd64-obsd-tdep.c: Fix common/ includes.
5566         * amd64-nbsd-tdep.c: Fix common/ includes.
5567         * amd64-linux-tdep.c: Fix common/ includes.
5568         * amd64-linux-nat.c: Fix common/ includes.
5569         * amd64-fbsd-tdep.c: Fix common/ includes.
5570         * amd64-fbsd-nat.c: Fix common/ includes.
5571         * amd64-dicos-tdep.c: Fix common/ includes.
5572         * amd64-darwin-tdep.c: Fix common/ includes.
5573         * agent.c: Fix common/ includes.
5574         * ada-lang.h: Fix common/ includes.
5575         * ada-lang.c: Fix common/ includes.
5576         * aarch64-tdep.c: Fix common/ includes.
5577
5578 2019-01-25  Tom Tromey  <tom@tromey.com>
5579
5580         * common/create-version.sh: Use common/version.h.
5581
5582 2019-01-24  Pedro Alves  <palves@redhat.com>
5583
5584         * infrun.c (signal_stop, signal_print, signal_program)
5585         (signal_catch, signal_pass): Now arrays instead of pointers.
5586         (update_signals_program_target, do_target_resume)
5587         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5588         * linux-nat.c (linux_nat_target::pass_signals)
5589         (linux_nat_target::create_inferior, linux_nat_target::attach):
5590         Adjust.
5591         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5592         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5593         * procfs.c (procfs_target::pass_signals): Adjust.
5594         * record-full.c (record_full_target::resume): Adjust.
5595         * remote.c (remote_target::pass_signals)
5596         (remote_target::program_signals): Adjust.
5597         * target-debug.h (target_debug_print_signals): Now takes a
5598         gdb::array_view as parameter.  Adjust.
5599         * target.h (target_ops) <pass_signals, program_signals>: Replace
5600         pointer and length parameters with gdb::array_view.
5601         (target_pass_signals, target_program_signals): Likewise.
5602         * target-delegates.c: Regenerate.
5603
5604 2019-01-24  Pedro Alves  <palves@redhat.com>
5605
5606         * common/forward-scope-exit.h
5607         (forward_scope_exit::forward_scope_exit): Pass arguments to
5608         m_bind_function directly, instead of creating a std::bind and
5609         copying that.
5610
5611 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5612
5613         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5614         for static members.
5615         (pass_in_v_vfp_candidate): Likewise.
5616
5617 2019-01-23  Tom Tromey  <tom@tromey.com>
5618             Pedro Alves  <palves@redhat.com>
5619
5620         * regcache.c (class regcache_invalidator): Remove.
5621         (regcache::raw_write): Use make_scope_exit.
5622
5623 2019-01-23  Tom Tromey  <tom@tromey.com>
5624
5625         * ui-out.h (class ui_out_emit_type): Update comment.
5626
5627 2019-01-23  Tom Tromey  <tom@tromey.com>
5628
5629         * infrun.c (fetch_inferior_event): Update comment.
5630
5631 2019-01-23  Tom Tromey  <tom@tromey.com>
5632             Pedro Alves  <palves@redhat.com>
5633
5634         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5635         parameter.
5636         (fetch_inferior_event): Use SCOPE_EXIT.
5637
5638
5639 2019-01-23  Tom Tromey  <tom@tromey.com>
5640             Pedro Alves  <palves@redhat.com>
5641
5642         * infrun.c (disable_thread_events): Delete.
5643         (stop_all_threads): Use SCOPE_EXIT.
5644
5645 2019-01-23  Tom Tromey  <tom@tromey.com>
5646             Pedro Alves  <palves@redhat.com>
5647
5648         * symfile.c: Include forward-scope-exit.h.
5649         (clear_symtab_users_cleanup): Replace forward declaration with
5650         a FORWARD_SCOPE_EXIT.
5651         (syms_from_objfile_1): Use the forward_scope_exit and
5652         gdb::optional instead of cleanup_function.
5653         (reread_symbols): Use the forward_scope_exit instead of
5654         cleanup_function.
5655         (clear_symtab_users_cleanup): Remove function.
5656
5657 2019-01-23  Tom Tromey  <tom@tromey.com>
5658             Pedro Alves  <palves@redhat.com>
5659
5660         * linux-nat.c: Include scope-exit.h.
5661         (cleanup_target_stop): Remove.
5662         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5663         SCOPE_EXIT.
5664
5665 2019-01-23  Tom Tromey  <tom@tromey.com>
5666             Pedro Alves  <palves@redhat.com>
5667
5668         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5669         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5670
5671 2019-01-23  Tom Tromey  <tom@tromey.com>
5672             Andrew Burgess  <andrew.burgess@embecosm.com>
5673             Pedro Alves  <palves@redhat.com>
5674
5675         * infrun.c (fetch_inferior_event): Use scope_exit.
5676         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5677         * top.c (execute_command): Use scope_exit.
5678         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5679         * utils.c (do_bpstat_clear_actions_cleanup)
5680         (make_bpstat_clear_actions_cleanup): Remove.
5681
5682 2019-01-23  Tom Tromey  <tom@tromey.com>
5683             Pedro Alves  <palves@redhat.com>
5684
5685         * infrun.c: Include "common/scope-exit.h"
5686         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5687         (wait_for_inferior): Use SCOPE_EXIT.
5688         (fetch_inferior_event): Use scope_exit.
5689
5690 2019-01-23  Tom Tromey  <tom@tromey.com>
5691             Pedro Alves  <palves@redhat.com>
5692
5693         * breakpoint.c (create_breakpoint): Remove cleanup.
5694
5695 2019-01-23  Tom Tromey  <tom@tromey.com>
5696             Andrew Burgess  <andrew.burgess@embecosm.com>
5697             Pedro Alves  <palves@redhat.com>
5698
5699 2019-01-23  Pedro Alves  <palves@redhat.com>
5700
5701         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5702
5703 2019-01-23  Pedro Alves  <palves@redhat.com>
5704             Andrew Burgess  <andrew.burgess@embecosm.com>
5705
5706         * gdbthread.h: Include "common/forward-scope-exit.h".
5707         (scoped_finish_thread_state): Redefine custom class in terms of
5708         forward_scope_exit.
5709
5710 2019-01-23  Pedro Alves  <palves@redhat.com>
5711             Andrew Burgess  <andrew.burgess@embecosm.com>
5712
5713         * common/forward-scope-exit.h: New file.
5714
5715 2019-01-23  Pedro Alves  <palves@redhat.com>
5716             Andrew Burgess  <andrew.burgess@embecosm.com>
5717             Tom Tromey  <tom@tromey.com>
5718
5719         * common/scope-exit.h: New file.
5720
5721 2019-01-23  Pedro Alves  <palves@redhat.com>
5722
5723         * common/preprocessor.h (ESC): Rename to ...
5724         (ESC_PARENS): ... this.
5725         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5726         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5727
5728 2019-01-23  Tom Tromey  <tom@tromey.com>
5729
5730         * language.h (class scoped_switch_to_sym_language_if_auto):
5731         Initialize m_lang in both cases.
5732
5733 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5734
5735         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5736         with XCNEW.
5737
5738 2019-01-22  Tom Tromey  <tom@tromey.com>
5739
5740         * corelow.c: Do not include sys/file.h.
5741
5742 2019-01-22  Tom Tromey  <tom@tromey.com>
5743
5744         * tui/tui-wingeneral.h: Include gdb_curses.h.
5745
5746 2019-01-22  Tom Tromey  <tom@tromey.com>
5747
5748         * source-cache.h (class source_cache) <get_source_lines,
5749         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5750
5751 2019-01-22  Tom Tromey  <tom@tromey.com>
5752
5753         * remote-fileio.h (struct remote_target): Declare.
5754
5755 2019-01-22  Tom Tromey  <tom@tromey.com>
5756
5757         * python/py-arch.c: Do not include py-ref.h.
5758         * python/py-bpevent.c: Do not include py-ref.h.
5759         * python/py-cmd.c: Do not include py-ref.h.
5760         * python/py-continueevent.c: Do not include py-ref.h.
5761         * python/py-event.h: Do not include py-ref.h.
5762         * python/py-evtregistry.c: Do not include py-ref.h.
5763         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5764         * python/py-frame.c: Do not include py-ref.h.
5765         * python/py-framefilter.c: Do not include py-ref.h.
5766         * python/py-function.c: Do not include py-ref.h.
5767         * python/py-infevents.c: Do not include py-ref.h.
5768         * python/py-linetable.c: Do not include py-ref.h.
5769         * python/py-objfile.c: Do not include py-ref.h.
5770         * python/py-param.c: Do not include py-ref.h.
5771         * python/py-prettyprint.c: Do not include py-ref.h.
5772         * python/py-progspace.c: Do not include py-ref.h.
5773         * python/py-symbol.c: Do not include py-ref.h.
5774         * python/py-symtab.c: Do not include py-ref.h.
5775         * python/py-type.c: Do not include py-ref.h.
5776         * python/py-unwind.c: Do not include py-ref.h.
5777         * python/py-utils.c: Do not include py-ref.h.
5778         * python/py-value.c: Do not include py-ref.h.
5779         * python/py-varobj.c: Do not include py-ref.h.
5780         * python/py-xmethods.c: Do not include py-ref.h.
5781         * python/python.c: Do not include py-ref.h.
5782         * varobj.c: Do not include py-ref.h.
5783
5784 2019-01-22  Tom Tromey  <tom@tromey.com>
5785
5786         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5787         keyword for bcache.
5788
5789 2019-01-22  Tom Tromey  <tom@tromey.com>
5790
5791         * compile/compile-cplus-types.c: Remove a comment by #include.
5792
5793 2019-01-22  Tom Tromey  <tom@tromey.com>
5794
5795         * compile/gcc-c-plugin.h: Include compile-internal.h.
5796
5797 2019-01-22  Tom Tromey  <tom@tromey.com>
5798
5799         * stabsread.c (EXTERN): Do not define.
5800         (symnum, next_symbol_text_func, processing_gcc_compilation)
5801         (within_function, global_sym_chain, global_stabs)
5802         (previous_stab_code, this_object_header_files)
5803         (n_this_object_header_files)
5804         (n_allocated_this_object_header_files): Define.
5805         * stabsread.h (EXTERN): Never define.  Use "extern".
5806
5807 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5808
5809         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5810         history_value.
5811
5812 2019-01-21  Tom Tromey  <tom@tromey.com>
5813
5814         * ui-out.c: Fix includes.
5815         * tui/tui-source.c: Fix includes.
5816         * target.c: Fix includes.
5817         * remote.c: Fix includes.
5818         * regcache.c: Fix includes.
5819         * python/py-block.c: Fix includes.
5820         * printcmd.c: Fix includes.
5821         * or1k-tdep.c: Fix includes.
5822         * mi/mi-main.c: Fix includes.
5823         * m32r-tdep.c: Fix includes.
5824         * csky-tdep.c: Fix includes.
5825         * compile/compile-cplus-types.c: Fix includes.
5826         * cli/cli-interp.c: Fix includes.
5827
5828 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5829
5830         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5831         for padding.
5832
5833 2019-01-16  Tom Tromey  <tom@tromey.com>
5834
5835         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5836         earlier.
5837         (struct objfile) <msymbols_range>: Move from top level.
5838         <msymbols>: New method.
5839         (class objfile_msymbols): Remove.
5840         * symtab.c (default_collect_symbol_completion_matches_break_on):
5841         Update.
5842         * symmisc.c (dump_msymbols): Update.
5843         * stabsread.c (scan_file_globals): Update.
5844         * objc-lang.c (info_selectors_command, info_classes_command)
5845         (find_methods): Update.
5846         * minsyms.c (find_solib_trampoline_target): Update.
5847         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5848         * coffread.c (coff_symfile_read): Update.
5849         * ada-lang.c (ada_lookup_simple_minsym)
5850         (ada_collect_symbol_completion_matches): Update.
5851
5852 2019-01-16  Tom Tromey  <tom@tromey.com>
5853
5854         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5855         type.  Remove no-argument constructor.
5856         <iterator::operator++>: Simplify.
5857         <begin>: Update.
5858         <end>: Use minimal_symbol_count.
5859
5860 2019-01-16  Tom Tromey  <tom@tromey.com>
5861
5862         * objfiles.h (struct objfile) <psymtabs>: New method.
5863         (class objfile_psymtabs): Remove.
5864         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5865         typedef.
5866         <range>: New method.
5867         (require_partial_symbols): Change return type.
5868         * psymtab.c (require_partial_symbols)
5869         (psym_expand_symtabs_matching): Update.
5870         * mdebugread.c (parse_partial_symbols): Update.
5871         * dbxread.c (dbx_end_psymtab): Update.
5872
5873 2019-01-15  Tom Tromey  <tom@tromey.com>
5874
5875         * symtab.c (lookup_objfile_from_block)
5876         (lookup_symbol_in_objfile_symtabs)
5877         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5878         (find_line_symtab, info_sources_command)
5879         (default_collect_symbol_completion_matches_break_on)
5880         (make_source_files_completion_list): Update.
5881         * symmisc.c (print_objfile_statistics, dump_objfile)
5882         (maintenance_print_symbols, maintenance_info_symtabs)
5883         (maintenance_check_symtabs, maintenance_info_line_tables):
5884         Update.
5885         * source.c (select_source_symtab)
5886         (forget_cached_source_info_for_objfile): Update.
5887         * objfiles.h (class objfile_compunits): Remove.
5888         (struct objfile) <compunits_range>: New typedef.
5889         (compunits): New method.
5890         * objfiles.c (objfile_relocate1): Update.
5891         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5892         * maint.c (count_symtabs_and_blocks): Update.
5893         * linespec.c (iterate_over_all_matching_symtabs): Update.
5894         * cp-support.c (add_symbol_overload_list_qualified): Update.
5895         * coffread.c (coff_symtab_read): Update.
5896         * ada-lang.c (add_nonlocal_symbols)
5897         (ada_collect_symbol_completion_matches)
5898         (ada_add_global_exceptions): Update.
5899
5900 2019-01-15  Tom Tromey  <tom@tromey.com>
5901
5902         * progspace.h (program_space) <objfiles_safe_range>: New
5903         typedef.
5904         <objfiles_safe>: New method.
5905         * objfiles.h (class all_objfiles_safe): Remove.
5906         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5907         * jit.c (jit_inferior_exit_hook): Update.
5908
5909 2019-01-17  Tom Tromey  <tom@tromey.com>
5910
5911         * progspace.h (program_space) <objfiles_range>: New typedef.
5912         <objfiles>: New method.
5913         <objfiles_head>: Rename from objfiles.
5914         (object_files): Update.
5915         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5916         * guile/scm-pretty-print.c
5917         (ppscm_find_pretty_printer_from_objfiles): Update.
5918         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5919         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5920         Update.
5921         * python/py-progspace.c (pspy_get_objfiles): Update.
5922         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5923         Update.
5924         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5925         (objfpy_lookup_objfile_by_build_id): Update.
5926         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5927         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5928         Update.
5929         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5930         (expand_symtab_containing_pc, lookup_objfile_from_block)
5931         (lookup_static_symbol, basic_lookup_transparent_type)
5932         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5933         (find_line_symtab, info_sources_command)
5934         (default_collect_symbol_completion_matches_break_on)
5935         (make_source_files_completion_list, find_main_name): Update.
5936         * symmisc.c (print_symbol_bcache_statistics)
5937         (print_objfile_statistics, maintenance_print_symbols)
5938         (maintenance_print_msymbols, maintenance_print_objfiles)
5939         (maintenance_info_symtabs, maintenance_check_symtabs)
5940         (maintenance_expand_symtabs, maintenance_info_line_tables):
5941         Update.
5942         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5943         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5944         (map_overlay_command, unmap_overlay_command)
5945         (simple_overlay_update, expand_symtabs_matching)
5946         (map_symbol_filenames): Update.
5947         * symfile-debug.c (set_debug_symfile): Update.
5948         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5949         Update.
5950         * source.c (select_source_symtab, forget_cached_source_info):
5951         Update.
5952         * solib.c (solib_read_symbols): Update.
5953         * solib-spu.c (append_ocl_sos): Update.
5954         * psymtab.c (maintenance_print_psymbols)
5955         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5956         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5957         * printcmd.c (info_symbol_command): Update.
5958         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5959         Update.
5960         * objfiles.h (class all_objfiles): Remove.
5961         * objfiles.c (have_partial_symbols, have_full_symbols)
5962         (have_minimal_symbols, qsort_cmp, update_section_map)
5963         (shared_objfile_contains_address_p)
5964         (default_iterate_over_objfiles_in_search_order): Update.
5965         * objc-lang.c (info_selectors_command, info_classes_command)
5966         (find_methods): Update.
5967         * minsyms.c (find_solib_trampoline_target): Update.
5968         * maint.c (maintenance_info_sections)
5969         (maintenance_translate_address, count_symtabs_and_blocks):
5970         Update.
5971         * main.c (captured_main_1): Update.
5972         * linux-thread-db.c (try_thread_db_load_from_pdir)
5973         (has_libpthread): Update.
5974         * linespec.c (iterate_over_all_matching_symtabs)
5975         (search_minsyms_for_name): Update.
5976         * jit.c (jit_find_objf_with_entry_addr): Update.
5977         * hppa-tdep.c (find_unwind_entry)
5978         (hppa_lookup_stub_minimal_symbol): Update.
5979         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5980         Update.
5981         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5982         (elf_gnu_ifunc_resolve_by_got): Update.
5983         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5984         * dwarf-index-write.c (save_gdb_index_command): Update.
5985         * cp-support.c (add_symbol_overload_list_qualified): Update.
5986         * breakpoint.c (create_overlay_event_breakpoint)
5987         (create_longjmp_master_breakpoint)
5988         (create_std_terminate_master_breakpoint)
5989         (create_exception_master_breakpoint): Update.
5990         * blockframe.c (find_pc_partial_function): Update.
5991         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5992         (ada_collect_symbol_completion_matches)
5993         (ada_add_global_exceptions): Update.
5994
5995 2019-01-17  Tom Tromey  <tom@tromey.com>
5996
5997         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5998         declare VEC.
5999         (solib_target_parse_libraries): Change return type.
6000         (library_list_start_segment, library_list_start_section)
6001         (library_list_end_library, library_list_start_library); Update.
6002         (solib_target_free_library_list): Remove.
6003         (solib_target_parse_libraries): Remove cleanup.  Change return
6004         type.
6005         (solib_target_current_sos): Update.
6006
6007 2019-01-17  Tom Tromey  <tromey@bapiya>
6008
6009         * valprint.c: Replace "the the" with "the".
6010         * symtab.c: Replace "the the" with "the".
6011         * solib.c: Replace "the the" with "the".
6012         * solib-dsbt.c: Replace "the the" with "the".
6013         * linespec.c: Replace "the the" with "the".
6014         * dwarf2loc.h: Replace "the the" with "the".
6015         * amd64-windows-tdep.c: Replace "the the" with "the".
6016         * aarch64-tdep.c: Replace "the the" with "the".
6017
6018 2019-01-16  Keith Seitz  <keiths@redhat.com>
6019
6020         PR gdb/23773
6021         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6022         <builder>: Rename to ..
6023         <m_builder>: ... this and make private.
6024         (dwarf2_cu::get_builder): New method.  Change all users of
6025         `builder' to use this method.
6026         (dwarf2_start_symtab): Move to ...
6027         (dwarf2_cu::start_symtab): ... here.  Update all callers
6028         (setup_type_unit_groups): Move to ...
6029         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6030         callers.
6031         (dwarf2_cu::reset_builder): New method.
6032         (process_full_compunit, process_full_type_unit): Use
6033         dwarf2_cu::reset_builder.
6034         (follow_die_offset): Record the ancestor CU if it is different
6035         from the followed DIE's CU.
6036         (follow_die_sig_1): Likewise.
6037
6038 2019-01-15  Tom Tromey  <tom@tromey.com>
6039
6040         * remote.c (class remote_state) <buf>: Now a char_vector.
6041         <buf_size>: Remove.
6042         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6043         parameter.
6044         (remote_target::getpkt_or_notif_sane_1)
6045         (remote_target::getpkt_sane)
6046         (remote_target::getpkt_or_notif_sane): Likewise.
6047         (class remote_target) <putpkt>: New overload.
6048         (remote_target::read_frame): Change type of "buf_p".  Remove
6049         sizeof_p parameter.
6050         (packet_ok): New overload.
6051         (packet_check_result): New overload.
6052         Update all uses.
6053
6054 2019-01-14  Tom Tromey  <tom@tromey.com>
6055
6056         * remote-notif.c (handle_notification, remote_notif_ack)
6057         (remote_notif_parse): Make "buf" const.
6058         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6059         const.
6060         (remote_notif_parse, remote_notif_ack, handle_notification):
6061         Likewise.
6062         * remote.c (remote_notif_stop_parse): Make "buf" const.
6063         (remote_target::remote_parse_stop_reply): Make "buf" const.
6064         (remote_notif_stop_ack): Make "buf" const.
6065
6066 2019-01-14  Tom Tromey  <tom@tromey.com>
6067
6068         * remote.c (remote_console_output): Make parameter const.
6069
6070 2019-01-14  Tom Tromey  <tom@tromey.com>
6071
6072         * target-debug.h (target_debug_print_signals): Constify.
6073         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6074         * procfs.c (procfs_target::pass_signals): Update.
6075         * linux-nat.c (linux_nat_target::pass_signals): Update.
6076         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6077         * target-delegates.c: Rebuild.
6078         * remote.c (remote_target::program_signals): Update.
6079         (remote_target::pass_signals): Update.
6080         * target.c (target_pass_signals): Constify argument.
6081         (target_program_signals): Likewise.
6082         * target.h (struct target_ops) <pass_signals, program_signals>:
6083         Constify argument.
6084         (target_pass_signals, target_program_signals): Constify argument.
6085
6086 2019-01-14  Tom Tromey  <tom@tromey.com>
6087
6088         PR tui/28819:
6089         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6090
6091 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6092
6093         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6094         field.
6095         * rs6000-tdep.c: Include reggroups.h.
6096         (IS_V_ALIAS_PSEUDOREG): Define.
6097         (rs6000_register_name): Return names for the "vX" aliases.
6098         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6099         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6100         aliases.  Call default_register_reggroup_p for all other
6101         pseudo-registers.
6102         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6103         New functions.
6104         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6105         Handle "vX" aliases.
6106         (v_alias_pseudo_register_collect): New function.
6107         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6108         (rs6000_gdbarch_init): Initialize "vX" aliases as
6109         pseudo-registers.  Restore registration of
6110         rs6000_pseudo_register_reggroup_p with
6111         set_tdesc_pseudo_register_reggroup_p.
6112
6113 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6114
6115         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6116         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6117         set_gdbarch_num_pseudo_regs.
6118
6119 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6120
6121         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6122         Remove arg prefixname, add do_set and do_show.
6123         Add member functions set_list and show_list.
6124         * cli/cli-style.c (class cli_style_option): Update accordingly.
6125         (style_set_list): Move to file scope.
6126         (style_show_list): Likewise.
6127         (set_style): Call help_list.
6128         (show_style): Call cmd_show_list.
6129         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6130         Update to use the new macro.
6131
6132 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6133
6134         * ada-lang.c (_initialize_ada_language): Expand the help text
6135         for the "catch exception" command.
6136
6137 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6138
6139         * symtab.c (matching_obj_sections): Initialize obj,
6140         declare it closer to its usage.
6141
6142 2019-01-10  Tom Tromey  <tom@tromey.com>
6143
6144         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6145         (basic_inf_threads_range): Remove.
6146         (inf_threads_range, inf_non_exited_threads_range)
6147         (safe_inf_threads_range): Use next_adapter.
6148
6149 2019-01-10  Keith Seitz  <keiths@redhat.com>
6150
6151         PR gdb/23712
6152         PR symtab/23010
6153         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6154         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6155
6156 2019-01-10  Keith Seitz  <keiths@redhat.com>
6157
6158         PR gdb/23712
6159         PR symtab/23010
6160         * dictionary.c (pending_to_vector): Remove.
6161         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6162         Remove _1 suffix, replacing functions of the same name.  Update
6163         all callers.
6164         (dict_create_hashed, dict_create_hashed_expandable)
6165         (dict_create_linear, dict_create_linear_expandable, dict_free)
6166         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6167         Make functions static.
6168
6169 2019-01-10  Keith Seitz  <keiths@redhat.com>
6170
6171         PR gdb/23712
6172         PR symtab/23010
6173         * dictionary.h (struct dictionary): Replace declaration with
6174         multidictionary.
6175         (dict_create_hashed, dict_create_hashed_expandable)
6176         (dict_create_linear, dict_create_linear_expandable)
6177         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6178         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6179         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6180         taking multidictionary argument.
6181         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6182         * block.h (struct block) <dict>: Change to multidictionary
6183         and rename `multidict'.
6184         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6185         symmisc.c: Update all dictionary references to multidictionary.
6186
6187 2019-01-10  Keith Seitz  <keiths@redhat.com>
6188
6189         PR gdb/23712
6190         PR symtab/23010
6191         * dictionary.c: Include unordered_map.
6192         (pending_to_vector): New function.
6193         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6194         Rewrite the non-"_1" functions to take vector instead
6195         of linked list.
6196         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6197         "new" _1 versions of the same name.
6198         (multidictionary): Define.
6199         (std::hash<enum language): New definition.
6200         (collate_pending_symbols_by_language, mdict_create_hashed)
6201         (mdict_create_hashed_expandable, mdict_create_linear)
6202         (mdict_create_linear_expandable, mdict_free)
6203         (find_language_dictionary, create_new_language_dictionary)
6204         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6205         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6206         (mdict_size, mdict_empty): New functions.
6207         * dictionary.h (mdict_iterator): Define.
6208
6209 2019-01-10  Pedro Alves  <palves@redhat.com>
6210
6211         * breakpoint.c (read_uploaded_action)
6212         (create_tracepoint_from_upload): Adjust to use
6213         gdb::unique_xmalloc_ptr.
6214         * ctf.c (ctf_write_uploaded_tp):
6215         (SET_ARRAY_FIELD): Use emplace_back.
6216         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6217         * tracefile-tfile.c (tfile_write_uploaded_tp):
6218         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6219         gdb::unique_xmalloc_ptr.
6220         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6221         at_string, cond_string, cmd_strings>: Replace char pointers
6222         with gdb::unique_xmalloc_ptr.
6223
6224 2019-01-10  Pedro Alves  <palves@redhat.com>
6225
6226         * solib-target.c (library_list_start_library): Don't xstrdup name.
6227
6228 2019-01-10  Pedro Alves  <palves@redhat.com>
6229
6230         * mdebugread.c (parse_partial_symbols): Use
6231         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6232
6233 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         * linux-fork.c (scoped_switch_fork_info)
6236         <~scoped_switch_fork_info>: Fix incorrect variable name.
6237
6238 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6239
6240         * linux-fork.c (scoped_switch_fork_info)
6241         <scoped_switch_fork_info>: Make explicit.
6242         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6243
6244 2019-01-10  Tom Tromey  <tom@tromey.com>
6245
6246         * objfiles.h (objfile::reset_psymtabs): Update.
6247         * objfiles.c (objfile::objfile): Update.
6248         * psymtab.h (psymtab_storage::obstack): Update.
6249         (psymtab_storage::m_obstack): Use gdb::optional.
6250         (class psymtab_storage): Update comment.  Remove objfile
6251         parameter.
6252         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6253
6254 2019-01-10  Tom Tromey  <tom@tromey.com>
6255
6256         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6257         <free_psymtabs>: Now private.
6258         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6259         (allocate_psymtab): Use new method.
6260
6261 2019-01-10  Tom Tromey  <tom@tromey.com>
6262
6263         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6264         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6265         * mdebugread.c (parse_partial_symbols): Use
6266         allocate_dependencies.
6267         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6268         allocate_dependencies.
6269         (process_psymtab_comp_unit_reader)
6270         (build_type_psymtab_dependencies): Likewise.
6271         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6272
6273 2019-01-10  Tom Tromey  <tom@tromey.com>
6274
6275         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6276         PSYMBOL_SET_LANGUAGE.
6277         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6278
6279 2019-01-10  Tom Tromey  <tom@tromey.com>
6280
6281         * psymtab.h (psymtab_storage::obstack): New method.
6282         <m_obstack>: Rename from obstack; now private.
6283         * psymtab.c (psymtab_storage): Update.
6284         * dwarf2read.c (create_addrmap_from_index)
6285         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6286         Update.
6287
6288 2019-01-10  Tom Tromey  <tom@tromey.com>
6289
6290         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6291         * objfiles.h (objfile::reset_psymtabs): New method.
6292
6293 2019-01-10  Tom Tromey  <tom@tromey.com>
6294
6295         * symmisc.c (print_symbol_bcache_statistics): Update.
6296         (print_objfile_statistics): Update.
6297         * symfile.c (reread_symbols): Update.
6298         * psymtab.h (class psymtab_storage): New.
6299         * psymtab.c (psymtab_storage): New constructor.
6300         (~psymtab_storage): New destructor.
6301         (require_partial_symbols): Update.
6302         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6303         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6304         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6305         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6306         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6307         (start_psymtab_common, end_psymtab_common)
6308         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6309         (allocate_psymtab): Update.
6310         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6311         Update.
6312         (dump_psymtab_addrmap, maintenance_print_psymbols)
6313         (maintenance_check_psymtabs): Update.
6314         (class objfile_psymtabs): Move to objfiles.h.
6315         * psympriv.h (discard_psymtab): Now inline.
6316         (psymtab_discarder::psymtab_discarder): Update.
6317         (psymtab_discarder::~psymtab_discarder): Update.
6318         (ALL_OBJFILE_PSYMTABS): Rewrite.
6319         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6320         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6321         Remove fields.
6322         <partial_symtabs>: New field.
6323         (class objfile_psymtabs): Move from psymtab.h.  Update.
6324         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6325         psymbol_cache.
6326         (objfile::~objfile): Don't destroy psymbol_cache.
6327         * mdebugread.c (parse_partial_symbols): Update.
6328         * dwarf2read.c (create_addrmap_from_index)
6329         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6330         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6331         (add_partial_subprogram, dwarf2_ranges_read): Update.
6332         * dwarf-index-write.c (write_address_map)
6333         (write_one_signatured_type, recursively_write_psymbols)
6334         (class debug_names, class debug_names, write_psymtabs_to_index):
6335         Update.
6336
6337 2019-01-10  Tom Tromey  <tom@tromey.com>
6338
6339         * symtab.h (SYMBOL_SET_NAMES): Update.
6340         (symbol_set_names): Update.
6341         (MSYMBOL_SET_NAMES): Update.
6342         * symtab.c (symbol_set_names): Change argument to be an
6343         objfile_per_bfd_storage.
6344         * psymtab.c (add_psymbol_to_bcache): Update.
6345         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6346
6347 2019-01-10  Tom Tromey  <tom@tromey.com>
6348
6349         * symtab.c (create_demangled_names_hash): Change argument to be an
6350         objfile_per_bfd_storage.
6351         (symbol_set_names): Update.
6352
6353 2019-01-10  Tom Tromey  <tom@tromey.com>
6354
6355         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6356         init_psymbol_list.
6357         * psymtab.c (init_psymbol_list): Do nothing if already called.
6358         * psympriv.h (init_psymbol_list): Add comment.
6359         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6360         init_psymbol_list.
6361         * dbxread.c (dbx_symfile_read): Unconditionally call
6362         init_psymbol_list.
6363
6364 2019-01-10  Tom Tromey  <tom@tromey.com>
6365
6366         * xcoffread.c (scan_xcoff_symtab): Update.
6367         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6368         "where".
6369         * mdebugread.c (parse_partial_symbols)
6370         (handle_psymbol_enumerators): Update.
6371         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6372         * dbxread.c (read_dbx_symtab): Update.
6373         * psympriv.h (psymbol_placement): New enum.
6374         (add_psymbol_to_list): Update.
6375
6376 2019-01-10  Tom Tromey  <tom@tromey.com>
6377
6378         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6379         static_psymbols parameters.
6380         (scan_xcoff_symtab): Update.
6381         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6382         static_psymbols parameters.
6383         * psympriv.h (start_psymtab_common): Update.
6384         * mdebugread.c (parse_partial_symbols): Update.
6385         * dwarf2read.c (create_partial_symtab): Update.
6386         * dbxread.c (read_dbx_symtab): Update.
6387         (start_psymtab): Remove global_psymbols and static_psymbols
6388         parameters.
6389
6390 2019-01-10  Tom Tromey  <tom@tromey.com>
6391
6392         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6393         * psymtab.c (allocate_psymtab): Add comment.
6394         * psympriv.h (allocate_psymtab): Add comment.
6395         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6396         initializations.
6397         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6398
6399 2019-01-10  Tom Tromey  <tom@tromey.com>
6400
6401         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6402         Don't declare.
6403         * mipsread.c: Include mdebugread.h.
6404         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6405         Declare.
6406         * elfread.c: Include mdebugread.h.
6407
6408 2019-01-09  Tom Tromey  <tom@tromey.com>
6409
6410         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6411         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6412         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6413         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6414         (psym_lookup_symbol, psym_find_last_source_symtab)
6415         (psym_forget_cached_source_info, psym_print_stats)
6416         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6417         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6418         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6419         (psym_find_compunit_symtab_by_address)
6420         (maintenance_print_psymbols, maintenance_info_psymtabs)
6421         (maintenance_check_psymtabs): Use ranged for.
6422         * psymtab.h (class objfile_psymtabs): New.
6423         (require_partial_symbols): Return objfile_psymtabs.
6424         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6425
6426 2019-01-09  Tom Tromey  <tom@tromey.com>
6427
6428         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6429         (find_pc_mapped_section, list_overlays_command)
6430         (map_overlay_command, unmap_overlay_command)
6431         (simple_overlay_update): Use all_objfiles.
6432         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6433         * printcmd.c (info_symbol_command): Use all_objfiles.
6434         * objfiles.h (ALL_OBJSECTIONS): Remove.
6435         * maint.c (maintenance_translate_address): Use all_objfiles.
6436         * gcore.c (gcore_create_callback): Use all_objfiles.
6437         (objfile_find_memory_regions): Likewise.
6438
6439 2019-01-09  Tom Tromey  <tom@tromey.com>
6440
6441         * symtab.c (find_line_symtab, info_sources_command)
6442         (make_source_files_completion_list): Use objfile_compunits.
6443         * source.c (select_source_symtab): Use objfile_compunits.
6444         * objfiles.h (struct objfile): Update comment.
6445         (ALL_OBJFILES): Remove.
6446         (ALL_FILETABS): Remove.
6447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6448         objfile_compunits.
6449
6450 2019-01-09  Tom Tromey  <tom@tromey.com>
6451
6452         * symmisc.c (print_objfile_statistics, dump_objfile)
6453         (maintenance_print_symbols): Use compunit_filetabs.
6454         * source.c (forget_cached_source_info_for_objfile): Use
6455         compunit_filetabs.
6456         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6457         (ALL_FILETABS): Use compunit_filetabs.
6458         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6459         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6460
6461 2019-01-09  Tom Tromey  <tom@tromey.com>
6462
6463         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6464         (compunit_filetabs): New.
6465         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6466         compunit_filetabs.
6467         (info_sources_command, make_source_files_completion_list): Remove
6468         declaration.
6469         * symmisc.c (print_objfile_statistics, dump_objfile)
6470         (maintenance_print_symbols): Remove declaration.
6471         (maintenance_info_symtabs): Use compunit_filetabs.
6472         (maintenance_info_line_tables): Likewise.
6473         * source.c (select_source_symtab): Change local variable name.
6474         (forget_cached_source_info_for_objfile): Remove declaration.
6475         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6476         * objfiles.c (objfile_relocate1): Remove declaration.
6477         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6478         declaration.
6479         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6480         * coffread.c (coff_symtab_read): Remove declaration.
6481         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6482         compunit_filetabs.
6483
6484 2019-01-09  Tom Tromey  <tom@tromey.com>
6485
6486         * symtab.c (lookup_objfile_from_block)
6487         (find_pc_sect_compunit_symtab, search_symbols)
6488         (default_collect_symbol_completion_matches_break_on): Use
6489         objfile_compunits.
6490         * objfiles.h (ALL_COMPUNITS): Remove.
6491         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6492         * cp-support.c (add_symbol_overload_list_qualified): Use
6493         objfile_compunits.
6494         * ada-lang.c (ada_collect_symbol_completion_matches)
6495         (ada_add_global_exceptions): Use objfile_compunits.
6496
6497 2019-01-09  Tom Tromey  <tom@tromey.com>
6498
6499         * source.c (select_source_symtab)
6500         (forget_cached_source_info_for_objfile): Remove declaration.
6501         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6502         declaration.
6503         * maint.c (count_symtabs_and_blocks): Remove declaration.
6504         * cp-support.c (add_symbol_overload_list_qualified): Remove
6505         declaration.
6506         * coffread.c (coff_symtab_read): Remove declaration.
6507         * symtab.c (lookup_symbol_in_objfile_symtabs)
6508         (basic_lookup_transparent_type_1): Use objfile_compunits.
6509         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6510         (info_sources_command, search_symbols)
6511         (default_collect_symbol_completion_matches_break_on)
6512         (make_source_files_completion_list): Remove declaration.
6513         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6514         (ada_collect_symbol_completion_matches)
6515         (ada_add_global_exceptions): Remove declaration.
6516         * linespec.c (iterate_over_all_matching_symtabs): Use
6517         objfile_compunits.
6518         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6519         (class objfile_compunits): New.
6520         (ALL_COMPUNITS): Use objfile_compunits.
6521         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6522         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6523         objfile_compunits.
6524         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6525
6526 2019-01-09  Tom Tromey  <tom@tromey.com>
6527
6528         * symtab.c (search_symbols)
6529         (default_collect_symbol_completion_matches_break_on): Use
6530         objfile_msymbols.
6531         * ada-lang.c (ada_lookup_simple_minsym)
6532         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6533         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6534         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6535         objfile_msymbols.
6536         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6537         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6538         * objc-lang.c (find_methods): Use objfile_msymbols.
6539         (info_selectors_command, info_classes_command): Likewise.
6540         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6541         * objfiles.h (class objfile_msymbols): New.
6542         (ALL_OBJFILE_MSYMBOLS): Remove.
6543         (ALL_MSYMBOLS): Remove.
6544
6545 2019-01-09  Tom Tromey  <tom@tromey.com>
6546
6547         * common/next-iterator.h (next_adapter): Add Iterator template
6548         parameter.
6549         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6550         (class all_objfiles_safe): New.
6551         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6552         * objfiles.c (put_objfile_before): Update comment.
6553         (add_separate_debug_objfile): Likewise.
6554         (free_all_objfiles): Use all_objfiles_safe.
6555         (objfile_purge_solibs): Likewise.
6556
6557 2019-01-09  Tom Tromey  <tom@tromey.com>
6558
6559         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6560         (expand_symtab_containing_pc, lookup_static_symbol)
6561         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6562         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6563         all_objfiles.
6564         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6565         * breakpoint.c (create_overlay_event_breakpoint)
6566         (create_longjmp_master_breakpoint)
6567         (create_std_terminate_master_breakpoint)
6568         (create_exception_master_breakpoint): Use all_objfiles.
6569         * linux-thread-db.c (try_thread_db_load_from_pdir)
6570         (has_libpthread): Use all_objfiles.
6571         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6572         * linespec.c (iterate_over_all_matching_symtabs)
6573         (search_minsyms_for_name): Use all_objfiles.
6574         * maint.c (maintenance_info_sections): Use all_objfiles.
6575         * main.c (captured_main_1): Use all_objfiles.
6576         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6577         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6578         * guile/scm-pretty-print.c
6579         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6580         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6581         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6582         (maintenance_print_msymbols): Use all_objfiles.
6583         * source.c (select_source_symtab): Use all_objfiles.
6584         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6585         * symfile.c (remove_symbol_file_command)
6586         (expand_symtabs_matching, map_symbol_filenames): Use
6587         all_objfiles.
6588         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6589         all_objfiles.
6590         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6591         * objc-lang.c (find_methods): Use all_objfiles.
6592         * objfiles.c (have_partial_symbols, have_full_symbols)
6593         (have_minimal_symbols, qsort_cmp)
6594         (default_iterate_over_objfiles_in_search_order): Use
6595         all_objfiles.
6596         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6597         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6598         (maintenance_check_psymtabs): Use all_objfiles.
6599         (ALL_PSYMTABS): Remove.
6600         * compile/compile-object-run.c (do_module_cleanup): Use
6601         all_objfiles.
6602         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6603         * cp-support.c (add_symbol_overload_list_qualified): Use
6604         all_objfiles.
6605         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6606         Use all_objfiles.
6607         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6608         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6609         all_objfiles.
6610         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6611         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6612         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6613         Uses all_objfiles.
6614         * solib.c (solib_read_symbols): Use all_objfiles
6615
6616 2019-01-09  Tom Tromey  <tom@tromey.com>
6617
6618         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6619         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6620         all_objfiles.
6621         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6622         * symmisc.c (print_symbol_bcache_statistics)
6623         (print_objfile_statistics, maintenance_print_objfiles)
6624         (maintenance_info_symtabs, maintenance_check_symtabs)
6625         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6626         all_objfiles.
6627         * source.c (forget_cached_source_info): Use all_objfiles.
6628         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6629         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6630         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6631         * objfiles.c (update_section_map): Use all_objfiles.
6632         (shared_objfile_contains_address_p): Likewise.
6633         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6634         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6635
6636 2019-01-09  Tom Tromey  <tom@tromey.com>
6637
6638         * common/next-iterator.h: New file.
6639         * objfiles.h (class all_objfiles): New.
6640         (struct objfile_iterator): New.
6641
6642 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6643
6644         * NEWS: Move the description of the changed "frame", "select-frame",
6645          and "info frame" commands to the Changed commands section.
6646
6647 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6648
6649         * gdbtypes.c (check_stub_method_group): Remove handling of old
6650         mangling schemes.
6651         * linespec.c (find_methods): Likewise.
6652         * stabsread.c (read_member_functions): Likewise.
6653         * valops.c (search_struct_method): Likewise.
6654         (value_struct_elt_for_reference): Likewise.
6655         * NEWS: Mention this change.
6656
6657 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6658
6659         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6660         print_source_lines.
6661         * source.c (print_source_lines_base): Update line number check.
6662         (print_source_lines): New function.
6663         (source_lines_range::source_lines_range): New function.
6664         * source.h (class source_lines_range): New class.
6665         (print_source_lines): New declaration.
6666
6667 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6668
6669         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6670
6671 2019-01-08  Tom Tromey  <tom@tromey.com>
6672             Simon Marchi  <simon.marchi@ericsson.com>
6673
6674         PR gdb/24060
6675         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6676         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6677         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6678         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6679         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6680         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6681
6682 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6683
6684         * source.c (select_source_symtab): Move header comment to
6685         declaration in source.h.
6686         (forget_cached_source_info_for_objfile): Likewise.
6687         (forget_cached_source_info): Likewise.
6688         (identify_source_line): Likewise.
6689         * source.h (identify_source_line): Move declaration from symtab.h
6690         and add comment from source.c
6691         (print_source_lines): Likewise.
6692         (forget_cached_source_info_for_objfile): Likewise.
6693         (forget_cached_source_info): Likewise.
6694         (select_source_symtab): Likewise.
6695         (enum print_source_lines_flag): Move definition from symtab.h.
6696         * symtab.h (identify_source_line): Move declaration to source.h.
6697         (print_source_lines): Likewise.
6698         (forget_cached_source_info_for_objfile): Likewise.
6699         (forget_cached_source_info): Likewise.
6700         (select_source_symtab): Likewise.
6701         (enum print_source_lines_flag): Move definition to source.h.
6702         * tui/tui-hooks.c: Add 'source.h' include.
6703
6704 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6705
6706         * source.c (print_source_lines_base): Handle requests to print
6707         reverse line number sequences, and guard against empty lines
6708         string.
6709
6710 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6711
6712         * source.c (print_source_lines_base): Fix skip of '\r' if next
6713         character is '\n'.
6714
6715 2019-01-06  Tom Tromey  <tom@tromey.com>
6716
6717         * c-exp.y (struct c_parse_state) <macro_original_text,
6718         expansion_obstack>: New member.
6719         (macro_original_text, expansion_obstack): Remove globals.
6720         (scan_macro_expansion, scanning_macro_expansion)
6721         (finished_macro_expansion): Update.
6722         (scan_macro_cleanup): Remove.
6723         (yylex, c_parse): Update.
6724
6725 2019-01-06  Tom Tromey  <tom@tromey.com>
6726
6727         * c-exp.y (struct c_parse_state) <strings>: New member.
6728         (operator_stoken): Update.
6729
6730 2019-01-06  Tom Tromey  <tom@tromey.com>
6731
6732         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6733         (union type_stack_elt) <typelist_val>: Now a pointer to
6734         std::vector.
6735         (type_stack_cleanup): Don't declare.
6736         (push_typelist): Update.
6737         * parse.c (pop_typelist): Return a std::vector.
6738         (push_typelist): Take a std::vector.
6739         (follow_types): Update.  Do not free args.
6740         (type_stack_cleanup): Remove.
6741         * c-exp.y (struct c_parse_state): New.
6742         (cpstate): New global.
6743         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6744         (nonempty_typelist): Update.
6745         (func_mod): Create a new vector.
6746         (c_parse): Create a c_parse_state.
6747         (check_parameter_typelist): Do not delete params.
6748         (function_method): Update.  Do not delete type_list.
6749
6750 2019-01-06  Tom Tromey  <tom@tromey.com>
6751
6752         PR gdb/28155:
6753         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6754         check_typedef.
6755         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6756         (print_return_value): Likewise.
6757
6758 2019-01-05  Tom Tromey  <tom@tromey.com>
6759
6760         * contrib/cleanup_check.py: Remove.
6761         * contrib/gcc-with-excheck: Remove.
6762         * contrib/exsummary.py: Remove.
6763         * contrib/excheck.py: Remove.
6764
6765 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6766
6767         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6768         NULL. Initialize tpprev to NULL instead of assigning it
6769         to NULL on the next statement.
6770         * windows-nat.c (windows_delete_thread): Remove check for
6771         main_thread_id before printing thread exit notifications.
6772         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6773         Remove thread ID check against main_thread_id.
6774         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6775         windows_delete_thread.
6776         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6777
6778 2019-01-04  Tom Tromey  <tom@tromey.com>
6779
6780         * compile/compile.c (_initialize_compile): Use upper case for
6781         metasyntactic variables.
6782         * symmisc.c (_initialize_symmisc): Use upper case for
6783         metasyntactic variables.
6784         * psymtab.c (_initialize_psymtab): Use upper case for
6785         metasyntactic variables.
6786         * demangle.c (demangle_command): Use upper case for metasyntactic
6787         variables.
6788         (_initialize_demangler): Likewise.
6789         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6790         variables.
6791
6792 2019-01-03  Tom Tromey  <tom@tromey.com>
6793
6794         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6795
6796 2019-01-03  Tom Tromey  <tom@tromey.com>
6797
6798         * python/py-symtab.c (salpy_str): Update.
6799         (struct salpy_sal_object) <symtab>: Now a PyObject.
6800         (salpy_dealloc): Update.
6801         (del_objfile_sal): Use gdbpy_ref.
6802
6803 2019-01-03  Tom Tromey  <tom@tromey.com>
6804
6805         * python/py-type.c (convert_field): Use new_reference.  Return
6806         gdbpy_ref.
6807         (make_fielditem): Return gdbpy_ref.
6808         (typy_fields): Update.
6809         (typy_getitem): Update.
6810         (field_name): Return gdbpy_ref.  Use new_reference.
6811         (typy_iterator_iternext): Update.
6812
6813 2019-01-03  Tom Tromey  <tom@tromey.com>
6814
6815         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6816
6817 2019-01-03  Tom Tromey  <tom@tromey.com>
6818
6819         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6820         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6821         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6822         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6823         (pspy_set_type_printers): Likewise.
6824         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6825         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6826         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6827         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6828         (objfpy_set_type_printers): Likewise.
6829
6830 2019-01-03  Tom Tromey  <tom@tromey.com>
6831
6832         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6833         (gdbpy_print_stack): Use gdbpy_err_fetch.
6834         * python/python-internal.h (class gdbpy_err_fetch): New class.
6835         (class gdbpy_enter) <m_error_type, m_error_value,
6836         m_error_traceback>: Remove.
6837         <m_error>: New member.
6838         (gdbpy_exception_to_string): Don't declare.
6839         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6840         * python/py-value.c (convert_value_from_python): Use
6841         gdbpy_err_fetch.
6842         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6843         gdbpy_exception_to_string.
6844         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6845         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6846         gdbpy_err_fetch.
6847
6848 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6849
6850         * linux-nat.c (delete_lwp_cleanup): Delete.
6851         (struct lwp_deleter): New struct.
6852         (lwp_info_up): New typedef.
6853         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6854         lwp_info_up.
6855
6856 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6857
6858         * linux-fork.c (class scoped_switch_fork_info): New class.
6859         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6860
6861 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6862
6863         * valops.c (find_overload_match): Remove use of null_cleanup, and
6864         calls to do_cleanups.
6865
6866 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6867
6868         * compile/compile-cplus-types.c
6869         (compile_cplus_instance::decl_name): Handle changes to
6870         cp_func_name.
6871         * cp-support.c (cp_func_name): Update header comment, update
6872         return type.
6873         * cp-support.h (cp_func_name): Update return type in declaration.
6874         * valops.c (find_overload_match): Move temp_func local to top
6875         level of function and change its type.  Use temp_func to hold and
6876         delete temporary string obtained from cp_func_name.
6877
6878 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6879
6880         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6881         gdb::char_vector, remove cleanup, and update uses of `msg`.
6882
6883 2019-01-03  Jim Wilson  <jimw@sifive.com>
6884
6885         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6886
6887 2019-01-02  Tom Tromey  <tom@tromey.com>
6888
6889         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6890         (tdesc_parse_xml): Remove cleanups.
6891         * target-descriptions.h (make_cleanup_free_target_description):
6892         Don't declare.
6893         (target_desc_deleter): New struct.
6894         (target_desc_up): New typedef.
6895         * target-descriptions.c (target_desc_deleter::operator()): Rename
6896         from free_target_description.
6897         (make_cleanup_free_target_description): Remove.
6898
6899 2019-01-02  Tom Tromey  <tom@tromey.com>
6900
6901         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6902         constructor, destructor.
6903         (linespec_parser): Remove typedef.
6904         (~linespec_parser): Rename from linespec_parser_delete.
6905         (linespec_lex_to_end, linespec_complete_label)
6906         (linespec_complete): Update.
6907         (decode_line_full): Remove cleanups.
6908         (decode_line_1): Update.
6909
6910 2019-01-02  Tom Tromey  <tom@tromey.com>
6911
6912         * python/python-internal.h (inferior_to_inferior_object): Change
6913         return type.
6914         * python/py-exitedevent.c (create_exited_event_object): Update.
6915         * python/py-inferior.c (inferior_to_inferior_object): Return
6916         gdbpy_ref.
6917         (python_new_inferior, python_inferior_deleted)
6918         (thread_to_thread_object, delete_thread_object)
6919         (build_inferior_list, gdbpy_selected_inferior): Update.
6920         * python/py-infthread.c (create_thread_object): Update.  Also fail
6921         if inferior_to_inferior_object fails.
6922
6923 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6924
6925         * inferior.h (class inferior) <displaced_step_state>: New field.
6926         * infrun.h (struct displaced_step_state): Move here from
6927         infrun.c.  Initialize fields, add constructor.
6928         <inf>: Remove field.
6929         <reset>: New method.
6930         * infrun.c (struct displaced_step_inferior_state): Move to
6931         infrun.h.
6932         (displaced_step_inferior_states): Remove.
6933         (get_displaced_stepping_state): Adust.
6934         (displaced_step_in_progress_any_inferior): Adjust.
6935         (displaced_step_in_progress_thread): Adjust.
6936         (displaced_step_in_progress): Adjust.
6937         (add_displaced_stepping_state): Remove.
6938         (get_displaced_step_closure_by_addr): Adjust.
6939         (remove_displaced_stepping_state): Remove.
6940         (infrun_inferior_exit): Call displaced_step_state.reset.
6941         (use_displaced_stepping): Don't check for NULL.
6942         (displaced_step_prepare_throw): Call
6943         get_displaced_stepping_state.
6944         (displaced_step_fixup): Don't check for NULL.
6945         (prepare_for_detach): Don't check for NULL.
6946
6947 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6948
6949         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6950          in case of call that did not complete.
6951
6952 2019-01-02  Andrey Utkin  <autkin@undo.io>
6953
6954         * symfile.c (find_separate_debug_file): Fix search of debug files for
6955         remote debuggee.
6956
6957 2019-01-02  Tom Tromey  <tom@tromey.com>
6958
6959         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6960         indentation.
6961         * python/py-frame.c (frapy_older): Remove cast.
6962         (frapy_newer): Likewise.
6963         * python/py-breakpoint.c (local_setattro): Remove cast.
6964         * python/py-arch.c (archpy_name): Remove local variable.
6965         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6966
6967 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6968
6969         * unittests/basic_string_view/element_access/char/empty.cc:
6970         Fix year range in copyright header.
6971
6972 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6973
6974         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6975         Delete.
6976         <operator==>: Update with for removed field.
6977         <hash>: Likewise.
6978         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6979         <isa_features>: ...this.
6980         <abi_features>: New field.
6981         (riscv_isa_flen): Update comment.
6982         (riscv_abi_xlen): New declaration.
6983         (riscv_abi_flen): New declaration.
6984         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6985         isa_features.
6986         (riscv_abi_xlen): New function.
6987         (riscv_isa_flen): Update to get answer from isa_features.
6988         (riscv_abi_flen): New function.
6989         (riscv_has_fp_abi): Update to get answer from abi_features.
6990         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6991         xlen and flen.
6992         (riscv_call_info) <xlen, flen>: Update comment.
6993         (riscv_call_arg_struct): Remove invalid assertions
6994         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6995         is removed.
6996         (riscv_gdbarch_init): Gather isa features and abi features
6997         separately, ensure both match on the gdbarch when reusing an old
6998         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6999         a target with 64-bit float hardware.
7000
7001 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7002
7003         * source.c (search_command_helper): Stop reverse search
7004         when line 1 has been searched.
7005
7006 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7007
7008         * record-full.c (record_full_base_target::close): Rewrite
7009         record_full_core_buf_list free logic.
7010
7011 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7012
7013         * break-catch-syscall.c (print_one_catch_syscall): xfree
7014         the last text.
7015
7016 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7017
7018         * top.c (print_gdb_version): Update Copyright year in version
7019         message.
7020
7021 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7022
7023         Update copyright year range in all GDB files.
7024
7025 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7026
7027         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7028
7029 For older changes see ChangeLog-2018.
7030 \f
7031 Local Variables:
7032 mode: change-log
7033 left-margin: 8
7034 fill-column: 74
7035 version-control: never
7036 coding: utf-8
7037 End:
7038