gdb/ChangeLog

   1 2019-06-11  Tom Tromey  <tom@tromey.com>
   2
   3         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
   4         (xmalloc_failed): Move to alloc.c.
   5         * alloc.c: New file.
   6         * Makefile.in (COMMON_SFILES): Add alloc.c.
   7
   8 2019-06-11  Tom Tromey  <tom@tromey.com>
   9
  10         * nat/linux-waitpid.c: Don't include server.h.
  11         (linux_debug): Remove.
  12         (my_waitpid): Update.
  13
  14 2019-06-11  Tom Tromey  <tromey@adacore.com>
  15
  16         * infcall.c (_initialize_infcall): Remove trailing newline from
  17         help.
  18         * user-regs.c (_initialize_user_regs): Remove trailing newline
  19         from help.
  20         * typeprint.c (_initialize_typeprint): Remove trailing newline
  21         from help.
  22         * reverse.c (_initialize_reverse): Remove trailing newlines from
  23         help.
  24         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
  25         from help.
  26         * language.c (add_set_language_command): Remove trailing newline
  27         from help.
  28         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
  29         help.
  30         * disasm.c (_initialize_disasm): Remove trailing newline from
  31         help.
  32         * top.c (init_main): Remove trailing newline from help.
  33         * interps.c (_initialize_interpreter): Remove trailing newline
  34         from help.
  35         * btrace.c (_initialize_btrace): Remove trailing newlines from
  36         help.
  37         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
  38         from help.
  39         * python/python.c (_initialize_python): Remove trailing newline
  40         from help.
  41         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
  42         help.
  43         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
  44         from help.  Reformat some text.
  45         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
  46         from help.
  47         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
  48         newline from help.
  49
  50 2019-06-11  Tom Tromey  <tromey@adacore.com>
  51
  52         * darwin-nat.c (darwin_decode_exception_message)
  53         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
  54
  55 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
  56
  57         * valops.c (value_slice): Check for not allocated or not
  58         associated values.
  59
  60 2019-06-10  Tom de Vries  <tdevries@suse.de>
  61
  62         PR gdb/24618
  63         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
  64         sure an empty slot (defined by a 32-bit zero pair) is recognized as
  65         invalid.
  66
  67 2019-06-10  Tom de Vries  <tdevries@suse.de>
  68
  69         PR gdb/24611
  70         * linespec.c (linespec_lexer_lex_string): Remove incorrect
  71         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
  72
  73 2019-06-10  Tom de Vries  <tdevries@suse.de>
  74
  75         PR symtab/24545
  76         * symtab.c (struct demangled_name_entry): Add language field.
  77         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
  78         static minimal symbol".  Set and use language field.
  79
  80 2019-06-10  Tom Tromey  <tromey@adacore.com>
  81
  82         * ada-lang.c (_initialize_ada_language): Update help text.
  83
  84 2019-06-10  Tom Tromey  <tromey@adacore.com>
  85
  86         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
  87         with a newline.
  88         * guile/guile.c (handle_boot_error): Don't end warning with a
  89         newline.
  90         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
  91         warning with a newline.
  92         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
  93         newline.
  94         (s12z_frame_cache): Likewise.
  95         * dwarf-index-cache.c (index_cache::store): Don't end warning with
  96         a newline.
  97         * solib-svr4.c (disable_probes_interface): Don't end warning with
  98         a newline.
  99         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 100         newline.
 101         * python/python.c (do_finish_initialization): Don't end warning
 102         with a newline.
 103
 104 2019-06-10  Tom Tromey  <tom@tromey.com>
 105
 106         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 107         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 108         gdbpy_enter.
 109
 110 2019-06-10  Tom Tromey  <tromey@adacore.com>
 111
 112         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 113         data.
 114         (elf_new_init): Don't call stabsread_new_init.
 115         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 116         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 117         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 118
 119 2019-06-10  Tom de Vries  <tdevries@suse.de>
 120
 121         PR symtab/16264
 122         PR symtab/24517
 123         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 124
 125 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 126
 127         * source.c (find_and_open_source): Also rewrite relative file
 128         names.
 129
 130 2019-04-26  Amos Bird  <amosbird@gmail.com>
 131
 132         * annotate.c (annotate_thread_exited): Add "thread-exited"
 133         annotation.
 134
 135 2019-06-06  Tom Tromey  <tromey@adacore.com>
 136
 137         * maint.h (class scoped_command_stats): Use
 138         DISABLE_COPY_AND_ASSIGN.
 139         <print_time>: New method.
 140         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 141         print_time.
 142         (scoped_command_stats::print_time): New method.
 143
 144 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 145
 146         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 147         instructions of lengths 6 or 8 bytes.
 148
 149 2019-06-04  Pedro Alves  <palves@redhat.com>
 150
 151         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 152
 153         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 154         * breakpoint.c (condition_completer): Likewise.
 155         * cli/cli-dump.c (scan_expression): Likewise.
 156         * common/filestuff.c (mkdir_recursive): Likewise.
 157         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 158         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 159         (gdb_abspath): Likewise.
 160         * compile/compile-cplus-types.c
 161         (compile_cplus_instance::decl_name): Likewise.
 162         * completer.c (complete_explicit_location):
 163         (signal_completer, reg_or_group_completer_1): Likewise.
 164         * cp-support.c (cp_remove_params_if_any): Likewise.
 165         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 166         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 167         * infcmd.c (strip_bg_char): Likewise.
 168         * linespec.c (copy_token_string): Likewise.
 169         * mi/mi-main.c (output_cores): Likewise.
 170         * psymtab.c (psymtab_search_name):
 171         * symfile.c (test_set_ext_lang_command): Likewise.
 172         * target.c (target_fileio_read_stralloc): Likewise.
 173         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 174         * value.c (complete_internalvar): Likewise.
 175
 176 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 177
 178         Add objfile property to gdb.Type.
 179         * NEWS: Mention Python API addition.
 180         * python/py-type.c (typy_get_objfile): New method.
 181
 182 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 183
 184         * NEWS: Mention the new set|show style [title|highlight].
 185         Mention changes to "show style", "help" and "apropos".
 186
 187 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 188
 189         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 190         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 191         instead of print_help_for_command.
 192         (print_doc_of_command): New function.
 193         (help_list): Add 'apropos -v word' suggestion.
 194         (print_help_for_command): Style the command name using title style.
 195         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 196         (_initialize_cli_cmds): Describe -v in apropos_command help.
 197
 198 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 199
 200         * cli/cli-style.h (cli_style_option): Add name in constructor,
 201         add m_name class member, add constructor with intensity,
 202         add name class function.
 203         (cli_style_option::add_setshow_commands): Remove name argument.
 204         (highlight_style, title_style): New styles.
 205         * cli/cli-style.c (do_show): New function that shows a style
 206         characteristic styling the style name with itself.
 207         (set_style_name): New function.
 208         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 209         Update all callers according to the changes in cli/cli-style.h.
 210         * utils.h (fputs_highlighted): New function.
 211         * utils.c (fputs_highlighted): Likewise.
 212
 213 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 214
 215         * NEWS: Mention new pipe command and new convenience variables.
 216
 217 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 218
 219         * cli/cli-cmds.c (pipe_command): New function.
 220         (_initialize_cli_cmds): Call add_com for pipe_command.
 221         Define | as an alias for pipe.
 222         (exit_status_set_internal_vars): New function.
 223         (shell_escape): Call exit_status_set_internal_vars.
 224         cli/cli-decode.c (find_command_name_length): Recognize | as
 225         a single character command.
 226
 227 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 228
 229         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 230         top.c (execute_command_to_ui_file): New function, mostly a copy
 231         of execute_command_to_string.
 232         (execute_command_to_string): Implement by calling
 233         execute_command_to_ui_file.
 234
 235 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 236
 237         * top.h (saved_command_line): Remove declaration.
 238         * top.c (previous_saved_command_line, previous_repeat_arguments):
 239         New variables.
 240         (saved_command_line): Make static, define together with other
 241         'repeat variables'.
 242         (dont_repeat): Clear repeat_arguments.
 243         (repeat_previous, get_saved_command_line, save_command_line):
 244         New functions.
 245         (gdb_init): Initialize saved_command_line
 246         and previous_saved_command_line.
 247         * main.c (captured_main_1): Remove saved_command_line initialization.
 248         * event-top.c (handle_line_of_input): Update to use
 249         the new 'repeat' related functions instead of direct access to
 250         saved_command_line.
 251         * command.h (repeat_previous, get_saved_command_line,
 252         save_command_line): New declarations.
 253         (dont_repeat): Add comment.
 254
 255 2019-05-30  Tom Tromey  <tromey@adacore.com>
 256
 257         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 258         Fix comment.
 259         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 260
 261 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 262
 263         PR cli/24587
 264         * completer.c (complete): Initialize variable word.
 265
 266 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 267
 268         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 269         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 270         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 271         'body' is NULL to the outter 'if', protecting the '!is_define'
 272         situation as well.
 273
 274 2019-05-29  Tom Tromey  <tromey@adacore.com>
 275
 276         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 277         (dwarf_unknown): New function.
 278         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 279         (dwarf_type_encoding_name): Use dwarf_unknown.
 280
 281 2019-05-29  Tom Tromey  <tromey@adacore.com>
 282
 283         PR c++/20020:
 284         * cp-valprint.c (cp_print_value_fields): Call
 285         cp_print_static_field inside "try".
 286
 287 2019-05-29  Tom Tromey  <tromey@adacore.com>
 288
 289         * inflow.c (struct terminal_info): Add default operator=.
 290         * configure: Rebuild.
 291         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 292         -Wdeprecated-copy-dtor, -Wredundant-move.
 293
 294 2019-05-29  Tom Tromey  <tromey@adacore.com>
 295
 296         * NEWS: Add entry.
 297         * infcmd.c (print_return_value_1): Handle finish_print
 298         option.
 299         (show_print_finish): New function.
 300         (_initialize_infcmd): Add "set/show print finish" commands.
 301         * valprint.c (user_print_options): Initialize new member.
 302         * valprint.h (struct value_print_options) <finish_print>: New
 303         member.
 304
 305 2019-05-28  Tom Tromey  <tromey@adacore.com>
 306
 307         * ada-lang.c (ada_remove_Xbn_suffix)
 308         (find_old_style_renaming_symbol)
 309         (parse_old_style_renaming): Remove.
 310         (ada_find_renaming_symbol): Don't call
 311         find_old_style_renaming_symbol.
 312         (ada_is_renaming_symbol): Rename from
 313         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 314         bool.  Now static.
 315         (ada_read_var_value): Update and simplify.
 316         * ada-exp.y (write_var_or_type): Remove old code.
 317
 318 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 319
 320         * event-top.c: Remove include comment.
 321         * inflow.c (class scoped_ignore_sigttou): Move from here...
 322         * inflow.h (class scoped_ignore_sigttou): ...to here.
 323         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 324         * top.c:  Remove include comment.
 325
 326 2019-05-27  Tom Tromey  <tom@tromey.com>
 327
 328         * NEWS: Fix typo.
 329
 330 2019-05-22  Tom Tromey  <tromey@adacore.com>
 331
 332         * target.c (target_follow_exec): Constify parameter.
 333         * target-delegates.c: Rebuild.
 334         * remote.c (remote_target::follow_exec): Constify parameter.
 335         * infrun.c (follow_exec): Constify parameter.
 336         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 337         (target_follow_exec): Likewise.
 338
 339 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 340
 341         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 342         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 343
 344 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 345
 346         * NEWS: Add debugredirect and testsuite sections.
 347
 348 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 349
 350         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 351         target descriptions using exclusively floating point register name
 352         aliases.
 353
 354 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 355
 356         PR gdb/18644:
 357         * f-lang.c (build_fortran_types): Handle the case where
 358         gdbarch_floatformat_for_type returns a nullptr.
 359
 360 2019-05-21  Tom de Vries  <tdevries@suse.de>
 361
 362         PR cli/24587
 363         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 364
 365 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 366
 367         PR gdb/18644:
 368         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 369         16-byte floats.
 370         * i386-tdep.c (i386_floatformat_for_type): Use
 371         floatformats_ia64_quad for the 16-byte floating point component
 372         within a fortran 32-byte complex number.
 373
 374 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 375
 376         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 377         delete default constructor.
 378         (find_partial_die): Update to return const struct.
 379         (partial_die_parent_scope): Move variable declaration into scope
 380         of its use and change its type to auto.
 381         (guess_partial_die_structure_name): Likewise.
 382         (partial_die_info::fixup): Likewise.
 383
 384 2019-05-17  Tom Tromey  <tromey@adacore.com>
 385
 386         * source.c (find_and_open_source): Remove cast.
 387
 388 2019-05-17  Tom Tromey  <tromey@adacore.com>
 389
 390         * annotate.c (annotate_source): Make "filename" const.
 391         * annotate.h (annotate_source): Use const.
 392
 393 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 394
 395         * disasm.c (set_disassembler_options): Send errors to stderr.
 396
 397 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 398
 399         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 400         (cli_interp_base::set_logging): Check debug_redirect.
 401         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 402         * cli/cli-logging.c (debug_redirect): Add static variable.
 403         (pop_output_files): Add default param.
 404         (handle_redirections): Print debug setting.
 405         (show_logging_command): Likewise.
 406         (_initialize_cli_logging): Add debugredirect command.
 407         * interps.c (current_interp_set_logging): Add debug_redirect
 408         parameter.
 409         * interps.h (set_logging): Add debug_redirect parameter.
 410         (current_interp_set_logging): Likewise.
 411         * mi/mi-common.h: Likewise.
 412         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 413
 414 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 415             Tom Tromey  <tromey@adacore.com>
 416
 417         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 418         directly.
 419         * cli/cli-interp.h (make_logging_output): Remove declaration.
 420         * cli/cli-logging.c (make_logging_output): Remove function.
 421         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 422         directly.
 423         * ui-file.c (tee_file::tee_file): Remove bools.
 424         (tee_file::~tee_file): Remove deletes.
 425         * ui-file.h (tee_file): Remove bools.
 426
 427 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 428
 429         * mi/mi-cmds.h (mi_cmd_complete): New function.
 430         * mi/mi-main.c (mi_cmd_complete): Likewise.
 431         * mi/mi-cmds.c: Define new MI command -complete.
 432         * NEWS: Mention new -complete command.
 433
 434 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 435
 436         * completer.h (complete): New function.
 437         * completer.c (complete): Likewise.
 438         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 439         function defined in completer.h.
 440
 441 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 442
 443        * MAINTAINERS (Write After Approval): Add myself.
 444
 445 2019-05-17  Tom de Vries  <tdevries@suse.de>
 446
 447         PR gdb/24094
 448         * dwarf2read.c (struct cu_partial_die_info): New struct.
 449         (find_partial_die): Return cu_partial_die_info.
 450         (partial_die_parent_scope, guess_partial_die_structure_name)
 451         (partial_die_info::fixup): Handle new return type of find_partial_die.
 452
 453 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 454
 455         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 456         "std::string", simplifying the algorithm.
 457
 458 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 459
 460         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 461         (stap_static_probe_ops::get_probes): Likewise.
 462
 463 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 464
 465         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 466         '-')" and "else if".
 467         (stap_parse_single_operand): Join checks for
 468         "gdbarch_stap_parse_special_token_p" and
 469         "gdbarch_stap_parse_special_token" in the same "if" statement.
 470         Invert check when verifying for operation on register
 471         displacement.
 472
 473 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 474
 475         * stap-probe.c (stap_get_opcode): Update comment.
 476         (stap_get_expected_argument_type): Likewise.
 477         (handle_stap_probe): Likewise.
 478
 479 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 480
 481         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 482         return type to 'bool'.  Adjust comment.  Use 'bool' when
 483         appropriate.
 484         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 485         * stap-probe.c (stap_parse_argument_1): Likewise.
 486         (stap_is_operator): Likewise.
 487         (stap_is_generic_prefix): Likewise.
 488         (stap_is_register_prefix): Likewise.
 489         (stap_is_register_indirection_prefix): Likewise.
 490         (stap_is_integer_prefix): Likewise.
 491         (stap_generic_check_suffix): Likewise.
 492         (stap_check_integer_suffix): Likewise.
 493         (stap_check_register_suffix): Likewise.
 494         (stap_check_register_indirection_suffix): Likewise.
 495         (stap_parse_register_operand): Likewise.
 496         (stap_parse_single_operand): Likewise.
 497         (stap_parse_argument_1): Likewise.
 498         (stap_probe::get_argument_count): Likewise.
 499         (stap_is_operator): Likewise.
 500
 501 2019-05-16  Tom Tromey  <tromey@adacore.com>
 502
 503         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 504         keyword to foreach.
 505
 506 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 507
 508         * linux-thread-db.c (try_thread_db_load_1): Change return type
 509         to bool.
 510         (try_thread_db_load): Likewise.
 511         (try_thread_db_load_from_pdir_1): Likewise.
 512         (try_thread_db_load_from_pdir): Likewise.
 513         (try_thread_db_load_from_sdir): Likewise.
 514         (try_thread_db_load_from_dir): Likewise.
 515         (thread_db_load_search): Likewise.
 516         (has_libpthread): Likewise.
 517         (thread_db_load): Likewise.
 518
 519 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 520
 521         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 522         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 523         NULL, and complain/return if that's the case.
 524
 525 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 526
 527         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 528         (advance, posn, abstract_read_memory): New functions.
 529         [struct mem_read_abstraction]: New struct.
 530         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 531
 532 2019-05-14  Tom Tromey  <tromey@adacore.com>
 533
 534         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 535         value is not lval_memory.
 536
 537 2019-05-14  Tom Tromey  <tromey@adacore.com>
 538
 539         * solib.c (info_sharedlibrary_command): Style the file name.
 540
 541 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 542
 543         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 544         (aarch64_vnv_type): Likewise.
 545         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 546         * common/tdesc.c: Likewise.
 547         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 548         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 549         * features/aarch64-fpu.xml: Add ieee half view.
 550         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 551         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 552         * gdbtypes.h (struct builtin_type): Likewise.
 553         (struct objfile_type): Likewise.
 554
 555 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 556
 557         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 558         typo.
 559         * location.h (string_to_event_location): Likewise.
 560
 561 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 562
 563         GDB 8.3 released.
 564
 565 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 566
 567         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 568         New variable declaration.
 569         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 570         New variable.
 571         (print_one_breakpoint): Use ui_out::test_flags and new global
 572         variable to compute use_fixed_output.
 573         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 574         Remove.
 575         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 576         (mi_multi_location_breakpoint_output_fixed): Remove.
 577         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 578         new variable.
 579         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 580         fix_multi_location_breakpoint_output flag if version >= 3.
 581         * ui-out.h (enum ui_out_flag)
 582         <fix_multi_location_breakpoint_output>: New enumerator.
 583
 584 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 585
 586         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 587
 588 2019-05-10  Tom Tromey  <tromey@adacore.com>
 589
 590         * ada-lang.c (catch_ada_completer): New function.
 591         (_initialize_ada_language): Use it.
 592
 593 2019-05-10  Tom Tromey  <tromey@adacore.com>
 594
 595         * thread.c (print_thread_info): Make "requested_threads" const.
 596         * gdbthread.h (print_thread_info): Make "requested_threads"
 597         const.
 598         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 599         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 600
 601 2019-05-08  Tom Tromey  <tom@tromey.com>
 602
 603         * gdbtypes.c (objfile_type_data): Change type.
 604         (objfile_type, _initialize_gdbtypes): Update.
 605
 606 2019-05-08  Tom Tromey  <tom@tromey.com>
 607
 608         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 609         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 610         (_initialize_dwarf2_frame): Update.
 611
 612 2019-05-08  Tom Tromey  <tom@tromey.com>
 613
 614         * objc-lang.c (objc_objfile_data): Change type.
 615         (find_methods): Update.
 616         (_initialize_objc_lang): Remove.
 617
 618 2019-05-08  Tom Tromey  <tom@tromey.com>
 619
 620         * stabsread.c (rs6000_builtin_type_data): Change type.
 621         (rs6000_builtin_type, _initialize_stabsread): Update.
 622
 623 2019-05-08  Tom Tromey  <tom@tromey.com>
 624
 625         * mips-tdep.c (mips_pdr_data): Remove.
 626         (_initialize_mips_tdep): Update.
 627
 628 2019-05-08  Tom Tromey  <tom@tromey.com>
 629
 630         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 631         (hppa_init_objfile_priv_data, read_unwind_info)
 632         (find_unwind_entry, _initialize_hppa_tdep): Update.
 633
 634 2019-05-08  Tom Tromey  <tom@tromey.com>
 635
 636         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 637         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 638         on obstack.
 639         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 640
 641 2019-05-08  Tom Tromey  <tom@tromey.com>
 642
 643         * mdebugread.c (basic_type_data): Change type.
 644         (basic_type, _initialize_mdebugread): Update.
 645
 646 2019-05-08  Tom Tromey  <tom@tromey.com>
 647
 648         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 649
 650 2019-05-08  Tom Tromey  <tom@tromey.com>
 651
 652         * nto-tdep.c (nto_inferior_data_reg): Change type.
 653         (nto_inferior_data): Update.
 654         (nto_inferior_data_cleanup, nto_new_inferior_data)
 655         (_initialize_nto_tdep): Remove.
 656         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 657
 658 2019-05-08  Tom Tromey  <tom@tromey.com>
 659
 660         * ada-lang.c (struct ada_inferior_data): Add initializers.
 661         (ada_inferior_data): Change type.
 662         (ada_inferior_data_cleanup): Remove.
 663         (get_ada_inferior_data, ada_inferior_exit)
 664         (struct ada_pspace_data): Add initializers, destructor.
 665         (ada_pspace_data_handle): Change type.
 666         (get_ada_pspace_data): Update.
 667         (ada_pspace_data_cleanup): Remove.
 668
 669 2019-05-08  Tom Tromey  <tom@tromey.com>
 670
 671         * coffread.c (struct coff_symfile_info): Add initializers.
 672         (coff_objfile_data_key): Move lower.  Change type.
 673         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 674         Update.
 675         (coff_free_info): Remove.
 676
 677 2019-05-08  Tom Tromey  <tom@tromey.com>
 678
 679         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 680         (fbsd_pspace_data_handle): Move lower.  Change type.
 681         (get_fbsd_pspace_data): Update.
 682         (fbsd_pspace_data_cleanup): Remove.
 683         (_initialize_fbsd_tdep): Update.
 684
 685 2019-05-08  Tom Tromey  <tom@tromey.com>
 686
 687         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 688         (get_ada_tasks_pspace_data): Update.
 689         (ada_tasks_pspace_data_cleanup): Remove.
 690         (_initialize_tasks): Update.
 691         (ada_tasks_inferior_data_handle): Change type.
 692         (get_ada_tasks_inferior_data): Update.
 693         (ada_tasks_inferior_data_cleanup): Remove.
 694         (struct ada_tasks_pspace_data): Add initializers.
 695
 696 2019-05-08  Tom Tromey  <tom@tromey.com>
 697
 698         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 699         * symfile-debug.c (debug_sym_get_probes): Change type.
 700         * stap-probe.c (handle_stap_probe):
 701         (stap_static_probe_ops::get_probes): Change type.
 702         * probe.h (class static_probe_ops) <get_probes>: Change type.
 703         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 704         (parse_probes_in_pspace): Update.
 705         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 706         Update.
 707         (any_static_probe_ops::get_probes): Change type.
 708         * elfread.c (elfread_data): New typedef.
 709         (probe_key): Change type.
 710         (elf_get_probes): Likewise.  Update.
 711         (probe_key_free): Remove.
 712         (_initialize_elfread): Update.
 713         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 714         Change type.
 715         (dtrace_process_dof_probe, dtrace_process_dof)
 716         (dtrace_static_probe_ops::get_probe): Change type.
 717
 718 2019-05-08  Tom Tromey  <tom@tromey.com>
 719
 720         * xcoffread.c (struct xcoff_symfile_info): Rename from
 721         coff_symfile_info.  Add initializers.
 722         (xcoff_objfile_data_key): Move lower.  Change type.
 723         (XCOFF_DATA): Rewrite.
 724         (xcoff_free_info): Remove.
 725         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 726         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 727         (xcoff_initial_scan): Update.
 728
 729 2019-05-08  Tom Tromey  <tom@tromey.com>
 730
 731         * solib-svr4.c (struct svr4_info): Add initializers and
 732         destructor.
 733         <probes_table>: Now an htab_up.
 734         (solib_svr4_pspace_data): Change type.
 735         (free_probes_table): Simplify.
 736         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 737         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 738         (probes_table_remove_objfile_probes, register_solib_event_probe)
 739         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 740         (_initialize_svr4_solib): Update.
 741
 742 2019-05-08  Tom Tromey  <tom@tromey.com>
 743
 744         * remote.c (remote_pspace_data): Change type.
 745         (remote_pspace_data_cleanup): Remove.
 746         (get_remote_exec_file, set_pspace_remote_exec_file)
 747         (_initialize_remote): Update.
 748
 749 2019-05-08  Tom Tromey  <tom@tromey.com>
 750
 751         * breakpoint.c (breakpoint_objfile_key): Change type.
 752         (get_breakpoint_objfile_data): Update.
 753         (free_breakpoint_objfile_data): Remove.
 754         (_initialize_breakpoint): Update.
 755
 756 2019-05-08  Tom Tromey  <tom@tromey.com>
 757
 758         * linux-tdep.c (struct linux_info): Add initializers.
 759         (linux_inferior_data): Move.  Change type.
 760         (invalidate_linux_cache_inf): Update.
 761         (linux_inferior_data_cleanup): Remove.
 762         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 763
 764 2019-05-08  Tom Tromey  <tom@tromey.com>
 765
 766         * auxv.c (auxv_inferior_data): Move.  Change type.
 767         (auxv_inferior_data_cleanup): Remove.
 768         (invalidate_auxv_cache_inf): Rewrite.
 769         (get_auxv_inferior_data, _initialize_auxv): Update.
 770
 771 2019-05-08  Tom Tromey  <tom@tromey.com>
 772
 773         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 774         (symfile_debug_objfile_data_key): Change type.
 775         (symfile_debug_installed, debug_qf_has_symbols)
 776         (debug_qf_find_last_source_symtab)
 777         (debug_qf_forget_cached_source_info)
 778         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 779         (debug_qf_print_stats, debug_qf_dump)
 780         (debug_qf_expand_symtabs_for_function)
 781         (debug_qf_expand_all_symtabs)
 782         (debug_qf_expand_symtabs_with_fullname)
 783         (debug_qf_map_matching_symbols)
 784         (debug_qf_expand_symtabs_matching)
 785         (debug_qf_find_pc_sect_compunit_symtab)
 786         (debug_qf_map_symbol_filenames)
 787         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 788         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 789         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 790         (debug_sym_read_linetable, debug_sym_relocate): Update.
 791         (symfile_debug_free_objfile): Remove.
 792         (install_symfile_debug_logging, _initialize_symfile_debug):
 793         Update.
 794
 795 2019-05-08  Tom Tromey  <tom@tromey.com>
 796
 797         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 798         allocate_on_obstack.
 799         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 800         (get_dwarf2_per_objfile): Update.
 801         (set_dwarf2_per_objfile): Remove.
 802         (dwarf2_has_info, dwarf2_get_section_info): Update.
 803         (dwarf2_free_objfile): Remove.
 804         (_initialize_dwarf2_read): Update.
 805
 806 2019-05-08  Tom Tromey  <tom@tromey.com>
 807
 808         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 809         initializers.
 810         <unsupported_script_warning_printed,
 811         script_not_found_warning_printed>: Now bool.
 812         (auto_load_pspace_data): Change type.
 813         (~auto_load_pspace_info): Rename from
 814         auto_load_pspace_data_cleanup.
 815         (get_auto_load_pspace_data, init_loaded_scripts_info)
 816         (clear_section_scripts, maybe_print_unsupported_script_warning)
 817         (maybe_print_script_not_found_warning, _initialize_auto_load):
 818         Update.
 819
 820 2019-05-08  Tom Tromey  <tom@tromey.com>
 821
 822         * objfiles.c (objfile_pspace_info): Add destructor and
 823         initializers.
 824         (objfiles_pspace_data): Change type.
 825         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 826         (get_objfile_pspace_data): Update.
 827         (objfiles_bfd_data): Change type.
 828         (get_objfile_bfd_data): Update.
 829         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 830
 831 2019-05-08  Tom Tromey  <tom@tromey.com>
 832
 833         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 834         Change type.
 835         (get_catch_syscall_inferior_data): Update.
 836         (catch_syscall_inferior_data_cleanup): Remove.
 837         (_initialize_break_catch_syscall): Update.
 838
 839 2019-05-08  Tom Tromey  <tom@tromey.com>
 840
 841         * inflow.c (struct terminal_info): Add destructor and
 842         initializers.
 843         (inflow_inferior_data): Change type.
 844         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 845         (get_inflow_inferior_data, inflow_inferior_exit)
 846         (swap_terminal_info, _initialize_inflow): Update.
 847
 848 2019-05-08  Tom Tromey  <tom@tromey.com>
 849
 850         * target-dcache.c (target_dcache_cleanup): Remove.
 851         (target_dcache_aspace_key): Change type.
 852         (target_dcache_init_p, target_dcache_invalidate)
 853         (target_dcache_get, target_dcache_get_or_init)
 854         (_initialize_target_dcache): Update.
 855         * dcache.h (struct dcache_deleter): New.
 856
 857 2019-05-08  Tom Tromey  <tom@tromey.com>
 858
 859         * symtab.c (struct symbol_cache): Add destructor and
 860         initializers.
 861         (symbol_cache_key): Move.  Change type.
 862         (make_symbol_cache, free_symbol_cache): Remove.
 863         (get_symbol_cache): Update.
 864         (symbol_cache_cleanup): Remove.
 865         (ALL_PSPACES, symbol_cache_flush)
 866         (maintenance_print_symbol_cache)
 867         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 868         Update.
 869
 870 2019-05-08  Tom Tromey  <tom@tromey.com>
 871
 872         * symtab.c (struct main_info): Add destructor and initializers.
 873         (main_progspace_key): Move.  Change type.
 874         (get_main_info): Update.
 875         (main_info_cleanup): Remove.
 876         (_initialize_symtab): Update.
 877
 878 2019-05-08  Tom Tromey  <tom@tromey.com>
 879
 880         * registry.h (DECLARE_REGISTRY): Define the _key class.
 881
 882 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 883
 884         * NEWS: Merge two 'New commands' sections.
 885
 886 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 887
 888         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 889         parameter and use Ada language definition instead.
 890         (ada_val_print_ptr): Remove unused language parameter.
 891         (ada_val_print_num): Remove language parameter and use Ada language
 892         definition instead.
 893         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 894         parameter.
 895         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 896         parameter and use Ada language definition instead.
 897         (ada_val_print_1): Update all ada_val_print_xxx calls.
 898         Remove language parameter.
 899         (ada_val_print): Update ada_val_print_1 call.
 900
 901 2019-05-08  Tom Tromey  <tromey@adacore.com>
 902
 903         * remote.c (remote_hw_watchpoint_limit)
 904         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 905         Now static.
 906
 907 2019-05-08  Tom Tromey  <tromey@adacore.com>
 908
 909         * maint.c (_initialize_maint_cmds): Move initialization code to
 910         remote.c.
 911         (watchdog, show_watchdog): Move to remote.c.
 912         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 913         "watchdog" static.
 914         (_initialize_remote): Move initialization code from maint.c.
 915         * defs.h (watchdog): Don't declare.
 916
 917 2019-05-08  Tom Tromey  <tromey@adacore.com>
 918
 919         * tui/tui-interp.c: Include main.h.
 920         * interps.c: Include main.h.
 921         * main.h (interpreter_p): Declare.
 922         * defs.h (interpreter_p): Don't declare.
 923
 924 2019-05-08  Tom Tromey  <tromey@adacore.com>
 925
 926         * dwarf2loc.c: Include dwarf2read.h.
 927         * defs.h (read_unsigned_leb128): Don't declare.
 928         * dwarf2read.h (read_unsigned_leb128): Declare.
 929
 930 2019-05-08  Tom Tromey  <tromey@adacore.com>
 931
 932         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 933         method.
 934
 935 2019-05-08  Tom Tromey  <tromey@adacore.com>
 936
 937         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 938         when no wrap column is set.
 939
 940 2019-05-08  Tom Tromey  <tromey@adacore.com>
 941
 942         * c-lang.c (c_get_string): Handle non-C-style arrays.
 943
 944 2019-05-08  Tom Tromey  <tromey@adacore.com>
 945
 946         * typeprint.c (print_offset_data::update): Print the bit offset,
 947         not the number of bits remaining.
 948
 949 2019-05-08  Tom Tromey  <tromey@adacore.com>
 950
 951         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 952         padding at end of comment.
 953
 954 2019-05-08  Tom Tromey  <tromey@adacore.com>
 955
 956         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 957         Compare main types.
 958
 959 2019-05-06  Tom Tromey  <tom@tromey.com>
 960
 961         * common/scoped_mmap.c: Include common-defs.h.
 962         * common/scoped_mmap.h: Don't include config.h.
 963
 964 2019-05-04  Tom Tromey  <tom@tromey.com>
 965
 966         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 967         (struct aarch64_call_info): Add initializers.
 968         <si>: Now a std::vector.
 969         (pass_on_stack, aarch64_push_dummy_call): Update.
 970
 971 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 972             Tom Tromey  <tom@tromey.com>
 973
 974         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 975         (ppc_threads): Now a std::vector.  Now static.
 976         (hwdebug_find_thread_points_by_tid)
 977         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 978         Update.
 979
 980 2019-05-04  Tom Tromey  <tom@tromey.com>
 981
 982         * arc-tdep.c (arc_tdesc_init): Return bool.
 983
 984 2019-05-04  Tom Tromey  <tom@tromey.com>
 985
 986         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 987         Use gdb_assert_not_reached.
 988
 989 2019-05-04  Tom Tromey  <tom@tromey.com>
 990
 991         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 992         "false".
 993
 994 2019-05-04  Tom Tromey  <tom@tromey.com>
 995
 996         * arc-tdep.c (arc_tdesc_init): Use bool.
 997
 998 2019-05-04  Tom Tromey  <tom@tromey.com>
 999
1000         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1001
1002 2019-05-04  Tom Tromey  <tom@tromey.com>
1003
1004         * cli/cli-cmds.c (valid_command_p): Return bool.
1005
1006 2019-05-04  Tom Tromey  <tom@tromey.com>
1007
1008         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1009         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1010
1011 2019-05-04  Raul Tambre  <raul@tambre.ee>
1012
1013         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1014         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1015         operator for comparison.
1016
1017 2019-05-04  Tom Tromey  <tom@tromey.com>
1018
1019         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1020         (lookup_partial_symbol, print_partial_symbols)
1021         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1022         (psymbol_compare): Update.
1023         (add_psymbol_to_bcache): Clear the entire psymbol.
1024         (maintenance_check_psymtabs): Update.
1025         * psympriv.h (struct partial_symbol): Don't derive from
1026         general_symbol_info.
1027         <obj_section, unrelocated_address, address,
1028         set_unrelocated_address>: Update.
1029         <ginfo>: New member.
1030         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1031         (debug_names::write_psymbols): Update.
1032
1033 2019-05-04  Tom de Vries  <tdevries@suse.de>
1034
1035         * contrib/cc-with-tweaks.sh: Support -n arg.
1036
1037 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1038
1039         * corelow.c (core_target::detach): Ensure frame cache and
1040         register caches are cleared.
1041         inferior.c (exit_inferior_1): Likewise.
1042
1043 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1044             Tom Tromey  <tom@tromey.com>
1045
1046         * dictionary.c (collate_pending_symbols_by_language): Remove
1047         "struct" from foreach.
1048         * symtab.c (lookup_global_symbol_from_objfile)
1049         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1050         foreach.
1051         * ser-tcp.c (net_open): Remove "struct" from foreach.
1052         * objfiles.c (objfile_relocate, objfile_rebase)
1053         (objfile_has_symbols): Remove "struct" from foreach.
1054         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1055         from foreach.
1056         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1057         foreach.
1058         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1059         "struct" from foreach.
1060         * ada-lang.c (create_excep_cond_exprs)
1061         (ada_exception_catchpoint_cond_string): Remove "struct" from
1062         foreach.
1063
1064 2019-05-03  Tom Tromey  <tromey@adacore.com>
1065
1066         * ada-exp.y (convert_char_literal): Check suffix of each
1067         enumerator.
1068
1069 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1070
1071         PR ada/21406:
1072         * ada-exp.y (yywrap): Don't define.
1073         * ada-lex.l (%option): Add noyywrap
1074         (yywrap): Remove.
1075
1076 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1077
1078         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1079         _WIN32_WINNT to the XP level, unless already defined to a higher
1080         level.
1081
1082         * unittests/parse-connection-spec-selftests.c:
1083         * ser-tcp.c:
1084         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1085         override.
1086
1087         * symfile.c (find_separate_debug_file): Remove colon from the
1088         drive spec of DOS/Windows file names of the target, so that the
1089         file name produced from DEBUGDIR and the target's directory will
1090         be valid on DOS/Windows systems.
1091
1092 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1093
1094         * rust-lang.c (val_print_struct): Handle printing structures
1095         containing strings.
1096
1097 2019-05-02  Tom Tromey  <tromey@adacore.com>
1098
1099         * valarith.c (_initialize_valarith): Remove.
1100
1101 2019-05-01  Tom Tromey  <tromey@adacore.com>
1102
1103         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1104         bitfields.
1105
1106 2019-05-01  Tom Tromey  <tromey@adacore.com>
1107
1108         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1109         for big-endian copies.
1110
1111 2019-04-30  Ali Tamur  <tamur@google.com>
1112         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1113         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1114         (read_3_bytes): New function.
1115
1116 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1117
1118         * windows-nat.c (main_thread_id): Delete.
1119         (handle_output_debug_string): Replace main_thread_id by
1120         current_event.dwThreadId.
1121         (fake_create_process): Likewise.
1122         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1123         Do not set main_thread_id.
1124         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1125         current_event.dwThreadId.
1126         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1127
1128 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1129
1130         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1131         Use current_event.dwThreadId instead of main_thread_id.
1132
1133 2019-04-30  Tom Tromey  <tromey@adacore.com>
1134
1135         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1136         (create_excep_cond_exprs): Iterate over program spaces.
1137         (ada_exception_catchpoint_cond_string): Examine all minimal
1138         symbols for exception types.
1139
1140 2019-04-30  Tom Tromey  <tromey@adacore.com>
1141
1142         PR c++/24470:
1143         * dwarf2read.c (process_structure_scope): Handle case where type
1144         has template parameters but no symbol was created.
1145
1146 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1147             Chris January  <chris.january@arm.com>
1148
1149         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1150         qualifier.
1151         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1152
1153 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * f-typeprint.c (f_print_type): Update rules for printing
1156         whitespace.
1157         (f_type_print_varspec_suffix): Likewise.
1158
1159 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1160             Chris January  <chris.january@arm.com>
1161
1162         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1163         function arguments.
1164
1165 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1166
1167         * f-lang.c (build_fortran_types): Change name of void type to
1168         lower case.
1169         * f-typeprint.c (f_type_print_base): Print the name of the void
1170         type, rather than a fixed string.
1171         * f-valprint.c (f_decorations): Use lower case void string.
1172
1173 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1174             Chris January  <chris.january@arm.com>
1175
1176         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1177         types for Fortran.
1178
1179 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1180             Chris January  <chris.january@arm.com>
1181             David Lecomber  <david.lecomber@arm.com>
1182
1183         * f-exp.y (BINOP_INTRINSIC): New token.
1184         (exp): New parser rule handling BINOP_INTRINSIC.
1185         (f77_keywords): Add new builtin procedures.
1186         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1187         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1188         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1189         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1190         (print_unop_subexp_f): New function.
1191         (print_binop_subexp_f): New function.
1192         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1193         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1194         (dump_subexp_body_f): Likewise.
1195         (operator_check_f): Likewise.
1196         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1197         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1198
1199 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1200
1201         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1202         UNOP_KIND.
1203         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1204         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1205         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1206         (operator_length_f): New fuction.
1207         (print_subexp_f): New function.
1208         (op_name_f): New function.
1209         (dump_subexp_body_f): New function.
1210         (operator_check_f): New function.
1211         (exp_descriptor_f): Replace standard expression handling functions
1212         with new functions.
1213         * gdb/fortran-operator.def: New file.
1214         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1215         * gdb/std-operator.def: Remove UNOP_KIND.
1216
1217 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1218
1219         * std-operator.def: Remove unbalanced, stray double quote
1220         character.
1221
1222 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1223             Chris January  <chris.january@arm.com>
1224             Daniel Everett  <daniel.everett@arm.com>
1225             Nick Forrington  <nick.forrington@arm.com>
1226             Richard Bunt  <richard.bunt@arm.com>
1227
1228         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1229         of depth when printing anonymous structs or unions.
1230         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1231         Don't print either the top-level value, or the children if the
1232         max-depth is exceeded.
1233         (ppscm_print_children): When printing the key of a map, allow one
1234         extra level of depth.
1235         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1236         print either the top-level value, or the children if the max-depth
1237         is exceeded.
1238         (print_children): When printing the key of a map, allow one extra
1239         level of depth.
1240         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1241         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1242         (user_print_options): Initialise max_depth field.
1243         (val_print_scalar_or_string_type_p): New function.
1244         (val_print): Check to see if the max depth has been reached.
1245         (val_print_check_max_depth): Define new function.
1246         (show_print_max_depth): New function.
1247         (_initialize_valprint): Add 'print max-depth' option.
1248         * valprint.h (struct value_print_options) <max_depth>: New field.
1249         (val_print_check_max_depth): Declare new function.
1250         * NEWS: Document new feature.
1251
1252 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * ada-lang.c (ada_language_defn): Initialise new field.
1255         * c-lang.c (c_is_string_type_p): New function.
1256         (c_language_defn): Initialise new field.
1257         (cplus_language_defn): Initialise new field.
1258         (asm_language_defn): Initialise new field.
1259         (minimal_language_defn): Initialise new field.
1260         * c-lang.h (c_is_string_type_p): Declare new function.
1261         * d-lang.c (d_language_defn): Initialise new field.
1262         * f-lang.c (f_is_string_type_p): New function.
1263         (f_language_defn): Initialise new field.
1264         * go-lang.c (go_is_string_type_p): New function.
1265         (go_language_defn): Initialise new field.
1266         * language.c (default_is_string_type_p): New function.
1267         (unknown_language_defn): Initialise new field.
1268         (auto_language_defn): Initialise new field.
1269         * language.h (struct language_defn) <la_is_string_type_p>: New
1270         member variable.
1271         (default_is_string_type_p): Declare new function.
1272         * m2-lang.c (m2_language_defn): Initialise new field.
1273         * objc-lang.c (objc_language_defn): Initialise new field.
1274         * opencl-lang.c (opencl_language_defn): Initialise new field.
1275         * p-lang.c (pascal_is_string_type_p): New function.
1276         (pascal_language_defn): Initialise new field.
1277         * rust-lang.c (rust_is_string_type_p): New function.
1278         (rust_language_defn): Initialise new field.
1279
1280 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1281
1282         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1283         New field.
1284         * ada-lang.c (ada_language_defn): Initialise new field.
1285         * c-lang.c (c_language_defn): Likewise.
1286         (cplus_language_defn): Likewise.
1287         (asm_language_defn): Likewise.
1288         (minimal_language_defn): Likewise.
1289         * d-lang.c (d_language_defn): Likewise.
1290         * f-lang.c (f_language_defn): Likewise.
1291         * go-lang.c (go_language_defn): Likewise.
1292         * language.c (unknown_language_defn): Likewise.
1293         (auto_language_defn): Likewise.
1294         * m2-lang.c (m2_language_defn): Likewise.
1295         * objc-lang.c (objc_language_defn): Likewise.
1296         * opencl-lang.c (opencl_language_defn): Likewise.
1297         * p-lang.c (pascal_language_defn): Likewise.
1298         * rust-lang.c (rust_language_defn): Likewise.
1299
1300 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * ada-lang.c (ada_is_character_type): Change return type to bool.
1303         (ada_is_string_type): Likewise.
1304         * ada-lang.h (ada_is_character_type): Update declaration
1305         (ada_is_string_type): Likewise.
1306
1307 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1308
1309         Support style in 'frame|thread apply'
1310
1311         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1312         * record.c (record_start, record_stop): Update callers of
1313         execute_command_to_string with false.
1314         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1315         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1316         methods.
1317         (class string_file): New constructor with term_out parameter.
1318         Override methods term_out and can_emit_style_escape.  New member
1319         term_out.
1320         (class stdio_file): Override can_emit_style_escape.
1321         (class tee_file): Override term_out and can_emit_style_escape.
1322         * utils.h (can_emit_style_escape): Remove.
1323         * utils.c (can_emit_style_escape): Likewise.
1324         Update all callers of can_emit_style_escape (SOMESTREAM) to
1325         SOMESTREAM->can_emit_style_escape.
1326         * source-cache.c (source_cache::get_source_lines): Likewise.
1327         * stack.c (frame_apply_command_count): Call execute_command_to_string
1328         passing the term_out characteristic of the current gdb_stdout.
1329         * thread.c (thr_try_catch_cmd): Likewise.
1330         * top.c (execute_command_to_string): pass term_out parameter
1331         to construct the string_file for the command output.
1332         * ui-file.c (term_cli_styling): New function (most code moved
1333         from utils.c can_emit_style_escape).
1334         (string_file::string_file, string_file::can_emit_style_escape,
1335         stdio_file::can_emit_style_escape, tee_file::term_out,
1336         tee_file::can_emit_style_escape): New functions.
1337
1338 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1339
1340         * NEWS: Mention the new set|show may-call-functions.
1341         * infcall.c (may_call_functions_p): New variable.
1342         (show_may_call_functions_p): New function.
1343         (call_function_by_hand_dummy): Throws an error if not
1344         may-call-functions.
1345         (_initialize_infcall): Call add_setshow_boolean_cmd for
1346         may-call-functions.
1347
1348 2019-04-25  Keith Seitz  <keiths@redhat.com>
1349
1350         PR c++/24367
1351         * cp-support.c (inspect_type): Don't attempt substitutions
1352         of symbol with the same name.
1353
1354 2019-04-25  Tom Tromey  <tromey@adacore.com>
1355
1356         PR gdb/24475:
1357         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1358         static.
1359
1360 2019-04-25  Tom Tromey  <tromey@adacore.com>
1361
1362         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1363         rvalue reference.
1364         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1365         (gdb_xml_parser::parse): Use std::move.
1366         * python/python-internal.h (gdbpy_convert_exception): Take a const
1367         reference.
1368         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1369         std::move.
1370         * python/py-utils.c (gdbpy_convert_exception): Take a const
1371         reference.
1372         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1373         Use std::move.
1374         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1375         Use std::move.
1376         * mi/mi-main.c (mi_print_exception): Take a const reference.
1377         * main.c (handle_command_errors): Take a const reference.
1378         * linespec.c (parse_linespec): Use std::move.
1379         * infcall.c (run_inferior_call): Use std::move.
1380         (call_function_by_hand_dummy): Use std::move.
1381         * exec.c (try_open_exec_file): Use std::move.
1382         * exceptions.h (exception_print, exception_fprintf)
1383         (exception_print_same): Update.
1384         * exceptions.c (print_exception, exception_print)
1385         (exception_fprintf, exception_print_same): Change parameters to
1386         const reference.
1387         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1388         * common/new-op.c: Use std::move.
1389         * common/common-exceptions.h (struct gdb_exception): Add move
1390         constructor.
1391         (struct gdb_exception_error, struct gdb_exception_quit, struct
1392         gdb_quit_bad_alloc): Change constructor to move constructor.
1393         (throw_exception): Change parameter to rvalue reference.
1394         * common/common-exceptions.c (throw_exception): Take rvalue
1395         reference.
1396         * cli/cli-interp.c (safe_execute_command): Use std::move.
1397         * breakpoint.c (insert_bp_location, location_to_sals): Use
1398         std::move.
1399
1400 2019-04-25  Tom Tromey  <tromey@adacore.com>
1401
1402         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1403         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1404         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1405         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1406         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1407         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1408         guile/scm-value.c: Use unpack.
1409         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1410         gdbscm_gdb_exception.
1411         (gdbscm_throw_gdb_exception): Likewise.
1412         (struct gdbscm_gdb_exception): New.
1413         (unpack): New function.
1414         (gdbscm_wrap): Use unpack.
1415
1416 2019-04-25  Tom Tromey  <tromey@adacore.com>
1417
1418         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1419         (gdb_rl_callback_handler): Use std::move.
1420         * common/common-exceptions.h (struct gdb_exception): Add move
1421         assignment operator.
1422         (throw_exception_sjlj): Change "exception" to const reference.
1423         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1424         (throw_exception_sjlj): Change "exception" to const reference.
1425
1426 2019-04-25  Tom Tromey  <tromey@adacore.com>
1427
1428         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1429         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1430         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1431         Update.
1432         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1433         Update.
1434         * mi/mi-interp.c (mi_interp::exec): Update.
1435         * linespec.c (parse_linespec): Update.
1436         * infcall.c (run_inferior_call): Update.
1437         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1438         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1439         (gdbscm_lookup_global_symbol): Update.
1440         * guile/scm-param.c (gdbscm_parameter_value): Update.
1441         * guile/scm-frame.c (gdbscm_frame_read_register)
1442         (gdbscm_frame_read_var): Update.
1443         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1444         * exec.c (try_open_exec_file): Update.
1445         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1446         (gdb_rl_callback_handler): Update.
1447         * common/common-exceptions.h (exception_none): Don't declare.
1448         * common/common-exceptions.c (exception_none): Don't define.
1449         (struct catcher) <exception>: Update.
1450         * cli/cli-interp.c (safe_execute_command): Update.
1451         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1452
1453 2019-04-25  Ali Tamur  <tamur@google.com>
1454
1455         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1456         (read_attribute_value): Likewise.
1457         (dwarf2_read_addr_index): Update comment.
1458         (read_str_index): Add DW_FORM_strx.
1459         (dwarf2_string_attr): Likewise.
1460         (dwarf2_const_value_attr): Likewise.
1461         (dump_die_shallow): Likewise.
1462         (dwarf2_fetch_constant_bytes): Likewise.
1463         (skip_form_bytes): Likewise.
1464         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1465
1466 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1467
1468         PR corefiles/11608
1469         PR corefiles/18187
1470         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1471         OFFSET.  Verify if current mapping contains an ELF header.
1472         (linux_find_memory_regions_full): Adjust call to
1473         dump_mapping_p.
1474
1475 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1476             Kang Li <kanglictf@gmail.com>
1477
1478         PR gdb/21600
1479
1480         * dwarf2-frame.c (read_initial_length): Be consistent about using
1481         unsigned representation of length.
1482         (decode_frame_entry_1): Likewise.  Check for wraparound of
1483         end pointer as well as buffer overflow.
1484
1485 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1486
1487         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1488         "vq".
1489
1490 2019-04-24  Tom Tromey  <tromey@adacore.com>
1491
1492         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1493
1494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1495
1496         * s12z-tdep.c (s12z_unwind_pc): Delete.
1497         (s12z_unwind_sp): Delete.
1498         (s12z_gdbarch_init): Don't register deleted functions with
1499         gdbarch.
1500
1501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * rl78-tdep.c (rl78_unwind_sp): Delete.
1504         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1505
1506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1507
1508         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1509         (xstormy16_unwind_pc): Delete.
1510         (xstormy16_dummy_id): Delete.
1511         (xstormy16_gdbarch_init): Don't register deleted functions with
1512         gdbarch.
1513
1514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1515
1516         * vax-tdep.c (vax_unwind_pc): Delete.
1517         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1518
1519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1520
1521         * v850-tdep.c (v850_unwind_sp): Delete.
1522         (v850_unwind_pc): Delete.
1523         (v850_dummy_id): Delete.
1524         (v850_gdbarch_init): Don't register deleted functions with
1525         gdbarch.
1526
1527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1528
1529         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1530         (tilegx_unwind_pc): Delete.
1531         (tilegx_unwind_dummy_id): Delete.
1532         (tilegx_gdbarch_init): Don't register deleted functions with
1533         gdbarch.
1534
1535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1538         (tic6x_dummy_id): Delete.
1539         (tic6x_gdbarch_init): Don't register deleted functions with
1540         gdbarch.
1541
1542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * sparc-tdep.c (sparc_unwind_pc): Delete.
1545         (sparc32_gdbarch_init): Don't register deleted function with
1546         gdbarch.
1547
1548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1549
1550         * sh-tdep.c (sh_unwind_sp): Delete.
1551         (sh_unwind_pc): Delete.
1552         (sh_dummy_id): Delete.
1553         (sh_gdbarch_init): Don't register deleted functions with
1554         gdbarch.
1555
1556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * score-tdep.c (score_unwind_sp): Delete.
1559         (score_unwind_pc): Delete.
1560         (score_dummy_id): Delete.
1561         (score_gdbarch_init): Don't register deleted functions with
1562         gdbarch.
1563
1564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1565
1566         * rx-tdep.c (rx_unwind_pc): Delete.
1567         (rx_unwind_sp): Delete.
1568         (rx_dummy_id): Delete.
1569         (rx_gdbarch_init): Don't register deleted functions with
1570         gdbarch.  Update comment.
1571
1572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1575         (rs6000_dummy_id): Delete.
1576         (rs6000_gdbarch_init): Don't register deleted functions with
1577         gdbarch.
1578
1579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1580
1581         * or1k-tdep.c (or1k_dummy_id): Delete.
1582         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1583
1584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1585
1586         * nios2-tdep.c (nios2_dummy_id): Delete.
1587         (nios2_unwind_sp): Delete.
1588         (nios2_gdbarch_init): Don't register deleted functions with
1589         gdbarch.
1590
1591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1592
1593         * nds32-tdep.c (nds32_dummy_id): Delete.
1594         (nds32_unwind_pc): Delete.
1595         (nds32_unwind_sp): Delete.
1596         (nds32_gdbarch_init): Don't register deleted functions with
1597         gdbarch.
1598
1599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1600
1601         * msp430-tdep.c (msp430_unwind_pc): Delete.
1602         (msp430_unwind_sp): Delete.
1603         (msp430_dummy_id): Delete.
1604         (msp430_gdbarch_init): Don't register deleted functions with
1605         gdbarch.
1606
1607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * moxie-tdep.c (moxie_unwind_sp): Delete.
1610         (moxie_unwind_pc): Delete.
1611         (moxie_dummy_id): Delete.
1612         (moxie_gdbarch_init): Don't register deleted functions with
1613         gdbarch.
1614
1615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1618         (mn10300_unwind_pc): Delete.
1619         (mn10300_unwind_sp): Delete.
1620         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1621         mn10300_unwind_sp.
1622         (mn10300_frame_unwind_init): Don't register deleted functions with
1623         gdbarch.
1624
1625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1626
1627         * mep-tdep.c (mep_unwind_pc): Delete.
1628         (mep_unwind_sp): Delete.
1629         (mep_dummy_id): Delete.
1630         (mep_gdbarch_init): Don't register deleted functions with
1631         gdbarch.
1632
1633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1634
1635         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1636         (m68hc11_unwind_sp): Delete.
1637         (m68hc11_gdbarch_init): Don't register deleted functions with
1638         gdbarch.
1639
1640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1641
1642         * m32r-tdep.c (m32r_unwind_sp): Delete.
1643         (m32r_unwind_pc): Delete.
1644         (m32r_dummy_id): Delete.
1645         (m32r_gdbarch_init): Don't register deleted functions with
1646         gdbarch.
1647
1648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1649
1650         * m32c-tdep.c (m32c_unwind_pc): Delete.
1651         (m32c_unwind_sp): Delete.
1652         (m32c_dummy_id): Delete.
1653         (m32c_gdbarch_init): Don't register deleted functions with
1654         gdbarch.
1655
1656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1657
1658         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1659         (lm32_unwind_pc): Delete.
1660         (lm32_dummy_id): Delete.
1661         (lm32_gdbarch_init): Don't register deleted functions with
1662         gdbarch.
1663
1664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1665
1666         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1667         (iq2000_unwind_pc): Delete.
1668         (iq2000_dummy_id): Delete.
1669         (iq2000_gdbarch_init): Don't register deleted functions with
1670         gdbarch.
1671
1672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1673
1674         * nds32-tdep.c (nds32_type_align): Delete.
1675         (nds32_push_dummy_call): Use type_align instead.
1676
1677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1678
1679         * arm-tdep.c (arm_type_align): Only handle vector override case.
1680         (arm_push_dummy_call): Use type_align.
1681         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1682
1683 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1684
1685         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1686         case.
1687         (pass_on_stack): Use type_align.
1688         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1689         function.
1690
1691 2019-04-23  Tom Tromey  <tromey@adacore.com>
1692
1693         * dwarf2read.c (line_header::file_name_at): Remove unused
1694         overload.
1695
1696 2019-04-23  Tom de Vries  <tdevries@suse.de>
1697
1698         PR gdb/24438
1699         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1700         invocation.
1701
1702
1703 2019-03-27  Ali Tamur  <tamur@google.com>
1704
1705         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1706         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1707         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1708         (dwarf_expr_context::get_addr_index): Likewise
1709         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1710         (symbol_needs_eval_context::get_addr_index): Likewise
1711         (disassemble_dwarf_expression): Add DW_OP_addrx
1712         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1713         (read_cutu_die_from_dwo): Update comment
1714         (skip_one_die): Add DW_FORM_addrx
1715         (read_attribute_value): Likewise
1716         (var_decode_location): Add DW_OP_addrx
1717         (dwarf2_const_value_attr): Add DW_FORM_addrx
1718         (dump_die_shallow): Likewise
1719         (dwarf2_fetch_constant_bytes): Likewise
1720         (decode_locdesc): Add DW_OP_addrx
1721         (skip_form_bytes): Add DW_FORM_addrx
1722
1723 2019-04-22  Ali Tamur  <tamur@google.com>
1724
1725         * MAINTAINERS (Write After Approval): Add self.
1726
1727 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1728
1729         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1730         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1731         (open_symbol_file_object): Likewise.
1732         (svr4_default_sos): Add info parameter.
1733         (svr4_read_so_list): Likewise.
1734         (svr4_current_sos_direct): Adjust functions calls to pass down
1735         info.
1736         (svr4_current_sos_1): Add info parameter.
1737         (svr4_current_sos): Call get_svr4_info, pass info down to
1738         svr4_current_sos_1.
1739         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1740         get_svr4_info.
1741         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1742         get_svr4_info.
1743         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1744         to get_svr4_info.
1745         (probes_table_remove_objfile_probes): Likewise.
1746         (register_solib_event_probe): Add info parameter.
1747         (solist_update_incremental): Pass info parameter down to
1748         svr4_read_so_list.
1749         (disable_probes_interface): Add info parameter.
1750         (svr4_handle_solib_event): Pass current_program_space to
1751         get_svr4_info.  Adjust disable_probes_interface cleanup.
1752         (svr4_create_probe_breakpoints): Add info parameter, pass it
1753         down to register_solib_event_probe.
1754         (svr4_create_solib_event_breakpoints): Add info parameter,
1755         pass it down to svr4_create_probe_breakpoints.
1756         (enable_break): Pass info down to
1757         svr4_create_solib_event_breakpoints.
1758         (svr4_solib_create_inferior_hook): Pass current_program_space to
1759         get_svr4_info.
1760         (svr4_clear_solib): Likewise.
1761
1762 2019-04-22  Pedro Alves  <palves@redhat.com>
1763
1764         * solib-svr4.c (svr4_free_objfile_observer): New.
1765         (probe_and_action::objfile): New field.
1766         (probes_table_htab_remove_objfile_probes)
1767         (probes_table_remove_objfile_probes): New functions.
1768         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1769         in the new probe_and_action.  Don't store the probe in 'lookup'.
1770         (svr4_create_probe_breakpoints): Pass objfile to
1771         register_solib_event_probe.
1772         (_initialize_svr4_solib): Register a free_objfile observer.
1773
1774 2019-04-19  Tom Tromey  <tom@tromey.com>
1775
1776         * common/queue.h: Remove.
1777
1778 2019-04-19  Tom Tromey  <tom@tromey.com>
1779
1780         * event-loop.c: Don't include "common/queue.h".
1781
1782 2019-04-19  Tom Tromey  <tom@tromey.com>
1783
1784         * remote.c (remote_target): Use delete.
1785         * remote-notif.h: Include <list>, not "common/queue.h".
1786         (notif_client_p): Remove typedef.
1787         (remote_notif_state): Add constructor, destructor, initializer.
1788         <notif_queue>: Now a std::list.
1789         (remote_notif_state_xfree): Don't declare.
1790         * remote-notif.c (remote_notif_process, handle_notification)
1791         (remote_notif_state_allocate): Update.
1792         (~remote_notif_state): Rename from remote_notif_state_xfree.
1793
1794 2019-04-19  Tom Tromey  <tom@tromey.com>
1795
1796         * symfile.c (reread_symbols): Update.
1797         * objfiles.c (objfile_register_static_link)
1798         (objfile_lookup_static_link): Update
1799         (~objfile) Don't delete static_links.
1800         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1801
1802 2019-04-19  Tom Tromey  <tom@tromey.com>
1803
1804         * type-stack.h (struct type_stack) <insert>: Constify string.
1805         * type-stack.c (type_stack::insert): Constify string.
1806         * gdbtypes.h (lookup_template_type): Update.
1807         (address_space_name_to_int): Update.
1808         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1809         const.
1810         (lookup_template_type): Make name const.
1811         * c-exp.y: Update rules.
1812         (lex_one_token, classify_name, classify_inner_name)
1813         (c_print_token): Update.
1814         * p-exp.y: Update rules.
1815         (yylex): Update.
1816         * f-exp.y: Update rules.
1817         (yylex): Update.
1818         * d-exp.y: Update rules.
1819         (lex_one_token, classify_name, classify_inner_name): Update.
1820         * parse.c (write_dollar_variable, copy_name): Return std::string.
1821         * parser-defs.h (copy_name): Change return type.
1822         * m2-exp.y: Update rules.
1823         (yylex): Update.
1824         * go-exp.y (lex_one_token): Update.
1825         Update rules.
1826         (classify_unsafe_function, classify_packaged_name)
1827         (classify_name, yylex): Update.
1828
1829 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1830
1831         * configure.ac: add --enable-source-highlight switch.
1832         * configure: Regenerate.
1833         * top.c (print_gdb_version): plumb --enable-source-highlight
1834         status to "show configuration".
1835
1836 2019-04-19  Tom Tromey  <tromey@adacore.com>
1837
1838         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1839         Check ADA_TYPE_P.
1840         (empty_record, ada_template_to_fixed_record_type_1)
1841         (template_to_static_fixed_type)
1842         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1843         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1844         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1845         macros.
1846
1847 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1848
1849         PR symtab/24423:
1850         * source.c (print_source_lines_base): Advance "iter" when a
1851         control character is seen.
1852
1853 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1854
1855         * inferior.h (struct infcall_suspend_state_deleter):
1856         Catch exception in destructor to avoid crash.
1857
1858 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1859
1860         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1861         close to the add_com "shell".
1862
1863 2019-04-18  Tom Tromey  <tromey@adacore.com>
1864
1865         * process-stratum-target.h (class process_stratum_target)
1866         <stratum>: Add "final".
1867
1868 2019-04-17  Tom Tromey  <tromey@adacore.com>
1869
1870         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1871         against nullptr before use.
1872
1873 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1874
1875         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1876
1877 2019-04-17  Jim Wilson  <jimw@sifive.com>
1878             Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1881         code read might fail, assume 4-byte breakpoint in that case.
1882
1883 2019-04-15  Leszek Swirski  <leszeks@google.com>
1884
1885         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1886         rather than a hand-rolled POD check when checking for forced MEMORY
1887         classification.
1888
1889 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1890
1891         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1892         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1893         function.
1894         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1895         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1896         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1897         declaration.
1898
1899 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1900
1901         * aarch64-linux-nat.c
1902         (aarch64_linux_nat_target::thread_architecture): Add override.
1903         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1904         each VQ.
1905
1906 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1907
1908         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1909
1910 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1913         target types of size 96-bits, add some additional comments, and
1914         check that the builtin type we found was the correct size.
1915
1916 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1917
1918         * utils.c (prompt_for_continue): Don't restore the styling at the
1919         end, as applied_style has the wrong value.  This fixes styling in
1920         long lists of file names that are interrupted by the "Continue?"
1921         prompt.
1922
1923 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1926         * c-lang.c (c_language_defn): Likewise.
1927         (cplus_language_defn): Likewise.
1928         (asm_language_defn): Likewise.
1929         (minimal_language_defn): Likewise.
1930         * d-lang.c (d_language_defn): Likewise.
1931         * f-lang.c (f_language_defn): Likewise.
1932         * go-lang.c (go_language_defn): Likewise.
1933         * language.c (unknown_language_defn): Likewise.
1934         (auto_language_defn): Likewise.
1935         * language.h (struct language_defn): Remove la_magic field.
1936         (LANG_MAGIC): Delete.
1937         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1938         * objc-lang.c (objc_language_defn): Likewise.
1939         * opencl-lang.c (opencl_language_defn): Likewise.
1940         * p-lang.c (pascal_language_defn): Likewise.
1941         * rust-lang.c (rust_language_defn): Likewise.
1942
1943 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1944
1945         * riscv-tdep.c (riscv_type_align): New function.
1946         (riscv_type_alignment): Delete.
1947         (riscv_arg_location): Use 'type_align'.
1948         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1949
1950 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * gdbtypes.c (type_align): A struct with no non-static fields also
1953         has alignment of 1.
1954
1955 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1956
1957         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1958         component to 0.
1959         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1960         member.
1961         (riscv_struct_info::analyse): New implementation using new
1962         analyse_inner member function.
1963         (riscv_struct_info::field_offset): New member function.
1964         (riscv_struct_info::m_offsets): New member variable.
1965         (riscv_struct_info::analyse_inner): New private member function,
1966         takes the old implementation of riscv_struct_info::analyse but
1967         extended to track field offsets.
1968         (riscv_call_arg_struct): Update the struct folding special cases
1969         to handle cases where empty C++ structs, which are non-zero
1970         length, are found.
1971         (riscv_arg_location): Initialise the length of each location, a
1972         non-zero length now indicates the location is in use.
1973         (riscv_push_dummy_call): Allow for the first location having a
1974         non-zero offset when setting up arguments.
1975         (riscv_return_value): Likewise, but for return values.
1976
1977 2019-04-11  Tom Tromey  <tromey@adacore.com>
1978
1979         * utils.c (internal_vproblem): Make "msg" const.
1980
1981 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1982
1983         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1984         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1985         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1986         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1987
1988 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1989
1990         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1991         function.
1992         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1993         of amd64_collect_native_gregset.
1994         (amd64_linux_nat_target::store_registers): Likewise.
1995
1996 2019-04-10  Tom Tromey  <tom@tromey.com>
1997
1998         * symtab.c (lookup_global_symbol_from_objfile)
1999         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2000         * objfiles.h (class separate_debug_iterator): New.
2001         (class separate_debug_range): New.
2002         (struct objfile) <separate_debug_objfiles>: New method.
2003         (objfile_separate_debug_iterate): Don't declare.
2004         * objfiles.c (separate_debug_iterator::operator++): Rename from
2005         objfile_separate_debug_iterate.
2006         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2007         iterator.
2008         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2009         iterator.
2010
2011 2019-04-10  Tom Tromey  <tom@tromey.com>
2012
2013         * symfile.c (reread_symbols): Remove old comment.
2014         * objfiles.c (free_all_objfiles): Fix a typo.
2015
2016 2019-04-10  Tom Tromey  <tom@tromey.com>
2017
2018         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2019         * minsyms.c (lookup_minimal_symbol): Use foreach.
2020         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2021         (lookup_minimal_symbol_solib_trampoline): Likewise.
2022         * symfile.c (reread_symbols): Use foreach.
2023
2024 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2025             Tom Tromey  <tromey@adacore.com>
2026
2027         PR rust/24414:
2028         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2029         (rust_lex_int_test): Change "value" to be LONGEST.
2030         (rust_lex_tests): Add test for long integer literal.
2031
2032 2019-04-09  Tom Tromey  <tromey@adacore.com>
2033
2034         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2035         to bool.
2036         (extended_remote_target::attach): Update.
2037         (remote_target::remote_notice_new_inferior): Update.
2038         (remote_target::add_current_inferior_and_thread): Update.
2039         * inferior.c (exit_inferior_1): Use "false".
2040         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2041
2042 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2043
2044         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2045         the "start" command.
2046
2047 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2048
2049         * python/py-inferior.c (infpy_thread_from_thread_handle):
2050         Adjust comments to reflect renaming of thread_from_thread_handle
2051         to thread_from_handle.  Adjust keywords.  Fix type error message.
2052         (inferior_object_methods): Add thread_from_handle.  Retain
2053         thread_from_thread_handle, but mark it as deprecated.
2054
2055 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2056
2057         * gdbthread.h (find_thread_by_handle): Revise declaration.
2058         * thread.c (find_thread_by_handle): Likewise.  Adjust
2059         implementation too.
2060         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2061         support for buffer objects as handles.
2062
2063 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2064
2065         * python/py-infthread.c (thpy_thread_handle): New function.
2066         (thread_object_methods): Register thpy_thread_handle.
2067
2068 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2069
2070         * gdbthread.h (thread_to_thread_handle): Declare.
2071         * thread.c (gdbtypes.h): Include.
2072         (thread_to_thread_handle): New function.
2073
2074         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2075         (target_thread_info_to_thread_handle): Declare.
2076         * target.c (target_thread_info_to_thread_handle): New function.
2077         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2078         * target-delegates.c: Regenerate.
2079
2080         * linux-thread-db.c (class thread_db_target): Add method
2081         thread_info_to_thread_handle.
2082         (thread_db_target::thread_info_to_thread_handle): Define.
2083         * remote.c (class remote_target): Add new method
2084         thread_info_to_thread_handle.
2085         (remote_target::thread_info_to_thread_handle): Define.
2086
2087 2019-04-08  Pedro Alves  <palves@redhat.com>
2088
2089         * common/common-exceptions.c (throw_exception): Don't create
2090         named object to throw; throw directly.
2091         (throw_it): Likewise.  Don't initialize gdb_exception::message
2092         here, with new; pass FMT and AP to the ctor instead.
2093         * common/common-exceptions.h: Include <string>.
2094         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2095         const char *, va_list)): New ctor.  Use std::make_shared.
2096         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2097         errors)): Delete.
2098         (gdb_exception_error::gdb_exception_error(enum errors, const char
2099         *, va_list)): New.
2100         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2101         Add assertion.
2102         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2103         errors)): Delete.
2104         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2105         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2106         Add assertion.
2107
2108 2019-04-08  Tom Tromey  <tom@tromey.com>
2109
2110         * valops.c (value_rtti_indirect_type): Replace throw_exception
2111         with throw.
2112         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2113         with throw.
2114         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2115         throw.
2116         * target.c (target_translate_tls_address): Replace throw_exception
2117         with throw.
2118         * stack.c (frame_apply_command_count): Replace throw_exception
2119         with throw.
2120         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2121         throw.
2122         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2123         with throw.
2124         * rs6000-tdep.c (rs6000_frame_cache)
2125         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2126         * remote.c: Replace throw_exception with throw.
2127         * record-full.c (record_full_message, record_full_wait_1)
2128         (record_full_restore): Replace throw_exception with throw.
2129         * record-btrace.c:
2130         (get_thread_current_frame_id, record_btrace_start_replaying)
2131         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2132         (cmd_record_btrace_start): Replace throw_exception with throw.
2133         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2134         throw.
2135         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2136         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2137         * linespec.c:
2138         (find_linespec_symbols): Replace throw_exception with throw.
2139         * infrun.c (displaced_step_prepare, resume): Replace
2140         throw_exception with throw.
2141         * infcmd.c (post_create_inferior): Replace throw_exception with
2142         throw.
2143         * inf-loop.c (inferior_event_handler): Replace throw_exception
2144         with throw.
2145         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2146         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2147         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2148         (get_prev_frame_always, get_frame_pc_if_available)
2149         (get_frame_address_in_block_if_available, get_frame_language):
2150         Replace throw_exception with throw.
2151         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2152         throw_exception with throw.
2153         * eval.c (fetch_subexp_value, evaluate_var_value)
2154         (evaluate_funcall, evaluate_subexp_standard): Replace
2155         throw_exception with throw.
2156         * dwarf2loc.c (call_site_find_chain)
2157         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2158         Replace throw_exception with throw.
2159         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2160         with throw.
2161         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2162         throw.
2163         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2164         * completer.c (complete_line_internal): Replace throw_exception
2165         with throw.
2166         * compile/compile-object-run.c (compile_object_run): Replace
2167         throw_exception with throw.
2168         * cli/cli-script.c (process_next_line): Replace throw_exception
2169         with throw.
2170         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2171         (btrace_enable, btrace_maint_update_pt_packets): Replace
2172         throw_exception with throw.
2173         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2174         throw_exception with throw.
2175         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2176         throw_exception with throw.
2177         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2178         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2179         * aarch64-tdep.c (aarch64_make_prologue_cache)
2180         (aarch64_make_stub_cache): Replace throw_exception with throw.
2181
2182 2019-04-08  Tom Tromey  <tom@tromey.com>
2183
2184         * common/common-exceptions.c (throw_exception): Rename from
2185         throw_exception_cxx.  Remove old copy.  Make argument const.
2186         (throw_it): Create and throw exception objects directly.
2187         * common/common-exceptions.h (throw_exception): Make argument
2188         const.
2189         (struct gdb_exception_error): Add constructor.
2190         (struct gdb_exception_quit): Add constructor.
2191
2192 2019-04-08  Tom Tromey  <tom@tromey.com>
2193
2194         * common/common-exceptions.h (exception_rethrow): Don't declare.
2195         (TRY_SJLJ): Update comment.
2196         (TRY, CATCH, END_CATCH): Remove.
2197         * common/common-exceptions.c (exception_rethrow): Remove.
2198
2199 2019-04-08  Tom Tromey  <tom@tromey.com>
2200
2201         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2202         Remove.
2203         (gdb_exception_error): Rename from
2204         gdb_exception_RETURN_MASK_ERROR.
2205         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2206         (gdb_quit_bad_alloc): Update.
2207         * aarch64-tdep.c: Update.
2208         * ada-lang.c: Update.
2209         * ada-typeprint.c: Update.
2210         * ada-valprint.c: Update.
2211         * amd64-tdep.c: Update.
2212         * arch-utils.c: Update.
2213         * break-catch-throw.c: Update.
2214         * breakpoint.c: Update.
2215         * btrace.c: Update.
2216         * c-varobj.c: Update.
2217         * cli/cli-cmds.c: Update.
2218         * cli/cli-interp.c: Update.
2219         * cli/cli-script.c: Update.
2220         * common/common-exceptions.c: Update.
2221         * common/new-op.c: Update.
2222         * common/selftest.c: Update.
2223         * compile/compile-c-symbols.c: Update.
2224         * compile/compile-cplus-symbols.c: Update.
2225         * compile/compile-object-load.c: Update.
2226         * compile/compile-object-run.c: Update.
2227         * completer.c: Update.
2228         * corelow.c: Update.
2229         * cp-abi.c: Update.
2230         * cp-support.c: Update.
2231         * cp-valprint.c: Update.
2232         * darwin-nat.c: Update.
2233         * disasm-selftests.c: Update.
2234         * dtrace-probe.c: Update.
2235         * dwarf-index-cache.c: Update.
2236         * dwarf-index-write.c: Update.
2237         * dwarf2-frame-tailcall.c: Update.
2238         * dwarf2-frame.c: Update.
2239         * dwarf2loc.c: Update.
2240         * dwarf2read.c: Update.
2241         * eval.c: Update.
2242         * event-loop.c: Update.
2243         * event-top.c: Update.
2244         * exec.c: Update.
2245         * f-valprint.c: Update.
2246         * fbsd-tdep.c: Update.
2247         * frame-unwind.c: Update.
2248         * frame.c: Update.
2249         * gdbtypes.c: Update.
2250         * gnu-v3-abi.c: Update.
2251         * guile/guile-internal.h: Update.
2252         * guile/scm-block.c: Update.
2253         * guile/scm-breakpoint.c: Update.
2254         * guile/scm-cmd.c: Update.
2255         * guile/scm-disasm.c: Update.
2256         * guile/scm-frame.c: Update.
2257         * guile/scm-lazy-string.c: Update.
2258         * guile/scm-math.c: Update.
2259         * guile/scm-param.c: Update.
2260         * guile/scm-ports.c: Update.
2261         * guile/scm-pretty-print.c: Update.
2262         * guile/scm-symbol.c: Update.
2263         * guile/scm-symtab.c: Update.
2264         * guile/scm-type.c: Update.
2265         * guile/scm-value.c: Update.
2266         * i386-linux-tdep.c: Update.
2267         * i386-tdep.c: Update.
2268         * inf-loop.c: Update.
2269         * infcall.c: Update.
2270         * infcmd.c: Update.
2271         * infrun.c: Update.
2272         * jit.c: Update.
2273         * language.c: Update.
2274         * linespec.c: Update.
2275         * linux-fork.c: Update.
2276         * linux-nat.c: Update.
2277         * linux-tdep.c: Update.
2278         * linux-thread-db.c: Update.
2279         * main.c: Update.
2280         * mi/mi-cmd-break.c: Update.
2281         * mi/mi-cmd-stack.c: Update.
2282         * mi/mi-interp.c: Update.
2283         * mi/mi-main.c: Update.
2284         * objc-lang.c: Update.
2285         * p-valprint.c: Update.
2286         * parse.c: Update.
2287         * ppc-linux-tdep.c: Update.
2288         * printcmd.c: Update.
2289         * python/py-arch.c: Update.
2290         * python/py-breakpoint.c: Update.
2291         * python/py-cmd.c: Update.
2292         * python/py-finishbreakpoint.c: Update.
2293         * python/py-frame.c: Update.
2294         * python/py-framefilter.c: Update.
2295         * python/py-gdb-readline.c: Update.
2296         * python/py-inferior.c: Update.
2297         * python/py-infthread.c: Update.
2298         * python/py-lazy-string.c: Update.
2299         * python/py-linetable.c: Update.
2300         * python/py-objfile.c: Update.
2301         * python/py-param.c: Update.
2302         * python/py-prettyprint.c: Update.
2303         * python/py-progspace.c: Update.
2304         * python/py-record-btrace.c: Update.
2305         * python/py-record.c: Update.
2306         * python/py-symbol.c: Update.
2307         * python/py-type.c: Update.
2308         * python/py-unwind.c: Update.
2309         * python/py-utils.c: Update.
2310         * python/py-value.c: Update.
2311         * python/python.c: Update.
2312         * record-btrace.c: Update.
2313         * record-full.c: Update.
2314         * remote-fileio.c: Update.
2315         * remote.c: Update.
2316         * riscv-tdep.c: Update.
2317         * rs6000-aix-tdep.c: Update.
2318         * rs6000-tdep.c: Update.
2319         * rust-exp.y: Update.
2320         * rust-lang.c: Update.
2321         * s390-tdep.c: Update.
2322         * selftest-arch.c: Update.
2323         * solib-dsbt.c: Update.
2324         * solib-frv.c: Update.
2325         * solib-spu.c: Update.
2326         * solib-svr4.c: Update.
2327         * solib.c: Update.
2328         * sparc64-linux-tdep.c: Update.
2329         * stack.c: Update.
2330         * symfile-mem.c: Update.
2331         * symmisc.c: Update.
2332         * target.c: Update.
2333         * thread.c: Update.
2334         * top.c: Update.
2335         * tracefile-tfile.c: Update.
2336         * tui/tui.c: Update.
2337         * typeprint.c: Update.
2338         * unittests/cli-utils-selftests.c: Update.
2339         * unittests/parse-connection-spec-selftests.c: Update.
2340         * valops.c: Update.
2341         * valprint.c: Update.
2342         * value.c: Update.
2343         * varobj.c: Update.
2344         * windows-nat.c: Update.
2345         * x86-linux-nat.c: Update.
2346         * xml-support.c: Update.
2347
2348 2019-04-08  Tom Tromey  <tom@tromey.com>
2349
2350         * xml-support.c: Use C++ exception handling.
2351         * x86-linux-nat.c: Use C++ exception handling.
2352         * windows-nat.c: Use C++ exception handling.
2353         * varobj.c: Use C++ exception handling.
2354         * value.c: Use C++ exception handling.
2355         * valprint.c: Use C++ exception handling.
2356         * valops.c: Use C++ exception handling.
2357         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2358         handling.
2359         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2360         * typeprint.c: Use C++ exception handling.
2361         * tui/tui.c: Use C++ exception handling.
2362         * tracefile-tfile.c: Use C++ exception handling.
2363         * top.c: Use C++ exception handling.
2364         * thread.c: Use C++ exception handling.
2365         * target.c: Use C++ exception handling.
2366         * symmisc.c: Use C++ exception handling.
2367         * symfile-mem.c: Use C++ exception handling.
2368         * stack.c: Use C++ exception handling.
2369         * sparc64-linux-tdep.c: Use C++ exception handling.
2370         * solib.c: Use C++ exception handling.
2371         * solib-svr4.c: Use C++ exception handling.
2372         * solib-spu.c: Use C++ exception handling.
2373         * solib-frv.c: Use C++ exception handling.
2374         * solib-dsbt.c: Use C++ exception handling.
2375         * selftest-arch.c: Use C++ exception handling.
2376         * s390-tdep.c: Use C++ exception handling.
2377         * rust-lang.c: Use C++ exception handling.
2378         * rust-exp.y: Use C++ exception handling.
2379         * rs6000-tdep.c: Use C++ exception handling.
2380         * rs6000-aix-tdep.c: Use C++ exception handling.
2381         * riscv-tdep.c: Use C++ exception handling.
2382         * remote.c: Use C++ exception handling.
2383         * remote-fileio.c: Use C++ exception handling.
2384         * record-full.c: Use C++ exception handling.
2385         * record-btrace.c: Use C++ exception handling.
2386         * python/python.c: Use C++ exception handling.
2387         * python/py-value.c: Use C++ exception handling.
2388         * python/py-utils.c: Use C++ exception handling.
2389         * python/py-unwind.c: Use C++ exception handling.
2390         * python/py-type.c: Use C++ exception handling.
2391         * python/py-symbol.c: Use C++ exception handling.
2392         * python/py-record.c: Use C++ exception handling.
2393         * python/py-record-btrace.c: Use C++ exception handling.
2394         * python/py-progspace.c: Use C++ exception handling.
2395         * python/py-prettyprint.c: Use C++ exception handling.
2396         * python/py-param.c: Use C++ exception handling.
2397         * python/py-objfile.c: Use C++ exception handling.
2398         * python/py-linetable.c: Use C++ exception handling.
2399         * python/py-lazy-string.c: Use C++ exception handling.
2400         * python/py-infthread.c: Use C++ exception handling.
2401         * python/py-inferior.c: Use C++ exception handling.
2402         * python/py-gdb-readline.c: Use C++ exception handling.
2403         * python/py-framefilter.c: Use C++ exception handling.
2404         * python/py-frame.c: Use C++ exception handling.
2405         * python/py-finishbreakpoint.c: Use C++ exception handling.
2406         * python/py-cmd.c: Use C++ exception handling.
2407         * python/py-breakpoint.c: Use C++ exception handling.
2408         * python/py-arch.c: Use C++ exception handling.
2409         * printcmd.c: Use C++ exception handling.
2410         * ppc-linux-tdep.c: Use C++ exception handling.
2411         * parse.c: Use C++ exception handling.
2412         * p-valprint.c: Use C++ exception handling.
2413         * objc-lang.c: Use C++ exception handling.
2414         * mi/mi-main.c: Use C++ exception handling.
2415         * mi/mi-interp.c: Use C++ exception handling.
2416         * mi/mi-cmd-stack.c: Use C++ exception handling.
2417         * mi/mi-cmd-break.c: Use C++ exception handling.
2418         * main.c: Use C++ exception handling.
2419         * linux-thread-db.c: Use C++ exception handling.
2420         * linux-tdep.c: Use C++ exception handling.
2421         * linux-nat.c: Use C++ exception handling.
2422         * linux-fork.c: Use C++ exception handling.
2423         * linespec.c: Use C++ exception handling.
2424         * language.c: Use C++ exception handling.
2425         * jit.c: Use C++ exception handling.
2426         * infrun.c: Use C++ exception handling.
2427         * infcmd.c: Use C++ exception handling.
2428         * infcall.c: Use C++ exception handling.
2429         * inf-loop.c: Use C++ exception handling.
2430         * i386-tdep.c: Use C++ exception handling.
2431         * i386-linux-tdep.c: Use C++ exception handling.
2432         * guile/scm-value.c: Use C++ exception handling.
2433         * guile/scm-type.c: Use C++ exception handling.
2434         * guile/scm-symtab.c: Use C++ exception handling.
2435         * guile/scm-symbol.c: Use C++ exception handling.
2436         * guile/scm-pretty-print.c: Use C++ exception handling.
2437         * guile/scm-ports.c: Use C++ exception handling.
2438         * guile/scm-param.c: Use C++ exception handling.
2439         * guile/scm-math.c: Use C++ exception handling.
2440         * guile/scm-lazy-string.c: Use C++ exception handling.
2441         * guile/scm-frame.c: Use C++ exception handling.
2442         * guile/scm-disasm.c: Use C++ exception handling.
2443         * guile/scm-cmd.c: Use C++ exception handling.
2444         * guile/scm-breakpoint.c: Use C++ exception handling.
2445         * guile/scm-block.c: Use C++ exception handling.
2446         * guile/guile-internal.h: Use C++ exception handling.
2447         * gnu-v3-abi.c: Use C++ exception handling.
2448         * gdbtypes.c: Use C++ exception handling.
2449         * frame.c: Use C++ exception handling.
2450         * frame-unwind.c: Use C++ exception handling.
2451         * fbsd-tdep.c: Use C++ exception handling.
2452         * f-valprint.c: Use C++ exception handling.
2453         * exec.c: Use C++ exception handling.
2454         * event-top.c: Use C++ exception handling.
2455         * event-loop.c: Use C++ exception handling.
2456         * eval.c: Use C++ exception handling.
2457         * dwarf2read.c: Use C++ exception handling.
2458         * dwarf2loc.c: Use C++ exception handling.
2459         * dwarf2-frame.c: Use C++ exception handling.
2460         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2461         * dwarf-index-write.c: Use C++ exception handling.
2462         * dwarf-index-cache.c: Use C++ exception handling.
2463         * dtrace-probe.c: Use C++ exception handling.
2464         * disasm-selftests.c: Use C++ exception handling.
2465         * darwin-nat.c: Use C++ exception handling.
2466         * cp-valprint.c: Use C++ exception handling.
2467         * cp-support.c: Use C++ exception handling.
2468         * cp-abi.c: Use C++ exception handling.
2469         * corelow.c: Use C++ exception handling.
2470         * completer.c: Use C++ exception handling.
2471         * compile/compile-object-run.c: Use C++ exception handling.
2472         * compile/compile-object-load.c: Use C++ exception handling.
2473         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2474         * compile/compile-c-symbols.c: Use C++ exception handling.
2475         * common/selftest.c: Use C++ exception handling.
2476         * common/new-op.c: Use C++ exception handling.
2477         * cli/cli-script.c: Use C++ exception handling.
2478         * cli/cli-interp.c: Use C++ exception handling.
2479         * cli/cli-cmds.c: Use C++ exception handling.
2480         * c-varobj.c: Use C++ exception handling.
2481         * btrace.c: Use C++ exception handling.
2482         * breakpoint.c: Use C++ exception handling.
2483         * break-catch-throw.c: Use C++ exception handling.
2484         * arch-utils.c: Use C++ exception handling.
2485         * amd64-tdep.c: Use C++ exception handling.
2486         * ada-valprint.c: Use C++ exception handling.
2487         * ada-typeprint.c: Use C++ exception handling.
2488         * ada-lang.c: Use C++ exception handling.
2489         * aarch64-tdep.c: Use C++ exception handling.
2490
2491 2019-04-08  Tom Tromey  <tom@tromey.com>
2492
2493         * xml-support.c (gdb_xml_parser::parse): Update.
2494         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2495         * value.c (show_convenience): Update.
2496         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2497         (test_parse_flags_qcs): Update.
2498         * thread.c (thr_try_catch_cmd): Update.
2499         * target.c (target_translate_tls_address): Update.
2500         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2501         (info_frame_command_core, frame_apply_command_count): Update.
2502         * rust-exp.y (rust_lex_exception_test): Update.
2503         * riscv-tdep.c (riscv_print_one_register_info): Update.
2504         * remote.c (remote_target::enable_btrace): Update.
2505         * record-btrace.c (record_btrace_enable_warn): Update.
2506         * python/py-utils.c (gdbpy_convert_exception): Update.
2507         * printcmd.c (do_one_display, print_variable_and_value): Update.
2508         * mi/mi-main.c (mi_print_exception): Update.
2509         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2510         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2511         * linux-nat.c (linux_nat_target::attach): Update.
2512         * linux-fork.c (class scoped_switch_fork_info): Update.
2513         * infrun.c (displaced_step_prepare): Update.
2514         * infcall.c (call_function_by_hand_dummy): Update.
2515         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2516         * gnu-v3-abi.c (print_one_vtable): Update.
2517         * frame.c (get_prev_frame_always): Update.
2518         * f-valprint.c (info_common_command_for_block): Update.
2519         * exec.c (try_open_exec_file): Update.
2520         * exceptions.c (print_exception, exception_print)
2521         (exception_fprintf, exception_print_same): Update.
2522         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2523         * dwarf-index-cache.c (index_cache::store)
2524         (index_cache::lookup_gdb_index): Update.
2525         * darwin-nat.c (maybe_cache_shell): Update.
2526         * cp-valprint.c (cp_print_value_fields): Update.
2527         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2528         (gcc_cplus_symbol_address): Update.
2529         * compile/compile-c-symbols.c (gcc_convert_symbol)
2530         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2531         * common/selftest.c: Update.
2532         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2533         a std::string.
2534         (exception_try_scope_entry, exception_try_scope_exit): Don't
2535         declare.
2536         (struct exception_try_scope): Remove.
2537         (TRY): Don't use exception_try_scope.
2538         (struct gdb_exception): Add constructor, operator=.
2539         <what>: New method.
2540         (struct gdb_exception_RETURN_MASK_ALL)
2541         (struct gdb_exception_RETURN_MASK_ERROR)
2542         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2543         (struct gdb_quit_bad_alloc): Update.
2544         * common/common-exceptions.c (exception_none): Change
2545         initializer.
2546         (struct catcher) <state, exception>: Initialize inline.
2547         <prev>: Remove member.
2548         (current_catcher): Remove.
2549         (catchers): New global.
2550         (exceptions_state_mc_init): Simplify.
2551         (catcher_pop): Remove.
2552         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2553         (try_scope_depth, exception_try_scope_entry)
2554         (exception_try_scope_exit): Remove.
2555         (throw_exception_sjlj): Update.
2556         (exception_messages, exception_messages_size): Remove.
2557         (throw_it): Simplify.
2558         (gdb_exception_sliced_copy): Remove.
2559         (throw_exception_cxx): Update.
2560         * cli/cli-script.c (script_from_file): Update.
2561         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2562         Update.
2563         * ada-valprint.c (ada_val_print): Update.
2564         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2565         (create_excep_cond_exprs): Update.
2566
2567 2019-04-08  Tom Tromey  <tom@tromey.com>
2568
2569         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2570         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2571         (TRY, CATCH, END_CATCH): Remove some definitions.
2572         * common/common-exceptions.c: Don't use GDB_XCPT.
2573         (catcher_list_size): Remove.
2574         (throw_exception, throw_it): Simplify.
2575
2576 2019-04-05  Tom Tromey  <tom@tromey.com>
2577
2578         Revert the header-sorting patch.
2579         * ft32-tdep.c: Revert.
2580         * frv-tdep.c: Revert.
2581         * frv-linux-tdep.c: Revert.
2582         * frame.c: Revert.
2583         * frame-unwind.c: Revert.
2584         * frame-base.c: Revert.
2585         * fork-child.c: Revert.
2586         * findvar.c: Revert.
2587         * findcmd.c: Revert.
2588         * filesystem.c: Revert.
2589         * filename-seen-cache.h: Revert.
2590         * filename-seen-cache.c: Revert.
2591         * fbsd-tdep.c: Revert.
2592         * fbsd-nat.h: Revert.
2593         * fbsd-nat.c: Revert.
2594         * f-valprint.c: Revert.
2595         * f-typeprint.c: Revert.
2596         * f-lang.c: Revert.
2597         * extension.h: Revert.
2598         * extension.c: Revert.
2599         * extension-priv.h: Revert.
2600         * expprint.c: Revert.
2601         * exec.h: Revert.
2602         * exec.c: Revert.
2603         * exceptions.c: Revert.
2604         * event-top.c: Revert.
2605         * event-loop.c: Revert.
2606         * eval.c: Revert.
2607         * elfread.c: Revert.
2608         * dwarf2read.h: Revert.
2609         * dwarf2read.c: Revert.
2610         * dwarf2loc.c: Revert.
2611         * dwarf2expr.h: Revert.
2612         * dwarf2expr.c: Revert.
2613         * dwarf2-frame.c: Revert.
2614         * dwarf2-frame-tailcall.c: Revert.
2615         * dwarf-index-write.h: Revert.
2616         * dwarf-index-write.c: Revert.
2617         * dwarf-index-common.c: Revert.
2618         * dwarf-index-cache.h: Revert.
2619         * dwarf-index-cache.c: Revert.
2620         * dummy-frame.c: Revert.
2621         * dtrace-probe.c: Revert.
2622         * disasm.h: Revert.
2623         * disasm.c: Revert.
2624         * disasm-selftests.c: Revert.
2625         * dictionary.c: Revert.
2626         * dicos-tdep.c: Revert.
2627         * demangle.c: Revert.
2628         * dcache.h: Revert.
2629         * dcache.c: Revert.
2630         * darwin-nat.h: Revert.
2631         * darwin-nat.c: Revert.
2632         * darwin-nat-info.c: Revert.
2633         * d-valprint.c: Revert.
2634         * d-namespace.c: Revert.
2635         * d-lang.c: Revert.
2636         * ctf.c: Revert.
2637         * csky-tdep.c: Revert.
2638         * csky-linux-tdep.c: Revert.
2639         * cris-tdep.c: Revert.
2640         * cris-linux-tdep.c: Revert.
2641         * cp-valprint.c: Revert.
2642         * cp-support.c: Revert.
2643         * cp-namespace.c: Revert.
2644         * cp-abi.c: Revert.
2645         * corelow.c: Revert.
2646         * corefile.c: Revert.
2647         * continuations.c: Revert.
2648         * completer.h: Revert.
2649         * completer.c: Revert.
2650         * complaints.c: Revert.
2651         * coffread.c: Revert.
2652         * coff-pe-read.c: Revert.
2653         * cli-out.h: Revert.
2654         * cli-out.c: Revert.
2655         * charset.c: Revert.
2656         * c-varobj.c: Revert.
2657         * c-valprint.c: Revert.
2658         * c-typeprint.c: Revert.
2659         * c-lang.c: Revert.
2660         * buildsym.c: Revert.
2661         * buildsym-legacy.c: Revert.
2662         * build-id.h: Revert.
2663         * build-id.c: Revert.
2664         * btrace.c: Revert.
2665         * bsd-uthread.c: Revert.
2666         * breakpoint.h: Revert.
2667         * breakpoint.c: Revert.
2668         * break-catch-throw.c: Revert.
2669         * break-catch-syscall.c: Revert.
2670         * break-catch-sig.c: Revert.
2671         * blockframe.c: Revert.
2672         * block.c: Revert.
2673         * bfin-tdep.c: Revert.
2674         * bfin-linux-tdep.c: Revert.
2675         * bfd-target.c: Revert.
2676         * bcache.c: Revert.
2677         * ax-general.c: Revert.
2678         * ax-gdb.h: Revert.
2679         * ax-gdb.c: Revert.
2680         * avr-tdep.c: Revert.
2681         * auxv.c: Revert.
2682         * auto-load.c: Revert.
2683         * arm-wince-tdep.c: Revert.
2684         * arm-tdep.c: Revert.
2685         * arm-symbian-tdep.c: Revert.
2686         * arm-pikeos-tdep.c: Revert.
2687         * arm-obsd-tdep.c: Revert.
2688         * arm-nbsd-tdep.c: Revert.
2689         * arm-nbsd-nat.c: Revert.
2690         * arm-linux-tdep.c: Revert.
2691         * arm-linux-nat.c: Revert.
2692         * arm-fbsd-tdep.c: Revert.
2693         * arm-fbsd-nat.c: Revert.
2694         * arm-bsd-tdep.c: Revert.
2695         * arch-utils.c: Revert.
2696         * arc-tdep.c: Revert.
2697         * arc-newlib-tdep.c: Revert.
2698         * annotate.h: Revert.
2699         * annotate.c: Revert.
2700         * amd64-windows-tdep.c: Revert.
2701         * amd64-windows-nat.c: Revert.
2702         * amd64-tdep.c: Revert.
2703         * amd64-sol2-tdep.c: Revert.
2704         * amd64-obsd-tdep.c: Revert.
2705         * amd64-obsd-nat.c: Revert.
2706         * amd64-nbsd-tdep.c: Revert.
2707         * amd64-nbsd-nat.c: Revert.
2708         * amd64-nat.c: Revert.
2709         * amd64-linux-tdep.c: Revert.
2710         * amd64-linux-nat.c: Revert.
2711         * amd64-fbsd-tdep.c: Revert.
2712         * amd64-fbsd-nat.c: Revert.
2713         * amd64-dicos-tdep.c: Revert.
2714         * amd64-darwin-tdep.c: Revert.
2715         * amd64-bsd-nat.c: Revert.
2716         * alpha-tdep.c: Revert.
2717         * alpha-obsd-tdep.c: Revert.
2718         * alpha-nbsd-tdep.c: Revert.
2719         * alpha-mdebug-tdep.c: Revert.
2720         * alpha-linux-tdep.c: Revert.
2721         * alpha-linux-nat.c: Revert.
2722         * alpha-bsd-tdep.c: Revert.
2723         * alpha-bsd-nat.c: Revert.
2724         * aix-thread.c: Revert.
2725         * agent.c: Revert.
2726         * addrmap.c: Revert.
2727         * ada-varobj.c: Revert.
2728         * ada-valprint.c: Revert.
2729         * ada-typeprint.c: Revert.
2730         * ada-tasks.c: Revert.
2731         * ada-lang.c: Revert.
2732         * aarch64-tdep.c: Revert.
2733         * aarch64-ravenscar-thread.c: Revert.
2734         * aarch64-newlib-tdep.c: Revert.
2735         * aarch64-linux-tdep.c: Revert.
2736         * aarch64-linux-nat.c: Revert.
2737         * aarch64-fbsd-tdep.c: Revert.
2738         * aarch64-fbsd-nat.c: Revert.
2739         * aarch32-linux-nat.c: Revert.
2740
2741 2019-04-05  Tom Tromey  <tom@tromey.com>
2742
2743         * ft32-tdep.c: Sort headers.
2744         * frv-tdep.c: Sort headers.
2745         * frv-linux-tdep.c: Sort headers.
2746         * frame.c: Sort headers.
2747         * frame-unwind.c: Sort headers.
2748         * frame-base.c: Sort headers.
2749         * fork-child.c: Sort headers.
2750         * findvar.c: Sort headers.
2751         * findcmd.c: Sort headers.
2752         * filesystem.c: Sort headers.
2753         * filename-seen-cache.h: Sort headers.
2754         * filename-seen-cache.c: Sort headers.
2755         * fbsd-tdep.c: Sort headers.
2756         * fbsd-nat.h: Sort headers.
2757         * fbsd-nat.c: Sort headers.
2758         * f-valprint.c: Sort headers.
2759         * f-typeprint.c: Sort headers.
2760         * f-lang.c: Sort headers.
2761         * extension.h: Sort headers.
2762         * extension.c: Sort headers.
2763         * extension-priv.h: Sort headers.
2764         * expprint.c: Sort headers.
2765         * exec.h: Sort headers.
2766         * exec.c: Sort headers.
2767         * exceptions.c: Sort headers.
2768         * event-top.c: Sort headers.
2769         * event-loop.c: Sort headers.
2770         * eval.c: Sort headers.
2771         * elfread.c: Sort headers.
2772         * dwarf2read.h: Sort headers.
2773         * dwarf2read.c: Sort headers.
2774         * dwarf2loc.c: Sort headers.
2775         * dwarf2expr.h: Sort headers.
2776         * dwarf2expr.c: Sort headers.
2777         * dwarf2-frame.c: Sort headers.
2778         * dwarf2-frame-tailcall.c: Sort headers.
2779         * dwarf-index-write.h: Sort headers.
2780         * dwarf-index-write.c: Sort headers.
2781         * dwarf-index-common.c: Sort headers.
2782         * dwarf-index-cache.h: Sort headers.
2783         * dwarf-index-cache.c: Sort headers.
2784         * dummy-frame.c: Sort headers.
2785         * dtrace-probe.c: Sort headers.
2786         * disasm.h: Sort headers.
2787         * disasm.c: Sort headers.
2788         * disasm-selftests.c: Sort headers.
2789         * dictionary.c: Sort headers.
2790         * dicos-tdep.c: Sort headers.
2791         * demangle.c: Sort headers.
2792         * dcache.h: Sort headers.
2793         * dcache.c: Sort headers.
2794         * darwin-nat.h: Sort headers.
2795         * darwin-nat.c: Sort headers.
2796         * darwin-nat-info.c: Sort headers.
2797         * d-valprint.c: Sort headers.
2798         * d-namespace.c: Sort headers.
2799         * d-lang.c: Sort headers.
2800         * ctf.c: Sort headers.
2801         * csky-tdep.c: Sort headers.
2802         * csky-linux-tdep.c: Sort headers.
2803         * cris-tdep.c: Sort headers.
2804         * cris-linux-tdep.c: Sort headers.
2805         * cp-valprint.c: Sort headers.
2806         * cp-support.c: Sort headers.
2807         * cp-namespace.c: Sort headers.
2808         * cp-abi.c: Sort headers.
2809         * corelow.c: Sort headers.
2810         * corefile.c: Sort headers.
2811         * continuations.c: Sort headers.
2812         * completer.h: Sort headers.
2813         * completer.c: Sort headers.
2814         * complaints.c: Sort headers.
2815         * coffread.c: Sort headers.
2816         * coff-pe-read.c: Sort headers.
2817         * cli-out.h: Sort headers.
2818         * cli-out.c: Sort headers.
2819         * charset.c: Sort headers.
2820         * c-varobj.c: Sort headers.
2821         * c-valprint.c: Sort headers.
2822         * c-typeprint.c: Sort headers.
2823         * c-lang.c: Sort headers.
2824         * buildsym.c: Sort headers.
2825         * buildsym-legacy.c: Sort headers.
2826         * build-id.h: Sort headers.
2827         * build-id.c: Sort headers.
2828         * btrace.c: Sort headers.
2829         * bsd-uthread.c: Sort headers.
2830         * breakpoint.h: Sort headers.
2831         * breakpoint.c: Sort headers.
2832         * break-catch-throw.c: Sort headers.
2833         * break-catch-syscall.c: Sort headers.
2834         * break-catch-sig.c: Sort headers.
2835         * blockframe.c: Sort headers.
2836         * block.c: Sort headers.
2837         * bfin-tdep.c: Sort headers.
2838         * bfin-linux-tdep.c: Sort headers.
2839         * bfd-target.c: Sort headers.
2840         * bcache.c: Sort headers.
2841         * ax-general.c: Sort headers.
2842         * ax-gdb.h: Sort headers.
2843         * ax-gdb.c: Sort headers.
2844         * avr-tdep.c: Sort headers.
2845         * auxv.c: Sort headers.
2846         * auto-load.c: Sort headers.
2847         * arm-wince-tdep.c: Sort headers.
2848         * arm-tdep.c: Sort headers.
2849         * arm-symbian-tdep.c: Sort headers.
2850         * arm-pikeos-tdep.c: Sort headers.
2851         * arm-obsd-tdep.c: Sort headers.
2852         * arm-nbsd-tdep.c: Sort headers.
2853         * arm-nbsd-nat.c: Sort headers.
2854         * arm-linux-tdep.c: Sort headers.
2855         * arm-linux-nat.c: Sort headers.
2856         * arm-fbsd-tdep.c: Sort headers.
2857         * arm-fbsd-nat.c: Sort headers.
2858         * arm-bsd-tdep.c: Sort headers.
2859         * arch-utils.c: Sort headers.
2860         * arc-tdep.c: Sort headers.
2861         * arc-newlib-tdep.c: Sort headers.
2862         * annotate.h: Sort headers.
2863         * annotate.c: Sort headers.
2864         * amd64-windows-tdep.c: Sort headers.
2865         * amd64-windows-nat.c: Sort headers.
2866         * amd64-tdep.c: Sort headers.
2867         * amd64-sol2-tdep.c: Sort headers.
2868         * amd64-obsd-tdep.c: Sort headers.
2869         * amd64-obsd-nat.c: Sort headers.
2870         * amd64-nbsd-tdep.c: Sort headers.
2871         * amd64-nbsd-nat.c: Sort headers.
2872         * amd64-nat.c: Sort headers.
2873         * amd64-linux-tdep.c: Sort headers.
2874         * amd64-linux-nat.c: Sort headers.
2875         * amd64-fbsd-tdep.c: Sort headers.
2876         * amd64-fbsd-nat.c: Sort headers.
2877         * amd64-dicos-tdep.c: Sort headers.
2878         * amd64-darwin-tdep.c: Sort headers.
2879         * amd64-bsd-nat.c: Sort headers.
2880         * alpha-tdep.c: Sort headers.
2881         * alpha-obsd-tdep.c: Sort headers.
2882         * alpha-nbsd-tdep.c: Sort headers.
2883         * alpha-mdebug-tdep.c: Sort headers.
2884         * alpha-linux-tdep.c: Sort headers.
2885         * alpha-linux-nat.c: Sort headers.
2886         * alpha-bsd-tdep.c: Sort headers.
2887         * alpha-bsd-nat.c: Sort headers.
2888         * aix-thread.c: Sort headers.
2889         * agent.c: Sort headers.
2890         * addrmap.c: Sort headers.
2891         * ada-varobj.c: Sort headers.
2892         * ada-valprint.c: Sort headers.
2893         * ada-typeprint.c: Sort headers.
2894         * ada-tasks.c: Sort headers.
2895         * ada-lang.c: Sort headers.
2896         * aarch64-tdep.c: Sort headers.
2897         * aarch64-ravenscar-thread.c: Sort headers.
2898         * aarch64-newlib-tdep.c: Sort headers.
2899         * aarch64-linux-tdep.c: Sort headers.
2900         * aarch64-linux-nat.c: Sort headers.
2901         * aarch64-fbsd-tdep.c: Sort headers.
2902         * aarch64-fbsd-nat.c: Sort headers.
2903         * aarch32-linux-nat.c: Sort headers.
2904
2905 2019-04-04  Tom Tromey  <tom@tromey.com>
2906
2907         * varobj.c (varobj_create): Update.
2908         * rust-exp.y (struct rust_parser) <update_innermost_block,
2909         lookup_symbol>: New methods.
2910         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2911         Rename.
2912         (rust_parser::rust_lookup_type)
2913         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2914         * printcmd.c (display_command, do_one_display): Update.
2915         * parser-defs.h (struct parser_state) <parser_state>: Add
2916         "tracker" parameter.
2917         (block_tracker): New member.
2918         (class innermost_block_tracker) <innermost_block_tracker>: Add
2919         "types" parameter.
2920         <reset>: Remove method.
2921         (innermost_block): Don't declare.
2922         (null_post_parser): Update.
2923         * parse.c (innermost_block): Remove global.
2924         (write_dollar_variable): Update.
2925         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2926         Remove "tracker_types" parameter.
2927         (parse_expression): Add "tracker" parameter.
2928         (parse_expression_for_completion): Update.
2929         (null_post_parser): Add "tracker" parameter.
2930         * p-exp.y: Update rules.
2931         * m2-exp.y: Update rules.
2932         * language.h (struct language_defn) <la_post_parser>: Add
2933         "tracker" parameter.
2934         * go-exp.y: Update rules.
2935         * f-exp.y: Update rules.
2936         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2937         parameter.
2938         * d-exp.y: Update rules.
2939         * c-exp.y: Update rules.
2940         * breakpoint.c (set_breakpoint_condition): Create an
2941         innermost_block_tracker.
2942         (watch_command_1): Likewise.
2943         * ada-lang.c (resolve): Add "tracker" parameter.
2944         (resolve_subexp): Likewise.
2945         * ada-exp.y (write_var_from_sym): Update.
2946
2947 2019-04-04  Tom Tromey  <tom@tromey.com>
2948
2949         * type-stack.h: New file.
2950         * type-stack.c: New file.
2951         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2952         type-stack.h.
2953         (insert_into_type_stack, insert_type, push_type, push_type_int)
2954         (insert_type_address_space, pop_type, pop_type_int)
2955         (pop_typelist, pop_type_stack, append_type_stack)
2956         (push_type_stack, get_type_stack, push_typelist)
2957         (follow_type_instance_flags, follow_types): Don't declare.
2958         * parse.c (type_stack): Remove global.
2959         (parse_exp_in_context): Update.
2960         (insert_into_type_stack, insert_type, push_type, push_type_int)
2961         (insert_type_address_space, pop_type, pop_type_int)
2962         (pop_typelist, pop_type_stack, append_type_stack)
2963         (push_type_stack, get_type_stack, push_typelist)
2964         (follow_type_instance_flags, follow_types): Remove (moved to
2965         type-stack.c).
2966         * f-exp.y (type_stack): New global.
2967         Update rules.
2968         (push_kind_type, f_parse): Update.
2969         * d-exp.y (type_stack): New global.
2970         Update rules.
2971         (d_parse): Update.
2972         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2973         Update rules.
2974         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2975         (HFILES_NO_SRCDIR): Add type-stack.h.
2976
2977 2019-04-04  Tom Tromey  <tom@tromey.com>
2978
2979         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2980         (rust_parser::convert_ast_to_expression, rust_parse)
2981         (rust_lex_test_completion, rust_lex_tests): Update.
2982         * parser-defs.h (struct expr_completion_state): New.
2983         (struct parser_state) <parser_state>: Add completion parameter.
2984         <mark_struct_expression, mark_completion_tag>: New methods.
2985         <parse_completion, m_completion_state>: New members.
2986         (prefixify_expression, null_post_parser): Update.
2987         (mark_struct_expression, mark_completion_tag): Don't declare.
2988         * parse.c (parse_completion, expout_last_struct)
2989         (expout_tag_completion_type, expout_completion_name): Remove
2990         globals.
2991         (parser_state::mark_struct_expression)
2992         (parser_state::mark_completion_tag): Now methods.
2993         (prefixify_expression): Add last_struct parameter.
2994         (prefixify_subexp): Likewise.
2995         (parse_exp_1): Update.
2996         (parse_exp_in_context): Add cstate parameter.  Update.
2997         (parse_expression_for_completion): Create an
2998         expr_completion_state.
2999         (null_post_parser): Add "completion" parameter.
3000         * p-exp.y: Update rules.
3001         (yylex): Update.
3002         * language.h (struct language_defn) <la_post_parser>: Add
3003         "completing" parameter.
3004         * go-exp.y: Update rules.
3005         (lex_one_token): Update.
3006         * expression.h (parse_completion): Don't declare.
3007         * d-exp.y: Update rules.
3008         (lex_one_token): Update rules.
3009         * c-exp.y: Update rules.
3010         (lex_one_token): Update.
3011         * ada-lang.c (resolve): Add "parse_completion" parameter.
3012         (resolve_subexp): Likewise.
3013         (ada_resolve_function): Likewise.
3014
3015 2019-04-04  Tom Tromey  <tom@tromey.com>
3016
3017         * parser-defs.h (struct parser_state) <start_arglist,
3018         end_arglist>: New methods.
3019         <arglist_len, m_funcall_chain>: New members.
3020         (arglist_len, start_arglist, end_arglist): Don't declare.
3021         * parse.c (arglist_len, funcall_chain): Remove global.
3022         (start_arglist, end_arglist): Remove functions.
3023         (parse_exp_in_context): Update.
3024         * p-exp.y: Update rules.
3025         * m2-exp.y: Update rules.
3026         * go-exp.y: Update rules.
3027         * f-exp.y: Update rules.
3028         * d-exp.y: Update rules.
3029         * c-exp.y: Update rules.
3030
3031 2019-04-04  Tom Tromey  <tom@tromey.com>
3032
3033         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3034         lex_operator, push_back>: New methods.
3035         Update all rules.
3036         (rust_parser::lex_hex, lex_escape): Rename and update.
3037         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3038         (rust_parser::lex_operator): Rename and update.
3039         (rust_parser::lex_number, rustyylex, rustyyerror)
3040         (rust_lex_test_init, rust_lex_test_sequence)
3041         (rust_lex_test_push_back, rust_lex_tests): Update.
3042         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3043         parameter.
3044         <lexptr, prev_lexptr>: New members.
3045         (lexptr, prev_lexptr): Don't declare.
3046         * parse.c (lexptr, prev_lexptr): Remove globals.
3047         (parse_exp_in_context): Update.
3048         * p-exp.y (yylex, yyerror): Update.
3049         * m2-exp.y (parse_number, yylex, yyerror): Update.
3050         * go-exp.y (lex_one_token, yyerror): Update.
3051         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3052         * d-exp.y (lex_one_token, yyerror): Update.
3053         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3054         (lex_one_token, yyerror): Update.
3055         * ada-lex.l (YY_INPUT): Update.
3056         (rewind_to_char): Update.
3057         * ada-exp.y (yyerror): Update.
3058
3059 2019-04-04  Tom Tromey  <tom@tromey.com>
3060
3061         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3062         * parser-defs.h (struct parser_state) <parser_state>: Add new
3063         parameter.
3064         <comma_terminates>: New member.
3065         (comma_terminates): Don't declare global.
3066         * parse.c (comma_terminates): Remove global.
3067         (parse_exp_in_context): Update.
3068         * p-exp.y (yylex): Update.
3069         * m2-exp.y (yylex): Update.
3070         * go-exp.y (lex_one_token): Update.
3071         * f-exp.y (yylex): Update.
3072         * d-exp.y (lex_one_token): Update.
3073         * c-exp.y (lex_one_token): Update.
3074         * ada-lex.l: Update.
3075
3076 2019-04-04  Tom Tromey  <tom@tromey.com>
3077
3078         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3079         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3080         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3081         * parser-defs.h (paren_depth): Don't declare.
3082         * parse.c (paren_depth): Remove global.
3083         (parse_exp_in_context): Update.
3084         * p-exp.y (paren_depth): New global.
3085         (pascal_parse): Initialize it.
3086         * m2-exp.y (paren_depth): New global.
3087         (m2_parse): Initialize it.
3088         * go-exp.y (paren_depth): New global.
3089         (go_parse): Initialize it.
3090         * f-exp.y (paren_depth): New global.
3091         (f_parse): Initialize it.
3092         * d-exp.y (paren_depth): New global.
3093         (d_parse): Initialize it.
3094         * c-exp.y (paren_depth): New global.
3095         (c_parse): Initialize it.
3096         * ada-lex.l (paren_depth): New global.
3097         (lexer_init): Initialize it.
3098
3099 2019-04-04  Tom Tromey  <tom@tromey.com>
3100
3101         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3102         (rust_parser::convert_ast_to_type)
3103         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3104         * parser-defs.h (struct parser_state) <parser_state>: Add
3105         parameters.  Initialize new members.
3106         <expression_context_block, expression_context_pc>: New members.
3107         * parse.c (expression_context_block, expression_context_pc):
3108         Remove globals.
3109         (parse_exp_in_context): Update.
3110         * p-exp.y: Update all rules.
3111         (yylex): Update.
3112         * m2-exp.y: Update all rules.
3113         (yylex): Update.
3114         * go-exp.y (yylex): Update.
3115         * f-exp.y (yylex): Update.
3116         * d-exp.y: Update all rules.
3117         (yylex): Update.
3118         * c-exp.y: Update all rules.
3119         (lex_one_token, classify_name, yylex, c_parse): Update.
3120         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3121
3122 2019-04-04  Tom Tromey  <tom@tromey.com>
3123
3124         * gdbarch.h, gdbarch.c: Rebuild.
3125         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3126         * stap-probe.h:
3127         (struct stap_parse_info): Replace "parser_state" with
3128         "expr_builder".
3129         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3130         (parser_state): New class.
3131         * parse.c (expr_builder): Rename.
3132         (expr_builder::release): Rename.
3133         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3134         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3135         (write_exp_elt_longcst, write_exp_elt_floatcst)
3136         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3137         (write_exp_string_vector, write_exp_bitstring)
3138         (write_exp_msymbol, mark_struct_expression)
3139         (write_dollar_variable)
3140         (insert_type_address_space, increase_expout_size): Replace
3141         "parser_state" with "expr_builder".
3142         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3143         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3144         "parser_state" with "expr_builder".
3145
3146 2019-04-04  Tom Tromey  <tom@tromey.com>
3147
3148         * rust-exp.y: Replace "parse_language" with method call.
3149         * p-exp.y:
3150         (yylex): Replace "parse_language" with method call.
3151         * m2-exp.y:
3152         (yylex): Replace "parse_language" with method call.
3153         * go-exp.y (classify_name): Replace "parse_language" with method
3154         call.
3155         * f-exp.y (yylex): Replace "parse_language" with method call.
3156         * d-exp.y (lex_one_token): Replace "parse_language" with method
3157         call.
3158         * c-exp.y:
3159         (lex_one_token, classify_name, yylex): Replace "parse_language"
3160         with method call.
3161         * ada-exp.y (find_primitive_type, type_char)
3162         (type_system_address): Replace "parse_language" with method call.
3163
3164 2019-04-04  Tom Tromey  <tom@tromey.com>
3165
3166         * rust-exp.y: Replace "parse_gdbarch" with method call.
3167         * parse.c (write_dollar_variable, insert_type_address_space):
3168         Replace "parse_gdbarch" with method call.
3169         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3170         call.
3171         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3172         call.
3173         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3174         "parse_gdbarch" with method call.
3175         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3176         with method call.
3177         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3178         "parse_gdbarch" with method call.
3179         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3180         "parse_gdbarch" with method call.
3181         * c-exp.y (parse_type, parse_number, classify_name): Replace
3182         "parse_gdbarch" with method call.
3183         * ada-lex.l: Replace "parse_gdbarch" with method call.
3184         * ada-exp.y (parse_type, find_primitive_type, type_char)
3185         (type_system_address): Replace "parse_gdbarch" with method call.
3186
3187 2019-04-04  Tom Tromey  <tom@tromey.com>
3188
3189         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3190         * stap-probe.c (stap_parse_argument): Update.
3191         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3192         initial_size parameter.
3193         * rust-exp.y (rust_lex_tests): Update.
3194         * parse.c (parser_state): Update.
3195         (parse_exp_in_context): Update.
3196         * parser-defs.h (struct parser_state) <parser_state>: Remove
3197         "initial_size" parameter.
3198
3199 2019-04-04  Tom Tromey  <tom@tromey.com>
3200
3201         * parser-defs.h (increase_expout_size): Don't declare.
3202         * parse.c (increase_expout_size): Now static.
3203
3204 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3205
3206         * gnu-nat.c (gnu_nat_target::wait): Fix
3207         target_waitstatus_to_string call.
3208
3209 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3210
3211         * eval.c (evaluate_subexp_standard): Handle internal functions
3212         during Fortran function call handling.
3213
3214 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3215
3216         * NEWS: Mention new internal functions.
3217         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3218         (read_base_type): Use dwarf2_init_complex_target_type.
3219         * value.c (creal_internal_fn): New function.
3220         (cimag_internal_fn): New function.
3221         (_initialize_values): Register new internal functions.
3222
3223 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3224
3225         * infrun.c (stop_all_threads): If debug_infrun, always
3226         trace the wait status after wait_one, using
3227         target_waitstatus_to_string and target_pid_to_str.
3228         (handle_inferior_event): Replace various trace of
3229         wait status kind by a single trace.
3230         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3231         wait status kind image by target_waitstatus_to_string.
3232         * target/waitstatus.c (target_waitstatus_to_string): Fix
3233         obsolete comment.
3234
3235 2019-04-01  Tom Tromey  <tromey@adacore.com>
3236
3237         PR symtab/23331:
3238         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3239
3240 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3241             Pedro Alves  <palves@redhat.com>
3242
3243         * top.c (quit_force): Call 'finalize_values'.
3244         * value.c (finalize_values): New function.
3245         * value.h (finalize_values): Declare.
3246
3247 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3248
3249         * NEWS: Announce $_gdb_major and $_gdb_minor.
3250
3251         * top.c (init_gdb_version_vars): New function.
3252         (gdb_init): Call init_gdb_version_vars.
3253
3254 2019-03-29  Tom Tromey  <tromey@adacore.com>
3255
3256         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3257         help text.  Remove dead code.
3258
3259 2019-03-29  Keith Seitz  <keiths@redhat.com>
3260
3261         From Siddhesh Poyarekar:
3262         * f-lang.h (f77_get_upperbound): Return LONGEST.
3263         (f77_get_lowerbound): Likewise.
3264         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3265         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3266         print them.
3267         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3268         plongest to format print it.
3269         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3270         (f77_get_upperbound): Likewise.
3271         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3272         LOWER_BOUND to LONGEST.
3273         (f77_create_arrayprint_offset_tbl): Likewise.
3274
3275 2019-03-29  Keith Seitz  <keiths@redhat.com>
3276
3277         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3278         %s/pulongest for TYPE_LENGTH instead of %d in format
3279         strings.
3280         * ada-typerint.c (ada_print_type): Likewise.
3281         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3282         * compile/compile-c-support.c (generate_register_struct): Likewise.
3283         * gdbtypes.c (recursive_dump_type): Likewise.
3284         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3285         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3286         instead of %d in format strings.
3287         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3288         to std::min to ULONGEST.
3289         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3290         instead of %d in format strings.
3291         * tracepoint.c (info_scope_command): Likewise.
3292         * typeprint.c (print_offset_data::update)
3293         (print_offset_data::finish): Likewise.
3294         * xtensa-tdep.c (xtensa_store_return_value)
3295         (xtensa_push_dummy_call): Likewise.
3296
3297 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3298
3299         * windows-nat.c (display_selector): Fixed format specifications
3300         for 64-bit Cygwin.
3301
3302 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3303
3304         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3305
3306 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3307
3308         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3309         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3310         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3311         (nios2_linux_init_abi): Install it.
3312
3313 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3314
3315         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3316
3317 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3318
3319         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3320
3321 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3322             Tom Tromey  <tromey@adacore.com>
3323
3324         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3325
3326 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3327
3328         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3329         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3330         method to compute the bounds of range types. Also print "[evaluated]"
3331         if the bounds' values come from a dynamic evaluation.
3332
3333 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3334
3335         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3336         whitespace when pretty printing is on.
3337
3338 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3339
3340         * ppc-linux-nat.c: Add include.
3341
3342 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3343
3344         * NEWS: Mention AArch64 Pointer Authentication.
3345
3346 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3347
3348         * arm-linux-nat.c: Add include.
3349
3350 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3351
3352         * source-cache.c (source_cache::get_source_lines): Re-read
3353         fullname after calling open_source_file.
3354
3355 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3356
3357         * NEWS: Mention TLS support for FreeBSD.
3358
3359 2019-03-25  Tom Tromey  <tromey@adacore.com>
3360
3361         * minsyms.c (BUNCH_SIZE): Update comment.
3362         (~minimal_symbol_reader): Remove old comment.
3363         (compact_minimal_symbols): Update comment.
3364         (minimal_symbol_reader::install): Remove old comment.  Update
3365         other comments.
3366
3367 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3368
3369         * s390-linux-nat.c: Add include.
3370
3371 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3372
3373         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3374         Call linux_get_hwcap.
3375         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3376         Likewise.
3377         (aarch64_linux_get_hwcap): Remove function.
3378         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3379         declaration.
3380         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3381         linux_get_hwcap.
3382         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3383         * linux-tdep.c (linux_get_hwcap): Add function.
3384         (linux_get_hwcap2): Likewise.
3385         * linux-tdep.h (linux_get_hwcap): Add declaration.
3386         (linux_get_hwcap2): Likewise.
3387         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3388         (ppc_linux_get_hwcap2): Likewise.
3389         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3390         linux_get_hwcap.
3391         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3392         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3393         (ppc_linux_nat_target::read_description): Likewise.
3394         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3395         * s390-linux-nat.c: Likewise.
3396         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3397
3398 2019-03-24  Tom Tromey  <tom@tromey.com>
3399
3400         * ada-lang.c (standard_lookup): Simplify initialization.
3401         (ada_lookup_symbol_nonlocal): Simplify return.
3402         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3403         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3404         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3405         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3406         initialization.
3407         * solib.c (solib_global_lookup): Simplify.
3408         * symtab.c (null_block_symbol): Remove.
3409         (symbol_cache_lookup): Simplify returns.
3410         (lookup_language_this): Simplify returns.
3411         (lookup_symbol_aux): Simplify return.
3412         (lookup_local_symbol): Simplify returns.
3413         (lookup_global_symbol_from_objfile): Simplify return.
3414         (lookup_symbol_in_objfile_symtabs)
3415         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3416         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3417         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3418         * cp-namespace.c (cp_lookup_bare_symbol)
3419         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3420         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3421         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3422         (cp_lookup_symbol_via_imports): Simplify initialization.
3423         (find_symbol_in_baseclass): Likewise.
3424         * symtab.h (null_block_symbol): Remove.
3425         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3426         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3427         (d_lookup_symbol_module): Likewise.
3428         (find_symbol_in_baseclass): Simplify initialization.
3429
3430 2019-03-24  Tom Tromey  <tom@tromey.com>
3431
3432         * expression.h: Don't include symtab.h.
3433         (struct block): Forward declare.
3434
3435 2019-03-24  Tom Tromey  <tom@tromey.com>
3436
3437         * c-exp.y (typebase): Remove casts.
3438         * gdbtypes.c (lookup_unsigned_typename, )
3439         (lookup_signed_typename): Remove cast.
3440         * eval.c (parse_to_comma_and_eval): Remove cast.
3441         * parse.c (write_dollar_variable): Remove cast.
3442         * block.h (struct block) <superblock>: Now const.
3443         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3444         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3445         (map_block): Make "block" const.
3446         * symfile.h (struct quick_symbol_functions)
3447         <map_matching_symbols>: Constify block argument to "callback".
3448         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3449         const.
3450         (find_pc_sect_compunit_symtab): Make "b" const.
3451         (find_symbol_at_address): Likewise.
3452         (search_symbols): Likewise.
3453         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3454         (dw2_debug_names_lookup_symbol): Likewise.
3455         (dw2_map_matching_symbols): Update.
3456         * p-valprint.c (pascal_val_print): Remove "block".
3457         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3458         (aux_add_nonlocal_symbols): Make "block" const.
3459         (resolve_subexp): Remove cast.
3460         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3461         const.
3462         (iterate_over_file_blocks): Likewise.
3463         * f-exp.y (%union) <bval>: Remove.
3464         * coffread.c (patch_opaque_types): Make "b" const.
3465         * spu-tdep.c (spu_catch_start): Make "block" const.
3466         * c-valprint.c (print_unpacked_pointer): Remove "block".
3467         * symmisc.c (dump_symtab_1): Make "b" const.
3468         (block_depth): Make "block" const.
3469         * d-exp.y (%union) <bval>: Remove.
3470         * cp-support.h (cp_lookup_rtti_type): Update.
3471         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3472         * psymtab.c (psym_lookup_symbol): Make "block" const.
3473         (maintenance_check_psymtabs): Make "b" const.
3474         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3475         (enumerate_locals, enumerate_args): Update.
3476         * python/py-symtab.c (stpy_global_block): Make "block" const.
3477         (stpy_static_block): Likewise.
3478         * inline-frame.c (block_starting_point_at): Make "new_block"
3479         const.
3480         * block.c (find_block_in_blockvector): Make return type const.
3481         (blockvector_for_pc_sect): Make "b" const.
3482         (find_block_in_blockvector): Make "b" const.
3483
3484 2019-03-23  Tom Tromey  <tom@tromey.com>
3485
3486         * varobj.c (varobj_create): Update.
3487         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3488         * printcmd.c (display_command, do_one_display): Don't reset
3489         innermost_block.
3490         * parser-defs.h (enum innermost_block_tracker_type): Move to
3491         expression.h.
3492         (innermost_block): Update comment.
3493         * parse.c (parse_exp_1): Add tracker_types parameter.
3494         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3495         tracker_types parameter.  Reset innermost_block.
3496         (parse_exp_in_context): Remove.
3497         (parse_expression_for_completion): Update.
3498         * objfiles.c (~objfile): Don't reset expression_context_block or
3499         innermost_block.
3500         * expression.h (enum innermost_block_tracker_type): Move from
3501         parser-defs.h.
3502         (parse_exp_1): Add tracker_types parameter.
3503         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3504         reset innermost_block.
3505
3506 2019-03-23  Tom Tromey  <tom@tromey.com>
3507
3508         * objfiles.h: Include bcache.h.
3509
3510 2019-03-23  Tom Tromey  <tom@tromey.com>
3511
3512         * linespec.c (get_current_search_block): Use
3513         scoped_restore_current_language.
3514         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3515
3516 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3517             Jiong Wang  <jiong.wang@arm.com>
3518
3519         * aarch64-linux-tdep.c
3520         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3521         section.
3522         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3523
3524 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3525             Jiong Wang  <jiong.wang@arm.com>
3526
3527         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3528         instructions.
3529         (aarch64_analyze_prologue_test): Add PACIASP test.
3530         (aarch64_prologue_prev_register): Unmask PC value.
3531
3532 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3533             Jiong Wang  <jiong.wang@arm.com>
3534
3535         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3536         (aarch64_dwarf2_prev_register): Unmask PC value.
3537         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3538         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3539         DW_CFA_AARCH64_negate_ra_state.
3540         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3541
3542 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3543             Jiong Wang  <jiong.wang@arm.com>
3544
3545         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3546         registers.
3547         (aarch64_pseudo_register_name): Likewise.
3548         (aarch64_pseudo_register_type): Likewise.
3549         (aarch64_pseudo_register_reggroup_p): Likewise.
3550         (aarch64_gdbarch_init): Add pauth registers.
3551         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3552         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3553         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3554         (struct gdbarch_tdep): Add regnum for ra_state.
3555
3556 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3557             Jiong Wang  <jiong.wang@arm.com>
3558
3559         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3560
3561 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3562             Jiong Wang  <jiong.wang@arm.com>
3563
3564         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3565         function.
3566         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3567         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3568         (aarch64_gdbarch_init): Add puth registers.
3569         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3570         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3571         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3572
3573 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3574             Jiong Wang  <jiong.wang@arm.com>
3575
3576         * aarch64-linux-nat.c
3577         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3578         * aarch64-linux-tdep.c
3579         (aarch64_linux_core_read_description): Likewise.
3580         (aarch64_linux_get_hwcap): New function.
3581         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3582         (aarch64_linux_get_hwcap): New declaration.
3583
3584 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3585             Jiong Wang  <jiong.wang@arm.com>
3586
3587         * aarch64-linux-nat.c
3588         (aarch64_linux_nat_target::read_description): Add pauth param.
3589         * aarch64-linux-tdep.c
3590         (aarch64_linux_core_read_description): Likewise.
3591         * aarch64-tdep.c (struct target_desc): Add in pauth.
3592         (aarch64_read_description): Add pauth param.
3593         (aarch64_gdbarch_init): Likewise.
3594         * aarch64-tdep.h (aarch64_read_description): Likewise.
3595         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3596         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3597         * features/Makefile: Add new files.
3598         * features/aarch64-pauth.c: New file.
3599         * features/aarch64-pauth.xml: New file.
3600
3601 2019-03-20  Tom Tromey  <tromey@adacore.com>
3602
3603         * infrun.c (handle_inferior_event): Rename from
3604         handle_inferior_event_1.  Create a scoped_value_mark.
3605         (handle_inferior_event): Remove.
3606
3607 2019-03-19  Tom Tromey  <tromey@adacore.com>
3608
3609         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3610         * infrun.h (print_stop_event): Add "displays" parameter.
3611         * infrun.c (print_stop_event): Add "displays" parameter.
3612
3613 2019-03-19  Pedro Alves  <palves@redhat.com>
3614
3615         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3616         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3617         to -1.  Fix TABs vs spaces.
3618         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3619         * tui/tui-out.h (tui_ui_out) Add intro comments.
3620         <m_line, m_start_of_line>: In-class initialize, and add describing
3621         comment.
3622
3623 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3624
3625         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3626         variable names.
3627         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3628
3629 2019-03-18  Pedro Alves  <palves@redhat.com>
3630             Eli Zaretskii <eliz@gnu.org>
3631
3632         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3633         m_line and m_start_of_line.
3634
3635 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3636
3637         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3638         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3639         it returns a newline.  This fixes a regression in TU mode, whereby
3640         the next line is output on the same screen line as the user input.
3641
3642 2019-03-18  Tom Tromey  <tromey@adacore.com>
3643
3644         * minsyms.c (minimal_symbol_reader::install): Remove call to
3645         obstack_blank.
3646
3647 2019-03-18  Pedro Alves  <palves@redhat.com>
3648
3649         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3650         New globals.
3651         (apply_style): New, factored out from ...
3652         (apply_ansi_escape): ... this.  Handle reverse video mode.
3653         (tui_set_reverse_mode): New function.
3654         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3655         * tui/tui-winsource.c (tui_show_source_line): Use
3656         tui_set_reverse_mode instead of setting A_STANDOUT.
3657         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3658         New setter methods.
3659
3660 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3661
3662         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3663         Handle tabs.
3664
3665 2019-03-18  Tom Tromey  <tromey@adacore.com>
3666
3667         * ada-lang.c (empty_array): Add "high" parameter.
3668         (ada_evaluate_subexp): Update.
3669
3670 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3671
3672         * unittests/string_view-selftests.c: Define
3673         _initialize_string_view_selftests unconditionally.
3674
3675 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3676
3677         PR gdb/24350
3678         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3679
3680 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3681
3682         PR gdb/24351
3683         * windows-nat.c (display_selector): Fix format specifiers.
3684
3685 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3686
3687         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3688         tui_refill_source_window instead of tui_refresh_win, to update the
3689         current execution line.  This fixes redisplay of the current line
3690         when stepping through the code with "next" or "step".
3691
3692 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3693
3694         * source-cache.c (source_cache::get_source_lines): Call
3695         find_source_lines to initialize s->nlines.  This fixes vertical
3696         scrolling of TUI source window when the DOWN arrow is pressed.
3697
3698 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3699
3700         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3701         linux-thread-db.c (_initialize_thread_db): Likewise.
3702
3703 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3704
3705         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3706         wclrtoeol in tui_show_source_line".  This reverts changes made in
3707         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3708
3709 2019-03-15  Tom Tromey  <tom@tromey.com>
3710
3711         * symtab.h (struct minimal_symbol): Derive from
3712         general_symbol_info.
3713         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3714         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3715         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3716         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3717         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3718         (MSYMBOL_SEARCH_NAME): Update.
3719         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3720         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3721         * minsyms.c (minimal_symbol_reader::record_full): Update.
3722
3723 2019-03-15  Tom Tromey  <tom@tromey.com>
3724
3725         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3726
3727 2019-03-15  Tom Tromey  <tom@tromey.com>
3728
3729         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3730         unique_xmalloc_ptr.
3731         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3732         Update.
3733         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3734         (build_minimal_symbol_hash_tables)
3735         (minimal_symbol_reader::install): Update.
3736
3737 2019-03-15  Tom Tromey  <tom@tromey.com>
3738
3739         * symtab.c (create_demangled_names_hash): Update.
3740         (symbol_set_names): Update.
3741         * objfiles.h (struct objfile_per_bfd_storage)
3742         <demangled_names_hash>: Now an htab_up.
3743         * objfiles.c (objfile_per_bfd_storage): Simplify.
3744
3745 2019-03-15  Tom Tromey  <tom@tromey.com>
3746
3747         * objfiles.h (struct objfile_per_bfd_storage): Declare
3748         destructor.
3749         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3750         New.
3751         (get_objfile_bfd_data): Use new.  Don't initialize
3752         language_of_main.
3753         (free_objfile_per_bfd_storage): Remove.
3754         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3755
3756 2019-03-15  Tom Tromey  <tom@tromey.com>
3757
3758         * symfile.c (reread_symbols): Update.
3759         * objfiles.c (objfile::objfile): Update.
3760         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3761         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3762         comment.
3763         (minimal_symbol_reader::install): Update.
3764         (terminate_minimal_symbol_table): Remove.
3765         * jit.c (jit_object_close_impl): Update.
3766
3767 2019-03-15  Tom Tromey  <tom@tromey.com>
3768
3769         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3770         initializations.
3771
3772 2019-03-15  Tom Tromey  <tom@tromey.com>
3773
3774         * objfiles.h (struct objfile_per_bfd_storage)
3775         <demangled_hash_languages>: Now a bitset.
3776         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3777         (lookup_minimal_symbol): Update.
3778
3779 2019-03-15  Tom Tromey  <tom@tromey.com>
3780
3781         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3782         Don't return the symbol.
3783         * coffread.c (record_minimal_symbol): Use record_full.
3784
3785 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3786
3787         The MS-Windows port of ncurses fails to switch to a color pair if
3788         one or both of the colors are the implicit default colors.  This
3789         change records the default colors when TUI is initialized, and
3790         then specifies them explicitly when a color pair uses the default
3791         colors.  This allows color styling in TUI mode on MS-Windows.
3792
3793         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3794         ncurses_norm_attr.
3795         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3796         colors in ncurses_norm_attr.
3797         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3798         "none", replace it with the default color recorded in
3799         ncurses_norm_attr.
3800
3801 2019-03-14  Tom Tromey  <tromey@adacore.com>
3802
3803         * source-cache.h (class source_cache) <get_source_lines>: Return
3804         std::string.
3805         * source-cache.c (source_cache::extract_lines): Handle case where
3806         first_pos==npos.  Return std::string.
3807         (source_cache::get_source_lines): Update.
3808
3809 2019-03-14  Tom Tromey  <tromey@adacore.com>
3810
3811         * NEWS: Add item for "style sources" commands.
3812         * source-cache.c (source_cache::get_source_lines): Check
3813         source_styling.
3814         * cli/cli-style.c (source_styling): New global.
3815         (_initialize_cli_style): Add "style sources" commands.
3816         (show_style_sources): New function.
3817         * cli/cli-style.h (source_styling): Declare.
3818
3819 2019-03-14  Pedro Alves  <palves@redhat.com>
3820             Tom Tromey  <tromey@adacore.com>
3821
3822         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3823         * tui/tui-winsource.c (tui_refill_source_window): New function,
3824         from...
3825         (tui_horizontal_source_scroll): ... here.  Move some logic.
3826         * cli/cli-style.c (set_style_enabled): Notify new observable.
3827         * tui/tui-hooks.c (tui_redisplay_source): New function.
3828         (tui_attach_detach_observers): Attach or detach
3829         tui_redisplay_source.
3830         * observable.h (source_styling_changed): New observable.
3831         * observable.c: Define source_styling_changed observable.
3832
3833 2019-03-13  Tom Tromey  <tromey@adacore.com>
3834
3835         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3836         (i386_gnu_nat_target::store_registers): Update.
3837         * target-debug.h (target_debug_print_std_string): New macro.
3838         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3839         * windows-tdep.c (display_one_tib): Update.
3840         * tui/tui-stack.c (tui_make_status_line): Update.
3841         * top.c (print_inferior_quit_action): Update.
3842         * thread.c (thr_try_catch_cmd): Update.
3843         (add_thread_with_info): Update.
3844         (thread_target_id_str): Update.
3845         (thr_try_catch_cmd): Update.
3846         (thread_command): Update.
3847         (thread_find_command): Update.
3848         * record-btrace.c (record_btrace_target::info_record)
3849         (record_btrace_resume_thread, record_btrace_target::resume)
3850         (record_btrace_cancel_resume, record_btrace_step_thread)
3851         (record_btrace_target::wait, record_btrace_target::wait)
3852         (record_btrace_target::wait, record_btrace_target::stop): Update.
3853         * progspace.c (print_program_space): Update.
3854         * process-stratum-target.c
3855         (process_stratum_target::thread_address_space): Update.
3856         * linux-fork.c (linux_fork_mourn_inferior)
3857         (detach_checkpoint_command, info_checkpoints_command)
3858         (linux_fork_context): Update.
3859         (linux_fork_detach): Update.
3860         (class scoped_switch_fork_info): Update.
3861         (delete_checkpoint_command): Update.
3862         * infrun.c (follow_fork_inferior): Update.
3863         (follow_fork_inferior): Update.
3864         (proceed_after_vfork_done): Update.
3865         (handle_vfork_child_exec_or_exit): Update.
3866         (follow_exec): Update.
3867         (displaced_step_prepare_throw): Update.
3868         (displaced_step_restore): Update.
3869         (start_step_over): Update.
3870         (resume_1): Update.
3871         (clear_proceed_status_thread): Update.
3872         (proceed): Update.
3873         (print_target_wait_results): Update.
3874         (do_target_wait): Update.
3875         (context_switch): Update.
3876         (stop_all_threads): Update.
3877         (restart_threads): Update.
3878         (finish_step_over): Update.
3879         (handle_signal_stop): Update.
3880         (switch_back_to_stepped_thread): Update.
3881         (keep_going_pass_signal): Update.
3882         (print_exited_reason): Update.
3883         (normal_stop): Update.
3884         * inferior.c (inferior_pid_to_str): Change return type.
3885         (print_selected_inferior): Update.
3886         (add_inferior): Update.
3887         (detach_inferior): Update.
3888         * dummy-frame.c (fprint_dummy_frames): Update.
3889         * dcache.c (dcache_info_1): Update.
3890         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3891         (btrace_fetch, btrace_clear): Update.
3892         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3893         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3894         type.
3895         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3896         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3897         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3898         * gdbarch.c, gdbarch.h: Rebuild.
3899         * gdbarch.sh (core_pid_to_str): Change return type.
3900         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3901         return type.
3902         (windows_nat_target::pid_to_str): Change return type.
3903         (windows_delete_thread): Update.
3904         (windows_nat_target::attach): Update.
3905         (windows_nat_target::files_info): Update.
3906         * target-delegates.c: Rebuild.
3907         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3908         return type.
3909         (sol_thread_target::pid_to_str): Change return type.
3910         * remote.c (class remote_target) <pid_to_str>: Change return
3911         type.
3912         (remote_target::pid_to_str): Change return type.
3913         (extended_remote_target::attach, remote_target::remote_stop_ns)
3914         (remote_target::remote_notif_remove_queued_reply)
3915         (remote_target::push_stop_reply, remote_target::disable_btrace):
3916         Update.
3917         (extended_remote_target::attach): Update.
3918         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3919         type.
3920         (gdbsim_target::pid_to_str): Change return type.
3921         * ravenscar-thread.c (struct ravenscar_thread_target)
3922         <pid_to_str>: Change return type.
3923         (ravenscar_thread_target::pid_to_str): Change return type.
3924         * procfs.c (class procfs_target) <pid_to_str>: Change return
3925         type.
3926         (procfs_target::pid_to_str): Change return type.
3927         (procfs_target::attach): Update.
3928         (procfs_target::detach): Update.
3929         (procfs_target::fetch_registers): Update.
3930         (procfs_target::store_registers): Update.
3931         (procfs_target::wait): Update.
3932         (procfs_target::files_info): Update.
3933         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3934         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3935         return type.
3936         (nto_procfs_target::pid_to_str): Change return type.
3937         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3938         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3939         return type.
3940         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3941         (exit_lwp): Update.
3942         (attach_proc_task_lwp_callback, get_detach_signal)
3943         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3944         (linux_nat_target::resume, wait_lwp, stop_callback)
3945         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3946         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3947         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3948         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3949         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3950         type.
3951         (inf_ptrace_target::attach): Update.
3952         (inf_ptrace_target::files_info): Update.
3953         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3954         type.
3955         (go32_nat_target::pid_to_str): Change return type.
3956         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3957         (gnu_nat_target::wait): Update.
3958         (gnu_nat_target::wait): Update.
3959         (gnu_nat_target::resume): Update.
3960         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3961         (fbsd_nat_target::wait): Update.
3962         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3963         type.
3964         (darwin_nat_target::attach): Update.
3965         * corelow.c (class core_target) <pid_to_str>: Change return type.
3966         (core_target::pid_to_str): Change return type.
3967         * target.c (normal_pid_to_str): Change return type.
3968         (default_pid_to_str): Likewise.
3969         (target_pid_to_str): Change return type.
3970         (target_translate_tls_address): Update.
3971         (target_announce_detach): Update.
3972         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3973         return type.
3974         (bsd_uthread_target::pid_to_str): Change return type.
3975         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3976         type.
3977         (bsd_kvm_target::pid_to_str): Change return type.
3978         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3979         return type.
3980         (aix_thread_target::pid_to_str): Change return type.
3981         * target.h (struct target_ops) <pid_to_str>: Change return type.
3982         (target_pid_to_str, normal_pid_to_str): Likewise.
3983         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3984         type.
3985         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3986         type.
3987         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3988         return type.
3989         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3990         type.
3991         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3992         type.
3993         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3994         return type.
3995
3996 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3997
3998         * NEWS: Mention that the new default MI version is 3.  Mention
3999         changes to the output of commands and events that deal with
4000         multi-location breakpoints.
4001         * breakpoint.c: Include "mi/mi-out.h".
4002         (print_one_breakpoint): Change output syntax if using MI version
4003         >= 3.
4004         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4005         New.
4006         (mi_multi_location_breakpoint_output_fixed): New.
4007         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4008         (mi_cmd_fix_multi_location_breakpoint_output): New.
4009         (mi_multi_location_breakpoint_output_fixed): New.
4010         * mi/mi-cmds.c (mi_cmds): Register command
4011         -fix-multi-location-breakpoint-output.
4012         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4013         interpreter "mi".
4014
4015 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4016
4017         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4018         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4019         instantiate mi_ui_out based on interpreter name.
4020         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4021         * mi/mi-main.c (mi_load_progress): Likewise.
4022
4023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4024
4025         * NEWS: Combine separate "New targets" sections for 8.3.
4026
4027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4028
4029         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4030         (ppcfbsd_init_abi): Install gdbarch
4031         "fetch_tls_load_module_address" and "get_thread_local_address"
4032         methods.
4033
4034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4035
4036         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4037         (riscv_fbsd_init_abi): Install gdbarch
4038         "fetch_tls_load_module_address" and "get_thread_local_address"
4039         methods.
4040
4041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4042
4043         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4044         (i386fbsd_init_abi): Install gdbarch
4045         "fetch_tls_load_module_address" and "get_thread_local_address"
4046         methods.
4047
4048 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4049
4050         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4051         (amd64fbsd_init_abi): Install gdbarch
4052         "fetch_tls_load_module_address" and "get_thread_local_address"
4053         methods.
4054
4055 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4056
4057         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4058         (struct fbsd_pspace_data): New type.
4059         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4060         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4061         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4062         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4063         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4064
4065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4066
4067         * gdbtypes.c (lookup_struct_elt): New function.
4068         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4069         * gdbtypes.h (struct struct_elt): New type.
4070         (lookup_struct_elt): New prototype.
4071
4072 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4073
4074         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4075         remove disabled code block.
4076
4077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4078
4079         * gdbarch.sh (get_thread_local_address): New method.
4080         * gdbarch.h, gdbarch.c: Regenerate.
4081         * target.c (target_translate_tls_address): Use
4082         gdbarch_get_thread_local_address if present instead of
4083         target::get_thread_local_address.
4084
4085 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4086
4087         * target.h (target::get_thread_local_address): Update comment.
4088
4089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4090
4091         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4092         objfile->separate_debug_objfile_backlink if not NULL.
4093
4094 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4095
4096         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4097         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4098         (amd64bsd_store_inferior_registers): Likewise.
4099         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4100         Enable segment base registers.
4101         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4102         PT_GETFSBASE and PT_GETGSBASE.
4103         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4104         PT_SETGSBASE.
4105         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4106         segment base registers.
4107         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4108
4109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4110
4111         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4112         Update calls to i386_target_description to add 'segments'
4113         parameter.
4114         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4115         add segment base registers.
4116         * arch/i386.c (i386_create_target_description): Add 'segments'
4117         parameter to enable segment base registers.
4118         * arch/i386.h (i386_create_target_description): Likewise.
4119         * features/i386/32bit-segments.xml: New file.
4120         * features/i386/32bit-segments.c: Generate.
4121         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4122         call to i386_target_description to add 'segments' parameter.
4123         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4124         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4125         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4126         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4127         if feature is present.
4128         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4129         Add 'segments' parameter to call to i386_target_description.
4130         (i386_target_description): Add 'segments' parameter to enable
4131         segment base registers.
4132         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4133         to call to i386_target_description.
4134         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4135         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4136         Define I386_NUM_REGS.
4137         (i386_target_description): Add 'segments' parameter to enable
4138         segment base registers.
4139
4140 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4141
4142         PR/24325
4143         * source-cache.c: #undef open and close, to avoid unresolved
4144         externals during linking.
4145
4146 2019-03-12  Tom Tromey  <tromey@adacore.com>
4147
4148         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4149         const.  Add initializers.
4150         (_initialize_remote): Don't initialize ptid globals.
4151
4152 2019-03-12  Pedro Alves  <palves@redhat.com>
4153
4154         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4155
4156 2019-03-12  Pedro Alves  <palves@redhat.com>
4157
4158         * cp-name-parser.y (main): Remove unused 'len' variable.
4159
4160 2019-03-12  Tom Tromey  <tromey@adacore.com>
4161
4162         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4163         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4164
4165 2019-03-12  Tom Tromey  <tromey@adacore.com>
4166
4167         * linux-nat.c (iterate_over_lwps): Update.
4168         (stop_callback): Remove parameter.
4169         (stop_wait_callback, detach_callback, resume_set_callback)
4170         (select_singlestep_lwp_callback, set_ignore_sigint)
4171         (status_callback, resumed_callback, resume_clear_callback)
4172         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4173         data parameter.
4174         (linux_nat_target::detach, linux_nat_target::resume)
4175         (linux_stop_and_wait_all_lwps, select_event_lwp)
4176         (linux_nat_filter_event, linux_nat_wait_1)
4177         (linux_nat_target::kill, linux_nat_target::stop)
4178         (linux_nat_target::stop): Update.
4179         (linux_nat_resume_callback): Change type.
4180         (resume_stopped_resumed_lwps, count_events_callback)
4181         (select_event_lwp_callback): Likewise.
4182         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4183         * arm-linux-nat.c (struct update_registers_data): Remove.
4184         (update_registers_callback): Change type.
4185         (arm_linux_insert_hw_breakpoint1): Update.
4186         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4187         parameter.
4188         (x86_linux_dr_set_addr): Update.
4189         (x86_linux_dr_set_control): Update.
4190         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4191         (iterate_over_lwps): Use gdb::function_view.
4192         * nat/aarch64-linux-hw-point.c (struct
4193         aarch64_dr_update_callback_param): Remove.
4194         (debug_reg_change_callback): Change type.
4195         (aarch64_notify_debug_reg_change): Update.
4196         * s390-linux-nat.c (s390_refresh_per_info): Update.
4197
4198 2019-03-11  Tom Tromey  <tromey@adacore.com>
4199
4200         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4201         redundant assignment to "this_cu".
4202
4203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4204
4205         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4206
4207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4208
4209         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4210         from...
4211         (rank_one_type): ... this.
4212
4213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4214
4215         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4216         from...
4217         (rank_one_type): ... this.
4218
4219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4220
4221         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4222         from...
4223         (rank_one_type): ... this.
4224
4225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4226
4227         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4228         from...
4229         (rank_one_type): ... this.
4230
4231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4232
4233         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4234         from...
4235         (rank_one_type): ... this.
4236
4237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4238
4239         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4240         from...
4241         (rank_one_type): ... this.
4242
4243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4244
4245         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4246         from...
4247         (rank_one_type): ... this.
4248
4249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4250
4251         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4252         from...
4253         (rank_one_type): ... this.
4254
4255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4256
4257         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4258         from...
4259         (rank_one_type): ... this.
4260
4261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4262
4263         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4264         from...
4265         (rank_one_type): ... this.
4266
4267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4268
4269         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4270         from...
4271         (rank_one_type): ... this.
4272
4273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4274
4275         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4276         from...
4277         (rank_one_type): ... this.
4278
4279 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4280
4281         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4282         inferior-events' shows the example events.
4283
4284 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4285
4286         Support styling on native MS-Windows console
4287
4288         PR/24315
4289         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4290         on MS-Windows if $TERM is not defined.
4291
4292         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4293
4294         * posix-hdep.c (gdb_console_fputs):
4295         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4296         functions.
4297         * ui-file.h (gdb_console_fputs): Add prototype.
4298
4299         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4300         back to fputs only if the former returns zero.
4301
4302 2019-03-07  Tom Tromey  <tom@tromey.com>
4303
4304         * symmisc.c (print_symbol_bcache_statistics): Update.
4305         (print_objfile_statistics): Update.
4306         * symfile.c (allocate_symtab): Update.
4307         * stabsread.c: Don't include bcache.h.
4308         * psymtab.h (struct psymbol_bcache): Don't declare.
4309         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4310         (psymbol_bcache_init, psymbol_bcache_free)
4311         (psymbol_bcache_get_bcache): Don't declare.
4312         * psymtab.c (struct psymbol_bcache): Remove.
4313         (psymtab_storage::psymtab_storage): Update.
4314         (psymtab_storage::~psymtab_storage): Update.
4315         (psymbol_bcache_init, psymbol_bcache_free)
4316         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4317         (add_psymbol_to_bcache): Update.
4318         (allocate_psymtab): Update.
4319         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4320         macro_cache>: No longer pointers.
4321         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4322         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4323         * macrotab.c (macro_bcache): Update.
4324         * macroexp.c: Don't include bcache.h.
4325         * gdbtypes.c (check_types_worklist): Update.
4326         (types_deeply_equal): Remove TRY/CATCH.  Update.
4327         * elfread.c (elf_symtab_read): Update.
4328         * dwarf2read.c: Don't include bcache.h.
4329         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4330         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4331         (print_bcache_statistics, bcache_memory_used): Don't declare.
4332         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4333         methods.  Rename all data members.
4334         * bcache.c (struct bcache): Move to bcache.h.
4335         (bcache::expand_hash_table): Rename from expand_hash_table.
4336         (bcache): Remove.
4337         (bcache::insert): Rename from bcache_full.
4338         (bcache::compare): Rename from bcache_compare.
4339         (bcache_xmalloc): Remove.
4340         (bcache::~bcache): Rename from bcache_xfree.
4341         (bcache::print_statistics): Rename from print_bcache_statistics.
4342         (bcache::memory_used): Rename from bcache_memory_used.
4343
4344 2019-03-07  Pedro Alves  <palves@redhat.com>
4345
4346         * infrun.c (normal_stop): Also check for
4347         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4348
4349 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         * f-lang.c (value_from_host_double): Moved to...
4352         * value.c (value_from_host_double): ...here.
4353         * value.h (value_from_host_double): Declare.
4354         * guile/scm-math.c (vlscm_convert_typed_number): Use
4355         value_from_host_double.
4356         (vlscm_convert_number): Likewise.
4357         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4358         * python/py-value.c (convert_value_from_python): Likewise.
4359
4360 2019-03-06  Tom Tromey  <tom@tromey.com>
4361
4362         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4363
4364 2019-03-06  Tom Tromey  <tom@tromey.com>
4365
4366         * utils.h (free_current_contents): Don't declare.
4367         * utils.c (free_current_contents): Remove.
4368
4369 2019-03-06  Tom Tromey  <tom@tromey.com>
4370
4371         * top.c (quit_force): Update.
4372         * main.c (captured_command_loop): Update.
4373         * common/new-op.c (operator new): Update.
4374         * common/common-exceptions.c (struct catcher)
4375         <save_cleanup_chain>: Remove member.
4376         (exceptions_state_mc_init): Update.
4377         (exception_try_scope_entry): Return nullptr.
4378         (exception_try_scope_exit, exception_rethrow)
4379         (throw_exception_sjlj, throw_exception_cxx): Update.
4380         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4381         (all_cleanups, do_cleanups, discard_cleanups)
4382         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4383         (restore_cleanups, restore_final_cleanups): Don't declare.
4384         (do_final_cleanups): Remove parameter.
4385         * common/cleanups.c (cleanup_chain, make_cleanup)
4386         (make_cleanup_dtor, all_cleanups, do_cleanups)
4387         (discard_my_cleanups, discard_cleanups)
4388         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4389         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4390         (null_cleanup): Remove.
4391         (do_final_cleanups): Remove parameter.
4392
4393 2019-03-06  Tom Tromey  <tom@tromey.com>
4394
4395         * remote.c (remote_target::remote_parse_stop_reply): Use
4396         unique_xmalloc_ptr.
4397
4398 2019-03-06  Tom Tromey  <tom@tromey.com>
4399
4400         * stabsread.c (struct stabs_field_info): Rename from field_info.
4401         <list, fnlist>: Add initializers.
4402         <obstack>: New member.
4403         (read_member_functions, read_struct_fields, read_baseclasses):
4404         Allocate on obstack.  Don't use cleanups.
4405         (read_one_struct_field, read_member_functions, read_struct_fields)
4406         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4407         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4408         (read_struct_type): Update.
4409
4410 2019-03-06  Tom Tromey  <tom@tromey.com>
4411
4412         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4413         * common/filestuff.h (make_cleanup_close): Don't declare.
4414         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4415         Remove.
4416
4417 2019-03-06  Tom Tromey  <tom@tromey.com>
4418
4419         * solib-aix.c: Use make_scope_exit.
4420
4421 2019-03-06  Tom Tromey  <tom@tromey.com>
4422
4423         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4424         Use make_scope_exit.
4425
4426 2019-03-06  Tom Tromey  <tom@tromey.com>
4427
4428         * solib-svr4.c (disable_probes_interface): Remove parameter.
4429         (svr4_handle_solib_event): Use make_scope_exit.
4430
4431 2019-03-06  Tom Tromey  <tom@tromey.com>
4432
4433         * remote.c (struct stop_reply_deleter): Remove.
4434         (stop_reply_up): Update.
4435         (struct stop_reply): Derive from notif_event.  Don't typedef.
4436         <regcache>: Now a std::vector.
4437         (stop_reply_xfree): Remove.
4438         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4439         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4440         (remote_target::discard_pending_stop_replies): Use delete.
4441         (remote_target::remote_parse_stop_reply): Update.
4442         (remote_target::process_stop_reply): Update.
4443         * remote-notif.h (struct notif_event): Add virtual destructor.
4444         Remove "dtr" member.
4445         (struct notif_client) <alloc_event>: Return a unique_ptr.
4446         (notif_event_xfree): Don't declare.
4447         (notif_event_up): New typedef.
4448         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4449         (notif_event_xfree, do_notif_event_xfree): Remove.
4450         (remote_notif_state_xfree): Update.
4451
4452 2019-03-06  Tom Tromey  <tom@tromey.com>
4453
4454         * infrun.c (displaced_step_clear_cleanup): Now a
4455         forward_scope_exit type.
4456         (displaced_step_prepare_throw): Update.
4457         (displaced_step_fixup): Update.
4458
4459 2019-03-06  Tom Tromey  <tom@tromey.com>
4460
4461         * inferior.h (class inferior): Update comment.
4462         * gdbthread.h (class thread_info): Update comment.
4463
4464 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4465             Tom Tromey  <tom@tromey.com>
4466
4467         * stabsread.h (struct stab_section_list): Remove.
4468         (coffstab_build_psymtabs): Update.
4469         * dbxread.c (symbuf_sections): Now a std::vector.
4470         (sect_idx): New global.
4471         (fill_symbuf): Update.
4472         (coffstab_build_psymtabs): Change type of stabsects parameter.
4473         Update.
4474         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4475         std::vector.
4476         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4477         (coff_locate_sections): Update.
4478         (coff_symfile_read): Remove cleanups.  Update.
4479         (init_stringtab): Add storage parameter.
4480         (free_stringtab, free_stringtab_cleanup): Remove.
4481         (init_lineno): Add storage parameter.
4482         (free_linetab, free_linetab_cleanup): Remove.
4483
4484 2019-03-06  Pedro Alves  <palves@redhat.com>
4485
4486         * linux-fork.c (fork_info::clobber_regs): Delete.
4487         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4488         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4489         comment.  Adjust.
4490         (scoped_switch_fork_info::scoped_switch_fork_info)
4491         (checkpoint_command, linux_fork_context): Adjust
4492         fork_save_infrun_state calls.
4493
4494 2019-03-06  Pedro Alves  <palves@redhat.com>
4495
4496         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4497         (inf_has_multiple_threads): Return 'bool' and rewrite using
4498         inferior_info::threads().
4499
4500 2019-03-06  Pedro Alves  <palves@redhat.com>
4501
4502         * linux-fork.c: Include <list>.
4503         (fork_list): Now a std::list instance.
4504         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4505         (forks_exist_p, find_last_fork): Adjust.
4506         (new_fork): Delete.
4507         (one_fork_p): New.
4508         (add_fork): Adjust.
4509         (free_fork): Delete, folded into fork_info::~fork_info().
4510         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4511         Adjust.
4512         (init_fork_list): Delete.
4513         (linux_fork_killall, linux_fork_mourn_inferior)
4514         (linux_fork_detach, info_checkpoints_command): Adjust.
4515         (_initialize_linux_fork): No longer call init_fork_list.
4516
4517 2019-03-06  Pedro Alves  <palves@redhat.com>
4518
4519         * linux-fork.c (new_fork): New, split out of ...
4520         (add_fork): ... this.  Return void.  Move "first fork" special
4521         case from here, to ...
4522         (checkpoint_command): ... here.
4523         * linux-linux.h (add_fork): Return void.
4524
4525 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4528
4529 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4530             Chris January  <chris.january@arm.com>
4531             David Lecomber  <david.lecomber@arm.com>
4532
4533         * f-exp.y: New token, UNOP_INTRINSIC.
4534         (exp): New pattern using UNOP_INTRINSIC token.
4535         (f77_keywords): Add 'abs' keyword.
4536         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4537         (value_from_host_double): New function.
4538         (evaluate_subexp_f): Support UNOP_ABS.
4539
4540 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4541
4542         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4543         types.
4544
4545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4548         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4549         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4550
4551 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4552
4553         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4554
4555 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4556             Chris January  <chris.january@arm.com>
4557
4558         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4559         * f-exp.y: Define 'KIND' token.
4560         (exp): New pattern for KIND expressions.
4561         (ptype): Handle types with a kind extension.
4562         (direct_abs_decl): Extend to spot kind extensions.
4563         (f77_keywords): Add 'kind' to the list.
4564         (push_kind_type): New function.
4565         (convert_to_kind_type): New function.
4566         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4567         * parse.c (operator_length_standard): Likewise.
4568         * parser-defs.h (enum type_pieces): Add tp_kind.
4569         * std-operator.def: Add UNOP_KIND.
4570
4571 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * f-exp.y (f_parse): Set yydebug.
4574
4575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4576
4577         * f-lang.c (evaluate_subexp_f): New function.
4578         (exp_descriptor_f): New global.
4579         (f_language_defn): Use exp_descriptor_f instead of
4580         exp_descriptor_standard.
4581
4582 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4583
4584         * f-exp.y (struct token): Add comments.
4585         (dot_ops): Remove uppercase versions and the end marker.
4586         (f77_keywords): Likewise.
4587         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4588         entries in the dot_ops array are case insensitive, and use
4589         strncasecmp to compare strings.  Also some whitespace cleanup in
4590         this area.  Similar for the f77_keywords array, except entries in
4591         this list might be case sensitive.
4592
4593 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * f-exp.y (struct f77_boolean_val): Add comments.
4596         (boolean_values): Remove uppercase versions, and end marker.
4597         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4598         and use strncasecmp to achieve case insensitivity.  Additionally,
4599         perform whitespace cleanup around this code.
4600
4601 2019-03-06  Tom Tromey  <tromey@adacore.com>
4602
4603         * remote-sim.c (gdbsim_target_open): Use result of
4604         gdb_argv::release.
4605
4606 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4607         Dirk Schubert  <dirk.schubert@arm.com>
4608         Chris January  <chris.january@arm.com>
4609
4610         * eval.c (evaluate_subexp_standard): Call Fortran argument
4611         wrapping logic.
4612         * f-lang.c (struct value): A value which can be passed into a
4613         Fortran function call.
4614         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4615         where appropriate.
4616         (struct type): Value ready for a Fortran function call.
4617         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4618         is needed.
4619         * f-lang.h (fortran_argument_convert): Declaration.
4620         (fortran_preserve_arg_pointer): Declaration.
4621         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4622
4623 2019-03-05  Tom Tromey  <tromey@adacore.com>
4624
4625         * python/py-prettyprint.c (print_string_repr): Remove #if.
4626         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4627
4628 2019-03-05  Tom Tromey  <tromey@adacore.com>
4629
4630         * target.c (the_dummy_target): Move later.  Change type to
4631         "dummy_target".
4632         (initialize_targets): Don't initialize the_dummy_target.
4633
4634 2019-03-05  Tom Tromey  <tromey@adacore.com>
4635
4636         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4637         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4638
4639 2019-03-05  Tom Tromey  <tromey@adacore.com>
4640
4641         * windows-nat.c (windows_nat_target::attach)
4642         (windows_nat_target::detach): Don't call gdb_flush.
4643         * valprint.c (generic_val_print, val_print, val_print_string):
4644         Don't call gdb_flush.
4645         * utils.c (defaulted_query): Don't call gdb_flush.
4646         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4647         * target.c (target_announce_detach): Don't call gdb_flush.
4648         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4649         * remote.c (extended_remote_target::attach): Don't call
4650         gdb_flush.
4651         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4652         * printcmd.c (do_examine): Don't call gdb_flush.
4653         (info_display_command): Don't call gdb_flush.
4654         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4655         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4656         * memattr.c (info_mem_command): Don't call gdb_flush.
4657         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4658         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4659         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4660         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4661         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4662         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4663         (gnu_nat_target::detach): Don't call gdb_flush.
4664         * f-valprint.c (f_val_print): Don't call gdb_flush.
4665         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4666         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4667         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4668         gdb_flush.
4669         * c-valprint.c (c_val_print): Don't call gdb_flush.
4670         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4671
4672 2019-03-05  Tom Tromey  <tromey@adacore.com>
4673
4674         * varobj.c (update_dynamic_varobj_children): Update.
4675         (install_default_visualizer): Use reset, not release.
4676         * value.c (set_internalvar): Update.
4677         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4678         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4679         ATTRIBUTE_UNUSED_RESULT.
4680
4681 2019-03-05  Tom Tromey  <tromey@adacore.com>
4682
4683         * remote.c (class scoped_remote_fd) <release>: Add
4684         ATTRIBUTE_UNUSED_RESULT.
4685
4686 2019-03-05  Tom Tromey  <tromey@adacore.com>
4687
4688         * macroexp.c (struct macro_buffer) <release>: Add
4689         ATTRIBUTE_UNUSED_RESULT.
4690
4691 2019-03-05  Tom Tromey  <tromey@adacore.com>
4692
4693         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4694         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4695         ATTRIBUTE_UNUSED_RESULT.
4696
4697 2019-03-05  Tom Tromey  <tromey@adacore.com>
4698
4699         * common/scoped_fd.h (class scoped_fd) <release>: Add
4700         ATTRIBUTE_UNUSED_RESULT.
4701
4702 2019-03-05  Tom Tromey  <tromey@adacore.com>
4703
4704         * parser-defs.h (struct parser_state) <release>: Add
4705         ATTRIBUTE_UNUSED_RESULT.
4706
4707 2019-03-05  Tom Tromey  <tromey@adacore.com>
4708
4709         * utils.h (class gdb_argv) <release>: Add
4710         ATTRIBUTE_UNUSED_RESULT.
4711         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4712
4713 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4714
4715         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4716         for-loop range, to avoid compiler warnings.
4717
4718         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4719         avoid compiler warnings about unused variables.
4720
4721         * NEWS: Mention end of support for native debugging on MS-Windows
4722         before XP.
4723
4724         PR gdb/24292
4725         * common/netstuff.c:
4726         * gdbserver/gdbreplay.c
4727         * gdbserver/remote-utils.c:
4728         * ser-tcp.c:
4729         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4730         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4731         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4732         'getaddrinfo' and 'freeaddrinfo' were not available before
4733         Windows XP, and mingw.org's MinGW headers by default define
4734         _WIN32_WINNT to 0x500.
4735
4736 2019-03-01  Gary Benson <gbenson@redhat.com>
4737
4738         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4739
4740 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4741             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4742
4743         PR gdb/8527
4744         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4745         set_sigint_trap, clear_sigint_trap.
4746
4747 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4748
4749         * target.c (target_detach): Clear the regcache and the
4750         frame cache.
4751
4752 2019-02-27  Pedro Alves  <palves@redhat.com>
4753
4754         * utils.c (set_screen_size): When we cap the height/width sizes,
4755         tweak the corresponding command variable to show "unlimited":
4756
4757 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4758             Pedro Alves  <palves@redhat.com>
4759
4760         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4761         before calling rl_set_screen_size.
4762
4763 2019-02-27  Tom Tromey  <tromey@adacore.com>
4764
4765         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4766         define.
4767         * python/py-value.c: Remove Python 2.4 workaround.
4768         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4769         workaround.
4770         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4771         Python 2.4 workaround.
4772         * python/python-internal.h: Remove Python 2.4 comment.
4773         (Py_ssize_t): Don't define.
4774         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4775         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4776         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4777         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4778         * python/python.c (do_start_initialization): Remove Python 2.4
4779         workaround.
4780         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4781         (print_children): Remove Python 2.4 workaround.
4782         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4783         workaround.
4784         (CHARBUFFERPROC_NAME): Remove.
4785         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4786         Python 2.4 workaround.
4787
4788 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4789
4790         * NEWS: Note minimum Python version.
4791
4792 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4793
4794         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4795         code from these functions.  Remove corresponding ifdefs.  Use
4796         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4797         Remove gotos and target of gotos.
4798         (infpy_search_memory): Likewise.
4799
4800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4801
4802         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4803         (hppa_gdbarch_init): Don't register deleted functions with
4804         gdbarch.
4805
4806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4807
4808         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4809         (h8300_unwind_sp): Delete.
4810         (h8300_dummy_id): Delete.
4811         (h8300_gdbarch_init): Don't register deleted functions with
4812         gdbarch.
4813
4814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4815
4816         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4817         (ft32_unwind_pc): Delete.
4818         (ft32_unwind_sp): Delete.
4819         (ft32_gdbarch_init): Don't register deleted functions with
4820         gdbarch.
4821
4822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4825         (frv_unwind_pc): Delete.
4826         (frv_unwind_sp): Delete.
4827         (frv_gdbarch_init): Don't register deleted functions with
4828         gdbarch.
4829
4830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4831
4832         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4833         (riscv_unwind_pc): Delete.
4834         (riscv_unwind_sp): Delete.
4835         (riscv_gdbarch_init): Don't register deleted functions with
4836         gdbarch.
4837
4838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4841         (csky_unwind_pc): Delete.
4842         (csky_unwind_sp): Delete.
4843         (csky_gdbarch_init): Don't register deleted functions with
4844         gdbarch.
4845
4846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4849         (cris_unwind_pc): Delete.
4850         (cris_unwind_sp): Delete.
4851         (cris_gdbarch_init): Don't register deleted functions with
4852         gdbarch.
4853
4854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4857         (bfin_unwind_pc): Delete.
4858         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4859
4860 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4863         (arm_unwind_pc): Delete.
4864         (arm_unwind_sp): Delete.
4865         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4866
4867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4868
4869         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4870         (arc_unwind_pc): Delete.
4871         (arc_unwind_sp): Delete.
4872         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4873
4874 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4875
4876         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4877         (alpha_unwind_pc): Delete.
4878         (alpha_gdbarch_init): Don't register deleted functions with
4879         gdbarch.
4880
4881 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4882
4883         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4884         (aarch64_unwind_pc): Delete.
4885         (aarch64_unwind_sp): Delete.
4886         (aarch64_gdbarch_init): Don't register deleted functions with
4887         gdbarch.
4888
4889 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4890
4891         * gdbtypes.c (type_align): Don't consider static members when
4892         computing structure alignment.
4893
4894 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4895
4896         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4897         return 0 for other types.
4898         * arch-utils.c (default_type_align): Always return 0.
4899         * gdbarch.h: Regenerate.
4900         * gdbarch.sh (type_align): Extend comment.
4901         * gdbtypes.c (type_align): Add additional comments, always call
4902         gdbarch_type_align before applying the default rules.
4903         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4904         generic code will then apply a suitable default.
4905         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4906         types, return 0 for other types.
4907
4908 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4909
4910         * NEWS: Create a new section for the next release branch.
4911         Rename the section of the current branch, now that it has
4912         been cut.
4913
4914 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4915
4916         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4917         * version.in: Bump version to 8.3.50.DATE-git.
4918
4919 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4920
4921         * aix-thread.c (ptid_cmp): Remove unused variable.
4922         (get_signaled_thread): Likewise.
4923         (store_regs_user_thread): Likewise.
4924         (store_regs_kernel_thread): Likewise.
4925         (fetch_regs_kernel_thread): Remove shadowed variable.
4926
4927 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * features/riscv/32bit-cpu.xml: Add register numbers.
4930         * features/riscv/32bit-fpu.c: Regenerate.
4931         * features/riscv/32bit-fpu.xml: Add register numbers.
4932         * features/riscv/64bit-cpu.xml: Add register numbers.
4933         * features/riscv/64bit-fpu.c: Regenerate.
4934         * features/riscv/64bit-fpu.xml: Add register numbers.
4935
4936 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4937
4938         * NEWS: Mention two argument form of gdb.Value constructor.
4939         * python/py-value.c (convert_buffer_and_type_to_value): New
4940         function.
4941         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4942         Add support for handling an optional second argument.  Call
4943         convert_buffer_and_type_to_value as appropriate.
4944         * python/python-internal.h (Py_buffer_deleter): New struct.
4945         (Py_buffer_up): New typedef.
4946
4947 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4948
4949         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4950         instead of releasing ownership.
4951
4952 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4953
4954         * dwarf2read.c (open_and_init_dwp_file): Call
4955         elf_numsections instead of bfd_count_sections to initialize
4956         dwp_file->num_sections.
4957
4958 2019-02-25  Tom Tromey  <tromey@adacore.com>
4959
4960         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4961
4962 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4963
4964         * gcore.in: Add '--readnever' option when invoking GDB.
4965
4966 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4967
4968         * MAINTAINERS: Update my email address.
4969
4970 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4971
4972         * build-id.c (build_id_to_debug_bfd_1): New function.
4973         (build_id_to_debug_bfd): Look for separate debug file in
4974         sysroot.
4975
4976 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4977
4978         * gdbarch.sh: Update the copyright year range that is placed into
4979         generated files.
4980
4981 2019-02-22  Keith Seitz  <keiths@redhat.com>
4982
4983         PR symtab/23853
4984         * linespec.c (create_sals_line_offset): Search for the default
4985         symtab's filename instead of its fullname.
4986
4987 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4988
4989         * NEWS: Update style defaults.
4990
4991 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4992
4993         * main.c (captured_main_1): Disable styling in batch mode.
4994
4995 2019-02-20  Tom Tromey  <tom@tromey.com>
4996
4997         * symtab.c (symtab_symbol_info): Fix typos.
4998
4999 2019-02-20  Tom Tromey  <tromey@adacore.com>
5000
5001         * findcmd.c (_initialize_mem_search): Use upper case for
5002         metasyntactic variables.
5003
5004 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5005
5006         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5007         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5008
5009 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5010
5011         * top.h (source_file_name): Change to std::string.
5012         * top.c (source_file_name): Likewise.
5013         (command_line_input): Adjust.
5014         * cli/cli-script.c (script_from_file): Adjust.
5015
5016 2019-02-19  Tom Tromey  <tromey@adacore.com>
5017
5018         * ravenscar-thread.c
5019         (ravenscar_thread_target::update_thread_list): Don't call
5020         ada_build_task_list.
5021         * ada-lang.h (ada_build_task_list): Don't declare.
5022         * ada-tasks.c (struct ada_tasks_inferior_data)
5023         <task_list_valid_p>: Now bool.
5024         (read_known_tasks, ada_task_list_changed)
5025         (ada_tasks_invalidate_inferior_data): Update.
5026         (read_known_tasks_array): Return bool.
5027         (read_known_tasks_list): Likewise.
5028         (read_known_tasks): Return void.
5029         (ada_build_task_list): Now static.
5030
5031 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5032
5033         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5034         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5035
5036 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5037
5038         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5039         variant for ada_tasks_pspace_data_handle and
5040         ada_tasks_inferior_data_handle.
5041         (ada_tasks_pspace_data_cleanup): New function.
5042         (ada_tasks_inferior_data_cleanup): New function.
5043
5044 2019-02-17  Tom Tromey  <tom@tromey.com>
5045
5046         * macrotab.h (macro_source_fullname): Return a std::string.
5047         * macrotab.c (macro_include, check_for_redefinition)
5048         (macro_undef, macro_lookup_definition, foreach_macro)
5049         (foreach_macro_in_scope): Update.
5050         (macro_source_fullname): Return a std::string.
5051         * macrocmd.c (show_pp_source_pos): Update.
5052
5053 2019-02-17  Tom Tromey  <tom@tromey.com>
5054
5055         * macrocmd.c (show_pp_source_pos): Style the file names.
5056
5057 2019-02-17  Tom Tromey  <tom@tromey.com>
5058
5059         PR tui/24197:
5060         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5061
5062 2019-02-17  Tom Tromey  <tom@tromey.com>
5063
5064         * ada-lang.c (user_select_syms): Use filtered printing.
5065         * utils.c (wrap_style): New global.
5066         (desired_style): Remove.
5067         (emit_style_escape): Add stream parameter.
5068         (set_output_style, reset_terminal_style, prompt_for_continue):
5069         Update.
5070         (flush_wrap_buffer): Only flush gdb_stdout.
5071         (wrap_here): Set wrap_style.
5072         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5073         treat escape sequences as a character.  Change when wrap buffer is
5074         flushed.
5075         (fputs_styled): Do not set the output style when the default is
5076         requested.
5077         * ui-style.h (struct ui_file_style) <is_default>: New method.
5078         * source.c (print_source_lines_base): Emit escape sequences in one
5079         piece.
5080
5081 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5082
5083         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5084         integers and enumeration types.
5085
5086 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5087
5088         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5089         instead of lookup_symbol_in_language
5090         (do_exact_match): New function.
5091         (ada_get_symbol_name_matcher): Return do_exact_match when
5092         doing a verbatim match.
5093
5094 2019-02-15  Tom Tromey  <tromey@adacore.com>
5095
5096         * ravenscar-thread.c (ravenscar_thread_target::resume)
5097         (ravenscar_thread_target::wait): Special case wildcard requests.
5098
5099 2019-02-15  Tom Tromey  <tromey@adacore.com>
5100
5101         * ravenscar-thread.c (base_ptid): Remove.
5102         (struct ravenscar_thread_target) <close>: New method.
5103         <m_base_ptid>: New member.
5104         <update_inferior_ptid, active_task, task_is_currently_active,
5105         runtime_initialized>: Declare methods.
5106         <ravenscar_thread_target>: Add constructor.
5107         (ravenscar_thread_target::task_is_currently_active)
5108         (ravenscar_thread_target::update_inferior_ptid)
5109         (ravenscar_runtime_initialized): Rename.  Now methods.
5110         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5111         (ravenscar_thread_target::update_thread_list): Update.
5112         (ravenscar_thread_target::active_task): Now method.
5113         (ravenscar_thread_target::store_registers)
5114         (ravenscar_thread_target::prepare_to_store)
5115         (ravenscar_thread_target::prepare_to_store)
5116         (ravenscar_thread_target::mourn_inferior): Update.
5117         (ravenscar_inferior_created): Use "new" to create target.
5118         (ravenscar_thread_target::get_ada_task_ptid): Update.
5119         (_initialize_ravenscar): Don't initialize base_ptid.
5120         (ravenscar_ops): Remove global.
5121
5122 2019-02-15  Tom Tromey  <tromey@adacore.com>
5123
5124         * target.h (push_target): Declare new overload.
5125         * target.c (push_target): New overload, taking an rvalue reference.
5126         * remote.c (remote_target::open_1): Use push_target overload.
5127         * corelow.c (core_target_open): Use push_target overload.
5128
5129 2019-02-15  Tom Tromey  <tromey@adacore.com>
5130
5131         * ravenscar-thread.c (is_ravenscar_task)
5132         (ravenscar_task_is_currently_active): Return bool.
5133         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5134         (_initialize_ravenscar): Remove "(void)".
5135         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5136         Return bool.
5137
5138 2019-02-15  Tom Tromey  <tromey@adacore.com>
5139
5140         * ravenscar-thread.c (ravenscar_runtime_initializer)
5141         (has_ravenscar_runtime, get_running_thread_id)
5142         (ravenscar_thread_target::resume): Fix indentation.
5143
5144 2019-02-15  Tom Tromey  <tromey@adacore.com>
5145
5146         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5147         from ravenscar_arch_ops.
5148         (sparc_ravenscar_ops::fetch_registers)
5149         (sparc_ravenscar_ops::store_registers): Now methods.
5150         (sparc_ravenscar_prepare_to_store): Remove.
5151         (sparc_ravenscar_ops): Redefine.
5152         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5153         methods and destructor.  Remove members.
5154         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5155         (ravenscar_thread_target::store_registers)
5156         (ravenscar_thread_target::prepare_to_store): Update.
5157         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5158         Remove.
5159         (struct ppc_ravenscar_powerpc_ops): Derive from
5160         ravenscar_arch_ops.
5161         (ppc_ravenscar_powerpc_ops::fetch_registers)
5162         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5163         (ppc_ravenscar_powerpc_ops): Redefine.
5164         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5165         (ppc_ravenscar_e500_ops::fetch_registers)
5166         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5167         (ppc_ravenscar_e500_ops): Redefine.
5168         * aarch64-ravenscar-thread.c
5169         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5170         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5171         (aarch64_ravenscar_fetch_registers)
5172         (aarch64_ravenscar_store_registers): Now methods.
5173         (aarch64_ravenscar_ops): Redefine.
5174
5175 2019-02-15  Tom Tromey  <tromey@adacore.com>
5176
5177         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5178         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5179         (ravenscar_thread_target::stopped_by_watchpoint)
5180         (ravenscar_thread_target::stopped_data_address)
5181         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5182
5183 2019-02-15  Tom Tromey  <tromey@adacore.com>
5184
5185         * ravenscar-thread.c: Fix some typos.
5186
5187 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5188             Tom Tromey  <tromey@adacore.com>
5189
5190         * ada-lang.c (ada_exception_sal): Change addr_string to a
5191         std::string.
5192         (create_ada_exception_catchpoint): Update.
5193
5194 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5195             Tom Tromey  <tromey@adacore.com>
5196
5197         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5198         (bp_location_ops): Remove.
5199         (base_breakpoint_allocate_location): Update.
5200         (free_bp_location): Update.
5201         * ada-lang.c (class ada_catchpoint_location)
5202         <ada_catchpoint_location>: Remove ops parameter.
5203         (ada_catchpoint_location_dtor): Remove.
5204         (ada_catchpoint_location_ops): Remove.
5205         (allocate_location_exception): Update.
5206         * breakpoint.h (struct bp_location_ops): Remove.
5207         (class bp_location) <bp_location>: Remove bp_location_ops
5208         parameter.
5209         <~bp_location>: Add destructor.
5210         <ops>: Remove.
5211
5212 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5213             Pedro Alves  <palves@redhat.com>
5214
5215         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5216         'PATH_MAX'.
5217
5218 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5219             Samuel Thibault  <samuel.thibault@gnu.org>
5220             Thomas Schwinge  <thomas@codesourcery.com>
5221
5222         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5223         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5224
5225 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5226
5227         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5228         (check_empty): Use "const char *".
5229
5230         * gnu-nat.c (gnu_nat_target::detach): Instead of
5231         'detach_inferior (pid)' call
5232         'detach_inferior (find_inferior_pid (pid))'.
5233
5234         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5235         'nat/fork-inferior.o'.
5236         * gnu-nat.c: #include "nat/fork-inferior.h".
5237
5238         * gnu-nat.c (gnu_nat_target::detach): Instead of
5239         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5240         * gnu-nat.h: #include "inf-child.h".
5241         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5242         'i386_gnu_nat_target::fetch_registers'.
5243         (gnu_store_registers): Rename/move to
5244         'i386_gnu_nat_target::store_registers'.
5245
5246         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5247         * gnu-nat.h (mach_thread_info): New function.
5248         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5249
5250         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5251
5252 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5253
5254         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5255
5256 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5257
5258         * windows-nat.c (windows_add_thread): Add new parameter
5259         "main_thread_p" with default value set to false.  Update
5260         function documentation as well as all callers.
5261         (windows_delete_thread): Likewise.
5262         (fake_create_process): Update call to windows_add_thread.
5263         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5264         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5265         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5266         call to windows_delete_thread.
5267
5268 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5269
5270         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5271
5272 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5273
5274         * symfile.c (find_separate_debug_file): Use canonical path of
5275         sysroot with child_path instead of gdb_sysroot if it is valid.
5276
5277 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5278
5279         * symfile.c (find_separate_debug_file): Use child_path to
5280         determine if an object file is under a sysroot.
5281
5282 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5283
5284         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5285         unittests/child-path-selftests.c.
5286         * common/pathstuff.c (child_path): New function.
5287         * common/pathstuff.h (child_path): New prototype.
5288         * unittests/child-path-selftests.c: New file.
5289
5290 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5291
5292         * symfile.c (find_separate_debug_file): Look for separate debug
5293         files in debug directories under the sysroot.
5294
5295 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5296
5297         * symtab.h (struct minimal_symbol data_p): New const method.
5298         (struct minimal_symbol text_p): Likewise.
5299         * symtab.c (output_source_filename): Use file name style
5300         to print file name.
5301         (print_symbol_info): Likewise.
5302         (print_msymbol_info): Use address style to print addresses.
5303         Use function name style to print executable text symbols.
5304         (expand_symtab_containing_pc): Use data_p.
5305         (find_pc_sect_compunit_symtab): Likewise.
5306
5307 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5308
5309         * breakpoint.c (describe_other_breakpoints): Use address style
5310         to print addresses.
5311         (say_where): Likewise.
5312
5313 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5314
5315         * ada-typeprint.c (print_func_type): Print function name
5316         style to print function name.
5317         * c-typeprint.c (c_print_type_1): Likewise.
5318
5319 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5320
5321         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5322         for execve.
5323
5324 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5325
5326         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5327         type_stack.
5328
5329 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5330
5331         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5332         TYPE_CODE_REF types.
5333
5334 2019-02-08  Jim Wilson  <jimw@sifive.com>
5335
5336         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5337         (riscv_linux_fregset): New.
5338         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5339
5340 2019-02-07  Tom Tromey  <tom@tromey.com>
5341
5342         * thread.c (thread_cancel_execution_command): Update.
5343         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5344         methods.
5345         (struct thread_fsm_ops): Remove.
5346         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5347         (thread_fsm_should_stop, thread_fsm_return_value)
5348         (thread_fsm_set_finished, thread_fsm_finished_p)
5349         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5350         Don't declare.
5351         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5352         * infrun.c (clear_proceed_status_thread)
5353         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5354         (print_stop_event): Update.
5355         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5356         Add constructor.
5357         (step_command_fsm_ops): Remove.
5358         (new_step_command_fsm): Remove.
5359         (step_1): Update.
5360         (step_command_fsm::should_stop): Rename from
5361         step_command_fsm_should_stop.
5362         (step_command_fsm::clean_up): Rename from
5363         step_command_fsm_clean_up.
5364         (step_command_fsm::do_async_reply_reason): Rename from
5365         step_command_fsm_async_reply_reason.
5366         (struct until_next_fsm): Inherit from thread_fsm.  Add
5367         constructor.
5368         (until_next_fsm_ops): Remove.
5369         (new_until_next_fsm): Remove.
5370         (until_next_fsm::should_stop): Rename from
5371         until_next_fsm_should_stop.
5372         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5373         (until_next_fsm::do_async_reply_reason): Rename from
5374         until_next_fsm_async_reply_reason.
5375         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5376         constructor.  Change type of breakpoint.
5377         (finish_command_fsm_ops): Remove.
5378         (new_finish_command_fsm): Remove.
5379         (finish_command_fsm::should_stop): Rename from
5380         finish_command_fsm_should_stop.
5381         (finish_command_fsm::clean_up): Rename from
5382         finish_command_fsm_clean_up.
5383         (finish_command_fsm::return_value): Rename from
5384         finish_command_fsm_return_value.
5385         (finish_command_fsm::do_async_reply_reason): Rename from
5386         finish_command_fsm_async_reply_reason.
5387         (finish_command): Update.
5388         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5389         Add constructor.
5390         (call_thread_fsm_ops): Remove.
5391         (call_thread_fsm::call_thread_fsm): Rename from
5392         new_call_thread_fsm.
5393         (call_thread_fsm::should_stop): Rename from
5394         call_thread_fsm_should_stop.
5395         (call_thread_fsm::should_notify_stop): Rename from
5396         call_thread_fsm_should_notify_stop.
5397         (run_inferior_call, call_function_by_hand_dummy): Update.
5398         * cli/cli-interp.c (should_print_stop_to_console): Update.
5399         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5400         Add constructor.  Change type of location_breakpoint,
5401         caller_breakpoint.
5402         (until_break_fsm_ops): Remove.
5403         (new_until_break_fsm): Remove.
5404         (until_break_fsm::should_stop): Rename from
5405         until_break_fsm_should_stop.
5406         (until_break_fsm::clean_up): Rename from
5407         until_break_fsm_clean_up.
5408         (until_break_fsm::do_async_reply_reason): Rename from
5409         until_break_fsm_async_reply_reason.
5410         (until_break_command): Update.
5411         * thread-fsm.c: Remove.
5412         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5413
5414 2019-02-07  Tom Tromey  <tom@tromey.com>
5415
5416         * yy-remap.h: Add include guard.
5417         * xtensa-tdep.h: Add include guard.
5418         * xcoffread.h: Rename include guard.
5419         * varobj-iter.h: Add include guard.
5420         * tui/tui.h: Rename include guard.
5421         * tui/tui-winsource.h: Rename include guard.
5422         * tui/tui-wingeneral.h: Rename include guard.
5423         * tui/tui-windata.h: Rename include guard.
5424         * tui/tui-win.h: Rename include guard.
5425         * tui/tui-stack.h: Rename include guard.
5426         * tui/tui-source.h: Rename include guard.
5427         * tui/tui-regs.h: Rename include guard.
5428         * tui/tui-out.h: Rename include guard.
5429         * tui/tui-layout.h: Rename include guard.
5430         * tui/tui-io.h: Rename include guard.
5431         * tui/tui-hooks.h: Rename include guard.
5432         * tui/tui-file.h: Rename include guard.
5433         * tui/tui-disasm.h: Rename include guard.
5434         * tui/tui-data.h: Rename include guard.
5435         * tui/tui-command.h: Rename include guard.
5436         * tic6x-tdep.h: Add include guard.
5437         * target/waitstatus.h: Rename include guard.
5438         * target/wait.h: Rename include guard.
5439         * target/target.h: Rename include guard.
5440         * target/resume.h: Rename include guard.
5441         * target-float.h: Rename include guard.
5442         * stabsread.h: Add include guard.
5443         * rs6000-tdep.h: Add include guard.
5444         * riscv-fbsd-tdep.h: Add include guard.
5445         * regformats/regdef.h: Rename include guard.
5446         * record.h: Rename include guard.
5447         * python/python.h: Rename include guard.
5448         * python/python-internal.h: Rename include guard.
5449         * python/py-stopevent.h: Rename include guard.
5450         * python/py-ref.h: Rename include guard.
5451         * python/py-record.h: Rename include guard.
5452         * python/py-record-full.h: Rename include guard.
5453         * python/py-record-btrace.h: Rename include guard.
5454         * python/py-instruction.h: Rename include guard.
5455         * python/py-events.h: Rename include guard.
5456         * python/py-event.h: Rename include guard.
5457         * procfs.h: Add include guard.
5458         * proc-utils.h: Add include guard.
5459         * p-lang.h: Add include guard.
5460         * or1k-tdep.h: Rename include guard.
5461         * observable.h: Rename include guard.
5462         * nto-tdep.h: Rename include guard.
5463         * nat/x86-linux.h: Rename include guard.
5464         * nat/x86-linux-dregs.h: Rename include guard.
5465         * nat/x86-gcc-cpuid.h: Add include guard.
5466         * nat/x86-dregs.h: Rename include guard.
5467         * nat/x86-cpuid.h: Rename include guard.
5468         * nat/ppc-linux.h: Rename include guard.
5469         * nat/mips-linux-watch.h: Rename include guard.
5470         * nat/linux-waitpid.h: Rename include guard.
5471         * nat/linux-ptrace.h: Rename include guard.
5472         * nat/linux-procfs.h: Rename include guard.
5473         * nat/linux-osdata.h: Rename include guard.
5474         * nat/linux-nat.h: Rename include guard.
5475         * nat/linux-namespaces.h: Rename include guard.
5476         * nat/linux-btrace.h: Rename include guard.
5477         * nat/glibc_thread_db.h: Rename include guard.
5478         * nat/gdb_thread_db.h: Rename include guard.
5479         * nat/gdb_ptrace.h: Rename include guard.
5480         * nat/fork-inferior.h: Rename include guard.
5481         * nat/amd64-linux-siginfo.h: Rename include guard.
5482         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5483         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5484         * nat/aarch64-linux.h: Rename include guard.
5485         * nat/aarch64-linux-hw-point.h: Rename include guard.
5486         * mn10300-tdep.h: Add include guard.
5487         * mips-linux-tdep.h: Add include guard.
5488         * mi/mi-parse.h: Rename include guard.
5489         * mi/mi-out.h: Rename include guard.
5490         * mi/mi-main.h: Rename include guard.
5491         * mi/mi-interp.h: Rename include guard.
5492         * mi/mi-getopt.h: Rename include guard.
5493         * mi/mi-console.h: Rename include guard.
5494         * mi/mi-common.h: Rename include guard.
5495         * mi/mi-cmds.h: Rename include guard.
5496         * mi/mi-cmd-break.h: Rename include guard.
5497         * m2-lang.h: Add include guard.
5498         * location.h: Rename include guard.
5499         * linux-record.h: Rename include guard.
5500         * linux-nat.h: Add include guard.
5501         * linux-fork.h: Add include guard.
5502         * i386-darwin-tdep.h: Rename include guard.
5503         * hppa-linux-offsets.h: Add include guard.
5504         * guile/guile.h: Rename include guard.
5505         * guile/guile-internal.h: Rename include guard.
5506         * gnu-nat.h: Rename include guard.
5507         * gdb-stabs.h: Rename include guard.
5508         * frv-tdep.h: Add include guard.
5509         * f-lang.h: Add include guard.
5510         * event-loop.h: Add include guard.
5511         * darwin-nat.h: Rename include guard.
5512         * cp-abi.h: Rename include guard.
5513         * config/sparc/nm-sol2.h: Rename include guard.
5514         * config/nm-nto.h: Rename include guard.
5515         * config/nm-linux.h: Add include guard.
5516         * config/i386/nm-i386gnu.h: Rename include guard.
5517         * config/djgpp/nl_types.h: Rename include guard.
5518         * config/djgpp/langinfo.h: Rename include guard.
5519         * compile/gcc-cp-plugin.h: Add include guard.
5520         * compile/gcc-c-plugin.h: Add include guard.
5521         * compile/compile.h: Rename include guard.
5522         * compile/compile-object-run.h: Rename include guard.
5523         * compile/compile-object-load.h: Rename include guard.
5524         * compile/compile-internal.h: Rename include guard.
5525         * compile/compile-cplus.h: Rename include guard.
5526         * compile/compile-c.h: Rename include guard.
5527         * common/xml-utils.h: Rename include guard.
5528         * common/x86-xstate.h: Rename include guard.
5529         * common/version.h: Rename include guard.
5530         * common/vec.h: Rename include guard.
5531         * common/tdesc.h: Rename include guard.
5532         * common/selftest.h: Rename include guard.
5533         * common/scoped_restore.h: Rename include guard.
5534         * common/scoped_mmap.h: Rename include guard.
5535         * common/scoped_fd.h: Rename include guard.
5536         * common/safe-iterator.h: Rename include guard.
5537         * common/run-time-clock.h: Rename include guard.
5538         * common/refcounted-object.h: Rename include guard.
5539         * common/queue.h: Rename include guard.
5540         * common/ptid.h: Rename include guard.
5541         * common/print-utils.h: Rename include guard.
5542         * common/preprocessor.h: Rename include guard.
5543         * common/pathstuff.h: Rename include guard.
5544         * common/observable.h: Rename include guard.
5545         * common/netstuff.h: Rename include guard.
5546         * common/job-control.h: Rename include guard.
5547         * common/host-defs.h: Rename include guard.
5548         * common/gdb_wait.h: Rename include guard.
5549         * common/gdb_vecs.h: Rename include guard.
5550         * common/gdb_unlinker.h: Rename include guard.
5551         * common/gdb_unique_ptr.h: Rename include guard.
5552         * common/gdb_tilde_expand.h: Rename include guard.
5553         * common/gdb_sys_time.h: Rename include guard.
5554         * common/gdb_string_view.h: Rename include guard.
5555         * common/gdb_splay_tree.h: Rename include guard.
5556         * common/gdb_setjmp.h: Rename include guard.
5557         * common/gdb_ref_ptr.h: Rename include guard.
5558         * common/gdb_optional.h: Rename include guard.
5559         * common/gdb_locale.h: Rename include guard.
5560         * common/gdb_assert.h: Rename include guard.
5561         * common/filtered-iterator.h: Rename include guard.
5562         * common/filestuff.h: Rename include guard.
5563         * common/fileio.h: Rename include guard.
5564         * common/environ.h: Rename include guard.
5565         * common/common-utils.h: Rename include guard.
5566         * common/common-types.h: Rename include guard.
5567         * common/common-regcache.h: Rename include guard.
5568         * common/common-inferior.h: Rename include guard.
5569         * common/common-gdbthread.h: Rename include guard.
5570         * common/common-exceptions.h: Rename include guard.
5571         * common/common-defs.h: Rename include guard.
5572         * common/common-debug.h: Rename include guard.
5573         * common/cleanups.h: Rename include guard.
5574         * common/buffer.h: Rename include guard.
5575         * common/btrace-common.h: Rename include guard.
5576         * common/break-common.h: Rename include guard.
5577         * cli/cli-utils.h: Rename include guard.
5578         * cli/cli-style.h: Rename include guard.
5579         * cli/cli-setshow.h: Rename include guard.
5580         * cli/cli-script.h: Rename include guard.
5581         * cli/cli-interp.h: Rename include guard.
5582         * cli/cli-decode.h: Rename include guard.
5583         * cli/cli-cmds.h: Rename include guard.
5584         * charset-list.h: Add include guard.
5585         * buildsym-legacy.h: Rename include guard.
5586         * bfin-tdep.h: Add include guard.
5587         * ax.h: Rename include guard.
5588         * arm-linux-tdep.h: Add include guard.
5589         * arm-fbsd-tdep.h: Add include guard.
5590         * arch/xtensa.h: Rename include guard.
5591         * arch/tic6x.h: Add include guard.
5592         * arch/i386.h: Add include guard.
5593         * arch/arm.h: Rename include guard.
5594         * arch/arm-linux.h: Rename include guard.
5595         * arch/arm-get-next-pcs.h: Rename include guard.
5596         * arch/amd64.h: Add include guard.
5597         * arch/aarch64-insn.h: Rename include guard.
5598         * arch-utils.h: Rename include guard.
5599         * annotate.h: Add include guard.
5600         * amd64-darwin-tdep.h: Rename include guard.
5601         * aarch64-linux-tdep.h: Add include guard.
5602         * aarch64-fbsd-tdep.h: Add include guard.
5603         * aarch32-linux-nat.h: Add include guard.
5604
5605 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5606
5607         * macrotab.c (macro_define_internal): New function that
5608         factorizes macro_define_object_internal and macro_define_function
5609         code.
5610         (macro_define_object_internal): Use macro_define_internal.
5611         (macro_define_function): Likewise.
5612
5613 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5614
5615         * macrocmd.c (extract_identifier): Return
5616         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5617         callers.
5618
5619 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5620
5621         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5622
5623 2019-02-05  Tom Tromey  <tom@tromey.com>
5624
5625         * target.c (target_stack::unpush): Move assertion earlier.
5626
5627 2019-01-30  Tom Tromey  <tom@tromey.com>
5628
5629         PR python/23615:
5630         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5631         (gdbpy_parse_and_eval): Likewise.
5632         * python/python-internal.h (gdbpy_allow_threads): New class.
5633
5634 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5635
5636         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5637         (aarch64_fbsd_fpregmap): Move earlier.
5638         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5639         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5640         instead of individual calls to trad_frame_set_reg_addr.
5641         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5642         earlier.
5643         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5644         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5645         instead of individual calls to trad_frame_set_reg_addr.
5646
5647 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5648
5649         * CONTRIBUTE: Replace contribution list with wiki link.
5650
5651 2019-01-25  Tom Tromey  <tom@tromey.com>
5652
5653         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5654
5655 2019-01-25  Tom Tromey  <tom@tromey.com>
5656
5657         * xtensa-linux-nat.c: Fix common/ includes.
5658         * xml-support.h: Fix common/ includes.
5659         * xml-support.c: Fix common/ includes.
5660         * x86-linux-nat.c: Fix common/ includes.
5661         * windows-nat.c: Fix common/ includes.
5662         * varobj.h: Fix common/ includes.
5663         * varobj.c: Fix common/ includes.
5664         * value.c: Fix common/ includes.
5665         * valops.c: Fix common/ includes.
5666         * utils.c: Fix common/ includes.
5667         * unittests/xml-utils-selftests.c: Fix common/ includes.
5668         * unittests/utils-selftests.c: Fix common/ includes.
5669         * unittests/unpack-selftests.c: Fix common/ includes.
5670         * unittests/tracepoint-selftests.c: Fix common/ includes.
5671         * unittests/style-selftests.c: Fix common/ includes.
5672         * unittests/string_view-selftests.c: Fix common/ includes.
5673         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5674         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5675         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5676         * unittests/rsp-low-selftests.c: Fix common/ includes.
5677         * unittests/parse-connection-spec-selftests.c: Fix common/
5678         includes.
5679         * unittests/optional-selftests.c: Fix common/ includes.
5680         * unittests/offset-type-selftests.c: Fix common/ includes.
5681         * unittests/observable-selftests.c: Fix common/ includes.
5682         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5683         * unittests/memrange-selftests.c: Fix common/ includes.
5684         * unittests/memory-map-selftests.c: Fix common/ includes.
5685         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5686         * unittests/function-view-selftests.c: Fix common/ includes.
5687         * unittests/environ-selftests.c: Fix common/ includes.
5688         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5689         * unittests/common-utils-selftests.c: Fix common/ includes.
5690         * unittests/cli-utils-selftests.c: Fix common/ includes.
5691         * unittests/array-view-selftests.c: Fix common/ includes.
5692         * ui-file.c: Fix common/ includes.
5693         * tui/tui-io.c: Fix common/ includes.
5694         * tracepoint.h: Fix common/ includes.
5695         * tracepoint.c: Fix common/ includes.
5696         * tracefile-tfile.c: Fix common/ includes.
5697         * top.h: Fix common/ includes.
5698         * top.c: Fix common/ includes.
5699         * thread.c: Fix common/ includes.
5700         * target/waitstatus.h: Fix common/ includes.
5701         * target/waitstatus.c: Fix common/ includes.
5702         * target.h: Fix common/ includes.
5703         * target.c: Fix common/ includes.
5704         * target-memory.c: Fix common/ includes.
5705         * target-descriptions.c: Fix common/ includes.
5706         * symtab.h: Fix common/ includes.
5707         * symfile.c: Fix common/ includes.
5708         * stap-probe.c: Fix common/ includes.
5709         * spu-linux-nat.c: Fix common/ includes.
5710         * sparc-nat.c: Fix common/ includes.
5711         * source.c: Fix common/ includes.
5712         * solib.c: Fix common/ includes.
5713         * solib-target.c: Fix common/ includes.
5714         * ser-unix.c: Fix common/ includes.
5715         * ser-tcp.c: Fix common/ includes.
5716         * ser-pipe.c: Fix common/ includes.
5717         * ser-base.c: Fix common/ includes.
5718         * selftest-arch.c: Fix common/ includes.
5719         * s12z-tdep.c: Fix common/ includes.
5720         * rust-exp.y: Fix common/ includes.
5721         * rs6000-aix-tdep.c: Fix common/ includes.
5722         * riscv-tdep.c: Fix common/ includes.
5723         * remote.c: Fix common/ includes.
5724         * remote-notif.h: Fix common/ includes.
5725         * remote-fileio.h: Fix common/ includes.
5726         * remote-fileio.c: Fix common/ includes.
5727         * regcache.h: Fix common/ includes.
5728         * regcache.c: Fix common/ includes.
5729         * record-btrace.c: Fix common/ includes.
5730         * python/python.c: Fix common/ includes.
5731         * python/py-type.c: Fix common/ includes.
5732         * python/py-inferior.c: Fix common/ includes.
5733         * progspace.h: Fix common/ includes.
5734         * producer.c: Fix common/ includes.
5735         * procfs.c: Fix common/ includes.
5736         * proc-api.c: Fix common/ includes.
5737         * printcmd.c: Fix common/ includes.
5738         * ppc-linux-nat.c: Fix common/ includes.
5739         * parser-defs.h: Fix common/ includes.
5740         * osdata.c: Fix common/ includes.
5741         * obsd-nat.c: Fix common/ includes.
5742         * nat/x86-linux.c: Fix common/ includes.
5743         * nat/x86-linux-dregs.c: Fix common/ includes.
5744         * nat/x86-dregs.h: Fix common/ includes.
5745         * nat/x86-dregs.c: Fix common/ includes.
5746         * nat/ppc-linux.c: Fix common/ includes.
5747         * nat/mips-linux-watch.h: Fix common/ includes.
5748         * nat/mips-linux-watch.c: Fix common/ includes.
5749         * nat/linux-waitpid.c: Fix common/ includes.
5750         * nat/linux-ptrace.h: Fix common/ includes.
5751         * nat/linux-ptrace.c: Fix common/ includes.
5752         * nat/linux-procfs.c: Fix common/ includes.
5753         * nat/linux-personality.c: Fix common/ includes.
5754         * nat/linux-osdata.c: Fix common/ includes.
5755         * nat/linux-namespaces.c: Fix common/ includes.
5756         * nat/linux-btrace.h: Fix common/ includes.
5757         * nat/linux-btrace.c: Fix common/ includes.
5758         * nat/fork-inferior.c: Fix common/ includes.
5759         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5760         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5761         * nat/aarch64-linux.c: Fix common/ includes.
5762         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5763         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5764         * namespace.h: Fix common/ includes.
5765         * mips-linux-tdep.c: Fix common/ includes.
5766         * minsyms.c: Fix common/ includes.
5767         * mi/mi-parse.h: Fix common/ includes.
5768         * mi/mi-main.c: Fix common/ includes.
5769         * mi/mi-cmd-env.c: Fix common/ includes.
5770         * memrange.h: Fix common/ includes.
5771         * memattr.c: Fix common/ includes.
5772         * maint.h: Fix common/ includes.
5773         * maint.c: Fix common/ includes.
5774         * main.c: Fix common/ includes.
5775         * machoread.c: Fix common/ includes.
5776         * location.c: Fix common/ includes.
5777         * linux-thread-db.c: Fix common/ includes.
5778         * linux-nat.c: Fix common/ includes.
5779         * linux-fork.c: Fix common/ includes.
5780         * inline-frame.c: Fix common/ includes.
5781         * infrun.c: Fix common/ includes.
5782         * inflow.c: Fix common/ includes.
5783         * inferior.h: Fix common/ includes.
5784         * inferior.c: Fix common/ includes.
5785         * infcmd.c: Fix common/ includes.
5786         * inf-ptrace.c: Fix common/ includes.
5787         * inf-child.c: Fix common/ includes.
5788         * ia64-linux-nat.c: Fix common/ includes.
5789         * i387-tdep.c: Fix common/ includes.
5790         * i386-tdep.c: Fix common/ includes.
5791         * i386-linux-tdep.c: Fix common/ includes.
5792         * i386-linux-nat.c: Fix common/ includes.
5793         * i386-go32-tdep.c: Fix common/ includes.
5794         * i386-fbsd-tdep.c: Fix common/ includes.
5795         * i386-fbsd-nat.c: Fix common/ includes.
5796         * guile/scm-type.c: Fix common/ includes.
5797         * guile/guile.c: Fix common/ includes.
5798         * go32-nat.c: Fix common/ includes.
5799         * gnu-nat.c: Fix common/ includes.
5800         * gdbthread.h: Fix common/ includes.
5801         * gdbarch-selftests.c: Fix common/ includes.
5802         * gdb_usleep.c: Fix common/ includes.
5803         * gdb_select.h: Fix common/ includes.
5804         * gdb_bfd.c: Fix common/ includes.
5805         * gcore.c: Fix common/ includes.
5806         * fork-child.c: Fix common/ includes.
5807         * findvar.c: Fix common/ includes.
5808         * fbsd-nat.c: Fix common/ includes.
5809         * event-top.c: Fix common/ includes.
5810         * event-loop.c: Fix common/ includes.
5811         * dwarf2read.c: Fix common/ includes.
5812         * dwarf2loc.c: Fix common/ includes.
5813         * dwarf2-frame.c: Fix common/ includes.
5814         * dwarf-index-cache.c: Fix common/ includes.
5815         * dtrace-probe.c: Fix common/ includes.
5816         * disasm-selftests.c: Fix common/ includes.
5817         * defs.h: Fix common/ includes.
5818         * csky-tdep.c: Fix common/ includes.
5819         * cp-valprint.c: Fix common/ includes.
5820         * cp-support.h: Fix common/ includes.
5821         * cp-support.c: Fix common/ includes.
5822         * corelow.c: Fix common/ includes.
5823         * completer.h: Fix common/ includes.
5824         * completer.c: Fix common/ includes.
5825         * compile/compile.c: Fix common/ includes.
5826         * compile/compile-loc2c.c: Fix common/ includes.
5827         * compile/compile-cplus-types.c: Fix common/ includes.
5828         * compile/compile-cplus-symbols.c: Fix common/ includes.
5829         * command.h: Fix common/ includes.
5830         * cli/cli-dump.c: Fix common/ includes.
5831         * cli/cli-cmds.c: Fix common/ includes.
5832         * charset.c: Fix common/ includes.
5833         * build-id.c: Fix common/ includes.
5834         * btrace.h: Fix common/ includes.
5835         * btrace.c: Fix common/ includes.
5836         * breakpoint.h: Fix common/ includes.
5837         * breakpoint.c: Fix common/ includes.
5838         * ax.h:
5839         (enum agent_op): Fix common/ includes.
5840         * ax-general.c (struct aop_map): Fix common/ includes.
5841         * ax-gdb.c: Fix common/ includes.
5842         * auxv.c: Fix common/ includes.
5843         * auto-load.c: Fix common/ includes.
5844         * arm-tdep.c: Fix common/ includes.
5845         * arch/riscv.c: Fix common/ includes.
5846         * arch/ppc-linux-common.c: Fix common/ includes.
5847         * arch/i386.c: Fix common/ includes.
5848         * arch/arm.c: Fix common/ includes.
5849         * arch/arm-linux.c: Fix common/ includes.
5850         * arch/arm-get-next-pcs.c: Fix common/ includes.
5851         * arch/amd64.c: Fix common/ includes.
5852         * arch/aarch64.c: Fix common/ includes.
5853         * arch/aarch64-insn.c: Fix common/ includes.
5854         * arch-utils.c: Fix common/ includes.
5855         * amd64-windows-tdep.c: Fix common/ includes.
5856         * amd64-tdep.c: Fix common/ includes.
5857         * amd64-sol2-tdep.c: Fix common/ includes.
5858         * amd64-obsd-tdep.c: Fix common/ includes.
5859         * amd64-nbsd-tdep.c: Fix common/ includes.
5860         * amd64-linux-tdep.c: Fix common/ includes.
5861         * amd64-linux-nat.c: Fix common/ includes.
5862         * amd64-fbsd-tdep.c: Fix common/ includes.
5863         * amd64-fbsd-nat.c: Fix common/ includes.
5864         * amd64-dicos-tdep.c: Fix common/ includes.
5865         * amd64-darwin-tdep.c: Fix common/ includes.
5866         * agent.c: Fix common/ includes.
5867         * ada-lang.h: Fix common/ includes.
5868         * ada-lang.c: Fix common/ includes.
5869         * aarch64-tdep.c: Fix common/ includes.
5870
5871 2019-01-25  Tom Tromey  <tom@tromey.com>
5872
5873         * common/create-version.sh: Use common/version.h.
5874
5875 2019-01-24  Pedro Alves  <palves@redhat.com>
5876
5877         * infrun.c (signal_stop, signal_print, signal_program)
5878         (signal_catch, signal_pass): Now arrays instead of pointers.
5879         (update_signals_program_target, do_target_resume)
5880         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5881         * linux-nat.c (linux_nat_target::pass_signals)
5882         (linux_nat_target::create_inferior, linux_nat_target::attach):
5883         Adjust.
5884         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5885         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5886         * procfs.c (procfs_target::pass_signals): Adjust.
5887         * record-full.c (record_full_target::resume): Adjust.
5888         * remote.c (remote_target::pass_signals)
5889         (remote_target::program_signals): Adjust.
5890         * target-debug.h (target_debug_print_signals): Now takes a
5891         gdb::array_view as parameter.  Adjust.
5892         * target.h (target_ops) <pass_signals, program_signals>: Replace
5893         pointer and length parameters with gdb::array_view.
5894         (target_pass_signals, target_program_signals): Likewise.
5895         * target-delegates.c: Regenerate.
5896
5897 2019-01-24  Pedro Alves  <palves@redhat.com>
5898
5899         * common/forward-scope-exit.h
5900         (forward_scope_exit::forward_scope_exit): Pass arguments to
5901         m_bind_function directly, instead of creating a std::bind and
5902         copying that.
5903
5904 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5905
5906         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5907         for static members.
5908         (pass_in_v_vfp_candidate): Likewise.
5909
5910 2019-01-23  Tom Tromey  <tom@tromey.com>
5911             Pedro Alves  <palves@redhat.com>
5912
5913         * regcache.c (class regcache_invalidator): Remove.
5914         (regcache::raw_write): Use make_scope_exit.
5915
5916 2019-01-23  Tom Tromey  <tom@tromey.com>
5917
5918         * ui-out.h (class ui_out_emit_type): Update comment.
5919
5920 2019-01-23  Tom Tromey  <tom@tromey.com>
5921
5922         * infrun.c (fetch_inferior_event): Update comment.
5923
5924 2019-01-23  Tom Tromey  <tom@tromey.com>
5925             Pedro Alves  <palves@redhat.com>
5926
5927         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5928         parameter.
5929         (fetch_inferior_event): Use SCOPE_EXIT.
5930
5931
5932 2019-01-23  Tom Tromey  <tom@tromey.com>
5933             Pedro Alves  <palves@redhat.com>
5934
5935         * infrun.c (disable_thread_events): Delete.
5936         (stop_all_threads): Use SCOPE_EXIT.
5937
5938 2019-01-23  Tom Tromey  <tom@tromey.com>
5939             Pedro Alves  <palves@redhat.com>
5940
5941         * symfile.c: Include forward-scope-exit.h.
5942         (clear_symtab_users_cleanup): Replace forward declaration with
5943         a FORWARD_SCOPE_EXIT.
5944         (syms_from_objfile_1): Use the forward_scope_exit and
5945         gdb::optional instead of cleanup_function.
5946         (reread_symbols): Use the forward_scope_exit instead of
5947         cleanup_function.
5948         (clear_symtab_users_cleanup): Remove function.
5949
5950 2019-01-23  Tom Tromey  <tom@tromey.com>
5951             Pedro Alves  <palves@redhat.com>
5952
5953         * linux-nat.c: Include scope-exit.h.
5954         (cleanup_target_stop): Remove.
5955         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5956         SCOPE_EXIT.
5957
5958 2019-01-23  Tom Tromey  <tom@tromey.com>
5959             Pedro Alves  <palves@redhat.com>
5960
5961         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5962         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5963
5964 2019-01-23  Tom Tromey  <tom@tromey.com>
5965             Andrew Burgess  <andrew.burgess@embecosm.com>
5966             Pedro Alves  <palves@redhat.com>
5967
5968         * infrun.c (fetch_inferior_event): Use scope_exit.
5969         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5970         * top.c (execute_command): Use scope_exit.
5971         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5972         * utils.c (do_bpstat_clear_actions_cleanup)
5973         (make_bpstat_clear_actions_cleanup): Remove.
5974
5975 2019-01-23  Tom Tromey  <tom@tromey.com>
5976             Pedro Alves  <palves@redhat.com>
5977
5978         * infrun.c: Include "common/scope-exit.h"
5979         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5980         (wait_for_inferior): Use SCOPE_EXIT.
5981         (fetch_inferior_event): Use scope_exit.
5982
5983 2019-01-23  Tom Tromey  <tom@tromey.com>
5984             Pedro Alves  <palves@redhat.com>
5985
5986         * breakpoint.c (create_breakpoint): Remove cleanup.
5987
5988 2019-01-23  Tom Tromey  <tom@tromey.com>
5989             Andrew Burgess  <andrew.burgess@embecosm.com>
5990             Pedro Alves  <palves@redhat.com>
5991
5992 2019-01-23  Pedro Alves  <palves@redhat.com>
5993
5994         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5995
5996 2019-01-23  Pedro Alves  <palves@redhat.com>
5997             Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * gdbthread.h: Include "common/forward-scope-exit.h".
6000         (scoped_finish_thread_state): Redefine custom class in terms of
6001         forward_scope_exit.
6002
6003 2019-01-23  Pedro Alves  <palves@redhat.com>
6004             Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * common/forward-scope-exit.h: New file.
6007
6008 2019-01-23  Pedro Alves  <palves@redhat.com>
6009             Andrew Burgess  <andrew.burgess@embecosm.com>
6010             Tom Tromey  <tom@tromey.com>
6011
6012         * common/scope-exit.h: New file.
6013
6014 2019-01-23  Pedro Alves  <palves@redhat.com>
6015
6016         * common/preprocessor.h (ESC): Rename to ...
6017         (ESC_PARENS): ... this.
6018         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6019         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6020
6021 2019-01-23  Tom Tromey  <tom@tromey.com>
6022
6023         * language.h (class scoped_switch_to_sym_language_if_auto):
6024         Initialize m_lang in both cases.
6025
6026 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6027
6028         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6029         with XCNEW.
6030
6031 2019-01-22  Tom Tromey  <tom@tromey.com>
6032
6033         * corelow.c: Do not include sys/file.h.
6034
6035 2019-01-22  Tom Tromey  <tom@tromey.com>
6036
6037         * tui/tui-wingeneral.h: Include gdb_curses.h.
6038
6039 2019-01-22  Tom Tromey  <tom@tromey.com>
6040
6041         * source-cache.h (class source_cache) <get_source_lines,
6042         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6043
6044 2019-01-22  Tom Tromey  <tom@tromey.com>
6045
6046         * remote-fileio.h (struct remote_target): Declare.
6047
6048 2019-01-22  Tom Tromey  <tom@tromey.com>
6049
6050         * python/py-arch.c: Do not include py-ref.h.
6051         * python/py-bpevent.c: Do not include py-ref.h.
6052         * python/py-cmd.c: Do not include py-ref.h.
6053         * python/py-continueevent.c: Do not include py-ref.h.
6054         * python/py-event.h: Do not include py-ref.h.
6055         * python/py-evtregistry.c: Do not include py-ref.h.
6056         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6057         * python/py-frame.c: Do not include py-ref.h.
6058         * python/py-framefilter.c: Do not include py-ref.h.
6059         * python/py-function.c: Do not include py-ref.h.
6060         * python/py-infevents.c: Do not include py-ref.h.
6061         * python/py-linetable.c: Do not include py-ref.h.
6062         * python/py-objfile.c: Do not include py-ref.h.
6063         * python/py-param.c: Do not include py-ref.h.
6064         * python/py-prettyprint.c: Do not include py-ref.h.
6065         * python/py-progspace.c: Do not include py-ref.h.
6066         * python/py-symbol.c: Do not include py-ref.h.
6067         * python/py-symtab.c: Do not include py-ref.h.
6068         * python/py-type.c: Do not include py-ref.h.
6069         * python/py-unwind.c: Do not include py-ref.h.
6070         * python/py-utils.c: Do not include py-ref.h.
6071         * python/py-value.c: Do not include py-ref.h.
6072         * python/py-varobj.c: Do not include py-ref.h.
6073         * python/py-xmethods.c: Do not include py-ref.h.
6074         * python/python.c: Do not include py-ref.h.
6075         * varobj.c: Do not include py-ref.h.
6076
6077 2019-01-22  Tom Tromey  <tom@tromey.com>
6078
6079         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6080         keyword for bcache.
6081
6082 2019-01-22  Tom Tromey  <tom@tromey.com>
6083
6084         * compile/compile-cplus-types.c: Remove a comment by #include.
6085
6086 2019-01-22  Tom Tromey  <tom@tromey.com>
6087
6088         * compile/gcc-c-plugin.h: Include compile-internal.h.
6089
6090 2019-01-22  Tom Tromey  <tom@tromey.com>
6091
6092         * stabsread.c (EXTERN): Do not define.
6093         (symnum, next_symbol_text_func, processing_gcc_compilation)
6094         (within_function, global_sym_chain, global_stabs)
6095         (previous_stab_code, this_object_header_files)
6096         (n_this_object_header_files)
6097         (n_allocated_this_object_header_files): Define.
6098         * stabsread.h (EXTERN): Never define.  Use "extern".
6099
6100 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6101
6102         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6103         history_value.
6104
6105 2019-01-21  Tom Tromey  <tom@tromey.com>
6106
6107         * ui-out.c: Fix includes.
6108         * tui/tui-source.c: Fix includes.
6109         * target.c: Fix includes.
6110         * remote.c: Fix includes.
6111         * regcache.c: Fix includes.
6112         * python/py-block.c: Fix includes.
6113         * printcmd.c: Fix includes.
6114         * or1k-tdep.c: Fix includes.
6115         * mi/mi-main.c: Fix includes.
6116         * m32r-tdep.c: Fix includes.
6117         * csky-tdep.c: Fix includes.
6118         * compile/compile-cplus-types.c: Fix includes.
6119         * cli/cli-interp.c: Fix includes.
6120
6121 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6122
6123         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6124         for padding.
6125
6126 2019-01-16  Tom Tromey  <tom@tromey.com>
6127
6128         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6129         earlier.
6130         (struct objfile) <msymbols_range>: Move from top level.
6131         <msymbols>: New method.
6132         (class objfile_msymbols): Remove.
6133         * symtab.c (default_collect_symbol_completion_matches_break_on):
6134         Update.
6135         * symmisc.c (dump_msymbols): Update.
6136         * stabsread.c (scan_file_globals): Update.
6137         * objc-lang.c (info_selectors_command, info_classes_command)
6138         (find_methods): Update.
6139         * minsyms.c (find_solib_trampoline_target): Update.
6140         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6141         * coffread.c (coff_symfile_read): Update.
6142         * ada-lang.c (ada_lookup_simple_minsym)
6143         (ada_collect_symbol_completion_matches): Update.
6144
6145 2019-01-16  Tom Tromey  <tom@tromey.com>
6146
6147         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6148         type.  Remove no-argument constructor.
6149         <iterator::operator++>: Simplify.
6150         <begin>: Update.
6151         <end>: Use minimal_symbol_count.
6152
6153 2019-01-16  Tom Tromey  <tom@tromey.com>
6154
6155         * objfiles.h (struct objfile) <psymtabs>: New method.
6156         (class objfile_psymtabs): Remove.
6157         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6158         typedef.
6159         <range>: New method.
6160         (require_partial_symbols): Change return type.
6161         * psymtab.c (require_partial_symbols)
6162         (psym_expand_symtabs_matching): Update.
6163         * mdebugread.c (parse_partial_symbols): Update.
6164         * dbxread.c (dbx_end_psymtab): Update.
6165
6166 2019-01-15  Tom Tromey  <tom@tromey.com>
6167
6168         * symtab.c (lookup_objfile_from_block)
6169         (lookup_symbol_in_objfile_symtabs)
6170         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6171         (find_line_symtab, info_sources_command)
6172         (default_collect_symbol_completion_matches_break_on)
6173         (make_source_files_completion_list): Update.
6174         * symmisc.c (print_objfile_statistics, dump_objfile)
6175         (maintenance_print_symbols, maintenance_info_symtabs)
6176         (maintenance_check_symtabs, maintenance_info_line_tables):
6177         Update.
6178         * source.c (select_source_symtab)
6179         (forget_cached_source_info_for_objfile): Update.
6180         * objfiles.h (class objfile_compunits): Remove.
6181         (struct objfile) <compunits_range>: New typedef.
6182         (compunits): New method.
6183         * objfiles.c (objfile_relocate1): Update.
6184         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6185         * maint.c (count_symtabs_and_blocks): Update.
6186         * linespec.c (iterate_over_all_matching_symtabs): Update.
6187         * cp-support.c (add_symbol_overload_list_qualified): Update.
6188         * coffread.c (coff_symtab_read): Update.
6189         * ada-lang.c (add_nonlocal_symbols)
6190         (ada_collect_symbol_completion_matches)
6191         (ada_add_global_exceptions): Update.
6192
6193 2019-01-15  Tom Tromey  <tom@tromey.com>
6194
6195         * progspace.h (program_space) <objfiles_safe_range>: New
6196         typedef.
6197         <objfiles_safe>: New method.
6198         * objfiles.h (class all_objfiles_safe): Remove.
6199         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6200         * jit.c (jit_inferior_exit_hook): Update.
6201
6202 2019-01-17  Tom Tromey  <tom@tromey.com>
6203
6204         * progspace.h (program_space) <objfiles_range>: New typedef.
6205         <objfiles>: New method.
6206         <objfiles_head>: Rename from objfiles.
6207         (object_files): Update.
6208         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6209         * guile/scm-pretty-print.c
6210         (ppscm_find_pretty_printer_from_objfiles): Update.
6211         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6212         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6213         Update.
6214         * python/py-progspace.c (pspy_get_objfiles): Update.
6215         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6216         Update.
6217         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6218         (objfpy_lookup_objfile_by_build_id): Update.
6219         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6220         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6221         Update.
6222         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6223         (expand_symtab_containing_pc, lookup_objfile_from_block)
6224         (lookup_static_symbol, basic_lookup_transparent_type)
6225         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6226         (find_line_symtab, info_sources_command)
6227         (default_collect_symbol_completion_matches_break_on)
6228         (make_source_files_completion_list, find_main_name): Update.
6229         * symmisc.c (print_symbol_bcache_statistics)
6230         (print_objfile_statistics, maintenance_print_symbols)
6231         (maintenance_print_msymbols, maintenance_print_objfiles)
6232         (maintenance_info_symtabs, maintenance_check_symtabs)
6233         (maintenance_expand_symtabs, maintenance_info_line_tables):
6234         Update.
6235         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6236         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6237         (map_overlay_command, unmap_overlay_command)
6238         (simple_overlay_update, expand_symtabs_matching)
6239         (map_symbol_filenames): Update.
6240         * symfile-debug.c (set_debug_symfile): Update.
6241         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6242         Update.
6243         * source.c (select_source_symtab, forget_cached_source_info):
6244         Update.
6245         * solib.c (solib_read_symbols): Update.
6246         * solib-spu.c (append_ocl_sos): Update.
6247         * psymtab.c (maintenance_print_psymbols)
6248         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6249         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6250         * printcmd.c (info_symbol_command): Update.
6251         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6252         Update.
6253         * objfiles.h (class all_objfiles): Remove.
6254         * objfiles.c (have_partial_symbols, have_full_symbols)
6255         (have_minimal_symbols, qsort_cmp, update_section_map)
6256         (shared_objfile_contains_address_p)
6257         (default_iterate_over_objfiles_in_search_order): Update.
6258         * objc-lang.c (info_selectors_command, info_classes_command)
6259         (find_methods): Update.
6260         * minsyms.c (find_solib_trampoline_target): Update.
6261         * maint.c (maintenance_info_sections)
6262         (maintenance_translate_address, count_symtabs_and_blocks):
6263         Update.
6264         * main.c (captured_main_1): Update.
6265         * linux-thread-db.c (try_thread_db_load_from_pdir)
6266         (has_libpthread): Update.
6267         * linespec.c (iterate_over_all_matching_symtabs)
6268         (search_minsyms_for_name): Update.
6269         * jit.c (jit_find_objf_with_entry_addr): Update.
6270         * hppa-tdep.c (find_unwind_entry)
6271         (hppa_lookup_stub_minimal_symbol): Update.
6272         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6273         Update.
6274         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6275         (elf_gnu_ifunc_resolve_by_got): Update.
6276         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6277         * dwarf-index-write.c (save_gdb_index_command): Update.
6278         * cp-support.c (add_symbol_overload_list_qualified): Update.
6279         * breakpoint.c (create_overlay_event_breakpoint)
6280         (create_longjmp_master_breakpoint)
6281         (create_std_terminate_master_breakpoint)
6282         (create_exception_master_breakpoint): Update.
6283         * blockframe.c (find_pc_partial_function): Update.
6284         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6285         (ada_collect_symbol_completion_matches)
6286         (ada_add_global_exceptions): Update.
6287
6288 2019-01-17  Tom Tromey  <tom@tromey.com>
6289
6290         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6291         declare VEC.
6292         (solib_target_parse_libraries): Change return type.
6293         (library_list_start_segment, library_list_start_section)
6294         (library_list_end_library, library_list_start_library); Update.
6295         (solib_target_free_library_list): Remove.
6296         (solib_target_parse_libraries): Remove cleanup.  Change return
6297         type.
6298         (solib_target_current_sos): Update.
6299
6300 2019-01-17  Tom Tromey  <tromey@bapiya>
6301
6302         * valprint.c: Replace "the the" with "the".
6303         * symtab.c: Replace "the the" with "the".
6304         * solib.c: Replace "the the" with "the".
6305         * solib-dsbt.c: Replace "the the" with "the".
6306         * linespec.c: Replace "the the" with "the".
6307         * dwarf2loc.h: Replace "the the" with "the".
6308         * amd64-windows-tdep.c: Replace "the the" with "the".
6309         * aarch64-tdep.c: Replace "the the" with "the".
6310
6311 2019-01-16  Keith Seitz  <keiths@redhat.com>
6312
6313         PR gdb/23773
6314         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6315         <builder>: Rename to ..
6316         <m_builder>: ... this and make private.
6317         (dwarf2_cu::get_builder): New method.  Change all users of
6318         `builder' to use this method.
6319         (dwarf2_start_symtab): Move to ...
6320         (dwarf2_cu::start_symtab): ... here.  Update all callers
6321         (setup_type_unit_groups): Move to ...
6322         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6323         callers.
6324         (dwarf2_cu::reset_builder): New method.
6325         (process_full_compunit, process_full_type_unit): Use
6326         dwarf2_cu::reset_builder.
6327         (follow_die_offset): Record the ancestor CU if it is different
6328         from the followed DIE's CU.
6329         (follow_die_sig_1): Likewise.
6330
6331 2019-01-15  Tom Tromey  <tom@tromey.com>
6332
6333         * remote.c (class remote_state) <buf>: Now a char_vector.
6334         <buf_size>: Remove.
6335         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6336         parameter.
6337         (remote_target::getpkt_or_notif_sane_1)
6338         (remote_target::getpkt_sane)
6339         (remote_target::getpkt_or_notif_sane): Likewise.
6340         (class remote_target) <putpkt>: New overload.
6341         (remote_target::read_frame): Change type of "buf_p".  Remove
6342         sizeof_p parameter.
6343         (packet_ok): New overload.
6344         (packet_check_result): New overload.
6345         Update all uses.
6346
6347 2019-01-14  Tom Tromey  <tom@tromey.com>
6348
6349         * remote-notif.c (handle_notification, remote_notif_ack)
6350         (remote_notif_parse): Make "buf" const.
6351         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6352         const.
6353         (remote_notif_parse, remote_notif_ack, handle_notification):
6354         Likewise.
6355         * remote.c (remote_notif_stop_parse): Make "buf" const.
6356         (remote_target::remote_parse_stop_reply): Make "buf" const.
6357         (remote_notif_stop_ack): Make "buf" const.
6358
6359 2019-01-14  Tom Tromey  <tom@tromey.com>
6360
6361         * remote.c (remote_console_output): Make parameter const.
6362
6363 2019-01-14  Tom Tromey  <tom@tromey.com>
6364
6365         * target-debug.h (target_debug_print_signals): Constify.
6366         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6367         * procfs.c (procfs_target::pass_signals): Update.
6368         * linux-nat.c (linux_nat_target::pass_signals): Update.
6369         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6370         * target-delegates.c: Rebuild.
6371         * remote.c (remote_target::program_signals): Update.
6372         (remote_target::pass_signals): Update.
6373         * target.c (target_pass_signals): Constify argument.
6374         (target_program_signals): Likewise.
6375         * target.h (struct target_ops) <pass_signals, program_signals>:
6376         Constify argument.
6377         (target_pass_signals, target_program_signals): Constify argument.
6378
6379 2019-01-14  Tom Tromey  <tom@tromey.com>
6380
6381         PR tui/28819:
6382         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6383
6384 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6385
6386         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6387         field.
6388         * rs6000-tdep.c: Include reggroups.h.
6389         (IS_V_ALIAS_PSEUDOREG): Define.
6390         (rs6000_register_name): Return names for the "vX" aliases.
6391         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6392         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6393         aliases.  Call default_register_reggroup_p for all other
6394         pseudo-registers.
6395         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6396         New functions.
6397         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6398         Handle "vX" aliases.
6399         (v_alias_pseudo_register_collect): New function.
6400         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6401         (rs6000_gdbarch_init): Initialize "vX" aliases as
6402         pseudo-registers.  Restore registration of
6403         rs6000_pseudo_register_reggroup_p with
6404         set_tdesc_pseudo_register_reggroup_p.
6405
6406 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6407
6408         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6409         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6410         set_gdbarch_num_pseudo_regs.
6411
6412 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6413
6414         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6415         Remove arg prefixname, add do_set and do_show.
6416         Add member functions set_list and show_list.
6417         * cli/cli-style.c (class cli_style_option): Update accordingly.
6418         (style_set_list): Move to file scope.
6419         (style_show_list): Likewise.
6420         (set_style): Call help_list.
6421         (show_style): Call cmd_show_list.
6422         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6423         Update to use the new macro.
6424
6425 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6426
6427         * ada-lang.c (_initialize_ada_language): Expand the help text
6428         for the "catch exception" command.
6429
6430 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6431
6432         * symtab.c (matching_obj_sections): Initialize obj,
6433         declare it closer to its usage.
6434
6435 2019-01-10  Tom Tromey  <tom@tromey.com>
6436
6437         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6438         (basic_inf_threads_range): Remove.
6439         (inf_threads_range, inf_non_exited_threads_range)
6440         (safe_inf_threads_range): Use next_adapter.
6441
6442 2019-01-10  Keith Seitz  <keiths@redhat.com>
6443
6444         PR gdb/23712
6445         PR symtab/23010
6446         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6447         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6448
6449 2019-01-10  Keith Seitz  <keiths@redhat.com>
6450
6451         PR gdb/23712
6452         PR symtab/23010
6453         * dictionary.c (pending_to_vector): Remove.
6454         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6455         Remove _1 suffix, replacing functions of the same name.  Update
6456         all callers.
6457         (dict_create_hashed, dict_create_hashed_expandable)
6458         (dict_create_linear, dict_create_linear_expandable, dict_free)
6459         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6460         Make functions static.
6461
6462 2019-01-10  Keith Seitz  <keiths@redhat.com>
6463
6464         PR gdb/23712
6465         PR symtab/23010
6466         * dictionary.h (struct dictionary): Replace declaration with
6467         multidictionary.
6468         (dict_create_hashed, dict_create_hashed_expandable)
6469         (dict_create_linear, dict_create_linear_expandable)
6470         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6471         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6472         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6473         taking multidictionary argument.
6474         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6475         * block.h (struct block) <dict>: Change to multidictionary
6476         and rename `multidict'.
6477         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6478         symmisc.c: Update all dictionary references to multidictionary.
6479
6480 2019-01-10  Keith Seitz  <keiths@redhat.com>
6481
6482         PR gdb/23712
6483         PR symtab/23010
6484         * dictionary.c: Include unordered_map.
6485         (pending_to_vector): New function.
6486         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6487         Rewrite the non-"_1" functions to take vector instead
6488         of linked list.
6489         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6490         "new" _1 versions of the same name.
6491         (multidictionary): Define.
6492         (std::hash<enum language): New definition.
6493         (collate_pending_symbols_by_language, mdict_create_hashed)
6494         (mdict_create_hashed_expandable, mdict_create_linear)
6495         (mdict_create_linear_expandable, mdict_free)
6496         (find_language_dictionary, create_new_language_dictionary)
6497         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6498         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6499         (mdict_size, mdict_empty): New functions.
6500         * dictionary.h (mdict_iterator): Define.
6501
6502 2019-01-10  Pedro Alves  <palves@redhat.com>
6503
6504         * breakpoint.c (read_uploaded_action)
6505         (create_tracepoint_from_upload): Adjust to use
6506         gdb::unique_xmalloc_ptr.
6507         * ctf.c (ctf_write_uploaded_tp):
6508         (SET_ARRAY_FIELD): Use emplace_back.
6509         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6510         * tracefile-tfile.c (tfile_write_uploaded_tp):
6511         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6512         gdb::unique_xmalloc_ptr.
6513         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6514         at_string, cond_string, cmd_strings>: Replace char pointers
6515         with gdb::unique_xmalloc_ptr.
6516
6517 2019-01-10  Pedro Alves  <palves@redhat.com>
6518
6519         * solib-target.c (library_list_start_library): Don't xstrdup name.
6520
6521 2019-01-10  Pedro Alves  <palves@redhat.com>
6522
6523         * mdebugread.c (parse_partial_symbols): Use
6524         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6525
6526 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * linux-fork.c (scoped_switch_fork_info)
6529         <~scoped_switch_fork_info>: Fix incorrect variable name.
6530
6531 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6532
6533         * linux-fork.c (scoped_switch_fork_info)
6534         <scoped_switch_fork_info>: Make explicit.
6535         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6536
6537 2019-01-10  Tom Tromey  <tom@tromey.com>
6538
6539         * objfiles.h (objfile::reset_psymtabs): Update.
6540         * objfiles.c (objfile::objfile): Update.
6541         * psymtab.h (psymtab_storage::obstack): Update.
6542         (psymtab_storage::m_obstack): Use gdb::optional.
6543         (class psymtab_storage): Update comment.  Remove objfile
6544         parameter.
6545         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6546
6547 2019-01-10  Tom Tromey  <tom@tromey.com>
6548
6549         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6550         <free_psymtabs>: Now private.
6551         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6552         (allocate_psymtab): Use new method.
6553
6554 2019-01-10  Tom Tromey  <tom@tromey.com>
6555
6556         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6557         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6558         * mdebugread.c (parse_partial_symbols): Use
6559         allocate_dependencies.
6560         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6561         allocate_dependencies.
6562         (process_psymtab_comp_unit_reader)
6563         (build_type_psymtab_dependencies): Likewise.
6564         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6565
6566 2019-01-10  Tom Tromey  <tom@tromey.com>
6567
6568         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6569         PSYMBOL_SET_LANGUAGE.
6570         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6571
6572 2019-01-10  Tom Tromey  <tom@tromey.com>
6573
6574         * psymtab.h (psymtab_storage::obstack): New method.
6575         <m_obstack>: Rename from obstack; now private.
6576         * psymtab.c (psymtab_storage): Update.
6577         * dwarf2read.c (create_addrmap_from_index)
6578         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6579         Update.
6580
6581 2019-01-10  Tom Tromey  <tom@tromey.com>
6582
6583         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6584         * objfiles.h (objfile::reset_psymtabs): New method.
6585
6586 2019-01-10  Tom Tromey  <tom@tromey.com>
6587
6588         * symmisc.c (print_symbol_bcache_statistics): Update.
6589         (print_objfile_statistics): Update.
6590         * symfile.c (reread_symbols): Update.
6591         * psymtab.h (class psymtab_storage): New.
6592         * psymtab.c (psymtab_storage): New constructor.
6593         (~psymtab_storage): New destructor.
6594         (require_partial_symbols): Update.
6595         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6596         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6597         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6598         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6599         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6600         (start_psymtab_common, end_psymtab_common)
6601         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6602         (allocate_psymtab): Update.
6603         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6604         Update.
6605         (dump_psymtab_addrmap, maintenance_print_psymbols)
6606         (maintenance_check_psymtabs): Update.
6607         (class objfile_psymtabs): Move to objfiles.h.
6608         * psympriv.h (discard_psymtab): Now inline.
6609         (psymtab_discarder::psymtab_discarder): Update.
6610         (psymtab_discarder::~psymtab_discarder): Update.
6611         (ALL_OBJFILE_PSYMTABS): Rewrite.
6612         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6613         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6614         Remove fields.
6615         <partial_symtabs>: New field.
6616         (class objfile_psymtabs): Move from psymtab.h.  Update.
6617         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6618         psymbol_cache.
6619         (objfile::~objfile): Don't destroy psymbol_cache.
6620         * mdebugread.c (parse_partial_symbols): Update.
6621         * dwarf2read.c (create_addrmap_from_index)
6622         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6623         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6624         (add_partial_subprogram, dwarf2_ranges_read): Update.
6625         * dwarf-index-write.c (write_address_map)
6626         (write_one_signatured_type, recursively_write_psymbols)
6627         (class debug_names, class debug_names, write_psymtabs_to_index):
6628         Update.
6629
6630 2019-01-10  Tom Tromey  <tom@tromey.com>
6631
6632         * symtab.h (SYMBOL_SET_NAMES): Update.
6633         (symbol_set_names): Update.
6634         (MSYMBOL_SET_NAMES): Update.
6635         * symtab.c (symbol_set_names): Change argument to be an
6636         objfile_per_bfd_storage.
6637         * psymtab.c (add_psymbol_to_bcache): Update.
6638         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6639
6640 2019-01-10  Tom Tromey  <tom@tromey.com>
6641
6642         * symtab.c (create_demangled_names_hash): Change argument to be an
6643         objfile_per_bfd_storage.
6644         (symbol_set_names): Update.
6645
6646 2019-01-10  Tom Tromey  <tom@tromey.com>
6647
6648         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6649         init_psymbol_list.
6650         * psymtab.c (init_psymbol_list): Do nothing if already called.
6651         * psympriv.h (init_psymbol_list): Add comment.
6652         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6653         init_psymbol_list.
6654         * dbxread.c (dbx_symfile_read): Unconditionally call
6655         init_psymbol_list.
6656
6657 2019-01-10  Tom Tromey  <tom@tromey.com>
6658
6659         * xcoffread.c (scan_xcoff_symtab): Update.
6660         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6661         "where".
6662         * mdebugread.c (parse_partial_symbols)
6663         (handle_psymbol_enumerators): Update.
6664         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6665         * dbxread.c (read_dbx_symtab): Update.
6666         * psympriv.h (psymbol_placement): New enum.
6667         (add_psymbol_to_list): Update.
6668
6669 2019-01-10  Tom Tromey  <tom@tromey.com>
6670
6671         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6672         static_psymbols parameters.
6673         (scan_xcoff_symtab): Update.
6674         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6675         static_psymbols parameters.
6676         * psympriv.h (start_psymtab_common): Update.
6677         * mdebugread.c (parse_partial_symbols): Update.
6678         * dwarf2read.c (create_partial_symtab): Update.
6679         * dbxread.c (read_dbx_symtab): Update.
6680         (start_psymtab): Remove global_psymbols and static_psymbols
6681         parameters.
6682
6683 2019-01-10  Tom Tromey  <tom@tromey.com>
6684
6685         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6686         * psymtab.c (allocate_psymtab): Add comment.
6687         * psympriv.h (allocate_psymtab): Add comment.
6688         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6689         initializations.
6690         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6691
6692 2019-01-10  Tom Tromey  <tom@tromey.com>
6693
6694         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6695         Don't declare.
6696         * mipsread.c: Include mdebugread.h.
6697         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6698         Declare.
6699         * elfread.c: Include mdebugread.h.
6700
6701 2019-01-09  Tom Tromey  <tom@tromey.com>
6702
6703         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6704         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6705         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6706         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6707         (psym_lookup_symbol, psym_find_last_source_symtab)
6708         (psym_forget_cached_source_info, psym_print_stats)
6709         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6710         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6711         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6712         (psym_find_compunit_symtab_by_address)
6713         (maintenance_print_psymbols, maintenance_info_psymtabs)
6714         (maintenance_check_psymtabs): Use ranged for.
6715         * psymtab.h (class objfile_psymtabs): New.
6716         (require_partial_symbols): Return objfile_psymtabs.
6717         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6718
6719 2019-01-09  Tom Tromey  <tom@tromey.com>
6720
6721         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6722         (find_pc_mapped_section, list_overlays_command)
6723         (map_overlay_command, unmap_overlay_command)
6724         (simple_overlay_update): Use all_objfiles.
6725         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6726         * printcmd.c (info_symbol_command): Use all_objfiles.
6727         * objfiles.h (ALL_OBJSECTIONS): Remove.
6728         * maint.c (maintenance_translate_address): Use all_objfiles.
6729         * gcore.c (gcore_create_callback): Use all_objfiles.
6730         (objfile_find_memory_regions): Likewise.
6731
6732 2019-01-09  Tom Tromey  <tom@tromey.com>
6733
6734         * symtab.c (find_line_symtab, info_sources_command)
6735         (make_source_files_completion_list): Use objfile_compunits.
6736         * source.c (select_source_symtab): Use objfile_compunits.
6737         * objfiles.h (struct objfile): Update comment.
6738         (ALL_OBJFILES): Remove.
6739         (ALL_FILETABS): Remove.
6740         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6741         objfile_compunits.
6742
6743 2019-01-09  Tom Tromey  <tom@tromey.com>
6744
6745         * symmisc.c (print_objfile_statistics, dump_objfile)
6746         (maintenance_print_symbols): Use compunit_filetabs.
6747         * source.c (forget_cached_source_info_for_objfile): Use
6748         compunit_filetabs.
6749         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6750         (ALL_FILETABS): Use compunit_filetabs.
6751         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6752         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6753
6754 2019-01-09  Tom Tromey  <tom@tromey.com>
6755
6756         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6757         (compunit_filetabs): New.
6758         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6759         compunit_filetabs.
6760         (info_sources_command, make_source_files_completion_list): Remove
6761         declaration.
6762         * symmisc.c (print_objfile_statistics, dump_objfile)
6763         (maintenance_print_symbols): Remove declaration.
6764         (maintenance_info_symtabs): Use compunit_filetabs.
6765         (maintenance_info_line_tables): Likewise.
6766         * source.c (select_source_symtab): Change local variable name.
6767         (forget_cached_source_info_for_objfile): Remove declaration.
6768         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6769         * objfiles.c (objfile_relocate1): Remove declaration.
6770         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6771         declaration.
6772         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6773         * coffread.c (coff_symtab_read): Remove declaration.
6774         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6775         compunit_filetabs.
6776
6777 2019-01-09  Tom Tromey  <tom@tromey.com>
6778
6779         * symtab.c (lookup_objfile_from_block)
6780         (find_pc_sect_compunit_symtab, search_symbols)
6781         (default_collect_symbol_completion_matches_break_on): Use
6782         objfile_compunits.
6783         * objfiles.h (ALL_COMPUNITS): Remove.
6784         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6785         * cp-support.c (add_symbol_overload_list_qualified): Use
6786         objfile_compunits.
6787         * ada-lang.c (ada_collect_symbol_completion_matches)
6788         (ada_add_global_exceptions): Use objfile_compunits.
6789
6790 2019-01-09  Tom Tromey  <tom@tromey.com>
6791
6792         * source.c (select_source_symtab)
6793         (forget_cached_source_info_for_objfile): Remove declaration.
6794         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6795         declaration.
6796         * maint.c (count_symtabs_and_blocks): Remove declaration.
6797         * cp-support.c (add_symbol_overload_list_qualified): Remove
6798         declaration.
6799         * coffread.c (coff_symtab_read): Remove declaration.
6800         * symtab.c (lookup_symbol_in_objfile_symtabs)
6801         (basic_lookup_transparent_type_1): Use objfile_compunits.
6802         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6803         (info_sources_command, search_symbols)
6804         (default_collect_symbol_completion_matches_break_on)
6805         (make_source_files_completion_list): Remove declaration.
6806         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6807         (ada_collect_symbol_completion_matches)
6808         (ada_add_global_exceptions): Remove declaration.
6809         * linespec.c (iterate_over_all_matching_symtabs): Use
6810         objfile_compunits.
6811         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6812         (class objfile_compunits): New.
6813         (ALL_COMPUNITS): Use objfile_compunits.
6814         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6815         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6816         objfile_compunits.
6817         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6818
6819 2019-01-09  Tom Tromey  <tom@tromey.com>
6820
6821         * symtab.c (search_symbols)
6822         (default_collect_symbol_completion_matches_break_on): Use
6823         objfile_msymbols.
6824         * ada-lang.c (ada_lookup_simple_minsym)
6825         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6826         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6827         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6828         objfile_msymbols.
6829         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6830         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6831         * objc-lang.c (find_methods): Use objfile_msymbols.
6832         (info_selectors_command, info_classes_command): Likewise.
6833         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6834         * objfiles.h (class objfile_msymbols): New.
6835         (ALL_OBJFILE_MSYMBOLS): Remove.
6836         (ALL_MSYMBOLS): Remove.
6837
6838 2019-01-09  Tom Tromey  <tom@tromey.com>
6839
6840         * common/next-iterator.h (next_adapter): Add Iterator template
6841         parameter.
6842         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6843         (class all_objfiles_safe): New.
6844         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6845         * objfiles.c (put_objfile_before): Update comment.
6846         (add_separate_debug_objfile): Likewise.
6847         (free_all_objfiles): Use all_objfiles_safe.
6848         (objfile_purge_solibs): Likewise.
6849
6850 2019-01-09  Tom Tromey  <tom@tromey.com>
6851
6852         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6853         (expand_symtab_containing_pc, lookup_static_symbol)
6854         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6855         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6856         all_objfiles.
6857         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6858         * breakpoint.c (create_overlay_event_breakpoint)
6859         (create_longjmp_master_breakpoint)
6860         (create_std_terminate_master_breakpoint)
6861         (create_exception_master_breakpoint): Use all_objfiles.
6862         * linux-thread-db.c (try_thread_db_load_from_pdir)
6863         (has_libpthread): Use all_objfiles.
6864         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6865         * linespec.c (iterate_over_all_matching_symtabs)
6866         (search_minsyms_for_name): Use all_objfiles.
6867         * maint.c (maintenance_info_sections): Use all_objfiles.
6868         * main.c (captured_main_1): Use all_objfiles.
6869         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6870         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6871         * guile/scm-pretty-print.c
6872         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6873         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6874         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6875         (maintenance_print_msymbols): Use all_objfiles.
6876         * source.c (select_source_symtab): Use all_objfiles.
6877         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6878         * symfile.c (remove_symbol_file_command)
6879         (expand_symtabs_matching, map_symbol_filenames): Use
6880         all_objfiles.
6881         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6882         all_objfiles.
6883         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6884         * objc-lang.c (find_methods): Use all_objfiles.
6885         * objfiles.c (have_partial_symbols, have_full_symbols)
6886         (have_minimal_symbols, qsort_cmp)
6887         (default_iterate_over_objfiles_in_search_order): Use
6888         all_objfiles.
6889         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6890         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6891         (maintenance_check_psymtabs): Use all_objfiles.
6892         (ALL_PSYMTABS): Remove.
6893         * compile/compile-object-run.c (do_module_cleanup): Use
6894         all_objfiles.
6895         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6896         * cp-support.c (add_symbol_overload_list_qualified): Use
6897         all_objfiles.
6898         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6899         Use all_objfiles.
6900         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6901         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6902         all_objfiles.
6903         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6904         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6905         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6906         Uses all_objfiles.
6907         * solib.c (solib_read_symbols): Use all_objfiles
6908
6909 2019-01-09  Tom Tromey  <tom@tromey.com>
6910
6911         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6912         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6913         all_objfiles.
6914         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6915         * symmisc.c (print_symbol_bcache_statistics)
6916         (print_objfile_statistics, maintenance_print_objfiles)
6917         (maintenance_info_symtabs, maintenance_check_symtabs)
6918         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6919         all_objfiles.
6920         * source.c (forget_cached_source_info): Use all_objfiles.
6921         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6922         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6923         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6924         * objfiles.c (update_section_map): Use all_objfiles.
6925         (shared_objfile_contains_address_p): Likewise.
6926         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6927         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6928
6929 2019-01-09  Tom Tromey  <tom@tromey.com>
6930
6931         * common/next-iterator.h: New file.
6932         * objfiles.h (class all_objfiles): New.
6933         (struct objfile_iterator): New.
6934
6935 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6936
6937         * NEWS: Move the description of the changed "frame", "select-frame",
6938          and "info frame" commands to the Changed commands section.
6939
6940 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6941
6942         * gdbtypes.c (check_stub_method_group): Remove handling of old
6943         mangling schemes.
6944         * linespec.c (find_methods): Likewise.
6945         * stabsread.c (read_member_functions): Likewise.
6946         * valops.c (search_struct_method): Likewise.
6947         (value_struct_elt_for_reference): Likewise.
6948         * NEWS: Mention this change.
6949
6950 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6951
6952         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6953         print_source_lines.
6954         * source.c (print_source_lines_base): Update line number check.
6955         (print_source_lines): New function.
6956         (source_lines_range::source_lines_range): New function.
6957         * source.h (class source_lines_range): New class.
6958         (print_source_lines): New declaration.
6959
6960 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6961
6962         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6963
6964 2019-01-08  Tom Tromey  <tom@tromey.com>
6965             Simon Marchi  <simon.marchi@ericsson.com>
6966
6967         PR gdb/24060
6968         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6969         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6970         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6971         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6972         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6973         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6974
6975 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6976
6977         * source.c (select_source_symtab): Move header comment to
6978         declaration in source.h.
6979         (forget_cached_source_info_for_objfile): Likewise.
6980         (forget_cached_source_info): Likewise.
6981         (identify_source_line): Likewise.
6982         * source.h (identify_source_line): Move declaration from symtab.h
6983         and add comment from source.c
6984         (print_source_lines): Likewise.
6985         (forget_cached_source_info_for_objfile): Likewise.
6986         (forget_cached_source_info): Likewise.
6987         (select_source_symtab): Likewise.
6988         (enum print_source_lines_flag): Move definition from symtab.h.
6989         * symtab.h (identify_source_line): Move declaration to source.h.
6990         (print_source_lines): Likewise.
6991         (forget_cached_source_info_for_objfile): Likewise.
6992         (forget_cached_source_info): Likewise.
6993         (select_source_symtab): Likewise.
6994         (enum print_source_lines_flag): Move definition to source.h.
6995         * tui/tui-hooks.c: Add 'source.h' include.
6996
6997 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6998
6999         * source.c (print_source_lines_base): Handle requests to print
7000         reverse line number sequences, and guard against empty lines
7001         string.
7002
7003 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7004
7005         * source.c (print_source_lines_base): Fix skip of '\r' if next
7006         character is '\n'.
7007
7008 2019-01-06  Tom Tromey  <tom@tromey.com>
7009
7010         * c-exp.y (struct c_parse_state) <macro_original_text,
7011         expansion_obstack>: New member.
7012         (macro_original_text, expansion_obstack): Remove globals.
7013         (scan_macro_expansion, scanning_macro_expansion)
7014         (finished_macro_expansion): Update.
7015         (scan_macro_cleanup): Remove.
7016         (yylex, c_parse): Update.
7017
7018 2019-01-06  Tom Tromey  <tom@tromey.com>
7019
7020         * c-exp.y (struct c_parse_state) <strings>: New member.
7021         (operator_stoken): Update.
7022
7023 2019-01-06  Tom Tromey  <tom@tromey.com>
7024
7025         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7026         (union type_stack_elt) <typelist_val>: Now a pointer to
7027         std::vector.
7028         (type_stack_cleanup): Don't declare.
7029         (push_typelist): Update.
7030         * parse.c (pop_typelist): Return a std::vector.
7031         (push_typelist): Take a std::vector.
7032         (follow_types): Update.  Do not free args.
7033         (type_stack_cleanup): Remove.
7034         * c-exp.y (struct c_parse_state): New.
7035         (cpstate): New global.
7036         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7037         (nonempty_typelist): Update.
7038         (func_mod): Create a new vector.
7039         (c_parse): Create a c_parse_state.
7040         (check_parameter_typelist): Do not delete params.
7041         (function_method): Update.  Do not delete type_list.
7042
7043 2019-01-06  Tom Tromey  <tom@tromey.com>
7044
7045         PR gdb/28155:
7046         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7047         check_typedef.
7048         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7049         (print_return_value): Likewise.
7050
7051 2019-01-05  Tom Tromey  <tom@tromey.com>
7052
7053         * contrib/cleanup_check.py: Remove.
7054         * contrib/gcc-with-excheck: Remove.
7055         * contrib/exsummary.py: Remove.
7056         * contrib/excheck.py: Remove.
7057
7058 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7059
7060         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7061         NULL. Initialize tpprev to NULL instead of assigning it
7062         to NULL on the next statement.
7063         * windows-nat.c (windows_delete_thread): Remove check for
7064         main_thread_id before printing thread exit notifications.
7065         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7066         Remove thread ID check against main_thread_id.
7067         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7068         windows_delete_thread.
7069         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7070
7071 2019-01-04  Tom Tromey  <tom@tromey.com>
7072
7073         * compile/compile.c (_initialize_compile): Use upper case for
7074         metasyntactic variables.
7075         * symmisc.c (_initialize_symmisc): Use upper case for
7076         metasyntactic variables.
7077         * psymtab.c (_initialize_psymtab): Use upper case for
7078         metasyntactic variables.
7079         * demangle.c (demangle_command): Use upper case for metasyntactic
7080         variables.
7081         (_initialize_demangler): Likewise.
7082         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7083         variables.
7084
7085 2019-01-03  Tom Tromey  <tom@tromey.com>
7086
7087         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7088
7089 2019-01-03  Tom Tromey  <tom@tromey.com>
7090
7091         * python/py-symtab.c (salpy_str): Update.
7092         (struct salpy_sal_object) <symtab>: Now a PyObject.
7093         (salpy_dealloc): Update.
7094         (del_objfile_sal): Use gdbpy_ref.
7095
7096 2019-01-03  Tom Tromey  <tom@tromey.com>
7097
7098         * python/py-type.c (convert_field): Use new_reference.  Return
7099         gdbpy_ref.
7100         (make_fielditem): Return gdbpy_ref.
7101         (typy_fields): Update.
7102         (typy_getitem): Update.
7103         (field_name): Return gdbpy_ref.  Use new_reference.
7104         (typy_iterator_iternext): Update.
7105
7106 2019-01-03  Tom Tromey  <tom@tromey.com>
7107
7108         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7109
7110 2019-01-03  Tom Tromey  <tom@tromey.com>
7111
7112         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7113         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7114         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7115         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7116         (pspy_set_type_printers): Likewise.
7117         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7118         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7119         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7120         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7121         (objfpy_set_type_printers): Likewise.
7122
7123 2019-01-03  Tom Tromey  <tom@tromey.com>
7124
7125         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7126         (gdbpy_print_stack): Use gdbpy_err_fetch.
7127         * python/python-internal.h (class gdbpy_err_fetch): New class.
7128         (class gdbpy_enter) <m_error_type, m_error_value,
7129         m_error_traceback>: Remove.
7130         <m_error>: New member.
7131         (gdbpy_exception_to_string): Don't declare.
7132         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7133         * python/py-value.c (convert_value_from_python): Use
7134         gdbpy_err_fetch.
7135         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7136         gdbpy_exception_to_string.
7137         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7138         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7139         gdbpy_err_fetch.
7140
7141 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7142
7143         * linux-nat.c (delete_lwp_cleanup): Delete.
7144         (struct lwp_deleter): New struct.
7145         (lwp_info_up): New typedef.
7146         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7147         lwp_info_up.
7148
7149 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7150
7151         * linux-fork.c (class scoped_switch_fork_info): New class.
7152         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7153
7154 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7155
7156         * valops.c (find_overload_match): Remove use of null_cleanup, and
7157         calls to do_cleanups.
7158
7159 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7160
7161         * compile/compile-cplus-types.c
7162         (compile_cplus_instance::decl_name): Handle changes to
7163         cp_func_name.
7164         * cp-support.c (cp_func_name): Update header comment, update
7165         return type.
7166         * cp-support.h (cp_func_name): Update return type in declaration.
7167         * valops.c (find_overload_match): Move temp_func local to top
7168         level of function and change its type.  Use temp_func to hold and
7169         delete temporary string obtained from cp_func_name.
7170
7171 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7172
7173         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7174         gdb::char_vector, remove cleanup, and update uses of `msg`.
7175
7176 2019-01-03  Jim Wilson  <jimw@sifive.com>
7177
7178         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7179
7180 2019-01-02  Tom Tromey  <tom@tromey.com>
7181
7182         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7183         (tdesc_parse_xml): Remove cleanups.
7184         * target-descriptions.h (make_cleanup_free_target_description):
7185         Don't declare.
7186         (target_desc_deleter): New struct.
7187         (target_desc_up): New typedef.
7188         * target-descriptions.c (target_desc_deleter::operator()): Rename
7189         from free_target_description.
7190         (make_cleanup_free_target_description): Remove.
7191
7192 2019-01-02  Tom Tromey  <tom@tromey.com>
7193
7194         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7195         constructor, destructor.
7196         (linespec_parser): Remove typedef.
7197         (~linespec_parser): Rename from linespec_parser_delete.
7198         (linespec_lex_to_end, linespec_complete_label)
7199         (linespec_complete): Update.
7200         (decode_line_full): Remove cleanups.
7201         (decode_line_1): Update.
7202
7203 2019-01-02  Tom Tromey  <tom@tromey.com>
7204
7205         * python/python-internal.h (inferior_to_inferior_object): Change
7206         return type.
7207         * python/py-exitedevent.c (create_exited_event_object): Update.
7208         * python/py-inferior.c (inferior_to_inferior_object): Return
7209         gdbpy_ref.
7210         (python_new_inferior, python_inferior_deleted)
7211         (thread_to_thread_object, delete_thread_object)
7212         (build_inferior_list, gdbpy_selected_inferior): Update.
7213         * python/py-infthread.c (create_thread_object): Update.  Also fail
7214         if inferior_to_inferior_object fails.
7215
7216 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7217
7218         * inferior.h (class inferior) <displaced_step_state>: New field.
7219         * infrun.h (struct displaced_step_state): Move here from
7220         infrun.c.  Initialize fields, add constructor.
7221         <inf>: Remove field.
7222         <reset>: New method.
7223         * infrun.c (struct displaced_step_inferior_state): Move to
7224         infrun.h.
7225         (displaced_step_inferior_states): Remove.
7226         (get_displaced_stepping_state): Adust.
7227         (displaced_step_in_progress_any_inferior): Adjust.
7228         (displaced_step_in_progress_thread): Adjust.
7229         (displaced_step_in_progress): Adjust.
7230         (add_displaced_stepping_state): Remove.
7231         (get_displaced_step_closure_by_addr): Adjust.
7232         (remove_displaced_stepping_state): Remove.
7233         (infrun_inferior_exit): Call displaced_step_state.reset.
7234         (use_displaced_stepping): Don't check for NULL.
7235         (displaced_step_prepare_throw): Call
7236         get_displaced_stepping_state.
7237         (displaced_step_fixup): Don't check for NULL.
7238         (prepare_for_detach): Don't check for NULL.
7239
7240 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7241
7242         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7243          in case of call that did not complete.
7244
7245 2019-01-02  Andrey Utkin  <autkin@undo.io>
7246
7247         * symfile.c (find_separate_debug_file): Fix search of debug files for
7248         remote debuggee.
7249
7250 2019-01-02  Tom Tromey  <tom@tromey.com>
7251
7252         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7253         indentation.
7254         * python/py-frame.c (frapy_older): Remove cast.
7255         (frapy_newer): Likewise.
7256         * python/py-breakpoint.c (local_setattro): Remove cast.
7257         * python/py-arch.c (archpy_name): Remove local variable.
7258         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7259
7260 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7261
7262         * unittests/basic_string_view/element_access/char/empty.cc:
7263         Fix year range in copyright header.
7264
7265 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7266
7267         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7268         Delete.
7269         <operator==>: Update with for removed field.
7270         <hash>: Likewise.
7271         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7272         <isa_features>: ...this.
7273         <abi_features>: New field.
7274         (riscv_isa_flen): Update comment.
7275         (riscv_abi_xlen): New declaration.
7276         (riscv_abi_flen): New declaration.
7277         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7278         isa_features.
7279         (riscv_abi_xlen): New function.
7280         (riscv_isa_flen): Update to get answer from isa_features.
7281         (riscv_abi_flen): New function.
7282         (riscv_has_fp_abi): Update to get answer from abi_features.
7283         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7284         xlen and flen.
7285         (riscv_call_info) <xlen, flen>: Update comment.
7286         (riscv_call_arg_struct): Remove invalid assertions
7287         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7288         is removed.
7289         (riscv_gdbarch_init): Gather isa features and abi features
7290         separately, ensure both match on the gdbarch when reusing an old
7291         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7292         a target with 64-bit float hardware.
7293
7294 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7295
7296         * source.c (search_command_helper): Stop reverse search
7297         when line 1 has been searched.
7298
7299 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7300
7301         * record-full.c (record_full_base_target::close): Rewrite
7302         record_full_core_buf_list free logic.
7303
7304 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7305
7306         * break-catch-syscall.c (print_one_catch_syscall): xfree
7307         the last text.
7308
7309 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7310
7311         * top.c (print_gdb_version): Update Copyright year in version
7312         message.
7313
7314 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7315
7316         Update copyright year range in all GDB files.
7317
7318 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7319
7320         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7321
7322 For older changes see ChangeLog-2018.
7323 \f
7324 Local Variables:
7325 mode: change-log
7326 left-margin: 8
7327 fill-column: 74
7328 version-control: never
7329 coding: utf-8
7330 End:
7331